[webkit-changes] [127558] trunk/Source
Title: [127558] trunk/Source Revision 127558 Author kei...@webkit.org Date 2012-09-04 23:35:41 -0700 (Tue, 04 Sep 2012) Log Message Move PagePopupClient implementation for input[type=date] to Chromium WebKit layer https://bugs.webkit.org/show_bug.cgi?id=95681 Reviewed by Kent Tamura. Source/WebCore: We are moving calendar picker PagePopupClient to WebKit layer so ports can use their platform native chooser UI if they have one. DateTimeChooser, DateTimeChooserClient etc. will be reused when we implement the week picker and month picker. No new tests. No behavior change. Covered by existing calendar picker tests. * WebCore.gypi: * html/shadow/CalendarPickerElement.cpp: (WebCore::CalendarPickerElement::CalendarPickerElement): (WebCore::CalendarPickerElement::~CalendarPickerElement): (WebCore::CalendarPickerElement::didChooseValue): Called when user chose a value. (WebCore): (WebCore::CalendarPickerElement::didEndChooser): Called when chooser has ended. (WebCore::CalendarPickerElement::openPopup): (WebCore::CalendarPickerElement::closePopup): * html/shadow/CalendarPickerElement.h: (CalendarPickerElement): * loader/EmptyClients.cpp: (WebCore): (WebCore::EmptyChromeClient::openDateTimeChooser): * loader/EmptyClients.h: (EmptyChromeClient): * page/ChromeClient.h: (WebCore): (ChromeClient): * platform/DateTimeChooser.h: (WebCore): (DateTimeChooserParameters): Contains information needed to open the DateTimeChooser. (DateTimeChooser): (WebCore::DateTimeChooser::~DateTimeChooser): * platform/DateTimeChooserClient.h: (WebCore): (DateTimeChooserClient): (WebCore::DateTimeChooserClient::~DateTimeChooserClient): Source/WebKit/chromium: * WebKit.gyp: * src/ChromeClientImpl.cpp: (WebKit): (WebKit::ChromeClientImpl::openDateTimeChooser): * src/ChromeClientImpl.h: (WebCore): (ChromeClientImpl): * src/DateTimeChooserImpl.cpp: Added. (WebKit): (WebKit::DateTimeChooserImpl::DateTimeChooserImpl): (WebKit::DateTimeChooserImpl::~DateTimeChooserImpl): (WebKit::DateTimeChooserImpl::endChooser): (WebKit::DateTimeChooserImpl::contentSize): (WebKit::DateTimeChooserImpl::writeDocument): (WebKit::DateTimeChooserImpl::setValueAndClosePopup): (WebKit::DateTimeChooserImpl::didClosePopup): * src/DateTimeChooserImpl.h: (WebCore): (WebKit): (DateTimeChooserImpl): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/WebCore.gypi trunk/Source/WebCore/html/shadow/CalendarPickerElement.cpp trunk/Source/WebCore/html/shadow/CalendarPickerElement.h trunk/Source/WebCore/loader/EmptyClients.cpp trunk/Source/WebCore/loader/EmptyClients.h trunk/Source/WebCore/page/ChromeClient.h trunk/Source/WebKit/chromium/ChangeLog trunk/Source/WebKit/chromium/WebKit.gyp trunk/Source/WebKit/chromium/src/ChromeClientImpl.cpp trunk/Source/WebKit/chromium/src/ChromeClientImpl.h Added Paths trunk/Source/WebCore/platform/DateTimeChooser.h trunk/Source/WebCore/platform/DateTimeChooserClient.h trunk/Source/WebKit/chromium/src/DateTimeChooserImpl.cpp trunk/Source/WebKit/chromium/src/DateTimeChooserImpl.h Diff Modified: trunk/Source/WebCore/ChangeLog (127557 => 127558) --- trunk/Source/WebCore/ChangeLog 2012-09-05 06:28:26 UTC (rev 127557) +++ trunk/Source/WebCore/ChangeLog 2012-09-05 06:35:41 UTC (rev 127558) @@ -1,3 +1,46 @@ +2012-09-04 Keishi Hattori + +Move PagePopupClient implementation for input[type=date] to Chromium WebKit layer +https://bugs.webkit.org/show_bug.cgi?id=95681 + +Reviewed by Kent Tamura. + +We are moving calendar picker PagePopupClient to WebKit layer so ports +can use their platform native chooser UI if they have one. +DateTimeChooser, DateTimeChooserClient etc. will be reused when we +implement the week picker and month picker. + +No new tests. No behavior change. Covered by existing calendar picker tests. + +* WebCore.gypi: +* html/shadow/CalendarPickerElement.cpp: +(WebCore::CalendarPickerElement::CalendarPickerElement): +(WebCore::CalendarPickerElement::~CalendarPickerElement): +(WebCore::CalendarPickerElement::didChooseValue): Called when user chose a value. +(WebCore): +(WebCore::CalendarPickerElement::didEndChooser): Called when chooser has ended. +(WebCore::CalendarPickerElement::openPopup): +(WebCore::CalendarPickerElement::closePopup): +* html/shadow/CalendarPickerElement.h: +(CalendarPickerElement): +* loader/EmptyClients.cpp: +(WebCore): +(WebCore::EmptyChromeClient::openDateTimeChooser): +* loader/EmptyClients.h: +(EmptyChromeClient): +* page/ChromeClient.h: +(WebCore): +(ChromeClient): +* platform/DateTimeChooser.h: +(WebCore): +(DateTimeChooserParameters): Contains information needed to open the DateTimeChooser. +(DateTimeChooser): +(WebCore::DateTimeChooser::~DateTimeChooser): +* platform/DateTimeChooserClient.h: +(WebCore): +
[webkit-changes] [127557] trunk
Title: [127557] trunk
Revision 127557
Author mikelawt...@chromium.org
Date 2012-09-04 23:28:26 -0700 (Tue, 04 Sep 2012)
Log Message
CSS3 calc: expressions with 'em' units do not zoom correctly.
https://bugs.webkit.org/show_bug.cgi?id=95705
Reviewed by Ojan Vafai.
Source/WebCore:
Each primitive value in a CSS calc _expression_ now has (zoom) multiplier and scale factor applied
independently. Previously the multiplier and a single scale factor was applied to the _expression_
as a whole, but this failed to account for expressions involving font relative units. This is
because the multiplier should not be applied to font relative units.
Test: css3/calc/zoom-with-em.html
* css/CSSPrimitiveValue.cpp:
(WebCore::CSSPrimitiveValue::computeLengthDouble):
LayoutTests:
* css3/calc/zoom-with-em-expected.txt: Added.
* css3/calc/zoom-with-em.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/CSSPrimitiveValue.cpp
Added Paths
trunk/LayoutTests/css3/calc/zoom-with-em-expected.txt
trunk/LayoutTests/css3/calc/zoom-with-em.html
Diff
Modified: trunk/LayoutTests/ChangeLog (127556 => 127557)
--- trunk/LayoutTests/ChangeLog 2012-09-05 06:07:18 UTC (rev 127556)
+++ trunk/LayoutTests/ChangeLog 2012-09-05 06:28:26 UTC (rev 127557)
@@ -1,3 +1,13 @@
+2012-09-04 Mike Lawther
+
+CSS3 calc: expressions with 'em' units do not zoom correctly.
+https://bugs.webkit.org/show_bug.cgi?id=95705
+
+Reviewed by Ojan Vafai.
+
+* css3/calc/zoom-with-em-expected.txt: Added.
+* css3/calc/zoom-with-em.html: Added.
+
2012-09-04 Keishi Hattori
REGRESSION(r126132): MediaSlider and MediaVolumeSlider thumbs don't match mouse when dragged
Added: trunk/LayoutTests/css3/calc/zoom-with-em-expected.txt (0 => 127557)
--- trunk/LayoutTests/css3/calc/zoom-with-em-expected.txt (rev 0)
+++ trunk/LayoutTests/css3/calc/zoom-with-em-expected.txt 2012-09-05 06:28:26 UTC (rev 127557)
@@ -0,0 +1,19 @@
+Tests that zooming a calc _expression_ containing 'em' units works correctly
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+PASS 310 is 310
+PASS 310 is 310
+PASS 310 is 310
+PASS 310 is 310
+PASS 310 is 310
+PASS 311 is 311
+PASS 310 is 310
+PASS 310 is 310
+PASS 310 is 310
+PASS 310 is 310
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
Added: trunk/LayoutTests/css3/calc/zoom-with-em.html (0 => 127557)
--- trunk/LayoutTests/css3/calc/zoom-with-em.html (rev 0)
+++ trunk/LayoutTests/css3/calc/zoom-with-em.html 2012-09-05 06:28:26 UTC (rev 127557)
@@ -0,0 +1,22 @@
+
+
+ .test { display: height: 10px; background: #ddf; font: 20px/1 Ahem; }
+ #nocalc { width: 310px; }
+ #calc { width: -webkit-calc(15em + 10px); width: -moz-calc(15em + 10px); width: calc(15em + 10px); }
+
+
+
+