[webkit-changes] [127440] trunk/Source/WebCore
Title: [127440] trunk/Source/WebCore
Revision 127440
Author hausm...@webkit.org
Date 2012-09-03 23:37:37 -0700 (Mon, 03 Sep 2012)
Log Message
[Qt] Port the Qt pixmap JS bindings to use the JSC C API
https://bugs.webkit.org/show_bug.cgi?id=94702
Reviewed by Kenneth Rohde Christiansen.
Based on patch by Noam Rosenthal.
The conversion uses a simple JSClassRef based binding and only a few
uses of private JSC API for the HTML element DOM bindings remain.
This is essentially used for wrapping QPixmap and QImage types in
_javascript_ and the other way around, for retrieving the image data
out of a HTML image element when converting from JS/DOM to Qt.
* bridge/qt/qt_pixmapruntime.cpp:
(JSC::Bindings::copyPixels):
(JSC::Bindings::toPixmap):
(JSC::Bindings::toImage):
(JSC::Bindings::imageSizeForVariant):
(JSC::Bindings::getPixmapWidth):
(JSC::Bindings::getPixmapHeight):
(JSC::Bindings::assignToHTMLImageElement):
(JSC::Bindings::pixmapToImageData):
(JSC::Bindings::pixmapToDataUrl):
(JSC::Bindings::pixmapToString):
(JSC::Bindings::QtPixmapRuntime::toJS):
(JSC::Bindings::QtPixmapRuntime::toQt):
(JSC::Bindings::QtPixmapRuntime::canHandle):
(JSC::Bindings::QtPixmapRuntime::getClassRef):
* bridge/qt/qt_pixmapruntime.h:
(QtPixmapRuntime):
* bridge/qt/qt_runtime.cpp:
(JSC::Bindings::convertValueToQVariant):
(JSC::Bindings::convertQVariantToValue):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bridge/qt/qt_pixmapruntime.cpp
trunk/Source/WebCore/bridge/qt/qt_pixmapruntime.h
trunk/Source/WebCore/bridge/qt/qt_runtime.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (127439 => 127440)
--- trunk/Source/WebCore/ChangeLog 2012-09-04 05:26:08 UTC (rev 127439)
+++ trunk/Source/WebCore/ChangeLog 2012-09-04 06:37:37 UTC (rev 127440)
@@ -1,3 +1,40 @@
+2012-08-31 Simon Hausmann simon.hausm...@nokia.com
+
+[Qt] Port the Qt pixmap JS bindings to use the JSC C API
+https://bugs.webkit.org/show_bug.cgi?id=94702
+
+Reviewed by Kenneth Rohde Christiansen.
+
+Based on patch by Noam Rosenthal.
+
+The conversion uses a simple JSClassRef based binding and only a few
+uses of private JSC API for the HTML element DOM bindings remain.
+
+This is essentially used for wrapping QPixmap and QImage types in
+_javascript_ and the other way around, for retrieving the image data
+out of a HTML image element when converting from JS/DOM to Qt.
+
+* bridge/qt/qt_pixmapruntime.cpp:
+(JSC::Bindings::copyPixels):
+(JSC::Bindings::toPixmap):
+(JSC::Bindings::toImage):
+(JSC::Bindings::imageSizeForVariant):
+(JSC::Bindings::getPixmapWidth):
+(JSC::Bindings::getPixmapHeight):
+(JSC::Bindings::assignToHTMLImageElement):
+(JSC::Bindings::pixmapToImageData):
+(JSC::Bindings::pixmapToDataUrl):
+(JSC::Bindings::pixmapToString):
+(JSC::Bindings::QtPixmapRuntime::toJS):
+(JSC::Bindings::QtPixmapRuntime::toQt):
+(JSC::Bindings::QtPixmapRuntime::canHandle):
+(JSC::Bindings::QtPixmapRuntime::getClassRef):
+* bridge/qt/qt_pixmapruntime.h:
+(QtPixmapRuntime):
+* bridge/qt/qt_runtime.cpp:
+(JSC::Bindings::convertValueToQVariant):
+(JSC::Bindings::convertQVariantToValue):
+
2012-09-03 Andreas Kling kl...@webkit.org
Share immutable ElementAttributeData between elements with identical attributes.
Modified: trunk/Source/WebCore/bridge/qt/qt_pixmapruntime.cpp (127439 => 127440)
--- trunk/Source/WebCore/bridge/qt/qt_pixmapruntime.cpp 2012-09-04 05:26:08 UTC (rev 127439)
+++ trunk/Source/WebCore/bridge/qt/qt_pixmapruntime.cpp 2012-09-04 06:37:37 UTC (rev 127440)
@@ -19,6 +19,7 @@
#include config.h
#include qt_pixmapruntime.h
+#include APICast.h
#include CachedImage.h
#include HTMLImageElement.h
#include ImageData.h
@@ -27,8 +28,8 @@
#include JSGlobalObject.h
#include JSHTMLImageElement.h
#include JSImageData.h
-#include JSLock.h
-#include ObjectPrototype.h
+#include JSRetainPtr.h
+#include _javascript_.h
#include StillImageQt.h
#include QtEndian
#include QBuffer
@@ -37,399 +38,237 @@
#include QImage
#include QPixmap
#include QVariant
-#include runtime_method.h
-#include runtime_object.h
-#include runtime_root.h
-#include runtime/FunctionPrototype.h
using namespace WebCore;
namespace JSC {
namespace Bindings {
-class QtPixmapClass : public Class {
-public:
-QtPixmapClass();
-virtual MethodList methodsNamed(PropertyName, Instance*) const;
-virtual Field* fieldNamed(PropertyName, Instance*) const;
-};
-
-
-class QtPixmapWidthField : public Field {
-public:
-static const char* name() { return width; }
-virtual JSValue valueFromInstance(ExecState*, const Instance* instance) const
-{
-return jsNumber(static_castconst QtPixmapInstance*(instance)-width());
-}
-virtual void setValueToInstance(ExecState*, const Instance*, JSValue) const {}
[webkit-changes] [127441] releases/WebKitGTK/webkit-1.10
Title: [127441] releases/WebKitGTK/webkit-1.10 Revision 127441 Author carlo...@webkit.org Date 2012-09-04 00:08:33 -0700 (Tue, 04 Sep 2012) Log Message Merge r127228 - Unreviewed, rolling out r126127. http://trac.webkit.org/changeset/126127 This breaks gobject bindings. Source/WebCore: * dom/Attr.cpp: (WebCore::Attr::cloneNode): * dom/Attr.h: * dom/CDATASection.cpp: (WebCore::CDATASection::cloneNode): * dom/CDATASection.h: (CDATASection): * dom/Comment.cpp: (WebCore::Comment::cloneNode): * dom/Comment.h: (Comment): * dom/Document.cpp: (WebCore::Document::cloneNode): * dom/Document.h: (Document): * dom/DocumentFragment.cpp: (WebCore::DocumentFragment::cloneNode): * dom/DocumentFragment.h: (DocumentFragment): * dom/DocumentType.cpp: (WebCore::DocumentType::cloneNode): * dom/DocumentType.h: (DocumentType): * dom/Element.cpp: (WebCore::Element::cloneNode): * dom/Element.h: (Element): * dom/EntityReference.cpp: (WebCore::EntityReference::cloneNode): * dom/EntityReference.h: (EntityReference): * dom/Node.h: (Node): * dom/Node.idl: * dom/Notation.cpp: (WebCore::Notation::cloneNode): * dom/Notation.h: (Notation): * dom/ProcessingInstruction.cpp: (WebCore::ProcessingInstruction::cloneNode): * dom/ProcessingInstruction.h: (ProcessingInstruction): * dom/ShadowRoot.cpp: (WebCore::ShadowRoot::cloneNode): * dom/ShadowRoot.h: (ShadowRoot): * dom/Text.cpp: (WebCore::Text::cloneNode): * dom/Text.h: (Text): LayoutTests: * fast/dom/shadow/shadowroot-clonenode-expected.txt: Removed. * fast/dom/shadow/shadowroot-clonenode.html: Removed. Modified Paths releases/WebKitGTK/webkit-1.10/LayoutTests/ChangeLog releases/WebKitGTK/webkit-1.10/Source/WebCore/ChangeLog releases/WebKitGTK/webkit-1.10/Source/WebCore/dom/Attr.cpp releases/WebKitGTK/webkit-1.10/Source/WebCore/dom/Attr.h releases/WebKitGTK/webkit-1.10/Source/WebCore/dom/CDATASection.cpp releases/WebKitGTK/webkit-1.10/Source/WebCore/dom/CDATASection.h releases/WebKitGTK/webkit-1.10/Source/WebCore/dom/Comment.cpp releases/WebKitGTK/webkit-1.10/Source/WebCore/dom/Comment.h releases/WebKitGTK/webkit-1.10/Source/WebCore/dom/Document.cpp releases/WebKitGTK/webkit-1.10/Source/WebCore/dom/Document.h releases/WebKitGTK/webkit-1.10/Source/WebCore/dom/DocumentFragment.cpp releases/WebKitGTK/webkit-1.10/Source/WebCore/dom/DocumentFragment.h releases/WebKitGTK/webkit-1.10/Source/WebCore/dom/DocumentType.cpp releases/WebKitGTK/webkit-1.10/Source/WebCore/dom/DocumentType.h releases/WebKitGTK/webkit-1.10/Source/WebCore/dom/Element.cpp releases/WebKitGTK/webkit-1.10/Source/WebCore/dom/Element.h releases/WebKitGTK/webkit-1.10/Source/WebCore/dom/EntityReference.cpp releases/WebKitGTK/webkit-1.10/Source/WebCore/dom/EntityReference.h releases/WebKitGTK/webkit-1.10/Source/WebCore/dom/Node.h releases/WebKitGTK/webkit-1.10/Source/WebCore/dom/Node.idl releases/WebKitGTK/webkit-1.10/Source/WebCore/dom/Notation.cpp releases/WebKitGTK/webkit-1.10/Source/WebCore/dom/Notation.h releases/WebKitGTK/webkit-1.10/Source/WebCore/dom/ProcessingInstruction.cpp releases/WebKitGTK/webkit-1.10/Source/WebCore/dom/ProcessingInstruction.h releases/WebKitGTK/webkit-1.10/Source/WebCore/dom/ShadowRoot.cpp releases/WebKitGTK/webkit-1.10/Source/WebCore/dom/ShadowRoot.h releases/WebKitGTK/webkit-1.10/Source/WebCore/dom/Text.cpp releases/WebKitGTK/webkit-1.10/Source/WebCore/dom/Text.h Removed Paths releases/WebKitGTK/webkit-1.10/LayoutTests/fast/dom/shadow/shadowroot-clonenode-expected.txt releases/WebKitGTK/webkit-1.10/LayoutTests/fast/dom/shadow/shadowroot-clonenode.html Diff Modified: releases/WebKitGTK/webkit-1.10/LayoutTests/ChangeLog (127440 => 127441) --- releases/WebKitGTK/webkit-1.10/LayoutTests/ChangeLog 2012-09-04 06:37:37 UTC (rev 127440) +++ releases/WebKitGTK/webkit-1.10/LayoutTests/ChangeLog 2012-09-04 07:08:33 UTC (rev 127441) @@ -1,3 +1,13 @@ +2012-08-30 MORITA Hajime morr...@google.com + +Unreviewed, rolling out r126127. +http://trac.webkit.org/changeset/126127 + +This breaks gobject bindings. + +* fast/dom/shadow/shadowroot-clonenode-expected.txt: Removed. +* fast/dom/shadow/shadowroot-clonenode.html: Removed. + 2012-08-23 Zan Dobersek zandober...@gmail.com Unreviewed GTK gardening. Deleted: releases/WebKitGTK/webkit-1.10/LayoutTests/fast/dom/shadow/shadowroot-clonenode-expected.txt (127440 => 127441) --- releases/WebKitGTK/webkit-1.10/LayoutTests/fast/dom/shadow/shadowroot-clonenode-expected.txt 2012-09-04 06:37:37 UTC (rev 127440) +++ releases/WebKitGTK/webkit-1.10/LayoutTests/fast/dom/shadow/shadowroot-clonenode-expected.txt 2012-09-04 07:08:33 UTC (rev 127441) @@ -1,10 +0,0 @@ -Calling ShadowRoot.cloneNode() should throw a DATA_CLONE_ERR exception. - -On success, you will see a series of PASS messages, followed by TEST COMPLETE. - - -PASS exceptionCode is DOMException.DATA_CLONE_ERR -PASS successfullyParsed is true - -TEST COMPLETE - Deleted:
[webkit-changes] [127443] trunk/Source/WebCore
Title: [127443] trunk/Source/WebCore
Revision 127443
Author loi...@chromium.org
Date 2012-09-04 01:19:02 -0700 (Tue, 04 Sep 2012)
Log Message
Web Inspector: NMI: cosmetic change, rename m_domMemoryUsage to m_memoryInstrumentation.
https://bugs.webkit.org/show_bug.cgi?id=95716
Also m_memoryInstrumentation became a reference to external object because it has other life time than domNodeVisitor.
Reviewed by Yury Semikhatsky.
* inspector/InspectorMemoryAgent.cpp:
(WebCore):
(WebCore::collectDomTreeInfo):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/InspectorMemoryAgent.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (127442 => 127443)
--- trunk/Source/WebCore/ChangeLog 2012-09-04 07:25:38 UTC (rev 127442)
+++ trunk/Source/WebCore/ChangeLog 2012-09-04 08:19:02 UTC (rev 127443)
@@ -1,3 +1,16 @@
+2012-09-04 Ilya Tikhonovsky loi...@chromium.org
+
+Web Inspector: NMI: cosmetic change, rename m_domMemoryUsage to m_memoryInstrumentation.
+https://bugs.webkit.org/show_bug.cgi?id=95716
+
+Also m_memoryInstrumentation became a reference to external object because it has other life time than domNodeVisitor.
+
+Reviewed by Yury Semikhatsky.
+
+* inspector/InspectorMemoryAgent.cpp:
+(WebCore):
+(WebCore::collectDomTreeInfo):
+
2012-08-31 Simon Hausmann simon.hausm...@nokia.com
[Qt] Port the Qt pixmap JS bindings to use the JSC C API
Modified: trunk/Source/WebCore/inspector/InspectorMemoryAgent.cpp (127442 => 127443)
--- trunk/Source/WebCore/inspector/InspectorMemoryAgent.cpp 2012-09-04 07:25:38 UTC (rev 127442)
+++ trunk/Source/WebCore/inspector/InspectorMemoryAgent.cpp 2012-09-04 08:19:02 UTC (rev 127443)
@@ -451,9 +451,9 @@
class DOMTreesIterator : public NodeWrapperVisitor {
public:
-DOMTreesIterator(Page* page, VisitedObjects visitedObjects)
+DOMTreesIterator(Page* page, MemoryInstrumentationImpl memoryInstrumentation)
: m_page(page)
-, m_domMemoryUsage(visitedObjects)
+, m_memoryInstrumentation(memoryInstrumentation)
{
}
@@ -462,22 +462,22 @@
if (node-document() node-document()-frame() m_page != node-document()-frame()-page())
return;
-m_domMemoryUsage.addRootObject(node);
+m_memoryInstrumentation.addRootObject(node);
}
void visitFrame(Frame* frame)
{
-m_domMemoryUsage.addRootObject(frame);
+m_memoryInstrumentation.addRootObject(frame);
}
void visitBindings()
{
-ScriptProfiler::collectBindingMemoryInfo(m_domMemoryUsage);
+ScriptProfiler::collectBindingMemoryInfo(m_memoryInstrumentation);
}
void visitMemoryCache()
{
-m_domMemoryUsage.addRootObject(memoryCache());
+m_memoryInstrumentation.addRootObject(memoryCache());
}
PassRefPtrInspectorMemoryBlock buildObjectForMemoryCache() const
@@ -486,18 +486,18 @@
COMPILE_ASSERT(MemoryInstrumentation::LastTypeEntry == MemoryInstrumentation::CachedResourceXSLT + 1, object_type_enum_was_changed_please_fix_the_implementation);
for (int i = MemoryInstrumentation::MemoryCacheStructures; i MemoryInstrumentation::LastTypeEntry; ++i)
-totalSize += m_domMemoryUsage.totalSize(static_castMemoryInstrumentation::ObjectType(i));
+totalSize += m_memoryInstrumentation.totalSize(static_castMemoryInstrumentation::ObjectType(i));
RefPtrTypeBuilder::ArrayInspectorMemoryBlock children = TypeBuilder::ArrayInspectorMemoryBlock::create();
-addMemoryBlockFor(children.get(), m_domMemoryUsage.totalSize(MemoryInstrumentation::MemoryCacheStructures), MemoryBlockName::memoryCacheStructures);
-addMemoryBlockFor(children.get(), m_domMemoryUsage.totalSize(MemoryInstrumentation::CachedResource), MemoryBlockName::cachedResource);
-addMemoryBlockFor(children.get(), m_domMemoryUsage.totalSize(MemoryInstrumentation::CachedResourceCSS), MemoryBlockName::cachedResourceCSS);
-addMemoryBlockFor(children.get(), m_domMemoryUsage.totalSize(MemoryInstrumentation::CachedResourceFont), MemoryBlockName::cachedResourceFont);
-addMemoryBlockFor(children.get(), m_domMemoryUsage.totalSize(MemoryInstrumentation::CachedResourceImage), MemoryBlockName::cachedResourceImage);
-addMemoryBlockFor(children.get(), m_domMemoryUsage.totalSize(MemoryInstrumentation::CachedResourceScript), MemoryBlockName::cachedResourceScript);
-addMemoryBlockFor(children.get(), m_domMemoryUsage.totalSize(MemoryInstrumentation::CachedResourceSVG), MemoryBlockName::cachedResourceSVG);
-addMemoryBlockFor(children.get(), m_domMemoryUsage.totalSize(MemoryInstrumentation::CachedResourceShader), MemoryBlockName::cachedResourceShader);
-addMemoryBlockFor(children.get(), m_domMemoryUsage.totalSize(MemoryInstrumentation::CachedResourceXSLT), MemoryBlockName::cachedResourceXSLT);
+
[webkit-changes] [127445] trunk/Source/WebKit/blackberry
Title: [127445] trunk/Source/WebKit/blackberry Revision 127445 Author mary...@torchmobile.com.cn Date 2012-09-04 01:38:04 -0700 (Tue, 04 Sep 2012) Log Message [BlackBerry] Add webplatform and browser to build info https://bugs.webkit.org/show_bug.cgi?id=95715 Reviewed by George Staikos. PR# 202102 * WebKitSupport/AboutData.cpp: (BlackBerry::WebKit::buildPage): Modified Paths trunk/Source/WebKit/blackberry/ChangeLog trunk/Source/WebKit/blackberry/WebKitSupport/AboutData.cpp Diff Modified: trunk/Source/WebKit/blackberry/ChangeLog (127444 => 127445) --- trunk/Source/WebKit/blackberry/ChangeLog 2012-09-04 08:27:24 UTC (rev 127444) +++ trunk/Source/WebKit/blackberry/ChangeLog 2012-09-04 08:38:04 UTC (rev 127445) @@ -1,3 +1,15 @@ +2012-09-04 Mary Wu mary...@torchmobile.com.cn + +[BlackBerry] Add webplatform and browser to build info +https://bugs.webkit.org/show_bug.cgi?id=95715 + +Reviewed by George Staikos. + +PR# 202102 + +* WebKitSupport/AboutData.cpp: +(BlackBerry::WebKit::buildPage): + 2012-08-31 Jacky Jiang zhaji...@rim.com [BlackBerry] ASSERT failure in RenderBlock::checkPositionedObjectsNeedLayout Modified: trunk/Source/WebKit/blackberry/WebKitSupport/AboutData.cpp (127444 => 127445) --- trunk/Source/WebKit/blackberry/WebKitSupport/AboutData.cpp 2012-09-04 08:27:24 UTC (rev 127444) +++ trunk/Source/WebKit/blackberry/WebKitSupport/AboutData.cpp 2012-09-04 08:38:04 UTC (rev 127445) @@ -505,6 +505,8 @@ result.append(String(BlackBerry::Platform::BUILDINFO_WEBKIT)); result.append(String(BlackBerry::Platform::BUILDINFO_PLATFORM)); result.append(String(BlackBerry::Platform::BUILDINFO_LIBWEBVIEW)); +result.append(String(BlackBerry::Platform::BUILDINFO_WEBPLATFORM)); +result.append(String(BlackBerry::Platform::BUILDINFO_BROWSER)); result.append(String(/body/html)); return result; ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [127447] trunk/LayoutTests
Title: [127447] trunk/LayoutTests Revision 127447 Author dominik.rottsc...@intel.com Date 2012-09-04 01:39:43 -0700 (Tue, 04 Sep 2012) Log Message [EFL] Unreviewed gardening. Removing http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-in-body.html from skipped crashers section, after https://bugs.webkit.org/show_bug.cgi?id=94458#c14 * platform/efl/TestExpectations: Previously crashing test removed. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/efl/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (127446 => 127447) --- trunk/LayoutTests/ChangeLog 2012-09-04 08:38:18 UTC (rev 127446) +++ trunk/LayoutTests/ChangeLog 2012-09-04 08:39:43 UTC (rev 127447) @@ -1,3 +1,12 @@ +2012-09-04 Dominik Röttsches dominik.rottsc...@intel.com + +[EFL] Unreviewed gardening. + +Removing http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-in-body.html +from skipped crashers section, after https://bugs.webkit.org/show_bug.cgi?id=94458#c14 + +* platform/efl/TestExpectations: Previously crashing test removed. + 2012-09-03 Noel Gordon noel.gor...@gmail.com http/tests/incremental/partial-jpeg.html is flaky Modified: trunk/LayoutTests/platform/efl/TestExpectations (127446 => 127447) --- trunk/LayoutTests/platform/efl/TestExpectations 2012-09-04 08:38:18 UTC (rev 127446) +++ trunk/LayoutTests/platform/efl/TestExpectations 2012-09-04 08:39:43 UTC (rev 127447) @@ -177,8 +177,6 @@ // CRASHES // -BUGWK94458 DEBUG : http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-in-body.html = CRASH TEXT - // // FLAKY TESTS // ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [127446] releases/WebKitGTK/webkit-1.10
Title: [127446] releases/WebKitGTK/webkit-1.10 Revision 127446 Author carlo...@webkit.org Date 2012-09-04 01:38:18 -0700 (Tue, 04 Sep 2012) Log Message Merge r127070 - Source/WebCore: [Gtk] Process Gtk 3.4 smooth scroll events properly. https://bugs.webkit.org/show_bug.cgi?id=88070 Gtk 3.3.18 added smooth scroll events, adding a new scroll direction that provides detailed delta information. Added GDK_SMOOTH_SCROLL_MASK to the events listened, and added code to process properly the new direction GDK_SCROLL_SMOOTH and its deltas. Patch by José Dapena Paz jdap...@igalia.com on 2012-08-29 Reviewed by Martin Robinson. Test: fast/events/continuous-platform-wheelevent-in-scrolling-div.html * platform/gtk/PlatformWheelEventGtk.cpp: (WebCore::PlatformWheelEvent::PlatformWheelEvent): Source/WebKit/gtk: [Gtk] Process Gtk 3.4 smooth scroll events properly. https://bugs.webkit.org/show_bug.cgi?id=88070 Gtk 3.3.18 added smooth scroll events, adding a new scroll direction that provides detailed delta information. Added GDK_SMOOTH_SCROLL_MASK to the events listened, and added code to process properly the new direction GDK_SCROLL_SMOOTH and its deltas. Patch by José Dapena Paz jdap...@igalia.com on 2012-08-29 Reviewed by Martin Robinson. * webkit/webkitwebview.cpp: (webkit_web_view_realize): Source/WebKit2: [Gtk] Process Gtk 3.4 smooth scroll events properly. https://bugs.webkit.org/show_bug.cgi?id=88070 Gtk 3.3.18 added smooth scroll events, adding a new scroll direction that provides detailed delta information. Added GDK_SMOOTH_SCROLL_MASK to the events listened, and added code to process properly the new direction GDK_SCROLL_SMOOTH and its deltas. Patch by José Dapena Paz jdap...@igalia.com on 2012-08-29 Reviewed by Martin Robinson. * Shared/gtk/WebEventFactory.cpp: (WebKit::WebEventFactory::createWebWheelEvent): * UIProcess/API/gtk/WebKitWebViewBase.cpp: (webkitWebViewBaseRealize): Tools: [Gtk] Process Gtk 3.4 smooth scroll events properly https://bugs.webkit.org/show_bug.cgi?id=88070 Added continousMouseScrollBy support in WebKitTestRunner, and added implementation for gtk, and stub for Qt, mac and EFL. Added layout tests support for smooth scroll in Gtk 3.4, and use smooth scroll for emulating multi-tick mouseScrollBy events. Patch by José Dapena Paz jdap...@igalia.com on 2012-08-29 Reviewed by Martin Robinson. * DumpRenderTree/gtk/EventSender.cpp: (mouseScrollByCallback): (continuousMouseScrollByCallback): * WebKitTestRunner/EventSenderProxy.h: (EventSenderProxy): * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl: * WebKitTestRunner/InjectedBundle/EventSendingController.cpp: (WTR::EventSendingController::mouseScrollBy): (WTR): (WTR::EventSendingController::continuousMouseScrollBy): * WebKitTestRunner/InjectedBundle/EventSendingController.h: (EventSendingController): * WebKitTestRunner/TestController.cpp: (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle): * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp: (WTR): (WTR::EventSenderProxy::mouseScrollBy): (WTR::EventSenderProxy::continuousMouseScrollBy): * WebKitTestRunner/efl/EventSenderProxyEfl.cpp: (WTR): (WTR::EventSenderProxy::continuousMouseScrollBy): * WebKitTestRunner/mac/EventSenderProxy.mm: (WTR::EventSenderProxy::continuousScrollBy): * WebKitTestRunner/qt/EventSenderProxyQt.cpp: (WTR::EventSenderProxy::continuousMouseScrollBy): (WTR): LayoutTests: [Gtk] Process Gtk 3.4 smooth scroll events properly. https://bugs.webkit.org/show_bug.cgi?id=88070 Added layout tests support for smooth scroll in Gtk 3.4, and use smooth scroll for emulating multi-tick mouseScrollBy events. Patch by José Dapena Paz jdap...@igalia.com on 2012-08-29 Reviewed by Martin Robinson. * platform/gtk-wk2/fast/events/wheelevent-in-horizontal-scrollbar-in-rtl-expected.txt: Added. * platform/gtk-wk2/fast/events/wheelevent-in-vertical-scrollbar-in-rtl-expected.txt: Added. * platform/gtk/TestExpectations: * platform/gtk/fast/events/wheelevent-in-horizontal-scrollbar-in-rtl-expected.txt: Added. * platform/gtk/fast/events/wheelevent-in-vertical-scrollbar-in-rtl-expected.txt: Added. Modified Paths releases/WebKitGTK/webkit-1.10/LayoutTests/ChangeLog releases/WebKitGTK/webkit-1.10/LayoutTests/platform/gtk/TestExpectations releases/WebKitGTK/webkit-1.10/Source/WebCore/ChangeLog releases/WebKitGTK/webkit-1.10/Source/WebCore/platform/gtk/PlatformWheelEventGtk.cpp releases/WebKitGTK/webkit-1.10/Source/WebKit/gtk/ChangeLog releases/WebKitGTK/webkit-1.10/Source/WebKit/gtk/webkit/webkitwebview.cpp releases/WebKitGTK/webkit-1.10/Source/WebKit2/ChangeLog releases/WebKitGTK/webkit-1.10/Source/WebKit2/Shared/gtk/WebEventFactory.cpp releases/WebKitGTK/webkit-1.10/Source/WebKit2/UIProcess/API/gtk/WebKitWebViewBase.cpp releases/WebKitGTK/webkit-1.10/Tools/ChangeLog releases/WebKitGTK/webkit-1.10/Tools/DumpRenderTree/gtk/EventSender.cpp releases/WebKitGTK/webkit-1.10/Tools/WebKitTestRunner/EventSenderProxy.h
[webkit-changes] [127448] trunk/Source/WebCore
Title: [127448] trunk/Source/WebCore Revision 127448 Author yu...@chromium.org Date 2012-09-04 01:53:31 -0700 (Tue, 04 Sep 2012) Log Message Web Inspector: new CPU Profiles are not shown after reattach https://bugs.webkit.org/show_bug.cgi?id=95686 Reviewed by Vsevolod Vlasov. * inspector/InspectorProfilerAgent.cpp: (WebCore::InspectorProfilerAgent::restore): set m_headersRequested flags to true and clear all profiles on the front-end since there are no collected profiles yet immediately after render process sitching. Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/inspector/InspectorProfilerAgent.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (127447 => 127448) --- trunk/Source/WebCore/ChangeLog 2012-09-04 08:39:43 UTC (rev 127447) +++ trunk/Source/WebCore/ChangeLog 2012-09-04 08:53:31 UTC (rev 127448) @@ -1,3 +1,15 @@ +2012-09-04 Yury Semikhatsky yu...@chromium.org + +Web Inspector: new CPU Profiles are not shown after reattach +https://bugs.webkit.org/show_bug.cgi?id=95686 + +Reviewed by Vsevolod Vlasov. + +* inspector/InspectorProfilerAgent.cpp: +(WebCore::InspectorProfilerAgent::restore): set m_headersRequested flags +to true and clear all profiles on the front-end since there are no +collected profiles yet immediately after render process sitching. + 2012-09-04 Ilya Tikhonovsky loi...@chromium.org Web Inspector: NMI: cosmetic change, rename m_domMemoryUsage to m_memoryInstrumentation. Modified: trunk/Source/WebCore/inspector/InspectorProfilerAgent.cpp (127447 => 127448) --- trunk/Source/WebCore/inspector/InspectorProfilerAgent.cpp 2012-09-04 08:39:43 UTC (rev 127447) +++ trunk/Source/WebCore/inspector/InspectorProfilerAgent.cpp 2012-09-04 08:53:31 UTC (rev 127448) @@ -349,6 +349,7 @@ restoreEnablement(); // Revisit this. +m_headersRequested = true; resetFrontendProfiles(); if (m_state-getBoolean(ProfilerAgentState::userInitiatedProfiling)) start(); ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [127449] trunk
Title: [127449] trunk
Revision 127449
Author apav...@chromium.org
Date 2012-09-04 01:55:03 -0700 (Tue, 04 Sep 2012)
Log Message
Web Inspector: More directional control characters for debugging in inspector
https://bugs.webkit.org/show_bug.cgi?id=95696
Reviewed by Vsevolod Vlasov.
Source/WebCore:
Entities for text directionality-related characters added (LRE, RLE, LRO, RLO, PDF).
* inspector/front-end/ElementsTreeOutline.js:
LayoutTests:
* inspector/elements/elements-panel-structure-expected.txt:
* inspector/elements/elements-panel-structure.html:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/inspector/elements/elements-panel-structure-expected.txt
trunk/LayoutTests/inspector/elements/elements-panel-structure.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/ElementsTreeOutline.js
Diff
Modified: trunk/LayoutTests/ChangeLog (127448 => 127449)
--- trunk/LayoutTests/ChangeLog 2012-09-04 08:53:31 UTC (rev 127448)
+++ trunk/LayoutTests/ChangeLog 2012-09-04 08:55:03 UTC (rev 127449)
@@ -1,3 +1,13 @@
+2012-09-04 Alexander Pavlov apav...@chromium.org
+
+Web Inspector: More directional control characters for debugging in inspector
+https://bugs.webkit.org/show_bug.cgi?id=95696
+
+Reviewed by Vsevolod Vlasov.
+
+* inspector/elements/elements-panel-structure-expected.txt:
+* inspector/elements/elements-panel-structure.html:
+
2012-09-04 Dominik Röttsches dominik.rottsc...@intel.com
[EFL] Unreviewed gardening.
Modified: trunk/LayoutTests/inspector/elements/elements-panel-structure-expected.txt (127448 => 127449)
--- trunk/LayoutTests/inspector/elements/elements-panel-structure-expected.txt 2012-09-04 08:53:31 UTC (rev 127448)
+++ trunk/LayoutTests/inspector/elements/elements-panel-structure-expected.txt 2012-09-04 08:55:03 UTC (rev 127449)
@@ -1,6 +1,6 @@
Tests that elements panel shows DOM tree structure.
-Quoted Text. Special characters: '
+Quoted Text. Special characters: '
!DOCTYPE html PUBLIC -//W3C//DTD HTML 4.01 Transitional//EN http://www.w3.org/TR/html4/loose.dtd
- html
- head
@@ -14,7 +14,7 @@
pTests that elements panel shows DOM tree structure./p
- div id=level1
- div id=level2
- Quoted Text. Specialnbsp;characters: 'nbsp;ensp;emsp;thinsp;#8203;zwnj;zwj;lrm;rlm;
+ Quoted Text. Specialnbsp;characters: 'nbsp;ensp;emsp;thinsp;#8203;zwnj;zwj;lrm;rlm; #8234;#8235;#8236;#8237;#8238;
div id=level3/div
/div
/div
Modified: trunk/LayoutTests/inspector/elements/elements-panel-structure.html (127448 => 127449)
--- trunk/LayoutTests/inspector/elements/elements-panel-structure.html 2012-09-04 08:53:31 UTC (rev 127448)
+++ trunk/LayoutTests/inspector/elements/elements-panel-structure.html 2012-09-04 08:55:03 UTC (rev 127449)
@@ -25,7 +25,7 @@
/p
div id=level1
-div id=level2Quoted Text. Specialnbsp;characters: gt;lt;quot;apos;nbsp;ensp;emsp;thinsp;#8203;zwnj;zwj;lrm;rlm;div id=level3/div
+div id=level2Quoted Text. Specialnbsp;characters: gt;lt;quot;apos;nbsp;ensp;emsp;thinsp;#8203;zwnj;zwj;lrm;rlm; #8234;#8235;#8236;#8237;#8238;div id=level3/div
/div
/div
Modified: trunk/Source/WebCore/ChangeLog (127448 => 127449)
--- trunk/Source/WebCore/ChangeLog 2012-09-04 08:53:31 UTC (rev 127448)
+++ trunk/Source/WebCore/ChangeLog 2012-09-04 08:55:03 UTC (rev 127449)
@@ -1,3 +1,14 @@
+2012-09-04 Alexander Pavlov apav...@chromium.org
+
+Web Inspector: More directional control characters for debugging in inspector
+https://bugs.webkit.org/show_bug.cgi?id=95696
+
+Reviewed by Vsevolod Vlasov.
+
+Entities for text directionality-related characters added (LRE, RLE, LRO, RLO, PDF).
+
+* inspector/front-end/ElementsTreeOutline.js:
+
2012-09-04 Yury Semikhatsky yu...@chromium.org
Web Inspector: new CPU Profiles are not shown after reattach
Modified: trunk/Source/WebCore/inspector/front-end/ElementsTreeOutline.js (127448 => 127449)
--- trunk/Source/WebCore/inspector/front-end/ElementsTreeOutline.js 2012-09-04 08:53:31 UTC (rev 127448)
+++ trunk/Source/WebCore/inspector/front-end/ElementsTreeOutline.js 2012-09-04 08:55:03 UTC (rev 127449)
@@ -76,11 +76,16 @@
\u2002: ensp,
\u2003: emsp,
\u2009: thinsp,
-\u200b: #8203,
+\u200b: #8203, // ZWSP
\u200c: zwnj,
\u200d: zwj,
\u200e: lrm,
-\u200f: rlm
+\u200f: rlm,
+\u202a: #8234, // LRE
+\u202b: #8235, // RLE
+\u202c: #8236, // PDF
+\u202d: #8237, // LRO
+\u202e: #8238 // RLO
}
WebInspector.ElementsTreeOutline.prototype = {
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [127450] trunk/Source/WebKit/qt
Title: [127450] trunk/Source/WebKit/qt
Revision 127450
Author o...@webkit.org
Date 2012-09-04 02:20:08 -0700 (Tue, 04 Sep 2012)
Log Message
[Qt] REGRESSION(r127321): It made 3 notification test timeout
https://bugs.webkit.org/show_bug.cgi?id=95638
Patch by Jon Lee jon...@apple.com on 2012-09-04
Reviewed by Csaba Osztrogonác.
Dispatch show event instead of display after r127321.
* WebCoreSupport/NotificationPresenterClientQt.cpp:
(WebCore::NotificationPresenterClientQt::sendDisplayEvent):
Modified Paths
trunk/Source/WebKit/qt/ChangeLog
trunk/Source/WebKit/qt/WebCoreSupport/NotificationPresenterClientQt.cpp
Diff
Modified: trunk/Source/WebKit/qt/ChangeLog (127449 => 127450)
--- trunk/Source/WebKit/qt/ChangeLog 2012-09-04 08:55:03 UTC (rev 127449)
+++ trunk/Source/WebKit/qt/ChangeLog 2012-09-04 09:20:08 UTC (rev 127450)
@@ -1,3 +1,15 @@
+2012-09-04 Jon Lee jon...@apple.com
+
+[Qt] REGRESSION(r127321): It made 3 notification test timeout
+https://bugs.webkit.org/show_bug.cgi?id=95638
+
+Reviewed by Csaba Osztrogonác.
+
+Dispatch show event instead of display after r127321.
+
+* WebCoreSupport/NotificationPresenterClientQt.cpp:
+(WebCore::NotificationPresenterClientQt::sendDisplayEvent):
+
2012-08-31 Simon Hausmann simon.hausm...@nokia.com
[Qt] Port convertValueToQVariant to use the JSC C API
Modified: trunk/Source/WebKit/qt/WebCoreSupport/NotificationPresenterClientQt.cpp (127449 => 127450)
--- trunk/Source/WebKit/qt/WebCoreSupport/NotificationPresenterClientQt.cpp 2012-09-04 08:55:03 UTC (rev 127449)
+++ trunk/Source/WebKit/qt/WebCoreSupport/NotificationPresenterClientQt.cpp 2012-09-04 09:20:08 UTC (rev 127450)
@@ -384,7 +384,7 @@
{
Notification* notification = notificationForWrapper(wrapper);
if (notification)
-sendEvent(notification, display);
+sendEvent(notification, show);
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [127451] trunk
Title: [127451] trunk Revision 127451 Author commit-qu...@webkit.org Date 2012-09-04 02:25:24 -0700 (Tue, 04 Sep 2012) Log Message [CMAKE] Update cmakeconfig.h.cmake https://bugs.webkit.org/show_bug.cgi?id=95712 Patch by Jinwoo Song jinwoo7.s...@samsung.com on 2012-09-04 Reviewed by Gyuyoung Kim. Update feature definitions which are missing compared to WebKitFeatures.cmake * Source/cmakeconfig.h.cmake: Modified Paths trunk/ChangeLog trunk/Source/cmakeconfig.h.cmake Diff Modified: trunk/ChangeLog (127450 => 127451) --- trunk/ChangeLog 2012-09-04 09:20:08 UTC (rev 127450) +++ trunk/ChangeLog 2012-09-04 09:25:24 UTC (rev 127451) @@ -1,3 +1,14 @@ +2012-09-04 Jinwoo Song jinwoo7.s...@samsung.com + +[CMAKE] Update cmakeconfig.h.cmake +https://bugs.webkit.org/show_bug.cgi?id=95712 + +Reviewed by Gyuyoung Kim. + +Update feature definitions which are missing compared to WebKitFeatures.cmake + +* Source/cmakeconfig.h.cmake: + 2012-09-03 Jinwoo Song jinwoo7.s...@samsung.com [EFL] Use WebKitVersion.h to get version information Modified: trunk/Source/cmakeconfig.h.cmake (127450 => 127451) --- trunk/Source/cmakeconfig.h.cmake 2012-09-04 09:20:08 UTC (rev 127450) +++ trunk/Source/cmakeconfig.h.cmake 2012-09-04 09:25:24 UTC (rev 127451) @@ -1,10 +1,10 @@ #ifndef CMAKECONFIG_H #define CMAKECONFIG_H +#cmakedefine01 ENABLE_3D_RENDERING +#cmakedefine01 ENABLE_ACCELERATED_2D_CANVAS #cmakedefine01 ENABLE_ANIMATION_API #cmakedefine01 ENABLE_API_TESTS -#cmakedefine01 ENABLE_3D_RENDERING -#cmakedefine01 ENABLE_ACCELERATED_2D_CANVAS #cmakedefine01 ENABLE_AS_IMAGE #cmakedefine01 ENABLE_ASSEMBLER_WX_EXCLUSIVE #cmakedefine01 ENABLE_BATTERY_STATUS @@ -12,18 +12,19 @@ #cmakedefine01 ENABLE_CHANNEL_MESSAGING #cmakedefine01 ENABLE_CLIENT_BASED_GEOLOCATION #cmakedefine01 ENABLE_CSP_NEXT +#cmakedefine01 ENABLE_CSS3_TEXT_DECORATION #cmakedefine01 ENABLE_CSS_BOX_DECORATION_BREAK #cmakedefine01 ENABLE_CSS_COMPOSITING #cmakedefine01 ENABLE_CSS_EXCLUSIONS +#cmakedefine01 ENABLE_CSS_FILTERS +#cmakedefine01 ENABLE_CSS_HIERARCHIES #cmakedefine01 ENABLE_CSS_IMAGE_ORIENTATION #cmakedefine01 ENABLE_CSS_IMAGE_RESOLUTION #cmakedefine01 ENABLE_CSS_IMAGE_SET #cmakedefine01 ENABLE_CSS_REGIONS +#cmakedefine01 ENABLE_CSS_SHADERS #cmakedefine01 ENABLE_CSS_STICKY_POSITION #cmakedefine01 ENABLE_CSS_VARIABLES -#cmakedefine01 ENABLE_CSS3_TEXT_DECORATION -#cmakedefine01 ENABLE_CSS_FILTERS -#cmakedefine01 ENABLE_CSS_SHADERS #cmakedefine01 ENABLE_CUSTOM_SCHEME_HANDLER #cmakedefine01 ENABLE_DATALIST_ELEMENT #cmakedefine01 ENABLE_DATA_TRANSFER_ITEMS @@ -46,6 +47,7 @@ #cmakedefine01 ENABLE_IFRAME_SEAMLESS #cmakedefine01 ENABLE_IMAGE_DECODER_DOWN_SAMPLING #cmakedefine01 ENABLE_INDEXED_DATABASE +#cmakedefine01 ENABLE_INPUT_SPEECH #cmakedefine01 ENABLE_INPUT_TYPE_COLOR #cmakedefine01 ENABLE_INPUT_TYPE_DATE #cmakedefine01 ENABLE_INPUT_TYPE_DATETIME @@ -57,14 +59,18 @@ #cmakedefine01 ENABLE_JAVASCRIPT_DEBUGGER #cmakedefine01 ENABLE_JIT #cmakedefine01 ENABLE_LEGACY_NOTIFICATIONS +#cmakedefine01 ENABLE_LEGACY_VIEWPORT_ADAPTION +#cmakedefine01 ENABLE_LEGACY_WEBKIT_BLOB_BUILDER #cmakedefine01 ENABLE_LINK_PREFETCH #cmakedefine01 ENABLE_LINK_PRERENDER -#cmakedefine01 ENABLE_LEGACY_WEBKIT_BLOB_BUILDER #cmakedefine01 ENABLE_MATHML #cmakedefine01 ENABLE_MEDIA_CAPTURE +#cmakedefine01 ENABLE_MEDIA_SOURCE +#cmakedefine01 ENABLE_MEDIA_STATISTICS #cmakedefine01 ENABLE_MEDIA_STREAM #cmakedefine01 ENABLE_MEMORY_SAMPLER #cmakedefine01 ENABLE_METER_ELEMENT +#cmakedefine01 ENABLE_MHTML #cmakedefine01 ENABLE_MICRODATA #cmakedefine01 ENABLE_MUTATION_OBSERVERS #cmakedefine01 ENABLE_NAVIGATOR_CONTENT_UTILS @@ -75,14 +81,19 @@ #cmakedefine01 ENABLE_OVERFLOW_SCROLLING #cmakedefine01 ENABLE_PAGE_POPUP #cmakedefine01 ENABLE_PAGE_VISIBILITY_API +#cmakedefine01 ENABLE_PLUGIN_PROXY_FOR_VIDEO #cmakedefine01 ENABLE_PROGRESS_ELEMENT +#cmakedefine01 ENABLE_QUOTA +#cmakedefine01 ENABLE_REPAINT_THROTTLING #cmakedefine01 ENABLE_REQUEST_ANIMATION_FRAME +#cmakedefine01 ENABLE_SCRIPTED_SPEECH #cmakedefine01 ENABLE_SHADOW_DOM #cmakedefine01 ENABLE_SHARED_WORKERS #cmakedefine01 ENABLE_SMOOTH_SCROLLING #cmakedefine01 ENABLE_SQL_DATABASE #cmakedefine01 ENABLE_STYLE_SCOPED #cmakedefine01 ENABLE_SVG +#cmakedefine01 ENABLE_SVG_DOM_OBJC_BINDINGS #cmakedefine01 ENABLE_SVG_FONTS #cmakedefine01 ENABLE_TEXT_AUTOSIZING #cmakedefine01 ENABLE_TOUCH_EVENTS ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [127452] trunk
Title: [127452] trunk
Revision 127452
Author commit-qu...@webkit.org
Date 2012-09-04 02:37:41 -0700 (Tue, 04 Sep 2012)
Log Message
Web Inspector: [WebGL] Save gl.getError() status before taking a WebGL state snapshot and restore it afterwards
https://bugs.webkit.org/show_bug.cgi?id=95443
Patch by Andrey Adaikin aand...@chromium.org on 2012-09-04
Reviewed by Vsevolod Vlasov.
Source/WebCore:
Save gl.getError() status before taking the GL snapshot and restore it afterwards.
* inspector/InjectedScriptWebGLModuleSource.js:
(.):
LayoutTests:
Adds a test to check that we properly save the WebGL getError() status while doing the instrumentation.
* inspector/profiler/webgl/webgl-profiler-get-error-expected.txt: Added.
* inspector/profiler/webgl/webgl-profiler-get-error.html: Added.
* inspector/profiler/webgl/webgl-profiler-test.js: Added.
(initialize_WebGLProfilerTest.InspectorTest.enableWebGLAgent):
(initialize_WebGLProfilerTest):
(createWebGLContext):
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/InjectedScriptWebGLModuleSource.js
Added Paths
trunk/LayoutTests/inspector/profiler/webgl/webgl-profiler-get-error-expected.txt
trunk/LayoutTests/inspector/profiler/webgl/webgl-profiler-get-error.html
trunk/LayoutTests/inspector/profiler/webgl/webgl-profiler-test.js
Diff
Modified: trunk/LayoutTests/ChangeLog (127451 => 127452)
--- trunk/LayoutTests/ChangeLog 2012-09-04 09:25:24 UTC (rev 127451)
+++ trunk/LayoutTests/ChangeLog 2012-09-04 09:37:41 UTC (rev 127452)
@@ -1,3 +1,19 @@
+2012-09-04 Andrey Adaikin aand...@chromium.org
+
+Web Inspector: [WebGL] Save gl.getError() status before taking a WebGL state snapshot and restore it afterwards
+https://bugs.webkit.org/show_bug.cgi?id=95443
+
+Reviewed by Vsevolod Vlasov.
+
+Adds a test to check that we properly save the WebGL getError() status while doing the instrumentation.
+
+* inspector/profiler/webgl/webgl-profiler-get-error-expected.txt: Added.
+* inspector/profiler/webgl/webgl-profiler-get-error.html: Added.
+* inspector/profiler/webgl/webgl-profiler-test.js: Added.
+(initialize_WebGLProfilerTest.InspectorTest.enableWebGLAgent):
+(initialize_WebGLProfilerTest):
+(createWebGLContext):
+
2012-09-04 Alexander Pavlov apav...@chromium.org
Web Inspector: More directional control characters for debugging in inspector
Added: trunk/LayoutTests/inspector/profiler/webgl/webgl-profiler-get-error-expected.txt (0 => 127452)
--- trunk/LayoutTests/inspector/profiler/webgl/webgl-profiler-get-error-expected.txt (rev 0)
+++ trunk/LayoutTests/inspector/profiler/webgl/webgl-profiler-get-error-expected.txt 2012-09-04 09:37:41 UTC (rev 127452)
@@ -0,0 +1,3 @@
+Tests WebGL getError() status.
+
+Bug 95443
Added: trunk/LayoutTests/inspector/profiler/webgl/webgl-profiler-get-error.html (0 => 127452)
--- trunk/LayoutTests/inspector/profiler/webgl/webgl-profiler-get-error.html (rev 0)
+++ trunk/LayoutTests/inspector/profiler/webgl/webgl-profiler-get-error.html 2012-09-04 09:37:41 UTC (rev 127452)
@@ -0,0 +1,140 @@
+html
+head
+script src=""
+script src=""
+script
+
+var gl;
+var rawGL;
+var glResource;
+
+function assertNoErrors(gl)
+{
+console.assert(gl.getError() === gl.NO_ERROR, No GL error was expected at this time);
+}
+
+function assertEqualArrays(a, b)
+{
+console.assert(a.length === b.length, assertEqualArrays: a.length= + a.length + , b.length= + b.length);
+a = a.slice();
+b = b.slice();
+a.sort();
+b.sort();
+a.forEach(function(element, index) {
+console.assert(a[index] === b[index], assertEqualArrays: different values at index + index);
+});
+}
+
+function generateWebGLError(gl, error)
+{
+switch (error) {
+case gl.INVALID_ENUM:
+gl.pixelStorei(123, 234);
+break;
+case gl.INVALID_VALUE:
+gl.pixelStorei(gl.PACK_ALIGNMENT, 234);
+break;
+case gl.INVALID_OPERATION:
+default:
+gl.generateMipmap(gl.TEXTURE_CUBE_MAP);
+break;
+}
+}
+
+function getAllErrors(gl)
+{
+var errors = [];
+while (true) {
+var error = gl.getError();
+if (error === gl.NO_ERROR)
+break;
+console.assert(typeof error === number, getError() should return a number instead of a + (typeof error));
+errors.push(error);
+}
+return errors;
+}
+
+function createAndRunWebGLProgram()
+{
+gl = createWebGLContext();
+console.assert(gl, Failed to create WebGL context);
+
+glResource = gl[__resourceObject];
+console.assert(glResource, WebGL context is not wrapped);
+
+rawGL = glResource.wrappedObject();
+console.assert(rawGL, No raw WebGL context found);
+console.assert(gl !== rawGL, Proxy and RAW contexts should not be the same);
+
+assertNoErrors(gl);
+assertNoErrors(rawGL);
+
+//
[webkit-changes] [127453] trunk/LayoutTests
Title: [127453] trunk/LayoutTests Revision 127453 Author commit-qu...@webkit.org Date 2012-09-04 03:38:03 -0700 (Tue, 04 Sep 2012) Log Message Unreviewed, rolling out r127447. http://trac.webkit.org/changeset/127447 https://bugs.webkit.org/show_bug.cgi?id=95726 Mistake, did not reliably pass yet. (Requested by drott on #webkit). Patch by Sheriff Bot webkit.review@gmail.com on 2012-09-04 * platform/efl/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/efl/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (127452 => 127453) --- trunk/LayoutTests/ChangeLog 2012-09-04 09:37:41 UTC (rev 127452) +++ trunk/LayoutTests/ChangeLog 2012-09-04 10:38:03 UTC (rev 127453) @@ -1,3 +1,14 @@ +2012-09-04 Sheriff Bot webkit.review@gmail.com + +Unreviewed, rolling out r127447. +http://trac.webkit.org/changeset/127447 +https://bugs.webkit.org/show_bug.cgi?id=95726 + +Mistake, did not reliably pass yet. (Requested by drott on +#webkit). + +* platform/efl/TestExpectations: + 2012-09-04 Andrey Adaikin aand...@chromium.org Web Inspector: [WebGL] Save gl.getError() status before taking a WebGL state snapshot and restore it afterwards Modified: trunk/LayoutTests/platform/efl/TestExpectations (127452 => 127453) --- trunk/LayoutTests/platform/efl/TestExpectations 2012-09-04 09:37:41 UTC (rev 127452) +++ trunk/LayoutTests/platform/efl/TestExpectations 2012-09-04 10:38:03 UTC (rev 127453) @@ -177,6 +177,8 @@ // CRASHES // +BUGWK94458 DEBUG : http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-in-body.html = CRASH TEXT + // // FLAKY TESTS // ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [127455] trunk/Source/WebCore
Title: [127455] trunk/Source/WebCore Revision 127455 Author commit-qu...@webkit.org Date 2012-09-04 04:25:13 -0700 (Tue, 04 Sep 2012) Log Message [EFL] Fix build error in NetworkStateNotifierEfl.cpp https://bugs.webkit.org/show_bug.cgi?id=95724 Unreviewed EFL build fix. Make sure sys/socket.h is included before linux/netlink.h to fix build errors on some systems (e.g. Ubuntu 11.10). No new tests, no behavior change. Patch by Christophe Dumez christophe.du...@intel.com on 2012-09-04 * platform/network/efl/NetworkStateNotifierEfl.cpp: Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/platform/network/efl/NetworkStateNotifierEfl.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (127454 => 127455) --- trunk/Source/WebCore/ChangeLog 2012-09-04 10:48:27 UTC (rev 127454) +++ trunk/Source/WebCore/ChangeLog 2012-09-04 11:25:13 UTC (rev 127455) @@ -1,3 +1,18 @@ +2012-09-04 Christophe Dumez christophe.du...@intel.com + +[EFL] Fix build error in NetworkStateNotifierEfl.cpp +https://bugs.webkit.org/show_bug.cgi?id=95724 + +Unreviewed EFL build fix. + +Make sure sys/socket.h is included before +linux/netlink.h to fix build errors on some +systems (e.g. Ubuntu 11.10). + +No new tests, no behavior change. + +* platform/network/efl/NetworkStateNotifierEfl.cpp: + 2012-09-04 Vsevolod Vlasov vse...@chromium.org Web Inspector: Create _javascript_Sources based on network resources. Modified: trunk/Source/WebCore/platform/network/efl/NetworkStateNotifierEfl.cpp (127454 => 127455) --- trunk/Source/WebCore/platform/network/efl/NetworkStateNotifierEfl.cpp 2012-09-04 10:48:27 UTC (rev 127454) +++ trunk/Source/WebCore/platform/network/efl/NetworkStateNotifierEfl.cpp 2012-09-04 11:25:13 UTC (rev 127455) @@ -31,12 +31,14 @@ #include Eeze.h #include Eeze_Net.h #include asm/types.h -#include linux/netlink.h -#include linux/rtnetlink.h #include string.h #include sys/socket.h #include unistd.h +// Must come at the end so that sys/socket.h is included first. +#include linux/netlink.h +#include linux/rtnetlink.h + static const char udevLoopBackInterfaceSysPath[] = lo; static const char udevOperstateAttribute[] = operstate; static const char udevOperstateUp[] = up; ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [127456] trunk/LayoutTests
Title: [127456] trunk/LayoutTests
Revision 127456
Author vse...@chromium.org
Date 2012-09-04 04:52:57 -0700 (Tue, 04 Sep 2012)
Log Message
Unreviewed tests fix.
* http/tests/inspector/workspace-test.js:
* inspector/debugger/dynamic-script-tag-expected.txt:
* inspector/debugger/dynamic-script-tag.html:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/http/tests/inspector/workspace-test.js
trunk/LayoutTests/inspector/debugger/dynamic-script-tag-expected.txt
trunk/LayoutTests/inspector/debugger/dynamic-script-tag.html
Diff
Modified: trunk/LayoutTests/ChangeLog (127455 => 127456)
--- trunk/LayoutTests/ChangeLog 2012-09-04 11:25:13 UTC (rev 127455)
+++ trunk/LayoutTests/ChangeLog 2012-09-04 11:52:57 UTC (rev 127456)
@@ -1,5 +1,13 @@
2012-09-04 Vsevolod Vlasov vse...@chromium.org
+Unreviewed tests fix.
+
+* http/tests/inspector/workspace-test.js:
+* inspector/debugger/dynamic-script-tag-expected.txt:
+* inspector/debugger/dynamic-script-tag.html:
+
+2012-09-04 Vsevolod Vlasov vse...@chromium.org
+
Web Inspector: Create _javascript_Sources based on network resources.
https://bugs.webkit.org/show_bug.cgi?id=95352
Modified: trunk/LayoutTests/http/tests/inspector/workspace-test.js (127455 => 127456)
--- trunk/LayoutTests/http/tests/inspector/workspace-test.js 2012-09-04 11:25:13 UTC (rev 127455)
+++ trunk/LayoutTests/http/tests/inspector/workspace-test.js 2012-09-04 11:52:57 UTC (rev 127456)
@@ -50,7 +50,8 @@
InspectorTest.dumpUISourceCode = function(uiSourceCode, callback)
{
-InspectorTest.addResult(UISourceCode: + uiSourceCode.url);
+var url = "" LayoutTests);
+InspectorTest.addResult(UISourceCode: + url);
if (uiSourceCode instanceof WebInspector._javascript_Source) {
InspectorTest.addResult(UISourceCode is editable: + uiSourceCode._isEditable);
InspectorTest.addResult(UISourceCode is content script: + uiSourceCode.isContentScript);
Modified: trunk/LayoutTests/inspector/debugger/dynamic-script-tag-expected.txt (127455 => 127456)
--- trunk/LayoutTests/inspector/debugger/dynamic-script-tag-expected.txt 2012-09-04 11:25:13 UTC (rev 127455)
+++ trunk/LayoutTests/inspector/debugger/dynamic-script-tag-expected.txt 2012-09-04 11:52:57 UTC (rev 127456)
@@ -2,20 +2,20 @@
Debugger was enabled.
Dumping scripts:
-script1: file:///usr/local/google/home/vsevik/chromium/src/third_party/WebKit/LayoutTests/inspector/debugger/dynamic-script-tag.html
+script1: LayoutTests/inspector/debugger/dynamic-script-tag.html
Is anonymous:false
Is inline script:false
-script2: file:///usr/local/google/home/vsevik/chromium/src/third_party/WebKit/LayoutTests/inspector/debugger/dynamic-script-tag.html
+script2: LayoutTests/inspector/debugger/dynamic-script-tag.html
Is anonymous:false
Is inline script:false
Dumping uiSourceCodes:
-UISourceCode: file:///usr/local/google/home/vsevik/chromium/src/third_party/WebKit/LayoutTests/inspector/debugger/dynamic-script-tag.html (1)
+UISourceCode: LayoutTests/inspector/debugger/dynamic-script-tag.html (1)
UISourceCode is editable: true
UISourceCode is content script: false
Mime type: text/_javascript_
UISourceCode content: function foo() { }
UI resource: null
-UISourceCode: file:///usr/local/google/home/vsevik/chromium/src/third_party/WebKit/LayoutTests/inspector/debugger/dynamic-script-tag.html (2)
+UISourceCode: LayoutTests/inspector/debugger/dynamic-script-tag.html (2)
UISourceCode is editable: true
UISourceCode is content script: false
Mime type: text/_javascript_
Modified: trunk/LayoutTests/inspector/debugger/dynamic-script-tag.html (127455 => 127456)
--- trunk/LayoutTests/inspector/debugger/dynamic-script-tag.html 2012-09-04 11:25:13 UTC (rev 127455)
+++ trunk/LayoutTests/inspector/debugger/dynamic-script-tag.html 2012-09-04 11:52:57 UTC (rev 127456)
@@ -49,7 +49,8 @@
InspectorTest.addResult(Dumping scripts:);
for (var i = 0; i scripts.length; ++i) {
var script = scripts[i];
-InspectorTest.addResult(script + (i+1) + : + script.sourceURL);
+var url = "" LayoutTests);
+InspectorTest.addResult(script + (i+1) + : + url);
InspectorTest.addResult(Is anonymous: + script.isAnonymousScript());
InspectorTest.addResult(Is inline script: + script.isInlineScript());
uiSourceCodes.push(script.rawLocationToUILocation(0, 0).uiSourceCode);
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [127460] trunk/LayoutTests
Title: [127460] trunk/LayoutTests Revision 127460 Author commit-qu...@webkit.org Date 2012-09-04 05:34:23 -0700 (Tue, 04 Sep 2012) Log Message [EFL] Gardening of failing tests https://bugs.webkit.org/show_bug.cgi?id=95725 Unreviewed gardening. Patch by Thiago Marcos P. Santos thiago.san...@intel.com on 2012-09-04 * platform/efl-wk2/TestExpectations: * platform/efl/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/efl/TestExpectations trunk/LayoutTests/platform/efl-wk2/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (127459 => 127460) --- trunk/LayoutTests/ChangeLog 2012-09-04 12:30:35 UTC (rev 127459) +++ trunk/LayoutTests/ChangeLog 2012-09-04 12:34:23 UTC (rev 127460) @@ -1,3 +1,13 @@ +2012-09-04 Thiago Marcos P. Santos thiago.san...@intel.com + +[EFL] Gardening of failing tests +https://bugs.webkit.org/show_bug.cgi?id=95725 + +Unreviewed gardening. + +* platform/efl-wk2/TestExpectations: +* platform/efl/TestExpectations: + 2012-09-04 Allan Sandfeld Jensen allan.jen...@nokia.com Allow child-frame content in hit-tests. Modified: trunk/LayoutTests/platform/efl/TestExpectations (127459 => 127460) --- trunk/LayoutTests/platform/efl/TestExpectations 2012-09-04 12:30:35 UTC (rev 127459) +++ trunk/LayoutTests/platform/efl/TestExpectations 2012-09-04 12:34:23 UTC (rev 127460) @@ -543,6 +543,7 @@ BUGWK77219 SKIP : http/tests/security/webgl-remote-read-remote-image-allowed.html = TEXT BUGWK77219 SKIP : http/tests/security/webgl-remote-read-remote-image-blocked-no-crossorigin.html = TEXT BUGWK77219 : inspector/profiler/webgl/webgl-profiler-api-changes.html = TEXT +BUGWK77219 : inspector/profiler/webgl/webgl-profiler-get-error.html = TEXT BUGWK84759 : ietestcenter/css3/multicolumn/column-containing-block-001.htm = IMAGE BUGWK84760 : ietestcenter/css3/multicolumn/column-containing-block-002.htm = IMAGE Modified: trunk/LayoutTests/platform/efl-wk2/TestExpectations (127459 => 127460) --- trunk/LayoutTests/platform/efl-wk2/TestExpectations 2012-09-04 12:30:35 UTC (rev 127459) +++ trunk/LayoutTests/platform/efl-wk2/TestExpectations 2012-09-04 12:34:23 UTC (rev 127460) @@ -37,6 +37,7 @@ BUGWKEFL : fast/dom/register-protocol-handler.html = CRASH BUGWKEFL : fast/dom/unregister-protocol-handler.html = CRASH BUGWKEFL : http/tests/loading/fire-error-event-script-no-content-type.html = CRASH +BUGWKEFL : http/tests/loading/fire-error-event-empty-404-script.html = CRASH BUGWK95333 DEBUG : fast/forms/color/input-value-sanitization-color.html = CRASH // @@ -77,9 +78,9 @@ BUGWKEFL : inspector/debugger/debugger-breakpoints-not-activated-on-reload.html = TEXT PASS BUGWKEFL : inspector/debugger/debugger-eval-while-paused.html = TEXT PASS BUGWKEFL : inspector/debugger/callstack-placards-discarded.html = TEXT PASS -BUGWKEFL : inspector/debugger/debugger-expand-scope.html = TEXT PASS +BUGWKEFL : inspector/debugger/debugger-expand-scope.html = TEXT PASS CRASH BUGWKEFL : inspector/debugger/debugger-autocontinue-on-syntax-error.html = TEXT PASS -BUGWKEFL : inspector/debugger/debugger-activation-crash.html = TEXT PASS +BUGWKEFL : inspector/debugger/debugger-activation-crash.html = TEXT PASS CRASH BUGWKEFL : inspector/debugger/debugger-pause-in-eval-script.html = TEXT PASS CRASH BUGWKEFL : inspector/debugger/debugger-pause-on-debugger-statement.html = TEXT PASS CRASH BUGWKEFL : inspector/debugger/debugger-pause-on-failed-assertion.html = TEXT PASS CRASH ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [127459] trunk/Source/WebCore
Title: [127459] trunk/Source/WebCore
Revision 127459
Author commit-qu...@webkit.org
Date 2012-09-04 05:30:35 -0700 (Tue, 04 Sep 2012)
Log Message
Web Inspector: [WebGL] Bugfix: wrong texture binding target in replay for 3D textures
https://bugs.webkit.org/show_bug.cgi?id=95687
Patch by Andrey Adaikin aand...@chromium.org on 2012-09-04
Reviewed by Vsevolod Vlasov.
gl.bindTexture accepts either TEXTURE_2D or TEXTURE_CUBE_MAP targets, but we tried to replay with TEXTURE_CUBE_MAP_POSITIVE_X and others for 3D textures.
* inspector/InjectedScriptWebGLModuleSource.js:
(.):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/InjectedScriptWebGLModuleSource.js
Diff
Modified: trunk/Source/WebCore/ChangeLog (127458 => 127459)
--- trunk/Source/WebCore/ChangeLog 2012-09-04 12:11:13 UTC (rev 127458)
+++ trunk/Source/WebCore/ChangeLog 2012-09-04 12:30:35 UTC (rev 127459)
@@ -1,3 +1,15 @@
+2012-09-04 Andrey Adaikin aand...@chromium.org
+
+Web Inspector: [WebGL] Bugfix: wrong texture binding target in replay for 3D textures
+https://bugs.webkit.org/show_bug.cgi?id=95687
+
+Reviewed by Vsevolod Vlasov.
+
+gl.bindTexture accepts either TEXTURE_2D or TEXTURE_CUBE_MAP targets, but we tried to replay with TEXTURE_CUBE_MAP_POSITIVE_X and others for 3D textures.
+
+* inspector/InjectedScriptWebGLModuleSource.js:
+(.):
+
2012-09-04 Allan Sandfeld Jensen allan.jen...@nokia.com
Allow child-frame content in hit-tests.
Modified: trunk/Source/WebCore/inspector/InjectedScriptWebGLModuleSource.js (127458 => 127459)
--- trunk/Source/WebCore/inspector/InjectedScriptWebGLModuleSource.js 2012-09-04 12:11:13 UTC (rev 127458)
+++ trunk/Source/WebCore/inspector/InjectedScriptWebGLModuleSource.js 2012-09-04 12:30:35 UTC (rev 127459)
@@ -1456,19 +1456,20 @@
if (resource)
return resource;
var gl = this.wrappedObject();
-var bindingTarget;
+var bindingParameter;
var bindMethodName;
+var bindMethodTarget = target;
switch (target) {
case gl.ARRAY_BUFFER:
-bindingTarget = gl.ARRAY_BUFFER_BINDING;
+bindingParameter = gl.ARRAY_BUFFER_BINDING;
bindMethodName = bindBuffer;
break;
case gl.ELEMENT_ARRAY_BUFFER:
-bindingTarget = gl.ELEMENT_ARRAY_BUFFER_BINDING;
+bindingParameter = gl.ELEMENT_ARRAY_BUFFER_BINDING;
bindMethodName = bindBuffer;
break;
case gl.TEXTURE_2D:
-bindingTarget = gl.TEXTURE_BINDING_2D;
+bindingParameter = gl.TEXTURE_BINDING_2D;
bindMethodName = bindTexture;
break;
case gl.TEXTURE_CUBE_MAP:
@@ -1478,24 +1479,25 @@
case gl.TEXTURE_CUBE_MAP_NEGATIVE_Y:
case gl.TEXTURE_CUBE_MAP_POSITIVE_Z:
case gl.TEXTURE_CUBE_MAP_NEGATIVE_Z:
-bindingTarget = gl.TEXTURE_BINDING_CUBE_MAP;
+bindingParameter = gl.TEXTURE_BINDING_CUBE_MAP;
+bindMethodTarget = gl.TEXTURE_CUBE_MAP;
bindMethodName = bindTexture;
break;
case gl.FRAMEBUFFER:
-bindingTarget = gl.FRAMEBUFFER_BINDING;
+bindingParameter = gl.FRAMEBUFFER_BINDING;
bindMethodName = bindFramebuffer;
break;
case gl.RENDERBUFFER:
-bindingTarget = gl.RENDERBUFFER_BINDING;
+bindingParameter = gl.RENDERBUFFER_BINDING;
bindMethodName = bindRenderbuffer;
break;
default:
console.error(ASSERT_NOT_REACHED: unknown binding target + target);
return null;
}
-resource = Resource.forObject(gl.getParameter(bindingTarget));
+resource = Resource.forObject(gl.getParameter(bindingParameter));
if (resource)
-resource.pushBinding(target, bindMethodName);
+resource.pushBinding(bindMethodTarget, bindMethodName);
return resource;
},
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [127461] trunk/LayoutTests
Title: [127461] trunk/LayoutTests Revision 127461 Author vse...@chromium.org Date 2012-09-04 05:51:20 -0700 (Tue, 04 Sep 2012) Log Message Web Inspector: Skip inspector WebGL tests where WebGL is disabled https://bugs.webkit.org/show_bug.cgi?id=95733 Patch by Andrey Adaikin aand...@chromium.org on 2012-09-04 Reviewed by Vsevolod Vlasov. This is to update Skipped and TestExpectations files. * platform/efl/TestExpectations: * platform/win/Skipped: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/efl/TestExpectations trunk/LayoutTests/platform/win/Skipped Diff Modified: trunk/LayoutTests/ChangeLog (127460 => 127461) --- trunk/LayoutTests/ChangeLog 2012-09-04 12:34:23 UTC (rev 127460) +++ trunk/LayoutTests/ChangeLog 2012-09-04 12:51:20 UTC (rev 127461) @@ -1,3 +1,15 @@ +2012-09-04 Andrey Adaikin aand...@chromium.org + +Web Inspector: Skip inspector WebGL tests where WebGL is disabled +https://bugs.webkit.org/show_bug.cgi?id=95733 + +Reviewed by Vsevolod Vlasov. + +This is to update Skipped and TestExpectations files. + +* platform/efl/TestExpectations: +* platform/win/Skipped: + 2012-09-04 Thiago Marcos P. Santos thiago.san...@intel.com [EFL] Gardening of failing tests Modified: trunk/LayoutTests/platform/efl/TestExpectations (127460 => 127461) --- trunk/LayoutTests/platform/efl/TestExpectations 2012-09-04 12:34:23 UTC (rev 127460) +++ trunk/LayoutTests/platform/efl/TestExpectations 2012-09-04 12:51:20 UTC (rev 127461) @@ -542,8 +542,7 @@ BUGWK77219 SKIP : http/tests/security/webgl-remote-read-remote-image-allowed-with-credentials.html = TEXT BUGWK77219 SKIP : http/tests/security/webgl-remote-read-remote-image-allowed.html = TEXT BUGWK77219 SKIP : http/tests/security/webgl-remote-read-remote-image-blocked-no-crossorigin.html = TEXT -BUGWK77219 : inspector/profiler/webgl/webgl-profiler-api-changes.html = TEXT -BUGWK77219 : inspector/profiler/webgl/webgl-profiler-get-error.html = TEXT +BUGWK77219 SKIP : inspector/profiler/webgl = TEXT BUGWK84759 : ietestcenter/css3/multicolumn/column-containing-block-001.htm = IMAGE BUGWK84760 : ietestcenter/css3/multicolumn/column-containing-block-002.htm = IMAGE Modified: trunk/LayoutTests/platform/win/Skipped (127460 => 127461) --- trunk/LayoutTests/platform/win/Skipped 2012-09-04 12:34:23 UTC (rev 127460) +++ trunk/LayoutTests/platform/win/Skipped 2012-09-04 12:51:20 UTC (rev 127461) @@ -1472,7 +1472,7 @@ http/tests/security/webgl-remote-read-remote-image-allowed.html http/tests/security/webgl-remote-read-remote-image-allowed-with-credentials.html http/tests/security/webgl-remote-read-remote-image-blocked-no-crossorigin.html -inspector/profiler/webgl/webgl-profiler-api-changes.html +inspector/profiler/webgl # Tests that require ENABLE(DOWNLOAD_ATTRIBUTE). fast/dom/HTMLAnchorElement/anchor-nodownload.html ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [127462] trunk
Title: [127462] trunk Revision 127462 Author commit-qu...@webkit.org Date 2012-09-04 06:13:08 -0700 (Tue, 04 Sep 2012) Log Message .: [EFL] Context menu restore. https://bugs.webkit.org/show_bug.cgi?id=74179 Patch by Michał Pakuła vel Rutka m.pak...@samsung.com on 2012-09-04 Reviewed by Gyuyoung Kim. Adds context menu support for EFL port using non-CROSS_PLATFORM_CONTEXT_MENUS approach, the same as used in WebKit2. * Source/cmake/OptionsEfl.cmake: Turn on CONTEXT_MENUS flag for EFL port Source/WebCore: [EFL] Context menu restore. https://bugs.webkit.org/show_bug.cgi?id=74179 Patch by Michał Pakuła vel Rutka m.pak...@samsung.com on 2012-09-04 Reviewed by Gyuyoung Kim. Adds context menu support for EFL port using non-CROSS_PLATFORM_CONTEXT_MENUS approach, the same as used in WebKit2. * PlatformEfl.cmake: Removed -DWTF_USE_CROSS_PLATFORM_CONTEXT_MENUS=1 Source/WebKit: [EFL] Context menu restore. https://bugs.webkit.org/show_bug.cgi?id=74179 Patch by Michał Pakuła vel Rutka m.pak...@samsung.com on 2012-09-04 Reviewed by Gyuyoung Kim. Adds context menu support for EFL port using non-CROSS_PLATFORM_CONTEXT_MENUS approach, the same as used in WebKit2. * PlatformEfl.cmake: Added ContextMenuClientEfl.cpp file to sources list. Source/WebKit/efl: [EFL] Context menu restore. https://bugs.webkit.org/show_bug.cgi?id=74179 Patch by Michał Pakuła vel Rutka m.pak...@samsung.com on 2012-09-04 Reviewed by Gyuyoung Kim. Adds context menu support for EFL port using non-CROSS_PLATFORM_CONTEXT_MENUS approach, the same as used in WebKit2. * WebCoreSupport/ContextMenuClientEfl.cpp: Added. (WebCore): (WebCore::ContextMenuClientEfl::contextMenuDestroyed): (WebCore::ContextMenuClientEfl::getCustomMenuFromDefaultItems): (WebCore::ContextMenuClientEfl::contextMenuItemSelected): (WebCore::ContextMenuClientEfl::downloadURL): (WebCore::ContextMenuClientEfl::lookUpInDictionary): (WebCore::ContextMenuClientEfl::speak): (WebCore::ContextMenuClientEfl::isSpeaking): (WebCore::ContextMenuClientEfl::stopSpeaking): (WebCore::ContextMenuClientEfl::searchWithGoogle): * WebCoreSupport/ContextMenuClientEfl.h: Added. (WebCore): (ContextMenuClientEfl): * ewk/ewk_contextmenu.cpp: Removed ewk_context_menu_customize implementation. (ewk_context_menu_destroy): Added freeing context menu. (ewk_context_menu_new): Added filling ewk_contextmenu list. (ewk_context_menu_item_append): * ewk/ewk_contextmenu_private.h: Removed ewk_context_menu_customize and changed ewk_context_menu_new definition. * ewk/ewk_view.cpp: (_Ewk_View_Private_Data): (_ewk_view_priv_new): (_ewk_view_priv_del): (ewk_view_context_menu_forward_event): Modified Paths trunk/ChangeLog trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/PlatformEfl.cmake trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/PlatformEfl.cmake trunk/Source/WebKit/efl/ChangeLog trunk/Source/WebKit/efl/ewk/ewk_contextmenu.cpp trunk/Source/WebKit/efl/ewk/ewk_contextmenu_private.h trunk/Source/WebKit/efl/ewk/ewk_view.cpp trunk/Source/cmake/OptionsEfl.cmake Added Paths trunk/Source/WebKit/efl/WebCoreSupport/ContextMenuClientEfl.cpp trunk/Source/WebKit/efl/WebCoreSupport/ContextMenuClientEfl.h Diff Modified: trunk/ChangeLog (127461 => 127462) --- trunk/ChangeLog 2012-09-04 12:51:20 UTC (rev 127461) +++ trunk/ChangeLog 2012-09-04 13:13:08 UTC (rev 127462) @@ -1,3 +1,15 @@ +2012-09-04 Michał Pakuła vel Rutka m.pak...@samsung.com + +[EFL] Context menu restore. +https://bugs.webkit.org/show_bug.cgi?id=74179 + +Reviewed by Gyuyoung Kim. + +Adds context menu support for EFL port using non-CROSS_PLATFORM_CONTEXT_MENUS +approach, the same as used in WebKit2. + +* Source/cmake/OptionsEfl.cmake: Turn on CONTEXT_MENUS flag for EFL port + 2012-09-04 Allan Sandfeld Jensen allan.jen...@nokia.com Allow child-frame content in hit-tests. Modified: trunk/Source/WebCore/ChangeLog (127461 => 127462) --- trunk/Source/WebCore/ChangeLog 2012-09-04 12:51:20 UTC (rev 127461) +++ trunk/Source/WebCore/ChangeLog 2012-09-04 13:13:08 UTC (rev 127462) @@ -1,3 +1,15 @@ +2012-09-04 Michał Pakuła vel Rutka m.pak...@samsung.com + +[EFL] Context menu restore. +https://bugs.webkit.org/show_bug.cgi?id=74179 + +Reviewed by Gyuyoung Kim. + +Adds context menu support for EFL port using non-CROSS_PLATFORM_CONTEXT_MENUS +approach, the same as used in WebKit2. + +* PlatformEfl.cmake: Removed -DWTF_USE_CROSS_PLATFORM_CONTEXT_MENUS=1 + 2012-09-04 Andrey Adaikin aand...@chromium.org Web Inspector: [WebGL] Bugfix: wrong texture binding target in replay for 3D textures Modified: trunk/Source/WebCore/PlatformEfl.cmake (127461 => 127462) --- trunk/Source/WebCore/PlatformEfl.cmake 2012-09-04 12:51:20 UTC (rev 127461) +++ trunk/Source/WebCore/PlatformEfl.cmake 2012-09-04 13:13:08 UTC (rev 127462) @@ -297,8 +297,7 @@ ) ENDIF () -ADD_DEFINITIONS(-DWTF_USE_CROSS_PLATFORM_CONTEXT_MENUS=1 -
[webkit-changes] [127463] trunk
Title: [127463] trunk Revision 127463 Author commit-qu...@webkit.org Date 2012-09-04 06:30:35 -0700 (Tue, 04 Sep 2012) Log Message [EFL][WK2] CSS3 Media Queries functionality is broken https://bugs.webkit.org/show_bug.cgi?id=95680 Patch by Alexander Shalamov alexander.shala...@intel.com on 2012-09-04 Reviewed by Kenneth Rohde Christiansen. Source/WebCore: In WK2, WebProcess doesn't have access to ewk_view evas object. Methods that get screen rect or screen depth either return incorrect value or crash. This patch removes dependency to ewk_view evas object and relies on ecore_x_* functions to get screen rectangle or color depth of the screen. * platform/efl/EflScreenUtilities.cpp: removed unused getPixelDepth method definition * platform/efl/EflScreenUtilities.h: removed unsused getPixelDepth method declaration (WebCore): * platform/efl/PlatformScreenEfl.cpp: (WebCore): (WebCore::screenHorizontalDPI): (WebCore::screenVerticalDPI): (WebCore::screenDepth): (WebCore::screenDepthPerComponent): (WebCore::screenIsMonochrome): (WebCore::screenRect): LayoutTests: Unskipped passing CSS3 Media Query tests. * platform/efl-wk2/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/efl-wk2/TestExpectations trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/platform/efl/EflScreenUtilities.cpp trunk/Source/WebCore/platform/efl/EflScreenUtilities.h trunk/Source/WebCore/platform/efl/PlatformScreenEfl.cpp Diff Modified: trunk/LayoutTests/ChangeLog (127462 => 127463) --- trunk/LayoutTests/ChangeLog 2012-09-04 13:13:08 UTC (rev 127462) +++ trunk/LayoutTests/ChangeLog 2012-09-04 13:30:35 UTC (rev 127463) @@ -1,3 +1,14 @@ +2012-09-04 Alexander Shalamov alexander.shala...@intel.com + +[EFL][WK2] CSS3 Media Queries functionality is broken +https://bugs.webkit.org/show_bug.cgi?id=95680 + +Reviewed by Kenneth Rohde Christiansen. + +Unskipped passing CSS3 Media Query tests. + +* platform/efl-wk2/TestExpectations: + 2012-09-04 Andrey Adaikin aand...@chromium.org Web Inspector: Skip inspector WebGL tests where WebGL is disabled Modified: trunk/LayoutTests/platform/efl-wk2/TestExpectations (127462 => 127463) --- trunk/LayoutTests/platform/efl-wk2/TestExpectations 2012-09-04 13:13:08 UTC (rev 127462) +++ trunk/LayoutTests/platform/efl-wk2/TestExpectations 2012-09-04 13:30:35 UTC (rev 127463) @@ -245,7 +245,6 @@ BUGWKEFL : fast/block/float/float-in-float-hit-testing.html = TEXT BUGWKEFL : fast/cookies/local-file-can-set-cookies.html = TEXT BUGWKEFL : fast/css/bidi-override-in-anonymous-block.html = TEXT -BUGWKEFL : fast/css/media-rule-screenDepthPerComponent.html = TEXT BUGWKEFL : fast/css/relative-positioned-block-crash.html = TEXT BUGWKEFL : fast/dom/Window/mozilla-focus-blur.html = TEXT BUGWKEFL : fast/dom/Window/timer-resume-on-navigation-back.html = TEXT @@ -268,18 +267,6 @@ BUGWKEFL : fast/frames/flattening/iframe-tiny.html = TEXT BUGWKEFL : fast/harness/use-page-cache.html = TEXT BUGWKEFL : fast/history/timed-refresh-in-cached-frame.html = TEXT -BUGWKEFL : fast/media/color-does-not-include-alpha.html = TEXT -BUGWKEFL : fast/media/implicit-media-all.html = TEXT -BUGWKEFL : fast/media/mq-compound-query-01.html = TEXT -BUGWKEFL : fast/media/mq-compound-query-02.html = TEXT -BUGWKEFL : fast/media/mq-compound-query-03.html = TEXT -BUGWKEFL : fast/media/mq-compound-query-04.html = TEXT -BUGWKEFL : fast/media/mq-js-media-except-01.html = TEXT -BUGWKEFL : fast/media/mq-js-stylesheet-media-01.html = TEXT -BUGWKEFL : fast/media/mq-js-stylesheet-media-02.html = TEXT -BUGWKEFL : fast/media/mq-js-stylesheet-media-03.html = TEXT -BUGWKEFL : fast/media/mq-simple-query-05.html = TEXT -BUGWKEFL : fast/media/mq-valueless.html = TEXT BUGWKEFL : fast/repaint/fixed-move-after-keyboard-scroll.html = TEXT BUGWKEFL : fast/replaced/no-focus-ring-embed.html = TEXT BUGWKEFL : fast/replaced/no-focus-ring-object.html = TEXT Modified: trunk/Source/WebCore/ChangeLog (127462 => 127463) --- trunk/Source/WebCore/ChangeLog 2012-09-04 13:13:08 UTC (rev 127462) +++ trunk/Source/WebCore/ChangeLog 2012-09-04 13:30:35 UTC (rev 127463) @@ -1,3 +1,27 @@ +2012-09-04 Alexander Shalamov alexander.shala...@intel.com + +[EFL][WK2] CSS3 Media Queries functionality is broken +https://bugs.webkit.org/show_bug.cgi?id=95680 + +Reviewed by Kenneth Rohde Christiansen. + +In WK2, WebProcess doesn't have access to ewk_view evas object. +Methods that get screen rect or screen depth either return incorrect value or crash. +This patch removes dependency to ewk_view evas object and relies on ecore_x_* functions +to get screen rectangle or color depth of the screen. + +* platform/efl/EflScreenUtilities.cpp: removed unused getPixelDepth method definition +* platform/efl/EflScreenUtilities.h: removed unsused getPixelDepth method declaration +(WebCore): +*
[webkit-changes] [127464] trunk
Title: [127464] trunk
Revision 127464
Author commit-qu...@webkit.org
Date 2012-09-04 06:32:29 -0700 (Tue, 04 Sep 2012)
Log Message
[EFL] Check if ecore_x is initialised before calling ecore_x_bell to avoid crash
https://bugs.webkit.org/show_bug.cgi?id=86961
Patch by Alexander Shalamov alexander.shala...@intel.com on 2012-09-04
Reviewed by Kenneth Rohde Christiansen.
Source/WebCore:
Add ecore_x initialisation check before calling ecore_x_bell
to avoid crashes when X server is not running.
* platform/efl/SoundEfl.cpp:
(WebCore::systemBeep):
LayoutTests:
Unskipped two layout tests that were crashing.
* platform/efl/TestExpectations:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/efl/TestExpectations
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/efl/SoundEfl.cpp
Diff
Modified: trunk/LayoutTests/ChangeLog (127463 => 127464)
--- trunk/LayoutTests/ChangeLog 2012-09-04 13:30:35 UTC (rev 127463)
+++ trunk/LayoutTests/ChangeLog 2012-09-04 13:32:29 UTC (rev 127464)
@@ -1,5 +1,16 @@
2012-09-04 Alexander Shalamov alexander.shala...@intel.com
+[EFL] Check if ecore_x is initialised before calling ecore_x_bell to avoid crash
+https://bugs.webkit.org/show_bug.cgi?id=86961
+
+Reviewed by Kenneth Rohde Christiansen.
+
+Unskipped two layout tests that were crashing.
+
+* platform/efl/TestExpectations:
+
+2012-09-04 Alexander Shalamov alexander.shala...@intel.com
+
[EFL][WK2] CSS3 Media Queries functionality is broken
https://bugs.webkit.org/show_bug.cgi?id=95680
Modified: trunk/LayoutTests/platform/efl/TestExpectations (127463 => 127464)
--- trunk/LayoutTests/platform/efl/TestExpectations 2012-09-04 13:30:35 UTC (rev 127463)
+++ trunk/LayoutTests/platform/efl/TestExpectations 2012-09-04 13:32:29 UTC (rev 127464)
@@ -759,10 +759,6 @@
BUGWK86187 : media/media-fullscreen-not-in-document.html = TEXT
BUGWK86187 SKIP : media/media-fullscreen-inline.html = PASS
-// ecore_x library is not initialized and calls to it cause crashes
-BUGWK86961 : editing/execCommand/paste-and-match-style-event.html = CRASH
-BUGWK86961 : fast/dom/shadow/cppevent-in-shadow.html = CRASH
-
// Selection problem in Shadow DOM test (passes on GTK)
BUGWKEFL : fast/dom/shadow/selections-in-shadow.html = TEXT
Modified: trunk/Source/WebCore/ChangeLog (127463 => 127464)
--- trunk/Source/WebCore/ChangeLog 2012-09-04 13:30:35 UTC (rev 127463)
+++ trunk/Source/WebCore/ChangeLog 2012-09-04 13:32:29 UTC (rev 127464)
@@ -1,5 +1,18 @@
2012-09-04 Alexander Shalamov alexander.shala...@intel.com
+[EFL] Check if ecore_x is initialised before calling ecore_x_bell to avoid crash
+https://bugs.webkit.org/show_bug.cgi?id=86961
+
+Reviewed by Kenneth Rohde Christiansen.
+
+Add ecore_x initialisation check before calling ecore_x_bell
+to avoid crashes when X server is not running.
+
+* platform/efl/SoundEfl.cpp:
+(WebCore::systemBeep):
+
+2012-09-04 Alexander Shalamov alexander.shala...@intel.com
+
[EFL][WK2] CSS3 Media Queries functionality is broken
https://bugs.webkit.org/show_bug.cgi?id=95680
Modified: trunk/Source/WebCore/platform/efl/SoundEfl.cpp (127463 => 127464)
--- trunk/Source/WebCore/platform/efl/SoundEfl.cpp 2012-09-04 13:30:35 UTC (rev 127463)
+++ trunk/Source/WebCore/platform/efl/SoundEfl.cpp 2012-09-04 13:32:29 UTC (rev 127464)
@@ -39,7 +39,10 @@
void systemBeep()
{
#ifdef HAVE_ECORE_X
-ecore_x_bell(0);
+if (ecore_x_init(0)) {
+ecore_x_bell(0);
+ecore_x_shutdown();
+}
#endif
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [127465] trunk/Source/WebCore
Title: [127465] trunk/Source/WebCore
Revision 127465
Author commit-qu...@webkit.org
Date 2012-09-04 06:34:10 -0700 (Tue, 04 Sep 2012)
Log Message
[Cairo] [TextureMapper] Assertion failure in TextureMapperGL
https://bugs.webkit.org/show_bug.cgi?id=95713
Patch by Martin Robinson mrobin...@igalia.com on 2012-09-04
Reviewed by Noam Rosenthal.
Fix an assertion failure by returning a valid context always for GraphicsContext3D::platformContext.
This is important because TextureMapperGL uses the platform context to perform hashing.
No new tests. This is covered by existing accelerated compositing tests.
* platform/graphics/cairo/GraphicsContext3DPrivate.cpp:
(WebCore::GraphicsContext3DPrivate::platformContext): Return the current GLContext
when getting the platform context for private GraphicsContext3DPrivates that render
to the currently active context.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/cairo/GraphicsContext3DPrivate.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (127464 => 127465)
--- trunk/Source/WebCore/ChangeLog 2012-09-04 13:32:29 UTC (rev 127464)
+++ trunk/Source/WebCore/ChangeLog 2012-09-04 13:34:10 UTC (rev 127465)
@@ -1,3 +1,20 @@
+2012-09-04 Martin Robinson mrobin...@igalia.com
+
+[Cairo] [TextureMapper] Assertion failure in TextureMapperGL
+https://bugs.webkit.org/show_bug.cgi?id=95713
+
+Reviewed by Noam Rosenthal.
+
+Fix an assertion failure by returning a valid context always for GraphicsContext3D::platformContext.
+This is important because TextureMapperGL uses the platform context to perform hashing.
+
+No new tests. This is covered by existing accelerated compositing tests.
+
+* platform/graphics/cairo/GraphicsContext3DPrivate.cpp:
+(WebCore::GraphicsContext3DPrivate::platformContext): Return the current GLContext
+when getting the platform context for private GraphicsContext3DPrivates that render
+to the currently active context.
+
2012-09-04 Alexander Shalamov alexander.shala...@intel.com
[EFL] Check if ecore_x is initialised before calling ecore_x_bell to avoid crash
Modified: trunk/Source/WebCore/platform/graphics/cairo/GraphicsContext3DPrivate.cpp (127464 => 127465)
--- trunk/Source/WebCore/platform/graphics/cairo/GraphicsContext3DPrivate.cpp 2012-09-04 13:32:29 UTC (rev 127464)
+++ trunk/Source/WebCore/platform/graphics/cairo/GraphicsContext3DPrivate.cpp 2012-09-04 13:34:10 UTC (rev 127465)
@@ -68,7 +68,7 @@
PlatformGraphicsContext3D GraphicsContext3DPrivate::platformContext()
{
-return m_glContext ? m_glContext-platformContext() : 0;
+return m_glContext ? m_glContext-platformContext() : GLContext::getCurrent()-platformContext();
}
#if USE(ACCELERATED_COMPOSITING) USE(TEXTURE_MAPPER)
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [127466] trunk
Title: [127466] trunk
Revision 127466
Author commit-qu...@webkit.org
Date 2012-09-04 06:36:10 -0700 (Tue, 04 Sep 2012)
Log Message
[Stable] [GTK] Crash in WebCore::HTMLSelectElement::selectedIndex
https://bugs.webkit.org/show_bug.cgi?id=95618
Patch by Mario Sanchez Prada msanc...@igalia.com on 2012-09-04
Reviewed by Martin Robinson.
Source/WebCore:
Make sure we only emit the the signal for menu lists and list
boxes rendered from actual HTML select elements.
* accessibility/gtk/AXObjectCacheAtk.cpp:
(WebCore::notifyChildrenSelectionChange): We support accessibility
ListBoxes and MenuLists only here, assuming they represent HTML
select elements, which might be not always true (e.g. ARIA). Thus,
check if that condition is true, early returning in other case.
LayoutTests:
New layout test to ensure we don't crash with ATK notifications
anymore when changing the selection in an ARIA listbox.
* platform/gtk/accessibility/aria-listbox-crash-expected.txt: Added.
* platform/gtk/accessibility/aria-listbox-crash.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/accessibility/gtk/AXObjectCacheAtk.cpp
Added Paths
trunk/LayoutTests/platform/gtk/accessibility/aria-listbox-crash-expected.txt
trunk/LayoutTests/platform/gtk/accessibility/aria-listbox-crash.html
Diff
Modified: trunk/LayoutTests/ChangeLog (127465 => 127466)
--- trunk/LayoutTests/ChangeLog 2012-09-04 13:34:10 UTC (rev 127465)
+++ trunk/LayoutTests/ChangeLog 2012-09-04 13:36:10 UTC (rev 127466)
@@ -1,3 +1,16 @@
+2012-09-04 Mario Sanchez Prada msanc...@igalia.com
+
+[Stable] [GTK] Crash in WebCore::HTMLSelectElement::selectedIndex
+https://bugs.webkit.org/show_bug.cgi?id=95618
+
+Reviewed by Martin Robinson.
+
+New layout test to ensure we don't crash with ATK notifications
+anymore when changing the selection in an ARIA listbox.
+
+* platform/gtk/accessibility/aria-listbox-crash-expected.txt: Added.
+* platform/gtk/accessibility/aria-listbox-crash.html: Added.
+
2012-09-04 Alexander Shalamov alexander.shala...@intel.com
[EFL] Check if ecore_x is initialised before calling ecore_x_bell to avoid crash
Added: trunk/LayoutTests/platform/gtk/accessibility/aria-listbox-crash-expected.txt (0 => 127466)
--- trunk/LayoutTests/platform/gtk/accessibility/aria-listbox-crash-expected.txt (rev 0)
+++ trunk/LayoutTests/platform/gtk/accessibility/aria-listbox-crash-expected.txt 2012-09-04 13:36:10 UTC (rev 127466)
@@ -0,0 +1,11 @@
+foo
+bar
+This tests that selecting an option in an ARIA listbox doesn't crash.
+
+On success, you will see a series of PASS messages, followed by TEST COMPLETE.
+
+
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
Added: trunk/LayoutTests/platform/gtk/accessibility/aria-listbox-crash.html (0 => 127466)
--- trunk/LayoutTests/platform/gtk/accessibility/aria-listbox-crash.html (rev 0)
+++ trunk/LayoutTests/platform/gtk/accessibility/aria-listbox-crash.html 2012-09-04 13:36:10 UTC (rev 127466)
@@ -0,0 +1,49 @@
+!DOCTYPE HTML PUBLIC -//IETF//DTD HTML//EN
+html
+head
+script src=""
+script
+function test()
+{
+ description(This tests that selecting an option in an ARIA listbox doesn't crash.);
+
+ if (window.testRunner) {
+testRunner.dumpAsText();
+testRunner.waitUntilDone();
+
+// We focus on the body and get the associated accessibility
+// object to force the creation of the accessibility hierarchy.
+if (window.accessibilityController)
+ document.getElementById(body).focus();
+ accessibilityController.focusedElement;
+}
+
+ // Get references to the list and the items, and change selection.
+ list = document.getElementById('list');
+ preSelectedItem = document.getElementById('list_item_1');
+ targetItem = document.getElementById('list_item_2');
+
+ list.setAttribute('aria-activedescendant', targetItem.id);
+ preSelectedItem.setAttribute('aria-selected', false);
+ targetItem.setAttribute('aria-selected', true);
+
+ // We need to finish on idle to give room for the crash to happen,
+ // since it's supposed to crash because of a notification about the
+ // selection changing and so if we notifyDone() now it would be too
+ // soon and we would skip such emission, not crashing at all.
+ window.setTimeout(testRunner.notifyDone(),0);
+}
+/script
+/head
+body id=body _onload_=test();
+ul id=list role=listbox aria-activedescendant=list_item_1
+ li id=list_item_1 role=option aria-selected=falsefoo/li
+ li id=list_item_2 role=option aria-selected=falsebar/li
+/ul
+
+p id=description/p
+div id=console/div
+
+script src=""
+/body
+/html
Modified: trunk/Source/WebCore/ChangeLog (127465 => 127466)
--- trunk/Source/WebCore/ChangeLog 2012-09-04 13:34:10 UTC (rev 127465)
+++ trunk/Source/WebCore/ChangeLog 2012-09-04 13:36:10 UTC (rev 127466)
@@ -1,3 +1,19 @@
+2012-09-04 Mario Sanchez Prada
[webkit-changes] [127467] trunk/Source/WebCore
Title: [127467] trunk/Source/WebCore
Revision 127467
Author commit-qu...@webkit.org
Date 2012-09-04 06:48:51 -0700 (Tue, 04 Sep 2012)
Log Message
Fix IDL dependency generation correctly
https://bugs.webkit.org/show_bug.cgi?id=95730
Patch by Jonathan Liu net...@gmail.com on 2012-09-04
Reviewed by Csaba Osztrogonác.
IDL dependency generation is still not working after
https://bugs.webkit.org/show_bug.cgi?id=88304. This is because spaces
added after the filename in an echo command end up being added to the
file which isn't handled correctly by preprocess-idls.pl. The problem
is fixed by removing the space after the filename.
* DerivedSources.pri:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/DerivedSources.pri
Diff
Modified: trunk/Source/WebCore/ChangeLog (127466 => 127467)
--- trunk/Source/WebCore/ChangeLog 2012-09-04 13:36:10 UTC (rev 127466)
+++ trunk/Source/WebCore/ChangeLog 2012-09-04 13:48:51 UTC (rev 127467)
@@ -1,3 +1,18 @@
+2012-09-04 Jonathan Liu net...@gmail.com
+
+Fix IDL dependency generation correctly
+https://bugs.webkit.org/show_bug.cgi?id=95730
+
+Reviewed by Csaba Osztrogonác.
+
+IDL dependency generation is still not working after
+https://bugs.webkit.org/show_bug.cgi?id=88304. This is because spaces
+added after the filename in an echo command end up being added to the
+file which isn't handled correctly by preprocess-idls.pl. The problem
+is fixed by removing the space after the filename.
+
+* DerivedSources.pri:
+
2012-09-04 Mario Sanchez Prada msanc...@igalia.com
[Stable] [GTK] Crash in WebCore::HTMLSelectElement::selectedIndex
Modified: trunk/Source/WebCore/DerivedSources.pri (127466 => 127467)
--- trunk/Source/WebCore/DerivedSources.pri 2012-09-04 13:36:10 UTC (rev 127466)
+++ trunk/Source/WebCore/DerivedSources.pri 2012-09-04 13:48:51 UTC (rev 127467)
@@ -705,7 +705,8 @@
else: preprocessIdls.commands = cat /dev/null $$IDL_FILES_TMP $$EOC
for(binding, IDL_BINDINGS) {
# We need $$binding instead of $$binding , because Windows' echo writes trailing whitespaces. (http://wkb.ug/88304)
-preprocessIdls.commands += echo $$binding $$IDL_FILES_TMP $$EOC
+# A space is omitted between $$IDL_FILES_TMP and $$EOC to also avoid writing trailing whitespace. (http://wkb.ug/95730)
+preprocessIdls.commands += echo $$binding $$IDL_FILES_TMP$$EOC
}
preprocessIdls.commands += perl -I$$PWD/bindings/scripts $$preprocessIdls.script \
--defines \$${FEATURE_DEFINES_JAVASCRIPT}\ \
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [127469] trunk/Source/WebCore
Title: [127469] trunk/Source/WebCore
Revision 127469
Author ph...@webkit.org
Date 2012-09-04 08:45:38 -0700 (Tue, 04 Sep 2012)
Log Message
[GStreamer] 0.11 build breaks due to rename of gst_message_new_duration
https://bugs.webkit.org/show_bug.cgi?id=95751
Reviewed by Martin Robinson.
In gstreamer commit f712a9596c2bc1863edf9b816d9854eefca9ba45
gst_message_new_duration was renamed to
gst_message_new_duration_changed.
However the only place where we used this is in the HTTP source
element and only if appsrc 0.10.27 is used at runtime. In the
case of GStreamer 1.0 this condition will be always false so we
can disable this code at build time.
* platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
(StreamingClient::didReceiveResponse):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (127468 => 127469)
--- trunk/Source/WebCore/ChangeLog 2012-09-04 15:32:27 UTC (rev 127468)
+++ trunk/Source/WebCore/ChangeLog 2012-09-04 15:45:38 UTC (rev 127469)
@@ -1,3 +1,22 @@
+2012-09-04 Philippe Normand pnorm...@igalia.com
+
+[GStreamer] 0.11 build breaks due to rename of gst_message_new_duration
+https://bugs.webkit.org/show_bug.cgi?id=95751
+
+Reviewed by Martin Robinson.
+
+In gstreamer commit f712a9596c2bc1863edf9b816d9854eefca9ba45
+gst_message_new_duration was renamed to
+gst_message_new_duration_changed.
+
+However the only place where we used this is in the HTTP source
+element and only if appsrc 0.10.27 is used at runtime. In the
+case of GStreamer 1.0 this condition will be always false so we
+can disable this code at build time.
+
+* platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
+(StreamingClient::didReceiveResponse):
+
2012-09-04 Andrei Poenaru poen...@adobe.com
Web Inspector: Protocol Extension: Add regionLayoutUpdate event
Modified: trunk/Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp (127468 => 127469)
--- trunk/Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp 2012-09-04 15:32:27 UTC (rev 127468)
+++ trunk/Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp 2012-09-04 15:45:38 UTC (rev 127469)
@@ -782,18 +782,15 @@
if (length 0) {
length += priv-requestedOffset;
gst_app_src_set_size(priv-appsrc, length);
+
+#ifndef GST_API_VERSION_1
if (!priv-haveAppSrc27) {
-#ifdef GST_API_VERSION_1
-GstSegment* segment = GST_BASE_SRC(priv-appsrc)-segment;
-segment-duration = length;
-segment-format = GST_FORMAT_BYTES;
-#else
gst_segment_set_duration(GST_BASE_SRC(priv-appsrc)-segment, GST_FORMAT_BYTES, length);
-#endif
gst_element_post_message(GST_ELEMENT(priv-appsrc),
gst_message_new_duration(GST_OBJECT(priv-appsrc),
GST_FORMAT_BYTES, length));
}
+#endif
}
priv-size = length = 0 ? length : 0;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [127470] trunk/Source/WebCore
Title: [127470] trunk/Source/WebCore
Revision 127470
Author commit-qu...@webkit.org
Date 2012-09-04 08:47:25 -0700 (Tue, 04 Sep 2012)
Log Message
[BlackBerry] Browser is not sending secured Cookie back to server over HTTPS connection
https://bugs.webkit.org/show_bug.cgi?id=95747
PR199729
Patch by Otto Derek Cheung otche...@rim.com on 2012-09-04
Reviewed by Rob Buis.
Internally Reviewed by Joe Mason.
If the browser has never saved a secure protocol cookie in its mapping before,
and it tries to set and retreive a secure cookie over a non-secure
protocol, it will not show up because the link between the secure and
non-secure mapping isn't created until a cookie (sent through secure) is set.
The fix is to also check for the linkage in getRawCookies. Note that we cannot
map the secure CookieMap to the non-secure one because getRawCookies is a const
function.
Manually tested using our Browser Test suite.
* platform/blackberry/CookieManager.cpp:
(WebCore::CookieManager::getRawCookies):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/blackberry/CookieManager.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (127469 => 127470)
--- trunk/Source/WebCore/ChangeLog 2012-09-04 15:45:38 UTC (rev 127469)
+++ trunk/Source/WebCore/ChangeLog 2012-09-04 15:47:25 UTC (rev 127470)
@@ -1,3 +1,27 @@
+2012-09-04 Otto Derek Cheung otche...@rim.com
+
+[BlackBerry] Browser is not sending secured Cookie back to server over HTTPS connection
+https://bugs.webkit.org/show_bug.cgi?id=95747
+
+PR199729
+
+Reviewed by Rob Buis.
+Internally Reviewed by Joe Mason.
+
+If the browser has never saved a secure protocol cookie in its mapping before,
+and it tries to set and retreive a secure cookie over a non-secure
+protocol, it will not show up because the link between the secure and
+non-secure mapping isn't created until a cookie (sent through secure) is set.
+
+The fix is to also check for the linkage in getRawCookies. Note that we cannot
+map the secure CookieMap to the non-secure one because getRawCookies is a const
+function.
+
+Manually tested using our Browser Test suite.
+
+* platform/blackberry/CookieManager.cpp:
+(WebCore::CookieManager::getRawCookies):
+
2012-09-04 Philippe Normand pnorm...@igalia.com
[GStreamer] 0.11 build breaks due to rename of gst_message_new_duration
Modified: trunk/Source/WebCore/platform/blackberry/CookieManager.cpp (127469 => 127470)
--- trunk/Source/WebCore/platform/blackberry/CookieManager.cpp 2012-09-04 15:45:38 UTC (rev 127469)
+++ trunk/Source/WebCore/platform/blackberry/CookieManager.cpp 2012-09-04 15:47:25 UTC (rev 127470)
@@ -207,10 +207,22 @@
VectorParsedCookie* cookieCandidates;
VectorCookieMap* protocolsToSearch;
+// Special Case: If a server sets a secure cookie over a non-secure channel and tries to access the cookie
+// over a secure channel, it will not succeed because the secure protocol isn't mapped to the insecure protocol yet.
+// Set the map to the non-secure version, so it'll search the mapping for a secure cookie.
+CookieMap* targetMap = m_managerMap.get(requestURL.protocol());
+if (!targetMap isConnectionSecure) {
+CookieLog(CookieManager - special case: secure protocol are not linked yet.);
+if (requestURL.protocolIs(https))
+targetMap = m_managerMap.get(http);
+else if (requestURL.protocolIs(wss))
+targetMap = m_managerMap.get(ws);
+}
+
if (specialCaseForLocal)
copyValuesToVector(m_managerMap, protocolsToSearch);
else {
-protocolsToSearch.append(m_managerMap.get(requestURL.protocol()));
+protocolsToSearch.append(targetMap);
// FIXME: this is a hack for webworks apps; RFC 6265 says Cookies do not provide isolation by scheme
// so we should not be checking protocols at all. See PR 135595
if (m_shouldDumpAllCookies) {
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [127471] trunk/Source/WebCore
Title: [127471] trunk/Source/WebCore Revision 127471 Author pe...@chromium.org Date 2012-09-04 09:50:47 -0700 (Tue, 04 Sep 2012) Log Message [chromium] OpenTypeVerticalData.cpp in both webcore_remaining and webcore_platform seems to break incremental linking on Windows Chromium https://bugs.webkit.org/show_bug.cgi?id=95744 Patch by Koji Ishii kojii...@gmail.com on 2012-09-04 Unreviewed build fix, verified by Scott Graham. The addition of 'platform/graphics/opentype/*' to webcore_platform in WebCore.gyp was redundant because '/opentype/' was already included to webcore_remaining. It was not only redundant but also breaks incremental linking. No new tests are required because no behavior changes. Patch by Koji Ishii kojii...@gmail.com on 2012-09-04 * WebCore.gyp/WebCore.gyp: Removed platform/graphics/opentype/* from webcore_platform. Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/WebCore.gyp/WebCore.gyp Diff Modified: trunk/Source/WebCore/ChangeLog (127470 => 127471) --- trunk/Source/WebCore/ChangeLog 2012-09-04 15:47:25 UTC (rev 127470) +++ trunk/Source/WebCore/ChangeLog 2012-09-04 16:50:47 UTC (rev 127471) @@ -1,3 +1,19 @@ +2012-09-04 Koji Ishii kojii...@gmail.com + +[chromium] OpenTypeVerticalData.cpp in both webcore_remaining and webcore_platform seems to break incremental linking on Windows Chromium +https://bugs.webkit.org/show_bug.cgi?id=95744 + +Patch by Koji Ishii kojii...@gmail.com on 2012-09-04 +Unreviewed build fix, verified by Scott Graham. + +The addition of 'platform/graphics/opentype/*' to webcore_platform in WebCore.gyp was redundant +because '/opentype/' was already included to webcore_remaining. +It was not only redundant but also breaks incremental linking. + +No new tests are required because no behavior changes. + +* WebCore.gyp/WebCore.gyp: Removed platform/graphics/opentype/* from webcore_platform. + 2012-09-04 Otto Derek Cheung otche...@rim.com [BlackBerry] Browser is not sending secured Cookie back to server over HTTPS connection Modified: trunk/Source/WebCore/WebCore.gyp/WebCore.gyp (127470 => 127471) --- trunk/Source/WebCore/WebCore.gyp/WebCore.gyp 2012-09-04 15:47:25 UTC (rev 127470) +++ trunk/Source/WebCore/WebCore.gyp/WebCore.gyp 2012-09-04 16:50:47 UTC (rev 127471) @@ -1843,10 +1843,6 @@ 'sources/': [ ['exclude', 'Posix\\.cpp$'], -['include', 'platform/graphics/opentype/OpenTypeTypes\\.h$'], -['include', 'platform/graphics/opentype/OpenTypeVerticalData\\.cpp$'], -['include', 'platform/graphics/opentype/OpenTypeVerticalData\\.h$'], - # The Chromium Win currently uses GlyphPageTreeNodeChromiumWin.cpp from # platform/graphics/chromium, included by regex above, instead. ['exclude', 'platform/graphics/skia/FontCacheSkia\\.cpp$'], ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [127472] trunk
Title: [127472] trunk Revision 127472 Author commit-qu...@webkit.org Date 2012-09-04 10:47:49 -0700 (Tue, 04 Sep 2012) Log Message [CSS Regions] Destroying a render named flow thread without unregistering left-over content nodes triggered an assertion. https://bugs.webkit.org/show_bug.cgi?id=95645 Patch by Andrei Bucur abu...@adobe.com on 2012-09-04 Reviewed by Abhishek Arya. Source/WebCore: This patch cleans up the render named flow thread before destruction by unregistering left-over content nodes. Tests: fast/regions/moved-content-node-crash.html * rendering/RenderNamedFlowThread.cpp: (WebCore::RenderNamedFlowThread::~RenderNamedFlowThread): LayoutTests: Simple test case that triggers an ASSERT in debug mode and causes a crash in release. The ASSERT appears in RenderFlowThreadController::unregisterNamedFlowContentNode ASSERT(it != m_mapNamedFlowContentNodes.end()); It happens because when a content node is added to an iframe document and then moved back, the iframe's RenderNamedFlowThread is destroyed without calling unregisterNamedFlowContentNode on the node. This triggers the before mentioned assertion after a lazyAttach and a detach in the parent document. * fast/regions/moved-content-node-crash-expected.txt: Added. * fast/regions/moved-content-node-crash.html: Added. Modified Paths trunk/LayoutTests/ChangeLog trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/rendering/RenderNamedFlowThread.cpp trunk/Source/WebCore/rendering/RenderNamedFlowThread.h Added Paths trunk/LayoutTests/fast/regions/moved-content-node-crash-expected.txt trunk/LayoutTests/fast/regions/moved-content-node-crash.html Diff Modified: trunk/LayoutTests/ChangeLog (127471 => 127472) --- trunk/LayoutTests/ChangeLog 2012-09-04 16:50:47 UTC (rev 127471) +++ trunk/LayoutTests/ChangeLog 2012-09-04 17:47:49 UTC (rev 127472) @@ -1,3 +1,21 @@ +2012-09-04 Andrei Bucur abu...@adobe.com + +[CSS Regions] Destroying a render named flow thread without unregistering left-over content nodes triggered an assertion. +https://bugs.webkit.org/show_bug.cgi?id=95645 + +Reviewed by Abhishek Arya. + +Simple test case that triggers an ASSERT in debug mode and causes a crash in release. +The ASSERT appears in RenderFlowThreadController::unregisterNamedFlowContentNode +ASSERT(it != m_mapNamedFlowContentNodes.end()); + +It happens because when a content node is added to an iframe document and then moved back, the iframe's RenderNamedFlowThread is destroyed +without calling unregisterNamedFlowContentNode on the node. This triggers the before mentioned assertion after a lazyAttach and a detach +in the parent document. + +* fast/regions/moved-content-node-crash-expected.txt: Added. +* fast/regions/moved-content-node-crash.html: Added. + 2012-09-04 Andrei Poenaru poen...@adobe.com Web Inspector: Protocol Extension: Add regionLayoutUpdate event Added: trunk/LayoutTests/fast/regions/moved-content-node-crash-expected.txt (0 => 127472) --- trunk/LayoutTests/fast/regions/moved-content-node-crash-expected.txt (rev 0) +++ trunk/LayoutTests/fast/regions/moved-content-node-crash-expected.txt 2012-09-04 17:47:49 UTC (rev 127472) @@ -0,0 +1,7 @@ +Test for WebKit Bug 95645 Crash + +The test passes if it does not crash or assert. + +PASS + + Added: trunk/LayoutTests/fast/regions/moved-content-node-crash.html (0 => 127472) --- trunk/LayoutTests/fast/regions/moved-content-node-crash.html (rev 0) +++ trunk/LayoutTests/fast/regions/moved-content-node-crash.html 2012-09-04 17:47:49 UTC (rev 127472) @@ -0,0 +1,27 @@ +!doctype html +html +body +pTest for a href="" Bug 95645/a Crash /p +pThe test passes if it does not crash or assert./p +pPASS/p +div id=DIV1 +div id=DIV2 +iframe id=FRAME1 style=-webkit-flow-into: flow;/iframe +iframe id=FRAME2/iframe +script +if (window.testRunner) +window.testRunner.dumpAsText(); + +div1 = document.getElementById(DIV1); +div2 = document.getElementById(DIV2); +frame1 = document.getElementById(FRAME1); +frame2 = document.getElementById(FRAME2); +frame2.contentDocument.body.appendChild(frame1); + +document.body.offsetTop; +div1.replaceChild(frame1, div2); +/script +/div +/div +/body +/html Modified: trunk/Source/WebCore/ChangeLog (127471 => 127472) --- trunk/Source/WebCore/ChangeLog 2012-09-04 16:50:47 UTC (rev 127471) +++ trunk/Source/WebCore/ChangeLog 2012-09-04 17:47:49 UTC (rev 127472) @@ -1,3 +1,17 @@ +2012-09-04 Andrei Bucur abu...@adobe.com + +[CSS Regions] Destroying a render named flow thread without unregistering left-over content nodes triggered an assertion. +https://bugs.webkit.org/show_bug.cgi?id=95645 + +
[webkit-changes] [127473] trunk
Title: [127473] trunk
Revision 127473
Author sch...@chromium.org
Date 2012-09-04 11:08:19 -0700 (Tue, 04 Sep 2012)
Log Message
[Chromium] Allow asyncronous response of pointer lock requests in layout tests.
https://bugs.webkit.org/show_bug.cgi?id=95628
Reviewed by James Robinson.
Tools:
Future tests need the ability to respond asynchronously that
pointer lock requests have been accepted or rejected. This patch
adds the following:
testRunner.setPointerLockWillRespondAsynchronously();
testRunner.didAcquirePointerLock();
testRunner.didNotAcquirePointerLock();
Tested in existing test:
pointerlockchange-pointerlockerror-events.html
* DumpRenderTree/chromium/DRTTestRunner.cpp:
(DRTTestRunner::DRTTestRunner):
(DRTTestRunner::didAcquirePointerLock):
(DRTTestRunner::didNotAcquirePointerLock):
(DRTTestRunner::setPointerLockWillRespondAsynchronously):
* DumpRenderTree/chromium/DRTTestRunner.h:
(DRTTestRunner):
* DumpRenderTree/chromium/WebViewHost.cpp:
(WebViewHost::requestPointerLock):
(WebViewHost::didAcquirePointerLock):
(WebViewHost::didNotAcquirePointerLock):
* DumpRenderTree/chromium/WebViewHost.h:
(WebViewHost):
(WebViewHost::setPointerLockWillRespondAsynchronously):
LayoutTests:
Add testing for testRunner.setPointerLockWillRespondAsynchronously().
* pointer-lock/pointerlockchange-pointerlockerror-events-expected.txt:
* pointer-lock/pointerlockchange-pointerlockerror-events.html:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/pointer-lock/pointerlockchange-pointerlockerror-events-expected.txt
trunk/LayoutTests/pointer-lock/pointerlockchange-pointerlockerror-events.html
trunk/Tools/ChangeLog
trunk/Tools/DumpRenderTree/chromium/DRTTestRunner.cpp
trunk/Tools/DumpRenderTree/chromium/DRTTestRunner.h
trunk/Tools/DumpRenderTree/chromium/WebViewHost.cpp
trunk/Tools/DumpRenderTree/chromium/WebViewHost.h
Diff
Modified: trunk/LayoutTests/ChangeLog (127472 => 127473)
--- trunk/LayoutTests/ChangeLog 2012-09-04 17:47:49 UTC (rev 127472)
+++ trunk/LayoutTests/ChangeLog 2012-09-04 18:08:19 UTC (rev 127473)
@@ -1,3 +1,15 @@
+2012-09-04 Vincent Scheib sch...@chromium.org
+
+[Chromium] Allow asyncronous response of pointer lock requests in layout tests.
+https://bugs.webkit.org/show_bug.cgi?id=95628
+
+Reviewed by James Robinson.
+
+Add testing for testRunner.setPointerLockWillRespondAsynchronously().
+
+* pointer-lock/pointerlockchange-pointerlockerror-events-expected.txt:
+* pointer-lock/pointerlockchange-pointerlockerror-events.html:
+
2012-09-04 Andrei Bucur abu...@adobe.com
[CSS Regions] Destroying a render named flow thread without unregistering left-over content nodes triggered an assertion.
Modified: trunk/LayoutTests/pointer-lock/pointerlockchange-pointerlockerror-events-expected.txt (127472 => 127473)
--- trunk/LayoutTests/pointer-lock/pointerlockchange-pointerlockerror-events-expected.txt 2012-09-04 17:47:49 UTC (rev 127472)
+++ trunk/LayoutTests/pointer-lock/pointerlockchange-pointerlockerror-events-expected.txt 2012-09-04 18:08:19 UTC (rev 127473)
@@ -30,9 +30,13 @@
PASS testRunner.setPointerLockWillFailSynchronously is defined.
Lock with synchronous failure.
PASS onwebkitpointerlockerror received after: Lock with synchronous failure.
-PASS testRunner.setPointerLockWillFailAsynchronously is defined.
+PASS testRunner.setPointerLockWillRespondAsynchronously is defined.
+PASS testRunner.didAcquirePointerLock is defined.
+PASS testRunner.didNotAcquirePointerLock is defined.
Lock with asynchronous failure.
PASS onwebkitpointerlockerror received after: Lock with asynchronous failure.
+ Lock with asynchronous success.
+PASS onwebkitpointerlockchange received after: Lock with asynchronous success.
PASS successfullyParsed is true
TEST COMPLETE
Modified: trunk/LayoutTests/pointer-lock/pointerlockchange-pointerlockerror-events.html (127472 => 127473)
--- trunk/LayoutTests/pointer-lock/pointerlockchange-pointerlockerror-events.html 2012-09-04 17:47:49 UTC (rev 127472)
+++ trunk/LayoutTests/pointer-lock/pointerlockchange-pointerlockerror-events.html 2012-09-04 18:08:19 UTC (rev 127473)
@@ -82,11 +82,26 @@
targetDiv1.webkitRequestPointerLock();
},
function () {
-shouldBeDefined(testRunner.setPointerLockWillFailAsynchronously);
-testRunner.setPointerLockWillFailAsynchronously();
+shouldBeDefined(testRunner.setPointerLockWillRespondAsynchronously);
+shouldBeDefined(testRunner.didAcquirePointerLock);
+shouldBeDefined(testRunner.didNotAcquirePointerLock);
+testRunner.setPointerLockWillRespondAsynchronously();
expectOnlyErrorEvent(Lock with asynchronous failure.);
targetDiv1.webkitRequestPointerLock();
+doNextStep();
},
+function () {
+testRunner.didNotAcquirePointerLock();
+},
+function () {
+
[webkit-changes] [127474] trunk
Title: [127474] trunk
Revision 127474
Author timothy_hor...@apple.com
Date 2012-09-04 11:31:31 -0700 (Tue, 04 Sep 2012)
Log Message
ASSERTion failure when SVG element is removed from document and readded
https://bugs.webkit.org/show_bug.cgi?id=95517
rdar://problem/12175583
Reviewed by Brady Eidson.
Previously, SVG animations would cease to animate when their parent
svg element was removed and re-added to the document.
Instead, to match Firefox and Opera, we should continue the animation
with the same beginTime (i.e. the animation continues as if it had never
been removed from the document).
Test: svg/animations/reinserting-svg-into-document.html
* svg/SVGSVGElement.cpp:
(WebCore::SVGSVGElement::insertedInto): Don't call begin() on an already-started SMILTimeContainer().
* svg/animation/SMILTimeContainer.cpp:
(WebCore::SMILTimeContainer::isStarted): Added.
* svg/animation/SMILTimeContainer.h: Add isStarted().
* svg/animation/SVGSMILElement.cpp:
(WebCore::SVGSMILElement::insertedInto): Always reschedule SVGSMILElements with
their parent SMILTimeContainer when they are inserted into the document, otherwise
they are lost (and never again update) when their subtree is removed and then
readded to the document.
Add a test that ensures that removing an SVG element from the document
and readding it continues SMIL animations.
* svg/animations/reinserting-svg-into-document.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/scrolling/mac/ScrollingTreeNodeMac.mm
trunk/Source/WebCore/svg/SVGSVGElement.cpp
trunk/Source/WebCore/svg/animation/SMILTimeContainer.cpp
trunk/Source/WebCore/svg/animation/SMILTimeContainer.h
trunk/Source/WebCore/svg/animation/SVGSMILElement.cpp
Added Paths
trunk/LayoutTests/svg/animations/reinserting-svg-into-document-expected.txt
trunk/LayoutTests/svg/animations/reinserting-svg-into-document.html
Diff
Modified: trunk/LayoutTests/ChangeLog (127473 => 127474)
--- trunk/LayoutTests/ChangeLog 2012-09-04 18:08:19 UTC (rev 127473)
+++ trunk/LayoutTests/ChangeLog 2012-09-04 18:31:31 UTC (rev 127474)
@@ -1,3 +1,16 @@
+2012-09-04 Tim Horton timothy_hor...@apple.com
+
+ASSERTion failure when SVG element is removed from document and readded
+https://bugs.webkit.org/show_bug.cgi?id=95517
+rdar://problem/12175583
+
+Reviewed by Brady Eidson.
+
+Add a test that ensures that removing an SVG element from the document
+and readding it continues SMIL animations.
+
+* svg/animations/reinserting-svg-into-document.html: Added.
+
2012-09-04 Vincent Scheib sch...@chromium.org
[Chromium] Allow asyncronous response of pointer lock requests in layout tests.
Added: trunk/LayoutTests/svg/animations/reinserting-svg-into-document-expected.txt (0 => 127474)
--- trunk/LayoutTests/svg/animations/reinserting-svg-into-document-expected.txt (rev 0)
+++ trunk/LayoutTests/svg/animations/reinserting-svg-into-document-expected.txt 2012-09-04 18:31:31 UTC (rev 127474)
@@ -0,0 +1,5 @@
+Reinserting SVG animation into document should continue the animation
+
+PASS rect.x.animVal.value is 30
+PASS rect.x.animVal.value is 60
+
Added: trunk/LayoutTests/svg/animations/reinserting-svg-into-document.html (0 => 127474)
--- trunk/LayoutTests/svg/animations/reinserting-svg-into-document.html (rev 0)
+++ trunk/LayoutTests/svg/animations/reinserting-svg-into-document.html 2012-09-04 18:31:31 UTC (rev 127474)
@@ -0,0 +1,43 @@
+html
+script src=""
+script src=""
+script
+function load() {
+if (window.testRunner) {
+testRunner.dumpAsText();
+testRunner.waitUntilDone();
+}
+
+svg = document.getElementById(svg);
+rect = document.getElementById(rect);
+
+setTimeout(function () {
+svg.setCurrentTime(1);
+
+document.body.removeChild(svg);
+document.body.appendChild(svg);
+
+setTimeout(function () {
+shouldBeCloseEnough(rect.x.animVal.value, 30, 1);
+
+svg.setCurrentTime(2);
+
+shouldBeCloseEnough(rect.x.animVal.value, 60, 1);
+
+if (window.testRunner)
+testRunner.notifyDone();
+}, 0);
+}, 0);
+};
+/script
+body _onload_=load()
+h1Reinserting SVG animation into document should continue the animation/h1
+p id=description/p
+div id=console/div
+svg id=svg xmlns=http://www.w3.org/2000/svg
+rect id=rect x=0 y=0 width=20 height=20
+animate attributeName=x begin=0 from=0 to=90 dur=3s fill=freeze /
+/rect
+/svg
+/body
+/html
Modified: trunk/Source/WebCore/ChangeLog (127473 => 127474)
--- trunk/Source/WebCore/ChangeLog 2012-09-04 18:08:19 UTC (rev 127473)
+++ trunk/Source/WebCore/ChangeLog 2012-09-04 18:31:31 UTC (rev 127474)
@@ -1,3 +1,31 @@
+2012-09-04 Tim Horton timothy_hor...@apple.com
+
+ASSERTion failure when SVG element is removed from document
[webkit-changes] [127475] trunk/Tools
Title: [127475] trunk/Tools
Revision 127475
Author commit-qu...@webkit.org
Date 2012-09-04 11:33:10 -0700 (Tue, 04 Sep 2012)
Log Message
[GTK] Print API missing documentation when generating gtkdoc
https://bugs.webkit.org/show_bug.cgi?id=95703
Patch by Martin Robinson mrobin...@igalia.com on 2012-09-04
Reviewed by Carlos Garcia Campos.
Print out API missing documentation when generating gtkdoc. This makes it
easier to fix documentation errors.
* gtk/generate-gtkdoc:
(print_missing_api): Added.
(generate_doc): Inline the rebase step, since it now reports an error
when you try to rebase without generating documentation first.
* gtk/gtkdoc.py:
(GTKDoc.rebase_installed_docs): Raise an error when rebasing without
generating documentation first to enable a small cleanup at the caller.
(GTKDoc.api_missing_documentation): Added.
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/gtk/generate-gtkdoc
trunk/Tools/gtk/gtkdoc.py
Diff
Modified: trunk/Tools/ChangeLog (127474 => 127475)
--- trunk/Tools/ChangeLog 2012-09-04 18:31:31 UTC (rev 127474)
+++ trunk/Tools/ChangeLog 2012-09-04 18:33:10 UTC (rev 127475)
@@ -1,3 +1,22 @@
+2012-09-04 Martin Robinson mrobin...@igalia.com
+
+[GTK] Print API missing documentation when generating gtkdoc
+https://bugs.webkit.org/show_bug.cgi?id=95703
+
+Reviewed by Carlos Garcia Campos.
+
+Print out API missing documentation when generating gtkdoc. This makes it
+easier to fix documentation errors.
+
+* gtk/generate-gtkdoc:
+(print_missing_api): Added.
+(generate_doc): Inline the rebase step, since it now reports an error
+when you try to rebase without generating documentation first.
+* gtk/gtkdoc.py:
+(GTKDoc.rebase_installed_docs): Raise an error when rebasing without
+generating documentation first to enable a small cleanup at the caller.
+(GTKDoc.api_missing_documentation): Added.
+
2012-09-04 Vincent Scheib sch...@chromium.org
[Chromium] Allow asyncronous response of pointer lock requests in layout tests.
Modified: trunk/Tools/gtk/generate-gtkdoc (127474 => 127475)
--- trunk/Tools/gtk/generate-gtkdoc 2012-09-04 18:31:31 UTC (rev 127474)
+++ trunk/Tools/gtk/generate-gtkdoc 2012-09-04 18:33:10 UTC (rev 127475)
@@ -137,18 +137,20 @@
})
return options
-def generate_doc(pkg_config_path, options):
-generator = gtkdoc.PkgConfigGTKDoc(pkg_config_path, options)
+def print_missing_api(generator):
+missing_api = generator.api_missing_documentation()
+if not missing_api:
+return
+print \nThe following API are missing documentation:
+for api in missing_api:
+print \t%s % api
+
+def generate_doc(generator):
generator.generate(html='--skip-html' not in sys.argv)
+if generator.saw_warnings:
+print_missing_api(generator)
return generator.saw_warnings
-def rebase_installed_docs(pkg_config_path, options):
-if not os.path.isdir(options['output_dir']):
-print Documentation was not generated
-return
-generator = gtkdoc.PkgConfigGTKDoc(pkg_config_path, options)
-generator.rebase_installed_docs()
-
configure_logging()
# We need to add the _javascript_Core build directory to the PKG_CONFIG_PATH
@@ -165,22 +167,23 @@
pkg_config_path = common.build_path('Source', 'WebKit', 'gtk', 'webkit-1.0.pc')
if os.path.exists(pkg_config_path):
options = get_webkit1_options(common.gtk_version_of_pkg_config_file(pkg_config_path))
+generator = gtkdoc.PkgConfigGTKDoc(pkg_config_path, options)
if '--rebase' not in sys.argv:
print Generating WebKit1 documentation...
-saw_webkit1_warnings = generate_doc(pkg_config_path, options)
+saw_webkit1_warnings = generate_doc(generator)
else:
print Rebasing WebKit1 documentation...
-rebase_installed_docs(pkg_config_path, options)
+generator.rebase_installed_docs()
# WebKit2 might not be enabled, so check for the pkg-config file before building documentation.
pkg_config_path = common.build_path('Source', 'WebKit2', 'webkit2gtk-3.0.pc')
if os.path.exists(pkg_config_path):
-options = get_webkit2_options()
+generator = gtkdoc.PkgConfigGTKDoc(pkg_config_path, get_webkit2_options())
if '--rebase' not in sys.argv:
print \nGenerating WebKit2 documentation...
-saw_webkit2_warnings = generate_doc(pkg_config_path, options)
+saw_webkit2_warnings = generate_doc(generator)
else:
print \nRebasing WebKit2 documentation...
-rebase_installed_docs(pkg_config_path, options)
+generator.rebase_installed_docs()
sys.exit(saw_webkit1_warnings or saw_webkit2_warnings)
Modified: trunk/Tools/gtk/gtkdoc.py (127474 => 127475)
--- trunk/Tools/gtk/gtkdoc.py 2012-09-04 18:31:31 UTC (rev 127474)
+++ trunk/Tools/gtk/gtkdoc.py 2012-09-04 18:33:10 UTC (rev 127475)
@@ -361,6 +361,8 @@
self._run_command(args,
[webkit-changes] [127476] trunk/Source/WebCore
Title: [127476] trunk/Source/WebCore
Revision 127476
Author commit-qu...@webkit.org
Date 2012-09-04 11:37:26 -0700 (Tue, 04 Sep 2012)
Log Message
[chromium] Do not allow infinite pending frames in CCFrameRateController
https://bugs.webkit.org/show_bug.cgi?id=94254
Patch by Brian Anderson briander...@chromium.org on 2012-09-04
Reviewed by James Robinson.
Removes support for infinite pending frames in CCFrameRateController
if swap acks are available.
Functionality covered by existing tests.
* platform/graphics/chromium/cc/CCFrameRateController.cpp:
(WebCore::CCFrameRateController::CCFrameRateController):
(WebCore::CCFrameRateController::setMaxFramesPending):
(WebCore::CCFrameRateController::setSwapBuffersCompleteSupported):
(WebCore):
(WebCore::CCFrameRateController::onTimerTick):
(WebCore::CCFrameRateController::didBeginFrame):
(WebCore::CCFrameRateController::didFinishFrame):
* platform/graphics/chromium/cc/CCFrameRateController.h:
(CCFrameRateController):
* platform/graphics/chromium/cc/CCScheduler.cpp:
(WebCore::CCScheduler::setSwapBuffersCompleteSupported):
(WebCore):
* platform/graphics/chromium/cc/CCScheduler.h:
(CCScheduler):
* platform/graphics/chromium/cc/CCThreadProxy.cpp:
(WebCore::CCThreadProxy::initializeRendererOnImplThread):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/chromium/cc/CCFrameRateController.cpp
trunk/Source/WebCore/platform/graphics/chromium/cc/CCFrameRateController.h
trunk/Source/WebCore/platform/graphics/chromium/cc/CCScheduler.cpp
trunk/Source/WebCore/platform/graphics/chromium/cc/CCScheduler.h
trunk/Source/WebCore/platform/graphics/chromium/cc/CCThreadProxy.cpp
Property Changed
trunk/Source/WebCore/platform/graphics/chromium/cc/CCFrameRateController.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (127475 => 127476)
--- trunk/Source/WebCore/ChangeLog 2012-09-04 18:33:10 UTC (rev 127475)
+++ trunk/Source/WebCore/ChangeLog 2012-09-04 18:37:26 UTC (rev 127476)
@@ -1,3 +1,33 @@
+2012-09-04 Brian Anderson briander...@chromium.org
+
+[chromium] Do not allow infinite pending frames in CCFrameRateController
+https://bugs.webkit.org/show_bug.cgi?id=94254
+
+Reviewed by James Robinson.
+
+Removes support for infinite pending frames in CCFrameRateController
+if swap acks are available.
+
+Functionality covered by existing tests.
+
+* platform/graphics/chromium/cc/CCFrameRateController.cpp:
+(WebCore::CCFrameRateController::CCFrameRateController):
+(WebCore::CCFrameRateController::setMaxFramesPending):
+(WebCore::CCFrameRateController::setSwapBuffersCompleteSupported):
+(WebCore):
+(WebCore::CCFrameRateController::onTimerTick):
+(WebCore::CCFrameRateController::didBeginFrame):
+(WebCore::CCFrameRateController::didFinishFrame):
+* platform/graphics/chromium/cc/CCFrameRateController.h:
+(CCFrameRateController):
+* platform/graphics/chromium/cc/CCScheduler.cpp:
+(WebCore::CCScheduler::setSwapBuffersCompleteSupported):
+(WebCore):
+* platform/graphics/chromium/cc/CCScheduler.h:
+(CCScheduler):
+* platform/graphics/chromium/cc/CCThreadProxy.cpp:
+(WebCore::CCThreadProxy::initializeRendererOnImplThread):
+
2012-09-04 Tim Horton timothy_hor...@apple.com
ASSERTion failure when SVG element is removed from document and readded
Modified: trunk/Source/WebCore/platform/graphics/chromium/cc/CCFrameRateController.cpp (127475 => 127476)
--- trunk/Source/WebCore/platform/graphics/chromium/cc/CCFrameRateController.cpp 2012-09-04 18:33:10 UTC (rev 127475)
+++ trunk/Source/WebCore/platform/graphics/chromium/cc/CCFrameRateController.cpp 2012-09-04 18:37:26 UTC (rev 127476)
@@ -31,6 +31,14 @@
#include TraceEvent.h
#include wtf/CurrentTime.h
+namespace {
+
+// This will be the maximum number of pending frames unless
+// CCFrameRateController::setMaxFramesPending is called.
+const int defaultMaxFramesPending = 2;
+
+}
+
namespace WebCore {
class CCFrameRateControllerTimeSourceAdapter : public CCTimeSourceClient {
@@ -52,9 +60,10 @@
CCFrameRateController::CCFrameRateController(PassRefPtrCCTimeSource timer)
: m_client(0)
, m_numFramesPending(0)
-, m_maxFramesPending(0)
+, m_maxFramesPending(defaultMaxFramesPending)
, m_timeSource(timer)
, m_active(false)
+, m_swapBuffersCompleteSupported(true)
, m_isTimeSourceThrottling(true)
{
m_timeSourceClientAdapter = CCFrameRateControllerTimeSourceAdapter::create(this);
@@ -64,8 +73,9 @@
CCFrameRateController::CCFrameRateController(CCThread* thread)
: m_client(0)
, m_numFramesPending(0)
-, m_maxFramesPending(0)
+, m_maxFramesPending(defaultMaxFramesPending)
, m_active(false)
+, m_swapBuffersCompleteSupported(true)
, m_isTimeSourceThrottling(false)
{
m_manualTicker = adoptPtr(new CCTimer(thread, this));
@@ -96,6
[webkit-changes] [127477] branches/safari-536.26-branch/Source/WebKit2
Title: [127477] branches/safari-536.26-branch/Source/WebKit2
Revision 127477
Author lforsch...@apple.com
Date 2012-09-04 11:42:03 -0700 (Tue, 04 Sep 2012)
Log Message
Rollout r127322.
Modified Paths
branches/safari-536.26-branch/Source/WebKit2/ChangeLog
branches/safari-536.26-branch/Source/WebKit2/WebProcess/Plugins/PluginView.cpp
Diff
Modified: branches/safari-536.26-branch/Source/WebKit2/ChangeLog (127476 => 127477)
--- branches/safari-536.26-branch/Source/WebKit2/ChangeLog 2012-09-04 18:37:26 UTC (rev 127476)
+++ branches/safari-536.26-branch/Source/WebKit2/ChangeLog 2012-09-04 18:42:03 UTC (rev 127477)
@@ -1,3 +1,27 @@
+2012-08-14 Lucas Forschler lforsch...@apple.com
+
+Rollout 127322.
+
+2012-08-31 Timothy Hatcher timo...@apple.com
+
+Merge r127272.
+
+2012-08-31 Brady Eidson beid...@apple.com
+
+REGRESSION (127047): Crash in PluginProxy::windowVisibilityChanged when changing tabs
+rdar://problem/12211180 and https://bugs.webkit.org/show_bug.cgi?id=95515
+
+Reviewed by Dan Bernstein.
+
+Plug-ins created in background tabs don't get initialized until they first become visible,
+so telling them they are now invisible leads to messaging on behalf of an uninitialized plug-in.
+
+Many other methods related to visibility and focus only call through if the plug-in is initialized,
+so setWindowIsVisible should do the same.
+
+* WebProcess/Plugins/PluginView.cpp:
+(WebKit::PluginView::setWindowIsVisible): Only tell initialized plug-ins of window visibility changes.
+
2012-08-31 Timothy Hatcher timo...@apple.com
Merge r127319.
Modified: branches/safari-536.26-branch/Source/WebKit2/WebProcess/Plugins/PluginView.cpp (127476 => 127477)
--- branches/safari-536.26-branch/Source/WebKit2/WebProcess/Plugins/PluginView.cpp 2012-09-04 18:37:26 UTC (rev 127476)
+++ branches/safari-536.26-branch/Source/WebKit2/WebProcess/Plugins/PluginView.cpp 2012-09-04 18:42:03 UTC (rev 127477)
@@ -756,19 +756,13 @@
transform.translate(scaledLocationInRootViewCoordinates.x(), scaledLocationInRootViewCoordinates.y());
transform.scale(pageScaleFactor);
-// FIXME: The way we calculate this clip rect isn't correct.
-// But it is still important to distinguish between empty and non-empty rects so we can notify the plug-in when it becomes invisible.
+// FIXME: This clip rect isn't correct.
+// But it is still important distinguish between empty and non-empty rects so we can notify the plug-in when it becomes invisible.
// Making the rect actually correct is covered by https://bugs.webkit.org/show_bug.cgi?id=95362
-IntRect clipRect = boundsRect();
-
-// FIXME: We can only get a semi-reliable answer from clipRectInWindowCoordinates() when the page is not scaled.
-// Fixing that is tracked in rdar://problem/9026611 - Make the Widget hierarchy play nicely with transforms, for zoomed plug-ins and iframes
-if (pageScaleFactor == 1) {
-clipRect = clipRectInWindowCoordinates();
-if (!clipRect.isEmpty())
-clipRect = boundsRect();
-}
-
+IntRect clipRect = clipRectInWindowCoordinates();
+if (!clipRect.isEmpty())
+clipRect = boundsRect();
+
m_plugin-geometryDidChange(size(), clipRect, transform);
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [127478] trunk/Tools
Title: [127478] trunk/Tools
Revision 127478
Author t...@chromium.org
Date 2012-09-04 11:45:35 -0700 (Tue, 04 Sep 2012)
Log Message
Elide test names when running new-run-webkit-tests
https://bugs.webkit.org/show_bug.cgi?id=95626
Reviewed by Dirk Pranke.
When the test name exceeds the number of terminal columns, it leaves
text on the screen. Avoid this by eliding the test name when running
tests. This is similar to what ninja does when compiling.
* Scripts/webkitpy/layout_tests/views/metered_stream.py:
(MeteredStream):
(MeteredStream.number_of_columns): Helper method to get number of
terminal columns. Won't work on Win32 python, but meh.
* Scripts/webkitpy/layout_tests/views/printing.py:
(Printer._test_status_line): New method for eliding the text. Doesn't use \u2026
because stderr appears to be ascii only.
(Printer.print_started_test): Route through _test_status_line.
(Printer.print_finished_test): Route through _test_status_line.
(Printer._print_test_trace): Route through _test_status_line.
(Printer._print_baseline): Route through _test_status_line.
* Scripts/webkitpy/layout_tests/views/printing_unittest.py:
(test_test_status_line): Test for _test_status_line.
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/layout_tests/views/metered_stream.py
trunk/Tools/Scripts/webkitpy/layout_tests/views/printing.py
trunk/Tools/Scripts/webkitpy/layout_tests/views/printing_unittest.py
Diff
Modified: trunk/Tools/ChangeLog (127477 => 127478)
--- trunk/Tools/ChangeLog 2012-09-04 18:42:03 UTC (rev 127477)
+++ trunk/Tools/ChangeLog 2012-09-04 18:45:35 UTC (rev 127478)
@@ -1,3 +1,28 @@
+2012-09-04 Tony Chang t...@chromium.org
+
+Elide test names when running new-run-webkit-tests
+https://bugs.webkit.org/show_bug.cgi?id=95626
+
+Reviewed by Dirk Pranke.
+
+When the test name exceeds the number of terminal columns, it leaves
+text on the screen. Avoid this by eliding the test name when running
+tests. This is similar to what ninja does when compiling.
+
+* Scripts/webkitpy/layout_tests/views/metered_stream.py:
+(MeteredStream):
+(MeteredStream.number_of_columns): Helper method to get number of
+terminal columns. Won't work on Win32 python, but meh.
+* Scripts/webkitpy/layout_tests/views/printing.py:
+(Printer._test_status_line): New method for eliding the text. Doesn't use \u2026
+because stderr appears to be ascii only.
+(Printer.print_started_test): Route through _test_status_line.
+(Printer.print_finished_test): Route through _test_status_line.
+(Printer._print_test_trace): Route through _test_status_line.
+(Printer._print_baseline): Route through _test_status_line.
+* Scripts/webkitpy/layout_tests/views/printing_unittest.py:
+(test_test_status_line): Test for _test_status_line.
+
2012-09-04 Martin Robinson mrobin...@igalia.com
[GTK] Print API missing documentation when generating gtkdoc
Modified: trunk/Tools/Scripts/webkitpy/layout_tests/views/metered_stream.py (127477 => 127478)
--- trunk/Tools/Scripts/webkitpy/layout_tests/views/metered_stream.py 2012-09-04 18:42:03 UTC (rev 127477)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/views/metered_stream.py 2012-09-04 18:45:35 UTC (rev 127478)
@@ -32,7 +32,9 @@
import sys
import time
+from webkitpy.common.memoized import memoized
+
LOG_HANDLER_NAME = 'MeteredStreamLogHandler'
@@ -120,6 +122,21 @@
self._last_partial_line = ''
self._stream.flush()
+@memoized
+def number_of_columns(self):
+if not self._isatty:
+return sys.maxint
+try:
+import fcntl
+import struct
+import termios
+packed = fcntl.ioctl(self._stream.fileno(), termios.TIOCGWINSZ, '\0' * 8)
+_, columns, _, _ = struct.unpack('', packed)
+return columns
+except:
+return sys.maxint
+
+
class _LogHandler(logging.Handler):
def __init__(self, meter):
logging.Handler.__init__(self)
Modified: trunk/Tools/Scripts/webkitpy/layout_tests/views/printing.py (127477 => 127478)
--- trunk/Tools/Scripts/webkitpy/layout_tests/views/printing.py 2012-09-04 18:42:03 UTC (rev 127477)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/views/printing.py 2012-09-04 18:45:35 UTC (rev 127478)
@@ -324,6 +324,22 @@
self._print_quiet(summary)
self._print_quiet()
+def _test_status_line(self, test_name, suffix):
+format_string = '[%d/%d] %s%s'
+status_line = format_string % (self.num_completed, self.num_tests, test_name, suffix)
+if len(status_line) self._meter.number_of_columns():
+overflow_columns = len(status_line) - self._meter.number_of_columns()
+ellipsis = '...'
+if len(test_name) overflow_columns + len(ellipsis) + 2:
+# We don't have enough space even if we
[webkit-changes] [127479] trunk/Source/JavaScriptCore
Title: [127479] trunk/Source/_javascript_Core
Revision 127479
Author mhahnenb...@apple.com
Date 2012-09-04 11:46:21 -0700 (Tue, 04 Sep 2012)
Log Message
Remove uses of ClassInfo from SpeculativeJIT::compileObjectOrOtherLogicalNot
https://bugs.webkit.org/show_bug.cgi?id=95510
Reviewed by Oliver Hunt.
More refactoring to get rid of ClassInfo checks in the DFG.
* dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::execute):
* dfg/DFGSpeculativeJIT.h:
(SpeculativeJIT):
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compileNonStringCellOrOtherLogicalNot):
(JSC::DFG::SpeculativeJIT::compileLogicalNot):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compileNonStringCellOrOtherLogicalNot):
(JSC::DFG::SpeculativeJIT::compileLogicalNot):
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/dfg/DFGAbstractState.cpp
trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.h
trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT32_64.cpp
trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT64.cpp
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (127478 => 127479)
--- trunk/Source/_javascript_Core/ChangeLog 2012-09-04 18:45:35 UTC (rev 127478)
+++ trunk/Source/_javascript_Core/ChangeLog 2012-09-04 18:46:21 UTC (rev 127479)
@@ -1,3 +1,23 @@
+2012-09-04 Mark Hahnenberg mhahnenb...@apple.com
+
+Remove uses of ClassInfo from SpeculativeJIT::compileObjectOrOtherLogicalNot
+https://bugs.webkit.org/show_bug.cgi?id=95510
+
+Reviewed by Oliver Hunt.
+
+More refactoring to get rid of ClassInfo checks in the DFG.
+
+* dfg/DFGAbstractState.cpp:
+(JSC::DFG::AbstractState::execute):
+* dfg/DFGSpeculativeJIT.h:
+(SpeculativeJIT):
+* dfg/DFGSpeculativeJIT32_64.cpp:
+(JSC::DFG::SpeculativeJIT::compileNonStringCellOrOtherLogicalNot):
+(JSC::DFG::SpeculativeJIT::compileLogicalNot):
+* dfg/DFGSpeculativeJIT64.cpp:
+(JSC::DFG::SpeculativeJIT::compileNonStringCellOrOtherLogicalNot):
+(JSC::DFG::SpeculativeJIT::compileLogicalNot):
+
2012-09-03 Patrick Gansterer par...@webkit.org
Unreviewed. Build fix for ENABLE(CLASSIC_INTERPRETER) after r127393.
Modified: trunk/Source/_javascript_Core/dfg/DFGAbstractState.cpp (127478 => 127479)
--- trunk/Source/_javascript_Core/dfg/DFGAbstractState.cpp 2012-09-04 18:45:35 UTC (rev 127478)
+++ trunk/Source/_javascript_Core/dfg/DFGAbstractState.cpp 2012-09-04 18:46:21 UTC (rev 127479)
@@ -608,14 +608,9 @@
Node child = m_graph[node.child1()];
if (isBooleanSpeculation(child.prediction()))
speculateBooleanUnary(node);
-else if (child.shouldSpeculateFinalObjectOrOther()) {
-node.setCanExit(
-!isFinalObjectOrOtherSpeculation(forNode(node.child1()).m_type));
-forNode(node.child1()).filter(SpecFinalObject | SpecOther);
-} else if (child.shouldSpeculateArrayOrOther()) {
-node.setCanExit(
-!isArrayOrOtherSpeculation(forNode(node.child1()).m_type));
-forNode(node.child1()).filter(SpecArray | SpecOther);
+else if (child.shouldSpeculateNonStringCellOrOther()) {
+node.setCanExit(true);
+forNode(node.child1()).filter((SpecCell ~SpecString) | SpecOther);
} else if (child.shouldSpeculateInteger())
speculateInt32Unary(node);
else if (child.shouldSpeculateNumber())
Modified: trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.h (127478 => 127479)
--- trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.h 2012-09-04 18:45:35 UTC (rev 127478)
+++ trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.h 2012-09-04 18:46:21 UTC (rev 127479)
@@ -2059,7 +2059,7 @@
void compileObjectEquality(Node);
void compileObjectToObjectOrOtherEquality(Edge leftChild, Edge rightChild);
void compileValueAdd(Node);
-void compileObjectOrOtherLogicalNot(Edge value, const ClassInfo*, bool needSpeculationCheck);
+void compileNonStringCellOrOtherLogicalNot(Edge value, bool needSpeculationCheck);
void compileLogicalNot(Node);
void emitNonStringCellOrOtherBranch(Edge value, BlockIndex taken, BlockIndex notTaken, bool needSpeculationCheck);
void emitBranch(Node);
Modified: trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT32_64.cpp (127478 => 127479)
--- trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT32_64.cpp 2012-09-04 18:45:35 UTC (rev 127478)
+++ trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT32_64.cpp 2012-09-04 18:46:21 UTC (rev 127479)
@@ -1791,7 +1791,7 @@
jsValueResult(resultTag.gpr(), resultPayload.gpr(), m_compileIndex);
}
-void SpeculativeJIT::compileObjectOrOtherLogicalNot(Edge nodeUse, const ClassInfo* classInfo, bool needSpeculationCheck)
+void SpeculativeJIT::compileNonStringCellOrOtherLogicalNot(Edge nodeUse, bool needSpeculationCheck)
{
JSValueOperand value(this, nodeUse);
[webkit-changes] [127480] trunk/Source/WebCore
Title: [127480] trunk/Source/WebCore Revision 127480 Author commit-qu...@webkit.org Date 2012-09-04 11:54:00 -0700 (Tue, 04 Sep 2012) Log Message Register scrolling layers with ScrollingCoordinator https://bugs.webkit.org/show_bug.cgi?id=78862 Patch by Sami Kyostila skyos...@google.com on 2012-09-04 Reviewed by James Robinson. In order to allow scrollable child layers to be scrolled off the main thread, register them with the ScrollingCoordinator. These layers are also removed from the non-fast scrollable region. Whenever the scroll offset or other scroll geometry related attribute of a compositor scrolled layer changes, the ScrollingCoordinator is informed to allow it to update its internal representation of the scrollable layer. No tests because the ScrollingCoordinator is currently not testable. * page/scrolling/ScrollingCoordinator.cpp: (WebCore::computeNonFastScrollableRegion): Composited scrolling layers can be scrolled off the main thread. (WebCore): (WebCore::ScrollingCoordinator::scrollableAreaScrollLayerDidChange): Callback to ScrollingCoordinator about changes the composited scrolling layers. * page/scrolling/ScrollingCoordinator.h: (WebCore): (ScrollingCoordinator): * page/scrolling/ScrollingCoordinatorNone.cpp: (WebCore): (WebCore::ScrollingCoordinator::scrollableAreaScrollLayerDidChange): * platform/ScrollableArea.h: (WebCore::ScrollableArea::usesCompositedScrolling): * rendering/RenderLayer.cpp: (WebCore): (WebCore::RenderLayer::usesCompositedScrolling): * rendering/RenderLayer.h: (RenderLayer): (WebCore::RenderLayer::usesCompositedScrolling): * rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::updateGraphicsLayerGeometry): (WebCore::RenderLayerBacking::updateScrollingLayers): * rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::scrollingLayerDidChange): (WebCore): * rendering/RenderLayerCompositor.h: (RenderLayerCompositor): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/page/scrolling/ScrollingCoordinator.cpp trunk/Source/WebCore/page/scrolling/ScrollingCoordinator.h trunk/Source/WebCore/page/scrolling/ScrollingCoordinatorNone.cpp trunk/Source/WebCore/page/scrolling/chromium/ScrollingCoordinatorChromium.cpp trunk/Source/WebCore/platform/ScrollableArea.h trunk/Source/WebCore/rendering/RenderLayer.cpp trunk/Source/WebCore/rendering/RenderLayer.h trunk/Source/WebCore/rendering/RenderLayerBacking.cpp trunk/Source/WebCore/rendering/RenderLayerCompositor.cpp trunk/Source/WebCore/rendering/RenderLayerCompositor.h Diff Modified: trunk/Source/WebCore/ChangeLog (127479 => 127480) --- trunk/Source/WebCore/ChangeLog 2012-09-04 18:46:21 UTC (rev 127479) +++ trunk/Source/WebCore/ChangeLog 2012-09-04 18:54:00 UTC (rev 127480) @@ -1,3 +1,50 @@ +2012-09-04 Sami Kyostila skyos...@google.com + +Register scrolling layers with ScrollingCoordinator +https://bugs.webkit.org/show_bug.cgi?id=78862 + +Reviewed by James Robinson. + +In order to allow scrollable child layers to be scrolled off the main +thread, register them with the ScrollingCoordinator. These layers are +also removed from the non-fast scrollable region. + +Whenever the scroll offset or other scroll geometry related attribute of +a compositor scrolled layer changes, the ScrollingCoordinator is +informed to allow it to update its internal representation of the +scrollable layer. + +No tests because the ScrollingCoordinator is currently not testable. + +* page/scrolling/ScrollingCoordinator.cpp: +(WebCore::computeNonFastScrollableRegion): Composited scrolling layers +can be scrolled off the main thread. +(WebCore): +(WebCore::ScrollingCoordinator::scrollableAreaScrollLayerDidChange): +Callback to ScrollingCoordinator about changes the composited scrolling layers. +* page/scrolling/ScrollingCoordinator.h: +(WebCore): +(ScrollingCoordinator): +* page/scrolling/ScrollingCoordinatorNone.cpp: +(WebCore): +(WebCore::ScrollingCoordinator::scrollableAreaScrollLayerDidChange): +* platform/ScrollableArea.h: +(WebCore::ScrollableArea::usesCompositedScrolling): +* rendering/RenderLayer.cpp: +(WebCore): +(WebCore::RenderLayer::usesCompositedScrolling): +* rendering/RenderLayer.h: +(RenderLayer): +(WebCore::RenderLayer::usesCompositedScrolling): +* rendering/RenderLayerBacking.cpp: +(WebCore::RenderLayerBacking::updateGraphicsLayerGeometry): +(WebCore::RenderLayerBacking::updateScrollingLayers): +* rendering/RenderLayerCompositor.cpp: +(WebCore::RenderLayerCompositor::scrollingLayerDidChange): +(WebCore): +* rendering/RenderLayerCompositor.h: +(RenderLayerCompositor): + 2012-09-04 Brian Anderson briander...@chromium.org [chromium] Do not allow infinite pending frames
[webkit-changes] [127481] trunk
Title: [127481] trunk Revision 127481 Author commit-qu...@webkit.org Date 2012-09-04 11:58:19 -0700 (Tue, 04 Sep 2012) Log Message Automatic features should work in sandboxed iframes if allow-scripts flag is set https://bugs.webkit.org/show_bug.cgi?id=93961 Patch by Christophe Dumez christophe.du...@intel.com on 2012-09-04 Reviewed by Adam Barth. Source/WebCore: Allow automatic features (video autoplay and form control autofocus) in a sandboxed iframe that has allow-scripts flag set. This behavior is according to the latest specification at: http://dev.w3.org/html5/spec/browsers.html#attr-iframe-sandbox-allow-same-origin This sandboxed automatic features browsing context flag is relaxed by the same keyword as scripts, because when scripts are enabled these features are trivially possible anyway, and it would be unfortunate to force authors to use script to do them when sandboxed rather than allowing them to use the declarative features. Tests: fast/forms/autofocus-in-sandbox-with-allow-scripts.html media/auto-play-in-sandbox-with-allow-scripts.html * dom/SecurityContext.cpp: (WebCore::SecurityContext::parseSandboxPolicy): LayoutTests: Add layout tests to check that automatic features (video autoplay and form control autofocus) are allowed / working in sandboxed iframes if the allow-scripts flag is set. This behavior is according to the latest specification at: http://dev.w3.org/html5/spec/browsers.html#attr-iframe-sandbox-allow-same-origin The tests to check that automatic features are blocked in sandboxed iframes have been removed since they relied on the allow-scripts flag to work. * fast/forms/autofocus-in-sandbox-with-allow-scripts-expected.txt: Added. * fast/forms/autofocus-in-sandbox-with-allow-scripts.html: Renamed from LayoutTests/fast/forms/no-autofocus-in-sandbox.html. * fast/forms/no-autofocus-in-sandbox-expected.txt: Removed. * media/auto-play-in-sandbox-with-allow-scripts-expected.txt: Added. * media/auto-play-in-sandbox-with-allow-scripts.html: Renamed from LayoutTests/media/no-auto-play-in-sandbox.html. * media/no-auto-play-in-sandbox-expected.txt: Removed. * media/resources/auto-play-in-sandbox-with-allow-scripts-iframe.html: Added. * media/resources/no-auto-play-in-sandbox-iframe.html: Removed. Modified Paths trunk/LayoutTests/ChangeLog trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/dom/SecurityContext.cpp Added Paths trunk/LayoutTests/fast/forms/autofocus-in-sandbox-with-allow-scripts-expected.txt trunk/LayoutTests/fast/forms/autofocus-in-sandbox-with-allow-scripts.html trunk/LayoutTests/media/auto-play-in-sandbox-with-allow-scripts-expected.txt trunk/LayoutTests/media/auto-play-in-sandbox-with-allow-scripts.html trunk/LayoutTests/media/resources/auto-play-in-sandbox-with-allow-scripts-iframe.html Removed Paths trunk/LayoutTests/fast/forms/no-autofocus-in-sandbox-expected.txt trunk/LayoutTests/fast/forms/no-autofocus-in-sandbox.html trunk/LayoutTests/media/no-auto-play-in-sandbox-expected.txt trunk/LayoutTests/media/no-auto-play-in-sandbox.html trunk/LayoutTests/media/resources/no-auto-play-in-sandbox-iframe.html Diff Modified: trunk/LayoutTests/ChangeLog (127480 => 127481) --- trunk/LayoutTests/ChangeLog 2012-09-04 18:54:00 UTC (rev 127480) +++ trunk/LayoutTests/ChangeLog 2012-09-04 18:58:19 UTC (rev 127481) @@ -1,3 +1,29 @@ +2012-09-04 Christophe Dumez christophe.du...@intel.com + +Automatic features should work in sandboxed iframes if allow-scripts flag is set +https://bugs.webkit.org/show_bug.cgi?id=93961 + +Reviewed by Adam Barth. + +Add layout tests to check that automatic features (video +autoplay and form control autofocus) are allowed / working +in sandboxed iframes if the allow-scripts flag is set. +This behavior is according to the latest specification at: +http://dev.w3.org/html5/spec/browsers.html#attr-iframe-sandbox-allow-same-origin + +The tests to check that automatic features are blocked in +sandboxed iframes have been removed since they relied on +the allow-scripts flag to work. + +* fast/forms/autofocus-in-sandbox-with-allow-scripts-expected.txt: Added. +* fast/forms/autofocus-in-sandbox-with-allow-scripts.html: Renamed from LayoutTests/fast/forms/no-autofocus-in-sandbox.html. +* fast/forms/no-autofocus-in-sandbox-expected.txt: Removed. +* media/auto-play-in-sandbox-with-allow-scripts-expected.txt: Added. +* media/auto-play-in-sandbox-with-allow-scripts.html: Renamed from LayoutTests/media/no-auto-play-in-sandbox.html. +* media/no-auto-play-in-sandbox-expected.txt: Removed. +* media/resources/auto-play-in-sandbox-with-allow-scripts-iframe.html: Added. +* media/resources/no-auto-play-in-sandbox-iframe.html: Removed. + 2012-09-04 Tim Horton timothy_hor...@apple.com ASSERTion failure when SVG element is removed from document and readded Added:
[webkit-changes] [127482] trunk/Tools
Title: [127482] trunk/Tools
Revision 127482
Author o...@chromium.org
Date 2012-09-04 12:11:43 -0700 (Tue, 04 Sep 2012)
Log Message
Elide test names when running new-run-webkit-tests
https://bugs.webkit.org/show_bug.cgi?id=95626
Patch by Tony Chang t...@chromium.org on 2012-09-04
Reviewed by Dirk Pranke.
When the test name exceeds the number of terminal columns, it leaves
text on the screen. Avoid this by eliding the test name when running
tests. This is similar to what ninja does when compiling.
* Scripts/webkitpy/layout_tests/views/metered_stream.py:
(MeteredStream):
(MeteredStream.number_of_columns): Helper method to get number of
terminal columns. Won't work on Win32 python, but meh.
* Scripts/webkitpy/layout_tests/views/printing.py:
(Printer._test_status_line): New method for eliding the text. Doesn't use \u2026
because stderr appears to be ascii only.
(Printer.print_started_test): Route through _test_status_line.
(Printer.print_finished_test): Route through _test_status_line.
(Printer._print_test_trace): Route through _test_status_line.
(Printer._print_baseline): Route through _test_status_line.
* Scripts/webkitpy/layout_tests/views/printing_unittest.py:
(test_test_status_line): Test for _test_status_line.
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/TestResultServer/static-dashboards/builders.js
Diff
Modified: trunk/Tools/ChangeLog (127481 => 127482)
--- trunk/Tools/ChangeLog 2012-09-04 18:58:19 UTC (rev 127481)
+++ trunk/Tools/ChangeLog 2012-09-04 19:11:43 UTC (rev 127482)
@@ -74,6 +74,24 @@
(WebViewHost):
(WebViewHost::setPointerLockWillRespondAsynchronously):
+2012-09-04 Ojan Vafai o...@chromium.org
+
+Move content shell bots to their own builder group
+https://bugs.webkit.org/show_bug.cgi?id=95765
+
+Reviewed by Adam Barth.
+
+In their current state of instability, they add too much noise. Once they get more stable,
+we can add them back to the regular group or just have them replace the other bots.
+
+Also, fix the filter for Apple Windows bots since some of them are now Apple Win
+
+* TestResultServer/static-dashboards/builders.js:
+(isWebkitTestRunner):
+(isChromiumContentShellTestRunner):
+(isChromiumWebkitTipOfTreeTestRunner):
+(loadBuildersList):
+
2012-09-03 Ryuan Choi ryuan.c...@samsung.com
[EFL] Change the focus when the web view is clicked in MiniBrowser and EWebLauncher
Modified: trunk/Tools/TestResultServer/static-dashboards/builders.js (127481 => 127482)
--- trunk/Tools/TestResultServer/static-dashboards/builders.js 2012-09-04 18:58:19 UTC (rev 127481)
+++ trunk/Tools/TestResultServer/static-dashboards/builders.js 2012-09-04 19:11:43 UTC (rev 127482)
@@ -165,14 +165,19 @@
{
if (builder.indexOf('Tests') != -1) {
// Apple Windows bots still run old-run-webkit-tests, so they don't upload data.
-return builder.indexOf('Windows') == -1 || (builder.indexOf('Qt') != -1 builder.indexOf('Chromium') != -1);
+return builder.indexOf('Win') == -1 || (builder.indexOf('Qt') != -1 builder.indexOf('Chromium') != -1);
}
return builder.indexOf('GTK') != -1 || builder == 'Qt Linux Release';
}
+function isChromiumContentShellTestRunner(builder)
+{
+return builder.indexOf('(Content Shell)') != -1;
+}
+
function isChromiumWebkitTipOfTreeTestRunner(builder)
{
-return (builder.indexOf('Webkit') != -1 builder.indexOf('Builder') == -1 builder.indexOf('(deps)') == -1 builder.indexOf('ASAN') == -1) || builder.indexOf('(Content Shell)') != -1;
+return builder.indexOf('Webkit') != -1 builder.indexOf('Builder') == -1 builder.indexOf('(deps)') == -1 builder.indexOf('ASAN') == -1;
}
function isChromiumWebkitDepsTestRunner(builder)
@@ -250,6 +255,11 @@
case 'layout-tests':
switch(groupName) {
+case 'Content Shell @ToT - chromium.org':
+var builderGroup = new BuilderGroup(BuilderGroup.TOT_WEBKIT);
+requestBuilderList(LAYOUT_TESTS_BUILDER_GROUPS, isChromiumContentShellTestRunner, CHROMIUM_WEBKIT_BUILDER_MASTER, groupName, builderGroup);
+break;
+
case '@ToT - chromium.org':
var builderGroup = new BuilderGroup(BuilderGroup.TOT_WEBKIT);
requestBuilderList(LAYOUT_TESTS_BUILDER_GROUPS, isChromiumWebkitTipOfTreeTestRunner, CHROMIUM_WEBKIT_BUILDER_MASTER, groupName, builderGroup);
@@ -296,6 +306,7 @@
'@ToT - chromium.org': null,
'@ToT - webkit.org': null,
'@DEPS - chromium.org': null,
+'Content Shell @ToT - chromium.org': null,
};
var CHROMIUM_GPU_TESTS_BUILDER_GROUPS = {
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [127483] trunk/Source
Title: [127483] trunk/Source Revision 127483 Author commit-qu...@webkit.org Date 2012-09-04 12:23:41 -0700 (Tue, 04 Sep 2012) Log Message [GTK] Crash in AccessibilityObject::accessibilityPlatformIncludesObject() https://bugs.webkit.org/show_bug.cgi?id=95740 Patch by Joanmarie Diggs jdi...@igalia.com on 2012-09-04 Reviewed by Martin Robinson. Source/WebCore: Added sanity check to be sure we have a render object prior to seeing if said object is an anonymous block. Testing via unit test because a non-flaky layout test crasher could not be found. * accessibility/gtk/AccessibilityObjectAtk.cpp: (WebCore::AccessibilityObject::accessibilityPlatformIncludesObject): Sanity check for render object added. Source/WebKit/gtk: Updated unit test. * tests/testatk.c: (testWebkitAtkComboBox): Added checks that the menu popup in a combo box has 0 links and, more importantly, that checking doesn't result in a crash. Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/accessibility/gtk/AccessibilityObjectAtk.cpp trunk/Source/WebKit/gtk/ChangeLog trunk/Source/WebKit/gtk/tests/testatk.c Diff Modified: trunk/Source/WebCore/ChangeLog (127482 => 127483) --- trunk/Source/WebCore/ChangeLog 2012-09-04 19:11:43 UTC (rev 127482) +++ trunk/Source/WebCore/ChangeLog 2012-09-04 19:23:41 UTC (rev 127483) @@ -1,3 +1,20 @@ +2012-09-04 Joanmarie Diggs jdi...@igalia.com + +[GTK] Crash in AccessibilityObject::accessibilityPlatformIncludesObject() +https://bugs.webkit.org/show_bug.cgi?id=95740 + +Reviewed by Martin Robinson. + +Added sanity check to be sure we have a render object prior to seeing if +said object is an anonymous block. + +Testing via unit test because a non-flaky layout test crasher could not +be found. + +* accessibility/gtk/AccessibilityObjectAtk.cpp: +(WebCore::AccessibilityObject::accessibilityPlatformIncludesObject): +Sanity check for render object added. + 2012-09-04 Christophe Dumez christophe.du...@intel.com Automatic features should work in sandboxed iframes if allow-scripts flag is set Modified: trunk/Source/WebCore/accessibility/gtk/AccessibilityObjectAtk.cpp (127482 => 127483) --- trunk/Source/WebCore/accessibility/gtk/AccessibilityObjectAtk.cpp 2012-09-04 19:11:43 UTC (rev 127482) +++ trunk/Source/WebCore/accessibility/gtk/AccessibilityObjectAtk.cpp 2012-09-04 19:23:41 UTC (rev 127483) @@ -104,7 +104,7 @@ // anonymous blocks which are aria-related to themselves have an aria role, nor // have we encountered instances where the parent of an anonymous block also lacked // an aria role but the grandparent had one. -if (renderer()-isAnonymousBlock() !parent-renderer()-isBody() +if (renderer() renderer()-isAnonymousBlock() !parent-renderer()-isBody() parent-ariaRoleAttribute() == UnknownRole) return IgnoreObject; Modified: trunk/Source/WebKit/gtk/ChangeLog (127482 => 127483) --- trunk/Source/WebKit/gtk/ChangeLog 2012-09-04 19:11:43 UTC (rev 127482) +++ trunk/Source/WebKit/gtk/ChangeLog 2012-09-04 19:23:41 UTC (rev 127483) @@ -1,3 +1,16 @@ +2012-09-04 Joanmarie Diggs jdi...@igalia.com + +[GTK] Crash in AccessibilityObject::accessibilityPlatformIncludesObject() +https://bugs.webkit.org/show_bug.cgi?id=95740 + +Reviewed by Martin Robinson. + +Updated unit test. + +* tests/testatk.c: +(testWebkitAtkComboBox): Added checks that the menu popup in a combo box +has 0 links and, more importantly, that checking doesn't result in a crash. + 2012-09-01 Joanmarie Diggs jdi...@igalia.com [Gtk] Incorrect/unexpected characters in the text of certain accessibles Modified: trunk/Source/WebKit/gtk/tests/testatk.c (127482 => 127483) --- trunk/Source/WebKit/gtk/tests/testatk.c 2012-09-04 19:11:43 UTC (rev 127482) +++ trunk/Source/WebKit/gtk/tests/testatk.c 2012-09-04 19:23:41 UTC (rev 127483) @@ -562,6 +562,10 @@ g_assert(selectedItem == item1); g_object_unref(selectedItem); +/* Check that the menu popup has 0 links and doesn't crash from checking. */ +gint nLinks = atk_hypertext_get_n_links(ATK_HYPERTEXT(menuPopup)); +g_assert_cmpint(nLinks, ==, 0); + /* Check the implementations of the AtkAction interface. */ g_assert(ATK_IS_ACTION(comboBox)); AtkAction* atkAction = ATK_ACTION(comboBox); ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [127484] trunk/Source
Title: [127484] trunk/Source
Revision 127484
Author zol...@webkit.org
Date 2012-09-04 12:35:54 -0700 (Tue, 04 Sep 2012)
Log Message
Extend the coverage of the Custom Allocation Framework in WTF and in _javascript_Core
https://bugs.webkit.org/show_bug.cgi?id=95737
Reviewed by Eric Seidel.
Add WTF_MAKE_FAST_ALLOCATED macro to the following class declarations because these are instantiated by operator new.
Source/_javascript_Core:
* wtf/CryptographicallyRandomNumber.cpp: CryptographicallyRandomNumber is instantiated at wtf/CryptographicallyRandomNumber.cpp:162.
* heap/MachineStackMarker.cpp:
(MachineThreads::Thread): Thread is instantiated at heap/MachineStackMarker.cpp:196.
* jit/ExecutableAllocatorFixedVMPool.cpp:
(FixedVMPoolExecutableAllocator): FixedVMPoolExecutableAllocator is instantiated at jit/ExecutableAllocatorFixedVMPool.cpp:111
* parser/SourceProviderCache.h:
(SourceProviderCache): SourceProviderCache is instantiated at parser/SourceProvider.h:49.
* parser/SourceProviderCacheItem.h:
(SourceProviderCacheItem): SourceProviderCacheItem is instantiated at parser/Parser.cpp:843.
* runtime/GCActivityCallback.h:
(GCActivityCallback): GCActivityCallback is instantiated at runtime/GCActivityCallback.h:96.
* tools/CodeProfile.h:
(CodeProfile): CodeProfile is instantiated at _javascript_Core/tools/CodeProfiling.cpp:140.
Source/WTF:
* wtf/CryptographicallyRandomNumber.cpp: CryptographicallyRandomNumber is instantiated at wtf/CryptographicallyRandomNumber.cpp:162.
* wtf/MediaTime.h: MediaTime is instantiated at wtf/MediaTime.cpp:288.
* wtf/MetaAllocator.h:
(MetaAllocatorTracker): MetaAllocatorTracker is instantiated at _javascript_Core/tools/CodeProfiling.cpp:120.
* wtf/ThreadingPthreads.cpp:
(PthreadState): PthreadState is instantiated at wtf/ThreadingPthreads.cpp:165.
* wtf/text/AtomicString.cpp:
(AtomicStringTable): AtomicStringTable is instantiated at wtf/text/AtomicString.cpp:43.
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/heap/MachineStackMarker.cpp
trunk/Source/_javascript_Core/jit/ExecutableAllocatorFixedVMPool.cpp
trunk/Source/_javascript_Core/parser/SourceProviderCache.h
trunk/Source/_javascript_Core/parser/SourceProviderCacheItem.h
trunk/Source/_javascript_Core/runtime/GCActivityCallback.h
trunk/Source/_javascript_Core/tools/CodeProfile.h
trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/CryptographicallyRandomNumber.cpp
trunk/Source/WTF/wtf/MediaTime.h
trunk/Source/WTF/wtf/MetaAllocator.h
trunk/Source/WTF/wtf/ThreadingPthreads.cpp
trunk/Source/WTF/wtf/text/AtomicString.cpp
Property Changed
trunk/Source/WTF/wtf/MediaTime.h
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (127483 => 127484)
--- trunk/Source/_javascript_Core/ChangeLog 2012-09-04 19:23:41 UTC (rev 127483)
+++ trunk/Source/_javascript_Core/ChangeLog 2012-09-04 19:35:54 UTC (rev 127484)
@@ -1,3 +1,27 @@
+2012-09-04 Zoltan Horvath zol...@webkit.org
+
+Extend the coverage of the Custom Allocation Framework in WTF and in _javascript_Core
+https://bugs.webkit.org/show_bug.cgi?id=95737
+
+Reviewed by Eric Seidel.
+
+Add WTF_MAKE_FAST_ALLOCATED macro to the following class declarations because these are instantiated by operator new.
+
+* wtf/CryptographicallyRandomNumber.cpp: CryptographicallyRandomNumber is instantiated at wtf/CryptographicallyRandomNumber.cpp:162.
+
+* heap/MachineStackMarker.cpp:
+(MachineThreads::Thread): Thread is instantiated at heap/MachineStackMarker.cpp:196.
+* jit/ExecutableAllocatorFixedVMPool.cpp:
+(FixedVMPoolExecutableAllocator): FixedVMPoolExecutableAllocator is instantiated at jit/ExecutableAllocatorFixedVMPool.cpp:111
+* parser/SourceProviderCache.h:
+(SourceProviderCache): SourceProviderCache is instantiated at parser/SourceProvider.h:49.
+* parser/SourceProviderCacheItem.h:
+(SourceProviderCacheItem): SourceProviderCacheItem is instantiated at parser/Parser.cpp:843.
+* runtime/GCActivityCallback.h:
+(GCActivityCallback): GCActivityCallback is instantiated at runtime/GCActivityCallback.h:96.
+* tools/CodeProfile.h:
+(CodeProfile): CodeProfile is instantiated at _javascript_Core/tools/CodeProfiling.cpp:140.
+
2012-09-04 Mark Hahnenberg mhahnenb...@apple.com
Remove uses of ClassInfo from SpeculativeJIT::compileObjectOrOtherLogicalNot
Modified: trunk/Source/_javascript_Core/heap/MachineStackMarker.cpp (127483 => 127484)
--- trunk/Source/_javascript_Core/heap/MachineStackMarker.cpp 2012-09-04 19:23:41 UTC (rev 127483)
+++ trunk/Source/_javascript_Core/heap/MachineStackMarker.cpp 2012-09-04 19:35:54 UTC (rev 127484)
@@ -107,6 +107,7 @@
#endif
class MachineThreads::Thread {
+WTF_MAKE_FAST_ALLOCATED;
public:
Thread(const PlatformThread platThread, void* base)
: platformThread(platThread)
Modified: trunk/Source/_javascript_Core/jit/ExecutableAllocatorFixedVMPool.cpp
[webkit-changes] [127485] trunk
Title: [127485] trunk
Revision 127485
Author tom...@google.com
Date 2012-09-04 12:43:51 -0700 (Tue, 04 Sep 2012)
Log Message
MediaStream API: Change the MediaStreamTrackList track added/removed signaling
https://bugs.webkit.org/show_bug.cgi?id=95721
Reviewed by Adam Barth.
Source/Platform:
Adding the signaling to the WebKit interface.
* chromium/public/WebMediaStreamCenter.h:
(WebKit::WebMediaStreamCenter::didAddMediaStreamTrack):
(WebKit::WebMediaStreamCenter::didRemoveMediaStreamTrack):
Source/WebCore:
This allows the platform implementor to throw an NOT_SUPPORTED_ERR exception if it doesn support these methods.
Patch covered by expanded existing test.
* Modules/mediastream/MediaStreamTrackList.cpp:
(WebCore::MediaStreamTrackList::add):
(WebCore::MediaStreamTrackList::remove):
* platform/mediastream/MediaStreamCenter.h:
(MediaStreamCenter):
* platform/mediastream/blackberry/MediaStreamCenterBlackBerry.cpp:
(WebCore::MediaStreamCenterBlackBerry::didAddMediaStreamTrack):
(WebCore):
(WebCore::MediaStreamCenterBlackBerry::didRemoveMediaStreamTrack):
* platform/mediastream/blackberry/MediaStreamCenterBlackBerry.h:
(MediaStreamCenterBlackBerry):
* platform/mediastream/chromium/MediaStreamCenterChromium.cpp:
(WebCore::MediaStreamCenterChromium::didAddMediaStreamTrack):
(WebCore::MediaStreamCenterChromium::didRemoveMediaStreamTrack):
* platform/mediastream/chromium/MediaStreamCenterChromium.h:
(MediaStreamCenterChromium):
* platform/mediastream/gstreamer/MediaStreamCenterGStreamer.cpp:
(WebCore::MediaStreamCenterGStreamer::didAddMediaStreamTrack):
(WebCore::MediaStreamCenterGStreamer::didRemoveMediaStreamTrack):
* platform/mediastream/gstreamer/MediaStreamCenterGStreamer.h:
(MediaStreamCenterGStreamer):
Tools:
* DumpRenderTree/chromium/MockWebMediaStreamCenter.cpp:
(MockWebMediaStreamCenter::didAddMediaStreamTrack):
(MockWebMediaStreamCenter::didRemoveMediaStreamTrack):
* DumpRenderTree/chromium/MockWebMediaStreamCenter.h:
(MockWebMediaStreamCenter):
LayoutTests:
* fast/mediastream/MediaStreamTrackList.html:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/mediastream/MediaStreamTrackList.html
trunk/Source/Platform/ChangeLog
trunk/Source/Platform/chromium/public/WebMediaStreamCenter.h
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/mediastream/MediaStreamTrackList.cpp
trunk/Source/WebCore/platform/mediastream/MediaStreamCenter.h
trunk/Source/WebCore/platform/mediastream/blackberry/MediaStreamCenterBlackBerry.cpp
trunk/Source/WebCore/platform/mediastream/blackberry/MediaStreamCenterBlackBerry.h
trunk/Source/WebCore/platform/mediastream/chromium/MediaStreamCenterChromium.cpp
trunk/Source/WebCore/platform/mediastream/chromium/MediaStreamCenterChromium.h
trunk/Source/WebCore/platform/mediastream/gstreamer/MediaStreamCenterGStreamer.cpp
trunk/Source/WebCore/platform/mediastream/gstreamer/MediaStreamCenterGStreamer.h
trunk/Tools/ChangeLog
trunk/Tools/DumpRenderTree/chromium/MockWebMediaStreamCenter.cpp
trunk/Tools/DumpRenderTree/chromium/MockWebMediaStreamCenter.h
Diff
Modified: trunk/LayoutTests/ChangeLog (127484 => 127485)
--- trunk/LayoutTests/ChangeLog 2012-09-04 19:35:54 UTC (rev 127484)
+++ trunk/LayoutTests/ChangeLog 2012-09-04 19:43:51 UTC (rev 127485)
@@ -1,3 +1,12 @@
+2012-09-04 Tommy Widenflycht tom...@google.com
+
+MediaStream API: Change the MediaStreamTrackList track added/removed signaling
+https://bugs.webkit.org/show_bug.cgi?id=95721
+
+Reviewed by Adam Barth.
+
+* fast/mediastream/MediaStreamTrackList.html:
+
2012-09-04 Christophe Dumez christophe.du...@intel.com
Automatic features should work in sandboxed iframes if allow-scripts flag is set
Modified: trunk/LayoutTests/fast/mediastream/MediaStreamTrackList.html (127484 => 127485)
--- trunk/LayoutTests/fast/mediastream/MediaStreamTrackList.html 2012-09-04 19:35:54 UTC (rev 127484)
+++ trunk/LayoutTests/fast/mediastream/MediaStreamTrackList.html 2012-09-04 19:43:51 UTC (rev 127485)
@@ -42,14 +42,25 @@
testPassed('Add track callback succeeded.');
stream1.videoTracks._onremovetrack_ = onRemoveTrack;
-stream1.videoTracks.remove(e.track);
+try {
+stream1.videoTracks.remove(e.track);
+} catch (exception) {
+testFailed(remove threw an exception.);
+finishJSTest();
+}
}
function gotStream2(s) {
stream2 = s;
stream1.videoTracks._onaddtrack_ = onAddTrack;
-stream1.videoTracks.add(stream2.videoTracks[0]);
+
+try {
+stream1.videoTracks.add(stream2.videoTracks[0]);
+} catch (exception) {
+testFailed(add threw an exception.);
+finishJSTest();
+}
}
function gotStream1(s) {
Modified: trunk/Source/Platform/ChangeLog (127484 => 127485)
--- trunk/Source/Platform/ChangeLog 2012-09-04 19:35:54 UTC (rev 127484)
+++ trunk/Source/Platform/ChangeLog 2012-09-04 19:43:51 UTC (rev 127485)
@@ -1,3 +1,16 @@
+2012-09-04 Tommy Widenflycht tom...@google.com
+
[webkit-changes] [127486] trunk/Source/WebKit/blackberry
Title: [127486] trunk/Source/WebKit/blackberry
Revision 127486
Author rwlb...@webkit.org
Date 2012-09-04 12:46:35 -0700 (Tue, 04 Sep 2012)
Log Message
[BlackBerry] Provide virtual dtor for DumpRenderTreeClient
https://bugs.webkit.org/show_bug.cgi?id=95769
Reviewed by NOBODY (OOPS!).
Also remove WTF prefixes.
* Api/DumpRenderTreeClient.h:
Modified Paths
trunk/Source/WebKit/blackberry/Api/DumpRenderTreeClient.h
trunk/Source/WebKit/blackberry/ChangeLog
Diff
Modified: trunk/Source/WebKit/blackberry/Api/DumpRenderTreeClient.h (127485 => 127486)
--- trunk/Source/WebKit/blackberry/Api/DumpRenderTreeClient.h 2012-09-04 19:43:51 UTC (rev 127485)
+++ trunk/Source/WebKit/blackberry/Api/DumpRenderTreeClient.h 2012-09-04 19:46:35 UTC (rev 127486)
@@ -42,6 +42,7 @@
class BLACKBERRY_EXPORT DumpRenderTreeClient {
public:
+virtual ~DumpRenderTreeClient() { }
virtual void runTests() = 0;
// FrameLoaderClient delegates
@@ -53,19 +54,19 @@
virtual void didFinishLoadForFrame(WebCore::Frame*) = 0;
virtual void didFinishDocumentLoadForFrame(WebCore::Frame*) = 0;
virtual void didClearWindowObjectInWorld(WebCore::DOMWrapperWorld*, JSGlobalContextRef, JSObjectRef windowObject) = 0;
-virtual void didReceiveTitleForFrame(const WTF::String title, WebCore::Frame*) = 0;
+virtual void didReceiveTitleForFrame(const String title, WebCore::Frame*) = 0;
virtual void didDecidePolicyForNavigationAction(const WebCore::NavigationAction, const WebCore::ResourceRequest) = 0;
virtual void didDispatchWillPerformClientRedirect() = 0;
virtual void didHandleOnloadEventsForFrame(WebCore::Frame*) = 0;
// ChromeClient delegates
-virtual void addMessageToConsole(const WTF::String message, unsigned int lineNumber, const WTF::String sourceID) = 0;
-virtual void runJavaScriptAlert(const WTF::String message) = 0;
-virtual bool runJavaScriptConfirm(const WTF::String message) = 0;
-virtual WTF::String runJavaScriptPrompt(const WTF::String message, const WTF::String defaultValue) = 0;
-virtual bool runBeforeUnloadConfirmPanel(const WTF::String message) = 0;
-virtual void setStatusText(const WTF::String) = 0;
-virtual void exceededDatabaseQuota(WebCore::SecurityOrigin*, const WTF::String name) = 0;
+virtual void addMessageToConsole(const String message, unsigned int lineNumber, const String sourceID) = 0;
+virtual void runJavaScriptAlert(const String message) = 0;
+virtual bool runJavaScriptConfirm(const String message) = 0;
+virtual String runJavaScriptPrompt(const String message, const String defaultValue) = 0;
+virtual bool runBeforeUnloadConfirmPanel(const String message) = 0;
+virtual void setStatusText(const String) = 0;
+virtual void exceededDatabaseQuota(WebCore::SecurityOrigin*, const String name) = 0;
virtual bool allowsOpeningWindow() = 0;
virtual void windowCreated(WebPage*) = 0;
@@ -80,7 +81,7 @@
virtual bool shouldDeleteDOMRange(WebCore::Range*) = 0;
virtual bool shouldChangeSelectedDOMRangeToDOMRangeAffinityStillSelecting(WebCore::Range* fromRange, WebCore::Range* toRange, int affinity, bool stillSelecting) = 0;
virtual bool shouldInsertNode(WebCore::Node*, WebCore::Range*, int insertAction) = 0;
-virtual bool shouldInsertText(const WTF::String, WebCore::Range*, int insertAction) = 0;
+virtual bool shouldInsertText(const String, WebCore::Range*, int insertAction) = 0;
virtual bool isSelectTrailingWhitespaceEnabled() const = 0;
virtual bool didReceiveAuthenticationChallenge(WebCore::Credential) = 0;
Modified: trunk/Source/WebKit/blackberry/ChangeLog (127485 => 127486)
--- trunk/Source/WebKit/blackberry/ChangeLog 2012-09-04 19:43:51 UTC (rev 127485)
+++ trunk/Source/WebKit/blackberry/ChangeLog 2012-09-04 19:46:35 UTC (rev 127486)
@@ -1,3 +1,14 @@
+2012-09-04 Rob Buis rb...@rim.com
+
+[BlackBerry] Provide virtual dtor for DumpRenderTreeClient
+https://bugs.webkit.org/show_bug.cgi?id=95769
+
+Reviewed by Yong Li.
+
+Also remove WTF prefixes.
+
+* Api/DumpRenderTreeClient.h:
+
2012-09-04 Mary Wu mary...@torchmobile.com.cn
[BlackBerry] Add webplatform and browser to build info
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [127487] trunk/Source/WebKit2
Title: [127487] trunk/Source/WebKit2
Revision 127487
Author commit-qu...@webkit.org
Date 2012-09-04 12:48:56 -0700 (Tue, 04 Sep 2012)
Log Message
[Qt] Remove use of deprecated QInputMethod method
https://bugs.webkit.org/show_bug.cgi?id=95741
Patch by Pekka Vuorela pvuor...@iki.fi on 2012-09-04
Reviewed by Simon Hausmann.
Adapt from deprecated QInputMethod::visible() to isVisible().
* UIProcess/qt/QtWebPageEventHandler.cpp:
(WebKit::setInputPanelVisible):
(WebKit::QtWebPageEventHandler::inputPanelVisibleChanged):
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/qt/QtWebPageEventHandler.cpp
Diff
Modified: trunk/Source/WebKit2/ChangeLog (127486 => 127487)
--- trunk/Source/WebKit2/ChangeLog 2012-09-04 19:46:35 UTC (rev 127486)
+++ trunk/Source/WebKit2/ChangeLog 2012-09-04 19:48:56 UTC (rev 127487)
@@ -1,3 +1,16 @@
+2012-09-04 Pekka Vuorela pvuor...@iki.fi
+
+[Qt] Remove use of deprecated QInputMethod method
+https://bugs.webkit.org/show_bug.cgi?id=95741
+
+Reviewed by Simon Hausmann.
+
+Adapt from deprecated QInputMethod::visible() to isVisible().
+
+* UIProcess/qt/QtWebPageEventHandler.cpp:
+(WebKit::setInputPanelVisible):
+(WebKit::QtWebPageEventHandler::inputPanelVisibleChanged):
+
2012-09-04 Allan Sandfeld Jensen allan.jen...@nokia.com
Allow child-frame content in hit-tests.
Modified: trunk/Source/WebKit2/UIProcess/qt/QtWebPageEventHandler.cpp (127486 => 127487)
--- trunk/Source/WebKit2/UIProcess/qt/QtWebPageEventHandler.cpp 2012-09-04 19:46:35 UTC (rev 127486)
+++ trunk/Source/WebKit2/UIProcess/qt/QtWebPageEventHandler.cpp 2012-09-04 19:48:56 UTC (rev 127487)
@@ -398,7 +398,7 @@
static void setInputPanelVisible(bool visible)
{
-if (qApp-inputMethod()-visible() == visible)
+if (qApp-inputMethod()-isVisible() == visible)
return;
qApp-inputMethod()-setVisible(visible);
@@ -410,7 +410,7 @@
return;
// We only respond to the input panel becoming visible.
-if (!m_webView-hasActiveFocus() || !qApp-inputMethod()-visible())
+if (!m_webView-hasActiveFocus() || !qApp-inputMethod()-isVisible())
return;
const EditorState editor = m_webPageProxy-editorState();
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [127489] trunk/Source/WebKit/blackberry
Title: [127489] trunk/Source/WebKit/blackberry
Revision 127489
Author stai...@webkit.org
Date 2012-09-04 13:03:17 -0700 (Tue, 04 Sep 2012)
Log Message
[BlackBerry] pass isMainFrame() through to notifyDocumentOnLoad()
https://bugs.webkit.org/show_bug.cgi?id=95766
Reviewed by Rob Buis.
Passing the frame status through will allow the client to make better
decisions about how to act on the onload.
* Api/WebPageClient.h:
* WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
(WebCore::FrameLoaderClientBlackBerry::dispatchDidHandleOnloadEvents):
Modified Paths
trunk/Source/WebKit/blackberry/Api/WebPageClient.h
trunk/Source/WebKit/blackberry/ChangeLog
trunk/Source/WebKit/blackberry/WebCoreSupport/FrameLoaderClientBlackBerry.cpp
Diff
Modified: trunk/Source/WebKit/blackberry/Api/WebPageClient.h (127488 => 127489)
--- trunk/Source/WebKit/blackberry/Api/WebPageClient.h 2012-09-04 19:59:35 UTC (rev 127488)
+++ trunk/Source/WebKit/blackberry/Api/WebPageClient.h 2012-09-04 20:03:17 UTC (rev 127489)
@@ -104,7 +104,7 @@
virtual void notifyInRegionScrollingStartingPointChanged(const std::vectorPlatform::ScrollViewBase*) = 0;
virtual void notifyNoMouseMoveOrTouchMoveHandlers() = 0;
-virtual void notifyDocumentOnLoad() = 0;
+virtual void notifyDocumentOnLoad(bool) = 0;
virtual void notifyWindowObjectCleared() = 0;
virtual WebString invokeClientJavaScriptCallback(const char* const* args, unsigned numArgs) = 0;
Modified: trunk/Source/WebKit/blackberry/ChangeLog (127488 => 127489)
--- trunk/Source/WebKit/blackberry/ChangeLog 2012-09-04 19:59:35 UTC (rev 127488)
+++ trunk/Source/WebKit/blackberry/ChangeLog 2012-09-04 20:03:17 UTC (rev 127489)
@@ -1,3 +1,17 @@
+2012-09-04 George Staikos stai...@webkit.org
+
+[BlackBerry] pass isMainFrame() through to notifyDocumentOnLoad()
+https://bugs.webkit.org/show_bug.cgi?id=95766
+
+Reviewed by Rob Buis.
+
+Passing the frame status through will allow the client to make better
+decisions about how to act on the onload.
+
+* Api/WebPageClient.h:
+* WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
+(WebCore::FrameLoaderClientBlackBerry::dispatchDidHandleOnloadEvents):
+
2012-09-04 Rob Buis rb...@rim.com
[BlackBerry] Provide virtual dtor for DumpRenderTreeClient
Modified: trunk/Source/WebKit/blackberry/WebCoreSupport/FrameLoaderClientBlackBerry.cpp (127488 => 127489)
--- trunk/Source/WebKit/blackberry/WebCoreSupport/FrameLoaderClientBlackBerry.cpp 2012-09-04 19:59:35 UTC (rev 127488)
+++ trunk/Source/WebKit/blackberry/WebCoreSupport/FrameLoaderClientBlackBerry.cpp 2012-09-04 20:03:17 UTC (rev 127489)
@@ -572,7 +572,7 @@
void FrameLoaderClientBlackBerry::dispatchDidHandleOnloadEvents()
{
-m_webPagePrivate-m_client-notifyDocumentOnLoad();
+m_webPagePrivate-m_client-notifyDocumentOnLoad(isMainFrame());
if (m_webPagePrivate-m_dumpRenderTree)
m_webPagePrivate-m_dumpRenderTree-didHandleOnloadEventsForFrame(m_frame);
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [127490] tags/Safari-537.8/trunk/
Title: [127490] tags/Safari-537.8/trunk/ Revision 127490 Author lforsch...@apple.com Date 2012-09-04 13:05:44 -0700 (Tue, 04 Sep 2012) Log Message New Tag. Added Paths tags/Safari-537.8/trunk/ Diff Property changes: tags/Safari-537.8/trunk Added: svn:ignore depcomp compile config.guess GNUmakefile.in config.sub ltmain.sh aconfig.h.in autom4te.cache missing aclocal.m4 install-sh autotoolsconfig.h.in INSTALL README gtk-doc.make out Makefile.chromium WebKitSupportLibrary.zip WebKitBuild Added: svn:mergeinfo ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [127491] trunk/LayoutTests
Title: [127491] trunk/LayoutTests Revision 127491 Author roger_f...@apple.com Date 2012-09-04 13:14:40 -0700 (Tue, 04 Sep 2012) Log Message Unreviewed. Removing accidentally added executable properties on test files. * platform/win/accessibility/canvas-description-and-role-expected.txt: Removed property svn:executable. * platform/win/fast/canvas/canvas-strokeRect-alpha-shadow-expected.txt: Removed property svn:executable. * platform/win/fast/css/image-resolution/image-resolution-expected.txt: Removed property svn:executable. * platform/win/fast/css/image-set-setting-expected.txt: Removed property svn:executable. * platform/win/fast/css/parse-border-image-repeat-null-crash-expected.txt: Removed property svn:executable. * platform/win/fast/css/variables/build-supports-variables-expected.txt: Removed property svn:executable. * platform/win/fast/css3-text-decoration/getComputedStyle/getComputedStyle-text-decoration-line-expected.txt: Removed property svn:executable. * platform/win/fast/css3-text-decoration/getComputedStyle/getComputedStyle-text-decoration-style-expected.txt: Removed property svn:executable. Modified Paths trunk/LayoutTests/ChangeLog Property Changed trunk/LayoutTests/platform/win/accessibility/canvas-description-and-role-expected.txt trunk/LayoutTests/platform/win/fast/canvas/canvas-strokeRect-alpha-shadow-expected.txt trunk/LayoutTests/platform/win/fast/css/image-resolution/image-resolution-expected.txt trunk/LayoutTests/platform/win/fast/css/image-set-setting-expected.txt trunk/LayoutTests/platform/win/fast/css/parse-border-image-repeat-null-crash-expected.txt trunk/LayoutTests/platform/win/fast/css/variables/build-supports-variables-expected.txt trunk/LayoutTests/platform/win/fast/css3-text-decoration/getComputedStyle/getComputedStyle-text-decoration-line-expected.txt trunk/LayoutTests/platform/win/fast/css3-text-decoration/getComputedStyle/getComputedStyle-text-decoration-style-expected.txt Diff Modified: trunk/LayoutTests/ChangeLog (127490 => 127491) --- trunk/LayoutTests/ChangeLog 2012-09-04 20:05:44 UTC (rev 127490) +++ trunk/LayoutTests/ChangeLog 2012-09-04 20:14:40 UTC (rev 127491) @@ -1,3 +1,16 @@ +2012-09-04 Roger Fong roger_f...@apple.com + +Unreviewed. Removing accidentally added executable properties on test files. + +* platform/win/accessibility/canvas-description-and-role-expected.txt: Removed property svn:executable. +* platform/win/fast/canvas/canvas-strokeRect-alpha-shadow-expected.txt: Removed property svn:executable. +* platform/win/fast/css/image-resolution/image-resolution-expected.txt: Removed property svn:executable. +* platform/win/fast/css/image-set-setting-expected.txt: Removed property svn:executable. +* platform/win/fast/css/parse-border-image-repeat-null-crash-expected.txt: Removed property svn:executable. +* platform/win/fast/css/variables/build-supports-variables-expected.txt: Removed property svn:executable. +* platform/win/fast/css3-text-decoration/getComputedStyle/getComputedStyle-text-decoration-line-expected.txt: Removed property svn:executable. +* platform/win/fast/css3-text-decoration/getComputedStyle/getComputedStyle-text-decoration-style-expected.txt: Removed property svn:executable. + 2012-09-04 Tommy Widenflycht tom...@google.com MediaStream API: Change the MediaStreamTrackList track added/removed signaling Property changes: trunk/LayoutTests/platform/win/accessibility/canvas-description-and-role-expected.txt Deleted: svn:executable Property changes: trunk/LayoutTests/platform/win/fast/canvas/canvas-strokeRect-alpha-shadow-expected.txt Deleted: svn:executable Property changes: trunk/LayoutTests/platform/win/fast/css/image-resolution/image-resolution-expected.txt Deleted: svn:executable Property changes: trunk/LayoutTests/platform/win/fast/css/image-set-setting-expected.txt Deleted: svn:executable Property changes: trunk/LayoutTests/platform/win/fast/css/parse-border-image-repeat-null-crash-expected.txt Deleted: svn:executable Property changes: trunk/LayoutTests/platform/win/fast/css/variables/build-supports-variables-expected.txt Deleted: svn:executable Property changes: trunk/LayoutTests/platform/win/fast/css3-text-decoration/getComputedStyle/getComputedStyle-text-decoration-line-expected.txt Deleted: svn:executable Property changes: trunk/LayoutTests/platform/win/fast/css3-text-decoration/getComputedStyle/getComputedStyle-text-decoration-style-expected.txt Deleted: svn:executable ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [127492] trunk/Source
Title: [127492] trunk/Source Revision 127492 Author lforsch...@apple.com Date 2012-09-04 13:18:48 -0700 (Tue, 04 Sep 2012) Log Message Versioning. Modified Paths trunk/Source/_javascript_Core/Configurations/Version.xcconfig trunk/Source/WebCore/Configurations/Version.xcconfig trunk/Source/WebKit/mac/Configurations/Version.xcconfig trunk/Source/WebKit2/Configurations/Version.xcconfig Diff Modified: trunk/Source/_javascript_Core/Configurations/Version.xcconfig (127491 => 127492) --- trunk/Source/_javascript_Core/Configurations/Version.xcconfig 2012-09-04 20:14:40 UTC (rev 127491) +++ trunk/Source/_javascript_Core/Configurations/Version.xcconfig 2012-09-04 20:18:48 UTC (rev 127492) @@ -22,7 +22,7 @@ // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. MAJOR_VERSION = 537; -MINOR_VERSION = 8; +MINOR_VERSION = 9; TINY_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION); Modified: trunk/Source/WebCore/Configurations/Version.xcconfig (127491 => 127492) --- trunk/Source/WebCore/Configurations/Version.xcconfig 2012-09-04 20:14:40 UTC (rev 127491) +++ trunk/Source/WebCore/Configurations/Version.xcconfig 2012-09-04 20:18:48 UTC (rev 127492) @@ -22,7 +22,7 @@ // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. MAJOR_VERSION = 537; -MINOR_VERSION = 8; +MINOR_VERSION = 9; TINY_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION); Modified: trunk/Source/WebKit/mac/Configurations/Version.xcconfig (127491 => 127492) --- trunk/Source/WebKit/mac/Configurations/Version.xcconfig 2012-09-04 20:14:40 UTC (rev 127491) +++ trunk/Source/WebKit/mac/Configurations/Version.xcconfig 2012-09-04 20:18:48 UTC (rev 127492) @@ -22,7 +22,7 @@ // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. MAJOR_VERSION = 537; -MINOR_VERSION = 8; +MINOR_VERSION = 9; TINY_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION); Modified: trunk/Source/WebKit2/Configurations/Version.xcconfig (127491 => 127492) --- trunk/Source/WebKit2/Configurations/Version.xcconfig 2012-09-04 20:14:40 UTC (rev 127491) +++ trunk/Source/WebKit2/Configurations/Version.xcconfig 2012-09-04 20:18:48 UTC (rev 127492) @@ -22,7 +22,7 @@ // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. MAJOR_VERSION = 537; -MINOR_VERSION = 8; +MINOR_VERSION = 9; TINY_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION); ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [127494] trunk/Source/WebKit/chromium
Title: [127494] trunk/Source/WebKit/chromium
Revision 127494
Author commit-qu...@webkit.org
Date 2012-09-04 13:25:47 -0700 (Tue, 04 Sep 2012)
Log Message
[chromium] Rename WebViewClient::handleDisambiguationPopup
https://bugs.webkit.org/show_bug.cgi?id=95529
Patch by Tien-Ren Chen trc...@chromium.org on 2012-09-04
Reviewed by Adam Barth.
Rename it to something more descriptive (WebViewClient::didTapMultipleTargets) before people start using it.
* public/WebViewClient.h:
(WebKit::WebViewClient::didTapMultipleTargets):
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::handleGestureEvent):
* tests/WebFrameTest.cpp:
Modified Paths
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/public/WebViewClient.h
trunk/Source/WebKit/chromium/src/WebViewImpl.cpp
trunk/Source/WebKit/chromium/tests/WebFrameTest.cpp
Diff
Modified: trunk/Source/WebKit/chromium/ChangeLog (127493 => 127494)
--- trunk/Source/WebKit/chromium/ChangeLog 2012-09-04 20:22:16 UTC (rev 127493)
+++ trunk/Source/WebKit/chromium/ChangeLog 2012-09-04 20:25:47 UTC (rev 127494)
@@ -1,3 +1,18 @@
+2012-09-04 Tien-Ren Chen trc...@chromium.org
+
+[chromium] Rename WebViewClient::handleDisambiguationPopup
+https://bugs.webkit.org/show_bug.cgi?id=95529
+
+Reviewed by Adam Barth.
+
+Rename it to something more descriptive (WebViewClient::didTapMultipleTargets) before people start using it.
+
+* public/WebViewClient.h:
+(WebKit::WebViewClient::didTapMultipleTargets):
+* src/WebViewImpl.cpp:
+(WebKit::WebViewImpl::handleGestureEvent):
+* tests/WebFrameTest.cpp:
+
2012-09-03 Tao Bai michael...@chromium.org
Added ANDROID_GDBSERVER definition for Ant
Modified: trunk/Source/WebKit/chromium/public/WebViewClient.h (127493 => 127494)
--- trunk/Source/WebKit/chromium/public/WebViewClient.h 2012-09-04 20:22:16 UTC (rev 127493)
+++ trunk/Source/WebKit/chromium/public/WebViewClient.h 2012-09-04 20:25:47 UTC (rev 127494)
@@ -288,7 +288,7 @@
virtual void didUpdateLayout() { }
// Return true to swallow the input event if the embedder will start a disambiguation popup
-virtual bool handleDisambiguationPopup(const WebGestureEvent, const WebVectorWebRect targetRects) { return false; }
+virtual bool didTapMultipleTargets(const WebGestureEvent, const WebVectorWebRect targetRects) { return false; }
// Session history -
Modified: trunk/Source/WebKit/chromium/src/WebViewImpl.cpp (127493 => 127494)
--- trunk/Source/WebKit/chromium/src/WebViewImpl.cpp 2012-09-04 20:22:16 UTC (rev 127493)
+++ trunk/Source/WebKit/chromium/src/WebViewImpl.cpp 2012-09-04 20:25:47 UTC (rev 127494)
@@ -718,7 +718,7 @@
findGoodTouchTargets(event.boundingBox, mainFrameImpl()-frame(), pageScaleFactor(), goodTargets);
// FIXME: replace touch adjustment code when numberOfGoodTargets == 1?
// Single candidate case is currently handled by: https://bugs.webkit.org/show_bug.cgi?id=85101
-if (goodTargets.size() = 2 m_client m_client-handleDisambiguationPopup(event, goodTargets))
+if (goodTargets.size() = 2 m_client m_client-didTapMultipleTargets(event, goodTargets))
return true;
}
Modified: trunk/Source/WebKit/chromium/tests/WebFrameTest.cpp (127493 => 127494)
--- trunk/Source/WebKit/chromium/tests/WebFrameTest.cpp 2012-09-04 20:22:16 UTC (rev 127493)
+++ trunk/Source/WebKit/chromium/tests/WebFrameTest.cpp 2012-09-04 20:25:47 UTC (rev 127494)
@@ -1080,7 +1080,7 @@
class DisambiguationPopupTestWebViewClient : public WebViewClient {
public:
-virtual bool handleDisambiguationPopup(const WebGestureEvent, const WebVectorWebRect targetRects) OVERRIDE
+virtual bool didTapMultipleTargets(const WebGestureEvent, const WebVectorWebRect targetRects) OVERRIDE
{
EXPECT_GE(targetRects.size(), 2u);
m_triggered = true;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [127495] trunk/Source/WebCore
Title: [127495] trunk/Source/WebCore
Revision 127495
Author dominik.rottsc...@intel.com
Date 2012-09-04 13:30:09 -0700 (Tue, 04 Sep 2012)
Log Message
ResourceErrorBase needs to identify timeouts
https://bugs.webkit.org/show_bug.cgi?id=95755
Reviewed by Alexey Proskuryakov.
Adding a property to check whether this ResourceError was raised due to a timeout.
This is preparatory work for bug 74802. In order to implement XHR2 timeout functionality,
I need to identify some layers up whether the original network problem has been a timeout.
No new tests, no change in behavior yet.
* platform/network/ResourceErrorBase.cpp:
(WebCore::ResourceErrorBase::copy): Copying new member.
(WebCore::ResourceErrorBase::compare): Comparing new member.
* platform/network/ResourceErrorBase.h:
(WebCore::ResourceErrorBase::setIsTimeout): New setter.
(WebCore::ResourceErrorBase::isTimeout): New getter.
(ResourceErrorBase),
(WebCore::ResourceErrorBase::ResourceErrorBase): Adding m_isTimeout member.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/network/ResourceErrorBase.cpp
trunk/Source/WebCore/platform/network/ResourceErrorBase.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (127494 => 127495)
--- trunk/Source/WebCore/ChangeLog 2012-09-04 20:25:47 UTC (rev 127494)
+++ trunk/Source/WebCore/ChangeLog 2012-09-04 20:30:09 UTC (rev 127495)
@@ -1,3 +1,25 @@
+2012-09-04 Dominik Röttsches dominik.rottsc...@intel.com
+
+ResourceErrorBase needs to identify timeouts
+https://bugs.webkit.org/show_bug.cgi?id=95755
+
+Reviewed by Alexey Proskuryakov.
+
+Adding a property to check whether this ResourceError was raised due to a timeout.
+This is preparatory work for bug 74802. In order to implement XHR2 timeout functionality,
+I need to identify some layers up whether the original network problem has been a timeout.
+
+No new tests, no change in behavior yet.
+
+* platform/network/ResourceErrorBase.cpp:
+(WebCore::ResourceErrorBase::copy): Copying new member.
+(WebCore::ResourceErrorBase::compare): Comparing new member.
+* platform/network/ResourceErrorBase.h:
+(WebCore::ResourceErrorBase::setIsTimeout): New setter.
+(WebCore::ResourceErrorBase::isTimeout): New getter.
+(ResourceErrorBase),
+(WebCore::ResourceErrorBase::ResourceErrorBase): Adding m_isTimeout member.
+
2012-09-04 Tommy Widenflycht tom...@google.com
MediaStream API: Change the MediaStreamTrackList track added/removed signaling
Modified: trunk/Source/WebCore/platform/network/ResourceErrorBase.cpp (127494 => 127495)
--- trunk/Source/WebCore/platform/network/ResourceErrorBase.cpp 2012-09-04 20:25:47 UTC (rev 127494)
+++ trunk/Source/WebCore/platform/network/ResourceErrorBase.cpp 2012-09-04 20:30:09 UTC (rev 127495)
@@ -42,6 +42,7 @@
errorCopy.m_localizedDescription = m_localizedDescription.isolatedCopy();
errorCopy.m_isNull = m_isNull;
errorCopy.m_isCancellation = m_isCancellation;
+errorCopy.m_isTimeout = m_isTimeout;
platformCopy(errorCopy);
return errorCopy;
}
@@ -74,6 +75,9 @@
if (a.isCancellation() != b.isCancellation())
return false;
+if (a.isTimeout() != b.isTimeout())
+return false;
+
return platformCompare(a, b);
}
Modified: trunk/Source/WebCore/platform/network/ResourceErrorBase.h (127494 => 127495)
--- trunk/Source/WebCore/platform/network/ResourceErrorBase.h 2012-09-04 20:25:47 UTC (rev 127494)
+++ trunk/Source/WebCore/platform/network/ResourceErrorBase.h 2012-09-04 20:30:09 UTC (rev 127495)
@@ -49,6 +49,9 @@
void setIsCancellation(bool isCancellation) { m_isCancellation = isCancellation; }
bool isCancellation() const { return m_isCancellation; }
+void setIsTimeout(bool isTimeout) { m_isTimeout = isTimeout; }
+bool isTimeout() const { return m_isTimeout; }
+
static bool compare(const ResourceError, const ResourceError);
protected:
@@ -56,6 +59,7 @@
: m_errorCode(0)
, m_isNull(true)
, m_isCancellation(false)
+, m_isTimeout(false)
{
}
@@ -66,6 +70,7 @@
, m_localizedDescription(localizedDescription)
, m_isNull(false)
, m_isCancellation(false)
+, m_isTimeout(false)
{
}
@@ -86,6 +91,7 @@
String m_localizedDescription;
bool m_isNull;
bool m_isCancellation;
+bool m_isTimeout;
};
inline bool operator==(const ResourceError a, const ResourceError b) { return ResourceErrorBase::compare(a, b); }
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [127496] branches/safari-536.26-branch/Source/WebKit2
Title: [127496] branches/safari-536.26-branch/Source/WebKit2
Revision 127496
Author lforsch...@apple.com
Date 2012-09-04 13:30:38 -0700 (Tue, 04 Sep 2012)
Log Message
Rollout r127276.
Modified Paths
branches/safari-536.26-branch/Source/WebKit2/ChangeLog
branches/safari-536.26-branch/Source/WebKit2/WebProcess/Plugins/PluginView.cpp
Diff
Modified: branches/safari-536.26-branch/Source/WebKit2/ChangeLog (127495 => 127496)
--- branches/safari-536.26-branch/Source/WebKit2/ChangeLog 2012-09-04 20:30:09 UTC (rev 127495)
+++ branches/safari-536.26-branch/Source/WebKit2/ChangeLog 2012-09-04 20:30:38 UTC (rev 127496)
@@ -1,3 +1,36 @@
+2012-09-04 Lucas Forschler lforsch...@apple.com
+
+Rollout r127276.
+
+2012-08-31 Timothy Hatcher timo...@apple.com
+
+Merge r127047.
+
+2012-08-29 Brady Eidson beid...@apple.com
+
+REGRESSION: Not sending NPP_SetWindow is causing Flash to not throttle itself
+rdar://problem/12133021 and https://bugs.webkit.org/show_bug.cgi?id=95274
+
+Reviewed by Sam Weinig.
+
+* UIProcess/API/mac/WKView.mm:
+(-[WKView viewDidMoveToWindow]): Previously we'd only update window visibility when the window is hidden.
+ Now we also update window visibility when the window is shown.
+
+* WebProcess/Plugins/Netscape/NetscapePlugin.cpp:
+(WebKit::NetscapePlugin::callSetWindowInvisible): Call set window with a manufactured empty clip rect to tell
+ the plug-in that it is complete hidden.
+(WebKit):
+* WebProcess/Plugins/Netscape/NetscapePlugin.h:
+(NetscapePlugin):
+* WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm:
+(WebKit::NetscapePlugin::windowVisibilityChanged): Call callSetWindow or callSetWindowInvisible as appropriate.
+
+* WebProcess/Plugins/PluginView.cpp:
+(WebKit::PluginView::setWindowIsVisible): Tell the plugin that its visibility changed.
+(WebKit::PluginView::viewGeometryDidChange): Grab a clip rect that - although incorrect - at least is correct if
+ the PluginView is completely hidden.
+
2012-08-14 Lucas Forschler lforsch...@apple.com
Rollout 127322.
Modified: branches/safari-536.26-branch/Source/WebKit2/WebProcess/Plugins/PluginView.cpp (127495 => 127496)
--- branches/safari-536.26-branch/Source/WebKit2/WebProcess/Plugins/PluginView.cpp 2012-09-04 20:30:09 UTC (rev 127495)
+++ branches/safari-536.26-branch/Source/WebKit2/WebProcess/Plugins/PluginView.cpp 2012-09-04 20:30:38 UTC (rev 127496)
@@ -401,7 +401,7 @@
#if PLATFORM(MAC)
void PluginView::setWindowIsVisible(bool windowIsVisible)
{
-if (!m_isInitialized || !m_plugin)
+if (!m_plugin)
return;
m_plugin-windowVisibilityChanged(windowIsVisible);
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [127497] trunk
Title: [127497] trunk
Revision 127497
Author simon.fra...@apple.com
Date 2012-09-04 13:34:01 -0700 (Tue, 04 Sep 2012)
Log Message
Regression: Heap-use-after-free in WebCore::FrameView::scrollContentsFastPath
https://bugs.webkit.org/show_bug.cgi?id=95754
Reviewed by Dave Hyatt.
Source/WebCore:
It's possible to have a renderer with position:fixed or sticky style,
but no layer, for example a RenderScrollBarPart. Don't register such
renderers with the FrameView.
Moved the code that registers/unregisters with the FrameView from
styleWillChange() to styleDidChange(), since in the latter case
we can check if we have a RenderLayer. Only register renderers with layers.
We always unregister, which required removing an assertion in
FrameView::removeFixedObject(), and replacing it with a null check of m_fixedObjects.
Test: fast/css/remove-fixed-resizer-crash.html
* page/FrameView.cpp:
(WebCore::FrameView::removeFixedObject):
* rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::styleWillChange):
(WebCore::RenderBoxModelObject::styleDidChange):
LayoutTests:
Testcase with a position:fixed resizer and scrolling.
* fast/css/remove-fixed-resizer-crash-expected.txt: Added.
* fast/css/remove-fixed-resizer-crash.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/FrameView.cpp
trunk/Source/WebCore/rendering/RenderBoxModelObject.cpp
Added Paths
trunk/LayoutTests/fast/css/remove-fixed-resizer-crash-expected.txt
trunk/LayoutTests/fast/css/remove-fixed-resizer-crash.html
Diff
Modified: trunk/LayoutTests/ChangeLog (127496 => 127497)
--- trunk/LayoutTests/ChangeLog 2012-09-04 20:30:38 UTC (rev 127496)
+++ trunk/LayoutTests/ChangeLog 2012-09-04 20:34:01 UTC (rev 127497)
@@ -1,3 +1,15 @@
+2012-09-04 Simon Fraser simon.fra...@apple.com
+
+Regression: Heap-use-after-free in WebCore::FrameView::scrollContentsFastPath
+https://bugs.webkit.org/show_bug.cgi?id=95754
+
+Reviewed by Dave Hyatt.
+
+Testcase with a position:fixed resizer and scrolling.
+
+* fast/css/remove-fixed-resizer-crash-expected.txt: Added.
+* fast/css/remove-fixed-resizer-crash.html: Added.
+
2012-09-04 Roger Fong roger_f...@apple.com
Unreviewed. Removing accidentally added executable properties on test files.
Added: trunk/LayoutTests/fast/css/remove-fixed-resizer-crash-expected.txt (0 => 127497)
--- trunk/LayoutTests/fast/css/remove-fixed-resizer-crash-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/css/remove-fixed-resizer-crash-expected.txt 2012-09-04 20:34:01 UTC (rev 127497)
@@ -0,0 +1,3 @@
+This test should not crash
+
+
Property changes on: trunk/LayoutTests/fast/css/remove-fixed-resizer-crash-expected.txt
___
Added: svn:mime-type
Added: svn:keywords
Added: svn:eol-style
Added: trunk/LayoutTests/fast/css/remove-fixed-resizer-crash.html (0 => 127497)
--- trunk/LayoutTests/fast/css/remove-fixed-resizer-crash.html (rev 0)
+++ trunk/LayoutTests/fast/css/remove-fixed-resizer-crash.html 2012-09-04 20:34:01 UTC (rev 127497)
@@ -0,0 +1,28 @@
+!DOCTYPE html
+html
+head
+style
+body {
+height: 2000px;
+}
+
+*::-webkit-resizer { position: fixed; }
+/style
+script
+if (window.testRunner)
+testRunner.dumpAsText();
+
+function doTest()
+{
+var svgElement = document.createElementNS(http://www.w3.org/2000/svg, svg);
+document.body.appendChild(svgElement);
+window.scrollBy(0, 100);
+}
+window.addEventListener('load', doTest, false);
+/script
+/head
+body
+pThis test should not crash/p
+input
+/body
+/html
Property changes on: trunk/LayoutTests/fast/css/remove-fixed-resizer-crash.html
___
Added: svn:mime-type
Added: svn:keywords
Added: svn:eol-style
Modified: trunk/Source/WebCore/ChangeLog (127496 => 127497)
--- trunk/Source/WebCore/ChangeLog 2012-09-04 20:30:38 UTC (rev 127496)
+++ trunk/Source/WebCore/ChangeLog 2012-09-04 20:34:01 UTC (rev 127497)
@@ -1,3 +1,28 @@
+2012-09-04 Simon Fraser simon.fra...@apple.com
+
+Regression: Heap-use-after-free in WebCore::FrameView::scrollContentsFastPath
+https://bugs.webkit.org/show_bug.cgi?id=95754
+
+Reviewed by Dave Hyatt.
+
+It's possible to have a renderer with position:fixed or sticky style,
+but no layer, for example a RenderScrollBarPart. Don't register such
+renderers with the FrameView.
+
+Moved the code that registers/unregisters with the FrameView from
+styleWillChange() to styleDidChange(), since in the latter case
+we can check if we have a RenderLayer. Only register renderers with layers.
+We always unregister, which required removing an assertion in
+FrameView::removeFixedObject(), and
[webkit-changes] [127498] branches/safari-536.26-branch
Title: [127498] branches/safari-536.26-branch
Revision 127498
Author lforsch...@apple.com
Date 2012-09-04 13:35:10 -0700 (Tue, 04 Sep 2012)
Log Message
Rollout 127252.
Modified Paths
branches/safari-536.26-branch/LayoutTests/ChangeLog
branches/safari-536.26-branch/Source/WebKit2/ChangeLog
branches/safari-536.26-branch/Source/WebKit2/UIProcess/API/mac/WKView.mm
branches/safari-536.26-branch/Source/WebKit2/WebProcess/Plugins/Netscape/NetscapePlugin.cpp
branches/safari-536.26-branch/Source/WebKit2/WebProcess/Plugins/Netscape/NetscapePlugin.h
branches/safari-536.26-branch/Source/WebKit2/WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm
branches/safari-536.26-branch/Source/WebKit2/WebProcess/Plugins/PluginView.cpp
branches/safari-536.26-branch/Tools/ChangeLog
branches/safari-536.26-branch/Tools/DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj
Removed Paths
branches/safari-536.26-branch/LayoutTests/platform/mac-wk2/plugins/npp-setwindow-called-on-scroll-expected.txt
branches/safari-536.26-branch/Tools/DumpRenderTree/TestNetscapePlugIn/Tests/LogNPPSetWindow.cpp
Diff
Modified: branches/safari-536.26-branch/LayoutTests/ChangeLog (127497 => 127498)
--- branches/safari-536.26-branch/LayoutTests/ChangeLog 2012-09-04 20:34:01 UTC (rev 127497)
+++ branches/safari-536.26-branch/LayoutTests/ChangeLog 2012-09-04 20:35:10 UTC (rev 127498)
@@ -1,3 +1,7 @@
+2012-09-04 Lucas Forschler lforsch...@apple.com
+
+Rollout r127252.
+
2012-08-31 Brady Eidson beid...@apple.com
Rename testRunner to layoutTestController for a test on the branch.
Deleted: branches/safari-536.26-branch/LayoutTests/platform/mac-wk2/plugins/npp-setwindow-called-on-scroll-expected.txt (127497 => 127498)
--- branches/safari-536.26-branch/LayoutTests/platform/mac-wk2/plugins/npp-setwindow-called-on-scroll-expected.txt 2012-09-04 20:34:01 UTC (rev 127497)
+++ branches/safari-536.26-branch/LayoutTests/platform/mac-wk2/plugins/npp-setwindow-called-on-scroll-expected.txt 2012-09-04 20:35:10 UTC (rev 127498)
@@ -1,15 +0,0 @@
-a div
-
-another div
-Tests that netscape plugins get appropriate calls to NPP_SetWindow when scrolled out of view or back in to view.
-
-On success, you will see a series of PASS messages, followed by TEST COMPLETE.
-
-
-PASS NPP_SetWindow called with expected parameters
-PASS NPP_SetWindow called with expected parameters
-PASS NPP_SetWindow called with expected parameters
-PASS NPP_SetWindow called with expected parameters
-PASS NPP_SetWindow called with expected parameters
-PASS NPP_SetWindow called with expected parameters
-
Modified: branches/safari-536.26-branch/Source/WebKit2/ChangeLog (127497 => 127498)
--- branches/safari-536.26-branch/Source/WebKit2/ChangeLog 2012-09-04 20:34:01 UTC (rev 127497)
+++ branches/safari-536.26-branch/Source/WebKit2/ChangeLog 2012-09-04 20:35:10 UTC (rev 127498)
@@ -1,5 +1,9 @@
2012-09-04 Lucas Forschler lforsch...@apple.com
+Rollout r127252.
+
+2012-09-04 Lucas Forschler lforsch...@apple.com
+
Rollout r127276.
2012-08-31 Timothy Hatcher timo...@apple.com
Modified: branches/safari-536.26-branch/Source/WebKit2/UIProcess/API/mac/WKView.mm (127497 => 127498)
--- branches/safari-536.26-branch/Source/WebKit2/UIProcess/API/mac/WKView.mm 2012-09-04 20:34:01 UTC (rev 127497)
+++ branches/safari-536.26-branch/Source/WebKit2/UIProcess/API/mac/WKView.mm 2012-09-04 20:35:10 UTC (rev 127498)
@@ -1918,7 +1918,6 @@
[self _accessibilityRegisterUIProcessTokens];
} else {
-[self _updateWindowVisibility];
_data-_page-viewStateDidChange(WebPageProxy::ViewIsVisible);
_data-_page-viewStateDidChange(WebPageProxy::ViewWindowIsActive | WebPageProxy::ViewIsInWindow);
Modified: branches/safari-536.26-branch/Source/WebKit2/WebProcess/Plugins/Netscape/NetscapePlugin.cpp (127497 => 127498)
--- branches/safari-536.26-branch/Source/WebKit2/WebProcess/Plugins/Netscape/NetscapePlugin.cpp 2012-09-04 20:34:01 UTC (rev 127497)
+++ branches/safari-536.26-branch/Source/WebKit2/WebProcess/Plugins/Netscape/NetscapePlugin.cpp 2012-09-04 20:35:10 UTC (rev 127498)
@@ -508,20 +508,6 @@
m_hasCalledSetWindow = true;
}
-void NetscapePlugin::callSetWindowInvisible()
-{
-NPWindow invisibleWindow = m_npWindow;
-
-invisibleWindow.window = 0;
-invisibleWindow.clipRect.top = 0;
-invisibleWindow.clipRect.left = 0;
-invisibleWindow.clipRect.bottom = 0;
-invisibleWindow.clipRect.right = 0;
-
-NPP_SetWindow(invisibleWindow);
-m_hasCalledSetWindow = true;
-}
-
bool NetscapePlugin::shouldLoadSrcURL()
{
// Check if we should cancel the load
Modified: branches/safari-536.26-branch/Source/WebKit2/WebProcess/Plugins/Netscape/NetscapePlugin.h (127497 => 127498)
--- branches/safari-536.26-branch/Source/WebKit2/WebProcess/Plugins/Netscape/NetscapePlugin.h 2012-09-04 20:34:01 UTC (rev 127497)
+++ branches/safari-536.26-branch/Source/WebKit2/WebProcess/Plugins/Netscape/NetscapePlugin.h
[webkit-changes] [127499] tags/Safari-536.26.12/
Title: [127499] tags/Safari-536.26.12/ Revision 127499 Author lforsch...@apple.com Date 2012-09-04 13:41:28 -0700 (Tue, 04 Sep 2012) Log Message New Tag. Added Paths tags/Safari-536.26.12/ Diff Property changes: tags/Safari-536.26.12 Added: svn:ignore depcomp compile config.guess GNUmakefile.in config.sub ltmain.sh aconfig.h.in autom4te.cache missing aclocal.m4 install-sh autotoolsconfig.h.in INSTALL README gtk-doc.make out Makefile.chromium WebKitSupportLibrary.zip WebKitBuild Added: svn:mergeinfo ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [127502] trunk/Source
Title: [127502] trunk/Source
Revision 127502
Author toniki...@webkit.org
Date 2012-09-04 14:10:32 -0700 (Tue, 04 Sep 2012)
Log Message
[BlackBerry] Use child/ScrollableContent layer's position instead of parent/ScrollLayer's boundsOrigin
https://bugs.webkit.org/show_bug.cgi?id=95778
PR #202252
Reviewed by Rob Buis.
Patch by Antonio Gomes ago...@rim.com
Internally reviewed by Arvid Nilsson.
Upstream has switch away from using the parent scroll layer's bounds origin
in order to translate contents of all its child layers. Instead now, it directly
sets the scroll position of the child scrollable contents layer.
Source/WebCore:
No new tests, since it is a catch-up with upstreaming code.
Source/WebCore:
* platform/graphics/blackberry/GraphicsLayerBlackBerry.cpp:
(WebCore):
* platform/graphics/blackberry/GraphicsLayerBlackBerry.h:
(GraphicsLayerBlackBerry):
* platform/graphics/blackberry/LayerCompositingThread.cpp:
(WebCore::LayerCompositingThread::updateAnimations):
* platform/graphics/blackberry/LayerCompositingThread.h:
(WebCore::LayerOverride::LayerOverride):
(LayerOverride):
* platform/graphics/blackberry/LayerData.h:
(LayerData):
* platform/graphics/blackberry/LayerRenderer.cpp:
(WebCore::LayerRenderer::updateLayersRecursive):
* platform/graphics/blackberry/LayerWebKitThread.h:
* rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):
Source/WebKit/blackberry:
Source/WebKit/blackberry:
* Api/InRegionScroller.cpp:
(BlackBerry::WebKit::InRegionScrollerPrivate::setScrollPositionCompositingThread):
* WebKitSupport/InRegionScrollableArea.cpp:
(BlackBerry::WebKit::InRegionScrollableArea::InRegionScrollableArea):
No new tests, since it is a catch-up with upstreaming code.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/blackberry/GraphicsLayerBlackBerry.cpp
trunk/Source/WebCore/platform/graphics/blackberry/GraphicsLayerBlackBerry.h
trunk/Source/WebCore/platform/graphics/blackberry/LayerCompositingThread.cpp
trunk/Source/WebCore/platform/graphics/blackberry/LayerCompositingThread.h
trunk/Source/WebCore/platform/graphics/blackberry/LayerData.h
trunk/Source/WebCore/platform/graphics/blackberry/LayerRenderer.cpp
trunk/Source/WebCore/platform/graphics/blackberry/LayerWebKitThread.h
trunk/Source/WebCore/rendering/RenderLayerBacking.cpp
trunk/Source/WebKit/blackberry/Api/InRegionScroller.cpp
trunk/Source/WebKit/blackberry/ChangeLog
trunk/Source/WebKit/blackberry/WebKitSupport/InRegionScrollableArea.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (127501 => 127502)
--- trunk/Source/WebCore/ChangeLog 2012-09-04 21:02:07 UTC (rev 127501)
+++ trunk/Source/WebCore/ChangeLog 2012-09-04 21:10:32 UTC (rev 127502)
@@ -1,3 +1,36 @@
+2012-09-04 Antonio Gomes ago...@rim.com
+
+[BlackBerry] Use child/ScrollableContent layer's position instead of parent/ScrollLayer's boundsOrigin
+https://bugs.webkit.org/show_bug.cgi?id=95778
+PR #202252
+
+Reviewed by Rob Buis.
+Internally reviewed by Arvid Nilsson.
+
+Upstream has switch away from using the parent scroll layer's bounds origin
+in order to translate contents of all its child layers. Instead now, it directly
+sets the scroll position of the child scrollable contents layer.
+
+No new tests, since it is a catch-up with upstreaming code.
+
+Source/WebCore:
+* platform/graphics/blackberry/GraphicsLayerBlackBerry.cpp:
+(WebCore):
+* platform/graphics/blackberry/GraphicsLayerBlackBerry.h:
+(GraphicsLayerBlackBerry):
+* platform/graphics/blackberry/LayerCompositingThread.cpp:
+(WebCore::LayerCompositingThread::updateAnimations):
+* platform/graphics/blackberry/LayerCompositingThread.h:
+(WebCore::LayerOverride::LayerOverride):
+(LayerOverride):
+* platform/graphics/blackberry/LayerData.h:
+(LayerData):
+* platform/graphics/blackberry/LayerRenderer.cpp:
+(WebCore::LayerRenderer::updateLayersRecursive):
+* platform/graphics/blackberry/LayerWebKitThread.h:
+* rendering/RenderLayerBacking.cpp:
+(WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):
+
2012-09-04 Tommy Widenflycht tom...@google.com
MediaStream API: Add the async createOffer functionality to RTCPeerConnection
Modified: trunk/Source/WebCore/platform/graphics/blackberry/GraphicsLayerBlackBerry.cpp (127501 => 127502)
--- trunk/Source/WebCore/platform/graphics/blackberry/GraphicsLayerBlackBerry.cpp 2012-09-04 21:02:07 UTC (rev 127501)
+++ trunk/Source/WebCore/platform/graphics/blackberry/GraphicsLayerBlackBerry.cpp 2012-09-04 21:10:32 UTC (rev 127502)
@@ -319,16 +319,6 @@
}
#endif
-void GraphicsLayerBlackBerry::setBoundsOrigin(const FloatPoint origin)
-{
-if (origin == m_boundsOrigin)
-return;
-
-GraphicsLayer::setBoundsOrigin(origin);
-updateBoundsOrigin();
-
-}
-
void
[webkit-changes] [127503] trunk/Source/JavaScriptCore
Title: [127503] trunk/Source/_javascript_Core
Revision 127503
Author fpi...@apple.com
Date 2012-09-04 14:15:02 -0700 (Tue, 04 Sep 2012)
Log Message
DFG GetByVal for JSArrays shouldn't OSR exit every time that the index is out of bound
https://bugs.webkit.org/show_bug.cgi?id=95717
Reviewed by Oliver Hunt.
Make GetByVal for JSArrayOutOfBounds do meaningful things. The profiling was already
there so we should just use it!
* bytecode/DFGExitProfile.h:
(JSC::DFG::exitKindToString):
* dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::execute):
* dfg/DFGOperations.cpp:
* dfg/DFGOperations.h:
* dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::callOperation):
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/bytecode/DFGExitProfile.h
trunk/Source/_javascript_Core/dfg/DFGAbstractState.cpp
trunk/Source/_javascript_Core/dfg/DFGOperations.cpp
trunk/Source/_javascript_Core/dfg/DFGOperations.h
trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.h
trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT32_64.cpp
trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT64.cpp
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (127502 => 127503)
--- trunk/Source/_javascript_Core/ChangeLog 2012-09-04 21:10:32 UTC (rev 127502)
+++ trunk/Source/_javascript_Core/ChangeLog 2012-09-04 21:15:02 UTC (rev 127503)
@@ -1,3 +1,26 @@
+2012-09-04 Filip Pizlo fpi...@apple.com
+
+DFG GetByVal for JSArrays shouldn't OSR exit every time that the index is out of bound
+https://bugs.webkit.org/show_bug.cgi?id=95717
+
+Reviewed by Oliver Hunt.
+
+Make GetByVal for JSArrayOutOfBounds do meaningful things. The profiling was already
+there so we should just use it!
+
+* bytecode/DFGExitProfile.h:
+(JSC::DFG::exitKindToString):
+* dfg/DFGAbstractState.cpp:
+(JSC::DFG::AbstractState::execute):
+* dfg/DFGOperations.cpp:
+* dfg/DFGOperations.h:
+* dfg/DFGSpeculativeJIT.h:
+(JSC::DFG::SpeculativeJIT::callOperation):
+* dfg/DFGSpeculativeJIT32_64.cpp:
+(JSC::DFG::SpeculativeJIT::compile):
+* dfg/DFGSpeculativeJIT64.cpp:
+(JSC::DFG::SpeculativeJIT::compile):
+
2012-09-04 Zoltan Horvath zol...@webkit.org
Extend the coverage of the Custom Allocation Framework in WTF and in _javascript_Core
Modified: trunk/Source/_javascript_Core/bytecode/DFGExitProfile.h (127502 => 127503)
--- trunk/Source/_javascript_Core/bytecode/DFGExitProfile.h 2012-09-04 21:10:32 UTC (rev 127502)
+++ trunk/Source/_javascript_Core/bytecode/DFGExitProfile.h 2012-09-04 21:15:02 UTC (rev 127503)
@@ -58,6 +58,8 @@
return Overflow;
case NegativeZero:
return NegativeZero;
+case OutOfBounds:
+return OutOfBounds;
case InadequateCoverage:
return InadequateCoverage;
case ArgumentsEscaped:
Modified: trunk/Source/_javascript_Core/dfg/DFGAbstractState.cpp (127502 => 127503)
--- trunk/Source/_javascript_Core/dfg/DFGAbstractState.cpp 2012-09-04 21:10:32 UTC (rev 127502)
+++ trunk/Source/_javascript_Core/dfg/DFGAbstractState.cpp 2012-09-04 21:15:02 UTC (rev 127503)
@@ -853,10 +853,12 @@
forNode(nodeIndex).makeTop();
break;
case Array::JSArray:
+forNode(node.child2()).filter(SpecInt32);
+forNode(nodeIndex).makeTop();
+break;
case Array::JSArrayOutOfBounds:
-// FIXME: We should have more conservative handling of the out-of-bounds
-// case.
forNode(node.child2()).filter(SpecInt32);
+clobberWorld(node.codeOrigin, indexInBlock);
forNode(nodeIndex).makeTop();
break;
case Array::Int8Array:
Modified: trunk/Source/_javascript_Core/dfg/DFGOperations.cpp (127502 => 127503)
--- trunk/Source/_javascript_Core/dfg/DFGOperations.cpp 2012-09-04 21:10:32 UTC (rev 127502)
+++ trunk/Source/_javascript_Core/dfg/DFGOperations.cpp 2012-09-04 21:15:02 UTC (rev 127503)
@@ -409,6 +409,15 @@
return JSValue::encode(JSValue(base).get(exec, ident));
}
+EncodedJSValue DFG_OPERATION operationGetByValArrayInt(ExecState* exec, JSArray* base, int32_t index)
+{
+JSGlobalData* globalData = exec-globalData();
+NativeCallFrameTracer tracer(globalData, exec);
+
+// Use this since we know that the value is out of bounds.
+return JSValue::encode(JSValue(base).get(exec, index));
+}
+
EncodedJSValue DFG_OPERATION operationGetById(ExecState* exec, EncodedJSValue base, Identifier* propertyName)
{
JSGlobalData* globalData = exec-globalData();
Modified: trunk/Source/_javascript_Core/dfg/DFGOperations.h (127502 => 127503)
--- trunk/Source/_javascript_Core/dfg/DFGOperations.h 2012-09-04 21:10:32 UTC (rev 127502)
+++
[webkit-changes] [127504] branches/safari-536.26-branch/Source
Title: [127504] branches/safari-536.26-branch/Source Revision 127504 Author lforsch...@apple.com Date 2012-09-04 14:16:22 -0700 (Tue, 04 Sep 2012) Log Message Versioning. Modified Paths branches/safari-536.26-branch/Source/_javascript_Core/Configurations/Version.xcconfig branches/safari-536.26-branch/Source/WebCore/Configurations/Version.xcconfig branches/safari-536.26-branch/Source/WebKit/mac/Configurations/Version.xcconfig branches/safari-536.26-branch/Source/WebKit2/Configurations/Version.xcconfig Diff Modified: branches/safari-536.26-branch/Source/_javascript_Core/Configurations/Version.xcconfig (127503 => 127504) --- branches/safari-536.26-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2012-09-04 21:15:02 UTC (rev 127503) +++ branches/safari-536.26-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2012-09-04 21:16:22 UTC (rev 127504) @@ -23,7 +23,7 @@ MAJOR_VERSION = 536; MINOR_VERSION = 26; -TINY_VERSION = 12; +TINY_VERSION = 13; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-536.26-branch/Source/WebCore/Configurations/Version.xcconfig (127503 => 127504) --- branches/safari-536.26-branch/Source/WebCore/Configurations/Version.xcconfig 2012-09-04 21:15:02 UTC (rev 127503) +++ branches/safari-536.26-branch/Source/WebCore/Configurations/Version.xcconfig 2012-09-04 21:16:22 UTC (rev 127504) @@ -23,7 +23,7 @@ MAJOR_VERSION = 536; MINOR_VERSION = 26; -TINY_VERSION = 12; +TINY_VERSION = 13; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-536.26-branch/Source/WebKit/mac/Configurations/Version.xcconfig (127503 => 127504) --- branches/safari-536.26-branch/Source/WebKit/mac/Configurations/Version.xcconfig 2012-09-04 21:15:02 UTC (rev 127503) +++ branches/safari-536.26-branch/Source/WebKit/mac/Configurations/Version.xcconfig 2012-09-04 21:16:22 UTC (rev 127504) @@ -23,7 +23,7 @@ MAJOR_VERSION = 536; MINOR_VERSION = 26; -TINY_VERSION = 12; +TINY_VERSION = 13; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-536.26-branch/Source/WebKit2/Configurations/Version.xcconfig (127503 => 127504) --- branches/safari-536.26-branch/Source/WebKit2/Configurations/Version.xcconfig 2012-09-04 21:15:02 UTC (rev 127503) +++ branches/safari-536.26-branch/Source/WebKit2/Configurations/Version.xcconfig 2012-09-04 21:16:22 UTC (rev 127504) @@ -23,7 +23,7 @@ MAJOR_VERSION = 536; MINOR_VERSION = 26; -TINY_VERSION = 12; +TINY_VERSION = 13; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [127506] trunk/LayoutTests
Title: [127506] trunk/LayoutTests Revision 127506 Author roger_f...@apple.com Date 2012-09-04 14:21:50 -0700 (Tue, 04 Sep 2012) Log Message Unreviewed gardening. meda/video-controls-captions.html fails on Windows after it was introduced in http://trac.webkit.org/changeset/127035. https://bugs.webkit.org/show_bug.cgi?id=95428 * platform/win/Skipped: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/win/Skipped Diff Modified: trunk/LayoutTests/ChangeLog (127505 => 127506) --- trunk/LayoutTests/ChangeLog 2012-09-04 21:19:25 UTC (rev 127505) +++ trunk/LayoutTests/ChangeLog 2012-09-04 21:21:50 UTC (rev 127506) @@ -1,3 +1,10 @@ +2012-09-04 Roger Fong roger_f...@apple.com + +Unreviewed gardening. meda/video-controls-captions.html fails on Windows after it was introduced in http://trac.webkit.org/changeset/127035. +https://bugs.webkit.org/show_bug.cgi?id=95428 + +* platform/win/Skipped: + 2012-09-04 Tommy Widenflycht tom...@google.com MediaStream API: Add the async createOffer functionality to RTCPeerConnection Modified: trunk/LayoutTests/platform/win/Skipped (127505 => 127506) --- trunk/LayoutTests/platform/win/Skipped 2012-09-04 21:19:25 UTC (rev 127505) +++ trunk/LayoutTests/platform/win/Skipped 2012-09-04 21:21:50 UTC (rev 127506) @@ -2162,3 +2162,6 @@ # https://bugs.webkit.org/show_bug.cgi?id=95388 fast/css/nested-layers-with-hover.html + +# https://bugs.webkit.org/show_bug.cgi?id=95428 +media/video-controls-captions.html ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [127507] trunk/Tools
Title: [127507] trunk/Tools Revision 127507 Author sat...@chromium.org Date 2012-09-04 14:23:01 -0700 (Tue, 04 Sep 2012) Log Message Run git commands within the checkout directory https://bugs.webkit.org/show_bug.cgi?id=95742 Reviewed by Eric Seidel. git commands run from scm/git.py are sometimes run with cwd set to the checkout_root and other times with whatever directory was the default cwd. Instead all these should run with the checkout root set as the cwd (except where we explicitly need a different path) * Scripts/webkitpy/common/checkout/scm/git.py: (Git._run_git): (Git.find_checkout_root): (Git.discard_local_commits): (Git.local_commits): (Git.working_directory_is_clean): (Git.clean_working_directory): (Git.add_list): (Git.delete_list): (Git.exists): (Git._current_branch): (Git._changes_files_for_commit): (Git.revisions_changing_file): (Git.svn_revision): (Git._run_git_svn_find_rev): (Git.contents_at_revision): (Git.diff_for_file): (Git.show_head): (Git.committer_email_for_revision): (Git.apply_reverse_diff): (Git.revert_files): (Git.commit_with_message): (Git._commit_on_branch): (Git.svn_commit_log): (Git.last_svn_commit_log): (Git.svn_blame): (Git._branch_ref_exists): (Git.delete_branch): (Git.remote_merge_base): (Git.commit_locally_with_message): (Git.push_local_commits_to_server): (Git.commit_ids_from_commitish_arguments): (Git.commit_message_for_local_commit): (Git.files_changed_summary_for_commit): Modified Paths trunk/Tools/ChangeLog trunk/Tools/Scripts/webkitpy/common/checkout/scm/git.py Diff Modified: trunk/Tools/ChangeLog (127506 => 127507) --- trunk/Tools/ChangeLog 2012-09-04 21:21:50 UTC (rev 127506) +++ trunk/Tools/ChangeLog 2012-09-04 21:23:01 UTC (rev 127507) @@ -1,3 +1,50 @@ +2012-09-04 Satish Sampath sat...@chromium.org + +Run git commands within the checkout directory +https://bugs.webkit.org/show_bug.cgi?id=95742 + +Reviewed by Eric Seidel. + +git commands run from scm/git.py are sometimes run with cwd set to the +checkout_root and other times with whatever directory was the default cwd. +Instead all these should run with the checkout root set as the cwd +(except where we explicitly need a different path) + +* Scripts/webkitpy/common/checkout/scm/git.py: +(Git._run_git): +(Git.find_checkout_root): +(Git.discard_local_commits): +(Git.local_commits): +(Git.working_directory_is_clean): +(Git.clean_working_directory): +(Git.add_list): +(Git.delete_list): +(Git.exists): +(Git._current_branch): +(Git._changes_files_for_commit): +(Git.revisions_changing_file): +(Git.svn_revision): +(Git._run_git_svn_find_rev): +(Git.contents_at_revision): +(Git.diff_for_file): +(Git.show_head): +(Git.committer_email_for_revision): +(Git.apply_reverse_diff): +(Git.revert_files): +(Git.commit_with_message): +(Git._commit_on_branch): +(Git.svn_commit_log): +(Git.last_svn_commit_log): +(Git.svn_blame): +(Git._branch_ref_exists): +(Git.delete_branch): +(Git.remote_merge_base): +(Git.commit_locally_with_message): +(Git.push_local_commits_to_server): +(Git.commit_ids_from_commitish_arguments): +(Git.commit_message_for_local_commit): +(Git.files_changed_summary_for_commit): + 2012-09-04 Tommy Widenflycht tom...@google.com MediaStream API: Add the async createOffer functionality to RTCPeerConnection Modified: trunk/Tools/Scripts/webkitpy/common/checkout/scm/git.py (127506 => 127507) --- trunk/Tools/Scripts/webkitpy/common/checkout/scm/git.py 2012-09-04 21:21:50 UTC (rev 127506) +++ trunk/Tools/Scripts/webkitpy/common/checkout/scm/git.py 2012-09-04 21:23:01 UTC (rev 127507) @@ -98,6 +98,13 @@ webkit_dev_thread_url = https://lists.webkit.org/pipermail/webkit-dev/2010-December/015287.html log(Warning: This machine is 64-bit, but the git binary (%s) does not support 64-bit.\nInstall a 64-bit git for better performance, see:\n%s\n % (git_path, webkit_dev_thread_url)) +def _run_git(self, command_args, **kwargs): +full_command_args = [self.executable_name] + command_args +full_kwargs = kwargs +if not 'cwd' in full_kwargs: +full_kwargs['cwd'] = self.checkout_root +return self.run(full_command_args, **full_kwargs) + @classmethod def in_working_directory(cls, path, executive=None): try: @@ -109,7 +116,7 @@ def find_checkout_root(self, path): # git rev-parse --show-cdup would be another way to get to the root -checkout_root = self._executive.run_command([self.executable_name, 'rev-parse', '--show-toplevel'], cwd=(path or ./)).strip() +checkout_root = self._run_git(['rev-parse', '--show-toplevel'], cwd=(path or ./)).strip() if not
[webkit-changes] [127508] trunk
Title: [127508] trunk
Revision 127508
Author msab...@apple.com
Date 2012-09-04 14:32:19 -0700 (Tue, 04 Sep 2012)
Log Message
equal() in CSSParser.cpp should check the length of characters
https://bugs.webkit.org/show_bug.cgi?id=95706
Source/WebCore:
Reviewed by Abhishek Arya.
Pass the length of string literals to CSSParser static functions equal() and
equalIgnoringCase() so that checks won't access out of bounds memory.
Added test fast/css/crash-comparing-equal.html.
* css/CSSParser.cpp:
(WebCore::equal): Use template to retrieve the length of string literal.
(WebCore::equalIgnoringCase): Ditto.
(WebCore::CSSParser::parseDashboardRegions): Use const char[] instead of const char*
LayoutTests:
Added test from duplicate defect https://bugs.webkit.org/show_bug.cgi?id=95634.
Reviewed by Abhishek Arya.
* fast/css/crash-comparing-equal-expected.txt: Added.
* fast/css/crash-comparing-equal.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/CSSParser.cpp
Added Paths
trunk/LayoutTests/fast/css/crash-comparing-equal-expected.txt
trunk/LayoutTests/fast/css/crash-comparing-equal.html
Diff
Modified: trunk/LayoutTests/ChangeLog (127507 => 127508)
--- trunk/LayoutTests/ChangeLog 2012-09-04 21:23:01 UTC (rev 127507)
+++ trunk/LayoutTests/ChangeLog 2012-09-04 21:32:19 UTC (rev 127508)
@@ -1,3 +1,15 @@
+2012-09-04 Michael Saboff msab...@apple.com
+
+equal() in CSSParser.cpp should check the length of characters
+https://bugs.webkit.org/show_bug.cgi?id=95706
+
+Added test from duplicate defect https://bugs.webkit.org/show_bug.cgi?id=95634.
+
+Reviewed by Abhishek Arya.
+
+* fast/css/crash-comparing-equal-expected.txt: Added.
+* fast/css/crash-comparing-equal.html: Added.
+
2012-09-04 Roger Fong roger_f...@apple.com
Unreviewed gardening. meda/video-controls-captions.html fails on Windows after it was introduced in http://trac.webkit.org/changeset/127035.
Added: trunk/LayoutTests/fast/css/crash-comparing-equal-expected.txt (0 => 127508)
--- trunk/LayoutTests/fast/css/crash-comparing-equal-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/css/crash-comparing-equal-expected.txt 2012-09-04 21:32:19 UTC (rev 127508)
@@ -0,0 +1 @@
+This page shouldn't crash when parsing CSS - Bug 95706.
Added: trunk/LayoutTests/fast/css/crash-comparing-equal.html (0 => 127508)
--- trunk/LayoutTests/fast/css/crash-comparing-equal.html (rev 0)
+++ trunk/LayoutTests/fast/css/crash-comparing-equal.html 2012-09-04 21:32:19 UTC (rev 127508)
@@ -0,0 +1,15 @@
+html
+head
+script
+if (window.testRunner)
+testRunner.dumpAsText();
+/script
+style
+#parent {
+font: 20px/1 ahem;
+/style
+/head
+body
+This page shouldn't crash when parsing CSS - Bug 95706.
+/body
+/html
Modified: trunk/Source/WebCore/ChangeLog (127507 => 127508)
--- trunk/Source/WebCore/ChangeLog 2012-09-04 21:23:01 UTC (rev 127507)
+++ trunk/Source/WebCore/ChangeLog 2012-09-04 21:32:19 UTC (rev 127508)
@@ -1,3 +1,20 @@
+2012-09-04 Michael Saboff msab...@apple.com
+
+equal() in CSSParser.cpp should check the length of characters
+https://bugs.webkit.org/show_bug.cgi?id=95706
+
+Reviewed by Abhishek Arya.
+
+Pass the length of string literals to CSSParser static functions equal() and
+equalIgnoringCase() so that checks won't access out of bounds memory.
+
+Added test fast/css/crash-comparing-equal.html.
+
+* css/CSSParser.cpp:
+(WebCore::equal): Use template to retrieve the length of string literal.
+(WebCore::equalIgnoringCase): Ditto.
+(WebCore::CSSParser::parseDashboardRegions): Use const char[] instead of const char*
+
2012-09-04 Antonio Gomes ago...@rim.com
[BlackBerry] Use child/ScrollableContent layer's position instead of parent/ScrollLayer's boundsOrigin
Modified: trunk/Source/WebCore/css/CSSParser.cpp (127507 => 127508)
--- trunk/Source/WebCore/css/CSSParser.cpp 2012-09-04 21:23:01 UTC (rev 127507)
+++ trunk/Source/WebCore/css/CSSParser.cpp 2012-09-04 21:32:19 UTC (rev 127508)
@@ -156,14 +156,24 @@
static const unsigned INVALID_NUM_PARSED_PROPERTIES = UINT_MAX;
static const double MAX_SCALE = 100;
-static bool equal(const CSSParserString a, const char* b)
+template unsigned N
+static bool equal(const CSSParserString a, const char (b)[N])
{
-return a.is8Bit() ? WTF::equal(a.characters8(), reinterpret_castconst LChar*(b), a.length()) : WTF::equal(a.characters16(), reinterpret_castconst LChar*(b), a.length());
+unsigned length = N - 1; // Ignore the trailing null character
+if (a.length() != length)
+return false;
+
+return a.is8Bit() ? WTF::equal(a.characters8(), reinterpret_castconst LChar*(b), length) : WTF::equal(a.characters16(), reinterpret_castconst LChar*(b), length);
}
-static bool
[webkit-changes] [127509] trunk
Title: [127509] trunk
Revision 127509
Author rob...@webkit.org
Date 2012-09-04 14:35:11 -0700 (Tue, 04 Sep 2012)
Log Message
Regression(r127163): Heap-use-after-free in WebCore::RenderBoxModelObject::hasSelfPaintingLayer
https://bugs.webkit.org/show_bug.cgi?id=95632
Reviewed by Abhishek Arya.
Source/WebCore:
Don't add floats to the floating object set of blocks that avoid floats. There's no point in doing that
and they will never get cleared out during relayout.
Tests: fast/css/intruding-floats-crash.html
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::clearFloatsIfNeeded):
LayoutTests:
* fast/css/intruding-floats-crash-expected.txt: Added.
* fast/css/intruding-floats-crash.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderBlock.cpp
Added Paths
trunk/LayoutTests/fast/css/intruding-floats-crash-expected.txt
trunk/LayoutTests/fast/css/intruding-floats-crash.html
Diff
Modified: trunk/LayoutTests/ChangeLog (127508 => 127509)
--- trunk/LayoutTests/ChangeLog 2012-09-04 21:32:19 UTC (rev 127508)
+++ trunk/LayoutTests/ChangeLog 2012-09-04 21:35:11 UTC (rev 127509)
@@ -1,3 +1,13 @@
+2012-09-04 Robert Hogan rob...@webkit.org
+
+Regression(r127163): Heap-use-after-free in WebCore::RenderBoxModelObject::hasSelfPaintingLayer
+https://bugs.webkit.org/show_bug.cgi?id=95632
+
+Reviewed by Abhishek Arya.
+
+* fast/css/intruding-floats-crash-expected.txt: Added.
+* fast/css/intruding-floats-crash.html: Added.
+
2012-09-04 Michael Saboff msab...@apple.com
equal() in CSSParser.cpp should check the length of characters
Added: trunk/LayoutTests/fast/css/intruding-floats-crash-expected.txt (0 => 127509)
--- trunk/LayoutTests/fast/css/intruding-floats-crash-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/css/intruding-floats-crash-expected.txt 2012-09-04 21:35:11 UTC (rev 127509)
@@ -0,0 +1,2 @@
+Passes if it doesn't crash!
+
Added: trunk/LayoutTests/fast/css/intruding-floats-crash.html (0 => 127509)
--- trunk/LayoutTests/fast/css/intruding-floats-crash.html (rev 0)
+++ trunk/LayoutTests/fast/css/intruding-floats-crash.html 2012-09-04 21:35:11 UTC (rev 127509)
@@ -0,0 +1,65 @@
+html
+head
+style
+.c3 { text-decoration: inherit; border-style: dotted; }
+.c6:only-of-type { position: relative; content: url(data:text/plain,aaa); }
+.c6 + .c3 { display: table-row; float: right; }
+.c6[class^=c6] { overflow: auto; }
+.c7:nth-last-of-type(odd) { float: right; width: 100%; }
+.c7:nth-last-child(2n) { display: -wap-marquee; float: none; }
+.c7[class$=c7] { content: url(data:text/plain,aaa); }
+.c8 { display: compact; -webkit-column-count: 65536; }
+.c8:first-of-type { float: none; -webkit-column-span: all;}
+/style
+script
+if (window.testRunner) {
+testRunner.waitUntilDone();
+testRunner.dumpAsText();
+}
+
+var nodes = Array();
+
+function tryToCrash()
+{
+document.body.OffsetTop;
+setTimeout('testRunner.notifyDone();',10);
+}
+
+function boom() {
+try { nodes[8] = document.createElement('nav'); } catch(e) {}
+try { nodes[12] = document.createElement('ins'); } catch(e) {}
+try { nodes[48] = document.createElement('button'); } catch(e) {}
+try { document.documentElement.appendChild(nodes[48]); } catch(e) {}
+try { nodes[59] = document.createElement('sub'); } catch(e) {}
+try { nodes[59].setAttribute('class', 'c7'); } catch(e) {}
+try { document.documentElement.appendChild(nodes[59]); } catch(e) {}
+try { nodes[65] = document.createElement('b'); } catch(e) {}
+try { nodes[65].setAttribute('class', 'c6'); } catch(e) {}
+try { document.documentElement.appendChild(nodes[65]); } catch(e) {}
+try { nodes[66] = document.createElement('tbody'); } catch(e) {}
+try { nodes[66].setAttribute('class', 'c3'); } catch(e) {}
+try { document.documentElement.appendChild(nodes[66]); } catch(e) {}
+try { nodes[68] = document.createElement('button'); } catch(e) {}
+try { document.documentElement.appendChild(nodes[68]); } catch(e) {}
+try { nodes[77] = document.createElement('i'); } catch(e) {}
+try { document.documentElement.appendChild(nodes[77]); } catch(e) {}
+try { nodes[78] = document.createElement('aside'); } catch(e) {}
+try { document.documentElement.appendChild(nodes[78]); } catch(e) {}
+try { nodes[84] = document.createElement('nav'); } catch(e) {}
+try { nodes[84].setAttribute('class', 'c8'); } catch(e) {}
+try { nodes[86] = document.createElement('colgroup'); } catch(e) {}
+try { document.documentElement.appendChild(nodes[86]); } catch(e) {}
+setTimeout('try { nodes[12].appendChild(nodes[65]); } catch(e) {}', 5);
+setTimeout('try { nodes[8].appendChild(nodes[86]); } catch(e) {}', 4);
+setTimeout(try { nodes[68].setAttribute('class', 'c8'); } catch(e) {}, 2);
+setTimeout('try {
[webkit-changes] [127510] trunk/LayoutTests
Title: [127510] trunk/LayoutTests Revision 127510 Author wangxian...@chromium.org Date 2012-09-04 14:48:47 -0700 (Tue, 04 Sep 2012) Log Message Unreviewed. Update test expectations for Android. * platform/chromium-android/TestExpectations: * platform/chromium-android/compositing/layer-creation/overflow-scrolling-touch-expected.txt: * platform/chromium/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/TestExpectations trunk/LayoutTests/platform/chromium-android/TestExpectations trunk/LayoutTests/platform/chromium-android/compositing/layer-creation/overflow-scrolling-touch-expected.txt Diff Modified: trunk/LayoutTests/ChangeLog (127509 => 127510) --- trunk/LayoutTests/ChangeLog 2012-09-04 21:35:11 UTC (rev 127509) +++ trunk/LayoutTests/ChangeLog 2012-09-04 21:48:47 UTC (rev 127510) @@ -1,3 +1,11 @@ +2012-09-04 Xianzhu Wang wangxian...@chromium.org + +Unreviewed. Update test expectations for Android. + +* platform/chromium-android/TestExpectations: +* platform/chromium-android/compositing/layer-creation/overflow-scrolling-touch-expected.txt: +* platform/chromium/TestExpectations: + 2012-09-04 Robert Hogan rob...@webkit.org Regression(r127163): Heap-use-after-free in WebCore::RenderBoxModelObject::hasSelfPaintingLayer Modified: trunk/LayoutTests/platform/chromium/TestExpectations (127509 => 127510) --- trunk/LayoutTests/platform/chromium/TestExpectations 2012-09-04 21:35:11 UTC (rev 127509) +++ trunk/LayoutTests/platform/chromium/TestExpectations 2012-09-04 21:48:47 UTC (rev 127510) @@ -3298,7 +3298,8 @@ // Flaky. It also times out very frequently on Windows and Linux debug build. BUGWK90207 SLOW WIN DEBUG : fast/forms/select/select-state-restore.html = PASS TEXT -BUGWK90207 SLOW LINUX ANDROID DEBUG : fast/forms/select/select-state-restore.html = PASS TEXT +BUGWK90207 SLOW LINUX DEBUG : fast/forms/select/select-state-restore.html = PASS TEXT +BUGWK90207 ANDROID : fast/forms/select/select-state-restore.html = PASS TEXT TIMEOUT BUGWK90207 WIN RELEASE : fast/forms/select/select-state-restore.html = PASS TIMEOUT // Flaky @@ -3548,11 +3549,13 @@ BUGCR145590 ANDROID : http/tests/appcache/video.html = TEXT BUGCR145590 ANDROID : http/tests/media/media-source/video-media-source-abort.html = TIMEOUT BUGCR145590 ANDROID : http/tests/media/media-source/video-media-source-add-and-remove-buffers.html = TIMEOUT +BUGCR145590 ANDROID : http/tests/media/media-source/video-media-source-async-events.html = TIMEOUT BUGCR145590 ANDROID : http/tests/media/media-source/video-media-source-errors.html = TIMEOUT BUGCR145590 ANDROID : http/tests/media/media-source/video-media-source-event-attributes.html = TIMEOUT BUGCR145590 ANDROID : http/tests/media/media-source/video-media-source-objects.html = TIMEOUT BUGCR145590 ANDROID : http/tests/media/media-source/video-media-source-play.html = TEXT BUGCR145590 ANDROID : http/tests/media/media-source/video-media-source-seek.html = TEXT +BUGCR145590 ANDROID : http/tests/media/media-source/video-media-source-sourcebufferlist-crash.html = TIMEOUT BUGCR145590 ANDROID : http/tests/media/media-source/video-media-source-state-changes.html = TEXT BUGCR145590 ANDROID : http/tests/media/pdf-served-as-pdf.html = TEXT BUGCR145590 ANDROID : http/tests/media/text-served-as-text.html = TEXT @@ -3565,14 +3568,16 @@ BUGCR145590 ANDROID : media/W3C/video/canPlayType/canPlayType_two_implies_one_5.html = TEXT BUGCR145590 ANDROID : media/W3C/video/canPlayType/canPlayType_two_implies_one_6.html = TEXT BUGCR145590 ANDROID : media/audio-data-url.html = TEXT -BUGCR145590 ANDROID : media/audio-repaint.html = TEXT +BUGCR145590 ANDROID : media/audio-repaint.html = TEXT TIMEOUT BUGCR145590 ANDROID : media/encrypted-media/encrypted-media-events.html = TIMEOUT BUGCR145590 ANDROID : media/encrypted-media/encrypted-media-not-loaded.html = TEXT BUGCR145590 ANDROID : media/encrypted-media/encrypted-media-syntax.html = TEXT +BUGCR145590 ANDROID : media/track/track-default-attribute.html = TIMEOUT PASS BUGCR145590 ANDROID : media/video-aspect-ratio.html = TEXT // 8 videos BUGCR145590 ANDROID : media/video-buffered.html = TEXT BUGCR145590 ANDROID : media/video-canvas-source.html = TEXT BUGCR145590 ANDROID : media/video-error-does-not-exist.html = TEXT +BUGCR145590 ANDROID : media/video-source-error-no-candidate.html = TIMEOUT PASS BUGCR145590 ANDROID : media/video-source-type-params.html = TEXT BUGCR145590 ANDROID : platform/chromium/compositing/video-frame-size-change.html = TIMEOUT BUGCR145590 ANDROID : platform/chromium/media/video-frame-size-change.html = TIMEOUT @@ -3605,3 +3610,11 @@ // Does not yet support new web notifications TestRunner API BUGWK95506 SKIP : http/tests/notifications = PASS + +// The test font doesn't contain the glyph that Android uses to detect Arabic. +BUGCR146399 ANDROID : platform/chromium-linux/fast/text/international/arabic-vertical-offset.html =
[webkit-changes] [127511] trunk/LayoutTests
Title: [127511] trunk/LayoutTests Revision 127511 Author roger_f...@apple.com Date 2012-09-04 15:14:20 -0700 (Tue, 04 Sep 2012) Log Message Unreviewed. Rebaseline Windows expected results for accessibility\canvas-description-and-role-expected.txt. One of the results in the test now passes. * platform/win/accessibility/canvas-description-and-role-expected.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/win/accessibility/canvas-description-and-role-expected.txt Diff Modified: trunk/LayoutTests/ChangeLog (127510 => 127511) --- trunk/LayoutTests/ChangeLog 2012-09-04 21:48:47 UTC (rev 127510) +++ trunk/LayoutTests/ChangeLog 2012-09-04 22:14:20 UTC (rev 127511) @@ -1,3 +1,10 @@ +2012-09-04 Roger Fong roger_f...@apple.com + +Unreviewed. Rebaseline Windows expected results for accessibility\canvas-description-and-role-expected.txt. +One of the results in the test now passes. + +* platform/win/accessibility/canvas-description-and-role-expected.txt: + 2012-09-04 Xianzhu Wang wangxian...@chromium.org Unreviewed. Update test expectations for Android. Modified: trunk/LayoutTests/platform/win/accessibility/canvas-description-and-role-expected.txt (127510 => 127511) --- trunk/LayoutTests/platform/win/accessibility/canvas-description-and-role-expected.txt 2012-09-04 21:48:47 UTC (rev 127510) +++ trunk/LayoutTests/platform/win/accessibility/canvas-description-and-role-expected.txt 2012-09-04 22:14:20 UTC (rev 127511) @@ -3,7 +3,7 @@ On success, you will see a series of PASS messages, followed by TEST COMPLETE. -FAIL axContainer.childrenCount should be 2. Was 3. +PASS axContainer.childrenCount is 2 Canvas 1 description: Description: Canvas label Canvas 1 role: graphic Canvas 2 description: ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [127512] trunk/Tools
Title: [127512] trunk/Tools
Revision 127512
Author wangxian...@chromium.org
Date 2012-09-04 15:14:36 -0700 (Tue, 04 Sep 2012)
Log Message
[Chromium-Android] Include device serial number in ChromiumAndroidDriver log messages
https://bugs.webkit.org/show_bug.cgi?id=95770
Reviewed by Adam Barth.
* Scripts/webkitpy/layout_tests/port/chromium_android.py:
(ChromiumAndroidDriver.__init__):
(ChromiumAndroidDriver._log_error): Added to replace original _log.error().
(ChromiumAndroidDriver._log_debug): Added to replace original _log.debug().
(ChromiumAndroidDriver._abort): Added to replace original raise AssertionError().
(ChromiumAndroidDriver._push_executable):
(ChromiumAndroidDriver._push_fonts):
(ChromiumAndroidDriver._push_test_resources):
(ChromiumAndroidDriver._run_adb_command):
(ChromiumAndroidDriver._get_last_stacktrace):
(ChromiumAndroidDriver._get_crash_log):
(ChromiumAndroidDriver._start):
(ChromiumAndroidDriver._start_once):
(ChromiumAndroidDriver._start_once.deadlock_detector):
* Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
(ChromiumAndroidDriverTest.test_get_crash_log):
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_android.py
trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py
Diff
Modified: trunk/Tools/ChangeLog (127511 => 127512)
--- trunk/Tools/ChangeLog 2012-09-04 22:14:20 UTC (rev 127511)
+++ trunk/Tools/ChangeLog 2012-09-04 22:14:36 UTC (rev 127512)
@@ -1,3 +1,27 @@
+2012-09-04 Xianzhu Wang wangxian...@chromium.org
+
+[Chromium-Android] Include device serial number in ChromiumAndroidDriver log messages
+https://bugs.webkit.org/show_bug.cgi?id=95770
+
+Reviewed by Adam Barth.
+
+* Scripts/webkitpy/layout_tests/port/chromium_android.py:
+(ChromiumAndroidDriver.__init__):
+(ChromiumAndroidDriver._log_error): Added to replace original _log.error().
+(ChromiumAndroidDriver._log_debug): Added to replace original _log.debug().
+(ChromiumAndroidDriver._abort): Added to replace original raise AssertionError().
+(ChromiumAndroidDriver._push_executable):
+(ChromiumAndroidDriver._push_fonts):
+(ChromiumAndroidDriver._push_test_resources):
+(ChromiumAndroidDriver._run_adb_command):
+(ChromiumAndroidDriver._get_last_stacktrace):
+(ChromiumAndroidDriver._get_crash_log):
+(ChromiumAndroidDriver._start):
+(ChromiumAndroidDriver._start_once):
+(ChromiumAndroidDriver._start_once.deadlock_detector):
+* Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
+(ChromiumAndroidDriverTest.test_get_crash_log):
+
2012-09-04 Satish Sampath sat...@chromium.org
Run git commands within the checkout directory
Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_android.py (127511 => 127512)
--- trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_android.py 2012-09-04 22:14:20 UTC (rev 127511)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_android.py 2012-09-04 22:14:36 UTC (rev 127512)
@@ -317,7 +317,8 @@
self._forwarder_process = None
self._has_setup = False
self._original_governors = {}
-self._adb_command = ['adb', '-s', port._get_device_serial(worker_number)]
+self._device_serial = port._get_device_serial(worker_number)
+self._adb_command = ['adb', '-s', self._device_serial]
def __del__(self):
self._teardown_performance()
@@ -347,6 +348,15 @@
# This is like what's done in ChromiumPort.setup_test_run but on the device.
self._run_adb_command(['shell', 'rm', '-r', DRT_APP_CACHE_DIR])
+def _log_error(self, message):
+_log.error('[%s] %s' % (self._device_serial, message))
+
+def _log_debug(self, message):
+_log.debug('[%s] %s' % (self._device_serial, message))
+
+def _abort(self, message):
+raise AssertionError('[%s] %s' % (self._device_serial, message))
+
def _push_executable(self):
drt_host_path = self._port._path_to_driver()
forwarder_host_path = self._port._path_to_forwarder()
@@ -355,12 +365,12 @@
device_stamp = int(float(self._run_adb_command([
'shell', 'cat %s 2/dev/null || echo 0' % DEVICE_DRT_STAMP_PATH])))
if device_stamp != host_stamp:
-_log.debug('Pushing executable')
+self._log_debug('Pushing executable')
self._push_to_device(forwarder_host_path, DEVICE_FORWARDER_PATH)
self._run_adb_command(['uninstall', DRT_APP_PACKAGE])
install_result = self._run_adb_command(['install', drt_host_path])
if install_result.find('Success') == -1:
-raise AssertionError('Failed to install %s onto device: %s' % (drt_host_path, install_result))
+self._abort('Failed to install %s onto device: %s' % (drt_host_path, install_result))
[webkit-changes] [127513] trunk
Title: [127513] trunk Revision 127513 Author jp...@apple.com Date 2012-09-04 15:20:43 -0700 (Tue, 04 Sep 2012) Log Message Make plugins respect third-party storage blocking setting https://bugs.webkit.org/show_bug.cgi?id=94888 Reviewed by Brady Eidson. Source/WebCore: Added functions for discerning if a plugin should be able to access its storage in its current origin. Tests: http/tests/security/cross-origin-plugin-allowed.html http/tests/security/cross-origin-plugin.html * WebCore.exp.in: Export FrameTree::top and SecurityOrigin::canAccessStorage * page/SecurityOrigin.h: Added canAccessPluginStorage (WebCore::SecurityOrigin::canAccessPluginStorage): Source/WebKit2: Plugins that are in a third-party context should be put into private browsing mode so their storage is temporary. * WebProcess/Plugins/PluginView.cpp: (WebKit::PluginView::isPrivateBrowsingEnabled): Put the plugin into private browsing mode if it is in a third-party context. (WebKit::PluginView::privateBrowsingStateChanged): Make sure a plugin doesn't leave private browsing mode if it's in a third-party context. LayoutTests: Created tests for plugins in a third party and first party context when third-party blocking is on and off. * http/tests/security/cross-origin-plugin-allowed-expected.txt: Added. * http/tests/security/cross-origin-plugin-allowed.html: Added. * http/tests/security/cross-origin-plugin-expected.txt: Added. * http/tests/security/cross-origin-plugin-private-browsing-toggled-allowed-expected.txt: Added. * http/tests/security/cross-origin-plugin-private-browsing-toggled-allowed.html: Added. * http/tests/security/cross-origin-plugin-private-browsing-toggled-expected.txt: Added. * http/tests/security/cross-origin-plugin-private-browsing-toggled.html: Added. * http/tests/security/cross-origin-plugin.html: Added. * http/tests/security/resources/cross-origin-iframe-for-plugin.html: Added. * http/tests/security/resources/cross-origin-iframe-for-plugin-async.html: Added. * platform/mac-wk2/http/tests/security/cross-origin-plugin-expected.txt: Added. * platform/mac-wk2/http/tests/security/cross-origin-plugin-private-browsing-toggled-expected.txt: Added. Modified Paths trunk/LayoutTests/ChangeLog trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/WebCore.exp.in trunk/Source/WebCore/page/SecurityOrigin.h trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/WebProcess/Plugins/PluginView.cpp Added Paths trunk/LayoutTests/http/tests/security/cross-origin-plugin-allowed-expected.txt trunk/LayoutTests/http/tests/security/cross-origin-plugin-allowed.html trunk/LayoutTests/http/tests/security/cross-origin-plugin-expected.txt trunk/LayoutTests/http/tests/security/cross-origin-plugin-private-browsing-toggled-allowed-expected.txt trunk/LayoutTests/http/tests/security/cross-origin-plugin-private-browsing-toggled-allowed.html trunk/LayoutTests/http/tests/security/cross-origin-plugin-private-browsing-toggled-expected.txt trunk/LayoutTests/http/tests/security/cross-origin-plugin-private-browsing-toggled.html trunk/LayoutTests/http/tests/security/cross-origin-plugin.html trunk/LayoutTests/http/tests/security/resources/cross-origin-iframe-for-plugin-async.html trunk/LayoutTests/http/tests/security/resources/cross-origin-iframe-for-plugin.html trunk/LayoutTests/platform/mac-wk2/http/tests/security/cross-origin-plugin-expected.txt trunk/LayoutTests/platform/mac-wk2/http/tests/security/cross-origin-plugin-private-browsing-toggled-expected.txt Diff Modified: trunk/LayoutTests/ChangeLog (127512 => 127513) --- trunk/LayoutTests/ChangeLog 2012-09-04 22:14:36 UTC (rev 127512) +++ trunk/LayoutTests/ChangeLog 2012-09-04 22:20:43 UTC (rev 127513) @@ -1,3 +1,25 @@ +2012-09-04 Jeffrey Pfau jp...@apple.com + +Make plugins respect third-party storage blocking setting +https://bugs.webkit.org/show_bug.cgi?id=94888 + +Reviewed by Brady Eidson. + +Created tests for plugins in a third party and first party context when third-party blocking is on and off. + +* http/tests/security/cross-origin-plugin-allowed-expected.txt: Added. +* http/tests/security/cross-origin-plugin-allowed.html: Added. +* http/tests/security/cross-origin-plugin-expected.txt: Added. +* http/tests/security/cross-origin-plugin-private-browsing-toggled-allowed-expected.txt: Added. +* http/tests/security/cross-origin-plugin-private-browsing-toggled-allowed.html: Added. +* http/tests/security/cross-origin-plugin-private-browsing-toggled-expected.txt: Added. +* http/tests/security/cross-origin-plugin-private-browsing-toggled.html: Added. +* http/tests/security/cross-origin-plugin.html: Added. +* http/tests/security/resources/cross-origin-iframe-for-plugin.html: Added. +* http/tests/security/resources/cross-origin-iframe-for-plugin-async.html: Added. +* platform/mac-wk2/http/tests/security/cross-origin-plugin-expected.txt: Added. +*
[webkit-changes] [127514] trunk/Source/WebCore
Title: [127514] trunk/Source/WebCore
Revision 127514
Author commit-qu...@webkit.org
Date 2012-09-04 15:22:40 -0700 (Tue, 04 Sep 2012)
Log Message
Fix style for Event.h
https://bugs.webkit.org/show_bug.cgi?id=95779
Patch by Nikhil Bhargava nbharg...@google.com on 2012-09-04
Reviewed by Eric Seidel.
Changes indenting for Event.h to match style guidelines for namespaces
* dom/Event.h:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/Event.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (127513 => 127514)
--- trunk/Source/WebCore/ChangeLog 2012-09-04 22:20:43 UTC (rev 127513)
+++ trunk/Source/WebCore/ChangeLog 2012-09-04 22:22:40 UTC (rev 127514)
@@ -1,3 +1,14 @@
+2012-09-04 Nikhil Bhargava nbharg...@google.com
+
+Fix style for Event.h
+https://bugs.webkit.org/show_bug.cgi?id=95779
+
+Reviewed by Eric Seidel.
+
+Changes indenting for Event.h to match style guidelines for namespaces
+
+* dom/Event.h:
+
2012-09-04 Jeffrey Pfau jp...@apple.com
Make plugins respect third-party storage blocking setting
Modified: trunk/Source/WebCore/dom/Event.h (127513 => 127514)
--- trunk/Source/WebCore/dom/Event.h 2012-09-04 22:20:43 UTC (rev 127513)
+++ trunk/Source/WebCore/dom/Event.h 2012-09-04 22:22:40 UTC (rev 127514)
@@ -31,160 +31,164 @@
namespace WebCore {
-class EventTarget;
-class EventDispatcher;
-class HTMLIFrameElement;
-class MemoryInstrumentation;
+class EventTarget;
+class EventDispatcher;
+class HTMLIFrameElement;
+class MemoryInstrumentation;
-struct EventInit {
-EventInit();
-
-bool bubbles;
-bool cancelable;
+struct EventInit {
+EventInit();
+
+bool bubbles;
+bool cancelable;
+};
+
+class Event : public RefCountedEvent {
+public:
+enum PhaseType {
+NONE= 0,
+CAPTURING_PHASE = 1,
+AT_TARGET = 2,
+BUBBLING_PHASE = 3
};
-class Event : public RefCountedEvent {
-public:
-enum PhaseType {
-NONE= 0,
-CAPTURING_PHASE = 1,
-AT_TARGET = 2,
-BUBBLING_PHASE = 3
-};
+enum EventType {
+MOUSEDOWN = 1,
+MOUSEUP = 2,
+MOUSEOVER = 4,
+MOUSEOUT= 8,
+MOUSEMOVE = 16,
+MOUSEDRAG = 32,
+CLICK = 64,
+DBLCLICK= 128,
+KEYDOWN = 256,
+KEYUP = 512,
+KEYPRESS= 1024,
+DRAGDROP= 2048,
+FOCUS = 4096,
+BLUR= 8192,
+SELECT = 16384,
+CHANGE = 32768
+};
-enum EventType {
-MOUSEDOWN = 1,
-MOUSEUP = 2,
-MOUSEOVER = 4,
-MOUSEOUT= 8,
-MOUSEMOVE = 16,
-MOUSEDRAG = 32,
-CLICK = 64,
-DBLCLICK= 128,
-KEYDOWN = 256,
-KEYUP = 512,
-KEYPRESS= 1024,
-DRAGDROP= 2048,
-FOCUS = 4096,
-BLUR= 8192,
-SELECT = 16384,
-CHANGE = 32768
-};
+static PassRefPtrEvent create()
+{
+return adoptRef(new Event);
+}
+static PassRefPtrEvent create(const AtomicString type, bool canBubble, bool cancelable)
+{
+return adoptRef(new Event(type, canBubble, cancelable));
+}
-static PassRefPtrEvent create()
-{
-return adoptRef(new Event);
-}
-static PassRefPtrEvent create(const AtomicString type, bool canBubble, bool cancelable)
-{
-return adoptRef(new Event(type, canBubble, cancelable));
-}
+static PassRefPtrEvent create(const AtomicString type, const EventInit initializer)
+{
+return adoptRef(new Event(type, initializer));
+}
-static PassRefPtrEvent create(const AtomicString type, const EventInit initializer)
-{
-return adoptRef(new Event(type, initializer));
-}
+virtual ~Event();
-virtual ~Event();
+void initEvent(const AtomicString type, bool canBubble, bool cancelable);
-void initEvent(const AtomicString type, bool canBubble, bool cancelable);
+const AtomicString type() const { return m_type; }
+
+EventTarget* target() const { return m_target.get(); }
+void setTarget(PassRefPtrEventTarget);
-const AtomicString type() const { return m_type; }
-
-EventTarget* target() const { return m_target.get(); }
-void setTarget(PassRefPtrEventTarget);
+
[webkit-changes] [127515] trunk/Source/WebKit/blackberry
Title: [127515] trunk/Source/WebKit/blackberry
Revision 127515
Author rwlb...@webkit.org
Date 2012-09-04 15:27:16 -0700 (Tue, 04 Sep 2012)
Log Message
[BlackBerry] FatFingers::cachingStrategy uses incorrect enum value
https://bugs.webkit.org/show_bug.cgi?id=95783
Reviewed by Antonio Gomes.
Use the correct enum values.
* WebKitSupport/FatFingers.cpp:
(BlackBerry::WebKit::FatFingers::cachingStrategy):
Modified Paths
trunk/Source/WebKit/blackberry/ChangeLog
trunk/Source/WebKit/blackberry/WebKitSupport/FatFingers.cpp
Diff
Modified: trunk/Source/WebKit/blackberry/ChangeLog (127514 => 127515)
--- trunk/Source/WebKit/blackberry/ChangeLog 2012-09-04 22:22:40 UTC (rev 127514)
+++ trunk/Source/WebKit/blackberry/ChangeLog 2012-09-04 22:27:16 UTC (rev 127515)
@@ -1,3 +1,15 @@
+2012-09-04 Rob Buis rb...@rim.com
+
+[BlackBerry] FatFingers::cachingStrategy uses incorrect enum value
+https://bugs.webkit.org/show_bug.cgi?id=95783
+
+Reviewed by Antonio Gomes.
+
+Use the correct enum values.
+
+* WebKitSupport/FatFingers.cpp:
+(BlackBerry::WebKit::FatFingers::cachingStrategy):
+
2012-09-04 Antonio Gomes ago...@rim.com
[BlackBerry] Use child/ScrollableContent layer's position instead of parent/ScrollLayer's boundsOrigin
Modified: trunk/Source/WebKit/blackberry/WebKitSupport/FatFingers.cpp (127514 => 127515)
--- trunk/Source/WebKit/blackberry/WebKitSupport/FatFingers.cpp 2012-09-04 22:22:40 UTC (rev 127514)
+++ trunk/Source/WebKit/blackberry/WebKitSupport/FatFingers.cpp 2012-09-04 22:27:16 UTC (rev 127515)
@@ -465,7 +465,7 @@
FatFingers::CachedResultsStrategy FatFingers::cachingStrategy() const
{
switch (m_matchingApproach) {
-case ClickableElement:
+case ClickableByDefault:
return GetFromRenderTree;
case MadeClickableByTheWebpage:
return GetFromCache;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [127516] trunk/Source/JavaScriptCore
Title: [127516] trunk/Source/_javascript_Core
Revision 127516
Author commit-qu...@webkit.org
Date 2012-09-04 15:34:03 -0700 (Tue, 04 Sep 2012)
Log Message
Unreviewed, rolling out r127503.
http://trac.webkit.org/changeset/127503
https://bugs.webkit.org/show_bug.cgi?id=95788
broke some tests (fast/js/dfg-negative-array-index, fast/js
/dfg-put-by-val-setter-then-get-by-val) (Requested by thorton
on #webkit).
Patch by Sheriff Bot webkit.review@gmail.com on 2012-09-04
* bytecode/DFGExitProfile.h:
(JSC::DFG::exitKindToString):
* dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::execute):
* dfg/DFGOperations.cpp:
* dfg/DFGOperations.h:
* dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::callOperation):
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/bytecode/DFGExitProfile.h
trunk/Source/_javascript_Core/dfg/DFGAbstractState.cpp
trunk/Source/_javascript_Core/dfg/DFGOperations.cpp
trunk/Source/_javascript_Core/dfg/DFGOperations.h
trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.h
trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT32_64.cpp
trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT64.cpp
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (127515 => 127516)
--- trunk/Source/_javascript_Core/ChangeLog 2012-09-04 22:27:16 UTC (rev 127515)
+++ trunk/Source/_javascript_Core/ChangeLog 2012-09-04 22:34:03 UTC (rev 127516)
@@ -1,3 +1,26 @@
+2012-09-04 Sheriff Bot webkit.review@gmail.com
+
+Unreviewed, rolling out r127503.
+http://trac.webkit.org/changeset/127503
+https://bugs.webkit.org/show_bug.cgi?id=95788
+
+broke some tests (fast/js/dfg-negative-array-index, fast/js
+/dfg-put-by-val-setter-then-get-by-val) (Requested by thorton
+on #webkit).
+
+* bytecode/DFGExitProfile.h:
+(JSC::DFG::exitKindToString):
+* dfg/DFGAbstractState.cpp:
+(JSC::DFG::AbstractState::execute):
+* dfg/DFGOperations.cpp:
+* dfg/DFGOperations.h:
+* dfg/DFGSpeculativeJIT.h:
+(JSC::DFG::SpeculativeJIT::callOperation):
+* dfg/DFGSpeculativeJIT32_64.cpp:
+(JSC::DFG::SpeculativeJIT::compile):
+* dfg/DFGSpeculativeJIT64.cpp:
+(JSC::DFG::SpeculativeJIT::compile):
+
2012-09-04 Benjamin Poulain bpoul...@apple.com
Improve JSC use of Strings after the UString-String change
Modified: trunk/Source/_javascript_Core/bytecode/DFGExitProfile.h (127515 => 127516)
--- trunk/Source/_javascript_Core/bytecode/DFGExitProfile.h 2012-09-04 22:27:16 UTC (rev 127515)
+++ trunk/Source/_javascript_Core/bytecode/DFGExitProfile.h 2012-09-04 22:34:03 UTC (rev 127516)
@@ -58,8 +58,6 @@
return Overflow;
case NegativeZero:
return NegativeZero;
-case OutOfBounds:
-return OutOfBounds;
case InadequateCoverage:
return InadequateCoverage;
case ArgumentsEscaped:
Modified: trunk/Source/_javascript_Core/dfg/DFGAbstractState.cpp (127515 => 127516)
--- trunk/Source/_javascript_Core/dfg/DFGAbstractState.cpp 2012-09-04 22:27:16 UTC (rev 127515)
+++ trunk/Source/_javascript_Core/dfg/DFGAbstractState.cpp 2012-09-04 22:34:03 UTC (rev 127516)
@@ -853,12 +853,10 @@
forNode(nodeIndex).makeTop();
break;
case Array::JSArray:
-forNode(node.child2()).filter(SpecInt32);
-forNode(nodeIndex).makeTop();
-break;
case Array::JSArrayOutOfBounds:
+// FIXME: We should have more conservative handling of the out-of-bounds
+// case.
forNode(node.child2()).filter(SpecInt32);
-clobberWorld(node.codeOrigin, indexInBlock);
forNode(nodeIndex).makeTop();
break;
case Array::Int8Array:
Modified: trunk/Source/_javascript_Core/dfg/DFGOperations.cpp (127515 => 127516)
--- trunk/Source/_javascript_Core/dfg/DFGOperations.cpp 2012-09-04 22:27:16 UTC (rev 127515)
+++ trunk/Source/_javascript_Core/dfg/DFGOperations.cpp 2012-09-04 22:34:03 UTC (rev 127516)
@@ -409,15 +409,6 @@
return JSValue::encode(JSValue(base).get(exec, ident));
}
-EncodedJSValue DFG_OPERATION operationGetByValArrayInt(ExecState* exec, JSArray* base, int32_t index)
-{
-JSGlobalData* globalData = exec-globalData();
-NativeCallFrameTracer tracer(globalData, exec);
-
-// Use this since we know that the value is out of bounds.
-return JSValue::encode(JSValue(base).get(exec, index));
-}
-
EncodedJSValue DFG_OPERATION operationGetById(ExecState* exec, EncodedJSValue base, Identifier* propertyName)
{
JSGlobalData* globalData = exec-globalData();
Modified: trunk/Source/_javascript_Core/dfg/DFGOperations.h (127515 => 127516)
--- trunk/Source/_javascript_Core/dfg/DFGOperations.h 2012-09-04 22:27:16 UTC (rev 127515)
+++
[webkit-changes] [127517] trunk
Title: [127517] trunk
Revision 127517
Author commit-qu...@webkit.org
Date 2012-09-04 15:53:25 -0700 (Tue, 04 Sep 2012)
Log Message
[CSS Shaders] Implement multiply, screen, darken, lighten, difference, exclusion blend modes.
https://bugs.webkit.org/show_bug.cgi?id=93870
Patch by Max Vujovic mvujo...@adobe.com on 2012-09-04
Reviewed by Dirk Schulze.
Source/WebCore:
Add expressions for the aforementioned blend modes. The expressions are lifted directly
from the CSS Compositing and Blending spec [1]. WebKit adds these blending expressions to
the author's shader.
[1]: https://dvcs.w3.org/hg/FXTF/rawfile/tip/compositing/index.html#blendingnormal
Test: css3/filters/custom/custom-filter-blend-modes.html
* platform/graphics/filters/CustomFilterValidatedProgram.cpp:
(WebCore::CustomFilterValidatedProgram::blendFunctionString):
LayoutTests:
Add test to check that the DOM element texture blends correctly with the css_MixColor
variable from the author's shader for each blend mode.
* css3/filters/custom/custom-filter-blend-modes-expected.html: Added.
* css3/filters/custom/custom-filter-blend-modes.html: Added.
* css3/filters/resources/mix-color.fs: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/filters/CustomFilterValidatedProgram.cpp
Added Paths
trunk/LayoutTests/css3/filters/custom/custom-filter-blend-modes-expected.html
trunk/LayoutTests/css3/filters/custom/custom-filter-blend-modes.html
trunk/LayoutTests/css3/filters/resources/mix-color.fs
Diff
Modified: trunk/LayoutTests/ChangeLog (127516 => 127517)
--- trunk/LayoutTests/ChangeLog 2012-09-04 22:34:03 UTC (rev 127516)
+++ trunk/LayoutTests/ChangeLog 2012-09-04 22:53:25 UTC (rev 127517)
@@ -1,3 +1,17 @@
+2012-09-04 Max Vujovic mvujo...@adobe.com
+
+[CSS Shaders] Implement multiply, screen, darken, lighten, difference, exclusion blend modes.
+https://bugs.webkit.org/show_bug.cgi?id=93870
+
+Reviewed by Dirk Schulze.
+
+Add test to check that the DOM element texture blends correctly with the css_MixColor
+variable from the author's shader for each blend mode.
+
+* css3/filters/custom/custom-filter-blend-modes-expected.html: Added.
+* css3/filters/custom/custom-filter-blend-modes.html: Added.
+* css3/filters/resources/mix-color.fs: Added.
+
2012-09-04 Jeffrey Pfau jp...@apple.com
Make plugins respect third-party storage blocking setting
Added: trunk/LayoutTests/css3/filters/custom/custom-filter-blend-modes-expected.html (0 => 127517)
--- trunk/LayoutTests/css3/filters/custom/custom-filter-blend-modes-expected.html (rev 0)
+++ trunk/LayoutTests/css3/filters/custom/custom-filter-blend-modes-expected.html 2012-09-04 22:53:25 UTC (rev 127517)
@@ -0,0 +1,79 @@
+!doctype html
+html
+head
+titleTests that custom filter blend modes compute color values correctly./title
+!--
+This is the reference file for the test.
+The test passes if each horizontal pair of squares are exactly the same color.
+The test file describes how the color values in this reference file are computed.
+--
+style
+.pair-of-squares {
+clear: both;
+}
+.pair-of-squares div {
+/* Square size. */
+width: 20px;
+height: 20px;
+margin: 2px;
+float: left;
+}
+/* Blend modes */
+.normal-expected {
+background-color: rgb(0%, 60%, 50%);
+}
+.multiply-expected {
+background-color: rgb(0%, 18%, 25%);
+}
+.screen-expected {
+background-color: rgb(255, 183, 192);
+}
+.darken-expected {
+background-color: rgb(0%, 30%, 50%);
+}
+.lighten-expected {
+background-color: rgb(100%, 60%, 50%);
+}
+.difference-expected {
+background-color: rgb(255, 77, 1);
+}
+.exclusion-expected {
+background-color: rgb(255, 138, 127);
+}
+/style
+/head
+body
+div class=pair-of-squares
+div class=normal-expected/div
+div class=normal-expected/div
+/div
+div class=pair-of-squares
+div class=multiply-expected/div
+div class=multiply-expected/div
+/div
+div class=pair-of-squares
+div class=screen-expected/div
+div class=screen-expected/div
+/div
+div class=pair-of-squares
+div class=darken-expected/div
+div class=darken-expected/div
+/div
+div class=pair-of-squares
+div class=lighten-expected/div
+div class=lighten-expected/div
+/div
+div class=pair-of-squares
+div class=difference-expected/div
+div class=difference-expected/div
+/div
+div class=pair-of-squares
+div class=exclusion-expected/div
+div class=exclusion-expected/div
+/div
+!--
+If you add more blend modes to this page, be careful not to exceed 600px in
+height, since
[webkit-changes] [127518] trunk/Source/WebCore
Title: [127518] trunk/Source/WebCore
Revision 127518
Author jsb...@chromium.org
Date 2012-09-04 16:34:19 -0700 (Tue, 04 Sep 2012)
Log Message
IndexedDB: IDBRequest leaks if IDBCursor closes and no further events fired
https://bugs.webkit.org/show_bug.cgi?id=95777
Reviewed by Tony Chang.
IDBRequests are kept alive as long as they may fire events, which includes
if the associated IDBCursor object can be advanced. When the transaction
is finished the IDBCursor is notified which in turn tells the IDBRequest
that the cursor won't be the source of more events. However, if this occurs
and no further events fire the IDBRequest doesn't clear it's has pending
activity flag. Clear the flag on the notification if the request is
otherwise complete.
No new tests - ActiveDOMObjects and leaks are persnickety.
* Modules/indexeddb/IDBRequest.cpp:
(WebCore::IDBRequest::finishCursor):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/indexeddb/IDBRequest.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (127517 => 127518)
--- trunk/Source/WebCore/ChangeLog 2012-09-04 22:53:25 UTC (rev 127517)
+++ trunk/Source/WebCore/ChangeLog 2012-09-04 23:34:19 UTC (rev 127518)
@@ -1,3 +1,23 @@
+2012-09-04 Joshua Bell jsb...@chromium.org
+
+IndexedDB: IDBRequest leaks if IDBCursor closes and no further events fired
+https://bugs.webkit.org/show_bug.cgi?id=95777
+
+Reviewed by Tony Chang.
+
+IDBRequests are kept alive as long as they may fire events, which includes
+if the associated IDBCursor object can be advanced. When the transaction
+is finished the IDBCursor is notified which in turn tells the IDBRequest
+that the cursor won't be the source of more events. However, if this occurs
+and no further events fire the IDBRequest doesn't clear it's has pending
+activity flag. Clear the flag on the notification if the request is
+otherwise complete.
+
+No new tests - ActiveDOMObjects and leaks are persnickety.
+
+* Modules/indexeddb/IDBRequest.cpp:
+(WebCore::IDBRequest::finishCursor):
+
2012-09-04 Max Vujovic mvujo...@adobe.com
[CSS Shaders] Implement multiply, screen, darken, lighten, difference, exclusion blend modes.
Modified: trunk/Source/WebCore/Modules/indexeddb/IDBRequest.cpp (127517 => 127518)
--- trunk/Source/WebCore/Modules/indexeddb/IDBRequest.cpp 2012-09-04 22:53:25 UTC (rev 127517)
+++ trunk/Source/WebCore/Modules/indexeddb/IDBRequest.cpp 2012-09-04 23:34:19 UTC (rev 127518)
@@ -232,6 +232,8 @@
void IDBRequest::finishCursor()
{
m_cursorFinished = true;
+if (m_readyState != PENDING)
+m_hasPendingActivity = false;
}
bool IDBRequest::shouldEnqueueEvent() const
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [127519] trunk/LayoutTests
Title: [127519] trunk/LayoutTests Revision 127519 Author roger_f...@apple.com Date 2012-09-04 16:34:22 -0700 (Tue, 04 Sep 2012) Log Message Unreviewed gardening. editing/style/apply-style-atomic.html fails on Windows since introduced in http://trac.webkit.org/changeset/126865. Test added to skip list. https://bugs.webkit.org/show_bug.cgi?id=95795 * platform/win/Skipped: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/win/Skipped Diff Modified: trunk/LayoutTests/ChangeLog (127518 => 127519) --- trunk/LayoutTests/ChangeLog 2012-09-04 23:34:19 UTC (rev 127518) +++ trunk/LayoutTests/ChangeLog 2012-09-04 23:34:22 UTC (rev 127519) @@ -1,3 +1,12 @@ +2012-09-04 Roger Fong roger_f...@apple.com + +Unreviewed gardening. editing/style/apply-style-atomic.html fails on Windows since introduced in http://trac.webkit.org/changeset/126865. +Test added to skip list. + +https://bugs.webkit.org/show_bug.cgi?id=95795 + +* platform/win/Skipped: + 2012-09-04 Max Vujovic mvujo...@adobe.com [CSS Shaders] Implement multiply, screen, darken, lighten, difference, exclusion blend modes. Modified: trunk/LayoutTests/platform/win/Skipped (127518 => 127519) --- trunk/LayoutTests/platform/win/Skipped 2012-09-04 23:34:19 UTC (rev 127518) +++ trunk/LayoutTests/platform/win/Skipped 2012-09-04 23:34:22 UTC (rev 127519) @@ -2165,3 +2165,6 @@ # https://bugs.webkit.org/show_bug.cgi?id=95428 media/video-controls-captions.html + +# https://bugs.webkit.org/show_bug.cgi?id=95795 +editing/style/apply-style-atomic.html ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [127520] trunk
Title: [127520] trunk
Revision 127520
Author jchaffr...@webkit.org
Date 2012-09-04 16:39:00 -0700 (Tue, 04 Sep 2012)
Log Message
REGRESSION(r120832): RenderLayer::clampScrollOffset doesn't properly clamp
https://bugs.webkit.org/show_bug.cgi?id=95776
Reviewed by Simon Fraser.
.:
* ManualTests/select-menu-list-wrongly-positioned.html: Added.
Source/WebCore:
r120832 consolidated the clamping logic into RenderLayer::clampScrollOffset. The existing code wouldn't properly ensure that
the offset were positive which got exposed to other code paths, leading to the regression.
Tested by ManualTests/select-menu-list-wrongly-positioned.html as I didn't find a way to create a reliable layout test.
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::clampScrollOffset):
Fixed the clamping logic to ensure that the scroll offset's dimensions are positive.
Modified Paths
trunk/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderLayer.cpp
Added Paths
trunk/ManualTests/select-menu-list-wrongly-positioned.html
Diff
Modified: trunk/ChangeLog (127519 => 127520)
--- trunk/ChangeLog 2012-09-04 23:34:22 UTC (rev 127519)
+++ trunk/ChangeLog 2012-09-04 23:39:00 UTC (rev 127520)
@@ -1,3 +1,12 @@
+2012-09-04 Julien Chaffraix jchaffr...@webkit.org
+
+REGRESSION(r120832): RenderLayer::clampScrollOffset doesn't properly clamp
+https://bugs.webkit.org/show_bug.cgi?id=95776
+
+Reviewed by Simon Fraser.
+
+* ManualTests/select-menu-list-wrongly-positioned.html: Added.
+
2012-09-04 Michał Pakuła vel Rutka m.pak...@samsung.com
[EFL] Context menu restore.
Added: trunk/ManualTests/select-menu-list-wrongly-positioned.html (0 => 127520)
--- trunk/ManualTests/select-menu-list-wrongly-positioned.html (rev 0)
+++ trunk/ManualTests/select-menu-list-wrongly-positioned.html 2012-09-04 23:39:00 UTC (rev 127520)
@@ -0,0 +1,38 @@
+!DOCTYPE html
+html
+head
+style
+table {
+overflow: hidden;
+}
+/style
+script
+function onSelectionChange(select)
+{
+document.getElementById('hiddenRow').style.display = '';
+}
+/script
+/head
+body
+diva href="" REGRESSION(r120832): RenderLayer::clampScrollOffset doesn't properly clamp/div
+divManual test: click on the menu below and lt;selectgt; the 'shown' option. Click somewhere on the page so that the lt;selectgt; loses focus and click again on the lt;selectgt;./div
+divTo pass the menu should be properly placed below the lt;selectgt;./div
+form name=teste
+table
+tr
+thTest select:/th
+td
+select _onchange_=onSelectionChange(this)
+option value=0hidden/option
+option value=1shown/option
+/select
+/td
+/tr
+tr id=hiddenRow style=display: none;
+thLorem ipsum/th
+tddolor sic amet./td
+/tr
+/table
+/form
+/body
+/html
Property changes on: trunk/ManualTests/select-menu-list-wrongly-positioned.html
___
Added: svn:executable
Modified: trunk/Source/WebCore/ChangeLog (127519 => 127520)
--- trunk/Source/WebCore/ChangeLog 2012-09-04 23:34:22 UTC (rev 127519)
+++ trunk/Source/WebCore/ChangeLog 2012-09-04 23:39:00 UTC (rev 127520)
@@ -1,3 +1,19 @@
+2012-09-04 Julien Chaffraix jchaffr...@webkit.org
+
+REGRESSION(r120832): RenderLayer::clampScrollOffset doesn't properly clamp
+https://bugs.webkit.org/show_bug.cgi?id=95776
+
+Reviewed by Simon Fraser.
+
+r120832 consolidated the clamping logic into RenderLayer::clampScrollOffset. The existing code wouldn't properly ensure that
+the offset were positive which got exposed to other code paths, leading to the regression.
+
+Tested by ManualTests/select-menu-list-wrongly-positioned.html as I didn't find a way to create a reliable layout test.
+
+* rendering/RenderLayer.cpp:
+(WebCore::RenderLayer::clampScrollOffset):
+Fixed the clamping logic to ensure that the scroll offset's dimensions are positive.
+
2012-09-04 Joshua Bell jsb...@chromium.org
IndexedDB: IDBRequest leaks if IDBCursor closes and no further events fired
Modified: trunk/Source/WebCore/rendering/RenderLayer.cpp (127519 => 127520)
--- trunk/Source/WebCore/rendering/RenderLayer.cpp 2012-09-04 23:34:22 UTC (rev 127519)
+++ trunk/Source/WebCore/rendering/RenderLayer.cpp 2012-09-04 23:39:00 UTC (rev 127520)
@@ -1665,8 +1665,8 @@
int maxX = scrollWidth() - box-pixelSnappedClientWidth();
int maxY = scrollHeight() - box-pixelSnappedClientHeight();
-int x = min(max(scrollOffset.width(), 0), maxX);
-int y = min(max(scrollOffset.height(), 0), maxY);
+int x = max(min(scrollOffset.width(), maxX), 0);
+int y = max(min(scrollOffset.height(), maxY), 0);
return IntSize(x, y);
}
[webkit-changes] [127521] tags/Safari-536.26.13/
Title: [127521] tags/Safari-536.26.13/ Revision 127521 Author mr...@apple.com Date 2012-09-04 16:45:39 -0700 (Tue, 04 Sep 2012) Log Message New tag. Added Paths tags/Safari-536.26.13/ Diff Property changes: tags/Safari-536.26.13 Added: svn:ignore depcomp compile config.guess GNUmakefile.in config.sub ltmain.sh aconfig.h.in autom4te.cache missing aclocal.m4 install-sh autotoolsconfig.h.in INSTALL README gtk-doc.make out Makefile.chromium WebKitSupportLibrary.zip WebKitBuild Added: svn:mergeinfo ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [127522] branches/safari-536.26-branch
Title: [127522] branches/safari-536.26-branch Revision 127522 Author mr...@apple.com Date 2012-09-04 16:56:23 -0700 (Tue, 04 Sep 2012) Log Message Merge r127047. Modified Paths branches/safari-536.26-branch/LayoutTests/ChangeLog branches/safari-536.26-branch/Source/WebKit2/ChangeLog branches/safari-536.26-branch/Source/WebKit2/UIProcess/API/mac/WKView.mm branches/safari-536.26-branch/Source/WebKit2/WebProcess/Plugins/Netscape/NetscapePlugin.cpp branches/safari-536.26-branch/Source/WebKit2/WebProcess/Plugins/Netscape/NetscapePlugin.h branches/safari-536.26-branch/Source/WebKit2/WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm branches/safari-536.26-branch/Source/WebKit2/WebProcess/Plugins/PluginView.cpp branches/safari-536.26-branch/Tools/ChangeLog branches/safari-536.26-branch/Tools/DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj Added Paths branches/safari-536.26-branch/LayoutTests/platform/mac-wk2/plugins/npp-setwindow-called-on-scroll-expected.txt branches/safari-536.26-branch/Tools/DumpRenderTree/TestNetscapePlugIn/Tests/LogNPPSetWindow.cpp Diff Modified: branches/safari-536.26-branch/LayoutTests/ChangeLog (127521 => 127522) --- branches/safari-536.26-branch/LayoutTests/ChangeLog 2012-09-04 23:45:39 UTC (rev 127521) +++ branches/safari-536.26-branch/LayoutTests/ChangeLog 2012-09-04 23:56:23 UTC (rev 127522) @@ -1,3 +1,17 @@ +2012-08-31 Timothy Hatcher timo...@apple.com + +Merge r127047. + +2012-08-29 Brady Eidson beid...@apple.com + +REGRESSION: Not sending NPP_SetWindow is causing Flash to not throttle itself +rdar://problem/12133021 and https://bugs.webkit.org/show_bug.cgi?id=95274 + +Reviewed by Sam Weinig. + +* platform/mac-wk2/plugins/npp-setwindow-called-on-scroll-expected.txt: Added. +* platform/mac-wk2/plugins/npp-setwindow-called-on-scroll.html: Added. + 2012-09-04 Lucas Forschler lforsch...@apple.com Rollout r127252. Added: branches/safari-536.26-branch/LayoutTests/platform/mac-wk2/plugins/npp-setwindow-called-on-scroll-expected.txt (0 => 127522) --- branches/safari-536.26-branch/LayoutTests/platform/mac-wk2/plugins/npp-setwindow-called-on-scroll-expected.txt (rev 0) +++ branches/safari-536.26-branch/LayoutTests/platform/mac-wk2/plugins/npp-setwindow-called-on-scroll-expected.txt 2012-09-04 23:56:23 UTC (rev 127522) @@ -0,0 +1,15 @@ +a div + +another div +Tests that netscape plugins get appropriate calls to NPP_SetWindow when scrolled out of view or back in to view. + +On success, you will see a series of PASS messages, followed by TEST COMPLETE. + + +PASS NPP_SetWindow called with expected parameters +PASS NPP_SetWindow called with expected parameters +PASS NPP_SetWindow called with expected parameters +PASS NPP_SetWindow called with expected parameters +PASS NPP_SetWindow called with expected parameters +PASS NPP_SetWindow called with expected parameters + Modified: branches/safari-536.26-branch/Source/WebKit2/ChangeLog (127521 => 127522) --- branches/safari-536.26-branch/Source/WebKit2/ChangeLog 2012-09-04 23:45:39 UTC (rev 127521) +++ branches/safari-536.26-branch/Source/WebKit2/ChangeLog 2012-09-04 23:56:23 UTC (rev 127522) @@ -1,3 +1,32 @@ +2012-08-31 Timothy Hatcher timo...@apple.com + +Merge r127047. + +2012-08-29 Brady Eidson beid...@apple.com + +REGRESSION: Not sending NPP_SetWindow is causing Flash to not throttle itself +rdar://problem/12133021 and https://bugs.webkit.org/show_bug.cgi?id=95274 + +Reviewed by Sam Weinig. + +* UIProcess/API/mac/WKView.mm: +(-[WKView viewDidMoveToWindow]): Previously we'd only update window visibility when the window is hidden. + Now we also update window visibility when the window is shown. + +* WebProcess/Plugins/Netscape/NetscapePlugin.cpp: +(WebKit::NetscapePlugin::callSetWindowInvisible): Call set window with a manufactured empty clip rect to tell + the plug-in that it is complete hidden. +(WebKit): +* WebProcess/Plugins/Netscape/NetscapePlugin.h: +(NetscapePlugin): +* WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm: +(WebKit::NetscapePlugin::windowVisibilityChanged): Call callSetWindow or callSetWindowInvisible as appropriate. + +* WebProcess/Plugins/PluginView.cpp: +(WebKit::PluginView::setWindowIsVisible): Tell the plugin that its visibility changed. +(WebKit::PluginView::viewGeometryDidChange): Grab a clip rect that - although incorrect - at least is correct if + the PluginView is completely hidden. + 2012-09-04 Lucas Forschler lforsch...@apple.com Rollout r127252. Modified: branches/safari-536.26-branch/Source/WebKit2/UIProcess/API/mac/WKView.mm (127521 => 127522) --- branches/safari-536.26-branch/Source/WebKit2/UIProcess/API/mac/WKView.mm 2012-09-04 23:45:39 UTC (rev 127521) +++
[webkit-changes] [127523] branches/safari-536.26-branch/Source/WebKit2
Title: [127523] branches/safari-536.26-branch/Source/WebKit2
Revision 127523
Author mr...@apple.com
Date 2012-09-04 16:56:28 -0700 (Tue, 04 Sep 2012)
Log Message
Merge r127272.
Modified Paths
branches/safari-536.26-branch/Source/WebKit2/ChangeLog
branches/safari-536.26-branch/Source/WebKit2/WebProcess/Plugins/PluginView.cpp
Diff
Modified: branches/safari-536.26-branch/Source/WebKit2/ChangeLog (127522 => 127523)
--- branches/safari-536.26-branch/Source/WebKit2/ChangeLog 2012-09-04 23:56:23 UTC (rev 127522)
+++ branches/safari-536.26-branch/Source/WebKit2/ChangeLog 2012-09-04 23:56:28 UTC (rev 127523)
@@ -1,5 +1,25 @@
2012-08-31 Timothy Hatcher timo...@apple.com
+Merge r127272.
+
+2012-08-31 Brady Eidson beid...@apple.com
+
+REGRESSION (127047): Crash in PluginProxy::windowVisibilityChanged when changing tabs
+rdar://problem/12211180 and https://bugs.webkit.org/show_bug.cgi?id=95515
+
+Reviewed by Dan Bernstein.
+
+Plug-ins created in background tabs don't get initialized until they first become visible,
+so telling them they are now invisible leads to messaging on behalf of an uninitialized plug-in.
+
+Many other methods related to visibility and focus only call through if the plug-in is initialized,
+so setWindowIsVisible should do the same.
+
+* WebProcess/Plugins/PluginView.cpp:
+(WebKit::PluginView::setWindowIsVisible): Only tell initialized plug-ins of window visibility changes.
+
+2012-08-31 Timothy Hatcher timo...@apple.com
+
Merge r127047.
2012-08-29 Brady Eidson beid...@apple.com
Modified: branches/safari-536.26-branch/Source/WebKit2/WebProcess/Plugins/PluginView.cpp (127522 => 127523)
--- branches/safari-536.26-branch/Source/WebKit2/WebProcess/Plugins/PluginView.cpp 2012-09-04 23:56:23 UTC (rev 127522)
+++ branches/safari-536.26-branch/Source/WebKit2/WebProcess/Plugins/PluginView.cpp 2012-09-04 23:56:28 UTC (rev 127523)
@@ -401,7 +401,7 @@
#if PLATFORM(MAC)
void PluginView::setWindowIsVisible(bool windowIsVisible)
{
-if (!m_plugin)
+if (!m_isInitialized || !m_plugin)
return;
m_plugin-windowVisibilityChanged(windowIsVisible);
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [127524] branches/safari-536.26-branch/Source/WebKit2
Title: [127524] branches/safari-536.26-branch/Source/WebKit2
Revision 127524
Author mr...@apple.com
Date 2012-09-04 16:56:32 -0700 (Tue, 04 Sep 2012)
Log Message
Merge r127319.
Modified Paths
branches/safari-536.26-branch/Source/WebKit2/ChangeLog
branches/safari-536.26-branch/Source/WebKit2/WebProcess/Plugins/PluginView.cpp
Diff
Modified: branches/safari-536.26-branch/Source/WebKit2/ChangeLog (127523 => 127524)
--- branches/safari-536.26-branch/Source/WebKit2/ChangeLog 2012-09-04 23:56:28 UTC (rev 127523)
+++ branches/safari-536.26-branch/Source/WebKit2/ChangeLog 2012-09-04 23:56:32 UTC (rev 127524)
@@ -1,5 +1,20 @@
2012-08-31 Timothy Hatcher timo...@apple.com
+Merge r127319.
+
+2012-08-31 Brady Eidson beid...@apple.com
+
+ REGRESSION (r127252): incomplete repaint on Flash element after pinch to zoom
+ rdar://problem/12217897 and https://bugs.webkit.org/show_bug.cgi?id=95607
+
+ Reviewed by Simon Fraser.
+
+ * WebProcess/Plugins/PluginView.cpp:
+ (WebKit::PluginView::viewGeometryDidChange): Only give the window coordinate clip rect a chance
+ to override the boundsRect() if the page scale factor is 1.
+
+2012-08-31 Timothy Hatcher timo...@apple.com
+
Merge r127272.
2012-08-31 Brady Eidson beid...@apple.com
Modified: branches/safari-536.26-branch/Source/WebKit2/WebProcess/Plugins/PluginView.cpp (127523 => 127524)
--- branches/safari-536.26-branch/Source/WebKit2/WebProcess/Plugins/PluginView.cpp 2012-09-04 23:56:28 UTC (rev 127523)
+++ branches/safari-536.26-branch/Source/WebKit2/WebProcess/Plugins/PluginView.cpp 2012-09-04 23:56:32 UTC (rev 127524)
@@ -756,13 +756,19 @@
transform.translate(scaledLocationInRootViewCoordinates.x(), scaledLocationInRootViewCoordinates.y());
transform.scale(pageScaleFactor);
-// FIXME: This clip rect isn't correct.
-// But it is still important distinguish between empty and non-empty rects so we can notify the plug-in when it becomes invisible.
+// FIXME: The way we calculate this clip rect isn't correct.
+// But it is still important to distinguish between empty and non-empty rects so we can notify the plug-in when it becomes invisible.
// Making the rect actually correct is covered by https://bugs.webkit.org/show_bug.cgi?id=95362
-IntRect clipRect = clipRectInWindowCoordinates();
-if (!clipRect.isEmpty())
-clipRect = boundsRect();
-
+IntRect clipRect = boundsRect();
+
+// FIXME: We can only get a semi-reliable answer from clipRectInWindowCoordinates() when the page is not scaled.
+// Fixing that is tracked in rdar://problem/9026611 - Make the Widget hierarchy play nicely with transforms, for zoomed plug-ins and iframes
+if (pageScaleFactor == 1) {
+clipRect = clipRectInWindowCoordinates();
+if (!clipRect.isEmpty())
+clipRect = boundsRect();
+}
+
m_plugin-geometryDidChange(size(), clipRect, transform);
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [127525] trunk/Source
Title: [127525] trunk/Source Revision 127525 Author wei...@apple.com Date 2012-09-04 16:58:01 -0700 (Tue, 04 Sep 2012) Log Message Part 1 of removing PlatformString.h, move remaining functions to new homes https://bugs.webkit.org/show_bug.cgi?id=95702 Reviewed by Beth Dakin. Source/WebCore: Move utf8Buffer() to SharedBuffer.h/cpp Move numGraphemeClusters() and numCharactersInGraphemeClusters() to TextBreakIterator.h/cpp * CMakeLists.txt: * GNUmakefile.list.am: * Target.pri: * WebCore.gypi: * WebCore.vcproj/WebCore.vcproj: * WebCore.xcodeproj/project.pbxproj: Update projects. * platform/text/TextAllInOne.cpp: Add TextBreakIterator.cpp. * editing/Editor.h: Forward declare SharedBuffer, now that PlatformString.h doesn't. * html/InputType.cpp: #include TextBreakIterator.h. * loader/appcache/ApplicationCacheStorage.h: Replace inclusion of PlatformString.h with WTFString.h and forward declare SharedBuffer. * platform/LocalizedStrings.cpp: Replace inclusion of PlatformString.h with TextBreakIterator.h * platform/SharedBuffer.cpp: * platform/SharedBuffer.h: Move utf8Buffer() here. * platform/text/PlatformString.h: Remove everything except the #include of WTFString.h. * platform/text/TextBreakIterator.cpp: Renamed from Source/WebCore/platform/text/String.cpp. (WebCore::numGraphemeClusters): (WebCore::numCharactersInGraphemeClusters): * platform/text/TextBreakIterator.h: Move numGraphemeClusters() and numCharactersInGraphemeClusters() here. Source/WebKit2: * UIProcess/WebPageProxy.h: Forward declare SharedBuffer. Modified Paths trunk/Source/WebCore/CMakeLists.txt trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/GNUmakefile.list.am trunk/Source/WebCore/Target.pri trunk/Source/WebCore/WebCore.gypi trunk/Source/WebCore/WebCore.vcproj/WebCore.vcproj trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj trunk/Source/WebCore/editing/Editor.h trunk/Source/WebCore/html/InputType.cpp trunk/Source/WebCore/html/shadow/DateTimeSymbolicFieldElement.cpp trunk/Source/WebCore/loader/appcache/ApplicationCacheStorage.h trunk/Source/WebCore/platform/LocalizedStrings.cpp trunk/Source/WebCore/platform/SharedBuffer.cpp trunk/Source/WebCore/platform/SharedBuffer.h trunk/Source/WebCore/platform/text/PlatformString.h trunk/Source/WebCore/platform/text/TextAllInOne.cpp trunk/Source/WebCore/platform/text/TextBreakIterator.h trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/UIProcess/WebPageProxy.h Added Paths trunk/Source/WebCore/platform/text/TextBreakIterator.cpp Removed Paths trunk/Source/WebCore/platform/text/String.cpp Diff Modified: trunk/Source/WebCore/CMakeLists.txt (127524 => 127525) --- trunk/Source/WebCore/CMakeLists.txt 2012-09-04 23:56:32 UTC (rev 127524) +++ trunk/Source/WebCore/CMakeLists.txt 2012-09-04 23:58:01 UTC (rev 127525) @@ -1988,8 +1988,8 @@ platform/text/QuotedPrintable.cpp platform/text/RegularExpression.cpp platform/text/SegmentedString.cpp -platform/text/String.cpp platform/text/TextBoundaries.cpp +platform/text/TextBreakIterator.cpp platform/text/TextCodec.cpp platform/text/TextCodecLatin1.cpp platform/text/TextCodecUTF16.cpp Modified: trunk/Source/WebCore/ChangeLog (127524 => 127525) --- trunk/Source/WebCore/ChangeLog 2012-09-04 23:56:32 UTC (rev 127524) +++ trunk/Source/WebCore/ChangeLog 2012-09-04 23:58:01 UTC (rev 127525) @@ -1,3 +1,49 @@ +2012-09-03 Sam Weinig s...@webkit.org + +Part 1 of removing PlatformString.h, move remaining functions to new homes +https://bugs.webkit.org/show_bug.cgi?id=95702 + +Reviewed by Beth Dakin. + +Move utf8Buffer() to SharedBuffer.h/cpp +Move numGraphemeClusters() and numCharactersInGraphemeClusters() to TextBreakIterator.h/cpp + +* CMakeLists.txt: +* GNUmakefile.list.am: +* Target.pri: +* WebCore.gypi: +* WebCore.vcproj/WebCore.vcproj: +* WebCore.xcodeproj/project.pbxproj: +Update projects. + +* platform/text/TextAllInOne.cpp: +Add TextBreakIterator.cpp. + +* editing/Editor.h: +Forward declare SharedBuffer, now that PlatformString.h doesn't. + +* html/InputType.cpp: +#include TextBreakIterator.h. + +* loader/appcache/ApplicationCacheStorage.h: +Replace inclusion of PlatformString.h with WTFString.h and forward declare SharedBuffer. + +* platform/LocalizedStrings.cpp: +Replace inclusion of PlatformString.h with TextBreakIterator.h + +* platform/SharedBuffer.cpp: +* platform/SharedBuffer.h: +Move utf8Buffer() here. + +* platform/text/PlatformString.h: +Remove everything except the #include of WTFString.h. + +* platform/text/TextBreakIterator.cpp: Renamed from Source/WebCore/platform/text/String.cpp. +(WebCore::numGraphemeClusters): +(WebCore::numCharactersInGraphemeClusters): +* platform/text/TextBreakIterator.h: +Move
[webkit-changes] [127526] trunk/Source/Platform
Title: [127526] trunk/Source/Platform Revision 127526 Author ba...@chromium.org Date 2012-09-04 17:07:58 -0700 (Tue, 04 Sep 2012) Log Message [Chromium] Attempt to fix build failure on Win Remove chromium/public/WebOfferAnswerRequest.h from Platform.gypi, which was added in r127501, but doesn't exist. Unreviewed. * Platform.gypi: Modified Paths trunk/Source/Platform/ChangeLog trunk/Source/Platform/Platform.gypi Diff Modified: trunk/Source/Platform/ChangeLog (127525 => 127526) --- trunk/Source/Platform/ChangeLog 2012-09-04 23:58:01 UTC (rev 127525) +++ trunk/Source/Platform/ChangeLog 2012-09-05 00:07:58 UTC (rev 127526) @@ -1,3 +1,12 @@ +2012-09-04 Kenichi Ishibashi ba...@chromium.org + +[Chromium] Attempt to fix build failure on Win + +Remove chromium/public/WebOfferAnswerRequest.h from Platform.gypi, +which was added in r127501, but doesn't exist. Unreviewed. + +* Platform.gypi: + 2012-09-04 Tommy Widenflycht tom...@google.com MediaStream API: Add the async createOffer functionality to RTCPeerConnection Modified: trunk/Source/Platform/Platform.gypi (127525 => 127526) --- trunk/Source/Platform/Platform.gypi 2012-09-04 23:58:01 UTC (rev 127525) +++ trunk/Source/Platform/Platform.gypi 2012-09-05 00:07:58 UTC (rev 127526) @@ -94,7 +94,6 @@ 'chromium/public/WebMessagePortChannelClient.h', 'chromium/public/WebMimeRegistry.h', 'chromium/public/WebNonCopyable.h', -'chromium/public/WebOfferAnswerRequest.h', 'chromium/public/WebPeerConnection00Handler.h', 'chromium/public/WebPeerConnection00HandlerClient.h', 'chromium/public/WebPeerConnectionHandler.h', ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [127527] trunk/LayoutTests
Title: [127527] trunk/LayoutTests
Revision 127527
Author roger_f...@apple.com
Date 2012-09-04 17:09:06 -0700 (Tue, 04 Sep 2012)
Log Message
Unreviewed. Rebaseline tests after http://trac.webkit.org/changeset/127354.
* platform/win/fast/text/international/text-spliced-font-expected.txt:
* platform/win/fast/writing-mode/border-vertical-lr-expected.txt:
* platform/win/fast/writing-mode/japanese-lr-selection-expected.txt:
* platform/win/fast/writing-mode/japanese-lr-text-expected.txt:
* platform/win/fast/writing-mode/japanese-rl-selection-expected.txt:
* platform/win/fast/writing-mode/japanese-rl-text-expected.txt:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/win/fast/text/international/text-spliced-font-expected.txt
trunk/LayoutTests/platform/win/fast/writing-mode/border-vertical-lr-expected.txt
trunk/LayoutTests/platform/win/fast/writing-mode/japanese-lr-selection-expected.txt
trunk/LayoutTests/platform/win/fast/writing-mode/japanese-lr-text-expected.txt
trunk/LayoutTests/platform/win/fast/writing-mode/japanese-rl-selection-expected.txt
trunk/LayoutTests/platform/win/fast/writing-mode/japanese-rl-text-expected.txt
Diff
Modified: trunk/LayoutTests/ChangeLog (127526 => 127527)
--- trunk/LayoutTests/ChangeLog 2012-09-05 00:07:58 UTC (rev 127526)
+++ trunk/LayoutTests/ChangeLog 2012-09-05 00:09:06 UTC (rev 127527)
@@ -1,5 +1,16 @@
2012-09-04 Roger Fong roger_f...@apple.com
+Unreviewed. Rebaseline tests after http://trac.webkit.org/changeset/127354.
+
+* platform/win/fast/text/international/text-spliced-font-expected.txt:
+* platform/win/fast/writing-mode/border-vertical-lr-expected.txt:
+* platform/win/fast/writing-mode/japanese-lr-selection-expected.txt:
+* platform/win/fast/writing-mode/japanese-lr-text-expected.txt:
+* platform/win/fast/writing-mode/japanese-rl-selection-expected.txt:
+* platform/win/fast/writing-mode/japanese-rl-text-expected.txt:
+
+2012-09-04 Roger Fong roger_f...@apple.com
+
Unreviewed gardening. editing/style/apply-style-atomic.html fails on Windows since introduced in http://trac.webkit.org/changeset/126865.
Test added to skip list.
Modified: trunk/LayoutTests/platform/win/fast/text/international/text-spliced-font-expected.txt (127526 => 127527)
--- trunk/LayoutTests/platform/win/fast/text/international/text-spliced-font-expected.txt 2012-09-05 00:07:58 UTC (rev 127526)
+++ trunk/LayoutTests/platform/win/fast/text/international/text-spliced-font-expected.txt 2012-09-05 00:09:06 UTC (rev 127527)
@@ -1,44 +1,44 @@
layer at (0,0) size 800x600
RenderView at (0,0) size 800x600
-layer at (0,0) size 800x464
- RenderBlock {HTML} at (0,0) size 800x464
-RenderBody {BODY} at (8,16) size 784x440
- RenderBlock {P} at (0,0) size 784x18
-RenderText {#text} at (0,0) size 110x18
- text run at (0,0) width 110: Simple text path:
-RenderInline {SPAN} at (0,0) size 133x18
- RenderText {#text} at (110,0) size 133x18
-text run at (110,0) width 133: string\x{300C}\x{3042}\x{3001}\x{5909}\x{3063}\x{FF01}\x{300D}\x{3002}
- RenderBlock (anonymous) at (0,34) size 784x173
-RenderBlock {SPAN} at (0,0) size 18x133
- RenderText {#text} at (0,0) size 18x133
-text run at (0,0) width 133: string\x{300C}\x{3042}\x{3001}\x{5909}\x{3063}\x{FF01}\x{300D}\x{3002}
-RenderBR {BR} at (18,119) size 0x18
-RenderInline {SPAN} at (0,0) size 206x18
- RenderText {#text} at (0,137) size 206x18
-text run at (0,137) width 206: \x{90CA}\x{5916}\x{306E}\x{304E}\x{3089}\x{304E}\x{3089}\x{3072}\x{304B}\x{308B}\x{8349}\x{306E}\x{6CE2}\x{3002}
-RenderBR {BR} at (206,137) size 0x18
-RenderInline {SPAN} at (0,0) size 314x18
- RenderText {#text} at (0,155) size 314x18
-text run at (0,155) width 314: ABCDEFGHIJKLM abcdefghijklm 1234567890
-RenderBR {BR} at (314,155) size 0x18
- RenderBlock {HR} at (0,215) size 784x2 [border: (1px inset #00)]
- RenderBlock {P} at (0,233) size 784x18
-RenderText {#text} at (0,0) size 124x18
- text run at (0,0) width 124: Complex text path:
-RenderInline {SPAN} at (0,0) size 133x18
- RenderText {#text} at (124,0) size 133x18
-text run at (124,0) width 133: string\x{300C}\x{3042}\x{3001}\x{5909}\x{3063}\x{FF01}\x{300D}\x{3002}
- RenderBlock (anonymous) at (0,267) size 784x173
-RenderBlock {SPAN} at (0,0) size 18x133
- RenderText {#text} at (0,0) size 18x133
-text run at (0,0) width 133: string\x{300C}\x{3042}\x{3001}\x{5909}\x{3063}\x{FF01}\x{300D}\x{3002}
-RenderBR {BR} at (18,119) size 0x18
-RenderInline {SPAN} at (0,0) size 206x18
- RenderText {#text} at (0,137) size 206x18
-text run at (0,137) width 206:
[webkit-changes] [127528] branches/safari-536.26-branch/Tools/DumpRenderTree/DumpRenderTree. xcodeproj/project.pbxproj
Title: [127528] branches/safari-536.26-branch/Tools/DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj
Revision 127528
Author mr...@apple.com
Date 2012-09-04 17:18:17 -0700 (Tue, 04 Sep 2012)
Log Message
Build fix.
Modified Paths
branches/safari-536.26-branch/Tools/DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj
Diff
Modified: branches/safari-536.26-branch/Tools/DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj (127527 => 127528)
--- branches/safari-536.26-branch/Tools/DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj 2012-09-05 00:09:06 UTC (rev 127527)
+++ branches/safari-536.26-branch/Tools/DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj 2012-09-05 00:18:17 UTC (rev 127528)
@@ -71,7 +71,6 @@
515F429C15C07872007C8F90 /* PluginScriptableObjectOverridesAllProperties.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 515F429B15C07872007C8F90 /* PluginScriptableObjectOverridesAllProperties.cpp */; };
5185F6B210714E07007AA393 /* HistoryDelegate.mm in Sources */ = {isa = PBXBuildFile; fileRef = 5185F69F10714A57007AA393 /* HistoryDelegate.mm */; };
5185F6B310714E12007AA393 /* HistoryDelegate.h in Headers */ = {isa = PBXBuildFile; fileRef = 5185F69E10714A57007AA393 /* HistoryDelegate.h */; };
- 515C0CD015EE785700F5A613 /* LogNPPSetWindow.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 515C0CCF15EE785700F5A613 /* LogNPPSetWindow.cpp */; };
53CBB832134E42F3001CE6A4 /* CyclicRedundancyCheck.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 53CBB830134E42F3001CE6A4 /* CyclicRedundancyCheck.cpp */; };
53CBB833134E42F3001CE6A4 /* CyclicRedundancyCheck.h in Headers */ = {isa = PBXBuildFile; fileRef = 53CBB831134E42F3001CE6A4 /* CyclicRedundancyCheck.h */; };
5DB9AC970F722C3600684641 /* AHEM.TTF in Copy Font Files */ = {isa = PBXBuildFile; fileRef = AA7F10C20CB3C1030003BDC9 /* AHEM.TTF */; };
@@ -288,7 +287,6 @@
A803FF7409CAAD08009B2A37 /* DumpRenderTree.h */ = {isa = PBXFileReference; explicitFileType = sourcecode.cpp.h; fileEncoding = 4; path = DumpRenderTree.h; sourceTree = group; };
A817090308B164D300CCB9FB /* _javascript_Core.framework */ = {isa = PBXFileReference; lastKnownFileType = wrapper.framework; path = _javascript_Core.framework; sourceTree = BUILT_PRODUCTS_DIR; };
A84F608908B136DA00E9745F /* Cocoa.framework */ = {isa = PBXFileReference; lastKnownFileType = wrapper.framework; name = Cocoa.framework; path = /System/Library/Frameworks/Cocoa.framework; sourceTree = absolute; };
- 515C0CCF15EE785700F5A613 /* LogNPPSetWindow.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = LogNPPSetWindow.cpp; sourceTree = group; };
A8B91AD70CF3B32F008F91FF /* DumpRenderTreePasteboard.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; name = DumpRenderTreePasteboard.m; path = mac/DumpRenderTreePasteboard.m; sourceTree = group; };
A8B91AD90CF3B32F008F91FF /* DumpRenderTreeWindow.mm */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.objcpp; name = DumpRenderTreeWindow.mm; path = mac/DumpRenderTreeWindow.mm; sourceTree = group; };
A8B91ADD0CF3B372008F91FF /* DumpRenderTreeWindow.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; name = DumpRenderTreeWindow.h; path = mac/DumpRenderTreeWindow.h; sourceTree = group; };
@@ -902,7 +900,6 @@
};
2D403ED8150871F9005358D2 /* Sources */ = {
isa = PBXSourcesBuildPhase;
-515C0CD015EE785700F5A613 /* LogNPPSetWindow.cpp in Sources */,
buildActionMask = 2147483647;
files = (
2D403F1B15087209005358D2 /* LayoutTestHelper.m in Sources */,
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [127530] tags/Safari-536.26.13/
Title: [127530] tags/Safari-536.26.13/ Revision 127530 Author mr...@apple.com Date 2012-09-04 17:21:43 -0700 (Tue, 04 Sep 2012) Log Message New tag. Added Paths tags/Safari-536.26.13/ Diff Property changes: tags/Safari-536.26.13 Added: svn:ignore depcomp compile config.guess GNUmakefile.in config.sub ltmain.sh aconfig.h.in autom4te.cache missing aclocal.m4 install-sh autotoolsconfig.h.in INSTALL README gtk-doc.make out Makefile.chromium WebKitSupportLibrary.zip WebKitBuild Added: svn:mergeinfo ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [127529] tags/Safari-536.26.13/
Title: [127529] tags/Safari-536.26.13/ Revision 127529 Author mr...@apple.com Date 2012-09-04 17:21:30 -0700 (Tue, 04 Sep 2012) Log Message Remove tag. Removed Paths tags/Safari-536.26.13/ Diff ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [127532] trunk/LayoutTests
Title: [127532] trunk/LayoutTests Revision 127532 Author roger_f...@apple.com Date 2012-09-04 17:25:17 -0700 (Tue, 04 Sep 2012) Log Message Unreviewed. Adding test inspector/timeline/timeline-decode-resize.html to Windows skip list. It fails on both Windows and Mac: https://bugs.webkit.org/show_bug.cgi?id=94374. * platform/win/Skipped: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/win/Skipped Diff Modified: trunk/LayoutTests/ChangeLog (127531 => 127532) --- trunk/LayoutTests/ChangeLog 2012-09-05 00:23:05 UTC (rev 127531) +++ trunk/LayoutTests/ChangeLog 2012-09-05 00:25:17 UTC (rev 127532) @@ -1,5 +1,12 @@ 2012-09-04 Roger Fong roger_f...@apple.com +Unreviewed. Adding test inspector/timeline/timeline-decode-resize.html to Windows skip list. +It fails on both Windows and Mac: https://bugs.webkit.org/show_bug.cgi?id=94374. + +* platform/win/Skipped: + +2012-09-04 Roger Fong roger_f...@apple.com + Unreviewed. Rebaseline tests after http://trac.webkit.org/changeset/127354. * platform/win/fast/text/international/text-spliced-font-expected.txt: Modified: trunk/LayoutTests/platform/win/Skipped (127531 => 127532) --- trunk/LayoutTests/platform/win/Skipped 2012-09-05 00:23:05 UTC (rev 127531) +++ trunk/LayoutTests/platform/win/Skipped 2012-09-05 00:25:17 UTC (rev 127532) @@ -2168,3 +2168,6 @@ # https://bugs.webkit.org/show_bug.cgi?id=95795 editing/style/apply-style-atomic.html + +# https://bugs.webkit.org/show_bug.cgi?id=94374 +inspector/timeline/timeline-decode-resize.html ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [127533] trunk/LayoutTests
Title: [127533] trunk/LayoutTests Revision 127533 Author ba...@chromium.org Date 2012-09-04 17:28:47 -0700 (Tue, 04 Sep 2012) Log Message [Chromium] Unreviewed test expectation update after r127457 * platform/chromium/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (127532 => 127533) --- trunk/LayoutTests/ChangeLog 2012-09-05 00:25:17 UTC (rev 127532) +++ trunk/LayoutTests/ChangeLog 2012-09-05 00:28:47 UTC (rev 127533) @@ -1,3 +1,9 @@ +2012-09-04 Kenichi Ishibashi ba...@chromium.org + +[Chromium] Unreviewed test expectation update after r127457 + +* platform/chromium/TestExpectations: + 2012-09-04 Roger Fong roger_f...@apple.com Unreviewed. Adding test inspector/timeline/timeline-decode-resize.html to Windows skip list. Modified: trunk/LayoutTests/platform/chromium/TestExpectations (127532 => 127533) --- trunk/LayoutTests/platform/chromium/TestExpectations 2012-09-05 00:25:17 UTC (rev 127532) +++ trunk/LayoutTests/platform/chromium/TestExpectations 2012-09-05 00:28:47 UTC (rev 127533) @@ -3618,3 +3618,7 @@ BUGCR146401 ANDROID : css3/filters/custom/effect-custom-transform-parameters.html = IMAGE BUGCR146401 ANDROID : css3/filters/custom/filter-fallback-to-software.html = IMAGE BUGCR146401 ANDROID : fast/css/sticky/sticky-writing-mode-vertical-lr.html = IMAGE + +// Started failing after r127457 +BUGWK95799 MAC : touchadjustment/iframe-boundary.html = TEXT + ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [127534] trunk
Title: [127534] trunk Revision 127534 Author commit-qu...@webkit.org Date 2012-09-04 17:40:07 -0700 (Tue, 04 Sep 2012) Log Message Frame element doesn't always unload its child frame. https://bugs.webkit.org/show_bug.cgi?id=94717 Patch by Sergey Glazunov serg.glazu...@gmail.com on 2012-09-04 Reviewed by Hajime Morita. Source/WebCore: It's possible for a frame element that has been removed from the document to retain an active child frame. This inconsistent state may become a source of security vulnerabilities. The patch adds a global HashSet to store the nodes currently processed by ChildFrameDisconnector. Insertion into these nodes' subtrees is not allowed until the processing is complete. Also, the ChildFrameDisconnector call in removeChild(ren) is now immediately followed by the actual removal. Test: fast/frames/out-of-document-iframe-has-child-frame.html * dom/ContainerNode.cpp: (WebCore::willRemoveChildren): Move the ChildFrameDisconnector call out of a loop. (WebCore::ContainerNode::removeChild): Rearrange some event firing code. (WebCore::ContainerNode::removeChildren): Ditto. * dom/ContainerNodeAlgorithms.cpp: (WebCore::ChildFrameDisconnector::collectDescendant): Pass a new parameter to collectDescendant(Node*). * dom/ContainerNodeAlgorithms.h: (WebCore::ChildFrameDisconnector::ChildFrameDisconnector): (ChildFrameDisconnector): Maintain a list of nodes that have an active ChildFrameDisconnector. (WebCore::ChildFrameDisconnector::~ChildFrameDisconnector): (WebCore::ChildFrameDisconnector::rootNodes): (WebCore::ChildFrameDisconnector::collectDescendant): Add ShouldIncludeRoot parameter. (WebCore::ChildFrameDisconnector::nodeHasDisconnector): (WebCore): * dom/Node.cpp: (WebCore::checkAcceptChild): Reject a parent node if it or one of its parents has an active ChildFrameDisconnector. * html/HTMLFrameElementBase.cpp: (WebCore::HTMLFrameElementBase::didNotifySubtreeInsertions): Check if an element is still in the document. LayoutTests: * fast/frames/out-of-document-iframe-has-child-frame-expected.txt: Added. * fast/frames/out-of-document-iframe-has-child-frame.html: Added. * fast/innerHTML/innerHTML-iframe-expected.txt: * platform/chromium/fast/frames/out-of-document-iframe-has-child-frame-expected.txt: Added. * platform/chromium/fast/innerHTML: Added. * platform/chromium/fast/innerHTML/innerHTML-iframe-expected.txt: Added. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/fast/innerHTML/innerHTML-iframe-expected.txt trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/dom/ContainerNode.cpp trunk/Source/WebCore/dom/ContainerNodeAlgorithms.cpp trunk/Source/WebCore/dom/ContainerNodeAlgorithms.h trunk/Source/WebCore/dom/Node.cpp trunk/Source/WebCore/html/HTMLFrameElementBase.cpp Added Paths trunk/LayoutTests/fast/frames/out-of-document-iframe-has-child-frame-expected.txt trunk/LayoutTests/fast/frames/out-of-document-iframe-has-child-frame.html trunk/LayoutTests/platform/chromium/fast/frames/out-of-document-iframe-has-child-frame-expected.txt trunk/LayoutTests/platform/chromium/fast/innerHTML/ trunk/LayoutTests/platform/chromium/fast/innerHTML/innerHTML-iframe-expected.txt Diff Modified: trunk/LayoutTests/ChangeLog (127533 => 127534) --- trunk/LayoutTests/ChangeLog 2012-09-05 00:28:47 UTC (rev 127533) +++ trunk/LayoutTests/ChangeLog 2012-09-05 00:40:07 UTC (rev 127534) @@ -1,3 +1,17 @@ +2012-09-04 Sergey Glazunov serg.glazu...@gmail.com + +Frame element doesn't always unload its child frame. +https://bugs.webkit.org/show_bug.cgi?id=94717 + +Reviewed by Hajime Morita. + +* fast/frames/out-of-document-iframe-has-child-frame-expected.txt: Added. +* fast/frames/out-of-document-iframe-has-child-frame.html: Added. +* fast/innerHTML/innerHTML-iframe-expected.txt: +* platform/chromium/fast/frames/out-of-document-iframe-has-child-frame-expected.txt: Added. +* platform/chromium/fast/innerHTML: Added. +* platform/chromium/fast/innerHTML/innerHTML-iframe-expected.txt: Added. + 2012-09-04 Kenichi Ishibashi ba...@chromium.org [Chromium] Unreviewed test expectation update after r127457 Added: trunk/LayoutTests/fast/frames/out-of-document-iframe-has-child-frame-expected.txt (0 => 127534) --- trunk/LayoutTests/fast/frames/out-of-document-iframe-has-child-frame-expected.txt (rev 0) +++ trunk/LayoutTests/fast/frames/out-of-document-iframe-has-child-frame-expected.txt 2012-09-05 00:40:07 UTC (rev 127534) @@ -0,0 +1,13 @@ +CONSOLE MESSAGE: line 19: NO_MODIFICATION_ALLOWED_ERR: DOM Exception 7: An attempt was made to modify an object where modifications are not allowed. +This tests that several ways of making an iframe that isn't inserted into a document tree but has a child frame will fail. + +On success, you will see a series of PASS messages, followed by TEST COMPLETE. + + +PASS targetFrame1.contentWindow == undefined is true +PASS targetFrame2.contentWindow == undefined is
[webkit-changes] [127535] trunk/Source
Title: [127535] trunk/Source Revision 127535 Author commit-qu...@webkit.org Date 2012-09-04 17:56:25 -0700 (Tue, 04 Sep 2012) Log Message IndexedDB: remove final createIndex backend glue https://bugs.webkit.org/show_bug.cgi?id=95385 Patch by Alec Flett alecfl...@chromium.org on 2012-09-04 Reviewed by Adam Barth. Source/WebCore: Remove all code that created index keys in the IndexedDB backend. No new tests, this is just removal of dead code. * Modules/indexeddb/IDBKeyPathBackendImpl.cpp: Removed. * Modules/indexeddb/IDBKeyPathBackendImpl.h: Removed. * Modules/indexeddb/IDBObjectStoreBackendImpl.cpp: (WebCore): * WebCore.gyp/WebCore.gyp: * WebCore.gypi: * storage/chromium/IDBKeyPathBackendImpl.cpp: Removed. Source/WebKit/chromium: Remove chromium glue for old key-generation code. * public/WebIDBKey.h: (WebIDBKey): * src/WebIDBKey.cpp: Modified Paths trunk/Source/WebCore/CMakeLists.txt trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/GNUmakefile.list.am trunk/Source/WebCore/Modules/indexeddb/IDBObjectStoreBackendImpl.cpp trunk/Source/WebCore/WebCore.gyp/WebCore.gyp trunk/Source/WebCore/WebCore.gypi trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj trunk/Source/WebCore/platform/chromium/PlatformSupport.h trunk/Source/WebKit/chromium/ChangeLog trunk/Source/WebKit/chromium/public/WebIDBKey.h trunk/Source/WebKit/chromium/public/platform/WebKitPlatformSupport.h trunk/Source/WebKit/chromium/src/PlatformSupport.cpp trunk/Source/WebKit/chromium/src/WebIDBKey.cpp Removed Paths trunk/Source/WebCore/Modules/indexeddb/IDBKeyPathBackendImpl.cpp trunk/Source/WebCore/Modules/indexeddb/IDBKeyPathBackendImpl.h trunk/Source/WebCore/storage/chromium/IDBKeyPathBackendImpl.cpp Diff Modified: trunk/Source/WebCore/CMakeLists.txt (127534 => 127535) --- trunk/Source/WebCore/CMakeLists.txt 2012-09-05 00:40:07 UTC (rev 127534) +++ trunk/Source/WebCore/CMakeLists.txt 2012-09-05 00:56:25 UTC (rev 127535) @@ -820,7 +820,6 @@ Modules/indexeddb/IDBKey.cpp Modules/indexeddb/IDBKeyRange.cpp Modules/indexeddb/IDBKeyPath.cpp -Modules/indexeddb/IDBKeyPathBackendImpl.cpp Modules/indexeddb/IDBLevelDBBackingStore.cpp Modules/indexeddb/IDBLevelDBCoding.cpp Modules/indexeddb/IDBObjectStore.cpp Modified: trunk/Source/WebCore/ChangeLog (127534 => 127535) --- trunk/Source/WebCore/ChangeLog 2012-09-05 00:40:07 UTC (rev 127534) +++ trunk/Source/WebCore/ChangeLog 2012-09-05 00:56:25 UTC (rev 127535) @@ -1,3 +1,22 @@ +2012-09-04 Alec Flett alecfl...@chromium.org + +IndexedDB: remove final createIndex backend glue +https://bugs.webkit.org/show_bug.cgi?id=95385 + +Reviewed by Adam Barth. + +Remove all code that created index keys in the IndexedDB backend. + +No new tests, this is just removal of dead code. + +* Modules/indexeddb/IDBKeyPathBackendImpl.cpp: Removed. +* Modules/indexeddb/IDBKeyPathBackendImpl.h: Removed. +* Modules/indexeddb/IDBObjectStoreBackendImpl.cpp: +(WebCore): +* WebCore.gyp/WebCore.gyp: +* WebCore.gypi: +* storage/chromium/IDBKeyPathBackendImpl.cpp: Removed. + 2012-09-04 Sergey Glazunov serg.glazu...@gmail.com Frame element doesn't always unload its child frame. Modified: trunk/Source/WebCore/GNUmakefile.list.am (127534 => 127535) --- trunk/Source/WebCore/GNUmakefile.list.am 2012-09-05 00:40:07 UTC (rev 127534) +++ trunk/Source/WebCore/GNUmakefile.list.am 2012-09-05 00:56:25 UTC (rev 127535) @@ -1849,8 +1849,6 @@ Source/WebCore/Modules/indexeddb/IDBIndex.h \ Source/WebCore/Modules/indexeddb/IDBKey.cpp \ Source/WebCore/Modules/indexeddb/IDBKey.h \ - Source/WebCore/Modules/indexeddb/IDBKeyPathBackendImpl.cpp \ - Source/WebCore/Modules/indexeddb/IDBKeyPathBackendImpl.h \ Source/WebCore/Modules/indexeddb/IDBKeyPath.cpp \ Source/WebCore/Modules/indexeddb/IDBKeyPath.h \ Source/WebCore/Modules/indexeddb/IDBKeyRange.cpp \ Deleted: trunk/Source/WebCore/Modules/indexeddb/IDBKeyPathBackendImpl.cpp (127534 => 127535) --- trunk/Source/WebCore/Modules/indexeddb/IDBKeyPathBackendImpl.cpp 2012-09-05 00:40:07 UTC (rev 127534) +++ trunk/Source/WebCore/Modules/indexeddb/IDBKeyPathBackendImpl.cpp 2012-09-05 00:56:25 UTC (rev 127535) @@ -1,54 +0,0 @@ -/* - * Copyright (C) 2010 Google Inc. All rights reserved. - * - * Redistribution and use in source and binary forms, with or without - * modification, are permitted provided that the following conditions - * are met: - * - * 1. Redistributions of source code must retain the above copyright - * notice, this list of conditions and the following disclaimer. - * 2. Redistributions in binary form must reproduce the above copyright - * notice, this list of conditions and the following disclaimer in the - * documentation and/or other materials provided with the distribution. - * - * THIS SOFTWARE IS PROVIDED BY APPLE AND ITS CONTRIBUTORS AS IS AND ANY - * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT
[webkit-changes] [127536] trunk/Source/JavaScriptCore
Title: [127536] trunk/Source/_javascript_Core
Revision 127536
Author fpi...@apple.com
Date 2012-09-04 18:27:50 -0700 (Tue, 04 Sep 2012)
Log Message
DFG GetByVal for JSArrays shouldn't OSR exit every time that the index is out of bound
https://bugs.webkit.org/show_bug.cgi?id=95717
Reviewed by Oliver Hunt.
Rolling back in after fixing the negative index case.
Make GetByVal for JSArrayOutOfBounds do meaningful things. The profiling was already
there so we should just use it!
* bytecode/DFGExitProfile.h:
(JSC::DFG::exitKindToString):
* dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::execute):
* dfg/DFGOperations.cpp:
* dfg/DFGOperations.h:
* dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::callOperation):
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/bytecode/DFGExitProfile.h
trunk/Source/_javascript_Core/dfg/DFGAbstractState.cpp
trunk/Source/_javascript_Core/dfg/DFGOperations.cpp
trunk/Source/_javascript_Core/dfg/DFGOperations.h
trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.h
trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT32_64.cpp
trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT64.cpp
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (127535 => 127536)
--- trunk/Source/_javascript_Core/ChangeLog 2012-09-05 00:56:25 UTC (rev 127535)
+++ trunk/Source/_javascript_Core/ChangeLog 2012-09-05 01:27:50 UTC (rev 127536)
@@ -1,3 +1,28 @@
+2012-09-04 Filip Pizlo fpi...@apple.com
+
+DFG GetByVal for JSArrays shouldn't OSR exit every time that the index is out of bound
+https://bugs.webkit.org/show_bug.cgi?id=95717
+
+Reviewed by Oliver Hunt.
+
+Rolling back in after fixing the negative index case.
+
+Make GetByVal for JSArrayOutOfBounds do meaningful things. The profiling was already
+there so we should just use it!
+
+* bytecode/DFGExitProfile.h:
+(JSC::DFG::exitKindToString):
+* dfg/DFGAbstractState.cpp:
+(JSC::DFG::AbstractState::execute):
+* dfg/DFGOperations.cpp:
+* dfg/DFGOperations.h:
+* dfg/DFGSpeculativeJIT.h:
+(JSC::DFG::SpeculativeJIT::callOperation):
+* dfg/DFGSpeculativeJIT32_64.cpp:
+(JSC::DFG::SpeculativeJIT::compile):
+* dfg/DFGSpeculativeJIT64.cpp:
+(JSC::DFG::SpeculativeJIT::compile):
+
2012-09-04 Sheriff Bot webkit.review@gmail.com
Unreviewed, rolling out r127503.
Modified: trunk/Source/_javascript_Core/bytecode/DFGExitProfile.h (127535 => 127536)
--- trunk/Source/_javascript_Core/bytecode/DFGExitProfile.h 2012-09-05 00:56:25 UTC (rev 127535)
+++ trunk/Source/_javascript_Core/bytecode/DFGExitProfile.h 2012-09-05 01:27:50 UTC (rev 127536)
@@ -58,6 +58,8 @@
return Overflow;
case NegativeZero:
return NegativeZero;
+case OutOfBounds:
+return OutOfBounds;
case InadequateCoverage:
return InadequateCoverage;
case ArgumentsEscaped:
Modified: trunk/Source/_javascript_Core/dfg/DFGAbstractState.cpp (127535 => 127536)
--- trunk/Source/_javascript_Core/dfg/DFGAbstractState.cpp 2012-09-05 00:56:25 UTC (rev 127535)
+++ trunk/Source/_javascript_Core/dfg/DFGAbstractState.cpp 2012-09-05 01:27:50 UTC (rev 127536)
@@ -853,10 +853,12 @@
forNode(nodeIndex).makeTop();
break;
case Array::JSArray:
+forNode(node.child2()).filter(SpecInt32);
+forNode(nodeIndex).makeTop();
+break;
case Array::JSArrayOutOfBounds:
-// FIXME: We should have more conservative handling of the out-of-bounds
-// case.
forNode(node.child2()).filter(SpecInt32);
+clobberWorld(node.codeOrigin, indexInBlock);
forNode(nodeIndex).makeTop();
break;
case Array::Int8Array:
Modified: trunk/Source/_javascript_Core/dfg/DFGOperations.cpp (127535 => 127536)
--- trunk/Source/_javascript_Core/dfg/DFGOperations.cpp 2012-09-05 00:56:25 UTC (rev 127535)
+++ trunk/Source/_javascript_Core/dfg/DFGOperations.cpp 2012-09-05 01:27:50 UTC (rev 127536)
@@ -409,6 +409,20 @@
return JSValue::encode(JSValue(base).get(exec, ident));
}
+EncodedJSValue DFG_OPERATION operationGetByValArrayInt(ExecState* exec, JSArray* base, int32_t index)
+{
+JSGlobalData* globalData = exec-globalData();
+NativeCallFrameTracer tracer(globalData, exec);
+
+if (index 0) {
+// Go the slowest way possible becase negative indices don't use indexed storage.
+return JSValue::encode(JSValue(base).get(exec, Identifier::from(exec, index)));
+}
+
+// Use this since we know that the value is out of bounds.
+return JSValue::encode(JSValue(base).get(exec, index));
+}
+
EncodedJSValue DFG_OPERATION operationGetById(ExecState* exec,
[webkit-changes] [127537] trunk/LayoutTests
Title: [127537] trunk/LayoutTests Revision 127537 Author roger_f...@apple.com Date 2012-09-04 18:30:55 -0700 (Tue, 04 Sep 2012) Log Message Unreviewed. Some flaky inspector tests on Windows. Adding to skip list. https://bugs.webkit.org/show_bug.cgi?id=95802 * platform/win/Skipped: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/win/Skipped Diff Modified: trunk/LayoutTests/ChangeLog (127536 => 127537) --- trunk/LayoutTests/ChangeLog 2012-09-05 01:27:50 UTC (rev 127536) +++ trunk/LayoutTests/ChangeLog 2012-09-05 01:30:55 UTC (rev 127537) @@ -1,3 +1,10 @@ +2012-09-04 Roger Fong roger_f...@apple.com + +Unreviewed. Some flaky inspector tests on Windows. Adding to skip list. +https://bugs.webkit.org/show_bug.cgi?id=95802 + +* platform/win/Skipped: + 2012-09-04 Sergey Glazunov serg.glazu...@gmail.com Frame element doesn't always unload its child frame. Modified: trunk/LayoutTests/platform/win/Skipped (127536 => 127537) --- trunk/LayoutTests/platform/win/Skipped 2012-09-05 01:27:50 UTC (rev 127536) +++ trunk/LayoutTests/platform/win/Skipped 2012-09-05 01:30:55 UTC (rev 127537) @@ -2171,3 +2171,14 @@ # https://bugs.webkit.org/show_bug.cgi?id=94374 inspector/timeline/timeline-decode-resize.html + +# Flaky inspector tests +http/tests/inspector/appcache/appcache-manifest-with-non-existing-file.html +http/tests/inspector/console-resource-errors.html +http/tests/inspector/network/network-initiator-from-console.html +http/tests/inspector/resource-tree/resource-request-content-while-loading.html +http/tests/inspector/search/resources-search-match-index.html +inspector/profiler/heap-snapshot.html +inspector/profiler/memory-instrumentation-cached-images.html +inspector/styles/media-queries.html +inspector/styles/region-style-crash.html ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [127538] trunk/Source/WebCore
Title: [127538] trunk/Source/WebCore
Revision 127538
Author t...@chromium.org
Date 2012-09-04 18:31:38 -0700 (Tue, 04 Sep 2012)
Log Message
Use TrackedRendererListHashSet typedef for percentHeightDescendants()
https://bugs.webkit.org/show_bug.cgi?id=95791
Reviewed by Ojan Vafai.
There were a couple callers that were using ListHashSetRenderBox* instead of the typedef.
No new tests, this is just a refactor.
* rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::layoutRows):
* rendering/RenderView.cpp:
(WebCore::RenderView::setFixedPositionedObjectsNeedLayout):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderTableSection.cpp
trunk/Source/WebCore/rendering/RenderView.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (127537 => 127538)
--- trunk/Source/WebCore/ChangeLog 2012-09-05 01:30:55 UTC (rev 127537)
+++ trunk/Source/WebCore/ChangeLog 2012-09-05 01:31:38 UTC (rev 127538)
@@ -1,3 +1,19 @@
+2012-09-04 Tony Chang t...@chromium.org
+
+Use TrackedRendererListHashSet typedef for percentHeightDescendants()
+https://bugs.webkit.org/show_bug.cgi?id=95791
+
+Reviewed by Ojan Vafai.
+
+There were a couple callers that were using ListHashSetRenderBox* instead of the typedef.
+
+No new tests, this is just a refactor.
+
+* rendering/RenderTableSection.cpp:
+(WebCore::RenderTableSection::layoutRows):
+* rendering/RenderView.cpp:
+(WebCore::RenderView::setFixedPositionedObjectsNeedLayout):
+
2012-09-04 Alec Flett alecfl...@chromium.org
IndexedDB: remove final createIndex backend glue
Modified: trunk/Source/WebCore/rendering/RenderTableSection.cpp (127537 => 127538)
--- trunk/Source/WebCore/rendering/RenderTableSection.cpp 2012-09-05 01:30:55 UTC (rev 127537)
+++ trunk/Source/WebCore/rendering/RenderTableSection.cpp 2012-09-05 01:31:38 UTC (rev 127538)
@@ -579,9 +579,9 @@
}
}
-if (ListHashSetRenderBox** percentHeightDescendants = cell-percentHeightDescendants()) {
-ListHashSetRenderBox*::iterator end = percentHeightDescendants-end();
-for (ListHashSetRenderBox*::iterator it = percentHeightDescendants-begin(); it != end; ++it) {
+if (TrackedRendererListHashSet* percentHeightDescendants = cell-percentHeightDescendants()) {
+TrackedRendererListHashSet::iterator end = percentHeightDescendants-end();
+for (TrackedRendererListHashSet::iterator it = percentHeightDescendants-begin(); it != end; ++it) {
RenderBox* box = *it;
if (!box-isReplaced() !box-scrollsOverflow() !flexAllChildren)
continue;
Modified: trunk/Source/WebCore/rendering/RenderView.cpp (127537 => 127538)
--- trunk/Source/WebCore/rendering/RenderView.cpp 2012-09-05 01:30:55 UTC (rev 127537)
+++ trunk/Source/WebCore/rendering/RenderView.cpp 2012-09-05 01:31:38 UTC (rev 127538)
@@ -941,12 +941,12 @@
{
ASSERT(m_frameView);
-ListHashSetRenderBox** positionedObjects = this-positionedObjects();
+TrackedRendererListHashSet* positionedObjects = this-positionedObjects();
if (!positionedObjects)
return;
-ListHashSetRenderBox*::const_iterator end = positionedObjects-end();
-for (ListHashSetRenderBox*::const_iterator it = positionedObjects-begin(); it != end; ++it) {
+TrackedRendererListHashSet::const_iterator end = positionedObjects-end();
+for (TrackedRendererListHashSet::const_iterator it = positionedObjects-begin(); it != end; ++it) {
RenderBox* currBox = *it;
currBox-setNeedsLayout(true);
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [127539] trunk/LayoutTests
Title: [127539] trunk/LayoutTests Revision 127539 Author roger_f...@apple.com Date 2012-09-04 18:38:29 -0700 (Tue, 04 Sep 2012) Log Message Unreviewed. Some flaky http/tests/security tests on Windows. Adding to skip list. https://bugs.webkit.org/show_bug.cgi?id=95803 * platform/win/Skipped: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/win/Skipped Diff Modified: trunk/LayoutTests/ChangeLog (127538 => 127539) --- trunk/LayoutTests/ChangeLog 2012-09-05 01:31:38 UTC (rev 127538) +++ trunk/LayoutTests/ChangeLog 2012-09-05 01:38:29 UTC (rev 127539) @@ -1,5 +1,12 @@ 2012-09-04 Roger Fong roger_f...@apple.com +Unreviewed. Some flaky http/tests/security tests on Windows. Adding to skip list. +https://bugs.webkit.org/show_bug.cgi?id=95803 + +* platform/win/Skipped: + +2012-09-04 Roger Fong roger_f...@apple.com + Unreviewed. Some flaky inspector tests on Windows. Adding to skip list. https://bugs.webkit.org/show_bug.cgi?id=95802 Modified: trunk/LayoutTests/platform/win/Skipped (127538 => 127539) --- trunk/LayoutTests/platform/win/Skipped 2012-09-05 01:31:38 UTC (rev 127538) +++ trunk/LayoutTests/platform/win/Skipped 2012-09-05 01:38:29 UTC (rev 127539) @@ -2173,6 +2173,7 @@ inspector/timeline/timeline-decode-resize.html # Flaky inspector tests +# https://bugs.webkit.org/show_bug.cgi?id=95802 http/tests/inspector/appcache/appcache-manifest-with-non-existing-file.html http/tests/inspector/console-resource-errors.html http/tests/inspector/network/network-initiator-from-console.html @@ -2182,3 +2183,11 @@ inspector/profiler/memory-instrumentation-cached-images.html inspector/styles/media-queries.html inspector/styles/region-style-crash.html + +# Flaky http/tests/security tests +# https://bugs.webkit.org/show_bug.cgi?id=95803 +http/tests/security/local-image-from-remote-whitelisted.html +http/tests/security/object-literals.html +http/tests/security/script-with-failed-cors-check-fails-to-load.html +http/tests/security/xss-DENIED-mime-type-execute-as-html.html +http/tests/security/xss-DENIED-xsl-external-entity.xml ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [127540] trunk/Source
Title: [127540] trunk/Source
Revision 127540
Author commit-qu...@webkit.org
Date 2012-09-04 18:43:42 -0700 (Tue, 04 Sep 2012)
Log Message
Make chromium-linux build without WTF_DEPRECATED_STRING_OPERATORS
https://bugs.webkit.org/show_bug.cgi?id=95798
Patch by Adam Barth aba...@chromium.org on 2012-09-04
Reviewed by Eric Seidel.
Source/WebCore:
This patch makes the chromium-linux port build without
WTF::String::operator+=. There are a couple places that require some
more careful study, and I've whitelisted those uses by defining
WTF_DEPRECATED_STRING_OPERATORS at the top of the files. (See
https://bugs.webkit.org/show_bug.cgi?id=95797 for an explanation of
WTF_DEPRECATED_STRING_OPERATORS.)
* css/StylePropertySet.cpp:
* inspector/InspectorOverlay.cpp:
(WebCore::InspectorOverlay::drawNodeHighlight):
* platform/graphics/filters/CustomFilterValidatedProgram.cpp:
(WebCore::CustomFilterValidatedProgram::rewriteMixVertexShader):
Source/WebKit/chromium:
* src/WebAccessibilityObject.cpp:
(WebKit::WebAccessibilityObject::keyboardShortcut):
- Remove use of WTF::String::operator+=
* src/WebPageSerializerImpl.cpp:
- Whitelist use of WTF::String::operator+=. Remove this use will take
some more careful thought.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/StylePropertySet.cpp
trunk/Source/WebCore/inspector/InspectorOverlay.cpp
trunk/Source/WebCore/platform/graphics/filters/CustomFilterValidatedProgram.cpp
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/src/WebAccessibilityObject.cpp
trunk/Source/WebKit/chromium/src/WebPageSerializerImpl.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (127539 => 127540)
--- trunk/Source/WebCore/ChangeLog 2012-09-05 01:38:29 UTC (rev 127539)
+++ trunk/Source/WebCore/ChangeLog 2012-09-05 01:43:42 UTC (rev 127540)
@@ -1,3 +1,23 @@
+2012-09-04 Adam Barth aba...@chromium.org
+
+Make chromium-linux build without WTF_DEPRECATED_STRING_OPERATORS
+https://bugs.webkit.org/show_bug.cgi?id=95798
+
+Reviewed by Eric Seidel.
+
+This patch makes the chromium-linux port build without
+WTF::String::operator+=. There are a couple places that require some
+more careful study, and I've whitelisted those uses by defining
+WTF_DEPRECATED_STRING_OPERATORS at the top of the files. (See
+https://bugs.webkit.org/show_bug.cgi?id=95797 for an explanation of
+WTF_DEPRECATED_STRING_OPERATORS.)
+
+* css/StylePropertySet.cpp:
+* inspector/InspectorOverlay.cpp:
+(WebCore::InspectorOverlay::drawNodeHighlight):
+* platform/graphics/filters/CustomFilterValidatedProgram.cpp:
+(WebCore::CustomFilterValidatedProgram::rewriteMixVertexShader):
+
2012-09-04 Tony Chang t...@chromium.org
Use TrackedRendererListHashSet typedef for percentHeightDescendants()
Modified: trunk/Source/WebCore/css/StylePropertySet.cpp (127539 => 127540)
--- trunk/Source/WebCore/css/StylePropertySet.cpp 2012-09-05 01:38:29 UTC (rev 127539)
+++ trunk/Source/WebCore/css/StylePropertySet.cpp 2012-09-05 01:43:42 UTC (rev 127540)
@@ -19,6 +19,8 @@
* Boston, MA 02110-1301, USA.
*/
+#define WTF_DEPRECATED_STRING_OPERATORS
+
#include config.h
#include StylePropertySet.h
Modified: trunk/Source/WebCore/inspector/InspectorOverlay.cpp (127539 => 127540)
--- trunk/Source/WebCore/inspector/InspectorOverlay.cpp 2012-09-05 01:38:29 UTC (rev 127539)
+++ trunk/Source/WebCore/inspector/InspectorOverlay.cpp 2012-09-05 01:43:42 UTC (rev 127540)
@@ -50,6 +50,7 @@
#include ScriptValue.h
#include Settings.h
#include StyledElement.h
+#include wtf/text/StringBuilder.h
namespace WebCore {
@@ -351,7 +352,7 @@
elementInfo-setString(idValue, element-getIdAttribute());
HashSetAtomicString usedClassNames;
if (element-hasClass() element-isStyledElement()) {
-String classNames;
+StringBuilder classNames;
const SpaceSplitString classNamesString = static_castStyledElement*(element)-classNames();
size_t classNameCount = classNamesString.size();
for (size_t i = 0; i classNameCount; ++i) {
@@ -359,9 +360,10 @@
if (usedClassNames.contains(className))
continue;
usedClassNames.add(className);
-classNames += makeString(., className);
+classNames.append('.');
+classNames.append(className);
}
-elementInfo-setString(className, classNames);
+elementInfo-setString(className, classNames.toString());
}
RenderObject* renderer = node-renderer();
Modified: trunk/Source/WebCore/platform/graphics/filters/CustomFilterValidatedProgram.cpp (127539 => 127540)
--- trunk/Source/WebCore/platform/graphics/filters/CustomFilterValidatedProgram.cpp 2012-09-05 01:38:29 UTC (rev 127539)
+++
[webkit-changes] [127541] trunk/LayoutTests
Title: [127541] trunk/LayoutTests Revision 127541 Author roger_f...@apple.com Date 2012-09-04 18:45:56 -0700 (Tue, 04 Sep 2012) Log Message Unreviewed. Some flaky http/tests/cookies tests on Windows. Adding to skip list. https://bugs.webkit.org/show_bug.cgi?id=95805 * platform/win/Skipped: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/win/Skipped Diff Modified: trunk/LayoutTests/ChangeLog (127540 => 127541) --- trunk/LayoutTests/ChangeLog 2012-09-05 01:43:42 UTC (rev 127540) +++ trunk/LayoutTests/ChangeLog 2012-09-05 01:45:56 UTC (rev 127541) @@ -1,5 +1,12 @@ 2012-09-04 Roger Fong roger_f...@apple.com +Unreviewed. Some flaky http/tests/cookies tests on Windows. Adding to skip list. +https://bugs.webkit.org/show_bug.cgi?id=95805 + +* platform/win/Skipped: + +2012-09-04 Roger Fong roger_f...@apple.com + Unreviewed. Some flaky http/tests/security tests on Windows. Adding to skip list. https://bugs.webkit.org/show_bug.cgi?id=95803 Modified: trunk/LayoutTests/platform/win/Skipped (127540 => 127541) --- trunk/LayoutTests/platform/win/Skipped 2012-09-05 01:43:42 UTC (rev 127540) +++ trunk/LayoutTests/platform/win/Skipped 2012-09-05 01:45:56 UTC (rev 127541) @@ -2191,3 +2191,8 @@ http/tests/security/script-with-failed-cors-check-fails-to-load.html http/tests/security/xss-DENIED-mime-type-execute-as-html.html http/tests/security/xss-DENIED-xsl-external-entity.xml + +# Flaky http/tests/cookie tests +# https://bugs.webkit.org/show_bug.cgi?id=95805 +http/tests/cookies/multiple-cookies.html +http/tests/cookies/single-quoted-value.html ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [127542] trunk/LayoutTests
Title: [127542] trunk/LayoutTests Revision 127542 Author roger_f...@apple.com Date 2012-09-04 18:55:39 -0700 (Tue, 04 Sep 2012) Log Message Unreviewed. Some flaky media/video tests on Windows. Adding to skip list. https://bugs.webkit.org/show_bug.cgi?id=95806 * platform/win/Skipped: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/win/Skipped Diff Modified: trunk/LayoutTests/ChangeLog (127541 => 127542) --- trunk/LayoutTests/ChangeLog 2012-09-05 01:45:56 UTC (rev 127541) +++ trunk/LayoutTests/ChangeLog 2012-09-05 01:55:39 UTC (rev 127542) @@ -1,5 +1,12 @@ 2012-09-04 Roger Fong roger_f...@apple.com +Unreviewed. Some flaky media/video tests on Windows. Adding to skip list. +https://bugs.webkit.org/show_bug.cgi?id=95806 + +* platform/win/Skipped: + +2012-09-04 Roger Fong roger_f...@apple.com + Unreviewed. Some flaky http/tests/cookies tests on Windows. Adding to skip list. https://bugs.webkit.org/show_bug.cgi?id=95805 Modified: trunk/LayoutTests/platform/win/Skipped (127541 => 127542) --- trunk/LayoutTests/platform/win/Skipped 2012-09-05 01:45:56 UTC (rev 127541) +++ trunk/LayoutTests/platform/win/Skipped 2012-09-05 01:55:39 UTC (rev 127542) @@ -2196,3 +2196,12 @@ # https://bugs.webkit.org/show_bug.cgi?id=95805 http/tests/cookies/multiple-cookies.html http/tests/cookies/single-quoted-value.html + +# Flaky media/video tests +# https://bugs.webkit.org/show_bug.cgi?id=95806 +media/video-aspect-ratio.html +media/video-replaces-poster.html +media/video-set-rate-from-pause.html +media/video-src-change.html +media/video-timeupdate-reverse-play.html +media/W3C/video/src/src_removal_does_not_trigger_loadstart.html ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [127544] trunk
Title: [127544] trunk
Revision 127544
Author barraclo...@apple.com
Date 2012-09-04 19:36:45 -0700 (Tue, 04 Sep 2012)
Log Message
inc/dec behave incorrectly operating on a resolved const
https://bugs.webkit.org/show_bug.cgi?id=95815
Reviewed by Geoff Garen.
Source/_javascript_Core:
There are two bugs here.
(1) When the value being incremented is const, and the result is ignored, we assume this cannot be observed, and emit no code.
However if the value being incremented is not a primitive has a valueOf conversion, then this should be being called.
(2) In the case of a pre-increment of a const value where the result is not ignored, we'll move +/-1 to the destination, then
add the resolved const value being incremented to this. This is problematic if the destination is a local, and the const
value being incremented has a valueOf conversion that throws - the destination will be modified erroneously. Instead, we
need to use a temporary location.
* bytecompiler/NodesCodegen.cpp:
(JSC::PostfixResolveNode::emitBytecode):
(JSC::PrefixResolveNode::emitBytecode):
- always at least perform a toNumber conversion, use tempDestination when reducing inc/dec to an add +/-1.
LayoutTests:
Added test cases.
* fast/js/inc-const-valueOf-expected.txt: Added.
* fast/js/inc-const-valueOf.html: Added.
* fast/js/script-tests/inc-const-valueOf.js: Added.
(testPostIncConstVarWithIgnoredResult.const.a.valueOf):
(testPostIncConstVarWithIgnoredResult):
test that 'a++' results in a valueOf call, where 'a' is const.
(testPreIncConstVarWithIgnoredResult.const.a.valueOf):
(testPreIncConstVarWithIgnoredResult):
test that '++a' results in a valueOf call, where 'a' is const.
(testPreIncConstVarWithAssign.const.a.valueOf):
(testPreIncConstVarWithAssign):
test that 'b = ++a' does not erroneously update 'b', where 'a' is const.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/bytecompiler/NodesCodegen.cpp
Added Paths
trunk/LayoutTests/fast/js/inc-const-valueOf-expected.txt
trunk/LayoutTests/fast/js/inc-const-valueOf.html
trunk/LayoutTests/fast/js/script-tests/inc-const-valueOf.js
Diff
Modified: trunk/LayoutTests/ChangeLog (127543 => 127544)
--- trunk/LayoutTests/ChangeLog 2012-09-05 02:28:29 UTC (rev 127543)
+++ trunk/LayoutTests/ChangeLog 2012-09-05 02:36:45 UTC (rev 127544)
@@ -1,3 +1,25 @@
+2012-09-04 Gavin Barraclough barraclo...@apple.com
+
+inc/dec behave incorrectly operating on a resolved const
+https://bugs.webkit.org/show_bug.cgi?id=95815
+
+Reviewed by Geoff Garen.
+
+Added test cases.
+
+* fast/js/inc-const-valueOf-expected.txt: Added.
+* fast/js/inc-const-valueOf.html: Added.
+* fast/js/script-tests/inc-const-valueOf.js: Added.
+(testPostIncConstVarWithIgnoredResult.const.a.valueOf):
+(testPostIncConstVarWithIgnoredResult):
+test that 'a++' results in a valueOf call, where 'a' is const.
+(testPreIncConstVarWithIgnoredResult.const.a.valueOf):
+(testPreIncConstVarWithIgnoredResult):
+test that '++a' results in a valueOf call, where 'a' is const.
+(testPreIncConstVarWithAssign.const.a.valueOf):
+(testPreIncConstVarWithAssign):
+test that 'b = ++a' does not erroneously update 'b', where 'a' is const.
+
2012-09-04 Kent Tamura tk...@chromium.org
[Chromium] Test expectation update
Added: trunk/LayoutTests/fast/js/inc-const-valueOf-expected.txt (0 => 127544)
--- trunk/LayoutTests/fast/js/inc-const-valueOf-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/js/inc-const-valueOf-expected.txt 2012-09-05 02:36:45 UTC (rev 127544)
@@ -0,0 +1,12 @@
+Test for regression against
+
+On success, you will see a series of PASS messages, followed by TEST COMPLETE.
+
+
+PASS testPostIncConstVarWithIgnoredResult() is true
+PASS testPreIncConstVarWithIgnoredResult() is true
+PASS testPreIncConstVarWithAssign() is true
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
Added: trunk/LayoutTests/fast/js/inc-const-valueOf.html (0 => 127544)
--- trunk/LayoutTests/fast/js/inc-const-valueOf.html (rev 0)
+++ trunk/LayoutTests/fast/js/inc-const-valueOf.html 2012-09-05 02:36:45 UTC (rev 127544)
@@ -0,0 +1,10 @@
+!DOCTYPE HTML PUBLIC -//IETF//DTD HTML//EN
+html
+head
+script src=""
+/head
+body
+script src=""
+script src=""
+/body
+/html
Added: trunk/LayoutTests/fast/js/script-tests/inc-const-valueOf.js (0 => 127544)
--- trunk/LayoutTests/fast/js/script-tests/inc-const-valueOf.js (rev 0)
+++ trunk/LayoutTests/fast/js/script-tests/inc-const-valueOf.js 2012-09-05 02:36:45 UTC (rev 127544)
@@ -0,0 +1,56 @@
+description(
+'Test for regression against a href=""
+);
+
+function testPostIncConstVarWithIgnoredResult()
+{
+var okay = false;
+const a = {
+valueOf: (function(){
+okay = true;
+
[webkit-changes] [127545] branches/chromium/1229
Title: [127545] branches/chromium/1229
Revision 127545
Author jchaffr...@webkit.org
Date 2012-09-04 19:48:12 -0700 (Tue, 04 Sep 2012)
Log Message
Merge 127520 - REGRESSION(r120832): RenderLayer::clampScrollOffset doesn't properly clamp
https://bugs.webkit.org/show_bug.cgi?id=95776
Reviewed by Simon Fraser.
.:
* ManualTests/select-menu-list-wrongly-positioned.html: Added.
Source/WebCore:
r120832 consolidated the clamping logic into RenderLayer::clampScrollOffset. The existing code wouldn't properly ensure that
the offset were positive which got exposed to other code paths, leading to the regression.
Tested by ManualTests/select-menu-list-wrongly-positioned.html as I didn't find a way to create a reliable layout test.
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::clampScrollOffset):
Fixed the clamping logic to ensure that the scroll offset's dimensions are positive.
TBR=jchaffr...@webkit.org
Review URL: https://chromiumcodereview.appspot.com/10908086
Modified Paths
branches/chromium/1229/Source/WebCore/rendering/RenderLayer.cpp
Added Paths
branches/chromium/1229/ManualTests/select-menu-list-wrongly-positioned.html
Diff
Copied: branches/chromium/1229/ManualTests/select-menu-list-wrongly-positioned.html (from rev 127520, trunk/ManualTests/select-menu-list-wrongly-positioned.html) (0 => 127545)
--- branches/chromium/1229/ManualTests/select-menu-list-wrongly-positioned.html (rev 0)
+++ branches/chromium/1229/ManualTests/select-menu-list-wrongly-positioned.html 2012-09-05 02:48:12 UTC (rev 127545)
@@ -0,0 +1,38 @@
+!DOCTYPE html
+html
+head
+style
+table {
+overflow: hidden;
+}
+/style
+script
+function onSelectionChange(select)
+{
+document.getElementById('hiddenRow').style.display = '';
+}
+/script
+/head
+body
+diva href="" REGRESSION(r120832): RenderLayer::clampScrollOffset doesn't properly clamp/div
+divManual test: click on the menu below and lt;selectgt; the 'shown' option. Click somewhere on the page so that the lt;selectgt; loses focus and click again on the lt;selectgt;./div
+divTo pass the menu should be properly placed below the lt;selectgt;./div
+form name=teste
+table
+tr
+thTest select:/th
+td
+select _onchange_=onSelectionChange(this)
+option value=0hidden/option
+option value=1shown/option
+/select
+/td
+/tr
+tr id=hiddenRow style=display: none;
+thLorem ipsum/th
+tddolor sic amet./td
+/tr
+/table
+/form
+/body
+/html
Modified: branches/chromium/1229/Source/WebCore/rendering/RenderLayer.cpp (127544 => 127545)
--- branches/chromium/1229/Source/WebCore/rendering/RenderLayer.cpp 2012-09-05 02:36:45 UTC (rev 127544)
+++ branches/chromium/1229/Source/WebCore/rendering/RenderLayer.cpp 2012-09-05 02:48:12 UTC (rev 127545)
@@ -1625,8 +1625,8 @@
int maxX = scrollWidth() - box-pixelSnappedClientWidth();
int maxY = scrollHeight() - box-pixelSnappedClientHeight();
-int x = min(max(scrollOffset.width(), 0), maxX);
-int y = min(max(scrollOffset.height(), 0), maxY);
+int x = max(min(scrollOffset.width(), maxX), 0);
+int y = max(min(scrollOffset.height(), maxY), 0);
return IntSize(x, y);
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [127546] trunk/LayoutTests
Title: [127546] trunk/LayoutTests Revision 127546 Author ba...@chromium.org Date 2012-09-04 20:33:40 -0700 (Tue, 04 Sep 2012) Log Message [Chromium] Unreviewed test expectations update after r127534 * platform/chromium/fast/innerHTML/innerHTML-iframe-expected.txt: Removed. Modified Paths trunk/LayoutTests/ChangeLog Removed Paths trunk/LayoutTests/platform/chromium/fast/innerHTML/innerHTML-iframe-expected.txt Diff Modified: trunk/LayoutTests/ChangeLog (127545 => 127546) --- trunk/LayoutTests/ChangeLog 2012-09-05 02:48:12 UTC (rev 127545) +++ trunk/LayoutTests/ChangeLog 2012-09-05 03:33:40 UTC (rev 127546) @@ -1,3 +1,9 @@ +2012-09-04 Kenichi Ishibashi ba...@chromium.org + +[Chromium] Unreviewed test expectations update after r127534 + +* platform/chromium/fast/innerHTML/innerHTML-iframe-expected.txt: Removed. + 2012-09-04 Gavin Barraclough barraclo...@apple.com inc/dec behave incorrectly operating on a resolved const Deleted: trunk/LayoutTests/platform/chromium/fast/innerHTML/innerHTML-iframe-expected.txt (127545 => 127546) --- trunk/LayoutTests/platform/chromium/fast/innerHTML/innerHTML-iframe-expected.txt 2012-09-05 02:48:12 UTC (rev 127545) +++ trunk/LayoutTests/platform/chromium/fast/innerHTML/innerHTML-iframe-expected.txt 2012-09-05 03:33:40 UTC (rev 127546) @@ -1 +0,0 @@ -PASS: body and iframe cleared without crashing. ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [127547] trunk/Tools
Title: [127547] trunk/Tools Revision 127547 Author timothy_hor...@apple.com Date 2012-09-04 20:45:33 -0700 (Tue, 04 Sep 2012) Log Message Have NRWT log more output when crash logs are missing https://bugs.webkit.org/show_bug.cgi?id=95814 Reviewed by Dan Bernstein. Log the stderr and stdout of the test, in order to provide slightly more context when the WebProcess times out while running tests. * Scripts/webkitpy/layout_tests/port/driver.py: (Driver.run_test): Modified Paths trunk/Tools/ChangeLog trunk/Tools/Scripts/webkitpy/layout_tests/port/driver.py Diff Modified: trunk/Tools/ChangeLog (127546 => 127547) --- trunk/Tools/ChangeLog 2012-09-05 03:33:40 UTC (rev 127546) +++ trunk/Tools/ChangeLog 2012-09-05 03:45:33 UTC (rev 127547) @@ -1,3 +1,16 @@ +2012-09-04 Tim Horton timothy_hor...@apple.com + +Have NRWT log more output when crash logs are missing +https://bugs.webkit.org/show_bug.cgi?id=95814 + +Reviewed by Dan Bernstein. + +Log the stderr and stdout of the test, in order to provide slightly more +context when the WebProcess times out while running tests. + +* Scripts/webkitpy/layout_tests/port/driver.py: +(Driver.run_test): + 2012-09-04 Xianzhu Wang wangxian...@chromium.org [Chromium-Android] Include device serial number in ChromiumAndroidDriver log messages Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/driver.py (127546 => 127547) --- trunk/Tools/Scripts/webkitpy/layout_tests/port/driver.py 2012-09-05 03:33:40 UTC (rev 127546) +++ trunk/Tools/Scripts/webkitpy/layout_tests/port/driver.py 2012-09-05 03:45:33 UTC (rev 127547) @@ -176,11 +176,15 @@ # If we don't find a crash log use a placeholder error message instead. if not crash_log: pid_str = str(self._crashed_pid) if self._crashed_pid else unknown pid -crash_log = 'no crash log found for %s:%s.' % (self._crashed_process_name, pid_str) +crash_log = 'No crash log found for %s:%s.\n' % (self._crashed_process_name, pid_str) # If we were unresponsive append a message informing there may not have been a crash. if self._subprocess_was_unresponsive: -crash_log += ' Process failed to become responsive before timing out.' +crash_log += 'Process failed to become responsive before timing out.\n' +# Print stdout and stderr to the placeholder crash log; we want as much context as possible. +if self.error_from_test: +crash_log += '\nstdout:\n%s\nstderr:\n%s\n' % (text, self.error_from_test) + return DriverOutput(text, image, actual_image_hash, audio, crash=crashed, test_time=time.time() - test_begin_time, timeout=timed_out, error=self.error_from_test, ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [127548] trunk
Title: [127548] trunk
Revision 127548
Author k...@webkit.org
Date 2012-09-04 20:57:56 -0700 (Tue, 04 Sep 2012)
Log Message
-webkit-clip-path does not apply origin for polygon()
https://bugs.webkit.org/show_bug.cgi?id=95656
Reviewed by Tim Horton.
Source/WebCore:
The polygon() shape function did not apply origin of bouding box on created path. The shape was
not moved to the correct position.
Tests: svg/clip-path/clip-path-shape-polygon-relative-expected.svg
svg/clip-path/clip-path-shape-polygon-relative.svg
* rendering/style/BasicShapes.cpp:
(WebCore::BasicShapePolygon::path): Apply origin of bounding box.
LayoutTests:
Check that the origin of the bounding box gets applied to the clip path.
* svg/clip-path/clip-path-shape-polygon-relative-expected.svg: Added.
* svg/clip-path/clip-path-shape-polygon-relative.svg: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/style/BasicShapes.cpp
Added Paths
trunk/LayoutTests/svg/clip-path/clip-path-shape-polygon-relative-expected.svg
trunk/LayoutTests/svg/clip-path/clip-path-shape-polygon-relative.svg
Diff
Modified: trunk/LayoutTests/ChangeLog (127547 => 127548)
--- trunk/LayoutTests/ChangeLog 2012-09-05 03:45:33 UTC (rev 127547)
+++ trunk/LayoutTests/ChangeLog 2012-09-05 03:57:56 UTC (rev 127548)
@@ -1,3 +1,15 @@
+2012-09-04 Dirk Schulze k...@webkit.org
+
+-webkit-clip-path does not apply origin for polygon()
+https://bugs.webkit.org/show_bug.cgi?id=95656
+
+Reviewed by Tim Horton.
+
+Check that the origin of the bounding box gets applied to the clip path.
+
+* svg/clip-path/clip-path-shape-polygon-relative-expected.svg: Added.
+* svg/clip-path/clip-path-shape-polygon-relative.svg: Added.
+
2012-09-04 Kenichi Ishibashi ba...@chromium.org
[Chromium] Unreviewed test expectations update after r127534
Added: trunk/LayoutTests/svg/clip-path/clip-path-shape-polygon-relative-expected.svg (0 => 127548)
--- trunk/LayoutTests/svg/clip-path/clip-path-shape-polygon-relative-expected.svg (rev 0)
+++ trunk/LayoutTests/svg/clip-path/clip-path-shape-polygon-relative-expected.svg 2012-09-05 03:57:56 UTC (rev 127548)
@@ -0,0 +1,3 @@
+svg xmlns=http://www.w3.org/2000/svg
+rect x=50 y=50 width=200 height=200 fill=green/
+/svg
\ No newline at end of file
Added: trunk/LayoutTests/svg/clip-path/clip-path-shape-polygon-relative.svg (0 => 127548)
--- trunk/LayoutTests/svg/clip-path/clip-path-shape-polygon-relative.svg (rev 0)
+++ trunk/LayoutTests/svg/clip-path/clip-path-shape-polygon-relative.svg 2012-09-05 03:57:56 UTC (rev 127548)
@@ -0,0 +1,3 @@
+svg xmlns=http://www.w3.org/2000/svg
+rect x=50 y=50 width=200 height=200 fill=green style=-webkit-clip-path: polygon(0% 0%, 100% 0%, 100% 100%, 0% 100%)/
+/svg
\ No newline at end of file
Modified: trunk/Source/WebCore/ChangeLog (127547 => 127548)
--- trunk/Source/WebCore/ChangeLog 2012-09-05 03:45:33 UTC (rev 127547)
+++ trunk/Source/WebCore/ChangeLog 2012-09-05 03:57:56 UTC (rev 127548)
@@ -1,3 +1,19 @@
+2012-09-04 Dirk Schulze k...@webkit.org
+
+-webkit-clip-path does not apply origin for polygon()
+https://bugs.webkit.org/show_bug.cgi?id=95656
+
+Reviewed by Tim Horton.
+
+The polygon() shape function did not apply origin of bouding box on created path. The shape was
+not moved to the correct position.
+
+Tests: svg/clip-path/clip-path-shape-polygon-relative-expected.svg
+ svg/clip-path/clip-path-shape-polygon-relative.svg
+
+* rendering/style/BasicShapes.cpp:
+(WebCore::BasicShapePolygon::path): Apply origin of bounding box.
+
2012-09-04 Adam Barth aba...@chromium.org
Make chromium-linux build without WTF_DEPRECATED_STRING_OPERATORS
Modified: trunk/Source/WebCore/rendering/style/BasicShapes.cpp (127547 => 127548)
--- trunk/Source/WebCore/rendering/style/BasicShapes.cpp 2012-09-05 03:45:33 UTC (rev 127547)
+++ trunk/Source/WebCore/rendering/style/BasicShapes.cpp 2012-09-05 03:57:56 UTC (rev 127548)
@@ -82,11 +82,11 @@
if (!length)
return;
-path.moveTo(FloatPoint(floatValueForLength(m_values.at(0), boundingBox.width()),
- floatValueForLength(m_values.at(1), boundingBox.width(;
+path.moveTo(FloatPoint(floatValueForLength(m_values.at(0), boundingBox.width()) + boundingBox.x(),
+ floatValueForLength(m_values.at(1), boundingBox.width()) + boundingBox.y()));
for (size_t i = 2; i length; i = i + 2) {
-path.addLineTo(FloatPoint(floatValueForLength(m_values.at(i), boundingBox.width()),
- floatValueForLength(m_values.at(i + 1), boundingBox.width(;
+path.addLineTo(FloatPoint(floatValueForLength(m_values.at(i), boundingBox.width()) + boundingBox.x(),
+
[webkit-changes] [127549] trunk/Source/WebCore
Title: [127549] trunk/Source/WebCore
Revision 127549
Author t...@chromium.org
Date 2012-09-04 21:14:44 -0700 (Tue, 04 Sep 2012)
Log Message
Add a const version of RenderBox::computeLogicalHeight
https://bugs.webkit.org/show_bug.cgi?id=95787
Reviewed by Ojan Vafai.
After this, we can rename the old computeLogicalHeight to computeAndSetLogicalHeight
to make it clear that it is modifying values.
No new tests, this should just be a refactor.
* rendering/RenderBox.cpp:
(WebCore::RenderBox::constrainLogicalHeightByMinMax): Make const.
(WebCore::RenderBox::computeLogicalHeight): Add a const version that takes a LogicalExtentComputedValues struct for out values.
(WebCore::RenderBox::computeLogicalHeightUsing): Make const.
(WebCore::RenderBox::computeContentLogicalHeightUsing): Make const.
(WebCore::RenderBox::computePercentageLogicalHeight): Add a const cast. I tried to
convert everything below to const, but that's not a simple task. Also, computeReplacedLogicalHeightUsing
is already using a const_cast.
* rendering/RenderBox.h:
(RenderBox): Add const to method signatures.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderBox.cpp
trunk/Source/WebCore/rendering/RenderBox.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (127548 => 127549)
--- trunk/Source/WebCore/ChangeLog 2012-09-05 03:57:56 UTC (rev 127548)
+++ trunk/Source/WebCore/ChangeLog 2012-09-05 04:14:44 UTC (rev 127549)
@@ -1,3 +1,26 @@
+2012-09-04 Tony Chang t...@chromium.org
+
+Add a const version of RenderBox::computeLogicalHeight
+https://bugs.webkit.org/show_bug.cgi?id=95787
+
+Reviewed by Ojan Vafai.
+
+After this, we can rename the old computeLogicalHeight to computeAndSetLogicalHeight
+to make it clear that it is modifying values.
+
+No new tests, this should just be a refactor.
+
+* rendering/RenderBox.cpp:
+(WebCore::RenderBox::constrainLogicalHeightByMinMax): Make const.
+(WebCore::RenderBox::computeLogicalHeight): Add a const version that takes a LogicalExtentComputedValues struct for out values.
+(WebCore::RenderBox::computeLogicalHeightUsing): Make const.
+(WebCore::RenderBox::computeContentLogicalHeightUsing): Make const.
+(WebCore::RenderBox::computePercentageLogicalHeight): Add a const cast. I tried to
+convert everything below to const, but that's not a simple task. Also, computeReplacedLogicalHeightUsing
+is already using a const_cast.
+* rendering/RenderBox.h:
+(RenderBox): Add const to method signatures.
+
2012-09-04 Dirk Schulze k...@webkit.org
-webkit-clip-path does not apply origin for polygon()
Modified: trunk/Source/WebCore/rendering/RenderBox.cpp (127548 => 127549)
--- trunk/Source/WebCore/rendering/RenderBox.cpp 2012-09-05 03:57:56 UTC (rev 127548)
+++ trunk/Source/WebCore/rendering/RenderBox.cpp 2012-09-05 04:14:44 UTC (rev 127549)
@@ -421,7 +421,7 @@
return max(logicalWidth, computeLogicalWidthInRegionUsing(MinSize, availableWidth, cb, region, offsetFromLogicalTopOfFirstPage));
}
-LayoutUnit RenderBox::constrainLogicalHeightByMinMax(LayoutUnit logicalHeight)
+LayoutUnit RenderBox::constrainLogicalHeightByMinMax(LayoutUnit logicalHeight) const
{
RenderStyle* styleToUse = style();
if (!styleToUse-logicalMaxHeight().isUndefined()) {
@@ -1967,43 +1967,45 @@
void RenderBox::computeLogicalHeight()
{
+LogicalExtentComputedValues computedValues;
+computeLogicalHeight(computedValues);
+
+setLogicalHeight(computedValues.m_extent);
+setLogicalTop(computedValues.m_position);
+setMarginBefore(computedValues.m_margins.m_before);
+setMarginAfter(computedValues.m_margins.m_after);
+}
+
+void RenderBox::computeLogicalHeight(LogicalExtentComputedValues computedValues) const
+{
+computedValues.m_extent = logicalHeight();
+computedValues.m_position = logicalTop();
+
// Cell height is managed by the table and inline non-replaced elements do not support a height property.
if (isTableCell() || (isInline() !isReplaced()))
return;
Length h;
-if (isOutOfFlowPositioned()) {
-LogicalExtentComputedValues computedValues;
+if (isOutOfFlowPositioned())
computePositionedLogicalHeight(computedValues);
-
-setLogicalHeight(computedValues.m_extent);
-setLogicalTop(computedValues.m_position);
-setMarginBefore(computedValues.m_margins.m_before);
-setMarginAfter(computedValues.m_margins.m_after);
-} else {
+else {
RenderBlock* cb = containingBlock();
bool hasPerpendicularContainingBlock = cb-isHorizontalWritingMode() != isHorizontalWritingMode();
if (!hasPerpendicularContainingBlock) {
-ComputedMarginValues marginValues;
bool shouldFlipBeforeAfter = cb-style()-writingMode() != style()-writingMode();
computeBlockDirectionMargins(cb,
-
[webkit-changes] [127550] trunk/LayoutTests
Title: [127550] trunk/LayoutTests Revision 127550 Author tk...@chromium.org Date 2012-09-04 21:16:11 -0700 (Tue, 04 Sep 2012) Log Message [Chromium] Test expectatino update. * platform/chromium/TestExpectations: japanese-ruby-vertical-*.html might be flaky on Windows too. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (127549 => 127550) --- trunk/LayoutTests/ChangeLog 2012-09-05 04:14:44 UTC (rev 127549) +++ trunk/LayoutTests/ChangeLog 2012-09-05 04:16:11 UTC (rev 127550) @@ -1,3 +1,10 @@ +2012-09-04 Kent Tamura tk...@chromium.org + +[Chromium] Test expectatino update. + +* platform/chromium/TestExpectations: +japanese-ruby-vertical-*.html might be flaky on Windows too. + 2012-09-04 Dirk Schulze k...@webkit.org -webkit-clip-path does not apply origin for polygon() Modified: trunk/LayoutTests/platform/chromium/TestExpectations (127549 => 127550) --- trunk/LayoutTests/platform/chromium/TestExpectations 2012-09-05 04:14:44 UTC (rev 127549) +++ trunk/LayoutTests/platform/chromium/TestExpectations 2012-09-05 04:16:11 UTC (rev 127550) @@ -2056,8 +2056,8 @@ BUGCR65877 ANDROID : fast/writing-mode/border-vertical-lr.html = IMAGE+TEXT BUGCR65877 LINUX ANDROID MAC : fast/writing-mode/japanese-lr-selection.html = IMAGE+TEXT IMAGE BUGCR65877 LINUX ANDROID MAC : fast/writing-mode/japanese-rl-selection.html = IMAGE+TEXT IMAGE -BUGCR65877 LINUX ANDROID MAC : fast/writing-mode/japanese-ruby-vertical-lr.html = PASS IMAGE+TEXT -BUGCR65877 LINUX ANDROID MAC : fast/writing-mode/japanese-ruby-vertical-rl.html = PASS IMAGE+TEXT +BUGCR65877 : fast/writing-mode/japanese-ruby-vertical-lr.html = PASS IMAGE+TEXT +BUGCR65877 : fast/writing-mode/japanese-ruby-vertical-rl.html = PASS IMAGE+TEXT BUGCR65877 LINUX ANDROID : fast/writing-mode/japanese-ruby-horizontal-bt.html = PASS IMAGE+TEXT BUGCR65877 LINUX : fast/writing-mode/broken-ideographic-font.html = IMAGE+TEXT BUGCR65877 ANDROID : fast/writing-mode/vertical-font-fallback.html = IMAGE+TEXT ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [127551] trunk/LayoutTests
Title: [127551] trunk/LayoutTests Revision 127551 Author tk...@chromium.org Date 2012-09-04 21:27:14 -0700 (Tue, 04 Sep 2012) Log Message [Chromium] Update test expectation https://bugs.webkit.org/show_bug.cgi?id=95395 * platform/chromium-linux/media/track/track-cue-rendering-horizontal-expected.png: * platform/chromium-linux/media/track/track-cue-rendering-vertical-expected.png: * platform/chromium-win/media/track/track-cue-rendering-horizontal-expected.png: * platform/chromium/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/TestExpectations trunk/LayoutTests/platform/chromium-linux/media/track/track-cue-rendering-horizontal-expected.png trunk/LayoutTests/platform/chromium-linux/media/track/track-cue-rendering-vertical-expected.png trunk/LayoutTests/platform/chromium-win/media/track/track-cue-rendering-horizontal-expected.png Diff Modified: trunk/LayoutTests/ChangeLog (127550 => 127551) --- trunk/LayoutTests/ChangeLog 2012-09-05 04:16:11 UTC (rev 127550) +++ trunk/LayoutTests/ChangeLog 2012-09-05 04:27:14 UTC (rev 127551) @@ -1,5 +1,15 @@ 2012-09-04 Kent Tamura tk...@chromium.org +[Chromium] Update test expectation +https://bugs.webkit.org/show_bug.cgi?id=95395 + +* platform/chromium-linux/media/track/track-cue-rendering-horizontal-expected.png: +* platform/chromium-linux/media/track/track-cue-rendering-vertical-expected.png: +* platform/chromium-win/media/track/track-cue-rendering-horizontal-expected.png: +* platform/chromium/TestExpectations: + +2012-09-04 Kent Tamura tk...@chromium.org + [Chromium] Test expectatino update. * platform/chromium/TestExpectations: Modified: trunk/LayoutTests/platform/chromium/TestExpectations (127550 => 127551) --- trunk/LayoutTests/platform/chromium/TestExpectations 2012-09-05 04:16:11 UTC (rev 127550) +++ trunk/LayoutTests/platform/chromium/TestExpectations 2012-09-05 04:27:14 UTC (rev 127551) @@ -3563,10 +3563,6 @@ BUGWK95101 SNOWLEOPARD : fast/text/atsui-bidi-control.html = PASS TIMEOUT -// These need new baselines: both new tests and new CC button has just been added. -BUGWK95395 : media/track/track-cue-rendering-horizontal.html = IMAGE -BUGWK95395 LINUX MAC : media/track/track-cue-rendering-vertical.html = IMAGE - // Failing due to sub-pixel layout. BUGWK95136 : fast/css/sticky/sticky-left-percentage.html = IMAGE BUGWK95136 WIN LINUX : fast/css/sticky/sticky-writing-mode-vertical-lr.html = IMAGE Modified: trunk/LayoutTests/platform/chromium-linux/media/track/track-cue-rendering-horizontal-expected.png (Binary files differ) Modified: trunk/LayoutTests/platform/chromium-linux/media/track/track-cue-rendering-vertical-expected.png (Binary files differ) Modified: trunk/LayoutTests/platform/chromium-win/media/track/track-cue-rendering-horizontal-expected.png (Binary files differ) ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [127552] trunk/Source/WebKit2
Title: [127552] trunk/Source/WebKit2
Revision 127552
Author commit-qu...@webkit.org
Date 2012-09-04 21:40:29 -0700 (Tue, 04 Sep 2012)
Log Message
[WK2] Use explicit constructor in InjectedBundle.
https://bugs.webkit.org/show_bug.cgi?id=95746
Patch by Kangil Han kangil@samsung.com on 2012-09-04
Reviewed by Sam Weinig.
Added explicit keyword in constructor of InjectedBundle in order to avoid implicit type conversion.
* WebProcess/InjectedBundle/InjectedBundle.h:
(InjectedBundle):
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/WebProcess/InjectedBundle/InjectedBundle.h
Diff
Modified: trunk/Source/WebKit2/ChangeLog (127551 => 127552)
--- trunk/Source/WebKit2/ChangeLog 2012-09-05 04:27:14 UTC (rev 127551)
+++ trunk/Source/WebKit2/ChangeLog 2012-09-05 04:40:29 UTC (rev 127552)
@@ -1,3 +1,15 @@
+2012-09-04 Kangil Han kangil@samsung.com
+
+[WK2] Use explicit constructor in InjectedBundle.
+https://bugs.webkit.org/show_bug.cgi?id=95746
+
+Reviewed by Sam Weinig.
+
+Added explicit keyword in constructor of InjectedBundle in order to avoid implicit type conversion.
+
+* WebProcess/InjectedBundle/InjectedBundle.h:
+(InjectedBundle):
+
2012-09-03 Sam Weinig s...@webkit.org
Part 1 of removing PlatformString.h, move remaining functions to new homes
Modified: trunk/Source/WebKit2/WebProcess/InjectedBundle/InjectedBundle.h (127551 => 127552)
--- trunk/Source/WebKit2/WebProcess/InjectedBundle/InjectedBundle.h 2012-09-05 04:27:14 UTC (rev 127551)
+++ trunk/Source/WebKit2/WebProcess/InjectedBundle/InjectedBundle.h 2012-09-05 04:40:29 UTC (rev 127552)
@@ -166,7 +166,7 @@
void setPageVisibilityState(WebPage*, int state, bool isInitialState);
private:
-InjectedBundle(const String);
+explicit InjectedBundle(const String);
virtual Type type() const { return APIType; }
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
