date:20120914

[webkit-changes] [128682] trunk/Source/WTF

2012-09-14 Thread commit-queue

Title: [128682] trunk/Source/WTF








Revision 128682
Author commit-qu...@webkit.org
Date 2012-09-14 21:36:06 -0700 (Fri, 14 Sep 2012)


Log Message
WTFString::show doesn't dump non-ASCII characters in a readable manner
https://bugs.webkit.org/show_bug.cgi?id=96749

Patch by Glenn Adams  on 2012-09-14
Reviewed by Benjamin Poulain.

Dump non-ASCII characters in a useful form for debugging.

* wtf/text/WTFString.cpp:
(asciiDebug):
Dump non-ASCII characters (i.e., UTF-16 code elements) as well as non-printable ASCII characters
using \u format.

Modified Paths

trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/text/WTFString.cpp




Diff

Modified: trunk/Source/WTF/ChangeLog (128681 => 128682)

--- trunk/Source/WTF/ChangeLog	2012-09-15 04:18:44 UTC (rev 128681)
+++ trunk/Source/WTF/ChangeLog	2012-09-15 04:36:06 UTC (rev 128682)
@@ -1,3 +1,17 @@
+2012-09-14  Glenn Adams  
+
+WTFString::show doesn't dump non-ASCII characters in a readable manner
+https://bugs.webkit.org/show_bug.cgi?id=96749
+
+Reviewed by Benjamin Poulain.
+
+Dump non-ASCII characters in a useful form for debugging.
+
+* wtf/text/WTFString.cpp:
+(asciiDebug):
+Dump non-ASCII characters (i.e., UTF-16 code elements) as well as non-printable ASCII characters
+using \u format.
+
 2012-09-14  Alexey Proskuryakov  
 
 Minimize collisions when hashing pairs


Modified: trunk/Source/WTF/wtf/text/WTFString.cpp (128681 => 128682)

--- trunk/Source/WTF/wtf/text/WTFString.cpp	2012-09-15 04:18:44 UTC (rev 128681)
+++ trunk/Source/WTF/wtf/text/WTFString.cpp	2012-09-15 04:36:06 UTC (rev 128682)
@@ -26,6 +26,7 @@
 #include 
 #include 
 #include 
+#include 
 #include 
 #include 
 #include 
@@ -1135,16 +1136,17 @@
 return asciiDebug(String("[null]").impl());
 
 Vector buffer;
-unsigned length = impl->length();
-const UChar* characters = impl->characters();
-
-buffer.resize(length + 1);
-for (unsigned i = 0; i < length; ++i) {
-UChar ch = characters[i];
-buffer[i] = ch && (ch < 0x20 || ch > 0x7f) ? '?' : ch;
+for (unsigned i = 0; i < impl->length(); ++i) {
+UChar ch = (*impl)[i];
+if (isASCIIPrintable(ch))
+buffer.append(ch);
+else {
+buffer.append('\\');
+buffer.append('u');
+appendUnsignedAsHexFixedSize(ch, buffer, 4);
+}
 }
-buffer[length] = '\0';
-
+buffer.append('\0');
 return buffer;
 }
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [128681] trunk/LayoutTests

2012-09-14 Thread jamesr

Title: [128681] trunk/LayoutTests








Revision 128681
Author jam...@google.com
Date 2012-09-14 21:18:44 -0700 (Fri, 14 Sep 2012)


Log Message
Unreviewed gardening - more position:fixed stacking context rebaselines.

* fast/block/positioning/016-expected.txt: Renamed from LayoutTests/platform/chromium-linux-x86/fast/block/positioning/016-expected.txt.
* fast/block/positioning/025-expected.txt: Renamed from LayoutTests/platform/chromium-linux-x86/fast/block/positioning/025-expected.txt.
* platform/chromium-linux/compositing/geometry/fixed-position-composited-switch-expected.txt: Removed.
* platform/chromium-linux/fast/block/positioning/fixed-position-stacking-context-expected.txt: Removed.
* platform/chromium-mac-snowleopard/compositing/geometry/fixed-position-composited-switch-expected.txt: Removed.
* platform/chromium-mac-snowleopard/fast/block/positioning/016-expected.txt: Removed.
* platform/chromium-mac-snowleopard/fast/block/positioning/025-expected.txt: Removed.
* platform/chromium-mac-snowleopard/fast/block/positioning/fixed-position-stacking-context-expected.txt: Removed.
* platform/chromium-mac/compositing/geometry/fixed-position-composited-switch-expected.txt: Removed.
* platform/chromium-mac/fast/block/positioning/016-expected.txt: Removed.
* platform/chromium-mac/fast/block/positioning/025-expected.txt: Removed.
* platform/chromium-mac/fast/block/positioning/fixed-position-stacking-context-expected.txt: Removed.
* platform/chromium-win/fast/block/positioning/016-expected.png: Renamed from LayoutTests/platform/chromium-linux/fast/block/positioning/016-expected.png.
* platform/chromium-win/fast/block/positioning/025-expected.png: Renamed from LayoutTests/platform/chromium-linux/fast/block/positioning/025-expected.png.
* platform/chromium-win/fast/block/positioning/fixed-position-stacking-context-expected.png: Renamed from LayoutTests/platform/chromium-linux/fast/block/positioning/fixed-position-stacking-context-expected.png.
* platform/chromium/compositing/geometry/fixed-position-composited-switch-expected.txt: Renamed from LayoutTests/platform/chromium-linux-x86/compositing/geometry/fixed-position-composited-switch-expected.txt.
* platform/chromium/fast/block/positioning/016-expected.txt: Renamed from LayoutTests/platform/chromium-linux/fast/block/positioning/016-expected.txt.
* platform/chromium/fast/block/positioning/025-expected.txt: Renamed from LayoutTests/platform/chromium-linux/fast/block/positioning/025-expected.txt.
* platform/chromium/fast/block/positioning/fixed-position-stacking-context-expected.txt: Renamed from LayoutTests/platform/chromium-linux-x86/fast/block/positioning/fixed-position-stacking-context-expected.txt.
* platform/efl/fast/block/positioning/016-expected.txt: Removed.
* platform/efl/fast/block/positioning/025-expected.txt: Removed.
* platform/gtk/fast/block/positioning/016-expected.txt: Removed.
* platform/gtk/fast/block/positioning/025-expected.txt: Removed.
* platform/qt/fast/block/positioning/016-expected.txt: Removed.
* platform/qt/fast/block/positioning/025-expected.txt: Removed.

Modified Paths

trunk/LayoutTests/ChangeLog


Added Paths

trunk/LayoutTests/fast/block/positioning/016-expected.txt
trunk/LayoutTests/fast/block/positioning/025-expected.txt
trunk/LayoutTests/platform/chromium/compositing/geometry/fixed-position-composited-switch-expected.txt
trunk/LayoutTests/platform/chromium/fast/block/positioning/016-expected.txt
trunk/LayoutTests/platform/chromium/fast/block/positioning/025-expected.txt
trunk/LayoutTests/platform/chromium/fast/block/positioning/fixed-position-stacking-context-expected.txt
trunk/LayoutTests/platform/chromium-win/fast/block/positioning/016-expected.png
trunk/LayoutTests/platform/chromium-win/fast/block/positioning/025-expected.png
trunk/LayoutTests/platform/chromium-win/fast/block/positioning/fixed-position-stacking-context-expected.png


Removed Paths

trunk/LayoutTests/platform/chromium-linux/compositing/geometry/fixed-position-composited-switch-expected.txt
trunk/LayoutTests/platform/chromium-linux/fast/block/positioning/016-expected.png
trunk/LayoutTests/platform/chromium-linux/fast/block/positioning/016-expected.txt
trunk/LayoutTests/platform/chromium-linux/fast/block/positioning/025-expected.png
trunk/LayoutTests/platform/chromium-linux/fast/block/positioning/025-expected.txt
trunk/LayoutTests/platform/chromium-linux/fast/block/positioning/fixed-position-stacking-context-expected.png
trunk/LayoutTests/platform/chromium-linux/fast/block/positioning/fixed-position-stacking-context-expected.txt
trunk/LayoutTests/platform/chromium-linux-x86/compositing/geometry/fixed-position-composited-switch-expected.txt
trunk/LayoutTests/platform/chromium-linux-x86/fast/block/positioning/016-expected.txt
trunk/LayoutTests/platform/chromium-linux-x86/fast/block/positioning/025-expected.txt
trunk/LayoutTests/platform/chromium-linux-x86/fast/block/positioning/fixed-position-stacking-context-expected.txt
trunk/LayoutTests/platform/chromium-mac/

[webkit-changes] [128680] trunk/Source/JavaScriptCore

2012-09-14 Thread fpizlo

Title: [128680] trunk/Source/_javascript_Core








Revision 128680
Author fpi...@apple.com
Date 2012-09-14 20:29:04 -0700 (Fri, 14 Sep 2012)


Log Message
All of the things in SparseArrayValueMap should be out-of-line
https://bugs.webkit.org/show_bug.cgi?id=96854

Reviewed by Andy Estes.

Those inline methods were buying us nothing.

* GNUmakefile.list.am:
* _javascript_Core.vcproj/_javascript_Core/_javascript_Core.vcproj:
* _javascript_Core.xcodeproj/project.pbxproj:
* runtime/JSArray.cpp:
* runtime/JSGlobalData.cpp:
* runtime/JSObject.cpp:
* runtime/RegExpMatchesArray.cpp:
* runtime/SparseArrayValueMap.cpp:
(JSC::SparseArrayValueMap::SparseArrayValueMap):
(JSC):
(JSC::SparseArrayValueMap::~SparseArrayValueMap):
(JSC::SparseArrayValueMap::finishCreation):
(JSC::SparseArrayValueMap::create):
(JSC::SparseArrayValueMap::destroy):
(JSC::SparseArrayValueMap::createStructure):
(JSC::SparseArrayValueMap::add):
(JSC::SparseArrayValueMap::putEntry):
(JSC::SparseArrayValueMap::putDirect):
(JSC::SparseArrayEntry::get):
(JSC::SparseArrayEntry::getNonSparseMode):
(JSC::SparseArrayValueMap::visitChildren):
* runtime/SparseArrayValueMapInlineMethods.h: Removed.

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/GNUmakefile.list.am
trunk/Source/_javascript_Core/_javascript_Core.vcproj/_javascript_Core/_javascript_Core.vcproj
trunk/Source/_javascript_Core/_javascript_Core.xcodeproj/project.pbxproj
trunk/Source/_javascript_Core/runtime/JSArray.cpp
trunk/Source/_javascript_Core/runtime/JSGlobalData.cpp
trunk/Source/_javascript_Core/runtime/JSObject.cpp
trunk/Source/_javascript_Core/runtime/RegExpMatchesArray.cpp
trunk/Source/_javascript_Core/runtime/SparseArrayValueMap.cpp


Removed Paths

trunk/Source/_javascript_Core/runtime/SparseArrayValueMapInlineMethods.h




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (128679 => 128680)

--- trunk/Source/_javascript_Core/ChangeLog	2012-09-15 01:43:41 UTC (rev 128679)
+++ trunk/Source/_javascript_Core/ChangeLog	2012-09-15 03:29:04 UTC (rev 128680)
@@ -1,3 +1,35 @@
+2012-09-14  Filip Pizlo  
+
+All of the things in SparseArrayValueMap should be out-of-line
+https://bugs.webkit.org/show_bug.cgi?id=96854
+
+Reviewed by Andy Estes.
+
+Those inline methods were buying us nothing.
+
+* GNUmakefile.list.am:
+* _javascript_Core.vcproj/_javascript_Core/_javascript_Core.vcproj:
+* _javascript_Core.xcodeproj/project.pbxproj:
+* runtime/JSArray.cpp:
+* runtime/JSGlobalData.cpp:
+* runtime/JSObject.cpp:
+* runtime/RegExpMatchesArray.cpp:
+* runtime/SparseArrayValueMap.cpp:
+(JSC::SparseArrayValueMap::SparseArrayValueMap):
+(JSC):
+(JSC::SparseArrayValueMap::~SparseArrayValueMap):
+(JSC::SparseArrayValueMap::finishCreation):
+(JSC::SparseArrayValueMap::create):
+(JSC::SparseArrayValueMap::destroy):
+(JSC::SparseArrayValueMap::createStructure):
+(JSC::SparseArrayValueMap::add):
+(JSC::SparseArrayValueMap::putEntry):
+(JSC::SparseArrayValueMap::putDirect):
+(JSC::SparseArrayEntry::get):
+(JSC::SparseArrayEntry::getNonSparseMode):
+(JSC::SparseArrayValueMap::visitChildren):
+* runtime/SparseArrayValueMapInlineMethods.h: Removed.
+
 2012-09-14  Mike West  
 
 JSC should throw a more descriptive exception when blocking 'eval' via CSP.


Modified: trunk/Source/_javascript_Core/GNUmakefile.list.am (128679 => 128680)

--- trunk/Source/_javascript_Core/GNUmakefile.list.am	2012-09-15 01:43:41 UTC (rev 128679)
+++ trunk/Source/_javascript_Core/GNUmakefile.list.am	2012-09-15 03:29:04 UTC (rev 128680)
@@ -647,7 +647,6 @@
 	Source/_javascript_Core/runtime/SamplingCounter.h \
 	Source/_javascript_Core/runtime/SmallStrings.cpp \
 	Source/_javascript_Core/runtime/SmallStrings.h \
-	Source/_javascript_Core/runtime/SparseArrayValueMapInlineMethods.h \
 	Source/_javascript_Core/runtime/SparseArrayValueMap.cpp \
 	Source/_javascript_Core/runtime/SparseArrayValueMap.h \
 	Source/_javascript_Core/runtime/StrictEvalActivation.cpp \


Modified: trunk/Source/_javascript_Core/_javascript_Core.vcproj/_javascript_Core/_javascript_Core.vcproj (128679 => 128680)

--- trunk/Source/_javascript_Core/_javascript_Core.vcproj/_javascript_Core/_javascript_Core.vcproj	2012-09-15 01:43:41 UTC (rev 128679)
+++ trunk/Source/_javascript_Core/_javascript_Core.vcproj/_javascript_Core/_javascript_Core.vcproj	2012-09-15 03:29:04 UTC (rev 128680)
@@ -518,10 +518,6 @@
 >
 			
 			-RelativePath="..\..\runtime\SparseArrayValueMapInlineMethods.h"
->
-			
-			 RelativePath="..\..\runtime\ArrayStorage.h"
 >
 			


Modified: trunk/Source/_javascript_Core/_javascript_Core.xcodeproj/project.pbxproj (128679 => 128680)

--- trunk/Source/_javascript_Core/_javascript_Core.xcodeproj/project.pbxproj	2012-09-15 01:43:41 UTC (rev 128679)
+++ trunk/Source/_javascript_Core/_javascri

[webkit-changes] [128679] trunk/Source/WebCore

2012-09-14 Thread commit-queue

Title: [128679] trunk/Source/WebCore








Revision 128679
Author commit-qu...@webkit.org
Date 2012-09-14 18:43:41 -0700 (Fri, 14 Sep 2012)


Log Message
Unreviewed, rolling out r128673.
http://trac.webkit.org/changeset/128673
https://bugs.webkit.org/show_bug.cgi?id=96847

Makes plugins/document-open.html crash (Requested by jamesr_
on #webkit).

Patch by Sheriff Bot  on 2012-09-14

* dom/ContainerNode.cpp:
(WebCore):
(WebCore::ContainerNode::insertBeforeCommon):
(WebCore::ContainerNode::replaceChild):
(WebCore::ContainerNode::removeBetween):
(WebCore::ContainerNode::removeChildren):
(WebCore::ContainerNode::appendChild):
(WebCore::ContainerNode::parserAddChild):
(WebCore::dispatchChildInsertionEvents):
(WebCore::dispatchChildRemovalEvents):
* dom/ContainerNode.h:
* dom/ContainerNodeAlgorithms.h:
(WebCore::ChildNodeInsertionNotifier::notifyNodeInsertedIntoTree):
(WebCore::ChildNodeInsertionNotifier::notify):
(WebCore::ChildNodeRemovalNotifier::notifyNodeRemovedFromTree):
* dom/Document.cpp:
(WebCore::Document::dispatchWindowEvent):
(WebCore::Document::dispatchWindowLoadEvent):
* dom/EventDispatcher.cpp:
(WebCore::EventDispatcher::dispatchEvent):
* dom/EventTarget.cpp:
(WebCore):
(WebCore::forbidEventDispatch):
(WebCore::allowEventDispatch):
(WebCore::eventDispatchForbidden):
(WebCore::EventTarget::fireEventListeners):
* dom/EventTarget.h:
(WebCore):
(WebCore::forbidEventDispatch):
(WebCore::allowEventDispatch):
* dom/Node.cpp:
(WebCore::Node::dispatchSubtreeModifiedEvent):
(WebCore::Node::dispatchFocusInEvent):
(WebCore::Node::dispatchFocusOutEvent):
(WebCore::Node::dispatchDOMActivateEvent):
* dom/WebKitNamedFlow.cpp:
(WebCore::WebKitNamedFlow::dispatchRegionLayoutUpdateEvent):
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::loadInternal):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/ContainerNode.cpp
trunk/Source/WebCore/dom/ContainerNode.h
trunk/Source/WebCore/dom/ContainerNodeAlgorithms.h
trunk/Source/WebCore/dom/Document.cpp
trunk/Source/WebCore/dom/EventDispatcher.cpp
trunk/Source/WebCore/dom/EventTarget.cpp
trunk/Source/WebCore/dom/EventTarget.h
trunk/Source/WebCore/dom/Node.cpp
trunk/Source/WebCore/dom/WebKitNamedFlow.cpp
trunk/Source/WebCore/html/HTMLMediaElement.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (128678 => 128679)

--- trunk/Source/WebCore/ChangeLog	2012-09-15 01:38:05 UTC (rev 128678)
+++ trunk/Source/WebCore/ChangeLog	2012-09-15 01:43:41 UTC (rev 128679)
@@ -1,3 +1,52 @@
+2012-09-14  Sheriff Bot  
+
+Unreviewed, rolling out r128673.
+http://trac.webkit.org/changeset/128673
+https://bugs.webkit.org/show_bug.cgi?id=96847
+
+Makes plugins/document-open.html crash (Requested by jamesr_
+on #webkit).
+
+* dom/ContainerNode.cpp:
+(WebCore):
+(WebCore::ContainerNode::insertBeforeCommon):
+(WebCore::ContainerNode::replaceChild):
+(WebCore::ContainerNode::removeBetween):
+(WebCore::ContainerNode::removeChildren):
+(WebCore::ContainerNode::appendChild):
+(WebCore::ContainerNode::parserAddChild):
+(WebCore::dispatchChildInsertionEvents):
+(WebCore::dispatchChildRemovalEvents):
+* dom/ContainerNode.h:
+* dom/ContainerNodeAlgorithms.h:
+(WebCore::ChildNodeInsertionNotifier::notifyNodeInsertedIntoTree):
+(WebCore::ChildNodeInsertionNotifier::notify):
+(WebCore::ChildNodeRemovalNotifier::notifyNodeRemovedFromTree):
+* dom/Document.cpp:
+(WebCore::Document::dispatchWindowEvent):
+(WebCore::Document::dispatchWindowLoadEvent):
+* dom/EventDispatcher.cpp:
+(WebCore::EventDispatcher::dispatchEvent):
+* dom/EventTarget.cpp:
+(WebCore):
+(WebCore::forbidEventDispatch):
+(WebCore::allowEventDispatch):
+(WebCore::eventDispatchForbidden):
+(WebCore::EventTarget::fireEventListeners):
+* dom/EventTarget.h:
+(WebCore):
+(WebCore::forbidEventDispatch):
+(WebCore::allowEventDispatch):
+* dom/Node.cpp:
+(WebCore::Node::dispatchSubtreeModifiedEvent):
+(WebCore::Node::dispatchFocusInEvent):
+(WebCore::Node::dispatchFocusOutEvent):
+(WebCore::Node::dispatchDOMActivateEvent):
+* dom/WebKitNamedFlow.cpp:
+(WebCore::WebKitNamedFlow::dispatchRegionLayoutUpdateEvent):
+* html/HTMLMediaElement.cpp:
+(WebCore::HTMLMediaElement::loadInternal):
+
 2012-09-14  Julien Chaffraix  
 
 Revert r127457 and following fixes due to several hit-testing regressions


Modified: trunk/Source/WebCore/dom/ContainerNode.cpp (128678 => 128679)

--- trunk/Source/WebCore/dom/ContainerNode.cpp	2012-09-15 01:38:05 UTC (rev 128678)
+++ trunk/Source/WebCore/dom/ContainerNode.cpp	2012-09-15 01:43:41 UTC (rev 128679)
@@ -64,10 +64,6 @@
 
 ChildNodesLazySnapshot* ChildNodesLazySnapshot::latestSnapshot = 0;
 
-#ifndef NDEBUG
-unsigned AssertNoEventDisp

[webkit-changes] [128678] trunk/Source/WebKit2

2012-09-14 Thread bdakin

Title: [128678] trunk/Source/WebKit2








Revision 128678
Author bda...@apple.com
Date 2012-09-14 18:38:05 -0700 (Fri, 14 Sep 2012)


Log Message
https://bugs.webkit.org/show_bug.cgi?id=96846
Tests failing on WK2 bots after giving fixed positioning its own 
stacking context

Reviewed by Geoffrey Garen.

Tests are failing because I checked in updated results that expect 
fixed positioning to create a stacking context. However, 
WebKitTestRunner does not enable ScrollingCoordinator, so the code 
that I added to enable stacking contexts for fixedPos is never 
actually running. This patch moves that code to a place where it will 
run for the testing tools, which matches the patch for WK1.
* WebProcess/WebPage/DrawingAreaImpl.cpp:
(WebKit::DrawingAreaImpl::updatePreferences):
* WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
(WebKit::TiledCoreAnimationDrawingArea::TiledCoreAnimationDrawingArea):

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/WebProcess/WebPage/DrawingAreaImpl.cpp
trunk/Source/WebKit2/WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm




Diff

Modified: trunk/Source/WebKit2/ChangeLog (128677 => 128678)

--- trunk/Source/WebKit2/ChangeLog	2012-09-15 01:24:30 UTC (rev 128677)
+++ trunk/Source/WebKit2/ChangeLog	2012-09-15 01:38:05 UTC (rev 128678)
@@ -1,3 +1,22 @@
+2012-09-14  Beth Dakin  
+
+https://bugs.webkit.org/show_bug.cgi?id=96846
+Tests failing on WK2 bots after giving fixed positioning its own 
+stacking context
+
+Reviewed by Geoffrey Garen.
+
+Tests are failing because I checked in updated results that expect 
+fixed positioning to create a stacking context. However, 
+WebKitTestRunner does not enable ScrollingCoordinator, so the code 
+that I added to enable stacking contexts for fixedPos is never 
+actually running. This patch moves that code to a place where it will 
+run for the testing tools, which matches the patch for WK1.
+* WebProcess/WebPage/DrawingAreaImpl.cpp:
+(WebKit::DrawingAreaImpl::updatePreferences):
+* WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
+(WebKit::TiledCoreAnimationDrawingArea::TiledCoreAnimationDrawingArea):
+
 2012-09-14  Julien Chaffraix  
 
 Revert r127457 and following fixes due to several hit-testing regressions


Modified: trunk/Source/WebKit2/WebProcess/WebPage/DrawingAreaImpl.cpp (128677 => 128678)

--- trunk/Source/WebKit2/WebProcess/WebPage/DrawingAreaImpl.cpp	2012-09-15 01:24:30 UTC (rev 128677)
+++ trunk/Source/WebKit2/WebProcess/WebPage/DrawingAreaImpl.cpp	2012-09-15 01:38:05 UTC (rev 128678)
@@ -261,9 +261,15 @@
 
 void DrawingAreaImpl::updatePreferences(const WebPreferencesStore& store)
 {
+#if PLATFORM(MAC)
+// Soon we want pages with fixed positioned elements to be able to be scrolled by the ScrollingCoordinator.
+// As a part of that work, we have to composite fixed position elements, and we have to allow those
+// elements to create a stacking context.
+m_webPage->corePage()->settings()->setAcceleratedCompositingForFixedPositionEnabled(true);
+m_webPage->corePage()->settings()->setFixedPositionCreatesStackingContext(true);
+
 // : It is necessary to force compositing when accelerate drawing
 // is enabled on Mac so that scrollbars are always in their own layers.
-#if PLATFORM(MAC)
 if (m_webPage->corePage()->settings()->acceleratedDrawingEnabled())
 m_webPage->corePage()->settings()->setForceCompositingMode(LayerTreeHost::supportsAcceleratedCompositing());
 else


Modified: trunk/Source/WebKit2/WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm (128677 => 128678)

--- trunk/Source/WebKit2/WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm	2012-09-15 01:24:30 UTC (rev 128677)
+++ trunk/Source/WebKit2/WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm	2012-09-15 01:38:05 UTC (rev 128678)
@@ -76,12 +76,6 @@
 page->settings()->setScrollingCoordinatorEnabled(true);
 page->settings()->setForceCompositingMode(true);
 
-// Soon we want pages with fixed positioned elements to be able to be scrolled by the ScrollingCoordinator.
-// As a part of that work, we have to composite fixed position elements, and we have to allow those
-// elements to create a stacking context.
-page->settings()->setAcceleratedCompositingForFixedPositionEnabled(true);
-page->settings()->setFixedPositionCreatesStackingContext(true);
-
 WebProcess::shared().eventDispatcher().addScrollingTreeForPage(webPage);
 
 m_rootLayer = [CALayer layer];






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [128676] trunk/LayoutTests

2012-09-14 Thread commit-queue

Title: [128676] trunk/LayoutTests








Revision 128676
Author commit-qu...@webkit.org
Date 2012-09-14 18:22:06 -0700 (Fri, 14 Sep 2012)


Log Message
Skip image load tests that requires queueReload in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=96832

Tests added in reivison 128645.

Patch by Bo Liu  on 2012-09-14
Reviewed by Adam Barth.

* platform/wk2/Skipped:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/wk2/Skipped




Diff

Modified: trunk/LayoutTests/ChangeLog (128675 => 128676)

--- trunk/LayoutTests/ChangeLog	2012-09-15 00:43:07 UTC (rev 128675)
+++ trunk/LayoutTests/ChangeLog	2012-09-15 01:22:06 UTC (rev 128676)
@@ -1,3 +1,14 @@
+2012-09-14  Bo Liu  
+
+Skip image load tests that requires queueReload in WebKit2
+https://bugs.webkit.org/show_bug.cgi?id=96832
+
+Tests added in reivison 128645.
+
+Reviewed by Adam Barth.
+
+* platform/wk2/Skipped:
+
 2012-09-14  Joshua Bell  
 
 IndexedDB: Calling close() during upgradeneeded handler should fire error at open request


Modified: trunk/LayoutTests/platform/wk2/Skipped (128675 => 128676)

--- trunk/LayoutTests/platform/wk2/Skipped	2012-09-15 00:43:07 UTC (rev 128675)
+++ trunk/LayoutTests/platform/wk2/Skipped	2012-09-15 01:22:06 UTC (rev 128676)
@@ -339,6 +339,8 @@
 # 
 fast/css/compare-content-style.html
 fast/frames/frame-display-none-focus.html
+fast/loader/display-image-unset-can-block-image-and-can-reload-in-place.html
+fast/loader/images-enabled-unset-can-block-image-and-can-reload-in-place.html
 fast/loader/reload-policy-delegate.html
 
 # WebKitTestRunner needs layoutTestController.queueLoad






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [128675] trunk/Tools

2012-09-14 Thread dpranke

Title: [128675] trunk/Tools








Revision 128675
Author dpra...@chromium.org
Date 2012-09-14 17:43:07 -0700 (Fri, 14 Sep 2012)


Log Message
nrwt: --additional-platform-dir is broken on chromium ports
https://bugs.webkit.org/show_bug.cgi?id=96840

Reviewed by Ojan Vafai.

Looks like I broke this when cleaning things up as part of
adding ML support. Fixing and adding a test.

* Scripts/webkitpy/layout_tests/port/chromium.py:
(ChromiumPort.default_baseline_search_path):
* Scripts/webkitpy/layout_tests/port/chromium_android.py:
(ChromiumAndroidPort.default_baseline_search_path):
* Scripts/webkitpy/layout_tests/port/chromium_linux.py:
(ChromiumLinuxPort.default_baseline_search_path):
* Scripts/webkitpy/layout_tests/port/chromium_mac.py:
(ChromiumMacPort.__init__):
* Scripts/webkitpy/layout_tests/port/chromium_win.py:
(ChromiumWinPort.setup_environ_for_server):
* Scripts/webkitpy/layout_tests/port/port_testcase.py:
(test_check_build):
(test_additional_platform_directory):

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium.py
trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_android.py
trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_linux.py
trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_mac.py
trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_win.py
trunk/Tools/Scripts/webkitpy/layout_tests/port/port_testcase.py




Diff

Modified: trunk/Tools/ChangeLog (128674 => 128675)

--- trunk/Tools/ChangeLog	2012-09-15 00:08:43 UTC (rev 128674)
+++ trunk/Tools/ChangeLog	2012-09-15 00:43:07 UTC (rev 128675)
@@ -1,3 +1,27 @@
+2012-09-14  Dirk Pranke  
+
+nrwt: --additional-platform-dir is broken on chromium ports
+https://bugs.webkit.org/show_bug.cgi?id=96840
+
+Reviewed by Ojan Vafai.
+
+Looks like I broke this when cleaning things up as part of
+adding ML support. Fixing and adding a test.
+
+* Scripts/webkitpy/layout_tests/port/chromium.py:
+(ChromiumPort.default_baseline_search_path):
+* Scripts/webkitpy/layout_tests/port/chromium_android.py:
+(ChromiumAndroidPort.default_baseline_search_path):
+* Scripts/webkitpy/layout_tests/port/chromium_linux.py:
+(ChromiumLinuxPort.default_baseline_search_path):
+* Scripts/webkitpy/layout_tests/port/chromium_mac.py:
+(ChromiumMacPort.__init__):
+* Scripts/webkitpy/layout_tests/port/chromium_win.py:
+(ChromiumWinPort.setup_environ_for_server):
+* Scripts/webkitpy/layout_tests/port/port_testcase.py:
+(test_check_build):
+(test_additional_platform_directory):
+
 2012-09-13  Stephanie Lewis  
 
 mac-future ignores previous platform TestExpectations.


Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium.py (128674 => 128675)

--- trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium.py	2012-09-15 00:08:43 UTC (rev 128674)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium.py	2012-09-15 00:43:07 UTC (rev 128675)
@@ -114,6 +114,9 @@
 def default_pixel_tests(self):
 return True
 
+def default_baseline_search_path(self):
+return map(self._webkit_baseline_path, self.FALLBACK_PATHS[self.version()])
+
 def default_timeout_ms(self):
 if self.get_option('configuration') == 'Debug':
 return 12 * 1000


Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_android.py (128674 => 128675)

--- trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_android.py	2012-09-15 00:08:43 UTC (rev 128674)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_android.py	2012-09-15 00:43:07 UTC (rev 128675)
@@ -187,7 +187,7 @@
 def default_child_processes(self):
 return len(self._get_devices())
 
-def baseline_search_path(self):
+def default_baseline_search_path(self):
 return map(self._webkit_baseline_path, self.FALLBACK_PATHS)
 
 def check_wdiff(self, logging=True):


Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_linux.py (128674 => 128675)

--- trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_linux.py	2012-09-15 00:08:43 UTC (rev 128674)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_linux.py	2012-09-15 00:43:07 UTC (rev 128675)
@@ -106,7 +106,7 @@
 self._version = 'lucid'  # We only support lucid right now.
 self._architecture = arch
 
-def baseline_search_path(self):
+def default_baseline_search_path(self):
 port_names = self.FALLBACK_PATHS[self._architecture]
 return map(self._webkit_baseline_path, port_names)
 


Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_mac.py (128674 => 128675)

--- trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_mac.py	2012-09-15 00:08:43 UTC (rev 128674)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_mac.py	2012-09-15 00:43:07 UTC (rev 128675)
@@ -79,10 +79,6 @@
 self._version = port_name[port_name.index('chr

[webkit-changes] [128674] trunk

2012-09-14 Thread jsbell

Title: [128674] trunk








Revision 128674
Author jsb...@chromium.org
Date 2012-09-14 17:08:43 -0700 (Fri, 14 Sep 2012)


Log Message
IndexedDB: Calling close() during upgradeneeded handler should fire error at open request
https://bugs.webkit.org/show_bug.cgi?id=96807

Reviewed by Tony Chang.

Source/WebCore:

Per spec, if the database connection is closed before the success event fires, the request
should have an error event of type AbortError fired at it.

Test: storage/indexeddb/intversion-close-in-upgradeneeded.html

* Modules/indexeddb/IDBDatabase.h:
(WebCore::IDBDatabase::isClosePending): Expose this state so an in-flight success can be morphed.
* Modules/indexeddb/IDBDatabaseBackendImpl.cpp:
(WebCore::IDBDatabaseBackendImpl::close): Fire the appropriate error at connections that are mid-opening.
* Modules/indexeddb/IDBOpenDBRequest.cpp:
(WebCore::IDBOpenDBRequest::onSuccess): If the connection was closed before the success is enqueued -
which can happen in multi-process ports with asynchronous messaging - convert the success to an error.

LayoutTests:

Update the test to match the spec behavior.

* storage/indexeddb/intversion-close-in-upgradeneeded-expected.txt:
* storage/indexeddb/resources/intversion-close-in-upgradeneeded.js:
(deleteSuccess):
(upgradeNeeded.transaction.oncomplete):
(upgradeNeeded):
(openError):

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/storage/indexeddb/intversion-close-in-upgradeneeded-expected.txt
trunk/LayoutTests/storage/indexeddb/resources/intversion-close-in-upgradeneeded.js
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/indexeddb/IDBDatabase.h
trunk/Source/WebCore/Modules/indexeddb/IDBDatabaseBackendImpl.cpp
trunk/Source/WebCore/Modules/indexeddb/IDBOpenDBRequest.cpp




Diff

Modified: trunk/LayoutTests/ChangeLog (128673 => 128674)

--- trunk/LayoutTests/ChangeLog	2012-09-15 00:04:59 UTC (rev 128673)
+++ trunk/LayoutTests/ChangeLog	2012-09-15 00:08:43 UTC (rev 128674)
@@ -1,3 +1,19 @@
+2012-09-14  Joshua Bell  
+
+IndexedDB: Calling close() during upgradeneeded handler should fire error at open request
+https://bugs.webkit.org/show_bug.cgi?id=96807
+
+Reviewed by Tony Chang.
+
+Update the test to match the spec behavior.
+
+* storage/indexeddb/intversion-close-in-upgradeneeded-expected.txt:
+* storage/indexeddb/resources/intversion-close-in-upgradeneeded.js:
+(deleteSuccess):
+(upgradeNeeded.transaction.oncomplete):
+(upgradeNeeded):
+(openError):
+
 2012-09-14  Ojan Vafai  
 
 Mark svg/carto.net/selectionlist.svg as flaky because it depends on svg/carto.net/button.svg


Modified: trunk/LayoutTests/storage/indexeddb/intversion-close-in-upgradeneeded-expected.txt (128673 => 128674)

--- trunk/LayoutTests/storage/indexeddb/intversion-close-in-upgradeneeded-expected.txt	2012-09-15 00:04:59 UTC (rev 128673)
+++ trunk/LayoutTests/storage/indexeddb/intversion-close-in-upgradeneeded-expected.txt	2012-09-15 00:08:43 UTC (rev 128674)
@@ -20,12 +20,19 @@
 transaction.oncomplete:
 sawTransactionComplete = true
 
-openSuccess():
+openError():
 PASS sawTransactionComplete is true
-db = event.target.result
+PASS event.target.errorCode is DOMException.ABORT_ERR
+PASS event.target.error.name is 'AbortError'
+PASS event.result is undefined
+
+Verify that the old connection is unchanged and was closed:
+PASS db is non-null.
 PASS db.version is 7
-transaction = db.transaction('os')
-FAIL transaction = db.transaction('os') threw exception Error: InvalidStateError: DOM IDBDatabase Exception 11
+Expecting exception from db.transaction('os')
+PASS Exception was thrown.
+PASS code is DOMException.INVALID_STATE_ERR
+PASS ename is 'InvalidStateError'
 PASS successfullyParsed is true
 
 TEST COMPLETE


Modified: trunk/LayoutTests/storage/indexeddb/resources/intversion-close-in-upgradeneeded.js (128673 => 128674)

--- trunk/LayoutTests/storage/indexeddb/resources/intversion-close-in-upgradeneeded.js	2012-09-15 00:04:59 UTC (rev 128673)
+++ trunk/LayoutTests/storage/indexeddb/resources/intversion-close-in-upgradeneeded.js	2012-09-15 00:08:43 UTC (rev 128674)
@@ -17,18 +17,17 @@
 
 function deleteSuccess(evt) {
 evalAndLog("request = indexedDB.open(dbname, 7)");
-request._onsuccess_ = openSuccess;
+request._onsuccess_ = unexpectedSuccessCallback;
 request._onupgradeneeded_ = upgradeNeeded;
 request._onblocked_ = unexpectedBlockedCallback;
+request._onerror_ = openError;
 debug("");
 }
 
 var sawTransactionComplete = false;
 function upgradeNeeded(evt)
 {
-event = evt;
-debug("");
-debug("upgradeNeeded():");
+preamble(evt);
 evalAndLog("db = event.target.result");
 shouldBe("event.newVersion", "7");
 
@@ -40,18 +39,24 @@
 debug("");
 debug("transaction.oncomplete:");
 evalAndLog("sawTransactionComplete = true");
-}
+};
 }
 
-function openSuccess(evt)
+function openError(evt)
 {
-event = evt;

[webkit-changes] [128673] trunk/Source/WebCore

2012-09-14 Thread rniwa

Title: [128673] trunk/Source/WebCore








Revision 128673
Author rn...@webkit.org
Date 2012-09-14 17:04:59 -0700 (Fri, 14 Sep 2012)


Log Message
Turn forbidEventDispatch and allowEventDispatch into a RAII object
https://bugs.webkit.org/show_bug.cgi?id=96717

Reviewed by Abhishek Arya.

Replaced forbidEventDispatch and allowEventDispatch by AssertNoEventDispatch.

* dom/ContainerNode.cpp:
(WebCore):
(WebCore::ContainerNode::insertBeforeCommon):
(WebCore::ContainerNode::replaceChild):
(WebCore::ContainerNode::removeBetween):
(WebCore::ContainerNode::removeChildren):
(WebCore::ContainerNode::appendChild):
(WebCore::ContainerNode::parserAddChild):
(WebCore::dispatchChildInsertionEvents):
(WebCore::dispatchChildRemovalEvents):
* dom/ContainerNode.h:
(AssertNoEventDispatch):
(WebCore::AssertNoEventDispatch::AssertNoEventDispatch):
(WebCore::AssertNoEventDispatch::~AssertNoEventDispatch):
(WebCore::AssertNoEventDispatch::isEventDispatchForbidden):
(WebCore):
* dom/ContainerNodeAlgorithms.h:
(WebCore::ChildNodeInsertionNotifier::notifyNodeInsertedIntoTree):
(WebCore::ChildNodeInsertionNotifier::notify):
(WebCore::ChildNodeRemovalNotifier::notifyNodeRemovedFromTree):
* dom/Document.cpp:
(WebCore::Document::dispatchWindowEvent):
(WebCore::Document::dispatchWindowLoadEvent):
* dom/EventDispatcher.cpp:
(WebCore::EventDispatcher::dispatchEvent):
* dom/EventTarget.cpp:
(WebCore):
(WebCore::EventTarget::fireEventListeners):
* dom/EventTarget.h:
(WebCore):
* dom/Node.cpp:
(WebCore::Node::dispatchSubtreeModifiedEvent):
(WebCore::Node::dispatchFocusInEvent):
(WebCore::Node::dispatchFocusOutEvent):
(WebCore::Node::dispatchDOMActivateEvent):
* dom/WebKitNamedFlow.cpp:
(WebCore::WebKitNamedFlow::dispatchRegionLayoutUpdateEvent):
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::loadInternal):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/ContainerNode.cpp
trunk/Source/WebCore/dom/ContainerNode.h
trunk/Source/WebCore/dom/ContainerNodeAlgorithms.h
trunk/Source/WebCore/dom/Document.cpp
trunk/Source/WebCore/dom/EventDispatcher.cpp
trunk/Source/WebCore/dom/EventTarget.cpp
trunk/Source/WebCore/dom/EventTarget.h
trunk/Source/WebCore/dom/Node.cpp
trunk/Source/WebCore/dom/WebKitNamedFlow.cpp
trunk/Source/WebCore/html/HTMLMediaElement.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (128672 => 128673)

--- trunk/Source/WebCore/ChangeLog	2012-09-14 23:41:16 UTC (rev 128672)
+++ trunk/Source/WebCore/ChangeLog	2012-09-15 00:04:59 UTC (rev 128673)
@@ -1,3 +1,52 @@
+2012-09-14  Ryosuke Niwa  
+
+Turn forbidEventDispatch and allowEventDispatch into a RAII object
+https://bugs.webkit.org/show_bug.cgi?id=96717
+
+Reviewed by Abhishek Arya.
+
+Replaced forbidEventDispatch and allowEventDispatch by AssertNoEventDispatch.
+
+* dom/ContainerNode.cpp:
+(WebCore):
+(WebCore::ContainerNode::insertBeforeCommon):
+(WebCore::ContainerNode::replaceChild):
+(WebCore::ContainerNode::removeBetween):
+(WebCore::ContainerNode::removeChildren):
+(WebCore::ContainerNode::appendChild):
+(WebCore::ContainerNode::parserAddChild):
+(WebCore::dispatchChildInsertionEvents):
+(WebCore::dispatchChildRemovalEvents):
+* dom/ContainerNode.h:
+(AssertNoEventDispatch):
+(WebCore::AssertNoEventDispatch::AssertNoEventDispatch):
+(WebCore::AssertNoEventDispatch::~AssertNoEventDispatch):
+(WebCore::AssertNoEventDispatch::isEventDispatchForbidden):
+(WebCore):
+* dom/ContainerNodeAlgorithms.h:
+(WebCore::ChildNodeInsertionNotifier::notifyNodeInsertedIntoTree):
+(WebCore::ChildNodeInsertionNotifier::notify):
+(WebCore::ChildNodeRemovalNotifier::notifyNodeRemovedFromTree):
+* dom/Document.cpp:
+(WebCore::Document::dispatchWindowEvent):
+(WebCore::Document::dispatchWindowLoadEvent):
+* dom/EventDispatcher.cpp:
+(WebCore::EventDispatcher::dispatchEvent):
+* dom/EventTarget.cpp:
+(WebCore):
+(WebCore::EventTarget::fireEventListeners):
+* dom/EventTarget.h:
+(WebCore):
+* dom/Node.cpp:
+(WebCore::Node::dispatchSubtreeModifiedEvent):
+(WebCore::Node::dispatchFocusInEvent):
+(WebCore::Node::dispatchFocusOutEvent):
+(WebCore::Node::dispatchDOMActivateEvent):
+* dom/WebKitNamedFlow.cpp:
+(WebCore::WebKitNamedFlow::dispatchRegionLayoutUpdateEvent):
+* html/HTMLMediaElement.cpp:
+(WebCore::HTMLMediaElement::loadInternal):
+
 2012-09-14  Mike West  
 
 JSC should throw a more descriptive exception when blocking 'eval' via CSP.


Modified: trunk/Source/WebCore/dom/ContainerNode.cpp (128672 => 128673)

--- trunk/Source/WebCore/dom/ContainerNode.cpp	2012-09-14 23:41:16 UTC (rev 128672)
+++ trunk/Source/WebCore/dom/ContainerNode.cpp	2012-09-15 00:04:59 UTC (rev 128673)
@@ -64,6 +64,10 @@
 
 ChildNodesLazySna

[webkit-changes] [128672] trunk/LayoutTests

2012-09-14 Thread ojan

Title: [128672] trunk/LayoutTests








Revision 128672
Author o...@chromium.org
Date 2012-09-14 16:41:16 -0700 (Fri, 14 Sep 2012)


Log Message
Mark svg/carto.net/selectionlist.svg as flaky because it depends on svg/carto.net/button.svg
running first in order to pass.
* platform/chromium/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (128671 => 128672)

--- trunk/LayoutTests/ChangeLog	2012-09-14 23:37:49 UTC (rev 128671)
+++ trunk/LayoutTests/ChangeLog	2012-09-14 23:41:16 UTC (rev 128672)
@@ -1,5 +1,11 @@
 2012-09-14  Ojan Vafai  
 
+Mark svg/carto.net/selectionlist.svg as flaky because it depends on svg/carto.net/button.svg
+running first in order to pass.
+* platform/chromium/TestExpectations:
+
+2012-09-14  Ojan Vafai  
+
 The cr-linux-ews thinks http/tests/cache/post-redirect-get.php and http/tests/cache/post-with-cached-subresources.php are MISSING results
 https://bugs.webkit.org/show_bug.cgi?id=95215
 


Modified: trunk/LayoutTests/platform/chromium/TestExpectations (128671 => 128672)

--- trunk/LayoutTests/platform/chromium/TestExpectations	2012-09-14 23:37:49 UTC (rev 128671)
+++ trunk/LayoutTests/platform/chromium/TestExpectations	2012-09-14 23:41:16 UTC (rev 128672)
@@ -3595,6 +3595,7 @@
 BUGWK96835 : platform/chromium/virtual/gpu/canvas/philip/tests/2d.text.draw.fontface.notinpage.html = TEXT PASS
 BUGWK96836 : inspector/debugger/xhr-breakpoints.html = TEXT PASS
 BUGWK96834 : platform/chromium/virtual/threaded/compositing/visibility/visibility-image-layers.html = IMAGE PASS
+BUGWK96833 : svg/carto.net/selectionlist.svg = IMAGE PASS
 BUGWK96833 : svg/carto.net/combobox.svg = IMAGE PASS
 
 BUGWK96720 MAC WIN : fast/forms/time-multiple-fields/time-multiple-fields-preserve-value-after-history-back.html = PASS TIMEOUT






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [128671] trunk/LayoutTests

2012-09-14 Thread ojan

Title: [128671] trunk/LayoutTests








Revision 128671
Author o...@chromium.org
Date 2012-09-14 16:37:49 -0700 (Fri, 14 Sep 2012)


Log Message
The cr-linux-ews thinks http/tests/cache/post-redirect-get.php and http/tests/cache/post-with-cached-subresources.php are MISSING results
https://bugs.webkit.org/show_bug.cgi?id=95215

Reviewed by Adam Barth.

Apparently, marking these as missing did not fix the EWS problem,
so remove them from TestExpectations.

* platform/chromium/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (128670 => 128671)

--- trunk/LayoutTests/ChangeLog	2012-09-14 23:33:20 UTC (rev 128670)
+++ trunk/LayoutTests/ChangeLog	2012-09-14 23:37:49 UTC (rev 128671)
@@ -1,3 +1,15 @@
+2012-09-14  Ojan Vafai  
+
+The cr-linux-ews thinks http/tests/cache/post-redirect-get.php and http/tests/cache/post-with-cached-subresources.php are MISSING results
+https://bugs.webkit.org/show_bug.cgi?id=95215
+
+Reviewed by Adam Barth.
+
+Apparently, marking these as missing did not fix the EWS problem,
+so remove them from TestExpectations.
+
+* platform/chromium/TestExpectations:
+
 2012-09-14  Mike West  
 
 JSC should throw a more descriptive exception when blocking 'eval' via CSP.


Modified: trunk/LayoutTests/platform/chromium/TestExpectations (128670 => 128671)

--- trunk/LayoutTests/platform/chromium/TestExpectations	2012-09-14 23:33:20 UTC (rev 128670)
+++ trunk/LayoutTests/platform/chromium/TestExpectations	2012-09-14 23:37:49 UTC (rev 128671)
@@ -2675,10 +2675,6 @@
 
 BUGWK71278 SLOW : fast/events/dispatch-message-string-data.html = PASS
 
-// For some reason the EWS bots cannot find the results for these tests.
-BUGWK95215 LINUX : http/tests/cache/post-redirect-get.php = PASS MISSING
-BUGWK95215 LINUX : http/tests/cache/post-with-cached-subresources.php = PASS MISSING
-
 BUGWK71451 SLOW : fast/frames/sandboxed-iframe-navigation-windowopen.html = PASS
 
 BUGWK94681 : fast/js/array-functions-non-arrays.html = TEXT
@@ -3134,10 +3130,6 @@
 BUGWK86592 LINUX ANDROID : fast/loader/unload-form-about-blank.html = TIMEOUT PASS
 BUGWK86592 LINUX ANDROID : http/tests/xmlhttprequest/zero-length-response-sync.html = TIMEOUT PASS
 
-// strange "Unexpected no expected results found" on cr-linux ews
-BUGWK86600 LINUX ANDROID : http/tests/cache/loaded-from-cache-after-reload-within-iframe.html = MISSING PASS
-BUGWK86600 LINUX ANDROID : http/tests/cache/loaded-from-cache-after-reload.html = MISSING PASS
-
 BUGWK88964 MAC : http/tests/misc/embedCrasher.html = MISSING PASS
 
 BUGWK86674 DEBUG : fast/dom/HTMLObjectElement/beforeload-set-text-crash.xhtml = TIMEOUT PASS






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [128670] trunk

2012-09-14 Thread commit-queue

Title: [128670] trunk








Revision 128670
Author commit-qu...@webkit.org
Date 2012-09-14 16:33:20 -0700 (Fri, 14 Sep 2012)


Log Message
JSC should throw a more descriptive exception when blocking 'eval' via CSP.
https://bugs.webkit.org/show_bug.cgi?id=94331

Patch by Mike West  on 2012-09-14
Reviewed by Geoffrey Garen.

Source/_javascript_Core:

Unless explicitly whitelisted, the 'script-src' Content Security Policy
directive blocks 'eval' and 'eval'-like constructs such as
'new Function()'. When 'eval' is encountered in code, an 'EvalError' is
thrown, but the associated message is poor: "Eval is disabled" doesn't
give developers enough information about why their code isn't behaving
as expected.

This patch adds an 'errorMessage' parameter to the _javascript_Core method
used to disable 'eval'; ContentSecurityPolicy has the opportunity to
pass in a more detailed and descriptive error that contains more context
for the developer.

* runtime/Executable.cpp:
(JSC::EvalExecutable::compileInternal):
Drop the hard-coded "Eval is disabled" error message in favor of
reading the error message off the global object.
* runtime/FunctionConstructor.cpp:
(JSC::FunctionConstructor::getCallData):
Drop the hard-coded "Function constructor is disabled" error message
in favor of reading the error message off the global object.
* runtime/JSGlobalObject.h:
(JSGlobalObject):
(JSC::JSGlobalObject::evalEnabled):
Making this accessor method const.
(JSC::JSGlobalObject::evalDisabledErrorMessage):
Accessor for the error message set via 'setEvalDisabled'.
(JSC::JSGlobalObject::setEvalEnabled):
Adding an 'errorMessage' parameter which is stored on the global
object, and used when exceptions are thrown.

Source/WebCore:

Unless explicitly whitelisted, the 'script-src' Content Security Policy
directive blocks 'eval' and 'eval'-like constructs such as
'new Function()'. When 'eval' is encountered in code, an 'EvalError' is
thrown, but the associated message is poor: "Eval is disabled" doesn't
give developers enough information about why their code isn't behaving
as expected.

This patch adds an 'errorMessage' parameter to the _javascript_Core method
used to disable 'eval'; ContentSecurityPolicy has the opportunity to
pass in a more detailed and descriptive error that contains more context
for the developer.

The new error message is tested by adjusting existing tests; nothing new
is required.

* bindings/js/ScriptController.cpp:
(WebCore::ScriptController::initScript):
Read the error message off the document's ContentSecurityPolicy.
(WebCore::ScriptController::disableEval):
* bindings/js/ScriptController.h:
(ScriptController):
Pipe the error message through to JSGlobalObject when disabling eval
* bindings/js/WorkerScriptController.cpp:
(WebCore::WorkerScriptController::disableEval):
* bindings/js/WorkerScriptController.h:
(WorkerScriptController):
Pipe the error message through to JSGlobalObject when disabling eval
* bindings/v8/ScriptController.cpp:
(WebCore::ScriptController::disableEval):
* bindings/v8/ScriptController.h:
(ScriptController):
* bindings/v8/WorkerScriptController.cpp:
(WebCore::WorkerScriptController::disableEval):
* bindings/v8/WorkerScriptController.h:
(WorkerScriptController):
Placeholder for V8 piping to be built in webk.it/94332.
* dom/Document.cpp:
(WebCore::Document::disableEval):
* dom/Document.h:
(Document):
* dom/ScriptExecutionContext.h:
(ScriptExecutionContext):
Pipe the error message through to the ScriptController when
disabling eval.
* page/ContentSecurityPolicy.cpp:
(WebCore::CSPDirectiveList::evalDisabledErrorMessage):
Accessor for the error message that ought be displayed to developers
when 'eval' used while disabled for a specific directive list.
(WebCore::CSPDirectiveList::setEvalDisabledErrorMessage):
Mutator for the error message that ought be displayed to developers
when 'eval' used while disabled for a specific directive list.
(CSPDirectiveList):
(WebCore::CSPDirectiveList::create):
Upon creation of a CSPDirectiveList, set the error message if the
directive list disables 'eval'.
(WebCore::ContentSecurityPolicy::didReceiveHeader):
Pass the error message into ScriptExecutionContext::disableEval.
(WebCore::ContentSecurityPolicy::evalDisabledErrorMessage):
Public accessor for the policy's error message; walks the list of
directive lists and returns the first error message found.
(WebCore):
* page/ContentSecurityPolicy.h:
* workers/WorkerContext.cpp:
(WebCore::WorkerContext::disableEval):
* workers/WorkerContext.h:
(WorkerContext):
Pipe the error message through to the ScriptController when
disabling eval.

LayoutTests:

* http/tests/security/contentSecurityPolicy/eval-blocked-expected.txt:
* http/tests/security/contentSecurityPolicy/eval-blocked-in-about-blank-iframe-expected.txt:
* http/tests/security/contentSecurityPolicy/function-constructor-blocked-expected.txt:

Modified Paths

trunk/LayoutTes

[webkit-changes] [128669] trunk/Source/WebCore

2012-09-14 Thread commit-queue

Title: [128669] trunk/Source/WebCore








Revision 128669
Author commit-qu...@webkit.org
Date 2012-09-14 16:25:56 -0700 (Fri, 14 Sep 2012)


Log Message
Remove V8DOMWindowShell::getEntered
https://bugs.webkit.org/show_bug.cgi?id=96637

Patch by Dan Carney  on 2012-09-14
Reviewed by Adam Barth.

V8DOMWindowShell::getEntered was refactored so that the window shell
no longer has to be kept alive by a v8 context but rather a smaller
object.

No new tests. No change in functionality.

* bindings/v8/DOMData.cpp:
(WebCore::DOMData::getCurrentStore):
* bindings/v8/ScopedPersistent.h:
(WebCore::ScopedPersistent::leakHandle):
(ScopedPersistent):
* bindings/v8/ScriptController.cpp:
(WebCore::ScriptController::resetIsolatedWorlds):
(WebCore::ScriptController::evaluateInIsolatedWorld):
(WebCore::ScriptController::currentWorldContext):
* bindings/v8/V8Binding.cpp:
(WebCore::perContextDataForCurrentWorld):
* bindings/v8/V8DOMWindowShell.cpp:
(WebCore::setIsolatedWorldField):
(WebCore::V8DOMWindowShell::toIsolatedContextData):
(WebCore::isolatedContextWeakCallback):
(WebCore::V8DOMWindowShell::disposeContext):
(WebCore::V8DOMWindowShell::clearIsolatedShell):
(WebCore):
(WebCore::V8DOMWindowShell::initializeIfNeeded):
(WebCore::V8DOMWindowShell::setIsolatedWorldSecurityOrigin):
* bindings/v8/V8DOMWindowShell.h:
(V8DOMWindowShell):
(IsolatedContextData):
(WebCore::V8DOMWindowShell::IsolatedContextData::create):
(WebCore::V8DOMWindowShell::IsolatedContextData::world):
(WebCore::V8DOMWindowShell::IsolatedContextData::perContextData):
(WebCore::V8DOMWindowShell::IsolatedContextData::setSecurityOrigin):
(WebCore::V8DOMWindowShell::IsolatedContextData::securityOrigin):
(WebCore::V8DOMWindowShell::IsolatedContextData::IsolatedContextData):
(WebCore::V8DOMWindowShell::enteredIsolatedContext):
(WebCore::V8DOMWindowShell::enteredIsolatedContextData):
* bindings/v8/V8DOMWrapper.h:
(WebCore::V8DOMWrapper::getCachedWrapper):
* bindings/v8/WorldContextHandle.cpp:
(WebCore::WorldContextHandle::WorldContextHandle):
* bindings/v8/custom/V8DocumentCustom.cpp:
(WebCore::toV8):
* bindings/v8/custom/V8HTMLDocumentCustom.cpp:
(WebCore::toV8):
* bindings/v8/custom/V8SVGDocumentCustom.cpp:
(WebCore::toV8):
* bindings/v8/custom/V8XMLHttpRequestConstructor.cpp:
(WebCore::V8XMLHttpRequest::constructorCallback):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/v8/DOMData.cpp
trunk/Source/WebCore/bindings/v8/ScopedPersistent.h
trunk/Source/WebCore/bindings/v8/ScriptController.cpp
trunk/Source/WebCore/bindings/v8/V8Binding.cpp
trunk/Source/WebCore/bindings/v8/V8DOMWindowShell.cpp
trunk/Source/WebCore/bindings/v8/V8DOMWindowShell.h
trunk/Source/WebCore/bindings/v8/V8DOMWrapper.h
trunk/Source/WebCore/bindings/v8/WorldContextHandle.cpp
trunk/Source/WebCore/bindings/v8/custom/V8DocumentCustom.cpp
trunk/Source/WebCore/bindings/v8/custom/V8HTMLDocumentCustom.cpp
trunk/Source/WebCore/bindings/v8/custom/V8SVGDocumentCustom.cpp
trunk/Source/WebCore/bindings/v8/custom/V8XMLHttpRequestConstructor.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (128668 => 128669)

--- trunk/Source/WebCore/ChangeLog	2012-09-14 23:19:39 UTC (rev 128668)
+++ trunk/Source/WebCore/ChangeLog	2012-09-14 23:25:56 UTC (rev 128669)
@@ -1,3 +1,60 @@
+2012-09-14  Dan Carney  
+
+Remove V8DOMWindowShell::getEntered
+https://bugs.webkit.org/show_bug.cgi?id=96637
+
+Reviewed by Adam Barth.
+
+V8DOMWindowShell::getEntered was refactored so that the window shell
+no longer has to be kept alive by a v8 context but rather a smaller
+object.
+
+No new tests. No change in functionality.
+
+* bindings/v8/DOMData.cpp:
+(WebCore::DOMData::getCurrentStore):
+* bindings/v8/ScopedPersistent.h:
+(WebCore::ScopedPersistent::leakHandle):
+(ScopedPersistent):
+* bindings/v8/ScriptController.cpp:
+(WebCore::ScriptController::resetIsolatedWorlds):
+(WebCore::ScriptController::evaluateInIsolatedWorld):
+(WebCore::ScriptController::currentWorldContext):
+* bindings/v8/V8Binding.cpp:
+(WebCore::perContextDataForCurrentWorld):
+* bindings/v8/V8DOMWindowShell.cpp:
+(WebCore::setIsolatedWorldField):
+(WebCore::V8DOMWindowShell::toIsolatedContextData):
+(WebCore::isolatedContextWeakCallback):
+(WebCore::V8DOMWindowShell::disposeContext):
+(WebCore::V8DOMWindowShell::clearIsolatedShell):
+(WebCore):
+(WebCore::V8DOMWindowShell::initializeIfNeeded):
+(WebCore::V8DOMWindowShell::setIsolatedWorldSecurityOrigin):
+* bindings/v8/V8DOMWindowShell.h:
+(V8DOMWindowShell):
+(IsolatedContextData):
+(WebCore::V8DOMWindowShell::IsolatedContextData::create):
+(WebCore::V8DOMWindowShell::IsolatedContextData::world):
+(WebCore::V8DOMWindowShell::IsolatedContextData::perContextData):
+(WebCore::V8DOMWindowShell::IsolatedContextData

[webkit-changes] [128668] trunk/LayoutTests

2012-09-14 Thread ojan

Title: [128668] trunk/LayoutTests








Revision 128668
Author o...@chromium.org
Date 2012-09-14 16:19:39 -0700 (Fri, 14 Sep 2012)


Log Message
Mark compositing/geometry/fixed-position-transform-composited-page-scale.html flaky
as it's flaky on all the Chromium bots.
* platform/chromium/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (128667 => 128668)

--- trunk/LayoutTests/ChangeLog	2012-09-14 23:13:07 UTC (rev 128667)
+++ trunk/LayoutTests/ChangeLog	2012-09-14 23:19:39 UTC (rev 128668)
@@ -1,3 +1,16 @@
+2012-09-14  Ojan Vafai  
+
+Mark compositing/geometry/fixed-position-transform-composited-page-scale.html flaky
+as it's flaky on all the Chromium bots.
+* platform/chromium/TestExpectations:
+
+2012-09-14  Ojan Vafai  
+
+Add expectations for tests that depend on other tests running before them.
+Filed a bug for each with information on which test it depends on.
+
+* platform/chromium/TestExpectations:
+
 2012-09-14  Michelangelo De Simone  
 
 [CSS Shaders] u_textureSize uniform should be set to the size of the texture.


Modified: trunk/LayoutTests/platform/chromium/TestExpectations (128667 => 128668)

--- trunk/LayoutTests/platform/chromium/TestExpectations	2012-09-14 23:13:07 UTC (rev 128667)
+++ trunk/LayoutTests/platform/chromium/TestExpectations	2012-09-14 23:19:39 UTC (rev 128668)
@@ -3229,6 +3229,7 @@
 // Timing out on some Windows bots
 BUGWK89510 WIN : gamepad/gamepad-polling-access.html = PASS TIMEOUT
 
+BUGWK96839 : compositing/geometry/fixed-position-transform-composited-page-scale.html = PASS IMAGE
 BUGWK89702 : compositing/geometry/fixed-position-transform-composited-page-scale-down.html = PASS IMAGE
 BUGWK89702 : compositing/scaling/tiled-layer-recursion.html = PASS IMAGE
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [128667] trunk/Source/JavaScriptCore

2012-09-14 Thread fpizlo

Title: [128667] trunk/Source/_javascript_Core








Revision 128667
Author fpi...@apple.com
Date 2012-09-14 16:13:07 -0700 (Fri, 14 Sep 2012)


Log Message
bbc homepage crashes immediately
https://bugs.webkit.org/show_bug.cgi?id=96812


Reviewed by Oliver Hunt.

If you use the old storage pointer to write to space you thought was newly allocated,
you're going to have a bad time.

* runtime/JSArray.cpp:
(JSC::JSArray::unshiftCount):

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/runtime/JSArray.cpp




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (128666 => 128667)

--- trunk/Source/_javascript_Core/ChangeLog	2012-09-14 23:11:39 UTC (rev 128666)
+++ trunk/Source/_javascript_Core/ChangeLog	2012-09-14 23:13:07 UTC (rev 128667)
@@ -1,3 +1,17 @@
+2012-09-14  Filip Pizlo  
+
+bbc homepage crashes immediately
+https://bugs.webkit.org/show_bug.cgi?id=96812
+
+
+Reviewed by Oliver Hunt.
+
+If you use the old storage pointer to write to space you thought was newly allocated,
+you're going to have a bad time.
+
+* runtime/JSArray.cpp:
+(JSC::JSArray::unshiftCount):
+
 2012-09-14  Adam Barth  
 
 Remove webkitPostMessage


Modified: trunk/Source/_javascript_Core/runtime/JSArray.cpp (128666 => 128667)

--- trunk/Source/_javascript_Core/runtime/JSArray.cpp	2012-09-14 23:11:39 UTC (rev 128666)
+++ trunk/Source/_javascript_Core/runtime/JSArray.cpp	2012-09-14 23:13:07 UTC (rev 128667)
@@ -549,7 +549,9 @@
 storage = m_butterfly->arrayStorage();
 storage->m_indexBias -= count;
 storage->setVectorLength(storage->vectorLength() + count);
-} else if (!unshiftCountSlowCase(exec->globalData(), count)) {
+} else if (unshiftCountSlowCase(exec->globalData(), count))
+storage = arrayStorage();
+else {
 throwOutOfMemoryError(exec);
 return true;
 }






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [128666] trunk

2012-09-14 Thread michelangelo

Title: [128666] trunk








Revision 128666
Author michelang...@webkit.org
Date 2012-09-14 16:11:39 -0700 (Fri, 14 Sep 2012)


Log Message
[CSS Shaders] u_textureSize uniform should be set to the size of the texture.
https://bugs.webkit.org/show_bug.cgi?id=95914

Reviewed by Dean Jackson.

Source/WebCore:

This adds support for the following shader uniform variables:

uniform vec2 u_textureSize
uniform vec4 u_meshBox
uniform vec2 u_tileSize
uniform vec2 u_meshSize

The relevant section of the specification is:
http://dvcs.w3.org/hg/FXTF/raw-file/tip/filters/index.html#shader-uniform-variables

Tests: css3/filters/custom/custom-filter-u-mesh-box.html
   css3/filters/custom/custom-filter-u-mesh-size.html
   css3/filters/custom/custom-filter-u-texture-size.html
   css3/filters/custom/custom-filter-u-tile-size.html

* platform/graphics/filters/FECustomFilter.cpp:
(WebCore::FECustomFilter::bindProgramAndBuffers):

LayoutTests:

Tests for the following uniform variables:
uniform vec2 u_textureSize
uniform vec4 u_meshBox
uniform vec2 u_tileSize
uniform vec2 u_meshSize

The relevant section of the specification is:
http://dvcs.w3.org/hg/FXTF/raw-file/tip/filters/index.html#shader-uniform-variables

* css3/filters/custom/custom-filter-u-mesh-box-expected.html: Added.
* css3/filters/custom/custom-filter-u-mesh-box.html: Added.
* css3/filters/custom/custom-filter-u-mesh-size-expected.html: Added.
* css3/filters/custom/custom-filter-u-mesh-size.html: Added.
* css3/filters/custom/custom-filter-u-texture-size-expected.html: Added.
* css3/filters/custom/custom-filter-u-texture-size.html: Added.
* css3/filters/custom/custom-filter-u-tile-size-expected.html: Added.
* css3/filters/custom/custom-filter-u-tile-size.html: Added.
* css3/filters/resources/u-mesh-box-is-unit-square.fs: Added.
* css3/filters/resources/u-mesh-size.fs: Added.
* css3/filters/resources/u-texture-size.fs: Added.
* css3/filters/resources/u-tile-size.fs: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/filters/FECustomFilter.cpp


Added Paths

trunk/LayoutTests/css3/filters/custom/custom-filter-u-mesh-box-expected.html
trunk/LayoutTests/css3/filters/custom/custom-filter-u-mesh-box.html
trunk/LayoutTests/css3/filters/custom/custom-filter-u-mesh-size-expected.html
trunk/LayoutTests/css3/filters/custom/custom-filter-u-mesh-size.html
trunk/LayoutTests/css3/filters/custom/custom-filter-u-texture-size-expected.html
trunk/LayoutTests/css3/filters/custom/custom-filter-u-texture-size.html
trunk/LayoutTests/css3/filters/custom/custom-filter-u-tile-size-expected.html
trunk/LayoutTests/css3/filters/custom/custom-filter-u-tile-size.html
trunk/LayoutTests/css3/filters/resources/u-mesh-box-is-unit-square.fs
trunk/LayoutTests/css3/filters/resources/u-mesh-size.fs
trunk/LayoutTests/css3/filters/resources/u-texture-size.fs
trunk/LayoutTests/css3/filters/resources/u-tile-size.fs




Diff

Modified: trunk/LayoutTests/ChangeLog (128665 => 128666)

--- trunk/LayoutTests/ChangeLog	2012-09-14 23:06:26 UTC (rev 128665)
+++ trunk/LayoutTests/ChangeLog	2012-09-14 23:11:39 UTC (rev 128666)
@@ -1,3 +1,32 @@
+2012-09-14  Michelangelo De Simone  
+
+[CSS Shaders] u_textureSize uniform should be set to the size of the texture.
+https://bugs.webkit.org/show_bug.cgi?id=95914
+
+Reviewed by Dean Jackson.
+
+Tests for the following uniform variables:
+uniform vec2 u_textureSize
+uniform vec4 u_meshBox
+uniform vec2 u_tileSize
+uniform vec2 u_meshSize
+
+The relevant section of the specification is:
+http://dvcs.w3.org/hg/FXTF/raw-file/tip/filters/index.html#shader-uniform-variables
+
+* css3/filters/custom/custom-filter-u-mesh-box-expected.html: Added.
+* css3/filters/custom/custom-filter-u-mesh-box.html: Added.
+* css3/filters/custom/custom-filter-u-mesh-size-expected.html: Added.
+* css3/filters/custom/custom-filter-u-mesh-size.html: Added.
+* css3/filters/custom/custom-filter-u-texture-size-expected.html: Added.
+* css3/filters/custom/custom-filter-u-texture-size.html: Added.
+* css3/filters/custom/custom-filter-u-tile-size-expected.html: Added.
+* css3/filters/custom/custom-filter-u-tile-size.html: Added.
+* css3/filters/resources/u-mesh-box-is-unit-square.fs: Added.
+* css3/filters/resources/u-mesh-size.fs: Added.
+* css3/filters/resources/u-texture-size.fs: Added.
+* css3/filters/resources/u-tile-size.fs: Added.
+
 2012-09-14  Alexey Proskuryakov  
 
 Unreviewed.


Added: trunk/LayoutTests/css3/filters/custom/custom-filter-u-mesh-box-expected.html (0 => 128666)

--- trunk/LayoutTests/css3/filters/custom/custom-filter-u-mesh-box-expected.html	(rev 0)
+++ trunk/LayoutTests/css3/filters/custom/custom-filter-u-mesh-box-expected.html	2012-09-14 23:11:3

[webkit-changes] [128665] trunk/LayoutTests

2012-09-14 Thread ap

Title: [128665] trunk/LayoutTests








Revision 128665
Author a...@apple.com
Date 2012-09-14 16:06:26 -0700 (Fri, 14 Sep 2012)


Log Message
Unreviewed.

A small improvement to this flaky test: use a correct URL, so that the test fails
quickly and understandably instead of timing out. This code path didn't use to be
taken before, so the URL was always wrong.

* fast/loader/resources/submit-form-while-parsing-subframe.html:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/loader/resources/submit-form-while-parsing-subframe.html




Diff

Modified: trunk/LayoutTests/ChangeLog (128664 => 128665)

--- trunk/LayoutTests/ChangeLog	2012-09-14 22:49:51 UTC (rev 128664)
+++ trunk/LayoutTests/ChangeLog	2012-09-14 23:06:26 UTC (rev 128665)
@@ -1,3 +1,13 @@
+2012-09-14  Alexey Proskuryakov  
+
+Unreviewed.
+
+A small improvement to this flaky test: use a correct URL, so that the test fails
+quickly and understandably instead of timing out. This code path didn't use to be
+taken before, so the URL was always wrong.
+
+* fast/loader/resources/submit-form-while-parsing-subframe.html:
+
 2012-09-14  Stephanie Lewis  
 
 new fast/loader tests from r128645 fail on Mac-wk2.


Modified: trunk/LayoutTests/fast/loader/resources/submit-form-while-parsing-subframe.html (128664 => 128665)

--- trunk/LayoutTests/fast/loader/resources/submit-form-while-parsing-subframe.html	2012-09-14 22:49:51 UTC (rev 128664)
+++ trunk/LayoutTests/fast/loader/resources/submit-form-while-parsing-subframe.html	2012-09-14 23:06:26 UTC (rev 128665)
@@ -5,5 +5,5 @@
 testRunner.waitUntilDone();
 }
 document.forms.form.submit();
-setTimeout("location='resources/submit-form-while-parsing-success.html'", 0);
+setTimeout("location='submit-form-while-parsing-success.html'", 0);
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [128664] trunk/LayoutTests

2012-09-14 Thread slewis

Title: [128664] trunk/LayoutTests








Revision 128664
Author sle...@apple.com
Date 2012-09-14 15:49:51 -0700 (Fri, 14 Sep 2012)


Log Message
new fast/loader tests from r128645 fail on Mac-wk2.
https://bugs.webkit.org/show_bug.cgi?id=96832.

Unreviewed.

Update TestExpectations

* platform/mac-wk2/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac-wk2/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (128663 => 128664)

--- trunk/LayoutTests/ChangeLog	2012-09-14 22:49:38 UTC (rev 128663)
+++ trunk/LayoutTests/ChangeLog	2012-09-14 22:49:51 UTC (rev 128664)
@@ -1,3 +1,14 @@
+2012-09-14  Stephanie Lewis  
+
+new fast/loader tests from r128645 fail on Mac-wk2.
+https://bugs.webkit.org/show_bug.cgi?id=96832.
+
+Unreviewed.
+
+Update TestExpectations
+
+* platform/mac-wk2/TestExpectations:
+
 2012-09-14  Ojan Vafai  
 
 Add expectations for tests that depend on other tests running before them.


Modified: trunk/LayoutTests/platform/mac-wk2/TestExpectations (128663 => 128664)

--- trunk/LayoutTests/platform/mac-wk2/TestExpectations	2012-09-14 22:49:38 UTC (rev 128663)
+++ trunk/LayoutTests/platform/mac-wk2/TestExpectations	2012-09-14 22:49:51 UTC (rev 128664)
@@ -9,3 +9,6 @@
 // WK2 tests fail image diff
 BUGWK96580 : css3/filters/custom/filter-fallback-to-software.html = IMAGE
 
+// new fast/load tests fail https://bugs.webkit.org/show_bug.cgi?id=96832
+BUGWK96832 : fast/loader/images-enabled-unset-can-block-image-and-can-reload-in-place.html = TEXT
+BUGWK96832 : fast/loader/display-image-unset-can-block-image-and-can-reload-in-place.html = TEXT






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [128663] trunk/Source

2012-09-14 Thread ojan

Title: [128663] trunk/Source








Revision 128663
Author o...@chromium.org
Date 2012-09-14 15:49:38 -0700 (Fri, 14 Sep 2012)


Log Message
Provide a runtime setting to disable position:sticky
https://bugs.webkit.org/show_bug.cgi?id=96827

Reviewed by James Robinson.

Source/WebCore:

Have it be on by default so that only ports that both enable
the define and don't want it on by default need to do something special.

* css/CSSParser.cpp:
(WebCore::CSSParserContext::CSSParserContext):
(WebCore::operator==):
(WebCore::isValidKeywordPropertyAndValue):
* css/CSSParserMode.h:
(CSSParserContext):
* dom/Document.cpp:
(WebCore::Document::cssStickyPositionEnabled):
(WebCore):
* dom/Document.h:
(Document):
* page/Settings.cpp:
(WebCore::Settings::Settings):
* page/Settings.h:
(Settings):
(WebCore::Settings::setCSSStickyPositionEnabled):
(WebCore::Settings::cssStickyPositionEnabled):

Source/WebKit/chromium:

* public/WebSettings.h:
* src/WebSettingsImpl.cpp:
(WebKit::WebSettingsImpl::setCSSStickyPositionEnabled):
(WebKit):
* src/WebSettingsImpl.h:
(WebSettingsImpl):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/CSSParser.cpp
trunk/Source/WebCore/css/CSSParserMode.h
trunk/Source/WebCore/dom/Document.cpp
trunk/Source/WebCore/dom/Document.h
trunk/Source/WebCore/page/Settings.cpp
trunk/Source/WebCore/page/Settings.h
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/public/WebSettings.h
trunk/Source/WebKit/chromium/src/WebSettingsImpl.cpp
trunk/Source/WebKit/chromium/src/WebSettingsImpl.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (128662 => 128663)

--- trunk/Source/WebCore/ChangeLog	2012-09-14 22:48:12 UTC (rev 128662)
+++ trunk/Source/WebCore/ChangeLog	2012-09-14 22:49:38 UTC (rev 128663)
@@ -1,3 +1,31 @@
+2012-09-14  Ojan Vafai  
+
+Provide a runtime setting to disable position:sticky
+https://bugs.webkit.org/show_bug.cgi?id=96827
+
+Reviewed by James Robinson.
+
+Have it be on by default so that only ports that both enable
+the define and don't want it on by default need to do something special.
+
+* css/CSSParser.cpp:
+(WebCore::CSSParserContext::CSSParserContext):
+(WebCore::operator==):
+(WebCore::isValidKeywordPropertyAndValue):
+* css/CSSParserMode.h:
+(CSSParserContext):
+* dom/Document.cpp:
+(WebCore::Document::cssStickyPositionEnabled):
+(WebCore):
+* dom/Document.h:
+(Document):
+* page/Settings.cpp:
+(WebCore::Settings::Settings):
+* page/Settings.h:
+(Settings):
+(WebCore::Settings::setCSSStickyPositionEnabled):
+(WebCore::Settings::cssStickyPositionEnabled):
+
 2012-09-14  Simon Fraser  
 
 Fix builds with CSS_IMAGE_RESOLUTION enabled after r128656.


Modified: trunk/Source/WebCore/css/CSSParser.cpp (128662 => 128663)

--- trunk/Source/WebCore/css/CSSParser.cpp	2012-09-14 22:48:12 UTC (rev 128662)
+++ trunk/Source/WebCore/css/CSSParser.cpp	2012-09-14 22:49:38 UTC (rev 128663)
@@ -199,6 +199,7 @@
 , mode(mode)
 , isHTMLDocument(false)
 , isCSSCustomFilterEnabled(false)
+, isCSSStickyPositionEnabled(false)
 , isCSSRegionsEnabled(false)
 , isCSSGridLayoutEnabled(false)
 #if ENABLE(CSS_VARIABLES)
@@ -215,6 +216,7 @@
 , mode(document->inQuirksMode() ? CSSQuirksMode : CSSStrictMode)
 , isHTMLDocument(document->isHTMLDocument())
 , isCSSCustomFilterEnabled(document->settings() ? document->settings()->isCSSCustomFilterEnabled() : false)
+, isCSSStickyPositionEnabled(document->cssStickyPositionEnabled())
 , isCSSRegionsEnabled(document->cssRegionsEnabled())
 , isCSSGridLayoutEnabled(document->cssGridLayoutEnabled())
 #if ENABLE(CSS_VARIABLES)
@@ -232,6 +234,7 @@
 && a.mode == b.mode
 && a.isHTMLDocument == b.isHTMLDocument
 && a.isCSSCustomFilterEnabled == b.isCSSCustomFilterEnabled
+&& a.isCSSStickyPositionEnabled == b.isCSSStickyPositionEnabled
 && a.isCSSRegionsEnabled == b.isCSSRegionsEnabled
 && a.isCSSGridLayoutEnabled == b.isCSSGridLayoutEnabled
 #if ENABLE(CSS_VARIABLES)
@@ -670,7 +673,7 @@
 case CSSPropertyPosition: // static | relative | absolute | fixed | sticky | inherit
 if (valueID == CSSValueStatic || valueID == CSSValueRelative || valueID == CSSValueAbsolute || valueID == CSSValueFixed
 #if ENABLE(CSS_STICKY_POSITION)
-|| valueID == CSSValueWebkitSticky
+|| (parserContext.isCSSStickyPositionEnabled && valueID == CSSValueWebkitSticky)
 #endif
 )
 return true;


Modified: trunk/Source/WebCore/css/CSSParserMode.h (128662 => 128663)

--- trunk/Source/WebCore/css/CSSParserMode.h	2012-09-14 22:48:12 UTC (rev 128662)
+++ trunk/Source/WebCore/css/CSSParserMode.h	2012-09-14 22:49:38 UTC (rev 128663)
@@ -65,6 +65,7 @@
 CSSParserMode mode;
 bool isHTMLDocument;
 bool isCSSCustomFilterEnabled;
+bool isCSSS

[webkit-changes] [128662] trunk/Tools

2012-09-14 Thread slewis

Title: [128662] trunk/Tools








Revision 128662
Author sle...@apple.com
Date 2012-09-14 15:48:12 -0700 (Fri, 14 Sep 2012)


Log Message
mac-future ignores previous platform TestExpectations.
https://bugs.webkit.org/show_bug.cgi?id=96718.

Reviewed by Dirk Pranke.

TestExpectations match an expectation's configuraton against a list of configurations that are
valid for that port.  That list does not contain mac-future so none of the expectations can be
applied.

* Scripts/webkitpy/layout_tests/port/apple.py:
(ApplePort._generate_all_test_configurations):

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/layout_tests/port/apple.py




Diff

Modified: trunk/Tools/ChangeLog (128661 => 128662)

--- trunk/Tools/ChangeLog	2012-09-14 22:47:47 UTC (rev 128661)
+++ trunk/Tools/ChangeLog	2012-09-14 22:48:12 UTC (rev 128662)
@@ -1,3 +1,17 @@
+2012-09-13  Stephanie Lewis  
+
+mac-future ignores previous platform TestExpectations.
+https://bugs.webkit.org/show_bug.cgi?id=96718.
+
+Reviewed by Dirk Pranke.
+
+TestExpectations match an expectation's configuraton against a list of configurations that are 
+valid for that port.  That list does not contain mac-future so none of the expectations can be
+applied.
+
+* Scripts/webkitpy/layout_tests/port/apple.py:
+(ApplePort._generate_all_test_configurations):
+
 2012-09-14  Adam Barth  
 
 Remove webkitPostMessage


Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/apple.py (128661 => 128662)

--- trunk/Tools/Scripts/webkitpy/layout_tests/port/apple.py	2012-09-14 22:47:47 UTC (rev 128661)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/port/apple.py	2012-09-14 22:48:12 UTC (rev 128662)
@@ -92,7 +92,8 @@
 
 def _generate_all_test_configurations(self):
 configurations = []
-for port_name in self.VERSION_FALLBACK_ORDER:
+allowed_port_names = self.VERSION_FALLBACK_ORDER + [self.operating_system() + "-future"]
+for port_name in allowed_port_names:
 for build_type in self.ALL_BUILD_TYPES:
 for architecture in self.ARCHITECTURES:
 configurations.append(TestConfiguration(version=self._strip_port_name_prefix(port_name), architecture=architecture, build_type=build_type))






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [128661] trunk/LayoutTests

2012-09-14 Thread ojan

Title: [128661] trunk/LayoutTests








Revision 128661
Author o...@chromium.org
Date 2012-09-14 15:47:47 -0700 (Fri, 14 Sep 2012)


Log Message
Add expectations for tests that depend on other tests running before them.
Filed a bug for each with information on which test it depends on.

* platform/chromium/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (128660 => 128661)

--- trunk/LayoutTests/ChangeLog	2012-09-14 22:26:25 UTC (rev 128660)
+++ trunk/LayoutTests/ChangeLog	2012-09-14 22:47:47 UTC (rev 128661)
@@ -1,3 +1,10 @@
+2012-09-14  Ojan Vafai  
+
+Add expectations for tests that depend on other tests running before them.
+Filed a bug for each with information on which test it depends on.
+
+* platform/chromium/TestExpectations:
+
 2012-09-14  James Robinson  
 
 Unreviewed gardening.


Modified: trunk/LayoutTests/platform/chromium/TestExpectations (128660 => 128661)

--- trunk/LayoutTests/platform/chromium/TestExpectations	2012-09-14 22:26:25 UTC (rev 128660)
+++ trunk/LayoutTests/platform/chromium/TestExpectations	2012-09-14 22:47:47 UTC (rev 128661)
@@ -3598,6 +3598,12 @@
 
 BUGWK96524 WIN LINUX DEBUG : fast/filesystem/workers/detached-frame-crash.html = PASS CRASH
 
+BUGWK96835 : canvas/philip/tests/2d.text.draw.fontface.notinpage.html = TEXT PASS
+BUGWK96835 : platform/chromium/virtual/gpu/canvas/philip/tests/2d.text.draw.fontface.notinpage.html = TEXT PASS
+BUGWK96836 : inspector/debugger/xhr-breakpoints.html = TEXT PASS
+BUGWK96834 : platform/chromium/virtual/threaded/compositing/visibility/visibility-image-layers.html = IMAGE PASS
+BUGWK96833 : svg/carto.net/combobox.svg = IMAGE PASS
+
 BUGWK96720 MAC WIN : fast/forms/time-multiple-fields/time-multiple-fields-preserve-value-after-history-back.html = PASS TIMEOUT
 BUGWK96549 MAC : platform/chromium/virtual/gpu/fast/hidpi/focus-rings.html = IMAGE
 BUGWK96549 MAC : platform/chromium/virtual/gpu/fast/hidpi/video-controls-in-hidpi.html = IMAGE






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [128660] trunk/Source/WebCore

2012-09-14 Thread simon . fraser

Title: [128660] trunk/Source/WebCore








Revision 128660
Author simon.fra...@apple.com
Date 2012-09-14 15:26:25 -0700 (Fri, 14 Sep 2012)


Log Message
Fix builds with CSS_IMAGE_RESOLUTION enabled after r128656.

* css/StyleBuilder.cpp:
(WebCore::ApplyPropertyImageResolution::applyInheritValue):
(WebCore::ApplyPropertyImageResolution::applyInitialValue):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/StyleBuilder.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (128659 => 128660)

--- trunk/Source/WebCore/ChangeLog	2012-09-14 22:21:31 UTC (rev 128659)
+++ trunk/Source/WebCore/ChangeLog	2012-09-14 22:26:25 UTC (rev 128660)
@@ -1,3 +1,11 @@
+2012-09-14  Simon Fraser  
+
+Fix builds with CSS_IMAGE_RESOLUTION enabled after r128656.
+
+* css/StyleBuilder.cpp:
+(WebCore::ApplyPropertyImageResolution::applyInheritValue):
+(WebCore::ApplyPropertyImageResolution::applyInitialValue):
+
 2012-09-14  Adam Barth  
 
 Remove webkitPostMessage


Modified: trunk/Source/WebCore/css/StyleBuilder.cpp (128659 => 128660)

--- trunk/Source/WebCore/css/StyleBuilder.cpp	2012-09-14 22:21:31 UTC (rev 128659)
+++ trunk/Source/WebCore/css/StyleBuilder.cpp	2012-09-14 22:26:25 UTC (rev 128660)
@@ -1735,18 +1735,18 @@
 #if ENABLE(CSS_IMAGE_RESOLUTION)
 class ApplyPropertyImageResolution {
 public:
-static void applyInheritValue(CSSPropertyID, StyleResolver* styleResolver)
+static void applyInheritValue(CSSPropertyID propertyID, StyleResolver* styleResolver)
 {
-ApplyPropertyDefaultBase::applyInheritValue(styleResolver);
-ApplyPropertyDefaultBase::applyInheritValue(styleResolver);
-ApplyPropertyDefaultBase::applyInheritValue(styleResolver);
+ApplyPropertyDefaultBase::applyInheritValue(propertyID, styleResolver);
+ApplyPropertyDefaultBase::applyInheritValue(propertyID, styleResolver);
+ApplyPropertyDefaultBase::applyInheritValue(propertyID, styleResolver);
 }
 
-static void applyInitialValue(CSSPropertyID, StyleResolver* styleResolver)
+static void applyInitialValue(CSSPropertyID propertyID, StyleResolver* styleResolver)
 {
-ApplyPropertyDefaultBase::applyInitialValue(styleResolver);
-ApplyPropertyDefaultBase::applyInitialValue(styleResolver);
-ApplyPropertyDefaultBase::applyInitialValue(styleResolver);
+ApplyPropertyDefaultBase::applyInitialValue(propertyID, styleResolver);
+ApplyPropertyDefaultBase::applyInitialValue(propertyID, styleResolver);
+ApplyPropertyDefaultBase::applyInitialValue(propertyID, styleResolver);
 }
 
 static void applyValue(CSSPropertyID, StyleResolver* styleResolver, CSSValue* value)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [128659] trunk/LayoutTests

2012-09-14 Thread jamesr

Title: [128659] trunk/LayoutTests








Revision 128659
Author jam...@google.com
Date 2012-09-14 15:21:31 -0700 (Fri, 14 Sep 2012)


Log Message
Unreviewed gardening.

Update fixpos layout test results. Chromium currently doesn't set the fixpos-forms-stacking-context setting in
DumpRenderTree.

* fast/block/positioning/016-expected.png: Copied from LayoutTests/platform/efl/fast/block/positioning/016-expected.png.
* fast/block/positioning/025-expected.png: Renamed from LayoutTests/platform/efl/fast/block/positioning/025-expected.png.
* platform/chromium-linux-x86/compositing/geometry/fixed-position-composited-switch-expected.txt: Added.
* platform/chromium-linux-x86/fast/block/positioning/016-expected.txt: Added.
* platform/chromium-linux-x86/fast/block/positioning/025-expected.txt: Added.
* platform/chromium-linux-x86/fast/block/positioning/fixed-position-stacking-context-expected.txt: Added.
* platform/chromium-linux/compositing/geometry/fixed-position-composited-switch-expected.txt: Added.
* platform/chromium-linux/fast/block/positioning/016-expected.png: Renamed from LayoutTests/platform/gtk/fast/block/positioning/016-expected.png.
* platform/chromium-linux/fast/block/positioning/016-expected.txt: Added.
* platform/chromium-linux/fast/block/positioning/025-expected.png: Renamed from LayoutTests/platform/gtk/fast/block/positioning/025-expected.png.
* platform/chromium-linux/fast/block/positioning/025-expected.txt: Added.
* platform/chromium-linux/fast/block/positioning/fixed-position-stacking-context-expected.png: Renamed from LayoutTests/platform/efl/fast/block/positioning/016-expected.png.
* platform/chromium-linux/fast/block/positioning/fixed-position-stacking-context-expected.txt: Added.
* platform/chromium-mac-snowleopard/compositing/geometry/fixed-position-composited-switch-expected.txt: Added.
* platform/chromium-mac-snowleopard/fast/block/positioning/016-expected.txt: Added.
* platform/chromium-mac-snowleopard/fast/block/positioning/025-expected.txt: Added.
* platform/chromium-mac-snowleopard/fast/block/positioning/fixed-position-stacking-context-expected.txt: Added.
* platform/chromium-mac/compositing/geometry/fixed-position-composited-switch-expected.txt: Added.
* platform/chromium-mac/fast/block/positioning/016-expected.png: Added.
* platform/chromium-mac/fast/block/positioning/016-expected.txt: Added.
* platform/chromium-mac/fast/block/positioning/025-expected.png: Added.
* platform/chromium-mac/fast/block/positioning/025-expected.txt: Added.
* platform/chromium-mac/fast/block/positioning/fixed-position-stacking-context-expected.png: Added.
* platform/chromium-mac/fast/block/positioning/fixed-position-stacking-context-expected.txt: Added.

Modified Paths

trunk/LayoutTests/ChangeLog


Added Paths

trunk/LayoutTests/fast/block/positioning/016-expected.png
trunk/LayoutTests/fast/block/positioning/025-expected.png
trunk/LayoutTests/platform/chromium-linux/compositing/geometry/fixed-position-composited-switch-expected.txt
trunk/LayoutTests/platform/chromium-linux/fast/block/positioning/016-expected.png
trunk/LayoutTests/platform/chromium-linux/fast/block/positioning/016-expected.txt
trunk/LayoutTests/platform/chromium-linux/fast/block/positioning/025-expected.png
trunk/LayoutTests/platform/chromium-linux/fast/block/positioning/025-expected.txt
trunk/LayoutTests/platform/chromium-linux/fast/block/positioning/fixed-position-stacking-context-expected.png
trunk/LayoutTests/platform/chromium-linux/fast/block/positioning/fixed-position-stacking-context-expected.txt
trunk/LayoutTests/platform/chromium-linux-x86/compositing/geometry/fixed-position-composited-switch-expected.txt
trunk/LayoutTests/platform/chromium-linux-x86/fast/block/positioning/016-expected.txt
trunk/LayoutTests/platform/chromium-linux-x86/fast/block/positioning/025-expected.txt
trunk/LayoutTests/platform/chromium-linux-x86/fast/block/positioning/fixed-position-stacking-context-expected.txt
trunk/LayoutTests/platform/chromium-mac/compositing/geometry/fixed-position-composited-switch-expected.txt
trunk/LayoutTests/platform/chromium-mac/fast/block/positioning/016-expected.png
trunk/LayoutTests/platform/chromium-mac/fast/block/positioning/016-expected.txt
trunk/LayoutTests/platform/chromium-mac/fast/block/positioning/025-expected.png
trunk/LayoutTests/platform/chromium-mac/fast/block/positioning/025-expected.txt
trunk/LayoutTests/platform/chromium-mac/fast/block/positioning/fixed-position-stacking-context-expected.png
trunk/LayoutTests/platform/chromium-mac/fast/block/positioning/fixed-position-stacking-context-expected.txt
trunk/LayoutTests/platform/chromium-mac-snowleopard/compositing/geometry/fixed-position-composited-switch-expected.txt
trunk/LayoutTests/platform/chromium-mac-snowleopard/fast/block/positioning/016-expected.txt
trunk/LayoutTests/platform/chromium-mac-snowleopard/fast/block/positioning/025-expected.txt
trunk/LayoutTests/platform/chromium-mac-snowleopard/fast/block/positioning/fixed-position-stacking-context-expected.tx

[webkit-changes] [128657] trunk/Source/WTF

2012-09-14 Thread ap

Title: [128657] trunk/Source/WTF








Revision 128657
Author a...@apple.com
Date 2012-09-14 14:57:26 -0700 (Fri, 14 Sep 2012)


Log Message
Minimize collisions when hashing pairs
https://bugs.webkit.org/show_bug.cgi?id=96022

Build fix (with newer clang?)

* wtf/HashFunctions.h: (WTF::pairIntHash): Be explicit about casting from
64 bit to 32 bit.

Modified Paths

trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/HashFunctions.h




Diff

Modified: trunk/Source/WTF/ChangeLog (128656 => 128657)

--- trunk/Source/WTF/ChangeLog	2012-09-14 21:52:22 UTC (rev 128656)
+++ trunk/Source/WTF/ChangeLog	2012-09-14 21:57:26 UTC (rev 128657)
@@ -1,3 +1,13 @@
+2012-09-14  Alexey Proskuryakov  
+
+Minimize collisions when hashing pairs
+https://bugs.webkit.org/show_bug.cgi?id=96022
+
+Build fix (with newer clang?)
+
+* wtf/HashFunctions.h: (WTF::pairIntHash): Be explicit about casting from
+64 bit to 32 bit.
+
 2012-09-14  Dana Jansens  
 
 Minimize collisions when hashing pairs


Modified: trunk/Source/WTF/wtf/HashFunctions.h (128656 => 128657)

--- trunk/Source/WTF/wtf/HashFunctions.h	2012-09-14 21:52:22 UTC (rev 128656)
+++ trunk/Source/WTF/wtf/HashFunctions.h	2012-09-14 21:57:26 UTC (rev 128657)
@@ -94,7 +94,7 @@
 uint64_t longRandom = 19248658165952622LL; // A random 64-bit value.
 
 uint64_t product = longRandom * (shortRandom1 * key1 + shortRandom2 * key2);
-unsigned highBits = product >> (sizeof(uint64_t) - sizeof(unsigned));
+unsigned highBits = static_cast(product >> (sizeof(uint64_t) - sizeof(unsigned)));
 return highBits;
 }
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [128655] trunk/Source/WebCore

2012-09-14 Thread commit-queue

Title: [128655] trunk/Source/WebCore








Revision 128655
Author commit-qu...@webkit.org
Date 2012-09-14 14:43:39 -0700 (Fri, 14 Sep 2012)


Log Message
Support constructor-type attribute in idls other than DOMWindow.
https://bugs.webkit.org/show_bug.cgi?id=96821

Patch by Chang Shu  on 2012-09-14
Reviewed by Kentaro Hara.

In CodeGeneratorJS.pm, we should not assume only DOMWindow uses Constructor
attribute. So for other interfaces, we should pass castedThis->globalObject()
instead of castedThis.

Test: bindings/scripts/test/JS/JSTestObj.idl

* bindings/scripts/CodeGeneratorJS.pm:
(GenerateImplementation):
* bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore::jsTestObjConstructorTestSubObj):
(WebCore::jsTestObjConditionalAttr4Constructor):
(WebCore::jsTestObjConditionalAttr5Constructor):
(WebCore::jsTestObjConditionalAttr6Constructor):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm
trunk/Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (128654 => 128655)

--- trunk/Source/WebCore/ChangeLog	2012-09-14 21:34:10 UTC (rev 128654)
+++ trunk/Source/WebCore/ChangeLog	2012-09-14 21:43:39 UTC (rev 128655)
@@ -1,3 +1,24 @@
+2012-09-14  Chang Shu  
+
+Support constructor-type attribute in idls other than DOMWindow.
+https://bugs.webkit.org/show_bug.cgi?id=96821
+
+Reviewed by Kentaro Hara.
+
+In CodeGeneratorJS.pm, we should not assume only DOMWindow uses Constructor
+attribute. So for other interfaces, we should pass castedThis->globalObject()
+instead of castedThis.
+
+Test: bindings/scripts/test/JS/JSTestObj.idl
+
+* bindings/scripts/CodeGeneratorJS.pm:
+(GenerateImplementation):
+* bindings/scripts/test/JS/JSTestObj.cpp:
+(WebCore::jsTestObjConstructorTestSubObj):
+(WebCore::jsTestObjConditionalAttr4Constructor):
+(WebCore::jsTestObjConditionalAttr5Constructor):
+(WebCore::jsTestObjConditionalAttr6Constructor):
+
 2012-09-14  Tom Sepez  
 
 ImageLoader can't be cleared when video element poster attribute removed.


Modified: trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm (128654 => 128655)

--- trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm	2012-09-14 21:34:10 UTC (rev 128654)
+++ trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm	2012-09-14 21:43:39 UTC (rev 128655)
@@ -1878,9 +1878,14 @@
 } elsif ($attribute->signature->type =~ /Constructor$/) {
 my $constructorType = $codeGenerator->StripModule($attribute->signature->type);
 $constructorType =~ s/Constructor$//;
-# Constructor attribute is only used by DOMWindow.idl, so it's correct to pass castedThis as the global object
-# Once JSDOMWrappers have a back-pointer to the globalObject we can pass castedThis->globalObject()
-push(@implContent, "return JS" . $constructorType . "::getConstructor(exec, castedThis);\n");
+# When Constructor attribute is used by DOMWindow.idl, it's correct to pass castedThis as the global object
+# When JSDOMWrappers have a back-pointer to the globalObject we can pass castedThis->globalObject()
+if ($interfaceName eq "DOMWindow") {
+push(@implContent, "return JS" . $constructorType . "::getConstructor(exec, castedThis);\n");
+} else {
+   AddToImplIncludes("JS" . $constructorType . ".h", $attribute->signature->extendedAttributes->{"Conditional"});
+   push(@implContent, "return JS" . $constructorType . "::getConstructor(exec, castedThis->globalObject());\n");
+}
 } elsif (!@{$attribute->getterExceptions}) {
 push(@implContent, "UNUSED_PARAM(exec);\n") if !$attribute->signature->extendedAttributes->{"CallWith"};
 


Modified: trunk/Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp (128654 => 128655)

--- trunk/Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp	2012-09-14 21:34:10 UTC (rev 128654)
+++ trunk/Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp	2012-09-14 21:43:39 UTC (rev 128655)
@@ -38,6 +38,7 @@
 #include "JSScriptProfile.h"
 #include "JSTestCallback.h"
 #include "JSTestObj.h"
+#include "JSTestSubObj.h"
 #include "JSa.h"
 #include "JSb.h"
 #include "JSbool.h"
@@ -438,7 +439,7 @@
 JSValue jsTestObjConstructorTestSubObj(ExecState* exec, JSValue slotBase, PropertyName)
 {
 JSTestObj* castedThis = jsCast(asObject(slotBase));
-return JSTestSubObj::getConstructor(exec, castedThis);
+return JSTestSubObj::getConstructor(exec, castedThis->globalObject());
 }
 
 
@@ -815,7 +816,7 @@
 JSValue jsTestObjConditionalAttr4Constructor(ExecState* exec, JSValue slotBase, PropertyName)
 {
 JSTestObj* castedThis = jsCast(asObject(slo

[webkit-changes] [128654] trunk

2012-09-14 Thread tsepez

Title: [128654] trunk








Revision 128654
Author tse...@chromium.org
Date 2012-09-14 14:34:10 -0700 (Fri, 14 Sep 2012)


Log Message
ImageLoader can't be cleared when video element poster attribute removed.
https://bugs.webkit.org/show_bug.cgi?id=96301

Reviewed by Abhishek Arya.

Source/WebCore:

Same problem as in https://bugs.webkit.org/show_bug.cgi?id=90801. We can't
clear the image loader when the src attribute is cleared, because we might be
inside a handler called on top of an image loader event dispatch. Instead we
will rely on the OwnPtr relationship between the Element and the Image Loader
to limit the lifetime of the loader to that of the element.

Test: fast/dom/beforeload/clear-video-poster-in-beforeload-listener.html

* html/HTMLVideoElement.cpp:
(WebCore::HTMLVideoElement::parseAttribute):
Remove permature clearing of m_imageLoader.
* html/HTMLEmbedElement.cpp:
(WebCore::HTMLEmbedElement::parseAttribute):
Remove permature clearing of m_imageLoader.
* html/HTMLObjectElement.cpp:
(WebCore::HTMLObjectElement::parseAttribute):
Remove permature clearing of m_imageLoader.

LayoutTests:

Added test case.

* fast/dom/beforeload/clear-video-poster-in-beforeload-listener-expected.txt: Added.
* fast/dom/beforeload/clear-video-poster-in-beforeload-listener.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/HTMLEmbedElement.cpp
trunk/Source/WebCore/html/HTMLObjectElement.cpp
trunk/Source/WebCore/html/HTMLVideoElement.cpp


Added Paths

trunk/LayoutTests/fast/dom/beforeload/clear-video-poster-in-beforeload-listener-expected.txt
trunk/LayoutTests/fast/dom/beforeload/clear-video-poster-in-beforeload-listener.html




Diff

Modified: trunk/LayoutTests/ChangeLog (128653 => 128654)

--- trunk/LayoutTests/ChangeLog	2012-09-14 21:30:42 UTC (rev 128653)
+++ trunk/LayoutTests/ChangeLog	2012-09-14 21:34:10 UTC (rev 128654)
@@ -1,3 +1,15 @@
+2012-09-14  Tom Sepez  
+
+ImageLoader can't be cleared when video element poster attribute removed.
+https://bugs.webkit.org/show_bug.cgi?id=96301
+
+Reviewed by Abhishek Arya.
+
+Added test case.
+
+* fast/dom/beforeload/clear-video-poster-in-beforeload-listener-expected.txt: Added.
+* fast/dom/beforeload/clear-video-poster-in-beforeload-listener.html: Added.
+
 2012-09-14  Jeffrey Pfau  
 
 Allow third-party storage blocking setting to change while a page is loaded


Added: trunk/LayoutTests/fast/dom/beforeload/clear-video-poster-in-beforeload-listener-expected.txt (0 => 128654)

--- trunk/LayoutTests/fast/dom/beforeload/clear-video-poster-in-beforeload-listener-expected.txt	(rev 0)
+++ trunk/LayoutTests/fast/dom/beforeload/clear-video-poster-in-beforeload-listener-expected.txt	2012-09-14 21:34:10 UTC (rev 128654)
@@ -0,0 +1,3 @@
+This page tests that you can correctly clear a video object's poster attribute in a beforeload listener without causing a crash.
+
+PASS: test completed.


Added: trunk/LayoutTests/fast/dom/beforeload/clear-video-poster-in-beforeload-listener.html (0 => 128654)

--- trunk/LayoutTests/fast/dom/beforeload/clear-video-poster-in-beforeload-listener.html	(rev 0)
+++ trunk/LayoutTests/fast/dom/beforeload/clear-video-poster-in-beforeload-listener.html	2012-09-14 21:34:10 UTC (rev 128654)
@@ -0,0 +1,21 @@
+
+
+
+This page tests that you can correctly clear a video object's poster attribute in a beforeload listener without causing a crash.
+FAIL: test didn't run to completion.
+
+if (window.testRunner) {
+testRunner.dumpAsText();
+testRunner.waitUntilDone();
+}
+x = document.createElement('video');
+x.addEventListener('beforeload', function () {
+x.removeAttribute('poster');
+document.getElementById('console').textContent = 'PASS: test completed.';
+if (window.testRunner)
+testRunner.notifyDone();
+}, false);
+x.poster = 'foobar';
+
+
+


Modified: trunk/Source/WebCore/ChangeLog (128653 => 128654)

--- trunk/Source/WebCore/ChangeLog	2012-09-14 21:30:42 UTC (rev 128653)
+++ trunk/Source/WebCore/ChangeLog	2012-09-14 21:34:10 UTC (rev 128654)
@@ -1,3 +1,28 @@
+2012-09-14  Tom Sepez  
+
+ImageLoader can't be cleared when video element poster attribute removed.
+https://bugs.webkit.org/show_bug.cgi?id=96301
+
+Reviewed by Abhishek Arya.
+
+Same problem as in https://bugs.webkit.org/show_bug.cgi?id=90801. We can't
+clear the image loader when the src attribute is cleared, because we might be
+inside a handler called on top of an image loader event dispatch. Instead we
+will rely on the OwnPtr relationship between the Element and the Image Loader
+to limit the lifetime of the loader to that of the element.
+
+Test: fast/dom/beforeload/clear-video-poster-in-beforeload-listener.html
+
+* html/HTMLVideoElement.cpp:
+(WebCore::HTMLVideoElement::parseAttribute):
+Remove permature

[webkit-changes] [128652] trunk

2012-09-14 Thread bdakin

Title: [128652] trunk








Revision 128652
Author bda...@apple.com
Date 2012-09-14 14:24:30 -0700 (Fri, 14 Sep 2012)


Log Message
https://bugs.webkit.org/show_bug.cgi?id=96688
Put position:fixed elements in their own layers and allow them to 
create a stacking context
-and corresponding-


Reviewed by Simon Fraser.

Source/WebKit/mac: 

Enable these settings in WK1 too for consistency. 
* WebView/WebView.mm:
(-[WebView _preferencesChanged:]):

Source/WebKit2: 

Soon we want pages with fixed positioned elements to be able to be 
scrolled by the ScrollingCoordinator. As a part of that work, we have 
to composite fixed position elements, and we have to allow those
elements to create a stacking context.
* WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
(WebKit::TiledCoreAnimationDrawingArea::TiledCoreAnimationDrawingArea):

LayoutTests: 

A few test result differences. These first three tests actually
render differently now.
* platform/mac/fast/block/positioning/016-expected.png:
* platform/mac/fast/block/positioning/016-expected.txt:
* platform/mac/fast/block/positioning/025-expected.png:
* platform/mac/fast/block/positioning/025-expected.txt:
* platform/mac/fast/block/positioning/fixed-position-stacking-context-expected.png: Added.
* platform/mac/fast/block/positioning/fixed-position-stacking-context-expected.txt: Added.

These tests just have different layer trees. 
* platform/mac/compositing/geometry/fixed-position-composited-switch-expected.txt: Added.
* platform/mac/compositing/rtl: Added.
* platform/mac/compositing/rtl/rtl-fixed-expected.txt: Added.
* platform/mac/compositing/rtl/rtl-fixed-overflow-expected.txt: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/block/positioning/016.html
trunk/LayoutTests/fast/block/positioning/025.html
trunk/LayoutTests/fast/block/positioning/fixed-position-stacking-context.html
trunk/LayoutTests/platform/mac/fast/block/positioning/016-expected.png
trunk/LayoutTests/platform/mac/fast/block/positioning/016-expected.txt
trunk/LayoutTests/platform/mac/fast/block/positioning/025-expected.png
trunk/LayoutTests/platform/mac/fast/block/positioning/025-expected.txt
trunk/Source/WebKit/mac/ChangeLog
trunk/Source/WebKit/mac/WebView/WebView.mm
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm


Added Paths

trunk/LayoutTests/platform/mac/compositing/geometry/fixed-position-composited-switch-expected.txt
trunk/LayoutTests/platform/mac/compositing/rtl/
trunk/LayoutTests/platform/mac/compositing/rtl/rtl-fixed-expected.txt
trunk/LayoutTests/platform/mac/compositing/rtl/rtl-fixed-overflow-expected.txt
trunk/LayoutTests/platform/mac/fast/block/positioning/fixed-position-stacking-context-expected.png
trunk/LayoutTests/platform/mac/fast/block/positioning/fixed-position-stacking-context-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (128651 => 128652)

--- trunk/LayoutTests/ChangeLog	2012-09-14 21:09:46 UTC (rev 128651)
+++ trunk/LayoutTests/ChangeLog	2012-09-14 21:24:30 UTC (rev 128652)
@@ -1,3 +1,28 @@
+2012-09-14  Beth Dakin  
+
+https://bugs.webkit.org/show_bug.cgi?id=96688
+Put position:fixed elements in their own layers and allow them to 
+create a stacking context
+-and corresponding-
+
+
+Reviewed by Simon Fraser.
+
+A few test result differences. These first three tests actually
+render differently now.
+* platform/mac/fast/block/positioning/016-expected.png:
+* platform/mac/fast/block/positioning/016-expected.txt:
+* platform/mac/fast/block/positioning/025-expected.png:
+* platform/mac/fast/block/positioning/025-expected.txt:
+* platform/mac/fast/block/positioning/fixed-position-stacking-context-expected.png: Added.
+* platform/mac/fast/block/positioning/fixed-position-stacking-context-expected.txt: Added.
+
+These tests just have different layer trees. 
+* platform/mac/compositing/geometry/fixed-position-composited-switch-expected.txt: Added.
+* platform/mac/compositing/rtl: Added.
+* platform/mac/compositing/rtl/rtl-fixed-expected.txt: Added.
+* platform/mac/compositing/rtl/rtl-fixed-overflow-expected.txt: Added.
+
 2012-09-14  Bo Liu  
 
 Add in-place reload behavior to ImagesEnabled setting


Modified: trunk/LayoutTests/fast/block/positioning/016.html (128651 => 128652)

--- trunk/LayoutTests/fast/block/positioning/016.html	2012-09-14 21:09:46 UTC (rev 128651)
+++ trunk/LayoutTests/fast/block/positioning/016.html	2012-09-14 21:24:30 UTC (rev 128652)
@@ -5,6 +5,7 @@
 
 
 z-index testcase: 'auto' doesn't establish new stacking context (position: fixed)
+

[webkit-changes] [128651] trunk/Source/WebCore

2012-09-14 Thread commit-queue

Title: [128651] trunk/Source/WebCore








Revision 128651
Author commit-qu...@webkit.org
Date 2012-09-14 14:09:46 -0700 (Fri, 14 Sep 2012)


Log Message
Prevent workers from calling back into other worlds
https://bugs.webkit.org/show_bug.cgi?id=96790

Patch by Dan Carney  on 2012-09-14
Reviewed by Adam Barth.

Added a few sanity checks to ensure callbacks are always using the correct world.

No new tests. No new change in functionality.

* bindings/v8/V8DOMWrapper.cpp:
(WebCore::V8DOMWrapper::getEventListener):
* bindings/v8/V8LazyEventListener.cpp:
(WebCore::V8LazyEventListener::prepareListenerObject):
* bindings/v8/WorldContextHandle.cpp:
(WebCore::WorldContextHandle::WorldContextHandle):
(WebCore::WorldContextHandle::adjustedContext):
* bindings/v8/WorldContextHandle.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/v8/V8DOMWrapper.cpp
trunk/Source/WebCore/bindings/v8/V8LazyEventListener.cpp
trunk/Source/WebCore/bindings/v8/WorldContextHandle.cpp
trunk/Source/WebCore/bindings/v8/WorldContextHandle.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (128650 => 128651)

--- trunk/Source/WebCore/ChangeLog	2012-09-14 21:00:20 UTC (rev 128650)
+++ trunk/Source/WebCore/ChangeLog	2012-09-14 21:09:46 UTC (rev 128651)
@@ -1,3 +1,23 @@
+2012-09-14  Dan Carney  
+
+Prevent workers from calling back into other worlds
+https://bugs.webkit.org/show_bug.cgi?id=96790
+
+Reviewed by Adam Barth.
+
+Added a few sanity checks to ensure callbacks are always using the correct world.
+
+No new tests. No new change in functionality.
+
+* bindings/v8/V8DOMWrapper.cpp:
+(WebCore::V8DOMWrapper::getEventListener):
+* bindings/v8/V8LazyEventListener.cpp:
+(WebCore::V8LazyEventListener::prepareListenerObject):
+* bindings/v8/WorldContextHandle.cpp:
+(WebCore::WorldContextHandle::WorldContextHandle):
+(WebCore::WorldContextHandle::adjustedContext):
+* bindings/v8/WorldContextHandle.h:
+
 2012-09-14  Dana Jansens  
 
 Minimize collisions when hashing pairs


Modified: trunk/Source/WebCore/bindings/v8/V8DOMWrapper.cpp (128650 => 128651)

--- trunk/Source/WebCore/bindings/v8/V8DOMWrapper.cpp	2012-09-14 21:00:20 UTC (rev 128650)
+++ trunk/Source/WebCore/bindings/v8/V8DOMWrapper.cpp	2012-09-14 21:09:46 UTC (rev 128651)
@@ -201,8 +201,7 @@
 return 0;
 if (lookup == ListenerFindOnly)
 return V8EventListenerList::findWrapper(value, isAttribute);
-v8::Handle globalPrototype = v8::Handle::Cast(context->Global()->GetPrototype());
-if (isWrapperOfType(globalPrototype, &V8DOMWindow::info))
+if (isWrapperOfType(toInnerGlobalObject(context), &V8DOMWindow::info))
 return V8EventListenerList::findOrCreateWrapper(value, isAttribute);
 #if ENABLE(WORKERS)
 return V8EventListenerList::findOrCreateWrapper(value, isAttribute);


Modified: trunk/Source/WebCore/bindings/v8/V8LazyEventListener.cpp (128650 => 128651)

--- trunk/Source/WebCore/bindings/v8/V8LazyEventListener.cpp	2012-09-14 21:00:20 UTC (rev 128650)
+++ trunk/Source/WebCore/bindings/v8/V8LazyEventListener.cpp	2012-09-14 21:09:46 UTC (rev 128651)
@@ -124,7 +124,7 @@
 if (!frame->script()->canExecuteScripts(NotAboutToExecuteScript))
 return;
 // Use the outer scope to hold context.
-v8::Local v8Context = worldContext().adjustedContext(frame->script());
+v8::Local v8Context = toV8Context(context, worldContext());
 // Bail out if we cannot get the context.
 if (v8Context.IsEmpty())
 return;


Modified: trunk/Source/WebCore/bindings/v8/WorldContextHandle.cpp (128650 => 128651)

--- trunk/Source/WebCore/bindings/v8/WorldContextHandle.cpp	2012-09-14 21:00:20 UTC (rev 128650)
+++ trunk/Source/WebCore/bindings/v8/WorldContextHandle.cpp	2012-09-14 21:09:46 UTC (rev 128651)
@@ -32,6 +32,8 @@
 #include "WorldContextHandle.h"
 
 #include "ScriptController.h"
+#include "V8Binding.h"
+#include "V8DOMWindow.h"
 #include "V8DOMWindowShell.h"
 
 namespace WebCore {
@@ -39,9 +41,22 @@
 WorldContextHandle::WorldContextHandle(WorldToUse worldToUse)
 : m_worldToUse(worldToUse)
 {
-if (worldToUse == UseMainWorld)
+if (worldToUse == UseMainWorld || worldToUse == UseWorkerWorld)
 return;
 
+#if ENABLE(WORKERS)
+// FIXME We are duplicating a lot of effort here checking the context for the worker and for the isolated world.
+if (v8::Context::InContext()) {
+v8::Handle context = v8::Context::GetCurrent();
+if (!context.IsEmpty()) {
+if (UNLIKELY(!V8DOMWrapper::isWrapperOfType(toInnerGlobalObject(context), &V8DOMWindow::info))) {
+m_worldToUse = UseWorkerWorld;
+return;
+}
+}
+}
+#endif
+
 V8DOMWindowShell* shell = V8DOMWindowShell::getEntered();
 if (LIKELY(!shell)) {
 m_worldToUse = UseMainWorld;
@@ -54,6 +69,7 @@
 
 v8::Local WorldContextHandle::adjustedContext(Script

[webkit-changes] [128650] trunk/Source

2012-09-14 Thread danakj

Title: [128650] trunk/Source








Revision 128650
Author dan...@chromium.org
Date 2012-09-14 14:00:20 -0700 (Fri, 14 Sep 2012)


Log Message
Minimize collisions when hashing pairs
https://bugs.webkit.org/show_bug.cgi?id=96022

Reviewed by Adrienne Walker.

Source/WebCore:

Use WTF::pairIntHash() to hash pairs of integers.

* dom/Document.cpp:
(WebCore::ImmutableAttributeDataCacheKey::hash):
* dom/StyledElement.cpp:
(WebCore::computePresentationAttributeCacheHash):
* platform/graphics/Gradient.cpp:
(WebCore::Gradient::hash):
* platform/graphics/IntPointHash.h:
(WTF::IntPointHash::hash):
* platform/graphics/IntRectHash.h:
* platform/graphics/IntSizeHash.h:
* platform/graphics/blackberry/LayerTileIndex.h:
* platform/graphics/cg/GraphicsContextCG.cpp:
(WebCore::SubimageCacheHash::hash):

Source/WebKit/blackberry:

Use WTF::pairIntHash() to hash a pair of integers.

* WebKitSupport/TileIndexHash.h:

Source/WTF:

The current hash function for pairs has poor performance as it does a
nice hash function on 64 bits, but then just drops the top 32 bits. The
hash method for pairs tries to use Thomas Wang's 64 bit Mix Function,
but this requires not dropping any bits in order to retain the
characteristics mentioned by Thomas.

A better method of hashing sets of 32-bit integers is to use
multiplication in 64 bits with random integers. This method is a
provably almost-universal hash function. Testing shows that this
method decreases the time required, when compared with the current
method, by more than 20% due to better hashing characteristics.

* wtf/HashFunctions.h:
(WTF):
(WTF::pairIntHash):
Implments the hashing method for a pair of unsigned integers.

(WTF::PairHash::hash):
Use pairIntHash() on the hash results of each object in the pair.

(WTF::IntPairHash::hash):
Implement an integer-specific PairHash class that does not need to
hash each object in the pair. It uses pairIntHash on the two
integers in the pair directly.

(WTF::IntPairHash::equal):
(IntPairHash):

Modified Paths

trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/HashFunctions.h
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/Document.cpp
trunk/Source/WebCore/dom/StyledElement.cpp
trunk/Source/WebCore/platform/graphics/Gradient.cpp
trunk/Source/WebCore/platform/graphics/IntPointHash.h
trunk/Source/WebCore/platform/graphics/IntRectHash.h
trunk/Source/WebCore/platform/graphics/IntSizeHash.h
trunk/Source/WebCore/platform/graphics/blackberry/LayerTileIndex.h
trunk/Source/WebCore/platform/graphics/cg/GraphicsContextCG.cpp
trunk/Source/WebKit/blackberry/ChangeLog
trunk/Source/WebKit/blackberry/WebKitSupport/TileIndexHash.h




Diff

Modified: trunk/Source/WTF/ChangeLog (128649 => 128650)

--- trunk/Source/WTF/ChangeLog	2012-09-14 20:51:13 UTC (rev 128649)
+++ trunk/Source/WTF/ChangeLog	2012-09-14 21:00:20 UTC (rev 128650)
@@ -1,3 +1,38 @@
+2012-09-14  Dana Jansens  
+
+Minimize collisions when hashing pairs
+https://bugs.webkit.org/show_bug.cgi?id=96022
+
+Reviewed by Adrienne Walker.
+
+The current hash function for pairs has poor performance as it does a
+nice hash function on 64 bits, but then just drops the top 32 bits. The
+hash method for pairs tries to use Thomas Wang's 64 bit Mix Function,
+but this requires not dropping any bits in order to retain the
+characteristics mentioned by Thomas.
+
+A better method of hashing sets of 32-bit integers is to use
+multiplication in 64 bits with random integers. This method is a
+provably almost-universal hash function. Testing shows that this
+method decreases the time required, when compared with the current
+method, by more than 20% due to better hashing characteristics.
+
+* wtf/HashFunctions.h:
+(WTF):
+(WTF::pairIntHash):
+Implments the hashing method for a pair of unsigned integers.
+
+(WTF::PairHash::hash):
+Use pairIntHash() on the hash results of each object in the pair.
+
+(WTF::IntPairHash::hash):
+Implement an integer-specific PairHash class that does not need to
+hash each object in the pair. It uses pairIntHash on the two
+integers in the pair directly.
+
+(WTF::IntPairHash::equal):
+(IntPairHash):
+
 2012-09-14  Tor Arne Vestbø  
 
 [Qt] Make force_static_libs_as_shared work on Mac OS


Modified: trunk/Source/WTF/wtf/HashFunctions.h (128649 => 128650)

--- trunk/Source/WTF/wtf/HashFunctions.h	2012-09-14 20:51:13 UTC (rev 128649)
+++ trunk/Source/WTF/wtf/HashFunctions.h	2012-09-14 21:00:20 UTC (rev 128650)
@@ -86,6 +86,18 @@
 return static_cast(key);
 }
 
+// Compound integer hash method: http://opendatastructures.org/versions/edition-0.1d/ods-java/node33.html#SECTION00832000
+inline unsigned pairIntHash(unsigned key1, unsigned key2)
+{
+unsigned shortRandom1 = 277951225; // A random 32-bit value.
+unsigned shortRandom2 = 95187966;

[webkit-changes] [128649] trunk/PerformanceTests

2012-09-14 Thread rniwa

Title: [128649] trunk/PerformanceTests








Revision 128649
Author rn...@webkit.org
Date 2012-09-14 13:51:13 -0700 (Fri, 14 Sep 2012)


Log Message
Use performance.webkitNow in PerfTestRunner
https://bugs.webkit.org/show_bug.cgi?id=92826

Reviewed by Eric Seidel.

Use performance.webkitNow with Date.now as a fallback for more accurate time measurements.

* resources/runner.js:
(PerfTestRunner._runner):
(PerfTestRunner._perSecondRunnerIterator):

Modified Paths

trunk/PerformanceTests/ChangeLog
trunk/PerformanceTests/resources/runner.js




Diff

Modified: trunk/PerformanceTests/ChangeLog (128648 => 128649)

--- trunk/PerformanceTests/ChangeLog	2012-09-14 20:39:33 UTC (rev 128648)
+++ trunk/PerformanceTests/ChangeLog	2012-09-14 20:51:13 UTC (rev 128649)
@@ -1,3 +1,16 @@
+2012-09-14  Ryosuke Niwa  
+
+Use performance.webkitNow in PerfTestRunner
+https://bugs.webkit.org/show_bug.cgi?id=92826
+
+Reviewed by Eric Seidel.
+
+Use performance.webkitNow with Date.now as a fallback for more accurate time measurements.
+
+* resources/runner.js:
+(PerfTestRunner._runner):
+(PerfTestRunner._perSecondRunnerIterator):
+
 2012-09-14  Sheriff Bot  
 
 Unreviewed, rolling out r128562.


Modified: trunk/PerformanceTests/resources/runner.js (128648 => 128649)

--- trunk/PerformanceTests/resources/runner.js	2012-09-14 20:39:33 UTC (rev 128648)
+++ trunk/PerformanceTests/resources/runner.js	2012-09-14 20:51:13 UTC (rev 128649)
@@ -27,6 +27,8 @@
 return (randomSeed & 0xfff) / 0x1000;
 };
 
+PerfTestRunner.now = window.performance && window.performance.webkitNow ? function () { return window.performance.webkitNow(); } : Date.now;
+
 PerfTestRunner.log = function (text) {
 if (this._logLines) {
 this._logLines.push(text);
@@ -145,7 +147,7 @@
 }
 
 PerfTestRunner._runner = function () {
-var start = Date.now();
+var start = this.now();
 var totalTime = 0;
 
 for (var i = 0; i < this._loopsPerRun; ++i) {
@@ -158,7 +160,7 @@
 }
 
 // Assume totalTime can never be zero when _runFunction returns a number.
-var time = totalTime ? totalTime : Date.now() - start;
+var time = totalTime ? totalTime : this.now() - start;
 
 this.ignoreWarmUpAndLog(time);
 this._runLoop();
@@ -258,10 +260,10 @@
 }
 
 PerfTestRunner._perSecondRunnerIterator = function (callsPerIteration) {
-var startTime = Date.now();
+var startTime = this.now();
 for (var i = 0; i < callsPerIteration; i++)
 this._test.run();
-return Date.now() - startTime;
+return this.now() - startTime;
 }
 
 if (window.testRunner) {






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [128648] trunk/Source/WebKit/chromium

2012-09-14 Thread commit-queue

Title: [128648] trunk/Source/WebKit/chromium








Revision 128648
Author commit-qu...@webkit.org
Date 2012-09-14 13:39:33 -0700 (Fri, 14 Sep 2012)


Log Message
Unreviewed.  Rolled DEPS.

Patch by Sheriff Bot  on 2012-09-14

* DEPS:

Modified Paths

trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/DEPS




Diff

Modified: trunk/Source/WebKit/chromium/ChangeLog (128647 => 128648)

--- trunk/Source/WebKit/chromium/ChangeLog	2012-09-14 20:18:08 UTC (rev 128647)
+++ trunk/Source/WebKit/chromium/ChangeLog	2012-09-14 20:39:33 UTC (rev 128648)
@@ -1,3 +1,9 @@
+2012-09-14  Sheriff Bot  
+
+Unreviewed.  Rolled DEPS.
+
+* DEPS:
+
 2012-09-14  Rick Byers  
 
 [chromium] add touch area to gestureTapDown data


Modified: trunk/Source/WebKit/chromium/DEPS (128647 => 128648)

--- trunk/Source/WebKit/chromium/DEPS	2012-09-14 20:18:08 UTC (rev 128647)
+++ trunk/Source/WebKit/chromium/DEPS	2012-09-14 20:39:33 UTC (rev 128648)
@@ -32,7 +32,7 @@
 
 vars = {
   'chromium_svn': 'http://src.chromium.org/svn/trunk/src',
-  'chromium_rev': '156485'
+  'chromium_rev': '156816'
 }
 
 deps = {






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [128647] trunk/Source/WebCore

2012-09-14 Thread rwlbuis

Title: [128647] trunk/Source/WebCore








Revision 128647
Author rwlb...@webkit.org
Date 2012-09-14 13:18:08 -0700 (Fri, 14 Sep 2012)


Log Message
[BlackBerry] Use StringBuilder more in BlackBerry RSS classes
https://bugs.webkit.org/show_bug.cgi?id=96820

Reviewed by Antonio Gomes.

Use append/appendLiteral where possible.

* platform/MIMETypeRegistry.cpp:
(WebCore::mimeTypeAssociationMap):
* platform/network/blackberry/rss/RSSAtomParser.cpp:
(WebCore::RSSAtomParser::parseContent):
(WebCore::RSSAtomParser::parseAuthor):
* platform/network/blackberry/rss/RSSGenerator.cpp:
(WebCore::RSSGenerator::generateHtml):
* platform/network/blackberry/rss/RSSParserBase.cpp:
(WebCore::textFromXMLAttr):
(WebCore::textFromXMLNode):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/MIMETypeRegistry.cpp
trunk/Source/WebCore/platform/network/blackberry/rss/RSSAtomParser.cpp
trunk/Source/WebCore/platform/network/blackberry/rss/RSSGenerator.cpp
trunk/Source/WebCore/platform/network/blackberry/rss/RSSParserBase.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (128646 => 128647)

--- trunk/Source/WebCore/ChangeLog	2012-09-14 20:08:09 UTC (rev 128646)
+++ trunk/Source/WebCore/ChangeLog	2012-09-14 20:18:08 UTC (rev 128647)
@@ -1,3 +1,23 @@
+2012-09-14  Rob Buis  
+
+[BlackBerry] Use StringBuilder more in BlackBerry RSS classes
+https://bugs.webkit.org/show_bug.cgi?id=96820
+
+Reviewed by Antonio Gomes.
+
+Use append/appendLiteral where possible.
+
+* platform/MIMETypeRegistry.cpp:
+(WebCore::mimeTypeAssociationMap):
+* platform/network/blackberry/rss/RSSAtomParser.cpp:
+(WebCore::RSSAtomParser::parseContent):
+(WebCore::RSSAtomParser::parseAuthor):
+* platform/network/blackberry/rss/RSSGenerator.cpp:
+(WebCore::RSSGenerator::generateHtml):
+* platform/network/blackberry/rss/RSSParserBase.cpp:
+(WebCore::textFromXMLAttr):
+(WebCore::textFromXMLNode):
+
 2012-09-14  Alexandru Chiculita  
 
 [CSS Shaders] Enable anti-aliasing on the FECustomFilter


Modified: trunk/Source/WebCore/platform/MIMETypeRegistry.cpp (128646 => 128647)

--- trunk/Source/WebCore/platform/MIMETypeRegistry.cpp	2012-09-14 20:08:09 UTC (rev 128646)
+++ trunk/Source/WebCore/platform/MIMETypeRegistry.cpp	2012-09-14 20:18:08 UTC (rev 128647)
@@ -638,7 +638,7 @@
 
 mimeTypeMap = new MIMETypeAssociationMap;
 
-mimeTypeMap->add(ASCIILiteral("image/x-ms-bmp"), ASCIILiteral("image/bmp")));
+mimeTypeMap->add(ASCIILiteral("image/x-ms-bmp"), ASCIILiteral("image/bmp"));
 mimeTypeMap->add(ASCIILiteral("image/x-windows-bmp"), ASCIILiteral("image/bmp"));
 mimeTypeMap->add(ASCIILiteral("image/x-bmp"), ASCIILiteral("image/bmp"));
 mimeTypeMap->add(ASCIILiteral("image/x-bitmap"), ASCIILiteral("image/bmp"));


Modified: trunk/Source/WebCore/platform/network/blackberry/rss/RSSAtomParser.cpp (128646 => 128647)

--- trunk/Source/WebCore/platform/network/blackberry/rss/RSSAtomParser.cpp	2012-09-14 20:08:09 UTC (rev 128646)
+++ trunk/Source/WebCore/platform/network/blackberry/rss/RSSAtomParser.cpp	2012-09-14 20:18:08 UTC (rev 128647)
@@ -22,6 +22,7 @@
 #include "BlackBerryPlatformAssert.h"
 #include "libxml/parser.h"
 #include "libxml/xmlwriter.h"
+#include 
 
 namespace WebCore {
 
@@ -231,7 +232,7 @@
 
 BLACKBERRY_ASSERT(node);
 // Why does Blackberry have its own RSS parser?
-// FIXME: content should be a StringBuilder.
+
 String content;
 String type = "default";
 String src;
@@ -248,9 +249,10 @@
 if (!src.isEmpty()) {
 if (isRelativePath(src))
 src = "" + "/" + src;
-content += "" + src + "";
-return content;
+StringBuilder builder;
+builder.appendLiteral("" + src + "");
+return builder.toString();
 }
 
 if (type == "text" || type.startsWith("text/"))
@@ -263,14 +265,16 @@
 if (cur && cur->type == XML_ELEMENT_NODE) {
 // Encoding of buffer is utf-8.
 xmlNodeDump(buffer, cur->doc, cur, 0, 0);
+StringBuilder builder;
 if (!base.isEmpty()) {
-content += "";
+builder.appendLiteral("");
 }
-content += (const char*)xmlBufferContent(buffer);
+builder.append((const char*)xmlBufferContent(buffer));
+content = builder.toString();
 }
 xmlBufferFree(buffer);
 } else if (type.endsWith("+xml") || type.endsWith("/xml"))
@@ -300,9 +304,9 @@
 }
 
 if (!email.isEmpty()) {
-username += " (";
-username += email;
-username += ")";
+username = username + " (";
+username = username + email;
+username = username + ")";
 }
 
 return username;


Modified: trunk/Source/WebCore/platform/network/blackberry/rss/RSSGenerator.cpp (128646 => 128647)

--- trunk/Source/WebCore/platform/network/blackberry/rss/RSSGenerator.cpp	20

[webkit-changes] [128646] trunk/Source/WebCore

2012-09-14 Thread achicu

Title: [128646] trunk/Source/WebCore








Revision 128646
Author ach...@adobe.com
Date 2012-09-14 13:08:09 -0700 (Fri, 14 Sep 2012)


Log Message
[CSS Shaders] Enable anti-aliasing on the FECustomFilter
https://bugs.webkit.org/show_bug.cgi?id=96668

Reviewed by Dean Jackson.

Added multisample frame buffer for the FECustomFilter. It will try to allocate a multisample framebuffer
with a maximum sample count of 4. At the end it will blit the samples back to the original frame buffer,
so that we can read the pixels back.

This patch uses extensions GL_ANGLE_framebuffer_multisample, GL_ANGLE_framebuffer_blit
and GL_OES_rgb8_rgba8.

No new tests, multisampling is not working in Chromium DRT and has not pixel effect on WebKit Mac.

* platform/graphics/filters/FECustomFilter.cpp:
(WebCore::FECustomFilter::FECustomFilter):
(WebCore::FECustomFilter::deleteRenderBuffers):
(WebCore):
(WebCore::FECustomFilter::deleteMultisampleRenderBuffers):
(WebCore::FECustomFilter::drawFilterMesh):
(WebCore::FECustomFilter::createMultisampleBuffer):
(WebCore::FECustomFilter::resolveMultisampleBuffer):
(WebCore::FECustomFilter::canUseMultisampleBuffers):
(WebCore::FECustomFilter::resizeMultisampleBuffers):
(WebCore::FECustomFilter::resizeContext):
* platform/graphics/filters/FECustomFilter.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/filters/FECustomFilter.cpp
trunk/Source/WebCore/platform/graphics/filters/FECustomFilter.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (128645 => 128646)

--- trunk/Source/WebCore/ChangeLog	2012-09-14 20:04:30 UTC (rev 128645)
+++ trunk/Source/WebCore/ChangeLog	2012-09-14 20:08:09 UTC (rev 128646)
@@ -1,3 +1,32 @@
+2012-09-14  Alexandru Chiculita  
+
+[CSS Shaders] Enable anti-aliasing on the FECustomFilter
+https://bugs.webkit.org/show_bug.cgi?id=96668
+
+Reviewed by Dean Jackson.
+
+Added multisample frame buffer for the FECustomFilter. It will try to allocate a multisample framebuffer
+with a maximum sample count of 4. At the end it will blit the samples back to the original frame buffer,
+so that we can read the pixels back.
+
+This patch uses extensions GL_ANGLE_framebuffer_multisample, GL_ANGLE_framebuffer_blit
+and GL_OES_rgb8_rgba8.
+
+No new tests, multisampling is not working in Chromium DRT and has not pixel effect on WebKit Mac.
+
+* platform/graphics/filters/FECustomFilter.cpp:
+(WebCore::FECustomFilter::FECustomFilter):
+(WebCore::FECustomFilter::deleteRenderBuffers):
+(WebCore):
+(WebCore::FECustomFilter::deleteMultisampleRenderBuffers):
+(WebCore::FECustomFilter::drawFilterMesh):
+(WebCore::FECustomFilter::createMultisampleBuffer):
+(WebCore::FECustomFilter::resolveMultisampleBuffer):
+(WebCore::FECustomFilter::canUseMultisampleBuffers):
+(WebCore::FECustomFilter::resizeMultisampleBuffers):
+(WebCore::FECustomFilter::resizeContext):
+* platform/graphics/filters/FECustomFilter.h:
+
 2012-09-14  Bo Liu  
 
 Add in-place reload behavior to ImagesEnabled setting


Modified: trunk/Source/WebCore/platform/graphics/filters/FECustomFilter.cpp (128645 => 128646)

--- trunk/Source/WebCore/platform/graphics/filters/FECustomFilter.cpp	2012-09-14 20:04:30 UTC (rev 128645)
+++ trunk/Source/WebCore/platform/graphics/filters/FECustomFilter.cpp	2012-09-14 20:08:09 UTC (rev 128646)
@@ -43,12 +43,12 @@
 #include "CustomFilterTransformParameter.h"
 #include "CustomFilterValidatedProgram.h"
 #include "DrawingBuffer.h"
+#include "Extensions3D.h"
 #include "GraphicsContext3D.h"
 #include "ImageData.h"
 #include "NotImplemented.h"
 #include "RenderTreeAsText.h"
 #include "TextStream.h"
-#include "Texture.h"
 #include "TilingData.h"
 #include "TransformationMatrix.h"
 
@@ -56,6 +56,8 @@
 
 namespace WebCore {
 
+static const int kMaxSampleCount = 4;
+
 static void orthogonalProjectionMatrix(TransformationMatrix& matrix, float left, float right, float bottom, float top)
 {
 ASSERT(matrix.isIdentity());
@@ -89,6 +91,10 @@
 , m_frameBuffer(0)
 , m_depthBuffer(0)
 , m_destTexture(0)
+, m_triedMultisampleBuffer(false)
+, m_multisampleFrameBuffer(0)
+, m_multisampleRenderBuffer(0)
+, m_multisampleDepthBuffer(0)
 , m_parameters(parameters)
 , m_meshRows(meshRows)
 , m_meshColumns(meshColumns)
@@ -134,8 +140,28 @@
 m_context->deleteTexture(m_destTexture);
 m_destTexture = 0;
 }
+deleteMultisampleRenderBuffers();
 }
 
+void FECustomFilter::deleteMultisampleRenderBuffers()
+{
+if (m_multisampleFrameBuffer) {
+// Make sure to unbind any framebuffer from the context first, otherwise
+// some platforms might refuse to bind the same buffer id again.
+m_context->bindFramebuffer(GraphicsContext3D::FRAMEBUFFER, 0);
+m_context->deleteFramebuffer(m_multisampleFrameBuffer);
+m_multisampleFrameBu

[webkit-changes] [128644] trunk

2012-09-14 Thread eae

Title: [128644] trunk








Revision 128644
Author e...@chromium.org
Date 2012-09-14 13:01:36 -0700 (Fri, 14 Sep 2012)


Log Message
https://bugs.webkit.org/show_bug.cgi?id=96226
REGRESSION (r128006): Three spatial navigation tests are failing

Reviewed by Ryosuke Niwa.

Source/WebCore:

Fix spatial navigation regression by reverting parts of r128006.
Specifically the change to remove the overridden boundingBox
method in ContainerNode.

* dom/ContainerNode.cpp:
(WebCore::ContainerNode::getUpperLeftCorner):
(WebCore):
(WebCore::ContainerNode::getLowerRightCorner):
(WebCore::ContainerNode::boundingBox):
* dom/ContainerNode.h:
(ContainerNode):

LayoutTests:

Remove spatial navigation tests from Skipped list.

* platform/mac/Skipped:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac/Skipped
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/ContainerNode.cpp
trunk/Source/WebCore/dom/ContainerNode.h




Diff

Modified: trunk/LayoutTests/ChangeLog (128643 => 128644)

--- trunk/LayoutTests/ChangeLog	2012-09-14 20:00:58 UTC (rev 128643)
+++ trunk/LayoutTests/ChangeLog	2012-09-14 20:01:36 UTC (rev 128644)
@@ -1,3 +1,14 @@
+2012-09-14  Emil A Eklund  
+
+https://bugs.webkit.org/show_bug.cgi?id=96226
+REGRESSION (r128006): Three spatial navigation tests are failing
+
+Reviewed by Ryosuke Niwa.
+
+Remove spatial navigation tests from Skipped list.
+
+* platform/mac/Skipped:
+
 2012-09-14  James Robinson  
 
 Unreviewed, rolling out r128627.


Modified: trunk/LayoutTests/platform/mac/Skipped (128643 => 128644)

--- trunk/LayoutTests/platform/mac/Skipped	2012-09-14 20:00:58 UTC (rev 128643)
+++ trunk/LayoutTests/platform/mac/Skipped	2012-09-14 20:01:36 UTC (rev 128644)
@@ -1010,12 +1010,6 @@
 # ASSERTION FAILED: m_wrapper || !m_jsFunction
 svg/custom/use-instanceRoot-as-event-target.xhtml
 
-# https://bugs.webkit.org/show_bug.cgi?id=96226
-# REGRESSION (r128006): Three spatial navigation tests are failing
-fast/spatial-navigation/snav-container-white-space.html
-fast/spatial-navigation/snav-div-overflow-scrol-hidden.html
-fast/spatial-navigation/snav-imagemap-overlapped-areas.html
-
 # Assorted failures that need investigation
 
 # --- Canvas ---


Modified: trunk/Source/WebCore/ChangeLog (128643 => 128644)

--- trunk/Source/WebCore/ChangeLog	2012-09-14 20:00:58 UTC (rev 128643)
+++ trunk/Source/WebCore/ChangeLog	2012-09-14 20:01:36 UTC (rev 128644)
@@ -1,3 +1,22 @@
+2012-09-14  Emil A Eklund  
+
+https://bugs.webkit.org/show_bug.cgi?id=96226
+REGRESSION (r128006): Three spatial navigation tests are failing
+
+Reviewed by Ryosuke Niwa.
+
+Fix spatial navigation regression by reverting parts of r128006.
+Specifically the change to remove the overridden boundingBox
+method in ContainerNode. 
+
+* dom/ContainerNode.cpp:
+(WebCore::ContainerNode::getUpperLeftCorner):
+(WebCore):
+(WebCore::ContainerNode::getLowerRightCorner):
+(WebCore::ContainerNode::boundingBox):
+* dom/ContainerNode.h:
+(ContainerNode):
+
 2012-09-14  James Robinson  
 
 Unreviewed, rolling out r128627.


Modified: trunk/Source/WebCore/dom/ContainerNode.cpp (128643 => 128644)

--- trunk/Source/WebCore/dom/ContainerNode.cpp	2012-09-14 20:00:58 UTC (rev 128643)
+++ trunk/Source/WebCore/dom/ContainerNode.cpp	2012-09-14 20:01:36 UTC (rev 128644)
@@ -726,6 +726,134 @@
 }
 }
 
+bool ContainerNode::getUpperLeftCorner(FloatPoint& point) const
+{
+if (!renderer())
+return false;
+// What is this code really trying to do?
+RenderObject* o = renderer();
+RenderObject* p = o;
+
+if (!o->isInline() || o->isReplaced()) {
+point = o->localToAbsolute(FloatPoint(), false, true);
+return true;
+}
+
+// find the next text/image child, to get a position
+while (o) {
+p = o;
+if (o->firstChild())
+o = o->firstChild();
+else if (o->nextSibling())
+o = o->nextSibling();
+else {
+RenderObject* next = 0;
+while (!next && o->parent()) {
+o = o->parent();
+next = o->nextSibling();
+}
+o = next;
+
+if (!o)
+break;
+}
+ASSERT(o);
+
+if (!o->isInline() || o->isReplaced()) {
+point = o->localToAbsolute(FloatPoint(), false, true);
+return true;
+}
+
+if (p->node() && p->node() == this && o->isText() && !o->isBR() && !toRenderText(o)->firstTextBox()) {
+// do nothing - skip unrendered whitespace that is a child or next sibling of the anchor
+} else if ((o->isText() && !o->isBR()) || o->isReplaced()) {
+point = FloatPoint();
+if (o->isText() && toRenderText(o)->firstTextBox()) {
+point.move(toRenderText(o)->linesBoundingBox().x(), toRenderText(o)->firstText

[webkit-changes] [128643] trunk/Source/WebKit/chromium

2012-09-14 Thread commit-queue

Title: [128643] trunk/Source/WebKit/chromium








Revision 128643
Author commit-qu...@webkit.org
Date 2012-09-14 13:00:58 -0700 (Fri, 14 Sep 2012)


Log Message
[chromium] add touch area to gestureTapDown data
https://bugs.webkit.org/show_bug.cgi?id=96806

Patch by Rick Byers  on 2012-09-14
Reviewed by Adam Barth.

Add width/height for GestureTapDown as for GestureTap/LongPress so that
we can eventually do fuzzing on it.
* public/WebInputEvent.h:
* src/WebInputEventConversion.cpp:
(WebKit::PlatformGestureEventBuilder::PlatformGestureEventBuilder):

Modified Paths

trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/public/WebInputEvent.h
trunk/Source/WebKit/chromium/src/WebInputEventConversion.cpp




Diff

Modified: trunk/Source/WebKit/chromium/ChangeLog (128642 => 128643)

--- trunk/Source/WebKit/chromium/ChangeLog	2012-09-14 19:49:51 UTC (rev 128642)
+++ trunk/Source/WebKit/chromium/ChangeLog	2012-09-14 20:00:58 UTC (rev 128643)
@@ -1,3 +1,16 @@
+2012-09-14  Rick Byers  
+
+[chromium] add touch area to gestureTapDown data
+https://bugs.webkit.org/show_bug.cgi?id=96806
+
+Reviewed by Adam Barth.
+
+Add width/height for GestureTapDown as for GestureTap/LongPress so that
+we can eventually do fuzzing on it.
+* public/WebInputEvent.h:
+* src/WebInputEventConversion.cpp:
+(WebKit::PlatformGestureEventBuilder::PlatformGestureEventBuilder):
+
 2012-09-14  Peter Beverloo  
 
 [Chromium] Support the --{in,out,err}-fifo arguments on TestWebKitAPI and webkit_unit_tests


Modified: trunk/Source/WebKit/chromium/public/WebInputEvent.h (128642 => 128643)

--- trunk/Source/WebKit/chromium/public/WebInputEvent.h	2012-09-14 19:49:51 UTC (rev 128642)
+++ trunk/Source/WebKit/chromium/public/WebInputEvent.h	2012-09-14 20:00:58 UTC (rev 128643)
@@ -388,6 +388,11 @@
   struct {
 int width;
 int height;
+  } tapDown;
+
+  struct {
+int width;
+int height;
   } longPress;
 
   struct {


Modified: trunk/Source/WebKit/chromium/src/WebInputEventConversion.cpp (128642 => 128643)

--- trunk/Source/WebKit/chromium/src/WebInputEventConversion.cpp	2012-09-14 19:49:51 UTC (rev 128642)
+++ trunk/Source/WebKit/chromium/src/WebInputEventConversion.cpp	2012-09-14 20:00:58 UTC (rev 128643)
@@ -160,6 +160,7 @@
 break;
 case WebInputEvent::GestureTapDown:
 m_type = PlatformEvent::GestureTapDown;
+m_area = IntSize(e.data.tapDown.width, e.data.tapDown.height);
 break;
 case WebInputEvent::GestureDoubleTap:
 m_type = PlatformEvent::GestureDoubleTap;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [128641] trunk/Source/WebCore

2012-09-14 Thread achicu

Title: [128641] trunk/Source/WebCore








Revision 128641
Author ach...@adobe.com
Date 2012-09-14 12:31:04 -0700 (Fri, 14 Sep 2012)


Log Message
[CSS Shaders] Refactor FECustomFilter to make it usable from platform dependent implementations
https://bugs.webkit.org/show_bug.cgi?id=96801

Reviewed by Dean Jackson.

I've refactored the FECustomFilter to allow FECustomFilterSkia.cpp to use the rendering part
from outside.

Also removed the Texture class as it is not available on some platforms.

The changes for Skia will land in a different patch:
https://bugs.webkit.org/show_bug.cgi?id=96579

No new tests, the existing custom filters tests should already cover this.

* platform/graphics/filters/CustomFilterGlobalContext.cpp:
(WebCore::CustomFilterGlobalContext::prepareContextIfNeeded):
* platform/graphics/filters/FECustomFilter.cpp:
(WebCore::FECustomFilter::FECustomFilter):
(WebCore::FECustomFilter::deleteRenderBuffers):
(WebCore::FECustomFilter::drawFilterMesh):
(WebCore):
(WebCore::FECustomFilter::prepareForDrawing):
(WebCore::FECustomFilter::programNeedsInputTexture):
(WebCore::FECustomFilter::applyShader):
(WebCore::FECustomFilter::initializeContext):
(WebCore::FECustomFilter::ensureInputTexture):
(WebCore::FECustomFilter::uploadInputTexture):
(WebCore::FECustomFilter::ensureFrameBuffer):
(WebCore::FECustomFilter::resizeContextIfNeeded):
(WebCore::FECustomFilter::resizeContext):
(WebCore::FECustomFilter::bindProgramAndBuffers):
* platform/graphics/filters/FECustomFilter.h:
(FECustomFilter):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/filters/CustomFilterGlobalContext.cpp
trunk/Source/WebCore/platform/graphics/filters/FECustomFilter.cpp
trunk/Source/WebCore/platform/graphics/filters/FECustomFilter.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (128640 => 128641)

--- trunk/Source/WebCore/ChangeLog	2012-09-14 19:22:01 UTC (rev 128640)
+++ trunk/Source/WebCore/ChangeLog	2012-09-14 19:31:04 UTC (rev 128641)
@@ -1,3 +1,40 @@
+2012-09-14  Alexandru Chiculita  
+
+[CSS Shaders] Refactor FECustomFilter to make it usable from platform dependent implementations
+https://bugs.webkit.org/show_bug.cgi?id=96801
+
+Reviewed by Dean Jackson.
+
+I've refactored the FECustomFilter to allow FECustomFilterSkia.cpp to use the rendering part
+from outside.
+
+Also removed the Texture class as it is not available on some platforms.
+
+The changes for Skia will land in a different patch:
+https://bugs.webkit.org/show_bug.cgi?id=96579
+
+No new tests, the existing custom filters tests should already cover this.
+
+* platform/graphics/filters/CustomFilterGlobalContext.cpp:
+(WebCore::CustomFilterGlobalContext::prepareContextIfNeeded):
+* platform/graphics/filters/FECustomFilter.cpp:
+(WebCore::FECustomFilter::FECustomFilter):
+(WebCore::FECustomFilter::deleteRenderBuffers):
+(WebCore::FECustomFilter::drawFilterMesh):
+(WebCore):
+(WebCore::FECustomFilter::prepareForDrawing):
+(WebCore::FECustomFilter::programNeedsInputTexture):
+(WebCore::FECustomFilter::applyShader):
+(WebCore::FECustomFilter::initializeContext):
+(WebCore::FECustomFilter::ensureInputTexture):
+(WebCore::FECustomFilter::uploadInputTexture):
+(WebCore::FECustomFilter::ensureFrameBuffer):
+(WebCore::FECustomFilter::resizeContextIfNeeded):
+(WebCore::FECustomFilter::resizeContext):
+(WebCore::FECustomFilter::bindProgramAndBuffers):
+* platform/graphics/filters/FECustomFilter.h:
+(FECustomFilter):
+
 2012-09-14  Alexey Proskuryakov  
 
 REGRESSION(r126717): It made inspector/styles/media-queries.html fail/flakey


Modified: trunk/Source/WebCore/platform/graphics/filters/CustomFilterGlobalContext.cpp (128640 => 128641)

--- trunk/Source/WebCore/platform/graphics/filters/CustomFilterGlobalContext.cpp	2012-09-14 19:22:01 UTC (rev 128640)
+++ trunk/Source/WebCore/platform/graphics/filters/CustomFilterGlobalContext.cpp	2012-09-14 19:31:04 UTC (rev 128641)
@@ -78,6 +78,8 @@
 GraphicsContext3D::Attributes attributes;
 attributes.preserveDrawingBuffer = true;
 attributes.premultipliedAlpha = false;
+attributes.shareResources = true;
+attributes.preferDiscreteGPU = true;
 m_context = GraphicsContext3D::create(attributes, hostWindow, GraphicsContext3D::RenderOffscreen);
 if (!m_context)
 return;


Modified: trunk/Source/WebCore/platform/graphics/filters/FECustomFilter.cpp (128640 => 128641)

--- trunk/Source/WebCore/platform/graphics/filters/FECustomFilter.cpp	2012-09-14 19:22:01 UTC (rev 128640)
+++ trunk/Source/WebCore/platform/graphics/filters/FECustomFilter.cpp	2012-09-14 19:31:04 UTC (rev 128641)
@@ -1,4 +1,5 @@
 /*
+ * Copyright (C) 2012 Adobe Systems Incorporated. All rights reserved.
  * Copyright (C) 2011 Adobe Systems Incorporated. All rights reserved

[webkit-changes] [128640] trunk/LayoutTests

2012-09-14 Thread ojan

Title: [128640] trunk/LayoutTests








Revision 128640
Author o...@chromium.org
Date 2012-09-14 12:22:01 -0700 (Fri, 14 Sep 2012)


Log Message
Comment out bug URL. This fixes a lint warning.
* platform/qt/Skipped:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/qt/Skipped




Diff

Modified: trunk/LayoutTests/ChangeLog (128639 => 128640)

--- trunk/LayoutTests/ChangeLog	2012-09-14 19:19:50 UTC (rev 128639)
+++ trunk/LayoutTests/ChangeLog	2012-09-14 19:22:01 UTC (rev 128640)
@@ -1,5 +1,10 @@
 2012-09-14  Ojan Vafai  
 
+Comment out bug URL. This fixes a lint warning.
+* platform/qt/Skipped:
+
+2012-09-14  Ojan Vafai  
+
 Update all the MISSING lines in chromium's TestExpectations.
 If the test always passed, removed the line. In some cases, they just needed
 obvious rebaselines. In others, they haven't reported MISSING in the past


Modified: trunk/LayoutTests/platform/qt/Skipped (128639 => 128640)

--- trunk/LayoutTests/platform/qt/Skipped	2012-09-14 19:19:50 UTC (rev 128639)
+++ trunk/LayoutTests/platform/qt/Skipped	2012-09-14 19:22:01 UTC (rev 128640)
@@ -2755,7 +2755,7 @@
 fast/forms/time-multiple-fields
 
 # [Qt] New inspector/timeline/timeline-decode-resize.html introduced in r125790 fails
-https://bugs.webkit.org/show_bug.cgi?id=94341
+# https://bugs.webkit.org/show_bug.cgi?id=94341
 inspector/timeline/timeline-decode-resize.html
 
 # REGRESSION(r126852): It broke inspector tests






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [128638] trunk/Tools

2012-09-14 Thread ap

Title: [128638] trunk/Tools








Revision 128638
Author a...@apple.com
Date 2012-09-14 12:08:29 -0700 (Fri, 14 Sep 2012)


Log Message
[WK2] webarchive/loading/_javascript_-url-iframe-crash.html fails
https://bugs.webkit.org/show_bug.cgi?id=96817

Reviewed by Kenneth Rohde Christiansen.

* WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame): This callback
got overlooked when adding logging elsewhere.

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp




Diff

Modified: trunk/Tools/ChangeLog (128637 => 128638)

--- trunk/Tools/ChangeLog	2012-09-14 19:04:17 UTC (rev 128637)
+++ trunk/Tools/ChangeLog	2012-09-14 19:08:29 UTC (rev 128638)
@@ -1,3 +1,14 @@
+2012-09-14  Alexey Proskuryakov  
+
+[WK2] webarchive/loading/_javascript_-url-iframe-crash.html fails
+https://bugs.webkit.org/show_bug.cgi?id=96817
+
+Reviewed by Kenneth Rohde Christiansen.
+
+* WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
+(WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame): This callback
+got overlooked when adding logging elsewhere.
+
 2012-09-14  Peter Beverloo  
 
 [Chromium] Build fix for DumpRenderTree following r128628


Modified: trunk/Tools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp (128637 => 128638)

--- trunk/Tools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp	2012-09-14 19:04:17 UTC (rev 128637)
+++ trunk/Tools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp	2012-09-14 19:08:29 UTC (rev 128638)
@@ -774,6 +774,11 @@
 if (!InjectedBundle::shared().isTestRunning())
 return;
 
+if (InjectedBundle::shared().testRunner()->shouldDumpFrameLoadCallbacks()) {
+dumpFrameDescriptionSuitableForTestResult(frame);
+InjectedBundle::shared().stringBuilder()->appendLiteral(" - didFailProvisionalLoadWithError\n");
+}
+
 if (frame != InjectedBundle::shared().topLoadingFrame())
 return;
 InjectedBundle::shared().setTopLoadingFrame(0);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [128637] trunk/Source/WebCore

2012-09-14 Thread ap

Title: [128637] trunk/Source/WebCore








Revision 128637
Author a...@apple.com
Date 2012-09-14 12:04:17 -0700 (Fri, 14 Sep 2012)


Log Message
REGRESSION(r126717): It made inspector/styles/media-queries.html fail/flakey
https://bugs.webkit.org/show_bug.cgi?id=95070

Roll out r126717, and another change that depends on it.
r126717: Remove parent pointer from StyleSheetContents and StyleRuleImport
r127123: Cache and share parsed imported stylesheets

* css/CSSImportRule.cpp:
* css/CSSImportRule.h:
* css/CSSStyleSheet.cpp:
(WebCore::CSSStyleSheet::willMutateRules):
(WebCore::CSSStyleSheet::reattachChildRuleCSSOMWrappers):
(WebCore::CSSStyleSheet::insertRule):
(WebCore::CSSStyleSheet::ownerDocument):
* css/CSSStyleSheet.h:
(WebCore::CSSStyleSheet::clearOwnerRule):
* css/StyleRuleImport.cpp:
(WebCore::StyleRuleImport::StyleRuleImport):
(WebCore::StyleRuleImport::~StyleRuleImport):
(WebCore::StyleRuleImport::setCSSStyleSheet):
(WebCore::StyleRuleImport::isLoading):
(WebCore::StyleRuleImport::requestStyleSheet):
* css/StyleRuleImport.h:
(WebCore::StyleRuleImport::parentStyleSheet):
(WebCore::StyleRuleImport::setParentStyleSheet):
(WebCore::StyleRuleImport::clearParentStyleSheet):
(ImportedStyleSheetClient):
(WebCore::StyleRuleImport::ImportedStyleSheetClient::ImportedStyleSheetClient):
(WebCore::StyleRuleImport::ImportedStyleSheetClient::~ImportedStyleSheetClient):
(WebCore::StyleRuleImport::ImportedStyleSheetClient::setCSSStyleSheet):
* css/StyleSheetContents.cpp:
(WebCore::StyleSheetContents::StyleSheetContents):
(WebCore::StyleSheetContents::isCacheable):
(WebCore::StyleSheetContents::parserAppendRule):
(WebCore::StyleSheetContents::clearRules):
(WebCore::StyleSheetContents::wrapperInsertRule):
(WebCore::StyleSheetContents::wrapperDeleteRule):
(WebCore::StyleSheetContents::parseAuthorStyleSheet):
(WebCore::StyleSheetContents::parseStringAtLine):
(WebCore::StyleSheetContents::checkLoaded):
(WebCore::StyleSheetContents::notifyLoadedSheet):
(WebCore::StyleSheetContents::startLoadingDynamicSheet):
(WebCore::StyleSheetContents::rootStyleSheet):
(WebCore::StyleSheetContents::singleOwnerNode):
(WebCore::StyleSheetContents::singleOwnerDocument):
(WebCore::StyleSheetContents::parentStyleSheet):
* css/StyleSheetContents.h:
(WebCore::StyleSheetContents::create):
(StyleSheetContents):
(WebCore::StyleSheetContents::ownerRule):
(WebCore::StyleSheetContents::clearOwnerRule):
* dom/ProcessingInstruction.cpp:
(WebCore::ProcessingInstruction::parseStyleSheet):
* dom/StyleElement.cpp:
(WebCore::StyleElement::createSheet):
* html/HTMLLinkElement.cpp:
(WebCore::HTMLLinkElement::setCSSStyleSheet):
* loader/cache/CachedCSSStyleSheet.cpp:
(WebCore::CachedCSSStyleSheet::saveParsedStyleSheet):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/CSSImportRule.cpp
trunk/Source/WebCore/css/CSSImportRule.h
trunk/Source/WebCore/css/CSSStyleSheet.cpp
trunk/Source/WebCore/css/CSSStyleSheet.h
trunk/Source/WebCore/css/StyleRuleImport.cpp
trunk/Source/WebCore/css/StyleRuleImport.h
trunk/Source/WebCore/css/StyleSheetContents.cpp
trunk/Source/WebCore/css/StyleSheetContents.h
trunk/Source/WebCore/dom/ProcessingInstruction.cpp
trunk/Source/WebCore/dom/StyleElement.cpp
trunk/Source/WebCore/html/HTMLLinkElement.cpp
trunk/Source/WebCore/loader/cache/CachedCSSStyleSheet.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (128636 => 128637)

--- trunk/Source/WebCore/ChangeLog	2012-09-14 18:53:01 UTC (rev 128636)
+++ trunk/Source/WebCore/ChangeLog	2012-09-14 19:04:17 UTC (rev 128637)
@@ -1,3 +1,65 @@
+2012-09-14  Alexey Proskuryakov  
+
+REGRESSION(r126717): It made inspector/styles/media-queries.html fail/flakey
+https://bugs.webkit.org/show_bug.cgi?id=95070
+
+Roll out r126717, and another change that depends on it.
+r126717: Remove parent pointer from StyleSheetContents and StyleRuleImport
+r127123: Cache and share parsed imported stylesheets
+
+* css/CSSImportRule.cpp:
+* css/CSSImportRule.h:
+* css/CSSStyleSheet.cpp:
+(WebCore::CSSStyleSheet::willMutateRules):
+(WebCore::CSSStyleSheet::reattachChildRuleCSSOMWrappers):
+(WebCore::CSSStyleSheet::insertRule):
+(WebCore::CSSStyleSheet::ownerDocument):
+* css/CSSStyleSheet.h:
+(WebCore::CSSStyleSheet::clearOwnerRule):
+* css/StyleRuleImport.cpp:
+(WebCore::StyleRuleImport::StyleRuleImport):
+(WebCore::StyleRuleImport::~StyleRuleImport):
+(WebCore::StyleRuleImport::setCSSStyleSheet):
+

[webkit-changes] [128636] trunk/Source/WebKit2

2012-09-14 Thread commit-queue

Title: [128636] trunk/Source/WebKit2








Revision 128636
Author commit-qu...@webkit.org
Date 2012-09-14 11:53:01 -0700 (Fri, 14 Sep 2012)


Log Message
[EFL] RefPtr unit tests fails
https://bugs.webkit.org/show_bug.cgi?id=96809

Patch by Sudarsana Nagineni  on 2012-09-14
Reviewed by Kenneth Rohde Christiansen.

Added missing return.

* UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestBase.h:
(EWK2UnitTest::EWK2UnitTestBase::canvas):

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestBase.h




Diff

Modified: trunk/Source/WebKit2/ChangeLog (128635 => 128636)

--- trunk/Source/WebKit2/ChangeLog	2012-09-14 18:52:18 UTC (rev 128635)
+++ trunk/Source/WebKit2/ChangeLog	2012-09-14 18:53:01 UTC (rev 128636)
@@ -1,3 +1,15 @@
+2012-09-14  Sudarsana Nagineni  
+
+[EFL] RefPtr unit tests fails
+https://bugs.webkit.org/show_bug.cgi?id=96809
+
+Reviewed by Kenneth Rohde Christiansen.
+
+Added missing return.
+
+* UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestBase.h:
+(EWK2UnitTest::EWK2UnitTestBase::canvas):
+
 2012-09-14  Christophe Dumez  
 
 WebKitTestRunner needs layoutTestController.dumpDatabaseCallbacks


Modified: trunk/Source/WebKit2/UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestBase.h (128635 => 128636)

--- trunk/Source/WebKit2/UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestBase.h	2012-09-14 18:52:18 UTC (rev 128635)
+++ trunk/Source/WebKit2/UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestBase.h	2012-09-14 18:53:01 UTC (rev 128636)
@@ -30,7 +30,7 @@
 class EWK2UnitTestBase : public ::testing::Test {
 public:
 Ecore_Evas* backingStore() { return m_ecoreEvas; }
-Evas* canvas() { ecore_evas_get(m_ecoreEvas); }
+Evas* canvas() { return ecore_evas_get(m_ecoreEvas); }
 Evas_Object* webView() { return m_webView; }
 Ewk_View_Smart_Class* ewkViewClass() { return &m_ewkViewClass; }
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [128635] trunk/LayoutTests

2012-09-14 Thread ojan

Title: [128635] trunk/LayoutTests








Revision 128635
Author o...@chromium.org
Date 2012-09-14 11:52:18 -0700 (Fri, 14 Sep 2012)


Log Message
Complete forgotten rebaseline. See https://bugs.webkit.org/show_bug.cgi?id=96751.
The results all look like they pass.

* platform/chromium-linux/fast/forms/time-multiple-fields/time-multiple-fields-localization-expected.txt: Copied from LayoutTests/platform/chromium-mac/fast/forms/time-multiple-fields/time-multiple-fields-localization-expected.txt.
* platform/chromium-win-xp/fast/forms/time-multiple-fields/time-multiple-fields-localization-expected.txt: Copied from LayoutTests/platform/chromium-mac/fast/forms/time-multiple-fields/time-multiple-fields-localization-expected.txt.
* platform/chromium-win/fast/forms/time-multiple-fields/time-multiple-fields-localization-expected.txt: Copied from LayoutTests/platform/chromium-mac/fast/forms/time-multiple-fields/time-multiple-fields-localization-expected.txt.
* platform/chromium/TestExpectations:
* platform/chromium/fast/forms/time-multiple-fields/time-multiple-fields-localization-expected.txt: Renamed from LayoutTests/platform/chromium-mac/fast/forms/time-multiple-fields/time-multiple-fields-localization-expected.txt.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/TestExpectations


Added Paths

trunk/LayoutTests/platform/chromium/fast/forms/time-multiple-fields/
trunk/LayoutTests/platform/chromium/fast/forms/time-multiple-fields/time-multiple-fields-localization-expected.txt
trunk/LayoutTests/platform/chromium-linux/fast/forms/time-multiple-fields/time-multiple-fields-localization-expected.txt
trunk/LayoutTests/platform/chromium-win/fast/forms/time-multiple-fields/time-multiple-fields-localization-expected.txt
trunk/LayoutTests/platform/chromium-win-xp/fast/forms/time-multiple-fields/time-multiple-fields-localization-expected.txt


Removed Paths

trunk/LayoutTests/platform/chromium-mac/fast/forms/time-multiple-fields/time-multiple-fields-localization-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (128634 => 128635)

--- trunk/LayoutTests/ChangeLog	2012-09-14 18:48:57 UTC (rev 128634)
+++ trunk/LayoutTests/ChangeLog	2012-09-14 18:52:18 UTC (rev 128635)
@@ -1,5 +1,16 @@
 2012-09-14  Ojan Vafai  
 
+Complete forgotten rebaseline. See https://bugs.webkit.org/show_bug.cgi?id=96751.
+The results all look like they pass.
+
+* platform/chromium-linux/fast/forms/time-multiple-fields/time-multiple-fields-localization-expected.txt: Copied from LayoutTests/platform/chromium-mac/fast/forms/time-multiple-fields/time-multiple-fields-localization-expected.txt.
+* platform/chromium-win-xp/fast/forms/time-multiple-fields/time-multiple-fields-localization-expected.txt: Copied from LayoutTests/platform/chromium-mac/fast/forms/time-multiple-fields/time-multiple-fields-localization-expected.txt.
+* platform/chromium-win/fast/forms/time-multiple-fields/time-multiple-fields-localization-expected.txt: Copied from LayoutTests/platform/chromium-mac/fast/forms/time-multiple-fields/time-multiple-fields-localization-expected.txt.
+* platform/chromium/TestExpectations:
+* platform/chromium/fast/forms/time-multiple-fields/time-multiple-fields-localization-expected.txt: Renamed from LayoutTests/platform/chromium-mac/fast/forms/time-multiple-fields/time-multiple-fields-localization-expected.txt.
+
+2012-09-14  Ojan Vafai  
+
 Complete some forgotten rebaselines. See https://bugs.webkit.org/show_bug.cgi?id=94916.
 All the differences were anti-aliasing/form-controls.
 


Modified: trunk/LayoutTests/platform/chromium/TestExpectations (128634 => 128635)

--- trunk/LayoutTests/platform/chromium/TestExpectations	2012-09-14 18:48:57 UTC (rev 128634)
+++ trunk/LayoutTests/platform/chromium/TestExpectations	2012-09-14 18:52:18 UTC (rev 128635)
@@ -183,8 +183,6 @@
 // Chromium needs larger media files to test buffering this way.
 BUGWK88172 SKIP : http/tests/media/video-buffered.html = PASS
 
-BUGWK96751 WIN LINUX : fast/forms/time-multiple-fields/time-multiple-fields-localization.html = MISSING TEXT
-
 // Proximity Events is not supported.
 BUGWK92942 SKIP : fast/dom/Proximity = PASS
 BUGWK92942 SKIP : fast/events/constructors/device-proximity-event-constructor.html = PASS


Copied: trunk/LayoutTests/platform/chromium/fast/forms/time-multiple-fields/time-multiple-fields-localization-expected.txt (from rev 128634, trunk/LayoutTests/platform/chromium-mac/fast/forms/time-multiple-fields/time-multiple-fields-localization-expected.txt) (0 => 128635)

--- trunk/LayoutTests/platform/chromium/fast/forms/time-multiple-fields/time-multiple-fields-localization-expected.txt	(rev 0)
+++ trunk/LayoutTests/platform/chromium/fast/forms/time-multiple-fields/time-multiple-fields-localization-expected.txt	2012-09-14 18:52:18 UTC (rev 128635)
@@ -0,0 +1,21 @@
+Tests the time format for various locales.
+
+On success, you will see no "F

[webkit-changes] [128634] trunk/LayoutTests

2012-09-14 Thread ojan

Title: [128634] trunk/LayoutTests








Revision 128634
Author o...@chromium.org
Date 2012-09-14 11:48:57 -0700 (Fri, 14 Sep 2012)


Log Message
Complete some forgotten rebaselines. See https://bugs.webkit.org/show_bug.cgi?id=94916.
All the differences were anti-aliasing/form-controls.

* platform/chromium-linux/fast/forms/datalist/input-appearance-range-with-datalist-zoomed-expected.png:
* platform/chromium-linux/fast/forms/datalist/input-appearance-range-with-padding-with-datalist-expected.png: Added.
* platform/chromium-linux/fast/forms/datalist/input-appearance-range-with-transform-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/forms/datalist/input-appearance-range-with-padding-with-datalist-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/forms/datalist/input-appearance-range-with-transform-expected.png: Added.
* platform/chromium-win-xp/fast/forms/datalist/input-appearance-range-with-datalist-zoomed-expected.png: Removed.
* platform/chromium-win/fast/forms/datalist/input-appearance-range-with-datalist-zoomed-expected.png:
* platform/chromium-win/fast/forms/datalist/input-appearance-range-with-padding-with-datalist-expected.png: Added.
* platform/chromium-win/fast/forms/datalist/input-appearance-range-with-transform-expected.png: Added.
* platform/chromium/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/TestExpectations
trunk/LayoutTests/platform/chromium-linux/fast/forms/datalist/input-appearance-range-with-datalist-zoomed-expected.png
trunk/LayoutTests/platform/chromium-win/fast/forms/datalist/input-appearance-range-with-datalist-zoomed-expected.png


Added Paths

trunk/LayoutTests/platform/chromium-linux/fast/forms/datalist/input-appearance-range-with-padding-with-datalist-expected.png
trunk/LayoutTests/platform/chromium-linux/fast/forms/datalist/input-appearance-range-with-transform-expected.png
trunk/LayoutTests/platform/chromium-mac-snowleopard/fast/forms/datalist/input-appearance-range-with-padding-with-datalist-expected.png
trunk/LayoutTests/platform/chromium-mac-snowleopard/fast/forms/datalist/input-appearance-range-with-transform-expected.png
trunk/LayoutTests/platform/chromium-win/fast/forms/datalist/input-appearance-range-with-padding-with-datalist-expected.png
trunk/LayoutTests/platform/chromium-win/fast/forms/datalist/input-appearance-range-with-transform-expected.png


Removed Paths

trunk/LayoutTests/platform/chromium-win-xp/fast/forms/datalist/input-appearance-range-with-datalist-zoomed-expected.png




Diff

Modified: trunk/LayoutTests/ChangeLog (128633 => 128634)

--- trunk/LayoutTests/ChangeLog	2012-09-14 18:42:53 UTC (rev 128633)
+++ trunk/LayoutTests/ChangeLog	2012-09-14 18:48:57 UTC (rev 128634)
@@ -1,3 +1,19 @@
+2012-09-14  Ojan Vafai  
+
+Complete some forgotten rebaselines. See https://bugs.webkit.org/show_bug.cgi?id=94916.
+All the differences were anti-aliasing/form-controls.
+
+* platform/chromium-linux/fast/forms/datalist/input-appearance-range-with-datalist-zoomed-expected.png:
+* platform/chromium-linux/fast/forms/datalist/input-appearance-range-with-padding-with-datalist-expected.png: Added.
+* platform/chromium-linux/fast/forms/datalist/input-appearance-range-with-transform-expected.png: Added.
+* platform/chromium-mac-snowleopard/fast/forms/datalist/input-appearance-range-with-padding-with-datalist-expected.png: Added.
+* platform/chromium-mac-snowleopard/fast/forms/datalist/input-appearance-range-with-transform-expected.png: Added.
+* platform/chromium-win-xp/fast/forms/datalist/input-appearance-range-with-datalist-zoomed-expected.png: Removed.
+* platform/chromium-win/fast/forms/datalist/input-appearance-range-with-datalist-zoomed-expected.png:
+* platform/chromium-win/fast/forms/datalist/input-appearance-range-with-padding-with-datalist-expected.png: Added.
+* platform/chromium-win/fast/forms/datalist/input-appearance-range-with-transform-expected.png: Added.
+* platform/chromium/TestExpectations:
+
 2012-09-14  David Grogan  
 
 IndexedDB: Print console warning about setVersion


Modified: trunk/LayoutTests/platform/chromium/TestExpectations (128633 => 128634)

--- trunk/LayoutTests/platform/chromium/TestExpectations	2012-09-14 18:42:53 UTC (rev 128633)
+++ trunk/LayoutTests/platform/chromium/TestExpectations	2012-09-14 18:48:57 UTC (rev 128634)
@@ -183,10 +183,6 @@
 // Chromium needs larger media files to test buffering this way.
 BUGWK88172 SKIP : http/tests/media/video-buffered.html = PASS
 
-BUGWK94916 SNOWLEOPARD WIN LINUX : fast/forms/datalist/input-appearance-range-with-padding-with-datalist.html = MISSING IMAGE
-BUGWK94916 SNOWLEOPARD WIN LINUX : fast/forms/datalist/input-appearance-range-with-transform.html = MISSING IMAGE
-BUGWK94916 SNOWLEOPARD WIN LINUX : fast/forms/datalist/input-appearance-range-with-datalist-zoomed.html = IMAGE
-
 BUGWK96751 WIN LINUX : fast/forms/ti

[webkit-changes] [128633] trunk/Source/WebCore

2012-09-14 Thread ojan

Title: [128633] trunk/Source/WebCore








Revision 128633
Author o...@chromium.org
Date 2012-09-14 11:42:53 -0700 (Fri, 14 Sep 2012)


Log Message
Simplify some code in RenderBox::computePercentageLogicalHeight
https://bugs.webkit.org/show_bug.cgi?id=96704

Reviewed by Tony Chang.

This is strictly code cleanup. No behavior change.
Also removed some comments that were what comments and/or were
getting stale.

* rendering/RenderBox.cpp:
(WebCore::RenderBox::skipContainingBlockForPercentHeightCalculation):
(WebCore):
(WebCore::RenderBox::computePercentageLogicalHeight):
* rendering/RenderBox.h:
(RenderBox):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderBox.cpp
trunk/Source/WebCore/rendering/RenderBox.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (128632 => 128633)

--- trunk/Source/WebCore/ChangeLog	2012-09-14 18:26:16 UTC (rev 128632)
+++ trunk/Source/WebCore/ChangeLog	2012-09-14 18:42:53 UTC (rev 128633)
@@ -1,3 +1,21 @@
+2012-09-14  Ojan Vafai  
+
+Simplify some code in RenderBox::computePercentageLogicalHeight
+https://bugs.webkit.org/show_bug.cgi?id=96704
+
+Reviewed by Tony Chang.
+
+This is strictly code cleanup. No behavior change.
+Also removed some comments that were what comments and/or were
+getting stale.
+
+* rendering/RenderBox.cpp:
+(WebCore::RenderBox::skipContainingBlockForPercentHeightCalculation):
+(WebCore):
+(WebCore::RenderBox::computePercentageLogicalHeight):
+* rendering/RenderBox.h:
+(RenderBox):
+
 2012-09-14  Kent Tamura  
 
 Unreviewed, a workaround for a mysterious crash on Apple Windows port.


Modified: trunk/Source/WebCore/rendering/RenderBox.cpp (128632 => 128633)

--- trunk/Source/WebCore/rendering/RenderBox.cpp	2012-09-14 18:26:16 UTC (rev 128632)
+++ trunk/Source/WebCore/rendering/RenderBox.cpp	2012-09-14 18:42:53 UTC (rev 128633)
@@ -2119,21 +2119,23 @@
 return -1;
 }
 
+bool RenderBox::skipContainingBlockForPercentHeightCalculation(const RenderBox* containingBlock) const
+{
+// For quirks mode and anonymous blocks, we skip auto-height containingBlocks when computing percentages.
+// For standards mode, we treat the percentage as auto if it has an auto-height containing block.
+if (!document()->inQuirksMode() && !containingBlock->isAnonymousBlock())
+return false;
+return !containingBlock->isTableCell() && !containingBlock->isOutOfFlowPositioned() && containingBlock->style()->logicalHeight().isAuto() && isHorizontalWritingMode() == containingBlock->isHorizontalWritingMode();
+}
+
 LayoutUnit RenderBox::computePercentageLogicalHeight(const Length& height) const
 {
 LayoutUnit availableHeight = -1;
 
-// In quirks mode, blocks with auto height are skipped, and we keep looking for an enclosing
-// block that may have a specified height and then use it. In strict mode, this violates the
-// specification, which states that percentage heights just revert to auto if the containing
-// block has an auto height. We still skip anonymous containing blocks in both modes, though, and look
-// only at explicit containers.
 bool skippedAutoHeightContainingBlock = false;
 RenderBlock* cb = containingBlock();
 LayoutUnit rootMarginBorderPaddingHeight = 0;
-while (!cb->isRenderView() && !cb->isTableCell() && !cb->isOutOfFlowPositioned() && cb->style()->logicalHeight().isAuto() && isHorizontalWritingMode() == cb->isHorizontalWritingMode()) {
-if (!document()->inQuirksMode() && !cb->isAnonymousBlock())
-break;
+while (!cb->isRenderView() && skipContainingBlockForPercentHeightCalculation(cb)) {
 if (cb->isBody() || cb->isRoot())
 rootMarginBorderPaddingHeight += cb->marginBefore() + cb->marginAfter() + cb->borderAndPaddingLogicalHeight();
 skippedAutoHeightContainingBlock = true;
@@ -2153,29 +2155,26 @@
 
 if (isHorizontalWritingMode() != cb->isHorizontalWritingMode())
 availableHeight = cb->contentLogicalWidth();
-else if (cb->isTableCell()) {
+else if (cb->isTableCell() && !skippedAutoHeightContainingBlock) {
 // Table cells violate what the CSS spec says to do with heights. Basically we
 // don't care if the cell specified a height or not. We just always make ourselves
 // be a percentage of the cell's current content height.
-if (!skippedAutoHeightContainingBlock) {
-if (!cb->hasOverrideHeight()) {
-// Normally we would let the cell size intrinsically, but scrolling overflow has to be
-// treated differently, since WinIE lets scrolled overflow regions shrink as needed.
-// While we can't get all cases right, we can at least detect when the cell has a specified
-// height or when the table has a specified height.  In these cases we want to initially have
-// no size and allo

[webkit-changes] [128632] trunk/Tools

2012-09-14 Thread peter

Title: [128632] trunk/Tools








Revision 128632
Author pe...@chromium.org
Date 2012-09-14 11:26:16 -0700 (Fri, 14 Sep 2012)


Log Message
[Chromium] Build fix for DumpRenderTree following r128628
https://bugs.webkit.org/show_bug.cgi?id=96808

Reviewed by Tony Chang.

When building DumpRenderTree from the Chromium project, a compile error
shows up because including the header ForwardIOStreamsAndroid.h cannot
be located. TestWebKitAPI does this correctly.

* DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp




Diff

Modified: trunk/Tools/ChangeLog (128631 => 128632)

--- trunk/Tools/ChangeLog	2012-09-14 18:20:47 UTC (rev 128631)
+++ trunk/Tools/ChangeLog	2012-09-14 18:26:16 UTC (rev 128632)
@@ -1,3 +1,16 @@
+2012-09-14  Peter Beverloo  
+
+[Chromium] Build fix for DumpRenderTree following r128628
+https://bugs.webkit.org/show_bug.cgi?id=96808
+
+Reviewed by Tony Chang.
+
+When building DumpRenderTree from the Chromium project, a compile error
+shows up because including the header ForwardIOStreamsAndroid.h cannot
+be located. TestWebKitAPI does this correctly.
+
+* DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
+
 2012-09-14  Dana Jansens  
 
 Change cc-b...@google.com watchlist to cc-b...@chromium.org


Modified: trunk/Tools/DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp (128631 => 128632)

--- trunk/Tools/DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp	2012-09-14 18:20:47 UTC (rev 128631)
+++ trunk/Tools/DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp	2012-09-14 18:26:16 UTC (rev 128632)
@@ -292,6 +292,14 @@
 'copy_TestNetscapePlugIn',
 '<(chromium_src_dir)/third_party/mesa/mesa.gyp:osmesa',
 ],
+# FIXME: Remove when the io_stream_forwarder_android target is deprecated.
+'conditions': [
+['inside_chromium_build==1', {
+'include_dirs': [
+'<(source_dir)/WebKit/chromium/',
+],
+}],
+],
 'copies': [{
 'destination': '<(PRODUCT_DIR)',
 'files': [






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [128631] trunk/Tools

2012-09-14 Thread danakj

Title: [128631] trunk/Tools








Revision 128631
Author dan...@chromium.org
Date 2012-09-14 11:20:47 -0700 (Fri, 14 Sep 2012)


Log Message
Change cc-b...@google.com watchlist to cc-b...@chromium.org
https://bugs.webkit.org/show_bug.cgi?id=96805

Reviewed by Dirk Pranke.

* Scripts/webkitpy/common/config/committers.py:
* Scripts/webkitpy/common/config/watchlist:

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/common/config/committers.py
trunk/Tools/Scripts/webkitpy/common/config/watchlist




Diff

Modified: trunk/Tools/ChangeLog (128630 => 128631)

--- trunk/Tools/ChangeLog	2012-09-14 17:59:41 UTC (rev 128630)
+++ trunk/Tools/ChangeLog	2012-09-14 18:20:47 UTC (rev 128631)
@@ -1,3 +1,13 @@
+2012-09-14  Dana Jansens  
+
+Change cc-b...@google.com watchlist to cc-b...@chromium.org
+https://bugs.webkit.org/show_bug.cgi?id=96805
+
+Reviewed by Dirk Pranke.
+
+* Scripts/webkitpy/common/config/committers.py:
+* Scripts/webkitpy/common/config/watchlist:
+
 2012-09-14  Peter Beverloo  
 
 [Chromium] Support the --{in,out,err}-fifo arguments on TestWebKitAPI and webkit_unit_tests


Modified: trunk/Tools/Scripts/webkitpy/common/config/committers.py (128630 => 128631)

--- trunk/Tools/Scripts/webkitpy/common/config/committers.py	2012-09-14 17:59:41 UTC (rev 128630)
+++ trunk/Tools/Scripts/webkitpy/common/config/committers.py	2012-09-14 18:20:47 UTC (rev 128631)
@@ -93,7 +93,7 @@
 
 
 watchers_who_are_not_contributors = [
-Account("Chromium Compositor Bugs", ["cc-b...@google.com"], ""),
+Account("Chromium Compositor Bugs", ["cc-b...@chromium.org"], ""),
 Account("Chromium Media Reviews", ["feature-media-revi...@chromium.org"], ""),
 Account("David Levin", ["levin+thread...@chromium.org"], ""),
 Account("David Levin", ["levin+watchl...@chromium.org"], ""),


Modified: trunk/Tools/Scripts/webkitpy/common/config/watchlist (128630 => 128631)

--- trunk/Tools/Scripts/webkitpy/common/config/watchlist	2012-09-14 17:59:41 UTC (rev 128630)
+++ trunk/Tools/Scripts/webkitpy/common/config/watchlist	2012-09-14 18:20:47 UTC (rev 128631)
@@ -246,7 +246,7 @@
 "BlackBerry": [ "mifen...@rim.com", "rwlb...@gmail.com" ],
 "CMake": [ "rak...@webkit.org", "gyuyoung@samsung.com" ],
 "CSS": [ "ale...@webkit.org", "macpher...@chromium.org", "cmarc...@webkit.org" ],
-"ChromiumGraphics": [ "jam...@chromium.org", "cc-b...@google.com" ],
+"ChromiumGraphics": [ "jam...@chromium.org", "cc-b...@chromium.org" ],
 "ChromiumPublicApi": [ "aba...@webkit.org", "dglaz...@chromium.org", "fi...@chromium.org", "jam...@chromium.org", "tkent+wk...@chromium.org" ],
 "DOMAttributes": [ "cmarc...@webkit.org", ],
 "EFL": [ "rak...@webkit.org", "gyuyoung@samsung.com" ],






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [128630] trunk/Source/Platform

2012-09-14 Thread danakj

Title: [128630] trunk/Source/Platform








Revision 128630
Author dan...@chromium.org
Date 2012-09-14 10:59:41 -0700 (Fri, 14 Sep 2012)


Log Message
[chromium] Add the ubercomp WebDelegatedRendererLayer
https://bugs.webkit.org/show_bug.cgi?id=94145

Reviewed by Adrienne Walker.

Expose a WebDelegatedRendererLayer to allow the browser compositor to
embed such a layer in its tree. This layer will be connected to IPC
machinery in the compositor that is yet TBD which will give a set of
RenderPasses with DrawQuads to the impl copy of the layer.

* Platform.gypi:
* chromium/public/WebCompositorSupport.h:
(WebKit):
(WebKit::WebCompositorSupport::createDelegatedRendererLayer):
(WebCompositorSupport):
* chromium/public/WebDelegatedRendererLayer.h: Added.
(WebKit):
(WebDelegatedRendererLayer):
(WebKit::WebDelegatedRendererLayer::~WebDelegatedRendererLayer):

Modified Paths

trunk/Source/Platform/ChangeLog
trunk/Source/Platform/Platform.gypi
trunk/Source/Platform/chromium/public/WebCompositorSupport.h


Added Paths

trunk/Source/Platform/chromium/public/WebDelegatedRendererLayer.h




Diff

Modified: trunk/Source/Platform/ChangeLog (128629 => 128630)

--- trunk/Source/Platform/ChangeLog	2012-09-14 17:54:22 UTC (rev 128629)
+++ trunk/Source/Platform/ChangeLog	2012-09-14 17:59:41 UTC (rev 128630)
@@ -1,3 +1,25 @@
+2012-09-14  Dana Jansens  
+
+[chromium] Add the ubercomp WebDelegatedRendererLayer
+https://bugs.webkit.org/show_bug.cgi?id=94145
+
+Reviewed by Adrienne Walker.
+
+Expose a WebDelegatedRendererLayer to allow the browser compositor to
+embed such a layer in its tree. This layer will be connected to IPC
+machinery in the compositor that is yet TBD which will give a set of
+RenderPasses with DrawQuads to the impl copy of the layer.
+
+* Platform.gypi:
+* chromium/public/WebCompositorSupport.h:
+(WebKit):
+(WebKit::WebCompositorSupport::createDelegatedRendererLayer):
+(WebCompositorSupport):
+* chromium/public/WebDelegatedRendererLayer.h: Added.
+(WebKit):
+(WebDelegatedRendererLayer):
+(WebKit::WebDelegatedRendererLayer::~WebDelegatedRendererLayer):
+
 2012-09-11  Zach Kuznia  
 
 Fix FilterTypeZoom to properly call canvas->restore()


Modified: trunk/Source/Platform/Platform.gypi (128629 => 128630)

--- trunk/Source/Platform/Platform.gypi	2012-09-14 17:54:22 UTC (rev 128629)
+++ trunk/Source/Platform/Platform.gypi	2012-09-14 17:59:41 UTC (rev 128630)
@@ -53,6 +53,7 @@
 'chromium/public/WebCookie.h',
 'chromium/public/WebCookieJar.h',
 'chromium/public/WebData.h',
+'chromium/public/WebDelegatedRendererLayer.h',
 'chromium/public/WebDragData.h',
 'chromium/public/WebExternalTextureLayer.h',
 'chromium/public/WebExternalTextureLayerClient.h',


Modified: trunk/Source/Platform/chromium/public/WebCompositorSupport.h (128629 => 128630)

--- trunk/Source/Platform/chromium/public/WebCompositorSupport.h	2012-09-14 17:54:22 UTC (rev 128629)
+++ trunk/Source/Platform/chromium/public/WebCompositorSupport.h	2012-09-14 17:59:41 UTC (rev 128630)
@@ -36,6 +36,7 @@
 class WebAnimationCurve;
 class WebContentLayer;
 class WebContentLayerClient;
+class WebDelegatedRendererLayer;
 class WebExternalTextureLayer;
 class WebExternalTextureLayerClient;
 class WebFloatAnimationCurve;
@@ -81,6 +82,8 @@
 
 virtual WebContentLayer* createContentLayer(WebContentLayerClient*) { return 0; }
 
+virtual WebDelegatedRendererLayer* createDelegatedRendererLayer() { return 0; }
+
 virtual WebExternalTextureLayer* createExternalTextureLayer(WebExternalTextureLayerClient* = 0) { return 0; }
 
 virtual WebIOSurfaceLayer* createIOSurfaceLayer() { return 0; }


Added: trunk/Source/Platform/chromium/public/WebDelegatedRendererLayer.h (0 => 128630)

--- trunk/Source/Platform/chromium/public/WebDelegatedRendererLayer.h	(rev 0)
+++ trunk/Source/Platform/chromium/public/WebDelegatedRendererLayer.h	2012-09-14 17:59:41 UTC (rev 128630)
@@ -0,0 +1,47 @@
+/*
+ * Copyright (C) 2012 Google Inc. All rights reserved.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions
+ * are met:
+ *
+ * 1.  Redistributions of source code must retain the above copyright
+ * notice, this list of conditions and the following disclaimer.
+ * 2.  Redistributions in binary form must reproduce the above copyright
+ * notice, this list of conditions and the following disclaimer in the
+ * documentation and/or other materials provided with the distribution.
+ *
+ * THIS SOFTWARE IS PROVIDED BY APPLE AND ITS CONTRIBUTORS "AS IS" AND ANY
+ * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED
+ * WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
+ * DISCLAIMED. IN NO EVENT SHALL APPL

[webkit-changes] [128629] trunk/Source/WebCore

2012-09-14 Thread tkent

Title: [128629] trunk/Source/WebCore








Revision 128629
Author tk...@chromium.org
Date 2012-09-14 10:54:22 -0700 (Fri, 14 Sep 2012)


Log Message
Unreviewed, a workaround for a mysterious crash on Apple Windows port.
https://bugs.webkit.org/show_bug.cgi?id=96636

* testing/InternalSettings.cpp:
Touch RuntimeEnabledFeatures::langAttributeAwareFormControlUIEnabled only if
ENABLE(INPUT_TYPE_TIME_MULTIPLE_FIELDS)
(WebCore::InternalSettings::Backup::Backup):
(WebCore::InternalSettings::Backup::restoreTo):
(WebCore::InternalSettings::setLangAttributeAwareFormControlUIEnabled):
* testing/InternalSettings.h:
(Backup):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/testing/InternalSettings.cpp
trunk/Source/WebCore/testing/InternalSettings.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (128628 => 128629)

--- trunk/Source/WebCore/ChangeLog	2012-09-14 17:37:44 UTC (rev 128628)
+++ trunk/Source/WebCore/ChangeLog	2012-09-14 17:54:22 UTC (rev 128629)
@@ -1,3 +1,17 @@
+2012-09-14  Kent Tamura  
+
+Unreviewed, a workaround for a mysterious crash on Apple Windows port.
+https://bugs.webkit.org/show_bug.cgi?id=96636
+
+* testing/InternalSettings.cpp:
+Touch RuntimeEnabledFeatures::langAttributeAwareFormControlUIEnabled only if
+ENABLE(INPUT_TYPE_TIME_MULTIPLE_FIELDS)
+(WebCore::InternalSettings::Backup::Backup):
+(WebCore::InternalSettings::Backup::restoreTo):
+(WebCore::InternalSettings::setLangAttributeAwareFormControlUIEnabled):
+* testing/InternalSettings.h:
+(Backup):
+
 2012-09-14  David Grogan  
 
 IndexedDB: Print console warning about setVersion


Modified: trunk/Source/WebCore/testing/InternalSettings.cpp (128628 => 128629)

--- trunk/Source/WebCore/testing/InternalSettings.cpp	2012-09-14 17:37:44 UTC (rev 128628)
+++ trunk/Source/WebCore/testing/InternalSettings.cpp	2012-09-14 17:54:22 UTC (rev 128629)
@@ -98,7 +98,10 @@
 #endif
 , m_canStartMedia(page->canStartMedia())
 , m_originalMockScrollbarsEnabled(settings->mockScrollbarsEnabled())
+#if ENABLE(INPUT_TYPE_TIME_MULTIPLE_FIELDS)
+// FIXME: This is a workaround for Apple Windows crash.
 , m_langAttributeAwareFormControlUIEnabled(RuntimeEnabledFeatures::langAttributeAwareFormControlUIEnabled())
+#endif
 {
 }
 
@@ -132,7 +135,9 @@
 #endif
 page->setCanStartMedia(m_canStartMedia);
 settings->setMockScrollbarsEnabled(m_originalMockScrollbarsEnabled);
+#if ENABLE(INPUT_TYPE_TIME_MULTIPLE_FIELDS)
 RuntimeEnabledFeatures::setLangAttributeAwareFormControlUIEnabled(m_langAttributeAwareFormControlUIEnabled);
+#endif
 }
 
 InternalSettings* InternalSettings::from(Page* page)
@@ -648,7 +653,11 @@
 
 void InternalSettings::setLangAttributeAwareFormControlUIEnabled(bool enabled)
 {
+#if ENABLE(INPUT_TYPE_TIME_MULTIPLE_FIELDS)
 RuntimeEnabledFeatures::setLangAttributeAwareFormControlUIEnabled(enabled);
+#else
+UNUSED_PARAM(enabled);
+#endif
 }
 
 }


Modified: trunk/Source/WebCore/testing/InternalSettings.h (128628 => 128629)

--- trunk/Source/WebCore/testing/InternalSettings.h	2012-09-14 17:37:44 UTC (rev 128628)
+++ trunk/Source/WebCore/testing/InternalSettings.h	2012-09-14 17:54:22 UTC (rev 128629)
@@ -80,7 +80,9 @@
 #endif
 bool m_canStartMedia;
 bool m_originalMockScrollbarsEnabled;
+#if ENABLE(INPUT_TYPE_TIME_MULTIPLE_FIELDS)
 bool m_langAttributeAwareFormControlUIEnabled;
+#endif
 };
 
 typedef RefCountedSupplement SuperType;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [128628] trunk

2012-09-14 Thread peter

Title: [128628] trunk








Revision 128628
Author pe...@chromium.org
Date 2012-09-14 10:37:44 -0700 (Fri, 14 Sep 2012)


Log Message
[Chromium] Support the --{in,out,err}-fifo arguments on TestWebKitAPI and webkit_unit_tests
https://bugs.webkit.org/show_bug.cgi?id=96687

Reviewed by Tony Chang.

Android's DumpRenderTree currently supports these arguments, implemented
as part of TestShellAndroid:
http://trac.webkit.org/browser/trunk/Tools/DumpRenderTree/chromium/TestShellAndroid.cpp?rev=128496

They're used by the layout test runner to get the STDOUT and STDERR while
a layout test run is in process, which is a safer alternative to parsing
all the logcat output manually. The implementation can be seen here:
http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_android.py?rev=128496#L590

This patch generalizes parsing of and applying the effects of these arguments
so that they can be used for TestWebKitAPI and webkit_unit_tests as well.
After this patch, this will make it possible to pull out the output-reading
code from Android's layout test port and generalize it so it can be re-used
in the new test-runner for the other two test suites.

This has no effect when compiling and running these tests as part of Chromium
code, which has a much more advanced test-runner that does parse complete log
output, but also directly depends on code licensed under Apache 2.

Source/WebKit/chromium:

* WebKit.gypi:
* tests/ForwardIOStreamsAndroid.cpp: Added.
(WebKit):
(WebKit::maybeInitIOStreamForwardingForAndroid):
* tests/ForwardIOStreamsAndroid.h: Added.
(WebKit):
* tests/RunAllTests.cpp:
(main):

Tools:

* DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
* DumpRenderTree/chromium/TestShellAndroid.cpp:
(platformInit):
* TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp:

Modified Paths

trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/WebKitUnitTests.gyp
trunk/Source/WebKit/chromium/tests/RunAllTests.cpp
trunk/Tools/ChangeLog
trunk/Tools/DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp
trunk/Tools/DumpRenderTree/chromium/TestShellAndroid.cpp
trunk/Tools/TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp


Added Paths

trunk/Source/WebKit/chromium/tests/ForwardIOStreamsAndroid.cpp
trunk/Source/WebKit/chromium/tests/ForwardIOStreamsAndroid.h




Diff

Modified: trunk/Source/WebKit/chromium/ChangeLog (128627 => 128628)

--- trunk/Source/WebKit/chromium/ChangeLog	2012-09-14 17:28:11 UTC (rev 128627)
+++ trunk/Source/WebKit/chromium/ChangeLog	2012-09-14 17:37:44 UTC (rev 128628)
@@ -1,3 +1,38 @@
+2012-09-14  Peter Beverloo  
+
+[Chromium] Support the --{in,out,err}-fifo arguments on TestWebKitAPI and webkit_unit_tests
+https://bugs.webkit.org/show_bug.cgi?id=96687
+
+Reviewed by Tony Chang.
+
+Android's DumpRenderTree currently supports these arguments, implemented
+as part of TestShellAndroid:
+http://trac.webkit.org/browser/trunk/Tools/DumpRenderTree/chromium/TestShellAndroid.cpp?rev=128496
+
+They're used by the layout test runner to get the STDOUT and STDERR while
+a layout test run is in process, which is a safer alternative to parsing
+all the logcat output manually. The implementation can be seen here:
+http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_android.py?rev=128496#L590
+
+This patch generalizes parsing of and applying the effects of these arguments
+so that they can be used for TestWebKitAPI and webkit_unit_tests as well.
+After this patch, this will make it possible to pull out the output-reading
+code from Android's layout test port and generalize it so it can be re-used
+in the new test-runner for the other two test suites.
+
+This has no effect when compiling and running these tests as part of Chromium
+code, which has a much more advanced test-runner that does parse complete log
+output, but also directly depends on code licensed under Apache 2.
+
+* WebKit.gypi:
+* tests/ForwardIOStreamsAndroid.cpp: Added.
+(WebKit):
+(WebKit::maybeInitIOStreamForwardingForAndroid):
+* tests/ForwardIOStreamsAndroid.h: Added.
+(WebKit):
+* tests/RunAllTests.cpp:
+(main):
+
 2012-09-14  Keishi Hattori  
 
 Make time input lang attribute aware for testing


Modified: trunk/Source/WebKit/chromium/WebKitUnitTests.gyp (128627 => 128628)

--- trunk/Source/WebKit/chromium/WebKitUnitTests.gyp	2012-09-14 17:28:11 UTC (rev 128627)
+++ trunk/Source/WebKit/chromium/WebKitUnitTests.gyp	2012-09-14 17:37:44 UTC (rev 128628)
@@ -126,6 +126,7 @@
 'type': 'shared_library',
 'dependencies': [
 '<(chromium_src_dir)/testing/android/native_test.gyp:native_test_native_code',
+'io_stream_forwarder_android',
 ],
 }

[webkit-changes] [128625] trunk/Source/WebKit/blackberry

2012-09-14 Thread commit-queue

Title: [128625] trunk/Source/WebKit/blackberry








Revision 128625
Author commit-qu...@webkit.org
Date 2012-09-14 10:09:34 -0700 (Fri, 14 Sep 2012)


Log Message
Always send mouse events on pages that don't scroll even if there
is no mouse move listener attatched.
PR #208228
https://bugs.webkit.org/show_bug.cgi?id=96800

Patch by Genevieve Mak  on 2012-09-14
Reviewed by Antonio Gomes.

Reviewed Internally By Antonio Gomes.

* WebKitSupport/TouchEventHandler.cpp:
(BlackBerry::WebKit::TouchEventHandler::handleTouchPoint):

Modified Paths

trunk/Source/WebKit/blackberry/ChangeLog
trunk/Source/WebKit/blackberry/WebKitSupport/TouchEventHandler.cpp




Diff

Modified: trunk/Source/WebKit/blackberry/ChangeLog (128624 => 128625)

--- trunk/Source/WebKit/blackberry/ChangeLog	2012-09-14 17:05:32 UTC (rev 128624)
+++ trunk/Source/WebKit/blackberry/ChangeLog	2012-09-14 17:09:34 UTC (rev 128625)
@@ -1,3 +1,17 @@
+2012-09-14  Genevieve Mak  
+
+Always send mouse events on pages that don't scroll even if there
+is no mouse move listener attatched.
+PR #208228
+https://bugs.webkit.org/show_bug.cgi?id=96800
+
+Reviewed by Antonio Gomes.
+
+Reviewed Internally By Antonio Gomes.
+
+* WebKitSupport/TouchEventHandler.cpp:
+(BlackBerry::WebKit::TouchEventHandler::handleTouchPoint):
+
 2012-09-14  Mike Fenton  
 
 [BlackBerry] Update the minimum zoom scale when focusing an input field.


Modified: trunk/Source/WebKit/blackberry/WebKitSupport/TouchEventHandler.cpp (128624 => 128625)

--- trunk/Source/WebKit/blackberry/WebKitSupport/TouchEventHandler.cpp	2012-09-14 17:05:32 UTC (rev 128624)
+++ trunk/Source/WebKit/blackberry/WebKitSupport/TouchEventHandler.cpp	2012-09-14 17:09:34 UTC (rev 128625)
@@ -187,6 +187,7 @@
 // Enable input mode on any touch event.
 m_webPage->m_inputHandler->setInputModeEnabled();
 bool pureWithMouseConversion = m_webPage->m_touchEventMode == PureTouchEventsWithMouseConversion;
+bool alwaysEnableMouseConversion = pureWithMouseConversion || (!isMainFrameScrollable(m_webPage) && !m_webPage->m_inRegionScroller->d->isActive());
 
 switch (point.m_state) {
 case Platform::TouchPoint::TouchPressed:
@@ -208,7 +209,7 @@
 
 // Set or reset the touch mode.
 Element* possibleTargetNodeForMouseMoveEvents = static_cast(m_lastFatFingersResult.positionWasAdjusted() ? elementUnderFatFinger : m_lastFatFingersResult.node());
-m_convertTouchToMouse = pureWithMouseConversion ? true : shouldConvertTouchToMouse(possibleTargetNodeForMouseMoveEvents);
+m_convertTouchToMouse = alwaysEnableMouseConversion ? true : shouldConvertTouchToMouse(possibleTargetNodeForMouseMoveEvents);
 
 if (!possibleTargetNodeForMouseMoveEvents || (!possibleTargetNodeForMouseMoveEvents->hasEventListeners(eventNames().touchmoveEvent) && !m_convertTouchToMouse))
 m_webPage->client()->notifyNoMouseMoveOrTouchMoveHandlers();
@@ -274,9 +275,7 @@
 PlatformMouseEvent mouseEvent(point.m_pos, m_lastScreenPoint, PlatformEvent::MouseMoved, 1, LeftButton, TouchScreen);
 m_lastScreenPoint = point.m_screenPos;
 if (!m_webPage->handleMouseEvent(mouseEvent)) {
-// If the page is scrollable and the first event is not handled, ignore subsequent mouse moves.
-if (isMainFrameScrollable(m_webPage) || m_webPage->m_inRegionScroller->d->isActive() )
-m_convertTouchToMouse = pureWithMouseConversion;
+m_convertTouchToMouse = alwaysEnableMouseConversion;
 return false;
 }
 return true;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [128624] trunk/Tools

2012-09-14 Thread zoltan

Title: [128624] trunk/Tools








Revision 128624
Author zol...@webkit.org
Date 2012-09-14 10:05:32 -0700 (Fri, 14 Sep 2012)


Log Message
check-webkit-style should not warn in case of NONCOPYABLE and FAST_ALLOCATED macros
https://bugs.webkit.org/show_bug.cgi?id=96656

Reviewed by Adam Barth.

We should allow to use WTF_MAKE_NONCOPYABLE(ClassName) and WTF_MAKE_FAST_ALLOCATED
macros in 1 line.

* Scripts/webkitpy/style/checkers/cpp.py:
(check_style.definitions):
(check_style): Add rule.
* Scripts/webkitpy/style/checkers/cpp_unittest.py:
(WebKitStyleTest.test_line_breaking): Add unittest.

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/style/checkers/cpp.py
trunk/Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py




Diff

Modified: trunk/Tools/ChangeLog (128623 => 128624)

--- trunk/Tools/ChangeLog	2012-09-14 16:59:33 UTC (rev 128623)
+++ trunk/Tools/ChangeLog	2012-09-14 17:05:32 UTC (rev 128624)
@@ -1,3 +1,19 @@
+2012-09-14  Zoltan Horvath  
+
+check-webkit-style should not warn in case of NONCOPYABLE and FAST_ALLOCATED macros
+https://bugs.webkit.org/show_bug.cgi?id=96656
+
+Reviewed by Adam Barth.
+
+We should allow to use WTF_MAKE_NONCOPYABLE(ClassName) and WTF_MAKE_FAST_ALLOCATED
+macros in 1 line.
+
+* Scripts/webkitpy/style/checkers/cpp.py:
+(check_style.definitions):
+(check_style): Add rule.
+* Scripts/webkitpy/style/checkers/cpp_unittest.py:
+(WebKitStyleTest.test_line_breaking): Add unittest.
+
 2012-09-14  Christophe Dumez  
 
 WebKitTestRunner needs layoutTestController.dumpDatabaseCallbacks


Modified: trunk/Tools/Scripts/webkitpy/style/checkers/cpp.py (128623 => 128624)

--- trunk/Tools/Scripts/webkitpy/style/checkers/cpp.py	2012-09-14 16:59:33 UTC (rev 128623)
+++ trunk/Tools/Scripts/webkitpy/style/checkers/cpp.py	2012-09-14 17:05:32 UTC (rev 128624)
@@ -2567,7 +2567,10 @@
 and not (match(r'.*\(.*\).*{.*.}', line)
  and class_state.classinfo_stack
  and line.count('{') == line.count('}'))
-and not cleansed_line.startswith('#define ')):
+and not cleansed_line.startswith('#define ')
+# It's ok to use use WTF_MAKE_NONCOPYABLE and WTF_MAKE_FAST_ALLOCATED macros in 1 line
+and not (cleansed_line.find("WTF_MAKE_NONCOPYABLE") != -1
+ and cleansed_line.find("WTF_MAKE_FAST_ALLOCATED") != -1)):
 error(line_number, 'whitespace/newline', 4,
   'More than one command on the same line')
 


Modified: trunk/Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py (128623 => 128624)

--- trunk/Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py	2012-09-14 16:59:33 UTC (rev 128623)
+++ trunk/Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py	2012-09-14 17:05:32 UTC (rev 128624)
@@ -3861,6 +3861,9 @@
 # '#define TEST_ASSERT(_expression_) do { if (!(_expression_)) { TestsController::shared().testFailed(__FILE__, __LINE__, #_expression_); return; } } while (0 )\n',
 # 'Mismatching spaces inside () in if  [whitespace/parens] [5]')
 self.assert_multi_line_lint(
+'WTF_MAKE_NONCOPYABLE(ClassName); WTF_MAKE_FAST_ALLOCATED;\n',
+'')
+self.assert_multi_line_lint(
 'if (condition) {\n'
 'doSomething();\n'
 'doSomethingAgain();\n'






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [128623] trunk

2012-09-14 Thread commit-queue

Title: [128623] trunk








Revision 128623
Author commit-qu...@webkit.org
Date 2012-09-14 09:59:33 -0700 (Fri, 14 Sep 2012)


Log Message
WebKitTestRunner needs layoutTestController.dumpDatabaseCallbacks
https://bugs.webkit.org/show_bug.cgi?id=57570

Patch by Christophe Dumez  on 2012-09-14
Reviewed by Kenneth Rohde Christiansen.

Source/WebKit2:

Add new didExceedDatabaseQuota callback to WKBundlePageUIClient
and call it from WebChromeClient::exceededDatabaseQuota().
This is needed by WebKitTestRunner to dump information about
database callbacks.

* Shared/APIClientTraits.h:
* WebProcess/InjectedBundle/API/c/WKBundlePage.h:
* WebProcess/InjectedBundle/InjectedBundle.cpp:
(WebKit::InjectedBundle::setDatabaseQuota): Call WebDatabaseManager::setQuotaForOrigin()
with "file__0" instead of "file:///" as origin identifier. WebDatabaseManager expects
a database identifier, not a string representation of the security origin. "file__0" is
the string that is used as databaseIdentifier of local files. This bug was causing the
database quota not to be set. The test cases would therefore fail due to the quota being
0 instead of the value explicitly set.
* WebProcess/InjectedBundle/InjectedBundlePageUIClient.cpp:
(WebKit::InjectedBundlePageUIClient::didExceedDatabaseQuota):
(WebKit):
* WebProcess/InjectedBundle/InjectedBundlePageUIClient.h:
(InjectedBundlePageUIClient):
* WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::exceededDatabaseQuota):

Tools:

Implement testRunner.dumpDatabaseCallbacks in WebKitTestRunner
and dump the information expected by the test cases.

* WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
* WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
(WTR::InjectedBundle::beginTesting): Explicitly set the default
database quota.
* WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::securityOriginToStr): New convenience function to convert
a security origin to the string expected in test results.
(WTR):
(WTR::InjectedBundlePage::InjectedBundlePage):
(WTR::InjectedBundlePage::didExceedDatabaseQuota):
(WTR::InjectedBundlePage::didReachApplicationCacheOriginQuota): Minor
refactoring to share code with didExceedDatabaseQuota.
* WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
(InjectedBundlePage):
* WebKitTestRunner/InjectedBundle/TestRunner.cpp:
(WTR::TestRunner::TestRunner):
* WebKitTestRunner/InjectedBundle/TestRunner.h:
(WTR::TestRunner::dumpDatabaseCallbacks):
(WTR::TestRunner::shouldDumpDatabaseCallbacks):
(TestRunner):

LayoutTests:

Unskip several test cases which require implementation of
testRunner.dumpDatabaseCallbacks in WebKitTestRunner.

* platform/wk2/Skipped:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/wk2/Skipped
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/Shared/APIClientTraits.h
trunk/Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundlePage.h
trunk/Source/WebKit2/WebProcess/InjectedBundle/InjectedBundle.cpp
trunk/Source/WebKit2/WebProcess/InjectedBundle/InjectedBundlePageUIClient.cpp
trunk/Source/WebKit2/WebProcess/InjectedBundle/InjectedBundlePageUIClient.h
trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebChromeClient.cpp
trunk/Tools/ChangeLog
trunk/Tools/WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl
trunk/Tools/WebKitTestRunner/InjectedBundle/InjectedBundle.cpp
trunk/Tools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp
trunk/Tools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.h
trunk/Tools/WebKitTestRunner/InjectedBundle/TestRunner.cpp
trunk/Tools/WebKitTestRunner/InjectedBundle/TestRunner.h




Diff

Modified: trunk/LayoutTests/ChangeLog (128622 => 128623)

--- trunk/LayoutTests/ChangeLog	2012-09-14 16:58:59 UTC (rev 128622)
+++ trunk/LayoutTests/ChangeLog	2012-09-14 16:59:33 UTC (rev 128623)
@@ -1,3 +1,15 @@
+2012-09-14  Christophe Dumez  
+
+WebKitTestRunner needs layoutTestController.dumpDatabaseCallbacks
+https://bugs.webkit.org/show_bug.cgi?id=57570
+
+Reviewed by Kenneth Rohde Christiansen.
+
+Unskip several test cases which require implementation of
+testRunner.dumpDatabaseCallbacks in WebKitTestRunner.
+
+* platform/wk2/Skipped:
+
 2012-09-14  Sudarsana Nagineni  
 
 [EFL] Gardening of the WK2 Debug Bot failing tests


Modified: trunk/LayoutTests/platform/wk2/Skipped (128622 => 128623)

--- trunk/LayoutTests/platform/wk2/Skipped	2012-09-14 16:58:59 UTC (rev 128622)
+++ trunk/LayoutTests/platform/wk2/Skipped	2012-09-14 16:59:33 UTC (rev 128623)
@@ -288,11 +288,6 @@
 platform/mac/editing/deleting/deletionUI-minimum-size.html
 platform/mac/editing/deleting/deletionUI-successful-deletion.html
 
-# WebKitTestRunner needs layoutTestController.dumpDatabaseCallbacks
-# 
-storage/websql/open-database-creation-callback.html
-storage/websql/quota-tracking.html
-
 # WebKitTestRunner needs layoutTestController.setMockGeolocationPosition
 # and layoutTestController.setMockGeolocationError
 # 


Modified: trunk/Source/WebKit

[webkit-changes] [128622] trunk/Source/WebKit/blackberry

2012-09-14 Thread mifenton

Title: [128622] trunk/Source/WebKit/blackberry








Revision 128622
Author mifen...@rim.com
Date 2012-09-14 09:58:59 -0700 (Fri, 14 Sep 2012)


Log Message
[BlackBerry] Update the minimum zoom scale when focusing an input field.
https://bugs.webkit.org/show_bug.cgi?id=96789

Reviewed by Antonio Gomes.

PR 188751.

Increase the minimum font fix and base it on mm instead of pixels.

Reviewed Internally by Gen Mak.

* WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::InputHandler::ensureFocusTextElementVisible):

Modified Paths

trunk/Source/WebKit/blackberry/ChangeLog
trunk/Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp




Diff

Modified: trunk/Source/WebKit/blackberry/ChangeLog (128621 => 128622)

--- trunk/Source/WebKit/blackberry/ChangeLog	2012-09-14 16:55:35 UTC (rev 128621)
+++ trunk/Source/WebKit/blackberry/ChangeLog	2012-09-14 16:58:59 UTC (rev 128622)
@@ -1,3 +1,19 @@
+2012-09-14  Mike Fenton  
+
+[BlackBerry] Update the minimum zoom scale when focusing an input field.
+https://bugs.webkit.org/show_bug.cgi?id=96789
+
+Reviewed by Antonio Gomes.
+
+PR 188751.
+
+Increase the minimum font fix and base it on mm instead of pixels.
+
+Reviewed Internally by Gen Mak.
+
+* WebKitSupport/InputHandler.cpp:
+(BlackBerry::WebKit::InputHandler::ensureFocusTextElementVisible):
+
 2012-09-13  Antonio Gomes  
 
 [BlackBerry]  Remove the ability to schedule a zoom about point call.


Modified: trunk/Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp (128621 => 128622)

--- trunk/Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp	2012-09-14 16:55:35 UTC (rev 128621)
+++ trunk/Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp	2012-09-14 16:58:59 UTC (rev 128622)
@@ -66,6 +66,7 @@
 #include 
 #include 
 #include 
+#include 
 #include 
 #include 
 #include 
@@ -1158,9 +1159,10 @@
 }
 
 // If the text is too small, zoom in to make it a minimum size.
-static const int s_minimumTextHeightInPixels = 6;
+// The minimum size being defined as 3 mm is a good value based on my observations.
+static const int s_minimumTextHeightInPixels = Graphics::Screen::primaryScreen()->widthInMMToPixels(3);
 if (fontHeight && fontHeight < s_minimumTextHeightInPixels)
-m_webPage->zoomAboutPoint(s_minimumTextHeightInPixels / fontHeight, m_webPage->centerOfVisibleContentsRect());
+m_webPage->zoomAboutPoint(s_minimumTextHeightInPixels / fontHeight, selectionFocusRect.location());
 }
 
 void InputHandler::ensureFocusPluginElementVisible()






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [128621] trunk/LayoutTests

2012-09-14 Thread commit-queue

Title: [128621] trunk/LayoutTests








Revision 128621
Author commit-qu...@webkit.org
Date 2012-09-14 09:55:35 -0700 (Fri, 14 Sep 2012)


Log Message
[EFL] Gardening of the WK2 Debug Bot failing tests
https://bugs.webkit.org/show_bug.cgi?id=96795

Unreviewed EFL gardening.

Patch by Sudarsana Nagineni  on 2012-09-14

* platform/efl-wk2/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/efl-wk2/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (128620 => 128621)

--- trunk/LayoutTests/ChangeLog	2012-09-14 16:30:27 UTC (rev 128620)
+++ trunk/LayoutTests/ChangeLog	2012-09-14 16:55:35 UTC (rev 128621)
@@ -1,3 +1,12 @@
+2012-09-14  Sudarsana Nagineni  
+
+[EFL] Gardening of the WK2 Debug Bot failing tests
+https://bugs.webkit.org/show_bug.cgi?id=96795
+
+Unreviewed EFL gardening.
+
+* platform/efl-wk2/TestExpectations:
+
 2012-09-14  Sergio Villar Senin  
 
 [GTK] [WK2] Unreviewed gardening.


Modified: trunk/LayoutTests/platform/efl-wk2/TestExpectations (128620 => 128621)

--- trunk/LayoutTests/platform/efl-wk2/TestExpectations	2012-09-14 16:30:27 UTC (rev 128620)
+++ trunk/LayoutTests/platform/efl-wk2/TestExpectations	2012-09-14 16:55:35 UTC (rev 128621)
@@ -199,3 +199,9 @@
 BUGWKEFL : http/tests/inspector/network/network-sidebar-width.html = TEXT
 BUGWKEFL : inspector/extensions/extensions-panel.html = TEXT
 
+// New test introduced in r128462 fails.
+BUGWK96794 : fast/events/touch/touch-inside-iframe-scrolled.html = TEXT
+
+// Fails after r128056.
+BUGWk96792 : inspector/console/alert-toString-exception.html = TEXT
+






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [128620] trunk/LayoutTests

2012-09-14 Thread sergio

Title: [128620] trunk/LayoutTests








Revision 128620
Author ser...@webkit.org
Date 2012-09-14 09:30:27 -0700 (Fri, 14 Sep 2012)


Log Message
[GTK] [WK2] Unreviewed gardening.

Added a bunch of tests failing in the WK2 tests bot to the Skipped
list with the proper links to each bug.

* platform/gtk-wk2/Skipped:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/gtk-wk2/Skipped




Diff

Modified: trunk/LayoutTests/ChangeLog (128619 => 128620)

--- trunk/LayoutTests/ChangeLog	2012-09-14 16:27:59 UTC (rev 128619)
+++ trunk/LayoutTests/ChangeLog	2012-09-14 16:30:27 UTC (rev 128620)
@@ -1,3 +1,12 @@
+2012-09-14  Sergio Villar Senin  
+
+[GTK] [WK2] Unreviewed gardening.
+
+Added a bunch of tests failing in the WK2 tests bot to the Skipped
+list with the proper links to each bug.
+
+* platform/gtk-wk2/Skipped:
+
 2012-09-14  Rick Byers  
 
 Gesture events sent to wrong node when page is scrolled


Modified: trunk/LayoutTests/platform/gtk-wk2/Skipped (128619 => 128620)

--- trunk/LayoutTests/platform/gtk-wk2/Skipped	2012-09-14 16:27:59 UTC (rev 128619)
+++ trunk/LayoutTests/platform/gtk-wk2/Skipped	2012-09-14 16:30:27 UTC (rev 128620)
@@ -70,6 +70,11 @@
 fullscreen/full-screen-twice.html
 fullscreen/full-screen-remove.html
 fullscreen/full-screen-zIndex-after.html
+fullscreen/full-screen-element-stack.html
+fullscreen/full-screen-fixed-pos-parent.html
+fullscreen/full-screen-keyboard-enabled.html
+fullscreen/full-screen-restrictions.html
+fullscreen/non-ancestor-iframe.html
 
 animations/fill-mode-forwards.html
 editing/deleting/delete-by-word-001.html
@@ -83,6 +88,7 @@
 fast/forms/select-type-ahead-non-latin.html
 fast/forms/listbox-typeahead-cyrillic.html
 fast/forms/listbox-typeahead-greek.html
+fast/forms/legend-access-key.html
 http/tests/xmlhttprequest/workers/abort-exception-assert.html
 platform/gtk/fast/forms/menulist-typeahead-find.html
 plugins/document-open.html
@@ -405,11 +411,91 @@
 transitions/extra-transition.html
 transitions/interrupted-accelerated-transition.html
 
+# [Navigation Timing] Remove old-style LayoutTests
+# https://bugs.webkit.org/show_bug.cgi?id=91158
+fast/dom/navigation-type-back-forward.html
+fast/dom/navigation-type-navigate.html
+fast/dom/navigation-type-reload.html
+
+# https://bugs.webkit.org/show_bug.cgi?id=94549
+fast/forms/file/selected-files-from-history-state.html
+
+# https://bugs.webkit.org/show_bug.cgi?id=95043
+http/tests/security/local-user-CSS-from-remote.html
+
+# EventSender::dumpFilenameBeingDragged not implemented.
+# https://bugs.webkit.org/show_bug.cgi?id=61827
+fast/events/drag-image-filename.html
+
+# Assertion failure in replaySavedEvents
+# http://webkit.org/b/21796
+fast/forms/select-multiple-elements-with-mouse-drag-with-options-less-than-size.html
+
+# WebKitTestRunner layoutTestController.pathToLocalResource needs to be updated to work with NRWT
+# https://bugs.webkit.org/show_bug.cgi?id=81299
+fast/loader/local-CSS-from-local.html
+fast/loader/local-_javascript_-from-local.html
+fast/loader/local-image-from-local.html
+
+# WebKitTestRunner needs a more-complete implementation of eventSender
+# https://bugs.webkit.org/show_bug.cgi?id=42194
+editing/undo/undo-smart-delete-reversed-selection.html
+fast/dom/vertical-scrollbar-in-rtl.html
+fast/events/5056619.html
+http/tests/security/drag-drop-same-unique-origin.html
+svg/custom/polyline-hittest.svg
+
+# [Qt][GTK][WK2] New http/tests/cache/xhr-vary-header.html fails
+# https://bugs.webkit.org/show_bug.cgi?id=89278
+http/tests/cache/xhr-vary-header.html
+
+# [Qt][GTK] REGRESSION(r126194): http/tests/security/contentSecurityPolicy/register-bypassing-scheme.html fails
+# https://bugs.webkit.org/show_bug.cgi?id=94677
+http/tests/security/contentSecurityPolicy/register-bypassing-scheme.html
+
+# [Qt][WK2] New http/tests/security/cross-origin-plugin* tests fail
+# https://bugs.webkit.org/show_bug.cgi?id=95935
+http/tests/security/cross-origin-plugin-private-browsing-toggled.html
+http/tests/security/cross-origin-plugin.html
+
+# REGRESSION (r127202): http/tests/security/inactive-document-with-empty-security-origin.html failing on JSC ports
+# https://bugs.webkit.org/show_bug.cgi?id=95530
+http/tests/security/inactive-document-with-empty-security-origin.html
+
+# https://bugs.webkit.org/show_bug.cgi?id=82672
+http/tests/xmlhttprequest/range-test.html
+
+# https://bugs.webkit.org/show_bug.cgi?id=39160
+security/block-test-no-port.html
+
+# Some tests rely on a /tmp/LayoutTests symlink pointing to the LayoutTests directory
+# https://bugs.webkit.org/show_bug.cgi?id=64135
+fast/dom/frame-loading-via-document-write.html
+
+# media/audio-garbage-collect.html is flaky
+# https://bugs.webkit.org/show_bug.cgi?id=72698
+media/audio-garbage-collect.html
+
 ###
 # TESTS FAILING
 ###
 
-# Unchecked failures

[webkit-changes] [128619] trunk/Tools

2012-09-14 Thread vestbo

Title: [128619] trunk/Tools








Revision 128619
Author ves...@webkit.org
Date 2012-09-14 09:27:59 -0700 (Fri, 14 Sep 2012)


Log Message
[Qt] Set force_static_libs_as_shared early enough to be caught by configure

Rubber-stamped by Simon Hausmann.

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/qmake/mkspecs/features/default_post.prf




Diff

Modified: trunk/Tools/ChangeLog (128618 => 128619)

--- trunk/Tools/ChangeLog	2012-09-14 16:21:53 UTC (rev 128618)
+++ trunk/Tools/ChangeLog	2012-09-14 16:27:59 UTC (rev 128619)
@@ -1,5 +1,13 @@
 2012-09-14  Tor Arne Vestbø  
 
+[Qt] Set force_static_libs_as_shared early enough to be caught by configure
+
+Rubber-stamped by Simon Hausmann.
+
+* qmake/mkspecs/features/default_post.prf:
+
+2012-09-14  Tor Arne Vestbø  
+
 [Qt] Remove old cruft from the qmake build system
 
 Rubber-stamped by Simon Hausmann.


Modified: trunk/Tools/qmake/mkspecs/features/default_post.prf (128618 => 128619)

--- trunk/Tools/qmake/mkspecs/features/default_post.prf	2012-09-14 16:21:53 UTC (rev 128618)
+++ trunk/Tools/qmake/mkspecs/features/default_post.prf	2012-09-14 16:27:59 UTC (rev 128619)
@@ -10,6 +10,9 @@
 # or include() and a CONFIG += feature.
 CONFIG += config_step
 
+# Enable dynamic instead of static libraries for development
+!production_build:!buildbot:!win*: CONFIG += force_static_libs_as_shared
+
 root_project_file: finalizeConfigure()
 
 # Sanitize build config for single-configuration builds
@@ -65,9 +68,6 @@
 -Winit-self \
 $$QMAKE_CXXFLAGS
 
-# Enable dynamic instead of static libraries for development
-!production_build:!buildbot:!win*: CONFIG += force_static_libs_as_shared
-
 # Template configurations
 contains(TEMPLATE, derived) {
 # A (mostly) no-op template






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [128618] trunk

2012-09-14 Thread vestbo

Title: [128618] trunk








Revision 128618
Author ves...@webkit.org
Date 2012-09-14 09:21:53 -0700 (Fri, 14 Sep 2012)


Log Message
[Qt] Remove old cruft from the qmake build system

Rubber-stamped by Simon Hausmann.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/DerivedSources.pri
trunk/Source/WebCore/Target.pri
trunk/Tools/ChangeLog
trunk/Tools/DumpRenderTree/qt/DumpRenderTree.pro
trunk/Tools/qmake/mkspecs/features/default_post.prf




Diff

Modified: trunk/Source/WebCore/ChangeLog (128617 => 128618)

--- trunk/Source/WebCore/ChangeLog	2012-09-14 15:58:50 UTC (rev 128617)
+++ trunk/Source/WebCore/ChangeLog	2012-09-14 16:21:53 UTC (rev 128618)
@@ -1,5 +1,14 @@
 2012-09-14  Tor Arne Vestbø  
 
+[Qt] Remove old cruft from the qmake build system
+
+Rubber-stamped by Simon Hausmann.
+
+* DerivedSources.pri:
+* Target.pri:
+
+2012-09-14  Tor Arne Vestbø  
+
 [Qt] Make force_static_libs_as_shared work on Mac OS
 
 We had to move a few LIBS += around that were in the wrong place,


Modified: trunk/Source/WebCore/DerivedSources.pri (128617 => 128618)

--- trunk/Source/WebCore/DerivedSources.pri	2012-09-14 15:58:50 UTC (rev 128617)
+++ trunk/Source/WebCore/DerivedSources.pri	2012-09-14 16:21:53 UTC (rev 128618)
@@ -63,10 +63,6 @@
 
 INJECTED_SCRIPT_WEBGL_MODULE_SOURCE = $$PWD/inspector/InjectedScriptWebGLModuleSource.js
 
-DEBUGGER_SCRIPT_SOURCE = $$PWD/bindings/v8/DebuggerScript.js
-
-ARRAY_BUFFER_VIEW_CUSTOM_SCRIPT_SOURCE = $$PWD/bindings/v8/custom/V8ArrayBufferViewCustomScript.js
-
 XPATHBISON = $$PWD/xml/XPathGrammar.y
 
 enable?(SVG) {
@@ -805,19 +801,6 @@
 InjectedScriptWebGLModuleSource.add_output_to_sources = false
 GENERATORS += InjectedScriptWebGLModuleSource
 
-# GENERATOR 2-c: inspector debugger script source compiler
-debuggerScriptSource.output = DebuggerScriptSource.h
-debuggerScriptSource.input = DEBUGGER_SCRIPT_SOURCE
-debuggerScriptSource.commands = perl $$PWD/inspector/xxd.pl DebuggerScriptSource_js ${QMAKE_FILE_IN} ${QMAKE_FILE_OUT}
-debuggerScriptSource.add_output_to_sources = false
-GENERATORS += debuggerScriptSource
-
-arrayBufferViewCustomScript.output = V8ArrayBufferViewCustomScript.h
-arrayBufferViewCustomScript.input = ARRAY_BUFFER_VIEW_CUSTOM_SCRIPT_SOURCE
-arrayBufferViewCustomScript.commands = perl $$PWD/inspector/xxd.pl V8ArrayBufferViewCustomScript_js ${QMAKE_FILE_IN} ${QMAKE_FILE_OUT}
-arrayBufferViewCustomScript.add_output_to_sources = false
-GENERATORS += arrayBufferViewCustomScript
-
 # GENERATOR 4: CSS grammar
 cssbison.output = ${QMAKE_FILE_BASE}.cpp
 cssbison.input = CSSBISON


Modified: trunk/Source/WebCore/Target.pri (128617 => 128618)

--- trunk/Source/WebCore/Target.pri	2012-09-14 15:58:50 UTC (rev 128617)
+++ trunk/Source/WebCore/Target.pri	2012-09-14 16:21:53 UTC (rev 128618)
@@ -14,8 +14,6 @@
 
 CONFIG += staticlib
 
-DEFINES += QT_MAKEDLL
-
 RESOURCES += \
 $$PWD/WebCore.qrc
 


Modified: trunk/Tools/ChangeLog (128617 => 128618)

--- trunk/Tools/ChangeLog	2012-09-14 15:58:50 UTC (rev 128617)
+++ trunk/Tools/ChangeLog	2012-09-14 16:21:53 UTC (rev 128618)
@@ -1,5 +1,14 @@
 2012-09-14  Tor Arne Vestbø  
 
+[Qt] Remove old cruft from the qmake build system
+
+Rubber-stamped by Simon Hausmann.
+
+* DumpRenderTree/qt/DumpRenderTree.pro:
+* qmake/mkspecs/features/default_post.prf:
+
+2012-09-14  Tor Arne Vestbø  
+
 [Qt] Enable force_static_libs_as_shared for development
 
 Not enabled for buildbots or production-builds (part of Qt5)


Modified: trunk/Tools/DumpRenderTree/qt/DumpRenderTree.pro (128617 => 128618)

--- trunk/Tools/DumpRenderTree/qt/DumpRenderTree.pro	2012-09-14 15:58:50 UTC (rev 128617)
+++ trunk/Tools/DumpRenderTree/qt/DumpRenderTree.pro	2012-09-14 16:21:53 UTC (rev 128618)
@@ -9,8 +9,7 @@
 TARGET = DumpRenderTree
 DESTDIR = $$ROOT_BUILD_DIR/bin
 
-WEBKIT += wtf webcore
-!v8: WEBKIT += _javascript_core
+WEBKIT += wtf _javascript_core webcore
 
 INCLUDEPATH += \
 $$PWD/ \


Modified: trunk/Tools/qmake/mkspecs/features/default_post.prf (128617 => 128618)

--- trunk/Tools/qmake/mkspecs/features/default_post.prf	2012-09-14 15:58:50 UTC (rev 128617)
+++ trunk/Tools/qmake/mkspecs/features/default_post.prf	2012-09-14 16:21:53 UTC (rev 128618)
@@ -65,12 +65,6 @@
 -Winit-self \
 $$QMAKE_CXXFLAGS
 
-v8: DEFINES += WTF_USE_V8=1
-else {
-contains(_javascript_CORE_JIT, yes): DEFINES+=ENABLE_JIT=1
-contains(_javascript_CORE_JIT, no): DEFINES+=ENABLE_JIT=0
-}
-
 # Enable dynamic instead of static libraries for development
 !production_build:!buildbot:!win*: CONFIG += force_static_libs_as_shared
 
@@ -190,8 +184,7 @@
 # In addition to the main shared QtWebKit library we also
 # need to link to any intermediate shared libraries.
 force_static_libs_as_shared {
-WEBKIT += wtf webcore
-!v8: WEBKIT += _javascript_core
+WEBKIT += wtf _javascript_core webcore
 build?(webkit1): WEBKIT += webkit1

[webkit-changes] [128617] trunk/Tools

2012-09-14 Thread vestbo

Title: [128617] trunk/Tools








Revision 128617
Author ves...@webkit.org
Date 2012-09-14 08:58:50 -0700 (Fri, 14 Sep 2012)


Log Message
[Qt] Enable force_static_libs_as_shared for development

Not enabled for buildbots or production-builds (part of Qt5)

Reviewed by Simon Hausmann.

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/qmake/mkspecs/features/default_post.prf




Diff

Modified: trunk/Tools/ChangeLog (128616 => 128617)

--- trunk/Tools/ChangeLog	2012-09-14 15:58:28 UTC (rev 128616)
+++ trunk/Tools/ChangeLog	2012-09-14 15:58:50 UTC (rev 128617)
@@ -1,5 +1,15 @@
 2012-09-14  Tor Arne Vestbø  
 
+[Qt] Enable force_static_libs_as_shared for development
+
+Not enabled for buildbots or production-builds (part of Qt5)
+
+Reviewed by Simon Hausmann.
+
+* qmake/mkspecs/features/default_post.prf:
+
+2012-09-14  Tor Arne Vestbø  
+
 [Qt] Make force_static_libs_as_shared work on Mac OS
 
 We had to move a few LIBS += around that were in the wrong place,


Modified: trunk/Tools/qmake/mkspecs/features/default_post.prf (128616 => 128617)

--- trunk/Tools/qmake/mkspecs/features/default_post.prf	2012-09-14 15:58:28 UTC (rev 128616)
+++ trunk/Tools/qmake/mkspecs/features/default_post.prf	2012-09-14 15:58:50 UTC (rev 128617)
@@ -71,6 +71,9 @@
 contains(_javascript_CORE_JIT, no): DEFINES+=ENABLE_JIT=0
 }
 
+# Enable dynamic instead of static libraries for development
+!production_build:!buildbot:!win*: CONFIG += force_static_libs_as_shared
+
 # Template configurations
 contains(TEMPLATE, derived) {
 # A (mostly) no-op template






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [128616] trunk

2012-09-14 Thread vestbo

Title: [128616] trunk








Revision 128616
Author ves...@webkit.org
Date 2012-09-14 08:58:28 -0700 (Fri, 14 Sep 2012)


Log Message
[Qt] Make force_static_libs_as_shared work on Mac OS

We had to move a few LIBS += around that were in the wrong place,
and not caught when everything was just linked into the final
QtWebKit library.

Reviewed by Simon Hausmann.

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/jsc.pro
trunk/Source/WTF/ChangeLog
trunk/Source/WTF/WTF.pri
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/WebCore.pri
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/WebKit1.pri
trunk/Tools/ChangeLog
trunk/Tools/qmake/mkspecs/features/default_post.prf
trunk/Tools/qmake/mkspecs/features/force_static_libs_as_shared.prf




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (128615 => 128616)

--- trunk/Source/_javascript_Core/ChangeLog	2012-09-14 15:55:08 UTC (rev 128615)
+++ trunk/Source/_javascript_Core/ChangeLog	2012-09-14 15:58:28 UTC (rev 128616)
@@ -1,3 +1,15 @@
+2012-09-14  Tor Arne Vestbø  
+
+[Qt] Make force_static_libs_as_shared work on Mac OS
+
+We had to move a few LIBS += around that were in the wrong place,
+and not caught when everything was just linked into the final
+QtWebKit library.
+
+Reviewed by Simon Hausmann.
+
+* jsc.pro: No need for AppKit, we get it from WTF.pri
+
 2012-09-14  Kevin Funk  
 
 Fix interpreter build


Modified: trunk/Source/_javascript_Core/jsc.pro (128615 => 128616)

--- trunk/Source/_javascript_Core/jsc.pro	2012-09-14 15:55:08 UTC (rev 128615)
+++ trunk/Source/_javascript_Core/jsc.pro	2012-09-14 15:58:28 UTC (rev 128616)
@@ -19,10 +19,6 @@
 
 SOURCES = jsc.cpp
 
-mac {
-LIBS_PRIVATE += -framework AppKit
-}
-
 win32-* {
 LIBS += -ladvapi32
 }


Modified: trunk/Source/WTF/ChangeLog (128615 => 128616)

--- trunk/Source/WTF/ChangeLog	2012-09-14 15:55:08 UTC (rev 128615)
+++ trunk/Source/WTF/ChangeLog	2012-09-14 15:58:28 UTC (rev 128616)
@@ -1,3 +1,15 @@
+2012-09-14  Tor Arne Vestbø  
+
+[Qt] Make force_static_libs_as_shared work on Mac OS
+
+We had to move a few LIBS += around that were in the wrong place,
+and not caught when everything was just linked into the final
+QtWebKit library.
+
+Reviewed by Simon Hausmann.
+
+* WTF.pri:
+
 2012-09-14  Ilya Tikhonovsky  
 
 Web Inspector: NMI: convert template versions of String*::reportMemoryUsage functions to normal functions.


Modified: trunk/Source/WTF/WTF.pri (128615 => 128616)

--- trunk/Source/WTF/WTF.pri	2012-09-14 15:55:08 UTC (rev 128615)
+++ trunk/Source/WTF/WTF.pri	2012-09-14 15:58:28 UTC (rev 128616)
@@ -36,3 +36,7 @@
 # required for timegm
 LIBS += -lnbutil
 }
+
+mac {
+LIBS += -framework AppKit
+}


Modified: trunk/Source/WebCore/ChangeLog (128615 => 128616)

--- trunk/Source/WebCore/ChangeLog	2012-09-14 15:55:08 UTC (rev 128615)
+++ trunk/Source/WebCore/ChangeLog	2012-09-14 15:58:28 UTC (rev 128616)
@@ -1,3 +1,15 @@
+2012-09-14  Tor Arne Vestbø  
+
+[Qt] Make force_static_libs_as_shared work on Mac OS
+
+We had to move a few LIBS += around that were in the wrong place,
+and not caught when everything was just linked into the final
+QtWebKit library.
+
+Reviewed by Simon Hausmann.
+
+* WebCore.pri:
+
 2012-09-14  Rick Byers  
 
 Gesture events sent to wrong node when page is scrolled


Modified: trunk/Source/WebCore/WebCore.pri (128615 => 128616)

--- trunk/Source/WebCore/WebCore.pri	2012-09-14 15:55:08 UTC (rev 128615)
+++ trunk/Source/WebCore/WebCore.pri	2012-09-14 15:58:28 UTC (rev 128616)
@@ -176,8 +176,21 @@
 
 LIBS += -framework AppKit -framework AudioUnit \
 -framework AudioToolbox -framework CoreAudio \
--framework QuartzCore -framework QTKit
+-framework QuartzCore -framework QTKit \
+-framework Security -framework IOKit
 
+# We can know the Mac OS version by using the Darwin major version
+DARWIN_VERSION = $$split(QMAKE_HOST.version, ".")
+DARWIN_MAJOR_VERSION = $$first(DARWIN_VERSION)
+equals(DARWIN_MAJOR_VERSION, "12") {
+LIBS += $${ROOT_WEBKIT_DIR}/WebKitLibraries/libWebKitSystemInterfaceMountainLion.a
+} else:equals(DARWIN_MAJOR_VERSION, "11") {
+LIBS += $${ROOT_WEBKIT_DIR}/WebKitLibraries/libWebKitSystemInterfaceLion.a
+} else:equals(DARWIN_MAJOR_VERSION, "10") {
+LIBS += $${ROOT_WEBKIT_DIR}/WebKitLibraries/libWebKitSystemInterfaceSnowLeopard.a
+} else:equals(DARWIN_MAJOR_VERSION, "9") {
+LIBS += $${ROOT_WEBKIT_DIR}/WebKitLibraries/libWebKitSystemInterfaceLeopard.a
+}
 } else:use?(GSTREAMER) {
 INCLUDEPATH += $$SOURCE_DIR/platform/graphics/gstreamer
 PKGCONFIG += gstreamer-video-0.10
@@ -217,7 +230,7 @@
 use?(webp): LIBS += -lwebp
 
 mac {
-LIBS += -fram

[webkit-changes] [128615] trunk

2012-09-14 Thread commit-queue

Title: [128615] trunk








Revision 128615
Author commit-qu...@webkit.org
Date 2012-09-14 08:55:08 -0700 (Fri, 14 Sep 2012)


Log Message
Gesture events sent to wrong node when page is scrolled
https://bugs.webkit.org/show_bug.cgi?id=96788

Patch by Rick Byers  on 2012-09-14
Reviewed by Antonio Gomes.

Source/WebCore:

Adjust the co-ordinate space correctly when doing hit testing for
gesture events (as for all other event handling code here).

Test: platform/chromium/plugins/gesture-events-scrolled.html

* page/EventHandler.cpp:
(WebCore::EventHandler::handleGestureEvent):

LayoutTests:

Add layout test based on gesture-events.html which tests the case when
the document is scrolled (so that client co-ordinates don't equal page
co-ordinates).
* platform/chromium/plugins/gesture-events-scrolled-expected.txt: Added.
* platform/chromium/plugins/gesture-events-scrolled.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/EventHandler.cpp


Added Paths

trunk/LayoutTests/platform/chromium/plugins/gesture-events-scrolled-expected.txt
trunk/LayoutTests/platform/chromium/plugins/gesture-events-scrolled.html




Diff

Modified: trunk/LayoutTests/ChangeLog (128614 => 128615)

--- trunk/LayoutTests/ChangeLog	2012-09-14 15:47:15 UTC (rev 128614)
+++ trunk/LayoutTests/ChangeLog	2012-09-14 15:55:08 UTC (rev 128615)
@@ -1,3 +1,16 @@
+2012-09-14  Rick Byers  
+
+Gesture events sent to wrong node when page is scrolled
+https://bugs.webkit.org/show_bug.cgi?id=96788
+
+Reviewed by Antonio Gomes.
+
+Add layout test based on gesture-events.html which tests the case when
+the document is scrolled (so that client co-ordinates don't equal page
+co-ordinates).
+* platform/chromium/plugins/gesture-events-scrolled-expected.txt: Added.
+* platform/chromium/plugins/gesture-events-scrolled.html: Added.
+
 2012-09-14  Sudarsana Nagineni  
 
 [EFL][WK2] Unskip test cases that are now passing


Added: trunk/LayoutTests/platform/chromium/plugins/gesture-events-scrolled-expected.txt (0 => 128615)

--- trunk/LayoutTests/platform/chromium/plugins/gesture-events-scrolled-expected.txt	(rev 0)
+++ trunk/LayoutTests/platform/chromium/plugins/gesture-events-scrolled-expected.txt	2012-09-14 15:55:08 UTC (rev 128615)
@@ -0,0 +1,10 @@
+Plugin received event: GestureTap
+Plugin received event: MouseEnter
+Plugin received event: MouseMove
+Plugin received event: MouseDown
+Plugin received event: MouseUp
+Plugin received event: GestureScrollBegin
+Plugin received event: GestureScrollUpdate
+Plugin received event: MouseWheel
+Plugin received event: GestureScrollEnd
+


Added: trunk/LayoutTests/platform/chromium/plugins/gesture-events-scrolled.html (0 => 128615)

--- trunk/LayoutTests/platform/chromium/plugins/gesture-events-scrolled.html	(rev 0)
+++ trunk/LayoutTests/platform/chromium/plugins/gesture-events-scrolled.html	2012-09-14 15:55:08 UTC (rev 128615)
@@ -0,0 +1,43 @@
+
+
+
+  body {
+height: 2000px;
+  }
+  #plugin {
+position: absolute;
+top: 500px;
+width: 150px;
+height: 150px;
+  }
+
+
+
+
+
+
+
+if (!window.testRunner) {
+document.write("This test does not work in manual mode.");
+} else {
+testRunner.dumpAsText();
+
+// Scroll so the plugin is 100px down the page
+window.scroll(0, 400);
+
+// These events should not reach the plugin since it's futher down on the page.
+eventSender.gestureTapDown(30, 30);
+eventSender.gestureTapDown(30, 530);
+
+// Send some gesture events to the plugin.
+var positionX = 30;
+var positionY = 110;
+eventSender.gestureTap(positionX, positionY);
+eventSender.gestureScrollBegin(positionX, positionY);
+eventSender.gestureScrollUpdate(30, 0);
+eventSender.gestureScrollEnd(0, 0);
+}
+
+
+
+


Modified: trunk/Source/WebCore/ChangeLog (128614 => 128615)

--- trunk/Source/WebCore/ChangeLog	2012-09-14 15:47:15 UTC (rev 128614)
+++ trunk/Source/WebCore/ChangeLog	2012-09-14 15:55:08 UTC (rev 128615)
@@ -1,3 +1,18 @@
+2012-09-14  Rick Byers  
+
+Gesture events sent to wrong node when page is scrolled
+https://bugs.webkit.org/show_bug.cgi?id=96788
+
+Reviewed by Antonio Gomes.
+
+Adjust the co-ordinate space correctly when doing hit testing for
+gesture events (as for all other event handling code here).
+
+Test: platform/chromium/plugins/gesture-events-scrolled.html
+
+* page/EventHandler.cpp:
+(WebCore::EventHandler::handleGestureEvent):
+
 2012-09-14  Mikhail Pozdnyakov  
 
 [EFL] Attempt to create a theme for 0 sized element leads to assertion hit


Modified: trunk/Source/WebCore/page/EventHandler.cpp (128614 => 128615)

--- trunk/Source/WebCore/page/EventHandler.cpp	2012-09-14 15:47:15 UTC (rev 128614)
+++ trunk/Source/WebCore

[webkit-changes] [128614] trunk/Tools

2012-09-14 Thread hausmann

Title: [128614] trunk/Tools








Revision 128614
Author hausm...@webkit.org
Date 2012-09-14 08:47:15 -0700 (Fri, 14 Sep 2012)


Log Message
[Qt] Fix handling of debug/release/debug_and_release/build_all

We now pick up the defaults from Qt, in default_pre (CONFIG already
contains the appropriate values for debug and release). We then let
the command line arguments to qmake, or the project files themselves,
override the configuration, and finally we sanitize the configuration
in default_post.

Patch by Tor Arne Vestbø  on 2012-09-14
Reviewed by Simon Hausmann.

* Source/api.pri:

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/WebKitTestRunner/Target.pri




Diff

Modified: trunk/Tools/ChangeLog (128613 => 128614)

--- trunk/Tools/ChangeLog	2012-09-14 15:38:41 UTC (rev 128613)
+++ trunk/Tools/ChangeLog	2012-09-14 15:47:15 UTC (rev 128614)
@@ -1,3 +1,17 @@
+2012-09-14  Simon Hausmann  
+
+[Qt] Fix build of WTR on Windows
+
+Reviewed by Tor Arne Vestbø.
+
+WTR/qt/main.cpp includes TestController.h, which lives in just WTR/
+With qmake's unix makefile generator as well as with the MingW generator,
+the directory where the pro file lives (WTR/) is automatically added to
+the include search path, but not so with MSVC. Instead of relying on qmake's
+implicit feature here, add WTR/ explicitly to the include search path.
+
+* WebKitTestRunner/Target.pri:
+
 2012-09-14  Christophe Dumez  
 
 WebKitTestRunner needs layoutTestController.setStopProvisionalFrameLoads


Modified: trunk/Tools/WebKitTestRunner/Target.pri (128613 => 128614)

--- trunk/Tools/WebKitTestRunner/Target.pri	2012-09-14 15:38:41 UTC (rev 128613)
+++ trunk/Tools/WebKitTestRunner/Target.pri	2012-09-14 15:47:15 UTC (rev 128614)
@@ -38,6 +38,7 @@
 have?(FONTCONFIG): PKGCONFIG += fontconfig
 
 INCLUDEPATH += \
+$$PWD \
 $${ROOT_WEBKIT_DIR}/Tools/DumpRenderTree/qt
 
 PREFIX_HEADER = WebKitTestRunnerPrefix.h






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [128613] trunk/LayoutTests

2012-09-14 Thread commit-queue

Title: [128613] trunk/LayoutTests








Revision 128613
Author commit-qu...@webkit.org
Date 2012-09-14 08:38:41 -0700 (Fri, 14 Sep 2012)


Log Message
[EFL][WK2] Unskip test cases that are now passing
https://bugs.webkit.org/show_bug.cgi?id=96762

Unreviewed EFL gardening, unskip now passing tests.

Patch by Sudarsana Nagineni  on 2012-09-14

* platform/efl-wk2/TestExpectations:
* platform/efl/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/efl/TestExpectations
trunk/LayoutTests/platform/efl-wk2/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (128612 => 128613)

--- trunk/LayoutTests/ChangeLog	2012-09-14 15:18:40 UTC (rev 128612)
+++ trunk/LayoutTests/ChangeLog	2012-09-14 15:38:41 UTC (rev 128613)
@@ -1,3 +1,13 @@
+2012-09-14  Sudarsana Nagineni  
+
+[EFL][WK2] Unskip test cases that are now passing
+https://bugs.webkit.org/show_bug.cgi?id=96762
+
+Unreviewed EFL gardening, unskip now passing tests.
+
+* platform/efl-wk2/TestExpectations:
+* platform/efl/TestExpectations:
+
 2012-09-14  Christophe Dumez  
 
 WebKitTestRunner needs layoutTestController.setStopProvisionalFrameLoads


Modified: trunk/LayoutTests/platform/efl/TestExpectations (128612 => 128613)

--- trunk/LayoutTests/platform/efl/TestExpectations	2012-09-14 15:18:40 UTC (rev 128612)
+++ trunk/LayoutTests/platform/efl/TestExpectations	2012-09-14 15:38:41 UTC (rev 128613)
@@ -175,7 +175,6 @@
 // FLAKY TESTS
 //
 
-BUGWK93654 : fast/events/keyevent-iframe-removed-crash.html = CRASH TEXT
 BUGWK85603 : fast/forms/textarea-placeholder-set-attribute.html = TEXT IMAGE PASS
 BUGWK59801 : fast/workers/storage/use-same-database-in-page-and-workers.html = TEXT PASS
 BUGWK83878 : media/track/track-mode.html = TEXT PASS


Modified: trunk/LayoutTests/platform/efl-wk2/TestExpectations (128612 => 128613)

--- trunk/LayoutTests/platform/efl-wk2/TestExpectations	2012-09-14 15:18:40 UTC (rev 128612)
+++ trunk/LayoutTests/platform/efl-wk2/TestExpectations	2012-09-14 15:38:41 UTC (rev 128613)
@@ -30,11 +30,8 @@
 // CRASHES
 //
 
-BUGWKEFL : inspector/debugger/debugger-eval-on-call-frame.html = CRASH
-BUGWKEFL : fast/overflow/lots-of-sibling-inline-boxes.html = CRASH
 BUGWKEFL : fast/dom/register-protocol-handler.html = CRASH
 BUGWKEFL : fast/dom/unregister-protocol-handler.html = CRASH
-BUGWK95333 DEBUG : fast/forms/color/input-value-sanitization-color.html = CRASH
 
 // WebKitTestRunner needs an implementation for download attribute feature
 // The implementation for DumpRenderTree is on https://bugs.webkit.org/show_bug.cgi?id=96462
@@ -166,10 +163,8 @@
 BUGWKEFL : fast/events/touch/send-oncancel-event.html = TEXT
 BUGWKEFL : fast/events/touch/tap-highlight-color.html = TEXT
 BUGWKEFL : fast/events/touch/touch-active-state.html = TEXT
-BUGWKEFL : fast/events/touch/touch-before-pressing-spin-button.html = TEXT
 BUGWKEFL : fast/events/touch/touch-coords-in-zoom-and-scroll.html = TEXT
 BUGWKEFL : fast/events/touch/touch-inside-iframe.html = TEXT
-BUGWKEFL : fast/events/touch/touch-slider-no-js-touch-listener.html = TEXT
 BUGWKEFL : fast/events/touch/touch-slider.html = TEXT
 BUGWKEFL : fast/events/touch/touch-stale-node-crash.html = TEXT
 BUGWKEFL : fast/events/touch/touch-target-limited.html = TEXT
@@ -201,11 +196,6 @@
 BUGWKEFL : fast/frames/flattening/iframe-tiny.html = TEXT
 BUGWKEFL : fast/replaced/no-focus-ring-embed.html = TEXT
 BUGWKEFL : fast/replaced/no-focus-ring-object.html = TEXT
-BUGWKEFL : fast/workers/worker-cloneport.html = TEXT
 BUGWKEFL : http/tests/inspector/network/network-sidebar-width.html = TEXT
-BUGWKEFL : http/tests/xmlhttprequest/workers/abort-exception-assert.html = TEXT
-BUGWKEFL : inspector/debugger/debugger-completions-on-call-frame.html = TEXT
 BUGWKEFL : inspector/extensions/extensions-panel.html = TEXT
-BUGWKEFL : inspector/extensions/extensions-sidebar.html = TEXT
-BUGWKEFL : jquery/attributes.html = TEXT
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [128612] trunk

2012-09-14 Thread commit-queue

Title: [128612] trunk








Revision 128612
Author commit-qu...@webkit.org
Date 2012-09-14 08:18:40 -0700 (Fri, 14 Sep 2012)


Log Message
WebKitTestRunner needs layoutTestController.setStopProvisionalFrameLoads
https://bugs.webkit.org/show_bug.cgi?id=42691

Patch by Christophe Dumez  on 2012-09-14
Reviewed by Kenneth Rohde Christiansen.

Source/WebKit2:

Add WKBundleFrame private API to stop loading of a frame.
This is needed by WebKitTestRunner to implement
testrunner.setStopProvisionalFrameLoads.

Original patch by Alexey Proskuryakov.

* WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp:
(WKBundleFrameStopLoading):
* WebProcess/InjectedBundle/API/c/WKBundleFramePrivate.h:
* WebProcess/WebPage/WebFrame.cpp:
(WebKit::WebFrame::stopLoading):
(WebKit):
* WebProcess/WebPage/WebFrame.h:
(WebFrame):

Tools:

Add implementation for testrunner.setStopProvisionalFrameLoads()
in WebKitTestRunner.

Original patch by Alexey Proskuryakov.

* WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
* WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::InjectedBundlePage::didStartProvisionalLoadForFrame):
* WebKitTestRunner/InjectedBundle/TestRunner.cpp:
(WTR::TestRunner::TestRunner):
* WebKitTestRunner/InjectedBundle/TestRunner.h:
(TestRunner):
(WTR::TestRunner::setStopProvisionalFrameLoads):
(WTR::TestRunner::shouldStopProvisionalFrameLoads):

LayoutTests:

Unskip fast/loader/stop-provisional-loads.html now that WebKitTestRunner
implements testrunner.setStopProvisionalFrameLoads().

* platform/wk2/Skipped:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/wk2/Skipped
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp
trunk/Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundleFramePrivate.h
trunk/Source/WebKit2/WebProcess/WebPage/WebFrame.cpp
trunk/Source/WebKit2/WebProcess/WebPage/WebFrame.h
trunk/Tools/ChangeLog
trunk/Tools/WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl
trunk/Tools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp
trunk/Tools/WebKitTestRunner/InjectedBundle/TestRunner.cpp
trunk/Tools/WebKitTestRunner/InjectedBundle/TestRunner.h




Diff

Modified: trunk/LayoutTests/ChangeLog (128611 => 128612)

--- trunk/LayoutTests/ChangeLog	2012-09-14 14:55:11 UTC (rev 128611)
+++ trunk/LayoutTests/ChangeLog	2012-09-14 15:18:40 UTC (rev 128612)
@@ -1,3 +1,15 @@
+2012-09-14  Christophe Dumez  
+
+WebKitTestRunner needs layoutTestController.setStopProvisionalFrameLoads
+https://bugs.webkit.org/show_bug.cgi?id=42691
+
+Reviewed by Kenneth Rohde Christiansen.
+
+Unskip fast/loader/stop-provisional-loads.html now that WebKitTestRunner
+implements testrunner.setStopProvisionalFrameLoads().
+
+* platform/wk2/Skipped:
+
 2012-09-14  Mikhail Pozdnyakov  
 
 [EFL] Attempt to create a theme for 0 sized element leads to assertion hit


Modified: trunk/LayoutTests/platform/wk2/Skipped (128611 => 128612)

--- trunk/LayoutTests/platform/wk2/Skipped	2012-09-14 14:55:11 UTC (rev 128611)
+++ trunk/LayoutTests/platform/wk2/Skipped	2012-09-14 15:18:40 UTC (rev 128612)
@@ -428,10 +428,6 @@
 # 
 fast/events/show-modal-dialog-onblur-onfocus.html
 
-# WebKitTestRunner needs layoutTestController.setStopProvisionalFrameLoads
-# 
-fast/loader/stop-provisional-loads.html
-
 # WebKitTestRunner needs layoutTestController.setPrinting
 # 
 printing/compositing-layer-printing.html


Modified: trunk/Source/WebKit2/ChangeLog (128611 => 128612)

--- trunk/Source/WebKit2/ChangeLog	2012-09-14 14:55:11 UTC (rev 128611)
+++ trunk/Source/WebKit2/ChangeLog	2012-09-14 15:18:40 UTC (rev 128612)
@@ -1,3 +1,25 @@
+2012-09-14  Christophe Dumez  
+
+WebKitTestRunner needs layoutTestController.setStopProvisionalFrameLoads
+https://bugs.webkit.org/show_bug.cgi?id=42691
+
+Reviewed by Kenneth Rohde Christiansen.
+
+Add WKBundleFrame private API to stop loading of a frame.
+This is needed by WebKitTestRunner to implement
+testrunner.setStopProvisionalFrameLoads.
+
+Original patch by Alexey Proskuryakov.
+
+* WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp:
+(WKBundleFrameStopLoading):
+* WebProcess/InjectedBundle/API/c/WKBundleFramePrivate.h:
+* WebProcess/WebPage/WebFrame.cpp:
+(WebKit::WebFrame::stopLoading):
+(WebKit):
+* WebProcess/WebPage/WebFrame.h:
+(WebFrame):
+
 2012-09-14  Kenneth Rohde Christiansen  
 
 [EFL] Add unit test for RefPtr


Modified: trunk/Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp (128611 => 128612)

--- trunk/Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp	2012-09-14 14:55:11 UTC (rev 128611)
+++ trunk/Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp	2012-09-14 15:18:40 UTC (rev 128612)
@@ -182,6 +182,11 @@
 coreFrame->loader()->setOpener(0);
 }
 
+void WKBundleFrameStopLoading(WKBundleFrameRef f

[webkit-changes] [128611] trunk/Source/JavaScriptCore

2012-09-14 Thread hausmann

Title: [128611] trunk/Source/_javascript_Core








Revision 128611
Author hausm...@webkit.org
Date 2012-09-14 07:55:11 -0700 (Fri, 14 Sep 2012)


Log Message
Fix interpreter build
https://bugs.webkit.org/show_bug.cgi?id=96617

Patch by Kevin Funk  on 2012-09-14
Reviewed by Simon Hausmann.

Make compile.

* interpreter/Interpreter.cpp:

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/interpreter/Interpreter.cpp




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (128610 => 128611)

--- trunk/Source/_javascript_Core/ChangeLog	2012-09-14 14:30:58 UTC (rev 128610)
+++ trunk/Source/_javascript_Core/ChangeLog	2012-09-14 14:55:11 UTC (rev 128611)
@@ -1,3 +1,14 @@
+2012-09-14  Kevin Funk  
+
+Fix interpreter build
+https://bugs.webkit.org/show_bug.cgi?id=96617
+
+Reviewed by Simon Hausmann.
+
+Make compile.
+
+* interpreter/Interpreter.cpp:
+
 2012-09-14  Parth Patel  
 
 [BlackBerry] Switching from Slogger to Slogger2 requires changes in CMakeList of 


Modified: trunk/Source/_javascript_Core/interpreter/Interpreter.cpp (128610 => 128611)

--- trunk/Source/_javascript_Core/interpreter/Interpreter.cpp	2012-09-14 14:30:58 UTC (rev 128610)
+++ trunk/Source/_javascript_Core/interpreter/Interpreter.cpp	2012-09-14 14:55:11 UTC (rev 128611)
@@ -3610,8 +3610,8 @@
 uint32_t i = subscript.asUInt32();
 if (isJSArray(baseValue)) {
 JSArray* jsArray = asArray(baseValue);
-if (jsArray->canGetIndex(i))
-result = jsArray->getIndex(i);
+if (jsArray->canGetIndexQuickly(i))
+result = jsArray->getIndexQuickly(i);
 else
 result = jsArray->JSArray::get(callFrame, i);
 } else if (isJSString(baseValue) && asString(baseValue)->canGetIndex(i))
@@ -3652,8 +3652,8 @@
 uint32_t i = subscript.asUInt32();
 if (isJSArray(baseValue)) {
 JSArray* jsArray = asArray(baseValue);
-if (jsArray->canSetIndex(i))
-jsArray->setIndex(*globalData, i, callFrame->r(value).jsValue());
+if (jsArray->canSetIndexQuickly(i))
+jsArray->setIndexQuickly(*globalData, i, callFrame->r(value).jsValue());
 else
 jsArray->JSArray::putByIndex(jsArray, callFrame, i, callFrame->r(value).jsValue(), codeBlock->isStrictMode());
 } else
@@ -5012,7 +5012,7 @@
 accessor->setGetter(callFrame->globalData(), asObject(getter));
 if (!setter.isUndefined())
 accessor->setSetter(callFrame->globalData(), asObject(setter));
-baseObj->putDirectAccessor(callFrame->globalData(), ident, accessor, Accessor);
+baseObj->putDirectAccessor(callFrame, ident, accessor, Accessor);
 
 vPC += OPCODE_LENGTH(op_put_getter_setter);
 NEXT_INSTRUCTION();






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [128610] trunk/Source/WebKit2

2012-09-14 Thread kenneth

Title: [128610] trunk/Source/WebKit2








Revision 128610
Author kenn...@webkit.org
Date 2012-09-14 07:30:58 -0700 (Fri, 14 Sep 2012)


Log Message
[EFL] Add unit test for RefPtr
https://bugs.webkit.org/show_bug.cgi?id=96776

Reviewed by Simon Hausmann.

Basic testing of the new EFL specific RefPtr type.

* PlatformEfl.cmake:
* UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestBase.h:
(EWK2UnitTest::EWK2UnitTestBase::backingStore):
(EWK2UnitTest::EWK2UnitTestBase::canvas):

Add some new accessors for Ecore_Evas and Evas*.

* UIProcess/API/efl/tests/test_ewk2_refptr_evas_object.cpp: Added.
(TEST_F):

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/PlatformEfl.cmake
trunk/Source/WebKit2/UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestBase.h


Added Paths

trunk/Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_refptr_evas_object.cpp




Diff

Modified: trunk/Source/WebKit2/ChangeLog (128609 => 128610)

--- trunk/Source/WebKit2/ChangeLog	2012-09-14 14:08:27 UTC (rev 128609)
+++ trunk/Source/WebKit2/ChangeLog	2012-09-14 14:30:58 UTC (rev 128610)
@@ -1,3 +1,22 @@
+2012-09-14  Kenneth Rohde Christiansen  
+
+[EFL] Add unit test for RefPtr
+https://bugs.webkit.org/show_bug.cgi?id=96776
+
+Reviewed by Simon Hausmann.
+
+Basic testing of the new EFL specific RefPtr type.
+
+* PlatformEfl.cmake:
+* UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestBase.h:
+(EWK2UnitTest::EWK2UnitTestBase::backingStore):
+(EWK2UnitTest::EWK2UnitTestBase::canvas):
+
+Add some new accessors for Ecore_Evas and Evas*.
+
+* UIProcess/API/efl/tests/test_ewk2_refptr_evas_object.cpp: Added.
+(TEST_F):
+
 2012-09-14  Tor Arne Vestbø  
 
 [Qt] Move .mm file to OBJECTIVE_SOURCES


Modified: trunk/Source/WebKit2/PlatformEfl.cmake (128609 => 128610)

--- trunk/Source/WebKit2/PlatformEfl.cmake	2012-09-14 14:08:27 UTC (rev 128609)
+++ trunk/Source/WebKit2/PlatformEfl.cmake	2012-09-14 14:30:58 UTC (rev 128610)
@@ -286,6 +286,7 @@
 test_ewk2_cookie_manager
 test_ewk2_download_job
 test_ewk2_eina_shared_string
+test_ewk2_refptr_evas_object
 test_ewk2_intents
 test_ewk2_settings
 test_ewk2_view


Modified: trunk/Source/WebKit2/UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestBase.h (128609 => 128610)

--- trunk/Source/WebKit2/UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestBase.h	2012-09-14 14:08:27 UTC (rev 128609)
+++ trunk/Source/WebKit2/UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestBase.h	2012-09-14 14:30:58 UTC (rev 128610)
@@ -29,6 +29,8 @@
 
 class EWK2UnitTestBase : public ::testing::Test {
 public:
+Ecore_Evas* backingStore() { return m_ecoreEvas; }
+Evas* canvas() { ecore_evas_get(m_ecoreEvas); }
 Evas_Object* webView() { return m_webView; }
 Ewk_View_Smart_Class* ewkViewClass() { return &m_ewkViewClass; }
 


Added: trunk/Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_refptr_evas_object.cpp (0 => 128610)

--- trunk/Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_refptr_evas_object.cpp	(rev 0)
+++ trunk/Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_refptr_evas_object.cpp	2012-09-14 14:30:58 UTC (rev 128610)
@@ -0,0 +1,134 @@
+/*
+ * Copyright (C) 2012 Intel Corporation. All rights reserved.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions
+ * are met:
+ * 1. Redistributions of source code must retain the above copyright
+ *notice, this list of conditions and the following disclaimer.
+ * 2. Redistributions in binary form must reproduce the above copyright
+ *notice, this list of conditions and the following disclaimer in the
+ *documentation and/or other materials provided with the distribution.
+ *
+ * THIS SOFTWARE IS PROVIDED BY APPLE INC. AND ITS CONTRIBUTORS ``AS IS''
+ * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO,
+ * THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
+ * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR ITS CONTRIBUTORS
+ * BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
+ * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
+ * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
+ * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
+ * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
+ * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF
+ * THE POSSIBILITY OF SUCH DAMAGE.
+ */
+
+#include "config.h"
+
+#include "UnitTestUtils/EWK2UnitTestBase.h"
+#include "UnitTestUtils/EWK2UnitTestEnvironment.h"
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+
+using namespace EWK2UnitTest;
+
+extern EWK2UnitTestEnvironment* environment;
+
+TEST_F(EWK2UnitTestBase, construction)
+{
+RefPtr nullObject = 0;
+A

[webkit-changes] [128609] trunk/Source/WTF

2012-09-14 Thread loislo

Title: [128609] trunk/Source/WTF








Revision 128609
Author loi...@chromium.org
Date 2012-09-14 07:08:27 -0700 (Fri, 14 Sep 2012)


Log Message
Web Inspector: NMI: convert template versions of String*::reportMemoryUsage functions to normal functions.
https://bugs.webkit.org/show_bug.cgi?id=96759

Reviewed by Yury Semikhatsky.

Now when MemoryInstrumentation.h is a part of WTF we can move reportMemoryUsage functions to cpp file.

* wtf/text/AtomicString.cpp:
(WTF::AtomicString::reportMemoryUsage):
(WTF):
* wtf/text/AtomicString.h:
(WTF):
(AtomicString):
* wtf/text/StringImpl.cpp:
(WTF::StringImpl::reportMemoryUsage):
(WTF):
* wtf/text/StringImpl.h:
(WTF):
(StringImpl):
* wtf/text/WTFString.cpp:
(WTF::String::reportMemoryUsage):
(WTF):
* wtf/text/WTFString.h:
(WTF):
(String):

Modified Paths

trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/text/AtomicString.cpp
trunk/Source/WTF/wtf/text/AtomicString.h
trunk/Source/WTF/wtf/text/StringImpl.cpp
trunk/Source/WTF/wtf/text/StringImpl.h
trunk/Source/WTF/wtf/text/WTFString.cpp
trunk/Source/WTF/wtf/text/WTFString.h




Diff

Modified: trunk/Source/WTF/ChangeLog (128608 => 128609)

--- trunk/Source/WTF/ChangeLog	2012-09-14 14:02:35 UTC (rev 128608)
+++ trunk/Source/WTF/ChangeLog	2012-09-14 14:08:27 UTC (rev 128609)
@@ -1,5 +1,33 @@
 2012-09-14  Ilya Tikhonovsky  
 
+Web Inspector: NMI: convert template versions of String*::reportMemoryUsage functions to normal functions.
+https://bugs.webkit.org/show_bug.cgi?id=96759
+
+Reviewed by Yury Semikhatsky.
+
+Now when MemoryInstrumentation.h is a part of WTF we can move reportMemoryUsage functions to cpp file.
+
+* wtf/text/AtomicString.cpp:
+(WTF::AtomicString::reportMemoryUsage):
+(WTF):
+* wtf/text/AtomicString.h:
+(WTF):
+(AtomicString):
+* wtf/text/StringImpl.cpp:
+(WTF::StringImpl::reportMemoryUsage):
+(WTF):
+* wtf/text/StringImpl.h:
+(WTF):
+(StringImpl):
+* wtf/text/WTFString.cpp:
+(WTF::String::reportMemoryUsage):
+(WTF):
+* wtf/text/WTFString.h:
+(WTF):
+(String):
+
+2012-09-14  Ilya Tikhonovsky  
+
 Web Inspector: NMI: remove current traits helper class because it is customizing the instrumentation at a wrong place and is not necessary at the moment.
 https://bugs.webkit.org/show_bug.cgi?id=96737
 


Modified: trunk/Source/WTF/wtf/text/AtomicString.cpp (128608 => 128609)

--- trunk/Source/WTF/wtf/text/AtomicString.cpp	2012-09-14 14:02:35 UTC (rev 128608)
+++ trunk/Source/WTF/wtf/text/AtomicString.cpp	2012-09-14 14:08:27 UTC (rev 128609)
@@ -26,6 +26,7 @@
 
 #include "StringHash.h"
 #include 
+#include 
 #include 
 #include 
 #include 
@@ -435,4 +436,10 @@
 }
 #endif
 
+void AtomicString::reportMemoryUsage(MemoryObjectInfo* memoryObjectInfo) const
+{
+MemoryClassInfo info(memoryObjectInfo, this);
+info.addInstrumentedMember(m_string);
+}
+
 } // namespace WTF


Modified: trunk/Source/WTF/wtf/text/AtomicString.h (128608 => 128609)

--- trunk/Source/WTF/wtf/text/AtomicString.h	2012-09-14 14:02:35 UTC (rev 128608)
+++ trunk/Source/WTF/wtf/text/AtomicString.h	2012-09-14 14:08:27 UTC (rev 128609)
@@ -35,6 +35,7 @@
 namespace WTF {
 
 struct AtomicStringHash;
+class MemoryObjectInfo;
 
 class AtomicString {
 public:
@@ -158,12 +159,7 @@
 void show() const;
 #endif
 
-template
-void reportMemoryUsage(MemoryObjectInfo* memoryObjectInfo) const
-{
-typename MemoryObjectInfo::ClassInfo info(memoryObjectInfo, this);
-info.addInstrumentedMember(m_string);
-}
+WTF_EXPORT_STRING_API void reportMemoryUsage(MemoryObjectInfo*) const;
 
 private:
 // The explicit constructors with AtomicString::ConstructFromLiteral must be used for literals.


Modified: trunk/Source/WTF/wtf/text/StringImpl.cpp (128608 => 128609)

--- trunk/Source/WTF/wtf/text/StringImpl.cpp	2012-09-14 14:02:35 UTC (rev 128608)
+++ trunk/Source/WTF/wtf/text/StringImpl.cpp	2012-09-14 14:08:27 UTC (rev 128609)
@@ -28,6 +28,7 @@
 #include "AtomicString.h"
 #include "StringBuffer.h"
 #include "StringHash.h"
+#include 
 #include 
 #include 
 #include 
@@ -1791,4 +1792,24 @@
 return size + sizeof(*this);
 }
 
+void StringImpl::reportMemoryUsage(MemoryObjectInfo* memoryObjectInfo) const
+{
+size_t selfSize = sizeof(StringImpl);
+
+// Count size used by internal buffer but skip strings that were constructed from literals.
+if ((m_hashAndFlags & BufferInternal) && !hasTerminatingNullCharacter())
+// Three cases are covered here:
+// 1) a normal 8-bit string with internal storage (BufferInternal)
+// 2) a normal 16-bit string with internal storage (BufferInternal)
+// 3) empty unique string with length = 0 (BufferInternal)
+selfSize += m_length * (m_hashAndFlags & s_hashFlag8BitBuffer ? sizeof(LChar) : sizeof(UChar));
+
+MemoryClassInfo info(memoryObjectInfo, this, 0, se

[webkit-changes] [128608] trunk/Source/WebKit2

2012-09-14 Thread vestbo

Title: [128608] trunk/Source/WebKit2








Revision 128608
Author ves...@webkit.org
Date 2012-09-14 07:02:35 -0700 (Fri, 14 Sep 2012)


Log Message
[Qt] Move .mm file to OBJECTIVE_SOURCES

Reviewed by Simon Hausmann.

* Target.pri:

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/Target.pri




Diff

Modified: trunk/Source/WebKit2/ChangeLog (128607 => 128608)

--- trunk/Source/WebKit2/ChangeLog	2012-09-14 14:01:17 UTC (rev 128607)
+++ trunk/Source/WebKit2/ChangeLog	2012-09-14 14:02:35 UTC (rev 128608)
@@ -1,3 +1,11 @@
+2012-09-14  Tor Arne Vestbø  
+
+[Qt] Move .mm file to OBJECTIVE_SOURCES
+
+Reviewed by Simon Hausmann.
+
+* Target.pri:
+
 2012-09-14  Sudarsana Nagineni  
 
 WebKitTestRunner needs layoutTestController.setTabKeyCyclesThroughElements


Modified: trunk/Source/WebKit2/Target.pri (128607 => 128608)

--- trunk/Source/WebKit2/Target.pri	2012-09-14 14:01:17 UTC (rev 128607)
+++ trunk/Source/WebKit2/Target.pri	2012-09-14 14:02:35 UTC (rev 128608)
@@ -842,7 +842,7 @@
 $$PWD/../../WebKitLibraries/
 HEADERS += \
 WebProcess/WebCoreSupport/qt/WebSystemInterface.h
-SOURCES += \
+OBJECTIVE_SOURCES += \
 WebProcess/WebCoreSupport/qt/WebSystemInterface.mm
 }
 INCLUDEPATH += \






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [128607] trunk

2012-09-14 Thread commit-queue

Title: [128607] trunk








Revision 128607
Author commit-qu...@webkit.org
Date 2012-09-14 07:01:17 -0700 (Fri, 14 Sep 2012)


Log Message
[EFL] Attempt to create a theme for 0 sized element leads to assertion hit
https://bugs.webkit.org/show_bug.cgi?id=96743

Patch by Mikhail Pozdnyakov  on 2012-09-14
Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

RenderThemeEfl was not supposed to be created for the elements with '0' size and had an assertion
on that causing crash in debug mode.

Test: fast/forms/range/slider-zero-size-crash.html

* platform/efl/RenderThemeEfl.cpp:
(WebCore::RenderThemeEfl::ThemePartCacheEntry::create):

LayoutTests:

RenderThemeEfl was not supposed to be created for the elements with '0' size and had an assertion
on that causing crash in debug mode.

* fast/forms/range/slider-zero-size-crash-expected.txt: Added.
* fast/forms/range/slider-zero-size-crash.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/efl/RenderThemeEfl.cpp


Added Paths

trunk/LayoutTests/fast/forms/range/slider-zero-size-crash-expected.txt
trunk/LayoutTests/fast/forms/range/slider-zero-size-crash.html




Diff

Modified: trunk/LayoutTests/ChangeLog (128606 => 128607)

--- trunk/LayoutTests/ChangeLog	2012-09-14 13:41:24 UTC (rev 128606)
+++ trunk/LayoutTests/ChangeLog	2012-09-14 14:01:17 UTC (rev 128607)
@@ -1,3 +1,16 @@
+2012-09-14  Mikhail Pozdnyakov  
+
+[EFL] Attempt to create a theme for 0 sized element leads to assertion hit
+https://bugs.webkit.org/show_bug.cgi?id=96743
+
+Reviewed by Kenneth Rohde Christiansen.
+
+RenderThemeEfl was not supposed to be created for the elements with '0' size and had an assertion
+on that causing crash in debug mode.
+
+* fast/forms/range/slider-zero-size-crash-expected.txt: Added.
+* fast/forms/range/slider-zero-size-crash.html: Added.
+
 2012-09-14  Sudarsana Nagineni  
 
 [EFL] Gardening of failing tests


Added: trunk/LayoutTests/fast/forms/range/slider-zero-size-crash-expected.txt (0 => 128607)

--- trunk/LayoutTests/fast/forms/range/slider-zero-size-crash-expected.txt	(rev 0)
+++ trunk/LayoutTests/fast/forms/range/slider-zero-size-crash-expected.txt	2012-09-14 14:01:17 UTC (rev 128607)
@@ -0,0 +1,2 @@
+
+This test passes if it does not crash.


Added: trunk/LayoutTests/fast/forms/range/slider-zero-size-crash.html (0 => 128607)

--- trunk/LayoutTests/fast/forms/range/slider-zero-size-crash.html	(rev 0)
+++ trunk/LayoutTests/fast/forms/range/slider-zero-size-crash.html	2012-09-14 14:01:17 UTC (rev 128607)
@@ -0,0 +1,17 @@
+
+
+
+A slider with '0' size does not lead to a crash
+
+
+if (window.testRunner)
+testRunner.dumpAsText();
+
+
+
+
+document.getElementById("slider").style.height="0px"
+document.getElementById("slider").style.width="0px";
+
+This test passes if it does not crash.
+


Modified: trunk/Source/WebCore/ChangeLog (128606 => 128607)

--- trunk/Source/WebCore/ChangeLog	2012-09-14 13:41:24 UTC (rev 128606)
+++ trunk/Source/WebCore/ChangeLog	2012-09-14 14:01:17 UTC (rev 128607)
@@ -1,3 +1,18 @@
+2012-09-14  Mikhail Pozdnyakov  
+
+[EFL] Attempt to create a theme for 0 sized element leads to assertion hit
+https://bugs.webkit.org/show_bug.cgi?id=96743
+
+Reviewed by Kenneth Rohde Christiansen.
+
+RenderThemeEfl was not supposed to be created for the elements with '0' size and had an assertion
+on that causing crash in debug mode. 
+
+Test: fast/forms/range/slider-zero-size-crash.html
+
+* platform/efl/RenderThemeEfl.cpp:
+(WebCore::RenderThemeEfl::ThemePartCacheEntry::create):
+
 2012-09-14  Andrey Kosyakov  
 
 Web Inspector: reuse WebInspector.ProgressIndicator in Audits panel


Modified: trunk/Source/WebCore/platform/efl/RenderThemeEfl.cpp (128606 => 128607)

--- trunk/Source/WebCore/platform/efl/RenderThemeEfl.cpp	2012-09-14 13:41:24 UTC (rev 128606)
+++ trunk/Source/WebCore/platform/efl/RenderThemeEfl.cpp	2012-09-14 14:01:17 UTC (rev 128607)
@@ -196,9 +196,8 @@
 RenderThemeEfl::ThemePartCacheEntry* RenderThemeEfl::ThemePartCacheEntry::create(const String& themePath, FormType type, const IntSize& size)
 {
 ASSERT(!themePath.isEmpty());
-ASSERT(!size.isEmpty());
 
-if (isFormElementTooLargeToDisplay(size)) {
+if (isFormElementTooLargeToDisplay(size) || size.isEmpty()) {
 EINA_LOG_ERR("Cannot render an element of size %dx%d.", size.width(), size.height());
 return 0;
 }






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [128606] trunk

2012-09-14 Thread vestbo

Title: [128606] trunk








Revision 128606
Author ves...@webkit.org
Date 2012-09-14 06:41:24 -0700 (Fri, 14 Sep 2012)


Log Message
[Qt] Fix handling of debug/release/debug_and_release/build_all

We now pick up the defaults from Qt, in default_pre (CONFIG already
contains the appropriate values for debug and release). We then let
the command line arguments to qmake, or the project files themselves,
override the configuration, and finally we sanitize the configuration
in default_post.

Reviewed by Simon Hausmann.

Modified Paths

trunk/ChangeLog
trunk/Source/api.pri
trunk/Tools/ChangeLog
trunk/Tools/DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro
trunk/Tools/Scripts/webkitdirs.pm
trunk/Tools/qmake/mkspecs/features/default_post.prf
trunk/Tools/qmake/mkspecs/features/default_pre.prf
trunk/Tools/qmake/mkspecs/features/mac/default_pre.prf




Diff

Modified: trunk/ChangeLog (128605 => 128606)

--- trunk/ChangeLog	2012-09-14 13:37:23 UTC (rev 128605)
+++ trunk/ChangeLog	2012-09-14 13:41:24 UTC (rev 128606)
@@ -1,3 +1,17 @@
+2012-09-14  Tor Arne Vestbø  
+
+[Qt] Fix handling of debug/release/debug_and_release/build_all
+
+We now pick up the defaults from Qt, in default_pre (CONFIG already
+contains the appropriate values for debug and release). We then let
+the command line arguments to qmake, or the project files themselves,
+override the configuration, and finally we sanitize the configuration
+in default_post.
+
+Reviewed by Simon Hausmann.
+
+* Source/api.pri:
+
 2012-09-14  Keishi Hattori  
 
 Add runtime flag that enables lang attribute for form controls in LayoutTests


Modified: trunk/Source/api.pri (128605 => 128606)

--- trunk/Source/api.pri	2012-09-14 13:37:23 UTC (rev 128605)
+++ trunk/Source/api.pri	2012-09-14 13:41:24 UTC (rev 128606)
@@ -51,14 +51,6 @@
 
 load(qt_module)
 
-# Make sure the module config doesn't override our preferred build config.
-debug_and_release:if(!debug|!release) {
-# Removing debug_and_release causes issues with lib suffixes when building debug on Windows.
-# Work around it by only removing build_all, and still create the Makefiles for both configurations.
-win32*: CONFIG -= build_all
-else: CONFIG -= debug_and_release
-}
-
 # Allow doing a debug-only build of WebKit (not supported by Qt)
 macx:!debug_and_release:debug: TARGET = $$BASE_TARGET
 


Modified: trunk/Tools/ChangeLog (128605 => 128606)

--- trunk/Tools/ChangeLog	2012-09-14 13:37:23 UTC (rev 128605)
+++ trunk/Tools/ChangeLog	2012-09-14 13:41:24 UTC (rev 128606)
@@ -1,3 +1,22 @@
+2012-09-14  Tor Arne Vestbø  
+
+[Qt] Fix handling of debug/release/debug_and_release/build_all
+
+We now pick up the defaults from Qt, in default_pre (CONFIG already
+contains the appropriate values for debug and release). We then let
+the command line arguments to qmake, or the project files themselves,
+override the configuration, and finally we sanitize the configuration
+in default_post.
+
+Reviewed by Simon Hausmann.
+
+* DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
+* Scripts/webkitdirs.pm:
+(buildQMakeProjects):
+* qmake/mkspecs/features/default_post.prf:
+* qmake/mkspecs/features/default_pre.prf:
+* qmake/mkspecs/features/mac/default_pre.prf:
+
 2012-09-14  Sudarsana Nagineni  
 
 WebKitTestRunner needs layoutTestController.setTabKeyCyclesThroughElements


Modified: trunk/Tools/DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro (128605 => 128606)

--- trunk/Tools/DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro	2012-09-14 13:37:23 UTC (rev 128605)
+++ trunk/Tools/DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro	2012-09-14 13:41:24 UTC (rev 128606)
@@ -50,8 +50,6 @@
 QMAKE_PLUGIN_BUNDLE_NAME = $$TARGET
 QMAKE_BUNDLE_LOCATION += "Contents/MacOS"
 
-!build_pass:CONFIG += build_all
-
 OBJECTIVE_SOURCES += PluginObjectMac.mm
 LIBS += -framework Carbon -framework Cocoa -framework QuartzCore
 }


Modified: trunk/Tools/Scripts/webkitdirs.pm (128605 => 128606)

--- trunk/Tools/Scripts/webkitdirs.pm	2012-09-14 13:37:23 UTC (rev 128605)
+++ trunk/Tools/Scripts/webkitdirs.pm	2012-09-14 13:41:24 UTC (rev 128606)
@@ -2267,7 +2267,6 @@
 } elsif ($passedConfig) {
 die "Build type $passedConfig is not supported with --qt.\n";
 }
-push @buildArgs, "CONFIG-=debug_and_release" if ($passedConfig && isDarwin());
 
 # Using build-webkit to build assumes you want a developer-build
 push @buildArgs, "CONFIG-=production_build";


Modified: trunk/Tools/qmake/mkspecs/features/default_post.prf (128605 => 128606)

--- trunk/Tools/qmake/mkspecs/features/default_post.prf	2012-09-14 13:37:23 UTC (rev 128605)
+++ trunk/Tools/qmake/mkspecs/features/default_post.prf	2012-09-14 13:41:24 UTC (rev 128606)
@@ -12,6 +12,19 @@
 
 root_project_file: finalizeConfigure()

[webkit-changes] [128605] trunk/LayoutTests

2012-09-14 Thread commit-queue

Title: [128605] trunk/LayoutTests








Revision 128605
Author commit-qu...@webkit.org
Date 2012-09-14 06:37:23 -0700 (Fri, 14 Sep 2012)


Log Message
[EFL] Gardening of failing tests
https://bugs.webkit.org/show_bug.cgi?id=96646

Unreviewed EFL gardening of flaky tests on wk1.

Patch by Sudarsana Nagineni  on 2012-09-14

* platform/efl-wk1/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/efl-wk1/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (128604 => 128605)

--- trunk/LayoutTests/ChangeLog	2012-09-14 13:27:57 UTC (rev 128604)
+++ trunk/LayoutTests/ChangeLog	2012-09-14 13:37:23 UTC (rev 128605)
@@ -1,5 +1,14 @@
 2012-09-14  Sudarsana Nagineni  
 
+[EFL] Gardening of failing tests
+https://bugs.webkit.org/show_bug.cgi?id=96646
+
+Unreviewed EFL gardening of flaky tests on wk1.
+
+* platform/efl-wk1/TestExpectations:
+
+2012-09-14  Sudarsana Nagineni  
+
 WebKitTestRunner needs layoutTestController.setTabKeyCyclesThroughElements
 https://bugs.webkit.org/show_bug.cgi?id=42687
 


Modified: trunk/LayoutTests/platform/efl-wk1/TestExpectations (128604 => 128605)

--- trunk/LayoutTests/platform/efl-wk1/TestExpectations	2012-09-14 13:27:57 UTC (rev 128604)
+++ trunk/LayoutTests/platform/efl-wk1/TestExpectations	2012-09-14 13:37:23 UTC (rev 128605)
@@ -41,6 +41,9 @@
 BUGWKEFL : editing/undo/undo-indent.html = TEXT PASS
 BUGWKEFL : editing/undo/undo-misspellings.html = TEXT PASS
 
+BUGWK96641 : media/video-seek-past-end-playing.html = TEXT PASS
+BUGWK96642 : loader/go-back-to-different-window-size.html = TEXT PASS
+
 //
 // FAILING TESTS
 //






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [128604] trunk

2012-09-14 Thread commit-queue

Title: [128604] trunk








Revision 128604
Author commit-qu...@webkit.org
Date 2012-09-14 06:27:57 -0700 (Fri, 14 Sep 2012)


Log Message
WebKitTestRunner needs layoutTestController.setTabKeyCyclesThroughElements
https://bugs.webkit.org/show_bug.cgi?id=42687

Patch by Sudarsana Nagineni  on 2012-09-14
Reviewed by Kenneth Rohde Christiansen.

Source/WebKit2:

Implement testRunner.setTabKeyCyclesThroughElements for
WebKitTestRunner.

* WebProcess/InjectedBundle/API/c/WKBundle.cpp:
(WKBundleSetTabKeyCyclesThroughElements):
* WebProcess/InjectedBundle/API/c/WKBundlePrivate.h:
* WebProcess/InjectedBundle/InjectedBundle.cpp:
(WebKit::InjectedBundle::setTabKeyCyclesThroughElements):
(WebKit):
* WebProcess/InjectedBundle/InjectedBundle.h:
(InjectedBundle):

Tools:

Implement testRunner.setTabKeyCyclesThroughElements for
WebKitTestRunner.

* WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
* WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
(WTR::InjectedBundle::beginTesting):
* WebKitTestRunner/InjectedBundle/TestRunner.cpp:
(WTR::TestRunner::setTabKeyCyclesThroughElements):
(WTR):
* WebKitTestRunner/InjectedBundle/TestRunner.h:
(TestRunner):

LayoutTests:

fast/events/keypress-insert-tab.html is passing now on wk2. So, unskip
in common skipped files and re-skip it on efl-wk1 until WK82864 is fixed.

* platform/efl-wk1/TestExpectations:
* platform/efl/Skipped:
* platform/wk2/Skipped:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/efl/Skipped
trunk/LayoutTests/platform/efl-wk1/TestExpectations
trunk/LayoutTests/platform/wk2/Skipped
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundle.cpp
trunk/Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundlePrivate.h
trunk/Source/WebKit2/WebProcess/InjectedBundle/InjectedBundle.cpp
trunk/Source/WebKit2/WebProcess/InjectedBundle/InjectedBundle.h
trunk/Tools/ChangeLog
trunk/Tools/WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl
trunk/Tools/WebKitTestRunner/InjectedBundle/InjectedBundle.cpp
trunk/Tools/WebKitTestRunner/InjectedBundle/TestRunner.cpp
trunk/Tools/WebKitTestRunner/InjectedBundle/TestRunner.h




Diff

Modified: trunk/LayoutTests/ChangeLog (128603 => 128604)

--- trunk/LayoutTests/ChangeLog	2012-09-14 13:27:18 UTC (rev 128603)
+++ trunk/LayoutTests/ChangeLog	2012-09-14 13:27:57 UTC (rev 128604)
@@ -1,5 +1,19 @@
 2012-09-14  Sudarsana Nagineni  
 
+WebKitTestRunner needs layoutTestController.setTabKeyCyclesThroughElements
+https://bugs.webkit.org/show_bug.cgi?id=42687
+
+Reviewed by Kenneth Rohde Christiansen.
+
+fast/events/keypress-insert-tab.html is passing now on wk2. So, unskip
+in common skipped files and re-skip it on efl-wk1 until WK82864 is fixed.
+
+* platform/efl-wk1/TestExpectations:
+* platform/efl/Skipped:
+* platform/wk2/Skipped:
+
+2012-09-14  Sudarsana Nagineni  
+
 EventSendingController::keyDown does not support non-array modifier arguments
 https://bugs.webkit.org/show_bug.cgi?id=96727
 


Modified: trunk/LayoutTests/platform/efl/Skipped (128603 => 128604)

--- trunk/LayoutTests/platform/efl/Skipped	2012-09-14 13:27:18 UTC (rev 128603)
+++ trunk/LayoutTests/platform/efl/Skipped	2012-09-14 13:27:57 UTC (rev 128604)
@@ -78,9 +78,6 @@
 # EFL's LayoutTestController does not implement setScrollbarPolicy
 fast/overflow/scrollbar-restored-and-then-locked.html
 
-# EFL's LayoutTestController does not implement setTabKeyCyclesThroughElements
-fast/events/keypress-insert-tab.html
-
 # EFL's LayoutTestController does not implement enableAutoResizeMode
 fast/autoresize
 


Modified: trunk/LayoutTests/platform/efl-wk1/TestExpectations (128603 => 128604)

--- trunk/LayoutTests/platform/efl-wk1/TestExpectations	2012-09-14 13:27:18 UTC (rev 128603)
+++ trunk/LayoutTests/platform/efl-wk1/TestExpectations	2012-09-14 13:27:57 UTC (rev 128604)
@@ -78,3 +78,6 @@
 BUGWK96620 : http/tests/loading/pdf-commit-load-callbacks.html = TEXT
 BUGWK96620 : http/tests/loading/text-content-type-with-binary-extension.html = TEXT
 
+// EFL's LayoutTestController does not implement setTabKeyCyclesThroughElements.
+BUGWK82864 : fast/events/keypress-insert-tab.html = TEXT
+


Modified: trunk/LayoutTests/platform/wk2/Skipped (128603 => 128604)

--- trunk/LayoutTests/platform/wk2/Skipped	2012-09-14 13:27:18 UTC (rev 128603)
+++ trunk/LayoutTests/platform/wk2/Skipped	2012-09-14 13:27:57 UTC (rev 128604)
@@ -424,10 +424,6 @@
 # 
 fast/encoding/idn-security.html
 
-# WebKitTestRunner needs layoutTestController.setTabKeyCyclesThroughElements
-# 
-fast/events/keypress-insert-tab.html
-
 # WebKitTestRunner needs layoutTestController.abortModal
 # 
 fast/events/show-modal-dialog-onblur-onfocus.html


Modified: trunk/Source/WebKit2/ChangeLog (128603 => 128604)

--- trunk/Source/WebKit2/ChangeLog	2012-09-14 13:27:18 UTC (rev 128603)
+++ trunk/Source/WebKit2/ChangeLog	2012-09-14 13:27:57 UTC (rev 128604)
@@ -1,3 +1,22 @@
+2012-09-14  S

[webkit-changes] [128603] trunk/Source/WebKit/blackberry

2012-09-14 Thread tonikitoo

Title: [128603] trunk/Source/WebKit/blackberry








Revision 128603
Author toniki...@webkit.org
Date 2012-09-14 06:27:18 -0700 (Fri, 14 Sep 2012)


Log Message
[BlackBerry]  Remove the ability to schedule a zoom about point call.
https://bugs.webkit.org/show_bug.cgi?id=96696

[FullScreen] entering/leaving fullscreen results in temporary glitches on the screen (Part I)
PR #180866

Reviewed by Rob Buis.
Patch by Antonio Gomes 

Internally reviewed by Jacky Hajiang and Arvid Nilsson.

Patch replaces the async call to zoomAboutPoint (via scheduling it with a one-shot-0-timer).
Instead, at its single call site, we inline most of the previous scheduleZoomAboutPoint code,
and in the end call zoomAboutPoint directly.

Change was estimulated by Arvid's comment on PRzilla: "There is no longer any reason to have
"zoom about point" be async.. That was a hack I did for BB6, back when we were doing everything
on the WK read and needed manual time slicing betwren rendering and user interaction."

The bigger goal though is to be able to remove screen glitches while entering/leaving
fullscreen mode: since we could accurately use the count-based suspend/resume backing
store mechanism to prevent it.

* Api/WebPage.cpp:
(WebKit):
(BlackBerry::WebKit::WebPagePrivate::WebPagePrivate):
(BlackBerry::WebKit::WebPagePrivate::setLoadState):
(BlackBerry::WebKit::WebPagePrivate::setViewportSize):
* Api/WebPage_p.h:
(WebPagePrivate):

Modified Paths

trunk/Source/WebKit/blackberry/Api/WebPage.cpp
trunk/Source/WebKit/blackberry/Api/WebPage_p.h
trunk/Source/WebKit/blackberry/ChangeLog




Diff

Modified: trunk/Source/WebKit/blackberry/Api/WebPage.cpp (128602 => 128603)

--- trunk/Source/WebKit/blackberry/Api/WebPage.cpp	2012-09-14 13:19:36 UTC (rev 128602)
+++ trunk/Source/WebKit/blackberry/Api/WebPage.cpp	2012-09-14 13:27:18 UTC (rev 128603)
@@ -208,8 +208,6 @@
 
 const double manualScrollInterval = 0.1; // The time interval during which we associate user action with scrolling.
 
-const double delayedZoomInterval = 0;
-
 const IntSize minimumLayoutSize(10, 10); // Needs to be a small size, greater than 0, that we can grow the layout from.
 
 const double minimumExpandingRatio = 0.15;
@@ -402,7 +400,6 @@
 , m_currentBlockZoomNode(0)
 , m_currentBlockZoomAdjustedNode(0)
 , m_shouldReflowBlock(false)
-, m_delayedZoomTimer(adoptPtr(new Timer(this, &WebPagePrivate::zoomAboutPointTimerFired)))
 , m_lastUserEventTimestamp(0.0)
 , m_pluginMouseButtonPressed(false)
 , m_pluginMayOpenNewTab(false)
@@ -1042,8 +1039,6 @@
 break;
 case Committed:
 {
-unscheduleZoomAboutPoint();
-
 #if ENABLE(ACCELERATED_2D_CANVAS)
 if (m_page->settings()->canvasUsesAcceleratedDrawing()) {
 // Free GPU resources as we're on a new page.
@@ -1299,71 +1294,6 @@
 max(0, static_cast(roundf(reflowedRect.y() + offsetY - anchorOffset.y() / inverseScale;
 }
 
-bool WebPagePrivate::scheduleZoomAboutPoint(double unclampedScale, const FloatPoint& anchor, bool enforceScaleClamping, bool forceRendering)
-{
-double scale;
-if (!shouldZoomAboutPoint(unclampedScale, anchor, enforceScaleClamping, &scale)) {
-// We could be back to the right zoom level before the timer has
-// timed out, because of wiggling back and forth. Stop the timer.
-unscheduleZoomAboutPoint();
-return false;
-}
-
-// For some reason, the bitmap zoom wants an anchor in backingstore coordinates!
-// this is different from zoomAboutPoint, which wants content coordinates.
-// See RIM Bug #641.
-
-FloatPoint transformedAnchor = mapToTransformedFloatPoint(anchor);
-FloatPoint transformedScrollPosition = mapToTransformedFloatPoint(scrollPosition());
-
-// Prohibit backingstore from updating the window overtop of the bitmap.
-m_backingStore->d->suspendScreenAndBackingStoreUpdates();
-
-// Need to invert the previous transform to anchor the viewport.
-double zoomFraction = scale / transformationMatrix()->m11();
-
-// Anchor offset from scroll position in float.
-FloatPoint anchorOffset(transformedAnchor.x() - transformedScrollPosition.x(),
-transformedAnchor.y() - transformedScrollPosition.y());
-
-IntPoint srcPoint(
-static_cast(roundf(transformedAnchor.x() - anchorOffset.x() / zoomFraction)),
-static_cast(roundf(transformedAnchor.y() - anchorOffset.y() / zoomFraction)));
-
-const IntRect viewportRect = IntRect(IntPoint::zero(), transformedViewportSize());
-const IntRect dstRect = viewportRect;
-
-// This is the rect to pass as the actual source rect in the backingstore
-// for the transform given by zoom.
-IntRect srcRect(srcPoint.x(),
-srcPoint.y(),
-viewportRect.width() / zoomFraction,
-viewportRect.height() / zoomFraction);
-m_backingStore->d->blitContents(dstRect, srcRect);
-
-m_del

[webkit-changes] [128602] trunk

2012-09-14 Thread commit-queue

Title: [128602] trunk








Revision 128602
Author commit-qu...@webkit.org
Date 2012-09-14 06:19:36 -0700 (Fri, 14 Sep 2012)


Log Message
EventSendingController::keyDown does not support non-array modifier arguments
https://bugs.webkit.org/show_bug.cgi?id=96727

Patch by Sudarsana Nagineni  on 2012-09-14
Reviewed by Kenneth Rohde Christiansen.

Tools:

Add support for handling a string as modifier argument to
EventSendingController::keyDown.

* WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
(WTR::parseModifierArray):

LayoutTests:

Unskip passing test fast/forms/legend-access-key.html

* platform/efl-wk2/TestExpectations:
* platform/gtk-wk2/Skipped:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/efl-wk2/TestExpectations
trunk/LayoutTests/platform/gtk-wk2/Skipped
trunk/Tools/ChangeLog
trunk/Tools/WebKitTestRunner/InjectedBundle/EventSendingController.cpp




Diff

Modified: trunk/LayoutTests/ChangeLog (128601 => 128602)

--- trunk/LayoutTests/ChangeLog	2012-09-14 13:10:37 UTC (rev 128601)
+++ trunk/LayoutTests/ChangeLog	2012-09-14 13:19:36 UTC (rev 128602)
@@ -1,3 +1,15 @@
+2012-09-14  Sudarsana Nagineni  
+
+EventSendingController::keyDown does not support non-array modifier arguments
+https://bugs.webkit.org/show_bug.cgi?id=96727
+
+Reviewed by Kenneth Rohde Christiansen.
+
+Unskip passing test fast/forms/legend-access-key.html
+
+* platform/efl-wk2/TestExpectations:
+* platform/gtk-wk2/Skipped:
+
 2012-09-14  Vsevolod Vlasov  
 
 Unreviewed skipping failing test.


Modified: trunk/LayoutTests/platform/efl-wk2/TestExpectations (128601 => 128602)

--- trunk/LayoutTests/platform/efl-wk2/TestExpectations	2012-09-14 13:10:37 UTC (rev 128601)
+++ trunk/LayoutTests/platform/efl-wk2/TestExpectations	2012-09-14 13:19:36 UTC (rev 128602)
@@ -197,7 +197,6 @@
 BUGWKEFL : editing/input/emacs-ctrl-o.html = TEXT
 BUGWKEFL : fast/block/float/float-in-float-hit-testing.html = TEXT
 BUGWKEFL : fast/dom/Window/mozilla-focus-blur.html = TEXT
-BUGWKEFL : fast/forms/legend-access-key.html = TEXT
 BUGWKEFL : fast/forms/select-writing-direction-natural.html = TEXT
 BUGWKEFL : fast/frames/flattening/iframe-tiny.html = TEXT
 BUGWKEFL : fast/replaced/no-focus-ring-embed.html = TEXT


Modified: trunk/LayoutTests/platform/gtk-wk2/Skipped (128601 => 128602)

--- trunk/LayoutTests/platform/gtk-wk2/Skipped	2012-09-14 13:10:37 UTC (rev 128601)
+++ trunk/LayoutTests/platform/gtk-wk2/Skipped	2012-09-14 13:19:36 UTC (rev 128602)
@@ -83,7 +83,6 @@
 fast/forms/select-type-ahead-non-latin.html
 fast/forms/listbox-typeahead-cyrillic.html
 fast/forms/listbox-typeahead-greek.html
-fast/forms/legend-access-key.html
 http/tests/xmlhttprequest/workers/abort-exception-assert.html
 platform/gtk/fast/forms/menulist-typeahead-find.html
 plugins/document-open.html


Modified: trunk/Tools/ChangeLog (128601 => 128602)

--- trunk/Tools/ChangeLog	2012-09-14 13:10:37 UTC (rev 128601)
+++ trunk/Tools/ChangeLog	2012-09-14 13:19:36 UTC (rev 128602)
@@ -1,3 +1,16 @@
+2012-09-14  Sudarsana Nagineni  
+
+EventSendingController::keyDown does not support non-array modifier arguments
+https://bugs.webkit.org/show_bug.cgi?id=96727
+
+Reviewed by Kenneth Rohde Christiansen.
+
+Add support for handling a string as modifier argument to
+EventSendingController::keyDown.
+
+* WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
+(WTR::parseModifierArray):
+
 2012-09-14  Mikhail Pozdnyakov  
 
 WebKitTestRunner needs layoutTestController.setCustomPolicyDelegate


Modified: trunk/Tools/WebKitTestRunner/InjectedBundle/EventSendingController.cpp (128601 => 128602)

--- trunk/Tools/WebKitTestRunner/InjectedBundle/EventSendingController.cpp	2012-09-14 13:10:37 UTC (rev 128601)
+++ trunk/Tools/WebKitTestRunner/InjectedBundle/EventSendingController.cpp	2012-09-14 13:19:36 UTC (rev 128602)
@@ -74,6 +74,13 @@
 {
 if (!arrayValue)
 return 0;
+
+// The value may either be a string with a single modifier or an array of modifiers.
+if (JSValueIsString(context, arrayValue)) {
+JSRetainPtr string(Adopt, JSValueToStringCopy(context, arrayValue, 0));
+return parseModifier(string.get());
+}
+
 if (!JSValueIsObject(context, arrayValue))
 return 0;
 JSObjectRef array = const_cast(arrayValue);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [128601] trunk/LayoutTests

2012-09-14 Thread vsevik

Title: [128601] trunk/LayoutTests








Revision 128601
Author vse...@chromium.org
Date 2012-09-14 06:10:37 -0700 (Fri, 14 Sep 2012)


Log Message
Unreviewed skipping failing test.

* http/tests/inspector/network/network-xhr-replay.html_disabled: Renamed from LayoutTests/http/tests/inspector/network/network-xhr-replay.html.

Modified Paths

trunk/LayoutTests/ChangeLog


Added Paths

trunk/LayoutTests/http/tests/inspector/network/network-xhr-replay.html_disabled


Removed Paths

trunk/LayoutTests/http/tests/inspector/network/network-xhr-replay.html




Diff

Modified: trunk/LayoutTests/ChangeLog (128600 => 128601)

--- trunk/LayoutTests/ChangeLog	2012-09-14 13:09:06 UTC (rev 128600)
+++ trunk/LayoutTests/ChangeLog	2012-09-14 13:10:37 UTC (rev 128601)
@@ -1,3 +1,9 @@
+2012-09-14  Vsevolod Vlasov  
+
+Unreviewed skipping failing test.
+
+* http/tests/inspector/network/network-xhr-replay.html_disabled: Renamed from LayoutTests/http/tests/inspector/network/network-xhr-replay.html.
+
 2012-09-14  Mikhail Pozdnyakov  
 
 WebKitTestRunner needs layoutTestController.setCustomPolicyDelegate


Deleted: trunk/LayoutTests/http/tests/inspector/network/network-xhr-replay.html (128600 => 128601)

--- trunk/LayoutTests/http/tests/inspector/network/network-xhr-replay.html	2012-09-14 13:09:06 UTC (rev 128600)
+++ trunk/LayoutTests/http/tests/inspector/network/network-xhr-replay.html	2012-09-14 13:10:37 UTC (rev 128601)
@@ -1,109 +0,0 @@
-
-
-
-
-function test()
-{
-var networkPanel = WebInspector.showPanel("network");
-
-function lastRequest()
-{
-return networkPanel.requests[networkPanel.requests.length - 1];
-}
-
-function dumpRequest(request)
-{
-InspectorTest.addResult("Dumping request: ");
-InspectorTest.addResult("url: " + request.url);
-if (request.requestFormData)
-InspectorTest.addResult("requestFormData: " + request.requestFormData);
-InspectorTest.addResult("requestMethod: " + request.requestMethod);
-InspectorTest.addResult("test request header value: " + request.requestHeaderValue("headerName"));
-}
-
-function assertRequestEqual(request1, request2)
-{
-InspectorTest.assertEquals(request1.url, request2.url, "Requests have different url");
-InspectorTest.assertEquals(request1.requestFormData, request2.requestFormData, "Requests have different requestFormData");
-InspectorTest.assertEquals(request1.requestMethod, request2.requestMethod, "Requests have different requestMethod");
-InspectorTest.assertEquals(request1.requestHeadersText, request2.requestHeadersText, "Requests have different requestHeadersText");
-}
-
-function testXHRReplay(method, url, async, user, password, headers, withCredentials, payload, callback)
-{
-InspectorTest.resetInspectorResourcesData(step1);
-
-function step1()
-{
-InspectorTest.makeXHR(method, url, async, user, password, headers, withCredentials, payload, step2);
-}
-
-var originalRequest;
-function step2()
-{
-originalRequest = lastRequest();
-dumpRequest(originalRequest);
-NetworkAgent.replayXHR(originalRequest.requestId);
-InspectorTest.addSniffer(WebInspector.NetworkLogView.prototype, "_appendRequest", step3);
-}
-
-function step3()
-{
-var replayedRequest = lastRequest();
-assertRequestEqual(originalRequest, replayedRequest);
-callback();
-}
-}
-
-
-InspectorTest.runTestSuite([
-function testGetStaticAsync(next)
-{
-testXHRReplay("GET", "resources/empty.html", true, "user", "password", [["headerName", "headerValue"]], false, undefined, next);
-},
-
-function testGetStaticSync(next)
-{
-testXHRReplay("GET", "resources/empty.html", false, "user", "password", [["headerName", "headerValue"]], false, undefined, next);
-},
-
-function testGetCachedAsync(next)
-{
-testXHRReplay("GET", "resources/random-cached.php", true, "user", "password", [["headerName", "headerValue"]], false, undefined, next);
-},
-
-function testGetCachedSync(next)
-{
-testXHRReplay("GET", "resources/random-cached.php", false, "user", "password", [["headerName", "headerValue"]], false, undefined, next);
-},
-
-function testGetRandomAsync(next)
-{
-testXHRReplay("GET", "resources/random.php", true, "user", "password", [["headerName", "headerValue"]], false, undefined, next);
-},
-
-function testGetRandomSync(next)
-{
-testXHRReplay("GET", "resources/random.php", false, "user", "password", [["headerName", "headerValue"]], false, undefined, next);
-},
-
-function testPostAsync(next)
-{
-testXHRReplay("POST", "res

[webkit-changes] [128600] trunk

2012-09-14 Thread commit-queue

Title: [128600] trunk








Revision 128600
Author commit-qu...@webkit.org
Date 2012-09-14 06:09:06 -0700 (Fri, 14 Sep 2012)


Log Message
WebKitTestRunner needs layoutTestController.setCustomPolicyDelegate
https://bugs.webkit.org/show_bug.cgi?id=42546

Patch by Mikhail Pozdnyakov  on 2012-09-14
Reviewed by Kenneth Rohde Christiansen.

Tools:

Exported TestRunner::setCustomPolicyDelegate() method.
Allowed Policy Delegate dumping even if we're not in 'waitUntilDone' mode.

* WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
* WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::InjectedBundlePage::decidePolicyForNavigationAction):

LayoutTests:

Unskipped corresponding test cases. Distributed those which still not passing to appropriate groups in Skipped file.

* platform/wk2/Skipped:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/wk2/Skipped
trunk/Tools/ChangeLog
trunk/Tools/WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl
trunk/Tools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp




Diff

Modified: trunk/LayoutTests/ChangeLog (128599 => 128600)

--- trunk/LayoutTests/ChangeLog	2012-09-14 13:08:34 UTC (rev 128599)
+++ trunk/LayoutTests/ChangeLog	2012-09-14 13:09:06 UTC (rev 128600)
@@ -1,3 +1,14 @@
+2012-09-14  Mikhail Pozdnyakov  
+
+WebKitTestRunner needs layoutTestController.setCustomPolicyDelegate
+https://bugs.webkit.org/show_bug.cgi?id=42546
+
+Reviewed by Kenneth Rohde Christiansen.
+
+Unskipped corresponding test cases. Distributed those which still not passing to appropriate groups in Skipped file.
+
+* platform/wk2/Skipped:
+
 2012-09-14  Keishi Hattori  
 
 Make time input lang attribute aware for testing


Modified: trunk/LayoutTests/platform/wk2/Skipped (128599 => 128600)

--- trunk/LayoutTests/platform/wk2/Skipped	2012-09-14 13:08:34 UTC (rev 128599)
+++ trunk/LayoutTests/platform/wk2/Skipped	2012-09-14 13:09:06 UTC (rev 128600)
@@ -330,16 +330,6 @@
 fast/dom/Geolocation/watch.html
 fast/dom/Geolocation/window-close-crash.html
 
-# WebKitTestRunner needs layoutTestController.setCustomPolicyDelegate
-# 
-fast/loader/_javascript_-url-hierarchical-execution.html
-fast/loader/onload-policy-ignore-for-frame.html
-fast/loader/reload-policy-delegate.html
-http/tests/misc/policy-delegate-called-twice.html
-http/tests/misc/redirect-to-external-url.html
-http/tests/security/feed-urls-from-remote.html
-http/tests/download
-
 # WebKitTestRunner needs layoutTestController.setDashboardCompatibilityMode
 # 
 fast/canvas/canvas-gradient-addStop-error.html
@@ -354,6 +344,7 @@
 # 
 fast/css/compare-content-style.html
 fast/frames/frame-display-none-focus.html
+fast/loader/reload-policy-delegate.html
 
 # WebKitTestRunner needs layoutTestController.queueLoad
 # 
@@ -620,6 +611,11 @@
 inspector/geolocation-success.html
 inspector/geolocation-watchPosition.html
 
+# WebFrameLoaderClient::dispatchDecidePolicy methods should consider 
+# 'WKBundlePagePolicyActionPassThrough' policy action 
+# https://bugs.webkit.org/show_bug.cgi?id=95974
+fast/loader/onload-policy-ignore-for-frame.html
+
 ### END OF (1) Classified failures with bug reports
 
 
@@ -869,6 +865,13 @@
 fast/spatial-navigation/snav-iframe-no-scrollable-content.html
 fast/spatial-navigation/snav-imagemap-overlapped-areas.html
 
+# WK2 is missing API for getting header fields from HTTP responses
+# which have to be serialized.
+http/tests/download
+
+# WebFrameLoaderClient::canHandleRequest() has to be implemented.
+http/tests/misc/redirect-to-external-url.html
+
 ### END OF (2) Classified failures without bug reports (yet)
 
 
@@ -1123,6 +1126,9 @@
 fast/loader/file-protocol-fragment.html
 http/tests/loading/pdf-commit-load-callbacks.html
 
+# Times out unexpectedly.
+http/tests/security/feed-urls-from-remote.html
+
 ### END OF (3) Unclassified failures
 
 


Modified: trunk/Tools/ChangeLog (128599 => 128600)

--- trunk/Tools/ChangeLog	2012-09-14 13:08:34 UTC (rev 128599)
+++ trunk/Tools/ChangeLog	2012-09-14 13:09:06 UTC (rev 128600)
@@ -1,3 +1,17 @@
+2012-09-14  Mikhail Pozdnyakov  
+
+WebKitTestRunner needs layoutTestController.setCustomPolicyDelegate
+https://bugs.webkit.org/show_bug.cgi?id=42546
+
+Reviewed by Kenneth Rohde Christiansen.
+
+Exported TestRunner::setCustomPolicyDelegate() method.
+Allowed Policy Delegate dumping even if we're not in 'waitUntilDone' mode.
+
+* WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
+* WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
+(WTR::InjectedBundlePage::decidePolicyForNavigationAction):
+
 2012-09-14  Zan Dobersek  
 
 [GTK] Clear application cache between tests in DumpRenderTree


Modified: trunk/Tools/WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl (128599 => 128600)

--- trunk/Tools/We

[webkit-changes] [128599] trunk/Source/JavaScriptCore

2012-09-14 Thread commit-queue

Title: [128599] trunk/Source/_javascript_Core








Revision 128599
Author commit-qu...@webkit.org
Date 2012-09-14 06:08:34 -0700 (Fri, 14 Sep 2012)


Log Message
[BlackBerry] Switching from Slogger to Slogger2 requires changes in CMakeList of
webkit in order to include libraries of slog2
https://bugs.webkit.org/show_bug.cgi?id=96391

Patch by Parth Patel  on 2012-09-14
Reviewed by Yong Li.

Changes in Cmake files of _javascript_Core of webkit to include slog2 libs in build
files of webkit in response to switching from Slogger to Slogger2.

* shell/PlatformBlackBerry.cmake:

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/shell/PlatformBlackBerry.cmake




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (128598 => 128599)

--- trunk/Source/_javascript_Core/ChangeLog	2012-09-14 13:07:26 UTC (rev 128598)
+++ trunk/Source/_javascript_Core/ChangeLog	2012-09-14 13:08:34 UTC (rev 128599)
@@ -1,3 +1,16 @@
+2012-09-14  Parth Patel  
+
+[BlackBerry] Switching from Slogger to Slogger2 requires changes in CMakeList of 
+webkit in order to include libraries of slog2
+https://bugs.webkit.org/show_bug.cgi?id=96391
+
+Reviewed by Yong Li.
+
+Changes in Cmake files of _javascript_Core of webkit to include slog2 libs in build 
+files of webkit in response to switching from Slogger to Slogger2.
+
+* shell/PlatformBlackBerry.cmake:
+
 2012-09-14  Mark Hahnenberg  
 
 Remove the Zapped BlockState


Modified: trunk/Source/_javascript_Core/shell/PlatformBlackBerry.cmake (128598 => 128599)

--- trunk/Source/_javascript_Core/shell/PlatformBlackBerry.cmake	2012-09-14 13:07:26 UTC (rev 128598)
+++ trunk/Source/_javascript_Core/shell/PlatformBlackBerry.cmake	2012-09-14 13:08:34 UTC (rev 128599)
@@ -1,3 +1,4 @@
+FIND_STAGING_LIBRARY(SLOG2_LIBRARY slog2)
 LIST(APPEND JSC_LIBRARIES
 ${ICUI18N_LIBRARY}
 ${ICUUC_LIBRARY}
@@ -6,6 +7,7 @@
 ${Screen_LIBRARY}
 ${Skia_QNX_LIBRARY}
 ${WebKitPlatform_LIBRARY}
+${SLOG2_LIBRARY}
 )
 
 IF (PROFILING)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [128598] trunk/Source/WebCore

2012-09-14 Thread caseq

Title: [128598] trunk/Source/WebCore








Revision 128598
Author ca...@chromium.org
Date 2012-09-14 06:07:26 -0700 (Fri, 14 Sep 2012)


Log Message
Web Inspector: reuse WebInspector.ProgressIndicator in Audits panel
https://bugs.webkit.org/show_bug.cgi?id=96755

Reviewed by Alexander Pavlov.

- remove AuditProgressMonitor, use WebInspector.ProgressIndicator instead;
- add annotations for a bunch of audit methods;
- simplify control flow -- remove callbacks where possible.

* English.lproj/localizedStrings.js:
* inspector/front-end/AuditLauncherView.js:
(WebInspector.AuditLauncherView):
(WebInspector.AuditLauncherView.prototype._setAuditRunning):
(WebInspector.AuditLauncherView.prototype._launchButtonClicked.onAuditStarted):
(WebInspector.AuditLauncherView.prototype._launchButtonClicked):
(WebInspector.AuditLauncherView.prototype._createLauncherUI):
(WebInspector.AuditLauncherView.prototype._updateResourceProgress):
(WebInspector.AuditLauncherView.prototype._updateButton):
* inspector/front-end/AuditRules.js:
(WebInspector.AuditRules.GzipRule.prototype.doRun):
(WebInspector.AuditRules.CombineExternalResourcesRule.prototype.doRun):
(WebInspector.AuditRules.MinimizeDnsLookupsRule.prototype.doRun):
(WebInspector.AuditRules.UnusedCssRule.prototype.doRun.evalCallback.selectorsCallback):
(WebInspector.AuditRules.UnusedCssRule.prototype.doRun.evalCallback.documentLoaded):
(WebInspector.AuditRules.UnusedCssRule.prototype.doRun.evalCallback):
(WebInspector.AuditRules.UnusedCssRule.prototype.doRun.styleSheetCallback):
(WebInspector.AuditRules.UnusedCssRule.prototype.doRun.allStylesCallback):
(WebInspector.AuditRules.UnusedCssRule.prototype.doRun):
(WebInspector.AuditRules.CacheControlRule.prototype.doRun):
(WebInspector.AuditRules.ImageDimensionsRule.prototype.doRun):
(WebInspector.AuditRules.CssInHeadRule.prototype.doRun):
(WebInspector.AuditRules.CssInHeadRule.prototype.doRun.externalStylesheetsReceived):
(WebInspector.AuditRules.CssInHeadRule.prototype.doRun.inlineStylesReceived):
(WebInspector.AuditRules.CssInHeadRule.prototype.doRun.onDocumentAvailable):
(WebInspector.AuditRules.StylesScriptsOrderRule.prototype.doRun):
(WebInspector.AuditRules.StylesScriptsOrderRule.prototype.doRun.cssBeforeInlineReceived):
(WebInspector.AuditRules.StylesScriptsOrderRule.prototype.doRun.lateStylesReceived):
(WebInspector.AuditRules.StylesScriptsOrderRule.prototype.doRun.onDocumentAvailable):
(WebInspector.AuditRules.CSSRuleBase.prototype.doRun.sheetsCallback):
(WebInspector.AuditRules.CSSRuleBase.prototype._visitStyleSheet.sheetCallback):
(WebInspector.AuditRules.CSSRuleBase.prototype._visitStyleSheet):
(WebInspector.AuditRules.CookieRuleBase.prototype.doRun.resultCallback):
(WebInspector.AuditRules.CookieRuleBase.prototype.doRun):
* inspector/front-end/AuditsPanel.js:
(WebInspector.AuditsPanel):
(WebInspector.AuditsPanel.prototype._executeAudit.ruleResultReadyCallback):
(WebInspector.AuditsPanel.prototype._executeAudit):
(WebInspector.AuditsPanel.prototype._auditFinishedCallback):
(WebInspector.AuditsPanel.prototype.initiateAudit.else.onReload):
(WebInspector.AuditsPanel.prototype.initiateAudit):
(WebInspector.AuditCategory.prototype.run):
(WebInspector.AuditRule.prototype.run):
(WebInspector.AuditRule.prototype.doRun):
* inspector/front-end/ProgressBar.js:
(WebInspector.Progress.prototype.worked):
(WebInspector.ProgressIndicator):
(WebInspector.ProgressIndicator.prototype.cancel):
(WebInspector.ProgressIndicator.prototype.setWorked):
(WebInspector.ProgressIndicator.prototype.worked):
(WebInspector.SubProgress.prototype.setWorked):
(WebInspector.SubProgress.prototype.worked):
* inspector/front-end/auditsPanel.css:
(.audit-launcher-view .progress-bar-container):
(.audit-launcher-view .progress-bar-container .progress-bar-stop-button):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/English.lproj/localizedStrings.js
trunk/Source/WebCore/inspector/front-end/AuditLauncherView.js
trunk/Source/WebCore/inspector/front-end/AuditRules.js
trunk/Source/WebCore/inspector/front-end/AuditsPanel.js
trunk/Source/WebCore/inspector/front-end/ProgressBar.js
trunk/Source/WebCore/inspector/front-end/auditsPanel.css




Diff

Modified: trunk/Source/WebCore/ChangeLog (128597 => 128598)

--- trunk/Source/WebCore/ChangeLog	2012-09-14 12:45:29 UTC (rev 128597)
+++ trunk/Source/WebCore/ChangeLog	2012-09-14 13:07:26 UTC (rev 128598)
@@ -1,3 +1,70 @@
+2012-09-14  Andrey Kosyakov  
+
+Web Inspector: reuse WebInspector.ProgressIndicator in Audits panel
+https://bugs.webkit.org/show_bug.cgi?id=96755
+
+Reviewed by Alexander Pavlov.
+
+- remove AuditProgressMonitor, use WebInspector.ProgressIndicator instead;
+- add annotations for a bunch of audit methods;
+- simplify control flow -- remove callbacks where possible.
+
+* English.lproj/localizedStrings.js:
+* inspector/front-end/AuditLauncherView.js:
+(WebInspector.AuditLauncherView):
+(WebInspector.AuditLau

[webkit-changes] [128597] trunk/Source/WebCore

2012-09-14 Thread vsevik

Title: [128597] trunk/Source/WebCore








Revision 128597
Author vse...@chromium.org
Date 2012-09-14 05:45:29 -0700 (Fri, 14 Sep 2012)


Log Message
Unreviewed inspector ui polish.

* inspector/front-end/inspector.css:
(#floating-status-bar-resizer):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/inspector.css




Diff

Modified: trunk/Source/WebCore/ChangeLog (128596 => 128597)

--- trunk/Source/WebCore/ChangeLog	2012-09-14 12:43:18 UTC (rev 128596)
+++ trunk/Source/WebCore/ChangeLog	2012-09-14 12:45:29 UTC (rev 128597)
@@ -1,5 +1,12 @@
 2012-09-14  Vsevolod Vlasov  
 
+Unreviewed inspector ui polish.
+
+* inspector/front-end/inspector.css:
+(#floating-status-bar-resizer):
+
+2012-09-14  Vsevolod Vlasov  
+
 Web Inspector: Get rid of setting values to innerHTML in inspector front-end.
 https://bugs.webkit.org/show_bug.cgi?id=96758
 


Modified: trunk/Source/WebCore/inspector/front-end/inspector.css (128596 => 128597)

--- trunk/Source/WebCore/inspector/front-end/inspector.css	2012-09-14 12:43:18 UTC (rev 128596)
+++ trunk/Source/WebCore/inspector/front-end/inspector.css	2012-09-14 12:45:29 UTC (rev 128597)
@@ -572,6 +572,7 @@
 content: url(Images/statusbarResizerVertical.png);
 margin-top: 7px;
 pointer-events: none;
+height: 8px;
 }
 
 #panel-status-bar {






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [128596] trunk

2012-09-14 Thread zandobersek

Title: [128596] trunk








Revision 128596
Author zandober...@gmail.com
Date 2012-09-14 05:43:18 -0700 (Fri, 14 Sep 2012)


Log Message
[GTK] Clear application cache between tests in DumpRenderTree
https://bugs.webkit.org/show_bug.cgi?id=96543

Reviewed by Philippe Normand.

Source/WebKit/gtk: 

Add a method to the DumpRenderTreeSupportGtk class that upon calling
clears the application cache and vacuums the database file.

* WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
(DumpRenderTreeSupportGtk::clearApplicationCache):
* WebCoreSupport/DumpRenderTreeSupportGtk.h:
(DumpRenderTreeSupportGtk):

Tools: 

Call the new DumpRenderTreeSupportGtk method to clear application cache
after each test in DumpRenderTree.

Set the XDG_CACHE_HOME environment variable when running DumpRenderTree
as well. It's now being set in XvfbDriver._start so that each driver is assigned
a cache directory that's constructed out of the driver's name and its worker
number. These directories are located in the layout tests results directory.
At least on the builders this ensures a driver-specific empty cache directory
with each test run.

* DumpRenderTree/gtk/DumpRenderTree.cpp:
(runTest):
* Scripts/webkitpy/layout_tests/port/gtk.py:
(GtkPort.setup_environ_for_server):
* Scripts/webkitpy/layout_tests/port/xvfbdriver.py:
(XvfbDriver._start):

Modified Paths

trunk/Source/WebKit/gtk/ChangeLog
trunk/Source/WebKit/gtk/WebCoreSupport/DumpRenderTreeSupportGtk.cpp
trunk/Source/WebKit/gtk/WebCoreSupport/DumpRenderTreeSupportGtk.h
trunk/Tools/ChangeLog
trunk/Tools/DumpRenderTree/gtk/DumpRenderTree.cpp
trunk/Tools/Scripts/webkitpy/layout_tests/port/gtk.py
trunk/Tools/Scripts/webkitpy/layout_tests/port/xvfbdriver.py




Diff

Modified: trunk/Source/WebKit/gtk/ChangeLog (128595 => 128596)

--- trunk/Source/WebKit/gtk/ChangeLog	2012-09-14 12:42:50 UTC (rev 128595)
+++ trunk/Source/WebKit/gtk/ChangeLog	2012-09-14 12:43:18 UTC (rev 128596)
@@ -1,3 +1,18 @@
+2012-09-14  Zan Dobersek  
+
+[GTK] Clear application cache between tests in DumpRenderTree
+https://bugs.webkit.org/show_bug.cgi?id=96543
+
+Reviewed by Philippe Normand.
+
+Add a method to the DumpRenderTreeSupportGtk class that upon calling
+clears the application cache and vacuums the database file.
+
+* WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
+(DumpRenderTreeSupportGtk::clearApplicationCache):
+* WebCoreSupport/DumpRenderTreeSupportGtk.h:
+(DumpRenderTreeSupportGtk):
+
 2012-09-13  Sheriff Bot  
 
 Unreviewed, rolling out r128453.


Modified: trunk/Source/WebKit/gtk/WebCoreSupport/DumpRenderTreeSupportGtk.cpp (128595 => 128596)

--- trunk/Source/WebKit/gtk/WebCoreSupport/DumpRenderTreeSupportGtk.cpp	2012-09-14 12:42:50 UTC (rev 128595)
+++ trunk/Source/WebKit/gtk/WebCoreSupport/DumpRenderTreeSupportGtk.cpp	2012-09-14 12:43:18 UTC (rev 128596)
@@ -26,6 +26,7 @@
 #include "AXObjectCache.h"
 #include "AccessibilityObject.h"
 #include "AnimationController.h"
+#include "ApplicationCacheStorage.h"
 #include "CSSComputedStyleDeclaration.h"
 #include "Chrome.h"
 #include "ChromeClientGtk.h"
@@ -811,3 +812,9 @@
 {
 memoryCache()->evictResources();
 }
+
+void DumpRenderTreeSupportGtk::clearApplicationCache()
+{
+cacheStorage().empty();
+cacheStorage().vacuumDatabaseFile();
+}


Modified: trunk/Source/WebKit/gtk/WebCoreSupport/DumpRenderTreeSupportGtk.h (128595 => 128596)

--- trunk/Source/WebKit/gtk/WebCoreSupport/DumpRenderTreeSupportGtk.h	2012-09-14 12:42:50 UTC (rev 128595)
+++ trunk/Source/WebKit/gtk/WebCoreSupport/DumpRenderTreeSupportGtk.h	2012-09-14 12:43:18 UTC (rev 128596)
@@ -128,6 +128,7 @@
 static void resetTrackedRepaints(WebKitWebFrame*);
 
 static void clearMemoryCache();
+static void clearApplicationCache();
 
 private:
 static bool s_drtRun;


Modified: trunk/Tools/ChangeLog (128595 => 128596)

--- trunk/Tools/ChangeLog	2012-09-14 12:42:50 UTC (rev 128595)
+++ trunk/Tools/ChangeLog	2012-09-14 12:43:18 UTC (rev 128596)
@@ -1,3 +1,27 @@
+2012-09-14  Zan Dobersek  
+
+[GTK] Clear application cache between tests in DumpRenderTree
+https://bugs.webkit.org/show_bug.cgi?id=96543
+
+Reviewed by Philippe Normand.
+
+Call the new DumpRenderTreeSupportGtk method to clear application cache
+after each test in DumpRenderTree.
+
+Set the XDG_CACHE_HOME environment variable when running DumpRenderTree
+as well. It's now being set in XvfbDriver._start so that each driver is assigned
+a cache directory that's constructed out of the driver's name and its worker
+number. These directories are located in the layout tests results directory.
+At least on the builders this ensures a driver-specific empty cache directory
+with each test run.
+
+* DumpRenderTree/gtk/DumpRenderTree.cpp:
+(runTest):
+* Scripts/webkitpy/layout_tests/port/gtk.py:
+(GtkPort.setup_environ_for_server):
+

[webkit-changes] [128595] trunk/Source/WebCore

2012-09-14 Thread vsevik

Title: [128595] trunk/Source/WebCore








Revision 128595
Author vse...@chromium.org
Date 2012-09-14 05:42:50 -0700 (Fri, 14 Sep 2012)


Log Message
Web Inspector: Get rid of setting values to innerHTML in inspector front-end.
https://bugs.webkit.org/show_bug.cgi?id=96758

Reviewed by Alexander Pavlov.

Removed innerHTML from WebGLProfileView.

* inspector/front-end/WebGLProfileView.js:
(WebInspector.WebGLProfileView.prototype._showTraceLog):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/WebGLProfileView.js




Diff

Modified: trunk/Source/WebCore/ChangeLog (128594 => 128595)

--- trunk/Source/WebCore/ChangeLog	2012-09-14 12:40:27 UTC (rev 128594)
+++ trunk/Source/WebCore/ChangeLog	2012-09-14 12:42:50 UTC (rev 128595)
@@ -1,3 +1,15 @@
+2012-09-14  Vsevolod Vlasov  
+
+Web Inspector: Get rid of setting values to innerHTML in inspector front-end.
+https://bugs.webkit.org/show_bug.cgi?id=96758
+
+Reviewed by Alexander Pavlov.
+
+Removed innerHTML from WebGLProfileView.
+
+* inspector/front-end/WebGLProfileView.js:
+(WebInspector.WebGLProfileView.prototype._showTraceLog):
+
 2012-09-14  Keishi Hattori  
 
 Make time input lang attribute aware for testing


Modified: trunk/Source/WebCore/inspector/front-end/WebGLProfileView.js (128594 => 128595)

--- trunk/Source/WebCore/inspector/front-end/WebGLProfileView.js	2012-09-14 12:40:27 UTC (rev 128594)
+++ trunk/Source/WebCore/inspector/front-end/WebGLProfileView.js	2012-09-14 12:42:50 UTC (rev 128595)
@@ -99,7 +99,7 @@
 {
 function didReceiveTraceLog(error, traceLog)
 {
-this._traceLogElement.innerHTML = "";
+this._traceLogElement.textContent = "";
 if (!traceLog)
 return;
 var calls = traceLog.calls;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [128594] trunk

2012-09-14 Thread tkent

Title: [128594] trunk








Revision 128594
Author tk...@chromium.org
Date 2012-09-14 05:40:27 -0700 (Fri, 14 Sep 2012)


Log Message
Make time input lang attribute aware for testing
https://bugs.webkit.org/show_bug.cgi?id=96728

Patch by Keishi Hattori  on 2012-09-14
Reviewed by Kent Tamura.

Source/WebCore:

This patch implements partial lang attribute support for input type=time
that turns on only when enabled through InternalSettings.

Test: fast/forms/time-multiple-fields/time-multiple-fields-localization.html

* dom/Document.cpp:
(WebCore::Document::getLocalizer): Returns a localizer for a given locale. Localizers are cached for repeated use.
(WebCore):
* dom/Document.h:
(WebCore):
(Document):
* html/TimeInputType.cpp:
(WebCore::TimeInputType::updateInnerTextValue): Use the locale for the input element.
* html/shadow/DateTimeEditElement.cpp:
(DateTimeEditBuilder):
(WebCore::DateTimeEditBuilder::DateTimeEditBuilder):
(WebCore::DateTimeEditBuilder::visitField):
(WebCore::DateTimeEditElement::layout):
(WebCore::DateTimeEditElement::setValueAsDate):
(WebCore::DateTimeEditElement::setEmptyValue):
* html/shadow/DateTimeEditElement.h:
(WebCore):
(DateTimeEditElement):

Source/WebKit/chromium:

* tests/LocalizedDateICUTest.cpp:
(LocalizedDateICUTest::localizedDateFormatText):
(LocalizedDateICUTest::localizedShortDateFormatText):

LayoutTests:

* fast/forms/resources/common.js:
(getUserAgentShadowTextContent): Used to get the text inside an input element.
* fast/forms/time-multiple-fields/time-multiple-fields-localization.html: Added.
* platform/chromium-mac/fast/forms/time-multiple-fields/time-multiple-fields-localization-expected.txt: Added.
* platform/chromium/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/forms/resources/common.js
trunk/LayoutTests/platform/chromium/TestExpectations
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/Document.cpp
trunk/Source/WebCore/dom/Document.h
trunk/Source/WebCore/html/TimeInputType.cpp
trunk/Source/WebCore/html/shadow/DateTimeEditElement.cpp
trunk/Source/WebCore/html/shadow/DateTimeEditElement.h
trunk/Source/WebKit/chromium/ChangeLog


Added Paths

trunk/LayoutTests/fast/forms/time-multiple-fields/time-multiple-fields-localization.html
trunk/LayoutTests/platform/chromium-mac/fast/forms/time-multiple-fields/time-multiple-fields-localization-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (128593 => 128594)

--- trunk/LayoutTests/ChangeLog	2012-09-14 12:34:26 UTC (rev 128593)
+++ trunk/LayoutTests/ChangeLog	2012-09-14 12:40:27 UTC (rev 128594)
@@ -1,3 +1,16 @@
+2012-09-14  Keishi Hattori  
+
+Make time input lang attribute aware for testing
+https://bugs.webkit.org/show_bug.cgi?id=96728
+
+Reviewed by Kent Tamura.
+
+* fast/forms/resources/common.js:
+(getUserAgentShadowTextContent): Used to get the text inside an input element.
+* fast/forms/time-multiple-fields/time-multiple-fields-localization.html: Added.
+* platform/chromium-mac/fast/forms/time-multiple-fields/time-multiple-fields-localization-expected.txt: Added.
+* platform/chromium/TestExpectations:
+
 2012-09-14  Yoshifumi Inoue  
 
 REGRESSION(r128575): fast/forms/time-multiple-fields/time-multiple-fields-preserve-value-after-history-back.html is failed on Chromium-Win


Modified: trunk/LayoutTests/fast/forms/resources/common.js (128593 => 128594)

--- trunk/LayoutTests/fast/forms/resources/common.js	2012-09-14 12:34:26 UTC (rev 128593)
+++ trunk/LayoutTests/fast/forms/resources/common.js	2012-09-14 12:40:27 UTC (rev 128594)
@@ -115,3 +115,7 @@
 if (window.eventSender)
 eventSender.mouseMoveTo(listbox.offsetLeft + border, listbox.offsetTop + y - window.pageYOffset);
 }
+
+function getUserAgentShadowTextContent(element) {
+return internals.youngestShadowRoot(element).textContent;
+};


Added: trunk/LayoutTests/fast/forms/time-multiple-fields/time-multiple-fields-localization.html (0 => 128594)

--- trunk/LayoutTests/fast/forms/time-multiple-fields/time-multiple-fields-localization.html	(rev 0)
+++ trunk/LayoutTests/fast/forms/time-multiple-fields/time-multiple-fields-localization.html	2012-09-14 12:40:27 UTC (rev 128594)
@@ -0,0 +1,30 @@
+
+
+
+
+
+if (window.internals)
+internals.settings.setLangAttributeAwareFormControlUIEnabled(true);
+
+
+
+
+
+
+
+
+
+
+
+description("Tests the time format for various locales.", true);
+debug("The following lines depend on the locale data in the system.");
+var inputs = document.getElementsByTagName("input");
+for (var i = 0; i < inputs.length; ++i) {
+ debug(inputs[i].lang + ': ' + getUserAgentShadowTextContent(inputs[i]));
+}
+
+

[webkit-changes] [128593] trunk/Source/WebCore

2012-09-14 Thread tkent

Title: [128593] trunk/Source/WebCore








Revision 128593
Author tk...@chromium.org
Date 2012-09-14 05:34:26 -0700 (Fri, 14 Sep 2012)


Log Message
Unreviewed, rolling out r128566.
http://trac.webkit.org/changeset/128566
https://bugs.webkit.org/show_bug.cgi?id=96760

Assertion failure in http/tests/websocket/tests/hybi/workers
/close-code-and-reason.html (Requested by tkent1 on #webkit).

Patch by Sheriff Bot  on 2012-09-14

* bindings/v8/DOMData.cpp:
(WebCore::DOMData::getCurrentStore):
* bindings/v8/ScopedPersistent.h:
* bindings/v8/ScriptController.cpp:
(WebCore::ScriptController::resetIsolatedWorlds):
(WebCore::ScriptController::evaluateInIsolatedWorld):
(WebCore::ScriptController::currentWorldContext):
* bindings/v8/V8Binding.cpp:
(WebCore::perContextDataForCurrentWorld):
* bindings/v8/V8DOMWindowShell.cpp:
(WebCore::setIsolatedWorldField):
(WebCore::V8DOMWindowShell::enteredIsolatedWorldContext):
(WebCore::V8DOMWindowShell::destroyIsolatedShell):
(WebCore):
(WebCore::isolatedContextWeakCallback):
(WebCore::V8DOMWindowShell::disposeContext):
(WebCore::V8DOMWindowShell::initializeIfNeeded):
(WebCore::V8DOMWindowShell::setIsolatedWorldSecurityOrigin):
* bindings/v8/V8DOMWindowShell.h:
(V8DOMWindowShell):
(WebCore::V8DOMWindowShell::getEntered):
* bindings/v8/V8DOMWrapper.h:
(WebCore::V8DOMWrapper::getCachedWrapper):
* bindings/v8/WorldContextHandle.cpp:
(WebCore::WorldContextHandle::WorldContextHandle):
* bindings/v8/custom/V8DocumentCustom.cpp:
(WebCore::toV8):
* bindings/v8/custom/V8HTMLDocumentCustom.cpp:
(WebCore::toV8):
* bindings/v8/custom/V8SVGDocumentCustom.cpp:
(WebCore::toV8):
* bindings/v8/custom/V8XMLHttpRequestConstructor.cpp:
(WebCore::V8XMLHttpRequest::constructorCallback):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/v8/DOMData.cpp
trunk/Source/WebCore/bindings/v8/ScopedPersistent.h
trunk/Source/WebCore/bindings/v8/ScriptController.cpp
trunk/Source/WebCore/bindings/v8/V8Binding.cpp
trunk/Source/WebCore/bindings/v8/V8DOMWindowShell.cpp
trunk/Source/WebCore/bindings/v8/V8DOMWindowShell.h
trunk/Source/WebCore/bindings/v8/V8DOMWrapper.h
trunk/Source/WebCore/bindings/v8/WorldContextHandle.cpp
trunk/Source/WebCore/bindings/v8/custom/V8DocumentCustom.cpp
trunk/Source/WebCore/bindings/v8/custom/V8HTMLDocumentCustom.cpp
trunk/Source/WebCore/bindings/v8/custom/V8SVGDocumentCustom.cpp
trunk/Source/WebCore/bindings/v8/custom/V8XMLHttpRequestConstructor.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (128592 => 128593)

--- trunk/Source/WebCore/ChangeLog	2012-09-14 12:19:59 UTC (rev 128592)
+++ trunk/Source/WebCore/ChangeLog	2012-09-14 12:34:26 UTC (rev 128593)
@@ -1,3 +1,46 @@
+2012-09-14  Sheriff Bot  
+
+Unreviewed, rolling out r128566.
+http://trac.webkit.org/changeset/128566
+https://bugs.webkit.org/show_bug.cgi?id=96760
+
+Assertion failure in http/tests/websocket/tests/hybi/workers
+/close-code-and-reason.html (Requested by tkent1 on #webkit).
+
+* bindings/v8/DOMData.cpp:
+(WebCore::DOMData::getCurrentStore):
+* bindings/v8/ScopedPersistent.h:
+* bindings/v8/ScriptController.cpp:
+(WebCore::ScriptController::resetIsolatedWorlds):
+(WebCore::ScriptController::evaluateInIsolatedWorld):
+(WebCore::ScriptController::currentWorldContext):
+* bindings/v8/V8Binding.cpp:
+(WebCore::perContextDataForCurrentWorld):
+* bindings/v8/V8DOMWindowShell.cpp:
+(WebCore::setIsolatedWorldField):
+(WebCore::V8DOMWindowShell::enteredIsolatedWorldContext):
+(WebCore::V8DOMWindowShell::destroyIsolatedShell):
+(WebCore):
+(WebCore::isolatedContextWeakCallback):
+(WebCore::V8DOMWindowShell::disposeContext):
+(WebCore::V8DOMWindowShell::initializeIfNeeded):
+(WebCore::V8DOMWindowShell::setIsolatedWorldSecurityOrigin):
+* bindings/v8/V8DOMWindowShell.h:
+(V8DOMWindowShell):
+(WebCore::V8DOMWindowShell::getEntered):
+* bindings/v8/V8DOMWrapper.h:
+(WebCore::V8DOMWrapper::getCachedWrapper):
+* bindings/v8/WorldContextHandle.cpp:
+(WebCore::WorldContextHandle::WorldContextHandle):
+* bindings/v8/custom/V8DocumentCustom.cpp:
+(WebCore::toV8):
+* bindings/v8/custom/V8HTMLDocumentCustom.cpp:
+(WebCore::toV8):
+* bindings/v8/custom/V8SVGDocumentCustom.cpp:
+(WebCore::toV8):
+* bindings/v8/custom/V8XMLHttpRequestConstructor.cpp:
+(WebCore::V8XMLHttpRequest::constructorCallback):
+
 2012-09-14  Vsevolod Vlasov  
 
 Web Inspector: Fix front end closure compilation errors.


Modified: trunk/Source/WebCore/bindings/v8/DOMData.cpp (128592 => 128593)

--- trunk/Source/WebCore/bindings/v8/DOMData.cpp	2012-09-14 12:19:59 UTC (rev 128592)
+++ trunk/Source/WebCore/bindings/v8/DOMData.cpp	2012-09-14 12:34:26 UTC (rev 128593)
@@ -43,9 +43,9 @@
 V8PerIsolateData* data = ""
 if (UNLIKE

[webkit-changes] [128592] trunk/Source/WebCore

2012-09-14 Thread vsevik

Title: [128592] trunk/Source/WebCore








Revision 128592
Author vse...@chromium.org
Date 2012-09-14 05:19:59 -0700 (Fri, 14 Sep 2012)


Log Message
Web Inspector: Fix front end closure compilation errors.
https://bugs.webkit.org/show_bug.cgi?id=96753

Reviewed by Alexander Pavlov.

Closure compilation fix.
Also fixed wrong parameters passed to _javascript_Source constructor from CompilerScriptMapping.

* inspector/front-end/CompilerScriptMapping.js:
* inspector/front-end/Resource.js:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/CompilerScriptMapping.js
trunk/Source/WebCore/inspector/front-end/Resource.js




Diff

Modified: trunk/Source/WebCore/ChangeLog (128591 => 128592)

--- trunk/Source/WebCore/ChangeLog	2012-09-14 12:06:58 UTC (rev 128591)
+++ trunk/Source/WebCore/ChangeLog	2012-09-14 12:19:59 UTC (rev 128592)
@@ -1,3 +1,16 @@
+2012-09-14  Vsevolod Vlasov  
+
+Web Inspector: Fix front end closure compilation errors.
+https://bugs.webkit.org/show_bug.cgi?id=96753
+
+Reviewed by Alexander Pavlov.
+
+Closure compilation fix.
+Also fixed wrong parameters passed to _javascript_Source constructor from CompilerScriptMapping.
+
+* inspector/front-end/CompilerScriptMapping.js:
+* inspector/front-end/Resource.js:
+
 2012-09-14  Andrei Poenaru  
 
 Web Inspector: Display Named Flows in the "CSS Named Flows" drawer


Modified: trunk/Source/WebCore/inspector/front-end/CompilerScriptMapping.js (128591 => 128592)

--- trunk/Source/WebCore/inspector/front-end/CompilerScriptMapping.js	2012-09-14 12:06:58 UTC (rev 128591)
+++ trunk/Source/WebCore/inspector/front-end/CompilerScriptMapping.js	2012-09-14 12:19:59 UTC (rev 128592)
@@ -84,7 +84,7 @@
  */
 addScript: function(script)
 {
-var originalUISourceCode = new WebInspector._javascript_Source(script.sourceURL, null, script, this, true);
+var originalUISourceCode = new WebInspector._javascript_Source(script.sourceURL, null, script, true);
 this._originalUISourceCodeForScriptId[script.scriptId] = originalUISourceCode;
 this._scriptForOriginalUISource.put(originalUISourceCode, script);
 this._workspace.project().addUISourceCode(originalUISourceCode);


Modified: trunk/Source/WebCore/inspector/front-end/Resource.js (128591 => 128592)

--- trunk/Source/WebCore/inspector/front-end/Resource.js	2012-09-14 12:06:58 UTC (rev 128591)
+++ trunk/Source/WebCore/inspector/front-end/Resource.js	2012-09-14 12:19:59 UTC (rev 128592)
@@ -311,7 +311,7 @@
 this._contentRequested = true;
 
 /**
- * @param {string} content
+ * @param {?string} content
  * @param {boolean} contentEncoded
  */
 function contentLoaded(content, contentEncoded)
@@ -339,7 +339,7 @@
 
 if (this.request) {
 /**
- * @param {string} content
+ * @param {?string} content
  * @param {boolean} contentEncoded
  * @param {string} mimeType
  */






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [128591] trunk/LayoutTests

2012-09-14 Thread yosin

Title: [128591] trunk/LayoutTests








Revision 128591
Author yo...@chromium.org
Date 2012-09-14 05:06:58 -0700 (Fri, 14 Sep 2012)


Log Message
REGRESSION(r128575): fast/forms/time-multiple-fields/time-multiple-fields-preserve-value-after-history-back.html is failed on Chromium-Win
https://bugs.webkit.org/show_bug.cgi?id=96754

Reviewed by Kent Tamura.

The root cause of this failure is Chromium-Win port has a second field
event if step=60 due by Windows platform API.

This patch changes test sample to have a second field to get rid of
such difference.

* fast/forms/time-multiple-fields/time-multiple-fields-preserve-value-after-history-back-expected.txt: Updates expectation.
* fast/forms/time-multiple-fields/time-multiple-fields-preserve-value-after-history-back.html: Changed to add "step=1" to
test sample and to add a second field value to expectation.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/forms/time-multiple-fields/time-multiple-fields-preserve-value-after-history-back-expected.txt
trunk/LayoutTests/fast/forms/time-multiple-fields/time-multiple-fields-preserve-value-after-history-back.html




Diff

Modified: trunk/LayoutTests/ChangeLog (128590 => 128591)

--- trunk/LayoutTests/ChangeLog	2012-09-14 12:05:44 UTC (rev 128590)
+++ trunk/LayoutTests/ChangeLog	2012-09-14 12:06:58 UTC (rev 128591)
@@ -1,3 +1,20 @@
+2012-09-14  Yoshifumi Inoue  
+
+REGRESSION(r128575): fast/forms/time-multiple-fields/time-multiple-fields-preserve-value-after-history-back.html is failed on Chromium-Win
+https://bugs.webkit.org/show_bug.cgi?id=96754
+
+Reviewed by Kent Tamura.
+
+The root cause of this failure is Chromium-Win port has a second field
+event if step=60 due by Windows platform API.
+
+This patch changes test sample to have a second field to get rid of
+such difference.
+
+* fast/forms/time-multiple-fields/time-multiple-fields-preserve-value-after-history-back-expected.txt: Updates expectation.
+* fast/forms/time-multiple-fields/time-multiple-fields-preserve-value-after-history-back.html: Changed to add "step=1" to
+test sample and to add a second field value to expectation.
+
 2012-09-14  Christophe Dumez  
 
 [WK2][WKTR] TestRunner is not dumping some frame load callbacks information


Modified: trunk/LayoutTests/fast/forms/time-multiple-fields/time-multiple-fields-preserve-value-after-history-back-expected.txt (128590 => 128591)

--- trunk/LayoutTests/fast/forms/time-multiple-fields/time-multiple-fields-preserve-value-after-history-back-expected.txt	2012-09-14 12:05:44 UTC (rev 128590)
+++ trunk/LayoutTests/fast/forms/time-multiple-fields/time-multiple-fields-preserve-value-after-history-back-expected.txt	2012-09-14 12:06:58 UTC (rev 128591)
@@ -6,11 +6,11 @@
 Went back to a page. Checking a form control which had a full value:
 PASS "01:01" is "01:01"
 Went back to a page. Checking a form control which had a partial value:
-PASS "01:-- AM" is "01:-- AM"
+PASS "01:--:-- AM" is "01:--:-- AM"
 Went forward to a page. Checking a form control which had a full value:
 PASS "02:02" is "02:02"
 Went forward to a page. Checking a form control which had a partial value:
-PASS "--:59 --" is "--:59 --"
+PASS "--:59:-- --" is "--:59:-- --"
 
 PASS successfullyParsed is true
 


Modified: trunk/LayoutTests/fast/forms/time-multiple-fields/time-multiple-fields-preserve-value-after-history-back.html (128590 => 128591)

--- trunk/LayoutTests/fast/forms/time-multiple-fields/time-multiple-fields-preserve-value-after-history-back.html	2012-09-14 12:05:44 UTC (rev 128590)
+++ trunk/LayoutTests/fast/forms/time-multiple-fields/time-multiple-fields-preserve-value-after-history-back.html	2012-09-14 12:06:58 UTC (rev 128591)
@@ -6,7 +6,7 @@
 
 
 
-
+

[webkit-changes] [128590] trunk/Source/WebCore

2012-09-14 Thread commit-queue

Title: [128590] trunk/Source/WebCore








Revision 128590
Author commit-qu...@webkit.org
Date 2012-09-14 05:05:44 -0700 (Fri, 14 Sep 2012)


Log Message
Web Inspector: Display Named Flows in the "CSS Named Flows" drawer
https://bugs.webkit.org/show_bug.cgi?id=90871

Patch by Andrei Poenaru  on 2012-09-14
Reviewed by Alexander Pavlov.

Implemented CSS Regions support in WebInspector as a drawer. (feature is under an experimental flag)

* English.lproj/localizedStrings.js:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* inspector/compile-front-end.py:
* inspector/front-end/CSSNamedFlowCollectionsView.js: Added.
(WebInspector.CSSNamedFlowCollectionsView):
(WebInspector.CSSNamedFlowCollectionsView.prototype.showInDrawer):
(WebInspector.CSSNamedFlowCollectionsView.prototype.reset):
(WebInspector.CSSNamedFlowCollectionsView.prototype._setDocument):
(WebInspector.CSSNamedFlowCollectionsView.prototype._documentUpdated):
(WebInspector.CSSNamedFlowCollectionsView.prototype._setSidebarHasContent):
(WebInspector.CSSNamedFlowCollectionsView.prototype._appendNamedFlow):
(WebInspector.CSSNamedFlowCollectionsView.prototype._removeNamedFlow):
(WebInspector.CSSNamedFlowCollectionsView.prototype._updateNamedFlow):
(WebInspector.CSSNamedFlowCollectionsView.prototype._resetNamedFlows):
(WebInspector.CSSNamedFlowCollectionsView.prototype._namedFlowCreated):
(WebInspector.CSSNamedFlowCollectionsView.prototype._namedFlowRemoved):
(WebInspector.CSSNamedFlowCollectionsView.prototype._regionLayoutUpdated):
(WebInspector.CSSNamedFlowCollectionsView.prototype._hashNamedFlow):
(WebInspector.CSSNamedFlowCollectionsView.prototype._showNamedFlow):
(WebInspector.CSSNamedFlowCollectionsView.prototype._selectNamedFlowInSidebar):
(WebInspector.CSSNamedFlowCollectionsView.prototype._selectedNodeChanged):
(WebInspector.CSSNamedFlowCollectionsView.prototype._showNamedFlowForNode):
(WebInspector.CSSNamedFlowCollectionsView.prototype.wasShown):
(WebInspector.CSSNamedFlowCollectionsView.prototype.willHide):
* inspector/front-end/ElementsPanel.js:
(WebInspector.ElementsPanel.prototype._contextMenuEventFired.set get var):
(WebInspector.ElementsPanel.prototype._showNamedFlowCollections):
* inspector/front-end/Images/namedFlowOverflow.png: Added.
* inspector/front-end/Settings.js:
(WebInspector.ExperimentsSettings):
* inspector/front-end/WebKit.qrc:
* inspector/front-end/cssNamedFlows.css: Added.
(.css-named-flow-collections-view .split-view-sidebar-left):
(.css-named-flow-collections-view .tabbed-pane-header):
(.css-named-flow-collections-view .info):
(.css-named-flow-collections-view .split-view-sidebar-left .sidebar-content):
(.css-named-flow-collections-view .split-view-sidebar-left .selection):
(.css-named-flow-collections-view .split-view-contents .title):
(.css-named-flow-collections-view .split-view-sidebar-left .named-flow-overflow::before):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/English.lproj/localizedStrings.js
trunk/Source/WebCore/WebCore.gypi
trunk/Source/WebCore/WebCore.vcproj/WebCore.vcproj
trunk/Source/WebCore/inspector/compile-front-end.py
trunk/Source/WebCore/inspector/front-end/ElementsPanel.js
trunk/Source/WebCore/inspector/front-end/Settings.js
trunk/Source/WebCore/inspector/front-end/WebKit.qrc


Added Paths

trunk/Source/WebCore/inspector/front-end/CSSNamedFlowCollectionsView.js
trunk/Source/WebCore/inspector/front-end/Images/namedFlowOverflow.png
trunk/Source/WebCore/inspector/front-end/cssNamedFlows.css




Diff

Modified: trunk/Source/WebCore/ChangeLog (128589 => 128590)

--- trunk/Source/WebCore/ChangeLog	2012-09-14 11:57:47 UTC (rev 128589)
+++ trunk/Source/WebCore/ChangeLog	2012-09-14 12:05:44 UTC (rev 128590)
@@ -1,3 +1,53 @@
+2012-09-14  Andrei Poenaru  
+
+Web Inspector: Display Named Flows in the "CSS Named Flows" drawer
+https://bugs.webkit.org/show_bug.cgi?id=90871
+
+Reviewed by Alexander Pavlov.
+
+Implemented CSS Regions support in WebInspector as a drawer. (feature is under an experimental flag)
+
+* English.lproj/localizedStrings.js:
+* WebCore.gypi:
+* WebCore.vcproj/WebCore.vcproj:
+* inspector/compile-front-end.py:
+* inspector/front-end/CSSNamedFlowCollectionsView.js: Added.
+(WebInspector.CSSNamedFlowCollectionsView):
+(WebInspector.CSSNamedFlowCollectionsView.prototype.showInDrawer):
+(WebInspector.CSSNamedFlowCollectionsView.prototype.reset):
+(WebInspector.CSSNamedFlowCollectionsView.prototype._setDocument):
+(WebInspector.CSSNamedFlowCollectionsView.prototype._documentUpdated):
+(WebInspector.CSSNamedFlowCollectionsView.prototype._setSidebarHasContent):
+(WebInspector.CSSNamedFlowCollectionsView.prototype._appendNamedFlow):
+(WebInspector.CSSNamedFlowCollectionsView.prototype._removeNamedFlow):
+(WebInspector.CSSNamedFlowCollectionsView.prototype._updateNamedFlow):
+(WebInspector.CSSNamedFlowCollectionsView.prototype._r

[webkit-changes] [128589] trunk/Source/WebCore

2012-09-14 Thread yosin

Title: [128589] trunk/Source/WebCore








Revision 128589
Author yo...@chromium.org
Date 2012-09-14 04:57:47 -0700 (Fri, 14 Sep 2012)


Log Message
Unreviewed fix for build break on Chromium-Linux Debug build.

* html/DateTimeFieldsState.cpp: Initialize DateTimeFieldStates::emptyValue.
* html/DateTimeFieldsState.h: Remove initialization of public static member variable emptyValue.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/DateTimeFieldsState.cpp
trunk/Source/WebCore/html/DateTimeFieldsState.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (128588 => 128589)

--- trunk/Source/WebCore/ChangeLog	2012-09-14 11:49:23 UTC (rev 128588)
+++ trunk/Source/WebCore/ChangeLog	2012-09-14 11:57:47 UTC (rev 128589)
@@ -1,5 +1,12 @@
 2012-09-14  Yoshifumi Inoue  
 
+Unreviewed fix for build break on Chromium-Linux Debug build.
+
+* html/DateTimeFieldsState.cpp: Initialize DateTimeFieldStates::emptyValue.
+* html/DateTimeFieldsState.h: Remove initialization of public static member variable emptyValue.
+
+2012-09-14  Yoshifumi Inoue  
+
 Create Localizer factory method for LocaleNone
 https://bugs.webkit.org/show_bug.cgi?id=96745
 


Modified: trunk/Source/WebCore/html/DateTimeFieldsState.cpp (128588 => 128589)

--- trunk/Source/WebCore/html/DateTimeFieldsState.cpp	2012-09-14 11:49:23 UTC (rev 128588)
+++ trunk/Source/WebCore/html/DateTimeFieldsState.cpp	2012-09-14 11:57:47 UTC (rev 128589)
@@ -31,6 +31,8 @@
 
 namespace WebCore {
 
+const unsigned DateTimeFieldsState::emptyValue = static_cast(-1);
+
 static unsigned getNumberFromFormControlState(const FormControlState& state, size_t index)
 {
 if (index >= state.valueSize())


Modified: trunk/Source/WebCore/html/DateTimeFieldsState.h (128588 => 128589)

--- trunk/Source/WebCore/html/DateTimeFieldsState.h	2012-09-14 11:49:23 UTC (rev 128588)
+++ trunk/Source/WebCore/html/DateTimeFieldsState.h	2012-09-14 11:57:47 UTC (rev 128589)
@@ -47,7 +47,7 @@
 AMPMValuePM,
 };
 
-static const unsigned emptyValue = static_cast(-1);
+static const unsigned emptyValue;
 
 DateTimeFieldsState();
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [128588] trunk/Source/WebCore

2012-09-14 Thread tkent

Title: [128588] trunk/Source/WebCore








Revision 128588
Author tk...@chromium.org
Date 2012-09-14 04:49:23 -0700 (Fri, 14 Sep 2012)


Log Message
Create Localizer factory method for LocaleNone
https://bugs.webkit.org/show_bug.cgi?id=96745

Patch by Yoshifumi Inoue  on 2012-09-14
Reviewed by Kent Tamura.

This patch introduces Localizer class and LocaleNone class which
prodices a constructor of Localizer class for ports which don't use
LocaleICU, LocaleMac nor LocaleWin.

No new tests. This patch doesn't change behavior.

* CMakeLists.txt: Added platform/text/LocaleNone.cpp and platform/text/Localizer.cpp.
* GNUmakefile.list.am: Added platform/text/LocaleNone.cpp and platform/text/Localizer.{cpp,h}
* Target.pri: Added platform/text/LocaleNone.cpp and platform/text/Localizer.cpp
* WebCore.vcproj/WebCore.vcproj: Added platform/text/LocaleNone.cpp and platform/text/Localizer.{cpp,h}
* platform/text/LocaleNone.cpp: Added.
(WebCore::Localizer::create):
(WebCore::LocaleNone::~LocaleNone):
(WebCore::LocaleNone::initializeLocalizerData):

Modified Paths

trunk/Source/WebCore/CMakeLists.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/GNUmakefile.list.am
trunk/Source/WebCore/Target.pri
trunk/Source/WebCore/WebCore.vcproj/WebCore.vcproj


Added Paths

trunk/Source/WebCore/platform/text/LocaleNone.cpp




Diff

Modified: trunk/Source/WebCore/CMakeLists.txt (128587 => 128588)

--- trunk/Source/WebCore/CMakeLists.txt	2012-09-14 11:42:29 UTC (rev 128587)
+++ trunk/Source/WebCore/CMakeLists.txt	2012-09-14 11:49:23 UTC (rev 128588)
@@ -1986,9 +1986,11 @@
 platform/text/DateTimeFormat.cpp
 platform/text/Hyphenation.cpp
 platform/text/LineEnding.cpp
+platform/text/LocaleNone.cpp
 platform/text/LocaleToScriptMappingDefault.cpp
 platform/text/LocalizedDateNone.cpp
 platform/text/LocalizedNumberNone.cpp
+platform/text/Localizer.cpp
 platform/text/QuotedPrintable.cpp
 platform/text/RegularExpression.cpp
 platform/text/SegmentedString.cpp


Modified: trunk/Source/WebCore/ChangeLog (128587 => 128588)

--- trunk/Source/WebCore/ChangeLog	2012-09-14 11:42:29 UTC (rev 128587)
+++ trunk/Source/WebCore/ChangeLog	2012-09-14 11:49:23 UTC (rev 128588)
@@ -1,3 +1,25 @@
+2012-09-14  Yoshifumi Inoue  
+
+Create Localizer factory method for LocaleNone
+https://bugs.webkit.org/show_bug.cgi?id=96745
+
+Reviewed by Kent Tamura.
+
+This patch introduces Localizer class and LocaleNone class which
+prodices a constructor of Localizer class for ports which don't use
+LocaleICU, LocaleMac nor LocaleWin.
+
+No new tests. This patch doesn't change behavior.
+
+* CMakeLists.txt: Added platform/text/LocaleNone.cpp and platform/text/Localizer.cpp.
+* GNUmakefile.list.am: Added platform/text/LocaleNone.cpp and platform/text/Localizer.{cpp,h}
+* Target.pri: Added platform/text/LocaleNone.cpp and platform/text/Localizer.cpp
+* WebCore.vcproj/WebCore.vcproj: Added platform/text/LocaleNone.cpp and platform/text/Localizer.{cpp,h}
+* platform/text/LocaleNone.cpp: Added.
+(WebCore::Localizer::create): 
+(WebCore::LocaleNone::~LocaleNone):
+(WebCore::LocaleNone::initializeLocalizerData):
+
 2012-09-14  Vsevolod Vlasov  
 
 Unreviewed r128580 follow up: fixed qt minimal compilation.


Modified: trunk/Source/WebCore/GNUmakefile.list.am (128587 => 128588)

--- trunk/Source/WebCore/GNUmakefile.list.am	2012-09-14 11:42:29 UTC (rev 128587)
+++ trunk/Source/WebCore/GNUmakefile.list.am	2012-09-14 11:49:23 UTC (rev 128588)
@@ -4770,12 +4770,15 @@
 	Source/WebCore/platform/text/LineBreakIteratorPoolICU.h \
 	Source/WebCore/platform/text/LineEnding.cpp \
 	Source/WebCore/platform/text/LineEnding.h \
+	Source/WebCore/platform/text/LocaleNone.cpp \
 	Source/WebCore/platform/text/LocaleToScriptMapping.h \
 	Source/WebCore/platform/text/LocaleToScriptMappingDefault.cpp \
 	Source/WebCore/platform/text/LocalizedDate.h \
 	Source/WebCore/platform/text/LocalizedDateNone.cpp \
 	Source/WebCore/platform/text/LocalizedNumber.h \
 	Source/WebCore/platform/text/LocalizedNumberNone.cpp \
+	Source/WebCore/platform/text/Localizer.cpp \
+	Source/WebCore/platform/text/Localizer.h \
 	Source/WebCore/platform/text/ParserUtilities.h \
 	Source/WebCore/platform/text/QuotedPrintable.cpp \
 	Source/WebCore/platform/text/QuotedPrintable.h \


Modified: trunk/Source/WebCore/Target.pri (128587 => 128588)

--- trunk/Source/WebCore/Target.pri	2012-09-14 11:42:29 UTC (rev 128587)
+++ trunk/Source/WebCore/Target.pri	2012-09-14 11:49:23 UTC (rev 128588)
@@ -918,9 +918,11 @@
 platform/text/BidiContext.cpp \
 platform/text/DateTimeFormat.cpp \
 platform/text/Hyphenation.cpp \
+platform/text/LocaleNone.cpp \
 platform/text/LocaleToScriptMappingDefault.cpp \
 platform/text/LocalizedDateNone.cpp \
 platform/text/LocalizedNumberNone.cpp \
+platform/text/Localizer.cpp \
 platform/text/QuotedPrinta

[webkit-changes] [128587] trunk/Tools

2012-09-14 Thread hausmann

Title: [128587] trunk/Tools








Revision 128587
Author hausm...@webkit.org
Date 2012-09-14 04:42:29 -0700 (Fri, 14 Sep 2012)


Log Message
[Qt] Fix linking on Windows

Reviewed by Tor Arne Vestbø.

When compiling code _after_ QtWebKit.dll, we need to make sure that the QWEBKIT_EXPORT
macro turns into an import macro, which means QT_MAKEDLL should only be set _up until_
the QtWebKit.dll creation in the build process and be off afterwards. This is done in
win32/default_post.prf using a !contains(QT, webkit): DEFINES += QT_MAKEDLL.

r128450 sanitized the values of QT and PKGCONFIG to only contain the dependencies we
want for QtWebKit.dll, but unfortunately that code was applied to any binary built also
after the module. Therefore QT did never contain webkit anymore and we always passed
QT_MAKEDLL to DEFINES, resulting in QWEBKIT_EXPORT to _not_ turn into an import macro.

This patch introduces a creating_module configuration that is used to
scope the qt/pkgconfig sanitization.

* qmake/mkspecs/features/default_post.prf:

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/qmake/mkspecs/features/default_post.prf




Diff

Modified: trunk/Tools/ChangeLog (128586 => 128587)

--- trunk/Tools/ChangeLog	2012-09-14 11:24:01 UTC (rev 128586)
+++ trunk/Tools/ChangeLog	2012-09-14 11:42:29 UTC (rev 128587)
@@ -1,3 +1,24 @@
+2012-09-14  Simon Hausmann  
+
+[Qt] Fix linking on Windows
+
+Reviewed by Tor Arne Vestbø.
+
+When compiling code _after_ QtWebKit.dll, we need to make sure that the QWEBKIT_EXPORT
+macro turns into an import macro, which means QT_MAKEDLL should only be set _up until_
+the QtWebKit.dll creation in the build process and be off afterwards. This is done in
+win32/default_post.prf using a !contains(QT, webkit): DEFINES += QT_MAKEDLL.
+
+r128450 sanitized the values of QT and PKGCONFIG to only contain the dependencies we
+want for QtWebKit.dll, but unfortunately that code was applied to any binary built also
+after the module. Therefore QT did never contain webkit anymore and we always passed
+QT_MAKEDLL to DEFINES, resulting in QWEBKIT_EXPORT to _not_ turn into an import macro.
+
+This patch introduces a creating_module configuration that is used to
+scope the qt/pkgconfig sanitization.
+
+* qmake/mkspecs/features/default_post.prf:
+
 2012-09-14  Christophe Dumez  
 
 [WK2][WKTR] TestRunner is not dumping some frame load callbacks information


Modified: trunk/Tools/qmake/mkspecs/features/default_post.prf (128586 => 128587)

--- trunk/Tools/qmake/mkspecs/features/default_post.prf	2012-09-14 11:24:01 UTC (rev 128586)
+++ trunk/Tools/qmake/mkspecs/features/default_post.prf	2012-09-14 11:42:29 UTC (rev 128587)
@@ -183,9 +183,11 @@
 }
 }
 
+contains(TARGET, $$resolveFinalLibraryName($${QT.webkit.name})): CONFIG += creating_module
+
 defineTest(needToLink) {
 # The main dynamic library always needs to link in the intermediate libraries
-contains(TARGET, $$resolveFinalLibraryName($${QT.webkit.name})): return(true)
+creating_module: return(true)
 
 force_static_libs_as_shared {
 # So do the individual libraries if they are dynamic
@@ -216,18 +218,20 @@
 }
 }
 
-# Sanitize PKGCONFIG and LIBS, as we don't want any of these libraries
-# to end up in as public API dependenices in the QtWebKit prl file.
-PKGCONFIG_PRIVATE *= $$PKGCONFIG
-unset(PKGCONFIG)
-LIBS_PRIVATE += $$LIBS
-unset(LIBS)
+creating_module {
+# Sanitize PKGCONFIG and LIBS, as we don't want any of these libraries
+# to end up in as public API dependenices in the QtWebKit prl file.
+PKGCONFIG_PRIVATE *= $$PKGCONFIG
+unset(PKGCONFIG)
+LIBS_PRIVATE += $$LIBS
+unset(LIBS)
 
-# We do have a limited subset of Qt modules as dependencies for using
-# the public QtWebKit API. The rest of the modules go into QT_PRIVATE.
-QT_PRIVATE *= $$QT
-QT = $$QT_API_DEPENDS
-QT_PRIVATE -= $$QT
+# We do have a limited subset of Qt modules as dependencies for using
+# the public QtWebKit API. The rest of the modules go into QT_PRIVATE.
+QT_PRIVATE *= $$QT
+QT = $$QT_API_DEPENDS
+QT_PRIVATE -= $$QT
+}
 
 equals(_PRO_FILE_, $${ROOT_WEBKIT_DIR}/WebKit.pro):!isEmpty(OVERRIDE_SUBDIRS) {
 # The root WebKit project file is the only one that allows






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [128586] trunk/Source/WebCore

2012-09-14 Thread vsevik

Title: [128586] trunk/Source/WebCore








Revision 128586
Author vse...@chromium.org
Date 2012-09-14 04:24:01 -0700 (Fri, 14 Sep 2012)


Log Message
Unreviewed r128580 follow up: fixed qt minimal compilation.

* loader/DocumentThreadableLoader.cpp:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/loader/DocumentThreadableLoader.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (128585 => 128586)

--- trunk/Source/WebCore/ChangeLog	2012-09-14 11:22:00 UTC (rev 128585)
+++ trunk/Source/WebCore/ChangeLog	2012-09-14 11:24:01 UTC (rev 128586)
@@ -1,3 +1,9 @@
+2012-09-14  Vsevolod Vlasov  
+
+Unreviewed r128580 follow up: fixed qt minimal compilation.
+
+* loader/DocumentThreadableLoader.cpp:
+
 2012-09-14  Keishi Hattori  
 
 Refactor time format related methods on LocaleWin/Mac/ICU so that they override Localizer methods


Modified: trunk/Source/WebCore/loader/DocumentThreadableLoader.cpp (128585 => 128586)

--- trunk/Source/WebCore/loader/DocumentThreadableLoader.cpp	2012-09-14 11:22:00 UTC (rev 128585)
+++ trunk/Source/WebCore/loader/DocumentThreadableLoader.cpp	2012-09-14 11:24:01 UTC (rev 128586)
@@ -39,6 +39,7 @@
 #include "DocumentThreadableLoaderClient.h"
 #include "Frame.h"
 #include "FrameLoader.h"
+#include "InspectorInstrumentation.h"
 #include "ResourceError.h"
 #include "ResourceRequest.h"
 #include "SchemeRegistry.h"
@@ -49,7 +50,6 @@
 #include 
 
 #if ENABLE(INSPECTOR)
-#include "InspectorInstrumentation.h"
 #include "ProgressTracker.h"
 #endif
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [128585] trunk

2012-09-14 Thread commit-queue

Title: [128585] trunk








Revision 128585
Author commit-qu...@webkit.org
Date 2012-09-14 04:22:00 -0700 (Fri, 14 Sep 2012)


Log Message
[WK2][WKTR] TestRunner is not dumping some frame load callbacks information
https://bugs.webkit.org/show_bug.cgi?id=96740

Patch by Christophe Dumez  on 2012-09-14
Reviewed by Kenneth Rohde Christiansen.

Tools:

Dump information expected by the test cases about the following
frame load callbacks:
"didDisplayInsecureContentForFrame"
"didRunInsecureContentForFrame"
"didDetectXSSForFrame"

* WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::InjectedBundlePage::willPerformClientRedirectForFrame): Print a URL
as expected by test results by calling pathSuitableForTestResult() instead
of printing raw URL.
(WTR::InjectedBundlePage::didDisplayInsecureContentForFrame):
(WTR::InjectedBundlePage::didRunInsecureContentForFrame):
(WTR::InjectedBundlePage::didDetectXSSForFrame):

LayoutTests:

Unskip test cases which were failing due to missing
frame load callbacks information dumping with
WebKitTestRunner.

* platform/wk2/Skipped:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/wk2/Skipped
trunk/Tools/ChangeLog
trunk/Tools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp




Diff

Modified: trunk/LayoutTests/ChangeLog (128584 => 128585)

--- trunk/LayoutTests/ChangeLog	2012-09-14 11:17:37 UTC (rev 128584)
+++ trunk/LayoutTests/ChangeLog	2012-09-14 11:22:00 UTC (rev 128585)
@@ -1,3 +1,16 @@
+2012-09-14  Christophe Dumez  
+
+[WK2][WKTR] TestRunner is not dumping some frame load callbacks information
+https://bugs.webkit.org/show_bug.cgi?id=96740
+
+Reviewed by Kenneth Rohde Christiansen.
+
+Unskip test cases which were failing due to missing
+frame load callbacks information dumping with
+WebKitTestRunner.
+
+* platform/wk2/Skipped:
+
 2012-09-14  Vsevolod Vlasov  
 
 Web Inspector: Add ability to replay XHR in network panel.


Modified: trunk/LayoutTests/platform/wk2/Skipped (128584 => 128585)

--- trunk/LayoutTests/platform/wk2/Skipped	2012-09-14 11:17:37 UTC (rev 128584)
+++ trunk/LayoutTests/platform/wk2/Skipped	2012-09-14 11:22:00 UTC (rev 128585)
@@ -237,29 +237,9 @@
 webarchive/test-td-background.html
 webarchive/test-xml-stylesheet.xml
 
-# WebKitTestRunner needs layoutTestController.dumpFrameLoadCallbacks
-# 
+# Fails on WebKit2
+# 
 fast/loader/recursive-before-unload-crash.html
-http/tests/security/mixedContent/about-blank-iframe-in-main-frame.html
-http/tests/security/mixedContent/data-url-iframe-in-main-frame.html
-http/tests/security/mixedContent/data-url-script-in-iframe.html
-http/tests/security/mixedContent/empty-url-plugin-in-frame.html
-http/tests/security/mixedContent/insecure-css-in-iframe.html
-http/tests/security/mixedContent/insecure-css-in-main-frame.html
-http/tests/security/mixedContent/insecure-iframe-in-iframe.html
-http/tests/security/mixedContent/insecure-iframe-in-main-frame.html
-http/tests/security/mixedContent/insecure-image-in-iframe.html
-http/tests/security/mixedContent/insecure-image-in-main-frame.html
-http/tests/security/mixedContent/insecure-plugin-in-iframe.html
-http/tests/security/mixedContent/insecure-script-in-iframe.html
-http/tests/security/mixedContent/redirect-http-to-https-iframe-in-main-frame.html
-http/tests/security/mixedContent/redirect-http-to-https-script-in-iframe.html
-http/tests/security/mixedContent/redirect-https-to-http-iframe-in-main-frame.html
-http/tests/security/mixedContent/redirect-https-to-http-script-in-iframe.html
-webarchive/loading/_javascript_-url-iframe-crash.html
-webarchive/loading/mainresource-null-mimetype-crash.html
-webarchive/loading/missing-data.html
-http/tests/security/xssAuditor/script-tag-with-callbacks.html
 
 # WebKitTestRunner needs textInputController
 # 


Modified: trunk/Tools/ChangeLog (128584 => 128585)

--- trunk/Tools/ChangeLog	2012-09-14 11:17:37 UTC (rev 128584)
+++ trunk/Tools/ChangeLog	2012-09-14 11:22:00 UTC (rev 128585)
@@ -1,3 +1,24 @@
+2012-09-14  Christophe Dumez  
+
+[WK2][WKTR] TestRunner is not dumping some frame load callbacks information
+https://bugs.webkit.org/show_bug.cgi?id=96740
+
+Reviewed by Kenneth Rohde Christiansen.
+
+Dump information expected by the test cases about the following
+frame load callbacks:
+"didDisplayInsecureContentForFrame"
+"didRunInsecureContentForFrame"
+"didDetectXSSForFrame"
+
+* WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
+(WTR::InjectedBundlePage::willPerformClientRedirectForFrame): Print a URL
+as expected by test results by calling pathSuitableForTestResult() instead
+of printing raw URL.
+(WTR::InjectedBundlePage::didDisplayInsecureContentForFrame):
+(WTR::InjectedBundlePage::didRunInsecureContentForFrame):
+(WTR::InjectedBundlePage::didDetectXSSForFrame):
+
 2012-09-14  Peter Beverloo  
 
 Th

[webkit-changes] [128584] trunk/Source

2012-09-14 Thread keishi

Title: [128584] trunk/Source








Revision 128584
Author kei...@webkit.org
Date 2012-09-14 04:17:37 -0700 (Fri, 14 Sep 2012)


Log Message
Refactor time format related methods on LocaleWin/Mac/ICU so that they override Localizer methods
https://bugs.webkit.org/show_bug.cgi?id=96726

Reviewed by Kent Tamura.

Source/WebCore:

Refactoring time format related methods on LocaleWin/Mac/ICU so that
they override Localizer methods. We can call them from the Localizer
from now on.

No new tests. No behavior change. Covered by existing tests.

* platform/text/LocaleICU.cpp:
(WebCore::LocaleICU::initializeDateTimeFormat): m_timeAMPMLabels is no longer a OwnPtr so we account for that.
(WebCore::LocaleICU::timeFormat): Removing Text from end of function
name because *FormatText() shoud return human readable text like "Day/Month/Year".
(WebCore::LocaleICU::shortTimeFormat):
(WebCore::LocaleICU::timeAMPMLabels):
* platform/text/LocaleICU.h:
(LocaleICU):
* platform/text/LocaleWin.cpp:
(WebCore::LocaleWin::timeFormat):
(WebCore::LocaleWin::shortTimeFormat):
(WebCore::LocaleWin::timeAMPMLabels):
* platform/text/LocaleWin.h:
(LocaleWin):
* platform/text/LocalizedDateICU.cpp:
(WebCore::localizedTimeFormatText):
(WebCore::localizedShortTimeFormatText):
* platform/text/LocalizedDateWin.cpp:
(WebCore::localizedTimeFormatText):
(WebCore::localizedShortTimeFormatText):
* platform/text/Localizer.cpp:
(WebCore):
(WebCore::Localizer::timeFormat):
(WebCore::Localizer::shortTimeFormat):
(WebCore::Localizer::timeAMPMLabels):
* platform/text/Localizer.h:
(Localizer): We unified some of the member variables like m_timeAMPMLabels into this class.
* platform/text/mac/LocaleMac.h:
(LocaleMac):
* platform/text/mac/LocaleMac.mm:
(WebCore::LocaleMac::timeFormat):
(WebCore::LocaleMac::shortTimeFormat):
* platform/text/mac/LocalizedDateMac.cpp:
(WebCore::localizedTimeFormatText):
(WebCore::localizedShortTimeFormatText):

Source/WebKit/chromium:

* tests/LocaleMacTest.cpp:
(LocaleMacTest::timeFormat):
(LocaleMacTest::shortTimeFormat):
(TEST_F):
* tests/LocaleWinTest.cpp:
(LocaleWinTest::timeFormat):
(LocaleWinTest::shortTimeFormat):
(TEST_F):
* tests/LocalizedDateICUTest.cpp:
(LocalizedDateICUTest::localizedDateFormatText):
(LocalizedDateICUTest::localizedShortDateFormatText):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/text/LocaleICU.cpp
trunk/Source/WebCore/platform/text/LocaleICU.h
trunk/Source/WebCore/platform/text/LocaleWin.cpp
trunk/Source/WebCore/platform/text/LocaleWin.h
trunk/Source/WebCore/platform/text/LocalizedDateICU.cpp
trunk/Source/WebCore/platform/text/LocalizedDateWin.cpp
trunk/Source/WebCore/platform/text/Localizer.cpp
trunk/Source/WebCore/platform/text/Localizer.h
trunk/Source/WebCore/platform/text/mac/LocaleMac.h
trunk/Source/WebCore/platform/text/mac/LocaleMac.mm
trunk/Source/WebCore/platform/text/mac/LocalizedDateMac.cpp
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/tests/LocaleMacTest.cpp
trunk/Source/WebKit/chromium/tests/LocaleWinTest.cpp
trunk/Source/WebKit/chromium/tests/LocalizedDateICUTest.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (128583 => 128584)

--- trunk/Source/WebCore/ChangeLog	2012-09-14 11:11:17 UTC (rev 128583)
+++ trunk/Source/WebCore/ChangeLog	2012-09-14 11:17:37 UTC (rev 128584)
@@ -1,5 +1,54 @@
 2012-09-14  Keishi Hattori  
 
+Refactor time format related methods on LocaleWin/Mac/ICU so that they override Localizer methods
+https://bugs.webkit.org/show_bug.cgi?id=96726
+
+Reviewed by Kent Tamura.
+
+Refactoring time format related methods on LocaleWin/Mac/ICU so that
+they override Localizer methods. We can call them from the Localizer
+from now on.
+
+No new tests. No behavior change. Covered by existing tests.
+
+* platform/text/LocaleICU.cpp:
+(WebCore::LocaleICU::initializeDateTimeFormat): m_timeAMPMLabels is no longer a OwnPtr so we account for that.
+(WebCore::LocaleICU::timeFormat): Removing Text from end of function
+name because *FormatText() shoud return human readable text like "Day/Month/Year".
+(WebCore::LocaleICU::shortTimeFormat):
+(WebCore::LocaleICU::timeAMPMLabels):
+* platform/text/LocaleICU.h:
+(LocaleICU):
+* platform/text/LocaleWin.cpp:
+(WebCore::LocaleWin::timeFormat):
+(WebCore::LocaleWin::shortTimeFormat):
+(WebCore::LocaleWin::timeAMPMLabels):
+* platform/text/LocaleWin.h:
+(LocaleWin):
+* platform/text/LocalizedDateICU.cpp:
+(WebCore::localizedTimeFormatText):
+(WebCore::localizedShortTimeFormatText):
+* platform/text/LocalizedDateWin.cpp:
+(WebCore::localizedTimeFormatText):
+(WebCore::localizedShortTimeFormatText):
+* platform/text/Localizer.cpp:
+(WebCore):
+(WebCore::Localizer::timeFormat):
+(WebCore::Localizer::shortTimeFormat):
+(WebCore::Localizer:

[webkit-changes] [128583] trunk

2012-09-14 Thread keishi

Title: [128583] trunk








Revision 128583
Author kei...@webkit.org
Date 2012-09-14 04:11:17 -0700 (Fri, 14 Sep 2012)


Log Message
Add runtime flag that enables lang attribute for form controls in LayoutTests
https://bugs.webkit.org/show_bug.cgi?id=96636

Reviewed by Kent Tamura.

.:

* Source/autotools/symbols.filter:

Source/WebCore:

Lang attribute support for form controls will be incomplete and just for LayoutTests.

No new tests. No behavior change.

* WebCore.exp.in:
* bindings/generic/RuntimeEnabledFeatures.cpp:
(WebCore):
* bindings/generic/RuntimeEnabledFeatures.h:
(WebCore::RuntimeEnabledFeatures::langAttributeAwareFormControlUIEnabled):
(WebCore::RuntimeEnabledFeatures::setLangAttributeAwareFormControlUIEnabled):
(RuntimeEnabledFeatures):
* testing/InternalSettings.cpp:
(WebCore::InternalSettings::Backup::Backup):
(WebCore::InternalSettings::Backup::restoreTo):
(WebCore::InternalSettings::setLangAttributeAwareFormControlUIEnabled):
(WebCore):
* testing/InternalSettings.h:
(Backup):
(InternalSettings):
* testing/InternalSettings.idl:

Source/WebKit2:

* win/WebKit2.def:
* win/WebKit2CFLite.def:

Modified Paths

trunk/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/WebCore.exp.in
trunk/Source/WebCore/bindings/generic/RuntimeEnabledFeatures.cpp
trunk/Source/WebCore/bindings/generic/RuntimeEnabledFeatures.h
trunk/Source/WebCore/testing/InternalSettings.cpp
trunk/Source/WebCore/testing/InternalSettings.h
trunk/Source/WebCore/testing/InternalSettings.idl
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/win/WebKit2.def
trunk/Source/WebKit2/win/WebKit2CFLite.def
trunk/Source/autotools/symbols.filter




Diff

Modified: trunk/ChangeLog (128582 => 128583)

--- trunk/ChangeLog	2012-09-14 10:59:57 UTC (rev 128582)
+++ trunk/ChangeLog	2012-09-14 11:11:17 UTC (rev 128583)
@@ -1,3 +1,12 @@
+2012-09-14  Keishi Hattori  
+
+Add runtime flag that enables lang attribute for form controls in LayoutTests
+https://bugs.webkit.org/show_bug.cgi?id=96636
+
+Reviewed by Kent Tamura.
+
+* Source/autotools/symbols.filter:
+
 2012-09-13  Raphael Kubo da Costa  
 
 [CMake] Remove some redundant warning flags and enable a few more warnings.


Modified: trunk/Source/WebCore/ChangeLog (128582 => 128583)

--- trunk/Source/WebCore/ChangeLog	2012-09-14 10:59:57 UTC (rev 128582)
+++ trunk/Source/WebCore/ChangeLog	2012-09-14 11:11:17 UTC (rev 128583)
@@ -1,5 +1,33 @@
 2012-09-14  Keishi Hattori  
 
+Add runtime flag that enables lang attribute for form controls in LayoutTests
+https://bugs.webkit.org/show_bug.cgi?id=96636
+
+Reviewed by Kent Tamura.
+
+Lang attribute support for form controls will be incomplete and just for LayoutTests.
+
+No new tests. No behavior change.
+
+* WebCore.exp.in:
+* bindings/generic/RuntimeEnabledFeatures.cpp:
+(WebCore):
+* bindings/generic/RuntimeEnabledFeatures.h:
+(WebCore::RuntimeEnabledFeatures::langAttributeAwareFormControlUIEnabled):
+(WebCore::RuntimeEnabledFeatures::setLangAttributeAwareFormControlUIEnabled):
+(RuntimeEnabledFeatures):
+* testing/InternalSettings.cpp:
+(WebCore::InternalSettings::Backup::Backup):
+(WebCore::InternalSettings::Backup::restoreTo):
+(WebCore::InternalSettings::setLangAttributeAwareFormControlUIEnabled):
+(WebCore):
+* testing/InternalSettings.h:
+(Backup):
+(InternalSettings):
+* testing/InternalSettings.idl:
+
+2012-09-14  Keishi Hattori  
+
 LocaleMac should fallback to defaultLanguage for an invalid locale
 https://bugs.webkit.org/show_bug.cgi?id=96744
 


Modified: trunk/Source/WebCore/WebCore.exp.in (128582 => 128583)

--- trunk/Source/WebCore/WebCore.exp.in	2012-09-14 10:59:57 UTC (rev 128582)
+++ trunk/Source/WebCore/WebCore.exp.in	2012-09-14 11:11:17 UTC (rev 128583)
@@ -561,6 +561,7 @@
 __ZN7WebCore21setGlobalIconDatabaseEPNS_16IconDatabaseBaseE
 __ZN7WebCore21setPlatformStrategiesEPNS_18PlatformStrategiesE
 __ZN7WebCore22RuntimeEnabledFeatures22isCSSExclusionsEnabledE
+__ZN7WebCore22RuntimeEnabledFeatures40isLangAttributeAwareFormControlUIEnabledE
 __ZN7WebCore22ScriptExecutionContext26canSuspendActiveDOMObjectsEv
 __ZN7WebCore22URLWithUserTypedStringEP8NSStringP5NSURL
 __ZN7WebCore22counterValueForElementEPNS_7ElementE


Modified: trunk/Source/WebCore/bindings/generic/RuntimeEnabledFeatures.cpp (128582 => 128583)

--- trunk/Source/WebCore/bindings/generic/RuntimeEnabledFeatures.cpp	2012-09-14 10:59:57 UTC (rev 128582)
+++ trunk/Source/WebCore/bindings/generic/RuntimeEnabledFeatures.cpp	2012-09-14 11:11:17 UTC (rev 128583)
@@ -55,6 +55,7 @@
 bool RuntimeEnabledFeatures::isDeviceOrientationEnabled = true;
 bool RuntimeEnabledFeatures::isSpeechInputEnabled = true;
 bool RuntimeEnabledFeatures::isCSSExclusionsEnabled = false;
+bool RuntimeEnabledFeatures::isLangAttributeAwareFormControlUIEnabled = false;
 
 #if ENA

[webkit-changes] [128582] trunk/Source

2012-09-14 Thread keishi

Title: [128582] trunk/Source








Revision 128582
Author kei...@webkit.org
Date 2012-09-14 03:59:57 -0700 (Fri, 14 Sep 2012)


Log Message
LocaleMac should fallback to defaultLanguage for an invalid locale
https://bugs.webkit.org/show_bug.cgi?id=96744

Reviewed by Kent Tamura.

Source/WebCore:

There is no way to tell if a locale identifier is valid or not in Cocoa
so we look if we have a matching language in the list of
ISOLanguageCodes given by NSLocale.

Covered in LocaleMacTest.invalidLocale.

* platform/text/mac/LocaleMac.mm:
(WebCore):
(WebCore::LocaleMac::LocaleMac):
(WebCore::LocaleMac::create):

Source/WebKit/chromium:

* tests/LocaleMacTest.cpp:
(TEST_F):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/text/mac/LocaleMac.mm
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/tests/LocaleMacTest.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (128581 => 128582)

--- trunk/Source/WebCore/ChangeLog	2012-09-14 10:58:24 UTC (rev 128581)
+++ trunk/Source/WebCore/ChangeLog	2012-09-14 10:59:57 UTC (rev 128582)
@@ -1,3 +1,21 @@
+2012-09-14  Keishi Hattori  
+
+LocaleMac should fallback to defaultLanguage for an invalid locale
+https://bugs.webkit.org/show_bug.cgi?id=96744
+
+Reviewed by Kent Tamura.
+
+There is no way to tell if a locale identifier is valid or not in Cocoa
+so we look if we have a matching language in the list of
+ISOLanguageCodes given by NSLocale.
+
+Covered in LocaleMacTest.invalidLocale.
+
+* platform/text/mac/LocaleMac.mm:
+(WebCore):
+(WebCore::LocaleMac::LocaleMac):
+(WebCore::LocaleMac::create):
+
 2012-09-14  Vsevolod Vlasov  
 
 Web Inspector: Add ability to replay XHR in network panel.


Modified: trunk/Source/WebCore/platform/text/mac/LocaleMac.mm (128581 => 128582)

--- trunk/Source/WebCore/platform/text/mac/LocaleMac.mm	2012-09-14 10:58:24 UTC (rev 128581)
+++ trunk/Source/WebCore/platform/text/mac/LocaleMac.mm	2012-09-14 10:59:57 UTC (rev 128582)
@@ -71,6 +71,11 @@
 : m_locale([[NSLocale alloc] initWithLocaleIdentifier:localeIdentifier])
 , m_didInitializeNumberData(false)
 {
+NSArray* availableLanguages = [NSLocale ISOLanguageCodes];
+// NSLocale returns a lower case NSLocaleLanguageCode so we don't have care about case.
+NSString* language = [m_locale.get() objectForKey:NSLocaleLanguageCode];
+if ([availableLanguages indexOfObject:language] == NSNotFound)
+m_locale = [[NSLocale alloc] initWithLocaleIdentifier:defaultLanguage()];
 }
 
 LocaleMac::~LocaleMac()


Modified: trunk/Source/WebKit/chromium/ChangeLog (128581 => 128582)

--- trunk/Source/WebKit/chromium/ChangeLog	2012-09-14 10:58:24 UTC (rev 128581)
+++ trunk/Source/WebKit/chromium/ChangeLog	2012-09-14 10:59:57 UTC (rev 128582)
@@ -1,3 +1,13 @@
+2012-09-14  Keishi Hattori  
+
+LocaleMac should fallback to defaultLanguage for an invalid locale
+https://bugs.webkit.org/show_bug.cgi?id=96744
+
+Reviewed by Kent Tamura.
+
+* tests/LocaleMacTest.cpp:
+(TEST_F):
+
 2012-09-13  Sheriff Bot  
 
 Unreviewed, rolling out r128543.


Modified: trunk/Source/WebKit/chromium/tests/LocaleMacTest.cpp (128581 => 128582)

--- trunk/Source/WebKit/chromium/tests/LocaleMacTest.cpp	2012-09-14 10:58:24 UTC (rev 128581)
+++ trunk/Source/WebKit/chromium/tests/LocaleMacTest.cpp	2012-09-14 10:59:57 UTC (rev 128582)
@@ -221,6 +221,12 @@
 }
 #endif
 
+TEST_F(LocaleMacTest, invalidLocale)
+{
+EXPECT_STREQ(monthLabel("en_US", January).utf8().data(), monthLabel("foo", January).utf8().data());
+EXPECT_STREQ(decimalSeparator("en_US").utf8().data(), decimalSeparator("foo").utf8().data());
+}
+
 static void testNumberIsReversible(const AtomicString& localeString, const char* original, const char* shouldHave = 0)
 {
 OwnPtr locale = Localizer::create(localeString);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [128581] trunk/Tools

2012-09-14 Thread peter

Title: [128581] trunk/Tools








Revision 128581
Author pe...@chromium.org
Date 2012-09-14 03:58:24 -0700 (Fri, 14 Sep 2012)


Log Message
The runtime/unsigned category should be valid in the cpp style-checker.
https://bugs.webkit.org/show_bug.cgi?id=96748

Reviewed by Csaba Osztrogonác.

This is causing the webkitpy tests to fail because it's not listed in the
category array. Furthermore, change an "int" to "long" because it's
throwing a double error in one of the earlier asserts.

* Scripts/webkitpy/style/checkers/cpp.py:
(CppChecker):
* Scripts/webkitpy/style/checkers/cpp_unittest.py:
(WebKitStyleTest.test_names):

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/style/checkers/cpp.py
trunk/Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py




Diff

Modified: trunk/Tools/ChangeLog (128580 => 128581)

--- trunk/Tools/ChangeLog	2012-09-14 10:41:35 UTC (rev 128580)
+++ trunk/Tools/ChangeLog	2012-09-14 10:58:24 UTC (rev 128581)
@@ -1,3 +1,19 @@
+2012-09-14  Peter Beverloo  
+
+The runtime/unsigned category should be valid in the cpp style-checker.
+https://bugs.webkit.org/show_bug.cgi?id=96748
+
+Reviewed by Csaba Osztrogonác.
+
+This is causing the webkitpy tests to fail because it's not listed in the
+category array. Furthermore, change an "int" to "long" because it's
+throwing a double error in one of the earlier asserts.
+
+* Scripts/webkitpy/style/checkers/cpp.py:
+(CppChecker):
+* Scripts/webkitpy/style/checkers/cpp_unittest.py:
+(WebKitStyleTest.test_names):
+
 2012-09-13  Kenneth Rohde Christiansen  
 
 Evas_Object* is a ref'ed structure, so tread it as such


Modified: trunk/Tools/Scripts/webkitpy/style/checkers/cpp.py (128580 => 128581)

--- trunk/Tools/Scripts/webkitpy/style/checkers/cpp.py	2012-09-14 10:41:35 UTC (rev 128580)
+++ trunk/Tools/Scripts/webkitpy/style/checkers/cpp.py	2012-09-14 10:58:24 UTC (rev 128581)
@@ -3600,6 +3600,7 @@
 'runtime/sizeof',
 'runtime/string',
 'runtime/threadsafe_fn',
+'runtime/unsigned',
 'runtime/virtual',
 'whitespace/blank_line',
 'whitespace/braces',


Modified: trunk/Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py (128580 => 128581)

--- trunk/Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py	2012-09-14 10:41:35 UTC (rev 128580)
+++ trunk/Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py	2012-09-14 10:58:24 UTC (rev 128581)
@@ -4457,7 +4457,7 @@
  'length_' + name_underscore_error_message)
 self.assert_lint('unsigned _length;',
  '_length' + name_underscore_error_message)
-self.assert_lint('unsigned int _length;',
+self.assert_lint('unsigned long _length;',
  '_length' + name_underscore_error_message)
 self.assert_lint('unsigned long long _length;',
  '_length' + name_underscore_error_message)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [128579] trunk/PerformanceTests

2012-09-14 Thread ossy

Title: [128579] trunk/PerformanceTests








Revision 128579
Author o...@webkit.org
Date 2012-09-14 03:40:40 -0700 (Fri, 14 Sep 2012)


Log Message
Unreviewed, rolling out r128562.
http://trac.webkit.org/changeset/128562
https://bugs.webkit.org/show_bug.cgi?id=96747

It broke perf tests on Qt and Chromium (Requested by Ossy on
#webkit).

Patch by Sheriff Bot  on 2012-09-14

* resources/runner.js:
(PerfTestRunner._runner):
(PerfTestRunner._perSecondRunnerIterator):

Modified Paths

trunk/PerformanceTests/ChangeLog
trunk/PerformanceTests/resources/runner.js




Diff

Modified: trunk/PerformanceTests/ChangeLog (128578 => 128579)

--- trunk/PerformanceTests/ChangeLog	2012-09-14 10:22:00 UTC (rev 128578)
+++ trunk/PerformanceTests/ChangeLog	2012-09-14 10:40:40 UTC (rev 128579)
@@ -1,3 +1,16 @@
+2012-09-14  Sheriff Bot  
+
+Unreviewed, rolling out r128562.
+http://trac.webkit.org/changeset/128562
+https://bugs.webkit.org/show_bug.cgi?id=96747
+
+It broke perf tests on Qt and Chromium (Requested by Ossy on
+#webkit).
+
+* resources/runner.js:
+(PerfTestRunner._runner):
+(PerfTestRunner._perSecondRunnerIterator):
+
 2012-09-14  Ryosuke Niwa  
 
 Use performance.webkitNow in PerfTestRunner


Modified: trunk/PerformanceTests/resources/runner.js (128578 => 128579)

--- trunk/PerformanceTests/resources/runner.js	2012-09-14 10:22:00 UTC (rev 128578)
+++ trunk/PerformanceTests/resources/runner.js	2012-09-14 10:40:40 UTC (rev 128579)
@@ -27,8 +27,6 @@
 return (randomSeed & 0xfff) / 0x1000;
 };
 
-PerfTestRunner.now = window.performance && window.performance.webkitNow ? window.performance.webkitNow : Date.now;
-
 PerfTestRunner.log = function (text) {
 if (this._logLines) {
 this._logLines.push(text);
@@ -147,7 +145,7 @@
 }
 
 PerfTestRunner._runner = function () {
-var start = this.now();
+var start = Date.now();
 var totalTime = 0;
 
 for (var i = 0; i < this._loopsPerRun; ++i) {
@@ -160,7 +158,7 @@
 }
 
 // Assume totalTime can never be zero when _runFunction returns a number.
-var time = totalTime ? totalTime : this.now() - start;
+var time = totalTime ? totalTime : Date.now() - start;
 
 this.ignoreWarmUpAndLog(time);
 this._runLoop();
@@ -260,10 +258,10 @@
 }
 
 PerfTestRunner._perSecondRunnerIterator = function (callsPerIteration) {
-var startTime = this.now();
+var startTime = Date.now();
 for (var i = 0; i < callsPerIteration; i++)
 this._test.run();
-return this.now() - startTime;
+return Date.now() - startTime;
 }
 
 if (window.testRunner) {






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [128577] trunk/LayoutTests

2012-09-14 Thread commit-queue

Title: [128577] trunk/LayoutTests








Revision 128577
Author commit-qu...@webkit.org
Date 2012-09-14 03:15:16 -0700 (Fri, 14 Sep 2012)


Log Message
[WK2] Move globalhistory tests to their correct section in Skipped list
https://bugs.webkit.org/show_bug.cgi?id=96738

Unreviewed gardening.

Move 2 globalhistory tests to their correct section in WK2
Skipped list.

Patch by Christophe Dumez  on 2012-09-14

* platform/wk2/Skipped:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/wk2/Skipped




Diff

Modified: trunk/LayoutTests/ChangeLog (128576 => 128577)

--- trunk/LayoutTests/ChangeLog	2012-09-14 10:10:19 UTC (rev 128576)
+++ trunk/LayoutTests/ChangeLog	2012-09-14 10:15:16 UTC (rev 128577)
@@ -1,3 +1,15 @@
+2012-09-14  Christophe Dumez  
+
+[WK2] Move globalhistory tests to their correct section in Skipped list
+https://bugs.webkit.org/show_bug.cgi?id=96738
+
+Unreviewed gardening.
+
+Move 2 globalhistory tests to their correct section in WK2
+Skipped list.
+
+* platform/wk2/Skipped:
+
 2012-09-14  Yoshifumi Inoue  
 
 [Forms] multiple fields time input UI should save/restore its value even if it has an empty field.


Modified: trunk/LayoutTests/platform/wk2/Skipped (128576 => 128577)

--- trunk/LayoutTests/platform/wk2/Skipped	2012-09-14 10:10:19 UTC (rev 128576)
+++ trunk/LayoutTests/platform/wk2/Skipped	2012-09-14 10:15:16 UTC (rev 128577)
@@ -240,8 +240,6 @@
 # WebKitTestRunner needs layoutTestController.dumpFrameLoadCallbacks
 # 
 fast/loader/recursive-before-unload-crash.html
-http/tests/globalhistory/history-delegate-basic-302-redirect.html
-http/tests/globalhistory/history-delegate-basic-refresh-redirect.html
 http/tests/security/mixedContent/about-blank-iframe-in-main-frame.html
 http/tests/security/mixedContent/data-url-iframe-in-main-frame.html
 http/tests/security/mixedContent/data-url-script-in-iframe.html
@@ -509,6 +507,8 @@
 
 # WebKitTestRunner needs to print history delegate information
 # 
+http/tests/globalhistory/history-delegate-basic-302-redirect.html
+http/tests/globalhistory/history-delegate-basic-refresh-redirect.html
 http/tests/globalhistory/history-delegate-basic-title.html
 http/tests/globalhistory/history-delegate-basic-visited-links.html
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [128576] trunk/Source/WTF

2012-09-14 Thread loislo

Title: [128576] trunk/Source/WTF








Revision 128576
Author loi...@chromium.org
Date 2012-09-14 03:10:19 -0700 (Fri, 14 Sep 2012)


Log Message
Web Inspector: NMI: remove current traits helper class because it is customizing the instrumentation at a wrong place and is not necessary at the moment.
https://bugs.webkit.org/show_bug.cgi?id=96737

Reviewed by Yury Semikhatsky.

* wtf/MemoryInstrumentation.h:
(MemoryInstrumentation):
WTF::MemoryInstrumentationTraits): removed
(WTF::MemoryInstrumentation::OwningTraits::addInstrumentedObject): direct call inserted
(WTF::MemoryInstrumentation::OwningTraits::addObject):direct call inserted

Modified Paths

trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/MemoryInstrumentation.h




Diff

Modified: trunk/Source/WTF/ChangeLog (128575 => 128576)

--- trunk/Source/WTF/ChangeLog	2012-09-14 10:09:02 UTC (rev 128575)
+++ trunk/Source/WTF/ChangeLog	2012-09-14 10:10:19 UTC (rev 128576)
@@ -1,3 +1,16 @@
+2012-09-14  Ilya Tikhonovsky  
+
+Web Inspector: NMI: remove current traits helper class because it is customizing the instrumentation at a wrong place and is not necessary at the moment.
+https://bugs.webkit.org/show_bug.cgi?id=96737
+
+Reviewed by Yury Semikhatsky.
+
+* wtf/MemoryInstrumentation.h:
+(MemoryInstrumentation):
+WTF::MemoryInstrumentationTraits): removed
+(WTF::MemoryInstrumentation::OwningTraits::addInstrumentedObject): direct call inserted
+(WTF::MemoryInstrumentation::OwningTraits::addObject):direct call inserted
+
 2012-09-13  Kenneth Rohde Christiansen  
 
 Evas_Object* is a ref'ed structure, so tread it as such


Modified: trunk/Source/WTF/wtf/MemoryInstrumentation.h (128575 => 128576)

--- trunk/Source/WTF/wtf/MemoryInstrumentation.h	2012-09-14 10:09:02 UTC (rev 128575)
+++ trunk/Source/WTF/wtf/MemoryInstrumentation.h	2012-09-14 10:10:19 UTC (rev 128576)
@@ -48,12 +48,6 @@
 byReference
 };
 
-class MemoryInstrumentationTraits {
-public:
-template static void addInstrumentedObject(MemoryInstrumentation*, const T* const&, MemoryObjectType, MemoryOwningType);
-template static void addObject(MemoryInstrumentation*, const T* const&, MemoryObjectType, MemoryOwningType);
-};
-
 class MemoryInstrumentation {
 public:
 virtual ~MemoryInstrumentation() { }
@@ -80,7 +74,6 @@
 virtual void processDeferredInstrumentedPointers() = 0;
 
 friend class MemoryClassInfo;
-friend class MemoryInstrumentationTraits;
 
 template class InstrumentedPointer : public InstrumentedPointerBase {
 public:
@@ -116,11 +109,11 @@
 struct OwningTraits { // Default byReference implementation.
 static void addInstrumentedObject(MemoryInstrumentation* instrumentation, const T& t, MemoryObjectType ownerObjectType)
 {
-MemoryInstrumentationTraits::addInstrumentedObject(instrumentation, &t, ownerObjectType, byReference);
+instrumentation->addInstrumentedObjectImpl(&t, ownerObjectType, byReference);
 }
 static void addObject(MemoryInstrumentation* instrumentation, const T& t, MemoryObjectType ownerObjectType)
 {
-MemoryInstrumentationTraits::addObject(instrumentation, &t, ownerObjectType, byReference);
+instrumentation->addObjectImpl(&t, ownerObjectType, byReference);
 }
 };
 
@@ -128,11 +121,11 @@
 struct OwningTraits { // Custom byPointer implementation.
 static void addInstrumentedObject(MemoryInstrumentation* instrumentation, const T* const& t, MemoryObjectType ownerObjectType)
 {
-MemoryInstrumentationTraits::addInstrumentedObject(instrumentation, t, ownerObjectType, byPointer);
+instrumentation->addInstrumentedObjectImpl(t, ownerObjectType, byPointer);
 }
 static void addObject(MemoryInstrumentation* instrumentation, const T* const& t, MemoryObjectType ownerObjectType)
 {
-MemoryInstrumentationTraits::addObject(instrumentation, t, ownerObjectType, byPointer);
+instrumentation->addObjectImpl(t, ownerObjectType, byPointer);
 }
 };
 
@@ -145,18 +138,6 @@
 template void addObjectImpl(const RefPtr* const&, MemoryObjectType, MemoryOwningType);
 };
 
-template
-void MemoryInstrumentationTraits::addInstrumentedObject(MemoryInstrumentation* instrumentation, const T* const& t, MemoryObjectType ownerObjectType, MemoryOwningType owningType)
-{
-instrumentation->addInstrumentedObjectImpl(t, ownerObjectType, owningType);
-}
-
-template
-void MemoryInstrumentationTraits::addObject(MemoryInstrumentation* instrumentation, const T* const& t, MemoryObjectType ownerObjectType, MemoryOwningType owningType)
-{
-instrumentation->addObjectImpl(t, ownerObjectType, owningType);
-}
-
 class MemoryObjectInfo {
 public:
 MemoryObjectInfo(MemoryInstrumentation* memoryInstrumentation, MemoryObjectType ownerObjectType)






___
webkit-changes maili

[webkit-changes] [128574] trunk/Source/WebCore

2012-09-14 Thread ossy

Title: [128574] trunk/Source/WebCore








Revision 128574
Author o...@webkit.org
Date 2012-09-14 02:37:27 -0700 (Fri, 14 Sep 2012)


Log Message
Unreviewed, rolling out r128568.
http://trac.webkit.org/changeset/128568
https://bugs.webkit.org/show_bug.cgi?id=96739

It broke 3 tests everywhere (Requested by Ossy on #webkit).

Patch by Sheriff Bot  on 2012-09-14

* bindings/js/JSDictionary.h:
(WebCore::JSDictionary::tryGetPropertyAndResult):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/js/JSDictionary.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (128573 => 128574)

--- trunk/Source/WebCore/ChangeLog	2012-09-14 09:27:28 UTC (rev 128573)
+++ trunk/Source/WebCore/ChangeLog	2012-09-14 09:37:27 UTC (rev 128574)
@@ -1,3 +1,14 @@
+2012-09-14  Sheriff Bot  
+
+Unreviewed, rolling out r128568.
+http://trac.webkit.org/changeset/128568
+https://bugs.webkit.org/show_bug.cgi?id=96739
+
+It broke 3 tests everywhere (Requested by Ossy on #webkit).
+
+* bindings/js/JSDictionary.h:
+(WebCore::JSDictionary::tryGetPropertyAndResult):
+
 2012-09-13  Kenneth Rohde Christiansen  
 
 Evas_Object* is a ref'ed structure, so tread it as such


Modified: trunk/Source/WebCore/bindings/js/JSDictionary.h (128573 => 128574)

--- trunk/Source/WebCore/bindings/js/JSDictionary.h	2012-09-14 09:27:28 UTC (rev 128573)
+++ trunk/Source/WebCore/bindings/js/JSDictionary.h	2012-09-14 09:37:27 UTC (rev 128574)
@@ -145,10 +145,8 @@
 Result result;
 convertValue(m_exec, value, result);
 
-if (m_exec->hadException()) {
-m_exec->clearException();
+if (m_exec->hadException())
 return ExceptionThrown;
-}
 
 setter(context, result);
 break;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [128573] trunk

2012-09-14 Thread kenneth

Title: [128573] trunk








Revision 128573
Author kenn...@webkit.org
Date 2012-09-14 02:27:28 -0700 (Fri, 14 Sep 2012)


Log Message
Evas_Object* is a ref'ed structure, so tread it as such
https://bugs.webkit.org/show_bug.cgi?id=96659

Source/WebCore:

Reviewed by Adam Barth.

Replace OwnPtr with RefPtr.

* PlatformEfl.cmake:
* platform/efl/RenderThemeEfl.cpp:
(WebCore::RenderThemeEfl::ThemePartCacheEntry::create):
(WebCore::RenderThemeEfl::loadTheme):
(WebCore::RenderThemeEfl::applyPartDescriptionsFrom):
* platform/efl/RenderThemeEfl.h:
(RenderThemeEfl):
(ThemePartCacheEntry):

Source/WebKit/efl:

Reviewed by Adam Barth.

Replace OwnPtr with RefPtr.

* tests/UnitTestUtils/EWKTestView.cpp:
(EWKUnitTests::EWKTestView::init):
* tests/UnitTestUtils/EWKTestView.h:
(EWKTestView):

Source/WTF:

Reviewed by Gyuyoung Kim.

Remove OwnPtr support for Evas_Object* and add support for it
with RefPtr instead (the latter moved from WebCore).

* wtf/PlatformEfl.cmake:
* wtf/efl/OwnPtrEfl.cpp:
* wtf/efl/RefPtrEfl.cpp: Renamed from Source/WebCore/platform/efl/RefPtrEfl.cpp.
(WTF):
(WTF::refIfNotNull):
(WTF::derefIfNotNull):
* wtf/efl/RefPtrEfl.h: Renamed from Source/WebCore/platform/efl/RefPtrEfl.h.
(WTF):

Tools:

Reviewed by Adam Barth.

Replace OwnPtr with RefPtr.

* DumpRenderTree/efl/ImageDiff.cpp:
(calculateDifference):
(printImageDifferences):
(readImageFromStdin):
(main):

Modified Paths

trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/PlatformEfl.cmake
trunk/Source/WTF/wtf/efl/OwnPtrEfl.cpp
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/PlatformEfl.cmake
trunk/Source/WebCore/platform/efl/RenderThemeEfl.cpp
trunk/Source/WebCore/platform/efl/RenderThemeEfl.h
trunk/Source/WebKit/efl/ChangeLog
trunk/Source/WebKit/efl/tests/UnitTestUtils/EWKTestView.cpp
trunk/Source/WebKit/efl/tests/UnitTestUtils/EWKTestView.h
trunk/Tools/ChangeLog
trunk/Tools/DumpRenderTree/efl/ImageDiff.cpp


Added Paths

trunk/Source/WTF/wtf/efl/RefPtrEfl.cpp
trunk/Source/WTF/wtf/efl/RefPtrEfl.h


Removed Paths

trunk/Source/WebCore/platform/efl/RefPtrEfl.cpp
trunk/Source/WebCore/platform/efl/RefPtrEfl.h




Diff

Modified: trunk/Source/WTF/ChangeLog (128572 => 128573)

--- trunk/Source/WTF/ChangeLog	2012-09-14 09:12:48 UTC (rev 128572)
+++ trunk/Source/WTF/ChangeLog	2012-09-14 09:27:28 UTC (rev 128573)
@@ -1,3 +1,22 @@
+2012-09-13  Kenneth Rohde Christiansen  
+
+Evas_Object* is a ref'ed structure, so tread it as such
+https://bugs.webkit.org/show_bug.cgi?id=96659
+
+Reviewed by Gyuyoung Kim.
+
+Remove OwnPtr support for Evas_Object* and add support for it
+with RefPtr instead (the latter moved from WebCore).
+
+* wtf/PlatformEfl.cmake:
+* wtf/efl/OwnPtrEfl.cpp:
+* wtf/efl/RefPtrEfl.cpp: Renamed from Source/WebCore/platform/efl/RefPtrEfl.cpp.
+(WTF):
+(WTF::refIfNotNull):
+(WTF::derefIfNotNull):
+* wtf/efl/RefPtrEfl.h: Renamed from Source/WebCore/platform/efl/RefPtrEfl.h.
+(WTF):
+
 2012-09-14  Gyuyoung Kim  
 
 Unreviewed, rolling out r128507.


Modified: trunk/Source/WTF/wtf/PlatformEfl.cmake (128572 => 128573)

--- trunk/Source/WTF/wtf/PlatformEfl.cmake	2012-09-14 09:12:48 UTC (rev 128572)
+++ trunk/Source/WTF/wtf/PlatformEfl.cmake	2012-09-14 09:27:28 UTC (rev 128573)
@@ -1,6 +1,7 @@
 LIST(APPEND WTF_SOURCES
 efl/MainThreadEfl.cpp
 efl/OwnPtrEfl.cpp
+efl/RefPtrEfl.cpp
 gobject/GOwnPtr.cpp
 gobject/GRefPtr.cpp
 
@@ -33,5 +34,6 @@
 ${GLIB_INCLUDE_DIRS}
 ${ICU_INCLUDE_DIRS}
 ${_javascript_CORE_DIR}/wtf/gobject
-${_javascript_CORE_DIR}/wtf/unicode/
+${_javascript_CORE_DIR}/wtf/unicode
+${_javascript_CORE_DIR}/wtf/efl
 )


Modified: trunk/Source/WTF/wtf/efl/OwnPtrEfl.cpp (128572 => 128573)

--- trunk/Source/WTF/wtf/efl/OwnPtrEfl.cpp	2012-09-14 09:12:48 UTC (rev 128572)
+++ trunk/Source/WTF/wtf/efl/OwnPtrEfl.cpp	2012-09-14 09:27:28 UTC (rev 128573)
@@ -40,11 +40,6 @@
 ecore_evas_free(ptr);
 }
 
-void deleteOwnedPtr(Evas_Object* ptr)
-{
-evas_object_del(ptr);
-}
-
 void deleteOwnedPtr(Ecore_Pipe* ptr)
 {
 if (ptr)


Copied: trunk/Source/WTF/wtf/efl/RefPtrEfl.cpp (from rev 128572, trunk/Source/WebCore/platform/efl/RefPtrEfl.cpp) (0 => 128573)

--- trunk/Source/WTF/wtf/efl/RefPtrEfl.cpp	(rev 0)
+++ trunk/Source/WTF/wtf/efl/RefPtrEfl.cpp	2012-09-14 09:27:28 UTC (rev 128573)
@@ -0,0 +1,48 @@
+/*
+ *  Copyright (C) 2011 Samsung Electronics
+ *  Copyright (C) 2012 Intel Corporation. All rights reserved.
+ *
+ *  This library is free software; you can redistribute it and/or
+ *  modify it under the terms of the GNU Lesser General Public
+ *  License as published by the Free Software Foundation; either
+ *  version 2 of the License, or (at your option) any later version.
+ *
+ *  This library is distributed in the hope that it will be useful,
+ *  but WITHOUT ANY WARRANTY; without even the implied warranty of
+ *  MERCHANTABILITY or FITNESS FOR A PARTICULAR PU

[webkit-changes] [128571] trunk/Source/WebCore

2012-09-14 Thread commit-queue

Title: [128571] trunk/Source/WebCore








Revision 128571
Author commit-qu...@webkit.org
Date 2012-09-14 02:02:07 -0700 (Fri, 14 Sep 2012)


Log Message
Web Inspector: [WebGL] Refactoring: move the proxy wrapping method up to the base class
https://bugs.webkit.org/show_bug.cgi?id=96515

Patch by Andrey Adaikin  on 2012-09-14
Reviewed by Vsevolod Vlasov.

Move the proxyObject() method up from WebGLRenderingContextResource to the Resource class, so that it could be reused later for wrapping a 2D context.

* inspector/InjectedScriptWebGLModuleSource.js:
(.):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/InjectedScriptWebGLModuleSource.js




Diff

Modified: trunk/Source/WebCore/ChangeLog (128570 => 128571)

--- trunk/Source/WebCore/ChangeLog	2012-09-14 08:42:44 UTC (rev 128570)
+++ trunk/Source/WebCore/ChangeLog	2012-09-14 09:02:07 UTC (rev 128571)
@@ -1,3 +1,15 @@
+2012-09-14  Andrey Adaikin  
+
+Web Inspector: [WebGL] Refactoring: move the proxy wrapping method up to the base class
+https://bugs.webkit.org/show_bug.cgi?id=96515
+
+Reviewed by Vsevolod Vlasov.
+
+Move the proxyObject() method up from WebGLRenderingContextResource to the Resource class, so that it could be reused later for wrapping a 2D context.
+
+* inspector/InjectedScriptWebGLModuleSource.js:
+(.):
+
 2012-09-14  Kangil Han  
 
 Fix unused parameter compile warnings in WebCore.


Modified: trunk/Source/WebCore/inspector/InjectedScriptWebGLModuleSource.js (128570 => 128571)

--- trunk/Source/WebCore/inspector/InjectedScriptWebGLModuleSource.js	2012-09-14 08:42:44 UTC (rev 128570)
+++ trunk/Source/WebCore/inspector/InjectedScriptWebGLModuleSource.js	2012-09-14 09:02:07 UTC (rev 128571)
@@ -559,8 +559,9 @@
  */
 proxyObject: function()
 {
-// No proxy wrapping by default.
-return this.wrappedObject();
+if (!this._proxyObject)
+this._proxyObject = this._wrapObject();
+return this._proxyObject;
 },
 
 /**
@@ -667,11 +668,172 @@
 enumerable: false,
 configurable: true
 });
+},
+
+/**
+ * @return {Object}
+ */
+_wrapObject: function()
+{
+var wrappedObject = this.wrappedObject();
+if (!wrappedObject)
+return null;
+var proxy = Object.create(wrappedObject.__proto__); // In order to emulate "instanceof".
+
+var self = this;
+var customWrapFunctions = this._customWrapFunctions();
+function processProperty(property)
+{
+if (typeof wrappedObject[property] === "function") {
+var customWrapFunction = customWrapFunctions[property];
+if (customWrapFunction)
+proxy[property] = self._wrapCustomFunction(self, wrappedObject, wrappedObject[property], property, customWrapFunction);
+else
+proxy[property] = self._wrapFunction(self, wrappedObject, wrappedObject[property], property);
+} else if (/^[A-Z0-9_]+$/.test(property) && typeof wrappedObject[property] === "number") {
+// Fast access to enums and constants.
+proxy[property] = wrappedObject[property];
+} else {
+Object.defineProperty(proxy, property, {
+get: function()
+{
+return wrappedObject[property];
+},
+set: function(value)
+{
+// FIXME: Log the setter calls.
+console.error("FIXME: Setting an attribute %s was not logged.", property);
+wrappedObject[property] = value;
+},
+enumerable: true
+});
+}
+}
+
+var isEmpty = true;
+for (var property in wrappedObject) {
+isEmpty = false;
+processProperty(property);
+}
+if (isEmpty)
+return wrappedObject; // Nothing to proxy.
+
+this._bindObjectToResource(proxy);
+return proxy;
+},
+
+/**
+ * @param {Resource} resource
+ * @param {Object} originalObject
+ * @param {Function} originalFunction
+ * @param {string} functionName
+ * @param {Function} customWrapFunction
+ * @return {Function}
+ */
+_wrapCustomFunction: function(resource, originalObject, originalFunction, functionName, customWrapFunction)
+{
+return function()
+{
+var manager = resource.manager();
+var isCapturing = manager && manager.capturing();
+if (isCapturing)
+manager.captureArguments(resource, arguments);
+var wrapFunction = new Resource.WrapFunction(originalObject, originalFunction, functionName, arguments);
+customWrapFunction.apply(wrapFunction, arguments);
+

[webkit-changes] [128568] trunk/Source/WebCore

2012-09-14 Thread charles . wei

Title: [128568] trunk/Source/WebCore








Revision 128568
Author charles@torchmobile.com.cn
Date 2012-09-14 01:27:05 -0700 (Fri, 14 Sep 2012)


Log Message
Need to clear exception in JSDictionary for operations that might have.
https://bugs.webkit.org/show_bug.cgi?id=96614

Reviewed by Kentaro Hara.

Clear the exception if failed to convert the value inside the JSDictionary.
Otherwise, it might impact the following operations on the dictionary.

No new tests, the existing test at LayoutTest/storage/indexeddb/tutorial.html should work for JSC binding.

* bindings/js/JSDictionary.h:
(WebCore::JSDictionary::tryGetPropertyAndResult):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/js/JSDictionary.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (128567 => 128568)

--- trunk/Source/WebCore/ChangeLog	2012-09-14 08:09:45 UTC (rev 128567)
+++ trunk/Source/WebCore/ChangeLog	2012-09-14 08:27:05 UTC (rev 128568)
@@ -1,3 +1,18 @@
+2012-09-14  Charles Wei  
+
+Need to clear exception in JSDictionary for operations that might have.
+https://bugs.webkit.org/show_bug.cgi?id=96614
+
+Reviewed by Kentaro Hara.
+
+Clear the exception if failed to convert the value inside the JSDictionary. 
+Otherwise, it might impact the following operations on the dictionary.
+
+No new tests, the existing test at LayoutTest/storage/indexeddb/tutorial.html should work for JSC binding.
+
+* bindings/js/JSDictionary.h:
+(WebCore::JSDictionary::tryGetPropertyAndResult):
+
 2012-09-14  Grzegorz Czajkowski  
 
 Add method to get the list of all available dictionaries


Modified: trunk/Source/WebCore/bindings/js/JSDictionary.h (128567 => 128568)

--- trunk/Source/WebCore/bindings/js/JSDictionary.h	2012-09-14 08:09:45 UTC (rev 128567)
+++ trunk/Source/WebCore/bindings/js/JSDictionary.h	2012-09-14 08:27:05 UTC (rev 128568)
@@ -145,8 +145,10 @@
 Result result;
 convertValue(m_exec, value, result);
 
-if (m_exec->hadException())
+if (m_exec->hadException()) {
+m_exec->clearException();
 return ExceptionThrown;
+}
 
 setter(context, result);
 break;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

1 2 >

1 - 100 of 104 matches

Mail list logo