[webkit-changes] [129729] trunk/Source/WebCore
Title: [129729] trunk/Source/WebCore
Revision 129729
Author yo...@chromium.org
Date 2012-09-26 23:43:17 -0700 (Wed, 26 Sep 2012)
Log Message
[Forms] Move multiple fields related functions to BaseDateAndTimeInputType from TimeInputType
https://bugs.webkit.org/show_bug.cgi?id=97521
Reviewed by Kent Tamura.
This patch introduces new class BaseMultipleFieldsDateAndTimeInputType
for sharing code among multiple fields date/time input UI.
Member functions in BaseMultipleFieldsDateAndTimeInputType are moved
from TimeInputType. BaseMultipleFieldsDateAndTimeInputType.{cpp,h}
were copied from TimeInputType.{cpp,h} by r129721.
This patch affects ports which enable both ENABLE_INPUT_TYPE_TIME and
ENABLE_INPUT_MULTIPLE_FIELDS_UI.
No new tests. This patch doesn't change behavior.
* WebCore.gypi: Changed to have html/BaseMultipleFieldsDateAndTimeInputType.{cpp,h}
* html/BaseDateAndTimeInputType.h:
(BaseDateAndTimeInputType): Exposed setMillisecondToDateComponents as protected for BaseMultipleFieldsDateAndTimeInputType::restoreFormControlState().
* html/BaseMultipleFieldsDateAndTimeInputType.cpp:
(WebCore::BaseMultipleFieldsDateAndTimeInputType::DateTimeEditControlOwnerImpl::DateTimeEditControlOwnerImpl): Moved from TimeInputType::DateTimeEditControlOwnerImpl.
(WebCore::BaseMultipleFieldsDateAndTimeInputType::DateTimeEditControlOwnerImpl::~DateTimeEditControlOwnerImpl): ditto.
(WebCore::BaseMultipleFieldsDateAndTimeInputType::DateTimeEditControlOwnerImpl::didBlurFromControl): ditto.
(WebCore::BaseMultipleFieldsDateAndTimeInputType::DateTimeEditControlOwnerImpl::didFocusOnControl): ditto.
(WebCore::BaseMultipleFieldsDateAndTimeInputType::DateTimeEditControlOwnerImpl::editControlValueChanged): ditto.
(WebCore::BaseMultipleFieldsDateAndTimeInputType::DateTimeEditControlOwnerImpl::formatDateTimeFieldsState): Moved from TimeInputType::DateTimeEditControlOwnerImpl and changed to call formatDateTimeFieldsState() in BaseMultipleFieldsDateAndTimeInputTypeInputType class.
(WebCore::BaseMultipleFieldsDateAndTimeInputType::hasCustomFocusLogic): Moved from TimeInputType.
(WebCore::BaseMultipleFieldsDateAndTimeInputType::DateTimeEditControlOwnerImpl::isEditControlOwnerDisabled): ditto.
(WebCore::BaseMultipleFieldsDateAndTimeInputType::DateTimeEditControlOwnerImpl::isEditControlOwnerReadOnly): ditto.
(WebCore::BaseMultipleFieldsDateAndTimeInputType::BaseMultipleFieldsDateAndTimeInputType): ditto.
(WebCore::BaseMultipleFieldsDateAndTimeInputType::~BaseMultipleFieldsDateAndTimeInputType): ditto.
(WebCore::BaseMultipleFieldsDateAndTimeInputType::blur): ditto.
(WebCore::BaseMultipleFieldsDateAndTimeInputType::createRenderer): ditto.
(WebCore::BaseMultipleFieldsDateAndTimeInputType::createShadowSubtree): ditto.
(WebCore::BaseMultipleFieldsDateAndTimeInputType::destroyShadowSubtree): ditto.
(WebCore::BaseMultipleFieldsDateAndTimeInputType::focus): ditto.
(WebCore::BaseMultipleFieldsDateAndTimeInputType::forwardEvent): ditto.
(WebCore::BaseMultipleFieldsDateAndTimeInputType::disabledAttributeChanged): ditto.
(WebCore::BaseMultipleFieldsDateAndTimeInputType::handleKeydownEvent): ditto.
(WebCore::BaseMultipleFieldsDateAndTimeInputType::isKeyboardFocusable): ditto.
(WebCore::BaseMultipleFieldsDateAndTimeInputType::isMouseFocusable): ditto.
(WebCore::BaseMultipleFieldsDateAndTimeInputType::minOrMaxAttributeChanged): ditto.
(WebCore::BaseMultipleFieldsDateAndTimeInputType::readonlyAttributeChanged): ditto.
(WebCore::BaseMultipleFieldsDateAndTimeInputType::isTextField): ditto.
(WebCore::BaseMultipleFieldsDateAndTimeInputType::restoreFormControlState): ditto.
(WebCore::BaseMultipleFieldsDateAndTimeInputType::saveFormControlState): ditto.
(WebCore::BaseMultipleFieldsDateAndTimeInputType::setValue): ditto.
(WebCore::BaseMultipleFieldsDateAndTimeInputType::shouldUseInputMethod): ditto.
(WebCore::BaseMultipleFieldsDateAndTimeInputType::stepAttributeChanged): ditto.
(WebCore::BaseMultipleFieldsDateAndTimeInputType::updateInnerTextValue): Moved from TimeInputType and changed to call setupLayoutParameters() to set date/time format by each input type.
* html/BaseMultipleFieldsDateAndTimeInputType.h:
(BaseMultipleFieldsDateAndTimeInputType): Added.
(DateTimeEditControlOwnerImpl): Moved from TimeInputType.
* html/TimeInputType.cpp: Moved multiple fields UI related functions to BaseMultipleFieldsDateAndTimeInputType.
(WebCore::TimeInputType::TimeInputType): Changed base class name to BaseTimeInput.
(WebCore::TimeInputType::formatDateTimeFieldsState): Moved from TimeINput::DateTImeEditControlOwnerImpl class.
(WebCore::TimeInputType::setupLayoutParameters): Added for set time format.
* html/TimeInputType.h:
(TimeInputType): Chaned base class to BaseTimeInput which is alias of BaseDateAndTimeInputType or BaseMultipleFieldsDateAndTimeInputType.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/WebCore.gypi
trunk/Source/WebCore/html/BaseDateAndTimeInputType.h
trunk/Source/WebCore/html/BaseMultipleFieldsDateAndTimeInputType.cpp
[webkit-changes] [129730] trunk/Source/WTF
Title: [129730] trunk/Source/WTF
Revision 129730
Author commit-qu...@webkit.org
Date 2012-09-27 00:01:07 -0700 (Thu, 27 Sep 2012)
Log Message
[BlackBerry] Allow denormal floats in ARM VFP
https://bugs.webkit.org/show_bug.cgi?id=97008
Patch by Cosmin Truta ctr...@rim.com on 2012-09-26
Reviewed by Filip Pizlo.
Reviewed internally by Yong Li.
Cleared the Flush-to-Zero flag in the ARM FPSCR register on QNX.
* wtf/ThreadingPthreads.cpp:
(WTF::enableIEEE754Denormal): Added.
(WTF::initializeThreading):
(WTF::initializeCurrentThreadInternal):
Modified Paths
trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/ThreadingPthreads.cpp
Diff
Modified: trunk/Source/WTF/ChangeLog (129729 => 129730)
--- trunk/Source/WTF/ChangeLog 2012-09-27 06:43:17 UTC (rev 129729)
+++ trunk/Source/WTF/ChangeLog 2012-09-27 07:01:07 UTC (rev 129730)
@@ -1,3 +1,18 @@
+2012-09-26 Cosmin Truta ctr...@rim.com
+
+[BlackBerry] Allow denormal floats in ARM VFP
+https://bugs.webkit.org/show_bug.cgi?id=97008
+
+Reviewed by Filip Pizlo.
+Reviewed internally by Yong Li.
+
+Cleared the Flush-to-Zero flag in the ARM FPSCR register on QNX.
+
+* wtf/ThreadingPthreads.cpp:
+(WTF::enableIEEE754Denormal): Added.
+(WTF::initializeThreading):
+(WTF::initializeCurrentThreadInternal):
+
2012-09-26 Michael Saboff msab...@apple.com
Update ComplexTextController for 8 bit TextRun changes
Modified: trunk/Source/WTF/wtf/ThreadingPthreads.cpp (129729 => 129730)
--- trunk/Source/WTF/wtf/ThreadingPthreads.cpp 2012-09-27 06:43:17 UTC (rev 129729)
+++ trunk/Source/WTF/wtf/ThreadingPthreads.cpp 2012-09-27 07:01:07 UTC (rev 129730)
@@ -110,11 +110,26 @@
return mutex;
}
+#if OS(QNX) CPU(ARM_THUMB2)
+static void enableIEEE754Denormal()
+{
+// Clear the ARM_VFP_FPSCR_FZ flag in FPSCR.
+unsigned fpscr;
+asm volatile(vmrs %0, fpscr : =r(fpscr));
+fpscr = ~0x0100u;
+asm volatile(vmsr fpscr, %0 : : r(fpscr));
+}
+#endif
+
void initializeThreading()
{
if (atomicallyInitializedStaticMutex)
return;
+#if OS(QNX) CPU(ARM_THUMB2)
+enableIEEE754Denormal();
+#endif
+
WTF::double_conversion::initialize();
// StringImpl::empty() does not construct its static string in a threadsafe fashion,
// so ensure it has been initialized from here.
@@ -212,6 +227,10 @@
objc_registerThreadWithCollector();
#endif
+#if OS(QNX) CPU(ARM_THUMB2)
+enableIEEE754Denormal();
+#endif
+
ThreadIdentifier id = identifierByPthreadHandle(pthread_self());
ASSERT(id);
ThreadIdentifierData::initialize(id);
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [129731] trunk/Source/WebCore
Title: [129731] trunk/Source/WebCore
Revision 129731
Author par...@webkit.org
Date 2012-09-27 00:25:13 -0700 (Thu, 27 Sep 2012)
Log Message
Build fix for !USE(ICU_UNICODE) after r129662.
Convert LChar to UChar so we can call the existing function until the
other TextBreakIterator implemenations provide an overload for LChar.
* platform/text/TextBreakIterator.cpp:
(WebCore):
(WebCore::acquireLineBreakIterator):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/text/TextBreakIterator.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (129730 => 129731)
--- trunk/Source/WebCore/ChangeLog 2012-09-27 07:01:07 UTC (rev 129730)
+++ trunk/Source/WebCore/ChangeLog 2012-09-27 07:25:13 UTC (rev 129731)
@@ -1,3 +1,14 @@
+2012-09-27 Patrick Gansterer par...@webkit.org
+
+Build fix for !USE(ICU_UNICODE) after r129662.
+
+Convert LChar to UChar so we can call the existing function until the
+other TextBreakIterator implemenations provide an overload for LChar.
+
+* platform/text/TextBreakIterator.cpp:
+(WebCore):
+(WebCore::acquireLineBreakIterator):
+
2012-09-26 Yoshifumi Inoue yo...@chromium.org
[Forms] Move multiple fields related functions to BaseDateAndTimeInputType from TimeInputType
Modified: trunk/Source/WebCore/platform/text/TextBreakIterator.cpp (129730 => 129731)
--- trunk/Source/WebCore/platform/text/TextBreakIterator.cpp 2012-09-27 07:01:07 UTC (rev 129730)
+++ trunk/Source/WebCore/platform/text/TextBreakIterator.cpp 2012-09-27 07:25:13 UTC (rev 129731)
@@ -49,4 +49,14 @@
return textBreakCurrent(it);
}
+#if !USE(ICU_UNICODE)
+TextBreakIterator* acquireLineBreakIterator(const LChar* string, int length, const AtomicString locale)
+{
+VectorUChar utf16string(length);
+for (int i = 0; i length; ++i)
+utf16string[i] = string[i];
+return acquireLineBreakIterator(utf16string.data(), length, locale);
+}
+#endif
+
} // namespace WebCore
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [129732] trunk
Title: [129732] trunk Revision 129732 Author par...@webkit.org Date 2012-09-27 00:30:06 -0700 (Thu, 27 Sep 2012) Log Message [WINCE] Enable JIT by default * Source/cmake/OptionsWinCE.cmake: Modified Paths trunk/ChangeLog trunk/Source/cmake/OptionsWinCE.cmake Diff Modified: trunk/ChangeLog (129731 => 129732) --- trunk/ChangeLog 2012-09-27 07:25:13 UTC (rev 129731) +++ trunk/ChangeLog 2012-09-27 07:30:06 UTC (rev 129732) @@ -1,3 +1,9 @@ +2012-09-27 Patrick Gansterer par...@webkit.org + +[WINCE] Enable JIT by default + +* Source/cmake/OptionsWinCE.cmake: + 2012-09-26 Martin Robinson mrobin...@igalia.com [GTK] Use XDamage to simplify RedirectedXCompositeWindow Modified: trunk/Source/cmake/OptionsWinCE.cmake (129731 => 129732) --- trunk/Source/cmake/OptionsWinCE.cmake 2012-09-27 07:25:13 UTC (rev 129731) +++ trunk/Source/cmake/OptionsWinCE.cmake 2012-09-27 07:30:06 UTC (rev 129732) @@ -23,6 +23,5 @@ WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_DRAG_SUPPORT OFF) WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_FTPDIR OFF) WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_INSPECTOR OFF) -WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_JIT OFF) WEBKIT_OPTION_DEFAULT_PORT_VALUE(USE_SYSTEM_MALLOC ON) WEBKIT_OPTION_END() ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [129734] trunk/Source/WebCore
Title: [129734] trunk/Source/WebCore
Revision 129734
Author yu...@chromium.org
Date 2012-09-27 00:57:49 -0700 (Thu, 27 Sep 2012)
Log Message
Web Inspector: expose debug memory instrumentation debug data through the protocol
https://bugs.webkit.org/show_bug.cgi?id=97683
Reviewed by Pavel Feldman.
Memory.getProcessMemoryDistribution command now returns number of instrumented
objects that were found and the number of the objects that were counted by
the instrumentation but were not actually allocated by the memory allocator.
These numbers are only added to the response if embedder provides access to the
set of all live heap objects. These numbers are intended to be used for testing
memory instrumentation.
* inspector/InspectorMemoryAgent.cpp:
(WebCore::collectDomTreeInfo):
* inspector/MemoryInstrumentationImpl.cpp:
(WebCore::MemoryInstrumentationImpl::MemoryInstrumentationImpl):
(WebCore::MemoryInstrumentationImpl::checkCountedObject):
* inspector/MemoryInstrumentationImpl.h:
(WebCore::MemoryInstrumentationImpl::checkInstrumentedObjects):
(WebCore::MemoryInstrumentationImpl::totalCountedObjects):
(WebCore::MemoryInstrumentationImpl::totalObjectsNotInAllocatedSet):
(MemoryInstrumentationImpl):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/InspectorMemoryAgent.cpp
trunk/Source/WebCore/inspector/MemoryInstrumentationImpl.cpp
trunk/Source/WebCore/inspector/MemoryInstrumentationImpl.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (129733 => 129734)
--- trunk/Source/WebCore/ChangeLog 2012-09-27 07:53:07 UTC (rev 129733)
+++ trunk/Source/WebCore/ChangeLog 2012-09-27 07:57:49 UTC (rev 129734)
@@ -1,3 +1,28 @@
+2012-09-27 Yury Semikhatsky yu...@chromium.org
+
+Web Inspector: expose debug memory instrumentation debug data through the protocol
+https://bugs.webkit.org/show_bug.cgi?id=97683
+
+Reviewed by Pavel Feldman.
+
+Memory.getProcessMemoryDistribution command now returns number of instrumented
+objects that were found and the number of the objects that were counted by
+the instrumentation but were not actually allocated by the memory allocator.
+These numbers are only added to the response if embedder provides access to the
+set of all live heap objects. These numbers are intended to be used for testing
+memory instrumentation.
+
+* inspector/InspectorMemoryAgent.cpp:
+(WebCore::collectDomTreeInfo):
+* inspector/MemoryInstrumentationImpl.cpp:
+(WebCore::MemoryInstrumentationImpl::MemoryInstrumentationImpl):
+(WebCore::MemoryInstrumentationImpl::checkCountedObject):
+* inspector/MemoryInstrumentationImpl.h:
+(WebCore::MemoryInstrumentationImpl::checkInstrumentedObjects):
+(WebCore::MemoryInstrumentationImpl::totalCountedObjects):
+(WebCore::MemoryInstrumentationImpl::totalObjectsNotInAllocatedSet):
+(MemoryInstrumentationImpl):
+
2012-09-27 Mihnea Ovidenie mih...@adobe.com
[CSSRegions]Refactor RenderFlowThread::contentLogical(Width/Height/Left)OfFirstRegion
Modified: trunk/Source/WebCore/inspector/InspectorMemoryAgent.cpp (129733 => 129734)
--- trunk/Source/WebCore/inspector/InspectorMemoryAgent.cpp 2012-09-27 07:53:07 UTC (rev 129733)
+++ trunk/Source/WebCore/inspector/InspectorMemoryAgent.cpp 2012-09-27 07:57:49 UTC (rev 129734)
@@ -542,6 +542,20 @@
}
+static void addMemoryInstrumentationDebugData(TypeBuilder::ArrayInspectorMemoryBlock* children, const MemoryInstrumentationImpl memoryInstrumentation)
+{
+if (memoryInstrumentation.checkInstrumentedObjects()) {
+RefPtrInspectorMemoryBlock totalInstrumented = InspectorMemoryBlock::create().setName(InstrumentedObjectsCount);
+totalInstrumented-setSize(memoryInstrumentation.totalCountedObjects());
+
+RefPtrInspectorMemoryBlock incorrectlyInstrumented = InspectorMemoryBlock::create().setName(InstrumentedButNotAllocatedObjectsCount);
+incorrectlyInstrumented-setSize(memoryInstrumentation.totalObjectsNotInAllocatedSet());
+
+children-addItem(totalInstrumented);
+children-addItem(incorrectlyInstrumented);
+}
+}
+
static void collectDomTreeInfo(Page* page, InspectorClient* inspectorClient, VisitedObjects visitedObjects, TypeBuilder::ArrayInspectorMemoryBlock* children, InspectorDataCounter* inspectorData)
{
HashSetconst void* allocatedObjects;
@@ -570,6 +584,7 @@
domTreesIterator.visitMemoryCache();
domTreesIterator.dumpStatistics(children, inspectorData);
+addMemoryInstrumentationDebugData(children, memoryInstrumentation);
}
static void addPlatformComponentsInfo(PassRefPtrTypeBuilder::ArrayInspectorMemoryBlock children)
Modified: trunk/Source/WebCore/inspector/MemoryInstrumentationImpl.cpp (129733 => 129734)
--- trunk/Source/WebCore/inspector/MemoryInstrumentationImpl.cpp 2012-09-27 07:53:07 UTC (rev 129733)
+++
[webkit-changes] [129735] trunk/LayoutTests
Title: [129735] trunk/LayoutTests
Revision 129735
Author commit-qu...@webkit.org
Date 2012-09-27 01:11:50 -0700 (Thu, 27 Sep 2012)
Log Message
[EFL] fast/layers/video-layer.html needs rebaselining after r129687
https://bugs.webkit.org/show_bug.cgi?id=97764
Unreviewed EFL gardening.
Rebaseline fast/layers/video-layer.html due to r129687. The volume
button is no longer shown for that test.
Patch by Christophe Dumez christophe.du...@intel.com on 2012-09-27
* platform/efl/fast/layers/video-layer-expected.png:
* platform/efl/fast/layers/video-layer-expected.txt:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/efl/fast/layers/video-layer-expected.png
trunk/LayoutTests/platform/efl/fast/layers/video-layer-expected.txt
Diff
Modified: trunk/LayoutTests/ChangeLog (129734 => 129735)
--- trunk/LayoutTests/ChangeLog 2012-09-27 07:57:49 UTC (rev 129734)
+++ trunk/LayoutTests/ChangeLog 2012-09-27 08:11:50 UTC (rev 129735)
@@ -1,3 +1,16 @@
+2012-09-27 Christophe Dumez christophe.du...@intel.com
+
+[EFL] fast/layers/video-layer.html needs rebaselining after r129687
+https://bugs.webkit.org/show_bug.cgi?id=97764
+
+Unreviewed EFL gardening.
+
+Rebaseline fast/layers/video-layer.html due to r129687. The volume
+button is no longer shown for that test.
+
+* platform/efl/fast/layers/video-layer-expected.png:
+* platform/efl/fast/layers/video-layer-expected.txt:
+
2012-09-26 Keishi Hattori kei...@webkit.org
Add tests for datalist UI for input type date
Modified: trunk/LayoutTests/platform/efl/fast/layers/video-layer-expected.png
(Binary files differ)
Modified: trunk/LayoutTests/platform/efl/fast/layers/video-layer-expected.txt (129734 => 129735)
--- trunk/LayoutTests/platform/efl/fast/layers/video-layer-expected.txt 2012-09-27 07:57:49 UTC (rev 129734)
+++ trunk/LayoutTests/platform/efl/fast/layers/video-layer-expected.txt 2012-09-27 08:11:50 UTC (rev 129735)
@@ -20,19 +20,17 @@
layer at (59,241) size 300x20 scrollHeight 28
RenderDeprecatedFlexibleBox (relative positioned) {DIV} at (0,130) size 300x20
RenderButton {INPUT} at (0,0) size 20x20
-RenderDeprecatedFlexibleBox {DIV} at (20,0) size 220x20
+RenderDeprecatedFlexibleBox {DIV} at (20,0) size 240x20
RenderDeprecatedFlexibleBox {DIV} at (0,0) size 63x28
RenderBlock (anonymous) at (4,4) size 55x20
RenderText {#text} at (0,0) size 55x12
text run at (0,0) width 55: 00:00 / 00:00
- RenderSlider {INPUT} at (63,0) size 157x20
-RenderDeprecatedFlexibleBox {DIV} at (2,0) size 153x20
- RenderBlock {DIV} at (0,4) size 141x12
- RenderBlock {DIV} at (141,4) size 12x12
-RenderButton {INPUT} at (240,0) size 20x20
+ RenderSlider {INPUT} at (63,0) size 177x20
+RenderDeprecatedFlexibleBox {DIV} at (2,0) size 173x20
+ RenderBlock {DIV} at (0,4) size 161x12
+ RenderBlock {DIV} at (161,4) size 12x12
RenderButton {INPUT} at (260,0) size 20x20
-RenderBlock {DIV} at (280,0) size 20x20
+RenderButton {INPUT} at (280,0) size 20x20
+RenderBlock {DIV} at (300,10) size 0x0
layer at (144,245) size 12x12
RenderBlock (relative positioned) {DIV} at (0,0) size 12x12
-layer at (339,241) size 20x20
- RenderButton zI: 2 {INPUT} at (0,0) size 20x20
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [129736] trunk/Source/JavaScriptCore
Title: [129736] trunk/Source/_javascript_Core
Revision 129736
Author par...@webkit.org
Date 2012-09-27 01:12:05 -0700 (Thu, 27 Sep 2012)
Log Message
[CMake] Fix build with static _javascript_Core library
* shell/CMakeLists.txt: Define STATICALLY_LINKED_WITH_JavaScriptCore if
_javascript_Core_LIBRARY_TYPE is set to STATIC.
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/shell/CMakeLists.txt
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (129735 => 129736)
--- trunk/Source/_javascript_Core/ChangeLog 2012-09-27 08:11:50 UTC (rev 129735)
+++ trunk/Source/_javascript_Core/ChangeLog 2012-09-27 08:12:05 UTC (rev 129736)
@@ -1,3 +1,10 @@
+2012-09-27 Patrick Gansterer par...@webkit.org
+
+[CMake] Fix build with static _javascript_Core library
+
+* shell/CMakeLists.txt: Define STATICALLY_LINKED_WITH_JavaScriptCore if
+_javascript_Core_LIBRARY_TYPE is set to STATIC.
+
2012-09-26 Gavin Barraclough barraclo...@apple.com
Proxy the global this in JSC
Modified: trunk/Source/_javascript_Core/shell/CMakeLists.txt (129735 => 129736)
--- trunk/Source/_javascript_Core/shell/CMakeLists.txt 2012-09-27 08:11:50 UTC (rev 129735)
+++ trunk/Source/_javascript_Core/shell/CMakeLists.txt 2012-09-27 08:12:05 UTC (rev 129736)
@@ -7,6 +7,10 @@
${_javascript_Core_LIBRARY_NAME}
)
+IF (${_javascript_Core_LIBRARY_TYPE} MATCHES STATIC)
+ADD_DEFINITIONS(-DSTATICALLY_LINKED_WITH_JavaScriptCore)
+ENDIF ()
+
WEBKIT_INCLUDE_CONFIG_FILES_IF_EXISTS()
WEBKIT_WRAP_SOURCELIST(${JSC_SOURCES})
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [129737] trunk/Source/WebCore
Title: [129737] trunk/Source/WebCore Revision 129737 Author mr...@apple.com Date 2012-09-27 01:13:15 -0700 (Thu, 27 Sep 2012) Log Message Follow-up to r129723 to once more allow parsing of scoped names in IDL files. Patch by Takashi Sakamoto ta...@google.com on 2012-09-27 Reviewed by Kentaro Hara. This functionality was supported by the old IDL parser but was lost in the rewrite of the parser in r129723. It is being reinstated to unbreak clients that currently depend on it, but will likely be removed in the future once those clients have a chance to adopt an approach that more closely follows the WebIDL syntax. * bindings/scripts/IDLParser.pm: (parseDefinition): (parseInheritance): (parseImplementsStatement): (parseExtendedAttribute): (parseExtendedAttribute2): (parseExtendedAttributeRest2): (parseExtendedAttributeRest3): (parseScopedNameListNoComma): (parseNonAnyType): (parseExceptionList): (parseDefinitionOld): (parseScopedName): (parseAbsoluteScopedName): (parseRelativeScopedName): (parseScopedNameParts): (parseScopedNameList): (parseScopedNames): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/bindings/scripts/IDLParser.pm Diff Modified: trunk/Source/WebCore/ChangeLog (129736 => 129737) --- trunk/Source/WebCore/ChangeLog 2012-09-27 08:12:05 UTC (rev 129736) +++ trunk/Source/WebCore/ChangeLog 2012-09-27 08:13:15 UTC (rev 129737) @@ -1,3 +1,33 @@ +2012-09-27 Takashi Sakamoto ta...@google.com + +Follow-up to r129723 to once more allow parsing of scoped names in IDL files. + +Reviewed by Kentaro Hara. + +This functionality was supported by the old IDL parser but was lost in the rewrite of the parser +in r129723. It is being reinstated to unbreak clients that currently depend on it, but will likely +be removed in the future once those clients have a chance to adopt an approach that more closely +follows the WebIDL syntax. + +* bindings/scripts/IDLParser.pm: +(parseDefinition): +(parseInheritance): +(parseImplementsStatement): +(parseExtendedAttribute): +(parseExtendedAttribute2): +(parseExtendedAttributeRest2): +(parseExtendedAttributeRest3): +(parseScopedNameListNoComma): +(parseNonAnyType): +(parseExceptionList): +(parseDefinitionOld): +(parseScopedName): +(parseAbsoluteScopedName): +(parseRelativeScopedName): +(parseScopedNameParts): +(parseScopedNameList): +(parseScopedNames): + 2012-09-27 Yury Semikhatsky yu...@chromium.org Web Inspector: expose debug memory instrumentation debug data through the protocol Modified: trunk/Source/WebCore/bindings/scripts/IDLParser.pm (129736 => 129737) --- trunk/Source/WebCore/bindings/scripts/IDLParser.pm 2012-09-27 08:12:05 UTC (rev 129736) +++ trunk/Source/WebCore/bindings/scripts/IDLParser.pm 2012-09-27 08:13:15 UTC (rev 129737) @@ -208,31 +208,32 @@ my $nextPrimitiveType_1 = '^(int|long|short|unsigned)$'; my $nextPrimitiveType_2 = '^(double|float|unrestricted)$'; my $nextSetGetRaises2_1 = '^(;|getraises|setraises)$'; -my $nextArgumentList_1 = '^(\(|ByteString|DOMString|Date|\[|any|boolean|byte|double|float|in|int|long|object|octet|optional|sequence|short|unrestricted|unsigned)$'; +my $nextArgumentList_1 = '^(\(|::|ByteString|DOMString|Date|\[|any|boolean|byte|double|float|in|int|long|object|octet|optional|sequence|short|unrestricted|unsigned)$'; my $nextNonAnyType_1 = '^(boolean|byte|double|float|int|long|octet|short|unrestricted|unsigned)$'; -my $nextInterfaceMemberOld_1 = '^(\(|ByteString|DOMString|Date|any|attribute|boolean|byte|creator|deleter|double|float|getter|inherit|int|legacycaller|long|object|octet|readonly|sequence|serializer|setter|short|static|stringifier|unrestricted|unsigned|void)$'; +my $nextInterfaceMemberOld_1 = '^(\(|::|ByteString|DOMString|Date|any|attribute|boolean|byte|creator|deleter|double|float|getter|inherit|int|legacycaller|long|object|octet|readonly|sequence|serializer|setter|short|static|stringifier|unrestricted|unsigned|void)$'; my $nextOptionalIteratorInterfaceOrObject_1 = '^(;|=)$'; my $nextAttributeOrOperationOrIterator_1 = '^(static|stringifier)$'; -my $nextAttributeOrOperationOrIterator_2 = '^(\(|ByteString|DOMString|Date|any|boolean|byte|creator|deleter|double|float|getter|int|legacycaller|long|object|octet|sequence|setter|short|unrestricted|unsigned|void)$'; +my $nextAttributeOrOperationOrIterator_2 = '^(\(|::|ByteString|DOMString|Date|any|boolean|byte|creator|deleter|double|float|getter|int|legacycaller|long|object|octet|sequence|setter|short|unrestricted|unsigned|void)$'; my $nextUnrestrictedFloatType_1 = '^(double|float)$'; -my $nextExtendedAttributeRest3_1 = '^(,|\])$'; -my $nextExceptionField_1 = '^(\(|ByteString|DOMString|Date|any|boolean|byte|double|float|int|long|object|octet|sequence|short|unrestricted|unsigned)$'; -my $nextType_1 =
[webkit-changes] [129739] trunk/Source/WebCore
Title: [129739] trunk/Source/WebCore Revision 129739 Author yo...@chromium.org Date 2012-09-27 01:22:03 -0700 (Thu, 27 Sep 2012) Log Message [Forms] BaseMultipleFieldsDateAndTimeInputType class should inherit DateTimeEditElement::EditControlOwner rather than containing https://bugs.webkit.org/show_bug.cgi?id=97756 Reviewed by Kent Tamura. This patch changes class hierarchy of BaseMultipleFieldsDateAndTimeInputType to inherit from DateTimeEditElement::EditControlOwner rather than containing an instance of DateTimeEditElement::EditControlOwner for saving memory, although one pointer, and one memory fetch on using HTMLInputElement. Note: This patch affects ports which enable both ENABLE_INPUT_TYPE_TIME and ENABLE_INPUT_MULTIPLE_FIELDS_UI. No new tests. This patch doesn't change behavior. * html/BaseMultipleFieldsDateAndTimeInputType.cpp: DateTimeEditElement::EditControlOwner::DateTimeformatDateTimeFieldsState was removed. We no longer need to redirection. Each date/time input type classe implements it. (WebCore::BaseMultipleFieldsDateAndTimeInputType::didBlurFromControl): Moved from DateTimeEditControlOwnerImpl and removed reference of m_dateTimeInputType. (WebCore::BaseMultipleFieldsDateAndTimeInputType::didFocusOnControl): ditto. (WebCore::BaseMultipleFieldsDateAndTimeInputType::editControlValueChanged): ditto. (WebCore::BaseMultipleFieldsDateAndTimeInputType::isEditControlOwnerDisabled): ditto. (WebCore::BaseMultipleFieldsDateAndTimeInputType::isEditControlOwnerReadOnly): ditto. (WebCore::BaseMultipleFieldsDateAndTimeInputType::BaseMultipleFieldsDateAndTimeInputType): ditto. (WebCore::BaseMultipleFieldsDateAndTimeInputType::createShadowSubtree): Changed to pass BaseMultipleFieldsDateAndTimeInputType instead of DateTimeEditControlOwnerImpl. * html/BaseMultipleFieldsDateAndTimeInputType.h: Changed base class to have DateTImeEditElement::EditControlOwner. (BaseMultipleFieldsDateAndTimeInputType): Removed DateTimeEditControlOwnerImpl class and member variable m_dateTimeEditControlOwner. Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/html/BaseMultipleFieldsDateAndTimeInputType.cpp trunk/Source/WebCore/html/BaseMultipleFieldsDateAndTimeInputType.h Diff Modified: trunk/Source/WebCore/ChangeLog (129738 => 129739) --- trunk/Source/WebCore/ChangeLog 2012-09-27 08:17:24 UTC (rev 129738) +++ trunk/Source/WebCore/ChangeLog 2012-09-27 08:22:03 UTC (rev 129739) @@ -1,3 +1,32 @@ +2012-09-27 Yoshifumi Inoue yo...@chromium.org + +[Forms] BaseMultipleFieldsDateAndTimeInputType class should inherit DateTimeEditElement::EditControlOwner rather than containing +https://bugs.webkit.org/show_bug.cgi?id=97756 + +Reviewed by Kent Tamura. + +This patch changes class hierarchy of BaseMultipleFieldsDateAndTimeInputType +to inherit from DateTimeEditElement::EditControlOwner rather than +containing an instance of DateTimeEditElement::EditControlOwner for +saving memory, although one pointer, and one memory fetch on using +HTMLInputElement. + +Note: This patch affects ports which enable both ENABLE_INPUT_TYPE_TIME and +ENABLE_INPUT_MULTIPLE_FIELDS_UI. + +No new tests. This patch doesn't change behavior. + +* html/BaseMultipleFieldsDateAndTimeInputType.cpp: DateTimeEditElement::EditControlOwner::DateTimeformatDateTimeFieldsState was removed. We no longer need to redirection. Each date/time input type classe implements it. +(WebCore::BaseMultipleFieldsDateAndTimeInputType::didBlurFromControl): Moved from DateTimeEditControlOwnerImpl and removed reference of m_dateTimeInputType. +(WebCore::BaseMultipleFieldsDateAndTimeInputType::didFocusOnControl): ditto. +(WebCore::BaseMultipleFieldsDateAndTimeInputType::editControlValueChanged): ditto. +(WebCore::BaseMultipleFieldsDateAndTimeInputType::isEditControlOwnerDisabled): ditto. +(WebCore::BaseMultipleFieldsDateAndTimeInputType::isEditControlOwnerReadOnly): ditto. +(WebCore::BaseMultipleFieldsDateAndTimeInputType::BaseMultipleFieldsDateAndTimeInputType): ditto. +(WebCore::BaseMultipleFieldsDateAndTimeInputType::createShadowSubtree): Changed to pass BaseMultipleFieldsDateAndTimeInputType instead of DateTimeEditControlOwnerImpl. +* html/BaseMultipleFieldsDateAndTimeInputType.h: Changed base class to have DateTImeEditElement::EditControlOwner. +(BaseMultipleFieldsDateAndTimeInputType): Removed DateTimeEditControlOwnerImpl class and member variable m_dateTimeEditControlOwner. + 2012-09-27 Keishi Hattori kei...@webkit.org SuggestionPicker should support rtl Modified: trunk/Source/WebCore/html/BaseMultipleFieldsDateAndTimeInputType.cpp (129738 => 129739) --- trunk/Source/WebCore/html/BaseMultipleFieldsDateAndTimeInputType.cpp 2012-09-27 08:17:24 UTC (rev 129738) +++ trunk/Source/WebCore/html/BaseMultipleFieldsDateAndTimeInputType.cpp 2012-09-27 08:22:03 UTC (rev 129739) @@
[webkit-changes] [129740] trunk/LayoutTests
Title: [129740] trunk/LayoutTests Revision 129740 Author rak...@webkit.org Date 2012-09-27 01:36:42 -0700 (Thu, 27 Sep 2012) Log Message [EFL] Unskip http/tests/security/xss-eval.html again. Fix was re-landed in r129712. * platform/efl/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/efl/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (129739 => 129740) --- trunk/LayoutTests/ChangeLog 2012-09-27 08:22:03 UTC (rev 129739) +++ trunk/LayoutTests/ChangeLog 2012-09-27 08:36:42 UTC (rev 129740) @@ -1,3 +1,11 @@ +2012-09-27 Raphael Kubo da Costa raphael.kubo.da.co...@intel.com + +[EFL] Unskip http/tests/security/xss-eval.html again. + +Fix was re-landed in r129712. + +* platform/efl/TestExpectations: + 2012-09-27 Keishi Hattori kei...@webkit.org SuggestionPicker should support rtl Modified: trunk/LayoutTests/platform/efl/TestExpectations (129739 => 129740) --- trunk/LayoutTests/platform/efl/TestExpectations 2012-09-27 08:22:03 UTC (rev 129739) +++ trunk/LayoutTests/platform/efl/TestExpectations 2012-09-27 08:36:42 UTC (rev 129740) @@ -1083,8 +1083,5 @@ # Frame does not get focus as expected webkit.org/b/97077 inspector/extensions/extensions-panel.html [ Failure ] -# Marking this as failing again, since r129592 was rolled out. -webkit.org/b/97529 http/tests/security/xss-eval.html [ Failure ] - # Needs rebaseline. webkit.org/b/97401 mathml/presentation/tables.xhtml [ Failure ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [129741] trunk/LayoutTests
Title: [129741] trunk/LayoutTests Revision 129741 Author commit-qu...@webkit.org Date 2012-09-27 01:57:30 -0700 (Thu, 27 Sep 2012) Log Message [EFL] Skip fast/dom/Geolocation to make LayoutTests faster https://bugs.webkit.org/show_bug.cgi?id=97765 Unreviewed EFL gardening. Skip fast/dom/Geolocation for EFL port instead of marking them with Failure expectation. This makes running LayoutTests much faster. Patch by Christophe Dumez christophe.du...@intel.com on 2012-09-27 * platform/efl/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/efl/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (129740 => 129741) --- trunk/LayoutTests/ChangeLog 2012-09-27 08:36:42 UTC (rev 129740) +++ trunk/LayoutTests/ChangeLog 2012-09-27 08:57:30 UTC (rev 129741) @@ -1,3 +1,16 @@ +2012-09-27 Christophe Dumez christophe.du...@intel.com + +[EFL] Skip fast/dom/Geolocation to make LayoutTests faster +https://bugs.webkit.org/show_bug.cgi?id=97765 + +Unreviewed EFL gardening. + +Skip fast/dom/Geolocation for EFL port instead of marking +them with Failure expectation. This makes running +LayoutTests much faster. + +* platform/efl/TestExpectations: + 2012-09-27 Raphael Kubo da Costa raphael.kubo.da.co...@intel.com [EFL] Unskip http/tests/security/xss-eval.html again. Modified: trunk/LayoutTests/platform/efl/TestExpectations (129740 => 129741) --- trunk/LayoutTests/platform/efl/TestExpectations 2012-09-27 08:36:42 UTC (rev 129740) +++ trunk/LayoutTests/platform/efl/TestExpectations 2012-09-27 08:57:30 UTC (rev 129741) @@ -819,7 +819,7 @@ webkit.org/b/68591 http/tests/inspector/filesystem # The EFL port has no support for the Geolocation -webkit.org/b/82140 fast/dom/Geolocation [ Failure ] +webkit.org/b/82140 fast/dom/Geolocation [ Skip ] webkit.org/b/82140 fast/dom/Window/window-properties-geolocation.html [ Failure ] webkit.org/b/82140 inspector/geolocation-error.html [ Failure ] webkit.org/b/82140 inspector/geolocation-success.html [ Failure ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [129742] trunk/Source/WebKit2
Title: [129742] trunk/Source/WebKit2 Revision 129742 Author ma...@webkit.org Date 2012-09-27 02:24:59 -0700 (Thu, 27 Sep 2012) Log Message [WK2] IconDatabase: Add a way to notify when icon data is available https://bugs.webkit.org/show_bug.cgi?id=63945 Reviewed by Anders Carlsson. Provide new API to notify the API layer when icon data is available, and use it from the implementation layer when needed, that is, either when the data has been loaded from the network or imported from disk. Added new callback to WKIconDatabaseClient API. * UIProcess/API/C/WKIconDatabase.h: Added new callback. * UIProcess/WebIconDatabaseClient.cpp: (WebKit::WebIconDatabaseClient::iconDataReadyForPageURL): Implementation of the new callback at this level in the UI process, by using its implementation in the API layer if present. * UIProcess/WebIconDatabaseClient.h: (WebIconDatabaseClient): Added new callback. Implemented WebFrameLoaderClient::dispatchDidReceiveIcon, so we get notified in the UI process when loading a new icon. * UIProcess/WebIconDatabase.messages.in: Added new message to notify the UI process: DidReceiveIconForPageURL. * UIProcess/WebIconDatabase.cpp: (WebKit::WebIconDatabase::notifyIconDataReadyForPageURL): New private helper function to notify the API layer both that new icon data is ready and that the icon has changed. (WebKit::WebIconDatabase::didReceiveIconForPageURL): Implementation of the new message added, by calling notifyIconDataReadyForPageURL() to notify the API layer. (WebKit::WebIconDatabase::didImportIconDataForPageURL): Call notifyIconDataReadyForPageURL() from here as well. * UIProcess/WebIconDatabase.h: Added new prototypes. * WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp: (WebKit::WebFrameLoaderClient::dispatchDidReceiveIcon): Send a message to the UI process telling a new icon has been received. Modified Paths trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/UIProcess/API/C/WKIconDatabase.h trunk/Source/WebKit2/UIProcess/WebIconDatabase.cpp trunk/Source/WebKit2/UIProcess/WebIconDatabase.h trunk/Source/WebKit2/UIProcess/WebIconDatabase.messages.in trunk/Source/WebKit2/UIProcess/WebIconDatabaseClient.cpp trunk/Source/WebKit2/UIProcess/WebIconDatabaseClient.h trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp Diff Modified: trunk/Source/WebKit2/ChangeLog (129741 => 129742) --- trunk/Source/WebKit2/ChangeLog 2012-09-27 08:57:30 UTC (rev 129741) +++ trunk/Source/WebKit2/ChangeLog 2012-09-27 09:24:59 UTC (rev 129742) @@ -1,3 +1,44 @@ +2012-09-27 Mario Sanchez Prada msanc...@igalia.com + +[WK2] IconDatabase: Add a way to notify when icon data is available +https://bugs.webkit.org/show_bug.cgi?id=63945 + +Reviewed by Anders Carlsson. + +Provide new API to notify the API layer when icon data is +available, and use it from the implementation layer when needed, +that is, either when the data has been loaded from the network or +imported from disk. + +Added new callback to WKIconDatabaseClient API. + +* UIProcess/API/C/WKIconDatabase.h: Added new callback. +* UIProcess/WebIconDatabaseClient.cpp: +(WebKit::WebIconDatabaseClient::iconDataReadyForPageURL): +Implementation of the new callback at this level in the UI +process, by using its implementation in the API layer if present. +* UIProcess/WebIconDatabaseClient.h: +(WebIconDatabaseClient): Added new callback. + +Implemented WebFrameLoaderClient::dispatchDidReceiveIcon, so we +get notified in the UI process when loading a new icon. + +* UIProcess/WebIconDatabase.messages.in: Added new message to +notify the UI process: DidReceiveIconForPageURL. +* UIProcess/WebIconDatabase.cpp: +(WebKit::WebIconDatabase::notifyIconDataReadyForPageURL): New +private helper function to notify the API layer both that new icon +data is ready and that the icon has changed. +(WebKit::WebIconDatabase::didReceiveIconForPageURL): +Implementation of the new message added, by calling +notifyIconDataReadyForPageURL() to notify the API layer. +(WebKit::WebIconDatabase::didImportIconDataForPageURL): Call +notifyIconDataReadyForPageURL() from here as well. +* UIProcess/WebIconDatabase.h: Added new prototypes. +* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp: +(WebKit::WebFrameLoaderClient::dispatchDidReceiveIcon): Send a +message to the UI process telling a new icon has been received. + 2012-09-26 Sam Weinig s...@webkit.org Fix XPCServices symlink to not be to an absolute path Modified: trunk/Source/WebKit2/UIProcess/API/C/WKIconDatabase.h (129741 => 129742) --- trunk/Source/WebKit2/UIProcess/API/C/WKIconDatabase.h 2012-09-27 08:57:30 UTC (rev 129741) +++ trunk/Source/WebKit2/UIProcess/API/C/WKIconDatabase.h 2012-09-27 09:24:59 UTC (rev 129742) @@ -35,12
[webkit-changes] [129743] trunk/Source/WebKit2
Title: [129743] trunk/Source/WebKit2 Revision 129743 Author commit-qu...@webkit.org Date 2012-09-27 02:32:32 -0700 (Thu, 27 Sep 2012) Log Message [WK2] Injected bundle API implementation should use toWTFString() https://bugs.webkit.org/show_bug.cgi?id=97766 Patch by Mikhail Pozdnyakov mikhail.pozdnya...@intel.com on 2012-09-27 Reviewed by Kenneth Rohde Christiansen. Injected bundle API implementation should call toWTFString() rather than convert WKStringRef and WKURLRef to their impls and then call string() method directly. The rational for that are both safety (toWTFString checks the given pointer) and code readability. * WebProcess/InjectedBundle/API/c/WKBundle.cpp: (WKBundlePostMessage): (WKBundlePostSynchronousMessage): (WKBundleOverrideBoolPreferenceForTestRunner): (WKBundleAddOriginAccessWhitelistEntry): (WKBundleRemoveOriginAccessWhitelistEntry): (WKBundleClearApplicationCacheForOrigin): (WKBundleGetAppCacheUsageForOrigin): (WKBundleSetApplicationCacheOriginQuota): (WKBundleResetApplicationCacheOriginQuota): (WKBundlePageNumberForElementById): (WKBundleSetUserStyleSheetLocation): (WKBundleSetWebNotificationPermission): * WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp: (WKBundleFramePauseAnimationOnElementWithId): (WKBundleFramePauseTransitionOnElementWithId): (WKBundleFrameAllowsFollowingLink): (WKBundleFrameCopySuggestedFilenameForResourceWithURL): (WKBundleFrameCopyMIMETypeForResourceWithURL): (WKBundleFrameSetTextDirection): * WebProcess/InjectedBundle/API/c/WKBundleInspector.cpp: (WKBundleInspectorEvaluateScriptForTest): * WebProcess/InjectedBundle/API/c/WKBundleIntent.cpp: (WKBundleIntentCreate): * WebProcess/InjectedBundle/API/c/WKBundlePage.cpp: (WKBundlePageExecuteEditingCommand): (WKBundlePageIsEditingCommandEnabled): (WKBundlePageHasLocalDataForURL): (WKBundlePageFindString): (WKBundlePageSetComposition): (WKBundlePageConfirmCompositionWithText): (WKBundlePageCanShowMIMEType): Modified Paths trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundle.cpp trunk/Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp trunk/Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundleInspector.cpp trunk/Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundleIntent.cpp trunk/Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundlePage.cpp Diff Modified: trunk/Source/WebKit2/ChangeLog (129742 => 129743) --- trunk/Source/WebKit2/ChangeLog 2012-09-27 09:24:59 UTC (rev 129742) +++ trunk/Source/WebKit2/ChangeLog 2012-09-27 09:32:32 UTC (rev 129743) @@ -1,3 +1,48 @@ +2012-09-27 Mikhail Pozdnyakov mikhail.pozdnya...@intel.com + +[WK2] Injected bundle API implementation should use toWTFString() +https://bugs.webkit.org/show_bug.cgi?id=97766 + +Reviewed by Kenneth Rohde Christiansen. + +Injected bundle API implementation should call toWTFString() rather than convert +WKStringRef and WKURLRef to their impls and then call string() method directly. +The rational for that are both safety (toWTFString checks the given pointer) and +code readability. + +* WebProcess/InjectedBundle/API/c/WKBundle.cpp: +(WKBundlePostMessage): +(WKBundlePostSynchronousMessage): +(WKBundleOverrideBoolPreferenceForTestRunner): +(WKBundleAddOriginAccessWhitelistEntry): +(WKBundleRemoveOriginAccessWhitelistEntry): +(WKBundleClearApplicationCacheForOrigin): +(WKBundleGetAppCacheUsageForOrigin): +(WKBundleSetApplicationCacheOriginQuota): +(WKBundleResetApplicationCacheOriginQuota): +(WKBundlePageNumberForElementById): +(WKBundleSetUserStyleSheetLocation): +(WKBundleSetWebNotificationPermission): +* WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp: +(WKBundleFramePauseAnimationOnElementWithId): +(WKBundleFramePauseTransitionOnElementWithId): +(WKBundleFrameAllowsFollowingLink): +(WKBundleFrameCopySuggestedFilenameForResourceWithURL): +(WKBundleFrameCopyMIMETypeForResourceWithURL): +(WKBundleFrameSetTextDirection): +* WebProcess/InjectedBundle/API/c/WKBundleInspector.cpp: +(WKBundleInspectorEvaluateScriptForTest): +* WebProcess/InjectedBundle/API/c/WKBundleIntent.cpp: +(WKBundleIntentCreate): +* WebProcess/InjectedBundle/API/c/WKBundlePage.cpp: +(WKBundlePageExecuteEditingCommand): +(WKBundlePageIsEditingCommandEnabled): +(WKBundlePageHasLocalDataForURL): +(WKBundlePageFindString): +(WKBundlePageSetComposition): +(WKBundlePageConfirmCompositionWithText): +(WKBundlePageCanShowMIMEType): + 2012-09-27 Mario Sanchez Prada msanc...@igalia.com [WK2] IconDatabase: Add a way to notify when icon data is available Modified: trunk/Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundle.cpp (129742 => 129743) ---
[webkit-changes] [129744] trunk/LayoutTests
Title: [129744] trunk/LayoutTests Revision 129744 Author vse...@chromium.org Date 2012-09-27 02:40:54 -0700 (Thu, 27 Sep 2012) Log Message Unreviewed inspector test unskipped on qt, expectations updated. * http/tests/inspector/console-cross-origin-iframe-logging-expected.txt: * platform/qt/Skipped: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/http/tests/inspector/console-cross-origin-iframe-logging-expected.txt trunk/LayoutTests/platform/qt/Skipped Diff Modified: trunk/LayoutTests/ChangeLog (129743 => 129744) --- trunk/LayoutTests/ChangeLog 2012-09-27 09:32:32 UTC (rev 129743) +++ trunk/LayoutTests/ChangeLog 2012-09-27 09:40:54 UTC (rev 129744) @@ -1,3 +1,10 @@ +2012-09-27 Vsevolod Vlasov vse...@chromium.org + +Unreviewed inspector test unskipped on qt, expectations updated. + +* http/tests/inspector/console-cross-origin-iframe-logging-expected.txt: +* platform/qt/Skipped: + 2012-09-27 Christophe Dumez christophe.du...@intel.com [EFL] Skip fast/dom/Geolocation to make LayoutTests faster Modified: trunk/LayoutTests/http/tests/inspector/console-cross-origin-iframe-logging-expected.txt (129743 => 129744) --- trunk/LayoutTests/http/tests/inspector/console-cross-origin-iframe-logging-expected.txt 2012-09-27 09:32:32 UTC (rev 129743) +++ trunk/LayoutTests/http/tests/inspector/console-cross-origin-iframe-logging-expected.txt 2012-09-27 09:40:54 UTC (rev 129744) @@ -8,9 +8,9 @@ Unsafe _javascript_ attempt to access frame with URL http://localhost:8000/inspector/resources/cross-origin-iframe.html from frame with URL http://127.0.0.1:8000/inspector/console-cross-origin-iframe-logging.html. Domains, protocols and ports must match. - + console-cross-origin-iframe-logging.html:9 Unsafe _javascript_ attempt to access frame with URL http://localhost:8000/inspector/resources/cross-origin-iframe.html from frame with URL http://127.0.0.1:8000/inspector/console-cross-origin-iframe-logging.html. Domains, protocols and ports must match. - + [native code]:1 Unable to post message to http://127.0.0.1:8000. Recipient has origin http://localhost:8000. + [native code]:1 - Modified: trunk/LayoutTests/platform/qt/Skipped (129743 => 129744) --- trunk/LayoutTests/platform/qt/Skipped 2012-09-27 09:32:32 UTC (rev 129743) +++ trunk/LayoutTests/platform/qt/Skipped 2012-09-27 09:40:54 UTC (rev 129744) @@ -735,10 +735,6 @@ # https://bugs.webkit.org/show_bug.cgi?id=65911 http/tests/inspector/resource-main-cookies.php -# [Qt] REGRESSION(r105310): Two inspector tests fails -# https://bugs.webkit.org/show_bug.cgi?id=76566 -http/tests/inspector/console-cross-origin-iframe-logging.html - # [Qt]http/tests/workers/terminate-during-sync-operation.html fails intermittently # https://bugs.webkit.org/show_bug.cgi?id=75614 http/tests/workers/terminate-during-sync-operation.html ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [129745] trunk/Source
Title: [129745] trunk/Source
Revision 129745
Author commit-qu...@webkit.org
Date 2012-09-27 02:44:05 -0700 (Thu, 27 Sep 2012)
Log Message
[EFL] No way to exit video fullscreen mode once entered
https://bugs.webkit.org/show_bug.cgi?id=97631
Patch by Christophe Dumez christophe.du...@intel.com on 2012-09-27
Reviewed by Kenneth Rohde Christiansen.
Source/WebCore:
Show fullscreen media control in fullscreen so that
we now have a way to exit fullscreen mode.
No new tests, no behavior change for layout tests.
* css/mediaControlsEflFullscreen.css:
* platform/efl/RenderThemeEfl.cpp:
(WebCore::RenderThemeEfl::emitMediaButtonSignal):
(WebCore::RenderThemeEfl::paintMediaFullscreenButton):
Source/WebKit/efl:
Fix default theme so that we have 2 fullscreen buttons, one
to enter fullscreen mode and another to exit it.
New icon by Alexander Shalamov.
* DefaultTheme/widget/mediacontrol/fullscreenbutton/enterfullscreenbutton.png: Added.
* DefaultTheme/widget/mediacontrol/fullscreenbutton/exitfullscreenbutton.png: Added.
* DefaultTheme/widget/mediacontrol/fullscreenbutton/fullscreen_button.edc:
* DefaultTheme/widget/mediacontrol/fullscreenbutton/fullscreenbutton.png: Removed.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/mediaControlsEflFullscreen.css
trunk/Source/WebCore/platform/efl/RenderThemeEfl.cpp
trunk/Source/WebKit/efl/ChangeLog
trunk/Source/WebKit/efl/DefaultTheme/widget/mediacontrol/fullscreenbutton/fullscreen_button.edc
Added Paths
trunk/Source/WebKit/efl/DefaultTheme/widget/mediacontrol/fullscreenbutton/enterfullscreenbutton.png
trunk/Source/WebKit/efl/DefaultTheme/widget/mediacontrol/fullscreenbutton/exitfullscreenbutton.png
Removed Paths
trunk/Source/WebKit/efl/DefaultTheme/widget/mediacontrol/fullscreenbutton/fullscreenbutton.png
Diff
Modified: trunk/Source/WebCore/ChangeLog (129744 => 129745)
--- trunk/Source/WebCore/ChangeLog 2012-09-27 09:40:54 UTC (rev 129744)
+++ trunk/Source/WebCore/ChangeLog 2012-09-27 09:44:05 UTC (rev 129745)
@@ -1,3 +1,20 @@
+2012-09-27 Christophe Dumez christophe.du...@intel.com
+
+[EFL] No way to exit video fullscreen mode once entered
+https://bugs.webkit.org/show_bug.cgi?id=97631
+
+Reviewed by Kenneth Rohde Christiansen.
+
+Show fullscreen media control in fullscreen so that
+we now have a way to exit fullscreen mode.
+
+No new tests, no behavior change for layout tests.
+
+* css/mediaControlsEflFullscreen.css:
+* platform/efl/RenderThemeEfl.cpp:
+(WebCore::RenderThemeEfl::emitMediaButtonSignal):
+(WebCore::RenderThemeEfl::paintMediaFullscreenButton):
+
2012-09-27 Yoshifumi Inoue yo...@chromium.org
[Forms] BaseMultipleFieldsDateAndTimeInputType class should inherit DateTimeEditElement::EditControlOwner rather than containing
Modified: trunk/Source/WebCore/css/mediaControlsEflFullscreen.css (129744 => 129745)
--- trunk/Source/WebCore/css/mediaControlsEflFullscreen.css 2012-09-27 09:40:54 UTC (rev 129744)
+++ trunk/Source/WebCore/css/mediaControlsEflFullscreen.css 2012-09-27 09:44:05 UTC (rev 129745)
@@ -111,10 +111,6 @@
display: none;
}
-video:-webkit-full-screen::-webkit-media-controls-fullscreen-button {
-display: none;
-}
-
video:-webkit-full-screen::-webkit-media-controls-rewind-button {
display: none;
}
Modified: trunk/Source/WebCore/platform/efl/RenderThemeEfl.cpp (129744 => 129745)
--- trunk/Source/WebCore/platform/efl/RenderThemeEfl.cpp 2012-09-27 09:40:54 UTC (rev 129744)
+++ trunk/Source/WebCore/platform/efl/RenderThemeEfl.cpp 2012-09-27 09:44:05 UTC (rev 129745)
@@ -1063,7 +1063,9 @@
else if (mediaElementType == MediaSeekBackButton)
edje_object_signal_emit(entry-edje(), seekbackward, );
else if (mediaElementType == MediaEnterFullscreenButton)
-edje_object_signal_emit(entry-edje(), fullscreen, );
+edje_object_signal_emit(entry-edje(), fullscreen_enter, );
+else if (mediaElementType == MediaExitFullscreenButton)
+edje_object_signal_emit(entry-edje(), fullscreen_exit, );
#if ENABLE(VIDEO_TRACK)
else if (mediaElementType == MediaShowClosedCaptionsButton)
edje_object_signal_emit(entry-edje(), show_captions, );
@@ -1103,10 +1105,11 @@
Node* mediaNode = object-node() ? object-node()-shadowHost() : 0;
if (!mediaNode)
mediaNode = object-node();
-if (!mediaNode || (!mediaNode-hasTagName(videoTag)))
+if (!mediaNode || !mediaNode-isElementNode() || !static_castElement*(mediaNode)-isMediaElement())
return false;
-if (!emitMediaButtonSignal(FullScreenButton, MediaEnterFullscreenButton, rect))
+HTMLMediaElement* mediaElement = static_castHTMLMediaElement*(mediaNode);
+if (!emitMediaButtonSignal(FullScreenButton, mediaElement-isFullscreen() ? MediaExitFullscreenButton : MediaEnterFullscreenButton, rect))
return false;
return paintThemePart(object, FullScreenButton, info, rect);
[webkit-changes] [129746] trunk
Title: [129746] trunk Revision 129746 Author apav...@chromium.org Date 2012-09-27 02:55:52 -0700 (Thu, 27 Sep 2012) Log Message CollectingRules and QueryingRules modes of SelectorChecker miss some complex selectors with pseudo elements https://bugs.webkit.org/show_bug.cgi?id=78595 Reviewed by Antti Koivisto. Source/WebCore: Do not use the same dynamicPseudo reference when recursively invoking checkSelector() for non-SubSelector selectors. Test: fast/dom/Window/getMatchedCSSRules-with-pseudo-elements-complex.html * css/SelectorChecker.cpp: (WebCore::SelectorChecker::checkSelector): Use new NOPSEUDO dynamic pseudoId values for each non-SubSelector selector further in the tag history. LayoutTests: The original issue mentioned failures on selectors like .foo.moo .bar:before, while things worked fine for .foo .bar:before. The test checks 2 and 3 selector levels for all conventional non-SubSelector relations (Child, Descendant, DirectAdjacent, IndirectAdjacent), each selector in all levels but the last one containing a SubSelector relation. * fast/dom/Window/getMatchedCSSRules-with-pseudo-elements-complex.html: Added. * fast/dom/Window/getMatchedCSSRules-with-pseudo-elements-complex-expected.txt: Added. Modified Paths trunk/LayoutTests/ChangeLog trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/css/SelectorChecker.cpp Added Paths trunk/LayoutTests/fast/dom/Window/getMatchedCSSRules-with-pseudo-elements-complex-expected.txt trunk/LayoutTests/fast/dom/Window/getMatchedCSSRules-with-pseudo-elements-complex.html Diff Modified: trunk/LayoutTests/ChangeLog (129745 => 129746) --- trunk/LayoutTests/ChangeLog 2012-09-27 09:44:05 UTC (rev 129745) +++ trunk/LayoutTests/ChangeLog 2012-09-27 09:55:52 UTC (rev 129746) @@ -1,3 +1,17 @@ +2012-09-25 Alexander Pavlov apav...@chromium.org + +CollectingRules and QueryingRules modes of SelectorChecker miss some complex selectors with pseudo elements +https://bugs.webkit.org/show_bug.cgi?id=78595 + +Reviewed by Antti Koivisto. + +The original issue mentioned failures on selectors like .foo.moo .bar:before, while things worked fine for .foo .bar:before. +The test checks 2 and 3 selector levels for all conventional non-SubSelector relations (Child, Descendant, DirectAdjacent, IndirectAdjacent), +each selector in all levels but the last one containing a SubSelector relation. + +* fast/dom/Window/getMatchedCSSRules-with-pseudo-elements-complex.html: Added. +* fast/dom/Window/getMatchedCSSRules-with-pseudo-elements-complex-expected.txt: Added. + 2012-09-27 Vsevolod Vlasov vse...@chromium.org Unreviewed inspector test unskipped on qt, expectations updated. Added: trunk/LayoutTests/fast/dom/Window/getMatchedCSSRules-with-pseudo-elements-complex-expected.txt (0 => 129746) --- trunk/LayoutTests/fast/dom/Window/getMatchedCSSRules-with-pseudo-elements-complex-expected.txt (rev 0) +++ trunk/LayoutTests/fast/dom/Window/getMatchedCSSRules-with-pseudo-elements-complex-expected.txt 2012-09-27 09:55:52 UTC (rev 129746) @@ -0,0 +1,12 @@ +Test for WebKit bug 78595: CollectingRules and QueryingRules modes of SelectorChecker miss some complex selectors with pseudo elements + + + +PASS Expected 'rgb(165, 42, 42)' for color in the matched CSS rule for element with id firstChild and pseudo-element :before and got 'rgb(165, 42, 42)' +PASS Expected 'rgb(0, 255, 255)' for color in the matched CSS rule for element with id secondChild and pseudo-element :before and got 'rgb(0, 255, 255)' +PASS Expected 'red' for color in the matched CSS rule for element with id thirdChild and pseudo-element :before and got 'red' +PASS Expected 'rgb(255, 0, 255)' for color in the matched CSS rule for element with id fourthChild and pseudo-element :before and got 'rgb(255, 0, 255)' +PASS Expected 'green' for color in the matched CSS rule for element with id firstParent and pseudo-element :before and got 'green' +PASS Expected 'lime' for color in the matched CSS rule for element with id secondParent and pseudo-element :before and got 'lime' +PASS Expected 'blue' for color in the matched CSS rule for element with id thirdParent and pseudo-element :before and got 'blue' +PASS Expected 'rgb(220, 20, 60)' for color in the matched CSS rule for element with id fourthParent and pseudo-element :before and got 'rgb(220, 20, 60)' Property changes on: trunk/LayoutTests/fast/dom/Window/getMatchedCSSRules-with-pseudo-elements-complex-expected.txt ___ Added: svn:eol-style Added: trunk/LayoutTests/fast/dom/Window/getMatchedCSSRules-with-pseudo-elements-complex.html (0 => 129746) --- trunk/LayoutTests/fast/dom/Window/getMatchedCSSRules-with-pseudo-elements-complex.html (rev 0) +++ trunk/LayoutTests/fast/dom/Window/getMatchedCSSRules-with-pseudo-elements-complex.html 2012-09-27 09:55:52 UTC (rev 129746) @@ -0,0 +1,125
[webkit-changes] [129747] trunk/LayoutTests
Title: [129747] trunk/LayoutTests Revision 129747 Author o...@webkit.org Date 2012-09-27 03:05:10 -0700 (Thu, 27 Sep 2012) Log Message [Qt] Unreviewed gardening. Unskip a test again after r129712. * platform/qt/Skipped: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/qt/Skipped Diff Modified: trunk/LayoutTests/ChangeLog (129746 => 129747) --- trunk/LayoutTests/ChangeLog 2012-09-27 09:55:52 UTC (rev 129746) +++ trunk/LayoutTests/ChangeLog 2012-09-27 10:05:10 UTC (rev 129747) @@ -1,3 +1,9 @@ +2012-09-27 Csaba Osztrogonác o...@webkit.org + +[Qt] Unreviewed gardening. Unskip a test again after r129712. + +* platform/qt/Skipped: + 2012-09-25 Alexander Pavlov apav...@chromium.org CollectingRules and QueryingRules modes of SelectorChecker miss some complex selectors with pseudo elements Modified: trunk/LayoutTests/platform/qt/Skipped (129746 => 129747) --- trunk/LayoutTests/platform/qt/Skipped 2012-09-27 09:55:52 UTC (rev 129746) +++ trunk/LayoutTests/platform/qt/Skipped 2012-09-27 10:05:10 UTC (rev 129747) @@ -2789,7 +2789,3 @@ # [Qt] New test introduced in r129346 inspector-protocol/css-getSupportedCSSProperties.html fails # https://bugs.webkit.org/show_bug.cgi?id=97451 inspector-protocol/css-getSupportedCSSProperties.html - -# REGRESSION (r129456): http/tests/security/xss-eval.html is failing on JSC platforms -# https://bugs.webkit.org/show_bug.cgi?id=97529 -http/tests/security/xss-eval.html ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [129748] trunk/Source/WebCore
Title: [129748] trunk/Source/WebCore
Revision 129748
Author vse...@chromium.org
Date 2012-09-27 03:37:56 -0700 (Thu, 27 Sep 2012)
Log Message
Unreviewed inspector front-end closure compilation fix.
* inspector/front-end/UISourceCode.js:
(WebInspector.UISourceCode.prototype.revertToOriginal):
(WebInspector.UISourceCode.prototype.revertAndClearHistory):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/UISourceCode.js
Diff
Modified: trunk/Source/WebCore/ChangeLog (129747 => 129748)
--- trunk/Source/WebCore/ChangeLog 2012-09-27 10:05:10 UTC (rev 129747)
+++ trunk/Source/WebCore/ChangeLog 2012-09-27 10:37:56 UTC (rev 129748)
@@ -1,3 +1,11 @@
+2012-09-27 Vsevolod Vlasov vse...@chromium.org
+
+Unreviewed inspector front-end closure compilation fix.
+
+* inspector/front-end/UISourceCode.js:
+(WebInspector.UISourceCode.prototype.revertToOriginal):
+(WebInspector.UISourceCode.prototype.revertAndClearHistory):
+
2012-09-25 Alexander Pavlov apav...@chromium.org
CollectingRules and QueryingRules modes of SelectorChecker miss some complex selectors with pseudo elements
Modified: trunk/Source/WebCore/inspector/front-end/UISourceCode.js (129747 => 129748)
--- trunk/Source/WebCore/inspector/front-end/UISourceCode.js 2012-09-27 10:05:10 UTC (rev 129747)
+++ trunk/Source/WebCore/inspector/front-end/UISourceCode.js 2012-09-27 10:37:56 UTC (rev 129748)
@@ -201,10 +201,10 @@
*/
function callback(content, contentEncoded, mimeType)
{
-if (typeof content === undefined)
+if (typeof content !== string)
return;
-this._setContent(/** @type {string} */ content);
+this._setContent(content);
}
this.requestOriginalContent(callback.bind(this));
@@ -223,10 +223,10 @@
*/
function revert(content, contentEncoded, mimeType)
{
-if (typeof content === undefined)
+if (typeof content !== string)
return;
-this._setContent(/** @type {string} */ content);
+this._setContent(content);
this._clearRevisionHistory();
this.history = [];
callback(this);
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [129750] trunk/Source
Title: [129750] trunk/Source
Revision 129750
Author commit-qu...@webkit.org
Date 2012-09-27 04:12:11 -0700 (Thu, 27 Sep 2012)
Log Message
Unify event handling of middle mouse button.
https://bugs.webkit.org/show_bug.cgi?id=97690
Patch by Allan Sandfeld Jensen allan.jen...@digia.com on 2012-09-27
Reviewed by Tony Chang.
Source/WebCore:
Implement a unified version of middle mouse button press that can be shared between
all the ports with X11 support.
* page/EventHandler.cpp:
(WebCore::EventHandler::handleMousePressEventSingleClick):
(WebCore::EventHandler::handleMouseReleaseEvent):
(WebCore::EventHandler::handlePasteGlobalSelection):
* page/EventHandler.h:
(EventHandler):
Source/WebKit/chromium:
Remove port specific handling of middle mouse button press.
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::handleMouseUp):
Source/WebKit/gtk:
Remove port specific handling of middle mouse button press.
* WebCoreSupport/EditorClientGtk.cpp:
(WebKit::EditorClient::supportsGlobalSelection):
* WebCoreSupport/EditorClientGtk.h:
(EditorClient):
* webkit/webkitwebview.cpp:
(webkit_web_view_button_press_event):
Source/WebKit/qt:
Remove port specific handling of middle mouse button press.
* Api/qwebpage.cpp:
(QWebPagePrivate::mouseReleaseEvent):
* Api/qwebpage_p.h:
(QWebPagePrivate):
Source/WebKit2:
Remove Qt and GTK port specific handling of middle mouse button press.
* WebProcess/WebPage/WebPage.cpp:
(WebKit::handleMouseEvent):
* WebProcess/WebPage/WebPage.h:
(WebPage):
* WebProcess/WebPage/gtk/WebPageGtk.cpp:
(WebKit):
* WebProcess/WebPage/qt/WebPageQt.cpp:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/EventHandler.cpp
trunk/Source/WebCore/page/EventHandler.h
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/src/WebViewImpl.cpp
trunk/Source/WebKit/gtk/ChangeLog
trunk/Source/WebKit/gtk/WebCoreSupport/EditorClientGtk.cpp
trunk/Source/WebKit/gtk/WebCoreSupport/EditorClientGtk.h
trunk/Source/WebKit/gtk/webkit/webkitwebview.cpp
trunk/Source/WebKit/qt/Api/qwebpage.cpp
trunk/Source/WebKit/qt/Api/qwebpage_p.h
trunk/Source/WebKit/qt/ChangeLog
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp
trunk/Source/WebKit2/WebProcess/WebPage/WebPage.h
trunk/Source/WebKit2/WebProcess/WebPage/gtk/WebPageGtk.cpp
trunk/Source/WebKit2/WebProcess/WebPage/qt/WebPageQt.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (129749 => 129750)
--- trunk/Source/WebCore/ChangeLog 2012-09-27 11:07:12 UTC (rev 129749)
+++ trunk/Source/WebCore/ChangeLog 2012-09-27 11:12:11 UTC (rev 129750)
@@ -1,3 +1,20 @@
+2012-09-27 Allan Sandfeld Jensen allan.jen...@digia.com
+
+Unify event handling of middle mouse button.
+https://bugs.webkit.org/show_bug.cgi?id=97690
+
+Reviewed by Tony Chang.
+
+Implement a unified version of middle mouse button press that can be shared between
+all the ports with X11 support.
+
+* page/EventHandler.cpp:
+(WebCore::EventHandler::handleMousePressEventSingleClick):
+(WebCore::EventHandler::handleMouseReleaseEvent):
+(WebCore::EventHandler::handlePasteGlobalSelection):
+* page/EventHandler.h:
+(EventHandler):
+
2012-09-27 Tommy Widenflycht tom...@google.com
MediaStream API: Update getUserMedia to match the latest specification
Modified: trunk/Source/WebCore/page/EventHandler.cpp (129749 => 129750)
--- trunk/Source/WebCore/page/EventHandler.cpp 2012-09-27 11:07:12 UTC (rev 129749)
+++ trunk/Source/WebCore/page/EventHandler.cpp 2012-09-27 11:12:11 UTC (rev 129750)
@@ -1,6 +1,7 @@
/*
* Copyright (C) 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All rights reserved.
* Copyright (C) 2006 Alexey Proskuryakov (a...@webkit.org)
+ * Copyright (C) 2012 Digia Plc. and/or its subsidiary(-ies)
*
* Redistribution and use in source and binary forms, with or without
* modification, are permitted provided that the following conditions
@@ -39,6 +40,7 @@
#include DragController.h
#include DragState.h
#include Editor.h
+#include EditorClient.h
#include EventNames.h
#include FloatPoint.h
#include FloatRect.h
@@ -559,7 +561,13 @@
} else
newSelection = VisibleSelection(visiblePos);
-return updateSelectionForMouseDownDispatchingSelectStart(innerNode, newSelection, granularity);
+bool handled = updateSelectionForMouseDownDispatchingSelectStart(innerNode, newSelection, granularity);
+
+if (event.event().button() == MiddleButton) {
+// Ignore handled, since we want to paste to where the caret was placed anyway.
+handled = handlePasteGlobalSelection(event.event()) || handled;
+}
+return handled;
}
static inline bool canMouseDownStartSelect(Node* node)
@@ -904,6 +912,11 @@
m_frame-selection()-selectFrameElementInParentIfFullySelected();
+if (event.event().button() == MiddleButton) {
+// Ignore handled, since we want to paste to where the caret was placed anyway.
[webkit-changes] [129752] trunk/Source/WebKit
Title: [129752] trunk/Source/WebKit
Revision 129752
Author commit-qu...@webkit.org
Date 2012-09-27 04:22:49 -0700 (Thu, 27 Sep 2012)
Log Message
[EFL][CMAKE] Default theme files are outdated in PlatformEfl.cmake
https://bugs.webkit.org/show_bug.cgi?id=97769
Patch by Christophe Dumez christophe.du...@intel.com on 2012-09-27
Reviewed by Kenneth Rohde Christiansen.
Update Default theme files in PlatformEfl.cmake so that
changes to those files are properly picked up by CMake
when building incrementally.
* PlatformEfl.cmake:
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/PlatformEfl.cmake
Diff
Modified: trunk/Source/WebKit/ChangeLog (129751 => 129752)
--- trunk/Source/WebKit/ChangeLog 2012-09-27 11:18:23 UTC (rev 129751)
+++ trunk/Source/WebKit/ChangeLog 2012-09-27 11:22:49 UTC (rev 129752)
@@ -1,3 +1,16 @@
+2012-09-27 Christophe Dumez christophe.du...@intel.com
+
+[EFL][CMAKE] Default theme files are outdated in PlatformEfl.cmake
+https://bugs.webkit.org/show_bug.cgi?id=97769
+
+Reviewed by Kenneth Rohde Christiansen.
+
+Update Default theme files in PlatformEfl.cmake so that
+changes to those files are properly picked up by CMake
+when building incrementally.
+
+* PlatformEfl.cmake:
+
2012-09-24 Arvid Nilsson anils...@rim.com
[BlackBerry] Add cookie database API
Modified: trunk/Source/WebKit/PlatformEfl.cmake (129751 => 129752)
--- trunk/Source/WebKit/PlatformEfl.cmake 2012-09-27 11:18:23 UTC (rev 129751)
+++ trunk/Source/WebKit/PlatformEfl.cmake 2012-09-27 11:22:49 UTC (rev 129752)
@@ -164,70 +164,94 @@
COMMAND ${EDJE_CC_EXECUTABLE} -v -id ${WEBKIT_DIR}/efl/DefaultTheme ${WebKit_THEME_DEFINITION} ${WEBKIT_DIR}/efl/DefaultTheme/default.edc ${WebKit_THEME}
DEPENDS
${WEBKIT_DIR}/efl/DefaultTheme/default.edc
-${WEBKIT_DIR}/efl/DefaultTheme/widget/slider/slider.edc
-${WEBKIT_DIR}/efl/DefaultTheme/widget/slider/slider_fill_v.png
-${WEBKIT_DIR}/efl/DefaultTheme/widget/slider/slider_fill_h.png
-${WEBKIT_DIR}/efl/DefaultTheme/widget/slider/slider_h.png
-${WEBKIT_DIR}/efl/DefaultTheme/widget/slider/slider_thumb_h.png
-${WEBKIT_DIR}/efl/DefaultTheme/widget/slider/slider_thumb_press_h.png
-${WEBKIT_DIR}/efl/DefaultTheme/widget/slider/slider_thumb_press_v.png
-${WEBKIT_DIR}/efl/DefaultTheme/widget/slider/slider_thumb_v.png
-${WEBKIT_DIR}/efl/DefaultTheme/widget/slider/slider_v.png
+${WEBKIT_DIR}/efl/DefaultTheme/widget/button/button.edc
+${WEBKIT_DIR}/efl/DefaultTheme/widget/button/img_button_focus.png
+${WEBKIT_DIR}/efl/DefaultTheme/widget/button/img_button_hover.png
+${WEBKIT_DIR}/efl/DefaultTheme/widget/button/img_button_normal.png
+${WEBKIT_DIR}/efl/DefaultTheme/widget/button/img_button_press.png
+${WEBKIT_DIR}/efl/DefaultTheme/widget/check/check.edc
+${WEBKIT_DIR}/efl/DefaultTheme/widget/check/img_check_off_focus.png
+${WEBKIT_DIR}/efl/DefaultTheme/widget/check/img_check_off_hover.png
+${WEBKIT_DIR}/efl/DefaultTheme/widget/check/img_check_off.png
+${WEBKIT_DIR}/efl/DefaultTheme/widget/check/img_check_on_focus.png
+${WEBKIT_DIR}/efl/DefaultTheme/widget/check/img_check_on_hover.png
+${WEBKIT_DIR}/efl/DefaultTheme/widget/check/img_check_on.png
+${WEBKIT_DIR}/efl/DefaultTheme/widget/combo/combo.edc
${WEBKIT_DIR}/efl/DefaultTheme/widget/combo/combo_focus_button.png
-${WEBKIT_DIR}/efl/DefaultTheme/widget/combo/combo_press.png
-${WEBKIT_DIR}/efl/DefaultTheme/widget/combo/icon.png
-${WEBKIT_DIR}/efl/DefaultTheme/widget/combo/combo_normal.png
+${WEBKIT_DIR}/efl/DefaultTheme/widget/combo/combo_focus.png
+${WEBKIT_DIR}/efl/DefaultTheme/widget/combo/combo_hover_button.png
${WEBKIT_DIR}/efl/DefaultTheme/widget/combo/combo_hover.png
${WEBKIT_DIR}/efl/DefaultTheme/widget/combo/combo_normal_button.png
-${WEBKIT_DIR}/efl/DefaultTheme/widget/combo/combo_focus.png
-${WEBKIT_DIR}/efl/DefaultTheme/widget/combo/combo_hover_button.png
-${WEBKIT_DIR}/efl/DefaultTheme/widget/combo/combo.edc
+${WEBKIT_DIR}/efl/DefaultTheme/widget/combo/combo_normal.png
${WEBKIT_DIR}/efl/DefaultTheme/widget/combo/combo_press_button.png
-${WEBKIT_DIR}/efl/DefaultTheme/widget/search/decoration/search_decoration.edc
-${WEBKIT_DIR}/efl/DefaultTheme/widget/search/decoration/decoration_normal_button.png
-${WEBKIT_DIR}/efl/DefaultTheme/widget/search/field/field_hovered.png
-${WEBKIT_DIR}/efl/DefaultTheme/widget/search/field/search_field.edc
-${WEBKIT_DIR}/efl/DefaultTheme/widget/search/field/field_normal.png
-${WEBKIT_DIR}/efl/DefaultTheme/widget/search/field/field_focused.png
-${WEBKIT_DIR}/efl/DefaultTheme/widget/search/cancel/cancel_normal_button.png
-${WEBKIT_DIR}/efl/DefaultTheme/widget/search/cancel/cancel_normal_button2.png
-${WEBKIT_DIR}/efl/DefaultTheme/widget/search/cancel/search_cancel.edc
-
[webkit-changes] [129753] trunk
Title: [129753] trunk
Revision 129753
Author vse...@chromium.org
Date 2012-09-27 04:39:58 -0700 (Thu, 27 Sep 2012)
Log Message
Web Inspector: Open resource dialog should assume implicit wildcard in the beginning of the query.
https://bugs.webkit.org/show_bug.cgi?id=97768
Reviewed by Pavel Feldman.
Source/WebCore:
Open resource dialog now assumes implicit wildcard in the beginning of the query.
* inspector/front-end/FilteredItemSelectionDialog.js:
(WebInspector.FilteredItemSelectionDialog.prototype._innerCreateSearchRegExp):
LayoutTests:
* inspector/filtered-item-selection-dialog-filtering-expected.txt:
* inspector/filtered-item-selection-dialog-filtering.html:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/inspector/filtered-item-selection-dialog-filtering-expected.txt
trunk/LayoutTests/inspector/filtered-item-selection-dialog-filtering.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/FilteredItemSelectionDialog.js
Diff
Modified: trunk/LayoutTests/ChangeLog (129752 => 129753)
--- trunk/LayoutTests/ChangeLog 2012-09-27 11:22:49 UTC (rev 129752)
+++ trunk/LayoutTests/ChangeLog 2012-09-27 11:39:58 UTC (rev 129753)
@@ -1,3 +1,13 @@
+2012-09-27 Vsevolod Vlasov vse...@chromium.org
+
+Web Inspector: Open resource dialog should assume implicit wildcard in the beginning of the query.
+https://bugs.webkit.org/show_bug.cgi?id=97768
+
+Reviewed by Pavel Feldman.
+
+* inspector/filtered-item-selection-dialog-filtering-expected.txt:
+* inspector/filtered-item-selection-dialog-filtering.html:
+
2012-09-27 Tommy Widenflycht tom...@google.com
MediaStream API: Update getUserMedia to match the latest specification
Modified: trunk/LayoutTests/inspector/filtered-item-selection-dialog-filtering-expected.txt (129752 => 129753)
--- trunk/LayoutTests/inspector/filtered-item-selection-dialog-filtering-expected.txt 2012-09-27 11:22:49 UTC (rev 129752)
+++ trunk/LayoutTests/inspector/filtered-item-selection-dialog-filtering-expected.txt 2012-09-27 11:39:58 UTC (rev 129753)
@@ -26,7 +26,7 @@
}
{
input : [abab,abaa,caab,baac,fooaab]
-output : []
+output : [caab,fooaab]
query : aab
title : Duplicate symbols in query
}
@@ -37,9 +37,9 @@
title : Star in query
}
{
-input : [abab,abaa,caab,baac,fooaab]
-output : [caab]
-query : ?aab
+input : [abab,abaa,caab,aqb,fooaab]
+output : [caab,aqb,fooaab]
+query : a?b
title : Question in query
}
{
@@ -50,7 +50,7 @@
}
{
input : [fooBarBaz,FooBarBaz,Foo_Bar_Baz,foo_bar_baz,foobarbaz,foobarBaz,afooBarBaz,aFooBarBaz,a fooBarBaz,fooBorBaz,fooBorCaz]
-output : [fooBarBaz]
+output : [fooBarBaz,afooBarBaz,a fooBarBaz]
query : fBaB
title : Camel case matching
}
Modified: trunk/LayoutTests/inspector/filtered-item-selection-dialog-filtering.html (129752 => 129753)
--- trunk/LayoutTests/inspector/filtered-item-selection-dialog-filtering.html 2012-09-27 11:22:49 UTC (rev 129752)
+++ trunk/LayoutTests/inspector/filtered-item-selection-dialog-filtering.html 2012-09-27 11:39:58 UTC (rev 129753)
@@ -32,7 +32,7 @@
checkQuery(Spaces in the input, d.v , [div .visible, div . visible ]);
checkQuery(Duplicate symbols in query, aab, [abab, abaa, caab, baac, fooaab]);
checkQuery(Star in query, *aab, [abab, abaa, caab, baac, fooaab]);
-checkQuery(Question in query, ?aab, [abab, abaa, caab, baac, fooaab]);
+checkQuery(Question in query, a?b, [abab, abaa, caab, aqb, fooaab]);
checkQuery(Dangerous input escaping, ^[]{}()\\.$*+?|, [^[]{}()\\.$*+?|, 0123456789abcdef]);
checkQuery(Camel case matching, fBaB, [fooBarBaz, FooBarBaz, Foo_Bar_Baz, foo_bar_baz, foobarbaz, foobarBaz, afooBarBaz, aFooBarBaz, a fooBarBaz, fooBorBaz, fooBorCaz]);
checkQuery(Underscore matching, fO_ba_b, [foOBarBaz, FoOBarBaz, FoO_Bar_Baz, foO_bar_baz, foObarbaz, foObarBaz, afoOBarBaz, aFoOBarBaz, a foOBarBaz, foOBorBaz, foOBorCaz]);
Modified: trunk/Source/WebCore/ChangeLog (129752 => 129753)
--- trunk/Source/WebCore/ChangeLog 2012-09-27 11:22:49 UTC (rev 129752)
+++ trunk/Source/WebCore/ChangeLog 2012-09-27 11:39:58 UTC (rev 129753)
@@ -1,3 +1,15 @@
+2012-09-27 Vsevolod Vlasov vse...@chromium.org
+
+Web Inspector: Open resource dialog should assume implicit wildcard in the beginning of the query.
+https://bugs.webkit.org/show_bug.cgi?id=97768
+
+Reviewed by Pavel Feldman.
+
+Open resource dialog now assumes implicit wildcard in the beginning of the query.
+
+* inspector/front-end/FilteredItemSelectionDialog.js:
+(WebInspector.FilteredItemSelectionDialog.prototype._innerCreateSearchRegExp):
+
2012-09-27 Pavel Feldman pfeld...@chromium.org
Web Inspector: do not use InspectorInstrumentation::hasFrontends() check when collecting stacks
Modified: trunk/Source/WebCore/inspector/front-end/FilteredItemSelectionDialog.js (129752 => 129753)
---
[webkit-changes] [129754] trunk/Source/WebCore
Title: [129754] trunk/Source/WebCore
Revision 129754
Author commit-qu...@webkit.org
Date 2012-09-27 04:46:03 -0700 (Thu, 27 Sep 2012)
Log Message
[EFL] Remove duplicated CSS between mediaControlsEfl.css and mediaControlsEflFullscreen.css
https://bugs.webkit.org/show_bug.cgi?id=97770
Patch by Christophe Dumez christophe.du...@intel.com on 2012-09-27
Reviewed by Kenneth Rohde Christiansen.
Some CSS rules were duplicated between mediaControlsEfl.css and mediaControlsEflFullscreen.css
for no reason. This is an issue because it is easy to update mediaControlsEfl.css and forget
to make the same update to mediaControlsEflFullscreen.css. As a matter of fact, the timeline
display in fullscreen is currently off by a few pixels because its fullscreen CSS is not in
sync with what is in mediaControlsEfl.css.
We need to include in mediaControlsEflFullscreen.css only the CSS rules that are specific to
fullscreen mode, that is to say, the hiding of some controls.
No new tests, no behavior change for layout tests.
* css/mediaControlsEflFullscreen.css:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/mediaControlsEflFullscreen.css
Diff
Modified: trunk/Source/WebCore/ChangeLog (129753 => 129754)
--- trunk/Source/WebCore/ChangeLog 2012-09-27 11:39:58 UTC (rev 129753)
+++ trunk/Source/WebCore/ChangeLog 2012-09-27 11:46:03 UTC (rev 129754)
@@ -1,3 +1,23 @@
+2012-09-27 Christophe Dumez christophe.du...@intel.com
+
+[EFL] Remove duplicated CSS between mediaControlsEfl.css and mediaControlsEflFullscreen.css
+https://bugs.webkit.org/show_bug.cgi?id=97770
+
+Reviewed by Kenneth Rohde Christiansen.
+
+Some CSS rules were duplicated between mediaControlsEfl.css and mediaControlsEflFullscreen.css
+for no reason. This is an issue because it is easy to update mediaControlsEfl.css and forget
+to make the same update to mediaControlsEflFullscreen.css. As a matter of fact, the timeline
+display in fullscreen is currently off by a few pixels because its fullscreen CSS is not in
+sync with what is in mediaControlsEfl.css.
+
+We need to include in mediaControlsEflFullscreen.css only the CSS rules that are specific to
+fullscreen mode, that is to say, the hiding of some controls.
+
+No new tests, no behavior change for layout tests.
+
+* css/mediaControlsEflFullscreen.css:
+
2012-09-27 Vsevolod Vlasov vse...@chromium.org
Web Inspector: Open resource dialog should assume implicit wildcard in the beginning of the query.
Modified: trunk/Source/WebCore/css/mediaControlsEflFullscreen.css (129753 => 129754)
--- trunk/Source/WebCore/css/mediaControlsEflFullscreen.css 2012-09-27 11:39:58 UTC (rev 129753)
+++ trunk/Source/WebCore/css/mediaControlsEflFullscreen.css 2012-09-27 11:46:03 UTC (rev 129754)
@@ -24,20 +24,6 @@
/* EFLWebKit media controls for fullscreen. */
-video:-webkit-full-screen::-webkit-media-controls-panel {
-display: -webkit-box;
--webkit-box-orient: horizontal;
--webkit-box-align: center;
--webkit-user-select: none;
-position: relative;
-bottom: 0;
-width: 100%;
-z-index: 0;
-overflow: hidden;
-height: 20px;
-text-align: right;
-}
-
video:-webkit-full-screen:-webkit-full-page-media::-webkit-media-controls-panel {
display: none;
}
@@ -46,53 +32,10 @@
display: none;
}
-video:-webkit-full-screen::-webkit-media-controls-play-button {
--webkit-appearance: media-play-button;
-display: -webkit-box;
-width: 20px;
-height: 20px;
-background-color: initial;
-border: initial;
-color: inherit;
-}
-
-video:-webkit-full-screen::-webkit-media-controls-timeline-container {
--webkit-appearance: media-controls-background;
-display: -webkit-box;
--webkit-box-orient: horizontal;
--webkit-box-align: center;
--webkit-box-pack: end;
--webkit-box-flex: 1;
--webkit-user-select: none;
-height: 20px;
-}
-
-video:-webkit-full-screen::-webkit-media-controls-current-time-display {
--webkit-appearance: media-current-time-display;
--webkit-user-select: none;
-display: inline-block;
-height: 20px;
-padding: 4px;
-text-align: center;
-font-size: 10px;
-}
-
video:-webkit-full-screen::-webkit-media-controls-time-remaining-display {
display: none;
}
-video:-webkit-full-screen::-webkit-media-controls-timeline {
--webkit-appearance: media-slider;
-display: -webkit-box;
--webkit-box-flex: 1;
-height: 20px;
-padding: 0px 2px;
-background-color: initial;
-border: initial;
-color: inherit;
-margin: initial;
-}
-
video:-webkit-full-screen::-webkit-media-controls-volume-slider-container {
-webkit-appearance: media-volume-slider-container;
display: none;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
[webkit-changes] [129755] trunk/Source/WebCore
Title: [129755] trunk/Source/WebCore Revision 129755 Author ca...@chromium.org Date 2012-09-27 05:15:52 -0700 (Thu, 27 Sep 2012) Log Message Unreviewed, rolling out r129633. http://trac.webkit.org/changeset/129633 https://bugs.webkit.org/show_bug.cgi?id=97659 Breaks inspector overlay in non-composited mode * inspector/InspectorOverlay.cpp: (WebCore::InspectorOverlay::paint): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/inspector/InspectorOverlay.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (129754 => 129755) --- trunk/Source/WebCore/ChangeLog 2012-09-27 11:46:03 UTC (rev 129754) +++ trunk/Source/WebCore/ChangeLog 2012-09-27 12:15:52 UTC (rev 129755) @@ -1,3 +1,14 @@ +2012-09-27 Andrey Kosyakov ca...@chromium.org + +Unreviewed, rolling out r129633. +http://trac.webkit.org/changeset/129633 +https://bugs.webkit.org/show_bug.cgi?id=97659 + +Breaks inspector overlay in non-composited mode + +* inspector/InspectorOverlay.cpp: +(WebCore::InspectorOverlay::paint): + 2012-09-27 Christophe Dumez christophe.du...@intel.com [EFL] Remove duplicated CSS between mediaControlsEfl.css and mediaControlsEflFullscreen.css Modified: trunk/Source/WebCore/inspector/InspectorOverlay.cpp (129754 => 129755) --- trunk/Source/WebCore/inspector/InspectorOverlay.cpp 2012-09-27 11:46:03 UTC (rev 129754) +++ trunk/Source/WebCore/inspector/InspectorOverlay.cpp 2012-09-27 12:15:52 UTC (rev 129755) @@ -210,13 +210,7 @@ GraphicsContextStateSaver stateSaver(context); FrameView* view = overlayPage()-mainFrame()-view(); ASSERT(!view-needsLayout()); - -context.setCompositeOperation(CompositeCopy); -context.beginTransparencyLayer(1); - view-paint(context, IntRect(0, 0, view-width(), view-height())); - -context.endTransparencyLayer(); } void InspectorOverlay::drawOutline(GraphicsContext* context, const LayoutRect rect, const Color color) ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [129757] trunk/Source/WebCore
Title: [129757] trunk/Source/WebCore Revision 129757 Author ca...@chromium.org Date 2012-09-27 05:53:56 -0700 (Thu, 27 Sep 2012) Log Message Unreviewed, re-landing r129633 with the proper order of calls. https://bugs.webkit.org/show_bug.cgi?id=97659 * inspector/InspectorOverlay.cpp: (WebCore::InspectorOverlay::paint): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/inspector/InspectorOverlay.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (129756 => 129757) --- trunk/Source/WebCore/ChangeLog 2012-09-27 12:21:00 UTC (rev 129756) +++ trunk/Source/WebCore/ChangeLog 2012-09-27 12:53:56 UTC (rev 129757) @@ -1,5 +1,13 @@ 2012-09-27 Andrey Kosyakov ca...@chromium.org +Unreviewed, re-landing r129633 with the proper order of calls. +https://bugs.webkit.org/show_bug.cgi?id=97659 + +* inspector/InspectorOverlay.cpp: +(WebCore::InspectorOverlay::paint): + +2012-09-27 Andrey Kosyakov ca...@chromium.org + Unreviewed, rolling out r129633. http://trac.webkit.org/changeset/129633 https://bugs.webkit.org/show_bug.cgi?id=97659 Modified: trunk/Source/WebCore/inspector/InspectorOverlay.cpp (129756 => 129757) --- trunk/Source/WebCore/inspector/InspectorOverlay.cpp 2012-09-27 12:21:00 UTC (rev 129756) +++ trunk/Source/WebCore/inspector/InspectorOverlay.cpp 2012-09-27 12:53:56 UTC (rev 129757) @@ -210,7 +210,13 @@ GraphicsContextStateSaver stateSaver(context); FrameView* view = overlayPage()-mainFrame()-view(); ASSERT(!view-needsLayout()); + +context.beginTransparencyLayer(1); +context.setCompositeOperation(CompositeCopy); + view-paint(context, IntRect(0, 0, view-width(), view-height())); + +context.endTransparencyLayer(); } void InspectorOverlay::drawOutline(GraphicsContext* context, const LayoutRect rect, const Color color) ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [129758] trunk/Source/WebKit2
Title: [129758] trunk/Source/WebKit2
Revision 129758
Author commit-qu...@webkit.org
Date 2012-09-27 06:00:12 -0700 (Thu, 27 Sep 2012)
Log Message
[EFL][WK2] Add callback functions for WKPageFindClient
https://bugs.webkit.org/show_bug.cgi?id=97431
Patch by Jinwoo Song jinwoo7.s...@samsung.com on 2012-09-27
Reviewed by Laszlo Gombos.
Add didFailToFindString() and didCountStringMatches() for WKPageFindClient's callback functions.
The unit test for didFindString() and didFailToFindString() have beend added. The unit test for
didCountStringMatches() needs a API which wraps the WKPageCountStringMatches but it is not exists yet.
Additionaly, I changed the 'unsinged int' to 'unsigned' in the parameter type and removed unnecessary
type conversion.
* UIProcess/API/efl/ewk_view.cpp:
(ewk_view_text_find):
* UIProcess/API/efl/ewk_view.h:
* UIProcess/API/efl/ewk_view_find_client.cpp:
(didFindString):
(didFailToFindString):
(didCountStringMatches):
(ewk_view_find_client_attach):
* UIProcess/API/efl/tests/test_ewk2_view.cpp:
(onTextFound):
(TEST_F):
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/efl/ewk_view.cpp
trunk/Source/WebKit2/UIProcess/API/efl/ewk_view.h
trunk/Source/WebKit2/UIProcess/API/efl/ewk_view_find_client.cpp
trunk/Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_view.cpp
Diff
Modified: trunk/Source/WebKit2/ChangeLog (129757 => 129758)
--- trunk/Source/WebKit2/ChangeLog 2012-09-27 12:53:56 UTC (rev 129757)
+++ trunk/Source/WebKit2/ChangeLog 2012-09-27 13:00:12 UTC (rev 129758)
@@ -1,3 +1,28 @@
+2012-09-27 Jinwoo Song jinwoo7.s...@samsung.com
+
+[EFL][WK2] Add callback functions for WKPageFindClient
+https://bugs.webkit.org/show_bug.cgi?id=97431
+
+Reviewed by Laszlo Gombos.
+
+Add didFailToFindString() and didCountStringMatches() for WKPageFindClient's callback functions.
+The unit test for didFindString() and didFailToFindString() have beend added. The unit test for
+didCountStringMatches() needs a API which wraps the WKPageCountStringMatches but it is not exists yet.
+Additionaly, I changed the 'unsinged int' to 'unsigned' in the parameter type and removed unnecessary
+type conversion.
+
+* UIProcess/API/efl/ewk_view.cpp:
+(ewk_view_text_find):
+* UIProcess/API/efl/ewk_view.h:
+* UIProcess/API/efl/ewk_view_find_client.cpp:
+(didFindString):
+(didFailToFindString):
+(didCountStringMatches):
+(ewk_view_find_client_attach):
+* UIProcess/API/efl/tests/test_ewk2_view.cpp:
+(onTextFound):
+(TEST_F):
+
2012-09-27 Allan Sandfeld Jensen allan.jen...@digia.com
Unify event handling of middle mouse button.
Modified: trunk/Source/WebKit2/UIProcess/API/efl/ewk_view.cpp (129757 => 129758)
--- trunk/Source/WebKit2/UIProcess/API/efl/ewk_view.cpp 2012-09-27 12:53:56 UTC (rev 129757)
+++ trunk/Source/WebKit2/UIProcess/API/efl/ewk_view.cpp 2012-09-27 13:00:12 UTC (rev 129758)
@@ -1517,7 +1517,7 @@
COMPILE_ASSERT_MATCHING_ENUM(EWK_FIND_OPTIONS_SHOW_FIND_INDICATOR, kWKFindOptionsShowFindIndicator);
COMPILE_ASSERT_MATCHING_ENUM(EWK_FIND_OPTIONS_SHOW_HIGHLIGHT, kWKFindOptionsShowHighlight);
-Eina_Bool ewk_view_text_find(Evas_Object* ewkView, const char* text, Ewk_Find_Options options, unsigned int maxMatchCount)
+Eina_Bool ewk_view_text_find(Evas_Object* ewkView, const char* text, Ewk_Find_Options options, unsigned maxMatchCount)
{
EWK_VIEW_SD_GET_OR_RETURN(ewkView, smartData, false);
EWK_VIEW_PRIV_GET_OR_RETURN(smartData, priv, false);
Modified: trunk/Source/WebKit2/UIProcess/API/efl/ewk_view.h (129757 => 129758)
--- trunk/Source/WebKit2/UIProcess/API/efl/ewk_view.h 2012-09-27 12:53:56 UTC (rev 129757)
+++ trunk/Source/WebKit2/UIProcess/API/efl/ewk_view.h 2012-09-27 13:00:12 UTC (rev 129758)
@@ -622,7 +622,7 @@
*
* @return @c EINA_TRUE on success, @c EINA_FALSE on errors
*/
-EAPI Eina_Bool ewk_view_text_find(Evas_Object *o, const char *text, Ewk_Find_Options options, unsigned int max_match_count);
+EAPI Eina_Bool ewk_view_text_find(Evas_Object *o, const char *text, Ewk_Find_Options options, unsigned max_match_count);
/**
* Clears the highlight of searched text.
Modified: trunk/Source/WebKit2/UIProcess/API/efl/ewk_view_find_client.cpp (129757 => 129758)
--- trunk/Source/WebKit2/UIProcess/API/efl/ewk_view_find_client.cpp 2012-09-27 12:53:56 UTC (rev 129757)
+++ trunk/Source/WebKit2/UIProcess/API/efl/ewk_view_find_client.cpp 2012-09-27 13:00:12 UTC (rev 129758)
@@ -34,11 +34,21 @@
return static_castEvas_Object*(const_castvoid*(clientInfo));
}
-static void didFindString(WKPageRef, WKStringRef /*string*/, unsigned matchCount, const void* clientInfo)
+static void didFindString(WKPageRef, WKStringRef, unsigned matchCount, const void* clientInfo)
{
-ewk_view_text_found(toEwkView(clientInfo), static_castunsigned int(matchCount));
+
[webkit-changes] [129759] trunk/Source/WebCore
Title: [129759] trunk/Source/WebCore
Revision 129759
Author commit-qu...@webkit.org
Date 2012-09-27 06:17:18 -0700 (Thu, 27 Sep 2012)
Log Message
[CMAKE] Remove unnecessary header files from CMakeLists.txt
https://bugs.webkit.org/show_bug.cgi?id=97771
Patch by Jinwoo Song jinwoo7.s...@samsung.com on 2012-09-27
Reviewed by Kentaro Hara.
Remove the header files which are added in the source file list.
* CMakeLists.txt:
Modified Paths
trunk/Source/WebCore/CMakeLists.txt
trunk/Source/WebCore/ChangeLog
Diff
Modified: trunk/Source/WebCore/CMakeLists.txt (129758 => 129759)
--- trunk/Source/WebCore/CMakeLists.txt 2012-09-27 13:00:12 UTC (rev 129758)
+++ trunk/Source/WebCore/CMakeLists.txt 2012-09-27 13:17:18 UTC (rev 129759)
@@ -1908,10 +1908,6 @@
platform/graphics/filters/SourceGraphic.cpp
platform/graphics/filters/SpotLightSource.cpp
-platform/graphics/filters/arm/NEONHelpers.h
-platform/graphics/filters/arm/FEBlendNEON.h
-platform/graphics/filters/arm/FECompositeArithmeticNEON.h
-platform/graphics/filters/arm/FEGaussianBlurNEON.h
platform/graphics/filters/arm/FELightingNEON.cpp
platform/graphics/texmap/TextureMapper.cpp
@@ -2597,19 +2593,13 @@
${THIRDPARTY_DIR}/ANGLE/src/compiler/CodeGenGLSL.cpp
${THIRDPARTY_DIR}/ANGLE/src/compiler/Compiler.cpp
${THIRDPARTY_DIR}/ANGLE/src/compiler/Diagnostics.cpp
-${THIRDPARTY_DIR}/ANGLE/src/compiler/Diagnostics.h
${THIRDPARTY_DIR}/ANGLE/src/compiler/DirectiveHandler.cpp
-${THIRDPARTY_DIR}/ANGLE/src/compiler/DirectiveHandler.h
${THIRDPARTY_DIR}/ANGLE/src/compiler/debug.cpp
${THIRDPARTY_DIR}/ANGLE/src/compiler/depgraph/DependencyGraph.cpp
-${THIRDPARTY_DIR}/ANGLE/src/compiler/depgraph/DependencyGraph.h
-${THIRDPARTY_DIR}/ANGLE/src/compiler/depgraph/DependencyGraphBuilder.h
${THIRDPARTY_DIR}/ANGLE/src/compiler/depgraph/DependencyGraphBuilder.cpp
-${THIRDPARTY_DIR}/ANGLE/src/compiler/depgraph/DependencyGraphOutput.h
${THIRDPARTY_DIR}/ANGLE/src/compiler/depgraph/DependencyGraphOutput.cpp
${THIRDPARTY_DIR}/ANGLE/src/compiler/depgraph/DependencyGraphTraverse.cpp
${THIRDPARTY_DIR}/ANGLE/src/compiler/DetectDiscontinuity.cpp
-${THIRDPARTY_DIR}/ANGLE/src/compiler/DetectDiscontinuity.h
${THIRDPARTY_DIR}/ANGLE/src/compiler/DetectRecursion.cpp
${THIRDPARTY_DIR}/ANGLE/src/compiler/ForLoopUnroll.cpp
${THIRDPARTY_DIR}/ANGLE/src/compiler/InfoSink.cpp
@@ -2628,52 +2618,35 @@
${THIRDPARTY_DIR}/ANGLE/src/compiler/parseConst.cpp
${THIRDPARTY_DIR}/ANGLE/src/compiler/ParseHelper.cpp
${THIRDPARTY_DIR}/ANGLE/src/compiler/PoolAlloc.cpp
-${THIRDPARTY_DIR}/ANGLE/src/compiler/Pragma.h
${THIRDPARTY_DIR}/ANGLE/src/compiler/preprocessor/atom.c
${THIRDPARTY_DIR}/ANGLE/src/compiler/preprocessor/cpp.c
${THIRDPARTY_DIR}/ANGLE/src/compiler/preprocessor/cppstruct.c
${THIRDPARTY_DIR}/ANGLE/src/compiler/preprocessor/memory.c
${THIRDPARTY_DIR}/ANGLE/src/compiler/preprocessor/new/DiagnosticsBase.cpp
-${THIRDPARTY_DIR}/ANGLE/src/compiler/preprocessor/new/Diagnostics.h
${THIRDPARTY_DIR}/ANGLE/src/compiler/preprocessor/new/DirectiveHandlerBase.cpp
-${THIRDPARTY_DIR}/ANGLE/src/compiler/preprocessor/new/DirectiveHandler.h
${THIRDPARTY_DIR}/ANGLE/src/compiler/preprocessor/new/DirectiveParser.cpp
-${THIRDPARTY_DIR}/ANGLE/src/compiler/preprocessor/new/DirectiveParser.h
${THIRDPARTY_DIR}/ANGLE/src/compiler/preprocessor/new/ExpressionParser.cpp
-${THIRDPARTY_DIR}/ANGLE/src/compiler/preprocessor/new/ExpressionParser.h
${THIRDPARTY_DIR}/ANGLE/src/compiler/preprocessor/new/Input.cpp
-${THIRDPARTY_DIR}/ANGLE/src/compiler/preprocessor/new/Input.h
${THIRDPARTY_DIR}/ANGLE/src/compiler/preprocessor/new/Lexer.cpp
-${THIRDPARTY_DIR}/ANGLE/src/compiler/preprocessor/new/Lexer.h
${THIRDPARTY_DIR}/ANGLE/src/compiler/preprocessor/new/Macro.cpp
-${THIRDPARTY_DIR}/ANGLE/src/compiler/preprocessor/new/Macro.h
${THIRDPARTY_DIR}/ANGLE/src/compiler/preprocessor/new/MacroExpander.cpp
-${THIRDPARTY_DIR}/ANGLE/src/compiler/preprocessor/new/MacroExpander.h
${THIRDPARTY_DIR}/ANGLE/src/compiler/preprocessor/new/Preprocessor.cpp
-${THIRDPARTY_DIR}/ANGLE/src/compiler/preprocessor/new/Preprocessor.h
-${THIRDPARTY_DIR}/ANGLE/src/compiler/preprocessor/new/SourceLocation.h
${THIRDPARTY_DIR}/ANGLE/src/compiler/preprocessor/new/Token.cpp
-${THIRDPARTY_DIR}/ANGLE/src/compiler/preprocessor/new/Token.h
${THIRDPARTY_DIR}/ANGLE/src/compiler/preprocessor/new/Tokenizer.cpp
-${THIRDPARTY_DIR}/ANGLE/src/compiler/preprocessor/new/Tokenizer.h
${THIRDPARTY_DIR}/ANGLE/src/compiler/preprocessor/scanner.c
${THIRDPARTY_DIR}/ANGLE/src/compiler/preprocessor/symbols.c
[webkit-changes] [129760] trunk/Source
Title: [129760] trunk/Source
Revision 129760
Author o...@webkit.org
Date 2012-09-27 06:28:34 -0700 (Thu, 27 Sep 2012)
Log Message
[Qt] Enable the LLInt on Linux
https://bugs.webkit.org/show_bug.cgi?id=95749
Patch by Csaba Osztrogonác o...@webkit.org, Tor Arne Vestbø ves...@webkit.org on 2012-09-27
Reviewed by Simon Hausmann.
Source/_javascript_Core:
* DerivedSources.pri:
* _javascript_Core.pro:
* LLIntOffsetsExtractor.pro: Added.
* Target.pri:
Source/WTF:
* wtf/Platform.h:
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/DerivedSources.pri
trunk/Source/_javascript_Core/_javascript_Core.pro
trunk/Source/_javascript_Core/Target.pri
trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/Platform.h
Added Paths
trunk/Source/_javascript_Core/LLIntOffsetsExtractor.pro
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (129759 => 129760)
--- trunk/Source/_javascript_Core/ChangeLog 2012-09-27 13:17:18 UTC (rev 129759)
+++ trunk/Source/_javascript_Core/ChangeLog 2012-09-27 13:28:34 UTC (rev 129760)
@@ -1,3 +1,15 @@
+2012-09-27 Csaba Osztrogonác o...@webkit.org, Tor Arne Vestbø ves...@webkit.org
+
+[Qt] Enable the LLInt on Linux
+https://bugs.webkit.org/show_bug.cgi?id=95749
+
+Reviewed by Simon Hausmann.
+
+* DerivedSources.pri:
+* _javascript_Core.pro:
+* LLIntOffsetsExtractor.pro: Added.
+* Target.pri:
+
2012-09-27 Patrick Gansterer par...@webkit.org
[CMake] Fix build with static _javascript_Core library
Modified: trunk/Source/_javascript_Core/DerivedSources.pri (129759 => 129760)
--- trunk/Source/_javascript_Core/DerivedSources.pri 2012-09-27 13:17:18 UTC (rev 129759)
+++ trunk/Source/_javascript_Core/DerivedSources.pri 2012-09-27 13:28:34 UTC (rev 129760)
@@ -33,6 +33,9 @@
JIT_STUB_FILES += \
jit/JITStubs.cpp
+LLINT_FILES = \
+llint/LowLevelInterpreter.asm
+
# GENERATOR 1-A: LUT creator
lut.output = ${QMAKE_FILE_BASE}.lut.h
lut.input = LUT_FILES
@@ -80,3 +83,12 @@
klgen.input = KEYWORDLUT_FILES
klgen.commands = python $$klgen.script ${QMAKE_FILE_NAME} ${QMAKE_FILE_OUT}
GENERATORS += klgen
+
+linux-*:!equals(QT_ARCH, arm) {
+#GENERATOR: LLInt
+llint.output = LLIntAssembly.h
+llint.script = $$PWD/offlineasm/asm.rb
+llint.input = LLINT_FILES
+llint.commands = ruby $$llint.script ${QMAKE_FILE_NAME} LLIntOffsetsExtractor ${QMAKE_FILE_OUT}
+GENERATORS += llint
+}
Modified: trunk/Source/_javascript_Core/_javascript_Core.pro (129759 => 129760)
--- trunk/Source/_javascript_Core/_javascript_Core.pro 2012-09-27 13:17:18 UTC (rev 129759)
+++ trunk/Source/_javascript_Core/_javascript_Core.pro 2012-09-27 13:28:34 UTC (rev 129760)
@@ -7,11 +7,18 @@
TEMPLATE = subdirs
CONFIG += ordered
+linux-*:!equals(QT_ARCH, arm) {
+LLIntOffsetsExtractor.file = LLIntOffsetsExtractor.pro
+LLIntOffsetsExtractor.makefile = Makefile.LLIntOffsetsExtractor
+SUBDIRS += LLIntOffsetsExtractor
+}
+
derived_sources.file = DerivedSources.pri
target.file = Target.pri
SUBDIRS += derived_sources target
+linux-*:!equals(QT_ARCH, arm):addStrictSubdirOrderBetween(LLIntOffsetsExtractor, derived_sources)
addStrictSubdirOrderBetween(derived_sources, target)
jsc.file = jsc.pro
Added: trunk/Source/_javascript_Core/LLIntOffsetsExtractor.pro (0 => 129760)
--- trunk/Source/_javascript_Core/LLIntOffsetsExtractor.pro (rev 0)
+++ trunk/Source/_javascript_Core/LLIntOffsetsExtractor.pro 2012-09-27 13:28:34 UTC (rev 129760)
@@ -0,0 +1,36 @@
+# ---
+# Project file for the LLIntOffsetsExtractor binary, used to generate
+# derived sources for _javascript_Core.
+#
+# See 'Tools/qmake/README' for an overview of the build system
+# ---
+
+TEMPLATE = app
+TARGET = LLIntOffsetsExtractor
+DESTDIR = $$OUT_PWD
+
+QT = core # Needed for qglobal.h
+
+defineTest(addIncludePaths) {
+# Just needed for include paths
+include(../WTF/WTF.pri)
+include(_javascript_Core.pri)
+
+export(INCLUDEPATH)
+}
+
+addIncludePaths()
+
+INPUT_FILES = $$PWD/llint/LowLevelInterpreter.asm
+llint.output = LLIntDesiredOffsets.h
+llint.script = $$PWD/offlineasm/generate_offset_extractor.rb
+llint.input = INPUT_FILES
+llint.commands = ruby $$llint.script ${QMAKE_FILE_NAME} ${QMAKE_FILE_OUT}
+llint.CONFIG += no_link
+QMAKE_EXTRA_COMPILERS += llint
+
+# Compilation of this file will automatically depend on LLIntDesiredOffsets.h
+# due to qmake scanning the source file for header dependencies.
+SOURCES = llint/LLIntOffsetsExtractor.cpp
+
+mac: LIBS_PRIVATE += -framework AppKit
Modified: trunk/Source/_javascript_Core/Target.pri (129759 => 129760)
--- trunk/Source/_javascript_Core/Target.pri 2012-09-27 13:17:18 UTC (rev 129759)
+++ trunk/Source/_javascript_Core/Target.pri 2012-09-27 13:28:34 UTC (rev 129760)
@@ -156,6 +156,13 @@
[webkit-changes] [129761] trunk/Tools
Title: [129761] trunk/Tools
Revision 129761
Author tom...@google.com
Date 2012-09-27 06:44:06 -0700 (Thu, 27 Sep 2012)
Log Message
MediaStream API: Rename MockConstraints::verify to verifyConstraints
https://bugs.webkit.org/show_bug.cgi?id=97779
Reviewed by Csaba Osztrogonác.
The Mac OS X sdk has a macro called verify :/
* DumpRenderTree/chromium/MockConstraints.cpp:
(MockConstraints::verifyConstraints):
* DumpRenderTree/chromium/MockConstraints.h:
(MockConstraints):
* DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
(MockWebRTCPeerConnectionHandler::initialize):
* DumpRenderTree/chromium/WebUserMediaClientMock.cpp:
(WebUserMediaClientMock::requestUserMedia):
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/DumpRenderTree/chromium/MockConstraints.cpp
trunk/Tools/DumpRenderTree/chromium/MockConstraints.h
trunk/Tools/DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp
trunk/Tools/DumpRenderTree/chromium/WebUserMediaClientMock.cpp
Diff
Modified: trunk/Tools/ChangeLog (129760 => 129761)
--- trunk/Tools/ChangeLog 2012-09-27 13:28:34 UTC (rev 129760)
+++ trunk/Tools/ChangeLog 2012-09-27 13:44:06 UTC (rev 129761)
@@ -1,5 +1,23 @@
2012-09-27 Tommy Widenflycht tom...@google.com
+MediaStream API: Rename MockConstraints::verify to verifyConstraints
+https://bugs.webkit.org/show_bug.cgi?id=97779
+
+Reviewed by Csaba Osztrogonác.
+
+The Mac OS X sdk has a macro called verify :/
+
+* DumpRenderTree/chromium/MockConstraints.cpp:
+(MockConstraints::verifyConstraints):
+* DumpRenderTree/chromium/MockConstraints.h:
+(MockConstraints):
+* DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
+(MockWebRTCPeerConnectionHandler::initialize):
+* DumpRenderTree/chromium/WebUserMediaClientMock.cpp:
+(WebUserMediaClientMock::requestUserMedia):
+
+2012-09-27 Tommy Widenflycht tom...@google.com
+
MediaStream API: Update getUserMedia to match the latest specification
https://bugs.webkit.org/show_bug.cgi?id=97540
Modified: trunk/Tools/DumpRenderTree/chromium/MockConstraints.cpp (129760 => 129761)
--- trunk/Tools/DumpRenderTree/chromium/MockConstraints.cpp 2012-09-27 13:28:34 UTC (rev 129760)
+++ trunk/Tools/DumpRenderTree/chromium/MockConstraints.cpp 2012-09-27 13:44:06 UTC (rev 129761)
@@ -49,7 +49,7 @@
return isSupported(constraint) || constraint == valid_but_unsupported_1 || constraint == valid_but_unsupported_2;
}
-bool verify(const WebMediaConstraints constraints)
+bool verifyConstraints(const WebMediaConstraints constraints)
{
WebVectorWebString mandatoryConstraintNames;
constraints.getMandatoryConstraintNames(mandatoryConstraintNames);
Modified: trunk/Tools/DumpRenderTree/chromium/MockConstraints.h (129760 => 129761)
--- trunk/Tools/DumpRenderTree/chromium/MockConstraints.h 2012-09-27 13:28:34 UTC (rev 129760)
+++ trunk/Tools/DumpRenderTree/chromium/MockConstraints.h 2012-09-27 13:44:06 UTC (rev 129761)
@@ -39,7 +39,7 @@
namespace MockConstraints {
-bool verify(const WebKit::WebMediaConstraints);
+bool verifyConstraints(const WebKit::WebMediaConstraints);
} // namespace MockConstraints
Modified: trunk/Tools/DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp (129760 => 129761)
--- trunk/Tools/DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp 2012-09-27 13:28:34 UTC (rev 129760)
+++ trunk/Tools/DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp 2012-09-27 13:44:06 UTC (rev 129761)
@@ -111,7 +111,7 @@
bool MockWebRTCPeerConnectionHandler::initialize(const WebRTCConfiguration, const WebMediaConstraints constraints)
{
-return MockConstraints::verify(constraints);
+return MockConstraints::verifyConstraints(constraints);
}
void MockWebRTCPeerConnectionHandler::createOffer(const WebRTCSessionDescriptionRequest request, const WebMediaConstraints constraints)
Modified: trunk/Tools/DumpRenderTree/chromium/WebUserMediaClientMock.cpp (129760 => 129761)
--- trunk/Tools/DumpRenderTree/chromium/WebUserMediaClientMock.cpp 2012-09-27 13:28:34 UTC (rev 129760)
+++ trunk/Tools/DumpRenderTree/chromium/WebUserMediaClientMock.cpp 2012-09-27 13:44:06 UTC (rev 129761)
@@ -90,12 +90,12 @@
}
WebMediaConstraints constraints = request.audioConstraints();
-if (!constraints.isNull() !MockConstraints::verify(constraints)) {
+if (!constraints.isNull() !MockConstraints::verifyConstraints(constraints)) {
postTask(new UserMediaRequestTask(this, request, WebMediaStreamDescriptor()));
return;
}
constraints = request.videoConstraints();
-if (!constraints.isNull() !MockConstraints::verify(constraints)) {
+if (!constraints.isNull() !MockConstraints::verifyConstraints(constraints)) {
postTask(new UserMediaRequestTask(this, request, WebMediaStreamDescriptor()));
return;
}
___
[webkit-changes] [129764] trunk
Title: [129764] trunk
Revision 129764
Author tom...@google.com
Date 2012-09-27 07:56:53 -0700 (Thu, 27 Sep 2012)
Log Message
MediaStream API: Enhance MediaConstraints to make it easier to get the constraint data
https://bugs.webkit.org/show_bug.cgi?id=97559
Reviewed by Adam Barth.
Source/Platform:
Refactored to mimic the new MediaConstraints api.
* chromium/public/WebMediaConstraints.h:
(WebCore):
(WebKit::WebMediaConstraint::WebMediaConstraint):
(WebMediaConstraint):
(WebKit):
(WebMediaConstraints):
Source/WebCore:
Instead of just returning the names, return a pair of name and value.
Existing tests cover this patch.
* Modules/mediastream/MediaConstraintsImpl.cpp:
(WebCore::MediaConstraintsImpl::initialize):
(WebCore::MediaConstraintsImpl::getMandatoryConstraints):
(WebCore::MediaConstraintsImpl::getOptionalConstraints):
(WebCore::MediaConstraintsImpl::getOptionalConstraintValue):
* Modules/mediastream/MediaConstraintsImpl.h:
(MediaConstraintsImpl):
* platform/chromium/support/WebMediaConstraints.cpp:
(WebKit::WebMediaConstraint::WebMediaConstraint):
(WebKit):
(WebKit::WebMediaConstraints::getMandatoryConstraints):
(WebKit::WebMediaConstraints::getOptionalConstraints):
* platform/mediastream/MediaConstraints.h:
(WebCore::MediaConstraint::MediaConstraint):
(MediaConstraint):
(WebCore):
(MediaConstraints):
Tools:
Refactoring for the new WebMediaConstraints api.
* DumpRenderTree/chromium/MockConstraints.cpp:
(MockConstraints::verify):
Modified Paths
trunk/Source/Platform/ChangeLog
trunk/Source/Platform/chromium/public/WebMediaConstraints.h
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/mediastream/MediaConstraintsImpl.cpp
trunk/Source/WebCore/Modules/mediastream/MediaConstraintsImpl.h
trunk/Source/WebCore/platform/chromium/support/WebMediaConstraints.cpp
trunk/Source/WebCore/platform/mediastream/MediaConstraints.h
trunk/Tools/ChangeLog
trunk/Tools/DumpRenderTree/chromium/MockConstraints.cpp
Diff
Modified: trunk/Source/Platform/ChangeLog (129763 => 129764)
--- trunk/Source/Platform/ChangeLog 2012-09-27 13:51:04 UTC (rev 129763)
+++ trunk/Source/Platform/ChangeLog 2012-09-27 14:56:53 UTC (rev 129764)
@@ -1,5 +1,21 @@
2012-09-27 Tommy Widenflycht tom...@google.com
+MediaStream API: Enhance MediaConstraints to make it easier to get the constraint data
+https://bugs.webkit.org/show_bug.cgi?id=97559
+
+Reviewed by Adam Barth.
+
+Refactored to mimic the new MediaConstraints api.
+
+* chromium/public/WebMediaConstraints.h:
+(WebCore):
+(WebKit::WebMediaConstraint::WebMediaConstraint):
+(WebMediaConstraint):
+(WebKit):
+(WebMediaConstraints):
+
+2012-09-27 Tommy Widenflycht tom...@google.com
+
MediaStream API: Update getUserMedia to match the latest specification
https://bugs.webkit.org/show_bug.cgi?id=97540
Modified: trunk/Source/Platform/chromium/public/WebMediaConstraints.h (129763 => 129764)
--- trunk/Source/Platform/chromium/public/WebMediaConstraints.h 2012-09-27 13:51:04 UTC (rev 129763)
+++ trunk/Source/Platform/chromium/public/WebMediaConstraints.h 2012-09-27 14:56:53 UTC (rev 129764)
@@ -38,11 +38,31 @@
#include WebVector.h
namespace WebCore {
+struct MediaConstraint;
class MediaConstraints;
}
namespace WebKit {
+struct WebMediaConstraint {
+WebMediaConstraint()
+{
+}
+
+WebMediaConstraint(WebString name, WebString value)
+: m_name(name)
+, m_value(value)
+{
+}
+
+#if WEBKIT_IMPLEMENTATION
+WebMediaConstraint(const WebCore::MediaConstraint);
+#endif
+
+WebString m_name;
+WebString m_value;
+};
+
class WebMediaConstraints {
public:
WebMediaConstraints() { }
@@ -60,8 +80,8 @@
WEBKIT_EXPORT void reset();
bool isNull() const { return m_private.isNull(); }
-WEBKIT_EXPORT void getMandatoryConstraintNames(WebVectorWebString names) const;
-WEBKIT_EXPORT void getOptionalConstraintNames(WebVectorWebString names) const;
+WEBKIT_EXPORT void getMandatoryConstraints(WebVectorWebMediaConstraint) const;
+WEBKIT_EXPORT void getOptionalConstraints(WebVectorWebMediaConstraint) const;
WEBKIT_EXPORT bool getMandatoryConstraintValue(const WebString name, WebString value) const;
WEBKIT_EXPORT bool getOptionalConstraintValue(const WebString name, WebString value) const;
Modified: trunk/Source/WebCore/ChangeLog (129763 => 129764)
--- trunk/Source/WebCore/ChangeLog 2012-09-27 13:51:04 UTC (rev 129763)
+++ trunk/Source/WebCore/ChangeLog 2012-09-27 14:56:53 UTC (rev 129764)
@@ -1,3 +1,32 @@
+2012-09-27 Tommy Widenflycht tom...@google.com
+
+MediaStream API: Enhance MediaConstraints to make it easier to get the constraint data
+https://bugs.webkit.org/show_bug.cgi?id=97559
+
+Reviewed by Adam Barth.
+
+Instead of just returning the names, return a pair of name and value.
+
+Existing tests cover this patch.
+
+*
[webkit-changes] [129765] trunk/Source/WebKit2
Title: [129765] trunk/Source/WebKit2
Revision 129765
Author commit-qu...@webkit.org
Date 2012-09-27 08:08:14 -0700 (Thu, 27 Sep 2012)
Log Message
[EFL][WK2] Process touch events using mouse and multi events of Evas.
https://bugs.webkit.org/show_bug.cgi?id=96906
Patch by Eunmi Lee eunmi15@samsung.com on 2012-09-27
Reviewed by Kenneth Rohde Christiansen.
Provide default behavior for processing touch events in the ewk_view if
application wants to use it.
We can to process touch events using mouse and multi events because the
Evas creates mouse events for first touch and multi events for second and
third touch. It can be modified when Evas starts to support event type
for touch events.
* UIProcess/API/efl/ewk_view.cpp:
(_Ewk_View_Private_Data):
(_Ewk_View_Private_Data::_Ewk_View_Private_Data):
(_ewk_view_feed_touch_event_using_touch_point_list_of_evas):
(_ewk_view_on_touch_down):
(_ewk_view_on_touch_up):
(_ewk_view_on_touch_move):
(ewk_view_touch_events_enabled_set):
(ewk_view_touch_events_enabled_get):
* UIProcess/API/efl/ewk_view.h:
* UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestBase.cpp:
(EWK2UnitTest::EWK2UnitTestBase::mouseDown):
(EWK2UnitTest):
(EWK2UnitTest::EWK2UnitTestBase::mouseUp):
(EWK2UnitTest::EWK2UnitTestBase::mouseMove):
(EWK2UnitTest::EWK2UnitTestBase::multiDown):
(EWK2UnitTest::EWK2UnitTestBase::multiUp):
(EWK2UnitTest::EWK2UnitTestBase::multiMove):
* UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestBase.h:
(EWK2UnitTestBase):
* UIProcess/API/efl/tests/test_ewk2_view.cpp:
(TEST_F):
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/efl/ewk_view.cpp
trunk/Source/WebKit2/UIProcess/API/efl/ewk_view.h
trunk/Source/WebKit2/UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestBase.cpp
trunk/Source/WebKit2/UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestBase.h
trunk/Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_view.cpp
Diff
Modified: trunk/Source/WebKit2/ChangeLog (129764 => 129765)
--- trunk/Source/WebKit2/ChangeLog 2012-09-27 14:56:53 UTC (rev 129764)
+++ trunk/Source/WebKit2/ChangeLog 2012-09-27 15:08:14 UTC (rev 129765)
@@ -1,3 +1,40 @@
+2012-09-27 Eunmi Lee eunmi15@samsung.com
+
+[EFL][WK2] Process touch events using mouse and multi events of Evas.
+https://bugs.webkit.org/show_bug.cgi?id=96906
+
+Reviewed by Kenneth Rohde Christiansen.
+
+Provide default behavior for processing touch events in the ewk_view if
+application wants to use it.
+We can to process touch events using mouse and multi events because the
+Evas creates mouse events for first touch and multi events for second and
+third touch. It can be modified when Evas starts to support event type
+for touch events.
+
+* UIProcess/API/efl/ewk_view.cpp:
+(_Ewk_View_Private_Data):
+(_Ewk_View_Private_Data::_Ewk_View_Private_Data):
+(_ewk_view_feed_touch_event_using_touch_point_list_of_evas):
+(_ewk_view_on_touch_down):
+(_ewk_view_on_touch_up):
+(_ewk_view_on_touch_move):
+(ewk_view_touch_events_enabled_set):
+(ewk_view_touch_events_enabled_get):
+* UIProcess/API/efl/ewk_view.h:
+* UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestBase.cpp:
+(EWK2UnitTest::EWK2UnitTestBase::mouseDown):
+(EWK2UnitTest):
+(EWK2UnitTest::EWK2UnitTestBase::mouseUp):
+(EWK2UnitTest::EWK2UnitTestBase::mouseMove):
+(EWK2UnitTest::EWK2UnitTestBase::multiDown):
+(EWK2UnitTest::EWK2UnitTestBase::multiUp):
+(EWK2UnitTest::EWK2UnitTestBase::multiMove):
+* UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestBase.h:
+(EWK2UnitTestBase):
+* UIProcess/API/efl/tests/test_ewk2_view.cpp:
+(TEST_F):
+
2012-09-27 Jinwoo Song jinwoo7.s...@samsung.com
[EFL][WK2] Add callback functions for WKPageFindClient
Modified: trunk/Source/WebKit2/UIProcess/API/efl/ewk_view.cpp (129764 => 129765)
--- trunk/Source/WebKit2/UIProcess/API/efl/ewk_view.cpp 2012-09-27 14:56:53 UTC (rev 129764)
+++ trunk/Source/WebKit2/UIProcess/API/efl/ewk_view.cpp 2012-09-27 15:08:14 UTC (rev 129765)
@@ -101,6 +101,9 @@
bool areMouseEventsEnabled;
WKColorPickerResultListenerRef colorPickerResultListener;
Ewk_Context* context;
+#if ENABLE(TOUCH_EVENTS)
+bool areTouchEventsEnabled;
+#endif
WebPopupMenuProxyEfl* popupMenuProxy;
Eina_List* popupMenuItems;
@@ -121,6 +124,9 @@
, areMouseEventsEnabled(false)
, colorPickerResultListener(0)
, context(0)
+#if ENABLE(TOUCH_EVENTS)
+, areTouchEventsEnabled(false)
+#endif
, popupMenuProxy(0)
, popupMenuItems(0)
#ifdef HAVE_ECORE_X
@@ -356,6 +362,47 @@
smartData-api-key_up(smartData, upEvent);
}
+#if ENABLE(TOUCH_EVENTS)
+static inline void _ewk_view_feed_touch_event_using_touch_point_list_of_evas(Evas_Object* ewkView, Ewk_Touch_Event_Type type)
+{
+
[webkit-changes] [129766] trunk/LayoutTests
Title: [129766] trunk/LayoutTests Revision 129766 Author commit-qu...@webkit.org Date 2012-09-27 08:26:23 -0700 (Thu, 27 Sep 2012) Log Message [EFL][WK2][WTR] Unskip two jQuery test cases. https://bugs.webkit.org/show_bug.cgi?id=97787 Unreviewed EFL gardening. 'jquery/data.html' and 'jquery/offset.html' cases seem to be passed consistently now. For more information, BUG 81606 resolved some jQuery test cases that need several seconds to finish its running by extending timeout value like WK1. Seemingly, mentioned two cases took around 5 seconds for each on my laptop and it would had been flaky in different hardware condition before BUG 81606. Therefore, this patch unskipped those cases from TestExpections. Patch by Kangil Han kangil@samsung.com on 2012-09-27 * platform/efl-wk2/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/efl-wk2/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (129765 => 129766) --- trunk/LayoutTests/ChangeLog 2012-09-27 15:08:14 UTC (rev 129765) +++ trunk/LayoutTests/ChangeLog 2012-09-27 15:26:23 UTC (rev 129766) @@ -1,3 +1,22 @@ +2012-09-27 Kangil Han kangil@samsung.com + +[EFL][WK2][WTR] Unskip two jQuery test cases. +https://bugs.webkit.org/show_bug.cgi?id=97787 + +Unreviewed EFL gardening. + +'jquery/data.html' and 'jquery/offset.html' cases seem to be passed consistently now. + +For more information, BUG 81606 resolved some jQuery test cases +that need several seconds to finish its running by extending timeout value like WK1. + +Seemingly, mentioned two cases took around 5 seconds for each on my laptop +and it would had been flaky in different hardware condition before BUG 81606. + +Therefore, this patch unskipped those cases from TestExpections. + +* platform/efl-wk2/TestExpectations: + 2012-09-27 Stephen Chenney schen...@chromium.org Unreviewed Chromium expectations Modified: trunk/LayoutTests/platform/efl-wk2/TestExpectations (129765 => 129766) --- trunk/LayoutTests/platform/efl-wk2/TestExpectations 2012-09-27 15:08:14 UTC (rev 129765) +++ trunk/LayoutTests/platform/efl-wk2/TestExpectations 2012-09-27 15:26:23 UTC (rev 129766) @@ -121,8 +121,6 @@ Bug(EFL) fast/events/domactivate-sets-underlying-click-event-as-handled.html [ Failure Pass ] Bug(EFL) http/tests/inspector/change-iframe-src.html [ Failure Pass ] Bug(EFL) http/tests/loading/fire-error-event-empty-404-script.html [ Crash Failure Pass ] -Bug(EFL) jquery/data.html [ Failure Pass ] -Bug(EFL) jquery/offset.html [ Failure Pass ] Bug(EFL) sputnik/Conformance/07_Lexical_Conventions/7.4_Comments/S7.4_A5.html [ Crash Failure Pass ] Bug(EFL) sputnik/Conformance/07_Lexical_Conventions/7.4_Comments/S7.4_A6.html [ Crash Failure Pass ] Bug(EFL) sputnik/Conformance/07_Lexical_Conventions/7.8_Literals/7.8.5_Regular_Expression_Literals/S7.8.5_A1.1_T2.html [ Crash Failure Pass ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [129767] trunk/LayoutTests
Title: [129767] trunk/LayoutTests Revision 129767 Author schen...@chromium.org Date 2012-09-27 08:42:02 -0700 (Thu, 27 Sep 2012) Log Message Unreviewed Chromium expectations Expectations that were lagging at the last rebaseline. * platform/chromium-linux-x86/fast/repaint/block-selection-gap-in-composited-layer-expected.png: Removed. * platform/chromium-linux-x86/platform/chromium/fast/forms/date: Removed. * platform/chromium-linux-x86/platform/chromium/fast/forms/date/date-suggestion-picker-appearance-rtl-expected.png: Removed. * platform/chromium-mac-snowleopard/platform/chromium/fast/forms/date/date-suggestion-picker-appearance-rtl-expected.png: * platform/chromium-mac/fast/repaint/block-selection-gap-in-composited-layer-expected.png: * platform/chromium-win-xp/platform/chromium/fast/forms/date: Removed. * platform/chromium-win-xp/platform/chromium/fast/forms/date/date-suggestion-picker-appearance-rtl-expected.png: Removed. * platform/chromium/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/TestExpectations trunk/LayoutTests/platform/chromium-mac/fast/repaint/block-selection-gap-in-composited-layer-expected.png trunk/LayoutTests/platform/chromium-mac-snowleopard/platform/chromium/fast/forms/date/date-suggestion-picker-appearance-rtl-expected.png Removed Paths trunk/LayoutTests/platform/chromium-linux-x86/fast/repaint/block-selection-gap-in-composited-layer-expected.png trunk/LayoutTests/platform/chromium-linux-x86/platform/chromium/fast/forms/date/ trunk/LayoutTests/platform/chromium-win-xp/platform/chromium/fast/forms/date/ Diff Modified: trunk/LayoutTests/ChangeLog (129766 => 129767) --- trunk/LayoutTests/ChangeLog 2012-09-27 15:26:23 UTC (rev 129766) +++ trunk/LayoutTests/ChangeLog 2012-09-27 15:42:02 UTC (rev 129767) @@ -1,3 +1,18 @@ +2012-09-27 Stephen Chenney schen...@chromium.org + +Unreviewed Chromium expectations + +Expectations that were lagging at the last rebaseline. + +* platform/chromium-linux-x86/fast/repaint/block-selection-gap-in-composited-layer-expected.png: Removed. +* platform/chromium-linux-x86/platform/chromium/fast/forms/date: Removed. +* platform/chromium-linux-x86/platform/chromium/fast/forms/date/date-suggestion-picker-appearance-rtl-expected.png: Removed. +* platform/chromium-mac-snowleopard/platform/chromium/fast/forms/date/date-suggestion-picker-appearance-rtl-expected.png: +* platform/chromium-mac/fast/repaint/block-selection-gap-in-composited-layer-expected.png: +* platform/chromium-win-xp/platform/chromium/fast/forms/date: Removed. +* platform/chromium-win-xp/platform/chromium/fast/forms/date/date-suggestion-picker-appearance-rtl-expected.png: Removed. +* platform/chromium/TestExpectations: + 2012-09-27 Kangil Han kangil@samsung.com [EFL][WK2][WTR] Unskip two jQuery test cases. Modified: trunk/LayoutTests/platform/chromium/TestExpectations (129766 => 129767) --- trunk/LayoutTests/platform/chromium/TestExpectations 2012-09-27 15:26:23 UTC (rev 129766) +++ trunk/LayoutTests/platform/chromium/TestExpectations 2012-09-27 15:42:02 UTC (rev 129767) @@ -3506,7 +3506,7 @@ webkit.org/b/95588 [ Mac ] fast/dom/shadow/shadowdom-for-textarea-complex-shadow.html [ ImageOnlyFailure ] -webkit.org/b/97558 [ Win Linux ] platform/chromium/fast/forms/date/date-suggestion-picker-appearance-rtl.html [ ImageOnlyFailure ] +webkit.org/b/97558 [ Linux Win7 ] platform/chromium/fast/forms/date/date-suggestion-picker-appearance-rtl.html [ ImageOnlyFailure ] webkit.org/b/95070 [ Win Release ] inspector/styles/media-queries.html [ Failure Pass ] Deleted: trunk/LayoutTests/platform/chromium-linux-x86/fast/repaint/block-selection-gap-in-composited-layer-expected.png (Binary files differ) Modified: trunk/LayoutTests/platform/chromium-mac/fast/repaint/block-selection-gap-in-composited-layer-expected.png (Binary files differ) Modified: trunk/LayoutTests/platform/chromium-mac-snowleopard/platform/chromium/fast/forms/date/date-suggestion-picker-appearance-rtl-expected.png (Binary files differ) ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [129768] trunk/LayoutTests
Title: [129768] trunk/LayoutTests Revision 129768 Author o...@webkit.org Date 2012-09-27 08:54:06 -0700 (Thu, 27 Sep 2012) Log Message [Qt] fast/profiler/apply.html fails with LLInt on 32 bit https://bugs.webkit.org/show_bug.cgi?id=97791 Unreviewed gardening, skip the new failing test to paint the bots green. * platform/qt/Skipped: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/qt/Skipped Diff Modified: trunk/LayoutTests/ChangeLog (129767 => 129768) --- trunk/LayoutTests/ChangeLog 2012-09-27 15:42:02 UTC (rev 129767) +++ trunk/LayoutTests/ChangeLog 2012-09-27 15:54:06 UTC (rev 129768) @@ -1,3 +1,12 @@ +2012-09-27 Csaba Osztrogonác o...@webkit.org + +[Qt] fast/profiler/apply.html fails with LLInt on 32 bit +https://bugs.webkit.org/show_bug.cgi?id=97791 + +Unreviewed gardening, skip the new failing test to paint the bots green. + +* platform/qt/Skipped: + 2012-09-27 Stephen Chenney schen...@chromium.org Unreviewed Chromium expectations Modified: trunk/LayoutTests/platform/qt/Skipped (129767 => 129768) --- trunk/LayoutTests/platform/qt/Skipped 2012-09-27 15:42:02 UTC (rev 129767) +++ trunk/LayoutTests/platform/qt/Skipped 2012-09-27 15:54:06 UTC (rev 129768) @@ -2789,3 +2789,7 @@ # [Qt] New test introduced in r129346 inspector-protocol/css-getSupportedCSSProperties.html fails # https://bugs.webkit.org/show_bug.cgi?id=97451 inspector-protocol/css-getSupportedCSSProperties.html + +# [Qt] fast/profiler/apply.html fails with LLInt on 32 bit +# https://bugs.webkit.org/show_bug.cgi?id=97791 +fast/profiler/apply.html ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [129769] trunk/Source/WebCore
Title: [129769] trunk/Source/WebCore
Revision 129769
Author a...@chromium.org
Date 2012-09-27 09:06:48 -0700 (Thu, 27 Sep 2012)
Log Message
Remove unused regular expressions from IDLStructure.pm
https://bugs.webkit.org/show_bug.cgi?id=97790
Reviewed by Kentaro Hara.
After http://trac.webkit.org/changeset/129723 these regular expressions are no longer used.
No new tests, run-binding-tests generates the same output.
* bindings/scripts/IDLStructure.pm:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/scripts/IDLStructure.pm
Diff
Modified: trunk/Source/WebCore/ChangeLog (129768 => 129769)
--- trunk/Source/WebCore/ChangeLog 2012-09-27 15:54:06 UTC (rev 129768)
+++ trunk/Source/WebCore/ChangeLog 2012-09-27 16:06:48 UTC (rev 129769)
@@ -1,3 +1,16 @@
+2012-09-27 Erik Arvidsson a...@chromium.org
+
+Remove unused regular expressions from IDLStructure.pm
+https://bugs.webkit.org/show_bug.cgi?id=97790
+
+Reviewed by Kentaro Hara.
+
+After http://trac.webkit.org/changeset/129723 these regular expressions are no longer used.
+
+No new tests, run-binding-tests generates the same output.
+
+* bindings/scripts/IDLStructure.pm:
+
2012-09-27 Tommy Widenflycht tom...@google.com
MediaStream API: Enhance MediaConstraints to make it easier to get the constraint data
Modified: trunk/Source/WebCore/bindings/scripts/IDLStructure.pm (129768 => 129769)
--- trunk/Source/WebCore/bindings/scripts/IDLStructure.pm 2012-09-27 15:54:06 UTC (rev 129768)
+++ trunk/Source/WebCore/bindings/scripts/IDLStructure.pm 2012-09-27 16:06:48 UTC (rev 129769)
@@ -78,39 +78,4 @@
extendedAttributes = '$', # Extended attributes
});
-# Helpers
-our $idlId = '[a-zA-Z0-9]';# Generic identifier
-our $idlIdNs = '[a-zA-Z0-9:]'; # Generic identifier including namespace
-our $idlIdNsList = '[a-zA-Z0-9:,\ ]'; # List of Generic identifiers including namespace
-
-our $idlType = '[a-zA-Z0-9_]'; # Generic type/value string identifier
-# Match a string value, a hexadecimal number, or an integral number.
-# Note: some of the characters that are allowed in the string value may not be allowed by
-# interfaceSelector.
-our $constValue = '([^\r\n]*)|(0[xX][a-fA-F0-9]+)|(-?[0-9]*)';
-our $idlDataType = '[a-zA-Z0-9\ ]'; # Generic data type identifier
-
-# Magic IDL parsing regular expressions
-my $supportedTypes = ((?:(?:unsigned )?(?:int|short|(?:long )?long)|(?:$idlIdNs*))(?:\\[\\]|(?:$idlIdNsList*))?);
-my $supportedTypeSuffix = (\\?)?;
-
-# Special IDL notations. This regular _expression_ extracts the string between the first [ and its corresponding ].
-our $extendedAttributeSyntax = qr/\[[^\[\]]*(?:(??{$IDLStructure::extendedAttributeSyntax})[^\[\]]*)*\]/x; # Used for extended attributes
-
-# Regular _expression_ based IDL 'syntactical tokenizer' used in the IDLParser
-our $moduleSelector = 'module\s*(' . $idlId . '*)\s*{';
-our $moduleNSSelector = 'module\s*(' . $idlId . '*)\s*\[ns\s*(' . $idlIdNs . '*)\s*(' . $idlIdNs . '*)\]\s*;';
-our $constantSelector = '(' . $extendedAttributeSyntax . ' )?const\s+' . $supportedTypes . '\s*(' . $idlType . '*)\s*=\s*(' . $constValue . ')';
-our $raisesSelector = 'raises\s*\((' . $idlIdNsList . '*)\s*\)';
-our $getterRaisesSelector = '\bgetter\s+raises\s*\((' . $idlIdNsList . '*)\s*\)';
-our $setterRaisesSelector = '\bsetter\s+raises\s*\((' . $idlIdNsList . '*)\s*\)';
-
-our $typeNamespaceSelector = '((?:' . $idlId . '*::)*)\s*(' . $idlDataType . '*)';
-
-our $interfaceSelector = '(interface|exception)\s*((?:' . $extendedAttributeSyntax . ' )?)(' . $idlIdNs . '*)\s*(?::(\s*[^{]*))?{([-a-zA-Z0-9_=\s(),;:\[\]\|?]*)';
-our $interfaceMethodSelector = '\s*((?:' . $extendedAttributeSyntax . ' )?)(static\s+)?' . $supportedTypes . '\s*(' . $idlIdNs . '*)\s*\(\s*([a-zA-Z0-9:\s,=\[\]?]*)';
-our $interfaceParameterSelector = '(in|out)\s*((?:' . $extendedAttributeSyntax . ' )?)' . $supportedTypes . $supportedTypeSuffix . '\s*(' . $idlIdNs . '*)';
-
-our $interfaceAttributeSelector = '\s*(static\s+)?(readonly attribute|attribute)\s*(' . $extendedAttributeSyntax . ' )?' . $supportedTypes . '\s*(' . $idlType . '*)';
-
1;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [129770] trunk/Source/WebKit/chromium
Title: [129770] trunk/Source/WebKit/chromium
Revision 129770
Author commit-qu...@webkit.org
Date 2012-09-27 09:22:47 -0700 (Thu, 27 Sep 2012)
Log Message
Unreviewed. Rolled DEPS.
Patch by Sheriff Bot webkit.review@gmail.com on 2012-09-27
* DEPS:
Modified Paths
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/DEPS
Diff
Modified: trunk/Source/WebKit/chromium/ChangeLog (129769 => 129770)
--- trunk/Source/WebKit/chromium/ChangeLog 2012-09-27 16:06:48 UTC (rev 129769)
+++ trunk/Source/WebKit/chromium/ChangeLog 2012-09-27 16:22:47 UTC (rev 129770)
@@ -1,3 +1,9 @@
+2012-09-27 Sheriff Bot webkit.review@gmail.com
+
+Unreviewed. Rolled DEPS.
+
+* DEPS:
+
2012-09-27 Ilya Tikhonovsky loi...@chromium.org
Web Inspector: NMI: move visited and countObjectSize methods implementation into separate class.
Modified: trunk/Source/WebKit/chromium/DEPS (129769 => 129770)
--- trunk/Source/WebKit/chromium/DEPS 2012-09-27 16:06:48 UTC (rev 129769)
+++ trunk/Source/WebKit/chromium/DEPS 2012-09-27 16:22:47 UTC (rev 129770)
@@ -32,7 +32,7 @@
vars = {
'chromium_svn': 'http://src.chromium.org/svn/trunk/src',
- 'chromium_rev': '158657'
+ 'chromium_rev': '159019'
}
deps = {
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [129771] trunk/Source/WebCore
Title: [129771] trunk/Source/WebCore
Revision 129771
Author mk...@chromium.org
Date 2012-09-27 09:58:22 -0700 (Thu, 27 Sep 2012)
Log Message
Dropping JSC references from InspectorInstrumentation.h by including 'ScriptState.h'
https://bugs.webkit.org/show_bug.cgi?id=97759
Reviewed by Adam Barth.
InspectorInstrumentation.h includes two '#if USE(JSC)' blocks, which
I've been reliably informed should not appear in WebCore[1]. This patch
drops both blocks, and includes 'ScriptState.h' instead, which should
have the same practical effect.
There's no functional change, so this should be covered by existing tests.
[1]: https://bugs.webkit.org/show_bug.cgi?id=94433#c55
* inspector/InspectorInstrumentation.h:
(WebCore):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/InspectorInstrumentation.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (129770 => 129771)
--- trunk/Source/WebCore/ChangeLog 2012-09-27 16:22:47 UTC (rev 129770)
+++ trunk/Source/WebCore/ChangeLog 2012-09-27 16:58:22 UTC (rev 129771)
@@ -1,3 +1,22 @@
+2012-09-27 Mike West mk...@chromium.org
+
+Dropping JSC references from InspectorInstrumentation.h by including 'ScriptState.h'
+https://bugs.webkit.org/show_bug.cgi?id=97759
+
+Reviewed by Adam Barth.
+
+InspectorInstrumentation.h includes two '#if USE(JSC)' blocks, which
+I've been reliably informed should not appear in WebCore[1]. This patch
+drops both blocks, and includes 'ScriptState.h' instead, which should
+have the same practical effect.
+
+There's no functional change, so this should be covered by existing tests.
+
+[1]: https://bugs.webkit.org/show_bug.cgi?id=94433#c55
+
+* inspector/InspectorInstrumentation.h:
+(WebCore):
+
2012-09-27 Erik Arvidsson a...@chromium.org
Remove unused regular expressions from IDLStructure.pm
Modified: trunk/Source/WebCore/inspector/InspectorInstrumentation.h (129770 => 129771)
--- trunk/Source/WebCore/inspector/InspectorInstrumentation.h 2012-09-27 16:22:47 UTC (rev 129770)
+++ trunk/Source/WebCore/inspector/InspectorInstrumentation.h 2012-09-27 16:58:22 UTC (rev 129771)
@@ -37,14 +37,9 @@
#include Frame.h
#include Page.h
#include ScriptExecutionContext.h
+#include ScriptState.h
#include StorageArea.h
-#if USE(JSC)
-namespace JSC {
-class ExecState;
-}
-#endif
-
namespace WebCore {
class CSSRule;
@@ -82,12 +77,6 @@
class WorkerContextProxy;
class XMLHttpRequest;
-#if USE(JSC)
-typedef JSC::ExecState ScriptState;
-#else
-class ScriptState;
-#endif
-
#if ENABLE(WEB_SOCKETS)
struct WebSocketFrame;
class WebSocketHandshakeRequest;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [129772] trunk/Source/WebKit/chromium
Title: [129772] trunk/Source/WebKit/chromium Revision 129772 Author ca...@chromium.org Date 2012-09-27 10:01:58 -0700 (Thu, 27 Sep 2012) Log Message Page overlays are not updated when WebView is resized https://bugs.webkit.org/show_bug.cgi?id=97789 Reviewed by Vsevolod Vlasov. Invalidate page overlays when view is resized. * src/WebViewImpl.cpp: (WebKit::WebViewImpl::sendResizeEventAndRepaint): Modified Paths trunk/Source/WebKit/chromium/ChangeLog trunk/Source/WebKit/chromium/src/WebViewImpl.cpp Diff Modified: trunk/Source/WebKit/chromium/ChangeLog (129771 => 129772) --- trunk/Source/WebKit/chromium/ChangeLog 2012-09-27 16:58:22 UTC (rev 129771) +++ trunk/Source/WebKit/chromium/ChangeLog 2012-09-27 17:01:58 UTC (rev 129772) @@ -1,3 +1,15 @@ +2012-09-27 Andrey Kosyakov ca...@chromium.org + +Page overlays are not updated when WebView is resized +https://bugs.webkit.org/show_bug.cgi?id=97789 + +Reviewed by Vsevolod Vlasov. + +Invalidate page overlays when view is resized. + +* src/WebViewImpl.cpp: +(WebKit::WebViewImpl::sendResizeEventAndRepaint): + 2012-09-27 Sheriff Bot webkit.review@gmail.com Unreviewed. Rolled DEPS. Modified: trunk/Source/WebKit/chromium/src/WebViewImpl.cpp (129771 => 129772) --- trunk/Source/WebKit/chromium/src/WebViewImpl.cpp 2012-09-27 16:58:22 UTC (rev 129771) +++ trunk/Source/WebKit/chromium/src/WebViewImpl.cpp 2012-09-27 17:01:58 UTC (rev 129772) @@ -3161,6 +3161,8 @@ m_client-didInvalidateRect(damagedRect); } } +if (m_pageOverlays) +m_pageOverlays-update(); } void WebViewImpl::configureAutoResizeMode() ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [129773] trunk/Source/JavaScriptCore
Title: [129773] trunk/Source/_javascript_Core
Revision 129773
Author kl...@webkit.org
Date 2012-09-27 10:04:40 -0700 (Thu, 27 Sep 2012)
Log Message
3.20MB below FunctionParameters::create() on Membuster3.
http://webkit.org/b/97730
Reviewed by Anders Carlsson.
Figure out the exact space needed for parameter identifiers and use reserveInitialCapacity().
Reduces memory consumption on Membuster3 by ~1.60 MB.
* parser/Nodes.cpp:
(JSC::FunctionParameters::FunctionParameters):
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/parser/Nodes.cpp
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (129772 => 129773)
--- trunk/Source/_javascript_Core/ChangeLog 2012-09-27 17:01:58 UTC (rev 129772)
+++ trunk/Source/_javascript_Core/ChangeLog 2012-09-27 17:04:40 UTC (rev 129773)
@@ -1,3 +1,16 @@
+2012-09-27 Andreas Kling kl...@webkit.org
+
+3.20MB below FunctionParameters::create() on Membuster3.
+http://webkit.org/b/97730
+
+Reviewed by Anders Carlsson.
+
+Figure out the exact space needed for parameter identifiers and use reserveInitialCapacity().
+Reduces memory consumption on Membuster3 by ~1.60 MB.
+
+* parser/Nodes.cpp:
+(JSC::FunctionParameters::FunctionParameters):
+
2012-09-27 Csaba Osztrogonác o...@webkit.org, Tor Arne Vestbø ves...@webkit.org
[Qt] Enable the LLInt on Linux
Modified: trunk/Source/_javascript_Core/parser/Nodes.cpp (129772 => 129773)
--- trunk/Source/_javascript_Core/parser/Nodes.cpp 2012-09-27 17:01:58 UTC (rev 129772)
+++ trunk/Source/_javascript_Core/parser/Nodes.cpp 2012-09-27 17:04:40 UTC (rev 129773)
@@ -153,8 +153,14 @@
FunctionParameters::FunctionParameters(ParameterNode* firstParameter)
{
+unsigned parameterCount = 0;
for (ParameterNode* parameter = firstParameter; parameter; parameter = parameter-nextParam())
-append(parameter-ident());
+++parameterCount;
+
+reserveInitialCapacity(parameterCount);
+
+for (ParameterNode* parameter = firstParameter; parameter; parameter = parameter-nextParam())
+uncheckedAppend(parameter-ident());
}
inline FunctionBodyNode::FunctionBodyNode(JSGlobalData* globalData, const JSTokenLocation location, bool inStrictContext)
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [129774] trunk/Source/JavaScriptCore
Title: [129774] trunk/Source/_javascript_Core
Revision 129774
Author par...@webkit.org
Date 2012-09-27 10:09:02 -0700 (Thu, 27 Sep 2012)
Log Message
Fix usage of COMPILER() macros
https://bugs.webkit.org/show_bug.cgi?id=97642
Reviewed by Geoffrey Garen.
Add COMPILER(GCC) around compiler specific code and remove it from generic code.
This allows us to implement the DFG code for other compilers to in a next step.
* dfg/DFGOperations.cpp:
* jit/HostCallReturnValue.h:
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/dfg/DFGOperations.cpp
trunk/Source/_javascript_Core/jit/HostCallReturnValue.h
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (129773 => 129774)
--- trunk/Source/_javascript_Core/ChangeLog 2012-09-27 17:04:40 UTC (rev 129773)
+++ trunk/Source/_javascript_Core/ChangeLog 2012-09-27 17:09:02 UTC (rev 129774)
@@ -1,3 +1,16 @@
+2012-09-27 Patrick Gansterer par...@webkit.org
+
+Fix usage of COMPILER() macros
+https://bugs.webkit.org/show_bug.cgi?id=97642
+
+Reviewed by Geoffrey Garen.
+
+Add COMPILER(GCC) around compiler specific code and remove it from generic code.
+This allows us to implement the DFG code for other compilers to in a next step.
+
+* dfg/DFGOperations.cpp:
+* jit/HostCallReturnValue.h:
+
2012-09-27 Andreas Kling kl...@webkit.org
3.20MB below FunctionParameters::create() on Membuster3.
Modified: trunk/Source/_javascript_Core/dfg/DFGOperations.cpp (129773 => 129774)
--- trunk/Source/_javascript_Core/dfg/DFGOperations.cpp 2012-09-27 17:04:40 UTC (rev 129773)
+++ trunk/Source/_javascript_Core/dfg/DFGOperations.cpp 2012-09-27 17:09:02 UTC (rev 129774)
@@ -49,7 +49,7 @@
#if ENABLE(DFG_JIT)
-#if CPU(X86_64)
+#if COMPILER(GCC) CPU(X86_64)
#define FUNCTION_WRAPPER_WITH_RETURN_ADDRESS(function, register) \
asm( \
@@ -64,7 +64,7 @@
#define FUNCTION_WRAPPER_WITH_RETURN_ADDRESS_EJI(function) FUNCTION_WRAPPER_WITH_RETURN_ADDRESS(function, rcx)
#define FUNCTION_WRAPPER_WITH_RETURN_ADDRESS_EJCI(function) FUNCTION_WRAPPER_WITH_RETURN_ADDRESS(function, r8)
-#elif CPU(X86)
+#elif COMPILER(GCC) CPU(X86)
#define FUNCTION_WRAPPER_WITH_RETURN_ADDRESS(function, offset) \
asm( \
@@ -1425,11 +1425,9 @@
#endif // ENABLE(DFG_JIT)
-#if COMPILER(GCC)
-
namespace JSC {
-#if CPU(X86_64)
+#if COMPILER(GCC) CPU(X86_64)
asm (
.globl SYMBOL_STRING(getHostCallReturnValue) \n
HIDE_SYMBOL(getHostCallReturnValue) \n
@@ -1438,7 +1436,7 @@
mov %r13, %rdi\n
jmp LOCAL_REFERENCE(getHostCallReturnValueWithExecState) \n
);
-#elif CPU(X86)
+#elif COMPILER(GCC) CPU(X86)
asm (
.text \n \
.globl SYMBOL_STRING(getHostCallReturnValue) \n
@@ -1448,7 +1446,7 @@
mov %edi, 4(%esp)\n
jmp LOCAL_REFERENCE(getHostCallReturnValueWithExecState) \n
);
-#elif CPU(ARM_THUMB2)
+#elif COMPILER(GCC) CPU(ARM_THUMB2)
asm (
.text \n
.align 2 \n
@@ -1461,7 +1459,7 @@
mov r0, r5 \n
b LOCAL_REFERENCE(getHostCallReturnValueWithExecState) \n
);
-#elif CPU(ARM_TRADITIONAL)
+#elif COMPILER(GCC) CPU(ARM_TRADITIONAL)
asm (
.text \n
.globl SYMBOL_STRING(getHostCallReturnValue) \n
@@ -1483,6 +1481,4 @@
} // namespace JSC
-#endif // COMPILER(GCC)
-
#endif // ENABLE(JIT)
Modified: trunk/Source/_javascript_Core/jit/HostCallReturnValue.h (129773 => 129774)
--- trunk/Source/_javascript_Core/jit/HostCallReturnValue.h 2012-09-27 17:04:40 UTC (rev 129773)
+++ trunk/Source/_javascript_Core/jit/HostCallReturnValue.h 2012-09-27 17:09:02 UTC (rev 129774)
@@ -30,10 +30,7 @@
#include MacroAssemblerCodeRef.h
#include wtf/Platform.h
-// Unfortunately this only works on GCC-like compilers. And it's currently only used
-// by LLInt and DFG, which also are restricted to GCC-like compilers. We should
-// probably fix that at some point.
-#if COMPILER(GCC) ENABLE(JIT)
+#if ENABLE(JIT)
#if CALLING_CONVENTION_IS_STDCALL
#define HOST_CALL_RETURN_VALUE_OPTION CDECL
@@ -45,6 +42,8 @@
extern C EncodedJSValue HOST_CALL_RETURN_VALUE_OPTION getHostCallReturnValue() REFERENCED_FROM_ASM WTF_INTERNAL;
+#if COMPILER(GCC)
+
// This is a public declaration only to convince CLANG not to elide it.
extern C EncodedJSValue HOST_CALL_RETURN_VALUE_OPTION getHostCallReturnValueWithExecState(ExecState*) REFERENCED_FROM_ASM WTF_INTERNAL;
@@ -53,15 +52,14 @@
getHostCallReturnValueWithExecState(0);
}
-}
-
#else // COMPILER(GCC)
-namespace JSC {
inline void initializeHostCallReturnValue() { }
-}
#endif // COMPILER(GCC)
-#endif // HostCallReturnValue_h
+} // namespace JSC
+#endif // ENABLE(JIT)
+
+#endif // HostCallReturnValue_h
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [129775] trunk/Source/WebCore
Title: [129775] trunk/Source/WebCore
Revision 129775
Author vse...@chromium.org
Date 2012-09-27 10:09:38 -0700 (Thu, 27 Sep 2012)
Log Message
Web Inspector: [REGRESSION] Breakpoints are not always shown in breakpoints sidebar pane.
https://bugs.webkit.org/show_bug.cgi?id=97783
Reviewed by Pavel Feldman.
BreakpointSidebarPane now explicitly adds all breakpoints that are available at the moment of its creation.
* inspector/front-end/BreakpointManager.js:
(WebInspector.BreakpointManager.prototype._filteredBreakpointLocations):
(WebInspector.BreakpointManager.prototype.breakpointLocationsForUISourceCode):
(WebInspector.BreakpointManager.prototype.allBreakpointLocations):
* inspector/front-end/BreakpointsSidebarPane.js:
(WebInspector._javascript_BreakpointsSidebarPane):
(WebInspector._javascript_BreakpointsSidebarPane.prototype._breakpointAdded):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/BreakpointManager.js
trunk/Source/WebCore/inspector/front-end/BreakpointsSidebarPane.js
Diff
Modified: trunk/Source/WebCore/ChangeLog (129774 => 129775)
--- trunk/Source/WebCore/ChangeLog 2012-09-27 17:09:02 UTC (rev 129774)
+++ trunk/Source/WebCore/ChangeLog 2012-09-27 17:09:38 UTC (rev 129775)
@@ -1,3 +1,20 @@
+2012-09-27 Vsevolod Vlasov vse...@chromium.org
+
+Web Inspector: [REGRESSION] Breakpoints are not always shown in breakpoints sidebar pane.
+https://bugs.webkit.org/show_bug.cgi?id=97783
+
+Reviewed by Pavel Feldman.
+
+BreakpointSidebarPane now explicitly adds all breakpoints that are available at the moment of its creation.
+
+* inspector/front-end/BreakpointManager.js:
+(WebInspector.BreakpointManager.prototype._filteredBreakpointLocations):
+(WebInspector.BreakpointManager.prototype.breakpointLocationsForUISourceCode):
+(WebInspector.BreakpointManager.prototype.allBreakpointLocations):
+* inspector/front-end/BreakpointsSidebarPane.js:
+(WebInspector._javascript_BreakpointsSidebarPane):
+(WebInspector._javascript_BreakpointsSidebarPane.prototype._breakpointAdded):
+
2012-09-27 Mike West mk...@chromium.org
Dropping JSC references from InspectorInstrumentation.h by including 'ScriptState.h'
Modified: trunk/Source/WebCore/inspector/front-end/BreakpointManager.js (129774 => 129775)
--- trunk/Source/WebCore/inspector/front-end/BreakpointManager.js 2012-09-27 17:09:02 UTC (rev 129774)
+++ trunk/Source/WebCore/inspector/front-end/BreakpointManager.js 2012-09-27 17:09:38 UTC (rev 129775)
@@ -133,17 +133,17 @@
},
/**
- * @param {WebInspector.UISourceCode} uiSourceCode
- * @return {Array.Object}
+ * @param {function(WebInspector.BreakpointManager.Breakpoint, WebInspector.UILocation)} filter
+ * @return {Array.{breakpoint: WebInspector.BreakpointManager.Breakpoint, uiLocation: WebInspector.UILocation}}
*/
-breakpointLocationsForUISourceCode: function(uiSourceCode)
+_filteredBreakpointLocations: function(filter)
{
var result = [];
for (var i = 0; i this._breakpoints.length; ++i) {
var breakpoint = this._breakpoints[i];
for (var stringifiedLocation in breakpoint._uiLocations) {
var uiLocation = breakpoint._uiLocations[stringifiedLocation];
-if (uiLocation.uiSourceCode === uiSourceCode)
+if (filter(breakpoint, uiLocation))
result.push({breakpoint: breakpoint, uiLocation: uiLocation});
}
}
@@ -151,6 +151,28 @@
},
/**
+ * @param {WebInspector.UISourceCode} uiSourceCode
+ * @return {Array.{breakpoint: WebInspector.BreakpointManager.Breakpoint, uiLocation: WebInspector.UILocation}}
+ */
+breakpointLocationsForUISourceCode: function(uiSourceCode)
+{
+function filter(breakpoint, uiLocation)
+{
+return uiLocation.uiSourceCode === uiSourceCode;
+}
+
+return this._filteredBreakpointLocations(filter);
+},
+
+/**
+ * @return {Array.{breakpoint: WebInspector.BreakpointManager.Breakpoint, uiLocation: WebInspector.UILocation}}
+ */
+allBreakpointLocations: function()
+{
+return this._filteredBreakpointLocations(function(breakpoint, uiLocation) { return true; });
+},
+
+/**
* @param {boolean} toggleState
*/
toggleAllBreakpoints: function(toggleState)
Modified: trunk/Source/WebCore/inspector/front-end/BreakpointsSidebarPane.js (129774 => 129775)
--- trunk/Source/WebCore/inspector/front-end/BreakpointsSidebarPane.js 2012-09-27 17:09:02 UTC (rev 129774)
+++ trunk/Source/WebCore/inspector/front-end/BreakpointsSidebarPane.js 2012-09-27 17:09:38 UTC (rev 129775)
@@ -45,6 +45,11 @@
this.bodyElement.appendChild(this.emptyElement);
this._items = new Map();
+
+var breakpointLocations = this._breakpointManager.allBreakpointLocations();
+
[webkit-changes] [129776] trunk/Source/WebCore
Title: [129776] trunk/Source/WebCore
Revision 129776
Author kl...@webkit.org
Date 2012-09-27 10:23:11 -0700 (Thu, 27 Sep 2012)
Log Message
332kB below DocumentEventQueue::create() on Membuster3.
http://webkit.org/b/97712
Reviewed by Anders Carlsson.
Give DocumentEventQueue::m_queuedEvents an inline capacity of 16 (the default is 256.)
312kB progression on Membuster3.
* dom/DocumentEventQueue.h:
* dom/DocumentEventQueue.cpp:
(WebCore::DocumentEventQueue::pendingEventTimerFired):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/DocumentEventQueue.cpp
trunk/Source/WebCore/dom/DocumentEventQueue.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (129775 => 129776)
--- trunk/Source/WebCore/ChangeLog 2012-09-27 17:09:38 UTC (rev 129775)
+++ trunk/Source/WebCore/ChangeLog 2012-09-27 17:23:11 UTC (rev 129776)
@@ -1,3 +1,17 @@
+2012-09-27 Andreas Kling kl...@webkit.org
+
+332kB below DocumentEventQueue::create() on Membuster3.
+http://webkit.org/b/97712
+
+Reviewed by Anders Carlsson.
+
+Give DocumentEventQueue::m_queuedEvents an inline capacity of 16 (the default is 256.)
+312kB progression on Membuster3.
+
+* dom/DocumentEventQueue.h:
+* dom/DocumentEventQueue.cpp:
+(WebCore::DocumentEventQueue::pendingEventTimerFired):
+
2012-09-27 Vsevolod Vlasov vse...@chromium.org
Web Inspector: [REGRESSION] Breakpoints are not always shown in breakpoints sidebar pane.
Modified: trunk/Source/WebCore/dom/DocumentEventQueue.cpp (129775 => 129776)
--- trunk/Source/WebCore/dom/DocumentEventQueue.cpp 2012-09-27 17:09:38 UTC (rev 129775)
+++ trunk/Source/WebCore/dom/DocumentEventQueue.cpp 2012-09-27 17:23:11 UTC (rev 129776)
@@ -148,7 +148,7 @@
RefPtrDocumentEventQueue protector(this);
while (!m_queuedEvents.isEmpty()) {
-ListHashSetRefPtrEvent ::iterator iter = m_queuedEvents.begin();
+ListHashSetRefPtrEvent, 16::iterator iter = m_queuedEvents.begin();
RefPtrEvent event = *iter;
m_queuedEvents.remove(iter);
if (!event)
Modified: trunk/Source/WebCore/dom/DocumentEventQueue.h (129775 => 129776)
--- trunk/Source/WebCore/dom/DocumentEventQueue.h 2012-09-27 17:09:38 UTC (rev 129775)
+++ trunk/Source/WebCore/dom/DocumentEventQueue.h 2012-09-27 17:23:11 UTC (rev 129776)
@@ -68,7 +68,7 @@
void dispatchEvent(PassRefPtrEvent);
OwnPtrDocumentEventQueueTimer m_pendingEventTimer;
-ListHashSetRefPtrEvent m_queuedEvents;
+ListHashSetRefPtrEvent, 16 m_queuedEvents;
HashSetNode* m_nodesWithQueuedScrollEvents;
bool m_isClosed;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [129780] trunk/Source/WTF
Title: [129780] trunk/Source/WTF
Revision 129780
Author mhahnenb...@apple.com
Date 2012-09-27 11:30:40 -0700 (Thu, 27 Sep 2012)
Log Message
Clean up HasTrivialConstructor/Destructor
https://bugs.webkit.org/show_bug.cgi?id=97754
Reviewed by Darin Adler.
Cleaned up HasTrivialConstructor and HasTrivialDestructor by defining them in terms of
other type traits we have. Also moved some ifdefs and comments to make things more clear.
* wtf/TypeTraits.h:
Modified Paths
trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/TypeTraits.h
Diff
Modified: trunk/Source/WTF/ChangeLog (129779 => 129780)
--- trunk/Source/WTF/ChangeLog 2012-09-27 18:05:28 UTC (rev 129779)
+++ trunk/Source/WTF/ChangeLog 2012-09-27 18:30:40 UTC (rev 129780)
@@ -1,3 +1,15 @@
+2012-09-26 Mark Hahnenberg mhahnenb...@apple.com
+
+Clean up HasTrivialConstructor/Destructor
+https://bugs.webkit.org/show_bug.cgi?id=97754
+
+Reviewed by Darin Adler.
+
+Cleaned up HasTrivialConstructor and HasTrivialDestructor by defining them in terms of
+other type traits we have. Also moved some ifdefs and comments to make things more clear.
+
+* wtf/TypeTraits.h:
+
2012-09-27 Ilya Tikhonovsky loi...@chromium.org
Web Inspector: NMI: move visited and countObjectSize methods implementation into separate class.
Modified: trunk/Source/WTF/wtf/TypeTraits.h (129779 => 129780)
--- trunk/Source/WTF/wtf/TypeTraits.h 2012-09-27 18:05:28 UTC (rev 129779)
+++ trunk/Source/WTF/wtf/TypeTraits.h 2012-09-27 18:30:40 UTC (rev 129780)
@@ -228,208 +228,34 @@
::Type Type;
};
-#if (defined(__GLIBCXX__) (__GLIBCXX__ = 20070724) defined(__GXX_EXPERIMENTAL_CXX0X__)) || (defined(_MSC_VER) (_MSC_VER = 1600))
-
+#if COMPILER(CLANG) || GCC_VERSION_AT_LEAST(4, 6, 0) || (defined(_MSC_VER) (_MSC_VER = 1400) !defined(__INTEL_COMPILER))
+// VC8 (VS2005) and later has __has_trivial_constructor and __has_trivial_destructor,
+// but the implementation returns false for built-in types. We add the extra IsPod condition to
+// work around this.
+template typename T struct HasTrivialConstructor {
+static const bool value = __has_trivial_constructor(T) || IsPodRemoveConstVolatileT ::value;
+};
+template typename T struct HasTrivialDestructor {
+static const bool value = __has_trivial_destructor(T) || IsPodRemoveConstVolatileT ::value;
+};
+#elif (defined(__GLIBCXX__) (__GLIBCXX__ = 20070724) defined(__GXX_EXPERIMENTAL_CXX0X__)) || (defined(_MSC_VER) (_MSC_VER = 1600))
// GCC's libstdc++ 20070724 and later supports C++ TR1 type_traits in the std namespace.
// VC10 (VS2010) and later support C++ TR1 type_traits in the std::tr1 namespace.
templatetypename T struct HasTrivialConstructor : public std::tr1::has_trivial_constructorT { };
templatetypename T struct HasTrivialDestructor : public std::tr1::has_trivial_destructorT { };
-
#else
-
-// This compiler doesn't provide type traits, so we provide basic HasTrivialConstructor
-// and HasTrivialDestructor definitions. The definitions here include most built-in
-// scalar types but do not include POD structs and classes. For the intended purposes of
-// type_traits this results correct but potentially less efficient code.
-template typename T, T v
-struct IntegralConstant {
-static const T value = v;
-typedef T value_type;
-typedef IntegralConstantT, v type;
+// For compilers that don't support detection of trivial constructors and destructors in classes,
+// we use a template that returns true for any POD type that IsPod can detect (see IsPod caveats above),
+// but false for all other types (which includes all classes). This will give false negatives, which can hurt
+// performance, but avoids false positives, which would result in incorrect behavior.
+template typename T struct HasTrivialConstructor {
+static const bool value = IsPodRemoveConstVolatileT ::value;
};
-
-typedef IntegralConstantbool, true true_type;
-typedef IntegralConstantbool, false false_type;
-
-#if COMPILER(CLANG) || (defined(_MSC_VER) (_MSC_VER = 1400) !defined(__INTEL_COMPILER))
-// VC8 (VS2005) and later have built-in compiler support for HasTrivialConstructor / HasTrivialDestructor,
-// but for some unexplained reason it doesn't work on built-in types.
-template typename T struct HasTrivialConstructor : public IntegralConstantbool, __has_trivial_constructor(T){ };
-template typename T struct HasTrivialDestructor : public IntegralConstantbool, __has_trivial_destructor(T){ };
-#else
-template typename T struct HasTrivialConstructor : public false_type{ };
-template typename T struct HasTrivialDestructor : public false_type{ };
+template typename T struct HasTrivialDestructor {
+static const bool value = IsPodRemoveConstVolatileT ::value;
+};
#endif
-template typename T struct
[webkit-changes] [129781] trunk/Source/WebCore
Title: [129781] trunk/Source/WebCore
Revision 129781
Author ad...@chromium.org
Date 2012-09-27 11:35:13 -0700 (Thu, 27 Sep 2012)
Log Message
Simplify and clarify MutationObserverRegistration interface and usage
https://bugs.webkit.org/show_bug.cgi?id=97742
Reviewed by Ojan Vafai.
Minor cleanups in MutationObserverRegistration: make const methods explicitly const,
use C++ templates to avoid duplicating logic, improve usage of raw pointers vs PassRefPtr,
remove the declaration of a no-longer-existing method.
No change in behavior.
* dom/MutationObserverRegistration.cpp:
(WebCore::MutationObserverRegistration::observedSubtreeNodeWillDetach): Take a raw pointer because we don't always ref the node.
(WebCore::MutationObserverRegistration::shouldReceiveMutationFrom): Make this a const method.
* dom/MutationObserverRegistration.h:
(MutationObserverRegistration): Removed declaration of non-existent caseInsensitiveAttributeFilter method.
(WebCore::MutationObserverRegistration::hasTransientRegistrations): const method.
(WebCore::MutationObserverRegistration::isSubtree): Remove superfluous inline keyword.
(WebCore::MutationObserverRegistration::observer): const method.
* dom/Node.cpp:
(WebCore):
(WebCore::collectMatchingObserversForMutation): Add a templatized function to reduce duplicated code.
(WebCore::Node::getRegisteredMutationObserversOfType):
(WebCore::Node::registerMutationObserver): Take a raw pointer because we don't always ref the observer.
* dom/Node.h:
(Node): Remove old method, replaced by templatized static function.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/MutationObserverRegistration.cpp
trunk/Source/WebCore/dom/MutationObserverRegistration.h
trunk/Source/WebCore/dom/Node.cpp
trunk/Source/WebCore/dom/Node.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (129780 => 129781)
--- trunk/Source/WebCore/ChangeLog 2012-09-27 18:30:40 UTC (rev 129780)
+++ trunk/Source/WebCore/ChangeLog 2012-09-27 18:35:13 UTC (rev 129781)
@@ -1,3 +1,32 @@
+2012-09-27 Adam Klein ad...@chromium.org
+
+Simplify and clarify MutationObserverRegistration interface and usage
+https://bugs.webkit.org/show_bug.cgi?id=97742
+
+Reviewed by Ojan Vafai.
+
+Minor cleanups in MutationObserverRegistration: make const methods explicitly const,
+use C++ templates to avoid duplicating logic, improve usage of raw pointers vs PassRefPtr,
+remove the declaration of a no-longer-existing method.
+
+No change in behavior.
+
+* dom/MutationObserverRegistration.cpp:
+(WebCore::MutationObserverRegistration::observedSubtreeNodeWillDetach): Take a raw pointer because we don't always ref the node.
+(WebCore::MutationObserverRegistration::shouldReceiveMutationFrom): Make this a const method.
+* dom/MutationObserverRegistration.h:
+(MutationObserverRegistration): Removed declaration of non-existent caseInsensitiveAttributeFilter method.
+(WebCore::MutationObserverRegistration::hasTransientRegistrations): const method.
+(WebCore::MutationObserverRegistration::isSubtree): Remove superfluous inline keyword.
+(WebCore::MutationObserverRegistration::observer): const method.
+* dom/Node.cpp:
+(WebCore):
+(WebCore::collectMatchingObserversForMutation): Add a templatized function to reduce duplicated code.
+(WebCore::Node::getRegisteredMutationObserversOfType):
+(WebCore::Node::registerMutationObserver): Take a raw pointer because we don't always ref the observer.
+* dom/Node.h:
+(Node): Remove old method, replaced by templatized static function.
+
2012-09-27 Erik Arvidsson a...@chromium.org
DOM4: Add support for rest parameters to DOMTokenList
Modified: trunk/Source/WebCore/dom/MutationObserverRegistration.cpp (129780 => 129781)
--- trunk/Source/WebCore/dom/MutationObserverRegistration.cpp 2012-09-27 18:30:40 UTC (rev 129780)
+++ trunk/Source/WebCore/dom/MutationObserverRegistration.cpp 2012-09-27 18:35:13 UTC (rev 129781)
@@ -66,7 +66,7 @@
m_attributeFilter = attributeFilter;
}
-void MutationObserverRegistration::observedSubtreeNodeWillDetach(PassRefPtrNode node)
+void MutationObserverRegistration::observedSubtreeNodeWillDetach(Node* node)
{
if (!isSubtree())
return;
@@ -105,7 +105,7 @@
// The above line will cause this object to be deleted, so don't do any more in this function.
}
-bool MutationObserverRegistration::shouldReceiveMutationFrom(Node* node, MutationObserver::MutationType type, const QualifiedName* attributeName)
+bool MutationObserverRegistration::shouldReceiveMutationFrom(Node* node, MutationObserver::MutationType type, const QualifiedName* attributeName) const
{
ASSERT((type == MutationObserver::Attributes attributeName) || !attributeName);
if (!(m_options type))
Modified: trunk/Source/WebCore/dom/MutationObserverRegistration.h (129780 => 129781)
---
[webkit-changes] [129782] trunk/Source/WebKit2
Title: [129782] trunk/Source/WebKit2
Revision 129782
Author kbal...@webkit.org
Date 2012-09-27 11:41:39 -0700 (Thu, 27 Sep 2012)
Log Message
[Qt][WK2] REGRESSION(r128980): It broke all QRawWebView API test
https://bugs.webkit.org/show_bug.cgi?id=97561
Reviewed by Noam Rosenthal.
Make sure we always send the very first RenderNextFrame message.
Before r128980 it was working accidentally because in the common
case the web process sent a DeleteCompositingLayer message at some
point before the forced repaint would time out and we was sending
the first RenderNextFrame when reacting to that.
* UIProcess/API/qt/raw/qrawwebview.cpp:
(QRawWebView::setActive): Set the LayerTreeRenderer to active
as well. In the QQuickWebView case it is handled by the QtWebPageSGNode.
(QRawWebView::layerTreeRenderer): Added a convenience getter
for the LayerTreeRenderer.
(QRawWebView::paint):
* UIProcess/API/qt/raw/qrawwebview_p.h:
(WebKit):
* UIProcess/API/qt/tests/qrawwebview/tst_qrawwebview.cpp:
(tst_qrawwebview::tst_qrawwebview): Added a call to addQtWebProcessToPath
to make my and the follower users of this test easier.
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/qt/raw/qrawwebview.cpp
trunk/Source/WebKit2/UIProcess/API/qt/raw/qrawwebview_p.h
trunk/Source/WebKit2/UIProcess/API/qt/tests/qrawwebview/tst_qrawwebview.cpp
Diff
Modified: trunk/Source/WebKit2/ChangeLog (129781 => 129782)
--- trunk/Source/WebKit2/ChangeLog 2012-09-27 18:35:13 UTC (rev 129781)
+++ trunk/Source/WebKit2/ChangeLog 2012-09-27 18:41:39 UTC (rev 129782)
@@ -1,3 +1,28 @@
+2012-09-27 Balazs Kelemen kbal...@webkit.org
+
+[Qt][WK2] REGRESSION(r128980): It broke all QRawWebView API test
+https://bugs.webkit.org/show_bug.cgi?id=97561
+
+Reviewed by Noam Rosenthal.
+
+Make sure we always send the very first RenderNextFrame message.
+Before r128980 it was working accidentally because in the common
+case the web process sent a DeleteCompositingLayer message at some
+point before the forced repaint would time out and we was sending
+the first RenderNextFrame when reacting to that.
+
+* UIProcess/API/qt/raw/qrawwebview.cpp:
+(QRawWebView::setActive): Set the LayerTreeRenderer to active
+as well. In the QQuickWebView case it is handled by the QtWebPageSGNode.
+(QRawWebView::layerTreeRenderer): Added a convenience getter
+for the LayerTreeRenderer.
+(QRawWebView::paint):
+* UIProcess/API/qt/raw/qrawwebview_p.h:
+(WebKit):
+* UIProcess/API/qt/tests/qrawwebview/tst_qrawwebview.cpp:
+(tst_qrawwebview::tst_qrawwebview): Added a call to addQtWebProcessToPath
+to make my and the follower users of this test easier.
+
2012-09-27 Eunmi Lee eunmi15@samsung.com
[EFL][WK2] Process touch events using mouse and multi events of Evas.
Modified: trunk/Source/WebKit2/UIProcess/API/qt/raw/qrawwebview.cpp (129781 => 129782)
--- trunk/Source/WebKit2/UIProcess/API/qt/raw/qrawwebview.cpp 2012-09-27 18:35:13 UTC (rev 129781)
+++ trunk/Source/WebKit2/UIProcess/API/qt/raw/qrawwebview.cpp 2012-09-27 18:41:39 UTC (rev 129782)
@@ -319,6 +319,7 @@
{
d-m_active = active;
d-m_webPageProxy-viewStateDidChange(WebKit::WebPageProxy::ViewWindowIsActive);
+layerTreeRenderer()-setActive(active);
}
QSize QRawWebView::size() const
@@ -352,17 +353,20 @@
return toAPI(d-m_webPageProxy.get());
}
-void QRawWebView::paint(const QMatrix4x4 transform, float opacity, unsigned paintFlags)
+WebKit::LayerTreeRenderer* QRawWebView::layerTreeRenderer() const
{
WebKit::DrawingAreaProxy* drawingArea = d-m_webPageProxy-drawingArea();
if (!drawingArea)
-return;
+return 0;
+WebKit::LayerTreeCoordinatorProxy* layerTreeCoordinatorProxy = drawingArea-layerTreeCoordinatorProxy();
+if (!layerTreeCoordinatorProxy)
+return 0;
+return layerTreeCoordinatorProxy-layerTreeRenderer();
+}
-WebKit::LayerTreeCoordinatorProxy* coordinatorProxy = drawingArea-layerTreeCoordinatorProxy();
-if (!coordinatorProxy)
-return;
-
-WebKit::LayerTreeRenderer* renderer = coordinatorProxy-layerTreeRenderer();
+void QRawWebView::paint(const QMatrix4x4 transform, float opacity, unsigned paintFlags)
+{
+WebKit::LayerTreeRenderer* renderer = layerTreeRenderer();
if (!renderer)
return;
Modified: trunk/Source/WebKit2/UIProcess/API/qt/raw/qrawwebview_p.h (129781 => 129782)
--- trunk/Source/WebKit2/UIProcess/API/qt/raw/qrawwebview_p.h 2012-09-27 18:35:13 UTC (rev 129781)
+++ trunk/Source/WebKit2/UIProcess/API/qt/raw/qrawwebview_p.h 2012-09-27 18:41:39 UTC (rev 129782)
@@ -47,6 +47,10 @@
class QRawWebViewPrivate;
+namespace WebKit {
+class LayerTreeRenderer;
+}
+
class QRawWebViewClient {
public:
virtual ~QRawWebViewClient() { }
@@ -97,6 +101,8 @@
void sendTouchEvent(QTouchEvent*);
private:
+
[webkit-changes] [129783] trunk
Title: [129783] trunk Revision 129783 Author wangxian...@chromium.org Date 2012-09-27 11:47:43 -0700 (Thu, 27 Sep 2012) Log Message [Chromium-Android] Push more fonts for layout tests to match chromium-linux https://bugs.webkit.org/show_bug.cgi?id=97746 Tools: Reviewed by Dirk Pranke. * DumpRenderTree/chromium/android_fallback_fonts.xml: Added the new fonts into fallback list. Removed the Android system fallback font DroidSansFallback.ttf. * Scripts/webkitpy/layout_tests/port/builders.py: Add chromium-android to pass style check. * Scripts/webkitpy/layout_tests/port/chromium_android.py: (ChromiumAndroidPort.check_build): Added check for md5sum and forwarder utilities to give better error message when they are missing. (ChromiumAndroidPort.check_sys_deps): Allow host font files to come from one of multiple directories. (ChromiumAndroidPort._path_to_md5sum): (ChromiumAndroidDriver._setup_md5sum_and_push_data_if_needed): (ChromiumAndroidDriver._push_fonts): (ChromiumAndroidDriver._push_test_resources): LayoutTests: Some original rebaselines will be unnecessary after this change. Checked some rebaselines of chromium-android under fast/text, but there should be more. Leave them to gardening. Reviewed by Dirk Pranke. * platform/chromium-android/TestExpectations: Enabled some skipped tests because now we have the fonts. * platform/chromium-android/fast/text/complex-text-opacity-expected.txt: Removed. No more need rebaselining. * platform/chromium-android/fast/text/international/hindi-spacing-expected.txt: Removed. No more need rebaselining. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium-android/TestExpectations trunk/Tools/ChangeLog trunk/Tools/DumpRenderTree/chromium/android_fallback_fonts.xml trunk/Tools/Scripts/webkitpy/layout_tests/port/builders.py trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_android.py Removed Paths trunk/LayoutTests/platform/chromium-android/fast/text/complex-text-opacity-expected.txt trunk/LayoutTests/platform/chromium-android/fast/text/international/hindi-spacing-expected.txt Diff Modified: trunk/LayoutTests/ChangeLog (129782 => 129783) --- trunk/LayoutTests/ChangeLog 2012-09-27 18:41:39 UTC (rev 129782) +++ trunk/LayoutTests/ChangeLog 2012-09-27 18:47:43 UTC (rev 129783) @@ -1,3 +1,18 @@ +2012-09-27 Xianzhu Wang wangxian...@chromium.org + +[Chromium-Android] Push more fonts for layout tests to match chromium-linux +https://bugs.webkit.org/show_bug.cgi?id=97746 + +Some original rebaselines will be unnecessary after this change. +Checked some rebaselines of chromium-android under fast/text, +but there should be more. Leave them to gardening. + +Reviewed by Dirk Pranke. + +* platform/chromium-android/TestExpectations: Enabled some skipped tests because now we have the fonts. +* platform/chromium-android/fast/text/complex-text-opacity-expected.txt: Removed. No more need rebaselining. +* platform/chromium-android/fast/text/international/hindi-spacing-expected.txt: Removed. No more need rebaselining. + 2012-09-27 Erik Arvidsson a...@chromium.org DOM4: Add support for rest parameters to DOMTokenList Modified: trunk/LayoutTests/platform/chromium-android/TestExpectations (129782 => 129783) --- trunk/LayoutTests/platform/chromium-android/TestExpectations 2012-09-27 18:41:39 UTC (rev 129782) +++ trunk/LayoutTests/platform/chromium-android/TestExpectations 2012-09-27 18:47:43 UTC (rev 129783) @@ -1,7 +1,7 @@ # This file should contain only the rules to skip tests about the features not supported # or not testable on Android. # -# Other rules should be in TestExpectations. +# Other rules should be in platform/chromium/TestExpectations. # Skip tests of other platforms to save time. platform/gtk [ WontFix ] @@ -72,16 +72,9 @@ # Causes server error. Not feasible to fix because this is a behavior of Apache server. webkit.org/b/95378 fast/encoding/percent-escaping.html [ WontFix ] -# Tests depending on Bengali, Tamil, Danda fonts -webkit.org/b/95378 fast/text/international/bold-bengali.html [ WontFix ] -webkit.org/b/95378 fast/text/international/complex-character-based-fallback.html [ WontFix ] - # The test creates a temporary file via HTTP POST and access the file as a blob. This is unfeasible. webkit.org/b/95378 http/tests/local/fileapi/send-sliced-dragged-file.html [ WontFix ] # The test depends on the same modified time returned from local file api and PHP. This is unfeasible. webkit.org/b/95378 http/tests/local/fileapi/file-last-modified.html [ WontFix ] -# Android font lacks some plane2 CJK glyphs to pass this test. -webkit.org/b/95378 fast/text/international/plane2.html [ WontFix ] - Deleted: trunk/LayoutTests/platform/chromium-android/fast/text/complex-text-opacity-expected.txt (129782 => 129783) --- trunk/LayoutTests/platform/chromium-android/fast/text/complex-text-opacity-expected.txt 2012-09-27 18:41:39 UTC (rev
[webkit-changes] [129784] trunk/Tools
Title: [129784] trunk/Tools Revision 129784 Author dpra...@chromium.org Date 2012-09-27 12:00:15 -0700 (Thu, 27 Sep 2012) Log Message webkitpy: make warning about missing BUG identifiers per-port configurable https://bugs.webkit.org/show_bug.cgi?id=97751 Reviewed by Ojan Vafai. Prior to this change linting TestExpectations files (checking their style) would raise warnings if lines were missing a BUG modifier, even though such a modifier is actually optional in the syntax. As we migrate the entries over from the Skipped files, these warnings will generate a lot of noise, and it's not yet clear that we actually want to require the modifiers on all ports. So, this change makes this per-port configurable so that they will generate warnings in the Chromium TestExpectations and not anywhere else. * Scripts/webkitpy/layout_tests/models/test_expectations.py: (TestExpectationParser._parse_modifiers): * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: (MiscTests.test_parse_warning): (SemanticTests.test_missing_bugid): * Scripts/webkitpy/layout_tests/port/base.py: (Port.warn_if_bug_missing_in_test_expectations): * Scripts/webkitpy/layout_tests/port/chromium.py: (ChromiumPort.warn_if_bug_missing_in_test_expectations): Modified Paths trunk/Tools/ChangeLog trunk/Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py trunk/Tools/Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py trunk/Tools/Scripts/webkitpy/layout_tests/port/base.py trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium.py Diff Modified: trunk/Tools/ChangeLog (129783 => 129784) --- trunk/Tools/ChangeLog 2012-09-27 18:47:43 UTC (rev 129783) +++ trunk/Tools/ChangeLog 2012-09-27 19:00:15 UTC (rev 129784) @@ -1,3 +1,31 @@ +2012-09-27 Dirk Pranke dpra...@chromium.org + +webkitpy: make warning about missing BUG identifiers per-port configurable +https://bugs.webkit.org/show_bug.cgi?id=97751 + +Reviewed by Ojan Vafai. + +Prior to this change linting TestExpectations files (checking their style) +would raise warnings if lines were missing a BUG modifier, even +though such a modifier is actually optional in the syntax. As we +migrate the entries over from the Skipped files, these warnings +will generate a lot of noise, and it's not yet clear that we +actually want to require the modifiers on all ports. + +So, this change makes this per-port configurable so that they +will generate warnings in the Chromium TestExpectations and not +anywhere else. + +* Scripts/webkitpy/layout_tests/models/test_expectations.py: +(TestExpectationParser._parse_modifiers): +* Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: +(MiscTests.test_parse_warning): +(SemanticTests.test_missing_bugid): +* Scripts/webkitpy/layout_tests/port/base.py: +(Port.warn_if_bug_missing_in_test_expectations): +* Scripts/webkitpy/layout_tests/port/chromium.py: +(ChromiumPort.warn_if_bug_missing_in_test_expectations): + 2012-09-27 Xianzhu Wang wangxian...@chromium.org [Chromium-Android] Push more fonts for layout tests to match chromium-linux Modified: trunk/Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py (129783 => 129784) --- trunk/Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py 2012-09-27 18:47:43 UTC (rev 129783) +++ trunk/Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py 2012-09-27 19:00:15 UTC (rev 129784) @@ -155,7 +155,7 @@ else: parsed_specifiers.add(modifier) -if not expectation_line.parsed_bug_modifiers and not has_wontfix and not has_bugid: +if not expectation_line.parsed_bug_modifiers and not has_wontfix and not has_bugid and self._port.warn_if_bug_missing_in_test_expectations(): expectation_line.warnings.append(self.MISSING_BUG_WARNING) if self._allow_rebaseline_modifier and self.REBASELINE_MODIFIER in modifiers: Modified: trunk/Tools/Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py (129783 => 129784) --- trunk/Tools/Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py 2012-09-27 18:47:43 UTC (rev 129783) +++ trunk/Tools/Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py 2012-09-27 19:00:15 UTC (rev 129784) @@ -179,8 +179,7 @@ Bug(rniwa) disabled-test.html-disabled [ ImageOnlyFailure ], is_lint_mode=True) self.assertFalse(True, ParseError wasn't raised) except ParseError, e: -warnings = (expectations:1 Test lacks BUG modifier. failures/expected/text.html\n -expectations:1 Unrecognized modifier 'foo' failures/expected/text.html\n +warnings = (expectations:1 Unrecognized modifier 'foo' failures/expected/text.html\n expectations:2 Path does not exist.
[webkit-changes] [129785] trunk/Source/WebCore
Title: [129785] trunk/Source/WebCore
Revision 129785
Author schen...@chromium.org
Date 2012-09-27 12:03:31 -0700 (Thu, 27 Sep 2012)
Log Message
Unreviewed Chromium debug build fix.
ASSERT contains an inequality of unmatched types. A cast should do the trick.
* bindings/v8/V8Binding.h:
(WebCore::toNativeArguments):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/v8/V8Binding.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (129784 => 129785)
--- trunk/Source/WebCore/ChangeLog 2012-09-27 19:00:15 UTC (rev 129784)
+++ trunk/Source/WebCore/ChangeLog 2012-09-27 19:03:31 UTC (rev 129785)
@@ -1,3 +1,12 @@
+2012-09-27 Stephen Chenney schen...@chromium.org
+
+Unreviewed Chromium debug build fix.
+
+ASSERT contains an inequality of unmatched types. A cast should do the trick.
+
+* bindings/v8/V8Binding.h:
+(WebCore::toNativeArguments):
+
2012-09-27 Adam Klein ad...@chromium.org
Simplify and clarify MutationObserverRegistration interface and usage
Modified: trunk/Source/WebCore/bindings/v8/V8Binding.h (129784 => 129785)
--- trunk/Source/WebCore/bindings/v8/V8Binding.h 2012-09-27 19:00:15 UTC (rev 129784)
+++ trunk/Source/WebCore/bindings/v8/V8Binding.h 2012-09-27 19:03:31 UTC (rev 129785)
@@ -224,7 +224,7 @@
template class T
VectorT toNativeArguments(const v8::Arguments args, size_t startIndex)
{
-ASSERT(startIndex = args.Length());
+ASSERT(startIndex = static_castsize_t(args.Length()));
VectorT result;
typedef NativeValueTraitsT TraitsType;
size_t length = args.Length();
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [129786] trunk/Source/WebCore
Title: [129786] trunk/Source/WebCore
Revision 129786
Author msab...@apple.com
Date 2012-09-27 12:04:59 -0700 (Thu, 27 Sep 2012)
Log Message
ApplicationCacheStorage does not optimally handle 8 bit strings
https://bugs.webkit.org/show_bug.cgi?id=97733
Reviewed by Alexey Proskuryakov.
Added 8 bit string paths.
No functional change, therefore no new tests.
* loader/appcache/ApplicationCacheStorage.cpp:
(WebCore::urlHostHash):
(WebCore::ApplicationCacheStorage::store):
(WebCore::parseHeader):
(WebCore::parseHeaders):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/loader/appcache/ApplicationCacheStorage.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (129785 => 129786)
--- trunk/Source/WebCore/ChangeLog 2012-09-27 19:03:31 UTC (rev 129785)
+++ trunk/Source/WebCore/ChangeLog 2012-09-27 19:04:59 UTC (rev 129786)
@@ -1,3 +1,20 @@
+2012-09-27 Michael Saboff msab...@apple.com
+
+ApplicationCacheStorage does not optimally handle 8 bit strings
+https://bugs.webkit.org/show_bug.cgi?id=97733
+
+Reviewed by Alexey Proskuryakov.
+
+Added 8 bit string paths.
+
+No functional change, therefore no new tests.
+
+* loader/appcache/ApplicationCacheStorage.cpp:
+(WebCore::urlHostHash):
+(WebCore::ApplicationCacheStorage::store):
+(WebCore::parseHeader):
+(WebCore::parseHeaders):
+
2012-09-27 Stephen Chenney schen...@chromium.org
Unreviewed Chromium debug build fix.
Modified: trunk/Source/WebCore/loader/appcache/ApplicationCacheStorage.cpp (129785 => 129786)
--- trunk/Source/WebCore/loader/appcache/ApplicationCacheStorage.cpp 2012-09-27 19:03:31 UTC (rev 129785)
+++ trunk/Source/WebCore/loader/appcache/ApplicationCacheStorage.cpp 2012-09-27 19:04:59 UTC (rev 129786)
@@ -91,8 +91,13 @@
{
unsigned hostStart = url.hostStart();
unsigned hostEnd = url.hostEnd();
+
+const String urlString = url.string();
+
+if (urlString.is8Bit())
+return AlreadyHashed::avoidDeletedValue(StringHasher::computeHashAndMaskTop8Bits(urlString.characters8() + hostStart, hostEnd - hostStart));
-return AlreadyHashed::avoidDeletedValue(StringHasher::computeHashAndMaskTop8Bits(url.string().characters() + hostStart, hostEnd - hostStart));
+return AlreadyHashed::avoidDeletedValue(StringHasher::computeHashAndMaskTop8Bits(urlString.characters16() + hostStart, hostEnd - hostStart));
}
ApplicationCacheGroup* ApplicationCacheStorage::loadCacheGroup(const KURL manifestURL)
@@ -840,9 +845,9 @@
HTTPHeaderMap::const_iterator end = resource-response().httpHeaderFields().end();
for (HTTPHeaderMap::const_iterator it = resource-response().httpHeaderFields().begin(); it!= end; ++it) {
stringBuilder.append(it-first);
-stringBuilder.append((UChar)':');
+stringBuilder.append(':');
stringBuilder.append(it-second);
-stringBuilder.append((UChar)'\n');
+stringBuilder.append('\n');
}
String headers = stringBuilder.toString();
@@ -1052,7 +1057,8 @@
return storeNewestCache(group, 0, ignoredFailureReason);
}
-static inline void parseHeader(const UChar* header, size_t headerLength, ResourceResponse response)
+template typename CharacterType
+static inline void parseHeader(const CharacterType* header, size_t headerLength, ResourceResponse response)
{
size_t pos = find(header, headerLength, ':');
ASSERT(pos != notFound);
@@ -1070,13 +1076,20 @@
while ((endPos = headers.find('\n', startPos)) != notFound) {
ASSERT(startPos != endPos);
-parseHeader(headers.characters() + startPos, endPos - startPos, response);
+if (headers.is8Bit())
+parseHeader(headers.characters8() + startPos, endPos - startPos, response);
+else
+parseHeader(headers.characters16() + startPos, endPos - startPos, response);
startPos = endPos + 1;
}
-if (startPos != headers.length())
-parseHeader(headers.characters(), headers.length(), response);
+if (startPos != headers.length()) {
+if (headers.is8Bit())
+parseHeader(headers.characters8(), headers.length(), response);
+else
+parseHeader(headers.characters16(), headers.length(), response);
+}
}
PassRefPtrApplicationCache ApplicationCacheStorage::loadCache(unsigned storageID)
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [129787] trunk/Source/WebCore
Title: [129787] trunk/Source/WebCore Revision 129787 Author commit-qu...@webkit.org Date 2012-09-27 12:23:40 -0700 (Thu, 27 Sep 2012) Log Message [CSS Exclusions] Rename RenderStyle::wrapShapeInside/Outside to shapeInside/Outside https://bugs.webkit.org/show_bug.cgi?id=97707 Patch by Bear Travis betra...@adobe.com on 2012-09-27 Reviewed by Antti Koivisto. The exclusions specification has renamed wrap-shape-inside and wrap-shape-outside to shape-inside and shape-outside. We should rename the getter/setter functions in RenderStyle, and update the derived variable and function names accordingly. For more information, see: http://dev.w3.org/csswg/css3-exclusions/#declaring-shapes Covered by existing tests. No new functionality. * css/CSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): * css/StyleBuilder.cpp: (WebCore::ApplyPropertyExclusionShape::applyValue): (WebCore::StyleBuilder::StyleBuilder): * rendering/ExclusionShapeInsideInfo.cpp: (WebCore::ExclusionShapeInsideInfo::exclusionShapeInsideInfoForRenderBlock): (WebCore::ExclusionShapeInsideInfo::isExclusionShapeInsideInfoEnabledForRenderBlock): (WebCore::ExclusionShapeInsideInfo::removeExclusionShapeInsideInfoForRenderBlock): (WebCore::ExclusionShapeInsideInfo::computeShapeSize): * rendering/RenderBlock.cpp: (WebCore::RenderBlock::styleDidChange): (WebCore::RenderBlock::updateExclusionShapeInsideInfoAfterStyleChange): * rendering/RenderBlock.h: (WebCore::RenderBlock::exclusionShapeInsideInfo): * rendering/style/RenderStyle.cpp: (WebCore::RenderStyle::diff): * rendering/style/RenderStyle.h: * rendering/style/StyleRareNonInheritedData.cpp: (WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData): (WebCore::StyleRareNonInheritedData::operator==): (WebCore::StyleRareNonInheritedData::reportMemoryUsage): * rendering/style/StyleRareNonInheritedData.h: (StyleRareNonInheritedData): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/css/CSSComputedStyleDeclaration.cpp trunk/Source/WebCore/css/StyleBuilder.cpp trunk/Source/WebCore/rendering/ExclusionShapeInsideInfo.cpp trunk/Source/WebCore/rendering/RenderBlock.cpp trunk/Source/WebCore/rendering/RenderBlock.h trunk/Source/WebCore/rendering/style/RenderStyle.cpp trunk/Source/WebCore/rendering/style/RenderStyle.h trunk/Source/WebCore/rendering/style/StyleRareNonInheritedData.cpp trunk/Source/WebCore/rendering/style/StyleRareNonInheritedData.h Diff Modified: trunk/Source/WebCore/ChangeLog (129786 => 129787) --- trunk/Source/WebCore/ChangeLog 2012-09-27 19:04:59 UTC (rev 129786) +++ trunk/Source/WebCore/ChangeLog 2012-09-27 19:23:40 UTC (rev 129787) @@ -1,3 +1,42 @@ +2012-09-27 Bear Travis betra...@adobe.com + +[CSS Exclusions] Rename RenderStyle::wrapShapeInside/Outside to shapeInside/Outside +https://bugs.webkit.org/show_bug.cgi?id=97707 + +Reviewed by Antti Koivisto. + +The exclusions specification has renamed wrap-shape-inside and wrap-shape-outside +to shape-inside and shape-outside. We should rename the getter/setter functions +in RenderStyle, and update the derived variable and function names accordingly. +For more information, see: http://dev.w3.org/csswg/css3-exclusions/#declaring-shapes + +Covered by existing tests. No new functionality. + +* css/CSSComputedStyleDeclaration.cpp: +(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): +* css/StyleBuilder.cpp: +(WebCore::ApplyPropertyExclusionShape::applyValue): +(WebCore::StyleBuilder::StyleBuilder): +* rendering/ExclusionShapeInsideInfo.cpp: +(WebCore::ExclusionShapeInsideInfo::exclusionShapeInsideInfoForRenderBlock): +(WebCore::ExclusionShapeInsideInfo::isExclusionShapeInsideInfoEnabledForRenderBlock): +(WebCore::ExclusionShapeInsideInfo::removeExclusionShapeInsideInfoForRenderBlock): +(WebCore::ExclusionShapeInsideInfo::computeShapeSize): +* rendering/RenderBlock.cpp: +(WebCore::RenderBlock::styleDidChange): +(WebCore::RenderBlock::updateExclusionShapeInsideInfoAfterStyleChange): +* rendering/RenderBlock.h: +(WebCore::RenderBlock::exclusionShapeInsideInfo): +* rendering/style/RenderStyle.cpp: +(WebCore::RenderStyle::diff): +* rendering/style/RenderStyle.h: +* rendering/style/StyleRareNonInheritedData.cpp: +(WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData): +(WebCore::StyleRareNonInheritedData::operator==): +(WebCore::StyleRareNonInheritedData::reportMemoryUsage): +* rendering/style/StyleRareNonInheritedData.h: +(StyleRareNonInheritedData): + 2012-09-27 Michael Saboff msab...@apple.com ApplicationCacheStorage does not optimally handle 8 bit strings Modified: trunk/Source/WebCore/css/CSSComputedStyleDeclaration.cpp (129786 => 129787) ---
[webkit-changes] [129789] trunk/Source/WebKit2
Title: [129789] trunk/Source/WebKit2
Revision 129789
Author ma...@webkit.org
Date 2012-09-27 12:24:13 -0700 (Thu, 27 Sep 2012)
Log Message
[WK2] IconDatabase: Add a way to notify when icon data is available
https://bugs.webkit.org/show_bug.cgi?id=63945
Rubber stamped by Anders Carlsson.
Update version of WKIconDatabaseClient and API traits.
* Shared/APIClientTraits.cpp:
(WebKit):
* Shared/APIClientTraits.h:
* UIProcess/API/C/WKIconDatabase.h:
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/Shared/APIClientTraits.cpp
trunk/Source/WebKit2/Shared/APIClientTraits.h
trunk/Source/WebKit2/UIProcess/API/C/WKIconDatabase.h
Diff
Modified: trunk/Source/WebKit2/ChangeLog (129788 => 129789)
--- trunk/Source/WebKit2/ChangeLog 2012-09-27 19:24:09 UTC (rev 129788)
+++ trunk/Source/WebKit2/ChangeLog 2012-09-27 19:24:13 UTC (rev 129789)
@@ -1,3 +1,17 @@
+2012-09-27 Mario Sanchez Prada msanc...@igalia.com
+
+[WK2] IconDatabase: Add a way to notify when icon data is available
+https://bugs.webkit.org/show_bug.cgi?id=63945
+
+Rubber stamped by Anders Carlsson.
+
+Update version of WKIconDatabaseClient and API traits.
+
+* Shared/APIClientTraits.cpp:
+(WebKit):
+* Shared/APIClientTraits.h:
+* UIProcess/API/C/WKIconDatabase.h:
+
2012-09-27 Balazs Kelemen kbal...@webkit.org
[Qt][WK2] REGRESSION(r128980): It broke all QRawWebView API test
Modified: trunk/Source/WebKit2/Shared/APIClientTraits.cpp (129788 => 129789)
--- trunk/Source/WebKit2/Shared/APIClientTraits.cpp 2012-09-27 19:24:09 UTC (rev 129788)
+++ trunk/Source/WebKit2/Shared/APIClientTraits.cpp 2012-09-27 19:24:13 UTC (rev 129789)
@@ -86,4 +86,9 @@
sizeof(WKContextInjectedBundleClient)
};
+const size_t APIClientTraitsWKIconDatabaseClient::interfaceSizesByVersion[] = {
+offsetof(WKIconDatabaseClient, iconDataReadyForPageURL),
+sizeof(WKIconDatabaseClient)
+};
+
} // namespace WebKit
Modified: trunk/Source/WebKit2/Shared/APIClientTraits.h (129788 => 129789)
--- trunk/Source/WebKit2/Shared/APIClientTraits.h 2012-09-27 19:24:09 UTC (rev 129788)
+++ trunk/Source/WebKit2/Shared/APIClientTraits.h 2012-09-27 19:24:13 UTC (rev 129789)
@@ -29,6 +29,7 @@
#include WKBundle.h
#include WKBundlePage.h
#include WKContext.h
+#include WKIconDatabase.h
#include WKPage.h
namespace WebKit {
@@ -78,6 +79,10 @@
static const size_t interfaceSizesByVersion[2];
};
+template struct APIClientTraitsWKIconDatabaseClient {
+static const size_t interfaceSizesByVersion[2];
+};
+
} // namespace WebKit
#endif // APIClientTraits_h
Modified: trunk/Source/WebKit2/UIProcess/API/C/WKIconDatabase.h (129788 => 129789)
--- trunk/Source/WebKit2/UIProcess/API/C/WKIconDatabase.h 2012-09-27 19:24:09 UTC (rev 129788)
+++ trunk/Source/WebKit2/UIProcess/API/C/WKIconDatabase.h 2012-09-27 19:24:13 UTC (rev 129789)
@@ -40,13 +40,17 @@
struct WKIconDatabaseClient {
int version;
const void *clientInfo;
+
+// Version 0
WKIconDatabaseDidChangeIconForPageURLCallback didChangeIconForPageURL;
WKIconDatabaseDidRemoveAllIconsCallback didRemoveAllIcons;
+
+// Version 1
WKIconDatabaseIconDataReadyForPageURLCallback iconDataReadyForPageURL;
};
typedef struct WKIconDatabaseClient WKIconDatabaseClient;
-enum { kWKIconDatabaseClientCurrentVersion = 0 };
+enum { kWKIconDatabaseClientCurrentVersion = 1 };
WK_EXPORT WKTypeID WKIconDatabaseGetTypeID();
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [129790] trunk/Source/WebKit2
Title: [129790] trunk/Source/WebKit2
Revision 129790
Author ander...@apple.com
Date 2012-09-27 12:33:57 -0700 (Thu, 27 Sep 2012)
Log Message
Stop using dispatch_get_current_queue
https://bugs.webkit.org/show_bug.cgi?id=97806
rdar://problem/12379094
Reviewed by Mark Rowe.
* Platform/mac/WorkQueueMac.cpp:
(WorkQueueAndFunction::WorkQueueAndFunction):
(WorkQueueAndFunction):
(WorkQueue::executeFunction):
(WorkQueue::dispatch):
(WorkQueue::dispatchAfterDelay):
Keep track of the associated work queue so we can get it in WorkQueue::executeFunction.
* UIProcess/Launcher/mac/ProcessLauncherMac.mm:
(WebKit::setUpTerminationNotificationHandler):
We don't care about which queue the termination notification is delivered on since we only want to call
waitpid on the child pid so we can just use a global queue.
* UIProcess/mac/WebInspectorProxyMac.mm:
(-[WKWebInspectorProxyObjCAdapter inspectedViewFrameDidChange:]):
Use dispatch_get_main_queue here.
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/Platform/mac/WorkQueueMac.cpp
trunk/Source/WebKit2/UIProcess/Launcher/mac/ProcessLauncherMac.mm
trunk/Source/WebKit2/UIProcess/mac/WebInspectorProxyMac.mm
Diff
Modified: trunk/Source/WebKit2/ChangeLog (129789 => 129790)
--- trunk/Source/WebKit2/ChangeLog 2012-09-27 19:24:13 UTC (rev 129789)
+++ trunk/Source/WebKit2/ChangeLog 2012-09-27 19:33:57 UTC (rev 129790)
@@ -1,3 +1,28 @@
+2012-09-27 Anders Carlsson ander...@apple.com
+
+Stop using dispatch_get_current_queue
+https://bugs.webkit.org/show_bug.cgi?id=97806
+rdar://problem/12379094
+
+Reviewed by Mark Rowe.
+
+* Platform/mac/WorkQueueMac.cpp:
+(WorkQueueAndFunction::WorkQueueAndFunction):
+(WorkQueueAndFunction):
+(WorkQueue::executeFunction):
+(WorkQueue::dispatch):
+(WorkQueue::dispatchAfterDelay):
+Keep track of the associated work queue so we can get it in WorkQueue::executeFunction.
+
+* UIProcess/Launcher/mac/ProcessLauncherMac.mm:
+(WebKit::setUpTerminationNotificationHandler):
+We don't care about which queue the termination notification is delivered on since we only want to call
+waitpid on the child pid so we can just use a global queue.
+
+* UIProcess/mac/WebInspectorProxyMac.mm:
+(-[WKWebInspectorProxyObjCAdapter inspectedViewFrameDidChange:]):
+Use dispatch_get_main_queue here.
+
2012-09-27 Mario Sanchez Prada msanc...@igalia.com
[WK2] IconDatabase: Add a way to notify when icon data is available
Modified: trunk/Source/WebKit2/Platform/mac/WorkQueueMac.cpp (129789 => 129790)
--- trunk/Source/WebKit2/Platform/mac/WorkQueueMac.cpp 2012-09-27 19:24:13 UTC (rev 129789)
+++ trunk/Source/WebKit2/Platform/mac/WorkQueueMac.cpp 2012-09-27 19:33:57 UTC (rev 129790)
@@ -30,30 +30,39 @@
#include mach/mach_port.h
#include wtf/PassOwnPtr.h
+struct WorkQueueAndFunction {
+WorkQueueAndFunction(WorkQueue* workQueue, const Functionvoid() function)
+: workQueue(workQueue)
+, function(function)
+{
+}
+
+WorkQueue* workQueue;
+Functionvoid() function;
+};
+
void WorkQueue::executeFunction(void* context)
{
-WorkQueue* queue = static_castWorkQueue*(dispatch_get_context(dispatch_get_current_queue()));
-OwnPtrFunctionvoid() function = adoptPtr(static_castFunctionvoid()*(context));
+OwnPtrWorkQueueAndFunction workQueueAndFunction = adoptPtr(static_castWorkQueueAndFunction*(context));
{
-MutexLocker locker(queue-m_isValidMutex);
-if (!queue-m_isValid)
+MutexLocker locker(workQueueAndFunction-workQueue-m_isValidMutex);
+if (!workQueueAndFunction-workQueue-m_isValid)
return;
}
-(*function)();
+(workQueueAndFunction-function)();
}
void WorkQueue::dispatch(const Functionvoid() function)
{
-dispatch_async_f(m_dispatchQueue, new Functionvoid()(function), executeFunction);
+dispatch_async_f(m_dispatchQueue, new WorkQueueAndFunction(this, function), executeFunction);
}
void WorkQueue::dispatchAfterDelay(const Functionvoid() function, double delay)
{
dispatch_time_t delayTime = dispatch_time(DISPATCH_TIME_NOW, delay * NSEC_PER_SEC);
-
-dispatch_after_f(delayTime, m_dispatchQueue, new Functionvoid()(function), executeFunction);
+dispatch_after_f(delayTime, m_dispatchQueue, new WorkQueueAndFunction(this, function), executeFunction);
}
class WorkQueue::EventSource {
Modified: trunk/Source/WebKit2/UIProcess/Launcher/mac/ProcessLauncherMac.mm (129789 => 129790)
--- trunk/Source/WebKit2/UIProcess/Launcher/mac/ProcessLauncherMac.mm 2012-09-27 19:24:13 UTC (rev 129789)
+++ trunk/Source/WebKit2/UIProcess/Launcher/mac/ProcessLauncherMac.mm 2012-09-27 19:33:57 UTC (rev 129790)
@@ -82,7 +82,7 @@
static void setUpTerminationNotificationHandler(pid_t pid)
{
#if HAVE(DISPATCH_H)
-dispatch_source_t processDiedSource =
[webkit-changes] [129791] trunk/Source/WebKit2
Title: [129791] trunk/Source/WebKit2 Revision 129791 Author commit-qu...@webkit.org Date 2012-09-27 12:44:29 -0700 (Thu, 27 Sep 2012) Log Message [Cairo] Unnecessary creation of ShareableBitmap's for directly composited images https://bugs.webkit.org/show_bug.cgi?id=97745 Patch by Helder Correia helder.corr...@nokia.com on 2012-09-27 Reviewed by Martin Robinson. In LayerTreeCoordinator::adoptImageBackingStore(), there is a PLATFORM(QT) code path to check for identical images, but nothing is done for Cairo, which results in the occurrence of avoidable resource allocations. The issue happens in e.g. http://www.webkit.org/blog-files/leaves/, where there are many leaves flying around while they're produced out of only four bitmaps. This patch uses pointers to cairo_surface_t's as the key to the hashmap that caches bitmaps. This can be safely done since we own the references. We artificially increment the surface references in adoptImageBackingStore() and decrement them in releaseImageBackingStore(). * WebProcess/WebPage/CoordinatedGraphics/LayerTreeCoordinator.cpp: (WebKit::LayerTreeCoordinator::adoptImageBackingStore): (WebKit::LayerTreeCoordinator::releaseImageBackingStore): Modified Paths trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/LayerTreeCoordinator.cpp Diff Modified: trunk/Source/WebKit2/ChangeLog (129790 => 129791) --- trunk/Source/WebKit2/ChangeLog 2012-09-27 19:33:57 UTC (rev 129790) +++ trunk/Source/WebKit2/ChangeLog 2012-09-27 19:44:29 UTC (rev 129791) @@ -1,3 +1,28 @@ +2012-09-27 Helder Correia helder.corr...@nokia.com + +[Cairo] Unnecessary creation of ShareableBitmap's for directly composited images +https://bugs.webkit.org/show_bug.cgi?id=97745 + +Reviewed by Martin Robinson. + +In LayerTreeCoordinator::adoptImageBackingStore(), there is a +PLATFORM(QT) code path to check for identical images, but nothing is +done for Cairo, which results in the occurrence of avoidable resource +allocations. + +The issue happens in e.g. http://www.webkit.org/blog-files/leaves/, +where there are many leaves flying around while they're produced out of +only four bitmaps. + +This patch uses pointers to cairo_surface_t's as the key to the hashmap +that caches bitmaps. This can be safely done since we own the references. +We artificially increment the surface references in adoptImageBackingStore() +and decrement them in releaseImageBackingStore(). + +* WebProcess/WebPage/CoordinatedGraphics/LayerTreeCoordinator.cpp: +(WebKit::LayerTreeCoordinator::adoptImageBackingStore): +(WebKit::LayerTreeCoordinator::releaseImageBackingStore): + 2012-09-27 Anders Carlsson ander...@apple.com Stop using dispatch_get_current_queue Modified: trunk/Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/LayerTreeCoordinator.cpp (129790 => 129791) --- trunk/Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/LayerTreeCoordinator.cpp 2012-09-27 19:33:57 UTC (rev 129790) +++ trunk/Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/LayerTreeCoordinator.cpp 2012-09-27 19:44:29 UTC (rev 129791) @@ -454,6 +454,14 @@ return InvalidWebLayerID; key = nativeImage-cacheKey(); +#elif USE(CAIRO) +NativeImageCairo* nativeImage = image-nativeImageForCurrentFrame(); +if (!nativeImage) +return InvalidWebLayerID; +// This can be safely done since we own the reference. +// A corresponding cairo_surface_destroy() is ensured in releaseImageBackingStore(). +cairo_surface_t* cairoSurface = cairo_surface_reference(nativeImage-surface()); +key = reinterpret_castint64_t(cairoSurface); #endif HashMapint64_t, int::iterator it = m_directlyCompositedImageRefCounts.find(key); @@ -490,6 +498,11 @@ return; m_directlyCompositedImageRefCounts.remove(it); +#if USE(CAIRO) +// Complement the referencing in adoptImageBackingStore(). +cairo_surface_t* cairoSurface = reinterpret_castcairo_surface_t*(key); +cairo_surface_destroy(cairoSurface); +#endif m_webPage-send(Messages::LayerTreeCoordinatorProxy::DestroyDirectlyCompositedImage(key)); } ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [129792] trunk/Source
Title: [129792] trunk/Source Revision 129792 Author pilg...@chromium.org Date 2012-09-27 12:48:58 -0700 (Thu, 27 Sep 2012) Log Message [Chromium] Move UNIX-specific theme functions out of PlatformSupport https://bugs.webkit.org/show_bug.cgi?id=96516 Reviewed by Adam Barth. Call WebThemeEngine functions and use WebThemeEngine enums directly from the new Platform/ directly; remove all intermediate functions and enums and conversion functions from PlatformSupport. Part of a refactoring series; see tracking bug 82948. Source/WebCore: * WebCore.gyp/WebCore.gyp: * platform/chromium/PlatformSupport.h: (PlatformSupport): * platform/chromium/ScrollbarThemeChromiumLinux.cpp: (WebCore::ScrollbarThemeChromiumLinux::scrollbarThickness): (WebCore::ScrollbarThemeChromiumLinux::paintTrackPiece): (WebCore::ScrollbarThemeChromiumLinux::paintButton): (WebCore::ScrollbarThemeChromiumLinux::paintThumb): (WebCore::ScrollbarThemeChromiumLinux::buttonSize): (WebCore::ScrollbarThemeChromiumLinux::minimumThumbLength): * rendering/RenderThemeChromiumAndroid.cpp: (WebCore::RenderThemeChromiumAndroid::adjustInnerSpinButtonStyle): (WebCore::RenderThemeChromiumAndroid::menuListArrowPadding): * rendering/RenderThemeChromiumLinux.cpp: (WebCore::getWebThemeState): (WebCore): (WebCore::RenderThemeChromiumLinux::adjustSliderThumbSize): (WebCore::RenderThemeChromiumLinux::paintCheckbox): (WebCore::RenderThemeChromiumLinux::setCheckboxSize): (WebCore::RenderThemeChromiumLinux::paintRadio): (WebCore::RenderThemeChromiumLinux::setRadioSize): (WebCore::RenderThemeChromiumLinux::paintButton): (WebCore::RenderThemeChromiumLinux::paintTextField): (WebCore::RenderThemeChromiumLinux::paintMenuList): (WebCore::RenderThemeChromiumLinux::paintSliderTrack): (WebCore::RenderThemeChromiumLinux::paintSliderThumb): (WebCore::RenderThemeChromiumLinux::adjustInnerSpinButtonStyle): (WebCore::RenderThemeChromiumLinux::paintInnerSpinButton): (WebCore::RenderThemeChromiumLinux::paintProgressBar): Source/WebKit/chromium: * src/PlatformSupport.cpp: (WebCore): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/WebCore.gyp/WebCore.gyp trunk/Source/WebCore/platform/chromium/PlatformSupport.h trunk/Source/WebCore/platform/chromium/ScrollbarThemeChromiumLinux.cpp trunk/Source/WebCore/rendering/RenderThemeChromiumAndroid.cpp trunk/Source/WebCore/rendering/RenderThemeChromiumLinux.cpp trunk/Source/WebKit/chromium/ChangeLog trunk/Source/WebKit/chromium/src/PlatformSupport.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (129791 => 129792) --- trunk/Source/WebCore/ChangeLog 2012-09-27 19:44:29 UTC (rev 129791) +++ trunk/Source/WebCore/ChangeLog 2012-09-27 19:48:58 UTC (rev 129792) @@ -1,3 +1,46 @@ +2012-09-27 Mark Pilgrim pilg...@chromium.org + +[Chromium] Move UNIX-specific theme functions out of PlatformSupport +https://bugs.webkit.org/show_bug.cgi?id=96516 + +Reviewed by Adam Barth. + +Call WebThemeEngine functions and use WebThemeEngine enums +directly from the new Platform/ directly; remove all +intermediate functions and enums and conversion functions from +PlatformSupport. +Part of a refactoring series; see tracking bug 82948. + +* WebCore.gyp/WebCore.gyp: +* platform/chromium/PlatformSupport.h: +(PlatformSupport): +* platform/chromium/ScrollbarThemeChromiumLinux.cpp: +(WebCore::ScrollbarThemeChromiumLinux::scrollbarThickness): +(WebCore::ScrollbarThemeChromiumLinux::paintTrackPiece): +(WebCore::ScrollbarThemeChromiumLinux::paintButton): +(WebCore::ScrollbarThemeChromiumLinux::paintThumb): +(WebCore::ScrollbarThemeChromiumLinux::buttonSize): +(WebCore::ScrollbarThemeChromiumLinux::minimumThumbLength): +* rendering/RenderThemeChromiumAndroid.cpp: +(WebCore::RenderThemeChromiumAndroid::adjustInnerSpinButtonStyle): +(WebCore::RenderThemeChromiumAndroid::menuListArrowPadding): +* rendering/RenderThemeChromiumLinux.cpp: +(WebCore::getWebThemeState): +(WebCore): +(WebCore::RenderThemeChromiumLinux::adjustSliderThumbSize): +(WebCore::RenderThemeChromiumLinux::paintCheckbox): +(WebCore::RenderThemeChromiumLinux::setCheckboxSize): +(WebCore::RenderThemeChromiumLinux::paintRadio): +(WebCore::RenderThemeChromiumLinux::setRadioSize): +(WebCore::RenderThemeChromiumLinux::paintButton): +(WebCore::RenderThemeChromiumLinux::paintTextField): +(WebCore::RenderThemeChromiumLinux::paintMenuList): +(WebCore::RenderThemeChromiumLinux::paintSliderTrack): +(WebCore::RenderThemeChromiumLinux::paintSliderThumb): +(WebCore::RenderThemeChromiumLinux::adjustInnerSpinButtonStyle): +(WebCore::RenderThemeChromiumLinux::paintInnerSpinButton): +(WebCore::RenderThemeChromiumLinux::paintProgressBar): + 2012-09-27 Bear Travis betra...@adobe.com [CSS
[webkit-changes] [129793] trunk/LayoutTests
Title: [129793] trunk/LayoutTests Revision 129793 Author schen...@chromium.org Date 2012-09-27 12:57:38 -0700 (Thu, 27 Sep 2012) Log Message Unreviewed Chromium expectations update. Marking fast/dom/shadow/base-in-shadow-tree.html as timeout flakey. * platform/chromium/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (129792 => 129793) --- trunk/LayoutTests/ChangeLog 2012-09-27 19:48:58 UTC (rev 129792) +++ trunk/LayoutTests/ChangeLog 2012-09-27 19:57:38 UTC (rev 129793) @@ -1,3 +1,11 @@ +2012-09-27 Stephen Chenney schen...@chromium.org + +Unreviewed Chromium expectations update. + +Marking fast/dom/shadow/base-in-shadow-tree.html as timeout flakey. + +* platform/chromium/TestExpectations: + 2012-09-26 Dirk Pranke dpra...@chromium.org merge Skipped file entries into TestExpectations, remove Skipped files Modified: trunk/LayoutTests/platform/chromium/TestExpectations (129792 => 129793) --- trunk/LayoutTests/platform/chromium/TestExpectations 2012-09-27 19:48:58 UTC (rev 129792) +++ trunk/LayoutTests/platform/chromium/TestExpectations 2012-09-27 19:57:38 UTC (rev 129793) @@ -3506,6 +3506,8 @@ webkit.org/b/95588 [ Mac ] fast/dom/shadow/shadowdom-for-textarea-complex-shadow.html [ ImageOnlyFailure ] +webkit.org/b/97811 fast/dom/shadow/base-in-shadow-tree.html [ Pass Timeout ] + webkit.org/b/97558 [ Linux Win7 ] platform/chromium/fast/forms/date/date-suggestion-picker-appearance-rtl.html [ ImageOnlyFailure ] webkit.org/b/95070 [ Win Release ] inspector/styles/media-queries.html [ Failure Pass ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [129794] trunk/Tools
Title: [129794] trunk/Tools
Revision 129794
Author dpra...@chromium.org
Date 2012-09-27 13:21:29 -0700 (Thu, 27 Sep 2012)
Log Message
efl wk2 bots weren't looking at platform/wk2/TestExpectations
https://bugs.webkit.org/show_bug.cgi?id=97815
Unreviewed, build fix.
Should clean up this logic later so that we're just using the
implementation in base ...
* Scripts/webkitpy/layout_tests/port/efl.py:
(EflPort._search_paths):
(EflPort.expectations_files):
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/layout_tests/port/efl.py
Diff
Modified: trunk/Tools/ChangeLog (129793 => 129794)
--- trunk/Tools/ChangeLog 2012-09-27 19:57:38 UTC (rev 129793)
+++ trunk/Tools/ChangeLog 2012-09-27 20:21:29 UTC (rev 129794)
@@ -1,5 +1,19 @@
2012-09-27 Dirk Pranke dpra...@chromium.org
+efl wk2 bots weren't looking at platform/wk2/TestExpectations
+https://bugs.webkit.org/show_bug.cgi?id=97815
+
+Unreviewed, build fix.
+
+Should clean up this logic later so that we're just using the
+implementation in base ...
+
+* Scripts/webkitpy/layout_tests/port/efl.py:
+(EflPort._search_paths):
+(EflPort.expectations_files):
+
+2012-09-27 Dirk Pranke dpra...@chromium.org
+
webkitpy: make warning about missing BUG identifiers per-port configurable
https://bugs.webkit.org/show_bug.cgi?id=97751
Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/efl.py (129793 => 129794)
--- trunk/Tools/Scripts/webkitpy/layout_tests/port/efl.py 2012-09-27 19:57:38 UTC (rev 129793)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/port/efl.py 2012-09-27 20:21:29 UTC (rev 129794)
@@ -98,12 +98,14 @@
search_paths = []
if self.get_option('webkit_test_runner'):
search_paths.append(self.port_name + '-wk2')
+search_paths.append('wk2')
else:
search_paths.append(self.port_name + '-wk1')
search_paths.append(self.port_name)
return search_paths
def expectations_files(self):
+# FIXME: We should be able to use the default algorithm here.
return list(reversed([self._filesystem.join(self._webkit_baseline_path(p), 'TestExpectations') for p in self._search_paths()]))
def show_results_html_file(self, results_filename):
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [129795] trunk/LayoutTests
Title: [129795] trunk/LayoutTests Revision 129795 Author schen...@chromium.org Date 2012-09-27 13:26:02 -0700 (Thu, 27 Sep 2012) Log Message Unreviewed Chromium expectations update. Flakey compositing tests and another flakey dom/shadow test. * platform/chromium/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (129794 => 129795) --- trunk/LayoutTests/ChangeLog 2012-09-27 20:21:29 UTC (rev 129794) +++ trunk/LayoutTests/ChangeLog 2012-09-27 20:26:02 UTC (rev 129795) @@ -2,6 +2,14 @@ Unreviewed Chromium expectations update. +Flakey compositing tests and another flakey dom/shadow test. + +* platform/chromium/TestExpectations: + +2012-09-27 Stephen Chenney schen...@chromium.org + +Unreviewed Chromium expectations update. + Marking fast/dom/shadow/base-in-shadow-tree.html as timeout flakey. * platform/chromium/TestExpectations: Modified: trunk/LayoutTests/platform/chromium/TestExpectations (129794 => 129795) --- trunk/LayoutTests/platform/chromium/TestExpectations 2012-09-27 20:21:29 UTC (rev 129794) +++ trunk/LayoutTests/platform/chromium/TestExpectations 2012-09-27 20:26:02 UTC (rev 129795) @@ -3507,6 +3507,7 @@ webkit.org/b/95588 [ Mac ] fast/dom/shadow/shadowdom-for-textarea-complex-shadow.html [ ImageOnlyFailure ] webkit.org/b/97811 fast/dom/shadow/base-in-shadow-tree.html [ Pass Timeout ] +webkit.org/b/97811 fast/dom/shadow/drop-event-for-input-in-shadow.html [ Pass Failure ] webkit.org/b/97558 [ Linux Win7 ] platform/chromium/fast/forms/date/date-suggestion-picker-appearance-rtl.html [ ImageOnlyFailure ] @@ -3559,6 +3560,13 @@ crbug.com/63921 platform/chromium/virtual/gpu/fast/canvas/canvas-fillPath-shadow.html [ Failure ] webkit.org/b/77550 platform/chromium/virtual/gpu/canvas/philip/tests/2d.gradient.interpolate.colouralpha.html [ Failure ] +webkit.org/b/97816 [ Linux ] platform/chromium/compositing/filters/background-filter-blur-off-axis.html [ Pass ImageOnlyFailure ] +webkit.org/b/97816 [ Linux ] platform/chromium/compositing/filters/background-filter-blur-outsets.html [ Pass ImageOnlyFailure ] +webkit.org/b/97816 [ Linux ] platform/chromium/compositing/filters/background-filter-blur.html [ Pass ImageOnlyFailure ] +webkit.org/b/97816 [ Linux ] platform/chromium/compositing/plugins/webplugin-alpha.html [ Pass ImageOnlyFailure ] +webkit.org/b/97816 [ Linux ] platform/chromium/compositing/plugins/webplugin-no-alpha.html [ Pass ImageOnlyFailure ] +webkit.org/b/97816 [ Linux ] platform/chromium/compositing/plugins/webplugin-reflection.html [ Pass ImageOnlyFailure ] + # Started failing on r128793 webkit.org/b/96953 [ Win ] http/tests/inspector/network/network-xhr-replay.html [ Timeout ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [129796] trunk
Title: [129796] trunk
Revision 129796
Author p...@google.com
Date 2012-09-27 13:49:30 -0700 (Thu, 27 Sep 2012)
Log Message
Rewrite multithreaded filter job dispatching
https://bugs.webkit.org/show_bug.cgi?id=97500
Reviewed by Dean Jackson.
Source/WebCore:
This patch solves the problem of splitting up images into subregions for multithreaded
filters. This fixes the way we partition the image array into equal-sized chunks.
If we have an array of length N and want to split it into K chunks, we calculate:
int jobSize = N / K; // integer division, so this is floored
int jobSizeExtra = N % K; // modulus produces the remainder
We then split the array into jobSizeExtra number of jobs with size jobSize + 1
and (K - jobSizeExtra) number of jobs with size jobSize. This pattern
is used in each of the 5 filters in this patch.
This patch primarily fixes an error in FEMorphology::platformApply where
the image array was partitioned into (1 + (N / K)) pieces with the last job
taking the remainder. Unfortunately, this can cause overruns in the 2nd-to-last job.
Consider N = 2373 and K = 64 jobs. Job 0 would take indices 0...38, job 1 would take
38...76, etc. Unfortunately the 62nd job takes 2356...2394 which overruns.
To prevent similar issues elsewhere this patch updates all of the filters
to use the same pattern as FEMorphology.
Test: svg/filters/feMorphology-crash.html
* platform/graphics/filters/FEConvolveMatrix.cpp:
(WebCore::FEConvolveMatrix::platformApplySoftware):
* platform/graphics/filters/FEGaussianBlur.cpp:
(WebCore::FEGaussianBlur::platformApply):
* platform/graphics/filters/FELighting.cpp:
(WebCore::FELighting::platformApplyGeneric):
* platform/graphics/filters/FEMorphology.cpp:
(WebCore::FEMorphology::platformApply):
Some special care is taken for Gaussian Blur because there is an
extraHeight parameter for sampling outside the image's dimensions.
This means we use the same partitioning algorithm but add
extraHeight padding on the lower and upper bounds.
* platform/graphics/filters/FETurbulence.cpp:
(WebCore::FETurbulence::platformApplySoftware):
LayoutTests:
Add test that shows the morphology filter no longer crashes.
Note: this is only reliably reproducable when run with libgmalloc.
* svg/filters/feMorphology-crash-expected.txt: Added.
* svg/filters/feMorphology-crash.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/filters/FEConvolveMatrix.cpp
trunk/Source/WebCore/platform/graphics/filters/FEGaussianBlur.cpp
trunk/Source/WebCore/platform/graphics/filters/FELighting.cpp
trunk/Source/WebCore/platform/graphics/filters/FEMorphology.cpp
trunk/Source/WebCore/platform/graphics/filters/FETurbulence.cpp
Added Paths
trunk/LayoutTests/svg/filters/feMorphology-crash-expected.txt
trunk/LayoutTests/svg/filters/feMorphology-crash.html
Diff
Modified: trunk/LayoutTests/ChangeLog (129795 => 129796)
--- trunk/LayoutTests/ChangeLog 2012-09-27 20:26:02 UTC (rev 129795)
+++ trunk/LayoutTests/ChangeLog 2012-09-27 20:49:30 UTC (rev 129796)
@@ -1,3 +1,16 @@
+2012-09-27 Philip Rogers p...@google.com
+
+Rewrite multithreaded filter job dispatching
+https://bugs.webkit.org/show_bug.cgi?id=97500
+
+Reviewed by Dean Jackson.
+
+Add test that shows the morphology filter no longer crashes.
+Note: this is only reliably reproducable when run with libgmalloc.
+
+* svg/filters/feMorphology-crash-expected.txt: Added.
+* svg/filters/feMorphology-crash.html: Added.
+
2012-09-27 Stephen Chenney schen...@chromium.org
Unreviewed Chromium expectations update.
Added: trunk/LayoutTests/svg/filters/feMorphology-crash-expected.txt (0 => 129796)
--- trunk/LayoutTests/svg/filters/feMorphology-crash-expected.txt (rev 0)
+++ trunk/LayoutTests/svg/filters/feMorphology-crash-expected.txt 2012-09-27 20:49:30 UTC (rev 129796)
@@ -0,0 +1 @@
+PASS - This test passes if it did not crash.
Added: trunk/LayoutTests/svg/filters/feMorphology-crash.html (0 => 129796)
--- trunk/LayoutTests/svg/filters/feMorphology-crash.html (rev 0)
+++ trunk/LayoutTests/svg/filters/feMorphology-crash.html 2012-09-27 20:49:30 UTC (rev 129796)
@@ -0,0 +1,25 @@
+!DOCTYPE HTML
+html
+!-- Test for WK97500 - this test passes if it does not crash. --
+script
+if (window.testRunner) {
+testRunner.waitUntilDone();
+setTimeout(function() {
+document.write(PASS - This test passes if it did not crash.);
+testRunner.dumpAsText();
+testRunner.notifyDone();
+}, 1);
+}
+/script
+svg xmlns:xlink=http://www.w3.org/1999/xlink xmlns=http://www.w3.org/2000/svg width=300 height=300
+defs
+filter id=erode1 filterUnits=objectBoundingBox x=0 y=0 width=1000 height=1000
+feMorphology operator=erode radius=1 width=2000 height=10/
+/filter
+g
[webkit-changes] [129797] trunk/LayoutTests
Title: [129797] trunk/LayoutTests Revision 129797 Author rak...@webkit.org Date 2012-09-27 13:59:57 -0700 (Thu, 27 Sep 2012) Log Message [EFL] Unskip a couple of passing tests. * platform/efl/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/efl/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (129796 => 129797) --- trunk/LayoutTests/ChangeLog 2012-09-27 20:49:30 UTC (rev 129796) +++ trunk/LayoutTests/ChangeLog 2012-09-27 20:59:57 UTC (rev 129797) @@ -1,3 +1,9 @@ +2012-09-27 Raphael Kubo da Costa rak...@webkit.org + +[EFL] Unskip a couple of passing tests. + +* platform/efl/TestExpectations: + 2012-09-27 Philip Rogers p...@google.com Rewrite multithreaded filter job dispatching Modified: trunk/LayoutTests/platform/efl/TestExpectations (129796 => 129797) --- trunk/LayoutTests/platform/efl/TestExpectations 2012-09-27 20:49:30 UTC (rev 129796) +++ trunk/LayoutTests/platform/efl/TestExpectations 2012-09-27 20:59:57 UTC (rev 129797) @@ -523,7 +523,6 @@ webkit.org/b/86623 editing/pasteboard/drag-and-drop-image-contenteditable.html [ Failure ] webkit.org/b/86623 editing/pasteboard/drag-and-drop-inputimage-contenteditable.html [ Failure ] webkit.org/b/86623 editing/pasteboard/drag-and-drop-objectimage-contenteditable.html [ Failure ] -webkit.org/b/86623 editing/pasteboard/drag-drop-to-data-url.html [ Failure ] webkit.org/b/86623 editing/pasteboard/drag-image-in-about-blank-frame.html [ Failure ] webkit.org/b/86623 editing/pasteboard/files-during-page-drags.html [ Failure ] webkit.org/b/86623 editing/selection/drag-text-delay.html [ Failure ] @@ -864,7 +863,6 @@ webkit.org/b/84338 editing/pasteboard/paste-blockquote-before-blockquote.html [ Failure ] webkit.org/b/84338 editing/pasteboard/paste-code-in-pre.html [ Failure ] webkit.org/b/84338 editing/pasteboard/paste-double-nested-blockquote-before-blockquote.html [ Failure ] -webkit.org/b/84338 editing/pasteboard/paste-event-only-once.html [ Failure ] webkit.org/b/84338 editing/pasteboard/paste-into-table-cell.html [ Failure ] webkit.org/b/84338 editing/pasteboard/paste-list-001.html [ Failure ] webkit.org/b/84338 editing/pasteboard/paste-list-002.html [ Failure ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [129798] trunk/Source/WebCore
Title: [129798] trunk/Source/WebCore
Revision 129798
Author a...@chromium.org
Date 2012-09-27 14:03:47 -0700 (Thu, 27 Sep 2012)
Log Message
Fix issue with ClassList which was hitting an assert in debug mode
https://bugs.webkit.org/show_bug.cgi?id=97820
Reviewed by Ojan Vafai.
http://trac.webkit.org/changeset/129779 hit asserts in debug mode when trying to use fastGetAttribute on an SVG element.
No new tests. No change in behavior.
* bindings/v8/V8Binding.h:
(WebCore::toNativeArguments):
* html/ClassList.h:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/v8/V8Binding.h
trunk/Source/WebCore/html/ClassList.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (129797 => 129798)
--- trunk/Source/WebCore/ChangeLog 2012-09-27 20:59:57 UTC (rev 129797)
+++ trunk/Source/WebCore/ChangeLog 2012-09-27 21:03:47 UTC (rev 129798)
@@ -1,3 +1,18 @@
+2012-09-27 Erik Arvidsson a...@chromium.org
+
+Fix issue with ClassList which was hitting an assert in debug mode
+https://bugs.webkit.org/show_bug.cgi?id=97820
+
+Reviewed by Ojan Vafai.
+
+http://trac.webkit.org/changeset/129779 hit asserts in debug mode when trying to use fastGetAttribute on an SVG element.
+
+No new tests. No change in behavior.
+
+* bindings/v8/V8Binding.h:
+(WebCore::toNativeArguments):
+* html/ClassList.h:
+
2012-09-27 Philip Rogers p...@google.com
Rewrite multithreaded filter job dispatching
Modified: trunk/Source/WebCore/bindings/v8/V8Binding.h (129797 => 129798)
--- trunk/Source/WebCore/bindings/v8/V8Binding.h 2012-09-27 20:59:57 UTC (rev 129797)
+++ trunk/Source/WebCore/bindings/v8/V8Binding.h 2012-09-27 21:03:47 UTC (rev 129798)
@@ -222,13 +222,13 @@
}
template class T
-VectorT toNativeArguments(const v8::Arguments args, size_t startIndex)
+VectorT toNativeArguments(const v8::Arguments args, int startIndex)
{
ASSERT(startIndex = static_castsize_t(args.Length()));
VectorT result;
typedef NativeValueTraitsT TraitsType;
-size_t length = args.Length();
-for (size_t i = startIndex; i length; ++i)
+int length = args.Length();
+for (int i = startIndex; i length; ++i)
result.append(TraitsType::nativeValue(args[i]));
return result;
}
Modified: trunk/Source/WebCore/html/ClassList.h (129797 => 129798)
--- trunk/Source/WebCore/html/ClassList.h 2012-09-27 20:59:57 UTC (rev 129797)
+++ trunk/Source/WebCore/html/ClassList.h 2012-09-27 21:03:47 UTC (rev 129798)
@@ -65,7 +65,7 @@
const SpaceSplitString classNames() const;
-virtual AtomicString value() const OVERRIDE { return m_element-fastGetAttribute(classAttr); }
+virtual AtomicString value() const OVERRIDE { return m_element-getAttribute(classAttr); }
virtual void setValue(const AtomicString value) OVERRIDE { m_element-setAttribute(classAttr, value); }
Element* m_element;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [129799] trunk/Source
Title: [129799] trunk/Source
Revision 129799
Author pilg...@chromium.org
Date 2012-09-27 14:25:48 -0700 (Thu, 27 Sep 2012)
Log Message
[Chromium][Mac] Move Mac-specific theme functions out of PlatformSupport
https://bugs.webkit.org/show_bug.cgi?id=97817
Reviewed by Adam Barth.
Part of a refactoring series. See tracking bug 82948. We're calling WebThemeEngine directly now instead of proxying through PlatformSupport.
Source/WebCore:
* platform/chromium/PlatformSupport.h:
(PlatformSupport):
* platform/chromium/ScrollbarThemeChromiumMac.mm:
(WebCore::scrollbarStateToThemeState):
(WebCore):
(WebCore::ScrollbarThemeChromiumMac::paint):
Source/WebKit/chromium:
* src/AssertMatchingEnums.cpp:
* src/PlatformSupport.cpp:
(WebCore):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/chromium/PlatformSupport.h
trunk/Source/WebCore/platform/chromium/ScrollbarThemeChromiumMac.mm
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/src/AssertMatchingEnums.cpp
trunk/Source/WebKit/chromium/src/PlatformSupport.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (129798 => 129799)
--- trunk/Source/WebCore/ChangeLog 2012-09-27 21:03:47 UTC (rev 129798)
+++ trunk/Source/WebCore/ChangeLog 2012-09-27 21:25:48 UTC (rev 129799)
@@ -1,3 +1,19 @@
+2012-09-27 Mark Pilgrim pilg...@chromium.org
+
+[Chromium][Mac] Move Mac-specific theme functions out of PlatformSupport
+https://bugs.webkit.org/show_bug.cgi?id=97817
+
+Reviewed by Adam Barth.
+
+Part of a refactoring series. See tracking bug 82948. We're calling WebThemeEngine directly now instead of proxying through PlatformSupport.
+
+* platform/chromium/PlatformSupport.h:
+(PlatformSupport):
+* platform/chromium/ScrollbarThemeChromiumMac.mm:
+(WebCore::scrollbarStateToThemeState):
+(WebCore):
+(WebCore::ScrollbarThemeChromiumMac::paint):
+
2012-09-27 Erik Arvidsson a...@chromium.org
Fix issue with ClassList which was hitting an assert in debug mode
Modified: trunk/Source/WebCore/platform/chromium/PlatformSupport.h (129798 => 129799)
--- trunk/Source/WebCore/platform/chromium/PlatformSupport.h 2012-09-27 21:03:47 UTC (rev 129798)
+++ trunk/Source/WebCore/platform/chromium/PlatformSupport.h 2012-09-27 21:25:48 UTC (rev 129799)
@@ -127,39 +127,6 @@
GraphicsContext*, int part, int state, int classicState, const IntRect);
static void paintProgressBar(
GraphicsContext*, const IntRect barRect, const IntRect valueRect, bool determinate, double animatedSeconds);
-#elif OS(DARWIN)
-enum ThemePaintState {
-StateDisabled,
-StateInactive,
-StateActive,
-StatePressed,
-};
-
-enum ThemePaintSize {
-SizeRegular,
-SizeSmall,
-};
-
-enum ThemePaintScrollbarOrientation {
-ScrollbarOrientationHorizontal,
-ScrollbarOrientationVertical,
-};
-
-enum ThemePaintScrollbarParent {
-ScrollbarParentScrollView,
-ScrollbarParentRenderLayer,
-};
-
-struct ThemePaintScrollbarInfo {
-ThemePaintScrollbarOrientation orientation;
-ThemePaintScrollbarParent parent;
-int maxValue;
-int currentValue;
-int visibleSize;
-int totalSize;
-};
-
-static void paintScrollbarThumb(GraphicsContext*, ThemePaintState, ThemePaintSize, const IntRect, const ThemePaintScrollbarInfo);
#endif
};
Modified: trunk/Source/WebCore/platform/chromium/ScrollbarThemeChromiumMac.mm (129798 => 129799)
--- trunk/Source/WebCore/platform/chromium/ScrollbarThemeChromiumMac.mm 2012-09-27 21:03:47 UTC (rev 129798)
+++ trunk/Source/WebCore/platform/chromium/ScrollbarThemeChromiumMac.mm 2012-09-27 21:25:48 UTC (rev 129799)
@@ -33,11 +33,13 @@
#include LocalCurrentGraphicsContext.h
#include NSScrollerImpDetails.h
#include PlatformContextSkia.h
-#include PlatformSupport.h
#include ScrollAnimatorMac.h
#include ScrollView.h
#include skia/ext/skia_utils_mac.h
#include Carbon/Carbon.h
+#include public/Platform.h
+#include public/WebRect.h
+#include public/mac/WebThemeEngine.h
namespace WebCore {
@@ -58,16 +60,16 @@
{
}
-static PlatformSupport::ThemePaintState scrollbarStateToThemeState(ScrollbarThemeClient* scrollbar)
+static WebKit::WebThemeEngine::State scrollbarStateToThemeState(ScrollbarThemeClient* scrollbar)
{
if (!scrollbar-enabled())
-return PlatformSupport::StateDisabled;
+return WebKit::WebThemeEngine::StateDisabled;
if (!scrollbar-isScrollableAreaActive())
-return PlatformSupport::StateInactive;
+return WebKit::WebThemeEngine::StateInactive;
if (scrollbar-pressedPart() == ThumbPart)
-return PlatformSupport::StatePressed;
+return WebKit::WebThemeEngine::StatePressed;
-return PlatformSupport::StateActive;
+return WebKit::WebThemeEngine::StateActive;
}
static void scrollbarPainterPaintTrack(ScrollbarPainter
[webkit-changes] [129800] trunk/LayoutTests
Title: [129800] trunk/LayoutTests Revision 129800 Author o...@chromium.org Date 2012-09-27 14:33:27 -0700 (Thu, 27 Sep 2012) Log Message platform/chromium/fast/forms/date/date-suggestion-picker-appearance-rtl.html is flaky on Mac debug and is passing on all the other bots. * platform/chromium/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (129799 => 129800) --- trunk/LayoutTests/ChangeLog 2012-09-27 21:25:48 UTC (rev 129799) +++ trunk/LayoutTests/ChangeLog 2012-09-27 21:33:27 UTC (rev 129800) @@ -1,3 +1,9 @@ +2012-09-27 Ojan Vafai o...@chromium.org + +platform/chromium/fast/forms/date/date-suggestion-picker-appearance-rtl.html is flaky on Mac debug +and is passing on all the other bots. +* platform/chromium/TestExpectations: + 2012-09-27 Raphael Kubo da Costa rak...@webkit.org [EFL] Unskip a couple of passing tests. Modified: trunk/LayoutTests/platform/chromium/TestExpectations (129799 => 129800) --- trunk/LayoutTests/platform/chromium/TestExpectations 2012-09-27 21:25:48 UTC (rev 129799) +++ trunk/LayoutTests/platform/chromium/TestExpectations 2012-09-27 21:33:27 UTC (rev 129800) @@ -3509,7 +3509,7 @@ webkit.org/b/97811 fast/dom/shadow/base-in-shadow-tree.html [ Pass Timeout ] webkit.org/b/97811 fast/dom/shadow/drop-event-for-input-in-shadow.html [ Pass Failure ] -webkit.org/b/97558 [ Linux Win7 ] platform/chromium/fast/forms/date/date-suggestion-picker-appearance-rtl.html [ ImageOnlyFailure ] +webkit.org/b/97558 [ Mac Debug ] platform/chromium/fast/forms/date/date-suggestion-picker-appearance-rtl.html [ Pass ImageOnlyFailure ] webkit.org/b/95070 [ Win Release ] inspector/styles/media-queries.html [ Failure Pass ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [129801] trunk/Source/WebKit/mac
Title: [129801] trunk/Source/WebKit/mac
Revision 129801
Author ander...@apple.com
Date 2012-09-27 14:36:36 -0700 (Thu, 27 Sep 2012)
Log Message
Remove support for CFM plug-ins in WebKit1
https://bugs.webkit.org/show_bug.cgi?id=97822
Reviewed by Mark Rowe.
I'm pretty sure that CFM style plug-ins haven't been used for the last ten years or so,
so it's safe to remove them (especially since they're PPC only).
* Plugins/WebNetscapePluginPackage.h:
* Plugins/WebNetscapePluginPackage.mm:
(-[WebNetscapePluginPackage openResourceFile]):
(-[WebNetscapePluginPackage closeResourceFile:]):
(-[WebNetscapePluginPackage _initWithPath:]):
(-[WebNetscapePluginPackage _tryLoad]):
(-[WebNetscapePluginPackage _unloadWithShutdown:]):
* Plugins/WebPluginDatabase.mm:
(PluginPackageCandidates::PluginPackageCandidates):
(PluginPackageCandidates::update):
(PluginPackageCandidates::bestCandidate):
(PluginPackageCandidates):
Modified Paths
trunk/Source/WebKit/mac/ChangeLog
trunk/Source/WebKit/mac/Plugins/WebNetscapePluginPackage.h
trunk/Source/WebKit/mac/Plugins/WebNetscapePluginPackage.mm
trunk/Source/WebKit/mac/Plugins/WebPluginDatabase.mm
Diff
Modified: trunk/Source/WebKit/mac/ChangeLog (129800 => 129801)
--- trunk/Source/WebKit/mac/ChangeLog 2012-09-27 21:33:27 UTC (rev 129800)
+++ trunk/Source/WebKit/mac/ChangeLog 2012-09-27 21:36:36 UTC (rev 129801)
@@ -1,3 +1,26 @@
+2012-09-27 Anders Carlsson ander...@apple.com
+
+Remove support for CFM plug-ins in WebKit1
+https://bugs.webkit.org/show_bug.cgi?id=97822
+
+Reviewed by Mark Rowe.
+
+I'm pretty sure that CFM style plug-ins haven't been used for the last ten years or so,
+so it's safe to remove them (especially since they're PPC only).
+
+* Plugins/WebNetscapePluginPackage.h:
+* Plugins/WebNetscapePluginPackage.mm:
+(-[WebNetscapePluginPackage openResourceFile]):
+(-[WebNetscapePluginPackage closeResourceFile:]):
+(-[WebNetscapePluginPackage _initWithPath:]):
+(-[WebNetscapePluginPackage _tryLoad]):
+(-[WebNetscapePluginPackage _unloadWithShutdown:]):
+* Plugins/WebPluginDatabase.mm:
+(PluginPackageCandidates::PluginPackageCandidates):
+(PluginPackageCandidates::update):
+(PluginPackageCandidates::bestCandidate):
+(PluginPackageCandidates):
+
2012-09-26 Anders Carlsson ander...@apple.com
Stop using kCFURLHFSPathStyle
Modified: trunk/Source/WebKit/mac/Plugins/WebNetscapePluginPackage.h (129800 => 129801)
--- trunk/Source/WebKit/mac/Plugins/WebNetscapePluginPackage.h 2012-09-27 21:33:27 UTC (rev 129800)
+++ trunk/Source/WebKit/mac/Plugins/WebNetscapePluginPackage.h 2012-09-27 21:36:36 UTC (rev 129801)
@@ -30,15 +30,6 @@
#import WebBasePluginPackage.h
-#if defined(__ppc__) !defined(__LP64__)
-#define SUPPORT_CFM
-#endif
-
-typedef enum {
-WebCFMExecutableType,
-WebMachOExecutableType
-} WebExecutableType;
-
@interface WebNetscapePluginPackage : WebBasePluginPackage
{
NPPluginFuncs pluginFuncs;
@@ -58,12 +49,6 @@
#if USE(PLUGIN_HOST_PROCESS)
cpu_type_t pluginHostArchitecture;
#endif
-
-#ifdef SUPPORT_CFM
-BOOL isBundle;
-BOOL isCFM;
-CFragConnectionID connID;
-#endif
}
// Netscape plug-in packages must be explicitly opened and closed by each plug-in instance.
@@ -71,7 +56,6 @@
- (void)open;
- (void)close;
-- (WebExecutableType)executableType;
- (NPPluginFuncs *)pluginFuncs;
- (NPNetscapeFuncs *)browserFuncs;
Modified: trunk/Source/WebKit/mac/Plugins/WebNetscapePluginPackage.mm (129800 => 129801)
--- trunk/Source/WebKit/mac/Plugins/WebNetscapePluginPackage.mm 2012-09-27 21:33:27 UTC (rev 129800)
+++ trunk/Source/WebKit/mac/Plugins/WebNetscapePluginPackage.mm 2012-09-27 21:36:36 UTC (rev 129801)
@@ -57,9 +57,6 @@
#define MIMEDescriptionStringNumber 127
#define MIMEListStringStringNumber 128
-#define RealPlayerAppIndentifier@com.RealNetworks.RealOne Player
-#define RealPlayerPluginFilenameRealPlayer Plugin
-
@interface WebNetscapePluginPackage (Internal)
- (void)_unloadWithShutdown:(BOOL)shutdown;
@end
@@ -107,29 +104,11 @@
- (ResFileRefNum)openResourceFile
{
-#ifdef SUPPORT_CFM
-if (!isBundle) {
-FSRef fref;
-OSErr err = FSPathMakeRef((const UInt8 *)[(NSString *)path fileSystemRepresentation], fref, NULL);
-if (err != noErr)
-return -1;
-
-return FSOpenResFile(fref, fsRdPerm);
-}
-#endif
-
return CFBundleOpenBundleResourceMap(cfBundle.get());
}
- (void)closeResourceFile:(ResFileRefNum)resRef
{
-#ifdef SUPPORT_CFM
-if (!isBundle) {
-CloseResFile(resRef);
-return;
-}
-#endif
-
CFBundleCloseBundleResourceMap(cfBundle.get(), resRef);
}
@@ -227,60 +206,31 @@
OSType type = 0;
-if (cfBundle) {
-// Bundle
-CFBundleGetPackageInfo(cfBundle.get(), type, NULL);
-#ifdef
[webkit-changes] [129802] trunk/Tools
Title: [129802] trunk/Tools
Revision 129802
Author commit-qu...@webkit.org
Date 2012-09-27 14:44:01 -0700 (Thu, 27 Sep 2012)
Log Message
[Mac][DRT] Add support to allow non-array modifier arguments in keyDown()
https://bugs.webkit.org/show_bug.cgi?id=97805
Patch by Sudarsana Nagineni sudarsana.nagin...@intel.com on 2012-09-27
Reviewed by Alexey Proskuryakov.
Add support for handling a string as modifier argument to keyDown().
This support has already been added to other ports, so implementing
this on Mac too, to be consistent with the other ports.
* DumpRenderTree/mac/EventSendingController.mm:
(modifierFlags):
(buildModifierFlags):
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/DumpRenderTree/mac/EventSendingController.mm
Diff
Modified: trunk/Tools/ChangeLog (129801 => 129802)
--- trunk/Tools/ChangeLog 2012-09-27 21:36:36 UTC (rev 129801)
+++ trunk/Tools/ChangeLog 2012-09-27 21:44:01 UTC (rev 129802)
@@ -1,3 +1,18 @@
+2012-09-27 Sudarsana Nagineni sudarsana.nagin...@intel.com
+
+[Mac][DRT] Add support to allow non-array modifier arguments in keyDown()
+https://bugs.webkit.org/show_bug.cgi?id=97805
+
+Reviewed by Alexey Proskuryakov.
+
+Add support for handling a string as modifier argument to keyDown().
+This support has already been added to other ports, so implementing
+this on Mac too, to be consistent with the other ports.
+
+* DumpRenderTree/mac/EventSendingController.mm:
+(modifierFlags):
+(buildModifierFlags):
+
2012-09-27 Dirk Pranke dpra...@chromium.org
efl wk2 bots weren't looking at platform/wk2/TestExpectations
Modified: trunk/Tools/DumpRenderTree/mac/EventSendingController.mm (129801 => 129802)
--- trunk/Tools/DumpRenderTree/mac/EventSendingController.mm 2012-09-27 21:36:36 UTC (rev 129801)
+++ trunk/Tools/DumpRenderTree/mac/EventSendingController.mm 2012-09-27 21:44:01 UTC (rev 129802)
@@ -299,21 +299,31 @@
clickCount++;
}
+static int modifierFlags(const NSString* modifierName)
+{
+int flags = 0;
+if ([modifierName isEqual:@ctrlKey])
+flags |= NSControlKeyMask;
+else if ([modifierName isEqual:@shiftKey] || [modifierName isEqual:@rangeSelectionKey])
+flags |= NSShiftKeyMask;
+else if ([modifierName isEqual:@altKey])
+flags |= NSAlternateKeyMask;
+else if ([modifierName isEqual:@metaKey] || [modifierName isEqual:@addSelectionKey])
+flags |= NSCommandKeyMask;
+
+return flags;
+}
+
static int buildModifierFlags(const WebScriptObject* modifiers)
{
int flags = 0;
-if (![modifiers isKindOfClass:[WebScriptObject class]])
+if ([modifiers isKindOfClass:[NSString class]])
+return modifierFlags((NSString*)modifiers);
+else if (![modifiers isKindOfClass:[WebScriptObject class]])
return flags;
for (unsigned i = 0; [[modifiers webScriptValueAtIndex:i] isKindOfClass:[NSString class]]; i++) {
NSString* modifierName = (NSString*)[modifiers webScriptValueAtIndex:i];
-if ([modifierName isEqual:@ctrlKey])
-flags |= NSControlKeyMask;
-else if ([modifierName isEqual:@shiftKey] || [modifierName isEqual:@rangeSelectionKey])
-flags |= NSShiftKeyMask;
-else if ([modifierName isEqual:@altKey])
-flags |= NSAlternateKeyMask;
-else if ([modifierName isEqual:@metaKey] || [modifierName isEqual:@addSelectionKey])
-flags |= NSCommandKeyMask;
+flags |= modifierFlags(modifierName);
}
return flags;
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [129803] trunk/Source/WebKit/mac
Title: [129803] trunk/Source/WebKit/mac Revision 129803 Author ander...@apple.com Date 2012-09-27 14:54:20 -0700 (Thu, 27 Sep 2012) Log Message Fix 32-bit build. * Plugins/WebNetscapePluginPackage.mm: (-[WebNetscapePluginPackage _initWithPath:]): Add back the architecture check that i accidentally. Modified Paths trunk/Source/WebKit/mac/ChangeLog trunk/Source/WebKit/mac/Plugins/WebNetscapePluginPackage.mm Diff Modified: trunk/Source/WebKit/mac/ChangeLog (129802 => 129803) --- trunk/Source/WebKit/mac/ChangeLog 2012-09-27 21:44:01 UTC (rev 129802) +++ trunk/Source/WebKit/mac/ChangeLog 2012-09-27 21:54:20 UTC (rev 129803) @@ -1,5 +1,13 @@ 2012-09-27 Anders Carlsson ander...@apple.com +Fix 32-bit build. + +* Plugins/WebNetscapePluginPackage.mm: +(-[WebNetscapePluginPackage _initWithPath:]): +Add back the architecture check that i accidentally. + +2012-09-27 Anders Carlsson ander...@apple.com + Remove support for CFM plug-ins in WebKit1 https://bugs.webkit.org/show_bug.cgi?id=97822 Modified: trunk/Source/WebKit/mac/Plugins/WebNetscapePluginPackage.mm (129802 => 129803) --- trunk/Source/WebKit/mac/Plugins/WebNetscapePluginPackage.mm 2012-09-27 21:44:01 UTC (rev 129802) +++ trunk/Source/WebKit/mac/Plugins/WebNetscapePluginPackage.mm 2012-09-27 21:54:20 UTC (rev 129803) @@ -230,6 +230,10 @@ NSFileHandle *executableFile = [NSFileHandle fileHandleForReadingAtPath:[(NSURL *)executableURL.get() path]]; NSData *data = "" readDataOfLength:512]; [executableFile closeFile]; + + if (![self isNativeLibraryData:data]) + return NO; + #endif if (![self getPluginInfoFromPLists] ![self getPluginInfoFromResources]) ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [129804] trunk/Tools
Title: [129804] trunk/Tools
Revision 129804
Author fmal...@chromium.org
Date 2012-09-27 14:55:47 -0700 (Thu, 27 Sep 2012)
Log Message
[Perftest] PerfTestRunner exception when using nested git checkouts
https://bugs.webkit.org/show_bug.cgi?id=97796
Reviewed by Ryosuke Niwa.
In order to support separate Chromium vs. WebKit git trees, PerfTestsRunner needs to
instantiate per-repository SCM objects when collecting revision information.
* Scripts/webkitpy/performance_tests/perftestsrunner.py:
(PerfTestsRunner._generate_results_dict):
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/performance_tests/perftestsrunner.py
Diff
Modified: trunk/Tools/ChangeLog (129803 => 129804)
--- trunk/Tools/ChangeLog 2012-09-27 21:54:20 UTC (rev 129803)
+++ trunk/Tools/ChangeLog 2012-09-27 21:55:47 UTC (rev 129804)
@@ -1,3 +1,16 @@
+2012-09-27 Florin Malita fmal...@chromium.org
+
+[Perftest] PerfTestRunner exception when using nested git checkouts
+https://bugs.webkit.org/show_bug.cgi?id=97796
+
+Reviewed by Ryosuke Niwa.
+
+In order to support separate Chromium vs. WebKit git trees, PerfTestsRunner needs to
+instantiate per-repository SCM objects when collecting revision information.
+
+* Scripts/webkitpy/performance_tests/perftestsrunner.py:
+(PerfTestsRunner._generate_results_dict):
+
2012-09-27 Sudarsana Nagineni sudarsana.nagin...@intel.com
[Mac][DRT] Add support to allow non-array modifier arguments in keyDown()
Modified: trunk/Tools/Scripts/webkitpy/performance_tests/perftestsrunner.py (129803 => 129804)
--- trunk/Tools/Scripts/webkitpy/performance_tests/perftestsrunner.py 2012-09-27 21:54:20 UTC (rev 129803)
+++ trunk/Tools/Scripts/webkitpy/performance_tests/perftestsrunner.py 2012-09-27 21:55:47 UTC (rev 129804)
@@ -36,6 +36,7 @@
import time
from webkitpy.common import find_files
+from webkitpy.common.checkout.scm.detection import SCMDetector
from webkitpy.common.host import Host
from webkitpy.common.net.file_uploader import FileUploader
from webkitpy.performance_tests.perftest import PerfTestFactory
@@ -205,7 +206,8 @@
if description:
contents['description'] = description
for (name, path) in self._port.repository_paths():
-contents[name + '-revision'] = self._host.scm().svn_revision(path)
+scm = SCMDetector(self._host.filesystem, self._host.executive).detect_scm_system(path) or self._host.scm()
+contents[name + '-revision'] = scm.svn_revision(path)
# FIXME: Add --branch or auto-detect the branch we're in
for key, value in {'timestamp': int(timestamp), 'branch': self._default_branch, 'platform': platform,
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [129805] trunk/Tools
Title: [129805] trunk/Tools
Revision 129805
Author aba...@webkit.org
Date 2012-09-27 15:01:17 -0700 (Thu, 27 Sep 2012)
Log Message
Add webkit_unit_tests to the flakiness dashboard
https://bugs.webkit.org/show_bug.cgi?id=97814
Patch by Julie Parent jpar...@chromium.org on 2012-09-27
Reviewed by Dirk Pranke.
webkit_unit_tests run on the same bots as test_shell_tests.
* TestResultServer/static-dashboards/builders.js:
(loadBuildersList):
* TestResultServer/static-dashboards/dashboard_base.js:
(currentBuilderGroupCategory):
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/TestResultServer/static-dashboards/builders.js
trunk/Tools/TestResultServer/static-dashboards/dashboard_base.js
Diff
Modified: trunk/Tools/ChangeLog (129804 => 129805)
--- trunk/Tools/ChangeLog 2012-09-27 21:55:47 UTC (rev 129804)
+++ trunk/Tools/ChangeLog 2012-09-27 22:01:17 UTC (rev 129805)
@@ -1,3 +1,17 @@
+2012-09-27 Julie Parent jpar...@chromium.org
+
+Add webkit_unit_tests to the flakiness dashboard
+https://bugs.webkit.org/show_bug.cgi?id=97814
+
+Reviewed by Dirk Pranke.
+
+webkit_unit_tests run on the same bots as test_shell_tests.
+
+* TestResultServer/static-dashboards/builders.js:
+(loadBuildersList):
+* TestResultServer/static-dashboards/dashboard_base.js:
+(currentBuilderGroupCategory):
+
2012-09-27 Florin Malita fmal...@chromium.org
[Perftest] PerfTestRunner exception when using nested git checkouts
Modified: trunk/Tools/TestResultServer/static-dashboards/builders.js (129804 => 129805)
--- trunk/Tools/TestResultServer/static-dashboards/builders.js 2012-09-27 21:55:47 UTC (rev 129804)
+++ trunk/Tools/TestResultServer/static-dashboards/builders.js 2012-09-27 22:01:17 UTC (rev 129805)
@@ -281,6 +281,7 @@
break;
case 'test_shell_tests':
+case 'webkit_unit_tests':
switch(groupName) {
case '@ToT - chromium.org':
var builderGroup = new BuilderGroup(BuilderGroup.TOT_WEBKIT);
Modified: trunk/Tools/TestResultServer/static-dashboards/dashboard_base.js (129804 => 129805)
--- trunk/Tools/TestResultServer/static-dashboards/dashboard_base.js 2012-09-27 21:55:47 UTC (rev 129804)
+++ trunk/Tools/TestResultServer/static-dashboards/dashboard_base.js 2012-09-27 22:01:17 UTC (rev 129805)
@@ -147,6 +147,7 @@
'ui_tests',
'unit_tests',
'views_unittests',
+'webkit_unit_tests',
];
var RELOAD_REQUIRING_PARAMETERS = ['showAllRuns', 'group', 'testType'];
@@ -457,6 +458,7 @@
case 'layout-tests':
return LAYOUT_TESTS_BUILDER_GROUPS;
case 'test_shell_tests':
+case 'webkit_unit_tests':
return TEST_SHELL_TESTS_BUILDER_GROUPS;
default:
return CHROMIUM_GTESTS_BUILDER_GROUPS;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [129806] trunk/Source/WebCore
Title: [129806] trunk/Source/WebCore
Revision 129806
Author jsb...@chromium.org
Date 2012-09-27 15:03:50 -0700 (Thu, 27 Sep 2012)
Log Message
IndexedDB: Optimize encodeString/decodeString
https://bugs.webkit.org/show_bug.cgi?id=97794
Reviewed by Tony Chang.
Optimize string encoding/decoding, which showed up as a CPU hot spot during profiling.
The backing store uses big-endian ordering of 16-bit code unit strings, so a memcopy
isn't sufficient, but the code used StringBuilder::append() character-by-character
and custom byte-swapping which was slow.
Ran a test w/ DumpRenderTree (to avoid multiprocess overhead) taking a 10k character string
and putting it 20k times and getting it 20k times. On my test box, mean time before the
patch was 8.2s, mean time after the patch was 4.6s.
Tested by Chromium's webkit_unit_tests --gtest_filter='IDBLevelDBCodingTest.*String*'
* Modules/indexeddb/IDBLevelDBCoding.cpp:
(WebCore::IDBLevelDBCoding::encodeString):
(WebCore::IDBLevelDBCoding::decodeString):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/indexeddb/IDBLevelDBCoding.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (129805 => 129806)
--- trunk/Source/WebCore/ChangeLog 2012-09-27 22:01:17 UTC (rev 129805)
+++ trunk/Source/WebCore/ChangeLog 2012-09-27 22:03:50 UTC (rev 129806)
@@ -1,3 +1,25 @@
+2012-09-27 Joshua Bell jsb...@chromium.org
+
+IndexedDB: Optimize encodeString/decodeString
+https://bugs.webkit.org/show_bug.cgi?id=97794
+
+Reviewed by Tony Chang.
+
+Optimize string encoding/decoding, which showed up as a CPU hot spot during profiling.
+The backing store uses big-endian ordering of 16-bit code unit strings, so a memcopy
+isn't sufficient, but the code used StringBuilder::append() character-by-character
+and custom byte-swapping which was slow.
+
+Ran a test w/ DumpRenderTree (to avoid multiprocess overhead) taking a 10k character string
+and putting it 20k times and getting it 20k times. On my test box, mean time before the
+patch was 8.2s, mean time after the patch was 4.6s.
+
+Tested by Chromium's webkit_unit_tests --gtest_filter='IDBLevelDBCodingTest.*String*'
+
+* Modules/indexeddb/IDBLevelDBCoding.cpp:
+(WebCore::IDBLevelDBCoding::encodeString):
+(WebCore::IDBLevelDBCoding::decodeString):
+
2012-09-27 Mark Pilgrim pilg...@chromium.org
[Chromium][Mac] Move Mac-specific theme functions out of PlatformSupport
Modified: trunk/Source/WebCore/Modules/indexeddb/IDBLevelDBCoding.cpp (129805 => 129806)
--- trunk/Source/WebCore/Modules/indexeddb/IDBLevelDBCoding.cpp 2012-09-27 22:01:17 UTC (rev 129805)
+++ trunk/Source/WebCore/Modules/indexeddb/IDBLevelDBCoding.cpp 2012-09-27 22:03:50 UTC (rev 129806)
@@ -26,6 +26,9 @@
#include config.h
#include IDBLevelDBCoding.h
+// For htons/ntohs.
+#include arpa/inet.h
+
#if ENABLE(INDEXED_DATABASE)
#if USE(LEVELDB)
@@ -289,36 +292,33 @@
Vectorchar encodeString(const String s)
{
-Vectorchar ret(s.length() * 2);
+// Backing store is UTF-16BE, convert from host endianness.
+size_t length = s.length();
+Vectorchar ret(length * sizeof(UChar));
-for (unsigned i = 0; i s.length(); ++i) {
-UChar u = s[i];
-unsigned char hi = u 8;
-unsigned char lo = u;
-ret[2 * i] = hi;
-ret[2 * i + 1] = lo;
-}
+const UChar* src = ""
+UChar* dst = reinterpret_castUChar*(ret.data());
+for (unsigned i = 0; i length; ++i)
+*dst++ = htons(*src++);
return ret;
}
-String decodeString(const char* p, const char* end)
+String decodeString(const char* start, const char* end)
{
-ASSERT(end = p);
-ASSERT(!((end - p) % 2));
+// Backing store is UTF-16BE, convert to host endianness.
+ASSERT(end = start);
+ASSERT(!((end - start) % sizeof(UChar)));
-size_t len = (end - p) / 2;
-StringBuilder result;
-result.reserveCapacity(len);
+size_t length = (end - start) / sizeof(UChar);
+VectorUChar buffer(length);
-for (size_t i = 0; i len; ++i) {
-unsigned char hi = *p++;
-unsigned char lo = *p++;
+const UChar* src = "" UChar*(start);
+UChar* dst = buffer.data();
+for (unsigned i = 0; i length; ++i)
+*dst++ = ntohs(*src++);
-result.append(static_castUChar((hi 8) | lo));
-}
-
-return result.toString();
+return String::adopt(buffer);
}
Vectorchar encodeStringWithLength(const String s)
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [129807] trunk/Source/WebCore
Title: [129807] trunk/Source/WebCore
Revision 129807
Author a...@chromium.org
Date 2012-09-27 15:15:24 -0700 (Thu, 27 Sep 2012)
Log Message
Unreviewed Chromium debug build fix.
Two fixes makes one breakage
http://trac.webkit.org/changeset/129785
http://trac.webkit.org/changeset/129798
* bindings/v8/V8Binding.h:
(WebCore::toNativeArguments):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/v8/V8Binding.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (129806 => 129807)
--- trunk/Source/WebCore/ChangeLog 2012-09-27 22:03:50 UTC (rev 129806)
+++ trunk/Source/WebCore/ChangeLog 2012-09-27 22:15:24 UTC (rev 129807)
@@ -1,3 +1,14 @@
+2012-09-27 Erik Arvidsson a...@chromium.org
+Unreviewed Chromium debug build fix.
+
+Two fixes makes one breakage
+
+http://trac.webkit.org/changeset/129785
+http://trac.webkit.org/changeset/129798
+
+* bindings/v8/V8Binding.h:
+(WebCore::toNativeArguments):
+
2012-09-27 Joshua Bell jsb...@chromium.org
IndexedDB: Optimize encodeString/decodeString
Modified: trunk/Source/WebCore/bindings/v8/V8Binding.h (129806 => 129807)
--- trunk/Source/WebCore/bindings/v8/V8Binding.h 2012-09-27 22:03:50 UTC (rev 129806)
+++ trunk/Source/WebCore/bindings/v8/V8Binding.h 2012-09-27 22:15:24 UTC (rev 129807)
@@ -224,7 +224,7 @@
template class T
VectorT toNativeArguments(const v8::Arguments args, int startIndex)
{
-ASSERT(startIndex = static_castsize_t(args.Length()));
+ASSERT(startIndex = args.Length());
VectorT result;
typedef NativeValueTraitsT TraitsType;
int length = args.Length();
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [129808] trunk
Title: [129808] trunk
Revision 129808
Author commit-qu...@webkit.org
Date 2012-09-27 15:25:36 -0700 (Thu, 27 Sep 2012)
Log Message
requestAnimationFrame broken with subframes (DisplayRefreshMonitorManager::registerClient fails to register client)
https://bugs.webkit.org/show_bug.cgi?id=95360
Patch by Andrew Lo a...@rim.com on 2012-09-27
Reviewed by Simon Fraser.
Source/WebCore:
DisplayRefreshMonitorManager::ensureMonitorForClient currently only adds the DisplayRefreshMonitorClient
to the appropriate DisplayRefreshMonitor when a new monitor is created.
It should also do so when it finds an existing monitor.
Test: fast/animation/request-animation-frame-iframe2.html
* platform/graphics/DisplayRefreshMonitor.cpp:
(WebCore::DisplayRefreshMonitor::addClient):
(WebCore::DisplayRefreshMonitorManager::ensureMonitorForClient):
LayoutTests:
Add a new test which does requestAnimationFrame in both a sub-frame and
main-frame, and checks that both were executed.
* fast/animation/request-animation-frame-iframe2-expected.txt: Added.
* fast/animation/request-animation-frame-iframe2.html: Added.
* fast/animation/script-tests/request-animation-frame-subframe.html:
Remove element parameter from window.webkitRequestAnimationFrame.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/animation/script-tests/request-animation-frame-subframe.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/DisplayRefreshMonitor.cpp
Added Paths
trunk/LayoutTests/fast/animation/request-animation-frame-iframe2-expected.txt
trunk/LayoutTests/fast/animation/request-animation-frame-iframe2.html
Diff
Modified: trunk/LayoutTests/ChangeLog (129807 => 129808)
--- trunk/LayoutTests/ChangeLog 2012-09-27 22:15:24 UTC (rev 129807)
+++ trunk/LayoutTests/ChangeLog 2012-09-27 22:25:36 UTC (rev 129808)
@@ -1,3 +1,18 @@
+2012-09-27 Andrew Lo a...@rim.com
+
+requestAnimationFrame broken with subframes (DisplayRefreshMonitorManager::registerClient fails to register client)
+https://bugs.webkit.org/show_bug.cgi?id=95360
+
+Reviewed by Simon Fraser.
+
+Add a new test which does requestAnimationFrame in both a sub-frame and
+main-frame, and checks that both were executed.
+
+* fast/animation/request-animation-frame-iframe2-expected.txt: Added.
+* fast/animation/request-animation-frame-iframe2.html: Added.
+* fast/animation/script-tests/request-animation-frame-subframe.html:
+Remove element parameter from window.webkitRequestAnimationFrame.
+
2012-09-27 Ojan Vafai o...@chromium.org
platform/chromium/fast/forms/date/date-suggestion-picker-appearance-rtl.html is flaky on Mac debug
Added: trunk/LayoutTests/fast/animation/request-animation-frame-iframe2-expected.txt (0 => 129808)
--- trunk/LayoutTests/fast/animation/request-animation-frame-iframe2-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/animation/request-animation-frame-iframe2-expected.txt 2012-09-27 22:25:36 UTC (rev 129808)
@@ -0,0 +1,11 @@
+Tests requestAnimationFrame in both an iframe and main frame
+
+On success, you will see a series of PASS messages, followed by TEST COMPLETE.
+
+
+PASS callbackInvoked is true
+PASS mainFrameCallbackInvoked is true
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
Added: trunk/LayoutTests/fast/animation/request-animation-frame-iframe2.html (0 => 129808)
--- trunk/LayoutTests/fast/animation/request-animation-frame-iframe2.html (rev 0)
+++ trunk/LayoutTests/fast/animation/request-animation-frame-iframe2.html 2012-09-27 22:25:36 UTC (rev 129808)
@@ -0,0 +1,44 @@
+!DOCTYPE html
+html
+head
+script src=""
+/head
+body
+iframe src="" width=700 height=500/iframe
+script type=text/_javascript_ charset=utf-8
+description(Tests requestAnimationFrame in both an iframe and main frame);
+
+var callbackInvoked = false;
+var mainFrameCallbackInvoked = false;
+
+if (window.testRunner) {
+testRunner.dumpAsText();
+testRunner.waitUntilDone();
+}
+
+window.webkitRequestAnimationFrame(function() {
+mainFrameCallbackInvoked = true;
+});
+
+// Called from subframe.
+function doDisplay()
+{
+if (window.testRunner)
+testRunner.display();
+}
+
+function doCheckResult()
+{
+shouldBeTrue(callbackInvoked);
+shouldBeTrue(mainFrameCallbackInvoked);
+}
+
+function doTestDone()
+{
+isSuccessfullyParsed();
+if (window.testRunner)
+testRunner.notifyDone();
+}
+/script
+/body
+/html
Modified: trunk/LayoutTests/fast/animation/script-tests/request-animation-frame-subframe.html (129807 => 129808)
--- trunk/LayoutTests/fast/animation/script-tests/request-animation-frame-subframe.html 2012-09-27 22:15:24 UTC (rev 129807)
+++
[webkit-changes] [129810] trunk/Source/WebKit2
Title: [129810] trunk/Source/WebKit2
Revision 129810
Author bda...@apple.com
Date 2012-09-27 15:37:45 -0700 (Thu, 27 Sep 2012)
Log Message
https://bugs.webkit.org/show_bug.cgi?id=97823
Need to bump the WKBundlePageLoaderClient version after the addition of didLayout
Reviewed by Brady Eidson.
Bump the version.
* Shared/APIClientTraits.cpp:
(WebKit):
* Shared/APIClientTraits.h:
* WebProcess/InjectedBundle/API/c/WKBundlePage.h:
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/Shared/APIClientTraits.cpp
trunk/Source/WebKit2/Shared/APIClientTraits.h
trunk/Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundlePage.h
Diff
Modified: trunk/Source/WebKit2/ChangeLog (129809 => 129810)
--- trunk/Source/WebKit2/ChangeLog 2012-09-27 22:33:53 UTC (rev 129809)
+++ trunk/Source/WebKit2/ChangeLog 2012-09-27 22:37:45 UTC (rev 129810)
@@ -1,3 +1,16 @@
+2012-09-27 Beth Dakin bda...@apple.com
+
+https://bugs.webkit.org/show_bug.cgi?id=97823
+Need to bump the WKBundlePageLoaderClient version after the addition of didLayout
+
+Reviewed by Brady Eidson.
+
+Bump the version.
+* Shared/APIClientTraits.cpp:
+(WebKit):
+* Shared/APIClientTraits.h:
+* WebProcess/InjectedBundle/API/c/WKBundlePage.h:
+
2012-09-27 Helder Correia helder.corr...@nokia.com
[Cairo] Unnecessary creation of ShareableBitmap's for directly composited images
Modified: trunk/Source/WebKit2/Shared/APIClientTraits.cpp (129809 => 129810)
--- trunk/Source/WebKit2/Shared/APIClientTraits.cpp 2012-09-27 22:33:53 UTC (rev 129809)
+++ trunk/Source/WebKit2/Shared/APIClientTraits.cpp 2012-09-27 22:37:45 UTC (rev 129810)
@@ -40,6 +40,7 @@
offsetof(WKBundlePageLoaderClient, didLayoutForFrame),
offsetof(WKBundlePageLoaderClient, didFinishProgress),
offsetof(WKBundlePageLoaderClient, didReceiveIntentForFrame),
+offsetof(WKBundlePageLoaderClient, registerIntentServiceForFrame),
sizeof(WKBundlePageLoaderClient)
};
Modified: trunk/Source/WebKit2/Shared/APIClientTraits.h (129809 => 129810)
--- trunk/Source/WebKit2/Shared/APIClientTraits.h 2012-09-27 22:33:53 UTC (rev 129809)
+++ trunk/Source/WebKit2/Shared/APIClientTraits.h 2012-09-27 22:37:45 UTC (rev 129810)
@@ -44,7 +44,7 @@
};
template struct APIClientTraitsWKBundlePageLoaderClient {
-static const size_t interfaceSizesByVersion[4];
+static const size_t interfaceSizesByVersion[5];
};
template struct APIClientTraitsWKBundlePageResourceLoadClient {
Modified: trunk/Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundlePage.h (129809 => 129810)
--- trunk/Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundlePage.h 2012-09-27 22:33:53 UTC (rev 129809)
+++ trunk/Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundlePage.h 2012-09-27 22:37:45 UTC (rev 129810)
@@ -154,11 +154,13 @@
// Version 3
WKBundlePageDidReceiveIntentForFrameCallbackdidReceiveIntentForFrame;
WKBundlePageRegisterIntentServiceForFrameCallback registerIntentServiceForFrame;
+
+// Version 4
WKBundlePageDidLayoutCallback didLayout;
};
typedef struct WKBundlePageLoaderClient WKBundlePageLoaderClient;
-enum { kWKBundlePageLoaderClientCurrentVersion = 3 };
+enum { kWKBundlePageLoaderClientCurrentVersion = 4 };
enum {
WKBundlePagePolicyActionPassThrough,
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [129811] tags/Safari-537.12/
Title: [129811] tags/Safari-537.12/ Revision 129811 Author lforsch...@apple.com Date 2012-09-27 15:48:10 -0700 (Thu, 27 Sep 2012) Log Message New Tag. Added Paths tags/Safari-537.12/ Diff Property changes: tags/Safari-537.12 Added: svn:ignore depcomp compile config.guess GNUmakefile.in config.sub ltmain.sh aconfig.h.in autom4te.cache missing aclocal.m4 install-sh autotoolsconfig.h.in INSTALL README gtk-doc.make out Makefile.chromium WebKitSupportLibrary.zip WebKitBuild Added: svn:mergeinfo ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [129812] tags/Safari-537.12/Source/WebKit2
Title: [129812] tags/Safari-537.12/Source/WebKit2
Revision 129812
Author lforsch...@apple.com
Date 2012-09-27 16:05:03 -0700 (Thu, 27 Sep 2012)
Log Message
Merge r129810.
Modified Paths
tags/Safari-537.12/Source/WebKit2/ChangeLog
tags/Safari-537.12/Source/WebKit2/Shared/APIClientTraits.cpp
tags/Safari-537.12/Source/WebKit2/Shared/APIClientTraits.h
tags/Safari-537.12/Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundlePage.h
Diff
Modified: tags/Safari-537.12/Source/WebKit2/ChangeLog (129811 => 129812)
--- tags/Safari-537.12/Source/WebKit2/ChangeLog 2012-09-27 22:48:10 UTC (rev 129811)
+++ tags/Safari-537.12/Source/WebKit2/ChangeLog 2012-09-27 23:05:03 UTC (rev 129812)
@@ -1,3 +1,20 @@
+2012-09-27 Lucas Forschler lforsch...@apple.com
+
+Merge 129810.
+
+2012-09-27 Beth Dakin bda...@apple.com
+
+https://bugs.webkit.org/show_bug.cgi?id=97823
+Need to bump the WKBundlePageLoaderClient version after the addition of didLayout
+
+Reviewed by Brady Eidson.
+
+Bump the version.
+* Shared/APIClientTraits.cpp:
+(WebKit):
+* Shared/APIClientTraits.h:
+* WebProcess/InjectedBundle/API/c/WKBundlePage.h:
+
2012-09-26 Anders Carlsson ander...@apple.com
Stop using CFURLCreateDataAndPropertiesFromResource
Modified: tags/Safari-537.12/Source/WebKit2/Shared/APIClientTraits.cpp (129811 => 129812)
--- tags/Safari-537.12/Source/WebKit2/Shared/APIClientTraits.cpp 2012-09-27 22:48:10 UTC (rev 129811)
+++ tags/Safari-537.12/Source/WebKit2/Shared/APIClientTraits.cpp 2012-09-27 23:05:03 UTC (rev 129812)
@@ -40,6 +40,7 @@
offsetof(WKBundlePageLoaderClient, didLayoutForFrame),
offsetof(WKBundlePageLoaderClient, didFinishProgress),
offsetof(WKBundlePageLoaderClient, didReceiveIntentForFrame),
+offsetof(WKBundlePageLoaderClient, registerIntentServiceForFrame),
sizeof(WKBundlePageLoaderClient)
};
Modified: tags/Safari-537.12/Source/WebKit2/Shared/APIClientTraits.h (129811 => 129812)
--- tags/Safari-537.12/Source/WebKit2/Shared/APIClientTraits.h 2012-09-27 22:48:10 UTC (rev 129811)
+++ tags/Safari-537.12/Source/WebKit2/Shared/APIClientTraits.h 2012-09-27 23:05:03 UTC (rev 129812)
@@ -43,7 +43,7 @@
};
template struct APIClientTraitsWKBundlePageLoaderClient {
-static const size_t interfaceSizesByVersion[4];
+static const size_t interfaceSizesByVersion[5];
};
template struct APIClientTraitsWKBundlePageResourceLoadClient {
Modified: tags/Safari-537.12/Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundlePage.h (129811 => 129812)
--- tags/Safari-537.12/Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundlePage.h 2012-09-27 22:48:10 UTC (rev 129811)
+++ tags/Safari-537.12/Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundlePage.h 2012-09-27 23:05:03 UTC (rev 129812)
@@ -154,11 +154,13 @@
// Version 3
WKBundlePageDidReceiveIntentForFrameCallbackdidReceiveIntentForFrame;
WKBundlePageRegisterIntentServiceForFrameCallback registerIntentServiceForFrame;
+
+// Version 4
WKBundlePageDidLayoutCallback didLayout;
};
typedef struct WKBundlePageLoaderClient WKBundlePageLoaderClient;
-enum { kWKBundlePageLoaderClientCurrentVersion = 3 };
+enum { kWKBundlePageLoaderClientCurrentVersion = 4 };
enum {
WKBundlePagePolicyActionPassThrough,
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [129813] trunk/PerformanceTests
Title: [129813] trunk/PerformanceTests
Revision 129813
Author rn...@webkit.org
Date 2012-09-27 16:23:53 -0700 (Thu, 27 Sep 2012)
Log Message
Results page should warn about time-dependent distributions
https://bugs.webkit.org/show_bug.cgi?id=97818
Reviewed by Ojan Vafai.
Add a simple linear regression analysis on results page to detect time-dependent distributions.
We add a warning sign (inline SVG) when the regression gave us a slope of at least 0.01 and a R^2 of at least 0.6.
Also added time-series graphs per run under the bar graphs so that humans can manually inspect them.
A nice follow up would be to add some normality test (e.g. Shapiro-Wilk) to detect bi-modal distributions
but we probably need to restructure the code to run it asynchronously since normality tests are slow.
* resources/results-template.html:
Modified Paths
trunk/PerformanceTests/ChangeLog
trunk/PerformanceTests/resources/results-template.html
Diff
Modified: trunk/PerformanceTests/ChangeLog (129812 => 129813)
--- trunk/PerformanceTests/ChangeLog 2012-09-27 23:05:03 UTC (rev 129812)
+++ trunk/PerformanceTests/ChangeLog 2012-09-27 23:23:53 UTC (rev 129813)
@@ -1,3 +1,19 @@
+2012-09-27 Ryosuke Niwa rn...@webkit.org
+
+Results page should warn about time-dependent distributions
+https://bugs.webkit.org/show_bug.cgi?id=97818
+
+Reviewed by Ojan Vafai.
+
+Add a simple linear regression analysis on results page to detect time-dependent distributions.
+We add a warning sign (inline SVG) when the regression gave us a slope of at least 0.01 and a R^2 of at least 0.6.
+Also added time-series graphs per run under the bar graphs so that humans can manually inspect them.
+
+A nice follow up would be to add some normality test (e.g. Shapiro-Wilk) to detect bi-modal distributions
+but we probably need to restructure the code to run it asynchronously since normality tests are slow.
+
+* resources/results-template.html:
+
2012-09-26 Ryosuke Niwa rn...@webkit.org
Use runPerSecond in PerformanceTests/Bindings/typed-array* and event-target-wrapper
Modified: trunk/PerformanceTests/resources/results-template.html (129812 => 129813)
--- trunk/PerformanceTests/resources/results-template.html 2012-09-27 23:05:03 UTC (rev 129812)
+++ trunk/PerformanceTests/resources/results-template.html 2012-09-27 23:23:53 UTC (rev 129813)
@@ -17,6 +17,17 @@
position: relative;
}
+.time-plots {
+padding-left: 25px;
+}
+
+.time-plots div {
+display: inline-block;
+width: 90px;
+height: 40px;
+margin-right: 10px;
+}
+
section h1 {
text-align: center;
font-size: 1em;
@@ -243,16 +254,26 @@
}
};
+var timePlotOptions = {
+yaxis: { show: false },
+xaxis: { show: false },
+lines: { show: true },
+grid: { borderWidth: 1, borderColor: '#ccc' },
+colors: ['#06f']
+};
+
function createPlot(container, test) {
-var section = $('sectiondiv class=plot/div'
+var section = $('sectiondiv class=plot/divdiv class=time-plots/div'
+ 'span class=tooltip/span/section');
-section.children('.plot').css({'width': 100 * test.results().length + 'px', 'height': '300px'});
+section.children('.plot').css({'width': (100 * test.results().length + 25) + 'px', 'height': '300px'});
$(container).append(section);
var plotContainer = section.children('.plot');
var minIsZero = true;
attachPlot(test, plotContainer, minIsZero);
+attachTimePlots(test, section.children('.time-plots'));
+
var tooltip = section.children('.tooltip');
plotContainer.bind('plothover', function (event, position, item) {
if (item) {
@@ -276,6 +297,24 @@
return section;
}
+function attachTimePlots(test, container) {
+var results = test.results();
+var attachedPlot = false;
+for (var i = 0; i results.length; i++) {
+container.append('div/div');
+var values = results[i].values();
+if (!values)
+continue;
+attachedPlot = true;
+
+$.plot(container.children().last(), [values.map(function (value, index) { return [index, value]; })],
+$.extend(true, {}, timePlotOptions, {yaxis: {min: Math.min.apply(Math, values) * 0.9, max: Math.max.apply(Math, values) * 1.1},
+xaxis: {min: -0.5, max: values.length - 0.5}}));
+}
+if (!attachedPlot)
+container.children().remove();
+}
+
function attachPlot(test, plotContainer, minIsZero) {
var results = test.results();
@@ -335,6 +374,44 @@
$('#container').tablesorter({widgets: ['zebra']});
}
+function linearRegression(points) {
+// Implement http://www.easycalculation.com/statistics/learn-correlation.php.
+// x = magnitude
+// y = iterations
+var sumX = 0;
+var sumY = 0;
+var sumXSquared = 0;
+var sumYSquared = 0;
+var sumXTimesY = 0;
+
+for (var i = 0; i points.length; i++) {
+var x = i;
+
[webkit-changes] [129814] trunk/Source/WebCore
Title: [129814] trunk/Source/WebCore
Revision 129814
Author le...@chromium.org
Date 2012-09-27 16:25:05 -0700 (Thu, 27 Sep 2012)
Log Message
REGRESSION(r129186): Pressing enter at the end of a line deletes the line
https://bugs.webkit.org/show_bug.cgi?id=97763
Reviewed by Ryosuke Niwa.
r129186 exposed incorrect behavior in RenderText whereby RenderText's lines were
dirtied but the renderer wasn't marked for layout. Rich text editing in GMail exposed
this behavior. RenderText::setTextWithOffset is called with a text string identical
to the current text. It still dirties lines, then calls setText, which has a check
for the case when the strings are the same and returns early and doesn't mark us as
needing layout.
This change adds the same early bailing logic in setText to setTextWithOffset, but
forces setText to work its magic whenever we dirty lines there (and avoid double-
checking that the strings are equal).
* rendering/RenderText.cpp:
(WebCore::RenderText::setTextWithOffset):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderText.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (129813 => 129814)
--- trunk/Source/WebCore/ChangeLog 2012-09-27 23:23:53 UTC (rev 129813)
+++ trunk/Source/WebCore/ChangeLog 2012-09-27 23:25:05 UTC (rev 129814)
@@ -1,3 +1,24 @@
+2012-09-27 Levi Weintraub le...@chromium.org
+
+REGRESSION(r129186): Pressing enter at the end of a line deletes the line
+https://bugs.webkit.org/show_bug.cgi?id=97763
+
+Reviewed by Ryosuke Niwa.
+
+r129186 exposed incorrect behavior in RenderText whereby RenderText's lines were
+dirtied but the renderer wasn't marked for layout. Rich text editing in GMail exposed
+this behavior. RenderText::setTextWithOffset is called with a text string identical
+to the current text. It still dirties lines, then calls setText, which has a check
+for the case when the strings are the same and returns early and doesn't mark us as
+needing layout.
+
+This change adds the same early bailing logic in setText to setTextWithOffset, but
+forces setText to work its magic whenever we dirty lines there (and avoid double-
+checking that the strings are equal).
+
+* rendering/RenderText.cpp:
+(WebCore::RenderText::setTextWithOffset):
+
2012-09-27 Andrew Lo a...@rim.com
requestAnimationFrame broken with subframes (DisplayRefreshMonitorManager::registerClient fails to register client)
Modified: trunk/Source/WebCore/rendering/RenderText.cpp (129813 => 129814)
--- trunk/Source/WebCore/rendering/RenderText.cpp 2012-09-27 23:23:53 UTC (rev 129813)
+++ trunk/Source/WebCore/rendering/RenderText.cpp 2012-09-27 23:25:05 UTC (rev 129814)
@@ -1256,6 +1256,9 @@
void RenderText::setTextWithOffset(PassRefPtrStringImpl text, unsigned offset, unsigned len, bool force)
{
+if (!force equal(m_text.impl(), text.get()))
+return;
+
unsigned oldLen = textLength();
unsigned newLen = text-length();
int delta = newLen - oldLen;
@@ -1328,7 +1331,7 @@
}
m_linesDirty = dirtiedLines;
-setText(text, force);
+setText(text, force || dirtiedLines);
}
void RenderText::transformText()
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [129815] trunk/Source
Title: [129815] trunk/Source Revision 129815 Author lforsch...@apple.com Date 2012-09-27 16:30:55 -0700 (Thu, 27 Sep 2012) Log Message Versioning. Modified Paths trunk/Source/_javascript_Core/Configurations/Version.xcconfig trunk/Source/WebCore/Configurations/Version.xcconfig trunk/Source/WebKit/mac/Configurations/Version.xcconfig trunk/Source/WebKit2/Configurations/Version.xcconfig Diff Modified: trunk/Source/_javascript_Core/Configurations/Version.xcconfig (129814 => 129815) --- trunk/Source/_javascript_Core/Configurations/Version.xcconfig 2012-09-27 23:25:05 UTC (rev 129814) +++ trunk/Source/_javascript_Core/Configurations/Version.xcconfig 2012-09-27 23:30:55 UTC (rev 129815) @@ -22,7 +22,7 @@ // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. MAJOR_VERSION = 537; -MINOR_VERSION = 12; +MINOR_VERSION = 13; TINY_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION); Modified: trunk/Source/WebCore/Configurations/Version.xcconfig (129814 => 129815) --- trunk/Source/WebCore/Configurations/Version.xcconfig 2012-09-27 23:25:05 UTC (rev 129814) +++ trunk/Source/WebCore/Configurations/Version.xcconfig 2012-09-27 23:30:55 UTC (rev 129815) @@ -22,7 +22,7 @@ // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. MAJOR_VERSION = 537; -MINOR_VERSION = 12; +MINOR_VERSION = 13; TINY_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION); Modified: trunk/Source/WebKit/mac/Configurations/Version.xcconfig (129814 => 129815) --- trunk/Source/WebKit/mac/Configurations/Version.xcconfig 2012-09-27 23:25:05 UTC (rev 129814) +++ trunk/Source/WebKit/mac/Configurations/Version.xcconfig 2012-09-27 23:30:55 UTC (rev 129815) @@ -22,7 +22,7 @@ // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. MAJOR_VERSION = 537; -MINOR_VERSION = 12; +MINOR_VERSION = 13; TINY_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION); Modified: trunk/Source/WebKit2/Configurations/Version.xcconfig (129814 => 129815) --- trunk/Source/WebKit2/Configurations/Version.xcconfig 2012-09-27 23:25:05 UTC (rev 129814) +++ trunk/Source/WebKit2/Configurations/Version.xcconfig 2012-09-27 23:30:55 UTC (rev 129815) @@ -22,7 +22,7 @@ // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. MAJOR_VERSION = 537; -MINOR_VERSION = 12; +MINOR_VERSION = 13; TINY_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION); ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [129816] trunk/PerformanceTests
Title: [129816] trunk/PerformanceTests
Revision 129816
Author rn...@webkit.org
Date 2012-09-27 16:35:44 -0700 (Thu, 27 Sep 2012)
Log Message
Unreviewed. Minor appearance tweaks after r129813.
* resources/results-template.html:
Modified Paths
trunk/PerformanceTests/ChangeLog
trunk/PerformanceTests/resources/results-template.html
Diff
Modified: trunk/PerformanceTests/ChangeLog (129815 => 129816)
--- trunk/PerformanceTests/ChangeLog 2012-09-27 23:30:55 UTC (rev 129815)
+++ trunk/PerformanceTests/ChangeLog 2012-09-27 23:35:44 UTC (rev 129816)
@@ -1,5 +1,11 @@
2012-09-27 Ryosuke Niwa rn...@webkit.org
+Unreviewed. Minor appearance tweaks after r129813.
+
+* resources/results-template.html:
+
+2012-09-27 Ryosuke Niwa rn...@webkit.org
+
Results page should warn about time-dependent distributions
https://bugs.webkit.org/show_bug.cgi?id=97818
Modified: trunk/PerformanceTests/resources/results-template.html (129815 => 129816)
--- trunk/PerformanceTests/resources/results-template.html 2012-09-27 23:30:55 UTC (rev 129815)
+++ trunk/PerformanceTests/resources/results-template.html 2012-09-27 23:35:44 UTC (rev 129816)
@@ -247,7 +247,8 @@
lines: { show: false },
points: { show: true },
grid: {
-borderWidth: 2,
+borderWidth: 1,
+borderColor: '#ccc',
backgroundColor: '#fff',
hoverable: true,
autoHighlight: false,
@@ -259,7 +260,7 @@
xaxis: { show: false },
lines: { show: true },
grid: { borderWidth: 1, borderColor: '#ccc' },
-colors: ['#06f']
+colors: [ plotColor ]
};
function createPlot(container, test) {
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [129817] trunk/PerformanceTests
Title: [129817] trunk/PerformanceTests
Revision 129817
Author rn...@webkit.org
Date 2012-09-27 16:39:09 -0700 (Thu, 27 Sep 2012)
Log Message
PerformanceTests/CSS/StyleSheetInsert.html has a time-dependent non-Gaussian distribution
https://bugs.webkit.org/show_bug.cgi?id=97741
Reviewed by Antti Koivisto.
Reset the content in the iframe in each run so that the runtime from each run follows a normal distribution.
We can cleanup this code once my patch to replace the argument list of run by an object is landed.
* CSS/StyleSheetInsert.html:
Modified Paths
trunk/PerformanceTests/CSS/StyleSheetInsert.html
trunk/PerformanceTests/ChangeLog
Diff
Modified: trunk/PerformanceTests/CSS/StyleSheetInsert.html (129816 => 129817)
--- trunk/PerformanceTests/CSS/StyleSheetInsert.html 2012-09-27 23:35:44 UTC (rev 129816)
+++ trunk/PerformanceTests/CSS/StyleSheetInsert.html 2012-09-27 23:39:09 UTC (rev 129817)
@@ -7,19 +7,28 @@
iframe/iframe
/body
script
-var frame = document.getElementsByTagName(iframe)[0];
-var testDoc = frame.contentDocument;
-var docText = ;
-docText += bodystyle.foo {color:red}/style;
-docText += div class='bar'Foo/div;
-for (var i = 0; i 1; ++i)
-docText += div class='foo'Foo/div;
-testDoc.body.innerHTML = docText;
+function setup() {
+var frame = document.getElementsByTagName(iframe)[0];
+var testDoc = frame.contentDocument;
+var docText = ;
+docText += bodystyle.foo {color:red}/style;
+docText += div class='bar'Foo/div;
+for (var i = 0; i 1; ++i)
+docText += div class='foo'Foo/div;
+testDoc.body.innerHTML = docText;
+return testDoc;
+}
+
PerfTestRunner.run(function() {
-var styleElem = testDoc.createElement(style);
-styleElem.innerText = .bar {color:green};
-testDoc.body.insertBefore(styleElem, testDoc.body.firstChild);
-}, 50, 10);
+var testDoc = setup();
+var start = PerfTestRunner.now();
+for (var i = 0; i 50; i++) {
+var styleElem = testDoc.createElement(style);
+styleElem.innerText = .bar {color:green};
+testDoc.body.insertBefore(styleElem, testDoc.body.firstChild);
+}
+return PerfTestRunner.now() - start;
+}, 1);
/script
/html
Modified: trunk/PerformanceTests/ChangeLog (129816 => 129817)
--- trunk/PerformanceTests/ChangeLog 2012-09-27 23:35:44 UTC (rev 129816)
+++ trunk/PerformanceTests/ChangeLog 2012-09-27 23:39:09 UTC (rev 129817)
@@ -1,5 +1,17 @@
2012-09-27 Ryosuke Niwa rn...@webkit.org
+PerformanceTests/CSS/StyleSheetInsert.html has a time-dependent non-Gaussian distribution
+https://bugs.webkit.org/show_bug.cgi?id=97741
+
+Reviewed by Antti Koivisto.
+
+Reset the content in the iframe in each run so that the runtime from each run follows a normal distribution.
+We can cleanup this code once my patch to replace the argument list of run by an object is landed.
+
+* CSS/StyleSheetInsert.html:
+
+2012-09-27 Ryosuke Niwa rn...@webkit.org
+
Unreviewed. Minor appearance tweaks after r129813.
* resources/results-template.html:
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [129818] branches/chromium/1229/Source/WebCore/rendering/RenderText.cpp
Title: [129818] branches/chromium/1229/Source/WebCore/rendering/RenderText.cpp
Revision 129818
Author le...@chromium.org
Date 2012-09-27 16:51:47 -0700 (Thu, 27 Sep 2012)
Log Message
Merge 129814 - REGRESSION(r129186): Pressing enter at the end of a line deletes the line
https://bugs.webkit.org/show_bug.cgi?id=97763
Reviewed by Ryosuke Niwa.
r129186 exposed incorrect behavior in RenderText whereby RenderText's lines were
dirtied but the renderer wasn't marked for layout. Rich text editing in GMail exposed
this behavior. RenderText::setTextWithOffset is called with a text string identical
to the current text. It still dirties lines, then calls setText, which has a check
for the case when the strings are the same and returns early and doesn't mark us as
needing layout.
This change adds the same early bailing logic in setText to setTextWithOffset, but
forces setText to work its magic whenever we dirty lines there (and avoid double-
checking that the strings are equal).
* rendering/RenderText.cpp:
(WebCore::RenderText::setTextWithOffset):
TBR=le...@chromium.org
Review URL: https://codereview.chromium.org/10993072
Modified Paths
branches/chromium/1229/Source/WebCore/rendering/RenderText.cpp
Diff
Modified: branches/chromium/1229/Source/WebCore/rendering/RenderText.cpp (129817 => 129818)
--- branches/chromium/1229/Source/WebCore/rendering/RenderText.cpp 2012-09-27 23:39:09 UTC (rev 129817)
+++ branches/chromium/1229/Source/WebCore/rendering/RenderText.cpp 2012-09-27 23:51:47 UTC (rev 129818)
@@ -1253,6 +1253,9 @@
void RenderText::setTextWithOffset(PassRefPtrStringImpl text, unsigned offset, unsigned len, bool force)
{
+if (!force equal(m_text.impl(), text.get()))
+return;
+
unsigned oldLen = textLength();
unsigned newLen = text-length();
int delta = newLen - oldLen;
@@ -1324,7 +1327,7 @@
}
m_linesDirty = dirtiedLines;
-setText(text, force);
+setText(text, force || dirtiedLines);
}
void RenderText::transformText()
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [129819] trunk/Source/WTF
Title: [129819] trunk/Source/WTF Revision 129819 Author ander...@apple.com Date 2012-09-27 16:57:06 -0700 (Thu, 27 Sep 2012) Log Message Remove the clang pragmas to disable warnings in Noncopyable.h https://bugs.webkit.org/show_bug.cgi?id=97826 Reviewed by Beth Dakin. Warnings about C++11 extensions are already disabled project-wide now so there's no need to keep these pragmas. * wtf/Noncopyable.h: Modified Paths trunk/Source/WTF/ChangeLog trunk/Source/WTF/wtf/Noncopyable.h Diff Modified: trunk/Source/WTF/ChangeLog (129818 => 129819) --- trunk/Source/WTF/ChangeLog 2012-09-27 23:51:47 UTC (rev 129818) +++ trunk/Source/WTF/ChangeLog 2012-09-27 23:57:06 UTC (rev 129819) @@ -1,3 +1,15 @@ +2012-09-27 Anders Carlsson ander...@apple.com + +Remove the clang pragmas to disable warnings in Noncopyable.h +https://bugs.webkit.org/show_bug.cgi?id=97826 + +Reviewed by Beth Dakin. + +Warnings about C++11 extensions are already disabled project-wide now so there's no need +to keep these pragmas. + +* wtf/Noncopyable.h: + 2012-09-26 Mark Hahnenberg mhahnenb...@apple.com Clean up HasTrivialConstructor/Destructor Modified: trunk/Source/WTF/wtf/Noncopyable.h (129818 => 129819) --- trunk/Source/WTF/wtf/Noncopyable.h 2012-09-27 23:51:47 UTC (rev 129818) +++ trunk/Source/WTF/wtf/Noncopyable.h 2012-09-27 23:57:06 UTC (rev 129819) @@ -25,13 +25,9 @@ #if COMPILER_SUPPORTS(CXX_DELETED_FUNCTIONS) #define WTF_MAKE_NONCOPYABLE(ClassName) \ -CLANG_PRAGMA(clang diagnostic push) \ -CLANG_PRAGMA(clang diagnostic ignored \-Wunknown-pragmas\) \ -CLANG_PRAGMA(clang diagnostic ignored \-Wc++0x-extensions\) \ private: \ ClassName(const ClassName) = delete; \ -ClassName operator=(const ClassName) = delete; \ -CLANG_PRAGMA(clang diagnostic pop) +ClassName operator=(const ClassName) = delete; #else #define WTF_MAKE_NONCOPYABLE(ClassName) \ private: \ ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [129820] trunk/LayoutTests
Title: [129820] trunk/LayoutTests Revision 129820 Author o...@chromium.org Date 2012-09-27 17:02:32 -0700 (Thu, 27 Sep 2012) Log Message Delete test that no longer exists. * platform/chromium/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (129819 => 129820) --- trunk/LayoutTests/ChangeLog 2012-09-27 23:57:06 UTC (rev 129819) +++ trunk/LayoutTests/ChangeLog 2012-09-28 00:02:32 UTC (rev 129820) @@ -1,3 +1,8 @@ +2012-09-27 Ojan Vafai o...@chromium.org + +Delete test that no longer exists. +* platform/chromium/TestExpectations: + 2012-09-27 Joshua Bell jsb...@chromium.org IndexedDB: Split up setVersion and deleteDatabase sequencing tests Modified: trunk/LayoutTests/platform/chromium/TestExpectations (129819 => 129820) --- trunk/LayoutTests/platform/chromium/TestExpectations 2012-09-27 23:57:06 UTC (rev 129819) +++ trunk/LayoutTests/platform/chromium/TestExpectations 2012-09-28 00:02:32 UTC (rev 129820) @@ -84,7 +84,6 @@ crbug.com/24182 storage/indexeddb/database-closepending-flag.html [ Pass Slow ] crbug.com/24182 storage/indexeddb/factory-basics-workers.html [ Pass Slow ] crbug.com/24182 storage/indexeddb/factory-basics.html [ Pass Slow ] -crbug.com/24182 storage/indexeddb/factory-deletedatabase-interactions.html [ Pass Slow ] crbug.com/24182 storage/indexeddb/intversion-and-setversion.html [ Pass Slow ] crbug.com/24182 storage/indexeddb/key-generator.html [ Pass Slow ] crbug.com/24182 storage/indexeddb/metadata.html [ Pass Slow ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [129821] trunk
Title: [129821] trunk
Revision 129821
Author commit-qu...@webkit.org
Date 2012-09-27 17:05:04 -0700 (Thu, 27 Sep 2012)
Log Message
Source/WebKit/chromium: Remove unused methods from Chromium WebKit API.
https://bugs.webkit.org/show_bug.cgi?id=95254
Patch by Nasko Oskov na...@chromium.org on 2012-09-27
Reviewed by Adam Barth.
Removing methods, which are no longer in use.
* public/WebFrame.h:
* public/WebFrameClient.h:
(WebKit::WebFrameClient::willCheckAndDispatchMessageEvent):
* src/WebFrameImpl.cpp:
* src/WebFrameImpl.h:
(WebFrameImpl):
Tools: Move DumpRenderTree to use newer version of the name method of
WebFrame and the willCheckAndDispatchMessageEvent method of WebFrameClient
https://bugs.webkit.org/show_bug.cgi?id=95254
Patch by Nasko Oskov na...@chromium.org on 2012-09-27
Reviewed by Adam Barth.
The WebFrame name() method is removed and replaced by better named
uniqueName() method, so DRT needs to be updated to use this new version.
Also the willCheckAndDispatchMessageEvent in WebFrameClient gained
one more parameter, which had to be added in DRT.
* DumpRenderTree/chromium/TestShell.cpp:
(dumpFramesAsText):
(dumpFramesAsPrintedText):
(dumpFrameScrollPosition):
* DumpRenderTree/chromium/WebViewHost.cpp:
(WebViewHost::unableToImplementPolicyWithError):
(WebViewHost::willCheckAndDispatchMessageEvent):
(WebViewHost::printFrameDescription):
* DumpRenderTree/chromium/WebViewHost.h:
(WebViewHost):
Modified Paths
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/public/WebFrame.h
trunk/Source/WebKit/chromium/public/WebFrameClient.h
trunk/Source/WebKit/chromium/src/WebFrameImpl.cpp
trunk/Source/WebKit/chromium/src/WebFrameImpl.h
trunk/Tools/ChangeLog
trunk/Tools/DumpRenderTree/chromium/TestShell.cpp
trunk/Tools/DumpRenderTree/chromium/WebViewHost.cpp
trunk/Tools/DumpRenderTree/chromium/WebViewHost.h
Diff
Modified: trunk/Source/WebKit/chromium/ChangeLog (129820 => 129821)
--- trunk/Source/WebKit/chromium/ChangeLog 2012-09-28 00:02:32 UTC (rev 129820)
+++ trunk/Source/WebKit/chromium/ChangeLog 2012-09-28 00:05:04 UTC (rev 129821)
@@ -1,3 +1,19 @@
+2012-09-27 Nasko Oskov na...@chromium.org
+
+Remove unused methods from Chromium WebKit API.
+https://bugs.webkit.org/show_bug.cgi?id=95254
+
+Reviewed by Adam Barth.
+
+Removing methods, which are no longer in use.
+
+* public/WebFrame.h:
+* public/WebFrameClient.h:
+(WebKit::WebFrameClient::willCheckAndDispatchMessageEvent):
+* src/WebFrameImpl.cpp:
+* src/WebFrameImpl.h:
+(WebFrameImpl):
+
2012-09-27 Mark Pilgrim pilg...@chromium.org
[Chromium][Mac] Move Mac-specific theme functions out of PlatformSupport
Modified: trunk/Source/WebKit/chromium/public/WebFrame.h (129820 => 129821)
--- trunk/Source/WebKit/chromium/public/WebFrame.h 2012-09-28 00:02:32 UTC (rev 129820)
+++ trunk/Source/WebKit/chromium/public/WebFrame.h 2012-09-28 00:05:04 UTC (rev 129821)
@@ -132,14 +132,7 @@
// Basic properties ---
-// The name of this frame.
-virtual WebString name() const = 0;
-
// The unique name of this frame.
-//
-// This is temporarily identical to the above name() function. Once this
-// change makes it over to the Chromium tree, I will change all callers to
-// use this function and will subsequently move assignedName() to name().
virtual WebString uniqueName() const = 0;
// The name of this frame. If no name is given, empty string is returned.
Modified: trunk/Source/WebKit/chromium/public/WebFrameClient.h (129820 => 129821)
--- trunk/Source/WebKit/chromium/public/WebFrameClient.h 2012-09-28 00:02:32 UTC (rev 129820)
+++ trunk/Source/WebKit/chromium/public/WebFrameClient.h 2012-09-28 00:05:04 UTC (rev 129821)
@@ -404,18 +404,10 @@
// gives the embedder a chance to handle it instead of WebKit. Returns true
// if the embedder handled it.
virtual bool willCheckAndDispatchMessageEvent(
-WebFrame* source,
-WebSecurityOrigin target,
-WebDOMMessageEvent) { return false; }
-
-virtual bool willCheckAndDispatchMessageEvent(
WebFrame* sourceFrame,
WebFrame* targetFrame,
WebSecurityOrigin target,
-WebDOMMessageEvent event)
-{
-return willCheckAndDispatchMessageEvent(sourceFrame, target, event);
-}
+WebDOMMessageEvent event) { return false; }
// Asks the embedder if a specific user agent should be used for the given
// URL. Non-empty strings indicate an override should be used. Otherwise,
Modified: trunk/Source/WebKit/chromium/src/WebFrameImpl.cpp (129820 => 129821)
--- trunk/Source/WebKit/chromium/src/WebFrameImpl.cpp 2012-09-28 00:02:32 UTC (rev 129820)
+++ trunk/Source/WebKit/chromium/src/WebFrameImpl.cpp 2012-09-28 00:05:04 UTC (rev 129821)
@@ -598,11 +598,6 @@
PassRefPtrElement(element).get());
}
-WebString
[webkit-changes] [129822] trunk/Source/WebCore
Title: [129822] trunk/Source/WebCore
Revision 129822
Author jsb...@chromium.org
Date 2012-09-27 17:07:11 -0700 (Thu, 27 Sep 2012)
Log Message
Unreviewed, rolling out r129806.
http://trac.webkit.org/changeset/129806
https://bugs.webkit.org/show_bug.cgi?id=97831
Broke windows build due to missing header (Requested by jsbell
on #webkit).
Patch by Sheriff Bot webkit.review@gmail.com on 2012-09-27
* Modules/indexeddb/IDBLevelDBCoding.cpp:
(WebCore::IDBLevelDBCoding::encodeString):
(WebCore::IDBLevelDBCoding::decodeString):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/indexeddb/IDBLevelDBCoding.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (129821 => 129822)
--- trunk/Source/WebCore/ChangeLog 2012-09-28 00:05:04 UTC (rev 129821)
+++ trunk/Source/WebCore/ChangeLog 2012-09-28 00:07:11 UTC (rev 129822)
@@ -1,3 +1,16 @@
+2012-09-27 Sheriff Bot webkit.review@gmail.com
+
+Unreviewed, rolling out r129806.
+http://trac.webkit.org/changeset/129806
+https://bugs.webkit.org/show_bug.cgi?id=97831
+
+Broke windows build due to missing header (Requested by jsbell
+on #webkit).
+
+* Modules/indexeddb/IDBLevelDBCoding.cpp:
+(WebCore::IDBLevelDBCoding::encodeString):
+(WebCore::IDBLevelDBCoding::decodeString):
+
2012-09-27 Levi Weintraub le...@chromium.org
REGRESSION(r129186): Pressing enter at the end of a line deletes the line
Modified: trunk/Source/WebCore/Modules/indexeddb/IDBLevelDBCoding.cpp (129821 => 129822)
--- trunk/Source/WebCore/Modules/indexeddb/IDBLevelDBCoding.cpp 2012-09-28 00:05:04 UTC (rev 129821)
+++ trunk/Source/WebCore/Modules/indexeddb/IDBLevelDBCoding.cpp 2012-09-28 00:07:11 UTC (rev 129822)
@@ -26,9 +26,6 @@
#include config.h
#include IDBLevelDBCoding.h
-// For htons/ntohs.
-#include arpa/inet.h
-
#if ENABLE(INDEXED_DATABASE)
#if USE(LEVELDB)
@@ -292,33 +289,36 @@
Vectorchar encodeString(const String s)
{
-// Backing store is UTF-16BE, convert from host endianness.
-size_t length = s.length();
-Vectorchar ret(length * sizeof(UChar));
+Vectorchar ret(s.length() * 2);
-const UChar* src = ""
-UChar* dst = reinterpret_castUChar*(ret.data());
-for (unsigned i = 0; i length; ++i)
-*dst++ = htons(*src++);
+for (unsigned i = 0; i s.length(); ++i) {
+UChar u = s[i];
+unsigned char hi = u 8;
+unsigned char lo = u;
+ret[2 * i] = hi;
+ret[2 * i + 1] = lo;
+}
return ret;
}
-String decodeString(const char* start, const char* end)
+String decodeString(const char* p, const char* end)
{
-// Backing store is UTF-16BE, convert to host endianness.
-ASSERT(end = start);
-ASSERT(!((end - start) % sizeof(UChar)));
+ASSERT(end = p);
+ASSERT(!((end - p) % 2));
-size_t length = (end - start) / sizeof(UChar);
-VectorUChar buffer(length);
+size_t len = (end - p) / 2;
+StringBuilder result;
+result.reserveCapacity(len);
-const UChar* src = "" UChar*(start);
-UChar* dst = buffer.data();
-for (unsigned i = 0; i length; ++i)
-*dst++ = ntohs(*src++);
+for (size_t i = 0; i len; ++i) {
+unsigned char hi = *p++;
+unsigned char lo = *p++;
-return String::adopt(buffer);
+result.append(static_castUChar((hi 8) | lo));
+}
+
+return result.toString();
}
Vectorchar encodeStringWithLength(const String s)
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [129823] trunk/Source/WebCore
Title: [129823] trunk/Source/WebCore
Revision 129823
Author ba...@chromium.org
Date 2012-09-27 17:13:34 -0700 (Thu, 27 Sep 2012)
Log Message
[Chromium] FontHarfBuzz.cpp should not use drawTextOnPath().
https://bugs.webkit.org/show_bug.cgi?id=97676
Reviewed by Tony Chang.
Use drawPosText() if possible for vertical text.
Use drawTextOnPath() only if the font doesn't have vhea/vmtx table.
No new tests. No change in behavior on LayoutTests.
Confirmed improvement in vertical text positioning using ipafont and Skia r5677.
* platform/graphics/harfbuzz/FontHarfBuzz.cpp:
(WebCore::drawVerticalTextWithBrokenIdeographs): Added.
(WebCore):
(WebCore::Font::drawGlyphs): Draw vertical text by drawPosText() in a similar manner of FontSkia.cpp.
(WebCore::Font::drawComplexText): Disable setVerticalText(). Complex path doesn't support it now.
* platform/graphics/harfbuzz/FontPlatformDataHarfBuzz.cpp:
(WebCore::FontPlatformData::setupPaint): Call setVertialText().
* platform/graphics/skia/SimpleFontDataSkia.cpp:
(WebCore::SimpleFontData::platformWidthForGlyph): Disable setVerticalText() if the font doesn't have vertical metrics.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/harfbuzz/FontHarfBuzz.cpp
trunk/Source/WebCore/platform/graphics/harfbuzz/FontPlatformDataHarfBuzz.cpp
trunk/Source/WebCore/platform/graphics/skia/SimpleFontDataSkia.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (129822 => 129823)
--- trunk/Source/WebCore/ChangeLog 2012-09-28 00:07:11 UTC (rev 129822)
+++ trunk/Source/WebCore/ChangeLog 2012-09-28 00:13:34 UTC (rev 129823)
@@ -1,3 +1,26 @@
+2012-09-27 Kenichi Ishibashi ba...@chromium.org
+
+[Chromium] FontHarfBuzz.cpp should not use drawTextOnPath().
+https://bugs.webkit.org/show_bug.cgi?id=97676
+
+Reviewed by Tony Chang.
+
+Use drawPosText() if possible for vertical text.
+Use drawTextOnPath() only if the font doesn't have vhea/vmtx table.
+
+No new tests. No change in behavior on LayoutTests.
+Confirmed improvement in vertical text positioning using ipafont and Skia r5677.
+
+* platform/graphics/harfbuzz/FontHarfBuzz.cpp:
+(WebCore::drawVerticalTextWithBrokenIdeographs): Added.
+(WebCore):
+(WebCore::Font::drawGlyphs): Draw vertical text by drawPosText() in a similar manner of FontSkia.cpp.
+(WebCore::Font::drawComplexText): Disable setVerticalText(). Complex path doesn't support it now.
+* platform/graphics/harfbuzz/FontPlatformDataHarfBuzz.cpp:
+(WebCore::FontPlatformData::setupPaint): Call setVertialText().
+* platform/graphics/skia/SimpleFontDataSkia.cpp:
+(WebCore::SimpleFontData::platformWidthForGlyph): Disable setVerticalText() if the font doesn't have vertical metrics.
+
2012-09-27 Sheriff Bot webkit.review@gmail.com
Unreviewed, rolling out r129806.
Modified: trunk/Source/WebCore/platform/graphics/harfbuzz/FontHarfBuzz.cpp (129822 => 129823)
--- trunk/Source/WebCore/platform/graphics/harfbuzz/FontHarfBuzz.cpp 2012-09-28 00:07:11 UTC (rev 129822)
+++ trunk/Source/WebCore/platform/graphics/harfbuzz/FontHarfBuzz.cpp 2012-09-28 00:13:34 UTC (rev 129823)
@@ -65,15 +65,81 @@
return false;
}
+static void drawVerticalTextWithBrokenIdeographs(GraphicsContext* gc, const SimpleFontData* font, const GlyphBuffer glyphBuffer, int from, int numGlyphs, const FloatPoint point)
+{
+const GlyphBufferAdvance* adv = glyphBuffer.advances(from);
+VectorSkPoint, 32 beginPoints(numGlyphs);
+VectorSkPoint, 32 endPoints(numGlyphs);
+SkScalar x = SkFloatToScalar(point.x());
+SkScalar y = SkFloatToScalar(point.y());
+
+for (int i = 0; i numGlyphs; ++i) {
+SkScalar width = SkFloatToScalar(adv[0].width());
+beginPoints[i].set(x + width, y);
+endPoints[i].set(x + width, y - width);
+x += SkFloatToScalar(width);
+y += SkFloatToScalar(adv[i].height());
+}
+
+SkCanvas* canvas = gc-platformContext()-canvas();
+const GlyphBufferGlyph* glyphs = glyphBuffer.glyphs(from);
+TextDrawingModeFlags textMode = gc-platformContext()-getTextDrawingMode();
+
+if (textMode TextModeFill) {
+SkPaint paint;
+gc-platformContext()-setupPaintForFilling(paint);
+font-platformData().setupPaint(paint);
+gc-platformContext()-adjustTextRenderMode(paint);
+paint.setTextEncoding(SkPaint::kGlyphID_TextEncoding);
+
+SkPath path;
+for (int i = 0; i numGlyphs; ++i) {
+path.reset();
+path.moveTo(beginPoints[i]);
+path.lineTo(endPoints[i]);
+canvas-drawTextOnPath(glyphs + i, sizeof(GlyphBufferGlyph), path, 0, paint);
+}
+}
+
+if ((textMode TextModeStroke)
+ gc-platformContext()-getStrokeStyle() != NoStroke
+ gc-platformContext()-getStrokeThickness() 0) {
+SkPaint paint;
+
[webkit-changes] [129824] trunk/PerformanceTests
Title: [129824] trunk/PerformanceTests
Revision 129824
Author rn...@webkit.org
Date 2012-09-27 17:26:14 -0700 (Thu, 27 Sep 2012)
Log Message
PerfTestRunner.run should take an object
https://bugs.webkit.org/show_bug.cgi?id=97743
Reviewed by Kentaro Hara.
Rename PerfTestRunner.run to PerfTestRunner.measureTime and make it take an object instead of
5 arguments. Also get rid of PerfTestRunner._loopsPerRun since it's no longer used (it's always 1).
* CSS/StyleSheetInsert.html:
* DOM/resources/dom-perf.js:
* Layout/floats_100_100.html:
* Layout/floats_100_100_nested.html:
* Layout/floats_20_100.html:
* Layout/floats_20_100_nested.html:
* Layout/floats_2_100.html:
* Layout/floats_2_100_nested.html:
* Layout/floats_50_100.html:
* Layout/floats_50_100_nested.html:
* Parser/html-parser.html:
* Parser/html5-full-render.html:
* SVG/SvgCubics.html:
* SVG/SvgHitTesting.html:
* resources/runner.js:
Modified Paths
trunk/PerformanceTests/CSS/StyleSheetInsert.html
trunk/PerformanceTests/ChangeLog
trunk/PerformanceTests/DOM/resources/dom-perf.js
trunk/PerformanceTests/Layout/floats_100_100.html
trunk/PerformanceTests/Layout/floats_100_100_nested.html
trunk/PerformanceTests/Layout/floats_20_100.html
trunk/PerformanceTests/Layout/floats_20_100_nested.html
trunk/PerformanceTests/Layout/floats_2_100.html
trunk/PerformanceTests/Layout/floats_2_100_nested.html
trunk/PerformanceTests/Layout/floats_50_100.html
trunk/PerformanceTests/Layout/floats_50_100_nested.html
trunk/PerformanceTests/Parser/html-parser.html
trunk/PerformanceTests/Parser/html5-full-render.html
trunk/PerformanceTests/SVG/SvgCubics.html
trunk/PerformanceTests/SVG/SvgHitTesting.html
trunk/PerformanceTests/resources/runner.js
Diff
Modified: trunk/PerformanceTests/CSS/StyleSheetInsert.html (129823 => 129824)
--- trunk/PerformanceTests/CSS/StyleSheetInsert.html 2012-09-28 00:13:34 UTC (rev 129823)
+++ trunk/PerformanceTests/CSS/StyleSheetInsert.html 2012-09-28 00:26:14 UTC (rev 129824)
@@ -20,7 +20,7 @@
return testDoc;
}
-PerfTestRunner.run(function() {
+PerfTestRunner.measureTime({run:function() {
var testDoc = setup();
var start = PerfTestRunner.now();
for (var i = 0; i 50; i++) {
@@ -29,6 +29,6 @@
testDoc.body.insertBefore(styleElem, testDoc.body.firstChild);
}
return PerfTestRunner.now() - start;
-}, 1);
+}});
/script
/html
Modified: trunk/PerformanceTests/ChangeLog (129823 => 129824)
--- trunk/PerformanceTests/ChangeLog 2012-09-28 00:13:34 UTC (rev 129823)
+++ trunk/PerformanceTests/ChangeLog 2012-09-28 00:26:14 UTC (rev 129824)
@@ -1,5 +1,31 @@
2012-09-27 Ryosuke Niwa rn...@webkit.org
+PerfTestRunner.run should take an object
+https://bugs.webkit.org/show_bug.cgi?id=97743
+
+Reviewed by Kentaro Hara.
+
+Rename PerfTestRunner.run to PerfTestRunner.measureTime and make it take an object instead of
+5 arguments. Also get rid of PerfTestRunner._loopsPerRun since it's no longer used (it's always 1).
+
+* CSS/StyleSheetInsert.html:
+* DOM/resources/dom-perf.js:
+* Layout/floats_100_100.html:
+* Layout/floats_100_100_nested.html:
+* Layout/floats_20_100.html:
+* Layout/floats_20_100_nested.html:
+* Layout/floats_2_100.html:
+* Layout/floats_2_100_nested.html:
+* Layout/floats_50_100.html:
+* Layout/floats_50_100_nested.html:
+* Parser/html-parser.html:
+* Parser/html5-full-render.html:
+* SVG/SvgCubics.html:
+* SVG/SvgHitTesting.html:
+* resources/runner.js:
+
+2012-09-27 Ryosuke Niwa rn...@webkit.org
+
PerformanceTests/CSS/StyleSheetInsert.html has a time-dependent non-Gaussian distribution
https://bugs.webkit.org/show_bug.cgi?id=97741
Modified: trunk/PerformanceTests/DOM/resources/dom-perf.js (129823 => 129824)
--- trunk/PerformanceTests/DOM/resources/dom-perf.js 2012-09-28 00:13:34 UTC (rev 129823)
+++ trunk/PerformanceTests/DOM/resources/dom-perf.js 2012-09-28 00:26:14 UTC (rev 129824)
@@ -331,7 +331,7 @@
};
function runBenchmarkSuite(suite, runCount) {
-PerfTestRunner.run(function () {
+PerfTestRunner.measureTime({run: function () {
var container = document.getElementById('container');
var content = document.getElementById('benchmark_content');
suite.benchmarkContentHolder = container;
@@ -345,7 +345,9 @@
totalMeanTime += result.mean;
}
return totalMeanTime;
-}, 1, runCount || 20, function () {
+},
+runCount: runCount,
+done: function () {
var container = document.getElementById('container');
if (container.firstChild)
container.removeChild(container.firstChild);
Modified: trunk/PerformanceTests/Layout/floats_100_100.html (129823 => 129824)
--- trunk/PerformanceTests/Layout/floats_100_100.html 2012-09-28 00:13:34 UTC (rev 129823)
+++ trunk/PerformanceTests/Layout/floats_100_100.html
[webkit-changes] [129825] trunk/Source
Title: [129825] trunk/Source Revision 129825 Author pilg...@chromium.org Date 2012-09-27 17:31:12 -0700 (Thu, 27 Sep 2012) Log Message [Chromium] Remove screen-related functions from PlatformSupport https://bugs.webkit.org/show_bug.cgi?id=97474 Reviewed by Adam Barth. Source/Platform: Screen-related functions like screenHorizontalDPI that used to be on PlatformSupport are now accessed through a new PlatformPageClient attached to Widget in WebCore-land, which is implemented by ChromeClientImpl in WebKit-land, which proxies calls to WebWidgetClient, which is actually implemented in Chromium-land. * Platform.gypi: * chromium/public/WebScreenInfo.h: Added. (WebKit): (WebScreenInfo): (WebKit::WebScreenInfo::WebScreenInfo): Source/WebCore: Part of a refactoring series. See tracking bug 82948. Screen-related functions like screenHorizontalDPI that used to be on PlatformSupport are now accessed through a new PlatformPageClient attached to Widget in WebCore-land, which is implemented by ChromeClientImpl in WebKit-land, which proxies calls to WebWidgetClient, which is actually implemented in Chromium-land. * WebCore.gypi: * platform/Widget.h: * platform/chromium/PageClientChromium.h: Copied from Source/WebCore/platform/chromium/PlatformWidget.h. (PageClientChromium): * platform/chromium/PlatformScreenChromium.cpp: (WebCore::toPlatformPageClient): (WebCore): (WebCore::screenHorizontalDPI): (WebCore::screenVerticalDPI): (WebCore::screenDepth): (WebCore::screenDepthPerComponent): (WebCore::screenIsMonochrome): (WebCore::screenRect): (WebCore::screenAvailableRect): * platform/chromium/PlatformSupport.h: (PlatformSupport): Source/WebKit/chromium: Screen-related functions like screenHorizontalDPI that used to be on PlatformSupport are now accessed through a new PlatformPageClient attached to Widget in WebCore-land, which is implemented by ChromeClientImpl in WebKit-land, which proxies calls to WebWidgetClient, which is actually implemented in Chromium-land. * public/WebScreenInfo.h: * src/ChromeClientImpl.cpp: (WebKit::ChromeClientImpl::screenInfo): (WebKit): * src/ChromeClientImpl.h: (WebKit): (WebKit::ChromeClientImpl::platformPageClient): (ChromeClientImpl): * src/PlatformSupport.cpp: (WebCore): Modified Paths trunk/Source/Platform/ChangeLog trunk/Source/Platform/Platform.gypi trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/WebCore.gypi trunk/Source/WebCore/platform/Widget.h trunk/Source/WebCore/platform/chromium/PlatformScreenChromium.cpp trunk/Source/WebCore/platform/chromium/PlatformSupport.h trunk/Source/WebKit/chromium/ChangeLog trunk/Source/WebKit/chromium/public/WebScreenInfo.h trunk/Source/WebKit/chromium/src/ChromeClientImpl.cpp trunk/Source/WebKit/chromium/src/ChromeClientImpl.h trunk/Source/WebKit/chromium/src/PlatformSupport.cpp Added Paths trunk/Source/Platform/chromium/public/WebScreenInfo.h trunk/Source/WebCore/platform/chromium/PageClientChromium.h Diff Modified: trunk/Source/Platform/ChangeLog (129824 => 129825) --- trunk/Source/Platform/ChangeLog 2012-09-28 00:26:14 UTC (rev 129824) +++ trunk/Source/Platform/ChangeLog 2012-09-28 00:31:12 UTC (rev 129825) @@ -1,3 +1,23 @@ +2012-09-27 Mark Pilgrim pilg...@chromium.org + +[Chromium] Remove screen-related functions from PlatformSupport +https://bugs.webkit.org/show_bug.cgi?id=97474 + +Reviewed by Adam Barth. + +Screen-related functions like screenHorizontalDPI that +used to be on PlatformSupport are now accessed through a new +PlatformPageClient attached to Widget in WebCore-land, which is +implemented by ChromeClientImpl in WebKit-land, which proxies +calls to WebWidgetClient, which is actually implemented in +Chromium-land. + +* Platform.gypi: +* chromium/public/WebScreenInfo.h: Added. +(WebKit): +(WebScreenInfo): +(WebKit::WebScreenInfo::WebScreenInfo): + 2012-09-27 Tommy Widenflycht tom...@google.com MediaStream API: Enhance MediaConstraints to make it easier to get the constraint data Modified: trunk/Source/Platform/Platform.gypi (129824 => 129825) --- trunk/Source/Platform/Platform.gypi 2012-09-28 00:26:14 UTC (rev 129824) +++ trunk/Source/Platform/Platform.gypi 2012-09-28 00:31:12 UTC (rev 129825) @@ -116,6 +116,7 @@ 'chromium/public/WebRect.h', 'chromium/public/WebReferrerPolicy.h', 'chromium/public/WebRenderingStats.h', +'chromium/public/WebScreenInfo.h', 'chromium/public/WebScrollbar.h', 'chromium/public/WebScrollbarLayer.h', 'chromium/public/WebScrollbarThemeGeometry.h', Copied: trunk/Source/Platform/chromium/public/WebScreenInfo.h (from rev 129824, trunk/Source/WebKit/chromium/public/WebScreenInfo.h) (0 => 129825) --- trunk/Source/Platform/chromium/public/WebScreenInfo.h (rev 0) +++ trunk/Source/Platform/chromium/public/WebScreenInfo.h 2012-09-28 00:31:12 UTC (rev
[webkit-changes] [129827] trunk/Source/JavaScriptCore
Title: [129827] trunk/Source/_javascript_Core
Revision 129827
Author mark@apple.com
Date 2012-09-27 17:50:34 -0700 (Thu, 27 Sep 2012)
Log Message
Fixed CallFrameClosure::resetCallFrame() to use the valid
range of argument index values.
https://bugs.webkit.org/show_bug.cgi?id=97836.
Reviewed by Gavin Barraclough.
* interpreter/CallFrame.h:
(ExecState):
* interpreter/CallFrameClosure.h:
(JSC::CallFrameClosure::resetCallFrame):
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/interpreter/CallFrame.h
trunk/Source/_javascript_Core/interpreter/CallFrameClosure.h
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (129826 => 129827)
--- trunk/Source/_javascript_Core/ChangeLog 2012-09-28 00:46:53 UTC (rev 129826)
+++ trunk/Source/_javascript_Core/ChangeLog 2012-09-28 00:50:34 UTC (rev 129827)
@@ -1,3 +1,16 @@
+2012-09-27 Mark Lam mark@apple.com
+
+Fixed CallFrameClosure::resetCallFrame() to use the valid
+range of argument index values.
+https://bugs.webkit.org/show_bug.cgi?id=97836.
+
+Reviewed by Gavin Barraclough.
+
+* interpreter/CallFrame.h:
+(ExecState):
+* interpreter/CallFrameClosure.h:
+(JSC::CallFrameClosure::resetCallFrame):
+
2012-09-27 Patrick Gansterer par...@webkit.org
Fix usage of COMPILER() macros
Modified: trunk/Source/_javascript_Core/interpreter/CallFrame.h (129826 => 129827)
--- trunk/Source/_javascript_Core/interpreter/CallFrame.h 2012-09-28 00:46:53 UTC (rev 129826)
+++ trunk/Source/_javascript_Core/interpreter/CallFrame.h 2012-09-28 00:50:34 UTC (rev 129827)
@@ -190,6 +190,15 @@
static int argumentOffset(int argument) { return s_firstArgumentOffset - argument; }
static int argumentOffsetIncludingThis(int argument) { return s_thisArgumentOffset - argument; }
+// In the following (argument() and setArgument()), the 'argument'
+// parameter is the index of the arguments of the target function of
+// this frame. The index starts at 0 for the first arg, 1 for the
+// second, etc.
+//
+// The arguments (in this case) do not include the 'this' value.
+// arguments(0) will not fetch the 'this' value. To get/set 'this',
+// use thisValue() and setThisValue() below.
+
JSValue argument(size_t argument)
{
if (argument = argumentCount())
Modified: trunk/Source/_javascript_Core/interpreter/CallFrameClosure.h (129826 => 129827)
--- trunk/Source/_javascript_Core/interpreter/CallFrameClosure.h 2012-09-28 00:46:53 UTC (rev 129826)
+++ trunk/Source/_javascript_Core/interpreter/CallFrameClosure.h 2012-09-28 00:50:34 UTC (rev 129827)
@@ -52,7 +52,11 @@
void resetCallFrame()
{
newCallFrame-setScope(scope);
-for (int i = argumentCountIncludingThis; i parameterCountIncludingThis; ++i)
+// setArgument() takes an arg index that starts from 0 for the first
+// argument after the 'this' value. Since both argumentCountIncludingThis
+// and parameterCountIncludingThis includes the 'this' value, we need to
+// subtract 1 from them to make i a valid argument index for setArgument().
+for (int i = argumentCountIncludingThis-1; i parameterCountIncludingThis-1; ++i)
newCallFrame-setArgument(i, jsUndefined());
}
};
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [129828] trunk/Source/WebKit
Title: [129828] trunk/Source/WebKit
Revision 129828
Author ander...@apple.com
Date 2012-09-27 17:51:06 -0700 (Thu, 27 Sep 2012)
Log Message
Get rid of more unused WK1 plug-in code
https://bugs.webkit.org/show_bug.cgi?id=97835
Reviewed by Mark Rowe.
Source/WebKit:
Remove WebNetscapeDeprecatedFunctions.c and WebNetscapeDeprecatedFunctions.h from the Xcode project.
* WebKit.xcodeproj/project.pbxproj:
Source/WebKit/mac:
* Plugins/WebBasePluginPackage.mm:
Remove JavaCFMPluginFilename #define.
(-[WebBasePluginPackage initWithPath:]):
#ifndef __ppc__ is always true now.
(-[WebBasePluginPackage isJavaPlugIn]):
Remove JavaCFMPluginFilename.
* Plugins/WebNetscapeDeprecatedFunctions.c: Removed.
* Plugins/WebNetscapeDeprecatedFunctions.h: Removed.
Remove functions that nobody calls anymore.
* Plugins/WebNetscapePluginPackage.mm:
Remove +initialize call, the earliest version of Shockwave we now support doesn't
require us to have a valid CurApRefNum file anymore.
(-[WebNetscapePluginPackage _tryLoad]):
Remove more unused code.
* Plugins/WebPluginDatabase.h:
Remove CFM from a comment.
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/WebKit.xcodeproj/project.pbxproj
trunk/Source/WebKit/mac/ChangeLog
trunk/Source/WebKit/mac/Plugins/WebBasePluginPackage.mm
trunk/Source/WebKit/mac/Plugins/WebNetscapePluginPackage.mm
trunk/Source/WebKit/mac/Plugins/WebPluginDatabase.h
Removed Paths
trunk/Source/WebKit/mac/Plugins/WebNetscapeDeprecatedFunctions.c
trunk/Source/WebKit/mac/Plugins/WebNetscapeDeprecatedFunctions.h
Diff
Modified: trunk/Source/WebKit/ChangeLog (129827 => 129828)
--- trunk/Source/WebKit/ChangeLog 2012-09-28 00:50:34 UTC (rev 129827)
+++ trunk/Source/WebKit/ChangeLog 2012-09-28 00:51:06 UTC (rev 129828)
@@ -1,3 +1,14 @@
+2012-09-27 Anders Carlsson ander...@apple.com
+
+Get rid of more unused WK1 plug-in code
+https://bugs.webkit.org/show_bug.cgi?id=97835
+
+Reviewed by Mark Rowe.
+
+Remove WebNetscapeDeprecatedFunctions.c and WebNetscapeDeprecatedFunctions.h from the Xcode project.
+
+* WebKit.xcodeproj/project.pbxproj:
+
2012-09-27 Christophe Dumez christophe.du...@intel.com
[EFL][CMAKE] Default theme files are outdated in PlatformEfl.cmake
Modified: trunk/Source/WebKit/WebKit.xcodeproj/project.pbxproj (129827 => 129828)
--- trunk/Source/WebKit/WebKit.xcodeproj/project.pbxproj 2012-09-28 00:50:34 UTC (rev 129827)
+++ trunk/Source/WebKit/WebKit.xcodeproj/project.pbxproj 2012-09-28 00:51:06 UTC (rev 129828)
@@ -70,8 +70,6 @@
224100F3091818D900D2D266 /* WebPluginsPrivate.h in Headers */ = {isa = PBXBuildFile; fileRef = 224100F2091818D900D2D266 /* WebPluginsPrivate.h */; settings = {ATTRIBUTES = (Private, ); }; };
224100F90918190100D2D266 /* WebPluginsPrivate.m in Sources */ = {isa = PBXBuildFile; fileRef = 224100F80918190100D2D266 /* WebPluginsPrivate.m */; };
225F881509F97E8A00423A40 /* WebPluginPrivate.h in Headers */ = {isa = PBXBuildFile; fileRef = 225F881409F97E8A00423A40 /* WebPluginPrivate.h */; settings = {ATTRIBUTES = (Private, ); }; };
- 226E9E6A09D0AA8200F3A2BC /* WebNetscapeDeprecatedFunctions.h in Headers */ = {isa = PBXBuildFile; fileRef = 226E9E6809D0AA8200F3A2BC /* WebNetscapeDeprecatedFunctions.h */; };
- 226E9E6B09D0AA8200F3A2BC /* WebNetscapeDeprecatedFunctions.c in Sources */ = {isa = PBXBuildFile; fileRef = 226E9E6909D0AA8200F3A2BC /* WebNetscapeDeprecatedFunctions.c */; settings = {COMPILER_FLAGS = -Wno-deprecated-declarations; }; };
22F219CC08D236730030E078 /* WebBackForwardListPrivate.h in Headers */ = {isa = PBXBuildFile; fileRef = 22F219CB08D236730030E078 /* WebBackForwardListPrivate.h */; settings = {ATTRIBUTES = (Private, ); }; };
29AEF960134C76FB00FE5096 /* OutlookQuirksUserScript.js in Resources */ = {isa = PBXBuildFile; fileRef = 29AEF95D134C755400FE5096 /* OutlookQuirksUserScript.js */; };
312E2FE514E48182007CCA18 /* WebNotification.h in Headers */ = {isa = PBXBuildFile; fileRef = 312E2FE314E48182007CCA18 /* WebNotification.h */; settings = {ATTRIBUTES = (Private, ); }; };
@@ -455,8 +453,6 @@
224100F2091818D900D2D266 /* WebPluginsPrivate.h */ = {isa = PBXFileReference; fileEncoding = 4; indentWidth = 4; lastKnownFileType = sourcecode.c.h; path = WebPluginsPrivate.h; sourceTree = group; tabWidth = 8; usesTabs = 0; };
224100F80918190100D2D266 /* WebPluginsPrivate.m */ = {isa = PBXFileReference; fileEncoding = 4; indentWidth = 4; lastKnownFileType = sourcecode.c.objc; path = WebPluginsPrivate.m; sourceTree = group; tabWidth = 8; usesTabs = 0; };
225F881409F97E8A00423A40 /* WebPluginPrivate.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = WebPluginPrivate.h; sourceTree = group; };
- 226E9E6809D0AA8200F3A2BC /* WebNetscapeDeprecatedFunctions.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = WebNetscapeDeprecatedFunctions.h; sourceTree = group; };
-
[webkit-changes] [129829] trunk/Source/WebCore
Title: [129829] trunk/Source/WebCore
Revision 129829
Author commit-qu...@webkit.org
Date 2012-09-27 18:16:06 -0700 (Thu, 27 Sep 2012)
Log Message
Unreviewed, rolling out r129823.
http://trac.webkit.org/changeset/129823
https://bugs.webkit.org/show_bug.cgi?id=97837
Cause a bunch of pixel failures on Chrome Linux that look like
real regressions (Requested by ojan on #webkit).
Patch by Sheriff Bot webkit.review@gmail.com on 2012-09-27
* platform/graphics/harfbuzz/FontHarfBuzz.cpp:
(WebCore::Font::drawGlyphs):
(WebCore::Font::drawComplexText):
* platform/graphics/harfbuzz/FontPlatformDataHarfBuzz.cpp:
(WebCore::FontPlatformData::setupPaint):
* platform/graphics/skia/SimpleFontDataSkia.cpp:
(WebCore::SimpleFontData::platformWidthForGlyph):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/harfbuzz/FontHarfBuzz.cpp
trunk/Source/WebCore/platform/graphics/harfbuzz/FontPlatformDataHarfBuzz.cpp
trunk/Source/WebCore/platform/graphics/skia/SimpleFontDataSkia.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (129828 => 129829)
--- trunk/Source/WebCore/ChangeLog 2012-09-28 00:51:06 UTC (rev 129828)
+++ trunk/Source/WebCore/ChangeLog 2012-09-28 01:16:06 UTC (rev 129829)
@@ -1,3 +1,20 @@
+2012-09-27 Sheriff Bot webkit.review@gmail.com
+
+Unreviewed, rolling out r129823.
+http://trac.webkit.org/changeset/129823
+https://bugs.webkit.org/show_bug.cgi?id=97837
+
+Cause a bunch of pixel failures on Chrome Linux that look like
+real regressions (Requested by ojan on #webkit).
+
+* platform/graphics/harfbuzz/FontHarfBuzz.cpp:
+(WebCore::Font::drawGlyphs):
+(WebCore::Font::drawComplexText):
+* platform/graphics/harfbuzz/FontPlatformDataHarfBuzz.cpp:
+(WebCore::FontPlatformData::setupPaint):
+* platform/graphics/skia/SimpleFontDataSkia.cpp:
+(WebCore::SimpleFontData::platformWidthForGlyph):
+
2012-09-27 Mark Pilgrim pilg...@chromium.org
[Chromium] Remove screen-related functions from PlatformSupport
Modified: trunk/Source/WebCore/platform/graphics/harfbuzz/FontHarfBuzz.cpp (129828 => 129829)
--- trunk/Source/WebCore/platform/graphics/harfbuzz/FontHarfBuzz.cpp 2012-09-28 00:51:06 UTC (rev 129828)
+++ trunk/Source/WebCore/platform/graphics/harfbuzz/FontHarfBuzz.cpp 2012-09-28 01:16:06 UTC (rev 129829)
@@ -65,81 +65,15 @@
return false;
}
-static void drawVerticalTextWithBrokenIdeographs(GraphicsContext* gc, const SimpleFontData* font, const GlyphBuffer glyphBuffer, int from, int numGlyphs, const FloatPoint point)
-{
-const GlyphBufferAdvance* adv = glyphBuffer.advances(from);
-VectorSkPoint, 32 beginPoints(numGlyphs);
-VectorSkPoint, 32 endPoints(numGlyphs);
-SkScalar x = SkFloatToScalar(point.x());
-SkScalar y = SkFloatToScalar(point.y());
-
-for (int i = 0; i numGlyphs; ++i) {
-SkScalar width = SkFloatToScalar(adv[0].width());
-beginPoints[i].set(x + width, y);
-endPoints[i].set(x + width, y - width);
-x += SkFloatToScalar(width);
-y += SkFloatToScalar(adv[i].height());
-}
-
-SkCanvas* canvas = gc-platformContext()-canvas();
-const GlyphBufferGlyph* glyphs = glyphBuffer.glyphs(from);
-TextDrawingModeFlags textMode = gc-platformContext()-getTextDrawingMode();
-
-if (textMode TextModeFill) {
-SkPaint paint;
-gc-platformContext()-setupPaintForFilling(paint);
-font-platformData().setupPaint(paint);
-gc-platformContext()-adjustTextRenderMode(paint);
-paint.setTextEncoding(SkPaint::kGlyphID_TextEncoding);
-
-SkPath path;
-for (int i = 0; i numGlyphs; ++i) {
-path.reset();
-path.moveTo(beginPoints[i]);
-path.lineTo(endPoints[i]);
-canvas-drawTextOnPath(glyphs + i, sizeof(GlyphBufferGlyph), path, 0, paint);
-}
-}
-
-if ((textMode TextModeStroke)
- gc-platformContext()-getStrokeStyle() != NoStroke
- gc-platformContext()-getStrokeThickness() 0) {
-SkPaint paint;
-gc-platformContext()-setupPaintForStroking(paint, 0, 0);
-font-platformData().setupPaint(paint);
-gc-platformContext()-adjustTextRenderMode(paint);
-paint.setTextEncoding(SkPaint::kGlyphID_TextEncoding);
-
-if (textMode TextModeFill)
-paint.setLooper(0);
-
-SkPath path;
-for (int i = 0; i numGlyphs; ++i) {
-path.reset();
-path.moveTo(beginPoints[i]);
-path.lineTo(endPoints[i]);
-canvas-drawTextOnPath(glyphs + i, sizeof(GlyphBufferGlyph), path, 0, paint);
-}
-}
-}
-
void Font::drawGlyphs(GraphicsContext* gc, const SimpleFontData* font,
const GlyphBuffer glyphBuffer, int from, int numGlyphs,
const FloatPoint point) const {
SkASSERT(sizeof(GlyphBufferGlyph) == sizeof(uint16_t)); //
[webkit-changes] [129830] trunk/Source/JavaScriptCore
Title: [129830] trunk/Source/_javascript_Core Revision 129830 Author mark@apple.com Date 2012-09-27 18:43:52 -0700 (Thu, 27 Sep 2012) Log Message Put initializeHostCallReturnValue() behind #if ENABLE(JIT). Fixes non JIT builds. https://bugs.webkit.org/show_bug.cgi?id=97838. Reviewed by John Sullivan. * runtime/JSGlobalData.cpp: (JSC::JSGlobalData::JSGlobalData): Modified Paths trunk/Source/_javascript_Core/ChangeLog trunk/Source/_javascript_Core/runtime/JSGlobalData.cpp Diff Modified: trunk/Source/_javascript_Core/ChangeLog (129829 => 129830) --- trunk/Source/_javascript_Core/ChangeLog 2012-09-28 01:16:06 UTC (rev 129829) +++ trunk/Source/_javascript_Core/ChangeLog 2012-09-28 01:43:52 UTC (rev 129830) @@ -1,5 +1,16 @@ 2012-09-27 Mark Lam mark@apple.com +Put initializeHostCallReturnValue() behind #if ENABLE(JIT). +Fixes non JIT builds. +https://bugs.webkit.org/show_bug.cgi?id=97838. + +Reviewed by John Sullivan. + +* runtime/JSGlobalData.cpp: +(JSC::JSGlobalData::JSGlobalData): + +2012-09-27 Mark Lam mark@apple.com + Fixed CallFrameClosure::resetCallFrame() to use the valid range of argument index values. https://bugs.webkit.org/show_bug.cgi?id=97836. Modified: trunk/Source/_javascript_Core/runtime/JSGlobalData.cpp (129829 => 129830) --- trunk/Source/_javascript_Core/runtime/JSGlobalData.cpp 2012-09-28 01:16:06 UTC (rev 129829) +++ trunk/Source/_javascript_Core/runtime/JSGlobalData.cpp 2012-09-28 01:43:52 UTC (rev 129830) @@ -231,7 +231,9 @@ interpreter-initialize(this-canUseJIT()); +#if ENABLE(JIT) initializeHostCallReturnValue(); // This is needed to convince the linker not to drop host call return support. +#endif heap.notifyIsSafeToCollect(); ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [129831] trunk/Source/WebCore
Title: [129831] trunk/Source/WebCore
Revision 129831
Author macpher...@chromium.org
Date 2012-09-27 19:16:38 -0700 (Thu, 27 Sep 2012)
Log Message
Implement reviewer feedback that I missed on bug 95930.
https://bugs.webkit.org/show_bug.cgi?id=97752
Reviewed by Alexey Proskuryakov.
This patch updates the indentation of function parameters in a few places,
and reserves an appropriate amount of space when using StringBuilder.
* css/CSSBasicShapes.cpp:
(WebCore::buildRectangleString):
(WebCore::CSSBasicShapeRectangle::cssText):
(WebCore::CSSBasicShapeRectangle::serializeResolvingVariables):
(WebCore::CSSBasicShapeCircle::serializeResolvingVariables):
(WebCore::CSSBasicShapeEllipse::serializeResolvingVariables):
(WebCore::buildPolygonString):
* css/Rect.h:
(WebCore::Rect::serializeResolvingVariables):
(WebCore::Quad::serializeResolvingVariables):
(WebCore::Quad::generateCSSString):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/CSSBasicShapes.cpp
trunk/Source/WebCore/css/Rect.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (129830 => 129831)
--- trunk/Source/WebCore/ChangeLog 2012-09-28 01:43:52 UTC (rev 129830)
+++ trunk/Source/WebCore/ChangeLog 2012-09-28 02:16:38 UTC (rev 129831)
@@ -1,3 +1,25 @@
+2012-09-27 Luke Macpherson macpher...@chromium.org
+
+Implement reviewer feedback that I missed on bug 95930.
+https://bugs.webkit.org/show_bug.cgi?id=97752
+
+Reviewed by Alexey Proskuryakov.
+
+This patch updates the indentation of function parameters in a few places,
+and reserves an appropriate amount of space when using StringBuilder.
+
+* css/CSSBasicShapes.cpp:
+(WebCore::buildRectangleString):
+(WebCore::CSSBasicShapeRectangle::cssText):
+(WebCore::CSSBasicShapeRectangle::serializeResolvingVariables):
+(WebCore::CSSBasicShapeCircle::serializeResolvingVariables):
+(WebCore::CSSBasicShapeEllipse::serializeResolvingVariables):
+(WebCore::buildPolygonString):
+* css/Rect.h:
+(WebCore::Rect::serializeResolvingVariables):
+(WebCore::Quad::serializeResolvingVariables):
+(WebCore::Quad::generateCSSString):
+
2012-09-27 Sheriff Bot webkit.review@gmail.com
Unreviewed, rolling out r129823.
Modified: trunk/Source/WebCore/css/CSSBasicShapes.cpp (129830 => 129831)
--- trunk/Source/WebCore/css/CSSBasicShapes.cpp 2012-09-28 01:43:52 UTC (rev 129830)
+++ trunk/Source/WebCore/css/CSSBasicShapes.cpp 2012-09-28 02:16:38 UTC (rev 129831)
@@ -39,20 +39,24 @@
static String buildRectangleString(const String x, const String y, const String width, const String height, const String radiusX, const String radiusY)
{
+char opening[] = rectangle(;
+char separator[] = , ;
StringBuilder result;
-result.appendLiteral(rectangle();
+// Compute the required capacity in advance to reduce allocations.
+result.reserveCapacity((sizeof(opening) - 1) + (5 * (sizeof(separator) -1 )) + 1 + x.length() + y.length() + width.length() + height.length() + radiusX.length() + radiusY.length());
+result.appendLiteral(opening);
result.append(x);
-result.appendLiteral(, );
+result.appendLiteral(separator);
result.append(y);
-result.appendLiteral(, );
+result.appendLiteral(separator);
result.append(width);
-result.appendLiteral(, );
+result.appendLiteral(separator);
result.append(height);
if (!radiusX.isNull()) {
-result.appendLiteral(, );
+result.appendLiteral(separator);
result.append(radiusX);
if (!radiusY.isNull()) {
-result.appendLiteral(, );
+result.appendLiteral(separator);
result.append(radiusY);
}
}
@@ -63,22 +67,22 @@
String CSSBasicShapeRectangle::cssText() const
{
return buildRectangleString(m_x-cssText(),
-m_y-cssText(),
-m_width-cssText(),
-m_height-cssText(),
-m_radiusX.get() ? m_radiusX-cssText() : String(),
-m_radiusY.get() ? m_radiusY-cssText() : String());
+m_y-cssText(),
+m_width-cssText(),
+m_height-cssText(),
+m_radiusX.get() ? m_radiusX-cssText() : String(),
+m_radiusY.get() ? m_radiusY-cssText() : String());
}
#if ENABLE(CSS_VARIABLES)
String CSSBasicShapeRectangle::serializeResolvingVariables(const HashMapAtomicString, String variables) const
{
return buildRectangleString(m_x-serializeResolvingVariables(variables),
-m_y-serializeResolvingVariables(variables),
-m_width-serializeResolvingVariables(variables),
-m_height-serializeResolvingVariables(variables),
-m_radiusX.get() ? m_radiusX-serializeResolvingVariables(variables) : String(),
-
[webkit-changes] [129832] trunk
Title: [129832] trunk Revision 129832 Author tk...@chromium.org Date 2012-09-27 19:36:03 -0700 (Thu, 27 Sep 2012) Log Message DateTimeNumericFieldElement should use Localizer functions. https://bugs.webkit.org/show_bug.cgi?id=97318 Reviewed by Hajime Morita. Source/WebCore: Source/WebCore: Use Localizer functions instead of functions in LocalizedNumber to test i18n behavior. This affects only layout tests because Document::getLocalizer() always returns a Localizer for the browser locale. To obtain a Localizer object for input's locale from a deep shadow node, we add localeIdentifier() function to DateTimeFieldElement::FieldOwner and DateTimeEditElement::EditControlOwner interfaces. Tests: fast/forms/time-multiple-fields/time-multiple-fields-localization.html * html/shadow/DateTimeFieldElement.h: (FieldOwner): Add localeIdentifier callback. (DateTimeFieldElement): Add localeIdentifier(). * html/shadow/DateTimeFieldElement.cpp: (WebCore::DateTimeFieldElement::localeIdentifier): Added. Returns FieldOwner::localeIdentifier if m_fieldOwner is available. * html/shadow/DateTimeNumericFieldElement.h: (DateTimeNumericFieldElement): Declare localizer(). * html/shadow/DateTimeNumericFieldElement.cpp: (WebCore::DateTimeNumericFieldElement::localizer): Returns a Localizer for DateTimeFieldElement::localeIdentifier() (WebCore::DateTimeNumericFieldElement::handleKeyboardEvent): Use localizer(). (WebCore::DateTimeNumericFieldElement::value): Use localizer(). * html/shadow/DateTimeEditElement.h: (EditControlOwner): Add localeIdentifier() callback. (DateTimeEditElement): Declare localeIdentifier(), which implements FieldOwner::localeIdentifier(). * html/shadow/DateTimeEditElement.cpp: (WebCore::DateTimeEditElement::localeIdentifier): Added. Returns EditControlOwner::localeIdentifier if m_editControlOwner is available. * html/BaseMultipleFieldsDateAndTimeInputType.h: (BaseMultipleFieldsDateAndTimeInputType): Declare localeIdentifier(), which implements EditControlOwner::localeIdentifier(). * html/BaseMultipleFieldsDateAndTimeInputType.cpp: (WebCore::BaseMultipleFieldsDateAndTimeInputType::localeIdentifier): Added. Returns input's inherited locale identifier. LayoutTests: * platform/chromium/TestExpectations: Need rebaseline for non-Mac results. * platform/chromium/fast/forms/time-multiple-fields/time-multiple-fields-localization-expected.txt: Update ar locale result. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/TestExpectations trunk/LayoutTests/platform/chromium/fast/forms/time-multiple-fields/time-multiple-fields-localization-expected.txt trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/html/BaseMultipleFieldsDateAndTimeInputType.cpp trunk/Source/WebCore/html/BaseMultipleFieldsDateAndTimeInputType.h trunk/Source/WebCore/html/shadow/DateTimeEditElement.cpp trunk/Source/WebCore/html/shadow/DateTimeEditElement.h trunk/Source/WebCore/html/shadow/DateTimeFieldElement.cpp trunk/Source/WebCore/html/shadow/DateTimeFieldElement.h trunk/Source/WebCore/html/shadow/DateTimeNumericFieldElement.cpp trunk/Source/WebCore/html/shadow/DateTimeNumericFieldElement.h Diff Modified: trunk/LayoutTests/ChangeLog (129831 => 129832) --- trunk/LayoutTests/ChangeLog 2012-09-28 02:16:38 UTC (rev 129831) +++ trunk/LayoutTests/ChangeLog 2012-09-28 02:36:03 UTC (rev 129832) @@ -1,3 +1,15 @@ +2012-09-27 Kent Tamura tk...@chromium.org + +DateTimeNumericFieldElement should use Localizer functions. +https://bugs.webkit.org/show_bug.cgi?id=97318 + +Reviewed by Hajime Morita. + +* platform/chromium/TestExpectations: +Need rebaseline for non-Mac results. +* platform/chromium/fast/forms/time-multiple-fields/time-multiple-fields-localization-expected.txt: +Update ar locale result. + 2012-09-27 Alexandre Elias ael...@chromium.org [chromium] DumpRenderTree support for software compositing Modified: trunk/LayoutTests/platform/chromium/TestExpectations (129831 => 129832) --- trunk/LayoutTests/platform/chromium/TestExpectations 2012-09-28 02:16:38 UTC (rev 129831) +++ trunk/LayoutTests/platform/chromium/TestExpectations 2012-09-28 02:36:03 UTC (rev 129832) @@ -3596,6 +3596,7 @@ webkit.org/b/96833 svg/carto.net/combobox.svg [ ImageOnlyFailure Pass ] webkit.org/b/96720 [ Mac Win ] fast/forms/time-multiple-fields/time-multiple-fields-preserve-value-after-history-back.html [ Pass Timeout ] +webkit.org/b/97318 [ Linux Win ] fast/forms/time-multiple-fields/time-multiple-fields-localization.html [ Failure Pass ] webkit.org/b/96549 [ Mac ] platform/chromium/virtual/gpu/fast/hidpi/focus-rings.html [ ImageOnlyFailure ] webkit.org/b/96549 [ Mac ] platform/chromium/virtual/gpu/fast/hidpi/video-controls-in-hidpi.html [ ImageOnlyFailure ] webkit.org/b/96628 [ Lion ] fast/frames/calculate-order.html [ Failure Pass ] Modified:
[webkit-changes] [129833] trunk/Source/WebKit/chromium
Title: [129833] trunk/Source/WebKit/chromium Revision 129833 Author pilg...@chromium.org Date 2012-09-27 19:37:49 -0700 (Thu, 27 Sep 2012) Log Message [Chromium] Remove unused PlatformSupport reference in WebFrameImpl https://bugs.webkit.org/show_bug.cgi?id=97842 Reviewed by Kentaro Hara. Part of a refactoring series. See tracking bug 82948. * src/WebFrameImpl.cpp: Modified Paths trunk/Source/WebKit/chromium/ChangeLog trunk/Source/WebKit/chromium/src/WebFrameImpl.cpp Diff Modified: trunk/Source/WebKit/chromium/ChangeLog (129832 => 129833) --- trunk/Source/WebKit/chromium/ChangeLog 2012-09-28 02:36:03 UTC (rev 129832) +++ trunk/Source/WebKit/chromium/ChangeLog 2012-09-28 02:37:49 UTC (rev 129833) @@ -1,5 +1,16 @@ 2012-09-27 Mark Pilgrim pilg...@chromium.org +[Chromium] Remove unused PlatformSupport reference in WebFrameImpl +https://bugs.webkit.org/show_bug.cgi?id=97842 + +Reviewed by Kentaro Hara. + +Part of a refactoring series. See tracking bug 82948. + +* src/WebFrameImpl.cpp: + +2012-09-27 Mark Pilgrim pilg...@chromium.org + [Chromium] Remove screen-related functions from PlatformSupport https://bugs.webkit.org/show_bug.cgi?id=97474 Modified: trunk/Source/WebKit/chromium/src/WebFrameImpl.cpp (129832 => 129833) --- trunk/Source/WebKit/chromium/src/WebFrameImpl.cpp 2012-09-28 02:36:03 UTC (rev 129832) +++ trunk/Source/WebKit/chromium/src/WebFrameImpl.cpp 2012-09-28 02:37:49 UTC (rev 129833) @@ -116,7 +116,6 @@ #include PageOverlay.h #include Performance.h #include PlatformMessagePortChannel.h -#include PlatformSupport.h #include PluginDocument.h #include PrintContext.h #include RenderBox.h ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [129834] trunk/Source/WebCore
Title: [129834] trunk/Source/WebCore Revision 129834 Author pilg...@chromium.org Date 2012-09-27 19:40:27 -0700 (Thu, 27 Sep 2012) Log Message [Chromium] Remove unused PlatformSupport reference in ClipboardChromium https://bugs.webkit.org/show_bug.cgi?id=97840 Reviewed by Kentaro Hara. Part of a refactoring series. See tracking bug 82948. * platform/chromium/ClipboardChromium.cpp: Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/platform/chromium/ClipboardChromium.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (129833 => 129834) --- trunk/Source/WebCore/ChangeLog 2012-09-28 02:37:49 UTC (rev 129833) +++ trunk/Source/WebCore/ChangeLog 2012-09-28 02:40:27 UTC (rev 129834) @@ -1,3 +1,14 @@ +2012-09-27 Mark Pilgrim pilg...@chromium.org + +[Chromium] Remove unused PlatformSupport reference in ClipboardChromium +https://bugs.webkit.org/show_bug.cgi?id=97840 + +Reviewed by Kentaro Hara. + +Part of a refactoring series. See tracking bug 82948. + +* platform/chromium/ClipboardChromium.cpp: + 2012-09-27 Kent Tamura tk...@chromium.org DateTimeNumericFieldElement should use Localizer functions. Modified: trunk/Source/WebCore/platform/chromium/ClipboardChromium.cpp (129833 => 129834) --- trunk/Source/WebCore/platform/chromium/ClipboardChromium.cpp 2012-09-28 02:37:49 UTC (rev 129833) +++ trunk/Source/WebCore/platform/chromium/ClipboardChromium.cpp 2012-09-28 02:40:27 UTC (rev 129834) @@ -45,7 +45,6 @@ #include Image.h #include MIMETypeRegistry.h #include NamedNodeMap.h -#include PlatformSupport.h #include Range.h #include RenderImage.h #include StringCallback.h ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [129835] trunk/Source/WebKit/chromium
Title: [129835] trunk/Source/WebKit/chromium Revision 129835 Author pilg...@chromium.org Date 2012-09-27 19:55:58 -0700 (Thu, 27 Sep 2012) Log Message [Chromium] Clean up includes in AudioDestinationChromium https://bugs.webkit.org/show_bug.cgi?id=97845 Reviewed by Kentaro Hara. Part of a refactoring series. See tracking bug 82948. * src/AudioDestinationChromium.cpp: Modified Paths trunk/Source/WebKit/chromium/ChangeLog trunk/Source/WebKit/chromium/src/AudioDestinationChromium.cpp Diff Modified: trunk/Source/WebKit/chromium/ChangeLog (129834 => 129835) --- trunk/Source/WebKit/chromium/ChangeLog 2012-09-28 02:40:27 UTC (rev 129834) +++ trunk/Source/WebKit/chromium/ChangeLog 2012-09-28 02:55:58 UTC (rev 129835) @@ -1,5 +1,16 @@ 2012-09-27 Mark Pilgrim pilg...@chromium.org +[Chromium] Clean up includes in AudioDestinationChromium +https://bugs.webkit.org/show_bug.cgi?id=97845 + +Reviewed by Kentaro Hara. + +Part of a refactoring series. See tracking bug 82948. + +* src/AudioDestinationChromium.cpp: + +2012-09-27 Mark Pilgrim pilg...@chromium.org + [Chromium] Remove unused PlatformSupport reference in WebFrameImpl https://bugs.webkit.org/show_bug.cgi?id=97842 Modified: trunk/Source/WebKit/chromium/src/AudioDestinationChromium.cpp (129834 => 129835) --- trunk/Source/WebKit/chromium/src/AudioDestinationChromium.cpp 2012-09-28 02:40:27 UTC (rev 129834) +++ trunk/Source/WebKit/chromium/src/AudioDestinationChromium.cpp 2012-09-28 02:55:58 UTC (rev 129835) @@ -29,14 +29,9 @@ #include config.h #if ENABLE(WEB_AUDIO) - #include AudioDestinationChromium.h - #include AudioFIFO.h #include AudioPullFIFO.h -#include WebKit.h -#include platform/WebKitPlatformSupport.h - #include public/Platform.h using namespace WebKit; ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [129836] trunk/Source/WebKit/chromium
Title: [129836] trunk/Source/WebKit/chromium Revision 129836 Author pilg...@chromium.org Date 2012-09-27 19:57:21 -0700 (Thu, 27 Sep 2012) Log Message [Chromium] Clean up includes in SocketStreamHandle https://bugs.webkit.org/show_bug.cgi?id=97843 Reviewed by Kentaro Hara. Part of a refactoring series. See tracking bug 82948. * src/SocketStreamHandle.cpp: Modified Paths trunk/Source/WebKit/chromium/ChangeLog trunk/Source/WebKit/chromium/src/SocketStreamHandle.cpp Diff Modified: trunk/Source/WebKit/chromium/ChangeLog (129835 => 129836) --- trunk/Source/WebKit/chromium/ChangeLog 2012-09-28 02:55:58 UTC (rev 129835) +++ trunk/Source/WebKit/chromium/ChangeLog 2012-09-28 02:57:21 UTC (rev 129836) @@ -1,5 +1,16 @@ 2012-09-27 Mark Pilgrim pilg...@chromium.org +[Chromium] Clean up includes in SocketStreamHandle +https://bugs.webkit.org/show_bug.cgi?id=97843 + +Reviewed by Kentaro Hara. + +Part of a refactoring series. See tracking bug 82948. + +* src/SocketStreamHandle.cpp: + +2012-09-27 Mark Pilgrim pilg...@chromium.org + [Chromium] Clean up includes in AudioDestinationChromium https://bugs.webkit.org/show_bug.cgi?id=97845 Modified: trunk/Source/WebKit/chromium/src/SocketStreamHandle.cpp (129835 => 129836) --- trunk/Source/WebKit/chromium/src/SocketStreamHandle.cpp 2012-09-28 02:55:58 UTC (rev 129835) +++ trunk/Source/WebKit/chromium/src/SocketStreamHandle.cpp 2012-09-28 02:57:21 UTC (rev 129836) @@ -38,9 +38,8 @@ #include NotImplemented.h #include SocketStreamHandleClient.h #include platform/WebData.h -#include WebKit.h -#include platform/WebKitPlatformSupport.h #include platform/WebSocketStreamHandle.h +#include public/Platform.h #include wtf/PassOwnPtr.h using namespace WebKit; ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [129837] trunk/Source/WebCore
Title: [129837] trunk/Source/WebCore Revision 129837 Author pilg...@chromium.org Date 2012-09-27 19:59:36 -0700 (Thu, 27 Sep 2012) Log Message [Chromium][Android] Remove unused PlatformSupport reference in ScrollbarThemeChromiumAndroid https://bugs.webkit.org/show_bug.cgi?id=97846 Reviewed by Kentaro Hara. Part of a refactoring series. See tracking bug 82948. * platform/chromium/ScrollbarThemeChromiumAndroid.cpp: Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/platform/chromium/ScrollbarThemeChromiumAndroid.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (129836 => 129837) --- trunk/Source/WebCore/ChangeLog 2012-09-28 02:57:21 UTC (rev 129836) +++ trunk/Source/WebCore/ChangeLog 2012-09-28 02:59:36 UTC (rev 129837) @@ -1,5 +1,16 @@ 2012-09-27 Mark Pilgrim pilg...@chromium.org +[Chromium][Android] Remove unused PlatformSupport reference in ScrollbarThemeChromiumAndroid +https://bugs.webkit.org/show_bug.cgi?id=97846 + +Reviewed by Kentaro Hara. + +Part of a refactoring series. See tracking bug 82948. + +* platform/chromium/ScrollbarThemeChromiumAndroid.cpp: + +2012-09-27 Mark Pilgrim pilg...@chromium.org + [Chromium] Remove unused PlatformSupport reference in ClipboardChromium https://bugs.webkit.org/show_bug.cgi?id=97840 Modified: trunk/Source/WebCore/platform/chromium/ScrollbarThemeChromiumAndroid.cpp (129836 => 129837) --- trunk/Source/WebCore/platform/chromium/ScrollbarThemeChromiumAndroid.cpp 2012-09-28 02:57:21 UTC (rev 129836) +++ trunk/Source/WebCore/platform/chromium/ScrollbarThemeChromiumAndroid.cpp 2012-09-28 02:59:36 UTC (rev 129837) @@ -28,7 +28,6 @@ #include PlatformContextSkia.h #include PlatformMouseEvent.h -#include PlatformSupport.h #include Scrollbar.h #include TransformationMatrix.h ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [129838] trunk/Source/WebKit/chromium
Title: [129838] trunk/Source/WebKit/chromium
Revision 129838
Author pilg...@chromium.org
Date 2012-09-27 20:01:35 -0700 (Thu, 27 Sep 2012)
Log Message
[Chromium] Clean up includes in PaintAggregator
https://bugs.webkit.org/show_bug.cgi?id=97848
Reviewed by Kentaro Hara.
Part of a refactoring series. See tracking bug 82948.
* src/painting/PaintAggregator.cpp:
Modified Paths
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/src/painting/PaintAggregator.cpp
Diff
Modified: trunk/Source/WebKit/chromium/ChangeLog (129837 => 129838)
--- trunk/Source/WebKit/chromium/ChangeLog 2012-09-28 02:59:36 UTC (rev 129837)
+++ trunk/Source/WebKit/chromium/ChangeLog 2012-09-28 03:01:35 UTC (rev 129838)
@@ -1,5 +1,16 @@
2012-09-27 Mark Pilgrim pilg...@chromium.org
+[Chromium] Clean up includes in PaintAggregator
+https://bugs.webkit.org/show_bug.cgi?id=97848
+
+Reviewed by Kentaro Hara.
+
+Part of a refactoring series. See tracking bug 82948.
+
+* src/painting/PaintAggregator.cpp:
+
+2012-09-27 Mark Pilgrim pilg...@chromium.org
+
[Chromium] Clean up includes in SocketStreamHandle
https://bugs.webkit.org/show_bug.cgi?id=97843
Modified: trunk/Source/WebKit/chromium/src/painting/PaintAggregator.cpp (129837 => 129838)
--- trunk/Source/WebKit/chromium/src/painting/PaintAggregator.cpp 2012-09-28 02:59:36 UTC (rev 129837)
+++ trunk/Source/WebKit/chromium/src/painting/PaintAggregator.cpp 2012-09-28 03:01:35 UTC (rev 129838)
@@ -30,10 +30,7 @@
#include config.h
#include PaintAggregator.h
-
-#include WebKit.h
-#include platform/WebKitPlatformSupport.h
-
+#include public/Platform.h
using namespace WebCore;
namespace WebKit {
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [129839] trunk/Source/WebKit/chromium
Title: [129839] trunk/Source/WebKit/chromium
Revision 129839
Author pilg...@chromium.org
Date 2012-09-27 20:03:29 -0700 (Thu, 27 Sep 2012)
Log Message
[Chromium] Clean up includes in ColorChooserUIController
https://bugs.webkit.org/show_bug.cgi?id=97849
Reviewed by Kentaro Hara.
Part of a refactoring series. See tracking bug 82948.
* src/ColorChooserUIController.cpp:
Modified Paths
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/src/ColorChooserUIController.cpp
Diff
Modified: trunk/Source/WebKit/chromium/ChangeLog (129838 => 129839)
--- trunk/Source/WebKit/chromium/ChangeLog 2012-09-28 03:01:35 UTC (rev 129838)
+++ trunk/Source/WebKit/chromium/ChangeLog 2012-09-28 03:03:29 UTC (rev 129839)
@@ -1,5 +1,16 @@
2012-09-27 Mark Pilgrim pilg...@chromium.org
+[Chromium] Clean up includes in ColorChooserUIController
+https://bugs.webkit.org/show_bug.cgi?id=97849
+
+Reviewed by Kentaro Hara.
+
+Part of a refactoring series. See tracking bug 82948.
+
+* src/ColorChooserUIController.cpp:
+
+2012-09-27 Mark Pilgrim pilg...@chromium.org
+
[Chromium] Clean up includes in PaintAggregator
https://bugs.webkit.org/show_bug.cgi?id=97848
Modified: trunk/Source/WebKit/chromium/src/ColorChooserUIController.cpp (129838 => 129839)
--- trunk/Source/WebKit/chromium/src/ColorChooserUIController.cpp 2012-09-28 03:01:35 UTC (rev 129838)
+++ trunk/Source/WebKit/chromium/src/ColorChooserUIController.cpp 2012-09-28 03:03:29 UTC (rev 129839)
@@ -36,8 +36,8 @@
#include LocalizedStrings.h
#include PickerCommon.h
#include WebColorChooser.h
-#include platform/WebColor.h
-#include platform/WebKitPlatformSupport.h
+#include public/Platform.h
+#include public/WebColor.h
#include public/WebLocalizedString.h
namespace WebKit {
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [129840] trunk/Source/WebCore
Title: [129840] trunk/Source/WebCore Revision 129840 Author pilg...@chromium.org Date 2012-09-27 20:05:39 -0700 (Thu, 27 Sep 2012) Log Message [Chromium] Remove unused PlatformSupport reference in FontCacheSkia https://bugs.webkit.org/show_bug.cgi?id=97850 Reviewed by Kentaro Hara. Part of a refactoring series. See tracking bug 82948. * platform/graphics/skia/FontCacheSkia.cpp: Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/platform/graphics/skia/FontCacheSkia.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (129839 => 129840) --- trunk/Source/WebCore/ChangeLog 2012-09-28 03:03:29 UTC (rev 129839) +++ trunk/Source/WebCore/ChangeLog 2012-09-28 03:05:39 UTC (rev 129840) @@ -1,5 +1,16 @@ 2012-09-27 Mark Pilgrim pilg...@chromium.org +[Chromium] Remove unused PlatformSupport reference in FontCacheSkia +https://bugs.webkit.org/show_bug.cgi?id=97850 + +Reviewed by Kentaro Hara. + +Part of a refactoring series. See tracking bug 82948. + +* platform/graphics/skia/FontCacheSkia.cpp: + +2012-09-27 Mark Pilgrim pilg...@chromium.org + [Chromium][Android] Remove unused PlatformSupport reference in ScrollbarThemeChromiumAndroid https://bugs.webkit.org/show_bug.cgi?id=97846 Modified: trunk/Source/WebCore/platform/graphics/skia/FontCacheSkia.cpp (129839 => 129840) --- trunk/Source/WebCore/platform/graphics/skia/FontCacheSkia.cpp 2012-09-28 03:03:29 UTC (rev 129839) +++ trunk/Source/WebCore/platform/graphics/skia/FontCacheSkia.cpp 2012-09-28 03:05:39 UTC (rev 129840) @@ -30,20 +30,16 @@ #include config.h #include FontCache.h - #include Font.h #include FontDescription.h #include FontFamily.h #include FontPlatformData.h #include Logging.h #include NotImplemented.h -#include PlatformSupport.h #include SimpleFontData.h - #include SkPaint.h #include SkTypeface.h #include SkUtils.h - #include unicode/locid.h #include wtf/Assertions.h #include wtf/text/AtomicString.h ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [129841] trunk/Source/WebKit/chromium
Title: [129841] trunk/Source/WebKit/chromium Revision 129841 Author pilg...@chromium.org Date 2012-09-27 20:14:37 -0700 (Thu, 27 Sep 2012) Log Message [Chromium] Clean up includes in DateTimeChooserImpl https://bugs.webkit.org/show_bug.cgi?id=97847 Reviewed by Kentaro Hara. Part of a refactoring series. See tracking bug 82948. * src/DateTimeChooserImpl.cpp: Modified Paths trunk/Source/WebKit/chromium/ChangeLog trunk/Source/WebKit/chromium/src/DateTimeChooserImpl.cpp Diff Modified: trunk/Source/WebKit/chromium/ChangeLog (129840 => 129841) --- trunk/Source/WebKit/chromium/ChangeLog 2012-09-28 03:05:39 UTC (rev 129840) +++ trunk/Source/WebKit/chromium/ChangeLog 2012-09-28 03:14:37 UTC (rev 129841) @@ -1,5 +1,16 @@ 2012-09-27 Mark Pilgrim pilg...@chromium.org +[Chromium] Clean up includes in DateTimeChooserImpl +https://bugs.webkit.org/show_bug.cgi?id=97847 + +Reviewed by Kentaro Hara. + +Part of a refactoring series. See tracking bug 82948. + +* src/DateTimeChooserImpl.cpp: + +2012-09-27 Mark Pilgrim pilg...@chromium.org + [Chromium] Clean up includes in ColorChooserUIController https://bugs.webkit.org/show_bug.cgi?id=97849 Modified: trunk/Source/WebKit/chromium/src/DateTimeChooserImpl.cpp (129840 => 129841) --- trunk/Source/WebKit/chromium/src/DateTimeChooserImpl.cpp 2012-09-28 03:05:39 UTC (rev 129840) +++ trunk/Source/WebKit/chromium/src/DateTimeChooserImpl.cpp 2012-09-28 03:14:37 UTC (rev 129841) @@ -43,7 +43,7 @@ #include NotImplemented.h #include PickerCommon.h #include RenderTheme.h -#include platform/WebKitPlatformSupport.h +#include public/Platform.h #include public/WebLocalizedString.h using namespace WTF::Unicode; ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
