[webkit-changes] [130472] trunk/Tools
Title: [130472] trunk/Tools
Revision 130472
Author commit-qu...@webkit.org
Date 2012-10-04 23:58:57 -0700 (Thu, 04 Oct 2012)
Log Message
[EFL][WK2] Fix destination path when download with suggested filename on the Minibrowser
https://bugs.webkit.org/show_bug.cgi?id=98334
Patch by KyungTae Kim on 2012-10-04
Reviewed by Gyuyoung Kim.
Add callback functions for download requests to Minibrowser to set the destination path for download.
Set the destination path with suggested file name as (destination folder) + (suggested file name).
The 'destination folder' should be a specific folder user selected, but is set to '/tmp' for now.
Additionally, for printing out the download status,
use the info macro and set the verbose variable to 1 to enable it.
* MiniBrowser/efl/main.c:
(on_download_request):
(on_download_finished):
(on_download_failed):
(browserCreate):
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/MiniBrowser/efl/main.c
Diff
Modified: trunk/Tools/ChangeLog (130471 => 130472)
--- trunk/Tools/ChangeLog 2012-10-05 06:57:34 UTC (rev 130471)
+++ trunk/Tools/ChangeLog 2012-10-05 06:58:57 UTC (rev 130472)
@@ -1,3 +1,23 @@
+2012-10-04 KyungTae Kim
+
+[EFL][WK2] Fix destination path when download with suggested filename on the Minibrowser
+https://bugs.webkit.org/show_bug.cgi?id=98334
+
+Reviewed by Gyuyoung Kim.
+
+Add callback functions for download requests to Minibrowser to set the destination path for download.
+Set the destination path with suggested file name as (destination folder) + (suggested file name).
+The 'destination folder' should be a specific folder user selected, but is set to '/tmp' for now.
+
+Additionally, for printing out the download status,
+use the info macro and set the verbose variable to 1 to enable it.
+
+* MiniBrowser/efl/main.c:
+(on_download_request):
+(on_download_finished):
+(on_download_failed):
+(browserCreate):
+
2012-10-04 Christophe Dumez
[WK2][WKTR] Implement UIClient focus callbacks in WebKitTestRunner
Modified: trunk/Tools/MiniBrowser/efl/main.c (130471 => 130472)
--- trunk/Tools/MiniBrowser/efl/main.c 2012-10-05 06:57:34 UTC (rev 130471)
+++ trunk/Tools/MiniBrowser/efl/main.c 2012-10-05 06:58:57 UTC (rev 130472)
@@ -36,7 +36,7 @@
printf(format, ##args); \
} while (0)
-static int verbose = 0;
+static int verbose = 1;
typedef struct _MiniBrowser {
Ecore_Evas *ee;
@@ -199,6 +199,41 @@
eina_strbuf_free(buffer);
}
+static void
+on_download_request(void *user_data, Evas_Object *webview, void *event_info)
+{
+Ewk_Download_Job *download = (Ewk_Download_Job *)event_info;
+
+// FIXME: The destination folder should be selected by the user but we set it to '/tmp' for now.
+Eina_Strbuf *destination_path = eina_strbuf_new();
+eina_strbuf_append(destination_path, "/tmp/");
+
+const char *suggested_name = ewk_download_job_suggested_filename_get(download);
+if (suggested_name && *suggested_name)
+eina_strbuf_append(destination_path, suggested_name);
+else {
+eina_strbuf_append(destination_path, "downloaded-file.XX");
+mktemp(eina_strbuf_string_get(destination_path));
+}
+
+ewk_download_job_destination_set(download, eina_strbuf_string_get(destination_path));
+info("Downloading: %s\n", eina_strbuf_string_get(destination_path));
+eina_strbuf_free(destination_path);
+}
+
+static void
+on_download_finished(void *user_data, Evas_Object *webview, void *event_info)
+{
+Ewk_Download_Job *download = (Ewk_Download_Job *)event_info;
+info("Download finished: %s\n", ewk_download_job_destination_get(download));
+}
+
+static void
+on_download_failed(void *user_data, Evas_Object *webview, void *event_info)
+{
+info("Download failed!\n");
+}
+
static int
quit(Eina_Bool success, const char *msg)
{
@@ -238,6 +273,9 @@
Ewk_Settings *settings = ewk_view_settings_get(app->browser);
ewk_settings_file_access_from_file_urls_allowed_set(settings, EINA_TRUE);
+evas_object_smart_callback_add(app->browser, "download,failed", on_download_failed, app);
+evas_object_smart_callback_add(app->browser, "download,finished", on_download_finished, app);
+evas_object_smart_callback_add(app->browser, "download,request", on_download_request, app);
evas_object_smart_callback_add(app->browser, "load,error", on_error, app);
evas_object_smart_callback_add(app->browser, "load,progress", on_progress, app);
evas_object_smart_callback_add(app->browser, "title,changed", on_title_changed, app);
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [130471] trunk/Source
Title: [130471] trunk/Source Revision 130471 Author ba...@chromium.org Date 2012-10-04 23:57:34 -0700 (Thu, 04 Oct 2012) Log Message [WebSocket] ExtensionParser should have its own file https://bugs.webkit.org/show_bug.cgi?id=98475 Reviewed by Yuta Kitamura. Source/WebCore: Factor out ExtensionParser from WebSocketExtensionDispatcher and rename it as WebSocketExtensionParser. WebSocketExtensionParser has its own file. No changes in behavior. Added a test case for parsing Sec-WebSocket-Extensions field as a chromium unit test. * CMakeLists.txt: Added WebSocketExtensionParser. * GNUmakefile.list.am: Ditto. * Modules/websockets/WebSocketExtensionDispatcher.cpp: (WebCore::WebSocketExtensionDispatcher::processHeaderValue): Use WebSocketExtensionParser::parseExtension() to parser extension header value. * Modules/websockets/WebSocketExtensionParser.cpp: Added. (WebCore): (WebCore::WebSocketExtensionParser::finished): Moved from ExtensionParser. (WebCore::WebSocketExtensionParser::parsedSuccessfully): Ditto. (WebCore::isSeparator): Ditto. (WebCore::WebSocketExtensionParser::skipSpaces): Ditto. (WebCore::WebSocketExtensionParser::consumeToken): Ditto. (WebCore::WebSocketExtensionParser::consumeQuotedString): Ditto. (WebCore::WebSocketExtensionParser::consumeQuotedStringOrToken): Ditto. (WebCore::WebSocketExtensionParser::consumeCharacter): Ditto. (WebCore::WebSocketExtensionParser::parseExtension): Moved from WebSocketExtensionDispatcher. * Modules/websockets/WebSocketExtensionParser.h: Added. (WebCore): (WebSocketExtensionParser): (WebCore::WebSocketExtensionParser::WebSocketExtensionParser): (WebCore::WebSocketExtensionParser::currentToken): * Target.pri: Added WebSocketExtensionParser. * WebCore.gypi: Ditto. * WebCore.vcproj/WebCore.vcproj: Ditto. * WebCore.xcodeproj/project.pbxproj: Ditto. Source/WebKit/chromium: Add a test for parsing Sec-WebSocket-Extensions field. * tests/WebSocketExtensionDispatcherTest.cpp: (WebCore): (WebCore::TEST_F): Modified Paths trunk/Source/WebCore/CMakeLists.txt trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/GNUmakefile.list.am trunk/Source/WebCore/Modules/websockets/WebSocketExtensionDispatcher.cpp trunk/Source/WebCore/Target.pri trunk/Source/WebCore/WebCore.gypi trunk/Source/WebCore/WebCore.vcproj/WebCore.vcproj trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj trunk/Source/WebKit/chromium/ChangeLog trunk/Source/WebKit/chromium/tests/WebSocketExtensionDispatcherTest.cpp Added Paths trunk/Source/WebCore/Modules/websockets/WebSocketExtensionParser.cpp trunk/Source/WebCore/Modules/websockets/WebSocketExtensionParser.h Diff Modified: trunk/Source/WebCore/CMakeLists.txt (130470 => 130471) --- trunk/Source/WebCore/CMakeLists.txt 2012-10-05 06:55:23 UTC (rev 130470) +++ trunk/Source/WebCore/CMakeLists.txt 2012-10-05 06:57:34 UTC (rev 130471) @@ -968,6 +968,7 @@ Modules/websockets/WebSocketDeflater.cpp Modules/websockets/WebSocketDeflateFramer.cpp Modules/websockets/WebSocketExtensionDispatcher.cpp +Modules/websockets/WebSocketExtensionParser.cpp Modules/websockets/WebSocketFrame.cpp Modules/websockets/WebSocketHandshake.cpp Modules/websockets/WebSocketHandshakeRequest.cpp Modified: trunk/Source/WebCore/ChangeLog (130470 => 130471) --- trunk/Source/WebCore/ChangeLog 2012-10-05 06:55:23 UTC (rev 130470) +++ trunk/Source/WebCore/ChangeLog 2012-10-05 06:57:34 UTC (rev 130471) @@ -1,3 +1,41 @@ +2012-10-04 Kenichi Ishibashi + +[WebSocket] ExtensionParser should have its own file +https://bugs.webkit.org/show_bug.cgi?id=98475 + +Reviewed by Yuta Kitamura. + +Factor out ExtensionParser from WebSocketExtensionDispatcher and rename it as WebSocketExtensionParser. +WebSocketExtensionParser has its own file. + +No changes in behavior. Added a test case for parsing Sec-WebSocket-Extensions field as a chromium unit test. + +* CMakeLists.txt: Added WebSocketExtensionParser. +* GNUmakefile.list.am: Ditto. +* Modules/websockets/WebSocketExtensionDispatcher.cpp: +(WebCore::WebSocketExtensionDispatcher::processHeaderValue): +Use WebSocketExtensionParser::parseExtension() to parser extension header value. +* Modules/websockets/WebSocketExtensionParser.cpp: Added. +(WebCore): +(WebCore::WebSocketExtensionParser::finished): Moved from ExtensionParser. +(WebCore::WebSocketExtensionParser::parsedSuccessfully): Ditto. +(WebCore::isSeparator): Ditto. +(WebCore::WebSocketExtensionParser::skipSpaces): Ditto. +(WebCore::WebSocketExtensionParser::consumeToken): Ditto. +(WebCore::WebSocketExtensionParser::consumeQuotedString): Ditto. +(WebCore::WebSocketExtensionParser::consumeQuotedStringOrToken): Ditto. +(WebCore::WebSocketExtensionParser::consumeCharacter): Ditto. +(WebCore::WebSocketExtensionParser::parseExtension): Moved from WebSocketExtensionDispatcher. +
[webkit-changes] [130469] trunk
Title: [130469] trunk
Revision 130469
Author commit-qu...@webkit.org
Date 2012-10-04 23:41:30 -0700 (Thu, 04 Oct 2012)
Log Message
size attribute should throw INDEX_SIZE_ERR when set to 0
https://bugs.webkit.org/show_bug.cgi?id=61675
Patch by Kunihiko Sakamoto on 2012-10-04
Reviewed by Kent Tamura.
Source/WebCore:
According to the spec, the size IDL attribute of input elements is limited
to only non-negative numbers greater than zero. It should throw INDEX_SIZE_ERR
exception when set to 0. New behavior matches both Firefox and IE.
Spec: http://www.w3.org/TR/html5/common-input-element-attributes.html#the-size-attribute
Test: fast/dom/HTMLInputElement/input-size-attribute.html
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::setSize):
* html/HTMLInputElement.h:
(HTMLInputElement):
* html/HTMLInputElement.idl:
LayoutTests:
Added test case to verify that input.size throws INDEX_SIZE_ERR when set to 0.
Updated fast/forms/number/number-size.html to reflect new behavior.
* fast/dom/HTMLInputElement/input-size-attribute-expected.txt:
* fast/dom/HTMLInputElement/input-size-attribute.html:
* fast/forms/number/number-size.html:
* fast/forms/number/number-size-expected.txt:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/dom/HTMLInputElement/input-size-attribute-expected.txt
trunk/LayoutTests/fast/dom/HTMLInputElement/input-size-attribute.html
trunk/LayoutTests/fast/forms/number/number-size-expected.txt
trunk/LayoutTests/fast/forms/number/number-size.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/HTMLInputElement.cpp
trunk/Source/WebCore/html/HTMLInputElement.h
trunk/Source/WebCore/html/HTMLInputElement.idl
Diff
Modified: trunk/LayoutTests/ChangeLog (130468 => 130469)
--- trunk/LayoutTests/ChangeLog 2012-10-05 06:39:21 UTC (rev 130468)
+++ trunk/LayoutTests/ChangeLog 2012-10-05 06:41:30 UTC (rev 130469)
@@ -1,3 +1,19 @@
+2012-10-04 Kunihiko Sakamoto
+
+ size attribute should throw INDEX_SIZE_ERR when set to 0
+https://bugs.webkit.org/show_bug.cgi?id=61675
+
+Reviewed by Kent Tamura.
+
+Added test case to verify that input.size throws INDEX_SIZE_ERR when set to 0.
+
+Updated fast/forms/number/number-size.html to reflect new behavior.
+
+* fast/dom/HTMLInputElement/input-size-attribute-expected.txt:
+* fast/dom/HTMLInputElement/input-size-attribute.html:
+* fast/forms/number/number-size.html:
+* fast/forms/number/number-size-expected.txt:
+
2012-10-04 Christophe Dumez
[WK2][WKTR] Implement UIClient focus callbacks in WebKitTestRunner
Modified: trunk/LayoutTests/fast/dom/HTMLInputElement/input-size-attribute-expected.txt (130468 => 130469)
--- trunk/LayoutTests/fast/dom/HTMLInputElement/input-size-attribute-expected.txt 2012-10-05 06:39:21 UTC (rev 130468)
+++ trunk/LayoutTests/fast/dom/HTMLInputElement/input-size-attribute-expected.txt 2012-10-05 06:41:30 UTC (rev 130469)
@@ -13,6 +13,7 @@
PASS input.removeAttribute('size'); input.size is 20
PASS input.setAttribute('size', '0'); input.size is 20
PASS input.setAttribute('size', '10'); input.size is 10
+PASS input.size = 0 threw exception Error: INDEX_SIZE_ERR: DOM Exception 1.
PASS successfullyParsed is true
TEST COMPLETE
Modified: trunk/LayoutTests/fast/dom/HTMLInputElement/input-size-attribute.html (130468 => 130469)
--- trunk/LayoutTests/fast/dom/HTMLInputElement/input-size-attribute.html 2012-10-05 06:39:21 UTC (rev 130468)
+++ trunk/LayoutTests/fast/dom/HTMLInputElement/input-size-attribute.html 2012-10-05 06:41:30 UTC (rev 130469)
@@ -22,6 +22,9 @@
shouldBe("input.removeAttribute('size'); input.size", "20");
shouldBe("input.setAttribute('size', '0'); input.size", "20");
shouldBe("input.setAttribute('size', '10'); input.size", "10");
+
+shouldThrow("input.size = 0", "'Error: INDEX_SIZE_ERR: DOM Exception 1'");
+
Modified: trunk/LayoutTests/fast/forms/number/number-size-expected.txt (130468 => 130469)
--- trunk/LayoutTests/fast/forms/number/number-size-expected.txt 2012-10-05 06:39:21 UTC (rev 130468)
+++ trunk/LayoutTests/fast/forms/number/number-size-expected.txt 2012-10-05 06:41:30 UTC (rev 130469)
@@ -16,6 +16,7 @@
PASS number.size is 10
PASS number.size = 100; number.offsetWidth is text.offsetWidth
PASS number.size is 100
+PASS number.size = null threw exception Error: INDEX_SIZE_ERR: DOM Exception 1.
If min or max is absent, the number input has the same width as input[type=text]
PASS numberWidth(0, null, null) is text.offsetWidth
Modified: trunk/LayoutTests/fast/forms/number/number-size.html (130468 => 130469)
--- trunk/LayoutTests/fast/forms/number/number-size.html 2012-10-05 06:39:21 UTC (rev 130468)
+++ trunk/LayoutTests/fast/forms/number/number-size.html 2012-10-05 06:41:30 UTC (rev 130469)
@@ -63,7 +63,7 @@
shouldBe('number.size', '10');
shouldBe('number.size = 100; number.offsetWidth', 'text.offsetWidth');
shouldBe('number.size', '100');
-number.size = null;
+
[webkit-changes] [130468] trunk/Source/WebKit/chromium
Title: [130468] trunk/Source/WebKit/chromium
Revision 130468
Author ba...@chromium.org
Date 2012-10-04 23:39:21 -0700 (Thu, 04 Oct 2012)
Log Message
[Chromium] Improve SocketStreamHandle::send() stability
https://bugs.webkit.org/show_bug.cgi?id=98459
Reviewed by Yuta Kitamura.
Avoid null dereference in SocketStreamHandleInternal::send().
No changes in behavior.
* src/SocketStreamHandle.cpp:
(WebCore::SocketStreamHandleInternal::send):
Modified Paths
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/src/SocketStreamHandle.cpp
Diff
Modified: trunk/Source/WebKit/chromium/ChangeLog (130467 => 130468)
--- trunk/Source/WebKit/chromium/ChangeLog 2012-10-05 06:24:56 UTC (rev 130467)
+++ trunk/Source/WebKit/chromium/ChangeLog 2012-10-05 06:39:21 UTC (rev 130468)
@@ -1,3 +1,16 @@
+2012-10-04 Kenichi Ishibashi
+
+[Chromium] Improve SocketStreamHandle::send() stability
+https://bugs.webkit.org/show_bug.cgi?id=98459
+
+Reviewed by Yuta Kitamura.
+
+Avoid null dereference in SocketStreamHandleInternal::send().
+No changes in behavior.
+
+* src/SocketStreamHandle.cpp:
+(WebCore::SocketStreamHandleInternal::send):
+
2012-10-04 Dirk Pranke
Chromium DEPS roll r160281:160322
Modified: trunk/Source/WebKit/chromium/src/SocketStreamHandle.cpp (130467 => 130468)
--- trunk/Source/WebKit/chromium/src/SocketStreamHandle.cpp 2012-10-05 06:24:56 UTC (rev 130467)
+++ trunk/Source/WebKit/chromium/src/SocketStreamHandle.cpp 2012-10-05 06:39:21 UTC (rev 130468)
@@ -72,7 +72,13 @@
int SocketStreamHandleInternal::send(const char* data, int len)
{
LOG(Network, "send len=%d", len);
-ASSERT(m_socket);
+// FIXME: |m_socket| should not be null here, but it seems that there is the
+// case. We should figure out such a path and fix it rather than checking
+// null here.
+if (!m_socket) {
+LOG(Network, "m_socket is null when sending. It should not be.");
+return 0;
+}
if (m_pendingAmountSent + len >= m_maxPendingSendAllowed)
len = m_maxPendingSendAllowed - m_pendingAmountSent - 1;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [130467] trunk/Source/WebCore
Title: [130467] trunk/Source/WebCore
Revision 130467
Author tk...@chromium.org
Date 2012-10-04 23:24:56 -0700 (Thu, 04 Oct 2012)
Log Message
Fix font for date/time input types.
https://bugs.webkit.org/show_bug.cgi?id=98478
Reviewed by Kentaro Hara.
input[type=date] should use monospace font if
ENABLE_INPUT_MULTIPLE_FIELDS_UI && ENABLE_INPUT_TYPE_DATE.
For other date/time types, they should use monospace font only
if their types are enabled. input[type="foo"] matches input
element with type="foo" even if the foo type is not supported.
The input[type=date] change is covered by
fast/forms/date/calendar-picker-appearance.html,
platform/chromium/fast/forms/date/date-suggestion-picker-appearance*.html
* css/html.css:
(input[type="date"]):
(input[type="datetime"]):
(input[type="datetime-local"]):
(input[type="month"]):
(input[type="time"]):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/html.css
Diff
Modified: trunk/Source/WebCore/ChangeLog (130466 => 130467)
--- trunk/Source/WebCore/ChangeLog 2012-10-05 06:22:19 UTC (rev 130466)
+++ trunk/Source/WebCore/ChangeLog 2012-10-05 06:24:56 UTC (rev 130467)
@@ -1,3 +1,28 @@
+2012-10-04 Kent Tamura
+
+Fix font for date/time input types.
+https://bugs.webkit.org/show_bug.cgi?id=98478
+
+Reviewed by Kentaro Hara.
+
+input[type=date] should use monospace font if
+ENABLE_INPUT_MULTIPLE_FIELDS_UI && ENABLE_INPUT_TYPE_DATE.
+
+For other date/time types, they should use monospace font only
+if their types are enabled. input[type="foo"] matches input
+element with type="foo" even if the foo type is not supported.
+
+The input[type=date] change is covered by
+fast/forms/date/calendar-picker-appearance.html,
+platform/chromium/fast/forms/date/date-suggestion-picker-appearance*.html
+
+* css/html.css:
+(input[type="date"]):
+(input[type="datetime"]):
+(input[type="datetime-local"]):
+(input[type="month"]):
+(input[type="time"]):
+
2012-10-04 Hajime Morrita
[Refactoring] Some classes in StyleResolver.cpp/h could have its own file.
Modified: trunk/Source/WebCore/css/html.css (130466 => 130467)
--- trunk/Source/WebCore/css/html.css 2012-10-05 06:22:19 UTC (rev 130466)
+++ trunk/Source/WebCore/css/html.css 2012-10-05 06:24:56 UTC (rev 130467)
@@ -477,13 +477,36 @@
#endif
#if defined(ENABLE_INPUT_MULTIPLE_FIELDS_UI) && ENABLE_INPUT_MULTIPLE_FIELDS_UI
-input[type="datetime"],
-input[type="datetime-local"],
-input[type="month"],
-input[type="time"],
+#if defined(ENABLE_INPUT_TYPE_DATE) && ENABLE_INPUT_TYPE_DATE
+input[type="date"] {
+font-family: monospace;
+}
+#endif
+#if defined(ENABLE_INPUT_TYPE_DATETIME) && ENABLE_INPUT_TYPE_DATETIME
+input[type="datetime"] {
+font-family: monospace;
+}
+#endif
+#if defined(ENABLE_INPUT_TYPE_DATETIMELOCAL) && ENABLE_INPUT_TYPE_DATETIMELOCAL
+input[type="datetime-local"] {
+font-family: monospace;
+}
+#endif
+#if defined(ENABLE_INPUT_TYPE_MONTH) && ENABLE_INPUT_TYPE_MONTH
+input[type="month"] {
+font-family: monospace;
+}
+#endif
+#if defined(ENABLE_INPUT_TYPE_TIME) && ENABLE_INPUT_TYPE_TIME
+input[type="time"] {
+font-family: monospace;
+}
+#endif
+#if defined(ENABLE_INPUT_TYPE_WEEK) && ENABLE_INPUT_TYPE_WEEK
input[type="week"] {
font-family: monospace;
}
+#endif
input::-webkit-datetime-edit {
-webkit-user-modify: read-only !important;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [130466] trunk
Title: [130466] trunk
Revision 130466
Author commit-qu...@webkit.org
Date 2012-10-04 23:22:19 -0700 (Thu, 04 Oct 2012)
Log Message
[WK2][WKTR] Implement UIClient focus callbacks in WebKitTestRunner
https://bugs.webkit.org/show_bug.cgi?id=98256
Patch by Christophe Dumez on 2012-10-04
Reviewed by Kenneth Rohde Christiansen.
Tools:
Implement UIClient's focus callbacks in WebKitTestRunner.
* WebKitTestRunner/TestController.cpp:
(WTR::focus):
(WTR::TestController::initialize):
LayoutTests:
Unskip fast/dom/Window/mozilla-focus-blur.html now that
WebKitTestRunner implements UIClient's focus callbacks.
* platform/efl-wk2/TestExpectations:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/efl-wk2/TestExpectations
trunk/Tools/ChangeLog
trunk/Tools/WebKitTestRunner/TestController.cpp
Diff
Modified: trunk/LayoutTests/ChangeLog (130465 => 130466)
--- trunk/LayoutTests/ChangeLog 2012-10-05 06:15:20 UTC (rev 130465)
+++ trunk/LayoutTests/ChangeLog 2012-10-05 06:22:19 UTC (rev 130466)
@@ -1,3 +1,15 @@
+2012-10-04 Christophe Dumez
+
+[WK2][WKTR] Implement UIClient focus callbacks in WebKitTestRunner
+https://bugs.webkit.org/show_bug.cgi?id=98256
+
+Reviewed by Kenneth Rohde Christiansen.
+
+Unskip fast/dom/Window/mozilla-focus-blur.html now that
+WebKitTestRunner implements UIClient's focus callbacks.
+
+* platform/efl-wk2/TestExpectations:
+
2012-10-04 Rik Cabanier
Turn Compositing on by default in WebKit build
Modified: trunk/LayoutTests/platform/efl-wk2/TestExpectations (130465 => 130466)
--- trunk/LayoutTests/platform/efl-wk2/TestExpectations 2012-10-05 06:15:20 UTC (rev 130465)
+++ trunk/LayoutTests/platform/efl-wk2/TestExpectations 2012-10-05 06:22:19 UTC (rev 130466)
@@ -198,7 +198,6 @@
webkit.org/b/93982 storage/domstorage/storage-close-database-on-idle.html [ Failure ]
# Unclassified failures
-Bug(EFL) fast/dom/Window/mozilla-focus-blur.html [ Failure ]
Bug(EFL) http/tests/inspector/network/network-sidebar-width.html [ Failure ]
# Fails after r128056.
Modified: trunk/Tools/ChangeLog (130465 => 130466)
--- trunk/Tools/ChangeLog 2012-10-05 06:15:20 UTC (rev 130465)
+++ trunk/Tools/ChangeLog 2012-10-05 06:22:19 UTC (rev 130466)
@@ -1,3 +1,16 @@
+2012-10-04 Christophe Dumez
+
+[WK2][WKTR] Implement UIClient focus callbacks in WebKitTestRunner
+https://bugs.webkit.org/show_bug.cgi?id=98256
+
+Reviewed by Kenneth Rohde Christiansen.
+
+Implement UIClient's focus callbacks in WebKitTestRunner.
+
+* WebKitTestRunner/TestController.cpp:
+(WTR::focus):
+(WTR::TestController::initialize):
+
2012-10-04 Rik Cabanier
Turn Compositing on by default in WebKit build
Modified: trunk/Tools/WebKitTestRunner/TestController.cpp (130465 => 130466)
--- trunk/Tools/WebKitTestRunner/TestController.cpp 2012-10-05 06:15:20 UTC (rev 130465)
+++ trunk/Tools/WebKitTestRunner/TestController.cpp 2012-10-05 06:22:19 UTC (rev 130466)
@@ -163,6 +163,7 @@
static void focus(WKPageRef page, const void* clientInfo)
{
PlatformWebView* view = static_cast(const_cast(clientInfo));
+view->focus();
view->setWindowIsKey(true);
}
@@ -362,8 +363,8 @@
0, // showPage
0, // close
0, // takeFocus
-0, // focus
-0, // unfocus
+focus,
+unfocus,
0, // runJavaScriptAlert
0, // runJavaScriptConfirm
0, // runJavaScriptPrompt
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [130464] trunk/Source/WebKit2
Title: [130464] trunk/Source/WebKit2
Revision 130464
Author commit-qu...@webkit.org
Date 2012-10-04 23:11:58 -0700 (Thu, 04 Oct 2012)
Log Message
[EFL][WK2] Implement window frame callbacks in UIClient
https://bugs.webkit.org/show_bug.cgi?id=98280
Patch by Christophe Dumez on 2012-10-04
Reviewed by Kenneth Rohde Christiansen.
Implement callbacks to set and query window geometry
in EwkView's UIClient.
* UIProcess/API/efl/ewk_view_ui_client.cpp:
(getWindowFrame):
(setWindowFrame):
(ewk_view_ui_client_attach):
* UIProcess/API/efl/tests/resources/window_move_resize.html: Added.
* UIProcess/API/efl/tests/test_ewk2_view.cpp:
(windowMoveResizeTimedOut):
(TEST_F): Add corresponding unit test.
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/efl/ewk_view_ui_client.cpp
trunk/Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_view.cpp
Added Paths
trunk/Source/WebKit2/UIProcess/API/efl/tests/resources/window_move_resize.html
Diff
Modified: trunk/Source/WebKit2/ChangeLog (130463 => 130464)
--- trunk/Source/WebKit2/ChangeLog 2012-10-05 06:02:03 UTC (rev 130463)
+++ trunk/Source/WebKit2/ChangeLog 2012-10-05 06:11:58 UTC (rev 130464)
@@ -1,3 +1,22 @@
+2012-10-04 Christophe Dumez
+
+[EFL][WK2] Implement window frame callbacks in UIClient
+https://bugs.webkit.org/show_bug.cgi?id=98280
+
+Reviewed by Kenneth Rohde Christiansen.
+
+Implement callbacks to set and query window geometry
+in EwkView's UIClient.
+
+* UIProcess/API/efl/ewk_view_ui_client.cpp:
+(getWindowFrame):
+(setWindowFrame):
+(ewk_view_ui_client_attach):
+* UIProcess/API/efl/tests/resources/window_move_resize.html: Added.
+* UIProcess/API/efl/tests/test_ewk2_view.cpp:
+(windowMoveResizeTimedOut):
+(TEST_F): Add corresponding unit test.
+
2012-10-04 Rik Cabanier
Turn Compositing on by default in WebKit build
Modified: trunk/Source/WebKit2/UIProcess/API/efl/ewk_view_ui_client.cpp (130463 => 130464)
--- trunk/Source/WebKit2/UIProcess/API/efl/ewk_view_ui_client.cpp 2012-10-05 06:02:03 UTC (rev 130463)
+++ trunk/Source/WebKit2/UIProcess/API/efl/ewk_view_ui_client.cpp 2012-10-05 06:11:58 UTC (rev 130464)
@@ -28,6 +28,7 @@
#include "WKString.h"
#include "ewk_view_private.h"
#include "ewk_view_ui_client_private.h"
+#include
static inline Evas_Object* toEwkView(const void* clientInfo)
{
@@ -96,6 +97,22 @@
evas_object_focus_set(toEwkView(clientInfo), false);
}
+static WKRect getWindowFrame(WKPageRef, const void* clientInfo)
+{
+int x, y, width, height;
+
+Ecore_Evas* ee = ecore_evas_ecore_evas_get(evas_object_evas_get(toEwkView(clientInfo)));
+ecore_evas_request_geometry_get(ee, &x, &y, &width, &height);
+
+return WKRectMake(x, y, width, height);
+}
+
+static void setWindowFrame(WKPageRef, WKRect frame, const void* clientInfo)
+{
+Ecore_Evas* ee = ecore_evas_ecore_evas_get(evas_object_evas_get(toEwkView(clientInfo)));
+ecore_evas_move_resize(ee, frame.origin.x, frame.origin.y, frame.size.width, frame.size.height);
+}
+
void ewk_view_ui_client_attach(WKPageRef pageRef, Evas_Object* ewkView)
{
WKPageUIClient uiClient;
@@ -110,6 +127,8 @@
uiClient.takeFocus = takeFocus;
uiClient.focus = focus;
uiClient.unfocus = unfocus;
+uiClient.getWindowFrame = getWindowFrame;
+uiClient.setWindowFrame = setWindowFrame;
#if ENABLE(SQL_DATABASE)
uiClient.exceededDatabaseQuota = exceededDatabaseQuota;
#endif
Added: trunk/Source/WebKit2/UIProcess/API/efl/tests/resources/window_move_resize.html (0 => 130464)
--- trunk/Source/WebKit2/UIProcess/API/efl/tests/resources/window_move_resize.html (rev 0)
+++ trunk/Source/WebKit2/UIProcess/API/efl/tests/resources/window_move_resize.html 2012-10-05 06:11:58 UTC (rev 130464)
@@ -0,0 +1,15 @@
+
+
+Window move and resize test
+
+function test()
+{
+window.resizeTo(200, 100);
+window.moveTo(150, 200);
+document.title = "Moved and resized";
+}
+
+
+
+
+
Modified: trunk/Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_view.cpp (130463 => 130464)
--- trunk/Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_view.cpp 2012-10-05 06:02:03 UTC (rev 130463)
+++ trunk/Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_view.cpp 2012-10-05 06:11:58 UTC (rev 130464)
@@ -864,3 +864,28 @@
ASSERT_TRUE(ewk_view_touch_events_enabled_set(webView(), false));
ASSERT_FALSE(ewk_view_touch_events_enabled_get(webView()));
}
+
+Eina_Bool windowMoveResizeTimedOut(void* data)
+{
+*static_cast(data) = true;
+}
+
+TEST_F(EWK2UnitTestBase, window_move_resize)
+{
+int x, y, width, height;
+Ecore_Evas* ee = ecore_evas_ecore_evas_get(evas_object_evas_get(webView()));
+ecore_evas_geometry_get(ee, 0, 0, &width, &height);
+
+EXPECT_EQ(800, width);
+EXPECT_EQ(600, height);
+
+ewk_view_uri_set(webView(), environment->urlForResource("window_move_resize.html").data()
[webkit-changes] [130463] trunk/Source/WebCore
Title: [130463] trunk/Source/WebCore
Revision 130463
Author aba...@webkit.org
Date 2012-10-04 23:02:03 -0700 (Thu, 04 Oct 2012)
Log Message
FeatureObserver should distinguish between legacy HTML and text notifications
https://bugs.webkit.org/show_bug.cgi?id=98441
Reviewed by Tony Chang.
We might be able to drop support for legacy HTML notifications before
we can drop support for legacy text notifications. We should measure
and find out.
* Modules/notifications/NotificationCenter.idl:
* page/FeatureObserver.h:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/notifications/NotificationCenter.idl
trunk/Source/WebCore/page/FeatureObserver.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (130462 => 130463)
--- trunk/Source/WebCore/ChangeLog 2012-10-05 05:00:37 UTC (rev 130462)
+++ trunk/Source/WebCore/ChangeLog 2012-10-05 06:02:03 UTC (rev 130463)
@@ -1,3 +1,17 @@
+2012-10-04 Adam Barth
+
+FeatureObserver should distinguish between legacy HTML and text notifications
+https://bugs.webkit.org/show_bug.cgi?id=98441
+
+Reviewed by Tony Chang.
+
+We might be able to drop support for legacy HTML notifications before
+we can drop support for legacy text notifications. We should measure
+and find out.
+
+* Modules/notifications/NotificationCenter.idl:
+* page/FeatureObserver.h:
+
2012-10-04 Pravin D
Removing the unused member variable m_wasMalformed from HTMLFormElement class and its related code frgment.
Modified: trunk/Source/WebCore/Modules/notifications/NotificationCenter.idl (130462 => 130463)
--- trunk/Source/WebCore/Modules/notifications/NotificationCenter.idl 2012-10-05 05:00:37 UTC (rev 130462)
+++ trunk/Source/WebCore/Modules/notifications/NotificationCenter.idl 2012-10-05 06:02:03 UTC (rev 130463)
@@ -37,9 +37,9 @@
OmitConstructor
] NotificationCenter {
#if !defined(ENABLE_TEXT_NOTIFICATIONS_ONLY) || !ENABLE_TEXT_NOTIFICATIONS_ONLY
- [V8EnabledPerContext=htmlNotifications] Notification createHTMLNotification(in DOMString url) raises(DOMException);
+ [V8EnabledPerContext=htmlNotifications, V8MeasureAs=LegacyHTMLNotifications] Notification createHTMLNotification(in DOMString url) raises(DOMException);
#endif
- Notification createNotification(in DOMString iconUrl, in DOMString title, in DOMString body) raises(DOMException);
+ [V8MeasureAs=LegacyTextNotifications] Notification createNotification(in DOMString iconUrl, in DOMString title, in DOMString body) raises(DOMException);
int checkPermission();
[Custom] void requestPermission(in VoidCallback callback);
Modified: trunk/Source/WebCore/page/FeatureObserver.h (130462 => 130463)
--- trunk/Source/WebCore/page/FeatureObserver.h 2012-10-05 05:00:37 UTC (rev 130462)
+++ trunk/Source/WebCore/page/FeatureObserver.h 2012-10-05 06:02:03 UTC (rev 130463)
@@ -50,6 +50,8 @@
PrefixedContentSecurityPolicy,
UnprefixedIndexedDB,
OpenWebDatabase,
+LegacyHTMLNotifications,
+LegacyTextNotifications,
// Add new features above this line.
NumberOfFeatures, // This enum value must be last.
};
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [130462] trunk/Source/WebKit/chromium
Title: [130462] trunk/Source/WebKit/chromium
Revision 130462
Author dpra...@chromium.org
Date 2012-10-04 22:00:37 -0700 (Thu, 04 Oct 2012)
Log Message
Chromium DEPS roll r160281:160322
Unreviewed.
* DEPS:
Modified Paths
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/DEPS
Diff
Modified: trunk/Source/WebKit/chromium/ChangeLog (130461 => 130462)
--- trunk/Source/WebKit/chromium/ChangeLog 2012-10-05 04:59:49 UTC (rev 130461)
+++ trunk/Source/WebKit/chromium/ChangeLog 2012-10-05 05:00:37 UTC (rev 130462)
@@ -1,3 +1,11 @@
+2012-10-04 Dirk Pranke
+
+Chromium DEPS roll r160281:160322
+
+Unreviewed.
+
+* DEPS:
+
2012-10-04 Alexandre Elias
[chromium] Scale plugin container by frameScaleFactor
Modified: trunk/Source/WebKit/chromium/DEPS (130461 => 130462)
--- trunk/Source/WebKit/chromium/DEPS 2012-10-05 04:59:49 UTC (rev 130461)
+++ trunk/Source/WebKit/chromium/DEPS 2012-10-05 05:00:37 UTC (rev 130462)
@@ -32,7 +32,7 @@
vars = {
'chromium_svn': 'http://src.chromium.org/svn/trunk/src',
- 'chromium_rev': '160281'
+ 'chromium_rev': '160322'
}
deps = {
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [130461] trunk/Source/WebCore
Title: [130461] trunk/Source/WebCore
Revision 130461
Author commit-qu...@webkit.org
Date 2012-10-04 21:59:49 -0700 (Thu, 04 Oct 2012)
Log Message
Removing the unused member variable m_wasMalformed from HTMLFormElement class and its related code frgment.
https://bugs.webkit.org/show_bug.cgi?id=98444
Patch by Pravin D on 2012-10-04
Reviewed by Eric Seidel.
The member variable m_wasMalformed of HTMLFormElement class was used to determine if the tag was malformed or not.
This information was used elsewhere to decide if bottom margins have to be included for such a .
However currently this member variable is not being set by any code following code refactoring in HTML parser class.
Code cleanup patch. No new tests required.
* html/HTMLFormElement.cpp:
(WebCore::HTMLFormElement::HTMLFormElement):
Removed m_wasMalformed initialization.
* html/HTMLFormElement.h:
(HTMLFormElement):
Removed m_wasMalformed variable.
Removed m_wasMalformed variable's setter and getter functions.
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::layoutBlock):
Removed code fragment using/dependent on m_wasMalformed.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/HTMLFormElement.cpp
trunk/Source/WebCore/html/HTMLFormElement.h
trunk/Source/WebCore/rendering/RenderBlock.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (130460 => 130461)
--- trunk/Source/WebCore/ChangeLog 2012-10-05 04:56:44 UTC (rev 130460)
+++ trunk/Source/WebCore/ChangeLog 2012-10-05 04:59:49 UTC (rev 130461)
@@ -1,3 +1,29 @@
+2012-10-04 Pravin D
+
+Removing the unused member variable m_wasMalformed from HTMLFormElement class and its related code frgment.
+https://bugs.webkit.org/show_bug.cgi?id=98444
+
+Reviewed by Eric Seidel.
+
+The member variable m_wasMalformed of HTMLFormElement class was used to determine if the tag was malformed or not.
+This information was used elsewhere to decide if bottom margins have to be included for such a .
+However currently this member variable is not being set by any code following code refactoring in HTML parser class.
+
+Code cleanup patch. No new tests required.
+
+* html/HTMLFormElement.cpp:
+(WebCore::HTMLFormElement::HTMLFormElement):
+ Removed m_wasMalformed initialization.
+
+* html/HTMLFormElement.h:
+(HTMLFormElement):
+ Removed m_wasMalformed variable.
+ Removed m_wasMalformed variable's setter and getter functions.
+
+* rendering/RenderBlock.cpp:
+(WebCore::RenderBlock::layoutBlock):
+ Removed code fragment using/dependent on m_wasMalformed.
+
2012-10-04 Rik Cabanier
Turn Compositing on by default in WebKit build
Modified: trunk/Source/WebCore/html/HTMLFormElement.cpp (130460 => 130461)
--- trunk/Source/WebCore/html/HTMLFormElement.cpp 2012-10-05 04:56:44 UTC (rev 130460)
+++ trunk/Source/WebCore/html/HTMLFormElement.cpp 2012-10-05 04:59:49 UTC (rev 130461)
@@ -74,7 +74,6 @@
, m_isSubmittingOrPreparingForSubmission(false)
, m_shouldSubmit(false)
, m_isInResetFunction(false)
-, m_wasMalformed(false)
, m_wasDemoted(false)
{
ASSERT(hasTagName(formTag));
Modified: trunk/Source/WebCore/html/HTMLFormElement.h (130460 => 130461)
--- trunk/Source/WebCore/html/HTMLFormElement.h 2012-10-05 04:56:44 UTC (rev 130460)
+++ trunk/Source/WebCore/html/HTMLFormElement.h 2012-10-05 04:59:49 UTC (rev 130461)
@@ -73,11 +73,6 @@
void submitFromJavaScript();
void reset();
-// Used to indicate a malformed state to keep from applying the bottom margin of the form.
-// FIXME: Would probably be better to call this wasUnclosed; that's more specific.
-void setMalformed(bool malformed) { m_wasMalformed = malformed; }
-bool isMalformed() const { return m_wasMalformed; }
-
void setDemoted(bool demoted) { m_wasDemoted = demoted; }
void submitImplicitly(Event*, bool fromImplicitSubmissionTrigger);
@@ -166,7 +161,6 @@
bool m_isInResetFunction;
-bool m_wasMalformed;
bool m_wasDemoted;
};
Modified: trunk/Source/WebCore/rendering/RenderBlock.cpp (130460 => 130461)
--- trunk/Source/WebCore/rendering/RenderBlock.cpp 2012-10-05 04:56:44 UTC (rev 130460)
+++ trunk/Source/WebCore/rendering/RenderBlock.cpp 2012-10-05 04:59:49 UTC (rev 130461)
@@ -1543,14 +1543,6 @@
setMarginBeforeQuirk(styleToUse->marginBefore().quirk());
setMarginAfterQuirk(styleToUse->marginAfter().quirk());
-
-Node* n = node();
-if (n && n->hasTagName(formTag) && static_cast(n)->isMalformed()) {
-// See if this form is malformed (i.e., unclosed). If so, don't give the form
-// a bottom margin.
-setMaxMarginAfterValues(0, 0);
-}
-
setPaginationStrut(0);
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://list
[webkit-changes] [130460] trunk
Title: [130460] trunk
Revision 130460
Author commit-qu...@webkit.org
Date 2012-10-04 21:56:44 -0700 (Thu, 04 Oct 2012)
Log Message
Turn Compositing on by default in WebKit build
https://bugs.webkit.org/show_bug.cgi?id=98315
Patch by Rik Cabanier on 2012-10-04
Reviewed by Simon Fraser.
enable -webkit-blend-mode on trunk.
Source/_javascript_Core:
* Configurations/FeatureDefines.xcconfig:
Source/WebCore:
No new tests. Existing blending test were updated.
* Configurations/FeatureDefines.xcconfig:
* css/CSSPropertyNames.in:
* css/CSSValueKeywords.in:
Source/WebKit/mac:
* Configurations/FeatureDefines.xcconfig:
Source/WebKit2:
* Configurations/FeatureDefines.xcconfig:
Tools:
* Scripts/webkitperl/FeatureList.pm:
LayoutTests:
* css3/compositing/blend-mode-property-expected.txt:
* css3/compositing/blend-mode-property-parsing-expected.txt:
* css3/compositing/script-tests/blend-mode-property.js:
(testblendmode):
* css3/compositing/should-have-compositing-layer-expected.txt:
* platform/chromium/TestExpectations:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/css3/compositing/blend-mode-property-expected.txt
trunk/LayoutTests/css3/compositing/blend-mode-property-parsing-expected.txt
trunk/LayoutTests/css3/compositing/script-tests/blend-mode-property.js
trunk/LayoutTests/css3/compositing/should-have-compositing-layer-expected.txt
trunk/LayoutTests/platform/chromium/TestExpectations
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/Configurations/FeatureDefines.xcconfig
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Configurations/FeatureDefines.xcconfig
trunk/Source/WebCore/css/CSSPropertyNames.in
trunk/Source/WebKit/mac/ChangeLog
trunk/Source/WebKit/mac/Configurations/FeatureDefines.xcconfig
trunk/Source/WebKit2/ChangeLog
trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitperl/FeatureList.pm
Diff
Modified: trunk/LayoutTests/ChangeLog (130459 => 130460)
--- trunk/LayoutTests/ChangeLog 2012-10-05 04:47:21 UTC (rev 130459)
+++ trunk/LayoutTests/ChangeLog 2012-10-05 04:56:44 UTC (rev 130460)
@@ -1,3 +1,19 @@
+2012-10-04 Rik Cabanier
+
+Turn Compositing on by default in WebKit build
+https://bugs.webkit.org/show_bug.cgi?id=98315
+
+Reviewed by Simon Fraser.
+
+enable -webkit-blend-mode on trunk.
+
+* css3/compositing/blend-mode-property-expected.txt:
+* css3/compositing/blend-mode-property-parsing-expected.txt:
+* css3/compositing/script-tests/blend-mode-property.js:
+(testblendmode):
+* css3/compositing/should-have-compositing-layer-expected.txt:
+* platform/chromium/TestExpectations:
+
2012-10-04 Kent Tamura
Update some picker tests for input[type=date]
Modified: trunk/LayoutTests/css3/compositing/blend-mode-property-expected.txt (130459 => 130460)
--- trunk/LayoutTests/css3/compositing/blend-mode-property-expected.txt 2012-10-05 04:47:21 UTC (rev 130459)
+++ trunk/LayoutTests/css3/compositing/blend-mode-property-expected.txt 2012-10-05 04:56:44 UTC (rev 130460)
@@ -3,54 +3,54 @@
On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
-FAIL cssRule.type should be 1. Threw exception ReferenceError: Can't find variable: cssRule
-FAIL declaration.length should be 1. Threw exception ReferenceError: Can't find variable: declaration
-FAIL declaration.getPropertyValue('-webkit-blend-mode') should be normal. Threw exception ReferenceError: Can't find variable: declaration
-FAIL cssRule.type should be 1. Threw exception ReferenceError: Can't find variable: cssRule
-FAIL declaration.length should be 1. Threw exception ReferenceError: Can't find variable: declaration
-FAIL declaration.getPropertyValue('-webkit-blend-mode') should be multiply. Threw exception ReferenceError: Can't find variable: declaration
-FAIL cssRule.type should be 1. Threw exception ReferenceError: Can't find variable: cssRule
-FAIL declaration.length should be 1. Threw exception ReferenceError: Can't find variable: declaration
-FAIL declaration.getPropertyValue('-webkit-blend-mode') should be screen. Threw exception ReferenceError: Can't find variable: declaration
-FAIL cssRule.type should be 1. Threw exception ReferenceError: Can't find variable: cssRule
-FAIL declaration.length should be 1. Threw exception ReferenceError: Can't find variable: declaration
-FAIL declaration.getPropertyValue('-webkit-blend-mode') should be overlay. Threw exception ReferenceError: Can't find variable: declaration
-FAIL cssRule.type should be 1. Threw exception ReferenceError: Can't find variable: cssRule
-FAIL declaration.length should be 1. Threw exception ReferenceError: Can't find variable: declaration
-FAIL declaration.getPropertyValue('-webkit-blend-mode') should be darken. Threw exception ReferenceError: Can't find variable: declaration
-FAIL cssRule.type should be 1. Threw exception ReferenceError: Can't find variable: cssRule
-FAIL declaration.length should be 1. Threw ex
[webkit-changes] [130459] trunk
Title: [130459] trunk
Revision 130459
Author hay...@chromium.org
Date 2012-10-04 21:47:21 -0700 (Thu, 04 Oct 2012)
Log Message
[Refactoring] Introduce a traversal strategy in SelectorChecker
https://bugs.webkit.org/show_bug.cgi?id=97298
Reviewed by Antti Koivisto.
PerformanceTests:
Introduces querySelector() performance tests to check SelectorChecker performance.
* CSS/PseudoClassSelectors.html: Added.
Source/WebCore:
We extract DOM traversal code from SelectorChecker so that we can use another traversal strategy.
Another traversal strategy will be introduced in Bug 96990.
Since this code path is very hot, we were very careful not to regress performance.
We will use template specialization to change the traversal implementation.
We confirmed that this patch does not regress SelectorCheckerPerformance. I have checked the performance of
the added test in my Linux Box using run-perf-tests.
The performance of the added test before using this patch was:
RESULT CSS: PseudoClassSelectors= 3399.68308031 runs/s
median= 3404.48685564 runs/s, stdev= 37.3480114449 runs/s, min= 3272.64871114 runs/s, max= 3438.72385184 runs/s
When we used this patch, the performance was:
RESULT CSS: PseudoClassSelectors= 3367.74473886 runs/s
median= 3367.12072755 runs/s, stdev= 14.1464547639 runs/s, min= 3348.55881171 runs/s, max= 3395.98212857 runs/s
Test: PerformanceTests/CSS/PseudoClass-Selectors.html
* css/SelectorChecker.cpp:
(WebCore):
(WebCore::SelectorChecker::checkSelector): Make this a template method to accept another Context type.
Another Context type will be introduced in coming patch.
(WebCore::SelectorChecker::checkOneSelector):
(WebCore::SelectorChecker::DOMTraversalStrategy::isFirstChild):
(WebCore::SelectorChecker::DOMTraversalStrategy::isLastChild):
(WebCore::SelectorChecker::DOMTraversalStrategy::isFirstOfType):
(WebCore::SelectorChecker::DOMTraversalStrategy::isLastOfType):
(WebCore::SelectorChecker::DOMTraversalStrategy::countElementsBefore):
(WebCore::SelectorChecker::DOMTraversalStrategy::countElementsOfTypeBefore):
(WebCore::SelectorChecker::DOMTraversalStrategy::countElementsAfter):
(WebCore::SelectorChecker::DOMTraversalStrategy::countElementsOfTypeAfter):
* css/SelectorChecker.h:
(WebCore::SelectorChecker::SelectorCheckingContext::SelectorCheckingContext):
(SelectorCheckingContext):
(SelectorChecker):
(DOMTraversalStrategy): Extracted the DOM traversal code from SelectorChecker. Another traversal code
will be introduced the coming patch.
Modified Paths
trunk/PerformanceTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/SelectorChecker.cpp
trunk/Source/WebCore/css/SelectorChecker.h
Added Paths
trunk/PerformanceTests/CSS/PseudoClassSelectors.html
Diff
Added: trunk/PerformanceTests/CSS/PseudoClassSelectors.html (0 => 130459)
--- trunk/PerformanceTests/CSS/PseudoClassSelectors.html (rev 0)
+++ trunk/PerformanceTests/CSS/PseudoClassSelectors.html 2012-10-05 04:47:21 UTC (rev 130459)
@@ -0,0 +1,43 @@
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+PerfTestRunner.runPerSecond({
+description: "This benchmark tests CSS Selector performance with querySelector().",
+run: function() {
+for (var i = 0; i < 100; i++) {
+document.querySelector("p:first-child");
+document.querySelector("p:last-child");
+document.querySelector("p:first-of-type");
+document.querySelector("p:last-of-type");
+document.querySelector("p:nth-child(4n+3)");
+document.querySelector("p:nth-last-child(4n+3)");
+document.querySelector("p:nth-of-type(4n+3)");
+document.querySelector("p:nth-last-of-type(4n+3)");
+}
+}
+});
+
+
+
Modified: trunk/PerformanceTests/ChangeLog (130458 => 130459)
--- trunk/PerformanceTests/ChangeLog 2012-10-05 04:44:00 UTC (rev 130458)
+++ trunk/PerformanceTests/ChangeLog 2012-10-05 04:47:21 UTC (rev 130459)
@@ -1,3 +1,14 @@
+2012-10-04 Hayato Ito
+
+[Refactoring] Introduce a traversal strategy in SelectorChecker
+https://bugs.webkit.org/show_bug.cgi?id=97298
+
+Reviewed by Antti Koivisto.
+
+Introduces querySelector() performance tests to check SelectorChecker performance.
+
+* CSS/PseudoClassSelectors.html: Added.
+
2012-10-03 Philip Rogers
Force GC between PageLoad tests.
Modified: trunk/Source/WebCore/ChangeLog (130458 => 130459)
--- trunk/Source/WebCore/ChangeLog 2012-10-05 04:44:00 UTC (rev 130458)
+++ trunk/Source/WebCore/ChangeLog 2012-10-05 04:47:21 UTC (rev 130459)
@@ -1,3 +1,51 @@
+2012-10-04 Hayato Ito
+
+[Refactoring] Introduce a traversal strategy in SelectorChecker
+https://bugs.webkit.org/show_bug.cgi?id=97298
+
+Reviewed by Antti Koivisto.
+
+We extract DOM traversal code from Sel
[webkit-changes] [130458] trunk/LayoutTests
Title: [130458] trunk/LayoutTests
Revision 130458
Author tk...@chromium.org
Date 2012-10-04 21:44:00 -0700 (Thu, 04 Oct 2012)
Log Message
Update some picker tests for input[type=date]
https://bugs.webkit.org/show_bug.cgi?id=98390
Follow up of r130433. We still need offsetTop access.
* fast/forms/date/calendar-picker-common.js:
(openPicker):
* fast/forms/resources/suggestion-picker-common.js:
(openPicker):
* platform/chromium/fast/forms/date/date-suggestion-picker-appearance-rtl.html:
Remove unnecessary width style.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/forms/date/calendar-picker-common.js
trunk/LayoutTests/fast/forms/resources/suggestion-picker-common.js
trunk/LayoutTests/platform/chromium/fast/forms/date/date-suggestion-picker-appearance-rtl.html
Diff
Modified: trunk/LayoutTests/ChangeLog (130457 => 130458)
--- trunk/LayoutTests/ChangeLog 2012-10-05 04:37:39 UTC (rev 130457)
+++ trunk/LayoutTests/ChangeLog 2012-10-05 04:44:00 UTC (rev 130458)
@@ -1,3 +1,17 @@
+2012-10-04 Kent Tamura
+
+Update some picker tests for input[type=date]
+https://bugs.webkit.org/show_bug.cgi?id=98390
+
+Follow up of r130433. We still need offsetTop access.
+
+* fast/forms/date/calendar-picker-common.js:
+(openPicker):
+* fast/forms/resources/suggestion-picker-common.js:
+(openPicker):
+* platform/chromium/fast/forms/date/date-suggestion-picker-appearance-rtl.html:
+Remove unnecessary width style.
+
2012-10-04 Tony Chang
Convert some flexbox tests to run in mozilla
Modified: trunk/LayoutTests/fast/forms/date/calendar-picker-common.js (130457 => 130458)
--- trunk/LayoutTests/fast/forms/date/calendar-picker-common.js 2012-10-05 04:37:39 UTC (rev 130457)
+++ trunk/LayoutTests/fast/forms/date/calendar-picker-common.js 2012-10-05 04:44:00 UTC (rev 130458)
@@ -31,6 +31,7 @@
}
function openPicker(input) {
+input.offsetTop; // Force to lay out
sendKey(input, "Down", false, true);
popupWindow = document.getElementById('mock-page-popup').contentWindow;
}
Modified: trunk/LayoutTests/fast/forms/resources/suggestion-picker-common.js (130457 => 130458)
--- trunk/LayoutTests/fast/forms/resources/suggestion-picker-common.js 2012-10-05 04:37:39 UTC (rev 130457)
+++ trunk/LayoutTests/fast/forms/resources/suggestion-picker-common.js 2012-10-05 04:44:00 UTC (rev 130458)
@@ -18,6 +18,7 @@
}
function openPicker(input) {
+input.offsetTop; // Force to lay out
sendKey(input, "Down", false, true);
popupWindow = document.getElementById('mock-page-popup').contentWindow;
}
Modified: trunk/LayoutTests/platform/chromium/fast/forms/date/date-suggestion-picker-appearance-rtl.html (130457 => 130458)
--- trunk/LayoutTests/platform/chromium/fast/forms/date/date-suggestion-picker-appearance-rtl.html 2012-10-05 04:37:39 UTC (rev 130457)
+++ trunk/LayoutTests/platform/chromium/fast/forms/date/date-suggestion-picker-appearance-rtl.html 2012-10-05 04:44:00 UTC (rev 130458)
@@ -1,7 +1,7 @@
[webkit-changes] [130456] trunk/Source/WebCore
Title: [130456] trunk/Source/WebCore
Revision 130456
Author e...@webkit.org
Date 2012-10-04 21:22:31 -0700 (Thu, 04 Oct 2012)
Log Message
SVGAttributeHashTranslator does not need to copy QualifiedName in the common case
https://bugs.webkit.org/show_bug.cgi?id=98473
Reviewed by Adam Barth.
I tested this using instruments on a test case which modified SVG attributes in a loop.
I believe pdr has some perf-tests in this area, but they weren't needed here. A simple sample showed this as a huge win,
since we're no longer creating a QualifiedName (and thus adding it to the hash) on each QualifiedName-based lookup in SVG.
* svg/SVGElement.h:
(WebCore::SVGAttributeHashTranslator::hash):
(WebCore::SVGAttributeHashTranslator::equal):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/svg/SVGElement.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (130455 => 130456)
--- trunk/Source/WebCore/ChangeLog 2012-10-05 04:14:41 UTC (rev 130455)
+++ trunk/Source/WebCore/ChangeLog 2012-10-05 04:22:31 UTC (rev 130456)
@@ -1,3 +1,18 @@
+2012-10-04 Eric Seidel
+
+SVGAttributeHashTranslator does not need to copy QualifiedName in the common case
+https://bugs.webkit.org/show_bug.cgi?id=98473
+
+Reviewed by Adam Barth.
+
+I tested this using instruments on a test case which modified SVG attributes in a loop.
+I believe pdr has some perf-tests in this area, but they weren't needed here. A simple sample showed this as a huge win,
+since we're no longer creating a QualifiedName (and thus adding it to the hash) on each QualifiedName-based lookup in SVG.
+
+* svg/SVGElement.h:
+(WebCore::SVGAttributeHashTranslator::hash):
+(WebCore::SVGAttributeHashTranslator::equal):
+
2012-10-04 Julien Chaffraix
Split the intrinsic padding update code out of RenderTableSection::layoutRows
Modified: trunk/Source/WebCore/svg/SVGElement.h (130455 => 130456)
--- trunk/Source/WebCore/svg/SVGElement.h 2012-10-05 04:14:41 UTC (rev 130455)
+++ trunk/Source/WebCore/svg/SVGElement.h 2012-10-05 04:22:31 UTC (rev 130456)
@@ -157,12 +157,13 @@
};
struct SVGAttributeHashTranslator {
-static unsigned hash(QualifiedName key)
+static unsigned hash(const QualifiedName& key)
{
-key.setPrefix(nullAtom);
+if (key.hasPrefix())
+return DefaultHash::Hash::hash(QualifiedName(nullAtom, key.localName(), key.namespaceURI()));
return DefaultHash::Hash::hash(key);
}
-static bool equal(QualifiedName a, QualifiedName b) { return a.matches(b); }
+static bool equal(const QualifiedName& a, const QualifiedName& b) { return a.matches(b); }
};
inline SVGElement* toSVGElement(Element* element)
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [130455] trunk/Source/WebKit/chromium
Title: [130455] trunk/Source/WebKit/chromium Revision 130455 Author ael...@chromium.org Date 2012-10-04 21:14:41 -0700 (Thu, 04 Oct 2012) Log Message [chromium] Scale plugin container by frameScaleFactor https://bugs.webkit.org/show_bug.cgi?id=98468 Reviewed by Adam Barth. Plugin containers (for invalid plugins) weren't taking into account frameScaleFactor, looking cut off when that was non-1. * src/WebPluginContainerImpl.cpp: (WebKit::WebPluginContainerImpl::paint): Modified Paths trunk/Source/WebKit/chromium/ChangeLog trunk/Source/WebKit/chromium/src/WebPluginContainerImpl.cpp Diff Modified: trunk/Source/WebKit/chromium/ChangeLog (130454 => 130455) --- trunk/Source/WebKit/chromium/ChangeLog 2012-10-05 03:56:17 UTC (rev 130454) +++ trunk/Source/WebKit/chromium/ChangeLog 2012-10-05 04:14:41 UTC (rev 130455) @@ -1,3 +1,16 @@ +2012-10-04 Alexandre Elias + +[chromium] Scale plugin container by frameScaleFactor +https://bugs.webkit.org/show_bug.cgi?id=98468 + +Reviewed by Adam Barth. + +Plugin containers (for invalid plugins) weren't taking into account +frameScaleFactor, looking cut off when that was non-1. + +* src/WebPluginContainerImpl.cpp: +(WebKit::WebPluginContainerImpl::paint): + 2012-10-04 Alpha Lam Unreviewd. Chromium DEPS roll. Update to r160281. Modified: trunk/Source/WebKit/chromium/src/WebPluginContainerImpl.cpp (130454 => 130455) --- trunk/Source/WebKit/chromium/src/WebPluginContainerImpl.cpp 2012-10-05 03:56:17 UTC (rev 130454) +++ trunk/Source/WebKit/chromium/src/WebPluginContainerImpl.cpp 2012-10-05 04:14:41 UTC (rev 130455) @@ -115,8 +115,13 @@ if (!parent()) return; +FloatRect scaledDamageRect = damageRect; +float frameScaleFactor = m_element->document()->page()->mainFrame()->frameScaleFactor(); +scaledDamageRect.scale(frameScaleFactor); +scaledDamageRect.move(-frameRect().x() * (frameScaleFactor - 1), -frameRect().y() * (frameScaleFactor - 1)); + // Don't paint anything if the plugin doesn't intersect the damage rect. -if (!frameRect().intersects(damageRect)) +if (!frameRect().intersects(enclosingIntRect(scaledDamageRect))) return; gc->save(); @@ -132,7 +137,7 @@ WebCanvas* canvas = gc->platformContext()->canvas(); IntRect windowRect = -IntRect(view->contentsToWindow(damageRect.location()), damageRect.size()); +IntRect(view->contentsToWindow(enclosingIntRect(scaledDamageRect))); m_webPlugin->paint(canvas, windowRect); gc->restore(); ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [130454] trunk/Source/WebCore
Title: [130454] trunk/Source/WebCore
Revision 130454
Author jchaffr...@webkit.org
Date 2012-10-04 20:56:17 -0700 (Thu, 04 Oct 2012)
Log Message
Split the intrinsic padding update code out of RenderTableSection::layoutRows
https://bugs.webkit.org/show_bug.cgi?id=98454
Reviewed by Eric Seidel.
RenderTableSection::layoutRows is very long and it's difficult to see what's
going on. This change moves the intrinsic padding update code into RenderTableCell
for clarity. While at it, cleaned up a bit the code (renaming variables, functions).
Change covered by existing table tests.
* rendering/RenderTableCell.cpp:
(WebCore::RenderTableCell::computeIntrinsicPadding):
Added this new function that does the update. Removed the 'default' case, replaced by
the explicit label BASELINE_MIDDLE.
* rendering/RenderTableCell.h:
(WebCore::RenderTableCell::setIntrinsicPaddingBefore):
(WebCore::RenderTableCell::setIntrinsicPaddingAfter):
(WebCore::RenderTableCell::setIntrinsicPadding):
Moved those setters to the private section as we want other classes
to use computeIntrinsicPadding.
* rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::layoutRows):
Replaced the code with a call to RenderTableCell::computeIntrinsicPadding.
Also moved 2 variables in the loop per our coding style.
* rendering/RenderTableSection.h:
(WebCore::RenderTableSection::rowBaseline):
Renamed to match our coding style.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderTableCell.cpp
trunk/Source/WebCore/rendering/RenderTableCell.h
trunk/Source/WebCore/rendering/RenderTableSection.cpp
trunk/Source/WebCore/rendering/RenderTableSection.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (130453 => 130454)
--- trunk/Source/WebCore/ChangeLog 2012-10-05 03:18:46 UTC (rev 130453)
+++ trunk/Source/WebCore/ChangeLog 2012-10-05 03:56:17 UTC (rev 130454)
@@ -1,3 +1,37 @@
+2012-10-04 Julien Chaffraix
+
+Split the intrinsic padding update code out of RenderTableSection::layoutRows
+https://bugs.webkit.org/show_bug.cgi?id=98454
+
+Reviewed by Eric Seidel.
+
+RenderTableSection::layoutRows is very long and it's difficult to see what's
+going on. This change moves the intrinsic padding update code into RenderTableCell
+for clarity. While at it, cleaned up a bit the code (renaming variables, functions).
+
+Change covered by existing table tests.
+
+* rendering/RenderTableCell.cpp:
+(WebCore::RenderTableCell::computeIntrinsicPadding):
+Added this new function that does the update. Removed the 'default' case, replaced by
+the explicit label BASELINE_MIDDLE.
+
+* rendering/RenderTableCell.h:
+(WebCore::RenderTableCell::setIntrinsicPaddingBefore):
+(WebCore::RenderTableCell::setIntrinsicPaddingAfter):
+(WebCore::RenderTableCell::setIntrinsicPadding):
+Moved those setters to the private section as we want other classes
+to use computeIntrinsicPadding.
+
+* rendering/RenderTableSection.cpp:
+(WebCore::RenderTableSection::layoutRows):
+Replaced the code with a call to RenderTableCell::computeIntrinsicPadding.
+Also moved 2 variables in the loop per our coding style.
+
+* rendering/RenderTableSection.h:
+(WebCore::RenderTableSection::rowBaseline):
+Renamed to match our coding style.
+
2012-10-04 Nate Chapin
Crash in EventHandler::mouseMoved().
Modified: trunk/Source/WebCore/rendering/RenderTableCell.cpp (130453 => 130454)
--- trunk/Source/WebCore/rendering/RenderTableCell.cpp 2012-10-05 03:18:46 UTC (rev 130453)
+++ trunk/Source/WebCore/rendering/RenderTableCell.cpp 2012-10-05 03:56:17 UTC (rev 130454)
@@ -198,6 +198,47 @@
}
}
+void RenderTableCell::computeIntrinsicPadding(int rowHeight)
+{
+int oldIntrinsicPaddingBefore = intrinsicPaddingBefore();
+int oldIntrinsicPaddingAfter = intrinsicPaddingAfter();
+int logicalHeightWithoutIntrinsicPadding = pixelSnappedLogicalHeight() - oldIntrinsicPaddingBefore - oldIntrinsicPaddingAfter;
+
+int intrinsicPaddingBefore = 0;
+switch (style()->verticalAlign()) {
+case SUB:
+case SUPER:
+case TEXT_TOP:
+case TEXT_BOTTOM:
+case LENGTH:
+case BASELINE: {
+LayoutUnit baseline = cellBaselinePosition();
+if (baseline > borderBefore() + paddingBefore())
+intrinsicPaddingBefore = section()->rowBaseline(rowIndex()) - (baseline - oldIntrinsicPaddingBefore);
+break;
+}
+case TOP:
+break;
+case MIDDLE:
+intrinsicPaddingBefore = (rowHeight - logicalHeightWithoutIntrinsicPadding) / 2;
+break;
+case BOTTOM:
+intrinsicPaddingBefore = rowHeight - logicalHeightWithoutIntrinsicPadding;
+break;
+case BASELINE_MIDDLE:
+break;
+}
+
+int intrinsicPaddingAfter = rowHeight - logicalHeightWithoutIntrinsicPadding - intrinsicPaddingBefore;
+
[webkit-changes] [130453] trunk/Source/WebKit2
Title: [130453] trunk/Source/WebKit2 Revision 130453 Author simon.fra...@apple.com Date 2012-10-04 20:18:46 -0700 (Thu, 04 Oct 2012) Log Message Fix the Qt build by removing an errant paste at the top of the file. * WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.h: Modified Paths trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.h Diff Modified: trunk/Source/WebKit2/ChangeLog (130452 => 130453) --- trunk/Source/WebKit2/ChangeLog 2012-10-05 02:55:44 UTC (rev 130452) +++ trunk/Source/WebKit2/ChangeLog 2012-10-05 03:18:46 UTC (rev 130453) @@ -1,3 +1,9 @@ +2012-10-04 Simon Fraser + +Fix the Qt build by removing an errant paste at the top of the file. + +* WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.h: + 2012-10-04 Ryuan Choi [EFL][WK2] Add APIs to get/set the frame flattening. Modified: trunk/Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.h (130452 => 130453) --- trunk/Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.h 2012-10-05 02:55:44 UTC (rev 130452) +++ trunk/Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.h 2012-10-05 03:18:46 UTC (rev 130453) @@ -1,4 +1,4 @@ -flushCompositingState/* +/* Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies) This library is free software; you can redistribute it and/or ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [130452] trunk/LayoutTests
Title: [130452] trunk/LayoutTests
Revision 130452
Author dpra...@chromium.org
Date 2012-10-04 19:55:44 -0700 (Thu, 04 Oct 2012)
Log Message
Update chromium baselines for 5006779.html and paint-subrect-grid.html.
Unreviewed, rebaselining.
Updates after r130425 and r130411.
* platform/chromium-linux/fast/images/paint-subrect-grid-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/images/paint-subrect-grid-expected.png.
* platform/chromium-win-xp/editing/pasteboard/5006779-expected.png: Added.
* platform/chromium-win-xp/editing/pasteboard/5006779-expected.txt: Copied from LayoutTests/platform/chromium-win/editing/pasteboard/5006779-expected.txt.
* platform/chromium-win/editing/pasteboard/5006779-expected.txt:
* platform/chromium/fast/images/paint-subrect-grid-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/images/paint-subrect-grid-expected.png.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium-win/editing/pasteboard/5006779-expected.txt
Added Paths
trunk/LayoutTests/platform/chromium/fast/images/paint-subrect-grid-expected.png
trunk/LayoutTests/platform/chromium-linux/fast/images/paint-subrect-grid-expected.png
trunk/LayoutTests/platform/chromium-win-xp/editing/pasteboard/5006779-expected.png
trunk/LayoutTests/platform/chromium-win-xp/editing/pasteboard/5006779-expected.txt
Removed Paths
trunk/LayoutTests/platform/chromium-mac/fast/images/paint-subrect-grid-expected.png
Diff
Modified: trunk/LayoutTests/ChangeLog (130451 => 130452)
--- trunk/LayoutTests/ChangeLog 2012-10-05 02:47:52 UTC (rev 130451)
+++ trunk/LayoutTests/ChangeLog 2012-10-05 02:55:44 UTC (rev 130452)
@@ -1,3 +1,17 @@
+2012-10-04 Dirk Pranke
+
+Update chromium baselines for 5006779.html and paint-subrect-grid.html.
+
+Unreviewed, rebaselining.
+
+Updates after r130425 and r130411.
+
+* platform/chromium-linux/fast/images/paint-subrect-grid-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/images/paint-subrect-grid-expected.png.
+* platform/chromium-win-xp/editing/pasteboard/5006779-expected.png: Added.
+* platform/chromium-win-xp/editing/pasteboard/5006779-expected.txt: Copied from LayoutTests/platform/chromium-win/editing/pasteboard/5006779-expected.txt.
+* platform/chromium-win/editing/pasteboard/5006779-expected.txt:
+* platform/chromium/fast/images/paint-subrect-grid-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/images/paint-subrect-grid-expected.png.
+
2012-10-04 Douglas Stockwell
[chromium] Unreviewed. Rebaseline mac/win results after r130355
Copied: trunk/LayoutTests/platform/chromium/fast/images/paint-subrect-grid-expected.png (from rev 130451, trunk/LayoutTests/platform/chromium-mac/fast/images/paint-subrect-grid-expected.png)
(Binary files differ)
Property changes: trunk/LayoutTests/platform/chromium/fast/images/paint-subrect-grid-expected.png
Added: svn:mime-type
Copied: trunk/LayoutTests/platform/chromium-linux/fast/images/paint-subrect-grid-expected.png (from rev 130451, trunk/LayoutTests/platform/chromium-mac/fast/images/paint-subrect-grid-expected.png) (0 => 130452)
--- trunk/LayoutTests/platform/chromium-linux/fast/images/paint-subrect-grid-expected.png (rev 0)
+++ trunk/LayoutTests/platform/chromium-linux/fast/images/paint-subrect-grid-expected.png 2012-10-05 02:55:44 UTC (rev 130452)
@@ -0,0 +1,13 @@
+\x89PNG
+
+
+IHDR X ' )tEXtchecksum 07c01e5cc49ba27bb255e6d4cd31492b\xBC\xCC5 nIDATx\x9C\xED\xDDOO\x94g\xDF\xC7\xE1aPQ \xA6\xB0\x85ą\x86\xC4\x89\xA6 iS\xBB\xB5M\xBAlR\xDFA\xDFAw.}\xAE\xDCw\xE1\xB0\x86M\xD3TB$6\xB4
+TF\xC0\xA0\x83\xC8\xC8\xCC\xC0\xF8,\xAE\x84\x98;71y\xF2}0\xF19\x8E 3?\xCE\xDD''\xD7u\x9D=o߾- \xE4 \xFA\xD0 \xC0\xC7F` \x84 , \x800\x81 &\xB0 \xC2 @\x98\xC0 {O`ݾ}\xFBڵk\xE3\xE3\xE3\xBF\xFC\xF2\xCB\xEC\xEC\xEC\xFD\xFB\xF7\xFE\xF9硡\xA1\xEF\xBF\xFF\xFEΝ;KKK\xB7nݺp\xE1\xC2\xDE\xC0ݻwoܸ\xD1\xD3\xD3s\xE3ƍw.\\xB8p\xEB֭\xA5\xA5\xA5\x8D\x8D\x8D\x83Y \xC0\x87b \xAC\xF7\xE6͛\xFF\xF5\x8D۷o?x\xF0\xE0\xFE\xFD\xFBsss\x8DF\xA3\xBF\xBFkkknn\xEE\xC1\x83\x8B\x8B\x8B}}}\xDDnwee\xE5\xF7\xDF\xFF\xFB\xB6\xB6\xAA\x81\x87 \xCE\xCE\xCE>}\xFA\xF4رc\xADVko`{{\xBB\xB7\xB7\xF7իW\x8F =\xBAz\xF5\xEA\xC1\xAE \xE0@\xF5\xECwTεk\xD7J)++\xDB\xDBۧN\x9D\xD9\xD9\xD9Y[[[]] \xFD\xF4ӽ\x81R\xCA\xC8\xC8ȩS\xA7\xFA\xFA\xFA~\xFB\x{DDC3}\! \xC0\xEB\xDB\xEF\x8D'O\x9E\x94R^\xBF~\xBD\xBD\xBD\xBD\xB3\xB3\xD3h4\xDA\xEDv\xB7\xDBm6\x9B\xD5\xB5\xB5\x8D\x8D\x8D\xAD\xAD\xAD\xEA\xF5j`wwwkk\xAB\xFA\xC1\xDD\xDDݽ\x81Rʋ/Z\xAD֡C\xFE) |\xE4\xF6
+\xAC\x9F~\xFA\xA9\x942;\xDBh4&'[\xAD\xD6\xDC\xDC\xDC\xDC\xDC\xDC\xD8\xD8\xD8\xE4\xE4\xE4\xE9ӧ\xABo[\xADV5\xF0\xEAիꕉ\x89\x893g\xCE\xEC
+\x94R\xAA\x81Ç \xDC\xE2 >\x84\xF7֯\xBF\xFE\xBA\xBA\xBA\xDAn\xB7'''\xAF_\xBF\xBE\xB9\xB9\xD9\xE9t\xE6\xE7\xE7GGG\xA7\xA6\xA6._\xBE\\xABՖ\x97\x97_\xBF~]
+<{\xF6\xAC\xBATk||\xFC݁R\xCAŋ\xAF_\xBF~\xFC\xF8
[webkit-changes] [130451] trunk/Source/WebKit/chromium
Title: [130451] trunk/Source/WebKit/chromium
Revision 130451
Author hc...@chromium.org
Date 2012-10-04 19:47:52 -0700 (Thu, 04 Oct 2012)
Log Message
Unreviewd. Chromium DEPS roll. Update to r160281.
* DEPS:
Modified Paths
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/DEPS
Diff
Modified: trunk/Source/WebKit/chromium/ChangeLog (130450 => 130451)
--- trunk/Source/WebKit/chromium/ChangeLog 2012-10-05 02:37:58 UTC (rev 130450)
+++ trunk/Source/WebKit/chromium/ChangeLog 2012-10-05 02:47:52 UTC (rev 130451)
@@ -1,3 +1,9 @@
+2012-10-04 Alpha Lam
+
+Unreviewd. Chromium DEPS roll. Update to r160281.
+
+* DEPS:
+
2012-10-04 Mark Pilgrim
[Chromium] Update some #includes for Platform directory
Modified: trunk/Source/WebKit/chromium/DEPS (130450 => 130451)
--- trunk/Source/WebKit/chromium/DEPS 2012-10-05 02:37:58 UTC (rev 130450)
+++ trunk/Source/WebKit/chromium/DEPS 2012-10-05 02:47:52 UTC (rev 130451)
@@ -32,7 +32,7 @@
vars = {
'chromium_svn': 'http://src.chromium.org/svn/trunk/src',
- 'chromium_rev': '160008'
+ 'chromium_rev': '160281'
}
deps = {
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [130449] trunk/Source/WebCore
Title: [130449] trunk/Source/WebCore
Revision 130449
Author jap...@chromium.org
Date 2012-10-04 19:31:16 -0700 (Thu, 04 Oct 2012)
Log Message
Crash in EventHandler::mouseMoved().
https://bugs.webkit.org/show_bug.cgi?id=98460
Reviewed by Abhishek Arya.
No new tests, this fixes fast/events/mouse-moved-remove-frame-crash.html.
* page/EventHandler.cpp:
(WebCore::EventHandler::mouseMoved):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/EventHandler.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (130448 => 130449)
--- trunk/Source/WebCore/ChangeLog 2012-10-05 02:30:19 UTC (rev 130448)
+++ trunk/Source/WebCore/ChangeLog 2012-10-05 02:31:16 UTC (rev 130449)
@@ -1,3 +1,15 @@
+2012-10-04 Nate Chapin
+
+Crash in EventHandler::mouseMoved().
+https://bugs.webkit.org/show_bug.cgi?id=98460
+
+Reviewed by Abhishek Arya.
+
+No new tests, this fixes fast/events/mouse-moved-remove-frame-crash.html.
+
+* page/EventHandler.cpp:
+(WebCore::EventHandler::mouseMoved):
+
2012-10-04 Adam Barth
[V8] NotificationCenter leaks because it uses buggy custom bindings
Modified: trunk/Source/WebCore/page/EventHandler.cpp (130448 => 130449)
--- trunk/Source/WebCore/page/EventHandler.cpp 2012-10-05 02:30:19 UTC (rev 130448)
+++ trunk/Source/WebCore/page/EventHandler.cpp 2012-10-05 02:31:16 UTC (rev 130449)
@@ -1684,8 +1684,8 @@
bool EventHandler::mouseMoved(const PlatformMouseEvent& event)
{
+RefPtr protector(m_frame->view());
MaximumDurationTracker maxDurationTracker(&m_maxMouseMovedDuration);
-RefPtr protector(m_frame->view());
#if ENABLE(TOUCH_EVENTS)
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [130448] trunk/Source/WebKit/chromium
Title: [130448] trunk/Source/WebKit/chromium Revision 130448 Author pilg...@chromium.org Date 2012-10-04 19:30:19 -0700 (Thu, 04 Oct 2012) Log Message [Chromium] Update some #includes for Platform directory https://bugs.webkit.org/show_bug.cgi?id=98440 Reviewed by Adam Barth. Part of a refactoring series. See tracking bug 82948. * src/ApplicationCacheHost.cpp: * src/AssociatedURLLoader.h: * src/AsyncFileWriterChromium.cpp: * src/AudioDestinationChromium.h: * src/AutofillPopupMenuClient.cpp: * src/ChromeClientImpl.cpp: * src/ContextMenuClientImpl.cpp: * src/DeliveredIntentClientImpl.h: * src/DragClientImpl.cpp: * src/DragScrollTimer.h: * src/FrameLoaderClientImpl.cpp: * src/InspectorClientImpl.cpp: * src/InspectorClientImpl.h: * src/InspectorFrontendClientImpl.cpp: * src/NotificationPresenterImpl.cpp: * src/PageWidgetDelegate.h: * src/SocketStreamHandle.cpp: * src/SocketStreamHandleInternal.h: * src/SpeechInputClientImpl.cpp: * src/StorageAreaProxy.cpp: * src/StorageNamespaceProxy.cpp: * src/UserMediaClientImpl.cpp: * src/WebAccessibilityObject.cpp: * src/WebAnimationControllerImpl.cpp: * src/WebCommon.cpp: * src/WebDOMEventListenerPrivate.h: * src/WebDOMMessageEvent.cpp: * src/WebDOMStringList.cpp: * src/WebDataSourceImpl.cpp: * src/WebDatabase.cpp: * src/WebDevToolsAgentImpl.cpp: * src/WebDevToolsAgentImpl.h: * src/WebDocument.cpp: * src/WebDocumentType.cpp: * src/WebDragData.cpp: * src/WebElement.cpp: * src/WebEntities.cpp: * src/WebFileChooserCompletionImpl.h: * src/WebFileSystemCallbacksImpl.cpp: * src/WebFontImpl.cpp: Modified Paths trunk/Source/WebKit/chromium/ChangeLog trunk/Source/WebKit/chromium/src/ApplicationCacheHost.cpp trunk/Source/WebKit/chromium/src/AssociatedURLLoader.h trunk/Source/WebKit/chromium/src/AsyncFileWriterChromium.cpp trunk/Source/WebKit/chromium/src/AudioDestinationChromium.h trunk/Source/WebKit/chromium/src/AutofillPopupMenuClient.cpp trunk/Source/WebKit/chromium/src/ChromeClientImpl.cpp trunk/Source/WebKit/chromium/src/ContextMenuClientImpl.cpp trunk/Source/WebKit/chromium/src/DeliveredIntentClientImpl.h trunk/Source/WebKit/chromium/src/DragClientImpl.cpp trunk/Source/WebKit/chromium/src/DragScrollTimer.h trunk/Source/WebKit/chromium/src/FrameLoaderClientImpl.cpp trunk/Source/WebKit/chromium/src/InspectorClientImpl.cpp trunk/Source/WebKit/chromium/src/InspectorClientImpl.h trunk/Source/WebKit/chromium/src/InspectorFrontendClientImpl.cpp trunk/Source/WebKit/chromium/src/NotificationPresenterImpl.cpp trunk/Source/WebKit/chromium/src/PageWidgetDelegate.h trunk/Source/WebKit/chromium/src/SocketStreamHandle.cpp trunk/Source/WebKit/chromium/src/SocketStreamHandleInternal.h trunk/Source/WebKit/chromium/src/SpeechInputClientImpl.cpp trunk/Source/WebKit/chromium/src/StorageAreaProxy.cpp trunk/Source/WebKit/chromium/src/StorageNamespaceProxy.cpp trunk/Source/WebKit/chromium/src/UserMediaClientImpl.cpp trunk/Source/WebKit/chromium/src/WebAccessibilityObject.cpp trunk/Source/WebKit/chromium/src/WebAnimationControllerImpl.cpp trunk/Source/WebKit/chromium/src/WebCommon.cpp trunk/Source/WebKit/chromium/src/WebDOMEventListenerPrivate.h trunk/Source/WebKit/chromium/src/WebDOMMessageEvent.cpp trunk/Source/WebKit/chromium/src/WebDOMStringList.cpp trunk/Source/WebKit/chromium/src/WebDataSourceImpl.cpp trunk/Source/WebKit/chromium/src/WebDatabase.cpp trunk/Source/WebKit/chromium/src/WebDevToolsAgentImpl.cpp trunk/Source/WebKit/chromium/src/WebDevToolsAgentImpl.h trunk/Source/WebKit/chromium/src/WebDocument.cpp trunk/Source/WebKit/chromium/src/WebDocumentType.cpp trunk/Source/WebKit/chromium/src/WebDragData.cpp trunk/Source/WebKit/chromium/src/WebElement.cpp trunk/Source/WebKit/chromium/src/WebEntities.cpp trunk/Source/WebKit/chromium/src/WebFileChooserCompletionImpl.h trunk/Source/WebKit/chromium/src/WebFileSystemCallbacksImpl.cpp trunk/Source/WebKit/chromium/src/WebFontImpl.cpp Diff Modified: trunk/Source/WebKit/chromium/ChangeLog (130447 => 130448) --- trunk/Source/WebKit/chromium/ChangeLog 2012-10-05 02:26:11 UTC (rev 130447) +++ trunk/Source/WebKit/chromium/ChangeLog 2012-10-05 02:30:19 UTC (rev 130448) @@ -1,3 +1,53 @@ +2012-10-04 Mark Pilgrim + +[Chromium] Update some #includes for Platform directory +https://bugs.webkit.org/show_bug.cgi?id=98440 + +Reviewed by Adam Barth. + +Part of a refactoring series. See tracking bug 82948. + +* src/ApplicationCacheHost.cpp: +* src/AssociatedURLLoader.h: +* src/AsyncFileWriterChromium.cpp: +* src/AudioDestinationChromium.h: +* src/AutofillPopupMenuClient.cpp: +* src/ChromeClientImpl.cpp: +* src/ContextMenuClientImpl.cpp: +* src/DeliveredIntentClientImpl.h: +* src/DragClientImpl.cpp: +* src/DragScrollTimer.h: +* src/FrameLoaderClientImpl.cpp: +* src/InspectorClientImpl.cpp: +* src/InspectorClientImpl.h: +* src/InspectorFrontendClientImpl.cpp: +* src/NotificationPresenterImpl.cpp:
[webkit-changes] [130446] trunk/Source/WebCore
Title: [130446] trunk/Source/WebCore
Revision 130446
Author aba...@webkit.org
Date 2012-10-04 19:18:45 -0700 (Thu, 04 Oct 2012)
Log Message
[V8] NotificationCenter leaks because it uses buggy custom bindings
https://bugs.webkit.org/show_bug.cgi?id=98445
Reviewed by Tony Chang.
There's no reason to use custom bindings here. All they do is cause leaks..
* Modules/notifications/NotificationCenter.idl:
* bindings/v8/custom/V8NotificationCenterCustom.cpp:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/notifications/NotificationCenter.idl
trunk/Source/WebCore/bindings/v8/custom/V8NotificationCenterCustom.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (130445 => 130446)
--- trunk/Source/WebCore/ChangeLog 2012-10-05 02:16:23 UTC (rev 130445)
+++ trunk/Source/WebCore/ChangeLog 2012-10-05 02:18:45 UTC (rev 130446)
@@ -1,3 +1,15 @@
+2012-10-04 Adam Barth
+
+[V8] NotificationCenter leaks because it uses buggy custom bindings
+https://bugs.webkit.org/show_bug.cgi?id=98445
+
+Reviewed by Tony Chang.
+
+There's no reason to use custom bindings here. All they do is cause leaks..
+
+* Modules/notifications/NotificationCenter.idl:
+* bindings/v8/custom/V8NotificationCenterCustom.cpp:
+
2012-10-04 Tab Atkins
Selector specificity categories "overflow" into higher categories
Modified: trunk/Source/WebCore/Modules/notifications/NotificationCenter.idl (130445 => 130446)
--- trunk/Source/WebCore/Modules/notifications/NotificationCenter.idl 2012-10-05 02:16:23 UTC (rev 130445)
+++ trunk/Source/WebCore/Modules/notifications/NotificationCenter.idl 2012-10-05 02:18:45 UTC (rev 130446)
@@ -37,9 +37,9 @@
OmitConstructor
] NotificationCenter {
#if !defined(ENABLE_TEXT_NOTIFICATIONS_ONLY) || !ENABLE_TEXT_NOTIFICATIONS_ONLY
- [V8Custom, V8EnabledPerContext=htmlNotifications] Notification createHTMLNotification(in DOMString url) raises(DOMException);
+ [V8EnabledPerContext=htmlNotifications] Notification createHTMLNotification(in DOMString url) raises(DOMException);
#endif
- [V8Custom] Notification createNotification(in DOMString iconUrl, in DOMString title, in DOMString body) raises(DOMException);
+ Notification createNotification(in DOMString iconUrl, in DOMString title, in DOMString body) raises(DOMException);
int checkPermission();
[Custom] void requestPermission(in VoidCallback callback);
Modified: trunk/Source/WebCore/bindings/v8/custom/V8NotificationCenterCustom.cpp (130445 => 130446)
--- trunk/Source/WebCore/bindings/v8/custom/V8NotificationCenterCustom.cpp 2012-10-05 02:16:23 UTC (rev 130445)
+++ trunk/Source/WebCore/bindings/v8/custom/V8NotificationCenterCustom.cpp 2012-10-05 02:18:45 UTC (rev 130446)
@@ -46,37 +46,6 @@
namespace WebCore {
-v8::Handle V8NotificationCenter::createHTMLNotificationCallback(const v8::Arguments& args)
-{
-INC_STATS("DOM.NotificationCenter.CreateHTMLNotification()");
-NotificationCenter* notificationCenter = V8NotificationCenter::toNative(args.Holder());
-
-ExceptionCode ec = 0;
-String url = ""
-RefPtr notification = notificationCenter->createHTMLNotification(url, ec);
-
-if (ec)
-return setDOMException(ec, args.GetIsolate());
-
-notification->ref();
-return toV8(notification.get(), args.Holder(), args.GetIsolate());
-}
-
-v8::Handle V8NotificationCenter::createNotificationCallback(const v8::Arguments& args)
-{
-INC_STATS("DOM.NotificationCenter.CreateNotification()");
-NotificationCenter* notificationCenter = V8NotificationCenter::toNative(args.Holder());
-
-ExceptionCode ec = 0;
-RefPtr notification = notificationCenter->createNotification(toWebCoreString(args[0]), toWebCoreString(args[1]), toWebCoreString(args[2]), ec);
-
-if (ec)
-return setDOMException(ec, args.GetIsolate());
-
-notification->ref();
-return toV8(notification.get(), args.Holder(), args.GetIsolate());
-}
-
v8::Handle V8NotificationCenter::requestPermissionCallback(const v8::Arguments& args)
{
INC_STATS("DOM.NotificationCenter.RequestPermission()");
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [130445] branches/chromium/1271
Title: [130445] branches/chromium/1271
Revision 130445
Author kei...@webkit.org
Date 2012-10-04 19:16:23 -0700 (Thu, 04 Oct 2012)
Log Message
Merge 130008 - REGRESSION(r127727): Calendar picker is ignoring step
https://bugs.webkit.org/show_bug.cgi?id=97893
Reviewed by Kent Tamura.
Source/WebCore:
There were two mistakes:
- An if-statement to check step attribute validity was wrong, and
- DateTiemChooserParameters.step was milleseconds when it should be number of days.
This will be changing the DateTimeChooserParameters.step to milliseconds so we can handle steps for other input types in the future.
Test: fast/forms/date/calendar-picker-appearance-with-step.html
* Resources/pagepopups/calendarPicker.js:
(CalendarPicker):
* html/shadow/CalendarPickerElement.cpp:
(WebCore::CalendarPickerElement::openPopup): If statement was wrong.
LayoutTests:
* fast/forms/date/calendar-picker-appearance-with-step-expected.txt: Added.
* fast/forms/date/calendar-picker-appearance-with-step.html: Added.
TBR=kei...@webkit.org
Modified Paths
branches/chromium/1271/LayoutTests/ChangeLog
branches/chromium/1271/Source/WebCore/ChangeLog
branches/chromium/1271/Source/WebCore/Resources/pagepopups/calendarPicker.js
branches/chromium/1271/Source/WebCore/html/shadow/CalendarPickerElement.cpp
Added Paths
branches/chromium/1271/LayoutTests/fast/forms/date/calendar-picker-appearance-with-step-expected.txt
branches/chromium/1271/LayoutTests/fast/forms/date/calendar-picker-appearance-with-step.html
Diff
Modified: branches/chromium/1271/LayoutTests/ChangeLog (130444 => 130445)
--- branches/chromium/1271/LayoutTests/ChangeLog 2012-10-05 02:04:44 UTC (rev 130444)
+++ branches/chromium/1271/LayoutTests/ChangeLog 2012-10-05 02:16:23 UTC (rev 130445)
@@ -1,3 +1,13 @@
+2012-10-01 Keishi Hattori
+
+REGRESSION(r127727): Calendar picker is ignoring step
+https://bugs.webkit.org/show_bug.cgi?id=97893
+
+Reviewed by Kent Tamura.
+
+* fast/forms/date/calendar-picker-appearance-with-step-expected.txt: Added.
+* fast/forms/date/calendar-picker-appearance-with-step.html: Added.
+
2012-09-20 Keishi Hattori
REGRESSION(r127727): Can't navigate between months with arrow keys in calendar picker
Copied: branches/chromium/1271/LayoutTests/fast/forms/date/calendar-picker-appearance-with-step-expected.txt (from rev 130008, trunk/LayoutTests/fast/forms/date/calendar-picker-appearance-with-step-expected.txt) (0 => 130445)
--- branches/chromium/1271/LayoutTests/fast/forms/date/calendar-picker-appearance-with-step-expected.txt (rev 0)
+++ branches/chromium/1271/LayoutTests/fast/forms/date/calendar-picker-appearance-with-step-expected.txt 2012-10-05 02:16:23 UTC (rev 130445)
@@ -0,0 +1,10 @@
+Test if step limits available dates in calendar picker.
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+Step without min.
+PASS availableDatesInCurrentMonth().join(",") is ["2011-05-09", "2011-05-18", "2011-05-27"].join(",")
+Step when min is set.
+PASS availableDatesInCurrentMonth().join(",") is ["2011-05-01", "2011-05-10", "2011-05-19", "2011-05-28"].join(",")
+
Copied: branches/chromium/1271/LayoutTests/fast/forms/date/calendar-picker-appearance-with-step.html (from rev 130008, trunk/LayoutTests/fast/forms/date/calendar-picker-appearance-with-step.html) (0 => 130445)
--- branches/chromium/1271/LayoutTests/fast/forms/date/calendar-picker-appearance-with-step.html (rev 0)
+++ branches/chromium/1271/LayoutTests/fast/forms/date/calendar-picker-appearance-with-step.html 2012-10-05 02:16:23 UTC (rev 130445)
@@ -0,0 +1,64 @@
+
+
+
+
+
+
+
+
+
+
+