[webkit-changes] [133726] trunk/Source/WTF
Title: [133726] trunk/Source/WTF
Revision 133726
Author msab...@apple.com
Date 2012-11-06 23:13:20 -0800 (Tue, 06 Nov 2012)
Log Message
StringBuilder::append(UChar) with an 8 bit quantity shouldn't change the contents to 16 bits
https://bugs.webkit.org/show_bug.cgi?id=101421
Reviewed by Anders Carlsson.
If the string builder contains only 8 bit data, check if the character being appended contains
8 bit data. If so, append it to the 8 bit buffer instead of converting the buffer to 16 bits.
* wtf/text/StringBuilder.cpp:
(WTF::StringBuilder::append):
* wtf/text/StringBuilder.h:
(WTF::StringBuilder::append):
Modified Paths
trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/text/StringBuilder.cpp
trunk/Source/WTF/wtf/text/StringBuilder.h
Diff
Modified: trunk/Source/WTF/ChangeLog (133725 => 133726)
--- trunk/Source/WTF/ChangeLog 2012-11-07 06:46:04 UTC (rev 133725)
+++ trunk/Source/WTF/ChangeLog 2012-11-07 07:13:20 UTC (rev 133726)
@@ -1,3 +1,18 @@
+2012-11-06 Michael Saboff
+
+StringBuilder::append(UChar) with an 8 bit quantity shouldn't change the contents to 16 bits
+https://bugs.webkit.org/show_bug.cgi?id=101421
+
+Reviewed by Anders Carlsson.
+
+If the string builder contains only 8 bit data, check if the character being appended contains
+8 bit data. If so, append it to the 8 bit buffer instead of converting the buffer to 16 bits.
+
+* wtf/text/StringBuilder.cpp:
+(WTF::StringBuilder::append):
+* wtf/text/StringBuilder.h:
+(WTF::StringBuilder::append):
+
2012-11-06 Benjamin Poulain
Speed up TransformationMatrix::multiply() on modern ARM
Modified: trunk/Source/WTF/wtf/text/StringBuilder.cpp (133725 => 133726)
--- trunk/Source/WTF/wtf/text/StringBuilder.cpp 2012-11-07 06:46:04 UTC (rev 133725)
+++ trunk/Source/WTF/wtf/text/StringBuilder.cpp 2012-11-07 07:13:20 UTC (rev 133726)
@@ -243,6 +243,13 @@
ASSERT(characters);
if (m_is8Bit) {
+if (length == 1 && !(*characters & ~0xff)) {
+// Append as 8 bit character
+LChar lChar = static_cast(*characters);
+append(&lChar, 1);
+return;
+}
+
// Calculate the new size of the builder after appending.
unsigned requiredLength = length + m_length;
if (requiredLength < length)
Modified: trunk/Source/WTF/wtf/text/StringBuilder.h (133725 => 133726)
--- trunk/Source/WTF/wtf/text/StringBuilder.h 2012-11-07 06:46:04 UTC (rev 133725)
+++ trunk/Source/WTF/wtf/text/StringBuilder.h 2012-11-07 07:13:20 UTC (rev 133726)
@@ -111,10 +111,18 @@
void append(UChar c)
{
-if (m_buffer && !m_is8Bit && m_length < m_buffer->length() && m_string.isNull())
-m_bufferCharacters16[m_length++] = c;
-else
-append(&c, 1);
+if (m_buffer && m_length < m_buffer->length() && m_string.isNull()) {
+if (!m_is8Bit) {
+m_bufferCharacters16[m_length++] = c;
+return;
+}
+
+if (!(c & ~0xff)) {
+m_bufferCharacters8[m_length++] = static_cast(c);
+return;
+}
+}
+append(&c, 1);
}
void append(LChar c)
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [133725] trunk/LayoutTests
Title: [133725] trunk/LayoutTests Revision 133725 Author commit-qu...@webkit.org Date 2012-11-06 22:46:04 -0800 (Tue, 06 Nov 2012) Log Message [EFL][WK2] media/media-continues-playing-after-replace-source.html fails https://bugs.webkit.org/show_bug.cgi?id=101429 Unreviewed, EFL gardening. media-continues-playing-after-replace-source.html test case crashes in WK2 only. Patch by Kangil Han on 2012-11-06 * platform/efl-wk2/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/efl-wk2/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (133724 => 133725) --- trunk/LayoutTests/ChangeLog 2012-11-07 06:46:00 UTC (rev 133724) +++ trunk/LayoutTests/ChangeLog 2012-11-07 06:46:04 UTC (rev 133725) @@ -1,3 +1,14 @@ +2012-11-06 Kangil Han + +[EFL][WK2] media/media-continues-playing-after-replace-source.html fails +https://bugs.webkit.org/show_bug.cgi?id=101429 + +Unreviewed, EFL gardening. + +media-continues-playing-after-replace-source.html test case crashes in WK2 only. + +* platform/efl-wk2/TestExpectations: + 2012-11-06 Dan Beam Enable REQUEST_AUTOCOMPLETE for chromium port Modified: trunk/LayoutTests/platform/efl-wk2/TestExpectations (133724 => 133725) --- trunk/LayoutTests/platform/efl-wk2/TestExpectations 2012-11-07 06:46:00 UTC (rev 133724) +++ trunk/LayoutTests/platform/efl-wk2/TestExpectations 2012-11-07 06:46:04 UTC (rev 133725) @@ -57,6 +57,8 @@ webkit.org/b/100342 networkinformation/add-listener-from-callback.html [ Crash ] webkit.org/b/100342 networkinformation/basic-operation.html [ Crash ] +webkit.org/b/101428 media/media-continues-playing-after-replace-source.html [ Crash ] + # # FLAKY TESTS # ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [133724] trunk/Source/WebKit2
Title: [133724] trunk/Source/WebKit2
Revision 133724
Author commit-qu...@webkit.org
Date 2012-11-06 22:46:00 -0800 (Tue, 06 Nov 2012)
Log Message
Move DrawingAreaImpl methods graphicsLayerFactory, setRootCompositingLayer & scheduleCompositingLayerSync under ACCELERATED_COMPOSITING
https://bugs.webkit.org/show_bug.cgi?id=101427
Patch by Vivek Galatage on 2012-11-06
Reviewed by Anders Carlsson.
Moving these methods under the ACCELERATED_COMPOSITING flag.
This fixes broken wincairo due to use of override specifier.
* WebProcess/WebPage/DrawingAreaImpl.cpp:
(WebKit):
* WebProcess/WebPage/DrawingAreaImpl.h:
(DrawingAreaImpl):
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/WebProcess/WebPage/DrawingAreaImpl.cpp
trunk/Source/WebKit2/WebProcess/WebPage/DrawingAreaImpl.h
Diff
Modified: trunk/Source/WebKit2/ChangeLog (133723 => 133724)
--- trunk/Source/WebKit2/ChangeLog 2012-11-07 06:31:20 UTC (rev 133723)
+++ trunk/Source/WebKit2/ChangeLog 2012-11-07 06:46:00 UTC (rev 133724)
@@ -1,3 +1,18 @@
+2012-11-06 Vivek Galatage
+
+Move DrawingAreaImpl methods graphicsLayerFactory, setRootCompositingLayer & scheduleCompositingLayerSync under ACCELERATED_COMPOSITING
+https://bugs.webkit.org/show_bug.cgi?id=101427
+
+Reviewed by Anders Carlsson.
+
+Moving these methods under the ACCELERATED_COMPOSITING flag.
+This fixes broken wincairo due to use of override specifier.
+
+* WebProcess/WebPage/DrawingAreaImpl.cpp:
+(WebKit):
+* WebProcess/WebPage/DrawingAreaImpl.h:
+(DrawingAreaImpl):
+
2012-11-06 Viatcheslav Ostapenko
[EFL][WK2] API test crash with accelerated compositing on.
Modified: trunk/Source/WebKit2/WebProcess/WebPage/DrawingAreaImpl.cpp (133723 => 133724)
--- trunk/Source/WebKit2/WebProcess/WebPage/DrawingAreaImpl.cpp 2012-11-07 06:31:20 UTC (rev 133723)
+++ trunk/Source/WebKit2/WebProcess/WebPage/DrawingAreaImpl.cpp 2012-11-07 06:46:00 UTC (rev 133724)
@@ -307,6 +307,7 @@
#endif
}
+#if USE(ACCELERATED_COMPOSITING)
GraphicsLayerFactory* DrawingAreaImpl::graphicsLayerFactory()
{
if (m_layerTreeHost)
@@ -361,6 +362,7 @@
return;
m_layerTreeHost->scheduleLayerFlush();
}
+#endif
void DrawingAreaImpl::updateBackingStoreState(uint64_t stateID, bool respondImmediately, float deviceScaleFactor, const WebCore::IntSize& size, const WebCore::IntSize& scrollOffset)
{
Modified: trunk/Source/WebKit2/WebProcess/WebPage/DrawingAreaImpl.h (133723 => 133724)
--- trunk/Source/WebKit2/WebProcess/WebPage/DrawingAreaImpl.h 2012-11-07 06:31:20 UTC (rev 133723)
+++ trunk/Source/WebKit2/WebProcess/WebPage/DrawingAreaImpl.h 2012-11-07 06:46:00 UTC (rev 133724)
@@ -68,9 +68,11 @@
virtual void setPaintingEnabled(bool);
virtual void updatePreferences(const WebPreferencesStore&) OVERRIDE;
+#if USE(ACCELERATED_COMPOSITING)
virtual WebCore::GraphicsLayerFactory* graphicsLayerFactory() OVERRIDE;
virtual void setRootCompositingLayer(WebCore::GraphicsLayer*) OVERRIDE;
virtual void scheduleCompositingLayerFlush() OVERRIDE;
+#endif
#if PLATFORM(WIN)
virtual void scheduleChildWindowGeometryUpdate(const WindowGeometry&);
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [133723] trunk/Source/WebKit2
Title: [133723] trunk/Source/WebKit2
Revision 133723
Author commit-qu...@webkit.org
Date 2012-11-06 22:31:20 -0800 (Tue, 06 Nov 2012)
Log Message
[EFL][WK2] API test crash with accelerated compositing on.
https://bugs.webkit.org/show_bug.cgi?id=101384
Patch by Viatcheslav Ostapenko on 2012-11-06
Reviewed by Gyuyoung Kim.
If accelerated compositing is enabled API tests should create GL evas engine
instead of default one.
Also, in API tests first window resize and display often comes earlier
than enterAcceleratedCompositingMode call, so let's create GL surface in
_ewk_view_smart_calculate on first window resize.
* UIProcess/API/efl/ewk_view.cpp:
(_ewk_view_smart_calculate):
* UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestBase.cpp:
(EWK2UnitTest::EWK2UnitTestBase::SetUp):
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/efl/ewk_view.cpp
trunk/Source/WebKit2/UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestBase.cpp
Diff
Modified: trunk/Source/WebKit2/ChangeLog (133722 => 133723)
--- trunk/Source/WebKit2/ChangeLog 2012-11-07 06:29:43 UTC (rev 133722)
+++ trunk/Source/WebKit2/ChangeLog 2012-11-07 06:31:20 UTC (rev 133723)
@@ -1,3 +1,21 @@
+2012-11-06 Viatcheslav Ostapenko
+
+[EFL][WK2] API test crash with accelerated compositing on.
+https://bugs.webkit.org/show_bug.cgi?id=101384
+
+Reviewed by Gyuyoung Kim.
+
+If accelerated compositing is enabled API tests should create GL evas engine
+instead of default one.
+Also, in API tests first window resize and display often comes earlier
+than enterAcceleratedCompositingMode call, so let's create GL surface in
+_ewk_view_smart_calculate on first window resize.
+
+* UIProcess/API/efl/ewk_view.cpp:
+(_ewk_view_smart_calculate):
+* UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestBase.cpp:
+(EWK2UnitTest::EWK2UnitTestBase::SetUp):
+
2012-11-06 Anders Carlsson
Update Java related WKSI function names
Modified: trunk/Source/WebKit2/UIProcess/API/efl/ewk_view.cpp (133722 => 133723)
--- trunk/Source/WebKit2/UIProcess/API/efl/ewk_view.cpp 2012-11-07 06:29:43 UTC (rev 133722)
+++ trunk/Source/WebKit2/UIProcess/API/efl/ewk_view.cpp 2012-11-07 06:31:20 UTC (rev 133723)
@@ -387,10 +387,10 @@
#if USE(ACCELERATED_COMPOSITING)
// Recreate surface if needed.
-if (impl->evasGLSurface()) {
+if (impl->evasGLSurface())
impl->clearEvasGLSurface();
-impl->createGLSurface(IntSize(width, height));
-}
+
+impl->createGLSurface(IntSize(width, height));
#endif
#if USE(TILED_BACKING_STORE)
impl->pageClient()->updateViewportSize(IntSize(width, height));
Modified: trunk/Source/WebKit2/UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestBase.cpp (133722 => 133723)
--- trunk/Source/WebKit2/UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestBase.cpp 2012-11-07 06:29:43 UTC (rev 133722)
+++ trunk/Source/WebKit2/UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestBase.cpp 2012-11-07 06:31:20 UTC (rev 133723)
@@ -48,7 +48,12 @@
unsigned int width = environment->defaultWidth();
unsigned int height = environment->defaultHeight();
+#if defined(WTF_USE_ACCELERATED_COMPOSITING) && defined(HAVE_ECORE_X)
+const char* engine = "opengl_x11";
+m_ecoreEvas = ecore_evas_new(engine, 0, 0, width, height, 0);
+#else
m_ecoreEvas = ecore_evas_new(0, 0, 0, width, height, 0);
+#endif
ecore_evas_show(m_ecoreEvas);
Evas* evas = ecore_evas_get(m_ecoreEvas);
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [133722] trunk
Title: [133722] trunk
Revision 133722
Author kei...@webkit.org
Date 2012-11-06 22:29:43 -0800 (Tue, 06 Nov 2012)
Log Message
Implement month picking to calendar picker
https://bugs.webkit.org/show_bug.cgi?id=101333
Reviewed by Kent Tamura.
.:
* ManualTests/forms/calendar-picker.html: Added test for month picker.
Source/WebCore:
This adds month picker mode to CalendarPicker.
No new tests. Tests will be added later when this feature is enabled in DRT.
* Resources/pagepopups/calendarPicker.css:
(.month-mode .day): Remove rounded corners when in month mode.
* Resources/pagepopups/calendarPicker.js:
(Month.createFromToday): Creates month containing today.
(CalendarPicker): Set this.selectionConstructor to Day or Month depending on the mode. Create DayTables or MonthPickerDaysTable depending on the mode.
(CalendarPicker.prototype.handleToday):
(CalendarPicker.prototype._layoutButtons):
(DaysTable.prototype._renderMonth): Set element.dataset.monthValue for all date nodes.
(DaysTable.prototype._markRangeAsSelected): Marks all day nodes in range as selected.
(DaysTable.prototype.selectRange): Selects a day.
(DaysTable.prototype.selectRangeAndShowEntireRange): Same as selectRange.
(DaysTable.prototype._selectRangeContainingNode):
(DaysTable.prototype._rangeForNode): Returns Day for node.
(DaysTable.prototype.startDate): Start datetime of visible date range. This value is inclusive.
(DaysTable.prototype.endDate): End datetime of visible date range. This value is exclusive.
(DaysTable.prototype._handleKey):
(MonthPickerDaysTable):
(MonthPickerDaysTable.prototype._markRangeAsSelected): Marks all day nodes in range as selected.
(MonthPickerDaysTable.prototype.selectRange): Selects month. If month is not visible, navigates to that month.
(MonthPickerDaysTable.prototype.selectRangeAndShowEntireRange): Selects month. Navigates to the month.
(MonthPickerDaysTable.prototype._rangeForNode): Returns Month for node.
(MonthPickerDaysTable.prototype._handleKey): Arrow keys simply move the selection forwards or backwards.
Modified Paths
trunk/ChangeLog
trunk/ManualTests/forms/calendar-picker.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Resources/pagepopups/calendarPicker.css
trunk/Source/WebCore/Resources/pagepopups/calendarPicker.js
Diff
Modified: trunk/ChangeLog (133721 => 133722)
--- trunk/ChangeLog 2012-11-07 05:28:47 UTC (rev 133721)
+++ trunk/ChangeLog 2012-11-07 06:29:43 UTC (rev 133722)
@@ -1,3 +1,12 @@
+2012-11-06 Keishi Hattori
+
+Implement month picking to calendar picker
+https://bugs.webkit.org/show_bug.cgi?id=101333
+
+Reviewed by Kent Tamura.
+
+* ManualTests/forms/calendar-picker.html: Added test for month picker.
+
2012-11-06 Laszlo Gombos
[EFL] Simplify the build system
Modified: trunk/ManualTests/forms/calendar-picker.html (133721 => 133722)
--- trunk/ManualTests/forms/calendar-picker.html 2012-11-07 05:28:47 UTC (rev 133721)
+++ trunk/ManualTests/forms/calendar-picker.html 2012-11-07 06:29:43 UTC (rev 133722)
@@ -27,6 +27,7 @@
with long datalist
Arabic with datalist
Arabic with long datalist
+ Month
@@ -238,6 +239,21 @@
suggestionHighlightColor: "#ff",
suggestionHighlightTextColor: "#ff"
};
+var monthArguments = {
+locale: 'en-US',
+monthLabels : ['January', 'February', 'March', 'April', 'May', 'June',
+'July', 'August', 'September', 'October', 'November', 'December'],
+dayLabels : ['Sun', 'Mon', 'Tue', 'Wed', 'Thu', 'Fri', 'Sat'],
+todayLabel : 'This Month',
+clearLabel : 'Clear',
+cancelLabel : 'Cancel',
+weekStartDay : 0,
+step : "1",
+stepBase: "0",
+currentValue : '2000-01',
+max : '2099-03',
+mode: "month"
+};
function openCalendar(args) {
var frame = document.getElementsByTagName('iframe')[0];
@@ -310,6 +326,9 @@
case 6:
openCalendar(arabicLongDatalistArguments);
break;
+case 7:
+openCalendar(monthArguments);
+break;
}
}
Modified: trunk/Source/WebCore/ChangeLog (133721 => 133722)
--- trunk/Source/WebCore/ChangeLog 2012-11-07 05:28:47 UTC (rev 133721)
+++ trunk/Source/WebCore/ChangeLog 2012-11-07 06:29:43 UTC (rev 133722)
@@ -1,3 +1,37 @@
+2012-11-06 Keishi Hattori
+
+Implement month picking to calendar picker
+https://bugs.webkit.org/show_bug.cgi?id=101333
+
+Reviewed by Kent Tamura.
+
+This adds month picker mode to CalendarPicker.
+
+No new tests. Tests will be added later when this feature is enabled in DRT.
+
+* Resources/pagepopups/calendarPicker.css:
+(.month-mode .day): Remove rounded corners when in month mode.
+* Resources/pagepopups/calendarPicker.js:
+(Month.createFromToday): Creates month containing today.
+(CalendarPicker): Set this.selectionConstructor to Day or Month depending on the mode. Create DayTables or MonthPickerDaysTable depending on the mode.
+(CalendarPicker.
[webkit-changes] [133721] trunk/Source/WebKit/mac
Title: [133721] trunk/Source/WebKit/mac Revision 133721 Author aba...@webkit.org Date 2012-11-06 21:28:47 -0800 (Tue, 06 Nov 2012) Log Message Unreviewed attempt to fix the chromium-mac build. * WebCoreSupport/WebSystemInterface.mm: (InitWebCoreSystemInterface): Modified Paths trunk/Source/WebKit/mac/ChangeLog trunk/Source/WebKit/mac/WebCoreSupport/WebSystemInterface.mm Diff Modified: trunk/Source/WebKit/mac/ChangeLog (133720 => 133721) --- trunk/Source/WebKit/mac/ChangeLog 2012-11-07 05:05:25 UTC (rev 133720) +++ trunk/Source/WebKit/mac/ChangeLog 2012-11-07 05:28:47 UTC (rev 133721) @@ -1,3 +1,10 @@ +2012-11-06 Adam Barth + +Unreviewed attempt to fix the chromium-mac build. + +* WebCoreSupport/WebSystemInterface.mm: +(InitWebCoreSystemInterface): + 2012-11-06 Anders Carlsson Update Java related WKSI function names Modified: trunk/Source/WebKit/mac/WebCoreSupport/WebSystemInterface.mm (133720 => 133721) --- trunk/Source/WebKit/mac/WebCoreSupport/WebSystemInterface.mm 2012-11-07 05:05:25 UTC (rev 133720) +++ trunk/Source/WebKit/mac/WebCoreSupport/WebSystemInterface.mm 2012-11-07 05:28:47 UTC (rev 133721) @@ -165,10 +165,14 @@ INIT(CopyRequestWithStorageSession); INIT(CopyHTTPCookieStorage); INIT(GetHTTPCookieAcceptPolicy); +#if PLATFORM(MAC) INIT(HTTPCookies); +#endif INIT(HTTPCookiesForURL); INIT(SetHTTPCookiesForURL); +#if PLATFORM(MAC) INIT(DeleteAllHTTPCookies); +#endif INIT(DeleteHTTPCookie); INIT(GetCFURLResponseMIMEType); ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [133720] trunk
Title: [133720] trunk Revision 133720 Author commit-qu...@webkit.org Date 2012-11-06 21:05:25 -0800 (Tue, 06 Nov 2012) Log Message Enable REQUEST_AUTOCOMPLETE for chromium port https://bugs.webkit.org/show_bug.cgi?id=101376 Patch by Dan Beam on 2012-11-06 Reviewed by Adam Barth. Source/WebCore: Added a runtime enabled feature to control whether HTMLFormElement#requestAutocomplete is visible from _javascript_. * bindings/generic/RuntimeEnabledFeatures.cpp: (WebCore): * bindings/generic/RuntimeEnabledFeatures.h: (RuntimeEnabledFeatures): Added a binding from RuntimeEnabledFeatures that triggers [V8EnabledAtRuntime=requestAutocomplete]. (WebCore::RuntimeEnabledFeatures::requestAutocompleteEnabled): Added a getter to WebCore to ask whether the runtime flag requestAutocomplete is on. (WebCore::RuntimeEnabledFeatures::setRequestAutocompleteEnabled): Added a setter to WebCore to affect the runtime flag requestAutocomplete. * html/HTMLFormElement.idl: Wrapped commonly grouped features in an #if defined(ENABLED_REQUEST_AUTOCOMPLETE) block and added [V8EnableAtRuntime] so these features can be changed with a command line switch in the chromium port. Source/WebKit/chromium: This patch enables the feature flag REQUEST_AUTOCOMPLETE in WebKit/chromium only to allow web authors to start to use HTMLFormElement#requestAutocomplete as the chrome-side work progresses further. * features.gypi: Turned on the *compile* time flag for REQUEST_AUTOCOMPLETE in chromium's webkit port but also added a *run* time flag that functionally enables the behavior. This means the chromium port will compile in support but will require a run time flag to enable. * public/WebRuntimeFeatures.h: (WebRuntimeFeatures): Added a method to the public chromium run time features interface to allow chrome to enable/disable this feature. * src/WebRuntimeFeatures.cpp: (WebKit::WebRuntimeFeatures::enableRequestAutocomplete): (WebKit): A setter than can be called from chrome code to change the enable/disable requestAutocomplete and associated events at runtime. (WebKit::WebRuntimeFeatures::isRequestAutocompleteEnabled): A getter that returns whether the requestAutocomplete run time feature is enabled. Tools: This patch enables the feature flag REQUEST_AUTOCOMPLETE in WebKit/chromium only to allow web authors to start to use HTMLFormElement#requestAutocomplete as the chrome-side work progresses further. * DumpRenderTree/chromium/TestShell.cpp: (TestShell::TestShell): Enables the requestAutocomplete runtime feature flag during tests. LayoutTests: This patch enables the feature flag REQUEST_AUTOCOMPLETE in WebKit/chromium only to allow web authors to start to use HTMLFormElement#requestAutocomplete as the chrome-side work progresses further. * fast/forms/form-request-autocomplete-expected.txt: Updated to match form-request-autocomplete.html changes. * fast/forms/form-request-autocomplete.html: Remove bug number as per Adam Barth 's advice. * platform/chromium/fast/forms/form-request-autocomplete-expected.txt: Added. Adding expected successful layout test for form-request-autocomplete.html tests to chromium specific directory (as chromium is currently the only place the feature is enabled). Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/fast/forms/form-request-autocomplete-expected.txt trunk/LayoutTests/fast/forms/form-request-autocomplete.html trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/bindings/generic/RuntimeEnabledFeatures.cpp trunk/Source/WebCore/bindings/generic/RuntimeEnabledFeatures.h trunk/Source/WebCore/html/HTMLFormElement.idl trunk/Source/WebKit/chromium/ChangeLog trunk/Source/WebKit/chromium/features.gypi trunk/Source/WebKit/chromium/public/WebRuntimeFeatures.h trunk/Source/WebKit/chromium/src/WebRuntimeFeatures.cpp trunk/Tools/ChangeLog trunk/Tools/DumpRenderTree/chromium/TestShell.cpp Added Paths trunk/LayoutTests/platform/chromium/fast/forms/form-request-autocomplete-expected.txt Diff Modified: trunk/LayoutTests/ChangeLog (133719 => 133720) --- trunk/LayoutTests/ChangeLog 2012-11-07 04:59:58 UTC (rev 133719) +++ trunk/LayoutTests/ChangeLog 2012-11-07 05:05:25 UTC (rev 133720) @@ -1,3 +1,26 @@ +2012-11-06 Dan Beam + +Enable REQUEST_AUTOCOMPLETE for chromium port +https://bugs.webkit.org/show_bug.cgi?id=101376 + +Reviewed by Adam Barth. + +This patch enables the feature flag REQUEST_AUTOCOMPLETE in WebKit/chromium only to allow web authors to start to use +HTMLFormElement#requestAutocomplete as the chrome-side work progresses further. + +* fast/forms/form-request-autocomplete-expected.txt: + +Updated to match form-request-autocomplete.html changes. + +* fast/forms/form-request-autocomplete.html: + +Remove bug number as per Adam Barth 's advice. + +* platform/chromium/fast/forms/form-request-autocomplete
[webkit-changes] [133719] trunk/Source/WebCore
Title: [133719] trunk/Source/WebCore Revision 133719 Author aba...@webkit.org Date 2012-11-06 20:59:58 -0800 (Tue, 06 Nov 2012) Log Message [V8] Unify setJSWrapperForDOMObject and setJSWrapperForDOMNode https://bugs.webkit.org/show_bug.cgi?id=101422 Reviewed by Kentaro Hara. This patch is another incremental step towards the patch in Bug 10110. In this step, we unify setJSWrapperForDOMObject and setJSWrapperForDOMNode. * bindings/scripts/CodeGeneratorV8.pm: (GenerateHeader): (GenerateNormalAttrGetter): (GenerateConstructorCallback): (GenerateNamedConstructorCallback): (GenerateToV8Converters): * bindings/scripts/test/V8/V8Float64Array.h: (WebCore::V8Float64Array::wrap): * bindings/scripts/test/V8/V8TestActiveDOMObject.h: (WebCore::V8TestActiveDOMObject::wrap): * bindings/scripts/test/V8/V8TestCustomNamedGetter.h: (WebCore::V8TestCustomNamedGetter::wrap): * bindings/scripts/test/V8/V8TestEventConstructor.h: (WebCore::V8TestEventConstructor::wrap): * bindings/scripts/test/V8/V8TestEventTarget.h: (WebCore::V8TestEventTarget::wrap): * bindings/scripts/test/V8/V8TestException.h: (WebCore::V8TestException::wrap): * bindings/scripts/test/V8/V8TestInterface.h: (WebCore::V8TestInterface::wrap): * bindings/scripts/test/V8/V8TestMediaQueryListListener.h: (WebCore::V8TestMediaQueryListListener::wrap): * bindings/scripts/test/V8/V8TestNamedConstructor.h: (WebCore::V8TestNamedConstructor::wrap): * bindings/scripts/test/V8/V8TestNode.cpp: (WebCore::V8TestNode::constructorCallback): (WebCore::V8TestNode::wrapSlow): * bindings/scripts/test/V8/V8TestObj.cpp: (WebCore::TestObjV8Internal::readOnlyTestObjAttrAttrGetter): * bindings/scripts/test/V8/V8TestObj.h: (WebCore::V8TestObj::wrap): * bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.h: (WebCore::V8TestSerializedScriptValueInterface::wrap): * bindings/v8/DOMDataStore.cpp: (WebCore::DOMDataStore::current): * bindings/v8/DOMDataStore.h: (WebCore::DOMDataStore::get): (DOMDataStore): * bindings/v8/V8DOMWrapper.cpp: * bindings/v8/V8DOMWrapper.h: (V8DOMWrapper): (WebCore::V8DOMWrapper::setJSWrapperPrivate): (WebCore::V8DOMWrapper::setJSWrapperForDOMObject): * bindings/v8/custom/V8HTMLImageElementConstructor.cpp: (WebCore::v8HTMLImageElementConstructorCallback): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm trunk/Source/WebCore/bindings/scripts/test/V8/V8Float64Array.h trunk/Source/WebCore/bindings/scripts/test/V8/V8TestActiveDOMObject.h trunk/Source/WebCore/bindings/scripts/test/V8/V8TestCustomNamedGetter.h trunk/Source/WebCore/bindings/scripts/test/V8/V8TestEventConstructor.h trunk/Source/WebCore/bindings/scripts/test/V8/V8TestEventTarget.h trunk/Source/WebCore/bindings/scripts/test/V8/V8TestException.h trunk/Source/WebCore/bindings/scripts/test/V8/V8TestInterface.h trunk/Source/WebCore/bindings/scripts/test/V8/V8TestMediaQueryListListener.h trunk/Source/WebCore/bindings/scripts/test/V8/V8TestNamedConstructor.h trunk/Source/WebCore/bindings/scripts/test/V8/V8TestNode.cpp trunk/Source/WebCore/bindings/scripts/test/V8/V8TestObj.cpp trunk/Source/WebCore/bindings/scripts/test/V8/V8TestObj.h trunk/Source/WebCore/bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.h trunk/Source/WebCore/bindings/v8/DOMDataStore.cpp trunk/Source/WebCore/bindings/v8/DOMDataStore.h trunk/Source/WebCore/bindings/v8/V8DOMWrapper.cpp trunk/Source/WebCore/bindings/v8/V8DOMWrapper.h trunk/Source/WebCore/bindings/v8/custom/V8HTMLImageElementConstructor.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (133718 => 133719) --- trunk/Source/WebCore/ChangeLog 2012-11-07 04:56:50 UTC (rev 133718) +++ trunk/Source/WebCore/ChangeLog 2012-11-07 04:59:58 UTC (rev 133719) @@ -1,3 +1,60 @@ +2012-11-06 Adam Barth + +[V8] Unify setJSWrapperForDOMObject and setJSWrapperForDOMNode +https://bugs.webkit.org/show_bug.cgi?id=101422 + +Reviewed by Kentaro Hara. + +This patch is another incremental step towards the patch in Bug 10110. +In this step, we unify setJSWrapperForDOMObject and +setJSWrapperForDOMNode. + +* bindings/scripts/CodeGeneratorV8.pm: +(GenerateHeader): +(GenerateNormalAttrGetter): +(GenerateConstructorCallback): +(GenerateNamedConstructorCallback): +(GenerateToV8Converters): +* bindings/scripts/test/V8/V8Float64Array.h: +(WebCore::V8Float64Array::wrap): +* bindings/scripts/test/V8/V8TestActiveDOMObject.h: +(WebCore::V8TestActiveDOMObject::wrap): +* bindings/scripts/test/V8/V8TestCustomNamedGetter.h: +(WebCore::V8TestCustomNamedGetter::wrap): +* bindings/scripts/test/V8/V8TestEventConstructor.h: +(WebCore::V8TestEventConstructor::wrap): +* bindings/scripts/test/V8/V8TestEventTarget.h: +(WebCore::V8TestEventTarget::wrap): +* bindings/scripts/test/V8/V8TestException.h: +(WebCore::V8TestException::wrap): +* bindings/s
[webkit-changes] [133718] trunk/Tools
Title: [133718] trunk/Tools
Revision 133718
Author commit-qu...@webkit.org
Date 2012-11-06 20:56:50 -0800 (Tue, 06 Nov 2012)
Log Message
[WK2][EFL] Add shortcut for setting a pagination mode on Minibrowser
https://bugs.webkit.org/show_bug.cgi?id=100301
Patch by KyungTae Kim on 2012-11-06
Reviewed by Gyuyoung Kim.
Setting pagination modes is for a paginated view - left to right / right to left / top to bottom / bottom to top.
Assign a shortcut "F7" to set pagination modes for tests.
* MiniBrowser/efl/main.c:
(on_key_down):
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/MiniBrowser/efl/main.c
Diff
Modified: trunk/Tools/ChangeLog (133717 => 133718)
--- trunk/Tools/ChangeLog 2012-11-07 04:55:23 UTC (rev 133717)
+++ trunk/Tools/ChangeLog 2012-11-07 04:56:50 UTC (rev 133718)
@@ -1,5 +1,18 @@
2012-11-06 KyungTae Kim
+[WK2][EFL] Add shortcut for setting a pagination mode on Minibrowser
+https://bugs.webkit.org/show_bug.cgi?id=100301
+
+Reviewed by Gyuyoung Kim.
+
+Setting pagination modes is for a paginated view - left to right / right to left / top to bottom / bottom to top.
+Assign a shortcut "F7" to set pagination modes for tests.
+
+* MiniBrowser/efl/main.c:
+(on_key_down):
+
+2012-11-06 KyungTae Kim
+
[EFL][EWebLauncher] Use Ctrl +/- to zoom in EWebLauncher
https://bugs.webkit.org/show_bug.cgi?id=100207
Modified: trunk/Tools/MiniBrowser/efl/main.c (133717 => 133718)
--- trunk/Tools/MiniBrowser/efl/main.c 2012-11-07 04:55:23 UTC (rev 133717)
+++ trunk/Tools/MiniBrowser/efl/main.c 2012-11-07 04:56:50 UTC (rev 133718)
@@ -165,6 +165,13 @@
} else if (!strcmp(ev->key, "F6")) {
info("Stop (F6) was pressed, stop loading.\n");
ewk_view_stop(obj);
+} else if (!strcmp(ev->key, "F7")) {
+Ewk_Pagination_Mode mode = ewk_view_pagination_mode_get(obj);
+mode = (++mode) % (EWK_PAGINATION_MODE_BOTTOM_TO_TOP + 1);
+if (ewk_view_pagination_mode_set(obj, mode))
+info("Change Pagination Mode (F7) was pressed, changed to: %d\n", mode);
+else
+info("Change Pagination Mode (F7) was pressed, but NOT changed!");
} else if (!strcmp(ev->key, "n") && ctrlPressed) {
info("Create new window (Ctrl+n) was pressed.\n");
Browser_Window *window = window_create(DEFAULT_URL);
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [133717] trunk
Title: [133717] trunk
Revision 133717
Author ke...@chromium.org
Date 2012-11-06 20:55:23 -0800 (Tue, 06 Nov 2012)
Log Message
Crash due to column span under button element
https://bugs.webkit.org/show_bug.cgi?id=101402
Reviewed by Abhishek Arya.
Source/WebCore:
When there is a column-spanning child of a RenderButton
splitBlocks() must split the RenderButton as well as its
only permitted direct child, the anonymous block referenced
by m_inner. A crash was occurring because splitBlocks()
calls addChildIgnoringAnonymousColumnBlocks() to add the
cloned m_inner to the cloned RenderButton, which meant the
m_inner for the cloned RenderButton was not being set even
though a child was being added. This violates state
assumptions in the RenderButton code.
This patch prevents any descendants of RenderButton from
spanning columns. Also, it adds a precautionary check in
RenderButton::removeChild() to mitigate problems if similar
state problems are found in future.
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::containingColumnsBlock):
* rendering/RenderButton.cpp:
(WebCore::RenderButton::removeChild):
LayoutTests:
Test creates crashing condition for bug 101402.
* fast/block/colspan-under-button-crash.html: Added.
* fast/block/colspan-under-button-crash-expected.txt: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderBlock.cpp
trunk/Source/WebCore/rendering/RenderButton.cpp
Added Paths
trunk/LayoutTests/fast/block/colspan-under-button-crash-expected.txt
trunk/LayoutTests/fast/block/colspan-under-button-crash.html
Diff
Modified: trunk/LayoutTests/ChangeLog (133716 => 133717)
--- trunk/LayoutTests/ChangeLog 2012-11-07 04:50:50 UTC (rev 133716)
+++ trunk/LayoutTests/ChangeLog 2012-11-07 04:55:23 UTC (rev 133717)
@@ -1,3 +1,15 @@
+2012-11-06 Ken Buchanan
+
+Crash due to column span under button element
+https://bugs.webkit.org/show_bug.cgi?id=101402
+
+Reviewed by Abhishek Arya.
+
+Test creates crashing condition for bug 101402.
+
+* fast/block/colspan-under-button-crash.html: Added.
+* fast/block/colspan-under-button-crash-expected.txt: Added.
+
2012-11-06 Jaehun Lim
[EFL][WK2] fast/dom/shadow/shadowdom-for-object-only-shadow.html fails
Added: trunk/LayoutTests/fast/block/colspan-under-button-crash-expected.txt (0 => 133717)
--- trunk/LayoutTests/fast/block/colspan-under-button-crash-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/block/colspan-under-button-crash-expected.txt 2012-11-07 04:55:23 UTC (rev 133717)
@@ -0,0 +1 @@
+PASS if no crash or assert in debug
Added: trunk/LayoutTests/fast/block/colspan-under-button-crash.html (0 => 133717)
--- trunk/LayoutTests/fast/block/colspan-under-button-crash.html (rev 0)
+++ trunk/LayoutTests/fast/block/colspan-under-button-crash.html 2012-11-07 04:55:23 UTC (rev 133717)
@@ -0,0 +1,34 @@
+
+
+
+.c0 { display: inherit; }
+.c10 { display: table-column-group; -webkit-column-span: all; }
+.c11[class$="c11"] { vertical-align: -10; -webkit-column-width: 1px; }
+.c17 { overflow: hidden; position: fixed; }
+.c17::after { position: inherit; content: no-close-quote;
+
+window._onload_ = function() {
+pElem = document.createElement('p');
+pElem.setAttribute('class', 'c11');
+
+citeElem = document.createElement('cite');
+citeElem.setAttribute('class', 'c10');
+
+buttonElem = document.createElement('button');
+buttonElem.setAttribute('class', 'c0');
+
+document.documentElement.appendChild(pElem);
+pElem.appendChild(buttonElem);
+buttonElem.appendChild(citeElem);
+
+document.documentElement.offsetHeight;
+buttonElem.setAttribute('class', 'c17');
+document.documentElement.offsetHeight;
+document.documentElement.removeChild(pElem);
+
+document.body.innerHTML = "PASS if no crash or assert in debug";
+if (window.testRunner)
+testRunner.dumpAsText();
+}
+
+
Modified: trunk/Source/WebCore/ChangeLog (133716 => 133717)
--- trunk/Source/WebCore/ChangeLog 2012-11-07 04:50:50 UTC (rev 133716)
+++ trunk/Source/WebCore/ChangeLog 2012-11-07 04:55:23 UTC (rev 133717)
@@ -1,3 +1,30 @@
+2012-11-06 Ken Buchanan
+
+Crash due to column span under button element
+https://bugs.webkit.org/show_bug.cgi?id=101402
+
+Reviewed by Abhishek Arya.
+
+When there is a column-spanning child of a RenderButton
+splitBlocks() must split the RenderButton as well as its
+only permitted direct child, the anonymous block referenced
+by m_inner. A crash was occurring because splitBlocks()
+calls addChildIgnoringAnonymousColumnBlocks() to add the
+cloned m_inner to the cloned RenderButton, which meant the
+m_inner for the cloned RenderButton was not being set even
+though a child was being added. This violates state
+assumptions in the RenderButton co
[webkit-changes] [133716] trunk/LayoutTests
Title: [133716] trunk/LayoutTests Revision 133716 Author commit-qu...@webkit.org Date 2012-11-06 20:50:50 -0800 (Tue, 06 Nov 2012) Log Message [EFL][WK2] fast/dom/shadow/shadowdom-for-object-only-shadow.html fails https://bugs.webkit.org/show_bug.cgi?id=101417 Unreviewed, EFL gardening. shadowdom-for-object-only-shadow.html test is flaky in WK2 only. Patch by Jaehun Lim on 2012-11-06 * platform/efl-wk2/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/efl-wk2/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (133715 => 133716) --- trunk/LayoutTests/ChangeLog 2012-11-07 04:40:33 UTC (rev 133715) +++ trunk/LayoutTests/ChangeLog 2012-11-07 04:50:50 UTC (rev 133716) @@ -1,3 +1,14 @@ +2012-11-06 Jaehun Lim + +[EFL][WK2] fast/dom/shadow/shadowdom-for-object-only-shadow.html fails +https://bugs.webkit.org/show_bug.cgi?id=101417 + +Unreviewed, EFL gardening. + +shadowdom-for-object-only-shadow.html test is flaky in WK2 only. + +* platform/efl-wk2/TestExpectations: + 2012-11-06 Shinya Kawanaka [Shadow] Pseudo custom-elements should start with 'x-'. Modified: trunk/LayoutTests/platform/efl-wk2/TestExpectations (133715 => 133716) --- trunk/LayoutTests/platform/efl-wk2/TestExpectations 2012-11-07 04:40:33 UTC (rev 133715) +++ trunk/LayoutTests/platform/efl-wk2/TestExpectations 2012-11-07 04:50:50 UTC (rev 133716) @@ -166,6 +166,8 @@ # Flaky, probably because the result is sometimes taken before data about visited link have passed through IPC. webkit.org/b/81797 fast/history/visited-link-background-color.html [ Failure Pass ] +webkit.org/b/101417 fast/dom/shadow/shadowdom-for-object-only-shadow.html [ ImageOnlyFailure Pass ] + # Also flaky at least on GTK+ webkit.org/b/72698 media/audio-garbage-collect.html ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [133715] trunk
Title: [133715] trunk
Revision 133715
Author shin...@chromium.org
Date 2012-11-06 20:40:33 -0800 (Tue, 06 Nov 2012)
Log Message
[Shadow] Pseudo custom-elements should start with 'x-'.
https://bugs.webkit.org/show_bug.cgi?id=100919
Reviewed by Dimitri Glazkov.
Source/WebCore:
Pseuco custom-elements should start with 'x-'. 'Pseudo' starting with '-webkit-' should work
only in UserAgent ShadowDOM. If it's used in Author ShadowDOM, it should not work.
Test: fast/dom/shadow/pseudo-attribute-rendering.html
* css/SelectorChecker.cpp:
(WebCore::SelectorChecker::checkSelector): Added ShadowRoot type check.
LayoutTests:
* fast/dom/shadow/pseudo-attribute-rendering-expected.html: Added.
* fast/dom/shadow/pseudo-attribute-rendering.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/SelectorChecker.cpp
Added Paths
trunk/LayoutTests/fast/dom/shadow/pseudo-attribute-rendering-expected.html
trunk/LayoutTests/fast/dom/shadow/pseudo-attribute-rendering.html
Diff
Modified: trunk/LayoutTests/ChangeLog (133714 => 133715)
--- trunk/LayoutTests/ChangeLog 2012-11-07 04:39:00 UTC (rev 133714)
+++ trunk/LayoutTests/ChangeLog 2012-11-07 04:40:33 UTC (rev 133715)
@@ -1,3 +1,13 @@
+2012-11-06 Shinya Kawanaka
+
+[Shadow] Pseudo custom-elements should start with 'x-'.
+https://bugs.webkit.org/show_bug.cgi?id=100919
+
+Reviewed by Dimitri Glazkov.
+
+* fast/dom/shadow/pseudo-attribute-rendering-expected.html: Added.
+* fast/dom/shadow/pseudo-attribute-rendering.html: Added.
+
2012-11-06 Alice Boxhall
Unreviewed gardening. Rebaseline the tests added in http://trac.webkit.org/changeset/133686 for different platforms.
Added: trunk/LayoutTests/fast/dom/shadow/pseudo-attribute-rendering-expected.html (0 => 133715)
--- trunk/LayoutTests/fast/dom/shadow/pseudo-attribute-rendering-expected.html (rev 0)
+++ trunk/LayoutTests/fast/dom/shadow/pseudo-attribute-rendering-expected.html 2012-11-07 04:40:33 UTC (rev 133715)
@@ -0,0 +1,10 @@
+
+
+
+This test checks element.pseudo starting '-webkit-' only works in UserAgentShadowRoot.
+
+This text should be red.
+This text should not be red.
+
+
+
Added: trunk/LayoutTests/fast/dom/shadow/pseudo-attribute-rendering.html (0 => 133715)
--- trunk/LayoutTests/fast/dom/shadow/pseudo-attribute-rendering.html (rev 0)
+++ trunk/LayoutTests/fast/dom/shadow/pseudo-attribute-rendering.html 2012-11-07 04:40:33 UTC (rev 133715)
@@ -0,0 +1,35 @@
+
+
+
+
+div::x-foo {
+color: red;
+}
+div::-webkit-foobar {
+color: red;
+}
+
+
+
+This test checks element.pseudo starting '-webkit-' only works in UserAgentShadowRoot.
+
+
+
+
+