[webkit-changes] [135687] trunk/Source/WebCore
Title: [135687] trunk/Source/WebCore
Revision 135687
Author commit-qu...@webkit.org
Date 2012-11-26 00:10:35 -0800 (Mon, 26 Nov 2012)
Log Message
[V8] Give isolated shells a lifecycle like that of main shells
https://bugs.webkit.org/show_bug.cgi?id=96522
Patch by Dan Carney dcar...@google.com on 2012-11-26
Reviewed by Adam Barth.
Refactored the isolated shells in ScriptController
to be cleaned up the same way the main shell is.
No new tests. No change in functionality.
* bindings/v8/ScriptController.cpp:
(WebCore::ScriptController::~ScriptController):
(WebCore::ScriptController::clearForOutOfMemory):
(WebCore::ScriptController::clearForClose):
(WebCore::ScriptController::clearWindowShell):
* bindings/v8/ScriptController.h:
(ScriptController):
* bindings/v8/V8DOMWindowShell.cpp:
(WebCore::V8DOMWindowShell::destroyIsolatedShell):
(WebCore::V8DOMWindowShell::clearForClose):
* bindings/v8/V8DOMWindowShell.h:
(V8DOMWindowShell):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/v8/ScriptController.cpp
trunk/Source/WebCore/bindings/v8/ScriptController.h
trunk/Source/WebCore/bindings/v8/V8DOMWindowShell.cpp
trunk/Source/WebCore/bindings/v8/V8DOMWindowShell.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (135686 => 135687)
--- trunk/Source/WebCore/ChangeLog 2012-11-26 07:54:56 UTC (rev 135686)
+++ trunk/Source/WebCore/ChangeLog 2012-11-26 08:10:35 UTC (rev 135687)
@@ -1,3 +1,28 @@
+2012-11-26 Dan Carney dcar...@google.com
+
+[V8] Give isolated shells a lifecycle like that of main shells
+https://bugs.webkit.org/show_bug.cgi?id=96522
+
+Reviewed by Adam Barth.
+
+Refactored the isolated shells in ScriptController
+to be cleaned up the same way the main shell is.
+
+No new tests. No change in functionality.
+
+* bindings/v8/ScriptController.cpp:
+(WebCore::ScriptController::~ScriptController):
+(WebCore::ScriptController::clearForOutOfMemory):
+(WebCore::ScriptController::clearForClose):
+(WebCore::ScriptController::clearWindowShell):
+* bindings/v8/ScriptController.h:
+(ScriptController):
+* bindings/v8/V8DOMWindowShell.cpp:
+(WebCore::V8DOMWindowShell::destroyIsolatedShell):
+(WebCore::V8DOMWindowShell::clearForClose):
+* bindings/v8/V8DOMWindowShell.h:
+(V8DOMWindowShell):
+
2012-11-25 Sheriff Bot webkit.review@gmail.com
Unreviewed, rolling out r135656.
Modified: trunk/Source/WebCore/bindings/v8/ScriptController.cpp (135686 => 135687)
--- trunk/Source/WebCore/bindings/v8/ScriptController.cpp 2012-11-26 07:54:56 UTC (rev 135686)
+++ trunk/Source/WebCore/bindings/v8/ScriptController.cpp 2012-11-26 08:10:35 UTC (rev 135687)
@@ -112,8 +112,7 @@
ScriptController::~ScriptController()
{
-m_windowShell-destroyGlobal();
-clearForClose();
+clearForClose(true);
}
void ScriptController::clearScriptObjects()
@@ -145,27 +144,23 @@
#endif
}
-void ScriptController::reset()
+void ScriptController::clearForOutOfMemory()
{
-for (IsolatedWorldMap::iterator iter = m_isolatedWorlds.begin();
- iter != m_isolatedWorlds.end(); ++iter) {
-iter-value-destroyIsolatedShell();
-}
-m_isolatedWorlds.clear();
-V8GCController::hintForCollectGarbage();
+clearForClose(true);
}
-void ScriptController::clearForOutOfMemory()
+void ScriptController::clearForClose(bool destroyGlobal)
{
-clearForClose();
-m_windowShell-destroyGlobal();
+m_windowShell-clearForClose(destroyGlobal);
+for (IsolatedWorldMap::iterator iter = m_isolatedWorlds.begin(); iter != m_isolatedWorlds.end(); ++iter)
+iter-value-clearForClose(destroyGlobal);
+V8GCController::hintForCollectGarbage();
}
void ScriptController::clearForClose()
{
double start = currentTime();
-reset();
-m_windowShell-clearForClose();
+clearForClose(false);
HistogramSupport::histogramCustomCounts(WebCore.ScriptController.clearForClose, (currentTime() - start) * 1000, 0, 1, 50);
}
@@ -655,10 +650,12 @@
void ScriptController::clearWindowShell(DOMWindow*, bool)
{
double start = currentTime();
-reset();
// V8 binding expects ScriptController::clearWindowShell only be called
// when a frame is loading a new page. This creates a new context for the new page.
m_windowShell-clearForNavigation();
+for (IsolatedWorldMap::iterator iter = m_isolatedWorlds.begin(); iter != m_isolatedWorlds.end(); ++iter)
+iter-value-clearForNavigation();
+V8GCController::hintForCollectGarbage();
HistogramSupport::histogramCustomCounts(WebCore.ScriptController.clearWindowShell, (currentTime() - start) * 1000, 0, 1, 50);
}
Modified: trunk/Source/WebCore/bindings/v8/ScriptController.h (135686 => 135687)
--- trunk/Source/WebCore/bindings/v8/ScriptController.h 2012-11-26 07:54:56 UTC (rev 135686)
+++ trunk/Source/WebCore/bindings/v8/ScriptController.h
[webkit-changes] [135688] trunk
Title: [135688] trunk
Revision 135688
Author commit-qu...@webkit.org
Date 2012-11-26 00:31:18 -0800 (Mon, 26 Nov 2012)
Log Message
[CMake] Allow user specified compiler flags to take precedence
https://bugs.webkit.org/show_bug.cgi?id=103101
Patch by Laszlo Gombos l.gom...@samsung.com on 2012-11-26
Reviewed by Brent Fulgham.
Make sure that compiler and linker flags specified by the build system
are always prepended to the variables that can be specified by the
environment and the user as well.
* Source/cmake/OptionsCommon.cmake:
* Source/cmake/OptionsWindows.cmake:
* Source/cmake/WebKitHelpers.cmake:
Modified Paths
trunk/ChangeLog
trunk/Source/cmake/OptionsCommon.cmake
trunk/Source/cmake/OptionsWindows.cmake
trunk/Source/cmake/WebKitHelpers.cmake
Diff
Modified: trunk/ChangeLog (135687 => 135688)
--- trunk/ChangeLog 2012-11-26 08:10:35 UTC (rev 135687)
+++ trunk/ChangeLog 2012-11-26 08:31:18 UTC (rev 135688)
@@ -1,3 +1,18 @@
+2012-11-26 Laszlo Gombos l.gom...@samsung.com
+
+[CMake] Allow user specified compiler flags to take precedence
+https://bugs.webkit.org/show_bug.cgi?id=103101
+
+Reviewed by Brent Fulgham.
+
+Make sure that compiler and linker flags specified by the build system
+are always prepended to the variables that can be specified by the
+environment and the user as well.
+
+* Source/cmake/OptionsCommon.cmake:
+* Source/cmake/OptionsWindows.cmake:
+* Source/cmake/WebKitHelpers.cmake:
+
2012-11-23 Alexis Menard ale...@webkit.org
[CSS3 Backgrounds and Borders] Implement new CSS3 background-position parsing.
Modified: trunk/Source/cmake/OptionsCommon.cmake (135687 => 135688)
--- trunk/Source/cmake/OptionsCommon.cmake 2012-11-26 08:10:35 UTC (rev 135687)
+++ trunk/Source/cmake/OptionsCommon.cmake 2012-11-26 08:31:18 UTC (rev 135688)
@@ -30,7 +30,7 @@
IF (${CMAKE_CXX_COMPILER_ID} STREQUAL GNU AND ${LOWERCASE_CMAKE_HOST_SYSTEM_PROCESSOR} MATCHES (i[3-6]86|x86) AND ${CMAKE_BUILD_TYPE} STREQUAL Debug)
# To avoid out of memory when building with debug option in 32bit system.
# See https://bugs.webkit.org/show_bug.cgi?id=77327
-SET(CMAKE_SHARED_LINKER_FLAGS ${CMAKE_SHARED_LINKER_FLAGS} -Wl,--no-keep-memory)
+SET(CMAKE_SHARED_LINKER_FLAGS -Wl,--no-keep-memory ${CMAKE_SHARED_LINKER_FLAGS})
ENDIF ()
SET(LIB_SUFFIX CACHE STRING Define suffix of directory name (32/64))
Modified: trunk/Source/cmake/OptionsWindows.cmake (135687 => 135688)
--- trunk/Source/cmake/OptionsWindows.cmake 2012-11-26 08:10:35 UTC (rev 135687)
+++ trunk/Source/cmake/OptionsWindows.cmake 2012-11-26 08:31:18 UTC (rev 135688)
@@ -14,8 +14,8 @@
STRING(REGEX REPLACE /GR CMAKE_CXX_FLAGS ${CMAKE_CXX_FLAGS}) # Disable RTTI
IF (NOT MSVC_VERSION LESS 1500)
-SET(CMAKE_C_FLAGS ${CMAKE_C_FLAGS} /MP)
-SET(CMAKE_CXX_FLAGS ${CMAKE_CXX_FLAGS} /MP)
+SET(CMAKE_C_FLAGS /MP ${CMAKE_C_FLAGS})
+SET(CMAKE_CXX_FLAGS /MP ${CMAKE_CXX_FLAGS})
ENDIF ()
ENDIF ()
Modified: trunk/Source/cmake/WebKitHelpers.cmake (135687 => 135688)
--- trunk/Source/cmake/WebKitHelpers.cmake 2012-11-26 08:10:35 UTC (rev 135687)
+++ trunk/Source/cmake/WebKitHelpers.cmake 2012-11-26 08:31:18 UTC (rev 135688)
@@ -21,7 +21,7 @@
# Disable some optimizations on buggy compiler versions
# GCC 4.5.1 does not implement -ftree-sra correctly
IF (${COMPILER_VERSION} STREQUAL 4.5.1)
-SET(OLD_COMPILE_FLAGS ${OLD_COMPILE_FLAGS} -fno-tree-sra)
+SET(OLD_COMPILE_FLAGS -fno-tree-sra ${OLD_COMPILE_FLAGS})
ENDIF ()
IF (NOT SHARED_CORE)
@@ -42,7 +42,7 @@
# Enable errors on warning
IF (OPTION_ENABLE_WERROR)
-SET(OLD_COMPILE_FLAGS ${OLD_COMPILE_FLAGS} -Werror -Wno-error=unused-parameter)
+SET(OLD_COMPILE_FLAGS -Werror -Wno-error=unused-parameter ${OLD_COMPILE_FLAGS})
ENDIF ()
# Disable C++0x compat warnings for GCC = 4.6.0 until we build
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [135689] trunk/Source/WebCore
Title: [135689] trunk/Source/WebCore
Revision 135689
Author shin...@chromium.org
Date 2012-11-26 01:07:19 -0800 (Mon, 26 Nov 2012)
Log Message
[Shadow] Attaching children of a shadow host takes O(N^2) where N is the number of host children
https://bugs.webkit.org/show_bug.cgi?id=103017
Reviewed by Hajime Morita.
Since ContentDistribution was just a Vector, ContentDistribution::find() took O(N). Each child of shadow host calls it.
As a result, attaching children of shadow host takes O(N^2) at all.
In this patch, we make ContentDistribution::find() O(1) amortizedly. We introduce HashMap from a Node to Vector index,
and use it for ContentDistribution::find().
No new tests, covered by existing tests.
* html/shadow/ContentDistributor.cpp:
(WebCore::ContentDistribution::swap):
(WebCore):
(WebCore::ContentDistribution::append):
(WebCore::ContentDistribution::find):
(WebCore::ContentDistributor::distributeSelectionsTo):
* html/shadow/ContentDistributor.h:
(ContentDistribution): ContentDistribution now contains Vector and a reverse map.
(WebCore::ContentDistribution::first):
(WebCore::ContentDistribution::last):
(WebCore::ContentDistribution::at):
(WebCore::ContentDistribution::size):
(WebCore::ContentDistribution::isEmpty):
(WebCore::ContentDistribution::clear):
(WebCore::ContentDistribution::contains):
(WebCore::ContentDistribution::nodes):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/shadow/ContentDistributor.cpp
trunk/Source/WebCore/html/shadow/ContentDistributor.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (135688 => 135689)
--- trunk/Source/WebCore/ChangeLog 2012-11-26 08:31:18 UTC (rev 135688)
+++ trunk/Source/WebCore/ChangeLog 2012-11-26 09:07:19 UTC (rev 135689)
@@ -1,3 +1,35 @@
+2012-11-26 Shinya Kawanaka shin...@chromium.org
+
+[Shadow] Attaching children of a shadow host takes O(N^2) where N is the number of host children
+https://bugs.webkit.org/show_bug.cgi?id=103017
+
+Reviewed by Hajime Morita.
+
+Since ContentDistribution was just a Vector, ContentDistribution::find() took O(N). Each child of shadow host calls it.
+As a result, attaching children of shadow host takes O(N^2) at all.
+
+In this patch, we make ContentDistribution::find() O(1) amortizedly. We introduce HashMap from a Node to Vector index,
+and use it for ContentDistribution::find().
+
+No new tests, covered by existing tests.
+
+* html/shadow/ContentDistributor.cpp:
+(WebCore::ContentDistribution::swap):
+(WebCore):
+(WebCore::ContentDistribution::append):
+(WebCore::ContentDistribution::find):
+(WebCore::ContentDistributor::distributeSelectionsTo):
+* html/shadow/ContentDistributor.h:
+(ContentDistribution): ContentDistribution now contains Vector and a reverse map.
+(WebCore::ContentDistribution::first):
+(WebCore::ContentDistribution::last):
+(WebCore::ContentDistribution::at):
+(WebCore::ContentDistribution::size):
+(WebCore::ContentDistribution::isEmpty):
+(WebCore::ContentDistribution::clear):
+(WebCore::ContentDistribution::contains):
+(WebCore::ContentDistribution::nodes):
+
2012-11-26 Dan Carney dcar...@google.com
[V8] Give isolated shells a lifecycle like that of main shells
Modified: trunk/Source/WebCore/html/shadow/ContentDistributor.cpp (135688 => 135689)
--- trunk/Source/WebCore/html/shadow/ContentDistributor.cpp 2012-11-26 08:31:18 UTC (rev 135688)
+++ trunk/Source/WebCore/html/shadow/ContentDistributor.cpp 2012-11-26 09:07:19 UTC (rev 135689)
@@ -36,6 +36,28 @@
namespace WebCore {
+void ContentDistribution::swap(ContentDistribution other)
+{
+m_nodes.swap(other.m_nodes);
+m_indices.swap(other.m_indices);
+}
+
+void ContentDistribution::append(PassRefPtrNode node)
+{
+size_t size = m_nodes.size();
+m_indices.set(node.get(), size);
+m_nodes.append(node);
+}
+
+size_t ContentDistribution::find(const Node* node) const
+{
+HashMapconst Node*, size_t::const_iterator it = m_indices.find(node);
+if (it == m_indices.end())
+return notFound;
+
+return it.get()-value;
+}
+
ContentDistributor::ContentDistributor()
: m_validity(Undetermined)
{
@@ -156,10 +178,10 @@
if (distributed[i])
continue;
-if (!query.matches(pool, i))
+if (!query.matches(pool.nodes(), i))
continue;
-Node* child = pool[i].get();
+Node* child = pool.at(i).get();
distribution.append(child);
m_nodeToInsertionPoint.add(child, insertionPoint);
distributed[i] = true;
Modified: trunk/Source/WebCore/html/shadow/ContentDistributor.h (135688 => 135689)
--- trunk/Source/WebCore/html/shadow/ContentDistributor.h 2012-11-26 08:31:18 UTC (rev 135688)
+++ trunk/Source/WebCore/html/shadow/ContentDistributor.h 2012-11-26 09:07:19 UTC (rev 135689)
@@ -44,8 +44,30 @@
[webkit-changes] [135690] trunk/Source/WebCore
Title: [135690] trunk/Source/WebCore Revision 135690 Author jon...@apple.com Date 2012-11-26 01:11:52 -0800 (Mon, 26 Nov 2012) Log Message Extend EventDispatcher::dispatchSimulatedClick to allow sending a mouseover event https://bugs.webkit.org/show_bug.cgi?id=102610 rdar://problem/12725663 Reviewed by Darin Adler. Update the dispatchSimulatedClick() to take option enums for dispatching events. * dom/SimulatedClickOptions.h: Added. Define two options enums. One tracks which mouse events to send. The other determines whether to force the element to repaint. * dom/EventDispatcher.cpp: (WebCore::EventDispatcher::dispatchSimulatedClick): Refactor to use the option enums. * dom/EventDispatcher.h: (EventDispatcher): Update function signature. * dom/Node.cpp: Refactor parameters to use the options enums rather than booleans. (WebCore::Node::dispatchSimulatedClick): * dom/Node.h: Refactor. Remove redundant comments. * html/BaseCheckableInputType.cpp: (WebCore::BaseCheckableInputType::accessKeyAction): * html/BaseClickableWithKeyInputType.cpp: (WebCore::BaseClickableWithKeyInputType::accessKeyAction): * html/HTMLAnchorElement.cpp: (WebCore::HTMLAnchorElement::accessKeyAction): * html/HTMLButtonElement.cpp: (WebCore::HTMLButtonElement::accessKeyAction): * html/HTMLElement.cpp: (WebCore::HTMLElement::click): (WebCore::HTMLElement::accessKeyAction): * html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::accessKeyAction): * html/RadioInputType.cpp: (WebCore::RadioInputType::handleKeydownEvent): * html/RangeInputType.cpp: (WebCore::RangeInputType::accessKeyAction): Add SimulatedClickOptions.h. * GNUmakefile.list.am: * Target.pri: * WebCore.gypi: * WebCore.vcproj/WebCore.vcproj: * WebCore.xcodeproj/project.pbxproj: Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/GNUmakefile.list.am trunk/Source/WebCore/Target.pri trunk/Source/WebCore/WebCore.gypi trunk/Source/WebCore/WebCore.vcproj/WebCore.vcproj trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj trunk/Source/WebCore/dom/EventDispatcher.cpp trunk/Source/WebCore/dom/EventDispatcher.h trunk/Source/WebCore/dom/Node.cpp trunk/Source/WebCore/dom/Node.h trunk/Source/WebCore/html/BaseCheckableInputType.cpp trunk/Source/WebCore/html/BaseClickableWithKeyInputType.cpp trunk/Source/WebCore/html/HTMLAnchorElement.cpp trunk/Source/WebCore/html/HTMLButtonElement.cpp trunk/Source/WebCore/html/HTMLElement.cpp trunk/Source/WebCore/html/HTMLSelectElement.cpp trunk/Source/WebCore/html/RadioInputType.cpp trunk/Source/WebCore/html/RangeInputType.cpp Added Paths trunk/Source/WebCore/dom/SimulatedClickOptions.h Diff Modified: trunk/Source/WebCore/ChangeLog (135689 => 135690) --- trunk/Source/WebCore/ChangeLog 2012-11-26 09:07:19 UTC (rev 135689) +++ trunk/Source/WebCore/ChangeLog 2012-11-26 09:11:52 UTC (rev 135690) @@ -1,3 +1,51 @@ +2012-11-26 Jon Lee jon...@apple.com + +Extend EventDispatcher::dispatchSimulatedClick to allow sending a mouseover event +https://bugs.webkit.org/show_bug.cgi?id=102610 +rdar://problem/12725663 + +Reviewed by Darin Adler. + +Update the dispatchSimulatedClick() to take option enums for dispatching events. + +* dom/SimulatedClickOptions.h: Added. Define two options enums. One tracks which mouse +events to send. The other determines whether to force the element to repaint. + +* dom/EventDispatcher.cpp: +(WebCore::EventDispatcher::dispatchSimulatedClick): Refactor to use the option enums. +* dom/EventDispatcher.h: +(EventDispatcher): Update function signature. + +* dom/Node.cpp: Refactor parameters to use the options enums rather than booleans. +(WebCore::Node::dispatchSimulatedClick): +* dom/Node.h: + +Refactor. Remove redundant comments. +* html/BaseCheckableInputType.cpp: +(WebCore::BaseCheckableInputType::accessKeyAction): +* html/BaseClickableWithKeyInputType.cpp: +(WebCore::BaseClickableWithKeyInputType::accessKeyAction): +* html/HTMLAnchorElement.cpp: +(WebCore::HTMLAnchorElement::accessKeyAction): +* html/HTMLButtonElement.cpp: +(WebCore::HTMLButtonElement::accessKeyAction): +* html/HTMLElement.cpp: +(WebCore::HTMLElement::click): +(WebCore::HTMLElement::accessKeyAction): +* html/HTMLSelectElement.cpp: +(WebCore::HTMLSelectElement::accessKeyAction): +* html/RadioInputType.cpp: +(WebCore::RadioInputType::handleKeydownEvent): +* html/RangeInputType.cpp: +(WebCore::RangeInputType::accessKeyAction): + +Add SimulatedClickOptions.h. +* GNUmakefile.list.am: +* Target.pri: +* WebCore.gypi: +* WebCore.vcproj/WebCore.vcproj: +* WebCore.xcodeproj/project.pbxproj: + 2012-11-26 Shinya Kawanaka shin...@chromium.org [Shadow] Attaching children of a shadow host takes O(N^2) where N is the number of host
[webkit-changes] [135691] trunk/LayoutTests
Title: [135691] trunk/LayoutTests Revision 135691 Author zandober...@gmail.com Date 2012-11-26 01:18:30 -0800 (Mon, 26 Nov 2012) Log Message Unreviewed GTK gardening. Adding timeout expectation for the new a11y test added in r135680. * platform/gtk/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/gtk/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (135690 => 135691) --- trunk/LayoutTests/ChangeLog 2012-11-26 09:11:52 UTC (rev 135690) +++ trunk/LayoutTests/ChangeLog 2012-11-26 09:18:30 UTC (rev 135691) @@ -1,3 +1,11 @@ +2012-11-26 Zan Dobersek zandober...@gmail.com + +Unreviewed GTK gardening. + +Adding timeout expectation for the new a11y test added in r135680. + +* platform/gtk/TestExpectations: + 2012-11-25 Ryuan Choi ryuan.c...@samsung.com Unreviewed gardening. Modified: trunk/LayoutTests/platform/gtk/TestExpectations (135690 => 135691) --- trunk/LayoutTests/platform/gtk/TestExpectations 2012-11-26 09:11:52 UTC (rev 135690) +++ trunk/LayoutTests/platform/gtk/TestExpectations 2012-11-26 09:18:30 UTC (rev 135691) @@ -666,6 +666,7 @@ webkit.org/b/61826 fast/events/drag-image-filename.html [ Timeout ] webkit.org/b/98350 accessibility/aria-invalid.html [ Timeout ] +webkit.org/b/103223 accessibility/file-upload-button-with-axpress.html [ Timeout ] webkit.org/b/73003 [ Release ] editing/spelling/spellcheck-async.html [ Timeout ] webkit.org/b/73003 [ Release ] editing/spelling/spellcheck-paste.html [ Timeout ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [135692] trunk/LayoutTests
Title: [135692] trunk/LayoutTests Revision 135692 Author apav...@chromium.org Date 2012-11-26 01:27:28 -0800 (Mon, 26 Nov 2012) Log Message [Chromium] Unreviewed, mark platform/chromium/fast/forms/calendar-picker/week-picker-key-operations.html as flaky (date-dependent). * platform/chromium/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (135691 => 135692) --- trunk/LayoutTests/ChangeLog 2012-11-26 09:18:30 UTC (rev 135691) +++ trunk/LayoutTests/ChangeLog 2012-11-26 09:27:28 UTC (rev 135692) @@ -1,3 +1,9 @@ +2012-11-26 Alexander Pavlov apav...@chromium.org + +[Chromium] Unreviewed, mark platform/chromium/fast/forms/calendar-picker/week-picker-key-operations.html as flaky (date-dependent). + +* platform/chromium/TestExpectations: + 2012-11-26 Zan Dobersek zandober...@gmail.com Unreviewed GTK gardening. Modified: trunk/LayoutTests/platform/chromium/TestExpectations (135691 => 135692) --- trunk/LayoutTests/platform/chromium/TestExpectations 2012-11-26 09:18:30 UTC (rev 135691) +++ trunk/LayoutTests/platform/chromium/TestExpectations 2012-11-26 09:27:28 UTC (rev 135692) @@ -4252,3 +4252,6 @@ webkit.org/b/103148 [ Linux Win Mac ] svg/batik/text/textPosition2.svg [ ImageOnlyFailure ] webkit.org/b/103181 [ Win7 ] http/tests/local/drag-over-remote-content.html [ Pass Crash Timeout ] webkit.org/b/103183 [ Win7 SnowLeopard ] media/video-seek-past-end-playing.html [ Pass Crash ] + +# This test results are date-dependent, see bug. +webkit.org/b/103225 platform/chromium/fast/forms/calendar-picker/week-picker-key-operations.html [ Pass Failure ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [135693] trunk
Title: [135693] trunk
Revision 135693
Author morr...@google.com
Date 2012-11-26 01:38:43 -0800 (Mon, 26 Nov 2012)
Log Message
[Shadow DOM] Implement Element::createShadowRoot()
https://bugs.webkit.org/show_bug.cgi?id=102911
Reviewed by Kentaro Hara.
Source/WebCore:
Added an API implementation and exposed it.
This is basically an alias of the ShadowRoot constructor, which
will be removed as bug 102913.
Test: fast/dom/shadow/shadow-aware-create-shdow-root.html
* bindings/gobject/GNUmakefile.am:
* dom/Element.cpp:
(WebCore::Element::createShadowRoot):
(WebCore):
* dom/Element.h:
(Element):
* dom/Element.idl:
LayoutTests:
The coverage might not seem comprehensive at a glance. However,
this is just an alias of ShadowRoot constructor and there are
bunch of test cases which cover it.
As bug 102913 will convert such callsites to use createShadowRoot(),
the API will get be covered well then.
* fast/dom/shadow/shadow-aware-create-shdow-root-expected.txt: Added.
* fast/dom/shadow/shadow-aware-create-shdow-root.html: Added.
Further ShadowAware API will come here.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/gobject/GNUmakefile.am
trunk/Source/WebCore/dom/Element.cpp
trunk/Source/WebCore/dom/Element.h
trunk/Source/WebCore/dom/Element.idl
Added Paths
trunk/LayoutTests/fast/dom/shadow/shadow-aware-create-shadow-root-expected.txt
trunk/LayoutTests/fast/dom/shadow/shadow-aware-create-shadow-root.html
Diff
Modified: trunk/LayoutTests/ChangeLog (135692 => 135693)
--- trunk/LayoutTests/ChangeLog 2012-11-26 09:27:28 UTC (rev 135692)
+++ trunk/LayoutTests/ChangeLog 2012-11-26 09:38:43 UTC (rev 135693)
@@ -1,3 +1,21 @@
+2012-11-26 Hajime Morrita morr...@google.com
+
+[Shadow DOM] Implement Element::createShadowRoot()
+https://bugs.webkit.org/show_bug.cgi?id=102911
+
+Reviewed by Kentaro Hara.
+
+The coverage might not seem comprehensive at a glance. However,
+this is just an alias of ShadowRoot constructor and there are
+bunch of test cases which cover it.
+
+As bug 102913 will convert such callsites to use createShadowRoot(),
+the API will get be covered well then.
+
+* fast/dom/shadow/shadow-aware-create-shdow-root-expected.txt: Added.
+* fast/dom/shadow/shadow-aware-create-shdow-root.html: Added.
+ Further ShadowAware API will come here.
+
2012-11-26 Alexander Pavlov apav...@chromium.org
[Chromium] Unreviewed, mark platform/chromium/fast/forms/calendar-picker/week-picker-key-operations.html as flaky (date-dependent).
Added: trunk/LayoutTests/fast/dom/shadow/shadow-aware-create-shadow-root-expected.txt (0 => 135693)
--- trunk/LayoutTests/fast/dom/shadow/shadow-aware-create-shadow-root-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/dom/shadow/shadow-aware-create-shadow-root-expected.txt 2012-11-26 09:38:43 UTC (rev 135693)
@@ -0,0 +1,13 @@
+Tests for ShadowAware JS APIs.
+
+On success, you will see a series of PASS messages, followed by TEST COMPLETE.
+
+
+PASS root1.constructor is window.WebKitShadowRoot
+PASS root1 is not root2
+PASS root1 is window.internals.oldestShadowRoot(host)
+PASS root2 is window.internals.youngestShadowRoot(host)
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
Added: trunk/LayoutTests/fast/dom/shadow/shadow-aware-create-shadow-root.html (0 => 135693)
--- trunk/LayoutTests/fast/dom/shadow/shadow-aware-create-shadow-root.html (rev 0)
+++ trunk/LayoutTests/fast/dom/shadow/shadow-aware-create-shadow-root.html 2012-11-26 09:38:43 UTC (rev 135693)
@@ -0,0 +1,22 @@
+!DOCTYPE html
+html
+head
+script src=""
+/head
+body
+script
+description(Tests for ShadowAware JS APIs.);
+
+// ShadowAware.createShadowRoot()
+var host = document.createElement('div');
+var root1 = host.createShadowRoot();
+var root2 = host.createShadowRoot();
+shouldBe(root1.constructor, window.WebKitShadowRoot);
+shouldNotBe(root1, root2);
+shouldBe(root1, window.internals.oldestShadowRoot(host));
+shouldBe(root2, window.internals.youngestShadowRoot(host));
+
+/script
+script src=""
+/body
+/html
Modified: trunk/Source/WebCore/ChangeLog (135692 => 135693)
--- trunk/Source/WebCore/ChangeLog 2012-11-26 09:27:28 UTC (rev 135692)
+++ trunk/Source/WebCore/ChangeLog 2012-11-26 09:38:43 UTC (rev 135693)
@@ -1,3 +1,25 @@
+2012-11-26 Hajime Morrita morr...@google.com
+
+[Shadow DOM] Implement Element::createShadowRoot()
+https://bugs.webkit.org/show_bug.cgi?id=102911
+
+Reviewed by Kentaro Hara.
+
+Added an API implementation and exposed it.
+
+This is basically an alias of the ShadowRoot constructor, which
+will be removed as bug 102913.
+
+Test: fast/dom/shadow/shadow-aware-create-shdow-root.html
+
+* bindings/gobject/GNUmakefile.am:
+* dom/Element.cpp:
+(WebCore::Element::createShadowRoot):
+(WebCore):
+
[webkit-changes] [135694] trunk/Source/WebCore
Title: [135694] trunk/Source/WebCore Revision 135694 Author commit-qu...@webkit.org Date 2012-11-26 02:11:53 -0800 (Mon, 26 Nov 2012) Log Message [Chromium] Enable input type datetime-local https://bugs.webkit.org/show_bug.cgi?id=103213 Patch by Kunihiko Sakamoto ksakam...@chromium.org on 2012-11-26 Reviewed by Kent Tamura. This patch enables input type=datetime-local for Chromium. No new tests. Covered by existing tests. * bindings/generic/RuntimeEnabledFeatures.cpp: (WebCore): Changed RuntimeEnabledFeatures::isInputTypeDateTimeLocalEnabled to true if INPUT_TYPE_DATETIMELOCAL is enabled. Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/bindings/generic/RuntimeEnabledFeatures.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (135693 => 135694) --- trunk/Source/WebCore/ChangeLog 2012-11-26 09:38:43 UTC (rev 135693) +++ trunk/Source/WebCore/ChangeLog 2012-11-26 10:11:53 UTC (rev 135694) @@ -1,3 +1,18 @@ +2012-11-26 Kunihiko Sakamoto ksakam...@chromium.org + +[Chromium] Enable input type datetime-local +https://bugs.webkit.org/show_bug.cgi?id=103213 + +Reviewed by Kent Tamura. + +This patch enables input type=datetime-local for Chromium. + +No new tests. Covered by existing tests. + +* bindings/generic/RuntimeEnabledFeatures.cpp: +(WebCore): Changed RuntimeEnabledFeatures::isInputTypeDateTimeLocalEnabled to true +if INPUT_TYPE_DATETIMELOCAL is enabled. + 2012-11-26 Hajime Morrita morr...@google.com [Shadow DOM] Implement Element::createShadowRoot() Modified: trunk/Source/WebCore/bindings/generic/RuntimeEnabledFeatures.cpp (135693 => 135694) --- trunk/Source/WebCore/bindings/generic/RuntimeEnabledFeatures.cpp 2012-11-26 09:38:43 UTC (rev 135693) +++ trunk/Source/WebCore/bindings/generic/RuntimeEnabledFeatures.cpp 2012-11-26 10:11:53 UTC (rev 135694) @@ -205,12 +205,8 @@ #endif #if ENABLE(INPUT_TYPE_DATETIMELOCAL) -#if PLATFORM(CHROMIUM) !OS(ANDROID) -bool RuntimeEnabledFeatures::isInputTypeDateTimeLocalEnabled = false; -#else bool RuntimeEnabledFeatures::isInputTypeDateTimeLocalEnabled = true; #endif -#endif #if ENABLE(INPUT_TYPE_MONTH) bool RuntimeEnabledFeatures::isInputTypeMonthEnabled = true; ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [135695] trunk/Source/WebCore
Title: [135695] trunk/Source/WebCore
Revision 135695
Author morr...@google.com
Date 2012-11-26 02:21:53 -0800 (Mon, 26 Nov 2012)
Log Message
[Refactoring] Some Node::isDescendant calls can be replaced with Node::contains()
https://bugs.webkit.org/show_bug.cgi?id=103211
Reviewed by Daniel Bates.
A couple of call sites of isDescendant() does same as Node::contains().
This change replaces these locations with Node::contains().
No new tests, no behavior change.
* dom/Node.cpp:
(WebCore::checkAcceptChild):
* dom/Range.cpp:
(WebCore::Range::surroundContents):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/Node.cpp
trunk/Source/WebCore/dom/Range.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (135694 => 135695)
--- trunk/Source/WebCore/ChangeLog 2012-11-26 10:11:53 UTC (rev 135694)
+++ trunk/Source/WebCore/ChangeLog 2012-11-26 10:21:53 UTC (rev 135695)
@@ -1,3 +1,20 @@
+2012-11-26 Hajime Morrita morr...@google.com
+
+[Refactoring] Some Node::isDescendant calls can be replaced with Node::contains()
+https://bugs.webkit.org/show_bug.cgi?id=103211
+
+Reviewed by Daniel Bates.
+
+A couple of call sites of isDescendant() does same as Node::contains().
+This change replaces these locations with Node::contains().
+
+No new tests, no behavior change.
+
+* dom/Node.cpp:
+(WebCore::checkAcceptChild):
+* dom/Range.cpp:
+(WebCore::Range::surroundContents):
+
2012-11-26 Kunihiko Sakamoto ksakam...@chromium.org
[Chromium] Enable input type datetime-local
Modified: trunk/Source/WebCore/dom/Node.cpp (135694 => 135695)
--- trunk/Source/WebCore/dom/Node.cpp 2012-11-26 10:11:53 UTC (rev 135694)
+++ trunk/Source/WebCore/dom/Node.cpp 2012-11-26 10:21:53 UTC (rev 135695)
@@ -1193,7 +1193,7 @@
// HIERARCHY_REQUEST_ERR: Raised if this node is of a type that does not allow children of the type of the
// newChild node, or if the node to append is one of this node's ancestors.
-if (newChild == newParent || newParent-isDescendantOf(newChild)) {
+if (newChild-contains(newParent)) {
ec = HIERARCHY_REQUEST_ERR;
return;
}
Modified: trunk/Source/WebCore/dom/Range.cpp (135694 => 135695)
--- trunk/Source/WebCore/dom/Range.cpp 2012-11-26 10:11:53 UTC (rev 135694)
+++ trunk/Source/WebCore/dom/Range.cpp 2012-11-26 10:21:53 UTC (rev 135695)
@@ -1447,7 +1447,7 @@
return;
}
-if (m_start.container() == newParent || m_start.container()-isDescendantOf(newParent.get())) {
+if (newParent-contains(m_start.container())) {
ec = HIERARCHY_REQUEST_ERR;
return;
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [135696] trunk/Source/WebKit/qt
Title: [135696] trunk/Source/WebKit/qt
Revision 135696
Author michael.brun...@digia.com
Date 2012-11-26 02:35:28 -0800 (Mon, 26 Nov 2012)
Log Message
[Qt] QStyleFacadeImp build break with latest Qt 5
https://bugs.webkit.org/show_bug.cgi?id=103198
Reviewed by Simon Hausmann.
Original patch by J-P Nurmi jpnu...@digia.com.
Fixes QtWebKit build by replacing qobject_cast to
QMacStyle with calls to QObject::inherits. Also
replaces Q_WS_MAC preprocesser directives with Q_OS_MAC
for Qt 5 compatibility.
* WebCoreSupport/QStyleFacadeImp.cpp:
(WebKit::QStyleFacadeImp::getButtonMetrics):
(WebKit::QStyleFacadeImp::paintComboBox):
(WebKit::QStyleFacadeImp::paintInnerSpinButton):
(WebKit::QStyleFacadeImp::paintScrollBar):
Modified Paths
trunk/Source/WebKit/qt/ChangeLog
trunk/Source/WebKit/qt/WebCoreSupport/QStyleFacadeImp.cpp
Diff
Modified: trunk/Source/WebKit/qt/ChangeLog (135695 => 135696)
--- trunk/Source/WebKit/qt/ChangeLog 2012-11-26 10:21:53 UTC (rev 135695)
+++ trunk/Source/WebKit/qt/ChangeLog 2012-11-26 10:35:28 UTC (rev 135696)
@@ -1,3 +1,23 @@
+2012-11-26 Michael Brüning michael.brun...@digia.com
+
+[Qt] QStyleFacadeImp build break with latest Qt 5
+https://bugs.webkit.org/show_bug.cgi?id=103198
+
+Reviewed by Simon Hausmann.
+
+Original patch by J-P Nurmi jpnu...@digia.com.
+
+Fixes QtWebKit build by replacing qobject_cast to
+QMacStyle with calls to QObject::inherits. Also
+replaces Q_WS_MAC preprocesser directives with Q_OS_MAC
+for Qt 5 compatibility.
+
+* WebCoreSupport/QStyleFacadeImp.cpp:
+(WebKit::QStyleFacadeImp::getButtonMetrics):
+(WebKit::QStyleFacadeImp::paintComboBox):
+(WebKit::QStyleFacadeImp::paintInnerSpinButton):
+(WebKit::QStyleFacadeImp::paintScrollBar):
+
2012-11-24 Sheriff Bot webkit.review@gmail.com
Unreviewed, rolling out r135648 and r135649.
Modified: trunk/Source/WebKit/qt/WebCoreSupport/QStyleFacadeImp.cpp (135695 => 135696)
--- trunk/Source/WebKit/qt/WebCoreSupport/QStyleFacadeImp.cpp 2012-11-26 10:21:53 UTC (rev 135695)
+++ trunk/Source/WebKit/qt/WebCoreSupport/QStyleFacadeImp.cpp 2012-11-26 10:35:28 UTC (rev 135696)
@@ -27,7 +27,6 @@
#include QApplication
#include QLineEdit
-#include QMacStyle
#include QPainter
#include QPushButton
#include QStyleFactory
@@ -221,7 +220,7 @@
QFont defaultButtonFont = QApplication::font(button);
*buttonFontFamily = defaultButtonFont.family();
*buttonFontPixelSize = 0;
-#ifdef Q_WS_MAC
+#ifdef Q_OS_MAC
button.setAttribute(Qt::WA_MacSmallSize);
QFontInfo fontInfo(defaultButtonFont);
*buttonFontPixelSize = fontInfo.pixelSize();
@@ -275,11 +274,11 @@
IntRect rect = opt.rect;
-#if defined(Q_WS_MAC) !defined(QT_NO_STYLE_MAC)
+#if defined(Q_OS_MAC) !defined(QT_NO_STYLE_MAC)
// QMacStyle makes the combo boxes a little bit smaller to leave space for the focus rect.
// Because of it, the combo button is drawn at a point to the left of where it was expect to be and may end up
// overlapped with the text. This will force QMacStyle to draw the combo box with the expected width.
-if (qobject_castQMacStyle*(m_style))
+if (m_style-inherits(QMacStyle))
rect.inflateX(3);
#endif
@@ -359,11 +358,11 @@
// Default to moving the buttons a little bit within the editor frame.
int inflateX = -2;
int inflateY = -2;
-#if defined(Q_WS_MAC) !defined(QT_NO_STYLE_MAC)
+#if defined(Q_OS_MAC) !defined(QT_NO_STYLE_MAC)
// QMacStyle will position the aqua buttons flush to the right.
// This will move them more within the control for better style, a la
// Chromium look feel.
-if (qobject_castQMacStyle*(m_style)) {
+if (m_style-inherits(QMacStyle)) {
inflateX = -4;
// Render mini aqua spin buttons for QMacStyle to fit nicely into
// the editor area, like Chromium.
@@ -451,10 +450,10 @@
MappedStyleOptionQStyleOptionSlider opt(widget, proxyOption);
-#ifdef Q_WS_MAC
+#ifdef Q_OS_MAC
// FIXME: We also need to check the widget style but today ScrollbarTheme is not aware of the page so we
// can't get the widget.
-if (qobject_castQMacStyle*(m_style))
+if (m_style-inherits(QMacStyle))
m_style-drawComplexControl(QStyle::CC_ScrollBar, opt, painter, widget);
else
#endif
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [135697] trunk/Source/WebKit2
Title: [135697] trunk/Source/WebKit2
Revision 135697
Author commit-qu...@webkit.org
Date 2012-11-26 02:41:25 -0800 (Mon, 26 Nov 2012)
Log Message
REGRESSION(134142): ASSERT(!m_size.isZero()) hits in CoordinatedBackingStore::paintToTextureMapper().
https://bugs.webkit.org/show_bug.cgi?id=103217
Patch by Huang Dongsung luxte...@company100.net on 2012-11-26
Reviewed by Noam Rosenthal.
It is possible for CoordinatedBackingStore of directed composited image to not
have tiles, because CoordinatedImageBacking does not create tiles when the image
is invisible.
* UIProcess/CoordinatedGraphics/CoordinatedBackingStore.cpp:
(WebKit::CoordinatedBackingStore::paintToTextureMapper):
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/CoordinatedGraphics/CoordinatedBackingStore.cpp
Diff
Modified: trunk/Source/WebKit2/ChangeLog (135696 => 135697)
--- trunk/Source/WebKit2/ChangeLog 2012-11-26 10:35:28 UTC (rev 135696)
+++ trunk/Source/WebKit2/ChangeLog 2012-11-26 10:41:25 UTC (rev 135697)
@@ -1,3 +1,17 @@
+2012-11-26 Huang Dongsung luxte...@company100.net
+
+REGRESSION(134142): ASSERT(!m_size.isZero()) hits in CoordinatedBackingStore::paintToTextureMapper().
+https://bugs.webkit.org/show_bug.cgi?id=103217
+
+Reviewed by Noam Rosenthal.
+
+It is possible for CoordinatedBackingStore of directed composited image to not
+have tiles, because CoordinatedImageBacking does not create tiles when the image
+is invisible.
+
+* UIProcess/CoordinatedGraphics/CoordinatedBackingStore.cpp:
+(WebKit::CoordinatedBackingStore::paintToTextureMapper):
+
2012-11-25 Mikhail Pozdnyakov mikhail.pozdnya...@intel.com
[WK2] TiledBackingStore: page contents is scaled wrongly
Modified: trunk/Source/WebKit2/UIProcess/CoordinatedGraphics/CoordinatedBackingStore.cpp (135696 => 135697)
--- trunk/Source/WebKit2/UIProcess/CoordinatedGraphics/CoordinatedBackingStore.cpp 2012-11-26 10:35:28 UTC (rev 135696)
+++ trunk/Source/WebKit2/UIProcess/CoordinatedGraphics/CoordinatedBackingStore.cpp 2012-11-26 10:41:25 UTC (rev 135697)
@@ -140,6 +140,10 @@
void CoordinatedBackingStore::paintToTextureMapper(TextureMapper* textureMapper, const FloatRect targetRect, const TransformationMatrix transform, float opacity, BitmapTexture* mask)
{
+if (m_tiles.isEmpty())
+return;
+ASSERT(!m_size.isZero());
+
VectorTextureMapperTile* tilesToPaint;
VectorTextureMapperTile* previousTilesToPaint;
@@ -165,7 +169,6 @@
previousTilesToPaint.append(tile);
}
-ASSERT(!m_size.isZero());
FloatRect rectOnContents(FloatPoint::zero(), m_size);
TransformationMatrix adjustedTransform = transform;
// targetRect is on the contents coordinate system, so we must compare two rects on the contents coordinate system.
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [135699] trunk/Source/WebKit/blackberry
Title: [135699] trunk/Source/WebKit/blackberry
Revision 135699
Author jonathan.d...@torchmobile.com.cn
Date 2012-11-26 02:53:58 -0800 (Mon, 26 Nov 2012)
Log Message
[BlackBerry] Should not autofill username and password when there're more than one password inputs on the same page
https://bugs.webkit.org/show_bug.cgi?id=103104
Reviewed by Rob Buis.
RIM PR: 245334
Added the oldPassword detection back into the password input
detection logic, which was removed for simplicity when imported
those pieces of codes from Chromium. And we won't do autofill
when there're more than one password field detected.
Internally reviewed by Rob Buis.
* WebCoreSupport/CredentialTransformData.cpp:
(WebCore::CredentialTransformData::CredentialTransformData):
(WebCore::CredentialTransformData::findPasswordFormFields):
* WebCoreSupport/CredentialTransformData.h:
(CredentialTransformData):
* WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
(WebCore::FrameLoaderClientBlackBerry::dispatchWillSendSubmitEvent):
Modified Paths
trunk/Source/WebKit/blackberry/ChangeLog
trunk/Source/WebKit/blackberry/WebCoreSupport/CredentialTransformData.cpp
trunk/Source/WebKit/blackberry/WebCoreSupport/CredentialTransformData.h
trunk/Source/WebKit/blackberry/WebCoreSupport/FrameLoaderClientBlackBerry.cpp
Diff
Modified: trunk/Source/WebKit/blackberry/ChangeLog (135698 => 135699)
--- trunk/Source/WebKit/blackberry/ChangeLog 2012-11-26 10:46:59 UTC (rev 135698)
+++ trunk/Source/WebKit/blackberry/ChangeLog 2012-11-26 10:53:58 UTC (rev 135699)
@@ -1,3 +1,26 @@
+2012-11-26 Jonathan Dong jonathan.d...@torchmobile.com.cn
+
+[BlackBerry] Should not autofill username and password when there're more than one password inputs on the same page
+https://bugs.webkit.org/show_bug.cgi?id=103104
+
+Reviewed by Rob Buis.
+
+RIM PR: 245334
+Added the oldPassword detection back into the password input
+detection logic, which was removed for simplicity when imported
+those pieces of codes from Chromium. And we won't do autofill
+when there're more than one password field detected.
+
+Internally reviewed by Rob Buis.
+
+* WebCoreSupport/CredentialTransformData.cpp:
+(WebCore::CredentialTransformData::CredentialTransformData):
+(WebCore::CredentialTransformData::findPasswordFormFields):
+* WebCoreSupport/CredentialTransformData.h:
+(CredentialTransformData):
+* WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
+(WebCore::FrameLoaderClientBlackBerry::dispatchWillSendSubmitEvent):
+
2012-11-25 Jacky Jiang zhaji...@rim.com
[BlackBerry] Get rid of resetBitmapZoomScale()
Modified: trunk/Source/WebKit/blackberry/WebCoreSupport/CredentialTransformData.cpp (135698 => 135699)
--- trunk/Source/WebKit/blackberry/WebCoreSupport/CredentialTransformData.cpp 2012-11-26 10:46:59 UTC (rev 135698)
+++ trunk/Source/WebKit/blackberry/WebCoreSupport/CredentialTransformData.cpp 2012-11-26 10:53:58 UTC (rev 135699)
@@ -64,10 +64,10 @@
// Helper method to determine which password is the main one, and which is
// an old password (e.g on a make new password form), if any.
-bool locateSpecificPasswords(VectorHTMLInputElement* passwords,
- HTMLInputElement** password)
+bool locateSpecificPasswords(VectorHTMLInputElement* passwords, HTMLInputElement** password, HTMLInputElement** oldPassword)
{
ASSERT(password);
+ASSERT(oldPassword);
switch (passwords.size()) {
case 1:
@@ -80,6 +80,7 @@
*password = passwords[0];
else {
// Assume first is old password, second is new (no choice but to guess).
+*oldPassword = passwords[0];
*password = passwords[1];
}
break;
@@ -90,9 +91,12 @@
*password = passwords[0];
} else if (passwords[0]-value() == passwords[1]-value()) {
// Two the same and one different - old password is duplicated one.
+*oldPassword = passwords[0];
*password = passwords[2];
-} else if (passwords[1]-value() == passwords[2]-value())
+} else if (passwords[1]-value() == passwords[2]-value()) {
+*oldPassword = passwords[0];
*password = passwords[1];
+}
else {
// Three different passwords, or first and last match with middle
// different. No idea which is which, so no luck.
@@ -107,9 +111,10 @@
} // namespace
-CredentialTransformData::CredentialTransformData(HTMLFormElement* form)
+CredentialTransformData::CredentialTransformData(HTMLFormElement* form, bool isForSaving)
: m_userNameElement(0)
, m_passwordElement(0)
+, m_oldPasswordElement(0)
, m_isValid(false)
{
ASSERT(form);
@@ -128,6 +133,10 @@
if (!findPasswordFormFields(form))
return;
+// Won't restore password if there're two password inputs on the page.
+if
[webkit-changes] [135700] trunk/Source/WebKit/qt
Title: [135700] trunk/Source/WebKit/qt
Revision 135700
Author zeno.albis...@digia.com
Date 2012-11-26 03:00:03 -0800 (Mon, 26 Nov 2012)
Log Message
[Qt] Make sure the QGLWidget context is current when creating the TextureMapper.
https://bugs.webkit.org/show_bug.cgi?id=103142
When creating the TextureMapperGL for WK1 we have to make sure
that the GL context provided by the QGLWidget is current.
Otherwise the GraphicsContext3DQt created by TextureMapperGL will pick up
the wrong pointer by calling QOpenGLContext::currentContext().
Reviewed by Simon Hausmann.
* WebCoreSupport/PageClientQt.cpp:
(WebCore::PageClientQGraphicsWidget::setRootGraphicsLayer):
Modified Paths
trunk/Source/WebKit/qt/ChangeLog
trunk/Source/WebKit/qt/WebCoreSupport/PageClientQt.cpp
Diff
Modified: trunk/Source/WebKit/qt/ChangeLog (135699 => 135700)
--- trunk/Source/WebKit/qt/ChangeLog 2012-11-26 10:53:58 UTC (rev 135699)
+++ trunk/Source/WebKit/qt/ChangeLog 2012-11-26 11:00:03 UTC (rev 135700)
@@ -1,3 +1,18 @@
+2012-11-26 Zeno Albisser z...@webkit.org
+
+[Qt] Make sure the QGLWidget context is current when creating the TextureMapper.
+https://bugs.webkit.org/show_bug.cgi?id=103142
+
+When creating the TextureMapperGL for WK1 we have to make sure
+that the GL context provided by the QGLWidget is current.
+Otherwise the GraphicsContext3DQt created by TextureMapperGL will pick up
+the wrong pointer by calling QOpenGLContext::currentContext().
+
+Reviewed by Simon Hausmann.
+
+* WebCoreSupport/PageClientQt.cpp:
+(WebCore::PageClientQGraphicsWidget::setRootGraphicsLayer):
+
2012-11-26 Michael Brüning michael.brun...@digia.com
[Qt] QStyleFacadeImp build break with latest Qt 5
Modified: trunk/Source/WebKit/qt/WebCoreSupport/PageClientQt.cpp (135699 => 135700)
--- trunk/Source/WebKit/qt/WebCoreSupport/PageClientQt.cpp 2012-11-26 10:53:58 UTC (rev 135699)
+++ trunk/Source/WebKit/qt/WebCoreSupport/PageClientQt.cpp 2012-11-26 11:00:03 UTC (rev 135700)
@@ -282,11 +282,16 @@
{
if (layer) {
TextureMapperLayerClient = adoptPtr(new TextureMapperLayerClientQt(page-mainFrame(), layer));
-#if USE(TEXTURE_MAPPER_GL)
+#if USE(TEXTURE_MAPPER_GL) defined(QT_OPENGL_LIB)
QGraphicsView* graphicsView = view-scene()-views()[0];
-if (graphicsView graphicsView-viewport() graphicsView-viewport()-inherits(QGLWidget)) {
-TextureMapperLayerClient-setTextureMapper(TextureMapper::create(TextureMapper::OpenGLMode));
-return;
+if (graphicsView graphicsView-viewport()) {
+QGLWidget* glWidget = qobject_castQGLWidget*(graphicsView-viewport());
+if (glWidget) {
+// The GL context belonging to the QGLWidget viewport must be current when TextureMapper is being created.
+glWidget-makeCurrent();
+TextureMapperLayerClient-setTextureMapper(TextureMapper::create(TextureMapper::OpenGLMode));
+return;
+}
}
#endif
TextureMapperLayerClient-setTextureMapper(TextureMapper::create());
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [135701] trunk
Title: [135701] trunk
Revision 135701
Author hausm...@webkit.org
Date 2012-11-26 03:06:55 -0800 (Mon, 26 Nov 2012)
Log Message
[Qt] REGRESSION(r135575): It made all tests assert
https://bugs.webkit.org/show_bug.cgi?id=103169
Patch by Pierre Rossi pierre.ro...@gmail.com on 2012-11-26
Reviewed by Simon Hausmann.
This fixes another regression introduced in r135515:
initializeWebKitQt shouldn't implicitely call initializeWebCoreQt
since it can be called from WebKit2 to initialize QStyle for testing.
This would then lead to things such as PlatformStrategies being
initialized twice.
Source/WebKit/qt:
* Api/qwebpage.cpp: Explicitely call initializeWebCoreQt().
(QWebPagePrivate::QWebPagePrivate):
* WebCoreSupport/InitWebCoreQt.cpp:
(WebKit::initializeWebKitQt):
(WebCore::initializeWebCoreQt):
* WebCoreSupport/InitWebCoreQt.h:
(WebCore):
Source/WebKit2:
* qt/MainQt.cpp: No need to initialize anything if we're not using QStyle.
(WebKit):
(main):
Tools:
* DumpRenderTree/qt/DumpRenderTreeQt.cpp: Also propagate the change to DRT this time.
(WebCore::DumpRenderTree::DumpRenderTree):
Modified Paths
trunk/Source/WebKit/qt/Api/qwebpage.cpp
trunk/Source/WebKit/qt/ChangeLog
trunk/Source/WebKit/qt/WebCoreSupport/InitWebCoreQt.cpp
trunk/Source/WebKit/qt/WebCoreSupport/InitWebCoreQt.h
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/qt/MainQt.cpp
trunk/Tools/ChangeLog
trunk/Tools/DumpRenderTree/qt/DumpRenderTreeQt.cpp
Diff
Modified: trunk/Source/WebKit/qt/Api/qwebpage.cpp (135700 => 135701)
--- trunk/Source/WebKit/qt/Api/qwebpage.cpp 2012-11-26 11:00:03 UTC (rev 135700)
+++ trunk/Source/WebKit/qt/Api/qwebpage.cpp 2012-11-26 11:06:55 UTC (rev 135701)
@@ -68,6 +68,7 @@
#include HTMLNames.h
#include HitTestResult.h
#include Image.h
+#include InitWebCoreQt.h
#include InitWebKitQt.h
#include InspectorClientQt.h
#include InspectorClientWebPage.h
@@ -325,6 +326,7 @@
#endif
WebKit::initializeWebKitWidgets();
+WebCore::initializeWebCoreQt();
Page::PageClients pageClients;
pageClients.chromeClient = new ChromeClientQt(this);
Modified: trunk/Source/WebKit/qt/ChangeLog (135700 => 135701)
--- trunk/Source/WebKit/qt/ChangeLog 2012-11-26 11:00:03 UTC (rev 135700)
+++ trunk/Source/WebKit/qt/ChangeLog 2012-11-26 11:06:55 UTC (rev 135701)
@@ -1,3 +1,24 @@
+2012-11-26 Pierre Rossi pierre.ro...@gmail.com
+
+[Qt] REGRESSION(r135575): It made all tests assert
+https://bugs.webkit.org/show_bug.cgi?id=103169
+
+Reviewed by Simon Hausmann.
+
+This fixes another regression introduced in r135515:
+initializeWebKitQt shouldn't implicitely call initializeWebCoreQt
+since it can be called from WebKit2 to initialize QStyle for testing.
+This would then lead to things such as PlatformStrategies being
+initialized twice.
+
+* Api/qwebpage.cpp: Explicitely call initializeWebCoreQt().
+(QWebPagePrivate::QWebPagePrivate):
+* WebCoreSupport/InitWebCoreQt.cpp:
+(WebKit::initializeWebKitQt):
+(WebCore::initializeWebCoreQt):
+* WebCoreSupport/InitWebCoreQt.h:
+(WebCore):
+
2012-11-26 Zeno Albisser z...@webkit.org
[Qt] Make sure the QGLWidget context is current when creating the TextureMapper.
Modified: trunk/Source/WebKit/qt/WebCoreSupport/InitWebCoreQt.cpp (135700 => 135701)
--- trunk/Source/WebKit/qt/WebCoreSupport/InitWebCoreQt.cpp 2012-11-26 11:00:03 UTC (rev 135700)
+++ trunk/Source/WebKit/qt/WebCoreSupport/InitWebCoreQt.cpp 2012-11-26 11:06:55 UTC (rev 135701)
@@ -62,8 +62,6 @@
WebCore::RenderThemeQStyle::setStyleFactoryFunction(initCallback);
WebCore::RenderThemeQt::setCustomTheme(WebCore::RenderThemeQStyle::create, new WebCore::ScrollbarThemeQStyle);
}
-
-WebCore::initializeWebCoreQt();
}
Q_DECL_EXPORT void setImagePlatformResource(const char* name, const QPixmap pixmap)
@@ -75,7 +73,7 @@
namespace WebCore {
-void initializeWebCoreQt()
+Q_DECL_EXPORT void initializeWebCoreQt()
{
static bool initialized = false;
if (initialized)
Modified: trunk/Source/WebKit/qt/WebCoreSupport/InitWebCoreQt.h (135700 => 135701)
--- trunk/Source/WebKit/qt/WebCoreSupport/InitWebCoreQt.h 2012-11-26 11:00:03 UTC (rev 135700)
+++ trunk/Source/WebKit/qt/WebCoreSupport/InitWebCoreQt.h 2012-11-26 11:06:55 UTC (rev 135701)
@@ -48,7 +48,7 @@
namespace WebCore {
-void initializeWebCoreQt();
+Q_DECL_EXPORT void initializeWebCoreQt();
}
Modified: trunk/Source/WebKit2/ChangeLog (135700 => 135701)
--- trunk/Source/WebKit2/ChangeLog 2012-11-26 11:00:03 UTC (rev 135700)
+++ trunk/Source/WebKit2/ChangeLog 2012-11-26 11:06:55 UTC (rev 135701)
@@ -1,3 +1,20 @@
+2012-11-26 Pierre Rossi pierre.ro...@gmail.com
+
+[Qt] REGRESSION(r135575): It made all tests assert
+https://bugs.webkit.org/show_bug.cgi?id=103169
+
+Reviewed by Simon Hausmann.
+
+This fixes another regression introduced in r135515:
+
[webkit-changes] [135702] trunk
Title: [135702] trunk
Revision 135702
Author commit-qu...@webkit.org
Date 2012-11-26 03:16:09 -0800 (Mon, 26 Nov 2012)
Log Message
Text Autosizing: Add Text Autosizing APIs for WK2
https://bugs.webkit.org/show_bug.cgi?id=100633
Patch by Jaehun Lim ljaehun@samsung.com on 2012-11-26
Reviewed by Sam Weinig.
Source/WebKit2:
Implement basic Text Autosizing APIs for WK2.
Text Autosizing is a useful feature for mobile browsers. It adjusts the font size
of text in wide columns, and makes text more legible.
This patch adds setting APIs for Text Autosizing in WK2.
* Shared/WebPreferencesStore.h:
(WebKit):
* UIProcess/API/C/WKPreferences.cpp:
(WKPreferencesSetTextAutosizingEnabled):
(WKPreferencesGetTextAutosizingEnabled):
* UIProcess/API/C/WKPreferences.h:
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updatePreferences):
Tools:
Add test cases for Text Autosizing in WKPreferences.
* TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
(TestWebKitAPI::TEST):
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/Shared/WebPreferencesStore.h
trunk/Source/WebKit2/UIProcess/API/C/WKPreferences.cpp
trunk/Source/WebKit2/UIProcess/API/C/WKPreferences.h
trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp
Diff
Modified: trunk/Source/WebKit2/ChangeLog (135701 => 135702)
--- trunk/Source/WebKit2/ChangeLog 2012-11-26 11:06:55 UTC (rev 135701)
+++ trunk/Source/WebKit2/ChangeLog 2012-11-26 11:16:09 UTC (rev 135702)
@@ -1,3 +1,24 @@
+2012-11-26 Jaehun Lim ljaehun@samsung.com
+
+Text Autosizing: Add Text Autosizing APIs for WK2
+https://bugs.webkit.org/show_bug.cgi?id=100633
+
+Reviewed by Sam Weinig.
+
+Implement basic Text Autosizing APIs for WK2.
+Text Autosizing is a useful feature for mobile browsers. It adjusts the font size
+of text in wide columns, and makes text more legible.
+This patch adds setting APIs for Text Autosizing in WK2.
+
+* Shared/WebPreferencesStore.h:
+(WebKit):
+* UIProcess/API/C/WKPreferences.cpp:
+(WKPreferencesSetTextAutosizingEnabled):
+(WKPreferencesGetTextAutosizingEnabled):
+* UIProcess/API/C/WKPreferences.h:
+* WebProcess/WebPage/WebPage.cpp:
+(WebKit::WebPage::updatePreferences):
+
2012-11-26 Pierre Rossi pierre.ro...@gmail.com
[Qt] REGRESSION(r135575): It made all tests assert
Modified: trunk/Source/WebKit2/Shared/WebPreferencesStore.h (135701 => 135702)
--- trunk/Source/WebKit2/Shared/WebPreferencesStore.h 2012-11-26 11:06:55 UTC (rev 135701)
+++ trunk/Source/WebKit2/Shared/WebPreferencesStore.h 2012-11-26 11:16:09 UTC (rev 135702)
@@ -139,6 +139,7 @@
macro(PlugInSnapshottingEnabled, plugInSnapshottingEnabled, Bool, bool, false) \
macro(PDFPluginEnabled, pdfPluginEnabled, Bool, bool, false) \
macro(UsesEncodingDetector, usesEncodingDetector, Bool, bool, false) \
+macro(TextAutosizingEnabled, textAutosizingEnabled, Bool, bool, false) \
\
#define FOR_EACH_WEBKIT_DOUBLE_PREFERENCE(macro) \
Modified: trunk/Source/WebKit2/UIProcess/API/C/WKPreferences.cpp (135701 => 135702)
--- trunk/Source/WebKit2/UIProcess/API/C/WKPreferences.cpp 2012-11-26 11:06:55 UTC (rev 135701)
+++ trunk/Source/WebKit2/UIProcess/API/C/WKPreferences.cpp 2012-11-26 11:16:09 UTC (rev 135702)
@@ -953,3 +953,14 @@
{
return toImpl(preferencesRef)-usesEncodingDetector();
}
+
+void WKPreferencesSetTextAutosizingEnabled(WKPreferencesRef preferencesRef, bool textAutosizingEnabled)
+{
+toImpl(preferencesRef)-setTextAutosizingEnabled(textAutosizingEnabled);
+}
+
+bool WKPreferencesGetTextAutosizingEnabled(WKPreferencesRef preferencesRef)
+{
+return toImpl(preferencesRef)-textAutosizingEnabled();
+}
+
Modified: trunk/Source/WebKit2/UIProcess/API/C/WKPreferences.h (135701 => 135702)
--- trunk/Source/WebKit2/UIProcess/API/C/WKPreferences.h 2012-11-26 11:06:55 UTC (rev 135701)
+++ trunk/Source/WebKit2/UIProcess/API/C/WKPreferences.h 2012-11-26 11:16:09 UTC (rev 135702)
@@ -224,6 +224,10 @@
WK_EXPORT void WKPreferencesSetEncodingDetectorEnabled(WKPreferencesRef preferencesRef, bool enabled);
WK_EXPORT bool WKPreferencesGetEncodingDetectorEnabled(WKPreferencesRef preferencesRef);
+// Defaults to false.
+WK_EXPORT void WKPreferencesSetTextAutosizingEnabled(WKPreferencesRef preferences, bool textAutosizingEnabled);
+WK_EXPORT bool WKPreferencesGetTextAutosizingEnabled(WKPreferencesRef preferences);
+
#ifdef __cplusplus
}
#endif
Modified: trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp (135701 => 135702)
--- trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp 2012-11-26 11:06:55 UTC (rev 135701)
+++ trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp 2012-11-26 11:16:09 UTC (rev 135702)
@@ -2293,6 +2293,10 @@
settings-setPlugInSnapshottingEnabled(store.getBoolValueForKey(WebPreferencesKey::plugInSnapshottingEnabledKey()));
[webkit-changes] [135703] trunk/Source/WebCore
Title: [135703] trunk/Source/WebCore
Revision 135703
Author hara...@chromium.org
Date 2012-11-26 03:20:49 -0800 (Mon, 26 Nov 2012)
Log Message
[V8] Remove WorkerContextExecutionProxy
https://bugs.webkit.org/show_bug.cgi?id=103210
Reviewed by Adam Barth.
This patch moves all methods in WorkerContextExecutionProxy
to WorkerScriptController.
Due to the dependency between WorkerContextExecutionProxy's methods,
it is a bit difficult to split this patch into pieces.
This patch simply moves methods without changing their logic.
Also this patch doesn't remove empty WorkerContextExecutionProxy.{h,cpp}
to keep the diff sane. I will address these issues in a follow-up patch.
Tests: fast/worker/*
* bindings/v8/ScriptState.cpp:
(WebCore::scriptStateFromWorkerContext):
* bindings/v8/V8Binding.cpp:
(WebCore::toV8Context):
* bindings/v8/V8WorkerContextEventListener.cpp:
(WebCore::V8WorkerContextEventListener::handleEvent):
* bindings/v8/WorkerContextExecutionProxy.cpp:
* bindings/v8/WorkerContextExecutionProxy.h:
* bindings/v8/WorkerScriptController.cpp:
(WebCore::WorkerScriptController::WorkerScriptController):
(WebCore::WorkerScriptController::~WorkerScriptController):
(WebCore::WorkerScriptController::dispose):
(WebCore):
(WebCore::WorkerScriptController::initializeIfNeeded):
(WebCore::WorkerScriptController::evaluate):
(WebCore::WorkerScriptController::setEvalAllowed):
(WebCore::WorkerScriptController::disableEval):
* bindings/v8/WorkerScriptController.h:
(WebCore):
(WebCore::WorkerContextExecutionState::WorkerContextExecutionState):
(WorkerContextExecutionState):
(WorkerScriptController):
(WebCore::WorkerScriptController::context):
* bindings/v8/WorkerScriptDebugServer.cpp:
(WebCore::WorkerScriptDebugServer::addListener):
* bindings/v8/custom/V8WorkerContextCustom.cpp:
(WebCore::SetTimeoutOrInterval):
(WebCore::toV8):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/v8/ScriptState.cpp
trunk/Source/WebCore/bindings/v8/V8Binding.cpp
trunk/Source/WebCore/bindings/v8/V8WorkerContextEventListener.cpp
trunk/Source/WebCore/bindings/v8/WorkerContextExecutionProxy.cpp
trunk/Source/WebCore/bindings/v8/WorkerContextExecutionProxy.h
trunk/Source/WebCore/bindings/v8/WorkerScriptController.cpp
trunk/Source/WebCore/bindings/v8/WorkerScriptController.h
trunk/Source/WebCore/bindings/v8/WorkerScriptDebugServer.cpp
trunk/Source/WebCore/bindings/v8/custom/V8WorkerContextCustom.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (135702 => 135703)
--- trunk/Source/WebCore/ChangeLog 2012-11-26 11:16:09 UTC (rev 135702)
+++ trunk/Source/WebCore/ChangeLog 2012-11-26 11:20:49 UTC (rev 135703)
@@ -1,3 +1,50 @@
+2012-11-26 Kentaro Hara hara...@chromium.org
+
+[V8] Remove WorkerContextExecutionProxy
+https://bugs.webkit.org/show_bug.cgi?id=103210
+
+Reviewed by Adam Barth.
+
+This patch moves all methods in WorkerContextExecutionProxy
+to WorkerScriptController.
+
+Due to the dependency between WorkerContextExecutionProxy's methods,
+it is a bit difficult to split this patch into pieces.
+This patch simply moves methods without changing their logic.
+Also this patch doesn't remove empty WorkerContextExecutionProxy.{h,cpp}
+to keep the diff sane. I will address these issues in a follow-up patch.
+
+Tests: fast/worker/*
+
+* bindings/v8/ScriptState.cpp:
+(WebCore::scriptStateFromWorkerContext):
+* bindings/v8/V8Binding.cpp:
+(WebCore::toV8Context):
+* bindings/v8/V8WorkerContextEventListener.cpp:
+(WebCore::V8WorkerContextEventListener::handleEvent):
+* bindings/v8/WorkerContextExecutionProxy.cpp:
+* bindings/v8/WorkerContextExecutionProxy.h:
+* bindings/v8/WorkerScriptController.cpp:
+(WebCore::WorkerScriptController::WorkerScriptController):
+(WebCore::WorkerScriptController::~WorkerScriptController):
+(WebCore::WorkerScriptController::dispose):
+(WebCore):
+(WebCore::WorkerScriptController::initializeIfNeeded):
+(WebCore::WorkerScriptController::evaluate):
+(WebCore::WorkerScriptController::setEvalAllowed):
+(WebCore::WorkerScriptController::disableEval):
+* bindings/v8/WorkerScriptController.h:
+(WebCore):
+(WebCore::WorkerContextExecutionState::WorkerContextExecutionState):
+(WorkerContextExecutionState):
+(WorkerScriptController):
+(WebCore::WorkerScriptController::context):
+* bindings/v8/WorkerScriptDebugServer.cpp:
+(WebCore::WorkerScriptDebugServer::addListener):
+* bindings/v8/custom/V8WorkerContextCustom.cpp:
+(WebCore::SetTimeoutOrInterval):
+(WebCore::toV8):
+
2012-11-26 Hajime Morrita morr...@google.com
[Refactoring] Some Node::isDescendant calls can be replaced with Node::contains()
Modified: trunk/Source/WebCore/bindings/v8/ScriptState.cpp (135702 => 135703)
[webkit-changes] [135704] trunk/LayoutTests
Title: [135704] trunk/LayoutTests
Revision 135704
Author kei...@webkit.org
Date 2012-11-26 03:44:56 -0800 (Mon, 26 Nov 2012)
Log Message
Layout Test platform/chromium/fast/forms/calendar-picker/week-picker-key-operations.html is failing
https://bugs.webkit.org/show_bug.cgi?id=103225
Unreviewed.
* platform/chromium/TestExpectations:
* platform/chromium/fast/forms/calendar-picker/week-picker-key-operations.html: Remove current month check because it was flaky.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/TestExpectations
trunk/LayoutTests/platform/chromium/fast/forms/calendar-picker/week-picker-key-operations.html
Diff
Modified: trunk/LayoutTests/ChangeLog (135703 => 135704)
--- trunk/LayoutTests/ChangeLog 2012-11-26 11:20:49 UTC (rev 135703)
+++ trunk/LayoutTests/ChangeLog 2012-11-26 11:44:56 UTC (rev 135704)
@@ -1,3 +1,13 @@
+2012-11-26 Keishi Hattori kei...@webkit.org
+
+Layout Test platform/chromium/fast/forms/calendar-picker/week-picker-key-operations.html is failing
+https://bugs.webkit.org/show_bug.cgi?id=103225
+
+Unreviewed.
+
+* platform/chromium/TestExpectations:
+* platform/chromium/fast/forms/calendar-picker/week-picker-key-operations.html: Remove current month check because it was flaky.
+
2012-11-26 János Badics jbad...@inf.u-szeged.hu
[Qt] Gardening after r135629. Skipped a newly added but failing test.
Modified: trunk/LayoutTests/platform/chromium/TestExpectations (135703 => 135704)
--- trunk/LayoutTests/platform/chromium/TestExpectations 2012-11-26 11:20:49 UTC (rev 135703)
+++ trunk/LayoutTests/platform/chromium/TestExpectations 2012-11-26 11:44:56 UTC (rev 135704)
@@ -4252,6 +4252,3 @@
webkit.org/b/103148 [ Linux Win Mac ] svg/batik/text/textPosition2.svg [ ImageOnlyFailure ]
webkit.org/b/103181 [ Win7 ] http/tests/local/drag-over-remote-content.html [ Pass Crash Timeout ]
webkit.org/b/103183 [ Win7 SnowLeopard ] media/video-seek-past-end-playing.html [ Pass Crash ]
-
-# This test results are date-dependent, see bug.
-webkit.org/b/103225 platform/chromium/fast/forms/calendar-picker/week-picker-key-operations.html [ Pass Failure ]
Modified: trunk/LayoutTests/platform/chromium/fast/forms/calendar-picker/week-picker-key-operations.html (135703 => 135704)
--- trunk/LayoutTests/platform/chromium/fast/forms/calendar-picker/week-picker-key-operations.html 2012-11-26 11:20:49 UTC (rev 135703)
+++ trunk/LayoutTests/platform/chromium/fast/forms/calendar-picker/week-picker-key-operations.html 2012-11-26 11:44:56 UTC (rev 135704)
@@ -128,9 +128,8 @@
function testToday() {
eventSender.keyDown('t');
var now = new Date();
-var expectedMonth = new popupWindow.Month(now.getFullYear(), now.getMonth()).toString();
var expectedWeek = popupWindow.Week.createFromToday().toString();
-return selectedWeek() === expectedWeek currentMonth() === expectedMonth;
+return selectedWeek() === expectedWeek;
}
function focusedElement() {
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [135705] trunk/Source/WebCore
Title: [135705] trunk/Source/WebCore
Revision 135705
Author commit-qu...@webkit.org
Date 2012-11-26 04:10:28 -0800 (Mon, 26 Nov 2012)
Log Message
[GStreamer] Floating reference handling fix
https://bugs.webkit.org/show_bug.cgi?id=101349
Patch by Thiago Santos thiago.sousa.san...@collabora.com on 2012-11-26
Reviewed by Philippe Normand.
GStreamer 0.10 and 1.0 differ when creating GstGhostPad from pad
templates, the 1.0 doesn't take ownership on the passed
GstPadTemplate, while 0.10 does. So this patch adds a
GStreamerVersioning function to handle this different approach
transparently in Webkit gstreamer elements.
Existing media tests cover this change.
* platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp:
(webkit_web_audio_src_init):
* platform/graphics/gstreamer/GStreamerVersioning.cpp:
(webkitGstGhostPadFromStaticTemplate):
* platform/graphics/gstreamer/GStreamerVersioning.h:
* platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
(webkit_web_src_init):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp
trunk/Source/WebCore/platform/graphics/gstreamer/GStreamerVersioning.cpp
trunk/Source/WebCore/platform/graphics/gstreamer/GStreamerVersioning.h
trunk/Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (135704 => 135705)
--- trunk/Source/WebCore/ChangeLog 2012-11-26 11:44:56 UTC (rev 135704)
+++ trunk/Source/WebCore/ChangeLog 2012-11-26 12:10:28 UTC (rev 135705)
@@ -1,3 +1,26 @@
+2012-11-26 Thiago Santos thiago.sousa.san...@collabora.com
+
+[GStreamer] Floating reference handling fix
+https://bugs.webkit.org/show_bug.cgi?id=101349
+
+Reviewed by Philippe Normand.
+
+GStreamer 0.10 and 1.0 differ when creating GstGhostPad from pad
+templates, the 1.0 doesn't take ownership on the passed
+GstPadTemplate, while 0.10 does. So this patch adds a
+GStreamerVersioning function to handle this different approach
+transparently in Webkit gstreamer elements.
+
+Existing media tests cover this change.
+
+* platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp:
+(webkit_web_audio_src_init):
+* platform/graphics/gstreamer/GStreamerVersioning.cpp:
+(webkitGstGhostPadFromStaticTemplate):
+* platform/graphics/gstreamer/GStreamerVersioning.h:
+* platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
+(webkit_web_src_init):
+
2012-11-26 Kentaro Hara hara...@chromium.org
[V8] Remove WorkerContextExecutionProxy
Modified: trunk/Source/WebCore/platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp (135704 => 135705)
--- trunk/Source/WebCore/platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp 2012-11-26 11:44:56 UTC (rev 135704)
+++ trunk/Source/WebCore/platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp 2012-11-26 12:10:28 UTC (rev 135705)
@@ -26,6 +26,7 @@
#include AudioIOCallback.h
#include wtf/gobject/GOwnPtr.h
#include GRefPtrGStreamer.h
+#include GStreamerVersioning.h
#include gst/audio/multichannel.h
#include gst/pbutils/pbutils.h
@@ -178,8 +179,7 @@
src-priv = priv;
new (priv) WebKitWebAudioSourcePrivate();
-GRefPtrGstPadTemplate padTemplate = adoptGRef(gst_static_pad_template_get(srcTemplate));
-priv-sourcePad = gst_ghost_pad_new_no_target_from_template(src, padTemplate.get());
+priv-sourcePad = webkitGstGhostPadFromStaticTemplate(srcTemplate, src, 0);
gst_element_add_pad(GST_ELEMENT(src), priv-sourcePad);
priv-provider = 0;
Modified: trunk/Source/WebCore/platform/graphics/gstreamer/GStreamerVersioning.cpp (135704 => 135705)
--- trunk/Source/WebCore/platform/graphics/gstreamer/GStreamerVersioning.cpp 2012-11-26 11:44:56 UTC (rev 135704)
+++ trunk/Source/WebCore/platform/graphics/gstreamer/GStreamerVersioning.cpp 2012-11-26 12:10:28 UTC (rev 135705)
@@ -34,6 +34,23 @@
#endif
}
+GstPad* webkitGstGhostPadFromStaticTemplate(GstStaticPadTemplate* staticPadTemplate, const gchar* name, GstPad* target)
+{
+GstPad* pad;
+GstPadTemplate* padTemplate = gst_static_pad_template_get(staticPadTemplate);
+
+if (target)
+pad = gst_ghost_pad_new_from_template(name, target, padTemplate);
+else
+pad = gst_ghost_pad_new_no_target_from_template(name, padTemplate);
+
+#ifdef GST_API_VERSION_1
+gst_object_unref(padTemplate);
+#endif
+
+return pad;
+}
+
GRefPtrGstCaps webkitGstGetPadCaps(GstPad* pad)
{
if (!pad)
Modified: trunk/Source/WebCore/platform/graphics/gstreamer/GStreamerVersioning.h (135704 => 135705)
--- trunk/Source/WebCore/platform/graphics/gstreamer/GStreamerVersioning.h 2012-11-26 11:44:56 UTC (rev 135704)
+++ trunk/Source/WebCore/platform/graphics/gstreamer/GStreamerVersioning.h 2012-11-26 12:10:28 UTC (rev 135705)
@@ -29,6 +29,7 @@
};
void webkitGstObjectRefSink(GstObject*);
+GstPad*
[webkit-changes] [135706] trunk/Source/WebCore
Title: [135706] trunk/Source/WebCore Revision 135706 Author zeno.albis...@digia.com Date 2012-11-26 04:32:15 -0800 (Mon, 26 Nov 2012) Log Message GraphicsSurface should only store its size in a single place. https://bugs.webkit.org/show_bug.cgi?id=103143 Reviewed by Kenneth Rohde Christiansen. * platform/graphics/qt/GraphicsContext3DQt.cpp: (WebCore::GraphicsContext3DPrivate::GraphicsContext3DPrivate): Cosmetics only. * platform/graphics/surfaces/GraphicsSurface.cpp: (WebCore::GraphicsSurface::size): Return the size as received from the platform abstraction. (WebCore): (WebCore::GraphicsSurface::GraphicsSurface): * platform/graphics/surfaces/GraphicsSurface.h: (GraphicsSurface): Remove data member m_size. * platform/graphics/surfaces/mac/GraphicsSurfaceMac.cpp: (WebCore::GraphicsSurfacePrivate::GraphicsSurfacePrivate): Always take the size of the GraphicsSurface as an argument. (WebCore::GraphicsSurfacePrivate::size): (GraphicsSurfacePrivate): (WebCore::GraphicsSurface::platformPaintToTextureMapper): Retrieve the size from GraphicsSurfacePrivate where necessary. (WebCore::GraphicsSurface::platformSize): (WebCore): (WebCore::GraphicsSurface::platformImport): * platform/graphics/surfaces/qt/GraphicsSurfaceGLX.cpp: (WebCore::GraphicsSurfacePrivate::GraphicsSurfacePrivate): Add a constructor that takes a window id as an argument for the receiving side of the GraphcisSurface. The GraphicsSurface can then determine its dimensions from the provided XWindow. (WebCore::GraphicsSurfacePrivate::createPixmap): (WebCore::GraphicsSurfacePrivate::size): Query the size of the GraphicsSurface backing from X. (WebCore::GraphicsSurface::platformPaintToTextureMapper): Retrieve the size from GraphicsSurfacePrivate where necessary. (WebCore::GraphicsSurface::platformSize): (WebCore): (WebCore::GraphicsSurface::platformImport): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/platform/graphics/qt/GraphicsContext3DQt.cpp trunk/Source/WebCore/platform/graphics/surfaces/GraphicsSurface.cpp trunk/Source/WebCore/platform/graphics/surfaces/GraphicsSurface.h trunk/Source/WebCore/platform/graphics/surfaces/mac/GraphicsSurfaceMac.cpp trunk/Source/WebCore/platform/graphics/surfaces/qt/GraphicsSurfaceGLX.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (135705 => 135706) --- trunk/Source/WebCore/ChangeLog 2012-11-26 12:10:28 UTC (rev 135705) +++ trunk/Source/WebCore/ChangeLog 2012-11-26 12:32:15 UTC (rev 135706) @@ -1,3 +1,46 @@ +2012-11-26 Zeno Albisser z...@webkit.org + +GraphicsSurface should only store its size in a single place. +https://bugs.webkit.org/show_bug.cgi?id=103143 + +Reviewed by Kenneth Rohde Christiansen. + +* platform/graphics/qt/GraphicsContext3DQt.cpp: +(WebCore::GraphicsContext3DPrivate::GraphicsContext3DPrivate): +Cosmetics only. +* platform/graphics/surfaces/GraphicsSurface.cpp: +(WebCore::GraphicsSurface::size): +Return the size as received from the platform abstraction. +(WebCore): +(WebCore::GraphicsSurface::GraphicsSurface): +* platform/graphics/surfaces/GraphicsSurface.h: +(GraphicsSurface): +Remove data member m_size. +* platform/graphics/surfaces/mac/GraphicsSurfaceMac.cpp: +(WebCore::GraphicsSurfacePrivate::GraphicsSurfacePrivate): +Always take the size of the GraphicsSurface as an argument. +(WebCore::GraphicsSurfacePrivate::size): +(GraphicsSurfacePrivate): +(WebCore::GraphicsSurface::platformPaintToTextureMapper): +Retrieve the size from GraphicsSurfacePrivate where necessary. +(WebCore::GraphicsSurface::platformSize): +(WebCore): +(WebCore::GraphicsSurface::platformImport): +* platform/graphics/surfaces/qt/GraphicsSurfaceGLX.cpp: +(WebCore::GraphicsSurfacePrivate::GraphicsSurfacePrivate): +Add a constructor that takes a window id as an argument +for the receiving side of the GraphcisSurface. +The GraphicsSurface can then determine its dimensions +from the provided XWindow. +(WebCore::GraphicsSurfacePrivate::createPixmap): +(WebCore::GraphicsSurfacePrivate::size): +Query the size of the GraphicsSurface backing from X. +(WebCore::GraphicsSurface::platformPaintToTextureMapper): +Retrieve the size from GraphicsSurfacePrivate where necessary. +(WebCore::GraphicsSurface::platformSize): +(WebCore): +(WebCore::GraphicsSurface::platformImport): + 2012-11-26 Thiago Santos thiago.sousa.san...@collabora.com [GStreamer] Floating reference handling fix Modified: trunk/Source/WebCore/platform/graphics/qt/GraphicsContext3DQt.cpp (135705 => 135706) --- trunk/Source/WebCore/platform/graphics/qt/GraphicsContext3DQt.cpp 2012-11-26 12:10:28 UTC (rev 135705) +++
[webkit-changes] [135707] trunk/LayoutTests
Title: [135707] trunk/LayoutTests Revision 135707 Author commit-qu...@webkit.org Date 2012-11-26 04:40:40 -0800 (Mon, 26 Nov 2012) Log Message [EFL] Gardening: update test expectations https://bugs.webkit.org/show_bug.cgi?id=103119 Unreviewed gardening. timeline-timer-fired-from-eval-call-site-expected.html is passing now, other changes are just marking tests as flaky based on the flakiness dashboard. Patch by Jussi Kukkonen jussi.kukko...@intel.com on 2012-11-26 * platform/efl-wk1/TestExpectations: * platform/efl-wk2/TestExpectations: * platform/efl/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/efl/TestExpectations trunk/LayoutTests/platform/efl-wk1/TestExpectations trunk/LayoutTests/platform/efl-wk2/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (135706 => 135707) --- trunk/LayoutTests/ChangeLog 2012-11-26 12:32:15 UTC (rev 135706) +++ trunk/LayoutTests/ChangeLog 2012-11-26 12:40:40 UTC (rev 135707) @@ -1,3 +1,16 @@ +2012-11-26 Jussi Kukkonen jussi.kukko...@intel.com + +[EFL] Gardening: update test expectations +https://bugs.webkit.org/show_bug.cgi?id=103119 + +Unreviewed gardening. timeline-timer-fired-from-eval-call-site-expected.html +is passing now, other changes are just marking tests as flaky based on +the flakiness dashboard. + +* platform/efl-wk1/TestExpectations: +* platform/efl-wk2/TestExpectations: +* platform/efl/TestExpectations: + 2012-11-26 Keishi Hattori kei...@webkit.org Layout Test platform/chromium/fast/forms/calendar-picker/week-picker-key-operations.html is failing Modified: trunk/LayoutTests/platform/efl/TestExpectations (135706 => 135707) --- trunk/LayoutTests/platform/efl/TestExpectations 2012-11-26 12:32:15 UTC (rev 135706) +++ trunk/LayoutTests/platform/efl/TestExpectations 2012-11-26 12:40:40 UTC (rev 135707) @@ -1679,7 +1679,6 @@ webkit.org/b/102100 svg/repaint/inner-svg-change-viewBox.svg [ ImageOnlyFailure ] webkit.org/b/102190 compositing/overflow/updating-scrolling-content.html [ Failure ] -webkit.org/b/102190 fast/events/overflow-scroll-fake-mouse-move.html [ Failure ] webkit.org/b/102364 compositing/overflow/scrolling-without-painting.html [ Failure ] Modified: trunk/LayoutTests/platform/efl-wk1/TestExpectations (135706 => 135707) --- trunk/LayoutTests/platform/efl-wk1/TestExpectations 2012-11-26 12:32:15 UTC (rev 135706) +++ trunk/LayoutTests/platform/efl-wk1/TestExpectations 2012-11-26 12:40:40 UTC (rev 135707) @@ -392,3 +392,7 @@ # ESC key does not cancel context menu in EFL port Bug(EFL) editing/selection/5354455-1.html [ Failure ] + +# Fails on efl wk1 bot, see also webkit.org/b/102190 +webkit.org/b/103043 fast/events/overflow-scroll-fake-mouse-move.html [ Failure ] +webkit.org/b/103043 fast/events/frame-scroll-fake-mouse-move.html [ Failure ] Modified: trunk/LayoutTests/platform/efl-wk2/TestExpectations (135706 => 135707) --- trunk/LayoutTests/platform/efl-wk2/TestExpectations 2012-11-26 12:32:15 UTC (rev 135706) +++ trunk/LayoutTests/platform/efl-wk2/TestExpectations 2012-11-26 12:40:40 UTC (rev 135707) @@ -53,7 +53,6 @@ webkit.org/b/102200 fast/dom/HTMLAnchorElement/anchor-nodownload-set.html [ Crash Failure ] webkit.org/b/102203 fast/events/attribute-listener-deletion-crash.html [ Crash ] -webkit.org/b/102204 http/tests/security/frameNavigation/inactive-function-in-popup-navigate-child.html [ Crash ] # Hitting !decoder.destinationID() assertion. webkit.org/b/102651 [ Debug ] networkinformation/multiple-frames.html [ Crash ] @@ -182,6 +181,22 @@ webkit.org/b/102370 fast/writing-mode/japanese-ruby-vertical-rl.html [ Failure Pass ] webkit.org/b/102370 fast/text/international/002.html [ Failure Pass ] +# All debug bots timeout (crash) on this one +webkit.org/b/56496 [ Debug ] fast/js/array-sort-modifying-tostring.html [ Crash Pass ] + +webkit.org/b/102204 http/tests/security/frameNavigation/inactive-function-in-popup-navigate-child.html [ Crash Pass ] + +# Flaky on Debug bot. See also webkit.org/b/102190 +webkit.org/b/103043 fast/events/overflow-scroll-fake-mouse-move.html [ Failure Pass ] +webkit.org/b/103043 fast/events/frame-scroll-fake-mouse-move.html [ Failure Pass ] + +# Failures after r130363. +webkit.org/b/98573 fast/forms/multiple-form-submission-protection-mouse.html [ Failure Pass ] + +webkit.org/b/103113 editing/deleting/delete-ligature-003.html [ Failure Pass ] + +webkit.org/b/103115 http/tests/loading/remove-child-triggers-parser.html [ Failure Pass ] + # # FAILING TESTS # @@ -221,9 +236,6 @@ # The following test makes the fast/parser/document-write-ignores-later-network-bytes.html test crash webkit.org/b/98345 fast/parser/document-open-in-unload.html [ Skip ] -# Fails after r130363.
[webkit-changes] [135708] trunk
Title: [135708] trunk
Revision 135708
Author commit-qu...@webkit.org
Date 2012-11-26 05:37:20 -0800 (Mon, 26 Nov 2012)
Log Message
Web Inspector: HeapProfiler: remove snapshotView reference from data-grids.
https://bugs.webkit.org/show_bug.cgi?id=103240
Patch by Eugene Klyuchnikov eus...@chromium.org on 2012-11-26
Reviewed by Yury Semikhatsky.
Source/WebCore:
Cleanup: remove redundant dependency.
* inspector/front-end/HeapSnapshotDataGrids.js: Do not store view ref.
* inspector/front-end/HeapSnapshotGridNodes.js:
Removed unused assignments.
* inspector/front-end/HeapSnapshotView.js:
Do not pass self to data-grids.
LayoutTests:
Directly access current view instead of getting if from the data grid.
* inspector/profiler/heap-snapshot-test.js:
(initialize_HeapSnapshotTest):
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/inspector/profiler/heap-snapshot-test.js
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/HeapSnapshotDataGrids.js
trunk/Source/WebCore/inspector/front-end/HeapSnapshotGridNodes.js
trunk/Source/WebCore/inspector/front-end/HeapSnapshotView.js
Diff
Modified: trunk/LayoutTests/ChangeLog (135707 => 135708)
--- trunk/LayoutTests/ChangeLog 2012-11-26 12:40:40 UTC (rev 135707)
+++ trunk/LayoutTests/ChangeLog 2012-11-26 13:37:20 UTC (rev 135708)
@@ -1,3 +1,15 @@
+2012-11-26 Eugene Klyuchnikov eus...@chromium.org
+
+Web Inspector: HeapProfiler: remove snapshotView reference from data-grids.
+https://bugs.webkit.org/show_bug.cgi?id=103240
+
+Reviewed by Yury Semikhatsky.
+
+Directly access current view instead of getting if from the data grid.
+
+* inspector/profiler/heap-snapshot-test.js:
+(initialize_HeapSnapshotTest):
+
2012-11-26 Jussi Kukkonen jussi.kukko...@intel.com
[EFL] Gardening: update test expectations
Modified: trunk/LayoutTests/inspector/profiler/heap-snapshot-test.js (135707 => 135708)
--- trunk/LayoutTests/inspector/profiler/heap-snapshot-test.js 2012-11-26 12:40:40 UTC (rev 135707)
+++ trunk/LayoutTests/inspector/profiler/heap-snapshot-test.js 2012-11-26 13:37:20 UTC (rev 135708)
@@ -341,7 +341,7 @@
}
};
this._currentGrid()._mouseDownInDataTable(event);
-var rootNode = InspectorTest._currentGrid().snapshotView.retainmentDataGrid.rootNode();
+var rootNode = InspectorTest._currentProfileView().retainmentDataGrid.rootNode();
function populateComplete()
{
rootNode.removeEventListener(populate complete, populateComplete, this);
@@ -743,9 +743,14 @@
return InspectorTest._currentGrid()._columnsArray;
};
+InspectorTest._currentProfileView = function()
+{
+return WebInspector.panels.profiles.visibleView;
+};
+
InspectorTest._currentGrid = function()
{
-return WebInspector.panels.profiles.visibleView.dataGrid;
+return this._currentProfileView().dataGrid;
};
InspectorTest._snapshotViewShown = function()
Modified: trunk/Source/WebCore/ChangeLog (135707 => 135708)
--- trunk/Source/WebCore/ChangeLog 2012-11-26 12:40:40 UTC (rev 135707)
+++ trunk/Source/WebCore/ChangeLog 2012-11-26 13:37:20 UTC (rev 135708)
@@ -1,3 +1,18 @@
+2012-11-26 Eugene Klyuchnikov eus...@chromium.org
+
+Web Inspector: HeapProfiler: remove snapshotView reference from data-grids.
+https://bugs.webkit.org/show_bug.cgi?id=103240
+
+Reviewed by Yury Semikhatsky.
+
+Cleanup: remove redundant dependency.
+
+* inspector/front-end/HeapSnapshotDataGrids.js: Do not store view ref.
+* inspector/front-end/HeapSnapshotGridNodes.js:
+Removed unused assignments.
+* inspector/front-end/HeapSnapshotView.js:
+Do not pass self to data-grids.
+
2012-11-26 Zeno Albisser z...@webkit.org
GraphicsSurface should only store its size in a single place.
Modified: trunk/Source/WebCore/inspector/front-end/HeapSnapshotDataGrids.js (135707 => 135708)
--- trunk/Source/WebCore/inspector/front-end/HeapSnapshotDataGrids.js 2012-11-26 12:40:40 UTC (rev 135707)
+++ trunk/Source/WebCore/inspector/front-end/HeapSnapshotDataGrids.js 2012-11-26 13:37:20 UTC (rev 135708)
@@ -438,9 +438,8 @@
}
WebInspector.HeapSnapshotContainmentDataGrid.prototype = {
-setDataSource: function(snapshotView, snapshot, nodeIndex)
+setDataSource: function(snapshot, nodeIndex)
{
-this.snapshotView = snapshotView;
this.snapshot = snapshot;
var node = new WebInspector.HeapSnapshotNode(snapshot, nodeIndex || snapshot.rootNodeIndex);
var fakeEdge = { node: node };
@@ -552,9 +551,8 @@
this.snapshot.nodeClassName(parseInt(id, 10), didGetClassName.bind(this));
},
-setDataSource: function(snapshotView, snapshot)
+setDataSource: function(snapshot)
{
-this.snapshotView = snapshotView;
this.snapshot = snapshot;
if (this._profileIndex === -1)
this._populateChildren();
@@ -645,9 +643,8 @@
[webkit-changes] [135709] trunk/Source/WebCore
Title: [135709] trunk/Source/WebCore Revision 135709 Author commit-qu...@webkit.org Date 2012-11-26 05:41:20 -0800 (Mon, 26 Nov 2012) Log Message Circular reference between Document and MediaQueryMatcher. https://bugs.webkit.org/show_bug.cgi?id=103242 Patch by Marja Hölttä ma...@chromium.org on 2012-11-26 Reviewed by Kenneth Rohde Christiansen. It's not enough to clean up listeners in MediaQueryMatcher in ~Document, since MediaQueryListListener keeps the Document alive. This caused www.crbug.com/113983. No new tests: No visible change in behavior (except that it doesn't leak memory). * dom/Document.cpp: (WebCore::Document::~Document): (WebCore::Document::detach): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/dom/Document.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (135708 => 135709) --- trunk/Source/WebCore/ChangeLog 2012-11-26 13:37:20 UTC (rev 135708) +++ trunk/Source/WebCore/ChangeLog 2012-11-26 13:41:20 UTC (rev 135709) @@ -1,3 +1,20 @@ +2012-11-26 Marja Hölttä ma...@chromium.org + +Circular reference between Document and MediaQueryMatcher. +https://bugs.webkit.org/show_bug.cgi?id=103242 + +Reviewed by Kenneth Rohde Christiansen. + +It's not enough to clean up listeners in MediaQueryMatcher in ~Document, +since MediaQueryListListener keeps the Document alive. This caused +www.crbug.com/113983. + +No new tests: No visible change in behavior (except that it doesn't leak memory). + +* dom/Document.cpp: +(WebCore::Document::~Document): +(WebCore::Document::detach): + 2012-11-26 Eugene Klyuchnikov eus...@chromium.org Web Inspector: HeapProfiler: remove snapshotView reference from data-grids. Modified: trunk/Source/WebCore/dom/Document.cpp (135708 => 135709) --- trunk/Source/WebCore/dom/Document.cpp 2012-11-26 13:37:20 UTC (rev 135708) +++ trunk/Source/WebCore/dom/Document.cpp 2012-11-26 13:41:20 UTC (rev 135709) @@ -648,9 +648,6 @@ m_weakReference-clear(); -if (m_mediaQueryMatcher) -m_mediaQueryMatcher-documentDestroyed(); - clearStyleResolver(); // We need to destory CSSFontSelector before destroying m_cachedResourceLoader. // It's possible for multiple Documents to end up referencing the same CachedResourceLoader (e.g., SVGImages @@ -2142,6 +2139,9 @@ // callers of Document::detach(). m_frame = 0; m_renderArena.clear(); + +if (m_mediaQueryMatcher) +m_mediaQueryMatcher-documentDestroyed(); } void Document::prepareForDestruction() ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [135710] trunk/Source/WebCore
Title: [135710] trunk/Source/WebCore
Revision 135710
Author allan.jen...@digia.com
Date 2012-11-26 05:54:02 -0800 (Mon, 26 Nov 2012)
Log Message
HitTestResult should not be a HitTestLocation
https://bugs.webkit.org/show_bug.cgi?id=101590
Reviewed by Sam Weinig.
Change HitTestResult from being a HitTestLocation to having a HitTestLocation.
A result of a test should not be a special case of the location of the test.
No change in functionality. No new tests.
* rendering/HitTestResult.cpp:
(WebCore::HitTestResult::HitTestResult):
(WebCore::HitTestResult::operator=):
(WebCore::HitTestResult::isSelected):
(WebCore::HitTestResult::spellingToolTip):
(WebCore::HitTestResult::replacedString):
* rendering/HitTestResult.h:
(WebCore::HitTestResult::isRectBasedTest):
(WebCore::HitTestResult::pointInInnerNodeFrame):
(WebCore::HitTestResult::hitTestLocation):
(HitTestResult):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/HitTestResult.cpp
trunk/Source/WebCore/rendering/HitTestResult.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (135709 => 135710)
--- trunk/Source/WebCore/ChangeLog 2012-11-26 13:41:20 UTC (rev 135709)
+++ trunk/Source/WebCore/ChangeLog 2012-11-26 13:54:02 UTC (rev 135710)
@@ -1,3 +1,27 @@
+2012-11-26 Allan Sandfeld Jensen allan.jen...@digia.com
+
+HitTestResult should not be a HitTestLocation
+https://bugs.webkit.org/show_bug.cgi?id=101590
+
+Reviewed by Sam Weinig.
+
+Change HitTestResult from being a HitTestLocation to having a HitTestLocation.
+A result of a test should not be a special case of the location of the test.
+
+No change in functionality. No new tests.
+
+* rendering/HitTestResult.cpp:
+(WebCore::HitTestResult::HitTestResult):
+(WebCore::HitTestResult::operator=):
+(WebCore::HitTestResult::isSelected):
+(WebCore::HitTestResult::spellingToolTip):
+(WebCore::HitTestResult::replacedString):
+* rendering/HitTestResult.h:
+(WebCore::HitTestResult::isRectBasedTest):
+(WebCore::HitTestResult::pointInInnerNodeFrame):
+(WebCore::HitTestResult::hitTestLocation):
+(HitTestResult):
+
2012-11-26 Marja Hölttä ma...@chromium.org
Circular reference between Document and MediaQueryMatcher.
Modified: trunk/Source/WebCore/rendering/HitTestResult.cpp (135709 => 135710)
--- trunk/Source/WebCore/rendering/HitTestResult.cpp 2012-11-26 13:41:20 UTC (rev 135709)
+++ trunk/Source/WebCore/rendering/HitTestResult.cpp 2012-11-26 13:54:02 UTC (rev 135710)
@@ -192,34 +192,34 @@
return IntRect(actualPoint, actualPadding);
}
-HitTestResult::HitTestResult() : HitTestLocation()
-, m_isOverWidget(false)
+HitTestResult::HitTestResult()
+: m_isOverWidget(false)
{
}
HitTestResult::HitTestResult(const LayoutPoint point)
-: HitTestLocation(point)
+: m_hitTestLocation(point)
, m_pointInMainFrame(point)
, m_isOverWidget(false)
{
}
HitTestResult::HitTestResult(const LayoutPoint centerPoint, unsigned topPadding, unsigned rightPadding, unsigned bottomPadding, unsigned leftPadding)
-: HitTestLocation(centerPoint, topPadding, rightPadding, bottomPadding, leftPadding)
+: m_hitTestLocation(centerPoint, topPadding, rightPadding, bottomPadding, leftPadding)
, m_pointInMainFrame(centerPoint)
, m_isOverWidget(false)
{
}
HitTestResult::HitTestResult(const HitTestLocation other)
-: HitTestLocation(other)
-, m_pointInMainFrame(point())
+: m_hitTestLocation(other)
+, m_pointInMainFrame(m_hitTestLocation.point())
, m_isOverWidget(false)
{
}
HitTestResult::HitTestResult(const HitTestResult other)
-: HitTestLocation(other)
+: m_hitTestLocation(other.m_hitTestLocation)
, m_innerNode(other.innerNode())
, m_innerNonSharedNode(other.innerNonSharedNode())
, m_pointInMainFrame(other.m_pointInMainFrame)
@@ -238,7 +238,7 @@
HitTestResult HitTestResult::operator=(const HitTestResult other)
{
-HitTestLocation::operator=(other);
+m_hitTestLocation = other.m_hitTestLocation;
m_innerNode = other.innerNode();
m_innerNonSharedNode = other.innerNonSharedNode();
m_pointInMainFrame = other.m_pointInMainFrame;
@@ -315,7 +315,7 @@
if (!frame)
return false;
-return frame-selection()-contains(point());
+return frame-selection()-contains(m_hitTestLocation.point());
}
String HitTestResult::spellingToolTip(TextDirection dir) const
@@ -326,7 +326,7 @@
if (!m_innerNonSharedNode)
return String();
-DocumentMarker* marker = m_innerNonSharedNode-document()-markers()-markerContainingPoint(point(), DocumentMarker::Grammar);
+DocumentMarker* marker = m_innerNonSharedNode-document()-markers()-markerContainingPoint(m_hitTestLocation.point(), DocumentMarker::Grammar);
if (!marker)
return String();
@@ -342,7 +342,7 @@
if (!m_innerNonSharedNode)
return
[webkit-changes] [135711] trunk/Source/WebCore
Title: [135711] trunk/Source/WebCore
Revision 135711
Author commit-qu...@webkit.org
Date 2012-11-26 05:55:16 -0800 (Mon, 26 Nov 2012)
Log Message
Web Inspector: [WebGL] Save WebGL extensions and restore on replay
https://bugs.webkit.org/show_bug.cgi?id=103141
Patch by Andrey Adaikin aand...@chromium.org on 2012-11-26
Reviewed by Yury Semikhatsky.
Save WebGL extensions that were enabled by the application, and restore it before the replay.
Drive-by: remove redundant if- checks in WebGL custom function wrappers (similar to 2D canvas).
* inspector/InjectedScriptCanvasModuleSource.js:
(.):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/InjectedScriptCanvasModuleSource.js
Diff
Modified: trunk/Source/WebCore/ChangeLog (135710 => 135711)
--- trunk/Source/WebCore/ChangeLog 2012-11-26 13:54:02 UTC (rev 135710)
+++ trunk/Source/WebCore/ChangeLog 2012-11-26 13:55:16 UTC (rev 135711)
@@ -1,3 +1,16 @@
+2012-11-26 Andrey Adaikin aand...@chromium.org
+
+Web Inspector: [WebGL] Save WebGL extensions and restore on replay
+https://bugs.webkit.org/show_bug.cgi?id=103141
+
+Reviewed by Yury Semikhatsky.
+
+Save WebGL extensions that were enabled by the application, and restore it before the replay.
+Drive-by: remove redundant if- checks in WebGL custom function wrappers (similar to 2D canvas).
+
+* inspector/InjectedScriptCanvasModuleSource.js:
+(.):
+
2012-11-26 Allan Sandfeld Jensen allan.jen...@digia.com
HitTestResult should not be a HitTestLocation
Modified: trunk/Source/WebCore/inspector/InjectedScriptCanvasModuleSource.js (135710 => 135711)
--- trunk/Source/WebCore/inspector/InjectedScriptCanvasModuleSource.js 2012-11-26 13:54:02 UTC (rev 135710)
+++ trunk/Source/WebCore/inspector/InjectedScriptCanvasModuleSource.js 2012-11-26 13:55:16 UTC (rev 135711)
@@ -1189,9 +1189,10 @@
},
/**
+ * Handles: texParameteri, texParameterf
* @param {Call} call
*/
-pushCall_texParameterf: function(call)
+pushCall_texParameter: function(call)
{
var args = call.args();
var pname = args[1];
@@ -1203,6 +1204,7 @@
},
/**
+ * Handles: copyTexImage2D, copyTexSubImage2D
* copyTexImage2D and copyTexSubImage2D define a texture image with pixels from the current framebuffer.
* @param {Call} call
*/
@@ -1223,9 +1225,6 @@
__proto__: WebGLBoundResource.prototype
}
-WebGLTextureResource.prototype.pushCall_texParameteri = WebGLTextureResource.prototype.pushCall_texParameterf;
-WebGLTextureResource.prototype.pushCall_copyTexSubImage2D = WebGLTextureResource.prototype.pushCall_copyTexImage2D;
-
/**
* @constructor
* @extends {Resource}
@@ -1456,6 +1455,8 @@
this._replayContextCallback = replayContextCallback;
/** @type {Object.number, boolean} */
this._customErrors = null;
+/** @type {!Object.string, boolean} */
+this._extensions = {};
}
/**
@@ -1633,6 +1634,14 @@
},
/**
+ * @param {string} name
+ */
+addExtension: function(name)
+{
+this._extensions[name] = true;
+},
+
+/**
* @override
* @param {Object} data
* @param {Cache} cache
@@ -1641,6 +1650,7 @@
{
var gl = this.wrappedObject();
data.replayContextCallback = this._replayContextCallback;
+data.extensions = TypeUtils.cloneObject(this._extensions);
var originalErrors = this.getAllErrors();
@@ -1696,10 +1706,15 @@
{
this._replayContextCallback = data.replayContextCallback;
this._customErrors = null;
+this._extensions = TypeUtils.cloneObject(data.extensions) || {};
var gl = /** @type {!WebGLRenderingContext} */ (Resource.wrappedObject(this._replayContextCallback()));
this.setWrappedObject(gl);
+// Enable corresponding WebGL extensions.
+for (var name in this._extensions)
+gl.getExtension(name);
+
var glState = data.glState;
gl.bindFramebuffer(gl.FRAMEBUFFER, /** @type {WebGLFramebuffer} */ (ReplayableResource.replay(glState.FRAMEBUFFER_BINDING, cache)));
gl.bindRenderbuffer(gl.RENDERBUFFER, /** @type {WebGLRenderbuffer} */ (ReplayableResource.replay(glState.RENDERBUFFER_BINDING, cache)));
@@ -1853,45 +1868,54 @@
/**
* @param {string} methodName
+ * @param {function(this:Resource, Call)=} pushCallFunc
*/
-function customWrapFunction(methodName)
+function stateModifyingWrapFunction(methodName, pushCallFunc)
{
-var customPushCall = pushCall_ + methodName;
-/**
- * @param {Object|number} target
- * @this Resource.WrapFunction
- */
-wrapFunctions[methodName] = function(target)
-{
-var resource =
[webkit-changes] [135712] trunk
Title: [135712] trunk
Revision 135712
Author pfeld...@chromium.org
Date 2012-11-26 06:01:44 -0800 (Mon, 26 Nov 2012)
Log Message
Web Inspector: object preview does not render node id, className; logs too many functions for jQuery.
https://bugs.webkit.org/show_bug.cgi?id=103222
Reviewed by Yury Semikhatsky.
Source/WebCore:
- Added node class name and id into the preview
- Now keeps track of properties separately from array indexes.
* inspector/InjectedScriptSource.js:
(.):
* inspector/InspectorOverlayPage.html:
* inspector/front-end/ConsoleMessage.js:
(WebInspector.ConsoleMessageImpl.prototype._appendObjectPreview):
(WebInspector.ConsoleMessageImpl.prototype._appendPropertyPreview):
LayoutTests:
* inspector/console/command-line-api-expected.txt:
* inspector/console/console-dir-expected.txt:
* inspector/console/console-format-expected.txt:
* inspector/elements/event-listener-sidebar-expected.txt:
* inspector/elements/event-listeners-about-blank-expected.txt:
* platform/chromium/inspector/console/console-dir-expected.txt:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/inspector/console/command-line-api-expected.txt
trunk/LayoutTests/inspector/console/command-line-api-inspect-expected.txt
trunk/LayoutTests/inspector/console/console-dir-expected.txt
trunk/LayoutTests/inspector/console/console-format-collections-expected.txt
trunk/LayoutTests/inspector/console/console-format-expected.txt
trunk/LayoutTests/inspector/elements/event-listener-sidebar-expected.txt
trunk/LayoutTests/inspector/elements/event-listeners-about-blank-expected.txt
trunk/LayoutTests/platform/chromium/TestExpectations
trunk/LayoutTests/platform/chromium/inspector/console/command-line-api-inspect-expected.txt
trunk/LayoutTests/platform/chromium/inspector/console/console-dir-expected.txt
trunk/LayoutTests/platform/chromium/inspector/console/console-format-collections-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/InjectedScriptSource.js
trunk/Source/WebCore/inspector/InspectorOverlayPage.html
trunk/Source/WebCore/inspector/front-end/ConsoleMessage.js
Removed Paths
trunk/LayoutTests/platform/chromium-linux/inspector/console/console-format-collections-expected.txt
Diff
Modified: trunk/LayoutTests/ChangeLog (135711 => 135712)
--- trunk/LayoutTests/ChangeLog 2012-11-26 13:55:16 UTC (rev 135711)
+++ trunk/LayoutTests/ChangeLog 2012-11-26 14:01:44 UTC (rev 135712)
@@ -1,3 +1,17 @@
+2012-11-26 Pavel Feldman pfeld...@chromium.org
+
+Web Inspector: object preview does not render node id, className; logs too many functions for jQuery.
+https://bugs.webkit.org/show_bug.cgi?id=103222
+
+Reviewed by Yury Semikhatsky.
+
+* inspector/console/command-line-api-expected.txt:
+* inspector/console/console-dir-expected.txt:
+* inspector/console/console-format-expected.txt:
+* inspector/elements/event-listener-sidebar-expected.txt:
+* inspector/elements/event-listeners-about-blank-expected.txt:
+* platform/chromium/inspector/console/console-dir-expected.txt:
+
2012-11-26 Eugene Klyuchnikov eus...@chromium.org
Web Inspector: HeapProfiler: remove snapshotView reference from data-grids.
Modified: trunk/LayoutTests/inspector/console/command-line-api-expected.txt (135711 => 135712)
--- trunk/LayoutTests/inspector/console/command-line-api-expected.txt 2012-11-26 13:55:16 UTC (rev 135711)
+++ trunk/LayoutTests/inspector/console/command-line-api-expected.txt 2012-11-26 14:01:44 UTC (rev 135712)
@@ -1,4 +1,4 @@
-CONSOLE MESSAGE: line 1040: The console function $() has changed from $=getElementById(id) to $=querySelector(selector). You might try $(#%s)
+CONSOLE MESSAGE: line 1054: The console function $() has changed from $=getElementById(id) to $=querySelector(selector). You might try $(#%s)
Tests that command line api works.
Modified: trunk/LayoutTests/inspector/console/command-line-api-inspect-expected.txt (135711 => 135712)
--- trunk/LayoutTests/inspector/console/command-line-api-inspect-expected.txt 2012-11-26 13:55:16 UTC (rev 135711)
+++ trunk/LayoutTests/inspector/console/command-line-api-inspect-expected.txt 2012-11-26 14:01:44 UTC (rev 135712)
@@ -4,7 +4,7 @@
Running: testRevealElement
-WebInspector.inspect called with: p
+WebInspector.inspect called with: p#p1
WebInspector.inspect's hints are: []
inspect($('#p1')) =
Selected node id: 'p1'.
Modified: trunk/LayoutTests/inspector/console/console-dir-expected.txt (135711 => 135712)
--- trunk/LayoutTests/inspector/console/console-dir-expected.txt 2012-11-26 13:55:16 UTC (rev 135711)
+++ trunk/LayoutTests/inspector/console/console-dir-expected.txt 2012-11-26 14:01:44 UTC (rev 135712)
@@ -12,7 +12,7 @@
__proto__: Array[0] console-dir.html:9
NodeList[1]
-0: html
+0: html
constructor: NodeListConstructor
length: 1
__proto__: NodeListPrototype console-dir.html:10
Modified:
[webkit-changes] [135713] trunk/Source/WebCore
Title: [135713] trunk/Source/WebCore
Revision 135713
Author yu...@chromium.org
Date 2012-11-26 06:06:58 -0800 (Mon, 26 Nov 2012)
Log Message
Web Inspector: unify agents handling in Page and Worker inspector controllers
https://bugs.webkit.org/show_bug.cgi?id=103238
Reviewed by Alexander Pavlov.
Introduced a class that represents a collection of inspector agents and allows
to call methods declared on InspectorAgentBaseInterface for all registered agents.
InspectorController and WorkerInspectorController switched to this class.
* inspector/InspectorBaseAgent.cpp:
(WebCore::InspectorAgentRegistry::append):
(WebCore):
(WebCore::InspectorAgentRegistry::setFrontend):
(WebCore::InspectorAgentRegistry::clearFrontend):
(WebCore::InspectorAgentRegistry::restore):
(WebCore::InspectorAgentRegistry::registerInDispatcher):
(WebCore::InspectorAgentRegistry::discardAgents):
* inspector/InspectorBaseAgent.h:
(InspectorAgentRegistry):
(WebCore):
* inspector/InspectorController.cpp:
(WebCore::InspectorController::~InspectorController):
(WebCore::InspectorController::connectFrontend):
(WebCore::InspectorController::disconnectFrontend):
(WebCore::InspectorController::reconnectFrontend):
* inspector/InspectorController.h:
(InspectorController):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/InspectorBaseAgent.cpp
trunk/Source/WebCore/inspector/InspectorBaseAgent.h
trunk/Source/WebCore/inspector/InspectorController.cpp
trunk/Source/WebCore/inspector/InspectorController.h
trunk/Source/WebCore/inspector/WorkerInspectorController.cpp
trunk/Source/WebCore/inspector/WorkerInspectorController.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (135712 => 135713)
--- trunk/Source/WebCore/ChangeLog 2012-11-26 14:01:44 UTC (rev 135712)
+++ trunk/Source/WebCore/ChangeLog 2012-11-26 14:06:58 UTC (rev 135713)
@@ -1,3 +1,33 @@
+2012-11-26 Yury Semikhatsky yu...@chromium.org
+
+Web Inspector: unify agents handling in Page and Worker inspector controllers
+https://bugs.webkit.org/show_bug.cgi?id=103238
+
+Reviewed by Alexander Pavlov.
+
+Introduced a class that represents a collection of inspector agents and allows
+to call methods declared on InspectorAgentBaseInterface for all registered agents.
+InspectorController and WorkerInspectorController switched to this class.
+
+* inspector/InspectorBaseAgent.cpp:
+(WebCore::InspectorAgentRegistry::append):
+(WebCore):
+(WebCore::InspectorAgentRegistry::setFrontend):
+(WebCore::InspectorAgentRegistry::clearFrontend):
+(WebCore::InspectorAgentRegistry::restore):
+(WebCore::InspectorAgentRegistry::registerInDispatcher):
+(WebCore::InspectorAgentRegistry::discardAgents):
+* inspector/InspectorBaseAgent.h:
+(InspectorAgentRegistry):
+(WebCore):
+* inspector/InspectorController.cpp:
+(WebCore::InspectorController::~InspectorController):
+(WebCore::InspectorController::connectFrontend):
+(WebCore::InspectorController::disconnectFrontend):
+(WebCore::InspectorController::reconnectFrontend):
+* inspector/InspectorController.h:
+(InspectorController):
+
2012-11-26 Pavel Feldman pfeld...@chromium.org
Web Inspector: object preview does not render node id, className; logs too many functions for jQuery.
Modified: trunk/Source/WebCore/inspector/InspectorBaseAgent.cpp (135712 => 135713)
--- trunk/Source/WebCore/inspector/InspectorBaseAgent.cpp 2012-11-26 14:01:44 UTC (rev 135712)
+++ trunk/Source/WebCore/inspector/InspectorBaseAgent.cpp 2012-11-26 14:06:58 UTC (rev 135713)
@@ -57,6 +57,41 @@
info.addWeakPointer(m_state);
}
+void InspectorAgentRegistry::append(PassOwnPtrInspectorBaseAgentInterface agent)
+{
+m_agents.append(agent);
+}
+
+void InspectorAgentRegistry::setFrontend(InspectorFrontend* frontend)
+{
+for (size_t i = 0; i m_agents.size(); i++)
+m_agents[i]-setFrontend(frontend);
+}
+
+void InspectorAgentRegistry::clearFrontend()
+{
+for (size_t i = 0; i m_agents.size(); i++)
+m_agents[i]-clearFrontend();
+}
+
+void InspectorAgentRegistry::restore()
+{
+for (size_t i = 0; i m_agents.size(); i++)
+m_agents[i]-restore();
+}
+
+void InspectorAgentRegistry::registerInDispatcher(InspectorBackendDispatcher* dispatcher)
+{
+for (size_t i = 0; i m_agents.size(); i++)
+m_agents[i]-registerInDispatcher(dispatcher);
+}
+
+void InspectorAgentRegistry::discardAgents()
+{
+for (size_t i = 0; i m_agents.size(); i++)
+m_agents[i]-discardAgent();
+}
+
} // namespace WebCore
#endif // ENABLE(INSPECTOR)
Modified: trunk/Source/WebCore/inspector/InspectorBaseAgent.h (135712 => 135713)
--- trunk/Source/WebCore/inspector/InspectorBaseAgent.h 2012-11-26 14:01:44 UTC (rev 135712)
+++ trunk/Source/WebCore/inspector/InspectorBaseAgent.h 2012-11-26 14:06:58 UTC (rev 135713)
@@ -65,6 +65,20 @@
[webkit-changes] [135714] trunk/LayoutTests
Title: [135714] trunk/LayoutTests Revision 135714 Author pfeld...@chromium.org Date 2012-11-26 06:10:41 -0800 (Mon, 26 Nov 2012) Log Message Not reviewed: rolling out accidental TestExpectations change. * platform/chromium/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (135713 => 135714) --- trunk/LayoutTests/ChangeLog 2012-11-26 14:06:58 UTC (rev 135713) +++ trunk/LayoutTests/ChangeLog 2012-11-26 14:10:41 UTC (rev 135714) @@ -1,3 +1,9 @@ +2012-11-26 'Pavel Feldman' pfeld...@chromium.org + +Not reviewed: rolling out accidental TestExpectations change. + +* platform/chromium/TestExpectations: + 2012-11-26 Pavel Feldman pfeld...@chromium.org Web Inspector: object preview does not render node id, className; logs too many functions for jQuery. Modified: trunk/LayoutTests/platform/chromium/TestExpectations (135713 => 135714) --- trunk/LayoutTests/platform/chromium/TestExpectations 2012-11-26 14:06:58 UTC (rev 135713) +++ trunk/LayoutTests/platform/chromium/TestExpectations 2012-11-26 14:10:41 UTC (rev 135714) @@ -3679,7 +3679,7 @@ webkit.org/b/91372 [ Win ] css2.1/20110323/vertical-align-boxes-001.htm [ ImageOnlyFailure ] # Fails on Win -webkit.org/b/93624 [ Win ] inspector/console/console-format-collections.html [ Failure Pass ] +webkit.org/b/93624 [ Win Linux ] inspector/console/console-format-collections.html [ Failure Pass ] # Started failing around r122770 webkit.org/b/91445 [ Linux ] plugins/embed-attributes-style.html [ ImageOnlyFailure Pass ] @@ -4247,6 +4247,8 @@ webkit.org/b/103154 [ Win7 SnowLeopard Lion Linux Debug ] fast/frames/frame-unload-crash2.html [ Pass Timeout ] webkit.org/b/103148 [ Lion ] fast/text/large-text-composed-char.html [ ImageOnlyFailure ] webkit.org/b/103148 [ Lion ] fast/text/text-letter-spacing.html [ ImageOnlyFailure ] +webkit.org/b/103161 [ Linux Win ] inspector/console/command-line-api-inspect.html [ Pass Failure ] +webkit.org/b/103161 [ Linux Win ] inspector/runtime/runtime-localStorage-getProperties.html [ Pass Failure ] webkit.org/b/103148 [ Linux Win Mac ] svg/batik/text/textPosition2.svg [ ImageOnlyFailure ] webkit.org/b/103181 [ Win7 ] http/tests/local/drag-over-remote-content.html [ Pass Crash Timeout ] webkit.org/b/103183 [ Win7 SnowLeopard ] media/video-seek-past-end-playing.html [ Pass Crash ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [135715] trunk/Source/WebCore
Title: [135715] trunk/Source/WebCore
Revision 135715
Author zeno.albis...@digia.com
Date 2012-11-26 06:36:05 -0800 (Mon, 26 Nov 2012)
Log Message
[Qt][Win] buildfix after r135706.
https://bugs.webkit.org/show_bug.cgi?id=103249
The Windows implementation of GraphicsSurface cannot use
m_size anymore, as this member has been removed.
Further it needs to implement a platformSize() function.
Reviewed by Kenneth Rohde Christiansen.
* platform/graphics/surfaces/win/GraphicsSurfaceWin.cpp:
(WebCore::GraphicsSurfacePrivate::size):
(WebCore::GraphicsSurface::platformPaintToTextureMapper):
(WebCore::GraphicsSurface::platformSize):
(WebCore):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/surfaces/win/GraphicsSurfaceWin.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (135714 => 135715)
--- trunk/Source/WebCore/ChangeLog 2012-11-26 14:10:41 UTC (rev 135714)
+++ trunk/Source/WebCore/ChangeLog 2012-11-26 14:36:05 UTC (rev 135715)
@@ -1,3 +1,20 @@
+2012-11-26 Zeno Albisser z...@webkit.org
+
+[Qt][Win] buildfix after r135706.
+https://bugs.webkit.org/show_bug.cgi?id=103249
+
+The Windows implementation of GraphicsSurface cannot use
+m_size anymore, as this member has been removed.
+Further it needs to implement a platformSize() function.
+
+Reviewed by Kenneth Rohde Christiansen.
+
+* platform/graphics/surfaces/win/GraphicsSurfaceWin.cpp:
+(WebCore::GraphicsSurfacePrivate::size):
+(WebCore::GraphicsSurface::platformPaintToTextureMapper):
+(WebCore::GraphicsSurface::platformSize):
+(WebCore):
+
2012-11-26 Yury Semikhatsky yu...@chromium.org
Web Inspector: unify agents handling in Page and Worker inspector controllers
Modified: trunk/Source/WebCore/platform/graphics/surfaces/win/GraphicsSurfaceWin.cpp (135714 => 135715)
--- trunk/Source/WebCore/platform/graphics/surfaces/win/GraphicsSurfaceWin.cpp 2012-11-26 14:10:41 UTC (rev 135714)
+++ trunk/Source/WebCore/platform/graphics/surfaces/win/GraphicsSurfaceWin.cpp 2012-11-26 14:36:05 UTC (rev 135715)
@@ -246,6 +246,10 @@
m_eglFrontBufferSurface = 0;
}
+IntSize size() const
+{
+return m_size;
+}
protected:
void initializeShaderProgram()
@@ -422,8 +426,8 @@
GLuint frontBufferTexture = platformGetTextureID();
TransformationMatrix adjustedTransform = transform;
-adjustedTransform.multiply(TransformationMatrix::rectToRect(FloatRect(FloatPoint::zero(), m_size), targetRect));
-static_castTextureMapperGL*(textureMapper)-drawTexture(frontBufferTexture, 0, m_size, targetRect, adjustedTransform, opacity, mask);
+adjustedTransform.multiply(TransformationMatrix::rectToRect(FloatRect(FloatPoint::zero(), m_private-size()), targetRect));
+static_castTextureMapperGL*(textureMapper)-drawTexture(frontBufferTexture, 0, m_private-size(), targetRect, adjustedTransform, opacity, mask);
}
uint32_t GraphicsSurface::platformFrontBuffer() const
@@ -441,6 +445,11 @@
return platformFrontBuffer();
}
+IntSize GraphicsSurface::platformSize() const
+{
+return m_private-size();
+}
+
PassRefPtrGraphicsSurface GraphicsSurface::platformCreate(const IntSize size, Flags flags, const PlatformGraphicsContext3D shareContext)
{
// Single buffered GraphicsSurface is currently not supported.
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [135716] trunk
Title: [135716] trunk
Revision 135716
Author pfeld...@chromium.org
Date 2012-11-26 06:46:14 -0800 (Mon, 26 Nov 2012)
Log Message
Not reviewed: rolling out r135714 and r135712 for breaking debug tests.
Source/WebCore:
* inspector/InjectedScriptSource.js:
(.):
* inspector/InspectorOverlayPage.html:
* inspector/front-end/ConsoleMessage.js:
(WebInspector.ConsoleMessageImpl.prototype._appendObjectPreview):
LayoutTests:
* inspector/console/command-line-api-expected.txt:
* inspector/console/command-line-api-inspect-expected.txt:
* inspector/console/console-dir-expected.txt:
* inspector/console/console-format-collections-expected.txt:
* inspector/console/console-format-expected.txt:
* inspector/elements/event-listener-sidebar-expected.txt:
* inspector/elements/event-listeners-about-blank-expected.txt:
* platform/chromium-linux/inspector/console/console-format-collections-expected.txt: Copied from LayoutTests/platform/chromium/inspector/console/console-format-collections-expected.txt.
* platform/chromium/inspector/console/command-line-api-inspect-expected.txt:
* platform/chromium/inspector/console/console-dir-expected.txt:
* platform/chromium/inspector/console/console-format-collections-expected.txt:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/inspector/console/command-line-api-expected.txt
trunk/LayoutTests/inspector/console/command-line-api-inspect-expected.txt
trunk/LayoutTests/inspector/console/console-dir-expected.txt
trunk/LayoutTests/inspector/console/console-format-collections-expected.txt
trunk/LayoutTests/inspector/console/console-format-expected.txt
trunk/LayoutTests/inspector/elements/event-listener-sidebar-expected.txt
trunk/LayoutTests/inspector/elements/event-listeners-about-blank-expected.txt
trunk/LayoutTests/platform/chromium/inspector/console/command-line-api-inspect-expected.txt
trunk/LayoutTests/platform/chromium/inspector/console/console-dir-expected.txt
trunk/LayoutTests/platform/chromium/inspector/console/console-format-collections-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/InjectedScriptSource.js
trunk/Source/WebCore/inspector/InspectorOverlayPage.html
trunk/Source/WebCore/inspector/front-end/ConsoleMessage.js
Added Paths
trunk/LayoutTests/platform/chromium-linux/inspector/console/console-format-collections-expected.txt
Diff
Modified: trunk/LayoutTests/ChangeLog (135715 => 135716)
--- trunk/LayoutTests/ChangeLog 2012-11-26 14:36:05 UTC (rev 135715)
+++ trunk/LayoutTests/ChangeLog 2012-11-26 14:46:14 UTC (rev 135716)
@@ -1,5 +1,21 @@
2012-11-26 'Pavel Feldman' pfeld...@chromium.org
+Not reviewed: rolling out r135714 and r135712 for breaking debug tests.
+
+* inspector/console/command-line-api-expected.txt:
+* inspector/console/command-line-api-inspect-expected.txt:
+* inspector/console/console-dir-expected.txt:
+* inspector/console/console-format-collections-expected.txt:
+* inspector/console/console-format-expected.txt:
+* inspector/elements/event-listener-sidebar-expected.txt:
+* inspector/elements/event-listeners-about-blank-expected.txt:
+* platform/chromium-linux/inspector/console/console-format-collections-expected.txt: Copied from LayoutTests/platform/chromium/inspector/console/console-format-collections-expected.txt.
+* platform/chromium/inspector/console/command-line-api-inspect-expected.txt:
+* platform/chromium/inspector/console/console-dir-expected.txt:
+* platform/chromium/inspector/console/console-format-collections-expected.txt:
+
+2012-11-26 'Pavel Feldman' pfeld...@chromium.org
+
Not reviewed: rolling out accidental TestExpectations change.
* platform/chromium/TestExpectations:
Modified: trunk/LayoutTests/inspector/console/command-line-api-expected.txt (135715 => 135716)
--- trunk/LayoutTests/inspector/console/command-line-api-expected.txt 2012-11-26 14:36:05 UTC (rev 135715)
+++ trunk/LayoutTests/inspector/console/command-line-api-expected.txt 2012-11-26 14:46:14 UTC (rev 135716)
@@ -1,4 +1,4 @@
-CONSOLE MESSAGE: line 1054: The console function $() has changed from $=getElementById(id) to $=querySelector(selector). You might try $(#%s)
+CONSOLE MESSAGE: line 1040: The console function $() has changed from $=getElementById(id) to $=querySelector(selector). You might try $(#%s)
Tests that command line api works.
Modified: trunk/LayoutTests/inspector/console/command-line-api-inspect-expected.txt (135715 => 135716)
--- trunk/LayoutTests/inspector/console/command-line-api-inspect-expected.txt 2012-11-26 14:36:05 UTC (rev 135715)
+++ trunk/LayoutTests/inspector/console/command-line-api-inspect-expected.txt 2012-11-26 14:46:14 UTC (rev 135716)
@@ -4,7 +4,7 @@
Running: testRevealElement
-WebInspector.inspect called with: p#p1
+WebInspector.inspect called with: p
WebInspector.inspect's hints are: []
inspect($('#p1')) =
Selected node id: 'p1'.
Modified:
[webkit-changes] [135717] trunk/Source/JavaScriptCore
Title: [135717] trunk/Source/_javascript_Core
Revision 135717
Author o...@webkit.org
Date 2012-11-26 06:47:40 -0800 (Mon, 26 Nov 2012)
Log Message
[Qt][ARM] REGRESSION(r130826): It made 33 JSC test and 466 layout tests crash
https://bugs.webkit.org/show_bug.cgi?id=98857
Patch by Gabor Ballabas gab...@inf.u-szeged.hu on 2012-11-26
Reviewed by Zoltan Herczeg.
Implement a new version of patchableBranch32 to fix crashing JSC
tests.
* assembler/MacroAssembler.h:
(MacroAssembler):
* assembler/MacroAssemblerARM.h:
(JSC::MacroAssemblerARM::patchableBranch32):
(MacroAssemblerARM):
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/assembler/MacroAssembler.h
trunk/Source/_javascript_Core/assembler/MacroAssemblerARM.h
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (135716 => 135717)
--- trunk/Source/_javascript_Core/ChangeLog 2012-11-26 14:46:14 UTC (rev 135716)
+++ trunk/Source/_javascript_Core/ChangeLog 2012-11-26 14:47:40 UTC (rev 135717)
@@ -1,3 +1,19 @@
+2012-11-26 Gabor Ballabas gab...@inf.u-szeged.hu
+
+[Qt][ARM] REGRESSION(r130826): It made 33 JSC test and 466 layout tests crash
+https://bugs.webkit.org/show_bug.cgi?id=98857
+
+Reviewed by Zoltan Herczeg.
+
+Implement a new version of patchableBranch32 to fix crashing JSC
+tests.
+
+* assembler/MacroAssembler.h:
+(MacroAssembler):
+* assembler/MacroAssemblerARM.h:
+(JSC::MacroAssemblerARM::patchableBranch32):
+(MacroAssemblerARM):
+
2012-11-21 Filip Pizlo fpi...@apple.com
Any function that can log things should be able to easily log them to a memory buffer as well
Modified: trunk/Source/_javascript_Core/assembler/MacroAssembler.h (135716 => 135717)
--- trunk/Source/_javascript_Core/assembler/MacroAssembler.h 2012-11-26 14:46:14 UTC (rev 135716)
+++ trunk/Source/_javascript_Core/assembler/MacroAssembler.h 2012-11-26 14:47:40 UTC (rev 135717)
@@ -266,12 +266,14 @@
{
return PatchableJump(branchTest32(cond, reg, mask));
}
-
+#endif // !CPU(ARM_THUMB2)
+
+#if !CPU(ARM)
PatchableJump patchableBranch32(RelationalCondition cond, RegisterID reg, TrustedImm32 imm)
{
return PatchableJump(branch32(cond, reg, imm));
}
-#endif
+#endif // !(CPU(ARM)
void jump(Label target)
{
Modified: trunk/Source/_javascript_Core/assembler/MacroAssemblerARM.h (135716 => 135717)
--- trunk/Source/_javascript_Core/assembler/MacroAssemblerARM.h 2012-11-26 14:46:14 UTC (rev 135716)
+++ trunk/Source/_javascript_Core/assembler/MacroAssemblerARM.h 2012-11-26 14:47:40 UTC (rev 135717)
@@ -570,11 +570,7 @@
Jump branch32(RelationalCondition cond, RegisterID left, TrustedImm32 right, int useConstantPool = 0)
{
-ARMWord tmp = (static_castunsigned(right.m_value) == 0x8000) ? ARMAssembler::InvalidImmediate : m_assembler.getOp2(-right.m_value);
-if (tmp != ARMAssembler::InvalidImmediate)
-m_assembler.cmn(left, tmp);
-else
-m_assembler.cmp(left, m_assembler.getImm(right.m_value, ARMRegisters::S0));
+internalCompare32(left, right);
return Jump(m_assembler.jmp(ARMCondition(cond), useConstantPool));
}
@@ -807,6 +803,14 @@
return Jump(m_assembler.jmp(ARMCondition(cond)));
}
+PatchableJump patchableBranch32(RelationalCondition cond, RegisterID reg, TrustedImm32 imm)
+{
+internalCompare32(reg, imm);
+Jump jump(m_assembler.loadBranchTarget(ARMRegisters::S1, ARMCondition(cond), true));
+m_assembler.bx(ARMRegisters::S1, ARMCondition(cond));
+return PatchableJump(jump);
+}
+
void breakpoint()
{
m_assembler.bkpt(0);
@@ -1320,6 +1324,15 @@
friend class LinkBuffer;
friend class RepatchBuffer;
+void internalCompare32(RegisterID left, TrustedImm32 right)
+{
+ARMWord tmp = (static_castunsigned(right.m_value) == 0x8000) ? ARMAssembler::InvalidImmediate : m_assembler.getOp2(-right.m_value);
+if (tmp != ARMAssembler::InvalidImmediate)
+m_assembler.cmn(left, tmp);
+else
+m_assembler.cmp(left, m_assembler.getImm(right.m_value, ARMRegisters::S0));
+}
+
static void linkCall(void* code, Call call, FunctionPtr function)
{
ARMAssembler::linkCall(code, call.m_label, function.value());
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [135718] trunk/Source/WebKit/chromium
Title: [135718] trunk/Source/WebKit/chromium
Revision 135718
Author commit-qu...@webkit.org
Date 2012-11-26 07:01:24 -0800 (Mon, 26 Nov 2012)
Log Message
[chromium] Make use_default_render_theme compile the right set of files
https://bugs.webkit.org/show_bug.cgi?id=102952
Patch by Scott Violet s...@chromium.org on 2012-11-26
Reviewed by Kent Tamura.
* WebKit.gyp: Adds WebRenderTheme.* and updates rules as to when to compile them.
* features.gypi: Removes use_default_render_theme default values as common.gypi sets them.
* public/default: Added.
* public/default/WebRenderTheme.h: Copy of linux/WebRenderTheme.h
* src/default: Added.
* src/default/WebRenderTheme.cpp: Copy of linux/WebRenderTheme.cpp
Modified Paths
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/WebKit.gyp
trunk/Source/WebKit/chromium/features.gypi
Added Paths
trunk/Source/WebKit/chromium/public/default/
trunk/Source/WebKit/chromium/public/default/WebRenderTheme.h
trunk/Source/WebKit/chromium/src/default/
trunk/Source/WebKit/chromium/src/default/WebRenderTheme.cpp
Diff
Modified: trunk/Source/WebKit/chromium/ChangeLog (135717 => 135718)
--- trunk/Source/WebKit/chromium/ChangeLog 2012-11-26 14:47:40 UTC (rev 135717)
+++ trunk/Source/WebKit/chromium/ChangeLog 2012-11-26 15:01:24 UTC (rev 135718)
@@ -1,3 +1,17 @@
+2012-11-26 Scott Violet s...@chromium.org
+
+[chromium] Make use_default_render_theme compile the right set of files
+https://bugs.webkit.org/show_bug.cgi?id=102952
+
+Reviewed by Kent Tamura.
+
+* WebKit.gyp: Adds WebRenderTheme.* and updates rules as to when to compile them.
+* features.gypi: Removes use_default_render_theme default values as common.gypi sets them.
+* public/default: Added.
+* public/default/WebRenderTheme.h: Copy of linux/WebRenderTheme.h
+* src/default: Added.
+* src/default/WebRenderTheme.cpp: Copy of linux/WebRenderTheme.cpp
+
2012-11-24 Silvia Pfeiffer silvi...@chromium.org
[chromium] Remove traces of MediaControlRootElement
Modified: trunk/Source/WebKit/chromium/WebKit.gyp (135717 => 135718)
--- trunk/Source/WebKit/chromium/WebKit.gyp 2012-11-26 14:47:40 UTC (rev 135717)
+++ trunk/Source/WebKit/chromium/WebKit.gyp 2012-11-26 15:01:24 UTC (rev 135718)
@@ -288,6 +288,7 @@
'public/WebWorkerInfo.h',
'public/android/WebInputEventFactory.h',
'public/android/WebSandboxSupport.h',
+'public/default/WebRenderTheme.h',
'public/gtk/WebInputEventFactory.h',
'public/linux/WebFontRenderStyle.h',
'public/linux/WebFontRendering.h',
@@ -432,6 +433,7 @@
'src/PrerendererClientImpl.h',
'src/PrerendererClientImpl.cpp',
'src/android/WebInputEventFactory.cpp',
+'src/default/WebRenderTheme.cpp',
'src/linux/WebFontInfo.cpp',
'src/linux/WebFontRendering.cpp',
'src/linux/WebFontRenderStyle.cpp',
@@ -840,6 +842,20 @@
}],
],
}],
+['use_default_render_theme==1', {
+'sources/': [
+['exclude', 'src/linux/WebRenderTheme.cpp'],
+['exclude', 'public/linux/WebRenderTheme.h'],
+],
+'include_dirs': [
+'public/default',
+],
+}, { # else use_default_render_theme==0
+'sources/': [
+['exclude', 'src/default/WebRenderTheme.cpp'],
+['exclude', 'public/default/WebRenderTheme.h'],
+],
+}],
],
'target_conditions': [
['OS==android', {
Modified: trunk/Source/WebKit/chromium/features.gypi (135717 => 135718)
--- trunk/Source/WebKit/chromium/features.gypi 2012-11-26 14:47:40 UTC (rev 135717)
+++ trunk/Source/WebKit/chromium/features.gypi 2012-11-26 15:01:24 UTC (rev 135718)
@@ -146,13 +146,11 @@
'enable_touch_events%': 1,
'enable_touch_icon_loading%' : 0,
'enable_mutation_observers%': 1,
- 'use_default_render_theme%': 0,
},
'use_accelerated_compositing%': '(use_accelerated_compositing)',
'enable_skia_text%': '(enable_skia_text)',
'enable_svg%': '(enable_svg)',
'enable_touch_events%': '(enable_touch_events)',
-'use_default_render_theme%': '(use_default_render_theme)',
'conditions': [
['OS==android', {
'feature_defines': [
Added: trunk/Source/WebKit/chromium/public/default/WebRenderTheme.h (0 => 135718)
--- trunk/Source/WebKit/chromium/public/default/WebRenderTheme.h (rev 0)
+++ trunk/Source/WebKit/chromium/public/default/WebRenderTheme.h 2012-11-26 15:01:24 UTC (rev 135718)
@@ -0,0 +1,43 @@
+/*
+ * Copyright (C)
[webkit-changes] [135719] trunk
Title: [135719] trunk
Revision 135719
Author fmal...@chromium.org
Date 2012-11-26 07:03:36 -0800 (Mon, 26 Nov 2012)
Log Message
RenderSVGResourceContainer does not clear cached data on removal
https://bugs.webkit.org/show_bug.cgi?id=102620
Reviewed by Dirk Schulze.
Source/WebCore:
RenderSVGResourceContainer::removeClient needs to also remove the client from specialized
caches, otherwise we can end up with stale references.
Test: svg/custom/stale-resource-data-crash.svg
* rendering/svg/RenderSVGResourceContainer.cpp:
(WebCore::RenderSVGResourceContainer::removeClient):
LayoutTests:
* svg/custom/stale-resource-data-crash-expected.txt: Added.
* svg/custom/stale-resource-data-crash.svg: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/svg/RenderSVGResourceContainer.cpp
Added Paths
trunk/LayoutTests/svg/custom/stale-resource-data-crash-expected.txt
trunk/LayoutTests/svg/custom/stale-resource-data-crash.svg
Diff
Modified: trunk/LayoutTests/ChangeLog (135718 => 135719)
--- trunk/LayoutTests/ChangeLog 2012-11-26 15:01:24 UTC (rev 135718)
+++ trunk/LayoutTests/ChangeLog 2012-11-26 15:03:36 UTC (rev 135719)
@@ -1,3 +1,13 @@
+2012-11-26 Florin Malita fmal...@chromium.org
+
+RenderSVGResourceContainer does not clear cached data on removal
+https://bugs.webkit.org/show_bug.cgi?id=102620
+
+Reviewed by Dirk Schulze.
+
+* svg/custom/stale-resource-data-crash-expected.txt: Added.
+* svg/custom/stale-resource-data-crash.svg: Added.
+
2012-11-26 'Pavel Feldman' pfeld...@chromium.org
Not reviewed: rolling out r135714 and r135712 for breaking debug tests.
Added: trunk/LayoutTests/svg/custom/stale-resource-data-crash-expected.txt (0 => 135719)
--- trunk/LayoutTests/svg/custom/stale-resource-data-crash-expected.txt (rev 0)
+++ trunk/LayoutTests/svg/custom/stale-resource-data-crash-expected.txt 2012-11-26 15:03:36 UTC (rev 135719)
@@ -0,0 +1,2 @@
+PASS: did not crash.
+
Added: trunk/LayoutTests/svg/custom/stale-resource-data-crash.svg (0 => 135719)
--- trunk/LayoutTests/svg/custom/stale-resource-data-crash.svg (rev 0)
+++ trunk/LayoutTests/svg/custom/stale-resource-data-crash.svg 2012-11-26 15:03:36 UTC (rev 135719)
@@ -0,0 +1,32 @@
+?xml version=1.0 encoding=UTF-8?
+svg id=svg xmlns:xlink=http://www.w3.org/1999/xlink xmlns=http://www.w3.org/2000/svg
+ defs id=defs
+filter id=f1
+ feDiffuseLighting
+feDistantLight azimuth=45 id=light/
+ /feDiffuseLighting
+/filter
+filter id=f2/
+ /defs
+ image id=img filter=url(#f1) xlink:href=""
+
+ textPASS: did not crash./text
+
+ script
+f2 = document.getElementById('f2');
+docElement = document.getElementById('svg');
+light = document.getElementById('light');
+newDefs = document.getElementById('defs').cloneNode(true);
+
+if (window.testRunner) {
+ testRunner.dumpAsText();
+ // Force a paint at this point to generate cached filter results.
+ testRunner.display();
+}
+
+docElement.appendChild(newDefs);
+docElement.appendChild(f2);
+docElement.offsetTop;
+light.removeAttribute('azimuth');
+ /script
+/svg
Modified: trunk/Source/WebCore/ChangeLog (135718 => 135719)
--- trunk/Source/WebCore/ChangeLog 2012-11-26 15:01:24 UTC (rev 135718)
+++ trunk/Source/WebCore/ChangeLog 2012-11-26 15:03:36 UTC (rev 135719)
@@ -1,3 +1,18 @@
+2012-11-26 Florin Malita fmal...@chromium.org
+
+RenderSVGResourceContainer does not clear cached data on removal
+https://bugs.webkit.org/show_bug.cgi?id=102620
+
+Reviewed by Dirk Schulze.
+
+RenderSVGResourceContainer::removeClient needs to also remove the client from specialized
+caches, otherwise we can end up with stale references.
+
+Test: svg/custom/stale-resource-data-crash.svg
+
+* rendering/svg/RenderSVGResourceContainer.cpp:
+(WebCore::RenderSVGResourceContainer::removeClient):
+
2012-11-26 'Pavel Feldman' pfeld...@chromium.org
Not reviewed: rolling out r135714 and r135712 for breaking debug tests.
Modified: trunk/Source/WebCore/rendering/svg/RenderSVGResourceContainer.cpp (135718 => 135719)
--- trunk/Source/WebCore/rendering/svg/RenderSVGResourceContainer.cpp 2012-11-26 15:01:24 UTC (rev 135718)
+++ trunk/Source/WebCore/rendering/svg/RenderSVGResourceContainer.cpp 2012-11-26 15:03:36 UTC (rev 135719)
@@ -151,6 +151,7 @@
void RenderSVGResourceContainer::removeClient(RenderObject* client)
{
ASSERT(client);
+removeClientFromCache(client, false);
m_clients.remove(client);
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [135720] trunk
Title: [135720] trunk Revision 135720 Author pfeld...@chromium.org Date 2012-11-26 07:17:17 -0800 (Mon, 26 Nov 2012) Log Message Web Inspector: object preview does not render node id, className; logs too many functions for jQuery. https://bugs.webkit.org/show_bug.cgi?id=103222 Reviewed by Yury Semikhatsky. Source/WebCore: - Added node class name and id into the preview - Now keeps track of properties separately from array indexes. * inspector/InjectedScriptSource.js: (.): * inspector/InspectorOverlayPage.html: * inspector/front-end/ConsoleMessage.js: (WebInspector.ConsoleMessageImpl.prototype._appendObjectPreview): (WebInspector.ConsoleMessageImpl.prototype._appendPropertyPreview): LayoutTests: * inspector/console/command-line-api-expected.txt: * inspector/console/command-line-api-inspect-expected.txt: * inspector/console/console-dir-expected.txt: * inspector/console/console-format-collections-expected.txt: * inspector/console/console-format-expected.txt: * inspector/elements/event-listener-sidebar-expected.txt: * inspector/elements/event-listeners-about-blank-expected.txt: * platform/chromium-linux/inspector/console/console-format-collections-expected.txt: Removed. * platform/chromium/inspector/console/command-line-api-inspect-expected.txt: * platform/chromium/inspector/console/console-dir-expected.txt: * platform/chromium/inspector/console/console-format-collections-expected.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/inspector/console/command-line-api-expected.txt trunk/LayoutTests/inspector/console/command-line-api-inspect-expected.txt trunk/LayoutTests/inspector/console/console-dir-expected.txt trunk/LayoutTests/inspector/console/console-format-collections-expected.txt trunk/LayoutTests/inspector/console/console-format-expected.txt trunk/LayoutTests/inspector/elements/event-listener-sidebar-expected.txt trunk/LayoutTests/inspector/elements/event-listeners-about-blank-expected.txt trunk/LayoutTests/platform/chromium/inspector/console/command-line-api-inspect-expected.txt trunk/LayoutTests/platform/chromium/inspector/console/console-dir-expected.txt trunk/LayoutTests/platform/chromium/inspector/console/console-format-collections-expected.txt trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/inspector/InjectedScriptSource.js trunk/Source/WebCore/inspector/InspectorOverlayPage.html trunk/Source/WebCore/inspector/front-end/ConsoleMessage.js Removed Paths trunk/LayoutTests/platform/chromium-linux/inspector/console/console-format-collections-expected.txt Diff Modified: trunk/LayoutTests/ChangeLog (135719 => 135720) --- trunk/LayoutTests/ChangeLog 2012-11-26 15:03:36 UTC (rev 135719) +++ trunk/LayoutTests/ChangeLog 2012-11-26 15:17:17 UTC (rev 135720) @@ -1,3 +1,22 @@ +2012-11-26 Pavel Feldman pfeld...@chromium.org + +Web Inspector: object preview does not render node id, className; logs too many functions for jQuery. +https://bugs.webkit.org/show_bug.cgi?id=103222 + +Reviewed by Yury Semikhatsky. + +* inspector/console/command-line-api-expected.txt: +* inspector/console/command-line-api-inspect-expected.txt: +* inspector/console/console-dir-expected.txt: +* inspector/console/console-format-collections-expected.txt: +* inspector/console/console-format-expected.txt: +* inspector/elements/event-listener-sidebar-expected.txt: +* inspector/elements/event-listeners-about-blank-expected.txt: +* platform/chromium-linux/inspector/console/console-format-collections-expected.txt: Removed. +* platform/chromium/inspector/console/command-line-api-inspect-expected.txt: +* platform/chromium/inspector/console/console-dir-expected.txt: +* platform/chromium/inspector/console/console-format-collections-expected.txt: + 2012-11-26 Florin Malita fmal...@chromium.org RenderSVGResourceContainer does not clear cached data on removal Modified: trunk/LayoutTests/inspector/console/command-line-api-expected.txt (135719 => 135720) --- trunk/LayoutTests/inspector/console/command-line-api-expected.txt 2012-11-26 15:03:36 UTC (rev 135719) +++ trunk/LayoutTests/inspector/console/command-line-api-expected.txt 2012-11-26 15:17:17 UTC (rev 135720) @@ -1,4 +1,4 @@ -CONSOLE MESSAGE: line 1040: The console function $() has changed from $=getElementById(id) to $=querySelector(selector). You might try $(#%s) +CONSOLE MESSAGE: line 1058: The console function $() has changed from $=getElementById(id) to $=querySelector(selector). You might try $(#%s) Tests that command line api works. Modified: trunk/LayoutTests/inspector/console/command-line-api-inspect-expected.txt (135719 => 135720) --- trunk/LayoutTests/inspector/console/command-line-api-inspect-expected.txt 2012-11-26 15:03:36 UTC (rev 135719) +++ trunk/LayoutTests/inspector/console/command-line-api-inspect-expected.txt 2012-11-26 15:17:17 UTC (rev 135720) @@ -4,7 +4,7 @@ Running: testRevealElement
[webkit-changes] [135721] trunk/Source/WebCore
Title: [135721] trunk/Source/WebCore Revision 135721 Author yu...@chromium.org Date 2012-11-26 07:23:45 -0800 (Mon, 26 Nov 2012) Log Message Unreviewed. Fix Qt minimal compilation after r135713. * inspector/InspectorController.h: hid file content behind ENABLE(INSPECTOR) Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/inspector/InspectorController.h Diff Modified: trunk/Source/WebCore/ChangeLog (135720 => 135721) --- trunk/Source/WebCore/ChangeLog 2012-11-26 15:17:17 UTC (rev 135720) +++ trunk/Source/WebCore/ChangeLog 2012-11-26 15:23:45 UTC (rev 135721) @@ -1,3 +1,9 @@ +2012-11-26 Yury Semikhatsky yu...@chromium.org + +Unreviewed. Fix Qt minimal compilation after r135713. + +* inspector/InspectorController.h: hid file content behind ENABLE(INSPECTOR) + 2012-11-26 Pavel Feldman pfeld...@chromium.org Web Inspector: object preview does not render node id, className; logs too many functions for jQuery. Modified: trunk/Source/WebCore/inspector/InspectorController.h (135720 => 135721) --- trunk/Source/WebCore/inspector/InspectorController.h 2012-11-26 15:17:17 UTC (rev 135720) +++ trunk/Source/WebCore/inspector/InspectorController.h 2012-11-26 15:23:45 UTC (rev 135721) @@ -31,6 +31,8 @@ #ifndef InspectorController_h #define InspectorController_h +#if ENABLE(INSPECTOR) + #include InspectorBaseAgent.h #include wtf/Forward.h #include wtf/HashMap.h @@ -147,4 +149,6 @@ } +#endif // ENABLE(INSPECTOR) + #endif // !defined(InspectorController_h) ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [135722] trunk/LayoutTests
Title: [135722] trunk/LayoutTests Revision 135722 Author rjkro...@chromium.org Date 2012-11-26 07:42:01 -0800 (Mon, 26 Nov 2012) Log Message Unreviewd Gardening: updated TestExpecations for additional failures in media/video-preload.html https://bugs.webkit.org/show_bug.cgi?id=103093 * platform/chromium/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (135721 => 135722) --- trunk/LayoutTests/ChangeLog 2012-11-26 15:23:45 UTC (rev 135721) +++ trunk/LayoutTests/ChangeLog 2012-11-26 15:42:01 UTC (rev 135722) @@ -1,3 +1,11 @@ +2012-11-26 Robert Kroeger rjkro...@chromium.org + +Unreviewd Gardening: updated TestExpecations for additional failures in +media/video-preload.html +https://bugs.webkit.org/show_bug.cgi?id=103093 + +* platform/chromium/TestExpectations: + 2012-11-26 Pavel Feldman pfeld...@chromium.org Web Inspector: object preview does not render node id, className; logs too many functions for jQuery. Modified: trunk/LayoutTests/platform/chromium/TestExpectations (135721 => 135722) --- trunk/LayoutTests/platform/chromium/TestExpectations 2012-11-26 15:23:45 UTC (rev 135721) +++ trunk/LayoutTests/platform/chromium/TestExpectations 2012-11-26 15:42:01 UTC (rev 135722) @@ -4238,7 +4238,7 @@ webkit.org/b/103062 [ Debug ] fast/canvas/canvas-strokePath-gradient-shadow.html [ Crash ] webkit.org/b/103062 [ Debug ] fast/canvas/canvas-strokeRect-gradient-shadow.html [ Crash ] -webkit.org/b/103093 [ MountainLion ] media/video-preload.html [ Crash ] +webkit.org/b/103093 [ Mac Win ] media/video-preload.html [ Crash Pass ] webkit.org/b/103148 [ Win Mac ] fast/frames/iframe-scaling-with-scroll.html [ ImageOnlyFailure ] webkit.org/b/103148 [ Lion ] fast/frames/iframe-scrolling-attribute.html [ ImageOnlyFailure ] webkit.org/b/103148 [ Lion ] fast/table/border-collapsing/004-vertical.html [ ImageOnlyFailure ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [135723] trunk
Title: [135723] trunk
Revision 135723
Author mk...@chromium.org
Date 2012-11-26 07:46:41 -0800 (Mon, 26 Nov 2012)
Log Message
Web Inspector: URLs containing '^' are improperly linked in console messages.
https://bugs.webkit.org/show_bug.cgi?id=103248
Reviewed by Yury Semikhatsky.
Source/WebCore:
This patch adds '^' to WebInspector's regex of acceptable characters for
URLs that it knows how to display.
Test: http/tests/inspector/network/script-as-text-loading-with-caret.html
* inspector/front-end/ResourceUtils.js:
(WebInspector.linkifyStringAsFragmentWithCustomLinkifier):
LayoutTests:
* http/tests/inspector/network/script-as-text-loading-with-caret-expected.txt: Added.
* http/tests/inspector/network/script-as-text-loading-with-caret.html: Added.
* platform/chromium/http/tests/inspector/network/script-as-text-loading-with-caret-expected.txt:
JSC vs V8. :(
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/ResourceUtils.js
Added Paths
trunk/LayoutTests/http/tests/inspector/network/script-as-text-loading-with-caret-expected.txt
trunk/LayoutTests/http/tests/inspector/network/script-as-text-loading-with-caret.html
trunk/LayoutTests/platform/chromium/http/tests/inspector/network/script-as-text-loading-with-caret-expected.txt
Diff
Modified: trunk/LayoutTests/ChangeLog (135722 => 135723)
--- trunk/LayoutTests/ChangeLog 2012-11-26 15:42:01 UTC (rev 135722)
+++ trunk/LayoutTests/ChangeLog 2012-11-26 15:46:41 UTC (rev 135723)
@@ -1,3 +1,15 @@
+2012-11-26 Mike West mk...@chromium.org
+
+Web Inspector: URLs containing '^' are improperly linked in console messages.
+https://bugs.webkit.org/show_bug.cgi?id=103248
+
+Reviewed by Yury Semikhatsky.
+
+* http/tests/inspector/network/script-as-text-loading-with-caret-expected.txt: Added.
+* http/tests/inspector/network/script-as-text-loading-with-caret.html: Added.
+* platform/chromium/http/tests/inspector/network/script-as-text-loading-with-caret-expected.txt:
+JSC vs V8. :(
+
2012-11-26 Robert Kroeger rjkro...@chromium.org
Unreviewd Gardening: updated TestExpecations for additional failures in
Added: trunk/LayoutTests/http/tests/inspector/network/script-as-text-loading-with-caret-expected.txt (0 => 135723)
--- trunk/LayoutTests/http/tests/inspector/network/script-as-text-loading-with-caret-expected.txt (rev 0)
+++ trunk/LayoutTests/http/tests/inspector/network/script-as-text-loading-with-caret-expected.txt 2012-11-26 15:46:41 UTC (rev 135723)
@@ -0,0 +1,5 @@
+Tests console message when script is loaded with incorrect text/html mime type and the URL contains the '^' character.
+
+Bug 103248
+Resource interpreted as Script but transferred with MIME type text/plain: http://127.0.0.1:8000/inspector/network/resources/script-as-text.php?this-i…-with^carats^like^these^because^who^doesnt^love^strange^characters^in^urls. [native code]:1
+
Added: trunk/LayoutTests/http/tests/inspector/network/script-as-text-loading-with-caret.html (0 => 135723)
--- trunk/LayoutTests/http/tests/inspector/network/script-as-text-loading-with-caret.html (rev 0)
+++ trunk/LayoutTests/http/tests/inspector/network/script-as-text-loading-with-caret.html 2012-11-26 15:46:41 UTC (rev 135723)
@@ -0,0 +1,31 @@
+html
+head
+script src=""
+script src=""
+script
+function loadScript()
+{
+var s = document.createElement(script);
+s.src = ""
+document.body.appendChild(s);
+}
+
+function test()
+{
+InspectorTest.addConsoleSniffer(step1);
+InspectorTest.evaluateInPage(loadScript());
+
+function step1()
+{
+InspectorTest.dumpConsoleMessages();
+InspectorTest.completeTest();
+}
+}
+/script
+/head
+body _onload_=runTest()
+pTests console message when script is loaded with incorrect text/html mime
+type and the URL contains the '^' character./p
+a href="" 103248/a
+/body
+/html
Added: trunk/LayoutTests/platform/chromium/http/tests/inspector/network/script-as-text-loading-with-caret-expected.txt (0 => 135723)
--- trunk/LayoutTests/platform/chromium/http/tests/inspector/network/script-as-text-loading-with-caret-expected.txt (rev 0)
+++ trunk/LayoutTests/platform/chromium/http/tests/inspector/network/script-as-text-loading-with-caret-expected.txt 2012-11-26 15:46:41 UTC (rev 135723)
@@ -0,0 +1,5 @@
+Tests console message when script is loaded with incorrect text/html mime type and the URL contains the '^' character.
+
+Bug 103248
+Resource interpreted as Script but transferred with MIME type text/plain: http://127.0.0.1:8000/inspector/network/resources/script-as-text.php?this-i…-with^carats^like^these^because^who^doesnt^love^strange^characters^in^urls. script-as-text-loading-with-caret.html:10
+
Modified: trunk/Source/WebCore/ChangeLog (135722 => 135723)
--- trunk/Source/WebCore/ChangeLog 2012-11-26 15:42:01 UTC (rev 135722)
[webkit-changes] [135724] trunk/Source/WTF
Title: [135724] trunk/Source/WTF Revision 135724 Author par...@webkit.org Date 2012-11-26 07:47:01 -0800 (Mon, 26 Nov 2012) Log Message Build fix for WinCE after r135640. * wtf/DataLog.cpp: Modified Paths trunk/Source/WTF/ChangeLog trunk/Source/WTF/wtf/DataLog.cpp Diff Modified: trunk/Source/WTF/ChangeLog (135723 => 135724) --- trunk/Source/WTF/ChangeLog 2012-11-26 15:46:41 UTC (rev 135723) +++ trunk/Source/WTF/ChangeLog 2012-11-26 15:47:01 UTC (rev 135724) @@ -1,3 +1,9 @@ +2012-11-26 Patrick Gansterer par...@webkit.org + +Build fix for WinCE after r135640. + +* wtf/DataLog.cpp: + 2012-11-24 Adam Barth aba...@webkit.org Chromium should use TCMalloc on Mac to go fast Modified: trunk/Source/WTF/wtf/DataLog.cpp (135723 => 135724) --- trunk/Source/WTF/wtf/DataLog.cpp 2012-11-26 15:46:41 UTC (rev 135723) +++ trunk/Source/WTF/wtf/DataLog.cpp 2012-11-26 15:47:01 UTC (rev 135724) @@ -29,6 +29,12 @@ #include wtf/FilePrintStream.h #include wtf/Threading.h +#if OS(WINCE) +#ifndef _IONBF +#define _IONBF 0x0004 +#endif +#endif + #define DATA_LOG_TO_FILE 0 // Uncomment to force logging to the given file regardless of what the environment variable says. ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [135725] trunk/LayoutTests
Title: [135725] trunk/LayoutTests Revision 135725 Author ju...@google.com Date 2012-11-26 07:51:38 -0800 (Mon, 26 Nov 2012) Log Message New baselines for test fast/backgrounds/gradient-background-leakage-2.html https://bugs.webkit.org/show_bug.cgi?id=103089 Unreviewed * platform/chromium-linux/fast/backgrounds/gradient-background-leakage-2-expected.png: Added. * platform/chromium-mac/fast/backgrounds/gradient-background-leakage-2-expected.png: Added. * platform/chromium-win/fast/backgrounds/gradient-background-leakage-2-expected.png: Added. * platform/chromium/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/TestExpectations Added Paths trunk/LayoutTests/platform/chromium-linux/fast/backgrounds/gradient-background-leakage-2-expected.png trunk/LayoutTests/platform/chromium-mac/fast/backgrounds/gradient-background-leakage-2-expected.png trunk/LayoutTests/platform/chromium-win/fast/backgrounds/gradient-background-leakage-2-expected.png Diff Modified: trunk/LayoutTests/ChangeLog (135724 => 135725) --- trunk/LayoutTests/ChangeLog 2012-11-26 15:47:01 UTC (rev 135724) +++ trunk/LayoutTests/ChangeLog 2012-11-26 15:51:38 UTC (rev 135725) @@ -1,3 +1,15 @@ +2012-11-26 Justin Novosad ju...@google.com + +New baselines for test fast/backgrounds/gradient-background-leakage-2.html +https://bugs.webkit.org/show_bug.cgi?id=103089 + +Unreviewed + +* platform/chromium-linux/fast/backgrounds/gradient-background-leakage-2-expected.png: Added. +* platform/chromium-mac/fast/backgrounds/gradient-background-leakage-2-expected.png: Added. +* platform/chromium-win/fast/backgrounds/gradient-background-leakage-2-expected.png: Added. +* platform/chromium/TestExpectations: + 2012-11-26 Mike West mk...@chromium.org Web Inspector: URLs containing '^' are improperly linked in console messages. Modified: trunk/LayoutTests/platform/chromium/TestExpectations (135724 => 135725) --- trunk/LayoutTests/platform/chromium/TestExpectations 2012-11-26 15:47:01 UTC (rev 135724) +++ trunk/LayoutTests/platform/chromium/TestExpectations 2012-11-26 15:51:38 UTC (rev 135725) @@ -2163,9 +2163,6 @@ crbug.com/117597 svg/batik/filters/feTile.svg [ ImageOnlyFailure ] -# Test needing new baselines -webkit.org/b/103089 fast/backgrounds/gradient-background-leakage-2.html [ Pass Missing ImageOnlyFailure Failure ] - # Caused by http://trac.webkit.org/changeset/56394. crbug.com/143475 [ Win ] http/tests/xmlhttprequest/xmlhttprequest-50ms-download-dispatch.html [ Failure Pass Timeout ] Added: trunk/LayoutTests/platform/chromium-linux/fast/backgrounds/gradient-background-leakage-2-expected.png (Binary files differ) Property changes on: trunk/LayoutTests/platform/chromium-linux/fast/backgrounds/gradient-background-leakage-2-expected.png ___ Added: svn:mime-type Added: trunk/LayoutTests/platform/chromium-mac/fast/backgrounds/gradient-background-leakage-2-expected.png (Binary files differ) Property changes on: trunk/LayoutTests/platform/chromium-mac/fast/backgrounds/gradient-background-leakage-2-expected.png ___ Added: svn:mime-type Added: trunk/LayoutTests/platform/chromium-win/fast/backgrounds/gradient-background-leakage-2-expected.png (Binary files differ) Property changes on: trunk/LayoutTests/platform/chromium-win/fast/backgrounds/gradient-background-leakage-2-expected.png ___ Added: svn:mime-type ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [135726] trunk/LayoutTests
Title: [135726] trunk/LayoutTests
Revision 135726
Author ju...@google.com
Date 2012-11-26 08:02:11 -0800 (Mon, 26 Nov 2012)
Log Message
New baselines for test fast/backgrounds/background-opaque-images-over-color.html
https://bugs.webkit.org/show_bug.cgi?id=102557
Unreviewed
* fast/backgrounds/background-opaque-images-over-color-expected.txt:
* platform/chromium-mac/fast/backgrounds/background-opaque-images-over-color-expected.png: Added.
* platform/chromium-win/fast/backgrounds/background-opaque-images-over-color-expected.png: Added.
* platform/chromium/TestExpectations:
* platform/mac/TestExpectations:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/backgrounds/background-opaque-images-over-color-expected.txt
trunk/LayoutTests/platform/chromium/TestExpectations
trunk/LayoutTests/platform/mac/TestExpectations
Added Paths
trunk/LayoutTests/platform/chromium-mac/fast/backgrounds/background-opaque-images-over-color-expected.png
trunk/LayoutTests/platform/chromium-win/fast/backgrounds/background-opaque-images-over-color-expected.png
Diff
Modified: trunk/LayoutTests/ChangeLog (135725 => 135726)
--- trunk/LayoutTests/ChangeLog 2012-11-26 15:51:38 UTC (rev 135725)
+++ trunk/LayoutTests/ChangeLog 2012-11-26 16:02:11 UTC (rev 135726)
@@ -1,5 +1,18 @@
2012-11-26 Justin Novosad ju...@google.com
+New baselines for test fast/backgrounds/background-opaque-images-over-color.html
+https://bugs.webkit.org/show_bug.cgi?id=102557
+
+Unreviewed
+
+* fast/backgrounds/background-opaque-images-over-color-expected.txt:
+* platform/chromium-mac/fast/backgrounds/background-opaque-images-over-color-expected.png: Added.
+* platform/chromium-win/fast/backgrounds/background-opaque-images-over-color-expected.png: Added.
+* platform/chromium/TestExpectations:
+* platform/mac/TestExpectations:
+
+2012-11-26 Justin Novosad ju...@google.com
+
New baselines for test fast/backgrounds/gradient-background-leakage-2.html
https://bugs.webkit.org/show_bug.cgi?id=103089
Modified: trunk/LayoutTests/fast/backgrounds/background-opaque-images-over-color-expected.txt (135725 => 135726)
--- trunk/LayoutTests/fast/backgrounds/background-opaque-images-over-color-expected.txt 2012-11-26 15:51:38 UTC (rev 135725)
+++ trunk/LayoutTests/fast/backgrounds/background-opaque-images-over-color-expected.txt 2012-11-26 16:02:11 UTC (rev 135726)
@@ -14,19 +14,14 @@
RenderBlock (floating) {DIV} at (140,0) size 20x100 [bgcolor=#FF]
RenderBlock (floating) {DIV} at (160,0) size 20x100 [bgcolor=#FF]
RenderBlock (floating) {DIV} at (180,0) size 20x100 [bgcolor=#FF]
-layer at (0,0) size 800x600
- RenderView at (0,0) size 800x600
-layer at (0,0) size 800x108
- RenderBlock {HTML} at (0,0) size 800x108
-RenderBody {BODY} at (8,8) size 784x0
RenderBlock {DIV} at (0,0) size 784x0
-RenderBlock (floating) {DIV} at (0,0) size 20x100 [bgcolor=#FF]
-RenderBlock (floating) {DIV} at (20,0) size 20x100 [bgcolor=#FF]
-RenderBlock (floating) {DIV} at (40,0) size 20x100 [bgcolor=#FF]
-RenderBlock (floating) {DIV} at (60,0) size 20x100 [bgcolor=#FF]
-RenderBlock (floating) {DIV} at (80,0) size 20x100 [bgcolor=#FF]
-RenderBlock (floating) {DIV} at (100,0) size 20x100 [bgcolor=#FF]
-RenderBlock (floating) {DIV} at (120,0) size 20x100 [bgcolor=#FF]
-RenderBlock (floating) {DIV} at (140,0) size 20x100 [bgcolor=#FF]
-RenderBlock (floating) {DIV} at (160,0) size 20x100 [bgcolor=#FF]
-RenderBlock (floating) {DIV} at (180,0) size 20x100 [bgcolor=#FF]
+RenderBlock (floating) {DIV} at (200,0) size 20x100 [bgcolor=#FF]
+RenderBlock (floating) {DIV} at (220,0) size 20x100 [bgcolor=#FF]
+RenderBlock (floating) {DIV} at (240,0) size 20x100 [bgcolor=#FF]
+RenderBlock (floating) {DIV} at (260,0) size 20x100 [bgcolor=#FF]
+RenderBlock (floating) {DIV} at (280,0) size 20x100 [bgcolor=#FF]
+RenderBlock (floating) {DIV} at (300,0) size 20x100 [bgcolor=#FF]
+RenderBlock (floating) {DIV} at (320,0) size 20x100 [bgcolor=#FF]
+RenderBlock (floating) {DIV} at (340,0) size 20x100 [bgcolor=#FF]
+RenderBlock (floating) {DIV} at (360,0) size 20x100 [bgcolor=#FF]
+RenderBlock (floating) {DIV} at (380,0) size 20x100 [bgcolor=#FF]
Modified: trunk/LayoutTests/platform/chromium/TestExpectations (135725 => 135726)
--- trunk/LayoutTests/platform/chromium/TestExpectations 2012-11-26 15:51:38 UTC (rev 135725)
+++ trunk/LayoutTests/platform/chromium/TestExpectations 2012-11-26 16:02:11 UTC (rev 135726)
@@ -1266,9 +1266,6 @@
webkit.org/b/60118 [ Mac ] svg/dom/SVGScriptElement/script-set-href.svg [ Failure Pass ]
-# New test in need of new baselines
-webkit.org/b/102557
[webkit-changes] [135727] trunk/LayoutTests
Title: [135727] trunk/LayoutTests Revision 135727 Author rjkro...@chromium.org Date 2012-11-26 08:12:47 -0800 (Mon, 26 Nov 2012) Log Message Unreviewed gardening: added TestExpecations failures for media/remove-from-document.html https://bugs.webkit.org/show_bug.cgi?id=103093 * platform/chromium/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (135726 => 135727) --- trunk/LayoutTests/ChangeLog 2012-11-26 16:02:11 UTC (rev 135726) +++ trunk/LayoutTests/ChangeLog 2012-11-26 16:12:47 UTC (rev 135727) @@ -1,3 +1,11 @@ +2012-11-26 Robert Kroeger rjkro...@chromium.org + +Unreviewed gardening: added TestExpecations failures for +media/remove-from-document.html +https://bugs.webkit.org/show_bug.cgi?id=103093 + +* platform/chromium/TestExpectations: + 2012-11-26 Justin Novosad ju...@google.com New baselines for test fast/backgrounds/background-opaque-images-over-color.html Modified: trunk/LayoutTests/platform/chromium/TestExpectations (135726 => 135727) --- trunk/LayoutTests/platform/chromium/TestExpectations 2012-11-26 16:02:11 UTC (rev 135726) +++ trunk/LayoutTests/platform/chromium/TestExpectations 2012-11-26 16:12:47 UTC (rev 135727) @@ -4246,3 +4246,4 @@ webkit.org/b/103148 [ Linux Win Mac ] svg/batik/text/textPosition2.svg [ ImageOnlyFailure ] webkit.org/b/103181 [ Win7 ] http/tests/local/drag-over-remote-content.html [ Pass Crash Timeout ] webkit.org/b/103183 [ Win7 SnowLeopard ] media/video-seek-past-end-playing.html [ Pass Crash ] +webkit.org/b/103093 [ Lion SnowLeopard ] media/remove-from-document.html [ Crash Pass ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [135728] trunk
Title: [135728] trunk
Revision 135728
Author commit-qu...@webkit.org
Date 2012-11-26 08:22:31 -0800 (Mon, 26 Nov 2012)
Log Message
Viewport CSS rules should not clamp values like Viewport META
https://bugs.webkit.org/show_bug.cgi?id=103068
Patch by Thiago Marcos P. Santos thiago.san...@intel.com on 2012-11-26
Reviewed by Kenneth Rohde Christiansen.
Source/WebCore:
CSS Device Adaption does not clamp the length and zoom values the
same way as the Viewport META. In fact, they are not clamped at all,
but instead, we just make sure that length values are at least 1px.
Tests: css3/device-adapt/opera/constrain-018.xhtml
css3/device-adapt/opera/constrain-019.xhtml
css3/device-adapt/opera/constrain-023.xhtml
css3/device-adapt/opera/constrain-024.xhtml
* dom/ViewportArguments.cpp:
(WebCore::ViewportArguments::resolve):
LayoutTests:
Imported Opera tests that makes sure we are doing the clamping right.
* css3/device-adapt/opera/constrain-018-expected.txt: Added.
* css3/device-adapt/opera/constrain-018.xhtml: Added.
* css3/device-adapt/opera/constrain-019-expected.txt: Added.
* css3/device-adapt/opera/constrain-019.xhtml: Added.
* css3/device-adapt/opera/constrain-023-expected.txt: Added.
* css3/device-adapt/opera/constrain-023.xhtml: Added.
* css3/device-adapt/opera/constrain-024-expected.txt: Added.
* css3/device-adapt/opera/constrain-024.xhtml: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/ViewportArguments.cpp
Added Paths
trunk/LayoutTests/css3/device-adapt/opera/constrain-018-expected.txt
trunk/LayoutTests/css3/device-adapt/opera/constrain-018.xhtml
trunk/LayoutTests/css3/device-adapt/opera/constrain-019-expected.txt
trunk/LayoutTests/css3/device-adapt/opera/constrain-019.xhtml
trunk/LayoutTests/css3/device-adapt/opera/constrain-023-expected.txt
trunk/LayoutTests/css3/device-adapt/opera/constrain-023.xhtml
trunk/LayoutTests/css3/device-adapt/opera/constrain-024-expected.txt
trunk/LayoutTests/css3/device-adapt/opera/constrain-024.xhtml
Diff
Modified: trunk/LayoutTests/ChangeLog (135727 => 135728)
--- trunk/LayoutTests/ChangeLog 2012-11-26 16:12:47 UTC (rev 135727)
+++ trunk/LayoutTests/ChangeLog 2012-11-26 16:22:31 UTC (rev 135728)
@@ -1,3 +1,21 @@
+2012-11-26 Thiago Marcos P. Santos thiago.san...@intel.com
+
+Viewport CSS rules should not clamp values like Viewport META
+https://bugs.webkit.org/show_bug.cgi?id=103068
+
+Reviewed by Kenneth Rohde Christiansen.
+
+Imported Opera tests that makes sure we are doing the clamping right.
+
+* css3/device-adapt/opera/constrain-018-expected.txt: Added.
+* css3/device-adapt/opera/constrain-018.xhtml: Added.
+* css3/device-adapt/opera/constrain-019-expected.txt: Added.
+* css3/device-adapt/opera/constrain-019.xhtml: Added.
+* css3/device-adapt/opera/constrain-023-expected.txt: Added.
+* css3/device-adapt/opera/constrain-023.xhtml: Added.
+* css3/device-adapt/opera/constrain-024-expected.txt: Added.
+* css3/device-adapt/opera/constrain-024.xhtml: Added.
+
2012-11-26 Robert Kroeger rjkro...@chromium.org
Unreviewed gardening: added TestExpecations failures for
Added: trunk/LayoutTests/css3/device-adapt/opera/constrain-018-expected.txt (0 => 135728)
--- trunk/LayoutTests/css3/device-adapt/opera/constrain-018-expected.txt (rev 0)
+++ trunk/LayoutTests/css3/device-adapt/opera/constrain-018-expected.txt 2012-11-26 16:22:31 UTC (rev 135728)
@@ -0,0 +1,3 @@
+
+PASS CSS Test: @viewport constrained - Small non-auto height not affecting width.
+
Added: trunk/LayoutTests/css3/device-adapt/opera/constrain-018.xhtml (0 => 135728)
--- trunk/LayoutTests/css3/device-adapt/opera/constrain-018.xhtml (rev 0)
+++ trunk/LayoutTests/css3/device-adapt/opera/constrain-018.xhtml 2012-11-26 16:22:31 UTC (rev 135728)
@@ -0,0 +1,84 @@
+?xml version=1.0 encoding=UTF-8?
+!DOCTYPE html PUBLIC -//W3C//DTD XHTML 1.0 Strict//EN http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd
+html xmlns=http://www.w3.org/1999/xhtml
+ head
+ titleCSS Test: @viewport constrained - Small non-auto height not affecting width./title
+ link rel=author title=Rune Lillesveen href=""
+ link rel=help href=""
+ meta name=flags content=visual scroll dom /
+ meta name=assert content=Non-auto height does not affect width if zoom is auto./
+ script src="" type=text/_javascript_ /
+ script src="" type=text/_javascript_ /
+ style type=text/css![CDATA[
+ body { margin: 0; }
+ html, body, #test { width: 100%; height: 100%; }
+ #log { padding: 1em; display: none; }
+ /* Reset viewport values to initial values to ignore UA stylesheet. */
+ @-webkit-viewport {
+width: auto;
+height: auto;
+zoom: auto;
+min-zoom: auto;
+max-zoom: auto;
+user-zoom: zoom;
+orientation: auto;
+resolution: auto;
+ }
+ ]]/style
+ style
[webkit-changes] [135729] trunk/Source/WebCore
Title: [135729] trunk/Source/WebCore
Revision 135729
Author stai...@webkit.org
Date 2012-11-26 08:32:31 -0800 (Mon, 26 Nov 2012)
Log Message
[BlackBerry] Remove a lot of unnecessary and incorrect code causing crashes
https://bugs.webkit.org/show_bug.cgi?id=103199
Reviewed by Yong Li.
This is the first big step to unforking this code. It's very close to
where it needs to be now, but the first step is to get rid of the
crashes by deleting code that isn't needed and makes bad assumptions
about object lifetime. Crashes were found by automation without
test case or reproduction steps.
* loader/blackberry/CookieJarBlackBerry.cpp:
(WebCore::cookies): delete most code
(WebCore::setCookies): delete most code
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/loader/blackberry/CookieJarBlackBerry.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (135728 => 135729)
--- trunk/Source/WebCore/ChangeLog 2012-11-26 16:22:31 UTC (rev 135728)
+++ trunk/Source/WebCore/ChangeLog 2012-11-26 16:32:31 UTC (rev 135729)
@@ -1,3 +1,20 @@
+2012-11-26 George Staikos stai...@webkit.org
+
+[BlackBerry] Remove a lot of unnecessary and incorrect code causing crashes
+https://bugs.webkit.org/show_bug.cgi?id=103199
+
+Reviewed by Yong Li.
+
+This is the first big step to unforking this code. It's very close to
+where it needs to be now, but the first step is to get rid of the
+crashes by deleting code that isn't needed and makes bad assumptions
+about object lifetime. Crashes were found by automation without
+test case or reproduction steps.
+
+* loader/blackberry/CookieJarBlackBerry.cpp:
+(WebCore::cookies): delete most code
+(WebCore::setCookies): delete most code
+
2012-11-26 Thiago Marcos P. Santos thiago.san...@intel.com
Viewport CSS rules should not clamp values like Viewport META
Modified: trunk/Source/WebCore/loader/blackberry/CookieJarBlackBerry.cpp (135728 => 135729)
--- trunk/Source/WebCore/loader/blackberry/CookieJarBlackBerry.cpp 2012-11-26 16:22:31 UTC (rev 135728)
+++ trunk/Source/WebCore/loader/blackberry/CookieJarBlackBerry.cpp 2012-11-26 16:32:31 UTC (rev 135729)
@@ -39,38 +39,15 @@
String cookies(Document const* document, KURL const url)
{
-Frame* frame = document-frame();
-Page* page = frame ? frame-page() : 0;
-
-if (!page)
-return String();
-
-if (!(frame frame-loader() frame-loader()-client()))
-return String();
-
-if (!static_castFrameLoaderClientBlackBerry*(frame-loader()-client())-cookiesEnabled())
-return String();
-
-ASSERT(document url == document-cookieURL());
// 'HttpOnly' cookies should no be accessible from scripts, so we filter them out here
return cookieManager().getCookie(url, NoHttpOnlyCookie);
}
void setCookies(Document* document, KURL const url, String const value)
{
-Frame* frame = document-frame();
-Page* page = frame ? frame-page() : 0;
-
-if (!page)
+if (!document-settings()-cookieEnabled())
return;
-if (!(frame frame-loader() frame-loader()-client()))
-return;
-
-if (!static_castFrameLoaderClientBlackBerry*(frame-loader()-client())-cookiesEnabled())
-return;
-
-ASSERT(document url == document-cookieURL());
cookieManager().setCookies(url, value, NoHttpOnlyCookie);
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [135730] trunk/LayoutTests
Title: [135730] trunk/LayoutTests
Revision 135730
Author commit-qu...@webkit.org
Date 2012-11-26 08:37:38 -0800 (Mon, 26 Nov 2012)
Log Message
Import more CSS Device Adaptation layout tests
https://bugs.webkit.org/show_bug.cgi?id=95967
Patch by Thiago Marcos P. Santos thiago.san...@intel.com on 2012-11-26
Reviewed by Kenneth Rohde Christiansen.
And these are the remaining test from the Opera's CSS
Device Adaptation test suite.
* css3/device-adapt/opera/constrain-021-expected.txt: Added.
* css3/device-adapt/opera/constrain-021.xhtml: Added.
* css3/device-adapt/opera/constrain-022-expected.txt: Added.
* css3/device-adapt/opera/constrain-022.xhtml: Added.
* css3/device-adapt/opera/orientation-001-expected.txt: Added.
* css3/device-adapt/opera/orientation-001.xhtml: Added.
* css3/device-adapt/opera/orientation-002-expected.txt: Added.
* css3/device-adapt/opera/orientation-002.xhtml: Added.
* platform/efl-wk1/TestExpectations:
* platform/efl-wk2/TestExpectations:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/efl-wk1/TestExpectations
trunk/LayoutTests/platform/efl-wk2/TestExpectations
Added Paths
trunk/LayoutTests/css3/device-adapt/opera/constrain-021-expected.txt
trunk/LayoutTests/css3/device-adapt/opera/constrain-021.xhtml
trunk/LayoutTests/css3/device-adapt/opera/constrain-022-expected.txt
trunk/LayoutTests/css3/device-adapt/opera/constrain-022.xhtml
trunk/LayoutTests/css3/device-adapt/opera/orientation-001-expected.txt
trunk/LayoutTests/css3/device-adapt/opera/orientation-001.xhtml
trunk/LayoutTests/css3/device-adapt/opera/orientation-002-expected.txt
trunk/LayoutTests/css3/device-adapt/opera/orientation-002.xhtml
Diff
Modified: trunk/LayoutTests/ChangeLog (135729 => 135730)
--- trunk/LayoutTests/ChangeLog 2012-11-26 16:32:31 UTC (rev 135729)
+++ trunk/LayoutTests/ChangeLog 2012-11-26 16:37:38 UTC (rev 135730)
@@ -1,5 +1,26 @@
2012-11-26 Thiago Marcos P. Santos thiago.san...@intel.com
+Import more CSS Device Adaptation layout tests
+https://bugs.webkit.org/show_bug.cgi?id=95967
+
+Reviewed by Kenneth Rohde Christiansen.
+
+And these are the remaining test from the Opera's CSS
+Device Adaptation test suite.
+
+* css3/device-adapt/opera/constrain-021-expected.txt: Added.
+* css3/device-adapt/opera/constrain-021.xhtml: Added.
+* css3/device-adapt/opera/constrain-022-expected.txt: Added.
+* css3/device-adapt/opera/constrain-022.xhtml: Added.
+* css3/device-adapt/opera/orientation-001-expected.txt: Added.
+* css3/device-adapt/opera/orientation-001.xhtml: Added.
+* css3/device-adapt/opera/orientation-002-expected.txt: Added.
+* css3/device-adapt/opera/orientation-002.xhtml: Added.
+* platform/efl-wk1/TestExpectations:
+* platform/efl-wk2/TestExpectations:
+
+2012-11-26 Thiago Marcos P. Santos thiago.san...@intel.com
+
Viewport CSS rules should not clamp values like Viewport META
https://bugs.webkit.org/show_bug.cgi?id=103068
Added: trunk/LayoutTests/css3/device-adapt/opera/constrain-021-expected.txt (0 => 135730)
--- trunk/LayoutTests/css3/device-adapt/opera/constrain-021-expected.txt (rev 0)
+++ trunk/LayoutTests/css3/device-adapt/opera/constrain-021-expected.txt 2012-11-26 16:37:38 UTC (rev 135730)
@@ -0,0 +1,3 @@
+
+PASS CSS Test: @viewport constrained - width is device-width.
+
Added: trunk/LayoutTests/css3/device-adapt/opera/constrain-021.xhtml (0 => 135730)
--- trunk/LayoutTests/css3/device-adapt/opera/constrain-021.xhtml (rev 0)
+++ trunk/LayoutTests/css3/device-adapt/opera/constrain-021.xhtml 2012-11-26 16:37:38 UTC (rev 135730)
@@ -0,0 +1,84 @@
+?xml version=1.0 encoding=UTF-8?
+!DOCTYPE html PUBLIC -//W3C//DTD XHTML 1.0 Strict//EN http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd
+html xmlns=http://www.w3.org/1999/xhtml
+ head
+ titleCSS Test: @viewport constrained - width is device-width./title
+ link rel=author title=Rune Lillesveen href=""
+ link rel=help href=""
+ meta name=flags content=visual scroll dom /
+ meta name=assert content=When width is set to device-width, the device-width media feature will match when the actual viewport width is the value./
+ script src="" type=text/_javascript_ /
+ script src="" type=text/_javascript_ /
+ style type=text/css![CDATA[
+ body { margin: 0; }
+ html, body, #test { width: 100%; height: 100%; }
+ #log { padding: 1em; display: none; }
+ /* Reset viewport values to initial values to ignore UA stylesheet. */
+ @-webkit-viewport {
+width: auto;
+height: auto;
+zoom: auto;
+min-zoom: auto;
+max-zoom: auto;
+user-zoom: zoom;
+orientation: auto;
+resolution: auto;
+ }
+ ]]/style
+ style type=text/css![CDATA[
+ /* CSS for the test below. */
+ @-webkit-viewport { width: device-width }
+ /* Set root element font-size to something different from the initial
+
[webkit-changes] [135731] trunk/Source/WebCore
Title: [135731] trunk/Source/WebCore
Revision 135731
Author commit-qu...@webkit.org
Date 2012-11-26 08:40:24 -0800 (Mon, 26 Nov 2012)
Log Message
[EFL] Crashes in compositing layout tests with AC on.
https://bugs.webkit.org/show_bug.cgi?id=103144
Patch by Viatcheslav Ostapenko v.ostape...@samsung.com on 2012-11-26
Reviewed by Noam Rosenthal.
Application could leave texture packing parameters in non-zero state before
texture mapper drawing/texture uploading. To avoid crash texture upload should
specify packing parameters before each texture upload if packing is supported.
Covered by existing tests.
* platform/graphics/texmap/TextureMapperGL.cpp:
(WebCore::BitmapTextureGL::updateContentsNoSwizzle):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/texmap/TextureMapperGL.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (135730 => 135731)
--- trunk/Source/WebCore/ChangeLog 2012-11-26 16:37:38 UTC (rev 135730)
+++ trunk/Source/WebCore/ChangeLog 2012-11-26 16:40:24 UTC (rev 135731)
@@ -1,3 +1,19 @@
+2012-11-26 Viatcheslav Ostapenko v.ostape...@samsung.com
+
+[EFL] Crashes in compositing layout tests with AC on.
+https://bugs.webkit.org/show_bug.cgi?id=103144
+
+Reviewed by Noam Rosenthal.
+
+Application could leave texture packing parameters in non-zero state before
+texture mapper drawing/texture uploading. To avoid crash texture upload should
+specify packing parameters before each texture upload if packing is supported.
+
+Covered by existing tests.
+
+* platform/graphics/texmap/TextureMapperGL.cpp:
+(WebCore::BitmapTextureGL::updateContentsNoSwizzle):
+
2012-11-26 George Staikos stai...@webkit.org
[BlackBerry] Remove a lot of unnecessary and incorrect code causing crashes
Modified: trunk/Source/WebCore/platform/graphics/texmap/TextureMapperGL.cpp (135730 => 135731)
--- trunk/Source/WebCore/platform/graphics/texmap/TextureMapperGL.cpp 2012-11-26 16:37:38 UTC (rev 135730)
+++ trunk/Source/WebCore/platform/graphics/texmap/TextureMapperGL.cpp 2012-11-26 16:40:24 UTC (rev 135731)
@@ -691,21 +691,21 @@
void BitmapTextureGL::updateContentsNoSwizzle(const void* srcData, const IntRect targetRect, const IntPoint sourceOffset, int bytesPerLine, unsigned bytesPerPixel, Platform3DObject glFormat)
{
-if (!driverSupportsSubImage() // For ES drivers that don't support sub-images.
-|| (bytesPerLine == static_castint(targetRect.width() * bytesPerPixel) sourceOffset == IntPoint::zero())) {
-m_context3D-texSubImage2D(GraphicsContext3D::TEXTURE_2D, 0, targetRect.x(), targetRect.y(), targetRect.width(), targetRect.height(), glFormat, DEFAULT_TEXTURE_PIXEL_TRANSFER_TYPE, srcData);
-return;
+#if !defined(TEXMAP_OPENGL_ES_2)
+if (driverSupportsSubImage()) { // For ES drivers that don't support sub-images.
+// Use the OpenGL sub-image extension, now that we know it's available.
+m_context3D-pixelStorei(GL_UNPACK_ROW_LENGTH, bytesPerLine / bytesPerPixel);
+m_context3D-pixelStorei(GL_UNPACK_SKIP_ROWS, sourceOffset.y());
+m_context3D-pixelStorei(GL_UNPACK_SKIP_PIXELS, sourceOffset.x());
}
-
+#endif
+m_context3D-texSubImage2D(GraphicsContext3D::TEXTURE_2D, 0, targetRect.x(), targetRect.y(), targetRect.width(), targetRect.height(), glFormat, DEFAULT_TEXTURE_PIXEL_TRANSFER_TYPE, srcData);
#if !defined(TEXMAP_OPENGL_ES_2)
-// Use the OpenGL sub-image extension, now that we know it's available.
-m_context3D-pixelStorei(GL_UNPACK_ROW_LENGTH, bytesPerLine / bytesPerPixel);
-m_context3D-pixelStorei(GL_UNPACK_SKIP_ROWS, sourceOffset.y());
-m_context3D-pixelStorei(GL_UNPACK_SKIP_PIXELS, sourceOffset.x());
-m_context3D-texSubImage2D(GraphicsContext3D::TEXTURE_2D, 0, targetRect.x(), targetRect.y(), targetRect.width(), targetRect.height(), glFormat, DEFAULT_TEXTURE_PIXEL_TRANSFER_TYPE, srcData);
-m_context3D-pixelStorei(GL_UNPACK_ROW_LENGTH, 0);
-m_context3D-pixelStorei(GL_UNPACK_SKIP_ROWS, 0);
-m_context3D-pixelStorei(GL_UNPACK_SKIP_PIXELS, 0);
+if (driverSupportsSubImage()) { // For ES drivers that don't support sub-images.
+m_context3D-pixelStorei(GL_UNPACK_ROW_LENGTH, 0);
+m_context3D-pixelStorei(GL_UNPACK_SKIP_ROWS, 0);
+m_context3D-pixelStorei(GL_UNPACK_SKIP_PIXELS, 0);
+}
#endif
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [135732] trunk/Source/WebCore
Title: [135732] trunk/Source/WebCore Revision 135732 Author pfeld...@chromium.org Date 2012-11-26 08:50:10 -0800 (Mon, 26 Nov 2012) Log Message Not reviewed: follow up for r135720, fixing node highlight. * inspector/InspectorOverlayPage.html: Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/inspector/InspectorOverlayPage.html Diff Modified: trunk/Source/WebCore/ChangeLog (135731 => 135732) --- trunk/Source/WebCore/ChangeLog 2012-11-26 16:40:24 UTC (rev 135731) +++ trunk/Source/WebCore/ChangeLog 2012-11-26 16:50:10 UTC (rev 135732) @@ -1,3 +1,9 @@ +2012-11-26 'Pavel Feldman' pfeld...@chromium.org + +Not reviewed: follow up for r135720, fixing node highlight. + +* inspector/InspectorOverlayPage.html: + 2012-11-26 Viatcheslav Ostapenko v.ostape...@samsung.com [EFL] Crashes in compositing layout tests with AC on. Modified: trunk/Source/WebCore/inspector/InspectorOverlayPage.html (135731 => 135732) --- trunk/Source/WebCore/inspector/InspectorOverlayPage.html 2012-11-26 16:40:24 UTC (rev 135731) +++ trunk/Source/WebCore/inspector/InspectorOverlayPage.html 2012-11-26 16:50:10 UTC (rev 135732) @@ -344,9 +344,9 @@ document.getElementById(tag-name).textContent = elementInfo.tagName; document.getElementById(node-id).textContent = elementInfo.idValue ? # + elementInfo.idValue : ; var className = elementInfo.className; -if (className.length 50) +if (className className.length 50) className = className.substring(0, 50) + \u2026; -document.getElementById(class-name).textContent = className; +document.getElementById(class-name).textContent = className || ; document.getElementById(node-width).textContent = elementInfo.nodeWidth; document.getElementById(node-height).textContent = elementInfo.nodeHeight; var elementTitle = document.getElementById(element-title); ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [135734] trunk/Source/WebCore
Title: [135734] trunk/Source/WebCore Revision 135734 Author commit-qu...@webkit.org Date 2012-11-26 09:33:28 -0800 (Mon, 26 Nov 2012) Log Message Remove redundant assignment in TextureMapperLayer::flushCompositingStateSelf https://bugs.webkit.org/show_bug.cgi?id=103233 Patch by Jae Hyun Park jae.p...@company100.net on 2012-11-26 Reviewed by Noam Rosenthal. This patch removes redundant assignment in TextureMapperLayer::flushCompositingStateSelf. No new tests, because no change in bahavior. * platform/graphics/texmap/TextureMapperLayer.cpp: (WebCore::TextureMapperLayer::flushCompositingStateSelf): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/platform/graphics/texmap/TextureMapperLayer.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (135733 => 135734) --- trunk/Source/WebCore/ChangeLog 2012-11-26 17:18:25 UTC (rev 135733) +++ trunk/Source/WebCore/ChangeLog 2012-11-26 17:33:28 UTC (rev 135734) @@ -1,3 +1,17 @@ +2012-11-26 Jae Hyun Park jae.p...@company100.net + +Remove redundant assignment in TextureMapperLayer::flushCompositingStateSelf +https://bugs.webkit.org/show_bug.cgi?id=103233 + +Reviewed by Noam Rosenthal. + +This patch removes redundant assignment in TextureMapperLayer::flushCompositingStateSelf. + +No new tests, because no change in bahavior. + +* platform/graphics/texmap/TextureMapperLayer.cpp: +(WebCore::TextureMapperLayer::flushCompositingStateSelf): + 2012-11-26 Tamas Czene tcz...@inf.u-szeged.hu OpenCL version of SourceAlpha, SourceGraphics and FETurbulence filter effects Modified: trunk/Source/WebCore/platform/graphics/texmap/TextureMapperLayer.cpp (135733 => 135734) --- trunk/Source/WebCore/platform/graphics/texmap/TextureMapperLayer.cpp 2012-11-26 17:18:25 UTC (rev 135733) +++ trunk/Source/WebCore/platform/graphics/texmap/TextureMapperLayer.cpp 2012-11-26 17:33:28 UTC (rev 135734) @@ -418,7 +418,6 @@ m_state.pos = graphicsLayer-position(); m_state.anchorPoint = graphicsLayer-anchorPoint(); m_state.size = graphicsLayer-size(); -m_state.contentsRect = graphicsLayer-contentsRect(); m_state.transform = graphicsLayer-transform(); m_state.contentsRect = graphicsLayer-contentsRect(); m_state.preserves3D = graphicsLayer-preserves3D(); ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [135735] trunk/Source/WebKit/chromium
Title: [135735] trunk/Source/WebKit/chromium Revision 135735 Author r...@google.com Date 2012-11-26 09:43:46 -0800 (Mon, 26 Nov 2012) Log Message add SK_DISABLE_DITHER_32BIT_GRADIENT define, in preparation for rebaselining https://bugs.webkit.org/show_bug.cgi?id=103269 Reviewed by NOBODY. Unreviewed. No behavior change, as this define already exists on the chrome side in SkUserConfig.h * skia_webkit.gyp: Modified Paths trunk/Source/WebKit/chromium/ChangeLog trunk/Source/WebKit/chromium/skia_webkit.gyp Diff Modified: trunk/Source/WebKit/chromium/ChangeLog (135734 => 135735) --- trunk/Source/WebKit/chromium/ChangeLog 2012-11-26 17:33:28 UTC (rev 135734) +++ trunk/Source/WebKit/chromium/ChangeLog 2012-11-26 17:43:46 UTC (rev 135735) @@ -1,3 +1,14 @@ +2012-11-26 Mike Reed r...@google.com + +add SK_DISABLE_DITHER_32BIT_GRADIENT define, in preparation for rebaselining +https://bugs.webkit.org/show_bug.cgi?id=103269 + +Reviewed by NOBODY. Unreviewed. + +No behavior change, as this define already exists on the chrome side in SkUserConfig.h + +* skia_webkit.gyp: + 2012-11-26 Scott Violet s...@chromium.org [chromium] Make use_default_render_theme compile the right set of files Modified: trunk/Source/WebKit/chromium/skia_webkit.gyp (135734 => 135735) --- trunk/Source/WebKit/chromium/skia_webkit.gyp 2012-11-26 17:33:28 UTC (rev 135734) +++ trunk/Source/WebKit/chromium/skia_webkit.gyp 2012-11-26 17:43:46 UTC (rev 135735) @@ -39,6 +39,9 @@ 'defines': [ # Place defines here that require significant WebKit rebaselining, or that # are otherwise best removed in WebKit and then rolled into Chromium. + + # extracted from SkUserConfig.h, in preparation for rebaselining. + SK_DISABLE_DITHER_32BIT_GRADIENT, ], }, }, ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [135736] trunk/Source/WebKit/chromium
Title: [135736] trunk/Source/WebKit/chromium Revision 135736 Author rjkro...@chromium.org Date 2012-11-26 10:47:18 -0800 (Mon, 26 Nov 2012) Log Message Unreviewed, rolling out r135735. http://trac.webkit.org/changeset/135735 https://bugs.webkit.org/show_bug.cgi?id=103270 Caused breakage across the Chromium tree. (Requested by rjkroege_ on #webkit). Patch by Sheriff Bot webkit.review@gmail.com on 2012-11-26 * skia_webkit.gyp: Modified Paths trunk/Source/WebKit/chromium/ChangeLog trunk/Source/WebKit/chromium/skia_webkit.gyp Diff Modified: trunk/Source/WebKit/chromium/ChangeLog (135735 => 135736) --- trunk/Source/WebKit/chromium/ChangeLog 2012-11-26 17:43:46 UTC (rev 135735) +++ trunk/Source/WebKit/chromium/ChangeLog 2012-11-26 18:47:18 UTC (rev 135736) @@ -1,3 +1,14 @@ +2012-11-26 Sheriff Bot webkit.review@gmail.com + +Unreviewed, rolling out r135735. +http://trac.webkit.org/changeset/135735 +https://bugs.webkit.org/show_bug.cgi?id=103270 + +Caused breakage across the Chromium tree. (Requested by +rjkroege_ on #webkit). + +* skia_webkit.gyp: + 2012-11-26 Mike Reed r...@google.com add SK_DISABLE_DITHER_32BIT_GRADIENT define, in preparation for rebaselining Modified: trunk/Source/WebKit/chromium/skia_webkit.gyp (135735 => 135736) --- trunk/Source/WebKit/chromium/skia_webkit.gyp 2012-11-26 17:43:46 UTC (rev 135735) +++ trunk/Source/WebKit/chromium/skia_webkit.gyp 2012-11-26 18:47:18 UTC (rev 135736) @@ -39,9 +39,6 @@ 'defines': [ # Place defines here that require significant WebKit rebaselining, or that # are otherwise best removed in WebKit and then rolled into Chromium. - - # extracted from SkUserConfig.h, in preparation for rebaselining. - SK_DISABLE_DITHER_32BIT_GRADIENT, ], }, }, ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [135737] trunk/Source/WebCore
Title: [135737] trunk/Source/WebCore
Revision 135737
Author commit-qu...@webkit.org
Date 2012-11-26 10:49:54 -0800 (Mon, 26 Nov 2012)
Log Message
[Cairo] fillRectWithColor with Color::transparent doesn't perform anything
https://bugs.webkit.org/show_bug.cgi?id=101911
Patch by Hurnjoo Lee hurnjoo@samsung.com on 2012-11-26
Reviewed by Kenneth Rohde Christiansen.
fillRectWithColor with Color::transparent doesn't perform anything
because fillRectWithColor does early-return if the alpha value of
color is zero. But we expect that fill the rect with transparent color
in case the cairo_operator is CAIRO_OPERATOR_SOURCE.
Covered by existing tests.
* platform/graphics/cairo/GraphicsContextCairo.cpp:
(WebCore::fillRectWithColor):Add condition to prevent early-return if
cairo_operator is not CAIRO_OPERATOR_OVER
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/cairo/GraphicsContextCairo.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (135736 => 135737)
--- trunk/Source/WebCore/ChangeLog 2012-11-26 18:47:18 UTC (rev 135736)
+++ trunk/Source/WebCore/ChangeLog 2012-11-26 18:49:54 UTC (rev 135737)
@@ -1,3 +1,21 @@
+2012-11-26 Hurnjoo Lee hurnjoo@samsung.com
+
+[Cairo] fillRectWithColor with Color::transparent doesn't perform anything
+https://bugs.webkit.org/show_bug.cgi?id=101911
+
+Reviewed by Kenneth Rohde Christiansen.
+
+fillRectWithColor with Color::transparent doesn't perform anything
+because fillRectWithColor does early-return if the alpha value of
+color is zero. But we expect that fill the rect with transparent color
+in case the cairo_operator is CAIRO_OPERATOR_SOURCE.
+
+Covered by existing tests.
+
+* platform/graphics/cairo/GraphicsContextCairo.cpp:
+(WebCore::fillRectWithColor):Add condition to prevent early-return if
+cairo_operator is not CAIRO_OPERATOR_OVER
+
2012-11-26 Jae Hyun Park jae.p...@company100.net
Remove redundant assignment in TextureMapperLayer::flushCompositingStateSelf
Modified: trunk/Source/WebCore/platform/graphics/cairo/GraphicsContextCairo.cpp (135736 => 135737)
--- trunk/Source/WebCore/platform/graphics/cairo/GraphicsContextCairo.cpp 2012-11-26 18:47:18 UTC (rev 135736)
+++ trunk/Source/WebCore/platform/graphics/cairo/GraphicsContextCairo.cpp 2012-11-26 18:49:54 UTC (rev 135737)
@@ -70,7 +70,7 @@
// A helper which quickly fills a rectangle with a simple color fill.
static inline void fillRectWithColor(cairo_t* cr, const FloatRect rect, const Color color)
{
-if (!color.alpha())
+if (!color.alpha() cairo_get_operator(cr) == CAIRO_OPERATOR_OVER)
return;
setSourceRGBAFromColor(cr, color);
cairo_rectangle(cr, rect.x(), rect.y(), rect.width(), rect.height());
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [135739] trunk/Tools
Title: [135739] trunk/Tools Revision 135739 Author zandober...@gmail.com Date 2012-11-26 10:56:22 -0800 (Mon, 26 Nov 2012) Log Message Coverage testing in webkitpy should omit some paths https://bugs.webkit.org/show_bug.cgi?id=103267 Reviewed by Dirk Pranke. Omit testing coverage of any file under /usr directory and any file that is of third party origin and was autoinstalled. * Scripts/webkitpy/test/main.py: (Tester._run_tests): Modified Paths trunk/Tools/ChangeLog trunk/Tools/Scripts/webkitpy/test/main.py Diff Modified: trunk/Tools/ChangeLog (135738 => 135739) --- trunk/Tools/ChangeLog 2012-11-26 18:54:50 UTC (rev 135738) +++ trunk/Tools/ChangeLog 2012-11-26 18:56:22 UTC (rev 135739) @@ -1,3 +1,16 @@ +2012-11-26 Zan Dobersek zandober...@gmail.com + +Coverage testing in webkitpy should omit some paths +https://bugs.webkit.org/show_bug.cgi?id=103267 + +Reviewed by Dirk Pranke. + +Omit testing coverage of any file under /usr directory and any file +that is of third party origin and was autoinstalled. + +* Scripts/webkitpy/test/main.py: +(Tester._run_tests): + 2012-11-26 Jaehun Lim ljaehun@samsung.com Text Autosizing: Add Text Autosizing APIs for WK2 Modified: trunk/Tools/Scripts/webkitpy/test/main.py (135738 => 135739) --- trunk/Tools/Scripts/webkitpy/test/main.py 2012-11-26 18:54:50 UTC (rev 135738) +++ trunk/Tools/Scripts/webkitpy/test/main.py 2012-11-26 18:56:22 UTC (rev 135739) @@ -139,7 +139,7 @@ self._options.child_processes = 1 import webkitpy.thirdparty.autoinstalled.coverage as coverage -cov = coverage.coverage() +cov = coverage.coverage(omit=[/usr/*, */webkitpy/thirdparty/autoinstalled/*]) cov.start() self.printer.write_update(Checking imports ...) ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [135740] trunk
Title: [135740] trunk
Revision 135740
Author infe...@chromium.org
Date 2012-11-26 10:58:27 -0800 (Mon, 26 Nov 2012)
Log Message
Crash in Frame::dispatchVisibilityStateChangeEvent.
https://bugs.webkit.org/show_bug.cgi?id=102053
Reviewed by Adam Barth.
Source/WebCore:
Child frame can go away inside webkitvisibilitychange
event handler. Store it in a ref counted vector.
Test: fast/frames/page-visibility-crash.html
* page/Frame.cpp:
(WebCore::Frame::dispatchVisibilityStateChangeEvent):
LayoutTests:
* fast/frames/page-visibility-crash-expected.txt: Added.
* fast/frames/page-visibility-crash.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/Frame.cpp
Added Paths
trunk/LayoutTests/fast/frames/page-visibility-crash-expected.txt
trunk/LayoutTests/fast/frames/page-visibility-crash.html
Diff
Modified: trunk/LayoutTests/ChangeLog (135739 => 135740)
--- trunk/LayoutTests/ChangeLog 2012-11-26 18:56:22 UTC (rev 135739)
+++ trunk/LayoutTests/ChangeLog 2012-11-26 18:58:27 UTC (rev 135740)
@@ -1,3 +1,13 @@
+2012-11-26 Abhishek Arya infe...@chromium.org
+
+Crash in Frame::dispatchVisibilityStateChangeEvent.
+https://bugs.webkit.org/show_bug.cgi?id=102053
+
+Reviewed by Adam Barth.
+
+* fast/frames/page-visibility-crash-expected.txt: Added.
+* fast/frames/page-visibility-crash.html: Added.
+
2012-11-26 Thiago Marcos P. Santos thiago.san...@intel.com
Import more CSS Device Adaptation layout tests
Added: trunk/LayoutTests/fast/frames/page-visibility-crash-expected.txt (0 => 135740)
--- trunk/LayoutTests/fast/frames/page-visibility-crash-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/frames/page-visibility-crash-expected.txt 2012-11-26 18:58:27 UTC (rev 135740)
@@ -0,0 +1 @@
+PASS. WebKit didn't crash
Added: trunk/LayoutTests/fast/frames/page-visibility-crash.html (0 => 135740)
--- trunk/LayoutTests/fast/frames/page-visibility-crash.html (rev 0)
+++ trunk/LayoutTests/fast/frames/page-visibility-crash.html 2012-11-26 18:58:27 UTC (rev 135740)
@@ -0,0 +1,46 @@
+!DOCTYPE html
+html
+body
+script
+if (window.testRunner) {
+window.testRunner.dumpAsText();
+window.testRunner.waitUntilDone();
+}
+
+function finish() {
+if (window.testRunner)
+testRunner.resetPageVisibility();
+
+document.open();
+document.write(PASS. WebKit didn't crash);
+document.close();
+
+if (window.testRunner)
+testRunner.notifyDone();
+}
+
+function crash()
+{
+document.body.removeChild(document.getElementById(f));
+setTimeout(finish(), 0);
+}
+
+frame = document.createElement(iframe);
+frame.id = f;
+document.body.appendChild(frame);
+scriptElement = frame.contentDocument.createElement(script);
+frame.contentDocument.body.appendChild(scriptElement);
+scriptElement.innerText = function handleVisibilityChange() \
+ { \
+ parent.crash(); \
+ } \
+ document.addEventListener('webkitvisibilitychange', handleVisibilityChange, false);;
+
+if (window.testRunner)
+testRunner.setPageVisibility(hidden);
+
+// Many platforms don't support the page visibility api. For those, just bail out.
+setTimeout(finish(), 10);
+/script
+/body
+/html
Property changes on: trunk/LayoutTests/fast/frames/page-visibility-crash.html
___
Added: svn:executable
Modified: trunk/Source/WebCore/ChangeLog (135739 => 135740)
--- trunk/Source/WebCore/ChangeLog 2012-11-26 18:56:22 UTC (rev 135739)
+++ trunk/Source/WebCore/ChangeLog 2012-11-26 18:58:27 UTC (rev 135740)
@@ -1,3 +1,18 @@
+2012-11-26 Abhishek Arya infe...@chromium.org
+
+Crash in Frame::dispatchVisibilityStateChangeEvent.
+https://bugs.webkit.org/show_bug.cgi?id=102053
+
+Reviewed by Adam Barth.
+
+Child frame can go away inside webkitvisibilitychange
+event handler. Store it in a ref counted vector.
+
+Test: fast/frames/page-visibility-crash.html
+
+* page/Frame.cpp:
+(WebCore::Frame::dispatchVisibilityStateChangeEvent):
+
2012-11-26 Hurnjoo Lee hurnjoo@samsung.com
[Cairo] fillRectWithColor with Color::transparent doesn't perform anything
Modified: trunk/Source/WebCore/page/Frame.cpp (135739 => 135740)
--- trunk/Source/WebCore/page/Frame.cpp 2012-11-26 18:56:22 UTC (rev 135739)
+++ trunk/Source/WebCore/page/Frame.cpp 2012-11-26 18:58:27 UTC (rev 135740)
@@ -657,8 +657,13 @@
{
if (m_doc)
m_doc-dispatchVisibilityStateChangeEvent();
+
+VectorRefPtrFrame childFrames;
for (Frame* child = tree()-firstChild(); child; child = child-tree()-nextSibling())
-child-dispatchVisibilityStateChangeEvent();
+childFrames.append(child);
+
+for (size_t i = 0; i childFrames.size(); ++i)
+
[webkit-changes] [135741] trunk
Title: [135741] trunk
Revision 135741
Author jchaffr...@webkit.org
Date 2012-11-26 11:07:20 -0800 (Mon, 26 Nov 2012)
Log Message
RenderBox::computePercentageLogicalHeight should use containingBlockLogicalWidthForContent
https://bugs.webkit.org/show_bug.cgi?id=103075
Reviewed by Ojan Vafai.
Source/WebCore:
Using the containing block's content logical block was working for most renderers but 2 renderers
were special and were broken in orthogonal writing modes:
- captions as they override containingBlockLogicalWidthForContent to return the table's logical width.
- multi-column renderers as they override availableLogicalWidth to constrain the child to the column logical width.
By switching to containingBlockLogicalWidthForContent, we got those 2 cases covered.
Tests: fast/multicol/fixed-column-percent-logical-height-orthogonal-writing-mode.html
fast/table/caption-orthogonal-writing-mode-sizing.html
* rendering/RenderBox.cpp:
(WebCore::RenderBox::computePercentageLogicalHeight):
Updated the function to track which renderer's containing block we use and call
containingBlockLogicalWidthForContent on it.
LayoutTests:
* fast/multicol/fixed-column-percent-logical-height-orthogonal-writing-mode-expected.txt: Added.
* fast/multicol/fixed-column-percent-logical-height-orthogonal-writing-mode.html: Added.
* fast/table/caption-orthogonal-writing-mode-sizing-expected.txt: Added.
* fast/table/caption-orthogonal-writing-mode-sizing.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderBox.cpp
Added Paths
trunk/LayoutTests/fast/multicol/fixed-column-percent-logical-height-orthogonal-writing-mode-expected.txt
trunk/LayoutTests/fast/multicol/fixed-column-percent-logical-height-orthogonal-writing-mode.html
trunk/LayoutTests/fast/table/caption-orthogonal-writing-mode-sizing-expected.txt
trunk/LayoutTests/fast/table/caption-orthogonal-writing-mode-sizing.html
Diff
Modified: trunk/LayoutTests/ChangeLog (135740 => 135741)
--- trunk/LayoutTests/ChangeLog 2012-11-26 18:58:27 UTC (rev 135740)
+++ trunk/LayoutTests/ChangeLog 2012-11-26 19:07:20 UTC (rev 135741)
@@ -1,3 +1,15 @@
+2012-11-26 Julien Chaffraix jchaffr...@webkit.org
+
+RenderBox::computePercentageLogicalHeight should use containingBlockLogicalWidthForContent
+https://bugs.webkit.org/show_bug.cgi?id=103075
+
+Reviewed by Ojan Vafai.
+
+* fast/multicol/fixed-column-percent-logical-height-orthogonal-writing-mode-expected.txt: Added.
+* fast/multicol/fixed-column-percent-logical-height-orthogonal-writing-mode.html: Added.
+* fast/table/caption-orthogonal-writing-mode-sizing-expected.txt: Added.
+* fast/table/caption-orthogonal-writing-mode-sizing.html: Added.
+
2012-11-26 Abhishek Arya infe...@chromium.org
Crash in Frame::dispatchVisibilityStateChangeEvent.
Added: trunk/LayoutTests/fast/multicol/fixed-column-percent-logical-height-orthogonal-writing-mode-expected.txt (0 => 135741)
--- trunk/LayoutTests/fast/multicol/fixed-column-percent-logical-height-orthogonal-writing-mode-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/multicol/fixed-column-percent-logical-height-orthogonal-writing-mode-expected.txt 2012-11-26 19:07:20 UTC (rev 135741)
@@ -0,0 +1,5 @@
+Bug 103075: RenderBox::computePercentageLogicalHeight should use containingBlockLogicalWidthForContent
+
+This test checks that a percent logical height child in an orthogonal writing mode uses the multi-column's containing block column-width when resolving the logical height.
+
+PASS
Added: trunk/LayoutTests/fast/multicol/fixed-column-percent-logical-height-orthogonal-writing-mode.html (0 => 135741)
--- trunk/LayoutTests/fast/multicol/fixed-column-percent-logical-height-orthogonal-writing-mode.html (rev 0)
+++ trunk/LayoutTests/fast/multicol/fixed-column-percent-logical-height-orthogonal-writing-mode.html 2012-11-26 19:07:20 UTC (rev 135741)
@@ -0,0 +1,28 @@
+!DOCTYPE html
+html
+head
+style
+.container {
+height: 100px;
+width: 400px;
+-webkit-column-width: 100px;
+-webkit-column-gap: 0px;
+}
+
+.percentLogicalHeight {
+-webkit-writing-mode: vertical-lr;
+height: 100%;
+width: 100%;
+background-color: navy;
+}
+/style
+/head
+script src=""
+body _onload_=checkLayout('.percentLogicalHeight')
+pa href="" 103075/a: RenderBox::computePercentageLogicalHeight should use containingBlockLogicalWidthForContent/p
+pThis test checks that a percent logical height child in an orthogonal writing mode uses the multi-column's containing block column-width when resolving the logical height./p
+div class=container
+div class=percentLogicalHeight data-expected-width=100 data-expected-height=100/div
+/div
+/body
+/html
Added: trunk/LayoutTests/fast/table/caption-orthogonal-writing-mode-sizing-expected.txt (0 => 135741)
---
[webkit-changes] [135743] trunk/Source/WebKit/chromium
Title: [135743] trunk/Source/WebKit/chromium Revision 135743 Author r...@google.com Date 2012-11-26 11:27:52 -0800 (Mon, 26 Nov 2012) Log Message add SK_DISABLE_DITHER_32BIT_GRADIENT define, in preparation for rebaselining https://bugs.webkit.org/show_bug.cgi?id=103272 Reviewed by NOBODY. Unreviewed. No behavior change, as this define already exists on the chrome side in SkUserConfig.h * skia_webkit.gyp: Modified Paths trunk/Source/WebKit/chromium/ChangeLog trunk/Source/WebKit/chromium/skia_webkit.gyp Diff Modified: trunk/Source/WebKit/chromium/ChangeLog (135742 => 135743) --- trunk/Source/WebKit/chromium/ChangeLog 2012-11-26 19:12:01 UTC (rev 135742) +++ trunk/Source/WebKit/chromium/ChangeLog 2012-11-26 19:27:52 UTC (rev 135743) @@ -1,3 +1,14 @@ +2012-11-26 Mike Reed r...@google.com + +add SK_DISABLE_DITHER_32BIT_GRADIENT define, in preparation for rebaselining +https://bugs.webkit.org/show_bug.cgi?id=103272 + +Reviewed by NOBODY. Unreviewed. + +No behavior change, as this define already exists on the chrome side in SkUserConfig.h + +* skia_webkit.gyp: + 2012-11-26 Sheriff Bot webkit.review@gmail.com Unreviewed, rolling out r135735. Modified: trunk/Source/WebKit/chromium/skia_webkit.gyp (135742 => 135743) --- trunk/Source/WebKit/chromium/skia_webkit.gyp 2012-11-26 19:12:01 UTC (rev 135742) +++ trunk/Source/WebKit/chromium/skia_webkit.gyp 2012-11-26 19:27:52 UTC (rev 135743) @@ -39,6 +39,9 @@ 'defines': [ # Place defines here that require significant WebKit rebaselining, or that # are otherwise best removed in WebKit and then rolled into Chromium. + + # extracted from SkUserConfig.h, in preparation for rebaselining. + 'SK_DISABLE_DITHER_32BIT_GRADIENT', ], }, }, ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [135745] trunk/Source/JavaScriptCore
Title: [135745] trunk/Source/_javascript_Core
Revision 135745
Author commit-qu...@webkit.org
Date 2012-11-26 11:37:18 -0800 (Mon, 26 Nov 2012)
Log Message
[sh4] _javascript_Core JIT build is broken since r135330
Add missing implementation for sh4 arch.
https://bugs.webkit.org/show_bug.cgi?id=103145
Patch by Julien BRIANCEAU jbrianc...@nds.com on 2012-11-26
Reviewed by Oliver Hunt.
* assembler/MacroAssemblerSH4.h:
(JSC::MacroAssemblerSH4::canJumpReplacePatchableBranchPtrWithPatch):
(MacroAssemblerSH4):
(JSC::MacroAssemblerSH4::startOfBranchPtrWithPatchOnRegister):
(JSC::MacroAssemblerSH4::revertJumpReplacementToBranchPtrWithPatch):
(JSC::MacroAssemblerSH4::startOfPatchableBranchPtrWithPatchOnAddress):
(JSC::MacroAssemblerSH4::revertJumpReplacementToPatchableBranchPtrWithPatch):
* assembler/SH4Assembler.h:
(JSC::SH4Assembler::revertJump):
(SH4Assembler):
(JSC::SH4Assembler::printInstr):
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/assembler/MacroAssemblerSH4.h
trunk/Source/_javascript_Core/assembler/SH4Assembler.h
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (135744 => 135745)
--- trunk/Source/_javascript_Core/ChangeLog 2012-11-26 19:31:53 UTC (rev 135744)
+++ trunk/Source/_javascript_Core/ChangeLog 2012-11-26 19:37:18 UTC (rev 135745)
@@ -1,3 +1,23 @@
+2012-11-26 Julien BRIANCEAU jbrianc...@nds.com
+
+[sh4] _javascript_Core JIT build is broken since r135330
+Add missing implementation for sh4 arch.
+https://bugs.webkit.org/show_bug.cgi?id=103145
+
+Reviewed by Oliver Hunt.
+
+* assembler/MacroAssemblerSH4.h:
+(JSC::MacroAssemblerSH4::canJumpReplacePatchableBranchPtrWithPatch):
+(MacroAssemblerSH4):
+(JSC::MacroAssemblerSH4::startOfBranchPtrWithPatchOnRegister):
+(JSC::MacroAssemblerSH4::revertJumpReplacementToBranchPtrWithPatch):
+(JSC::MacroAssemblerSH4::startOfPatchableBranchPtrWithPatchOnAddress):
+(JSC::MacroAssemblerSH4::revertJumpReplacementToPatchableBranchPtrWithPatch):
+* assembler/SH4Assembler.h:
+(JSC::SH4Assembler::revertJump):
+(SH4Assembler):
+(JSC::SH4Assembler::printInstr):
+
2012-11-26 Yuqiang Xian yuqiang.x...@intel.com
Use load64 instead of loadPtr to load a JSValue on JSVALUE64 platforms
Modified: trunk/Source/_javascript_Core/assembler/MacroAssemblerSH4.h (135744 => 135745)
--- trunk/Source/_javascript_Core/assembler/MacroAssemblerSH4.h 2012-11-26 19:31:53 UTC (rev 135744)
+++ trunk/Source/_javascript_Core/assembler/MacroAssemblerSH4.h 2012-11-26 19:37:18 UTC (rev 135745)
@@ -2216,6 +2216,29 @@
return 0;
}
+static bool canJumpReplacePatchableBranchPtrWithPatch() { return false; }
+
+static CodeLocationLabel startOfBranchPtrWithPatchOnRegister(CodeLocationDataLabelPtr label)
+{
+return label.labelAtOffset(0);
+}
+
+static void revertJumpReplacementToBranchPtrWithPatch(CodeLocationLabel instructionStart, RegisterID, void* initialValue)
+{
+SH4Assembler::revertJump(instructionStart.dataLocation(), reinterpret_castuintptr_t(initialValue) 0x);
+}
+
+static CodeLocationLabel startOfPatchableBranchPtrWithPatchOnAddress(CodeLocationDataLabelPtr)
+{
+UNREACHABLE_FOR_PLATFORM();
+return CodeLocationLabel();
+}
+
+static void revertJumpReplacementToPatchableBranchPtrWithPatch(CodeLocationLabel instructionStart, Address, void* initialValue)
+{
+UNREACHABLE_FOR_PLATFORM();
+}
+
protected:
SH4Assembler::Condition SH4Condition(RelationalCondition cond)
{
Modified: trunk/Source/_javascript_Core/assembler/SH4Assembler.h (135744 => 135745)
--- trunk/Source/_javascript_Core/assembler/SH4Assembler.h 2012-11-26 19:31:53 UTC (rev 135744)
+++ trunk/Source/_javascript_Core/assembler/SH4Assembler.h 2012-11-26 19:37:18 UTC (rev 135745)
@@ -1462,6 +1462,20 @@
// Linking patching
+static void revertJump(void* instructionStart, SH4Word imm)
+{
+SH4Word *insn = reinterpret_castSH4Word*(instructionStart);
+SH4Word disp;
+
+ASSERT((insn[0] 0xf000) == MOVL_READ_OFFPC_OPCODE);
+
+disp = insn[0] 0x00ff;
+insn += 2 + (disp 1); // PC += 4 + (disp*4)
+insn = (SH4Word *) ((unsigned) insn (~3));
+insn[0] = imm;
+cacheFlush(insn, sizeof(SH4Word));
+}
+
void linkJump(AssemblerLabel from, AssemblerLabel to, JumpType type = JumpFar)
{
ASSERT(to.isSet());
@@ -1755,6 +1769,9 @@
case FCNVDS_DRM_FPUL_OPCODE:
format = FCNVDS FR%d, FPUL\n;
break;
+case FCNVSD_FPUL_DRN_OPCODE:
+format = FCNVSD FPUL, FR%d\n;
+break;
}
if (format) {
if (isdoubleInst)
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
[webkit-changes] [135746] trunk/Source/WebCore
Title: [135746] trunk/Source/WebCore Revision 135746 Author simon.fra...@apple.com Date 2012-11-26 11:37:45 -0800 (Mon, 26 Nov 2012) Log Message Optimize layer updates after scrolling https://bugs.webkit.org/show_bug.cgi?id=102635 Reviewed by Sam Weinig. updateLayerPositionsAfterScroll() previously unconditionally cleared clip rects, and recomputed repaint rects too often. Recomputing both of these can be very expensive, as they involve tree walks up to the root. We can optimize layer updates after document scrolling by only clearing clip rects, and recomputing repaint rects, if we encounter a fixed- or sticky-position element. For overflow scroll, we have to clear clip rects and recompute repaint rects. * page/FrameView.cpp: (WebCore::FrameView::repaintFixedElementsAfterScrolling): Call updateLayerPositionsAfterDocumentScroll(). * rendering/RenderLayer.cpp: (WebCore::RenderLayer::updateLayerPositions): Call clearClipRects() because updateLayerPosition() no longer does. (WebCore::RenderLayer::updateLayerPositionsAfterDocumentScroll): Version of updateLayerPositionsAfterScroll() that is for document scrolls. It has no need to push layers to the geometry map. (WebCore::RenderLayer::updateLayerPositionsAfterOverflowScroll): Pushes layers to the geometry map, and calls updateLayerPositionsAfterScroll() with the IsOverflowScroll flag. (WebCore::RenderLayer::updateLayerPositionsAfterScroll): Set the HasChangedAncestor flag if our location changed, and use that as a hint to clear cached rects. Be more conservative than before about when to clear cached clip rects. (WebCore::RenderLayer::updateLayerPosition): Move responsibility for calling clearClipRects() ouf of this function and into callers. (The one caller outside RenderLayer will be removed via bug 102624). Return a bool indicating whether our position changed. (WebCore::RenderLayer::scrollTo): Call updateLayerPositionsAfterOverflowScroll(). (WebCore::RenderLayer::updateClipRects): Added some #ifdeffed out code that is useful to verify that cached clips are correct; it's too slow to leave enabled in debug builds. * rendering/RenderLayer.h: (WebCore::RenderLayer::setLocation): Change to take a LayoutPoint, rather than separate x and y. Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/page/FrameView.cpp trunk/Source/WebCore/rendering/RenderLayer.cpp trunk/Source/WebCore/rendering/RenderLayer.h Diff Modified: trunk/Source/WebCore/ChangeLog (135745 => 135746) --- trunk/Source/WebCore/ChangeLog 2012-11-26 19:37:18 UTC (rev 135745) +++ trunk/Source/WebCore/ChangeLog 2012-11-26 19:37:45 UTC (rev 135746) @@ -1,3 +1,41 @@ +2012-11-26 Simon Fraser simon.fra...@apple.com + +Optimize layer updates after scrolling +https://bugs.webkit.org/show_bug.cgi?id=102635 + +Reviewed by Sam Weinig. + +updateLayerPositionsAfterScroll() previously unconditionally cleared clip +rects, and recomputed repaint rects too often. Recomputing both of these +can be very expensive, as they involve tree walks up to the root. + +We can optimize layer updates after document scrolling by only clearing clip +rects, and recomputing repaint rects, if we encounter a fixed- or sticky-position +element. For overflow scroll, we have to clear clip rects and recompute repaint rects. + +* page/FrameView.cpp: +(WebCore::FrameView::repaintFixedElementsAfterScrolling): Call updateLayerPositionsAfterDocumentScroll(). +* rendering/RenderLayer.cpp: +(WebCore::RenderLayer::updateLayerPositions): Call clearClipRects() because +updateLayerPosition() no longer does. +(WebCore::RenderLayer::updateLayerPositionsAfterDocumentScroll): Version of updateLayerPositionsAfterScroll() +that is for document scrolls. It has no need to push layers to the geometry map. +(WebCore::RenderLayer::updateLayerPositionsAfterOverflowScroll): Pushes layers to the geometry map, +and calls updateLayerPositionsAfterScroll() with the IsOverflowScroll flag. +(WebCore::RenderLayer::updateLayerPositionsAfterScroll): Set the HasChangedAncestor flag +if our location changed, and use that as a hint to clear cached rects. Be more conservative +than before about when to clear cached clip rects. +(WebCore::RenderLayer::updateLayerPosition): Move responsibility for calling +clearClipRects() ouf of this function and into callers. +(The one caller outside RenderLayer will be removed via bug 102624). +Return a bool indicating whether our position changed. +(WebCore::RenderLayer::scrollTo): Call updateLayerPositionsAfterOverflowScroll(). +(WebCore::RenderLayer::updateClipRects): Added some #ifdeffed out code that is useful +to verify that cached clips are correct; it's too slow to leave enabled in debug builds. +* rendering/RenderLayer.h: +
[webkit-changes] [135747] branches/chromium/1312/Source/WebCore/dom/Document.cpp
Title: [135747] branches/chromium/1312/Source/WebCore/dom/Document.cpp Revision 135747 Author kar...@chromium.org Date 2012-11-26 11:42:13 -0800 (Mon, 26 Nov 2012) Log Message Merge 135709 - Circular reference between Document and MediaQueryMatcher. https://bugs.webkit.org/show_bug.cgi?id=103242 Patch by Marja Hölttä ma...@chromium.org on 2012-11-26 Reviewed by Kenneth Rohde Christiansen. It's not enough to clean up listeners in MediaQueryMatcher in ~Document, since MediaQueryListListener keeps the Document alive. This caused www.crbug.com/113983. No new tests: No visible change in behavior (except that it doesn't leak memory). * dom/Document.cpp: (WebCore::Document::~Document): (WebCore::Document::detach): TBR=commit-qu...@webkit.org Review URL: https://codereview.chromium.org/11415134 Modified Paths branches/chromium/1312/Source/WebCore/dom/Document.cpp Diff Modified: branches/chromium/1312/Source/WebCore/dom/Document.cpp (135746 => 135747) --- branches/chromium/1312/Source/WebCore/dom/Document.cpp 2012-11-26 19:37:45 UTC (rev 135746) +++ branches/chromium/1312/Source/WebCore/dom/Document.cpp 2012-11-26 19:42:13 UTC (rev 135747) @@ -656,9 +656,6 @@ m_weakReference-clear(); -if (m_mediaQueryMatcher) -m_mediaQueryMatcher-documentDestroyed(); - clearStyleResolver(); // We need to destory CSSFontSelector before destroying m_cachedResourceLoader. // It's possible for multiple Documents to end up referencing the same CachedResourceLoader (e.g., SVGImages @@ -2151,6 +2148,9 @@ // callers of Document::detach(). m_frame = 0; m_renderArena.clear(); + +if (m_mediaQueryMatcher) +m_mediaQueryMatcher-documentDestroyed(); } void Document::prepareForDestruction() ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [135749] trunk
Title: [135749] trunk Revision 135749 Author michelang...@webkit.org Date 2012-11-26 11:57:40 -0800 (Mon, 26 Nov 2012) Log Message [CSS Shaders] Add IDL file and bindings for mix function https://bugs.webkit.org/show_bug.cgi?id=93011 Reviewed by Dean Jackson. Source/WebCore: _javascript_ bindings have been added for the Custom Filter mix() function (WebKitCSSMixFunctionValue). As of now, this is only a placeholder that extends CSSValueList without adding any new property. Test: css3/filters/custom/custom-filter-mix-bindings.html * CMakeLists.txt: mix() IDL has been added to the Generator; DerivedSources have been included. * DerivedSources.cpp: Ditto. * DerivedSources.make: Ditto. * DerivedSources.pri: Ditto. * GNUmakefile.list.am: Ditto. * WebCore.gypi: Ditto. * WebCore.vcproj/WebCore.vcproj: Ditto. * WebCore.xcodeproj/project.pbxproj: Ditto. * bindings/js/JSCSSValueCustom.cpp: (WebCore::toJS): return a JSC DOM wrapper for WebKitCSSMixFunctionValue. * bindings/v8/custom/V8CSSValueCustom.cpp: (WebCore::V8CSSValue::dispatchWrapCustom): Ditto, for V8. * css/WebKitCSSMixFunctionValue.idl: Added. LayoutTests: Test for the Custom Filter mix() function JS bindings. * css3/filters/custom/custom-filter-mix-bindings-expected.txt: Added. * css3/filters/custom/custom-filter-mix-bindings.html: Added. * css3/filters/script-tests/custom-filter-mix-bindings.js: Added. (jsWrapperClass): (shouldBeType): * platform/chromium/css3/filters/custom/custom-filter-mix-bindings-expected.txt: Added. * platform/efl/fast/js/global-constructors-expected.txt: Updated with the new WebKitCSSMixFunctionValueConstructor. * platform/gtk/fast/js/global-constructors-expected.txt: Ditto. * platform/mac/fast/js/global-constructors-expected.txt: Ditto. * platform/qt-5.0/fast/js/global-constructors-expected.txt: Ditto. * platform/qt/fast/js/global-constructors-expected.txt: Ditto. * platform/win/fast/js/global-constructors-expected.txt: Ditto. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/efl/fast/js/global-constructors-expected.txt trunk/LayoutTests/platform/gtk/fast/js/global-constructors-expected.txt trunk/LayoutTests/platform/mac/fast/js/global-constructors-expected.txt trunk/LayoutTests/platform/qt/fast/js/global-constructors-expected.txt trunk/LayoutTests/platform/qt-5.0/fast/js/global-constructors-expected.txt trunk/LayoutTests/platform/win/fast/js/global-constructors-expected.txt trunk/Source/WebCore/CMakeLists.txt trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/DerivedSources.cpp trunk/Source/WebCore/DerivedSources.make trunk/Source/WebCore/DerivedSources.pri trunk/Source/WebCore/GNUmakefile.list.am trunk/Source/WebCore/WebCore.gypi trunk/Source/WebCore/WebCore.vcproj/WebCore.vcproj trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj trunk/Source/WebCore/bindings/js/JSCSSValueCustom.cpp trunk/Source/WebCore/bindings/v8/custom/V8CSSValueCustom.cpp trunk/Source/WebCore/page/DOMWindow.idl Added Paths trunk/LayoutTests/css3/filters/custom/custom-filter-mix-bindings-expected.txt trunk/LayoutTests/css3/filters/custom/custom-filter-mix-bindings.html trunk/LayoutTests/css3/filters/script-tests/custom-filter-mix-bindings.js trunk/LayoutTests/platform/chromium/css3/filters/custom/custom-filter-mix-bindings-expected.txt trunk/Source/WebCore/css/WebKitCSSMixFunctionValue.idl Diff Modified: trunk/LayoutTests/ChangeLog (135748 => 135749) --- trunk/LayoutTests/ChangeLog 2012-11-26 19:45:31 UTC (rev 135748) +++ trunk/LayoutTests/ChangeLog 2012-11-26 19:57:40 UTC (rev 135749) @@ -1,3 +1,25 @@ +2012-11-26 Michelangelo De Simone michelang...@webkit.org + +[CSS Shaders] Add IDL file and bindings for mix function +https://bugs.webkit.org/show_bug.cgi?id=93011 + +Reviewed by Dean Jackson. + +Test for the Custom Filter mix() function JS bindings. + +* css3/filters/custom/custom-filter-mix-bindings-expected.txt: Added. +* css3/filters/custom/custom-filter-mix-bindings.html: Added. +* css3/filters/script-tests/custom-filter-mix-bindings.js: Added. +(jsWrapperClass): +(shouldBeType): +* platform/chromium/css3/filters/custom/custom-filter-mix-bindings-expected.txt: Added. +* platform/efl/fast/js/global-constructors-expected.txt: Updated with the new WebKitCSSMixFunctionValueConstructor. +* platform/gtk/fast/js/global-constructors-expected.txt: Ditto. +* platform/mac/fast/js/global-constructors-expected.txt: Ditto. +* platform/qt-5.0/fast/js/global-constructors-expected.txt: Ditto. +* platform/qt/fast/js/global-constructors-expected.txt: Ditto. +* platform/win/fast/js/global-constructors-expected.txt: Ditto. + 2012-11-26 Julien Chaffraix jchaffr...@webkit.org RenderBox::computePercentageLogicalHeight should use containingBlockLogicalWidthForContent Added: trunk/LayoutTests/css3/filters/custom/custom-filter-mix-bindings-expected.txt (0 => 135749) ---
[webkit-changes] [135750] trunk
Title: [135750] trunk Revision 135750 Author commit-qu...@webkit.org Date 2012-11-26 12:00:49 -0800 (Mon, 26 Nov 2012) Log Message [CSS Regions] Add Region info for RootLineBoxes and pack the pagination data https://bugs.webkit.org/show_bug.cgi?id=101332 Patch by Andrei Bucur abu...@adobe.com on 2012-11-26 Reviewed by David Hyatt. Source/WebCore: Currently the pagination information for lines is spread between the RootInlineBox and InlineFlowBox classes, consuming memory even though the boxes were not the result of an pagination layout. To overcome this, a new struct (LineFragmentationData) is created that wraps all the data, including two new members, the containing Region for the line and a boolean that states if the line was laid out in a Region or not. The flag is necessary because the sanitize function on LineFragmentationData resets the containing Region to 0 if the Region was removed from chain (so a value of 0 for the containing Region means two things). The sanitize function should prevent access to an invalid address. The containing Region is used to detect if a line changed the Region where it resides. This will be helpful especially when implementing region styling for layout properties (e.g. the font-size property https://bugs.webkit.org/show_bug.cgi?id=95559 ). A line can change the region when it is shifted inside the containing block or if the entire block moves. This means it's better to delegate the task of updating the containing Region to the block. Tests: fast/regions/line-containing-region-crash.html * rendering/InlineFlowBox.cpp: (SameSizeAsInlineFlowBox): * rendering/InlineFlowBox.h: (WebCore::InlineFlowBox::InlineFlowBox): (InlineFlowBox): * rendering/RenderBlock.cpp: (WebCore::RenderBlock::lineWidthForPaginatedLineChanged): * rendering/RenderBlockLineLayout.cpp: (WebCore::RenderBlock::layoutRunsAndFloatsInRange): (WebCore::RenderBlock::linkToEndLineIfNeeded): (WebCore::RenderBlock::determineStartPosition): * rendering/RootInlineBox.cpp: (WebCore::RootInlineBox::RootInlineBox): (WebCore::RootInlineBox::setContainingRegion): (WebCore): (WebCore::RootInlineBox::LineFragmentationData::sanitize): This is an O(1) function that checks if the containig Region is still valid pointer. * rendering/RootInlineBox.h: (WebCore): (WebCore::RootInlineBox::paginationStrut): (WebCore::RootInlineBox::setPaginationStrut): (WebCore::RootInlineBox::isFirstAfterPageBreak): (WebCore::RootInlineBox::setIsFirstAfterPageBreak): (WebCore::RootInlineBox::paginatedLineWidth): (WebCore::RootInlineBox::setPaginatedLineWidth): (RootInlineBox): (WebCore::RootInlineBox::containingRegion): (WebCore::RootInlineBox::hasContainingRegion): Use this to determine if the line has a region or not. (WebCore::RootInlineBox::ensureLineFragmentationData): (LineFragmentationData): (WebCore::RootInlineBox::LineFragmentationData::LineFragmentationData): LayoutTests: The test checks if there is a crash when doing a line layout if: - the flow has no region - the flow has a region but the lines have no containing region - the flow has no region but the lines have a containing region * fast/regions/line-containing-region-crash-expected.txt: Added. * fast/regions/line-containing-region-crash.html: Added. Modified Paths trunk/LayoutTests/ChangeLog trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/rendering/InlineFlowBox.cpp trunk/Source/WebCore/rendering/InlineFlowBox.h trunk/Source/WebCore/rendering/RenderBlock.cpp trunk/Source/WebCore/rendering/RenderBlockLineLayout.cpp trunk/Source/WebCore/rendering/RootInlineBox.cpp trunk/Source/WebCore/rendering/RootInlineBox.h Added Paths trunk/LayoutTests/fast/regions/line-containing-region-crash-expected.txt trunk/LayoutTests/fast/regions/line-containing-region-crash.html Diff Modified: trunk/LayoutTests/ChangeLog (135749 => 135750) --- trunk/LayoutTests/ChangeLog 2012-11-26 19:57:40 UTC (rev 135749) +++ trunk/LayoutTests/ChangeLog 2012-11-26 20:00:49 UTC (rev 135750) @@ -1,3 +1,18 @@ +2012-11-26 Andrei Bucur abu...@adobe.com + +[CSS Regions] Add Region info for RootLineBoxes and pack the pagination data +https://bugs.webkit.org/show_bug.cgi?id=101332 + +Reviewed by David Hyatt. + +The test checks if there is a crash when doing a line layout if: +- the flow has no region +- the flow has a region but the lines have no containing region +- the flow has no region but the lines have a containing region + +* fast/regions/line-containing-region-crash-expected.txt: Added. +* fast/regions/line-containing-region-crash.html: Added. + 2012-11-26 Michelangelo De Simone michelang...@webkit.org [CSS Shaders] Add IDL file and bindings for mix function Added: trunk/LayoutTests/fast/regions/line-containing-region-crash-expected.txt (0 => 135750) --- trunk/LayoutTests/fast/regions/line-containing-region-crash-expected.txt (rev 0) +++
[webkit-changes] [135751] branches/safari-536.28-branch
Title: [135751] branches/safari-536.28-branch
Revision 135751
Author lforsch...@apple.com
Date 2012-11-26 12:02:10 -0800 (Mon, 26 Nov 2012)
Log Message
Merged r132713. rdar://problem/12589195
Modified Paths
branches/safari-536.28-branch/LayoutTests/ChangeLog
branches/safari-536.28-branch/Source/WebKit2/ChangeLog
branches/safari-536.28-branch/Source/WebKit2/WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp
branches/safari-536.28-branch/Source/WebKit2/WebProcess/Plugins/Netscape/NetscapePlugin.cpp
branches/safari-536.28-branch/Tools/ChangeLog
branches/safari-536.28-branch/Tools/DumpRenderTree/DumpRenderTree.gypi
branches/safari-536.28-branch/Tools/DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj
branches/safari-536.28-branch/Tools/DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp
branches/safari-536.28-branch/Tools/DumpRenderTree/TestNetscapePlugIn/PluginTest.h
branches/safari-536.28-branch/Tools/DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj
branches/safari-536.28-branch/Tools/DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro
branches/safari-536.28-branch/Tools/GNUmakefile.am
Added Paths
branches/safari-536.28-branch/LayoutTests/plugins/npruntime/npruntime-calls-with-null-npp-expected.txt
branches/safari-536.28-branch/LayoutTests/plugins/npruntime/npruntime-calls-with-null-npp.html
branches/safari-536.28-branch/Tools/DumpRenderTree/TestNetscapePlugIn/Tests/NPRuntimeCallsWithNullNPP.cpp
Diff
Modified: branches/safari-536.28-branch/LayoutTests/ChangeLog (135750 => 135751)
--- branches/safari-536.28-branch/LayoutTests/ChangeLog 2012-11-26 20:00:49 UTC (rev 135750)
+++ branches/safari-536.28-branch/LayoutTests/ChangeLog 2012-11-26 20:02:10 UTC (rev 135751)
@@ -1,3 +1,19 @@
+2012-11-26 Lucas Forschler lforsch...@apple.com
+
+Merge r132713
+
+2012-10-26 Anders Carlsson ander...@apple.com
+
+Crash when making NPRuntime calls with a null NPP pointer
+https://bugs.webkit.org/show_bug.cgi?id=100569
+
+Reviewed by Darin Adler.
+
+Add new tests.
+
+* plugins/npruntime/npruntime-calls-with-null-npp-expected.txt: Added.
+* plugins/npruntime/npruntime-calls-with-null-npp.html: Added.
+
2012-11-18 Simon Fraser simon.fra...@apple.com
rdar://problem/12725998 Simplify bounds computation for the RenderView's layer (102597)
Copied: branches/safari-536.28-branch/LayoutTests/plugins/npruntime/npruntime-calls-with-null-npp-expected.txt (from rev 132713, trunk/LayoutTests/plugins/npruntime/npruntime-calls-with-null-npp-expected.txt) (0 => 135751)
--- branches/safari-536.28-branch/LayoutTests/plugins/npruntime/npruntime-calls-with-null-npp-expected.txt (rev 0)
+++ branches/safari-536.28-branch/LayoutTests/plugins/npruntime/npruntime-calls-with-null-npp-expected.txt 2012-11-26 20:02:10 UTC (rev 135751)
@@ -0,0 +1,4 @@
+
+Test that calling various NPRuntime related NPN_ functions doesn't crash.
+
+SUCCESS!
Copied: branches/safari-536.28-branch/LayoutTests/plugins/npruntime/npruntime-calls-with-null-npp.html (from rev 132713, trunk/LayoutTests/plugins/npruntime/npruntime-calls-with-null-npp.html) (0 => 135751)
--- branches/safari-536.28-branch/LayoutTests/plugins/npruntime/npruntime-calls-with-null-npp.html (rev 0)
+++ branches/safari-536.28-branch/LayoutTests/plugins/npruntime/npruntime-calls-with-null-npp.html 2012-11-26 20:02:10 UTC (rev 135751)
@@ -0,0 +1,13 @@
+script
+function runTest() {
+if (window.testRunner) {
+testRunner.dumpAsText();
+testRunner.waitUntilDone();
+}
+}
+/script
+body _onLoad_=runTest()
+embed id=plugin type=application/x-webkit-test-netscape test=npruntime-calls-with-null-npp/embed
+p id=descriptionTest that calling various NPRuntime related NPN_ functions doesn't crash./p
+div id=resultFAILURE/div
+/body
Modified: branches/safari-536.28-branch/Source/WebKit2/ChangeLog (135750 => 135751)
--- branches/safari-536.28-branch/Source/WebKit2/ChangeLog 2012-11-26 20:00:49 UTC (rev 135750)
+++ branches/safari-536.28-branch/Source/WebKit2/ChangeLog 2012-11-26 20:02:10 UTC (rev 135751)
@@ -1,3 +1,29 @@
+2012-11-26 Lucas Forschler lforsch...@apple.com
+
+Merge r132713
+
+2012-10-26 Anders Carlsson ander...@apple.com
+
+Crash when making NPRuntime calls with a null NPP pointer
+https://bugs.webkit.org/show_bug.cgi?id=100569
+rdar://problem/11726426
+rdar://problem/12352836
+
+Reviewed by Darin Adler.
+
+Finally bite the bullet and remove the assertion from NetscapePlugin::fromNPP. The WebKit1 equivalent of this
+function used to return the plug-in currently being initialized in NPP_New, but we've never done that in WebKit2
+and it has never been necessary. The crashes fixed here are not from calls underneath NPP_New so fixing it wouldn't
+do us any good
[webkit-changes] [135752] trunk
Title: [135752] trunk
Revision 135752
Author commit-qu...@webkit.org
Date 2012-11-26 12:17:36 -0800 (Mon, 26 Nov 2012)
Log Message
[EFL][WK2] Add setting to enable / disable HTML5 local storage functionality
https://bugs.webkit.org/show_bug.cgi?id=103224
Patch by Christophe Dumez christophe.du...@intel.com on 2012-11-26
Reviewed by Laszlo Gombos.
Source/WebKit2:
Add API to ewk_settings to enable / disable the HTML5
local storage functionality. The functionality is
enabled by default.
* UIProcess/API/efl/ewk_settings.cpp:
(ewk_settings_local_storage_enabled_set):
(ewk_settings_local_storage_enabled_get):
* UIProcess/API/efl/ewk_settings.h:
* UIProcess/API/efl/tests/test_ewk2_settings.cpp:
(TEST_F): Add API test for ewk_settings_local_storage_enabled_get / set.
Tools:
Add --local-storage command line argument to MiniBrowser to
explicitely disable HTML5 local storage functionality. This
is useful for testing purposes.
* MiniBrowser/efl/main.c:
(window_create):
(elm_main):
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/efl/ewk_settings.cpp
trunk/Source/WebKit2/UIProcess/API/efl/ewk_settings.h
trunk/Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_settings.cpp
trunk/Tools/ChangeLog
trunk/Tools/MiniBrowser/efl/main.c
Diff
Modified: trunk/Source/WebKit2/ChangeLog (135751 => 135752)
--- trunk/Source/WebKit2/ChangeLog 2012-11-26 20:02:10 UTC (rev 135751)
+++ trunk/Source/WebKit2/ChangeLog 2012-11-26 20:17:36 UTC (rev 135752)
@@ -1,3 +1,21 @@
+2012-11-26 Christophe Dumez christophe.du...@intel.com
+
+[EFL][WK2] Add setting to enable / disable HTML5 local storage functionality
+https://bugs.webkit.org/show_bug.cgi?id=103224
+
+Reviewed by Laszlo Gombos.
+
+Add API to ewk_settings to enable / disable the HTML5
+local storage functionality. The functionality is
+enabled by default.
+
+* UIProcess/API/efl/ewk_settings.cpp:
+(ewk_settings_local_storage_enabled_set):
+(ewk_settings_local_storage_enabled_get):
+* UIProcess/API/efl/ewk_settings.h:
+* UIProcess/API/efl/tests/test_ewk2_settings.cpp:
+(TEST_F): Add API test for ewk_settings_local_storage_enabled_get / set.
+
2012-11-26 Rafael Brandao rafael.l...@openbossa.org
[CoordinatedGraphics] Access to LayerTreeRenderer::m_renderQueue should be thread safe
Modified: trunk/Source/WebKit2/UIProcess/API/efl/ewk_settings.cpp (135751 => 135752)
--- trunk/Source/WebKit2/UIProcess/API/efl/ewk_settings.cpp 2012-11-26 20:02:10 UTC (rev 135751)
+++ trunk/Source/WebKit2/UIProcess/API/efl/ewk_settings.cpp 2012-11-26 20:17:36 UTC (rev 135752)
@@ -332,3 +332,19 @@
return settings-preferences()-_javascript_CanOpenWindowsAutomatically();
}
+
+Eina_Bool ewk_settings_local_storage_enabled_set(Ewk_Settings* settings, Eina_Bool enable)
+{
+EINA_SAFETY_ON_NULL_RETURN_VAL(settings, false);
+
+settings-preferences()-setLocalStorageEnabled(enable);
+
+return true;
+}
+
+Eina_Bool ewk_settings_local_storage_enabled_get(const Ewk_Settings* settings)
+{
+EINA_SAFETY_ON_NULL_RETURN_VAL(settings, false);
+
+return settings-preferences()-localStorageEnabled();
+}
Modified: trunk/Source/WebKit2/UIProcess/API/efl/ewk_settings.h (135751 => 135752)
--- trunk/Source/WebKit2/UIProcess/API/efl/ewk_settings.h 2012-11-26 20:02:10 UTC (rev 135751)
+++ trunk/Source/WebKit2/UIProcess/API/efl/ewk_settings.h 2012-11-26 20:17:36 UTC (rev 135752)
@@ -391,6 +391,39 @@
*/
EAPI Eina_Bool ewk_settings_scripts_can_open_windows_get(const Ewk_Settings *settings);
+/**
+ * Enables/disables the HTML5 local storage functionality.
+ *
+ * Local storage provides simple synchronous storage access.
+ * HTML5 local storage specification is available at
+ * http://dev.w3.org/html5/webstorage/.
+ *
+ * By default, the HTML5 local storage is enabled.
+ *
+ * @param settings settings object to set the HTML5 local storage state
+ * @param enable @c EINA_TRUE to enable HTML5 local storage,
+ *@c EINA_FALSE to disable
+ *
+ * @return @c EINA_TRUE on success or @c EINA_FALSE on failure
+ */
+EAPI Eina_Bool ewk_settings_local_storage_enabled_set(Ewk_Settings *settings, Eina_Bool enable);
+
+/**
+ * Returns whether the HTML5 local storage functionality is enabled or not.
+ *
+ * Local storage provides simple synchronous storage access.
+ * HTML5 local storage specification is available at
+ * http://dev.w3.org/html5/webstorage/.
+ *
+ * By default, the HTML5 local storage is enabled.
+ *
+ * @param settings settings object to query whether HTML5 local storage is enabled
+ *
+ * @return @c EINA_TRUE if the HTML5 local storage is enabled
+ * @c EINA_FALSE if disabled or on failure
+ */
+EAPI Eina_Bool ewk_settings_local_storage_enabled_get(const Ewk_Settings *settings);
+
#ifdef __cplusplus
}
#endif
Modified: trunk/Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_settings.cpp (135751 => 135752)
---
[webkit-changes] [135753] trunk
Title: [135753] trunk Revision 135753 Author t...@chromium.org Date 2012-11-26 12:27:36 -0800 (Mon, 26 Nov 2012) Log Message Move more functions from internals.settings to internals https://bugs.webkit.org/show_bug.cgi?id=102976 Reviewed by Adam Barth. Source/WebCore: Move functions that don't have to do with Settings off of internals.settings. setPagination and configurationForViewport were defined on internals, so we can inline the functions (no test change). setEnableMockPagePopup is moved to Internals. No new tests, this is a refactor. * testing/InternalSettings.cpp: (WebCore::InternalSettings::reset): Move reset code into Internals. * testing/InternalSettings.h: (InternalSettings): Remove code for setPagination, configurationForViewport and setEnableMockPagePopup. * testing/InternalSettings.idl: Remove setPagination and setEnableMockPagePopup. * testing/Internals.cpp: (WebCore): Use a static to keep track of the MockPagePopupDriver. (WebCore::Internals::resetToConsistentState): Code from InternalSettings::reset (WebCore::Internals::setEnableMockPagePopup): Code copied from InternalSettings. (WebCore::Internals::pagePopupController): Code copied from InternalSettings. (WebCore::Internals::setPagination): Code copied from InternalSettings. (WebCore::Internals::configurationForViewport): Code copied from InternalSettings. * testing/Internals.h: (Internals): Add setEnableMockPagePopup. * testing/Internals.idl: Add setEnableMockPagePopup. LayoutTests: Move internals.settings.setEnableMockPagePopup to internals.setEnableMockPagePopup. * fast/forms/resources/picker-common.js: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/fast/forms/resources/picker-common.js trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/testing/InternalSettings.cpp trunk/Source/WebCore/testing/InternalSettings.h trunk/Source/WebCore/testing/InternalSettings.idl trunk/Source/WebCore/testing/Internals.cpp trunk/Source/WebCore/testing/Internals.h trunk/Source/WebCore/testing/Internals.idl Diff Modified: trunk/LayoutTests/ChangeLog (135752 => 135753) --- trunk/LayoutTests/ChangeLog 2012-11-26 20:17:36 UTC (rev 135752) +++ trunk/LayoutTests/ChangeLog 2012-11-26 20:27:36 UTC (rev 135753) @@ -1,3 +1,14 @@ +2012-11-26 Tony Chang t...@chromium.org + +Move more functions from internals.settings to internals +https://bugs.webkit.org/show_bug.cgi?id=102976 + +Reviewed by Adam Barth. + +Move internals.settings.setEnableMockPagePopup to internals.setEnableMockPagePopup. + +* fast/forms/resources/picker-common.js: + 2012-11-26 Andrei Bucur abu...@adobe.com [CSS Regions] Add Region info for RootLineBoxes and pack the pagination data Modified: trunk/LayoutTests/fast/forms/resources/picker-common.js (135752 => 135753) --- trunk/LayoutTests/fast/forms/resources/picker-common.js 2012-11-26 20:17:36 UTC (rev 135752) +++ trunk/LayoutTests/fast/forms/resources/picker-common.js 2012-11-26 20:27:36 UTC (rev 135753) @@ -1,6 +1,6 @@ window.jsTestIsAsync = true; if (window.internals) -internals.settings.setEnableMockPagePopup(true); +internals.setEnableMockPagePopup(true); var popupWindow = null; Modified: trunk/Source/WebCore/ChangeLog (135752 => 135753) --- trunk/Source/WebCore/ChangeLog 2012-11-26 20:17:36 UTC (rev 135752) +++ trunk/Source/WebCore/ChangeLog 2012-11-26 20:27:36 UTC (rev 135753) @@ -1,3 +1,34 @@ +2012-11-26 Tony Chang t...@chromium.org + +Move more functions from internals.settings to internals +https://bugs.webkit.org/show_bug.cgi?id=102976 + +Reviewed by Adam Barth. + +Move functions that don't have to do with Settings off of internals.settings. +setPagination and configurationForViewport were defined on internals, so we +can inline the functions (no test change). + +setEnableMockPagePopup is moved to Internals. + +No new tests, this is a refactor. + +* testing/InternalSettings.cpp: +(WebCore::InternalSettings::reset): Move reset code into Internals. +* testing/InternalSettings.h: +(InternalSettings): Remove code for setPagination, configurationForViewport and setEnableMockPagePopup. +* testing/InternalSettings.idl: Remove setPagination and setEnableMockPagePopup. +* testing/Internals.cpp: +(WebCore): Use a static to keep track of the MockPagePopupDriver. +(WebCore::Internals::resetToConsistentState): Code from InternalSettings::reset +(WebCore::Internals::setEnableMockPagePopup): Code copied from InternalSettings. +(WebCore::Internals::pagePopupController): Code copied from InternalSettings. +(WebCore::Internals::setPagination): Code copied from InternalSettings. +(WebCore::Internals::configurationForViewport): Code copied from InternalSettings. +* testing/Internals.h: +(Internals): Add setEnableMockPagePopup. +* testing/Internals.idl: Add
[webkit-changes] [135754] trunk/Source/WebKit/chromium
Title: [135754] trunk/Source/WebKit/chromium Revision 135754 Author rjkro...@chromium.org Date 2012-11-26 12:37:06 -0800 (Mon, 26 Nov 2012) Log Message Unreviewed, rolling out r135743. http://trac.webkit.org/changeset/135743 https://bugs.webkit.org/show_bug.cgi?id=103280 Caused compile failure 'SK_DISABLE_DITHER_32BIT_GRADIENT' macro redefined (Requested by rjkroege on #webkit). Patch by Sheriff Bot webkit.review@gmail.com on 2012-11-26 * skia_webkit.gyp: Modified Paths trunk/Source/WebKit/chromium/ChangeLog trunk/Source/WebKit/chromium/skia_webkit.gyp Diff Modified: trunk/Source/WebKit/chromium/ChangeLog (135753 => 135754) --- trunk/Source/WebKit/chromium/ChangeLog 2012-11-26 20:27:36 UTC (rev 135753) +++ trunk/Source/WebKit/chromium/ChangeLog 2012-11-26 20:37:06 UTC (rev 135754) @@ -1,3 +1,14 @@ +2012-11-26 Sheriff Bot webkit.review@gmail.com + +Unreviewed, rolling out r135743. +http://trac.webkit.org/changeset/135743 +https://bugs.webkit.org/show_bug.cgi?id=103280 + +Caused compile failure 'SK_DISABLE_DITHER_32BIT_GRADIENT' +macro redefined (Requested by rjkroege on #webkit). + +* skia_webkit.gyp: + 2012-11-26 Mike Reed r...@google.com add SK_DISABLE_DITHER_32BIT_GRADIENT define, in preparation for rebaselining Modified: trunk/Source/WebKit/chromium/skia_webkit.gyp (135753 => 135754) --- trunk/Source/WebKit/chromium/skia_webkit.gyp 2012-11-26 20:27:36 UTC (rev 135753) +++ trunk/Source/WebKit/chromium/skia_webkit.gyp 2012-11-26 20:37:06 UTC (rev 135754) @@ -39,9 +39,6 @@ 'defines': [ # Place defines here that require significant WebKit rebaselining, or that # are otherwise best removed in WebKit and then rolled into Chromium. - - # extracted from SkUserConfig.h, in preparation for rebaselining. - 'SK_DISABLE_DITHER_32BIT_GRADIENT', ], }, }, ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [135755] trunk/Source/WebCore
Title: [135755] trunk/Source/WebCore
Revision 135755
Author psola...@apple.com
Date 2012-11-26 12:49:06 -0800 (Mon, 26 Nov 2012)
Log Message
Add ResourceBuffer::append(CFDataRef) to get code to compile with USE(NETWORK_CFDATA_ARRAY_CALLBACK)
https://bugs.webkit.org/show_bug.cgi?id=102706
Reviewed by Brent Fulgham.
No new tests because the flag isn't enabled. Also the functionality should be covered by
existing tests.
* loader/ResourceBuffer.cpp:
(WebCore):
(WebCore::ResourceBuffer::append):
* loader/ResourceBuffer.h:
(ResourceBuffer):
* loader/mac/ResourceLoaderMac.mm:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/loader/ResourceBuffer.cpp
trunk/Source/WebCore/loader/ResourceBuffer.h
trunk/Source/WebCore/loader/mac/ResourceLoaderMac.mm
Diff
Modified: trunk/Source/WebCore/ChangeLog (135754 => 135755)
--- trunk/Source/WebCore/ChangeLog 2012-11-26 20:37:06 UTC (rev 135754)
+++ trunk/Source/WebCore/ChangeLog 2012-11-26 20:49:06 UTC (rev 135755)
@@ -1,3 +1,20 @@
+2012-11-26 Pratik Solanki psola...@apple.com
+
+Add ResourceBuffer::append(CFDataRef) to get code to compile with USE(NETWORK_CFDATA_ARRAY_CALLBACK)
+https://bugs.webkit.org/show_bug.cgi?id=102706
+
+Reviewed by Brent Fulgham.
+
+No new tests because the flag isn't enabled. Also the functionality should be covered by
+existing tests.
+
+* loader/ResourceBuffer.cpp:
+(WebCore):
+(WebCore::ResourceBuffer::append):
+* loader/ResourceBuffer.h:
+(ResourceBuffer):
+* loader/mac/ResourceLoaderMac.mm:
+
2012-11-26 Tony Chang t...@chromium.org
Move more functions from internals.settings to internals
Modified: trunk/Source/WebCore/loader/ResourceBuffer.cpp (135754 => 135755)
--- trunk/Source/WebCore/loader/ResourceBuffer.cpp 2012-11-26 20:37:06 UTC (rev 135754)
+++ trunk/Source/WebCore/loader/ResourceBuffer.cpp 2012-11-26 20:49:06 UTC (rev 135755)
@@ -71,6 +71,14 @@
m_sharedBuffer-append(data, size);
}
+#if USE(NETWORK_CFDATA_ARRAY_CALLBACK)
+void ResourceBuffer::append(CFDataRef data)
+{
+ASSERT(m_sharedBuffer);
+m_sharedBuffer-append(data);
+}
+#endif
+
void ResourceBuffer::clear()
{
m_sharedBuffer-clear();
Modified: trunk/Source/WebCore/loader/ResourceBuffer.h (135754 => 135755)
--- trunk/Source/WebCore/loader/ResourceBuffer.h 2012-11-26 20:37:06 UTC (rev 135754)
+++ trunk/Source/WebCore/loader/ResourceBuffer.h 2012-11-26 20:49:06 UTC (rev 135755)
@@ -55,6 +55,9 @@
virtual bool isEmpty() const;
void append(const char*, unsigned);
+#if USE(NETWORK_CFDATA_ARRAY_CALLBACK)
+void append(CFDataRef);
+#endif
void clear();
unsigned getSomeData(const char* data, unsigned position = 0) const;
Modified: trunk/Source/WebCore/loader/mac/ResourceLoaderMac.mm (135754 => 135755)
--- trunk/Source/WebCore/loader/mac/ResourceLoaderMac.mm 2012-11-26 20:37:06 UTC (rev 135754)
+++ trunk/Source/WebCore/loader/mac/ResourceLoaderMac.mm 2012-11-26 20:49:06 UTC (rev 135755)
@@ -35,6 +35,7 @@
#if USE(NETWORK_CFDATA_ARRAY_CALLBACK)
#include InspectorInstrumentation.h
+#include ResourceBuffer.h
#endif
#if USE(CFNETWORK)
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [135756] trunk/Source/JavaScriptCore
Title: [135756] trunk/Source/_javascript_Core
Revision 135756
Author mhahnenb...@apple.com
Date 2012-11-26 13:00:07 -0800 (Mon, 26 Nov 2012)
Log Message
JSObject::copyButterfly doesn't handle undecided indexing types correctly
https://bugs.webkit.org/show_bug.cgi?id=102573
Reviewed by Filip Pizlo.
We don't do any copying into the newly allocated vector and we don't zero-initialize CopiedBlocks
during the copying phase, so we end up with uninitialized memory in arrays which have undecided indexing
types. We should just do the actual memcpy from the old block to the new one.
* runtime/JSObject.cpp:
(JSC::JSObject::copyButterfly): Just do the same thing that we do for other contiguous indexing types.
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/runtime/JSObject.cpp
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (135755 => 135756)
--- trunk/Source/_javascript_Core/ChangeLog 2012-11-26 20:49:06 UTC (rev 135755)
+++ trunk/Source/_javascript_Core/ChangeLog 2012-11-26 21:00:07 UTC (rev 135756)
@@ -1,3 +1,17 @@
+2012-11-26 Mark Hahnenberg mhahnenb...@apple.com
+
+JSObject::copyButterfly doesn't handle undecided indexing types correctly
+https://bugs.webkit.org/show_bug.cgi?id=102573
+
+Reviewed by Filip Pizlo.
+
+We don't do any copying into the newly allocated vector and we don't zero-initialize CopiedBlocks
+during the copying phase, so we end up with uninitialized memory in arrays which have undecided indexing
+types. We should just do the actual memcpy from the old block to the new one.
+
+* runtime/JSObject.cpp:
+(JSC::JSObject::copyButterfly): Just do the same thing that we do for other contiguous indexing types.
+
2012-11-26 Julien BRIANCEAU jbrianc...@nds.com
[sh4] _javascript_Core JIT build is broken since r135330
Modified: trunk/Source/_javascript_Core/runtime/JSObject.cpp (135755 => 135756)
--- trunk/Source/_javascript_Core/runtime/JSObject.cpp 2012-11-26 20:49:06 UTC (rev 135755)
+++ trunk/Source/_javascript_Core/runtime/JSObject.cpp 2012-11-26 21:00:07 UTC (rev 135756)
@@ -129,13 +129,7 @@
size_t count;
switch (structure-indexingType()) {
-case ALL_UNDECIDED_INDEXING_TYPES: {
-currentTarget = 0;
-currentSource = 0;
-count = 0;
-break;
-}
-
+case ALL_UNDECIDED_INDEXING_TYPES:
case ALL_CONTIGUOUS_INDEXING_TYPES:
case ALL_INT32_INDEXING_TYPES:
case ALL_DOUBLE_INDEXING_TYPES: {
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [135757] trunk/Source/JavaScriptCore
Title: [135757] trunk/Source/_javascript_Core
Revision 135757
Author oli...@apple.com
Date 2012-11-26 13:20:37 -0800 (Mon, 26 Nov 2012)
Log Message
Don't blind all the things.
https://bugs.webkit.org/show_bug.cgi?id=102572
Reviewed by Gavin Barraclough.
No longer blind all the constants in the instruction stream. We use a
simple non-deterministic filter to avoid blinding everything. Also modified
the basic integer blinding logic to avoid blinding small negative values.
* assembler/MacroAssembler.h:
(MacroAssembler):
(JSC::MacroAssembler::shouldConsiderBlinding):
(JSC::MacroAssembler::shouldBlind):
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/assembler/MacroAssembler.h
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (135756 => 135757)
--- trunk/Source/_javascript_Core/ChangeLog 2012-11-26 21:00:07 UTC (rev 135756)
+++ trunk/Source/_javascript_Core/ChangeLog 2012-11-26 21:20:37 UTC (rev 135757)
@@ -1,3 +1,19 @@
+2012-11-26 Oliver Hunt oli...@apple.com
+
+Don't blind all the things.
+https://bugs.webkit.org/show_bug.cgi?id=102572
+
+Reviewed by Gavin Barraclough.
+
+No longer blind all the constants in the instruction stream. We use a
+simple non-deterministic filter to avoid blinding everything. Also modified
+the basic integer blinding logic to avoid blinding small negative values.
+
+* assembler/MacroAssembler.h:
+(MacroAssembler):
+(JSC::MacroAssembler::shouldConsiderBlinding):
+(JSC::MacroAssembler::shouldBlind):
+
2012-11-26 Mark Hahnenberg mhahnenb...@apple.com
JSObject::copyButterfly doesn't handle undecided indexing types correctly
Modified: trunk/Source/_javascript_Core/assembler/MacroAssembler.h (135756 => 135757)
--- trunk/Source/_javascript_Core/assembler/MacroAssembler.h 2012-11-26 21:00:07 UTC (rev 135756)
+++ trunk/Source/_javascript_Core/assembler/MacroAssembler.h 2012-11-26 21:20:37 UTC (rev 135757)
@@ -839,26 +839,30 @@
using MacroAssemblerBase::and64;
using MacroAssemblerBase::convertInt32ToDouble;
using MacroAssemblerBase::store64;
-
+static const unsigned BlindingModulus = 64;
+bool shouldConsiderBlinding()
+{
+return !(random() (BlindingModulus - 1));
+}
bool shouldBlindDouble(double value)
{
// Don't trust NaN or +/-Infinity
if (!isfinite(value))
-return true;
+return shouldConsiderBlinding();
// Try to force normalisation, and check that there's no change
// in the bit pattern
if (bitwise_castuint64_t(value * 1.0) != bitwise_castuint64_t(value))
-return true;
+return shouldConsiderBlinding();
value = abs(value);
// Only allow a limited set of fractional components
double scaledValue = value * 8;
if (scaledValue / 8 != value)
-return true;
+return shouldConsiderBlinding();
double frac = scaledValue - floor(scaledValue);
if (frac != 0.0)
-return true;
+return shouldConsiderBlinding();
return value 0xff;
}
@@ -887,8 +891,14 @@
default: {
if (value = 0xff)
return false;
+if (~value = 0xff)
+return false;
}
}
+
+if (!shouldConsiderBlinding())
+return false;
+
return shouldBlindForSpecificArch(value);
}
@@ -940,6 +950,9 @@
default: {
if (value = 0xff)
return false;
+if (~value = 0xff)
+return false;
+
JSValue jsValue = JSValue::decode(value);
if (jsValue.isInt32())
return shouldBlind(Imm32(jsValue.asInt32()));
@@ -950,6 +963,10 @@
return false;
}
}
+
+if (!shouldConsiderBlinding())
+return false;
+
return shouldBlindForSpecificArch(value);
}
@@ -1068,7 +1085,13 @@
default:
if (value = 0xff)
return false;
+if (~value = 0xff)
+return false;
}
+
+if (!shouldConsiderBlinding())
+return false;
+
return shouldBlindForSpecificArch(value);
#endif
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [135758] trunk/Source/WebKit/blackberry
Title: [135758] trunk/Source/WebKit/blackberry Revision 135758 Author commit-qu...@webkit.org Date 2012-11-26 13:38:45 -0800 (Mon, 26 Nov 2012) Log Message [BlackBerry] Null check calls associated with retrieving the caret rect. https://bugs.webkit.org/show_bug.cgi?id=103281 Patch by Nima Ghanavatian nghanavat...@rim.com on 2012-11-26 Reviewed by Rob Buis. Some of these calls can return null, which could lead to a crash. Internally reviewed by Gen Mak. * WebKitSupport/InputHandler.cpp: (BlackBerry::WebKit::InputHandler::requestSpellingCheckingOptions): Modified Paths trunk/Source/WebKit/blackberry/ChangeLog trunk/Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp Diff Modified: trunk/Source/WebKit/blackberry/ChangeLog (135757 => 135758) --- trunk/Source/WebKit/blackberry/ChangeLog 2012-11-26 21:20:37 UTC (rev 135757) +++ trunk/Source/WebKit/blackberry/ChangeLog 2012-11-26 21:38:45 UTC (rev 135758) @@ -1,3 +1,17 @@ +2012-11-26 Nima Ghanavatian nghanavat...@rim.com + +[BlackBerry] Null check calls associated with retrieving the caret rect. +https://bugs.webkit.org/show_bug.cgi?id=103281 + +Reviewed by Rob Buis. + +Some of these calls can return null, which could lead to a crash. + +Internally reviewed by Gen Mak. + +* WebKitSupport/InputHandler.cpp: +(BlackBerry::WebKit::InputHandler::requestSpellingCheckingOptions): + 2012-11-26 Jonathan Dong jonathan.d...@torchmobile.com.cn [BlackBerry] Should not autofill username and password when there're more than one password inputs on the same page Modified: trunk/Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp (135757 => 135758) --- trunk/Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp 2012-11-26 21:20:37 UTC (rev 135757) +++ trunk/Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp 2012-11-26 21:38:45 UTC (rev 135758) @@ -743,6 +743,9 @@ if (m_webPage-focusedOrMainFrame()-selection()-selectionType() != VisibleSelection::CaretSelection) return; +if (!m_currentFocusElement || !m_currentFocusElement-document() || !m_currentFocusElement-document()-frame()) +return; + // imf_sp_text_t should be generated in pixel viewport coordinates. WebCore::IntRect caretRect = m_webPage-focusedOrMainFrame()-selection()-selection().visibleStart().absoluteCaretBounds(); caretRect = m_webPage-focusedOrMainFrame()-view()-contentsToRootView(caretRect); ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [135759] trunk/Source/JavaScriptCore
Title: [135759] trunk/Source/_javascript_Core
Revision 135759
Author oli...@apple.com
Date 2012-11-26 13:41:28 -0800 (Mon, 26 Nov 2012)
Log Message
32-bit build fix. Move the method decalration outside of the X86_64 only section.
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/assembler/MacroAssembler.h
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (135758 => 135759)
--- trunk/Source/_javascript_Core/ChangeLog 2012-11-26 21:38:45 UTC (rev 135758)
+++ trunk/Source/_javascript_Core/ChangeLog 2012-11-26 21:41:28 UTC (rev 135759)
@@ -1,5 +1,13 @@
2012-11-26 Oliver Hunt oli...@apple.com
+32-bit build fix. Move the method decalration outside of the X86_64 only section.
+
+* assembler/MacroAssembler.h:
+(MacroAssembler):
+(JSC::MacroAssembler::shouldConsiderBlinding):
+
+2012-11-26 Oliver Hunt oli...@apple.com
+
Don't blind all the things.
https://bugs.webkit.org/show_bug.cgi?id=102572
Modified: trunk/Source/_javascript_Core/assembler/MacroAssembler.h (135758 => 135759)
--- trunk/Source/_javascript_Core/assembler/MacroAssembler.h 2012-11-26 21:38:45 UTC (rev 135758)
+++ trunk/Source/_javascript_Core/assembler/MacroAssembler.h 2012-11-26 21:41:28 UTC (rev 135759)
@@ -308,8 +308,13 @@
ASSERT(condition == Equal || condition == NotEqual);
return condition;
}
-
+static const unsigned BlindingModulus = 64;
+bool shouldConsiderBlinding()
+{
+return !(random() (BlindingModulus - 1));
+}
+
// Ptr methods
// On 32-bit platforms (i.e. x86), these methods directly map onto their 32-bit equivalents.
// FIXME: should this use a test for 32-bitness instead of this specific exception?
@@ -839,11 +844,6 @@
using MacroAssemblerBase::and64;
using MacroAssemblerBase::convertInt32ToDouble;
using MacroAssemblerBase::store64;
-static const unsigned BlindingModulus = 64;
-bool shouldConsiderBlinding()
-{
-return !(random() (BlindingModulus - 1));
-}
bool shouldBlindDouble(double value)
{
// Don't trust NaN or +/-Infinity
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [135760] trunk/Source/WebCore
Title: [135760] trunk/Source/WebCore Revision 135760 Author macpher...@chromium.org Date 2012-11-26 13:44:10 -0800 (Mon, 26 Nov 2012) Log Message Make StyleResolver::applyProperty use isInherit in CSSPropertyWebkitMarquee instead of calculating equivalent in-place. https://bugs.webkit.org/show_bug.cgi?id=102446 Reviewed by Tony Chang. !m_parentNode || !value-isInheritedValue() is equivalent to !isInherit (by De Morgan's law). No new tests / code is provably equivalent. * css/StyleResolver.cpp: (WebCore::StyleResolver::applyProperty): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/css/StyleResolver.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (135759 => 135760) --- trunk/Source/WebCore/ChangeLog 2012-11-26 21:41:28 UTC (rev 135759) +++ trunk/Source/WebCore/ChangeLog 2012-11-26 21:44:10 UTC (rev 135760) @@ -1,3 +1,17 @@ +2012-11-26 Luke Macpherson macpher...@chromium.org + +Make StyleResolver::applyProperty use isInherit in CSSPropertyWebkitMarquee instead of calculating equivalent in-place. +https://bugs.webkit.org/show_bug.cgi?id=102446 + +Reviewed by Tony Chang. + +!m_parentNode || !value-isInheritedValue() is equivalent to !isInherit (by De Morgan's law). + +No new tests / code is provably equivalent. + +* css/StyleResolver.cpp: +(WebCore::StyleResolver::applyProperty): + 2012-11-26 Pratik Solanki psola...@apple.com Add ResourceBuffer::append(CFDataRef) to get code to compile with USE(NETWORK_CFDATA_ARRAY_CALLBACK) Modified: trunk/Source/WebCore/css/StyleResolver.cpp (135759 => 135760) --- trunk/Source/WebCore/css/StyleResolver.cpp 2012-11-26 21:41:28 UTC (rev 135759) +++ trunk/Source/WebCore/css/StyleResolver.cpp 2012-11-26 21:44:10 UTC (rev 135760) @@ -3190,7 +3190,7 @@ m_style-resetColumnRule(); return; case CSSPropertyWebkitMarquee: -if (!m_parentNode || !value-isInheritedValue()) +if (!isInherit) return; m_style-setMarqueeDirection(m_parentStyle-marqueeDirection()); m_style-setMarqueeIncrement(m_parentStyle-marqueeIncrement()); ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [135761] trunk
Title: [135761] trunk Revision 135761 Author mrobin...@webkit.org Date 2012-11-26 14:00:15 -0800 (Mon, 26 Nov 2012) Log Message [GTK] Explicitly link against librt https://bugs.webkit.org/show_bug.cgi?id=103194 Patch by Kalev Lember kalevlem...@gmail.com on 2012-11-26 Reviewed by Martin Robinson. Fixes broken build with undefined references to shm_open / shm_unlink symbols. SharedMemoryUnix.cpp uses these so we need to link with -lrt. .: * configure.ac: Source/WebKit2: * GNUmakefile.am: Modified Paths trunk/ChangeLog trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/GNUmakefile.am trunk/configure.ac Diff Modified: trunk/ChangeLog (135760 => 135761) --- trunk/ChangeLog 2012-11-26 21:44:10 UTC (rev 135760) +++ trunk/ChangeLog 2012-11-26 22:00:15 UTC (rev 135761) @@ -1,3 +1,15 @@ +2012-11-26 Kalev Lember kalevlem...@gmail.com + +[GTK] Explicitly link against librt +https://bugs.webkit.org/show_bug.cgi?id=103194 + +Reviewed by Martin Robinson. + +Fixes broken build with undefined references to shm_open / shm_unlink +symbols. SharedMemoryUnix.cpp uses these so we need to link with -lrt. + +* configure.ac: + 2012-11-26 Laszlo Gombos l.gom...@samsung.com [CMake] Allow user specified compiler flags to take precedence Modified: trunk/Source/WebKit2/ChangeLog (135760 => 135761) --- trunk/Source/WebKit2/ChangeLog 2012-11-26 21:44:10 UTC (rev 135760) +++ trunk/Source/WebKit2/ChangeLog 2012-11-26 22:00:15 UTC (rev 135761) @@ -1,3 +1,15 @@ +2012-11-26 Kalev Lember kalevlem...@gmail.com + +[GTK] Explicitly link against librt +https://bugs.webkit.org/show_bug.cgi?id=103194 + +Reviewed by Martin Robinson. + +Fixes broken build with undefined references to shm_open / shm_unlink +symbols. SharedMemoryUnix.cpp uses these so we need to link with -lrt. + +* GNUmakefile.am: + 2012-11-26 Christophe Dumez christophe.du...@intel.com [EFL][WK2] Add setting to enable / disable HTML5 local storage functionality Modified: trunk/Source/WebKit2/GNUmakefile.am (135760 => 135761) --- trunk/Source/WebKit2/GNUmakefile.am 2012-11-26 21:44:10 UTC (rev 135760) +++ trunk/Source/WebKit2/GNUmakefile.am 2012-11-26 22:00:15 UTC (rev 135761) @@ -566,6 +566,7 @@ $(PANGO_LIBS) \ $(PNG_LIBS) \ $(SHLWAPI_LIBS) \ + $(SHM_LIBS) \ $(SQLITE3_LIBS) \ $(UNICODE_LIBS) \ $(XRENDER_LIBS) \ Modified: trunk/configure.ac (135760 => 135761) --- trunk/configure.ac 2012-11-26 21:44:10 UTC (rev 135760) +++ trunk/configure.ac 2012-11-26 22:00:15 UTC (rev 135761) @@ -1118,6 +1118,13 @@ if test $have_gtk_unix_printing = yes; then AC_DEFINE([HAVE_GTK_UNIX_PRINTING], [1], [Define if GTK+ UNIX Printing is available]) fi + + # On some Linux/Unix platforms, shm_* may only be available if linking + # against librt + if test $os_win32 = no; then + AC_SEARCH_LIBS([shm_open], [rt], [SHM_LIBS=-lrt]) + AC_SUBST(SHM_LIBS) + fi fi # Plugin Process ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [135762] trunk/Source/WebCore
Title: [135762] trunk/Source/WebCore
Revision 135762
Author mrobin...@webkit.org
Date 2012-11-26 14:01:01 -0800 (Mon, 26 Nov 2012)
Log Message
[GTK] GtkSocket is leaked until webview is destroyed.
https://bugs.webkit.org/show_bug.cgi?id=102564
Patch by Arnaud Renevier a.renev...@sisa.samsung.com on 2012-11-26
Reviewed by Martin Robinson.
Remove GtkSocket from its parent when pluginview is destroyed. Then,
the GtkSocket and it's possible child widgets are realeased when it is
no more needed.
No new tests, already covered by existing tests.
* plugins/gtk/PluginViewGtk.cpp:
(WebCore::PluginView::platformDestroy):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/plugins/gtk/PluginViewGtk.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (135761 => 135762)
--- trunk/Source/WebCore/ChangeLog 2012-11-26 22:00:15 UTC (rev 135761)
+++ trunk/Source/WebCore/ChangeLog 2012-11-26 22:01:01 UTC (rev 135762)
@@ -1,3 +1,19 @@
+2012-11-26 Arnaud Renevier a.renev...@sisa.samsung.com
+
+[GTK] GtkSocket is leaked until webview is destroyed.
+https://bugs.webkit.org/show_bug.cgi?id=102564
+
+Reviewed by Martin Robinson.
+
+Remove GtkSocket from its parent when pluginview is destroyed. Then,
+the GtkSocket and it's possible child widgets are realeased when it is
+no more needed.
+
+No new tests, already covered by existing tests.
+
+* plugins/gtk/PluginViewGtk.cpp:
+(WebCore::PluginView::platformDestroy):
+
2012-11-26 Luke Macpherson macpher...@chromium.org
Make StyleResolver::applyProperty use isInherit in CSSPropertyWebkitMarquee instead of calculating equivalent in-place.
Modified: trunk/Source/WebCore/plugins/gtk/PluginViewGtk.cpp (135761 => 135762)
--- trunk/Source/WebCore/plugins/gtk/PluginViewGtk.cpp 2012-11-26 22:00:15 UTC (rev 135761)
+++ trunk/Source/WebCore/plugins/gtk/PluginViewGtk.cpp 2012-11-26 22:01:01 UTC (rev 135762)
@@ -883,6 +883,13 @@
XFreePixmap(GDK_DISPLAY_XDISPLAY(gdk_display_get_default()), m_drawable);
m_drawable = 0;
}
+
+GtkWidget* widget = platformWidget();
+if (widget) {
+GtkWidget* parent = gtk_widget_get_parent(widget);
+ASSERT(parent);
+gtk_container_remove(GTK_CONTAINER(parent), widget);
+}
}
} // namespace WebCore
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [135763] trunk/Source/WebCore
Title: [135763] trunk/Source/WebCore Revision 135763 Author bfulg...@webkit.org Date 2012-11-26 14:11:42 -0800 (Mon, 26 Nov 2012) Log Message clipboardwin compile error for win64 https://bugs.webkit.org/show_bug.cgi?id=94124 Patch by Alex Christensen alex.christen...@flexsim.com on 2012-11-26 Reviewed by Brent Fulgham. The clipboard utilities code uses std::min with one unsigned int parameter and one size_t parameter. This causes a problem when compiling for 64-bit Windows because the two types are not the same size. To resolve this issue, we specify the template type as the type the return value is being cast into Fixed a few compile errors for Windows x64 by specifying template parameters. * platform/win/ClipboardUtilitiesWin.cpp: (WebCore::setFileDescriptorData): Specify the types for the std::min macro to avoid compiler errors under 64-bit builds. Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/platform/win/ClipboardUtilitiesWin.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (135762 => 135763) --- trunk/Source/WebCore/ChangeLog 2012-11-26 22:01:01 UTC (rev 135762) +++ trunk/Source/WebCore/ChangeLog 2012-11-26 22:11:42 UTC (rev 135763) @@ -1,3 +1,20 @@ +2012-11-26 Alex Christensen alex.christen...@flexsim.com + +clipboardwin compile error for win64 +https://bugs.webkit.org/show_bug.cgi?id=94124 + +Reviewed by Brent Fulgham. + +The clipboard utilities code uses std::min with one unsigned int parameter and one size_t parameter. +This causes a problem when compiling for 64-bit Windows because the two types are not the same size. +To resolve this issue, we specify the template type as the type the return value is being cast into + +Fixed a few compile errors for Windows x64 by specifying template parameters. + +* platform/win/ClipboardUtilitiesWin.cpp: +(WebCore::setFileDescriptorData): Specify the types for the std::min macro to avoid compiler errors +under 64-bit builds. + 2012-11-26 Arnaud Renevier a.renev...@sisa.samsung.com [GTK] GtkSocket is leaked until webview is destroyed. Modified: trunk/Source/WebCore/platform/win/ClipboardUtilitiesWin.cpp (135762 => 135763) --- trunk/Source/WebCore/platform/win/ClipboardUtilitiesWin.cpp 2012-11-26 22:01:01 UTC (rev 135762) +++ trunk/Source/WebCore/platform/win/ClipboardUtilitiesWin.cpp 2012-11-26 22:11:42 UTC (rev 135763) @@ -433,7 +433,7 @@ fgd-fgd[0].dwFlags = FD_FILESIZE; fgd-fgd[0].nFileSizeLow = size; -int maxSize = std::min(pathname.length(), WTF_ARRAY_LENGTH(fgd-fgd[0].cFileName)); +int maxSize = std::minint(pathname.length(), WTF_ARRAY_LENGTH(fgd-fgd[0].cFileName)); CopyMemory(fgd-fgd[0].cFileName, pathname.charactersWithNullTermination(), maxSize * sizeof(UChar)); GlobalUnlock(medium.hGlobal); ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [135764] branches/safari-536.28-branch
Title: [135764] branches/safari-536.28-branch
Revision 135764
Author lforsch...@apple.com
Date 2012-11-26 14:15:06 -0800 (Mon, 26 Nov 2012)
Log Message
Merged r132924. rdar://problem/12603373
Modified Paths
branches/safari-536.28-branch/LayoutTests/ChangeLog
branches/safari-536.28-branch/Source/WebCore/ChangeLog
branches/safari-536.28-branch/Source/WebCore/WebCore.exp.in
branches/safari-536.28-branch/Source/WebCore/editing/Editor.cpp
branches/safari-536.28-branch/Source/WebCore/editing/TextIterator.cpp
branches/safari-536.28-branch/Source/WebCore/editing/TextIterator.h
Added Paths
branches/safari-536.28-branch/LayoutTests/platform/mac/editing/spelling/autocorrection-in-textarea-expected.txt
branches/safari-536.28-branch/LayoutTests/platform/mac/editing/spelling/autocorrection-in-textarea.html
Diff
Modified: branches/safari-536.28-branch/LayoutTests/ChangeLog (135763 => 135764)
--- branches/safari-536.28-branch/LayoutTests/ChangeLog 2012-11-26 22:11:42 UTC (rev 135763)
+++ branches/safari-536.28-branch/LayoutTests/ChangeLog 2012-11-26 22:15:06 UTC (rev 135764)
@@ -1,5 +1,19 @@
2012-11-26 Lucas Forschler lforsch...@apple.com
+Merge r132924
+
+2012-10-30 Dan Bernstein m...@apple.com
+
+rdar://problem/12395187 REGRESSION (r121299): OS X Text Replacement forces cursor out of text fields
+https://bugs.webkit.org/show_bug.cgi?id=100768
+
+Reviewed by Anders Carlsson.
+
+* platform/mac/editing/spelling/autocorrection-in-textarea-expected.txt: Added.
+* platform/mac/editing/spelling/autocorrection-in-textarea.html: Added.
+
+2012-11-26 Lucas Forschler lforsch...@apple.com
+
Merge r132713
2012-10-26 Anders Carlsson ander...@apple.com
Copied: branches/safari-536.28-branch/LayoutTests/platform/mac/editing/spelling/autocorrection-in-textarea-expected.txt (from rev 132924, trunk/LayoutTests/platform/mac/editing/spelling/autocorrection-in-textarea-expected.txt) (0 => 135764)
--- branches/safari-536.28-branch/LayoutTests/platform/mac/editing/spelling/autocorrection-in-textarea-expected.txt (rev 0)
+++ branches/safari-536.28-branch/LayoutTests/platform/mac/editing/spelling/autocorrection-in-textarea-expected.txt 2012-11-26 22:15:06 UTC (rev 135764)
@@ -0,0 +1,3 @@
+0123456789
+
+PASS
Copied: branches/safari-536.28-branch/LayoutTests/platform/mac/editing/spelling/autocorrection-in-textarea.html (from rev 132924, trunk/LayoutTests/platform/mac/editing/spelling/autocorrection-in-textarea.html) (0 => 135764)
--- branches/safari-536.28-branch/LayoutTests/platform/mac/editing/spelling/autocorrection-in-textarea.html (rev 0)
+++ branches/safari-536.28-branch/LayoutTests/platform/mac/editing/spelling/autocorrection-in-textarea.html 2012-11-26 22:15:06 UTC (rev 135764)
@@ -0,0 +1,27 @@
+div contenteditable
+0123456789
+/div
+script
+if (window.testRunner)
+testRunner.dumpAsText();
+
+_onload_ = function() {
+var textarea = document.getElementById(textarea);
+textarea.focus();
+var hasBeenBlurred = false;
+textarea._onblur_ = function() {
+hasBeenBlurred = true;
+}
+
+document.execCommand(InsertText, false, te);
+document.execCommand(InsertText, false, h);
+document.execCommand(InsertText, false, );
+
+document.execCommand(InsertText, false, test result is);
+
+var result = textarea.value === the test result is ? PASS : FAIL;
+document.getElementById(result).appendChild(document.createTextNode(result));
+}
+/script
+textarea id=textarea/textarea
+p id=result/p
Modified: branches/safari-536.28-branch/Source/WebCore/ChangeLog (135763 => 135764)
--- branches/safari-536.28-branch/Source/WebCore/ChangeLog 2012-11-26 22:11:42 UTC (rev 135763)
+++ branches/safari-536.28-branch/Source/WebCore/ChangeLog 2012-11-26 22:15:06 UTC (rev 135764)
@@ -1,3 +1,28 @@
+2012-11-26 Lucas Forschler lforsch...@apple.com
+
+Merge r132924
+
+2012-10-30 Dan Bernstein m...@apple.com
+
+rdar://problem/12395187 REGRESSION (r121299): OS X Text Replacement forces cursor out of text fields
+https://bugs.webkit.org/show_bug.cgi?id=100768
+
+Reviewed by Anders Carlsson.
+
+r121299 introduced code to restore the paragraph range by saving its length and start offset
+relative to the document. The latter was obtained by iterating over the range starting at
+the beginning of the document and ending at the beginning of the paragraph range. However,
+such a range could not be constructed if the paragraph range was contained in a shadow DOM,
+since a range must have both its endpoints within the same shadow tree (or not in a shadow
+tree).
+
+Test: platform/mac/editing/spelling/autocorrection-in-textarea.html
+
+*
[webkit-changes] [135765] trunk
Title: [135765] trunk
Revision 135765
Author commit-qu...@webkit.org
Date 2012-11-26 14:24:31 -0800 (Mon, 26 Nov 2012)
Log Message
Refactor V8 bindings to allow content scripts to access subframes
https://bugs.webkit.org/show_bug.cgi?id=93646
Patch by Dan Carney dcar...@google.com on 2012-11-26
Reviewed by Adam Barth.
Source/WebCore:
Isolated window shells are now initialized on the fly
as needed.
No new tests. Existing test modified.
* bindings/v8/DOMWrapperWorld.cpp:
(WebCore::DOMWrapperWorld::ensureIsolatedWorld):
* bindings/v8/DOMWrapperWorld.h:
(WebCore::DOMWrapperWorld::createdFromUnitializedWorld):
(DOMWrapperWorld):
* bindings/v8/ScriptController.cpp:
(WebCore::ScriptController::currentWorldContext):
LayoutTests:
Test modified to check isolated world access across frames.
* http/tests/security/isolatedWorld/world-reuse-expected.txt:
* http/tests/security/isolatedWorld/world-reuse.html:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/http/tests/security/isolatedWorld/world-reuse-expected.txt
trunk/LayoutTests/http/tests/security/isolatedWorld/world-reuse.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/v8/DOMWrapperWorld.cpp
trunk/Source/WebCore/bindings/v8/DOMWrapperWorld.h
trunk/Source/WebCore/bindings/v8/ScriptController.cpp
Diff
Modified: trunk/LayoutTests/ChangeLog (135764 => 135765)
--- trunk/LayoutTests/ChangeLog 2012-11-26 22:15:06 UTC (rev 135764)
+++ trunk/LayoutTests/ChangeLog 2012-11-26 22:24:31 UTC (rev 135765)
@@ -1,3 +1,15 @@
+2012-11-26 Dan Carney dcar...@google.com
+
+Refactor V8 bindings to allow content scripts to access subframes
+https://bugs.webkit.org/show_bug.cgi?id=93646
+
+Reviewed by Adam Barth.
+
+Test modified to check isolated world access across frames.
+
+* http/tests/security/isolatedWorld/world-reuse-expected.txt:
+* http/tests/security/isolatedWorld/world-reuse.html:
+
2012-11-26 Tony Chang t...@chromium.org
Move more functions from internals.settings to internals
Modified: trunk/LayoutTests/http/tests/security/isolatedWorld/world-reuse-expected.txt (135764 => 135765)
--- trunk/LayoutTests/http/tests/security/isolatedWorld/world-reuse-expected.txt 2012-11-26 22:15:06 UTC (rev 135764)
+++ trunk/LayoutTests/http/tests/security/isolatedWorld/world-reuse-expected.txt 2012-11-26 22:24:31 UTC (rev 135765)
@@ -2,6 +2,8 @@
Expecting undefined: undefined
Expecting bar: bar
Expecting undefined: undefined
+Expecting true: true
+Expecting true: true
Expecting undefined,undefined: undefined,undefined
Expecting undefined,undefined: undefined,undefined
Modified: trunk/LayoutTests/http/tests/security/isolatedWorld/world-reuse.html (135764 => 135765)
--- trunk/LayoutTests/http/tests/security/isolatedWorld/world-reuse.html 2012-11-26 22:15:06 UTC (rev 135764)
+++ trunk/LayoutTests/http/tests/security/isolatedWorld/world-reuse.html 2012-11-26 22:24:31 UTC (rev 135765)
@@ -30,10 +30,22 @@
document.body.insertBefore(iframe, document.body.firstChild);
document.body.insertBefore(document.createElement(br), iframe.nextSibling);
var iframeComplete = function(result) {
+
+// Isolated world executing in frame should be able to to access parent content.
+testRunner.evaluateScriptInIsolatedWorld(1,
+ parent.document.body.appendChild(parent.document.createTextNode('Expecting true: ' + (parent.frames[0].document == this.document))); +
+ parent.document.body.appendChild(parent.document.createElement('br')););
+
document.body.appendChild(document.createTextNode('Expecting undefined,undefined: ' + result));
document.body.appendChild(document.createElement('br'));
reloadFrame();
}
+
+ // Isolated world executing in window should be able to to access frame content.
+ testRunner.evaluateScriptInIsolatedWorld(1,
+document.body.appendChild(document.createTextNode('Expecting true: ' + !!frames[0].document)); +
+document.body.appendChild(document.createElement('br')););
+
iframe.src = ""
// Also, navigating a single frame should not result in sharing variables.
Modified: trunk/Source/WebCore/ChangeLog (135764 => 135765)
--- trunk/Source/WebCore/ChangeLog 2012-11-26 22:15:06 UTC (rev 135764)
+++ trunk/Source/WebCore/ChangeLog 2012-11-26 22:24:31 UTC (rev 135765)
@@ -1,3 +1,23 @@
+2012-11-26 Dan Carney dcar...@google.com
+
+Refactor V8 bindings to allow content scripts to access subframes
+https://bugs.webkit.org/show_bug.cgi?id=93646
+
+Reviewed by Adam Barth.
+
+Isolated window shells are now initialized on the fly
+as needed.
+
+No new tests. Existing test modified.
+
+* bindings/v8/DOMWrapperWorld.cpp:
+(WebCore::DOMWrapperWorld::ensureIsolatedWorld):
+* bindings/v8/DOMWrapperWorld.h:
+(WebCore::DOMWrapperWorld::createdFromUnitializedWorld):
+(DOMWrapperWorld):
+* bindings/v8/ScriptController.cpp:
+
[webkit-changes] [135766] trunk
Title: [135766] trunk Revision 135766 Author roger_f...@apple.com Date 2012-11-26 14:34:47 -0800 (Mon, 26 Nov 2012) Log Message Unreviewed. ENABLE_ACCELERATED_OVERFLOW_SCROLLING not enabled on Windows. Add a feature flag and skip some failing tests. https://bugs.webkit.org/show_bug.cgi?id=103294 Tests skipped: compositing/overflow/scrolling-without-painting.html compositing/overflow/updating-scrolling-content.html * win/tools/vsprops/FeatureDefines.vsprops: * platform/win/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/win/TestExpectations trunk/WebKitLibraries/ChangeLog trunk/WebKitLibraries/win/tools/vsprops/FeatureDefines.vsprops Diff Modified: trunk/LayoutTests/ChangeLog (135765 => 135766) --- trunk/LayoutTests/ChangeLog 2012-11-26 22:24:31 UTC (rev 135765) +++ trunk/LayoutTests/ChangeLog 2012-11-26 22:34:47 UTC (rev 135766) @@ -1,3 +1,15 @@ +2012-11-26 Roger Fong roger_f...@apple.com + +Unreviewed. ENABLE_ACCELERATED_OVERFLOW_SCROLLING not enabled on Windows. +Add a feature flag and skip some failing tests. +https://bugs.webkit.org/show_bug.cgi?id=103294 + +Tests skipped: +compositing/overflow/scrolling-without-painting.html +compositing/overflow/updating-scrolling-content.html + +* platform/win/TestExpectations: + 2012-11-26 Dan Carney dcar...@google.com Refactor V8 bindings to allow content scripts to access subframes Modified: trunk/LayoutTests/platform/win/TestExpectations (135765 => 135766) --- trunk/LayoutTests/platform/win/TestExpectations 2012-11-26 22:24:31 UTC (rev 135765) +++ trunk/LayoutTests/platform/win/TestExpectations 2012-11-26 22:34:47 UTC (rev 135766) @@ -2433,3 +2433,7 @@ fast/css3-text/css3-text-align-last/getComputedStyle/getComputedStyle-text-align-last-inherited.html fast/css3-text/css3-text-align-last/getComputedStyle/getComputedStyle-text-align-last.html fast/css3-text/css3-text-decoration/getComputedStyle/getComputedStyle-text-decoration-line.html + +#ACCELERATED_OVERFLOW_SCROLLING is disabled on Windows +compositing/overflow/scrolling-without-painting.html +compositing/overflow/updating-scrolling-content.html Modified: trunk/WebKitLibraries/ChangeLog (135765 => 135766) --- trunk/WebKitLibraries/ChangeLog 2012-11-26 22:24:31 UTC (rev 135765) +++ trunk/WebKitLibraries/ChangeLog 2012-11-26 22:34:47 UTC (rev 135766) @@ -1,3 +1,15 @@ +2012-11-26 Roger Fong roger_f...@apple.com + +Unreviewed. ENABLE_ACCELERATED_OVERFLOW_SCROLLING not enabled on Windows. +Add a feature flag and skip some failing tests. +https://bugs.webkit.org/show_bug.cgi?id=103294 + +Tests skipped: +compositing/overflow/scrolling-without-painting.html +compositing/overflow/updating-scrolling-content.html + +* win/tools/vsprops/FeatureDefines.vsprops: + 2012-11-23 Alexis Menard ale...@webkit.org [CSS3 Backgrounds and Borders] Implement new CSS3 background-position parsing. Modified: trunk/WebKitLibraries/win/tools/vsprops/FeatureDefines.vsprops (135765 => 135766) --- trunk/WebKitLibraries/win/tools/vsprops/FeatureDefines.vsprops 2012-11-26 22:24:31 UTC (rev 135765) +++ trunk/WebKitLibraries/win/tools/vsprops/FeatureDefines.vsprops 2012-11-26 22:34:47 UTC (rev 135766) @@ -9,7 +9,7 @@ Tool Name=VCCLCompilerTool -
[webkit-changes] [135767] trunk/Source
Title: [135767] trunk/Source Revision 135767 Author jon...@apple.com Date 2012-11-26 14:36:03 -0800 (Mon, 26 Nov 2012) Log Message Pass clicks through to the restarted plugin https://bugs.webkit.org/show_bug.cgi?id=102150 rdar://problem/12695575 Reviewed by Simon Fraser. Source/WebCore: Add a new state to the machine for plugin snapshotting, called PlayingWithPendingMouseClick. This represents the state where the plugin is playing, but before the pending mouse click has been fired. Once the click is sent, the plugin state transitions to Playing. For situations where the plugin just runs normally without a simulated click, the plugin state jumps from DisplayingSnapshot straight to Playing, as before. * html/HTMLPlugInElement.h: Add new display state to represent when the plugin is running, but a pending mouse click is about to be sent to the plugin. (WebCore::HTMLPlugInElement::dispatchPendingMouseClick): Called by the plugin when it is ok for the element to send the pending mouse click. * html/HTMLPlugInElement.cpp: (WebCore::HTMLPlugInElement::defaultEventHandler): Update the handler to pass the event to the renderer to handle if the state is before PlayingWithPendingMouseClick. * html/HTMLPlugInImageElement.h: * html/HTMLPlugInImageElement.cpp: Add a click timer to delay the mouse click so that the plugin has some time to initialize. (WebCore::HTMLPlugInImageElement::HTMLPlugInImageElement): Initialize the mouse timer. (WebCore::HTMLPlugInImageElement::setPendingClickEvent): Keep track of the click event the user made to restart the plugin. (WebCore::HTMLPlugInImageElement::dispatchPendingMouseClick): Start the timer. (WebCore::HTMLPlugInImageElement::simulatedMouseClickTimerFired): When the timer fires, dispatch the simulated click, with mouse over, mouse down, and mouse up events. Transition to the Playing state, and we no longer need the click event. * rendering/RenderSnapshottedPlugIn.cpp: Change the threshold state to PlayingWithPendingMouseClick instead of Playing, since that is the earliest state where the plugin is playing. (WebCore::RenderSnapshottedPlugIn::paint): (WebCore::RenderSnapshottedPlugIn::paintReplaced): (WebCore::RenderSnapshottedPlugIn::getCursor): (WebCore::RenderSnapshottedPlugIn::handleEvent): If the user clicked on the button, jump to Playing, and don't send a simulated click. Otherwise, transition to PlayingWithPendingMouseClick, and keep track of that mouse event. * WebCore.exp.in: Export MouseRelatedEvent::offsetX() and offsetY(). Source/WebKit2: Expose convertToRootView() as a public function for all plugins. It converts the click point from local plugin coordinates to root view coordinates. When the events are sent to the plugin, the coordinate gets converted back to the local reference frame. * WebProcess/Plugins/Plugin.cpp: (WebKit::Plugin::convertToRootView): Default implementation should not be reached. * WebProcess/Plugins/Plugin.h: Promote convertToRootView() from NetscapePlugin.h. * WebProcess/Plugins/Netscape/NetscapePlugin.h: An implementation already existed. Make the method virtual. * WebProcess/Plugins/PluginProxy.h: * WebProcess/Plugins/PluginProxy.cpp: (WebKit::PluginProxy::convertToRootView): Apply the transform to the provided point to return a point in root view coordinates. Change the threshold state to PlayingWithPendingMouseClick instead of Playing, since that is the earliest state where the plugin is playing. * WebProcess/Plugins/PluginView.cpp: Give the snapshot a little more time to generate. (WebKit::PluginView::didInitializePlugin): When the plugin has initialized, tell the plugin element to dispatch the pending mouse click. (WebKit::PluginView::paint): (WebKit::PluginView::createWebEvent): Helper function to convert a WebCore mouse event to a WebMouseEvent. (WebKit::PluginView::handleEvent): If the event is simulated, there is no source event from the UI process. So we fabricate one based on the simulated event. (WebKit::PluginView::invalidateRect): (WebKit::PluginView::isAcceleratedCompositingEnabled): * WebProcess/Plugins/PluginView.h: Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/WebCore.exp.in trunk/Source/WebCore/html/HTMLPlugInElement.cpp trunk/Source/WebCore/html/HTMLPlugInElement.h trunk/Source/WebCore/html/HTMLPlugInImageElement.cpp trunk/Source/WebCore/html/HTMLPlugInImageElement.h trunk/Source/WebCore/rendering/RenderSnapshottedPlugIn.cpp trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/WebProcess/Plugins/Netscape/NetscapePlugin.h trunk/Source/WebKit2/WebProcess/Plugins/Plugin.cpp trunk/Source/WebKit2/WebProcess/Plugins/Plugin.h trunk/Source/WebKit2/WebProcess/Plugins/PluginProxy.cpp trunk/Source/WebKit2/WebProcess/Plugins/PluginProxy.h trunk/Source/WebKit2/WebProcess/Plugins/PluginView.cpp trunk/Source/WebKit2/WebProcess/Plugins/PluginView.h Diff Modified: trunk/Source/WebCore/ChangeLog (135766 => 135767) --- trunk/Source/WebCore/ChangeLog 2012-11-26 22:34:47 UTC (rev 135766) +++
[webkit-changes] [135768] branches/safari-536.28-branch/Source/WebKit2
Title: [135768] branches/safari-536.28-branch/Source/WebKit2
Revision 135768
Author lforsch...@apple.com
Date 2012-11-26 14:37:56 -0800 (Mon, 26 Nov 2012)
Log Message
Merged r131975. rdar://problem/12589198
Modified Paths
branches/safari-536.28-branch/Source/WebKit2/ChangeLog
branches/safari-536.28-branch/Source/WebKit2/UIProcess/WebContext.cpp
Diff
Modified: branches/safari-536.28-branch/Source/WebKit2/ChangeLog (135767 => 135768)
--- branches/safari-536.28-branch/Source/WebKit2/ChangeLog 2012-11-26 22:36:03 UTC (rev 135767)
+++ branches/safari-536.28-branch/Source/WebKit2/ChangeLog 2012-11-26 22:37:56 UTC (rev 135768)
@@ -1,5 +1,23 @@
2012-11-26 Lucas Forschler lforsch...@apple.com
+Merge r131975
+
+2012-10-19 Andreas Kling kl...@webkit.org
+
+Race condition in WebProcessProxy::handleGetPlugins().
+http://webkit.org/b/99903
+rdar://problem/12541471
+
+Reviewed by Anders Carlsson.
+
+Scope the VectorPluginModuleInfo so that all the destructors are guaranteed
+to have run when sendDidGetPlugins() executes on the main thread.
+
+* UIProcess/WebProcessProxy.cpp:
+(WebKit::WebProcessProxy::handleGetPlugins):
+
+2012-11-26 Lucas Forschler lforsch...@apple.com
+
Merge r132713
2012-10-26 Anders Carlsson ander...@apple.com
Modified: branches/safari-536.28-branch/Source/WebKit2/UIProcess/WebContext.cpp (135767 => 135768)
--- branches/safari-536.28-branch/Source/WebKit2/UIProcess/WebContext.cpp 2012-11-26 22:36:03 UTC (rev 135767)
+++ branches/safari-536.28-branch/Source/WebKit2/UIProcess/WebContext.cpp 2012-11-26 22:37:56 UTC (rev 135768)
@@ -635,9 +635,11 @@
OwnPtrVectorPluginInfo pluginInfos = adoptPtr(new VectorPluginInfo);
-VectorPluginModuleInfo plugins = m_pluginInfoStore.plugins();
-for (size_t i = 0; i plugins.size(); ++i)
-pluginInfos-append(plugins[i].info);
+{
+VectorPluginModuleInfo plugins = m_pluginInfoStore.plugins();
+for (size_t i = 0; i plugins.size(); ++i)
+pluginInfos-append(plugins[i].info);
+}
// NOTE: We have to pass the PluginInfo vector to the secondary thread via a pointer as otherwise
// we'd end up with a deref() race on all the WTF::Strings it contains.
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [135769] trunk/Source/WebKit/chromium
Title: [135769] trunk/Source/WebKit/chromium
Revision 135769
Author commit-qu...@webkit.org
Date 2012-11-26 14:43:40 -0800 (Mon, 26 Nov 2012)
Log Message
Unreviewed. Rolled DEPS.
Patch by Sheriff Bot webkit.review@gmail.com on 2012-11-26
* DEPS:
Modified Paths
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/DEPS
Diff
Modified: trunk/Source/WebKit/chromium/ChangeLog (135768 => 135769)
--- trunk/Source/WebKit/chromium/ChangeLog 2012-11-26 22:37:56 UTC (rev 135768)
+++ trunk/Source/WebKit/chromium/ChangeLog 2012-11-26 22:43:40 UTC (rev 135769)
@@ -1,5 +1,11 @@
2012-11-26 Sheriff Bot webkit.review@gmail.com
+Unreviewed. Rolled DEPS.
+
+* DEPS:
+
+2012-11-26 Sheriff Bot webkit.review@gmail.com
+
Unreviewed, rolling out r135743.
http://trac.webkit.org/changeset/135743
https://bugs.webkit.org/show_bug.cgi?id=103280
Modified: trunk/Source/WebKit/chromium/DEPS (135768 => 135769)
--- trunk/Source/WebKit/chromium/DEPS 2012-11-26 22:37:56 UTC (rev 135768)
+++ trunk/Source/WebKit/chromium/DEPS 2012-11-26 22:43:40 UTC (rev 135769)
@@ -32,7 +32,7 @@
vars = {
'chromium_svn': 'http://src.chromium.org/svn/trunk/src',
- 'chromium_rev': '169306'
+ 'chromium_rev': '169445'
}
deps = {
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [135770] trunk/Source
Title: [135770] trunk/Source
Revision 135770
Author zeno.albis...@digia.com
Date 2012-11-26 14:45:20 -0800 (Mon, 26 Nov 2012)
Log Message
[Qt] Fix the LLInt build on Mac
https://bugs.webkit.org/show_bug.cgi?id=97587
Reviewed by Simon Hausmann.
Source/_javascript_Core:
* DerivedSources.pri:
* _javascript_Core.pro:
Source/WTF:
* wtf/InlineASM.h:
Use OS(DARWIN) instead of PLATFORM(MAC),
in order to allow Qt to use the same code.
* wtf/Platform.h:
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/DerivedSources.pri
trunk/Source/_javascript_Core/_javascript_Core.pro
trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/InlineASM.h
trunk/Source/WTF/wtf/Platform.h
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (135769 => 135770)
--- trunk/Source/_javascript_Core/ChangeLog 2012-11-26 22:43:40 UTC (rev 135769)
+++ trunk/Source/_javascript_Core/ChangeLog 2012-11-26 22:45:20 UTC (rev 135770)
@@ -1,3 +1,13 @@
+2012-11-26 Zeno Albisser z...@webkit.org
+
+[Qt] Fix the LLInt build on Mac
+https://bugs.webkit.org/show_bug.cgi?id=97587
+
+Reviewed by Simon Hausmann.
+
+* DerivedSources.pri:
+* _javascript_Core.pro:
+
2012-11-26 Oliver Hunt oli...@apple.com
32-bit build fix. Move the method decalration outside of the X86_64 only section.
Modified: trunk/Source/_javascript_Core/DerivedSources.pri (135769 => 135770)
--- trunk/Source/_javascript_Core/DerivedSources.pri 2012-11-26 22:43:40 UTC (rev 135769)
+++ trunk/Source/_javascript_Core/DerivedSources.pri 2012-11-26 22:45:20 UTC (rev 135770)
@@ -102,15 +102,13 @@
exists($$file): LLINT_FILES += $$file
}
-if(linux-*|win32) {
-#GENERATOR: LLInt
-llint.output = ${QMAKE_FILE_IN_PATH}$${QMAKE_DIR_SEP}LLIntAssembly.h
-llint.script = $$PWD/offlineasm/asm.rb
-llint.input = LLINT_FILES
-llint.depends = $$LLINT_DEPENDENCY
-llint.commands = ruby $$llint.script $$LLINT_ASSEMBLER ${QMAKE_FILE_IN} ${QMAKE_FILE_OUT}
-GENERATORS += llint
-}
+#GENERATOR: LLInt
+llint.output = ${QMAKE_FILE_IN_PATH}$${QMAKE_DIR_SEP}LLIntAssembly.h
+llint.script = $$PWD/offlineasm/asm.rb
+llint.input = LLINT_FILES
+llint.depends = $$LLINT_DEPENDENCY
+llint.commands = ruby $$llint.script $$LLINT_ASSEMBLER ${QMAKE_FILE_IN} ${QMAKE_FILE_OUT}
+GENERATORS += llint
linux-*:if(isEqual(QT_ARCH, i386)|isEqual(QT_ARCH, x86_64)) {
# GENERATOR: disassembler
Modified: trunk/Source/_javascript_Core/_javascript_Core.pro (135769 => 135770)
--- trunk/Source/_javascript_Core/_javascript_Core.pro 2012-11-26 22:43:40 UTC (rev 135769)
+++ trunk/Source/_javascript_Core/_javascript_Core.pro 2012-11-26 22:45:20 UTC (rev 135770)
@@ -7,18 +7,16 @@
TEMPLATE = subdirs
CONFIG += ordered
-if(linux-*|win32*) {
-LLIntOffsetsExtractor.file = LLIntOffsetsExtractor.pro
-LLIntOffsetsExtractor.makefile = Makefile.LLIntOffsetsExtractor
-SUBDIRS += LLIntOffsetsExtractor
-}
+LLIntOffsetsExtractor.file = LLIntOffsetsExtractor.pro
+LLIntOffsetsExtractor.makefile = Makefile.LLIntOffsetsExtractor
+SUBDIRS += LLIntOffsetsExtractor
derived_sources.file = DerivedSources.pri
target.file = Target.pri
SUBDIRS += derived_sources target
-if(linux-*|win32*):addStrictSubdirOrderBetween(LLIntOffsetsExtractor, derived_sources)
+addStrictSubdirOrderBetween(LLIntOffsetsExtractor, derived_sources)
addStrictSubdirOrderBetween(derived_sources, target)
jsc.file = jsc.pro
Modified: trunk/Source/WTF/ChangeLog (135769 => 135770)
--- trunk/Source/WTF/ChangeLog 2012-11-26 22:43:40 UTC (rev 135769)
+++ trunk/Source/WTF/ChangeLog 2012-11-26 22:45:20 UTC (rev 135770)
@@ -1,3 +1,15 @@
+2012-11-26 Zeno Albisser z...@webkit.org
+
+[Qt] Fix the LLInt build on Mac
+https://bugs.webkit.org/show_bug.cgi?id=97587
+
+Reviewed by Simon Hausmann.
+
+* wtf/InlineASM.h:
+Use OS(DARWIN) instead of PLATFORM(MAC),
+in order to allow Qt to use the same code.
+* wtf/Platform.h:
+
2012-11-26 Patrick Gansterer par...@webkit.org
Build fix for WinCE after r135640.
Modified: trunk/Source/WTF/wtf/InlineASM.h (135769 => 135770)
--- trunk/Source/WTF/wtf/InlineASM.h 2012-11-26 22:43:40 UTC (rev 135769)
+++ trunk/Source/WTF/wtf/InlineASM.h 2012-11-26 22:45:20 UTC (rev 135770)
@@ -77,7 +77,7 @@
// FIXME: figure out how this works on all the platforms. I know that
// on ELF, the preferred form is .Lstuff as opposed to Lstuff.
// Don't know about any of the others.
-#if PLATFORM(MAC)
+#if OS(DARWIN)
#define LOCAL_LABEL_STRING(name) L #name
#elif OS(LINUX) \
|| OS(FREEBSD) \
Modified: trunk/Source/WTF/wtf/Platform.h (135769 => 135770)
--- trunk/Source/WTF/wtf/Platform.h 2012-11-26 22:43:40 UTC (rev 135769)
+++ trunk/Source/WTF/wtf/Platform.h 2012-11-26 22:45:20 UTC (rev 135770)
@@ -926,7 +926,7 @@
#if !defined(ENABLE_LLINT) \
ENABLE(JIT) \
(OS(DARWIN) || OS(LINUX)) \
-
[webkit-changes] [135771] trunk/LayoutTests
Title: [135771] trunk/LayoutTests Revision 135771 Author roger_f...@apple.com Date 2012-11-26 14:52:41 -0800 (Mon, 26 Nov 2012) Log Message Unreviewed. Skip fast/dom/Window/open-window-min-size.html on Windows. DRT doesn't support showModalDialog https://bugs.webkit.org/show_bug.cgi?id=53675 * platform/win/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/win/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (135770 => 135771) --- trunk/LayoutTests/ChangeLog 2012-11-26 22:45:20 UTC (rev 135770) +++ trunk/LayoutTests/ChangeLog 2012-11-26 22:52:41 UTC (rev 135771) @@ -1,5 +1,12 @@ 2012-11-26 Roger Fong roger_f...@apple.com +Unreviewed. Skip fast/dom/Window/open-window-min-size.html on Windows. +DRT doesn't support showModalDialog https://bugs.webkit.org/show_bug.cgi?id=53675. + +* platform/win/TestExpectations: + +2012-11-26 Roger Fong roger_f...@apple.com + Unreviewed. ENABLE_ACCELERATED_OVERFLOW_SCROLLING not enabled on Windows. Add a feature flag and skip some failing tests. https://bugs.webkit.org/show_bug.cgi?id=103294 Modified: trunk/LayoutTests/platform/win/TestExpectations (135770 => 135771) --- trunk/LayoutTests/platform/win/TestExpectations 2012-11-26 22:45:20 UTC (rev 135770) +++ trunk/LayoutTests/platform/win/TestExpectations 2012-11-26 22:52:41 UTC (rev 135771) @@ -1124,11 +1124,12 @@ fast/text/hyphenate-character.html fast/text/hyphens.html -# DRT doesn't support showModalDialog http://webkit.org/b/53675 +# DRT doesn't support showModalDialog https://bugs.webkit.org/show_bug.cgi?id=53675 fast/events/show-modal-dialog-onblur-onfocus.html fast/harness/show-modal-dialog.html fast/events/scroll-event-during-modal-dialog.html inspector/console/console-long-eval-crash.html +fast/dom/Window/open-window-min-size.html # These tests fail when showModalDialog is unsupported, even though they don't # rely on it directly http://webkit.org/b/53676 ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [135772] trunk/LayoutTests
Title: [135772] trunk/LayoutTests Revision 135772 Author rjkro...@chromium.org Date 2012-11-26 15:01:13 -0800 (Mon, 26 Nov 2012) Log Message Unreviewed gardening: updated TextExpecations for failing fast/dom/shadow/shadow-dom-event-dispatching.html https://bugs.webkit.org/show_bug.cgi?id=103299 * platform/chromium/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (135771 => 135772) --- trunk/LayoutTests/ChangeLog 2012-11-26 22:52:41 UTC (rev 135771) +++ trunk/LayoutTests/ChangeLog 2012-11-26 23:01:13 UTC (rev 135772) @@ -1,3 +1,11 @@ +2012-11-26 Robert Kroeger rjkro...@chromium.org + +Unreviewed gardening: updated TextExpecations for failing +fast/dom/shadow/shadow-dom-event-dispatching.html +https://bugs.webkit.org/show_bug.cgi?id=103299 + +* platform/chromium/TestExpectations: + 2012-11-26 Roger Fong roger_f...@apple.com Unreviewed. Skip fast/dom/Window/open-window-min-size.html on Windows. Modified: trunk/LayoutTests/platform/chromium/TestExpectations (135771 => 135772) --- trunk/LayoutTests/platform/chromium/TestExpectations 2012-11-26 22:52:41 UTC (rev 135771) +++ trunk/LayoutTests/platform/chromium/TestExpectations 2012-11-26 23:01:13 UTC (rev 135772) @@ -4247,3 +4247,4 @@ webkit.org/b/103181 [ Win7 ] http/tests/local/drag-over-remote-content.html [ Pass Crash Timeout ] webkit.org/b/103183 [ Win7 SnowLeopard ] media/video-seek-past-end-playing.html [ Pass Crash ] webkit.org/b/103093 [ Lion SnowLeopard ] media/remove-from-document.html [ Crash Pass ] +webkit.org/b/103299 [ Linux Mac Win ] fast/dom/shadow/shadow-dom-event-dispatching.html [ Failure Pass ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [135773] branches/chromium/1312
Title: [135773] branches/chromium/1312 Revision 135773 Author t...@chromium.org Date 2012-11-26 15:01:24 -0800 (Mon, 26 Nov 2012) Log Message Merge 135082 - REGRESSION(r129644): User StyleSheet not applying https://bugs.webkit.org/show_bug.cgi?id=102110 Reviewed by Andreas Kling. Source/WebCore: Injected stylesheets added as UserStyleAuthorLevel fail to apply. r129644 implicitly assumed that such things don't exists but on Chromium addUserStyleSheet() confusingly uses them. The patch adds injected author stylesheets to DocumentStyleSheetCollection::activeStyleSheets(). It also generally cleans up the code around injected and user stylesheets. Tests: userscripts/user-script-and-stylesheet.html userscripts/user-stylesheet-invalidate.html * css/StyleResolver.cpp: (WebCore::StyleResolver::StyleResolver): (WebCore::StyleResolver::collectRulesFromUserStyleSheets): (WebCore::collectCSSOMWrappers): * css/StyleResolver.h: (StyleResolver): * dom/Document.cpp: (WebCore::Document::setCompatibilityMode): * dom/DocumentStyleSheetCollection.cpp: (WebCore::DocumentStyleSheetCollection::DocumentStyleSheetCollection): (WebCore::DocumentStyleSheetCollection::~DocumentStyleSheetCollection): (WebCore::DocumentStyleSheetCollection::injectedUserStyleSheets): (WebCore): (WebCore::DocumentStyleSheetCollection::injectedAuthorStyleSheets): (WebCore::DocumentStyleSheetCollection::updateInjectedStyleSheetCache): (WebCore::DocumentStyleSheetCollection::invalidateInjectedStyleSheetCache): (WebCore::DocumentStyleSheetCollection::addUserSheet): (WebCore::DocumentStyleSheetCollection::updateActiveStyleSheets): (WebCore::DocumentStyleSheetCollection::reportMemoryUsage): * dom/DocumentStyleSheetCollection.h: (WebCore::DocumentStyleSheetCollection::documentUserStyleSheets): (DocumentStyleSheetCollection): * page/PageGroup.cpp: (WebCore::PageGroup::addUserStyleSheetToWorld): (WebCore::PageGroup::removeUserStyleSheetFromWorld): (WebCore::PageGroup::removeUserStyleSheetsFromWorld): (WebCore::PageGroup::removeAllUserContent): (WebCore::PageGroup::invalidatedInjectedStyleSheetCacheInAllFrames): * page/PageGroup.h: (PageGroup): LayoutTests: * inspector/timeline/timeline-script-tag-1-expected.txt: Update the test result. The style invalidation log is slightly different. * userscripts/user-stylesheet-invalidate-expected.txt: Added. * userscripts/user-stylesheet-invalidate.html: Added. TBR=an...@apple.com Review URL: https://codereview.chromium.org/11412176 Modified Paths branches/chromium/1312/LayoutTests/ChangeLog branches/chromium/1312/LayoutTests/inspector/timeline/timeline-script-tag-1-expected.txt branches/chromium/1312/Source/WebCore/ChangeLog branches/chromium/1312/Source/WebCore/css/StyleResolver.cpp branches/chromium/1312/Source/WebCore/css/StyleResolver.h branches/chromium/1312/Source/WebCore/dom/Document.cpp branches/chromium/1312/Source/WebCore/dom/DocumentStyleSheetCollection.cpp branches/chromium/1312/Source/WebCore/dom/DocumentStyleSheetCollection.h branches/chromium/1312/Source/WebCore/page/PageGroup.cpp branches/chromium/1312/Source/WebCore/page/PageGroup.h Added Paths branches/chromium/1312/LayoutTests/userscripts/user-stylesheet-invalidate-expected.txt branches/chromium/1312/LayoutTests/userscripts/user-stylesheet-invalidate.html Diff Modified: branches/chromium/1312/LayoutTests/ChangeLog (135772 => 135773) --- branches/chromium/1312/LayoutTests/ChangeLog 2012-11-26 23:01:13 UTC (rev 135772) +++ branches/chromium/1312/LayoutTests/ChangeLog 2012-11-26 23:01:24 UTC (rev 135773) @@ -1,3 +1,17 @@ +2012-11-18 Antti Koivisto an...@apple.com + +REGRESSION(r129644): User StyleSheet not applying +https://bugs.webkit.org/show_bug.cgi?id=102110 + +Reviewed by Andreas Kling. + +* inspector/timeline/timeline-script-tag-1-expected.txt: + +Update the test result. The style invalidation log is slightly different. + +* userscripts/user-stylesheet-invalidate-expected.txt: Added. +* userscripts/user-stylesheet-invalidate.html: Added. + 2012-10-30 Keishi Hattori kei...@webkit.org F4 inside input type=time should not open calendar picker Modified: branches/chromium/1312/LayoutTests/inspector/timeline/timeline-script-tag-1-expected.txt (135772 => 135773) --- branches/chromium/1312/LayoutTests/inspector/timeline/timeline-script-tag-1-expected.txt 2012-11-26 23:01:13 UTC (rev 135772) +++ branches/chromium/1312/LayoutTests/inspector/timeline/timeline-script-tag-1-expected.txt 2012-11-26 23:01:24 UTC (rev 135773) @@ -3,8 +3,10 @@ ParseHTML + ScheduleStyleRecalculation InvalidateLayout ParseHTML + ScheduleStyleRecalculation EvaluateScript TimeStamp : SCRIPT TAG InvalidateLayout Copied: branches/chromium/1312/LayoutTests/userscripts/user-stylesheet-invalidate-expected.txt (from rev 135082, trunk/LayoutTests/userscripts/user-stylesheet-invalidate-expected.txt) (0 => 135773) ---
[webkit-changes] [135774] branches/chromium/1312/Source
Title: [135774] branches/chromium/1312/Source
Revision 135774
Author t...@chromium.org
Date 2012-11-26 15:02:49 -0800 (Mon, 26 Nov 2012)
Log Message
Merge 135316 - When calling DocumentStyleSheetCollection::addUserSheet, pass in a user sheet
https://bugs.webkit.org/show_bug.cgi?id=102835
Reviewed by Ojan Vafai.
After r135082, Chromium browser_tests were triggering the ASSERT in
StyleResolver::collectRulesFromUserStyleSheets. Add an ASSERT that will
trigger earlier and make it clear in the Chromium code that we're always
inserting user level styles.
Source/WebCore:
No new tests, no behavior change except no longer triggering the StyleResolver ASSERT
in Chromium browser_tests.
* dom/DocumentStyleSheetCollection.cpp:
(WebCore::DocumentStyleSheetCollection::addUserSheet):
Source/WebKit/chromium:
* src/WebDocument.cpp:
(WebKit::WebDocument::insertUserStyleSheet):
TBR=t...@chromium.org
Review URL: https://codereview.chromium.org/11412177
Modified Paths
branches/chromium/1312/Source/WebCore/ChangeLog
branches/chromium/1312/Source/WebCore/dom/DocumentStyleSheetCollection.cpp
branches/chromium/1312/Source/WebKit/chromium/ChangeLog
branches/chromium/1312/Source/WebKit/chromium/src/WebDocument.cpp
Diff
Modified: branches/chromium/1312/Source/WebCore/ChangeLog (135773 => 135774)
--- branches/chromium/1312/Source/WebCore/ChangeLog 2012-11-26 23:01:24 UTC (rev 135773)
+++ branches/chromium/1312/Source/WebCore/ChangeLog 2012-11-26 23:02:49 UTC (rev 135774)
@@ -1,3 +1,21 @@
+2012-11-20 Tony Chang t...@chromium.org
+
+When calling DocumentStyleSheetCollection::addUserSheet, pass in a user sheet
+https://bugs.webkit.org/show_bug.cgi?id=102835
+
+Reviewed by Ojan Vafai.
+
+After r135082, Chromium browser_tests were triggering the ASSERT in
+StyleResolver::collectRulesFromUserStyleSheets. Add an ASSERT that will
+trigger earlier and make it clear in the Chromium code that we're always
+inserting user level styles.
+
+No new tests, no behavior change except no longer triggering the StyleResolver ASSERT
+in Chromium browser_tests.
+
+* dom/DocumentStyleSheetCollection.cpp:
+(WebCore::DocumentStyleSheetCollection::addUserSheet):
+
2012-11-18 Antti Koivisto an...@apple.com
REGRESSION(r129644): User StyleSheet not applying
Modified: branches/chromium/1312/Source/WebCore/dom/DocumentStyleSheetCollection.cpp (135773 => 135774)
--- branches/chromium/1312/Source/WebCore/dom/DocumentStyleSheetCollection.cpp 2012-11-26 23:01:24 UTC (rev 135773)
+++ branches/chromium/1312/Source/WebCore/dom/DocumentStyleSheetCollection.cpp 2012-11-26 23:02:49 UTC (rev 135774)
@@ -193,6 +193,7 @@
void DocumentStyleSheetCollection::addUserSheet(PassRefPtrStyleSheetContents userSheet)
{
+ASSERT(userSheet-isUserStyleSheet());
m_userStyleSheets.append(CSSStyleSheet::create(userSheet, m_document));
m_document-styleResolverChanged(RecalcStyleImmediately);
}
Modified: branches/chromium/1312/Source/WebKit/chromium/ChangeLog (135773 => 135774)
--- branches/chromium/1312/Source/WebKit/chromium/ChangeLog 2012-11-26 23:01:24 UTC (rev 135773)
+++ branches/chromium/1312/Source/WebKit/chromium/ChangeLog 2012-11-26 23:02:49 UTC (rev 135774)
@@ -1,3 +1,18 @@
+2012-11-20 Tony Chang t...@chromium.org
+
+When calling DocumentStyleSheetCollection::addUserSheet, pass in a user sheet
+https://bugs.webkit.org/show_bug.cgi?id=102835
+
+Reviewed by Ojan Vafai.
+
+After r135082, Chromium browser_tests were triggering the ASSERT in
+StyleResolver::collectRulesFromUserStyleSheets. Add an ASSERT that will
+trigger earlier and make it clear in the Chromium code that we're always
+inserting user level styles.
+
+* src/WebDocument.cpp:
+(WebKit::WebDocument::insertUserStyleSheet):
+
2012-11-08 Keishi Hattori kei...@webkit.org
WebPagePopupImpl::handleKeyEvent is called after WebPagePopupImpl::close
Modified: branches/chromium/1312/Source/WebKit/chromium/src/WebDocument.cpp (135773 => 135774)
--- branches/chromium/1312/Source/WebKit/chromium/src/WebDocument.cpp 2012-11-26 23:01:24 UTC (rev 135773)
+++ branches/chromium/1312/Source/WebKit/chromium/src/WebDocument.cpp 2012-11-26 23:02:49 UTC (rev 135774)
@@ -194,12 +194,13 @@
return WebDocumentType(constUnwrapDocument()-doctype());
}
-void WebDocument::insertUserStyleSheet(const WebString sourceCode, UserStyleLevel level)
+void WebDocument::insertUserStyleSheet(const WebString sourceCode, UserStyleLevel)
{
RefPtrDocument document = unwrapDocument();
+// FIXME: We currently ignore the passed in UserStyleLevel. http://crbug.com/162096
RefPtrStyleSheetContents parsedSheet = StyleSheetContents::create(document.get());
-parsedSheet-setIsUserStyleSheet(level == UserStyleUserLevel);
+parsedSheet-setIsUserStyleSheet(true);
parsedSheet-parseString(sourceCode);
[webkit-changes] [135775] trunk/Source/WebKit/blackberry
Title: [135775] trunk/Source/WebKit/blackberry
Revision 135775
Author commit-qu...@webkit.org
Date 2012-11-26 15:07:35 -0800 (Mon, 26 Nov 2012)
Log Message
[BlackBerry] Form controls don't show pressed state.
https://bugs.webkit.org/show_bug.cgi?id=103292
Patch by Genevieve Mak g...@rim.com on 2012-11-26
Reviewed by Rob Buis.
Reviewed internally by Eli Fidler and Mike Lattanzio.
We weren't sending touch events to webpages unless they
had JS touch event listeners which form controls don't have.
Now send them always and do a little cleanup.
PR #249791
* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::WebPagePrivate):
(BlackBerry::WebKit::WebPage::touchEvent):
* Api/WebPageClient.h:
* Api/WebPage_p.h:
(WebPagePrivate):
* WebCoreSupport/ChromeClientBlackBerry.cpp:
(WebCore::ChromeClientBlackBerry::needTouchEvents):
Modified Paths
trunk/Source/WebKit/blackberry/Api/WebPage.cpp
trunk/Source/WebKit/blackberry/Api/WebPageClient.h
trunk/Source/WebKit/blackberry/Api/WebPage_p.h
trunk/Source/WebKit/blackberry/ChangeLog
trunk/Source/WebKit/blackberry/WebCoreSupport/ChromeClientBlackBerry.cpp
Diff
Modified: trunk/Source/WebKit/blackberry/Api/WebPage.cpp (135774 => 135775)
--- trunk/Source/WebKit/blackberry/Api/WebPage.cpp 2012-11-26 23:02:49 UTC (rev 135774)
+++ trunk/Source/WebKit/blackberry/Api/WebPage.cpp 2012-11-26 23:07:35 UTC (rev 135775)
@@ -372,7 +372,6 @@
, m_overflowExceedsContentsSize(false)
, m_resetVirtualViewportOnCommitted(true)
, m_shouldUseFixedDesktopMode(false)
-, m_needTouchEvents(false)
, m_preventIdleDimmingCount(0)
#if ENABLE(TOUCH_EVENTS)
, m_preventDefaultOnTouchStart(false)
@@ -4010,7 +4009,7 @@
bool handled = false;
-if (d-m_needTouchEvents !event.m_type != Platform::TouchEvent::TouchInjected)
+if (!event.m_type != Platform::TouchEvent::TouchInjected)
handled = d-m_mainFrame-eventHandler()-handleTouchEvent(PlatformTouchEvent(tEvent));
if (d-m_preventDefaultOnTouchStart) {
@@ -5918,11 +5917,6 @@
return d-m_page-settings()-webGLEnabled();
}
-void WebPagePrivate::setNeedTouchEvents(bool value)
-{
-m_needTouchEvents = value;
-}
-
void WebPagePrivate::frameUnloaded(const Frame* frame)
{
m_inputHandler-frameUnloaded(frame);
Modified: trunk/Source/WebKit/blackberry/Api/WebPageClient.h (135774 => 135775)
--- trunk/Source/WebKit/blackberry/Api/WebPageClient.h 2012-11-26 23:02:49 UTC (rev 135774)
+++ trunk/Source/WebKit/blackberry/Api/WebPageClient.h 2012-11-26 23:07:35 UTC (rev 135775)
@@ -103,7 +103,6 @@
virtual void notifyRunLayoutTestsFinished() = 0;
virtual void notifyInRegionScrollableAreasChanged(const std::vectorPlatform::ScrollViewBase*) = 0;
-virtual void notifyNoMouseMoveOrTouchMoveHandlers() = 0;
virtual void notifyDocumentOnLoad(bool) = 0;
Modified: trunk/Source/WebKit/blackberry/Api/WebPage_p.h (135774 => 135775)
--- trunk/Source/WebKit/blackberry/Api/WebPage_p.h 2012-11-26 23:02:49 UTC (rev 135774)
+++ trunk/Source/WebKit/blackberry/Api/WebPage_p.h 2012-11-26 23:07:35 UTC (rev 135775)
@@ -490,7 +490,6 @@
bool m_overflowExceedsContentsSize;
bool m_resetVirtualViewportOnCommitted;
bool m_shouldUseFixedDesktopMode;
-bool m_needTouchEvents;
int m_preventIdleDimmingCount;
#if ENABLE(TOUCH_EVENTS)
Modified: trunk/Source/WebKit/blackberry/ChangeLog (135774 => 135775)
--- trunk/Source/WebKit/blackberry/ChangeLog 2012-11-26 23:02:49 UTC (rev 135774)
+++ trunk/Source/WebKit/blackberry/ChangeLog 2012-11-26 23:07:35 UTC (rev 135775)
@@ -1,3 +1,25 @@
+2012-11-26 Genevieve Mak g...@rim.com
+
+[BlackBerry] Form controls don't show pressed state.
+https://bugs.webkit.org/show_bug.cgi?id=103292
+
+Reviewed by Rob Buis.
+
+Reviewed internally by Eli Fidler and Mike Lattanzio.
+We weren't sending touch events to webpages unless they
+had JS touch event listeners which form controls don't have.
+Now send them always and do a little cleanup.
+PR #249791
+
+* Api/WebPage.cpp:
+(BlackBerry::WebKit::WebPagePrivate::WebPagePrivate):
+(BlackBerry::WebKit::WebPage::touchEvent):
+* Api/WebPageClient.h:
+* Api/WebPage_p.h:
+(WebPagePrivate):
+* WebCoreSupport/ChromeClientBlackBerry.cpp:
+(WebCore::ChromeClientBlackBerry::needTouchEvents):
+
2012-11-26 Nima Ghanavatian nghanavat...@rim.com
[BlackBerry] Null check calls associated with retrieving the caret rect.
Modified: trunk/Source/WebKit/blackberry/WebCoreSupport/ChromeClientBlackBerry.cpp (135774 => 135775)
--- trunk/Source/WebKit/blackberry/WebCoreSupport/ChromeClientBlackBerry.cpp 2012-11-26 23:02:49 UTC (rev 135774)
+++ trunk/Source/WebKit/blackberry/WebCoreSupport/ChromeClientBlackBerry.cpp 2012-11-26 23:07:35 UTC (rev 135775)
@@ -656,7 +656,6 @@
#if ENABLE(TOUCH_EVENTS)
void ChromeClientBlackBerry::needTouchEvents(bool value)
{
-
[webkit-changes] [135777] branches/safari-536.28-branch/Source/WebCore
Title: [135777] branches/safari-536.28-branch/Source/WebCore Revision 135777 Author simon.fra...@apple.com Date 2012-11-26 15:12:49 -0800 (Mon, 26 Nov 2012) Log Message rdar://problem/12751360 Merge r135746 2012-11-26 Simon Fraser simon.fra...@apple.com Optimize layer updates after scrolling https://bugs.webkit.org/show_bug.cgi?id=102635 Reviewed by Sam Weinig. updateLayerPositionsAfterScroll() previously unconditionally cleared clip rects, and recomputed repaint rects too often. Recomputing both of these can be very expensive, as they involve tree walks up to the root. We can optimize layer updates after document scrolling by only clearing clip rects, and recomputing repaint rects, if we encounter a fixed- or sticky-position element. For overflow scroll, we have to clear clip rects and recompute repaint rects. * page/FrameView.cpp: (WebCore::FrameView::repaintFixedElementsAfterScrolling): Call updateLayerPositionsAfterDocumentScroll(). * rendering/RenderLayer.cpp: (WebCore::RenderLayer::updateLayerPositions): Call clearClipRects() because updateLayerPosition() no longer does. (WebCore::RenderLayer::updateLayerPositionsAfterDocumentScroll): Version of updateLayerPositionsAfterScroll() that is for document scrolls. It has no need to push layers to the geometry map. (WebCore::RenderLayer::updateLayerPositionsAfterOverflowScroll): Pushes layers to the geometry map, and calls updateLayerPositionsAfterScroll() with the IsOverflowScroll flag. (WebCore::RenderLayer::updateLayerPositionsAfterScroll): Set the HasChangedAncestor flag if our location changed, and use that as a hint to clear cached rects. Be more conservative than before about when to clear cached clip rects. (WebCore::RenderLayer::updateLayerPosition): Move responsibility for calling clearClipRects() ouf of this function and into callers. (The one caller outside RenderLayer will be removed via bug 102624). Return a bool indicating whether our position changed. (WebCore::RenderLayer::scrollTo): Call updateLayerPositionsAfterOverflowScroll(). (WebCore::RenderLayer::updateClipRects): Added some #ifdeffed out code that is useful to verify that cached clips are correct; it's too slow to leave enabled in debug builds. * rendering/RenderLayer.h: (WebCore::RenderLayer::setLocation): Change to take a LayoutPoint, rather than separate x and y. Modified Paths branches/safari-536.28-branch/Source/WebCore/ChangeLog branches/safari-536.28-branch/Source/WebCore/page/FrameView.cpp branches/safari-536.28-branch/Source/WebCore/rendering/RenderLayer.cpp branches/safari-536.28-branch/Source/WebCore/rendering/RenderLayer.h Diff Modified: branches/safari-536.28-branch/Source/WebCore/ChangeLog (135776 => 135777) --- branches/safari-536.28-branch/Source/WebCore/ChangeLog 2012-11-26 23:12:43 UTC (rev 135776) +++ branches/safari-536.28-branch/Source/WebCore/ChangeLog 2012-11-26 23:12:49 UTC (rev 135777) @@ -1,5 +1,48 @@ 2012-11-26 Simon Fraser simon.fra...@apple.com +rdar://problem/12751360 +Merge r135746 + +2012-11-26 Simon Fraser simon.fra...@apple.com + +Optimize layer updates after scrolling +https://bugs.webkit.org/show_bug.cgi?id=102635 + +Reviewed by Sam Weinig. + +updateLayerPositionsAfterScroll() previously unconditionally cleared clip +rects, and recomputed repaint rects too often. Recomputing both of these +can be very expensive, as they involve tree walks up to the root. + +We can optimize layer updates after document scrolling by only clearing clip +rects, and recomputing repaint rects, if we encounter a fixed- or sticky-position +element. For overflow scroll, we have to clear clip rects and recompute repaint rects. + +* page/FrameView.cpp: +(WebCore::FrameView::repaintFixedElementsAfterScrolling): Call updateLayerPositionsAfterDocumentScroll(). +* rendering/RenderLayer.cpp: +(WebCore::RenderLayer::updateLayerPositions): Call clearClipRects() because +updateLayerPosition() no longer does. +(WebCore::RenderLayer::updateLayerPositionsAfterDocumentScroll): Version of updateLayerPositionsAfterScroll() +that is for document scrolls. It has no need to push layers to the geometry map. +(WebCore::RenderLayer::updateLayerPositionsAfterOverflowScroll): Pushes layers to the geometry map, +and calls updateLayerPositionsAfterScroll() with the IsOverflowScroll flag. +(WebCore::RenderLayer::updateLayerPositionsAfterScroll): Set the HasChangedAncestor flag +if our location changed, and use that as a hint to clear cached rects. Be more conservative +than before about when to clear cached clip rects. +
[webkit-changes] [135778] trunk/LayoutTests
Title: [135778] trunk/LayoutTests Revision 135778 Author rjkro...@chromium.org Date 2012-11-26 15:18:55 -0800 (Mon, 26 Nov 2012) Log Message Unreviewed gardening: failure in http/tests/media/pdf-served-as-pdf.html https://bugs.webkit.org/show_bug.cgi?id=103093 * platform/chromium/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (135777 => 135778) --- trunk/LayoutTests/ChangeLog 2012-11-26 23:12:49 UTC (rev 135777) +++ trunk/LayoutTests/ChangeLog 2012-11-26 23:18:55 UTC (rev 135778) @@ -1,5 +1,12 @@ 2012-11-26 Robert Kroeger rjkro...@chromium.org +Unreviewed gardening: failure in http/tests/media/pdf-served-as-pdf.html +https://bugs.webkit.org/show_bug.cgi?id=103093 + +* platform/chromium/TestExpectations: + +2012-11-26 Robert Kroeger rjkro...@chromium.org + Unreviewed gardening: updated TextExpecations for failing fast/dom/shadow/shadow-dom-event-dispatching.html https://bugs.webkit.org/show_bug.cgi?id=103299 Modified: trunk/LayoutTests/platform/chromium/TestExpectations (135777 => 135778) --- trunk/LayoutTests/platform/chromium/TestExpectations 2012-11-26 23:12:49 UTC (rev 135777) +++ trunk/LayoutTests/platform/chromium/TestExpectations 2012-11-26 23:18:55 UTC (rev 135778) @@ -3868,7 +3868,7 @@ crbug.com/145590 [ Android ] http/tests/media/media-source/video-media-source-seek.html [ Failure ] crbug.com/145590 [ Android ] http/tests/media/media-source/video-media-source-sourcebufferlist-crash.html [ Timeout ] crbug.com/145590 [ Android ] http/tests/media/media-source/video-media-source-state-changes.html [ Failure ] -crbug.com/145590 [ Android ] http/tests/media/pdf-served-as-pdf.html [ Failure ] +crbug.com/145590 [ Android Mac Win Linux ] http/tests/media/pdf-served-as-pdf.html [ Failure Pass Crash Timeout ] crbug.com/145590 [ Android ] http/tests/media/text-served-as-text.html [ Failure ] crbug.com/145590 [ Android ] http/tests/media/video-error-abort.html [ Failure ] crbug.com/145590 [ Android ] http/tests/media/video-load-suspend.html [ Timeout ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [135779] trunk/Source/WebCore
Title: [135779] trunk/Source/WebCore
Revision 135779
Author commit-qu...@webkit.org
Date 2012-11-26 15:27:57 -0800 (Mon, 26 Nov 2012)
Log Message
Removing unnecessary friend classes in RenderObject: LayoutRepainter, RenderSVGContainer
https://bugs.webkit.org/show_bug.cgi?id=103164
Patch by Adenilson Cavalcanti cavalcan...@gmail.com on 2012-11-26
Reviewed by Simon Fraser.
Removing some of classes marked as friend of RenderObject. This patch solves this issue
for 2 classes: RenderSVGContainer (that is derived from RenderObject) and LayoutRepainter
(that accesses one const member function in RenderObject that is now made public).
No new tests, no changes in functionality.
* rendering/RenderObject.h:
(RenderObject):
(WebCore::RenderObject::outlineBoundsForRepaint):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderObject.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (135778 => 135779)
--- trunk/Source/WebCore/ChangeLog 2012-11-26 23:18:55 UTC (rev 135778)
+++ trunk/Source/WebCore/ChangeLog 2012-11-26 23:27:57 UTC (rev 135779)
@@ -1,3 +1,20 @@
+2012-11-26 Adenilson Cavalcanti cavalcan...@gmail.com
+
+Removing unnecessary friend classes in RenderObject: LayoutRepainter, RenderSVGContainer
+https://bugs.webkit.org/show_bug.cgi?id=103164
+
+Reviewed by Simon Fraser.
+
+Removing some of classes marked as friend of RenderObject. This patch solves this issue
+for 2 classes: RenderSVGContainer (that is derived from RenderObject) and LayoutRepainter
+(that accesses one const member function in RenderObject that is now made public).
+
+No new tests, no changes in functionality.
+
+* rendering/RenderObject.h:
+(RenderObject):
+(WebCore::RenderObject::outlineBoundsForRepaint):
+
2012-11-26 Jon Lee jon...@apple.com
Pass clicks through to the restarted plugin
Modified: trunk/Source/WebCore/rendering/RenderObject.h (135778 => 135779)
--- trunk/Source/WebCore/rendering/RenderObject.h 2012-11-26 23:18:55 UTC (rev 135778)
+++ trunk/Source/WebCore/rendering/RenderObject.h 2012-11-26 23:27:57 UTC (rev 135779)
@@ -155,11 +155,9 @@
// Base class for all rendering tree objects.
class RenderObject : public CachedImageClient {
-friend class LayoutRepainter;
friend class RenderBlock;
friend class RenderLayer;
friend class RenderObjectChildList;
-friend class RenderSVGContainer;
public:
// Anonymous objects should pass the document as their node, and they will then automatically be
// marked as anonymous in the constructor.
@@ -811,6 +809,7 @@
IntRect pixelSnappedAbsoluteClippedOverflowRect() const;
virtual LayoutRect clippedOverflowRectForRepaint(const RenderLayerModelObject* repaintContainer) const;
virtual LayoutRect rectWithOutlineForRepaint(const RenderLayerModelObject* repaintContainer, LayoutUnit outlineWidth) const;
+virtual LayoutRect outlineBoundsForRepaint(const RenderLayerModelObject* /*repaintContainer*/, const RenderGeometryMap* = 0) const { return LayoutRect(); }
// Given a rect in the object's coordinate space, compute a rect suitable for repainting
// that rect in view coordinates.
@@ -980,8 +979,6 @@
virtual void willBeDestroyed();
void arenaDelete(RenderArena*, void* objectBase);
-virtual LayoutRect outlineBoundsForRepaint(const RenderLayerModelObject* /*repaintContainer*/, const RenderGeometryMap* = 0) const { return LayoutRect(); }
-
virtual bool canBeReplacedWithInlineRunIn() const;
virtual void insertedIntoTree();
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [135780] trunk/LayoutTests
Title: [135780] trunk/LayoutTests Revision 135780 Author rjkro...@chromium.org Date 2012-11-26 15:38:43 -0800 (Mon, 26 Nov 2012) Log Message Unreviewed gardening: failure in fast/text/atsui-small-caps-punctuation-size.html https://bugs.webkit.org/show_bug.cgi?id=103148 * platform/chromium/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (135779 => 135780) --- trunk/LayoutTests/ChangeLog 2012-11-26 23:27:57 UTC (rev 135779) +++ trunk/LayoutTests/ChangeLog 2012-11-26 23:38:43 UTC (rev 135780) @@ -1,5 +1,12 @@ 2012-11-26 Robert Kroeger rjkro...@chromium.org +Unreviewed gardening: failure in fast/text/atsui-small-caps-punctuation-size.html +https://bugs.webkit.org/show_bug.cgi?id=103148 + +* platform/chromium/TestExpectations: + +2012-11-26 Robert Kroeger rjkro...@chromium.org + Unreviewed gardening: failure in http/tests/media/pdf-served-as-pdf.html https://bugs.webkit.org/show_bug.cgi?id=103093 Modified: trunk/LayoutTests/platform/chromium/TestExpectations (135779 => 135780) --- trunk/LayoutTests/platform/chromium/TestExpectations 2012-11-26 23:27:57 UTC (rev 135779) +++ trunk/LayoutTests/platform/chromium/TestExpectations 2012-11-26 23:38:43 UTC (rev 135780) @@ -4248,3 +4248,4 @@ webkit.org/b/103183 [ Win7 SnowLeopard ] media/video-seek-past-end-playing.html [ Pass Crash ] webkit.org/b/103093 [ Lion SnowLeopard ] media/remove-from-document.html [ Crash Pass ] webkit.org/b/103299 [ Linux Mac Win ] fast/dom/shadow/shadow-dom-event-dispatching.html [ Failure Pass ] +webkit.org/b/103148 [ Linux Win ] fast/text/atsui-small-caps-punctuation-size.html [ ImageOnlyFailure Failure Pass ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [135781] trunk/LayoutTests
Title: [135781] trunk/LayoutTests Revision 135781 Author rjkro...@chromium.org Date 2012-11-26 15:45:36 -0800 (Mon, 26 Nov 2012) Log Message Unreviewed gardening: css3/filters/custom/custom-filter-transforms-animation.html times out intermittently. https://bugs.webkit.org/show_bug.cgi?id=103308 * platform/chromium/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (135780 => 135781) --- trunk/LayoutTests/ChangeLog 2012-11-26 23:38:43 UTC (rev 135780) +++ trunk/LayoutTests/ChangeLog 2012-11-26 23:45:36 UTC (rev 135781) @@ -1,5 +1,13 @@ 2012-11-26 Robert Kroeger rjkro...@chromium.org +Unreviewed gardening: css3/filters/custom/custom-filter-transforms-animation.html +times out intermittently. +https://bugs.webkit.org/show_bug.cgi?id=103308 + +* platform/chromium/TestExpectations: + +2012-11-26 Robert Kroeger rjkro...@chromium.org + Unreviewed gardening: failure in fast/text/atsui-small-caps-punctuation-size.html https://bugs.webkit.org/show_bug.cgi?id=103148 Modified: trunk/LayoutTests/platform/chromium/TestExpectations (135780 => 135781) --- trunk/LayoutTests/platform/chromium/TestExpectations 2012-11-26 23:38:43 UTC (rev 135780) +++ trunk/LayoutTests/platform/chromium/TestExpectations 2012-11-26 23:45:36 UTC (rev 135781) @@ -4249,3 +4249,4 @@ webkit.org/b/103093 [ Lion SnowLeopard ] media/remove-from-document.html [ Crash Pass ] webkit.org/b/103299 [ Linux Mac Win ] fast/dom/shadow/shadow-dom-event-dispatching.html [ Failure Pass ] webkit.org/b/103148 [ Linux Win ] fast/text/atsui-small-caps-punctuation-size.html [ ImageOnlyFailure Failure Pass ] +webkit.org/b/103308 [ SnowLeopard Lion ] css3/filters/custom/custom-filter-transforms-animation.html [ Pass Timeout ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [135783] trunk/LayoutTests
Title: [135783] trunk/LayoutTests Revision 135783 Author roger_f...@apple.com Date 2012-11-26 15:53:46 -0800 (Mon, 26 Nov 2012) Log Message Unreviewed. Skipping some compositing/tiling tests on Windows because tiled backing is not supported. Tests skipped: compositing/tiling/rotated-tiled-preserve3d-clamped.html compositing/tiling/rotated-tiled-clamped.html * platform/win/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/win/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (135782 => 135783) --- trunk/LayoutTests/ChangeLog 2012-11-26 23:49:36 UTC (rev 135782) +++ trunk/LayoutTests/ChangeLog 2012-11-26 23:53:46 UTC (rev 135783) @@ -1,3 +1,12 @@ +2012-11-26 Roger Fong roger_f...@apple.com + +Unreviewed. Skipping some compositing/tiling tests on Windows because tiled backing is not supported. +Tests skipped: +compositing/tiling/rotated-tiled-preserve3d-clamped.html +compositing/tiling/rotated-tiled-clamped.html + +* platform/win/TestExpectations: + 2012-11-26 Robert Kroeger rjkro...@chromium.org Unreviewed gardening: css3/filters/custom/custom-filter-transforms-animation.html Modified: trunk/LayoutTests/platform/win/TestExpectations (135782 => 135783) --- trunk/LayoutTests/platform/win/TestExpectations 2012-11-26 23:49:36 UTC (rev 135782) +++ trunk/LayoutTests/platform/win/TestExpectations 2012-11-26 23:53:46 UTC (rev 135783) @@ -2435,6 +2435,10 @@ fast/css3-text/css3-text-align-last/getComputedStyle/getComputedStyle-text-align-last.html fast/css3-text/css3-text-decoration/getComputedStyle/getComputedStyle-text-decoration-line.html -#ACCELERATED_OVERFLOW_SCROLLING is disabled on Windows +# ACCELERATED_OVERFLOW_SCROLLING is disabled on Windows compositing/overflow/scrolling-without-painting.html compositing/overflow/updating-scrolling-content.html + +# Skip some compositing/tiling tests after r133056 +compositing/tiling/rotated-tiled-preserve3d-clamped.html +compositing/tiling/rotated-tiled-clamped.html ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [135784] trunk/Source/WebCore
Title: [135784] trunk/Source/WebCore
Revision 135784
Author commit-qu...@webkit.org
Date 2012-11-26 15:57:29 -0800 (Mon, 26 Nov 2012)
Log Message
[BlackBerry] Stop sending touch events to plugins.
https://bugs.webkit.org/show_bug.cgi?id=103188
Patch by Genevieve Mak g...@rim.com on 2012-11-24
Reviewed by Rob Buis.
Reviewed internally by Jeff Rogers and Mike Lattanzio.
No tests required.
PR #248605
* plugins/blackberry/PluginViewBlackBerry.cpp:
(WebCore::PluginView::handleTouchEvent):
(WebCore::PluginView::handleMouseEvent):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/plugins/blackberry/PluginViewBlackBerry.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (135783 => 135784)
--- trunk/Source/WebCore/ChangeLog 2012-11-26 23:53:46 UTC (rev 135783)
+++ trunk/Source/WebCore/ChangeLog 2012-11-26 23:57:29 UTC (rev 135784)
@@ -1,3 +1,18 @@
+2012-11-24 Genevieve Mak g...@rim.com
+
+[BlackBerry] Stop sending touch events to plugins.
+https://bugs.webkit.org/show_bug.cgi?id=103188
+
+Reviewed by Rob Buis.
+
+Reviewed internally by Jeff Rogers and Mike Lattanzio.
+No tests required.
+PR #248605
+
+* plugins/blackberry/PluginViewBlackBerry.cpp:
+(WebCore::PluginView::handleTouchEvent):
+(WebCore::PluginView::handleMouseEvent):
+
2012-11-26 Adenilson Cavalcanti cavalcan...@gmail.com
Removing unnecessary friend classes in RenderObject: LayoutRepainter, RenderSVGContainer
Modified: trunk/Source/WebCore/plugins/blackberry/PluginViewBlackBerry.cpp (135783 => 135784)
--- trunk/Source/WebCore/plugins/blackberry/PluginViewBlackBerry.cpp 2012-11-26 23:53:46 UTC (rev 135783)
+++ trunk/Source/WebCore/plugins/blackberry/PluginViewBlackBerry.cpp 2012-11-26 23:57:29 UTC (rev 135784)
@@ -490,22 +490,15 @@
npTouchEvent.type = TOUCH_EVENT_DOUBLETAP;
else if (event-isTouchHold())
npTouchEvent.type = TOUCH_EVENT_TOUCHHOLD;
-else if (event-type() == eventNames().touchstartEvent)
-npTouchEvent.type = TOUCH_EVENT_START;
-else if (event-type() == eventNames().touchendEvent)
-npTouchEvent.type = TOUCH_EVENT_END;
-else if (event-type() == eventNames().touchmoveEvent)
-npTouchEvent.type = TOUCH_EVENT_MOVE;
else if (event-type() == eventNames().touchcancelEvent)
npTouchEvent.type = TOUCH_EVENT_CANCEL;
-else {
-ASSERT_NOT_REACHED();
+else
return;
-}
TouchList* touchList;
-// The touches list is empty if in a touch end event. Use changedTouches instead.
-if (npTouchEvent.type == TOUCH_EVENT_DOUBLETAP || npTouchEvent.type == TOUCH_EVENT_END)
+// The touches list is empty if in a touch end event.
+// Since DoubleTap is ususally a TouchEnd Use changedTouches instead.
+if (npTouchEvent.type == TOUCH_EVENT_DOUBLETAP)
touchList = event-changedTouches();
else
touchList = event-touches();
@@ -536,13 +529,6 @@
if (dispatchNPEvent(npEvent))
event-setDefaultHandled();
-else if (npTouchEvent.type == TOUCH_EVENT_DOUBLETAP) {
-// Send Touch Up if double tap not consumed
-npTouchEvent.type = TOUCH_EVENT_END;
-npEvent.data = ""
-if (dispatchNPEvent(npEvent))
-event-setDefaultHandled();
-}
}
void PluginView::handleMouseEvent(MouseEvent* event)
@@ -559,19 +545,17 @@
mouseEvent.x = event-offsetX();
mouseEvent.y = event-offsetY();
-if (event-type() == eventNames().mousedownEvent) {
+if (event-type() == eventNames().mousedownEvent)
mouseEvent.type = MOUSE_BUTTON_DOWN;
-parentFrame()-eventHandler()-setCapturingMouseEventsNode(node());
-} else if (event-type() == eventNames().mousemoveEvent)
+else if (event-type() == eventNames().mousemoveEvent)
mouseEvent.type = MOUSE_MOTION;
else if (event-type() == eventNames().mouseoutEvent)
mouseEvent.type = MOUSE_OUTBOUND;
else if (event-type() == eventNames().mouseoverEvent)
mouseEvent.type = MOUSE_OVER;
-else if (event-type() == eventNames().mouseupEvent) {
+else if (event-type() == eventNames().mouseupEvent)
mouseEvent.type = MOUSE_BUTTON_UP;
-parentFrame()-eventHandler()-setCapturingMouseEventsNode(0);
-} else
+else
return;
mouseEvent.button = event-button();
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [135785] branches/safari-536.28-branch/Source
Title: [135785] branches/safari-536.28-branch/Source
Revision 135785
Author lforsch...@apple.com
Date 2012-11-26 15:57:43 -0800 (Mon, 26 Nov 2012)
Log Message
Merged r134327. rdar://problem/12696109
Modified Paths
branches/safari-536.28-branch/Source/WebCore/ChangeLog
branches/safari-536.28-branch/Source/WebCore/inspector/InspectorFrontendClientLocal.cpp
branches/safari-536.28-branch/Source/WebKit/win/ChangeLog
branches/safari-536.28-branch/Source/WebKit/win/WebCoreSupport/WebInspectorClient.cpp
Diff
Modified: branches/safari-536.28-branch/Source/WebCore/ChangeLog (135784 => 135785)
--- branches/safari-536.28-branch/Source/WebCore/ChangeLog 2012-11-26 23:57:29 UTC (rev 135784)
+++ branches/safari-536.28-branch/Source/WebCore/ChangeLog 2012-11-26 23:57:43 UTC (rev 135785)
@@ -1,3 +1,23 @@
+2012-11-26 Lucas Forschler lforsch...@apple.com
+
+Merge r134327
+
+2012-11-12 Roger Fong roger_f...@apple.com
+
+Web Inspector: Fix docking behaviour on Windows.
+https://bugs.webkit.org/show_bug.cgi?id=101978
+
+Reviewed by Brian Weinstein.
+
+There are a number of problems with docking behaviour on Windows.
+For starters, it does not ever constrain the inspector's size properly while docked.
+It also does not properly set the whether or not the inspector can be docked/undocked.
+This patch fixes both issues.
+
+* inspector/InspectorFrontendClientLocal.cpp:
+(WebCore::InspectorFrontendClientLocal::frontendLoaded):
+Switch order of calling bringToFront and setDockingUnavailable.
+
2012-11-26 Simon Fraser simon.fra...@apple.com
rdar://problem/12751360
Modified: branches/safari-536.28-branch/Source/WebCore/inspector/InspectorFrontendClientLocal.cpp (135784 => 135785)
--- branches/safari-536.28-branch/Source/WebCore/inspector/InspectorFrontendClientLocal.cpp 2012-11-26 23:57:29 UTC (rev 135784)
+++ branches/safari-536.28-branch/Source/WebCore/inspector/InspectorFrontendClientLocal.cpp 2012-11-26 23:57:43 UTC (rev 135785)
@@ -140,8 +140,11 @@
void InspectorFrontendClientLocal::frontendLoaded()
{
+// Call setDockingUnavailable before bringToFront. If we display the inspector window via bringToFront first it causes the call to canAttachWindow to return the wrong result on Windows.
+// Calling bringToFront first causes the visibleHeight of the inspected page to always return 0 immediately after.
+// Thus if we call canAttachWindow first we can avoid this problem. This change does not cause any regressions on Mac.
+setDockingUnavailable(!canAttachWindow());
bringToFront();
-setDockingUnavailable(!canAttachWindow());
m_frontendLoaded = true;
for (VectorString::iterator it = m_evaluateOnLoad.begin(); it != m_evaluateOnLoad.end(); ++it)
evaluateOnLoad(*it);
Modified: branches/safari-536.28-branch/Source/WebKit/win/ChangeLog (135784 => 135785)
--- branches/safari-536.28-branch/Source/WebKit/win/ChangeLog 2012-11-26 23:57:29 UTC (rev 135784)
+++ branches/safari-536.28-branch/Source/WebKit/win/ChangeLog 2012-11-26 23:57:43 UTC (rev 135785)
@@ -1,3 +1,25 @@
+2012-11-26 Lucas Forschler lforsch...@apple.com
+
+Merge r134327
+
+2012-11-12 Roger Fong roger_f...@apple.com
+
+Web Inspector: Fix docking behaviour on Windows.
+https://bugs.webkit.org/show_bug.cgi?id=101978
+
+Reviewed by Brian Weinstein.
+
+There are a number of problems with docking behaviour on Windows.
+For starters, it does not ever constrain the inspector's size properly while docked.
+It also does not properly set the whether or not the inspector can be docked/undocked.
+This patch fixes both issues.
+
+* WebCoreSupport/WebInspectorClient.cpp:
+(WebInspectorFrontendClient::frontendLoaded):
+(WebInspectorFrontendClient::attachWindow):
+Call restoreAttachedWindowHeight so that when first loading or reattaching the inspector,
+we resize the inspector window properly.
+
2012-08-02 Lucas Forschler lforsch...@apple.com
Merge 122676
Modified: branches/safari-536.28-branch/Source/WebKit/win/WebCoreSupport/WebInspectorClient.cpp (135784 => 135785)
--- branches/safari-536.28-branch/Source/WebKit/win/WebCoreSupport/WebInspectorClient.cpp 2012-11-26 23:57:29 UTC (rev 135784)
+++ branches/safari-536.28-branch/Source/WebKit/win/WebCoreSupport/WebInspectorClient.cpp 2012-11-26 23:57:43 UTC (rev 135785)
@@ -253,6 +253,9 @@
{
InspectorFrontendClientLocal::frontendLoaded();
+if (m_attached)
+restoreAttachedWindowHeight();
+
setAttachedWindow(m_attached);
}
@@ -289,6 +292,13 @@
m_inspectorClient-setInspectorStartsAttached(true);
closeWindowWithoutNotifications();
+// We need to set the attached window's height before we actually attach the window.
+//
[webkit-changes] [135787] trunk/Source/WebKit/chromium
Title: [135787] trunk/Source/WebKit/chromium
Revision 135787
Author commit-qu...@webkit.org
Date 2012-11-26 16:39:53 -0800 (Mon, 26 Nov 2012)
Log Message
Add hasTouchEventhandlersAt to WebView API
https://bugs.webkit.org/show_bug.cgi?id=102541
Patch by Yusuf Ozuysal yus...@google.com on 2012-11-26
Reviewed by James Robinson.
Adds hasTouchEventHandlersAt to WebWidget API to check for touch event handlers at a
given point. This will be used to distinguish between events not processed by
touch event handlers and event not hitting any touch event handlers. Both are
returning the same ACK message currently. Default implementation returns true to
continue the same behavior as we currently have.
* public/WebWidget.h:
(WebWidget):
(WebKit::WebWidget::hasTouchEventHandlersAt):
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::hasTouchEventHandlersAt):
(WebKit):
* src/WebViewImpl.h:
(WebViewImpl):
Modified Paths
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/public/WebWidget.h
trunk/Source/WebKit/chromium/src/WebViewImpl.cpp
trunk/Source/WebKit/chromium/src/WebViewImpl.h
Diff
Modified: trunk/Source/WebKit/chromium/ChangeLog (135786 => 135787)
--- trunk/Source/WebKit/chromium/ChangeLog 2012-11-27 00:17:49 UTC (rev 135786)
+++ trunk/Source/WebKit/chromium/ChangeLog 2012-11-27 00:39:53 UTC (rev 135787)
@@ -1,3 +1,25 @@
+2012-11-26 Yusuf Ozuysal yus...@google.com
+
+Add hasTouchEventhandlersAt to WebView API
+https://bugs.webkit.org/show_bug.cgi?id=102541
+
+Reviewed by James Robinson.
+
+Adds hasTouchEventHandlersAt to WebWidget API to check for touch event handlers at a
+given point. This will be used to distinguish between events not processed by
+touch event handlers and event not hitting any touch event handlers. Both are
+returning the same ACK message currently. Default implementation returns true to
+continue the same behavior as we currently have.
+
+* public/WebWidget.h:
+(WebWidget):
+(WebKit::WebWidget::hasTouchEventHandlersAt):
+* src/WebViewImpl.cpp:
+(WebKit::WebViewImpl::hasTouchEventHandlersAt):
+(WebKit):
+* src/WebViewImpl.h:
+(WebViewImpl):
+
2012-11-26 James Simonsen simon...@chromium.org
Consolidate FrameLoader::load() into one function taking a FrameLoadRequest
Modified: trunk/Source/WebKit/chromium/public/WebWidget.h (135786 => 135787)
--- trunk/Source/WebKit/chromium/public/WebWidget.h 2012-11-27 00:17:49 UTC (rev 135786)
+++ trunk/Source/WebKit/chromium/public/WebWidget.h 2012-11-27 00:39:53 UTC (rev 135787)
@@ -157,6 +157,9 @@
// the event has been processed, false otherwise.
virtual bool handleInputEvent(const WebInputEvent) { return false; }
+// Check whether the given point hits any registered touch event handlers.
+virtual bool hasTouchEventHandlersAt(const WebPoint) { return true; }
+
// Called to inform the WebWidget that mouse capture was lost.
virtual void mouseCaptureLost() { }
Modified: trunk/Source/WebKit/chromium/src/WebViewImpl.cpp (135786 => 135787)
--- trunk/Source/WebKit/chromium/src/WebViewImpl.cpp 2012-11-27 00:17:49 UTC (rev 135786)
+++ trunk/Source/WebKit/chromium/src/WebViewImpl.cpp 2012-11-27 00:39:53 UTC (rev 135787)
@@ -1274,6 +1274,11 @@
m_client-hasTouchEventHandlers(hasTouchHandlers);
}
+bool WebViewImpl::hasTouchEventHandlersAt(const WebPoint point)
+{
+return true;
+}
+
#if !OS(DARWIN)
// Mac has no way to open a context menu based on a keyboard event.
bool WebViewImpl::sendContextMenuEvent(const WebKeyboardEvent event)
Modified: trunk/Source/WebKit/chromium/src/WebViewImpl.h (135786 => 135787)
--- trunk/Source/WebKit/chromium/src/WebViewImpl.h 2012-11-27 00:17:49 UTC (rev 135786)
+++ trunk/Source/WebKit/chromium/src/WebViewImpl.h 2012-11-27 00:39:53 UTC (rev 135787)
@@ -152,6 +152,7 @@
virtual void setNeedsRedraw();
virtual bool isInputThrottled() const;
virtual bool handleInputEvent(const WebInputEvent);
+virtual bool hasTouchEventHandlersAt(const WebPoint);
virtual void mouseCaptureLost();
virtual void setFocus(bool enable);
virtual bool setComposition(
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [135788] trunk/Source/WebCore
Title: [135788] trunk/Source/WebCore
Revision 135788
Author akl...@apple.com
Date 2012-11-26 16:41:39 -0800 (Mon, 26 Nov 2012)
Log Message
RenderStyle: Move 'list-style-image' to rare inherited data.
http://webkit.org/b/103300
Reviewed by Antti Koivisto.
list-style-image is not nearly common enough to merit a spot in StyleInheritedData.
Move it to StyleRareInheritedData.
134kB progression on Membuster3.
* rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::diff):
(WebCore::RenderStyle::listStyleImage):
(WebCore::RenderStyle::setListStyleImage):
* rendering/style/StyleInheritedData.cpp:
(WebCore::StyleInheritedData::StyleInheritedData):
(WebCore::StyleInheritedData::operator==):
* rendering/style/StyleInheritedData.h:
(StyleInheritedData):
* rendering/style/StyleRareInheritedData.h:
* rendering/style/StyleRareInheritedData.cpp:
(SameSizeAsStyleRareInheritedData):
(WebCore::StyleRareInheritedData::StyleRareInheritedData):
(WebCore::StyleRareInheritedData::operator==):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/style/RenderStyle.cpp
trunk/Source/WebCore/rendering/style/StyleInheritedData.cpp
trunk/Source/WebCore/rendering/style/StyleInheritedData.h
trunk/Source/WebCore/rendering/style/StyleRareInheritedData.cpp
trunk/Source/WebCore/rendering/style/StyleRareInheritedData.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (135787 => 135788)
--- trunk/Source/WebCore/ChangeLog 2012-11-27 00:39:53 UTC (rev 135787)
+++ trunk/Source/WebCore/ChangeLog 2012-11-27 00:41:39 UTC (rev 135788)
@@ -1,3 +1,30 @@
+2012-11-26 Andreas Kling akl...@apple.com
+
+RenderStyle: Move 'list-style-image' to rare inherited data.
+http://webkit.org/b/103300
+
+Reviewed by Antti Koivisto.
+
+list-style-image is not nearly common enough to merit a spot in StyleInheritedData.
+Move it to StyleRareInheritedData.
+
+134kB progression on Membuster3.
+
+* rendering/style/RenderStyle.cpp:
+(WebCore::RenderStyle::diff):
+(WebCore::RenderStyle::listStyleImage):
+(WebCore::RenderStyle::setListStyleImage):
+* rendering/style/StyleInheritedData.cpp:
+(WebCore::StyleInheritedData::StyleInheritedData):
+(WebCore::StyleInheritedData::operator==):
+* rendering/style/StyleInheritedData.h:
+(StyleInheritedData):
+* rendering/style/StyleRareInheritedData.h:
+* rendering/style/StyleRareInheritedData.cpp:
+(SameSizeAsStyleRareInheritedData):
+(WebCore::StyleRareInheritedData::StyleRareInheritedData):
+(WebCore::StyleRareInheritedData::operator==):
+
2012-11-26 James Simonsen simon...@chromium.org
Consolidate FrameLoader::load() into one function taking a FrameLoadRequest
Modified: trunk/Source/WebCore/rendering/style/RenderStyle.cpp (135787 => 135788)
--- trunk/Source/WebCore/rendering/style/RenderStyle.cpp 2012-11-27 00:39:53 UTC (rev 135787)
+++ trunk/Source/WebCore/rendering/style/RenderStyle.cpp 2012-11-27 00:41:39 UTC (rev 135788)
@@ -491,7 +491,8 @@
|| rareInheritedData-m_imageResolution != other-rareInheritedData-m_imageResolution
#endif
|| rareInheritedData-m_lineSnap != other-rareInheritedData-m_lineSnap
-|| rareInheritedData-m_lineAlign != other-rareInheritedData-m_lineAlign)
+|| rareInheritedData-m_lineAlign != other-rareInheritedData-m_lineAlign
+|| rareInheritedData-listStyleImage != other-rareInheritedData-listStyleImage)
return StyleDifferenceLayout;
if (!rareInheritedData-shadowDataEquivalent(*other-rareInheritedData.get()))
@@ -507,7 +508,6 @@
#endif
if (inherited-line_height != other-inherited-line_height
-|| inherited-list_style_image != other-inherited-list_style_image
|| inherited-font != other-inherited-font
|| inherited-horizontal_border_spacing != other-inherited-horizontal_border_spacing
|| inherited-vertical_border_spacing != other-inherited-vertical_border_spacing
@@ -966,11 +966,11 @@
return factor;
}
-StyleImage* RenderStyle::listStyleImage() const { return inherited-list_style_image.get(); }
+StyleImage* RenderStyle::listStyleImage() const { return rareInheritedData-listStyleImage.get(); }
void RenderStyle::setListStyleImage(PassRefPtrStyleImage v)
{
-if (inherited-list_style_image != v)
-inherited.access()-list_style_image = v;
+if (rareInheritedData-listStyleImage != v)
+rareInheritedData.access()-listStyleImage = v;
}
Color RenderStyle::color() const { return inherited-color; }
Modified: trunk/Source/WebCore/rendering/style/StyleInheritedData.cpp (135787 => 135788)
--- trunk/Source/WebCore/rendering/style/StyleInheritedData.cpp 2012-11-27 00:39:53 UTC (rev 135787)
+++ trunk/Source/WebCore/rendering/style/StyleInheritedData.cpp 2012-11-27 00:41:39 UTC (rev 135788)
@@ -23,7 +23,6 @@
#include StyleInheritedData.h
#include
[webkit-changes] [135789] trunk
Title: [135789] trunk Revision 135789 Author commit-qu...@webkit.org Date 2012-11-26 16:56:30 -0800 (Mon, 26 Nov 2012) Log Message LongPress and LongTap gestures should start drag/drop and open context menu respectively. https://bugs.webkit.org/show_bug.cgi?id=101545 Patch by Varun Jain varunj...@chromium.org on 2012-11-26 Reviewed by Antonio Gomes. For LongPress, we simulate drag by sending a mouse down and mouse drag events. If a drag is not started (because maybe there is no draggable element), then we show context menu instead (which is the current behavior for LongPress). For LongTap, we use the existing functions that LongPress uses to summon the context menu. LongPress initiated drag and drop can be enabled/disabled by the platform using the Setting touchDragDropEnabled which is disabled by default. Source/WebCore: Tests: fast/events/touch/gesture/context-menu-on-long-tap.html fast/events/touch/gesture/long-press-on-draggable-element-triggers-drag.html * page/EventHandler.cpp: (WebCore::EventHandler::EventHandler): (WebCore::EventHandler::clear): (WebCore::EventHandler::handleMouseDraggedEvent): (WebCore::EventHandler::handleGestureEvent): (WebCore::EventHandler::handleGestureLongPress): (WebCore::EventHandler::handleGestureLongTap): (WebCore): (WebCore::EventHandler::handleGestureForTextSelectionOrContextMenu): (WebCore::EventHandler::adjustGesturePosition): (WebCore::EventHandler::handleDrag): * page/EventHandler.h: (EventHandler): * page/Settings.in: Source/WebKit/chromium: * public/WebSettings.h: * src/WebSettingsImpl.cpp: (WebKit::WebSettingsImpl::setTouchDragDropEnabled): (WebKit): * src/WebSettingsImpl.h: (WebSettingsImpl): Tools: * DumpRenderTree/chromium/TestRunner/src/EventSender.cpp: (WebTestRunner): (WebTestRunner::EventSender::EventSender): (WebTestRunner::EventSender::gestureLongTap): (WebTestRunner::EventSender::gestureEvent): * DumpRenderTree/chromium/TestRunner/src/EventSender.h: (EventSender): * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp: (WebTestRunner::TestRunner::TestRunner): (WebTestRunner::TestRunner::setTouchDragDropEnabled): (WebTestRunner): * DumpRenderTree/chromium/TestRunner/src/TestRunner.h: (TestRunner): LayoutTests: * fast/events/touch/gesture/context-menu-on-long-tap.html: Added. * fast/events/touch/gesture/long-press-on-draggable-element-triggers-drag.html: Added. * platform/chromium/fast/events/touch/gesture/context-menu-on-long-tap-expected.txt: Added. * platform/chromium/fast/events/touch/gesture/long-press-on-draggable-element-triggers-drag-expected.txt: Added. * touchadjustment/touch-links-longpress-expected.txt: * touchadjustment/touch-links-longpress.html: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/touchadjustment/touch-links-longpress-expected.txt trunk/LayoutTests/touchadjustment/touch-links-longpress.html trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/page/EventHandler.cpp trunk/Source/WebCore/page/EventHandler.h trunk/Source/WebCore/page/Settings.in trunk/Source/WebKit/chromium/ChangeLog trunk/Source/WebKit/chromium/public/WebSettings.h trunk/Source/WebKit/chromium/src/WebSettingsImpl.cpp trunk/Source/WebKit/chromium/src/WebSettingsImpl.h trunk/Tools/ChangeLog trunk/Tools/DumpRenderTree/chromium/TestRunner/src/EventSender.cpp trunk/Tools/DumpRenderTree/chromium/TestRunner/src/EventSender.h trunk/Tools/DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp trunk/Tools/DumpRenderTree/chromium/TestRunner/src/TestRunner.h Added Paths trunk/LayoutTests/fast/events/touch/gesture/context-menu-on-long-tap.html trunk/LayoutTests/fast/events/touch/gesture/long-press-on-draggable-element-triggers-drag.html trunk/LayoutTests/platform/chromium/fast/events/touch/gesture/context-menu-on-long-tap-expected.txt trunk/LayoutTests/platform/chromium/fast/events/touch/gesture/long-press-on-draggable-element-triggers-drag-expected.txt Diff Modified: trunk/LayoutTests/ChangeLog (135788 => 135789) --- trunk/LayoutTests/ChangeLog 2012-11-27 00:41:39 UTC (rev 135788) +++ trunk/LayoutTests/ChangeLog 2012-11-27 00:56:30 UTC (rev 135789) @@ -1,3 +1,25 @@ +2012-11-26 Varun Jain varunj...@chromium.org + +LongPress and LongTap gestures should start drag/drop and open context menu respectively. +https://bugs.webkit.org/show_bug.cgi?id=101545 + +Reviewed by Antonio Gomes. + +For LongPress, we simulate drag by sending a mouse down and mouse drag +events. If a drag is not started (because maybe there is no draggable +element), then we show context menu instead (which is the current +behavior for LongPress). For LongTap, we use the existing functions that +LongPress uses to summon the context menu. LongPress initiated drag and +drop can be enabled/disabled by the platform using the Setting +touchDragDropEnabled which is disabled by default. + +* fast/events/touch/gesture/context-menu-on-long-tap.html: Added. +*
[webkit-changes] [135790] trunk/Source/WTF
Title: [135790] trunk/Source/WTF
Revision 135790
Author fpi...@apple.com
Date 2012-11-26 17:09:31 -0800 (Mon, 26 Nov 2012)
Log Message
DataLog to a file should work if there are multiple processes using WTF
https://bugs.webkit.org/show_bug.cgi?id=103323
Reviewed by Mark Hahnenberg.
Whereas before DataLog would open a file with the name you specified, now it'll open a file with the
name plus the PID appended to it. So if you are dealing with multiple processes running with DataLog
to a file enabled, you'll get multiple separate log files.
* wtf/DataLog.cpp:
(WTF::initializeLogFileOnce):
Modified Paths
trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/DataLog.cpp
Diff
Modified: trunk/Source/WTF/ChangeLog (135789 => 135790)
--- trunk/Source/WTF/ChangeLog 2012-11-27 00:56:30 UTC (rev 135789)
+++ trunk/Source/WTF/ChangeLog 2012-11-27 01:09:31 UTC (rev 135790)
@@ -1,3 +1,17 @@
+2012-11-26 Filip Pizlo fpi...@apple.com
+
+DataLog to a file should work if there are multiple processes using WTF
+https://bugs.webkit.org/show_bug.cgi?id=103323
+
+Reviewed by Mark Hahnenberg.
+
+Whereas before DataLog would open a file with the name you specified, now it'll open a file with the
+name plus the PID appended to it. So if you are dealing with multiple processes running with DataLog
+to a file enabled, you'll get multiple separate log files.
+
+* wtf/DataLog.cpp:
+(WTF::initializeLogFileOnce):
+
2012-11-26 Zeno Albisser z...@webkit.org
[Qt] Fix the LLInt build on Mac
Modified: trunk/Source/WTF/wtf/DataLog.cpp (135789 => 135790)
--- trunk/Source/WTF/wtf/DataLog.cpp 2012-11-27 00:56:30 UTC (rev 135789)
+++ trunk/Source/WTF/wtf/DataLog.cpp 2012-11-27 01:09:31 UTC (rev 135790)
@@ -27,8 +27,13 @@
#include DataLog.h
#include stdarg.h
#include wtf/FilePrintStream.h
+#include wtf/WTFThreadData.h
#include wtf/Threading.h
+#if OS(UNIX)
+#include unistd.h
+#endif
+
#if OS(WINCE)
#ifndef _IONBF
#define _IONBF 0x0004
@@ -37,8 +42,9 @@
#define DATA_LOG_TO_FILE 0
-// Uncomment to force logging to the given file regardless of what the environment variable says.
-// #define DATA_LOG_FILENAME /tmp/WTFLog.txt
+// Uncomment to force logging to the given file regardless of what the environment variable says. Note that
+// we will append .pid.txt where pid is the PID.
+#define DATA_LOG_FILENAME /tmp/WTFLog
namespace WTF {
@@ -56,12 +62,14 @@
#else
const char* filename = getenv(WTF_DATA_LOG_FILENAME);
#endif
+char actualFilename[1024];
+snprintf(actualFilename, sizeof(actualFilename), %s.%d.txt, filename, getpid());
if (filename) {
-FILE* rawFile = fopen(filename, w);
+FILE* rawFile = fopen(actualFilename, w);
if (rawFile)
file = new FilePrintStream(rawFile);
else
-fprintf(stderr, Warning: Could not open log file %s for writing.\n, filename);
+fprintf(stderr, Warning: Could not open log file %s for writing.\n, actualFilename);
}
#endif // DATA_LOG_TO_FILE
if (!file)
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [135791] trunk/Source/WebKit2
Title: [135791] trunk/Source/WebKit2
Revision 135791
Author commit-qu...@webkit.org
Date 2012-11-26 17:35:08 -0800 (Mon, 26 Nov 2012)
Log Message
[EFL] Unreviewed build fix after r135767 without Tiled Backing Store
https://bugs.webkit.org/show_bug.cgi?id=103320
Unreviewed build fix.
Patch by Ryuan Choi ryuan.c...@gmail.com on 2012-11-26
* WebProcess/Plugins/Plugin.cpp:
* WebProcess/Plugins/Plugin.h:
(WebCore):
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/WebProcess/Plugins/Plugin.cpp
trunk/Source/WebKit2/WebProcess/Plugins/Plugin.h
Diff
Modified: trunk/Source/WebKit2/ChangeLog (135790 => 135791)
--- trunk/Source/WebKit2/ChangeLog 2012-11-27 01:09:31 UTC (rev 135790)
+++ trunk/Source/WebKit2/ChangeLog 2012-11-27 01:35:08 UTC (rev 135791)
@@ -1,3 +1,14 @@
+2012-11-26 Ryuan Choi ryuan.c...@gmail.com
+
+[EFL] Unreviewed build fix after r135767 without Tiled Backing Store
+https://bugs.webkit.org/show_bug.cgi?id=103320
+
+Unreviewed build fix.
+
+* WebProcess/Plugins/Plugin.cpp:
+* WebProcess/Plugins/Plugin.h:
+(WebCore):
+
2012-11-26 James Simonsen simon...@chromium.org
Consolidate FrameLoader::load() into one function taking a FrameLoadRequest
Modified: trunk/Source/WebKit2/WebProcess/Plugins/Plugin.cpp (135790 => 135791)
--- trunk/Source/WebKit2/WebProcess/Plugins/Plugin.cpp 2012-11-27 01:09:31 UTC (rev 135790)
+++ trunk/Source/WebKit2/WebProcess/Plugins/Plugin.cpp 2012-11-27 01:35:08 UTC (rev 135791)
@@ -27,6 +27,7 @@
#include Plugin.h
#include WebCoreArgumentCoders.h
+#include WebCore/IntPoint.h
using namespace WebCore;
Modified: trunk/Source/WebKit2/WebProcess/Plugins/Plugin.h (135790 => 135791)
--- trunk/Source/WebKit2/WebProcess/Plugins/Plugin.h 2012-11-27 01:09:31 UTC (rev 135790)
+++ trunk/Source/WebKit2/WebProcess/Plugins/Plugin.h 2012-11-27 01:35:08 UTC (rev 135791)
@@ -50,6 +50,7 @@
namespace WebCore {
class AffineTransform;
class GraphicsContext;
+class IntPoint;
class IntRect;
class IntSize;
class Scrollbar;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [135792] trunk/Source/WebCore
Title: [135792] trunk/Source/WebCore
Revision 135792
Author hara...@chromium.org
Date 2012-11-26 17:50:21 -0800 (Mon, 26 Nov 2012)
Log Message
[V8] Refactor WorkerScriptController
https://bugs.webkit.org/show_bug.cgi?id=103330
Reviewed by Adam Barth.
r135703 just moved methods from WorkerContextExecutionProxy
to WorkerScriptController. We should refactor the methods as a follow-up.
No tests. No change in behavior.
* bindings/v8/WorkerScriptController.cpp:
(WebCore::WorkerScriptController::~WorkerScriptController):
(WebCore::WorkerScriptController::disposeContext):
(WebCore::WorkerScriptController::initializeContextIfNeeded):
(WebCore::WorkerScriptController::evaluate):
(WebCore::WorkerScriptController::disableEval):
* bindings/v8/WorkerScriptController.h:
(WorkerScriptController):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/v8/WorkerScriptController.cpp
trunk/Source/WebCore/bindings/v8/WorkerScriptController.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (135791 => 135792)
--- trunk/Source/WebCore/ChangeLog 2012-11-27 01:35:08 UTC (rev 135791)
+++ trunk/Source/WebCore/ChangeLog 2012-11-27 01:50:21 UTC (rev 135792)
@@ -1,3 +1,24 @@
+2012-11-26 Kentaro Hara hara...@chromium.org
+
+[V8] Refactor WorkerScriptController
+https://bugs.webkit.org/show_bug.cgi?id=103330
+
+Reviewed by Adam Barth.
+
+r135703 just moved methods from WorkerContextExecutionProxy
+to WorkerScriptController. We should refactor the methods as a follow-up.
+
+No tests. No change in behavior.
+
+* bindings/v8/WorkerScriptController.cpp:
+(WebCore::WorkerScriptController::~WorkerScriptController):
+(WebCore::WorkerScriptController::disposeContext):
+(WebCore::WorkerScriptController::initializeContextIfNeeded):
+(WebCore::WorkerScriptController::evaluate):
+(WebCore::WorkerScriptController::disableEval):
+* bindings/v8/WorkerScriptController.h:
+(WorkerScriptController):
+
2012-11-26 Varun Jain varunj...@chromium.org
LongPress and LongTap gestures should start drag/drop and open context menu respectively.
Modified: trunk/Source/WebCore/bindings/v8/WorkerScriptController.cpp (135791 => 135792)
--- trunk/Source/WebCore/bindings/v8/WorkerScriptController.cpp 2012-11-27 01:35:08 UTC (rev 135791)
+++ trunk/Source/WebCore/bindings/v8/WorkerScriptController.cpp 2012-11-27 01:50:21 UTC (rev 135792)
@@ -79,19 +79,19 @@
// See http://webkit.org/b/83104#c14 for why this is here.
WebKit::Platform::current()-didStopWorkerRunLoop(WebKit::WebWorkerRunLoop(m_workerContext-thread()-runLoop()));
#endif
-dispose();
+disposeContext();
V8PerIsolateData::dispose(m_isolate);
m_isolate-Exit();
m_isolate-Dispose();
}
-void WorkerScriptController::dispose()
+void WorkerScriptController::disposeContext()
{
m_perContextData.clear();
m_context.clear();
}
-bool WorkerScriptController::initializeIfNeeded()
+bool WorkerScriptController::initializeContextIfNeeded()
{
if (!m_context.isEmpty())
return true;
@@ -108,7 +108,7 @@
m_perContextData = V8PerContextData::create(m_context.get());
if (!m_perContextData-init()) {
-dispose();
+disposeContext();
return false;
}
@@ -124,7 +124,7 @@
v8::Handlev8::Function workerContextConstructor = m_perContextData-constructorForType(contextType);
v8::Localv8::Object jsWorkerContext = V8ObjectConstructor::newInstance(workerContextConstructor);
if (jsWorkerContext.IsEmpty()) {
-dispose();
+disposeContext();
return false;
}
@@ -143,7 +143,7 @@
v8::HandleScope handleScope;
-if (!initializeIfNeeded())
+if (!initializeContextIfNeeded())
return ScriptValue();
if (!m_disableEvalPending.isEmpty()) {
@@ -186,16 +186,6 @@
return ScriptValue(result);
}
-void WorkerScriptController::setEvalAllowed(bool enable, const String errorMessage)
-{
-m_disableEvalPending = enable ? String() : errorMessage;
-}
-
-void WorkerScriptController::evaluate(const ScriptSourceCode sourceCode)
-{
-evaluate(sourceCode, 0);
-}
-
void WorkerScriptController::evaluate(const ScriptSourceCode sourceCode, ScriptValue* exception)
{
if (isExecutionForbidden())
@@ -244,7 +234,7 @@
void WorkerScriptController::disableEval(const String errorMessage)
{
-setEvalAllowed(false, errorMessage);
+m_disableEvalPending = errorMessage;
}
void WorkerScriptController::setException(const ScriptValue exception)
Modified: trunk/Source/WebCore/bindings/v8/WorkerScriptController.h (135791 => 135792)
--- trunk/Source/WebCore/bindings/v8/WorkerScriptController.h 2012-11-27 01:35:08 UTC (rev 135791)
+++ trunk/Source/WebCore/bindings/v8/WorkerScriptController.h 2012-11-27 01:50:21 UTC (rev 135792)
@@ -67,8 +67,7 @@
WorkerContext* workerContext() { return m_workerContext; }
-
[webkit-changes] [135793] trunk/Source/WebCore
Title: [135793] trunk/Source/WebCore
Revision 135793
Author akl...@apple.com
Date 2012-11-26 17:52:14 -0800 (Mon, 26 Nov 2012)
Log Message
Node: Remove IsSynchronizingSVGAttributesFlag.
http://webkit.org/b/103328
Reviewed by Antti Koivisto.
Animated SVG attributes used to be synchronized by using DOM API which could use unwanted re-entrancy
via callbacks below Element::attributeChanged(). The is synchronizing SVG attributes flag was used
to protect against such re-entrancy.
These days, lazy attributes are synchronized using Element::setSynchronizedLazyAttribute() to avoid
issues like this. The flag does nothing, so we can just remove it.
* dom/Node.h:
(WebCore):
* svg/SVGElement.cpp:
(WebCore::SVGElement::attributeChanged):
(WebCore::SVGElement::updateAnimatedSVGAttribute):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/Node.h
trunk/Source/WebCore/svg/SVGElement.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (135792 => 135793)
--- trunk/Source/WebCore/ChangeLog 2012-11-27 01:50:21 UTC (rev 135792)
+++ trunk/Source/WebCore/ChangeLog 2012-11-27 01:52:14 UTC (rev 135793)
@@ -1,3 +1,23 @@
+2012-11-26 Andreas Kling akl...@apple.com
+
+Node: Remove IsSynchronizingSVGAttributesFlag.
+http://webkit.org/b/103328
+
+Reviewed by Antti Koivisto.
+
+Animated SVG attributes used to be synchronized by using DOM API which could use unwanted re-entrancy
+via callbacks below Element::attributeChanged(). The is synchronizing SVG attributes flag was used
+to protect against such re-entrancy.
+
+These days, lazy attributes are synchronized using Element::setSynchronizedLazyAttribute() to avoid
+issues like this. The flag does nothing, so we can just remove it.
+
+* dom/Node.h:
+(WebCore):
+* svg/SVGElement.cpp:
+(WebCore::SVGElement::attributeChanged):
+(WebCore::SVGElement::updateAnimatedSVGAttribute):
+
2012-11-26 Kentaro Hara hara...@chromium.org
[V8] Refactor WorkerScriptController
Modified: trunk/Source/WebCore/dom/Node.h (135792 => 135793)
--- trunk/Source/WebCore/dom/Node.h 2012-11-27 01:50:21 UTC (rev 135792)
+++ trunk/Source/WebCore/dom/Node.h 2012-11-27 01:52:14 UTC (rev 135793)
@@ -98,7 +98,7 @@
typedef int ExceptionCode;
-const int nodeStyleChangeShift = 19;
+const int nodeStyleChangeShift = 18;
// SyntheticStyleChange means that we need to go through the entire style change logic even though
// no style property has actually changed. It is used to restructure the tree when, for instance,
@@ -706,23 +706,22 @@
IsParsingChildrenFinishedFlag = 1 15, // Element
#if ENABLE(SVG)
AreSVGAttributesValidFlag = 1 16, // Element
-IsSynchronizingSVGAttributesFlag = 1 17, // SVGElement
-HasSVGRareDataFlag = 1 18, // SVGElement
+HasSVGRareDataFlag = 1 17, // SVGElement
#endif
StyleChangeMask = 1 nodeStyleChangeShift | 1 (nodeStyleChangeShift + 1),
-SelfOrAncestorHasDirAutoFlag = 1 21,
+SelfOrAncestorHasDirAutoFlag = 1 20,
-HasNameOrIsEditingTextFlag = 1 22,
+HasNameOrIsEditingTextFlag = 1 21,
-InNamedFlowFlag = 1 23,
-HasSyntheticAttrChildNodesFlag = 1 24,
-HasCustomCallbacksFlag = 1 25,
-HasScopedHTMLStyleChildFlag = 1 26,
-HasEventTargetDataFlag = 1 27,
-V8CollectableDuringMinorGCFlag = 1 28,
-IsInsertionPointFlag = 1 29,
+InNamedFlowFlag = 1 22,
+HasSyntheticAttrChildNodesFlag = 1 23,
+HasCustomCallbacksFlag = 1 24,
+HasScopedHTMLStyleChildFlag = 1 25,
+HasEventTargetDataFlag = 1 26,
+V8CollectableDuringMinorGCFlag = 1 27,
+IsInsertionPointFlag = 1 28,
#if ENABLE(SVG)
DefaultNodeFlags = IsParsingChildrenFinishedFlag | AreSVGAttributesValidFlag,
@@ -731,7 +730,7 @@
#endif
};
-// 2 bits remaining
+// 3 bits remaining
bool getFlag(NodeFlags mask) const { return m_nodeFlags mask; }
void setFlag(bool f, NodeFlags mask) const { m_nodeFlags = (m_nodeFlags ~mask) | (-(int32_t)f mask); }
@@ -843,9 +842,6 @@
bool areSVGAttributesValid() const { return getFlag(AreSVGAttributesValidFlag); }
void setAreSVGAttributesValid() const { setFlag(AreSVGAttributesValidFlag); }
void clearAreSVGAttributesValid() { clearFlag(AreSVGAttributesValidFlag); }
-bool isSynchronizingSVGAttributes() const { return getFlag(IsSynchronizingSVGAttributesFlag); }
-void setIsSynchronizingSVGAttributes() const { setFlag(IsSynchronizingSVGAttributesFlag); }
-void clearIsSynchronizingSVGAttributes() const { clearFlag(IsSynchronizingSVGAttributesFlag); }
bool hasSVGRareData() const { return getFlag(HasSVGRareDataFlag); }
void setHasSVGRareData() { setFlag(HasSVGRareDataFlag); }
void clearHasSVGRareData() { clearFlag(HasSVGRareDataFlag); }
Modified:
[webkit-changes] [135794] trunk
Title: [135794] trunk
Revision 135794
Author dba...@webkit.org
Date 2012-11-26 18:00:23 -0800 (Mon, 26 Nov 2012)
Log Message
_javascript_ fails to handle String.replace() with large replacement string
https://bugs.webkit.org/show_bug.cgi?id=102956
rdar://problem/12738012
Reviewed by Oliver Hunt.
Source/_javascript_Core:
Fix an issue where we didn't check for overflow when computing the length
of the result of String.replace() with a large replacement string.
* runtime/StringPrototype.cpp:
(JSC::jsSpliceSubstringsWithSeparators):
LayoutTests:
Add test to ensure that we handle string replacement with a large replacement string.
* fast/js/script-tests/string-replacement-outofmemory.js: Added.
(createStringWithRepeatedChar):
* fast/js/string-replacement-outofmemory-expected.txt: Added.
* fast/js/string-replacement-outofmemory.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/runtime/StringPrototype.cpp
Added Paths
trunk/LayoutTests/fast/js/script-tests/string-replacement-outofmemory.js
trunk/LayoutTests/fast/js/string-replacement-outofmemory-expected.txt
trunk/LayoutTests/fast/js/string-replacement-outofmemory.html
Diff
Modified: trunk/LayoutTests/ChangeLog (135793 => 135794)
--- trunk/LayoutTests/ChangeLog 2012-11-27 01:52:14 UTC (rev 135793)
+++ trunk/LayoutTests/ChangeLog 2012-11-27 02:00:23 UTC (rev 135794)
@@ -1,3 +1,18 @@
+2012-11-26 Daniel Bates dba...@webkit.org
+
+_javascript_ fails to handle String.replace() with large replacement string
+https://bugs.webkit.org/show_bug.cgi?id=102956
+rdar://problem/12738012
+
+Reviewed by Oliver Hunt.
+
+Add test to ensure that we handle string replacement with a large replacement string.
+
+* fast/js/script-tests/string-replacement-outofmemory.js: Added.
+(createStringWithRepeatedChar):
+* fast/js/string-replacement-outofmemory-expected.txt: Added.
+* fast/js/string-replacement-outofmemory.html: Added.
+
2012-11-26 Varun Jain varunj...@chromium.org
LongPress and LongTap gestures should start drag/drop and open context menu respectively.
Added: trunk/LayoutTests/fast/js/script-tests/string-replacement-outofmemory.js (0 => 135794)
--- trunk/LayoutTests/fast/js/script-tests/string-replacement-outofmemory.js (rev 0)
+++ trunk/LayoutTests/fast/js/script-tests/string-replacement-outofmemory.js 2012-11-27 02:00:23 UTC (rev 135794)
@@ -0,0 +1,18 @@
+description(
+'This tests that string replacement with a large replacement string causes an out-of-memory exception. See a href="" 102956/a for more details.'
+);
+
+function createStringWithRepeatedChar(c, multiplicity) {
+while (c.length multiplicity)
+c += c;
+c = c.substring(0, multiplicity);
+return c;
+}
+
+var x = 1;
+var y = 2;
+x = createStringWithRepeatedChar(x, 1 12);
+y = createStringWithRepeatedChar(y, (1 20) + 1);
+
+shouldThrow(x.replace(/\\d/g, y), 'Error: Out of memory');
+var successfullyParsed = true;
Added: trunk/LayoutTests/fast/js/string-replacement-outofmemory-expected.txt (0 => 135794)
--- trunk/LayoutTests/fast/js/string-replacement-outofmemory-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/js/string-replacement-outofmemory-expected.txt 2012-11-27 02:00:23 UTC (rev 135794)
@@ -0,0 +1,10 @@
+This tests that string replacement with a large replacement string causes an out-of-memory exception. See bug 102956 for more details.
+
+On success, you will see a series of PASS messages, followed by TEST COMPLETE.
+
+
+PASS x.replace(/\d/g, y) threw exception Error: Out of memory.
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
Added: trunk/LayoutTests/fast/js/string-replacement-outofmemory.html (0 => 135794)
--- trunk/LayoutTests/fast/js/string-replacement-outofmemory.html (rev 0)
+++ trunk/LayoutTests/fast/js/string-replacement-outofmemory.html 2012-11-27 02:00:23 UTC (rev 135794)
@@ -0,0 +1,10 @@
+!DOCTYPE html
+html
+head
+script src=""
+/head
+body
+script src=""
+script src=""
+/body
+/html
Modified: trunk/Source/_javascript_Core/ChangeLog (135793 => 135794)
--- trunk/Source/_javascript_Core/ChangeLog 2012-11-27 01:52:14 UTC (rev 135793)
+++ trunk/Source/_javascript_Core/ChangeLog 2012-11-27 02:00:23 UTC (rev 135794)
@@ -1,3 +1,17 @@
+2012-11-26 Daniel Bates dba...@webkit.org
+
+_javascript_ fails to handle String.replace() with large replacement string
+https://bugs.webkit.org/show_bug.cgi?id=102956
+rdar://problem/12738012
+
+Reviewed by Oliver Hunt.
+
+Fix an issue where we didn't check for overflow when computing the length
+of the result of String.replace() with a large replacement string.
+
+* runtime/StringPrototype.cpp:
+(JSC::jsSpliceSubstringsWithSeparators):
+
2012-11-26 Zeno Albisser z...@webkit.org
[Qt] Fix the
[webkit-changes] [135795] trunk/Source/WebKit2
Title: [135795] trunk/Source/WebKit2
Revision 135795
Author timothy_hor...@apple.com
Date 2012-11-26 18:00:26 -0800 (Mon, 26 Nov 2012)
Log Message
PDFPlugin: Ctrl-click opens a link in a PDF in addition to context menu
https://bugs.webkit.org/show_bug.cgi?id=103282
rdar://problem/12710892
Reviewed by Dan Bernstein.
Don't send standard mouse events to PDFKit if a click will also show/hide the context menu.
* WebProcess/Plugins/PDF/PDFPlugin.mm:
(WebKit::PDFPlugin::handleMouseEvent):
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/WebProcess/Plugins/PDF/PDFPlugin.mm
Diff
Modified: trunk/Source/WebKit2/ChangeLog (135794 => 135795)
--- trunk/Source/WebKit2/ChangeLog 2012-11-27 02:00:23 UTC (rev 135794)
+++ trunk/Source/WebKit2/ChangeLog 2012-11-27 02:00:26 UTC (rev 135795)
@@ -1,3 +1,16 @@
+2012-11-26 Tim Horton timothy_hor...@apple.com
+
+PDFPlugin: Ctrl-click opens a link in a PDF in addition to context menu
+https://bugs.webkit.org/show_bug.cgi?id=103282
+rdar://problem/12710892
+
+Reviewed by Dan Bernstein.
+
+Don't send standard mouse events to PDFKit if a click will also show/hide the context menu.
+
+* WebProcess/Plugins/PDF/PDFPlugin.mm:
+(WebKit::PDFPlugin::handleMouseEvent):
+
2012-11-26 Ryuan Choi ryuan.c...@gmail.com
[EFL] Unreviewed build fix after r135767 without Tiled Backing Store
Modified: trunk/Source/WebKit2/WebProcess/Plugins/PDF/PDFPlugin.mm (135794 => 135795)
--- trunk/Source/WebKit2/WebProcess/Plugins/PDF/PDFPlugin.mm 2012-11-27 02:00:23 UTC (rev 135794)
+++ trunk/Source/WebKit2/WebProcess/Plugins/PDF/PDFPlugin.mm 2012-11-27 02:00:26 UTC (rev 135795)
@@ -523,6 +523,10 @@
|| IntRect(m_scrollCornerLayer.get().frame).contains(mousePosition))
return false;
+// Right-clicks and Control-clicks always call handleContextMenuEvent as well.
+if (event.button() == WebMouseEvent::RightButton || (event.button() == WebMouseEvent::LeftButton event.controlKey()))
+return true;
+
NSEvent *nsEvent = nsEventForWebMouseEvent(event);
switch (event.type()) {
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
