[webkit-changes] [138125] trunk/LayoutTests
Title: [138125] trunk/LayoutTests Revision 138125 Author loi...@chromium.org Date 2012-12-19 00:15:51 -0800 (Wed, 19 Dec 2012) Log Message Unreviewed gardening. Update expectation for mac and remove wrong expectation for win. * platform/chromium-mac-snowleopard/fast/text/line-initial-and-final-swashes-expected.png: Added. * platform/chromium-win/fast/text/line-initial-and-final-swashes-expected.png: Removed. Modified Paths trunk/LayoutTests/ChangeLog Added Paths trunk/LayoutTests/platform/chromium-mac-snowleopard/fast/text/line-initial-and-final-swashes-expected.png Removed Paths trunk/LayoutTests/platform/chromium-win/fast/text/line-initial-and-final-swashes-expected.png Diff Modified: trunk/LayoutTests/ChangeLog (138124 => 138125) --- trunk/LayoutTests/ChangeLog 2012-12-19 07:57:33 UTC (rev 138124) +++ trunk/LayoutTests/ChangeLog 2012-12-19 08:15:51 UTC (rev 138125) @@ -1,3 +1,10 @@ +2012-12-19 Ilya Tikhonovsky loi...@chromium.org + +Unreviewed gardening. Update expectation for mac and remove wrong expectation for win. + +* platform/chromium-mac-snowleopard/fast/text/line-initial-and-final-swashes-expected.png: Added. +* platform/chromium-win/fast/text/line-initial-and-final-swashes-expected.png: Removed. + 2012-12-18 Dominic Mazzoni dmazz...@google.com AX: radio-button-checkbox-size is Mac-specific and should be moved. Added: trunk/LayoutTests/platform/chromium-mac-snowleopard/fast/text/line-initial-and-final-swashes-expected.png (Binary files differ) Property changes on: trunk/LayoutTests/platform/chromium-mac-snowleopard/fast/text/line-initial-and-final-swashes-expected.png ___ Added: svn:mime-type Deleted: trunk/LayoutTests/platform/chromium-win/fast/text/line-initial-and-final-swashes-expected.png (Binary files differ) ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [138126] trunk/Source/WebKit2
Title: [138126] trunk/Source/WebKit2 Revision 138126 Author commit-qu...@webkit.org Date 2012-12-19 00:21:19 -0800 (Wed, 19 Dec 2012) Log Message Unused parameters on WebContext.cpp https://bugs.webkit.org/show_bug.cgi?id=105395 Patch by KyungTae Kim ktf@samsung.com on 2012-12-19 Reviewed by Kentaro Hara. Because the parameters 'certficate', 'host' are not used if !ENABLE(NETWORK_PROCESS), use UNUSED_PARAM macro to fix build warning -Wunused-parameter. * UIProcess/WebContext.cpp: (WebKit::WebContext::allowSpecificHTTPSCertificateForHost): Modified Paths trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/UIProcess/WebContext.cpp Diff Modified: trunk/Source/WebKit2/ChangeLog (138125 => 138126) --- trunk/Source/WebKit2/ChangeLog 2012-12-19 08:15:51 UTC (rev 138125) +++ trunk/Source/WebKit2/ChangeLog 2012-12-19 08:21:19 UTC (rev 138126) @@ -1,3 +1,16 @@ +2012-12-19 KyungTae Kim ktf@samsung.com + +Unused parameters on WebContext.cpp +https://bugs.webkit.org/show_bug.cgi?id=105395 + +Reviewed by Kentaro Hara. + +Because the parameters 'certficate', 'host' are not used if !ENABLE(NETWORK_PROCESS), +use UNUSED_PARAM macro to fix build warning -Wunused-parameter. + +* UIProcess/WebContext.cpp: +(WebKit::WebContext::allowSpecificHTTPSCertificateForHost): + 2012-12-18 Alexey Proskuryakov a...@apple.com Remove unnecessary functions from CookiesStrategy Modified: trunk/Source/WebKit2/UIProcess/WebContext.cpp (138125 => 138126) --- trunk/Source/WebKit2/UIProcess/WebContext.cpp 2012-12-19 08:15:51 UTC (rev 138125) +++ trunk/Source/WebKit2/UIProcess/WebContext.cpp 2012-12-19 08:21:19 UTC (rev 138126) @@ -1055,6 +1055,9 @@ m_networkProcess-send(Messages::NetworkProcess::AllowSpecificHTTPSCertificateForHost(certificate-platformCertificateInfo(), host), 0); return; } +#else +UNUSED_PARAM(certificate); +UNUSED_PARAM(host); #endif // FIXME: It's unclear whether we want this SPI to be exposed and used for clients that don't use the NetworkProcess. ASSERT_NOT_REACHED(); ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [138127] trunk/LayoutTests
Title: [138127] trunk/LayoutTests Revision 138127 Author loi...@chromium.org Date 2012-12-19 00:23:27 -0800 (Wed, 19 Dec 2012) Log Message Unreviewed gardening. Restore expectations for mac. The tests still have problem with scroller image. * platform/chromium/TestExpectations: added: webkit.org/b/102294 [ Mac ] platform/chromium/virtual/deferred/fast/images/exif-orientation.html [ ImageOnlyFailure ] added: webkit.org/b/102294 [ Mac ] platform/chromium/virtual/deferred/fast/images/exif-orientation-css.html [ ImageOnlyFailure ] added: webkit.org/b/102294 [ Mac ] platform/chromium/virtual/deferred/fast/images/gray-scale-jpeg-with-color-profile.html [ ImageOnlyFailure ] Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (138126 => 138127) --- trunk/LayoutTests/ChangeLog 2012-12-19 08:21:19 UTC (rev 138126) +++ trunk/LayoutTests/ChangeLog 2012-12-19 08:23:27 UTC (rev 138127) @@ -1,5 +1,16 @@ 2012-12-19 Ilya Tikhonovsky loi...@chromium.org +Unreviewed gardening. Restore expectations for mac. + +The tests still have problem with scroller image. + +* platform/chromium/TestExpectations: +added: webkit.org/b/102294 [ Mac ] platform/chromium/virtual/deferred/fast/images/exif-orientation.html [ ImageOnlyFailure ] +added: webkit.org/b/102294 [ Mac ] platform/chromium/virtual/deferred/fast/images/exif-orientation-css.html [ ImageOnlyFailure ] +added: webkit.org/b/102294 [ Mac ] platform/chromium/virtual/deferred/fast/images/gray-scale-jpeg-with-color-profile.html [ ImageOnlyFailure ] + +2012-12-19 Ilya Tikhonovsky loi...@chromium.org + Unreviewed gardening. Update expectation for mac and remove wrong expectation for win. * platform/chromium-mac-snowleopard/fast/text/line-initial-and-final-swashes-expected.png: Added. Modified: trunk/LayoutTests/platform/chromium/TestExpectations (138126 => 138127) --- trunk/LayoutTests/platform/chromium/TestExpectations 2012-12-19 08:21:19 UTC (rev 138126) +++ trunk/LayoutTests/platform/chromium/TestExpectations 2012-12-19 08:23:27 UTC (rev 138127) @@ -4115,6 +4115,9 @@ webkit.org/b/102264 [ Debug ] css3/filters/custom/custom-filter-property-computed-style.html [ Pass Timeout ] webkit.org/b/102277 fast/events/frame-scroll-fake-mouse-move.html [ Pass Failure ] webkit.org/b/102277 fast/events/overflow-scroll-fake-mouse-move.html [ Pass Failure ] +webkit.org/b/102294 [ Mac ] platform/chromium/virtual/deferred/fast/images/exif-orientation.html [ ImageOnlyFailure ] +webkit.org/b/102294 [ Mac ] platform/chromium/virtual/deferred/fast/images/exif-orientation-css.html [ ImageOnlyFailure ] +webkit.org/b/102294 [ Mac ] platform/chromium/virtual/deferred/fast/images/gray-scale-jpeg-with-color-profile.html [ ImageOnlyFailure ] # This test is consistently leaking state into the next test. webkit.org/b/85522 http/tests/security/sandboxed-iframe-form-top.html [ Skip ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [138128] trunk/LayoutTests
Title: [138128] trunk/LayoutTests
Revision 138128
Author commit-qu...@webkit.org
Date 2012-12-19 00:41:02 -0800 (Wed, 19 Dec 2012)
Log Message
transitions/interrupted-accelerated-transition.html should use pauseAPI
https://bugs.webkit.org/show_bug.cgi?id=103524
Patch by Jussi Kukkonen jussi.kukko...@intel.com on 2012-12-19
Reviewed by Simon Fraser.
In certain situations interrupted-accelerated-transition.html exceeds the
test tolerance, making the test flaky. Use the pauseAPI so we don't
depend on _javascript_ timing.
* transitions/resources/interrupted-accelerated-transition-final.html:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/transitions/resources/interrupted-accelerated-transition-final.html
Diff
Modified: trunk/LayoutTests/ChangeLog (138127 => 138128)
--- trunk/LayoutTests/ChangeLog 2012-12-19 08:23:27 UTC (rev 138127)
+++ trunk/LayoutTests/ChangeLog 2012-12-19 08:41:02 UTC (rev 138128)
@@ -1,3 +1,16 @@
+2012-12-19 Jussi Kukkonen jussi.kukko...@intel.com
+
+transitions/interrupted-accelerated-transition.html should use pauseAPI
+https://bugs.webkit.org/show_bug.cgi?id=103524
+
+Reviewed by Simon Fraser.
+
+In certain situations interrupted-accelerated-transition.html exceeds the
+test tolerance, making the test flaky. Use the pauseAPI so we don't
+depend on _javascript_ timing.
+
+* transitions/resources/interrupted-accelerated-transition-final.html:
+
2012-12-19 Ilya Tikhonovsky loi...@chromium.org
Unreviewed gardening. Restore expectations for mac.
Modified: trunk/LayoutTests/transitions/resources/interrupted-accelerated-transition-final.html (138127 => 138128)
--- trunk/LayoutTests/transitions/resources/interrupted-accelerated-transition-final.html 2012-12-19 08:23:27 UTC (rev 138127)
+++ trunk/LayoutTests/transitions/resources/interrupted-accelerated-transition-final.html 2012-12-19 08:41:02 UTC (rev 138128)
@@ -32,7 +32,7 @@
document.getElementById('box').className = 'faded';
}
-runTransitionTest(expectedValues, setupTest);
+runTransitionTest(expectedValues, setupTest, usePauseAPI);
/script
/head
body
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [138129] trunk
Title: [138129] trunk
Revision 138129
Author loi...@chromium.org
Date 2012-12-19 00:46:12 -0800 (Wed, 19 Dec 2012)
Log Message
Unreviewed, rolling out r138123.
http://trac.webkit.org/changeset/138123
https://bugs.webkit.org/show_bug.cgi?id=105399
It broke compositing/visibility/visibility-simple-video-
layer.html (Requested by loislo on #webkit).
Patch by Sheriff Bot webkit.review@gmail.com on 2012-12-19
Source/WebCore:
* dom/Element.cpp:
(WebCore::Element::insertedInto):
(WebCore::Element::removedFrom):
* dom/Element.h:
* dom/Node.cpp:
(WebCore::Node::insertedInto):
(WebCore):
(WebCore::Node::removedFrom):
LayoutTests:
* fast/dom/shadow/getelementbyid-shadow-expected.txt: Removed.
* fast/dom/shadow/getelementbyid-shadow.html: Removed.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/Element.cpp
trunk/Source/WebCore/dom/Element.h
trunk/Source/WebCore/dom/Node.cpp
Removed Paths
trunk/LayoutTests/fast/dom/shadow/getelementbyid-shadow-expected.txt
trunk/LayoutTests/fast/dom/shadow/getelementbyid-shadow.html
Diff
Modified: trunk/LayoutTests/ChangeLog (138128 => 138129)
--- trunk/LayoutTests/ChangeLog 2012-12-19 08:41:02 UTC (rev 138128)
+++ trunk/LayoutTests/ChangeLog 2012-12-19 08:46:12 UTC (rev 138129)
@@ -1,3 +1,15 @@
+2012-12-19 Sheriff Bot webkit.review@gmail.com
+
+Unreviewed, rolling out r138123.
+http://trac.webkit.org/changeset/138123
+https://bugs.webkit.org/show_bug.cgi?id=105399
+
+It broke compositing/visibility/visibility-simple-video-
+layer.html (Requested by loislo on #webkit).
+
+* fast/dom/shadow/getelementbyid-shadow-expected.txt: Removed.
+* fast/dom/shadow/getelementbyid-shadow.html: Removed.
+
2012-12-19 Jussi Kukkonen jussi.kukko...@intel.com
transitions/interrupted-accelerated-transition.html should use pauseAPI
Deleted: trunk/LayoutTests/fast/dom/shadow/getelementbyid-shadow-expected.txt (138128 => 138129)
--- trunk/LayoutTests/fast/dom/shadow/getelementbyid-shadow-expected.txt 2012-12-19 08:41:02 UTC (rev 138128)
+++ trunk/LayoutTests/fast/dom/shadow/getelementbyid-shadow-expected.txt 2012-12-19 08:46:12 UTC (rev 138129)
@@ -1,37 +0,0 @@
-Tests to ensure ShadowRoot.getElementById works after complex DOM manipulation.
-
-On success, you will see a series of PASS messages, followed by TEST COMPLETE.
-
-
-PASS document.getElementById(A) is A
-PASS shadowRootA.getElementById(B) is B
-PASS shadowRootB.getElementById(C) is C
-PASS shadowRootC.getElementById(D) is D
-
-Remove C from shadowRootB
-PASS document.getElementById(A) is A
-PASS shadowRootA.getElementById(B) is B
-PASS shadowRootB.getElementById(C) is null
-PASS shadowRootC.getElementById(D) is D
-
-Append C to ShadowRootB, and remove A from document
-PASS document.getElementById(A) is null
-PASS shadowRootA.getElementById(B) is B
-PASS shadowRootB.getElementById(C) is C
-PASS shadowRootC.getElementById(D) is D
-
-Remove C from shadowRootB
-PASS document.getElementById(A) is null
-PASS shadowRootA.getElementById(B) is B
-PASS shadowRootB.getElementById(C) is null
-PASS shadowRootC.getElementById(D) is D
-
-Remove D from shadowRootC
-PASS document.getElementById(A) is null
-PASS shadowRootA.getElementById(B) is B
-PASS shadowRootB.getElementById(C) is null
-PASS shadowRootC.getElementById(D) is null
-PASS successfullyParsed is true
-
-TEST COMPLETE
-
Deleted: trunk/LayoutTests/fast/dom/shadow/getelementbyid-shadow.html (138128 => 138129)
--- trunk/LayoutTests/fast/dom/shadow/getelementbyid-shadow.html 2012-12-19 08:41:02 UTC (rev 138128)
+++ trunk/LayoutTests/fast/dom/shadow/getelementbyid-shadow.html 2012-12-19 08:46:12 UTC (rev 138129)
@@ -1,78 +0,0 @@
-!DOCTYPE html
-html
-body
-script src=""
-script src=""
-
-div id=container/div
-pre id=console/pre
-
-script
-description(Tests to ensure ShadowRoot.getElementById works after complex DOM manipulation.);
-
-function createDiv(id)
-{
-var div = document.createElement('div');
-div.id = id;
-return div;
-}
-
-var A = createDiv('A');
-var B = createDiv('B');
-var C = createDiv('C');
-var D = createDiv('D');
-var shadowRootA = A.webkitCreateShadowRoot();
-var shadowRootB = B.webkitCreateShadowRoot();
-var shadowRootC = C.webkitCreateShadowRoot();
-
-shadowRootA.appendChild(B);
-shadowRootB.appendChild(C);
-shadowRootC.appendChild(D);
-
-container.appendChild(A);
-shouldBe('document.getElementById(A)', 'A');
-shouldBe('shadowRootA.getElementById(B)', 'B');
-shouldBe('shadowRootB.getElementById(C)', 'C');
-shouldBe('shadowRootC.getElementById(D)', 'D');
-
-debug('');
-debug('Remove C from shadowRootB');
-shadowRootB.removeChild(C);
-
-shouldBe('document.getElementById(A)', 'A');
-shouldBe('shadowRootA.getElementById(B)', 'B');
-shouldBe('shadowRootB.getElementById(C)', 'null');
-shouldBe('shadowRootC.getElementById(D)', 'D');
-
-debug('');
-debug('Append C to ShadowRootB, and remove A from document');
[webkit-changes] [138130] trunk
Title: [138130] trunk
Revision 138130
Author ta...@google.com
Date 2012-12-19 00:54:10 -0800 (Wed, 19 Dec 2012)
Log Message
[Shadow] TITLE elements in Shadow DOM should not affect document.title attribute
https://bugs.webkit.org/show_bug.cgi?id=85864
Reviewed by Ryosuke Niwa.
Source/WebCore:
Modified HTMLTitleElement to check whether a title element is in a
shadow tree or not when it is inserted or removed. Now if a title
element has been just removed from or inserted into a shadow tree,
document.title is not updated independent of inDocument(). If the
title element is not in a shadow tree and in document,
document.title is updated.
Test: fast/dom/shadow/title-element-in-shadow.html
* html/HTMLTitleElement.cpp:
(WebCore::HTMLTitleElement::insertedInto):
Added a condition: isInShadowTree() to the code which checks
inDocument or not.
(WebCore::HTMLTitleElement::removedFrom):
Added a condition: insertionPoint.isInShadowTree() to the code which
checks an insertion point is in a document or not.
(WebCore::HTMLTitleElement::childrenChanged):
Added a condition: isInShadowTree() before setTitle.
If not isInShadowTree, modified to removeTitle from document.
LayoutTests:
* fast/dom/shadow/title-element-in-shadow-expected.txt: Added.
* fast/dom/shadow/title-element-in-shadow.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/HTMLTitleElement.cpp
Added Paths
trunk/LayoutTests/fast/dom/shadow/title-element-in-shadow-expected.txt
trunk/LayoutTests/fast/dom/shadow/title-element-in-shadow.html
Diff
Modified: trunk/LayoutTests/ChangeLog (138129 => 138130)
--- trunk/LayoutTests/ChangeLog 2012-12-19 08:46:12 UTC (rev 138129)
+++ trunk/LayoutTests/ChangeLog 2012-12-19 08:54:10 UTC (rev 138130)
@@ -1,3 +1,13 @@
+2012-12-19 Takashi Sakamoto ta...@google.com
+
+[Shadow] TITLE elements in Shadow DOM should not affect document.title attribute
+https://bugs.webkit.org/show_bug.cgi?id=85864
+
+Reviewed by Ryosuke Niwa.
+
+* fast/dom/shadow/title-element-in-shadow-expected.txt: Added.
+* fast/dom/shadow/title-element-in-shadow.html: Added.
+
2012-12-19 Sheriff Bot webkit.review@gmail.com
Unreviewed, rolling out r138123.
Added: trunk/LayoutTests/fast/dom/shadow/title-element-in-shadow-expected.txt (0 => 138130)
--- trunk/LayoutTests/fast/dom/shadow/title-element-in-shadow-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/dom/shadow/title-element-in-shadow-expected.txt 2012-12-19 08:54:10 UTC (rev 138130)
@@ -0,0 +1,21 @@
+This test ensures that title elements in a shadow subtree do not affect document.title attribute.
+
+On success, you will see a series of PASS messages, followed by TEST COMPLETE.
+
+
+create a title element and insert it to document.
+PASS document.title is document title
+remove title element from document.
+PASS document.title is
+create a shadow root whose host is already in document, create a subtree which contains a title element, and add the subtree to the shadow root.
+PASS document.title is
+remove the subtree from document.
+PASS document.title is
+create a subtree, add a shadow root which contains a title element to the subtree, and insert the subtree to document.
+PASS document.title is
+remove the subtree from document
+PASS document.title is
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
Added: trunk/LayoutTests/fast/dom/shadow/title-element-in-shadow.html (0 => 138130)
--- trunk/LayoutTests/fast/dom/shadow/title-element-in-shadow.html (rev 0)
+++ trunk/LayoutTests/fast/dom/shadow/title-element-in-shadow.html 2012-12-19 08:54:10 UTC (rev 138130)
@@ -0,0 +1,46 @@
+!DOCTYPE html
+html
+head
+script src=""
+script src=""
+/head
+body
+script
+description(This test ensures that title elements in a shadow subtree do not affect document.title attribute.)
+
+debug('create a title element and insert it to document.');
+var title = document.createElement('title');
+title.appendChild(document.createTextNode('document title'));
+document.head.appendChild(title);
+shouldBe('document.title', 'document title');
+document.head.removeChild(title);
+debug('remove title element from document.');
+shouldBe('document.title', '');
+
+debug('create a shadow root whose host is already in document, create a subtree which contains a title element, and add the subtree to the shadow root.');
+var subtree1 = document.createElement('div');
+var shadow1 = subtree1.webkitCreateShadowRoot();
+document.head.appendChild(subtree1);
+var shadowTitle = document.createElement('title');
+shadowTitle.appendChild(document.createTextNode('shadow title1'));
+shadow1.appendChild(shadowTitle);
+shouldBe('document.title', '');
+
+debug('remove the subtree from document.');
+document.head.removeChild(subtree1);
+shouldBe('document.title', '');
+
+debug('create a subtree, add a shadow root which contains a title element to the subtree, and
[webkit-changes] [138131] trunk
Title: [138131] trunk
Revision 138131
Author loi...@chromium.org
Date 2012-12-19 01:56:33 -0800 (Wed, 19 Dec 2012)
Log Message
Unreviewed, rolling out r138129.
http://trac.webkit.org/changeset/138129
https://bugs.webkit.org/show_bug.cgi?id=105399
reapply patch r138123. The problem was on chromium side at r173875.
Source/WebCore:
* dom/Element.cpp:
(WebCore::Element::insertedInto):
(WebCore::Element::removedFrom):
* dom/Element.h:
(WebCore::Node::insertedInto):
(WebCore):
(WebCore::Node::removedFrom):
* dom/Node.cpp:
LayoutTests:
* fast/dom/shadow/getelementbyid-shadow-expected.txt: Added.
* fast/dom/shadow/getelementbyid-shadow.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/Element.cpp
trunk/Source/WebCore/dom/Element.h
trunk/Source/WebCore/dom/Node.cpp
Added Paths
trunk/LayoutTests/fast/dom/shadow/getelementbyid-shadow-expected.txt
trunk/LayoutTests/fast/dom/shadow/getelementbyid-shadow.html
Diff
Modified: trunk/LayoutTests/ChangeLog (138130 => 138131)
--- trunk/LayoutTests/ChangeLog 2012-12-19 08:54:10 UTC (rev 138130)
+++ trunk/LayoutTests/ChangeLog 2012-12-19 09:56:33 UTC (rev 138131)
@@ -1,3 +1,14 @@
+2012-12-19 Ilya Tikhonovsky loi...@chromium.org
+
+Unreviewed, rolling out r138129.
+http://trac.webkit.org/changeset/138129
+https://bugs.webkit.org/show_bug.cgi?id=105399
+
+reapply patch r138123. The problem was on chromium side at r173875.
+
+* fast/dom/shadow/getelementbyid-shadow-expected.txt: Added.
+* fast/dom/shadow/getelementbyid-shadow.html: Added.
+
2012-12-19 Takashi Sakamoto ta...@google.com
[Shadow] TITLE elements in Shadow DOM should not affect document.title attribute
Added: trunk/LayoutTests/fast/dom/shadow/getelementbyid-shadow-expected.txt (0 => 138131)
--- trunk/LayoutTests/fast/dom/shadow/getelementbyid-shadow-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/dom/shadow/getelementbyid-shadow-expected.txt 2012-12-19 09:56:33 UTC (rev 138131)
@@ -0,0 +1,37 @@
+Tests to ensure ShadowRoot.getElementById works after complex DOM manipulation.
+
+On success, you will see a series of PASS messages, followed by TEST COMPLETE.
+
+
+PASS document.getElementById(A) is A
+PASS shadowRootA.getElementById(B) is B
+PASS shadowRootB.getElementById(C) is C
+PASS shadowRootC.getElementById(D) is D
+
+Remove C from shadowRootB
+PASS document.getElementById(A) is A
+PASS shadowRootA.getElementById(B) is B
+PASS shadowRootB.getElementById(C) is null
+PASS shadowRootC.getElementById(D) is D
+
+Append C to ShadowRootB, and remove A from document
+PASS document.getElementById(A) is null
+PASS shadowRootA.getElementById(B) is B
+PASS shadowRootB.getElementById(C) is C
+PASS shadowRootC.getElementById(D) is D
+
+Remove C from shadowRootB
+PASS document.getElementById(A) is null
+PASS shadowRootA.getElementById(B) is B
+PASS shadowRootB.getElementById(C) is null
+PASS shadowRootC.getElementById(D) is D
+
+Remove D from shadowRootC
+PASS document.getElementById(A) is null
+PASS shadowRootA.getElementById(B) is B
+PASS shadowRootB.getElementById(C) is null
+PASS shadowRootC.getElementById(D) is null
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
Property changes on: trunk/LayoutTests/fast/dom/shadow/getelementbyid-shadow-expected.txt
___
Added: svn:eol-style
Added: trunk/LayoutTests/fast/dom/shadow/getelementbyid-shadow.html (0 => 138131)
--- trunk/LayoutTests/fast/dom/shadow/getelementbyid-shadow.html (rev 0)
+++ trunk/LayoutTests/fast/dom/shadow/getelementbyid-shadow.html 2012-12-19 09:56:33 UTC (rev 138131)
@@ -0,0 +1,78 @@
+!DOCTYPE html
+html
+body
+script src=""
+script src=""
+
+div id=container/div
+pre id=console/pre
+
+script
+description(Tests to ensure ShadowRoot.getElementById works after complex DOM manipulation.);
+
+function createDiv(id)
+{
+var div = document.createElement('div');
+div.id = id;
+return div;
+}
+
+var A = createDiv('A');
+var B = createDiv('B');
+var C = createDiv('C');
+var D = createDiv('D');
+var shadowRootA = A.webkitCreateShadowRoot();
+var shadowRootB = B.webkitCreateShadowRoot();
+var shadowRootC = C.webkitCreateShadowRoot();
+
+shadowRootA.appendChild(B);
+shadowRootB.appendChild(C);
+shadowRootC.appendChild(D);
+
+container.appendChild(A);
+shouldBe('document.getElementById(A)', 'A');
+shouldBe('shadowRootA.getElementById(B)', 'B');
+shouldBe('shadowRootB.getElementById(C)', 'C');
+shouldBe('shadowRootC.getElementById(D)', 'D');
+
+debug('');
+debug('Remove C from shadowRootB');
+shadowRootB.removeChild(C);
+
+shouldBe('document.getElementById(A)', 'A');
+shouldBe('shadowRootA.getElementById(B)', 'B');
+shouldBe('shadowRootB.getElementById(C)', 'null');
+shouldBe('shadowRootC.getElementById(D)', 'D');
+
+debug('');
+debug('Append C to ShadowRootB, and remove A from document');
[webkit-changes] [138132] trunk/LayoutTests
Title: [138132] trunk/LayoutTests Revision 138132 Author loi...@chromium.org Date 2012-12-19 02:10:14 -0800 (Wed, 19 Dec 2012) Log Message Unreviewed gardening. Move chromium-mac image to chromium where it will also be used for win and linux. * platform/chromium/fast/text/line-initial-and-final-swashes-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/text/line-initial-and-final-swashes-expected.png. Modified Paths trunk/LayoutTests/ChangeLog Added Paths trunk/LayoutTests/platform/chromium/fast/text/line-initial-and-final-swashes-expected.png Removed Paths trunk/LayoutTests/platform/chromium-mac/fast/text/line-initial-and-final-swashes-expected.png Diff Modified: trunk/LayoutTests/ChangeLog (138131 => 138132) --- trunk/LayoutTests/ChangeLog 2012-12-19 09:56:33 UTC (rev 138131) +++ trunk/LayoutTests/ChangeLog 2012-12-19 10:10:14 UTC (rev 138132) @@ -1,5 +1,11 @@ 2012-12-19 Ilya Tikhonovsky loi...@chromium.org +Unreviewed gardening. Move chromium-mac image to chromium where it will also be used for win and linux. + +* platform/chromium/fast/text/line-initial-and-final-swashes-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/text/line-initial-and-final-swashes-expected.png. + +2012-12-19 Ilya Tikhonovsky loi...@chromium.org + Unreviewed, rolling out r138129. http://trac.webkit.org/changeset/138129 https://bugs.webkit.org/show_bug.cgi?id=105399 Copied: trunk/LayoutTests/platform/chromium/fast/text/line-initial-and-final-swashes-expected.png (from rev 138131, trunk/LayoutTests/platform/chromium-mac/fast/text/line-initial-and-final-swashes-expected.png) (Binary files differ) Property changes: trunk/LayoutTests/platform/chromium/fast/text/line-initial-and-final-swashes-expected.png Added: svn:mime-type Deleted: trunk/LayoutTests/platform/chromium-mac/fast/text/line-initial-and-final-swashes-expected.png (Binary files differ) ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [138133] trunk/Tools
Title: [138133] trunk/Tools
Revision 138133
Author carlo...@webkit.org
Date 2012-12-19 02:18:15 -0800 (Wed, 19 Dec 2012)
Log Message
[GTK] Tests that time out are not considered as failures.
https://bugs.webkit.org/show_bug.cgi?id=105318
Patch by Alberto Garcia agar...@igalia.com on 2012-12-19
Reviewed by Martin Robinson.
Fix parsing of the GTK API tests log files.
* BuildSlaveSupport/build.webkit.org-config/master.cfg:
(RunGtkAPITests.commandComplete):
Modified Paths
trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg
trunk/Tools/ChangeLog
Diff
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg (138132 => 138133)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg 2012-12-19 10:10:14 UTC (rev 138132)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg 2012-12-19 10:18:15 UTC (rev 138133)
@@ -542,7 +542,7 @@
logText = cmd.logs['stdio'].getText()
incorrectLines = []
for line in logText.splitlines():
-if line.startswith('ERROR') or line.endswith('TIMEOUT\n'):
+if line.startswith('ERROR') or line.endswith('TIMEOUT'):
incorrectLines.append(line)
self.incorrectLines = incorrectLines
Modified: trunk/Tools/ChangeLog (138132 => 138133)
--- trunk/Tools/ChangeLog 2012-12-19 10:10:14 UTC (rev 138132)
+++ trunk/Tools/ChangeLog 2012-12-19 10:18:15 UTC (rev 138133)
@@ -1,3 +1,15 @@
+2012-12-19 Alberto Garcia agar...@igalia.com
+
+[GTK] Tests that time out are not considered as failures.
+https://bugs.webkit.org/show_bug.cgi?id=105318
+
+Reviewed by Martin Robinson.
+
+Fix parsing of the GTK API tests log files.
+
+* BuildSlaveSupport/build.webkit.org-config/master.cfg:
+(RunGtkAPITests.commandComplete):
+
2012-12-18 Ilya Tikhonovsky loi...@chromium.org
Unreviewed, rolling out r138061.
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [138135] trunk/Source/WebCore
Title: [138135] trunk/Source/WebCore
Revision 138135
Author commit-qu...@webkit.org
Date 2012-12-19 02:39:17 -0800 (Wed, 19 Dec 2012)
Log Message
Pass debuggerTaskMode as a parameter in WorkerScriptDebugServer constructor
https://bugs.webkit.org/show_bug.cgi?id=105085
Patch by Seokju Kwon seokju.k...@gmail.com on 2012-12-19
Reviewed by Yury Semikhatsky.
Leave WorkerDebuggerAgent::debuggerTaskMode
and remove WorkerScriptDebugServer::debuggerTaskMode.
No new tests, no behavior change.
* bindings/js/WorkerScriptDebugServer.cpp:
(WebCore::WorkerScriptDebugServer::WorkerScriptDebugServer):
(WebCore::WorkerScriptDebugServer::runEventLoopWhilePaused):
* bindings/js/WorkerScriptDebugServer.h:
(WorkerScriptDebugServer):
* bindings/v8/WorkerScriptDebugServer.cpp:
(WebCore::WorkerScriptDebugServer::WorkerScriptDebugServer):
(WebCore::WorkerScriptDebugServer::runMessageLoopOnPause):
* bindings/v8/WorkerScriptDebugServer.h:
(WorkerScriptDebugServer):
* inspector/WorkerDebuggerAgent.cpp:
(WebCore::WorkerDebuggerAgent::WorkerDebuggerAgent):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/js/WorkerScriptDebugServer.cpp
trunk/Source/WebCore/bindings/js/WorkerScriptDebugServer.h
trunk/Source/WebCore/bindings/v8/WorkerScriptDebugServer.cpp
trunk/Source/WebCore/bindings/v8/WorkerScriptDebugServer.h
trunk/Source/WebCore/inspector/WorkerDebuggerAgent.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (138134 => 138135)
--- trunk/Source/WebCore/ChangeLog 2012-12-19 10:29:41 UTC (rev 138134)
+++ trunk/Source/WebCore/ChangeLog 2012-12-19 10:39:17 UTC (rev 138135)
@@ -1,3 +1,28 @@
+2012-12-19 Seokju Kwon seokju.k...@gmail.com
+
+Pass debuggerTaskMode as a parameter in WorkerScriptDebugServer constructor
+https://bugs.webkit.org/show_bug.cgi?id=105085
+
+Reviewed by Yury Semikhatsky.
+
+Leave WorkerDebuggerAgent::debuggerTaskMode
+and remove WorkerScriptDebugServer::debuggerTaskMode.
+
+No new tests, no behavior change.
+
+* bindings/js/WorkerScriptDebugServer.cpp:
+(WebCore::WorkerScriptDebugServer::WorkerScriptDebugServer):
+(WebCore::WorkerScriptDebugServer::runEventLoopWhilePaused):
+* bindings/js/WorkerScriptDebugServer.h:
+(WorkerScriptDebugServer):
+* bindings/v8/WorkerScriptDebugServer.cpp:
+(WebCore::WorkerScriptDebugServer::WorkerScriptDebugServer):
+(WebCore::WorkerScriptDebugServer::runMessageLoopOnPause):
+* bindings/v8/WorkerScriptDebugServer.h:
+(WorkerScriptDebugServer):
+* inspector/WorkerDebuggerAgent.cpp:
+(WebCore::WorkerDebuggerAgent::WorkerDebuggerAgent):
+
2012-12-19 Ilya Tikhonovsky loi...@chromium.org
Unreviewed, rolling out r138129.
Modified: trunk/Source/WebCore/bindings/js/WorkerScriptDebugServer.cpp (138134 => 138135)
--- trunk/Source/WebCore/bindings/js/WorkerScriptDebugServer.cpp 2012-12-19 10:29:41 UTC (rev 138134)
+++ trunk/Source/WebCore/bindings/js/WorkerScriptDebugServer.cpp 2012-12-19 10:39:17 UTC (rev 138135)
@@ -42,11 +42,10 @@
namespace WebCore {
-const char* WorkerScriptDebugServer::debuggerTaskMode = debugger;
-
-WorkerScriptDebugServer::WorkerScriptDebugServer(WorkerContext* context)
+WorkerScriptDebugServer::WorkerScriptDebugServer(WorkerContext* context, const String mode)
: ScriptDebugServer()
, m_workerContext(context)
+, m_debuggerTaskMode(mode)
{
}
@@ -93,7 +92,7 @@
{
MessageQueueWaitResult result;
do {
-result = m_workerContext-thread()-runLoop().runInMode(m_workerContext, WorkerDebuggerAgent::debuggerTaskMode);
+result = m_workerContext-thread()-runLoop().runInMode(m_workerContext, m_debuggerTaskMode);
// Keep waiting until execution is resumed.
} while (result != MessageQueueTerminated !m_doneProcessingDebuggerEvents);
}
Modified: trunk/Source/WebCore/bindings/js/WorkerScriptDebugServer.h (138134 => 138135)
--- trunk/Source/WebCore/bindings/js/WorkerScriptDebugServer.h 2012-12-19 10:29:41 UTC (rev 138134)
+++ trunk/Source/WebCore/bindings/js/WorkerScriptDebugServer.h 2012-12-19 10:39:17 UTC (rev 138135)
@@ -42,14 +42,12 @@
class WorkerScriptDebugServer : public ScriptDebugServer {
WTF_MAKE_NONCOPYABLE(WorkerScriptDebugServer);
public:
-explicit WorkerScriptDebugServer(WorkerContext*);
+WorkerScriptDebugServer(WorkerContext*, const String);
~WorkerScriptDebugServer() { }
void addListener(ScriptDebugListener*);
void removeListener(ScriptDebugListener*);
-static const char* debuggerTaskMode;
-
void interruptAndRunTask(PassOwnPtrScriptDebugServer::Task);
void recompileAllJSFunctions(TimerScriptDebugServer*);
@@ -67,6 +65,7 @@
WorkerContext* m_workerContext;
ListenerSet m_listeners;
+String m_debuggerTaskMode;
};
} // namespace WebCore
Modified: trunk/Source/WebCore/bindings/v8/WorkerScriptDebugServer.cpp (138134 => 138135)
---
[webkit-changes] [138136] trunk/Tools
Title: [138136] trunk/Tools
Revision 138136
Author zeno.albis...@digia.com
Date 2012-12-19 02:46:03 -0800 (Wed, 19 Dec 2012)
Log Message
[Qt][Mac] run-launcher cannot find Qt5WebKitWidgets.
https://bugs.webkit.org/show_bug.cgi?id=105309
The version number is only used as a part
of the library name on Linux.
Reviewed by Kenneth Rohde Christiansen.
* Scripts/webkitdirs.pm:
(builtDylibPathForName):
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitdirs.pm
Diff
Modified: trunk/Tools/ChangeLog (138135 => 138136)
--- trunk/Tools/ChangeLog 2012-12-19 10:39:17 UTC (rev 138135)
+++ trunk/Tools/ChangeLog 2012-12-19 10:46:03 UTC (rev 138136)
@@ -1,3 +1,16 @@
+2012-12-19 Zeno Albisser z...@webkit.org
+
+[Qt][Mac] run-launcher cannot find Qt5WebKitWidgets.
+https://bugs.webkit.org/show_bug.cgi?id=105309
+
+The version number is only used as a part
+of the library name on Linux.
+
+Reviewed by Kenneth Rohde Christiansen.
+
+* Scripts/webkitdirs.pm:
+(builtDylibPathForName):
+
2012-12-19 Alberto Garcia agar...@igalia.com
[GTK] Tests that time out are not considered as failures.
Modified: trunk/Tools/Scripts/webkitdirs.pm (138135 => 138136)
--- trunk/Tools/Scripts/webkitdirs.pm 2012-12-19 10:39:17 UTC (rev 138135)
+++ trunk/Tools/Scripts/webkitdirs.pm 2012-12-19 10:46:03 UTC (rev 138136)
@@ -723,7 +723,11 @@
}
if (isQt()) {
my $isSearchingForWebCore = $libraryName =~ WebCore;
-$libraryName = Qt5WebKitWidgets;
+if (isDarwin() || isWindows()) {
+$libraryName = QtWebKitWidgets;
+} else {
+$libraryName = Qt5WebKitWidgets;
+}
my $result;
if (isDarwin() and -d $configurationProductDir/lib/$libraryName.framework) {
$result = $configurationProductDir/lib/$libraryName.framework/$libraryName;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [138137] trunk/LayoutTests
Title: [138137] trunk/LayoutTests Revision 138137 Author commit-qu...@webkit.org Date 2012-12-19 02:48:06 -0800 (Wed, 19 Dec 2012) Log Message [EFL] Mark XHR tests flaky (unreliable console logging) https://bugs.webkit.org/show_bug.cgi?id=105403 Unreviewed gardening: mark a bunch of xmlhttprequest tests flaky. Patch by Jussi Kukkonen jussi.kukko...@intel.com on 2012-12-19 * platform/efl/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/efl/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (138136 => 138137) --- trunk/LayoutTests/ChangeLog 2012-12-19 10:46:03 UTC (rev 138136) +++ trunk/LayoutTests/ChangeLog 2012-12-19 10:48:06 UTC (rev 138137) @@ -1,3 +1,12 @@ +2012-12-19 Jussi Kukkonen jussi.kukko...@intel.com + +[EFL] Mark XHR tests flaky (unreliable console logging) +https://bugs.webkit.org/show_bug.cgi?id=105403 + +Unreviewed gardening: mark a bunch of xmlhttprequest tests flaky. + +* platform/efl/TestExpectations: + 2012-12-19 János Badics jbad...@inf.u-szeged.hu [Qt] Gardening after r138095, skip a newly added, but failing test. Modified: trunk/LayoutTests/platform/efl/TestExpectations (138136 => 138137) --- trunk/LayoutTests/platform/efl/TestExpectations 2012-12-19 10:46:03 UTC (rev 138136) +++ trunk/LayoutTests/platform/efl/TestExpectations 2012-12-19 10:48:06 UTC (rev 138137) @@ -751,6 +751,15 @@ webkit.org/b/103880 fast/writing-mode/vertical-font-vmtx-units-per-em.html [ Failure Pass ] +# flaky console output problem +webkit.org/b/105280 http/tests/xmlhttprequest/origin-whitelisting-https.html [ Failure Pass ] +webkit.org/b/105280 http/tests/xmlhttprequest/access-control-preflight-async-header-denied.html [ Failure Pass ] +webkit.org/b/105280 http/tests/xmlhttprequest/simple-cross-origin-denied-events.html [ Failure Pass ] +webkit.org/b/105280 http/tests/xmlhttprequest/access-control-preflight-async-method-denied.html [ Failure Pass ] +webkit.org/b/105280 http/tests/xmlhttprequest/cross-site-denied-response.html [ Failure Pass ] +webkit.org/b/105280 http/tests/xmlhttprequest/simple-cross-origin-denied-events-post.html [ Failure Pass ] +webkit.org/b/105280 http/tests/xmlhttprequest/access-control-preflight-async-not-supported.html [ Failure Pass ] + # # FAILING TESTS # ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [138138] trunk
Title: [138138] trunk Revision 138138 Author commit-qu...@webkit.org Date 2012-12-19 02:50:36 -0800 (Wed, 19 Dec 2012) Log Message [JSC] Add support for overloaded constructors https://bugs.webkit.org/show_bug.cgi?id=103226 Patch by Tommy Widenflycht tom...@chromium.org on 2012-12-19 Reviewed by Kentaro Hara. Source/WebCore: This patch adds the same support for overloaded constructors to JSC as V8. As proof of implementation soundness WebSockets custom constructor is removed. Existing tests cover patch. As they should. * GNUmakefile.list.am: * Modules/websockets/WebSocket.idl: * Target.pri: * UseJSC.cmake: * WebCore.vcproj/WebCore.vcproj: * WebCore.xcodeproj/project.pbxproj: * bindings/js/JSBindingsAllInOne.cpp: * bindings/js/JSWebSocketCustom.cpp: Removed. * bindings/scripts/CodeGeneratorJS.pm: (GenerateConstructorDeclaration): (GenerateConstructorDefinitions): (GenerateOverloadedConstructorDefinition): (GenerateConstructorDefinition): (GenerateConstructorHelperMethods): * bindings/scripts/test/JS/JSTestOverloadedConstructors.cpp: (WebCore::JSTestOverloadedConstructorsConstructor::constructJSTestOverloadedConstructors1): (WebCore): (WebCore::JSTestOverloadedConstructorsConstructor::constructJSTestOverloadedConstructors2): (WebCore::JSTestOverloadedConstructorsConstructor::constructJSTestOverloadedConstructors3): (WebCore::JSTestOverloadedConstructorsConstructor::constructJSTestOverloadedConstructors4): (WebCore::JSTestOverloadedConstructorsConstructor::constructJSTestOverloadedConstructors): * bindings/scripts/test/JS/JSTestOverloadedConstructors.h: (JSTestOverloadedConstructorsConstructor): LayoutTests: * http/tests/websocket/tests/hybi/url-parsing-expected.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/http/tests/websocket/tests/hybi/url-parsing-expected.txt trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/GNUmakefile.list.am trunk/Source/WebCore/Modules/websockets/WebSocket.idl trunk/Source/WebCore/Target.pri trunk/Source/WebCore/UseJSC.cmake trunk/Source/WebCore/WebCore.vcproj/WebCore.vcproj trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj trunk/Source/WebCore/bindings/js/JSBindingsAllInOne.cpp trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm trunk/Source/WebCore/bindings/scripts/test/JS/JSTestOverloadedConstructors.cpp trunk/Source/WebCore/bindings/scripts/test/JS/JSTestOverloadedConstructors.h Removed Paths trunk/Source/WebCore/bindings/js/JSWebSocketCustom.cpp Diff Modified: trunk/LayoutTests/ChangeLog (138137 => 138138) --- trunk/LayoutTests/ChangeLog 2012-12-19 10:48:06 UTC (rev 138137) +++ trunk/LayoutTests/ChangeLog 2012-12-19 10:50:36 UTC (rev 138138) @@ -1,3 +1,12 @@ +2012-12-19 Tommy Widenflycht tom...@chromium.org + +[JSC] Add support for overloaded constructors +https://bugs.webkit.org/show_bug.cgi?id=103226 + +Reviewed by Kentaro Hara. + +* http/tests/websocket/tests/hybi/url-parsing-expected.txt: + 2012-12-19 Jussi Kukkonen jussi.kukko...@intel.com [EFL] Mark XHR tests flaky (unreliable console logging) Modified: trunk/LayoutTests/http/tests/websocket/tests/hybi/url-parsing-expected.txt (138137 => 138138) --- trunk/LayoutTests/http/tests/websocket/tests/hybi/url-parsing-expected.txt 2012-12-19 10:48:06 UTC (rev 138137) +++ trunk/LayoutTests/http/tests/websocket/tests/hybi/url-parsing-expected.txt 2012-12-19 10:50:36 UTC (rev 138138) @@ -1,6 +1,6 @@ -CONSOLE MESSAGE: Invalid url for WebSocket null +CONSOLE MESSAGE: Wrong url scheme for WebSocket http://127.0.0.1:8000/websocket/tests/hybi/null CONSOLE MESSAGE: Invalid url for WebSocket ws://_javascript_:a -CONSOLE MESSAGE: Invalid url for WebSocket /applet +CONSOLE MESSAGE: Wrong url scheme for WebSocket http://127.0.0.1:8000/applet CONSOLE MESSAGE: Wrong url scheme for WebSocket _javascript_:a CONSOLE MESSAGE: WebSocket port 25 blocked CONSOLE MESSAGE: URL has fragment component ws://127.0.0.1/path# Modified: trunk/Source/WebCore/ChangeLog (138137 => 138138) --- trunk/Source/WebCore/ChangeLog 2012-12-19 10:48:06 UTC (rev 138137) +++ trunk/Source/WebCore/ChangeLog 2012-12-19 10:50:36 UTC (rev 138138) @@ -1,3 +1,39 @@ +2012-12-19 Tommy Widenflycht tom...@chromium.org + +[JSC] Add support for overloaded constructors +https://bugs.webkit.org/show_bug.cgi?id=103226 + +Reviewed by Kentaro Hara. + +This patch adds the same support for overloaded constructors to JSC as V8. +As proof of implementation soundness WebSockets custom constructor is removed. + +Existing tests cover patch. As they should. + +* GNUmakefile.list.am: +* Modules/websockets/WebSocket.idl: +* Target.pri: +* UseJSC.cmake: +* WebCore.vcproj/WebCore.vcproj: +* WebCore.xcodeproj/project.pbxproj: +* bindings/js/JSBindingsAllInOne.cpp: +* bindings/js/JSWebSocketCustom.cpp: Removed. +* bindings/scripts/CodeGeneratorJS.pm: +
[webkit-changes] [138139] trunk/LayoutTests
Title: [138139] trunk/LayoutTests Revision 138139 Author dominik.rottsc...@intel.com Date 2012-12-19 02:56:01 -0800 (Wed, 19 Dec 2012) Log Message [EFL] Unreviewed gardening. Adding failing touch events case, details in bug 105406. * platform/efl/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/efl/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (138138 => 138139) --- trunk/LayoutTests/ChangeLog 2012-12-19 10:50:36 UTC (rev 138138) +++ trunk/LayoutTests/ChangeLog 2012-12-19 10:56:01 UTC (rev 138139) @@ -1,3 +1,11 @@ +2012-12-19 Dominik Röttsches dominik.rottsc...@intel.com + +[EFL] Unreviewed gardening. + +Adding failing touch events case, details in bug 105406. + +* platform/efl/TestExpectations: + 2012-12-19 Tommy Widenflycht tom...@chromium.org [JSC] Add support for overloaded constructors Modified: trunk/LayoutTests/platform/efl/TestExpectations (138138 => 138139) --- trunk/LayoutTests/platform/efl/TestExpectations 2012-12-19 10:50:36 UTC (rev 138138) +++ trunk/LayoutTests/platform/efl/TestExpectations 2012-12-19 10:56:01 UTC (rev 138139) @@ -1726,3 +1726,6 @@ # Note webkit.org/b/104506, random crashes webkit.org/b/105029 fast/canvas/webgl/webgl-composite-modes.html [ ImageOnlyFailure Crash ] webkit.org/b/105029 fast/canvas/webgl/webgl-composite-modes-repaint.html [ ImageOnlyFailure Crash ] + +# Failing touch events case +webkit.org/b/105406 fast/events/touch/touch-input-element-change-documents.html [ Failure ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [138140] trunk/Source/WebCore
Title: [138140] trunk/Source/WebCore Revision 138140 Author commit-qu...@webkit.org Date 2012-12-19 03:35:05 -0800 (Wed, 19 Dec 2012) Log Message [EFL][WebGL] Refactor GLXSurface. https://bugs.webkit.org/show_bug.cgi?id=105357 Patch by Kondapally Kalyan kalyan.kondapa...@intel.com on 2012-12-19 Reviewed by Kenneth Rohde Christiansen. This is in preparation for adding EGL support. There is lot of X related code which could be shared between our current GLX implementation and EGL. This patch makes it possible to share the common code but doesn't change any functionality. * PlatformEfl.cmake: * platform/graphics/surfaces/glx/GLXSurface.cpp: (WebCore): (WebCore::GLXTransportSurface::GLXTransportSurface): (WebCore::GLXTransportSurface::configuration): (WebCore::GLXTransportSurface::destroy): (WebCore::GLXTransportSurface::freeResources): (WebCore::GLXPBuffer::GLXPBuffer): (WebCore::GLXPBuffer::initialize): (WebCore::GLXPBuffer::configuration): (WebCore::GLXPBuffer::setGeometry): * platform/graphics/surfaces/glx/GLXSurface.h: (GLXTransportSurface): (GLXPBuffer): GLX related implementation. * platform/graphics/surfaces/glx/GLXWindowResources.h: Added. (WebCore): (SharedGLXResources): (WebCore::SharedGLXResources::create): (WebCore::SharedGLXResources::nativeDisplay): (WebCore::SharedGLXResources::pBufferContextConfig): (WebCore::SharedGLXResources::surfaceContextConfig): (WebCore::SharedGLXResources::SharedGLXResources): (WebCore::SharedGLXResources::createConfig): Moving X related code to a seperate class. * platform/graphics/surfaces/glx/X11WindowResources.cpp: Added. (WebCore): (WebCore::X11OffScreenWindow::X11OffScreenWindow): (WebCore::X11OffScreenWindow::~X11OffScreenWindow): (WebCore::X11OffScreenWindow::setGeometry): (WebCore::X11OffScreenWindow::createOffscreenWindow): * platform/graphics/surfaces/glx/X11WindowResources.h: Added. (WebCore): (SharedX11Resources): (WebCore::SharedX11Resources::deref): (WebCore::SharedX11Resources::x11Display): (WebCore::SharedX11Resources::getXWindow): (WebCore::SharedX11Resources::visualInfo): (WebCore::SharedX11Resources::isXRenderExtensionSupported): (WebCore::SharedX11Resources::SharedX11Resources): (WebCore::SharedX11Resources::~SharedX11Resources): (X11OffScreenWindow): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/PlatformEfl.cmake trunk/Source/WebCore/platform/graphics/surfaces/glx/GLXSurface.cpp trunk/Source/WebCore/platform/graphics/surfaces/glx/GLXSurface.h Added Paths trunk/Source/WebCore/platform/graphics/surfaces/glx/GLXWindowResources.h trunk/Source/WebCore/platform/graphics/surfaces/glx/X11WindowResources.cpp trunk/Source/WebCore/platform/graphics/surfaces/glx/X11WindowResources.h Diff Modified: trunk/Source/WebCore/ChangeLog (138139 => 138140) --- trunk/Source/WebCore/ChangeLog 2012-12-19 10:56:01 UTC (rev 138139) +++ trunk/Source/WebCore/ChangeLog 2012-12-19 11:35:05 UTC (rev 138140) @@ -1,3 +1,59 @@ +2012-12-19 Kondapally Kalyan kalyan.kondapa...@intel.com + +[EFL][WebGL] Refactor GLXSurface. +https://bugs.webkit.org/show_bug.cgi?id=105357 + +Reviewed by Kenneth Rohde Christiansen. + +This is in preparation for adding EGL support. +There is lot of X related code which could be shared between our current GLX implementation +and EGL. This patch makes it possible to share the common code but doesn't change any functionality. + +* PlatformEfl.cmake: +* platform/graphics/surfaces/glx/GLXSurface.cpp: +(WebCore): +(WebCore::GLXTransportSurface::GLXTransportSurface): +(WebCore::GLXTransportSurface::configuration): +(WebCore::GLXTransportSurface::destroy): +(WebCore::GLXTransportSurface::freeResources): +(WebCore::GLXPBuffer::GLXPBuffer): +(WebCore::GLXPBuffer::initialize): +(WebCore::GLXPBuffer::configuration): +(WebCore::GLXPBuffer::setGeometry): +* platform/graphics/surfaces/glx/GLXSurface.h: +(GLXTransportSurface): +(GLXPBuffer): + +GLX related implementation. +* platform/graphics/surfaces/glx/GLXWindowResources.h: Added. +(WebCore): +(SharedGLXResources): +(WebCore::SharedGLXResources::create): +(WebCore::SharedGLXResources::nativeDisplay): +(WebCore::SharedGLXResources::pBufferContextConfig): +(WebCore::SharedGLXResources::surfaceContextConfig): +(WebCore::SharedGLXResources::SharedGLXResources): +(WebCore::SharedGLXResources::createConfig): + +Moving X related code to a seperate class. +* platform/graphics/surfaces/glx/X11WindowResources.cpp: Added. +(WebCore): +(WebCore::X11OffScreenWindow::X11OffScreenWindow): +(WebCore::X11OffScreenWindow::~X11OffScreenWindow): +(WebCore::X11OffScreenWindow::setGeometry): +(WebCore::X11OffScreenWindow::createOffscreenWindow): +*
[webkit-changes] [138141] trunk
Title: [138141] trunk
Revision 138141
Author r...@webkit.org
Date 2012-12-19 03:56:08 -0800 (Wed, 19 Dec 2012)
Log Message
CSSParser crases, when no context is available, and the value is a valid keyword
https://bugs.webkit.org/show_bug.cgi?id=105275
Reviewed by Tony Chang.
ParserContext could be null even if the keyword is valid. We have to check it.
Source/WebCore:
Test: fast/css/invalid-parsercontext-valid-keyword-crash.svg
* css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):
LayoutTests:
* fast/css/invalid-parsercontext-valid-keyword-crash-expected.txt: Added.
* fast/css/invalid-parsercontext-valid-keyword-crash.svg: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/CSSParser.cpp
Added Paths
trunk/LayoutTests/fast/css/invalid-parsercontext-valid-keyword-crash-expected.txt
trunk/LayoutTests/fast/css/invalid-parsercontext-valid-keyword-crash.svg
Diff
Modified: trunk/LayoutTests/ChangeLog (138140 => 138141)
--- trunk/LayoutTests/ChangeLog 2012-12-19 11:35:05 UTC (rev 138140)
+++ trunk/LayoutTests/ChangeLog 2012-12-19 11:56:08 UTC (rev 138141)
@@ -1,3 +1,15 @@
+2012-12-19 Renata Hodovan r...@webkit.org
+
+CSSParser crases, when no context is available, and the value is a valid keyword
+https://bugs.webkit.org/show_bug.cgi?id=105275
+
+Reviewed by Tony Chang.
+
+ParserContext could be null even if the keyword is valid. We have to check it.
+
+* fast/css/invalid-parsercontext-valid-keyword-crash-expected.txt: Added.
+* fast/css/invalid-parsercontext-valid-keyword-crash.svg: Added.
+
2012-12-19 Dominik Röttsches dominik.rottsc...@intel.com
[EFL] Unreviewed gardening.
Added: trunk/LayoutTests/fast/css/invalid-parsercontext-valid-keyword-crash-expected.txt (0 => 138141)
--- trunk/LayoutTests/fast/css/invalid-parsercontext-valid-keyword-crash-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/css/invalid-parsercontext-valid-keyword-crash-expected.txt 2012-12-19 11:56:08 UTC (rev 138141)
@@ -0,0 +1 @@
+Excellent - did not crash. See bug https://bugs.webkit.org/show_bug.cgi?id=105275
Added: trunk/LayoutTests/fast/css/invalid-parsercontext-valid-keyword-crash.svg (0 => 138141)
--- trunk/LayoutTests/fast/css/invalid-parsercontext-valid-keyword-crash.svg (rev 0)
+++ trunk/LayoutTests/fast/css/invalid-parsercontext-valid-keyword-crash.svg 2012-12-19 11:56:08 UTC (rev 138141)
@@ -0,0 +1,13 @@
+svg xmlns=http://www.w3.org/2000/svg
+!-- This test passes if there is no crash. --
+rect
+ animate attributeName=display to=bevel/animate
+/rect
+
+text x=10 y=20Excellent - did not crash. See bug https://bugs.webkit.org/show_bug.cgi?id=105275/text
+script
+if (window.testRunner)
+testRunner.dumpAsText();
+/script
+/svg
+
Modified: trunk/Source/WebCore/ChangeLog (138140 => 138141)
--- trunk/Source/WebCore/ChangeLog 2012-12-19 11:35:05 UTC (rev 138140)
+++ trunk/Source/WebCore/ChangeLog 2012-12-19 11:56:08 UTC (rev 138141)
@@ -1,3 +1,17 @@
+2012-12-19 Renata Hodovan r...@webkit.org
+
+CSSParser crases, when no context is available, and the value is a valid keyword
+https://bugs.webkit.org/show_bug.cgi?id=105275
+
+Reviewed by Tony Chang.
+
+ParserContext could be null even if the keyword is valid. We have to check it.
+
+Test: fast/css/invalid-parsercontext-valid-keyword-crash.svg
+
+* css/CSSParser.cpp:
+(WebCore::CSSParser::parseValue):
+
2012-12-19 Kondapally Kalyan kalyan.kondapa...@intel.com
[EFL][WebGL] Refactor GLXSurface.
Modified: trunk/Source/WebCore/css/CSSParser.cpp (138140 => 138141)
--- trunk/Source/WebCore/css/CSSParser.cpp 2012-12-19 11:35:05 UTC (rev 138140)
+++ trunk/Source/WebCore/css/CSSParser.cpp 2012-12-19 11:56:08 UTC (rev 138141)
@@ -1229,16 +1229,18 @@
return true;
if (parseColorValue(declaration, propertyID, string, important, cssParserMode))
return true;
-if (parseKeywordValue(declaration, propertyID, string, important, contextStyleSheet-parserContext()))
-return true;
-if (parseTranslateTransformValue(declaration, propertyID, string, important))
-return true;
CSSParserContext context(cssParserMode);
if (contextStyleSheet) {
context = contextStyleSheet-parserContext();
context.mode = cssParserMode;
}
+
+if (parseKeywordValue(declaration, propertyID, string, important, context))
+return true;
+if (parseTranslateTransformValue(declaration, propertyID, string, important))
+return true;
+
CSSParser parser(context);
return parser.parseValue(declaration, propertyID, string, important, contextStyleSheet);
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [138142] trunk/Source/WebKit2
Title: [138142] trunk/Source/WebKit2
Revision 138142
Author zeno.albis...@digia.com
Date 2012-12-19 04:49:16 -0800 (Wed, 19 Dec 2012)
Log Message
[Qt] Missing vtable for LoadStartedCatcher.
https://bugs.webkit.org/show_bug.cgi?id=105313
Properly splitting class declarations and function
definitions into headers/cpp-files.
This makes including util.moc redundant
and avoids the well known vtable issues with QObject classes.
Reviewed by Simon Hausmann.
* UIProcess/API/qt/tests/util.cpp:
(LoadSpy::LoadSpy):
(LoadSpy::onLoadingChanged):
* UIProcess/API/qt/tests/util.h:
(LoadSpy):
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/qt/tests/util.cpp
trunk/Source/WebKit2/UIProcess/API/qt/tests/util.h
Diff
Modified: trunk/Source/WebKit2/ChangeLog (138141 => 138142)
--- trunk/Source/WebKit2/ChangeLog 2012-12-19 11:56:08 UTC (rev 138141)
+++ trunk/Source/WebKit2/ChangeLog 2012-12-19 12:49:16 UTC (rev 138142)
@@ -1,3 +1,21 @@
+2012-12-19 Zeno Albisser z...@webkit.org
+
+[Qt] Missing vtable for LoadStartedCatcher.
+https://bugs.webkit.org/show_bug.cgi?id=105313
+
+Properly splitting class declarations and function
+definitions into headers/cpp-files.
+This makes including util.moc redundant
+and avoids the well known vtable issues with QObject classes.
+
+Reviewed by Simon Hausmann.
+
+* UIProcess/API/qt/tests/util.cpp:
+(LoadSpy::LoadSpy):
+(LoadSpy::onLoadingChanged):
+* UIProcess/API/qt/tests/util.h:
+(LoadSpy):
+
2012-12-19 KyungTae Kim ktf@samsung.com
Unused parameters on WebContext.cpp
Modified: trunk/Source/WebKit2/UIProcess/API/qt/tests/util.cpp (138141 => 138142)
--- trunk/Source/WebKit2/UIProcess/API/qt/tests/util.cpp 2012-12-19 11:56:08 UTC (rev 138141)
+++ trunk/Source/WebKit2/UIProcess/API/qt/tests/util.cpp 2012-12-19 12:49:16 UTC (rev 138142)
@@ -74,26 +74,6 @@
}
#if defined(HAVE_QTQUICK) HAVE_QTQUICK
-class LoadSpy : public QEventLoop {
-Q_OBJECT
-public:
-LoadSpy(QQuickWebView* webView)
-{
-connect(webView, SIGNAL(loadingChanged(QWebLoadRequest*)), SLOT(onLoadingChanged(QWebLoadRequest*)));
-}
-Q_SIGNALS:
-void loadSucceeded();
-void loadFailed();
-private Q_SLOTS:
-void onLoadingChanged(QWebLoadRequest* loadRequest)
-{
-if (loadRequest-status() == QQuickWebView::LoadSucceededStatus)
-emit loadSucceeded();
-else if (loadRequest-status() == QQuickWebView::LoadFailedStatus)
-emit loadFailed();
-}
-};
-
bool waitForLoadSucceeded(QQuickWebView* webView, int timeout)
{
QEventLoop loop;
@@ -133,6 +113,19 @@
return waitForSignal(webView-experimental(), SIGNAL(loadVisuallyCommitted()), timeout);
}
+LoadSpy::LoadSpy(QQuickWebView* webView)
+{
+connect(webView, SIGNAL(loadingChanged(QWebLoadRequest*)), SLOT(onLoadingChanged(QWebLoadRequest*)));
+}
+
+void LoadSpy::onLoadingChanged(QWebLoadRequest* loadRequest)
+{
+if (loadRequest-status() == QQuickWebView::LoadSucceededStatus)
+emit loadSucceeded();
+else if (loadRequest-status() == QQuickWebView::LoadFailedStatus)
+emit loadFailed();
+}
+
LoadStartedCatcher::LoadStartedCatcher(QQuickWebView* webView)
: m_webView(webView)
{
@@ -148,5 +141,3 @@
}
}
#endif
-
-#include util.moc
Modified: trunk/Source/WebKit2/UIProcess/API/qt/tests/util.h (138141 => 138142)
--- trunk/Source/WebKit2/UIProcess/API/qt/tests/util.h 2012-12-19 11:56:08 UTC (rev 138141)
+++ trunk/Source/WebKit2/UIProcess/API/qt/tests/util.h 2012-12-19 12:49:16 UTC (rev 138142)
@@ -38,6 +38,17 @@
bool waitForLoadFailed(QQuickWebView* webView, int timeout = 1);
bool waitForViewportReady(QQuickWebView* webView, int timeout = 1);
+class LoadSpy : public QEventLoop {
+Q_OBJECT
+public:
+LoadSpy(QQuickWebView* webView);
+Q_SIGNALS:
+void loadSucceeded();
+void loadFailed();
+private Q_SLOTS:
+void onLoadingChanged(QWebLoadRequest* loadRequest);
+};
+
class LoadStartedCatcher : public QObject {
Q_OBJECT
public:
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [138143] trunk/LayoutTests
Title: [138143] trunk/LayoutTests Revision 138143 Author o...@webkit.org Date 2012-12-19 05:00:54 -0800 (Wed, 19 Dec 2012) Log Message Unreviewed gardening, skip flakey tests. * platform/qt-5.0-wk2/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/qt-5.0-wk2/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (138142 => 138143) --- trunk/LayoutTests/ChangeLog 2012-12-19 12:49:16 UTC (rev 138142) +++ trunk/LayoutTests/ChangeLog 2012-12-19 13:00:54 UTC (rev 138143) @@ -1,3 +1,9 @@ +2012-12-19 Csaba Osztrogonác o...@webkit.org + +Unreviewed gardening, skip flakey tests. + +* platform/qt-5.0-wk2/TestExpectations: + 2012-12-19 Renata Hodovan r...@webkit.org CSSParser crases, when no context is available, and the value is a valid keyword Modified: trunk/LayoutTests/platform/qt-5.0-wk2/TestExpectations (138142 => 138143) --- trunk/LayoutTests/platform/qt-5.0-wk2/TestExpectations 2012-12-19 12:49:16 UTC (rev 138142) +++ trunk/LayoutTests/platform/qt-5.0-wk2/TestExpectations 2012-12-19 13:00:54 UTC (rev 138143) @@ -766,3 +766,9 @@ # [Qt][WK2] The new compositing/repaint/resize-repaint.html fails webkit.org/b/105182 compositing/repaint/resize-repaint.html + +# [Qt][WK2] svg/text/select-* tests are so flakey +# https://bugs.webkit.org/show_bug.cgi?id=105417 +svg/text/select-textLength-spacing-stretch-1.svg +svg/text/select-x-list-with-tspans-1.svg +svg/text/select-x-list-1.svg ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [138144] trunk/Source/WebCore
Title: [138144] trunk/Source/WebCore
Revision 138144
Author apav...@chromium.org
Date 2012-12-19 05:02:17 -0800 (Wed, 19 Dec 2012)
Log Message
Web Inspector: [REGRESSION] The last remembered tab is not restored when the Settings dialog is opened
https://bugs.webkit.org/show_bug.cgi?id=105414
Reviewed by Vsevolod Vlasov.
Do not force the General tab when opening settings upon the Cog button click.
* inspector/front-end/SettingsScreen.js:
(WebInspector.SettingsController.prototype._mouseUp):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/SettingsScreen.js
Diff
Modified: trunk/Source/WebCore/ChangeLog (138143 => 138144)
--- trunk/Source/WebCore/ChangeLog 2012-12-19 13:00:54 UTC (rev 138143)
+++ trunk/Source/WebCore/ChangeLog 2012-12-19 13:02:17 UTC (rev 138144)
@@ -1,3 +1,15 @@
+2012-12-19 Alexander Pavlov apav...@chromium.org
+
+Web Inspector: [REGRESSION] The last remembered tab is not restored when the Settings dialog is opened
+https://bugs.webkit.org/show_bug.cgi?id=105414
+
+Reviewed by Vsevolod Vlasov.
+
+Do not force the General tab when opening settings upon the Cog button click.
+
+* inspector/front-end/SettingsScreen.js:
+(WebInspector.SettingsController.prototype._mouseUp):
+
2012-12-19 Renata Hodovan r...@webkit.org
CSSParser crases, when no context is available, and the value is a valid keyword
Modified: trunk/Source/WebCore/inspector/front-end/SettingsScreen.js (138143 => 138144)
--- trunk/Source/WebCore/inspector/front-end/SettingsScreen.js 2012-12-19 13:00:54 UTC (rev 138143)
+++ trunk/Source/WebCore/inspector/front-end/SettingsScreen.js 2012-12-19 13:02:17 UTC (rev 138144)
@@ -539,7 +539,7 @@
*/
_mouseUp: function(event)
{
-this.showSettingsScreen(WebInspector.SettingsScreen.Tabs.General);
+this.showSettingsScreen();
},
_onHideSettingsScreen: function()
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [138145] trunk/Source/WebCore
Title: [138145] trunk/Source/WebCore
Revision 138145
Author commit-qu...@webkit.org
Date 2012-12-19 05:13:41 -0800 (Wed, 19 Dec 2012)
Log Message
[BlackBerry] Fix undesired re-entrant calls during media error dialog
https://bugs.webkit.org/show_bug.cgi?id=105398
Patch by Max Feil mf...@rim.com on 2012-12-19
Reviewed by Rob Buis.
A recent change in libwebview (PR194379) to the dialog
handling means that dialogs are not truly blocking anymore.
While the dialog is up, a sub-event loop is called. Therefore
the HTML5 media code will continue processing pps messages from
mm-renderer, responding to periodic timers, etc., all while a
media error dialog call higher up in the stack is waiting for
the user to respond. Unfortunately certain places in our code
do not anticipate being called in this re-entrant way.
This patch restores previous behaviour, covered by existing tests.
* platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.cpp:
(WebCore::MediaPlayerPrivate::waitMetadataTimerFired):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (138144 => 138145)
--- trunk/Source/WebCore/ChangeLog 2012-12-19 13:02:17 UTC (rev 138144)
+++ trunk/Source/WebCore/ChangeLog 2012-12-19 13:13:41 UTC (rev 138145)
@@ -1,3 +1,24 @@
+2012-12-19 Max Feil mf...@rim.com
+
+[BlackBerry] Fix undesired re-entrant calls during media error dialog
+https://bugs.webkit.org/show_bug.cgi?id=105398
+
+Reviewed by Rob Buis.
+
+A recent change in libwebview (PR194379) to the dialog
+handling means that dialogs are not truly blocking anymore.
+While the dialog is up, a sub-event loop is called. Therefore
+the HTML5 media code will continue processing pps messages from
+mm-renderer, responding to periodic timers, etc., all while a
+media error dialog call higher up in the stack is waiting for
+the user to respond. Unfortunately certain places in our code
+do not anticipate being called in this re-entrant way.
+
+This patch restores previous behaviour, covered by existing tests.
+
+* platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.cpp:
+(WebCore::MediaPlayerPrivate::waitMetadataTimerFired):
+
2012-12-19 Alexander Pavlov apav...@chromium.org
Web Inspector: [REGRESSION] The last remembered tab is not restored when the Settings dialog is opened
Modified: trunk/Source/WebCore/platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.cpp (138144 => 138145)
--- trunk/Source/WebCore/platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.cpp 2012-12-19 13:02:17 UTC (rev 138144)
+++ trunk/Source/WebCore/platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.cpp 2012-12-19 13:13:41 UTC (rev 138145)
@@ -706,7 +706,11 @@
}
m_waitMetadataPopDialogCounter = 0;
+// Need to prevent re-entrant play here
+m_platformPlayer-setPreventReentrantPlay(true);
int wait = showErrorDialog(PlatformPlayer::MediaMetaDataTimeoutError);
+m_platformPlayer-setPreventReentrantPlay(false);
+
if (!wait)
onPauseNotified();
else {
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [138146] trunk/Source/WebKit2
Title: [138146] trunk/Source/WebKit2
Revision 138146
Author kenn...@webkit.org
Date 2012-12-19 05:22:31 -0800 (Wed, 19 Dec 2012)
Log Message
[EFL][WK2] Move deviceScaleFactor to our view as it's view related
https://bugs.webkit.org/show_bug.cgi?id=105412
Reviewed by Laszlo Gombos.
* UIProcess/API/efl/EwkViewImpl.cpp:
(EwkViewImpl::setDeviceScaleFactor):
(EwkViewImpl::transformFromScene):
* UIProcess/API/efl/EwkViewImpl.h:
(EwkViewImpl):
* UIProcess/API/efl/ewk_view.cpp:
(ewk_view_device_pixel_ratio_set):
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/efl/EwkViewImpl.cpp
trunk/Source/WebKit2/UIProcess/API/efl/EwkViewImpl.h
trunk/Source/WebKit2/UIProcess/API/efl/ewk_view.cpp
Diff
Modified: trunk/Source/WebKit2/ChangeLog (138145 => 138146)
--- trunk/Source/WebKit2/ChangeLog 2012-12-19 13:13:41 UTC (rev 138145)
+++ trunk/Source/WebKit2/ChangeLog 2012-12-19 13:22:31 UTC (rev 138146)
@@ -1,3 +1,18 @@
+2012-12-19 Kenneth Rohde Christiansen kenn...@webkit.org
+
+[EFL][WK2] Move deviceScaleFactor to our view as it's view related
+https://bugs.webkit.org/show_bug.cgi?id=105412
+
+Reviewed by Laszlo Gombos.
+
+* UIProcess/API/efl/EwkViewImpl.cpp:
+(EwkViewImpl::setDeviceScaleFactor):
+(EwkViewImpl::transformFromScene):
+* UIProcess/API/efl/EwkViewImpl.h:
+(EwkViewImpl):
+* UIProcess/API/efl/ewk_view.cpp:
+(ewk_view_device_pixel_ratio_set):
+
2012-12-19 Zeno Albisser z...@webkit.org
[Qt] Missing vtable for LoadStartedCatcher.
Modified: trunk/Source/WebKit2/UIProcess/API/efl/EwkViewImpl.cpp (138145 => 138146)
--- trunk/Source/WebKit2/UIProcess/API/efl/EwkViewImpl.cpp 2012-12-19 13:13:41 UTC (rev 138145)
+++ trunk/Source/WebKit2/UIProcess/API/efl/EwkViewImpl.cpp 2012-12-19 13:22:31 UTC (rev 138146)
@@ -289,11 +289,17 @@
ecore_evas_object_cursor_set(ecoreEvas, cursorObject.release().leakRef(), EVAS_LAYER_MAX, hotspotX, hotspotY);
}
+void EwkViewImpl::setDeviceScaleFactor(float scale)
+{
+page()-setIntrinsicDeviceScaleFactor(scale);
+}
+
AffineTransform EwkViewImpl::transformFromScene() const
{
AffineTransform transform;
#if USE(TILED_BACKING_STORE)
+// Note that the scale factor incl page and device scale for now.
transform.scale(1 / m_scaleFactor);
transform.translate(pagePosition().x(), pagePosition().y());
#endif
Modified: trunk/Source/WebKit2/UIProcess/API/efl/EwkViewImpl.h (138145 => 138146)
--- trunk/Source/WebKit2/UIProcess/API/efl/EwkViewImpl.h 2012-12-19 13:13:41 UTC (rev 138145)
+++ trunk/Source/WebKit2/UIProcess/API/efl/EwkViewImpl.h 2012-12-19 13:22:31 UTC (rev 138146)
@@ -107,8 +107,8 @@
~EwkViewImpl();
static EwkViewImpl* fromEvasObject(const Evas_Object* view);
+Evas_Object* view() { return m_view; }
-Evas_Object* view() { return m_view; }
WKPageRef wkPage();
WebKit::WebPageProxy* page() { return m_pageProxy.get(); }
EwkContext* ewkContext() { return m_context.get(); }
@@ -120,6 +120,8 @@
bool isFocused() const;
bool isVisible() const;
+void setDeviceScaleFactor(float scale);
+
WebCore::AffineTransform transformToScene() const;
WebCore::AffineTransform transformFromScene() const;
WebCore::AffineTransform transformToScreen() const;
Modified: trunk/Source/WebKit2/UIProcess/API/efl/ewk_view.cpp (138145 => 138146)
--- trunk/Source/WebKit2/UIProcess/API/efl/ewk_view.cpp 2012-12-19 13:13:41 UTC (rev 138145)
+++ trunk/Source/WebKit2/UIProcess/API/efl/ewk_view.cpp 2012-12-19 13:22:31 UTC (rev 138146)
@@ -640,7 +640,7 @@
{
EWK_VIEW_IMPL_GET_OR_RETURN(ewkView, impl, false);
-impl-page()-setIntrinsicDeviceScaleFactor(ratio);
+impl-setDeviceScaleFactor(ratio);
return true;
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [138147] trunk/Source/WebKit2
Title: [138147] trunk/Source/WebKit2 Revision 138147 Author commit-qu...@webkit.org Date 2012-12-19 05:32:45 -0800 (Wed, 19 Dec 2012) Log Message [GTK] [WK2] Trailing semicolon in an #include line https://bugs.webkit.org/show_bug.cgi?id=105418 Patch by Alberto Garcia agar...@igalia.com on 2012-12-19 Reviewed by Xan Lopez. * UIProcess/gtk/WebContextGtk.cpp: Remove trailing semicolon in #include line. Modified Paths trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/UIProcess/gtk/WebContextGtk.cpp Diff Modified: trunk/Source/WebKit2/ChangeLog (138146 => 138147) --- trunk/Source/WebKit2/ChangeLog 2012-12-19 13:22:31 UTC (rev 138146) +++ trunk/Source/WebKit2/ChangeLog 2012-12-19 13:32:45 UTC (rev 138147) @@ -1,3 +1,13 @@ +2012-12-19 Alberto Garcia agar...@igalia.com + +[GTK] [WK2] Trailing semicolon in an #include line +https://bugs.webkit.org/show_bug.cgi?id=105418 + +Reviewed by Xan Lopez. + +* UIProcess/gtk/WebContextGtk.cpp: +Remove trailing semicolon in #include line. + 2012-12-19 Kenneth Rohde Christiansen kenn...@webkit.org [EFL][WK2] Move deviceScaleFactor to our view as it's view related Modified: trunk/Source/WebKit2/UIProcess/gtk/WebContextGtk.cpp (138146 => 138147) --- trunk/Source/WebKit2/UIProcess/gtk/WebContextGtk.cpp 2012-12-19 13:22:31 UTC (rev 138146) +++ trunk/Source/WebKit2/UIProcess/gtk/WebContextGtk.cpp 2012-12-19 13:32:45 UTC (rev 138147) @@ -29,7 +29,7 @@ #include WebContext.h #include Logging.h -#include WebCookieManagerProxy.h; +#include WebCookieManagerProxy.h #include WebInspectorServer.h #include WebProcessCreationParameters.h #include WebSoupRequestManagerProxy.h ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [138148] trunk
Title: [138148] trunk Revision 138148 Author commit-qu...@webkit.org Date 2012-12-19 05:38:31 -0800 (Wed, 19 Dec 2012) Log Message INPUT_MULTIPLE_FIELDS_UI: Make year field readonly if min and max have the same year https://bugs.webkit.org/show_bug.cgi?id=105383 Patch by Kunihiko Sakamoto ksakam...@chromium.org on 2012-12-19 Reviewed by Kent Tamura. Source/WebCore: Make year field readonly if min and max have the same year, and it does not have value with different year. Test: fast/forms/date-multiple-fields/date-multiple-fields-readonly-subfield.html * css/html.css: Add CSS rule for the year field. * html/shadow/DateTimeEditElement.cpp: (DateTimeEditBuilder): (WebCore::DateTimeEditBuilder::visitField): Make year-field readonly when appropriate. (WebCore::DateTimeEditBuilder::shouldYearFieldReadOnly): Added. LayoutTests: * fast/forms/date-multiple-fields/date-multiple-fields-readonly-subfield-expected.txt: Added. * fast/forms/date-multiple-fields/date-multiple-fields-readonly-subfield.html: Added. * fast/forms/date-multiple-fields/resources/preserve-value-after-history-back-frame.html: Tweak so year field is focusable. * fast/forms/datetimelocal-multiple-fields/resources/preserve-value-after-history-back-frame.html: Ditto. * fast/forms/month-multiple-fields/resources/preserve-value-after-history-back-frame.html: Ditto. * fast/forms/week-multiple-fields/resources/preserve-value-after-history-back-frame.html: Ditto. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/fast/forms/date-multiple-fields/resources/preserve-value-after-history-back-frame.html trunk/LayoutTests/fast/forms/datetimelocal-multiple-fields/resources/preserve-value-after-history-back-frame.html trunk/LayoutTests/fast/forms/month-multiple-fields/resources/preserve-value-after-history-back-frame.html trunk/LayoutTests/fast/forms/week-multiple-fields/resources/preserve-value-after-history-back-frame.html trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/css/html.css trunk/Source/WebCore/html/shadow/DateTimeEditElement.cpp Added Paths trunk/LayoutTests/fast/forms/date-multiple-fields/date-multiple-fields-readonly-subfield-expected.txt trunk/LayoutTests/fast/forms/date-multiple-fields/date-multiple-fields-readonly-subfield.html Diff Modified: trunk/LayoutTests/ChangeLog (138147 => 138148) --- trunk/LayoutTests/ChangeLog 2012-12-19 13:32:45 UTC (rev 138147) +++ trunk/LayoutTests/ChangeLog 2012-12-19 13:38:31 UTC (rev 138148) @@ -1,3 +1,17 @@ +2012-12-19 Kunihiko Sakamoto ksakam...@chromium.org + +INPUT_MULTIPLE_FIELDS_UI: Make year field readonly if min and max have the same year +https://bugs.webkit.org/show_bug.cgi?id=105383 + +Reviewed by Kent Tamura. + +* fast/forms/date-multiple-fields/date-multiple-fields-readonly-subfield-expected.txt: Added. +* fast/forms/date-multiple-fields/date-multiple-fields-readonly-subfield.html: Added. +* fast/forms/date-multiple-fields/resources/preserve-value-after-history-back-frame.html: Tweak so year field is focusable. +* fast/forms/datetimelocal-multiple-fields/resources/preserve-value-after-history-back-frame.html: Ditto. +* fast/forms/month-multiple-fields/resources/preserve-value-after-history-back-frame.html: Ditto. +* fast/forms/week-multiple-fields/resources/preserve-value-after-history-back-frame.html: Ditto. + 2012-12-19 Csaba Osztrogonác o...@webkit.org Unreviewed gardening, skip flakey tests. Added: trunk/LayoutTests/fast/forms/date-multiple-fields/date-multiple-fields-readonly-subfield-expected.txt (0 => 138148) --- trunk/LayoutTests/fast/forms/date-multiple-fields/date-multiple-fields-readonly-subfield-expected.txt (rev 0) +++ trunk/LayoutTests/fast/forms/date-multiple-fields/date-multiple-fields-readonly-subfield-expected.txt 2012-12-19 13:38:31 UTC (rev 138148) @@ -0,0 +1,20 @@ +Sub-fields in input[type=date] should be read-only in some cases. This requires window.internals. + +On success, you will see a series of PASS messages, followed by TEST COMPLETE. + + +createDateInput argument order: min, max, value + +Year field: +PASS isReadOnlyField(createDateInput(, , ), pseudoYear) is false +PASS isReadOnlyField(createDateInput(2012-12-17, , ), pseudoYear) is false +PASS isReadOnlyField(createDateInput(, 2012-12-17, ), pseudoYear) is false +PASS isReadOnlyField(createDateInput(, , 2012-12-17), pseudoYear) is false +PASS isReadOnlyField(createDateInput(2012-01-01, 2012-12-31, ), pseudoYear) is true +PASS isReadOnlyField(createDateInput(2012-01-01, 2013-12-31, ), pseudoYear) is false +PASS isReadOnlyField(createDateInput(2012-01-01, 2012-12-31, 2012-05-30), pseudoYear) is true +PASS isReadOnlyField(createDateInput(2012-01-01, 2012-12-31, 2013-01-01), pseudoYear) is false +PASS successfullyParsed is true + +TEST COMPLETE + Added: trunk/LayoutTests/fast/forms/date-multiple-fields/date-multiple-fields-readonly-subfield.html (0 => 138148) ---
[webkit-changes] [138149] trunk/Source/WebKit2
Title: [138149] trunk/Source/WebKit2 Revision 138149 Author kenn...@webkit.org Date 2012-12-19 05:45:15 -0800 (Wed, 19 Dec 2012) Log Message [EFL][Qt][WK2] Going back to 47-amazing-css3-animation-demos shows nothing or wrong position https://bugs.webkit.org/show_bug.cgi?id=104414 Reviewed by Simon Hausmann. When contents size changes, make sure to apply any pending position change if possible. * UIProcess/PageViewportController.cpp: (WebKit::PageViewportController::didChangeContentsSize): Modified Paths trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/UIProcess/PageViewportController.cpp Diff Modified: trunk/Source/WebKit2/ChangeLog (138148 => 138149) --- trunk/Source/WebKit2/ChangeLog 2012-12-19 13:38:31 UTC (rev 138148) +++ trunk/Source/WebKit2/ChangeLog 2012-12-19 13:45:15 UTC (rev 138149) @@ -1,3 +1,16 @@ +2012-12-19 Kenneth Rohde Christiansen kenn...@webkit.org + +[EFL][Qt][WK2] Going back to 47-amazing-css3-animation-demos shows nothing or wrong position +https://bugs.webkit.org/show_bug.cgi?id=104414 + +Reviewed by Simon Hausmann. + +When contents size changes, make sure to apply any pending position +change if possible. + +* UIProcess/PageViewportController.cpp: +(WebKit::PageViewportController::didChangeContentsSize): + 2012-12-19 Alberto Garcia agar...@igalia.com [GTK] [WK2] Trailing semicolon in an #include line Modified: trunk/Source/WebKit2/UIProcess/PageViewportController.cpp (138148 => 138149) --- trunk/Source/WebKit2/UIProcess/PageViewportController.cpp 2012-12-19 13:38:31 UTC (rev 138148) +++ trunk/Source/WebKit2/UIProcess/PageViewportController.cpp 2012-12-19 13:45:15 UTC (rev 138149) @@ -163,6 +163,9 @@ if (minimumScaleUpdated) m_client-didChangeViewportAttributes(); + +// We might have pending position change which is now possible. +syncVisibleContents(); } void PageViewportController::didRenderFrame(const IntSize contentsSize, const IntRect coveredRect) ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [138150] trunk/Source/WebCore
Title: [138150] trunk/Source/WebCore
Revision 138150
Author ca...@chromium.org
Date 2012-12-19 05:56:38 -0800 (Wed, 19 Dec 2012)
Log Message
Web Inspector: scripts to evaluate on load are not removed from inspector state when Page agent is disabled
https://bugs.webkit.org/show_bug.cgi?id=105422
Reviewed by Alexander Pavlov.
- reset scripts to evaluate on load when InspectorPageAgent is disabled.
- added InspectorState::remove();
* inspector/InspectorPageAgent.cpp:
(WebCore::InspectorPageAgent::disable):
* inspector/InspectorState.cpp:
(WebCore::InspectorState::remove):
(WebCore):
* inspector/InspectorState.h:
(InspectorState):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/InspectorPageAgent.cpp
trunk/Source/WebCore/inspector/InspectorState.cpp
trunk/Source/WebCore/inspector/InspectorState.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (138149 => 138150)
--- trunk/Source/WebCore/ChangeLog 2012-12-19 13:45:15 UTC (rev 138149)
+++ trunk/Source/WebCore/ChangeLog 2012-12-19 13:56:38 UTC (rev 138150)
@@ -1,3 +1,21 @@
+2012-12-19 Andrey Kosyakov ca...@chromium.org
+
+Web Inspector: scripts to evaluate on load are not removed from inspector state when Page agent is disabled
+https://bugs.webkit.org/show_bug.cgi?id=105422
+
+Reviewed by Alexander Pavlov.
+
+- reset scripts to evaluate on load when InspectorPageAgent is disabled.
+- added InspectorState::remove();
+
+* inspector/InspectorPageAgent.cpp:
+(WebCore::InspectorPageAgent::disable):
+* inspector/InspectorState.cpp:
+(WebCore::InspectorState::remove):
+(WebCore):
+* inspector/InspectorState.h:
+(InspectorState):
+
2012-12-19 Kunihiko Sakamoto ksakam...@chromium.org
INPUT_MULTIPLE_FIELDS_UI: Make year field readonly if min and max have the same year
Modified: trunk/Source/WebCore/inspector/InspectorPageAgent.cpp (138149 => 138150)
--- trunk/Source/WebCore/inspector/InspectorPageAgent.cpp 2012-12-19 13:45:15 UTC (rev 138149)
+++ trunk/Source/WebCore/inspector/InspectorPageAgent.cpp 2012-12-19 13:56:38 UTC (rev 138150)
@@ -407,6 +407,7 @@
m_state-setLong(PageAgentState::pageAgentScreenHeightOverride, 0);
m_state-setDouble(PageAgentState::pageAgentFontScaleFactorOverride, 1);
m_state-setBoolean(PageAgentState::pageAgentFitWindow, false);
+m_state-remove(PageAgentState::pageAgentScriptsToEvaluateOnLoad);
updateViewMetrics(0, 0, 1, false);
}
Modified: trunk/Source/WebCore/inspector/InspectorState.cpp (138149 => 138150)
--- trunk/Source/WebCore/inspector/InspectorState.cpp 2012-12-19 13:45:15 UTC (rev 138149)
+++ trunk/Source/WebCore/inspector/InspectorState.cpp 2012-12-19 13:56:38 UTC (rev 138150)
@@ -75,6 +75,11 @@
updateCookie();
}
+void InspectorState::remove(const String propertyName)
+{
+m_properties-remove(propertyName);
+}
+
bool InspectorState::getBoolean(const String propertyName)
{
InspectorObject::iterator it = m_properties-find(propertyName);
Modified: trunk/Source/WebCore/inspector/InspectorState.h (138149 => 138150)
--- trunk/Source/WebCore/inspector/InspectorState.h 2012-12-19 13:45:15 UTC (rev 138149)
+++ trunk/Source/WebCore/inspector/InspectorState.h 2012-12-19 13:56:38 UTC (rev 138150)
@@ -65,6 +65,7 @@
void setDouble(const String propertyName, double value) { setValue(propertyName, InspectorBasicValue::create(value)); }
void setObject(const String propertyName, PassRefPtrInspectorObject value) { setValue(propertyName, value); }
+void remove(const String);
private:
void updateCookie();
void setValue(const String propertyName, PassRefPtrInspectorValue);
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [138151] trunk/Source/WebCore
Title: [138151] trunk/Source/WebCore
Revision 138151
Author vse...@chromium.org
Date 2012-12-19 06:14:01 -0800 (Wed, 19 Dec 2012)
Log Message
Web Inspector: Support removing several tabs from TabbedEditorContainer/TabbedPane at once.
https://bugs.webkit.org/show_bug.cgi?id=104881
Reviewed by Alexander Pavlov.
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype._uiSourceCodeRemoved):
* inspector/front-end/TabbedEditorContainer.js:
(WebInspector.TabbedEditorContainer.prototype.removeUISourceCode):
* inspector/front-end/TabbedPane.js:
(WebInspector.TabbedPane.prototype.closeTab):
(WebInspector.TabbedPane.prototype.closeTabs):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/ScriptsPanel.js
trunk/Source/WebCore/inspector/front-end/TabbedEditorContainer.js
trunk/Source/WebCore/inspector/front-end/TabbedPane.js
Diff
Modified: trunk/Source/WebCore/ChangeLog (138150 => 138151)
--- trunk/Source/WebCore/ChangeLog 2012-12-19 13:56:38 UTC (rev 138150)
+++ trunk/Source/WebCore/ChangeLog 2012-12-19 14:14:01 UTC (rev 138151)
@@ -1,3 +1,18 @@
+2012-12-19 Vsevolod Vlasov vse...@chromium.org
+
+Web Inspector: Support removing several tabs from TabbedEditorContainer/TabbedPane at once.
+https://bugs.webkit.org/show_bug.cgi?id=104881
+
+Reviewed by Alexander Pavlov.
+
+* inspector/front-end/ScriptsPanel.js:
+(WebInspector.ScriptsPanel.prototype._uiSourceCodeRemoved):
+* inspector/front-end/TabbedEditorContainer.js:
+(WebInspector.TabbedEditorContainer.prototype.removeUISourceCode):
+* inspector/front-end/TabbedPane.js:
+(WebInspector.TabbedPane.prototype.closeTab):
+(WebInspector.TabbedPane.prototype.closeTabs):
+
2012-12-19 Andrey Kosyakov ca...@chromium.org
Web Inspector: scripts to evaluate on load are not removed from inspector state when Page agent is disabled
Modified: trunk/Source/WebCore/inspector/front-end/ScriptsPanel.js (138150 => 138151)
--- trunk/Source/WebCore/inspector/front-end/ScriptsPanel.js 2012-12-19 13:56:38 UTC (rev 138150)
+++ trunk/Source/WebCore/inspector/front-end/ScriptsPanel.js 2012-12-19 14:14:01 UTC (rev 138151)
@@ -251,9 +251,16 @@
_uiSourceCodeRemoved: function(event)
{
var uiSourceCode = /** @type {WebInspector.UISourceCode} */ (event.data);
+var wasCurrent = uiSourceCode === this._currentUISourceCode;
this._editorContainer.removeUISourceCode(uiSourceCode);
this._navigator.removeUISourceCode(uiSourceCode);
this._removeSourceFrame(uiSourceCode);
+// Replace debugger script-based uiSourceCode with a network-based one.
+if (wasCurrent uiSourceCode.isTemporary) {
+var newUISourceCode = WebInspector.workspace.uiSourceCodeForURL(uiSourceCode.url);
+if (newUISourceCode)
+this._showFile(newUISourceCode);
+}
},
_consoleCommandEvaluatedInSelectedCallFrame: function(event)
Modified: trunk/Source/WebCore/inspector/front-end/TabbedEditorContainer.js (138150 => 138151)
--- trunk/Source/WebCore/inspector/front-end/TabbedEditorContainer.js 2012-12-19 13:56:38 UTC (rev 138150)
+++ trunk/Source/WebCore/inspector/front-end/TabbedEditorContainer.js 2012-12-19 14:14:01 UTC (rev 138151)
@@ -203,8 +203,8 @@
var tabId = this._tabIds.get(uiSourceCode) || this._appendFileTab(uiSourceCode, false);
// Select tab if this file was the last to be shown.
-if (index === 0)
-this._innerShowFile(uiSourceCode, false);
+if (!index)
+this._innerShowFile(uiSourceCode, true);
},
/**
@@ -212,17 +212,22 @@
*/
removeUISourceCode: function(uiSourceCode)
{
-var wasCurrent = this._currentFile === uiSourceCode;
+this.removeUISourceCodes([uiSourceCode]);
+},
-var tabId = this._tabIds.get(uiSourceCode);
-if (tabId)
-this._tabbedPane.closeTab(tabId);
-
-if (wasCurrent uiSourceCode.isTemporary) {
-var newUISourceCode = WebInspector.workspace.uiSourceCodeForURL(uiSourceCode.url);
-if (newUISourceCode)
-this._innerShowFile(newUISourceCode, false);
+/**
+ * @param {Array.WebInspector.UISourceCode} uiSourceCodes
+ */
+removeUISourceCodes: function(uiSourceCodes)
+{
+var tabIds = [];
+for (var i = 0; i uiSourceCodes.length; ++i) {
+var uiSourceCode = uiSourceCodes[i];
+var tabId = this._tabIds.get(uiSourceCode);
+if (tabId)
+tabIds.push(tabId);
}
+this._tabbedPane.closeTabs(tabIds);
},
/**
Modified: trunk/Source/WebCore/inspector/front-end/TabbedPane.js (138150 => 138151)
--- trunk/Source/WebCore/inspector/front-end/TabbedPane.js 2012-12-19 13:56:38 UTC (rev 138150)
+++ trunk/Source/WebCore/inspector/front-end/TabbedPane.js
[webkit-changes] [138152] branches/chromium/1365/
Title: [138152] branches/chromium/1365/ Revision 138152 Author kar...@chromium.org Date 2012-12-19 06:31:55 -0800 (Wed, 19 Dec 2012) Log Message branching for chromium Added Paths branches/chromium/1365/ Diff Property changes: branches/chromium/1365 Added: svn:ignore depcomp compile config.guess GNUmakefile.in config.sub ltmain.sh aconfig.h.in autom4te.cache missing aclocal.m4 install-sh autotoolsconfig.h.in INSTALL README gtk-doc.make out Makefile.chromium WebKitSupportLibrary.zip WebKitBuild Added: svn:mergeinfo ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [138153] branches/chromium/1365/codereview.settings
Title: [138153] branches/chromium/1365/codereview.settings Revision 138153 Author kar...@chromium.org Date 2012-12-19 06:33:04 -0800 (Wed, 19 Dec 2012) Log Message for easy drovering Added Paths branches/chromium/1365/codereview.settings Diff Added: branches/chromium/1365/codereview.settings (0 => 138153) --- branches/chromium/1365/codereview.settings (rev 0) +++ branches/chromium/1365/codereview.settings 2012-12-19 14:33:04 UTC (rev 138153) @@ -0,0 +1,10 @@ +# This file is used by gcl to get repository specific information. +CODE_REVIEW_SERVER: codereview.chromium.org +CC_LIST: chromium-revi...@chromium.org +VIEW_VC: http://src.chromium.org/viewvc/chrome?view=revrevision= +STATUS: http://chromium-status.appspot.com/status +TRY_ON_UPLOAD: True +TRYSERVER_SVN_URL: svn://svn.chromium.org/chrome-try/try +GITCL_PREUPLOAD: http://src.chromium.org/viewvc/trunk/tools/depot_tools/git-cl-upload-hook?revision=HEADroot=chrome +GITCL_PREDCOMMIT: http://src.chromium.org/viewvc/trunk/tools/depot_tools/git-cl-upload-hook?revision=HEADroot=chrome +LINT_IGNORE_REGEX: webkit/api/.* ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [138154] trunk/Source/WebKit2
Title: [138154] trunk/Source/WebKit2
Revision 138154
Author commit-qu...@webkit.org
Date 2012-12-19 06:39:30 -0800 (Wed, 19 Dec 2012)
Log Message
[EFL][WK2][AC] Avoid creating an empty surface.
https://bugs.webkit.org/show_bug.cgi?id=105410
Patch by Kondapally Kalyan kalyan.kondapa...@intel.com on 2012-12-19
Reviewed by Kenneth Rohde Christiansen.
Ensure that the view has valid size before creating the surface.
* UIProcess/API/efl/EvasGLSurface.h:
(WebKit::EvasGLSurface::create):
* UIProcess/API/efl/EwkViewImpl.cpp:
(EwkViewImpl::displayTimerFired):
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/efl/EvasGLSurface.h
trunk/Source/WebKit2/UIProcess/API/efl/EwkViewImpl.cpp
Diff
Modified: trunk/Source/WebKit2/ChangeLog (138153 => 138154)
--- trunk/Source/WebKit2/ChangeLog 2012-12-19 14:33:04 UTC (rev 138153)
+++ trunk/Source/WebKit2/ChangeLog 2012-12-19 14:39:30 UTC (rev 138154)
@@ -1,3 +1,17 @@
+2012-12-19 Kondapally Kalyan kalyan.kondapa...@intel.com
+
+[EFL][WK2][AC] Avoid creating an empty surface.
+https://bugs.webkit.org/show_bug.cgi?id=105410
+
+Reviewed by Kenneth Rohde Christiansen.
+
+Ensure that the view has valid size before creating the surface.
+
+* UIProcess/API/efl/EvasGLSurface.h:
+(WebKit::EvasGLSurface::create):
+* UIProcess/API/efl/EwkViewImpl.cpp:
+(EwkViewImpl::displayTimerFired):
+
2012-12-19 Kenneth Rohde Christiansen kenn...@webkit.org
[EFL][Qt][WK2] Going back to 47-amazing-css3-animation-demos shows nothing or wrong position
Modified: trunk/Source/WebKit2/UIProcess/API/efl/EvasGLSurface.h (138153 => 138154)
--- trunk/Source/WebKit2/UIProcess/API/efl/EvasGLSurface.h 2012-12-19 14:33:04 UTC (rev 138153)
+++ trunk/Source/WebKit2/UIProcess/API/efl/EvasGLSurface.h 2012-12-19 14:39:30 UTC (rev 138154)
@@ -39,7 +39,13 @@
{
ASSERT(evasGL);
ASSERT(cfg);
-Evas_GL_Surface* surface = evas_gl_surface_create(evasGL, cfg, size.width(), size.height());
+
+Evas_GL_Surface* surface = 0;
+
+// Ensure that the surface is created with valid size.
+if (size.width() size.height())
+surface = evas_gl_surface_create(evasGL, cfg, size.width(), size.height());
+
if (!surface)
return nullptr;
Modified: trunk/Source/WebKit2/UIProcess/API/efl/EwkViewImpl.cpp (138153 => 138154)
--- trunk/Source/WebKit2/UIProcess/API/efl/EwkViewImpl.cpp 2012-12-19 14:33:04 UTC (rev 138153)
+++ trunk/Source/WebKit2/UIProcess/API/efl/EwkViewImpl.cpp 2012-12-19 14:39:30 UTC (rev 138154)
@@ -373,6 +373,9 @@
if (m_pendingSurfaceResize) {
// Create a GL surface here so that Evas has no chance of painting to an empty GL surface.
createGLSurface(IntSize(sd-view.w, sd-view.h));
+if (!m_evasGLSurface)
+return;
+
m_pendingSurfaceResize = false;
} else
evas_gl_make_current(m_evasGL.get(), evasGLSurface(), evasGLContext());
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [138158] trunk/Tools
Title: [138158] trunk/Tools
Revision 138158
Author thiago.san...@intel.com
Date 2012-12-19 07:05:46 -0800 (Wed, 19 Dec 2012)
Log Message
[EFL] Move ImageDiff to the Tools directory root
https://bugs.webkit.org/show_bug.cgi?id=105305
Reviewed by Laszlo Gombos.
We previously moved this directory from the DRT directory to
efl/ImageDiff. The major reason for doing so was because ImageDiff does
not depend on DumpRenderTree but for legacy reasons was living inside the
DRT folder, even though it is needed when running pixel tests for WK2.
Now we are moving to Tool directory root as other ports agreed to do the same.
* CMakeLists.txt:
* ImageDiff/CMakeLists.txt: Added.
* ImageDiff/PlatformEfl.cmake: Added.
* ImageDiff/efl/ImageDiff.cpp: Renamed from Tools/efl/ImageDiff/ImageDiff.cpp.
* efl/ImageDiff/CMakeLists.txt: Removed.
Modified Paths
trunk/Tools/CMakeLists.txt
trunk/Tools/ChangeLog
Added Paths
trunk/Tools/ImageDiff/
trunk/Tools/ImageDiff/CMakeLists.txt
trunk/Tools/ImageDiff/PlatformEfl.cmake
trunk/Tools/ImageDiff/efl/
trunk/Tools/ImageDiff/efl/ImageDiff.cpp
Removed Paths
trunk/Tools/efl/ImageDiff/CMakeLists.txt
trunk/Tools/efl/ImageDiff/ImageDiff.cpp
Diff
Modified: trunk/Tools/CMakeLists.txt (138157 => 138158)
--- trunk/Tools/CMakeLists.txt 2012-12-19 14:52:12 UTC (rev 138157)
+++ trunk/Tools/CMakeLists.txt 2012-12-19 15:05:46 UTC (rev 138158)
@@ -3,7 +3,7 @@
endif ()
if (${PORT} STREQUAL Efl)
-add_subdirectory(efl/ImageDiff)
+add_subdirectory(ImageDiff)
add_subdirectory(EWebLauncher/ControlTheme)
if (ENABLE_WEBKIT)
Modified: trunk/Tools/ChangeLog (138157 => 138158)
--- trunk/Tools/ChangeLog 2012-12-19 14:52:12 UTC (rev 138157)
+++ trunk/Tools/ChangeLog 2012-12-19 15:05:46 UTC (rev 138158)
@@ -1,3 +1,23 @@
+2012-12-19 Thiago Marcos P. Santos thiago.san...@intel.com
+
+[EFL] Move ImageDiff to the Tools directory root
+https://bugs.webkit.org/show_bug.cgi?id=105305
+
+Reviewed by Laszlo Gombos.
+
+We previously moved this directory from the DRT directory to
+efl/ImageDiff. The major reason for doing so was because ImageDiff does
+not depend on DumpRenderTree but for legacy reasons was living inside the
+DRT folder, even though it is needed when running pixel tests for WK2.
+
+Now we are moving to Tool directory root as other ports agreed to do the same.
+
+* CMakeLists.txt:
+* ImageDiff/CMakeLists.txt: Added.
+* ImageDiff/PlatformEfl.cmake: Added.
+* ImageDiff/efl/ImageDiff.cpp: Renamed from Tools/efl/ImageDiff/ImageDiff.cpp.
+* efl/ImageDiff/CMakeLists.txt: Removed.
+
2012-12-19 Zeno Albisser z...@webkit.org
[Qt][Mac] run-launcher cannot find Qt5WebKitWidgets.
Added: trunk/Tools/ImageDiff/CMakeLists.txt (0 => 138158)
--- trunk/Tools/ImageDiff/CMakeLists.txt (rev 0)
+++ trunk/Tools/ImageDiff/CMakeLists.txt 2012-12-19 15:05:46 UTC (rev 138158)
@@ -0,0 +1,17 @@
+set(IMAGE_DIFF_DIR ${TOOLS_DIR}/ImageDiff)
+
+set(IMAGE_DIFF_INCLUDE_DIRECTORIES
+${CMAKE_BINARY_DIR}
+${WTF_DIR}
+)
+
+set(IMAGE_DIFF_LIBRARIES
+${WTF_LIBRARY_NAME}
+)
+
+INCLUDE_IF_EXISTS(${IMAGE_DIFF_DIR}/Platform${PORT}.cmake)
+
+include_directories(${IMAGE_DIFF_INCLUDE_DIRECTORIES})
+add_executable(ImageDiff ${IMAGE_DIFF_SOURCES})
+target_link_libraries(ImageDiff ${IMAGE_DIFF_LIBRARIES})
+set_target_properties(ImageDiff PROPERTIES FOLDER Tools)
Added: trunk/Tools/ImageDiff/PlatformEfl.cmake (0 => 138158)
--- trunk/Tools/ImageDiff/PlatformEfl.cmake (rev 0)
+++ trunk/Tools/ImageDiff/PlatformEfl.cmake 2012-12-19 15:05:46 UTC (rev 138158)
@@ -0,0 +1,17 @@
+set(IMAGE_DIFF_SOURCES
+${IMAGE_DIFF_DIR}/efl/ImageDiff.cpp
+)
+
+list(APPEND IMAGE_DIFF_INCLUDE_DIRECTORIES
+${ECORE_EVAS_INCLUDE_DIRS}
+${ECORE_INCLUDE_DIRS}
+${EINA_INCLUDE_DIRS}
+${EVAS_INCLUDE_DIRS}
+)
+
+list(APPEND IMAGE_DIFF_LIBRARIES
+${ECORE_EVAS_LIBRARIES}
+${ECORE_LIBRARIES}
+${EINA_LIBRARIES}
+${EVAS_LIBRARIES}
+)
Copied: trunk/Tools/ImageDiff/efl/ImageDiff.cpp (from rev 138157, trunk/Tools/efl/ImageDiff/ImageDiff.cpp) (0 => 138158)
--- trunk/Tools/ImageDiff/efl/ImageDiff.cpp (rev 0)
+++ trunk/Tools/ImageDiff/efl/ImageDiff.cpp 2012-12-19 15:05:46 UTC (rev 138158)
@@ -0,0 +1,368 @@
+/*
+ * Copyright (C) 2009 Zan Dobersek zandober...@gmail.com
+ * Copyright (C) 2010 Igalia S.L.
+ * Copyright (C) 2011 ProFUSION Embedded Systems
+ * Copyright (C) 2011 Samsung Electronics
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions
+ * are met:
+ *
+ * 1. Redistributions of source code must retain the above copyright
+ * notice, this list of conditions and the following disclaimer.
+ * 2. Redistributions in binary form must reproduce the above copyright
+ * notice, this list of conditions and the
[webkit-changes] [138160] trunk/Source/WebCore
Title: [138160] trunk/Source/WebCore
Revision 138160
Author vse...@chromium.org
Date 2012-12-19 07:29:46 -0800 (Wed, 19 Dec 2012)
Log Message
Web Inspector: Rename workspace path to uri.
https://bugs.webkit.org/show_bug.cgi?id=105433
Reviewed by Pavel Feldman.
URI should later become file unique id / address in workspace.
* inspector/front-end/NetworkWorkspaceProvider.js:
(WebInspector.NetworkWorkspaceProvider.prototype.requestFileContent):
(WebInspector.NetworkWorkspaceProvider.prototype.setFileContent):
(WebInspector.NetworkWorkspaceProvider.prototype.searchInFileContent):
(WebInspector.NetworkWorkspaceProvider.prototype.addFile):
(WebInspector.NetworkWorkspaceProvider.prototype.removeFile):
* inspector/front-end/Workspace.js:
(WebInspector.FileDescriptor):
(WebInspector.WorkspaceProvider.prototype.requestFileContent):
(WebInspector.WorkspaceProvider.prototype.searchInFileContent):
(WebInspector.Project.prototype._fileAdded):
(WebInspector.Project.prototype._fileRemoved):
(WebInspector.Project.prototype.requestFileContent):
(WebInspector.Project.prototype.searchInFileContent):
(WebInspector.Workspace.prototype.addTemporaryUISourceCode):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/NetworkWorkspaceProvider.js
trunk/Source/WebCore/inspector/front-end/Workspace.js
Diff
Modified: trunk/Source/WebCore/ChangeLog (138159 => 138160)
--- trunk/Source/WebCore/ChangeLog 2012-12-19 15:28:17 UTC (rev 138159)
+++ trunk/Source/WebCore/ChangeLog 2012-12-19 15:29:46 UTC (rev 138160)
@@ -1,3 +1,28 @@
+2012-12-19 Vsevolod Vlasov vse...@chromium.org
+
+Web Inspector: Rename workspace path to uri.
+https://bugs.webkit.org/show_bug.cgi?id=105433
+
+Reviewed by Pavel Feldman.
+
+URI should later become file unique id / address in workspace.
+
+* inspector/front-end/NetworkWorkspaceProvider.js:
+(WebInspector.NetworkWorkspaceProvider.prototype.requestFileContent):
+(WebInspector.NetworkWorkspaceProvider.prototype.setFileContent):
+(WebInspector.NetworkWorkspaceProvider.prototype.searchInFileContent):
+(WebInspector.NetworkWorkspaceProvider.prototype.addFile):
+(WebInspector.NetworkWorkspaceProvider.prototype.removeFile):
+* inspector/front-end/Workspace.js:
+(WebInspector.FileDescriptor):
+(WebInspector.WorkspaceProvider.prototype.requestFileContent):
+(WebInspector.WorkspaceProvider.prototype.searchInFileContent):
+(WebInspector.Project.prototype._fileAdded):
+(WebInspector.Project.prototype._fileRemoved):
+(WebInspector.Project.prototype.requestFileContent):
+(WebInspector.Project.prototype.searchInFileContent):
+(WebInspector.Workspace.prototype.addTemporaryUISourceCode):
+
2012-12-14 Alexander Pavlov apav...@chromium.org
Web Inspector: Refactor CSS[Keyword]Completions to augment property metadata
Modified: trunk/Source/WebCore/inspector/front-end/NetworkWorkspaceProvider.js (138159 => 138160)
--- trunk/Source/WebCore/inspector/front-end/NetworkWorkspaceProvider.js 2012-12-19 15:28:17 UTC (rev 138159)
+++ trunk/Source/WebCore/inspector/front-end/NetworkWorkspaceProvider.js 2012-12-19 15:29:46 UTC (rev 138160)
@@ -41,21 +41,21 @@
WebInspector.NetworkWorkspaceProvider.prototype = {
/**
- * @param {string} path
+ * @param {string} uri
* @param {function(?string,boolean,string)} callback
*/
-requestFileContent: function(path, callback)
+requestFileContent: function(uri, callback)
{
-var contentProvider = this._contentProviders[path];
+var contentProvider = this._contentProviders[uri];
contentProvider.requestContent(callback);
},
/**
- * @param {string} path
+ * @param {string} uri
* @param {string} newContent
* @param {function(?string)} callback
*/
-setFileContent: function(path, newContent, callback)
+setFileContent: function(uri, newContent, callback)
{
callback(null);
},
@@ -66,33 +66,33 @@
* @param {boolean} isRegex
* @param {function(Array.WebInspector.ContentProvider.SearchMatch)} callback
*/
-searchInFileContent: function(path, query, caseSensitive, isRegex, callback)
+searchInFileContent: function(uri, query, caseSensitive, isRegex, callback)
{
-var contentProvider = this._contentProviders[path];
+var contentProvider = this._contentProviders[uri];
contentProvider.searchInContent(query, caseSensitive, isRegex, callback);
},
/**
- * @param {string} path
+ * @param {string} uri
* @param {WebInspector.ContentProvider} contentProvider
* @param {boolean} isEditable
* @param {boolean=} isContentScript
* @param {boolean=} isSnippet
*/
-addFile: function(path, contentProvider, isEditable, isContentScript, isSnippet)
+addFile: function(uri, contentProvider,
[webkit-changes] [138161] trunk/Source/WebCore
Title: [138161] trunk/Source/WebCore
Revision 138161
Author vse...@chromium.org
Date 2012-12-19 07:32:32 -0800 (Wed, 19 Dec 2012)
Log Message
Web Inspector: Add Workspace.setFileContent() method
https://bugs.webkit.org/show_bug.cgi?id=105434
Reviewed by Pavel Feldman.
Added method that will be usedto save file system-based uiSourceCodes to the disk.
* inspector/front-end/UISourceCode.js:
(WebInspector.UISourceCode.prototype._commitContent):
* inspector/front-end/Workspace.js:
(WebInspector.WorkspaceProvider.prototype.setFileContent):
(WebInspector.Project.prototype.setFileContent):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/UISourceCode.js
trunk/Source/WebCore/inspector/front-end/Workspace.js
Diff
Modified: trunk/Source/WebCore/ChangeLog (138160 => 138161)
--- trunk/Source/WebCore/ChangeLog 2012-12-19 15:29:46 UTC (rev 138160)
+++ trunk/Source/WebCore/ChangeLog 2012-12-19 15:32:32 UTC (rev 138161)
@@ -1,5 +1,20 @@
2012-12-19 Vsevolod Vlasov vse...@chromium.org
+Web Inspector: Add Workspace.setFileContent() method
+https://bugs.webkit.org/show_bug.cgi?id=105434
+
+Reviewed by Pavel Feldman.
+
+Added method that will be usedto save file system-based uiSourceCodes to the disk.
+
+* inspector/front-end/UISourceCode.js:
+(WebInspector.UISourceCode.prototype._commitContent):
+* inspector/front-end/Workspace.js:
+(WebInspector.WorkspaceProvider.prototype.setFileContent):
+(WebInspector.Project.prototype.setFileContent):
+
+2012-12-19 Vsevolod Vlasov vse...@chromium.org
+
Web Inspector: Rename workspace path to uri.
https://bugs.webkit.org/show_bug.cgi?id=105433
Modified: trunk/Source/WebCore/inspector/front-end/UISourceCode.js (138160 => 138161)
--- trunk/Source/WebCore/inspector/front-end/UISourceCode.js 2012-12-19 15:29:46 UTC (rev 138160)
+++ trunk/Source/WebCore/inspector/front-end/UISourceCode.js 2012-12-19 15:32:32 UTC (rev 138161)
@@ -198,6 +198,7 @@
WebInspector.fileManager.save(this._url, this._content, false);
WebInspector.fileManager.close(this._url);
}
+this._workspace.setFileContent(this, this._content, function() { });
},
/**
Modified: trunk/Source/WebCore/inspector/front-end/Workspace.js (138160 => 138161)
--- trunk/Source/WebCore/inspector/front-end/Workspace.js 2012-12-19 15:29:46 UTC (rev 138160)
+++ trunk/Source/WebCore/inspector/front-end/Workspace.js 2012-12-19 15:32:32 UTC (rev 138161)
@@ -91,6 +91,14 @@
requestFileContent: function(uri, callback) { },
/**
+ * @param {string} uri
+ * @param {string} newContent
+ * @param {function(?string)} callback
+ */
+setFileContent: function(uri, newContent, callback) { },
+
+/**
+ * @param {string} uri
* @param {string} query
* @param {boolean} caseSensitive
* @param {boolean} isRegex
@@ -195,6 +203,17 @@
},
/**
+ * @param {string} uri
+ * @param {string} newContent
+ * @param {function(?string)} callback
+ */
+setFileContent: function(uri, newContent, callback)
+{
+this._workspaceProvider.setFileContent(uri, newContent, callback);
+},
+
+/**
+ * @param {string} uri
* @param {string} query
* @param {boolean} caseSensitive
* @param {boolean} isRegex
@@ -301,6 +320,18 @@
/**
* @param {WebInspector.UISourceCode} uiSourceCode
+ * @param {string} newContent
+ * @param {function(?string)} callback
+ */
+setFileContent: function(uiSourceCode, newContent, callback)
+{
+if (this._temporaryContentProviders.get(uiSourceCode))
+return;
+this._project.setFileContent(uiSourceCode.url, newContent, callback);
+},
+
+/**
+ * @param {WebInspector.UISourceCode} uiSourceCode
* @param {string} query
* @param {boolean} caseSensitive
* @param {boolean} isRegex
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [138162] trunk
Title: [138162] trunk Revision 138162 Author commit-qu...@webkit.org Date 2012-12-19 07:34:36 -0800 (Wed, 19 Dec 2012) Log Message Text Autosizing: Work out what to do about form controls https://bugs.webkit.org/show_bug.cgi?id=102560 Patch by Tim Volodine timvolod...@chromium.org on 2012-12-19 Reviewed by Kenneth Rohde Christiansen. Source/WebCore: Disallow autosizing of form input controls like buttons, text input fields, selection controls, radio buttons and check boxes. This is a short term solution to avoid inconsistent autosizing of form controls (which is worse than not autosizing at all). Tests: fast/text-autosizing/form-controls-autosizing-button-input-elements.html fast/text-autosizing/form-controls-autosizing-checkbox-input-element.html fast/text-autosizing/form-controls-autosizing-radio-input-element.html fast/text-autosizing/form-controls-autosizing-select-element.html fast/text-autosizing/form-controls-autosizing-textfield-input-elements.html * rendering/TextAutosizer.cpp: (WebCore): (WebCore::formInputTags): (WebCore::TextAutosizer::isAutosizingContainer): (WebCore::TextAutosizer::contentHeightIsConstrained): (WebCore::TextAutosizer::containerShouldBeAutosized): (WebCore::TextAutosizer::containerContainsOneOfTags): * rendering/TextAutosizer.h: LayoutTests: Tests for form input elements autosizing. Added tests to check that various kinds of form elements don't get autosized, i.e. buttons, textareas, check boxes, radio button and selection menus. * fast/text-autosizing/form-controls-autosizing-button-input-elements-expected.html: Added. * fast/text-autosizing/form-controls-autosizing-button-input-elements.html: Added. * fast/text-autosizing/form-controls-autosizing-checkbox-input-element-expected.html: Added. * fast/text-autosizing/form-controls-autosizing-checkbox-input-element.html: Added. * fast/text-autosizing/form-controls-autosizing-radio-input-element-expected.html: Added. * fast/text-autosizing/form-controls-autosizing-radio-input-element.html: Added. * fast/text-autosizing/form-controls-autosizing-select-element-expected.html: Added. * fast/text-autosizing/form-controls-autosizing-select-element.html: Added. * fast/text-autosizing/form-controls-autosizing-textfield-input-elements-expected.html: Added. * fast/text-autosizing/form-controls-autosizing-textfield-input-elements.html: Added. Modified Paths trunk/LayoutTests/ChangeLog trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/rendering/TextAutosizer.cpp trunk/Source/WebCore/rendering/TextAutosizer.h Added Paths trunk/LayoutTests/fast/text-autosizing/form-controls-autosizing-button-input-elements-expected.html trunk/LayoutTests/fast/text-autosizing/form-controls-autosizing-button-input-elements.html trunk/LayoutTests/fast/text-autosizing/form-controls-autosizing-checkbox-input-element-expected.html trunk/LayoutTests/fast/text-autosizing/form-controls-autosizing-checkbox-input-element.html trunk/LayoutTests/fast/text-autosizing/form-controls-autosizing-radio-input-element-expected.html trunk/LayoutTests/fast/text-autosizing/form-controls-autosizing-radio-input-element.html trunk/LayoutTests/fast/text-autosizing/form-controls-autosizing-select-element-expected.html trunk/LayoutTests/fast/text-autosizing/form-controls-autosizing-select-element.html trunk/LayoutTests/fast/text-autosizing/form-controls-autosizing-textfield-input-elements-expected.html trunk/LayoutTests/fast/text-autosizing/form-controls-autosizing-textfield-input-elements.html Diff Modified: trunk/LayoutTests/ChangeLog (138161 => 138162) --- trunk/LayoutTests/ChangeLog 2012-12-19 15:32:32 UTC (rev 138161) +++ trunk/LayoutTests/ChangeLog 2012-12-19 15:34:36 UTC (rev 138162) @@ -1,3 +1,24 @@ +2012-12-19 Tim Volodine timvolod...@chromium.org + +Text Autosizing: Work out what to do about form controls +https://bugs.webkit.org/show_bug.cgi?id=102560 + +Reviewed by Kenneth Rohde Christiansen. + +Tests for form input elements autosizing. Added tests to check that various kinds of form elements +don't get autosized, i.e. buttons, textareas, check boxes, radio button and selection menus. + +* fast/text-autosizing/form-controls-autosizing-button-input-elements-expected.html: Added. +* fast/text-autosizing/form-controls-autosizing-button-input-elements.html: Added. +* fast/text-autosizing/form-controls-autosizing-checkbox-input-element-expected.html: Added. +* fast/text-autosizing/form-controls-autosizing-checkbox-input-element.html: Added. +* fast/text-autosizing/form-controls-autosizing-radio-input-element-expected.html: Added. +* fast/text-autosizing/form-controls-autosizing-radio-input-element.html: Added. +* fast/text-autosizing/form-controls-autosizing-select-element-expected.html: Added. +* fast/text-autosizing/form-controls-autosizing-select-element.html: Added. +*
[webkit-changes] [138163] trunk/Source/WebCore
Title: [138163] trunk/Source/WebCore
Revision 138163
Author commit-qu...@webkit.org
Date 2012-12-19 07:43:16 -0800 (Wed, 19 Dec 2012)
Log Message
Web Inspector: Use Document* as argument in WebSocket Instrumentation.
https://bugs.webkit.org/show_bug.cgi?id=105279.
Patch by Pan Deng pan.d...@intel.com on 2012-12-19
Reviewed by Pavel Feldman.
Some WebSocket instrumentation fuctions adopted ScriptExecutionContext* as argument, it is not clear that
their clients and implementations are all using Document*. This patch adopt Document* as argument, and
Document* could supply more information in future.
No functionality changed, no new tests.
* inspector/InspectorInstrumentation.h:
(InspectorInstrumentation):
(WebCore::InspectorInstrumentation::didCreateWebSocket):
(WebCore::InspectorInstrumentation::willSendWebSocketHandshakeRequest):
(WebCore::InspectorInstrumentation::didReceiveWebSocketHandshakeResponse):
(WebCore::InspectorInstrumentation::didCloseWebSocket):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/InspectorInstrumentation.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (138162 => 138163)
--- trunk/Source/WebCore/ChangeLog 2012-12-19 15:34:36 UTC (rev 138162)
+++ trunk/Source/WebCore/ChangeLog 2012-12-19 15:43:16 UTC (rev 138163)
@@ -1,3 +1,23 @@
+2012-12-19 Pan Deng pan.d...@intel.com
+
+Web Inspector: Use Document* as argument in WebSocket Instrumentation.
+https://bugs.webkit.org/show_bug.cgi?id=105279.
+
+Reviewed by Pavel Feldman.
+
+Some WebSocket instrumentation fuctions adopted ScriptExecutionContext* as argument, it is not clear that
+their clients and implementations are all using Document*. This patch adopt Document* as argument, and
+Document* could supply more information in future.
+
+No functionality changed, no new tests.
+
+* inspector/InspectorInstrumentation.h:
+(InspectorInstrumentation):
+(WebCore::InspectorInstrumentation::didCreateWebSocket):
+(WebCore::InspectorInstrumentation::willSendWebSocketHandshakeRequest):
+(WebCore::InspectorInstrumentation::didReceiveWebSocketHandshakeResponse):
+(WebCore::InspectorInstrumentation::didCloseWebSocket):
+
2012-12-19 Tim Volodine timvolod...@chromium.org
Text Autosizing: Work out what to do about form controls
Modified: trunk/Source/WebCore/inspector/InspectorInstrumentation.h (138162 => 138163)
--- trunk/Source/WebCore/inspector/InspectorInstrumentation.h 2012-12-19 15:34:36 UTC (rev 138162)
+++ trunk/Source/WebCore/inspector/InspectorInstrumentation.h 2012-12-19 15:43:16 UTC (rev 138163)
@@ -240,10 +240,10 @@
#endif
#if ENABLE(WEB_SOCKETS)
-static void didCreateWebSocket(ScriptExecutionContext*, unsigned long identifier, const KURL requestURL, const KURL documentURL);
-static void willSendWebSocketHandshakeRequest(ScriptExecutionContext*, unsigned long identifier, const WebSocketHandshakeRequest);
-static void didReceiveWebSocketHandshakeResponse(ScriptExecutionContext*, unsigned long identifier, const WebSocketHandshakeResponse);
-static void didCloseWebSocket(ScriptExecutionContext*, unsigned long identifier);
+static void didCreateWebSocket(Document*, unsigned long identifier, const KURL requestURL, const KURL documentURL);
+static void willSendWebSocketHandshakeRequest(Document*, unsigned long identifier, const WebSocketHandshakeRequest);
+static void didReceiveWebSocketHandshakeResponse(Document*, unsigned long identifier, const WebSocketHandshakeResponse);
+static void didCloseWebSocket(Document*, unsigned long identifier);
static void didReceiveWebSocketFrame(Document*, unsigned long identifier, const WebSocketFrame);
static void didSendWebSocketFrame(Document*, unsigned long identifier, const WebSocketFrame);
static void didReceiveWebSocketFrameError(Document*, unsigned long identifier, const String errorMessage);
@@ -1759,50 +1759,50 @@
#if ENABLE(WEB_SOCKETS)
-inline void InspectorInstrumentation::didCreateWebSocket(ScriptExecutionContext* context, unsigned long identifier, const KURL requestURL, const KURL documentURL)
+inline void InspectorInstrumentation::didCreateWebSocket(Document* document, unsigned long identifier, const KURL requestURL, const KURL documentURL)
{
#if ENABLE(INSPECTOR)
-if (InstrumentingAgents* instrumentingAgents = instrumentingAgentsForContext(context))
+if (InstrumentingAgents* instrumentingAgents = instrumentingAgentsForDocument(document))
didCreateWebSocketImpl(instrumentingAgents, identifier, requestURL, documentURL);
#else
-UNUSED_PARAM(context);
+UNUSED_PARAM(document);
UNUSED_PARAM(identifier);
UNUSED_PARAM(requestURL);
UNUSED_PARAM(documentURL);
#endif
}
-inline void InspectorInstrumentation::willSendWebSocketHandshakeRequest(ScriptExecutionContext* context, unsigned long identifier, const WebSocketHandshakeRequest
[webkit-changes] [138164] trunk/Source/WebCore
Title: [138164] trunk/Source/WebCore
Revision 138164
Author commit-qu...@webkit.org
Date 2012-12-19 08:07:10 -0800 (Wed, 19 Dec 2012)
Log Message
Web Inspector: refactor DefaultTextEditor's |expanded| setters
https://bugs.webkit.org/show_bug.cgi?id=105415
Patch by Andrey Lushnikov lushni...@chromium.com on 2012-12-19
Reviewed by Pavel Feldman.
Refactor |expanded| setters and getters into |collapse()|, |expand()|
and |expanded()| methods
* inspector/front-end/DefaultTextEditor.js:
(WebInspector.TextEditorChunkedPanel.prototype._splitChunkOnALine):
(WebInspector.TextEditorChunkedPanel.prototype._expandChunks):
(WebInspector.TextEditorGutterPanel.prototype.textChanged):
(WebInspector.TextEditorGutterChunk.prototype.expanded): Added.
(WebInspector.TextEditorGutterChunk.prototype.collapse): Added.
(WebInspector.TextEditorGutterChunk.prototype.expand): Added.
(WebInspector.TextEditorMainPanel.prototype.markAndRevealRange):
(WebInspector.TextEditorMainPanel.prototype._updateHighlightsForRange):
(WebInspector.TextEditorMainChunk.prototype.expanded): Added.
(WebInspector.TextEditorMainChunk.prototype.collapse): Added.
(WebInspector.TextEditorMainChunk.prototype.expand): Added.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/DefaultTextEditor.js
Diff
Modified: trunk/Source/WebCore/ChangeLog (138163 => 138164)
--- trunk/Source/WebCore/ChangeLog 2012-12-19 15:43:16 UTC (rev 138163)
+++ trunk/Source/WebCore/ChangeLog 2012-12-19 16:07:10 UTC (rev 138164)
@@ -1,3 +1,26 @@
+2012-12-19 Andrey Lushnikov lushni...@chromium.com
+
+Web Inspector: refactor DefaultTextEditor's |expanded| setters
+https://bugs.webkit.org/show_bug.cgi?id=105415
+
+Reviewed by Pavel Feldman.
+
+Refactor |expanded| setters and getters into |collapse()|, |expand()|
+and |expanded()| methods
+
+* inspector/front-end/DefaultTextEditor.js:
+(WebInspector.TextEditorChunkedPanel.prototype._splitChunkOnALine):
+(WebInspector.TextEditorChunkedPanel.prototype._expandChunks):
+(WebInspector.TextEditorGutterPanel.prototype.textChanged):
+(WebInspector.TextEditorGutterChunk.prototype.expanded): Added.
+(WebInspector.TextEditorGutterChunk.prototype.collapse): Added.
+(WebInspector.TextEditorGutterChunk.prototype.expand): Added.
+(WebInspector.TextEditorMainPanel.prototype.markAndRevealRange):
+(WebInspector.TextEditorMainPanel.prototype._updateHighlightsForRange):
+(WebInspector.TextEditorMainChunk.prototype.expanded): Added.
+(WebInspector.TextEditorMainChunk.prototype.collapse): Added.
+(WebInspector.TextEditorMainChunk.prototype.expand): Added.
+
2012-12-19 Pan Deng pan.d...@intel.com
Web Inspector: Use Document* as argument in WebSocket Instrumentation.
Modified: trunk/Source/WebCore/inspector/front-end/DefaultTextEditor.js (138163 => 138164)
--- trunk/Source/WebCore/inspector/front-end/DefaultTextEditor.js 2012-12-19 15:43:16 UTC (rev 138163)
+++ trunk/Source/WebCore/inspector/front-end/DefaultTextEditor.js 2012-12-19 16:07:10 UTC (rev 138164)
@@ -778,8 +778,8 @@
this.beginDomUpdates();
var oldChunk = this._textChunks[chunkNumber];
-var wasExpanded = oldChunk.expanded;
-oldChunk.expanded = false;
+var wasExpanded = oldChunk.expanded();
+oldChunk.collapse();
var insertIndex = chunkNumber + 1;
@@ -809,10 +809,10 @@
if (wasExpanded) {
if (prefixChunk)
-prefixChunk.expanded = true;
-lineChunk.expanded = true;
+prefixChunk.expand();
+lineChunk.expand();
if (suffixChunk)
-suffixChunk.expanded = true;
+suffixChunk.expand();
}
this.endDomUpdates();
@@ -910,7 +910,7 @@
_findFirstVisibleLineNumber: function(visibleFrom)
{
var chunk = this._textChunks[this._findFirstVisibleChunkNumber(visibleFrom)];
-if (!chunk.expanded)
+if (!chunk.expanded())
return chunk.startLine;
var lineNumbers = [];
@@ -961,11 +961,11 @@
{
// First collapse chunks to collect the DOM elements into a cache to reuse them later.
for (var i = 0; i fromIndex; ++i)
-this._textChunks[i].expanded = false;
+this._textChunks[i].collapse();
for (var i = toIndex; i this._textChunks.length; ++i)
-this._textChunks[i].expanded = false;
+this._textChunks[i].collapse();
for (var i = fromIndex; i toIndex; ++i)
-this._textChunks[i].expanded = true;
+this._textChunks[i].expand();
},
/**
@@ -1052,7 +1052,7 @@
var chunk = this._textChunks[chunkNumber];
if (chunk.startLine + chunk.linesCount = this._textModel.linesCount)
break;
-chunk.expanded =
[webkit-changes] [138165] trunk
Title: [138165] trunk
Revision 138165
Author hay...@chromium.org
Date 2012-12-19 08:09:46 -0800 (Wed, 19 Dec 2012)
Log Message
Expose WebKitShadowRoot constructor to DOMWindow.
https://bugs.webkit.org/show_bug.cgi?id=105385
Reviewed by Dimitri Glazkov.
Source/WebCore:
This is a follow-up patch for r137870. WebKitShadowRoot
constructor should be in DOMWindow, just like all of the other
not-callable-constructors like HTMLDivElement, etc. We need it
for instanceof tests and so on.
Test: fast/dom/shadow/shadow-root-js-api.html
fast/js/global-constructors-expected.html
* page/DOMWindow.idl:
LayoutTests:
* fast/dom/shadow/shadow-root-js-api-expected.txt:
* fast/dom/shadow/shadow-root-js-api.html:
* fast/js/global-constructors-expected.txt:
* platform/efl/fast/js/global-constructors-expected.txt:
* platform/gtk/fast/js/global-constructors-expected.txt:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/dom/shadow/shadow-root-js-api-expected.txt
trunk/LayoutTests/fast/dom/shadow/shadow-root-js-api.html
trunk/LayoutTests/fast/js/global-constructors-expected.txt
trunk/LayoutTests/platform/efl/fast/js/global-constructors-expected.txt
trunk/LayoutTests/platform/gtk/fast/js/global-constructors-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/DOMWindow.idl
Diff
Modified: trunk/LayoutTests/ChangeLog (138164 => 138165)
--- trunk/LayoutTests/ChangeLog 2012-12-19 16:07:10 UTC (rev 138164)
+++ trunk/LayoutTests/ChangeLog 2012-12-19 16:09:46 UTC (rev 138165)
@@ -1,3 +1,16 @@
+2012-12-19 Hayato Ito hay...@chromium.org
+
+Expose WebKitShadowRoot constructor to DOMWindow.
+https://bugs.webkit.org/show_bug.cgi?id=105385
+
+Reviewed by Dimitri Glazkov.
+
+* fast/dom/shadow/shadow-root-js-api-expected.txt:
+* fast/dom/shadow/shadow-root-js-api.html:
+* fast/js/global-constructors-expected.txt:
+* platform/efl/fast/js/global-constructors-expected.txt:
+* platform/gtk/fast/js/global-constructors-expected.txt:
+
2012-12-19 Tim Volodine timvolod...@chromium.org
Text Autosizing: Work out what to do about form controls
Modified: trunk/LayoutTests/fast/dom/shadow/shadow-root-js-api-expected.txt (138164 => 138165)
--- trunk/LayoutTests/fast/dom/shadow/shadow-root-js-api-expected.txt 2012-12-19 16:07:10 UTC (rev 138164)
+++ trunk/LayoutTests/fast/dom/shadow/shadow-root-js-api-expected.txt 2012-12-19 16:09:46 UTC (rev 138165)
@@ -3,6 +3,10 @@
On success, you will see a series of PASS messages, followed by TEST COMPLETE.
+PASS window.ShadowRoot is undefined.
+PASS window.WebKitShadowRoot is defined.
+PASS new window.WebKitShadowRoot(document.createElement('div')) threw exception TypeError: Illegal constructor.
+PASS shadowRoot instanceof window.WebKitShadowRoot is true
PASS shadowRoot.getElementById('div1') is div1
PASS shadowRoot.getElementById('foo') is null
PASS shadowRoot.getElementsByClassName('class2') is [div2]
Modified: trunk/LayoutTests/fast/dom/shadow/shadow-root-js-api.html (138164 => 138165)
--- trunk/LayoutTests/fast/dom/shadow/shadow-root-js-api.html 2012-12-19 16:07:10 UTC (rev 138164)
+++ trunk/LayoutTests/fast/dom/shadow/shadow-root-js-api.html 2012-12-19 16:09:46 UTC (rev 138165)
@@ -14,10 +14,17 @@
if (window.testRunner)
testRunner.dumpAsText();
+
+shouldBeUndefined(window.ShadowRoot);
+shouldBeDefined(window.WebKitShadowRoot);
+shouldThrow(new window.WebKitShadowRoot(document.createElement('div')));
+
var shadowHost = document.createElement('div');
document.body.appendChild(shadowHost);
var shadowRoot = shadowHost.webkitCreateShadowRoot();
+shouldBeTrue(shadowRoot instanceof window.WebKitShadowRoot);
+
var div1 = document.createElement(div);
div1.setAttribute(id, div1);
shadowRoot.appendChild(div1);
Modified: trunk/LayoutTests/fast/js/global-constructors-expected.txt (138164 => 138165)
--- trunk/LayoutTests/fast/js/global-constructors-expected.txt 2012-12-19 16:07:10 UTC (rev 138164)
+++ trunk/LayoutTests/fast/js/global-constructors-expected.txt 2012-12-19 16:09:46 UTC (rev 138165)
@@ -329,6 +329,7 @@
FAIL WebKitIntent.toString() should be [object WebKitIntentConstructor]. Was [object IntentConstructor].
FAIL WebKitMutationObserver.toString() should be [object WebKitMutationObserverConstructor]. Was [object MutationObserverConstructor].
PASS WebKitPoint.toString() is '[object WebKitPointConstructor]'
+FAIL WebKitShadowRoot.toString() should be [object WebKitShadowRootConstructor]. Was [object ShadowRootConstructor].
PASS WebKitTransitionEvent.toString() is '[object WebKitTransitionEventConstructor]'
PASS WebSocket.toString() is '[object WebSocketConstructor]'
PASS WheelEvent.toString() is '[object WheelEventConstructor]'
Modified: trunk/LayoutTests/platform/efl/fast/js/global-constructors-expected.txt (138164 => 138165)
--- trunk/LayoutTests/platform/efl/fast/js/global-constructors-expected.txt 2012-12-19 16:07:10 UTC (rev 138164)
+++
[webkit-changes] [138166] trunk/Source/WebCore
Title: [138166] trunk/Source/WebCore
Revision 138166
Author pfeld...@chromium.org
Date 2012-12-19 08:23:36 -0800 (Wed, 19 Dec 2012)
Log Message
Web Inspector: default font on mac is Monaco (should do be Menlo)
https://bugs.webkit.org/show_bug.cgi?id=105435
Reviewed by Alexander Pavlov.
Regressed when I introduced mountain lion modifier in the inspector.css.
* inspector/front-end/inspector.css:
(body.platform-mac .monospace, body.platform-mac .source-code):
(body.platform-mac.platform-mac-tiger .source-code):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/inspector.css
Diff
Modified: trunk/Source/WebCore/ChangeLog (138165 => 138166)
--- trunk/Source/WebCore/ChangeLog 2012-12-19 16:09:46 UTC (rev 138165)
+++ trunk/Source/WebCore/ChangeLog 2012-12-19 16:23:36 UTC (rev 138166)
@@ -1,3 +1,16 @@
+2012-12-19 Pavel Feldman pfeld...@chromium.org
+
+Web Inspector: default font on mac is Monaco (should do be Menlo)
+https://bugs.webkit.org/show_bug.cgi?id=105435
+
+Reviewed by Alexander Pavlov.
+
+Regressed when I introduced mountain lion modifier in the inspector.css.
+
+* inspector/front-end/inspector.css:
+(body.platform-mac .monospace, body.platform-mac .source-code):
+(body.platform-mac.platform-mac-tiger .source-code):
+
2012-12-19 Hayato Ito hay...@chromium.org
Expose WebKitShadowRoot constructor to DOMWindow.
Modified: trunk/Source/WebCore/inspector/front-end/inspector.css (138165 => 138166)
--- trunk/Source/WebCore/inspector/front-end/inspector.css 2012-12-19 16:09:46 UTC (rev 138165)
+++ trunk/Source/WebCore/inspector/front-end/inspector.css 2012-12-19 16:23:36 UTC (rev 138166)
@@ -874,16 +874,16 @@
}
body.platform-mac .monospace, body.platform-mac .source-code {
-font-family: Monaco, monospace;
-}
-
-/* Keep .platform-mac to make the rule more specific than the general one above. */
-body.platform-mac.platform-mac-snowleopard .monospace,
-body.platform-mac.platform-mac-snowleopard .source-code {
font-size: 11px !important;
font-family: Menlo, monospace;
}
+body.platform-mac.platform-mac-tiger .monospace,
+body.platform-mac.platform-mac-tiger .source-code {
+font-size: 10px !important;
+font-family: Monaco, monospace;
+}
+
body.platform-windows .monospace, body.platform-windows .source-code {
font-size: 12px !important;
font-family: Consolas, Lucida Console, monospace;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [138167] trunk/Source/WebCore
Title: [138167] trunk/Source/WebCore Revision 138167 Author zandober...@gmail.com Date 2012-12-19 08:33:52 -0800 (Wed, 19 Dec 2012) Log Message [GTK] Enable Navigation Timing by default https://bugs.webkit.org/show_bug.cgi?id=105322 Reviewed by Martin Robinson. The Navigation Timing specification (of which implementation is guarder by the ENABLE_WEB_TIMING feature define) has been promoted to the W3C Recommendation status. Because of this we should enable it by default in the release builds of the GTK port. No new tests - they already exist and are in majority passing. * GNUmakefile.am: * bindings/gobject/GNUmakefile.am: Move the DOM bindings for interfaces related to this feature out of the unstable features define guard and into the general list. Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/GNUmakefile.am trunk/Source/WebCore/bindings/gobject/GNUmakefile.am Diff Modified: trunk/Source/WebCore/ChangeLog (138166 => 138167) --- trunk/Source/WebCore/ChangeLog 2012-12-19 16:23:36 UTC (rev 138166) +++ trunk/Source/WebCore/ChangeLog 2012-12-19 16:33:52 UTC (rev 138167) @@ -1,3 +1,21 @@ +2012-12-19 Zan Dobersek zandober...@gmail.com + +[GTK] Enable Navigation Timing by default +https://bugs.webkit.org/show_bug.cgi?id=105322 + +Reviewed by Martin Robinson. + +The Navigation Timing specification (of which implementation is guarder +by the ENABLE_WEB_TIMING feature define) has been promoted to the W3C Recommendation +status. Because of this we should enable it by default in the release builds of +the GTK port. + +No new tests - they already exist and are in majority passing. + +* GNUmakefile.am: +* bindings/gobject/GNUmakefile.am: Move the DOM bindings for interfaces related to this +feature out of the unstable features define guard and into the general list. + 2012-12-19 Pavel Feldman pfeld...@chromium.org Web Inspector: default font on mac is Monaco (should do be Menlo) Modified: trunk/Source/WebCore/GNUmakefile.am (138166 => 138167) --- trunk/Source/WebCore/GNUmakefile.am 2012-12-19 16:23:36 UTC (rev 138166) +++ trunk/Source/WebCore/GNUmakefile.am 2012-12-19 16:33:52 UTC (rev 138167) @@ -346,8 +346,7 @@ ENABLE_MICRODATA=0 \ ENABLE_MUTATION_OBSERVERS=0 \ ENABLE_STYLE_SCOPED=0 \ - ENABLE_VIDEO_TRACK=0 \ - ENABLE_WEB_TIMING=0 + ENABLE_VIDEO_TRACK=0 endif Modified: trunk/Source/WebCore/bindings/gobject/GNUmakefile.am (138166 => 138167) --- trunk/Source/WebCore/bindings/gobject/GNUmakefile.am 2012-12-19 16:23:36 UTC (rev 138166) +++ trunk/Source/WebCore/bindings/gobject/GNUmakefile.am 2012-12-19 16:33:52 UTC (rev 138167) @@ -229,6 +229,12 @@ DerivedSources/webkitdom/WebKitDOMNodeList.cpp \ DerivedSources/webkitdom/WebKitDOMNodeListPrivate.h \ DerivedSources/webkitdom/WebKitDOMNodePrivate.h \ + DerivedSources/webkitdom/WebKitDOMPerformance.cpp \ + DerivedSources/webkitdom/WebKitDOMPerformancePrivate.h \ + DerivedSources/webkitdom/WebKitDOMPerformanceNavigation.cpp \ + DerivedSources/webkitdom/WebKitDOMPerformanceNavigationPrivate.h \ + DerivedSources/webkitdom/WebKitDOMPerformanceTiming.cpp \ + DerivedSources/webkitdom/WebKitDOMPerformanceTimingPrivate.h \ DerivedSources/webkitdom/WebKitDOMProcessingInstruction.cpp \ DerivedSources/webkitdom/WebKitDOMProcessingInstructionPrivate.h \ DerivedSources/webkitdom/WebKitDOMPropertyNodeList.cpp \ @@ -408,6 +414,9 @@ DerivedSources/webkitdom/WebKitDOMXPathExpression.h \ DerivedSources/webkitdom/WebKitDOMXPathNSResolver.h \ DerivedSources/webkitdom/WebKitDOMXPathResult.h \ + DerivedSources/webkitdom/WebKitDOMPerformance.h \ + DerivedSources/webkitdom/WebKitDOMPerformanceNavigation.h \ + DerivedSources/webkitdom/WebKitDOMPerformanceTiming.h \ DerivedSources/webkitdom/webkitdom.h \ DerivedSources/webkitdom/webkitdomdefines.h @@ -443,21 +452,6 @@ endif endif -# Web Timing feature is currently considered unstable. -if ENABLE_UNSTABLE_FEATURES -webkitgtk_gdom_built_h_api += \ - $(top_builddir)/DerivedSources/webkitdom/WebKitDOMPerformance.h \ - $(top_builddir)/DerivedSources/webkitdom/WebKitDOMPerformanceNavigation.h \ - $(top_builddir)/DerivedSources/webkitdom/WebKitDOMPerformanceTiming.h -webkitgtk_gdom_built_sources += \ - DerivedSources/webkitdom/WebKitDOMPerformance.cpp \ - DerivedSources/webkitdom/WebKitDOMPerformancePrivate.h \ - DerivedSources/webkitdom/WebKitDOMPerformanceNavigation.cpp \ - DerivedSources/webkitdom/WebKitDOMPerformanceNavigationPrivate.h \ - DerivedSources/webkitdom/WebKitDOMPerformanceTiming.cpp \ - DerivedSources/webkitdom/WebKitDOMPerformanceTimingPrivate.h -endif - BUILT_SOURCES += \ $(webkitgtk_gdom_built_h_api) \ $(webkitgtk_gdom_built_sources) ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [138169] trunk
Title: [138169] trunk
Revision 138169
Author commit-qu...@webkit.org
Date 2012-12-19 09:10:44 -0800 (Wed, 19 Dec 2012)
Log Message
Unable to place the caret at the end of the first line, when followed by a block, in the vertical writing mode.
https://bugs.webkit.org/show_bug.cgi?id=104794
Patch by Arpita Bahuguna arpitabahug...@gmail.com on 2012-12-19
Reviewed by Ryosuke Niwa.
Source/WebCore:
In the vertical writing mode, when trying to place the caret at the end
of a text line which is followed by a block, the local point sent as
part of the hitTest result in the mouse click event is not correct.
When clicking on the empty region (beyond the text) in the first line,
the local point computed is not in accordance with the writing mode.
Test: editing/selection/caret-at-end-of-text-line-followed-by-block-in-vertical-mode.html
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::nodeAtPoint):
Modified the code to handle the point as per the writing mode when
computing the hitTest result. Calling flipForWritingMode() on the
point for achieving the same.
LayoutTests:
* editing/selection/caret-at-end-of-text-line-followed-by-block-in-vertical-mode-expected.txt: Added.
* editing/selection/caret-at-end-of-text-line-followed-by-block-in-vertical-mode.html: Added.
Test added for verifying that a caret is painted at the end of the text
in the first vertical line, when followed by a block.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderBlock.cpp
Added Paths
trunk/LayoutTests/editing/selection/caret-at-end-of-text-line-followed-by-block-in-vertical-mode-expected.txt
trunk/LayoutTests/editing/selection/caret-at-end-of-text-line-followed-by-block-in-vertical-mode.html
Diff
Modified: trunk/LayoutTests/ChangeLog (138168 => 138169)
--- trunk/LayoutTests/ChangeLog 2012-12-19 16:40:10 UTC (rev 138168)
+++ trunk/LayoutTests/ChangeLog 2012-12-19 17:10:44 UTC (rev 138169)
@@ -1,3 +1,15 @@
+2012-12-19 Arpita Bahuguna arpitabahug...@gmail.com
+
+Unable to place the caret at the end of the first line, when followed by a block, in the vertical writing mode.
+https://bugs.webkit.org/show_bug.cgi?id=104794
+
+Reviewed by Ryosuke Niwa.
+
+* editing/selection/caret-at-end-of-text-line-followed-by-block-in-vertical-mode-expected.txt: Added.
+* editing/selection/caret-at-end-of-text-line-followed-by-block-in-vertical-mode.html: Added.
+Test added for verifying that a caret is painted at the end of the text
+in the first vertical line, when followed by a block.
+
2012-12-19 Hayato Ito hay...@chromium.org
Expose WebKitShadowRoot constructor to DOMWindow.
Added: trunk/LayoutTests/editing/selection/caret-at-end-of-text-line-followed-by-block-in-vertical-mode-expected.txt (0 => 138169)
--- trunk/LayoutTests/editing/selection/caret-at-end-of-text-line-followed-by-block-in-vertical-mode-expected.txt (rev 0)
+++ trunk/LayoutTests/editing/selection/caret-at-end-of-text-line-followed-by-block-in-vertical-mode-expected.txt 2012-12-19 17:10:44 UTC (rev 138169)
@@ -0,0 +1,12 @@
+Some text.
+Testcase for bug 104794: Unable to place the caret at the end of the first line, when followed by a block, in the vertical writing mode. To manually verify the issue, try clicking on the empty region of the first vertical line. The caret should be drawn at the end of the text.
+
+On success, you will see a series of PASS messages, followed by TEST COMPLETE.
+
+PASS caretRectAtEnd.left is caretRectAtStart.left
+PASS caretRectAtEnd.width is caretRectAtStart.width
+PASS caretRectAtEnd.height is caretRectAtStart.height
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
Added: trunk/LayoutTests/editing/selection/caret-at-end-of-text-line-followed-by-block-in-vertical-mode.html (0 => 138169)
--- trunk/LayoutTests/editing/selection/caret-at-end-of-text-line-followed-by-block-in-vertical-mode.html (rev 0)
+++ trunk/LayoutTests/editing/selection/caret-at-end-of-text-line-followed-by-block-in-vertical-mode.html 2012-12-19 17:10:44 UTC (rev 138169)
@@ -0,0 +1,40 @@
+!DOCTYPE html
+html
+head
+style
+#textDiv {
+height: 100px;
+width: 100px;
+border: 1px solid black;
+-webkit-writing-mode: vertical-rl;
+}
+/style
+script src=""
+/head
+body
+div id=textDiv contenteditable=trueSome text.p/p/div
+div id=description/div
+div id=console/div
+script
+description('Testcase for bug a href="" Unable to place the caret at the end of the first line, when followed by a block, in the vertical writing mode.\nTo manually verify the issue, try clicking on the empty region of the first vertical line. The caret should be drawn at the end of the text.');
+
+if (window.internals) {
+var testDiv = document.getElementById('textDiv');
+eventSender.mouseMoveTo(testDiv.offsetLeft + testDiv.offsetWidth - 5, testDiv.offsetTop);
+eventSender.mouseDown();
+
[webkit-changes] [138171] trunk/LayoutTests
Title: [138171] trunk/LayoutTests Revision 138171 Author zandober...@gmail.com Date 2012-12-19 09:21:13 -0800 (Wed, 19 Dec 2012) Log Message Unreviewed GTK gardening. Rebaselining two tests after r137953 and r138102. Updating test expectations as necessary. * platform/gtk/TestExpectations: * platform/gtk/editing/selection/move-by-character-6-expected.txt: * platform/gtk/fast/css/image-set-value-not-removed-crash-expected.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/gtk/TestExpectations trunk/LayoutTests/platform/gtk/editing/selection/move-by-character-6-expected.txt trunk/LayoutTests/platform/gtk/fast/css/image-set-value-not-removed-crash-expected.txt Diff Modified: trunk/LayoutTests/ChangeLog (138170 => 138171) --- trunk/LayoutTests/ChangeLog 2012-12-19 17:16:46 UTC (rev 138170) +++ trunk/LayoutTests/ChangeLog 2012-12-19 17:21:13 UTC (rev 138171) @@ -1,3 +1,14 @@ +2012-12-19 Zan Dobersek zandober...@gmail.com + +Unreviewed GTK gardening. + +Rebaselining two tests after r137953 and r138102. +Updating test expectations as necessary. + +* platform/gtk/TestExpectations: +* platform/gtk/editing/selection/move-by-character-6-expected.txt: +* platform/gtk/fast/css/image-set-value-not-removed-crash-expected.txt: + 2012-12-19 Arpita Bahuguna arpitabahug...@gmail.com Unable to place the caret at the end of the first line, when followed by a block, in the vertical writing mode. Modified: trunk/LayoutTests/platform/gtk/TestExpectations (138170 => 138171) --- trunk/LayoutTests/platform/gtk/TestExpectations 2012-12-19 17:16:46 UTC (rev 138170) +++ trunk/LayoutTests/platform/gtk/TestExpectations 2012-12-19 17:21:13 UTC (rev 138171) @@ -454,7 +454,7 @@ # No support for exposing in-band text tracks webkit.org/b/103771 media/track/track-in-band.html [ Failure ] -webkit.org/b/103771 media/track/track-in-band-cues-added-once.html [ Failure ] +webkit.org/b/103771 media/track/track-in-band-cues-added-once.html [ Timeout ] # # End of Expected failures @@ -1128,7 +1128,7 @@ # This test is out-dated since r95899. webkit.org/b/65709 canvas/philip/tests/2d.drawImage.outsidesource.html [ Failure ] -Bug(GTK) http/tests/multipart/multipart-wait-before-boundary.html [ Failure Timeout Pass Slow ] +Bug(GTK) http/tests/multipart/multipart-wait-before-boundary.html [ Failure Pass Slow ] # Does not render the rectangle as it should, even though the multiple parts seem to work webkit.org/b/54251 http/tests/multipart/invalid-image-data.html [ Timeout ] Modified: trunk/LayoutTests/platform/gtk/editing/selection/move-by-character-6-expected.txt (138170 => 138171) --- trunk/LayoutTests/platform/gtk/editing/selection/move-by-character-6-expected.txt 2012-12-19 17:16:46 UTC (rev 138170) +++ trunk/LayoutTests/platform/gtk/editing/selection/move-by-character-6-expected.txt 2012-12-19 17:21:13 UTC (rev 138171) @@ -1,3 +1,5 @@ +EDITING DELEGATE: shouldBeginEditingInDOMRange:range from 0 of DIV BODY HTML #document to 3 of DIV BODY HTML #document +EDITING DELEGATE: webViewDidBeginEditing:WebViewDidBeginEditingNotification EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification Modified: trunk/LayoutTests/platform/gtk/fast/css/image-set-value-not-removed-crash-expected.txt (138170 => 138171) --- trunk/LayoutTests/platform/gtk/fast/css/image-set-value-not-removed-crash-expected.txt 2012-12-19 17:16:46 UTC (rev 138170) +++ trunk/LayoutTests/platform/gtk/fast/css/image-set-value-not-removed-crash-expected.txt 2012-12-19 17:21:13 UTC (rev 138171) @@ -1 +1 @@ -PASS. WebKit didn't crash. +PASS. WebKit did not crash. ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [138172] trunk/LayoutTests
Title: [138172] trunk/LayoutTests
Revision 138172
Author dominik.rottsc...@intel.com
Date 2012-12-19 09:22:27 -0800 (Wed, 19 Dec 2012)
Log Message
[EFL] Unreviewed gardening.
Adding platform specific expectations since our error msg is chattier,
test was introduced in r138165.
Also, marking a crash failure.
* platform/efl/TestExpectations:
* platform/efl/fast/dom/shadow/shadow-root-js-api-expected.txt: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/efl/TestExpectations
Added Paths
trunk/LayoutTests/platform/efl/fast/dom/shadow/shadow-root-js-api-expected.txt
Diff
Modified: trunk/LayoutTests/ChangeLog (138171 => 138172)
--- trunk/LayoutTests/ChangeLog 2012-12-19 17:21:13 UTC (rev 138171)
+++ trunk/LayoutTests/ChangeLog 2012-12-19 17:22:27 UTC (rev 138172)
@@ -1,3 +1,14 @@
+2012-12-19 Dominik Röttsches dominik.rottsc...@intel.com
+
+[EFL] Unreviewed gardening.
+
+Adding platform specific expectations since our error msg is chattier,
+test was introduced in r138165.
+Also, marking a crash failure.
+
+* platform/efl/TestExpectations:
+* platform/efl/fast/dom/shadow/shadow-root-js-api-expected.txt: Added.
+
2012-12-19 Zan Dobersek zandober...@gmail.com
Unreviewed GTK gardening.
Modified: trunk/LayoutTests/platform/efl/TestExpectations (138171 => 138172)
--- trunk/LayoutTests/platform/efl/TestExpectations 2012-12-19 17:21:13 UTC (rev 138171)
+++ trunk/LayoutTests/platform/efl/TestExpectations 2012-12-19 17:22:27 UTC (rev 138172)
@@ -744,6 +744,8 @@
webkit.org/b/102928 svg/foreignObject/viewport-foreignobject-crash.html [ Crash Failure Pass ]
+webkit.org/b/105444 fast/selectors/querySelector-in-range-crash.html [ Crash Pass ]
+
# Issue with timing for suspend/resumeAnimations()?
webkit.org/b/49182 animations/stop-animation-on-suspend.html [ Failure Pass ]
Added: trunk/LayoutTests/platform/efl/fast/dom/shadow/shadow-root-js-api-expected.txt (0 => 138172)
--- trunk/LayoutTests/platform/efl/fast/dom/shadow/shadow-root-js-api-expected.txt (rev 0)
+++ trunk/LayoutTests/platform/efl/fast/dom/shadow/shadow-root-js-api-expected.txt 2012-12-19 17:22:27 UTC (rev 138172)
@@ -0,0 +1,29 @@
+Tests for ShadowRoot JS APIs. Can only run within DRT
+
+On success, you will see a series of PASS messages, followed by TEST COMPLETE.
+
+
+PASS window.ShadowRoot is undefined.
+PASS window.WebKitShadowRoot is defined.
+PASS new window.WebKitShadowRoot(document.createElement('div')) threw exception TypeError: '[object ShadowRootConstructor]' is not a constructor (evaluating 'new window.WebKitShadowRoot(document.createElement('div'))').
+PASS shadowRoot instanceof window.WebKitShadowRoot is true
+PASS shadowRoot.getElementById('div1') is div1
+PASS shadowRoot.getElementById('foo') is null
+PASS shadowRoot.getElementsByClassName('class2') is [div2]
+PASS shadowRoot.getElementsByClassName('foo') is []
+PASS shadowRoot.getElementsByTagName('div') is [div1, div2]
+PASS shadowRoot.getElementsByTagName('foo') is []
+PASS shadowRoot.getElementsByTagNameNS('*', 'div') is [div1, div2]
+PASS shadowRoot.getElementsByTagNameNS('', 'div') is []
+PASS shadowRoot.getElementsByTagNameNS('*', 'foo') is []
+PASS shadowRoot.querySelector('#div1') is div1
+PASS shadowRoot.querySelector('#foo') is null
+PASS shadowRoot.querySelector('.class2') is div2
+PASS shadowRoot.querySelector('.foo') is null
+PASS shadowRoot.querySelectorAll('div') is [div1, div2]
+PASS shadowRoot.querySelectorAll('foo') is []
+PASS youngerShadowRoot is not shadowRoot
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [138173] trunk/Source
Title: [138173] trunk/Source
Revision 138173
Author gav...@chromium.org
Date 2012-12-19 09:23:03 -0800 (Wed, 19 Dec 2012)
Log Message
[chromium] WebCore::Prerender::didStartPrerender depends on LinkLoader
https://bugs.webkit.org/show_bug.cgi?id=105290
Reviewed by Abhishek Arya.
The LinkLoader now removes itself from its prerender in time.
Source/WebCore:
Tested in unit tests, PrerenderingTest.FastRemoveElement.
* loader/LinkLoader.cpp:
(WebCore::LinkLoader::~LinkLoader):
(WebCore::LinkLoader::released):
Source/WebKit/chromium:
* tests/PrerenderingTest.cpp:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/loader/LinkLoader.cpp
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/tests/PrerenderingTest.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (138172 => 138173)
--- trunk/Source/WebCore/ChangeLog 2012-12-19 17:22:27 UTC (rev 138172)
+++ trunk/Source/WebCore/ChangeLog 2012-12-19 17:23:03 UTC (rev 138173)
@@ -1,3 +1,18 @@
+2012-12-19 Gavin Peters gav...@chromium.org
+
+[chromium] WebCore::Prerender::didStartPrerender depends on LinkLoader
+https://bugs.webkit.org/show_bug.cgi?id=105290
+
+Reviewed by Abhishek Arya.
+
+The LinkLoader now removes itself from its prerender in time.
+
+Tested in unit tests, PrerenderingTest.FastRemoveElement.
+
+* loader/LinkLoader.cpp:
+(WebCore::LinkLoader::~LinkLoader):
+(WebCore::LinkLoader::released):
+
2012-12-19 Brian Salomon bsalo...@google.com
[Chromium/Skia] Check whether bitmap has pixels in image encoders
Modified: trunk/Source/WebCore/loader/LinkLoader.cpp (138172 => 138173)
--- trunk/Source/WebCore/loader/LinkLoader.cpp 2012-12-19 17:22:27 UTC (rev 138172)
+++ trunk/Source/WebCore/loader/LinkLoader.cpp 2012-12-19 17:23:03 UTC (rev 138173)
@@ -63,6 +63,10 @@
{
if (m_cachedLinkResource)
m_cachedLinkResource-removeClient(this);
+#if ENABLE(LINK_PRERENDER)
+if (m_prerenderHandle)
+m_prerenderHandle-removeClient();
+#endif
}
void LinkLoader::linkLoadTimerFired(TimerLinkLoader* timer)
@@ -172,6 +176,7 @@
#if ENABLE(LINK_PRERENDER)
if (m_prerenderHandle) {
m_prerenderHandle-cancel();
+m_prerenderHandle-removeClient();
m_prerenderHandle.clear();
}
#endif
Modified: trunk/Source/WebKit/chromium/ChangeLog (138172 => 138173)
--- trunk/Source/WebKit/chromium/ChangeLog 2012-12-19 17:22:27 UTC (rev 138172)
+++ trunk/Source/WebKit/chromium/ChangeLog 2012-12-19 17:23:03 UTC (rev 138173)
@@ -1,3 +1,14 @@
+2012-12-19 Gavin Peters gav...@chromium.org
+
+[chromium] WebCore::Prerender::didStartPrerender depends on LinkLoader
+https://bugs.webkit.org/show_bug.cgi?id=105290
+
+Reviewed by Abhishek Arya.
+
+The LinkLoader now removes itself from its prerender in time.
+
+* tests/PrerenderingTest.cpp:
+
2012-12-18 Ilya Tikhonovsky loi...@chromium.org
Unreviewed, rolling out r138061.
Modified: trunk/Source/WebKit/chromium/tests/PrerenderingTest.cpp (138172 => 138173)
--- trunk/Source/WebKit/chromium/tests/PrerenderingTest.cpp 2012-12-19 17:22:27 UTC (rev 138172)
+++ trunk/Source/WebKit/chromium/tests/PrerenderingTest.cpp 2012-12-19 17:23:03 UTC (rev 138173)
@@ -437,4 +437,23 @@
webPrerender.didStartPrerender();
}
+TEST_F(PrerenderingTest, FastRemoveElement)
+{
+initialize(http://www.foo.com/, prerender/single_prerender.html);
+
+WebPrerender webPrerender = prerendererClient()-releaseWebPrerender();
+EXPECT_FALSE(webPrerender.isNull());
+
+EXPECT_EQ(1u, prerenderingSupport()-addCount(webPrerender));
+EXPECT_EQ(1u, prerenderingSupport()-totalCount());
+
+// Race removing starting the prerender against each other, as if the element was removed very quickly.
+executeScript(removePrerender());
+EXPECT_FALSE(webPrerender.isNull());
+webPrerender.didStartPrerender();
+
+// The page should be totally disconnected from the Prerender at this point, so the console should not have updated.
+EXPECT_EQ(0u, consoleLength());
+}
+
} // namespace
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [138174] trunk/Source/WebCore
Title: [138174] trunk/Source/WebCore
Revision 138174
Author jap...@chromium.org
Date 2012-12-19 09:38:48 -0800 (Wed, 19 Dec 2012)
Log Message
REGRESSION(r137607): PluginDocument loads consume huge amounts of memory
https://bugs.webkit.org/show_bug.cgi?id=105359
Reviewed by Alexey Proskuryakov.
No new tests, verified manually that http://www.scb.se/statistik/_publikationer/NR0001_2012K02_TI_A28TI1203.pdf
no longer consumes several GB of memory.
* loader/ResourceLoader.cpp:
(WebCore::ResourceLoader::setShouldBufferData): shouldBufferData is an enum, not a boolean, so this is reversed.
* loader/cache/CachedRawResource.cpp:
(WebCore::CachedRawResource::data): If the dataReceived() callback tells us to stop buffering data, be sure to
notify the ResourceLoader and clear the data buffer.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/loader/ResourceLoader.cpp
trunk/Source/WebCore/loader/cache/CachedRawResource.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (138173 => 138174)
--- trunk/Source/WebCore/ChangeLog 2012-12-19 17:23:03 UTC (rev 138173)
+++ trunk/Source/WebCore/ChangeLog 2012-12-19 17:38:48 UTC (rev 138174)
@@ -1,3 +1,19 @@
+2012-12-19 Nate Chapin jap...@chromium.org
+
+REGRESSION(r137607): PluginDocument loads consume huge amounts of memory
+https://bugs.webkit.org/show_bug.cgi?id=105359
+
+Reviewed by Alexey Proskuryakov.
+
+No new tests, verified manually that http://www.scb.se/statistik/_publikationer/NR0001_2012K02_TI_A28TI1203.pdf
+no longer consumes several GB of memory.
+
+* loader/ResourceLoader.cpp:
+(WebCore::ResourceLoader::setShouldBufferData): shouldBufferData is an enum, not a boolean, so this is reversed.
+* loader/cache/CachedRawResource.cpp:
+(WebCore::CachedRawResource::data): If the dataReceived() callback tells us to stop buffering data, be sure to
+notify the ResourceLoader and clear the data buffer.
+
2012-12-19 Gavin Peters gav...@chromium.org
[chromium] WebCore::Prerender::didStartPrerender depends on LinkLoader
Modified: trunk/Source/WebCore/loader/ResourceLoader.cpp (138173 => 138174)
--- trunk/Source/WebCore/loader/ResourceLoader.cpp 2012-12-19 17:23:03 UTC (rev 138173)
+++ trunk/Source/WebCore/loader/ResourceLoader.cpp 2012-12-19 17:38:48 UTC (rev 138174)
@@ -194,7 +194,7 @@
m_options.shouldBufferData = shouldBufferData;
// Reset any already buffered data
-if (!shouldBufferData)
+if (shouldBufferData == DoNotBufferData)
m_resourceData = 0;
}
Modified: trunk/Source/WebCore/loader/cache/CachedRawResource.cpp (138173 => 138174)
--- trunk/Source/WebCore/loader/cache/CachedRawResource.cpp 2012-12-19 17:23:03 UTC (rev 138173)
+++ trunk/Source/WebCore/loader/cache/CachedRawResource.cpp 2012-12-19 17:38:48 UTC (rev 138174)
@@ -56,19 +56,26 @@
incrementalData = data-data() + previousDataLength;
incrementalDataLength = data-size() - previousDataLength;
}
-
+
if (m_options.shouldBufferData == BufferData) {
if (data)
setEncodedSize(data-size());
m_data = data;
}
-
+
+DataBufferingPolicy dataBufferingPolicy = m_options.shouldBufferData;
if (incrementalDataLength) {
CachedResourceClientWalkerCachedRawResourceClient w(m_clients);
while (CachedRawResourceClient* c = w.next())
c-dataReceived(this, incrementalData, incrementalDataLength);
}
CachedResource::data(m_data, allDataReceived);
+
+if (dataBufferingPolicy == BufferData m_options.shouldBufferData == DoNotBufferData) {
+if (m_loader)
+m_loader-setShouldBufferData(DoNotBufferData);
+clear();
+}
}
void CachedRawResource::didAddClient(CachedResourceClient* c)
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [138175] trunk
Title: [138175] trunk Revision 138175 Author dmazz...@google.com Date 2012-12-19 09:42:35 -0800 (Wed, 19 Dec 2012) Log Message Support titleUIElement in chromium DRT https://bugs.webkit.org/show_bug.cgi?id=96529 Reviewed by Chris Fleizach. Source/WebKit/chromium: Fix implementation of titleUIElement - it shouldn't return anything if supportsTitleUIElement returns false, so that accessible label overriding logic works correctly. * src/WebAccessibilityObject.cpp: (WebKit::WebAccessibilityObject::titleUIElement): LayoutTests: Modify aria-labelledby-overrides-label.html to be more cross-platform, with slightly different expectations on Mac Chromium. * accessibility/aria-labelledby-overrides-label.html: * platform/chromium/TestExpectations: * platform/chromium/accessibility/aria-labelledby-overrides-label-expected.txt: Copied from LayoutTests/accessibility/aria-labelledby-overrides-label-expected.txt. * platform/mac/accessibility/aria-labelledby-overrides-label-expected.txt: Renamed from LayoutTests/accessibility/aria-labelledby-overrides-label-expected.txt. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/accessibility/aria-labelledby-overrides-label.html trunk/LayoutTests/platform/chromium/TestExpectations trunk/Source/WebKit/chromium/ChangeLog trunk/Source/WebKit/chromium/src/WebAccessibilityObject.cpp Added Paths trunk/LayoutTests/platform/chromium/accessibility/aria-labelledby-overrides-label-expected.txt trunk/LayoutTests/platform/mac/accessibility/aria-labelledby-overrides-label-expected.txt Removed Paths trunk/LayoutTests/accessibility/aria-labelledby-overrides-label-expected.txt Diff Modified: trunk/LayoutTests/ChangeLog (138174 => 138175) --- trunk/LayoutTests/ChangeLog 2012-12-19 17:38:48 UTC (rev 138174) +++ trunk/LayoutTests/ChangeLog 2012-12-19 17:42:35 UTC (rev 138175) @@ -1,3 +1,18 @@ +2012-12-19 Dominic Mazzoni dmazz...@google.com + +Support titleUIElement in chromium DRT +https://bugs.webkit.org/show_bug.cgi?id=96529 + +Reviewed by Chris Fleizach. + +Modify aria-labelledby-overrides-label.html to be more cross-platform, +with slightly different expectations on Mac Chromium. + +* accessibility/aria-labelledby-overrides-label.html: +* platform/chromium/TestExpectations: +* platform/chromium/accessibility/aria-labelledby-overrides-label-expected.txt: Copied from LayoutTests/accessibility/aria-labelledby-overrides-label-expected.txt. +* platform/mac/accessibility/aria-labelledby-overrides-label-expected.txt: Renamed from LayoutTests/accessibility/aria-labelledby-overrides-label-expected.txt. + 2012-12-19 Dominik Röttsches dominik.rottsc...@intel.com [EFL] Unreviewed gardening. Deleted: trunk/LayoutTests/accessibility/aria-labelledby-overrides-label-expected.txt (138174 => 138175) --- trunk/LayoutTests/accessibility/aria-labelledby-overrides-label-expected.txt 2012-12-19 17:38:48 UTC (rev 138174) +++ trunk/LayoutTests/accessibility/aria-labelledby-overrides-label-expected.txt 2012-12-19 17:42:35 UTC (rev 138175) @@ -1,13 +0,0 @@ -Shut down computer after minutes -This tests that if aria-labelledby is used, then label elements are not used - -On success, you will see a series of PASS messages, followed by TEST COMPLETE. - - -PASS text.description is 'AXDescription: Shut down computer after 10 minutes' -PASS text.titleUIElement() != null text.titleUIElement().isValid is false -PASS labelElement.role is 'AXRole: AXStaticText' -PASS successfullyParsed is true - -TEST COMPLETE - Modified: trunk/LayoutTests/accessibility/aria-labelledby-overrides-label.html (138174 => 138175) --- trunk/LayoutTests/accessibility/aria-labelledby-overrides-label.html 2012-12-19 17:38:48 UTC (rev 138174) +++ trunk/LayoutTests/accessibility/aria-labelledby-overrides-label.html 2012-12-19 17:42:35 UTC (rev 138175) @@ -5,7 +5,7 @@ /head body id=body -span id=labelShutdownlabel for="" down computer after/label/span +span id=labelShutdownlabel id=labelElement for="" down computer after/label/span input id=shutdownTime type=text value=10 aria-labelledby=labelShutdown shutdownTime shutdownUnit / span id=shutdownUnitminutes/span @@ -27,12 +27,10 @@ // There should be no title UI element. shouldBe(text.titleUIElement() != null text.titleUIElement().isValid, false); - // The label element is in a group, in a group, in the web area. - var labelElement = accessibilityController.rootElement.childAtIndex(0).childAtIndex(0).childAtIndex(0).childAtIndex(0); - + var labelElement = accessibilityController.accessibleElementById(labelElement); // This just makes sure that the label element is still visible in the AX hierarchy, even though // it's a label element (sometimes they are ignored). - shouldBe(labelElement.role, 'AXRole: AXStaticText'); + debug(Label element role is: +
[webkit-changes] [138176] trunk/Tools
Title: [138176] trunk/Tools
Revision 138176
Author jchaffr...@webkit.org
Date 2012-12-19 09:45:46 -0800 (Wed, 19 Dec 2012)
Log Message
2 clampTo unit tests are failing
https://bugs.webkit.org/show_bug.cgi?id=105253
Reviewed by Emil A Eklund.
Removed clampToUnsigned as it was actually testing exactly what
clampToUnsignedLong was doing. Also made clampToIntFloat more robust
to precision loss (fix suggested by Emil).
* TestWebKitAPI/Tests/WTF/MathExtras.cpp:
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WTF/MathExtras.cpp
Diff
Modified: trunk/Tools/ChangeLog (138175 => 138176)
--- trunk/Tools/ChangeLog 2012-12-19 17:42:35 UTC (rev 138175)
+++ trunk/Tools/ChangeLog 2012-12-19 17:45:46 UTC (rev 138176)
@@ -1,3 +1,16 @@
+2012-12-19 Julien Chaffraix jchaffr...@webkit.org
+
+2 clampTo unit tests are failing
+https://bugs.webkit.org/show_bug.cgi?id=105253
+
+Reviewed by Emil A Eklund.
+
+Removed clampToUnsigned as it was actually testing exactly what
+clampToUnsignedLong was doing. Also made clampToIntFloat more robust
+to precision loss (fix suggested by Emil).
+
+* TestWebKitAPI/Tests/WTF/MathExtras.cpp:
+
2012-12-19 Thiago Marcos P. Santos thiago.san...@intel.com
[EFL] Move ImageDiff to the Tools directory root
Modified: trunk/Tools/TestWebKitAPI/Tests/WTF/MathExtras.cpp (138175 => 138176)
--- trunk/Tools/TestWebKitAPI/Tests/WTF/MathExtras.cpp 2012-12-19 17:42:35 UTC (rev 138175)
+++ trunk/Tools/TestWebKitAPI/Tests/WTF/MathExtras.cpp 2012-12-19 17:45:46 UTC (rev 138176)
@@ -87,8 +87,7 @@
EXPECT_EQ(clampToint(underflowInt), minInt);
}
-// https://bugs.webkit.org/show_bug.cgi?id=105253
-TEST(WTF, DISABLED_clampToIntegerFloat)
+TEST(WTF, clampToIntegerFloat)
{
// This test is inaccurate as floats will round the min / max integer
// due to the narrow mantissa. However it will properly checks within
@@ -101,10 +100,11 @@
EXPECT_GT(overflowInt, maxInt);
EXPECT_LT(underflowInt, minInt);
-EXPECT_EQ(clampToInteger(maxInt), maxInt);
+// If maxInt == 2^31 - 1 (ie on I32 architecture), the closest float used to represent it is 2^31.
+EXPECT_NEAR(clampToInteger(maxInt), maxInt, 1);
EXPECT_EQ(clampToInteger(minInt), minInt);
-EXPECT_EQ(clampToInteger(overflowInt), maxInt);
+EXPECT_NEAR(clampToInteger(overflowInt), maxInt, 1);
EXPECT_EQ(clampToInteger(underflowInt), minInt);
}
@@ -145,17 +145,6 @@
EXPECT_EQ(clampToFloat(-std::numeric_limitsfloat::infinity()), minFloat);
}
-// https://bugs.webkit.org/show_bug.cgi?id=105253
-TEST(WTF, DISABLED_clampToUnsigned)
-{
-unsigned long maxUnsigned = std::numeric_limitsunsigned::max();
-unsigned long overflowUnsigned = maxUnsigned + 1;
-EXPECT_EQ(clampTounsigned(maxUnsigned), maxUnsigned);
-
-EXPECT_EQ(clampTounsigned(overflowUnsigned), maxUnsigned);
-EXPECT_EQ(clampTounsigned(-1), 0u);
-}
-
TEST(WTF, clampToUnsignedLong)
{
if (sizeof(unsigned long) == sizeof(unsigned))
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [138177] trunk/Source/WebCore
Title: [138177] trunk/Source/WebCore
Revision 138177
Author simon.fra...@apple.com
Date 2012-12-19 09:49:45 -0800 (Wed, 19 Dec 2012)
Log Message
Fix regression from r137923 that caused all tiles to paint when scrolling
https://bugs.webkit.org/show_bug.cgi?id=105394
Reviewed by Dean Jackson.
r137923 removed a 'continue' from the loop that ensures we have tile coverage,
but this caused us to issue repaints for all existing tiles.
Fix to 'continue' when the tile size is unchanged. Also remove 'primaryLayerCount'
which was unused.
* platform/graphics/ca/mac/TileCache.mm:
(WebCore::TileCache::revalidateTiles):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/ca/mac/TileCache.mm
Diff
Modified: trunk/Source/WebCore/ChangeLog (138176 => 138177)
--- trunk/Source/WebCore/ChangeLog 2012-12-19 17:45:46 UTC (rev 138176)
+++ trunk/Source/WebCore/ChangeLog 2012-12-19 17:49:45 UTC (rev 138177)
@@ -1,3 +1,19 @@
+2012-12-18 Simon Fraser simon.fra...@apple.com
+
+Fix regression from r137923 that caused all tiles to paint when scrolling
+https://bugs.webkit.org/show_bug.cgi?id=105394
+
+Reviewed by Dean Jackson.
+
+r137923 removed a 'continue' from the loop that ensures we have tile coverage,
+but this caused us to issue repaints for all existing tiles.
+
+Fix to 'continue' when the tile size is unchanged. Also remove 'primaryLayerCount'
+which was unused.
+
+* platform/graphics/ca/mac/TileCache.mm:
+(WebCore::TileCache::revalidateTiles):
+
2012-12-19 Nate Chapin jap...@chromium.org
REGRESSION(r137607): PluginDocument loads consume huge amounts of memory
Modified: trunk/Source/WebCore/platform/graphics/ca/mac/TileCache.mm (138176 => 138177)
--- trunk/Source/WebCore/platform/graphics/ca/mac/TileCache.mm 2012-12-19 17:45:46 UTC (rev 138176)
+++ trunk/Source/WebCore/platform/graphics/ca/mac/TileCache.mm 2012-12-19 17:49:45 UTC (rev 138177)
@@ -601,7 +601,6 @@
// Ensure primary tile coverage tiles.
m_primaryTileCoverageRect = IntRect();
-int primaryLayerCount = 0;
for (int y = topLeft.y(); y = bottomRight.y(); ++y) {
for (int x = topLeft.x(); x = bottomRight.x(); ++x) {
@@ -617,12 +616,12 @@
} else {
// We already have a layer for this tile. Ensure that its size is correct.
FloatSize tileLayerSize([tileInfo.layer.get() frame].size);
-if (tileLayerSize != FloatSize(tileRect.size()))
-[tileInfo.layer.get() setFrame:tileRect];
+if (tileLayerSize == FloatSize(tileRect.size()))
+continue;
+
+[tileInfo.layer.get() setFrame:tileRect];
}
-++primaryLayerCount;
-
FloatRect scaledTileRect = tileRect;
scaledTileRect.scale(1 / m_scale);
dirtyRects.append(scaledTileRect);
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [138178] trunk/LayoutTests
Title: [138178] trunk/LayoutTests Revision 138178 Author le...@chromium.org Date 2012-12-19 09:50:01 -0800 (Wed, 19 Dec 2012) Log Message Unreviewed. Fixing incorrect include path and unskipping broken test. * fast/events/touch/touch-input-element-change-documents.html: * platform/efl/TestExpectations: * platform/qt/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/fast/events/touch/touch-input-element-change-documents.html trunk/LayoutTests/platform/efl/TestExpectations trunk/LayoutTests/platform/qt/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (138177 => 138178) --- trunk/LayoutTests/ChangeLog 2012-12-19 17:49:45 UTC (rev 138177) +++ trunk/LayoutTests/ChangeLog 2012-12-19 17:50:01 UTC (rev 138178) @@ -1,3 +1,11 @@ +2012-12-19 Levi Weintraub le...@chromium.org + +Unreviewed. Fixing incorrect include path and unskipping broken test. + +* fast/events/touch/touch-input-element-change-documents.html: +* platform/efl/TestExpectations: +* platform/qt/TestExpectations: + 2012-12-19 Dominic Mazzoni dmazz...@google.com Support titleUIElement in chromium DRT Modified: trunk/LayoutTests/fast/events/touch/touch-input-element-change-documents.html (138177 => 138178) --- trunk/LayoutTests/fast/events/touch/touch-input-element-change-documents.html 2012-12-19 17:49:45 UTC (rev 138177) +++ trunk/LayoutTests/fast/events/touch/touch-input-element-change-documents.html 2012-12-19 17:50:01 UTC (rev 138178) @@ -1,4 +1,4 @@ -script src="" +script src="" div id='container'/div script description(This test checks that we correctly update the touch event handler count when an Input element with default touch handlers changes documents.); Modified: trunk/LayoutTests/platform/efl/TestExpectations (138177 => 138178) --- trunk/LayoutTests/platform/efl/TestExpectations 2012-12-19 17:49:45 UTC (rev 138177) +++ trunk/LayoutTests/platform/efl/TestExpectations 2012-12-19 17:50:01 UTC (rev 138178) @@ -1728,6 +1728,3 @@ # Note webkit.org/b/104506, random crashes webkit.org/b/105029 fast/canvas/webgl/webgl-composite-modes.html [ ImageOnlyFailure Crash ] webkit.org/b/105029 fast/canvas/webgl/webgl-composite-modes-repaint.html [ ImageOnlyFailure Crash ] - -# Failing touch events case -webkit.org/b/105406 fast/events/touch/touch-input-element-change-documents.html [ Failure ] Modified: trunk/LayoutTests/platform/qt/TestExpectations (138177 => 138178) --- trunk/LayoutTests/platform/qt/TestExpectations 2012-12-19 17:49:45 UTC (rev 138177) +++ trunk/LayoutTests/platform/qt/TestExpectations 2012-12-19 17:50:01 UTC (rev 138178) @@ -2272,9 +2272,6 @@ fast/profiler/apply.html http/tests/w3c/webperf/approved/navigation-timing/html/test_timing_xserver_redirect.html -# [Qt] New fast/events/touch/touch-input-element-change-documents.html fails on JSC platforms -webkit.org/b/104054 fast/events/touch/touch-input-element-change-documents.html - # === # # End of entries merged in from the old Skipped file# # === # ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [138180] trunk/LayoutTests
Title: [138180] trunk/LayoutTests Revision 138180 Author le...@chromium.org Date 2012-12-19 11:20:38 -0800 (Wed, 19 Dec 2012) Log Message Unreviewed gardening. The previous rebaseline didn't quite get it right for Mac. * platform/chromium-mac-lion/platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-with-scroll-bar-expected.png: * platform/chromium-mac-lion/platform/chromium/fast/forms/suggestion-picker/month-suggestion-picker-appearance-with-scroll-bar-expected.png: * platform/chromium-mac-lion/platform/chromium/fast/forms/suggestion-picker/week-suggestion-picker-appearance-with-scroll-bar-expected.png: * platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-with-scroll-bar-expected.png: * platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/month-suggestion-picker-appearance-with-scroll-bar-expected.png: * platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/week-suggestion-picker-appearance-with-scroll-bar-expected.png: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-with-scroll-bar-expected.png trunk/LayoutTests/platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/month-suggestion-picker-appearance-with-scroll-bar-expected.png trunk/LayoutTests/platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/week-suggestion-picker-appearance-with-scroll-bar-expected.png trunk/LayoutTests/platform/chromium-mac-lion/platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-with-scroll-bar-expected.png trunk/LayoutTests/platform/chromium-mac-lion/platform/chromium/fast/forms/suggestion-picker/month-suggestion-picker-appearance-with-scroll-bar-expected.png trunk/LayoutTests/platform/chromium-mac-lion/platform/chromium/fast/forms/suggestion-picker/week-suggestion-picker-appearance-with-scroll-bar-expected.png Diff Modified: trunk/LayoutTests/ChangeLog (138179 => 138180) --- trunk/LayoutTests/ChangeLog 2012-12-19 18:01:44 UTC (rev 138179) +++ trunk/LayoutTests/ChangeLog 2012-12-19 19:20:38 UTC (rev 138180) @@ -1,5 +1,16 @@ 2012-12-19 Levi Weintraub le...@chromium.org +Unreviewed gardening. The previous rebaseline didn't quite get it right for Mac. + +* platform/chromium-mac-lion/platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-with-scroll-bar-expected.png: +* platform/chromium-mac-lion/platform/chromium/fast/forms/suggestion-picker/month-suggestion-picker-appearance-with-scroll-bar-expected.png: +* platform/chromium-mac-lion/platform/chromium/fast/forms/suggestion-picker/week-suggestion-picker-appearance-with-scroll-bar-expected.png: +* platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-with-scroll-bar-expected.png: +* platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/month-suggestion-picker-appearance-with-scroll-bar-expected.png: +* platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/week-suggestion-picker-appearance-with-scroll-bar-expected.png: + +2012-12-19 Levi Weintraub le...@chromium.org + Unreviewed gardening. Updating expectations following r137847. * platform/chromium-linux-x86/fast/dom/Window: Added. Modified: trunk/LayoutTests/platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-with-scroll-bar-expected.png (Binary files differ) Modified: trunk/LayoutTests/platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/month-suggestion-picker-appearance-with-scroll-bar-expected.png (Binary files differ) Modified: trunk/LayoutTests/platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/week-suggestion-picker-appearance-with-scroll-bar-expected.png (Binary files differ) Modified: trunk/LayoutTests/platform/chromium-mac-lion/platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-with-scroll-bar-expected.png (Binary files differ) Modified: trunk/LayoutTests/platform/chromium-mac-lion/platform/chromium/fast/forms/suggestion-picker/month-suggestion-picker-appearance-with-scroll-bar-expected.png (Binary files differ) Modified: trunk/LayoutTests/platform/chromium-mac-lion/platform/chromium/fast/forms/suggestion-picker/week-suggestion-picker-appearance-with-scroll-bar-expected.png (Binary files differ) ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [138181] trunk
Title: [138181] trunk
Revision 138181
Author le...@chromium.org
Date 2012-12-19 11:22:12 -0800 (Wed, 19 Dec 2012)
Log Message
Correct missing touch event handler de-registration for nested Documents and DOMWindows
https://bugs.webkit.org/show_bug.cgi?id=105384
Reviewed by James Robinson.
Source/WebCore:
Correcting case by which a nested DOMWindow wouldn't clean up its event handler references
on its Document when removeAllEventListeners was called. Also, correctly propagating this
from a nested Document to its owner Document.
Updating fast/events/touch/touch-handler-count.html to catch this bug.
* dom/Document.cpp:
(WebCore::Document::didRemoveEventTargetNode):
* page/DOMWindow.cpp:
(WebCore::DOMWindow::removeAllEventListeners):
LayoutTests:
* fast/events/touch/touch-handler-count-expected.txt:
* fast/events/touch/touch-handler-count.html: Adding case of nested DOMWindows with event handlers.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/events/touch/touch-handler-count-expected.txt
trunk/LayoutTests/fast/events/touch/touch-handler-count.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/Document.cpp
trunk/Source/WebCore/page/DOMWindow.cpp
Diff
Modified: trunk/LayoutTests/ChangeLog (138180 => 138181)
--- trunk/LayoutTests/ChangeLog 2012-12-19 19:20:38 UTC (rev 138180)
+++ trunk/LayoutTests/ChangeLog 2012-12-19 19:22:12 UTC (rev 138181)
@@ -1,5 +1,15 @@
2012-12-19 Levi Weintraub le...@chromium.org
+Correct missing touch event handler de-registration for nested Documents and DOMWindows
+https://bugs.webkit.org/show_bug.cgi?id=105384
+
+Reviewed by James Robinson.
+
+* fast/events/touch/touch-handler-count-expected.txt:
+* fast/events/touch/touch-handler-count.html: Adding case of nested DOMWindows with event handlers.
+
+2012-12-19 Levi Weintraub le...@chromium.org
+
Unreviewed gardening. The previous rebaseline didn't quite get it right for Mac.
* platform/chromium-mac-lion/platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-with-scroll-bar-expected.png:
Modified: trunk/LayoutTests/fast/events/touch/touch-handler-count-expected.txt (138180 => 138181)
--- trunk/LayoutTests/fast/events/touch/touch-handler-count-expected.txt 2012-12-19 19:20:38 UTC (rev 138180)
+++ trunk/LayoutTests/fast/events/touch/touch-handler-count-expected.txt 2012-12-19 19:22:12 UTC (rev 138181)
@@ -71,4 +71,8 @@
PASS window.internals.touchEventHandlerCount(document) is 2
PASS window.internals.touchEventHandlerCount(document) is 2
PASS window.internals.touchEventHandlerCount(document) is 0
+Test that nested Documents' touch handlers are properly removed from their parent Document.
+PASS window.internals.touchEventHandlerCount(document) is 0
+PASS window.internals.touchEventHandlerCount(document) is 1
+PASS window.internals.touchEventHandlerCount(document) is 0
Modified: trunk/LayoutTests/fast/events/touch/touch-handler-count.html (138180 => 138181)
--- trunk/LayoutTests/fast/events/touch/touch-handler-count.html 2012-12-19 19:20:38 UTC (rev 138180)
+++ trunk/LayoutTests/fast/events/touch/touch-handler-count.html 2012-12-19 19:22:12 UTC (rev 138181)
@@ -204,5 +204,24 @@
shouldBe('window.internals.touchEventHandlerCount(document)', '0');
})();
+debug(Test that nested Documents' touch handlers are properly removed from their parent Document.);
+(function() {
+var iframe = document.createElement('iframe');
+var touchtarget = document.getElementById('touchtarget');
+
+shouldBe('window.internals.touchEventHandlerCount(document)', '0');
+
+touchtarget.appendChild(iframe);
+
+var nestedDocument = iframe.contentWindow.document;
+nestedDocument.open('text/html', 'replace');
+nestedDocument.write(!DOCTYPE html\nhtmlbody _onload_=\window._ontouchstart_ = function() { };\/body);
+nestedDocument.close();
+
+shouldBe('window.internals.touchEventHandlerCount(document)', '1');
+
+touchtarget.removeChild(iframe);
+shouldBe('window.internals.touchEventHandlerCount(document)', '0');
+})();
/script
/body
Modified: trunk/Source/WebCore/ChangeLog (138180 => 138181)
--- trunk/Source/WebCore/ChangeLog 2012-12-19 19:20:38 UTC (rev 138180)
+++ trunk/Source/WebCore/ChangeLog 2012-12-19 19:22:12 UTC (rev 138181)
@@ -1,3 +1,21 @@
+2012-12-19 Levi Weintraub le...@chromium.org
+
+Correct missing touch event handler de-registration for nested Documents and DOMWindows
+https://bugs.webkit.org/show_bug.cgi?id=105384
+
+Reviewed by James Robinson.
+
+Correcting case by which a nested DOMWindow wouldn't clean up its event handler references
+on its Document when removeAllEventListeners was called. Also, correctly propagating this
+from a nested Document to its owner Document.
+
+Updating fast/events/touch/touch-handler-count.html to catch this bug.
+
+* dom/Document.cpp:
+
[webkit-changes] [138182] trunk/Source/WebCore
Title: [138182] trunk/Source/WebCore
Revision 138182
Author roger_f...@apple.com
Date 2012-12-19 11:24:37 -0800 (Wed, 19 Dec 2012)
Log Message
Popup menu on Windows should fade in instead of sliding in.
https://bugs.webkit.org/show_bug.cgi?id=105358
rdar://problem/7611211
Reviewed by Timothy Horton.
Changing popup menu display animation to match what most other Windows applications do.
* platform/win/PopupMenuWin.cpp:
(WebCore::PopupMenuWin::show):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/win/PopupMenuWin.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (138181 => 138182)
--- trunk/Source/WebCore/ChangeLog 2012-12-19 19:22:12 UTC (rev 138181)
+++ trunk/Source/WebCore/ChangeLog 2012-12-19 19:24:37 UTC (rev 138182)
@@ -1,3 +1,16 @@
+2012-12-18 Roger Fong roger_f...@apple.com
+
+Popup menu on Windows should fade in instead of sliding in.
+https://bugs.webkit.org/show_bug.cgi?id=105358
+rdar://problem/7611211
+
+Reviewed by Timothy Horton.
+
+Changing popup menu display animation to match what most other Windows applications do.
+
+* platform/win/PopupMenuWin.cpp:
+(WebCore::PopupMenuWin::show):
+
2012-12-19 Levi Weintraub le...@chromium.org
Correct missing touch event handler de-registration for nested Documents and DOMWindows
Modified: trunk/Source/WebCore/platform/win/PopupMenuWin.cpp (138181 => 138182)
--- trunk/Source/WebCore/platform/win/PopupMenuWin.cpp 2012-12-19 19:22:12 UTC (rev 138181)
+++ trunk/Source/WebCore/platform/win/PopupMenuWin.cpp 2012-12-19 19:24:37 UTC (rev 138182)
@@ -168,14 +168,8 @@
if (shouldAnimate) {
RECT viewRect = {0};
::GetWindowRect(hostWindow, viewRect);
-
-if (!::IsRectEmpty(viewRect)) {
-// Popups should slide into view away from the select box
-// NOTE: This may have to change for Vista
-DWORD slideDirection = (m_windowRect.y() viewRect.top + view-contentsToWindow(r.location()).y()) ? AW_VER_NEGATIVE : AW_VER_POSITIVE;
-
-::AnimateWindow(m_popup, defaultAnimationDuration, AW_SLIDE | slideDirection);
-}
+if (!::IsRectEmpty(viewRect))
+::AnimateWindow(m_popup, defaultAnimationDuration, AW_BLEND);
} else
#endif
::ShowWindow(m_popup, SW_SHOWNOACTIVATE);
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [138183] trunk/Source/WebCore
Title: [138183] trunk/Source/WebCore
Revision 138183
Author toniki...@webkit.org
Date 2012-12-19 11:27:42 -0800 (Wed, 19 Dec 2012)
Log Message
Make RenderLayerCompositor::requiresCompositingForScrollableFrame scrollbars agnostic
https://bugs.webkit.org/show_bug.cgi?id=97903
Reviewed by Simon Fraser.
Patch by Antonio Gomes a1.go...@sisa.samsung.com
Some ports (including Qt-wk1 and BlackBerry) allow disabling
scrollbars at FrameView creation level. Regardless the scrollbars
presence though, their frame's content can still be scrolled as needed.
The said, checking for the scrollbars presence in order to determine
the scrollability of an inner frame is flaky, as done in RenderLayerCompositor::requiresCompositingForScrollableFrame.
Instead, the patch factors out part of the logic in
FrameView::updateScrollableAreaSet into a new ::isScrollable method.
The later can be used to check the scrollability of a given FrameView.
No new tests added, since there is no behavior change: ports like Chromium and others
who currently check for the scrollbars presence in order to determine
an inner frame scrollability should not be affected.
* page/FrameView.cpp:
(WebCore::FrameView::isScrollable):
(WebCore):
(WebCore::FrameView::updateScrollableAreaSet):
* page/FrameView.h:
(FrameView):
* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::requiresCompositingForScrollableFrame):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/FrameView.cpp
trunk/Source/WebCore/page/FrameView.h
trunk/Source/WebCore/rendering/RenderLayerCompositor.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (138182 => 138183)
--- trunk/Source/WebCore/ChangeLog 2012-12-19 19:24:37 UTC (rev 138182)
+++ trunk/Source/WebCore/ChangeLog 2012-12-19 19:27:42 UTC (rev 138183)
@@ -1,3 +1,33 @@
+2012-12-12 Antonio Gomes a1.go...@sisa.samsung.com
+
+Make RenderLayerCompositor::requiresCompositingForScrollableFrame scrollbars agnostic
+https://bugs.webkit.org/show_bug.cgi?id=97903
+
+Reviewed by Simon Fraser.
+
+Some ports (including Qt-wk1 and BlackBerry) allow disabling
+scrollbars at FrameView creation level. Regardless the scrollbars
+presence though, their frame's content can still be scrolled as needed.
+The said, checking for the scrollbars presence in order to determine
+the scrollability of an inner frame is flaky, as done in RenderLayerCompositor::requiresCompositingForScrollableFrame.
+
+Instead, the patch factors out part of the logic in
+FrameView::updateScrollableAreaSet into a new ::isScrollable method.
+The later can be used to check the scrollability of a given FrameView.
+
+No new tests added, since there is no behavior change: ports like Chromium and others
+who currently check for the scrollbars presence in order to determine
+an inner frame scrollability should not be affected.
+
+* page/FrameView.cpp:
+(WebCore::FrameView::isScrollable):
+(WebCore):
+(WebCore::FrameView::updateScrollableAreaSet):
+* page/FrameView.h:
+(FrameView):
+* rendering/RenderLayerCompositor.cpp:
+(WebCore::RenderLayerCompositor::requiresCompositingForScrollableFrame):
+
2012-12-18 Roger Fong roger_f...@apple.com
Popup menu on Windows should fade in instead of sliding in.
Modified: trunk/Source/WebCore/page/FrameView.cpp (138182 => 138183)
--- trunk/Source/WebCore/page/FrameView.cpp 2012-12-19 19:24:37 UTC (rev 138182)
+++ trunk/Source/WebCore/page/FrameView.cpp 2012-12-19 19:27:42 UTC (rev 138183)
@@ -2834,41 +2834,48 @@
return frameRect();
}
-void FrameView::updateScrollableAreaSet()
+bool FrameView::isScrollable()
{
-// That ensures that only inner frames are cached.
-if (!parentFrameView())
-return;
-
// Check for:
-// 1) display:none or visibility:hidden set to self or inherited.
-// 2) overflow{-x,-y}: hidden;
-// 3) scrolling: no;
+// 1) If there an actual overflow.
+// 2) display:none or visibility:hidden set to self or inherited.
+// 3) overflow{-x,-y}: hidden;
+// 4) scrolling: no;
-// Covers #1.
-HTMLFrameOwnerElement* owner = m_frame-ownerElement();
-if (!owner || !owner-renderer() || !owner-renderer()-visibleToHitTesting()) {
-parentFrameView()-removeScrollableArea(this);
-return;
-}
-
+// Covers #1
IntSize contentSize = contentsSize();
IntSize visibleContentSize = visibleContentRect().size();
-if ((contentSize.height() = visibleContentSize.height() contentSize.width() = visibleContentSize.width())) {
-parentFrameView()-removeScrollableArea(this);
-return;
-}
+if ((contentSize.height() = visibleContentSize.height() contentSize.width() = visibleContentSize.width()))
+return false;
-// Cover #2 and #3.
+// Covers #2.
+HTMLFrameOwnerElement* owner =
[webkit-changes] [138185] trunk/Source/WebKit2
Title: [138185] trunk/Source/WebKit2
Revision 138185
Author jon...@apple.com
Date 2012-12-19 12:01:53 -0800 (Wed, 19 Dec 2012)
Log Message
Notify context client of change to table, and allow client to get a copy of it
https://bugs.webkit.org/show_bug.cgi?id=105364
rdar://problem/12906267
Reviewed by Brady Eidson.
Add a callback to notify the context client that the origin hashes have changed.
The client may choose to get a copy of that table and save it to disk.
* UIProcess/API/C/WKContext.cpp:
(WKContextCopyPlugInAutoStartOriginHashes): Added to the context client.
* UIProcess/API/C/WKContext.h:
* UIProcess/WebContext.cpp:
(WebKit::WebContext::plugInAutoStartOriginHashes): Return a copy of the origin hash
table.
* UIProcess/WebContext.h:
* UIProcess/Plugins/PlugInAutoStartProvider.cpp:
(WebKit::PlugInAutoStartProvider::addAutoStartOrigin): When the origin is added to
the table, notify the context client.
(WebKit::PlugInAutoStartProvider::autoStartOriginsTableCopy): Create a copy of the
table.
* UIProcess/Plugins/PlugInAutoStartProvider.h:
* UIProcess/WebContextClient.cpp:
(WebKit::WebContextClient::plugInAutoStartOriginHashesChanged): Call the client.
* UIProcess/WebContextClient.h:
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/C/WKContext.cpp
trunk/Source/WebKit2/UIProcess/API/C/WKContext.h
trunk/Source/WebKit2/UIProcess/Plugins/PlugInAutoStartProvider.cpp
trunk/Source/WebKit2/UIProcess/Plugins/PlugInAutoStartProvider.h
trunk/Source/WebKit2/UIProcess/WebContext.cpp
trunk/Source/WebKit2/UIProcess/WebContext.h
trunk/Source/WebKit2/UIProcess/WebContextClient.cpp
trunk/Source/WebKit2/UIProcess/WebContextClient.h
Diff
Modified: trunk/Source/WebKit2/ChangeLog (138184 => 138185)
--- trunk/Source/WebKit2/ChangeLog 2012-12-19 19:35:57 UTC (rev 138184)
+++ trunk/Source/WebKit2/ChangeLog 2012-12-19 20:01:53 UTC (rev 138185)
@@ -1,3 +1,33 @@
+2012-12-18 Jon Lee jon...@apple.com
+
+Notify context client of change to table, and allow client to get a copy of it
+https://bugs.webkit.org/show_bug.cgi?id=105364
+rdar://problem/12906267
+
+Reviewed by Brady Eidson.
+
+Add a callback to notify the context client that the origin hashes have changed.
+The client may choose to get a copy of that table and save it to disk.
+
+* UIProcess/API/C/WKContext.cpp:
+(WKContextCopyPlugInAutoStartOriginHashes): Added to the context client.
+* UIProcess/API/C/WKContext.h:
+* UIProcess/WebContext.cpp:
+(WebKit::WebContext::plugInAutoStartOriginHashes): Return a copy of the origin hash
+table.
+* UIProcess/WebContext.h:
+
+* UIProcess/Plugins/PlugInAutoStartProvider.cpp:
+(WebKit::PlugInAutoStartProvider::addAutoStartOrigin): When the origin is added to
+the table, notify the context client.
+(WebKit::PlugInAutoStartProvider::autoStartOriginsTableCopy): Create a copy of the
+table.
+* UIProcess/Plugins/PlugInAutoStartProvider.h:
+
+* UIProcess/WebContextClient.cpp:
+(WebKit::WebContextClient::plugInAutoStartOriginHashesChanged): Call the client.
+* UIProcess/WebContextClient.h:
+
2012-12-19 Alexis Menard ale...@webkit.org
Implement CSS parsing for CSS transitions unprefixed.
Modified: trunk/Source/WebKit2/UIProcess/API/C/WKContext.cpp (138184 => 138185)
--- trunk/Source/WebKit2/UIProcess/API/C/WKContext.cpp 2012-12-19 19:35:57 UTC (rev 138184)
+++ trunk/Source/WebKit2/UIProcess/API/C/WKContext.cpp 2012-12-19 20:01:53 UTC (rev 138185)
@@ -337,6 +337,11 @@
toImpl(contextRef)-setUsesNetworkProcess(usesNetworkProcess);
}
+WKDictionaryRef WKContextCopyPlugInAutoStartOriginHashes(WKContextRef contextRef)
+{
+return toAPI(toImpl(contextRef)-plugInAutoStartOriginHashes().leakRef());
+}
+
// Deprecated functions.
void _WKContextSetAdditionalPluginsDirectory(WKContextRef context, WKStringRef pluginsDirectory)
{
Modified: trunk/Source/WebKit2/UIProcess/API/C/WKContext.h (138184 => 138185)
--- trunk/Source/WebKit2/UIProcess/API/C/WKContext.h 2012-12-19 19:35:57 UTC (rev 138184)
+++ trunk/Source/WebKit2/UIProcess/API/C/WKContext.h 2012-12-19 20:01:53 UTC (rev 138185)
@@ -40,9 +40,12 @@
typedef uint32_t WKCacheModel;
// Context Client
+typedef void (*WKContextPlugInAutoStartOriginHashesChangedCallback)(WKContextRef context, const void *clientInfo);
+
struct WKContextClient {
int version;
const void *clientInfo;
+WKContextPlugInAutoStartOriginHashesChangedCallback plugInAutoStartOriginHashesChanged;
};
typedef struct WKContextClient WKContextClient;
@@ -187,6 +190,8 @@
WK_EXPORT void WKContextGarbageCollectJavaScriptObjects(WKContextRef context);
WK_EXPORT void WKContextSetJavaScriptGarbageCollectorTimerEnabled(WKContextRef
[webkit-changes] [138186] trunk/LayoutTests
Title: [138186] trunk/LayoutTests Revision 138186 Author le...@chromium.org Date 2012-12-19 12:03:12 -0800 (Wed, 19 Dec 2012) Log Message Re-skipping touch-input-element-chang-documents.html since it's still failing on qt and efl. * platform/efl/TestExpectations: * platform/qt/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/efl/TestExpectations trunk/LayoutTests/platform/qt/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (138185 => 138186) --- trunk/LayoutTests/ChangeLog 2012-12-19 20:01:53 UTC (rev 138185) +++ trunk/LayoutTests/ChangeLog 2012-12-19 20:03:12 UTC (rev 138186) @@ -1,3 +1,11 @@ +2012-12-19 Levi Weintraub le...@chromium.org + +Re-skipping touch-input-element-chang-documents.html since it's still +failing on qt and efl. + +* platform/efl/TestExpectations: +* platform/qt/TestExpectations: + 2012-12-19 Alexis Menard ale...@webkit.org Implement CSS parsing for CSS transitions unprefixed. Modified: trunk/LayoutTests/platform/efl/TestExpectations (138185 => 138186) --- trunk/LayoutTests/platform/efl/TestExpectations 2012-12-19 20:01:53 UTC (rev 138185) +++ trunk/LayoutTests/platform/efl/TestExpectations 2012-12-19 20:03:12 UTC (rev 138186) @@ -1728,3 +1728,6 @@ # Note webkit.org/b/104506, random crashes webkit.org/b/105029 fast/canvas/webgl/webgl-composite-modes.html [ ImageOnlyFailure Crash ] webkit.org/b/105029 fast/canvas/webgl/webgl-composite-modes-repaint.html [ ImageOnlyFailure Crash ] + +# Failing touch events case +webkit.org/b/105406 fast/events/touch/touch-input-element-change-documents.html [ Failure ] Modified: trunk/LayoutTests/platform/qt/TestExpectations (138185 => 138186) --- trunk/LayoutTests/platform/qt/TestExpectations 2012-12-19 20:01:53 UTC (rev 138185) +++ trunk/LayoutTests/platform/qt/TestExpectations 2012-12-19 20:03:12 UTC (rev 138186) @@ -2272,6 +2272,9 @@ fast/profiler/apply.html http/tests/w3c/webperf/approved/navigation-timing/html/test_timing_xserver_redirect.html +# [Qt] New fast/events/touch/touch-input-element-change-documents.html fails on JSC platforms +webkit.org/b/104054 fast/events/touch/touch-input-element-change-documents.html + # === # # End of entries merged in from the old Skipped file# # === # ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [138187] trunk/Source/WTF
Title: [138187] trunk/Source/WTF
Revision 138187
Author oli...@apple.com
Date 2012-12-19 12:17:25 -0800 (Wed, 19 Dec 2012)
Log Message
WTF String from ASCIILiteral fails to correctly handle empty strings.
https://bugs.webkit.org/show_bug.cgi?id=105453
Reviewed by Anders Carlsson.
When we have an zero length literal we should return the empty StringImpl.
* wtf/text/StringImpl.cpp:
(WTF::StringImpl::createFromLiteral):
Modified Paths
trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/text/StringImpl.cpp
Diff
Modified: trunk/Source/WTF/ChangeLog (138186 => 138187)
--- trunk/Source/WTF/ChangeLog 2012-12-19 20:03:12 UTC (rev 138186)
+++ trunk/Source/WTF/ChangeLog 2012-12-19 20:17:25 UTC (rev 138187)
@@ -1,3 +1,15 @@
+2012-12-19 Oliver Hunt oli...@apple.com
+
+WTF String from ASCIILiteral fails to correctly handle empty strings.
+https://bugs.webkit.org/show_bug.cgi?id=105453
+
+Reviewed by Anders Carlsson.
+
+When we have an zero length literal we should return the empty StringImpl.
+
+* wtf/text/StringImpl.cpp:
+(WTF::StringImpl::createFromLiteral):
+
2012-12-18 Yury Semikhatsky yu...@chromium.org
Web Inspector: show cached images under MemoryCache - Images section
Modified: trunk/Source/WTF/wtf/text/StringImpl.cpp (138186 => 138187)
--- trunk/Source/WTF/wtf/text/StringImpl.cpp 2012-12-19 20:03:12 UTC (rev 138186)
+++ trunk/Source/WTF/wtf/text/StringImpl.cpp 2012-12-19 20:17:25 UTC (rev 138187)
@@ -158,6 +158,8 @@
PassRefPtrStringImpl StringImpl::createFromLiteral(const char* characters)
{
size_t length = strlen(characters);
+if (!length)
+return empty();
ASSERT(charactersAreAllASCIILChar(reinterpret_castconst LChar*(characters), length));
return adoptRef(new StringImpl(characters, length, ConstructFromLiteral));
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [138189] branches/chromium/1364
Title: [138189] branches/chromium/1364
Revision 138189
Author le...@chromium.org
Date 2012-12-19 12:47:05 -0800 (Wed, 19 Dec 2012)
Log Message
Merge 138095
Input elements with default touch handlers don't update handler counts when changing documents
https://bugs.webkit.org/show_bug.cgi?id=105334
Reviewed by James Robinson.
Source/WebCore:
When an Input element with default touch event handlers changes documents, it failed to
update the touch event handler sets in both the old and new document. This patch fixes this
case.
Test: fast/events/touch/touch-input-element-change-documents.html
* dom/Document.h:
(WebCore::Document::didRemoveTouchEventTargetNode) This function makes sense when touch
handling is enabled, regardless of whether we're tracking the rects.
* dom/Document.cpp:
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::~HTMLInputElement): Switch from didRemoveTouchEventHandler to
didRemoveTouchEventTargetNode, since we don't care about counts in the destructor.
(WebCore::HTMLInputElement::updateType): Fixing incorrect indentation.
(WebCore::HTMLInputElement::didMoveToNewDocument): Adding the node to the new document and
removing it from the old.
LayoutTests:
* fast/events/touch/touch-input-element-change-documents-expected.txt: Added.
* fast/events/touch/touch-input-element-change-documents.html: Added.
TBR=le...@chromium.org
Review URL: https://codereview.chromium.org/11649024
Modified Paths
branches/chromium/1364/Source/WebCore/dom/Document.cpp
branches/chromium/1364/Source/WebCore/dom/Document.h
branches/chromium/1364/Source/WebCore/html/HTMLInputElement.cpp
Added Paths
branches/chromium/1364/LayoutTests/fast/events/touch/touch-input-element-change-documents-expected.txt
branches/chromium/1364/LayoutTests/fast/events/touch/touch-input-element-change-documents.html
Diff
Copied: branches/chromium/1364/LayoutTests/fast/events/touch/touch-input-element-change-documents-expected.txt (from rev 138095, trunk/LayoutTests/fast/events/touch/touch-input-element-change-documents-expected.txt) (0 => 138189)
--- branches/chromium/1364/LayoutTests/fast/events/touch/touch-input-element-change-documents-expected.txt (rev 0)
+++ branches/chromium/1364/LayoutTests/fast/events/touch/touch-input-element-change-documents-expected.txt 2012-12-19 20:47:05 UTC (rev 138189)
@@ -0,0 +1,12 @@
+This test checks that we correctly update the touch event handler count when an Input element with default touch handlers changes documents.
+
+On success, you will see a series of PASS messages, followed by TEST COMPLETE.
+
+
+PASS window.internals.touchEventHandlerCount(document) is 0
+PASS window.internals.touchEventHandlerCount(document) is 0
+PASS window.internals.touchEventHandlerCount(document) is 2
+PASS window.internals.touchEventHandlerCount(document) is 3
+PASS window.internals.touchEventHandlerCount(document) is 2
+PASS window.internals.touchEventHandlerCount(document) is 0
+
Copied: branches/chromium/1364/LayoutTests/fast/events/touch/touch-input-element-change-documents.html (from rev 138095, trunk/LayoutTests/fast/events/touch/touch-input-element-change-documents.html) (0 => 138189)
--- branches/chromium/1364/LayoutTests/fast/events/touch/touch-input-element-change-documents.html (rev 0)
+++ branches/chromium/1364/LayoutTests/fast/events/touch/touch-input-element-change-documents.html 2012-12-19 20:47:05 UTC (rev 138189)
@@ -0,0 +1,30 @@
+script src=""
+div id='container'/div
+script
+description(This test checks that we correctly update the touch event handler count when an Input element with default touch handlers changes documents.);
+
+
+ shouldBe('window.internals.touchEventHandlerCount(document)', '0');
+
+ // There are two touchable Input elements in Audio's shadow DOM when controls are enabled.
+ var input = document.createElement('audio');
+ input.setAttribute(controls, true);
+ var container = document.getElementById('container');
+
+ shouldBe('window.internals.touchEventHandlerCount(document)', '0');
+
+ container.appendChild(input);
+ shouldBe('window.internals.touchEventHandlerCount(document)', '2');
+
+ input._ontouchend_ = function() { };
+ shouldBe('window.internals.touchEventHandlerCount(document)', '3');
+
+ input._ontouchend_ = null;
+ shouldBe('window.internals.touchEventHandlerCount(document)', '2');
+
+ document.implementation.createDocument(, , null).adoptNode(input);
+ shouldBe('window.internals.touchEventHandlerCount(document)', '0');
+
+
+/script
+/body
Modified: branches/chromium/1364/Source/WebCore/dom/Document.cpp (138188 => 138189)
--- branches/chromium/1364/Source/WebCore/dom/Document.cpp 2012-12-19 20:45:11 UTC (rev 138188)
+++ branches/chromium/1364/Source/WebCore/dom/Document.cpp 2012-12-19 20:47:05 UTC (rev 138189)
@@ -5654,7 +5654,7 @@
#endif
}
-#if ENABLE(TOUCH_EVENT_TRACKING)
+#if ENABLE(TOUCH_EVENTS)
void Document::didRemoveEventTargetNode(Node* handler)
[webkit-changes] [138190] branches/chromium/1364
Title: [138190] branches/chromium/1364
Revision 138190
Author le...@chromium.org
Date 2012-12-19 12:48:34 -0800 (Wed, 19 Dec 2012)
Log Message
Merge 138181
Correct missing touch event handler de-registration for nested Documents and DOMWindows
https://bugs.webkit.org/show_bug.cgi?id=105384
Reviewed by James Robinson.
Source/WebCore:
Correcting case by which a nested DOMWindow wouldn't clean up its event handler references
on its Document when removeAllEventListeners was called. Also, correctly propagating this
from a nested Document to its owner Document.
Updating fast/events/touch/touch-handler-count.html to catch this bug.
* dom/Document.cpp:
(WebCore::Document::didRemoveEventTargetNode):
* page/DOMWindow.cpp:
(WebCore::DOMWindow::removeAllEventListeners):
LayoutTests:
* fast/events/touch/touch-handler-count-expected.txt:
* fast/events/touch/touch-handler-count.html: Adding case of nested DOMWindows with event handlers.
TBR=le...@chromium.org
Review URL: https://codereview.chromium.org/11635026
Modified Paths
branches/chromium/1364/LayoutTests/fast/events/touch/touch-handler-count-expected.txt
branches/chromium/1364/LayoutTests/fast/events/touch/touch-handler-count.html
branches/chromium/1364/Source/WebCore/dom/Document.cpp
branches/chromium/1364/Source/WebCore/page/DOMWindow.cpp
Diff
Modified: branches/chromium/1364/LayoutTests/fast/events/touch/touch-handler-count-expected.txt (138189 => 138190)
--- branches/chromium/1364/LayoutTests/fast/events/touch/touch-handler-count-expected.txt 2012-12-19 20:47:05 UTC (rev 138189)
+++ branches/chromium/1364/LayoutTests/fast/events/touch/touch-handler-count-expected.txt 2012-12-19 20:48:34 UTC (rev 138190)
@@ -71,4 +71,8 @@
PASS window.internals.touchEventHandlerCount(document) is 2
PASS window.internals.touchEventHandlerCount(document) is 2
PASS window.internals.touchEventHandlerCount(document) is 0
+Test that nested Documents' touch handlers are properly removed from their parent Document.
+PASS window.internals.touchEventHandlerCount(document) is 0
+PASS window.internals.touchEventHandlerCount(document) is 1
+PASS window.internals.touchEventHandlerCount(document) is 0
Modified: branches/chromium/1364/LayoutTests/fast/events/touch/touch-handler-count.html (138189 => 138190)
--- branches/chromium/1364/LayoutTests/fast/events/touch/touch-handler-count.html 2012-12-19 20:47:05 UTC (rev 138189)
+++ branches/chromium/1364/LayoutTests/fast/events/touch/touch-handler-count.html 2012-12-19 20:48:34 UTC (rev 138190)
@@ -204,5 +204,24 @@
shouldBe('window.internals.touchEventHandlerCount(document)', '0');
})();
+debug(Test that nested Documents' touch handlers are properly removed from their parent Document.);
+(function() {
+var iframe = document.createElement('iframe');
+var touchtarget = document.getElementById('touchtarget');
+
+shouldBe('window.internals.touchEventHandlerCount(document)', '0');
+
+touchtarget.appendChild(iframe);
+
+var nestedDocument = iframe.contentWindow.document;
+nestedDocument.open('text/html', 'replace');
+nestedDocument.write(!DOCTYPE html\nhtmlbody _onload_=\window._ontouchstart_ = function() { };\/body);
+nestedDocument.close();
+
+shouldBe('window.internals.touchEventHandlerCount(document)', '1');
+
+touchtarget.removeChild(iframe);
+shouldBe('window.internals.touchEventHandlerCount(document)', '0');
+})();
/script
/body
Modified: branches/chromium/1364/Source/WebCore/dom/Document.cpp (138189 => 138190)
--- branches/chromium/1364/Source/WebCore/dom/Document.cpp 2012-12-19 20:47:05 UTC (rev 138189)
+++ branches/chromium/1364/Source/WebCore/dom/Document.cpp 2012-12-19 20:48:34 UTC (rev 138190)
@@ -5659,6 +5659,9 @@
{
if (m_touchEventTargets.get())
m_touchEventTargets-removeAll(handler);
+if (handler == this)
+if (Document* parentDocument = this-parentDocument())
+parentDocument-didRemoveEventTargetNode(this);
}
#endif
Modified: branches/chromium/1364/Source/WebCore/page/DOMWindow.cpp (138189 => 138190)
--- branches/chromium/1364/Source/WebCore/page/DOMWindow.cpp 2012-12-19 20:47:05 UTC (rev 138189)
+++ branches/chromium/1364/Source/WebCore/page/DOMWindow.cpp 2012-12-19 20:48:34 UTC (rev 138190)
@@ -1685,6 +1685,10 @@
if (DeviceOrientationController* controller = DeviceOrientationController::from(page()))
controller-removeAllDeviceEventListeners(this);
#endif
+#if ENABLE(TOUCH_EVENTS)
+if (Document* document = this-document())
+document-didRemoveEventTargetNode(document);
+#endif
removeAllUnloadEventListeners(this);
removeAllBeforeUnloadEventListeners(this);
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [138191] trunk/Source/WebCore
Title: [138191] trunk/Source/WebCore Revision 138191 Author a...@apple.com Date 2012-12-19 13:06:03 -0800 (Wed, 19 Dec 2012) Log Message rdar://problem/12896478 Cannot log into gmail/facebook with NetworkProcess and private browsing enabled https://bugs.webkit.org/show_bug.cgi?id=105454 Reviewed by Brady Eidson. Request was using a wrong session after a redirect, because session cannot be preserved over IPC. Just set the storage session after calling the client, it is not really meaningful for a client to change session behind WebKit's back. * platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::ResourceHandle::willSendRequest): * platform/network/mac/ResourceHandleMac.mm: (WebCore::ResourceHandle::willSendRequest): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/platform/network/cf/ResourceHandleCFNet.cpp trunk/Source/WebCore/platform/network/mac/ResourceHandleMac.mm Diff Modified: trunk/Source/WebCore/ChangeLog (138190 => 138191) --- trunk/Source/WebCore/ChangeLog 2012-12-19 20:48:34 UTC (rev 138190) +++ trunk/Source/WebCore/ChangeLog 2012-12-19 21:06:03 UTC (rev 138191) @@ -1,3 +1,21 @@ +2012-12-19 Alexey Proskuryakov a...@apple.com + +rdar://problem/12896478 Cannot log into gmail/facebook with NetworkProcess and private browsing enabled +https://bugs.webkit.org/show_bug.cgi?id=105454 + +Reviewed by Brady Eidson. + +Request was using a wrong session after a redirect, because session cannot be +preserved over IPC. + +Just set the storage session after calling the client, it is not really meaningful +for a client to change session behind WebKit's back. + +* platform/network/cf/ResourceHandleCFNet.cpp: +(WebCore::ResourceHandle::willSendRequest): +* platform/network/mac/ResourceHandleMac.mm: +(WebCore::ResourceHandle::willSendRequest): + 2012-12-19 Alexis Menard ale...@webkit.org Implement CSS parsing for CSS transitions unprefixed. Modified: trunk/Source/WebCore/platform/network/cf/ResourceHandleCFNet.cpp (138190 => 138191) --- trunk/Source/WebCore/platform/network/cf/ResourceHandleCFNet.cpp 2012-12-19 20:48:34 UTC (rev 138190) +++ trunk/Source/WebCore/platform/network/cf/ResourceHandleCFNet.cpp 2012-12-19 21:06:03 UTC (rev 138191) @@ -559,9 +559,10 @@ } } +client()-willSendRequest(this, request, redirectResponse); + +// Client call may not preserve the session, especially if the request is sent over IPC. request.setStorageSession(d-m_storageSession.get()); - -client()-willSendRequest(this, request, redirectResponse); } bool ResourceHandle::shouldUseCredentialStorage() Modified: trunk/Source/WebCore/platform/network/mac/ResourceHandleMac.mm (138190 => 138191) --- trunk/Source/WebCore/platform/network/mac/ResourceHandleMac.mm 2012-12-19 20:48:34 UTC (rev 138190) +++ trunk/Source/WebCore/platform/network/mac/ResourceHandleMac.mm 2012-12-19 21:06:03 UTC (rev 138191) @@ -472,10 +472,10 @@ } } -if (d-m_storageSession) -request.setStorageSession(d-m_storageSession.get()); +client()-willSendRequest(this, request, redirectResponse); -client()-willSendRequest(this, request, redirectResponse); +// Client call may not preserve the session, especially if the request is sent over IPC. +request.setStorageSession(d-m_storageSession.get()); } bool ResourceHandle::shouldUseCredentialStorage() ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [138192] trunk/Tools
Title: [138192] trunk/Tools Revision 138192 Author rn...@webkit.org Date 2012-12-19 13:31:11 -0800 (Wed, 19 Dec 2012) Log Message PerfTest.parse_output does too much https://bugs.webkit.org/show_bug.cgi?id=105391 Reviewed by Tony Chang. Moved the code to filter lines into PerfTest._filter_output, which has been renamed from _filter_stderr. Also moved the code to output test results into PerfTest._run_with_driver. * Scripts/webkitpy/performance_tests/perftest.py: (PerfTest.__init__): Added _description. (PerfTest.description): Added. (PerfTest._run_with_driver): Moved the code to output test description and test results. (PerfTest._filter_output): Moved and renamed from PerfTest._filter_stderr. (PerfTest.parse_output): Removed the code to output test results. Return test results and description respectively. Also removed the code that allowed some tests to omit values since all tests report each iteration now since r136492. (PerfTest.output_statistics): Removed the code to print test description, now done in _run_with_driver. (ChromiumStylePerfTest._run_with_driver): Added. Chromium style tests are sufficiently different from regular PerfTest that it doesn't make much sense to share _run_with_driver. But really, we should just get rid of this type of test altogether in favor of regular performance tests that uses runner.js. (ChromiumStylePerfTest.parse_and_log_output): Renamed from parse_output. (PageLoadingPerfTest._run_with_driver): Removed the explicit '' for the test description. * Scripts/webkitpy/performance_tests/perftest_unittest.py: (MainTest.test_parse_output): Removed the expected logs since parse_output no longer prints out results. Also added a call to _filter_output since parse_output doesn't filter the output text anymore. (MainTest.test_parse_output_with_failing_line): Added a call to _filter_output. Also added ',' after 'Time:' so that it's not string-concatenated with the next line. (MainTest.test_parse_output_with_description): Added; a test for PerfTest.description(). (MainTest.test_parse_output_with_subtests): Removed the expected logs, and added a call to _filter_output. Modified Paths trunk/Tools/ChangeLog trunk/Tools/Scripts/webkitpy/performance_tests/perftest.py trunk/Tools/Scripts/webkitpy/performance_tests/perftest_unittest.py Diff Modified: trunk/Tools/ChangeLog (138191 => 138192) --- trunk/Tools/ChangeLog 2012-12-19 21:06:03 UTC (rev 138191) +++ trunk/Tools/ChangeLog 2012-12-19 21:31:11 UTC (rev 138192) @@ -1,3 +1,35 @@ +2012-12-19 Ryosuke Niwa rn...@webkit.org + +PerfTest.parse_output does too much +https://bugs.webkit.org/show_bug.cgi?id=105391 + +Reviewed by Tony Chang. + +Moved the code to filter lines into PerfTest._filter_output, which has been renamed from _filter_stderr. +Also moved the code to output test results into PerfTest._run_with_driver. + +* Scripts/webkitpy/performance_tests/perftest.py: +(PerfTest.__init__): Added _description. +(PerfTest.description): Added. +(PerfTest._run_with_driver): Moved the code to output test description and test results. +(PerfTest._filter_output): Moved and renamed from PerfTest._filter_stderr. +(PerfTest.parse_output): Removed the code to output test results. Return test results and description +respectively. Also removed the code that allowed some tests to omit values since all tests report each +iteration now since r136492. +(PerfTest.output_statistics): Removed the code to print test description, now done in _run_with_driver. +(ChromiumStylePerfTest._run_with_driver): Added. Chromium style tests are sufficiently different from +regular PerfTest that it doesn't make much sense to share _run_with_driver. But really, we should just +get rid of this type of test altogether in favor of regular performance tests that uses runner.js. +(ChromiumStylePerfTest.parse_and_log_output): Renamed from parse_output. +(PageLoadingPerfTest._run_with_driver): Removed the explicit '' for the test description. +* Scripts/webkitpy/performance_tests/perftest_unittest.py: +(MainTest.test_parse_output): Removed the expected logs since parse_output no longer prints out results. +Also added a call to _filter_output since parse_output doesn't filter the output text anymore. +(MainTest.test_parse_output_with_failing_line): Added a call to _filter_output. Also added ',' after 'Time:' +so that it's not string-concatenated with the next line. +(MainTest.test_parse_output_with_description): Added; a test for PerfTest.description(). +(MainTest.test_parse_output_with_subtests): Removed the expected logs, and added a call to _filter_output. + 2012-12-19 Alexis Menard ale...@webkit.org Implement CSS parsing for CSS transitions unprefixed. Modified: trunk/Tools/Scripts/webkitpy/performance_tests/perftest.py (138191 =>
[webkit-changes] [138194] trunk/Source/WTF
Title: [138194] trunk/Source/WTF
Revision 138194
Author oli...@apple.com
Date 2012-12-19 13:59:25 -0800 (Wed, 19 Dec 2012)
Log Message
StringImpl isolatedCopy unnecessarily copies text-segment character data
https://bugs.webkit.org/show_bug.cgi?id=105376
Reviewed by Anders Carlsson.
This patch adds a new (private) helper to StringImpl that tests whether the StringImpl
is backed by an ASCII literal. This allows isolatedCopy() to safely use the createFromLiteral
constructor rather than making an unnecessary copy.
* wtf/text/StringImpl.h:
(StringImpl):
(WTF::StringImpl::isASCIILiteral):
(WTF::StringImpl::isolatedCopy):
Modified Paths
trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/text/StringImpl.h
Diff
Modified: trunk/Source/WTF/ChangeLog (138193 => 138194)
--- trunk/Source/WTF/ChangeLog 2012-12-19 21:32:15 UTC (rev 138193)
+++ trunk/Source/WTF/ChangeLog 2012-12-19 21:59:25 UTC (rev 138194)
@@ -1,5 +1,21 @@
2012-12-19 Oliver Hunt oli...@apple.com
+StringImpl isolatedCopy unnecessarily copies text-segment character data
+https://bugs.webkit.org/show_bug.cgi?id=105376
+
+Reviewed by Anders Carlsson.
+
+This patch adds a new (private) helper to StringImpl that tests whether the StringImpl
+is backed by an ASCII literal. This allows isolatedCopy() to safely use the createFromLiteral
+constructor rather than making an unnecessary copy.
+
+* wtf/text/StringImpl.h:
+(StringImpl):
+(WTF::StringImpl::isASCIILiteral):
+(WTF::StringImpl::isolatedCopy):
+
+2012-12-19 Oliver Hunt oli...@apple.com
+
WTF String from ASCIILiteral fails to correctly handle empty strings.
https://bugs.webkit.org/show_bug.cgi?id=105453
Modified: trunk/Source/WTF/wtf/text/StringImpl.h (138193 => 138194)
--- trunk/Source/WTF/wtf/text/StringImpl.h 2012-12-19 21:32:15 UTC (rev 138193)
+++ trunk/Source/WTF/wtf/text/StringImpl.h 2012-12-19 21:59:25 UTC (rev 138194)
@@ -729,6 +729,12 @@
#endif
private:
+
+bool isASCIILiteral() const
+{
+return is8Bit() hasInternalBuffer() reinterpret_castconst void*(m_data8) != reinterpret_castconst void*(this + 1);
+}
+
// This number must be at least 2 to avoid sharing empty, null as well as 1 character strings from SmallStrings.
static const unsigned s_copyCharsInlineCutOff = 20;
@@ -1126,6 +1132,8 @@
inline PassRefPtrStringImpl StringImpl::isolatedCopy() const
{
+if (isASCIILiteral())
+return StringImpl::createFromLiteral(reinterpret_castconst char*(m_data8), m_length);
if (is8Bit())
return create(m_data8, m_length);
return create(m_data16, m_length);
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [138195] trunk/Source/WebCore
Title: [138195] trunk/Source/WebCore Revision 138195 Author an...@apple.com Date 2012-12-19 14:39:28 -0800 (Wed, 19 Dec 2012) Log Message Use ElementTraversal in LiveNodeListBase https://bugs.webkit.org/show_bug.cgi?id=105324 Reviewed by Ryosuke Niwa. Factor the code so that we get clean minimally branchy traversal functions for all the common cases. This patch changes the more performance critical forward traversal only, backwards traversal is unaffected for now. Instruments thinks it is a progression at least in DOM/DOMDivWalk.html. Bots should tell more. * dom/ClassNodeList.cpp: (WebCore::ClassNodeList::nodeMatches): * dom/ClassNodeList.h: (ClassNodeList): (WebCore::ClassNodeList::create): (WebCore): (WebCore::ClassNodeList::nodeMatchesInlined): Add inlined version of the matching function for class lists. * dom/LiveNodeList.cpp: (WebCore::LiveNodeListBase::rootContainerNode): Root is always ContainerNode if the list has anything in it. Traversal functions are slightly more efficient if we know we are operating on ContainerNodes. (WebCore): * dom/LiveNodeList.h: (LiveNodeListBase): (WebCore::LiveNodeListBase::shouldOnlyIncludeDirectChildren): * dom/Node.cpp: (WebCore::Node::getElementsByTagName): * dom/TagNodeList.cpp: (WebCore::TagNodeList::TagNodeList): (WebCore::TagNodeList::~TagNodeList): (WebCore::HTMLTagNodeList::HTMLTagNodeList): (WebCore::HTMLTagNodeList::nodeMatches): * dom/TagNodeList.h: (WebCore): (TagNodeList): (WebCore::TagNodeList::create): (HTMLTagNodeList): (WebCore::HTMLTagNodeList::create): Use separate ContainerType enum value for HTMLTagNodeList so we can tell it apart from TagNodeList. (WebCore::HTMLTagNodeList::nodeMatchesInlined): Add inlined version of the matching function for tag lists. * html/CollectionType.h: * html/HTMLCollection.cpp: (WebCore::shouldOnlyIncludeDirectChildren): (WebCore::rootTypeFromCollectionType): (WebCore::invalidationTypeExcludingIdAndNameAttributes): (WebCore): (WebCore::isMatchingElement): List type templated matching functions for common cases. (WebCore::HTMLCollection::HTMLCollection): (WebCore::HTMLCollection::create): (WebCore::HTMLCollection::~HTMLCollection): (WebCore::previousNode): (WebCore::lastNode): (WebCore::LiveNodeListBase::iterateForPreviousNode): (WebCore::LiveNodeListBase::itemBefore): Leave the backwards traversal unchanged for now but remove the forward traversal code. (WebCore::firstMatchingElement): (WebCore::nextMatchingElement): (WebCore::firstMatchingChildElement): (WebCore::nextMatchingChildElement): (WebCore::traverseMatchingElementsForwardToOffset): List type templated traversal functions with matching. Separate functions for first and subsequent elements (WebCore::LiveNodeListBase::traverseChildNodeListForwardToOffset): (WebCore::LiveNodeListBase::traverseLiveNodeListFirstElement): (WebCore::LiveNodeListBase::traverseLiveNodeListForwardToOffset): LiveNodeList traversal, picking the right template. (WebCore::LiveNodeListBase::item): (WebCore::LiveNodeListBase::itemBeforeOrAfterCachedItem): Switch to new traversal functions. (WebCore::HTMLCollection::traverseFirstElement): (WebCore::HTMLCollection::traverseForwardToOffset): (WebCore::HTMLCollection::traverseNextElement): HTMLCollection traversal, picking the right template. (WebCore::HTMLCollection::namedItem): (WebCore::HTMLCollection::updateNameCache): Switch to new traversal functions. * html/HTMLCollection.h: (HTMLCollection): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/dom/ClassNodeList.cpp trunk/Source/WebCore/dom/ClassNodeList.h trunk/Source/WebCore/dom/LiveNodeList.cpp trunk/Source/WebCore/dom/LiveNodeList.h trunk/Source/WebCore/dom/Node.cpp trunk/Source/WebCore/dom/TagNodeList.cpp trunk/Source/WebCore/dom/TagNodeList.h trunk/Source/WebCore/html/CollectionType.h trunk/Source/WebCore/html/HTMLCollection.cpp trunk/Source/WebCore/html/HTMLCollection.h Diff Modified: trunk/Source/WebCore/ChangeLog (138194 => 138195) --- trunk/Source/WebCore/ChangeLog 2012-12-19 21:59:25 UTC (rev 138194) +++ trunk/Source/WebCore/ChangeLog 2012-12-19 22:39:28 UTC (rev 138195) @@ -1,3 +1,109 @@ +2012-12-19 Antti Koivisto an...@apple.com + +Use ElementTraversal in LiveNodeListBase +https://bugs.webkit.org/show_bug.cgi?id=105324 + +Reviewed by Ryosuke Niwa. + +Factor the code so that we get clean minimally branchy traversal functions for all the common cases. + +This patch changes the more performance critical forward traversal only, backwards traversal is unaffected for now. + +Instruments thinks it is a progression at least in DOM/DOMDivWalk.html. Bots should tell more. + +* dom/ClassNodeList.cpp: +(WebCore::ClassNodeList::nodeMatches): +* dom/ClassNodeList.h: +(ClassNodeList): +(WebCore::ClassNodeList::create): +(WebCore): +
[webkit-changes] [138196] trunk
Title: [138196] trunk
Revision 138196
Author e...@chromium.org
Date 2012-12-19 15:07:55 -0800 (Wed, 19 Dec 2012)
Log Message
[Regression] text-overflow ellipsis clips content when zoomed
https://bugs.webkit.org/show_bug.cgi?id=105456
Reviewed by Levi Weintraub.
Source/WebCore:
At certain zoom levels text-overflow ellipsis incorrectly clips
content and displays the ellipsis even though the full content
would fit.
Test: fast/sub-pixel/ellipsis-zoom.html
* rendering/RenderBlock.h:
(WebCore::RenderBlock::pixelSnappedLogicalRightOffsetForLine):
Add bug url to FIXME.
* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::checkLinesForTextOverflow):
Pixel snap the content edge before comparing with the line box
edge as the line box edge is aligned to a pixel boundary.
LayoutTests:
Add test for text-overflow: ellipsis.
* fast/sub-pixel/ellipsis-zoom-expected.html: Added.
* fast/sub-pixel/ellipsis-zoom.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderBlock.h
trunk/Source/WebCore/rendering/RenderBlockLineLayout.cpp
Added Paths
trunk/LayoutTests/fast/sub-pixel/ellipsis-zoom-expected.html
trunk/LayoutTests/fast/sub-pixel/ellipsis-zoom.html
Diff
Modified: trunk/LayoutTests/ChangeLog (138195 => 138196)
--- trunk/LayoutTests/ChangeLog 2012-12-19 22:39:28 UTC (rev 138195)
+++ trunk/LayoutTests/ChangeLog 2012-12-19 23:07:55 UTC (rev 138196)
@@ -1,3 +1,15 @@
+2012-12-19 Emil A Eklund e...@chromium.org
+
+[Regression] text-overflow ellipsis clips content when zoomed
+https://bugs.webkit.org/show_bug.cgi?id=105456
+
+Reviewed by Levi Weintraub.
+
+Add test for text-overflow: ellipsis.
+
+* fast/sub-pixel/ellipsis-zoom-expected.html: Added.
+* fast/sub-pixel/ellipsis-zoom.html: Added.
+
2012-12-19 Levi Weintraub le...@chromium.org
Re-skipping touch-input-element-chang-documents.html since it's still
Added: trunk/LayoutTests/fast/sub-pixel/ellipsis-zoom-expected.html (0 => 138196)
--- trunk/LayoutTests/fast/sub-pixel/ellipsis-zoom-expected.html (rev 0)
+++ trunk/LayoutTests/fast/sub-pixel/ellipsis-zoom-expected.html 2012-12-19 23:07:55 UTC (rev 138196)
@@ -0,0 +1,45 @@
+!DOCTYPE html
+html
+head
+style
+.test div { display: inline-block; white-space: nowrap; padding: 0 1px; }
+/style
+/head
+body
+div class=test style=zoom: 0.5;
+div class=ellipsisShould not be truncated/divbr
+div class=expectedShould not be truncated/div
+/div
+div class=test style=zoom: 0.66;
+div class=ellipsisShould not be truncated/divbr
+div class=expectedShould not be truncated/div
+/div
+div class=test style=zoom: 0.75;
+div class=ellipsisShould not be truncated/divbr
+div class=expectedShould not be truncated/div
+/div
+div class=test style=zoom: 0.9;
+div class=ellipsisShould not be truncated/divbr
+div class=expectedShould not be truncated/div
+/div
+div class=test style=zoom: 1.0;
+div class=ellipsisShould not be truncated/divbr
+div class=expectedShould not be truncated/div
+/div
+div class=test style=zoom: 1.1;
+div class=ellipsisShould not be truncated/divbr
+div class=expectedShould not be truncated/div
+/div
+div class=test style=zoom: 1.25;
+div class=ellipsisShould not be truncated/divbr
+div class=expectedShould not be truncated/div
+/div
+div class=test style=zoom: 1.33;
+div class=ellipsisShould not be truncated/divbr
+div class=expectedShould not be truncated/div
+/div
+p
+None of the lines above should be truncated.
+/p
+/body
+/html
Added: trunk/LayoutTests/fast/sub-pixel/ellipsis-zoom.html (0 => 138196)
--- trunk/LayoutTests/fast/sub-pixel/ellipsis-zoom.html (rev 0)
+++ trunk/LayoutTests/fast/sub-pixel/ellipsis-zoom.html 2012-12-19 23:07:55 UTC (rev 138196)
@@ -0,0 +1,46 @@
+!DOCTYPE html
+html
+head
+style
+.test div { display: inline-block; overflow: hidden; white-space: nowrap; padding: 0 1px; }
+.test .ellipsis { text-overflow: ellipsis; }
+/style
+/head
+body
+div class=test style=zoom: 0.5;
+div class=ellipsisShould not be truncated/divbr
+div class=expectedShould not be truncated/div
+/div
+div class=test style=zoom: 0.66;
+div class=ellipsisShould not be truncated/divbr
+div class=expectedShould not be truncated/div
+/div
+div class=test style=zoom: 0.75;
+div class=ellipsisShould not be truncated/divbr
+div class=expectedShould not
[webkit-changes] [138197] trunk/LayoutTests
Title: [138197] trunk/LayoutTests Revision 138197 Author wjmacl...@chromium.org Date 2012-12-19 15:21:09 -0800 (Wed, 19 Dec 2012) Log Message [chromium] composited scrolling tests failing on Win https://bugs.webkit.org/show_bug.cgi?id=105471 Unreviewed gardening. Mark tests as failing on Win: platform/chromium/virtual/gpu/compositedscrolling/overflow/scrolling-without-painting.html platform/chromium/virtual/gpu/compositedscrolling/overflow/updating-scrolling-content.html * platform/chromium/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (138196 => 138197) --- trunk/LayoutTests/ChangeLog 2012-12-19 23:07:55 UTC (rev 138196) +++ trunk/LayoutTests/ChangeLog 2012-12-19 23:21:09 UTC (rev 138197) @@ -1,3 +1,17 @@ +2012-12-19 W. James MacLean wjmacl...@chromium.org + +[chromium] composited scrolling tests failing on Win +https://bugs.webkit.org/show_bug.cgi?id=105471 + +Unreviewed gardening. + +Mark tests as failing on Win: + +platform/chromium/virtual/gpu/compositedscrolling/overflow/scrolling-without-painting.html +platform/chromium/virtual/gpu/compositedscrolling/overflow/updating-scrolling-content.html + +* platform/chromium/TestExpectations: + 2012-12-19 Emil A Eklund e...@chromium.org [Regression] text-overflow ellipsis clips content when zoomed Modified: trunk/LayoutTests/platform/chromium/TestExpectations (138196 => 138197) --- trunk/LayoutTests/platform/chromium/TestExpectations 2012-12-19 23:07:55 UTC (rev 138196) +++ trunk/LayoutTests/platform/chromium/TestExpectations 2012-12-19 23:21:09 UTC (rev 138197) @@ -4235,3 +4235,6 @@ webkit.org/b/104848 [ SnowLeopard Debug ] fast/frames/sandboxed-iframe-attribute-parsing.html [ Pass Failure ] webkit.org/b/104848 [ Release ] fast/frames/sandboxed-iframe-parsing-space-characters.html [ Pass Failure ] +webkit.org/b/105471 [ Win ] platform/chromium/virtual/gpu/compositedscrolling/overflow/scrolling-without-painting.html +webkit.org/b/105471 [ Win ] platform/chromium/virtual/gpu/compositedscrolling/overflow/updating-scrolling-content.html + ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [138198] trunk/LayoutTests
Title: [138198] trunk/LayoutTests Revision 138198 Author wjmacl...@chromium.org Date 2012-12-19 15:27:27 -0800 (Wed, 19 Dec 2012) Log Message [chromium] plugins/npp-set-window-called-during-destruction.html is flaky on Win http://crbug.com/78835 Unreviewed gardening. * platform/chromium/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (138197 => 138198) --- trunk/LayoutTests/ChangeLog 2012-12-19 23:21:09 UTC (rev 138197) +++ trunk/LayoutTests/ChangeLog 2012-12-19 23:27:27 UTC (rev 138198) @@ -1,5 +1,14 @@ 2012-12-19 W. James MacLean wjmacl...@chromium.org +[chromium] plugins/npp-set-window-called-during-destruction.html is flaky on Win +http://crbug.com/78835 + +Unreviewed gardening. + +* platform/chromium/TestExpectations: + +2012-12-19 W. James MacLean wjmacl...@chromium.org + [chromium] composited scrolling tests failing on Win https://bugs.webkit.org/show_bug.cgi?id=105471 Modified: trunk/LayoutTests/platform/chromium/TestExpectations (138197 => 138198) --- trunk/LayoutTests/platform/chromium/TestExpectations 2012-12-19 23:21:09 UTC (rev 138197) +++ trunk/LayoutTests/platform/chromium/TestExpectations 2012-12-19 23:27:27 UTC (rev 138198) @@ -2649,6 +2649,7 @@ crbug.com/780807 http/tests/misc/webtiming-origins.html [ Failure Pass ] crbug.com/78835 [ Mac ] plugins/npp-set-window-called-during-destruction.html [ Failure ] +crbug.com/78835 [ Win ] plugins/npp-set-window-called-during-destruction.html [ Failure Pass ] # http://trac.webkit.org/changeset/83411/ merged some frame tests into one. # The merged test is flaky on Chromium since then. crbug.com/78998 [ Debug ] fast/frames/frame-element-name.html [ Failure Pass ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [138199] trunk/Source/JavaScriptCore
Title: [138199] trunk/Source/_javascript_Core
Revision 138199
Author oli...@apple.com
Date 2012-12-19 15:36:13 -0800 (Wed, 19 Dec 2012)
Log Message
Tidy up JSScriptRef API
https://bugs.webkit.org/show_bug.cgi?id=105470
Reviewed by Anders Carlsson.
People found the API's use of a context confusing, so we'll switch to a JSContextGroup based
API, and drop a number of the unnecessary uses of contexts.
* API/JSScriptRef.cpp:
(OpaqueJSScript::globalData):
(parseScript):
* API/JSScriptRefPrivate.h:
* API/tests/testapi.c:
(main):
Modified Paths
trunk/Source/_javascript_Core/API/JSScriptRef.cpp
trunk/Source/_javascript_Core/API/JSScriptRefPrivate.h
trunk/Source/_javascript_Core/API/tests/testapi.c
trunk/Source/_javascript_Core/ChangeLog
Diff
Modified: trunk/Source/_javascript_Core/API/JSScriptRef.cpp (138198 => 138199)
--- trunk/Source/_javascript_Core/API/JSScriptRef.cpp 2012-12-19 23:27:27 UTC (rev 138198)
+++ trunk/Source/_javascript_Core/API/JSScriptRef.cpp 2012-12-19 23:36:13 UTC (rev 138199)
@@ -32,6 +32,7 @@
#include JSGlobalData.h
#include JSScriptRefPrivate.h
#include OpaqueJSString.h
+#include Parser.h
#include SourceCode.h
#include SourceProvider.h
@@ -49,7 +50,7 @@
return m_source;
}
-const JSGlobalData* globalData() const { return m_globalData; }
+JSGlobalData* globalData() const { return m_globalData; }
private:
OpaqueJSScript(JSGlobalData* globalData, const String url, int startingLineNumber, const String source)
@@ -65,60 +66,64 @@
String m_source;
};
+static bool parseScript(JSGlobalData* globalData, const SourceCode source, ParserError error)
+{
+return JSC::parseJSC::ProgramNode(globalData, source, 0, Identifier(), JSParseNormal, JSParseProgramCode, error);
+}
+
extern C {
-JSScriptRef JSScriptCreateReferencingImmortalASCIIText(JSContextRef context, JSStringRef url, int startingLineNumber, const char* source, size_t length, JSValueRef* exception)
+JSScriptRef JSScriptCreateReferencingImmortalASCIIText(JSContextGroupRef contextGroup, JSStringRef url, int startingLineNumber, const char* source, size_t length, JSStringRef* errorMessage, int* errorLine)
{
-ExecState* exec = toJS(context);
-APIEntryShim entryShim(exec);
-JSGlobalData* globalData = exec-globalData();
+JSGlobalData* globalData = toJS(contextGroup);
+APIEntryShim entryShim(globalData);
for (size_t i = 0; i length; i++) {
if (!isASCII(source[i]))
return 0;
}
RefPtrOpaqueJSScript result = OpaqueJSScript::create(globalData, url-string(), startingLineNumber, String(StringImpl::createFromLiteral(source, length)));
-JSValue exceptionValue;
-if (!checkSyntax(exec, SourceCode(result), exceptionValue)) {
-if (exception)
-*exception = toRef(exec, exceptionValue);
+
+ParserError error;
+if (!parseScript(globalData, SourceCode(result), error)) {
+if (errorMessage)
+*errorMessage = OpaqueJSString::create(error.m_message).leakRef();
+if (errorLine)
+*errorLine = error.m_line;
return 0;
}
return result.release().leakRef();
}
-JSScriptRef JSScriptCreateFromString(JSContextRef context, JSStringRef url, int startingLineNumber, JSStringRef source, JSValueRef* exception)
+JSScriptRef JSScriptCreateFromString(JSContextGroupRef contextGroup, JSStringRef url, int startingLineNumber, JSStringRef source, JSStringRef* errorMessage, int* errorLine)
{
-ExecState* exec = toJS(context);
-APIEntryShim entryShim(exec);
-JSGlobalData* globalData = exec-globalData();
+JSGlobalData* globalData = toJS(contextGroup);
+APIEntryShim entryShim(globalData);
RefPtrOpaqueJSScript result = OpaqueJSScript::create(globalData, url-string(), startingLineNumber, source-string());
-JSValue exceptionValue;
-if (!checkSyntax(exec, SourceCode(result), exceptionValue)) {
-if (exception)
-*exception = toRef(exec, exceptionValue);
+
+ParserError error;
+if (!parseScript(globalData, SourceCode(result), error)) {
+if (errorMessage)
+*errorMessage = OpaqueJSString::create(error.m_message).leakRef();
+if (errorLine)
+*errorLine = error.m_line;
return 0;
}
+
return result.release().leakRef();
}
-void JSScriptRetain(JSContextRef context, JSScriptRef script)
+void JSScriptRetain(JSScriptRef script)
{
-ExecState* exec = toJS(context);
-APIEntryShim entryShim(exec);
-if (script-globalData() != exec-globalData())
-CRASH();
+APIEntryShim entryShim(script-globalData());
script-ref();
}
-void JSScriptRelease(JSContextRef context, JSScriptRef script)
+void JSScriptRelease(JSScriptRef script)
{
-ExecState* exec = toJS(context);
-APIEntryShim entryShim(exec);
-if (script-globalData() != exec-globalData())
-CRASH();
+APIEntryShim entryShim(script-globalData());
script-deref();
}
[webkit-changes] [138202] trunk/Source/WebCore
Title: [138202] trunk/Source/WebCore
Revision 138202
Author simon...@chromium.org
Date 2012-12-19 16:27:40 -0800 (Wed, 19 Dec 2012)
Log Message
Set the original resource's response even on a 304
https://bugs.webkit.org/show_bug.cgi?id=105373
Reviewed by Nate Chapin.
The existing setResponse was renamed to responseReceived to better reflect what it does. A new
setResponse was added that only sets the response. This is used in the 304 case.
No new tests. A new Resource Timing test will depend on this soon.
* loader/SubresourceLoader.cpp:
(WebCore::SubresourceLoader::didReceiveResponse):
* loader/cache/CachedImage.cpp:
(WebCore::CachedImage::responseReceived):
* loader/cache/CachedImage.h:
(CachedImage):
* loader/cache/CachedRawResource.cpp:
(WebCore::CachedRawResource::responseReceived):
* loader/cache/CachedRawResource.h:
(CachedRawResource):
* loader/cache/CachedResource.cpp:
(WebCore::CachedResource::responseReceived):
* loader/cache/CachedResource.h:
(CachedResource):
(WebCore::CachedResource::setResponse):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/loader/SubresourceLoader.cpp
trunk/Source/WebCore/loader/cache/CachedImage.cpp
trunk/Source/WebCore/loader/cache/CachedImage.h
trunk/Source/WebCore/loader/cache/CachedRawResource.cpp
trunk/Source/WebCore/loader/cache/CachedRawResource.h
trunk/Source/WebCore/loader/cache/CachedResource.cpp
trunk/Source/WebCore/loader/cache/CachedResource.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (138201 => 138202)
--- trunk/Source/WebCore/ChangeLog 2012-12-20 00:19:03 UTC (rev 138201)
+++ trunk/Source/WebCore/ChangeLog 2012-12-20 00:27:40 UTC (rev 138202)
@@ -1,3 +1,31 @@
+2012-12-18 James Simonsen simon...@chromium.org
+
+Set the original resource's response even on a 304
+https://bugs.webkit.org/show_bug.cgi?id=105373
+
+Reviewed by Nate Chapin.
+
+The existing setResponse was renamed to responseReceived to better reflect what it does. A new
+setResponse was added that only sets the response. This is used in the 304 case.
+
+No new tests. A new Resource Timing test will depend on this soon.
+
+* loader/SubresourceLoader.cpp:
+(WebCore::SubresourceLoader::didReceiveResponse):
+* loader/cache/CachedImage.cpp:
+(WebCore::CachedImage::responseReceived):
+* loader/cache/CachedImage.h:
+(CachedImage):
+* loader/cache/CachedRawResource.cpp:
+(WebCore::CachedRawResource::responseReceived):
+* loader/cache/CachedRawResource.h:
+(CachedRawResource):
+* loader/cache/CachedResource.cpp:
+(WebCore::CachedResource::responseReceived):
+* loader/cache/CachedResource.h:
+(CachedResource):
+(WebCore::CachedResource::setResponse):
+
2012-12-19 Emil A Eklund e...@chromium.org
[Regression] text-overflow ellipsis clips content when zoomed
Modified: trunk/Source/WebCore/loader/SubresourceLoader.cpp (138201 => 138202)
--- trunk/Source/WebCore/loader/SubresourceLoader.cpp 2012-12-20 00:19:03 UTC (rev 138201)
+++ trunk/Source/WebCore/loader/SubresourceLoader.cpp 2012-12-20 00:27:40 UTC (rev 138202)
@@ -171,6 +171,7 @@
if (response.httpStatusCode() == 304) {
// 304 Not modified / Use local copy
// Existing resource is ok, just use it updating the expiration time.
+m_resource-setResponse(response);
memoryCache()-revalidationSucceeded(m_resource, response);
if (!reachedTerminalState())
ResourceLoader::didReceiveResponse(response);
@@ -180,7 +181,7 @@
memoryCache()-revalidationFailed(m_resource);
}
-m_resource-setResponse(response);
+m_resource-responseReceived(response);
if (reachedTerminalState())
return;
ResourceLoader::didReceiveResponse(response);
Modified: trunk/Source/WebCore/loader/cache/CachedImage.cpp (138201 => 138202)
--- trunk/Source/WebCore/loader/cache/CachedImage.cpp 2012-12-20 00:19:03 UTC (rev 138201)
+++ trunk/Source/WebCore/loader/cache/CachedImage.cpp 2012-12-20 00:27:40 UTC (rev 138202)
@@ -404,11 +404,11 @@
notifyObservers();
}
-void CachedImage::setResponse(const ResourceResponse response)
+void CachedImage::responseReceived(const ResourceResponse response)
{
if (!m_response.isNull())
clear();
-CachedResource::setResponse(response);
+CachedResource::responseReceived(response);
}
void CachedImage::destroyDecodedData()
Modified: trunk/Source/WebCore/loader/cache/CachedImage.h (138201 => 138202)
--- trunk/Source/WebCore/loader/cache/CachedImage.h 2012-12-20 00:19:03 UTC (rev 138201)
+++ trunk/Source/WebCore/loader/cache/CachedImage.h 2012-12-20 00:27:40 UTC (rev 138202)
@@ -78,7 +78,7 @@
virtual void data(PassRefPtrResourceBuffer data, bool allDataReceived);
virtual void error(CachedResource::Status);
-virtual void setResponse(const ResourceResponse);
+
[webkit-changes] [138203] trunk/Source/WebKit2
Title: [138203] trunk/Source/WebKit2
Revision 138203
Author jon...@apple.com
Date 2012-12-19 16:38:22 -0800 (Wed, 19 Dec 2012)
Log Message
Add a function to set the origin hash table
https://bugs.webkit.org/show_bug.cgi?id=105447
rdar://problem/12910985
Reviewed by Brian Weinstein.
Add a new API called WKContextSetPlugInAutoStartOriginHashes. It assigns the table of hashes,
keyed by main frame origin, to the WebContext. That, in turn, notifies all existing web
processes, so that each web process can update its copy of the auto-start hashes.
* UIProcess/API/C/WKContext.cpp:
(WKContextSetPlugInAutoStartOriginHashes): To clear the table, an empty dictionary must be
provided.
* UIProcess/API/C/WKContext.h:
* UIProcess/WebContext.cpp:
(WebKit::WebContext::setPlugInAutoStartOriginHashes): Forward to PlugInAutoStartProvider.
* UIProcess/WebContext.h:
* UIProcess/Plugins/PlugInAutoStartProvider.cpp:
(WebKit::PlugInAutoStartProvider::setAutoStartOriginsTable): Clear the map and set of hashes,
and convert the data from the provided dictionary. Also add it to a temporary vector, which will
be used to pass along to all of the active web processes.
* UIProcess/Plugins/PlugInAutoStartProvider.h:
* WebProcess/WebProcess.messages.in: Add plugInAutoStartOriginsChanged. Takes in a vector of
the new set of hashes.
* WebProcess/WebProcess.cpp:
(WebKit::WebProcess::plugInAutoStartOriginsChanged): Clear the existing set, and copy the new
hashes.
* WebProcess/WebProcess.h:
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/C/WKContext.cpp
trunk/Source/WebKit2/UIProcess/API/C/WKContext.h
trunk/Source/WebKit2/UIProcess/Plugins/PlugInAutoStartProvider.cpp
trunk/Source/WebKit2/UIProcess/Plugins/PlugInAutoStartProvider.h
trunk/Source/WebKit2/UIProcess/WebContext.cpp
trunk/Source/WebKit2/UIProcess/WebContext.h
trunk/Source/WebKit2/WebProcess/WebProcess.cpp
trunk/Source/WebKit2/WebProcess/WebProcess.h
trunk/Source/WebKit2/WebProcess/WebProcess.messages.in
Diff
Modified: trunk/Source/WebKit2/ChangeLog (138202 => 138203)
--- trunk/Source/WebKit2/ChangeLog 2012-12-20 00:27:40 UTC (rev 138202)
+++ trunk/Source/WebKit2/ChangeLog 2012-12-20 00:38:22 UTC (rev 138203)
@@ -1,3 +1,37 @@
+2012-12-19 Jon Lee jon...@apple.com
+
+Add a function to set the origin hash table
+https://bugs.webkit.org/show_bug.cgi?id=105447
+rdar://problem/12910985
+
+Reviewed by Brian Weinstein.
+
+Add a new API called WKContextSetPlugInAutoStartOriginHashes. It assigns the table of hashes,
+keyed by main frame origin, to the WebContext. That, in turn, notifies all existing web
+processes, so that each web process can update its copy of the auto-start hashes.
+
+* UIProcess/API/C/WKContext.cpp:
+(WKContextSetPlugInAutoStartOriginHashes): To clear the table, an empty dictionary must be
+provided.
+* UIProcess/API/C/WKContext.h:
+
+* UIProcess/WebContext.cpp:
+(WebKit::WebContext::setPlugInAutoStartOriginHashes): Forward to PlugInAutoStartProvider.
+* UIProcess/WebContext.h:
+
+* UIProcess/Plugins/PlugInAutoStartProvider.cpp:
+(WebKit::PlugInAutoStartProvider::setAutoStartOriginsTable): Clear the map and set of hashes,
+and convert the data from the provided dictionary. Also add it to a temporary vector, which will
+be used to pass along to all of the active web processes.
+* UIProcess/Plugins/PlugInAutoStartProvider.h:
+
+* WebProcess/WebProcess.messages.in: Add plugInAutoStartOriginsChanged. Takes in a vector of
+the new set of hashes.
+* WebProcess/WebProcess.cpp:
+(WebKit::WebProcess::plugInAutoStartOriginsChanged): Clear the existing set, and copy the new
+hashes.
+* WebProcess/WebProcess.h:
+
2012-12-18 Jon Lee jon...@apple.com
Notify context client of change to table, and allow client to get a copy of it
Modified: trunk/Source/WebKit2/UIProcess/API/C/WKContext.cpp (138202 => 138203)
--- trunk/Source/WebKit2/UIProcess/API/C/WKContext.cpp 2012-12-20 00:27:40 UTC (rev 138202)
+++ trunk/Source/WebKit2/UIProcess/API/C/WKContext.cpp 2012-12-20 00:38:22 UTC (rev 138203)
@@ -342,6 +342,13 @@
return toAPI(toImpl(contextRef)-plugInAutoStartOriginHashes().leakRef());
}
+void WKContextSetPlugInAutoStartOriginHashes(WKContextRef contextRef, WKDictionaryRef dictionaryRef)
+{
+if (!dictionaryRef)
+return;
+toImpl(contextRef)-setPlugInAutoStartOriginHashes(*toImpl(dictionaryRef));
+}
+
// Deprecated functions.
void _WKContextSetAdditionalPluginsDirectory(WKContextRef context, WKStringRef pluginsDirectory)
{
Modified: trunk/Source/WebKit2/UIProcess/API/C/WKContext.h (138202 => 138203)
--- trunk/Source/WebKit2/UIProcess/API/C/WKContext.h 2012-12-20 00:27:40 UTC (rev 138202)
+++ trunk/Source/WebKit2/UIProcess/API/C/WKContext.h 2012-12-20 00:38:22 UTC (rev 138203)
@@ -191,6 +191,7 @@
[webkit-changes] [138204] trunk/Source/WebCore
Title: [138204] trunk/Source/WebCore
Revision 138204
Author k...@webkit.org
Date 2012-12-19 16:40:01 -0800 (Wed, 19 Dec 2012)
Log Message
Unreviewed. Add new strings to GTK+'s implementation of
LocalizedStrings, using glib's context-aware macro.
* platform/gtk/LocalizedStringsGtk.cpp:
(WebCore):
(WebCore::textTrackClosedCaptionsText):
(WebCore::textTrackSubtitlesText):
(WebCore::textTrackOffText):
(WebCore::textTrackNoLabelText):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/gtk/LocalizedStringsGtk.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (138203 => 138204)
--- trunk/Source/WebCore/ChangeLog 2012-12-20 00:38:22 UTC (rev 138203)
+++ trunk/Source/WebCore/ChangeLog 2012-12-20 00:40:01 UTC (rev 138204)
@@ -1,3 +1,15 @@
+2012-12-19 Gustavo Noronha Silva g...@gnome.org
+
+Unreviewed. Add new strings to GTK+'s implementation of
+LocalizedStrings, using glib's context-aware macro.
+
+* platform/gtk/LocalizedStringsGtk.cpp:
+(WebCore):
+(WebCore::textTrackClosedCaptionsText):
+(WebCore::textTrackSubtitlesText):
+(WebCore::textTrackOffText):
+(WebCore::textTrackNoLabelText):
+
2012-12-18 James Simonsen simon...@chromium.org
Set the original resource's response even on a 304
Modified: trunk/Source/WebCore/platform/gtk/LocalizedStringsGtk.cpp (138203 => 138204)
--- trunk/Source/WebCore/platform/gtk/LocalizedStringsGtk.cpp 2012-12-20 00:38:22 UTC (rev 138203)
+++ trunk/Source/WebCore/platform/gtk/LocalizedStringsGtk.cpp 2012-12-20 00:40:01 UTC (rev 138204)
@@ -747,4 +747,26 @@
return validationMessageTypeMismatchText();
}
+#if ENABLE(VIDEO_TRACK)
+String textTrackClosedCaptionsText()
+{
+return String::fromUTF8(C_(Closed Captions, Menu section heading for closed captions));
}
+
+String textTrackSubtitlesText()
+{
+return String::fromUTF8(C_(Subtitles, Menu section heading for subtitles));
+}
+
+String textTrackOffText()
+{
+return String::fromUTF8(C_(Off, Menu item label for the track that represents disabling closed captions));
+}
+
+String textTrackNoLabelText()
+{
+return String::fromUTF8(C_(No label, Menu item label for a closed captions track that has no other name));
+}
+#endif
+
+}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [138205] trunk/Source/JavaScriptCore
Title: [138205] trunk/Source/_javascript_Core
Revision 138205
Author oli...@apple.com
Date 2012-12-19 16:50:48 -0800 (Wed, 19 Dec 2012)
Log Message
Fix some incorrect tests in testapi.c
Modified Paths
trunk/Source/_javascript_Core/API/tests/testapi.c
trunk/Source/_javascript_Core/ChangeLog
Diff
Modified: trunk/Source/_javascript_Core/API/tests/testapi.c (138204 => 138205)
--- trunk/Source/_javascript_Core/API/tests/testapi.c 2012-12-20 00:40:01 UTC (rev 138204)
+++ trunk/Source/_javascript_Core/API/tests/testapi.c 2012-12-20 00:50:48 UTC (rev 138205)
@@ -1634,8 +1634,8 @@
JSStringRef errorMessage = 0;
int errorLine = 0;
JSScriptRef scriptObject = JSScriptCreateFromString(contextGroup, url, 1, script, errorMessage, errorLine);
-ASSERT((!scriptObject) != (!exception));
-if (exception) {
+ASSERT((!scriptObject) != (!errorMessage));
+if (!scriptObject) {
printf(FAIL: Test script did not parse\n\t%s:%d\n\t, scriptPath, errorLine);
CFStringRef errorCF = JSStringCopyCFString(kCFAllocatorDefault, errorMessage);
CFShow(errorCF);
Modified: trunk/Source/_javascript_Core/ChangeLog (138204 => 138205)
--- trunk/Source/_javascript_Core/ChangeLog 2012-12-20 00:40:01 UTC (rev 138204)
+++ trunk/Source/_javascript_Core/ChangeLog 2012-12-20 00:50:48 UTC (rev 138205)
@@ -1,3 +1,12 @@
+2012-12-19 Oliver Hunt oli...@apple.com
+
+Fix some incorrect tests in testapi.c
+
+Reviewed by Simon Fraser.
+
+* API/tests/testapi.c:
+(main):
+
2012-12-19 Filip Pizlo fpi...@apple.com
JSObject::ensureIndexingType should gracefully handle InterceptsGetOwn..., and should never be called when the 'this' is not an object
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [138206] trunk/Source
Title: [138206] trunk/Source Revision 138206 Author a...@apple.com Date 2012-12-19 16:58:25 -0800 (Wed, 19 Dec 2012) Log Message rdar://problem/12890242 [WK2 NetworkProcess] Client doesn't receive SSL certificates https://bugs.webkit.org/show_bug.cgi?id=105467 Reviewed by Brady Eidson. Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/WebCore.exp.in trunk/Source/WebCore/platform/mac/WebCoreSystemInterface.h trunk/Source/WebCore/platform/mac/WebCoreSystemInterface.mm trunk/Source/WebCore/platform/network/cf/ResourceResponse.h trunk/Source/WebCore/platform/network/mac/ResourceResponseMac.mm trunk/Source/WebKit/mac/ChangeLog trunk/Source/WebKit/mac/WebCoreSupport/WebSystemInterface.mm trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/NetworkProcess/NetworkResourceLoader.cpp trunk/Source/WebKit2/Shared/mac/PlatformCertificateInfo.mm trunk/Source/WebKit2/WebProcess/Network/WebResourceLoader.cpp trunk/Source/WebKit2/WebProcess/Network/WebResourceLoader.h trunk/Source/WebKit2/WebProcess/Network/WebResourceLoader.messages.in trunk/Source/WebKit2/WebProcess/WebCoreSupport/mac/WebSystemInterface.mm Diff Modified: trunk/Source/WebCore/ChangeLog (138205 => 138206) --- trunk/Source/WebCore/ChangeLog 2012-12-20 00:50:48 UTC (rev 138205) +++ trunk/Source/WebCore/ChangeLog 2012-12-20 00:58:25 UTC (rev 138206) @@ -1,3 +1,21 @@ +2012-12-19 Alexey Proskuryakov a...@apple.com + +rdar://problem/12890242 [WK2 NetworkProcess] Client doesn't receive SSL certificates +https://bugs.webkit.org/show_bug.cgi?id=105467 + +Reviewed by Brady Eidson. + +Implement a way to store certificate chain in ResourceResponse separately from +NSURLResponse. There is no way to re-add it to a deserialized NSURLResponse. + +* WebCore.exp.in: +* platform/mac/WebCoreSystemInterface.h: +* platform/mac/WebCoreSystemInterface.mm: +* platform/network/cf/ResourceResponse.h: +* platform/network/mac/ResourceResponseMac.mm: +(WebCore::ResourceResponse::setCertificateChain): +(WebCore::ResourceResponse::certificateChain): + 2012-12-19 Gustavo Noronha Silva g...@gnome.org Unreviewed. Add new strings to GTK+'s implementation of Modified: trunk/Source/WebCore/WebCore.exp.in (138205 => 138206) --- trunk/Source/WebCore/WebCore.exp.in 2012-12-20 00:50:48 UTC (rev 138205) +++ trunk/Source/WebCore/WebCore.exp.in 2012-12-20 00:58:25 UTC (rev 138206) @@ -468,6 +468,7 @@ __ZN7WebCore16NavigationActionC1ERKNS_15ResourceRequestENS_13FrameLoadTypeEb __ZN7WebCore16NavigationActionC1ERKNS_15ResourceRequestENS_14NavigationTypeE __ZN7WebCore16NavigationActionC1Ev +__ZN7WebCore16ResourceResponse19setCertificateChainEPK9__CFArray __ZN7WebCore16ScriptController10initScriptEPNS_15DOMWrapperWorldE __ZN7WebCore16ScriptController11createWorldEv __ZN7WebCore16ScriptController13executeScriptERKN3WTF6StringEb @@ -1289,6 +1290,7 @@ __ZNK7WebCore16HTMLInputElement18shouldAutocompleteEv __ZNK7WebCore16IconDatabaseBase12databasePathEv __ZNK7WebCore16ResourceResponse13nsURLResponseEv +__ZNK7WebCore16ResourceResponse16certificateChainEv __ZNK7WebCore16VisibleSelection17isContentEditableEv __ZNK7WebCore16VisibleSelection17toNormalizedRangeEv __ZNK7WebCore16VisibleSelection19rootEditableElementEv @@ -1517,6 +1519,7 @@ _wkCopyCONNECTProxyResponse _wkCopyHTTPCookieStorage _wkCopyNSURLResponseStatusLine +_wkCopyNSURLResponseCertificateChain _wkCopyRequestWithStorageSession _wkCreateCTLineWithUniCharProvider _wkCreateCustomCFReadStream Modified: trunk/Source/WebCore/platform/mac/WebCoreSystemInterface.h (138205 => 138206) --- trunk/Source/WebCore/platform/mac/WebCoreSystemInterface.h 2012-12-20 00:50:48 UTC (rev 138205) +++ trunk/Source/WebCore/platform/mac/WebCoreSystemInterface.h 2012-12-20 00:58:25 UTC (rev 138206) @@ -135,6 +135,7 @@ void *context); extern CFStringRef (*wkCopyCFLocalizationPreferredName)(CFStringRef); extern NSString* (*wkCopyNSURLResponseStatusLine)(NSURLResponse*); +extern CFArrayRef (*wkCopyNSURLResponseCertificateChain)(NSURLResponse*); extern id (*wkCreateNSURLConnectionDelegateProxy)(void); extern void (*wkDrawBezeledTextFieldCell)(NSRect, BOOL enabled); extern void (*wkDrawTextFieldCellFocusRing)(NSTextFieldCell*, NSRect); Modified: trunk/Source/WebCore/platform/mac/WebCoreSystemInterface.mm (138205 => 138206) --- trunk/Source/WebCore/platform/mac/WebCoreSystemInterface.mm 2012-12-20 00:50:48 UTC (rev 138205) +++ trunk/Source/WebCore/platform/mac/WebCoreSystemInterface.mm 2012-12-20 00:58:25 UTC (rev 138206) @@ -39,6 +39,7 @@ CGPatternRef (*wkCGPatternCreateWithImageAndTransform)(CGImageRef, CGAffineTransform, int); CFStringRef (*wkCopyCFLocalizationPreferredName)(CFStringRef); NSString* (*wkCopyNSURLResponseStatusLine)(NSURLResponse*); +CFArrayRef (*wkCopyNSURLResponseCertificateChain)(NSURLResponse*); NSString* (*wkCreateURLPasteboardFlavorTypeName)(void);
[webkit-changes] [138207] branches/chromium/1364
Title: [138207] branches/chromium/1364
Revision 138207
Author k...@chromium.org
Date 2012-12-19 17:34:41 -0800 (Wed, 19 Dec 2012)
Log Message
Revert 138190
Merge 138181
Correct missing touch event handler de-registration for nested Documents and DOMWindows
https://bugs.webkit.org/show_bug.cgi?id=105384
Reviewed by James Robinson.
Source/WebCore:
Correcting case by which a nested DOMWindow wouldn't clean up its event handler references
on its Document when removeAllEventListeners was called. Also, correctly propagating this
from a nested Document to its owner Document.
Updating fast/events/touch/touch-handler-count.html to catch this bug.
* dom/Document.cpp:
(WebCore::Document::didRemoveEventTargetNode):
* page/DOMWindow.cpp:
(WebCore::DOMWindow::removeAllEventListeners):
LayoutTests:
* fast/events/touch/touch-handler-count-expected.txt:
* fast/events/touch/touch-handler-count.html: Adding case of nested DOMWindows with event handlers.
TBR=le...@chromium.org
Review URL: https://codereview.chromium.org/11635026
TBR=le...@chromium.org
Review URL: https://codereview.chromium.org/11647025
Modified Paths
branches/chromium/1364/LayoutTests/fast/events/touch/touch-handler-count-expected.txt
branches/chromium/1364/LayoutTests/fast/events/touch/touch-handler-count.html
branches/chromium/1364/Source/WebCore/dom/Document.cpp
branches/chromium/1364/Source/WebCore/page/DOMWindow.cpp
Diff
Modified: branches/chromium/1364/LayoutTests/fast/events/touch/touch-handler-count-expected.txt (138206 => 138207)
--- branches/chromium/1364/LayoutTests/fast/events/touch/touch-handler-count-expected.txt 2012-12-20 00:58:25 UTC (rev 138206)
+++ branches/chromium/1364/LayoutTests/fast/events/touch/touch-handler-count-expected.txt 2012-12-20 01:34:41 UTC (rev 138207)
@@ -71,8 +71,4 @@
PASS window.internals.touchEventHandlerCount(document) is 2
PASS window.internals.touchEventHandlerCount(document) is 2
PASS window.internals.touchEventHandlerCount(document) is 0
-Test that nested Documents' touch handlers are properly removed from their parent Document.
-PASS window.internals.touchEventHandlerCount(document) is 0
-PASS window.internals.touchEventHandlerCount(document) is 1
-PASS window.internals.touchEventHandlerCount(document) is 0
Modified: branches/chromium/1364/LayoutTests/fast/events/touch/touch-handler-count.html (138206 => 138207)
--- branches/chromium/1364/LayoutTests/fast/events/touch/touch-handler-count.html 2012-12-20 00:58:25 UTC (rev 138206)
+++ branches/chromium/1364/LayoutTests/fast/events/touch/touch-handler-count.html 2012-12-20 01:34:41 UTC (rev 138207)
@@ -204,24 +204,5 @@
shouldBe('window.internals.touchEventHandlerCount(document)', '0');
})();
-debug(Test that nested Documents' touch handlers are properly removed from their parent Document.);
-(function() {
-var iframe = document.createElement('iframe');
-var touchtarget = document.getElementById('touchtarget');
-
-shouldBe('window.internals.touchEventHandlerCount(document)', '0');
-
-touchtarget.appendChild(iframe);
-
-var nestedDocument = iframe.contentWindow.document;
-nestedDocument.open('text/html', 'replace');
-nestedDocument.write(!DOCTYPE html\nhtmlbody _onload_=\window._ontouchstart_ = function() { };\/body);
-nestedDocument.close();
-
-shouldBe('window.internals.touchEventHandlerCount(document)', '1');
-
-touchtarget.removeChild(iframe);
-shouldBe('window.internals.touchEventHandlerCount(document)', '0');
-})();
/script
/body
Modified: branches/chromium/1364/Source/WebCore/dom/Document.cpp (138206 => 138207)
--- branches/chromium/1364/Source/WebCore/dom/Document.cpp 2012-12-20 00:58:25 UTC (rev 138206)
+++ branches/chromium/1364/Source/WebCore/dom/Document.cpp 2012-12-20 01:34:41 UTC (rev 138207)
@@ -5659,9 +5659,6 @@
{
if (m_touchEventTargets.get())
m_touchEventTargets-removeAll(handler);
-if (handler == this)
-if (Document* parentDocument = this-parentDocument())
-parentDocument-didRemoveEventTargetNode(this);
}
#endif
Modified: branches/chromium/1364/Source/WebCore/page/DOMWindow.cpp (138206 => 138207)
--- branches/chromium/1364/Source/WebCore/page/DOMWindow.cpp 2012-12-20 00:58:25 UTC (rev 138206)
+++ branches/chromium/1364/Source/WebCore/page/DOMWindow.cpp 2012-12-20 01:34:41 UTC (rev 138207)
@@ -1685,10 +1685,6 @@
if (DeviceOrientationController* controller = DeviceOrientationController::from(page()))
controller-removeAllDeviceEventListeners(this);
#endif
-#if ENABLE(TOUCH_EVENTS)
-if (Document* document = this-document())
-document-didRemoveEventTargetNode(document);
-#endif
removeAllUnloadEventListeners(this);
removeAllBeforeUnloadEventListeners(this);
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [138208] branches/chromium/1364
Title: [138208] branches/chromium/1364
Revision 138208
Author k...@chromium.org
Date 2012-12-19 17:36:29 -0800 (Wed, 19 Dec 2012)
Log Message
Revert 138189
Merge 138095
Input elements with default touch handlers don't update handler counts when changing documents
https://bugs.webkit.org/show_bug.cgi?id=105334
Reviewed by James Robinson.
Source/WebCore:
When an Input element with default touch event handlers changes documents, it failed to
update the touch event handler sets in both the old and new document. This patch fixes this
case.
Test: fast/events/touch/touch-input-element-change-documents.html
* dom/Document.h:
(WebCore::Document::didRemoveTouchEventTargetNode) This function makes sense when touch
handling is enabled, regardless of whether we're tracking the rects.
* dom/Document.cpp:
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::~HTMLInputElement): Switch from didRemoveTouchEventHandler to
didRemoveTouchEventTargetNode, since we don't care about counts in the destructor.
(WebCore::HTMLInputElement::updateType): Fixing incorrect indentation.
(WebCore::HTMLInputElement::didMoveToNewDocument): Adding the node to the new document and
removing it from the old.
LayoutTests:
* fast/events/touch/touch-input-element-change-documents-expected.txt: Added.
* fast/events/touch/touch-input-element-change-documents.html: Added.
TBR=le...@chromium.org
Review URL: https://codereview.chromium.org/11649024
TBR=le...@chromium.org
Review URL: https://codereview.chromium.org/11571072
Modified Paths
branches/chromium/1364/Source/WebCore/dom/Document.cpp
branches/chromium/1364/Source/WebCore/dom/Document.h
branches/chromium/1364/Source/WebCore/html/HTMLInputElement.cpp
Removed Paths
branches/chromium/1364/LayoutTests/fast/events/touch/touch-input-element-change-documents-expected.txt
branches/chromium/1364/LayoutTests/fast/events/touch/touch-input-element-change-documents.html
Diff
Deleted: branches/chromium/1364/LayoutTests/fast/events/touch/touch-input-element-change-documents-expected.txt (138207 => 138208)
--- branches/chromium/1364/LayoutTests/fast/events/touch/touch-input-element-change-documents-expected.txt 2012-12-20 01:34:41 UTC (rev 138207)
+++ branches/chromium/1364/LayoutTests/fast/events/touch/touch-input-element-change-documents-expected.txt 2012-12-20 01:36:29 UTC (rev 138208)
@@ -1,12 +0,0 @@
-This test checks that we correctly update the touch event handler count when an Input element with default touch handlers changes documents.
-
-On success, you will see a series of PASS messages, followed by TEST COMPLETE.
-
-
-PASS window.internals.touchEventHandlerCount(document) is 0
-PASS window.internals.touchEventHandlerCount(document) is 0
-PASS window.internals.touchEventHandlerCount(document) is 2
-PASS window.internals.touchEventHandlerCount(document) is 3
-PASS window.internals.touchEventHandlerCount(document) is 2
-PASS window.internals.touchEventHandlerCount(document) is 0
-
Deleted: branches/chromium/1364/LayoutTests/fast/events/touch/touch-input-element-change-documents.html (138207 => 138208)
--- branches/chromium/1364/LayoutTests/fast/events/touch/touch-input-element-change-documents.html 2012-12-20 01:34:41 UTC (rev 138207)
+++ branches/chromium/1364/LayoutTests/fast/events/touch/touch-input-element-change-documents.html 2012-12-20 01:36:29 UTC (rev 138208)
@@ -1,30 +0,0 @@
-script src=""
-div id='container'/div
-script
-description(This test checks that we correctly update the touch event handler count when an Input element with default touch handlers changes documents.);
-
-
- shouldBe('window.internals.touchEventHandlerCount(document)', '0');
-
- // There are two touchable Input elements in Audio's shadow DOM when controls are enabled.
- var input = document.createElement('audio');
- input.setAttribute(controls, true);
- var container = document.getElementById('container');
-
- shouldBe('window.internals.touchEventHandlerCount(document)', '0');
-
- container.appendChild(input);
- shouldBe('window.internals.touchEventHandlerCount(document)', '2');
-
- input._ontouchend_ = function() { };
- shouldBe('window.internals.touchEventHandlerCount(document)', '3');
-
- input._ontouchend_ = null;
- shouldBe('window.internals.touchEventHandlerCount(document)', '2');
-
- document.implementation.createDocument(, , null).adoptNode(input);
- shouldBe('window.internals.touchEventHandlerCount(document)', '0');
-
-
-/script
-/body
Modified: branches/chromium/1364/Source/WebCore/dom/Document.cpp (138207 => 138208)
--- branches/chromium/1364/Source/WebCore/dom/Document.cpp 2012-12-20 01:34:41 UTC (rev 138207)
+++ branches/chromium/1364/Source/WebCore/dom/Document.cpp 2012-12-20 01:36:29 UTC (rev 138208)
@@ -5654,7 +5654,7 @@
#endif
}
-#if ENABLE(TOUCH_EVENTS)
+#if ENABLE(TOUCH_EVENT_TRACKING)
void Document::didRemoveEventTargetNode(Node* handler)
{
if (m_touchEventTargets.get())
Modified:
[webkit-changes] [138210] trunk/Source/WebCore
Title: [138210] trunk/Source/WebCore
Revision 138210
Author jon...@apple.com
Date 2012-12-19 17:40:57 -0800 (Wed, 19 Dec 2012)
Log Message
Leak in StringImpl::createCFString()
https://bugs.webkit.org/show_bug.cgi?id=105485
rdar://problem/12801963
Reviewed by Anders Carlsson.
* platform/text/cf/StringImplCF.cpp:
(WTF::StringImpl::createCFString): Missing adoptCF()'s.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/text/cf/StringImplCF.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (138209 => 138210)
--- trunk/Source/WebCore/ChangeLog 2012-12-20 01:40:41 UTC (rev 138209)
+++ trunk/Source/WebCore/ChangeLog 2012-12-20 01:40:57 UTC (rev 138210)
@@ -1,3 +1,14 @@
+2012-12-19 Jon Lee jon...@apple.com
+
+Leak in StringImpl::createCFString()
+https://bugs.webkit.org/show_bug.cgi?id=105485
+rdar://problem/12801963
+
+Reviewed by Anders Carlsson.
+
+* platform/text/cf/StringImplCF.cpp:
+(WTF::StringImpl::createCFString): Missing adoptCF()'s.
+
2012-12-19 Alexey Proskuryakov a...@apple.com
rdar://problem/12890242 [WK2 NetworkProcess] Client doesn't receive SSL certificates
Modified: trunk/Source/WebCore/platform/text/cf/StringImplCF.cpp (138209 => 138210)
--- trunk/Source/WebCore/platform/text/cf/StringImplCF.cpp 2012-12-20 01:40:41 UTC (rev 138209)
+++ trunk/Source/WebCore/platform/text/cf/StringImplCF.cpp 2012-12-20 01:40:57 UTC (rev 138210)
@@ -137,8 +137,8 @@
{
if (!m_length || !isMainThread()) {
if (is8Bit())
-return CFStringCreateWithBytes(0, reinterpret_castconst UInt8*(characters8()), m_length, kCFStringEncodingISOLatin1, false);
-return CFStringCreateWithCharacters(0, reinterpret_castconst UniChar*(characters16()), m_length);
+return adoptCF(CFStringCreateWithBytes(0, reinterpret_castconst UInt8*(characters8()), m_length, kCFStringEncodingISOLatin1, false));
+return adoptCF(CFStringCreateWithCharacters(0, reinterpret_castconst UniChar*(characters16()), m_length));
}
CFAllocatorRef allocator = StringWrapperCFAllocator::allocator();
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [138211] branches/chromium/1364/Source/WebCore/loader
Title: [138211] branches/chromium/1364/Source/WebCore/loader
Revision 138211
Author k...@chromium.org
Date 2012-12-19 17:43:15 -0800 (Wed, 19 Dec 2012)
Log Message
Merge 138174
REGRESSION(r137607): PluginDocument loads consume huge amounts of memory
https://bugs.webkit.org/show_bug.cgi?id=105359
Reviewed by Alexey Proskuryakov.
No new tests, verified manually that http://www.scb.se/statistik/_publikationer/NR0001_2012K02_TI_A28TI1203.pdf
no longer consumes several GB of memory.
* loader/ResourceLoader.cpp:
(WebCore::ResourceLoader::setShouldBufferData): shouldBufferData is an enum, not a boolean, so this is reversed.
* loader/cache/CachedRawResource.cpp:
(WebCore::CachedRawResource::data): If the dataReceived() callback tells us to stop buffering data, be sure to
notify the ResourceLoader and clear the data buffer.
TBR=jap...@chromium.org
Review URL: https://codereview.chromium.org/11571073
Modified Paths
branches/chromium/1364/Source/WebCore/loader/ResourceLoader.cpp
branches/chromium/1364/Source/WebCore/loader/cache/CachedRawResource.cpp
Diff
Modified: branches/chromium/1364/Source/WebCore/loader/ResourceLoader.cpp (138210 => 138211)
--- branches/chromium/1364/Source/WebCore/loader/ResourceLoader.cpp 2012-12-20 01:40:57 UTC (rev 138210)
+++ branches/chromium/1364/Source/WebCore/loader/ResourceLoader.cpp 2012-12-20 01:43:15 UTC (rev 138211)
@@ -194,7 +194,7 @@
m_options.shouldBufferData = shouldBufferData;
// Reset any already buffered data
-if (!shouldBufferData)
+if (shouldBufferData == DoNotBufferData)
m_resourceData = 0;
}
Modified: branches/chromium/1364/Source/WebCore/loader/cache/CachedRawResource.cpp (138210 => 138211)
--- branches/chromium/1364/Source/WebCore/loader/cache/CachedRawResource.cpp 2012-12-20 01:40:57 UTC (rev 138210)
+++ branches/chromium/1364/Source/WebCore/loader/cache/CachedRawResource.cpp 2012-12-20 01:43:15 UTC (rev 138211)
@@ -56,19 +56,26 @@
incrementalData = data-data() + previousDataLength;
incrementalDataLength = data-size() - previousDataLength;
}
-
+
if (m_options.shouldBufferData == BufferData) {
if (data)
setEncodedSize(data-size());
m_data = data;
}
-
+
+DataBufferingPolicy dataBufferingPolicy = m_options.shouldBufferData;
if (incrementalDataLength) {
CachedResourceClientWalkerCachedRawResourceClient w(m_clients);
while (CachedRawResourceClient* c = w.next())
c-dataReceived(this, incrementalData, incrementalDataLength);
}
CachedResource::data(m_data, allDataReceived);
+
+if (dataBufferingPolicy == BufferData m_options.shouldBufferData == DoNotBufferData) {
+if (m_loader)
+m_loader-setShouldBufferData(DoNotBufferData);
+clear();
+}
}
void CachedRawResource::didAddClient(CachedResourceClient* c)
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [138212] trunk/Source/WebKit/win
Title: [138212] trunk/Source/WebKit/win
Revision 138212
Author ander...@apple.com
Date 2012-12-19 18:00:32 -0800 (Wed, 19 Dec 2012)
Log Message
Build WebKit2ExportGenerator before WebKitLib
https://bugs.webkit.org/show_bug.cgi?id=105487
Reviewed by Tim Horton.
* WebKit.vcproj/WebKit.sln:
Modified Paths
trunk/Source/WebKit/win/ChangeLog
trunk/Source/WebKit/win/WebKit.vcproj/WebKit.sln
Diff
Modified: trunk/Source/WebKit/win/ChangeLog (138211 => 138212)
--- trunk/Source/WebKit/win/ChangeLog 2012-12-20 01:43:15 UTC (rev 138211)
+++ trunk/Source/WebKit/win/ChangeLog 2012-12-20 02:00:32 UTC (rev 138212)
@@ -1,3 +1,12 @@
+2012-12-19 Anders Carlsson ander...@apple.com
+
+Build WebKit2ExportGenerator before WebKitLib
+https://bugs.webkit.org/show_bug.cgi?id=105487
+
+Reviewed by Tim Horton.
+
+* WebKit.vcproj/WebKit.sln:
+
2012-12-18 Alexey Proskuryakov a...@apple.com
Remove unnecessary functions from CookiesStrategy
Modified: trunk/Source/WebKit/win/WebKit.vcproj/WebKit.sln (138211 => 138212)
--- trunk/Source/WebKit/win/WebKit.vcproj/WebKit.sln 2012-12-20 01:43:15 UTC (rev 138211)
+++ trunk/Source/WebKit/win/WebKit.vcproj/WebKit.sln 2012-12-20 02:00:32 UTC (rev 138212)
@@ -3,8 +3,8 @@
# Visual Studio 2005
Project({8BC9CEB8-8B4A-11D0-8D11-00A0C91BC942}) = _javascript_Core, ..\..\..\_javascript_Core\_javascript_Core.vcproj\_javascript_Core\_javascript_Core.vcproj, {011D10F1-B656-4A1B-A0C3-3842F02122C5}
ProjectSection(ProjectDependencies) = postProject
- {9221744B-5715-4F56-9590-42F7AB23DD8B} = {9221744B-5715-4F56-9590-42F7AB23DD8B}
{4FF5BA11-59EC-4C24-8F52-F235C2E7D43A} = {4FF5BA11-59EC-4C24-8F52-F235C2E7D43A}
+ {9221744B-5715-4F56-9590-42F7AB23DD8B} = {9221744B-5715-4F56-9590-42F7AB23DD8B}
EndProjectSection
EndProject
Project({8BC9CEB8-8B4A-11D0-8D11-00A0C91BC942}) = WebCore, ..\..\..\WebCore\WebCore.vcproj\WebCore.vcproj, {1C16337B-ACF3-4D03-AA90-851C5B5EADA6}
@@ -49,7 +49,6 @@
Project({8BC9CEB8-8B4A-11D0-8D11-00A0C91BC942}) = WebKit, ..\..\..\WebKit2\win\WebKit2.vcproj, {2E51ABE8-76CB-485B-A66C-46AEF4DF8ACD}
ProjectSection(ProjectDependencies) = postProject
{2EDAD637-CBA8-4E55-97ED-7D2BBC336FDB} = {2EDAD637-CBA8-4E55-97ED-7D2BBC336FDB}
- {BAE88FEF-509E-4D49-870B-7357922C276F} = {BAE88FEF-509E-4D49-870B-7357922C276F}
EndProjectSection
EndProject
Project({2150E333-8FDC-42A3-9474-1A3956D46DE8}) = WebKit2 Folder, WebKit2 Folder, {9AB9C96C-9039-4FA9-8F83-BBFC8F8B2182}
@@ -73,7 +72,7 @@
EndProject
Project({8BC9CEB8-8B4A-11D0-8D11-00A0C91BC942}) = WebKitLib, WebKit.vcproj, {0662A8A9-82A3-4638-97D8-EC425D8D87C9}
ProjectSection(ProjectDependencies) = postProject
- {B8437A41-67BC-4769-9452-45203827F821} = {B8437A41-67BC-4769-9452-45203827F821}
+ {BAE88FEF-509E-4D49-870B-7357922C276F} = {BAE88FEF-509E-4D49-870B-7357922C276F}
EndProjectSection
EndProject
Project({8BC9CEB8-8B4A-11D0-8D11-00A0C91BC942}) = WebKitGUID, WebKitGUID.vcproj, {B8437A41-67BC-4769-9452-45203827F821}
@@ -154,9 +153,9 @@
EndProject
Project({8BC9CEB8-8B4A-11D0-8D11-00A0C91BC942}) = LLIntDesiredOffsets, ..\..\..\_javascript_Core\_javascript_Core.vcproj\LLIntDesiredOffsets\LLIntDesiredOffsets.vcproj, {877150A0-41B3-4730-9D98-1B8298098B14}
ProjectSection(ProjectDependencies) = postProject
- {4FF5BA11-59EC-4C24-8F52-F235C2E7D43A} = {4FF5BA11-59EC-4C24-8F52-F235C2E7D43A}
- {AA8A5A85-592B-4357-BC60-E0E91E026AF6} = {AA8A5A85-592B-4357-BC60-E0E91E026AF6}
{5AE5F5E4-782D-4F63-B4D7-3977B52B9950} = {5AE5F5E4-782D-4F63-B4D7-3977B52B9950}
+ {AA8A5A85-592B-4357-BC60-E0E91E026AF6} = {AA8A5A85-592B-4357-BC60-E0E91E026AF6}
+ {4FF5BA11-59EC-4C24-8F52-F235C2E7D43A} = {4FF5BA11-59EC-4C24-8F52-F235C2E7D43A}
EndProjectSection
EndProject
Project({8BC9CEB8-8B4A-11D0-8D11-00A0C91BC942}) = LLIntOffsetsExtractor, ..\..\..\_javascript_Core\_javascript_Core.vcproj\LLIntOffsetsExtractor\LLIntOffsetsExtractor.vcproj, {D595E3F6-24F2-4C60-935C-95D50C6B3E96}
@@ -171,8 +170,7 @@
EndProject
Project({8BC9CEB8-8B4A-11D0-8D11-00A0C91BC942}) = WebKit2ExportGenerator, ..\..\..\WebKit2\win\WebKit2ExportGenerator.vcproj, {BAE88FEF-509E-4D49-870B-7357922C276F}
ProjectSection(ProjectDependencies) = postProject
- {AA8A5A85-592B-4357-BC60-E0E91E026AF6} = {AA8A5A85-592B-4357-BC60-E0E91E026AF6}
- {2EDAD637-CBA8-4E55-97ED-7D2BBC336FDB} = {2EDAD637-CBA8-4E55-97ED-7D2BBC336FDB}
+ {B8437A41-67BC-4769-9452-45203827F821} = {B8437A41-67BC-4769-9452-45203827F821}
EndProjectSection
EndProject
Global
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [138213] tags/Safari-537.23/
Title: [138213] tags/Safari-537.23/ Revision 138213 Author lforsch...@apple.com Date 2012-12-19 19:48:12 -0800 (Wed, 19 Dec 2012) Log Message New Tag. Added Paths tags/Safari-537.23/ Diff Property changes: tags/Safari-537.23 Added: svn:ignore depcomp compile config.guess GNUmakefile.in config.sub ltmain.sh aconfig.h.in autom4te.cache missing aclocal.m4 install-sh autotoolsconfig.h.in INSTALL README gtk-doc.make out Makefile.chromium WebKitSupportLibrary.zip WebKitBuild Added: svn:mergeinfo ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [138214] trunk/Source
Title: [138214] trunk/Source Revision 138214 Author lforsch...@apple.com Date 2012-12-19 20:07:42 -0800 (Wed, 19 Dec 2012) Log Message Versioning. Modified Paths trunk/Source/_javascript_Core/Configurations/Version.xcconfig trunk/Source/WebCore/Configurations/Version.xcconfig trunk/Source/WebKit/mac/Configurations/Version.xcconfig trunk/Source/WebKit2/Configurations/Version.xcconfig Diff Modified: trunk/Source/_javascript_Core/Configurations/Version.xcconfig (138213 => 138214) --- trunk/Source/_javascript_Core/Configurations/Version.xcconfig 2012-12-20 03:48:12 UTC (rev 138213) +++ trunk/Source/_javascript_Core/Configurations/Version.xcconfig 2012-12-20 04:07:42 UTC (rev 138214) @@ -22,7 +22,7 @@ // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. MAJOR_VERSION = 537; -MINOR_VERSION = 22; +MINOR_VERSION = 24; TINY_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION); Modified: trunk/Source/WebCore/Configurations/Version.xcconfig (138213 => 138214) --- trunk/Source/WebCore/Configurations/Version.xcconfig 2012-12-20 03:48:12 UTC (rev 138213) +++ trunk/Source/WebCore/Configurations/Version.xcconfig 2012-12-20 04:07:42 UTC (rev 138214) @@ -22,7 +22,7 @@ // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. MAJOR_VERSION = 537; -MINOR_VERSION = 22; +MINOR_VERSION = 24; TINY_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION); Modified: trunk/Source/WebKit/mac/Configurations/Version.xcconfig (138213 => 138214) --- trunk/Source/WebKit/mac/Configurations/Version.xcconfig 2012-12-20 03:48:12 UTC (rev 138213) +++ trunk/Source/WebKit/mac/Configurations/Version.xcconfig 2012-12-20 04:07:42 UTC (rev 138214) @@ -22,7 +22,7 @@ // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. MAJOR_VERSION = 537; -MINOR_VERSION = 22; +MINOR_VERSION = 24; TINY_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION); Modified: trunk/Source/WebKit2/Configurations/Version.xcconfig (138213 => 138214) --- trunk/Source/WebKit2/Configurations/Version.xcconfig 2012-12-20 03:48:12 UTC (rev 138213) +++ trunk/Source/WebKit2/Configurations/Version.xcconfig 2012-12-20 04:07:42 UTC (rev 138214) @@ -22,7 +22,7 @@ // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. MAJOR_VERSION = 537; -MINOR_VERSION = 22; +MINOR_VERSION = 24; TINY_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION); ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [138215] trunk/Source/WebKit/chromium
Title: [138215] trunk/Source/WebKit/chromium
Revision 138215
Author pilg...@chromium.org
Date 2012-12-19 21:23:07 -0800 (Wed, 19 Dec 2012)
Log Message
[Chromium] Remove all references to sharedWorkerRepository()
https://bugs.webkit.org/show_bug.cgi?id=104704
Reviewed by Darin Fisher.
Now that Chromium calls setSharedWorkerRepository upon
initializing WebKit (
https://codereview.chromium.org/10990121/ and
https://codereview.chromium.org/11576028/ ) and no longer
tries to override sharedWorkerRepository, it is safe to remove
all references to this function.
* public/platform/WebKitPlatformSupport.h:
(WebKit):
(WebKit::WebKitPlatformSupport::idbFactory):
* src/SharedWorkerRepository.cpp:
(WebKit::sharedWorkerRepository):
(WebCore::SharedWorkerRepository::isAvailable):
Modified Paths
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/public/platform/WebKitPlatformSupport.h
trunk/Source/WebKit/chromium/src/SharedWorkerRepository.cpp
Diff
Modified: trunk/Source/WebKit/chromium/ChangeLog (138214 => 138215)
--- trunk/Source/WebKit/chromium/ChangeLog 2012-12-20 04:07:42 UTC (rev 138214)
+++ trunk/Source/WebKit/chromium/ChangeLog 2012-12-20 05:23:07 UTC (rev 138215)
@@ -1,3 +1,24 @@
+2012-12-19 Mark Pilgrim pilg...@chromium.org
+
+[Chromium] Remove all references to sharedWorkerRepository()
+https://bugs.webkit.org/show_bug.cgi?id=104704
+
+Reviewed by Darin Fisher.
+
+Now that Chromium calls setSharedWorkerRepository upon
+initializing WebKit (
+https://codereview.chromium.org/10990121/ and
+https://codereview.chromium.org/11576028/ ) and no longer
+tries to override sharedWorkerRepository, it is safe to remove
+all references to this function.
+
+* public/platform/WebKitPlatformSupport.h:
+(WebKit):
+(WebKit::WebKitPlatformSupport::idbFactory):
+* src/SharedWorkerRepository.cpp:
+(WebKit::sharedWorkerRepository):
+(WebCore::SharedWorkerRepository::isAvailable):
+
2012-12-19 Alexis Menard ale...@webkit.org
Implement CSS parsing for CSS transitions unprefixed.
Modified: trunk/Source/WebKit/chromium/public/platform/WebKitPlatformSupport.h (138214 => 138215)
--- trunk/Source/WebKit/chromium/public/platform/WebKitPlatformSupport.h 2012-12-20 04:07:42 UTC (rev 138214)
+++ trunk/Source/WebKit/chromium/public/platform/WebKitPlatformSupport.h 2012-12-20 05:23:07 UTC (rev 138215)
@@ -36,7 +36,6 @@
namespace WebKit {
class WebIDBFactory; // FIXME: Does this belong in platform?
-class WebSharedWorkerRepository; // FIXME: Does this belong in platform?
// FIXME: Eventually all these API will need to move to WebKit::Platform.
class WebKitPlatformSupport : public Platform {
@@ -45,11 +44,6 @@
virtual WebIDBFactory* idbFactory() { return 0; }
-
-// Shared Workers --
-
-virtual WebSharedWorkerRepository* sharedWorkerRepository() { return 0; }
-
protected:
~WebKitPlatformSupport() { }
};
Modified: trunk/Source/WebKit/chromium/src/SharedWorkerRepository.cpp (138214 => 138215)
--- trunk/Source/WebKit/chromium/src/SharedWorkerRepository.cpp 2012-12-20 04:07:42 UTC (rev 138214)
+++ trunk/Source/WebKit/chromium/src/SharedWorkerRepository.cpp 2012-12-20 05:23:07 UTC (rev 138215)
@@ -69,15 +69,8 @@
static WebSharedWorkerRepository* sharedWorkerRepository()
{
-WebSharedWorkerRepository* repository;
-
-repository = s_sharedWorkerRepository;
-if (!repository) {
-repository = webKitPlatformSupport()-sharedWorkerRepository();
-setSharedWorkerRepository(repository);
-}
-
-return repository;
+// Will only be non-zero if the embedder has set the shared worker repository upon initialization. Nothing in WebKit sets this.
+return s_sharedWorkerRepository;
}
}
@@ -218,8 +211,6 @@
bool SharedWorkerRepository::isAvailable()
{
-// Allow the WebKitPlatformSupport to determine if SharedWorkers
-// are available.
return WebKit::sharedWorkerRepository();
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [138216] trunk/Source/WebKit/chromium
Title: [138216] trunk/Source/WebKit/chromium
Revision 138216
Author commit-qu...@webkit.org
Date 2012-12-19 21:25:15 -0800 (Wed, 19 Dec 2012)
Log Message
[Chromium] Spellchecker should provide suggestions for non-caret selection, too
https://bugs.webkit.org/show_bug.cgi?id=104841
Patch by Rachel Blum gr...@chromium.org on 2012-12-19
Reviewed by Anders Carlsson.
Allow spelling suggestions for a word if the word is already selected. No suggestion
if subset of a word or more than a word is selected.
* src/ContextMenuClientImpl.cpp:
(WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems):
Modified Paths
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/src/ContextMenuClientImpl.cpp
Diff
Modified: trunk/Source/WebKit/chromium/ChangeLog (138215 => 138216)
--- trunk/Source/WebKit/chromium/ChangeLog 2012-12-20 05:23:07 UTC (rev 138215)
+++ trunk/Source/WebKit/chromium/ChangeLog 2012-12-20 05:25:15 UTC (rev 138216)
@@ -1,3 +1,16 @@
+2012-12-19 Rachel Blum gr...@chromium.org
+
+[Chromium] Spellchecker should provide suggestions for non-caret selection, too
+https://bugs.webkit.org/show_bug.cgi?id=104841
+
+Reviewed by Anders Carlsson.
+
+Allow spelling suggestions for a word if the word is already selected. No suggestion
+if subset of a word or more than a word is selected.
+
+* src/ContextMenuClientImpl.cpp:
+(WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems):
+
2012-12-19 Mark Pilgrim pilg...@chromium.org
[Chromium] Remove all references to sharedWorkerRepository()
Modified: trunk/Source/WebKit/chromium/src/ContextMenuClientImpl.cpp (138215 => 138216)
--- trunk/Source/WebKit/chromium/src/ContextMenuClientImpl.cpp 2012-12-20 05:23:07 UTC (rev 138215)
+++ trunk/Source/WebKit/chromium/src/ContextMenuClientImpl.cpp 2012-12-20 05:25:15 UTC (rev 138216)
@@ -277,11 +277,19 @@
// a mouse on a word, Chrome just needs to find a spelling marker on the word instread of spellchecking it.
if (selectedFrame-settings() selectedFrame-settings()-asynchronousSpellCheckingEnabled()) {
VisibleSelection selection = selectedFrame-selection()-selection();
-if (selection.isCaret()) {
-selection.expandUsingGranularity(WordGranularity);
+bool shouldUpdateSelection = false;
+if (selection.isCaretOrRange()) {
+if (selection.isCaret()) {
+selection.expandUsingGranularity(WordGranularity);
+shouldUpdateSelection = true;
+}
RefPtrRange range = selection.toNormalizedRange();
VectorDocumentMarker* markers = selectedFrame-document()-markers()-markersInRange(range.get(), DocumentMarker::Spelling | DocumentMarker::Grammar);
if (markers.size() == 1) {
+if (markers[0]-startOffset() != static_castunsigned(range-startOffset()) || markers[0]-endOffset() != static_castunsigned(range-endOffset()))
+markers.clear();
+}
+if (markers.size() == 1) {
range-setStart(range-startContainer(), markers[0]-startOffset());
range-setEnd(range-endContainer(), markers[0]-endOffset());
data.misspelledWord = range-text();
@@ -294,7 +302,7 @@
m_webView-spellCheckClient()-spellCheck(data.misspelledWord, misspelledOffset, misspelledLength, data.dictionarySuggestions);
}
selection = VisibleSelection(range.get());
-if (selectedFrame-selection()-shouldChangeSelection(selection))
+if (shouldUpdateSelection selectedFrame-selection()-shouldChangeSelection(selection))
selectedFrame-selection()-setSelection(selection, WordGranularity);
}
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [138217] trunk
Title: [138217] trunk Revision 138217 Author commit-qu...@webkit.org Date 2012-12-19 21:27:12 -0800 (Wed, 19 Dec 2012) Log Message [EFL] Allow the build system to find OpenGL ES https://bugs.webkit.org/show_bug.cgi?id=104760 Patch by Yael Aharon yael.aha...@intel.com on 2012-12-19 Reviewed by Laszlo Gombos. Add a way to find if GLESv2 is supported by the build system. Support for GLESv2 will be added separately. * Source/cmake/FindGLES.cmake: Added. Modified Paths trunk/ChangeLog Added Paths trunk/Source/cmake/FindGLES.cmake Diff Modified: trunk/ChangeLog (138216 => 138217) --- trunk/ChangeLog 2012-12-20 05:25:15 UTC (rev 138216) +++ trunk/ChangeLog 2012-12-20 05:27:12 UTC (rev 138217) @@ -1,3 +1,15 @@ +2012-12-19 Yael Aharon yael.aha...@intel.com + +[EFL] Allow the build system to find OpenGL ES +https://bugs.webkit.org/show_bug.cgi?id=104760 + +Reviewed by Laszlo Gombos. + +Add a way to find if GLESv2 is supported by the build system. +Support for GLESv2 will be added separately. + +* Source/cmake/FindGLES.cmake: Added. + 2012-12-19 Alexis Menard ale...@webkit.org Implement CSS parsing for CSS transitions unprefixed. Added: trunk/Source/cmake/FindGLES.cmake (0 => 138217) --- trunk/Source/cmake/FindGLES.cmake (rev 0) +++ trunk/Source/cmake/FindGLES.cmake 2012-12-20 05:27:12 UTC (rev 138217) @@ -0,0 +1,38 @@ +# - Try to find OpenGLES +# Once done this will define +# +# OPENGLES2_FOUND- system has OpenGLESv2 installed. +# OPENGLES2_INCLUDE_DIR - directories which contain the OpenGlEsv2 headers. +# OPENGLES2_LIBRARIES- libraries required to link against OpenGLESv2 +# +# Copyright (C) 2012 Intel Corporation. All rights reserved. +# +# Redistribution and use in source and binary forms, with or without +# modification, are permitted provided that the following conditions +# are met: +# 1. Redistributions of source code must retain the above copyright +# notice, this list of conditions and the following disclaimer. +# 2. Redistributions in binary form must reproduce the above copyright +# notice, this list of conditions and the following disclaimer in the +# documentation and/or other materials provided with the distribution. +# +# THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDER AND ITS CONTRIBUTORS ``AS +# IS'' AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, +# THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR +# PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR ITS +# CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, +# EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, +# PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; +# OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, +# WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR +# OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF +# ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. + +find_path(OPENGLES2_INCLUDE_DIR NAMES GLES2/gl2.h) + +find_library(OPENGLES2_LIBRARY NAMES GLESv2) + +include(FindPackageHandleStandardArgs) +FIND_PACKAGE_HANDLE_STANDARD_ARGS(GLESv2 DEFAULT_MSG OPENGLES2_INCLUDE_DIR OPENGLES2_LIBRARY) + +mark_as_advanced(OPENGLES2_INCLUDE_DIR OPENGLES2_LIBRARY) ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [138218] trunk/Source/WebCore
Title: [138218] trunk/Source/WebCore
Revision 138218
Author commit-qu...@webkit.org
Date 2012-12-19 21:28:21 -0800 (Wed, 19 Dec 2012)
Log Message
[BlackBerry] RSS reader mangles UTF-8
https://bugs.webkit.org/show_bug.cgi?id=105440
RIM PR 235099
Patch by Cosmin Truta ctr...@rim.com on 2012-12-19
Reviewed by Yong Li.
Reviewed internally by Liam Quinn.
The HTML string built from RSS parse data is encoded in UTF-8,
and it should not be converted to UTF-8 repeatedly.
* platform/network/blackberry/rss/RSSFilterStream.cpp:
(WebCore::RSSFilterStream::convertContentToHtml):
* platform/network/blackberry/rss/RSSGenerator.cpp:
(WebCore::RSSGenerator::generateHtml):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/network/blackberry/rss/RSSFilterStream.cpp
trunk/Source/WebCore/platform/network/blackberry/rss/RSSGenerator.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (138217 => 138218)
--- trunk/Source/WebCore/ChangeLog 2012-12-20 05:27:12 UTC (rev 138217)
+++ trunk/Source/WebCore/ChangeLog 2012-12-20 05:28:21 UTC (rev 138218)
@@ -1,3 +1,21 @@
+2012-12-19 Cosmin Truta ctr...@rim.com
+
+[BlackBerry] RSS reader mangles UTF-8
+https://bugs.webkit.org/show_bug.cgi?id=105440
+
+RIM PR 235099
+
+Reviewed by Yong Li.
+Reviewed internally by Liam Quinn.
+
+The HTML string built from RSS parse data is encoded in UTF-8,
+and it should not be converted to UTF-8 repeatedly.
+
+* platform/network/blackberry/rss/RSSFilterStream.cpp:
+(WebCore::RSSFilterStream::convertContentToHtml):
+* platform/network/blackberry/rss/RSSGenerator.cpp:
+(WebCore::RSSGenerator::generateHtml):
+
2012-12-19 Jon Lee jon...@apple.com
Leak in StringImpl::createCFString()
Modified: trunk/Source/WebCore/platform/network/blackberry/rss/RSSFilterStream.cpp (138217 => 138218)
--- trunk/Source/WebCore/platform/network/blackberry/rss/RSSFilterStream.cpp 2012-12-20 05:27:12 UTC (rev 138217)
+++ trunk/Source/WebCore/platform/network/blackberry/rss/RSSFilterStream.cpp 2012-12-20 05:28:21 UTC (rev 138218)
@@ -525,9 +525,16 @@
if (!success)
return false;
+// FIXME:
+// The HTML string generated below purports to be a UTF8-encoded
+// WTF::String, although its characters8() data should be Latin1.
+// We build then extract this string, pretending that we don't know
+// that we pass incorrectly-encoded char data both ways.
+// We should use BlackBerry::Platform::String instead of WTF::String.
OwnPtrRSSGenerator generator = adoptPtr(new RSSGenerator());
String html = generator-generateHtml(parser-m_root);
-result = html.utf8(String::StrictConversion).data();
+ASSERT(html.is8Bit());
+result.assign(reinterpret_castconst char*(html.characters8()), html.length());
return true;
}
Modified: trunk/Source/WebCore/platform/network/blackberry/rss/RSSGenerator.cpp (138217 => 138218)
--- trunk/Source/WebCore/platform/network/blackberry/rss/RSSGenerator.cpp 2012-12-20 05:27:12 UTC (rev 138217)
+++ trunk/Source/WebCore/platform/network/blackberry/rss/RSSGenerator.cpp 2012-12-20 05:28:21 UTC (rev 138218)
@@ -83,10 +83,10 @@
builder.append(articleName);
builder.appendLiteral(\ class=\article\\na href=""
if (!item-m_link.isEmpty())
-builder.append(item-m_link.utf8(String::StrictConversion).data());
+builder.append(item-m_link);
builder.appendLiteral(\b);
if (!item-m_title.isEmpty())
-builder.append(item-m_title.utf8(String::StrictConversion).data());
+builder.append(item-m_title);
else
builder.append(s_defaultEntryTitle);
builder.appendLiteral(/b/a\nbr /);
@@ -94,13 +94,13 @@
if (!item-m_author.isEmpty()) {
builder.append(i18n(By));
builder.appendLiteral( b);
-builder.append(item-m_author.utf8(String::StrictConversion).data());
+builder.append(item-m_author);
builder.appendLiteral(/b );
} else {
if (!feed-m_author.isEmpty()) {
builder.append(i18n(By));
builder.appendLiteral( b);
-builder.append(feed-m_author.utf8(String::StrictConversion).data());
+builder.append(feed-m_author);
builder.appendLiteral(/b );
}
}
@@ -113,7 +113,7 @@
for (unsigned i = 0; i item-m_categories.size() ; ++i) {
builder.appendLiteral(b);
-builder.append(item-m_categories[i].utf8(String::StrictConversion).data());
+builder.append(item-m_categories[i]);
builder.appendLiteral(/b);
if (i item-m_categories.size() - 1)
@@ -123,11 +123,11 @@
builder.appendLiteral(br /);
if (!item-m_pubDate.isEmpty())
-
[webkit-changes] [138219] trunk/LayoutTests
Title: [138219] trunk/LayoutTests
Revision 138219
Author eric.carl...@apple.com
Date 2012-12-19 21:30:25 -0800 (Wed, 19 Dec 2012)
Log Message
Update video-controls-captions-trackmenu.html
https://bugs.webkit.org/show_bug.cgi?id=105455
Reviewed by Dean Jackson.
* media/video-controls-captions-trackmenu-expected.txt: Update results.
* media/video-controls-captions-trackmenu.html: Update test to account for sorted menu.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/media/video-controls-captions-trackmenu-expected.txt
trunk/LayoutTests/media/video-controls-captions-trackmenu.html
Diff
Modified: trunk/LayoutTests/ChangeLog (138218 => 138219)
--- trunk/LayoutTests/ChangeLog 2012-12-20 05:28:21 UTC (rev 138218)
+++ trunk/LayoutTests/ChangeLog 2012-12-20 05:30:25 UTC (rev 138219)
@@ -1,3 +1,13 @@
+2012-12-19 Eric Carlson eric.carl...@apple.com
+
+Update video-controls-captions-trackmenu.html
+https://bugs.webkit.org/show_bug.cgi?id=105455
+
+Reviewed by Dean Jackson.
+
+* media/video-controls-captions-trackmenu-expected.txt: Update results.
+* media/video-controls-captions-trackmenu.html: Update test to account for sorted menu.
+
2012-12-19 Filip Pizlo fpi...@apple.com
JSObject::ensureIndexingType should gracefully handle InterceptsGetOwn..., and should never be called when the 'this' is not an object
Modified: trunk/LayoutTests/media/video-controls-captions-trackmenu-expected.txt (138218 => 138219)
--- trunk/LayoutTests/media/video-controls-captions-trackmenu-expected.txt 2012-12-20 05:28:21 UTC (rev 138218)
+++ trunk/LayoutTests/media/video-controls-captions-trackmenu-expected.txt 2012-12-20 05:30:25 UTC (rev 138219)
@@ -12,10 +12,10 @@
*** Turning captions on
Found 5 menu items OK
EXPECTED (video.textTracks.length == '4') OK
-Track 0 should be disabled
-EXPECTED (video.textTracks[0].mode == 'disabled') OK
-Track 1 should be showing
-EXPECTED (video.textTracks[1].mode == 'showing') OK
+Track 0 should be showing
+EXPECTED (video.textTracks[0].mode == 'showing') OK
+Track 1 should be disabled
+EXPECTED (video.textTracks[1].mode == 'disabled') OK
Track 2 should be disabled
EXPECTED (video.textTracks[2].mode == 'disabled') OK
Track 3 should be disabled
Modified: trunk/LayoutTests/media/video-controls-captions-trackmenu.html (138218 => 138219)
--- trunk/LayoutTests/media/video-controls-captions-trackmenu.html 2012-12-20 05:28:21 UTC (rev 138218)
+++ trunk/LayoutTests/media/video-controls-captions-trackmenu.html 2012-12-20 05:30:25 UTC (rev 138219)
@@ -97,10 +97,10 @@
function testCaptionsVisible()
{
testExpected(video.textTracks.length, 4);
-consoleWrite(Track 0 should be disabled);
-testExpected(video.textTracks[0].mode, disabled);
-consoleWrite(Track 1 should be showing);
-testExpected(video.textTracks[1].mode, showing);
+consoleWrite(Track 0 should be showing);
+testExpected(video.textTracks[0].mode, showing);
+consoleWrite(Track 1 should be disabled);
+testExpected(video.textTracks[1].mode, disabled);
consoleWrite(Track 2 should be disabled);
testExpected(video.textTracks[2].mode, disabled);
consoleWrite(Track 3 should be disabled);
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [138220] trunk/Source/WebKit/chromium
Title: [138220] trunk/Source/WebKit/chromium
Revision 138220
Author commit-qu...@webkit.org
Date 2012-12-19 21:39:39 -0800 (Wed, 19 Dec 2012)
Log Message
[Chromium] Check Document now should work with continuous check off
https://bugs.webkit.org/show_bug.cgi?id=105228
Patch by Rachel Blum gr...@chromium.org on 2012-12-19
Reviewed by Anders Carlsson.
* src/EditorClientImpl.cpp:
(WebKit::EditorClientImpl::checkSpellingOfString):
Modified Paths
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/src/EditorClientImpl.cpp
Diff
Modified: trunk/Source/WebKit/chromium/ChangeLog (138219 => 138220)
--- trunk/Source/WebKit/chromium/ChangeLog 2012-12-20 05:30:25 UTC (rev 138219)
+++ trunk/Source/WebKit/chromium/ChangeLog 2012-12-20 05:39:39 UTC (rev 138220)
@@ -1,5 +1,15 @@
2012-12-19 Rachel Blum gr...@chromium.org
+[Chromium] Check Document now should work with continuous check off
+https://bugs.webkit.org/show_bug.cgi?id=105228
+
+Reviewed by Anders Carlsson.
+
+* src/EditorClientImpl.cpp:
+(WebKit::EditorClientImpl::checkSpellingOfString):
+
+2012-12-19 Rachel Blum gr...@chromium.org
+
[Chromium] Spellchecker should provide suggestions for non-caret selection, too
https://bugs.webkit.org/show_bug.cgi?id=104841
Modified: trunk/Source/WebKit/chromium/src/EditorClientImpl.cpp (138219 => 138220)
--- trunk/Source/WebKit/chromium/src/EditorClientImpl.cpp 2012-12-20 05:30:25 UTC (rev 138219)
+++ trunk/Source/WebKit/chromium/src/EditorClientImpl.cpp 2012-12-20 05:39:39 UTC (rev 138220)
@@ -726,7 +726,7 @@
int spellLength = 0;
// Check to see if the provided text is spelled correctly.
-if (isContinuousSpellCheckingEnabled() m_webView-spellCheckClient())
+if (m_webView-spellCheckClient())
m_webView-spellCheckClient()-spellCheck(WebString(text, length), spellLocation, spellLength, 0);
else {
spellLocation = 0;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [138221] trunk/Source/WebKit/chromium
Title: [138221] trunk/Source/WebKit/chromium
Revision 138221
Author pilg...@chromium.org
Date 2012-12-19 21:44:24 -0800 (Wed, 19 Dec 2012)
Log Message
[Chromium] add setIDBFactory method for embedders to call
https://bugs.webkit.org/show_bug.cgi?id=105465
Reviewed by Darin Fisher.
This is step 1 of getting rid of WebKitPlatform::idbFactory. This
adds a setter for embedders to call upon initialization, which (if
set) will be used instead of calling the idbFactory()
method. Eventually the idbFactory() method will go away, and this
setter will be the only way to initialize the Indexed Database API.
* public/WebIDBFactory.h:
(WebKit):
* src/IDBFactoryBackendProxy.cpp:
(WebKit):
(WebKit::setIDBFactory):
(WebKit::IDBFactoryBackendProxy::IDBFactoryBackendProxy):
Modified Paths
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/public/WebIDBFactory.h
trunk/Source/WebKit/chromium/src/IDBFactoryBackendProxy.cpp
Diff
Modified: trunk/Source/WebKit/chromium/ChangeLog (138220 => 138221)
--- trunk/Source/WebKit/chromium/ChangeLog 2012-12-20 05:39:39 UTC (rev 138220)
+++ trunk/Source/WebKit/chromium/ChangeLog 2012-12-20 05:44:24 UTC (rev 138221)
@@ -1,3 +1,23 @@
+2012-12-19 Mark Pilgrim pilg...@chromium.org
+
+[Chromium] add setIDBFactory method for embedders to call
+https://bugs.webkit.org/show_bug.cgi?id=105465
+
+Reviewed by Darin Fisher.
+
+This is step 1 of getting rid of WebKitPlatform::idbFactory. This
+adds a setter for embedders to call upon initialization, which (if
+set) will be used instead of calling the idbFactory()
+method. Eventually the idbFactory() method will go away, and this
+setter will be the only way to initialize the Indexed Database API.
+
+* public/WebIDBFactory.h:
+(WebKit):
+* src/IDBFactoryBackendProxy.cpp:
+(WebKit):
+(WebKit::setIDBFactory):
+(WebKit::IDBFactoryBackendProxy::IDBFactoryBackendProxy):
+
2012-12-19 Rachel Blum gr...@chromium.org
[Chromium] Check Document now should work with continuous check off
Modified: trunk/Source/WebKit/chromium/public/WebIDBFactory.h (138220 => 138221)
--- trunk/Source/WebKit/chromium/public/WebIDBFactory.h 2012-12-20 05:39:39 UTC (rev 138220)
+++ trunk/Source/WebKit/chromium/public/WebIDBFactory.h 2012-12-20 05:44:24 UTC (rev 138221)
@@ -63,6 +63,9 @@
virtual void deleteDatabase(const WebString name, WebIDBCallbacks*, const WebSecurityOrigin, WebFrame*, const WebString dataDir) { WEBKIT_ASSERT_NOT_REACHED(); }
};
+// Initializes IndexedDB support.
+WEBKIT_EXPORT void setIDBFactory(WebIDBFactory*);
+
} // namespace WebKit
#endif // WebIDBFactory_h
Modified: trunk/Source/WebKit/chromium/src/IDBFactoryBackendProxy.cpp (138220 => 138221)
--- trunk/Source/WebKit/chromium/src/IDBFactoryBackendProxy.cpp 2012-12-20 05:39:39 UTC (rev 138220)
+++ trunk/Source/WebKit/chromium/src/IDBFactoryBackendProxy.cpp 2012-12-20 05:44:24 UTC (rev 138221)
@@ -61,14 +61,24 @@
namespace WebKit {
+static WebIDBFactory* s_webIDBFactory = 0;
+
+void setIDBFactory(WebIDBFactory* factory)
+{
+s_webIDBFactory = factory;
+}
+
PassRefPtrIDBFactoryBackendInterface IDBFactoryBackendProxy::create()
{
return adoptRef(new IDBFactoryBackendProxy());
}
IDBFactoryBackendProxy::IDBFactoryBackendProxy()
-: m_webIDBFactory(webKitPlatformSupport()-idbFactory())
{
+if (s_webIDBFactory)
+m_webIDBFactory = s_webIDBFactory;
+else
+m_webIDBFactory = webKitPlatformSupport()-idbFactory();
}
IDBFactoryBackendProxy::~IDBFactoryBackendProxy()
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [138222] trunk/Source/WebCore
Title: [138222] trunk/Source/WebCore
Revision 138222
Author jap...@chromium.org
Date 2012-12-19 21:44:54 -0800 (Wed, 19 Dec 2012)
Log Message
REGRESSION(r137607): resource load client callbacks are not called for the main resource when loading HTML string
https://bugs.webkit.org/show_bug.cgi?id=105330
Reviewed by Brady Eidson.
* loader/MainResourceLoader.cpp:
(WebCore::MainResourceLoader::responseReceived):
(WebCore::MainResourceLoader::dataReceived):
(WebCore::MainResourceLoader::didFinishLoading):
(WebCore::MainResourceLoader::load):
(WebCore::MainResourceLoader::identifier):
* loader/MainResourceLoader.h:
(MainResourceLoader):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/loader/MainResourceLoader.cpp
trunk/Source/WebCore/loader/MainResourceLoader.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (138221 => 138222)
--- trunk/Source/WebCore/ChangeLog 2012-12-20 05:44:24 UTC (rev 138221)
+++ trunk/Source/WebCore/ChangeLog 2012-12-20 05:44:54 UTC (rev 138222)
@@ -1,3 +1,19 @@
+2012-12-19 Nate Chapin jap...@chromium.org
+
+REGRESSION(r137607): resource load client callbacks are not called for the main resource when loading HTML string
+https://bugs.webkit.org/show_bug.cgi?id=105330
+
+Reviewed by Brady Eidson.
+
+* loader/MainResourceLoader.cpp:
+(WebCore::MainResourceLoader::responseReceived):
+(WebCore::MainResourceLoader::dataReceived):
+(WebCore::MainResourceLoader::didFinishLoading):
+(WebCore::MainResourceLoader::load):
+(WebCore::MainResourceLoader::identifier):
+* loader/MainResourceLoader.h:
+(MainResourceLoader):
+
2012-12-19 Cosmin Truta ctr...@rim.com
[BlackBerry] RSS reader mangles UTF-8
Modified: trunk/Source/WebCore/loader/MainResourceLoader.cpp (138221 => 138222)
--- trunk/Source/WebCore/loader/MainResourceLoader.cpp 2012-12-20 05:44:24 UTC (rev 138221)
+++ trunk/Source/WebCore/loader/MainResourceLoader.cpp 2012-12-20 05:44:54 UTC (rev 138222)
@@ -73,6 +73,7 @@
, m_loadingMultipartContent(false)
, m_waitingForContentPolicy(false)
, m_timeOfLastDataReceived(0.0)
+, m_substituteDataLoadIdentifier(0)
#if PLATFORM(MAC) !PLATFORM(IOS) __MAC_OS_X_VERSION_MIN_REQUIRED = 1080
, m_filter(0)
#endif
@@ -412,6 +413,9 @@
m_response = r;
+if (!loader())
+frameLoader()-notifier()-dispatchDidReceiveResponse(documentLoader(), identifier(), m_response, 0);
+
ASSERT(!m_waitingForContentPolicy);
m_waitingForContentPolicy = true;
ref(); // balanced by deref in continueAfterContentPolicy and cancel
@@ -476,6 +480,9 @@
}
#endif
+if (!loader())
+frameLoader()-notifier()-dispatchDidReceiveData(documentLoader(), identifier(), data, length, -1);
+
documentLoader()-applicationCacheHost()-mainResourceDataReceived(data, length, -1, false);
// The additional processing can do anything including possibly removing the last
@@ -513,6 +520,9 @@
RefPtrMainResourceLoader protect(this);
RefPtrDocumentLoader dl = documentLoader();
+if (!loader())
+frameLoader()-notifier()-dispatchDidFinishLoading(documentLoader(), identifier(), finishTime);
+
#if PLATFORM(MAC) !PLATFORM(IOS) __MAC_OS_X_VERSION_MIN_REQUIRED = 1080
if (m_filter) {
int length;
@@ -634,6 +644,9 @@
if (m_substituteData.isValid()) {
handleSubstituteDataLoadSoon(request);
+m_substituteDataLoadIdentifier = m_documentLoader-frame()-page()-progress()-createUniqueIdentifier();
+frameLoader()-notifier()-assignIdentifierToInitialRequest(m_substituteDataLoadIdentifier, documentLoader(), request);
+frameLoader()-notifier()-dispatchWillSendRequest(documentLoader(), m_substituteDataLoadIdentifier, request, ResourceResponse());
return;
}
@@ -679,6 +692,9 @@
unsigned long MainResourceLoader::identifier() const
{
+ASSERT(!m_substituteDataLoadIdentifier || !loader() || !loader()-identifier());
+if (m_substituteDataLoadIdentifier)
+return m_substituteDataLoadIdentifier;
if (ResourceLoader* resourceLoader = loader())
return resourceLoader-identifier();
return 0;
Modified: trunk/Source/WebCore/loader/MainResourceLoader.h (138221 => 138222)
--- trunk/Source/WebCore/loader/MainResourceLoader.h 2012-12-20 05:44:24 UTC (rev 138221)
+++ trunk/Source/WebCore/loader/MainResourceLoader.h 2012-12-20 05:44:54 UTC (rev 138222)
@@ -128,6 +128,7 @@
bool m_loadingMultipartContent;
bool m_waitingForContentPolicy;
double m_timeOfLastDataReceived;
+unsigned long m_substituteDataLoadIdentifier;
#if PLATFORM(MAC) !PLATFORM(IOS) __MAC_OS_X_VERSION_MIN_REQUIRED = 1080
WebFilterEvaluator *m_filter;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [138223] trunk/Source/WebKit/chromium
Title: [138223] trunk/Source/WebKit/chromium
Revision 138223
Author pi...@chromium.org
Date 2012-12-19 21:50:30 -0800 (Wed, 19 Dec 2012)
Log Message
[chromium] Remove old setBackingTextureId/setBackingIOSurfaceId API on WebPluginContainer
https://bugs.webkit.org/show_bug.cgi?id=105472
Reviewed by James Robinson.
This is not called anymore by chromium (as of r173545), using
setWebPlugin instead.
* public/WebPluginContainer.h:
* src/WebPluginContainerImpl.cpp:
(WebKit::WebPluginContainerImpl::WebPluginContainerImpl):
* src/WebPluginContainerImpl.h:
(WebPluginContainerImpl):
Modified Paths
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/public/WebPluginContainer.h
trunk/Source/WebKit/chromium/src/WebPluginContainerImpl.cpp
trunk/Source/WebKit/chromium/src/WebPluginContainerImpl.h
Diff
Modified: trunk/Source/WebKit/chromium/ChangeLog (138222 => 138223)
--- trunk/Source/WebKit/chromium/ChangeLog 2012-12-20 05:44:54 UTC (rev 138222)
+++ trunk/Source/WebKit/chromium/ChangeLog 2012-12-20 05:50:30 UTC (rev 138223)
@@ -1,3 +1,19 @@
+2012-12-19 Antoine Labour pi...@chromium.org
+
+[chromium] Remove old setBackingTextureId/setBackingIOSurfaceId API on WebPluginContainer
+https://bugs.webkit.org/show_bug.cgi?id=105472
+
+Reviewed by James Robinson.
+
+This is not called anymore by chromium (as of r173545), using
+setWebPlugin instead.
+
+* public/WebPluginContainer.h:
+* src/WebPluginContainerImpl.cpp:
+(WebKit::WebPluginContainerImpl::WebPluginContainerImpl):
+* src/WebPluginContainerImpl.h:
+(WebPluginContainerImpl):
+
2012-12-19 Mark Pilgrim pilg...@chromium.org
[Chromium] add setIDBFactory method for embedders to call
Modified: trunk/Source/WebKit/chromium/public/WebPluginContainer.h (138222 => 138223)
--- trunk/Source/WebKit/chromium/public/WebPluginContainer.h 2012-12-20 05:44:54 UTC (rev 138222)
+++ trunk/Source/WebKit/chromium/public/WebPluginContainer.h 2012-12-20 05:50:30 UTC (rev 138223)
@@ -64,25 +64,7 @@
// Causes the container to report its current geometry via
// WebPlugin::updateGeometry.
virtual void reportGeometry() = 0;
-
-// Sets the id of the texture used for hw-accel compositing.
-// The default value for id is zero which indicates software rendering.
-// A non-zero value will trigger hw-accelerated compositing.
-virtual void setBackingTextureId(unsigned) = 0;
-// Notifies the container that the plugin allocated a new IOSurface for
-// its rendering, and that the compositor should bind to this texture
-// and use it for subsequent rendering. A non-zero ioSurfaceId triggers
-// hardware-accelerated compositing; a zero value switches back to the
-// software rendered path. (This entry point is used only on Mac OS,
-// but is defined on all platforms for simplicity.)
-virtual void setBackingIOSurfaceId(int width,
- int height,
- uint32_t ioSurfaceId) = 0;
-// Called when the backing texture is ready to be composited.
-// FIXME: consider renaming to something more general, now that
-// there are multiple providers. One idea: commitBackingStore.
-virtual void commitBackingTexture() {}
-
+
// Drop any references to script objects allocated by the plugin.
// These are objects derived from WebPlugin::scriptableObject. This is
// called when the plugin is being destroyed or if it needs to be
@@ -111,9 +93,6 @@
// Note, this does NOT affect pageScaleFactor or pageZoomFactor
virtual void zoomLevelChanged(double zoomLevel) = 0;
-// Notifies whether the contents of the plugin are entirely opaque.
-virtual void setOpaque(bool) = 0;
-
// Determines whether the given rectangle in this plugin is above all other
// content. The rectangle is in the plugin's coordinate system.
virtual bool isRectTopmost(const WebRect) = 0;
Modified: trunk/Source/WebKit/chromium/src/WebPluginContainerImpl.cpp (138222 => 138223)
--- trunk/Source/WebKit/chromium/src/WebPluginContainerImpl.cpp 2012-12-20 05:44:54 UTC (rev 138222)
+++ trunk/Source/WebKit/chromium/src/WebPluginContainerImpl.cpp 2012-12-20 05:50:30 UTC (rev 138223)
@@ -390,50 +390,6 @@
}
}
-void WebPluginContainerImpl::setBackingTextureId(unsigned textureId)
-{
-#if USE(ACCELERATED_COMPOSITING)
-if (m_textureId == textureId)
-return;
-
-ASSERT(!m_ioSurfaceLayer);
-
-if (!m_textureLayer)
-m_textureLayer = adoptPtr(Platform::current()-compositorSupport()-createExternalTextureLayer());
-m_textureLayer-setTextureId(textureId);
-m_textureId = textureId;
-
-setWebLayer(m_textureId ? m_textureLayer-layer() : 0);
-#endif
-}
-
-void WebPluginContainerImpl::setBackingIOSurfaceId(int width,
- int height,
-
[webkit-changes] [138224] trunk
Title: [138224] trunk Revision 138224 Author eric.carl...@apple.com Date 2012-12-19 21:50:34 -0800 (Wed, 19 Dec 2012) Log Message Crash in TextTrack::trackIndexRelativeToRenderedTracks() https://bugs.webkit.org/show_bug.cgi?id=105371 Reviewed by Simon Fraser. Source/WebCore: Add an RAII object to manage text track update blocking, use it to always process the current cues to ensure that cues from a track that is deleted are removed from the shadow DOM before the next layout. No new tests, this fixes a crash in media/video-controls-captions-trackmenu.html. * html/HTMLMediaElement.cpp: (WebCore::TrackDisplayUpdateScope::TrackDisplayUpdateScope): New, call beginIgnoringTrackDisplayUpdateRequests. (WebCore::TrackDisplayUpdateScope::~TrackDisplayUpdateScope): New, call endIgnoringTrackDisplayUpdateRequests. (WebCore::HTMLMediaElement::beginIgnoringTrackDisplayUpdateRequests): (WebCore::HTMLMediaElement::endIgnoringTrackDisplayUpdateRequests): Call updateActiveTextTrackCues when the ignore count reaches zero. (WebCore::HTMLMediaElement::textTrackAddCues): Use TrackDisplayUpdateScope instead of calling beginIgnoringTrackDisplayUpdateRequests and endIgnoringTrackDisplayUpdateRequests directly. (WebCore::HTMLMediaElement::textTrackRemoveCues): Ditto. (WebCore::HTMLMediaElement::removeTrack): Ditto. (WebCore::HTMLMediaElement::removeAllInbandTracks): Ditto. (WebCore::HTMLMediaElement::didRemoveTrack): Ditto. Call removeTrack. * html/HTMLMediaElement.h: Declare TrackDisplayUpdateScope as a friend of HTMLMediaElement so it can call protected methods. LayoutTests: * platform/mac/TestExpectations: Unskip video-controls-captions-trackmenu.html. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/mac/TestExpectations trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/html/HTMLMediaElement.cpp trunk/Source/WebCore/html/HTMLMediaElement.h Diff Modified: trunk/LayoutTests/ChangeLog (138223 => 138224) --- trunk/LayoutTests/ChangeLog 2012-12-20 05:50:30 UTC (rev 138223) +++ trunk/LayoutTests/ChangeLog 2012-12-20 05:50:34 UTC (rev 138224) @@ -1,5 +1,14 @@ 2012-12-19 Eric Carlson eric.carl...@apple.com +Crash in TextTrack::trackIndexRelativeToRenderedTracks() +https://bugs.webkit.org/show_bug.cgi?id=105371 + +Reviewed by Simon Fraser. + +* platform/mac/TestExpectations: Unskip video-controls-captions-trackmenu.html. + +2012-12-19 Eric Carlson eric.carl...@apple.com + Update video-controls-captions-trackmenu.html https://bugs.webkit.org/show_bug.cgi?id=105455 Modified: trunk/LayoutTests/platform/mac/TestExpectations (138223 => 138224) --- trunk/LayoutTests/platform/mac/TestExpectations 2012-12-20 05:50:30 UTC (rev 138223) +++ trunk/LayoutTests/platform/mac/TestExpectations 2012-12-20 05:50:34 UTC (rev 138224) @@ -473,9 +473,6 @@ media/track/track-cue-rendering-vertical.html media/track/track-webvtt-tc028-unsupported-markup.html -# Asserts: https://bugs.webkit.org/show_bug.cgi?id=105371 -[ Debug ] media/video-controls-captions-trackmenu.html - # Opera-submitted tests to W3C for track, a lot of failures still. # Opera-submitted tests to W3C for track, a lot of failures still. webkit.org/b/103926 media/track/opera/idl/media-idl-tests.html [ Skip ] Modified: trunk/Source/WebCore/ChangeLog (138223 => 138224) --- trunk/Source/WebCore/ChangeLog 2012-12-20 05:50:30 UTC (rev 138223) +++ trunk/Source/WebCore/ChangeLog 2012-12-20 05:50:34 UTC (rev 138224) @@ -1,3 +1,31 @@ +2012-12-19 Eric Carlson eric.carl...@apple.com + +Crash in TextTrack::trackIndexRelativeToRenderedTracks() +https://bugs.webkit.org/show_bug.cgi?id=105371 + +Reviewed by Simon Fraser. + +Add an RAII object to manage text track update blocking, use it to always process the +current cues to ensure that cues from a track that is deleted are removed from the +shadow DOM before the next layout. + +No new tests, this fixes a crash in media/video-controls-captions-trackmenu.html. + +* html/HTMLMediaElement.cpp: +(WebCore::TrackDisplayUpdateScope::TrackDisplayUpdateScope): New, call beginIgnoringTrackDisplayUpdateRequests. +(WebCore::TrackDisplayUpdateScope::~TrackDisplayUpdateScope): New, call endIgnoringTrackDisplayUpdateRequests. +(WebCore::HTMLMediaElement::beginIgnoringTrackDisplayUpdateRequests): +(WebCore::HTMLMediaElement::endIgnoringTrackDisplayUpdateRequests): Call updateActiveTextTrackCues +when the ignore count reaches zero. +(WebCore::HTMLMediaElement::textTrackAddCues): Use TrackDisplayUpdateScope instead of calling +beginIgnoringTrackDisplayUpdateRequests and endIgnoringTrackDisplayUpdateRequests directly. +(WebCore::HTMLMediaElement::textTrackRemoveCues): Ditto. +(WebCore::HTMLMediaElement::removeTrack): Ditto. +(WebCore::HTMLMediaElement::removeAllInbandTracks): Ditto. +
[webkit-changes] [138225] trunk/Source
Title: [138225] trunk/Source Revision 138225 Author pilg...@chromium.org Date 2012-12-19 21:52:36 -0800 (Wed, 19 Dec 2012) Log Message [Chromium] Remove idbFactory from PlatformSupport https://bugs.webkit.org/show_bug.cgi?id=105460 Reviewed by Darin Fisher. Part of a larger refactoring series; see tracking bug 82948. Source/WebCore: * WebCore.gyp/WebCore.gyp: * WebCore.gypi: * platform/chromium/PlatformSupport.h: Removed. * storage/chromium: Removed. * storage/chromium/IDBFactoryBackendInterface.cpp: Removed. Source/WebKit/chromium: * WebKit.gyp: * src/IDBFactoryBackendInterface.cpp: Added. (WebCore): (WebCore::IDBFactoryBackendInterface::create): * src/PlatformSupport.cpp: Removed. Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/WebCore.gyp/WebCore.gyp trunk/Source/WebCore/WebCore.gypi trunk/Source/WebKit/chromium/ChangeLog trunk/Source/WebKit/chromium/WebKit.gyp Added Paths trunk/Source/WebKit/chromium/src/IDBFactoryBackendInterface.cpp Removed Paths trunk/Source/WebCore/platform/chromium/PlatformSupport.h trunk/Source/WebCore/storage/chromium/IDBFactoryBackendInterface.cpp trunk/Source/WebKit/chromium/src/PlatformSupport.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (138224 => 138225) --- trunk/Source/WebCore/ChangeLog 2012-12-20 05:50:34 UTC (rev 138224) +++ trunk/Source/WebCore/ChangeLog 2012-12-20 05:52:36 UTC (rev 138225) @@ -1,3 +1,18 @@ +2012-12-19 Mark Pilgrim pilg...@chromium.org + +[Chromium] Remove idbFactory from PlatformSupport +https://bugs.webkit.org/show_bug.cgi?id=105460 + +Reviewed by Darin Fisher. + +Part of a larger refactoring series; see tracking bug 82948. + +* WebCore.gyp/WebCore.gyp: +* WebCore.gypi: +* platform/chromium/PlatformSupport.h: Removed. +* storage/chromium: Removed. +* storage/chromium/IDBFactoryBackendInterface.cpp: Removed. + 2012-12-19 Eric Carlson eric.carl...@apple.com Crash in TextTrack::trackIndexRelativeToRenderedTracks() Modified: trunk/Source/WebCore/WebCore.gyp/WebCore.gyp (138224 => 138225) --- trunk/Source/WebCore/WebCore.gyp/WebCore.gyp 2012-12-20 05:50:34 UTC (rev 138224) +++ trunk/Source/WebCore/WebCore.gyp/WebCore.gyp 2012-12-20 05:52:36 UTC (rev 138225) @@ -144,7 +144,6 @@ '../rendering/style', '../rendering/svg', '../storage', - '../storage/chromium', '../svg', '../svg/animation', '../svg/graphics', Modified: trunk/Source/WebCore/WebCore.gypi (138224 => 138225) --- trunk/Source/WebCore/WebCore.gypi 2012-12-20 05:50:34 UTC (rev 138224) +++ trunk/Source/WebCore/WebCore.gypi 2012-12-20 05:52:36 UTC (rev 138225) @@ -2579,7 +2579,6 @@ 'storage/StorageTrackerClient.h', 'storage/StorageTracker.cpp', 'storage/StorageTracker.h', -'storage/chromium/IDBFactoryBackendInterface.cpp', 'workers/AbstractWorker.cpp', 'workers/AbstractWorker.h', 'workers/DedicatedWorkerContext.cpp', @@ -3653,7 +3652,6 @@ 'platform/chromium/PasteboardChromium.cpp', 'platform/chromium/PlatformKeyboardEventChromium.cpp', 'platform/chromium/PlatformScreenChromium.cpp', -'platform/chromium/PlatformSupport.h', 'platform/chromium/PlatformThemeChromiumDefault.cpp', 'platform/chromium/PlatformThemeChromiumDefault.h', 'platform/chromium/PlatformWidget.h', Deleted: trunk/Source/WebCore/platform/chromium/PlatformSupport.h (138224 => 138225) --- trunk/Source/WebCore/platform/chromium/PlatformSupport.h 2012-12-20 05:50:34 UTC (rev 138224) +++ trunk/Source/WebCore/platform/chromium/PlatformSupport.h 2012-12-20 05:52:36 UTC (rev 138225) @@ -1,52 +0,0 @@ -/* - * Copyright (c) 2010, Google Inc. All rights reserved. - * - * Redistribution and use in source and binary forms, with or without - * modification, are permitted provided that the following conditions are - * met: - * - * * Redistributions of source code must retain the above copyright - * notice, this list of conditions and the following disclaimer. - * * Redistributions in binary form must reproduce the above - * copyright notice, this list of conditions and the following disclaimer - * in the documentation and/or other materials provided with the - * distribution. - * * Neither the name of Google Inc. nor the names of its - * contributors may be used to endorse or promote products derived from - * this software without specific prior written permission. - * - * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS - * AS IS AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT - * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR - * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT - * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, - * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES
[webkit-changes] [138226] trunk
Title: [138226] trunk
Revision 138226
Author commit-qu...@webkit.org
Date 2012-12-19 21:57:47 -0800 (Wed, 19 Dec 2012)
Log Message
Adopt new assertion SPI for process suppression on Mac
https://bugs.webkit.org/show_bug.cgi?id=105378
Patch by Kiran Muppala cmupp...@apple.com on 2012-12-19
Reviewed by Mark Rowe.
Source/WebKit2:
Process suppression for WebKit2 child processes is currently enabled or disabled using AutomaticTermination.
This should be replaced with a new assertion SPI specific to process suppression.
* Shared/ChildProcess.cpp:
(WebKit::ChildProcess::ChildProcess): Remove unused member variable m_applicationIsOccluded.
* Shared/ChildProcess.h:
(WebKit::ChildProcess::applicationIsOccluded): Infer occlusion state from m_processVisibleAssertion.
* Shared/mac/ChildProcessMac.mm:
(WebKit::ChildProcess::setApplicationIsOccluded): Use applicationIsOccluded() accessor to check if the
occlusion state has changed and take or release a process visible assertion accordingly.
(WebKit::ChildProcess::platformInitialize): Remove call to initializeTimerCoalescingPolicy(), since taking
a process visible assertion also sets the timer coalescing policy appropriately. Set the occlusion
state to false on initialization.
WebKitLibraries:
Add WKNSProcessInfoProcessAssertionWithTypes().
* WebKitSystemInterface.h:
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/Shared/ChildProcess.cpp
trunk/Source/WebKit2/Shared/ChildProcess.h
trunk/Source/WebKit2/Shared/mac/ChildProcessMac.mm
trunk/WebKitLibraries/ChangeLog
trunk/WebKitLibraries/WebKitSystemInterface.h
Diff
Modified: trunk/Source/WebKit2/ChangeLog (138225 => 138226)
--- trunk/Source/WebKit2/ChangeLog 2012-12-20 05:52:36 UTC (rev 138225)
+++ trunk/Source/WebKit2/ChangeLog 2012-12-20 05:57:47 UTC (rev 138226)
@@ -1,3 +1,24 @@
+2012-12-19 Kiran Muppala cmupp...@apple.com
+
+Adopt new assertion SPI for process suppression on Mac
+https://bugs.webkit.org/show_bug.cgi?id=105378
+
+Reviewed by Mark Rowe.
+
+Process suppression for WebKit2 child processes is currently enabled or disabled using AutomaticTermination.
+This should be replaced with a new assertion SPI specific to process suppression.
+
+* Shared/ChildProcess.cpp:
+(WebKit::ChildProcess::ChildProcess): Remove unused member variable m_applicationIsOccluded.
+* Shared/ChildProcess.h:
+(WebKit::ChildProcess::applicationIsOccluded): Infer occlusion state from m_processVisibleAssertion.
+* Shared/mac/ChildProcessMac.mm:
+(WebKit::ChildProcess::setApplicationIsOccluded): Use applicationIsOccluded() accessor to check if the
+occlusion state has changed and take or release a process visible assertion accordingly.
+(WebKit::ChildProcess::platformInitialize): Remove call to initializeTimerCoalescingPolicy(), since taking
+a process visible assertion also sets the timer coalescing policy appropriately. Set the occlusion
+state to false on initialization.
+
2012-12-19 Alexey Proskuryakov a...@apple.com
rdar://problem/12890242 [WK2 NetworkProcess] Client doesn't receive SSL certificates
Modified: trunk/Source/WebKit2/Shared/ChildProcess.cpp (138225 => 138226)
--- trunk/Source/WebKit2/Shared/ChildProcess.cpp 2012-12-20 05:52:36 UTC (rev 138225)
+++ trunk/Source/WebKit2/Shared/ChildProcess.cpp 2012-12-20 05:57:47 UTC (rev 138226)
@@ -60,9 +60,6 @@
: m_terminationTimeout(0)
, m_terminationCounter(0)
, m_terminationTimer(RunLoop::main(), this, ChildProcess::terminationTimerFired)
-#if PLATFORM(MAC)
-, m_applicationIsOccluded(false)
-#endif
{
// FIXME: The termination timer should not be scheduled on the main run loop.
// It won't work with the threaded mode, but it's not really useful anyway as is.
Modified: trunk/Source/WebKit2/Shared/ChildProcess.h (138225 => 138226)
--- trunk/Source/WebKit2/Shared/ChildProcess.h 2012-12-20 05:52:36 UTC (rev 138225)
+++ trunk/Source/WebKit2/Shared/ChildProcess.h 2012-12-20 05:57:47 UTC (rev 138226)
@@ -28,6 +28,7 @@
#include Connection.h
#include WebCore/RunLoop.h
+#include wtf/RetainPtr.h
#if PLATFORM(MAC)
OBJC_CLASS NSString;
@@ -62,7 +63,7 @@
};
#if PLATFORM(MAC)
-bool applicationIsOccluded() const { return m_applicationIsOccluded; }
+bool applicationIsOccluded() const { return !m_processVisibleAssertion; }
void setApplicationIsOccluded(bool);
#endif
@@ -80,13 +81,6 @@
virtual bool shouldTerminate() = 0;
virtual void terminate();
-#if PLATFORM(MAC)
-void disableProcessSuppression(NSString *reason);
-void enableProcessSuppression(NSString *reason);
-
-static NSString * const processSuppressionVisibleApplicationReason;
-#endif
-
void platformInitialize();
// The timeout, in seconds, before this process will be terminated if termination
@@ -100,7 +94,7 @@
WebCore::RunLoop::TimerChildProcess m_terminationTimer;
[webkit-changes] [138227] trunk/Source/WebCore
Title: [138227] trunk/Source/WebCore
Revision 138227
Author tha...@chromium.org
Date 2012-12-19 22:08:11 -0800 (Wed, 19 Dec 2012)
Log Message
Remove slighly confusing } if pattern
https://bugs.webkit.org/show_bug.cgi?id=105492
Reviewed by Andreas Kling.
ADVANCE_TO ends in a goto statement, so this doesn't change behavior.
* html/parser/HTMLTokenizer.cpp:
(WebCore::HTMLTokenizer::nextToken):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/parser/HTMLTokenizer.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (138226 => 138227)
--- trunk/Source/WebCore/ChangeLog 2012-12-20 05:57:47 UTC (rev 138226)
+++ trunk/Source/WebCore/ChangeLog 2012-12-20 06:08:11 UTC (rev 138227)
@@ -1,3 +1,15 @@
+2012-12-19 Nico Weber tha...@chromium.org
+
+Remove slighly confusing } if pattern
+https://bugs.webkit.org/show_bug.cgi?id=105492
+
+Reviewed by Andreas Kling.
+
+ADVANCE_TO ends in a goto statement, so this doesn't change behavior.
+
+* html/parser/HTMLTokenizer.cpp:
+(WebCore::HTMLTokenizer::nextToken):
+
2012-12-19 Mark Pilgrim pilg...@chromium.org
[Chromium] Remove idbFactory from PlatformSupport
Modified: trunk/Source/WebCore/html/parser/HTMLTokenizer.cpp (138226 => 138227)
--- trunk/Source/WebCore/html/parser/HTMLTokenizer.cpp 2012-12-20 05:57:47 UTC (rev 138226)
+++ trunk/Source/WebCore/html/parser/HTMLTokenizer.cpp 2012-12-20 06:08:11 UTC (rev 138227)
@@ -348,7 +348,7 @@
else if (isASCIIUpper(cc)) {
m_token-appendToName(toLowerCase(cc));
HTML_ADVANCE_TO(TagNameState);
-} if (cc == InputStreamPreprocessor::endOfFileMarker) {
+} else if (cc == InputStreamPreprocessor::endOfFileMarker) {
parseError();
HTML_RECONSUME_IN(DataState);
} else {
@@ -616,7 +616,7 @@
else if (cc == '') {
bufferCharacter(cc);
HTML_ADVANCE_TO(ScriptDataState);
-} if (cc == InputStreamPreprocessor::endOfFileMarker) {
+} else if (cc == InputStreamPreprocessor::endOfFileMarker) {
parseError();
HTML_RECONSUME_IN(DataState);
} else {
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [138228] trunk
Title: [138228] trunk
Revision 138228
Author yu...@chromium.org
Date 2012-12-19 22:41:31 -0800 (Wed, 19 Dec 2012)
Log Message
Web Inspector: deny access from injected script to nodes from document with another origin
https://bugs.webkit.org/show_bug.cgi?id=105423
Reviewed by Pavel Feldman.
Source/WebCore:
Check that calling context can access the document inspected node belong to
before returning JS wrapper for the node.
Test: http/tests/inspector-protocol/access-inspected-object.html
* bindings/js/JSInjectedScriptHostCustom.cpp:
(WebCore::JSInjectedScriptHost::inspectedObject):
* bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
(WebCore::InjectedScriptHost::nodeAsScriptValue):
LayoutTests:
Test that $0 is ineaccible in the main frame if it is a node from an iframe that
is not accassible beacause of cross origin access checks.
* http/tests/inspector-protocol/access-inspected-object-expected.txt: Added.
* http/tests/inspector-protocol/access-inspected-object.html: Added.
* http/tests/inspector-protocol/resources/test-page.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/js/JSInjectedScriptHostCustom.cpp
trunk/Source/WebCore/bindings/v8/custom/V8InjectedScriptHostCustom.cpp
Added Paths
trunk/LayoutTests/http/tests/inspector-protocol/access-inspected-object-expected.txt
trunk/LayoutTests/http/tests/inspector-protocol/access-inspected-object.html
trunk/LayoutTests/http/tests/inspector-protocol/resources/test-page.html
Diff
Modified: trunk/LayoutTests/ChangeLog (138227 => 138228)
--- trunk/LayoutTests/ChangeLog 2012-12-20 06:08:11 UTC (rev 138227)
+++ trunk/LayoutTests/ChangeLog 2012-12-20 06:41:31 UTC (rev 138228)
@@ -1,3 +1,17 @@
+2012-12-19 Yury Semikhatsky yu...@chromium.org
+
+Web Inspector: deny access from injected script to nodes from document with another origin
+https://bugs.webkit.org/show_bug.cgi?id=105423
+
+Reviewed by Pavel Feldman.
+
+Test that $0 is ineaccible in the main frame if it is a node from an iframe that
+is not accassible beacause of cross origin access checks.
+
+* http/tests/inspector-protocol/access-inspected-object-expected.txt: Added.
+* http/tests/inspector-protocol/access-inspected-object.html: Added.
+* http/tests/inspector-protocol/resources/test-page.html: Added.
+
2012-12-19 Eric Carlson eric.carl...@apple.com
Crash in TextTrack::trackIndexRelativeToRenderedTracks()
Added: trunk/LayoutTests/http/tests/inspector-protocol/access-inspected-object-expected.txt (0 => 138228)
--- trunk/LayoutTests/http/tests/inspector-protocol/access-inspected-object-expected.txt (rev 0)
+++ trunk/LayoutTests/http/tests/inspector-protocol/access-inspected-object-expected.txt 2012-12-20 06:41:31 UTC (rev 138228)
@@ -0,0 +1,5 @@
+CONSOLE MESSAGE: Unsafe _javascript_ attempt to access frame with URL http://localhost:8000/inspector-protocol/resources/test-page.html from frame with URL http://127.0.0.1:8000/inspector-protocol/access-inspected-object.html. Domains, protocols and ports must match.
+
+Test that code evaluated in the main frame cannot access $0 that resolves into a node in a frame from a different domain. Bug 105423.
+
+
Property changes on: trunk/LayoutTests/http/tests/inspector-protocol/access-inspected-object-expected.txt
___
Added: svn:eol-style
Added: trunk/LayoutTests/http/tests/inspector-protocol/access-inspected-object.html (0 => 138228)
--- trunk/LayoutTests/http/tests/inspector-protocol/access-inspected-object.html (rev 0)
+++ trunk/LayoutTests/http/tests/inspector-protocol/access-inspected-object.html 2012-12-20 06:41:31 UTC (rev 138228)
@@ -0,0 +1,75 @@
+html
+head
+script type=text/_javascript_ src=""
+script
+if (window.testRunner) {
+testRunner.dumpAsText();
+testRunner.waitUntilDone();
+}
+
+function test()
+{
+InspectorTest.sendCommand(DOM.getDocument, {}, didGetDocument);
+
+function didGetDocument(messageObject)
+{
+InspectorTest.sendCommand(DOM.querySelector, {
+nodeId: messageObject.result.root.nodeId,
+selector: iframe#myframe
+}, didFindIframe);
+InspectorTest.eventHandler[DOM.setChildNodes] = iframeRequestHandler;
+}
+
+function didFindIframe(messageObject)
+{
+if (messageObject.error) {
+InspectorTest.log(FAIL: + messageObject.error);
+InspectorTest.completeTest();
+}
+}
+
+function iframeRequestHandler(messageObject)
+{
+var node = messageObject.params.nodes[0];
+if (!node || node.nodeName !== IFRAME)
+return;
+InspectorTest.eventHandler[DOM.setChildNodes] = null;
+InspectorTest.sendCommand(DOM.querySelector, {
+nodeId: node.contentDocument.nodeId,
+
