[webkit-changes] [139589] trunk/Source/WebCore

[loislo]

Title: [139589] trunk/Source/WebCore








Revision 139589
Author loi...@chromium.org
Date 2013-01-14 00:21:49 -0800 (Mon, 14 Jan 2013)


Log Message
Web Inspector: Native Memory Instrumentation: fix instrumentation for already instrumented classes 2/N
https://bugs.webkit.org/show_bug.cgi?id=106546

Reviewed by Vsevolod Vlasov.

Many nontrivial class members were added into reportMemoryUsage methods.

* bindings/v8/V8PerIsolateData.cpp:
(WebCore::V8PerIsolateData::reportMemoryUsage):
* css/CSSMediaRule.cpp:
(WebCore::CSSMediaRule::reportMemoryUsage):
* css/CSSProperty.cpp:
(WebCore::CSSProperty::reportMemoryUsage):
* css/CSSStyleSheet.cpp:
(WebCore::CSSStyleSheet::reportMemoryUsage):
* css/MediaList.cpp:
(WebCore::MediaList::reportMemoryUsage):
* css/RuleSet.cpp:
(WebCore::RuleData::reportMemoryUsage):
(WebCore::RuleSet::reportMemoryUsage):
(WebCore::RuleSet::RuleSetSelectorPair::reportMemoryUsage):
* css/StyleResolver.cpp:
(WebCore::StyleResolver::MatchedPropertiesCacheItem::reportMemoryUsage):
(WebCore::StyleResolver::reportMemoryUsage):
* css/StyleSheetContents.cpp:
(WebCore::StyleSheetContents::reportMemoryUsage):
* dom/TreeScope.cpp:
(WebCore::TreeScope::reportMemoryUsage):
* inspector/HeapGraphSerializer.cpp:
(WebCore::HeapGraphSerializer::reportMemoryUsage):
* inspector/InspectorMemoryAgent.cpp:
* inspector/InspectorProfilerAgent.cpp:
(WebCore::InspectorProfilerAgent::reportMemoryUsage):
* inspector/MemoryInstrumentationImpl.cpp:
(WebCore::MemoryInstrumentationClientImpl::reportMemoryUsage):
* loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::reportMemoryUsage):
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::reportMemoryUsage):
* loader/MainResourceLoader.cpp:
(WebCore::MainResourceLoader::reportMemoryUsage):
* loader/Prerenderer.cpp:
(WebCore::Prerenderer::reportMemoryUsage):
* loader/ResourceLoader.cpp:
(WebCore::ResourceLoader::reportMemoryUsage):
* loader/cache/CachedImage.cpp:
(WebCore::CachedImage::reportMemoryUsage):
* page/Page.cpp:
(WebCore::Page::reportMemoryUsage):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/v8/V8PerIsolateData.cpp
trunk/Source/WebCore/css/CSSProperty.cpp
trunk/Source/WebCore/css/CSSStyleSheet.cpp
trunk/Source/WebCore/css/MediaList.cpp
trunk/Source/WebCore/css/RuleSet.cpp
trunk/Source/WebCore/css/StyleResolver.cpp
trunk/Source/WebCore/css/StyleSheetContents.cpp
trunk/Source/WebCore/dom/TreeScope.cpp
trunk/Source/WebCore/inspector/HeapGraphSerializer.cpp
trunk/Source/WebCore/inspector/InspectorMemoryAgent.cpp
trunk/Source/WebCore/inspector/InspectorProfilerAgent.cpp
trunk/Source/WebCore/inspector/MemoryInstrumentationImpl.cpp
trunk/Source/WebCore/loader/DocumentLoader.cpp
trunk/Source/WebCore/loader/FrameLoader.cpp
trunk/Source/WebCore/loader/MainResourceLoader.cpp
trunk/Source/WebCore/loader/Prerenderer.cpp
trunk/Source/WebCore/loader/ResourceLoader.cpp
trunk/Source/WebCore/loader/cache/CachedImage.cpp
trunk/Source/WebCore/page/Page.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (139588 => 139589)

--- trunk/Source/WebCore/ChangeLog	2013-01-14 07:18:36 UTC (rev 139588)
+++ trunk/Source/WebCore/ChangeLog	2013-01-14 08:21:49 UTC (rev 139589)
@@ -1,3 +1,55 @@
+2013-01-10  Ilya Tikhonovsky  loi...@chromium.org
+
+Web Inspector: Native Memory Instrumentation: fix instrumentation for already instrumented classes 2/N
+https://bugs.webkit.org/show_bug.cgi?id=106546
+
+Reviewed by Vsevolod Vlasov.
+
+Many nontrivial class members were added into reportMemoryUsage methods.
+
+* bindings/v8/V8PerIsolateData.cpp:
+(WebCore::V8PerIsolateData::reportMemoryUsage):
+* css/CSSMediaRule.cpp:
+(WebCore::CSSMediaRule::reportMemoryUsage):
+* css/CSSProperty.cpp:
+(WebCore::CSSProperty::reportMemoryUsage):
+* css/CSSStyleSheet.cpp:
+(WebCore::CSSStyleSheet::reportMemoryUsage):
+* css/MediaList.cpp:
+(WebCore::MediaList::reportMemoryUsage):
+* css/RuleSet.cpp:
+(WebCore::RuleData::reportMemoryUsage):
+(WebCore::RuleSet::reportMemoryUsage):
+(WebCore::RuleSet::RuleSetSelectorPair::reportMemoryUsage):
+* css/StyleResolver.cpp:
+(WebCore::StyleResolver::MatchedPropertiesCacheItem::reportMemoryUsage):
+(WebCore::StyleResolver::reportMemoryUsage):
+* css/StyleSheetContents.cpp:
+(WebCore::StyleSheetContents::reportMemoryUsage):
+* dom/TreeScope.cpp:
+(WebCore::TreeScope::reportMemoryUsage):
+* inspector/HeapGraphSerializer.cpp:
+(WebCore::HeapGraphSerializer::reportMemoryUsage):
+* inspector/InspectorMemoryAgent.cpp:
+* inspector/InspectorProfilerAgent.cpp:
+(WebCore::InspectorProfilerAgent::reportMemoryUsage):
+* inspector/MemoryInstrumentationImpl.cpp:
+(WebCore::MemoryInstrumentationClientImpl::reportMemoryUsage):
+* loader/DocumentLoader.cpp:
+

[webkit-changes] [139590] trunk/Source/WebCore

[loislo]

Title: [139590] trunk/Source/WebCore








Revision 139590
Author loi...@chromium.org
Date 2013-01-14 01:12:30 -0800 (Mon, 14 Jan 2013)


Log Message
Web Inspector: Native Memory Instrumentation: fix instrumentation for already instrumented classes 3/3
https://bugs.webkit.org/show_bug.cgi?id=106764

Reviewed by Vsevolod Vlasov.

Last three classes with not instrumented members were fixed.

* css/CSSGroupingRule.cpp:
(WebCore::CSSGroupingRule::reportMemoryUsage):
* css/StyleScopeResolver.cpp:
(WebCore::StyleScopeResolver::reportMemoryUsage):
* loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::reportMemoryUsage):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/CSSGroupingRule.cpp
trunk/Source/WebCore/css/StyleScopeResolver.cpp
trunk/Source/WebCore/loader/cache/CachedResourceLoader.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (139589 => 139590)

--- trunk/Source/WebCore/ChangeLog	2013-01-14 08:21:49 UTC (rev 139589)
+++ trunk/Source/WebCore/ChangeLog	2013-01-14 09:12:30 UTC (rev 139590)
@@ -1,3 +1,19 @@
+2013-01-14  Ilya Tikhonovsky  loi...@chromium.org
+
+Web Inspector: Native Memory Instrumentation: fix instrumentation for already instrumented classes 3/3
+https://bugs.webkit.org/show_bug.cgi?id=106764
+
+Reviewed by Vsevolod Vlasov.
+
+Last three classes with not instrumented members were fixed.
+
+* css/CSSGroupingRule.cpp:
+(WebCore::CSSGroupingRule::reportMemoryUsage):
+* css/StyleScopeResolver.cpp:
+(WebCore::StyleScopeResolver::reportMemoryUsage):
+* loader/cache/CachedResourceLoader.cpp:
+(WebCore::CachedResourceLoader::reportMemoryUsage):
+
 2013-01-10  Ilya Tikhonovsky  loi...@chromium.org
 
 Web Inspector: Native Memory Instrumentation: fix instrumentation for already instrumented classes 2/N


Modified: trunk/Source/WebCore/css/CSSGroupingRule.cpp (139589 => 139590)

--- trunk/Source/WebCore/css/CSSGroupingRule.cpp	2013-01-14 08:21:49 UTC (rev 139589)
+++ trunk/Source/WebCore/css/CSSGroupingRule.cpp	2013-01-14 09:12:30 UTC (rev 139590)
@@ -164,6 +164,7 @@
 {
 MemoryClassInfo info(memoryObjectInfo, this, WebCoreMemoryTypes::CSS);
 CSSRule::reportMemoryUsage(memoryObjectInfo);
+info.addMember(m_groupRule);
 info.addMember(m_childRuleCSSOMWrappers);
 info.addMember(m_ruleListCSSOMWrapper);
 }


Modified: trunk/Source/WebCore/css/StyleScopeResolver.cpp (139589 => 139590)

--- trunk/Source/WebCore/css/StyleScopeResolver.cpp	2013-01-14 08:21:49 UTC (rev 139589)
+++ trunk/Source/WebCore/css/StyleScopeResolver.cpp	2013-01-14 09:12:30 UTC (rev 139590)
@@ -244,6 +244,7 @@
 info.addMember(m_authorStyles);
 info.addMember(m_stack);
 info.addMember(m_atHostRules);
+info.addMember(m_stackParent);
 }
 
 }


Modified: trunk/Source/WebCore/loader/cache/CachedResourceLoader.cpp (139589 => 139590)

--- trunk/Source/WebCore/loader/cache/CachedResourceLoader.cpp	2013-01-14 08:21:49 UTC (rev 139589)
+++ trunk/Source/WebCore/loader/cache/CachedResourceLoader.cpp	2013-01-14 09:12:30 UTC (rev 139590)
@@ -946,9 +946,17 @@
 {
 MemoryClassInfo info(memoryObjectInfo, this, WebCoreMemoryTypes::Loader);
 info.addMember(m_documentResources);
+info.addMember(m_document);
+info.addMember(m_documentLoader);
 info.addMember(m_validatedURLs);
 info.addMember(m_preloads);
 info.addMember(m_pendingPreloads);
+info.addMember(m_garbageCollectDocumentResourcesTimer);
+#if ENABLE(RESOURCE_TIMING)
+// FIXME: m_initiatorMap has pointers to already deleted CachedResources
+info.ignoreMember(m_initiatorMap);
+#endif
+
 }
 
 const ResourceLoaderOptions CachedResourceLoader::defaultCachedResourceOptions()






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [139591] trunk/Source/WebCore

[commit-queue]

Title: [139591] trunk/Source/WebCore








Revision 139591
Author commit-qu...@webkit.org
Date 2013-01-14 01:23:31 -0800 (Mon, 14 Jan 2013)


Log Message
Fix a typo error in the comments in PlatformContextSkia.h
https://bugs.webkit.org/show_bug.cgi?id=105612

Patch by Qiankun Miao qiankun.m...@intel.com on 2013-01-14
Reviewed by Stephen White.

If false we're rendering to a GraphicsContext for a web page, if false
we're not (as is the case when rendering to a canvas object). is
self-contradictory. The second flase in the comments should be
true. If true, we're rendering to an ImageBuffer which has a canvas
object.

* platform/graphics/skia/PlatformContextSkia.h:
(PlatformContextSkia):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/skia/PlatformContextSkia.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (139590 => 139591)

--- trunk/Source/WebCore/ChangeLog	2013-01-14 09:12:30 UTC (rev 139590)
+++ trunk/Source/WebCore/ChangeLog	2013-01-14 09:23:31 UTC (rev 139591)
@@ -1,3 +1,19 @@
+2013-01-14  Qiankun Miao  qiankun.m...@intel.com
+
+Fix a typo error in the comments in PlatformContextSkia.h
+https://bugs.webkit.org/show_bug.cgi?id=105612
+
+Reviewed by Stephen White.
+
+If false we're rendering to a GraphicsContext for a web page, if false
+we're not (as is the case when rendering to a canvas object). is
+self-contradictory. The second flase in the comments should be
+true. If true, we're rendering to an ImageBuffer which has a canvas
+object.
+
+* platform/graphics/skia/PlatformContextSkia.h:
+(PlatformContextSkia):
+
 2013-01-14  Ilya Tikhonovsky  loi...@chromium.org
 
 Web Inspector: Native Memory Instrumentation: fix instrumentation for already instrumented classes 3/3


Modified: trunk/Source/WebCore/platform/graphics/skia/PlatformContextSkia.h (139590 => 139591)

--- trunk/Source/WebCore/platform/graphics/skia/PlatformContextSkia.h	2013-01-14 09:12:30 UTC (rev 139590)
+++ trunk/Source/WebCore/platform/graphics/skia/PlatformContextSkia.h	2013-01-14 09:23:31 UTC (rev 139591)
@@ -85,7 +85,7 @@
 
 SkDevice* createCompatibleDevice(const IntSize, bool hasAlpha);
 
-// If false we're rendering to a GraphicsContext for a web page, if false
+// If false we're rendering to a GraphicsContext for a web page, if true
 // we're not (as is the case when rendering to a canvas object).
 // If this is true the contents have not been marked up with the magic
 // color and all text drawing needs to go to a layer so that the alpha is






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [139592] trunk/Tools

[commit-queue]

Title: [139592] trunk/Tools








Revision 139592
Author commit-qu...@webkit.org
Date 2013-01-14 01:30:03 -0800 (Mon, 14 Jan 2013)


Log Message
Sheriffbot command aliases need test cases
https://bugs.webkit.org/show_bug.cgi?id=106754

Patch by Alan Cutter alancut...@chromium.org on 2013-01-14
Reviewed by Eric Seidel.

* Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
(SheriffBotTest.test_command_aliases):

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/tool/commands/sheriffbot_unittest.py




Diff

Modified: trunk/Tools/ChangeLog (139591 => 139592)

--- trunk/Tools/ChangeLog	2013-01-14 09:23:31 UTC (rev 139591)
+++ trunk/Tools/ChangeLog	2013-01-14 09:30:03 UTC (rev 139592)
@@ -1,3 +1,13 @@
+2013-01-14  Alan Cutter  alancut...@chromium.org
+
+Sheriffbot command aliases need test cases
+https://bugs.webkit.org/show_bug.cgi?id=106754
+
+Reviewed by Eric Seidel.
+
+* Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
+(SheriffBotTest.test_command_aliases):
+
 2013-01-13  Alan Cutter  alancut...@chromium.org
 
 Allow users to misspell the sheriffs command in sheriffbot


Modified: trunk/Tools/Scripts/webkitpy/tool/commands/sheriffbot_unittest.py (139591 => 139592)

--- trunk/Tools/Scripts/webkitpy/tool/commands/sheriffbot_unittest.py	2013-01-14 09:23:31 UTC (rev 139591)
+++ trunk/Tools/Scripts/webkitpy/tool/commands/sheriffbot_unittest.py	2013-01-14 09:30:03 UTC (rev 139592)
@@ -26,8 +26,30 @@
 # (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
 # OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 
-from webkitpy.tool.commands.queuestest import QueuesTest
+from webkitpy.tool.commands.queuestest import QueuesTest, MockQueueEngine
+from webkitpy.tool.commands import SheriffBot
+from webkitpy.tool.mocktool import MockTool, MockOptions
+from webkitpy.tool.bot.irc_command import Rollout, Sheriffs
 
 
 class SheriffBotTest(QueuesTest):
-pass  # No unittests as the moment.
+def test_command_aliases(self):
+tool = MockTool()
+options = MockOptions()
+options.ensure_value(confirm, False)
+sheriffbot = SheriffBot()
+sheriffbot.execute(options, [], tool, MockQueueEngine)
+sheriffbot.begin_work_queue()
+irc_bot = sheriffbot._irc_bot
+# Test Rollout command aliases
+revert_command, args = irc_bot._parse_command_and_args(revert)
+self.assertEqual(revert_command, Rollout)
+# Test Sheriffs command aliases
+gardeners_command, args = irc_bot._parse_command_and_args(gardeners)
+self.assertEqual(gardeners_command, Sheriffs)
+sherifs_command, args = irc_bot._parse_command_and_args(sherifs)
+self.assertEqual(sherifs_command, Sheriffs)
+sherrifs_command, args = irc_bot._parse_command_and_args(sherrifs)
+self.assertEqual(sherrifs_command, Sheriffs)
+sherriffs_command, args = irc_bot._parse_command_and_args(sherriffs)
+self.assertEqual(sherriffs_command, Sheriffs)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [139593] trunk/Source/WebCore

[commit-queue]

Title: [139593] trunk/Source/WebCore








Revision 139593
Author commit-qu...@webkit.org
Date 2013-01-14 01:44:20 -0800 (Mon, 14 Jan 2013)


Log Message
Web Inspector: [Network] Add domain column
https://bugs.webkit.org/show_bug.cgi?id=106757

Patch by Eugene Klyuchnikov eus...@chromium.org on 2013-01-14
Reviewed by Pavel Feldman.

Adding new column will ease domain tracking / sorting.

* inspector/front-end/NetworkPanel.js: Added column.
* inspector/front-end/NetworkRequest.js:
(WebInspector.NetworkRequest.prototype.get domain): Added getter.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/NetworkPanel.js
trunk/Source/WebCore/inspector/front-end/NetworkRequest.js




Diff

Modified: trunk/Source/WebCore/ChangeLog (139592 => 139593)

--- trunk/Source/WebCore/ChangeLog	2013-01-14 09:30:03 UTC (rev 139592)
+++ trunk/Source/WebCore/ChangeLog	2013-01-14 09:44:20 UTC (rev 139593)
@@ -1,3 +1,16 @@
+2013-01-14  Eugene Klyuchnikov  eus...@chromium.org
+
+Web Inspector: [Network] Add domain column
+https://bugs.webkit.org/show_bug.cgi?id=106757
+
+Reviewed by Pavel Feldman.
+
+Adding new column will ease domain tracking / sorting.
+
+* inspector/front-end/NetworkPanel.js: Added column.
+* inspector/front-end/NetworkRequest.js:
+(WebInspector.NetworkRequest.prototype.get domain): Added getter.
+
 2013-01-14  Qiankun Miao  qiankun.m...@intel.com
 
 Fix a typo error in the comments in PlatformContextSkia.h


Modified: trunk/Source/WebCore/inspector/front-end/NetworkPanel.js (139592 => 139593)

--- trunk/Source/WebCore/inspector/front-end/NetworkPanel.js	2013-01-14 09:30:03 UTC (rev 139592)
+++ trunk/Source/WebCore/inspector/front-end/NetworkPanel.js	2013-01-14 09:44:20 UTC (rev 139593)
@@ -95,7 +95,7 @@
 WebInspector.networkLog.requests.forEach(this._appendRequest.bind(this));
 }
 
-WebInspector.NetworkLogView._defaultColumnsVisivility = {method: true, status: true, type: true, initiator: true, size: true, time: true};
+WebInspector.NetworkLogView._defaultColumnsVisivility = {method: true, status: true, domain: false, type: true, initiator: true, size: true, time: true};
 
 WebInspector.NetworkLogView.prototype = {
 _initializeView: function()
@@ -157,7 +157,7 @@
 
 _createTable: function()
 {
-var columns = {name: {}, method: {}, status: {}, type: {}, initiator: {}, size: {}, time: {}, timeline: {}};
+var columns = {name: {}, method: {}, status: {}, domain: {}, type: {}, initiator: {}, size: {}, time: {}, timeline: {}};
 
 columns.name.titleDOMFragment = this._makeHeaderFragment(WebInspector.UIString(Name), WebInspector.UIString(Path));
 columns.name.name = WebInspector.UIString(Name);
@@ -174,6 +174,10 @@
 columns.status.sortable = true;
 columns.status.weight = 6;
 
+columns.domain.title = WebInspector.UIString(Domain);
+columns.domain.sortable = true;
+columns.domain.weight = 6;
+
 columns.type.title = WebInspector.UIString(Type);
 columns.type.sortable = true;
 columns.type.weight = 6;
@@ -273,6 +277,7 @@
 this._sortingFunctions.name = WebInspector.NetworkDataGridNode.NameComparator;
 this._sortingFunctions.method = WebInspector.NetworkDataGridNode.RequestPropertyComparator.bind(null, method, false);
 this._sortingFunctions.status = WebInspector.NetworkDataGridNode.RequestPropertyComparator.bind(null, statusCode, false);
+this._sortingFunctions.domain = WebInspector.NetworkDataGridNode.RequestPropertyComparator.bind(null, domain, false);
 this._sortingFunctions.type = WebInspector.NetworkDataGridNode.RequestPropertyComparator.bind(null, mimeType, false);
 this._sortingFunctions.initiator = WebInspector.NetworkDataGridNode.InitiatorComparator;
 this._sortingFunctions.size = WebInspector.NetworkDataGridNode.SizeComparator;
@@ -1879,6 +1884,7 @@
 this._nameCell = this._createDivInTD(name);
 this._methodCell = this._createDivInTD(method);
 this._statusCell = this._createDivInTD(status);
+this._domainCell = this._createDivInTD(domain);
 this._typeCell = this._createDivInTD(type);
 this._initiatorCell = this._createDivInTD(initiator);
 this._sizeCell = this._createDivInTD(size);
@@ -1986,6 +1992,7 @@
 this._methodCell.setTextAndTitle(this._request.requestMethod);
 
 this._refreshStatusCell();
+this._refreshDomainCell();
 this._refreshTypeCell();
 this._refreshInitiatorCell();
 this._refreshSizeCell();
@@ -2063,6 +2070,13 @@
 }
 },
 
+_refreshDomainCell: function()
+{
+this._domainCell.removeChildren();
+this._domainCell.appendChild(document.createTextNode(this._request.domain));
+this._domainCell.title = this._request.parsedURL.host;
+},
+
 _refreshTypeCell: function()
 {
 if 

[webkit-changes] [139595] trunk/Source/WebCore

[haraken]

Title: [139595] trunk/Source/WebCore








Revision 139595
Author hara...@chromium.org
Date 2013-01-14 01:52:20 -0800 (Mon, 14 Jan 2013)


Log Message
[V8] Make an Isolate parameter mandatory in v8DateOrNull()
https://bugs.webkit.org/show_bug.cgi?id=106765

Reviewed by Adam Barth.

This is one of the efforts to kill all optional Isolate parameters.

No tests. No change in behavior.

* bindings/v8/V8Binding.h:
(WebCore::v8DateOrNull):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/v8/V8Binding.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (139594 => 139595)

--- trunk/Source/WebCore/ChangeLog	2013-01-14 09:49:56 UTC (rev 139594)
+++ trunk/Source/WebCore/ChangeLog	2013-01-14 09:52:20 UTC (rev 139595)
@@ -1,3 +1,17 @@
+2013-01-14  Kentaro Hara  hara...@chromium.org
+
+[V8] Make an Isolate parameter mandatory in v8DateOrNull()
+https://bugs.webkit.org/show_bug.cgi?id=106765
+
+Reviewed by Adam Barth.
+
+This is one of the efforts to kill all optional Isolate parameters.
+
+No tests. No change in behavior.
+
+* bindings/v8/V8Binding.h:
+(WebCore::v8DateOrNull):
+
 2013-01-14  Pablo Flouret  pab...@motorola.com
 
 Allow nesting of at-rules


Modified: trunk/Source/WebCore/bindings/v8/V8Binding.h (139594 => 139595)

--- trunk/Source/WebCore/bindings/v8/V8Binding.h	2013-01-14 09:49:56 UTC (rev 139594)
+++ trunk/Source/WebCore/bindings/v8/V8Binding.h	2013-01-14 09:52:20 UTC (rev 139595)
@@ -431,8 +431,9 @@
 return (object-IsDate() || object-IsNumber()) ? object-NumberValue() : std::numeric_limitsdouble::quiet_NaN();
 }
 
-inline v8::Handlev8::Value v8DateOrNull(double value, v8::Isolate* isolate = 0)
+inline v8::Handlev8::Value v8DateOrNull(double value, v8::Isolate* isolate)
 {
+ASSERT(isolate);
 return isfinite(value) ? v8::Date::New(value) : v8NullWithCheck(isolate);
 }
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [139597] trunk/Source/WebCore

[apavlov]

Title: [139597] trunk/Source/WebCore








Revision 139597
Author apav...@chromium.org
Date 2013-01-14 02:13:20 -0800 (Mon, 14 Jan 2013)


Log Message
Web Inspector: [Styles] HTML color names not converted to RGB/HEX/HSL when Color format feature used
https://bugs.webkit.org/show_bug.cgi?id=106767

Reviewed by Vsevolod Vlasov.

We used to render named colors as names regardless of the selected color format option.

* inspector/front-end/StylesSidebarPane.js:
(WebInspector.StylePropertyTreeElement.prototype.updateTitle.):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/StylesSidebarPane.js




Diff

Modified: trunk/Source/WebCore/ChangeLog (139596 => 139597)

--- trunk/Source/WebCore/ChangeLog	2013-01-14 09:55:11 UTC (rev 139596)
+++ trunk/Source/WebCore/ChangeLog	2013-01-14 10:13:20 UTC (rev 139597)
@@ -1,3 +1,15 @@
+2013-01-14  Alexander Pavlov  apav...@chromium.org
+
+Web Inspector: [Styles] HTML color names not converted to RGB/HEX/HSL when Color format feature used
+https://bugs.webkit.org/show_bug.cgi?id=106767
+
+Reviewed by Vsevolod Vlasov.
+
+We used to render named colors as names regardless of the selected color format option.
+
+* inspector/front-end/StylesSidebarPane.js:
+(WebInspector.StylePropertyTreeElement.prototype.updateTitle.):
+
 2013-01-14  Andrei Bucur  abu...@adobe.com
 
 Crash caused by incomplete cleanup of regions information for anonymous block


Modified: trunk/Source/WebCore/inspector/front-end/StylesSidebarPane.js (139596 => 139597)

--- trunk/Source/WebCore/inspector/front-end/StylesSidebarPane.js	2013-01-14 09:55:11 UTC (rev 139596)
+++ trunk/Source/WebCore/inspector/front-end/StylesSidebarPane.js	2013-01-14 10:13:20 UTC (rev 139597)
@@ -1819,8 +1819,6 @@
 var formatSetting = WebInspector.settings.colorFormat.get();
 if (formatSetting === cf.Original)
 format = cf.Original;
-else if (color.nickname)
-format = cf.Nickname;
 else if (formatSetting === cf.RGB)
 format = (color.simple ? cf.RGB : cf.RGBA);
 else if (formatSetting === cf.HSL)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [139598] trunk

[tommyw]

Title: [139598] trunk








Revision 139598
Author tom...@google.com
Date 2013-01-14 02:15:25 -0800 (Mon, 14 Jan 2013)


Log Message
MediaStream API: Change MediaStream::readyState to an boolean attribute called ended.
https://bugs.webkit.org/show_bug.cgi?id=106568

Reviewed by Adam Barth.

Source/WebCore:

See specification: http://dev.w3.org/2011/webrtc/editor/getusermedia.html

Existings tests updated to cover patch.

* Modules/mediastream/LocalMediaStream.cpp:
(WebCore::LocalMediaStream::stop):
* Modules/mediastream/MediaStream.cpp:
(WebCore::MediaStream::ended):
(WebCore::MediaStream::streamEnded):
* Modules/mediastream/MediaStream.h:
(MediaStream):
(WebCore::MediaStream::isLocal):
* Modules/mediastream/MediaStream.idl:
* Modules/mediastream/MediaStreamTrackList.cpp:
(WebCore::MediaStreamTrackList::add):
(WebCore::MediaStreamTrackList::remove):

LayoutTests:

* fast/mediastream/LocalMediaStream-onended-expected.txt:
* fast/mediastream/LocalMediaStream-onended.html:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/mediastream/LocalMediaStream-onended-expected.txt
trunk/LayoutTests/fast/mediastream/LocalMediaStream-onended.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/mediastream/LocalMediaStream.cpp
trunk/Source/WebCore/Modules/mediastream/MediaStream.cpp
trunk/Source/WebCore/Modules/mediastream/MediaStream.h
trunk/Source/WebCore/Modules/mediastream/MediaStream.idl
trunk/Source/WebCore/Modules/mediastream/MediaStreamTrackList.cpp




Diff

Modified: trunk/LayoutTests/ChangeLog (139597 => 139598)

--- trunk/LayoutTests/ChangeLog	2013-01-14 10:13:20 UTC (rev 139597)
+++ trunk/LayoutTests/ChangeLog	2013-01-14 10:15:25 UTC (rev 139598)
@@ -1,3 +1,13 @@
+2013-01-14  Tommy Widenflycht  tom...@google.com
+
+MediaStream API: Change MediaStream::readyState to an boolean attribute called ended.
+https://bugs.webkit.org/show_bug.cgi?id=106568
+
+Reviewed by Adam Barth.
+
+* fast/mediastream/LocalMediaStream-onended-expected.txt:
+* fast/mediastream/LocalMediaStream-onended.html:
+
 2013-01-14  Andrei Bucur  abu...@adobe.com
 
 Crash caused by incomplete cleanup of regions information for anonymous block


Modified: trunk/LayoutTests/fast/mediastream/LocalMediaStream-onended-expected.txt (139597 => 139598)

--- trunk/LayoutTests/fast/mediastream/LocalMediaStream-onended-expected.txt	2013-01-14 10:13:20 UTC (rev 139597)
+++ trunk/LayoutTests/fast/mediastream/LocalMediaStream-onended-expected.txt	2013-01-14 10:15:25 UTC (rev 139598)
@@ -3,7 +3,9 @@
 On success, you will see a series of PASS messages, followed by TEST COMPLETE.
 
 
+PASS stream.ended is false
 PASS streamEnded was called.
+PASS stream.ended is true
 PASS successfullyParsed is true
 
 TEST COMPLETE


Modified: trunk/LayoutTests/fast/mediastream/LocalMediaStream-onended.html (139597 => 139598)

--- trunk/LayoutTests/fast/mediastream/LocalMediaStream-onended.html	2013-01-14 10:13:20 UTC (rev 139597)
+++ trunk/LayoutTests/fast/mediastream/LocalMediaStream-onended.html	2013-01-14 10:15:25 UTC (rev 139598)
@@ -24,13 +24,17 @@
 }
 }
 
+var stream;
+
 function streamEnded() {
 testPassed('streamEnded was called.');
+shouldBeTrue('stream.ended');
 finishJSTest();
 }
 
 function gotStream(s) {
 stream = s;
+shouldBeFalse('stream.ended');
 try {
 stream._onended_ = streamEnded;
 stream.stop();


Modified: trunk/Source/WebCore/ChangeLog (139597 => 139598)

--- trunk/Source/WebCore/ChangeLog	2013-01-14 10:13:20 UTC (rev 139597)
+++ trunk/Source/WebCore/ChangeLog	2013-01-14 10:15:25 UTC (rev 139598)
@@ -1,3 +1,27 @@
+2013-01-14  Tommy Widenflycht  tom...@google.com
+
+MediaStream API: Change MediaStream::readyState to an boolean attribute called ended.
+https://bugs.webkit.org/show_bug.cgi?id=106568
+
+Reviewed by Adam Barth.
+
+See specification: http://dev.w3.org/2011/webrtc/editor/getusermedia.html
+
+Existings tests updated to cover patch.
+
+* Modules/mediastream/LocalMediaStream.cpp:
+(WebCore::LocalMediaStream::stop):
+* Modules/mediastream/MediaStream.cpp:
+(WebCore::MediaStream::ended):
+(WebCore::MediaStream::streamEnded):
+* Modules/mediastream/MediaStream.h:
+(MediaStream):
+(WebCore::MediaStream::isLocal):
+* Modules/mediastream/MediaStream.idl:
+* Modules/mediastream/MediaStreamTrackList.cpp:
+(WebCore::MediaStreamTrackList::add):
+(WebCore::MediaStreamTrackList::remove):
+
 2013-01-14  Alexander Pavlov  apav...@chromium.org
 
 Web Inspector: [Styles] HTML color names not converted to RGB/HEX/HSL when Color format feature used


Modified: trunk/Source/WebCore/Modules/mediastream/LocalMediaStream.cpp (139597 => 139598)

--- trunk/Source/WebCore/Modules/mediastream/LocalMediaStream.cpp	2013-01-14 10:13:20 UTC (rev 139597)
+++ 

[webkit-changes] [139599] trunk/Source/WebCore

[haraken]

Title: [139599] trunk/Source/WebCore








Revision 139599
Author hara...@chromium.org
Date 2013-01-14 02:44:47 -0800 (Mon, 14 Jan 2013)


Log Message
[V8] Call Isolate::GetCurrent() in a callback from WebCore
https://bugs.webkit.org/show_bug.cgi?id=106766

Reviewed by Adam Barth.

The objective is to pass an Isolate everywhere.
Given that a callback from WebCore is an entry point to V8,
we can call Isolate::GetCurrent() at the head of the callback
and pass it to other places. (In practice, handleEvent() is
the only callback used in the current WebKit.)

No tests. No change in behavior.

* bindings/scripts/CodeGeneratorV8.pm:
(GenerateCallbackImplementation):
(NativeToJSValue):
* bindings/scripts/test/V8/V8TestCallback.cpp:
(WebCore::V8TestCallback::callbackWithNoParam):
(WebCore::V8TestCallback::callbackWithClass1Param):
(WebCore::V8TestCallback::callbackWithClass2Param):
(WebCore::V8TestCallback::callbackWithStringList):
(WebCore::V8TestCallback::callbackWithBoolean):
(WebCore::V8TestCallback::callbackRequiresThisToPass):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm
trunk/Source/WebCore/bindings/scripts/test/V8/V8TestCallback.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (139598 => 139599)

--- trunk/Source/WebCore/ChangeLog	2013-01-14 10:15:25 UTC (rev 139598)
+++ trunk/Source/WebCore/ChangeLog	2013-01-14 10:44:47 UTC (rev 139599)
@@ -1,3 +1,29 @@
+2013-01-14  Kentaro Hara  hara...@chromium.org
+
+[V8] Call Isolate::GetCurrent() in a callback from WebCore
+https://bugs.webkit.org/show_bug.cgi?id=106766
+
+Reviewed by Adam Barth.
+
+The objective is to pass an Isolate everywhere.
+Given that a callback from WebCore is an entry point to V8,
+we can call Isolate::GetCurrent() at the head of the callback
+and pass it to other places. (In practice, handleEvent() is
+the only callback used in the current WebKit.)
+
+No tests. No change in behavior.
+
+* bindings/scripts/CodeGeneratorV8.pm:
+(GenerateCallbackImplementation):
+(NativeToJSValue):
+* bindings/scripts/test/V8/V8TestCallback.cpp:
+(WebCore::V8TestCallback::callbackWithNoParam):
+(WebCore::V8TestCallback::callbackWithClass1Param):
+(WebCore::V8TestCallback::callbackWithClass2Param):
+(WebCore::V8TestCallback::callbackWithStringList):
+(WebCore::V8TestCallback::callbackWithBoolean):
+(WebCore::V8TestCallback::callbackRequiresThisToPass):
+
 2013-01-14  Tommy Widenflycht  tom...@google.com
 
 MediaStream API: Change MediaStream::readyState to an boolean attribute called ended.


Modified: trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm (139598 => 139599)

--- trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm	2013-01-14 10:15:25 UTC (rev 139598)
+++ trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm	2013-01-14 10:44:47 UTC (rev 139599)
@@ -3379,7 +3379,7 @@
 @args = ();
 foreach my $param (@params) {
 my $paramName = $param-name;
-push(@implContent, v8::Handlev8::Value ${paramName}Handle =  . NativeToJSValue($param, $paramName) . ;\n);
+push(@implContent, v8::Handlev8::Value ${paramName}Handle =  . NativeToJSValue($param, $paramName, v8::Handlev8::Object(), v8::Isolate::GetCurrent()) . ;\n);
 push(@implContent, if (${paramName}Handle.IsEmpty()) {\n);
 push(@implContent, if (!isScriptControllerTerminating())\n);
 push(@implContent, CRASH();\n);
@@ -4023,14 +4023,13 @@
 my $signature = shift;
 my $value = shift;
 my $getCreationContext = shift;
-my $getCreationContextArg = $getCreationContext ? , $getCreationContext : ;
 my $getIsolate = shift;
-my $getIsolateArg = $getIsolate ? , $getIsolate : ;
 my $getHolderContainer = shift;
 my $getHolderContainerArg = $getHolderContainer ? , $getHolderContainer : ;
 my $getScriptWrappable = shift;
 my $getScriptWrappableArg = $getScriptWrappable ? , $getScriptWrappable : ;
 my $returnHandleType = shift;
+my $returnHandleTypeArg = $returnHandleType ? , $returnHandleType : ;
 
 my $type = $signature-type;
 
@@ -4042,16 +4041,16 @@
 # should be returned instead.
 if ($signature-extendedAttributes-{Reflect} and ($type eq unsigned long or $type eq unsigned short)) {
 $value =~ s/getUnsignedIntegralAttribute/getIntegralAttribute/g;
-return v8UnsignedInteger(std::max(0,  . $value . )$getIsolateArg);
+return v8UnsignedInteger(std::max(0,  . $value . ), $getIsolate);
 }
 
 # For all the types where we use 'int' as the representation type,
 # we use v8Integer() which has a fast small integer conversion check.
 my $nativeType = GetNativeType($type);
-return v8Integer($value$getIsolateArg) if $nativeType eq int;
-return 

[webkit-changes] [139600] trunk/Source/WebKit2

[kbalazs]

Title: [139600] trunk/Source/WebKit2








Revision 139600
Author kbal...@webkit.org
Date 2013-01-14 03:02:35 -0800 (Mon, 14 Jan 2013)


Log Message
[Qt][WK2] plugin tests assert in debug
https://bugs.webkit.org/show_bug.cgi?id=106659

Reviewed by Benjamin Poulain.

Fixed the misuse of String::split.

* Shared/Plugins/Netscape/x11/NetscapePluginModuleX11.cpp:
(WebKit::truncateToSingleLine):
Add an assert to make sure this function works well. I just walked there
while debugging the bug, and although it was innocent, adding this assertion
is logical.
* UIProcess/Plugins/qt/PluginProcessProxyQt.cpp:
(WebKit::PluginProcessProxy::scanPlugin):
The ASSERT was wrong. We have three lines, each ends in a newline, so split
with allowEmptyEntries=true will devide it to 4 substrings.

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/Shared/Plugins/Netscape/x11/NetscapePluginModuleX11.cpp
trunk/Source/WebKit2/UIProcess/Plugins/qt/PluginProcessProxyQt.cpp




Diff

Modified: trunk/Source/WebKit2/ChangeLog (139599 => 139600)

--- trunk/Source/WebKit2/ChangeLog	2013-01-14 10:44:47 UTC (rev 139599)
+++ trunk/Source/WebKit2/ChangeLog	2013-01-14 11:02:35 UTC (rev 139600)
@@ -1,3 +1,22 @@
+2013-01-11  Balazs Kelemen  kbal...@webkit.org
+
+[Qt][WK2] plugin tests assert in debug
+https://bugs.webkit.org/show_bug.cgi?id=106659
+
+Reviewed by Benjamin Poulain.
+
+Fixed the misuse of String::split.
+
+* Shared/Plugins/Netscape/x11/NetscapePluginModuleX11.cpp:
+(WebKit::truncateToSingleLine):
+Add an assert to make sure this function works well. I just walked there
+while debugging the bug, and although it was innocent, adding this assertion
+is logical.
+* UIProcess/Plugins/qt/PluginProcessProxyQt.cpp:
+(WebKit::PluginProcessProxy::scanPlugin):
+The ASSERT was wrong. We have three lines, each ends in a newline, so split
+with allowEmptyEntries=true will devide it to 4 substrings.
+
 2013-01-11  Filip Pizlo  fpi...@apple.com
 
 JITThunks should not compile only because of luck


Modified: trunk/Source/WebKit2/Shared/Plugins/Netscape/x11/NetscapePluginModuleX11.cpp (139599 => 139600)

--- trunk/Source/WebKit2/Shared/Plugins/Netscape/x11/NetscapePluginModuleX11.cpp	2013-01-14 10:44:47 UTC (rev 139599)
+++ trunk/Source/WebKit2/Shared/Plugins/Netscape/x11/NetscapePluginModuleX11.cpp	2013-01-14 11:02:35 UTC (rev 139600)
@@ -172,9 +172,9 @@
 }
 buffer[newLength++] = UChar('\n');
 
-if (newLength == oldLength + 1)
-return stringBuffer;
-return String(stringBuffer.characters16(), newLength);
+String result = (newLength == oldLength + 1) ? stringBuffer : String(stringBuffer.characters16(), newLength);
+ASSERT(result.endsWith(UChar('\n')));
+return result;
 }
 
 bool NetscapePluginModule::scanPlugin(const String pluginPath)


Modified: trunk/Source/WebKit2/UIProcess/Plugins/qt/PluginProcessProxyQt.cpp (139599 => 139600)

--- trunk/Source/WebKit2/UIProcess/Plugins/qt/PluginProcessProxyQt.cpp	2013-01-14 10:44:47 UTC (rev 139599)
+++ trunk/Source/WebKit2/UIProcess/Plugins/qt/PluginProcessProxyQt.cpp	2013-01-14 11:02:35 UTC (rev 139600)
@@ -208,7 +208,7 @@
 String output(reinterpret_castconst UChar*(outputBytes.constData()), outputBytes.size() / sizeof(UChar));
 VectorString lines;
 output.split(UChar('\n'), true, lines);
-ASSERT(lines.size() == 3);
+ASSERT(lines.size() == 4  lines.last().isEmpty());
 
 result.name.swap(lines[0]);
 result.description.swap(lines[1]);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [139601] trunk/Source/WebCore

[haraken]

Title: [139601] trunk/Source/WebCore








Revision 139601
Author hara...@chromium.org
Date 2013-01-14 03:10:36 -0800 (Mon, 14 Jan 2013)


Log Message
[V8] Pass an Isolate to associateObjectWithWrapper()
https://bugs.webkit.org/show_bug.cgi?id=106773

Reviewed by Adam Barth.

In preparation for making an Isolate parameter mandatory
in associateObjectWithWrapper(), this patch passes an
Isolate to associateObjectWithWrapper().

No tests. No change in behavior.

* bindings/v8/custom/V8ArrayBufferCustom.cpp:
(WebCore::V8ArrayBuffer::constructorCallbackCustom):
* bindings/v8/custom/V8ArrayBufferViewCustom.h:
(WebCore::wrapArrayBufferView):
(WebCore::constructWebGLArray):
* bindings/v8/custom/V8AudioContextCustom.cpp:
(WebCore::V8AudioContext::constructorCallbackCustom):
* bindings/v8/custom/V8DOMFormDataCustom.cpp:
(WebCore::V8DOMFormData::constructorCallbackCustom):
* bindings/v8/custom/V8DataViewCustom.cpp:
(WebCore::V8DataView::constructorCallbackCustom):
* bindings/v8/custom/V8HTMLImageElementConstructor.cpp:
(WebCore::v8HTMLImageElementConstructorCallback):
* bindings/v8/custom/V8IntentCustom.cpp:
(WebCore::V8Intent::constructorCallbackCustom):
* bindings/v8/custom/V8MessageChannelCustom.cpp:
(WebCore::V8MessageChannel::constructorCallbackCustom):
* bindings/v8/custom/V8MutationObserverCustom.cpp:
(WebCore::V8MutationObserver::constructorCallbackCustom):
* bindings/v8/custom/V8WebKitPointCustom.cpp:
(WebCore::V8WebKitPoint::constructorCallbackCustom):
* bindings/v8/custom/V8XMLHttpRequestCustom.cpp:
(WebCore::V8XMLHttpRequest::constructorCallbackCustom):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/v8/custom/V8ArrayBufferCustom.cpp
trunk/Source/WebCore/bindings/v8/custom/V8ArrayBufferViewCustom.h
trunk/Source/WebCore/bindings/v8/custom/V8AudioContextCustom.cpp
trunk/Source/WebCore/bindings/v8/custom/V8DOMFormDataCustom.cpp
trunk/Source/WebCore/bindings/v8/custom/V8DataViewCustom.cpp
trunk/Source/WebCore/bindings/v8/custom/V8HTMLImageElementConstructor.cpp
trunk/Source/WebCore/bindings/v8/custom/V8IntentCustom.cpp
trunk/Source/WebCore/bindings/v8/custom/V8MessageChannelCustom.cpp
trunk/Source/WebCore/bindings/v8/custom/V8MutationObserverCustom.cpp
trunk/Source/WebCore/bindings/v8/custom/V8WebKitPointCustom.cpp
trunk/Source/WebCore/bindings/v8/custom/V8XMLHttpRequestCustom.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (139600 => 139601)

--- trunk/Source/WebCore/ChangeLog	2013-01-14 11:02:35 UTC (rev 139600)
+++ trunk/Source/WebCore/ChangeLog	2013-01-14 11:10:36 UTC (rev 139601)
@@ -1,5 +1,42 @@
 2013-01-14  Kentaro Hara  hara...@chromium.org
 
+[V8] Pass an Isolate to associateObjectWithWrapper()
+https://bugs.webkit.org/show_bug.cgi?id=106773
+
+Reviewed by Adam Barth.
+
+In preparation for making an Isolate parameter mandatory
+in associateObjectWithWrapper(), this patch passes an
+Isolate to associateObjectWithWrapper().
+
+No tests. No change in behavior.
+
+* bindings/v8/custom/V8ArrayBufferCustom.cpp:
+(WebCore::V8ArrayBuffer::constructorCallbackCustom):
+* bindings/v8/custom/V8ArrayBufferViewCustom.h:
+(WebCore::wrapArrayBufferView):
+(WebCore::constructWebGLArray):
+* bindings/v8/custom/V8AudioContextCustom.cpp:
+(WebCore::V8AudioContext::constructorCallbackCustom):
+* bindings/v8/custom/V8DOMFormDataCustom.cpp:
+(WebCore::V8DOMFormData::constructorCallbackCustom):
+* bindings/v8/custom/V8DataViewCustom.cpp:
+(WebCore::V8DataView::constructorCallbackCustom):
+* bindings/v8/custom/V8HTMLImageElementConstructor.cpp:
+(WebCore::v8HTMLImageElementConstructorCallback):
+* bindings/v8/custom/V8IntentCustom.cpp:
+(WebCore::V8Intent::constructorCallbackCustom):
+* bindings/v8/custom/V8MessageChannelCustom.cpp:
+(WebCore::V8MessageChannel::constructorCallbackCustom):
+* bindings/v8/custom/V8MutationObserverCustom.cpp:
+(WebCore::V8MutationObserver::constructorCallbackCustom):
+* bindings/v8/custom/V8WebKitPointCustom.cpp:
+(WebCore::V8WebKitPoint::constructorCallbackCustom):
+* bindings/v8/custom/V8XMLHttpRequestCustom.cpp:
+(WebCore::V8XMLHttpRequest::constructorCallbackCustom):
+
+2013-01-14  Kentaro Hara  hara...@chromium.org
+
 [V8] Call Isolate::GetCurrent() in a callback from WebCore
 https://bugs.webkit.org/show_bug.cgi?id=106766
 


Modified: trunk/Source/WebCore/bindings/v8/custom/V8ArrayBufferCustom.cpp (139600 => 139601)

--- trunk/Source/WebCore/bindings/v8/custom/V8ArrayBufferCustom.cpp	2013-01-14 11:02:35 UTC (rev 139600)
+++ trunk/Source/WebCore/bindings/v8/custom/V8ArrayBufferCustom.cpp	2013-01-14 11:10:36 UTC (rev 139601)
@@ -76,7 +76,7 @@
 v8::V8::AdjustAmountOfExternalAllocatedMemory(buffer-byteLength());
 // Transform the holder into a wrapper object for the array.
 

[webkit-changes] [139602] branches/chromium/1364

[pfeldman]

Title: [139602] branches/chromium/1364








Revision 139602
Author pfeld...@chromium.org
Date 2013-01-14 03:53:47 -0800 (Mon, 14 Jan 2013)


Log Message
Merge 139416
 Web Inspector [chromium]: Debugger.globalObjectCleared is not dispatched on reload after renderer swap
 https://bugs.webkit.org/show_bug.cgi?id=106555
 
 Reviewed by Vsevolod Vlasov.
 
 Source/WebCore:
 
 Wrong ::enable was made virtual in the InspectorDebuggerAgent.
 
 Test: inspector/debugger/debugger-scripts-reload.html
 
 * inspector/InspectorDebuggerAgent.h:
 (InspectorDebuggerAgent):
 * inspector/PageDebuggerAgent.cpp:
 (WebCore::PageDebuggerAgent::enable):
 (WebCore::PageDebuggerAgent::disable):
 * inspector/PageDebuggerAgent.h:
 (PageDebuggerAgent):
 
 LayoutTests:
 
 * http/tests/inspector/debugger-test.js:
 (initialize_DebuggerTest):
 * inspector/debugger/debugger-scripts-reload-expected.txt: Added.
 * inspector/debugger/debugger-scripts-reload.html: Added.

TBR=pfeld...@chromium.org
BUG=169437
Review URL: https://codereview.chromium.org/11876015

Modified Paths

branches/chromium/1364/LayoutTests/http/tests/inspector/debugger-test.js
branches/chromium/1364/Source/WebCore/inspector/InspectorDebuggerAgent.h
branches/chromium/1364/Source/WebCore/inspector/PageDebuggerAgent.cpp
branches/chromium/1364/Source/WebCore/inspector/PageDebuggerAgent.h


Added Paths

branches/chromium/1364/LayoutTests/inspector/debugger/debugger-scripts-reload-expected.txt
branches/chromium/1364/LayoutTests/inspector/debugger/debugger-scripts-reload.html




Diff

Modified: branches/chromium/1364/LayoutTests/http/tests/inspector/debugger-test.js (139601 => 139602)

--- branches/chromium/1364/LayoutTests/http/tests/inspector/debugger-test.js	2013-01-14 11:10:36 UTC (rev 139601)
+++ branches/chromium/1364/LayoutTests/http/tests/inspector/debugger-test.js	2013-01-14 11:53:47 UTC (rev 139602)
@@ -284,7 +284,7 @@
 var scripts = [];
 for (var scriptId in WebInspector.debuggerModel._scripts) {
 var script = WebInspector.debuggerModel._scripts[scriptId];
-if (filter(script))
+if (!filter || filter(script))
 scripts.push(script);
 }
 return scripts;


Copied: branches/chromium/1364/LayoutTests/inspector/debugger/debugger-scripts-reload-expected.txt (from rev 139416, trunk/LayoutTests/inspector/debugger/debugger-scripts-reload-expected.txt) (0 => 139602)

--- branches/chromium/1364/LayoutTests/inspector/debugger/debugger-scripts-reload-expected.txt	(rev 0)
+++ branches/chromium/1364/LayoutTests/inspector/debugger/debugger-scripts-reload-expected.txt	2013-01-14 11:53:47 UTC (rev 139602)
@@ -0,0 +1,7 @@
+Tests that scripts list is cleared upon page reload.
+
+Debugger was enabled.
+Dummy script found: dummyScript.js
+Page reloaded.
+Debugger was disabled.
+


Copied: branches/chromium/1364/LayoutTests/inspector/debugger/debugger-scripts-reload.html (from rev 139416, trunk/LayoutTests/inspector/debugger/debugger-scripts-reload.html) (0 => 139602)

--- branches/chromium/1364/LayoutTests/inspector/debugger/debugger-scripts-reload.html	(rev 0)
+++ branches/chromium/1364/LayoutTests/inspector/debugger/debugger-scripts-reload.html	2013-01-14 11:53:47 UTC (rev 139602)
@@ -0,0 +1,51 @@
+html
+head
+script src=""
+script src=""
+
+script
+
+function test()
+{
+InspectorTest.evaluateInPage(function foo() {} //@ sourceURL=dummyScript.js, step1);
+
+function step1()
+{
+InspectorTest.startDebuggerTest(step2);
+}
+
+function step2()
+{
+InspectorTest.queryScripts(function(script) { step3({ data: script }) });
+WebInspector.debuggerModel.addEventListener(WebInspector.DebuggerModel.Events.ParsedScriptSource, step3);
+}
+
+function step3(event)
+{
+var script = event.data;
+if (script.sourceURL.indexOf(dummyScript.js) !== -1) {
+InspectorTest.addResult(Dummy script found:  + script.sourceURL);
+// Let scripts dispatch and reload.
+setTimeout(InspectorTest.reloadPage.bind(InspectorTest, afterReload), 0);
+}
+}
+
+function afterReload()
+{
+var scripts = InspectorTest.queryScripts();
+for (var i = 0; i  scripts.length; ++i) {
+if (scripts[i].sourceURL.indexOf(dummyScript.js) !== -1)
+InspectorTest.addResult(FAILED: dummy script found after navigation);
+}
+InspectorTest.completeDebuggerTest();
+}
+
+}
+/script
+/head
+body _onload_=runTest()
+p
+Tests that scripts list is cleared upon page reload.
+/p
+/body
+/html


Modified: branches/chromium/1364/Source/WebCore/inspector/InspectorDebuggerAgent.h (139601 => 139602)

--- branches/chromium/1364/Source/WebCore/inspector/InspectorDebuggerAgent.h	2013-01-14 11:10:36 UTC (rev 139601)
+++ branches/chromium/1364/Source/WebCore/inspector/InspectorDebuggerAgent.h	2013-01-14 11:53:47 UTC (rev 139602)
@@ -71,9 +71,6 @@
 virtual void 

[webkit-changes] [139603] branches/chromium/1364/Source/WebKit/chromium/src/js/devTools.css

[pfeldman]

Title: [139603] branches/chromium/1364/Source/WebKit/chromium/src/js/devTools.css








Revision 139603
Author pfeld...@chromium.org
Date 2013-01-14 03:57:50 -0800 (Mon, 14 Jan 2013)


Log Message
Merge 139413
 Web Inspector [chromium]: toolbar border is missing on non-Mac in docked-to-bottom mode
 https://bugs.webkit.org/show_bug.cgi?id=106560
 
 Reviewed by Vsevolod Vlasov.
 
 * src/js/devTools.css:
 (body.dock-to-bottom.platform-mac #toolbar):
 

TBR=pfeld...@chromium.org
BUG=169438
Review URL: https://codereview.chromium.org/11878018

Modified Paths

branches/chromium/1364/Source/WebKit/chromium/src/js/devTools.css




Diff

Modified: branches/chromium/1364/Source/WebKit/chromium/src/js/devTools.css (139602 => 139603)

--- branches/chromium/1364/Source/WebKit/chromium/src/js/devTools.css	2013-01-14 11:53:47 UTC (rev 139602)
+++ branches/chromium/1364/Source/WebKit/chromium/src/js/devTools.css	2013-01-14 11:57:50 UTC (rev 139603)
@@ -3,10 +3,13 @@
 }
 
 body.dock-to-bottom #toolbar {
-border-top-color: white;
 cursor: default; /* overriden */
 }
 
+body.dock-to-bottom.platform-mac #toolbar {
+border-top-color: white;
+}
+
 /* Chrome theme overrides */
 
 body.platform-windows #toolbar, body.platform-windows.inactive #toolbar {






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [139604] trunk/LayoutTests

[ossy]

Title: [139604] trunk/LayoutTests








Revision 139604
Author o...@webkit.org
Date 2013-01-14 04:03:05 -0800 (Mon, 14 Jan 2013)


Log Message
[Qt] Unreviewed gardening, skip a new asserting test to paint the bots green.

* platform/qt/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/qt/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (139603 => 139604)

--- trunk/LayoutTests/ChangeLog	2013-01-14 11:57:50 UTC (rev 139603)
+++ trunk/LayoutTests/ChangeLog	2013-01-14 12:03:05 UTC (rev 139604)
@@ -1,3 +1,9 @@
+2013-01-14  Csaba Osztrogonác  o...@webkit.org
+
+[Qt] Unreviewed gardening, skip a new asserting test to paint the bots green.
+
+* platform/qt/TestExpectations:
+
 2013-01-14  Tommy Widenflycht  tom...@google.com
 
 MediaStream API: Change MediaStream::readyState to an boolean attribute called ended.


Modified: trunk/LayoutTests/platform/qt/TestExpectations (139603 => 139604)

--- trunk/LayoutTests/platform/qt/TestExpectations	2013-01-14 11:57:50 UTC (rev 139603)
+++ trunk/LayoutTests/platform/qt/TestExpectations	2013-01-14 12:03:05 UTC (rev 139604)
@@ -2504,3 +2504,6 @@
 fast/workers/worker-document-leak.html
 fast/workers/worker-lifecycle.html
 fast/workers/storage/interrupt-database.html
+
+# [Qt] New fast/js/dfg-create-inlined-arguments-in-closure-inline.html asserts on 32 bit
+webkit.org/b/106459 [ Debug ] fast/js/dfg-create-inlined-arguments-in-closure-inline.html






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [139605] trunk/LayoutTests

[commit-queue]

Title: [139605] trunk/LayoutTests








Revision 139605
Author commit-qu...@webkit.org
Date 2013-01-14 04:05:58 -0800 (Mon, 14 Jan 2013)


Log Message
Web Inspector: InspectorTest.createTestEditor should not set any text in editor
https://bugs.webkit.org/show_bug.cgi?id=106772

Patch by Andrey Lushnikov lushni...@chromium.org on 2013-01-14
Reviewed by Pavel Feldman.

Add InspectorTest.fillEditorWithText helper method and remove this
functionality from InspectorTest.createTestEditor method.

* inspector/editor/editor-test.js:
(initialize_EditorTests.InspectorTest.createTestEditor): Removed functionality for setting editor text.
(initialize_EditorTests.InspectorTest.fillEditorWithText): Added.
* inspector/editor/text-editor-remove-chunks-from-dom.html:
* inspector/editor/text-editor-selection.html:
* inspector/editor/text-editor-type-over-decoration.html:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/inspector/editor/editor-test.js
trunk/LayoutTests/inspector/editor/text-editor-remove-chunks-from-dom.html
trunk/LayoutTests/inspector/editor/text-editor-selection.html
trunk/LayoutTests/inspector/editor/text-editor-type-over-decoration.html




Diff

Modified: trunk/LayoutTests/ChangeLog (139604 => 139605)

--- trunk/LayoutTests/ChangeLog	2013-01-14 12:03:05 UTC (rev 139604)
+++ trunk/LayoutTests/ChangeLog	2013-01-14 12:05:58 UTC (rev 139605)
@@ -1,3 +1,20 @@
+2013-01-14  Andrey Lushnikov  lushni...@chromium.org
+
+Web Inspector: InspectorTest.createTestEditor should not set any text in editor
+https://bugs.webkit.org/show_bug.cgi?id=106772
+
+Reviewed by Pavel Feldman.
+
+Add InspectorTest.fillEditorWithText helper method and remove this
+functionality from InspectorTest.createTestEditor method.
+
+* inspector/editor/editor-test.js:
+(initialize_EditorTests.InspectorTest.createTestEditor): Removed functionality for setting editor text.
+(initialize_EditorTests.InspectorTest.fillEditorWithText): Added.
+* inspector/editor/text-editor-remove-chunks-from-dom.html:
+* inspector/editor/text-editor-selection.html:
+* inspector/editor/text-editor-type-over-decoration.html:
+
 2013-01-14  Csaba Osztrogonác  o...@webkit.org
 
 [Qt] Unreviewed gardening, skip a new asserting test to paint the bots green.


Modified: trunk/LayoutTests/inspector/editor/editor-test.js (139604 => 139605)

--- trunk/LayoutTests/inspector/editor/editor-test.js	2013-01-14 12:03:05 UTC (rev 139604)
+++ trunk/LayoutTests/inspector/editor/editor-test.js	2013-01-14 12:05:58 UTC (rev 139605)
@@ -1,19 +1,23 @@
 function initialize_EditorTests()
 {
 
-InspectorTest.createTestEditor = function(lineCount, clientHeight, chunkSize)
+InspectorTest.createTestEditor = function(clientHeight, chunkSize)
 {
 WebInspector.debugDefaultTextEditor = true;
 var textEditor = new WebInspector.DefaultTextEditor(, new WebInspector.TextEditorDelegate());
 textEditor.overrideViewportForTest(0, clientHeight || 100, chunkSize || 10);
 textEditor.show(WebInspector.inspectorView.element);
+return textEditor;
+};
+
+InspectorTest.fillEditorWithText = function(textEditor, lineCount)
+{
 var textModel = textEditor._textModel;
 var lines = [];
 for (var i = 0; i  lineCount; ++i)
 lines.push(i);
 textModel.setText(lines.join(\n));
-return textEditor;
-};
+}
 
 InspectorTest.dumpEditorChunks = function(textEditor)
 {


Modified: trunk/LayoutTests/inspector/editor/text-editor-remove-chunks-from-dom.html (139604 => 139605)

--- trunk/LayoutTests/inspector/editor/text-editor-remove-chunks-from-dom.html	2013-01-14 12:03:05 UTC (rev 139604)
+++ trunk/LayoutTests/inspector/editor/text-editor-remove-chunks-from-dom.html	2013-01-14 12:05:58 UTC (rev 139605)
@@ -9,7 +9,8 @@
 InspectorTest.runTestSuite([
 function testDamageLastChunk(next)
 {
-var textEditor = InspectorTest.createTestEditor(5);
+var textEditor = InspectorTest.createTestEditor();
+InspectorTest.fillEditorWithText(textEditor, 5);
 textEditor.setText(textEditor.text() + \n);
 InspectorTest.addResult(\nBefore editing);
 InspectorTest.dumpEditorModel(textEditor);


Modified: trunk/LayoutTests/inspector/editor/text-editor-selection.html (139604 => 139605)

--- trunk/LayoutTests/inspector/editor/text-editor-selection.html	2013-01-14 12:03:05 UTC (rev 139604)
+++ trunk/LayoutTests/inspector/editor/text-editor-selection.html	2013-01-14 12:05:58 UTC (rev 139605)
@@ -6,7 +6,8 @@
 
 function test()
 {
-var textEditor = InspectorTest.createTestEditor(34);
+var textEditor = InspectorTest.createTestEditor();
+InspectorTest.fillEditorWithText(textEditor, 34);
 InspectorTest.dumpEditorChunks(textEditor);
 
 InspectorTest.runTestSuite([


Modified: trunk/LayoutTests/inspector/editor/text-editor-type-over-decoration.html (139604 => 139605)

--- 

[webkit-changes] [139606] trunk/Tools

[commit-queue]

Title: [139606] trunk/Tools








Revision 139606
Author commit-qu...@webkit.org
Date 2013-01-14 04:10:56 -0800 (Mon, 14 Jan 2013)


Log Message
Web Inspector: fix DRT to deliver simulated events to devtools front-end
https://bugs.webkit.org/show_bug.cgi?id=106650

Patch by Andrey Lushnikov lushni...@chromium.org on 2013-01-14
Reviewed by Pavel Feldman.

Add separated m_devToolsTestInterfaces object to testShell which is
bind to devTools webview.

* DumpRenderTree/chromium/TestShell.cpp:
(TestShell::initialize):
(TestShell::createMainWindow):
(TestShell::~TestShell):
(TestShell::showDevTools):
(TestShell::resetTestController):
(TestShell::bindJSObjectsToWindow):
(TestShell::createNewWindow):
* DumpRenderTree/chromium/TestShell.h:
(TestShell):

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/DumpRenderTree/chromium/TestShell.cpp
trunk/Tools/DumpRenderTree/chromium/TestShell.h




Diff

Modified: trunk/Tools/ChangeLog (139605 => 139606)

--- trunk/Tools/ChangeLog	2013-01-14 12:05:58 UTC (rev 139605)
+++ trunk/Tools/ChangeLog	2013-01-14 12:10:56 UTC (rev 139606)
@@ -1,3 +1,24 @@
+2013-01-14  Andrey Lushnikov  lushni...@chromium.org
+
+Web Inspector: fix DRT to deliver simulated events to devtools front-end
+https://bugs.webkit.org/show_bug.cgi?id=106650
+
+Reviewed by Pavel Feldman.
+
+Add separated m_devToolsTestInterfaces object to testShell which is
+bind to devTools webview.
+
+* DumpRenderTree/chromium/TestShell.cpp:
+(TestShell::initialize):
+(TestShell::createMainWindow):
+(TestShell::~TestShell):
+(TestShell::showDevTools):
+(TestShell::resetTestController):
+(TestShell::bindJSObjectsToWindow):
+(TestShell::createNewWindow):
+* DumpRenderTree/chromium/TestShell.h:
+(TestShell):
+
 2013-01-14  Alan Cutter  alancut...@chromium.org
 
 Sheriffbot command aliases need test cases


Modified: trunk/Tools/DumpRenderTree/chromium/TestShell.cpp (139605 => 139606)

--- trunk/Tools/DumpRenderTree/chromium/TestShell.cpp	2013-01-14 12:05:58 UTC (rev 139605)
+++ trunk/Tools/DumpRenderTree/chromium/TestShell.cpp	2013-01-14 12:10:56 UTC (rev 139606)
@@ -161,8 +161,10 @@
 void TestShell::initialize()
 {
 m_testInterfaces = adoptPtr(new WebTestInterfaces());
+m_devToolsTestInterfaces = adoptPtr(new WebTestInterfaces());
 m_testRunner = adoptPtr(new DRTTestRunner(this));
 m_testInterfaces-setTestRunner(m_testRunner.get());
+m_devToolsTestInterfaces-setTestRunner(m_testRunner.get());
 #if ENABLE(NOTIFICATIONS) || ENABLE(LEGACY_NOTIFICATIONS)
 m_notificationPresenter = adoptPtr(new NotificationPresenter(this));
 #endif
@@ -182,7 +184,7 @@
 void TestShell::createMainWindow()
 {
 m_drtDevToolsAgent = adoptPtr(new DRTDevToolsAgent);
-m_webViewHost = adoptPtr(createNewWindow(WebURL(), m_drtDevToolsAgent.get()));
+m_webViewHost = adoptPtr(createNewWindow(WebURL(), m_drtDevToolsAgent.get(), m_testInterfaces.get()));
 m_webView = m_webViewHost-webView();
 m_testInterfaces-setDelegate(m_webViewHost.get());
 m_testInterfaces-setWebView(m_webView);
@@ -195,6 +197,8 @@
 {
 m_testInterfaces-setDelegate(0);
 m_testInterfaces-setWebView(0);
+m_devToolsTestInterfaces-setDelegate(0);
+m_devToolsTestInterfaces-setWebView(0);
 m_testRunner-setDelegate(0);
 m_testRunner-setWebView(0);
 m_drtDevToolsAgent-setWebView(0);
@@ -213,9 +217,11 @@
 ASSERT(false);
 return;
 }
-m_devTools = createNewWindow(url);
+m_devTools = createNewWindow(url, 0, m_devToolsTestInterfaces.get());
 m_devTools-webView()-settings()-setMemoryInfoEnabled(true);
 m_devTools-setLogConsoleOutput(false);
+m_devToolsTestInterfaces-setDelegate(m_devTools);
+m_devToolsTestInterfaces-setWebView(m_devTools-webView());
 ASSERT(m_devTools);
 createDRTDevToolsClient(m_drtDevToolsAgent.get());
 }
@@ -317,6 +323,7 @@
 {
 resetWebSettings(*webView());
 m_testInterfaces-resetAll();
+m_devToolsTestInterfaces-resetAll();
 m_testRunner-reset();
 m_webViewHost-reset();
 #if ENABLE(NOTIFICATIONS) || ENABLE(LEGACY_NOTIFICATIONS)
@@ -740,27 +747,30 @@
 void TestShell::bindJSObjectsToWindow(WebFrame* frame)
 {
 WebTestingSupport::injectInternalsObject(frame);
-m_testInterfaces-bindTo(frame);
+if (m_devTools  m_devTools-webView() == frame-view())
+m_devToolsTestInterfaces-bindTo(frame);
+else
+m_testInterfaces-bindTo(frame);
 m_testRunner-bindToJavascript(frame, WebString::fromUTF8(testRunner));
 m_testRunner-bindToJavascript(frame, WebString::fromUTF8(layoutTestController));
 }
 
 WebViewHost* TestShell::createNewWindow(const WebKit::WebURL url)
 {
-return createNewWindow(url, 0);
+return createNewWindow(url, 0, m_testInterfaces.get());
 }
 
-WebViewHost* TestShell::createNewWindow(const WebKit::WebURL url, DRTDevToolsAgent* 

[webkit-changes] [139607] trunk

[apavlov]

Title: [139607] trunk








Revision 139607
Author apav...@chromium.org
Date 2013-01-14 04:36:30 -0800 (Mon, 14 Jan 2013)


Log Message
Web Inspector: [Styles] Color names parsed inside background-image values
https://bugs.webkit.org/show_bug.cgi?id=106770

Reviewed by Pavel Feldman.

Source/WebCore:

Test: inspector/styles/url-color-swatch.html

Spaces were not allowed in url(...) CSS property values.

* inspector/front-end/StylesSidebarPane.js:

LayoutTests:

* inspector/styles/url-color-swatch-expected.txt: Added.
* inspector/styles/url-color-swatch.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/StylesSidebarPane.js


Added Paths

trunk/LayoutTests/inspector/styles/url-color-swatch-expected.txt
trunk/LayoutTests/inspector/styles/url-color-swatch.html




Diff

Modified: trunk/LayoutTests/ChangeLog (139606 => 139607)

--- trunk/LayoutTests/ChangeLog	2013-01-14 12:10:56 UTC (rev 139606)
+++ trunk/LayoutTests/ChangeLog	2013-01-14 12:36:30 UTC (rev 139607)
@@ -1,3 +1,13 @@
+2013-01-14  Alexander Pavlov  apav...@chromium.org
+
+Web Inspector: [Styles] Color names parsed inside background-image values
+https://bugs.webkit.org/show_bug.cgi?id=106770
+
+Reviewed by Pavel Feldman.
+
+* inspector/styles/url-color-swatch-expected.txt: Added.
+* inspector/styles/url-color-swatch.html: Added.
+
 2013-01-14  Andrey Lushnikov  lushni...@chromium.org
 
 Web Inspector: InspectorTest.createTestEditor should not set any text in editor


Added: trunk/LayoutTests/inspector/styles/url-color-swatch-expected.txt (0 => 139607)

--- trunk/LayoutTests/inspector/styles/url-color-swatch-expected.txt	(rev 0)
+++ trunk/LayoutTests/inspector/styles/url-color-swatch-expected.txt	2013-01-14 12:36:30 UTC (rev 139607)
@@ -0,0 +1,5 @@
+Tests that url(...) with space-delimited color names as filename segments do not contain color swatches. Bug 106770.
+
+url(red green blue.jpg)
+[] red
+
Property changes on: trunk/LayoutTests/inspector/styles/url-color-swatch-expected.txt
___


Added: svn:eol-style

Added: trunk/LayoutTests/inspector/styles/url-color-swatch.html (0 => 139607)

--- trunk/LayoutTests/inspector/styles/url-color-swatch.html	(rev 0)
+++ trunk/LayoutTests/inspector/styles/url-color-swatch.html	2013-01-14 12:36:30 UTC (rev 139607)
@@ -0,0 +1,60 @@
+html
+head
+style
+#inspected {
+background-image: url(red green blue.jpg);
+color: red;
+}
+/style
+script src=""
+script src=""
+script
+
+function test()
+{
+InspectorTest.selectNodeAndWaitForStyles(inspected, step1);
+
+function step1()
+{
+dumpDOM(InspectorTest.getMatchedStylePropertyTreeItem(background-image));
+dumpDOM(InspectorTest.getMatchedStylePropertyTreeItem(color));
+InspectorTest.completeTest();
+}
+
+function dumpDOM(treeItem)
+{
+var element = treeItem.listItemElement.getElementsByClassName(value)[0];
+var result = [];
+dumpNode(element, result);
+InspectorTest.addResult(result.join());
+}
+
+function dumpNode(parentNode, result)
+{
+var childNodes = parentNode.childNodes;
+for (var i = 0; i  childNodes.length; ++i) {
+var node = childNodes[i];
+switch (node.nodeType) {
+case Node.ELEMENT_NODE:
+if (node.hasStyleClass(swatch))
+result.push([] );
+else
+dumpNode(node, result);
+break;
+case Node.TEXT_NODE:
+result.push(node.nodeValue);
+break;
+}
+}
+}
+}
+
+/script
+/head
+body _onload_=runTest()
+p
+Tests that url(...) with space-delimited color names as filename segments do not contain color swatches. Bug a href=""
+/p
+div id=inspected/div
+/body
+/html
Property changes on: trunk/LayoutTests/inspector/styles/url-color-swatch.html
___


Added: svn:eol-style

Modified: trunk/Source/WebCore/ChangeLog (139606 => 139607)

--- trunk/Source/WebCore/ChangeLog	2013-01-14 12:10:56 UTC (rev 139606)
+++ trunk/Source/WebCore/ChangeLog	2013-01-14 12:36:30 UTC (rev 139607)
@@ -1,3 +1,16 @@
+2013-01-14  Alexander Pavlov  apav...@chromium.org
+
+Web Inspector: [Styles] Color names parsed inside background-image values
+https://bugs.webkit.org/show_bug.cgi?id=106770
+
+Reviewed by Pavel Feldman.
+
+Test: inspector/styles/url-color-swatch.html
+
+Spaces were not allowed in url(...) CSS property values.
+
+* inspector/front-end/StylesSidebarPane.js:
+
 2013-01-14  Kentaro Hara  hara...@chromium.org
 
 [V8] Pass an Isolate to associateObjectWithWrapper()


Modified: trunk/Source/WebCore/inspector/front-end/StylesSidebarPane.js 

[webkit-changes] [139608] trunk/Tools

[rakuco]

Title: [139608] trunk/Tools








Revision 139608
Author rak...@webkit.org
Date 2013-01-14 04:54:33 -0800 (Mon, 14 Jan 2013)


Log Message
[EFL][jhbuild] Bump the EFL dependencies in jhbuild to 1.7.5.
https://bugs.webkit.org/show_bug.cgi?id=106574

Reviewed by Laszlo Gombos.

Rely on a more recent stable release, which includes support for
Lua 5.2 in Edje and other assorted minor fixes.

While here, also use the configure script to build the libraries
instead of relying on autogen.sh, which is not really needed with
a release tarball and may have problems with automake 1.13.

* efl/jhbuild.modules:

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/efl/jhbuild.modules




Diff

Modified: trunk/Tools/ChangeLog (139607 => 139608)

--- trunk/Tools/ChangeLog	2013-01-14 12:36:30 UTC (rev 139607)
+++ trunk/Tools/ChangeLog	2013-01-14 12:54:33 UTC (rev 139608)
@@ -1,3 +1,19 @@
+2013-01-09  Raphael Kubo da Costa  raphael.kubo.da.co...@intel.com
+
+[EFL][jhbuild] Bump the EFL dependencies in jhbuild to 1.7.5.
+https://bugs.webkit.org/show_bug.cgi?id=106574
+
+Reviewed by Laszlo Gombos.
+
+Rely on a more recent stable release, which includes support for
+Lua 5.2 in Edje and other assorted minor fixes.
+
+While here, also use the configure script to build the libraries
+instead of relying on autogen.sh, which is not really needed with
+a release tarball and may have problems with automake 1.13.
+
+* efl/jhbuild.modules:
+
 2013-01-14  Andrey Lushnikov  lushni...@chromium.org
 
 Web Inspector: fix DRT to deliver simulated events to devtools front-end


Modified: trunk/Tools/efl/jhbuild.modules (139607 => 139608)

--- trunk/Tools/efl/jhbuild.modules	2013-01-14 12:36:30 UTC (rev 139607)
+++ trunk/Tools/efl/jhbuild.modules	2013-01-14 12:54:33 UTC (rev 139608)
@@ -170,42 +170,38 @@
/branch
  /autotools
 
-  autotools id=eina
-branch module=releases/eina-1.7.1.tar.bz2 version=1.7.1
-checkoutdir=eina-1.7.1
+  autotools id=eina autogen-sh=configure
+branch module=releases/eina-1.7.5.tar.bz2 version=1.7.5
 repo=download.enlightenment.org
-hash=sha256:af0b316734ba72d92fa7716005efd380f28677c76f0e0b6a3c5a9b524575a6ce
-md5sum=552c5e9042d9cb3dbdebbc0e211ef30b
+hash=sha256:fc08c8aa3a225e3a42793afbf109788ab003de7595a542607a6a65694d08a44d
+md5sum=ea505aa52729de68ed6c00e1e45c3c50
 /branch
   /autotools
 
-  autotools id=embryo
-branch module=releases/embryo-1.7.1.tar.bz2 version=1.7.1
-checkoutdir=embryo-1.7.1
+  autotools id=embryo autogen-sh=configure
+branch module=releases/embryo-1.7.5.tar.bz2 version=1.7.5
 repo=download.enlightenment.org
-hash=sha256:043563b8c1a66de117cfaaf76a4d9736e111007ce5c0cdcf2b1d83dd8b4df575
-md5sum=d66a0e91dfc37eeb4c362b2c46bd91ab
+hash=sha256:a946d6b4e6aa94b39537aa6746f4653d9235d8b9ca3a0dc0734df07482d28e80
+md5sum=a52682ebfd04a0e787028732ee8f11f9
 /branch
 dependencies
   dep package=eina/
 /dependencies
   /autotools
 
-  autotools id=evas
-branch module=releases/evas-1.7.1.tar.bz2 version=1.7.1
-checkoutdir=evas-1.7.1
+  autotools id=evas autogen-sh=configure
+branch module=releases/evas-1.7.5.tar.bz2 version=1.7.5
 repo=download.enlightenment.org
-hash=sha256:57966a16fdb20e94deefe83ec0f990607413f7952f9755ed23ce81aea49b670c
-md5sum=e33c1d270b16e45c2337424aa2f0
+hash=sha256:70b350a970b2086787622845896f3e54de278fe698b8069796fd752e70427374
+md5sum=2c965b836128a839292161d4ca89380d
 /branch
   /autotools
 
-  autotools id=ecore
-branch module=releases/ecore-1.7.1.tar.bz2 version=1.7.1
-checkoutdir=ecore-1.7.1
+  autotools id=ecore autogen-sh=configure
+branch module=releases/ecore-1.7.5.tar.bz2 version=1.7.5
 repo=download.enlightenment.org
-hash=sha256:fb5f547a0a6556b5f0e274b65cfbe42f4eb8371f20d5cd4f5a78a6b6a5d8
-md5sum=94fd264e478323a1100b3cfff833d28d
+hash=sha256:4bbaba2153db0c356d13c45adfbcc90c7118abd112d0817581417e708d6a9222
+md5sum=9ea98367ec40f7121ea61948bb395553
 /branch
 dependencies
   dep package=eina/
@@ -213,12 +209,11 @@
 /dependencies
   /autotools
 
-  autotools id=eet
-branch module=releases/eet-1.7.1.tar.bz2 version=1.7.1
-checkoutdir=eet-1.7.1
+  autotools id=eet autogen-sh=configure
+branch module=releases/eet-1.7.5.tar.bz2 version=1.7.5
 repo=download.enlightenment.org
-hash=sha256:3e5679c06792f0a1c4b5b158468afbcec3b510c60345055d5964fdbe2abba3eb
-md5sum=2974f892e2be5e2fa08296714e97c407
+hash=sha256:c79cc6e5d3304ae5761307c266835c4d8337cc0418ea43ace8c915b2d329427b
+md5sum=ec3fffbeff0be2699aeed1ed4377ee9d
 /branch
 dependencies
   dep package=libgcrypt/

[webkit-changes] [139609] trunk/Tools

[jocelyn . turcotte]

Title: [139609] trunk/Tools








Revision 139609
Author jocelyn.turco...@digia.com
Date 2013-01-14 05:01:20 -0800 (Mon, 14 Jan 2013)


Log Message
[Qt] The Qt's configuration isn't honoured regarding the use of the system libpng and libjpeg
https://bugs.webkit.org/show_bug.cgi?id=104909

Reviewed by Simon Hausmann.

To be able to build redistribuable binary packages, Qt's configure switches
-qt-libpng and -qt-libjpeg are used to avoid having the binaries trying to
dynamically link to optional system libraries.
QtWebKit is doing its own configure checks for those libraries, thus adding a
runtime dependency that might not be fulfilled if the packager's machine had
those libraries while the user's machine won't.

Since in most cases where WebKit will want to use those system libraries, Qt will
also be using them, remove these configure tests from WebKit.

* qmake/config.tests/libjpeg/libjpeg.cpp: Removed.
* qmake/config.tests/libjpeg/libjpeg.pro: Removed.
* qmake/config.tests/libpng/libpng.cpp: Removed.
* qmake/config.tests/libpng/libpng.pro: Removed.
* qmake/mkspecs/features/features.prf:

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/qmake/mkspecs/features/features.prf


Removed Paths

trunk/Tools/qmake/config.tests/libjpeg/libjpeg.cpp
trunk/Tools/qmake/config.tests/libjpeg/libjpeg.pro
trunk/Tools/qmake/config.tests/libpng/libpng.cpp
trunk/Tools/qmake/config.tests/libpng/libpng.pro




Diff

Modified: trunk/Tools/ChangeLog (139608 => 139609)

--- trunk/Tools/ChangeLog	2013-01-14 12:54:33 UTC (rev 139608)
+++ trunk/Tools/ChangeLog	2013-01-14 13:01:20 UTC (rev 139609)
@@ -1,3 +1,26 @@
+2013-01-14  Jocelyn Turcotte  jocelyn.turco...@digia.com
+
+[Qt] The Qt's configuration isn't honoured regarding the use of the system libpng and libjpeg
+https://bugs.webkit.org/show_bug.cgi?id=104909
+
+Reviewed by Simon Hausmann.
+
+To be able to build redistribuable binary packages, Qt's configure switches
+-qt-libpng and -qt-libjpeg are used to avoid having the binaries trying to
+dynamically link to optional system libraries.
+QtWebKit is doing its own configure checks for those libraries, thus adding a
+runtime dependency that might not be fulfilled if the packager's machine had
+those libraries while the user's machine won't.
+
+Since in most cases where WebKit will want to use those system libraries, Qt will
+also be using them, remove these configure tests from WebKit.
+
+* qmake/config.tests/libjpeg/libjpeg.cpp: Removed.
+* qmake/config.tests/libjpeg/libjpeg.pro: Removed.
+* qmake/config.tests/libpng/libpng.cpp: Removed.
+* qmake/config.tests/libpng/libpng.pro: Removed.
+* qmake/mkspecs/features/features.prf:
+
 2013-01-09  Raphael Kubo da Costa  raphael.kubo.da.co...@intel.com
 
 [EFL][jhbuild] Bump the EFL dependencies in jhbuild to 1.7.5.


Deleted: trunk/Tools/qmake/config.tests/libjpeg/libjpeg.cpp (139608 => 139609)

--- trunk/Tools/qmake/config.tests/libjpeg/libjpeg.cpp	2013-01-14 12:54:33 UTC (rev 139608)
+++ trunk/Tools/qmake/config.tests/libjpeg/libjpeg.cpp	2013-01-14 13:01:20 UTC (rev 139609)
@@ -1,35 +0,0 @@
-/*
- * Copyright (C) Zoltan Horvath (zol...@webkit.org) 2012 University of Szeged.
- *
- * Redistribution and use in source and binary forms, with or without
- * modification, are permitted provided that the following conditions
- * are met:
- * 1. Redistributions of source code must retain the above copyright
- *notice, this list of conditions and the following disclaimer.
- * 2. Redistributions in binary form must reproduce the above copyright
- *notice, this list of conditions and the following disclaimer in the
- *documentation and/or other materials provided with the distribution.
- *
- * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
- * AS IS AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
- * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
- * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
- * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
- * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
- * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
- * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
- * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
- * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
- * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
- */
-
-#include stdio.h
-#include jpeglib.h
-
-int main(int, char**)
-{
-struct jpeg_compress_struct cinfo;
-jpeg_create_compress(cinfo);
-
-return 0;
-}


Deleted: trunk/Tools/qmake/config.tests/libjpeg/libjpeg.pro (139608 => 139609)

--- trunk/Tools/qmake/config.tests/libjpeg/libjpeg.pro	2013-01-14 12:54:33 UTC (rev 139608)
+++ 

[webkit-changes] [139610] trunk/Source/WebCore

[haraken]

Title: [139610] trunk/Source/WebCore








Revision 139610
Author hara...@chromium.org
Date 2013-01-14 05:08:17 -0800 (Mon, 14 Jan 2013)


Log Message
[V8] Add m_isolate to ScriptController, WorkerScriptController and V8DOMWindowShell
https://bugs.webkit.org/show_bug.cgi?id=106771

Reviewed by Adam Barth.

This is one of the steps to pass an Isolate everywhere.

No tests. No change in behavior.

* bindings/v8/ScriptController.cpp:
(WebCore::ScriptController::ScriptController):
(WebCore::ScriptController::windowShell):
* bindings/v8/ScriptController.h:
(ScriptController):
* bindings/v8/V8DOMWindowShell.cpp:
(WebCore::V8DOMWindowShell::create):
(WebCore::V8DOMWindowShell::V8DOMWindowShell):
(WebCore::V8DOMWindowShell::initializeIfNeeded):
(WebCore::V8DOMWindowShell::installDOMWindow):
* bindings/v8/V8DOMWindowShell.h:
(V8DOMWindowShell):
* bindings/v8/V8Initializer.cpp:
(WebCore::V8Initializer::initializeMainThreadIfNeeded):
(WebCore::V8Initializer::initializeWorker):
* bindings/v8/V8Initializer.h:
(V8Initializer):
* bindings/v8/WorkerScriptController.cpp:
(WebCore::WorkerScriptController::WorkerScriptController):
(WebCore::WorkerScriptController::initializeContextIfNeeded):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/v8/ScriptController.cpp
trunk/Source/WebCore/bindings/v8/ScriptController.h
trunk/Source/WebCore/bindings/v8/V8DOMWindowShell.cpp
trunk/Source/WebCore/bindings/v8/V8DOMWindowShell.h
trunk/Source/WebCore/bindings/v8/V8Initializer.cpp
trunk/Source/WebCore/bindings/v8/V8Initializer.h
trunk/Source/WebCore/bindings/v8/WorkerScriptController.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (139609 => 139610)

--- trunk/Source/WebCore/ChangeLog	2013-01-14 13:01:20 UTC (rev 139609)
+++ trunk/Source/WebCore/ChangeLog	2013-01-14 13:08:17 UTC (rev 139610)
@@ -1,3 +1,35 @@
+2013-01-14  Kentaro Hara  hara...@chromium.org
+
+[V8] Add m_isolate to ScriptController, WorkerScriptController and V8DOMWindowShell
+https://bugs.webkit.org/show_bug.cgi?id=106771
+
+Reviewed by Adam Barth.
+
+This is one of the steps to pass an Isolate everywhere.
+
+No tests. No change in behavior.
+
+* bindings/v8/ScriptController.cpp:
+(WebCore::ScriptController::ScriptController):
+(WebCore::ScriptController::windowShell):
+* bindings/v8/ScriptController.h:
+(ScriptController):
+* bindings/v8/V8DOMWindowShell.cpp:
+(WebCore::V8DOMWindowShell::create):
+(WebCore::V8DOMWindowShell::V8DOMWindowShell):
+(WebCore::V8DOMWindowShell::initializeIfNeeded):
+(WebCore::V8DOMWindowShell::installDOMWindow):
+* bindings/v8/V8DOMWindowShell.h:
+(V8DOMWindowShell):
+* bindings/v8/V8Initializer.cpp:
+(WebCore::V8Initializer::initializeMainThreadIfNeeded):
+(WebCore::V8Initializer::initializeWorker):
+* bindings/v8/V8Initializer.h:
+(V8Initializer):
+* bindings/v8/WorkerScriptController.cpp:
+(WebCore::WorkerScriptController::WorkerScriptController):
+(WebCore::WorkerScriptController::initializeContextIfNeeded):
+
 2013-01-14  Alexander Pavlov  apav...@chromium.org
 
 Web Inspector: [Styles] Color names parsed inside background-image values


Modified: trunk/Source/WebCore/bindings/v8/ScriptController.cpp (139609 => 139610)

--- trunk/Source/WebCore/bindings/v8/ScriptController.cpp	2013-01-14 13:01:20 UTC (rev 139609)
+++ trunk/Source/WebCore/bindings/v8/ScriptController.cpp	2013-01-14 13:08:17 UTC (rev 139610)
@@ -102,7 +102,8 @@
 ScriptController::ScriptController(Frame* frame)
 : m_frame(frame)
 , m_sourceURL(0)
-, m_windowShell(V8DOMWindowShell::create(frame, mainThreadNormalWorld()))
+, m_isolate(v8::Isolate::GetCurrent())
+, m_windowShell(V8DOMWindowShell::create(frame, mainThreadNormalWorld(), m_isolate))
 , m_paused(false)
 #if ENABLE(NETSCAPE_PLUGIN_API)
 , m_wrappedWindowScriptNPObject(0)
@@ -357,7 +358,7 @@
 if (iter != m_isolatedWorlds.end())
 shell = iter-value.get();
 else {
-OwnPtrV8DOMWindowShell isolatedWorldShell = V8DOMWindowShell::create(m_frame, world);
+OwnPtrV8DOMWindowShell isolatedWorldShell = V8DOMWindowShell::create(m_frame, world, m_isolate);
 shell = isolatedWorldShell.get();
 m_isolatedWorlds.set(world-worldId(), isolatedWorldShell.release());
 }


Modified: trunk/Source/WebCore/bindings/v8/ScriptController.h (139609 => 139610)

--- trunk/Source/WebCore/bindings/v8/ScriptController.h	2013-01-14 13:01:20 UTC (rev 139609)
+++ trunk/Source/WebCore/bindings/v8/ScriptController.h	2013-01-14 13:08:17 UTC (rev 139610)
@@ -199,6 +199,7 @@
 
 Frame* m_frame;
 const String* m_sourceURL;
+v8::Isolate* m_isolate;
 
 OwnPtrV8DOMWindowShell m_windowShell;
 IsolatedWorldMap m_isolatedWorlds;


Modified: trunk/Source/WebCore/bindings/v8/V8DOMWindowShell.cpp 

[webkit-changes] [139612] trunk/Tools

[commit-queue]

Title: [139612] trunk/Tools








Revision 139612
Author commit-qu...@webkit.org
Date 2013-01-14 05:52:01 -0800 (Mon, 14 Jan 2013)


Log Message
[EFL][jhbuild] Build the GStreamer-related dependencies with the configure script
https://bugs.webkit.org/show_bug.cgi?id=106573

Patch by Raphael Kubo da Costa raphael.kubo.da.co...@intel.com on 2013-01-14
Reviewed by Philippe Normand.

Similarly to what's been described in bug 106569, we're building
from release tarballs, so there's no reason to regenerate the
autoconf-related stuff with autogen.sh, especially since we might
run into trouble with automake 1.13 and deprecated macros.

* efl/jhbuild.modules:

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/efl/jhbuild.modules




Diff

Modified: trunk/Tools/ChangeLog (139611 => 139612)

--- trunk/Tools/ChangeLog	2013-01-14 13:31:01 UTC (rev 139611)
+++ trunk/Tools/ChangeLog	2013-01-14 13:52:01 UTC (rev 139612)
@@ -1,3 +1,17 @@
+2013-01-14  Raphael Kubo da Costa  raphael.kubo.da.co...@intel.com
+
+[EFL][jhbuild] Build the GStreamer-related dependencies with the configure script
+https://bugs.webkit.org/show_bug.cgi?id=106573
+
+Reviewed by Philippe Normand.
+
+Similarly to what's been described in bug 106569, we're building
+from release tarballs, so there's no reason to regenerate the
+autoconf-related stuff with autogen.sh, especially since we might
+run into trouble with automake 1.13 and deprecated macros.
+
+* efl/jhbuild.modules:
+
 2013-01-14  Jocelyn Turcotte  jocelyn.turco...@digia.com
 
 [Qt] The Qt's configuration isn't honoured regarding the use of the system libpng and libjpeg


Modified: trunk/Tools/efl/jhbuild.modules (139611 => 139612)

--- trunk/Tools/efl/jhbuild.modules	2013-01-14 13:31:01 UTC (rev 139611)
+++ trunk/Tools/efl/jhbuild.modules	2013-01-14 13:52:01 UTC (rev 139612)
@@ -295,13 +295,15 @@
 md5sum=c62106f02ee00b6437f0fb9d370c1093/
   /autotools
 
-  autotools id=gstreamer
+  autotools id=gstreamer autogen-sh=configure
 branch repo=gstreamer
 module=gstreamer/gstreamer-1.0.5.tar.xz version=1.0.5
 hash=sha256:26c2827567f09a46d0a3bc1e7f8696b2ae72b047306539178079abae487c5b77/
   /autotools
 
-  autotools id=gst-plugins-base autogenargs=--disable-examples --enable-theora --enable-vorbis
+  autotools id=gst-plugins-base
+ autogen-sh=configure
+ autogenargs=--disable-examples --enable-theora --enable-vorbis
 dependencies
   dep package=gstreamer/
 /dependencies
@@ -310,7 +312,9 @@
 hash=sha256:37ce6e09b99ef3879111c861ee5090582b4fd4c764e81ab6eb2b2b4dd77d7173/
   /autotools
 
-  autotools id=gst-plugins-good autogenargs=--disable-examples --enable-pulse
+  autotools id=gst-plugins-good
+ autogen-sh=configure
+ autogenargs=--disable-examples --enable-pulse
 dependencies
   dep package=cairo/
   dep package=gst-plugins-base/
@@ -320,7 +324,9 @@
 hash=sha256:53bd0b848e7896f1b22548ca4e8be56cf425e5100e121c472dff8272d5140bc5/
   /autotools
 
-  autotools id=gst-plugins-bad autogenargs=--disable-examples --enable-faad
+  autotools id=gst-plugins-bad
+ autogen-sh=configure
+ autogenargs=--disable-examples --enable-faad
 dependencies
   dep package=gst-plugins-base/
 /dependencies
@@ -329,7 +335,9 @@
 hash=sha256:2e8f5b9a2fd274142d0a916b6425b9466028978b85858dc835dc80de744b276a/
   /autotools
 
-  autotools id=gst-libav autogenargs=--with-libav-extra-configure='--disable-yasm'
+  autotools id=gst-libav
+ autogen-sh=configure
+ autogenargs=--with-libav-extra-configure='--disable-yasm'
 dependencies
   dep package=gst-plugins-base/
 /dependencies






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [139613] trunk/Tools

[commit-queue]

Title: [139613] trunk/Tools








Revision 139613
Author commit-qu...@webkit.org
Date 2013-01-14 07:24:56 -0800 (Mon, 14 Jan 2013)


Log Message
Web Inspector: devtools front-end doesn't have focus in TestShell
https://bugs.webkit.org/show_bug.cgi?id=106778

Patch by Andrey Lushnikov lushni...@chromium.org on 2013-01-14
Reviewed by Pavel Feldman.

Focus devTools window after loadURL method.

* DumpRenderTree/chromium/TestShell.cpp:
(TestShell::runFileTest):

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/DumpRenderTree/chromium/TestShell.cpp




Diff

Modified: trunk/Tools/ChangeLog (139612 => 139613)

--- trunk/Tools/ChangeLog	2013-01-14 13:52:01 UTC (rev 139612)
+++ trunk/Tools/ChangeLog	2013-01-14 15:24:56 UTC (rev 139613)
@@ -1,3 +1,15 @@
+2013-01-14  Andrey Lushnikov  lushni...@chromium.org
+
+Web Inspector: devtools front-end doesn't have focus in TestShell
+https://bugs.webkit.org/show_bug.cgi?id=106778
+
+Reviewed by Pavel Feldman.
+
+Focus devTools window after loadURL method.
+
+* DumpRenderTree/chromium/TestShell.cpp:
+(TestShell::runFileTest):
+
 2013-01-14  Raphael Kubo da Costa  raphael.kubo.da.co...@intel.com
 
 [EFL][jhbuild] Build the GStreamer-related dependencies with the configure script


Modified: trunk/Tools/DumpRenderTree/chromium/TestShell.cpp (139612 => 139613)

--- trunk/Tools/DumpRenderTree/chromium/TestShell.cpp	2013-01-14 13:52:01 UTC (rev 139612)
+++ trunk/Tools/DumpRenderTree/chromium/TestShell.cpp	2013-01-14 15:24:56 UTC (rev 139613)
@@ -297,6 +297,9 @@
 m_printer.handleTestHeader(testUrl.c_str());
 loadURL(m_params.testUrl);
 
+if (m_devTools)
+this-setFocus(m_devTools-webView(), true);
+
 m_testIsPreparing = false;
 waitTestFinished();
 }






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [139614] trunk/Source/WebCore

[aandrey]

Title: [139614] trunk/Source/WebCore








Revision 139614
Author aand...@chromium.org
Date 2013-01-14 07:37:40 -0800 (Mon, 14 Jan 2013)


Log Message
Web Inspector: [Canvas] UI: add control buttons for doing the replay steps
https://bugs.webkit.org/show_bug.cgi?id=106788

Reviewed by Pavel Feldman.

Adding UI control buttons for doing the Canvas replay steps.
Drive-by: fixed a bug in DataGrid (found by the JSCompiler).

* inspector/front-end/CanvasProfileView.js:
(WebInspector.CanvasProfileView):
(WebInspector.CanvasProfileView.prototype._createControlButton):
(WebInspector.CanvasProfileView.prototype._onReplayStepClick):
(WebInspector.CanvasProfileView.prototype._onReplayFirstStepClick):
(WebInspector.CanvasProfileView.prototype._onReplayLastStepClick):
(WebInspector.CanvasProfileView.prototype._enableWaitIcon):
(WebInspector.CanvasProfileView.prototype._replayTraceLog.didReplayTraceLog):
(WebInspector.CanvasProfileView.prototype._replayTraceLog):
(WebInspector.CanvasProfileView.prototype._didReceiveTraceLog):
(WebInspector.CanvasProfileType.prototype._updateDecorationElement):
* inspector/front-end/DOMExtension.js:
(Element.prototype.enableStyleClass):
* inspector/front-end/DataGrid.js:
(WebInspector.DataGrid.prototype.setRootNode):
(WebInspector.DataGrid.prototype._startEditingColumnOfDataGridNode):
(WebInspector.DataGrid.prototype.moveToNextIfNeeded):
(WebInspector.DataGrid.prototype._editingCommitted):
(WebInspector.DataGridNode):
* inspector/front-end/canvasProfiler.css:
(.canvas-replay-image):
(.canvas-replay-image.wait):
(.canvas-replay-controls):
(.canvas-replay-log):
(.canvas-control-button):
(.canvas-control-button:active):
(.canvas-control-button:disabled):
(.canvas-control-button img):
(.canvas-replay-first-step img):
(.canvas-replay-next-step img):
(.canvas-replay-prev-step img):
(.canvas-replay-last-step img):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/English.lproj/localizedStrings.js
trunk/Source/WebCore/inspector/front-end/CanvasProfileView.js
trunk/Source/WebCore/inspector/front-end/DOMExtension.js
trunk/Source/WebCore/inspector/front-end/DataGrid.js
trunk/Source/WebCore/inspector/front-end/canvasProfiler.css




Diff

Modified: trunk/Source/WebCore/ChangeLog (139613 => 139614)

--- trunk/Source/WebCore/ChangeLog	2013-01-14 15:24:56 UTC (rev 139613)
+++ trunk/Source/WebCore/ChangeLog	2013-01-14 15:37:40 UTC (rev 139614)
@@ -1,3 +1,46 @@
+2013-01-14  Andrey Adaikin  aand...@chromium.org
+
+Web Inspector: [Canvas] UI: add control buttons for doing the replay steps
+https://bugs.webkit.org/show_bug.cgi?id=106788
+
+Reviewed by Pavel Feldman.
+
+Adding UI control buttons for doing the Canvas replay steps.
+Drive-by: fixed a bug in DataGrid (found by the JSCompiler).
+
+* inspector/front-end/CanvasProfileView.js:
+(WebInspector.CanvasProfileView):
+(WebInspector.CanvasProfileView.prototype._createControlButton):
+(WebInspector.CanvasProfileView.prototype._onReplayStepClick):
+(WebInspector.CanvasProfileView.prototype._onReplayFirstStepClick):
+(WebInspector.CanvasProfileView.prototype._onReplayLastStepClick):
+(WebInspector.CanvasProfileView.prototype._enableWaitIcon):
+(WebInspector.CanvasProfileView.prototype._replayTraceLog.didReplayTraceLog):
+(WebInspector.CanvasProfileView.prototype._replayTraceLog):
+(WebInspector.CanvasProfileView.prototype._didReceiveTraceLog):
+(WebInspector.CanvasProfileType.prototype._updateDecorationElement):
+* inspector/front-end/DOMExtension.js:
+(Element.prototype.enableStyleClass):
+* inspector/front-end/DataGrid.js:
+(WebInspector.DataGrid.prototype.setRootNode):
+(WebInspector.DataGrid.prototype._startEditingColumnOfDataGridNode):
+(WebInspector.DataGrid.prototype.moveToNextIfNeeded):
+(WebInspector.DataGrid.prototype._editingCommitted):
+(WebInspector.DataGridNode):
+* inspector/front-end/canvasProfiler.css:
+(.canvas-replay-image):
+(.canvas-replay-image.wait):
+(.canvas-replay-controls):
+(.canvas-replay-log):
+(.canvas-control-button):
+(.canvas-control-button:active):
+(.canvas-control-button:disabled):
+(.canvas-control-button img):
+(.canvas-replay-first-step img):
+(.canvas-replay-next-step img):
+(.canvas-replay-prev-step img):
+(.canvas-replay-last-step img):
+
 2013-01-14  Tommy Widenflycht  tom...@google.com
 
 MediaStream API: Update the track accessors on MediaStream to match the latest specification


Modified: trunk/Source/WebCore/English.lproj/localizedStrings.js (139613 => 139614)

--- trunk/Source/WebCore/English.lproj/localizedStrings.js	2013-01-14 15:24:56 UTC (rev 139613)
+++ trunk/Source/WebCore/English.lproj/localizedStrings.js	2013-01-14 15:37:40 UTC (rev 139614)
@@ -777,6 +777,10 @@
 

[webkit-changes] [139615] trunk/Source/WebCore

[eric . carlson]

Title: [139615] trunk/Source/WebCore








Revision 139615
Author eric.carl...@apple.com
Date 2013-01-14 08:33:45 -0800 (Mon, 14 Jan 2013)


Log Message
Do not pass nil when initializing legible output
https://bugs.webkit.org/show_bug.cgi?id=106799

Reviewed by Jessie Berlin.

* platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::tracksChanged): -[AVPlayerItemLegibleOutput initWithDependencyFactory:mediaSubtypesForNativeRepresentation:]
wants an empty NSArray rather than nil.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm




Diff

Modified: trunk/Source/WebCore/ChangeLog (139614 => 139615)

--- trunk/Source/WebCore/ChangeLog	2013-01-14 15:37:40 UTC (rev 139614)
+++ trunk/Source/WebCore/ChangeLog	2013-01-14 16:33:45 UTC (rev 139615)
@@ -1,3 +1,14 @@
+2013-01-14  Eric Carlson  eric.carl...@apple.com
+
+Do not pass nil when initializing legible output
+https://bugs.webkit.org/show_bug.cgi?id=106799
+
+Reviewed by Jessie Berlin.
+
+* platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
+(WebCore::MediaPlayerPrivateAVFoundationObjC::tracksChanged): -[AVPlayerItemLegibleOutput initWithDependencyFactory:mediaSubtypesForNativeRepresentation:]
+wants an empty NSArray rather than nil.
+
 2013-01-14  Andrey Adaikin  aand...@chromium.org
 
 Web Inspector: [Canvas] UI: add control buttons for doing the replay steps


Modified: trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm (139614 => 139615)

--- trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm	2013-01-14 15:37:40 UTC (rev 139614)
+++ trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm	2013-01-14 16:33:45 UTC (rev 139615)
@@ -888,7 +888,7 @@
 
 #if HAVE(AVFOUNDATION_TEXT_TRACK_SUPPORT)
 if (m_avPlayerItem  !m_legibleOutput) {
-m_legibleOutput = adoptNS([[AVPlayerItemLegibleOutput alloc] initWithMediaSubtypesForNativeRepresentation:nil]);
+m_legibleOutput = adoptNS([[AVPlayerItemLegibleOutput alloc] initWithMediaSubtypesForNativeRepresentation:[NSArray array]]);
 [m_legibleOutput.get() setSuppressesPlayerRendering:YES];
 
 // We enabled automatic media selection because we want alternate audio tracks to be enabled/disabled automatically,






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [139616] trunk

[vsevik]

Title: [139616] trunk








Revision 139616
Author vse...@chromium.org
Date 2013-01-14 08:46:58 -0800 (Mon, 14 Jan 2013)


Log Message
Web Inspector: Audit Tool's False Positive on Set-Cookie header
https://bugs.webkit.org/show_bug.cgi?id=106794

Reviewed by Pavel Feldman.

Source/WebCore:

Header value is now returned as undefined if there is no such header as it was before regression.

Test: http/tests/inspector/audits/set-cookie-header-audit-no-false-positive.html

* inspector/front-end/AuditRules.js:
(WebInspector.AuditRules.CSSRuleBase.prototype.sheetsCallback): Drive-by fix, callback should be called even when there is no headers.
* inspector/front-end/NetworkRequest.js:
(WebInspector.NetworkRequest.prototype._headerValue):

LayoutTests:

* http/tests/inspector/audits/resources/abe.png: Renamed from LayoutTests/inspector/audits/resources/abe.png.
* http/tests/inspector/audits/set-cookie-header-audit-no-false-positive-expected.txt: Added.
* http/tests/inspector/audits/set-cookie-header-audit-no-false-positive.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/AuditRules.js
trunk/Source/WebCore/inspector/front-end/NetworkRequest.js


Added Paths

trunk/LayoutTests/http/tests/inspector/audits/
trunk/LayoutTests/http/tests/inspector/audits/resources/
trunk/LayoutTests/http/tests/inspector/audits/resources/abe.png
trunk/LayoutTests/http/tests/inspector/audits/set-cookie-header-audit-no-false-positive-expected.txt
trunk/LayoutTests/http/tests/inspector/audits/set-cookie-header-audit-no-false-positive.html


Removed Paths

trunk/LayoutTests/inspector/audits/resources/abe.png




Diff

Modified: trunk/LayoutTests/ChangeLog (139615 => 139616)

--- trunk/LayoutTests/ChangeLog	2013-01-14 16:33:45 UTC (rev 139615)
+++ trunk/LayoutTests/ChangeLog	2013-01-14 16:46:58 UTC (rev 139616)
@@ -1,3 +1,14 @@
+2013-01-14  Vsevolod Vlasov  vse...@chromium.org
+
+Web Inspector: Audit Tool's False Positive on Set-Cookie header
+https://bugs.webkit.org/show_bug.cgi?id=106794
+
+Reviewed by Pavel Feldman.
+
+* http/tests/inspector/audits/resources/abe.png: Renamed from LayoutTests/inspector/audits/resources/abe.png.
+* http/tests/inspector/audits/set-cookie-header-audit-no-false-positive-expected.txt: Added.
+* http/tests/inspector/audits/set-cookie-header-audit-no-false-positive.html: Added.
+
 2013-01-14  Tommy Widenflycht  tom...@google.com
 
 MediaStream API: Update the track accessors on MediaStream to match the latest specification


Copied: trunk/LayoutTests/http/tests/inspector/audits/resources/abe.png (from rev 139615, trunk/LayoutTests/inspector/audits/resources/abe.png)

(Binary files differ)


Added: trunk/LayoutTests/http/tests/inspector/audits/set-cookie-header-audit-no-false-positive-expected.txt (0 => 139616)

--- trunk/LayoutTests/http/tests/inspector/audits/set-cookie-header-audit-no-false-positive-expected.txt	(rev 0)
+++ trunk/LayoutTests/http/tests/inspector/audits/set-cookie-header-audit-no-false-positive-expected.txt	2013-01-14 16:46:58 UTC (rev 139616)
@@ -0,0 +1,4 @@
+Tests there is no false positive Set-Cookie audit error. 
+Page reloaded.
+Success, no Set-Cookie headers found.
+


Added: trunk/LayoutTests/http/tests/inspector/audits/set-cookie-header-audit-no-false-positive.html (0 => 139616)

--- trunk/LayoutTests/http/tests/inspector/audits/set-cookie-header-audit-no-false-positive.html	(rev 0)
+++ trunk/LayoutTests/http/tests/inspector/audits/set-cookie-header-audit-no-false-positive.html	2013-01-14 16:46:58 UTC (rev 139616)
@@ -0,0 +1,25 @@
+html
+head
+script src=""
+script
+var test = function()
+{
+InspectorTest.reloadPage(step1);
+
+function step1()
+{
+WebInspector.showPanel(network);
+var requests = WebInspector.panels.network.requests;
+for (var i = 0; i  requests.length; ++i)
+InspectorTest.assertTrue(requests[i].responseHeaderValue(Set-Cookie) === undefined);
+InspectorTest.addResult(Success, no Set-Cookie headers found.);
+InspectorTest.completeTest();
+}
+}
+/script
+/head
+body _onload_=runTest()
+Tests there is no false positive Set-Cookie audit error.
+img src=""
+/body
+/html


Deleted: trunk/LayoutTests/inspector/audits/resources/abe.png

(Binary files differ)


Modified: trunk/Source/WebCore/ChangeLog (139615 => 139616)

--- trunk/Source/WebCore/ChangeLog	2013-01-14 16:33:45 UTC (rev 139615)
+++ trunk/Source/WebCore/ChangeLog	2013-01-14 16:46:58 UTC (rev 139616)
@@ -1,3 +1,19 @@
+2013-01-14  Vsevolod Vlasov  vse...@chromium.org
+
+Web Inspector: Audit Tool's False Positive on Set-Cookie header
+https://bugs.webkit.org/show_bug.cgi?id=106794
+
+Reviewed by Pavel Feldman.
+
+Header value is now returned as undefined if there is no such header as it was before regression.
+
+Test: 

[webkit-changes] [139617] trunk/LayoutTests

[commit-queue]

Title: [139617] trunk/LayoutTests








Revision 139617
Author commit-qu...@webkit.org
Date 2013-01-14 09:25:04 -0800 (Mon, 14 Jan 2013)


Log Message
Web Inspector: add text editor formatter test
https://bugs.webkit.org/show_bug.cgi?id=106705

Patch by Andrey Lushnikov lushni...@chromium.org on 2013-01-14
Reviewed by Pavel Feldman.

Adds a test checking text editor formatting.
The test creates a new text editor and fills it in with some
code by the means of simulated key and textInput events.

* inspector/editor/text-editor-formatter-expected.txt: Added.
* inspector/editor/text-editor-formatter.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/inspector/editor/editor-test.js
trunk/LayoutTests/platform/mac/TestExpectations


Added Paths

trunk/LayoutTests/inspector/editor/text-editor-formatter-expected.txt
trunk/LayoutTests/inspector/editor/text-editor-formatter.html




Diff

Modified: trunk/LayoutTests/ChangeLog (139616 => 139617)

--- trunk/LayoutTests/ChangeLog	2013-01-14 16:46:58 UTC (rev 139616)
+++ trunk/LayoutTests/ChangeLog	2013-01-14 17:25:04 UTC (rev 139617)
@@ -1,3 +1,17 @@
+2013-01-14  Andrey Lushnikov  lushni...@chromium.org
+
+Web Inspector: add text editor formatter test
+https://bugs.webkit.org/show_bug.cgi?id=106705
+
+Reviewed by Pavel Feldman.
+
+Adds a test checking text editor formatting.
+The test creates a new text editor and fills it in with some
+code by the means of simulated key and textInput events.
+
+* inspector/editor/text-editor-formatter-expected.txt: Added.
+* inspector/editor/text-editor-formatter.html: Added.
+
 2013-01-14  Vsevolod Vlasov  vse...@chromium.org
 
 Web Inspector: Audit Tool's False Positive on Set-Cookie header


Modified: trunk/LayoutTests/inspector/editor/editor-test.js (139616 => 139617)

--- trunk/LayoutTests/inspector/editor/editor-test.js	2013-01-14 16:46:58 UTC (rev 139616)
+++ trunk/LayoutTests/inspector/editor/editor-test.js	2013-01-14 17:25:04 UTC (rev 139617)
@@ -19,6 +19,21 @@
 textModel.setText(lines.join(\n));
 }
 
+InspectorTest.insertTextLine = function(line)
+{
+function enter()
+{
+eventSender.keyDown(\n);
+}
+
+function innerInsertTextLine()
+{
+textInputController.insertText(line);
+}
+setTimeout(innerInsertTextLine);
+setTimeout(enter);
+}
+
 InspectorTest.dumpEditorChunks = function(textEditor)
 {
 InspectorTest.addResult(Chunk model);


Added: trunk/LayoutTests/inspector/editor/text-editor-formatter-expected.txt (0 => 139617)

--- trunk/LayoutTests/inspector/editor/text-editor-formatter-expected.txt	(rev 0)
+++ trunk/LayoutTests/inspector/editor/text-editor-formatter-expected.txt	2013-01-14 17:25:04 UTC (rev 139617)
@@ -0,0 +1,54 @@
+This test checks text editor _javascript_ formatting.
+
+/**
+ * Multi-line comment
+ *
+ */
+function foo(n) {
+// one-line comment
+function bar() {
+return 42;
+}
+
+var sum = 0;
+for(var i = 0; i  n; ++i) {
+for(var j = 0; j  n; ++j) {
+sum += i + j;
+}
+}
+
+
+if (sum  1000) {
+while (sum  0) {
+--sum;
+}
+}
+}
+ editor contents start 
+/**
+*.Multi-line.comment
+*
+*/
+function.foo(n).{
+//.one-line.comment
+function.bar().{
+return.42;
+}
+
+var.sum.=.0;
+for(var.i.=.0;.i..n;.++i).{
+for(var.j.=.0;.j..n;.++j).{
+sum.+=.i.+.j;
+}
+}
+
+
+if.(sum..1000).{
+while.(sum..0).{
+--sum;
+}
+}
+}
+
+ editor contents end 
+


Added: trunk/LayoutTests/inspector/editor/text-editor-formatter.html (0 => 139617)

--- trunk/LayoutTests/inspector/editor/text-editor-formatter.html	(rev 0)
+++ trunk/LayoutTests/inspector/editor/text-editor-formatter.html	2013-01-14 17:25:04 UTC (rev 139617)
@@ -0,0 +1,73 @@
+html
+head
+script src=""
+script src=""
+script
+function codeSnippet() {
+return document.getElementById(codeSnippet).textContent;
+}
+
+function test()
+{
+var textEditor = InspectorTest.createTestEditor();
+textEditor.overrideViewportForTest(0, undefined, 3);
+textEditor.mimeType = text/_javascript_;
+textEditor.setReadOnly(false);
+textEditor.element.focus();
+
+function step2(result)
+{
+var codeLines = result.value.split(\n);
+for(var i = 0; i  codeLines.length; ++i)
+InspectorTest.insertTextLine(codeLines[i].trim());
+
+setTimeout(step3);
+}
+
+function step3()
+{
+InspectorTest.addResult( editor contents start );
+InspectorTest.addResult(textEditor.text().replace(/ /g, .));
+InspectorTest.addResult( editor contents end );
+InspectorTest.completeTest();
+}
+
+

[webkit-changes] [139618] trunk

[tommyw]

Title: [139618] trunk








Revision 139618
Author tom...@google.com
Date 2013-01-14 09:28:55 -0800 (Mon, 14 Jan 2013)


Log Message
MediaStream API: Update MediaStreamTrack::readyState to match specification
https://bugs.webkit.org/show_bug.cgi?id=106781

Reviewed by Adam Barth.

Source/WebCore:

MediaStreamTrack::readyState now returns a string like the rest of the RTC classes.

Existing tests expanded to cover patch.

* Modules/mediastream/MediaStream.cpp:
(WebCore::processTrack):
* Modules/mediastream/MediaStreamTrack.cpp:
(WebCore::MediaStreamTrack::readyState):
(WebCore::MediaStreamTrack::ended):
(WebCore):
* Modules/mediastream/MediaStreamTrack.h:
(MediaStreamTrack):
* Modules/mediastream/MediaStreamTrack.idl:

LayoutTests:

* fast/mediastream/MediaStreamTrack-expected.txt:
* fast/mediastream/MediaStreamTrack.html:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/mediastream/MediaStreamTrack-expected.txt
trunk/LayoutTests/fast/mediastream/MediaStreamTrack.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/mediastream/MediaStream.cpp
trunk/Source/WebCore/Modules/mediastream/MediaStreamTrack.cpp
trunk/Source/WebCore/Modules/mediastream/MediaStreamTrack.h
trunk/Source/WebCore/Modules/mediastream/MediaStreamTrack.idl




Diff

Modified: trunk/LayoutTests/ChangeLog (139617 => 139618)

--- trunk/LayoutTests/ChangeLog	2013-01-14 17:25:04 UTC (rev 139617)
+++ trunk/LayoutTests/ChangeLog	2013-01-14 17:28:55 UTC (rev 139618)
@@ -1,3 +1,13 @@
+2013-01-14  Tommy Widenflycht  tom...@google.com
+
+MediaStream API: Update MediaStreamTrack::readyState to match specification
+https://bugs.webkit.org/show_bug.cgi?id=106781
+
+Reviewed by Adam Barth.
+
+* fast/mediastream/MediaStreamTrack-expected.txt:
+* fast/mediastream/MediaStreamTrack.html:
+
 2013-01-14  Andrey Lushnikov  lushni...@chromium.org
 
 Web Inspector: add text editor formatter test


Modified: trunk/LayoutTests/fast/mediastream/MediaStreamTrack-expected.txt (139617 => 139618)

--- trunk/LayoutTests/fast/mediastream/MediaStreamTrack-expected.txt	2013-01-14 17:25:04 UTC (rev 139617)
+++ trunk/LayoutTests/fast/mediastream/MediaStreamTrack-expected.txt	2013-01-14 17:28:55 UTC (rev 139618)
@@ -4,9 +4,13 @@
 
 
 PASS getUserMedia succeeded.
+PASS track.readyState is live
 PASS Track onmute callback succeeded.
+PASS track.readyState is muted
 PASS Track onunmute callback succeeded.
+PASS track.readyState is live
 PASS Track onended callback succeeded.
+PASS track.readyState is ended
 PASS successfullyParsed is true
 
 TEST COMPLETE


Modified: trunk/LayoutTests/fast/mediastream/MediaStreamTrack.html (139617 => 139618)

--- trunk/LayoutTests/fast/mediastream/MediaStreamTrack.html	2013-01-14 17:25:04 UTC (rev 139617)
+++ trunk/LayoutTests/fast/mediastream/MediaStreamTrack.html	2013-01-14 17:28:55 UTC (rev 139618)
@@ -34,18 +34,24 @@
 function onTrackEnded() {
 testPassed('Track onended callback succeeded.');
 
+shouldBeEqualToString('track.readyState', 'ended');
+
 finishJSTest();
 }
 
 function onTrackUnmute() {
 testPassed('Track onunmute callback succeeded.');
 
+shouldBeEqualToString('track.readyState', 'live');
+
 stream.stop();
 }
 
 function onTrackMute() {
 testPassed('Track onmute callback succeeded.');
 
+shouldBeEqualToString('track.readyState', 'muted');
+
 track.enabled = true;
 }
 
@@ -55,6 +61,8 @@
 stream = s;
 track = stream.getVideoTracks()[0];
 
+shouldBeEqualToString('track.readyState', 'live');
+
 track._onunmute_ = onTrackUnmute;
 track._onmute_ = onTrackMute;
 track._onended_ = onTrackEnded;


Modified: trunk/Source/WebCore/ChangeLog (139617 => 139618)

--- trunk/Source/WebCore/ChangeLog	2013-01-14 17:25:04 UTC (rev 139617)
+++ trunk/Source/WebCore/ChangeLog	2013-01-14 17:28:55 UTC (rev 139618)
@@ -1,3 +1,24 @@
+2013-01-14  Tommy Widenflycht  tom...@google.com
+
+MediaStream API: Update MediaStreamTrack::readyState to match specification
+https://bugs.webkit.org/show_bug.cgi?id=106781
+
+Reviewed by Adam Barth.
+
+MediaStreamTrack::readyState now returns a string like the rest of the RTC classes.
+
+Existing tests expanded to cover patch.
+
+* Modules/mediastream/MediaStream.cpp:
+(WebCore::processTrack):
+* Modules/mediastream/MediaStreamTrack.cpp:
+(WebCore::MediaStreamTrack::readyState):
+(WebCore::MediaStreamTrack::ended):
+(WebCore):
+* Modules/mediastream/MediaStreamTrack.h:
+(MediaStreamTrack):
+* Modules/mediastream/MediaStreamTrack.idl:
+
 2013-01-14  Vsevolod Vlasov  vse...@chromium.org
 
 Web Inspector: Audit Tool's False Positive on Set-Cookie header


Modified: trunk/Source/WebCore/Modules/mediastream/MediaStream.cpp (139617 => 139618)

--- trunk/Source/WebCore/Modules/mediastream/MediaStream.cpp	2013-01-14 17:25:04 UTC (rev 139617)
+++ 

[webkit-changes] [139619] trunk/Source/WebCore

[haraken]

Title: [139619] trunk/Source/WebCore








Revision 139619
Author hara...@chromium.org
Date 2013-01-14 09:30:59 -0800 (Mon, 14 Jan 2013)


Log Message
[V8] Make an Isolate parameter mandatory in wrap()
https://bugs.webkit.org/show_bug.cgi?id=106783

Reviewed by Adam Barth.

Now it's safe to make an Isolate parameter in wrap().

No tests. No change in behavior.

* bindings/scripts/CodeGeneratorV8.pm:
(GenerateHeader):
* bindings/scripts/test/V8/V8Float64Array.h:
(WebCore):
* bindings/scripts/test/V8/V8TestActiveDOMObject.h:
(WebCore::wrap):
* bindings/scripts/test/V8/V8TestCustomNamedGetter.h:
(WebCore::wrap):
* bindings/scripts/test/V8/V8TestEventConstructor.h:
(WebCore::wrap):
* bindings/scripts/test/V8/V8TestEventTarget.h:
(WebCore::wrap):
* bindings/scripts/test/V8/V8TestException.h:
(WebCore::wrap):
* bindings/scripts/test/V8/V8TestInterface.h:
(WebCore::wrap):
* bindings/scripts/test/V8/V8TestMediaQueryListListener.h:
(WebCore::wrap):
* bindings/scripts/test/V8/V8TestNamedConstructor.h:
(WebCore::wrap):
* bindings/scripts/test/V8/V8TestNode.h:
(WebCore::wrap):
* bindings/scripts/test/V8/V8TestObj.h:
(WebCore::wrap):
* bindings/scripts/test/V8/V8TestOverloadedConstructors.h:
(WebCore::wrap):
* bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.h:
(WebCore::wrap):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm
trunk/Source/WebCore/bindings/scripts/test/V8/V8Float64Array.h
trunk/Source/WebCore/bindings/scripts/test/V8/V8TestActiveDOMObject.h
trunk/Source/WebCore/bindings/scripts/test/V8/V8TestCustomNamedGetter.h
trunk/Source/WebCore/bindings/scripts/test/V8/V8TestEventConstructor.h
trunk/Source/WebCore/bindings/scripts/test/V8/V8TestEventTarget.h
trunk/Source/WebCore/bindings/scripts/test/V8/V8TestException.h
trunk/Source/WebCore/bindings/scripts/test/V8/V8TestInterface.h
trunk/Source/WebCore/bindings/scripts/test/V8/V8TestMediaQueryListListener.h
trunk/Source/WebCore/bindings/scripts/test/V8/V8TestNamedConstructor.h
trunk/Source/WebCore/bindings/scripts/test/V8/V8TestNode.h
trunk/Source/WebCore/bindings/scripts/test/V8/V8TestObj.h
trunk/Source/WebCore/bindings/scripts/test/V8/V8TestOverloadedConstructors.h
trunk/Source/WebCore/bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (139618 => 139619)

--- trunk/Source/WebCore/ChangeLog	2013-01-14 17:28:55 UTC (rev 139618)
+++ trunk/Source/WebCore/ChangeLog	2013-01-14 17:30:59 UTC (rev 139619)
@@ -1,3 +1,43 @@
+2013-01-14  Kentaro Hara  hara...@chromium.org
+
+[V8] Make an Isolate parameter mandatory in wrap()
+https://bugs.webkit.org/show_bug.cgi?id=106783
+
+Reviewed by Adam Barth.
+
+Now it's safe to make an Isolate parameter in wrap().
+
+No tests. No change in behavior.
+
+* bindings/scripts/CodeGeneratorV8.pm:
+(GenerateHeader):
+* bindings/scripts/test/V8/V8Float64Array.h:
+(WebCore):
+* bindings/scripts/test/V8/V8TestActiveDOMObject.h:
+(WebCore::wrap):
+* bindings/scripts/test/V8/V8TestCustomNamedGetter.h:
+(WebCore::wrap):
+* bindings/scripts/test/V8/V8TestEventConstructor.h:
+(WebCore::wrap):
+* bindings/scripts/test/V8/V8TestEventTarget.h:
+(WebCore::wrap):
+* bindings/scripts/test/V8/V8TestException.h:
+(WebCore::wrap):
+* bindings/scripts/test/V8/V8TestInterface.h:
+(WebCore::wrap):
+* bindings/scripts/test/V8/V8TestMediaQueryListListener.h:
+(WebCore::wrap):
+* bindings/scripts/test/V8/V8TestNamedConstructor.h:
+(WebCore::wrap):
+* bindings/scripts/test/V8/V8TestNode.h:
+(WebCore::wrap):
+* bindings/scripts/test/V8/V8TestObj.h:
+(WebCore::wrap):
+* bindings/scripts/test/V8/V8TestOverloadedConstructors.h:
+(WebCore::wrap):
+* bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.h:
+(WebCore::wrap):
+
 2013-01-14  Tommy Widenflycht  tom...@google.com
 
 MediaStream API: Update MediaStreamTrack::readyState to match specification


Modified: trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm (139618 => 139619)

--- trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm	2013-01-14 17:28:55 UTC (rev 139618)
+++ trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm	2013-01-14 17:30:59 UTC (rev 139619)
@@ -545,12 +545,12 @@
 if ($customWrap) {
 push(@headerContent, END);
 
-v8::Handlev8::Object wrap(${nativeType}* impl, v8::Handlev8::Object creationContext, v8::Isolate* = 0);
+v8::Handlev8::Object wrap(${nativeType}* impl, v8::Handlev8::Object creationContext, v8::Isolate*);
 END
 } else {
 push(@headerContent, END);
 
-inline v8::Handlev8::Object wrap(${nativeType}* impl, v8::Handlev8::Object creationContext, v8::Isolate* isolate = 0)
+inline v8::Handlev8::Object wrap(${nativeType}* impl, 

[webkit-changes] [139620] branches/chromium/1364

[leviw]

Title: [139620] branches/chromium/1364








Revision 139620
Author le...@chromium.org
Date 2013-01-14 09:40:35 -0800 (Mon, 14 Jan 2013)


Log Message
Merge 139479
 RenderGeometryMap and TransformState disagree with sub-pixel layout and translations
 https://bugs.webkit.org/show_bug.cgi?id=106047
 
 Reviewed by Simon Fraser.
 
 Source/WebCore:
 
 Mirror RenderGeometryMap's optimization for integer-translated transforms in TransformState.
 This avoids the current behavior where the two can disagree on mappings, since RenderGeometryMap
 pixel-snapped later when a translation occurred between two sub-pixel containers.
 
 Test: fast/layers/geometry-map-transform-state-translation-mismatch.html
 
 * platform/graphics/transforms/TransformState.h:
 (WebCore::TransformState::setQuad): Clear accumulatedOffset when setting a new quad. Note: this
 implementation only works properly when only tracking a quad.
 * platform/graphics/transforms/TransformState.cpp:
 (WebCore::TransformState::applyTransform): apply integral translations to the accumulatedOffset
 for performance and consistency with RenderGeometryMap.
 
 LayoutTests:
 
 * fast/layers/geometry-map-transform-state-translation-mismatch-expected.txt: Added.
 * fast/layers/geometry-map-transform-state-translation-mismatch.html: Added.
 

TBR=le...@chromium.org
Review URL: https://codereview.chromium.org/11880024

Modified Paths

branches/chromium/1364/Source/WebCore/platform/graphics/transforms/TransformState.cpp
branches/chromium/1364/Source/WebCore/platform/graphics/transforms/TransformState.h


Added Paths

branches/chromium/1364/LayoutTests/fast/layers/geometry-map-transform-state-translation-mismatch-expected.txt
branches/chromium/1364/LayoutTests/fast/layers/geometry-map-transform-state-translation-mismatch.html




Diff

Copied: branches/chromium/1364/LayoutTests/fast/layers/geometry-map-transform-state-translation-mismatch-expected.txt (from rev 139479, trunk/LayoutTests/fast/layers/geometry-map-transform-state-translation-mismatch-expected.txt) (0 => 139620)

--- branches/chromium/1364/LayoutTests/fast/layers/geometry-map-transform-state-translation-mismatch-expected.txt	(rev 0)
+++ branches/chromium/1364/LayoutTests/fast/layers/geometry-map-transform-state-translation-mismatch-expected.txt	2013-01-14 17:40:35 UTC (rev 139620)
@@ -0,0 +1,2 @@
+This tests that RenderGeometryMap and TransformState both avoid pixel snapping prior to applying translation-only transforms. The test passes if it doesn't assert on Debug.
+


Copied: branches/chromium/1364/LayoutTests/fast/layers/geometry-map-transform-state-translation-mismatch.html (from rev 139479, trunk/LayoutTests/fast/layers/geometry-map-transform-state-translation-mismatch.html) (0 => 139620)

--- branches/chromium/1364/LayoutTests/fast/layers/geometry-map-transform-state-translation-mismatch.html	(rev 0)
+++ branches/chromium/1364/LayoutTests/fast/layers/geometry-map-transform-state-translation-mismatch.html	2013-01-14 17:40:35 UTC (rev 139620)
@@ -0,0 +1,33 @@
+!DOCTYPE html
+html
+style
+.wrapper {
+  width: 200px;
+  margin-left: 101.7px;
+}
+
+.content {
+  background: rgba(255, 0, 0, 0.2);
+  -webkit-transform: translateZ(0);
+  width: 100px;
+}
+
+.inner {
+  background: rgba(0, 0, 255, 0.2);
+  position: relative;
+  left: -6.25px;   
+}
+/style
+script
+if (window.testRunner)
+	testRunner.dumpAsText();
+/script
+body
+div id=descriptionThis tests that RenderGeometryMap and TransformState both avoid pixel snapping prior to applying translation-only transforms.
+The test passes if it doesn't assert on Debug./div
+div class=wrapper
+div class=content
+div class=inner/div
+/div
+/div
+/body


Modified: branches/chromium/1364/Source/WebCore/platform/graphics/transforms/TransformState.cpp (139619 => 139620)

--- branches/chromium/1364/Source/WebCore/platform/graphics/transforms/TransformState.cpp	2013-01-14 17:30:59 UTC (rev 139619)
+++ branches/chromium/1364/Source/WebCore/platform/graphics/transforms/TransformState.cpp	2013-01-14 17:40:35 UTC (rev 139620)
@@ -111,6 +111,11 @@
 if (wasClamped)
 *wasClamped = false;
 
+if (transformFromContainer.isIntegerTranslation()) {
+move(LayoutSize(transformFromContainer.e(), transformFromContainer.f()), accumulate);
+return;
+}
+
 applyAccumulatedOffset();
 
 // If we have an accumulated transform from last time, multiply in this transform


Modified: branches/chromium/1364/Source/WebCore/platform/graphics/transforms/TransformState.h (139619 => 139620)

--- branches/chromium/1364/Source/WebCore/platform/graphics/transforms/TransformState.h	2013-01-14 17:30:59 UTC (rev 139619)
+++ branches/chromium/1364/Source/WebCore/platform/graphics/transforms/TransformState.h	2013-01-14 17:40:35 UTC (rev 139620)
@@ -73,7 +73,14 @@
 
 TransformState operator=(const TransformState);
 
-void setQuad(const FloatQuad quad) { m_lastPlanarQuad = quad; }
+void 

[webkit-changes] [139621] trunk/Source

[haraken]

Title: [139621] trunk/Source








Revision 139621
Author hara...@chromium.org
Date 2013-01-14 09:40:59 -0800 (Mon, 14 Jan 2013)


Log Message
[V8] Make an Isolate parameter mandatory in ScriptDebugServer::interruptAndRun()
https://bugs.webkit.org/show_bug.cgi?id=106779

Reviewed by Adam Barth.

This is one of steps to make an Isolate parameter mandatory.

No tests. No change in behavior.

Source/WebCore:

* bindings/v8/ScriptDebugServer.h:
(ScriptDebugServer):

Source/WebKit/chromium:

* src/WebDevToolsAgentImpl.cpp:
(WebKit::WebDevToolsAgent::interruptAndDispatch):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/v8/ScriptDebugServer.h
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/src/WebDevToolsAgentImpl.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (139620 => 139621)

--- trunk/Source/WebCore/ChangeLog	2013-01-14 17:40:35 UTC (rev 139620)
+++ trunk/Source/WebCore/ChangeLog	2013-01-14 17:40:59 UTC (rev 139621)
@@ -1,5 +1,19 @@
 2013-01-14  Kentaro Hara  hara...@chromium.org
 
+[V8] Make an Isolate parameter mandatory in ScriptDebugServer::interruptAndRun()
+https://bugs.webkit.org/show_bug.cgi?id=106779
+
+Reviewed by Adam Barth.
+
+This is one of steps to make an Isolate parameter mandatory.
+
+No tests. No change in behavior.
+
+* bindings/v8/ScriptDebugServer.h:
+(ScriptDebugServer):
+
+2013-01-14  Kentaro Hara  hara...@chromium.org
+
 [V8] Make an Isolate parameter mandatory in wrap()
 https://bugs.webkit.org/show_bug.cgi?id=106783
 


Modified: trunk/Source/WebCore/bindings/v8/ScriptDebugServer.h (139620 => 139621)

--- trunk/Source/WebCore/bindings/v8/ScriptDebugServer.h	2013-01-14 17:40:35 UTC (rev 139620)
+++ trunk/Source/WebCore/bindings/v8/ScriptDebugServer.h	2013-01-14 17:40:59 UTC (rev 139621)
@@ -93,7 +93,7 @@
 virtual ~Task() { }
 virtual void run() = 0;
 };
-static void interruptAndRun(PassOwnPtrTask, v8::Isolate* = 0);
+static void interruptAndRun(PassOwnPtrTask, v8::Isolate*);
 void runPendingTasks();
 
 bool isPaused();


Modified: trunk/Source/WebKit/chromium/ChangeLog (139620 => 139621)

--- trunk/Source/WebKit/chromium/ChangeLog	2013-01-14 17:40:35 UTC (rev 139620)
+++ trunk/Source/WebKit/chromium/ChangeLog	2013-01-14 17:40:59 UTC (rev 139621)
@@ -1,3 +1,17 @@
+2013-01-14  Kentaro Hara  hara...@chromium.org
+
+[V8] Make an Isolate parameter mandatory in ScriptDebugServer::interruptAndRun()
+https://bugs.webkit.org/show_bug.cgi?id=106779
+
+Reviewed by Adam Barth.
+
+This is one of steps to make an Isolate parameter mandatory.
+
+No tests. No change in behavior.
+
+* src/WebDevToolsAgentImpl.cpp:
+(WebKit::WebDevToolsAgent::interruptAndDispatch):
+
 2013-01-13  Vsevolod Vlasov  vse...@chromium.org
 
 Web Inspector: [Chromium] DevToolsSanityTest.TestNoScriptDuplicatesOnPanelSwitch fails


Modified: trunk/Source/WebKit/chromium/src/WebDevToolsAgentImpl.cpp (139620 => 139621)

--- trunk/Source/WebKit/chromium/src/WebDevToolsAgentImpl.cpp	2013-01-14 17:40:35 UTC (rev 139620)
+++ trunk/Source/WebKit/chromium/src/WebDevToolsAgentImpl.cpp	2013-01-14 17:40:59 UTC (rev 139621)
@@ -733,7 +733,7 @@
 // rawDescriptor can't be a PassOwnPtr because interruptAndDispatch is a WebKit API function.
 OwnPtrMessageDescriptor descriptor = adoptPtr(rawDescriptor);
 OwnPtrDebuggerTask task = adoptPtr(new DebuggerTask(descriptor.release()));
-PageScriptDebugServer::interruptAndRun(task.release());
+PageScriptDebugServer::interruptAndRun(task.release(), v8::Isolate::GetCurrent());
 }
 
 bool WebDevToolsAgent::shouldInterruptForMessage(const WebString message)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [139622] trunk/Source/WebCore

[haraken]

Title: [139622] trunk/Source/WebCore








Revision 139622
Author hara...@chromium.org
Date 2013-01-14 09:43:53 -0800 (Mon, 14 Jan 2013)


Log Message
[V8] Make an Isolate parameter mandatory in associateObjectWithWrapper()
https://bugs.webkit.org/show_bug.cgi?id=106784

Reviewed by Adam Barth.

No tests. No change in behavior.

* bindings/v8/V8DOMWrapper.h:
(V8DOMWrapper):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/v8/V8DOMWrapper.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (139621 => 139622)

--- trunk/Source/WebCore/ChangeLog	2013-01-14 17:40:59 UTC (rev 139621)
+++ trunk/Source/WebCore/ChangeLog	2013-01-14 17:43:53 UTC (rev 139622)
@@ -1,5 +1,17 @@
 2013-01-14  Kentaro Hara  hara...@chromium.org
 
+[V8] Make an Isolate parameter mandatory in associateObjectWithWrapper()
+https://bugs.webkit.org/show_bug.cgi?id=106784
+
+Reviewed by Adam Barth.
+
+No tests. No change in behavior.
+
+* bindings/v8/V8DOMWrapper.h:
+(V8DOMWrapper):
+
+2013-01-14  Kentaro Hara  hara...@chromium.org
+
 [V8] Make an Isolate parameter mandatory in ScriptDebugServer::interruptAndRun()
 https://bugs.webkit.org/show_bug.cgi?id=106779
 


Modified: trunk/Source/WebCore/bindings/v8/V8DOMWrapper.h (139621 => 139622)

--- trunk/Source/WebCore/bindings/v8/V8DOMWrapper.h	2013-01-14 17:40:59 UTC (rev 139621)
+++ trunk/Source/WebCore/bindings/v8/V8DOMWrapper.h	2013-01-14 17:43:53 UTC (rev 139622)
@@ -61,7 +61,7 @@
 static v8::Localv8::Object createWrapper(v8::Handlev8::Object creationContext, WrapperTypeInfo*, void*);
 
 templatetypename T
-static inline v8::Persistentv8::Object associateObjectWithWrapper(PassRefPtrT, WrapperTypeInfo*, v8::Handlev8::Object, v8::Isolate* = 0);
+static inline v8::Persistentv8::Object associateObjectWithWrapper(PassRefPtrT, WrapperTypeInfo*, v8::Handlev8::Object, v8::Isolate*);
 static inline void setNativeInfo(v8::Handlev8::Object, WrapperTypeInfo*, void*);
 static inline void clearNativeInfo(v8::Handlev8::Object, WrapperTypeInfo*);
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [139623] trunk

[schenney]

Title: [139623] trunk








Revision 139623
Author schen...@chromium.org
Date 2013-01-14 10:08:27 -0800 (Mon, 14 Jan 2013)


Log Message
Re-enabling the SK_DISABLE_DASHING_OPTIMIZATION flag for Skia

Source/WebKit/chromium: 

Unreviewed build fix.

It turns out that the change behind this flag causes crashes and image errors.

* skia_webkit.gyp:

LayoutTests: 

Unreviewed expectations clean-up.

Removing the expectations associated with the flag.

* platform/chromium/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/TestExpectations
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/skia_webkit.gyp




Diff

Modified: trunk/LayoutTests/ChangeLog (139622 => 139623)

--- trunk/LayoutTests/ChangeLog	2013-01-14 17:43:53 UTC (rev 139622)
+++ trunk/LayoutTests/ChangeLog	2013-01-14 18:08:27 UTC (rev 139623)
@@ -1,3 +1,13 @@
+2013-01-14  Stephen Chenney  schen...@chromium.org
+
+Re-enabling the SK_DISABLE_DASHING_OPTIMIZATION flag for Skia
+
+Unreviewed expectations clean-up.
+
+Removing the expectations associated with the flag.
+
+* platform/chromium/TestExpectations:
+
 2013-01-14  Tommy Widenflycht  tom...@google.com
 
 MediaStream API: Update MediaStreamTrack::readyState to match specification


Modified: trunk/LayoutTests/platform/chromium/TestExpectations (139622 => 139623)

--- trunk/LayoutTests/platform/chromium/TestExpectations	2013-01-14 17:43:53 UTC (rev 139622)
+++ trunk/LayoutTests/platform/chromium/TestExpectations	2013-01-14 18:08:27 UTC (rev 139623)
@@ -4267,14 +4267,8 @@
 crbug.com/166932 [ Debug ] plugins/embed-attributes-setting.html [ Crash Pass ]
 
 # Broken by Skia flag changes in r139445
-crbug.com/169550 [ Debug ] fast/borders/border-mixed-alpha.html [ Crash ]
-crbug.com/169550 [ Debug ] fast/borders/outline-alpha-block.html [ Crash ]
-crbug.com/169550 [ Debug ] fast/borders/outline-alpha-inline.html [ Crash ]
 crbug.com/169550 [ Debug ] fast/lists/big-list-marker.html [ Crash ]
 crbug.com/169550 [ Debug ] platform/chromium/virtual/deferred/fast/images/icon-decoding.html [ Crash ]
-crbug.com/169550 [ Release ] fast/borders/border-mixed-alpha.html [ ImageOnlyFailure ]
-crbug.com/169550 [ Release ] fast/borders/outline-alpha-block.html [ ImageOnlyFailure ]
-crbug.com/169550 [ Release ] fast/borders/outline-alpha-inline.html [ ImageOnlyFailure ]
 
 # Transient. Needs rebaseline.
 webkit.org/b/103955 fast/repaint/caret-outside-block.html [ ImageOnlyFailure ]


Modified: trunk/Source/WebKit/chromium/ChangeLog (139622 => 139623)

--- trunk/Source/WebKit/chromium/ChangeLog	2013-01-14 17:43:53 UTC (rev 139622)
+++ trunk/Source/WebKit/chromium/ChangeLog	2013-01-14 18:08:27 UTC (rev 139623)
@@ -1,3 +1,13 @@
+2013-01-14  Stephen Chenney  schen...@chromium.org
+
+Re-enabling the SK_DISABLE_DASHING_OPTIMIZATION flag for Skia
+
+Unreviewed build fix.
+
+It turns out that the change behind this flag causes crashes and image errors.
+
+* skia_webkit.gyp:
+
 2013-01-14  Kentaro Hara  hara...@chromium.org
 
 [V8] Make an Isolate parameter mandatory in ScriptDebugServer::interruptAndRun()


Modified: trunk/Source/WebKit/chromium/skia_webkit.gyp (139622 => 139623)

--- trunk/Source/WebKit/chromium/skia_webkit.gyp	2013-01-14 17:43:53 UTC (rev 139622)
+++ trunk/Source/WebKit/chromium/skia_webkit.gyp	2013-01-14 18:08:27 UTC (rev 139623)
@@ -43,6 +43,12 @@
   # DO NOT remove the define until you are ready to rebaseline, and
   # AFTER the flag has been removed from skia.gyp in Chromium.
 
+  # This flag causes asserts and image errors in border-drawing code
+  # where the borders have alpha. Do not remove this suppression until
+  # those issues have been addressed and the associated tests verified.
+  # See crbug.com/169550
+  'SK_DISABLE_DASHING_OPTIMIZATION',
+
 ],
   },
 },






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [139624] trunk/LayoutTests

[leviw]

Title: [139624] trunk/LayoutTests








Revision 139624
Author le...@chromium.org
Date 2013-01-14 10:28:46 -0800 (Mon, 14 Jan 2013)


Log Message
Unreviewed gardening. Marking editing/spelling/spellcheck-sequencenum.html
as flaky on Chromium Win Debug bots.

* platform/chromium/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (139623 => 139624)

--- trunk/LayoutTests/ChangeLog	2013-01-14 18:08:27 UTC (rev 139623)
+++ trunk/LayoutTests/ChangeLog	2013-01-14 18:28:46 UTC (rev 139624)
@@ -1,3 +1,10 @@
+2013-01-14  Levi Weintraub  le...@chromium.org
+
+Unreviewed gardening. Marking editing/spelling/spellcheck-sequencenum.html
+as flaky on Chromium Win Debug bots.
+
+* platform/chromium/TestExpectations:
+
 2013-01-14  Stephen Chenney  schen...@chromium.org
 
 Re-enabling the SK_DISABLE_DASHING_OPTIMIZATION flag for Skia


Modified: trunk/LayoutTests/platform/chromium/TestExpectations (139623 => 139624)

--- trunk/LayoutTests/platform/chromium/TestExpectations	2013-01-14 18:08:27 UTC (rev 139623)
+++ trunk/LayoutTests/platform/chromium/TestExpectations	2013-01-14 18:28:46 UTC (rev 139624)
@@ -4500,3 +4500,4 @@
 Bug(schenney) fast/css/continuationCrash.html [ ImageOnlyFailure ]
 Bug(schenney) fast/text/international/hindi-spacing.html [ ImageOnlyFailure Pass ]
 
+webkit.org/b/106806 [ Win Debug ] editing/spelling/spellcheck-sequencenum.html [ Pass Failure ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [139625] trunk/LayoutTests

[commit-queue]

Title: [139625] trunk/LayoutTests








Revision 139625
Author commit-qu...@webkit.org
Date 2013-01-14 10:51:13 -0800 (Mon, 14 Jan 2013)


Log Message
IndexedDB: Fix test for error message in storage/indexeddb/transaction-complete-workers.html
https://bugs.webkit.org/show_bug.cgi?id=106805

Patch by Michael Pruett mich...@68k.org on 2013-01-14
Reviewed by Tony Chang.

V8 prepends Uncaught  to uncaught exceptions, while JSC does not.
Either form of the error message should be acceptable.

* storage/indexeddb/transaction-complete-workers.html:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/storage/indexeddb/transaction-complete-workers.html




Diff

Modified: trunk/LayoutTests/ChangeLog (139624 => 139625)

--- trunk/LayoutTests/ChangeLog	2013-01-14 18:28:46 UTC (rev 139624)
+++ trunk/LayoutTests/ChangeLog	2013-01-14 18:51:13 UTC (rev 139625)
@@ -1,3 +1,15 @@
+2013-01-14  Michael Pruett  mich...@68k.org
+
+IndexedDB: Fix test for error message in storage/indexeddb/transaction-complete-workers.html
+https://bugs.webkit.org/show_bug.cgi?id=106805
+
+Reviewed by Tony Chang.
+
+V8 prepends Uncaught  to uncaught exceptions, while JSC does not.
+Either form of the error message should be acceptable.
+
+* storage/indexeddb/transaction-complete-workers.html:
+
 2013-01-14  Levi Weintraub  le...@chromium.org
 
 Unreviewed gardening. Marking editing/spelling/spellcheck-sequencenum.html


Modified: trunk/LayoutTests/storage/indexeddb/transaction-complete-workers.html (139624 => 139625)

--- trunk/LayoutTests/storage/indexeddb/transaction-complete-workers.html	2013-01-14 18:28:46 UTC (rev 139624)
+++ trunk/LayoutTests/storage/indexeddb/transaction-complete-workers.html	2013-01-14 18:51:13 UTC (rev 139625)
@@ -14,7 +14,7 @@
 
 var orig_onerror = worker.onerror;
 worker._onerror_ = function (event) {
-if (event.message === Uncaught Error: ignore this) {
+if (event.message === Uncaught Error: ignore this || event.message === Error: ignore this) {
 debug(Got expected error from worker, ignoring);
 evalAndLog(event.preventDefault());
 } else if (orig_onerror) {






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [139626] trunk/LayoutTests

[leviw]

Title: [139626] trunk/LayoutTests








Revision 139626
Author le...@chromium.org
Date 2013-01-14 10:57:23 -0800 (Mon, 14 Jan 2013)


Log Message
Unreviewed gardening. Marking fast/dom/HTMLTemplateElement/inertContents.html
as flaky on Chromium Debug bots.

* platform/chromium/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (139625 => 139626)

--- trunk/LayoutTests/ChangeLog	2013-01-14 18:51:13 UTC (rev 139625)
+++ trunk/LayoutTests/ChangeLog	2013-01-14 18:57:23 UTC (rev 139626)
@@ -1,3 +1,10 @@
+2013-01-14  Levi Weintraub  le...@chromium.org
+
+Unreviewed gardening. Marking fast/dom/HTMLTemplateElement/inertContents.html
+as flaky on Chromium Debug bots.
+
+* platform/chromium/TestExpectations:
+
 2013-01-14  Michael Pruett  mich...@68k.org
 
 IndexedDB: Fix test for error message in storage/indexeddb/transaction-complete-workers.html


Modified: trunk/LayoutTests/platform/chromium/TestExpectations (139625 => 139626)

--- trunk/LayoutTests/platform/chromium/TestExpectations	2013-01-14 18:51:13 UTC (rev 139625)
+++ trunk/LayoutTests/platform/chromium/TestExpectations	2013-01-14 18:57:23 UTC (rev 139626)
@@ -4501,3 +4501,4 @@
 Bug(schenney) fast/text/international/hindi-spacing.html [ ImageOnlyFailure Pass ]
 
 webkit.org/b/106806 [ Win Debug ] editing/spelling/spellcheck-sequencenum.html [ Pass Failure ]
+webkit.org/b/106810 [ Debug ] fast/dom/HTMLTemplateElement/inertContents.html [ Pass Failure ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [139627] trunk/Tools

[jochen]

Title: [139627] trunk/Tools








Revision 139627
Author joc...@chromium.org
Date 2013-01-14 11:04:39 -0800 (Mon, 14 Jan 2013)


Log Message
[chromium] move remaining methods to dump WebViewClient callbacks to TestRunner library
https://bugs.webkit.org/show_bug.cgi?id=106785

Reviewed by Adam Barth.

* DumpRenderTree/chromium/DRTTestRunner.cpp:
(DRTTestRunner::DRTTestRunner):
(DRTTestRunner::reset):
* DumpRenderTree/chromium/DRTTestRunner.h:
(DRTTestRunner):
* DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
(WebTestProxyBase):
(WebTestRunner::WebTestProxy::setStatusText):
(WebTestRunner::WebTestProxy::didStopLoading):
* DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
(WebTestRunner::WebTestRunner::shouldDumpStatusCallbacks):
(WebTestRunner::WebTestRunner::shouldDumpProgressFinishedCallback):
* DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
(WebTestRunner::TestRunner::TestRunner):
(WebTestRunner::TestRunner::reset):
(WebTestRunner::TestRunner::shouldDumpStatusCallbacks):
(WebTestRunner):
(WebTestRunner::TestRunner::shouldDumpProgressFinishedCallback):
(WebTestRunner::TestRunner::dumpWindowStatusChanges):
(WebTestRunner::TestRunner::dumpProgressFinishedCallback):
* DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
(TestRunner):
* DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
(WebTestRunner::WebTestProxyBase::setStatusText):
(WebTestRunner):
(WebTestRunner::WebTestProxyBase::didStopLoading):
* DumpRenderTree/chromium/WebViewHost.cpp:
(WebViewHost::didStopLoading):
* DumpRenderTree/chromium/WebViewHost.h:
(WebViewHost):

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/DumpRenderTree/chromium/DRTTestRunner.cpp
trunk/Tools/DumpRenderTree/chromium/DRTTestRunner.h
trunk/Tools/DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h
trunk/Tools/DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h
trunk/Tools/DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp
trunk/Tools/DumpRenderTree/chromium/TestRunner/src/TestRunner.h
trunk/Tools/DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp
trunk/Tools/DumpRenderTree/chromium/WebViewHost.cpp
trunk/Tools/DumpRenderTree/chromium/WebViewHost.h




Diff

Modified: trunk/Tools/ChangeLog (139626 => 139627)

--- trunk/Tools/ChangeLog	2013-01-14 18:57:23 UTC (rev 139626)
+++ trunk/Tools/ChangeLog	2013-01-14 19:04:39 UTC (rev 139627)
@@ -1,3 +1,41 @@
+2013-01-14  Jochen Eisinger  joc...@chromium.org
+
+[chromium] move remaining methods to dump WebViewClient callbacks to TestRunner library
+https://bugs.webkit.org/show_bug.cgi?id=106785
+
+Reviewed by Adam Barth.
+
+* DumpRenderTree/chromium/DRTTestRunner.cpp:
+(DRTTestRunner::DRTTestRunner):
+(DRTTestRunner::reset):
+* DumpRenderTree/chromium/DRTTestRunner.h:
+(DRTTestRunner):
+* DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
+(WebTestProxyBase):
+(WebTestRunner::WebTestProxy::setStatusText):
+(WebTestRunner::WebTestProxy::didStopLoading):
+* DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
+(WebTestRunner::WebTestRunner::shouldDumpStatusCallbacks):
+(WebTestRunner::WebTestRunner::shouldDumpProgressFinishedCallback):
+* DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
+(WebTestRunner::TestRunner::TestRunner):
+(WebTestRunner::TestRunner::reset):
+(WebTestRunner::TestRunner::shouldDumpStatusCallbacks):
+(WebTestRunner):
+(WebTestRunner::TestRunner::shouldDumpProgressFinishedCallback):
+(WebTestRunner::TestRunner::dumpWindowStatusChanges):
+(WebTestRunner::TestRunner::dumpProgressFinishedCallback):
+* DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
+(TestRunner):
+* DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
+(WebTestRunner::WebTestProxyBase::setStatusText):
+(WebTestRunner):
+(WebTestRunner::WebTestProxyBase::didStopLoading):
+* DumpRenderTree/chromium/WebViewHost.cpp:
+(WebViewHost::didStopLoading):
+* DumpRenderTree/chromium/WebViewHost.h:
+(WebViewHost):
+
 2013-01-14  Andrey Lushnikov  lushni...@chromium.org
 
 Web Inspector: devtools front-end doesn't have focus in TestShell


Modified: trunk/Tools/DumpRenderTree/chromium/DRTTestRunner.cpp (139626 => 139627)

--- trunk/Tools/DumpRenderTree/chromium/DRTTestRunner.cpp	2013-01-14 18:57:23 UTC (rev 139626)
+++ trunk/Tools/DumpRenderTree/chromium/DRTTestRunner.cpp	2013-01-14 19:04:39 UTC (rev 139627)
@@ -115,9 +115,7 @@
 bindMethod(display, DRTTestRunner::display);
 bindMethod(displayInvalidatedRegion, DRTTestRunner::displayInvalidatedRegion);
 bindMethod(dumpBackForwardList, DRTTestRunner::dumpBackForwardList);
-bindMethod(dumpProgressFinishedCallback, DRTTestRunner::dumpProgressFinishedCallback);
 bindMethod(dumpSelectionRect, DRTTestRunner::dumpSelectionRect);
-

[webkit-changes] [139628] tags/Safari-537.26/

[lforschler]

Title: [139628] tags/Safari-537.26/








Revision 139628
Author lforsch...@apple.com
Date 2013-01-14 11:04:41 -0800 (Mon, 14 Jan 2013)


Log Message
New Tag.

Added Paths

tags/Safari-537.26/




Diff

Property changes: tags/Safari-537.26



Added: svn:ignore
depcomp
compile
config.guess
GNUmakefile.in
config.sub
ltmain.sh
aconfig.h.in
autom4te.cache
missing
aclocal.m4
install-sh
autotoolsconfig.h.in
INSTALL
README
gtk-doc.make
out
Makefile.chromium
WebKitSupportLibrary.zip
WebKitBuild

Added: svn:mergeinfo




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [139629] trunk/Source/WebKit/blackberry

[zhajiang]

Title: [139629] trunk/Source/WebKit/blackberry








Revision 139629
Author zhaji...@rim.com
Date 2013-01-14 11:09:44 -0800 (Mon, 14 Jan 2013)


Log Message
[BlackBerry] Zoom is still possible when user-scalable=no
https://bugs.webkit.org/show_bug.cgi?id=106809

Patch by Jacky Jiang zhaji...@rim.com.
Reviewed by George Staikos.

PR: 274566
On wordpress.com, the contents were rendered at the width 343 which was
1 css pixel larger than the expected device-width 342 so that we didn't
respect the viewport.
There was a RenderBlock on the page which contained \n and an
inline-block. \n took 0.78 width and the inline-block took 342 width
and they were unfortunately placed in the same InlineBox which caused
the contents width 1 css pixels larger than the device-width.
Allow the contents width to be 1 css pixel larger and still respect the
viewport in such a special case.

* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::respectViewport):

Modified Paths

trunk/Source/WebKit/blackberry/Api/WebPage.cpp
trunk/Source/WebKit/blackberry/ChangeLog




Diff

Modified: trunk/Source/WebKit/blackberry/Api/WebPage.cpp (139628 => 139629)

--- trunk/Source/WebKit/blackberry/Api/WebPage.cpp	2013-01-14 19:04:41 UTC (rev 139628)
+++ trunk/Source/WebKit/blackberry/Api/WebPage.cpp	2013-01-14 19:09:44 UTC (rev 139629)
@@ -1699,7 +1699,7 @@
 
 bool WebPagePrivate::respectViewport() const
 {
-return m_forceRespectViewportArguments || contentsSize().width() = m_virtualViewportSize.width();
+return m_forceRespectViewportArguments || contentsSize().width() = m_virtualViewportSize.width() + 1;
 }
 
 double WebPagePrivate::initialScale() const


Modified: trunk/Source/WebKit/blackberry/ChangeLog (139628 => 139629)

--- trunk/Source/WebKit/blackberry/ChangeLog	2013-01-14 19:04:41 UTC (rev 139628)
+++ trunk/Source/WebKit/blackberry/ChangeLog	2013-01-14 19:09:44 UTC (rev 139629)
@@ -1,3 +1,24 @@
+2013-01-14  Jacky Jiang  zhaji...@rim.com
+
+[BlackBerry] Zoom is still possible when user-scalable=no
+https://bugs.webkit.org/show_bug.cgi?id=106809
+
+Reviewed by George Staikos.
+
+PR: 274566
+On wordpress.com, the contents were rendered at the width 343 which was
+1 css pixel larger than the expected device-width 342 so that we didn't
+respect the viewport.
+There was a RenderBlock on the page which contained \n and an
+inline-block. \n took 0.78 width and the inline-block took 342 width
+and they were unfortunately placed in the same InlineBox which caused
+the contents width 1 css pixels larger than the device-width.
+Allow the contents width to be 1 css pixel larger and still respect the
+viewport in such a special case.
+
+* Api/WebPage.cpp:
+(BlackBerry::WebKit::WebPagePrivate::respectViewport):
+
 2013-01-13  Xiaobo Wang  xbw...@torchmobile.com.cn
 
 [BlackBerry] Add a public function WebPage::isLoading()






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [139630] trunk/Source

[lforschler]

Title: [139630] trunk/Source








Revision 139630
Author lforsch...@apple.com
Date 2013-01-14 11:11:48 -0800 (Mon, 14 Jan 2013)


Log Message
Versioning.

Modified Paths

trunk/Source/_javascript_Core/Configurations/Version.xcconfig
trunk/Source/WebCore/Configurations/Version.xcconfig
trunk/Source/WebKit/mac/Configurations/Version.xcconfig
trunk/Source/WebKit2/Configurations/Version.xcconfig




Diff

Modified: trunk/Source/_javascript_Core/Configurations/Version.xcconfig (139629 => 139630)

--- trunk/Source/_javascript_Core/Configurations/Version.xcconfig	2013-01-14 19:09:44 UTC (rev 139629)
+++ trunk/Source/_javascript_Core/Configurations/Version.xcconfig	2013-01-14 19:11:48 UTC (rev 139630)
@@ -22,7 +22,7 @@
 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 
 
 MAJOR_VERSION = 537;
-MINOR_VERSION = 26;
+MINOR_VERSION = 27;
 TINY_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION);
 


Modified: trunk/Source/WebCore/Configurations/Version.xcconfig (139629 => 139630)

--- trunk/Source/WebCore/Configurations/Version.xcconfig	2013-01-14 19:09:44 UTC (rev 139629)
+++ trunk/Source/WebCore/Configurations/Version.xcconfig	2013-01-14 19:11:48 UTC (rev 139630)
@@ -22,7 +22,7 @@
 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 
 
 MAJOR_VERSION = 537;
-MINOR_VERSION = 26;
+MINOR_VERSION = 27;
 TINY_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION);
 


Modified: trunk/Source/WebKit/mac/Configurations/Version.xcconfig (139629 => 139630)

--- trunk/Source/WebKit/mac/Configurations/Version.xcconfig	2013-01-14 19:09:44 UTC (rev 139629)
+++ trunk/Source/WebKit/mac/Configurations/Version.xcconfig	2013-01-14 19:11:48 UTC (rev 139630)
@@ -22,7 +22,7 @@
 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 
 
 MAJOR_VERSION = 537;
-MINOR_VERSION = 26;
+MINOR_VERSION = 27;
 TINY_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION);
 


Modified: trunk/Source/WebKit2/Configurations/Version.xcconfig (139629 => 139630)

--- trunk/Source/WebKit2/Configurations/Version.xcconfig	2013-01-14 19:09:44 UTC (rev 139629)
+++ trunk/Source/WebKit2/Configurations/Version.xcconfig	2013-01-14 19:11:48 UTC (rev 139630)
@@ -22,7 +22,7 @@
 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 
 
 MAJOR_VERSION = 537;
-MINOR_VERSION = 26;
+MINOR_VERSION = 27;
 TINY_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION);
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [139631] branches/chromium/1364/Source

[wangxianzhu]

Title: [139631] branches/chromium/1364/Source








Revision 139631
Author wangxian...@chromium.org
Date 2013-01-14 11:21:46 -0800 (Mon, 14 Jan 2013)


Log Message
Merge 138991
 Add window.internals.nonFastScrollableRects for testing scrollable areas in fast/slow paths
 https://bugs.webkit.org/show_bug.cgi?id=105546
 
 Reviewed by James Robinson.
 
 .:
 
 Export the new symbol.
 
 * Source/autotools/symbols.filter:
 
 Source/WebCore:
 
 No new tests. Added test API for new tests of other bugs.
 
 * WebCore.exp.in:
 * page/Page.cpp:
 (WebCore::Page::nonFastScrollableRects):
 (WebCore):
 * page/Page.h:
 (WebCore):
 (Page):
 * page/scrolling/ScrollingCoordinator.cpp:
 (WebCore::ScrollingCoordinator::computeNonFastScrollableRegion): Change to public to allow Page::nonFastScrollableRects to access.
 * page/scrolling/ScrollingCoordinator.h:
 (ScrollingCoordinator):
 * testing/Internals.cpp:
 (WebCore::Internals::nonFastScrollableRects):
 (WebCore):
 * testing/Internals.h:
 * testing/Internals.idl:
 
 Source/WebKit2:
 
 Export the new symbol.
 
 * win/WebKit2.def.in:
 

TBR=wangxian...@chromium.org
Review URL: https://codereview.chromium.org/11875020

Modified Paths

branches/chromium/1364/Source/WebCore/WebCore.exp.in
branches/chromium/1364/Source/WebCore/page/Page.cpp
branches/chromium/1364/Source/WebCore/page/Page.h
branches/chromium/1364/Source/WebCore/page/scrolling/ScrollingCoordinator.cpp
branches/chromium/1364/Source/WebCore/page/scrolling/ScrollingCoordinator.h
branches/chromium/1364/Source/WebCore/testing/Internals.cpp
branches/chromium/1364/Source/WebCore/testing/Internals.h
branches/chromium/1364/Source/WebCore/testing/Internals.idl
branches/chromium/1364/Source/autotools/symbols.filter




Diff

Modified: branches/chromium/1364/Source/WebCore/WebCore.exp.in (139630 => 139631)

--- branches/chromium/1364/Source/WebCore/WebCore.exp.in	2013-01-14 19:11:48 UTC (rev 139630)
+++ branches/chromium/1364/Source/WebCore/WebCore.exp.in	2013-01-14 19:21:46 UTC (rev 139631)
@@ -759,6 +759,7 @@
 __ZN7WebCore4Page20unmarkAllTextMatchesEv
 __ZN7WebCore4Page21markAllMatchesForTextERKN3WTF6StringEjbj
 __ZN7WebCore4Page22allVisitedStateChangedEPNS_9PageGroupE
+__ZN7WebCore4Page22nonFastScrollableRectsEPKNS_5FrameE
 __ZN7WebCore4Page23clearUndoRedoOperationsEv
 __ZN7WebCore4Page24resumeScriptedAnimationsEv
 __ZN7WebCore4Page24scrollingStateTreeAsTextEv


Modified: branches/chromium/1364/Source/WebCore/page/Page.cpp (139630 => 139631)

--- branches/chromium/1364/Source/WebCore/page/Page.cpp	2013-01-14 19:11:48 UTC (rev 139630)
+++ branches/chromium/1364/Source/WebCore/page/Page.cpp	2013-01-14 19:21:46 UTC (rev 139631)
@@ -25,6 +25,7 @@
 #include BackForwardList.h
 #include Chrome.h
 #include ChromeClient.h
+#include ClientRectList.h
 #include ContextMenuClient.h
 #include ContextMenuController.h
 #include DOMWindow.h
@@ -269,6 +270,21 @@
 return String();
 }
 
+PassRefPtrClientRectList Page::nonFastScrollableRects(const Frame* frame)
+{
+if (Document* document = m_mainFrame-document())
+document-updateLayout();
+
+VectorIntRect rects;
+if (ScrollingCoordinator* scrollingCoordinator = this-scrollingCoordinator())
+rects = scrollingCoordinator-computeNonFastScrollableRegion(frame, IntPoint()).rects();
+
+VectorFloatQuad quads(rects.size());
+for (size_t i = 0; i  rects.size(); ++i)
+quads[i] = FloatRect(rects[i]);
+return ClientRectList::create(quads);
+}
+
 struct ViewModeInfo {
 const char* name;
 Page::ViewMode type;


Modified: branches/chromium/1364/Source/WebCore/page/Page.h (139630 => 139631)

--- branches/chromium/1364/Source/WebCore/page/Page.h	2013-01-14 19:11:48 UTC (rev 139630)
+++ branches/chromium/1364/Source/WebCore/page/Page.h	2013-01-14 19:21:46 UTC (rev 139631)
@@ -57,6 +57,7 @@
 class BackForwardList;
 class Chrome;
 class ChromeClient;
+class ClientRectList;
 #if ENABLE(CONTEXT_MENUS)
 class ContextMenuClient;
 class ContextMenuController;
@@ -200,6 +201,7 @@
 
 String scrollingStateTreeAsText();
 String mainThreadScrollingReasonsAsText();
+PassRefPtrClientRectList nonFastScrollableRects(const Frame*);
 
 Settings* settings() const { return m_settings.get(); }
 ProgressTracker* progress() const { return m_progress.get(); }


Modified: branches/chromium/1364/Source/WebCore/page/scrolling/ScrollingCoordinator.cpp (139630 => 139631)

--- branches/chromium/1364/Source/WebCore/page/scrolling/ScrollingCoordinator.cpp	2013-01-14 19:11:48 UTC (rev 139630)
+++ branches/chromium/1364/Source/WebCore/page/scrolling/ScrollingCoordinator.cpp	2013-01-14 19:21:46 UTC (rev 139631)
@@ -136,7 +136,7 @@
 #endif
 }
 
-Region ScrollingCoordinator::computeNonFastScrollableRegion(Frame* frame, const IntPoint frameLocation)
+Region ScrollingCoordinator::computeNonFastScrollableRegion(const Frame* frame, const IntPoint frameLocation) const
 {
 Region nonFastScrollableRegion;
 FrameView* frameView 

[webkit-changes] [139632] branches/chromium/1364

[wangxianzhu]

Title: [139632] branches/chromium/1364








Revision 139632
Author wangxian...@chromium.org
Date 2013-01-14 11:23:26 -0800 (Mon, 14 Jan 2013)


Log Message
Merge 139024
 Add a setting to enable composited scrolling for frames
 https://bugs.webkit.org/show_bug.cgi?id=104950
 
 Reviewed by James Robinson.
 
 Source/WebCore:
 
 Test: compositing/iframes/iframe-composited-scrolling.html
 
 * page/FrameView.cpp:
 (WebCore::FrameView::usesCompositedScrolling): Returns true if compositedScrollingForFramesEnabled and the frame is in forced compositing mode (which is set when forced compositing mode and compositing for scrollable frames are enabled), so that ScrollingCoordinator won't include the region of the frame in the nonFastScrollableRegion.
 (WebCore):
 * page/FrameView.h:
 (FrameView):
 * page/Settings.in: Add compositedScrollingForFramesEnabled setting.
 * page/scrolling/chromium/ScrollingCoordinatorChromium.cpp:
 (WebCore::ScrollingCoordinatorChromium::frameViewLayoutUpdated): Changed the comment about which ScrollableAreas are non-fast-scrollable.
 * rendering/RenderLayerCompositor.cpp:
 (WebCore::RenderLayerCompositor::frameViewDidScroll): Let ScrollongCoordinator know when the scrolling changes for a frame with composited scrolling enabled.
 
 LayoutTests:
 
 Test case to ensure iframes are not added into nonFastScrollableRegion when acceleratedCompositingForScrollableFramesEnabled and compositedScrollingForFramesEnabled.
 
 * compositing/iframes/iframe-composited-scrolling-expected.txt: Added.
 * compositing/iframes/iframe-composited-scrolling.html: Added.
 

TBR=wangxian...@chromium.org
Review URL: https://codereview.chromium.org/11880030

Modified Paths

branches/chromium/1364/Source/WebCore/page/FrameView.cpp
branches/chromium/1364/Source/WebCore/page/FrameView.h
branches/chromium/1364/Source/WebCore/page/Settings.in
branches/chromium/1364/Source/WebCore/page/scrolling/chromium/ScrollingCoordinatorChromium.cpp
branches/chromium/1364/Source/WebCore/rendering/RenderLayerCompositor.cpp


Added Paths

branches/chromium/1364/LayoutTests/compositing/iframes/iframe-composited-scrolling-expected.txt
branches/chromium/1364/LayoutTests/compositing/iframes/iframe-composited-scrolling.html




Diff

Copied: branches/chromium/1364/LayoutTests/compositing/iframes/iframe-composited-scrolling-expected.txt (from rev 139024, trunk/LayoutTests/compositing/iframes/iframe-composited-scrolling-expected.txt) (0 => 139632)

--- branches/chromium/1364/LayoutTests/compositing/iframes/iframe-composited-scrolling-expected.txt	(rev 0)
+++ branches/chromium/1364/LayoutTests/compositing/iframes/iframe-composited-scrolling-expected.txt	2013-01-14 19:23:26 UTC (rev 139632)
@@ -0,0 +1,2 @@
+ 
+PASS


Copied: branches/chromium/1364/LayoutTests/compositing/iframes/iframe-composited-scrolling.html (from rev 139024, trunk/LayoutTests/compositing/iframes/iframe-composited-scrolling.html) (0 => 139632)

--- branches/chromium/1364/LayoutTests/compositing/iframes/iframe-composited-scrolling.html	(rev 0)
+++ branches/chromium/1364/LayoutTests/compositing/iframes/iframe-composited-scrolling.html	2013-01-14 19:23:26 UTC (rev 139632)
@@ -0,0 +1,32 @@
+!DOCTYPE html
+html
+head
+  style
+iframe {
+  height: 150px;
+  width: 150px;
+}
+  /style
+  script
+if (window.internals) {
+  internals.settings.setForceCompositingMode(true);
+  internals.settings.setAcceleratedCompositingForScrollableFramesEnabled(true);
+  internals.settings.setCompositedScrollingForFramesEnabled(true);
+}
+function doTest()
+{
+  if (window.testRunner) {
+testRunner.dumpAsText(false);
+if (window.internals)
+  document.getElementById(result).innerText = window.internals.nonFastScrollableRects(document).length ? FAIL : PASS;
+  }
+}
+window.addEventListener(load, doTest, false);
+  /script
+/head
+body
+  iframe id=scrollable-iframe src="" style=width: 100px; height: 100px/iframe
+  iframe id=non-scrollable-iframe src="" style=width: 2000px; height: 2000px/iframe
+  pre id=result/pre
+/body
+/html


Modified: branches/chromium/1364/Source/WebCore/page/FrameView.cpp (139631 => 139632)

--- branches/chromium/1364/Source/WebCore/page/FrameView.cpp	2013-01-14 19:21:46 UTC (rev 139631)
+++ branches/chromium/1364/Source/WebCore/page/FrameView.cpp	2013-01-14 19:23:26 UTC (rev 139632)
@@ -767,6 +767,15 @@
 compositor-updateCompositingLayers(CompositingUpdateAfterLayout);
 }
 
+bool FrameView::usesCompositedScrolling() const
+{
+if (m_frame-settings()  m_frame-settings()-compositedScrollingForFramesEnabled()) {
+RenderView* root = rootRenderer(this);
+return root  root-compositor()-inForcedCompositingMode();
+}
+return false;
+}
+
 GraphicsLayer* FrameView::layerForHorizontalScrollbar() const
 {
 RenderView* root = rootRenderer(this);


Modified: branches/chromium/1364/Source/WebCore/page/FrameView.h (139631 => 

[webkit-changes] [139633] branches/chromium/1364/Source/WebKit/chromium

[wangxianzhu]

Title: [139633] branches/chromium/1364/Source/WebKit/chromium








Revision 139633
Author wangxian...@chromium.org
Date 2013-01-14 11:24:49 -0800 (Mon, 14 Jan 2013)


Log Message
Merge 139028
 [Chromium] Expose compositedScrollingForFramesEnabled setting in WebKit API
 https://bugs.webkit.org/show_bug.cgi?id=106262
 
 Reviewed by James Robinson.
 
 * public/WebSettings.h:
 * src/WebSettingsImpl.cpp:
 (WebKit::WebSettingsImpl::setCompositedScrollingForFramesEnabled):
 (WebKit):
 * src/WebSettingsImpl.h:
 (WebSettingsImpl):
 

TBR=wangxian...@chromium.org
Review URL: https://codereview.chromium.org/11882024

Modified Paths

branches/chromium/1364/Source/WebKit/chromium/public/WebSettings.h
branches/chromium/1364/Source/WebKit/chromium/src/WebSettingsImpl.cpp
branches/chromium/1364/Source/WebKit/chromium/src/WebSettingsImpl.h




Diff

Modified: branches/chromium/1364/Source/WebKit/chromium/public/WebSettings.h (139632 => 139633)

--- branches/chromium/1364/Source/WebKit/chromium/public/WebSettings.h	2013-01-14 19:23:26 UTC (rev 139632)
+++ branches/chromium/1364/Source/WebKit/chromium/public/WebSettings.h	2013-01-14 19:24:49 UTC (rev 139633)
@@ -80,6 +80,7 @@
 virtual void setAutoZoomFocusedNodeToLegibleScale(bool) = 0;
 virtual void setAuthorAndUserStylesEnabled(bool) = 0;
 virtual void setCaretBrowsingEnabled(bool) = 0;
+virtual void setCompositedScrollingForFramesEnabled(bool) = 0;
 virtual void setCookieEnabled(bool) = 0;
 virtual void setCursiveFontFamily(const WebString, UScriptCode = USCRIPT_COMMON) = 0;
 virtual void setDNSPrefetchingEnabled(bool) = 0;


Modified: branches/chromium/1364/Source/WebKit/chromium/src/WebSettingsImpl.cpp (139632 => 139633)

--- branches/chromium/1364/Source/WebKit/chromium/src/WebSettingsImpl.cpp	2013-01-14 19:23:26 UTC (rev 139632)
+++ branches/chromium/1364/Source/WebKit/chromium/src/WebSettingsImpl.cpp	2013-01-14 19:24:49 UTC (rev 139633)
@@ -728,4 +728,9 @@
 m_settings-setAllowCustomScrollbarInMainFrame(enabled);
 }
 
+void WebSettingsImpl::setCompositedScrollingForFramesEnabled(bool enabled)
+{
+m_settings-setCompositedScrollingForFramesEnabled(enabled);
+}
+
 } // namespace WebKit


Modified: branches/chromium/1364/Source/WebKit/chromium/src/WebSettingsImpl.h (139632 => 139633)

--- branches/chromium/1364/Source/WebKit/chromium/src/WebSettingsImpl.h	2013-01-14 19:23:26 UTC (rev 139632)
+++ branches/chromium/1364/Source/WebKit/chromium/src/WebSettingsImpl.h	2013-01-14 19:24:49 UTC (rev 139633)
@@ -72,6 +72,7 @@
 virtual void setAuthorAndUserStylesEnabled(bool);
 virtual void setAutoZoomFocusedNodeToLegibleScale(bool);
 virtual void setCaretBrowsingEnabled(bool);
+virtual void setCompositedScrollingForFramesEnabled(bool);
 virtual void setCookieEnabled(bool);
 virtual void setCursiveFontFamily(const WebString, UScriptCode = USCRIPT_COMMON);
 virtual void setDNSPrefetchingEnabled(bool);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [139634] trunk/Source/WebCore

[yurys]

Title: [139634] trunk/Source/WebCore








Revision 139634
Author yu...@chromium.org
Date 2013-01-14 11:43:42 -0800 (Mon, 14 Jan 2013)


Log Message
[REGRESSION] Dev Tools popup for Workers forgets sizes/shows tiny in top left
https://bugs.webkit.org/show_bug.cgi?id=106807

Reviewed by Pavel Feldman.

Open dedicated worker inspector 600x600 by default and remember its size
after resizing.

* inspector/front-end/Settings.js:
* inspector/front-end/WorkerManager.js:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/Settings.js
trunk/Source/WebCore/inspector/front-end/WorkerManager.js




Diff

Modified: trunk/Source/WebCore/ChangeLog (139633 => 139634)

--- trunk/Source/WebCore/ChangeLog	2013-01-14 19:24:49 UTC (rev 139633)
+++ trunk/Source/WebCore/ChangeLog	2013-01-14 19:43:42 UTC (rev 139634)
@@ -1,3 +1,16 @@
+2013-01-14  Yury Semikhatsky  yu...@chromium.org
+
+[REGRESSION] Dev Tools popup for Workers forgets sizes/shows tiny in top left
+https://bugs.webkit.org/show_bug.cgi?id=106807
+
+Reviewed by Pavel Feldman.
+
+Open dedicated worker inspector 600x600 by default and remember its size
+after resizing.
+
+* inspector/front-end/Settings.js:
+* inspector/front-end/WorkerManager.js:
+
 2013-01-14  Kentaro Hara  hara...@chromium.org
 
 [V8] Make an Isolate parameter mandatory in associateObjectWithWrapper()


Modified: trunk/Source/WebCore/inspector/front-end/Settings.js (139633 => 139634)

--- trunk/Source/WebCore/inspector/front-end/Settings.js	2013-01-14 19:24:49 UTC (rev 139633)
+++ trunk/Source/WebCore/inspector/front-end/Settings.js	2013-01-14 19:43:42 UTC (rev 139634)
@@ -115,6 +115,8 @@
 this.showMetricsRulers = this.createSetting(showMetricsRulers, false);
 this.emulatedCSSMedia = this.createSetting(emulatedCSSMedia, print);
 this.showToolbarIcons = this.createSetting(showToolbarIcons, false);
+this.workerInspectorWidth = this.createSetting(workerInspectorWidth, 600);
+this.workerInspectorHeight = this.createSetting(workerInspectorHeight, 600);
 
 // If there are too many breakpoints in a storage, it is likely due to a recent bug that caused
 // periodical breakpoints duplication leading to inspector slowness.


Modified: trunk/Source/WebCore/inspector/front-end/WorkerManager.js (139633 => 139634)

--- trunk/Source/WebCore/inspector/front-end/WorkerManager.js	2013-01-14 19:24:49 UTC (rev 139633)
+++ trunk/Source/WebCore/inspector/front-end/WorkerManager.js	2013-01-14 19:43:42 UTC (rev 139634)
@@ -171,8 +171,11 @@
 url += workerPaused=true;
 url = "" );
 url += hash;
+var width = WebInspector.settings.workerInspectorWidth.get();
+var height = WebInspector.settings.workerInspectorHeight.get();
 // Set location=0 just to make sure the front-end will be opened in a separate window, not in new tab.
-var workerInspectorWindow = window.open(url, undefined, location=0);
+var workerInspectorWindow = window.open(url, undefined, location=0,width= + width + ,height= + height);
+workerInspectorWindow.addEventListener(resize, this._onWorkerInspectorResize.bind(this, workerInspectorWindow), false);
 this._workerIdToWindow[workerId] = workerInspectorWindow;
 workerInspectorWindow.addEventListener(beforeunload, this._workerInspectorClosing.bind(this, workerId), true);
 
@@ -204,6 +207,13 @@
 }
 },
 
+_onWorkerInspectorResize: function(workerInspectorWindow)
+{
+var doc = workerInspectorWindow.document;
+WebInspector.settings.workerInspectorWidth.set(doc.width);
+WebInspector.settings.workerInspectorHeight.set(doc.height);
+},
+
 _workerInspectorClosing: function(workerId, event)
 {
 if (event.target.location.href ="" about:blank)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [139635] branches/chromium/1364

[simonjam]

Title: [139635] branches/chromium/1364








Revision 139635
Author simon...@chromium.org
Date 2013-01-14 11:45:56 -0800 (Mon, 14 Jan 2013)


Log Message
Merge 139509
 Restore old semantics to webkitRequestAnimationFrame callbacks
 https://bugs.webkit.org/show_bug.cgi?id=106697
 
 Reviewed by James Robinson.
 
 Source/WebCore:
 
 Sites that use GWT = 2.4 are buggy and rely on Date.now()-like callback values.
 We'll restore that behavior to the prefixed version of webkitRequestAnimationFrame.
 requestAnimationFrame will continue to follow the spec.
 
 Test: fast/animation/request-animation-frame-prefix.html
 
 * dom/RequestAnimationFrameCallback.h:
 (RequestAnimationFrameCallback):
 * dom/ScriptedAnimationController.cpp:
 (WebCore::ScriptedAnimationController::serviceScriptedAnimations):
 * page/DOMWindow.cpp:
 (WebCore::DOMWindow::requestAnimationFrame):
 (WebCore):
 (WebCore::DOMWindow::webkitRequestAnimationFrame):
 * page/DOMWindow.h:
 (DOMWindow):
 * page/DOMWindow.idl:
 
 LayoutTests:
 
 * fast/animation/request-animation-frame-prefix-expected.txt: Added.
 * fast/animation/request-animation-frame-prefix.html: Added.
 * fast/animation/script-tests/request-animation-frame-prefix.js: Added.
 (busyWait):
 (window.webkitRequestAnimationFrame):
 

TBR=simon...@chromium.org
Review URL: https://codereview.chromium.org/11876026

Modified Paths

branches/chromium/1364/Source/WebCore/dom/RequestAnimationFrameCallback.h
branches/chromium/1364/Source/WebCore/dom/ScriptedAnimationController.cpp
branches/chromium/1364/Source/WebCore/page/DOMWindow.cpp
branches/chromium/1364/Source/WebCore/page/DOMWindow.h
branches/chromium/1364/Source/WebCore/page/DOMWindow.idl


Added Paths

branches/chromium/1364/LayoutTests/fast/animation/request-animation-frame-prefix-expected.txt
branches/chromium/1364/LayoutTests/fast/animation/request-animation-frame-prefix.html
branches/chromium/1364/LayoutTests/fast/animation/script-tests/request-animation-frame-prefix.js




Diff

Copied: branches/chromium/1364/LayoutTests/fast/animation/request-animation-frame-prefix-expected.txt (from rev 139509, trunk/LayoutTests/fast/animation/request-animation-frame-prefix-expected.txt) (0 => 139635)

--- branches/chromium/1364/LayoutTests/fast/animation/request-animation-frame-prefix-expected.txt	(rev 0)
+++ branches/chromium/1364/LayoutTests/fast/animation/request-animation-frame-prefix-expected.txt	2013-01-14 19:45:56 UTC (rev 139635)
@@ -0,0 +1,9 @@
+Tests the timestamps provided to prefixed webkitRequestAnimationFrame callbacks
+
+On success, you will see a series of PASS messages, followed by TEST COMPLETE.
+
+
+PASS legacyFirstTimestamp is = firstTimestamp
+PASS legacySecondTimestamp is = secondTimestamp
+PASS deltaError  0.001 is true
+


Copied: branches/chromium/1364/LayoutTests/fast/animation/request-animation-frame-prefix.html (from rev 139509, trunk/LayoutTests/fast/animation/request-animation-frame-prefix.html) (0 => 139635)

--- branches/chromium/1364/LayoutTests/fast/animation/request-animation-frame-prefix.html	(rev 0)
+++ branches/chromium/1364/LayoutTests/fast/animation/request-animation-frame-prefix.html	2013-01-14 19:45:56 UTC (rev 139635)
@@ -0,0 +1,11 @@
+!DOCTYPE html
+html
+head
+script src=""
+/head
+body
+span id=e/span
+span id=f/span
+script src=""
+/body
+/html


Copied: branches/chromium/1364/LayoutTests/fast/animation/script-tests/request-animation-frame-prefix.js (from rev 139509, trunk/LayoutTests/fast/animation/script-tests/request-animation-frame-prefix.js) (0 => 139635)

--- branches/chromium/1364/LayoutTests/fast/animation/script-tests/request-animation-frame-prefix.js	(rev 0)
+++ branches/chromium/1364/LayoutTests/fast/animation/script-tests/request-animation-frame-prefix.js	2013-01-14 19:45:56 UTC (rev 139635)
@@ -0,0 +1,46 @@
+description(Tests the timestamps provided to prefixed webkitRequestAnimationFrame callbacks);
+
+var firstTimestamp = undefined;
+var secondTimestamp = undefined;
+var legacyFirstTimestamp = undefined;
+var legacySecondTimestamp = undefined;
+var deltaError = undefined;
+
+function busyWait(millis) {
+var start = Date.now();
+while (Date.now()-start  millis) {}
+}
+
+window.requestAnimationFrame(function(timestamp) {
+firstTimestamp = timestamp;
+});
+
+window.webkitRequestAnimationFrame(function(timestamp) {
+legacyFirstTimestamp = timestamp;
+
+window.requestAnimationFrame(function(timestamp) {
+secondTimestamp = timestamp;
+});
+
+window.webkitRequestAnimationFrame(function(timestamp) {
+legacySecondTimestamp = timestamp;
+
+shouldBeGreaterThanOrEqual(legacyFirstTimestamp, firstTimestamp);
+shouldBeGreaterThanOrEqual(legacySecondTimestamp, secondTimestamp);
+deltaError = Math.abs((legacySecondTimestamp - legacyFirstTimestamp) - (secondTimestamp - firstTimestamp));
+shouldBeTrue(deltaError  0.001);
+testRunner.notifyDone();
+

[webkit-changes] [139636] trunk/LayoutTests

[tony]

Title: [139636] trunk/LayoutTests








Revision 139636
Author t...@chromium.org
Date 2013-01-14 11:53:42 -0800 (Mon, 14 Jan 2013)


Log Message
Layout Test editing/spelling/spellcheck-sequencenum.html is flaky on Debug Win Chromium Bot
https://bugs.webkit.org/show_bug.cgi?id=106806

Reviewed by Levi Weintraub.

This test manually calls waitUntilDone and uses js-test-pre.js/js-test-post.js. This confuses
the timing of the PASS successfullyParsed is true output. Fix this by using the helper
functions in js-test-pre.js for waitUntilDone/notifyDone.

* editing/spelling/spellcheck-sequencenum-expected.txt:
* editing/spelling/spellcheck-sequencenum.html:
* platform/win/editing/spelling/spellcheck-sequencenum-expected.txt: Removed.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/editing/spelling/spellcheck-sequencenum-expected.txt
trunk/LayoutTests/editing/spelling/spellcheck-sequencenum.html


Removed Paths

trunk/LayoutTests/platform/win/editing/spelling/spellcheck-sequencenum-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (139635 => 139636)

--- trunk/LayoutTests/ChangeLog	2013-01-14 19:45:56 UTC (rev 139635)
+++ trunk/LayoutTests/ChangeLog	2013-01-14 19:53:42 UTC (rev 139636)
@@ -1,3 +1,18 @@
+2013-01-14  Tony Chang  t...@chromium.org
+
+Layout Test editing/spelling/spellcheck-sequencenum.html is flaky on Debug Win Chromium Bot
+https://bugs.webkit.org/show_bug.cgi?id=106806
+
+Reviewed by Levi Weintraub.
+
+This test manually calls waitUntilDone and uses js-test-pre.js/js-test-post.js. This confuses
+the timing of the PASS successfullyParsed is true output. Fix this by using the helper
+functions in js-test-pre.js for waitUntilDone/notifyDone.
+
+* editing/spelling/spellcheck-sequencenum-expected.txt:
+* editing/spelling/spellcheck-sequencenum.html:
+* platform/win/editing/spelling/spellcheck-sequencenum-expected.txt: Removed.
+
 2013-01-14  Levi Weintraub  le...@chromium.org
 
 Unreviewed gardening. Marking fast/dom/HTMLTemplateElement/inertContents.html


Modified: trunk/LayoutTests/editing/spelling/spellcheck-sequencenum-expected.txt (139635 => 139636)

--- trunk/LayoutTests/editing/spelling/spellcheck-sequencenum-expected.txt	2013-01-14 19:45:56 UTC (rev 139635)
+++ trunk/LayoutTests/editing/spelling/spellcheck-sequencenum-expected.txt	2013-01-14 19:53:42 UTC (rev 139636)
@@ -3,10 +3,10 @@
 On success, you will see a series of PASS messages, followed by TEST COMPLETE.
 
 
-PASS successfullyParsed is true
-
-TEST COMPLETE
 PASS SpellCheck sequence seems working correctly.
 PASS SpellCheck sequence seems working correctly.
 PASS SpellCheck sequence seems working correctly.
+PASS successfullyParsed is true
 
+TEST COMPLETE
+


Modified: trunk/LayoutTests/editing/spelling/spellcheck-sequencenum.html (139635 => 139636)

--- trunk/LayoutTests/editing/spelling/spellcheck-sequencenum.html	2013-01-14 19:45:56 UTC (rev 139635)
+++ trunk/LayoutTests/editing/spelling/spellcheck-sequencenum.html	2013-01-14 19:53:42 UTC (rev 139636)
@@ -11,7 +11,7 @@
 description('For Bug 73511: Internals should have a method to return the max sequence number of spellcheck request.');
 
 if (window.testRunner) {
-testRunner.waitUntilDone();
+window.jsTestIsAsync = true;
 testRunner.setAsynchronousSpellCheckingEnabled(true);
 }
 
@@ -79,7 +79,7 @@
 testRoot.style.display = none;
 if (window.testRunner) {
 testRunner.setAsynchronousSpellCheckingEnabled(false);
-testRunner.notifyDone();
+finishJSTest();
 }
 }
 


Deleted: trunk/LayoutTests/platform/win/editing/spelling/spellcheck-sequencenum-expected.txt (139635 => 139636)

--- trunk/LayoutTests/platform/win/editing/spelling/spellcheck-sequencenum-expected.txt	2013-01-14 19:45:56 UTC (rev 139635)
+++ trunk/LayoutTests/platform/win/editing/spelling/spellcheck-sequencenum-expected.txt	2013-01-14 19:53:42 UTC (rev 139636)
@@ -1,12 +0,0 @@
-For Bug 73511: Internals should have a method to return the max sequence number of spellcheck request.
-
-On success, you will see a series of PASS messages, followed by TEST COMPLETE.
-
-
-PASS SpellCheck sequence seems working correctly.
-PASS SpellCheck sequence seems working correctly.
-PASS SpellCheck sequence seems working correctly.
-PASS successfullyParsed is true
-
-TEST COMPLETE
-






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [139637] trunk/LayoutTests

[leviw]

Title: [139637] trunk/LayoutTests








Revision 139637
Author le...@chromium.org
Date 2013-01-14 11:55:41 -0800 (Mon, 14 Jan 2013)


Log Message
Unreviewed gardening. Removing entry for editing/spelling/spellcheck-sequencenum.html
in Chromium test expectations. Tony fixed the issue in r139636.

* platform/chromium/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (139636 => 139637)

--- trunk/LayoutTests/ChangeLog	2013-01-14 19:53:42 UTC (rev 139636)
+++ trunk/LayoutTests/ChangeLog	2013-01-14 19:55:41 UTC (rev 139637)
@@ -1,3 +1,10 @@
+2013-01-14  Levi Weintraub  le...@chromium.org
+
+Unreviewed gardening. Removing entry for editing/spelling/spellcheck-sequencenum.html
+in Chromium test expectations. Tony fixed the issue in r139636.
+
+* platform/chromium/TestExpectations:
+
 2013-01-14  Tony Chang  t...@chromium.org
 
 Layout Test editing/spelling/spellcheck-sequencenum.html is flaky on Debug Win Chromium Bot


Modified: trunk/LayoutTests/platform/chromium/TestExpectations (139636 => 139637)

--- trunk/LayoutTests/platform/chromium/TestExpectations	2013-01-14 19:53:42 UTC (rev 139636)
+++ trunk/LayoutTests/platform/chromium/TestExpectations	2013-01-14 19:55:41 UTC (rev 139637)
@@ -4500,5 +4500,4 @@
 Bug(schenney) fast/css/continuationCrash.html [ ImageOnlyFailure ]
 Bug(schenney) fast/text/international/hindi-spacing.html [ ImageOnlyFailure Pass ]
 
-webkit.org/b/106806 [ Win Debug ] editing/spelling/spellcheck-sequencenum.html [ Pass Failure ]
 webkit.org/b/106810 [ Debug ] fast/dom/HTMLTemplateElement/inertContents.html [ Pass Failure ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [139638] trunk/Source/WebCore

[antti]

Title: [139638] trunk/Source/WebCore








Revision 139638
Author an...@apple.com
Date 2013-01-14 12:16:57 -0800 (Mon, 14 Jan 2013)


Log Message
REGRESSION (r139218): Flaky assertion in WebCore::StorageTask::StorageTask releasing memory
https://bugs.webkit.org/show_bug.cgi?id=106718

Reviewed by Andreas Kling.

Type assertion was missing a new type.

* storage/StorageTask.cpp:
(WebCore::StorageTask::StorageTask):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/storage/StorageTask.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (139637 => 139638)

--- trunk/Source/WebCore/ChangeLog	2013-01-14 19:55:41 UTC (rev 139637)
+++ trunk/Source/WebCore/ChangeLog	2013-01-14 20:16:57 UTC (rev 139638)
@@ -1,3 +1,15 @@
+2013-01-14  Antti Koivisto  an...@apple.com
+
+REGRESSION (r139218): Flaky assertion in WebCore::StorageTask::StorageTask releasing memory
+https://bugs.webkit.org/show_bug.cgi?id=106718
+
+Reviewed by Andreas Kling.
+
+Type assertion was missing a new type.
+
+* storage/StorageTask.cpp:
+(WebCore::StorageTask::StorageTask):
+
 2013-01-14  Yury Semikhatsky  yu...@chromium.org
 
 [REGRESSION] Dev Tools popup for Workers forgets sizes/shows tiny in top left


Modified: trunk/Source/WebCore/storage/StorageTask.cpp (139637 => 139638)

--- trunk/Source/WebCore/storage/StorageTask.cpp	2013-01-14 19:55:41 UTC (rev 139637)
+++ trunk/Source/WebCore/storage/StorageTask.cpp	2013-01-14 20:16:57 UTC (rev 139638)
@@ -55,7 +55,7 @@
 , m_area(0)
 , m_thread(0)
 {
-ASSERT(m_type == ImportOrigins || m_type == DeleteAllOrigins);
+ASSERT(m_type == ImportOrigins || m_type == DeleteAllOrigins || m_type == ReleaseFastMallocFreeMemory);
 }
 
 StorageTask::StorageTask(Type type, const String originIdentifier)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [139639] trunk/Source/WebCore

[esprehn]

Title: [139639] trunk/Source/WebCore








Revision 139639
Author espr...@chromium.org
Date 2013-01-14 12:17:58 -0800 (Mon, 14 Jan 2013)


Log Message
Clean up WebVTTNodeType code
https://bugs.webkit.org/show_bug.cgi?id=106714

Reviewed by Tony Chang.

There's no reason for so many methods just to compare some enums.
The existing code can also be simplified quite a bit.

No new tests, just refactoring.

* css/SelectorChecker.cpp:
(WebCore::SelectorChecker::checkOne):
* css/StyleResolver.cpp:
(WebCore::StyleResolver::collectMatchingRules):
(WebCore::StyleResolver::canShareStyleWithElement):
* dom/Element.cpp:
(WebCore::Element::webVTTNodeType):
(WebCore::Element::setWebVTTNodeType):
* dom/Element.h:
(Element):
* dom/ElementRareData.h:
(WebCore::ElementRareData::setWebVTTNodeType):
(WebCore::ElementRareData::webVTTNodeType):
(ElementRareData):
* dom/NodeRareData.h:
(WebCore::NodeRareData::NodeRareData):
(NodeRareData):
* html/track/TextTrack.h:
* html/track/TextTrackCue.cpp:
(WebCore::TextTrackCue::markFutureAndPastNodes):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/SelectorChecker.cpp
trunk/Source/WebCore/css/StyleResolver.cpp
trunk/Source/WebCore/dom/Element.cpp
trunk/Source/WebCore/dom/Element.h
trunk/Source/WebCore/dom/ElementRareData.h
trunk/Source/WebCore/dom/NodeRareData.h
trunk/Source/WebCore/html/track/TextTrack.h
trunk/Source/WebCore/html/track/TextTrackCue.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (139638 => 139639)

--- trunk/Source/WebCore/ChangeLog	2013-01-14 20:16:57 UTC (rev 139638)
+++ trunk/Source/WebCore/ChangeLog	2013-01-14 20:17:58 UTC (rev 139639)
@@ -1,3 +1,36 @@
+2013-01-14  Elliott Sprehn  espr...@chromium.org
+
+Clean up WebVTTNodeType code
+https://bugs.webkit.org/show_bug.cgi?id=106714
+
+Reviewed by Tony Chang.
+
+There's no reason for so many methods just to compare some enums.
+The existing code can also be simplified quite a bit.
+
+No new tests, just refactoring.
+
+* css/SelectorChecker.cpp:
+(WebCore::SelectorChecker::checkOne):
+* css/StyleResolver.cpp:
+(WebCore::StyleResolver::collectMatchingRules):
+(WebCore::StyleResolver::canShareStyleWithElement):
+* dom/Element.cpp:
+(WebCore::Element::webVTTNodeType):
+(WebCore::Element::setWebVTTNodeType):
+* dom/Element.h:
+(Element):
+* dom/ElementRareData.h:
+(WebCore::ElementRareData::setWebVTTNodeType):
+(WebCore::ElementRareData::webVTTNodeType):
+(ElementRareData):
+* dom/NodeRareData.h:
+(WebCore::NodeRareData::NodeRareData):
+(NodeRareData):
+* html/track/TextTrack.h:
+* html/track/TextTrackCue.cpp:
+(WebCore::TextTrackCue::markFutureAndPastNodes):
+
 2013-01-14  Antti Koivisto  an...@apple.com
 
 REGRESSION (r139218): Flaky assertion in WebCore::StorageTask::StorageTask releasing memory


Modified: trunk/Source/WebCore/css/SelectorChecker.cpp (139638 => 139639)

--- trunk/Source/WebCore/css/SelectorChecker.cpp	2013-01-14 20:16:57 UTC (rev 139638)
+++ trunk/Source/WebCore/css/SelectorChecker.cpp	2013-01-14 20:17:58 UTC (rev 139639)
@@ -941,9 +941,7 @@
 return element-isOutOfRange();
 #if ENABLE(VIDEO_TRACK)
 case CSSSelector::PseudoFutureCue:
-if (element-isWebVTTFutureNode())
-return true;
-return false;
+return element-webVTTNodeType() == WebVTTNodeTypeFuture;
 #endif
 
 case CSSSelector::PseudoHorizontal:


Modified: trunk/Source/WebCore/css/StyleResolver.cpp (139638 => 139639)

--- trunk/Source/WebCore/css/StyleResolver.cpp	2013-01-14 20:16:57 UTC (rev 139638)
+++ trunk/Source/WebCore/css/StyleResolver.cpp	2013-01-14 20:17:58 UTC (rev 139639)
@@ -654,7 +654,7 @@
 }
 
 #if ENABLE(VIDEO_TRACK)
-if (m_element-isWebVTTNode())
+if (m_element-webVTTNodeType())
 collectMatchingRulesForList(rules-cuePseudoRules(), firstRuleIndex, lastRuleIndex, options);
 #endif
 // Check whether other types of rules are applicable in the current tree scope. Criteria for this:
@@ -1241,11 +1241,8 @@
 return false;
 
 #if ENABLE(VIDEO_TRACK)
-if (element-isWebVTTNode()  m_element-isWebVTTNode()  element-isWebVTTFutureNode() != m_element-isWebVTTFutureNode())
+if (element-webVTTNodeType() != m_element-webVTTNodeType())
 return false;
-// Deny sharing styles between WebVTT nodes and non-WebVTT nodes.
-if (element-isWebVTTNode() != m_element-isWebVTTNode())
-return false;
 #endif
 
 return true;


Modified: trunk/Source/WebCore/dom/Element.cpp (139638 => 139639)

--- trunk/Source/WebCore/dom/Element.cpp	2013-01-14 20:16:57 UTC (rev 139638)
+++ trunk/Source/WebCore/dom/Element.cpp	2013-01-14 20:17:58 UTC (rev 139639)
@@ -2308,25 +2308,15 @@
 #endif
 
 #if ENABLE(VIDEO_TRACK)
-bool Element::isWebVTTNode() const
+WebVTTNodeType 

[webkit-changes] [139640] branches/chromium/1364

[kbr]

Title: [139640] branches/chromium/1364








Revision 139640
Author k...@google.com
Date 2013-01-14 12:23:02 -0800 (Mon, 14 Jan 2013)


Log Message
Merge 139459
 [Chromium] WebGL typed array constructor crashes on exception
 https://bugs.webkit.org/show_bug.cgi?id=106308
 
 Reviewed by Kentaro Hara.
 
 Source/WebCore:
 
 Check for empty handles (indicating exception thrown) after calls
 into V8 VM.
 
 Added new case from Khronos typed array conformance tests to
 fast/canvas/webgl/array-unit-tests.html.
 
 * bindings/v8/custom/V8ArrayBufferViewCustom.h:
 (WebCore::constructWebGLArray):
 Check for empty handles after calls into V8 VM.
 
 LayoutTests:
 
 Updated typed array tests to latest version from Khronos repository.
 
 * fast/canvas/webgl/array-unit-tests-expected.txt:
 * fast/canvas/webgl/array-unit-tests.html:
 

TBR=k...@google.com
Review URL: https://codereview.chromium.org/11889014

Modified Paths

branches/chromium/1364/LayoutTests/fast/canvas/webgl/array-unit-tests-expected.txt
branches/chromium/1364/LayoutTests/fast/canvas/webgl/array-unit-tests.html
branches/chromium/1364/Source/WebCore/bindings/v8/custom/V8ArrayBufferViewCustom.h




Diff

Modified: branches/chromium/1364/LayoutTests/fast/canvas/webgl/array-unit-tests-expected.txt (139639 => 139640)

--- branches/chromium/1364/LayoutTests/fast/canvas/webgl/array-unit-tests-expected.txt	2013-01-14 20:17:58 UTC (rev 139639)
+++ branches/chromium/1364/LayoutTests/fast/canvas/webgl/array-unit-tests-expected.txt	2013-01-14 20:23:02 UTC (rev 139640)
@@ -37,6 +37,7 @@
 PASS Construction of Float32Array with null buffer threw exception
 PASS Construction of Float32Array with (null buffer, 0) threw exception
 PASS Construction of Float32Array with (null buffer, 0, 0) threw exception
+PASS Construction of Float32Array with exception-throwing array-like object didn't crash unexpectedly
 PASS Construction of Float32Array with out-of-range number of elements threw an exception
 PASS Construction of Float32Array with out-of-range offset threw an exception
 PASS Construction of ArrayBuffer with negative size threw exception
@@ -92,6 +93,7 @@
 PASS Construction of Float64Array with null buffer threw exception
 PASS Construction of Float64Array with (null buffer, 0) threw exception
 PASS Construction of Float64Array with (null buffer, 0, 0) threw exception
+PASS Construction of Float64Array with exception-throwing array-like object didn't crash unexpectedly
 PASS Construction of Float64Array with out-of-range number of elements threw an exception
 PASS Construction of Float64Array with out-of-range offset threw an exception
 PASS Construction of ArrayBuffer with negative size threw exception
@@ -148,6 +150,7 @@
 PASS Construction of Int8Array with null buffer threw exception
 PASS Construction of Int8Array with (null buffer, 0) threw exception
 PASS Construction of Int8Array with (null buffer, 0, 0) threw exception
+PASS Construction of Int8Array with exception-throwing array-like object didn't crash unexpectedly
 PASS Construction of Int8Array with out-of-range number of elements threw an exception
 PASS Construction of Int8Array with out-of-range offset threw an exception
 PASS Construction of ArrayBuffer with negative size threw exception
@@ -199,6 +202,7 @@
 PASS Construction of Int16Array with null buffer threw exception
 PASS Construction of Int16Array with (null buffer, 0) threw exception
 PASS Construction of Int16Array with (null buffer, 0, 0) threw exception
+PASS Construction of Int16Array with exception-throwing array-like object didn't crash unexpectedly
 PASS Construction of Int16Array with out-of-range number of elements threw an exception
 PASS Construction of Int16Array with out-of-range offset threw an exception
 PASS Construction of ArrayBuffer with negative size threw exception
@@ -255,6 +259,7 @@
 PASS Construction of Int32Array with null buffer threw exception
 PASS Construction of Int32Array with (null buffer, 0) threw exception
 PASS Construction of Int32Array with (null buffer, 0, 0) threw exception
+PASS Construction of Int32Array with exception-throwing array-like object didn't crash unexpectedly
 PASS Construction of Int32Array with out-of-range number of elements threw an exception
 PASS Construction of Int32Array with out-of-range offset threw an exception
 PASS Construction of ArrayBuffer with negative size threw exception
@@ -311,6 +316,7 @@
 PASS Construction of Uint8Array with null buffer threw exception
 PASS Construction of Uint8Array with (null buffer, 0) threw exception
 PASS Construction of Uint8Array with (null buffer, 0, 0) threw exception
+PASS Construction of Uint8Array with exception-throwing array-like object didn't crash unexpectedly
 PASS Construction of Uint8Array with out-of-range number of elements threw an exception
 PASS Construction of Uint8Array with out-of-range offset threw an exception
 PASS Construction of ArrayBuffer with negative size threw exception
@@ -362,6 +368,7 @@
 PASS Construction of 

[webkit-changes] [139641] trunk/Source/WebCore

[jsbell]

Title: [139641] trunk/Source/WebCore








Revision 139641
Author jsb...@chromium.org
Date 2013-01-14 12:25:26 -0800 (Mon, 14 Jan 2013)


Log Message
Bindings: Remove special cases for DOMString[]
https://bugs.webkit.org/show_bug.cgi?id=106506

Remove special in binding code generators that map DOMString[] to DOMStringList.
Array (T[]) and sequence (sequenceT) are supported enough now that to be used
for Internals, which is the only IDL that needed updating.

Reviewed by Adam Barth.

Tests: fast/forms/file/selected-files-from-history-state.html
   fast/forms/state-restore-broken-state.html
   fast/forms/state-restore-skip-stateless.html

Bindings test results updated for JS/V8.

* bindings/scripts/CodeGenerator.pm: Remove redundant IsArrayType (use GetArrayType instead)
(IsRefPtrType): Array and Sequence types are not RefPtr types.
* bindings/scripts/CodeGeneratorJS.pm:
(IndexGetterReturnsStrings): Remove special case for DOMString[].
(AddIncludesForType): Skip Array types, just like Sequence types. (Should probably recurse
for the base type, but not needed for now.)
(GenerateParametersCheckExpression): s/IsArrayType/GetArrayType/
(GetNativeType): Remove special case for DOMString[].
(GetNativeTypeForCallbacks): Ditto.
(JSValueToNative): Ditto.
* bindings/scripts/CodeGeneratorV8.pm:
(GenerateParametersCheckExpression): s/IsArrayType/GetArrayType/
(GetNativeType): Remove special case for DOMString[].
(JSValueToNative): Ditto.
(GetV8HeaderName): Ditto.
(IsWrapperType):
* bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod7):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod9):
(WebCore::jsTestObjPrototypeFunctionStringArrayFunction):
(WebCore::jsTestObjPrototypeFunctionDomStringListFunction):
* bindings/scripts/test/JS/JSTestObj.h:
(WebCore):
* bindings/scripts/test/TestObj.idl: Added explicit new cases for DOMStringList
* bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::TestObjV8Internal::overloadedMethod7Callback):
(WebCore::TestObjV8Internal::overloadedMethod9Callback):
(WebCore::TestObjV8Internal::stringArrayFunctionCallback):
(TestObjV8Internal):
(WebCore::TestObjV8Internal::domStringListFunctionCallback):
(WebCore):
(WebCore::ConfigureV8TestObjTemplate):
* testing/Internals.cpp:
(WebCore::Internals::formControlStateOfPreviousHistoryItem):
(WebCore::Internals::setFormControlStateOfPreviousHistoryItem):
(WebCore::Internals::iconURLs):
(WebCore::Internals::getReferencedFilePaths):
* testing/Internals.h:
(Internals):
* testing/Internals.idl: Produce DOMString[], consume sequenceDOMString to match tests.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/scripts/CodeGenerator.pm
trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm
trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm
trunk/Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp
trunk/Source/WebCore/bindings/scripts/test/JS/JSTestObj.h
trunk/Source/WebCore/bindings/scripts/test/TestObj.idl
trunk/Source/WebCore/bindings/scripts/test/V8/V8TestObj.cpp
trunk/Source/WebCore/testing/Internals.cpp
trunk/Source/WebCore/testing/Internals.h
trunk/Source/WebCore/testing/Internals.idl




Diff

Modified: trunk/Source/WebCore/ChangeLog (139640 => 139641)

--- trunk/Source/WebCore/ChangeLog	2013-01-14 20:23:02 UTC (rev 139640)
+++ trunk/Source/WebCore/ChangeLog	2013-01-14 20:25:26 UTC (rev 139641)
@@ -1,3 +1,62 @@
+2013-01-14  Joshua Bell  jsb...@chromium.org
+
+Bindings: Remove special cases for DOMString[]
+https://bugs.webkit.org/show_bug.cgi?id=106506
+
+Remove special in binding code generators that map DOMString[] to DOMStringList.
+Array (T[]) and sequence (sequenceT) are supported enough now that to be used
+for Internals, which is the only IDL that needed updating.
+
+Reviewed by Adam Barth.
+
+Tests: fast/forms/file/selected-files-from-history-state.html
+   fast/forms/state-restore-broken-state.html
+   fast/forms/state-restore-skip-stateless.html
+
+Bindings test results updated for JS/V8.
+
+* bindings/scripts/CodeGenerator.pm: Remove redundant IsArrayType (use GetArrayType instead)
+(IsRefPtrType): Array and Sequence types are not RefPtr types.
+* bindings/scripts/CodeGeneratorJS.pm:
+(IndexGetterReturnsStrings): Remove special case for DOMString[].
+(AddIncludesForType): Skip Array types, just like Sequence types. (Should probably recurse
+for the base type, but not needed for now.)
+(GenerateParametersCheckExpression): s/IsArrayType/GetArrayType/
+(GetNativeType): Remove special case for DOMString[].
+(GetNativeTypeForCallbacks): Ditto.
+(JSValueToNative): Ditto.
+* bindings/scripts/CodeGeneratorV8.pm:
+(GenerateParametersCheckExpression): s/IsArrayType/GetArrayType/
+(GetNativeType): Remove special case for DOMString[].
+(JSValueToNative): 

[webkit-changes] [139643] trunk

[commit-queue]

Title: [139643] trunk








Revision 139643
Author commit-qu...@webkit.org
Date 2013-01-14 12:42:26 -0800 (Mon, 14 Jan 2013)


Log Message
Do not hardcode -ldl in OPENGL_LIBS
https://bugs.webkit.org/show_bug.cgi?id=96602

Patch by Alexandre Rostovtsev tetrom...@gentoo.org on 2013-01-14
Reviewed by Philippe Normand.

Some non-Linux systems, e.g. FreeBSD, have dlopen() as part of their
libc, and do not use a separate libdl.

* configure.ac:

Modified Paths

trunk/ChangeLog
trunk/configure.ac




Diff

Modified: trunk/ChangeLog (139642 => 139643)

--- trunk/ChangeLog	2013-01-14 20:35:36 UTC (rev 139642)
+++ trunk/ChangeLog	2013-01-14 20:42:26 UTC (rev 139643)
@@ -1,3 +1,15 @@
+2013-01-14  Alexandre Rostovtsev  tetrom...@gentoo.org
+
+Do not hardcode -ldl in OPENGL_LIBS
+https://bugs.webkit.org/show_bug.cgi?id=96602
+
+Reviewed by Philippe Normand.
+
+Some non-Linux systems, e.g. FreeBSD, have dlopen() as part of their
+libc, and do not use a separate libdl.
+
+* configure.ac:
+
 2013-01-11  Carlos Garcia Campos  cgar...@igalia.com
 
 Unreviewed. Update NEWS and configure.ac for 1.11.4 release


Modified: trunk/configure.ac (139642 => 139643)

--- trunk/configure.ac	2013-01-14 20:35:36 UTC (rev 139642)
+++ trunk/configure.ac	2013-01-14 20:42:26 UTC (rev 139643)
@@ -281,6 +281,12 @@
 AC_SUBST([OLE32_LIBS])
 
 
+# check whether dlopen() is in the core libc like on FreeBSD, or in a separate
+# libdl like on GNU/Linux (in which case we want to link to libdl)
+AC_CHECK_FUNC([dlopen], [], [AC_CHECK_LIB([dl], [dlopen], [DLOPEN_LIBS=-ldl])])
+AC_SUBST([DLOPEN_LIBS])
+
+
 # determine the GTK+ version to use
 AC_MSG_CHECKING([the GTK+ version to use])
 AC_ARG_WITH([gtk],
@@ -1028,7 +1034,7 @@
if test $enable_glx = yes; then
 acceleration_backend_description+=, glx
fi
-   OPENGL_LIBS+= -ldl
+   OPENGL_LIBS+= $DLOPEN_LIBS
acceleration_backend_description+=)
 fi
 AC_SUBST([OPENGL_LIBS])






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [139642] trunk/Source/WebCore

[commit-queue]

Title: [139642] trunk/Source/WebCore








Revision 139642
Author commit-qu...@webkit.org
Date 2013-01-14 12:35:36 -0800 (Mon, 14 Jan 2013)


Log Message
Use correct size for DrawingBuffer readback
https://bugs.webkit.org/show_bug.cgi?id=106744

Patch by John Bauman jbau...@chromium.org on 2013-01-14
Reviewed by Kenneth Russell.

The value getInternalFramebufferSize is bogus if there's a
DrawingBuffer, so use size() instead.

* platform/graphics/chromium/DrawingBufferChromium.cpp:
(WebCore::DrawingBuffer::paintCompositedResultsToCanvas):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/chromium/DrawingBufferChromium.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (139641 => 139642)

--- trunk/Source/WebCore/ChangeLog	2013-01-14 20:25:26 UTC (rev 139641)
+++ trunk/Source/WebCore/ChangeLog	2013-01-14 20:35:36 UTC (rev 139642)
@@ -1,3 +1,16 @@
+2013-01-14  John Bauman  jbau...@chromium.org
+
+Use correct size for DrawingBuffer readback
+https://bugs.webkit.org/show_bug.cgi?id=106744
+
+Reviewed by Kenneth Russell.
+
+The value getInternalFramebufferSize is bogus if there's a
+DrawingBuffer, so use size() instead.
+
+* platform/graphics/chromium/DrawingBufferChromium.cpp:
+(WebCore::DrawingBuffer::paintCompositedResultsToCanvas):
+
 2013-01-14  Joshua Bell  jsb...@chromium.org
 
 Bindings: Remove special cases for DOMString[]


Modified: trunk/Source/WebCore/platform/graphics/chromium/DrawingBufferChromium.cpp (139641 => 139642)

--- trunk/Source/WebCore/platform/graphics/chromium/DrawingBufferChromium.cpp	2013-01-14 20:25:26 UTC (rev 139641)
+++ trunk/Source/WebCore/platform/graphics/chromium/DrawingBufferChromium.cpp	2013-01-14 20:35:36 UTC (rev 139642)
@@ -234,8 +234,6 @@
 if (!m_context-makeContextCurrent() || m_context-getExtensions()-getGraphicsResetStatusARB() != GraphicsContext3D::NO_ERROR)
 return;
 
-IntSize framebufferSize = m_context-getInternalFramebufferSize();
-
 // Since we're using the same context as WebGL, we have to restore any state we change (in this case, just the framebuffer binding).
 // FIXME: The WebGLRenderingContext tracks the current framebuffer binding, it would be slightly more efficient to use this value
 // rather than querying it off of the context.
@@ -247,7 +245,7 @@
 m_context-framebufferTexture2D(GraphicsContext3D::FRAMEBUFFER, GraphicsContext3D::COLOR_ATTACHMENT0, GraphicsContext3D::TEXTURE_2D, frontColorBuffer(), 0);
 
 Extensions3DChromium* extensions = static_castExtensions3DChromium*(m_context-getExtensions());
-extensions-paintFramebufferToCanvas(framebuffer, framebufferSize.width(), framebufferSize.height(), !m_context-getContextAttributes().premultipliedAlpha, imageBuffer);
+extensions-paintFramebufferToCanvas(framebuffer, size().width(), size().height(), !m_context-getContextAttributes().premultipliedAlpha, imageBuffer);
 m_context-deleteFramebuffer(framebuffer);
 
 m_context-bindFramebuffer(GraphicsContext3D::FRAMEBUFFER, previousFramebuffer);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [139645] branches/chromium/1312/Source/WebCore/dom/Document.cpp

[cevans]

Title: [139645] branches/chromium/1312/Source/WebCore/dom/Document.cpp








Revision 139645
Author cev...@google.com
Date 2013-01-14 13:03:26 -0800 (Mon, 14 Jan 2013)


Log Message
Merge 139470
BUG=146145
Review URL: https://codereview.chromium.org/11889015

Modified Paths

branches/chromium/1312/Source/WebCore/dom/Document.cpp




Diff

Modified: branches/chromium/1312/Source/WebCore/dom/Document.cpp (139644 => 139645)

--- branches/chromium/1312/Source/WebCore/dom/Document.cpp	2013-01-14 20:49:44 UTC (rev 139644)
+++ branches/chromium/1312/Source/WebCore/dom/Document.cpp	2013-01-14 21:03:26 UTC (rev 139645)
@@ -1917,16 +1917,24 @@
 void Document::updateLayout()
 {
 ASSERT(isMainThread());
+
+FrameView* frameView = view();
+if (frameView  frameView-isInLayout()) {
+// View layout should not be re-entrant.
+ASSERT_NOT_REACHED();
+return;
+}
+
 if (Element* oe = ownerElement())
 oe-document()-updateLayout();
 
 updateStyleIfNeeded();
 
 StackStats::LayoutCheckPoint layoutCheckPoint;
+
 // Only do a layout if changes have occurred that make it necessary.  
-FrameView* v = view();
-if (v  renderer()  (v-layoutPending() || renderer()-needsLayout()))
-v-layout();
+if (frameView  renderer()  (frameView-layoutPending() || renderer()-needsLayout()))
+frameView-layout();
 }
 
 // FIXME: This is a bad idea and needs to be removed eventually.






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [139646] branches/chromium/1364/Source/WebCore/dom/Document.cpp

[cevans]

Title: [139646] branches/chromium/1364/Source/WebCore/dom/Document.cpp








Revision 139646
Author cev...@google.com
Date 2013-01-14 13:04:32 -0800 (Mon, 14 Jan 2013)


Log Message
Merge 139470
BUG=146145
Review URL: https://codereview.chromium.org/11891002

Modified Paths

branches/chromium/1364/Source/WebCore/dom/Document.cpp




Diff

Modified: branches/chromium/1364/Source/WebCore/dom/Document.cpp (139645 => 139646)

--- branches/chromium/1364/Source/WebCore/dom/Document.cpp	2013-01-14 21:03:26 UTC (rev 139645)
+++ branches/chromium/1364/Source/WebCore/dom/Document.cpp	2013-01-14 21:04:32 UTC (rev 139646)
@@ -1912,16 +1912,24 @@
 void Document::updateLayout()
 {
 ASSERT(isMainThread());
+
+FrameView* frameView = view();
+if (frameView  frameView-isInLayout()) {
+// View layout should not be re-entrant.
+ASSERT_NOT_REACHED();
+return;
+}
+
 if (Element* oe = ownerElement())
 oe-document()-updateLayout();
 
 updateStyleIfNeeded();
 
 StackStats::LayoutCheckPoint layoutCheckPoint;
+
 // Only do a layout if changes have occurred that make it necessary.  
-FrameView* v = view();
-if (v  renderer()  (v-layoutPending() || renderer()-needsLayout()))
-v-layout();
+if (frameView  renderer()  (frameView-layoutPending() || renderer()-needsLayout()))
+frameView-layout();
 }
 
 // FIXME: This is a bad idea and needs to be removed eventually.






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [139647] branches/chromium/1312/Source/WebCore/page/FrameView.cpp

[cevans]

Title: [139647] branches/chromium/1312/Source/WebCore/page/FrameView.cpp








Revision 139647
Author cev...@google.com
Date 2013-01-14 13:08:32 -0800 (Mon, 14 Jan 2013)


Log Message
Merge 139365
BUG=153184
Review URL: https://codereview.chromium.org/11889016

Modified Paths

branches/chromium/1312/Source/WebCore/page/FrameView.cpp




Diff

Modified: branches/chromium/1312/Source/WebCore/page/FrameView.cpp (139646 => 139647)

--- branches/chromium/1312/Source/WebCore/page/FrameView.cpp	2013-01-14 21:04:32 UTC (rev 139646)
+++ branches/chromium/1312/Source/WebCore/page/FrameView.cpp	2013-01-14 21:08:32 UTC (rev 139647)
@@ -3057,6 +3057,9 @@
 
 FrameView* FrameView::parentFrameView() const
 {
+if (!parent())
+return 0;
+
 if (Frame* parentFrame = m_frame-tree()-parent())
 return parentFrame-view();
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [139648] branches/chromium/1364/Source/WebCore/page/FrameView.cpp

[cevans]

Title: [139648] branches/chromium/1364/Source/WebCore/page/FrameView.cpp








Revision 139648
Author cev...@google.com
Date 2013-01-14 13:11:15 -0800 (Mon, 14 Jan 2013)


Log Message
Merge 139365
BUG=153184
Review URL: https://codereview.chromium.org/11885028

Modified Paths

branches/chromium/1364/Source/WebCore/page/FrameView.cpp




Diff

Modified: branches/chromium/1364/Source/WebCore/page/FrameView.cpp (139647 => 139648)

--- branches/chromium/1364/Source/WebCore/page/FrameView.cpp	2013-01-14 21:08:32 UTC (rev 139647)
+++ branches/chromium/1364/Source/WebCore/page/FrameView.cpp	2013-01-14 21:11:15 UTC (rev 139648)
@@ -3102,6 +3102,9 @@
 
 FrameView* FrameView::parentFrameView() const
 {
+if (!parent())
+return 0;
+
 if (Frame* parentFrame = m_frame-tree()-parent())
 return parentFrame-view();
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [139650] trunk/Source/WebCore

[commit-queue]

Title: [139650] trunk/Source/WebCore








Revision 139650
Author commit-qu...@webkit.org
Date 2013-01-14 13:14:31 -0800 (Mon, 14 Jan 2013)


Log Message
[GTK] Fix indentation for GStreamer supported MIME types list
https://bugs.webkit.org/show_bug.cgi?id=106812

Patch by Adrian Perez de Castro ape...@igalia.com on 2013-01-14
Reviewed by Philippe Normand.

No tests. No change in behavior.

* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (139649 => 139650)

--- trunk/Source/WebCore/ChangeLog	2013-01-14 21:11:25 UTC (rev 139649)
+++ trunk/Source/WebCore/ChangeLog	2013-01-14 21:14:31 UTC (rev 139650)
@@ -1,3 +1,14 @@
+2013-01-14  Adrian Perez de Castro  ape...@igalia.com
+
+[GTK] Fix indentation for GStreamer supported MIME types list
+https://bugs.webkit.org/show_bug.cgi?id=106812
+
+Reviewed by Philippe Normand.
+
+No tests. No change in behavior.
+
+* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
+
 2013-01-14  John Bauman  jbau...@chromium.org
 
 Use correct size for DrawingBuffer readback


Modified: trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp (139649 => 139650)

--- trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp	2013-01-14 21:11:25 UTC (rev 139649)
+++ trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp	2013-01-14 21:14:31 UTC (rev 139650)
@@ -1614,91 +1614,94 @@
 
 if (typeListInitialized)
 return cache;
-const char* mimeTypes[] = {application/ogg,
-   application/vnd.apple.mpegurl,
-   application/vnd.rn-realmedia,
-   application/x-3gp,
-   application/x-pn-realaudio,
-   audio/3gpp,
-   audio/aac,
-   audio/flac,
-   audio/iLBC-sh,
-   audio/midi,
-   audio/mobile-xmf,
-   audio/mp1,
-   audio/mp2,
-   audio/mp3,
-   audio/mp4,
-   audio/mpeg,
-   audio/ogg,
-   audio/qcelp,
-   audio/riff-midi,
-   audio/wav,
-   audio/webm,
-   audio/x-ac3,
-   audio/x-aiff,
-   audio/x-amr-nb-sh,
-   audio/x-amr-wb-sh,
-   audio/x-au,
-   audio/x-ay,
-   audio/x-celt,
-   audio/x-dts,
-   audio/x-flac,
-   audio/x-gbs,
-   audio/x-gsm,
-   audio/x-gym,
-   audio/x-imelody,
-   audio/x-ircam,
-   audio/x-kss,
-   audio/x-m4a,
-   audio/x-mod,
-   audio/x-mp3,
-   audio/x-mpeg,
-   audio/x-musepack,
-   audio/x-nist,
-   audio/x-nsf,
-   audio/x-paris,
-   audio/x-sap,
-   audio/x-sbc,
-   audio/x-sds,
-   audio/x-shorten,
-   audio/x-sid,
-   audio/x-spc,
-   audio/x-speex,
-   audio/x-svx,
-   audio/x-ttafile,
-   audio/x-vgm,
-   audio/x-voc,
-   audio/x-vorbis+ogg,
-   audio/x-w64,
-   audio/x-wav,
-   audio/x-wavpack,
-   audio/x-wavpack-correction,
-   video/3gpp,
-   video/mj2,
-   video/mp4,
-   video/mpeg,
-   video/mpegts,
-   video/ogg,
-   video/quicktime,
-   video/vivo,
-   video/webm,
-   video/x-cdxa,
-   

[webkit-changes] [139651] branches/chromium/1364/Source/WebCore/rendering/InlineIterator.h

[cevans]

Title: [139651] branches/chromium/1364/Source/WebCore/rendering/InlineIterator.h








Revision 139651
Author cev...@google.com
Date 2013-01-14 13:16:15 -0800 (Mon, 14 Jan 2013)


Log Message
Merge 139213
BUG=156096
Review URL: https://codereview.chromium.org/11886025

Modified Paths

branches/chromium/1364/Source/WebCore/rendering/InlineIterator.h




Diff

Modified: branches/chromium/1364/Source/WebCore/rendering/InlineIterator.h (139650 => 139651)

--- branches/chromium/1364/Source/WebCore/rendering/InlineIterator.h	2013-01-14 21:14:31 UTC (rev 139650)
+++ branches/chromium/1364/Source/WebCore/rendering/InlineIterator.h	2013-01-14 21:16:15 UTC (rev 139651)
@@ -85,6 +85,7 @@
 return (m_obj  m_obj-isBR()) || atTextParagraphSeparator();
 }
 
+UChar characterAt(unsigned) const;
 UChar current() const;
 UChar previousInSameNode() const;
 ALWAYS_INLINE WTF::Unicode::Direction direction() const;
@@ -352,25 +353,29 @@
 return !m_obj;
 }
 
-inline UChar InlineIterator::current() const
+inline UChar InlineIterator::characterAt(unsigned index) const
 {
 if (!m_obj || !m_obj-isText())
 return 0;
 
 RenderText* text = toRenderText(m_obj);
-if (m_pos = text-textLength())
+if (index = text-textLength())
 return 0;
 
-return text-characterAt(m_pos);
+return text-characterAt(index);
 }
 
+inline UChar InlineIterator::current() const
+{
+return characterAt(m_pos);
+}
+
 inline UChar InlineIterator::previousInSameNode() const
 {
-if (!m_obj || !m_obj-isText() || !m_pos)
+if (!m_pos)
 return 0;
 
-RenderText* text = toRenderText(m_obj);
-return text-characterAt(m_pos - 1);
+return characterAt(m_pos - 1);
 }
 
 ALWAYS_INLINE WTF::Unicode::Direction InlineIterator::direction() const






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [139652] trunk/Source

[pilgrim]

Title: [139652] trunk/Source








Revision 139652
Author pilg...@chromium.org
Date 2013-01-14 13:21:37 -0800 (Mon, 14 Jan 2013)


Log Message
[Chromium] Move AudioDestinationChromium into WebCore
https://bugs.webkit.org/show_bug.cgi?id=106803

Reviewed by Adam Barth.

This doesn't really belong in WebKit/chromium/src since it defines
things directly in the WebCore namespace.

Source/WebCore:

* WebCore.gypi:
* platform/audio/chromium/AudioDestinationChromium.cpp: Added.
(WebCore):
(WebCore::AudioDestination::create):
(WebCore::AudioDestinationChromium::AudioDestinationChromium):
(WebCore::AudioDestinationChromium::~AudioDestinationChromium):
(WebCore::AudioDestinationChromium::start):
(WebCore::AudioDestinationChromium::stop):
(WebCore::AudioDestination::hardwareSampleRate):
(WebCore::AudioDestinationChromium::render):
(WebCore::AudioDestinationChromium::provideInput):
* platform/audio/chromium/AudioDestinationChromium.h: Added.
(WebCore):
(AudioDestinationChromium):
(WebCore::AudioDestinationChromium::isPlaying):
(WebCore::AudioDestinationChromium::sampleRate):

Source/WebKit/chromium:

* WebKit.gyp:
* src/AudioDestinationChromium.cpp: Removed.
* src/AudioDestinationChromium.h: Removed.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/WebCore.gypi
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/WebKit.gyp


Added Paths

trunk/Source/WebCore/platform/audio/chromium/AudioDestinationChromium.cpp
trunk/Source/WebCore/platform/audio/chromium/AudioDestinationChromium.h


Removed Paths

trunk/Source/WebKit/chromium/src/AudioDestinationChromium.cpp
trunk/Source/WebKit/chromium/src/AudioDestinationChromium.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (139651 => 139652)

--- trunk/Source/WebCore/ChangeLog	2013-01-14 21:16:15 UTC (rev 139651)
+++ trunk/Source/WebCore/ChangeLog	2013-01-14 21:21:37 UTC (rev 139652)
@@ -1,3 +1,30 @@
+2013-01-14  Mark Pilgrim  pilg...@chromium.org
+
+[Chromium] Move AudioDestinationChromium into WebCore
+https://bugs.webkit.org/show_bug.cgi?id=106803
+
+Reviewed by Adam Barth.
+
+This doesn't really belong in WebKit/chromium/src since it defines
+things directly in the WebCore namespace.
+
+* WebCore.gypi:
+* platform/audio/chromium/AudioDestinationChromium.cpp: Added.
+(WebCore):
+(WebCore::AudioDestination::create):
+(WebCore::AudioDestinationChromium::AudioDestinationChromium):
+(WebCore::AudioDestinationChromium::~AudioDestinationChromium):
+(WebCore::AudioDestinationChromium::start):
+(WebCore::AudioDestinationChromium::stop):
+(WebCore::AudioDestination::hardwareSampleRate):
+(WebCore::AudioDestinationChromium::render):
+(WebCore::AudioDestinationChromium::provideInput):
+* platform/audio/chromium/AudioDestinationChromium.h: Added.
+(WebCore):
+(AudioDestinationChromium):
+(WebCore::AudioDestinationChromium::isPlaying):
+(WebCore::AudioDestinationChromium::sampleRate):
+
 2013-01-14  Adrian Perez de Castro  ape...@igalia.com
 
 [GTK] Fix indentation for GStreamer supported MIME types list


Modified: trunk/Source/WebCore/WebCore.gypi (139651 => 139652)

--- trunk/Source/WebCore/WebCore.gypi	2013-01-14 21:16:15 UTC (rev 139651)
+++ trunk/Source/WebCore/WebCore.gypi	2013-01-14 21:21:37 UTC (rev 139652)
@@ -3616,6 +3616,8 @@
 'platform/audio/ZeroPole.cpp',
 'platform/audio/ZeroPole.h',
 'platform/audio/chromium/AudioBusChromium.cpp',
+'platform/audio/chromium/AudioDestinationChromium.cpp',
+'platform/audio/chromium/AudioDestinationChromium.h',
 'platform/audio/mac/AudioBusMac.mm',
 'platform/audio/mac/AudioDestinationMac.cpp',
 'platform/audio/mac/AudioDestinationMac.h',


Copied: trunk/Source/WebCore/platform/audio/chromium/AudioDestinationChromium.cpp (from rev 139650, trunk/Source/WebKit/chromium/src/AudioDestinationChromium.cpp) (0 => 139652)

--- trunk/Source/WebCore/platform/audio/chromium/AudioDestinationChromium.cpp	(rev 0)
+++ trunk/Source/WebCore/platform/audio/chromium/AudioDestinationChromium.cpp	2013-01-14 21:21:37 UTC (rev 139652)
@@ -0,0 +1,160 @@
+/*
+ * Copyright (C) 2010 Google Inc. All rights reserved.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions
+ * are met:
+ *
+ * 1.  Redistributions of source code must retain the above copyright
+ * notice, this list of conditions and the following disclaimer.
+ * 2.  Redistributions in binary form must reproduce the above copyright
+ * notice, this list of conditions and the following disclaimer in the
+ * documentation and/or other materials provided with the distribution.
+ * 3.  Neither the name of Apple Computer, Inc. (Apple) nor the names of
+ * its contributors may 

[webkit-changes] [139653] branches/chromium/1364

[cevans]

Title: [139653] branches/chromium/1364








Revision 139653
Author cev...@google.com
Date 2013-01-14 13:22:23 -0800 (Mon, 14 Jan 2013)


Log Message
Merge 138988
BUG=138988
Review URL: https://codereview.chromium.org/11876028

Modified Paths

branches/chromium/1364/Source/WebCore/rendering/RenderBlock.cpp


Added Paths

branches/chromium/1364/LayoutTests/fast/multicol/recursive-split-flow-crash-expected.txt
branches/chromium/1364/LayoutTests/fast/multicol/recursive-split-flow-crash.html




Diff

Copied: branches/chromium/1364/LayoutTests/fast/multicol/recursive-split-flow-crash-expected.txt (from rev 138988, trunk/LayoutTests/fast/multicol/recursive-split-flow-crash-expected.txt) (0 => 139653)

--- branches/chromium/1364/LayoutTests/fast/multicol/recursive-split-flow-crash-expected.txt	(rev 0)
+++ branches/chromium/1364/LayoutTests/fast/multicol/recursive-split-flow-crash-expected.txt	2013-01-14 21:22:23 UTC (rev 139653)
@@ -0,0 +1,3 @@
+Bug 101984: Heap-buffer-overflow in WebCore::RenderBlock::clone.
+Test passes if it does not crash.
+


Copied: branches/chromium/1364/LayoutTests/fast/multicol/recursive-split-flow-crash.html (from rev 138988, trunk/LayoutTests/fast/multicol/recursive-split-flow-crash.html) (0 => 139653)

--- branches/chromium/1364/LayoutTests/fast/multicol/recursive-split-flow-crash.html	(rev 0)
+++ branches/chromium/1364/LayoutTests/fast/multicol/recursive-split-flow-crash.html	2013-01-14 21:22:23 UTC (rev 139653)
@@ -0,0 +1,34 @@
+!DOCTYPE html
+html
+Bug 101984: Heap-buffer-overflow in WebCore::RenderBlock::clone.br /
+Test passes if it does not crash.
+body
+table
+div class=container
+div class=testClass id=test1
+/div
+div class=testClass
+div
+i id=test2/i
+/div
+/div
+/div
+/table
+script
+if (window.testRunner)
+testRunner.dumpAsText();
+
+document.head.appendChild(document.createElement(style));
+var styleSheet0 = document.styleSheets[0];
+var test1 = document.getElementById(test1);
+var test2 = document.getElementById(test2);
+
+
+document.execCommand(SelectAll, true);
+styleSheet0.insertRule('.testClass { -webkit-column-span: all ; }', 0);
+test1.appendChild(test2);
+styleSheet0.insertRule('.testClass::first-letter { border-style: none; }', 0);
+styleSheet0.insertRule('.container { -webkit-column-axis: vertical; }', 0);
+/script
+/body
+/html
\ No newline at end of file


Modified: branches/chromium/1364/Source/WebCore/rendering/RenderBlock.cpp (139652 => 139653)

--- branches/chromium/1364/Source/WebCore/rendering/RenderBlock.cpp	2013-01-14 21:21:37 UTC (rev 139652)
+++ branches/chromium/1364/Source/WebCore/rendering/RenderBlock.cpp	2013-01-14 21:22:23 UTC (rev 139653)
@@ -70,6 +70,7 @@
 #include wtf/MemoryInstrumentationHashMap.h
 #include wtf/MemoryInstrumentationHashSet.h
 #include wtf/MemoryInstrumentationListHashSet.h
+#include wtf/TemporaryChange.h
 
 using namespace std;
 using namespace WTF;
@@ -117,6 +118,8 @@
 static int gDelayUpdateScrollInfo = 0;
 static DelayedUpdateScrollInfoSet* gDelayedUpdateScrollInfoSet = 0;
 
+static bool gIsInColumnFlowSplit = false;
+
 bool RenderBlock::s_canPropagateFloatIntoSibling = false;
 
 // This class helps dispatching the 'overflow' event on layout change. overflow can be set on RenderBoxes, yet the existing code
@@ -829,30 +832,33 @@
 beforeChild = beforeChild-nextSibling();
 
 // Check for a spanning element in columns.
-RenderBlock* columnsBlockAncestor = columnsBlockForSpanningElement(newChild);
-if (columnsBlockAncestor) {
-// We are placing a column-span element inside a block. 
-RenderBlock* newBox = createAnonymousColumnSpanBlock();
+if (!gIsInColumnFlowSplit) {
+RenderBlock* columnsBlockAncestor = columnsBlockForSpanningElement(newChild);
+if (columnsBlockAncestor) {
+TemporaryChangebool isInColumnFlowSplit(gIsInColumnFlowSplit, true);
+// We are placing a column-span element inside a block.
+RenderBlock* newBox = createAnonymousColumnSpanBlock();
 
-if (columnsBlockAncestor != this) {
-// We are nested inside a multi-column element and are being split by the span.  We have to break up
-// our block into continuations.
-RenderBoxModelObject* oldContinuation = continuation();
+if (columnsBlockAncestor != this) {
+// We are nested inside a multi-column element and are being split by the span. We have to break up
+// our block into continuations.
+RenderBoxModelObject* oldContinuation = continuation();
 
-// When we split an anonymous block, there's no need to do any continuation hookup,
-// since we haven't actually split a real element.
-if (!isAnonymousBlock())
-setContinuation(newBox);
+// When we split an anonymous block, there's no need to do any continuation hookup,
+// since 

[webkit-changes] [139655] trunk/Source/WebKit2

[ap]

Title: [139655] trunk/Source/WebKit2








Revision 139655
Author a...@apple.com
Date 2013-01-14 13:31:12 -0800 (Mon, 14 Jan 2013)


Log Message
NetworkProcess scheduler never resumes resource loads that were postponed
due to connection limit
https://bugs.webkit.org/show_bug.cgi?id=106821

Reviewed by Brady Eidson.

* NetworkProcess/NetworkResourceLoadScheduler.cpp:
(WebKit::NetworkResourceLoadScheduler::servePendingRequests):
* NetworkProcess/NetworkResourceLoadScheduler.h:
Remove an uninitialized variable that could prevent loading.

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/NetworkProcess/NetworkResourceLoadScheduler.cpp
trunk/Source/WebKit2/NetworkProcess/NetworkResourceLoadScheduler.h




Diff

Modified: trunk/Source/WebKit2/ChangeLog (139654 => 139655)

--- trunk/Source/WebKit2/ChangeLog	2013-01-14 21:31:06 UTC (rev 139654)
+++ trunk/Source/WebKit2/ChangeLog	2013-01-14 21:31:12 UTC (rev 139655)
@@ -1,3 +1,16 @@
+2013-01-14  Alexey Proskuryakov  a...@apple.com
+
+NetworkProcess scheduler never resumes resource loads that were postponed
+due to connection limit
+https://bugs.webkit.org/show_bug.cgi?id=106821
+
+Reviewed by Brady Eidson.
+
+* NetworkProcess/NetworkResourceLoadScheduler.cpp:
+(WebKit::NetworkResourceLoadScheduler::servePendingRequests):
+* NetworkProcess/NetworkResourceLoadScheduler.h:
+Remove an uninitialized variable that could prevent loading.
+
 2013-01-11  Balazs Kelemen  kbal...@webkit.org
 
 [Qt][WK2] plugin tests assert in debug


Modified: trunk/Source/WebKit2/NetworkProcess/NetworkResourceLoadScheduler.cpp (139654 => 139655)

--- trunk/Source/WebKit2/NetworkProcess/NetworkResourceLoadScheduler.cpp	2013-01-14 21:31:06 UTC (rev 139654)
+++ trunk/Source/WebKit2/NetworkProcess/NetworkResourceLoadScheduler.cpp	2013-01-14 21:31:12 UTC (rev 139655)
@@ -146,9 +146,6 @@
 
 void NetworkResourceLoadScheduler::servePendingRequests(ResourceLoadPriority minimumPriority)
 {
-if (m_suspendPendingRequestsCount)
-return;
-
 LOG(NetworkScheduling, (NetworkProcess) NetworkResourceLoadScheduler::servePendingRequests Serving requests for up to %i hosts, m_hosts.size());
 
 m_requestTimer.stop();


Modified: trunk/Source/WebKit2/NetworkProcess/NetworkResourceLoadScheduler.h (139654 => 139655)

--- trunk/Source/WebKit2/NetworkProcess/NetworkResourceLoadScheduler.h	2013-01-14 21:31:06 UTC (rev 139654)
+++ trunk/Source/WebKit2/NetworkProcess/NetworkResourceLoadScheduler.h	2013-01-14 21:31:12 UTC (rev 139655)
@@ -92,7 +92,6 @@
 
 HostRecord* m_nonHTTPProtocolHost;
 
-unsigned m_suspendPendingRequestsCount;
 bool m_isSerialLoadingEnabled;
 
 WebCore::TimerNetworkResourceLoadScheduler m_requestTimer;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [139656] branches/chromium/1364

[cevans]

Title: [139656] branches/chromium/1364








Revision 139656
Author cev...@google.com
Date 2013-01-14 13:31:58 -0800 (Mon, 14 Jan 2013)


Log Message
Merge 139444
BUG=161240
Review URL: https://codereview.chromium.org/11886026

Modified Paths

branches/chromium/1364/Source/WebCore/rendering/RenderObject.cpp


Added Paths

branches/chromium/1364/LayoutTests/accessibility/corresponding-control-deleted-crash-expected.txt
branches/chromium/1364/LayoutTests/accessibility/corresponding-control-deleted-crash.html




Diff

Copied: branches/chromium/1364/LayoutTests/accessibility/corresponding-control-deleted-crash-expected.txt (from rev 139444, trunk/LayoutTests/accessibility/corresponding-control-deleted-crash-expected.txt) (0 => 139656)

--- branches/chromium/1364/LayoutTests/accessibility/corresponding-control-deleted-crash-expected.txt	(rev 0)
+++ branches/chromium/1364/LayoutTests/accessibility/corresponding-control-deleted-crash-expected.txt	2013-01-14 21:31:58 UTC (rev 139656)
@@ -0,0 +1,9 @@
+Make sure that a debug assert is not triggered when a call to RenderBlock::deleteLineBoxTree calls AccessibilityRenderObject::accessibilityIsIgnored which may require the AXObject for a node that is being deleted.
+
+On success, you will see a series of PASS messages, followed by TEST COMPLETE.
+
+
+PASS successfullyParsed is true
+
+TEST COMPLETE
+


Copied: branches/chromium/1364/LayoutTests/accessibility/corresponding-control-deleted-crash.html (from rev 139444, trunk/LayoutTests/accessibility/corresponding-control-deleted-crash.html) (0 => 139656)

--- branches/chromium/1364/LayoutTests/accessibility/corresponding-control-deleted-crash.html	(rev 0)
+++ branches/chromium/1364/LayoutTests/accessibility/corresponding-control-deleted-crash.html	2013-01-14 21:31:58 UTC (rev 139656)
@@ -0,0 +1,42 @@
+
+!DOCTYPE html
+html
+head
+script src=""
+/head
+body
+
+p id=description/p
+div id=console/div
+
+script
+description(Make sure that a debug assert is not triggered when a call to RenderBlock::deleteLineBoxTree calls AccessibilityRenderObject::accessibilityIsIgnored which may require the AXObject for a node that is being deleted.);
+
+var label = document.createElement('label');
+label.style.position = 'fixed';
+document.body.appendChild(label);
+
+var progress = document.createElement('progress');
+progress.style.display = 'block';
+label.appendChild(progress);
+
+var kbd = document.createElement('kbd');
+label.appendChild(kbd);
+
+var labelShadow = label.webkitCreateShadowRoot();
+
+var select = document.createElement('select');
+select.setAttribute('multiple', 'multiple');
+labelShadow.appendChild(select);
+
+var shadow = document.createElement('shadow');
+labelShadow.appendChild(shadow);
+
+select.focus();
+
+document.body.removeChild(label);
+
+/script
+script src=""
+/body
+/html


Modified: branches/chromium/1364/Source/WebCore/rendering/RenderObject.cpp (139655 => 139656)

--- branches/chromium/1364/Source/WebCore/rendering/RenderObject.cpp	2013-01-14 21:31:12 UTC (rev 139655)
+++ branches/chromium/1364/Source/WebCore/rendering/RenderObject.cpp	2013-01-14 21:31:58 UTC (rev 139656)
@@ -2372,14 +2372,20 @@
 if (frame()  frame()-eventHandler()-autoscrollRenderer() == this)
 frame()-eventHandler()-stopAutoscrollTimer(true);
 
-if (AXObjectCache::accessibilityEnabled()) {
-document()-axObjectCache()-childrenChanged(this-parent());
-document()-axObjectCache()-remove(this);
-}
 animation()-cancelAnimations(this);
 
+// For accessibility management, notify the parent of the imminent change to its child set.
+// We do it now, before remove(), while the parent pointer is still available.
+if (AXObjectCache::accessibilityEnabled())
+document()-axObjectCache()-childrenChanged(this-parent());
+
 remove();
 
+// The remove() call above may invoke axObjectCache()-childrenChanged() on the parent, which may require the AX render
+// object for this renderer. So we remove the AX render object now, after the renderer is removed.
+if (AXObjectCache::accessibilityEnabled())
+document()-axObjectCache()-remove(this);
+
 // Continuation and first-letter can generate several renderers associated with a single node.
 // We only want to clear the node's renderer if we are the associated renderer.
 if (node()  node()-renderer() == this)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [139657] branches/chromium/1364

[cevans]

Title: [139657] branches/chromium/1364








Revision 139657
Author cev...@google.com
Date 2013-01-14 13:37:59 -0800 (Mon, 14 Jan 2013)


Log Message
Merge 139100
BUG=167780
Review URL: https://codereview.chromium.org/11879024

Modified Paths

branches/chromium/1364/Source/WebCore/dom/Document.cpp
branches/chromium/1364/Source/WebCore/dom/Element.cpp


Added Paths

branches/chromium/1364/LayoutTests/fast/dom/mutation-event-listener-with-dirty-inline-style-crash-expected.txt
branches/chromium/1364/LayoutTests/fast/dom/mutation-event-listener-with-dirty-inline-style-crash.html




Diff

Copied: branches/chromium/1364/LayoutTests/fast/dom/mutation-event-listener-with-dirty-inline-style-crash-expected.txt (from rev 139100, trunk/LayoutTests/fast/dom/mutation-event-listener-with-dirty-inline-style-crash-expected.txt) (0 => 139657)

--- branches/chromium/1364/LayoutTests/fast/dom/mutation-event-listener-with-dirty-inline-style-crash-expected.txt	(rev 0)
+++ branches/chromium/1364/LayoutTests/fast/dom/mutation-event-listener-with-dirty-inline-style-crash-expected.txt	2013-01-14 21:37:59 UTC (rev 139657)
@@ -0,0 +1,4 @@
+PASS successfullyParsed is true
+
+TEST COMPLETE
+PASS, assuming we didn't crash.


Copied: branches/chromium/1364/LayoutTests/fast/dom/mutation-event-listener-with-dirty-inline-style-crash.html (from rev 139100, trunk/LayoutTests/fast/dom/mutation-event-listener-with-dirty-inline-style-crash.html) (0 => 139657)

--- branches/chromium/1364/LayoutTests/fast/dom/mutation-event-listener-with-dirty-inline-style-crash.html	(rev 0)
+++ branches/chromium/1364/LayoutTests/fast/dom/mutation-event-listener-with-dirty-inline-style-crash.html	2013-01-14 21:37:59 UTC (rev 139657)
@@ -0,0 +1,39 @@
+!DOCTYPE html
+html
+head id=head1 style=border-right-color: inherit;
+style
+*[foo^=] { border: inherit; }
+/style
+script src=""
+script
+window.jsTestIsAsync = true;
+if (window.testRunner) {
+testRunner.dumpAsText();
+}
+
+function handleSubtreeModifiedEvent() {
+document.open();
+document.write(FAIL. WebKit shouldn't dispatch a DOMSubtreeModified event when element inline style is modified through CSSOM.);
+document.close();
+finishJSTest();
+}
+
+function everythingWentBetterThanExpected() {
+document.open();
+document.write(PASS, assuming we didn't crash.);
+document.close();
+finishJSTest();
+}
+
+function load() {
+head1.attributes[1].addEventListener(DOMSubtreeModified, handleSubtreeModifiedEvent, false);
+head1.style.display = none;
+setTimeout(everythingWentBetterThanExpected(), 0);
+}
+
+document.addEventListener(DOMContentLoaded, load, false);
+/script
+body
+script src=""
+/body
+/html


Modified: branches/chromium/1364/Source/WebCore/dom/Document.cpp (139656 => 139657)

--- branches/chromium/1364/Source/WebCore/dom/Document.cpp	2013-01-14 21:31:58 UTC (rev 139656)
+++ branches/chromium/1364/Source/WebCore/dom/Document.cpp	2013-01-14 21:37:59 UTC (rev 139657)
@@ -4467,6 +4467,7 @@
 
 void Document::styleResolverThrowawayTimerFired(TimerDocument*)
 {
+ASSERT(!m_inStyleRecalc);
 clearStyleResolver();
 }
 


Modified: branches/chromium/1364/Source/WebCore/dom/Element.cpp (139656 => 139657)

--- branches/chromium/1364/Source/WebCore/dom/Element.cpp	2013-01-14 21:31:58 UTC (rev 139656)
+++ branches/chromium/1364/Source/WebCore/dom/Element.cpp	2013-01-14 21:37:59 UTC (rev 139657)
@@ -739,7 +739,7 @@
 // If there is an Attr node hooked to this attribute, the Attr::setValue() call below
 // will write into the ElementAttributeData.
 // FIXME: Refactor this so it makes some sense.
-if (RefPtrAttr attrNode = attrIfExists(name))
+if (RefPtrAttr attrNode = inSynchronizationOfLazyAttribute ? 0 : attrIfExists(name))
 attrNode-setValue(newValue);
 else
 mutableAttributeData()-attributeItem(index)-setValue(newValue);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [139658] trunk

[dmazzoni]

Title: [139658] trunk








Revision 139658
Author dmazz...@google.com
Date 2013-01-14 13:38:46 -0800 (Mon, 14 Jan 2013)


Log Message
Chromium: Error in AccessibilityUIElement::intValueGetterCallback
https://bugs.webkit.org/show_bug.cgi?id=106682

Reviewed by Chris Fleizach.

Tools:

Modify Chromium's DRT implementation of intValue to return a
different value depending on the role.

There are actually platform-specific differences in what should
be returned in the value of an object, so Chromium normally keeps
these separate (i.e. valueForRange, headingLevel, hierarchicalLevel, etc.)
but this is a fine simplification to make cross-platform tests easier.

* DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp:
(WebTestRunner::AccessibilityUIElement::intValueGetterCallback):

LayoutTests:

Unskip accessibility/heading-level.html now that the bug is fixed.

* platform/chromium/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/TestExpectations
trunk/Tools/ChangeLog
trunk/Tools/DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp




Diff

Modified: trunk/LayoutTests/ChangeLog (139657 => 139658)

--- trunk/LayoutTests/ChangeLog	2013-01-14 21:37:59 UTC (rev 139657)
+++ trunk/LayoutTests/ChangeLog	2013-01-14 21:38:46 UTC (rev 139658)
@@ -1,3 +1,14 @@
+2013-01-14  Dominic Mazzoni  dmazz...@google.com
+
+Chromium: Error in AccessibilityUIElement::intValueGetterCallback
+https://bugs.webkit.org/show_bug.cgi?id=106682
+
+Reviewed by Chris Fleizach.
+
+Unskip accessibility/heading-level.html now that the bug is fixed.
+
+* platform/chromium/TestExpectations:
+
 2013-01-14  Stephen Chenney  schen...@chromium.org
 
 [Chromium] More test expectations for Skia changes


Modified: trunk/LayoutTests/platform/chromium/TestExpectations (139657 => 139658)

--- trunk/LayoutTests/platform/chromium/TestExpectations	2013-01-14 21:37:59 UTC (rev 139657)
+++ trunk/LayoutTests/platform/chromium/TestExpectations	2013-01-14 21:38:46 UTC (rev 139658)
@@ -1435,7 +1435,6 @@
 webkit.org/b/96529 accessibility/hidden-legend.html [ Skip ]
 webkit.org/b/73912 accessibility/aria-checkbox-text.html [ Skip ]
 webkit.org/b/99665 accessibility/loading-iframe-sends-notification.html [ Skip ]
-webkit.org/b/106682 accessibility/heading-level.html [ Skip ]
 
 webkit.org/b/73912 accessibility/aria-checkbox-sends-notification.html [ Failure Pass ]
 #webkit.org/b/98787 accessibility/aria-hidden-negates-no-visibility.html [ Skip ]


Modified: trunk/Tools/ChangeLog (139657 => 139658)

--- trunk/Tools/ChangeLog	2013-01-14 21:37:59 UTC (rev 139657)
+++ trunk/Tools/ChangeLog	2013-01-14 21:38:46 UTC (rev 139658)
@@ -1,3 +1,21 @@
+2013-01-14  Dominic Mazzoni  dmazz...@google.com
+
+Chromium: Error in AccessibilityUIElement::intValueGetterCallback
+https://bugs.webkit.org/show_bug.cgi?id=106682
+
+Reviewed by Chris Fleizach.
+
+Modify Chromium's DRT implementation of intValue to return a
+different value depending on the role.
+
+There are actually platform-specific differences in what should
+be returned in the value of an object, so Chromium normally keeps
+these separate (i.e. valueForRange, headingLevel, hierarchicalLevel, etc.)
+but this is a fine simplification to make cross-platform tests easier.
+
+* DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp:
+(WebTestRunner::AccessibilityUIElement::intValueGetterCallback):
+
 2013-01-14  Jochen Eisinger  joc...@chromium.org
 
 [chromium] move remaining methods to dump WebViewClient callbacks to TestRunner library


Modified: trunk/Tools/DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp (139657 => 139658)

--- trunk/Tools/DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp	2013-01-14 21:37:59 UTC (rev 139657)
+++ trunk/Tools/DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp	2013-01-14 21:38:46 UTC (rev 139658)
@@ -518,7 +518,12 @@
 
 void AccessibilityUIElement::intValueGetterCallback(CppVariant* result)
 {
-result-set(accessibilityObject().valueForRange());
+if (accessibilityObject().supportsRangeValue())
+result-set(accessibilityObject().valueForRange());
+else if (accessibilityObject().roleValue() == WebAccessibilityRoleHeading)
+result-set(accessibilityObject().headingLevel());
+else
+result-set(atoi(accessibilityObject().stringValue().utf8().data()));
 }
 
 void AccessibilityUIElement::minValueGetterCallback(CppVariant* result)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [139660] trunk/LayoutTests

[schenney]

Title: [139660] trunk/LayoutTests








Revision 139660
Author schen...@chromium.org
Date 2013-01-14 13:45:58 -0800 (Mon, 14 Jan 2013)


Log Message
Re-enabling the SK_DISABLE_DASHING_OPTIMIZATION flag for Skia

Unreviewed expectations clean-up.

These files apparently need new baselines after the dashing optimization was removed.
It's a little odd, so maybe the expectations for that bug were hiding these failures.
Finally, hindi-spacing may be a flakey test.

* platform/chromium-linux-x86/fast/text/international/hindi-spacing-expected.png: Removed.
* platform/chromium-linux/fast/borders/border-image-01-expected.png: Added.
* platform/chromium-linux/fast/borders/border-image-longhand-expected.png: Added.
* platform/chromium-linux/fast/borders/border-image-repeat-expected.png: Added.
* platform/chromium-linux/fast/borders/border-image-scrambled-expected.png: Added.
* platform/chromium-linux/fast/borders/border-image-slices-expected.png: Added.
* platform/chromium-linux/fast/borders/border-image-source-expected.png: Added.
* platform/chromium-linux/fast/css/continuationCrash-expected.png:
* platform/chromium-linux/fast/text/international/hindi-spacing-expected.png:
* platform/chromium-win-xp/fast/borders/border-image-01-expected.png: Removed.
* platform/chromium-win-xp/fast/borders/border-image-longhand-expected.png: Removed.
* platform/chromium-win-xp/fast/borders/border-image-repeat-expected.png: Removed.
* platform/chromium-win-xp/fast/borders/border-image-scrambled-expected.png: Removed.
* platform/chromium-win-xp/fast/borders/border-image-slices-expected.png: Removed.
* platform/chromium-win-xp/fast/borders/border-image-source-expected.png: Removed.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium-linux/fast/css/continuationCrash-expected.png
trunk/LayoutTests/platform/chromium-linux/fast/text/international/hindi-spacing-expected.png
trunk/LayoutTests/platform/chromium-mac-lion/svg/dynamic-updates/SVGFESpecularLightingElement-remove-lightSource-expected.png
trunk/LayoutTests/platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFESpecularLightingElement-remove-lightSource-expected.png


Added Paths

trunk/LayoutTests/platform/chromium-linux/fast/borders/border-image-01-expected.png
trunk/LayoutTests/platform/chromium-linux/fast/borders/border-image-longhand-expected.png
trunk/LayoutTests/platform/chromium-linux/fast/borders/border-image-repeat-expected.png
trunk/LayoutTests/platform/chromium-linux/fast/borders/border-image-scrambled-expected.png
trunk/LayoutTests/platform/chromium-linux/fast/borders/border-image-slices-expected.png
trunk/LayoutTests/platform/chromium-linux/fast/borders/border-image-source-expected.png


Removed Paths

trunk/LayoutTests/platform/chromium-linux-x86/fast/text/international/hindi-spacing-expected.png
trunk/LayoutTests/platform/chromium-win-xp/fast/borders/border-image-01-expected.png
trunk/LayoutTests/platform/chromium-win-xp/fast/borders/border-image-longhand-expected.png
trunk/LayoutTests/platform/chromium-win-xp/fast/borders/border-image-repeat-expected.png
trunk/LayoutTests/platform/chromium-win-xp/fast/borders/border-image-scrambled-expected.png
trunk/LayoutTests/platform/chromium-win-xp/fast/borders/border-image-slices-expected.png
trunk/LayoutTests/platform/chromium-win-xp/fast/borders/border-image-source-expected.png




Diff

Modified: trunk/LayoutTests/ChangeLog (139659 => 139660)

--- trunk/LayoutTests/ChangeLog	2013-01-14 21:40:52 UTC (rev 139659)
+++ trunk/LayoutTests/ChangeLog	2013-01-14 21:45:58 UTC (rev 139660)
@@ -1,3 +1,29 @@
+2013-01-14  Stephen Chenney  schen...@chromium.org
+
+Re-enabling the SK_DISABLE_DASHING_OPTIMIZATION flag for Skia
+
+Unreviewed expectations clean-up.
+
+These files apparently need new baselines after the dashing optimization was removed.
+It's a little odd, so maybe the expectations for that bug were hiding these failures.
+Finally, hindi-spacing may be a flakey test.
+
+* platform/chromium-linux-x86/fast/text/international/hindi-spacing-expected.png: Removed.
+* platform/chromium-linux/fast/borders/border-image-01-expected.png: Added.
+* platform/chromium-linux/fast/borders/border-image-longhand-expected.png: Added.
+* platform/chromium-linux/fast/borders/border-image-repeat-expected.png: Added.
+* platform/chromium-linux/fast/borders/border-image-scrambled-expected.png: Added.
+* platform/chromium-linux/fast/borders/border-image-slices-expected.png: Added.
+* platform/chromium-linux/fast/borders/border-image-source-expected.png: Added.
+* platform/chromium-linux/fast/css/continuationCrash-expected.png:
+* platform/chromium-linux/fast/text/international/hindi-spacing-expected.png:
+* platform/chromium-win-xp/fast/borders/border-image-01-expected.png: Removed.
+* platform/chromium-win-xp/fast/borders/border-image-longhand-expected.png: Removed.
+* 

[webkit-changes] [139661] branches/chromium/1364

[cevans]

Title: [139661] branches/chromium/1364








Revision 139661
Author cev...@google.com
Date 2013-01-14 14:11:30 -0800 (Mon, 14 Jan 2013)


Log Message
Merge 139457
BUG=168969
Review URL: https://codereview.chromium.org/11879026

Modified Paths

branches/chromium/1364/Source/WebCore/svg/SVGStyledElement.cpp


Added Paths

branches/chromium/1364/LayoutTests/svg/custom/use-rebuild-resources-crash-expected.txt
branches/chromium/1364/LayoutTests/svg/custom/use-rebuild-resources-crash.svg




Diff

Copied: branches/chromium/1364/LayoutTests/svg/custom/use-rebuild-resources-crash-expected.txt (from rev 139457, trunk/LayoutTests/svg/custom/use-rebuild-resources-crash-expected.txt) (0 => 139661)

--- branches/chromium/1364/LayoutTests/svg/custom/use-rebuild-resources-crash-expected.txt	(rev 0)
+++ branches/chromium/1364/LayoutTests/svg/custom/use-rebuild-resources-crash-expected.txt	2013-01-14 22:11:30 UTC (rev 139661)
@@ -0,0 +1,2 @@
+PASS: Did not crash.
+


Copied: branches/chromium/1364/LayoutTests/svg/custom/use-rebuild-resources-crash.svg (from rev 139457, trunk/LayoutTests/svg/custom/use-rebuild-resources-crash.svg) (0 => 139661)

--- branches/chromium/1364/LayoutTests/svg/custom/use-rebuild-resources-crash.svg	(rev 0)
+++ branches/chromium/1364/LayoutTests/svg/custom/use-rebuild-resources-crash.svg	2013-01-14 22:11:30 UTC (rev 139661)
@@ -0,0 +1,31 @@
+?xml version=1.0 encoding=iso-8859-1 standalone=no?
+svg id=svg xmlns:xlink=http://www.w3.org/1999/xlink xmlns=http://www.w3.org/2000/svg
+  !-- Test for https://bugs.webkit.org/show_bug.cgi?id=106664 --
+  defs
+symbol id=s1
+  use/
+  rect id=r1/
+/symbol
+
+use id=u1 xlink:href=""
+
+style
+  use { clip-path: url(#r1); }
+/style
+  /defs
+
+  textPASS: Did not crash./text
+
+  script
+function initCF() {
+  u1 = document.getElementById('u1');
+  clone = u1.cloneNode(false);
+  document.getElementById('svg').appendChild(clone);
+}
+
+if (window.testRunner)
+  testRunner.dumpAsText();
+
+document.addEventListener(DOMContentLoaded, initCF, false);
+  /script
+/svg


Modified: branches/chromium/1364/Source/WebCore/svg/SVGStyledElement.cpp (139660 => 139661)

--- branches/chromium/1364/Source/WebCore/svg/SVGStyledElement.cpp	2013-01-14 21:45:58 UTC (rev 139660)
+++ branches/chromium/1364/Source/WebCore/svg/SVGStyledElement.cpp	2013-01-14 22:11:30 UTC (rev 139661)
@@ -356,7 +356,7 @@
 void SVGStyledElement::buildPendingResourcesIfNeeded()
 {
 Document* document = this-document();
-if (!needsPendingResourceHandling() || !document)
+if (!needsPendingResourceHandling() || !document || !inDocument() || isInShadowTree())
 return;
 
 SVGDocumentExtensions* extensions = document-accessSVGExtensions();






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [139662] branches/chromium/1364

[cevans]

Title: [139662] branches/chromium/1364








Revision 139662
Author cev...@google.com
Date 2013-01-14 14:14:33 -0800 (Mon, 14 Jan 2013)


Log Message
Merge 139345
BUG=169006
Review URL: https://codereview.chromium.org/11884035

Modified Paths

branches/chromium/1364/Source/WebCore/dom/Document.cpp


Added Paths

branches/chromium/1364/LayoutTests/fast/events/touch/nested-document-with-touch-handler-detached-crash-expected.txt
branches/chromium/1364/LayoutTests/fast/events/touch/nested-document-with-touch-handler-detached-crash.html




Diff

Copied: branches/chromium/1364/LayoutTests/fast/events/touch/nested-document-with-touch-handler-detached-crash-expected.txt (from rev 139345, trunk/LayoutTests/fast/events/touch/nested-document-with-touch-handler-detached-crash-expected.txt) (0 => 139662)

--- branches/chromium/1364/LayoutTests/fast/events/touch/nested-document-with-touch-handler-detached-crash-expected.txt	(rev 0)
+++ branches/chromium/1364/LayoutTests/fast/events/touch/nested-document-with-touch-handler-detached-crash-expected.txt	2013-01-14 22:14:33 UTC (rev 139662)
@@ -0,0 +1,2 @@
+
+Test passes if DRT doesn't crash.


Copied: branches/chromium/1364/LayoutTests/fast/events/touch/nested-document-with-touch-handler-detached-crash.html (from rev 139345, trunk/LayoutTests/fast/events/touch/nested-document-with-touch-handler-detached-crash.html) (0 => 139662)

--- branches/chromium/1364/LayoutTests/fast/events/touch/nested-document-with-touch-handler-detached-crash.html	(rev 0)
+++ branches/chromium/1364/LayoutTests/fast/events/touch/nested-document-with-touch-handler-detached-crash.html	2013-01-14 22:14:33 UTC (rev 139662)
@@ -0,0 +1,15 @@
+!doctype html
+html
+body
+iframe id=testIframe srcdoc=iframe seamless srcdoc=' ' border: 2px solid black/iframe
+divTest passes if DRT doesn't crash./div
+script
+if (window.testRunner)
+	testRunner.dumpAsText();
+
+var testIframe = document.getElementById('testIframe');
+var input = testIframe.contentDocument.createElement('input');
+input.type = RANGE;
+input = 0;
+/script
+/body


Modified: branches/chromium/1364/Source/WebCore/dom/Document.cpp (139661 => 139662)

--- branches/chromium/1364/Source/WebCore/dom/Document.cpp	2013-01-14 22:11:30 UTC (rev 139661)
+++ branches/chromium/1364/Source/WebCore/dom/Document.cpp	2013-01-14 22:14:33 UTC (rev 139662)
@@ -2138,6 +2138,11 @@
 if (render)
 render-destroy();
 
+#if ENABLE(TOUCH_EVENTS)
+if (m_touchEventTargets  m_touchEventTargets-size()  parentDocument())
+parentDocument()-didRemoveEventTargetNode(this);
+#endif
+
 // This is required, as our Frame might delete itself as soon as it detaches
 // us. However, this violates Node::detach() semantics, as it's never
 // possible to re-attach. Eventually Document::detach() should be renamed,
@@ -5674,11 +5679,11 @@
 #if ENABLE(TOUCH_EVENTS)
 void Document::didRemoveEventTargetNode(Node* handler)
 {
-if (m_touchEventTargets.get())
+if (m_touchEventTargets) {
 m_touchEventTargets-removeAll(handler);
-if (handler == this)
-if (Document* parentDocument = this-parentDocument())
-parentDocument-didRemoveEventTargetNode(this);
+if ((handler == this || m_touchEventTargets-isEmpty())  parentDocument())
+parentDocument()-didRemoveEventTargetNode(this);
+}
 }
 #endif
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [139663] trunk

[dmazzoni]

Title: [139663] trunk








Revision 139663
Author dmazz...@google.com
Date 2013-01-14 14:21:00 -0800 (Mon, 14 Jan 2013)


Log Message
AX: Need to implement ColorWellRole
https://bugs.webkit.org/show_bug.cgi?id=106756

Reviewed by Chris Fleizach.

Source/WebCore:

Maps input type=color to the accessible role ColorWellRole.
Adds a new accessor to AccessibilityObject to get the color
value in a cross-platform way that doesn't require parsing.

Test: accessibility/color-well.html

* accessibility/AccessibilityNodeObject.cpp:
(WebCore::AccessibilityNodeObject::determineAccessibilityRole):
(WebCore::AccessibilityNodeObject::colorValue):
(WebCore):
* accessibility/AccessibilityNodeObject.h:
(AccessibilityNodeObject):
* accessibility/AccessibilityObject.h:
(WebCore::AccessibilityObject::isColorWell):
(AccessibilityObject):
(WebCore::AccessibilityObject::colorValue):
* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::stringValue):
(WebCore::AccessibilityRenderObject::determineAccessibilityRole):
* accessibility/mac/WebAccessibilityObjectWrapper.mm:
(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:]):
* html/HTMLInputElement.cpp:
(WebCore):
(WebCore::HTMLInputElement::isColorControl):
* html/HTMLInputElement.h:
(HTMLInputElement):

Source/WebKit/chromium:

Adds an accessibility interface to access the value of a
color control.

* public/WebAccessibilityObject.h:
(WebAccessibilityObject):
* src/WebAccessibilityObject.cpp:
(WebKit::WebAccessibilityObject::colorValue):
(WebKit):

Tools:

Returns a string representation of the value of a color
when the role is Color Well, to make it easy to write layout
tests for color controls.

* DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp:

LayoutTests:

Adds a test of accessibility attributes for input type=color.

* accessibility/color-well.html: Added.
* platform/chromium/accessibility/color-well-expected.txt: Added.
* platform/mac/accessibility/color-well-expected.txt: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/accessibility/AccessibilityNodeObject.cpp
trunk/Source/WebCore/accessibility/AccessibilityNodeObject.h
trunk/Source/WebCore/accessibility/AccessibilityObject.h
trunk/Source/WebCore/accessibility/AccessibilityRenderObject.cpp
trunk/Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapper.mm
trunk/Source/WebCore/html/HTMLInputElement.cpp
trunk/Source/WebCore/html/HTMLInputElement.h
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/public/WebAccessibilityObject.h
trunk/Source/WebKit/chromium/src/WebAccessibilityObject.cpp
trunk/Tools/ChangeLog
trunk/Tools/DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp


Added Paths

trunk/LayoutTests/accessibility/color-well.html
trunk/LayoutTests/platform/chromium/accessibility/color-well-expected.txt
trunk/LayoutTests/platform/mac/accessibility/color-well-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (139662 => 139663)

--- trunk/LayoutTests/ChangeLog	2013-01-14 22:14:33 UTC (rev 139662)
+++ trunk/LayoutTests/ChangeLog	2013-01-14 22:21:00 UTC (rev 139663)
@@ -1,3 +1,16 @@
+2013-01-14  Dominic Mazzoni  dmazz...@google.com
+
+AX: Need to implement ColorWellRole
+https://bugs.webkit.org/show_bug.cgi?id=106756
+
+Reviewed by Chris Fleizach.
+
+Adds a test of accessibility attributes for input type=color.
+
+* accessibility/color-well.html: Added.
+* platform/chromium/accessibility/color-well-expected.txt: Added.
+* platform/mac/accessibility/color-well-expected.txt: Added.
+
 2013-01-14  Stephen Chenney  schen...@chromium.org
 
 Re-enabling the SK_DISABLE_DASHING_OPTIMIZATION flag for Skia


Added: trunk/LayoutTests/accessibility/color-well.html (0 => 139663)

--- trunk/LayoutTests/accessibility/color-well.html	(rev 0)
+++ trunk/LayoutTests/accessibility/color-well.html	2013-01-14 22:21:00 UTC (rev 139663)
@@ -0,0 +1,38 @@
+html
+html
+head
+script src=""
+/head
+body id=body
+
+input id=empty_colorwell type=color
+input id=good_colorwell type=color value=#ff
+input id=bad_colorwell type=color value=purple
+
+p id=description/p
+div id=console/div
+ 
+script
+if (window.accessibilityController) {
+description(This test checks the role of ColorWellRolean input with type=color);
+
+var colorwell = document.getElementById(empty_colorwell).focus();
+var axColorwell = accessibilityController.focusedElement;
+debug(Role of input type=color is:  + axColorwell.role);
+
+debug(Value of empty color well:  + axColorwell.stringValue);
+
+colorwell = document.getElementById(good_colorwell).focus();
+axColorwell = accessibilityController.focusedElement;
+debug(Value of good color well:  + axColorwell.stringValue);
+
+

[webkit-changes] [139664] trunk

[jchaffraix]

Title: [139664] trunk








Revision 139664
Author jchaffr...@webkit.org
Date 2013-01-14 14:23:06 -0800 (Mon, 14 Jan 2013)


Log Message
REGRESSION (r132591): Underpainting @ uofmchildrenshospital.org
https://bugs.webkit.org/show_bug.cgi?id=105861

Reviewed by David Hyatt.

Source/WebCore:

Test: fast/repaint/overhanging-float-detach-repaint.html

The issue comes from overhanging float not contributing to their containing block's
overflow. This meant that repaint() would ignore them leading to an under-repaint.
The fix is simple: force all the overhanging floats to repaint themselves.

* rendering/RenderObject.cpp:
(WebCore::RenderObject::destroyAndCleanupAnonymousWrappers):

LayoutTests:

* fast/repaint/overhanging-float-detach-repaint-expected.png: Added.
* fast/repaint/overhanging-float-detach-repaint-expected.txt: Added.
* fast/repaint/overhanging-float-detach-repaint.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderObject.cpp


Added Paths

trunk/LayoutTests/fast/repaint/overhanging-float-detach-repaint-expected.png
trunk/LayoutTests/fast/repaint/overhanging-float-detach-repaint-expected.txt
trunk/LayoutTests/fast/repaint/overhanging-float-detach-repaint.html




Diff

Modified: trunk/LayoutTests/ChangeLog (139663 => 139664)

--- trunk/LayoutTests/ChangeLog	2013-01-14 22:21:00 UTC (rev 139663)
+++ trunk/LayoutTests/ChangeLog	2013-01-14 22:23:06 UTC (rev 139664)
@@ -1,3 +1,14 @@
+2013-01-14  Julien Chaffraix  jchaffr...@webkit.org
+
+REGRESSION (r132591): Underpainting @ uofmchildrenshospital.org
+https://bugs.webkit.org/show_bug.cgi?id=105861
+
+Reviewed by David Hyatt.
+
+* fast/repaint/overhanging-float-detach-repaint-expected.png: Added.
+* fast/repaint/overhanging-float-detach-repaint-expected.txt: Added.
+* fast/repaint/overhanging-float-detach-repaint.html: Added.
+
 2013-01-14  Dominic Mazzoni  dmazz...@google.com
 
 AX: Need to implement ColorWellRole


Added: trunk/LayoutTests/fast/repaint/overhanging-float-detach-repaint-expected.png (0 => 139664)

--- trunk/LayoutTests/fast/repaint/overhanging-float-detach-repaint-expected.png	(rev 0)
+++ trunk/LayoutTests/fast/repaint/overhanging-float-detach-repaint-expected.png	2013-01-14 22:23:06 UTC (rev 139664)
@@ -0,0 +1,6 @@
+\x89PNG
+
+
+IHDR X')tEXtchecksum991b2509651475980cf8bec8c6497b55\xB1\x80g\xD6
+\xC2IDATx\x9C\xEDر
+AA\x91\xE3^\x88\xE0\xB58xU\xB9\xEB\x8C\xD9\xDAkft\x9E\xA7܍\xC0\x88	,\x80\x98\xC0\x88	,\x80\x98\xC0\x88	,\x80\x98\xC0\x88	,\x80\x98\xC0\x88	,\x80\x98\xC0\x88	,\x80\x98\xC0\x88	,\x80\x98\xC0\x88	,\x80\x98\xC0\x88	,\x80\x98\xC0\x88	,\x80\x98\xC0\x88	,\x80\x98\xC0\x88	,\x80\x98\xC0\x88	,\x80\x98\xC0\x88	,\x80\x98\xC0\x88	,\x80\x98\xC0\x88	,\x80\x98\xC0\x88	,\x80\x98\xC0\x88	,\x80\x98\xC0\x88	,\x80\x98\xC0\x88	,\x80\x98\xC0\x88	,\x80\x98\xC0\x88	,\x80\x98\xC0\x88	,\x80\x98\xC0\x88	,\x80\x98\xC0\x88	,\x80\x98\xC0\x88	,\x80\x98\xC0\x88	,\x80\x98\xC0\x88	,\x80\x98\xC0\x88	,\x80\x98\xC0\x88	,\x80\x98\xC0\x88	,\x80\x98\xC0\x88	,\x80\x98\xC0\x88	,\x80\xD8\xEB\xD3a\xEF\xFD\xCDm\xADuz\xF0C|\xB0b \xB0b \xB0b \xB0b \xB0b \xB0b \xB0b \xB0b \xB0b \xB0b \xB0b \xB0b \xB0b \xB0b \xB0b \xB0b \xB0b \xB0b \xB0b \xB0b \xB0b \xB0b \xB0b \xB0b \xB0b \xB0b \xB0b \xB0b \xB0b \xB0b \xB0b \xB0b \xB0b \xB0b \xB0b \xB0b \xB0b \xB0b \xB0b \xB0b \xB0b \xB0b \xB0b \xB0b \xB0b \xB0b \xB0b \xB0b \xB0b 

[webkit-changes] [139667] trunk/Source/WebKit/blackberry

[commit-queue]

Title: [139667] trunk/Source/WebKit/blackberry








Revision 139667
Author commit-qu...@webkit.org
Date 2013-01-14 14:41:09 -0800 (Mon, 14 Jan 2013)


Log Message
[BlackBerry] FCC appears when switching search engine providers
https://bugs.webkit.org/show_bug.cgi?id=106824

Magnifying glass appears when switching search engine providers

PR 279178

Patch by Otto Derek Cheung otche...@rim.com on 2013-01-14
Reviewed by Rob Buis.
Internal Reviewed by Mike Fenton.

We need to make sure fatfinger is touching a textfield when we tell notifyCaretChanged
to show the FCC.

This behaviour is accidentally regressed in the fix in PR 267177, causing the FCC to show
when the user touches an element that is not a textfield and changes the caret in the inputbar..

Tested that the behaviour in 267177 isn't reproducible and the FCC isn't invoked when we switch
search engine providers.

* WebKitSupport/SelectionHandler.cpp:
(BlackBerry::WebKit::SelectionHandler::caretPositionChanged):

Modified Paths

trunk/Source/WebKit/blackberry/ChangeLog
trunk/Source/WebKit/blackberry/WebKitSupport/SelectionHandler.cpp




Diff

Modified: trunk/Source/WebKit/blackberry/ChangeLog (139666 => 139667)

--- trunk/Source/WebKit/blackberry/ChangeLog	2013-01-14 22:40:24 UTC (rev 139666)
+++ trunk/Source/WebKit/blackberry/ChangeLog	2013-01-14 22:41:09 UTC (rev 139667)
@@ -1,3 +1,27 @@
+2013-01-14  Otto Derek Cheung  otche...@rim.com
+
+[BlackBerry] FCC appears when switching search engine providers
+https://bugs.webkit.org/show_bug.cgi?id=106824
+
+Magnifying glass appears when switching search engine providers
+
+PR 279178
+
+Reviewed by Rob Buis.
+Internal Reviewed by Mike Fenton.
+
+We need to make sure fatfinger is touching a textfield when we tell notifyCaretChanged
+to show the FCC.
+
+This behaviour is accidentally regressed in the fix in PR 267177, causing the FCC to show
+when the user touches an element that is not a textfield and changes the caret in the inputbar..
+
+Tested that the behaviour in 267177 isn't reproducible and the FCC isn't invoked when we switch
+search engine providers.
+
+* WebKitSupport/SelectionHandler.cpp:
+(BlackBerry::WebKit::SelectionHandler::caretPositionChanged):
+
 2013-01-14  Jacky Jiang  zhaji...@rim.com
 
 [BlackBerry] Zoom is still possible when user-scalable=no


Modified: trunk/Source/WebKit/blackberry/WebKitSupport/SelectionHandler.cpp (139666 => 139667)

--- trunk/Source/WebKit/blackberry/WebKitSupport/SelectionHandler.cpp	2013-01-14 22:40:24 UTC (rev 139666)
+++ trunk/Source/WebKit/blackberry/WebKitSupport/SelectionHandler.cpp	2013-01-14 22:41:09 UTC (rev 139667)
@@ -1028,12 +1028,14 @@
 {
 SelectionLog(Platform::LogLevelInfo, SelectionHandler::caretPositionChanged);
 
+bool isFatFingerOnTextField = userTouchTriggered  m_webPage-m_touchEventHandler-lastFatFingersResult().isTextInput();
+
 WebCore::IntRect caretLocation;
 // If the input field is not active, we must be turning off the caret.
 if (!m_webPage-m_inputHandler-isInputMode()  m_caretActive) {
 m_caretActive = false;
 // Send an empty caret change to turn off the caret.
-m_webPage-m_client-notifyCaretChanged(caretLocation, userTouchTriggered);
+m_webPage-m_client-notifyCaretChanged(caretLocation, isFatFingerOnTextField);
 return;
 }
 
@@ -1074,7 +1076,7 @@
 Platform::IntRect(nodeBoundingBox).toString().c_str(),
 m_webPage-m_inputHandler-elementText().isEmpty() ? , empty text field : );
 
-m_webPage-m_client-notifyCaretChanged(caretLocation, userTouchTriggered, isSingleLineInput, nodeBoundingBox, m_webPage-m_inputHandler-elementText().isEmpty());
+m_webPage-m_client-notifyCaretChanged(caretLocation, isFatFingerOnTextField, isSingleLineInput, nodeBoundingBox, m_webPage-m_inputHandler-elementText().isEmpty());
 }
 
 bool SelectionHandler::selectionContains(const WebCore::IntPoint point)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [139668] trunk/LayoutTests

[eae]

Title: [139668] trunk/LayoutTests








Revision 139668
Author e...@chromium.org
Date 2013-01-14 14:41:44 -0800 (Mon, 14 Jan 2013)


Log Message
Unreviewed chromium mac rebaseline for r139659.

* platform/chromium-mac/platform/chromium/inspector/styles/device-metrics-fit-window-expected.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium-mac/platform/chromium/inspector/styles/device-metrics-fit-window-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (139667 => 139668)

--- trunk/LayoutTests/ChangeLog	2013-01-14 22:41:09 UTC (rev 139667)
+++ trunk/LayoutTests/ChangeLog	2013-01-14 22:41:44 UTC (rev 139668)
@@ -1,3 +1,9 @@
+2013-01-14  Emil A Eklund  e...@chromium.org
+
+Unreviewed chromium mac rebaseline for r139659.
+
+* platform/chromium-mac/platform/chromium/inspector/styles/device-metrics-fit-window-expected.txt:
+
 2013-01-14  Julien Chaffraix  jchaffr...@webkit.org
 
 REGRESSION (r132591): Underpainting @ uofmchildrenshospital.org


Modified: trunk/LayoutTests/platform/chromium-mac/platform/chromium/inspector/styles/device-metrics-fit-window-expected.txt (139667 => 139668)

--- trunk/LayoutTests/platform/chromium-mac/platform/chromium/inspector/styles/device-metrics-fit-window-expected.txt	2013-01-14 22:41:09 UTC (rev 139667)
+++ trunk/LayoutTests/platform/chromium-mac/platform/chromium/inspector/styles/device-metrics-fit-window-expected.txt	2013-01-14 22:41:44 UTC (rev 139668)
@@ -1,6 +1,6 @@
 Tests that emulating device metrics with Fit window for a small FrameView correctly downscales page content.
 
 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 123456789 

[webkit-changes] [139669] trunk

[commit-queue]

Title: [139669] trunk








Revision 139669
Author commit-qu...@webkit.org
Date 2013-01-14 14:44:02 -0800 (Mon, 14 Jan 2013)


Log Message
Positioned children of an overflow:visible container should ignore scroll offset when updating layer position
https://bugs.webkit.org/show_bug.cgi?id=106814

Source/WebCore:

Patch by Tien-Ren Chen trc...@chromium.org on 2013-01-14
Reviewed by Simon Fraser.

This patch fixes a bug in RenderLayer::updateLayerPosition that
scrollLeft / scrollTop of a block should only be effective when the
block has overflow clipping. The bug results in rendering artifacts
and triggers a RenderGeometryMap assertion falure.

Fixes http://crbug.com/167985

Test: fast/overflow/overflow-visible-should-ignore-scroll.html

* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::updateLayerPosition):

LayoutTests:

This patch fixes a bug in RenderLayer::updateLayerPosition that
scrollLeft / scrollTop of a block should only be effective when the
block has overflow clipping. The bug results in rendering artifacts
and triggers a RenderGeometryMap assertion falure.

Fixes http://crbug.com/167985

Patch by Tien-Ren Chen trc...@chromium.org on 2013-01-14
Reviewed by Simon Fraser.

* fast/overflow/overflow-visible-should-ignore-scroll-expected.html: Added.
* fast/overflow/overflow-visible-should-ignore-scroll.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderLayer.cpp


Added Paths

trunk/LayoutTests/fast/overflow/overflow-visible-should-ignore-scroll-expected.html
trunk/LayoutTests/fast/overflow/overflow-visible-should-ignore-scroll.html




Diff

Modified: trunk/LayoutTests/ChangeLog (139668 => 139669)

--- trunk/LayoutTests/ChangeLog	2013-01-14 22:41:44 UTC (rev 139668)
+++ trunk/LayoutTests/ChangeLog	2013-01-14 22:44:02 UTC (rev 139669)
@@ -1,3 +1,20 @@
+2013-01-14  Tien-Ren Chen  trc...@chromium.org
+
+Positioned children of an overflow:visible container should ignore scroll offset when updating layer position
+https://bugs.webkit.org/show_bug.cgi?id=106814
+
+This patch fixes a bug in RenderLayer::updateLayerPosition that
+scrollLeft / scrollTop of a block should only be effective when the
+block has overflow clipping. The bug results in rendering artifacts
+and triggers a RenderGeometryMap assertion falure.
+
+Fixes http://crbug.com/167985
+
+Reviewed by Simon Fraser.
+
+* fast/overflow/overflow-visible-should-ignore-scroll-expected.html: Added.
+* fast/overflow/overflow-visible-should-ignore-scroll.html: Added.
+
 2013-01-14  Emil A Eklund  e...@chromium.org
 
 Unreviewed chromium mac rebaseline for r139659.


Added: trunk/LayoutTests/fast/overflow/overflow-visible-should-ignore-scroll-expected.html (0 => 139669)

--- trunk/LayoutTests/fast/overflow/overflow-visible-should-ignore-scroll-expected.html	(rev 0)
+++ trunk/LayoutTests/fast/overflow/overflow-visible-should-ignore-scroll-expected.html	2013-01-14 22:44:02 UTC (rev 139669)
@@ -0,0 +1,7 @@
+!DOCTYPE html
+html
+body
+span style=position:absolute;Absolute/spanspan style=position:relative;left:100px;Relative/spanbr/
+This test is successful if both words in the above line are displayed properly.
+/body
+/html


Added: trunk/LayoutTests/fast/overflow/overflow-visible-should-ignore-scroll.html (0 => 139669)

--- trunk/LayoutTests/fast/overflow/overflow-visible-should-ignore-scroll.html	(rev 0)
+++ trunk/LayoutTests/fast/overflow/overflow-visible-should-ignore-scroll.html	2013-01-14 22:44:02 UTC (rev 139669)
@@ -0,0 +1,24 @@
+!DOCTYPE html
+html
+head
+style type=text/css
+#outerbox {
+height:0;
+position:absolute;
+overflow:hidden;
+}
+/style
+script type=text/_javascript_
+function test () {
+document.getElementById('outerbox').scrollTop=1000;
+document.getElementById('outerbox').style.overflow='visible';
+}
+/script
+/head
+body _onload_=test();
+div id=outerbox
+span style=position:absolute;Absolute/spanspan style=position:relative;left:100px;Relative/spanbr/
+This test is successful if both words in the above line are displayed properly.
+/div
+/body
+/html


Modified: trunk/Source/WebCore/ChangeLog (139668 => 139669)

--- trunk/Source/WebCore/ChangeLog	2013-01-14 22:41:44 UTC (rev 139668)
+++ trunk/Source/WebCore/ChangeLog	2013-01-14 22:44:02 UTC (rev 139669)
@@ -1,3 +1,22 @@
+2013-01-14  Tien-Ren Chen  trc...@chromium.org
+
+Positioned children of an overflow:visible container should ignore scroll offset when updating layer position
+https://bugs.webkit.org/show_bug.cgi?id=106814
+
+Reviewed by Simon Fraser.
+
+This patch fixes a bug in RenderLayer::updateLayerPosition that
+scrollLeft / scrollTop of a block should only be effective when the
+block has overflow clipping. The bug results in rendering artifacts
+and triggers a RenderGeometryMap 

[webkit-changes] [139670] branches/chromium/1364/Source/WebCore/platform/image-encoders/skia

[cevans]

Title: [139670] branches/chromium/1364/Source/WebCore/platform/image-encoders/skia








Revision 139670
Author cev...@google.com
Date 2013-01-14 14:46:32 -0800 (Mon, 14 Jan 2013)


Log Message
Merge 138170
BUG=162551
Review URL: https://codereview.chromium.org/11876030

Modified Paths

branches/chromium/1364/Source/WebCore/platform/image-encoders/skia/JPEGImageEncoder.cpp
branches/chromium/1364/Source/WebCore/platform/image-encoders/skia/PNGImageEncoder.cpp
branches/chromium/1364/Source/WebCore/platform/image-encoders/skia/WEBPImageEncoder.cpp




Diff

Modified: branches/chromium/1364/Source/WebCore/platform/image-encoders/skia/JPEGImageEncoder.cpp (139669 => 139670)

--- branches/chromium/1364/Source/WebCore/platform/image-encoders/skia/JPEGImageEncoder.cpp	2013-01-14 22:44:02 UTC (rev 139669)
+++ branches/chromium/1364/Source/WebCore/platform/image-encoders/skia/JPEGImageEncoder.cpp	2013-01-14 22:46:32 UTC (rev 139670)
@@ -188,7 +188,7 @@
 {
 SkAutoLockPixels bitmapLock(bitmap);
 
-if (bitmap.config() != SkBitmap::kARGB__Config)
+if (bitmap.config() != SkBitmap::kARGB__Config || !bitmap.getPixels())
 return false; // Only support 32 bit/pixel skia bitmaps.
 
 return encodePixels(IntSize(bitmap.width(), bitmap.height()), static_castunsigned char *(bitmap.getPixels()), true, quality, output);


Modified: branches/chromium/1364/Source/WebCore/platform/image-encoders/skia/PNGImageEncoder.cpp (139669 => 139670)

--- branches/chromium/1364/Source/WebCore/platform/image-encoders/skia/PNGImageEncoder.cpp	2013-01-14 22:44:02 UTC (rev 139669)
+++ branches/chromium/1364/Source/WebCore/platform/image-encoders/skia/PNGImageEncoder.cpp	2013-01-14 22:46:32 UTC (rev 139670)
@@ -118,7 +118,7 @@
 {
 SkAutoLockPixels bitmapLock(bitmap);
 
-if (bitmap.config() != SkBitmap::kARGB__Config)
+if (bitmap.config() != SkBitmap::kARGB__Config || !bitmap.getPixels())
 return false; // Only support 32 bit/pixel skia bitmaps.
 
 return encodePixels(IntSize(bitmap.width(), bitmap.height()), static_castunsigned char*(bitmap.getPixels()), true, output);


Modified: branches/chromium/1364/Source/WebCore/platform/image-encoders/skia/WEBPImageEncoder.cpp (139669 => 139670)

--- branches/chromium/1364/Source/WebCore/platform/image-encoders/skia/WEBPImageEncoder.cpp	2013-01-14 22:44:02 UTC (rev 139669)
+++ branches/chromium/1364/Source/WebCore/platform/image-encoders/skia/WEBPImageEncoder.cpp	2013-01-14 22:46:32 UTC (rev 139670)
@@ -122,7 +122,7 @@
 {
 SkAutoLockPixels bitmapLock(bitmap);
 
-if (bitmap.config() != SkBitmap::kARGB__Config)
+if (bitmap.config() != SkBitmap::kARGB__Config || !bitmap.getPixels())
 return false; // Only support 32 bit/pixel skia bitmaps.
 
 return encodePixels(IntSize(bitmap.width(), bitmap.height()), static_castunsigned char *(bitmap.getPixels()), true, quality, output);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [139671] trunk/LayoutTests

[schenney]

Title: [139671] trunk/LayoutTests








Revision 139671
Author schen...@chromium.org
Date 2013-01-14 14:48:56 -0800 (Mon, 14 Jan 2013)


Log Message
[Chromium] Rebaseline after Skia changes

Unreviewed expectatiosn update for two remaining tests.

* platform/chromium-mac-snowleopard/svg/custom/foreign-object-skew-expected.png:
* platform/chromium-win/fast/borders/outline-alpha-inline-expected.png: Added.
* platform/chromium/fast/borders/outline-alpha-inline-expected.png: Removed.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium-mac-snowleopard/svg/custom/foreign-object-skew-expected.png


Added Paths

trunk/LayoutTests/platform/chromium-win/fast/borders/outline-alpha-inline-expected.png


Removed Paths

trunk/LayoutTests/platform/chromium/fast/borders/outline-alpha-inline-expected.png




Diff

Modified: trunk/LayoutTests/ChangeLog (139670 => 139671)

--- trunk/LayoutTests/ChangeLog	2013-01-14 22:46:32 UTC (rev 139670)
+++ trunk/LayoutTests/ChangeLog	2013-01-14 22:48:56 UTC (rev 139671)
@@ -1,3 +1,13 @@
+2013-01-14  Stephen Chenney  schen...@chromium.org
+
+[Chromium] Rebaseline after Skia changes
+
+Unreviewed expectatiosn update for two remaining tests.
+
+* platform/chromium-mac-snowleopard/svg/custom/foreign-object-skew-expected.png:
+* platform/chromium-win/fast/borders/outline-alpha-inline-expected.png: Added.
+* platform/chromium/fast/borders/outline-alpha-inline-expected.png: Removed.
+
 2013-01-14  Tien-Ren Chen  trc...@chromium.org
 
 Positioned children of an overflow:visible container should ignore scroll offset when updating layer position


Deleted: trunk/LayoutTests/platform/chromium/fast/borders/outline-alpha-inline-expected.png

(Binary files differ)


Modified: trunk/LayoutTests/platform/chromium-mac-snowleopard/svg/custom/foreign-object-skew-expected.png

(Binary files differ)


Added: trunk/LayoutTests/platform/chromium-win/fast/borders/outline-alpha-inline-expected.png

(Binary files differ)

Property changes on: trunk/LayoutTests/platform/chromium-win/fast/borders/outline-alpha-inline-expected.png
___

Added: svn:mime-type




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [139672] tags/Safari-537.26/Source/WebKit2

[lforschler]

Title: [139672] tags/Safari-537.26/Source/WebKit2








Revision 139672
Author lforsch...@apple.com
Date 2013-01-14 14:57:46 -0800 (Mon, 14 Jan 2013)


Log Message
Merged r139655.

Modified Paths

tags/Safari-537.26/Source/WebKit2/ChangeLog
tags/Safari-537.26/Source/WebKit2/NetworkProcess/NetworkResourceLoadScheduler.cpp
tags/Safari-537.26/Source/WebKit2/NetworkProcess/NetworkResourceLoadScheduler.h




Diff

Modified: tags/Safari-537.26/Source/WebKit2/ChangeLog (139671 => 139672)

--- tags/Safari-537.26/Source/WebKit2/ChangeLog	2013-01-14 22:48:56 UTC (rev 139671)
+++ tags/Safari-537.26/Source/WebKit2/ChangeLog	2013-01-14 22:57:46 UTC (rev 139672)
@@ -1,3 +1,20 @@
+2013-01-14  Lucas Forschler  lforsch...@apple.com
+
+Merge r139655
+
+2013-01-14  Alexey Proskuryakov  a...@apple.com
+
+NetworkProcess scheduler never resumes resource loads that were postponed
+due to connection limit
+https://bugs.webkit.org/show_bug.cgi?id=106821
+
+Reviewed by Brady Eidson.
+
+* NetworkProcess/NetworkResourceLoadScheduler.cpp:
+(WebKit::NetworkResourceLoadScheduler::servePendingRequests):
+* NetworkProcess/NetworkResourceLoadScheduler.h:
+Remove an uninitialized variable that could prevent loading.
+
 2013-01-11  Balazs Kelemen  kbal...@webkit.org
 
 [Qt][WK2] plugin tests assert in debug


Modified: tags/Safari-537.26/Source/WebKit2/NetworkProcess/NetworkResourceLoadScheduler.cpp (139671 => 139672)

--- tags/Safari-537.26/Source/WebKit2/NetworkProcess/NetworkResourceLoadScheduler.cpp	2013-01-14 22:48:56 UTC (rev 139671)
+++ tags/Safari-537.26/Source/WebKit2/NetworkProcess/NetworkResourceLoadScheduler.cpp	2013-01-14 22:57:46 UTC (rev 139672)
@@ -146,9 +146,6 @@
 
 void NetworkResourceLoadScheduler::servePendingRequests(ResourceLoadPriority minimumPriority)
 {
-if (m_suspendPendingRequestsCount)
-return;
-
 LOG(NetworkScheduling, (NetworkProcess) NetworkResourceLoadScheduler::servePendingRequests Serving requests for up to %i hosts, m_hosts.size());
 
 m_requestTimer.stop();


Modified: tags/Safari-537.26/Source/WebKit2/NetworkProcess/NetworkResourceLoadScheduler.h (139671 => 139672)

--- tags/Safari-537.26/Source/WebKit2/NetworkProcess/NetworkResourceLoadScheduler.h	2013-01-14 22:48:56 UTC (rev 139671)
+++ tags/Safari-537.26/Source/WebKit2/NetworkProcess/NetworkResourceLoadScheduler.h	2013-01-14 22:57:46 UTC (rev 139672)
@@ -92,7 +92,6 @@
 
 HostRecord* m_nonHTTPProtocolHost;
 
-unsigned m_suspendPendingRequestsCount;
 bool m_isSerialLoadingEnabled;
 
 WebCore::TimerNetworkResourceLoadScheduler m_requestTimer;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [139674] trunk

[commit-queue]

Title: [139674] trunk








Revision 139674
Author commit-qu...@webkit.org
Date 2013-01-14 15:11:04 -0800 (Mon, 14 Jan 2013)


Log Message
[TexMap] Use a premuliplied color in TextureMapperGL.
https://bugs.webkit.org/show_bug.cgi?id=105786

Patch by Huang Dongsung luxte...@company100.net on 2013-01-14
Reviewed by Noam Rosenthal.

Source/WebCore:

TextureMapperGL always uses a premultiplied color, so we must convert
an unmultiplied color to a premultiplied color before setting the uniform value of
colorLocation.

Test: compositing/background-color/background-color-alpha-with-opacity.html

* platform/graphics/texmap/TextureMapperGL.cpp:
(WebCore::TextureMapperGL::drawBorder):
(WebCore::TextureMapperGL::drawSolidColor):
(WebCore::prepareFilterProgram):
* platform/graphics/texmap/TextureMapperLayer.cpp:
(WebCore::blendWithOpacity):
(WebCore):
(WebCore::TextureMapperLayer::paintSelf):
TextureMapperLayer must not convert solidColor to premultiplied
color, because TextureMapperImageBuffer expects unmultiplied color.

LayoutTests:

Created new tests for composited background colors with fractional
number opacity. This test is similar to background-color-alpha.html

* compositing/background-color/background-color-alpha-with-opacity-expected.html: Added.
* compositing/background-color/background-color-alpha-with-opacity.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/texmap/TextureMapperGL.cpp
trunk/Source/WebCore/platform/graphics/texmap/TextureMapperLayer.cpp


Added Paths

trunk/LayoutTests/compositing/background-color/background-color-alpha-with-opacity-expected.html
trunk/LayoutTests/compositing/background-color/background-color-alpha-with-opacity.html




Diff

Modified: trunk/LayoutTests/ChangeLog (139673 => 139674)

--- trunk/LayoutTests/ChangeLog	2013-01-14 23:02:19 UTC (rev 139673)
+++ trunk/LayoutTests/ChangeLog	2013-01-14 23:11:04 UTC (rev 139674)
@@ -1,3 +1,16 @@
+2013-01-14  Huang Dongsung  luxte...@company100.net
+
+[TexMap] Use a premuliplied color in TextureMapperGL.
+https://bugs.webkit.org/show_bug.cgi?id=105786
+
+Reviewed by Noam Rosenthal.
+
+Created new tests for composited background colors with fractional
+number opacity. This test is similar to background-color-alpha.html
+
+* compositing/background-color/background-color-alpha-with-opacity-expected.html: Added.
+* compositing/background-color/background-color-alpha-with-opacity.html: Added.
+
 2013-01-14  Arko Saha  a...@motorola.com
 
 Microdata: REGRESSION(r138725): Causes crash in chromium port


Added: trunk/LayoutTests/compositing/background-color/background-color-alpha-with-opacity-expected.html (0 => 139674)

--- trunk/LayoutTests/compositing/background-color/background-color-alpha-with-opacity-expected.html	(rev 0)
+++ trunk/LayoutTests/compositing/background-color/background-color-alpha-with-opacity-expected.html	2013-01-14 23:11:04 UTC (rev 139674)
@@ -0,0 +1,31 @@
+html
+head
+style type=text/css
+.green {
+width: 100px;
+height: 100px;
+background-color: rgba(0, 128, 0, 128);
+opacity: 0.5;
+display: block;
+}
+.blue {
+width: 100px;
+height: 100px;
+background-color: rgba(0, 0, 128, 128);
+opacity: 0.5;
+display: block;
+-webkit-transform: translate(50px, 50px);
+}
+
+.composited {
+-webkit-transform-style: preserve-3d;
+}
+/style
+/head
+body
+div class=green
+div class=blue
+/div
+/div
+/body
+/html
\ No newline at end of file


Added: trunk/LayoutTests/compositing/background-color/background-color-alpha-with-opacity.html (0 => 139674)

--- trunk/LayoutTests/compositing/background-color/background-color-alpha-with-opacity.html	(rev 0)
+++ trunk/LayoutTests/compositing/background-color/background-color-alpha-with-opacity.html	2013-01-14 23:11:04 UTC (rev 139674)
@@ -0,0 +1,31 @@
+html
+head
+style type=text/css
+.green {
+width: 100px;
+height: 100px;
+background-color: rgba(0, 128, 0, 128);
+opacity: 0.5;
+display: block;
+}
+.blue {
+width: 100px;
+height: 100px;
+background-color: rgba(0, 0, 128, 128);
+opacity: 0.5;
+display: block;
+-webkit-transform: translate(50px, 50px);
+}
+
+.composited {
+-webkit-transform-style: preserve-3d;
+}
+/style
+/head
+body
+div class=green composited
+

[webkit-changes] [139675] trunk/Source/WebKit2

[commit-queue]

Title: [139675] trunk/Source/WebKit2








Revision 139675
Author commit-qu...@webkit.org
Date 2013-01-14 15:13:13 -0800 (Mon, 14 Jan 2013)


Log Message
[EFL] REGRESSION(r139189): MiniBrowser renders abnormally with -r option.
https://bugs.webkit.org/show_bug.cgi?id=106512

Patch by Huang Dongsung luxte...@company100.net on 2013-01-14
Reviewed by Kenneth Rohde Christiansen.

PageViewportController handles only pageScaleFactor after r139189. So
PageViewportControllerClientEFL calls EwkView::setScaleFactor() with
pageScaleFactor instead of pageScaleFactor * deviceScaleFactor.

This patch makes EwkView handle pageScaleFactor.
1. EwkView uses pageScaleFactor * deviceScaleFactor when drawing in
the device unit.
2. EwkView uses pageScaleFactor when notifying the scale to
PageViewportController.

* UIProcess/API/efl/EwkViewImpl.cpp:
(EwkViewImpl::EwkViewImpl):
(EwkViewImpl::deviceScaleFactor):
(EwkViewImpl::transformFromScene):
(EwkViewImpl::displayTimerFired):
* UIProcess/API/efl/EwkViewImpl.h:
(EwkViewImpl):
(EwkViewImpl::setPageScaleFactor):
(EwkViewImpl::pageScaleFactor):
* UIProcess/PageViewportController.cpp:
(WebKit::PageViewportController::didRenderFrame):
* UIProcess/PageViewportControllerClient.h:
(PageViewportControllerClient):
* UIProcess/efl/PageClientLegacyImpl.cpp:
(WebKit::PageClientLegacyImpl::updateViewportSize):
* UIProcess/efl/PageViewportControllerClientEfl.cpp:
(WebKit::PageViewportControllerClientEfl::setViewportPosition):
(WebKit::PageViewportControllerClientEfl::setPageScaleFactor):
(WebKit::PageViewportControllerClientEfl::didResumeContent):
* UIProcess/efl/PageViewportControllerClientEfl.h:
(PageViewportControllerClientEfl):
* UIProcess/qt/PageViewportControllerClientQt.cpp:
(WebKit::PageViewportControllerClientQt::setPageScaleFactor):
* UIProcess/qt/PageViewportControllerClientQt.h:
(PageViewportControllerClientQt):

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/efl/EwkViewImpl.cpp
trunk/Source/WebKit2/UIProcess/API/efl/EwkViewImpl.h
trunk/Source/WebKit2/UIProcess/PageViewportController.cpp
trunk/Source/WebKit2/UIProcess/PageViewportControllerClient.h
trunk/Source/WebKit2/UIProcess/efl/PageClientLegacyImpl.cpp
trunk/Source/WebKit2/UIProcess/efl/PageViewportControllerClientEfl.cpp
trunk/Source/WebKit2/UIProcess/efl/PageViewportControllerClientEfl.h
trunk/Source/WebKit2/UIProcess/qt/PageViewportControllerClientQt.cpp
trunk/Source/WebKit2/UIProcess/qt/PageViewportControllerClientQt.h




Diff

Modified: trunk/Source/WebKit2/ChangeLog (139674 => 139675)

--- trunk/Source/WebKit2/ChangeLog	2013-01-14 23:11:04 UTC (rev 139674)
+++ trunk/Source/WebKit2/ChangeLog	2013-01-14 23:13:13 UTC (rev 139675)
@@ -1,3 +1,46 @@
+2013-01-14  Huang Dongsung  luxte...@company100.net
+
+[EFL] REGRESSION(r139189): MiniBrowser renders abnormally with -r option.
+https://bugs.webkit.org/show_bug.cgi?id=106512
+
+Reviewed by Kenneth Rohde Christiansen.
+
+PageViewportController handles only pageScaleFactor after r139189. So
+PageViewportControllerClientEFL calls EwkView::setScaleFactor() with
+pageScaleFactor instead of pageScaleFactor * deviceScaleFactor.
+
+This patch makes EwkView handle pageScaleFactor.
+1. EwkView uses pageScaleFactor * deviceScaleFactor when drawing in
+the device unit.
+2. EwkView uses pageScaleFactor when notifying the scale to
+PageViewportController.
+
+* UIProcess/API/efl/EwkViewImpl.cpp:
+(EwkViewImpl::EwkViewImpl):
+(EwkViewImpl::deviceScaleFactor):
+(EwkViewImpl::transformFromScene):
+(EwkViewImpl::displayTimerFired):
+* UIProcess/API/efl/EwkViewImpl.h:
+(EwkViewImpl):
+(EwkViewImpl::setPageScaleFactor):
+(EwkViewImpl::pageScaleFactor):
+* UIProcess/PageViewportController.cpp:
+(WebKit::PageViewportController::didRenderFrame):
+* UIProcess/PageViewportControllerClient.h:
+(PageViewportControllerClient):
+* UIProcess/efl/PageClientLegacyImpl.cpp:
+(WebKit::PageClientLegacyImpl::updateViewportSize):
+* UIProcess/efl/PageViewportControllerClientEfl.cpp:
+(WebKit::PageViewportControllerClientEfl::setViewportPosition):
+(WebKit::PageViewportControllerClientEfl::setPageScaleFactor):
+(WebKit::PageViewportControllerClientEfl::didResumeContent):
+* UIProcess/efl/PageViewportControllerClientEfl.h:
+(PageViewportControllerClientEfl):
+* UIProcess/qt/PageViewportControllerClientQt.cpp:
+(WebKit::PageViewportControllerClientQt::setPageScaleFactor):
+* UIProcess/qt/PageViewportControllerClientQt.h:
+(PageViewportControllerClientQt):
+
 2013-01-14  Max Vujovic  mvujo...@adobe.com
 
 [ANGLE] Update ANGLE in WebKit


Modified: trunk/Source/WebKit2/UIProcess/API/efl/EwkViewImpl.cpp (139674 => 139675)

--- trunk/Source/WebKit2/UIProcess/API/efl/EwkViewImpl.cpp	2013-01-14 

[webkit-changes] [139676] trunk/LayoutTests

[leviw]

Title: [139676] trunk/LayoutTests








Revision 139676
Author le...@chromium.org
Date 2013-01-14 15:44:10 -0800 (Mon, 14 Jan 2013)


Log Message
Unreviewed gardening. Marking fast/borders/outline-alpha-inline.html as failing image results.
Likely Stephen Schenney's skia changes are to blame.

* platform/chromium/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (139675 => 139676)

--- trunk/LayoutTests/ChangeLog	2013-01-14 23:13:13 UTC (rev 139675)
+++ trunk/LayoutTests/ChangeLog	2013-01-14 23:44:10 UTC (rev 139676)
@@ -1,3 +1,10 @@
+2013-01-14  Levi Weintraub  le...@chromium.org
+
+Unreviewed gardening. Marking fast/borders/outline-alpha-inline.html as failing image results.
+Likely Stephen Schenney's skia changes are to blame.
+
+* platform/chromium/TestExpectations:
+
 2013-01-14  Huang Dongsung  luxte...@company100.net
 
 [TexMap] Use a premuliplied color in TextureMapperGL.


Modified: trunk/LayoutTests/platform/chromium/TestExpectations (139675 => 139676)

--- trunk/LayoutTests/platform/chromium/TestExpectations	2013-01-14 23:13:13 UTC (rev 139675)
+++ trunk/LayoutTests/platform/chromium/TestExpectations	2013-01-14 23:44:10 UTC (rev 139676)
@@ -4365,3 +4365,4 @@
 Bug(schenney) svg/W3C-SVG-1.2-Tiny/struct-use-recursion-03-t.svg [ ImageOnlyFailure ]
 
 webkit.org/b/106810 [ Debug ] fast/dom/HTMLTemplateElement/inertContents.html [ Pass Failure ]
+webkit.org/b/106833 fast/borders/outline-alpha-inline.html [ Pass ImageOnlyFailure ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [139677] trunk/LayoutTests

[leviw]

Title: [139677] trunk/LayoutTests








Revision 139677
Author le...@chromium.org
Date 2013-01-14 15:49:00 -0800 (Mon, 14 Jan 2013)


Log Message
Unreviewed gardening. Marking fast/image/zoomed-offset-size.html as slow on debug.

* platform/chromium/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (139676 => 139677)

--- trunk/LayoutTests/ChangeLog	2013-01-14 23:44:10 UTC (rev 139676)
+++ trunk/LayoutTests/ChangeLog	2013-01-14 23:49:00 UTC (rev 139677)
@@ -1,5 +1,11 @@
 2013-01-14  Levi Weintraub  le...@chromium.org
 
+Unreviewed gardening. Marking fast/image/zoomed-offset-size.html as slow on debug.
+
+* platform/chromium/TestExpectations:
+
+2013-01-14  Levi Weintraub  le...@chromium.org
+
 Unreviewed gardening. Marking fast/borders/outline-alpha-inline.html as failing image results.
 Likely Stephen Schenney's skia changes are to blame.
 


Modified: trunk/LayoutTests/platform/chromium/TestExpectations (139676 => 139677)

--- trunk/LayoutTests/platform/chromium/TestExpectations	2013-01-14 23:44:10 UTC (rev 139676)
+++ trunk/LayoutTests/platform/chromium/TestExpectations	2013-01-14 23:49:00 UTC (rev 139677)
@@ -96,6 +96,7 @@
 webkit.org/b/106606 fast/canvas/webgl/context-release-upon-reload.html [ Pass Slow ]
 webkit.org/b/106606 platform/chromium/virtual/gpu/fast/canvas/webgl/context-release-upon-reload.html [ Pass Slow ]
 crbug.com/24182 [ Debug ] media/track/track-css-cue-lifetime.html [ Pass Timeout ]
+crbug.com/24182 [ Debug ] fast/images/zoomed-offset-size.html [ Pass Slow ]
 
 # These tests started being slow when we switched to DRT.
 webkit.org/b/90488 [ Debug ] inspector [ Pass Slow ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [139678] trunk/Source/WebCore

[crogers]

Title: [139678] trunk/Source/WebCore








Revision 139678
Author crog...@google.com
Date 2013-01-14 15:49:56 -0800 (Mon, 14 Jan 2013)


Log Message
Switch AudioDestinationChromium over to new createAudioDevice() method
https://bugs.webkit.org/show_bug.cgi?id=106816

Reviewed by James Robinson.

* platform/audio/chromium/AudioDestinationChromium.cpp:
(WebCore::AudioDestinationChromium::AudioDestinationChromium):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/audio/chromium/AudioDestinationChromium.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (139677 => 139678)

--- trunk/Source/WebCore/ChangeLog	2013-01-14 23:49:00 UTC (rev 139677)
+++ trunk/Source/WebCore/ChangeLog	2013-01-14 23:49:56 UTC (rev 139678)
@@ -1,3 +1,13 @@
+2013-01-14  Chris Rogers  crog...@google.com
+
+Switch AudioDestinationChromium over to new createAudioDevice() method
+https://bugs.webkit.org/show_bug.cgi?id=106816
+
+Reviewed by James Robinson.
+
+* platform/audio/chromium/AudioDestinationChromium.cpp:
+(WebCore::AudioDestinationChromium::AudioDestinationChromium):
+
 2013-01-14  Huang Dongsung  luxte...@company100.net
 
 [TexMap] Use a premuliplied color in TextureMapperGL.


Modified: trunk/Source/WebCore/platform/audio/chromium/AudioDestinationChromium.cpp (139677 => 139678)

--- trunk/Source/WebCore/platform/audio/chromium/AudioDestinationChromium.cpp	2013-01-14 23:49:00 UTC (rev 139677)
+++ trunk/Source/WebCore/platform/audio/chromium/AudioDestinationChromium.cpp	2013-01-14 23:49:56 UTC (rev 139678)
@@ -66,8 +66,7 @@
 if (m_callbackBufferSize + renderBufferSize  fifoSize)
 return;
 
-// FIXME: switch to new API (with input channels) once chromium supports it.
-m_audioDevice = adoptPtr(WebKit::Platform::current()-createAudioDevice(m_callbackBufferSize, numberOfOutputChannels, sampleRate, this));
+m_audioDevice = adoptPtr(WebKit::Platform::current()-createAudioDevice(m_callbackBufferSize, numberOfInputChannels, numberOfOutputChannels, sampleRate, this));
 ASSERT(m_audioDevice);
 
 // Create a FIFO to handle the possibility of the callback size






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [139679] trunk/Tools

[dpranke]

Title: [139679] trunk/Tools








Revision 139679
Author dpra...@chromium.org
Date 2013-01-14 15:50:42 -0800 (Mon, 14 Jan 2013)


Log Message
nrwt: use the same search path for baselines and TestExpectations on apple mac
https://bugs.webkit.org/show_bug.cgi?id=105599

Reviewed by Ryosuke Niwa.

Bug 105583 revealed some confusion due to the fact that the Apple
Mac port used a different list of directories to search for baselines
and TestExpectations files (actually, pretty much every port does).

It seems like a good idea to use the same list for both by default, but
making this happen will affect every port in slightly different ways, so
we'll try this on the Apple Mac port first.

Note that the effective changes for this are that:
1) The apple mac port will look in platform/wk2 for baselines where
it didn't before (it will look after looking in mac-wk2 but before
the non-wk2 dirs)
2) The apple mac-snowleopard port will use the expectations in
mac-lion as well as the expectations in mac-snowleopard, although
I'm not even sure if mac-snowleopard is still supported ...

* Scripts/webkitpy/layout_tests/port/mac.py:
(MacPort.default_baseline_search_path):
(MacPort.expectations_files):
* Scripts/webkitpy/layout_tests/port/mac_unittest.py:
(test_baseline_search_path):

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/layout_tests/port/mac.py
trunk/Tools/Scripts/webkitpy/layout_tests/port/mac_unittest.py




Diff

Modified: trunk/Tools/ChangeLog (139678 => 139679)

--- trunk/Tools/ChangeLog	2013-01-14 23:49:56 UTC (rev 139678)
+++ trunk/Tools/ChangeLog	2013-01-14 23:50:42 UTC (rev 139679)
@@ -1,3 +1,32 @@
+2013-01-14  Dirk Pranke  dpra...@chromium.org
+
+nrwt: use the same search path for baselines and TestExpectations on apple mac
+https://bugs.webkit.org/show_bug.cgi?id=105599
+
+Reviewed by Ryosuke Niwa.
+
+Bug 105583 revealed some confusion due to the fact that the Apple
+Mac port used a different list of directories to search for baselines
+and TestExpectations files (actually, pretty much every port does).
+
+It seems like a good idea to use the same list for both by default, but
+making this happen will affect every port in slightly different ways, so
+we'll try this on the Apple Mac port first.
+
+Note that the effective changes for this are that:
+1) The apple mac port will look in platform/wk2 for baselines where
+it didn't before (it will look after looking in mac-wk2 but before
+the non-wk2 dirs)
+2) The apple mac-snowleopard port will use the expectations in
+mac-lion as well as the expectations in mac-snowleopard, although
+I'm not even sure if mac-snowleopard is still supported ...
+
+* Scripts/webkitpy/layout_tests/port/mac.py:
+(MacPort.default_baseline_search_path):
+(MacPort.expectations_files):
+* Scripts/webkitpy/layout_tests/port/mac_unittest.py:
+(test_baseline_search_path):
+
 2013-01-14  Dominic Mazzoni  dmazz...@google.com
 
 AX: Need to implement ColorWellRole


Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/mac.py (139678 => 139679)

--- trunk/Tools/Scripts/webkitpy/layout_tests/port/mac.py	2013-01-14 23:49:56 UTC (rev 139678)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/port/mac.py	2013-01-14 23:50:42 UTC (rev 139679)
@@ -79,10 +79,12 @@
 else:
 fallback_names = self.VERSION_FALLBACK_ORDER[self.VERSION_FALLBACK_ORDER.index(name):-1] + [self.port_name]
 if self.get_option('webkit_test_runner'):
-fallback_names.insert(0, self._wk2_port_name())
-# Note we do not add 'wk2' here, even though it's included in _skipped_search_paths().
+fallback_names = [self._wk2_port_name(), 'wk2'] + fallback_names
 return map(self._webkit_baseline_path, fallback_names)
 
+def expectations_files(self):
+return reversed([self._filesystem.join(self._webkit_baseline_path(d), 'TestExpectations') for d in self.baseline_search_path()])
+
 def setup_environ_for_server(self, server_name=None):
 env = super(MacPort, self).setup_environ_for_server(server_name)
 if server_name == self.driver_name():


Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/mac_unittest.py (139678 => 139679)

--- trunk/Tools/Scripts/webkitpy/layout_tests/port/mac_unittest.py	2013-01-14 23:49:56 UTC (rev 139678)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/port/mac_unittest.py	2013-01-14 23:50:42 UTC (rev 139679)
@@ -130,10 +130,10 @@
 self._assert_search_path('mac-lion', 'mac-lion', ['mac-lion', 'mac'])
 self._assert_search_path('mac-mountainlion', 'mac', ['mac'])
 self._assert_search_path('mac-future', 'mac', ['mac'])
-self._assert_search_path('mac-snowleopard', 'mac-wk2', ['mac-wk2', 'mac-snowleopard', 'mac-lion', 'mac'], use_webkit2=True)
-self._assert_search_path('mac-lion', 

[webkit-changes] [139680] trunk/Source/WebCore

[ojan]

Title: [139680] trunk/Source/WebCore








Revision 139680
Author o...@chromium.org
Date 2013-01-14 15:53:51 -0800 (Mon, 14 Jan 2013)


Log Message
Remove unnecessary setNeedsLayoutAndPrefWidthsRecalc from RenderTable
https://bugs.webkit.org/show_bug.cgi?id=106832

Reviewed by Levi Weintraub.

These are both called from locations that either set these bits themselves
or clearly don't need these bits set (e.g. computePreferredLogicalWidths).

* rendering/RenderTable.cpp:
(WebCore::RenderTable::splitColumn):
(WebCore::RenderTable::appendColumn):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderTable.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (139679 => 139680)

--- trunk/Source/WebCore/ChangeLog	2013-01-14 23:50:42 UTC (rev 139679)
+++ trunk/Source/WebCore/ChangeLog	2013-01-14 23:53:51 UTC (rev 139680)
@@ -1,3 +1,17 @@
+2013-01-14  Ojan Vafai  o...@chromium.org
+
+Remove unnecessary setNeedsLayoutAndPrefWidthsRecalc from RenderTable
+https://bugs.webkit.org/show_bug.cgi?id=106832
+
+Reviewed by Levi Weintraub.
+
+These are both called from locations that either set these bits themselves
+or clearly don't need these bits set (e.g. computePreferredLogicalWidths).
+
+* rendering/RenderTable.cpp:
+(WebCore::RenderTable::splitColumn):
+(WebCore::RenderTable::appendColumn):
+
 2013-01-14  Chris Rogers  crog...@google.com
 
 Switch AudioDestinationChromium over to new createAudioDevice() method


Modified: trunk/Source/WebCore/rendering/RenderTable.cpp (139679 => 139680)

--- trunk/Source/WebCore/rendering/RenderTable.cpp	2013-01-14 23:50:42 UTC (rev 139679)
+++ trunk/Source/WebCore/rendering/RenderTable.cpp	2013-01-14 23:53:51 UTC (rev 139680)
@@ -758,7 +758,6 @@
 }
 
 m_columnPos.grow(numEffCols() + 1);
-setNeedsLayoutAndPrefWidthsRecalc();
 }
 
 void RenderTable::appendColumn(unsigned span)
@@ -780,7 +779,6 @@
 }
 
 m_columnPos.grow(numEffCols() + 1);
-setNeedsLayoutAndPrefWidthsRecalc();
 }
 
 RenderTableCol* RenderTable::firstColumn() const






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [139681] trunk/Source/WebCore

[rniwa]

Title: [139681] trunk/Source/WebCore








Revision 139681
Author rn...@webkit.org
Date 2013-01-14 15:57:39 -0800 (Mon, 14 Jan 2013)


Log Message
Move functions from NodeRareData to ElementRareData and other classes
https://bugs.webkit.org/show_bug.cgi?id=106679

Reviewed by Benjamin Poulain.

Moved tab index related functions from NodeRareData to ElementRareData since only
HTMLElement uses them, and moved related functions on Node to Element accordingly.

Also replaced transientMutationObserverRegistry and ensureTransientMutationObserverRegistry
by ensureMutationObserverData, and moved micro-data related member functions into
NodeMicroDataTokenLists, and moved NodeMutationObserverData and NodeMicroDataTokenLists
out of NodeRareData as they're used outside of NodeRareData now.

The intention is to move more code into NodeMutationObserverData and NodeMicroDataTokenLists
in the follow up patches so that they can detect the removability of NodeRareData.

No new tests are added since there should be no behavior changes.

* dom/Element.cpp:
(WebCore::Element::clearTabIndexExplicitlyIfNeeded):
(WebCore::Element::setTabIndexExplicitly):
(WebCore::Element::tabIndex):
(WebCore::Element::supportsFocus):
* dom/Element.h:
(Element):
* dom/ElementRareData.h:
(ElementRareData):
(WebCore::ElementRareData::tabIndex):
(WebCore::ElementRareData::setTabIndexExplicitly):
(WebCore::ElementRareData::tabIndexSetExplicitly):
(WebCore::ElementRareData::clearTabIndexExplicitly):
* dom/Node.cpp:
(WebCore::Node::tabIndex):
(WebCore::Node::supportsFocus):
(WebCore::Node::mutationObserverRegistry):
(WebCore::Node::transientMutationObserverRegistry):
(WebCore::Node::registerMutationObserver):
(WebCore::Node::registerTransientMutationObserver):
(WebCore::Node::itemProp):
(WebCore::Node::setItemProp):
(WebCore::Node::itemRef):
(WebCore::Node::setItemRef):
(WebCore::Node::itemType):
(WebCore::Node::setItemType):
* dom/Node.h:
(Node):
* dom/NodeRareData.h:
(NodeMutationObserverData):
(WebCore::NodeMutationObserverData::create):
(NodeMicroDataTokenLists):
(WebCore::NodeMicroDataTokenLists::create):
(WebCore::NodeMicroDataTokenLists::itemProp):
(WebCore::NodeMicroDataTokenLists::itemRef):
(WebCore::NodeMicroDataTokenLists::itemType):
(NodeRareData):
(WebCore::NodeRareData::mutationObserverData):
(WebCore::NodeRareData::ensureMutationObserverData):
(WebCore::NodeRareData::ensureMicroDataTokenLists):
* html/HTMLElement.cpp:
(WebCore::HTMLElement::parseAttribute):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/Element.cpp
trunk/Source/WebCore/dom/Element.h
trunk/Source/WebCore/dom/ElementRareData.h
trunk/Source/WebCore/dom/Node.cpp
trunk/Source/WebCore/dom/Node.h
trunk/Source/WebCore/dom/NodeRareData.cpp
trunk/Source/WebCore/dom/NodeRareData.h
trunk/Source/WebCore/html/HTMLElement.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (139680 => 139681)

--- trunk/Source/WebCore/ChangeLog	2013-01-14 23:53:51 UTC (rev 139680)
+++ trunk/Source/WebCore/ChangeLog	2013-01-14 23:57:39 UTC (rev 139681)
@@ -1,3 +1,66 @@
+2013-01-11  Ryosuke Niwa  rn...@webkit.org
+
+Move functions from NodeRareData to ElementRareData and other classes
+https://bugs.webkit.org/show_bug.cgi?id=106679
+
+Reviewed by Benjamin Poulain.
+
+Moved tab index related functions from NodeRareData to ElementRareData since only
+HTMLElement uses them, and moved related functions on Node to Element accordingly.
+
+Also replaced transientMutationObserverRegistry and ensureTransientMutationObserverRegistry
+by ensureMutationObserverData, and moved micro-data related member functions into
+NodeMicroDataTokenLists, and moved NodeMutationObserverData and NodeMicroDataTokenLists
+out of NodeRareData as they're used outside of NodeRareData now.
+
+The intention is to move more code into NodeMutationObserverData and NodeMicroDataTokenLists
+in the follow up patches so that they can detect the removability of NodeRareData.
+
+No new tests are added since there should be no behavior changes.
+
+* dom/Element.cpp:
+(WebCore::Element::clearTabIndexExplicitlyIfNeeded):
+(WebCore::Element::setTabIndexExplicitly):
+(WebCore::Element::tabIndex):
+(WebCore::Element::supportsFocus):
+* dom/Element.h:
+(Element):
+* dom/ElementRareData.h:
+(ElementRareData):
+(WebCore::ElementRareData::tabIndex):
+(WebCore::ElementRareData::setTabIndexExplicitly):
+(WebCore::ElementRareData::tabIndexSetExplicitly):
+(WebCore::ElementRareData::clearTabIndexExplicitly):
+* dom/Node.cpp:
+(WebCore::Node::tabIndex):
+(WebCore::Node::supportsFocus):
+(WebCore::Node::mutationObserverRegistry):
+(WebCore::Node::transientMutationObserverRegistry):
+(WebCore::Node::registerMutationObserver):
+(WebCore::Node::registerTransientMutationObserver):
+

[webkit-changes] [139682] trunk/Source/JavaScriptCore

[roger_fong]

Title: [139682] trunk/Source/_javascript_Core








Revision 139682
Author roger_f...@apple.com
Date 2013-01-14 16:09:03 -0800 (Mon, 14 Jan 2013)


Log Message
Unreviewed. Fix vcproj file. Missing file tag after http://trac.webkit.org/changeset/139541.

* _javascript_Core.vcproj/_javascript_Core/_javascript_Core.vcproj:

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/_javascript_Core.vcproj/_javascript_Core/_javascript_Core.vcproj




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (139681 => 139682)

--- trunk/Source/_javascript_Core/ChangeLog	2013-01-14 23:57:39 UTC (rev 139681)
+++ trunk/Source/_javascript_Core/ChangeLog	2013-01-15 00:09:03 UTC (rev 139682)
@@ -1,3 +1,9 @@
+2013-01-14  Roger Fong  roger_f...@apple.com
+
+Unreviewed. Fix vcproj file. Missing file tag after http://trac.webkit.org/changeset/139541.
+
+* _javascript_Core.vcproj/_javascript_Core/_javascript_Core.vcproj:
+
 2013-01-13  Filip Pizlo  fpi...@apple.com
 
 DFG phases that store per-node information should store it in Node itself rather than using a secondary vector


Modified: trunk/Source/_javascript_Core/_javascript_Core.vcproj/_javascript_Core/_javascript_Core.vcproj (139681 => 139682)

--- trunk/Source/_javascript_Core/_javascript_Core.vcproj/_javascript_Core/_javascript_Core.vcproj	2013-01-14 23:57:39 UTC (rev 139681)
+++ trunk/Source/_javascript_Core/_javascript_Core.vcproj/_javascript_Core/_javascript_Core.vcproj	2013-01-15 00:09:03 UTC (rev 139682)
@@ -2197,6 +2197,7 @@
 RelativePath=..\..\jit\JITStubs.h
 
 			/File
+File
 RelativePath=..\..\jit\JITThunks.cpp
 
 			/File






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [139684] trunk/LayoutTests

[leviw]

Title: [139684] trunk/LayoutTests








Revision 139684
Author le...@chromium.org
Date 2013-01-14 16:12:51 -0800 (Mon, 14 Jan 2013)


Log Message
Unreviewed gardening. Fixing Mac results for fast/repaint/overhanging-float-detach-repaint.html.

* platform/chromium-mac-lion/fast/repaint/overhanging-float-detach-repaint-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/repaint/overhanging-float-detach-repaint-expected.png: Added.
* platform/chromium-mac/fast/repaint/overhanging-float-detach-repaint-expected.png: Added.

Modified Paths

trunk/LayoutTests/ChangeLog


Added Paths

trunk/LayoutTests/platform/chromium-mac/fast/repaint/overhanging-float-detach-repaint-expected.png
trunk/LayoutTests/platform/chromium-mac-lion/fast/repaint/overhanging-float-detach-repaint-expected.png
trunk/LayoutTests/platform/chromium-mac-snowleopard/fast/repaint/overhanging-float-detach-repaint-expected.png




Diff

Modified: trunk/LayoutTests/ChangeLog (139683 => 139684)

--- trunk/LayoutTests/ChangeLog	2013-01-15 00:10:05 UTC (rev 139683)
+++ trunk/LayoutTests/ChangeLog	2013-01-15 00:12:51 UTC (rev 139684)
@@ -1,3 +1,11 @@
+2013-01-14  Levi Weintraub  le...@chromium.org
+
+Unreviewed gardening. Fixing Mac results for fast/repaint/overhanging-float-detach-repaint.html.
+
+* platform/chromium-mac-lion/fast/repaint/overhanging-float-detach-repaint-expected.png: Added.
+* platform/chromium-mac-snowleopard/fast/repaint/overhanging-float-detach-repaint-expected.png: Added.
+* platform/chromium-mac/fast/repaint/overhanging-float-detach-repaint-expected.png: Added.
+
 2013-01-14  Nate Chapin  jap...@chromium.org
 
 Enable reuse of cached main resources


Added: trunk/LayoutTests/platform/chromium-mac/fast/repaint/overhanging-float-detach-repaint-expected.png

(Binary files differ)

Property changes on: trunk/LayoutTests/platform/chromium-mac/fast/repaint/overhanging-float-detach-repaint-expected.png
___

Added: svn:mime-type

Added: trunk/LayoutTests/platform/chromium-mac-lion/fast/repaint/overhanging-float-detach-repaint-expected.png

(Binary files differ)

Property changes on: trunk/LayoutTests/platform/chromium-mac-lion/fast/repaint/overhanging-float-detach-repaint-expected.png
___

Added: svn:mime-type

Added: trunk/LayoutTests/platform/chromium-mac-snowleopard/fast/repaint/overhanging-float-detach-repaint-expected.png

(Binary files differ)

Property changes on: trunk/LayoutTests/platform/chromium-mac-snowleopard/fast/repaint/overhanging-float-detach-repaint-expected.png
___

Added: svn:mime-type




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [139685] trunk/Source/WebKit2

[ap]

Title: [139685] trunk/Source/WebKit2








Revision 139685
Author a...@apple.com
Date 2013-01-14 16:45:46 -0800 (Mon, 14 Jan 2013)


Log Message
rdar://problem/12524710 Update sandbox rules after r128003
https://bugs.webkit.org/show_bug.cgi?id=106840

Reviewed by Anders Carlsson.

* WebProcess/com.apple.WebProcess.sb.in:

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/WebProcess/com.apple.WebProcess.sb.in




Diff

Modified: trunk/Source/WebKit2/ChangeLog (139684 => 139685)

--- trunk/Source/WebKit2/ChangeLog	2013-01-15 00:12:51 UTC (rev 139684)
+++ trunk/Source/WebKit2/ChangeLog	2013-01-15 00:45:46 UTC (rev 139685)
@@ -1,3 +1,12 @@
+2013-01-14  Alexey Proskuryakov  a...@apple.com
+
+rdar://problem/12524710 Update sandbox rules after r128003
+https://bugs.webkit.org/show_bug.cgi?id=106840
+
+Reviewed by Anders Carlsson.
+
+* WebProcess/com.apple.WebProcess.sb.in:
+
 2013-01-14  Huang Dongsung  luxte...@company100.net
 
 [EFL] REGRESSION(r139189): MiniBrowser renders abnormally with -r option.


Modified: trunk/Source/WebKit2/WebProcess/com.apple.WebProcess.sb.in (139684 => 139685)

--- trunk/Source/WebKit2/WebProcess/com.apple.WebProcess.sb.in	2013-01-15 00:12:51 UTC (rev 139684)
+++ trunk/Source/WebKit2/WebProcess/com.apple.WebProcess.sb.in	2013-01-15 00:45:46 UTC (rev 139685)
@@ -47,6 +47,7 @@
(home-literal /Library/Preferences/com.apple.DownloadAssessment.plist)
(home-literal /Library/Preferences/com.apple.HIToolbox.plist)
(home-literal /Library/Preferences/com.apple.LaunchServices.plist)
+   (home-literal /Library/Preferences/com.apple.MultitouchSupport.plist) ;; FIXME: Remove when rdar://problem/13011633 is fixed.
(home-literal /Library/Preferences/com.apple.QTKit.plist)
(home-literal /Library/Preferences/com.apple.WebFoundation.plist)
(home-literal /Library/Preferences/com.apple.avfoundation.plist)
@@ -73,9 +74,7 @@
(subpath /Library/Video/Plug-Ins)
(subpath /Library/QuickTime)
 
-   (home-subpath /Library/Dictionaries)
-   (home-subpath /Library/Keyboard Layouts)
-   (home-subpath /Library/Input Methods))
+   (home-subpath /Library/Dictionaries))
 
 ;; This should be updated when rdar://problem/9355830 is fixed.
 ;; Read-only extensions from UIProcess
@@ -200,6 +199,15 @@
(home-literal /Library/Preferences/com.apple.LaunchServices.QuarantineEventsV2)
(home-literal /Library/Preferences/com.apple.LaunchServices.QuarantineEventsV2-journal))
 
+(deny file-read* (with no-log)
+   ;; FIXME: This should not be necessary once rdar://problem/13011633 is fixed.
+   (subpath /Library/Components)
+   (subpath /Library/Keyboard Layouts)
+   (subpath /Library/Input Methods)
+   (home-subpath /Library/Components)
+   (home-subpath /Library/Keyboard Layouts)
+   (home-subpath /Library/Input Methods))
+
 (deny mach-lookup (with no-log)
(global-name com.apple.coreservices.appleevents))
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [139687] trunk

[fpizlo]

Title: [139687] trunk








Revision 139687
Author fpi...@apple.com
Date 2013-01-14 16:53:39 -0800 (Mon, 14 Jan 2013)


Log Message
Python implementation reports MemoryError instead of doing things
https://bugs.webkit.org/show_bug.cgi?id=106690

Source/_javascript_Core: 

Reviewed by Oliver Hunt.

The bug was that the CFA was assuming that a variable is dead at the end of a basic block and hence doesn't need to
be merged to the next block if the last mention of the variable was dead. This is almost correct, except that it
doesn't work if the last mention is a GetLocal - the GetLocal itself may be dead, but that doesn't mean that the
variable is dead - it may still be live. The appropriate thing to do is to look at the GetLocal's Phi. If the
variable is used in the next block then the next block will have a reference to the last mention in our block unless
that last mention is a GetLocal, in which case it will link to the Phi. Doing it this way captures everything that
the CFA wants: if the last use is a live GetLocal then the CFA needs to consider the GetLocal itself for possible
refinements to the proof of the value in the variable, but if the GetLocal is dead, then this must mean that the
variable is not mentioned in the block but may still be passed through it, which is what the Phi will tell us.
Note that it is not possible for the GetLocal to refer to anything other than a Phi, and it is also not possible
for the last mention of a variable to be a dead GetLocal while there are other mentions that aren't dead - if
there had been SetLocals or GetLocals prior to the dead one then the dead one wouldn't have been emitted by the
parser.

This also fixes a similar bug in the handling of captured variables. If a variable is captured, then it doesn't
matter if the last mention is dead, or not. Either way, we already know that a captured variable will be live in
the next block, so we must merge it no matter what.

Finally, this change makes the output of Operands dumping a bit more verbose: it now prints the variable name next
to each variable's dump. I've often found the lack of this information confusing particularly for operand dumps
that involve a lot of variables.

* bytecode/Operands.h:
(JSC::dumpOperands):
* dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::mergeStateAtTail):

LayoutTests: 

Reviewed by Oliver Hunt.

* fast/js/dfg-cfa-merge-with-dead-use-at-tail-expected.txt: Added.
* fast/js/dfg-cfa-merge-with-dead-use-at-tail.html: Added.
* fast/js/jsc-test-list:
* fast/js/script-tests/dfg-cfa-merge-with-dead-use-at-tail.js: Added.
(foo):

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/js/jsc-test-list
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/bytecode/Operands.h
trunk/Source/_javascript_Core/dfg/DFGAbstractState.cpp


Added Paths

trunk/LayoutTests/fast/js/dfg-cfa-merge-with-dead-use-at-tail-expected.txt
trunk/LayoutTests/fast/js/dfg-cfa-merge-with-dead-use-at-tail.html
trunk/LayoutTests/fast/js/script-tests/dfg-cfa-merge-with-dead-use-at-tail.js




Diff

Modified: trunk/LayoutTests/ChangeLog (139686 => 139687)

--- trunk/LayoutTests/ChangeLog	2013-01-15 00:51:30 UTC (rev 139686)
+++ trunk/LayoutTests/ChangeLog	2013-01-15 00:53:39 UTC (rev 139687)
@@ -1,3 +1,16 @@
+2013-01-11  Filip Pizlo  fpi...@apple.com
+
+Python implementation reports MemoryError instead of doing things
+https://bugs.webkit.org/show_bug.cgi?id=106690
+
+Reviewed by Oliver Hunt.
+
+* fast/js/dfg-cfa-merge-with-dead-use-at-tail-expected.txt: Added.
+* fast/js/dfg-cfa-merge-with-dead-use-at-tail.html: Added.
+* fast/js/jsc-test-list:
+* fast/js/script-tests/dfg-cfa-merge-with-dead-use-at-tail.js: Added.
+(foo):
+
 2013-01-14  Tien-Ren Chen  trc...@chromium.org
 
 Correct FrameView::scrollableAreaBoundingBox() calculation in the presence of transforms


Added: trunk/LayoutTests/fast/js/dfg-cfa-merge-with-dead-use-at-tail-expected.txt (0 => 139687)

--- trunk/LayoutTests/fast/js/dfg-cfa-merge-with-dead-use-at-tail-expected.txt	(rev 0)
+++ trunk/LayoutTests/fast/js/dfg-cfa-merge-with-dead-use-at-tail-expected.txt	2013-01-15 00:53:39 UTC (rev 139687)
@@ -0,0 +1,209 @@
+Tests that a dead use of a variable at the tail of a basic block doesn't confuse the CFA into believing that the variable being used is dead as well.
+
+On success, you will see a series of PASS messages, followed by TEST COMPLETE.
+
+
+PASS foo(false, true, 5) is 42
+PASS foo(false, true, 5) is 42
+PASS foo(false, true, 5) is 42
+PASS foo(false, true, 5) is 42
+PASS foo(false, true, 5) is 42
+PASS foo(false, true, 5) is 42
+PASS foo(false, true, 5) is 42
+PASS foo(false, true, 5) is 42
+PASS foo(false, true, 5) is 42
+PASS foo(false, true, 5) is 42
+PASS foo(false, true, 5) is 42
+PASS foo(false, true, 5) is 42
+PASS foo(false, true, 5) is 42
+PASS foo(false, true, 5) is 42
+PASS foo(false, true, 5) 

[webkit-changes] [139688] trunk/Source/JavaScriptCore

[fpizlo]

Title: [139688] trunk/Source/_javascript_Core








Revision 139688
Author fpi...@apple.com
Date 2013-01-14 16:56:35 -0800 (Mon, 14 Jan 2013)


Log Message
DFG should not forget that it had proved something to be a constant during a merge just because it's merging against the empty value
https://bugs.webkit.org/show_bug.cgi?id=106727

Reviewed by Oliver Hunt.

The problem was this statement:

if (m_value != other.m_value)
m_value = JSValue();

This is well-intentioned, in the sense that if we want our abstract value (i.e. this) to become the superset of the other
abstract value, and the two abstract values have proven different constants, then our abstract value should rescind its
claim that it has been proven to be constant. But this misses the special case that if the other abstract value is
completely clear (meaning that it wishes to contribute zero information and so the superset operation shouldn't change
this), it will have a clear m_value. So, the code prior to this patch would rescind the constant proof even though it
didn't have to.

This comes up rarely and I don't believe it will be a performance win, but it is good to have the CFA been consistently
precise as often as possible.

* dfg/DFGAbstractValue.h:
(JSC::DFG::AbstractValue::merge):

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/dfg/DFGAbstractValue.h




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (139687 => 139688)

--- trunk/Source/_javascript_Core/ChangeLog	2013-01-15 00:53:39 UTC (rev 139687)
+++ trunk/Source/_javascript_Core/ChangeLog	2013-01-15 00:56:35 UTC (rev 139688)
@@ -1,5 +1,30 @@
 2013-01-11  Filip Pizlo  fpi...@apple.com
 
+DFG should not forget that it had proved something to be a constant during a merge just because it's merging against the empty value
+https://bugs.webkit.org/show_bug.cgi?id=106727
+
+Reviewed by Oliver Hunt.
+
+The problem was this statement:
+
+if (m_value != other.m_value)
+m_value = JSValue();
+
+This is well-intentioned, in the sense that if we want our abstract value (i.e. this) to become the superset of the other
+abstract value, and the two abstract values have proven different constants, then our abstract value should rescind its
+claim that it has been proven to be constant. But this misses the special case that if the other abstract value is
+completely clear (meaning that it wishes to contribute zero information and so the superset operation shouldn't change
+this), it will have a clear m_value. So, the code prior to this patch would rescind the constant proof even though it
+didn't have to.
+
+This comes up rarely and I don't believe it will be a performance win, but it is good to have the CFA been consistently
+precise as often as possible.
+
+* dfg/DFGAbstractValue.h:
+(JSC::DFG::AbstractValue::merge):
+
+2013-01-11  Filip Pizlo  fpi...@apple.com
+
 Python implementation reports MemoryError instead of doing things
 https://bugs.webkit.org/show_bug.cgi?id=106690
 


Modified: trunk/Source/_javascript_Core/dfg/DFGAbstractValue.h (139687 => 139688)

--- trunk/Source/_javascript_Core/dfg/DFGAbstractValue.h	2013-01-15 00:53:39 UTC (rev 139687)
+++ trunk/Source/_javascript_Core/dfg/DFGAbstractValue.h	2013-01-15 00:56:35 UTC (rev 139688)
@@ -193,6 +193,9 @@
 
 bool merge(const AbstractValue other)
 {
+if (other.isClear())
+return false;
+
 #if !ASSERT_DISABLED
 AbstractValue oldMe = *this;
 #endif






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [139689] trunk/Tools

[thakis]

Title: [139689] trunk/Tools








Revision 139689
Author tha...@chromium.org
Date 2013-01-14 17:00:42 -0800 (Mon, 14 Jan 2013)


Log Message
[chromium] Enable `update-webkit --chromium --ninja` on windows
https://bugs.webkit.org/show_bug.cgi?id=106836

Reviewed by Eric Seidel.

After running this, build-webkit --chromium will use ninja to build.
Apparently there are some minor issues with that still, so it's
not quite ready for use yet.

* Scripts/webkitdirs.pm:
(determineIsChromiumNinja):
(buildChromium):

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitdirs.pm




Diff

Modified: trunk/Tools/ChangeLog (139688 => 139689)

--- trunk/Tools/ChangeLog	2013-01-15 00:56:35 UTC (rev 139688)
+++ trunk/Tools/ChangeLog	2013-01-15 01:00:42 UTC (rev 139689)
@@ -1,3 +1,18 @@
+2013-01-14  Nico Weber  tha...@chromium.org
+
+[chromium] Enable `update-webkit --chromium --ninja` on windows
+https://bugs.webkit.org/show_bug.cgi?id=106836
+
+Reviewed by Eric Seidel.
+
+After running this, build-webkit --chromium will use ninja to build.
+Apparently there are some minor issues with that still, so it's
+not quite ready for use yet.
+
+* Scripts/webkitdirs.pm:
+(determineIsChromiumNinja):
+(buildChromium):
+
 2013-01-14  Dirk Pranke  dpra...@chromium.org
 
 nrwt: use the same search path for baselines and TestExpectations on apple mac


Modified: trunk/Tools/Scripts/webkitdirs.pm (139688 => 139689)

--- trunk/Tools/Scripts/webkitdirs.pm	2013-01-15 00:56:35 UTC (rev 139688)
+++ trunk/Tools/Scripts/webkitdirs.pm	2013-01-15 01:00:42 UTC (rev 139689)
@@ -1220,7 +1220,12 @@
   $statMake = stat('Makefile.chromium')-mtime;
 }
 
-$hasUpToDateNinjabuild = $statNinja  $statXcode  $statNinja  $statMake;
+my $statVisualStudio = 0;
+if (-e 'Source/WebKit/chromium/All.sln') {
+  $statVisualStudio = stat('Source/WebKit/chromium/All.sln')-mtime;
+}
+
+$hasUpToDateNinjabuild = $statNinja  $statXcode  $statNinja  $statMake  $statNinja  $statVisualStudio;
 }
 $isChromiumNinja = $hasUpToDateNinjabuild;
 }
@@ -2552,7 +2557,7 @@
 if (isDarwin()  !isChromiumAndroid()  !isChromiumMacMake()  !isChromiumNinja()) {
 # Mac build - builds the root xcode project.
 $result = buildXCodeProject(Source/WebKit/chromium/All, $clean, -configuration, configuration(), @options);
-} elsif (isCygwin() || isWindows()) {
+} elsif ((isCygwin() || isWindows())  !isChromiumNinja()) {
 # Windows build - builds the root visual studio solution.
 $result = buildChromiumVisualStudioProject(Source/WebKit/chromium/All.sln, $clean);
 } elsif (isChromiumNinja()) {






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [139691] trunk

[wangxianzhu]

Title: [139691] trunk








Revision 139691
Author wangxian...@chromium.org
Date 2013-01-14 17:13:45 -0800 (Mon, 14 Jan 2013)


Log Message
Sometimes RenderLayer::updateNeedsCompositedScrolling is not called
https://bugs.webkit.org/show_bug.cgi?id=106271

Reviewed by Simon Fraser.

Source/WebCore:

1. If a layer has no out-of-flow descendant, m_hasOutOfFlowPositionedDescendant won't change and won't trigger updateNeedsCompositedScrolling in updateDescendantDependentFlags. Set m_hasOutOfFlowPositionedDescendantDirty to true and call updateNeedsCompositedScrolling when the dirty flag becomes false from true.
2. When the content size changes causing change of scrollable status, updateNeedsCompositedScrolling should also be called.

Test: compositing/overflow/dynamic-composited-scrolling-status.html

* page/FrameView.cpp:
(WebCore::FrameView::addScrollableArea): Returns whether the scrollable area has just been newly added.
(WebCore::FrameView::removeScrollableArea): Returns whether the scrollable area has just been removed.
* page/FrameView.h:
(FrameView):
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::RenderLayer): Changed the initial value of m_hasOutOfFlowPositionedDescendantDirty to true to make sure m_hasOutOfFlowPositionedDescendant will be updated initially.
(WebCore::RenderLayer::updateDescendantDependentFlags): Call updateNeedsCompositedScrolling when m_hasOutOfFlowPositionedDescendantDirty is true.
(RenderLayer::updateScrollableAreaSet): Calls updateNeedsCompositedScrolling() when scrollable status changes.
* rendering/RenderLayer.h:
(RenderLayer):

LayoutTests:

* compositing/overflow/dynamic-composited-scrolling-status-expected.txt: Added.
* compositing/overflow/dynamic-composited-scrolling-status.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/FrameView.cpp
trunk/Source/WebCore/page/FrameView.h
trunk/Source/WebCore/rendering/RenderLayer.cpp
trunk/Source/WebCore/rendering/RenderLayer.h


Added Paths

trunk/LayoutTests/compositing/overflow/dynamic-composited-scrolling-status-expected.txt
trunk/LayoutTests/compositing/overflow/dynamic-composited-scrolling-status.html




Diff

Modified: trunk/LayoutTests/ChangeLog (139690 => 139691)

--- trunk/LayoutTests/ChangeLog	2013-01-15 01:02:20 UTC (rev 139690)
+++ trunk/LayoutTests/ChangeLog	2013-01-15 01:13:45 UTC (rev 139691)
@@ -1,3 +1,13 @@
+2013-01-14  Xianzhu Wang  wangxian...@chromium.org
+
+Sometimes RenderLayer::updateNeedsCompositedScrolling is not called
+https://bugs.webkit.org/show_bug.cgi?id=106271
+
+Reviewed by Simon Fraser.
+
+* compositing/overflow/dynamic-composited-scrolling-status-expected.txt: Added.
+* compositing/overflow/dynamic-composited-scrolling-status.html: Added.
+
 2013-01-11  Filip Pizlo  fpi...@apple.com
 
 Python implementation reports MemoryError instead of doing things


Added: trunk/LayoutTests/compositing/overflow/dynamic-composited-scrolling-status-expected.txt (0 => 139691)

--- trunk/LayoutTests/compositing/overflow/dynamic-composited-scrolling-status-expected.txt	(rev 0)
+++ trunk/LayoutTests/compositing/overflow/dynamic-composited-scrolling-status-expected.txt	2013-01-15 01:13:45 UTC (rev 139691)
@@ -0,0 +1 @@
+PASS


Added: trunk/LayoutTests/compositing/overflow/dynamic-composited-scrolling-status.html (0 => 139691)

--- trunk/LayoutTests/compositing/overflow/dynamic-composited-scrolling-status.html	(rev 0)
+++ trunk/LayoutTests/compositing/overflow/dynamic-composited-scrolling-status.html	2013-01-15 01:13:45 UTC (rev 139691)
@@ -0,0 +1,44 @@
+!DOCTYPE html
+html
+head
+  style
+#container {
+  width: 200px;
+  height: 200px;
+  overflow: auto;
+}
+
+#content {
+  width: 100px;
+  height: 100px;
+  background-color: yellow;
+}
+  /style
+
+  script type=text/_javascript_ charset=utf-8
+if (window.testRunner)
+  testRunner.dumpAsText();
+
+if (window.internals)
+  window.internals.settings.setAcceleratedCompositingForOverflowScrollEnabled(true);
+
+function doTest()
+{
+  document.body.offsetHeight;
+  document.getElementById('content').style.height = '1000px';
+  if (window.internals)
+document.getElementById('result').innerText = window.internals.nonFastScrollableRects(document).length ? FAIL : PASS;
+}
+
+window.addEventListener('load', doTest, false);
+  /script
+/head
+
+body
+  div id=container
+div id=content/div
+  /div
+  pre id=result/pre
+/body
+/html
+


Modified: trunk/Source/WebCore/ChangeLog (139690 => 139691)

--- trunk/Source/WebCore/ChangeLog	2013-01-15 01:02:20 UTC (rev 139690)
+++ trunk/Source/WebCore/ChangeLog	2013-01-15 01:13:45 UTC (rev 139691)
@@ -1,3 +1,27 @@
+2013-01-14  Xianzhu Wang  wangxian...@chromium.org
+
+Sometimes RenderLayer::updateNeedsCompositedScrolling is not called
+

[webkit-changes] [139692] trunk

[commit-queue]

Title: [139692] trunk








Revision 139692
Author commit-qu...@webkit.org
Date 2013-01-14 17:17:16 -0800 (Mon, 14 Jan 2013)


Log Message
Implement element type selectors for the WebVTT ::cue pseudo class
https://bugs.webkit.org/show_bug.cgi?id=105480

Patch by Dima Gorbik dgor...@apple.com on 2013-01-14
Reviewed by Antti Koivisto.

Source/WebCore:

Implemented tag matching for the WebVTT specific tags c and v. All common html tags like b and i are
handled without any changes to the code. Creating a rendering tree and DOM tree now use different code paths.
They both are made by cloning and modifying the tree produced by the parser. Voice tags now use spans for both
rendering and DOM trees to conform to specs. Since this changes a lot of code little refactoring has been
done. Removed m_hasInnerTimestamps since it is no longer needed, it doesn't affect anything. m_documentFragment
was renamed to m_webVTTNodeTree.

Existing tests were modified to cover this case.

* html/track/TextTrackCue.cpp:
(WebCore::TextTrackCue::TextTrackCue):
(WebCore::TextTrackCue::setText): rename m_documentFragment to m_webVTTNodeTree
(WebCore::TextTrackCue::createWebVTTNodeTree): parse the cue if it hasn't been parsed before.
(WebCore::TextTrackCue::copyWebVTTNodeToDOMTree): clone and prepare a node for using in the DOM tree according to specs.
(WebCore::TextTrackCue::getCueAsHTML): get a DOM tree for the cue.
(WebCore::TextTrackCue::createCueRenderingTree): create a rendering tree (main tree is just being cloned for now).
(WebCore::TextTrackCue::markFutureAndPastNodes): tightening the argument type.
(WebCore::TextTrackCue::updateDisplayTree):
(WebCore::TextTrackCue::getDisplayTree): code cleanup, removed m_hasInnerTimeStamps.
* html/track/TextTrackCue.h:
(WebCore::TextTrackCue::voiceElementTagName):
(TextTrackCue):
(WebCore::TextTrackCue::classElementTagName):
* html/track/WebVTTParser.cpp:
(WebCore::WebVTTParser::constructTreeFromToken): type of the newly created elements was changed to Element to avoid hitting
an assertion when cloning because a cloned element will not have HTMLElement type for elements with v and c tag.

LayoutTests:

* media/track/captions-webvtt/styling.vtt:
* media/track/track-css-matching-expected.txt:
* media/track/track-css-matching.html:
* media/track/track-webvtt-tc026-voice.html: voice elements should be spans according to specs.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/media/track/captions-webvtt/styling.vtt
trunk/LayoutTests/media/track/track-css-matching-expected.txt
trunk/LayoutTests/media/track/track-css-matching.html
trunk/LayoutTests/media/track/track-webvtt-tc026-voice.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/track/TextTrackCue.cpp
trunk/Source/WebCore/html/track/TextTrackCue.h
trunk/Source/WebCore/html/track/WebVTTParser.cpp




Diff

Modified: trunk/LayoutTests/ChangeLog (139691 => 139692)

--- trunk/LayoutTests/ChangeLog	2013-01-15 01:13:45 UTC (rev 139691)
+++ trunk/LayoutTests/ChangeLog	2013-01-15 01:17:16 UTC (rev 139692)
@@ -1,3 +1,15 @@
+2013-01-14  Dima Gorbik  dgor...@apple.com
+
+Implement element type selectors for the WebVTT ::cue pseudo class
+https://bugs.webkit.org/show_bug.cgi?id=105480
+
+Reviewed by Antti Koivisto.
+
+* media/track/captions-webvtt/styling.vtt:
+* media/track/track-css-matching-expected.txt:
+* media/track/track-css-matching.html:
+* media/track/track-webvtt-tc026-voice.html: voice elements should be spans according to specs.
+
 2013-01-14  Xianzhu Wang  wangxian...@chromium.org
 
 Sometimes RenderLayer::updateNeedsCompositedScrolling is not called


Modified: trunk/LayoutTests/media/track/captions-webvtt/styling.vtt (139691 => 139692)

--- trunk/LayoutTests/media/track/captions-webvtt/styling.vtt	2013-01-15 01:13:45 UTC (rev 139691)
+++ trunk/LayoutTests/media/track/captions-webvtt/styling.vtt	2013-01-15 01:17:16 UTC (rev 139692)
@@ -1,13 +1,17 @@
 WEBVTT
 
 1
-00:00.000 -- 00:01.000
+00:00.000 -- 00:00.200
 Lorum ipsum
 
 2
-00:01.000 -- 00:02.000
+00:00.200 -- 00:00.400
 c.reddolor sit /cc.greenamet, consectetur /cc.red2adipiscing elit/c
 
 3
-00:02.000 -- 00:05.000
-00:02.000cSuspendisse accumsan, /c00:03.000cmauris sed /c00:04.000ceuismod pharetra/c
\ No newline at end of file
+00:00.400 -- 00:01.000
+00:00.400cSuspendisse accumsan, /c00:00.600cmauris sed /c00:00.800ceuismod pharetra/c
+
+4
+00:01.000 -- 00:01.200
+cAliquam sollicitudin/c vmassa ac magna vulputate dignissim/v bposuere et fermentum/b


Modified: trunk/LayoutTests/media/track/track-css-matching-expected.txt (139691 => 139692)

--- trunk/LayoutTests/media/track/track-css-matching-expected.txt	2013-01-15 01:13:45 UTC (rev 139691)
+++ trunk/LayoutTests/media/track/track-css-matching-expected.txt	2013-01-15 01:17:16 UTC (rev 139692)
@@ -5,25 +5,34 @@
 EXPECTED (getComputedStyle(cueNode).color == 'rgb(0, 128, 0)') OK
 EXPECTED (getComputedStyle(cueNode).color == 'rgb(255, 0, 0)') OK
 

[webkit-changes] [139693] trunk/Source/WebCore

[ojan]

Title: [139693] trunk/Source/WebCore








Revision 139693
Author o...@chromium.org
Date 2013-01-14 17:19:14 -0800 (Mon, 14 Jan 2013)


Log Message
RenderListItem does not need to override computePreferredLogicalWidth
https://bugs.webkit.org/show_bug.cgi?id=106839

Reviewed by Levi Weintraub.

Apparently there was a time when the list marker was considered part of
the list item's preferred width, but that is no longer the case.
This code was added in r3421. The code around preferred widths has change
a lot since then.

* rendering/RenderListItem.cpp:
* rendering/RenderListItem.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderListItem.cpp
trunk/Source/WebCore/rendering/RenderListItem.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (139692 => 139693)

--- trunk/Source/WebCore/ChangeLog	2013-01-15 01:17:16 UTC (rev 139692)
+++ trunk/Source/WebCore/ChangeLog	2013-01-15 01:19:14 UTC (rev 139693)
@@ -1,3 +1,18 @@
+2013-01-14  Ojan Vafai  o...@chromium.org
+
+RenderListItem does not need to override computePreferredLogicalWidth
+https://bugs.webkit.org/show_bug.cgi?id=106839
+
+Reviewed by Levi Weintraub.
+
+Apparently there was a time when the list marker was considered part of
+the list item's preferred width, but that is no longer the case.
+This code was added in r3421. The code around preferred widths has change
+a lot since then.
+
+* rendering/RenderListItem.cpp:
+* rendering/RenderListItem.h:
+
 2013-01-14  Dima Gorbik  dgor...@apple.com
 
 Implement element type selectors for the WebVTT ::cue pseudo class


Modified: trunk/Source/WebCore/rendering/RenderListItem.cpp (139692 => 139693)

--- trunk/Source/WebCore/rendering/RenderListItem.cpp	2013-01-15 01:17:16 UTC (rev 139692)
+++ trunk/Source/WebCore/rendering/RenderListItem.cpp	2013-01-15 01:19:14 UTC (rev 139693)
@@ -274,15 +274,6 @@
 }
 }
 
-void RenderListItem::computePreferredLogicalWidths()
-{
-ASSERT(preferredLogicalWidthsDirty());
-
-updateMarkerLocation();
-
-RenderBlock::computePreferredLogicalWidths();
-}
-
 void RenderListItem::layout()
 {
 StackStats::LayoutCheckPoint layoutCheckPoint;


Modified: trunk/Source/WebCore/rendering/RenderListItem.h (139692 => 139693)

--- trunk/Source/WebCore/rendering/RenderListItem.h	2013-01-15 01:17:16 UTC (rev 139692)
+++ trunk/Source/WebCore/rendering/RenderListItem.h	2013-01-15 01:19:14 UTC (rev 139693)
@@ -65,7 +65,6 @@
 virtual void paint(PaintInfo, const LayoutPoint);
 
 virtual void layout();
-virtual void computePreferredLogicalWidths();
 
 void positionListMarker();
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [139694] trunk

[leviw]

Title: [139694] trunk








Revision 139694
Author le...@chromium.org
Date 2013-01-14 17:22:59 -0800 (Mon, 14 Jan 2013)


Log Message
Source/WebCore: Rolling out r139683. It broke a bunch of webkit_unit_tests.

Source/WebKit/win: Rolling out r139683. It broke a bunch of webkit_unit_tests. 

Modified Paths

trunk/LayoutTests/http/tests/inspector/resource-har-pages-expected.txt
trunk/LayoutTests/http/tests/loading/redirect-methods-expected.txt
trunk/LayoutTests/http/tests/misc/favicon-loads-with-images-disabled-expected.txt
trunk/LayoutTests/http/tests/misc/link-rel-icon-beforeload-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/WebCore.exp.in
trunk/Source/WebCore/dom/Document.cpp
trunk/Source/WebCore/dom/Document.h
trunk/Source/WebCore/loader/FrameLoader.cpp
trunk/Source/WebCore/loader/MainResourceLoader.cpp
trunk/Source/WebCore/loader/MainResourceLoader.h
trunk/Source/WebCore/loader/cache/CachedRawResource.cpp
trunk/Source/WebCore/loader/cache/CachedRawResource.h
trunk/Source/WebCore/loader/cache/CachedResource.cpp
trunk/Source/WebCore/loader/cache/CachedResource.h
trunk/Source/WebCore/loader/cache/CachedResourceLoader.cpp
trunk/Source/WebCore/testing/Internals.cpp
trunk/Source/WebCore/testing/Internals.h
trunk/Source/WebCore/testing/Internals.idl
trunk/Source/WebKit/win/ChangeLog
trunk/Source/WebKit/win/WebKit.vcproj/WebKitExports.def.in
trunk/Source/autotools/symbols.filter


Removed Paths

trunk/LayoutTests/http/tests/cache/cached-main-resource-expected.txt
trunk/LayoutTests/http/tests/cache/cached-main-resource.html
trunk/LayoutTests/http/tests/cache/resources/cacheable-iframe.php




Diff

Deleted: trunk/LayoutTests/http/tests/cache/cached-main-resource-expected.txt (139693 => 139694)

--- trunk/LayoutTests/http/tests/cache/cached-main-resource-expected.txt	2013-01-15 01:19:14 UTC (rev 139693)
+++ trunk/LayoutTests/http/tests/cache/cached-main-resource-expected.txt	2013-01-15 01:22:59 UTC (rev 139694)
@@ -1,2 +0,0 @@
-PASS
- 


Deleted: trunk/LayoutTests/http/tests/cache/cached-main-resource.html (139693 => 139694)

--- trunk/LayoutTests/http/tests/cache/cached-main-resource.html	2013-01-15 01:19:14 UTC (rev 139693)
+++ trunk/LayoutTests/http/tests/cache/cached-main-resource.html	2013-01-15 01:22:59 UTC (rev 139694)
@@ -1,24 +0,0 @@
-html
-body _onload_=setTimeout(removeAndReload, 0);
-div id=result/div
-script
-if (window.testRunner) {
-testRunner.dumpAsText();
-testRunner.waitUntilDone();
-}
-
-function removeAndReload()
-{
-document.body.removeChild(document.getElementById(iframe));
-var newIframe = document.createElement(iframe);
-newIframe.src = ""
-document.body.appendChild(newIframe);
-var fromCache = internals.isLoadingFromMemoryCache(newIframe.src);
-document.getElementById(result).appendChild(document.createTextNode(fromCache ? PASS : FAIL));
-if (window.testRunner)
-testRunner.notifyDone();
-}
-/script
-iframe id=iframe src=""
-/body
-/html


Deleted: trunk/LayoutTests/http/tests/cache/resources/cacheable-iframe.php (139693 => 139694)

--- trunk/LayoutTests/http/tests/cache/resources/cacheable-iframe.php	2013-01-15 01:19:14 UTC (rev 139693)
+++ trunk/LayoutTests/http/tests/cache/resources/cacheable-iframe.php	2013-01-15 01:22:59 UTC (rev 139694)
@@ -1,11 +0,0 @@
-?php
-require_once '../../resources/portabilityLayer.php';
-
-$max_age = 12 * 31 * 24 * 60 * 60; //one year
-$expires = gmdate(DATE_RFC1123, time() + $max_age);
-
-header('Cache-Control: public, max-age=' . $max_age);
-header('Expires: ' . $expires);
-header('Content-Type: text/html');
-exit();
-?


Modified: trunk/LayoutTests/http/tests/inspector/resource-har-pages-expected.txt (139693 => 139694)

--- trunk/LayoutTests/http/tests/inspector/resource-har-pages-expected.txt	2013-01-15 01:19:14 UTC (rev 139693)
+++ trunk/LayoutTests/http/tests/inspector/resource-har-pages-expected.txt	2013-01-15 01:22:59 UTC (rev 139694)
@@ -1,5 +1,6 @@
 Tests conversion of Inspector's resource representation into HAR format.
 
+Page reloaded.
 {
 0 : {
 id : string
@@ -27,5 +28,4 @@
 page: page_1 url: http://127.0.0.1:8000/inspector/resources/har-pages-navigation-target.html
 page: page_1 url: http://127.0.0.1:8000/inspector/resources/source1.js
 page: page_1 url: http://127.0.0.1:8000/resources/redirect.php?url=""
-Page reloaded.
 


Modified: trunk/LayoutTests/http/tests/loading/redirect-methods-expected.txt (139693 => 139694)

--- trunk/LayoutTests/http/tests/loading/redirect-methods-expected.txt	2013-01-15 01:19:14 UTC (rev 139693)
+++ trunk/LayoutTests/http/tests/loading/redirect-methods-expected.txt	2013-01-15 01:22:59 UTC (rev 139694)
@@ -42,11 +42,11 @@
 http://127.0.0.1:8000/loading/resources/redirect-methods-form.html - didReceiveResponse NSURLResponse http://127.0.0.1:8000/loading/resources/redirect-methods-form.html, http status code 200
 frame 1 - didCancelClientRedirectForFrame
 frame 1 - didCommitLoadForFrame

[webkit-changes] [139695] trunk/Source/WebCore

[leviw]

Title: [139695] trunk/Source/WebCore








Revision 139695
Author le...@chromium.org
Date 2013-01-14 17:31:34 -0800 (Mon, 14 Jan 2013)


Log Message
Rolling out r139678. This triggered a number of WebAudio crashes on Debug bots.

* platform/audio/chromium/AudioDestinationChromium.cpp:
(WebCore::AudioDestinationChromium::AudioDestinationChromium):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/audio/chromium/AudioDestinationChromium.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (139694 => 139695)

--- trunk/Source/WebCore/ChangeLog	2013-01-15 01:22:59 UTC (rev 139694)
+++ trunk/Source/WebCore/ChangeLog	2013-01-15 01:31:34 UTC (rev 139695)
@@ -1,3 +1,10 @@
+2013-01-14  Levi Weintraub  le...@chromium.org
+
+Rolling out r139678. This triggered a number of WebAudio crashes on Debug bots.
+
+* platform/audio/chromium/AudioDestinationChromium.cpp:
+(WebCore::AudioDestinationChromium::AudioDestinationChromium):
+
 2013-01-09  Levi Weintraub le...@chromium.org
 
 Rolling out r139683. It broke a bunch of webkit_unit_tests.


Modified: trunk/Source/WebCore/platform/audio/chromium/AudioDestinationChromium.cpp (139694 => 139695)

--- trunk/Source/WebCore/platform/audio/chromium/AudioDestinationChromium.cpp	2013-01-15 01:22:59 UTC (rev 139694)
+++ trunk/Source/WebCore/platform/audio/chromium/AudioDestinationChromium.cpp	2013-01-15 01:31:34 UTC (rev 139695)
@@ -66,7 +66,8 @@
 if (m_callbackBufferSize + renderBufferSize  fifoSize)
 return;
 
-m_audioDevice = adoptPtr(WebKit::Platform::current()-createAudioDevice(m_callbackBufferSize, numberOfInputChannels, numberOfOutputChannels, sampleRate, this));
+// FIXME: switch to new API (with input channels) once chromium supports it.
+m_audioDevice = adoptPtr(WebKit::Platform::current()-createAudioDevice(m_callbackBufferSize, numberOfOutputChannels, sampleRate, this));
 ASSERT(m_audioDevice);
 
 // Create a FIFO to handle the possibility of the callback size






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [139696] trunk

[leviw]

Title: [139696] trunk








Revision 139696
Author le...@chromium.org
Date 2013-01-14 17:36:32 -0800 (Mon, 14 Jan 2013)


Log Message
Source/WebCore: Rolling out r139618. Appears to be causing sporadic crashes on Debug bots.

* Modules/mediastream/MediaStream.cpp:
(WebCore::processTrack):
* Modules/mediastream/MediaStreamTrack.cpp:
(WebCore::MediaStreamTrack::readyState):
* Modules/mediastream/MediaStreamTrack.h:
* Modules/mediastream/MediaStreamTrack.idl:

LayoutTests: Speculatively rolling out r139618. Appears to be causing sporadic crashes on Debug bots.

* fast/mediastream/MediaStreamTrack-expected.txt:
* fast/mediastream/MediaStreamTrack.html:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/mediastream/MediaStreamTrack-expected.txt
trunk/LayoutTests/fast/mediastream/MediaStreamTrack.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/mediastream/MediaStream.cpp
trunk/Source/WebCore/Modules/mediastream/MediaStreamTrack.cpp
trunk/Source/WebCore/Modules/mediastream/MediaStreamTrack.h
trunk/Source/WebCore/Modules/mediastream/MediaStreamTrack.idl




Diff

Modified: trunk/LayoutTests/ChangeLog (139695 => 139696)

--- trunk/LayoutTests/ChangeLog	2013-01-15 01:31:34 UTC (rev 139695)
+++ trunk/LayoutTests/ChangeLog	2013-01-15 01:36:32 UTC (rev 139696)
@@ -1,3 +1,10 @@
+2013-01-14  Levi Weintraub  le...@chromium.org
+
+Speculatively rolling out r139618. Appears to be causing sporadic crashes on Debug bots.
+
+* fast/mediastream/MediaStreamTrack-expected.txt:
+* fast/mediastream/MediaStreamTrack.html:
+
 2013-01-14  Dima Gorbik  dgor...@apple.com
 
 Implement element type selectors for the WebVTT ::cue pseudo class


Modified: trunk/LayoutTests/fast/mediastream/MediaStreamTrack-expected.txt (139695 => 139696)

--- trunk/LayoutTests/fast/mediastream/MediaStreamTrack-expected.txt	2013-01-15 01:31:34 UTC (rev 139695)
+++ trunk/LayoutTests/fast/mediastream/MediaStreamTrack-expected.txt	2013-01-15 01:36:32 UTC (rev 139696)
@@ -4,13 +4,9 @@
 
 
 PASS getUserMedia succeeded.
-PASS track.readyState is live
 PASS Track onmute callback succeeded.
-PASS track.readyState is muted
 PASS Track onunmute callback succeeded.
-PASS track.readyState is live
 PASS Track onended callback succeeded.
-PASS track.readyState is ended
 PASS successfullyParsed is true
 
 TEST COMPLETE


Modified: trunk/LayoutTests/fast/mediastream/MediaStreamTrack.html (139695 => 139696)

--- trunk/LayoutTests/fast/mediastream/MediaStreamTrack.html	2013-01-15 01:31:34 UTC (rev 139695)
+++ trunk/LayoutTests/fast/mediastream/MediaStreamTrack.html	2013-01-15 01:36:32 UTC (rev 139696)
@@ -34,24 +34,18 @@
 function onTrackEnded() {
 testPassed('Track onended callback succeeded.');
 
-shouldBeEqualToString('track.readyState', 'ended');
-
 finishJSTest();
 }
 
 function onTrackUnmute() {
 testPassed('Track onunmute callback succeeded.');
 
-shouldBeEqualToString('track.readyState', 'live');
-
 stream.stop();
 }
 
 function onTrackMute() {
 testPassed('Track onmute callback succeeded.');
 
-shouldBeEqualToString('track.readyState', 'muted');
-
 track.enabled = true;
 }
 
@@ -61,8 +55,6 @@
 stream = s;
 track = stream.getVideoTracks()[0];
 
-shouldBeEqualToString('track.readyState', 'live');
-
 track._onunmute_ = onTrackUnmute;
 track._onmute_ = onTrackMute;
 track._onended_ = onTrackEnded;


Modified: trunk/Source/WebCore/ChangeLog (139695 => 139696)

--- trunk/Source/WebCore/ChangeLog	2013-01-15 01:31:34 UTC (rev 139695)
+++ trunk/Source/WebCore/ChangeLog	2013-01-15 01:36:32 UTC (rev 139696)
@@ -1,5 +1,16 @@
 2013-01-14  Levi Weintraub  le...@chromium.org
 
+Rolling out r139618. Appears to be causing sporadic crashes on Debug bots.
+
+* Modules/mediastream/MediaStream.cpp:
+(WebCore::processTrack):
+* Modules/mediastream/MediaStreamTrack.cpp:
+(WebCore::MediaStreamTrack::readyState):
+* Modules/mediastream/MediaStreamTrack.h:
+* Modules/mediastream/MediaStreamTrack.idl:
+
+2013-01-14  Levi Weintraub  le...@chromium.org
+
 Rolling out r139678. This triggered a number of WebAudio crashes on Debug bots.
 
 * platform/audio/chromium/AudioDestinationChromium.cpp:


Modified: trunk/Source/WebCore/Modules/mediastream/MediaStream.cpp (139695 => 139696)

--- trunk/Source/WebCore/Modules/mediastream/MediaStream.cpp	2013-01-15 01:31:34 UTC (rev 139695)
+++ trunk/Source/WebCore/Modules/mediastream/MediaStream.cpp	2013-01-15 01:36:32 UTC (rev 139696)
@@ -48,7 +48,7 @@
 
 static void processTrack(MediaStreamTrack* track, MediaStreamSourceVector sourceVector)
 {
-if (track-ended())
+if (track-readyState() == MediaStreamTrack::ENDED)
 return;
 
 MediaStreamSource* source = track-component()-source();


Modified: trunk/Source/WebCore/Modules/mediastream/MediaStreamTrack.cpp (139695 => 139696)

--- trunk/Source/WebCore/Modules/mediastream/MediaStreamTrack.cpp	

[webkit-changes] [139697] trunk/Tools

[dpranke]

Title: [139697] trunk/Tools








Revision 139697
Author dpra...@chromium.org
Date 2013-01-14 17:40:54 -0800 (Mon, 14 Jan 2013)


Log Message
kill whole lighttpd process tree for chromium win
https://bugs.webkit.org/show_bug.cgi?id=106838

Reviewed by Tony Chang.

Land a speculative fix for lighttpd.exe hanging on some chromium bots;
I think a test is causing a httpd server child process to wedge and
killing the parent httpd server process isn't sufficient to ensure
that the children are also killed.

* Scripts/webkitpy/layout_tests/servers/http_server.py:
(Lighttpd._check_and_kill):
* Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
(TestHttpServer.test_start_cmd):
(TestHttpServer):
(TestHttpServer.test_win32_start_and_stop):
(TestHttpServer.test_win32_start_and_stop.wait_for_action):
(TestHttpServer.test_win32_start_and_stop.mock_returns):
(TestHttpServer.test_win32_start_and_stop.mock_returns.return_value_thunk):

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/layout_tests/servers/http_server.py
trunk/Tools/Scripts/webkitpy/layout_tests/servers/http_server_unittest.py




Diff

Modified: trunk/Tools/ChangeLog (139696 => 139697)

--- trunk/Tools/ChangeLog	2013-01-15 01:36:32 UTC (rev 139696)
+++ trunk/Tools/ChangeLog	2013-01-15 01:40:54 UTC (rev 139697)
@@ -1,3 +1,25 @@
+2013-01-14  Dirk Pranke  dpra...@chromium.org
+
+kill whole lighttpd process tree for chromium win
+https://bugs.webkit.org/show_bug.cgi?id=106838
+
+Reviewed by Tony Chang.
+
+Land a speculative fix for lighttpd.exe hanging on some chromium bots;
+I think a test is causing a httpd server child process to wedge and
+killing the parent httpd server process isn't sufficient to ensure
+that the children are also killed.
+
+* Scripts/webkitpy/layout_tests/servers/http_server.py:
+(Lighttpd._check_and_kill):
+* Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
+(TestHttpServer.test_start_cmd):
+(TestHttpServer):
+(TestHttpServer.test_win32_start_and_stop):
+(TestHttpServer.test_win32_start_and_stop.wait_for_action):
+(TestHttpServer.test_win32_start_and_stop.mock_returns):
+(TestHttpServer.test_win32_start_and_stop.mock_returns.return_value_thunk):
+
 2013-01-14  Nico Weber  tha...@chromium.org
 
 [chromium] Enable `update-webkit --chromium --ninja` on windows


Modified: trunk/Tools/Scripts/webkitpy/layout_tests/servers/http_server.py (139696 => 139697)

--- trunk/Tools/Scripts/webkitpy/layout_tests/servers/http_server.py	2013-01-15 01:36:32 UTC (rev 139696)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/servers/http_server.py	2013-01-15 01:40:54 UTC (rev 139697)
@@ -214,6 +214,15 @@
 
 def _check_and_kill(self):
 if self._executive.check_running_pid(self._pid):
-self._executive.kill_process(self._pid)
+host = self._port_obj.host
+if host.platform.is_win() and not host.platform.is_cygwin():
+# FIXME: https://bugs.webkit.org/show_bug.cgi?id=106838
+# We need to kill all of the child processes as well as the
+# parent, so we can't use executive.kill_process().
+#
+# If this is actually working, we should figure out a clean API.
+self._executive.run_command([taskkill.exe, /f, /t, self._pid], error_handler=self._executive.ignore_error)
+else:
+self._executive.kill_process(self._pid)
 return False
 return True


Modified: trunk/Tools/Scripts/webkitpy/layout_tests/servers/http_server_unittest.py (139696 => 139697)

--- trunk/Tools/Scripts/webkitpy/layout_tests/servers/http_server_unittest.py	2013-01-15 01:36:32 UTC (rev 139696)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/servers/http_server_unittest.py	2013-01-15 01:40:54 UTC (rev 139697)
@@ -26,9 +26,9 @@
 # (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
 # OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 
-import unittest
 import re
 import sys
+import unittest
 
 from webkitpy.common.host_mock import MockHost
 from webkitpy.layout_tests.port import test
@@ -62,3 +62,39 @@
 'alias.url += ( /mock/another-additional-dir = /mock-checkout/one-additional-dir )',
 'alias.url += ( /media-resources = /test.checkout/LayoutTests/media )',
 ])
+
+def test_win32_start_and_stop(self):
+host = MockHost()
+test_port = test.TestPort(host)
+host.filesystem.write_text_file(
+/mock-checkout/Tools/Scripts/webkitpy/layout_tests/servers/lighttpd.conf, Mock Config\n)
+host.filesystem.write_text_file(
+/usr/lib/lighttpd/liblightcomp.dylib, Mock dylib)
+
+host.platform.is_win = lambda: True
+host.platform.is_cygwin = lambda: False
+
+server = Lighttpd(test_port, /mock/output_dir,
+   

[webkit-changes] [139698] trunk/Source

[pilgrim]

Title: [139698] trunk/Source








Revision 139698
Author pilg...@chromium.org
Date 2013-01-14 17:58:07 -0800 (Mon, 14 Jan 2013)


Log Message
[Chromium] Move BlobRegistryProxy into WebCore
https://bugs.webkit.org/show_bug.cgi?id=106831

Reviewed by Adam Barth.

Part of a larger refactoring series to remove layering violations
in Chromium. See tracking bug 106829.

Source/WebCore:

* WebCore.gypi:
* platform/network/chromium/BlobRegistryProxy.cpp: Added.
(WebCore):
(WebCore::blobRegistry):
(WebCore::BlobRegistryProxy::BlobRegistryProxy):
(WebCore::BlobRegistryProxy::registerBlobURL):
(WebCore::BlobRegistryProxy::unregisterBlobURL):
* platform/network/chromium/BlobRegistryProxy.h: Added.
(WebCore):
(BlobRegistryProxy):
(WebCore::BlobRegistryProxy::loadResourceSynchronously):
(WebCore::BlobRegistryProxy::~BlobRegistryProxy):

Source/WebKit/chromium:

* WebKit.gyp:
* src/BlobRegistryProxy.cpp: Removed.
* src/BlobRegistryProxy.h: Removed.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/WebCore.gypi
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/WebKit.gyp


Added Paths

trunk/Source/WebCore/platform/network/chromium/BlobRegistryProxy.cpp
trunk/Source/WebCore/platform/network/chromium/BlobRegistryProxy.h


Removed Paths

trunk/Source/WebKit/chromium/src/BlobRegistryProxy.cpp
trunk/Source/WebKit/chromium/src/BlobRegistryProxy.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (139697 => 139698)

--- trunk/Source/WebCore/ChangeLog	2013-01-15 01:40:54 UTC (rev 139697)
+++ trunk/Source/WebCore/ChangeLog	2013-01-15 01:58:07 UTC (rev 139698)
@@ -1,3 +1,26 @@
+2013-01-14  Mark Pilgrim  pilg...@chromium.org
+
+[Chromium] Move BlobRegistryProxy into WebCore
+https://bugs.webkit.org/show_bug.cgi?id=106831
+
+Reviewed by Adam Barth.
+
+Part of a larger refactoring series to remove layering violations
+in Chromium. See tracking bug 106829.
+
+* WebCore.gypi:
+* platform/network/chromium/BlobRegistryProxy.cpp: Added.
+(WebCore):
+(WebCore::blobRegistry):
+(WebCore::BlobRegistryProxy::BlobRegistryProxy):
+(WebCore::BlobRegistryProxy::registerBlobURL):
+(WebCore::BlobRegistryProxy::unregisterBlobURL):
+* platform/network/chromium/BlobRegistryProxy.h: Added.
+(WebCore):
+(BlobRegistryProxy):
+(WebCore::BlobRegistryProxy::loadResourceSynchronously):
+(WebCore::BlobRegistryProxy::~BlobRegistryProxy):
+
 2013-01-14  Levi Weintraub  le...@chromium.org
 
 Rolling out r139618. Appears to be causing sporadic crashes on Debug bots.


Modified: trunk/Source/WebCore/WebCore.gypi (139697 => 139698)

--- trunk/Source/WebCore/WebCore.gypi	2013-01-15 01:40:54 UTC (rev 139697)
+++ trunk/Source/WebCore/WebCore.gypi	2013-01-15 01:58:07 UTC (rev 139698)
@@ -4424,6 +4424,8 @@
 'platform/network/cf/SocketStreamHandleCFNet.cpp',
 'platform/network/chromium/AuthenticationChallenge.h',
 'platform/network/chromium/AuthenticationChallengeChromium.cpp',
+'platform/network/chromium/BlobRegistryProxy.cpp',
+'platform/network/chromium/BlobRegistryProxy.h',
 'platform/network/chromium/CookieJarChromium.cpp',
 'platform/network/chromium/DNSChromium.cpp',
 'platform/network/chromium/ResourceError.h',


Copied: trunk/Source/WebCore/platform/network/chromium/BlobRegistryProxy.cpp (from rev 139697, trunk/Source/WebKit/chromium/src/BlobRegistryProxy.cpp) (0 => 139698)

--- trunk/Source/WebCore/platform/network/chromium/BlobRegistryProxy.cpp	(rev 0)
+++ trunk/Source/WebCore/platform/network/chromium/BlobRegistryProxy.cpp	2013-01-15 01:58:07 UTC (rev 139698)
@@ -0,0 +1,86 @@
+/*
+ * Copyright (C) 2010 Google Inc. All rights reserved.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions are
+ * met:
+ *
+ * * Redistributions of source code must retain the above copyright
+ * notice, this list of conditions and the following disclaimer.
+ * * Redistributions in binary form must reproduce the above
+ * copyright notice, this list of conditions and the following disclaimer
+ * in the documentation and/or other materials provided with the
+ * distribution.
+ * * Neither the name of Google Inc. nor the names of its
+ * contributors may be used to endorse or promote products derived from
+ * this software without specific prior written permission.
+ *
+ * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
+ * AS IS AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
+ * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
+ * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
+ * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
+ * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES 

[webkit-changes] [139699] trunk/LayoutTests

[leviw]

Title: [139699] trunk/LayoutTests








Revision 139699
Author le...@chromium.org
Date 2013-01-14 18:06:20 -0800 (Mon, 14 Jan 2013)


Log Message
Unreviewed gardening. Adding mac expectatons after r139686.

* platform/chromium-mac/scrollingcoordinator: Added.
* platform/chromium-mac/scrollingcoordinator/non-fast-scrollable-region-scaled-iframe-expected.png: Added.

Modified Paths

trunk/LayoutTests/ChangeLog


Added Paths

trunk/LayoutTests/platform/chromium-mac/scrollingcoordinator/
trunk/LayoutTests/platform/chromium-mac/scrollingcoordinator/non-fast-scrollable-region-scaled-iframe-expected.png




Diff

Modified: trunk/LayoutTests/ChangeLog (139698 => 139699)

--- trunk/LayoutTests/ChangeLog	2013-01-15 01:58:07 UTC (rev 139698)
+++ trunk/LayoutTests/ChangeLog	2013-01-15 02:06:20 UTC (rev 139699)
@@ -1,5 +1,12 @@
 2013-01-14  Levi Weintraub  le...@chromium.org
 
+Unreviewed gardening. Adding mac expectatons after r139686.
+
+* platform/chromium-mac/scrollingcoordinator: Added.
+* platform/chromium-mac/scrollingcoordinator/non-fast-scrollable-region-scaled-iframe-expected.png: Added.
+
+2013-01-14  Levi Weintraub  le...@chromium.org
+
 Speculatively rolling out r139618. Appears to be causing sporadic crashes on Debug bots.
 
 * fast/mediastream/MediaStreamTrack-expected.txt:


Added: trunk/LayoutTests/platform/chromium-mac/scrollingcoordinator/non-fast-scrollable-region-scaled-iframe-expected.png

(Binary files differ)

Property changes on: trunk/LayoutTests/platform/chromium-mac/scrollingcoordinator/non-fast-scrollable-region-scaled-iframe-expected.png
___

Added: svn:mime-type




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [139700] trunk/Tools

[commit-queue]

Title: [139700] trunk/Tools








Revision 139700
Author commit-qu...@webkit.org
Date 2013-01-14 18:08:38 -0800 (Mon, 14 Jan 2013)


Log Message
Adding an error string to AmbiguousCommitError.
https://bugs.webkit.org/show_bug.cgi?id=106846

Patch by Tim 'mithro' Ansell mit...@mithis.com on 2013-01-14
Reviewed by Adam Barth.

* Scripts/webkitpy/common/checkout/scm/git.py:
(AmbiguousCommitError.__init__):

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/common/checkout/scm/git.py




Diff

Modified: trunk/Tools/ChangeLog (139699 => 139700)

--- trunk/Tools/ChangeLog	2013-01-15 02:06:20 UTC (rev 139699)
+++ trunk/Tools/ChangeLog	2013-01-15 02:08:38 UTC (rev 139700)
@@ -1,3 +1,13 @@
+2013-01-14  Tim 'mithro' Ansell  mit...@mithis.com
+
+Adding an error string to AmbiguousCommitError.
+https://bugs.webkit.org/show_bug.cgi?id=106846
+
+Reviewed by Adam Barth.
+
+* Scripts/webkitpy/common/checkout/scm/git.py:
+(AmbiguousCommitError.__init__):
+
 2013-01-14  Dirk Pranke  dpra...@chromium.org
 
 kill whole lighttpd process tree for chromium win


Modified: trunk/Tools/Scripts/webkitpy/common/checkout/scm/git.py (139699 => 139700)

--- trunk/Tools/Scripts/webkitpy/common/checkout/scm/git.py	2013-01-15 02:06:20 UTC (rev 139699)
+++ trunk/Tools/Scripts/webkitpy/common/checkout/scm/git.py	2013-01-15 02:08:38 UTC (rev 139700)
@@ -49,6 +49,8 @@
 
 class AmbiguousCommitError(Exception):
 def __init__(self, num_local_commits, working_directory_is_clean):
+Exception.__init__(self, Found %s local commits and the working directory is %s % (
+num_local_commits, [not clean, clean][working_directory_is_clean]))
 self.num_local_commits = num_local_commits
 self.working_directory_is_clean = working_directory_is_clean
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [139701] trunk/Source/WebCore

[dino]

Title: [139701] trunk/Source/WebCore








Revision 139701
Author d...@apple.com
Date 2013-01-14 18:44:55 -0800 (Mon, 14 Jan 2013)


Log Message
Blur the label background of a snapshotted plugin
https://bugs.webkit.org/show_bug.cgi?id=106630

Reviewed by Simon Fraser.

When we are showing a label indicating the plugin has been snapshotted,
slightly blur the snapshot behind the label so that it is more clear. I expect
that if/when other ports pick up this code, we'll need to separate the
UI treatment somewhat, but this is ok for a first step.

* rendering/RenderSnapshottedPlugIn.cpp:
(RenderSnapshottedPlugInBlurFilter): Private class to use FEGaussianBlur to blur an image.
(WebCore::RenderSnapshottedPlugInBlurFilter::create):
(WebCore::RenderSnapshottedPlugInBlurFilter::setSourceImageRect):
(WebCore::RenderSnapshottedPlugInBlurFilter::sourceImageRect):
(WebCore::RenderSnapshottedPlugInBlurFilter::filterRegion):
(WebCore::RenderSnapshottedPlugInBlurFilter::output):
(WebCore::RenderSnapshottedPlugInBlurFilter::RenderSnapshottedPlugInBlurFilter):
(WebCore::RenderSnapshottedPlugInBlurFilter::apply):
(WebCore::RenderSnapshottedPlugIn::RenderSnapshottedPlugIn): New member variable to hold a cached version of a preblurred snapshot.
(WebCore::RenderSnapshottedPlugIn::~RenderSnapshottedPlugIn): Remember to remove the preblurred image from the cache.
(WebCore::RenderSnapshottedPlugIn::updateSnapshot): Zero the preblurred version if it exists.
(WebCore::RenderSnapshottedPlugIn::paintReplaced): Either paint snapshot or blurred snapshot with label.
(WebCore::RenderSnapshottedPlugIn::paintSnapshot): New method to paint a full sized snapshot.
(WebCore::RenderSnapshottedPlugIn::paintReplacedSnapshot):
(WebCore::snapshottedPluginImageForLabelDisplay): Static function to produce the blurred snapshot.
(WebCore::RenderSnapshottedPlugIn::paintReplacedSnapshotWithLabel): Calls paintSnapshot with the blurred snapshot on Mac.
* rendering/RenderSnapshottedPlugIn.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderSnapshottedPlugIn.cpp
trunk/Source/WebCore/rendering/RenderSnapshottedPlugIn.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (139700 => 139701)

--- trunk/Source/WebCore/ChangeLog	2013-01-15 02:08:38 UTC (rev 139700)
+++ trunk/Source/WebCore/ChangeLog	2013-01-15 02:44:55 UTC (rev 139701)
@@ -1,3 +1,34 @@
+2013-01-14  Dean Jackson  d...@apple.com
+
+Blur the label background of a snapshotted plugin
+https://bugs.webkit.org/show_bug.cgi?id=106630
+
+Reviewed by Simon Fraser.
+
+When we are showing a label indicating the plugin has been snapshotted,
+slightly blur the snapshot behind the label so that it is more clear. I expect
+that if/when other ports pick up this code, we'll need to separate the
+UI treatment somewhat, but this is ok for a first step.
+
+* rendering/RenderSnapshottedPlugIn.cpp:
+(RenderSnapshottedPlugInBlurFilter): Private class to use FEGaussianBlur to blur an image.
+(WebCore::RenderSnapshottedPlugInBlurFilter::create):
+(WebCore::RenderSnapshottedPlugInBlurFilter::setSourceImageRect):
+(WebCore::RenderSnapshottedPlugInBlurFilter::sourceImageRect):
+(WebCore::RenderSnapshottedPlugInBlurFilter::filterRegion):
+(WebCore::RenderSnapshottedPlugInBlurFilter::output):
+(WebCore::RenderSnapshottedPlugInBlurFilter::RenderSnapshottedPlugInBlurFilter):
+(WebCore::RenderSnapshottedPlugInBlurFilter::apply):
+(WebCore::RenderSnapshottedPlugIn::RenderSnapshottedPlugIn): New member variable to hold a cached version of a preblurred snapshot.
+(WebCore::RenderSnapshottedPlugIn::~RenderSnapshottedPlugIn): Remember to remove the preblurred image from the cache.
+(WebCore::RenderSnapshottedPlugIn::updateSnapshot): Zero the preblurred version if it exists.
+(WebCore::RenderSnapshottedPlugIn::paintReplaced): Either paint snapshot or blurred snapshot with label.
+(WebCore::RenderSnapshottedPlugIn::paintSnapshot): New method to paint a full sized snapshot.
+(WebCore::RenderSnapshottedPlugIn::paintReplacedSnapshot):
+(WebCore::snapshottedPluginImageForLabelDisplay): Static function to produce the blurred snapshot.
+(WebCore::RenderSnapshottedPlugIn::paintReplacedSnapshotWithLabel): Calls paintSnapshot with the blurred snapshot on Mac.
+* rendering/RenderSnapshottedPlugIn.h:
+
 2013-01-14  Mark Pilgrim  pilg...@chromium.org
 
 [Chromium] Move BlobRegistryProxy into WebCore


Modified: trunk/Source/WebCore/rendering/RenderSnapshottedPlugIn.cpp (139700 => 139701)

--- trunk/Source/WebCore/rendering/RenderSnapshottedPlugIn.cpp	2013-01-15 02:08:38 UTC (rev 139700)
+++ trunk/Source/WebCore/rendering/RenderSnapshottedPlugIn.cpp	2013-01-15 02:44:55 UTC (rev 139701)
@@ -29,14 +29,18 @@
 #include Chrome.h
 #include ChromeClient.h
 #include Cursor.h
+#include FEGaussianBlur.h
+#include