[webkit-changes] [139722] trunk/Tools

[jochen]

Title: [139722] trunk/Tools








Revision 139722
Author joc...@chromium.org
Date 2013-01-15 00:19:57 -0800 (Tue, 15 Jan 2013)


Log Message
[chromium] move remaining methods that just set a boolean flag to TestRunner library
https://bugs.webkit.org/show_bug.cgi?id=106823

Reviewed by Darin Fisher.

* DumpRenderTree/chromium/DRTTestRunner.cpp:
(DRTTestRunner::DRTTestRunner):
(DRTTestRunner::reset):
* DumpRenderTree/chromium/DRTTestRunner.h:
(DRTTestRunner):
* DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
(WebTestRunner::WebTestRunner::shouldDumpBackForwardList):
(WebTestRunner::WebTestRunner::deferMainResourceDataLoad):
(WebTestRunner::WebTestRunner::shouldDumpSelectionRect):
(WebTestRunner::WebTestRunner::testRepaint):
(WebTestRunner::WebTestRunner::sweepHorizontally):
(WebTestRunner::WebTestRunner::isPrinting):
(WebTestRunner::WebTestRunner::shouldStayOnPageAfterHandlingBeforeUnload):
* DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
(WebTestRunner::TestRunner::TestRunner):
(WebTestRunner::TestRunner::reset):
(WebTestRunner::TestRunner::shouldDumpBackForwardList):
(WebTestRunner):
(WebTestRunner::TestRunner::deferMainResourceDataLoad):
(WebTestRunner::TestRunner::shouldDumpSelectionRect):
(WebTestRunner::TestRunner::testRepaint):
(WebTestRunner::TestRunner::sweepHorizontally):
(WebTestRunner::TestRunner::isPrinting):
(WebTestRunner::TestRunner::shouldStayOnPageAfterHandlingBeforeUnload):
(WebTestRunner::TestRunner::dumpBackForwardList):
(WebTestRunner::TestRunner::setDeferMainResourceDataLoad):
(WebTestRunner::TestRunner::dumpSelectionRect):
(WebTestRunner::TestRunner::repaintSweepHorizontally):
(WebTestRunner::TestRunner::setPrinting):
(WebTestRunner::TestRunner::setShouldStayOnPageAfterHandlingBeforeUnload):
* DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
(TestRunner):

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/DumpRenderTree/chromium/DRTTestRunner.cpp
trunk/Tools/DumpRenderTree/chromium/DRTTestRunner.h
trunk/Tools/DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h
trunk/Tools/DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp
trunk/Tools/DumpRenderTree/chromium/TestRunner/src/TestRunner.h




Diff

Modified: trunk/Tools/ChangeLog (139721 => 139722)

--- trunk/Tools/ChangeLog	2013-01-15 07:55:47 UTC (rev 139721)
+++ trunk/Tools/ChangeLog	2013-01-15 08:19:57 UTC (rev 139722)
@@ -1,3 +1,43 @@
+2013-01-15  Jochen Eisinger  joc...@chromium.org
+
+[chromium] move remaining methods that just set a boolean flag to TestRunner library
+https://bugs.webkit.org/show_bug.cgi?id=106823
+
+Reviewed by Darin Fisher.
+
+* DumpRenderTree/chromium/DRTTestRunner.cpp:
+(DRTTestRunner::DRTTestRunner):
+(DRTTestRunner::reset):
+* DumpRenderTree/chromium/DRTTestRunner.h:
+(DRTTestRunner):
+* DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
+(WebTestRunner::WebTestRunner::shouldDumpBackForwardList):
+(WebTestRunner::WebTestRunner::deferMainResourceDataLoad):
+(WebTestRunner::WebTestRunner::shouldDumpSelectionRect):
+(WebTestRunner::WebTestRunner::testRepaint):
+(WebTestRunner::WebTestRunner::sweepHorizontally):
+(WebTestRunner::WebTestRunner::isPrinting):
+(WebTestRunner::WebTestRunner::shouldStayOnPageAfterHandlingBeforeUnload):
+* DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
+(WebTestRunner::TestRunner::TestRunner):
+(WebTestRunner::TestRunner::reset):
+(WebTestRunner::TestRunner::shouldDumpBackForwardList):
+(WebTestRunner):
+(WebTestRunner::TestRunner::deferMainResourceDataLoad):
+(WebTestRunner::TestRunner::shouldDumpSelectionRect):
+(WebTestRunner::TestRunner::testRepaint):
+(WebTestRunner::TestRunner::sweepHorizontally):
+(WebTestRunner::TestRunner::isPrinting):
+(WebTestRunner::TestRunner::shouldStayOnPageAfterHandlingBeforeUnload):
+(WebTestRunner::TestRunner::dumpBackForwardList):
+(WebTestRunner::TestRunner::setDeferMainResourceDataLoad):
+(WebTestRunner::TestRunner::dumpSelectionRect):
+(WebTestRunner::TestRunner::repaintSweepHorizontally):
+(WebTestRunner::TestRunner::setPrinting):
+(WebTestRunner::TestRunner::setShouldStayOnPageAfterHandlingBeforeUnload):
+* DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
+(TestRunner):
+
 2013-01-14  Dirk Pranke  dpra...@chromium.org
 
 nrwt: stub out show_results_html for mock ports


Modified: trunk/Tools/DumpRenderTree/chromium/DRTTestRunner.cpp (139721 => 139722)

--- trunk/Tools/DumpRenderTree/chromium/DRTTestRunner.cpp	2013-01-15 07:55:47 UTC (rev 139721)
+++ trunk/Tools/DumpRenderTree/chromium/DRTTestRunner.cpp	2013-01-15 08:19:57 UTC (rev 139722)
@@ -87,10 +87,8 @@
 DRTTestRunner::DRTTestRunner(TestShell* shell)
 : m_shell(shell)
 , m_closeRemainingWindows(false)
-, m_deferMainResourceDataLoad(false)

[webkit-changes] [139723] trunk/Source/WebCore

[rniwa]

Title: [139723] trunk/Source/WebCore








Revision 139723
Author rn...@webkit.org
Date 2013-01-15 00:30:34 -0800 (Tue, 15 Jan 2013)


Log Message
platform/mac/accessibility/progressbar.html fails on Mac WK1 and WK2
https://bugs.webkit.org/show_bug.cgi?id=106850

Reviewed by Chris Fleizach.

The bug was caused by some callers of supportsFocus directly calling that of Node.
Fixed the bug by calling HTMLElement's so that the virtual function on Element gets
called as needed.

* html/HTMLMeterElement.cpp:
(WebCore::HTMLMeterElement::supportsFocus):
* html/HTMLOutputElement.cpp:
(WebCore::HTMLOutputElement::supportsFocus):
* html/HTMLProgressElement.cpp:
(WebCore::HTMLProgressElement::supportsFocus):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/HTMLMeterElement.cpp
trunk/Source/WebCore/html/HTMLOutputElement.cpp
trunk/Source/WebCore/html/HTMLProgressElement.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (139722 => 139723)

--- trunk/Source/WebCore/ChangeLog	2013-01-15 08:19:57 UTC (rev 139722)
+++ trunk/Source/WebCore/ChangeLog	2013-01-15 08:30:34 UTC (rev 139723)
@@ -1,3 +1,21 @@
+2013-01-14  Ryosuke Niwa  rn...@webkit.org
+
+platform/mac/accessibility/progressbar.html fails on Mac WK1 and WK2
+https://bugs.webkit.org/show_bug.cgi?id=106850
+
+Reviewed by Chris Fleizach.
+
+The bug was caused by some callers of supportsFocus directly calling that of Node.
+Fixed the bug by calling HTMLElement's so that the virtual function on Element gets
+called as needed.
+
+* html/HTMLMeterElement.cpp:
+(WebCore::HTMLMeterElement::supportsFocus):
+* html/HTMLOutputElement.cpp:
+(WebCore::HTMLOutputElement::supportsFocus):
+* html/HTMLProgressElement.cpp:
+(WebCore::HTMLProgressElement::supportsFocus):
+
 2013-01-14  Dima Gorbik  dgor...@apple.com
 
 Implement ID selector matching for the WebVTT ::cue pseudo element


Modified: trunk/Source/WebCore/html/HTMLMeterElement.cpp (139722 => 139723)

--- trunk/Source/WebCore/html/HTMLMeterElement.cpp	2013-01-15 08:19:57 UTC (rev 139722)
+++ trunk/Source/WebCore/html/HTMLMeterElement.cpp	2013-01-15 08:30:34 UTC (rev 139723)
@@ -74,7 +74,7 @@
 
 bool HTMLMeterElement::supportsFocus() const
 {
-return Node::supportsFocus()  !disabled();
+return HTMLElement::supportsFocus()  !disabled();
 }
 
 void HTMLMeterElement::parseAttribute(const QualifiedName name, const AtomicString value)


Modified: trunk/Source/WebCore/html/HTMLOutputElement.cpp (139722 => 139723)

--- trunk/Source/WebCore/html/HTMLOutputElement.cpp	2013-01-15 08:19:57 UTC (rev 139722)
+++ trunk/Source/WebCore/html/HTMLOutputElement.cpp	2013-01-15 08:30:34 UTC (rev 139723)
@@ -58,7 +58,7 @@
 
 bool HTMLOutputElement::supportsFocus() const
 {
-return Node::supportsFocus()  !disabled();
+return HTMLElement::supportsFocus()  !disabled();
 }
 
 void HTMLOutputElement::parseAttribute(const QualifiedName name, const AtomicString value)


Modified: trunk/Source/WebCore/html/HTMLProgressElement.cpp (139722 => 139723)

--- trunk/Source/WebCore/html/HTMLProgressElement.cpp	2013-01-15 08:19:57 UTC (rev 139722)
+++ trunk/Source/WebCore/html/HTMLProgressElement.cpp	2013-01-15 08:30:34 UTC (rev 139723)
@@ -90,7 +90,7 @@
 
 bool HTMLProgressElement::supportsFocus() const
 {
-return Node::supportsFocus()  !disabled();
+return HTMLElement::supportsFocus()  !disabled();
 }
 
 void HTMLProgressElement::parseAttribute(const QualifiedName name, const AtomicString value)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [139724] trunk/Source/WebCore

[commit-queue]

Title: [139724] trunk/Source/WebCore








Revision 139724
Author commit-qu...@webkit.org
Date 2013-01-15 00:54:59 -0800 (Tue, 15 Jan 2013)


Log Message
[EFL] [WebGL] Minor cleanup in PlatformContext.
https://bugs.webkit.org/show_bug.cgi?id=106758

Patch by Kondapally Kalyan kalyan.kondapa...@intel.com on 2013-01-15
Reviewed by Kenneth Rohde Christiansen.

We currently have different implementations of CurrentContextWrapper for EGL and GLX.
This patch cleans up the code to use same implementation for both the backends.

* platform/graphics/opengl/GLPlatformContext.cpp:
(GLCurrentContextWrapper):
(WebCore::GLCurrentContextWrapper::GLCurrentContextWrapper):
(WebCore::GLCurrentContextWrapper::~GLCurrentContextWrapper):

Common implementation for both EGL and GLX.
(WebCore::createOffScreenContext):
(WebCore::GLPlatformContext::createContext):
* platform/graphics/surfaces/egl/EGLContext.cpp:
* platform/graphics/surfaces/egl/EGLContext.h:
* platform/graphics/surfaces/glx/GLXContext.h:

Removed code related to CurrentContextWrapper.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/opengl/GLPlatformContext.cpp
trunk/Source/WebCore/platform/graphics/surfaces/egl/EGLContext.cpp
trunk/Source/WebCore/platform/graphics/surfaces/egl/EGLContext.h
trunk/Source/WebCore/platform/graphics/surfaces/glx/GLXContext.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (139723 => 139724)

--- trunk/Source/WebCore/ChangeLog	2013-01-15 08:30:34 UTC (rev 139723)
+++ trunk/Source/WebCore/ChangeLog	2013-01-15 08:54:59 UTC (rev 139724)
@@ -1,3 +1,27 @@
+2013-01-15  Kondapally Kalyan  kalyan.kondapa...@intel.com
+
+[EFL] [WebGL] Minor cleanup in PlatformContext.
+https://bugs.webkit.org/show_bug.cgi?id=106758
+
+Reviewed by Kenneth Rohde Christiansen.
+
+We currently have different implementations of CurrentContextWrapper for EGL and GLX.
+This patch cleans up the code to use same implementation for both the backends.
+
+* platform/graphics/opengl/GLPlatformContext.cpp:
+(GLCurrentContextWrapper):
+(WebCore::GLCurrentContextWrapper::GLCurrentContextWrapper):
+(WebCore::GLCurrentContextWrapper::~GLCurrentContextWrapper):
+
+Common implementation for both EGL and GLX.
+(WebCore::createOffScreenContext):
+(WebCore::GLPlatformContext::createContext):
+* platform/graphics/surfaces/egl/EGLContext.cpp:
+* platform/graphics/surfaces/egl/EGLContext.h:
+* platform/graphics/surfaces/glx/GLXContext.h:
+
+Removed code related to CurrentContextWrapper.
+
 2013-01-14  Ryosuke Niwa  rn...@webkit.org
 
 platform/mac/accessibility/progressbar.html fails on Mac WK1 and WK2


Modified: trunk/Source/WebCore/platform/graphics/opengl/GLPlatformContext.cpp (139723 => 139724)

--- trunk/Source/WebCore/platform/graphics/opengl/GLPlatformContext.cpp	2013-01-15 08:30:34 UTC (rev 139723)
+++ trunk/Source/WebCore/platform/graphics/opengl/GLPlatformContext.cpp	2013-01-15 08:54:59 UTC (rev 139724)
@@ -36,6 +36,10 @@
 
 #include NotImplemented.h
 
+#if HAVE(GLX)
+#include GL/glx.h
+#endif
+
 namespace WebCore {
 
 #if USE(OPENGL_ES_2)
@@ -45,23 +49,31 @@
 #endif
 static GLPlatformContext* m_currentContext = 0;
 
-static PassOwnPtrGLPlatformContext createOffScreenContext()
-{
-#if USE(GLX)
-return adoptPtr(new GLXOffScreenContext());
+class GLCurrentContextWrapper : public GLPlatformContext {
+
+public:
+GLCurrentContextWrapper()
+: GLPlatformContext()
+{
+// FIXME:: This is a workaround until support to build evas with EGL has been added.
+#if USE(GLX) || PLATFORM(EFL)
+m_contextHandle = glXGetCurrentContext();
 #elif USE(EGL)
-return adoptPtr(new EGLOffScreenContext());
+m_contextHandle = eglGetCurrentContext();
 #endif
+if (m_contextHandle)
+m_currentContext = this;
+}
 
-return nullptr;
-}
+virtual ~GLCurrentContextWrapper() { }
+};
 
-static PassOwnPtrGLPlatformContext createCurrentContextWrapper()
+static PassOwnPtrGLPlatformContext createOffScreenContext()
 {
 #if USE(GLX)
-return adoptPtr(new GLXCurrentContextWrapper());
+return adoptPtr(new GLXOffScreenContext());
 #elif USE(EGL)
-return adoptPtr(new EGLCurrentContextWrapper());
+return adoptPtr(new EGLOffScreenContext());
 #endif
 
 return nullptr;
@@ -104,12 +116,12 @@
 
 switch (renderStyle) {
 case GraphicsContext3D::RenderOffscreen:
-if (OwnPtrGLPlatformContext glxContext = createOffScreenContext())
-return glxContext.release();
+if (OwnPtrGLPlatformContext context = createOffScreenContext())
+return context.release();
 break;
 case GraphicsContext3D::RenderToCurrentGLContext:
-if (OwnPtrGLPlatformContext glxContext = createCurrentContextWrapper())
-return glxContext.release();
+if (OwnPtrGLPlatformContext context = adoptPtr(new 

[webkit-changes] [139725] trunk/Source/WebCore

[commit-queue]

Title: [139725] trunk/Source/WebCore








Revision 139725
Author commit-qu...@webkit.org
Date 2013-01-15 00:56:42 -0800 (Tue, 15 Jan 2013)


Log Message
[EFL][WebGL] Add error handling to carefully manage Window backing pixmaps.
https://bugs.webkit.org/show_bug.cgi?id=106582

Patch by Kondapally Kalyan kalyan.kondapa...@intel.com on 2013-01-15
Reviewed by Kenneth Rohde Christiansen.

We use XCompositeNameWindowPixmap to create a pixmap that serves as a reference to
the off-screen storage for a Window Handle. We expect the Window to be valid and
the created glx pixmap to be a valid drawable. This may not be true always.
This patch adds support for X Error checks and handles the generated errors.

Covered by existing WebGL layout tests.

* platform/graphics/surfaces/glx/GraphicsSurfaceGLX.cpp:
(WebCore):
(WebCore::handleXPixmapCreationError):
(ScopedXPixmapCreationErrorHandler):
(WebCore::ScopedXPixmapCreationErrorHandler::ScopedXPixmapCreationErrorHandler):
(WebCore::ScopedXPixmapCreationErrorHandler::~ScopedXPixmapCreationErrorHandler):
(WebCore::ScopedXPixmapCreationErrorHandler::isValidOperation):
Helper Class to catch XErrors.

(WebCore::GraphicsSurfacePrivate::~GraphicsSurfacePrivate):
(WebCore::GraphicsSurfacePrivate::createPixmap): Added support to check and handle generated XErrors.
(WebCore::GraphicsSurfacePrivate::findFBConfigWithAlpha):
(WebCore::GraphicsSurfacePrivate::clear): Destroys GL Resources.
(GraphicsSurfacePrivate):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/surfaces/glx/GraphicsSurfaceGLX.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (139724 => 139725)

--- trunk/Source/WebCore/ChangeLog	2013-01-15 08:54:59 UTC (rev 139724)
+++ trunk/Source/WebCore/ChangeLog	2013-01-15 08:56:42 UTC (rev 139725)
@@ -1,5 +1,34 @@
 2013-01-15  Kondapally Kalyan  kalyan.kondapa...@intel.com
 
+[EFL][WebGL] Add error handling to carefully manage Window backing pixmaps.
+https://bugs.webkit.org/show_bug.cgi?id=106582
+
+Reviewed by Kenneth Rohde Christiansen.
+
+We use XCompositeNameWindowPixmap to create a pixmap that serves as a reference to
+the off-screen storage for a Window Handle. We expect the Window to be valid and
+the created glx pixmap to be a valid drawable. This may not be true always.
+This patch adds support for X Error checks and handles the generated errors.
+
+Covered by existing WebGL layout tests.
+
+* platform/graphics/surfaces/glx/GraphicsSurfaceGLX.cpp:
+(WebCore):
+(WebCore::handleXPixmapCreationError):
+(ScopedXPixmapCreationErrorHandler):
+(WebCore::ScopedXPixmapCreationErrorHandler::ScopedXPixmapCreationErrorHandler):
+(WebCore::ScopedXPixmapCreationErrorHandler::~ScopedXPixmapCreationErrorHandler):
+(WebCore::ScopedXPixmapCreationErrorHandler::isValidOperation):
+Helper Class to catch XErrors.
+
+(WebCore::GraphicsSurfacePrivate::~GraphicsSurfacePrivate):
+(WebCore::GraphicsSurfacePrivate::createPixmap): Added support to check and handle generated XErrors.
+(WebCore::GraphicsSurfacePrivate::findFBConfigWithAlpha):
+(WebCore::GraphicsSurfacePrivate::clear): Destroys GL Resources.
+(GraphicsSurfacePrivate):
+
+2013-01-15  Kondapally Kalyan  kalyan.kondapa...@intel.com
+
 [EFL] [WebGL] Minor cleanup in PlatformContext.
 https://bugs.webkit.org/show_bug.cgi?id=106758
 


Modified: trunk/Source/WebCore/platform/graphics/surfaces/glx/GraphicsSurfaceGLX.cpp (139724 => 139725)

--- trunk/Source/WebCore/platform/graphics/surfaces/glx/GraphicsSurfaceGLX.cpp	2013-01-15 08:54:59 UTC (rev 139724)
+++ trunk/Source/WebCore/platform/graphics/surfaces/glx/GraphicsSurfaceGLX.cpp	2013-01-15 08:56:42 UTC (rev 139725)
@@ -36,6 +36,7 @@
 
 #include GL/glext.h
 #include GL/glx.h
+#include X11/Xlib.h
 #include X11/extensions/Xcomposite.h
 #include X11/extensions/Xrender.h
 
@@ -51,6 +52,31 @@
 static PFNGLDELETEFRAMEBUFFERSPROC pGlDeleteFramebuffers = 0;
 static PFNGLFRAMEBUFFERTEXTURE2DPROC pGlFramebufferTexture2D = 0;
 
+// Used for handling XError.
+static bool validOperation = true;
+static int handleXPixmapCreationError(Display*, XErrorEvent* event)
+{
+if (event-error_code == BadMatch || event-error_code == BadWindow || event-error_code == BadAlloc) {
+validOperation = false;
+
+switch (event-error_code) {
+case BadMatch:
+LOG_ERROR(BadMatch.);
+break;
+case BadWindow:
+LOG_ERROR(BadWindow.);
+break;
+case BadAlloc:
+LOG_ERROR(BadAlloc.);
+break;
+default:
+break;
+}
+}
+
+return 0;
+}
+
 static int attributes[] = {
 GLX_LEVEL, 0,
 GLX_DRAWABLE_TYPE, GLX_WINDOW_BIT,
@@ -65,6 +91,37 @@
 None
 };
 
+class ScopedXPixmapCreationErrorHandler {
+
+public:
+ScopedXPixmapCreationErrorHandler(Display* 

[webkit-changes] [139727] trunk/Tools

[abecsi]

Title: [139727] trunk/Tools








Revision 139727
Author abe...@webkit.org
Date 2013-01-15 01:33:54 -0800 (Tue, 15 Jan 2013)


Log Message
[Qt] Fix ImageDiff's image format conversion
https://bugs.webkit.org/show_bug.cgi?id=106880

Reviewed by Csaba Osztrogonác.

Besides actually doing the conversion this also silences the suspicious warning:
ignoring return value of function declared with warn_unused_result attribute.

* ImageDiff/qt/ImageDiff.cpp:
(main): QImage::convertToFormat, contrary to the assumed behaviour, returns a
copy of the image in the given format and does not alter the image itself.

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/ImageDiff/qt/ImageDiff.cpp




Diff

Modified: trunk/Tools/ChangeLog (139726 => 139727)

--- trunk/Tools/ChangeLog	2013-01-15 09:06:01 UTC (rev 139726)
+++ trunk/Tools/ChangeLog	2013-01-15 09:33:54 UTC (rev 139727)
@@ -1,3 +1,17 @@
+2013-01-15  Andras Becsi  andras.be...@digia.com
+
+[Qt] Fix ImageDiff's image format conversion
+https://bugs.webkit.org/show_bug.cgi?id=106880
+
+Reviewed by Csaba Osztrogonác.
+
+Besides actually doing the conversion this also silences the suspicious warning:
+ignoring return value of function declared with warn_unused_result attribute.
+
+* ImageDiff/qt/ImageDiff.cpp:
+(main): QImage::convertToFormat, contrary to the assumed behaviour, returns a
+copy of the image in the given format and does not alter the image itself.
+
 2013-01-15  Jochen Eisinger  joc...@chromium.org
 
 [chromium] move remaining methods that just set a boolean flag to TestRunner library


Modified: trunk/Tools/ImageDiff/qt/ImageDiff.cpp (139726 => 139727)

--- trunk/Tools/ImageDiff/qt/ImageDiff.cpp	2013-01-15 09:06:01 UTC (rev 139726)
+++ trunk/Tools/ImageDiff/qt/ImageDiff.cpp	2013-01-15 09:33:54 UTC (rev 139727)
@@ -70,7 +70,7 @@
 // Convert into QImage
 QImage decodedImage;
 decodedImage.loadFromData(data.data(), PNG);
-decodedImage.convertToFormat(QImage::Format_ARGB32);
+decodedImage = decodedImage.convertToFormat(QImage::Format_ARGB32);
 
 // Place it in the right place
 if (actualImage.isNull())






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [139728] trunk/PerformanceTests

[dominicc]

Title: [139728] trunk/PerformanceTests








Revision 139728
Author domin...@chromium.org
Date 2013-01-15 01:42:25 -0800 (Tue, 15 Jan 2013)


Log Message
Allow zero values as results from the runFunction.
https://bugs.webkit.org/show_bug.cgi?id=102500

Reviewed by Kentaro Hara.

DOM/DOMWalk.js fails on the Chromium Win perf bot because one or
more parts of the test usually return zero at some point.

* resources/runner.js: Accept merely non-negative results.

Modified Paths

trunk/PerformanceTests/ChangeLog
trunk/PerformanceTests/resources/runner.js




Diff

Modified: trunk/PerformanceTests/ChangeLog (139727 => 139728)

--- trunk/PerformanceTests/ChangeLog	2013-01-15 09:33:54 UTC (rev 139727)
+++ trunk/PerformanceTests/ChangeLog	2013-01-15 09:42:25 UTC (rev 139728)
@@ -1,3 +1,15 @@
+2013-01-15  Dominic Cooney  domin...@chromium.org
+
+Allow zero values as results from the runFunction.
+https://bugs.webkit.org/show_bug.cgi?id=102500
+
+Reviewed by Kentaro Hara.
+
+DOM/DOMWalk.js fails on the Chromium Win perf bot because one or
+more parts of the test usually return zero at some point.
+
+* resources/runner.js: Accept merely non-negative results.
+
 2012-12-28  Yury Semikhatsky  yu...@chromium.org
 
 Web Inspector: rename distanceToWindow to distance


Modified: trunk/PerformanceTests/resources/runner.js (139727 => 139728)

--- trunk/PerformanceTests/resources/runner.js	2013-01-15 09:33:54 UTC (rev 139727)
+++ trunk/PerformanceTests/resources/runner.js	2013-01-15 09:42:25 UTC (rev 139728)
@@ -257,8 +257,8 @@
 var end = PerfTestRunner.now();
 
 if (returnValue - 0 === returnValue) {
-if (returnValue = 0)
-PerfTestRunner.log(runFunction returned a non-positive value:  + returnValue);
+if (returnValue  0)
+PerfTestRunner.log(runFunction returned a negative value:  + returnValue);
 return returnValue;
 }
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [139730] trunk/LayoutTests

[ossy]

Title: [139730] trunk/LayoutTests








Revision 139730
Author o...@webkit.org
Date 2013-01-15 01:51:00 -0800 (Tue, 15 Jan 2013)


Log Message
[Qt] Gardening

Skip failing tests after r139609.
https://bugs.webkit.org/show_bug.cgi?id=104909

Skip failing inspector/editor/text-editor-formatter.html test.
https://bugs.webkit.org/show_bug.cgi?id=106883

Patch by Szilard Ledan szle...@inf.u-szeged.hu on 2013-01-15
Reviewed by Csaba Osztrogonác.

* platform/qt/TestExpectations:
* platform/qt/scrollingcoordinator/non-fast-scrollable-region-scaled-iframe-expected.png: Added after r139686.
* platform/qt/scrollingcoordinator/non-fast-scrollable-region-scaled-iframe-expected.txt: Added after r139686.
* platform/qt/scrollingcoordinator/non-fast-scrollable-region-transformed-iframe-expected.png: Added after r139686.
* platform/qt/scrollingcoordinator/non-fast-scrollable-region-transformed-iframe-expected.txt: Added after r139686.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/qt/TestExpectations


Added Paths

trunk/LayoutTests/platform/qt/scrollingcoordinator/
trunk/LayoutTests/platform/qt/scrollingcoordinator/non-fast-scrollable-region-scaled-iframe-expected.png
trunk/LayoutTests/platform/qt/scrollingcoordinator/non-fast-scrollable-region-scaled-iframe-expected.txt
trunk/LayoutTests/platform/qt/scrollingcoordinator/non-fast-scrollable-region-transformed-iframe-expected.png
trunk/LayoutTests/platform/qt/scrollingcoordinator/non-fast-scrollable-region-transformed-iframe-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (139729 => 139730)

--- trunk/LayoutTests/ChangeLog	2013-01-15 09:46:29 UTC (rev 139729)
+++ trunk/LayoutTests/ChangeLog	2013-01-15 09:51:00 UTC (rev 139730)
@@ -1,3 +1,21 @@
+2013-01-15  Szilard Ledan  szle...@inf.u-szeged.hu
+
+[Qt] Gardening
+
+Skip failing tests after r139609.
+https://bugs.webkit.org/show_bug.cgi?id=104909
+
+Skip failing inspector/editor/text-editor-formatter.html test.
+https://bugs.webkit.org/show_bug.cgi?id=106883
+
+Reviewed by Csaba Osztrogonác.
+
+* platform/qt/TestExpectations:
+* platform/qt/scrollingcoordinator/non-fast-scrollable-region-scaled-iframe-expected.png: Added after r139686.
+* platform/qt/scrollingcoordinator/non-fast-scrollable-region-scaled-iframe-expected.txt: Added after r139686.
+* platform/qt/scrollingcoordinator/non-fast-scrollable-region-transformed-iframe-expected.png: Added after r139686.
+* platform/qt/scrollingcoordinator/non-fast-scrollable-region-transformed-iframe-expected.txt: Added after r139686.
+
 2013-01-15  Andrey Adaikin  aand...@chromium.org
 
 Web Inspector: [Canvas] introduce CallArgument type into the protocol


Modified: trunk/LayoutTests/platform/qt/TestExpectations (139729 => 139730)

--- trunk/LayoutTests/platform/qt/TestExpectations	2013-01-15 09:46:29 UTC (rev 139729)
+++ trunk/LayoutTests/platform/qt/TestExpectations	2013-01-15 09:51:00 UTC (rev 139730)
@@ -1808,6 +1808,12 @@
 # https://bugs.webkit.org/show_bug.cgi?id=98751
 fast/xmlhttprequest/xmlhttprequest-nonexistent-file.html
 
+# [Qt] REGRESSION (r139609) - should be unskipped after Qt update (with system libjpeg/libpng)
+# https://bugs.webkit.org/show_bug.cgi?id=104909
+fast/events/mouse-cursor-multiframecur.html
+fast/events/mouse-cursor.html
+fast/images/icon-decoding.html
+
 # = #
 # failing security tests
 # = #
@@ -2507,3 +2513,7 @@
 
 # [Qt] New fast/js/dfg-create-inlined-arguments-in-closure-inline.html asserts on 32 bit
 webkit.org/b/106459 [ Debug ] fast/js/dfg-create-inlined-arguments-in-closure-inline.html
+
+# New inspector/editor/text-editor-formatter.html introduced in r139617 fails on EFL, Mac, QT
+# https://bugs.webkit.org/show_bug.cgi?id=106883
+inspector/editor/text-editor-formatter.html


Added: trunk/LayoutTests/platform/qt/scrollingcoordinator/non-fast-scrollable-region-scaled-iframe-expected.png

(Binary files differ)

Property changes on: trunk/LayoutTests/platform/qt/scrollingcoordinator/non-fast-scrollable-region-scaled-iframe-expected.png
___

Added: svn:mime-type

Added: trunk/LayoutTests/platform/qt/scrollingcoordinator/non-fast-scrollable-region-scaled-iframe-expected.txt (0 => 139730)

--- trunk/LayoutTests/platform/qt/scrollingcoordinator/non-fast-scrollable-region-scaled-iframe-expected.txt	(rev 0)
+++ trunk/LayoutTests/platform/qt/scrollingcoordinator/non-fast-scrollable-region-scaled-iframe-expected.txt	2013-01-15 09:51:00 UTC (rev 139730)
@@ -0,0 +1,12 @@
+layer at (0,0) size 785x585
+  RenderView at (0,0) size 785x585
+layer at (0,0) size 785x8
+  RenderBlock {HTML} at (0,0) size 785x8
+RenderBody {BODY} at (8,8) size 769x0
+layer at (50,50) size 324x224
+  

[webkit-changes] [139731] trunk/Source/WebCore

[allan . jensen]

Title: [139731] trunk/Source/WebCore








Revision 139731
Author allan.jen...@digia.com
Date 2013-01-15 02:01:57 -0800 (Tue, 15 Jan 2013)


Log Message
[Qt][CSS Shaders] Make custom filter render in Wk1 mode
https://bugs.webkit.org/show_bug.cgi?id=101532

Reviewed by Noam Rosenthal.

Handle ValidatedCustomFilterOperations which are used by WebKit1. To keep the cache of compiled programs working,
the cache has been updated to use CustomFilterProgramInfo as a hash key. CustomFilterProgramInfo is an existing
class specifically designed for this purpose.

* platform/graphics/texmap/TextureMapperGL.cpp:
(WebCore::getPassesRequiredForFilter):
(WebCore::TextureMapperGL::removeCachedCustomFilterProgram):
(WebCore::TextureMapperGL::drawUsingCustomFilter):
(WebCore::BitmapTextureGL::applyFilters):
* platform/graphics/texmap/TextureMapperGL.h:
(TextureMapperGL):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/texmap/TextureMapperGL.cpp
trunk/Source/WebCore/platform/graphics/texmap/TextureMapperGL.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (139730 => 139731)

--- trunk/Source/WebCore/ChangeLog	2013-01-15 09:51:00 UTC (rev 139730)
+++ trunk/Source/WebCore/ChangeLog	2013-01-15 10:01:57 UTC (rev 139731)
@@ -1,3 +1,22 @@
+2013-01-15  Allan Sandfeld Jensen  allan.jen...@digia.com
+
+[Qt][CSS Shaders] Make custom filter render in Wk1 mode
+https://bugs.webkit.org/show_bug.cgi?id=101532
+
+Reviewed by Noam Rosenthal.
+
+Handle ValidatedCustomFilterOperations which are used by WebKit1. To keep the cache of compiled programs working, 
+the cache has been updated to use CustomFilterProgramInfo as a hash key. CustomFilterProgramInfo is an existing
+class specifically designed for this purpose.
+
+* platform/graphics/texmap/TextureMapperGL.cpp:
+(WebCore::getPassesRequiredForFilter):
+(WebCore::TextureMapperGL::removeCachedCustomFilterProgram):
+(WebCore::TextureMapperGL::drawUsingCustomFilter):
+(WebCore::BitmapTextureGL::applyFilters):
+* platform/graphics/texmap/TextureMapperGL.h:
+(TextureMapperGL):
+
 2013-01-15  Andrey Adaikin  aand...@chromium.org
 
 Web Inspector: [Canvas] introduce CallArgument type into the protocol


Modified: trunk/Source/WebCore/platform/graphics/texmap/TextureMapperGL.cpp (139730 => 139731)

--- trunk/Source/WebCore/platform/graphics/texmap/TextureMapperGL.cpp	2013-01-15 09:51:00 UTC (rev 139730)
+++ trunk/Source/WebCore/platform/graphics/texmap/TextureMapperGL.cpp	2013-01-15 10:01:57 UTC (rev 139731)
@@ -736,6 +736,7 @@
 case FilterOperation::OPACITY:
 #if ENABLE(CSS_SHADERS)
 case FilterOperation::CUSTOM:
+case FilterOperation::VALIDATED_CUSTOM:
 #endif
 return 1;
 case FilterOperation::BLUR:
@@ -843,7 +844,7 @@
 #if ENABLE(CSS_SHADERS)
 void TextureMapperGL::removeCachedCustomFilterProgram(CustomFilterProgram* program)
 {
-m_customFilterPrograms.remove(program);
+m_customFilterPrograms.remove(program-programInfo());
 }
 
 bool TextureMapperGL::drawUsingCustomFilter(BitmapTexture target, const BitmapTexture source, const FilterOperation filter)
@@ -858,10 +859,10 @@
 renderer = CustomFilterRenderer::create(m_context3D, program-programType(), customFilter-parameters(), 
 customFilter-meshRows(), customFilter-meshColumns(), customFilter-meshType());
 RefPtrCustomFilterCompiledProgram compiledProgram;
-CustomFilterProgramMap::iterator iter = m_customFilterPrograms.find(program.get());
+CustomFilterProgramMap::iterator iter = m_customFilterPrograms.find(program-programInfo());
 if (iter == m_customFilterPrograms.end()) {
 compiledProgram = CustomFilterCompiledProgram::create(m_context3D, program-vertexShaderString(), program-fragmentShaderString(), program-programType());
-m_customFilterPrograms.set(program.get(), compiledProgram);
+m_customFilterPrograms.set(program-programInfo(), compiledProgram);
 } else
 compiledProgram = iter-value;
 renderer-setCompiledProgram(compiledProgram.release());
@@ -869,9 +870,19 @@
 }
 case FilterOperation::VALIDATED_CUSTOM: {
 // WebKit1 uses the ValidatedCustomFilterOperation.
-// FIXME: This path is not working yet as GraphicsContext3D fails to initialize.
-// https://bugs.webkit.org/show_bug.cgi?id=101532
-return false;
+const ValidatedCustomFilterOperation* customFilter = static_castconst ValidatedCustomFilterOperation*(filter);
+RefPtrCustomFilterValidatedProgram program = customFilter-validatedProgram();
+renderer = CustomFilterRenderer::create(m_context3D, program-programInfo().programType(), customFilter-parameters(),
+customFilter-meshRows(), customFilter-meshColumns(), customFilter-meshType());
+RefPtrCustomFilterCompiledProgram compiledProgram;
+

[webkit-changes] [139732] trunk

[tommyw]

Title: [139732] trunk








Revision 139732
Author tom...@google.com
Date 2013-01-15 02:45:04 -0800 (Tue, 15 Jan 2013)


Log Message
MediaStream API: Fixing crashing bug in MediaStream
https://bugs.webkit.org/show_bug.cgi?id=106886

Reviewed by Eric Seidel.

Source/WebCore:

Fixing crashing bug during destruction.

No new tests needed.

* Modules/mediastream/MediaStream.cpp:
(WebCore::MediaStream::contextDestroyed):

LayoutTests:

Removing obsolete exception.

* platform/chromium/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/TestExpectations
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/mediastream/MediaStream.cpp




Diff

Modified: trunk/LayoutTests/ChangeLog (139731 => 139732)

--- trunk/LayoutTests/ChangeLog	2013-01-15 10:01:57 UTC (rev 139731)
+++ trunk/LayoutTests/ChangeLog	2013-01-15 10:45:04 UTC (rev 139732)
@@ -1,3 +1,14 @@
+2013-01-15  Tommy Widenflycht  tom...@google.com
+
+MediaStream API: Fixing crashing bug in MediaStream
+https://bugs.webkit.org/show_bug.cgi?id=106886
+
+Reviewed by Eric Seidel.
+
+Removing obsolete exception.
+
+* platform/chromium/TestExpectations:
+
 2013-01-15  Szilard Ledan  szle...@inf.u-szeged.hu
 
 [Qt] Gardening


Modified: trunk/LayoutTests/platform/chromium/TestExpectations (139731 => 139732)

--- trunk/LayoutTests/platform/chromium/TestExpectations	2013-01-15 10:01:57 UTC (rev 139731)
+++ trunk/LayoutTests/platform/chromium/TestExpectations	2013-01-15 10:45:04 UTC (rev 139732)
@@ -4366,5 +4366,4 @@
 
 webkit.org/b/106833 fast/borders/outline-alpha-inline.html [ Pass ImageOnlyFailure ]
 webkit.org/b/106858 [ SnowLeopard Debug ] scrollingcoordinator/non-fast-scrollable-region-transformed-iframe.html [ ImageOnlyFailure ]
-webkit.org/b/106869 [ Lion Debug ] fast/mediastream/RTCPeerConnection-events.html [ Crash ]
 webkit.org/b/106875 [ XP ] svg/dynamic-updates/SVGFESpecularLightingElement-remove-lightSource.html [ ImageOnlyFailure ]


Modified: trunk/Source/WebCore/ChangeLog (139731 => 139732)

--- trunk/Source/WebCore/ChangeLog	2013-01-15 10:01:57 UTC (rev 139731)
+++ trunk/Source/WebCore/ChangeLog	2013-01-15 10:45:04 UTC (rev 139732)
@@ -1,3 +1,17 @@
+2013-01-15  Tommy Widenflycht  tom...@google.com
+
+MediaStream API: Fixing crashing bug in MediaStream
+https://bugs.webkit.org/show_bug.cgi?id=106886
+
+Reviewed by Eric Seidel.
+
+Fixing crashing bug during destruction.
+
+No new tests needed.
+
+* Modules/mediastream/MediaStream.cpp:
+(WebCore::MediaStream::contextDestroyed):
+
 2013-01-15  Allan Sandfeld Jensen  allan.jen...@digia.com
 
 [Qt][CSS Shaders] Make custom filter render in Wk1 mode


Modified: trunk/Source/WebCore/Modules/mediastream/MediaStream.cpp (139731 => 139732)

--- trunk/Source/WebCore/Modules/mediastream/MediaStream.cpp	2013-01-15 10:01:57 UTC (rev 139731)
+++ trunk/Source/WebCore/Modules/mediastream/MediaStream.cpp	2013-01-15 10:45:04 UTC (rev 139732)
@@ -231,6 +231,7 @@
 
 void MediaStream::contextDestroyed()
 {
+ContextDestructionObserver::contextDestroyed();
 m_stopped = true;
 }
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [139733] branches/chromium/1312/Source/WebCore/inspector/ InspectorOverlayPage.html

[pfeldman]

Title: [139733] branches/chromium/1312/Source/WebCore/inspector/InspectorOverlayPage.html








Revision 139733
Author pfeld...@chromium.org
Date 2013-01-15 03:29:48 -0800 (Tue, 15 Jan 2013)


Log Message
Merge 135732
 Not reviewed: follow up for r135720, fixing node highlight.
 
 * inspector/InspectorOverlayPage.html:

TBR=pfeld...@chromium.org
BUG=169722
Review URL: https://codereview.chromium.org/11881050

Modified Paths

branches/chromium/1312/Source/WebCore/inspector/InspectorOverlayPage.html




Diff

Modified: branches/chromium/1312/Source/WebCore/inspector/InspectorOverlayPage.html (139732 => 139733)

--- branches/chromium/1312/Source/WebCore/inspector/InspectorOverlayPage.html	2013-01-15 10:45:04 UTC (rev 139732)
+++ branches/chromium/1312/Source/WebCore/inspector/InspectorOverlayPage.html	2013-01-15 11:29:48 UTC (rev 139733)
@@ -344,9 +344,9 @@
 document.getElementById(tag-name).textContent = elementInfo.tagName;
 document.getElementById(node-id).textContent = elementInfo.idValue ? # + elementInfo.idValue : ;
 var className = elementInfo.className;
-if (className.length  50)
+if (className  className.length  50)
className = className.substring(0, 50) + \u2026;
-document.getElementById(class-name).textContent = className;
+document.getElementById(class-name).textContent = className || ;
 document.getElementById(node-width).textContent = elementInfo.nodeWidth;
 document.getElementById(node-height).textContent = elementInfo.nodeHeight;
 var elementTitle = document.getElementById(element-title);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [139734] trunk/Source/WebCore

[commit-queue]

Title: [139734] trunk/Source/WebCore








Revision 139734
Author commit-qu...@webkit.org
Date 2013-01-15 05:31:49 -0800 (Tue, 15 Jan 2013)


Log Message
[CSS] Rename the enum, from ETextAlignLast to TextAlignLast
https://bugs.webkit.org/show_bug.cgi?id=106887

Patch by Dongwoo Joshua Im dw...@samsung.com on 2013-01-15
Reviewed by Alexis Menard.

No new tests are added since there is no behavior changes.

* css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::operator TextAlignLast):
* css/StyleBuilder.cpp:
(WebCore::StyleBuilder::StyleBuilder):
* rendering/style/RenderStyle.h:
* rendering/style/RenderStyleConstants.h:
* rendering/style/StyleRareInheritedData.h:
(StyleRareInheritedData):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/CSSPrimitiveValueMappings.h
trunk/Source/WebCore/css/StyleBuilder.cpp
trunk/Source/WebCore/rendering/style/RenderStyle.h
trunk/Source/WebCore/rendering/style/RenderStyleConstants.h
trunk/Source/WebCore/rendering/style/StyleRareInheritedData.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (139733 => 139734)

--- trunk/Source/WebCore/ChangeLog	2013-01-15 11:29:48 UTC (rev 139733)
+++ trunk/Source/WebCore/ChangeLog	2013-01-15 13:31:49 UTC (rev 139734)
@@ -1,3 +1,22 @@
+2013-01-15  Dongwoo Joshua Im  dw...@samsung.com
+
+[CSS] Rename the enum, from ETextAlignLast to TextAlignLast
+https://bugs.webkit.org/show_bug.cgi?id=106887
+
+Reviewed by Alexis Menard.
+
+No new tests are added since there is no behavior changes.
+
+* css/CSSPrimitiveValueMappings.h:
+(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
+(WebCore::CSSPrimitiveValue::operator TextAlignLast):
+* css/StyleBuilder.cpp:
+(WebCore::StyleBuilder::StyleBuilder):
+* rendering/style/RenderStyle.h:
+* rendering/style/RenderStyleConstants.h:
+* rendering/style/StyleRareInheritedData.h:
+(StyleRareInheritedData):
+
 2013-01-15  Tommy Widenflycht  tom...@google.com
 
 MediaStream API: Fixing crashing bug in MediaStream


Modified: trunk/Source/WebCore/css/CSSPrimitiveValueMappings.h (139733 => 139734)

--- trunk/Source/WebCore/css/CSSPrimitiveValueMappings.h	2013-01-15 11:29:48 UTC (rev 139733)
+++ trunk/Source/WebCore/css/CSSPrimitiveValueMappings.h	2013-01-15 13:31:49 UTC (rev 139734)
@@ -2238,7 +2238,7 @@
 }
 
 #if ENABLE(CSS3_TEXT)
-template inline CSSPrimitiveValue::CSSPrimitiveValue(ETextAlignLast e)
+template inline CSSPrimitiveValue::CSSPrimitiveValue(TextAlignLast e)
 : CSSValue(PrimitiveClass)
 {
 m_primitiveUnitType = CSS_IDENT;
@@ -2267,7 +2267,7 @@
 }
 }
 
-template inline CSSPrimitiveValue::operator ETextAlignLast() const
+template inline CSSPrimitiveValue::operator TextAlignLast() const
 {
 switch (m_value.ident) {
 case CSSValueAuto:


Modified: trunk/Source/WebCore/css/StyleBuilder.cpp (139733 => 139734)

--- trunk/Source/WebCore/css/StyleBuilder.cpp	2013-01-15 11:29:48 UTC (rev 139733)
+++ trunk/Source/WebCore/css/StyleBuilder.cpp	2013-01-15 13:31:49 UTC (rev 139734)
@@ -1922,7 +1922,7 @@
 #if ENABLE(CSS3_TEXT)
 setPropertyHandler(CSSPropertyWebkitTextDecorationLine, ApplyPropertyTextDecoration::createHandler());
 setPropertyHandler(CSSPropertyWebkitTextDecorationStyle, ApplyPropertyDefaultTextDecorationStyle, RenderStyle::textDecorationStyle, TextDecorationStyle, RenderStyle::setTextDecorationStyle, TextDecorationStyle, RenderStyle::initialTextDecorationStyle::createHandler());
-setPropertyHandler(CSSPropertyWebkitTextAlignLast, ApplyPropertyDefaultETextAlignLast, RenderStyle::textAlignLast, ETextAlignLast, RenderStyle::setTextAlignLast, ETextAlignLast, RenderStyle::initialTextAlignLast::createHandler());
+setPropertyHandler(CSSPropertyWebkitTextAlignLast, ApplyPropertyDefaultTextAlignLast, RenderStyle::textAlignLast, TextAlignLast, RenderStyle::setTextAlignLast, TextAlignLast, RenderStyle::initialTextAlignLast::createHandler());
 #endif // CSS3_TEXT
 setPropertyHandler(CSSPropertyTextIndent, ApplyPropertyLengthRenderStyle::textIndent, RenderStyle::setTextIndent, RenderStyle::initialTextIndent::createHandler());
 setPropertyHandler(CSSPropertyTextOverflow, ApplyPropertyDefaultTextOverflow, RenderStyle::textOverflow, TextOverflow, RenderStyle::setTextOverflow, TextOverflow, RenderStyle::initialTextOverflow::createHandler());


Modified: trunk/Source/WebCore/rendering/style/RenderStyle.h (139733 => 139734)

--- trunk/Source/WebCore/rendering/style/RenderStyle.h	2013-01-15 11:29:48 UTC (rev 139733)
+++ trunk/Source/WebCore/rendering/style/RenderStyle.h	2013-01-15 13:31:49 UTC (rev 139734)
@@ -563,7 +563,7 @@
 ETextDecoration textDecoration() const { return static_castETextDecoration(visual-textDecoration); }
 #if ENABLE(CSS3_TEXT)
 TextDecorationStyle textDecorationStyle() const { return 

[webkit-changes] [139735] trunk/Source/WebCore

[haraken]

Title: [139735] trunk/Source/WebCore








Revision 139735
Author hara...@chromium.org
Date 2013-01-15 05:49:57 -0800 (Tue, 15 Jan 2013)


Log Message
[V8] Make an Isolate parameter mandatory in SerializedScriptValue methods
https://bugs.webkit.org/show_bug.cgi?id=106800

Reviewed by Adam Barth.

SerializedScriptValue methods are used by both V8 bindings
and WebCore. So they should support both an Isolate-version
method and an non-Isolate version method.

There are two ways to accomplish that:

[1] Use an optional Isolate parameter.

[2] Implement two versions and delegate the non-Isolate
version method to the Isolate version method.

I would prefer the approach [2], because I'd like to statically
make sure that we never pass a 0 Isolate. If we take the approach
[1], we need to insert ASSERT(isolate) here and there.

This patch implements the approach [2].

No tests. No change in behavior.

* bindings/v8/SerializedScriptValue.cpp:
(WebCore::SerializedScriptValue::create):
(WebCore):
(WebCore::SerializedScriptValue::nullValue):
(WebCore::SerializedScriptValue::undefinedValue):
(WebCore::SerializedScriptValue::booleanValue):
(WebCore::SerializedScriptValue::numberValue):
(WebCore::SerializedScriptValue::SerializedScriptValue):
* bindings/v8/SerializedScriptValue.h:
(SerializedScriptValue):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/v8/SerializedScriptValue.cpp
trunk/Source/WebCore/bindings/v8/SerializedScriptValue.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (139734 => 139735)

--- trunk/Source/WebCore/ChangeLog	2013-01-15 13:31:49 UTC (rev 139734)
+++ trunk/Source/WebCore/ChangeLog	2013-01-15 13:49:57 UTC (rev 139735)
@@ -1,3 +1,40 @@
+2013-01-14  Kentaro Hara  hara...@chromium.org
+
+[V8] Make an Isolate parameter mandatory in SerializedScriptValue methods
+https://bugs.webkit.org/show_bug.cgi?id=106800
+
+Reviewed by Adam Barth.
+
+SerializedScriptValue methods are used by both V8 bindings
+and WebCore. So they should support both an Isolate-version
+method and an non-Isolate version method.
+
+There are two ways to accomplish that:
+
+[1] Use an optional Isolate parameter.
+
+[2] Implement two versions and delegate the non-Isolate
+version method to the Isolate version method.
+
+I would prefer the approach [2], because I'd like to statically
+make sure that we never pass a 0 Isolate. If we take the approach
+[1], we need to insert ASSERT(isolate) here and there.
+
+This patch implements the approach [2].
+
+No tests. No change in behavior.
+
+* bindings/v8/SerializedScriptValue.cpp:
+(WebCore::SerializedScriptValue::create):
+(WebCore):
+(WebCore::SerializedScriptValue::nullValue):
+(WebCore::SerializedScriptValue::undefinedValue):
+(WebCore::SerializedScriptValue::booleanValue):
+(WebCore::SerializedScriptValue::numberValue):
+(WebCore::SerializedScriptValue::SerializedScriptValue):
+* bindings/v8/SerializedScriptValue.h:
+(SerializedScriptValue):
+
 2013-01-15  Dongwoo Joshua Im  dw...@samsung.com
 
 [CSS] Rename the enum, from ETextAlignLast to TextAlignLast


Modified: trunk/Source/WebCore/bindings/v8/SerializedScriptValue.cpp (139734 => 139735)

--- trunk/Source/WebCore/bindings/v8/SerializedScriptValue.cpp	2013-01-15 13:31:49 UTC (rev 139734)
+++ trunk/Source/WebCore/bindings/v8/SerializedScriptValue.cpp	2013-01-15 13:49:57 UTC (rev 139735)
@@ -2231,14 +2231,21 @@
 
 } // namespace
 
-PassRefPtrSerializedScriptValue SerializedScriptValue::create(v8::Handlev8::Value value,
-MessagePortArray* messagePorts, ArrayBufferArray* arrayBuffers,
-bool didThrow,
-v8::Isolate* isolate)
+PassRefPtrSerializedScriptValue SerializedScriptValue::create(v8::Handlev8::Value value, MessagePortArray* messagePorts, ArrayBufferArray* arrayBuffers, bool didThrow)
 {
+return create(value, messagePorts, arrayBuffers, didThrow, v8::Isolate::GetCurrent());
+}
+
+PassRefPtrSerializedScriptValue SerializedScriptValue::create(v8::Handlev8::Value value, MessagePortArray* messagePorts, ArrayBufferArray* arrayBuffers, bool didThrow, v8::Isolate* isolate)
+{
 return adoptRef(new SerializedScriptValue(value, messagePorts, arrayBuffers, didThrow, isolate));
 }
 
+PassRefPtrSerializedScriptValue SerializedScriptValue::create(v8::Handlev8::Value value)
+{
+return create(value, v8::Isolate::GetCurrent());
+}
+
 PassRefPtrSerializedScriptValue SerializedScriptValue::create(v8::Handlev8::Value value, v8::Isolate* isolate)
 {
 bool didThrow;
@@ -2264,6 +2271,11 @@
 return createFromWire(String::adopt(buffer));
 }
 
+PassRefPtrSerializedScriptValue SerializedScriptValue::create(const 

[webkit-changes] [139736] trunk/Tools

[zandobersek]

Title: [139736] trunk/Tools








Revision 139736
Author zandober...@gmail.com
Date 2013-01-15 07:10:14 -0800 (Tue, 15 Jan 2013)


Log Message
[GTK] Limit the number of frames printed out when backtracing with gdb
https://bugs.webkit.org/show_bug.cgi?id=106901

Reviewed by Philippe Normand.

Printing an unlimited number of frames when dumping the gdb backtracing
output can cause timeouts in the builders. This patch limits the number
of frames that are printed out to 1024.

* Scripts/webkitpy/layout_tests/port/gtk.py:
(GtkPort._get_gdb_output):

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/layout_tests/port/gtk.py




Diff

Modified: trunk/Tools/ChangeLog (139735 => 139736)

--- trunk/Tools/ChangeLog	2013-01-15 13:49:57 UTC (rev 139735)
+++ trunk/Tools/ChangeLog	2013-01-15 15:10:14 UTC (rev 139736)
@@ -1,3 +1,17 @@
+2013-01-15  Zan Dobersek  zdober...@igalia.com
+
+[GTK] Limit the number of frames printed out when backtracing with gdb
+https://bugs.webkit.org/show_bug.cgi?id=106901
+
+Reviewed by Philippe Normand.
+
+Printing an unlimited number of frames when dumping the gdb backtracing
+output can cause timeouts in the builders. This patch limits the number
+of frames that are printed out to 1024.
+
+* Scripts/webkitpy/layout_tests/port/gtk.py:
+(GtkPort._get_gdb_output):
+
 2013-01-15  Andras Becsi  andras.be...@digia.com
 
 [Qt] Fix ImageDiff's image format conversion


Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/gtk.py (139735 => 139736)

--- trunk/Tools/Scripts/webkitpy/layout_tests/port/gtk.py	2013-01-15 13:49:57 UTC (rev 139735)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/port/gtk.py	2013-01-15 15:10:14 UTC (rev 139736)
@@ -125,7 +125,7 @@
 self._run_script(run-launcher, run_launcher_args)
 
 def _get_gdb_output(self, coredump_path):
-cmd = ['gdb', '-ex', 'thread apply all bt', '--batch', str(self._path_to_driver()), coredump_path]
+cmd = ['gdb', '-ex', 'thread apply all bt 1024', '--batch', str(self._path_to_driver()), coredump_path]
 proc = subprocess.Popen(cmd, stdin=None, stdout=subprocess.PIPE, stderr=subprocess.PIPE)
 proc.wait()
 errors = [l.strip().decode('utf8', 'ignore') for l in proc.stderr.readlines()]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [139737] trunk/LayoutTests

[commit-queue]

Title: [139737] trunk/LayoutTests








Revision 139737
Author commit-qu...@webkit.org
Date 2013-01-15 07:12:11 -0800 (Tue, 15 Jan 2013)


Log Message
[Chromium] media/track/track-css-cue-lifetime.html Win7 dbg times out since r139562
https://bugs.webkit.org/show_bug.cgi?id=106853

Patch by Dima Gorbik dgor...@apple.com on 2013-01-15
Reviewed by Eric Carlson.

The amount of seeks may be reduced significantly since they may be slow.

* media/track/track-css-cue-lifetime-expected.txt:
* media/track/track-css-cue-lifetime.html:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/media/track/track-css-cue-lifetime-expected.txt
trunk/LayoutTests/media/track/track-css-cue-lifetime.html




Diff

Modified: trunk/LayoutTests/ChangeLog (139736 => 139737)

--- trunk/LayoutTests/ChangeLog	2013-01-15 15:10:14 UTC (rev 139736)
+++ trunk/LayoutTests/ChangeLog	2013-01-15 15:12:11 UTC (rev 139737)
@@ -1,3 +1,15 @@
+2013-01-15  Dima Gorbik  dgor...@apple.com
+
+[Chromium] media/track/track-css-cue-lifetime.html Win7 dbg times out since r139562
+https://bugs.webkit.org/show_bug.cgi?id=106853
+
+Reviewed by Eric Carlson.
+
+The amount of seeks may be reduced significantly since they may be slow.
+
+* media/track/track-css-cue-lifetime-expected.txt:
+* media/track/track-css-cue-lifetime.html:
+
 2013-01-15  Tommy Widenflycht  tom...@google.com
 
 MediaStream API: Fixing crashing bug in MediaStream


Modified: trunk/LayoutTests/media/track/track-css-cue-lifetime-expected.txt (139736 => 139737)

--- trunk/LayoutTests/media/track/track-css-cue-lifetime-expected.txt	2013-01-15 15:10:14 UTC (rev 139736)
+++ trunk/LayoutTests/media/track/track-css-cue-lifetime-expected.txt	2013-01-15 15:12:11 UTC (rev 139737)
@@ -5,142 +5,34 @@
 EXPECTED (getComputedStyle(cueNode).color == 'rgb(0, 128, 0)') OK
 EXPECTED (getComputedStyle(cueNode).color == 'rgb(255, 0, 0)') OK
 1
-RUN(video.currentTime = 0.7)
+RUN(video.currentTime = 0.5)
 EVENT(seeked)
 EXPECTED (getComputedStyle(cueNode).color == 'rgb(255, 0, 0)') OK
 EXPECTED (getComputedStyle(cueNode).color == 'rgb(0, 128, 0)') OK
 EXPECTED (getComputedStyle(cueNode).color == 'rgb(255, 0, 0)') OK
 2
-RUN(video.currentTime = 0.8)
+RUN(video.currentTime = 0.9)
 EVENT(seeked)
 EXPECTED (getComputedStyle(cueNode).color == 'rgb(255, 0, 0)') OK
 EXPECTED (getComputedStyle(cueNode).color == 'rgb(0, 128, 0)') OK
 EXPECTED (getComputedStyle(cueNode).color == 'rgb(255, 0, 0)') OK
 3
-RUN(video.currentTime = 0.9)
+RUN(video.currentTime = 1.3)
 EVENT(seeked)
 EXPECTED (getComputedStyle(cueNode).color == 'rgb(255, 0, 0)') OK
 EXPECTED (getComputedStyle(cueNode).color == 'rgb(0, 128, 0)') OK
 EXPECTED (getComputedStyle(cueNode).color == 'rgb(255, 0, 0)') OK
 4
-RUN(video.currentTime = 1)
+RUN(video.currentTime = 1.7)
 EVENT(seeked)
 EXPECTED (getComputedStyle(cueNode).color == 'rgb(255, 0, 0)') OK
 EXPECTED (getComputedStyle(cueNode).color == 'rgb(0, 128, 0)') OK
 EXPECTED (getComputedStyle(cueNode).color == 'rgb(255, 0, 0)') OK
 5
-RUN(video.currentTime = 1.1)
-EVENT(seeked)
-EXPECTED (getComputedStyle(cueNode).color == 'rgb(255, 0, 0)') OK
-EXPECTED (getComputedStyle(cueNode).color == 'rgb(0, 128, 0)') OK
-EXPECTED (getComputedStyle(cueNode).color == 'rgb(255, 0, 0)') OK
-6
-RUN(video.currentTime = 1.2002)
-EVENT(seeked)
-EXPECTED (getComputedStyle(cueNode).color == 'rgb(255, 0, 0)') OK
-EXPECTED (getComputedStyle(cueNode).color == 'rgb(0, 128, 0)') OK
-EXPECTED (getComputedStyle(cueNode).color == 'rgb(255, 0, 0)') OK
-7
-RUN(video.currentTime = 1.3)
-EVENT(seeked)
-EXPECTED (getComputedStyle(cueNode).color == 'rgb(255, 0, 0)') OK
-EXPECTED (getComputedStyle(cueNode).color == 'rgb(0, 128, 0)') OK
-EXPECTED (getComputedStyle(cueNode).color == 'rgb(255, 0, 0)') OK
-8
-RUN(video.currentTime = 1.4)
-EVENT(seeked)
-EXPECTED (getComputedStyle(cueNode).color == 'rgb(255, 0, 0)') OK
-EXPECTED (getComputedStyle(cueNode).color == 'rgb(0, 128, 0)') OK
-EXPECTED (getComputedStyle(cueNode).color == 'rgb(255, 0, 0)') OK
-9
-RUN(video.currentTime = 1.5)
-EVENT(seeked)
-EXPECTED (getComputedStyle(cueNode).color == 'rgb(255, 0, 0)') OK
-EXPECTED (getComputedStyle(cueNode).color == 'rgb(0, 128, 0)') OK
-EXPECTED (getComputedStyle(cueNode).color == 'rgb(255, 0, 0)') OK
-10
-RUN(video.currentTime = 1.6)
-EVENT(seeked)
-EXPECTED (getComputedStyle(cueNode).color == 'rgb(255, 0, 0)') OK
-EXPECTED (getComputedStyle(cueNode).color == 'rgb(0, 128, 0)') OK
-EXPECTED (getComputedStyle(cueNode).color == 'rgb(255, 0, 0)') OK
-11
-RUN(video.currentTime = 1.7002)
-EVENT(seeked)
-EXPECTED (getComputedStyle(cueNode).color == 'rgb(255, 0, 0)') OK
-EXPECTED (getComputedStyle(cueNode).color == 'rgb(0, 128, 0)') OK
-EXPECTED (getComputedStyle(cueNode).color == 'rgb(255, 0, 0)') OK
-12
-RUN(video.currentTime = 1.8003)
-EVENT(seeked)
-EXPECTED (getComputedStyle(cueNode).color == 'rgb(255, 0, 0)') OK
-EXPECTED (getComputedStyle(cueNode).color 

[webkit-changes] [139738] trunk/Source/WebCore

[zeno . albisser]

Title: [139738] trunk/Source/WebCore








Revision 139738
Author zeno.albis...@digia.com
Date 2013-01-15 07:41:34 -0800 (Tue, 15 Jan 2013)


Log Message
GraphicsSurface: Canvas with WebGL content is painted off by one pixel
https://bugs.webkit.org/show_bug.cgi?id=106446

When painting to TextureMapper the provided targetRect is in contents
coordinate system. This leads to an off by one pixel error when painting
outlines of 1px.
This needs to be taken into account in the transformation matrix
and in the TextureMapperGL::drawTexture call.

Test: fast/canvas/webgl/webgl-composite-modes.html

Reviewed by Noam Rosenthal.

* platform/graphics/surfaces/glx/GraphicsSurfaceGLX.cpp:
(WebCore::GraphicsSurface::platformPaintToTextureMapper):
* platform/graphics/surfaces/mac/GraphicsSurfaceMac.cpp:
(WebCore::GraphicsSurface::platformPaintToTextureMapper):
* platform/graphics/surfaces/win/GraphicsSurfaceWin.cpp:
(WebCore::GraphicsSurface::platformPaintToTextureMapper):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/surfaces/glx/GraphicsSurfaceGLX.cpp
trunk/Source/WebCore/platform/graphics/surfaces/mac/GraphicsSurfaceMac.cpp
trunk/Source/WebCore/platform/graphics/surfaces/win/GraphicsSurfaceWin.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (139737 => 139738)

--- trunk/Source/WebCore/ChangeLog	2013-01-15 15:12:11 UTC (rev 139737)
+++ trunk/Source/WebCore/ChangeLog	2013-01-15 15:41:34 UTC (rev 139738)
@@ -1,3 +1,25 @@
+2013-01-15  Zeno Albisser  z...@webkit.org
+
+GraphicsSurface: Canvas with WebGL content is painted off by one pixel
+https://bugs.webkit.org/show_bug.cgi?id=106446
+
+When painting to TextureMapper the provided targetRect is in contents
+coordinate system. This leads to an off by one pixel error when painting
+outlines of 1px.
+This needs to be taken into account in the transformation matrix
+and in the TextureMapperGL::drawTexture call.
+
+Test: fast/canvas/webgl/webgl-composite-modes.html
+
+Reviewed by Noam Rosenthal.
+
+* platform/graphics/surfaces/glx/GraphicsSurfaceGLX.cpp:
+(WebCore::GraphicsSurface::platformPaintToTextureMapper):
+* platform/graphics/surfaces/mac/GraphicsSurfaceMac.cpp:
+(WebCore::GraphicsSurface::platformPaintToTextureMapper):
+* platform/graphics/surfaces/win/GraphicsSurfaceWin.cpp:
+(WebCore::GraphicsSurface::platformPaintToTextureMapper):
+
 2013-01-14  Kentaro Hara  hara...@chromium.org
 
 [V8] Make an Isolate parameter mandatory in SerializedScriptValue methods


Modified: trunk/Source/WebCore/platform/graphics/surfaces/glx/GraphicsSurfaceGLX.cpp (139737 => 139738)

--- trunk/Source/WebCore/platform/graphics/surfaces/glx/GraphicsSurfaceGLX.cpp	2013-01-15 15:12:11 UTC (rev 139737)
+++ trunk/Source/WebCore/platform/graphics/surfaces/glx/GraphicsSurfaceGLX.cpp	2013-01-15 15:41:34 UTC (rev 139738)
@@ -515,18 +515,20 @@
 
 void GraphicsSurface::platformPaintToTextureMapper(TextureMapper* textureMapper, const FloatRect targetRect, const TransformationMatrix transform, float opacity, BitmapTexture* mask)
 {
-TextureMapperGL* texMapGL = static_castTextureMapperGL*(textureMapper);
 IntSize size = m_private-size();
 if (size.isEmpty())
 return;
 uint32_t texture = platformGetTextureID();
 if (!texture)
 return;
-TransformationMatrix adjustedTransform = transform;
-adjustedTransform.multiply(TransformationMatrix::rectToRect(FloatRect(FloatPoint::zero(), size), targetRect));
+
 TextureMapperGL::Flags flags = m_private-textureIsYInverted() ? TextureMapperGL::ShouldFlipTexture : 0;
 flags |= TextureMapperGL::ShouldBlend;
-texMapGL-drawTexture(texture, flags, size, targetRect, adjustedTransform, opacity, mask);
+
+FloatRect rectOnContents(FloatPoint::zero(), size);
+TransformationMatrix adjustedTransform = transform;
+adjustedTransform.multiply(TransformationMatrix::rectToRect(rectOnContents, targetRect));
+static_castTextureMapperGL*(textureMapper)-drawTexture(texture, flags, size, rectOnContents, adjustedTransform, opacity, mask);
 }
 
 uint32_t GraphicsSurface::platformFrontBuffer() const


Modified: trunk/Source/WebCore/platform/graphics/surfaces/mac/GraphicsSurfaceMac.cpp (139737 => 139738)

--- trunk/Source/WebCore/platform/graphics/surfaces/mac/GraphicsSurfaceMac.cpp	2013-01-15 15:12:11 UTC (rev 139737)
+++ trunk/Source/WebCore/platform/graphics/surfaces/mac/GraphicsSurfaceMac.cpp	2013-01-15 15:41:34 UTC (rev 139738)
@@ -335,9 +335,11 @@
 
 void GraphicsSurface::platformPaintToTextureMapper(TextureMapper* textureMapper, const FloatRect targetRect, const TransformationMatrix transform, float opacity, BitmapTexture* mask)
 {
+IntSize size = m_private-size();
+FloatRect rectOnContents(FloatPoint::zero(), size);
 TransformationMatrix adjustedTransform = transform;
-

[webkit-changes] [139739] trunk

[commit-queue]

Title: [139739] trunk








Revision 139739
Author commit-qu...@webkit.org
Date 2013-01-15 07:42:55 -0800 (Tue, 15 Jan 2013)


Log Message
display:inline's hover behavior is not applied to ::before and ::after pseudo elements
https://bugs.webkit.org/show_bug.cgi?id=91723

Patch by Elliott Sprehn espr...@gmail.com on 2013-01-15
Reviewed by Eric Seidel.

Source/WebCore:

When hovering over the anonymous text renderers inside :before and :after
we would correctly detect a hit in InlineTextBox::nodeAtPoint, but would
then fail to set the correct node for the hit test because in
RenderObject::updateHitTestResult node() is null. Instead we should walk
up the render tree to the PseudoElement and treat it as if we hit that.

Test: fast/css-generated-content/hover-inline.html

* rendering/RenderObject.cpp:
(WebCore::RenderObject::updateHitTestResult):

LayoutTests:

Add a test that hovering generated content inside an inline element causes
the element to become hovered.

* fast/css-generated-content/hover-inline-expected.txt: Added.
* fast/css-generated-content/hover-inline.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderObject.cpp


Added Paths

trunk/LayoutTests/fast/css-generated-content/hover-inline-expected.txt
trunk/LayoutTests/fast/css-generated-content/hover-inline.html




Diff

Modified: trunk/LayoutTests/ChangeLog (139738 => 139739)

--- trunk/LayoutTests/ChangeLog	2013-01-15 15:41:34 UTC (rev 139738)
+++ trunk/LayoutTests/ChangeLog	2013-01-15 15:42:55 UTC (rev 139739)
@@ -1,3 +1,16 @@
+2013-01-15  Elliott Sprehn  espr...@gmail.com
+
+display:inline's hover behavior is not applied to ::before and ::after pseudo elements
+https://bugs.webkit.org/show_bug.cgi?id=91723
+
+Reviewed by Eric Seidel.
+
+Add a test that hovering generated content inside an inline element causes
+the element to become hovered.
+
+* fast/css-generated-content/hover-inline-expected.txt: Added.
+* fast/css-generated-content/hover-inline.html: Added.
+
 2013-01-15  Dima Gorbik  dgor...@apple.com
 
 [Chromium] media/track/track-css-cue-lifetime.html Win7 dbg times out since r139562


Added: trunk/LayoutTests/fast/css-generated-content/hover-inline-expected.txt (0 => 139739)

--- trunk/LayoutTests/fast/css-generated-content/hover-inline-expected.txt	(rev 0)
+++ trunk/LayoutTests/fast/css-generated-content/hover-inline-expected.txt	2013-01-15 15:42:55 UTC (rev 139739)
@@ -0,0 +1,2 @@
+Hovering the generated text should hover the span:
+PASS


Added: trunk/LayoutTests/fast/css-generated-content/hover-inline.html (0 => 139739)

--- trunk/LayoutTests/fast/css-generated-content/hover-inline.html	(rev 0)
+++ trunk/LayoutTests/fast/css-generated-content/hover-inline.html	2013-01-15 15:42:55 UTC (rev 139739)
@@ -0,0 +1,25 @@
+!DOCTYPE html
+
+style
+* { margin: 0; padding: 0; }
+span:before { content: Hover this text.; }
+/style
+
+span/span
+
+pHovering the generated text should hover the span: /p
+
+script
+if (window.testRunner)
+testRunner.dumpAsText();
+
+_onload_ = function() {
+// Need to cause a layout before hover will work.
+document.body.offsetLeft;
+document.querySelector('span')._onmouseover_ = function() {
+document.body.appendChild(document.createElement('p')).textContent = 'PASS';
+};
+if (window.eventSender)
+eventSender.mouseMoveTo(5, 5);
+}
+/script


Modified: trunk/Source/WebCore/ChangeLog (139738 => 139739)

--- trunk/Source/WebCore/ChangeLog	2013-01-15 15:41:34 UTC (rev 139738)
+++ trunk/Source/WebCore/ChangeLog	2013-01-15 15:42:55 UTC (rev 139739)
@@ -1,3 +1,21 @@
+2013-01-15  Elliott Sprehn  espr...@gmail.com
+
+display:inline's hover behavior is not applied to ::before and ::after pseudo elements
+https://bugs.webkit.org/show_bug.cgi?id=91723
+
+Reviewed by Eric Seidel.
+
+When hovering over the anonymous text renderers inside :before and :after
+we would correctly detect a hit in InlineTextBox::nodeAtPoint, but would
+then fail to set the correct node for the hit test because in
+RenderObject::updateHitTestResult node() is null. Instead we should walk
+up the render tree to the PseudoElement and treat it as if we hit that.
+
+Test: fast/css-generated-content/hover-inline.html
+
+* rendering/RenderObject.cpp:
+(WebCore::RenderObject::updateHitTestResult):
+
 2013-01-15  Zeno Albisser  z...@webkit.org
 
 GraphicsSurface: Canvas with WebGL content is painted off by one pixel


Modified: trunk/Source/WebCore/rendering/RenderObject.cpp (139738 => 139739)

--- trunk/Source/WebCore/rendering/RenderObject.cpp	2013-01-15 15:41:34 UTC (rev 139738)
+++ trunk/Source/WebCore/rendering/RenderObject.cpp	2013-01-15 15:42:55 UTC (rev 139739)
@@ -2626,11 +2626,19 @@
 if (result.innerNode())
 

[webkit-changes] [139740] trunk/Source/WebCore

[commit-queue]

Title: [139740] trunk/Source/WebCore








Revision 139740
Author commit-qu...@webkit.org
Date 2013-01-15 07:50:11 -0800 (Tue, 15 Jan 2013)


Log Message
Web Inspector: refactor DefaultTextEditor's paintLine method
https://bugs.webkit.org/show_bug.cgi?id=106893

Patch by Andrey Lushnikov lushni...@chromium.org on 2013-01-15
Reviewed by Pavel Feldman.

Move render ranges functionality out of paintLine method into separate subroutine.

No new tests: no change in behaviour.

* inspector/front-end/DefaultTextEditor.js:
(WebInspector.TextEditorMainPanel.prototype._renderRanges): Added.
(WebInspector.TextEditorMainPanel.prototype._paintLine):
(WebInspector.TextEditorMainPanel.prototype._insertSpanBefore):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/DefaultTextEditor.js




Diff

Modified: trunk/Source/WebCore/ChangeLog (139739 => 139740)

--- trunk/Source/WebCore/ChangeLog	2013-01-15 15:42:55 UTC (rev 139739)
+++ trunk/Source/WebCore/ChangeLog	2013-01-15 15:50:11 UTC (rev 139740)
@@ -1,3 +1,19 @@
+2013-01-15  Andrey Lushnikov  lushni...@chromium.org
+
+Web Inspector: refactor DefaultTextEditor's paintLine method
+https://bugs.webkit.org/show_bug.cgi?id=106893
+
+Reviewed by Pavel Feldman.
+
+Move render ranges functionality out of paintLine method into separate subroutine.
+
+No new tests: no change in behaviour.
+
+* inspector/front-end/DefaultTextEditor.js:
+(WebInspector.TextEditorMainPanel.prototype._renderRanges): Added.
+(WebInspector.TextEditorMainPanel.prototype._paintLine):
+(WebInspector.TextEditorMainPanel.prototype._insertSpanBefore):
+
 2013-01-15  Elliott Sprehn  espr...@gmail.com
 
 display:inline's hover behavior is not applied to ::before and ::after pseudo elements


Modified: trunk/Source/WebCore/inspector/front-end/DefaultTextEditor.js (139739 => 139740)

--- trunk/Source/WebCore/inspector/front-end/DefaultTextEditor.js	2013-01-15 15:42:55 UTC (rev 139739)
+++ trunk/Source/WebCore/inspector/front-end/DefaultTextEditor.js	2013-01-15 15:50:11 UTC (rev 139740)
@@ -1865,7 +1865,50 @@
 
 /**
  * @param {Element} lineRow
+ * @param {string} line
+ * @param {Array.{startColumn: number, endColumn: number, cssClass: string}} ranges
  */
+_renderRanges: function(lineRow, line, ranges)
+{
+var decorationsElement = lineRow.decorationsElement;
+
+if (!decorationsElement)
+lineRow.removeChildren();
+else {
+while (true) {
+var child = lineRow.firstChild;
+if (!child || child === decorationsElement)
+break;
+lineRow.removeChild(child);
+}
+}
+
+if (!line)
+lineRow.insertBefore(document.createElement(br), decorationsElement);
+
+var plainTextStart = 0;
+for(var i = 0; i  ranges.length; i++) {
+var rangeStart = ranges[i].startColumn;
+var rangeEnd = ranges[i].endColumn;
+var cssClass = ranges[i].token ? webkit- + ranges[i].token : ;
+
+if (plainTextStart  rangeStart) {
+this._insertTextNodeBefore(lineRow, decorationsElement, line.substring(plainTextStart, rangeStart));
+--this._paintLinesOperationsCredit;
+}
+this._insertSpanBefore(lineRow, decorationsElement, line.substring(rangeStart, rangeEnd + 1), cssClass);
+--this._paintLinesOperationsCredit;
+plainTextStart = rangeEnd + 1;
+}
+if (plainTextStart  line.length) {
+this._insertTextNodeBefore(lineRow, decorationsElement, line.substring(plainTextStart, line.length));
+--this._paintLinesOperationsCredit;
+}
+},
+
+/**
+ * @param {Element} lineRow
+ */
 _paintLine: function(lineRow)
 {
 var lineNumber = lineRow.lineNumber;
@@ -1881,42 +1924,9 @@
 if (!highlight)
 return;
 
-var decorationsElement = lineRow.decorationsElement;
-if (!decorationsElement)
-lineRow.removeChildren();
-else {
-while (true) {
-var child = lineRow.firstChild;
-if (!child || child === decorationsElement)
-break;
-lineRow.removeChild(child);
-}
-}
-
 var line = this._textModel.line(lineNumber);
 var ranges = this._highlighter.orderedRangesPerLine(lineNumber);
-
-if (!line)
-lineRow.insertBefore(document.createElement(br), decorationsElement);
-
-var plainTextStart = 0;
-for(var i = 0; i  ranges.length; i++) {
-var rangeStart = ranges[i].startColumn;
-var rangeEnd = ranges[i].endColumn;
-var rangeToken = ranges[i].token;
-
- 

[webkit-changes] [139741] trunk/LayoutTests

[vsevik]

Title: [139741] trunk/LayoutTests








Revision 139741
Author vse...@chromium.org
Date 2013-01-15 07:57:41 -0800 (Tue, 15 Jan 2013)


Log Message
Unreviewed failing test skip.
https://bugs.webkit.org/show_bug.cgi?id=106883

* platform/efl/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/efl/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (139740 => 139741)

--- trunk/LayoutTests/ChangeLog	2013-01-15 15:50:11 UTC (rev 139740)
+++ trunk/LayoutTests/ChangeLog	2013-01-15 15:57:41 UTC (rev 139741)
@@ -1,3 +1,10 @@
+2013-01-15  Vsevolod Vlasov  vse...@chromium.org
+
+Unreviewed failing test skip.
+https://bugs.webkit.org/show_bug.cgi?id=106883
+
+* platform/efl/TestExpectations:
+
 2013-01-15  Elliott Sprehn  espr...@gmail.com
 
 display:inline's hover behavior is not applied to ::before and ::after pseudo elements


Modified: trunk/LayoutTests/platform/efl/TestExpectations (139740 => 139741)

--- trunk/LayoutTests/platform/efl/TestExpectations	2013-01-15 15:50:11 UTC (rev 139740)
+++ trunk/LayoutTests/platform/efl/TestExpectations	2013-01-15 15:57:41 UTC (rev 139741)
@@ -1806,3 +1806,7 @@
 # Started failing due to new checks added in r139547.
 webkit.org/b/106743 media/video-controls-captions.html [ Failure ]
 
+# New inspector/editor/text-editor-formatter.html introduced in r139617 fails on EFL, Mac, QT
+# https://bugs.webkit.org/show_bug.cgi?id=106883
+inspector/editor/text-editor-formatter.html
+






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [139742] trunk/Source/WebCore

[allan . jensen]

Title: [139742] trunk/Source/WebCore








Revision 139742
Author allan.jen...@digia.com
Date 2013-01-15 08:01:56 -0800 (Tue, 15 Jan 2013)


Log Message
[Qt] WebGL does not require accelerated compositing
https://bugs.webkit.org/show_bug.cgi?id=106892

Reviewed by Jocelyn Turcotte.

Allow the creation of WebGL canvas even when accelerated compositing is not enabled.

* html/HTMLCanvasElement.cpp:
(WebCore::HTMLCanvasElement::getContext):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/HTMLCanvasElement.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (139741 => 139742)

--- trunk/Source/WebCore/ChangeLog	2013-01-15 15:57:41 UTC (rev 139741)
+++ trunk/Source/WebCore/ChangeLog	2013-01-15 16:01:56 UTC (rev 139742)
@@ -1,3 +1,15 @@
+2013-01-15  Allan Sandfeld Jensen  allan.jen...@digia.com
+
+[Qt] WebGL does not require accelerated compositing
+https://bugs.webkit.org/show_bug.cgi?id=106892
+
+Reviewed by Jocelyn Turcotte.
+
+Allow the creation of WebGL canvas even when accelerated compositing is not enabled.
+
+* html/HTMLCanvasElement.cpp:
+(WebCore::HTMLCanvasElement::getContext):
+
 2013-01-15  Andrey Lushnikov  lushni...@chromium.org
 
 Web Inspector: refactor DefaultTextEditor's paintLine method


Modified: trunk/Source/WebCore/html/HTMLCanvasElement.cpp (139741 => 139742)

--- trunk/Source/WebCore/html/HTMLCanvasElement.cpp	2013-01-15 15:57:41 UTC (rev 139741)
+++ trunk/Source/WebCore/html/HTMLCanvasElement.cpp	2013-01-15 16:01:56 UTC (rev 139742)
@@ -189,7 +189,7 @@
 #if ENABLE(WEBGL)
 Settings* settings = document()-settings();
 if (settings  settings-webGLEnabled()
-#if !PLATFORM(CHROMIUM)  !PLATFORM(GTK)  !PLATFORM(EFL)
+#if !PLATFORM(CHROMIUM)  !PLATFORM(GTK)  !PLATFORM(EFL)  !PLATFORM(QT)
  settings-acceleratedCompositingEnabled()
 #endif
 ) {






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [139743] trunk/Tools

[zandobersek]

Title: [139743] trunk/Tools








Revision 139743
Author zandober...@gmail.com
Date 2013-01-15 08:03:37 -0800 (Tue, 15 Jan 2013)


Log Message
[GTK] Waiting on the gdb process will lead to deadlock
https://bugs.webkit.org/show_bug.cgi?id=106906

Reviewed by Philippe Normand.

Use communicate() rather than wait() on the Popen object that's running the gdb
command. This avoids the deadlock that occurs on the GTK builders.

* Scripts/webkitpy/layout_tests/port/gtk.py:
(GtkPort._get_gdb_output):

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/layout_tests/port/gtk.py




Diff

Modified: trunk/Tools/ChangeLog (139742 => 139743)

--- trunk/Tools/ChangeLog	2013-01-15 16:01:56 UTC (rev 139742)
+++ trunk/Tools/ChangeLog	2013-01-15 16:03:37 UTC (rev 139743)
@@ -1,5 +1,18 @@
 2013-01-15  Zan Dobersek  zdober...@igalia.com
 
+[GTK] Waiting on the gdb process will lead to deadlock
+https://bugs.webkit.org/show_bug.cgi?id=106906
+
+Reviewed by Philippe Normand.
+
+Use communicate() rather than wait() on the Popen object that's running the gdb
+command. This avoids the deadlock that occurs on the GTK builders.
+
+* Scripts/webkitpy/layout_tests/port/gtk.py:
+(GtkPort._get_gdb_output):
+
+2013-01-15  Zan Dobersek  zdober...@igalia.com
+
 [GTK] Limit the number of frames printed out when backtracing with gdb
 https://bugs.webkit.org/show_bug.cgi?id=106901
 


Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/gtk.py (139742 => 139743)

--- trunk/Tools/Scripts/webkitpy/layout_tests/port/gtk.py	2013-01-15 16:01:56 UTC (rev 139742)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/port/gtk.py	2013-01-15 16:03:37 UTC (rev 139743)
@@ -127,10 +127,9 @@
 def _get_gdb_output(self, coredump_path):
 cmd = ['gdb', '-ex', 'thread apply all bt 1024', '--batch', str(self._path_to_driver()), coredump_path]
 proc = subprocess.Popen(cmd, stdin=None, stdout=subprocess.PIPE, stderr=subprocess.PIPE)
-proc.wait()
-errors = [l.strip().decode('utf8', 'ignore') for l in proc.stderr.readlines()]
-trace = proc.stdout.read().decode('utf8', 'ignore')
-return (trace, errors)
+stdout, stderr = proc.communicate()
+errors = [l.strip().decode('utf8', 'ignore') for l in stderr.splitlines()]
+return (stdout.decode('utf8', 'ignore'), errors)
 
 def _get_crash_log(self, name, pid, stdout, stderr, newer_than):
 pid_representation = str(pid or 'unknown')






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [139744] trunk/Tools

[victor]

Title: [139744] trunk/Tools








Revision 139744
Author vic...@rosedu.org
Date 2013-01-15 08:35:41 -0800 (Tue, 15 Jan 2013)


Log Message
Unreviewed. Update my email addresses.

* Scripts/webkitpy/common/config/committers.py:

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/common/config/committers.py




Diff

Modified: trunk/Tools/ChangeLog (139743 => 139744)

--- trunk/Tools/ChangeLog	2013-01-15 16:03:37 UTC (rev 139743)
+++ trunk/Tools/ChangeLog	2013-01-15 16:35:41 UTC (rev 139744)
@@ -1,3 +1,9 @@
+2013-01-15  Victor Carbune  vic...@rosedu.org
+
+Unreviewed. Update my email addresses.
+
+* Scripts/webkitpy/common/config/committers.py:
+
 2013-01-15  Zan Dobersek  zdober...@igalia.com
 
 [GTK] Waiting on the gdb process will lead to deadlock


Modified: trunk/Tools/Scripts/webkitpy/common/config/committers.py (139743 => 139744)

--- trunk/Tools/Scripts/webkitpy/common/config/committers.py	2013-01-15 16:03:37 UTC (rev 139743)
+++ trunk/Tools/Scripts/webkitpy/common/config/committers.py	2013-01-15 16:35:41 UTC (rev 139744)
@@ -417,7 +417,7 @@
 Committer(Tristan O'Tierney, [tris...@otierney.net, tris...@apple.com]),
 Committer(Vangelis Kokkevis, vange...@chromium.org, vangelis),
 Committer(Viatcheslav Ostapenko, [osta...@gmail.com, v.ostape...@samsung.com, v.ostape...@sisa.samsung.com], ostap),
-Committer(Victor Carbune, vic...@rosedu.org, vcarbune),
+Committer(Victor Carbune, [vcarb...@chromium.org, vic...@rosedu.org], vcarbune),
 Committer(Victor Wang, vict...@chromium.org, victorw),
 Committer(Victoria Kirst, [v...@chromium.org, v...@google.com], vrk),
 Committer(Vincent Scheib, sch...@chromium.org, scheib),






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [139745] trunk

[fmalita]

Title: [139745] trunk








Revision 139745
Author fmal...@chromium.org
Date 2013-01-15 08:57:55 -0800 (Tue, 15 Jan 2013)


Log Message
[Chromium] Incorrect opaque region tracking for PlatformContextSkia::drawRRect
https://bugs.webkit.org/show_bug.cgi?id=106898

Reviewed by Stephen White.

Source/WebCore:

Since drawRRect() doesn't cover the whole bounding rect, it needs to pass a didDrawBounded
notification down to the opaque region tracker (instead of didDrawRect as it currently
does).

Test: platform/chromium/compositing/rounded-corners.html

* platform/graphics/skia/PlatformContextSkia.h:
(WebCore::PlatformContextSkia::drawRRect):

Source/WebKit/chromium:

* tests/PlatformContextSkiaTest.cpp:
(WebCore::TEST):
(WebCore):

LayoutTests:

* platform/chromium-linux/platform/chromium/compositing/rounded-corners-expected.png: Added.
* platform/chromium-linux/platform/chromium/compositing/rounded-corners-expected.txt: Added.
* platform/chromium/TestExpectations:
* platform/chromium/compositing/rounded-corners.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/TestExpectations
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/skia/PlatformContextSkia.h
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/tests/PlatformContextSkiaTest.cpp


Added Paths

trunk/LayoutTests/platform/chromium/compositing/rounded-corners.html
trunk/LayoutTests/platform/chromium-linux/platform/chromium/compositing/rounded-corners-expected.png
trunk/LayoutTests/platform/chromium-linux/platform/chromium/compositing/rounded-corners-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (139744 => 139745)

--- trunk/LayoutTests/ChangeLog	2013-01-15 16:35:41 UTC (rev 139744)
+++ trunk/LayoutTests/ChangeLog	2013-01-15 16:57:55 UTC (rev 139745)
@@ -1,3 +1,15 @@
+2013-01-15  Florin Malita  fmal...@chromium.org
+
+[Chromium] Incorrect opaque region tracking for PlatformContextSkia::drawRRect
+https://bugs.webkit.org/show_bug.cgi?id=106898
+
+Reviewed by Stephen White.
+
+* platform/chromium-linux/platform/chromium/compositing/rounded-corners-expected.png: Added.
+* platform/chromium-linux/platform/chromium/compositing/rounded-corners-expected.txt: Added.
+* platform/chromium/TestExpectations:
+* platform/chromium/compositing/rounded-corners.html: Added.
+
 2013-01-15  Vsevolod Vlasov  vse...@chromium.org
 
 Unreviewed failing test skip.


Modified: trunk/LayoutTests/platform/chromium/TestExpectations (139744 => 139745)

--- trunk/LayoutTests/platform/chromium/TestExpectations	2013-01-15 16:35:41 UTC (rev 139744)
+++ trunk/LayoutTests/platform/chromium/TestExpectations	2013-01-15 16:57:55 UTC (rev 139745)
@@ -4210,6 +4210,9 @@
 webkit.org/b/104489 [ Win ] http/tests/w3c/webperf/submission/Intel/user-timing/test_user_timing_clearMarks.html [ Failure Pass ]
 webkit.org/b/104489 [ Win ] http/tests/w3c/webperf/submission/Intel/user-timing/test_user_timing_measure_associate_with_navigation_timing.html [ Failure Pass ]
 
+# Needs platform-specific results
+webkit.org/b/106898 platform/chromium/compositing/rounded-corners.html [ Pass Missing ]
+
 # Flaky since r136945
 webkit.org/b/94002 [ Win Mac Debug ] inspector/debugger/live-edit-breakpoints.html [ Failure Timeout ]
 webkit.org/b/94002 [ Mac Debug ] inspector/debugger/live-edit.html [ Crash Pass Timeout ]


Added: trunk/LayoutTests/platform/chromium/compositing/rounded-corners.html (0 => 139745)

--- trunk/LayoutTests/platform/chromium/compositing/rounded-corners.html	(rev 0)
+++ trunk/LayoutTests/platform/chromium/compositing/rounded-corners.html	2013-01-15 16:57:55 UTC (rev 139745)
@@ -0,0 +1,7 @@
+!DOCTYPE html
+html
+body
+!-- Test for https://bugs.webkit.org/show_bug.cgi?id=106898 --
+div style=width: 200px; height: 200px; background: green; border-radius: 25%; -webkit-transform: translateZ(0);/div
+/body
+/html


Added: trunk/LayoutTests/platform/chromium-linux/platform/chromium/compositing/rounded-corners-expected.png (0 => 139745)

--- trunk/LayoutTests/platform/chromium-linux/platform/chromium/compositing/rounded-corners-expected.png	(rev 0)
+++ trunk/LayoutTests/platform/chromium-linux/platform/chromium/compositing/rounded-corners-expected.png	2013-01-15 16:57:55 UTC (rev 139745)
@@ -0,0 +1,24 @@
+\x89PNG
+
+
+IHDR X')tEXtchecksumfb023a73ef30b97adb409d2d5d7b11ae7/ŋ\xAFIDATx\x9C\xEDݿ\x8Fw\xC7\xE1\xC9\xE9$\xB6\xF3P\xB1\x9D\x87n;\x9B\x8At\xBB\xA9\xAE\x8CS]\xB9\xA6J\xBA\xDD\xFC,e\xAA@w\xA90\xE5U1]\xAE\xC2t\xB9
+\xD3\xEDU\xE9\x86Ω\xB8\xC2
+\x8A\xFB˼=^\xCF#\x8A\x90H\xF8#\xE5+\xF1\xD2g\xBE;\xFE\xE2ݻw9\xDB\xF4\xDBF`
\x84	

[webkit-changes] [139747] trunk/Tools

[jsbell]

Title: [139747] trunk/Tools








Revision 139747
Author jsb...@chromium.org
Date 2013-01-15 09:24:04 -0800 (Tue, 15 Jan 2013)


Log Message
Unreviewed. Adding Michael Pruett as contributor.

* Scripts/webkitpy/common/config/committers.py:

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/common/config/committers.py




Diff

Modified: trunk/Tools/ChangeLog (139746 => 139747)

--- trunk/Tools/ChangeLog	2013-01-15 17:13:07 UTC (rev 139746)
+++ trunk/Tools/ChangeLog	2013-01-15 17:24:04 UTC (rev 139747)
@@ -1,3 +1,9 @@
+2013-01-15  Joshua Bell  jsb...@chromium.org
+
+Unreviewed. Adding Michael Pruett as contributor.
+
+* Scripts/webkitpy/common/config/committers.py:
+
 2013-01-15  Victor Carbune  vic...@rosedu.org
 
 Unreviewed. Update my email addresses.


Modified: trunk/Tools/Scripts/webkitpy/common/config/committers.py (139746 => 139747)

--- trunk/Tools/Scripts/webkitpy/common/config/committers.py	2013-01-15 17:13:07 UTC (rev 139746)
+++ trunk/Tools/Scripts/webkitpy/common/config/committers.py	2013-01-15 17:24:04 UTC (rev 139747)
@@ -151,6 +151,7 @@
 Contributor(Kulanthaivel Palanichamy, kulanthai...@codeaurora.org, kvel),
 Contributor(Kiran Muppala, cmupp...@apple.com, kiranm),
 Contributor(Koji Ishii, kojii...@gmail.com),
+Contributor(Michael Pruett, mich...@68k.org, mpruett),
 Contributor(Mihai Balan, miba...@adobe.com, miChou),
 Contributor(Mihai Maerean, mmaer...@adobe.com, mmaerean),
 Contributor(Min Qin, qin...@chromium.org),






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [139748] trunk/LayoutTests

[leviw]

Title: [139748] trunk/LayoutTests








Revision 139748
Author le...@chromium.org
Date 2013-01-15 09:50:55 -0800 (Tue, 15 Jan 2013)


Log Message
Unreviewed gardening. Marking the deferred version of
fast/images/zoomed-offset-size.html as slow.

* platform/chromium/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (139747 => 139748)

--- trunk/LayoutTests/ChangeLog	2013-01-15 17:24:04 UTC (rev 139747)
+++ trunk/LayoutTests/ChangeLog	2013-01-15 17:50:55 UTC (rev 139748)
@@ -1,3 +1,10 @@
+2013-01-15  Levi Weintraub  le...@chromium.org
+
+Unreviewed gardening. Marking the deferred version of
+fast/images/zoomed-offset-size.html as slow.
+
+* platform/chromium/TestExpectations:
+
 2013-01-15  Florin Malita  fmal...@chromium.org
 
 [Chromium] Incorrect opaque region tracking for PlatformContextSkia::drawRRect


Modified: trunk/LayoutTests/platform/chromium/TestExpectations (139747 => 139748)

--- trunk/LayoutTests/platform/chromium/TestExpectations	2013-01-15 17:24:04 UTC (rev 139747)
+++ trunk/LayoutTests/platform/chromium/TestExpectations	2013-01-15 17:50:55 UTC (rev 139748)
@@ -97,6 +97,7 @@
 webkit.org/b/106606 platform/chromium/virtual/gpu/fast/canvas/webgl/context-release-upon-reload.html [ Pass Slow ]
 webkit.org/b/106853 [ Debug ] media/track/track-css-cue-lifetime.html [ Pass Timeout ]
 webkit.org/b/106855 [ Debug ] fast/images/zoomed-offset-size.html [ Pass Slow ]
+webkit.org/b/106855 [ Debug ] platform/chromium/virtual/deferred/fast/images/zoomed-offset-size.html [ Pass Slow ]
 
 # These tests started being slow when we switched to DRT.
 webkit.org/b/90488 [ Debug ] inspector [ Pass Slow ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [139750] trunk/Source

[simon . fraser]

Title: [139750] trunk/Source








Revision 139750
Author simon.fra...@apple.com
Date 2013-01-15 10:10:28 -0800 (Tue, 15 Jan 2013)


Log Message
Allow tiled WKViews to have transparent backgrounds
https://bugs.webkit.org/show_bug.cgi?id=106400

Source/WebCore:

Reviewed by Anders Carlsson.

When WKViews were set to have transparent backgrounds, they still
obscured content behind the view, for several reasons.

First, when in tiled scrolling mode, WKView set the background
of its layer to opaque white. Fix by using the clearColor (effectively
removing the background color) if the view has a non-opaque background.

Second, RenderLayerBacking just looked at FrameViews's isTransparent()
when deciding to make TileCache tiles non-opaque, but it also needs to
consider FrameViews with a non-opaque base background color. The
same logic was necessary to avoid setting an opaque white background
color on the TileCache layer.

Finally, for views with non-opaque backgrounds, we don't want to display
linen, so RenderLayerCompositor::requiresOverhangAreasLayer() was changed
to return false in that case.

View transparency is not testable in layout tests.

* page/FrameView.cpp:
(WebCore::FrameView::hasOpaqueBackground):
* page/FrameView.h:
* rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::createPrimaryGraphicsLayer):
(WebCore::RenderLayerBacking::updateBackgroundColor):
* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::requiresOverhangAreasLayer):

Source/WebKit2:

Reviewed by Anders Carlsson.

When WKViews were set to have transparent backgrounds, they still
obscured content behind the view, for several reasons.

First, when in tiled scrolling mode, WKView set the background
of its layer to opaque white. Fix by using the clearColor (effectively
removing the background color) if the view has a non-opaque background.

Second, RenderLayerBacking just looked at FrameViews's isTransparent()
when deciding to make TileCache tiles non-opaque, but it also needs to
consider FrameViews with a non-opaque base background color. The
same logic was necessary to avoid setting an opaque white background
color on the TileCache layer.

Finally, for views with non-opaque backgrounds, we don't want to display
linen, so RenderLayerCompositor::requiresOverhangAreasLayer() was changed
to return false in that case.

* UIProcess/API/mac/WKView.mm:
(-[WKView updateLayer]):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/FrameView.cpp
trunk/Source/WebCore/page/FrameView.h
trunk/Source/WebCore/rendering/RenderLayerBacking.cpp
trunk/Source/WebCore/rendering/RenderLayerCompositor.cpp
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/mac/WKView.mm




Diff

Modified: trunk/Source/WebCore/ChangeLog (139749 => 139750)

--- trunk/Source/WebCore/ChangeLog	2013-01-15 17:54:22 UTC (rev 139749)
+++ trunk/Source/WebCore/ChangeLog	2013-01-15 18:10:28 UTC (rev 139750)
@@ -1,3 +1,38 @@
+2013-01-15  Simon Fraser  simon.fra...@apple.com
+
+Allow tiled WKViews to have transparent backgrounds
+https://bugs.webkit.org/show_bug.cgi?id=106400
+
+Reviewed by Anders Carlsson.
+
+When WKViews were set to have transparent backgrounds, they still
+obscured content behind the view, for several reasons.
+
+First, when in tiled scrolling mode, WKView set the background
+of its layer to opaque white. Fix by using the clearColor (effectively
+removing the background color) if the view has a non-opaque background.
+
+Second, RenderLayerBacking just looked at FrameViews's isTransparent()
+when deciding to make TileCache tiles non-opaque, but it also needs to
+consider FrameViews with a non-opaque base background color. The
+same logic was necessary to avoid setting an opaque white background
+color on the TileCache layer.
+
+Finally, for views with non-opaque backgrounds, we don't want to display
+linen, so RenderLayerCompositor::requiresOverhangAreasLayer() was changed
+to return false in that case.
+
+View transparency is not testable in layout tests.
+
+* page/FrameView.cpp:
+(WebCore::FrameView::hasOpaqueBackground):
+* page/FrameView.h:
+* rendering/RenderLayerBacking.cpp:
+(WebCore::RenderLayerBacking::createPrimaryGraphicsLayer):
+(WebCore::RenderLayerBacking::updateBackgroundColor):
+* rendering/RenderLayerCompositor.cpp:
+(WebCore::RenderLayerCompositor::requiresOverhangAreasLayer):
+
 2013-01-15  Ojan Vafai  o...@chromium.org
 
 RenderView does not need to override computePreferredLogicalWidth


Modified: trunk/Source/WebCore/page/FrameView.cpp (139749 => 139750)

--- trunk/Source/WebCore/page/FrameView.cpp	2013-01-15 17:54:22 UTC (rev 139749)
+++ trunk/Source/WebCore/page/FrameView.cpp	2013-01-15 18:10:28 UTC (rev 139750)
@@ -2325,6 +2325,11 @@
   

[webkit-changes] [139751] trunk/Source/WebCore

[antti]

Title: [139751] trunk/Source/WebCore








Revision 139751
Author an...@apple.com
Date 2013-01-15 10:11:30 -0800 (Tue, 15 Jan 2013)


Log Message
Move parent pointer from TreeShared to subclass
https://bugs.webkit.org/show_bug.cgi?id=106910

Reviewed by Darin Adler.

This simplifies both TreeShared and clients, and makes code dealing with parents more understandable in general.

* dom/Document.h:
(WebCore::Node::Node):
* dom/Node.cpp:
(WebCore::Node::reportMemoryUsage):
* dom/Node.h:

Add m_parentOrHostNode variable (matching the accessor names).

(Node):
(WebCore::Node::hasTreeSharedParent):
(WebCore::Node::parentNode):
(WebCore::Node::setParentOrHostNode):
(WebCore::Node::parentOrHostNode):
* platform/TreeShared.h:
(WebCore):
(WebCore::TreeShared::TreeShared):
(WebCore::TreeShared::deref):

Call subclass hasTreeSharedParent() to figure out if it is time to delete.

(TreeShared):

Remove parent pointer and accessors.
Remove ParentNodeType template parameter.
Remove now unnecessay reportMemoryUsage().

(WebCore::adopted):
* svg/SVGElementInstance.cpp:
(WebCore::SVGElementInstance::SVGElementInstance):
* svg/SVGElementInstance.h:

Add m_parentInstance variable.

(WebCore::SVGElementInstance::setParentOrHostNode):
(WebCore::SVGElementInstance::parentNode):
(SVGElementInstance):
(WebCore::SVGElementInstance::hasTreeSharedParent):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/Document.h
trunk/Source/WebCore/dom/Node.cpp
trunk/Source/WebCore/dom/Node.h
trunk/Source/WebCore/platform/TreeShared.h
trunk/Source/WebCore/svg/SVGElementInstance.cpp
trunk/Source/WebCore/svg/SVGElementInstance.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (139750 => 139751)

--- trunk/Source/WebCore/ChangeLog	2013-01-15 18:10:28 UTC (rev 139750)
+++ trunk/Source/WebCore/ChangeLog	2013-01-15 18:11:30 UTC (rev 139751)
@@ -1,3 +1,50 @@
+2013-01-15  Antti Koivisto  an...@apple.com
+
+Move parent pointer from TreeShared to subclass
+https://bugs.webkit.org/show_bug.cgi?id=106910
+
+Reviewed by Darin Adler.
+
+This simplifies both TreeShared and clients, and makes code dealing with parents more understandable in general.
+
+* dom/Document.h:
+(WebCore::Node::Node):
+* dom/Node.cpp:
+(WebCore::Node::reportMemoryUsage):
+* dom/Node.h:
+
+Add m_parentOrHostNode variable (matching the accessor names).
+
+(Node):
+(WebCore::Node::hasTreeSharedParent):
+(WebCore::Node::parentNode):
+(WebCore::Node::setParentOrHostNode):
+(WebCore::Node::parentOrHostNode):
+* platform/TreeShared.h:
+(WebCore):
+(WebCore::TreeShared::TreeShared):
+(WebCore::TreeShared::deref):
+
+Call subclass hasTreeSharedParent() to figure out if it is time to delete.
+
+(TreeShared):
+
+Remove parent pointer and accessors.
+Remove ParentNodeType template parameter.
+Remove now unnecessay reportMemoryUsage().
+
+(WebCore::adopted):
+* svg/SVGElementInstance.cpp:
+(WebCore::SVGElementInstance::SVGElementInstance):
+* svg/SVGElementInstance.h:
+
+Add m_parentInstance variable.
+
+(WebCore::SVGElementInstance::setParentOrHostNode):
+(WebCore::SVGElementInstance::parentNode):
+(SVGElementInstance):
+(WebCore::SVGElementInstance::hasTreeSharedParent):
+
 2013-01-15  Simon Fraser  simon.fra...@apple.com
 
 Allow tiled WKViews to have transparent backgrounds


Modified: trunk/Source/WebCore/dom/Document.h (139750 => 139751)

--- trunk/Source/WebCore/dom/Document.h	2013-01-15 18:10:28 UTC (rev 139750)
+++ trunk/Source/WebCore/dom/Document.h	2013-01-15 18:11:30 UTC (rev 139751)
@@ -1588,6 +1588,7 @@
 
 inline Node::Node(Document* document, ConstructionType type)
 : m_nodeFlags(type)
+, m_parentOrHostNode(0)
 , m_treeScope(document)
 , m_previous(0)
 , m_next(0)


Modified: trunk/Source/WebCore/dom/Node.cpp (139750 => 139751)

--- trunk/Source/WebCore/dom/Node.cpp	2013-01-15 18:10:28 UTC (rev 139750)
+++ trunk/Source/WebCore/dom/Node.cpp	2013-01-15 18:11:30 UTC (rev 139751)
@@ -2572,8 +2572,8 @@
 void Node::reportMemoryUsage(MemoryObjectInfo* memoryObjectInfo) const
 {
 MemoryClassInfo info(memoryObjectInfo, this, WebCoreMemoryTypes::DOM);
-TreeSharedNode, ContainerNode::reportMemoryUsage(memoryObjectInfo);
 ScriptWrappable::reportMemoryUsage(memoryObjectInfo);
+info.addMember(m_parentOrHostNode);
 info.addMember(m_treeScope);
 info.addMember(m_next);
 info.addMember(m_previous);


Modified: trunk/Source/WebCore/dom/Node.h (139750 => 139751)

--- trunk/Source/WebCore/dom/Node.h	2013-01-15 18:10:28 UTC (rev 139750)
+++ trunk/Source/WebCore/dom/Node.h	2013-01-15 18:11:30 UTC (rev 139751)
@@ -122,7 +122,7 @@
 RenderObject* m_renderer;
 };
 
-class Node : 

[webkit-changes] [139752] branches/chromium/1364/Source

[senorblanco]

Title: [139752] branches/chromium/1364/Source








Revision 139752
Author senorbla...@chromium.org
Date 2013-01-15 10:15:57 -0800 (Tue, 15 Jan 2013)


Log Message
Merge 139026
 Add a flag to control canvas antialiasing.
 https://bugs.webkit.org/show_bug.cgi?id=106255
 
 Reviewed by Darin Fisher.
 
 Source/WebCore:
 
 This flag is not exposed through TestRunner or DRT, so no testing is
 possible yet.
 
 * html/HTMLCanvasElement.cpp:
 (WebCore::HTMLCanvasElement::createImageBuffer):
 * page/Settings.in:
 
 Source/WebKit/chromium:
 
 * public/WebSettings.h:
 * src/WebSettingsImpl.cpp:
 (WebKit::WebSettingsImpl::setAntialiased2dCanvasEnabled):
 * src/WebSettingsImpl.h:
 

TBR=senorbla...@chromium.org

Modified Paths

branches/chromium/1364/Source/WebCore/html/HTMLCanvasElement.cpp
branches/chromium/1364/Source/WebCore/page/Settings.in
branches/chromium/1364/Source/WebKit/chromium/public/WebSettings.h
branches/chromium/1364/Source/WebKit/chromium/src/WebSettingsImpl.cpp
branches/chromium/1364/Source/WebKit/chromium/src/WebSettingsImpl.h




Diff

Modified: branches/chromium/1364/Source/WebCore/html/HTMLCanvasElement.cpp (139751 => 139752)

--- branches/chromium/1364/Source/WebCore/html/HTMLCanvasElement.cpp	2013-01-15 18:11:30 UTC (rev 139751)
+++ branches/chromium/1364/Source/WebCore/html/HTMLCanvasElement.cpp	2013-01-15 18:15:57 UTC (rev 139752)
@@ -570,6 +570,8 @@
 return;
 m_imageBuffer-context()-setShadowsIgnoreTransforms(true);
 m_imageBuffer-context()-setImageInterpolationQuality(DefaultInterpolationQuality);
+if (document()-settings()  !document()-settings()-antialiased2dCanvasEnabled())
+m_imageBuffer-context()-setShouldAntialias(false);
 m_imageBuffer-context()-setStrokeThickness(1);
 m_contextStateSaver = adoptPtr(new GraphicsContextStateSaver(*m_imageBuffer-context()));
 


Modified: branches/chromium/1364/Source/WebCore/page/Settings.in (139751 => 139752)

--- branches/chromium/1364/Source/WebCore/page/Settings.in	2013-01-15 18:11:30 UTC (rev 139751)
+++ branches/chromium/1364/Source/WebCore/page/Settings.in	2013-01-15 18:15:57 UTC (rev 139752)
@@ -101,6 +101,7 @@
 privilegedWebGLExtensionsEnabled initial=false
 accelerated2dCanvasEnabled initial=false
 deferred2dCanvasEnabled initial=false
+antialiased2dCanvasEnabled initial=true
 loadDeferringEnabled initial=true
 webAudioEnabled initial=false
 paginateDuringLayoutEnabled initial=false


Modified: branches/chromium/1364/Source/WebKit/chromium/public/WebSettings.h (139751 => 139752)

--- branches/chromium/1364/Source/WebKit/chromium/public/WebSettings.h	2013-01-15 18:11:30 UTC (rev 139751)
+++ branches/chromium/1364/Source/WebKit/chromium/public/WebSettings.h	2013-01-15 18:15:57 UTC (rev 139752)
@@ -74,6 +74,7 @@
 virtual void setAllowRunningOfInsecureContent(bool) = 0;
 virtual void setAllowScriptsToCloseWindows(bool) = 0;
 virtual void setAllowUniversalAccessFromFileURLs(bool) = 0;
+virtual void setAntialiased2dCanvasEnabled(bool) = 0;
 virtual void setApplyDeviceScaleFactorInCompositor(bool) = 0;
 virtual void setApplyPageScaleFactorInCompositor(bool) = 0;
 virtual void setAsynchronousSpellCheckingEnabled(bool) = 0;


Modified: branches/chromium/1364/Source/WebKit/chromium/src/WebSettingsImpl.cpp (139751 => 139752)

--- branches/chromium/1364/Source/WebKit/chromium/src/WebSettingsImpl.cpp	2013-01-15 18:11:30 UTC (rev 139751)
+++ branches/chromium/1364/Source/WebKit/chromium/src/WebSettingsImpl.cpp	2013-01-15 18:15:57 UTC (rev 139752)
@@ -503,6 +503,11 @@
 m_settings-setAccelerated2dCanvasEnabled(enabled);
 }
 
+void WebSettingsImpl::setAntialiased2dCanvasEnabled(bool enabled)
+{
+m_settings-setAntialiased2dCanvasEnabled(enabled);
+}
+
 void WebSettingsImpl::setDeferred2dCanvasEnabled(bool enabled)
 {
 m_settings-setDeferred2dCanvasEnabled(enabled);


Modified: branches/chromium/1364/Source/WebKit/chromium/src/WebSettingsImpl.h (139751 => 139752)

--- branches/chromium/1364/Source/WebKit/chromium/src/WebSettingsImpl.h	2013-01-15 18:11:30 UTC (rev 139751)
+++ branches/chromium/1364/Source/WebKit/chromium/src/WebSettingsImpl.h	2013-01-15 18:15:57 UTC (rev 139752)
@@ -66,6 +66,7 @@
 virtual void setAllowRunningOfInsecureContent(bool);
 virtual void setAllowScriptsToCloseWindows(bool);
 virtual void setAllowUniversalAccessFromFileURLs(bool);
+virtual void setAntialiased2dCanvasEnabled(bool);
 virtual void setApplyDeviceScaleFactorInCompositor(bool);
 virtual void setApplyPageScaleFactorInCompositor(bool);
 virtual void setAsynchronousSpellCheckingEnabled(bool);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [139753] trunk/LayoutTests

[eae]

Title: [139753] trunk/LayoutTests








Revision 139753
Author e...@chromium.org
Date 2013-01-15 10:22:11 -0800 (Tue, 15 Jan 2013)


Log Message
https://bugs.webkit.org/show_bug.cgi?id=106855
https://bugs.webkit.org/show_bug.cgi?id=106855

Reviewed by Levi Weintraub.

Speed up zoomed-offset-size.html test and remove SLOW modifier
from TestExpectations.

* fast/images/zoomed-offset-size-expected.txt:
* fast/images/zoomed-offset-size.html:
* platform/chromium/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/images/zoomed-offset-size-expected.txt
trunk/LayoutTests/fast/images/zoomed-offset-size.html
trunk/LayoutTests/platform/chromium/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (139752 => 139753)

--- trunk/LayoutTests/ChangeLog	2013-01-15 18:15:57 UTC (rev 139752)
+++ trunk/LayoutTests/ChangeLog	2013-01-15 18:22:11 UTC (rev 139753)
@@ -1,3 +1,17 @@
+2013-01-15  Emil A Eklund  e...@chromium.org
+
+https://bugs.webkit.org/show_bug.cgi?id=106855
+https://bugs.webkit.org/show_bug.cgi?id=106855
+
+Reviewed by Levi Weintraub.
+
+Speed up zoomed-offset-size.html test and remove SLOW modifier
+from TestExpectations.
+
+* fast/images/zoomed-offset-size-expected.txt:
+* fast/images/zoomed-offset-size.html:
+* platform/chromium/TestExpectations:
+
 2013-01-15  Levi Weintraub  le...@chromium.org
 
 Unreviewed gardening. Marking the deferred version of


Modified: trunk/LayoutTests/fast/images/zoomed-offset-size-expected.txt (139752 => 139753)

--- trunk/LayoutTests/fast/images/zoomed-offset-size-expected.txt	2013-01-15 18:15:57 UTC (rev 139752)
+++ trunk/LayoutTests/fast/images/zoomed-offset-size-expected.txt	2013-01-15 18:22:11 UTC (rev 139753)
@@ -1,1202 +1,94 @@
-PASS getSize(0.01).imageWidth is 250
-PASS getSize(0.01).imageHeight is 166
-PASS getSize(0.01).wrapWidth is 250
-PASS getSize(0.01).wrapHeight is 166
-PASS getSize(0.02).imageWidth is 250
-PASS getSize(0.02).imageHeight is 166
-PASS getSize(0.02).wrapWidth is 250
-PASS getSize(0.02).wrapHeight is 166
-PASS getSize(0.03).imageWidth is 250
-PASS getSize(0.03).imageHeight is 166
-PASS getSize(0.03).wrapWidth is 250
-PASS getSize(0.03).wrapHeight is 166
-PASS getSize(0.04).imageWidth is 250
-PASS getSize(0.04).imageHeight is 166
-PASS getSize(0.04).wrapWidth is 250
-PASS getSize(0.04).wrapHeight is 166
-PASS getSize(0.05).imageWidth is 250
-PASS getSize(0.05).imageHeight is 166
-PASS getSize(0.05).wrapWidth is 250
-PASS getSize(0.05).wrapHeight is 166
-PASS getSize(0.06).imageWidth is 250
-PASS getSize(0.06).imageHeight is 166
-PASS getSize(0.06).wrapWidth is 250
-PASS getSize(0.06).wrapHeight is 166
-PASS getSize(0.07).imageWidth is 250
-PASS getSize(0.07).imageHeight is 166
-PASS getSize(0.07).wrapWidth is 250
-PASS getSize(0.07).wrapHeight is 166
-PASS getSize(0.08).imageWidth is 250
-PASS getSize(0.08).imageHeight is 166
-PASS getSize(0.08).wrapWidth is 250
-PASS getSize(0.08).wrapHeight is 166
-PASS getSize(0.09).imageWidth is 250
-PASS getSize(0.09).imageHeight is 166
-PASS getSize(0.09).wrapWidth is 250
-PASS getSize(0.09).wrapHeight is 166
-PASS getSize(0.1).imageWidth is 250
-PASS getSize(0.1).imageHeight is 166
-PASS getSize(0.1).wrapWidth is 250
-PASS getSize(0.1).wrapHeight is 166
-PASS getSize(0.11).imageWidth is 250
-PASS getSize(0.11).imageHeight is 166
-PASS getSize(0.11).wrapWidth is 250
-PASS getSize(0.11).wrapHeight is 166
-PASS getSize(0.12).imageWidth is 250
-PASS getSize(0.12).imageHeight is 166
-PASS getSize(0.12).wrapWidth is 250
-PASS getSize(0.12).wrapHeight is 166
-PASS getSize(0.13).imageWidth is 250
-PASS getSize(0.13).imageHeight is 166
-PASS getSize(0.13).wrapWidth is 250
-PASS getSize(0.13).wrapHeight is 166
-PASS getSize(0.14).imageWidth is 250
-PASS getSize(0.14).imageHeight is 166
-PASS getSize(0.14).wrapWidth is 250
-PASS getSize(0.14).wrapHeight is 166
-PASS getSize(0.15).imageWidth is 250
-PASS getSize(0.15).imageHeight is 166
-PASS getSize(0.15).wrapWidth is 250
-PASS getSize(0.15).wrapHeight is 166
-PASS getSize(0.16).imageWidth is 250
-PASS getSize(0.16).imageHeight is 166
-PASS getSize(0.16).wrapWidth is 250
-PASS getSize(0.16).wrapHeight is 166
-PASS getSize(0.17).imageWidth is 250
-PASS getSize(0.17).imageHeight is 166
-PASS getSize(0.17).wrapWidth is 250
-PASS getSize(0.17).wrapHeight is 166
-PASS getSize(0.18).imageWidth is 250
-PASS getSize(0.18).imageHeight is 166
-PASS getSize(0.18).wrapWidth is 250
-PASS getSize(0.18).wrapHeight is 166
-PASS getSize(0.19).imageWidth is 250
-PASS getSize(0.19).imageHeight is 166
-PASS getSize(0.19).wrapWidth is 250
-PASS getSize(0.19).wrapHeight is 166
-PASS getSize(0.2).imageWidth is 250
-PASS getSize(0.2).imageHeight is 166
-PASS getSize(0.2).wrapWidth is 250
-PASS getSize(0.2).wrapHeight is 166
-PASS getSize(0.21).imageWidth is 250
-PASS getSize(0.21).imageHeight is 166
-PASS getSize(0.21).wrapWidth is 250
-PASS 

[webkit-changes] [139754] branches/chromium/1364/Source/WebCore

[wangxianzhu]

Title: [139754] branches/chromium/1364/Source/WebCore








Revision 139754
Author wangxian...@chromium.org
Date 2013-01-15 10:26:16 -0800 (Tue, 15 Jan 2013)


Log Message
Merge 139691
 Sometimes RenderLayer::updateNeedsCompositedScrolling is not called
 https://bugs.webkit.org/show_bug.cgi?id=106271
 
 Reviewed by Simon Fraser.
 
 Source/WebCore:
 
 1. If a layer has no out-of-flow descendant, m_hasOutOfFlowPositionedDescendant won't change and won't trigger updateNeedsCompositedScrolling in updateDescendantDependentFlags. Set m_hasOutOfFlowPositionedDescendantDirty to true and call updateNeedsCompositedScrolling when the dirty flag becomes false from true.
 2. When the content size changes causing change of scrollable status, updateNeedsCompositedScrolling should also be called.
 
 Test: compositing/overflow/dynamic-composited-scrolling-status.html
 
 * page/FrameView.cpp:
 (WebCore::FrameView::addScrollableArea): Returns whether the scrollable area has just been newly added.
 (WebCore::FrameView::removeScrollableArea): Returns whether the scrollable area has just been removed.
 * page/FrameView.h:
 (FrameView):
 * rendering/RenderLayer.cpp:
 (WebCore::RenderLayer::RenderLayer): Changed the initial value of m_hasOutOfFlowPositionedDescendantDirty to true to make sure m_hasOutOfFlowPositionedDescendant will be updated initially.
 (WebCore::RenderLayer::updateDescendantDependentFlags): Call updateNeedsCompositedScrolling when m_hasOutOfFlowPositionedDescendantDirty is true.
 (RenderLayer::updateScrollableAreaSet): Calls updateNeedsCompositedScrolling() when scrollable status changes.
 * rendering/RenderLayer.h:
 (RenderLayer):
 
 LayoutTests:
 
 * compositing/overflow/dynamic-composited-scrolling-status-expected.txt: Added.
 * compositing/overflow/dynamic-composited-scrolling-status.html: Added.
 

TBR=wangxian...@chromium.org

Modified Paths

branches/chromium/1364/Source/WebCore/page/FrameView.cpp
branches/chromium/1364/Source/WebCore/page/FrameView.h
branches/chromium/1364/Source/WebCore/rendering/RenderLayer.cpp
branches/chromium/1364/Source/WebCore/rendering/RenderLayer.h




Diff

Modified: branches/chromium/1364/Source/WebCore/page/FrameView.cpp (139753 => 139754)

--- branches/chromium/1364/Source/WebCore/page/FrameView.cpp	2013-01-15 18:22:11 UTC (rev 139753)
+++ branches/chromium/1364/Source/WebCore/page/FrameView.cpp	2013-01-15 18:26:16 UTC (rev 139754)
@@ -3722,18 +3722,24 @@
 return ts.release();
 }
 
-void FrameView::addScrollableArea(ScrollableArea* scrollableArea)
+bool FrameView::addScrollableArea(ScrollableArea* scrollableArea)
 {
 if (!m_scrollableAreas)
 m_scrollableAreas = adoptPtr(new ScrollableAreaSet);
-m_scrollableAreas-add(scrollableArea);
+return m_scrollableAreas-add(scrollableArea).isNewEntry;
 }
 
-void FrameView::removeScrollableArea(ScrollableArea* scrollableArea)
+bool FrameView::removeScrollableArea(ScrollableArea* scrollableArea)
 {
 if (!m_scrollableAreas)
-return;
-m_scrollableAreas-remove(scrollableArea);
+return false;
+
+ScrollableAreaSet::iterator it = m_scrollableAreas-find(scrollableArea);
+if (it == m_scrollableAreas-end())
+return false;
+
+m_scrollableAreas-remove(it);
+return true;
 }
 
 bool FrameView::containsScrollableArea(ScrollableArea* scrollableArea) const


Modified: branches/chromium/1364/Source/WebCore/page/FrameView.h (139753 => 139754)

--- branches/chromium/1364/Source/WebCore/page/FrameView.h	2013-01-15 18:22:11 UTC (rev 139753)
+++ branches/chromium/1364/Source/WebCore/page/FrameView.h	2013-01-15 18:26:16 UTC (rev 139754)
@@ -344,8 +344,10 @@
 String trackedRepaintRectsAsText() const;
 
 typedef HashSetScrollableArea* ScrollableAreaSet;
-void addScrollableArea(ScrollableArea*);
-void removeScrollableArea(ScrollableArea*);
+// Returns whether the scrollable area has just been newly added.
+bool addScrollableArea(ScrollableArea*);
+// Returns whether the scrollable area has just been removed.
+bool removeScrollableArea(ScrollableArea*);
 bool containsScrollableArea(ScrollableArea*) const;
 const ScrollableAreaSet* scrollableAreas() const { return m_scrollableAreas.get(); }
 


Modified: branches/chromium/1364/Source/WebCore/rendering/RenderLayer.cpp (139753 => 139754)

--- branches/chromium/1364/Source/WebCore/rendering/RenderLayer.cpp	2013-01-15 18:22:11 UTC (rev 139753)
+++ branches/chromium/1364/Source/WebCore/rendering/RenderLayer.cpp	2013-01-15 18:26:16 UTC (rev 139754)
@@ -148,7 +148,7 @@
 , m_hasSelfPaintingLayerDescendant(false)
 , m_hasSelfPaintingLayerDescendantDirty(false)
 , m_hasOutOfFlowPositionedDescendant(false)
-, m_hasOutOfFlowPositionedDescendantDirty(false)
+, m_hasOutOfFlowPositionedDescendantDirty(true)
 , m_needsCompositedScrolling(false)
 , m_descendantsAreContiguousInStackingOrder(false)
 , m_isRootLayer(renderer-isRenderView())
@@ -956,9 +956,6 @@
 void 

[webkit-changes] [139755] trunk/Source/WebCore

[commit-queue]

Title: [139755] trunk/Source/WebCore








Revision 139755
Author commit-qu...@webkit.org
Date 2013-01-15 10:34:07 -0800 (Tue, 15 Jan 2013)


Log Message
[GTK] Fix build after r139665
https://bugs.webkit.org/show_bug.cgi?id=106917

Patch by Michael Pruett mich...@68k.org on 2013-01-15
Reviewed by Dean Jackson.

* GNUmakefile.list.am:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/GNUmakefile.list.am




Diff

Modified: trunk/Source/WebCore/ChangeLog (139754 => 139755)

--- trunk/Source/WebCore/ChangeLog	2013-01-15 18:26:16 UTC (rev 139754)
+++ trunk/Source/WebCore/ChangeLog	2013-01-15 18:34:07 UTC (rev 139755)
@@ -1,3 +1,12 @@
+2013-01-15  Michael Pruett  mich...@68k.org
+
+[GTK] Fix build after r139665
+https://bugs.webkit.org/show_bug.cgi?id=106917
+
+Reviewed by Dean Jackson.
+
+* GNUmakefile.list.am:
+
 2013-01-15  Antti Koivisto  an...@apple.com
 
 Move parent pointer from TreeShared to subclass


Modified: trunk/Source/WebCore/GNUmakefile.list.am (139754 => 139755)

--- trunk/Source/WebCore/GNUmakefile.list.am	2013-01-15 18:26:16 UTC (rev 139754)
+++ trunk/Source/WebCore/GNUmakefile.list.am	2013-01-15 18:34:07 UTC (rev 139755)
@@ -6346,6 +6346,8 @@
 	Source/ThirdParty/ANGLE/src/compiler/ShHandle.h \
 	Source/ThirdParty/ANGLE/src/compiler/SymbolTable.cpp \
 	Source/ThirdParty/ANGLE/src/compiler/SymbolTable.h \
+	Source/ThirdParty/ANGLE/src/compiler/VariablePacker.cpp \
+	Source/ThirdParty/ANGLE/src/compiler/VariablePacker.h \
 	Source/ThirdParty/ANGLE/src/compiler/VersionGLSL.cpp \
 	Source/ThirdParty/ANGLE/src/compiler/VersionGLSL.h \
 	Source/ThirdParty/ANGLE/src/compiler/timing/RestrictFragmentShaderTiming.cpp \






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [139757] trunk/LayoutTests

[zandobersek]

Title: [139757] trunk/LayoutTests








Revision 139757
Author zandober...@gmail.com
Date 2013-01-15 10:54:27 -0800 (Tue, 15 Jan 2013)


Log Message
Unreviewed GTK gardening.

Adding failure/crash/missing expectations for accessibility tests after
r139444, r139534 and r139663.
Adding platform-specific baselines for two scrolling coordinator tests that are
required after r139686.

* platform/gtk/TestExpectations:
* platform/gtk/scrollingcoordinator: Added.
* platform/gtk/scrollingcoordinator/non-fast-scrollable-region-scaled-iframe-expected.txt: Added.
* platform/gtk/scrollingcoordinator/non-fast-scrollable-region-transformed-iframe-expected.txt: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/gtk/TestExpectations


Added Paths

trunk/LayoutTests/platform/gtk/scrollingcoordinator/
trunk/LayoutTests/platform/gtk/scrollingcoordinator/non-fast-scrollable-region-scaled-iframe-expected.txt
trunk/LayoutTests/platform/gtk/scrollingcoordinator/non-fast-scrollable-region-transformed-iframe-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (139756 => 139757)

--- trunk/LayoutTests/ChangeLog	2013-01-15 18:49:17 UTC (rev 139756)
+++ trunk/LayoutTests/ChangeLog	2013-01-15 18:54:27 UTC (rev 139757)
@@ -1,3 +1,17 @@
+2013-01-15  Zan Dobersek  zdober...@igalia.com
+
+Unreviewed GTK gardening.
+
+Adding failure/crash/missing expectations for accessibility tests after
+r139444, r139534 and r139663.
+Adding platform-specific baselines for two scrolling coordinator tests that are
+required after r139686.
+
+* platform/gtk/TestExpectations:
+* platform/gtk/scrollingcoordinator: Added.
+* platform/gtk/scrollingcoordinator/non-fast-scrollable-region-scaled-iframe-expected.txt: Added.
+* platform/gtk/scrollingcoordinator/non-fast-scrollable-region-transformed-iframe-expected.txt: Added.
+
 2013-01-15  Arko Saha  a...@motorola.com
 
 Microdata: propertiesCollection[name] should return undefined if item doesn't have a property named 'name'


Modified: trunk/LayoutTests/platform/gtk/TestExpectations (139756 => 139757)

--- trunk/LayoutTests/platform/gtk/TestExpectations	2013-01-15 18:49:17 UTC (rev 139756)
+++ trunk/LayoutTests/platform/gtk/TestExpectations	2013-01-15 18:54:27 UTC (rev 139757)
@@ -41,6 +41,7 @@
 # Tests that require new results.
 #
 
+webkit.org/b/106920 accessibility/color-well.html [ Missing ]
 webkit.org/b/84044 accessibility/image-link.html [ Missing ]
 webkit.org/b/84045 accessibility/image-map1.html [ Missing ]
 webkit.org/b/84045 accessibility/image-map2.html [ Missing ]
@@ -503,6 +504,10 @@
 
 webkit.org/b/105689 [ Debug ] plugins/npruntime/embed-property-iframe-equality.html [ Crash ]
 
+webkit.org/b/106922 accessibility/aria-tables.html [ Crash ]
+webkit.org/b/106922 accessibility/aria-hidden-with-elements.html [ Crash ]
+webkit.org/b/106922 platform/gtk/accessibility/aria-table-hierarchy.html [ Crash ]
+
 #
 # End of Crashing tests
 #
@@ -1372,6 +1377,8 @@
 
 webkit.org/b/106316 accessibility/render-counter-text.html [ Failure ]
 
+webkit.org/b/106924 accessibility/heading-level.html [ Failure ]
+
 #
 # End of Tests failing
 #


Added: trunk/LayoutTests/platform/gtk/scrollingcoordinator/non-fast-scrollable-region-scaled-iframe-expected.txt (0 => 139757)

--- trunk/LayoutTests/platform/gtk/scrollingcoordinator/non-fast-scrollable-region-scaled-iframe-expected.txt	(rev 0)
+++ trunk/LayoutTests/platform/gtk/scrollingcoordinator/non-fast-scrollable-region-scaled-iframe-expected.txt	2013-01-15 18:54:27 UTC (rev 139757)
@@ -0,0 +1,12 @@
+layer at (0,0) size 785x585
+  RenderView at (0,0) size 785x585
+layer at (0,0) size 785x8
+  RenderBlock {HTML} at (0,0) size 785x8
+RenderBody {BODY} at (8,8) size 769x0
+layer at (50,50) size 324x224
+  RenderPartObject {IFRAME} at (50,50) size 324x224 [border: (2px inset #00)]
+layer at (0,0) size 1008x1016
+  RenderView at (0,0) size 285x185
+layer at (0,0) size 285x1016
+  RenderBlock {HTML} at (0,0) size 285x1016
+RenderBody {BODY} at (8,8) size 1000x1000


Added: trunk/LayoutTests/platform/gtk/scrollingcoordinator/non-fast-scrollable-region-transformed-iframe-expected.txt (0 => 139757)

--- trunk/LayoutTests/platform/gtk/scrollingcoordinator/non-fast-scrollable-region-transformed-iframe-expected.txt	(rev 0)
+++ trunk/LayoutTests/platform/gtk/scrollingcoordinator/non-fast-scrollable-region-transformed-iframe-expected.txt	2013-01-15 

[webkit-changes] [139758] trunk/Source/ThirdParty/ANGLE

[ddkilzer]

Title: [139758] trunk/Source/ThirdParty/ANGLE








Revision 139758
Author ddkil...@apple.com
Date 2013-01-15 10:56:19 -0800 (Tue, 15 Jan 2013)


Log Message
ANGLE should build with -Wshorten-64-to-32
http://webkit.org/b/106798
http://code.google.com/p/angleproject/issues/detail?id=396

Reviewed by Kenneth Russell.

Most changes below are simply to document issues with #pragma
statements per request by upstream.  The change to osinclude.h
is the only bug fix, which defines OS_TLSIndex in terms of
pthread_key_t instead of unsigned int since pthread_key_t is a
64-bit value on 64-bit Mac OS X.

* Configurations/Base.xcconfig: Enable -Wshorten-64-to-32 by
setting GCC_WARN_64_TO_32_BIT_CONVERSION to YES.
* src/compiler/Intermediate.cpp:
(TIntermTraverser::hash): Add #pragmas for clang to ignore
-Wshorten-64-to-32 warning.
* src/compiler/MapLongVariableNames.cpp:
(LongNameMap::Size): Ditto.
* src/compiler/ShaderLang.cpp:
(getVariableInfo): Ditto.
(ShGetInfo): Ditto.
* src/compiler/ValidateLimitations.cpp:
(ValidateLimitations::validateFunctionCall): Ditto.
* src/compiler/glslang.l: Ditto.
* src/compiler/glslang_lex.cpp: Ditto.
* src/compiler/osinclude.h: Change type of OS_TLSIndex to
pthread_key_t.  Define OS_INVALID_TLS_INDEX by using
static_castOS_TLSIndex(-1).
* src/compiler/preprocessor/Input.cpp:
(pp::Input::Input): Add #pragmas for clang to ignore
-Wshorten-64-to-32 warning.
* src/compiler/preprocessor/Tokenizer.cpp: Ditto.
* src/compiler/preprocessor/Tokenizer.l: Ditto.

Modified Paths

trunk/Source/ThirdParty/ANGLE/ChangeLog
trunk/Source/ThirdParty/ANGLE/Configurations/Base.xcconfig
trunk/Source/ThirdParty/ANGLE/src/compiler/Intermediate.cpp
trunk/Source/ThirdParty/ANGLE/src/compiler/MapLongVariableNames.cpp
trunk/Source/ThirdParty/ANGLE/src/compiler/ShaderLang.cpp
trunk/Source/ThirdParty/ANGLE/src/compiler/ValidateLimitations.cpp
trunk/Source/ThirdParty/ANGLE/src/compiler/glslang.l
trunk/Source/ThirdParty/ANGLE/src/compiler/glslang_lex.cpp
trunk/Source/ThirdParty/ANGLE/src/compiler/osinclude.h
trunk/Source/ThirdParty/ANGLE/src/compiler/preprocessor/Input.cpp
trunk/Source/ThirdParty/ANGLE/src/compiler/preprocessor/Tokenizer.cpp
trunk/Source/ThirdParty/ANGLE/src/compiler/preprocessor/Tokenizer.l




Diff

Modified: trunk/Source/ThirdParty/ANGLE/ChangeLog (139757 => 139758)

--- trunk/Source/ThirdParty/ANGLE/ChangeLog	2013-01-15 18:54:27 UTC (rev 139757)
+++ trunk/Source/ThirdParty/ANGLE/ChangeLog	2013-01-15 18:56:19 UTC (rev 139758)
@@ -1,3 +1,40 @@
+2013-01-15  David Kilzer  ddkil...@apple.com
+
+ANGLE should build with -Wshorten-64-to-32
+http://webkit.org/b/106798
+http://code.google.com/p/angleproject/issues/detail?id=396
+
+Reviewed by Kenneth Russell.
+
+Most changes below are simply to document issues with #pragma
+statements per request by upstream.  The change to osinclude.h
+is the only bug fix, which defines OS_TLSIndex in terms of
+pthread_key_t instead of unsigned int since pthread_key_t is a
+64-bit value on 64-bit Mac OS X.
+
+* Configurations/Base.xcconfig: Enable -Wshorten-64-to-32 by
+setting GCC_WARN_64_TO_32_BIT_CONVERSION to YES.
+* src/compiler/Intermediate.cpp:
+(TIntermTraverser::hash): Add #pragmas for clang to ignore
+-Wshorten-64-to-32 warning.
+* src/compiler/MapLongVariableNames.cpp:
+(LongNameMap::Size): Ditto.
+* src/compiler/ShaderLang.cpp:
+(getVariableInfo): Ditto.
+(ShGetInfo): Ditto.
+* src/compiler/ValidateLimitations.cpp:
+(ValidateLimitations::validateFunctionCall): Ditto.
+* src/compiler/glslang.l: Ditto.
+* src/compiler/glslang_lex.cpp: Ditto.
+* src/compiler/osinclude.h: Change type of OS_TLSIndex to
+pthread_key_t.  Define OS_INVALID_TLS_INDEX by using
+static_castOS_TLSIndex(-1).
+* src/compiler/preprocessor/Input.cpp:
+(pp::Input::Input): Add #pragmas for clang to ignore
+-Wshorten-64-to-32 warning.
+* src/compiler/preprocessor/Tokenizer.cpp: Ditto.
+* src/compiler/preprocessor/Tokenizer.l: Ditto.
+
 2013-01-14  David Kilzer  ddkil...@apple.com
 
 Remove nonexistent file in ANGLE Xcode project


Modified: trunk/Source/ThirdParty/ANGLE/Configurations/Base.xcconfig (139757 => 139758)

--- trunk/Source/ThirdParty/ANGLE/Configurations/Base.xcconfig	2013-01-15 18:54:27 UTC (rev 139757)
+++ trunk/Source/ThirdParty/ANGLE/Configurations/Base.xcconfig	2013-01-15 18:56:19 UTC (rev 139758)
@@ -19,6 +19,7 @@
 GCC_THREADSAFE_STATICS = NO;
 GCC_TREAT_WARNINGS_AS_ERRORS = YES;
 GCC_VERSION = com.apple.compilers.llvm.clang.1_0;
+GCC_WARN_64_TO_32_BIT_CONVERSION = YES;
 GCC_WARN_ABOUT_DEPRECATED_FUNCTIONS = NO;
 GCC_WARN_ABOUT_MISSING_NEWLINE = YES;
 LINKER_DISPLAYS_MANGLED_NAMES = YES;


Modified: trunk/Source/ThirdParty/ANGLE/src/compiler/Intermediate.cpp (139757 => 139758)

--- 

[webkit-changes] [139759] trunk/Source/WebKit/blackberry

[zhajiang]

Title: [139759] trunk/Source/WebKit/blackberry








Revision 139759
Author zhaji...@rim.com
Date 2013-01-15 11:00:28 -0800 (Tue, 15 Jan 2013)


Log Message
[BlackBerry] Manual zoom propagates to next page load
https://bugs.webkit.org/show_bug.cgi?id=106914

Patch by Jacky Jiang zhaji...@rim.com.
Reviewed by Yong Li.
Internally reviewed by Eli Fidler and Jakob Petsovits.

PR: 280481
During load committed, the web page scale was reset. However, UI thread
still kept the old scale in UserInterfaceViewportAccessor so that it
blitted the contents at the old scale although WebKit thread could
update the UI thread scale later when finished the load.
We should update the scale of the UI thread right after we reset it in
WebKit thread to keep them in sync.

* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::resetScales):

Modified Paths

trunk/Source/WebKit/blackberry/Api/WebPage.cpp
trunk/Source/WebKit/blackberry/ChangeLog




Diff

Modified: trunk/Source/WebKit/blackberry/Api/WebPage.cpp (139758 => 139759)

--- trunk/Source/WebKit/blackberry/Api/WebPage.cpp	2013-01-15 18:56:19 UTC (rev 139758)
+++ trunk/Source/WebKit/blackberry/Api/WebPage.cpp	2013-01-15 19:00:28 UTC (rev 139759)
@@ -1779,6 +1779,7 @@
 m_initialScale = m_webSettings-initialScale()  0 ? m_webSettings-initialScale() : -1.0;
 m_minimumScale = -1.0;
 m_maximumScale = -1.0;
+m_client-scaleChanged();
 
 // We have to let WebCore know about updated framerect now that we've
 // reset our scales. See: RIM Bug #401.


Modified: trunk/Source/WebKit/blackberry/ChangeLog (139758 => 139759)

--- trunk/Source/WebKit/blackberry/ChangeLog	2013-01-15 18:56:19 UTC (rev 139758)
+++ trunk/Source/WebKit/blackberry/ChangeLog	2013-01-15 19:00:28 UTC (rev 139759)
@@ -1,3 +1,22 @@
+2013-01-15  Jacky Jiang  zhaji...@rim.com
+
+[BlackBerry] Manual zoom propagates to next page load
+https://bugs.webkit.org/show_bug.cgi?id=106914
+
+Reviewed by Yong Li.
+Internally reviewed by Eli Fidler and Jakob Petsovits.
+
+PR: 280481
+During load committed, the web page scale was reset. However, UI thread
+still kept the old scale in UserInterfaceViewportAccessor so that it
+blitted the contents at the old scale although WebKit thread could
+update the UI thread scale later when finished the load.
+We should update the scale of the UI thread right after we reset it in
+WebKit thread to keep them in sync.
+
+* Api/WebPage.cpp:
+(BlackBerry::WebKit::WebPagePrivate::resetScales):
+
 2013-01-14  Otto Derek Cheung  otche...@rim.com
 
 [BlackBerry] FCC appears when switching search engine providers






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [139760] trunk/Source/WebCore

[tonyg]

Title: [139760] trunk/Source/WebCore








Revision 139760
Author to...@chromium.org
Date 2013-01-15 11:06:25 -0800 (Tue, 15 Jan 2013)


Log Message
Make AtomicMarkupTokenBase use a bare UChar* for external characters
https://bugs.webkit.org/show_bug.cgi?id=106919

Reviewed by Eric Seidel.

This allows an arbitrary backing for external characters which is necessary for the threaded HTML parser.

No new tests because no new functionality.

* html/parser/HTMLTreeBuilder.cpp:
(WebCore::HTMLTreeBuilder::ExternalCharacterTokenBuffer::ExternalCharacterTokenBuffer):
(WebCore::HTMLTreeBuilder::processTokenInForeignContent):
* xml/parser/MarkupTokenBase.h:
(WebCore::AtomicMarkupTokenBase::AtomicMarkupTokenBase):
(WebCore::AtomicMarkupTokenBase::characters):
(AtomicMarkupTokenBase):
(WebCore::AtomicMarkupTokenBase::charactersLength):
(WebCore::AtomicMarkupTokenBase::clearExternalCharacters):
* xml/parser/XMLTreeBuilder.cpp:
(WebCore::XMLTreeBuilder::processCharacter):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/parser/HTMLTreeBuilder.cpp
trunk/Source/WebCore/xml/parser/MarkupTokenBase.h
trunk/Source/WebCore/xml/parser/XMLTreeBuilder.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (139759 => 139760)

--- trunk/Source/WebCore/ChangeLog	2013-01-15 19:00:28 UTC (rev 139759)
+++ trunk/Source/WebCore/ChangeLog	2013-01-15 19:06:25 UTC (rev 139760)
@@ -1,3 +1,26 @@
+2013-01-15  Tony Gentilcore  to...@chromium.org
+
+Make AtomicMarkupTokenBase use a bare UChar* for external characters
+https://bugs.webkit.org/show_bug.cgi?id=106919
+
+Reviewed by Eric Seidel.
+
+This allows an arbitrary backing for external characters which is necessary for the threaded HTML parser.
+
+No new tests because no new functionality.
+
+* html/parser/HTMLTreeBuilder.cpp:
+(WebCore::HTMLTreeBuilder::ExternalCharacterTokenBuffer::ExternalCharacterTokenBuffer):
+(WebCore::HTMLTreeBuilder::processTokenInForeignContent):
+* xml/parser/MarkupTokenBase.h:
+(WebCore::AtomicMarkupTokenBase::AtomicMarkupTokenBase):
+(WebCore::AtomicMarkupTokenBase::characters):
+(AtomicMarkupTokenBase):
+(WebCore::AtomicMarkupTokenBase::charactersLength):
+(WebCore::AtomicMarkupTokenBase::clearExternalCharacters):
+* xml/parser/XMLTreeBuilder.cpp:
+(WebCore::XMLTreeBuilder::processCharacter):
+
 2013-01-15  Arko Saha  a...@motorola.com
 
 Microdata: propertiesCollection[name] should return undefined if item doesn't have a property named 'name'


Modified: trunk/Source/WebCore/html/parser/HTMLTreeBuilder.cpp (139759 => 139760)

--- trunk/Source/WebCore/html/parser/HTMLTreeBuilder.cpp	2013-01-15 19:00:28 UTC (rev 139759)
+++ trunk/Source/WebCore/html/parser/HTMLTreeBuilder.cpp	2013-01-15 19:06:25 UTC (rev 139760)
@@ -149,8 +149,8 @@
 WTF_MAKE_NONCOPYABLE(ExternalCharacterTokenBuffer);
 public:
 explicit ExternalCharacterTokenBuffer(AtomicHTMLToken* token)
-: m_current(token-characters().data())
-, m_end(m_current + token-characters().size())
+: m_current(token-characters())
+, m_end(m_current + token-charactersLength())
 , m_isAll8BitData(token-isAll8BitData())
 {
 ASSERT(!isEmpty());
@@ -2854,7 +2854,7 @@
 m_tree.insertComment(token);
 return;
 case HTMLTokenTypes::Character: {
-String characters = String(token-characters().data(), token-characters().size());
+String characters = String(token-characters(), token-charactersLength());
 m_tree.insertTextNode(characters);
 if (m_framesetOk  !isAllWhitespaceOrReplacementCharacters(characters))
 m_framesetOk = false;


Modified: trunk/Source/WebCore/xml/parser/MarkupTokenBase.h (139759 => 139760)

--- trunk/Source/WebCore/xml/parser/MarkupTokenBase.h	2013-01-15 19:00:28 UTC (rev 139759)
+++ trunk/Source/WebCore/xml/parser/MarkupTokenBase.h	2013-01-15 19:06:25 UTC (rev 139760)
@@ -458,7 +458,8 @@
 m_data = String(token-comment().data(), token-comment().size());
 break;
 case Token::Type::Character:
-m_externalCharacters = token-characters();
+m_externalCharacters = token-characters().data();
+m_externalCharactersLength = token-characters().size();
 m_isAll8BitData = token-isAll8BitData();
 break;
 default:
@@ -470,6 +471,7 @@
 : m_type(type)
 , m_name(name)
 , m_externalCharacters(0)
+, m_externalCharactersLength(0)
 , m_isAll8BitData(false)
 , m_attributes(attributes)
 {
@@ -514,12 +516,18 @@
 return m_attributes;
 }
 
-const typename Token::DataVector characters() const
+const UChar* characters() const
 {
 ASSERT(m_type == Token::Type::Character);
-return *m_externalCharacters;
+return m_externalCharacters;
 }
 
+size_t 

[webkit-changes] [139761] trunk/Source/ThirdParty/ANGLE

[ddkilzer]

Title: [139761] trunk/Source/ThirdParty/ANGLE








Revision 139761
Author ddkil...@apple.com
Date 2013-01-15 11:17:09 -0800 (Tue, 15 Jan 2013)


Log Message
Upstream iOS changes for ANGLE project
http://webkit.org/b/106913

Reviewed by Joseph Pecoraro.

* ANGLE.xcodeproj/project.pbxproj:
- Use $(INSTALL_PATH_PREFIX) with CopyFiles build phase paths.
- Add iOS.xcconfig to project.
* Configurations/ANGLE.xcconfig:
- Use INSTALL_PATH_ACTUAL instead of INSTALL_PATH.  (See below.)
- Use $(INSTALL_PATH_PREFIX) with PUBLIC_HEADERS_FOLDER_PATH.
* Configurations/Base.xcconfig:
- Include iOS.xcconfig.
- Add per-platform values for GCC_ENABLE_OBJC_GC and
  GCC_MODEL_TUNING.
- Define INSTALL_PATH when building for macosx SDK.
* Configurations/iOS.xcconfig: Add.  Note that missing include
files are simply ignored without an error by Xcode.

Modified Paths

trunk/Source/ThirdParty/ANGLE/ANGLE.xcodeproj/project.pbxproj
trunk/Source/ThirdParty/ANGLE/ChangeLog
trunk/Source/ThirdParty/ANGLE/Configurations/ANGLE.xcconfig
trunk/Source/ThirdParty/ANGLE/Configurations/Base.xcconfig


Added Paths

trunk/Source/ThirdParty/ANGLE/Configurations/iOS.xcconfig




Diff

Modified: trunk/Source/ThirdParty/ANGLE/ANGLE.xcodeproj/project.pbxproj (139760 => 139761)

--- trunk/Source/ThirdParty/ANGLE/ANGLE.xcodeproj/project.pbxproj	2013-01-15 19:06:25 UTC (rev 139760)
+++ trunk/Source/ThirdParty/ANGLE/ANGLE.xcodeproj/project.pbxproj	2013-01-15 19:17:09 UTC (rev 139761)
@@ -114,7 +114,7 @@
 		312BDB0B15FECAB00097EBC7 /* CopyFiles */ = {
 			isa = PBXCopyFilesBuildPhase;
 			buildActionMask = 8;
-			dstPath = /usr/local/OpenSourceVersions;
+			dstPath = $(INSTALL_PATH_PREFIX)/usr/local/OpenSourceVersions;
 			dstSubfolderSpec = 0;
 			files = (
 312BDB0C15FECAC90097EBC7 /* ANGLE.plist in CopyFiles */,
@@ -124,7 +124,7 @@
 		312BDB0D15FECACE0097EBC7 /* CopyFiles */ = {
 			isa = PBXCopyFilesBuildPhase;
 			buildActionMask = 8;
-			dstPath = /usr/local/OpenSourceLicenses;
+			dstPath = $(INSTALL_PATH_PREFIX)/usr/local/OpenSourceLicenses;
 			dstSubfolderSpec = 0;
 			files = (
 312BDB0E15FECAE50097EBC7 /* ANGLE.txt in CopyFiles */,
@@ -138,6 +138,7 @@
 		312BDB0A15FECA3A0097EBC7 /* ANGLE.txt */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = text; path = ANGLE.txt; sourceTree = group; };
 		3158EA0C1630968D006BE5EE /* ArrayBoundsClamper.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = ArrayBoundsClamper.cpp; sourceTree = group; };
 		3158EA0D1630968D006BE5EE /* ArrayBoundsClamper.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = ArrayBoundsClamper.h; sourceTree = group; };
+		443A3E1512ECF6CC0004F9D7 /* iOS.xcconfig */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = text.xcconfig; path = iOS.xcconfig; sourceTree = group; };
 		49951C0214B7AAB30060E96E /* length_limits.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = length_limits.h; sourceTree = group; };
 		49951C0514B7AAD70060E96E /* BuiltInFunctionEmulator.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = BuiltInFunctionEmulator.cpp; sourceTree = group; };
 		49951C0614B7AAD80060E96E /* BuiltInFunctionEmulator.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = BuiltInFunctionEmulator.h; sourceTree = group; };
@@ -290,6 +291,7 @@
 5D7C59C51208C68B001C873E /* ANGLE.xcconfig */,
 5D7C59C61208C68B001C873E /* Base.xcconfig */,
 5D7C59C71208C68B001C873E /* DebugRelease.xcconfig */,
+443A3E1512ECF6CC0004F9D7 /* iOS.xcconfig */,
 			);
 			path = Configurations;
 			sourceTree = group;


Modified: trunk/Source/ThirdParty/ANGLE/ChangeLog (139760 => 139761)

--- trunk/Source/ThirdParty/ANGLE/ChangeLog	2013-01-15 19:06:25 UTC (rev 139760)
+++ trunk/Source/ThirdParty/ANGLE/ChangeLog	2013-01-15 19:17:09 UTC (rev 139761)
@@ -1,5 +1,26 @@
 2013-01-15  David Kilzer  ddkil...@apple.com
 
+Upstream iOS changes for ANGLE project
+http://webkit.org/b/106913
+
+Reviewed by Joseph Pecoraro.
+
+* ANGLE.xcodeproj/project.pbxproj:
+- Use $(INSTALL_PATH_PREFIX) with CopyFiles build phase paths.
+- Add iOS.xcconfig to project.
+* Configurations/ANGLE.xcconfig:
+- Use INSTALL_PATH_ACTUAL instead of INSTALL_PATH.  (See below.)
+- Use $(INSTALL_PATH_PREFIX) with PUBLIC_HEADERS_FOLDER_PATH.
+* Configurations/Base.xcconfig:
+- Include iOS.xcconfig.
+- Add per-platform values for GCC_ENABLE_OBJC_GC and
+  GCC_MODEL_TUNING.
+- Define INSTALL_PATH when building for macosx SDK.
+* Configurations/iOS.xcconfig: Add.  Note that missing include
+files are simply ignored without an error by Xcode.
+
+2013-01-15  David Kilzer  ddkil...@apple.com
+
 ANGLE should build with -Wshorten-64-to-32
 

[webkit-changes] [139763] trunk/LayoutTests

[zandobersek]

Title: [139763] trunk/LayoutTests








Revision 139763
Author zandober...@gmail.com
Date 2013-01-15 11:25:38 -0800 (Tue, 15 Jan 2013)


Log Message
Unreviewed GTK gardening.

Remove a few failure expectations for tests that now pass.

* platform/gtk/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/gtk/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (139762 => 139763)

--- trunk/LayoutTests/ChangeLog	2013-01-15 19:17:42 UTC (rev 139762)
+++ trunk/LayoutTests/ChangeLog	2013-01-15 19:25:38 UTC (rev 139763)
@@ -1,3 +1,11 @@
+2013-01-15  Zan Dobersek  zdober...@igalia.com
+
+Unreviewed GTK gardening.
+
+Remove a few failure expectations for tests that now pass.
+
+* platform/gtk/TestExpectations:
+
 2013-01-15  Alexis Menard  ale...@webkit.org
 
 Unprefixed transitionend event doesn't seem to be implemented, which breaks many sites


Modified: trunk/LayoutTests/platform/gtk/TestExpectations (139762 => 139763)

--- trunk/LayoutTests/platform/gtk/TestExpectations	2013-01-15 19:17:42 UTC (rev 139762)
+++ trunk/LayoutTests/platform/gtk/TestExpectations	2013-01-15 19:25:38 UTC (rev 139763)
@@ -1078,7 +1078,6 @@
 # Rounding color problems inside pixman
 webkit.org/b/49964 fast/canvas/canvas-fillPath-shadow.html [ Failure ]
 
-webkit.org/b/50740 editing/spelling/spellcheck-sequencenum.html [ Failure ]
 webkit.org/b/50740 editing/spelling/spellcheck-async-mutation.html [ Failure ]
 
 # DRT does not obey testRunner.addURLToRedirect()
@@ -1278,9 +1277,6 @@
 
 webkit.org/b/89663 editing/deleting/delete-3800834-fix.html [ Failure ]
 
-webkit.org/b/94952 [ Debug ] platform/gtk/scrollbars/overflow-scrollbar-horizontal-wheel-scroll.html [ Failure ]
-webkit.org/b/94952 [ Debug ] scrollbars/scroll-rtl-or-bt-layer.html [ Failure ]
-
 webkit.org/b/87355 canvas/philip/tests/2d.text.draw.fontface.notinpage.html [ Failure ]
 
 webkit.org/b/95428 media/video-controls-captions.html [ Failure ]
@@ -1372,9 +1368,6 @@
 webkit.org/b/106015 fast/css-generated-content/pseudo-animation.html [ Failure ]
 webkit.org/b/106015 fast/css-generated-content/pseudo-transition.html [ Failure ]
 
-# Added only temporarily, until a clean build is performed on the builders.
-Bug(GTK) transitions/transitions-parsing.html [ Failure ]
-
 webkit.org/b/106316 accessibility/render-counter-text.html [ Failure ]
 
 webkit.org/b/106924 accessibility/heading-level.html [ Failure ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [139764] trunk/Tools

[tony]

Title: [139764] trunk/Tools








Revision 139764
Author t...@chromium.org
Date 2013-01-15 11:35:07 -0800 (Tue, 15 Jan 2013)


Log Message
[chromium] Unreviewed, fix a bug where we don't properly shutdown lighttpd.

* Scripts/webkitpy/layout_tests/servers/http_server.py:
(Lighttpd._check_and_kill): Pass /pid so taskkill.exe doesn't error out on us.
* Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
(TestHttpServer.test_win32_start_and_stop):

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/layout_tests/servers/http_server.py
trunk/Tools/Scripts/webkitpy/layout_tests/servers/http_server_unittest.py




Diff

Modified: trunk/Tools/ChangeLog (139763 => 139764)

--- trunk/Tools/ChangeLog	2013-01-15 19:25:38 UTC (rev 139763)
+++ trunk/Tools/ChangeLog	2013-01-15 19:35:07 UTC (rev 139764)
@@ -1,3 +1,12 @@
+2013-01-15  Tony Chang  t...@chromium.org
+
+[chromium] Unreviewed, fix a bug where we don't properly shutdown lighttpd.
+
+* Scripts/webkitpy/layout_tests/servers/http_server.py:
+(Lighttpd._check_and_kill): Pass /pid so taskkill.exe doesn't error out on us.
+* Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
+(TestHttpServer.test_win32_start_and_stop):
+
 2013-01-15  Joshua Bell  jsb...@chromium.org
 
 Unreviewed. Adding Michael Pruett as contributor.


Modified: trunk/Tools/Scripts/webkitpy/layout_tests/servers/http_server.py (139763 => 139764)

--- trunk/Tools/Scripts/webkitpy/layout_tests/servers/http_server.py	2013-01-15 19:25:38 UTC (rev 139763)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/servers/http_server.py	2013-01-15 19:35:07 UTC (rev 139764)
@@ -221,7 +221,7 @@
 # parent, so we can't use executive.kill_process().
 #
 # If this is actually working, we should figure out a clean API.
-self._executive.run_command([taskkill.exe, /f, /t, self._pid], error_handler=self._executive.ignore_error)
+self._executive.run_command([taskkill.exe, /f, /t, /pid, self._pid], error_handler=self._executive.ignore_error)
 else:
 self._executive.kill_process(self._pid)
 return False


Modified: trunk/Tools/Scripts/webkitpy/layout_tests/servers/http_server_unittest.py (139763 => 139764)

--- trunk/Tools/Scripts/webkitpy/layout_tests/servers/http_server_unittest.py	2013-01-15 19:25:38 UTC (rev 139763)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/servers/http_server_unittest.py	2013-01-15 19:35:07 UTC (rev 139764)
@@ -97,4 +97,4 @@
 server._wait_for_action = wait_for_action
 
 server.stop()
-self.assertEquals(['taskkill.exe', '/f', '/t', 42], host.executive.calls[1])
+self.assertEquals(['taskkill.exe', '/f', '/t', '/pid', 42], host.executive.calls[1])






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [139765] trunk/Source/JavaScriptCore

[zandobersek]

Title: [139765] trunk/Source/_javascript_Core








Revision 139765
Author zandober...@gmail.com
Date 2013-01-15 11:41:02 -0800 (Tue, 15 Jan 2013)


Log Message
[Autotools] Unify _javascript_Core sources list, regardless of target OS
https://bugs.webkit.org/show_bug.cgi?id=106007

Patch by Zan Dobersek zandober...@gmail.com on 2013-01-15
Reviewed by Gustavo Noronha Silva.

Include the Source/_javascript_Core/jit/ExecutableAllocatorFixedVMPool.cpp target
in the general sources list as it is guarded by the ENABLE_EXECUTABLE_ALLOCATOR_FIXED
feature define. This define is only used on 64-bit architecture and indirectly depends
on enabling either JIT or YARR JIT feature. Both of these defines are disabled on
Windows OS when using 64-bit architecture so there's no need to add this target to
sources only when the target OS is Windows.

* GNUmakefile.list.am:

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/GNUmakefile.list.am




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (139764 => 139765)

--- trunk/Source/_javascript_Core/ChangeLog	2013-01-15 19:35:07 UTC (rev 139764)
+++ trunk/Source/_javascript_Core/ChangeLog	2013-01-15 19:41:02 UTC (rev 139765)
@@ -1,3 +1,19 @@
+2013-01-15  Zan Dobersek  zandober...@gmail.com
+
+[Autotools] Unify _javascript_Core sources list, regardless of target OS
+https://bugs.webkit.org/show_bug.cgi?id=106007
+
+Reviewed by Gustavo Noronha Silva.
+
+Include the Source/_javascript_Core/jit/ExecutableAllocatorFixedVMPool.cpp target
+in the general sources list as it is guarded by the ENABLE_EXECUTABLE_ALLOCATOR_FIXED
+feature define. This define is only used on 64-bit architecture and indirectly depends
+on enabling either JIT or YARR JIT feature. Both of these defines are disabled on
+Windows OS when using 64-bit architecture so there's no need to add this target to
+sources only when the target OS is Windows.
+
+* GNUmakefile.list.am:
+
 2013-01-11  Filip Pizlo  fpi...@apple.com
 
 DFG should not forget that it had proved something to be a constant during a merge just because it's merging against the empty value


Modified: trunk/Source/_javascript_Core/GNUmakefile.list.am (139764 => 139765)

--- trunk/Source/_javascript_Core/GNUmakefile.list.am	2013-01-15 19:35:07 UTC (rev 139764)
+++ trunk/Source/_javascript_Core/GNUmakefile.list.am	2013-01-15 19:41:02 UTC (rev 139765)
@@ -405,6 +405,7 @@
 	Source/_javascript_Core/jit/ClosureCallStubRoutine.h \
 	Source/_javascript_Core/jit/ExecutableAllocator.cpp \
 	Source/_javascript_Core/jit/ExecutableAllocator.h \
+	Source/_javascript_Core/jit/ExecutableAllocatorFixedVMPool.cpp \
 	Source/_javascript_Core/jit/GCAwareJITStubRoutine.cpp \
 	Source/_javascript_Core/jit/GCAwareJITStubRoutine.h \
 	Source/_javascript_Core/jit/HostCallReturnValue.cpp \
@@ -765,12 +766,6 @@
 	Source/_javascript_Core/yarr/YarrSyntaxChecker.cpp \
 	Source/_javascript_Core/yarr/YarrSyntaxChecker.h
 
-if TARGET_WIN32
-else
-_javascript_core_sources += \
-	Source/_javascript_Core/jit/ExecutableAllocatorFixedVMPool.cpp
-endif
-
 llint_nosources += \
 	Source/_javascript_Core/llint/LowLevelInterpreter32_64.asm \
 	Source/_javascript_Core/llint/LowLevelInterpreter64.asm \






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [139766] trunk/Tools

[zandobersek]

Title: [139766] trunk/Tools








Revision 139766
Author zandober...@gmail.com
Date 2013-01-15 11:42:41 -0800 (Tue, 15 Jan 2013)


Log Message
[GTK] Stop passing the unstable features flag to configure script when using build-webkit
https://bugs.webkit.org/show_bug.cgi?id=106579

Patch by Zan Dobersek zandober...@gmail.com on 2013-01-15
Reviewed by Gustavo Noronha Silva.

The --enable-unstable-features flag is not required to be passed anymore
to the configure script as it was removed in r138252.

* Scripts/webkitdirs.pm:
(buildAutotoolsProject):

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitdirs.pm




Diff

Modified: trunk/Tools/ChangeLog (139765 => 139766)

--- trunk/Tools/ChangeLog	2013-01-15 19:41:02 UTC (rev 139765)
+++ trunk/Tools/ChangeLog	2013-01-15 19:42:41 UTC (rev 139766)
@@ -1,3 +1,16 @@
+2013-01-15  Zan Dobersek  zandober...@gmail.com
+
+[GTK] Stop passing the unstable features flag to configure script when using build-webkit
+https://bugs.webkit.org/show_bug.cgi?id=106579
+
+Reviewed by Gustavo Noronha Silva.
+
+The --enable-unstable-features flag is not required to be passed anymore
+to the configure script as it was removed in r138252.
+
+* Scripts/webkitdirs.pm:
+(buildAutotoolsProject):
+
 2013-01-15  Tony Chang  t...@chromium.org
 
 [chromium] Unreviewed, fix a bug where we don't properly shutdown lighttpd.


Modified: trunk/Tools/Scripts/webkitdirs.pm (139765 => 139766)

--- trunk/Tools/Scripts/webkitdirs.pm	2013-01-15 19:41:02 UTC (rev 139765)
+++ trunk/Tools/Scripts/webkitdirs.pm	2013-01-15 19:42:41 UTC (rev 139766)
@@ -2079,9 +2079,6 @@
 push @buildArgs, --disable-debug;
 }
 
-# Enable unstable features when building through build-webkit.
-push @buildArgs, --enable-unstable-features;
-
 if (checkForArgumentAndRemoveFromArrayRef(--update-gtk, \@buildArgs)) {
 # Force autogen to run, to catch the possibly updated libraries.
 system(rm -f previous-autogen-arguments.txt);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [139768] trunk

[zandobersek]

Title: [139768] trunk








Revision 139768
Author zandober...@gmail.com
Date 2013-01-15 11:47:31 -0800 (Tue, 15 Jan 2013)


Log Message
[GTK] Enable Performance Timeline, Resource Timing, Navigation Timing features
https://bugs.webkit.org/show_bug.cgi?id=106197

Patch by Zan Dobersek zandober...@gmail.com on 2013-01-15
Reviewed by Martin Robinson.

Source/WebCore: 

No new tests - existing layout tests are being unskipped, only a few fail
(but their failures are of cross-platform nature).

* GNUmakefile.features.am.in: Add feature defines for all three features.
They are disabled by default for now.
* GNUmakefile.list.am: Add missing build targets.
* bindings/gobject/GNUmakefile.am: Ditto.
* bindings/js/JSPerformanceEntryCustom.cpp: Added the necessary custom bindings.
Mimics the custom V8 bindings.
(WebCore):
(WebCore::toJS):

Tools: 

* Scripts/webkitperl/FeatureList.pm: Add the configuration options for all three
features. Enable them on GTK, meaning they will be enabled in development builds
(i.e. when building with build-webkit).

LayoutTests: 

Unskip related tests, add a few expectations for still-failing tests.

* platform/gtk/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/gtk/TestExpectations
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/GNUmakefile.features.am.in
trunk/Source/WebCore/GNUmakefile.list.am
trunk/Source/WebCore/bindings/gobject/GNUmakefile.am
trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitperl/FeatureList.pm


Added Paths

trunk/Source/WebCore/bindings/js/JSPerformanceEntryCustom.cpp




Diff

Modified: trunk/LayoutTests/ChangeLog (139767 => 139768)

--- trunk/LayoutTests/ChangeLog	2013-01-15 19:46:01 UTC (rev 139767)
+++ trunk/LayoutTests/ChangeLog	2013-01-15 19:47:31 UTC (rev 139768)
@@ -1,5 +1,16 @@
 2013-01-15  Zan Dobersek  zandober...@gmail.com
 
+[GTK] Enable Performance Timeline, Resource Timing, Navigation Timing features
+https://bugs.webkit.org/show_bug.cgi?id=106197
+
+Reviewed by Martin Robinson.
+
+Unskip related tests, add a few expectations for still-failing tests.
+
+* platform/gtk/TestExpectations:
+
+2013-01-15  Zan Dobersek  zandober...@gmail.com
+
 [GTK] Enable CSS Image Resolution feature
 https://bugs.webkit.org/show_bug.cgi?id=99038
 


Modified: trunk/LayoutTests/platform/gtk/TestExpectations (139767 => 139768)

--- trunk/LayoutTests/platform/gtk/TestExpectations	2013-01-15 19:46:01 UTC (rev 139767)
+++ trunk/LayoutTests/platform/gtk/TestExpectations	2013-01-15 19:47:31 UTC (rev 139768)
@@ -417,13 +417,6 @@
 # Requires HighDPI canvas support
 webkit.org/b/102180 fast/canvas/canvas-resize-reset-pixelRatio.html [ Failure ]
 
-# Fails until we enable the User Timing API.
-webkit.org/b/84893 http/tests/w3c/webperf/submission/Intel/user-timing [ Skip ]
-
-# Fails until we enable the Resource Timing API.
-webkit.org/b/61138 http/tests/w3c/webperf/submission/Intel/resource-timing [ Skip ]
-webkit.org/b/61138 http/tests/w3c/webperf/submission/resource-timing [ Skip ]
-
 # Opera-submitted tests to W3C for track, a lot of failures still.
 webkit.org/b/103926 media/track/opera/idl/media-idl-tests.html [ Skip ]
 webkit.org/b/103926 media/track/opera/interfaces/HTMLElement/HTMLMediaElement/crossOrigin.html [ Skip ]
@@ -1369,6 +1362,13 @@
 
 webkit.org/b/106924 accessibility/heading-level.html [ Failure ]
 
+webkit.org/b/103927 http/tests/w3c/webperf/submission/Intel/resource-timing/test_resource_timing_cross_origin_resource_request.html [ Failure ]
+webkit.org/b/103927 http/tests/w3c/webperf/submission/Intel/resource-timing/test_resource_timing_timing_allow_cross_origin_resource_request.html [ Failure ]
+webkit.org/b/103927 http/tests/w3c/webperf/submission/resource-timing/html/test_resource_dynamic_insertion.html [ Failure ]
+webkit.org/b/103927 http/tests/w3c/webperf/submission/resource-timing/html/test_resource_frame_initiator_type.html [ Failure ]
+webkit.org/b/103927 http/tests/w3c/webperf/submission/resource-timing/html/test_resource_initiator_types.html [ Failure ]
+webkit.org/b/103927 http/tests/w3c/webperf/submission/resource-timing/html/test_resource_redirects.html [ Failure ]
+
 #
 # End of Tests failing
 #


Modified: trunk/Source/WebCore/ChangeLog (139767 => 139768)

--- trunk/Source/WebCore/ChangeLog	2013-01-15 19:46:01 UTC (rev 139767)
+++ trunk/Source/WebCore/ChangeLog	2013-01-15 19:47:31 UTC (rev 139768)
@@ -1,3 +1,22 @@
+2013-01-15  Zan Dobersek  zandober...@gmail.com
+
+[GTK] Enable Performance Timeline, Resource Timing, Navigation Timing features
+https://bugs.webkit.org/show_bug.cgi?id=106197
+
+Reviewed by Martin Robinson.
+
+No new tests - existing layout tests are being unskipped, only a few fail
+(but their failures are of 

[webkit-changes] [139769] trunk

[zandobersek]

Title: [139769] trunk








Revision 139769
Author zandober...@gmail.com
Date 2013-01-15 11:49:50 -0800 (Tue, 15 Jan 2013)


Log Message
[Autotools] Add support for WebKit2-only builds
https://bugs.webkit.org/show_bug.cgi?id=106889

Patch by Zan Dobersek zandober...@gmail.com on 2013-01-15
Reviewed by Gustavo Noronha Silva.

.: 

* GNUmakefile.am: Only copy the WebKit1 documentation into the destination
directory if building WebKit1.
* configure.ac: Add a configuration option for disabling the WebKit1 build.
Only conditionally copy WebKit1-specific targets from the input files. Some
small style changes to the WebKit2 configuration flag included as well.

Source/WebKit/gtk: 

* GNUmakefile.am: Only build the WebKit1-specific targets if actually
building WebKit1. This puts the libwebkitgtk library, the pkg-config file
and the WebKit1-specific unit tests under the ENABLE_WEBKIT1 Automake
conditional.

Tools: 

* GNUmakefile.am: Only build the GtkLauncher and DumpRenderTree if building WebKit1.
* Scripts/build-webkit: Pass along the information on whether to build WebKit1 when
building the GTK port through build-webkit.
* Scripts/webkitdirs.pm:
(buildAutotoolsProject): Add the --disable-webkit1 configuration flag to the build
arguments when not building WebKit1.
(buildGtkProject): Pass along the information on whether to build WebKit1 when building
through the Autotools build system.

Modified Paths

trunk/ChangeLog
trunk/GNUmakefile.am
trunk/Source/WebKit/gtk/ChangeLog
trunk/Source/WebKit/gtk/GNUmakefile.am
trunk/Tools/ChangeLog
trunk/Tools/GNUmakefile.am
trunk/Tools/Scripts/build-webkit
trunk/Tools/Scripts/webkitdirs.pm
trunk/configure.ac




Diff

Modified: trunk/ChangeLog (139768 => 139769)

--- trunk/ChangeLog	2013-01-15 19:47:31 UTC (rev 139768)
+++ trunk/ChangeLog	2013-01-15 19:49:50 UTC (rev 139769)
@@ -1,3 +1,16 @@
+2013-01-15  Zan Dobersek  zandober...@gmail.com
+
+[Autotools] Add support for WebKit2-only builds
+https://bugs.webkit.org/show_bug.cgi?id=106889
+
+Reviewed by Gustavo Noronha Silva.
+
+* GNUmakefile.am: Only copy the WebKit1 documentation into the destination
+directory if building WebKit1.
+* configure.ac: Add a configuration option for disabling the WebKit1 build.
+Only conditionally copy WebKit1-specific targets from the input files. Some
+small style changes to the WebKit2 configuration flag included as well.
+
 2013-01-14  Nate Chapin  jap...@chromium.org
 
 Enable reuse of cached main resources


Modified: trunk/GNUmakefile.am (139768 => 139769)

--- trunk/GNUmakefile.am	2013-01-15 19:47:31 UTC (rev 139768)
+++ trunk/GNUmakefile.am	2013-01-15 19:49:50 UTC (rev 139769)
@@ -356,10 +356,12 @@
 dist-hook: doc-dist-hook
 doc-dist-hook: docs-build.stamp
 	cp $(WebKit)/NEWS $(distdir)
+if ENABLE_WEBKIT1
 	@mkdir -p $(distdir)/Documentation/webkitgtk/html
 	@mkdir -p $(distdir)/Documentation/webkitgtk/tmpl
 	@-cp ./Documentation/webkitgtk/tmpl/*.sgml $(distdir)/Documentation/webkitgtk/tmpl
 	@cp ./Documentation/webkitgtk/html/* $(distdir)/Documentation/webkitgtk/html
+endif
 if ENABLE_WEBKIT2
 	@mkdir -p $(distdir)/Documentation/webkit2gtk/html
 	@mkdir -p $(distdir)/Documentation/webkit2gtk/tmpl


Modified: trunk/Source/WebKit/gtk/ChangeLog (139768 => 139769)

--- trunk/Source/WebKit/gtk/ChangeLog	2013-01-15 19:47:31 UTC (rev 139768)
+++ trunk/Source/WebKit/gtk/ChangeLog	2013-01-15 19:49:50 UTC (rev 139769)
@@ -1,3 +1,15 @@
+2013-01-15  Zan Dobersek  zandober...@gmail.com
+
+[Autotools] Add support for WebKit2-only builds
+https://bugs.webkit.org/show_bug.cgi?id=106889
+
+Reviewed by Gustavo Noronha Silva.
+
+* GNUmakefile.am: Only build the WebKit1-specific targets if actually
+building WebKit1. This puts the libwebkitgtk library, the pkg-config file
+and the WebKit1-specific unit tests under the ENABLE_WEBKIT1 Automake
+conditional.
+
 2013-01-11  Carlos Garcia Campos  cgar...@igalia.com
 
 Unreviewed. Update NEWS and configure.ac for 1.11.4 release


Modified: trunk/Source/WebKit/gtk/GNUmakefile.am (139768 => 139769)

--- trunk/Source/WebKit/gtk/GNUmakefile.am	2013-01-15 19:47:31 UTC (rev 139768)
+++ trunk/Source/WebKit/gtk/GNUmakefile.am	2013-01-15 19:49:50 UTC (rev 139769)
@@ -1,5 +1,7 @@
+if ENABLE_WEBKIT1
 lib_LTLIBRARIES += \
 	libwebkitgtk-@WEBKITGTK_API_MAJOR_VERSION@.@WEBKITGTK_API_MINOR_VERSION@.la
+endif
 
 nodist_libwebkitgtk_@WEBKITGTK_API_MAJOR_VERSION@_@WEBKITGTK_API_MINOR_VERSION@_la_SOURCES = \
 	$(webkitgtk_built_sources)
@@ -278,6 +280,7 @@
 	Source/WebKit/gtk/webkit/webkitwebwindowfeatures.cpp \
 	Source/WebKit/gtk/webkit/webkitwebwindowfeaturesprivate.h
 
+if ENABLE_WEBKIT1
 pkgconfig_DATA += Source/WebKit/gtk/@WEBKITGTK_PC_NAME@-@WEBKITGTK_API_VERSION@.pc
 
 if ENABLE_INTROSPECTION
@@ -335,6 +338,7 @@
 CLEANFILES += $(JSCORE_GIRSOURCES) $(WEBKIT_GIRSOURCES) $(typelibs_DATA)
 
 endif
+endif
 
 EXTRA_DIST += 

[webkit-changes] [139770] trunk

[krit]

Title: [139770] trunk








Revision 139770
Author k...@webkit.org
Date 2013-01-15 12:02:20 -0800 (Tue, 15 Jan 2013)


Log Message
[CSS Filters] brightness() function doesn't work as specified
https://bugs.webkit.org/show_bug.cgi?id=106674

Source/WebCore:

Reviewed by Dean Jackson.

The brightness filter implementation modified the intercept instead of the slope on
the feComponentTransfer function. The passed amount acts as multiplier for each
color chanel now.

Existing tests cover the changes and were updated.

* css/CSSParser.cpp:
(WebCore::CSSParser::parseBuiltinFilterArguments):
* platform/graphics/ca/mac/PlatformCALayerMac.mm:
(PlatformCALayer::setFilters):
* rendering/FilterEffectRenderer.cpp:
(WebCore::FilterEffectRenderer::build):

LayoutTests:

Negative brightness values are possible but are meaningless. Modify the tests
to mainly use positive amounts for brightness tests.

Reviewed by Dean Jackson.

* css3/filters/effect-brightness-clamping-hw.html:
* css3/filters/effect-brightness-hw.html:
* css3/filters/effect-combined-hw.html:
* css3/filters/effect-combined.html:
* css3/filters/multiple-filters-invalidation.html:
* css3/filters/null-effect-check.html:
* css3/filters/script-tests/filter-property-parsing-invalid.js:
* css3/filters/script-tests/filter-property-parsing.js:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/css3/filters/effect-brightness-clamping-hw.html
trunk/LayoutTests/css3/filters/effect-brightness-hw.html
trunk/LayoutTests/css3/filters/effect-combined-hw.html
trunk/LayoutTests/css3/filters/effect-combined.html
trunk/LayoutTests/css3/filters/filter-property-parsing-expected.txt
trunk/LayoutTests/css3/filters/filter-property-parsing-invalid-expected.txt
trunk/LayoutTests/css3/filters/multiple-filters-invalidation.html
trunk/LayoutTests/css3/filters/null-effect-check.html
trunk/LayoutTests/css3/filters/script-tests/filter-property-parsing-invalid.js
trunk/LayoutTests/css3/filters/script-tests/filter-property-parsing.js
trunk/LayoutTests/platform/chromium/TestExpectations
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/CSSParser.cpp
trunk/Source/WebCore/platform/graphics/ca/mac/PlatformCALayerMac.mm
trunk/Source/WebCore/rendering/FilterEffectRenderer.cpp
trunk/Source/WebCore/svg/SVGStylable.h




Diff

Modified: trunk/LayoutTests/ChangeLog (139769 => 139770)

--- trunk/LayoutTests/ChangeLog	2013-01-15 19:49:50 UTC (rev 139769)
+++ trunk/LayoutTests/ChangeLog	2013-01-15 20:02:20 UTC (rev 139770)
@@ -1,3 +1,22 @@
+2013-01-13  Dirk Schulze  dschu...@adobe.com
+
+[CSS Filters] brightness() function doesn't work as specified
+https://bugs.webkit.org/show_bug.cgi?id=106674
+
+Negative brightness values are possible but are meaningless. Modify the tests
+to mainly use positive amounts for brightness tests.
+
+Reviewed by Dean Jackson.
+
+* css3/filters/effect-brightness-clamping-hw.html:
+* css3/filters/effect-brightness-hw.html:
+* css3/filters/effect-combined-hw.html:
+* css3/filters/effect-combined.html:
+* css3/filters/multiple-filters-invalidation.html:
+* css3/filters/null-effect-check.html:
+* css3/filters/script-tests/filter-property-parsing-invalid.js:
+* css3/filters/script-tests/filter-property-parsing.js:
+
 2013-01-15  Zan Dobersek  zandober...@gmail.com
 
 [GTK] Enable Performance Timeline, Resource Timing, Navigation Timing features


Modified: trunk/LayoutTests/css3/filters/effect-brightness-clamping-hw.html (139769 => 139770)

--- trunk/LayoutTests/css3/filters/effect-brightness-clamping-hw.html	2013-01-15 19:49:50 UTC (rev 139769)
+++ trunk/LayoutTests/css3/filters/effect-brightness-clamping-hw.html	2013-01-15 20:02:20 UTC (rev 139770)
@@ -3,14 +3,14 @@
 -webkit-transform:translateZ(0);
 }
 /style
-img style=-webkit-filter: brightness(-1) brightness(1) src=""
-img style=-webkit-filter: brightness(-0.8) brightness(0.8) src=""
-img style=-webkit-filter: brightness(-0.5) brightness(0.5) src=""
-img style=-webkit-filter: brightness(-0.2) brightness(0.2) src=""
-img style=-webkit-filter: brightness(0.2) brightness(-0.2) src=""
-img style=-webkit-filter: brightness(0.5) brightness(-0.5) src=""
-img style=-webkit-filter: brightness(0.8) brightness(-0.8) src=""
-img style=-webkit-filter: brightness(1) brightness(-1) src=""
+img style=-webkit-filter: brightness(1) brightness(2) src=""
+img style=-webkit-filter: brightness(0.2) brightness(1.8) src=""
+img style=-webkit-filter: brightness(0.5) brightness(1.5) src=""
+img style=-webkit-filter: brightness(0.8) brightness(1.2) src=""
+img style=-webkit-filter: brightness(1.2) brightness(0.8) src=""
+img style=-webkit-filter: brightness(1.5) brightness(0.5) src=""
+img style=-webkit-filter: brightness(1.8) brightness(0.2) src=""
+img style=-webkit-filter: brightness(1) brightness(1) src=""
 img style=-webkit-filter: brightness(0.8) grayscale(1) src=""
 img style=-webkit-filter: brightness(0.5) 

[webkit-changes] [139771] trunk/Tools

[commit-queue]

Title: [139771] trunk/Tools








Revision 139771
Author commit-qu...@webkit.org
Date 2013-01-15 12:03:10 -0800 (Tue, 15 Jan 2013)


Log Message
Renaming CleanWorkingDirectory step to DiscardLocalChanges to make
functionality match the name.
https://bugs.webkit.org/show_bug.cgi?id=106870

Patch by Tim 'mithro' Ansell mit...@mithis.com on 2013-01-15
Reviewed by Adam Barth.

* Scripts/webkitpy/tool/commands/download.py:
(Clean):
(Update):
(Build):
(BuildAndTest):
(CheckStyle):
(BuildAttachment):
(BuildAndTestAttachment):
(AbstractPatchApplyingCommand):
(ApplyWatchList):
(AbstractPatchLandingCommand):
(CreateRollout):
* Scripts/webkitpy/tool/steps/__init__.py:
* Scripts/webkitpy/tool/steps/cleanworkingdirectory.py:
(CleanWorkingDirectory.options):
(CleanWorkingDirectory.run):
* Scripts/webkitpy/tool/steps/cleanworkingdirectory_unittest.py:
* Scripts/webkitpy/tool/steps/discardlocalchanges.py: Copied from Tools/Scripts/webkitpy/tool/steps/cleanworkingdirectory.py.
* Scripts/webkitpy/tool/steps/discardlocalchanges_unittest.py: Copied from Tools/Scripts/webkitpy/tool/steps/cleanworkingdirectory_unittest.py.

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/tool/commands/download.py
trunk/Tools/Scripts/webkitpy/tool/steps/__init__.py
trunk/Tools/Scripts/webkitpy/tool/steps/cleanworkingdirectory.py
trunk/Tools/Scripts/webkitpy/tool/steps/cleanworkingdirectory_unittest.py


Added Paths

trunk/Tools/Scripts/webkitpy/tool/steps/discardlocalchanges.py
trunk/Tools/Scripts/webkitpy/tool/steps/discardlocalchanges_unittest.py


Removed Paths

trunk/Tools/Scripts/webkitpy/tool/steps/cleanworkingdirectorywithlocalcommits.py




Diff

Modified: trunk/Tools/ChangeLog (139770 => 139771)

--- trunk/Tools/ChangeLog	2013-01-15 20:02:20 UTC (rev 139770)
+++ trunk/Tools/ChangeLog	2013-01-15 20:03:10 UTC (rev 139771)
@@ -1,3 +1,31 @@
+2013-01-15  Tim 'mithro' Ansell  mit...@mithis.com
+
+Renaming CleanWorkingDirectory step to DiscardLocalChanges to make
+functionality match the name.
+https://bugs.webkit.org/show_bug.cgi?id=106870
+
+Reviewed by Adam Barth.
+
+* Scripts/webkitpy/tool/commands/download.py:
+(Clean):
+(Update):
+(Build):
+(BuildAndTest):
+(CheckStyle):
+(BuildAttachment):
+(BuildAndTestAttachment):
+(AbstractPatchApplyingCommand):
+(ApplyWatchList):
+(AbstractPatchLandingCommand):
+(CreateRollout):
+* Scripts/webkitpy/tool/steps/__init__.py:
+* Scripts/webkitpy/tool/steps/cleanworkingdirectory.py:
+(CleanWorkingDirectory.options):
+(CleanWorkingDirectory.run):
+* Scripts/webkitpy/tool/steps/cleanworkingdirectory_unittest.py:
+* Scripts/webkitpy/tool/steps/discardlocalchanges.py: Copied from Tools/Scripts/webkitpy/tool/steps/cleanworkingdirectory.py.
+* Scripts/webkitpy/tool/steps/discardlocalchanges_unittest.py: Copied from Tools/Scripts/webkitpy/tool/steps/cleanworkingdirectory_unittest.py.
+
 2013-01-15  Zan Dobersek  zandober...@gmail.com
 
 [Autotools] Add support for WebKit2-only builds


Modified: trunk/Tools/Scripts/webkitpy/tool/commands/download.py (139770 => 139771)

--- trunk/Tools/Scripts/webkitpy/tool/commands/download.py	2013-01-15 20:02:20 UTC (rev 139770)
+++ trunk/Tools/Scripts/webkitpy/tool/commands/download.py	2013-01-15 20:03:10 UTC (rev 139771)
@@ -47,7 +47,7 @@
 name = clean
 help_text = Clean the working copy
 steps = [
-steps.CleanWorkingDirectory,
+steps.DiscardLocalChanges,
 ]
 
 def _prepare_state(self, options, args, tool):
@@ -58,7 +58,7 @@
 name = update
 help_text = Update working copy (used internally)
 steps = [
-steps.CleanWorkingDirectory,
+steps.DiscardLocalChanges,
 steps.Update,
 ]
 
@@ -67,7 +67,7 @@
 name = build
 help_text = Update working copy and build
 steps = [
-steps.CleanWorkingDirectory,
+steps.DiscardLocalChanges,
 steps.Update,
 steps.Build,
 ]
@@ -80,7 +80,7 @@
 name = build-and-test
 help_text = Update working copy, build, and run the tests
 steps = [
-steps.CleanWorkingDirectory,
+steps.DiscardLocalChanges,
 steps.Update,
 steps.Build,
 steps.RunTests,
@@ -235,7 +235,7 @@
 help_text = Run check-webkit-style on the specified attachments
 argument_names = ATTACHMENT_ID [ATTACHMENT_IDS]
 main_steps = [
-steps.CleanWorkingDirectory,
+steps.DiscardLocalChanges,
 steps.Update,
 steps.ApplyPatch,
 steps.CheckStyle,
@@ -247,7 +247,7 @@
 help_text = Apply and build patches from bugzilla
 argument_names = ATTACHMENT_ID [ATTACHMENT_IDS]
 main_steps = [
-steps.CleanWorkingDirectory,
+steps.DiscardLocalChanges,
 steps.Update,
 steps.ApplyPatch,
 steps.Build,
@@ -259,7 +259,7 @@
 help_text = 

[webkit-changes] [139772] trunk/Source/WebCore

[ojan]

Title: [139772] trunk/Source/WebCore








Revision 139772
Author o...@chromium.org
Date 2013-01-15 12:39:40 -0800 (Tue, 15 Jan 2013)


Log Message
Cleanup visibility of some computePreferredLogicalWidths calls
https://bugs.webkit.org/show_bug.cgi?id=106933

Reviewed by Levi Weintraub.

No need for these to be public.

* rendering/RenderBox.h:
(WebCore::RenderBox::computePreferredLogicalWidths):
This should never get called in practice. Add an assert to that effect.

* rendering/RenderGrid.h:
(RenderGrid):
* rendering/RenderReplica.h:
(RenderReplica):
* rendering/RenderScrollbarPart.h:
(RenderScrollbarPart):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderBox.h
trunk/Source/WebCore/rendering/RenderGrid.h
trunk/Source/WebCore/rendering/RenderReplica.h
trunk/Source/WebCore/rendering/RenderScrollbarPart.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (139771 => 139772)

--- trunk/Source/WebCore/ChangeLog	2013-01-15 20:03:10 UTC (rev 139771)
+++ trunk/Source/WebCore/ChangeLog	2013-01-15 20:39:40 UTC (rev 139772)
@@ -1,3 +1,23 @@
+2013-01-15  Ojan Vafai  o...@chromium.org
+
+Cleanup visibility of some computePreferredLogicalWidths calls
+https://bugs.webkit.org/show_bug.cgi?id=106933
+
+Reviewed by Levi Weintraub.
+
+No need for these to be public.
+
+* rendering/RenderBox.h:
+(WebCore::RenderBox::computePreferredLogicalWidths):
+This should never get called in practice. Add an assert to that effect.
+
+* rendering/RenderGrid.h:
+(RenderGrid):
+* rendering/RenderReplica.h:
+(RenderReplica):
+* rendering/RenderScrollbarPart.h:
+(RenderScrollbarPart):
+
 2013-01-13  Dirk Schulze  dschu...@adobe.com
 
 [CSS Filters] brightness() function doesn't work as specified


Modified: trunk/Source/WebCore/rendering/RenderBox.h (139771 => 139772)

--- trunk/Source/WebCore/rendering/RenderBox.h	2013-01-15 20:03:10 UTC (rev 139771)
+++ trunk/Source/WebCore/rendering/RenderBox.h	2013-01-15 20:39:40 UTC (rev 139772)
@@ -658,7 +658,7 @@
 // This function calculates the minimum and maximum preferred widths for an object.
 // These values are used in shrink-to-fit layout systems.
 // These include tables, positioned objects, floats and flexible boxes.
-virtual void computePreferredLogicalWidths() { setPreferredLogicalWidthsDirty(false); }
+virtual void computePreferredLogicalWidths() { ASSERT_NOT_REACHED(); setPreferredLogicalWidthsDirty(false); }
 
 virtual LayoutRect frameRectForStickyPositioning() const OVERRIDE { return frameRect(); }
 


Modified: trunk/Source/WebCore/rendering/RenderGrid.h (139771 => 139772)

--- trunk/Source/WebCore/rendering/RenderGrid.h	2013-01-15 20:03:10 UTC (rev 139771)
+++ trunk/Source/WebCore/rendering/RenderGrid.h	2013-01-15 20:39:40 UTC (rev 139772)
@@ -40,13 +40,13 @@
 virtual const char* renderName() const OVERRIDE;
 
 virtual void layoutBlock(bool relayoutChildren, LayoutUnit pageLogicalHeight = 0) OVERRIDE;
-virtual void computePreferredLogicalWidths() OVERRIDE;
 
 virtual bool avoidsFloats() const OVERRIDE { return true; }
 virtual bool canCollapseAnonymousBlockChild() const OVERRIDE { return false; }
 
 private:
 virtual bool isRenderGrid() const OVERRIDE { return true; }
+virtual void computePreferredLogicalWidths() OVERRIDE;
 
 enum TrackSizingDirection { ForColumns, ForRows };
 void computedUsedBreadthOfGridTracks(TrackSizingDirection, VectorGridTrack);


Modified: trunk/Source/WebCore/rendering/RenderReplica.h (139771 => 139772)

--- trunk/Source/WebCore/rendering/RenderReplica.h	2013-01-15 20:03:10 UTC (rev 139771)
+++ trunk/Source/WebCore/rendering/RenderReplica.h	2013-01-15 20:39:40 UTC (rev 139772)
@@ -43,12 +43,12 @@
 virtual bool requiresLayer() const { return true; }
 
 virtual void layout();
-virtual void computePreferredLogicalWidths();
 
 virtual void paint(PaintInfo, const LayoutPoint);
 
 private:
 virtual bool isReplica() const { return true; }
+virtual void computePreferredLogicalWidths();
 
 };
 


Modified: trunk/Source/WebCore/rendering/RenderScrollbarPart.h (139771 => 139772)

--- trunk/Source/WebCore/rendering/RenderScrollbarPart.h	2013-01-15 20:03:10 UTC (rev 139771)
+++ trunk/Source/WebCore/rendering/RenderScrollbarPart.h	2013-01-15 20:39:40 UTC (rev 139772)
@@ -43,7 +43,6 @@
 virtual bool requiresLayer() const { return false; }
 
 virtual void layout();
-virtual void computePreferredLogicalWidths();
 
 void paintIntoRect(GraphicsContext*, const LayoutPoint, const LayoutRect);
 
@@ -62,6 +61,8 @@
 virtual void imageChanged(WrappedImagePtr, const IntRect* = 0);
 
 private:
+virtual void computePreferredLogicalWidths();
+
 void layoutHorizontalPart();
 void layoutVerticalPart();
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org

[webkit-changes] [139773] trunk/Source/WebCore

[ojan]

Title: [139773] trunk/Source/WebCore








Revision 139773
Author o...@chromium.org
Date 2013-01-15 12:44:25 -0800 (Tue, 15 Jan 2013)


Log Message
RenderText::computePreferredLogicalWidths does not need to be public
https://bugs.webkit.org/show_bug.cgi?id=106934

Reviewed by Levi Weintraub.

* rendering/RenderCounter.h:
Add OVERRIDE keyword.
* rendering/RenderText.h:
Make protected.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderCounter.h
trunk/Source/WebCore/rendering/RenderText.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (139772 => 139773)

--- trunk/Source/WebCore/ChangeLog	2013-01-15 20:39:40 UTC (rev 139772)
+++ trunk/Source/WebCore/ChangeLog	2013-01-15 20:44:25 UTC (rev 139773)
@@ -1,5 +1,17 @@
 2013-01-15  Ojan Vafai  o...@chromium.org
 
+RenderText::computePreferredLogicalWidths does not need to be public
+https://bugs.webkit.org/show_bug.cgi?id=106934
+
+Reviewed by Levi Weintraub.
+
+* rendering/RenderCounter.h:
+Add OVERRIDE keyword.
+* rendering/RenderText.h:
+Make protected.
+
+2013-01-15  Ojan Vafai  o...@chromium.org
+
 Cleanup visibility of some computePreferredLogicalWidths calls
 https://bugs.webkit.org/show_bug.cgi?id=106933
 


Modified: trunk/Source/WebCore/rendering/RenderCounter.h (139772 => 139773)

--- trunk/Source/WebCore/rendering/RenderCounter.h	2013-01-15 20:39:40 UTC (rev 139772)
+++ trunk/Source/WebCore/rendering/RenderCounter.h	2013-01-15 20:44:25 UTC (rev 139773)
@@ -49,7 +49,7 @@
 virtual PassRefPtrStringImpl originalText() const;
 
 virtual void updateText() OVERRIDE;
-virtual void computePreferredLogicalWidths(float leadWidth);
+virtual void computePreferredLogicalWidths(float leadWidth) OVERRIDE;
 
 // Removes the reference to the CounterNode associated with this renderer.
 // This is used to cause a counter display update when the CounterNode tree changes.


Modified: trunk/Source/WebCore/rendering/RenderText.h (139772 => 139773)

--- trunk/Source/WebCore/rendering/RenderText.h	2013-01-15 20:39:40 UTC (rev 139772)
+++ trunk/Source/WebCore/rendering/RenderText.h	2013-01-15 20:44:25 UTC (rev 139773)
@@ -137,7 +137,6 @@
 
 void checkConsistency() const;
 
-virtual void computePreferredLogicalWidths(float leadWidth);
 bool isAllCollapsibleWhitespace();
 
 bool canUseSimpleFontCodePath() const { return m_canUseSimpleFontCodePath; }
@@ -148,6 +147,7 @@
 virtual void reportMemoryUsage(MemoryObjectInfo*) const OVERRIDE;
 
 protected:
+virtual void computePreferredLogicalWidths(float leadWidth);
 virtual void willBeDestroyed();
 
 virtual void styleWillChange(StyleDifference, const RenderStyle*) { }






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [139774] trunk/Source

[pilgrim]

Title: [139774] trunk/Source








Revision 139774
Author pilg...@chromium.org
Date 2013-01-15 12:46:19 -0800 (Tue, 15 Jan 2013)


Log Message
[Chromium] Move SocketStreamHandle and SocketStreamHandleInternal to WebCore/platform
https://bugs.webkit.org/show_bug.cgi?id=106899

Reviewed by Adam Barth.

Part of a larger refactoring series; see tracking bug 106829.

Source/WebCore:

* WebCore.gypi:
* platform/network/chromium/SocketStreamHandle.cpp: Copied from Source/WebKit/chromium/src/SocketStreamHandle.cpp.
(WebCore::SocketStreamHandleInternal::send):
(WebCore::SocketStreamHandleInternal::didOpenStream):
(WebCore::SocketStreamHandleInternal::didSendData):
(WebCore::SocketStreamHandleInternal::didReceiveData):
(WebCore::SocketStreamHandleInternal::didClose):
(WebCore::SocketStreamHandleInternal::didFail):
* platform/network/chromium/SocketStreamHandleInternal.h: Copied from Source/WebKit/chromium/src/SocketStreamHandleInternal.h.

Source/WebKit/chromium:

* WebKit.gyp:
* src/SocketStreamHandle.cpp: Removed.
* src/SocketStreamHandleInternal.h: Removed.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/WebCore.gypi
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/WebKit.gyp


Added Paths

trunk/Source/WebCore/platform/network/chromium/SocketStreamHandle.cpp
trunk/Source/WebCore/platform/network/chromium/SocketStreamHandleInternal.h


Removed Paths

trunk/Source/WebKit/chromium/src/SocketStreamHandle.cpp
trunk/Source/WebKit/chromium/src/SocketStreamHandleInternal.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (139773 => 139774)

--- trunk/Source/WebCore/ChangeLog	2013-01-15 20:44:25 UTC (rev 139773)
+++ trunk/Source/WebCore/ChangeLog	2013-01-15 20:46:19 UTC (rev 139774)
@@ -1,3 +1,22 @@
+2013-01-15  Mark Pilgrim  pilg...@chromium.org
+
+[Chromium] Move SocketStreamHandle and SocketStreamHandleInternal to WebCore/platform
+https://bugs.webkit.org/show_bug.cgi?id=106899
+
+Reviewed by Adam Barth.
+
+Part of a larger refactoring series; see tracking bug 106829.
+
+* WebCore.gypi:
+* platform/network/chromium/SocketStreamHandle.cpp: Copied from Source/WebKit/chromium/src/SocketStreamHandle.cpp.
+(WebCore::SocketStreamHandleInternal::send):
+(WebCore::SocketStreamHandleInternal::didOpenStream):
+(WebCore::SocketStreamHandleInternal::didSendData):
+(WebCore::SocketStreamHandleInternal::didReceiveData):
+(WebCore::SocketStreamHandleInternal::didClose):
+(WebCore::SocketStreamHandleInternal::didFail):
+* platform/network/chromium/SocketStreamHandleInternal.h: Copied from Source/WebKit/chromium/src/SocketStreamHandleInternal.h.
+
 2013-01-15  Ojan Vafai  o...@chromium.org
 
 RenderText::computePreferredLogicalWidths does not need to be public


Modified: trunk/Source/WebCore/WebCore.gypi (139773 => 139774)

--- trunk/Source/WebCore/WebCore.gypi	2013-01-15 20:44:25 UTC (rev 139773)
+++ trunk/Source/WebCore/WebCore.gypi	2013-01-15 20:46:19 UTC (rev 139774)
@@ -4436,7 +4436,9 @@
 'platform/network/chromium/ResourceResponse.cpp',
 'platform/network/chromium/ResourceResponse.h',
 'platform/network/chromium/SocketStreamError.h',
+'platform/network/chromium/SocketStreamHandle.cpp',
 'platform/network/chromium/SocketStreamHandle.h',
+'platform/network/chromium/SocketStreamHandleInternal.h',
 'platform/network/curl/AuthenticationChallenge.h',
 'platform/network/curl/CookieJarCurl.cpp',
 'platform/network/curl/DNSCurl.cpp',


Copied: trunk/Source/WebCore/platform/network/chromium/SocketStreamHandle.cpp (from rev 139773, trunk/Source/WebKit/chromium/src/SocketStreamHandle.cpp) (0 => 139774)

--- trunk/Source/WebCore/platform/network/chromium/SocketStreamHandle.cpp	(rev 0)
+++ trunk/Source/WebCore/platform/network/chromium/SocketStreamHandle.cpp	2013-01-15 20:46:19 UTC (rev 139774)
@@ -0,0 +1,215 @@
+/*
+ * Copyright (C) 2009, 2012 Google Inc. All rights reserved.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions are
+ * met:
+ *
+ * * Redistributions of source code must retain the above copyright
+ * notice, this list of conditions and the following disclaimer.
+ * * Redistributions in binary form must reproduce the above
+ * copyright notice, this list of conditions and the following disclaimer
+ * in the documentation and/or other materials provided with the
+ * distribution.
+ * * Neither the name of Google Inc. nor the names of its
+ * contributors may be used to endorse or promote products derived from
+ * this software without specific prior written permission.
+ *
+ * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
+ * AS IS AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
+ * LIMITED TO, THE IMPLIED 

[webkit-changes] [139775] trunk/Source/WebCore

[tommyw]

Title: [139775] trunk/Source/WebCore








Revision 139775
Author tom...@google.com
Date 2013-01-15 12:47:18 -0800 (Tue, 15 Jan 2013)


Log Message
MediaStream API: Rename the [add|remove]Track callbacks to [add|remove]RemoteTrack for clarity
https://bugs.webkit.org/show_bug.cgi?id=106791

Reviewed by Adam Barth.

No tests needed.

* Modules/mediastream/MediaStream.cpp:
(WebCore::MediaStream::addRemoteTrack):
(WebCore::MediaStream::removeRemoteTrack):
* Modules/mediastream/MediaStream.h:
* platform/mediastream/MediaStreamCenter.cpp:
(WebCore::MediaStreamCenter::addMediaStreamTrack):
(WebCore::MediaStreamCenter::removeMediaStreamTrack):
* platform/mediastream/MediaStreamDescriptor.h:
(MediaStreamDescriptorClient):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/mediastream/MediaStream.cpp
trunk/Source/WebCore/Modules/mediastream/MediaStream.h
trunk/Source/WebCore/platform/mediastream/MediaStreamCenter.cpp
trunk/Source/WebCore/platform/mediastream/MediaStreamDescriptor.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (139774 => 139775)

--- trunk/Source/WebCore/ChangeLog	2013-01-15 20:46:19 UTC (rev 139774)
+++ trunk/Source/WebCore/ChangeLog	2013-01-15 20:47:18 UTC (rev 139775)
@@ -1,3 +1,22 @@
+2013-01-15  Tommy Widenflycht  tom...@google.com
+
+MediaStream API: Rename the [add|remove]Track callbacks to [add|remove]RemoteTrack for clarity
+https://bugs.webkit.org/show_bug.cgi?id=106791
+
+Reviewed by Adam Barth.
+
+No tests needed.
+
+* Modules/mediastream/MediaStream.cpp:
+(WebCore::MediaStream::addRemoteTrack):
+(WebCore::MediaStream::removeRemoteTrack):
+* Modules/mediastream/MediaStream.h:
+* platform/mediastream/MediaStreamCenter.cpp:
+(WebCore::MediaStreamCenter::addMediaStreamTrack):
+(WebCore::MediaStreamCenter::removeMediaStreamTrack):
+* platform/mediastream/MediaStreamDescriptor.h:
+(MediaStreamDescriptorClient):
+
 2013-01-15  Mark Pilgrim  pilg...@chromium.org
 
 [Chromium] Move SocketStreamHandle and SocketStreamHandleInternal to WebCore/platform


Modified: trunk/Source/WebCore/Modules/mediastream/MediaStream.cpp (139774 => 139775)

--- trunk/Source/WebCore/Modules/mediastream/MediaStream.cpp	2013-01-15 20:46:19 UTC (rev 139774)
+++ trunk/Source/WebCore/Modules/mediastream/MediaStream.cpp	2013-01-15 20:47:18 UTC (rev 139775)
@@ -255,7 +255,7 @@
 return m_eventTargetData;
 }
 
-void MediaStream::addTrack(MediaStreamComponent* component)
+void MediaStream::addRemoteTrack(MediaStreamComponent* component)
 {
 if (ended())
 return;
@@ -273,7 +273,7 @@
 scheduleDispatchEvent(MediaStreamTrackEvent::create(eventNames().addtrackEvent, false, false, track));
 }
 
-void MediaStream::removeTrack(MediaStreamComponent* component)
+void MediaStream::removeRemoteTrack(MediaStreamComponent* component)
 {
 if (ended())
 return;


Modified: trunk/Source/WebCore/Modules/mediastream/MediaStream.h (139774 => 139775)

--- trunk/Source/WebCore/Modules/mediastream/MediaStream.h	2013-01-15 20:46:19 UTC (rev 139774)
+++ trunk/Source/WebCore/Modules/mediastream/MediaStream.h	2013-01-15 20:47:18 UTC (rev 139775)
@@ -95,8 +95,8 @@
 virtual void derefEventTarget() OVERRIDE { deref(); }
 
 // MediaStreamDescriptorClient
-virtual void addTrack(MediaStreamComponent*) OVERRIDE;
-virtual void removeTrack(MediaStreamComponent*) OVERRIDE;
+virtual void addRemoteTrack(MediaStreamComponent*) OVERRIDE;
+virtual void removeRemoteTrack(MediaStreamComponent*) OVERRIDE;
 
 void scheduleDispatchEvent(PassRefPtrEvent);
 void scheduledEventTimerFired(TimerMediaStream*);


Modified: trunk/Source/WebCore/platform/mediastream/MediaStreamCenter.cpp (139774 => 139775)

--- trunk/Source/WebCore/platform/mediastream/MediaStreamCenter.cpp	2013-01-15 20:46:19 UTC (rev 139774)
+++ trunk/Source/WebCore/platform/mediastream/MediaStreamCenter.cpp	2013-01-15 20:47:18 UTC (rev 139775)
@@ -60,14 +60,14 @@
 {
 MediaStreamDescriptorClient* client = streamDescriptor-client();
 if (client)
-client-addTrack(component);
+client-addRemoteTrack(component);
 }
 
 void MediaStreamCenter::removeMediaStreamTrack(MediaStreamDescriptor* streamDescriptor, MediaStreamComponent* component)
 {
 MediaStreamDescriptorClient* client = streamDescriptor-client();
 if (client)
-client-removeTrack(component);
+client-removeRemoteTrack(component);
 }
 
 } // namespace WebCore


Modified: trunk/Source/WebCore/platform/mediastream/MediaStreamDescriptor.h (139774 => 139775)

--- trunk/Source/WebCore/platform/mediastream/MediaStreamDescriptor.h	2013-01-15 20:46:19 UTC (rev 139774)
+++ trunk/Source/WebCore/platform/mediastream/MediaStreamDescriptor.h	2013-01-15 20:47:18 UTC (rev 139775)
@@ -45,8 +45,8 @@
 virtual ~MediaStreamDescriptorClient() { }
 
 virtual void streamEnded() = 0;
-virtual void 

[webkit-changes] [139776] trunk/Tools

[jochen]

Title: [139776] trunk/Tools








Revision 139776
Author joc...@chromium.org
Date 2013-01-15 12:49:36 -0800 (Tue, 15 Jan 2013)


Log Message
[chromium] move WebDatabase related methods to TestRunner library
https://bugs.webkit.org/show_bug.cgi?id=106905

Reviewed by Adam Barth.

* DumpRenderTree/chromium/DRTTestRunner.cpp:
(DRTTestRunner::DRTTestRunner):
(DRTTestRunner::reset):
* DumpRenderTree/chromium/DRTTestRunner.h:
(DRTTestRunner):
* DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
(WebTestRunner::WebTestDelegate::clearAllDatabases):
(WebTestRunner::WebTestDelegate::setDatabaseQuota):
* DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
(WebTestRunner::TestRunner::TestRunner):
(WebTestRunner::TestRunner::reset):
(WebTestRunner::TestRunner::clearAllDatabases):
(WebTestRunner):
(WebTestRunner::TestRunner::setDatabaseQuota):
* DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
(TestRunner):
* DumpRenderTree/chromium/WebViewHost.cpp:
(WebViewHost::clearAllDatabases):
(WebViewHost::setDatabaseQuota):
* DumpRenderTree/chromium/WebViewHost.h:
(WebViewHost):

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/DumpRenderTree/chromium/DRTTestRunner.cpp
trunk/Tools/DumpRenderTree/chromium/DRTTestRunner.h
trunk/Tools/DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h
trunk/Tools/DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp
trunk/Tools/DumpRenderTree/chromium/TestRunner/src/TestRunner.h
trunk/Tools/DumpRenderTree/chromium/WebViewHost.cpp
trunk/Tools/DumpRenderTree/chromium/WebViewHost.h




Diff

Modified: trunk/Tools/ChangeLog (139775 => 139776)

--- trunk/Tools/ChangeLog	2013-01-15 20:47:18 UTC (rev 139775)
+++ trunk/Tools/ChangeLog	2013-01-15 20:49:36 UTC (rev 139776)
@@ -1,3 +1,32 @@
+2013-01-15  Jochen Eisinger  joc...@chromium.org
+
+[chromium] move WebDatabase related methods to TestRunner library
+https://bugs.webkit.org/show_bug.cgi?id=106905
+
+Reviewed by Adam Barth.
+
+* DumpRenderTree/chromium/DRTTestRunner.cpp:
+(DRTTestRunner::DRTTestRunner):
+(DRTTestRunner::reset):
+* DumpRenderTree/chromium/DRTTestRunner.h:
+(DRTTestRunner):
+* DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
+(WebTestRunner::WebTestDelegate::clearAllDatabases):
+(WebTestRunner::WebTestDelegate::setDatabaseQuota):
+* DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
+(WebTestRunner::TestRunner::TestRunner):
+(WebTestRunner::TestRunner::reset):
+(WebTestRunner::TestRunner::clearAllDatabases):
+(WebTestRunner):
+(WebTestRunner::TestRunner::setDatabaseQuota):
+* DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
+(TestRunner):
+* DumpRenderTree/chromium/WebViewHost.cpp:
+(WebViewHost::clearAllDatabases):
+(WebViewHost::setDatabaseQuota):
+* DumpRenderTree/chromium/WebViewHost.h:
+(WebViewHost):
+
 2013-01-15  Tim 'mithro' Ansell  mit...@mithis.com
 
 Renaming CleanWorkingDirectory step to DiscardLocalChanges to make


Modified: trunk/Tools/DumpRenderTree/chromium/DRTTestRunner.cpp (139775 => 139776)

--- trunk/Tools/DumpRenderTree/chromium/DRTTestRunner.cpp	2013-01-15 20:47:18 UTC (rev 139775)
+++ trunk/Tools/DumpRenderTree/chromium/DRTTestRunner.cpp	2013-01-15 20:49:36 UTC (rev 139776)
@@ -104,7 +104,6 @@
 bindMethod(setMockSpeechRecognitionError, DRTTestRunner::setMockSpeechRecognitionError);
 bindMethod(wasMockSpeechRecognitionAborted, DRTTestRunner::wasMockSpeechRecognitionAborted);
 #endif
-bindMethod(clearAllDatabases, DRTTestRunner::clearAllDatabases);
 #if ENABLE(POINTER_LOCK)
 bindMethod(didAcquirePointerLock, DRTTestRunner::didAcquirePointerLock);
 bindMethod(didLosePointerLock, DRTTestRunner::didLosePointerLock);
@@ -128,7 +127,6 @@
 bindMethod(setAlwaysAcceptCookies, DRTTestRunner::setAlwaysAcceptCookies);
 bindMethod(setCloseRemainingWindowsWhenComplete, DRTTestRunner::setCloseRemainingWindowsWhenComplete);
 bindMethod(setCustomPolicyDelegate, DRTTestRunner::setCustomPolicyDelegate);
-bindMethod(setDatabaseQuota, DRTTestRunner::setDatabaseQuota);
 bindMethod(setGeolocationPermission, DRTTestRunner::setGeolocationPermission);
 bindMethod(setMockDeviceOrientation, DRTTestRunner::setMockDeviceOrientation);
 bindMethod(setMockGeolocationPositionUnavailableError, DRTTestRunner::setMockGeolocationPositionUnavailableError);
@@ -401,9 +399,6 @@
 
 webkit_support::SetAcceptAllCookies(false);
 
-// Reset the default quota for each origin to 5MB
-webkit_support::SetDatabaseQuota(5 * 1024 * 1024);
-
 setlocale(LC_ALL, );
 
 if (m_closeRemainingWindows)
@@ -587,19 +582,6 @@
 result-setNull();
 }
 
-void DRTTestRunner::clearAllDatabases(const CppArgumentList arguments, CppVariant* result)
-{
-result-setNull();
-webkit_support::ClearAllDatabases();
-}
-
-void DRTTestRunner::setDatabaseQuota(const 

[webkit-changes] [139777] trunk

[simonjam]

Title: [139777] trunk








Revision 139777
Author simon...@chromium.org
Date 2013-01-15 12:57:59 -0800 (Tue, 15 Jan 2013)


Log Message
[User Timing] INVALID_ACCESS_ERR should be thrown if measuring from a 0 Nav Timing value
https://bugs.webkit.org/show_bug.cgi?id=106935

Reviewed by Tony Gentilcore.

Source/WebCore:

Test: http/tests/w3c/webperf/submission/Intel/user-timing/test_user_timing_measure_exception.html

* page/PerformanceUserTiming.cpp:
(WebCore::UserTiming::findExistingMarkStartTime):

LayoutTests:

* http/tests/w3c/webperf/submission/Intel/user-timing/test_user_timing_measure_exception-expected.txt:
* http/tests/w3c/webperf/submission/Intel/user-timing/test_user_timing_measure_exception.html:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/http/tests/w3c/webperf/submission/Intel/user-timing/test_user_timing_measure_exception-expected.txt
trunk/LayoutTests/http/tests/w3c/webperf/submission/Intel/user-timing/test_user_timing_measure_exception.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/PerformanceUserTiming.cpp




Diff

Modified: trunk/LayoutTests/ChangeLog (139776 => 139777)

--- trunk/LayoutTests/ChangeLog	2013-01-15 20:49:36 UTC (rev 139776)
+++ trunk/LayoutTests/ChangeLog	2013-01-15 20:57:59 UTC (rev 139777)
@@ -1,3 +1,13 @@
+2013-01-15  James Simonsen  simon...@chromium.org
+
+[User Timing] INVALID_ACCESS_ERR should be thrown if measuring from a 0 Nav Timing value
+https://bugs.webkit.org/show_bug.cgi?id=106935
+
+Reviewed by Tony Gentilcore.
+
+* http/tests/w3c/webperf/submission/Intel/user-timing/test_user_timing_measure_exception-expected.txt:
+* http/tests/w3c/webperf/submission/Intel/user-timing/test_user_timing_measure_exception.html:
+
 2013-01-13  Dirk Schulze  dschu...@adobe.com
 
 [CSS Filters] brightness() function doesn't work as specified


Modified: trunk/LayoutTests/http/tests/w3c/webperf/submission/Intel/user-timing/test_user_timing_measure_exception-expected.txt (139776 => 139777)

--- trunk/LayoutTests/http/tests/w3c/webperf/submission/Intel/user-timing/test_user_timing_measure_exception-expected.txt	2013-01-15 20:49:36 UTC (rev 139776)
+++ trunk/LayoutTests/http/tests/w3c/webperf/submission/Intel/user-timing/test_user_timing_measure_exception-expected.txt	2013-01-15 20:57:59 UTC (rev 139777)
@@ -10,4 +10,5 @@
 PASS Invocation of context.measure(Exception4, NonExistMark1, ExistMark) should throw SYNTAX_ERR Exception. 
 PASS Invocation of context.measure(Exception5, ExistMark, NonExistMark1) should throw SYNTAX_ERR Exception. 
 PASS Invocation of context.measure(Exception6, NonExistMark1, NonExistMark2) should throw SYNTAX_ERR Exception. 
+PASS Invocation of context.measure(Exception7, redirectStart) should throw INVALID_ACCESS_ERR Exception. 
 


Modified: trunk/LayoutTests/http/tests/w3c/webperf/submission/Intel/user-timing/test_user_timing_measure_exception.html (139776 => 139777)

--- trunk/LayoutTests/http/tests/w3c/webperf/submission/Intel/user-timing/test_user_timing_measure_exception.html	2013-01-15 20:49:36 UTC (rev 139776)
+++ trunk/LayoutTests/http/tests/w3c/webperf/submission/Intel/user-timing/test_user_timing_measure_exception.html	2013-01-15 20:57:59 UTC (rev 139777)
@@ -25,6 +25,7 @@
 test_method_throw_exception('context.measure(Exception4, NonExistMark1, ExistMark)', 'SYNTAX_ERR');
 test_method_throw_exception('context.measure(Exception5, ExistMark, NonExistMark1)', 'SYNTAX_ERR');
 test_method_throw_exception('context.measure(Exception6, NonExistMark1, NonExistMark2)', 'SYNTAX_ERR');
+test_method_throw_exception('context.measure(Exception7, redirectStart)', 'INVALID_ACCESS_ERR');
 /script
 /body
 /html


Modified: trunk/Source/WebCore/ChangeLog (139776 => 139777)

--- trunk/Source/WebCore/ChangeLog	2013-01-15 20:49:36 UTC (rev 139776)
+++ trunk/Source/WebCore/ChangeLog	2013-01-15 20:57:59 UTC (rev 139777)
@@ -1,3 +1,15 @@
+2013-01-15  James Simonsen  simon...@chromium.org
+
+[User Timing] INVALID_ACCESS_ERR should be thrown if measuring from a 0 Nav Timing value
+https://bugs.webkit.org/show_bug.cgi?id=106935
+
+Reviewed by Tony Gentilcore.
+
+Test: http/tests/w3c/webperf/submission/Intel/user-timing/test_user_timing_measure_exception.html
+
+* page/PerformanceUserTiming.cpp:
+(WebCore::UserTiming::findExistingMarkStartTime):
+
 2013-01-15  Tommy Widenflycht  tom...@google.com
 
 MediaStream API: Rename the [add|remove]Track callbacks to [add|remove]RemoteTrack for clarity


Modified: trunk/Source/WebCore/page/PerformanceUserTiming.cpp (139776 => 139777)

--- trunk/Source/WebCore/page/PerformanceUserTiming.cpp	2013-01-15 20:49:36 UTC (rev 139776)
+++ trunk/Source/WebCore/page/PerformanceUserTiming.cpp	2013-01-15 20:57:59 UTC (rev 139777)
@@ -123,8 +123,14 @@
 if (m_marksMap.contains(markName))
 return m_marksMap.get(markName).last()-startTime();
 
-if 

[webkit-changes] [139778] trunk/Tools

[dpranke]

Title: [139778] trunk/Tools








Revision 139778
Author dpra...@chromium.org
Date 2013-01-15 13:04:09 -0800 (Tue, 15 Jan 2013)


Log Message
nrwt: change the default # of locked shards on chromium_win to 1
https://bugs.webkit.org/show_bug.cgi?id=106938

Reviewed by Eric Seidel.

It looks like LigHTTPd might be buggy or unstable if we are
running multiple http tests in parallel; see
http://code.google.com/p/chromium/issues/detail?id=169530 for more
context as well. This change will stop running http tests in parallel
and we can see if this fixes things.

* Scripts/webkitpy/layout_tests/port/chromium_win.py:
(ChromiumWinPort.default_max_locked_shards):
* Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
(ChromiumWinTest.test_path_to_image_diff):
(ChromiumWinTest):
(ChromiumWinTest.test_default_max_locked_shards):

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_win.py
trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py




Diff

Modified: trunk/Tools/ChangeLog (139777 => 139778)

--- trunk/Tools/ChangeLog	2013-01-15 20:57:59 UTC (rev 139777)
+++ trunk/Tools/ChangeLog	2013-01-15 21:04:09 UTC (rev 139778)
@@ -1,3 +1,23 @@
+2013-01-15  Dirk Pranke  dpra...@chromium.org
+
+nrwt: change the default # of locked shards on chromium_win to 1
+https://bugs.webkit.org/show_bug.cgi?id=106938
+
+Reviewed by Eric Seidel.
+
+It looks like LigHTTPd might be buggy or unstable if we are
+running multiple http tests in parallel; see
+http://code.google.com/p/chromium/issues/detail?id=169530 for more
+context as well. This change will stop running http tests in parallel
+and we can see if this fixes things.
+
+* Scripts/webkitpy/layout_tests/port/chromium_win.py:
+(ChromiumWinPort.default_max_locked_shards):
+* Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
+(ChromiumWinTest.test_path_to_image_diff):
+(ChromiumWinTest):
+(ChromiumWinTest.test_default_max_locked_shards):
+
 2013-01-15  Jochen Eisinger  joc...@chromium.org
 
 [chromium] move WebDatabase related methods to TestRunner library


Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_win.py (139777 => 139778)

--- trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_win.py	2013-01-15 20:57:59 UTC (rev 139777)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_win.py	2013-01-15 21:04:09 UTC (rev 139778)
@@ -115,6 +115,11 @@
 path = filename[len(self.layout_tests_dir()) + 1:]
 return path.replace('\\', '/')
 
+def default_max_locked_shards(self):
+# FIXME: lighttpd may be unstable with  1 concurrent shards. See
+# http://code.google.com/p/chromium/issues/detail?id=169530
+return 1
+
 #
 # PROTECTED ROUTINES
 #


Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py (139777 => 139778)

--- trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py	2013-01-15 20:57:59 UTC (rev 139777)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py	2013-01-15 21:04:09 UTC (rev 139778)
@@ -131,3 +131,11 @@
 
 def test_path_to_image_diff(self):
 self.assertEqual(self.make_port()._path_to_image_diff(), '/mock-checkout/out/Release/ImageDiff.exe')
+
+def test_default_max_locked_shards(self):
+# FIXME: Remove this test when we remove the override for default_max_locked_shards() in chromium_win.py
+port = self.make_port()
+port.default_child_processes = lambda: 16
+self.assertEqual(port.default_max_locked_shards(), 1)
+port.default_child_processes = lambda: 2
+self.assertEqual(port.default_max_locked_shards(), 1)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [139779] trunk/Tools

[jochen]

Title: [139779] trunk/Tools








Revision 139779
Author joc...@chromium.org
Date 2013-01-15 13:34:59 -0800 (Tue, 15 Jan 2013)


Log Message
[chromium] add title text direction attribute to TestRunner
https://bugs.webkit.org/show_bug.cgi?id=106907

Reviewed by Adam Barth.

* DumpRenderTree/chromium/DRTTestRunner.cpp:
(DRTTestRunner::DRTTestRunner):
(DRTTestRunner::reset):
* DumpRenderTree/chromium/DRTTestRunner.h:
* DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
(WebTestRunner::WebTestRunner::setTitleTextDirection):
* DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
(WebTestRunner::TestRunner::TestRunner):
(WebTestRunner::TestRunner::reset):
(WebTestRunner::TestRunner::setTitleTextDirection):
(WebTestRunner):
* DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
(TestRunner):
* DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
(WebTestRunner::WebTestProxyBase::didReceiveTitle):
* DumpRenderTree/chromium/WebViewHost.cpp:
(WebViewHost::didReceiveTitle):

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/DumpRenderTree/chromium/DRTTestRunner.cpp
trunk/Tools/DumpRenderTree/chromium/DRTTestRunner.h
trunk/Tools/DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h
trunk/Tools/DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp
trunk/Tools/DumpRenderTree/chromium/TestRunner/src/TestRunner.h
trunk/Tools/DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp
trunk/Tools/DumpRenderTree/chromium/WebViewHost.cpp




Diff

Modified: trunk/Tools/ChangeLog (139778 => 139779)

--- trunk/Tools/ChangeLog	2013-01-15 21:04:09 UTC (rev 139778)
+++ trunk/Tools/ChangeLog	2013-01-15 21:34:59 UTC (rev 139779)
@@ -1,3 +1,28 @@
+2013-01-15  Jochen Eisinger  joc...@chromium.org
+
+[chromium] add title text direction attribute to TestRunner
+https://bugs.webkit.org/show_bug.cgi?id=106907
+
+Reviewed by Adam Barth.
+
+* DumpRenderTree/chromium/DRTTestRunner.cpp:
+(DRTTestRunner::DRTTestRunner):
+(DRTTestRunner::reset):
+* DumpRenderTree/chromium/DRTTestRunner.h:
+* DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
+(WebTestRunner::WebTestRunner::setTitleTextDirection):
+* DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
+(WebTestRunner::TestRunner::TestRunner):
+(WebTestRunner::TestRunner::reset):
+(WebTestRunner::TestRunner::setTitleTextDirection):
+(WebTestRunner):
+* DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
+(TestRunner):
+* DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
+(WebTestRunner::WebTestProxyBase::didReceiveTitle):
+* DumpRenderTree/chromium/WebViewHost.cpp:
+(WebViewHost::didReceiveTitle):
+
 2013-01-15  Dirk Pranke  dpra...@chromium.org
 
 nrwt: change the default # of locked shards on chromium_win to 1


Modified: trunk/Tools/DumpRenderTree/chromium/DRTTestRunner.cpp (139778 => 139779)

--- trunk/Tools/DumpRenderTree/chromium/DRTTestRunner.cpp	2013-01-15 21:04:09 UTC (rev 139778)
+++ trunk/Tools/DumpRenderTree/chromium/DRTTestRunner.cpp	2013-01-15 21:34:59 UTC (rev 139779)
@@ -152,7 +152,6 @@
 // Shared properties.
 // webHistoryItemCount is used by tests in LayoutTests\http\tests\history
 bindProperty(webHistoryItemCount, m_webHistoryItemCount);
-bindProperty(titleTextDirection, m_titleTextDirection);
 bindProperty(interceptPostMessage, m_interceptPostMessage);
 }
 
@@ -394,7 +393,6 @@
 m_shell-webViewHost()-setDeviceScaleFactor(1);
 m_waitUntilDone = false;
 m_webHistoryItemCount.set(0);
-m_titleTextDirection.set(ltr);
 m_interceptPostMessage.set(false);
 
 webkit_support::SetAcceptAllCookies(false);


Modified: trunk/Tools/DumpRenderTree/chromium/DRTTestRunner.h (139778 => 139779)

--- trunk/Tools/DumpRenderTree/chromium/DRTTestRunner.h	2013-01-15 21:04:09 UTC (rev 139778)
+++ trunk/Tools/DumpRenderTree/chromium/DRTTestRunner.h	2013-01-15 21:34:59 UTC (rev 139779)
@@ -44,7 +44,6 @@
 
 #include TestRunner/src/TestRunner.h
 #include WebTask.h
-#include WebTextDirection.h
 #include platform/WebArrayBufferView.h
 #include platform/WebString.h
 #include platform/WebURL.h
@@ -173,10 +172,6 @@
 void setWorkQueueFrozen(bool frozen) { m_workQueue.setFrozen(frozen); }
 
 void setShowDebugLayerTree(bool value) { m_showDebugLayerTree = value; }
-void setTitleTextDirection(WebKit::WebTextDirection dir)
-{
-m_titleTextDirection.set(dir == WebKit::WebTextDirectionLeftToRight ? ltr : rtl);
-}
 
 bool shouldInterceptPostMessage()
 {
@@ -268,9 +263,6 @@
 // Bound variable counting the number of top URLs visited.
 CppVariant m_webHistoryItemCount;
 
-// Bound variable tracking the directionality of the title tag.
-CppVariant m_titleTextDirection;
-
 // Bound variable to set whether postMessages should be intercepted or not
 CppVariant m_interceptPostMessage;
 };


Modified: 

[webkit-changes] [139780] trunk/Source

[abarth]

Title: [139780] trunk/Source








Revision 139780
Author aba...@webkit.org
Date 2013-01-15 13:35:08 -0800 (Tue, 15 Jan 2013)


Log Message
Generalize DocumentWeakReference into WTF::WeakPtr
https://bugs.webkit.org/show_bug.cgi?id=106854

Reviewed by Darin Adler.

Source/WebCore:

This patch replaces DocumentWeakReference with WeakPtr. There should be
no change in behavior.

* dom/Document.cpp:
(WebCore):
(WebCore::Document::Document):
(WebCore::Document::~Document):
(WebCore::PerformTaskContext::PerformTaskContext):
(PerformTaskContext):
(WebCore::Document::didReceiveTask):
(WebCore::Document::postTask):
(WebCore::Document::reportMemoryUsage):
* dom/Document.h:
(WebCore):
(Document):

Source/WTF:

This patch adds a simple WeakPtr object to WTF. To use WeakPtr, objects
must hold a WeakPtrFactory member variable, which clears the WeakPtrs
when the object is destructed. The underlying storage is a
ThreadSafeRefCounted WeakReference object, which is shared by all the
WeakPtrs.

WeakPtr is a generalization of DocumentWeakReference, which is used to
check whether the Document object is alive when tasks arive on the main
thread from worker threads. We plan to use a similar pattern in the
threaded HTML parser, but we want to send tasks to objects other than
Document.

* GNUmakefile.list.am:
* WTF.gypi:
* WTF.pro:
* WTF.vcproj/WTF.vcproj:
* WTF.xcodeproj/project.pbxproj:
* wtf/CMakeLists.txt:
* wtf/WeakPtr.h: Added.
(WeakReference):
- The ThreadSafeRefCounted object shared by all the WeakPtr
  instances. This patch uses ThreadSafeRefCounted so that we can
  use WeakPtrs to cancel cross-thread messages.
(WTF::WeakReference::create):
(WTF::WeakReference::get):
(WTF::WeakReference::clear):
- When the object is destroyed, WeakPtrFactory calls this function
  to clear all the WeakPtrs.
(WTF::WeakReference::WeakReference):
(WTF::WeakPtr::WeakPtr):
(WTF::WeakPtr::get):
- We might want to add implicit conversions and Boolean operators
  in the future, but I've kept this class simple for now.
(WTF::WeakPtrFactory::WeakPtrFactory):
(WTF::WeakPtrFactory::~WeakPtrFactory):
(WTF::WeakPtrFactory::createWeakPtr):

Modified Paths

trunk/Source/WTF/ChangeLog
trunk/Source/WTF/GNUmakefile.list.am
trunk/Source/WTF/WTF.gypi
trunk/Source/WTF/WTF.pro
trunk/Source/WTF/WTF.vcproj/WTF.vcproj
trunk/Source/WTF/WTF.xcodeproj/project.pbxproj
trunk/Source/WTF/wtf/CMakeLists.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/Document.cpp
trunk/Source/WebCore/dom/Document.h


Added Paths

trunk/Source/WTF/wtf/WeakPtr.h




Diff

Modified: trunk/Source/WTF/ChangeLog (139779 => 139780)

--- trunk/Source/WTF/ChangeLog	2013-01-15 21:34:59 UTC (rev 139779)
+++ trunk/Source/WTF/ChangeLog	2013-01-15 21:35:08 UTC (rev 139780)
@@ -1,3 +1,47 @@
+2013-01-15  Adam Barth  aba...@webkit.org
+
+Generalize DocumentWeakReference into WTF::WeakPtr
+https://bugs.webkit.org/show_bug.cgi?id=106854
+
+Reviewed by Darin Adler.
+
+This patch adds a simple WeakPtr object to WTF. To use WeakPtr, objects
+must hold a WeakPtrFactory member variable, which clears the WeakPtrs
+when the object is destructed. The underlying storage is a
+ThreadSafeRefCounted WeakReference object, which is shared by all the
+WeakPtrs.
+
+WeakPtr is a generalization of DocumentWeakReference, which is used to
+check whether the Document object is alive when tasks arive on the main
+thread from worker threads. We plan to use a similar pattern in the
+threaded HTML parser, but we want to send tasks to objects other than
+Document.
+
+* GNUmakefile.list.am:
+* WTF.gypi:
+* WTF.pro:
+* WTF.vcproj/WTF.vcproj:
+* WTF.xcodeproj/project.pbxproj:
+* wtf/CMakeLists.txt:
+* wtf/WeakPtr.h: Added.
+(WeakReference):
+- The ThreadSafeRefCounted object shared by all the WeakPtr
+  instances. This patch uses ThreadSafeRefCounted so that we can
+  use WeakPtrs to cancel cross-thread messages.
+(WTF::WeakReference::create):
+(WTF::WeakReference::get):
+(WTF::WeakReference::clear):
+- When the object is destroyed, WeakPtrFactory calls this function
+  to clear all the WeakPtrs.
+(WTF::WeakReference::WeakReference):
+(WTF::WeakPtr::WeakPtr):
+(WTF::WeakPtr::get):
+- We might want to add implicit conversions and Boolean operators
+  in the future, but I've kept this class simple for now.
+(WTF::WeakPtrFactory::WeakPtrFactory):
+(WTF::WeakPtrFactory::~WeakPtrFactory):
+(WTF::WeakPtrFactory::createWeakPtr):
+
 2013-01-12  Csaba Osztrogonác  o...@webkit.org
 
 Use __sync_add_and_fetch instead of __gnu_cxx::__exchange_and_add


Modified: trunk/Source/WTF/GNUmakefile.list.am (139779 => 139780)

--- trunk/Source/WTF/GNUmakefile.list.am	2013-01-15 21:34:59 UTC 

[webkit-changes] [139781] trunk/Source/WebKit2

[dominik . rottsches]

Title: [139781] trunk/Source/WebKit2








Revision 139781
Author dominik.rottsc...@intel.com
Date 2013-01-15 13:40:29 -0800 (Tue, 15 Jan 2013)


Log Message
[CoordinatedGraphics] Deadlock when running abspos-child-container-changes-from-relative-to-static.html
https://bugs.webkit.org/show_bug.cgi?id=106884

Reviewed by Benjamin Poulain.

We need to return false if m_waitingForUIProcess is true since otherwise
we'll not really repaint in performScheduledLayerFlush() and the
UI process will wait forever. Returning false leads to executing the layer flush
synchronously and immediately, then acknowledging the
callback to the WebProcess - which resolves the deadlock.

* WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp:
(WebKit::CoordinatedLayerTreeHost::forceRepaintAsync): Return false in order to trigger a synchronous repaint if m_waitingForUIProcess is true.

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp




Diff

Modified: trunk/Source/WebKit2/ChangeLog (139780 => 139781)

--- trunk/Source/WebKit2/ChangeLog	2013-01-15 21:35:08 UTC (rev 139780)
+++ trunk/Source/WebKit2/ChangeLog	2013-01-15 21:40:29 UTC (rev 139781)
@@ -1,3 +1,19 @@
+2013-01-15  Dominik Röttsches  dominik.rottsc...@intel.com
+
+[CoordinatedGraphics] Deadlock when running abspos-child-container-changes-from-relative-to-static.html
+https://bugs.webkit.org/show_bug.cgi?id=106884
+
+Reviewed by Benjamin Poulain.
+
+We need to return false if m_waitingForUIProcess is true since otherwise
+we'll not really repaint in performScheduledLayerFlush() and the
+UI process will wait forever. Returning false leads to executing the layer flush
+synchronously and immediately, then acknowledging the
+callback to the WebProcess - which resolves the deadlock.
+
+* WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp:
+(WebKit::CoordinatedLayerTreeHost::forceRepaintAsync): Return false in order to trigger a synchronous repaint if m_waitingForUIProcess is true.
+
 2013-01-15  Simon Fraser  simon.fra...@apple.com
 
 Allow tiled WKViews to have transparent backgrounds


Modified: trunk/Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp (139780 => 139781)

--- trunk/Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp	2013-01-15 21:35:08 UTC (rev 139780)
+++ trunk/Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp	2013-01-15 21:40:29 UTC (rev 139781)
@@ -204,6 +204,10 @@
 
 bool CoordinatedLayerTreeHost::forceRepaintAsync(uint64_t callbackID)
 {
+// Avoid deadlocks when the UI process has requested a forceRepaint by falling back to a synchronous repaint, see caller WebPage::forceRepaint.
+if (m_waitingForUIProcess)
+return false;
+
 // We expect the UI process to not require a new repaint until the previous one has finished.
 ASSERT(!m_forceRepaintAsyncCallbackID);
 m_forceRepaintAsyncCallbackID = callbackID;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [139782] trunk/Source/WebCore

[ojan]

Title: [139782] trunk/Source/WebCore








Revision 139782
Author o...@chromium.org
Date 2013-01-15 13:41:47 -0800 (Tue, 15 Jan 2013)


Log Message
Moving updating of margins from computePreferredLogicalWidths to layout
https://bugs.webkit.org/show_bug.cgi?id=106939

Reviewed by Levi Weintraub.

The margins don't affect it's preferred width. We should update them
during layout like we do in other classes (e.g. RenderBlock).

* rendering/RenderListMarker.cpp:
(WebCore::RenderListMarker::layout):
(WebCore::RenderListMarker::computePreferredLogicalWidths):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderListMarker.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (139781 => 139782)

--- trunk/Source/WebCore/ChangeLog	2013-01-15 21:40:29 UTC (rev 139781)
+++ trunk/Source/WebCore/ChangeLog	2013-01-15 21:41:47 UTC (rev 139782)
@@ -1,3 +1,17 @@
+2013-01-15  Ojan Vafai  o...@chromium.org
+
+Moving updating of margins from computePreferredLogicalWidths to layout
+https://bugs.webkit.org/show_bug.cgi?id=106939
+
+Reviewed by Levi Weintraub.
+
+The margins don't affect it's preferred width. We should update them
+during layout like we do in other classes (e.g. RenderBlock).
+
+* rendering/RenderListMarker.cpp:
+(WebCore::RenderListMarker::layout):
+(WebCore::RenderListMarker::computePreferredLogicalWidths):
+
 2013-01-15  Adam Barth  aba...@webkit.org
 
 Generalize DocumentWeakReference into WTF::WeakPtr


Modified: trunk/Source/WebCore/rendering/RenderListMarker.cpp (139781 => 139782)

--- trunk/Source/WebCore/rendering/RenderListMarker.cpp	2013-01-15 21:40:29 UTC (rev 139781)
+++ trunk/Source/WebCore/rendering/RenderListMarker.cpp	2013-01-15 21:41:47 UTC (rev 139782)
@@ -1316,6 +1316,8 @@
 {
 StackStats::LayoutCheckPoint layoutCheckPoint;
 ASSERT(needsLayout());
+
+updateMargins();
  
 if (isImage()) {
 setWidth(m_image-imageSize(this, style()-effectiveZoom()).width());
@@ -1367,7 +1369,6 @@
 LayoutSize imageSize = m_image-imageSize(this, style()-effectiveZoom());
 m_minPreferredLogicalWidth = m_maxPreferredLogicalWidth = style()-isHorizontalWritingMode() ? imageSize.width() : imageSize.height();
 setPreferredLogicalWidthsDirty(false);
-updateMargins();
 return;
 }
 
@@ -1478,8 +1479,6 @@
 m_maxPreferredLogicalWidth = logicalWidth;
 
 setPreferredLogicalWidthsDirty(false);
-
-updateMargins();
 }
 
 void RenderListMarker::updateMargins()






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [139783] trunk/Source/WebCore

[ojan]

Title: [139783] trunk/Source/WebCore








Revision 139783
Author o...@chromium.org
Date 2013-01-15 13:43:17 -0800 (Tue, 15 Jan 2013)


Log Message
Remove bogus assert added in http://trac.webkit.org/changeset/139772.
* rendering/RenderBox.h:
(WebCore::RenderBox::computePreferredLogicalWidths):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderBox.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (139782 => 139783)

--- trunk/Source/WebCore/ChangeLog	2013-01-15 21:41:47 UTC (rev 139782)
+++ trunk/Source/WebCore/ChangeLog	2013-01-15 21:43:17 UTC (rev 139783)
@@ -1,5 +1,11 @@
 2013-01-15  Ojan Vafai  o...@chromium.org
 
+Remove bogus assert added in http://trac.webkit.org/changeset/139772.
+* rendering/RenderBox.h:
+(WebCore::RenderBox::computePreferredLogicalWidths):
+
+2013-01-15  Ojan Vafai  o...@chromium.org
+
 Moving updating of margins from computePreferredLogicalWidths to layout
 https://bugs.webkit.org/show_bug.cgi?id=106939
 


Modified: trunk/Source/WebCore/rendering/RenderBox.h (139782 => 139783)

--- trunk/Source/WebCore/rendering/RenderBox.h	2013-01-15 21:41:47 UTC (rev 139782)
+++ trunk/Source/WebCore/rendering/RenderBox.h	2013-01-15 21:43:17 UTC (rev 139783)
@@ -658,7 +658,7 @@
 // This function calculates the minimum and maximum preferred widths for an object.
 // These values are used in shrink-to-fit layout systems.
 // These include tables, positioned objects, floats and flexible boxes.
-virtual void computePreferredLogicalWidths() { ASSERT_NOT_REACHED(); setPreferredLogicalWidthsDirty(false); }
+virtual void computePreferredLogicalWidths() { setPreferredLogicalWidthsDirty(false); }
 
 virtual LayoutRect frameRectForStickyPositioning() const OVERRIDE { return frameRect(); }
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [139784] trunk/Source/ThirdParty/ANGLE

[ddkilzer]

Title: [139784] trunk/Source/ThirdParty/ANGLE








Revision 139784
Author ddkil...@apple.com
Date 2013-01-15 13:49:49 -0800 (Tue, 15 Jan 2013)


Log Message
BUILD FIX: Add SUPPORTED_PLATFORMS to Base.xcconfig

* Configurations/Base.xcconfig: Add SUPPORTED_PLATFORMS so that
Xcode knows we can build this project for all three platforms.
Previously the Mac OS X SDKs were missing in the scheme picker.

Modified Paths

trunk/Source/ThirdParty/ANGLE/ChangeLog
trunk/Source/ThirdParty/ANGLE/Configurations/Base.xcconfig




Diff

Modified: trunk/Source/ThirdParty/ANGLE/ChangeLog (139783 => 139784)

--- trunk/Source/ThirdParty/ANGLE/ChangeLog	2013-01-15 21:43:17 UTC (rev 139783)
+++ trunk/Source/ThirdParty/ANGLE/ChangeLog	2013-01-15 21:49:49 UTC (rev 139784)
@@ -1,5 +1,13 @@
 2013-01-15  David Kilzer  ddkil...@apple.com
 
+BUILD FIX: Add SUPPORTED_PLATFORMS to Base.xcconfig
+
+* Configurations/Base.xcconfig: Add SUPPORTED_PLATFORMS so that
+Xcode knows we can build this project for all three platforms.
+Previously the Mac OS X SDKs were missing in the scheme picker.
+
+2013-01-15  David Kilzer  ddkil...@apple.com
+
 Upstream iOS changes for ANGLE project
 http://webkit.org/b/106913
 


Modified: trunk/Source/ThirdParty/ANGLE/Configurations/Base.xcconfig (139783 => 139784)

--- trunk/Source/ThirdParty/ANGLE/Configurations/Base.xcconfig	2013-01-15 21:43:17 UTC (rev 139783)
+++ trunk/Source/ThirdParty/ANGLE/Configurations/Base.xcconfig	2013-01-15 21:49:49 UTC (rev 139784)
@@ -32,6 +32,8 @@
 PREBINDING = NO;
 STRIP_INSTALLED_PRODUCT = NO;
 
+SUPPORTED_PLATFORMS = iphoneos iphonesimulator macosx;
+
 TARGET_MAC_OS_X_VERSION_MAJOR = $(MAC_OS_X_VERSION_MAJOR);
 
 TARGETING_SAME_OS_X_VERSION = $(TARGETING_SAME_OS_X_VERSION_$(MAC_OS_X_VERSION_MAJOR)_$(TARGET_MAC_OS_X_VERSION_MAJOR));






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [139785] trunk/LayoutTests

[zandobersek]

Title: [139785] trunk/LayoutTests








Revision 139785
Author zandober...@gmail.com
Date 2013-01-15 14:01:52 -0800 (Tue, 15 Jan 2013)


Log Message
Unreviewed GTK gardening.

Rebaselining after r139767 and r139768.

* platform/gtk/fast/dom/Window/window-properties-performance-expected.txt:
* platform/gtk/fast/media/w3c/test_media_queries-expected.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/gtk/fast/dom/Window/window-properties-performance-expected.txt
trunk/LayoutTests/platform/gtk/fast/media/w3c/test_media_queries-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (139784 => 139785)

--- trunk/LayoutTests/ChangeLog	2013-01-15 21:49:49 UTC (rev 139784)
+++ trunk/LayoutTests/ChangeLog	2013-01-15 22:01:52 UTC (rev 139785)
@@ -1,3 +1,12 @@
+2013-01-15  Zan Dobersek  zdober...@igalia.com
+
+Unreviewed GTK gardening.
+
+Rebaselining after r139767 and r139768.
+
+* platform/gtk/fast/dom/Window/window-properties-performance-expected.txt:
+* platform/gtk/fast/media/w3c/test_media_queries-expected.txt:
+
 2013-01-15  James Simonsen  simon...@chromium.org
 
 [User Timing] INVALID_ACCESS_ERR should be thrown if measuring from a 0 Nav Timing value


Modified: trunk/LayoutTests/platform/gtk/fast/dom/Window/window-properties-performance-expected.txt (139784 => 139785)

--- trunk/LayoutTests/platform/gtk/fast/dom/Window/window-properties-performance-expected.txt	2013-01-15 21:49:49 UTC (rev 139784)
+++ trunk/LayoutTests/platform/gtk/fast/dom/Window/window-properties-performance-expected.txt	2013-01-15 22:01:52 UTC (rev 139785)
@@ -13,6 +13,7 @@
 window.performance.navigation.redirectCount [number]
 window.performance.navigation.type [number]
 window.performance.now [function]
+window.performance.onwebkitresourcetimingbufferfull [null]
 window.performance.timing [object PerformanceTiming]
 window.performance.timing.connectEnd [number]
 window.performance.timing.connectStart [number]
@@ -35,6 +36,15 @@
 window.performance.timing.secureConnectionStart [number]
 window.performance.timing.unloadEventEnd [number]
 window.performance.timing.unloadEventStart [number]
+window.performance.webkitClearMarks [function]
+window.performance.webkitClearMeasures [function]
+window.performance.webkitClearResourceTimings [function]
+window.performance.webkitGetEntries [function]
+window.performance.webkitGetEntriesByName [function]
+window.performance.webkitGetEntriesByType [function]
+window.performance.webkitMark [function]
+window.performance.webkitMeasure [function]
+window.performance.webkitSetResourceTimingBufferSize [function]
 window.performance.timing [printed above as window.performance.timing]
 window.performance.navigation [printed above as window.performance.navigation]
 window.performance [string]


Modified: trunk/LayoutTests/platform/gtk/fast/media/w3c/test_media_queries-expected.txt (139784 => 139785)

--- trunk/LayoutTests/platform/gtk/fast/media/w3c/test_media_queries-expected.txt	2013-01-15 21:49:49 UTC (rev 139784)
+++ trunk/LayoutTests/platform/gtk/fast/media/w3c/test_media_queries-expected.txt	2013-01-15 22:01:52 UTC (rev 139785)
@@ -281,13 +281,13 @@
 PASS (resolution: dpi) should not apply 
 PASS (resolution: dpi + 1) should not apply 
 FAIL (min-resolution: dpi - 1 ) should apply assert_true: expected true got false
-PASS not all and (min-resolution: dpi - 1 ) should not apply 
-FAIL not all and (min-resolution: dpi + 1 ) should apply assert_true: expected true got false
+FAIL not all and (min-resolution: dpi - 1 ) should not apply assert_false: expected false got true
+PASS not all and (min-resolution: dpi + 1 ) should apply 
 PASS all and (min-resolution: dpi + 1 ) should not apply 
 FAIL (min-resolution: dpcm (dpi - 1) ) should apply assert_true: expected true got false
 FAIL (max-resolution: dpcm  (dpi + 1) ) should apply assert_true: expected true got false
 PASS (max-resolution: dpcm  (dpi - 1) ) should not apply 
-FAIL not all and (min-resolution: dpcm  (dpi + 1) ) should apply assert_true: expected true got false
+PASS not all and (min-resolution: dpcm  (dpi + 1) ) should apply 
 PASS _expression_ grid should be parseable 
 PASS _expression_ grid: 0 should be parseable 
 PASS _expression_ grid: 1 should be parseable 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [139786] trunk/Tools

[zandobersek]

Title: [139786] trunk/Tools








Revision 139786
Author zandober...@gmail.com
Date 2013-01-15 14:03:13 -0800 (Tue, 15 Jan 2013)


Log Message
Tests with WontFix expectation are (indirectly) skipped
https://bugs.webkit.org/show_bug.cgi?id=105860

Reviewed by Dirk Pranke.

Only skip the WontFix expectation if there are no other layout test
expectations (like Failure, ImageOnlyFailure) listed for the test.
This makes it possible to run an expected failure for which there
is no reason or interest to fix. There are some ports that would like
to exercise this behavior as well as specific test cases that should use
such expectations.

* Scripts/webkitpy/layout_tests/models/test_expectations.py:
(TestExpectationParser._tokenize_line): Only add the SKIP modifier for a
WONTFIX test if there are no expectations listed. The warning is adjusted
to reflect the new behavior.
* Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Add
and adjust test cases for these changes.
(ExpectationSyntaxTests.test_wontfix):
(SemanticTests.test_skip_and_wontfix):

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py
trunk/Tools/Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py




Diff

Modified: trunk/Tools/ChangeLog (139785 => 139786)

--- trunk/Tools/ChangeLog	2013-01-15 22:01:52 UTC (rev 139785)
+++ trunk/Tools/ChangeLog	2013-01-15 22:03:13 UTC (rev 139786)
@@ -1,3 +1,26 @@
+2013-01-15  Zan Dobersek  zdober...@igalia.com
+
+Tests with WontFix expectation are (indirectly) skipped
+https://bugs.webkit.org/show_bug.cgi?id=105860
+
+Reviewed by Dirk Pranke.
+
+Only skip the WontFix expectation if there are no other layout test
+expectations (like Failure, ImageOnlyFailure) listed for the test.
+This makes it possible to run an expected failure for which there
+is no reason or interest to fix. There are some ports that would like
+to exercise this behavior as well as specific test cases that should use
+such expectations.
+
+* Scripts/webkitpy/layout_tests/models/test_expectations.py:
+(TestExpectationParser._tokenize_line): Only add the SKIP modifier for a
+WONTFIX test if there are no expectations listed. The warning is adjusted
+to reflect the new behavior.
+* Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Add
+and adjust test cases for these changes.
+(ExpectationSyntaxTests.test_wontfix):
+(SemanticTests.test_skip_and_wontfix):
+
 2013-01-15  Jochen Eisinger  joc...@chromium.org
 
 [chromium] add title text direction attribute to TestRunner


Modified: trunk/Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py (139785 => 139786)

--- trunk/Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py	2013-01-15 22:01:52 UTC (rev 139785)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py	2013-01-15 22:03:13 UTC (rev 139786)
@@ -346,12 +346,12 @@
 elif state not in ('name_found', 'done'):
 warnings.append('Missing a ]')
 
-if 'WONTFIX' in modifiers and 'SKIP' not in modifiers:
+if 'WONTFIX' in modifiers and 'SKIP' not in modifiers and not expectations:
 modifiers.append('SKIP')
 
 if 'SKIP' in modifiers and expectations:
 # FIXME: This is really a semantic warning and shouldn't be here. Remove when we drop the old syntax.
-warnings.append('A test marked Skip or WontFix must not have other expectations.')
+warnings.append('A test marked Skip must not have other expectations.')
 elif not expectations:
 if 'SKIP' not in modifiers and 'REBASELINE' not in modifiers and 'SLOW' not in modifiers:
 modifiers.append('SKIP')


Modified: trunk/Tools/Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py (139785 => 139786)

--- trunk/Tools/Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py	2013-01-15 22:01:52 UTC (rev 139785)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py	2013-01-15 22:03:13 UTC (rev 139786)
@@ -356,6 +356,8 @@
 
 def test_wontfix(self):
 self.assert_tokenize_exp('foo.html [ WontFix ]', modifiers=['WONTFIX', 'SKIP'], expectations=['PASS'])
+self.assert_tokenize_exp('foo.html [ WontFix ImageOnlyFailure ]', modifiers=['WONTFIX'], expectations=['IMAGE'])
+self.assert_tokenize_exp('foo.html [ WontFix Pass Failure ]', modifiers=['WONTFIX'], expectations=['PASS', 'FAIL'])
 
 def test_blank_line(self):
 self.assert_tokenize_exp('', name=None)
@@ -391,16 +393,16 @@
 self.assertEqual(line.warnings, ['Test lacks BUG modifier.'])
 
 def test_skip_and_wontfix(self):
-# Skip and WontFix are not allowed to have other expectations as well, because those
+# Skip is not allowed to have other 

[webkit-changes] [139787] trunk/Source/WebKit/blackberry

[mifenton]

Title: [139787] trunk/Source/WebKit/blackberry








Revision 139787
Author mifen...@rim.com
Date 2013-01-15 14:04:29 -0800 (Tue, 15 Jan 2013)


Log Message
[BlackBerry] Don't overwrite field dir with current locale.
https://bugs.webkit.org/show_bug.cgi?id=106932

Reviewed by Yong Li.

PR 212267.

Remove uncalled onInputLocaleChanged and stop re-writing the dir
on input focus which prevented RTL fields from rendering properly.

Reviewed Internally by Eli Fidler.

* Api/WebPage.cpp:
* Api/WebPage.h:
* Api/WebPage_p.h:
(WebPagePrivate):
* WebKitSupport/InputHandler.cpp:
* WebKitSupport/InputHandler.h:
(InputHandler):

Modified Paths

trunk/Source/WebKit/blackberry/Api/WebPage.cpp
trunk/Source/WebKit/blackberry/Api/WebPage.h
trunk/Source/WebKit/blackberry/Api/WebPage_p.h
trunk/Source/WebKit/blackberry/ChangeLog
trunk/Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp
trunk/Source/WebKit/blackberry/WebKitSupport/InputHandler.h




Diff

Modified: trunk/Source/WebKit/blackberry/Api/WebPage.cpp (139786 => 139787)

--- trunk/Source/WebKit/blackberry/Api/WebPage.cpp	2013-01-15 22:03:13 UTC (rev 139786)
+++ trunk/Source/WebKit/blackberry/Api/WebPage.cpp	2013-01-15 22:04:29 UTC (rev 139787)
@@ -3517,19 +3517,6 @@
 zoomToInitialScaleOnLoad();
 }
 
-void WebPagePrivate::onInputLocaleChanged(bool isRTL)
-{
-if (isRTL != m_webSettings-isWritingDirectionRTL()) {
-m_webSettings-setWritingDirectionRTL(isRTL);
-m_inputHandler-handleInputLocaleChanged(isRTL);
-}
-}
-
-void WebPage::onInputLocaleChanged(bool isRTL)
-{
-d-onInputLocaleChanged(isRTL);
-}
-
 void WebPagePrivate::suspendBackingStore()
 {
 #if USE(ACCELERATED_COMPOSITING)


Modified: trunk/Source/WebKit/blackberry/Api/WebPage.h (139786 => 139787)

--- trunk/Source/WebKit/blackberry/Api/WebPage.h	2013-01-15 22:03:13 UTC (rev 139786)
+++ trunk/Source/WebKit/blackberry/Api/WebPage.h	2013-01-15 22:04:29 UTC (rev 139787)
@@ -264,7 +264,6 @@
 void setDateTimeInput(const BlackBerry::Platform::String value);
 void setColorInput(const BlackBerry::Platform::String value);
 
-void onInputLocaleChanged(bool isRTL);
 static void onNetworkAvailabilityChanged(bool available);
 static void onCertificateStoreLocationSet(const BlackBerry::Platform::String caPath);
 


Modified: trunk/Source/WebKit/blackberry/Api/WebPage_p.h (139786 => 139787)

--- trunk/Source/WebKit/blackberry/Api/WebPage_p.h	2013-01-15 22:03:13 UTC (rev 139786)
+++ trunk/Source/WebKit/blackberry/Api/WebPage_p.h	2013-01-15 22:04:29 UTC (rev 139787)
@@ -326,8 +326,6 @@
 
 void updateCursor();
 
-void onInputLocaleChanged(bool isRTL);
-
 ViewMode viewMode() const { return m_viewMode; }
 bool setViewMode(ViewMode); // Returns true if the change requires re-layout.
 


Modified: trunk/Source/WebKit/blackberry/ChangeLog (139786 => 139787)

--- trunk/Source/WebKit/blackberry/ChangeLog	2013-01-15 22:03:13 UTC (rev 139786)
+++ trunk/Source/WebKit/blackberry/ChangeLog	2013-01-15 22:04:29 UTC (rev 139787)
@@ -1,3 +1,25 @@
+2013-01-15  Mike Fenton  mifen...@rim.com
+
+[BlackBerry] Don't overwrite field dir with current locale.
+https://bugs.webkit.org/show_bug.cgi?id=106932
+
+Reviewed by Yong Li.
+
+PR 212267.
+
+Remove uncalled onInputLocaleChanged and stop re-writing the dir
+on input focus which prevented RTL fields from rendering properly.
+
+Reviewed Internally by Eli Fidler.
+
+* Api/WebPage.cpp:
+* Api/WebPage.h:
+* Api/WebPage_p.h:
+(WebPagePrivate):
+* WebKitSupport/InputHandler.cpp:
+* WebKitSupport/InputHandler.h:
+(InputHandler):
+
 2013-01-15  Jacky Jiang  zhaji...@rim.com
 
 [BlackBerry] Manual zoom propagates to next page load


Modified: trunk/Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp (139786 => 139787)

--- trunk/Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp	2013-01-15 22:03:13 UTC (rev 139786)
+++ trunk/Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp	2013-01-15 22:04:29 UTC (rev 139787)
@@ -1738,22 +1738,6 @@
 m_composingTextEnd = 0;
 }
 
-void InputHandler::handleInputLocaleChanged(bool isRTL)
-{
-if (!isActiveTextEdit())
-return;
-
-ASSERT(m_currentFocusElement-document()  m_currentFocusElement-document()-frame());
-RenderObject* renderer = m_currentFocusElement-renderer();
-if (!renderer)
-return;
-
-Editor* editor = m_currentFocusElement-document()-frame()-editor();
-ASSERT(editor);
-if ((renderer-style()-direction() == RTL) != isRTL)
-editor-setBaseWritingDirection(isRTL ? RightToLeftWritingDirection : LeftToRightWritingDirection);
-}
-
 void InputHandler::clearCurrentFocusElement()
 {
 if (m_currentFocusElement)


Modified: trunk/Source/WebKit/blackberry/WebKitSupport/InputHandler.h (139786 => 139787)

--- trunk/Source/WebKit/blackberry/WebKitSupport/InputHandler.h	2013-01-15 22:03:13 UTC (rev 139786)
+++ 

[webkit-changes] [139788] trunk

[esprehn]

Title: [139788] trunk








Revision 139788
Author espr...@chromium.org
Date 2013-01-15 14:14:29 -0800 (Tue, 15 Jan 2013)


Log Message
Heap-use-after-free in WebCore::RenderObject::willBeRemovedFromTree
https://bugs.webkit.org/show_bug.cgi?id=106384

Reviewed by Abhishek Arya.

Source/WebCore:

Always walk up from beforeChild until the parent() is the owner of the
child list, otherwise we can end up in situations where
newChild-parent() == owner but newChild-nextSibling()-parent() != owner
which is a recipe for security bugs. Previously we only walked up through
anonymous blocks, but missed anonymous inline blocks like those generated
by ruby.

Test: fast/css-generated-content/bug-106384.html

* rendering/RenderObjectChildList.cpp:
(WebCore::RenderObjectChildList::insertChildNode):

LayoutTests:

Add a test for ruby and generated content causing asserts and
crashes.

* fast/css-generated-content/bug-106384-expected.txt: Added.
* fast/css-generated-content/bug-106384.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderObjectChildList.cpp


Added Paths

trunk/LayoutTests/fast/css-generated-content/bug-106384-expected.txt
trunk/LayoutTests/fast/css-generated-content/bug-106384.html




Diff

Modified: trunk/LayoutTests/ChangeLog (139787 => 139788)

--- trunk/LayoutTests/ChangeLog	2013-01-15 22:04:29 UTC (rev 139787)
+++ trunk/LayoutTests/ChangeLog	2013-01-15 22:14:29 UTC (rev 139788)
@@ -1,3 +1,16 @@
+2013-01-15  Elliott Sprehn  espr...@chromium.org
+
+Heap-use-after-free in WebCore::RenderObject::willBeRemovedFromTree
+https://bugs.webkit.org/show_bug.cgi?id=106384
+
+Reviewed by Abhishek Arya.
+
+Add a test for ruby and generated content causing asserts and
+crashes.
+
+* fast/css-generated-content/bug-106384-expected.txt: Added.
+* fast/css-generated-content/bug-106384.html: Added.
+
 2013-01-15  Zan Dobersek  zdober...@igalia.com
 
 Unreviewed GTK gardening.


Added: trunk/LayoutTests/fast/css-generated-content/bug-106384-expected.txt (0 => 139788)

--- trunk/LayoutTests/fast/css-generated-content/bug-106384-expected.txt	(rev 0)
+++ trunk/LayoutTests/fast/css-generated-content/bug-106384-expected.txt	2013-01-15 22:14:29 UTC (rev 139788)
@@ -0,0 +1,3 @@
+Bug 106384: Heap-use-after-free in WebCore::RenderObject::willBeRemovedFromTree.
+
+Passed if this test did not crash or assert.


Added: trunk/LayoutTests/fast/css-generated-content/bug-106384.html (0 => 139788)

--- trunk/LayoutTests/fast/css-generated-content/bug-106384.html	(rev 0)
+++ trunk/LayoutTests/fast/css-generated-content/bug-106384.html	2013-01-15 22:14:29 UTC (rev 139788)
@@ -0,0 +1,25 @@
+!DOCTYPE html
+
+style
+ruby:after {
+display: block;
+content: ;
+}
+/style
+
+p
+Bug 106384: Heap-use-after-free in WebCore::RenderObject::willBeRemovedFromTree.
+/p
+
+script
+if (window.testRunner)
+testRunner.dumpAsText();
+
+_onload_ = function() {
+var ruby = document.createElement('ruby');
+document.body.appendChild(ruby);
+// Cause a layout.
+document.body.offsetLeft;
+ruby.appendChild(document.createTextNode('Passed if this test did not crash or assert.'));
+};
+/script


Modified: trunk/Source/WebCore/ChangeLog (139787 => 139788)

--- trunk/Source/WebCore/ChangeLog	2013-01-15 22:04:29 UTC (rev 139787)
+++ trunk/Source/WebCore/ChangeLog	2013-01-15 22:14:29 UTC (rev 139788)
@@ -1,3 +1,22 @@
+2013-01-15  Elliott Sprehn  espr...@chromium.org
+
+Heap-use-after-free in WebCore::RenderObject::willBeRemovedFromTree
+https://bugs.webkit.org/show_bug.cgi?id=106384
+
+Reviewed by Abhishek Arya.
+
+Always walk up from beforeChild until the parent() is the owner of the
+child list, otherwise we can end up in situations where
+newChild-parent() == owner but newChild-nextSibling()-parent() != owner
+which is a recipe for security bugs. Previously we only walked up through
+anonymous blocks, but missed anonymous inline blocks like those generated
+by ruby.
+
+Test: fast/css-generated-content/bug-106384.html
+
+* rendering/RenderObjectChildList.cpp:
+(WebCore::RenderObjectChildList::insertChildNode):
+
 2013-01-15  Ojan Vafai  o...@chromium.org
 
 Remove bogus assert added in http://trac.webkit.org/changeset/139772.


Modified: trunk/Source/WebCore/rendering/RenderObjectChildList.cpp (139787 => 139788)

--- trunk/Source/WebCore/rendering/RenderObjectChildList.cpp	2013-01-15 22:04:29 UTC (rev 139787)
+++ trunk/Source/WebCore/rendering/RenderObjectChildList.cpp	2013-01-15 22:14:29 UTC (rev 139788)
@@ -153,10 +153,17 @@
 }
 
 ASSERT(!child-parent());
-while (beforeChild-parent() != owner  beforeChild-parent()-isAnonymousBlock())
+while (beforeChild-parent()  beforeChild-parent() != owner)
 beforeChild = 

[webkit-changes] [139789] trunk

[ojan]

Title: [139789] trunk








Revision 139789
Author o...@chromium.org
Date 2013-01-15 14:15:35 -0800 (Tue, 15 Jan 2013)


Log Message
Unreviewed, rolling out r139782.
http://trac.webkit.org/changeset/139782
https://bugs.webkit.org/show_bug.cgi?id=106939

Source/WebCore:

Broke preferred widths on list markers.

* rendering/RenderListMarker.cpp:
(WebCore::RenderListMarker::layout):
(WebCore::RenderListMarker::computePreferredLogicalWidths):

LayoutTests:

* fast/lists/marker-preferred-margins-expected.txt: Added.
* fast/lists/marker-preferred-margins.html: Added.
Adding a new test to cover the case that broke.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderListMarker.cpp


Added Paths

trunk/LayoutTests/fast/lists/marker-preferred-margins-expected.txt
trunk/LayoutTests/fast/lists/marker-preferred-margins.html




Diff

Modified: trunk/LayoutTests/ChangeLog (139788 => 139789)

--- trunk/LayoutTests/ChangeLog	2013-01-15 22:14:29 UTC (rev 139788)
+++ trunk/LayoutTests/ChangeLog	2013-01-15 22:15:35 UTC (rev 139789)
@@ -1,3 +1,13 @@
+2013-01-15  Ojan Vafai  o...@chromium.org
+
+Unreviewed, rolling out r139782.
+http://trac.webkit.org/changeset/139782
+https://bugs.webkit.org/show_bug.cgi?id=106939
+
+* fast/lists/marker-preferred-margins-expected.txt: Added.
+* fast/lists/marker-preferred-margins.html: Added.
+Adding a new test to cover the case that broke.
+
 2013-01-15  Elliott Sprehn  espr...@chromium.org
 
 Heap-use-after-free in WebCore::RenderObject::willBeRemovedFromTree


Added: trunk/LayoutTests/fast/lists/marker-preferred-margins-expected.txt (0 => 139789)

--- trunk/LayoutTests/fast/lists/marker-preferred-margins-expected.txt	(rev 0)
+++ trunk/LayoutTests/fast/lists/marker-preferred-margins-expected.txt	2013-01-15 22:15:35 UTC (rev 139789)
@@ -0,0 +1,2 @@
+The list items should have no content.
+PASS


Added: trunk/LayoutTests/fast/lists/marker-preferred-margins.html (0 => 139789)

--- trunk/LayoutTests/fast/lists/marker-preferred-margins.html	(rev 0)
+++ trunk/LayoutTests/fast/lists/marker-preferred-margins.html	2013-01-15 22:15:35 UTC (rev 139789)
@@ -0,0 +1,23 @@
+!DOCTYPE html
+style
+li {
+float: left;
+border: 5px solid pink;
+}
+div {
+background-color: salmon;
+width: 20px;
+height: 20px;
+}
+/style
+The list items should have no content.
+
+ul style=border:2px solid blue;
+li data-expected-width=10/li
+li data-expected-width=10/li
+/ul
+
+script src=""
+script
+checkLayout('ul');
+/script
\ No newline at end of file


Modified: trunk/Source/WebCore/ChangeLog (139788 => 139789)

--- trunk/Source/WebCore/ChangeLog	2013-01-15 22:14:29 UTC (rev 139788)
+++ trunk/Source/WebCore/ChangeLog	2013-01-15 22:15:35 UTC (rev 139789)
@@ -1,3 +1,15 @@
+2013-01-15  Ojan Vafai  o...@chromium.org
+
+Unreviewed, rolling out r139782.
+http://trac.webkit.org/changeset/139782
+https://bugs.webkit.org/show_bug.cgi?id=106939
+
+Broke preferred widths on list markers.
+
+* rendering/RenderListMarker.cpp:
+(WebCore::RenderListMarker::layout):
+(WebCore::RenderListMarker::computePreferredLogicalWidths):
+
 2013-01-15  Elliott Sprehn  espr...@chromium.org
 
 Heap-use-after-free in WebCore::RenderObject::willBeRemovedFromTree


Modified: trunk/Source/WebCore/rendering/RenderListMarker.cpp (139788 => 139789)

--- trunk/Source/WebCore/rendering/RenderListMarker.cpp	2013-01-15 22:14:29 UTC (rev 139788)
+++ trunk/Source/WebCore/rendering/RenderListMarker.cpp	2013-01-15 22:15:35 UTC (rev 139789)
@@ -1316,8 +1316,6 @@
 {
 StackStats::LayoutCheckPoint layoutCheckPoint;
 ASSERT(needsLayout());
-
-updateMargins();
  
 if (isImage()) {
 setWidth(m_image-imageSize(this, style()-effectiveZoom()).width());
@@ -1369,6 +1367,7 @@
 LayoutSize imageSize = m_image-imageSize(this, style()-effectiveZoom());
 m_minPreferredLogicalWidth = m_maxPreferredLogicalWidth = style()-isHorizontalWritingMode() ? imageSize.width() : imageSize.height();
 setPreferredLogicalWidthsDirty(false);
+updateMargins();
 return;
 }
 
@@ -1479,6 +1478,8 @@
 m_maxPreferredLogicalWidth = logicalWidth;
 
 setPreferredLogicalWidthsDirty(false);
+
+updateMargins();
 }
 
 void RenderListMarker::updateMargins()






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [139790] trunk

[commit-queue]

Title: [139790] trunk








Revision 139790
Author commit-qu...@webkit.org
Date 2013-01-15 14:17:06 -0800 (Tue, 15 Jan 2013)


Log Message
HTML parser should queue MutationRecords for its operations
https://bugs.webkit.org/show_bug.cgi?id=89351

Patch by Elliott Sprehn espr...@gmail.com on 2013-01-15
Reviewed by Eric Seidel.

Source/WebCore:

Generate mutation records inside the parser. This is done by using a
ChildListMutationScope in the ContainerNode::parser* methods and then
adding delivery before each script element would be processed by
the parser.

Test: fast/dom/MutationObserver/parser-mutations.html

* dom/ContainerNode.cpp:
(WebCore::ContainerNode::parserInsertBefore):
(WebCore::ContainerNode::parserRemoveChild):
(WebCore::ContainerNode::parserAppendChild):
* html/parser/HTMLScriptRunner.cpp:
(WebCore::HTMLScriptRunner::executeParsingBlockingScript):
(WebCore::HTMLScriptRunner::executePendingScriptAndDispatchEvent):
(WebCore::HTMLScriptRunner::execute):
(WebCore::HTMLScriptRunner::executeScriptsWaitingForLoad):
(WebCore::HTMLScriptRunner::executeScriptsWaitingForStylesheets):
(WebCore::HTMLScriptRunner::executeScriptsWaitingForParsing):
(WebCore::HTMLScriptRunner::runScript):

LayoutTests:

Add tests for parser generated mutations.

XXX: This needs a bunch more tests observing the adoption
agency algorithm to catch parserInsertBefore and parserRemoveChild
mutations.

* fast/dom/MutationObserver/parser-mutations-expected.txt: Added.
* fast/dom/MutationObserver/parser-mutations.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/ContainerNode.cpp
trunk/Source/WebCore/html/parser/HTMLScriptRunner.cpp


Added Paths

trunk/LayoutTests/fast/dom/MutationObserver/parser-mutations-expected.txt
trunk/LayoutTests/fast/dom/MutationObserver/parser-mutations.html




Diff

Modified: trunk/LayoutTests/ChangeLog (139789 => 139790)

--- trunk/LayoutTests/ChangeLog	2013-01-15 22:15:35 UTC (rev 139789)
+++ trunk/LayoutTests/ChangeLog	2013-01-15 22:17:06 UTC (rev 139790)
@@ -1,3 +1,19 @@
+2013-01-15  Elliott Sprehn  espr...@gmail.com
+
+HTML parser should queue MutationRecords for its operations
+https://bugs.webkit.org/show_bug.cgi?id=89351
+
+Reviewed by Eric Seidel.
+
+Add tests for parser generated mutations.
+
+XXX: This needs a bunch more tests observing the adoption
+agency algorithm to catch parserInsertBefore and parserRemoveChild
+mutations.
+
+* fast/dom/MutationObserver/parser-mutations-expected.txt: Added.
+* fast/dom/MutationObserver/parser-mutations.html: Added.
+
 2013-01-15  Ojan Vafai  o...@chromium.org
 
 Unreviewed, rolling out r139782.


Added: trunk/LayoutTests/fast/dom/MutationObserver/parser-mutations-expected.txt (0 => 139790)

--- trunk/LayoutTests/fast/dom/MutationObserver/parser-mutations-expected.txt	(rev 0)
+++ trunk/LayoutTests/fast/dom/MutationObserver/parser-mutations-expected.txt	2013-01-15 22:17:06 UTC (rev 139790)
@@ -0,0 +1,6 @@
+PASS mutations.length is 6
+PASS mutations[1].type is childList
+PASS mutations[1].target.tagName is BODY
+PASS mutations[1].addedNodes.length is 1
+PASS mutations[1].addedNodes[0].tagName is P
+Mutation records should be delivered for all parser mutations after the above script.


Added: trunk/LayoutTests/fast/dom/MutationObserver/parser-mutations.html (0 => 139790)

--- trunk/LayoutTests/fast/dom/MutationObserver/parser-mutations.html	(rev 0)
+++ trunk/LayoutTests/fast/dom/MutationObserver/parser-mutations.html	2013-01-15 22:17:06 UTC (rev 139790)
@@ -0,0 +1,27 @@
+!DOCTYPE html
+
+body
+script src=""
+
+script
+if (window.testRunner)
+testRunner.dumpAsText();
+
+var observer = new WebKitMutationObserver(function(mutations, observer) {
+window.mutations = mutations;
+});
+observer.observe(document.body, {childList: true, subtree:true});
+/script
+
+p
+Mutation records should be delivered for all parser mutations after the above script.
+/p
+
+script
+shouldBe('mutations.length', '6');
+shouldBeEqualToString('mutations[1].type', 'childList');
+shouldBeEqualToString('mutations[1].target.tagName', 'BODY');
+shouldBe('mutations[1].addedNodes.length', '1');
+shouldBeEqualToString('mutations[1].addedNodes[0].tagName', 'P');
+/script
+/body
\ No newline at end of file


Modified: trunk/Source/WebCore/ChangeLog (139789 => 139790)

--- trunk/Source/WebCore/ChangeLog	2013-01-15 22:15:35 UTC (rev 139789)
+++ trunk/Source/WebCore/ChangeLog	2013-01-15 22:17:06 UTC (rev 139790)
@@ -1,3 +1,30 @@
+2013-01-15  Elliott Sprehn  espr...@gmail.com
+
+HTML parser should queue MutationRecords for its operations
+https://bugs.webkit.org/show_bug.cgi?id=89351
+
+Reviewed by Eric Seidel.
+
+Generate mutation records inside the parser. This is done by using a
+ChildListMutationScope in the 

[webkit-changes] [139791] trunk/Source/WebKit2

[andersca]

Title: [139791] trunk/Source/WebKit2








Revision 139791
Author ander...@apple.com
Date 2013-01-15 14:20:51 -0800 (Tue, 15 Jan 2013)


Log Message
Rename LayerTreeHostCAMac to LayerTreeHostMac.

Rubber-stamped by Deth Bakin.

* WebKit2.xcodeproj/project.pbxproj:
* WebProcess/WebPage/LayerTreeHost.cpp:
* WebProcess/WebPage/mac/LayerTreeHostMac.h: Renamed from Source/WebKit2/WebProcess/WebPage/ca/mac/LayerTreeHostCAMac.h.
* WebProcess/WebPage/mac/LayerTreeHostMac.mm: Renamed from Source/WebKit2/WebProcess/WebPage/ca/mac/LayerTreeHostCAMac.mm.

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/WebKit2.xcodeproj/project.pbxproj
trunk/Source/WebKit2/WebProcess/WebPage/LayerTreeHost.cpp


Added Paths

trunk/Source/WebKit2/WebProcess/WebPage/mac/LayerTreeHostMac.h
trunk/Source/WebKit2/WebProcess/WebPage/mac/LayerTreeHostMac.mm


Removed Paths

trunk/Source/WebKit2/WebProcess/WebPage/ca/mac/LayerTreeHostCAMac.h
trunk/Source/WebKit2/WebProcess/WebPage/ca/mac/LayerTreeHostCAMac.mm




Diff

Modified: trunk/Source/WebKit2/ChangeLog (139790 => 139791)

--- trunk/Source/WebKit2/ChangeLog	2013-01-15 22:17:06 UTC (rev 139790)
+++ trunk/Source/WebKit2/ChangeLog	2013-01-15 22:20:51 UTC (rev 139791)
@@ -1,3 +1,14 @@
+2013-01-15  Anders Carlsson  ander...@apple.com
+
+Rename LayerTreeHostCAMac to LayerTreeHostMac.
+
+Rubber-stamped by Deth Bakin.
+
+* WebKit2.xcodeproj/project.pbxproj:
+* WebProcess/WebPage/LayerTreeHost.cpp:
+* WebProcess/WebPage/mac/LayerTreeHostMac.h: Renamed from Source/WebKit2/WebProcess/WebPage/ca/mac/LayerTreeHostCAMac.h.
+* WebProcess/WebPage/mac/LayerTreeHostMac.mm: Renamed from Source/WebKit2/WebProcess/WebPage/ca/mac/LayerTreeHostCAMac.mm.
+
 2013-01-15  Dominik Röttsches  dominik.rottsc...@intel.com
 
 [CoordinatedGraphics] Deadlock when running abspos-child-container-changes-from-relative-to-static.html


Modified: trunk/Source/WebKit2/WebKit2.xcodeproj/project.pbxproj (139790 => 139791)

--- trunk/Source/WebKit2/WebKit2.xcodeproj/project.pbxproj	2013-01-15 22:17:06 UTC (rev 139790)
+++ trunk/Source/WebKit2/WebKit2.xcodeproj/project.pbxproj	2013-01-15 22:20:51 UTC (rev 139791)
@@ -194,6 +194,8 @@
 		1A91010B1268C8CA001842F5 /* FindIndicatorWindow.mm in Sources */ = {isa = PBXBuildFile; fileRef = 1A9101091268C8CA001842F5 /* FindIndicatorWindow.mm */; };
 		1A92DC1112F8BA460017AF65 /* LayerTreeContext.h in Headers */ = {isa = PBXBuildFile; fileRef = 1A92DC1012F8BA460017AF65 /* LayerTreeContext.h */; };
 		1A92DC1312F8BAB90017AF65 /* LayerTreeContextMac.mm in Sources */ = {isa = PBXBuildFile; fileRef = 1A92DC1212F8BAB90017AF65 /* LayerTreeContextMac.mm */; };
+		1A97E07616A5F9EBC9E5 /* LayerTreeHostMac.h in Headers */ = {isa = PBXBuildFile; fileRef = 1A97E07316A5F578000BC9E5 /* LayerTreeHostMac.h */; };
+		1A97E07716A5F9EBC9E5 /* LayerTreeHostMac.mm in Sources */ = {isa = PBXBuildFile; fileRef = 1A97E07416A5F578000BC9E5 /* LayerTreeHostMac.mm */; };
 		1A9FBA8D13FF04E600DEED67 /* PluginComplexTextInputState.h in Headers */ = {isa = PBXBuildFile; fileRef = 1A9FBA8C13FF04E600DEED67 /* PluginComplexTextInputState.h */; };
 		1AA2E51D12E4C05E00BC4966 /* CGUtilities.h in Headers */ = {isa = PBXBuildFile; fileRef = 1AA2E51B12E4C05E00BC4966 /* CGUtilities.h */; };
 		1AA2E51E12E4C05E00BC4966 /* CGUtilities.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 1AA2E51C12E4C05E00BC4966 /* CGUtilities.cpp */; };
@@ -986,7 +988,6 @@
 		C0337DD3127A2A0E008FF4F4 /* WebKeyboardEvent.cpp in Sources */ = {isa = PBXBuildFile; fileRef = C0337DD2127A2A0E008FF4F4 /* WebKeyboardEvent.cpp */; };
 		C0337DD8127A51B6008FF4F4 /* WebTouchEvent.cpp in Sources */ = {isa = PBXBuildFile; fileRef = C0337DD7127A51B6008FF4F4 /* WebTouchEvent.cpp */; };
 		C0337DDD127A521C008FF4F4 /* WebPlatformTouchPoint.cpp in Sources */ = {isa = PBXBuildFile; fileRef = C0337DDC127A521C008FF4F4 /* WebPlatformTouchPoint.cpp */; };
-		C03A136C133BEBF900D767D1 /* LayerTreeHostCAMac.mm in Sources */ = {isa = PBXBuildFile; fileRef = C03A136B133BEBF900D767D1 /* LayerTreeHostCAMac.mm */; };
 		C064504A133BE709003470E2 /* LayerTreeHostCA.h in Headers */ = {isa = PBXBuildFile; fileRef = C098A053133BE1C500B199A4 /* LayerTreeHostCA.h */; };
 		C06C6095124C144B0001682F /* WebPageCreationParameters.cpp in Sources */ = {isa = PBXBuildFile; fileRef = C06C6093124C14430001682F /* WebPageCreationParameters.cpp */; };
 		C09AE5E9125257C20025825D /* WKNativeEvent.h in Headers */ = {isa = PBXBuildFile; fileRef = C09AE5E8125257C20025825D /* WKNativeEvent.h */; settings = {ATTRIBUTES = (Private, ); }; };
@@ -997,7 +998,6 @@
 		C0E3AA7A1209E83000A49D01 /* ModuleMac.mm in Sources */ = {isa = PBXBuildFile; fileRef = C0E3AA481209E45000A49D01 /* ModuleMac.mm */; };
 		C0E3AA7B1209E83500A49D01 /* Module.cpp in Sources */ = {isa = PBXBuildFile; fileRef = C0E3AA451209E2BA00A49D01 /* Module.cpp */; };
 		C0E3AA7C1209E83C00A49D01 /* Module.h in Headers */ = {isa = PBXBuildFile; fileRef = 

[webkit-changes] [139792] trunk/Tools

[jochen]

Title: [139792] trunk/Tools








Revision 139792
Author joc...@chromium.org
Date 2013-01-15 14:21:43 -0800 (Tue, 15 Jan 2013)


Log Message
[chromium] route more webkit_support and webviewhost callbacks through WebTestDelegate
https://bugs.webkit.org/show_bug.cgi?id=106904

Reviewed by Adam Barth.

* DumpRenderTree/chromium/DRTTestRunner.cpp:
(DRTTestRunner::DRTTestRunner):
(DRTTestRunner::notifyDone):
(DRTTestRunner::reset):
* DumpRenderTree/chromium/DRTTestRunner.h:
(DRTTestRunner):
* DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
(WebTestRunner::WebTestDelegate::setDeviceScaleFactor):
(WebTestRunner::WebTestDelegate::setFocus):
(WebTestRunner::WebTestDelegate::setAcceptAllCookies):
(WebTestRunner::WebTestDelegate::pathToLocalResource):
(WebTestRunner::WebTestDelegate::setLocale):
* DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
(WebTestRunner::TestRunner::TestRunner):
(WebTestRunner::TestRunner::reset):
(WebTestRunner::TestRunner::setAlwaysAcceptCookies):
(WebTestRunner):
(WebTestRunner::TestRunner::setWindowIsKey):
(WebTestRunner::TestRunner::pathToLocalResource):
(WebTestRunner::TestRunner::setBackingScaleFactor):
(WebTestRunner::TestRunner::setPOSIXLocale):
* DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
(WebTestRunner::TestRunner::taskList):
(TestRunner):
* DumpRenderTree/chromium/WebViewHost.cpp:
(WebViewHost::setDeviceScaleFactor):
(WebViewHost::setFocus):
(WebViewHost::setAcceptAllCookies):
(WebViewHost::pathToLocalResource):
(WebViewHost::setLocale):
* DumpRenderTree/chromium/WebViewHost.h:
(WebViewHost):

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/DumpRenderTree/chromium/DRTTestRunner.cpp
trunk/Tools/DumpRenderTree/chromium/DRTTestRunner.h
trunk/Tools/DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h
trunk/Tools/DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp
trunk/Tools/DumpRenderTree/chromium/TestRunner/src/TestRunner.h
trunk/Tools/DumpRenderTree/chromium/WebViewHost.cpp
trunk/Tools/DumpRenderTree/chromium/WebViewHost.h




Diff

Modified: trunk/Tools/ChangeLog (139791 => 139792)

--- trunk/Tools/ChangeLog	2013-01-15 22:20:51 UTC (rev 139791)
+++ trunk/Tools/ChangeLog	2013-01-15 22:21:43 UTC (rev 139792)
@@ -1,3 +1,43 @@
+2013-01-15  Jochen Eisinger  joc...@chromium.org
+
+[chromium] route more webkit_support and webviewhost callbacks through WebTestDelegate
+https://bugs.webkit.org/show_bug.cgi?id=106904
+
+Reviewed by Adam Barth.
+
+* DumpRenderTree/chromium/DRTTestRunner.cpp:
+(DRTTestRunner::DRTTestRunner):
+(DRTTestRunner::notifyDone):
+(DRTTestRunner::reset):
+* DumpRenderTree/chromium/DRTTestRunner.h:
+(DRTTestRunner):
+* DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
+(WebTestRunner::WebTestDelegate::setDeviceScaleFactor):
+(WebTestRunner::WebTestDelegate::setFocus):
+(WebTestRunner::WebTestDelegate::setAcceptAllCookies):
+(WebTestRunner::WebTestDelegate::pathToLocalResource):
+(WebTestRunner::WebTestDelegate::setLocale):
+* DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
+(WebTestRunner::TestRunner::TestRunner):
+(WebTestRunner::TestRunner::reset):
+(WebTestRunner::TestRunner::setAlwaysAcceptCookies):
+(WebTestRunner):
+(WebTestRunner::TestRunner::setWindowIsKey):
+(WebTestRunner::TestRunner::pathToLocalResource):
+(WebTestRunner::TestRunner::setBackingScaleFactor):
+(WebTestRunner::TestRunner::setPOSIXLocale):
+* DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
+(WebTestRunner::TestRunner::taskList):
+(TestRunner):
+* DumpRenderTree/chromium/WebViewHost.cpp:
+(WebViewHost::setDeviceScaleFactor):
+(WebViewHost::setFocus):
+(WebViewHost::setAcceptAllCookies):
+(WebViewHost::pathToLocalResource):
+(WebViewHost::setLocale):
+* DumpRenderTree/chromium/WebViewHost.h:
+(WebViewHost):
+
 2013-01-15  Zan Dobersek  zdober...@igalia.com
 
 Tests with WontFix expectation are (indirectly) skipped


Modified: trunk/Tools/DumpRenderTree/chromium/DRTTestRunner.cpp (139791 => 139792)

--- trunk/Tools/DumpRenderTree/chromium/DRTTestRunner.cpp	2013-01-15 22:20:51 UTC (rev 139791)
+++ trunk/Tools/DumpRenderTree/chromium/DRTTestRunner.cpp	2013-01-15 22:21:43 UTC (rev 139792)
@@ -68,7 +68,6 @@
 #include webkit/support/webkit_support.h
 #include algorithm
 #include cctype
-#include clocale
 #include cstdlib
 #include limits
 #include sstream
@@ -116,7 +115,6 @@
 #endif
 bindMethod(notifyDone, DRTTestRunner::notifyDone);
 bindMethod(numberOfPendingGeolocationPermissionRequests, DRTTestRunner:: numberOfPendingGeolocationPermissionRequests);
-bindMethod(pathToLocalResource, DRTTestRunner::pathToLocalResource);
 bindMethod(queueBackNavigation, DRTTestRunner::queueBackNavigation);
 bindMethod(queueForwardNavigation, 

[webkit-changes] [139793] trunk/LayoutTests

[jsbell]

Title: [139793] trunk/LayoutTests








Revision 139793
Author jsb...@chromium.org
Date 2013-01-15 14:27:58 -0800 (Tue, 15 Jan 2013)


Log Message
IndexedDB: Fix tests which depend upon V8 event listener behavior
https://bugs.webkit.org/show_bug.cgi?id=106731

Ensure consistent use of callback(evt) { preamble(evt); ... } pattern, which addresses
running in JSC and in V8 under Workers. Also add worker test wrappers.

Reviewed by Tony Chang.

* storage/indexeddb/cursor-advance-expected.txt:
* storage/indexeddb/cursor-advance-workers-expected.txt: Added.
* storage/indexeddb/cursor-advance-workers.html: Added.
* storage/indexeddb/deletedatabase-delayed-by-open-and-versionchange-expected.txt:
* storage/indexeddb/deletedatabase-delayed-by-open-and-versionchange-workers-expected.txt: Added.
* storage/indexeddb/deletedatabase-delayed-by-open-and-versionchange-workers.html: Added.
* storage/indexeddb/resources/cursor-advance.js:
(prepareDatabase):
(testPrefetchInRange.prefetch):
(testPrefetchInRange):
(testPrefetchOutOfRange.prefetch):
(testPrefetchOutOfRange):
(testBadAdvance.advanceBadly):
(testBadAdvance):
(testEdges.request.onsuccess):
(testEdges):
(testDelete.deleteSecond):
(testDelete):
* storage/indexeddb/resources/deletedatabase-delayed-by-open-and-versionchange.js:
(onOpenSuccess):

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/storage/indexeddb/cursor-advance-expected.txt
trunk/LayoutTests/storage/indexeddb/deletedatabase-delayed-by-open-and-versionchange-expected.txt
trunk/LayoutTests/storage/indexeddb/resources/cursor-advance.js
trunk/LayoutTests/storage/indexeddb/resources/deletedatabase-delayed-by-open-and-versionchange.js


Added Paths

trunk/LayoutTests/storage/indexeddb/cursor-advance-workers-expected.txt
trunk/LayoutTests/storage/indexeddb/cursor-advance-workers.html
trunk/LayoutTests/storage/indexeddb/deletedatabase-delayed-by-open-and-versionchange-workers-expected.txt
trunk/LayoutTests/storage/indexeddb/deletedatabase-delayed-by-open-and-versionchange-workers.html




Diff

Modified: trunk/LayoutTests/ChangeLog (139792 => 139793)

--- trunk/LayoutTests/ChangeLog	2013-01-15 22:21:43 UTC (rev 139792)
+++ trunk/LayoutTests/ChangeLog	2013-01-15 22:27:58 UTC (rev 139793)
@@ -1,3 +1,34 @@
+2013-01-15  Joshua Bell  jsb...@chromium.org
+
+IndexedDB: Fix tests which depend upon V8 event listener behavior
+https://bugs.webkit.org/show_bug.cgi?id=106731
+
+Ensure consistent use of callback(evt) { preamble(evt); ... } pattern, which addresses
+running in JSC and in V8 under Workers. Also add worker test wrappers.
+
+Reviewed by Tony Chang.
+
+* storage/indexeddb/cursor-advance-expected.txt:
+* storage/indexeddb/cursor-advance-workers-expected.txt: Added.
+* storage/indexeddb/cursor-advance-workers.html: Added.
+* storage/indexeddb/deletedatabase-delayed-by-open-and-versionchange-expected.txt:
+* storage/indexeddb/deletedatabase-delayed-by-open-and-versionchange-workers-expected.txt: Added.
+* storage/indexeddb/deletedatabase-delayed-by-open-and-versionchange-workers.html: Added.
+* storage/indexeddb/resources/cursor-advance.js:
+(prepareDatabase):
+(testPrefetchInRange.prefetch):
+(testPrefetchInRange):
+(testPrefetchOutOfRange.prefetch):
+(testPrefetchOutOfRange):
+(testBadAdvance.advanceBadly):
+(testBadAdvance):
+(testEdges.request.onsuccess):
+(testEdges):
+(testDelete.deleteSecond):
+(testDelete):
+* storage/indexeddb/resources/deletedatabase-delayed-by-open-and-versionchange.js:
+(onOpenSuccess):
+
 2013-01-15  Elliott Sprehn  espr...@gmail.com
 
 HTML parser should queue MutationRecords for its operations


Modified: trunk/LayoutTests/storage/indexeddb/cursor-advance-expected.txt (139792 => 139793)

--- trunk/LayoutTests/storage/indexeddb/cursor-advance-expected.txt	2013-01-15 22:21:43 UTC (rev 139792)
+++ trunk/LayoutTests/storage/indexeddb/cursor-advance-expected.txt	2013-01-15 22:27:58 UTC (rev 139793)
@@ -8,6 +8,8 @@
 dbname = cursor-advance.html
 indexedDB.deleteDatabase(dbname)
 indexedDB.open(dbname)
+
+prepareDatabase():
 objectStore = db.createObjectStore(objectStoreName);
 Now create the indexes.
 objectStore.createIndex(indexData[i].name, indexData[i].keyPath, indexData[i].options);
@@ -84,52 +86,96 @@
 trans = db.transaction(objectStoreName)
 objectStore = trans.objectStore(objectStoreName)
 request = objectStore.openCursor()
+
+prefetch():
 PASS expected is {\key\:\237-23-7732\,\value\:{\name\:\Bob\,\height\:60,\weight\:120},\primaryKey\:\237-23-7732\}
 cursor.continue()
+
+prefetch():
 PASS expected is {\key\:\237-23-7733\,\value\:{\name\:\Ann\,\height\:52,\weight\:110},\primaryKey\:\237-23-7733\}
 cursor.continue()
+
+prefetch():
 PASS expected is {\key\:\237-23-7734\,\value\:{\name\:\Ron\,\height\:73,\weight\:180},\primaryKey\:\237-23-7734\}
 cursor.continue()

[webkit-changes] [139795] trunk/Tools

[leviw]

Title: [139795] trunk/Tools








Revision 139795
Author le...@chromium.org
Date 2013-01-15 14:46:47 -0800 (Tue, 15 Jan 2013)


Log Message
[chromium] route more webkit_support and webviewhost callbacks through WebTestDelegate
https://bugs.webkit.org/show_bug.cgi?id=106904

Reverting 139794. It broke the build. It appears that a header file,
WebTextDirection.h, was left out.

* DumpRenderTree/chromium/DRTTestRunner.cpp:
(DRTTestRunner::DRTTestRunner):
(DRTTestRunner::reset):
* DumpRenderTree/chromium/DRTTestRunner.h:
(DRTTestRunner::setTitleTextDirection):
* DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
(WebTestRunner::WebTestRunner::shouldStayOnPageAfterHandlingBeforeUnload):
* DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
(WebTestRunner::TestRunner::TestRunner):
(WebTestRunner::TestRunner::reset):
(WebTestRunner::TestRunner::shouldStayOnPageAfterHandlingBeforeUnload):
* DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
(TestRunner):
* DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
(WebTestRunner::WebTestProxyBase::didReceiveTitle):
* DumpRenderTree/chromium/WebViewHost.cpp:
(WebViewHost::didReceiveTitle):

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/DumpRenderTree/chromium/DRTTestRunner.cpp
trunk/Tools/DumpRenderTree/chromium/DRTTestRunner.h
trunk/Tools/DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h
trunk/Tools/DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp
trunk/Tools/DumpRenderTree/chromium/TestRunner/src/TestRunner.h
trunk/Tools/DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp
trunk/Tools/DumpRenderTree/chromium/WebViewHost.cpp




Diff

Modified: trunk/Tools/ChangeLog (139794 => 139795)

--- trunk/Tools/ChangeLog	2013-01-15 22:30:54 UTC (rev 139794)
+++ trunk/Tools/ChangeLog	2013-01-15 22:46:47 UTC (rev 139795)
@@ -1,3 +1,29 @@
+2013-01-15  Levi Weintraub  le...@chromium.org
+
+[chromium] route more webkit_support and webviewhost callbacks through WebTestDelegate
+https://bugs.webkit.org/show_bug.cgi?id=106904
+
+Reverting 139794. It broke the build. It appears that a header file,
+WebTextDirection.h, was left out.
+
+* DumpRenderTree/chromium/DRTTestRunner.cpp:
+(DRTTestRunner::DRTTestRunner):
+(DRTTestRunner::reset):
+* DumpRenderTree/chromium/DRTTestRunner.h:
+(DRTTestRunner::setTitleTextDirection):
+* DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
+(WebTestRunner::WebTestRunner::shouldStayOnPageAfterHandlingBeforeUnload):
+* DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
+(WebTestRunner::TestRunner::TestRunner):
+(WebTestRunner::TestRunner::reset):
+(WebTestRunner::TestRunner::shouldStayOnPageAfterHandlingBeforeUnload):
+* DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
+(TestRunner):
+* DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
+(WebTestRunner::WebTestProxyBase::didReceiveTitle):
+* DumpRenderTree/chromium/WebViewHost.cpp:
+(WebViewHost::didReceiveTitle):
+
 2013-01-15  Jochen Eisinger  joc...@chromium.org
 
 [chromium] route more webkit_support and webviewhost callbacks through WebTestDelegate


Modified: trunk/Tools/DumpRenderTree/chromium/DRTTestRunner.cpp (139794 => 139795)

--- trunk/Tools/DumpRenderTree/chromium/DRTTestRunner.cpp	2013-01-15 22:30:54 UTC (rev 139794)
+++ trunk/Tools/DumpRenderTree/chromium/DRTTestRunner.cpp	2013-01-15 22:46:47 UTC (rev 139795)
@@ -146,6 +146,7 @@
 // Shared properties.
 // webHistoryItemCount is used by tests in LayoutTests\http\tests\history
 bindProperty(webHistoryItemCount, m_webHistoryItemCount);
+bindProperty(titleTextDirection, m_titleTextDirection);
 bindProperty(interceptPostMessage, m_interceptPostMessage);
 }
 
@@ -385,6 +386,7 @@
 TestRunner::reset();
 m_waitUntilDone = false;
 m_webHistoryItemCount.set(0);
+m_titleTextDirection.set(ltr);
 m_interceptPostMessage.set(false);
 
 if (m_closeRemainingWindows)


Modified: trunk/Tools/DumpRenderTree/chromium/DRTTestRunner.h (139794 => 139795)

--- trunk/Tools/DumpRenderTree/chromium/DRTTestRunner.h	2013-01-15 22:30:54 UTC (rev 139794)
+++ trunk/Tools/DumpRenderTree/chromium/DRTTestRunner.h	2013-01-15 22:46:47 UTC (rev 139795)
@@ -44,6 +44,7 @@
 
 #include TestRunner/src/TestRunner.h
 #include WebTask.h
+#include WebTextDirection.h
 #include platform/WebArrayBufferView.h
 #include platform/WebString.h
 #include platform/WebURL.h
@@ -156,6 +157,10 @@
 void setWorkQueueFrozen(bool frozen) { m_workQueue.setFrozen(frozen); }
 
 void setShowDebugLayerTree(bool value) { m_showDebugLayerTree = value; }
+void setTitleTextDirection(WebKit::WebTextDirection dir)
+{
+m_titleTextDirection.set(dir == WebKit::WebTextDirectionLeftToRight ? ltr : rtl);
+}
 
 bool shouldInterceptPostMessage()
 {
@@ -242,6 +247,9 @@
 // Bound variable counting the number of 

[webkit-changes] [139797] trunk/Source/WebCore

[simon . fraser]

Title: [139797] trunk/Source/WebCore








Revision 139797
Author simon.fra...@apple.com
Date 2013-01-15 15:17:01 -0800 (Tue, 15 Jan 2013)


Log Message
Rename RenderLayerBacking's m_containmentLayer to m_childContainmentLayer to better describe its purpose
https://bugs.webkit.org/show_bug.cgi?id=106947

Reviewed by Dean Jackson.

Simple rename of m_containmentLayer to m_childContainmentLayer. I'll
be adding another container layer for background layers shortly,
and wanted to improve clarity.

* rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::createPrimaryGraphicsLayer):
(WebCore::RenderLayerBacking::destroyGraphicsLayers):
(WebCore::RenderLayerBacking::updateInternalHierarchy):
(WebCore::RenderLayerBacking::updateClippingLayers):
(WebCore::RenderLayerBacking::parentForSublayers):
(WebCore::RenderLayerBacking::backingStoreMemoryEstimate):
(WebCore::RenderLayerBacking::reportMemoryUsage):
* rendering/RenderLayerBacking.h:
(WebCore::RenderLayerBacking::hasClippingLayer):
(WebCore::RenderLayerBacking::clippingLayer):
(WebCore::RenderLayerBacking::hasTileCacheFlatteningLayer):
(WebCore::RenderLayerBacking::tileCacheFlatteningLayer):
(RenderLayerBacking):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderLayerBacking.cpp
trunk/Source/WebCore/rendering/RenderLayerBacking.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (139796 => 139797)

--- trunk/Source/WebCore/ChangeLog	2013-01-15 23:00:59 UTC (rev 139796)
+++ trunk/Source/WebCore/ChangeLog	2013-01-15 23:17:01 UTC (rev 139797)
@@ -1,3 +1,29 @@
+2013-01-15  Simon Fraser  simon.fra...@apple.com
+
+Rename RenderLayerBacking's m_containmentLayer to m_childContainmentLayer to better describe its purpose
+https://bugs.webkit.org/show_bug.cgi?id=106947
+
+Reviewed by Dean Jackson.
+
+Simple rename of m_containmentLayer to m_childContainmentLayer. I'll
+be adding another container layer for background layers shortly,
+and wanted to improve clarity.
+
+* rendering/RenderLayerBacking.cpp:
+(WebCore::RenderLayerBacking::createPrimaryGraphicsLayer):
+(WebCore::RenderLayerBacking::destroyGraphicsLayers):
+(WebCore::RenderLayerBacking::updateInternalHierarchy):
+(WebCore::RenderLayerBacking::updateClippingLayers):
+(WebCore::RenderLayerBacking::parentForSublayers):
+(WebCore::RenderLayerBacking::backingStoreMemoryEstimate):
+(WebCore::RenderLayerBacking::reportMemoryUsage):
+* rendering/RenderLayerBacking.h:
+(WebCore::RenderLayerBacking::hasClippingLayer):
+(WebCore::RenderLayerBacking::clippingLayer):
+(WebCore::RenderLayerBacking::hasTileCacheFlatteningLayer):
+(WebCore::RenderLayerBacking::tileCacheFlatteningLayer):
+(RenderLayerBacking):
+
 2013-01-15  Enrica Casucci  enr...@apple.com
 
 Add a new set of WebKit2 APIs for text search and


Modified: trunk/Source/WebCore/rendering/RenderLayerBacking.cpp (139796 => 139797)

--- trunk/Source/WebCore/rendering/RenderLayerBacking.cpp	2013-01-15 23:00:59 UTC (rev 139796)
+++ trunk/Source/WebCore/rendering/RenderLayerBacking.cpp	2013-01-15 23:17:01 UTC (rev 139797)
@@ -264,7 +264,7 @@
 m_creatingPrimaryGraphicsLayer = false;
 
 if (m_usingTiledCacheLayer)
-m_containmentLayer = createGraphicsLayer(TileCache Flattening Layer);
+m_childContainmentLayer = createGraphicsLayer(TileCache Flattening Layer);
 
 if (m_isMainFrameRenderViewLayer) {
 bool hasOpaqueBackground = false;
@@ -298,9 +298,10 @@
 if (m_graphicsLayer)
 m_graphicsLayer-removeFromParent();
 
+m_ancestorClippingLayer = nullptr;
 m_graphicsLayer = nullptr;
 m_foregroundLayer = nullptr;
-m_containmentLayer = nullptr;
+m_childContainmentLayer = nullptr;
 m_maskLayer = nullptr;
 
 m_scrollingLayer = nullptr;
@@ -781,13 +782,13 @@
 m_ancestorClippingLayer-addChild(m_graphicsLayer.get());
 }
 
-if (m_containmentLayer) {
-m_containmentLayer-removeFromParent();
-m_graphicsLayer-addChild(m_containmentLayer.get());
+if (m_childContainmentLayer) {
+m_childContainmentLayer-removeFromParent();
+m_graphicsLayer-addChild(m_childContainmentLayer.get());
 }
 
 if (m_scrollingLayer) {
-GraphicsLayer* superlayer = m_containmentLayer ? m_containmentLayer.get() : m_graphicsLayer.get();
+GraphicsLayer* superlayer = m_childContainmentLayer ? m_childContainmentLayer.get() : m_graphicsLayer.get();
 m_scrollingLayer-removeFromParent();
 superlayer-addChild(m_scrollingLayer.get());
 }
@@ -866,14 +867,14 @@
 }
 
 if (needsDescendantClip) {
-if (!m_containmentLayer  !m_usingTiledCacheLayer) {
-m_containmentLayer = createGraphicsLayer(Child clipping Layer);
-m_containmentLayer-setMasksToBounds(true);
+if (!m_childContainmentLayer  

[webkit-changes] [139798] trunk

[eae]

Title: [139798] trunk








Revision 139798
Author e...@chromium.org
Date 2013-01-15 15:21:34 -0800 (Tue, 15 Jan 2013)


Log Message
REGRESSION (r121599): incorrect border scaling when zoomed
https://bugs.webkit.org/show_bug.cgi?id=106944

Source/WebCore:

Reviewed by Levi Weintraub.

Fix bug in ApplyPropertyComputeLength::applyValue where zooming
of non-pixel values was incorrect.

Test: fast/sub-pixel/zoomed-em-border.html

* css/StyleBuilder.cpp:
(WebCore::ApplyPropertyComputeLength::applyValue):

LayoutTests:

Reviewed by Levi Weintraub.

Add test for zoomed em border and restore expectations for
zoom-replaced-intrinsic-ratio-001 to the pre r121599 state.

* fast/sub-pixel/zoomed-em-border-expected.html: Added.
* fast/sub-pixel/zoomed-em-border.html: Added.
* platform/chromium-linux/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.png:
* platform/chromium-win/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/TestExpectations
trunk/LayoutTests/platform/chromium-linux/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.png
trunk/LayoutTests/platform/chromium-win/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt
trunk/LayoutTests/platform/mac/TestExpectations
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/StyleBuilder.cpp


Added Paths

trunk/LayoutTests/fast/sub-pixel/zoomed-em-border-expected.html
trunk/LayoutTests/fast/sub-pixel/zoomed-em-border.html




Diff

Modified: trunk/LayoutTests/ChangeLog (139797 => 139798)

--- trunk/LayoutTests/ChangeLog	2013-01-15 23:17:01 UTC (rev 139797)
+++ trunk/LayoutTests/ChangeLog	2013-01-15 23:21:34 UTC (rev 139798)
@@ -1,3 +1,18 @@
+2013-01-15  Emil A Eklund  e...@chromium.org
+
+REGRESSION (r121599): incorrect border scaling when zoomed
+https://bugs.webkit.org/show_bug.cgi?id=106944
+
+Reviewed by Levi Weintraub.
+
+Add test for zoomed em border and restore expectations for 
+zoom-replaced-intrinsic-ratio-001 to the pre r121599 state.
+
+* fast/sub-pixel/zoomed-em-border-expected.html: Added.
+* fast/sub-pixel/zoomed-em-border.html: Added.
+* platform/chromium-linux/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.png:
+* platform/chromium-win/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt:
+
 2013-01-15  Alexandru Chiculita  ach...@adobe.com
 
 [Compositor] Do not disable overlap testing for layers in front of 3D transformed layers


Added: trunk/LayoutTests/fast/sub-pixel/zoomed-em-border-expected.html (0 => 139798)

--- trunk/LayoutTests/fast/sub-pixel/zoomed-em-border-expected.html	(rev 0)
+++ trunk/LayoutTests/fast/sub-pixel/zoomed-em-border-expected.html	2013-01-15 23:21:34 UTC (rev 139798)
@@ -0,0 +1,35 @@
+!DOCTYPE html
+html
+head
+style
+html {
+padding: 1em;
+}
+
+body {
+zoom: 3.0;
+}
+
+#one, #two {
+display: inline-block;
+padding: 0 0.5em;
+font-size: 10px;
+}
+
+#one {
+line-height: 1.5;
+background-color: orange;
+}
+
+#two {
+line-height: 1;
+border-width: 2.333px 0;
+border-color: #f60;
+border-style: solid;
+}
+/style
+/head
+body
+div id=oneHello/div div id=twoWorld/div
+/body
+/html


Added: trunk/LayoutTests/fast/sub-pixel/zoomed-em-border.html (0 => 139798)

--- trunk/LayoutTests/fast/sub-pixel/zoomed-em-border.html	(rev 0)
+++ trunk/LayoutTests/fast/sub-pixel/zoomed-em-border.html	2013-01-15 23:21:34 UTC (rev 139798)
@@ -0,0 +1,35 @@
+!DOCTYPE html
+html
+head
+style
+html {
+padding: 1em;
+}
+
+body {
+zoom: 3.0;
+}
+
+#one, #two {
+display: inline-block;
+padding: 0 0.5em;
+font-size: 10px;
+}
+
+#one {
+line-height: 1.5;
+background-color: orange;
+}
+
+#two {
+line-height: 1;
+border-width: 0.25em 0;
+border-color: #f60;
+border-style: solid;
+}
+/style
+/head
+body
+div id=oneHello/div div id=twoWorld/div
+/body
+/html


Modified: trunk/LayoutTests/platform/chromium/TestExpectations (139797 => 139798)

--- trunk/LayoutTests/platform/chromium/TestExpectations	2013-01-15 23:17:01 UTC (rev 139797)
+++ trunk/LayoutTests/platform/chromium/TestExpectations	2013-01-15 23:21:34 UTC (rev 139798)
@@ -4379,3 +4379,6 @@
 webkit.org/b/106833 fast/borders/outline-alpha-inline.html [ Pass ImageOnlyFailure ]
 

[webkit-changes] [139799] trunk

[leviw]

Title: [139799] trunk








Revision 139799
Author le...@chromium.org
Date 2013-01-15 15:40:29 -0800 (Tue, 15 Jan 2013)


Log Message
Unreviewed, rolling out r139790.
http://trac.webkit.org/changeset/139790
https://bugs.webkit.org/show_bug.cgi?id=106948

The patch is failing its own test.

Source/_javascript_Core: 

* bytecode/GlobalResolveInfo.h: Removed property svn:mergeinfo.

Source/WebCore: 

* dom/ContainerNode.cpp:
(WebCore::ContainerNode::parserInsertBefore):
(WebCore::ContainerNode::parserRemoveChild):
(WebCore::ContainerNode::parserAppendChild):
* html/parser/HTMLScriptRunner.cpp:
(WebCore::HTMLScriptRunner::executeParsingBlockingScript):
(WebCore::HTMLScriptRunner::executePendingScriptAndDispatchEvent):
(WebCore::HTMLScriptRunner::execute):
(WebCore::HTMLScriptRunner::executeScriptsWaitingForLoad):
(WebCore::HTMLScriptRunner::executeScriptsWaitingForStylesheets):
(WebCore::HTMLScriptRunner::executeScriptsWaitingForParsing):
(WebCore::HTMLScriptRunner::runScript):

LayoutTests: 

* fast/dom/MutationObserver/parser-mutations-expected.txt: Removed.
* fast/dom/MutationObserver/parser-mutations.html: Removed.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/ContainerNode.cpp
trunk/Source/WebCore/html/parser/HTMLScriptRunner.cpp


Removed Paths

trunk/LayoutTests/fast/dom/MutationObserver/parser-mutations-expected.txt
trunk/LayoutTests/fast/dom/MutationObserver/parser-mutations.html




Diff

Modified: trunk/LayoutTests/ChangeLog (139798 => 139799)

--- trunk/LayoutTests/ChangeLog	2013-01-15 23:21:34 UTC (rev 139798)
+++ trunk/LayoutTests/ChangeLog	2013-01-15 23:40:29 UTC (rev 139799)
@@ -1,3 +1,14 @@
+2013-01-15  Levi Weintraub  le...@chromium.org
+
+Unreviewed, rolling out r139790.
+http://trac.webkit.org/changeset/139790
+https://bugs.webkit.org/show_bug.cgi?id=106948
+
+The patch is failing its own test.
+
+* fast/dom/MutationObserver/parser-mutations-expected.txt: Removed.
+* fast/dom/MutationObserver/parser-mutations.html: Removed.
+
 2013-01-15  Emil A Eklund  e...@chromium.org
 
 REGRESSION (r121599): incorrect border scaling when zoomed


Deleted: trunk/LayoutTests/fast/dom/MutationObserver/parser-mutations-expected.txt (139798 => 139799)

--- trunk/LayoutTests/fast/dom/MutationObserver/parser-mutations-expected.txt	2013-01-15 23:21:34 UTC (rev 139798)
+++ trunk/LayoutTests/fast/dom/MutationObserver/parser-mutations-expected.txt	2013-01-15 23:40:29 UTC (rev 139799)
@@ -1,6 +0,0 @@
-PASS mutations.length is 6
-PASS mutations[1].type is childList
-PASS mutations[1].target.tagName is BODY
-PASS mutations[1].addedNodes.length is 1
-PASS mutations[1].addedNodes[0].tagName is P
-Mutation records should be delivered for all parser mutations after the above script.


Deleted: trunk/LayoutTests/fast/dom/MutationObserver/parser-mutations.html (139798 => 139799)

--- trunk/LayoutTests/fast/dom/MutationObserver/parser-mutations.html	2013-01-15 23:21:34 UTC (rev 139798)
+++ trunk/LayoutTests/fast/dom/MutationObserver/parser-mutations.html	2013-01-15 23:40:29 UTC (rev 139799)
@@ -1,27 +0,0 @@
-!DOCTYPE html
-
-body
-script src=""
-
-script
-if (window.testRunner)
-testRunner.dumpAsText();
-
-var observer = new WebKitMutationObserver(function(mutations, observer) {
-window.mutations = mutations;
-});
-observer.observe(document.body, {childList: true, subtree:true});
-/script
-
-p
-Mutation records should be delivered for all parser mutations after the above script.
-/p
-
-script
-shouldBe('mutations.length', '6');
-shouldBeEqualToString('mutations[1].type', 'childList');
-shouldBeEqualToString('mutations[1].target.tagName', 'BODY');
-shouldBe('mutations[1].addedNodes.length', '1');
-shouldBeEqualToString('mutations[1].addedNodes[0].tagName', 'P');
-/script
-/body
\ No newline at end of file


Modified: trunk/Source/_javascript_Core/ChangeLog (139798 => 139799)

--- trunk/Source/_javascript_Core/ChangeLog	2013-01-15 23:21:34 UTC (rev 139798)
+++ trunk/Source/_javascript_Core/ChangeLog	2013-01-15 23:40:29 UTC (rev 139799)
@@ -1,3 +1,13 @@
+2013-01-15  Levi Weintraub  le...@chromium.org
+
+Unreviewed, rolling out r139790.
+http://trac.webkit.org/changeset/139790
+https://bugs.webkit.org/show_bug.cgi?id=106948
+
+The patch is failing its own test.
+
+* bytecode/GlobalResolveInfo.h: Removed property svn:mergeinfo.
+
 2013-01-15  Zan Dobersek  zandober...@gmail.com
 
 [Autotools] Unify _javascript_Core sources list, regardless of target OS


Modified: trunk/Source/WebCore/ChangeLog (139798 => 139799)

--- trunk/Source/WebCore/ChangeLog	2013-01-15 23:21:34 UTC (rev 139798)
+++ trunk/Source/WebCore/ChangeLog	2013-01-15 23:40:29 UTC (rev 139799)
@@ -1,3 +1,24 @@
+2013-01-15  Levi Weintraub  le...@chromium.org
+
+Unreviewed, rolling out r139790.
+

[webkit-changes] [139800] trunk/Source/WebCore

[bdakin]

Title: [139800] trunk/Source/WebCore








Revision 139800
Author bda...@apple.com
Date 2013-01-15 15:43:27 -0800 (Tue, 15 Jan 2013)


Log Message
https://bugs.webkit.org/show_bug.cgi?id=106940
Suspend CSS animations for background tabs

Reviewed by Simon Fraser.

* page/Page.cpp:
(WebCore::Page::setVisibilityState):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/Page.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (139799 => 139800)

--- trunk/Source/WebCore/ChangeLog	2013-01-15 23:40:29 UTC (rev 139799)
+++ trunk/Source/WebCore/ChangeLog	2013-01-15 23:43:27 UTC (rev 139800)
@@ -1,3 +1,13 @@
+2013-01-15  Beth Dakin  bda...@apple.com
+
+https://bugs.webkit.org/show_bug.cgi?id=106940
+Suspend CSS animations for background tabs
+
+Reviewed by Simon Fraser.
+
+* page/Page.cpp:
+(WebCore::Page::setVisibilityState):
+
 2013-01-15  Levi Weintraub  le...@chromium.org
 
 Unreviewed, rolling out r139790.


Modified: trunk/Source/WebCore/page/Page.cpp (139799 => 139800)

--- trunk/Source/WebCore/page/Page.cpp	2013-01-15 23:40:29 UTC (rev 139799)
+++ trunk/Source/WebCore/page/Page.cpp	2013-01-15 23:43:27 UTC (rev 139800)
@@ -1184,15 +1184,20 @@
 m_mainFrame-dispatchVisibilityStateChangeEvent();
 #endif
 
+if (visibilityState == WebCore::PageVisibilityStateHidden) {
 #if ENABLE(HIDDEN_PAGE_DOM_TIMER_THROTTLING)
-if (visibilityState == WebCore::PageVisibilityStateHidden)
 setTimerAlignmentInterval(Settings::hiddenPageDOMTimerAlignmentInterval());
-else
+#endif
+mainFrame()-animation()-suspendAnimations();
+} else {
+#if ENABLE(HIDDEN_PAGE_DOM_TIMER_THROTTLING)
 setTimerAlignmentInterval(Settings::defaultDOMTimerAlignmentInterval());
+#endif
+mainFrame()-animation()-resumeAnimations();
+}
 #if !ENABLE(PAGE_VISIBILITY_API)
 UNUSED_PARAM(isInitialState);
 #endif
-#endif
 }
 #endif // ENABLE(PAGE_VISIBILITY_API) || ENABLE(HIDDEN_PAGE_DOM_TIMER_THROTTLING)
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [139801] trunk/Source/WebKit/win

[commit-queue]

Title: [139801] trunk/Source/WebKit/win








Revision 139801
Author commit-qu...@webkit.org
Date 2013-01-15 15:45:14 -0800 (Tue, 15 Jan 2013)


Log Message
Crash when saving history with no items in it.
https://bugs.webkit.org/show_bug.cgi?id=104261

Patch by pe...@outlook.com pe...@outlook.com on 2013-01-15
Reviewed by Darin Adler.

* WebHistory.cpp:
(WebHistory::saveHistoryGuts): Added null pointer check

Modified Paths

trunk/Source/WebKit/win/ChangeLog
trunk/Source/WebKit/win/WebHistory.cpp




Diff

Modified: trunk/Source/WebKit/win/ChangeLog (139800 => 139801)

--- trunk/Source/WebKit/win/ChangeLog	2013-01-15 23:43:27 UTC (rev 139800)
+++ trunk/Source/WebKit/win/ChangeLog	2013-01-15 23:45:14 UTC (rev 139801)
@@ -1,3 +1,13 @@
+2013-01-15  pe...@outlook.com  pe...@outlook.com
+
+Crash when saving history with no items in it.
+https://bugs.webkit.org/show_bug.cgi?id=104261
+
+Reviewed by Darin Adler.
+
+* WebHistory.cpp:
+(WebHistory::saveHistoryGuts): Added null pointer check
+
 2013-01-09  Levi Weintraub le...@chromium.org
 
 Rolling out r139683. It broke a bunch of webkit_unit_tests. 


Modified: trunk/Source/WebKit/win/WebHistory.cpp (139800 => 139801)

--- trunk/Source/WebKit/win/WebHistory.cpp	2013-01-15 23:43:27 UTC (rev 139800)
+++ trunk/Source/WebKit/win/WebHistory.cpp	2013-01-15 23:45:14 UTC (rev 139801)
@@ -381,6 +381,9 @@
 
 RetainPtrCFDataRef data = ""
 
+if (!data.get())
+return E_FAIL;
+
 RetainPtrCFWriteStreamRef stream(AdoptCF, CFWriteStreamCreateWithFile(kCFAllocatorDefault, url));
 if (!stream) 
 return E_FAIL;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [139802] trunk/Source/WebCore

[simon . fraser]

Title: [139802] trunk/Source/WebCore








Revision 139802
Author simon.fra...@apple.com
Date 2013-01-15 15:46:18 -0800 (Tue, 15 Jan 2013)


Log Message
Some ScrollingCoördinator-related cleanup in RenderLayerBacking
https://bugs.webkit.org/show_bug.cgi?id=106950

Reviewed by Beth Dakin.

Wrap up code that gets the ScrollingCoordinator into a utility function.
Pull code out of updateGraphicsLayerGeometry() that registers layers with
the ScrollingCoordinator, for cleanliness.

* rendering/RenderLayerBacking.cpp:
(WebCore::scrollingCoordinatorFromLayer):
(WebCore::RenderLayerBacking::adjustTileCacheCoverage):
(WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):
(WebCore::RenderLayerBacking::registerScrollingLayers):
(WebCore::RenderLayerBacking::attachToScrollingCoordinatorWithParent):
(WebCore::RenderLayerBacking::detachFromScrollingCoordinator):
* rendering/RenderLayerBacking.h:
(RenderLayerBacking):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderLayerBacking.cpp
trunk/Source/WebCore/rendering/RenderLayerBacking.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (139801 => 139802)

--- trunk/Source/WebCore/ChangeLog	2013-01-15 23:45:14 UTC (rev 139801)
+++ trunk/Source/WebCore/ChangeLog	2013-01-15 23:46:18 UTC (rev 139802)
@@ -1,3 +1,24 @@
+2013-01-15  Simon Fraser  simon.fra...@apple.com
+
+Some ScrollingCoördinator-related cleanup in RenderLayerBacking
+https://bugs.webkit.org/show_bug.cgi?id=106950
+
+Reviewed by Beth Dakin.
+
+Wrap up code that gets the ScrollingCoordinator into a utility function.
+Pull code out of updateGraphicsLayerGeometry() that registers layers with
+the ScrollingCoordinator, for cleanliness.
+
+* rendering/RenderLayerBacking.cpp:
+(WebCore::scrollingCoordinatorFromLayer):
+(WebCore::RenderLayerBacking::adjustTileCacheCoverage):
+(WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):
+(WebCore::RenderLayerBacking::registerScrollingLayers):
+(WebCore::RenderLayerBacking::attachToScrollingCoordinatorWithParent):
+(WebCore::RenderLayerBacking::detachFromScrollingCoordinator):
+* rendering/RenderLayerBacking.h:
+(RenderLayerBacking):
+
 2013-01-15  Beth Dakin  bda...@apple.com
 
 https://bugs.webkit.org/show_bug.cgi?id=106940


Modified: trunk/Source/WebCore/rendering/RenderLayerBacking.cpp (139801 => 139802)

--- trunk/Source/WebCore/rendering/RenderLayerBacking.cpp	2013-01-15 23:45:14 UTC (rev 139801)
+++ trunk/Source/WebCore/rendering/RenderLayerBacking.cpp	2013-01-15 23:46:18 UTC (rev 139802)
@@ -95,6 +95,16 @@
 return false;
 }
 
+// Get the scrolling coordinator in a way that works inside RenderLayerBacking's destructor.
+static ScrollingCoordinator* scrollingCoordinatorFromLayer(RenderLayer* layer)
+{
+Page* page = layer-renderer()-frame()-page();
+if (!page)
+return 0;
+
+return page-scrollingCoordinator();
+}
+
 bool RenderLayerBacking::m_creatingPrimaryGraphicsLayer = false;
 
 RenderLayerBacking::RenderLayerBacking(RenderLayer* layer)
@@ -200,7 +210,7 @@
 if (frameView-verticalScrollbarMode() != ScrollbarAlwaysOff)
 tileCoverage |= TiledBacking::CoverageForVerticalScrolling;
 
-if (ScrollingCoordinator* scrollingCoordinator = frame-page()-scrollingCoordinator()) {
+if (ScrollingCoordinator* scrollingCoordinator = scrollingCoordinatorFromLayer(m_owningLayer)) {
 // Ask our TiledBacking for large tiles unless the only reason we're main-thread-scrolling
 // is a page overlay (find-in-page, the Web Inspector highlight mechanism, etc.).
 if (scrollingCoordinator-mainThreadScrollingReasons()  ~ScrollingCoordinator::ForcedOnMainThread)
@@ -569,23 +579,6 @@
 m_graphicsLayer-setPreserves3D(style-transformStyle3D() == TransformStyle3DPreserve3D  !renderer()-hasReflection());
 m_graphicsLayer-setBackfaceVisibility(style-backfaceVisibility() == BackfaceVisibilityVisible);
 
-// Register fixed position layers and their containers with the scrolling coordinator.
-if (Page* page = renderer()-frame()-page()) {
-if (ScrollingCoordinator* scrollingCoordinator = page-scrollingCoordinator()) {
-if (style-position() == FixedPosition || compositor()-fixedPositionedByAncestor(m_owningLayer))
-scrollingCoordinator-setLayerIsFixedToContainerLayer(childForSuperlayers(), true);
-else {
-if (m_ancestorClippingLayer)
-scrollingCoordinator-setLayerIsFixedToContainerLayer(m_ancestorClippingLayer.get(), false);
-scrollingCoordinator-setLayerIsFixedToContainerLayer(m_graphicsLayer.get(), false);
-}
-// Page scale is applied as a transform on the root render view layer. Because the scroll
-// layer is further up in the hierarchy, we need to avoid marking the root render view

[webkit-changes] [139805] trunk/Tools

[commit-queue]

Title: [139805] trunk/Tools








Revision 139805
Author commit-qu...@webkit.org
Date 2013-01-15 16:02:22 -0800 (Tue, 15 Jan 2013)


Log Message
Extend sheriffbot's help command to be able to get help on individual commands
https://bugs.webkit.org/show_bug.cgi?id=106629

Patch by Alan Cutter alancut...@chromium.org on 2013-01-15
Reviewed by Eric Seidel.

Added a help command to sheriffbot.
Fixed some style issues and ordered the commands alphabetically.

* Scripts/webkitpy/tool/bot/irc_command.py:
(IRCCommand):
(IRCCommand.execute):
(IRCCommand.usage):
(IRCCommand.help):
(CreateBug):
(CreateBug.execute):
(Help):
(Help.execute):
(Help._post_command_help):
(Hi):
(Hi.execute):
(Restart):
(RollChromiumDEPS):
(RollChromiumDEPS._parse_args):
(RollChromiumDEPS._expand_irc_nickname):
(RollChromiumDEPS.execute):
(Rollout):
(Rollout._extract_revisions):
(Rollout.execute):
(Sheriffs):
(Sheriffs.execute):
(Whois):
(Whois.execute):
* Scripts/webkitpy/tool/bot/ircbot_unittest.py:
(IRCBotTest.test_help):

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/tool/bot/irc_command.py
trunk/Tools/Scripts/webkitpy/tool/bot/ircbot_unittest.py




Diff

Modified: trunk/Tools/ChangeLog (139804 => 139805)

--- trunk/Tools/ChangeLog	2013-01-15 23:58:42 UTC (rev 139804)
+++ trunk/Tools/ChangeLog	2013-01-16 00:02:22 UTC (rev 139805)
@@ -1,3 +1,40 @@
+2013-01-15  Alan Cutter  alancut...@chromium.org
+
+Extend sheriffbot's help command to be able to get help on individual commands
+https://bugs.webkit.org/show_bug.cgi?id=106629
+
+Reviewed by Eric Seidel.
+
+Added a help command to sheriffbot.
+Fixed some style issues and ordered the commands alphabetically.
+
+* Scripts/webkitpy/tool/bot/irc_command.py:
+(IRCCommand):
+(IRCCommand.execute):
+(IRCCommand.usage):
+(IRCCommand.help):
+(CreateBug):
+(CreateBug.execute):
+(Help):
+(Help.execute):
+(Help._post_command_help):
+(Hi):
+(Hi.execute):
+(Restart):
+(RollChromiumDEPS):
+(RollChromiumDEPS._parse_args):
+(RollChromiumDEPS._expand_irc_nickname):
+(RollChromiumDEPS.execute):
+(Rollout):
+(Rollout._extract_revisions):
+(Rollout.execute):
+(Sheriffs):
+(Sheriffs.execute):
+(Whois):
+(Whois.execute):
+* Scripts/webkitpy/tool/bot/ircbot_unittest.py:
+(IRCBotTest.test_help):
+
 2013-01-15  Enrica Casucci  enr...@apple.com
 
 Add a new set of WebKit2 APIs for text search and


Modified: trunk/Tools/Scripts/webkitpy/tool/bot/irc_command.py (139804 => 139805)

--- trunk/Tools/Scripts/webkitpy/tool/bot/irc_command.py	2013-01-15 23:58:42 UTC (rev 139804)
+++ trunk/Tools/Scripts/webkitpy/tool/bot/irc_command.py	2013-01-16 00:02:22 UTC (rev 139805)
@@ -49,19 +49,128 @@
 
 # FIXME: Merge with Command?
 class IRCCommand(object):
+usage_string = None
+help_string = None
+
 def execute(self, nick, args, tool, sheriff):
-raise NotImplementedError, subclasses must implement
+raise NotImplementedError(subclasses must implement)
 
+@classmethod
+def usage(cls, nick):
+return %s: Usage: %s % (nick, cls.usage_string)
 
+@classmethod
+def help(cls, nick):
+return %s: %s % (nick, cls.help_string)
+
+
+class CreateBug(IRCCommand):
+usage_string = create-bug BUG_TITLE
+help_string = Creates a Bugzilla bug with the given title.
+
+def execute(self, nick, args, tool, sheriff):
+if not args:
+return self.usage(nick)
+
+bug_title =  .join(args)
+bug_description = %s\nRequested by %s on %s. % (bug_title, nick, config_irc.channel)
+
+# There happens to be a committers list hung off of Bugzilla, so
+# re-using that one makes things easiest for now.
+requester = tool.bugs.committers.contributor_by_irc_nickname(nick)
+requester_email = requester.bugzilla_email() if requester else None
+
+try:
+bug_id = tool.bugs.create_bug(bug_title, bug_description, cc=requester_email, assignee=requester_email)
+bug_url = tool.bugs.bug_url_for_bug_id(bug_id)
+return %s: Created bug: %s % (nick, bug_url)
+except Exception, e:
+return %s: Failed to create bug:\n%s % (nick, e)
+
+
+class Help(IRCCommand):
+usage_string = help [COMMAND]
+help_string = Provides help on individual sheriffbot commands.
+
+def execute(self, nick, args, tool, sheriff):
+if args:
+for command_name in args:
+if command_name in commands:
+self._post_command_help(nick, tool, commands[command_name])
+else:
+tool.irc().post(%s: Available commands: %s % (nick, , .join(sorted(visible_commands.keys()
+tool.irc().post('%s: Type sheriffbot: help COMMAND for help on individual commands.' % nick)
+
+   

[webkit-changes] [139806] trunk

[dmazzoni]

Title: [139806] trunk








Revision 139806
Author dmazz...@google.com
Date 2013-01-15 16:13:15 -0800 (Tue, 15 Jan 2013)


Log Message
Use-after-free in AXObjectCache::notificationPostTimerFired
https://bugs.webkit.org/show_bug.cgi?id=106106

Reviewed by Ryosuke Niwa.

Source/WebCore:

Fixes a crash that occurs when a Node is adopted by another document,
in particular one that isn't part of the page, and then deleted,
which wasn't triggering the code that removed the Node from
AXObjectCache. Now, a Node is removed from the AXObjectCache whenever
its Document changes.

Test: accessibility/crash-adopt-node-from-new-document.html

* dom/Node.cpp:
(WebCore::Node::didMoveToNewDocument):

LayoutTests:

Test that demonstrates the crash when a Node with an
AccessibilityObject changes its document and then isn't removed from
the AXObjectCache when it's deleted.

* accessibility/crash-adopt-node-from-new-document-expected.txt: Added.
* accessibility/crash-adopt-node-from-new-document.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/Node.cpp


Added Paths

trunk/LayoutTests/accessibility/crash-adopt-node-from-new-document-expected.txt
trunk/LayoutTests/accessibility/crash-adopt-node-from-new-document.html




Diff

Modified: trunk/LayoutTests/ChangeLog (139805 => 139806)

--- trunk/LayoutTests/ChangeLog	2013-01-16 00:02:22 UTC (rev 139805)
+++ trunk/LayoutTests/ChangeLog	2013-01-16 00:13:15 UTC (rev 139806)
@@ -1,3 +1,17 @@
+2013-01-15  Dominic Mazzoni  dmazz...@google.com
+
+Use-after-free in AXObjectCache::notificationPostTimerFired
+https://bugs.webkit.org/show_bug.cgi?id=106106
+
+Reviewed by Ryosuke Niwa.
+
+Test that demonstrates the crash when a Node with an
+AccessibilityObject changes its document and then isn't removed from
+the AXObjectCache when it's deleted.
+
+* accessibility/crash-adopt-node-from-new-document-expected.txt: Added.
+* accessibility/crash-adopt-node-from-new-document.html: Added.
+
 2013-01-15  Arnaud Renevier  a.renev...@sisa.samsung.com
 
 Add Canvas blend modes to Cairo


Added: trunk/LayoutTests/accessibility/crash-adopt-node-from-new-document-expected.txt (0 => 139806)

--- trunk/LayoutTests/accessibility/crash-adopt-node-from-new-document-expected.txt	(rev 0)
+++ trunk/LayoutTests/accessibility/crash-adopt-node-from-new-document-expected.txt	2013-01-16 00:13:15 UTC (rev 139806)
@@ -0,0 +1,2 @@
+ALERT: This test makes sure that adopting a node with an AccessibilityObject into a new document doesn't crash. Test passed.
+


Added: trunk/LayoutTests/accessibility/crash-adopt-node-from-new-document.html (0 => 139806)

--- trunk/LayoutTests/accessibility/crash-adopt-node-from-new-document.html	(rev 0)
+++ trunk/LayoutTests/accessibility/crash-adopt-node-from-new-document.html	2013-01-16 00:13:15 UTC (rev 139806)
@@ -0,0 +1,24 @@
+!DOCTYPE html
+html
+head
+script src=""
+/head
+body
+
+canvas
+div id=node1
+div id=node2
+/canvas
+
+script
+document.getElementById(node2).setAttribute(aria-label, Label);
+document.implementation.createDocument(, , null).adoptNode(node1);
+
+gc();
+
+alert(This test makes sure that adopting a node with an AccessibilityObject into a new document doesn't crash. Test passed.);
+
+/script
+script src=""
+/body
+/html


Modified: trunk/Source/WebCore/ChangeLog (139805 => 139806)

--- trunk/Source/WebCore/ChangeLog	2013-01-16 00:02:22 UTC (rev 139805)
+++ trunk/Source/WebCore/ChangeLog	2013-01-16 00:13:15 UTC (rev 139806)
@@ -1,3 +1,21 @@
+2013-01-15  Dominic Mazzoni  dmazz...@google.com
+
+Use-after-free in AXObjectCache::notificationPostTimerFired
+https://bugs.webkit.org/show_bug.cgi?id=106106
+
+Reviewed by Ryosuke Niwa.
+
+Fixes a crash that occurs when a Node is adopted by another document,
+in particular one that isn't part of the page, and then deleted,
+which wasn't triggering the code that removed the Node from
+AXObjectCache. Now, a Node is removed from the AXObjectCache whenever
+its Document changes.
+
+Test: accessibility/crash-adopt-node-from-new-document.html
+
+* dom/Node.cpp:
+(WebCore::Node::didMoveToNewDocument):
+
 2013-01-15  Arnaud Renevier  a.renev...@sisa.samsung.com
 
 Add Canvas blend modes to Cairo


Modified: trunk/Source/WebCore/dom/Node.cpp (139805 => 139806)

--- trunk/Source/WebCore/dom/Node.cpp	2013-01-16 00:02:22 UTC (rev 139805)
+++ trunk/Source/WebCore/dom/Node.cpp	2013-01-16 00:13:15 UTC (rev 139806)
@@ -2079,6 +2079,9 @@
 {
 TreeScopeAdopter::ensureDidMoveToNewDocumentWasCalled(oldDocument);
 
+if (AXObjectCache::accessibilityEnabled()  oldDocument  oldDocument-axObjectCacheExists())
+oldDocument-axObjectCache()-remove(this);
+
 // FIXME: Event listener types for this node should be set on the new owner document here.
 
 

[webkit-changes] [139807] trunk

[eae]

Title: [139807] trunk








Revision 139807
Author e...@chromium.org
Date 2013-01-15 16:14:57 -0800 (Tue, 15 Jan 2013)


Log Message
[Sub pixel layout] RTL cells with padding wraps
https://bugs.webkit.org/show_bug.cgi?id=106843

Source/WebCore:

Reviewed by Levi Weintraub.

At certain zoom levels table cells with padding wraps for rtl
content.

Test: fast/sub-pixel/table-rtl-padding.html

* rendering/RenderTable.h: Override paddingStart/End to return
integer values for padding as we do elsewhere in the table code.

LayoutTests:

Reviewed by Levi Weintraub.

Add test for rtl tables with padding.

* fast/sub-pixel/input-caret-on-subpixel-bound-expected.html:
* fast/sub-pixel/table-rtl-padding-expected.html: Added.
* fast/sub-pixel/table-rtl-padding.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/sub-pixel/input-caret-on-subpixel-bound-expected.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderTable.h


Added Paths

trunk/LayoutTests/fast/sub-pixel/table-rtl-padding-expected.html
trunk/LayoutTests/fast/sub-pixel/table-rtl-padding.html




Diff

Modified: trunk/LayoutTests/ChangeLog (139806 => 139807)

--- trunk/LayoutTests/ChangeLog	2013-01-16 00:13:15 UTC (rev 139806)
+++ trunk/LayoutTests/ChangeLog	2013-01-16 00:14:57 UTC (rev 139807)
@@ -1,3 +1,16 @@
+2013-01-15  Emil A Eklund  e...@chromium.org
+
+[Sub pixel layout] RTL cells with padding wraps
+https://bugs.webkit.org/show_bug.cgi?id=106843
+
+Reviewed by Levi Weintraub.
+
+Add test for rtl tables with padding.
+
+* fast/sub-pixel/input-caret-on-subpixel-bound-expected.html:
+* fast/sub-pixel/table-rtl-padding-expected.html: Added.
+* fast/sub-pixel/table-rtl-padding.html: Added.
+
 2013-01-15  Dominic Mazzoni  dmazz...@google.com
 
 Use-after-free in AXObjectCache::notificationPostTimerFired


Modified: trunk/LayoutTests/fast/sub-pixel/input-caret-on-subpixel-bound-expected.html (139806 => 139807)

--- trunk/LayoutTests/fast/sub-pixel/input-caret-on-subpixel-bound-expected.html	2013-01-16 00:13:15 UTC (rev 139806)
+++ trunk/LayoutTests/fast/sub-pixel/input-caret-on-subpixel-bound-expected.html	2013-01-16 00:14:57 UTC (rev 139807)
@@ -10,7 +10,7 @@
   padding: 2px 3px 3px 2px;
   }
   input {
-  padding: 6px 5px 5px 6px;
+  padding: 6px 6px 5px 5px;
   }
 /style
   /head


Added: trunk/LayoutTests/fast/sub-pixel/table-rtl-padding-expected.html (0 => 139807)

--- trunk/LayoutTests/fast/sub-pixel/table-rtl-padding-expected.html	(rev 0)
+++ trunk/LayoutTests/fast/sub-pixel/table-rtl-padding-expected.html	2013-01-16 00:14:57 UTC (rev 139807)
@@ -0,0 +1,20 @@
+!DOCTYPE html
+html
+head
+meta content=text/html; charset=utf-8 http-equiv=Content-Type
+	style
+	td { white-space: nowrap; }
+	/style
+/head
+body style=zoom: 1.1;
+	table style=padding-right: 3px
+		tbody
+			tr
+			tdעדי רם /td
+			td(11:05 , 11.01.13 )/td
+			/tr
+		/tbody
+		Table content should not wrap.
+	/table
+/body
+/html


Added: trunk/LayoutTests/fast/sub-pixel/table-rtl-padding.html (0 => 139807)

--- trunk/LayoutTests/fast/sub-pixel/table-rtl-padding.html	(rev 0)
+++ trunk/LayoutTests/fast/sub-pixel/table-rtl-padding.html	2013-01-16 00:14:57 UTC (rev 139807)
@@ -0,0 +1,17 @@
+!DOCTYPE html
+html
+head
+meta content=text/html; charset=utf-8 http-equiv=Content-Type
+/head
+body style=zoom: 1.1;
+	table style=padding-right: 3px
+		tbody
+			tr
+			tdעדי רם /td
+			td(11:05 , 11.01.13 )/td
+			/tr
+		/tbody
+		Table content should not wrap.
+	/table
+/body
+/html


Modified: trunk/Source/WebCore/ChangeLog (139806 => 139807)

--- trunk/Source/WebCore/ChangeLog	2013-01-16 00:13:15 UTC (rev 139806)
+++ trunk/Source/WebCore/ChangeLog	2013-01-16 00:14:57 UTC (rev 139807)
@@ -1,3 +1,18 @@
+2013-01-15  Emil A Eklund  e...@chromium.org
+
+[Sub pixel layout] RTL cells with padding wraps
+https://bugs.webkit.org/show_bug.cgi?id=106843
+
+Reviewed by Levi Weintraub.
+
+At certain zoom levels table cells with padding wraps for rtl
+content.
+
+Test: fast/sub-pixel/table-rtl-padding.html
+
+* rendering/RenderTable.h: Override paddingStart/End to return
+integer values for padding as we do elsewhere in the table code.
+
 2013-01-15  Dominic Mazzoni  dmazz...@google.com
 
 Use-after-free in AXObjectCache::notificationPostTimerFired


Modified: trunk/Source/WebCore/rendering/RenderTable.h (139806 => 139807)

--- trunk/Source/WebCore/rendering/RenderTable.h	2013-01-16 00:13:15 UTC (rev 139806)
+++ trunk/Source/WebCore/rendering/RenderTable.h	2013-01-16 00:14:57 UTC (rev 139807)
@@ -194,6 +194,10 @@
 return 0;
 

[webkit-changes] [139808] trunk/Source/WebCore

[macpherson]

Title: [139808] trunk/Source/WebCore








Revision 139808
Author macpher...@chromium.org
Date 2013-01-15 16:16:22 -0800 (Tue, 15 Jan 2013)


Log Message
Don't do indiscriminate cast  call in StylePropertySet::PropertyReference::cssName() on release builds.
https://bugs.webkit.org/show_bug.cgi?id=106867

Reviewed by Darin Adler.

Check CSSValue::isVariableValue() before casting to CSSVariableValue.

Covered by existing variables tests.

* css/StylePropertySet.cpp:
(WebCore::StylePropertySet::PropertyReference::cssName):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/StylePropertySet.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (139807 => 139808)

--- trunk/Source/WebCore/ChangeLog	2013-01-16 00:14:57 UTC (rev 139807)
+++ trunk/Source/WebCore/ChangeLog	2013-01-16 00:16:22 UTC (rev 139808)
@@ -1,3 +1,17 @@
+2013-01-15  Luke Macpherson   macpher...@chromium.org
+
+Don't do indiscriminate cast  call in StylePropertySet::PropertyReference::cssName() on release builds.
+https://bugs.webkit.org/show_bug.cgi?id=106867
+
+Reviewed by Darin Adler.
+
+Check CSSValue::isVariableValue() before casting to CSSVariableValue.
+
+Covered by existing variables tests.
+
+* css/StylePropertySet.cpp:
+(WebCore::StylePropertySet::PropertyReference::cssName):
+
 2013-01-15  Emil A Eklund  e...@chromium.org
 
 [Sub pixel layout] RTL cells with padding wraps


Modified: trunk/Source/WebCore/css/StylePropertySet.cpp (139807 => 139808)

--- trunk/Source/WebCore/css/StylePropertySet.cpp	2013-01-16 00:14:57 UTC (rev 139807)
+++ trunk/Source/WebCore/css/StylePropertySet.cpp	2013-01-16 00:16:22 UTC (rev 139808)
@@ -1247,6 +1247,8 @@
 #if ENABLE(CSS_VARIABLES)
 if (id() == CSSPropertyVariable) {
 ASSERT(propertyValue()-isVariableValue());
+if (!propertyValue()-isVariableValue())
+return emptyString(); // Should not happen, but if it does, avoid a bad cast.
 return -webkit-var- + static_castconst CSSVariableValue*(propertyValue())-name();
 }
 #endif






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [139809] trunk

[commit-queue]

Title: [139809] trunk








Revision 139809
Author commit-qu...@webkit.org
Date 2013-01-15 16:18:07 -0800 (Tue, 15 Jan 2013)


Log Message
Fix typos in WebKitFeatures.cmake
https://bugs.webkit.org/show_bug.cgi?id=106952

Patch by Alberto Garcia agar...@igalia.com on 2013-01-15
Reviewed by Martin Robinson.

* Source/cmake/WebKitFeatures.cmake:
Replace Toogle with Toggle.

Modified Paths

trunk/ChangeLog
trunk/Source/cmake/WebKitFeatures.cmake




Diff

Modified: trunk/ChangeLog (139808 => 139809)

--- trunk/ChangeLog	2013-01-16 00:16:22 UTC (rev 139808)
+++ trunk/ChangeLog	2013-01-16 00:18:07 UTC (rev 139809)
@@ -1,3 +1,13 @@
+2013-01-15  Alberto Garcia  agar...@igalia.com
+
+Fix typos in WebKitFeatures.cmake
+https://bugs.webkit.org/show_bug.cgi?id=106952
+
+Reviewed by Martin Robinson.
+
+* Source/cmake/WebKitFeatures.cmake:
+Replace Toogle with Toggle.
+
 2013-01-15  Zan Dobersek  zandober...@gmail.com
 
 [Autotools] Add support for WebKit2-only builds


Modified: trunk/Source/cmake/WebKitFeatures.cmake (139808 => 139809)

--- trunk/Source/cmake/WebKitFeatures.cmake	2013-01-16 00:16:22 UTC (rev 139808)
+++ trunk/Source/cmake/WebKitFeatures.cmake	2013-01-16 00:18:07 UTC (rev 139809)
@@ -45,7 +45,7 @@
 WEBKIT_OPTION_DEFINE(ENABLE_DIRECTORY_UPLOAD Toggle Directory upload support OFF)
 WEBKIT_OPTION_DEFINE(ENABLE_DOWNLOAD_ATTRIBUTE Toggle download attribute support OFF)
 WEBKIT_OPTION_DEFINE(ENABLE_DRAG_SUPPORT Toggle Drag Support OFF)
-WEBKIT_OPTION_DEFINE(ENABLE_FAST_MOBILE_SCROLLING Toogle Fast Mobile Scrolling support OFF)
+WEBKIT_OPTION_DEFINE(ENABLE_FAST_MOBILE_SCROLLING Toggle Fast Mobile Scrolling support OFF)
 WEBKIT_OPTION_DEFINE(ENABLE_FILE_SYSTEM Toggle FileSystem support OFF)
 WEBKIT_OPTION_DEFINE(ENABLE_FILTERS Toggle SVG Filters support OFF)
 WEBKIT_OPTION_DEFINE(ENABLE_FTPDIR Toggle FTP directory support ON)
@@ -70,7 +70,7 @@
 WEBKIT_OPTION_DEFINE(ENABLE_JAVASCRIPT_DEBUGGER Toggle _javascript_ Debugger/Profiler support ON)
 WEBKIT_OPTION_DEFINE(ENABLE_JIT Enable JustInTime _javascript_ support ON)
 WEBKIT_OPTION_DEFINE(ENABLE_LEGACY_NOTIFICATIONS Toggle Legacy Desktop Notifications Support OFF)
-WEBKIT_OPTION_DEFINE(ENABLE_LEGACY_VIEWPORT_ADAPTION Toogle legacy viewport adaption OFF)
+WEBKIT_OPTION_DEFINE(ENABLE_LEGACY_VIEWPORT_ADAPTION Toggle legacy viewport adaption OFF)
 WEBKIT_OPTION_DEFINE(ENABLE_LEGACY_VENDOR_PREFIXES Toggle Legacy Vendor Prefix Support ON)
 WEBKIT_OPTION_DEFINE(ENABLE_LEGACY_WEB_AUDIO Toggle Legacy Web Audio support ON)
 WEBKIT_OPTION_DEFINE(ENABLE_LINK_PREFETCH Toggle pre fetching support OFF)
@@ -118,7 +118,7 @@
 WEBKIT_OPTION_DEFINE(ENABLE_VIDEO_TRACK Toggle Track support for HTML5 video OFF)
 WEBKIT_OPTION_DEFINE(ENABLE_WEB_AUDIO Toggle Web Audio support OFF)
 WEBKIT_OPTION_DEFINE(ENABLE_WEB_INTENTS Toggle Web Intents support OFF)
-WEBKIT_OPTION_DEFINE(ENABLE_WEB_INTENTS_TAG Toogle HTMLIntentElement tag support OFF)
+WEBKIT_OPTION_DEFINE(ENABLE_WEB_INTENTS_TAG Toggle HTMLIntentElement tag support OFF)
 WEBKIT_OPTION_DEFINE(ENABLE_WEB_SOCKETS Toggle Web Sockets support ON)
 WEBKIT_OPTION_DEFINE(ENABLE_WEB_TIMING Toggle Web Timing support OFF)
 WEBKIT_OPTION_DEFINE(ENABLE_WEBGL Toggle 3D canvas (WebGL) support OFF)
@@ -127,7 +127,7 @@
 WEBKIT_OPTION_DEFINE(ENABLE_XSLT Toggle XSLT support ON)
 WEBKIT_OPTION_DEFINE(USE_SYSTEM_MALLOC Toggle system allocator instead of TCmalloc OFF)
 WEBKIT_OPTION_DEFINE(WTF_USE_TILED_BACKING_STORE Toggle Tiled Backing Store support OFF)
-WEBKIT_OPTION_DEFINE(WTF_USE_WTFURL Toogle the use of WTFURL for URL parsing OFF)
+WEBKIT_OPTION_DEFINE(WTF_USE_WTFURL Toggle the use of WTFURL for URL parsing OFF)
 endmacro()
 
 macro(WEBKIT_OPTION_END)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [139810] trunk/LayoutTests

[eae]

Title: [139810] trunk/LayoutTests








Revision 139810
Author e...@chromium.org
Date 2013-01-15 16:45:22 -0800 (Tue, 15 Jan 2013)


Log Message
Unreviewed mac rebaseline for r139798.

* http/tests/misc/object-embedding-svg-delayed-size-negotiation-2-expected.txt: Added.
* platform/mac-wk2/svg/zoom/page: Removed.
* platform/mac/TestExpectations:
* platform/mac/http/tests/misc/object-embedding-svg-delayed-size-negotiation-2-expected.txt: Removed.
* platform/mac/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac/TestExpectations
trunk/LayoutTests/platform/mac/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt


Added Paths

trunk/LayoutTests/http/tests/misc/object-embedding-svg-delayed-size-negotiation-2-expected.txt


Removed Paths

trunk/LayoutTests/platform/mac/http/tests/misc/object-embedding-svg-delayed-size-negotiation-2-expected.txt
trunk/LayoutTests/platform/mac-wk2/svg/zoom/page/




Diff

Modified: trunk/LayoutTests/ChangeLog (139809 => 139810)

--- trunk/LayoutTests/ChangeLog	2013-01-16 00:18:07 UTC (rev 139809)
+++ trunk/LayoutTests/ChangeLog	2013-01-16 00:45:22 UTC (rev 139810)
@@ -1,5 +1,15 @@
 2013-01-15  Emil A Eklund  e...@chromium.org
 
+Unreviewed mac rebaseline for r139798.
+
+* http/tests/misc/object-embedding-svg-delayed-size-negotiation-2-expected.txt: Added.
+* platform/mac-wk2/svg/zoom/page: Removed.
+* platform/mac/TestExpectations:
+* platform/mac/http/tests/misc/object-embedding-svg-delayed-size-negotiation-2-expected.txt: Removed.
+* platform/mac/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt:
+
+2013-01-15  Emil A Eklund  e...@chromium.org
+
 [Sub pixel layout] RTL cells with padding wraps
 https://bugs.webkit.org/show_bug.cgi?id=106843
 


Added: trunk/LayoutTests/http/tests/misc/object-embedding-svg-delayed-size-negotiation-2-expected.txt (0 => 139810)

--- trunk/LayoutTests/http/tests/misc/object-embedding-svg-delayed-size-negotiation-2-expected.txt	(rev 0)
+++ trunk/LayoutTests/http/tests/misc/object-embedding-svg-delayed-size-negotiation-2-expected.txt	2013-01-16 00:45:22 UTC (rev 139810)
@@ -0,0 +1,62 @@
+layer at (0,0) size 800x600
+  RenderView at (0,0) size 800x600
+layer at (0,0) size 800x464
+  RenderBlock {HTML} at (0,0) size 800x464
+RenderBody {BODY} at (4,4) size 137x452 [border: (1px dashed #C0C0C0)]
+  RenderBlock {P} at (1,10) size 135x27
+RenderText {#text} at (0,-1) size 135x28
+  text run at (0,-1) width 133: The following six blue boxes must
+  text run at (0,8) width 135: be of the same width. There must be
+  text run at (0,17) width 26: no red.
+  RenderBlock {P} at (10,46) size 117x27 [bgcolor=#008000] [border: (9px solid #FF)]
+RenderText {#text} at (9,8) size 2x10
+  text run at (9,8) width 2:  
+  RenderBlock {P} at (1,127) size 135x9
+RenderText {#text} at (0,-1) size 12x10
+  text run at (0,-1) width 12:   
+RenderText {#text} at (0,0) size 0x0
+RenderEmbeddedObject {OBJECT} at (9,0) size 117x43 [bgcolor=#FF] [border: (9px solid #FF)]
+  layer at (0,0) size 99x25
+RenderView at (0,0) size 99x25
+  layer at (0,0) size 99x25
+RenderSVGRoot {svg} at (0,0) size 99x25
+  RenderSVGRect {rect} at (0,0) size 99x25 [stroke={[type=SOLID] [color=#008000] [stroke width=12.00]}] [fill={[type=SOLID] [color=#00FF00]}] [x=0.00] [y=0.00] [width=1000.00] [height=250.00]
+  RenderSVGPath {path} at (14,4) size 71x16 [fill={[type=SOLID] [color=#008000]}] [data="" 500 50 L 150 200 L 850 200 Z]
+  RenderBlock {P} at (1,190) size 135x9
+RenderEmbeddedObject {OBJECT} at (9,0) size 117x43 [bgcolor=#FF] [border: (9px solid #FF)]
+  layer at (0,0) size 99x25
+RenderView at (0,0) size 99x25
+  layer at (0,0) size 99x25
+RenderSVGRoot {svg} at (0,0) size 99x25
+  RenderSVGRect {rect} at (0,0) size 99x25 [stroke={[type=SOLID] [color=#008000] [stroke width=12.00]}] [fill={[type=SOLID] [color=#00FF00]}] [x=0.00] [y=0.00] [width=1000.00] [height=250.00]
+  RenderSVGPath {path} at (14,4) size 71x16 [fill={[type=SOLID] [color=#008000]}] [data="" 500 50 L 150 200 L 850 200 Z]
+  RenderTable at (1,253) size 135x45
+RenderTableSection (anonymous) at (0,0) size 135x45
+  RenderTableRow (anonymous) at (0,0) size 135x45
+RenderTableCell {P} at (0,0) size 135x45 [r=0 c=0 rs=1 cs=1]
+  RenderEmbeddedObject {OBJECT} at (9,0) size 117x43 [bgcolor=#FF] [border: (9px solid #FF)]
+layer at (0,0) size 99x25
+  RenderView at (0,0) size 99x25
+layer at (0,0) size 99x25
+  RenderSVGRoot {svg} at (0,0) size 99x25
+

[webkit-changes] [139811] trunk/Source/WebCore

[antti]

Title: [139811] trunk/Source/WebCore








Revision 139811
Author an...@apple.com
Date 2013-01-15 17:07:31 -0800 (Tue, 15 Jan 2013)


Log Message
ASSERT(!m_queue.killed()  m_threadID) hit in StorageThread::scheduleTask on low memory warning
https://bugs.webkit.org/show_bug.cgi?id=106960

Reviewed by Mark Rowe.

We were scheduling a memory clearing task to terminated StorageThreads.

Remove thread from the active thread list when terminate is scheduled. Add when thread is started.

* storage/StorageThread.cpp:
(WebCore::activeStorageThreads):
(WebCore::StorageThread::StorageThread):
(WebCore::StorageThread::~StorageThread):
(WebCore::StorageThread::start):
(WebCore::StorageThread::terminate):
(WebCore::StorageThread::releaseFastMallocFreeMemoryInAllThreads):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/storage/StorageThread.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (139810 => 139811)

--- trunk/Source/WebCore/ChangeLog	2013-01-16 00:45:22 UTC (rev 139810)
+++ trunk/Source/WebCore/ChangeLog	2013-01-16 01:07:31 UTC (rev 139811)
@@ -1,3 +1,22 @@
+2013-01-15  Antti Koivisto  an...@apple.com
+
+ASSERT(!m_queue.killed()  m_threadID) hit in StorageThread::scheduleTask on low memory warning
+https://bugs.webkit.org/show_bug.cgi?id=106960
+
+Reviewed by Mark Rowe.
+
+We were scheduling a memory clearing task to terminated StorageThreads.
+
+Remove thread from the active thread list when terminate is scheduled. Add when thread is started.
+
+* storage/StorageThread.cpp:
+(WebCore::activeStorageThreads):
+(WebCore::StorageThread::StorageThread):
+(WebCore::StorageThread::~StorageThread):
+(WebCore::StorageThread::start):
+(WebCore::StorageThread::terminate):
+(WebCore::StorageThread::releaseFastMallocFreeMemoryInAllThreads):
+
 2013-01-15  Luke Macpherson   macpher...@chromium.org
 
 Don't do indiscriminate cast  call in StylePropertySet::PropertyReference::cssName() on release builds.


Modified: trunk/Source/WebCore/storage/StorageThread.cpp (139810 => 139811)

--- trunk/Source/WebCore/storage/StorageThread.cpp	2013-01-16 00:45:22 UTC (rev 139810)
+++ trunk/Source/WebCore/storage/StorageThread.cpp	2013-01-16 01:07:31 UTC (rev 139811)
@@ -34,7 +34,7 @@
 
 namespace WebCore {
 
-static HashSetStorageThread* storageThreads()
+static HashSetStorageThread* activeStorageThreads()
 {
 ASSERT(isMainThread());
 DEFINE_STATIC_LOCAL(HashSetStorageThread*, threads, ());
@@ -50,14 +50,12 @@
 : m_threadID(0)
 {
 ASSERT(isMainThread());
-storageThreads().add(this);
 }
 
 StorageThread::~StorageThread()
 {
 ASSERT(isMainThread());
 ASSERT(!m_threadID);
-storageThreads().remove(this);
 }
 
 bool StorageThread::start()
@@ -65,6 +63,7 @@
 ASSERT(isMainThread());
 if (!m_threadID)
 m_threadID = createThread(StorageThread::threadEntryPointCallback, this, WebCore: LocalStorage);
+activeStorageThreads().add(this);
 return m_threadID;
 }
 
@@ -95,6 +94,7 @@
 {
 ASSERT(isMainThread());
 ASSERT(!m_queue.killed()  m_threadID);
+activeStorageThreads().remove(this);
 // Even in weird, exceptional cases, don't wait on a nonexistent thread to terminate.
 if (!m_threadID)
 return;
@@ -113,7 +113,7 @@
 
 void StorageThread::releaseFastMallocFreeMemoryInAllThreads()
 {
-HashSetStorageThread* threads = storageThreads();
+HashSetStorageThread* threads = activeStorageThreads();
 HashSetStorageThread*::iterator end = threads.end();
 for (HashSetStorageThread*::iterator it = threads.begin(); it != end; ++it)
 (*it)-scheduleTask(StorageTask::createReleaseFastMallocFreeMemory());






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [139812] trunk/Source/JavaScriptCore

[psolanki]

Title: [139812] trunk/Source/_javascript_Core








Revision 139812
Author psola...@apple.com
Date 2013-01-15 17:33:30 -0800 (Tue, 15 Jan 2013)


Log Message
Use MADV_FREE_REUSABLE to return JIT memory to OS
https://bugs.webkit.org/show_bug.cgi?id=106830
rdar://problem/11437701

Reviewed by Geoffrey Garen.

Use MADV_FREE_REUSABLE to return JIT memory on OSes that have the underlying madvise bug
fixed.

* jit/ExecutableAllocatorFixedVMPool.cpp:
(JSC::FixedVMPoolExecutableAllocator::notifyPageIsFree):

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/jit/ExecutableAllocatorFixedVMPool.cpp




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (139811 => 139812)

--- trunk/Source/_javascript_Core/ChangeLog	2013-01-16 01:07:31 UTC (rev 139811)
+++ trunk/Source/_javascript_Core/ChangeLog	2013-01-16 01:33:30 UTC (rev 139812)
@@ -1,3 +1,17 @@
+2013-01-15  Pratik Solanki  psola...@apple.com
+
+Use MADV_FREE_REUSABLE to return JIT memory to OS
+https://bugs.webkit.org/show_bug.cgi?id=106830
+rdar://problem/11437701
+
+Reviewed by Geoffrey Garen.
+
+Use MADV_FREE_REUSABLE to return JIT memory on OSes that have the underlying madvise bug
+fixed.
+
+* jit/ExecutableAllocatorFixedVMPool.cpp:
+(JSC::FixedVMPoolExecutableAllocator::notifyPageIsFree):
+
 2013-01-15  Levi Weintraub  le...@chromium.org
 
 Unreviewed, rolling out r139790.


Modified: trunk/Source/_javascript_Core/jit/ExecutableAllocatorFixedVMPool.cpp (139811 => 139812)

--- trunk/Source/_javascript_Core/jit/ExecutableAllocatorFixedVMPool.cpp	2013-01-16 01:07:31 UTC (rev 139811)
+++ trunk/Source/_javascript_Core/jit/ExecutableAllocatorFixedVMPool.cpp	2013-01-16 01:33:30 UTC (rev 139812)
@@ -40,6 +40,11 @@
 #include stdio.h
 #endif
 
+#if !PLATFORM(IOS)  PLATFORM(MAC)  __MAC_OS_X_VERSION_MIN_REQUIRED  1090
+// MADV_FREE_REUSABLE does not work for JIT memory on older OSes so use MADV_FREE in that case.
+#define WTF_USE_MADV_FREE_FOR_JIT_MEMORY 1
+#endif
+
 using namespace WTF;
 
 namespace JSC {
@@ -74,7 +79,7 @@
 
 virtual void notifyNeedPage(void* page)
 {
-#if OS(DARWIN)
+#if USE(MADV_FREE_FOR_JIT_MEMORY)
 UNUSED_PARAM(page);
 #else
 m_reservation.commit(page, pageSize());
@@ -83,7 +88,7 @@
 
 virtual void notifyPageIsFree(void* page)
 {
-#if OS(DARWIN)
+#if USE(MADV_FREE_FOR_JIT_MEMORY)
 for (;;) {
 int result = madvise(page, pageSize(), MADV_FREE);
 if (!result)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [139813] branches/chromium/1364/Source/WebKit/chromium

[kerz]

Title: [139813] branches/chromium/1364/Source/WebKit/chromium








Revision 139813
Author k...@chromium.org
Date 2013-01-15 17:38:38 -0800 (Tue, 15 Jan 2013)


Log Message
Merge 138893
 Add function to move caret selection towards a point
 https://bugs.webkit.org/show_bug.cgi?id=105189
 
 Patch by Chris Hopman cjhop...@google.com on 2013-01-05
 Reviewed by Eric Seidel.
 
 This function moves the selection to the corresponding point in the
 rootEditableElement of the current selection. Used on Android for
 the behavior of insertion handles (i.e. dragging the caret around).
 
 * public/WebFrame.h:
 (WebFrame):
 * src/WebFrameImpl.cpp:
 (WebKit::WebFrameImpl::moveCaretSelectionTowardsWindowPoint):
 (WebKit):
 * src/WebFrameImpl.h:
 (WebFrameImpl):

TBR=commit-qu...@webkit.org
Review URL: https://codereview.chromium.org/11931008

Modified Paths

branches/chromium/1364/Source/WebKit/chromium/ChangeLog
branches/chromium/1364/Source/WebKit/chromium/public/WebFrame.h
branches/chromium/1364/Source/WebKit/chromium/src/WebFrameImpl.cpp
branches/chromium/1364/Source/WebKit/chromium/src/WebFrameImpl.h




Diff

Modified: branches/chromium/1364/Source/WebKit/chromium/ChangeLog (139812 => 139813)

--- branches/chromium/1364/Source/WebKit/chromium/ChangeLog	2013-01-16 01:33:30 UTC (rev 139812)
+++ branches/chromium/1364/Source/WebKit/chromium/ChangeLog	2013-01-16 01:38:38 UTC (rev 139813)
@@ -1,796 +1,3 @@
-2013-01-10  John Mellor  joh...@chromium.org
-
-Fix scale of screen.width, window.outerWidth and @media device-width when page scale not applied in compositor.
-https://bugs.webkit.org/show_bug.cgi?id=106460
-
-Reviewed by Kenneth Rohde Christiansen.
-
-1. Exposes the existing applyDeviceScaleFactorInCompositor from
-WebSettings on Settings (and stores the value there instead), so it can
-be accessed from WebCore.
-
-2. Changes ChromeClientImpl::windowRect to return values in density
-independent (UI) pixels pixels instead of physical screen pixels (see
-explanation in Source/WebCore/ChangeLog).
-
-* src/ChromeClientImpl.cpp:
-(WebKit::ChromeClientImpl::windowRect):
-Normalizes window rect scale.
-* src/WebSettingsImpl.cpp:
-(WebKit::WebSettingsImpl::WebSettingsImpl):
-(WebKit::WebSettingsImpl::setApplyDeviceScaleFactorInCompositor):
-(WebKit::WebSettingsImpl::applyDeviceScaleFactorInCompositor):
-(WebKit):
-* src/WebSettingsImpl.h:
-(WebSettingsImpl):
-
-2013-01-10  Sheriff Bot  webkit.review@gmail.com
-
-Unreviewed.  Rolled DEPS.
-
-* DEPS:
-
-2013-01-10  Dimitri Glazkov  dglaz...@chromium.org
-
-Unreviewed, rolling out r139227.
-http://trac.webkit.org/changeset/139227
-https://bugs.webkit.org/show_bug.cgi?id=106227
-
-Broke Win component build.
-
-* public/WebAccessibilityObject.h:
-* public/WebAccessibilityRole.h:
-* public/WebActiveWheelFlingParameters.h:
-* public/WebAnimationController.h:
-* public/WebApplicationCacheHost.h:
-* public/WebApplicationCacheHostClient.h:
-* public/WebArrayBuffer.h:
-* public/WebAudioSourceProvider.h:
-* public/WebBatteryStatus.h:
-* public/WebBindings.h:
-* public/WebBlob.h:
-* public/WebCache.h:
-* public/WebCachedURLRequest.h:
-* public/WebColorChooser.h:
-* public/WebColorChooserClient.h:
-* public/WebColorName.h:
-* public/WebCommonWorkerClient.h:
-* public/WebCompositionUnderline.h:
-* public/WebCompositorInputHandler.h:
-* public/WebConsoleMessage.h:
-* public/WebContentDetectionResult.h:
-* public/WebContextMenuData.h:
-* public/WebCrossOriginPreflightResultCache.h:
-* public/WebCursorInfo.h:
-* public/WebDOMEvent.h:
-* public/WebDOMEventListener.h:
-* public/WebDOMStringList.h:
-* public/WebDataSource.h:
-* public/WebDatabase.h:
-* public/WebDateTimeChooserCompletion.h:
-* public/WebDateTimeChooserParams.h:
-* public/WebDeliveredIntentClient.h:
-* public/WebDevToolsAgent.h:
-* public/WebDevToolsAgentClient.h:
-* public/WebDevToolsFrontend.h:
-* public/WebDeviceOrientationClient.h:
-* public/WebDeviceOrientationClientMock.h:
-* public/WebDeviceOrientationController.h:
-* public/WebDocument.h:
-* public/WebDraggableRegion.h:
-* public/WebExternalPopupMenuClient.h:
-* public/WebFileChooserCompletion.h:
-* public/WebFileChooserParams.h:
-* public/WebFileSystemCallbacks.h:
-* public/WebFileSystemEntry.h:
-* public/WebFileWriter.h:
-* public/WebFileWriterClient.h:
-* public/WebFindOptions.h:
-* public/WebFont.h:
-* public/WebFontCache.h:
-* public/WebFontDescription.h:
-   

[webkit-changes] [139814] trunk/Source/WebCore

[commit-queue]

Title: [139814] trunk/Source/WebCore








Revision 139814
Author commit-qu...@webkit.org
Date 2013-01-15 17:48:37 -0800 (Tue, 15 Jan 2013)


Log Message
Remove Key3 and Challenge Response fields from Websocket implementation and Web Inspector.
https://bugs.webkit.org/show_bug.cgi?id=105738.

Patch by Pan Deng pan.d...@intel.com on 2013-01-15
Reviewed by Kent Tamura.

Key3 and Challenge Response fields were obsoleted in IETF websocket spec, this patch removes related
code in Websocket and Web Inspector

No new tests as no new functionality added.

* Modules/websockets/WebSocketHandshakeRequest.cpp: remove Key3 related code
* Modules/websockets/WebSocketHandshakeRequest.h:
(WebSocketHandshakeRequest):
* Modules/websockets/WebSocketHandshakeResponse.cpp: remove Challenge response related code
* Modules/websockets/WebSocketHandshakeResponse.h:
(WebSocketHandshakeResponse):
* inspector/Inspector.json: remove Key3 and Challenge response fields definition
* inspector/InspectorResourceAgent.cpp: remove Key3 and Challenge response field from inspector agent
(WebCore):
(WebCore::InspectorResourceAgent::willSendWebSocketHandshakeRequest):
(WebCore::InspectorResourceAgent::didReceiveWebSocketHandshakeResponse):
* inspector/front-end/NetworkManager.js:
(WebInspector.NetworkDispatcher.prototype.webSocketWillSendHandshakeRequest):
(WebInspector.NetworkDispatcher.prototype.webSocketHandshakeResponseReceived):
* inspector/front-end/RequestHeadersView.js: remove Key3 and Challenge response item from front-end.
(WebInspector.RequestHeadersView.prototype._refreshRequestHeaders):
(WebInspector.RequestHeadersView.prototype._refreshResponseHeaders):
(WebInspector.RequestHeadersView.prototype._refreshHeaders):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/websockets/WebSocketHandshakeRequest.cpp
trunk/Source/WebCore/Modules/websockets/WebSocketHandshakeRequest.h
trunk/Source/WebCore/Modules/websockets/WebSocketHandshakeResponse.cpp
trunk/Source/WebCore/Modules/websockets/WebSocketHandshakeResponse.h
trunk/Source/WebCore/inspector/Inspector.json
trunk/Source/WebCore/inspector/InspectorResourceAgent.cpp
trunk/Source/WebCore/inspector/front-end/NetworkManager.js
trunk/Source/WebCore/inspector/front-end/RequestHeadersView.js




Diff

Modified: trunk/Source/WebCore/ChangeLog (139813 => 139814)

--- trunk/Source/WebCore/ChangeLog	2013-01-16 01:38:38 UTC (rev 139813)
+++ trunk/Source/WebCore/ChangeLog	2013-01-16 01:48:37 UTC (rev 139814)
@@ -1,3 +1,34 @@
+2013-01-15  Pan Deng  pan.d...@intel.com
+
+Remove Key3 and Challenge Response fields from Websocket implementation and Web Inspector.
+https://bugs.webkit.org/show_bug.cgi?id=105738.
+
+Reviewed by Kent Tamura.
+
+Key3 and Challenge Response fields were obsoleted in IETF websocket spec, this patch removes related
+code in Websocket and Web Inspector
+
+No new tests as no new functionality added.
+
+* Modules/websockets/WebSocketHandshakeRequest.cpp: remove Key3 related code
+* Modules/websockets/WebSocketHandshakeRequest.h: 
+(WebSocketHandshakeRequest):
+* Modules/websockets/WebSocketHandshakeResponse.cpp: remove Challenge response related code
+* Modules/websockets/WebSocketHandshakeResponse.h: 
+(WebSocketHandshakeResponse):
+* inspector/Inspector.json: remove Key3 and Challenge response fields definition
+* inspector/InspectorResourceAgent.cpp: remove Key3 and Challenge response field from inspector agent
+(WebCore):
+(WebCore::InspectorResourceAgent::willSendWebSocketHandshakeRequest):
+(WebCore::InspectorResourceAgent::didReceiveWebSocketHandshakeResponse):
+* inspector/front-end/NetworkManager.js: 
+(WebInspector.NetworkDispatcher.prototype.webSocketWillSendHandshakeRequest): 
+(WebInspector.NetworkDispatcher.prototype.webSocketHandshakeResponseReceived): 
+* inspector/front-end/RequestHeadersView.js: remove Key3 and Challenge response item from front-end.
+(WebInspector.RequestHeadersView.prototype._refreshRequestHeaders):
+(WebInspector.RequestHeadersView.prototype._refreshResponseHeaders):
+(WebInspector.RequestHeadersView.prototype._refreshHeaders):
+
 2013-01-15  Antti Koivisto  an...@apple.com
 
 ASSERT(!m_queue.killed()  m_threadID) hit in StorageThread::scheduleTask on low memory warning


Modified: trunk/Source/WebCore/Modules/websockets/WebSocketHandshakeRequest.cpp (139813 => 139814)

--- trunk/Source/WebCore/Modules/websockets/WebSocketHandshakeRequest.cpp	2013-01-16 01:38:38 UTC (rev 139813)
+++ trunk/Source/WebCore/Modules/websockets/WebSocketHandshakeRequest.cpp	2013-01-16 01:48:37 UTC (rev 139814)
@@ -40,16 +40,6 @@
 
 namespace WebCore {
 
-WebSocketHandshakeRequest::Key3::Key3()
-{
-memset(value, 0, sizeof(value));
-}
-
-void WebSocketHandshakeRequest::Key3::set(const unsigned char key3[8])
-{
-memcpy(value, key3, 

[webkit-changes] [139815] trunk/Source/WebCore

[simon . fraser]

Title: [139815] trunk/Source/WebCore








Revision 139815
Author simon.fra...@apple.com
Date 2013-01-15 18:01:39 -0800 (Tue, 15 Jan 2013)


Log Message
Add the ability for a RenderLayerBacking to have a layer that renders backgrounds.
https://bugs.webkit.org/show_bug.cgi?id=106961

Reviewed by Dean Jackson.

In some cases we need a compositing layer to render its background into
a separate GraphicsLayer (e.g. for background-attachment: fixed in some scenarios).

To support this, have RenderLayer optionally create a GraphicsLayer for the background.
Currently nothing causes background layers to get created.

Having a background layer requires that we add an additional containment layer
which encloses the background, primary and foreground layers, since the
background layer has to be composited behind the primary content. This containment
layer gets any transform, including page scale on the RenderView's layer.

No new tests; there's no way to create a background layer yet. This was tested during
development by forcing a background layer.

* rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::updateDebugIndicators): Show borders on both new layers
and repaint counters on the background layer.
(WebCore::RenderLayerBacking::destroyGraphicsLayers): Clear the two new layers.
(WebCore::RenderLayerBacking::updateTransform): If we have a containment layer, it
takes the transform (and clear the transform on the primary layer).
(WebCore::RenderLayerBacking::updateGraphicsLayerConfiguration): Make the background
layer if we need one (currently never).
(WebCore::RenderLayerBacking::updateGraphicsLayerGeometry): Position and size
the containment layer if we have one. If we do, then the m_graphicsLayer will
be at 0,0 in that containment layer. The background layer is also sized similarly
to the foreground layer.
(WebCore::RenderLayerBacking::updateInternalHierarchy): Adapt to the new hierarchy
with containment and background layers if we have them.
(WebCore::RenderLayerBacking::updateBackgroundLayer): Here's where we create the background
and containment layers.
(WebCore::RenderLayerBacking::childForSuperlayers): If we have a containment layer, that's
what gets attached to our parent.
(WebCore::RenderLayerBacking::getCurrentTransform): The containment layer gets the transform
if we have one, so check that here.
(WebCore::RenderLayerBacking::backingStoreMemoryEstimate):
(WebCore::RenderLayerBacking::reportMemoryUsage):
* rendering/RenderLayerBacking.h:
(RenderLayerBacking):
* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::deviceOrPageScaleFactorChanged): We need to start notifying
about page/device scale on the containment layer if there is one (since it takes page scale), so
use childForSuperlayers() rather than just getting the primary layer.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderLayerBacking.cpp
trunk/Source/WebCore/rendering/RenderLayerBacking.h
trunk/Source/WebCore/rendering/RenderLayerCompositor.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (139814 => 139815)

--- trunk/Source/WebCore/ChangeLog	2013-01-16 01:48:37 UTC (rev 139814)
+++ trunk/Source/WebCore/ChangeLog	2013-01-16 02:01:39 UTC (rev 139815)
@@ -1,3 +1,53 @@
+2013-01-15  Simon Fraser  simon.fra...@apple.com
+
+Add the ability for a RenderLayerBacking to have a layer that renders backgrounds.
+https://bugs.webkit.org/show_bug.cgi?id=106961
+
+Reviewed by Dean Jackson.
+
+In some cases we need a compositing layer to render its background into
+a separate GraphicsLayer (e.g. for background-attachment: fixed in some scenarios).
+
+To support this, have RenderLayer optionally create a GraphicsLayer for the background.
+Currently nothing causes background layers to get created.
+
+Having a background layer requires that we add an additional containment layer
+which encloses the background, primary and foreground layers, since the 
+background layer has to be composited behind the primary content. This containment
+layer gets any transform, including page scale on the RenderView's layer.
+
+No new tests; there's no way to create a background layer yet. This was tested during
+development by forcing a background layer.
+
+* rendering/RenderLayerBacking.cpp:
+(WebCore::RenderLayerBacking::updateDebugIndicators): Show borders on both new layers
+and repaint counters on the background layer.
+(WebCore::RenderLayerBacking::destroyGraphicsLayers): Clear the two new layers.
+(WebCore::RenderLayerBacking::updateTransform): If we have a containment layer, it
+takes the transform (and clear the transform on the primary layer).
+(WebCore::RenderLayerBacking::updateGraphicsLayerConfiguration): Make the background
+layer if we need one (currently never).
+

[webkit-changes] [139817] trunk/Source/WebCore

[hayato]

Title: [139817] trunk/Source/WebCore








Revision 139817
Author hay...@chromium.org
Date 2013-01-15 18:06:05 -0800 (Tue, 15 Jan 2013)


Log Message
Group all request parameters which are used to match CSS Rules into a parameter object.
https://bugs.webkit.org/show_bug.cgi?id=106879

Reviewed by Dimitri Glazkov.

Introduces a MatchRequest which groups all request parameters to match CSS rules.

Factoring, no change in behavior.

* css/StyleResolver.cpp:
(WebCore::StyleResolver::collectMatchingRules):
(WebCore::StyleResolver::collectMatchingRulesForRegion):
(WebCore::StyleResolver::matchScopedAuthorRules):
(WebCore::StyleResolver::matchHostRules):
(WebCore::StyleResolver::matchAuthorRules):
(WebCore::StyleResolver::matchUserRules):
(WebCore::StyleResolver::matchUARules):
(WebCore::StyleResolver::collectMatchingRulesForList):
(WebCore::StyleResolver::styleSharingCandidateMatchesRuleSet):
* css/StyleResolver.h:
(WebCore::StyleResolver::MatchRequest::MatchRequest):
(MatchRequest):
(StyleResolver):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/StyleResolver.cpp
trunk/Source/WebCore/css/StyleResolver.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (139816 => 139817)

--- trunk/Source/WebCore/ChangeLog	2013-01-16 02:02:52 UTC (rev 139816)
+++ trunk/Source/WebCore/ChangeLog	2013-01-16 02:06:05 UTC (rev 139817)
@@ -1,3 +1,29 @@
+2013-01-15  Hayato Ito  hay...@chromium.org
+
+Group all request parameters which are used to match CSS Rules into a parameter object.
+https://bugs.webkit.org/show_bug.cgi?id=106879
+
+Reviewed by Dimitri Glazkov.
+
+Introduces a MatchRequest which groups all request parameters to match CSS rules.
+
+Factoring, no change in behavior.
+
+* css/StyleResolver.cpp:
+(WebCore::StyleResolver::collectMatchingRules):
+(WebCore::StyleResolver::collectMatchingRulesForRegion):
+(WebCore::StyleResolver::matchScopedAuthorRules):
+(WebCore::StyleResolver::matchHostRules):
+(WebCore::StyleResolver::matchAuthorRules):
+(WebCore::StyleResolver::matchUserRules):
+(WebCore::StyleResolver::matchUARules):
+(WebCore::StyleResolver::collectMatchingRulesForList):
+(WebCore::StyleResolver::styleSharingCandidateMatchesRuleSet):
+* css/StyleResolver.h:
+(WebCore::StyleResolver::MatchRequest::MatchRequest):
+(MatchRequest):
+(StyleResolver):
+
 2013-01-15  Simon Fraser  simon.fra...@apple.com
 
 Add the ability for a RenderLayerBacking to have a layer that renders backgrounds.


Modified: trunk/Source/WebCore/css/StyleResolver.cpp (139816 => 139817)

--- trunk/Source/WebCore/css/StyleResolver.cpp	2013-01-16 02:02:52 UTC (rev 139816)
+++ trunk/Source/WebCore/css/StyleResolver.cpp	2013-01-16 02:06:05 UTC (rev 139817)
@@ -642,20 +642,20 @@
 
 bool MatchingUARulesScope::m_matchingUARules = false;
 
-void StyleResolver::collectMatchingRules(RuleSet* rules, int firstRuleIndex, int lastRuleIndex, const MatchOptions options)
+void StyleResolver::collectMatchingRules(const MatchRequest matchRequest, int firstRuleIndex, int lastRuleIndex)
 {
-ASSERT(rules);
+ASSERT(matchRequest.ruleSet);
 ASSERT(m_element);
 
 const AtomicString pseudoId = m_element-shadowPseudoId();
 if (!pseudoId.isEmpty()) {
 ASSERT(m_styledElement);
-collectMatchingRulesForList(rules-shadowPseudoElementRules(pseudoId.impl()), firstRuleIndex, lastRuleIndex, options);
+collectMatchingRulesForList(matchRequest.ruleSet-shadowPseudoElementRules(pseudoId.impl()), matchRequest, firstRuleIndex, lastRuleIndex);
 }
 
 #if ENABLE(VIDEO_TRACK)
 if (m_element-webVTTNodeType())
-collectMatchingRulesForList(rules-cuePseudoRules(), firstRuleIndex, lastRuleIndex, options);
+collectMatchingRulesForList(matchRequest.ruleSet-cuePseudoRules(), matchRequest, firstRuleIndex, lastRuleIndex);
 #endif
 // Check whether other types of rules are applicable in the current tree scope. Criteria for this:
 // a) it's a UA rule
@@ -664,38 +664,38 @@
 TreeScope* treeScope = m_element-treeScope();
 if (!MatchingUARulesScope::isMatchingUARules()
  !treeScope-applyAuthorStyles()
- (!options.scope || options.scope-treeScope() != treeScope))
+ (!matchRequest.scope || matchRequest.scope-treeScope() != treeScope))
 return;
 
 // We need to collect the rules for id, class, tag, and everything else into a buffer and
 // then sort the buffer.
 if (m_element-hasID())
-collectMatchingRulesForList(rules-idRules(m_element-idForStyleResolution().impl()), firstRuleIndex, lastRuleIndex, options);
+collectMatchingRulesForList(matchRequest.ruleSet-idRules(m_element-idForStyleResolution().impl()), matchRequest, firstRuleIndex, lastRuleIndex);
 if (m_styledElement  m_styledElement-hasClass()) {
 for (size_t i = 0; i  m_styledElement-classNames().size(); ++i)
-  

[webkit-changes] [139818] trunk/Tools

[rniwa]

Title: [139818] trunk/Tools








Revision 139818
Author rn...@webkit.org
Date 2013-01-15 18:12:33 -0800 (Tue, 15 Jan 2013)


Log Message
Build fix after r139357. The port name of MacWK2EWS should be 'mac-wk2'.

* Scripts/webkitpy/common/config/ports.py:
(MacWK2Port):

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/common/config/ports.py




Diff

Modified: trunk/Tools/ChangeLog (139817 => 139818)

--- trunk/Tools/ChangeLog	2013-01-16 02:06:05 UTC (rev 139817)
+++ trunk/Tools/ChangeLog	2013-01-16 02:12:33 UTC (rev 139818)
@@ -1,3 +1,10 @@
+2013-01-15  Ryosuke Niwa  rn...@webkit.org
+
+Build fix after r139357. The port name of MacWK2EWS should be 'mac-wk2'.
+
+* Scripts/webkitpy/common/config/ports.py:
+(MacWK2Port):
+
 2013-01-15  Alan Cutter  alancut...@chromium.org
 
 Extend sheriffbot's help command to be able to get help on individual commands


Modified: trunk/Tools/Scripts/webkitpy/common/config/ports.py (139817 => 139818)

--- trunk/Tools/Scripts/webkitpy/common/config/ports.py	2013-01-16 02:06:05 UTC (rev 139817)
+++ trunk/Tools/Scripts/webkitpy/common/config/ports.py	2013-01-16 02:12:33 UTC (rev 139818)
@@ -123,7 +123,7 @@
 
 
 class MacWK2Port(DeprecatedPort):
-port_flag_name = mac
+port_flag_name = mac-wk2
 
 def run_webkit_tests_command(self):
 command = super(MacWK2Port, self).run_webkit_tests_command()






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [139819] trunk/Source/WebCore

[roger_fong]

Title: [139819] trunk/Source/WebCore








Revision 139819
Author roger_f...@apple.com
Date 2013-01-15 18:21:45 -0800 (Tue, 15 Jan 2013)


Log Message
Get rid of a straggling dependency on SafariThemeConstants in RenderThemeWin.

Rubberstamped by Timothy Horton.

* rendering/RenderThemeWin.cpp:
(WebCore::RenderThemeWin::supportsClosedCaptioning):
* rendering/RenderThemeWin.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderThemeWin.cpp
trunk/Source/WebCore/rendering/RenderThemeWin.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (139818 => 139819)

--- trunk/Source/WebCore/ChangeLog	2013-01-16 02:12:33 UTC (rev 139818)
+++ trunk/Source/WebCore/ChangeLog	2013-01-16 02:21:45 UTC (rev 139819)
@@ -1,3 +1,13 @@
+2013-01-15  Roger Fong  roger_f...@apple.com
+
+Get rid of a straggling dependency on SafariThemeConstants in RenderThemeWin.
+
+Rubberstamped by Timothy Horton.
+
+* rendering/RenderThemeWin.cpp:
+(WebCore::RenderThemeWin::supportsClosedCaptioning):
+* rendering/RenderThemeWin.h:
+
 2013-01-15  Hayato Ito  hay...@chromium.org
 
 Group all request parameters which are used to match CSS Rules into a parameter object.


Modified: trunk/Source/WebCore/rendering/RenderThemeWin.cpp (139818 => 139819)

--- trunk/Source/WebCore/rendering/RenderThemeWin.cpp	2013-01-16 02:12:33 UTC (rev 139818)
+++ trunk/Source/WebCore/rendering/RenderThemeWin.cpp	2013-01-16 02:21:45 UTC (rev 139819)
@@ -1049,12 +1049,7 @@
 
 bool RenderThemeWin::supportsClosedCaptioning() const
 {
-// We rely on QuickTime to render captions so only enable the button for a video element.
-#if SAFARI_THEME_VERSION = 4
 return true;
-#else
-return false;
-#endif
 }
 
 bool RenderThemeWin::paintMediaFullscreenButton(RenderObject* o, const PaintInfo paintInfo, const IntRect r)


Modified: trunk/Source/WebCore/rendering/RenderThemeWin.h (139818 => 139819)

--- trunk/Source/WebCore/rendering/RenderThemeWin.h	2013-01-16 02:12:33 UTC (rev 139818)
+++ trunk/Source/WebCore/rendering/RenderThemeWin.h	2013-01-16 02:21:45 UTC (rev 139819)
@@ -25,7 +25,6 @@
 #define RenderThemeWin_h
 
 #include RenderTheme.h
-#include SafariTheme/SafariThemeConstants.h
 
 #if WIN32
 typedef void* HANDLE;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [139820] trunk/LayoutTests

[dominicc]

Title: [139820] trunk/LayoutTests








Revision 139820
Author domin...@chromium.org
Date 2013-01-15 18:38:07 -0800 (Tue, 15 Jan 2013)


Log Message
[Chromium] Unreviewed gardening.

Add expectations for this test:

inspector/extensions/extensions-reload.html

This is flakily slow on the Chromium Win7 Release bot.

* platform/chromium/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (139819 => 139820)

--- trunk/LayoutTests/ChangeLog	2013-01-16 02:21:45 UTC (rev 139819)
+++ trunk/LayoutTests/ChangeLog	2013-01-16 02:38:07 UTC (rev 139820)
@@ -1,3 +1,15 @@
+2013-01-15  Dominic Cooney  domin...@chromium.org
+
+[Chromium] Unreviewed gardening.
+
+Add expectations for this test:
+
+inspector/extensions/extensions-reload.html
+
+This is flakily slow on the Chromium Win7 Release bot.
+
+* platform/chromium/TestExpectations:
+
 2013-01-15  Emil A Eklund  e...@chromium.org
 
 Unreviewed mac rebaseline for r139798.


Modified: trunk/LayoutTests/platform/chromium/TestExpectations (139819 => 139820)

--- trunk/LayoutTests/platform/chromium/TestExpectations	2013-01-16 02:21:45 UTC (rev 139819)
+++ trunk/LayoutTests/platform/chromium/TestExpectations	2013-01-16 02:38:07 UTC (rev 139820)
@@ -3720,6 +3720,7 @@
 webkit.org/b/94353 platform/chromium/virtual/softwarecompositing/overflow/overflow-overlay-with-touch.html [ Failure ]
 
 webkit.org/b/90488 [ Win ] http/tests/inspector/network-preflight-options.html [ Pass Slow ]
+webkit.org/b/90488 [ Win ] inspector/extensions/extensions-reload.html [ Pass Slow ]
 
 webkit.org/b/94521 [ Linux ] fast/loader/loadInProgress.html [ Crash Pass ]
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [139821] trunk

[leviw]

Title: [139821] trunk








Revision 139821
Author le...@chromium.org
Date 2013-01-15 18:39:17 -0800 (Tue, 15 Jan 2013)


Log Message
Unreviewed, rolling out r139792.
http://trac.webkit.org/changeset/139792
https://bugs.webkit.org/show_bug.cgi?id=106970

Broke the windows build.

Source/_javascript_Core: 

* bytecode/GlobalResolveInfo.h: Removed property svn:mergeinfo.

Tools: 

* DumpRenderTree/chromium/DRTTestRunner.cpp:
(DRTTestRunner::DRTTestRunner):
(DRTTestRunner::notifyDone):
(DRTTestRunner::reset):
(DRTTestRunner::setAlwaysAcceptCookies):
(DRTTestRunner::setWindowIsKey):
(DRTTestRunner::pathToLocalResource):
(DRTTestRunner::setPOSIXLocale):
(InvokeCallbackTask):
(InvokeCallbackTask::InvokeCallbackTask):
(InvokeCallbackTask::runIfValid):
(DRTTestRunner::setBackingScaleFactor):
* DumpRenderTree/chromium/DRTTestRunner.h:
(DRTTestRunner):
(DRTTestRunner::taskList):
* DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
(WebTestRunner::WebTestDelegate::setDatabaseQuota):
* DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
(WebTestRunner::TestRunner::TestRunner):
(WebTestRunner::TestRunner::reset):
(WebTestRunner::TestRunner::setDatabaseQuota):
* DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
(TestRunner):
* DumpRenderTree/chromium/WebViewHost.cpp:
(WebViewHost::setPendingExtraData):
(WebViewHost::setDeviceScaleFactor):
* DumpRenderTree/chromium/WebViewHost.h:
(WebViewHost):

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Tools/ChangeLog
trunk/Tools/DumpRenderTree/chromium/DRTTestRunner.cpp
trunk/Tools/DumpRenderTree/chromium/DRTTestRunner.h
trunk/Tools/DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h
trunk/Tools/DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp
trunk/Tools/DumpRenderTree/chromium/TestRunner/src/TestRunner.h
trunk/Tools/DumpRenderTree/chromium/WebViewHost.cpp
trunk/Tools/DumpRenderTree/chromium/WebViewHost.h




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (139820 => 139821)

--- trunk/Source/_javascript_Core/ChangeLog	2013-01-16 02:38:07 UTC (rev 139820)
+++ trunk/Source/_javascript_Core/ChangeLog	2013-01-16 02:39:17 UTC (rev 139821)
@@ -1,3 +1,13 @@
+2013-01-15  Levi Weintraub  le...@chromium.org
+
+Unreviewed, rolling out r139792.
+http://trac.webkit.org/changeset/139792
+https://bugs.webkit.org/show_bug.cgi?id=106970
+
+Broke the windows build.
+
+* bytecode/GlobalResolveInfo.h: Removed property svn:mergeinfo.
+
 2013-01-15  Pratik Solanki  psola...@apple.com
 
 Use MADV_FREE_REUSABLE to return JIT memory to OS


Modified: trunk/Tools/ChangeLog (139820 => 139821)

--- trunk/Tools/ChangeLog	2013-01-16 02:38:07 UTC (rev 139820)
+++ trunk/Tools/ChangeLog	2013-01-16 02:39:17 UTC (rev 139821)
@@ -1,3 +1,40 @@
+2013-01-15  Levi Weintraub  le...@chromium.org
+
+Unreviewed, rolling out r139792.
+http://trac.webkit.org/changeset/139792
+https://bugs.webkit.org/show_bug.cgi?id=106970
+
+Broke the windows build.
+
+* DumpRenderTree/chromium/DRTTestRunner.cpp:
+(DRTTestRunner::DRTTestRunner):
+(DRTTestRunner::notifyDone):
+(DRTTestRunner::reset):
+(DRTTestRunner::setAlwaysAcceptCookies):
+(DRTTestRunner::setWindowIsKey):
+(DRTTestRunner::pathToLocalResource):
+(DRTTestRunner::setPOSIXLocale):
+(InvokeCallbackTask):
+(InvokeCallbackTask::InvokeCallbackTask):
+(InvokeCallbackTask::runIfValid):
+(DRTTestRunner::setBackingScaleFactor):
+* DumpRenderTree/chromium/DRTTestRunner.h:
+(DRTTestRunner):
+(DRTTestRunner::taskList):
+* DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
+(WebTestRunner::WebTestDelegate::setDatabaseQuota):
+* DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
+(WebTestRunner::TestRunner::TestRunner):
+(WebTestRunner::TestRunner::reset):
+(WebTestRunner::TestRunner::setDatabaseQuota):
+* DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
+(TestRunner):
+* DumpRenderTree/chromium/WebViewHost.cpp:
+(WebViewHost::setPendingExtraData):
+(WebViewHost::setDeviceScaleFactor):
+* DumpRenderTree/chromium/WebViewHost.h:
+(WebViewHost):
+
 2013-01-15  Ryosuke Niwa  rn...@webkit.org
 
 Build fix after r139357. The port name of MacWK2EWS should be 'mac-wk2'.


Modified: trunk/Tools/DumpRenderTree/chromium/DRTTestRunner.cpp (139820 => 139821)

--- trunk/Tools/DumpRenderTree/chromium/DRTTestRunner.cpp	2013-01-16 02:38:07 UTC (rev 139820)
+++ trunk/Tools/DumpRenderTree/chromium/DRTTestRunner.cpp	2013-01-16 02:39:17 UTC (rev 139821)
@@ -68,6 +68,7 @@
 #include webkit/support/webkit_support.h
 #include algorithm
 #include cctype
+#include clocale
 #include cstdlib
 #include limits
 #include sstream
@@ -115,6 +116,7 @@
 #endif
 bindMethod(notifyDone, DRTTestRunner::notifyDone);
 

[webkit-changes] [139822] trunk/Source

[timothy_horton]

Title: [139822] trunk/Source








Revision 139822
Author timothy_hor...@apple.com
Date 2013-01-15 18:51:17 -0800 (Tue, 15 Jan 2013)


Log Message
Clamp TileCache visibleRect to WKView's visibleRect
https://bugs.webkit.org/show_bug.cgi?id=106601
rdar://problem/12843164

Reviewed by Simon Fraser.

Some clients expand the WKView to be much larger than what is visible on screen, and
control scrolling with their own view. Currently, we will create tiles for the entire
view, consuming a great deal of memory, and can sometimes factor scrollbars which can
never exist into layout. Piggyback on WKView SPI (the property minimumWidthForAutoLayout,
renamed from minimumLayoutWidth) to drop into a mode where we disable main frame scrolling
and respect the WKView's visibleRect when creating tiles.

* UIProcess/API/mac/WKView.mm:
(-[WKView setFrameSize:]): Update the page's viewExposedRect from our visibleRect.
(-[WKView _updateWindowAndViewFrames]): Update the page's viewExposedRect from our visibleRect.
(-[WKView initWithFrame:contextRef:pageGroupRef:relatedToPage:]): The main frame is scrollable by default.
(-[WKView enableFrameSizeUpdates]): If frame size updates become enabled, update the
page's viewExposedRect from our visibleRect.
(-[WKView setMinimumLayoutWidth:]): Rename minimumLayoutWidth property to minimumWidthForAutoLayout.
Warn once if the old one is used.
(-[WKView minimumWidthForAutoLayout]):
(-[WKView setMinimumWidthForAutoLayout:]): Adjust the minimum layout width, whether the main frame
is scrollable, and update the page's viewExposedRect if needed.
* UIProcess/API/mac/WKViewPrivate.h: Added minimumWidthForAutoLayout property.
* UIProcess/WebPageProxy.h:
(WebPageProxy): Add viewExposedRectChanged/setMainFrameIsScrollable.
* UIProcess/mac/WebPageProxyMac.mm:
(WebKit::WebPageProxy::viewExposedRectChanged): Forward viewExposedRectChanged to WebPage.
(WebKit::WebPageProxy::setMainFrameIsScrollable): Forward setMainFrameIsScrollable to WebPage.
* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::transitionToCommittedForNewPage): Disable scrollbars and scrolling if
main frame scrollability is disabled.
* WebProcess/WebPage/DrawingArea.h:
(WebKit::DrawingArea::setExposedRect): Added empty default implementation.
(WebKit::DrawingArea::mainFrameScrollabilityChanged): Added empty default implementation.
(DrawingArea):
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::windowAndViewFramesChanged): We don't need the WebCore:: namespace.
(WebKit::WebPage::viewExposedRectChanged): Forward exposed rect changes to DrawingArea (only TiledCoreAnimationDrawingArea cares, for now).
(WebKit::WebPage::setMainFrameIsScrollable): Forward scrollability changes to DrawingArea and the main FrameView.
(WebKit::WebPage::drawRectToImage): We don't need the WebCore:: namespace.
* WebProcess/WebPage/WebPage.h:
(WebPage): Add mainFrameIsScrollable, viewExposedRectChanged, setMainFrameIsScrollable, and storage for m_mainFrameIsScrollable.
(WebKit::WebPage::mainFrameIsScrollable):
* WebProcess/WebPage/WebPage.messages.in: Add ViewExposedRectChanged and SetMainFrameIsScrollable messages.
* WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:
(TiledCoreAnimationDrawingArea):
* WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
(WebKit::TiledCoreAnimationDrawingArea::setExposedRect): Forward new exposed rect to TiledBacking (only TileCache cares, for now).
(WebKit::TiledCoreAnimationDrawingArea::mainFrameScrollabilityChanged): Ask TiledBacking to clip to the exposedRect if main frame scrolling is disabled.
(WebKit::TiledCoreAnimationDrawingArea::updateGeometry): Use size instead of viewSize in case we've changed it because of m_minimumLayoutWidth.
(WebKit::TiledCoreAnimationDrawingArea::setRootCompositingLayer): Update exposedRect and clipsToExposedRect.

* platform/graphics/TiledBacking.h:
(TiledBacking): Add setExposedRect and setClipsToExposedRect.
* platform/graphics/ca/mac/TileCache.h:
(TileCache): Add setExposedRect, setClipsToExposedRect, and storage for their respective values.
* platform/graphics/ca/mac/TileCache.mm:
(WebCore::TileCache::TileCache): Initialize m_clipsToExposedRect to false.
(WebCore::TileCache::setExposedRect): Update exposedRect and revalidate tiles.
(WebCore::TileCache::setClipsToExposedRect): Update clipsToExposedRect and revalidate tiles;
if we're going from unclipped to clipped, we already have tiles, so we can skip tile revalidation.
(WebCore::TileCache::computeTileCoverageRect): Intersect exisiting visible rect with
exposed rect to get the visible rect we actually care about.
(WebCore::TileCache::revalidateTiles): Ditto.
* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::requiresOverhangAreasLayer): Don't create an overhang layer if the frame isn't scrollable.
(WebCore::RenderLayerCompositor::requiresContentShadowLayer): Don't create a shadow layer if the frame isn't scrollable.

Modified Paths

trunk/Source/WebCore/ChangeLog

[webkit-changes] [139823] trunk/LayoutTests

[dominicc]

Title: [139823] trunk/LayoutTests








Revision 139823
Author domin...@chromium.org
Date 2013-01-15 19:00:27 -0800 (Tue, 15 Jan 2013)


Log Message
[Chromium] Unreviewed gardening.

Rebaselining this test on Windows:

svg/dynamic-updates/SVGFESpecularLightingElement-remove-lightSource.html

The Chromium XP and Win7 bots' results look consistent and the
spurious grey areas are already being tracked by bug 80517.

* platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-remove-lightSource-expected.png:
* platform/chromium/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/TestExpectations
trunk/LayoutTests/platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-remove-lightSource-expected.png




Diff

Modified: trunk/LayoutTests/ChangeLog (139822 => 139823)

--- trunk/LayoutTests/ChangeLog	2013-01-16 02:51:17 UTC (rev 139822)
+++ trunk/LayoutTests/ChangeLog	2013-01-16 03:00:27 UTC (rev 139823)
@@ -1,3 +1,17 @@
+2013-01-15  Dominic Cooney   domin...@chromium.org
+
+[Chromium] Unreviewed gardening.
+
+Rebaselining this test on Windows:
+
+svg/dynamic-updates/SVGFESpecularLightingElement-remove-lightSource.html
+
+The Chromium XP and Win7 bots' results look consistent and the
+spurious grey areas are already being tracked by bug 80517.
+
+* platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-remove-lightSource-expected.png:
+* platform/chromium/TestExpectations:
+
 2013-01-15  Dominic Cooney  domin...@chromium.org
 
 [Chromium] Unreviewed gardening.


Modified: trunk/LayoutTests/platform/chromium/TestExpectations (139822 => 139823)

--- trunk/LayoutTests/platform/chromium/TestExpectations	2013-01-16 02:51:17 UTC (rev 139822)
+++ trunk/LayoutTests/platform/chromium/TestExpectations	2013-01-16 03:00:27 UTC (rev 139823)
@@ -4379,7 +4379,6 @@
 
 webkit.org/b/106833 fast/borders/outline-alpha-inline.html [ Pass ImageOnlyFailure ]
 webkit.org/b/106858 [ SnowLeopard Debug ] scrollingcoordinator/non-fast-scrollable-region-transformed-iframe.html [ ImageOnlyFailure ]
-webkit.org/b/106875 [ XP ] svg/dynamic-updates/SVGFESpecularLightingElement-remove-lightSource.html [ ImageOnlyFailure ]
 
 # Needs rebaseline after https://bugs.webkit.org/show_bug.cgi?id=106822
 webkit.org/b/106822 svg/zoom/page/zoom-replaced-intrinsic-ratio-001.htm [ Failure Pass ]


Modified: trunk/LayoutTests/platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-remove-lightSource-expected.png

(Binary files differ)





___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [139824] trunk

[charles . wei]

Title: [139824] trunk








Revision 139824
Author charles@torchmobile.com.cn
Date 2013-01-15 19:02:58 -0800 (Tue, 15 Jan 2013)


Log Message
Fullscreen element should not share styles with it's siblings.
https://bugs.webkit.org/show_bug.cgi?id=106888

Reviewed by George Staikos.

Source/WebCore:

Test: fullscreen/full-screen-no-style-sharing.html

* css/StyleResolver.cpp:
(WebCore::StyleResolver::canShareStyleWithElement):

LayoutTests:

* fullscreen/full-screen-no-style-sharing-expected.txt: Added.
* fullscreen/full-screen-no-style-sharing.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/StyleResolver.cpp


Added Paths

trunk/LayoutTests/fullscreen/full-screen-no-style-sharing-expected.txt
trunk/LayoutTests/fullscreen/full-screen-no-style-sharing.html




Diff

Modified: trunk/LayoutTests/ChangeLog (139823 => 139824)

--- trunk/LayoutTests/ChangeLog	2013-01-16 03:00:27 UTC (rev 139823)
+++ trunk/LayoutTests/ChangeLog	2013-01-16 03:02:58 UTC (rev 139824)
@@ -1,3 +1,13 @@
+2013-01-15  Charles Wei  charles@torchmobile.com.cn
+
+Fullscreen element should not share styles with it's siblings.
+https://bugs.webkit.org/show_bug.cgi?id=106888
+
+Reviewed by George Staikos.
+
+* fullscreen/full-screen-no-style-sharing-expected.txt: Added.
+* fullscreen/full-screen-no-style-sharing.html: Added.
+
 2013-01-15  Dominic Cooney   domin...@chromium.org
 
 [Chromium] Unreviewed gardening.


Added: trunk/LayoutTests/fullscreen/full-screen-no-style-sharing-expected.txt (0 => 139824)

--- trunk/LayoutTests/fullscreen/full-screen-no-style-sharing-expected.txt	(rev 0)
+++ trunk/LayoutTests/fullscreen/full-screen-no-style-sharing-expected.txt	2013-01-16 03:02:58 UTC (rev 139824)
@@ -0,0 +1,3 @@
+EVENT(webkitfullscreenchange) TEST(video2.clientWidth==document.body.clientWidth) OK
+END OF TEST
+


Added: trunk/LayoutTests/fullscreen/full-screen-no-style-sharing.html (0 => 139824)

--- trunk/LayoutTests/fullscreen/full-screen-no-style-sharing.html	(rev 0)
+++ trunk/LayoutTests/fullscreen/full-screen-no-style-sharing.html	2013-01-16 03:02:58 UTC (rev 139824)
@@ -0,0 +1,17 @@
+body
+video id=video1 width=1/video
+video id=video2 width=1/video
+script src=""
+script src=""
+script
+var video2 = document.getElementById('video2');
+// Bail out early if the full screen API is not enabled or is missing:
+if (Element.prototype.webkitRequestFullScreen == undefined) {
+logResult(false, Element.prototype.webkitRequestFullScreen == undefined);
+endTest();
+} else {
+waitForEventTestAndEnd(document, 'webkitfullscreenchange', video2.clientWidth==document.body.clientWidth);
+runWithKeyDown(function(){video2.webkitRequestFullScreen()});
+}
+/script
+/body


Modified: trunk/Source/WebCore/ChangeLog (139823 => 139824)

--- trunk/Source/WebCore/ChangeLog	2013-01-16 03:00:27 UTC (rev 139823)
+++ trunk/Source/WebCore/ChangeLog	2013-01-16 03:02:58 UTC (rev 139824)
@@ -1,3 +1,15 @@
+2013-01-15  Charles Wei  charles@torchmobile.com.cn
+
+Fullscreen element should not share styles with it's siblings.
+https://bugs.webkit.org/show_bug.cgi?id=106888
+
+Reviewed by George Staikos.
+
+Test: fullscreen/full-screen-no-style-sharing.html
+
+* css/StyleResolver.cpp:
+(WebCore::StyleResolver::canShareStyleWithElement):
+
 2013-01-15  Tim Horton  timothy_hor...@apple.com
 
 Clamp TileCache visibleRect to WKView's visibleRect


Modified: trunk/Source/WebCore/css/StyleResolver.cpp (139823 => 139824)

--- trunk/Source/WebCore/css/StyleResolver.cpp	2013-01-16 03:00:27 UTC (rev 139823)
+++ trunk/Source/WebCore/css/StyleResolver.cpp	2013-01-16 03:02:58 UTC (rev 139824)
@@ -1245,6 +1245,10 @@
 return false;
 #endif
 
+#if ENABLE(FULLSCREEN_API)
+if (element == element-document()-webkitCurrentFullScreenElement() || m_element == m_element-document()-webkitCurrentFullScreenElement())
+return false;
+#endif
 return true;
 }
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [139825] trunk/Source/WebKit2

[andersca]

Title: [139825] trunk/Source/WebKit2








Revision 139825
Author ander...@apple.com
Date 2013-01-15 19:12:01 -0800 (Tue, 15 Jan 2013)


Log Message
Merge LayerTreeHostCA and LayerTreeHostMac
https://bugs.webkit.org/show_bug.cgi?id=106967

Reviewed by Sam Weinig.

There's no need to have a LayerTreeHostCA base class anymore, just merge it into LayerTreeHostMac.

* WebKit2.xcodeproj/project.pbxproj:
* WebProcess/WebPage/ca/LayerTreeHostCA.cpp: Removed.
* WebProcess/WebPage/ca/LayerTreeHostCA.h: Removed.
* WebProcess/WebPage/mac/LayerTreeHostMac.h:
(LayerTreeHostMac):
* WebProcess/WebPage/mac/LayerTreeHostMac.mm:
(WebKit::LayerTreeHostMac::LayerTreeHostMac):
(WebKit::LayerTreeHostMac::~LayerTreeHostMac):
(WebKit::LayerTreeHostMac::layerTreeContext):
(WebKit::LayerTreeHostMac::setShouldNotifyAfterNextScheduledLayerFlush):
(WebKit):
(WebKit::LayerTreeHostMac::setRootCompositingLayer):
(WebKit::LayerTreeHostMac::invalidate):
(WebKit::LayerTreeHostMac::setNonCompositedContentsNeedDisplay):
(WebKit::LayerTreeHostMac::scrollNonCompositedContents):
(WebKit::LayerTreeHostMac::forceRepaint):
(WebKit::LayerTreeHostMac::sizeDidChange):
(WebKit::LayerTreeHostMac::deviceScaleFactorDidChange):
(WebKit::LayerTreeHostMac::didInstallPageOverlay):
(WebKit::LayerTreeHostMac::didUninstallPageOverlay):
(WebKit::LayerTreeHostMac::setPageOverlayNeedsDisplay):
(WebKit::LayerTreeHostMac::pauseRendering):
(WebKit::LayerTreeHostMac::resumeRendering):
(WebKit::LayerTreeHostMac::setLayerHostingMode):
(WebKit::LayerTreeHostMac::notifyAnimationStarted):
(WebKit::LayerTreeHostMac::notifyFlushRequired):
(WebKit::LayerTreeHostMac::paintContents):
(WebKit::LayerTreeHostMac::deviceScaleFactor):
(WebKit::LayerTreeHostMac::flushLayers):
(WebKit::LayerTreeHostMac::initialize):
(WebKit::LayerTreeHostMac::performScheduledLayerFlush):
(WebKit::LayerTreeHostMac::flushPendingLayerChanges):
(WebKit::LayerTreeHostMac::createPageOverlayLayer):
(WebKit::LayerTreeHostMac::destroyPageOverlayLayer):

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/WebKit2.xcodeproj/project.pbxproj
trunk/Source/WebKit2/WebProcess/WebPage/mac/LayerTreeHostMac.h
trunk/Source/WebKit2/WebProcess/WebPage/mac/LayerTreeHostMac.mm


Removed Paths

trunk/Source/WebKit2/WebProcess/WebPage/ca/LayerTreeHostCA.cpp
trunk/Source/WebKit2/WebProcess/WebPage/ca/LayerTreeHostCA.h




Diff

Modified: trunk/Source/WebKit2/ChangeLog (139824 => 139825)

--- trunk/Source/WebKit2/ChangeLog	2013-01-16 03:02:58 UTC (rev 139824)
+++ trunk/Source/WebKit2/ChangeLog	2013-01-16 03:12:01 UTC (rev 139825)
@@ -1,3 +1,47 @@
+2013-01-15  Anders Carlsson  ander...@apple.com
+
+Merge LayerTreeHostCA and LayerTreeHostMac
+https://bugs.webkit.org/show_bug.cgi?id=106967
+
+Reviewed by Sam Weinig.
+
+There's no need to have a LayerTreeHostCA base class anymore, just merge it into LayerTreeHostMac.
+
+* WebKit2.xcodeproj/project.pbxproj:
+* WebProcess/WebPage/ca/LayerTreeHostCA.cpp: Removed.
+* WebProcess/WebPage/ca/LayerTreeHostCA.h: Removed.
+* WebProcess/WebPage/mac/LayerTreeHostMac.h:
+(LayerTreeHostMac):
+* WebProcess/WebPage/mac/LayerTreeHostMac.mm:
+(WebKit::LayerTreeHostMac::LayerTreeHostMac):
+(WebKit::LayerTreeHostMac::~LayerTreeHostMac):
+(WebKit::LayerTreeHostMac::layerTreeContext):
+(WebKit::LayerTreeHostMac::setShouldNotifyAfterNextScheduledLayerFlush):
+(WebKit):
+(WebKit::LayerTreeHostMac::setRootCompositingLayer):
+(WebKit::LayerTreeHostMac::invalidate):
+(WebKit::LayerTreeHostMac::setNonCompositedContentsNeedDisplay):
+(WebKit::LayerTreeHostMac::scrollNonCompositedContents):
+(WebKit::LayerTreeHostMac::forceRepaint):
+(WebKit::LayerTreeHostMac::sizeDidChange):
+(WebKit::LayerTreeHostMac::deviceScaleFactorDidChange):
+(WebKit::LayerTreeHostMac::didInstallPageOverlay):
+(WebKit::LayerTreeHostMac::didUninstallPageOverlay):
+(WebKit::LayerTreeHostMac::setPageOverlayNeedsDisplay):
+(WebKit::LayerTreeHostMac::pauseRendering):
+(WebKit::LayerTreeHostMac::resumeRendering):
+(WebKit::LayerTreeHostMac::setLayerHostingMode):
+(WebKit::LayerTreeHostMac::notifyAnimationStarted):
+(WebKit::LayerTreeHostMac::notifyFlushRequired):
+(WebKit::LayerTreeHostMac::paintContents):
+(WebKit::LayerTreeHostMac::deviceScaleFactor):
+(WebKit::LayerTreeHostMac::flushLayers):
+(WebKit::LayerTreeHostMac::initialize):
+(WebKit::LayerTreeHostMac::performScheduledLayerFlush):
+(WebKit::LayerTreeHostMac::flushPendingLayerChanges):
+(WebKit::LayerTreeHostMac::createPageOverlayLayer):
+(WebKit::LayerTreeHostMac::destroyPageOverlayLayer):
+
 2013-01-15  Tim Horton  timothy_hor...@apple.com
 
 Clamp TileCache visibleRect to WKView's visibleRect


Modified: trunk/Source/WebKit2/WebKit2.xcodeproj/project.pbxproj 

[webkit-changes] [139826] trunk/LayoutTests

[dominicc]

Title: [139826] trunk/LayoutTests








Revision 139826
Author domin...@chromium.org
Date 2013-01-15 19:20:01 -0800 (Tue, 15 Jan 2013)


Log Message
[Chromium] Unreviewed gardening.

Add expectations for this test:

scrollingcoordinator/non-fast-scrollable-region-scaled-iframe.html

On the Chromium Mac Debug bot it is drawn with system scrollbars;
see https://bugs.webkit.org/show_bug.cgi?id=106858

* platform/chromium/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (139825 => 139826)

--- trunk/LayoutTests/ChangeLog	2013-01-16 03:12:01 UTC (rev 139825)
+++ trunk/LayoutTests/ChangeLog	2013-01-16 03:20:01 UTC (rev 139826)
@@ -1,3 +1,16 @@
+2013-01-15  Dominic Cooney  domin...@chromium.org
+
+[Chromium] Unreviewed gardening.
+
+Add expectations for this test:
+
+scrollingcoordinator/non-fast-scrollable-region-scaled-iframe.html
+
+On the Chromium Mac Debug bot it is drawn with system scrollbars;
+see https://bugs.webkit.org/show_bug.cgi?id=106858
+
+* platform/chromium/TestExpectations:
+
 2013-01-15  Charles Wei  charles@torchmobile.com.cn
 
 Fullscreen element should not share styles with it's siblings.


Modified: trunk/LayoutTests/platform/chromium/TestExpectations (139825 => 139826)

--- trunk/LayoutTests/platform/chromium/TestExpectations	2013-01-16 03:12:01 UTC (rev 139825)
+++ trunk/LayoutTests/platform/chromium/TestExpectations	2013-01-16 03:20:01 UTC (rev 139826)
@@ -4379,6 +4379,7 @@
 
 webkit.org/b/106833 fast/borders/outline-alpha-inline.html [ Pass ImageOnlyFailure ]
 webkit.org/b/106858 [ SnowLeopard Debug ] scrollingcoordinator/non-fast-scrollable-region-transformed-iframe.html [ ImageOnlyFailure ]
+webkit.org/b/106858 [ Mac Debug ] scrollingcoordinator/non-fast-scrollable-region-scaled-iframe.html [ ImageOnlyFailure ]
 
 # Needs rebaseline after https://bugs.webkit.org/show_bug.cgi?id=106822
 webkit.org/b/106822 svg/zoom/page/zoom-replaced-intrinsic-ratio-001.htm [ Failure Pass ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [139827] trunk/Tools

[dpranke]

Title: [139827] trunk/Tools








Revision 139827
Author dpra...@chromium.org
Date 2013-01-15 19:44:37 -0800 (Tue, 15 Jan 2013)


Log Message
webkitpy.layout_tests.servers.http_server_unittest.TestHttpServer.test_win32_start_and_stop is flaky
https://bugs.webkit.org/show_bug.cgi?id=106974

Reviewed by Ryosuke Niwa.

I forgot to stub out the call to check to ensure that the ports were
available, so this test could fail if something was listening on 8000 or
8443 on the machine.

* Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
(TestHttpServer.test_win32_start_and_stop):

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/layout_tests/servers/http_server_unittest.py




Diff

Modified: trunk/Tools/ChangeLog (139826 => 139827)

--- trunk/Tools/ChangeLog	2013-01-16 03:20:01 UTC (rev 139826)
+++ trunk/Tools/ChangeLog	2013-01-16 03:44:37 UTC (rev 139827)
@@ -1,3 +1,17 @@
+2013-01-15  Dirk Pranke  dpra...@chromium.org
+
+webkitpy.layout_tests.servers.http_server_unittest.TestHttpServer.test_win32_start_and_stop is flaky
+https://bugs.webkit.org/show_bug.cgi?id=106974
+
+Reviewed by Ryosuke Niwa.
+
+I forgot to stub out the call to check to ensure that the ports were
+available, so this test could fail if something was listening on 8000 or
+8443 on the machine.
+
+* Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
+(TestHttpServer.test_win32_start_and_stop):
+
 2013-01-15  Levi Weintraub  le...@chromium.org
 
 Unreviewed, rolling out r139792.


Modified: trunk/Tools/Scripts/webkitpy/layout_tests/servers/http_server_unittest.py (139826 => 139827)

--- trunk/Tools/Scripts/webkitpy/layout_tests/servers/http_server_unittest.py	2013-01-16 03:20:01 UTC (rev 139826)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/servers/http_server_unittest.py	2013-01-16 03:44:37 UTC (rev 139827)
@@ -78,6 +78,7 @@
   additional_dirs={
   /mock/one-additional-dir: /mock-checkout/one-additional-dir,
   /mock/another-additional-dir: /mock-checkout/one-additional-dir})
+server._check_that_all_ports_are_available = lambda: True
 server._is_server_running_on_all_ports = lambda: True
 
 server.start()






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [139829] trunk/Source

[vollick]

Title: [139829] trunk/Source








Revision 139829
Author voll...@chromium.org
Date 2013-01-15 20:36:33 -0800 (Tue, 15 Jan 2013)


Log Message
[chromium] Create GraphicsLayerChromiums using a factory
https://bugs.webkit.org/show_bug.cgi?id=103635

Reviewed by James Robinson.

Refactor graphics layer creation for chromium to go through a factory.

Source/WebCore:

No new tests, no change in functionality.

* platform/graphics/chromium/GraphicsLayerChromium.cpp:
(WebCore::GraphicsLayer::create):

Source/WebKit/chromium:

* src/ChromeClientImpl.cpp:
(WebCore):
(GraphicsLayerFactoryChromium):
(WebCore::GraphicsLayerFactoryChromium::~GraphicsLayerFactoryChromium):
(WebKit::ChromeClientImpl::ChromeClientImpl):
(WebKit::ChromeClientImpl::graphicsLayerFactory):
(WebKit):
* src/ChromeClientImpl.h:
(WebCore):
(ChromeClientImpl):
* src/NonCompositedContentHost.cpp:
(WebKit::NonCompositedContentHost::NonCompositedContentHost):
* src/NonCompositedContentHost.h:
(WebCore):
(WebKit::NonCompositedContentHost::create):
(NonCompositedContentHost):
* src/PageOverlay.cpp:
(WebKit::PageOverlay::update):
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::graphicsLayerFactory):
(WebKit):
(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
* src/WebViewImpl.h:
(WebCore):
(WebViewImpl):
* tests/GraphicsLayerChromiumTest.cpp:
(WebKit::GraphicsLayerChromiumTest::GraphicsLayerChromiumTest):
* tests/ImageLayerChromiumTest.cpp:
(WebCore::TEST):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/chromium/GraphicsLayerChromium.cpp
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/src/ChromeClientImpl.cpp
trunk/Source/WebKit/chromium/src/ChromeClientImpl.h
trunk/Source/WebKit/chromium/src/NonCompositedContentHost.cpp
trunk/Source/WebKit/chromium/src/NonCompositedContentHost.h
trunk/Source/WebKit/chromium/src/PageOverlay.cpp
trunk/Source/WebKit/chromium/src/WebViewImpl.cpp
trunk/Source/WebKit/chromium/src/WebViewImpl.h
trunk/Source/WebKit/chromium/tests/GraphicsLayerChromiumTest.cpp
trunk/Source/WebKit/chromium/tests/ImageLayerChromiumTest.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (139828 => 139829)

--- trunk/Source/WebCore/ChangeLog	2013-01-16 03:53:35 UTC (rev 139828)
+++ trunk/Source/WebCore/ChangeLog	2013-01-16 04:36:33 UTC (rev 139829)
@@ -1,3 +1,17 @@
+2013-01-15  Ian Vollick  voll...@chromium.org
+
+[chromium] Create GraphicsLayerChromiums using a factory
+https://bugs.webkit.org/show_bug.cgi?id=103635
+
+Reviewed by James Robinson.
+
+Refactor graphics layer creation for chromium to go through a factory.
+
+No new tests, no change in functionality.
+
+* platform/graphics/chromium/GraphicsLayerChromium.cpp:
+(WebCore::GraphicsLayer::create):
+
 2013-01-15  Charles Wei  charles@torchmobile.com.cn
 
 [BlackBerry]  LayerRenderingResults doesn't need to maintain the hole punch rect


Modified: trunk/Source/WebCore/platform/graphics/chromium/GraphicsLayerChromium.cpp (139828 => 139829)

--- trunk/Source/WebCore/platform/graphics/chromium/GraphicsLayerChromium.cpp	2013-01-16 03:53:35 UTC (rev 139828)
+++ trunk/Source/WebCore/platform/graphics/chromium/GraphicsLayerChromium.cpp	2013-01-16 04:36:33 UTC (rev 139829)
@@ -84,15 +84,13 @@
 
 PassOwnPtrGraphicsLayer GraphicsLayer::create(GraphicsLayerFactory* factory, GraphicsLayerClient* client)
 {
-if (!factory)
-return adoptPtr(new GraphicsLayerChromium(client));
-
 return factory-createGraphicsLayer(client);
 }
 
 PassOwnPtrGraphicsLayer GraphicsLayer::create(GraphicsLayerClient* client)
 {
-return adoptPtr(new GraphicsLayerChromium(client));
+ASSERT_NOT_REACHED();
+return nullptr;
 }
 
 GraphicsLayerChromium::GraphicsLayerChromium(GraphicsLayerClient* client)


Modified: trunk/Source/WebKit/chromium/ChangeLog (139828 => 139829)

--- trunk/Source/WebKit/chromium/ChangeLog	2013-01-16 03:53:35 UTC (rev 139828)
+++ trunk/Source/WebKit/chromium/ChangeLog	2013-01-16 04:36:33 UTC (rev 139829)
@@ -1,3 +1,42 @@
+2013-01-15  Ian Vollick  voll...@chromium.org
+
+[chromium] Create GraphicsLayerChromiums using a factory
+https://bugs.webkit.org/show_bug.cgi?id=103635
+
+Reviewed by James Robinson.
+
+Refactor graphics layer creation for chromium to go through a factory.
+
+* src/ChromeClientImpl.cpp:
+(WebCore):
+(GraphicsLayerFactoryChromium):
+(WebCore::GraphicsLayerFactoryChromium::~GraphicsLayerFactoryChromium):
+(WebKit::ChromeClientImpl::ChromeClientImpl):
+(WebKit::ChromeClientImpl::graphicsLayerFactory):
+(WebKit):
+* src/ChromeClientImpl.h:
+(WebCore):
+(ChromeClientImpl):
+* src/NonCompositedContentHost.cpp:
+(WebKit::NonCompositedContentHost::NonCompositedContentHost):
+* src/NonCompositedContentHost.h:
+(WebCore):
+(WebKit::NonCompositedContentHost::create):
+

[webkit-changes] [139830] trunk/Tools

[dpranke]

Title: [139830] trunk/Tools








Revision 139830
Author dpra...@chromium.org
Date 2013-01-15 20:42:47 -0800 (Tue, 15 Jan 2013)


Log Message
remove extraneous output in test-webkitpy
https://bugs.webkit.org/show_bug.cgi?id=106971

Reviewed by Ojan Vafai.

We weren't ignoring or capturing the echoed output from
these two tests, and getting noise in the logs as a result.

* Scripts/webkitpy/common/system/executive_unittest.py:
(ExecutiveTest.test_auto_stringify_args):
(ExecutiveTest.test_popen_args):

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/common/system/executive_unittest.py




Diff

Modified: trunk/Tools/ChangeLog (139829 => 139830)

--- trunk/Tools/ChangeLog	2013-01-16 04:36:33 UTC (rev 139829)
+++ trunk/Tools/ChangeLog	2013-01-16 04:42:47 UTC (rev 139830)
@@ -1,5 +1,19 @@
 2013-01-15  Dirk Pranke  dpra...@chromium.org
 
+remove extraneous output in test-webkitpy
+https://bugs.webkit.org/show_bug.cgi?id=106971
+
+Reviewed by Ojan Vafai.
+
+We weren't ignoring or capturing the echoed output from
+these two tests, and getting noise in the logs as a result.
+
+* Scripts/webkitpy/common/system/executive_unittest.py:
+(ExecutiveTest.test_auto_stringify_args):
+(ExecutiveTest.test_popen_args):
+
+2013-01-15  Dirk Pranke  dpra...@chromium.org
+
 webkitpy.layout_tests.servers.http_server_unittest.TestHttpServer.test_win32_start_and_stop is flaky
 https://bugs.webkit.org/show_bug.cgi?id=106974
 


Modified: trunk/Tools/Scripts/webkitpy/common/system/executive_unittest.py (139829 => 139830)

--- trunk/Tools/Scripts/webkitpy/common/system/executive_unittest.py	2013-01-16 04:36:33 UTC (rev 139829)
+++ trunk/Tools/Scripts/webkitpy/common/system/executive_unittest.py	2013-01-16 04:42:47 UTC (rev 139830)
@@ -116,13 +116,13 @@
 def test_auto_stringify_args(self):
 executive = Executive()
 executive.run_command(command_line('echo', 1))
-executive.popen(command_line('echo', 1)).wait()
+executive.popen(command_line('echo', 1), stdout=executive.PIPE).wait()
 self.assertEqual('echo 1', executive.command_for_printing(['echo', 1]))
 
 def test_popen_args(self):
 executive = Executive()
 # Explicitly naming the 'args' argument should not thow an exception.
-executive.popen(args=command_line('echo', 1)).wait()
+executive.popen(args=command_line('echo', 1), stdout=executive.PIPE).wait()
 
 def test_run_command_with_unicode(self):
 Validate that it is safe to pass unicode() objects






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [139831] trunk/Tools

[dpranke]

Title: [139831] trunk/Tools








Revision 139831
Author dpra...@chromium.org
Date 2013-01-15 20:44:48 -0800 (Tue, 15 Jan 2013)


Log Message
test-webkitpy: truncate output to the terminal width when necessary
https://bugs.webkit.org/show_bug.cgi?id=106973

Reviewed by Ojan Vafai.

this implements the same logic for test-webkitpy that we have
for run-webkit-tests (and ninja).

No tests written as this is exercised by running test-webkitpy itself.

* Scripts/webkitpy/test/printer.py:
(Printer.configure):
(Printer._test_line):

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/test/printer.py




Diff

Modified: trunk/Tools/ChangeLog (139830 => 139831)

--- trunk/Tools/ChangeLog	2013-01-16 04:42:47 UTC (rev 139830)
+++ trunk/Tools/ChangeLog	2013-01-16 04:44:48 UTC (rev 139831)
@@ -1,5 +1,21 @@
 2013-01-15  Dirk Pranke  dpra...@chromium.org
 
+test-webkitpy: truncate output to the terminal width when necessary
+https://bugs.webkit.org/show_bug.cgi?id=106973
+
+Reviewed by Ojan Vafai.
+
+this implements the same logic for test-webkitpy that we have
+for run-webkit-tests (and ninja).
+
+No tests written as this is exercised by running test-webkitpy itself.
+
+* Scripts/webkitpy/test/printer.py:
+(Printer.configure):
+(Printer._test_line):
+
+2013-01-15  Dirk Pranke  dpra...@chromium.org
+
 remove extraneous output in test-webkitpy
 https://bugs.webkit.org/show_bug.cgi?id=106971
 


Modified: trunk/Tools/Scripts/webkitpy/test/printer.py (139830 => 139831)

--- trunk/Tools/Scripts/webkitpy/test/printer.py	2013-01-16 04:42:47 UTC (rev 139830)
+++ trunk/Tools/Scripts/webkitpy/test/printer.py	2013-01-16 04:44:48 UTC (rev 139831)
@@ -25,6 +25,7 @@
 import StringIO
 
 from webkitpy.common.system import outputcapture
+from webkitpy.common.system.systemhost import SystemHost
 from webkitpy.layout_tests.views.metered_stream import MeteredStream
 
 _log = logging.getLogger(__name__)
@@ -57,7 +58,8 @@
 elif options.verbose == 2:
 log_level = logging.DEBUG
 
-self.meter = MeteredStream(self.stream, (options.verbose == 2))
+self.meter = MeteredStream(self.stream, (options.verbose == 2),
+number_of_columns=SystemHost().platform.terminal_width())
 
 handler = logging.StreamHandler(self.stream)
 # We constrain the level on the handler rather than on the root
@@ -159,7 +161,19 @@
 self.completed_tests = []
 
 def _test_line(self, test_name, suffix):
-return '[%d/%d] %s%s' % (self.num_completed, self.num_tests, test_name, suffix)
+format_string = '[%d/%d] %s%s'
+status_line = format_string % (self.num_completed, self.num_tests, test_name, suffix)
+if len(status_line)  self.meter.number_of_columns():
+overflow_columns = len(status_line) - self.meter.number_of_columns()
+ellipsis = '...'
+if len(test_name)  overflow_columns + len(ellipsis) + 3:
+# We don't have enough space even if we elide, just show the test method name.
+test_name = test_name.split('.')[-1]
+else:
+new_length = len(test_name) - overflow_columns - len(ellipsis)
+prefix = int(new_length / 2)
+test_name = test_name[:prefix] + ellipsis + test_name[-(new_length - prefix):]
+return format_string % (self.num_completed, self.num_tests, test_name, suffix)
 
 def print_result(self, run_time):
 write = self.meter.writeln






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [139832] trunk/LayoutTests

[dominicc]

Title: [139832] trunk/LayoutTests








Revision 139832
Author domin...@chromium.org
Date 2013-01-15 21:10:13 -0800 (Tue, 15 Jan 2013)


Log Message
[Chromium] Unreviewed gardening.

Rebaseline this test after r139798:

svg/zoom/page/zoom-replaced-intrinsic-ratio-001.html

* platform/chromium-mac-lion/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.png:
* platform/chromium-mac-snowleopard/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.png:
* platform/chromium-mac/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.png:
* platform/chromium-mac/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt:
* platform/chromium-win/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.png:
* platform/chromium/TestExpectations:
* platform/chromium/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt: Generalize LayoutTests/platform/chromium-win/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/TestExpectations
trunk/LayoutTests/platform/chromium-mac/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.png
trunk/LayoutTests/platform/chromium-mac/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt
trunk/LayoutTests/platform/chromium-mac-lion/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.png
trunk/LayoutTests/platform/chromium-mac-snowleopard/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.png
trunk/LayoutTests/platform/chromium-win/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.png


Added Paths

trunk/LayoutTests/platform/chromium/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt


Removed Paths

trunk/LayoutTests/platform/chromium-win/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (139831 => 139832)

--- trunk/LayoutTests/ChangeLog	2013-01-16 04:44:48 UTC (rev 139831)
+++ trunk/LayoutTests/ChangeLog	2013-01-16 05:10:13 UTC (rev 139832)
@@ -1,3 +1,19 @@
+2013-01-15  Dominic Cooney   domin...@chromium.org
+
+[Chromium] Unreviewed gardening.
+
+Rebaseline this test after r139798:
+
+svg/zoom/page/zoom-replaced-intrinsic-ratio-001.html
+
+* platform/chromium-mac-lion/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.png:
+* platform/chromium-mac-snowleopard/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.png:
+* platform/chromium-mac/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.png:
+* platform/chromium-mac/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt:
+* platform/chromium-win/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.png:
+* platform/chromium/TestExpectations:
+* platform/chromium/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt: Generalize LayoutTests/platform/chromium-win/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt.
+
 2013-01-15  Dominic Cooney  domin...@chromium.org
 
 [Chromium] Unreviewed gardening.


Modified: trunk/LayoutTests/platform/chromium/TestExpectations (139831 => 139832)

--- trunk/LayoutTests/platform/chromium/TestExpectations	2013-01-16 04:44:48 UTC (rev 139831)
+++ trunk/LayoutTests/platform/chromium/TestExpectations	2013-01-16 05:10:13 UTC (rev 139832)
@@ -4380,6 +4380,3 @@
 webkit.org/b/106833 fast/borders/outline-alpha-inline.html [ Pass ImageOnlyFailure ]
 webkit.org/b/106858 [ SnowLeopard Debug ] scrollingcoordinator/non-fast-scrollable-region-transformed-iframe.html [ ImageOnlyFailure ]
 webkit.org/b/106858 [ Mac Debug ] scrollingcoordinator/non-fast-scrollable-region-scaled-iframe.html [ ImageOnlyFailure ]
-
-# Needs rebaseline after https://bugs.webkit.org/show_bug.cgi?id=106822
-webkit.org/b/106822 svg/zoom/page/zoom-replaced-intrinsic-ratio-001.htm [ Failure Pass ]


Copied: trunk/LayoutTests/platform/chromium/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt (from rev 139826, trunk/LayoutTests/platform/chromium-win/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt) (0 => 139832)

--- trunk/LayoutTests/platform/chromium/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt	(rev 0)
+++ trunk/LayoutTests/platform/chromium/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt	2013-01-16 05:10:13 UTC (rev 139832)
@@ -0,0 +1,62 @@
+layer at (0,0) size 800x600
+  RenderView at (0,0) size 800x600
+layer at (0,0) size 800x474
+  RenderBlock {HTML} at (0,0) size 800x474
+RenderBody {BODY} at (4,4) size 142x462 [border: (1px dashed #C0C0C0)]
+  RenderBlock {P} at (1,10) size 139x28
+RenderText {#text} at (0,-2) size 133x30
+  text run at (0,-2) width 130: The following six blue boxes must
+  text run at (0,7) width 133: be of the same width. There must be
+  text run at (0,16) width 26: no red.
+  RenderBlock {P} at (10,46) size 121x28 [bgcolor=#008000] [border: (9px solid 

[webkit-changes] [139833] trunk/Source/WebCore

[rniwa]

Title: [139833] trunk/Source/WebCore








Revision 139833
Author rn...@webkit.org
Date 2013-01-15 21:23:04 -0800 (Tue, 15 Jan 2013)


Log Message
NodeRareData doesn't need to have a vtable pointer
https://bugs.webkit.org/show_bug.cgi?id=106965

Reviewed by Benjamin Poulain.

Made the destructor and reportMemoryUsage of NodeRareDataBase and NodeRareData
respectively and their subclasses non-virtual.

* dom/ElementRareData.cpp:
(SameSizeAsElementRareData): Added.
(WebCore): Added a compile assertion for the size of ElementRareData.
* dom/ElementRareData.h:
(ElementRareData):
* dom/Node.cpp:
(WebCore::Node::clearRareData): Explicitely delete NodeRareData or ElementRareData.
(WebCore::Node::reportMemoryUsage): Explicitely add NodeRareData or ElementRareData.
* dom/Node.h:
(NodeRareDataBase): Deleted the virtual destructor.
* dom/NodeRareData.cpp:
(SameSizeAsNodeRareData): Removed one pointer.
* dom/NodeRareData.h:
(NodeRareData): Removed the virtual destructor.
(NodeRareData::reportMemoryUsage): Made non-virtual.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/ElementRareData.cpp
trunk/Source/WebCore/dom/ElementRareData.h
trunk/Source/WebCore/dom/Node.cpp
trunk/Source/WebCore/dom/Node.h
trunk/Source/WebCore/dom/NodeRareData.cpp
trunk/Source/WebCore/dom/NodeRareData.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (139832 => 139833)

--- trunk/Source/WebCore/ChangeLog	2013-01-16 05:10:13 UTC (rev 139832)
+++ trunk/Source/WebCore/ChangeLog	2013-01-16 05:23:04 UTC (rev 139833)
@@ -1,3 +1,29 @@
+2013-01-15  Ryosuke Niwa  rn...@webkit.org
+
+NodeRareData doesn't need to have a vtable pointer
+https://bugs.webkit.org/show_bug.cgi?id=106965
+
+Reviewed by Benjamin Poulain.
+
+Made the destructor and reportMemoryUsage of NodeRareDataBase and NodeRareData
+respectively and their subclasses non-virtual.
+
+* dom/ElementRareData.cpp:
+(SameSizeAsElementRareData): Added.
+(WebCore): Added a compile assertion for the size of ElementRareData.
+* dom/ElementRareData.h:
+(ElementRareData):
+* dom/Node.cpp:
+(WebCore::Node::clearRareData): Explicitely delete NodeRareData or ElementRareData.
+(WebCore::Node::reportMemoryUsage): Explicitely add NodeRareData or ElementRareData.
+* dom/Node.h:
+(NodeRareDataBase): Deleted the virtual destructor.
+* dom/NodeRareData.cpp:
+(SameSizeAsNodeRareData): Removed one pointer.
+* dom/NodeRareData.h:
+(NodeRareData): Removed the virtual destructor.
+(NodeRareData::reportMemoryUsage): Made non-virtual.
+
 2013-01-15  Ian Vollick  voll...@chromium.org
 
 [chromium] Create GraphicsLayerChromiums using a factory


Modified: trunk/Source/WebCore/dom/ElementRareData.cpp (139832 => 139833)

--- trunk/Source/WebCore/dom/ElementRareData.cpp	2013-01-16 05:10:13 UTC (rev 139832)
+++ trunk/Source/WebCore/dom/ElementRareData.cpp	2013-01-16 05:23:04 UTC (rev 139833)
@@ -36,6 +36,16 @@
 
 namespace WebCore {
 
+struct SameSizeAsElementRareData : NodeRareData {
+short indices[2];
+unsigned bitfields;
+LayoutSize sizeForResizing;
+IntSize scrollOffset;
+void* pointers[7];
+};
+
+COMPILE_ASSERT(sizeof(ElementRareData) == sizeof(SameSizeAsElementRareData), ElementRareDataShouldStaySmall);
+
 void ElementRareData::reportMemoryUsage(MemoryObjectInfo* memoryObjectInfo) const
 {
 MemoryClassInfo info(memoryObjectInfo, this, WebCoreMemoryTypes::DOM);


Modified: trunk/Source/WebCore/dom/ElementRareData.h (139832 => 139833)

--- trunk/Source/WebCore/dom/ElementRareData.h	2013-01-16 05:10:13 UTC (rev 139832)
+++ trunk/Source/WebCore/dom/ElementRareData.h	2013-01-16 05:23:04 UTC (rev 139833)
@@ -36,7 +36,7 @@
 class ElementRareData : public NodeRareData {
 public:
 ElementRareData();
-virtual ~ElementRareData();
+~ElementRareData();
 
 void setPseudoElement(PseudoId, PassRefPtrPseudoElement);
 PseudoElement* pseudoElement(PseudoId) const;
@@ -94,7 +94,8 @@
 unsigned childIndex() const { return m_childIndex; }
 void setChildIndex(unsigned index) { m_childIndex = index; }
 
-virtual void reportMemoryUsage(MemoryObjectInfo*) const OVERRIDE;
+// Manually called by Node::reportMemoryUsage.
+void reportMemoryUsage(MemoryObjectInfo*) const;
 
 ElementShadow* shadow() const { return m_shadow.get(); }
 void setShadow(PassOwnPtrElementShadow shadow) { m_shadow = shadow; }
@@ -160,6 +161,7 @@
 #endif
 
 LayoutSize m_minimumSizeForResizing;
+IntSize m_savedLayerScrollOffset;
 RefPtrRenderStyle m_computedStyle;
 
 OwnPtrDatasetDOMStringMap m_dataset;
@@ -170,9 +172,6 @@
 RefPtrPseudoElement m_generatedBefore;
 RefPtrPseudoElement m_generatedAfter;
 
-IntSize m_savedLayerScrollOffset;
-
-private:
 void releasePseudoElement(PseudoElement*);
 };
 


Modified: trunk/Source/WebCore/dom/Node.cpp (139832 => 139833)

--- 

[webkit-changes] [139834] trunk/LayoutTests

[dominicc]

Title: [139834] trunk/LayoutTests








Revision 139834
Author domin...@chromium.org
Date 2013-01-15 21:25:37 -0800 (Tue, 15 Jan 2013)


Log Message
[Chromium] Unreviewed gardening.

Rebaseline this test on Win after r139798:

http/tests/misc/object-embedding-svg-delayed-size-negotiation-2.htm

* platform/chromium-win/http/tests/misc/object-embedding-svg-delayed-size-negotiation-2-expected.png:
* platform/chromium-win/http/tests/misc/object-embedding-svg-delayed-size-negotiation-2-expected.txt:
* platform/chromium/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/TestExpectations
trunk/LayoutTests/platform/chromium-win/http/tests/misc/object-embedding-svg-delayed-size-negotiation-2-expected.png
trunk/LayoutTests/platform/chromium-win/http/tests/misc/object-embedding-svg-delayed-size-negotiation-2-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (139833 => 139834)

--- trunk/LayoutTests/ChangeLog	2013-01-16 05:23:04 UTC (rev 139833)
+++ trunk/LayoutTests/ChangeLog	2013-01-16 05:25:37 UTC (rev 139834)
@@ -1,3 +1,15 @@
+2013-01-15  Dominic Cooney  domin...@chromium.org
+
+[Chromium] Unreviewed gardening.
+
+Rebaseline this test on Win after r139798:
+
+http/tests/misc/object-embedding-svg-delayed-size-negotiation-2.htm
+
+* platform/chromium-win/http/tests/misc/object-embedding-svg-delayed-size-negotiation-2-expected.png:
+* platform/chromium-win/http/tests/misc/object-embedding-svg-delayed-size-negotiation-2-expected.txt:
+* platform/chromium/TestExpectations:
+
 2013-01-15  Dominic Cooney   domin...@chromium.org
 
 [Chromium] Unreviewed gardening.


Modified: trunk/LayoutTests/platform/chromium/TestExpectations (139833 => 139834)

--- trunk/LayoutTests/platform/chromium/TestExpectations	2013-01-16 05:23:04 UTC (rev 139833)
+++ trunk/LayoutTests/platform/chromium/TestExpectations	2013-01-16 05:25:37 UTC (rev 139834)
@@ -4380,3 +4380,4 @@
 webkit.org/b/106833 fast/borders/outline-alpha-inline.html [ Pass ImageOnlyFailure ]
 webkit.org/b/106858 [ SnowLeopard Debug ] scrollingcoordinator/non-fast-scrollable-region-transformed-iframe.html [ ImageOnlyFailure ]
 webkit.org/b/106858 [ Mac Debug ] scrollingcoordinator/non-fast-scrollable-region-scaled-iframe.html [ ImageOnlyFailure ]
+


Modified: trunk/LayoutTests/platform/chromium-win/http/tests/misc/object-embedding-svg-delayed-size-negotiation-2-expected.png

(Binary files differ)


Modified: trunk/LayoutTests/platform/chromium-win/http/tests/misc/object-embedding-svg-delayed-size-negotiation-2-expected.txt (139833 => 139834)

--- trunk/LayoutTests/platform/chromium-win/http/tests/misc/object-embedding-svg-delayed-size-negotiation-2-expected.txt	2013-01-16 05:23:04 UTC (rev 139833)
+++ trunk/LayoutTests/platform/chromium-win/http/tests/misc/object-embedding-svg-delayed-size-negotiation-2-expected.txt	2013-01-16 05:25:37 UTC (rev 139834)
@@ -1,62 +1,62 @@
 layer at (0,0) size 800x600
   RenderView at (0,0) size 800x600
-layer at (0,0) size 800x436
-  RenderBlock {HTML} at (0,0) size 800x436
-RenderBody {BODY} at (4,4) size 137x424 [border: (1px dashed #C0C0C0)]
+layer at (0,0) size 800x462
+  RenderBlock {HTML} at (0,0) size 800x462
+RenderBody {BODY} at (4,4) size 137x450 [border: (1px dashed #C0C0C0)]
   RenderBlock {P} at (1,10) size 135x27
 RenderText {#text} at (0,-2) size 133x30
   text run at (0,-2) width 130: The following six blue boxes must
   text run at (0,7) width 133: be of the same width. There must be
   text run at (0,16) width 26: no red.
-  RenderBlock {P} at (10,46) size 117x17 [bgcolor=#008000] [border: (4px solid #FF)]
-RenderText {#text} at (4,2) size 2x12
-  text run at (4,2) width 2:  
-  RenderBlock {P} at (1,117) size 135x9
+  RenderBlock {P} at (10,46) size 117x27 [bgcolor=#008000] [border: (9px solid #FF)]
+RenderText {#text} at (9,7) size 2x12
+  text run at (9,7) width 2:  
+  RenderBlock {P} at (1,127) size 135x9
 RenderText {#text} at (0,-2) size 12x12
   text run at (0,-2) width 12:   
 RenderText {#text} at (0,0) size 0x0
-RenderEmbeddedObject {OBJECT} at (9,0) size 117x35 [bgcolor=#FF] [border: (4px solid #FF)]
-  layer at (0,0) size 109x27
-RenderView at (0,0) size 109x27
-  layer at (0,0) size 109x27
-RenderSVGRoot {svg} at (0,0) size 109x27
-  RenderSVGRect {rect} at (0,0) size 109x27 [stroke={[type=SOLID] [color=#008000] [stroke width=12.00]}] [fill={[type=SOLID] [color=#00FF00]}] [x=0.00] [y=0.00] [width=1000.00] [height=250.00]
-  RenderSVGPath {path} at (16,5) size 76x17 [fill={[type=SOLID] [color=#008000]}] [data="" 500 50 L 150 200 L 850 200 Z]
-  RenderBlock {P} at (1,180) size 135x9
-RenderEmbeddedObject {OBJECT} at (9,0) size 117x35 [bgcolor=#FF] [border: (4px solid #FF)]
-