[webkit-changes] [149482] trunk/Source
Title: [149482] trunk/Source Revision 149482 Author lforsch...@apple.com Date 2013-05-01 20:45:30 -0700 (Wed, 01 May 2013) Log Message Versioning. Modified Paths trunk/Source/_javascript_Core/Configurations/Version.xcconfig trunk/Source/WebCore/Configurations/Version.xcconfig trunk/Source/WebKit/mac/Configurations/Version.xcconfig trunk/Source/WebKit2/Configurations/Version.xcconfig Diff Modified: trunk/Source/_javascript_Core/Configurations/Version.xcconfig (149481 => 149482) --- trunk/Source/_javascript_Core/Configurations/Version.xcconfig 2013-05-02 02:38:44 UTC (rev 149481) +++ trunk/Source/_javascript_Core/Configurations/Version.xcconfig 2013-05-02 03:45:30 UTC (rev 149482) @@ -22,7 +22,7 @@ // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. MAJOR_VERSION = 537; -MINOR_VERSION = 40; +MINOR_VERSION = 41; TINY_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION); Modified: trunk/Source/WebCore/Configurations/Version.xcconfig (149481 => 149482) --- trunk/Source/WebCore/Configurations/Version.xcconfig 2013-05-02 02:38:44 UTC (rev 149481) +++ trunk/Source/WebCore/Configurations/Version.xcconfig 2013-05-02 03:45:30 UTC (rev 149482) @@ -22,7 +22,7 @@ // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. MAJOR_VERSION = 537; -MINOR_VERSION = 40; +MINOR_VERSION = 41; TINY_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION); Modified: trunk/Source/WebKit/mac/Configurations/Version.xcconfig (149481 => 149482) --- trunk/Source/WebKit/mac/Configurations/Version.xcconfig 2013-05-02 02:38:44 UTC (rev 149481) +++ trunk/Source/WebKit/mac/Configurations/Version.xcconfig 2013-05-02 03:45:30 UTC (rev 149482) @@ -22,7 +22,7 @@ // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. MAJOR_VERSION = 537; -MINOR_VERSION = 40; +MINOR_VERSION = 41; TINY_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION); Modified: trunk/Source/WebKit2/Configurations/Version.xcconfig (149481 => 149482) --- trunk/Source/WebKit2/Configurations/Version.xcconfig 2013-05-02 02:38:44 UTC (rev 149481) +++ trunk/Source/WebKit2/Configurations/Version.xcconfig 2013-05-02 03:45:30 UTC (rev 149482) @@ -22,7 +22,7 @@ // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. MAJOR_VERSION = 537; -MINOR_VERSION = 40; +MINOR_VERSION = 41; TINY_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION); ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [149481] trunk/LayoutTests
Title: [149481] trunk/LayoutTests
Revision 149481
Author sle...@apple.com
Date 2013-05-01 19:38:44 -0700 (Wed, 01 May 2013)
Log Message
Update Lion results after http://trac.webkit.org/projects/webkit/changeset/149474
Unreviewed.
* platform/mac-lion/fast/text/text-combine-different-fonts-expected.txt: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
Added Paths
trunk/LayoutTests/platform/mac-lion/fast/text/text-combine-different-fonts-expected.txt
Diff
Modified: trunk/LayoutTests/ChangeLog (149480 => 149481)
--- trunk/LayoutTests/ChangeLog 2013-05-02 02:10:25 UTC (rev 149480)
+++ trunk/LayoutTests/ChangeLog 2013-05-02 02:38:44 UTC (rev 149481)
@@ -1,3 +1,11 @@
+2013-05-01 Stephanie Lewis
+
+Update Lion results after http://trac.webkit.org/projects/webkit/changeset/149474
+
+Unreviewed.
+
+* platform/mac-lion/fast/text/text-combine-different-fonts-expected.txt: Added.
+
2013-05-01 Enrica Casucci
text-combine: horizontal does not work properly for some fonts.
Added: trunk/LayoutTests/platform/mac-lion/fast/text/text-combine-different-fonts-expected.txt (0 => 149481)
--- trunk/LayoutTests/platform/mac-lion/fast/text/text-combine-different-fonts-expected.txt (rev 0)
+++ trunk/LayoutTests/platform/mac-lion/fast/text/text-combine-different-fonts-expected.txt 2013-05-02 02:38:44 UTC (rev 149481)
@@ -0,0 +1,23 @@
+layer at (0,0) size 800x600
+ RenderView at (0,0) size 800x600
+layer at (0,0) size 800x600
+ RenderBlock {HTML} at (0,0) size 800x600
+RenderBody {BODY} at (8,8) size 776x584
+ RenderBlock {P} at (0,0) size 18x584
+RenderText {#text} at (0,0) size 18x47
+ text run at (0,0) width 47: "Times: "
+RenderInline {SPAN} at (0,0) size 18x16
+ RenderCombineText {#text} at (0,47) size 18x16
+text run at (0,47) width 16: "\x{FFFC}"
+ RenderBlock {P} at (34,0) size 24x584
+RenderText {#text} at (3,0) size 17x171
+ text run at (3,0) width 171: "Hiragino Mincho Pro: "
+RenderInline {SPAN} at (0,0) size 17x17
+ RenderCombineText {#text} at (3,170) size 17x17
+text run at (3,170) width 16: "\x{FFFC}"
+ RenderBlock {P} at (74,0) size 16x584
+RenderText {#text} at (0,0) size 16x117
+ text run at (0,0) width 117: "STHeitiSC-Light: "
+RenderInline {SPAN} at (0,0) size 16x16
+ RenderCombineText {#text} at (0,117) size 16x16
+text run at (0,117) width 16: "\x{FFFC}"
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [149480] trunk/Tools
Title: [149480] trunk/Tools
Revision 149480
Author gl...@skynav.com
Date 2013-05-01 19:10:25 -0700 (Wed, 01 May 2013)
Log Message
[webkitpy] Need abstract base class for commands that analyze commit logs
https://bugs.webkit.org/show_bug.cgi?id=115391
Reviewed by Benjamin Poulain.
Move commit log parsing functions into new abstract base class AbstractCommitLogCommand
in preparation for adding two new commands that will reuse this functionality along with
suggest-nominations. See https://bugs.webkit.org/show_bug.cgi?id=115387 and
https://bugs.webkit.org/show_bug.cgi?id=115388.
No new tests as this patch does not change existing functionality or behavior.
* Scripts/webkitpy/tool/commands/suggestnominations.py:
(AbstractCommitLogCommand): Add abstract base class for commands that analyze commit logs.
(AbstractCommitLogCommand.__init__):
(AbstractCommitLogCommand._init_options):
(AbstractCommitLogCommand._parse_commit_message):
(SuggestNominations): Move generic commit log parsing into new base class. Use new base class.
(SuggestNominations.__init__):
(SuggestNominations._init_options):
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/tool/commands/suggestnominations.py
Diff
Modified: trunk/Tools/ChangeLog (149479 => 149480)
--- trunk/Tools/ChangeLog 2013-05-02 02:01:43 UTC (rev 149479)
+++ trunk/Tools/ChangeLog 2013-05-02 02:10:25 UTC (rev 149480)
@@ -1,3 +1,26 @@
+2013-05-01 Glenn Adams
+
+[webkitpy] Need abstract base class for commands that analyze commit logs
+https://bugs.webkit.org/show_bug.cgi?id=115391
+
+Reviewed by Benjamin Poulain.
+
+Move commit log parsing functions into new abstract base class AbstractCommitLogCommand
+in preparation for adding two new commands that will reuse this functionality along with
+suggest-nominations. See https://bugs.webkit.org/show_bug.cgi?id=115387 and
+https://bugs.webkit.org/show_bug.cgi?id=115388.
+
+No new tests as this patch does not change existing functionality or behavior.
+
+* Scripts/webkitpy/tool/commands/suggestnominations.py:
+(AbstractCommitLogCommand): Add abstract base class for commands that analyze commit logs.
+(AbstractCommitLogCommand.__init__):
+(AbstractCommitLogCommand._init_options):
+(AbstractCommitLogCommand._parse_commit_message):
+(SuggestNominations): Move generic commit log parsing into new base class. Use new base class.
+(SuggestNominations.__init__):
+(SuggestNominations._init_options):
+
2013-05-01 Seokju Kwon
Web Inspector: Fix check-inspector-strings script and fix localized strings
Modified: trunk/Tools/Scripts/webkitpy/tool/commands/suggestnominations.py (149479 => 149480)
--- trunk/Tools/Scripts/webkitpy/tool/commands/suggestnominations.py 2013-05-02 02:01:43 UTC (rev 149479)
+++ trunk/Tools/Scripts/webkitpy/tool/commands/suggestnominations.py 2013-05-02 02:10:25 UTC (rev 149480)
@@ -46,10 +46,7 @@
CommitLogError.__init__(self)
-class SuggestNominations(Command):
-name = "suggest-nominations"
-help_text = "Suggest contributors for committer/reviewer nominations"
-
+class AbstractCommitLogCommand(Command):
_leading_indent_regexp = re.compile(r"^[ ]{4}", re.MULTILINE)
_reviewed_by_regexp = re.compile(ChangeLogEntry.reviewed_by_regexp, re.MULTILINE)
_patch_by_regexp = re.compile(r'^Patch by (?P.+?)\s+<(?P[^<>]+)> on (?P\d{4}-\d{2}-\d{2})$', re.MULTILINE)
@@ -57,23 +54,19 @@
_date_regexp = re.compile(r'^Date: (?P\d{4}-\d{2}-\d{2}) (?P\d{2}:\d{2}:\d{2}) [\+\-]\d{4}$', re.MULTILINE)
_revision_regexp = re.compile(r'^git-svn-id: http://svn.webkit.org/repository/webkit/trunk@(?P\d+) (?P[0-9a-f\-]{36})$', re.MULTILINE)
-def __init__(self):
-options = [
-make_option("--committer-minimum", action="" dest="committer_minimum", type="int", default=10, help="Specify minimum patch count for Committer nominations."),
-make_option("--reviewer-minimum", action="" dest="reviewer_minimum", type="int", default=80, help="Specify minimum patch count for Reviewer nominations."),
-make_option("--max-commit-age", action="" dest="max_commit_age", type="int", default=9, help="Specify max commit age to consider for nominations (in months)."),
-make_option("--show-commits", action="" dest="show_commits", default=False, help="Show commit history with nomination suggestions."),
+def __init__(self, options=None):
+options = options or []
+options += [
+make_option("--max-commit-age", action="" dest="max_commit_age", type="int", default=9, help="Specify maximum commit age to consider (in months)."),
]
-super(SuggestNominations, self).__init__(options=options)
+options = sorted(options, cmp=lambda a, b: cmp(a._long_opts, b._long_opts))
+super(AbstractCommitLogCommand, self).__init__(options=options)
[webkit-changes] [149479] tags/Safari-537.39.4/Source
Title: [149479] tags/Safari-537.39.4/Source Revision 149479 Author lforsch...@apple.com Date 2013-05-01 19:01:43 -0700 (Wed, 01 May 2013) Log Message Merge fix for Modified Paths tags/Safari-537.39.4/Source/_javascript_Core/ChangeLog tags/Safari-537.39.4/Source/_javascript_Core/_javascript_Core.vcxproj/_javascript_Core.make tags/Safari-537.39.4/Source/_javascript_Core/_javascript_Core.vcxproj/_javascript_CoreExportGenerator/_javascript_CoreExportGeneratorPostBuild.cmd tags/Safari-537.39.4/Source/WTF/ChangeLog tags/Safari-537.39.4/Source/WTF/WTF.vcxproj/WTF.make Diff Modified: tags/Safari-537.39.4/Source/_javascript_Core/ChangeLog (149478 => 149479) --- tags/Safari-537.39.4/Source/_javascript_Core/ChangeLog 2013-05-02 02:01:06 UTC (rev 149478) +++ tags/Safari-537.39.4/Source/_javascript_Core/ChangeLog 2013-05-02 02:01:43 UTC (rev 149479) @@ -1,3 +1,11 @@ +2013-05-01 Roger Fong + +Set Path in makefile for AppleWin. + +* _javascript_Core.vcxproj/_javascript_Core.make: +* _javascript_Core.vcxproj/_javascript_CoreExportGenerator/_javascript_CoreExportGeneratorPostBuild.cmd: +Now that path is set, some copy commands are unnecessary. + 2013-04-25 Julien Brianceau REGRESSION(r137994): Random crashes occur with SH4 JSC. Modified: tags/Safari-537.39.4/Source/_javascript_Core/_javascript_Core.vcxproj/_javascript_Core.make (149478 => 149479) --- tags/Safari-537.39.4/Source/_javascript_Core/_javascript_Core.vcxproj/_javascript_Core.make 2013-05-02 02:01:06 UTC (rev 149478) +++ tags/Safari-537.39.4/Source/_javascript_Core/_javascript_Core.vcxproj/_javascript_Core.make 2013-05-02 02:01:43 UTC (rev 149479) @@ -8,6 +8,7 @@ set OFFICIAL_BUILD=1 set WebKit_Libraries=$(SRCROOT)\AppleInternal set WebKit_OutputDir=$(OBJROOT) +set Path=%PATH%;$(SRCROOT)\Program Files (x86)\Common Files\Apple\Apple Application Support set ConfigurationBuildDir=$(OBJROOT)\$(BUILDSTYLE) -mkdir "%ConfigurationBuildDir%\include\private" xcopy "%WebKit_Libraries%\include\private\*" "%ConfigurationBuildDir%\include\private" /e/v/i/h/y Modified: tags/Safari-537.39.4/Source/_javascript_Core/_javascript_Core.vcxproj/_javascript_CoreExportGenerator/_javascript_CoreExportGeneratorPostBuild.cmd (149478 => 149479) --- tags/Safari-537.39.4/Source/_javascript_Core/_javascript_Core.vcxproj/_javascript_CoreExportGenerator/_javascript_CoreExportGeneratorPostBuild.cmd 2013-05-02 02:01:06 UTC (rev 149478) +++ tags/Safari-537.39.4/Source/_javascript_Core/_javascript_Core.vcxproj/_javascript_CoreExportGenerator/_javascript_CoreExportGeneratorPostBuild.cmd 2013-05-02 02:01:43 UTC (rev 149479) @@ -2,8 +2,6 @@ mkdir 2>NUL "%CONFIGURATIONBUILDDIR%\bin" if exist "%WebKit_Libraries%\bin32\pthreadVC2.dll" xcopy /y /d "%WebKit_Libraries%\bin32\pthreadVC2.dll" "%CONFIGURATIONBUILDDIR%\bin" -if exist "%WebKit_Libraries%\bin32\libicuuc.dll" xcopy /y /d "%WebKit_Libraries%\bin32\libicuuc.dll" "%CONFIGURATIONBUILDDIR%\bin" -if exist "%WebKit_Libraries%\bin32\icudt46.dll" xcopy /y /d "%WebKit_Libraries%\bin32\icudt46.dll" "%CONFIGURATIONBUILDDIR%\bin" echo Exporting link definition output (%GeneratorDirectory%\_javascript_CoreExports.def) if exist "%OUTDIR%\_javascript_CoreExportGenerator%DEBUGSUFFIX%.exe" "%OUTDIR%\_javascript_CoreExportGenerator%DEBUGSUFFIX%.exe" > "%GeneratorDirectory%\_javascript_CoreExports.def" Modified: tags/Safari-537.39.4/Source/WTF/ChangeLog (149478 => 149479) --- tags/Safari-537.39.4/Source/WTF/ChangeLog 2013-05-02 02:01:06 UTC (rev 149478) +++ tags/Safari-537.39.4/Source/WTF/ChangeLog 2013-05-02 02:01:43 UTC (rev 149479) @@ -1,3 +1,9 @@ +2013-05-01 Roger Fong + +Set Path in makefile for AppleWin. + +* WTF.vcxproj/WTF.make: + 2013-04-25 pe...@outlook.com [Windows] Compile fix. Modified: tags/Safari-537.39.4/Source/WTF/WTF.vcxproj/WTF.make (149478 => 149479) --- tags/Safari-537.39.4/Source/WTF/WTF.vcxproj/WTF.make 2013-05-02 02:01:06 UTC (rev 149478) +++ tags/Safari-537.39.4/Source/WTF/WTF.vcxproj/WTF.make 2013-05-02 02:01:43 UTC (rev 149479) @@ -8,6 +8,7 @@ set OFFICIAL_BUILD=1 set WebKit_Libraries=$(SRCROOT)\AppleInternal set WebKit_OutputDir=$(OBJROOT) +set Path=%PATH%;$(SRCROOT)\Program Files (x86)\Common Files\Apple\Apple Application Support set ConfigurationBuildDir=$(OBJROOT)\$(BUILDSTYLE) devenv "WTF.submit.sln" /clean $(BUILDSTYLE) devenv "WTF.submit.sln" /build $(BUILDSTYLE) ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [149478] tags/Safari-537.39.4/Source
Title: [149478] tags/Safari-537.39.4/Source Revision 149478 Author lforsch...@apple.com Date 2013-05-01 19:01:06 -0700 (Wed, 01 May 2013) Log Message Versioning. Modified Paths tags/Safari-537.39.4/Source/_javascript_Core/Configurations/Version.xcconfig tags/Safari-537.39.4/Source/WebCore/Configurations/Version.xcconfig tags/Safari-537.39.4/Source/WebKit/mac/Configurations/Version.xcconfig tags/Safari-537.39.4/Source/WebKit2/Configurations/Version.xcconfig Diff Modified: tags/Safari-537.39.4/Source/_javascript_Core/Configurations/Version.xcconfig (149477 => 149478) --- tags/Safari-537.39.4/Source/_javascript_Core/Configurations/Version.xcconfig 2013-05-02 01:59:19 UTC (rev 149477) +++ tags/Safari-537.39.4/Source/_javascript_Core/Configurations/Version.xcconfig 2013-05-02 02:01:06 UTC (rev 149478) @@ -23,7 +23,7 @@ MAJOR_VERSION = 537; MINOR_VERSION = 39; -TINY_VERSION = 3; +TINY_VERSION = 4; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: tags/Safari-537.39.4/Source/WebCore/Configurations/Version.xcconfig (149477 => 149478) --- tags/Safari-537.39.4/Source/WebCore/Configurations/Version.xcconfig 2013-05-02 01:59:19 UTC (rev 149477) +++ tags/Safari-537.39.4/Source/WebCore/Configurations/Version.xcconfig 2013-05-02 02:01:06 UTC (rev 149478) @@ -23,7 +23,7 @@ MAJOR_VERSION = 537; MINOR_VERSION = 39; -TINY_VERSION = 3; +TINY_VERSION = 4; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: tags/Safari-537.39.4/Source/WebKit/mac/Configurations/Version.xcconfig (149477 => 149478) --- tags/Safari-537.39.4/Source/WebKit/mac/Configurations/Version.xcconfig 2013-05-02 01:59:19 UTC (rev 149477) +++ tags/Safari-537.39.4/Source/WebKit/mac/Configurations/Version.xcconfig 2013-05-02 02:01:06 UTC (rev 149478) @@ -23,7 +23,7 @@ MAJOR_VERSION = 537; MINOR_VERSION = 39; -TINY_VERSION = 3; +TINY_VERSION = 4; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: tags/Safari-537.39.4/Source/WebKit2/Configurations/Version.xcconfig (149477 => 149478) --- tags/Safari-537.39.4/Source/WebKit2/Configurations/Version.xcconfig 2013-05-02 01:59:19 UTC (rev 149477) +++ tags/Safari-537.39.4/Source/WebKit2/Configurations/Version.xcconfig 2013-05-02 02:01:06 UTC (rev 149478) @@ -23,7 +23,7 @@ MAJOR_VERSION = 537; MINOR_VERSION = 39; -TINY_VERSION = 3; +TINY_VERSION = 4; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [149477] tags/Safari-537.39.4/
Title: [149477] tags/Safari-537.39.4/ Revision 149477 Author lforsch...@apple.com Date 2013-05-01 18:59:19 -0700 (Wed, 01 May 2013) Log Message New Tag. Added Paths tags/Safari-537.39.4/ Diff Property changes: tags/Safari-537.39.4 Added: svn:ignore depcomp compile config.guess GNUmakefile.in config.sub ltmain.sh aconfig.h.in autom4te.cache missing aclocal.m4 install-sh autotoolsconfig.h.in INSTALL README gtk-doc.make out Makefile.chromium WebKitSupportLibrary.zip WebKitBuild Added: svn:mergeinfo ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [149476] trunk/Source
Title: [149476] trunk/Source Revision 149476 Author rn...@webkit.org Date 2013-05-01 18:54:27 -0700 (Wed, 01 May 2013) Log Message [Mac] WebKit doesn't enable or disable autocorrections when system preferences are changed https://bugs.webkit.org/show_bug.cgi?id=115463 Reviewed by Darin Adler. Source/WebKit/mac: Observe the default notification center for changes to autocorrection preferences. Note system preferences may also update WebAutomatic* defaults. * WebView/WebView.mm: (+[WebView initialize]): (+[WebView _shouldAutomaticTextReplacementBeEnabled]): (+[WebView _didChangeAutomaticTextReplacementEnabled:]): (+[WebView _shouldAutomaticSpellingCorrectionBeEnabled]): (+[WebView _didChangeAutomaticSpellingCorrectionEnabled:]): (+[WebView _shouldAutomaticQuoteSubstitutionBeEnabled]): (+[WebView _shouldAutomaticDashSubstitutionBeEnabled]): (+[WebView _didChangeAutomaticQuoteSubstitutionEnabled:]): (+[WebView _didChangeAutomaticDashSubstitutionEnabled:]): Source/WebKit2: Observe the default notification center and propagate the changes to TextCheckerState and to all WebProcesses when system preferences are updated. * UIProcess/TextChecker.h: * UIProcess/WebContext.h: * UIProcess/mac/TextCheckerMac.mm: (WebKit::shouldAutomaticTextReplacementBeEnabled): (WebKit::shouldAutomaticSpellingCorrectionBeEnabled): (WebKit::shouldAutomaticQuoteSubstitutionBeEnabled): (WebKit::shouldAutomaticDashSubstitutionBeEnabled): (WebKit::initializeState): (WebKit::TextChecker::didChangeAutomaticTextReplacementEnabled): (WebKit::TextChecker::didChangeAutomaticSpellingCorrectionEnabled): (WebKit::TextChecker::didChangeAutomaticQuoteSubstitutionEnabled): (WebKit::TextChecker::didChangeAutomaticDashSubstitutionEnabled): * UIProcess/mac/WebContextMac.mm: (WebKit::WebContext::registerNotificationObservers): (WebKit::WebContext::unregisterNotificationObservers): Modified Paths trunk/Source/WebKit/mac/ChangeLog trunk/Source/WebKit/mac/WebView/WebView.mm trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/UIProcess/TextChecker.h trunk/Source/WebKit2/UIProcess/WebContext.h trunk/Source/WebKit2/UIProcess/mac/TextCheckerMac.mm trunk/Source/WebKit2/UIProcess/mac/WebContextMac.mm Diff Modified: trunk/Source/WebKit/mac/ChangeLog (149475 => 149476) --- trunk/Source/WebKit/mac/ChangeLog 2013-05-02 01:53:45 UTC (rev 149475) +++ trunk/Source/WebKit/mac/ChangeLog 2013-05-02 01:54:27 UTC (rev 149476) @@ -1,3 +1,24 @@ +2011-05-01 Ryosuke Niwa + +[Mac] WebKit doesn't enable or disable autocorrections when system preferences are changed +https://bugs.webkit.org/show_bug.cgi?id=115463 + +Reviewed by Darin Adler. + +Observe the default notification center for changes to autocorrection preferences. +Note system preferences may also update WebAutomatic* defaults. + +* WebView/WebView.mm: +(+[WebView initialize]): +(+[WebView _shouldAutomaticTextReplacementBeEnabled]): +(+[WebView _didChangeAutomaticTextReplacementEnabled:]): +(+[WebView _shouldAutomaticSpellingCorrectionBeEnabled]): +(+[WebView _didChangeAutomaticSpellingCorrectionEnabled:]): +(+[WebView _shouldAutomaticQuoteSubstitutionBeEnabled]): +(+[WebView _shouldAutomaticDashSubstitutionBeEnabled]): +(+[WebView _didChangeAutomaticQuoteSubstitutionEnabled:]): +(+[WebView _didChangeAutomaticDashSubstitutionEnabled:]): + 2013-05-01 Benjamin Poulain Fix the function names of r149453 Modified: trunk/Source/WebKit/mac/WebView/WebView.mm (149475 => 149476) --- trunk/Source/WebKit/mac/WebView/WebView.mm 2013-05-02 01:53:45 UTC (rev 149475) +++ trunk/Source/WebKit/mac/WebView/WebView.mm 2013-05-02 01:54:27 UTC (rev 149476) @@ -3136,7 +3136,7 @@ [[NSNotificationCenter defaultCenter] addObserver:self selector:@selector(_applicationWillTerminate) name:NSApplicationWillTerminateNotification object:NSApp]; [[NSNotificationCenter defaultCenter] addObserver:self selector:@selector(_cacheModelChangedNotification:) name:WebPreferencesCacheModelChangedInternalNotification object:nil]; -[[NSNotificationCenter defaultCenter] addObserver:self selector:@selector(_preferencesRemovedNotification:) name:WebPreferencesRemovedNotification object:nil]; +[[NSNotificationCenter defaultCenter] addObserver:self selector:@selector(_preferencesRemovedNotification:) name:WebPreferencesRemovedNotification object:nil]; NSUserDefaults *defaults = [NSUserDefaults standardUserDefaults]; @@ -3149,20 +3149,87 @@ Font::setDefaultTypesettingFeatures([defaults boolForKey:WebKitKerningAndLigaturesEnabledByDefaultDefaultsKey] ? Kerning | Ligatures : 0); -automaticQuoteSubstitutionEnabled = [defaults boolForKey:WebAutomaticQuoteSubstitutionEnabled]; +automaticQuoteSubstitutionEnabled = [self _shouldAutomaticQuoteSubstitutionBeEnabled]; automaticLinkDetectionEnabled = [defaults boolForKey:WebAutomaticLinkDetectionEnabled]; -auto
[webkit-changes] [149475] tags/Safari-537.40/
Title: [149475] tags/Safari-537.40/ Revision 149475 Author lforsch...@apple.com Date 2013-05-01 18:53:45 -0700 (Wed, 01 May 2013) Log Message New Tag. Added Paths tags/Safari-537.40/ Diff Property changes: tags/Safari-537.40 Added: svn:ignore depcomp compile config.guess GNUmakefile.in config.sub ltmain.sh aconfig.h.in autom4te.cache missing aclocal.m4 install-sh autotoolsconfig.h.in INSTALL README gtk-doc.make out Makefile.chromium WebKitSupportLibrary.zip WebKitBuild Added: svn:mergeinfo ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [149474] trunk
Title: [149474] trunk
Revision 149474
Author enr...@apple.com
Date 2013-05-01 18:48:55 -0700 (Wed, 01 May 2013)
Log Message
text-combine: horizontal does not work properly for some fonts.
https://bugs.webkit.org/show_bug.cgi?id=115503.
Reviewed by Dave Hyatt.
Source/WebCore:
For some fonts that don't have width variants, we fail to combine glyphs
because we believe they don't fit. That decision is made comparing the run width
with the font computed size multiplied by a margin factor.
I've increased the margin from 10% to 15%.
Test: fast/text/text-combine-different-fonts.html
* rendering/RenderCombineText.cpp:
LayoutTests:
* fast/text/text-combine-different-fonts.html: Added.
* platform/mac/fast/text/text-combine-different-fonts-expected.png: Added.
* platform/mac/fast/text/text-combine-different-fonts-expected.txt: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderCombineText.cpp
Added Paths
trunk/LayoutTests/fast/text/text-combine-different-fonts.html
trunk/LayoutTests/platform/mac/fast/text/text-combine-different-fonts-expected.png
trunk/LayoutTests/platform/mac/fast/text/text-combine-different-fonts-expected.txt
Diff
Modified: trunk/LayoutTests/ChangeLog (149473 => 149474)
--- trunk/LayoutTests/ChangeLog 2013-05-02 01:30:26 UTC (rev 149473)
+++ trunk/LayoutTests/ChangeLog 2013-05-02 01:48:55 UTC (rev 149474)
@@ -1,3 +1,14 @@
+2013-05-01 Enrica Casucci
+
+text-combine: horizontal does not work properly for some fonts.
+https://bugs.webkit.org/show_bug.cgi?id=115503.
+
+Reviewed by Dave Hyatt.
+
+* fast/text/text-combine-different-fonts.html: Added.
+* platform/mac/fast/text/text-combine-different-fonts-expected.png: Added.
+* platform/mac/fast/text/text-combine-different-fonts-expected.txt: Added.
+
2013-05-01 Stephanie Lewis
Update Lion results after http://trac.webkit.org/projects/webkit/changeset/149450
Added: trunk/LayoutTests/fast/text/text-combine-different-fonts.html (0 => 149474)
--- trunk/LayoutTests/fast/text/text-combine-different-fonts.html (rev 0)
+++ trunk/LayoutTests/fast/text/text-combine-different-fonts.html 2013-05-02 01:48:55 UTC (rev 149474)
@@ -0,0 +1,19 @@
+
+
+ text-combine demo
+
+.combine {
+ -webkit-text-combine: horizontal;
+}
+
+body {
+ -webkit-writing-mode: vertical-rl;
+}
+
+
+
+ Times: 16
+ Hiragino Mincho Pro: 16
+ STHeitiSC-Light: 16
+
+
Added: trunk/LayoutTests/platform/mac/fast/text/text-combine-different-fonts-expected.png
(Binary files differ)
Property changes on: trunk/LayoutTests/platform/mac/fast/text/text-combine-different-fonts-expected.png
___
Added: svn:mime-type
Added: trunk/LayoutTests/platform/mac/fast/text/text-combine-different-fonts-expected.txt (0 => 149474)
--- trunk/LayoutTests/platform/mac/fast/text/text-combine-different-fonts-expected.txt (rev 0)
+++ trunk/LayoutTests/platform/mac/fast/text/text-combine-different-fonts-expected.txt 2013-05-02 01:48:55 UTC (rev 149474)
@@ -0,0 +1,23 @@
+layer at (0,0) size 800x600
+ RenderView at (0,0) size 800x600
+layer at (0,0) size 800x600
+ RenderBlock {HTML} at (0,0) size 800x600
+RenderBody {BODY} at (8,8) size 776x584
+ RenderBlock {P} at (0,0) size 18x584
+RenderText {#text} at (0,0) size 18x47
+ text run at (0,0) width 47: "Times: "
+RenderInline {SPAN} at (0,0) size 18x16
+ RenderCombineText {#text} at (0,47) size 18x16
+text run at (0,47) width 16: "\x{FFFC}"
+ RenderBlock {P} at (34,0) size 24x584
+RenderText {#text} at (3,0) size 17x170
+ text run at (3,0) width 170: "Hiragino Mincho Pro: "
+RenderInline {SPAN} at (0,0) size 17x17
+ RenderCombineText {#text} at (3,169) size 17x17
+text run at (3,169) width 16: "\x{FFFC}"
+ RenderBlock {P} at (74,0) size 16x584
+RenderText {#text} at (0,0) size 16x117
+ text run at (0,0) width 117: "STHeitiSC-Light: "
+RenderInline {SPAN} at (0,0) size 16x16
+ RenderCombineText {#text} at (0,117) size 16x16
+text run at (0,117) width 16: "\x{FFFC}"
Modified: trunk/Source/WebCore/ChangeLog (149473 => 149474)
--- trunk/Source/WebCore/ChangeLog 2013-05-02 01:30:26 UTC (rev 149473)
+++ trunk/Source/WebCore/ChangeLog 2013-05-02 01:48:55 UTC (rev 149474)
@@ -1,3 +1,19 @@
+2013-05-01 Enrica Casucci
+
+text-combine: horizontal does not work properly for some fonts.
+https://bugs.webkit.org/show_bug.cgi?id=115503.
+
+Reviewed by Dave Hyatt.
+
+For some fonts that don't have width variants, we fail to combine glyphs
+because we believe they don't fit. That decision is made comparing the run width
+with the font computed size multiplied by a margin factor.
+I've
[webkit-changes] [149472] trunk/Source/WTF
Title: [149472] trunk/Source/WTF Revision 149472 Author msab...@apple.com Date 2013-05-01 18:22:55 -0700 (Wed, 01 May 2013) Log Message FastMalloc.cpp should use system defined page size instead of literal constant https://bugs.webkit.org/show_bug.cgi?id=115502 Reviewed by Geoffrey Garen. Updated kPageShift to be PAGE_SHIFT for Mac. Changed kMaxSize to be fixed at 32K. Updated kNumClasses for 4K and 16K page sizes. * wtf/FastMalloc.cpp: kPageShift: Changed this to be PAGE_SHIFT on mac. Modified Paths trunk/Source/WTF/ChangeLog trunk/Source/WTF/wtf/FastMalloc.cpp Diff Modified: trunk/Source/WTF/ChangeLog (149471 => 149472) --- trunk/Source/WTF/ChangeLog 2013-05-02 01:09:18 UTC (rev 149471) +++ trunk/Source/WTF/ChangeLog 2013-05-02 01:22:55 UTC (rev 149472) @@ -1,3 +1,16 @@ +2013-05-01 Michael Saboff + +FastMalloc.cpp should use system defined page size instead of literal constant +https://bugs.webkit.org/show_bug.cgi?id=115502 + +Reviewed by Geoffrey Garen. + +Updated kPageShift to be PAGE_SHIFT for Mac. Changed kMaxSize to be fixed at 32K. +Updated kNumClasses for 4K and 16K page sizes. + +* wtf/FastMalloc.cpp: +kPageShift: Changed this to be PAGE_SHIFT on mac. + 2013-05-01 Roger Fong Set Path in makefile for AppleWin. Modified: trunk/Source/WTF/wtf/FastMalloc.cpp (149471 => 149472) --- trunk/Source/WTF/wtf/FastMalloc.cpp 2013-05-02 01:09:18 UTC (rev 149471) +++ trunk/Source/WTF/wtf/FastMalloc.cpp 2013-05-02 01:22:55 UTC (rev 149472) @@ -628,12 +628,25 @@ // Not all possible combinations of the following parameters make // sense. In particular, if kMaxSize increases, you may have to // increase kNumClasses as well. -static const size_t kPageShift = 12; +#if OS(DARWIN) +#define K_PAGE_SHIFT PAGE_SHIFT +#if (K_PAGE_SHIFT == 12) +#define K_NUM_CLASSES 68 +#elif (K_PAGE_SHIFT == 14) +#define K_NUM_CLASSES 77 +#else +#error "Unsupported PAGE_SHIFT amount" +#endif +#else +#define K_PAGE_SHIFT 12 +#define K_NUM_CLASSES 68 +#endif +static const size_t kPageShift = K_PAGE_SHIFT; static const size_t kPageSize = 1 << kPageShift; -static const size_t kMaxSize= 8u * kPageSize; +static const size_t kMaxSize= 32u * 1024; static const size_t kAlignShift = 3; static const size_t kAlignment = 1 << kAlignShift; -static const size_t kNumClasses = 68; +static const size_t kNumClasses = K_NUM_CLASSES; // Allocates a big block of memory for the pagemap once we reach more than // 128MB ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [149471] trunk/Source/WebKit/blackberry
Title: [149471] trunk/Source/WebKit/blackberry
Revision 149471
Author commit-qu...@webkit.org
Date 2013-05-01 18:09:18 -0700 (Wed, 01 May 2013)
Log Message
[BlackBerry] Upstream smart selection
https://bugs.webkit.org/show_bug.cgi?id=111226
Patch by Iris Wu on 2013-05-01
Reviewed by Rob Buis.
Calling userInterfaceViewportAccessor()->documentViewportRect() on WK thread
caused crash.
But viewport from webkitThreadViewportAccessor uses unadjusted size which is
wrong for email.
The solution here is to get actual viewport size on UI thread and then pass it
to WebKit::SelectionHandler.
PR 333763
Reviewed Internally By Jakob Petsovits.
* Api/InRegionScroller.cpp:
(BlackBerry::WebKit::InRegionScrollerPrivate::updateSelectionScrollView):
* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPage::setSelectionDocumentViewportSize):
(WebKit):
* Api/WebPage.h:
* WebKitSupport/SelectionHandler.cpp:
(BlackBerry::WebKit::SelectionHandler::selectAtPoint):
(BlackBerry::WebKit::SelectionHandler::ensureSelectedTextVisible):
(BlackBerry::WebKit::SelectionHandler::selectionViewportRect):
* WebKitSupport/SelectionHandler.h:
(BlackBerry::WebKit::SelectionHandler::setSelectionViewportSize):
(BlackBerry::WebKit::SelectionHandler::setSelectionSubframeViewportRect):
(SelectionHandler):
Modified Paths
trunk/Source/WebKit/blackberry/Api/InRegionScroller.cpp
trunk/Source/WebKit/blackberry/Api/WebPage.cpp
trunk/Source/WebKit/blackberry/Api/WebPage.h
trunk/Source/WebKit/blackberry/ChangeLog
trunk/Source/WebKit/blackberry/WebKitSupport/SelectionHandler.cpp
trunk/Source/WebKit/blackberry/WebKitSupport/SelectionHandler.h
Diff
Modified: trunk/Source/WebKit/blackberry/Api/InRegionScroller.cpp (149470 => 149471)
--- trunk/Source/WebKit/blackberry/Api/InRegionScroller.cpp 2013-05-02 01:07:03 UTC (rev 149470)
+++ trunk/Source/WebKit/blackberry/Api/InRegionScroller.cpp 2013-05-02 01:09:18 UTC (rev 149471)
@@ -306,8 +306,8 @@
// Deleting the scrollview is handled by the client.
Platform::ScrollViewBase* selectionScrollView = firstScrollableInRegionForNode(node);
m_webPage->m_client->notifySelectionScrollView(selectionScrollView);
-// if there's no subframe set an empty rect so that we default to the main frame.
-m_webPage->m_selectionHandler->setSelectionViewportRect(selectionScrollView ? WebCore::IntRect(selectionScrollView->documentViewportRect()) : WebCore::IntRect());
+// If there's no subframe set an empty rect so that we default to the main frame.
+m_webPage->m_selectionHandler->setSelectionSubframeViewportRect(selectionScrollView ? WebCore::IntRect(selectionScrollView->documentViewportRect()) : WebCore::IntRect());
}
Platform::ScrollViewBase* InRegionScrollerPrivate::firstScrollableInRegionForNode(const Node* node)
Modified: trunk/Source/WebKit/blackberry/Api/WebPage.cpp (149470 => 149471)
--- trunk/Source/WebKit/blackberry/Api/WebPage.cpp 2013-05-02 01:07:03 UTC (rev 149470)
+++ trunk/Source/WebKit/blackberry/Api/WebPage.cpp 2013-05-02 01:09:18 UTC (rev 149471)
@@ -4432,6 +4432,11 @@
d->m_selectionHandler->setParagraphExpansionScrollMargin(documentScrollMargin);
}
+void WebPage::setSelectionDocumentViewportSize(const Platform::IntSize& selectionDocumentViewportSize)
+{
+d->m_selectionHandler->setSelectionViewportSize(selectionDocumentViewportSize);
+}
+
BackingStore* WebPage::backingStore() const
{
return d->m_backingStore;
Modified: trunk/Source/WebKit/blackberry/Api/WebPage.h (149470 => 149471)
--- trunk/Source/WebKit/blackberry/Api/WebPage.h 2013-05-02 01:07:03 UTC (rev 149470)
+++ trunk/Source/WebKit/blackberry/Api/WebPage.h 2013-05-02 01:09:18 UTC (rev 149471)
@@ -264,6 +264,7 @@
void expandSelection(bool isScrollStarted);
void setOverlayExpansionPixelHeight(int);
void setParagraphExpansionPixelScrollMargin(const Platform::IntSize&);
+void setSelectionDocumentViewportSize(const Platform::IntSize&);
void selectionCancelled();
bool selectionContainsDocumentPoint(const Platform::IntPoint&);
Modified: trunk/Source/WebKit/blackberry/ChangeLog (149470 => 149471)
--- trunk/Source/WebKit/blackberry/ChangeLog 2013-05-02 01:07:03 UTC (rev 149470)
+++ trunk/Source/WebKit/blackberry/ChangeLog 2013-05-02 01:09:18 UTC (rev 149471)
@@ -1,3 +1,35 @@
+2013-05-01 Iris Wu
+
+ [BlackBerry] Upstream smart selection
+ https://bugs.webkit.org/show_bug.cgi?id=111226
+
+Reviewed by Rob Buis.
+
+Calling userInterfaceViewportAccessor()->documentViewportRect() on WK thread
+caused crash.
+But viewport from webkitThreadViewportAccessor uses unadjusted size which is
+wrong for email.
+The solution here is to get actual viewport size on UI thread and then pass it
+to WebKit::SelectionHandler.
+
+PR 333763
+Reviewed Internally By Jakob Petsovits.
+
+* Api/InRegionScroller.cpp:
+(BlackBerry::WebKit::InRegionScrollerPrivate::updateSelectionScrollView):
+
[webkit-changes] [149469] trunk/Source/WebCore
Title: [149469] trunk/Source/WebCore
Revision 149469
Author commit-qu...@webkit.org
Date 2013-05-01 17:40:22 -0700 (Wed, 01 May 2013)
Log Message
Null check plugInClient earlier in snapshotting path
https://bugs.webkit.org/show_bug.cgi?id=115498
Patch by Joseph Pecoraro on 2013-05-01
Reviewed by Darin Adler.
* html/HTMLPlugInImageElement.cpp:
(WebCore::HTMLPlugInImageElement::subframeLoaderWillCreatePlugIn):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/HTMLPlugInImageElement.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (149468 => 149469)
--- trunk/Source/WebCore/ChangeLog 2013-05-02 00:39:14 UTC (rev 149468)
+++ trunk/Source/WebCore/ChangeLog 2013-05-02 00:40:22 UTC (rev 149469)
@@ -1,3 +1,13 @@
+2013-05-01 Joseph Pecoraro
+
+Null check plugInClient earlier in snapshotting path
+https://bugs.webkit.org/show_bug.cgi?id=115498
+
+Reviewed by Darin Adler.
+
+* html/HTMLPlugInImageElement.cpp:
+(WebCore::HTMLPlugInImageElement::subframeLoaderWillCreatePlugIn):
+
2013-05-01 Seokju Kwon
Web Inspector: Fix check-inspector-strings script and fix localized strings
Modified: trunk/Source/WebCore/html/HTMLPlugInImageElement.cpp (149468 => 149469)
--- trunk/Source/WebCore/html/HTMLPlugInImageElement.cpp 2013-05-02 00:39:14 UTC (rev 149468)
+++ trunk/Source/WebCore/html/HTMLPlugInImageElement.cpp 2013-05-02 00:40:22 UTC (rev 149469)
@@ -645,7 +645,7 @@
return;
}
-if (document()->page()->settings()->autostartOriginPlugInSnapshottingEnabled() && document()->page()->plugInClient()->shouldAutoStartFromOrigin(document()->page()->mainFrame()->document()->baseURL().host(), url.host(), loadedMimeType())) {
+if (document()->page()->settings()->autostartOriginPlugInSnapshottingEnabled() && document()->page()->plugInClient() && document()->page()->plugInClient()->shouldAutoStartFromOrigin(document()->page()->mainFrame()->document()->baseURL().host(), url.host(), loadedMimeType())) {
LOG(Plugins, "%p Plug-in from (%s, %s) is marked to auto-start, set to play", this, document()->page()->mainFrame()->document()->baseURL().host().utf8().data(), url.host().utf8().data());
m_snapshotDecision = NeverSnapshot;
return;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [149468] trunk
Title: [149468] trunk Revision 149468 Author commit-qu...@webkit.org Date 2013-05-01 17:39:14 -0700 (Wed, 01 May 2013) Log Message Web Inspector: Fix check-inspector-strings script and fix localized strings https://bugs.webkit.org/show_bug.cgi?id=115495 Patch by Seokju Kwon on 2013-05-01 Reviewed by Joseph Pecoraro. Source/WebCore: No new tests, because there is no change in behavior. * English.lproj/localizedStrings.js: Tools: * Scripts/check-inspector-strings: Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/English.lproj/localizedStrings.js trunk/Tools/ChangeLog trunk/Tools/Scripts/check-inspector-strings Diff Modified: trunk/Source/WebCore/ChangeLog (149467 => 149468) --- trunk/Source/WebCore/ChangeLog 2013-05-02 00:38:37 UTC (rev 149467) +++ trunk/Source/WebCore/ChangeLog 2013-05-02 00:39:14 UTC (rev 149468) @@ -1,3 +1,14 @@ +2013-05-01 Seokju Kwon + +Web Inspector: Fix check-inspector-strings script and fix localized strings +https://bugs.webkit.org/show_bug.cgi?id=115495 + +Reviewed by Joseph Pecoraro. + +No new tests, because there is no change in behavior. + +* English.lproj/localizedStrings.js: + 2013-05-01 Tim Horton "> MIME types aren't case-insensitive Modified: trunk/Source/WebCore/English.lproj/localizedStrings.js (149467 => 149468) --- trunk/Source/WebCore/English.lproj/localizedStrings.js 2013-05-02 00:38:37 UTC (rev 149467) +++ trunk/Source/WebCore/English.lproj/localizedStrings.js 2013-05-02 00:39:14 UTC (rev 149468) @@ -16,7 +16,6 @@ localizedStrings["%.2f\u2009s"] = "%.2f\u2009s"; localizedStrings["%.3f\u2009ms"] = "%.3f\u2009ms"; localizedStrings["%d characters selected"] = "%d characters selected"; -localizedStrings["%d console messages are not shown."] = "%d console messages are not shown."; localizedStrings["%d cookies (%s)"] = "%d cookies (%s)"; localizedStrings["%d descendant with forced state"] = "%d descendant with forced state"; localizedStrings["%d descendants with forced state"] = "%d descendants with forced state"; @@ -37,7 +36,6 @@ localizedStrings["%d \xd7 %d pixels"] = "%d \xd7 %d pixels"; localizedStrings["%d × %d"] = "%d × %d"; localizedStrings["× %d"] = "× %d"; -localizedStrings["%s (%s)"] = "%s (%s)"; localizedStrings["%s (at %s)"] = "%s (at %s)"; localizedStrings["%s (from cache)"] = "%s (from cache)"; localizedStrings["%s - Details"] = "%s - Details"; @@ -46,16 +44,13 @@ localizedStrings["%s latency"] = "%s latency"; localizedStrings["%s latency, %s download (%s total)"] = "%s latency, %s download (%s total)"; localizedStrings["(anonymous function)"] = "(anonymous function)"; -localizedStrings["(data url)"] = "(data url)"; localizedStrings["(from cache)"] = "(from cache)"; localizedStrings["(failed)"] = "(failed)"; localizedStrings["(canceled)"] = "(canceled)"; -localizedStrings["(internal script)"] = "(internal script)"; localizedStrings["(ping)"] = "(ping)"; localizedStrings["(program)"] = "(program)"; localizedStrings["(text)"] = "(text)"; localizedStrings["(unable to decode value)"] = "(unable to decode value)"; -localizedStrings["(whitespace)"] = "(whitespace)"; localizedStrings["Application Cache"] = "Application Cache"; localizedStrings["Accept suggestion"] = "Accept suggestion"; localizedStrings["Activate Breakpoints"] = "Activate Breakpoints"; @@ -122,7 +117,6 @@ localizedStrings["Clear"] = "Clear"; localizedStrings["Click to open a colorpicker. Shift-click to change color format"] = "Click to open a colorpicker. Shift-click to change color format"; localizedStrings["Closure"] = "Closure"; -localizedStrings["Code"] = "Code"; localizedStrings["Collected"] = "Collected"; localizedStrings["Collect CSS Selector Profile"] = "Collect CSS Selector Profile"; localizedStrings["Collect _javascript_ CPU Profile"] = "Collect _javascript_ CPU Profile"; @@ -138,7 +132,6 @@ localizedStrings["Copy All as HAR"] = "Copy All as HAR"; localizedStrings["Save as HAR with content"] = "Save as HAR with content"; localizedStrings["Save as HAR with Content"] = "Save as HAR with Content"; -localizedStrings["Specification for \"%s\""] = "Specification for \"%s\""; localizedStrings["Copy link address"] = "Copy link address"; localizedStrings["Copy Link Address"] = "Copy Link Address"; localizedStrings["Copy request headers"] = "Copy request headers"; @@ -297,7 +290,6 @@ localizedStrings["No audits to run"] = "No audits to run"; localizedStrings["Node Removed"] = "Node Removed"; localizedStrings["Nodes: %d"] = "Nodes: %d"; -localizedStrings["Not Found"] = "Not Found"; localizedStrings["Not Paused"] = "Not Paused"; localizedStrings["Objects Count"] = "Objects Count"; localizedStrings["Offline"] = "Offline"; @@ -494,10 +486,8 @@ localizedStrings["[empty domain]"] = "[empty domain]"; localizedStrings["border"] = "border"; localizedStrings["content"] = "content"; -localizedStrings["deleted"] = "deleted"; localizedStrings["empty"] = "empty";
[webkit-changes] [149467] trunk/Source/WebKit2
Title: [149467] trunk/Source/WebKit2 Revision 149467 Author mrobin...@webkit.org Date 2013-05-01 17:38:37 -0700 (Wed, 01 May 2013) Log Message [GTK] [WebKit2] Documentation for webkit_web_view_run_javascript should indicate what happens when _javascript_ is disabled https://bugs.webkit.org/show_bug.cgi?id=115492 Reviewed by Xan Lopez. * UIProcess/API/gtk/WebKitWebView.cpp: Clarify the documentation. Modified Paths trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp Diff Modified: trunk/Source/WebKit2/ChangeLog (149466 => 149467) --- trunk/Source/WebKit2/ChangeLog 2013-05-02 00:15:28 UTC (rev 149466) +++ trunk/Source/WebKit2/ChangeLog 2013-05-02 00:38:37 UTC (rev 149467) @@ -1,3 +1,12 @@ +2013-05-01 Martin Robinson + +[GTK] [WebKit2] Documentation for webkit_web_view_run_javascript should indicate what happens when _javascript_ is disabled +https://bugs.webkit.org/show_bug.cgi?id=115492 + +Reviewed by Xan Lopez. + +* UIProcess/API/gtk/WebKitWebView.cpp: Clarify the documentation. + 2013-05-01 Tim Horton Move knowledge of PDF/PostScript MIME types into MIMETypeRegistry Modified: trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp (149466 => 149467) --- trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp 2013-05-02 00:15:28 UTC (rev 149466) +++ trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp 2013-05-02 00:38:37 UTC (rev 149467) @@ -2523,7 +2523,8 @@ * @callback: (scope async): a #GAsyncReadyCallback to call when the script finished * @user_data: (closure): the data to pass to callback function * - * Asynchronously run @script in the context of the current page in @web_view. + * Asynchronously run @script in the context of the current page in @web_view. If + * WebKitWebSettings:enable-_javascript_ is FALSE, this method will do nothing. * * When the operation is finished, @callback will be called. You can then call * webkit_web_view_run_javascript_finish() to get the result of the operation. ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [149466] trunk
Title: [149466] trunk
Revision 149466
Author timothy_hor...@apple.com
Date 2013-05-01 17:15:28 -0700 (Wed, 01 May 2013)
Log Message
"> MIME types aren't case-insensitive
https://bugs.webkit.org/show_bug.cgi?id=115494
Reviewed by Darin Adler.
Test: fast/images/object-data-url-case-insensitivity.html
MIME types are defined to be case-insensitive, but many places in WebCore
only compare them against lower-case strings. Most entry points for MIME
types lower-case them, but mimeTypeFromDataURL doesn't, causing, for example,
data:image/png;... to work, but data:iMaGe/PNG;... to fail.
To fix this, lower-case the string returned from mimeTypeFromDataURL.
* platform/KURL.cpp:
(WebCore::mimeTypeFromDataURL):
Add a testcase that ensures that iMaGe/PNG == image/png when it comes to
the MIME type specified in a data URL provided to via its
'data' attribute.
* fast/images/object-data-url-case-insensitivity-expected.html: Added.
* fast/images/object-data-url-case-insensitivity.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/KURL.cpp
Added Paths
trunk/LayoutTests/fast/images/object-data-url-case-insensitivity-expected.html
trunk/LayoutTests/fast/images/object-data-url-case-insensitivity.html
Diff
Modified: trunk/LayoutTests/ChangeLog (149465 => 149466)
--- trunk/LayoutTests/ChangeLog 2013-05-02 00:02:29 UTC (rev 149465)
+++ trunk/LayoutTests/ChangeLog 2013-05-02 00:15:28 UTC (rev 149466)
@@ -1,3 +1,17 @@
+2013-05-01 Tim Horton
+
+"> MIME types aren't case-insensitive
+https://bugs.webkit.org/show_bug.cgi?id=115494
+
+Reviewed by Darin Adler.
+
+Add a testcase that ensures that iMaGe/PNG == image/png when it comes to
+the MIME type specified in a data URL provided to via its
+'data' attribute.
+
+* fast/images/object-data-url-case-insensitivity-expected.html: Added.
+* fast/images/object-data-url-case-insensitivity.html: Added.
+
2013-05-01 Hans Muller
[CSS Exclusions] Programmatic layout tests fail when subpixel layout is disabled
Added: trunk/LayoutTests/fast/images/object-data-url-case-insensitivity-expected.html (0 => 149466)
--- trunk/LayoutTests/fast/images/object-data-url-case-insensitivity-expected.html (rev 0)
+++ trunk/LayoutTests/fast/images/object-data-url-case-insensitivity-expected.html 2013-05-02 00:15:28 UTC (rev 149466)
@@ -0,0 +1,4 @@
+Should see two green squares if object-tag data="" MIME types are case-insensitive.
+
+\ No newline at end of file
Added: trunk/LayoutTests/fast/images/object-data-url-case-insensitivity.html (0 => 149466)
--- trunk/LayoutTests/fast/images/object-data-url-case-insensitivity.html (rev 0)
+++ trunk/LayoutTests/fast/images/object-data-url-case-insensitivity.html 2013-05-02 00:15:28 UTC (rev 149466)
@@ -0,0 +1,4 @@
+Should see two green squares if object-tag data="" MIME types are case-insensitive.
+
+\ No newline at end of file
Modified: trunk/Source/WebCore/ChangeLog (149465 => 149466)
--- trunk/Source/WebCore/ChangeLog 2013-05-02 00:02:29 UTC (rev 149465)
+++ trunk/Source/WebCore/ChangeLog 2013-05-02 00:15:28 UTC (rev 149466)
@@ -1,3 +1,22 @@
+2013-05-01 Tim Horton
+
+"> MIME types aren't case-insensitive
+https://bugs.webkit.org/show_bug.cgi?id=115494
+
+Reviewed by Darin Adler.
+
+Test: fast/images/object-data-url-case-insensitivity.html
+
+MIME types are defined to be case-insensitive, but many places in WebCore
+only compare them against lower-case strings. Most entry points for MIME
+types lower-case them, but mimeTypeFromDataURL doesn't, causing, for example,
+data:image/png;... to work, but data:iMaGe/PNG;... to fail.
+
+To fix this, lower-case the string returned from mimeTypeFromDataURL.
+
+* platform/KURL.cpp:
+(WebCore::mimeTypeFromDataURL):
+
2013-05-01 Ryosuke Niwa
[Mac] Text replacement should use correction indicator
Modified: trunk/Source/WebCore/platform/KURL.cpp (149465 => 149466)
--- trunk/Source/WebCore/platform/KURL.cpp 2013-05-02 00:02:29 UTC (rev 149465)
+++ trunk/Source/WebCore/platform/KURL.cpp 2013-05-02 00:15:28 UTC (rev 149466)
@@ -1889,7 +1889,7 @@
index = url.find(',');
if (index != notFound) {
if (index > 5)
-return url.substring(5, index - 5);
+return url.substring(5, index - 5).lower();
return "text/plain"; // Data URLs with no MIME type are considered text/plain.
}
return "";
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [149465] trunk/Source/WebCore
Title: [149465] trunk/Source/WebCore
Revision 149465
Author rn...@webkit.org
Date 2013-05-01 17:02:29 -0700 (Wed, 01 May 2013)
Log Message
[Mac] Text replacement should use correction indicator
https://bugs.webkit.org/show_bug.cgi?id=115471
Reviewed by Darin Adler.
Support autocorrection panel for text replacements by making AlternativeTextTypeCorrection
handle text replacements as well as automatic spelling correction.
No new tests. Unfortunately this feature is not testable as is. We need to provide some
internals or testRunner methods to make this feature testable in the long term.
* editing/AlternativeTextController.cpp:
(WebCore::AlternativeTextController::timerFired): Trigger both TextCheckingTypeReplacement
and TextCheckingTypeShowCorrectionPanel.
* editing/Editor.cpp:
(WebCore::Editor::markAndReplaceFor): Autocorrection panel maybe used for both
TextCheckingTypeReplacement and TextCheckingTypeShowCorrectionPanel.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/editing/AlternativeTextController.cpp
trunk/Source/WebCore/editing/Editor.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (149464 => 149465)
--- trunk/Source/WebCore/ChangeLog 2013-05-01 23:46:55 UTC (rev 149464)
+++ trunk/Source/WebCore/ChangeLog 2013-05-02 00:02:29 UTC (rev 149465)
@@ -1,3 +1,24 @@
+2013-05-01 Ryosuke Niwa
+
+[Mac] Text replacement should use correction indicator
+https://bugs.webkit.org/show_bug.cgi?id=115471
+
+Reviewed by Darin Adler.
+
+Support autocorrection panel for text replacements by making AlternativeTextTypeCorrection
+handle text replacements as well as automatic spelling correction.
+
+No new tests. Unfortunately this feature is not testable as is. We need to provide some
+internals or testRunner methods to make this feature testable in the long term.
+
+* editing/AlternativeTextController.cpp:
+(WebCore::AlternativeTextController::timerFired): Trigger both TextCheckingTypeReplacement
+and TextCheckingTypeShowCorrectionPanel.
+
+* editing/Editor.cpp:
+(WebCore::Editor::markAndReplaceFor): Autocorrection panel maybe used for both
+TextCheckingTypeReplacement and TextCheckingTypeShowCorrectionPanel.
+
2013-05-01 Tim Horton
Move knowledge of PDF/PostScript MIME types into MIMETypeRegistry
Modified: trunk/Source/WebCore/editing/AlternativeTextController.cpp (149464 => 149465)
--- trunk/Source/WebCore/editing/AlternativeTextController.cpp 2013-05-01 23:46:55 UTC (rev 149464)
+++ trunk/Source/WebCore/editing/AlternativeTextController.cpp 2013-05-02 00:02:29 UTC (rev 149465)
@@ -339,7 +339,7 @@
VisiblePosition start(selection.start(), selection.affinity());
VisiblePosition p = startOfWord(start, LeftWordIfOnBoundary);
VisibleSelection adjacentWords = VisibleSelection(p, start);
-m_frame->editor()->markAllMisspellingsAndBadGrammarInRanges(TextCheckingTypeSpelling | TextCheckingTypeShowCorrectionPanel, adjacentWords.toNormalizedRange().get(), 0);
+m_frame->editor()->markAllMisspellingsAndBadGrammarInRanges(TextCheckingTypeSpelling | TextCheckingTypeReplacement | TextCheckingTypeShowCorrectionPanel, adjacentWords.toNormalizedRange().get(), 0);
}
break;
case AlternativeTextTypeReversion: {
Modified: trunk/Source/WebCore/editing/Editor.cpp (149464 => 149465)
--- trunk/Source/WebCore/editing/Editor.cpp 2013-05-01 23:46:55 UTC (rev 149464)
+++ trunk/Source/WebCore/editing/Editor.cpp 2013-05-02 00:02:29 UTC (rev 149465)
@@ -2246,7 +2246,8 @@
// In this case the result range just has to touch the spelling range, so we can handle replacing non-word text such as punctuation.
ASSERT(resultLength > 0 && resultLocation >= 0);
-if (shouldShowCorrectionPanel && (resultEndLocation < spellingRangeEndOffset || resultType != TextCheckingTypeCorrection))
+if (shouldShowCorrectionPanel && (resultEndLocation < spellingRangeEndOffset
+|| !(resultType & (TextCheckingTypeReplacement | TextCheckingTypeCorrection
continue;
// Apply replacement if:
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [149464] trunk/Source
Title: [149464] trunk/Source Revision 149464 Author timothy_hor...@apple.com Date 2013-05-01 16:46:55 -0700 (Wed, 01 May 2013) Log Message Move knowledge of PDF/PostScript MIME types into MIMETypeRegistry https://bugs.webkit.org/show_bug.cgi?id=115487 Reviewed by Darin Adler. No new tests, just a refactoring. * UIProcess/WebContext.cpp: * UIProcess/WebContext.h: Remove pdfAndPostScriptMIMETypes. * UIProcess/WebFrameProxy.cpp: (WebKit::WebFrameProxy::canShowMIMEType): Move PDF bits to WebPageProxy. (WebKit::WebFrameProxy::isDisplayingPDFDocument): Make use of WebCore's newfound knowledge of PDF and PostScript MIME types, so we don't have to duplicate it unnecessarily in WebKit2. * UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::canShowMIMEType): Add code which used to be in WebFrameProxy::canShowMIMEType, and adapt it to use WebCore's knowledge of PDF and PostScript MIME types. * WebProcess/Plugins/PDF/SimplePDFPlugin.mm: (WebKit::SimplePDFPlugin::pluginInfo): We previously supported the "text/pdf" MIME type for PDFViewController, so SimplePDFPlugin and PDFPlugin should support it as well. * WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::createPlugin): Adopt MIMETypeRegistry::isPDFOrPostScriptMIMEType. * WebProcess/WebPage/WebPage.h: (WebPage): Remove pdfAndPostScriptMIMETypes. * WebProcess/WebPage/mac/WebPageMac.mm: (WebKit::WebPage::platformPreferencesDidChange): Adopt getPDFAndPostScriptMIMETypes instead of duplicating the list in WebKit2. * WebCore.exp.in: Export newly-added isPDFOrPostScriptMIMEType and getPDFAndPostScriptMIMETypes. * dom/DOMImplementation.cpp: (WebCore::DOMImplementation::createDocument): Adopt MIMETypeRegistry::isPDFOrPostScriptMIMEType instead of duplicating the list of MIME types. The previous list did not include PostScript, but it seems reasonable to put plugins ahead of built-in support for it in addition to PDF. * platform/MIMETypeRegistry.cpp: (WebCore::initializePDFAndPostScriptMIMETypes): Added. (WebCore::initializeMIMETypeRegistry): Call initializePDFAndPostScriptMIMETypes. (WebCore::MIMETypeRegistry::isPDFOrPostScriptMIMEType): Consult our new HashSet to see if the given MIME type is one of those used for PDF or PS. (WebCore::MIMETypeRegistry::getPDFAndPostScriptMIMETypes): Added. * platform/MIMETypeRegistry.h: (MIMETypeRegistry): Add isPDFOrPostScriptMIMEType and getPDFAndPostScriptMIMETypes. Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/WebCore.exp.in trunk/Source/WebCore/dom/DOMImplementation.cpp trunk/Source/WebCore/platform/MIMETypeRegistry.cpp trunk/Source/WebCore/platform/MIMETypeRegistry.h trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/UIProcess/WebContext.cpp trunk/Source/WebKit2/UIProcess/WebContext.h trunk/Source/WebKit2/UIProcess/WebFrameProxy.cpp trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp trunk/Source/WebKit2/WebProcess/Plugins/PDF/SimplePDFPlugin.mm trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp trunk/Source/WebKit2/WebProcess/WebPage/WebPage.h trunk/Source/WebKit2/WebProcess/WebPage/mac/WebPageMac.mm Diff Modified: trunk/Source/WebCore/ChangeLog (149463 => 149464) --- trunk/Source/WebCore/ChangeLog 2013-05-01 23:28:46 UTC (rev 149463) +++ trunk/Source/WebCore/ChangeLog 2013-05-01 23:46:55 UTC (rev 149464) @@ -1,3 +1,31 @@ +2013-05-01 Tim Horton + +Move knowledge of PDF/PostScript MIME types into MIMETypeRegistry +https://bugs.webkit.org/show_bug.cgi?id=115487 + +Reviewed by Darin Adler. + +No new tests, just a refactoring. + +* WebCore.exp.in: +Export newly-added isPDFOrPostScriptMIMEType and getPDFAndPostScriptMIMETypes. + +* dom/DOMImplementation.cpp: +(WebCore::DOMImplementation::createDocument): +Adopt MIMETypeRegistry::isPDFOrPostScriptMIMEType instead of duplicating +the list of MIME types. The previous list did not include PostScript, but +it seems reasonable to put plugins ahead of built-in support for it in addition to PDF. + +* platform/MIMETypeRegistry.cpp: +(WebCore::initializePDFAndPostScriptMIMETypes): Added. +(WebCore::initializeMIMETypeRegistry): Call initializePDFAndPostScriptMIMETypes. +(WebCore::MIMETypeRegistry::isPDFOrPostScriptMIMEType): +Consult our new HashSet to see if the given MIME type is one of those used for PDF or PS. + +(WebCore::MIMETypeRegistry::getPDFAndPostScriptMIMETypes): Added. +* platform/MIMETypeRegistry.h: +(MIMETypeRegistry): Add isPDFOrPostScriptMIMEType and getPDFAndPostScriptMIMETypes. + 2013-05-01 Anders Carlsson Implement LocalStorageDatabase::importItems Modified: trunk/Source/WebCore/WebCore.exp.in (149463 => 149464) --- trunk/Source/WebCore/WebCore.exp.in 2013-05-01 23:28:46 UTC (rev 149463) +++ trunk/Source/WebCore/WebCore.exp.in 2013-05-01 23:46:55 UTC (rev 149464) @@ -528,9 +528,11 @@ __ZN7WebCore16MIMETypeRegistry20isJavaAppletMIMETypeERKN3WTF6StringE __ZN7WebC
[webkit-changes] [149463] trunk/Source
Title: [149463] trunk/Source Revision 149463 Author roger_f...@apple.com Date 2013-05-01 16:28:46 -0700 (Wed, 01 May 2013) Log Message Set Path in makefile for AppleWin. * _javascript_Core.vcxproj/_javascript_Core.make: Modified Paths trunk/Source/_javascript_Core/ChangeLog trunk/Source/_javascript_Core/_javascript_Core.vcxproj/_javascript_Core.make trunk/Source/WTF/ChangeLog trunk/Source/WTF/WTF.vcxproj/WTF.make Diff Modified: trunk/Source/_javascript_Core/ChangeLog (149462 => 149463) --- trunk/Source/_javascript_Core/ChangeLog 2013-05-01 23:20:29 UTC (rev 149462) +++ trunk/Source/_javascript_Core/ChangeLog 2013-05-01 23:28:46 UTC (rev 149463) @@ -1,3 +1,9 @@ +2013-05-01 Roger Fong + +Set Path in makefile for AppleWin. + +* _javascript_Core.vcxproj/_javascript_Core.make: + 2013-05-01 Benjamin Poulain Remove the remaining wscript Modified: trunk/Source/_javascript_Core/_javascript_Core.vcxproj/_javascript_Core.make (149462 => 149463) --- trunk/Source/_javascript_Core/_javascript_Core.vcxproj/_javascript_Core.make 2013-05-01 23:20:29 UTC (rev 149462) +++ trunk/Source/_javascript_Core/_javascript_Core.vcxproj/_javascript_Core.make 2013-05-01 23:28:46 UTC (rev 149463) @@ -8,6 +8,7 @@ set OFFICIAL_BUILD=1 set WebKit_Libraries=$(SRCROOT)\AppleInternal set WebKit_OutputDir=$(OBJROOT) +set Path=%PATH%;$(SRCROOT)\Program Files (x86)\Common Files\Apple\Apple Application Support set ConfigurationBuildDir=$(OBJROOT)\$(BUILDSTYLE) -mkdir "%ConfigurationBuildDir%\include\private" xcopy "%WebKit_Libraries%\include\private\*" "%ConfigurationBuildDir%\include\private" /e/v/i/h/y Modified: trunk/Source/WTF/ChangeLog (149462 => 149463) --- trunk/Source/WTF/ChangeLog 2013-05-01 23:20:29 UTC (rev 149462) +++ trunk/Source/WTF/ChangeLog 2013-05-01 23:28:46 UTC (rev 149463) @@ -1,3 +1,9 @@ +2013-05-01 Roger Fong + +Set Path in makefile for AppleWin. + +* WTF.vcxproj/WTF.make: + 2013-05-01 Anders Carlsson Add FunctionDispatcher class and make RunLoop derive from it Modified: trunk/Source/WTF/WTF.vcxproj/WTF.make (149462 => 149463) --- trunk/Source/WTF/WTF.vcxproj/WTF.make 2013-05-01 23:20:29 UTC (rev 149462) +++ trunk/Source/WTF/WTF.vcxproj/WTF.make 2013-05-01 23:28:46 UTC (rev 149463) @@ -8,6 +8,7 @@ set OFFICIAL_BUILD=1 set WebKit_Libraries=$(SRCROOT)\AppleInternal set WebKit_OutputDir=$(OBJROOT) +set Path=%PATH%;$(SRCROOT)\Program Files (x86)\Common Files\Apple\Apple Application Support set ConfigurationBuildDir=$(OBJROOT)\$(BUILDSTYLE) devenv "WTF.submit.sln" /clean $(BUILDSTYLE) devenv "WTF.submit.sln" /build $(BUILDSTYLE) ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [149462] tags/Safari-537.39.3/Source
Title: [149462] tags/Safari-537.39.3/Source Revision 149462 Author lforsch...@apple.com Date 2013-05-01 16:20:29 -0700 (Wed, 01 May 2013) Log Message Versioning. Modified Paths tags/Safari-537.39.3/Source/_javascript_Core/Configurations/Version.xcconfig tags/Safari-537.39.3/Source/WebCore/Configurations/Version.xcconfig tags/Safari-537.39.3/Source/WebKit/mac/Configurations/Version.xcconfig tags/Safari-537.39.3/Source/WebKit2/Configurations/Version.xcconfig Diff Modified: tags/Safari-537.39.3/Source/_javascript_Core/Configurations/Version.xcconfig (149461 => 149462) --- tags/Safari-537.39.3/Source/_javascript_Core/Configurations/Version.xcconfig 2013-05-01 23:17:47 UTC (rev 149461) +++ tags/Safari-537.39.3/Source/_javascript_Core/Configurations/Version.xcconfig 2013-05-01 23:20:29 UTC (rev 149462) @@ -23,7 +23,7 @@ MAJOR_VERSION = 537; MINOR_VERSION = 39; -TINY_VERSION = 2; +TINY_VERSION = 3; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: tags/Safari-537.39.3/Source/WebCore/Configurations/Version.xcconfig (149461 => 149462) --- tags/Safari-537.39.3/Source/WebCore/Configurations/Version.xcconfig 2013-05-01 23:17:47 UTC (rev 149461) +++ tags/Safari-537.39.3/Source/WebCore/Configurations/Version.xcconfig 2013-05-01 23:20:29 UTC (rev 149462) @@ -23,7 +23,7 @@ MAJOR_VERSION = 537; MINOR_VERSION = 39; -TINY_VERSION = 2; +TINY_VERSION = 3; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: tags/Safari-537.39.3/Source/WebKit/mac/Configurations/Version.xcconfig (149461 => 149462) --- tags/Safari-537.39.3/Source/WebKit/mac/Configurations/Version.xcconfig 2013-05-01 23:17:47 UTC (rev 149461) +++ tags/Safari-537.39.3/Source/WebKit/mac/Configurations/Version.xcconfig 2013-05-01 23:20:29 UTC (rev 149462) @@ -23,7 +23,7 @@ MAJOR_VERSION = 537; MINOR_VERSION = 39; -TINY_VERSION = 2; +TINY_VERSION = 3; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: tags/Safari-537.39.3/Source/WebKit2/Configurations/Version.xcconfig (149461 => 149462) --- tags/Safari-537.39.3/Source/WebKit2/Configurations/Version.xcconfig 2013-05-01 23:17:47 UTC (rev 149461) +++ tags/Safari-537.39.3/Source/WebKit2/Configurations/Version.xcconfig 2013-05-01 23:20:29 UTC (rev 149462) @@ -23,7 +23,7 @@ MAJOR_VERSION = 537; MINOR_VERSION = 39; -TINY_VERSION = 2; +TINY_VERSION = 3; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [149461] tags/Safari-537.39.3/
Title: [149461] tags/Safari-537.39.3/ Revision 149461 Author lforsch...@apple.com Date 2013-05-01 16:17:47 -0700 (Wed, 01 May 2013) Log Message New Tag. Added Paths tags/Safari-537.39.3/ Diff Property changes: tags/Safari-537.39.3 Added: svn:ignore depcomp compile config.guess GNUmakefile.in config.sub ltmain.sh aconfig.h.in autom4te.cache missing aclocal.m4 install-sh autotoolsconfig.h.in INSTALL README gtk-doc.make out Makefile.chromium WebKitSupportLibrary.zip WebKitBuild Added: svn:mergeinfo ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [149460] trunk/Source
Title: [149460] trunk/Source
Revision 149460
Author ander...@apple.com
Date 2013-05-01 16:17:29 -0700 (Wed, 01 May 2013)
Log Message
Implement LocalStorageDatabase::importItems
https://bugs.webkit.org/show_bug.cgi?id=115493
Reviewed by Andreas Kling.
Source/WebCore:
Export symbols needed by WebKit2.
* WebCore.exp.in:
Source/WebKit2:
Fetch items and insert them in the storage map.
* UIProcess/Storage/LocalStorageDatabase.cpp:
(WebKit::LocalStorageDatabase::importItems):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/WebCore.exp.in
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/Storage/LocalStorageDatabase.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (149459 => 149460)
--- trunk/Source/WebCore/ChangeLog 2013-05-01 23:01:39 UTC (rev 149459)
+++ trunk/Source/WebCore/ChangeLog 2013-05-01 23:17:29 UTC (rev 149460)
@@ -1,5 +1,16 @@
2013-05-01 Anders Carlsson
+Implement LocalStorageDatabase::importItems
+https://bugs.webkit.org/show_bug.cgi?id=115493
+
+Reviewed by Andreas Kling.
+
+Export symbols needed by WebKit2.
+
+* WebCore.exp.in:
+
+2013-05-01 Anders Carlsson
+
Begin work on loading items from the local storage database
https://bugs.webkit.org/show_bug.cgi?id=115489
Modified: trunk/Source/WebCore/WebCore.exp.in (149459 => 149460)
--- trunk/Source/WebCore/WebCore.exp.in 2013-05-01 23:01:39 UTC (rev 149459)
+++ trunk/Source/WebCore/WebCore.exp.in 2013-05-01 23:17:29 UTC (rev 149460)
@@ -272,6 +272,7 @@
__ZN7WebCore13pointerCursorEv
__ZN7WebCore13ResourceErrorC1EP7NSError
__ZN7WebCore13ResourceErrorC1EP9__CFError
+__ZN7WebCore13SQLResultDoneE
__ZN7WebCore13StyledElement22setInlineStylePropertyENS_13CSSPropertyIDERKN3WTF6StringEb
__ZN7WebCore13StyledElement22setInlineStylePropertyENS_13CSSPropertyIDEdNS_17CSSPrimitiveValue9UnitTypesEb
__ZN7WebCore13cookiesForDOMERKNS_21NetworkStorageSessionERKNS_4KURLES5_
@@ -474,7 +475,11 @@
__ZN7WebCore15ProtectionSpaceC1Ev
__ZN7WebCore15ResourceRequest21httpPipeliningEnabledEv
__ZN7WebCore15ResourceRequest24setHTTPPipeliningEnabledEb
+__ZN7WebCore15SQLiteStatement13getColumnTextEi
+__ZN7WebCore15SQLiteStatement21getColumnBlobAsStringEi
__ZN7WebCore15SQLiteStatement22isColumnDeclaredAsBlobEi
+__ZN7WebCore15SQLiteStatement4stepEv
+__ZN7WebCore15SQLiteStatement7prepareEv
__ZN7WebCore15SQLiteStatementC1ERNS_14SQLiteDatabaseERKN3WTF6StringE
__ZN7WebCore15SQLiteStatementD1Ev
__ZN7WebCore15ScrollAlignment17alignCenterAlwaysE
@@ -1792,6 +1797,7 @@
__ZN7WebCore10FloatPointC1ERK8_NSPoint
__ZN7WebCore10handCursorEv
__ZN7WebCore11CachedImage5imageEv
+__ZN7WebCore11SQLResultOkE
__ZN7WebCore11globalPointERK8_NSPointP8NSWindow
__ZN7WebCore11toUserSpaceERK7_NSRectP8NSWindow
__ZN7WebCore12EventHandler10mouseMovedEP7NSEvent
@@ -1803,6 +1809,7 @@
__ZN7WebCore12EventHandler8keyEventEP7NSEvent
__ZN7WebCore12EventHandler9mouseDownEP7NSEvent
__ZN7WebCore12PopupMenuMacC1EPNS_15PopupMenuClientE
+__ZN7WebCore12SQLResultRowE
__ZN7WebCore13toDeviceSpaceERKNS_9FloatRectEP8NSWindow
__ZN7WebCore13getRawCookiesERKNS_21NetworkStorageSessionERKNS_4KURLES5_RN3WTF6VectorINS_6CookieELm0ENS6_15CrashOnOverflowEEE
__ZN7WebCore15GraphicsContextC1EP9CGContext
Modified: trunk/Source/WebKit2/ChangeLog (149459 => 149460)
--- trunk/Source/WebKit2/ChangeLog 2013-05-01 23:01:39 UTC (rev 149459)
+++ trunk/Source/WebKit2/ChangeLog 2013-05-01 23:17:29 UTC (rev 149460)
@@ -1,5 +1,16 @@
2013-05-01 Anders Carlsson
+Implement LocalStorageDatabase::importItems
+https://bugs.webkit.org/show_bug.cgi?id=115493
+
+Reviewed by Andreas Kling.
+
+Fetch items and insert them in the storage map.
+* UIProcess/Storage/LocalStorageDatabase.cpp:
+(WebKit::LocalStorageDatabase::importItems):
+
+2013-05-01 Anders Carlsson
+
Begin work on loading items from the local storage database
https://bugs.webkit.org/show_bug.cgi?id=115489
Modified: trunk/Source/WebKit2/UIProcess/Storage/LocalStorageDatabase.cpp (149459 => 149460)
--- trunk/Source/WebKit2/UIProcess/Storage/LocalStorageDatabase.cpp 2013-05-01 23:01:39 UTC (rev 149459)
+++ trunk/Source/WebKit2/UIProcess/Storage/LocalStorageDatabase.cpp 2013-05-01 23:17:29 UTC (rev 149460)
@@ -30,7 +30,9 @@
#include
#include
#include
+#include
#include
+#include
#include
using namespace WebCore;
@@ -134,7 +136,7 @@
return true;
}
-void LocalStorageDatabase::importItems(StorageMap&)
+void LocalStorageDatabase::importItems(StorageMap& storageMap)
{
// FIXME: If it can't import, then the default WebKit behavior should be that of private browsing,
// not silently ignoring it. https://bugs.webkit.org/show_bug.cgi?id=25894
@@ -143,7 +145,26 @@
if (!m_database.isOpen())
return;
-// FIXME: Actually import the items.
+SQLiteStatement query(m_database, "SELECT key, value FROM ItemTable");
+if (query.prepare() != SQLRe
[webkit-changes] [149459] branches/dfgFourthTier/Source/JavaScriptCore
Title: [149459] branches/dfgFourthTier/Source/_javascript_Core Revision 149459 Author fpi...@apple.com Date 2013-05-01 16:01:39 -0700 (Wed, 01 May 2013) Log Message fourthTier: Structure::addPropertyTransitionToExistingStructure should be thread-safe https://bugs.webkit.org/show_bug.cgi?id=115468 Reviewed by Geoffrey Garen. This makes the main thread modify the transition table while holding a lock. Note that the GC might modify its weak pointers without locking, but the GC will lock out the compilation thread anyway. The map will then only reshape in response to add() and set(), which happen while holding a lock. This allows the compilation thread to now query transition tables safely, provided it holds a lock when doing so. Also changed LLVM asm printer initialization to just initialize the X86 one. It makes sense for us to just initialize the asm printer(s) that we actually use; you could imagine us being linked to a system LLVM that has cross-compilation support; there is no point in the WebKit or JSC process doing work to initialize all of those targets. That part was rubber stamped by Mark Hahnenberg. * bytecode/PutByIdStatus.cpp: (JSC::PutByIdStatus::computeFor): * runtime/InitializeThreading.cpp: (JSC::initializeThreadingOnce): * runtime/Structure.cpp: (JSC::Structure::addPropertyTransitionToExistingStructureImpl): (JSC::Structure::addPropertyTransitionToExistingStructure): (JSC): (JSC::Structure::addPropertyTransitionToExistingStructureConcurrently): (JSC::Structure::addPropertyTransition): (JSC::Structure::nonPropertyTransition): * runtime/Structure.h: (Structure): Modified Paths branches/dfgFourthTier/Source/_javascript_Core/ChangeLog branches/dfgFourthTier/Source/_javascript_Core/bytecode/PutByIdStatus.cpp branches/dfgFourthTier/Source/_javascript_Core/runtime/InitializeThreading.cpp branches/dfgFourthTier/Source/_javascript_Core/runtime/Structure.cpp branches/dfgFourthTier/Source/_javascript_Core/runtime/Structure.h Diff Modified: branches/dfgFourthTier/Source/_javascript_Core/ChangeLog (149458 => 149459) --- branches/dfgFourthTier/Source/_javascript_Core/ChangeLog 2013-05-01 22:38:45 UTC (rev 149458) +++ branches/dfgFourthTier/Source/_javascript_Core/ChangeLog 2013-05-01 23:01:39 UTC (rev 149459) @@ -1,3 +1,38 @@ +2013-05-01 Filip Pizlo + +fourthTier: Structure::addPropertyTransitionToExistingStructure should be thread-safe +https://bugs.webkit.org/show_bug.cgi?id=115468 + +Reviewed by Geoffrey Garen. + +This makes the main thread modify the transition table while holding a lock. Note +that the GC might modify its weak pointers without locking, but the GC will lock out +the compilation thread anyway. The map will then only reshape in response to add() +and set(), which happen while holding a lock. + +This allows the compilation thread to now query transition tables safely, provided it +holds a lock when doing so. + +Also changed LLVM asm printer initialization to just initialize the X86 one. It makes +sense for us to just initialize the asm printer(s) that we actually use; you could +imagine us being linked to a system LLVM that has cross-compilation support; there is +no point in the WebKit or JSC process doing work to initialize all of those targets. +That part was rubber stamped by Mark Hahnenberg. + +* bytecode/PutByIdStatus.cpp: +(JSC::PutByIdStatus::computeFor): +* runtime/InitializeThreading.cpp: +(JSC::initializeThreadingOnce): +* runtime/Structure.cpp: +(JSC::Structure::addPropertyTransitionToExistingStructureImpl): +(JSC::Structure::addPropertyTransitionToExistingStructure): +(JSC): +(JSC::Structure::addPropertyTransitionToExistingStructureConcurrently): +(JSC::Structure::addPropertyTransition): +(JSC::Structure::nonPropertyTransition): +* runtime/Structure.h: +(Structure): + 2013-04-30 Filip Pizlo fourthTier: Structure::getConcurrently() may be called from for uncacheable dictionaries, and this is safe Modified: branches/dfgFourthTier/Source/_javascript_Core/bytecode/PutByIdStatus.cpp (149458 => 149459) --- branches/dfgFourthTier/Source/_javascript_Core/bytecode/PutByIdStatus.cpp 2013-05-01 22:38:45 UTC (rev 149458) +++ branches/dfgFourthTier/Source/_javascript_Core/bytecode/PutByIdStatus.cpp 2013-05-01 23:01:39 UTC (rev 149459) @@ -201,7 +201,7 @@ // - If we're not storing a value that could be specific: again, this would only be a // problem if the existing transition did have a specific value, which we check for // by passing 0 for the specificValue. -Structure* transition = Structure::addPropertyTransitionToExistingStructure(structure, ident, 0, 0, offset); +Structure* transition = Structure::addPropertyTransitionToExistingStructureC
[webkit-changes] [149458] trunk/Source
Title: [149458] trunk/Source Revision 149458 Author ander...@apple.com Date 2013-05-01 15:38:45 -0700 (Wed, 01 May 2013) Log Message Begin work on loading items from the local storage database https://bugs.webkit.org/show_bug.cgi?id=115489 Reviewed by Andreas Kling. Source/WebCore: Export symbols and SQLite headers needed. * WebCore.exp.in: * WebCore.xcodeproj/project.pbxproj: Source/WebKit2: Some of the LocalStorageDatabase code is originally from WebCore, but has been simplified due to the fact that we don't need to load database data asynchronously since we're already running on a non-main thread. * UIProcess/Storage/LocalStorageDatabase.cpp: (WebKit::LocalStorageDatabase::LocalStorageDatabase): (WebKit::LocalStorageDatabase::openDatabase): (WebKit::LocalStorageDatabase::tryToOpenDatabase): (WebKit::LocalStorageDatabase::migrateItemTableIfNeeded): (WebKit::LocalStorageDatabase::importItems): * UIProcess/Storage/LocalStorageDatabase.h: (WebKit::StorageManager::StorageArea::setItem): (WebKit::StorageManager::StorageArea::removeItem): (WebKit::StorageManager::StorageArea::clear): (WebKit::StorageManager::StorageArea::items): Call importItemsFromDatabase(). (WebKit::StorageManager::StorageArea::importItemsFromDatabase): Ask the database to import the items. Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/WebCore.exp.in trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/UIProcess/Storage/LocalStorageDatabase.cpp trunk/Source/WebKit2/UIProcess/Storage/LocalStorageDatabase.h trunk/Source/WebKit2/UIProcess/Storage/StorageManager.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (149457 => 149458) --- trunk/Source/WebCore/ChangeLog 2013-05-01 22:01:10 UTC (rev 149457) +++ trunk/Source/WebCore/ChangeLog 2013-05-01 22:38:45 UTC (rev 149458) @@ -1,3 +1,15 @@ +2013-05-01 Anders Carlsson + +Begin work on loading items from the local storage database +https://bugs.webkit.org/show_bug.cgi?id=115489 + +Reviewed by Andreas Kling. + +Export symbols and SQLite headers needed. + +* WebCore.exp.in: +* WebCore.xcodeproj/project.pbxproj: + 2013-05-01 Hans Muller [CSS Exclusions] Programmatic layout tests fail when subpixel layout is disabled https://bugs.webkit.org/show_bug.cgi?id=115455 Modified: trunk/Source/WebCore/WebCore.exp.in (149457 => 149458) --- trunk/Source/WebCore/WebCore.exp.in 2013-05-01 22:01:10 UTC (rev 149457) +++ trunk/Source/WebCore/WebCore.exp.in 2013-05-01 22:38:45 UTC (rev 149458) @@ -94,6 +94,7 @@ __ZN7WebCore10StorageMap6createEj __ZN7WebCore10StorageMap7setItemERKN3WTF6StringES4_RS2_Rb __ZN7WebCore10deleteFileERKN3WTF6StringE +__ZN7WebCore10fileExistsERKN3WTF6StringE __ZN7WebCore10setCookiesEPNS_8DocumentERKNS_4KURLERKN3WTF6StringE __ZN7WebCore10toDocumentEN3JSC7JSValueE __ZN7WebCore11BitmapImageC1EP7CGImagePNS_13ImageObserverE @@ -355,6 +356,9 @@ __ZN7WebCore14ResourceHandle6createEPNS_17NetworkingContextERKNS_15ResourceRequestEPNS_20ResourceHandleClientEbb __ZN7WebCore14ResourceLoader14cancelledErrorEv __ZN7WebCore14ResourceLoader6cancelEv +__ZN7WebCore14SQLiteDatabase11tableExistsERKN3WTF6StringE +__ZN7WebCore14SQLiteDatabase14executeCommandERKN3WTF6StringE +__ZN7WebCore14SQLiteDatabase4openERKN3WTF6StringEb __ZN7WebCore14SchemeRegistry24registerURLSchemeAsLocalERKN3WTF6StringE __ZN7WebCore14SchemeRegistry25registerURLSchemeAsSecureERKN3WTF6StringE __ZN7WebCore14SchemeRegistry27registerURLSchemeAsNoAccessERKN3WTF6StringE @@ -409,8 +413,6 @@ __ZN7WebCore14setMetadataURLERN3WTF6StringERKS1_S4_ __ZN7WebCore15AffineTransform5flipYEv __ZN7WebCore15AffineTransform5scaleEd -__ZNK7WebCore15AffineTransform6xScaleEv -__ZNK7WebCore15AffineTransform6yScaleEv __ZN7WebCore15AffineTransform8multiplyERKS0_ __ZN7WebCore15AffineTransform9translateEdd __ZN7WebCore15AffineTransformC1Edd @@ -472,6 +474,9 @@ __ZN7WebCore15ProtectionSpaceC1Ev __ZN7WebCore15ResourceRequest21httpPipeliningEnabledEv __ZN7WebCore15ResourceRequest24setHTTPPipeliningEnabledEb +__ZN7WebCore15SQLiteStatement22isColumnDeclaredAsBlobEi +__ZN7WebCore15SQLiteStatementC1ERNS_14SQLiteDatabaseERKN3WTF6StringE +__ZN7WebCore15SQLiteStatementD1Ev __ZN7WebCore15ScrollAlignment17alignCenterAlwaysE __ZN7WebCore15ScrollAlignment19alignToEdgeIfNeededE __ZN7WebCore15StorageStrategy21localStorageNamespaceEPNS_9PageGroupE @@ -528,6 +533,11 @@ __ZN7WebCore16NavigationActionC1ERKNS_15ResourceRequestENS_14NavigationTypeE __ZN7WebCore16NavigationActionC1Ev __ZN7WebCore16ResourceResponse19setCertificateChainEPK9__CFArray +__ZN7WebCore17SQLiteTransaction5beginEv +__ZN7WebCore17SQLiteTransaction6commitEv +__ZN7WebCore17SQLiteTransaction8rollbackEv +__ZN7WebCore17SQLiteTransactionC1ERNS_14SQLiteDatabaseEb +__ZN7WebCore17SQLiteTransactionD1Ev __ZN7WebCore16ScriptController10initScriptEPNS_15DOMWrapperWorldE __ZN7WebCore16ScriptController11createWorldEv __ZN7WebCore
[webkit-changes] [149455] branches/dfgFourthTier/Source/JavaScriptCore
Title: [149455] branches/dfgFourthTier/Source/_javascript_Core
Revision 149455
Author fpi...@apple.com
Date 2013-05-01 14:36:25 -0700 (Wed, 01 May 2013)
Log Message
fourthTier: Structure::getConcurrently() may be called from for uncacheable dictionaries, and this is safe
https://bugs.webkit.org/show_bug.cgi?id=115464
Reviewed by Oliver Hunt and Geoffrey Garen.
This can happen for example transitively from JSObject::put(). getCurrently() does
work for uncacheable dictionaries; it just has the obvious race that right after it
returns, the result it returned may no longer be right. This isn't an issue if it was
called on the main thread, and may not be an issue in some other situations.
So, we should just remove the assertion, since the only thing it buys us is crashes.
* runtime/Structure.cpp:
(JSC::Structure::getConcurrently):
Modified Paths
branches/dfgFourthTier/Source/_javascript_Core/ChangeLog
branches/dfgFourthTier/Source/_javascript_Core/runtime/Structure.cpp
Diff
Modified: branches/dfgFourthTier/Source/_javascript_Core/ChangeLog (149454 => 149455)
--- branches/dfgFourthTier/Source/_javascript_Core/ChangeLog 2013-05-01 21:22:24 UTC (rev 149454)
+++ branches/dfgFourthTier/Source/_javascript_Core/ChangeLog 2013-05-01 21:36:25 UTC (rev 149455)
@@ -1,5 +1,22 @@
2013-04-30 Filip Pizlo
+fourthTier: Structure::getConcurrently() may be called from for uncacheable dictionaries, and this is safe
+https://bugs.webkit.org/show_bug.cgi?id=115464
+
+Reviewed by Oliver Hunt and Geoffrey Garen.
+
+This can happen for example transitively from JSObject::put(). getCurrently() does
+work for uncacheable dictionaries; it just has the obvious race that right after it
+returns, the result it returned may no longer be right. This isn't an issue if it was
+called on the main thread, and may not be an issue in some other situations.
+
+So, we should just remove the assertion, since the only thing it buys us is crashes.
+
+* runtime/Structure.cpp:
+(JSC::Structure::getConcurrently):
+
+2013-04-30 Filip Pizlo
+
fourthTier: Don't link gtest into _javascript_Core
Rubber stamped by Mark Rowe.
Modified: branches/dfgFourthTier/Source/_javascript_Core/runtime/Structure.cpp (149454 => 149455)
--- branches/dfgFourthTier/Source/_javascript_Core/runtime/Structure.cpp 2013-05-01 21:22:24 UTC (rev 149454)
+++ branches/dfgFourthTier/Source/_javascript_Core/runtime/Structure.cpp 2013-05-01 21:36:25 UTC (rev 149455)
@@ -773,10 +773,6 @@
PropertyOffset Structure::getConcurrently(VM&, PropertyName propertyName, unsigned& attributes, JSCell*& specificValue)
{
-// We can't handle uncacheable dictionaries because we can't handle concurrent remove's
-// from the property maps.
-RELEASE_ASSERT(!isUncacheableDictionary());
-
Vector structures;
Structure* structure;
PropertyTable* table;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [149454] trunk/Source/WebKit/mac
Title: [149454] trunk/Source/WebKit/mac
Revision 149454
Author benja...@webkit.org
Date 2013-05-01 14:22:24 -0700 (Wed, 01 May 2013)
Log Message
Fix the function names of r149453
Unreviewed.
I forgot to follow one of Darin's review comment. This patch
fixes the function names to follow CF naming conventions.
Patch by Benjamin Poulain on 2013-05-01
* WebView/WebHTMLRepresentation.mm:
(newArrayWithStrings):
(newArrayByConcatenatingArrays):
(+[WebHTMLRepresentation supportedMIMETypes]):
(+[WebHTMLRepresentation supportedNonImageMIMETypes]):
(+[WebHTMLRepresentation supportedImageMIMETypes]):
(+[WebHTMLRepresentation unsupportedTextMIMETypes]):
Modified Paths
trunk/Source/WebKit/mac/ChangeLog
trunk/Source/WebKit/mac/WebView/WebHTMLRepresentation.mm
Diff
Modified: trunk/Source/WebKit/mac/ChangeLog (149453 => 149454)
--- trunk/Source/WebKit/mac/ChangeLog 2013-05-01 21:02:13 UTC (rev 149453)
+++ trunk/Source/WebKit/mac/ChangeLog 2013-05-01 21:22:24 UTC (rev 149454)
@@ -1,3 +1,20 @@
+2013-05-01 Benjamin Poulain
+
+Fix the function names of r149453
+
+Unreviewed.
+
+I forgot to follow one of Darin's review comment. This patch
+fixes the function names to follow CF naming conventions.
+
+* WebView/WebHTMLRepresentation.mm:
+(newArrayWithStrings):
+(newArrayByConcatenatingArrays):
+(+[WebHTMLRepresentation supportedMIMETypes]):
+(+[WebHTMLRepresentation supportedNonImageMIMETypes]):
+(+[WebHTMLRepresentation supportedImageMIMETypes]):
+(+[WebHTMLRepresentation unsupportedTextMIMETypes]):
+
2013-05-01 Benjamin Poulain
Simplify WebHTMLRepresentation supportedMIMETypes methods
Modified: trunk/Source/WebKit/mac/WebView/WebHTMLRepresentation.mm (149453 => 149454)
--- trunk/Source/WebKit/mac/WebView/WebHTMLRepresentation.mm 2013-05-01 21:02:13 UTC (rev 149453)
+++ trunk/Source/WebKit/mac/WebView/WebHTMLRepresentation.mm 2013-05-01 21:22:24 UTC (rev 149454)
@@ -84,8 +84,8 @@
@implementation WebHTMLRepresentation
-static NSMutableArray *createArrayWithStrings(const HashSet& set) NS_RETURNS_RETAINED;
-static NSMutableArray *createArrayWithStrings(const HashSet& set)
+static NSMutableArray *newArrayWithStrings(const HashSet& set) NS_RETURNS_RETAINED;
+static NSMutableArray *newArrayWithStrings(const HashSet& set)
{
NSMutableArray *array = [[NSMutableArray alloc] initWithCapacity:set.size()];
HashSet::const_iterator end = set.end();
@@ -94,8 +94,8 @@
return array;
}
-static NSMutableArray *createArrayByConcatenatingArrays(NSArray *first, NSArray *second) NS_RETURNS_RETAINED;
-static NSMutableArray *createArrayByConcatenatingArrays(NSArray *first, NSArray *second)
+static NSMutableArray *newArrayByConcatenatingArrays(NSArray *first, NSArray *second) NS_RETURNS_RETAINED;
+static NSMutableArray *newArrayByConcatenatingArrays(NSArray *first, NSArray *second)
{
NSMutableArray *result = [first mutableCopy];
[result addObjectsFromArray:second];
@@ -104,25 +104,25 @@
+ (NSArray *)supportedMIMETypes
{
-static __unsafe_unretained NSArray *staticSupportedMIMETypes = createArrayByConcatenatingArrays([self supportedNonImageMIMETypes], [self supportedImageMIMETypes]);
+static __unsafe_unretained NSArray *staticSupportedMIMETypes = newArrayByConcatenatingArrays([self supportedNonImageMIMETypes], [self supportedImageMIMETypes]);
return staticSupportedMIMETypes;
}
+ (NSArray *)supportedNonImageMIMETypes
{
-static __unsafe_unretained NSArray *staticSupportedNonImageMIMETypes = createArrayWithStrings(MIMETypeRegistry::getSupportedNonImageMIMETypes());
+static __unsafe_unretained NSArray *staticSupportedNonImageMIMETypes = newArrayWithStrings(MIMETypeRegistry::getSupportedNonImageMIMETypes());
return staticSupportedNonImageMIMETypes;
}
+ (NSArray *)supportedImageMIMETypes
{
-static __unsafe_unretained NSArray *staticSupportedImageMIMETypes = createArrayWithStrings(MIMETypeRegistry::getSupportedImageMIMETypes());
+static __unsafe_unretained NSArray *staticSupportedImageMIMETypes = newArrayWithStrings(MIMETypeRegistry::getSupportedImageMIMETypes());
return staticSupportedImageMIMETypes;
}
+ (NSArray *)unsupportedTextMIMETypes
{
-static __unsafe_unretained NSArray *staticUnsupportedTextMIMETypes = createArrayWithStrings(MIMETypeRegistry::getUnsupportedTextMIMETypes());
+static __unsafe_unretained NSArray *staticUnsupportedTextMIMETypes = newArrayWithStrings(MIMETypeRegistry::getUnsupportedTextMIMETypes());
return staticUnsupportedTextMIMETypes;
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [149453] trunk/Source/WebKit/mac
Title: [149453] trunk/Source/WebKit/mac
Revision 149453
Author benja...@webkit.org
Date 2013-05-01 14:02:13 -0700 (Wed, 01 May 2013)
Log Message
Simplify WebHTMLRepresentation supportedMIMETypes methods
https://bugs.webkit.org/show_bug.cgi?id=115314
Reviewed by Darin Adler.
The initialization was surprisingly complex because of DEFINE_STATIC_LOCAL.
First, a new pointer was allocated on the heap with fast malloc (for RetainPtr).
Then a new NSMutableArray was allocated but immediately put on the autorelease pool.
Finally, that array was retained by the RetainPtr.
This patch changes the code to only leak the NSMutableArray memory. There
is no fastMalloc, nor any use of the autorelease pool.
* WebView/WebHTMLRepresentation.mm:
(createArrayWithStrings):
(createArrayByConcatenatingArrays):
(+[WebHTMLRepresentation supportedMIMETypes]):
(+[WebHTMLRepresentation supportedNonImageMIMETypes]):
(+[WebHTMLRepresentation supportedImageMIMETypes]):
(+[WebHTMLRepresentation unsupportedTextMIMETypes]):
Modified Paths
trunk/Source/WebKit/mac/ChangeLog
trunk/Source/WebKit/mac/WebView/WebHTMLRepresentation.mm
Diff
Modified: trunk/Source/WebKit/mac/ChangeLog (149452 => 149453)
--- trunk/Source/WebKit/mac/ChangeLog 2013-05-01 20:58:32 UTC (rev 149452)
+++ trunk/Source/WebKit/mac/ChangeLog 2013-05-01 21:02:13 UTC (rev 149453)
@@ -1,3 +1,26 @@
+2013-05-01 Benjamin Poulain
+
+Simplify WebHTMLRepresentation supportedMIMETypes methods
+https://bugs.webkit.org/show_bug.cgi?id=115314
+
+Reviewed by Darin Adler.
+
+The initialization was surprisingly complex because of DEFINE_STATIC_LOCAL.
+First, a new pointer was allocated on the heap with fast malloc (for RetainPtr).
+Then a new NSMutableArray was allocated but immediately put on the autorelease pool.
+Finally, that array was retained by the RetainPtr.
+
+This patch changes the code to only leak the NSMutableArray memory. There
+is no fastMalloc, nor any use of the autorelease pool.
+
+* WebView/WebHTMLRepresentation.mm:
+(createArrayWithStrings):
+(createArrayByConcatenatingArrays):
+(+[WebHTMLRepresentation supportedMIMETypes]):
+(+[WebHTMLRepresentation supportedNonImageMIMETypes]):
+(+[WebHTMLRepresentation supportedImageMIMETypes]):
+(+[WebHTMLRepresentation unsupportedTextMIMETypes]):
+
2013-04-30 Darin Adler
[Mac] Remove adoptNS/retain pairs, since the two cancel each other out
Modified: trunk/Source/WebKit/mac/WebView/WebHTMLRepresentation.mm (149452 => 149453)
--- trunk/Source/WebKit/mac/WebView/WebHTMLRepresentation.mm 2013-05-01 20:58:32 UTC (rev 149452)
+++ trunk/Source/WebKit/mac/WebView/WebHTMLRepresentation.mm 2013-05-01 21:02:13 UTC (rev 149453)
@@ -84,44 +84,46 @@
@implementation WebHTMLRepresentation
-static NSArray *stringArray(const HashSet& set)
+static NSMutableArray *createArrayWithStrings(const HashSet& set) NS_RETURNS_RETAINED;
+static NSMutableArray *createArrayWithStrings(const HashSet& set)
{
-NSMutableArray *array = [NSMutableArray arrayWithCapacity:set.size()];
+NSMutableArray *array = [[NSMutableArray alloc] initWithCapacity:set.size()];
HashSet::const_iterator end = set.end();
for (HashSet::const_iterator it = set.begin(); it != end; ++it)
[array addObject:(NSString *)(*it)];
return array;
}
-static NSArray *concatenateArrays(NSArray *first, NSArray *second)
+static NSMutableArray *createArrayByConcatenatingArrays(NSArray *first, NSArray *second) NS_RETURNS_RETAINED;
+static NSMutableArray *createArrayByConcatenatingArrays(NSArray *first, NSArray *second)
{
-NSMutableArray *result = [[first mutableCopy] autorelease];
+NSMutableArray *result = [first mutableCopy];
[result addObjectsFromArray:second];
return result;
}
+ (NSArray *)supportedMIMETypes
{
-DEFINE_STATIC_LOCAL(RetainPtr, staticSupportedMIMETypes, (concatenateArrays([self supportedNonImageMIMETypes], [self supportedImageMIMETypes])));
-return staticSupportedMIMETypes.get();
+static __unsafe_unretained NSArray *staticSupportedMIMETypes = createArrayByConcatenatingArrays([self supportedNonImageMIMETypes], [self supportedImageMIMETypes]);
+return staticSupportedMIMETypes;
}
+ (NSArray *)supportedNonImageMIMETypes
{
-DEFINE_STATIC_LOCAL(RetainPtr, staticSupportedNonImageMIMETypes, (stringArray(MIMETypeRegistry::getSupportedNonImageMIMETypes(;
-return staticSupportedNonImageMIMETypes.get();
+static __unsafe_unretained NSArray *staticSupportedNonImageMIMETypes = createArrayWithStrings(MIMETypeRegistry::getSupportedNonImageMIMETypes());
+return staticSupportedNonImageMIMETypes;
}
+ (NSArray *)supportedImageMIMETypes
{
-DEFINE_STATIC_LOCAL(RetainPtr, staticSupportedImageMIMETypes, (stringArray(MIMETypeRegistry::getSupportedImageMIMETypes(;
-return staticSupportedImageMIMETypes.get();
+static __unsafe_unreta
[webkit-changes] [149451] trunk
Title: [149451] trunk
Revision 149451
Author benja...@webkit.org
Date 2013-05-01 13:52:04 -0700 (Wed, 01 May 2013)
Log Message
Remove the remaining wscript
https://bugs.webkit.org/show_bug.cgi?id=115459
Reviewed by Andreas Kling.
.:
* wscript: Removed.
Source/_javascript_Core:
* wscript: Removed.
Modified Paths
trunk/ChangeLog
trunk/Source/_javascript_Core/ChangeLog
Removed Paths
trunk/Source/_javascript_Core/wscript
trunk/wscript
Diff
Modified: trunk/ChangeLog (149450 => 149451)
--- trunk/ChangeLog 2013-05-01 20:37:04 UTC (rev 149450)
+++ trunk/ChangeLog 2013-05-01 20:52:04 UTC (rev 149451)
@@ -1,3 +1,12 @@
+2013-05-01 Benjamin Poulain
+
+Remove the remaining wscript
+https://bugs.webkit.org/show_bug.cgi?id=115459
+
+Reviewed by Andreas Kling.
+
+* wscript: Removed.
+
2013-05-01 Sergio Villar Senin
Show a block cursor in overtype mode
Modified: trunk/Source/_javascript_Core/ChangeLog (149450 => 149451)
--- trunk/Source/_javascript_Core/ChangeLog 2013-05-01 20:37:04 UTC (rev 149450)
+++ trunk/Source/_javascript_Core/ChangeLog 2013-05-01 20:52:04 UTC (rev 149451)
@@ -1,3 +1,12 @@
+2013-05-01 Benjamin Poulain
+
+Remove the remaining wscript
+https://bugs.webkit.org/show_bug.cgi?id=115459
+
+Reviewed by Andreas Kling.
+
+* wscript: Removed.
+
2013-04-30 Mark Lam
JSContextGroupSetExecutionTimeLimit() should not pass a callback to the
Deleted: trunk/Source/_javascript_Core/wscript (149450 => 149451)
--- trunk/Source/_javascript_Core/wscript 2013-05-01 20:37:04 UTC (rev 149450)
+++ trunk/Source/_javascript_Core/wscript 2013-05-01 20:52:04 UTC (rev 149451)
@@ -1,90 +0,0 @@
-#! /usr/bin/env python
-
-# Copyright (C) 2009 Kevin Ollivier All rights reserved.
-#
-# Redistribution and use in source and binary forms, with or without
-# modification, are permitted provided that the following conditions
-# are met:
-# 1. Redistributions of source code must retain the above copyright
-#notice, this list of conditions and the following disclaimer.
-# 2. Redistributions in binary form must reproduce the above copyright
-#notice, this list of conditions and the following disclaimer in the
-#documentation and/or other materials provided with the distribution.
-#
-# THIS SOFTWARE IS PROVIDED BY APPLE COMPUTER, INC. ``AS IS'' AND ANY
-# EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
-# IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
-# PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE COMPUTER, INC. OR
-# CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL,
-# EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO,
-# PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR
-# PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY
-# OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
-# (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
-# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
-#
-# _javascript_Core build script for the waf build system
-
-import commands
-
-from settings import *
-
-def build(bld):
-
-import Options
-
-jscore_excludes = ['jsc.cpp', 'ExecutableAllocatorPosix.cpp', 'LLIntOffsetsExtractor.cpp', 'udis86_itab.c']
-jscore_exclude_patterns = get_port_excludes(Options.options.port)
-jscore_exclude_patterns.append('*None.cpp')
-
-sources = []
-
-if Options.options.port == "wx":
-if building_on_win32:
-jscore_excludes += ['OSAllocatorPosix.cpp', 'ThreadingPthreads.cpp']
-sources.extend(['../WTF/wtf/ThreadingWin.cpp', '../WTF/wtf/ThreadSpecificWin.cpp', '../WTF/wtf/OSAllocatorWin.cpp'])
-else:
-jscore_excludes.append('JSStringRefBSTR.cpp')
-
-bld.env.LIBDIR = output_dir
-full_dirs = get_dirs_for_features(jscore_dir, features=[Options.options.port.lower()], dirs=jscore_dirs)
-abs_dirs = []
-for adir in full_dirs:
-abs_dirs.append(os.path.join(jscore_dir, adir))
-
-jscore_excludes.extend(get_excludes_in_dirs(abs_dirs, jscore_exclude_patterns))
-
-includes = common_includes + full_dirs + [output_dir]
-if sys.platform.startswith('darwin'):
-includes.append(os.path.join(jscore_dir, 'icu'))
-
-# 1. A simple program
-jscore = bld.new_task_gen(
-features = 'cc cxx cshlib',
-includes = '. .. assembler ../WTF ' + ' '.join(includes),
-source = sources,
-defines = ['BUILDING_JavaScriptCore'],
-target = 'jscore',
-uselib = 'WX ICU ' + get_config(),
-uselib_local = '',
-install_path = output_dir)
-
-jscore.find_sources_in_dirs(full_dirs, excludes = jscore_excludes)
-
-obj = bld.new_task_gen(
-features = 'cxx cprogram',
-includes = '. .. assembler ../WTF ' + ' '.join(includes),
-source = 'jsc.cpp',
-target = 'jsc
[webkit-changes] [149450] trunk
Title: [149450] trunk
Revision 149450
Author enr...@apple.com
Date 2013-05-01 13:37:04 -0700 (Wed, 01 May 2013)
Log Message
Incorrect layout for blocks containing ideographs with -webkit-linebox-contain: glyphs, font, inline-box.
https://bugs.webkit.org/show_bug.cgi?id=115478.
Reviewed by Dave Hyatt.
Source/WebCore:
Test: fast/block/lineboxcontain/block-with-ideographs.xhtml
When computing ascent and descent we need to take into account
the baseline type. RootInlineBox::ascentAndDescentForBox failed
to do that in few cases.
* rendering/RootInlineBox.cpp:
(WebCore::RootInlineBox::ascentAndDescentForBox):
LayoutTests:
* fast/block/lineboxcontain/block-with-ideographs.xhtml: Added.
* platform/mac/fast/block/lineboxcontain/block-with-ideographs-expected.txt: Added.
* platform/mac/fast/block/lineboxcontain/block-with-ideographs-expected.png : Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RootInlineBox.cpp
Added Paths
trunk/LayoutTests/fast/block/lineboxcontain/block-with-ideographs.xhtml
trunk/LayoutTests/platform/mac/fast/block/lineboxcontain/block-with-ideographs-expected.png
trunk/LayoutTests/platform/mac/fast/block/lineboxcontain/block-with-ideographs-expected.txt
Diff
Modified: trunk/LayoutTests/ChangeLog (149449 => 149450)
--- trunk/LayoutTests/ChangeLog 2013-05-01 20:28:27 UTC (rev 149449)
+++ trunk/LayoutTests/ChangeLog 2013-05-01 20:37:04 UTC (rev 149450)
@@ -1,3 +1,14 @@
+2013-05-01 Enrica Casucci
+
+Incorrect layout for blocks containing ideographs with -webkit-linebox-contain: glyphs, font, inline-box.
+https://bugs.webkit.org/show_bug.cgi?id=115478.
+
+Reviewed by Dave Hyatt.
+
+* fast/block/lineboxcontain/block-with-ideographs.xhtml: Added.
+* platform/mac/fast/block/lineboxcontain/block-with-ideographs-expected.txt: Added.
+* platform/mac/fast/block/lineboxcontain/block-with-ideographs-expected.png : Added.
+
2013-05-01 Per-Erik Brodin
EventSource: Loss of reconnect time precision due to integer division
Added: trunk/LayoutTests/fast/block/lineboxcontain/block-with-ideographs.xhtml (0 => 149450)
--- trunk/LayoutTests/fast/block/lineboxcontain/block-with-ideographs.xhtml (rev 0)
+++ trunk/LayoutTests/fast/block/lineboxcontain/block-with-ideographs.xhtml 2013-05-01 20:37:04 UTC (rev 149450)
@@ -0,0 +1,16 @@
+
+
+
+為櫻田
+為櫻田
+
+
+為櫻田
+為櫻田
+
+
+為櫻田
+為櫻田
+
+
+
Added: trunk/LayoutTests/platform/mac/fast/block/lineboxcontain/block-with-ideographs-expected.png
(Binary files differ)
Property changes on: trunk/LayoutTests/platform/mac/fast/block/lineboxcontain/block-with-ideographs-expected.png
___
Added: svn:mime-type
Added: trunk/LayoutTests/platform/mac/fast/block/lineboxcontain/block-with-ideographs-expected.txt (0 => 149450)
--- trunk/LayoutTests/platform/mac/fast/block/lineboxcontain/block-with-ideographs-expected.txt (rev 0)
+++ trunk/LayoutTests/platform/mac/fast/block/lineboxcontain/block-with-ideographs-expected.txt 2013-05-01 20:37:04 UTC (rev 149450)
@@ -0,0 +1,68 @@
+layer at (0,0) size 785x625
+ RenderView at (0,0) size 785x600
+layer at (0,0) size 785x625
+ RenderBlock {html} at (0,0) size 785x625
+RenderBody {body} at (8,8) size 769x609
+ RenderBlock {div} at (0,0) size 769x203
+RenderBlock {div} at (0,0) size 57x146 [border: (1px solid #FF)]
+ RenderText {#text} at (1,1) size 55x48
+text run at (1,1) width 48: "\x{70BA}"
+ RenderRuby (inline) {ruby} at (0,0) size 55x48
+RenderRubyRun (anonymous) at (1,49) size 55x48
+ RenderRubyBase (anonymous) at (0,0) size 55x48
+RenderText {#text} at (0,0) size 55x48
+ text run at (0,0) width 48: "\x{6AFB}"
+ RenderText {#text} at (1,97) size 55x48
+text run at (1,97) width 48: "\x{7530}"
+RenderBlock {div} at (0,146) size 769x57 [border: (1px solid #008000)]
+ RenderText {#text} at (1,1) size 48x55
+text run at (1,1) width 48: "\x{70BA}"
+ RenderRuby (inline) {ruby} at (0,0) size 48x55
+RenderRubyRun (anonymous) at (49,1) size 48x55
+ RenderRubyBase (anonymous) at (0,0) size 48x55
+RenderText {#text} at (0,0) size 48x55
+ text run at (0,0) width 48: "\x{6AFB}"
+ RenderText {#text} at (97,1) size 48x55
+text run at (97,1) width 48: "\x{7530}"
+ RenderBlock {div} at (0,203) size 769x203
+RenderBlock {div} at (0,0) size 57x146 [border: (1px solid #FF)]
+ RenderText {#text} at (1,1) size 55x48
+text run at (1,1) width 48: "\x{70BA}"
+ RenderRuby (inline) {ruby} at (
[webkit-changes] [149449] trunk/Source
Title: [149449] trunk/Source Revision 149449 Author ander...@apple.com Date 2013-05-01 13:28:27 -0700 (Wed, 01 May 2013) Log Message Add LocalStorageDatabase class https://bugs.webkit.org/show_bug.cgi?id=115486 Reviewed by Sam Weinig. Source/WebCore: Export symbols needed by WebKit2. * WebCore.exp.in: Source/WebKit2: The LocalStorageDatabase class will persist local storage data to disk. * UIProcess/Storage/LocalStorageDatabase.cpp: * UIProcess/Storage/LocalStorageDatabase.h: Added. * UIProcess/Storage/StorageManager.cpp: (StorageManager::StorageArea): (WebKit::StorageManager::LocalStorageNamespace::storageManager): Add getter. (StorageManager::LocalStorageNamespace): (WebKit::StorageManager::StorageArea::StorageArea): If this is a local storage area, create a LocalStorageDatabase. (WebKit::StorageManager::LocalStorageNamespace::databaseFilename): Helper function for getting the name of the database for the given origin. * WebKit2.xcodeproj/project.pbxproj: Add new files. Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/WebCore.exp.in trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/UIProcess/Storage/StorageManager.cpp trunk/Source/WebKit2/WebKit2.xcodeproj/project.pbxproj Added Paths trunk/Source/WebKit2/UIProcess/Storage/LocalStorageDatabase.cpp trunk/Source/WebKit2/UIProcess/Storage/LocalStorageDatabase.h Diff Modified: trunk/Source/WebCore/ChangeLog (149448 => 149449) --- trunk/Source/WebCore/ChangeLog 2013-05-01 19:57:31 UTC (rev 149448) +++ trunk/Source/WebCore/ChangeLog 2013-05-01 20:28:27 UTC (rev 149449) @@ -1,3 +1,14 @@ +2013-05-01 Anders Carlsson + +Add LocalStorageDatabase class +https://bugs.webkit.org/show_bug.cgi?id=115486 + +Reviewed by Sam Weinig. + +Export symbols needed by WebKit2. + +* WebCore.exp.in: + 2013-05-01 Eric Carlson [Mac Lion] Assertion failure in MediaControlTextTrackContainerElement::updateDisplay() Modified: trunk/Source/WebCore/WebCore.exp.in (149448 => 149449) --- trunk/Source/WebCore/WebCore.exp.in 2013-05-01 19:57:31 UTC (rev 149448) +++ trunk/Source/WebCore/WebCore.exp.in 2013-05-01 20:28:27 UTC (rev 149449) @@ -570,6 +570,7 @@ __ZN7WebCore17cacheDOMStructureEPNS_17JSDOMGlobalObjectEPN3JSC9StructureEPKNS2_9ClassInfoE __ZN7WebCore17openTemporaryFileERKN3WTF6StringERi __ZN7WebCore17userVisibleStringEP5NSURL +__ZN7WebCore18makeAllDirectoriesERKN3WTF6StringE __ZN7WebCore18DOMWindowExtensionC1EPNS_5FrameEPNS_15DOMWrapperWorldE __ZN7WebCore10Pasteboard17generalPasteboardEv __ZN7WebCore10Pasteboard14writePlainTextERKN3WTF6StringENS0_18SmartReplaceOptionE @@ -752,6 +753,7 @@ __ZN7WebCore24deleteCookiesForHostnameERKNS_21NetworkStorageSessionERKN3WTF6StringE __ZN7WebCore24fileSystemRepresentationERKN3WTF6StringE __ZN7WebCore24notifyHistoryItemChangedE +__ZN7WebCore24pathByAppendingComponentERKN3WTF6StringES3_ __ZN7WebCore25HistoryPropertyListWriter11releaseDataEv __ZN7WebCore25HistoryPropertyListWriter12writeObjectsERNS_30BinaryPropertyListObjectStreamE __ZN7WebCore25HistoryPropertyListWriter16writeHistoryItemERNS_30BinaryPropertyListObjectStreamEPNS_11HistoryItemE Modified: trunk/Source/WebKit2/ChangeLog (149448 => 149449) --- trunk/Source/WebKit2/ChangeLog 2013-05-01 19:57:31 UTC (rev 149448) +++ trunk/Source/WebKit2/ChangeLog 2013-05-01 20:28:27 UTC (rev 149449) @@ -1,3 +1,30 @@ +2013-05-01 Anders Carlsson + +Add LocalStorageDatabase class +https://bugs.webkit.org/show_bug.cgi?id=115486 + +Reviewed by Sam Weinig. + +The LocalStorageDatabase class will persist local storage data to disk. + +* UIProcess/Storage/LocalStorageDatabase.cpp: +* UIProcess/Storage/LocalStorageDatabase.h: Added. + +* UIProcess/Storage/StorageManager.cpp: +(StorageManager::StorageArea): +(WebKit::StorageManager::LocalStorageNamespace::storageManager): +Add getter. + +(StorageManager::LocalStorageNamespace): +(WebKit::StorageManager::StorageArea::StorageArea): +If this is a local storage area, create a LocalStorageDatabase. + +(WebKit::StorageManager::LocalStorageNamespace::databaseFilename): +Helper function for getting the name of the database for the given origin. + +* WebKit2.xcodeproj/project.pbxproj: +Add new files. + 2013-05-01 Alexey Proskuryakov Launching NetworkProcess broken on some OS versions. Added: trunk/Source/WebKit2/UIProcess/Storage/LocalStorageDatabase.cpp (0 => 149449) --- trunk/Source/WebKit2/UIProcess/Storage/LocalStorageDatabase.cpp (rev 0) +++ trunk/Source/WebKit2/UIProcess/Storage/LocalStorageDatabase.cpp 2013-05-01 20:28:27 UTC (rev 149449) @@ -0,0 +1,57 @@ +/* + * Copyright (C) 2013 Apple Inc. All rights reserved. + * + * Redistribution and use in source and binary forms, with or without + * modification, are permitted provided that the following conditions + * are met:
[webkit-changes] [149448] trunk/Source/WebCore
Title: [149448] trunk/Source/WebCore
Revision 149448
Author eric.carl...@apple.com
Date 2013-05-01 12:57:31 -0700 (Wed, 01 May 2013)
Log Message
[Mac Lion] Assertion failure in MediaControlTextTrackContainerElement::updateDisplay()
https://bugs.webkit.org/show_bug.cgi?id=115289
Reviewed by Jer Noble.
No new tests, this is a speculative fix for an infrequent assertion.
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::textTrackRemoveCue): Mark the cue as inactive when it is removed
from the active set.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/HTMLMediaElement.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (149447 => 149448)
--- trunk/Source/WebCore/ChangeLog 2013-05-01 19:55:31 UTC (rev 149447)
+++ trunk/Source/WebCore/ChangeLog 2013-05-01 19:57:31 UTC (rev 149448)
@@ -1,3 +1,16 @@
+2013-05-01 Eric Carlson
+
+[Mac Lion] Assertion failure in MediaControlTextTrackContainerElement::updateDisplay()
+https://bugs.webkit.org/show_bug.cgi?id=115289
+
+Reviewed by Jer Noble.
+
+No new tests, this is a speculative fix for an infrequent assertion.
+
+* html/HTMLMediaElement.cpp:
+(WebCore::HTMLMediaElement::textTrackRemoveCue): Mark the cue as inactive when it is removed
+from the active set.
+
2013-05-01 Joseph Pecoraro
TextTrackMenu crashes in ports where MediaElement players are lazily created
Modified: trunk/Source/WebCore/html/HTMLMediaElement.cpp (149447 => 149448)
--- trunk/Source/WebCore/html/HTMLMediaElement.cpp 2013-05-01 19:55:31 UTC (rev 149447)
+++ trunk/Source/WebCore/html/HTMLMediaElement.cpp 2013-05-01 19:57:31 UTC (rev 149448)
@@ -1471,8 +1471,10 @@
m_cueTree.remove(interval);
size_t index = m_currentlyActiveCues.find(interval);
-if (index != notFound)
+if (index != notFound) {
+cue->setIsActive(false);
m_currentlyActiveCues.remove(index);
+}
cue->removeDisplayTree();
updateActiveTextTrackCues(currentTime());
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [149447] trunk/Source/WebCore
Title: [149447] trunk/Source/WebCore Revision 149447 Author commit-qu...@webkit.org Date 2013-05-01 12:55:31 -0700 (Wed, 01 May 2013) Log Message TextTrackMenu crashes in ports where MediaElement players are lazily created https://bugs.webkit.org/show_bug.cgi?id=115485 Null check the player for ports, like iOS, that lazily create the player. Patch by Joseph Pecoraro on 2013-05-01 Reviewed by Eric Carlson. * html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::platformTextTrackMenu): (WebCore::HTMLMediaElement::closeCaptionTracksChanged): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/html/HTMLMediaElement.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (149446 => 149447) --- trunk/Source/WebCore/ChangeLog 2013-05-01 19:10:35 UTC (rev 149446) +++ trunk/Source/WebCore/ChangeLog 2013-05-01 19:55:31 UTC (rev 149447) @@ -1,3 +1,16 @@ +2013-05-01 Joseph Pecoraro + +TextTrackMenu crashes in ports where MediaElement players are lazily created +https://bugs.webkit.org/show_bug.cgi?id=115485 + +Null check the player for ports, like iOS, that lazily create the player. + +Reviewed by Eric Carlson. + +* html/HTMLMediaElement.cpp: +(WebCore::HTMLMediaElement::platformTextTrackMenu): +(WebCore::HTMLMediaElement::closeCaptionTracksChanged): + 2013-05-01 Anders Carlsson Add FunctionDispatcher class and make RunLoop derive from it Modified: trunk/Source/WebCore/html/HTMLMediaElement.cpp (149446 => 149447) --- trunk/Source/WebCore/html/HTMLMediaElement.cpp 2013-05-01 19:10:35 UTC (rev 149446) +++ trunk/Source/WebCore/html/HTMLMediaElement.cpp 2013-05-01 19:55:31 UTC (rev 149447) @@ -2938,7 +2938,7 @@ if (m_platformMenu) return m_platformMenu.get(); -if (!m_player->implementsTextTrackControls()) +if (!m_player || !m_player->implementsTextTrackControls()) return 0; m_platformMenu = m_player->textTrackMenu(); @@ -2957,7 +2957,7 @@ mediaControls()->closedCaptionTracksChanged(); #if USE(PLATFORM_TEXT_TRACK_MENU) -if (m_player->implementsTextTrackControls()) +if (m_player && m_player->implementsTextTrackControls()) scheduleDelayedAction(TextTrackChangesNotification); #endif } ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [149446] trunk/Tools
Title: [149446] trunk/Tools Revision 149446 Author zandober...@gmail.com Date 2013-05-01 12:10:35 -0700 (Wed, 01 May 2013) Log Message [TestWebKitAPI] being included in GTK WK1-only builds https://bugs.webkit.org/show_bug.cgi?id=115470 Reviewed by Martin Robinson. In the TestWebKitAPI's config.h header, only include the header when not building either of the IOS, Windows or GTK-WK1 platforms. Up until now the header was included for everything but the IOS and Windows platforms due to an incorrectly stated condition regarding the GTK platform. * TestWebKitAPI/config.h: Modified Paths trunk/Tools/ChangeLog trunk/Tools/TestWebKitAPI/config.h Diff Modified: trunk/Tools/ChangeLog (149445 => 149446) --- trunk/Tools/ChangeLog 2013-05-01 19:09:32 UTC (rev 149445) +++ trunk/Tools/ChangeLog 2013-05-01 19:10:35 UTC (rev 149446) @@ -1,5 +1,20 @@ 2013-05-01 Zan Dobersek +[TestWebKitAPI] being included in GTK WK1-only builds +https://bugs.webkit.org/show_bug.cgi?id=115470 + +Reviewed by Martin Robinson. + +In the TestWebKitAPI's config.h header, only include the header when +not building either of the IOS, Windows or GTK-WK1 platforms. + +Up until now the header was included for everything but the IOS and Windows platforms due to +an incorrectly stated condition regarding the GTK platform. + +* TestWebKitAPI/config.h: + +2013-05-01 Zan Dobersek + [GTK] Split the forwarding headers stamp in the TestWebKitAPI GNUmakefile.am https://bugs.webkit.org/show_bug.cgi?id=115469 Modified: trunk/Tools/TestWebKitAPI/config.h (149445 => 149446) --- trunk/Tools/TestWebKitAPI/config.h 2013-05-01 19:09:32 UTC (rev 149445) +++ trunk/Tools/TestWebKitAPI/config.h 2013-05-01 19:10:35 UTC (rev 149446) @@ -68,7 +68,7 @@ #include -#if !PLATFORM(IOS) && (!PLATFORM(WIN) || (PLATFORM(GTK) && defined(BUILDING_WEBKIT2__))) +#if !PLATFORM(IOS) && !PLATFORM(WIN) && !(PLATFORM(GTK) && !defined(BUILDING_WEBKIT2__)) #include #endif ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [149445] trunk/Tools
Title: [149445] trunk/Tools Revision 149445 Author zandober...@gmail.com Date 2013-05-01 12:09:32 -0700 (Wed, 01 May 2013) Log Message [GTK] Split the forwarding headers stamp in the TestWebKitAPI GNUmakefile.am https://bugs.webkit.org/show_bug.cgi?id=115469 Reviewed by Martin Robinson. Split the stamp-testwebkitapi-forwarding-headers into two stamps, one covering forwarding headers for the WebCore tests (under the Tests/WebCore directory) and the other covering forwarding headers for the WebKit2 tests and the injected bundle required by them. This makes it possible for the WebCore tests to compile when the WebKit2 build is disabled, i.e. the WebCore tests shouldn't depend on the WebKit2 build (though the forwarding headers generation script is stored under the WebKit2 code). The WebCore forwarding headers are generated by scanning only the files under the Tests/WebCore directory, while the WebKit2 forwarding headers generation should keep on scanning the complete root directory of the TestWebKitAPI subproject, though the target directory should be narrowed down if at all possible. * TestWebKitAPI/GNUmakefile.am: Modified Paths trunk/Tools/ChangeLog trunk/Tools/TestWebKitAPI/GNUmakefile.am Diff Modified: trunk/Tools/ChangeLog (149444 => 149445) --- trunk/Tools/ChangeLog 2013-05-01 18:59:21 UTC (rev 149444) +++ trunk/Tools/ChangeLog 2013-05-01 19:09:32 UTC (rev 149445) @@ -1,3 +1,24 @@ +2013-05-01 Zan Dobersek + +[GTK] Split the forwarding headers stamp in the TestWebKitAPI GNUmakefile.am +https://bugs.webkit.org/show_bug.cgi?id=115469 + +Reviewed by Martin Robinson. + +Split the stamp-testwebkitapi-forwarding-headers into two stamps, one covering forwarding headers +for the WebCore tests (under the Tests/WebCore directory) and the other covering forwarding headers +for the WebKit2 tests and the injected bundle required by them. + +This makes it possible for the WebCore tests to compile when the WebKit2 build is disabled, i.e. the WebCore +tests shouldn't depend on the WebKit2 build (though the forwarding headers generation script is stored +under the WebKit2 code). + +The WebCore forwarding headers are generated by scanning only the files under the Tests/WebCore directory, +while the WebKit2 forwarding headers generation should keep on scanning the complete root directory of the +TestWebKitAPI subproject, though the target directory should be narrowed down if at all possible. + +* TestWebKitAPI/GNUmakefile.am: + 2013-04-30 Glenn Adams Unreviewed. Add myself to watchlist entries. Modified: trunk/Tools/TestWebKitAPI/GNUmakefile.am (149444 => 149445) --- trunk/Tools/TestWebKitAPI/GNUmakefile.am 2013-05-01 18:59:21 UTC (rev 149444) +++ trunk/Tools/TestWebKitAPI/GNUmakefile.am 2013-05-01 19:09:32 UTC (rev 149445) @@ -14,6 +14,7 @@ -isystem $(srcdir)/Source/ThirdParty/gtest/include \ -I$(srcdir)/Tools/TestWebKitAPI \ -I$(srcdir)/Source/ThirdParty/gtest/include \ + -I$(top_builddir)/DerivedSources/WebCore/include \ -I$(top_builddir)/DerivedSources/WebKit2/include \ $(global_cppflags) \ $(_javascript_core_cppflags) \ @@ -249,14 +250,21 @@ Libraries_libTestWebKitAPIInjectedBundle_la_CFLAGS = \ $(global_cflags) -stamp-testwebkitapi-forwarding-headers: $(WebKit2)/Scripts/generate-forwarding-headers.pl $(Programs_TestWebKitAPI_TestWebKit2_SOURCES) $(Libraries_libTestWebKitAPIInjectedBundle_la_SOURCES) + +stamp-testwebkitapi-webcore-forwarding-headers: $(WebKit2)/Scripts/generate-forwarding-headers.pl $(Programs_TestWebKitAPI_TestWebCore_SOURCES) + $(AM_V_GEN)$(PERL) $< $(srcdir)/Tools/TestWebKitAPI/Tests/WebCore $(GENSOURCES_WEBCORE)/include gtk \ + && echo timestamp > $(@F) + +stamp-testwebkitapi-webkit2-forwarding-headers: $(WebKit2)/Scripts/generate-forwarding-headers.pl $(Programs_TestWebKitAPI_TestWebKit2_SOURCES) $(Libraries_libTestWebKitAPIInjectedBundle_la_SOURCES) $(AM_V_GEN)$(PERL) $< $(srcdir)/Tools/TestWebKitAPI $(GENSOURCES_WEBKIT2)/include gtk \ && echo timestamp > $(@F) +BUILT_SOURCES += $(top_builddir)/stamp-testwebkitapi-webcore-forwarding-headers if ENABLE_WEBKIT2 -BUILT_SOURCES += $(top_builddir)/stamp-testwebkitapi-forwarding-headers +BUILT_SOURCES += $(top_builddir)/stamp-testwebkitapi-webkit2-forwarding-headers endif # ENABLE_WEBKIT2 + EXTRA_DIST += \ Tools/TestWebKitAPI/Tests/WebKit2/18-characters.html \ Tools/TestWebKitAPI/Tests/WebKit2/file-with-anchor.html \ ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [149444] trunk/Source
Title: [149444] trunk/Source
Revision 149444
Author ander...@apple.com
Date 2013-05-01 11:59:21 -0700 (Wed, 01 May 2013)
Log Message
Add FunctionDispatcher class and make RunLoop derive from it
https://bugs.webkit.org/show_bug.cgi?id=115480
Reviewed by Sam Weinig.
Source/WebCore:
Change RunLoop to be a subclass of FunctionDispatcher.
* platform/RunLoop.h:
(RunLoop):
Source/WTF:
Add FunctionDispatcher files.
* WTF.pro:
* WTF.vcproj/WTF.vcproj:
* WTF.vcxproj/WTF.vcxproj:
* WTF.xcodeproj/project.pbxproj:
* wtf/FunctionDispatcher.cpp: Added.
(WTF::FunctionDispatcher::FunctionDispatcher):
(WTF::FunctionDispatcher::~FunctionDispatcher):
* wtf/FunctionDispatcher.h: Added.
Modified Paths
trunk/Source/WTF/ChangeLog
trunk/Source/WTF/GNUmakefile.list.am
trunk/Source/WTF/WTF.pro
trunk/Source/WTF/WTF.vcproj/WTF.vcproj
trunk/Source/WTF/WTF.vcxproj/WTF.vcxproj
trunk/Source/WTF/WTF.xcodeproj/project.pbxproj
trunk/Source/WTF/wtf/CMakeLists.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/RunLoop.h
Added Paths
trunk/Source/WTF/wtf/FunctionDispatcher.cpp
trunk/Source/WTF/wtf/FunctionDispatcher.h
Diff
Modified: trunk/Source/WTF/ChangeLog (149443 => 149444)
--- trunk/Source/WTF/ChangeLog 2013-05-01 18:55:32 UTC (rev 149443)
+++ trunk/Source/WTF/ChangeLog 2013-05-01 18:59:21 UTC (rev 149444)
@@ -1,3 +1,21 @@
+2013-05-01 Anders Carlsson
+
+Add FunctionDispatcher class and make RunLoop derive from it
+https://bugs.webkit.org/show_bug.cgi?id=115480
+
+Reviewed by Sam Weinig.
+
+Add FunctionDispatcher files.
+
+* WTF.pro:
+* WTF.vcproj/WTF.vcproj:
+* WTF.vcxproj/WTF.vcxproj:
+* WTF.xcodeproj/project.pbxproj:
+* wtf/FunctionDispatcher.cpp: Added.
+(WTF::FunctionDispatcher::FunctionDispatcher):
+(WTF::FunctionDispatcher::~FunctionDispatcher):
+* wtf/FunctionDispatcher.h: Added.
+
2013-05-01 Zoltan Arvai
[Qt][Win] Fix build after r149416.
Modified: trunk/Source/WTF/GNUmakefile.list.am (149443 => 149444)
--- trunk/Source/WTF/GNUmakefile.list.am 2013-05-01 18:55:32 UTC (rev 149443)
+++ trunk/Source/WTF/GNUmakefile.list.am 2013-05-01 18:59:21 UTC (rev 149444)
@@ -58,6 +58,8 @@
Source/WTF/wtf/Float32Array.h \
Source/WTF/wtf/Float64Array.h \
Source/WTF/wtf/Forward.h \
+Source/WTF/wtf/FunctionDispatcher.cpp \
+Source/WTF/wtf/FunctionDispatcher.h \
Source/WTF/wtf/Functional.h \
Source/WTF/wtf/GetPtr.h \
Source/WTF/wtf/GregorianDateTime.cpp \
Modified: trunk/Source/WTF/WTF.pro (149443 => 149444)
--- trunk/Source/WTF/WTF.pro 2013-05-01 18:55:32 UTC (rev 149443)
+++ trunk/Source/WTF/WTF.pro 2013-05-01 18:59:21 UTC (rev 149444)
@@ -68,6 +68,7 @@
Float32Array.h \
Float64Array.h \
Forward.h \
+FunctionDispatcher.h \
Functional.h \
GetPtr.h \
GregorianDateTime.h \
@@ -207,6 +208,7 @@
dtoa/strtod.cc \
FastMalloc.cpp \
FilePrintStream.cpp \
+FunctionDispatcher.cpp \
GregorianDateTime.cpp \
gobject/GOwnPtr.cpp \
gobject/GRefPtr.cpp \
Modified: trunk/Source/WTF/WTF.vcproj/WTF.vcproj (149443 => 149444)
--- trunk/Source/WTF/WTF.vcproj/WTF.vcproj 2013-05-01 18:55:32 UTC (rev 149443)
+++ trunk/Source/WTF/WTF.vcproj/WTF.vcproj 2013-05-01 18:59:21 UTC (rev 149444)
@@ -819,6 +819,14 @@
>
+ RelativePath="..\wtf\FunctionDispatcher.cpp"
+ >
+
+
+
+ RelativePath="..\wtf\Functional.h"
>
Modified: trunk/Source/WTF/WTF.vcxproj/WTF.vcxproj (149443 => 149444)
--- trunk/Source/WTF/WTF.vcxproj/WTF.vcxproj 2013-05-01 18:55:32 UTC (rev 149443)
+++ trunk/Source/WTF/WTF.vcxproj/WTF.vcxproj 2013-05-01 18:59:21 UTC (rev 149444)
@@ -48,6 +48,7 @@
+
@@ -143,6 +144,7 @@
+
Modified: trunk/Source/WTF/WTF.xcodeproj/project.pbxproj (149443 => 149444)
--- trunk/Source/WTF/WTF.xcodeproj/project.pbxproj 2013-05-01 18:55:32 UTC (rev 149443)
+++ trunk/Source/WTF/WTF.xcodeproj/project.pbxproj 2013-05-01 18:59:21 UTC (rev 149444)
@@ -42,6 +42,8 @@
1469419D16EAB10A0024E146 /* AutodrainedPoolMac.mm in Sources */ = {isa = PBXBuildFile; fileRef = 1469419B16EAB10A0024E146 /* AutodrainedPoolMac.mm */; };
149EF16316BBFE0D000A4331 /* TriState.h in Headers */ = {isa = PBXBuildFile; fileRef = 149EF16216BBFE0D000A4331 /* TriState.h */; settings = {ATTRIBUTES = (); }; };
14F3B0F715E45E4600210069 /* SaturatedArithmetic.h in Headers */ = {isa = PBXBuildFile; fileRef = 14F3B0F615E45E4600210069 /* SaturatedArithmetic.h */; settings = {ATTRIBUTES = (); }; };
+ 1A1D8B9C173186CE00141DA4 /* FunctionDispatcher.h in Headers */ = {isa = PBXBuildFile; fileRef = 1A1D8B9B173186CE00141DA4 /* FunctionDispatcher.h */; };
+ 1A1D8B9E1731879800141DA4 /* FunctionDispatcher.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 1A1D8B9D1731879800141DA4 /* FunctionDispatcher.cpp */; };
1A6BB769162F300500DD16DB /* StreamBuffer.h
[webkit-changes] [149443] trunk/Source/WebCore
Title: [149443] trunk/Source/WebCore
Revision 149443
Author eric.carl...@apple.com
Date 2013-05-01 11:55:32 -0700 (Wed, 01 May 2013)
Log Message
HTMLMediaElement::updateActiveTextTrackCues can do unnecessary work
https://bugs.webkit.org/show_bug.cgi?id=81856
Reviewed by Jer Noble.
No new tests, covered by existing tests.
* html/HTMLMediaElement.h:
(WebCore::HTMLMediaElement::ignoreTrackDisplayUpdateRequests): Add an early return when there
is obviously no work to be done.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/HTMLMediaElement.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (149442 => 149443)
--- trunk/Source/WebCore/ChangeLog 2013-05-01 18:26:51 UTC (rev 149442)
+++ trunk/Source/WebCore/ChangeLog 2013-05-01 18:55:32 UTC (rev 149443)
@@ -1,3 +1,16 @@
+2013-05-01 Eric Carlson
+
+HTMLMediaElement::updateActiveTextTrackCues can do unnecessary work
+https://bugs.webkit.org/show_bug.cgi?id=81856
+
+Reviewed by Jer Noble.
+
+No new tests, covered by existing tests.
+
+* html/HTMLMediaElement.h:
+(WebCore::HTMLMediaElement::ignoreTrackDisplayUpdateRequests): Add an early return when there
+is obviously no work to be done.
+
2013-04-30 Jer Noble
Closed caption lines overlap
Modified: trunk/Source/WebCore/html/HTMLMediaElement.h (149442 => 149443)
--- trunk/Source/WebCore/html/HTMLMediaElement.h 2013-05-01 18:26:51 UTC (rev 149442)
+++ trunk/Source/WebCore/html/HTMLMediaElement.h 2013-05-01 18:55:32 UTC (rev 149443)
@@ -415,7 +415,7 @@
void removeBehaviorRestriction(BehaviorRestrictions restriction) { m_restrictions &= ~restriction; }
#if ENABLE(VIDEO_TRACK)
-bool ignoreTrackDisplayUpdateRequests() const { return m_ignoreTrackDisplayUpdate > 0; }
+bool ignoreTrackDisplayUpdateRequests() const { return m_ignoreTrackDisplayUpdate > 0 || !m_textTracks || !m_cueTree.size(); }
void beginIgnoringTrackDisplayUpdateRequests();
void endIgnoringTrackDisplayUpdateRequests();
#endif
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [149442] trunk/WebKitLibraries
Title: [149442] trunk/WebKitLibraries Revision 149442 Author a...@apple.com Date 2013-05-01 11:26:51 -0700 (Wed, 01 May 2013) Log Message Update WebKitSystemInterface. * WebKitSystemInterface.h: * libWebKitSystemInterfaceLion.a: * libWebKitSystemInterfaceMountainLion.a: Modified Paths trunk/WebKitLibraries/ChangeLog trunk/WebKitLibraries/WebKitSystemInterface.h trunk/WebKitLibraries/libWebKitSystemInterfaceLion.a trunk/WebKitLibraries/libWebKitSystemInterfaceMountainLion.a Diff Modified: trunk/WebKitLibraries/ChangeLog (149441 => 149442) --- trunk/WebKitLibraries/ChangeLog 2013-05-01 18:14:59 UTC (rev 149441) +++ trunk/WebKitLibraries/ChangeLog 2013-05-01 18:26:51 UTC (rev 149442) @@ -1,3 +1,11 @@ +2013-05-01 Alexey Proskuryakov + +Update WebKitSystemInterface. + +* WebKitSystemInterface.h: +* libWebKitSystemInterfaceLion.a: +* libWebKitSystemInterfaceMountainLion.a: + 2013-04-29 Chris Fleizach WEB SPEECH: need to identify the default voice per language Modified: trunk/WebKitLibraries/WebKitSystemInterface.h (149441 => 149442) --- trunk/WebKitLibraries/WebKitSystemInterface.h 2013-05-01 18:14:59 UTC (rev 149441) +++ trunk/WebKitLibraries/WebKitSystemInterface.h 2013-05-01 18:26:51 UTC (rev 149442) @@ -261,6 +261,7 @@ void WKCFURLRequestSetHTTPRequestBodyParts(CFMutableURLRequestRef, CFArrayRef bodyParts); void WKSetVisibleApplicationName(CFStringRef); +void WKSetApplicationInformationItem(CFStringRef key, CFTypeRef value); CFURLRef WKCopyBundleURLForExecutableURL(CFURLRef); @@ -494,7 +495,10 @@ bool WKUnregisterOcclusionNotificationHandler(WKOcclusionNotificationType, WKOcclusionNotificationHandler); bool WKEnableWindowOcclusionNotifications(NSInteger windowID, bool *outCurrentOcclusionState); +#pragma clang diagnostic push +#pragma clang diagnostic ignored "-Wdeprecated-declarations" extern const NSSystemBehaviors WKProcessSuppressionSystemBehaviors; +#pragma clang diagnostic pop #endif bool WKIsJavaPlugInActive(void); Modified: trunk/WebKitLibraries/libWebKitSystemInterfaceLion.a (Binary files differ) Modified: trunk/WebKitLibraries/libWebKitSystemInterfaceMountainLion.a (Binary files differ) ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [149441] trunk/Source/WebKit2
Title: [149441] trunk/Source/WebKit2
Revision 149441
Author a...@apple.com
Date 2013-05-01 11:14:59 -0700 (Wed, 01 May 2013)
Log Message
Launching NetworkProcess broken on some OS versions.
Reviewed by Anders Carlsson.
Adapt to LaunchServices changes.
* Shared/mac/ChildProcessMac.mm:
(WebKit::ChildProcess::setApplicationIsDaemon):
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/Shared/mac/ChildProcessMac.mm
Diff
Modified: trunk/Source/WebKit2/ChangeLog (149440 => 149441)
--- trunk/Source/WebKit2/ChangeLog 2013-05-01 18:10:59 UTC (rev 149440)
+++ trunk/Source/WebKit2/ChangeLog 2013-05-01 18:14:59 UTC (rev 149441)
@@ -1,3 +1,14 @@
+2013-05-01 Alexey Proskuryakov
+
+ Launching NetworkProcess broken on some OS versions.
+
+Reviewed by Anders Carlsson.
+
+Adapt to LaunchServices changes.
+
+* Shared/mac/ChildProcessMac.mm:
+(WebKit::ChildProcess::setApplicationIsDaemon):
+
2013-05-01 Martin Robinson
[GTK] [WebKit2] Add a setting to control whether or not accelerated 2D canvas is enabled
Modified: trunk/Source/WebKit2/Shared/mac/ChildProcessMac.mm (149440 => 149441)
--- trunk/Source/WebKit2/Shared/mac/ChildProcessMac.mm 2013-05-01 18:10:59 UTC (rev 149440)
+++ trunk/Source/WebKit2/Shared/mac/ChildProcessMac.mm 2013-05-01 18:14:59 UTC (rev 149441)
@@ -47,6 +47,12 @@
#endif
#endif
+#if __MAC_OS_X_VERSION_MIN_REQUIRED >= 1090
+typedef bool (^LSServerConnectionAllowedBlock) ( CFDictionaryRef optionsRef );
+extern "C" void _LSSetApplicationLaunchServicesServerConnectionStatus(uint64_t flags, LSServerConnectionAllowedBlock block);
+extern "C" CFDictionaryRef _LSApplicationCheckIn(int sessionID, CFDictionaryRef applicationInfo);
+#endif
+
extern "C" OSStatus SetApplicationIsDaemon(Boolean isDaemon);
using namespace WebCore;
@@ -85,6 +91,11 @@
{
OSStatus error = SetApplicationIsDaemon(true);
ASSERT_UNUSED(error, error == noErr);
+
+#if __MAC_OS_X_VERSION_MIN_REQUIRED >= 1090
+_LSSetApplicationLaunchServicesServerConnectionStatus(0, 0);
+RetainPtr unused = _LSApplicationCheckIn(-2, CFBundleGetInfoDictionary(CFBundleGetMainBundle()));
+#endif
}
void ChildProcess::platformInitialize()
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [149440] trunk/Source/WebKit2
Title: [149440] trunk/Source/WebKit2
Revision 149440
Author commit-qu...@webkit.org
Date 2013-05-01 11:10:59 -0700 (Wed, 01 May 2013)
Log Message
[GTK] [WebKit2] Add a setting to control whether or not accelerated 2D canvas is enabled
https://bugs.webkit.org/show_bug.cgi?id=114394
Patch by Martin Robinson on 2013-05-01
Reviewed by Anders Carlsson.
Add a setting to control accelerated 2D canvas, which determines whether
or not to consider rendering HTML canvas with hardware acceleration.
* UIProcess/API/gtk/WebKitSettings.cpp:
(webKitSettingsSetProperty): Added support for enable-accelerated-2d-canvas property.
(webKitSettingsGetProperty): Added support for enable-accelerated-2d-canvas property.
(webkit_settings_class_init): Added support for enable-accelerated-2d-canvas property.
(webkit_settings_get_enable_accelerated_2d_canvas): Added.
(webkit_settings_set_enable_accelerated_2d_canvas): Added.
* UIProcess/API/gtk/WebKitSettings.h: New methods.
* UIProcess/API/gtk/docs/webkit2gtk-sections.txt: Added new methods to the documentation.
* UIProcess/API/gtk/tests/TestWebKitSettings.cpp:
(testWebKitSettings): Added a simple test for the setting.
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/gtk/WebKitSettings.cpp
trunk/Source/WebKit2/UIProcess/API/gtk/WebKitSettings.h
trunk/Source/WebKit2/UIProcess/API/gtk/docs/webkit2gtk-sections.txt
trunk/Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitSettings.cpp
Diff
Modified: trunk/Source/WebKit2/ChangeLog (149439 => 149440)
--- trunk/Source/WebKit2/ChangeLog 2013-05-01 17:45:11 UTC (rev 149439)
+++ trunk/Source/WebKit2/ChangeLog 2013-05-01 18:10:59 UTC (rev 149440)
@@ -1,3 +1,24 @@
+2013-05-01 Martin Robinson
+
+[GTK] [WebKit2] Add a setting to control whether or not accelerated 2D canvas is enabled
+https://bugs.webkit.org/show_bug.cgi?id=114394
+
+Reviewed by Anders Carlsson.
+
+Add a setting to control accelerated 2D canvas, which determines whether
+or not to consider rendering HTML canvas with hardware acceleration.
+
+* UIProcess/API/gtk/WebKitSettings.cpp:
+(webKitSettingsSetProperty): Added support for enable-accelerated-2d-canvas property.
+(webKitSettingsGetProperty): Added support for enable-accelerated-2d-canvas property.
+(webkit_settings_class_init): Added support for enable-accelerated-2d-canvas property.
+(webkit_settings_get_enable_accelerated_2d_canvas): Added.
+(webkit_settings_set_enable_accelerated_2d_canvas): Added.
+* UIProcess/API/gtk/WebKitSettings.h: New methods.
+* UIProcess/API/gtk/docs/webkit2gtk-sections.txt: Added new methods to the documentation.
+* UIProcess/API/gtk/tests/TestWebKitSettings.cpp:
+(testWebKitSettings): Added a simple test for the setting.
+
2013-04-30 Jer Noble
Entering full screen mode shows desktop linen instead of WKView the first time.
Modified: trunk/Source/WebKit2/UIProcess/API/gtk/WebKitSettings.cpp (149439 => 149440)
--- trunk/Source/WebKit2/UIProcess/API/gtk/WebKitSettings.cpp 2013-05-01 17:45:11 UTC (rev 149439)
+++ trunk/Source/WebKit2/UIProcess/API/gtk/WebKitSettings.cpp 2013-05-01 18:10:59 UTC (rev 149440)
@@ -132,7 +132,8 @@
PROP_ENABLE_SITE_SPECIFIC_QUIRKS,
PROP_ENABLE_PAGE_CACHE,
PROP_USER_AGENT,
-PROP_ENABLE_SMOOTH_SCROLLING
+PROP_ENABLE_SMOOTH_SCROLLING,
+PROP_ENABLE_ACCELERATED_2D_CANVAS
};
static void webKitSettingsSetProperty(GObject* object, guint propId, const GValue* value, GParamSpec* paramSpec)
@@ -275,6 +276,9 @@
case PROP_ENABLE_SMOOTH_SCROLLING:
webkit_settings_set_enable_smooth_scrolling(settings, g_value_get_boolean(value));
break;
+case PROP_ENABLE_ACCELERATED_2D_CANVAS:
+webkit_settings_set_enable_accelerated_2d_canvas(settings, g_value_get_boolean(value));
+break;
default:
G_OBJECT_WARN_INVALID_PROPERTY_ID(object, propId, paramSpec);
break;
@@ -415,6 +419,9 @@
case PROP_ENABLE_SMOOTH_SCROLLING:
g_value_set_boolean(value, webkit_settings_get_enable_smooth_scrolling(settings));
break;
+case PROP_ENABLE_ACCELERATED_2D_CANVAS:
+g_value_set_boolean(value, webkit_settings_get_enable_accelerated_2d_canvas(settings));
+break;
default:
G_OBJECT_WARN_INVALID_PROPERTY_ID(object, propId, paramSpec);
break;
@@ -1071,6 +1078,24 @@
_("Whether to enable smooth scrolling"),
FALSE,
readWriteConstructParamFlags));
+
+/**
+ * WebKitSettings:enable-accelerated-2d-canvas:
+ *
+ * Enable or disable accelerated 2D canvas. Accelerated 2D canvas is only available
+ * if WebKitGTK+ was compiled with a version of Cairo including the unstable CairoGL API.
+ * When acce
[webkit-changes] [149439] trunk/Source/WebKit2
Title: [149439] trunk/Source/WebKit2
Revision 149439
Author jer.no...@apple.com
Date 2013-05-01 10:45:11 -0700 (Wed, 01 May 2013)
Log Message
Entering full screen mode shows desktop linen instead of WKView the first time.
https://bugs.webkit.org/show_bug.cgi?id=115433
Reviewed by Eric Carlson.
For certain types of windows created by subclasses of WKView, the window in question fails to paint
when created with a zero-size rect. Create the window with an initial size of the active screen frame
as that is the likely destination size.
* UIProcess/API/mac/WKView.mm:
(-[WKView createFullScreenWindow]):
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/mac/WKView.mm
Diff
Modified: trunk/Source/WebKit2/ChangeLog (149438 => 149439)
--- trunk/Source/WebKit2/ChangeLog 2013-05-01 17:38:56 UTC (rev 149438)
+++ trunk/Source/WebKit2/ChangeLog 2013-05-01 17:45:11 UTC (rev 149439)
@@ -1,3 +1,18 @@
+2013-04-30 Jer Noble
+
+Entering full screen mode shows desktop linen instead of WKView the first time.
+https://bugs.webkit.org/show_bug.cgi?id=115433
+
+
+Reviewed by Eric Carlson.
+
+For certain types of windows created by subclasses of WKView, the window in question fails to paint
+when created with a zero-size rect. Create the window with an initial size of the active screen frame
+as that is the likely destination size.
+
+* UIProcess/API/mac/WKView.mm:
+(-[WKView createFullScreenWindow]):
+
2013-05-01 Zoltan Arvai
[Qt][Win] Fix build after r149416.
Modified: trunk/Source/WebKit2/UIProcess/API/mac/WKView.mm (149438 => 149439)
--- trunk/Source/WebKit2/UIProcess/API/mac/WKView.mm 2013-05-01 17:38:56 UTC (rev 149438)
+++ trunk/Source/WebKit2/UIProcess/API/mac/WKView.mm 2013-05-01 17:45:11 UTC (rev 149439)
@@ -3394,7 +3394,7 @@
- (NSWindow*)createFullScreenWindow
{
#if ENABLE(FULLSCREEN_API)
-return [[[WebCoreFullScreenWindow alloc] initWithContentRect:NSZeroRect styleMask:NSBorderlessWindowMask backing:NSBackingStoreBuffered defer:NO] autorelease];
+return [[[WebCoreFullScreenWindow alloc] initWithContentRect:[[NSScreen mainScreen] frame] styleMask:NSBorderlessWindowMask backing:NSBackingStoreBuffered defer:NO] autorelease];
#else
return nil;
#endif
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [149438] trunk/Source/WebCore
Title: [149438] trunk/Source/WebCore
Revision 149438
Author jer.no...@apple.com
Date 2013-05-01 10:38:56 -0700 (Wed, 01 May 2013)
Log Message
Closed caption lines overlap
https://bugs.webkit.org/show_bug.cgi?id=115438
Reviewed by Eric Carlson.
Take the line-box padding into account when determining line hight by setting
the -webkit-line-box-contain property to include 'inline-box'.
* css/mediaControls.css:
(video::-webkit-media-text-track-container):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/mediaControls.css
Diff
Modified: trunk/Source/WebCore/ChangeLog (149437 => 149438)
--- trunk/Source/WebCore/ChangeLog 2013-05-01 17:29:18 UTC (rev 149437)
+++ trunk/Source/WebCore/ChangeLog 2013-05-01 17:38:56 UTC (rev 149438)
@@ -1,3 +1,17 @@
+2013-04-30 Jer Noble
+
+Closed caption lines overlap
+https://bugs.webkit.org/show_bug.cgi?id=115438
+
+
+Reviewed by Eric Carlson.
+
+Take the line-box padding into account when determining line hight by setting
+the -webkit-line-box-contain property to include 'inline-box'.
+
+* css/mediaControls.css:
+(video::-webkit-media-text-track-container):
+
2013-05-01 David Kilzer
BUILD FIX (r149410): CFRunLoopStop() doesn't know what to do with a RetainPtr
Modified: trunk/Source/WebCore/css/mediaControls.css (149437 => 149438)
--- trunk/Source/WebCore/css/mediaControls.css 2013-05-01 17:29:18 UTC (rev 149437)
+++ trunk/Source/WebCore/css/mediaControls.css 2013-05-01 17:38:56 UTC (rev 149438)
@@ -237,6 +237,8 @@
word-break: break-word;
-webkit-flex: 1 1;
+
+-webkit-line-box-contain: block inline-box replaced;
}
video::cue {
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [149437] trunk/Source/WebCore
Title: [149437] trunk/Source/WebCore
Revision 149437
Author ddkil...@apple.com
Date 2013-05-01 10:29:18 -0700 (Wed, 01 May 2013)
Log Message
BUILD FIX (r149410): CFRunLoopStop() doesn't know what to do with a RetainPtr
Fixes the following build failure:
WebCore/platform/cf/RunLoopCF.cpp:82:5: error: no matching function for call to 'CFRunLoopStop'
CFRunLoopStop(m_runLoop);
^
* platform/cf/RunLoopCF.cpp:
(WebCore::RunLoop::stop): Call RetainPtr::get().
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/cf/RunLoopCF.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (149436 => 149437)
--- trunk/Source/WebCore/ChangeLog 2013-05-01 17:15:46 UTC (rev 149436)
+++ trunk/Source/WebCore/ChangeLog 2013-05-01 17:29:18 UTC (rev 149437)
@@ -1,3 +1,16 @@
+2013-05-01 David Kilzer
+
+BUILD FIX (r149410): CFRunLoopStop() doesn't know what to do with a RetainPtr
+
+Fixes the following build failure:
+
+WebCore/platform/cf/RunLoopCF.cpp:82:5: error: no matching function for call to 'CFRunLoopStop'
+CFRunLoopStop(m_runLoop);
+^
+
+* platform/cf/RunLoopCF.cpp:
+(WebCore::RunLoop::stop): Call RetainPtr::get().
+
2013-05-01 Per-Erik Brodin
EventSource: Loss of reconnect time precision due to integer division
Modified: trunk/Source/WebCore/platform/cf/RunLoopCF.cpp (149436 => 149437)
--- trunk/Source/WebCore/platform/cf/RunLoopCF.cpp 2013-05-01 17:15:46 UTC (rev 149436)
+++ trunk/Source/WebCore/platform/cf/RunLoopCF.cpp 2013-05-01 17:29:18 UTC (rev 149437)
@@ -79,7 +79,7 @@
void RunLoop::stop()
{
ASSERT(m_runLoop == CFRunLoopGetCurrent());
-CFRunLoopStop(m_runLoop);
+CFRunLoopStop(m_runLoop.get());
}
#endif
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [149436] trunk
Title: [149436] trunk
Revision 149436
Author commit-qu...@webkit.org
Date 2013-05-01 10:15:46 -0700 (Wed, 01 May 2013)
Log Message
EventSource: Loss of reconnect time precision due to integer division
https://bugs.webkit.org/show_bug.cgi?id=115358
Source/WebCore:
Make sure precision is not lost when converting the reconnect time from milliseconds to seconds.
Patch by Per-Erik Brodin on 2013-05-01
Reviewed by Alexey Proskuryakov.
Test: http/tests/eventsource/eventsource-retry-precision.html
* page/EventSource.cpp:
(WebCore::EventSource::scheduleReconnect):
LayoutTests:
Patch by Per-Erik Brodin on 2013-05-01
Reviewed by Alexey Proskuryakov.
* http/tests/eventsource/eventsource-retry-precision-expected.txt: Added.
* http/tests/eventsource/eventsource-retry-precision.html: Added.
* http/tests/eventsource/resources/precise-retry.asis: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/EventSource.cpp
Added Paths
trunk/LayoutTests/http/tests/eventsource/eventsource-retry-precision-expected.txt
trunk/LayoutTests/http/tests/eventsource/eventsource-retry-precision.html
trunk/LayoutTests/http/tests/eventsource/resources/precise-retry.asis
Diff
Modified: trunk/LayoutTests/ChangeLog (149435 => 149436)
--- trunk/LayoutTests/ChangeLog 2013-05-01 16:55:59 UTC (rev 149435)
+++ trunk/LayoutTests/ChangeLog 2013-05-01 17:15:46 UTC (rev 149436)
@@ -1,3 +1,14 @@
+2013-05-01 Per-Erik Brodin
+
+EventSource: Loss of reconnect time precision due to integer division
+https://bugs.webkit.org/show_bug.cgi?id=115358
+
+Reviewed by Alexey Proskuryakov.
+
+* http/tests/eventsource/eventsource-retry-precision-expected.txt: Added.
+* http/tests/eventsource/eventsource-retry-precision.html: Added.
+* http/tests/eventsource/resources/precise-retry.asis: Added.
+
2013-05-01 Sergio Villar Senin
Show a block cursor in overtype mode
Added: trunk/LayoutTests/http/tests/eventsource/eventsource-retry-precision-expected.txt (0 => 149436)
--- trunk/LayoutTests/http/tests/eventsource/eventsource-retry-precision-expected.txt (rev 0)
+++ trunk/LayoutTests/http/tests/eventsource/eventsource-retry-precision-expected.txt 2013-05-01 17:15:46 UTC (rev 149436)
@@ -0,0 +1,5 @@
+Test EventSource retry time precision. Should print PASS followed by DONE.
+
+PASS: did not immediately reconnect
+DONE
+
Added: trunk/LayoutTests/http/tests/eventsource/eventsource-retry-precision.html (0 => 149436)
--- trunk/LayoutTests/http/tests/eventsource/eventsource-retry-precision.html (rev 0)
+++ trunk/LayoutTests/http/tests/eventsource/eventsource-retry-precision.html 2013-05-01 17:15:46 UTC (rev 149436)
@@ -0,0 +1,37 @@
+
+
+Test EventSource retry time precision. Should print PASS followed by DONE.
+
+function log(msg) {
+document.body.innerHTML += msg + "
";
+}
+
+if (window.testRunner) {
+testRunner.dumpAsText();
+testRunner.waitUntilDone();
+}
+
+var timeoutId = setTimeout(function () {
+log("PASS: did not immediately reconnect");
+end();
+}, 500);
+
+var count = 0;
+var es = new EventSource("resources/precise-retry.asis");
+es._onopen_ = function () {
+if (count++ != 2)
+return;
+clearTimeout(timeoutId);
+log("FAIL: reconnected too soon");
+end();
+};
+
+function end() {
+es.close();
+log("DONE");
+if (window.testRunner)
+testRunner.notifyDone();
+}
+
+
+
Added: trunk/LayoutTests/http/tests/eventsource/resources/precise-retry.asis (0 => 149436)
--- trunk/LayoutTests/http/tests/eventsource/resources/precise-retry.asis (rev 0)
+++ trunk/LayoutTests/http/tests/eventsource/resources/precise-retry.asis 2013-05-01 17:15:46 UTC (rev 149436)
@@ -0,0 +1,4 @@
+Content-Type: text/event-stream
+
+retry: 999
+
Modified: trunk/Source/WebCore/ChangeLog (149435 => 149436)
--- trunk/Source/WebCore/ChangeLog 2013-05-01 16:55:59 UTC (rev 149435)
+++ trunk/Source/WebCore/ChangeLog 2013-05-01 17:15:46 UTC (rev 149436)
@@ -1,3 +1,17 @@
+2013-05-01 Per-Erik Brodin
+
+EventSource: Loss of reconnect time precision due to integer division
+https://bugs.webkit.org/show_bug.cgi?id=115358
+
+Make sure precision is not lost when converting the reconnect time from milliseconds to seconds.
+
+Reviewed by Alexey Proskuryakov.
+
+Test: http/tests/eventsource/eventsource-retry-precision.html
+
+* page/EventSource.cpp:
+(WebCore::EventSource::scheduleReconnect):
+
2013-05-01 Andreas Kling
REGRESSION(r149287): Assertion failure in fast/frames/flattening/iframe-flattening-crash.html
Modified: trunk/Source/WebCore/page/EventSource.cpp (149435 => 149436)
--- trunk/Source/WebCore/page/EventSource.cpp 2013-05-01 16:55:59 UTC (rev 149435)
+++ trunk/Source/WebCore/page/EventSource.cpp 2013-05-01 17:15:46 UTC (rev 149436)
@@ -166,7 +166,7 @@
[webkit-changes] [149435] trunk/Source/WebCore
Title: [149435] trunk/Source/WebCore
Revision 149435
Author akl...@apple.com
Date 2013-05-01 09:55:59 -0700 (Wed, 01 May 2013)
Log Message
REGRESSION(r149287): Assertion failure in fast/frames/flattening/iframe-flattening-crash.html
Reviewed by Antti Koivisto.
Only send synchronous resize events for the main frame. Subframes change size during layout,
so it never really makes sense for them to use synchronous dispatch anyway.
* page/FrameView.cpp:
(WebCore::FrameView::dispatchResizeEvent):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/FrameView.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (149434 => 149435)
--- trunk/Source/WebCore/ChangeLog 2013-05-01 15:47:16 UTC (rev 149434)
+++ trunk/Source/WebCore/ChangeLog 2013-05-01 16:55:59 UTC (rev 149435)
@@ -1,3 +1,17 @@
+2013-05-01 Andreas Kling
+
+REGRESSION(r149287): Assertion failure in fast/frames/flattening/iframe-flattening-crash.html
+
+
+
+Reviewed by Antti Koivisto.
+
+Only send synchronous resize events for the main frame. Subframes change size during layout,
+so it never really makes sense for them to use synchronous dispatch anyway.
+
+* page/FrameView.cpp:
+(WebCore::FrameView::dispatchResizeEvent):
+
2013-05-01 Csaba Osztrogonác
Unreviewed trivial buildfix after r149432.
Modified: trunk/Source/WebCore/page/FrameView.cpp (149434 => 149435)
--- trunk/Source/WebCore/page/FrameView.cpp 2013-05-01 15:47:16 UTC (rev 149434)
+++ trunk/Source/WebCore/page/FrameView.cpp 2013-05-01 16:55:59 UTC (rev 149435)
@@ -2788,21 +2788,21 @@
{
ASSERT(m_frame);
+Page* page = m_frame->page();
+bool isMainFrame = page && page->mainFrame() == m_frame;
+bool canSendResizeEventSynchronously = isMainFrame && !isInLayout();
+
// If we resized during layout, queue up a resize event for later, otherwise fire it right away.
RefPtr resizeEvent = Event::create(eventNames().resizeEvent, false, false);
-if (isInLayout())
+if (canSendResizeEventSynchronously)
+m_frame->document()->dispatchWindowEvent(resizeEvent.release(), m_frame->document()->domWindow());
+else
m_frame->document()->enqueueWindowEvent(resizeEvent.release());
-else
-m_frame->document()->dispatchWindowEvent(resizeEvent.release(), m_frame->document()->domWindow());
#if ENABLE(INSPECTOR)
-if (InspectorInstrumentation::hasFrontends()) {
-if (Page* page = m_frame->page()) {
-if (page->mainFrame() == m_frame) {
-if (InspectorClient* inspectorClient = page->inspectorController()->inspectorClient())
-inspectorClient->didResizeMainFrame(m_frame.get());
-}
-}
+if (InspectorInstrumentation::hasFrontends() && isMainFrame) {
+if (InspectorClient* inspectorClient = page ? page->inspectorController()->inspectorClient() : 0)
+inspectorClient->didResizeMainFrame(m_frame.get());
}
#endif
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [149434] trunk/Source/WebCore
Title: [149434] trunk/Source/WebCore
Revision 149434
Author o...@webkit.org
Date 2013-05-01 08:47:16 -0700 (Wed, 01 May 2013)
Log Message
Unreviewed trivial buildfix after r149432.
* testing/Internals.cpp:
(WebCore):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/testing/Internals.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (149433 => 149434)
--- trunk/Source/WebCore/ChangeLog 2013-05-01 14:25:07 UTC (rev 149433)
+++ trunk/Source/WebCore/ChangeLog 2013-05-01 15:47:16 UTC (rev 149434)
@@ -1,3 +1,10 @@
+2013-05-01 Csaba Osztrogonác
+
+Unreviewed trivial buildfix after r149432.
+
+* testing/Internals.cpp:
+(WebCore):
+
2013-05-01 Sergio Villar Senin
Show a block cursor in overtype mode
Modified: trunk/Source/WebCore/testing/Internals.cpp (149433 => 149434)
--- trunk/Source/WebCore/testing/Internals.cpp 2013-05-01 14:25:07 UTC (rev 149433)
+++ trunk/Source/WebCore/testing/Internals.cpp 2013-05-01 15:47:16 UTC (rev 149434)
@@ -2295,6 +2295,7 @@
{
return ranges->nearest(time);
}
+#endif
PassRefPtr Internals::selectionBounds(ExceptionCode& ec)
{
@@ -2307,6 +2308,4 @@
return ClientRect::create(document->frame()->selection()->bounds());
}
-#endif
-
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [149432] trunk
Title: [149432] trunk Revision 149432 Author ser...@webkit.org Date 2013-05-01 07:17:12 -0700 (Wed, 01 May 2013) Log Message Show a block cursor in overtype mode https://bugs.webkit.org/show_bug.cgi?id=114819 Reviewed by Ryosuke Niwa. .: * Source/autotools/symbols.filter: export some extra symbols for testing purposes. Source/WebCore: Test: editing/selection/block-cursor-overtype-mode.html Overtype mode will use block cursor instead of a caret to highlight the next character to be replaced. It will fully cover the next character to be replaced (except at the end of a line where the usual blinking caret will be shown). This new block cursor is internally implemented as a selection (not exposed to _javascript_) because the selection code knows how to deal with bidi text. * WebCore.exp.in: Export symbols for testing purposes. * WebCore.order: Ditto. * editing/Editor.cpp: (WebCore::Editor::toggleOverwriteModeEnabled): Added a call to FrameLoader::setShouldShowBlockCursor. (WebCore): * editing/Editor.h: (Editor): * editing/FrameSelection.cpp: (WebCore::FrameSelection::FrameSelection): (WebCore::FrameSelection::updateAppearance): Use a 1-character long selection to paint the cursor in overtype mode. (WebCore::FrameSelection::setShouldShowBlockCursor): (WebCore): * editing/FrameSelection.h: (WebCore::FrameSelection::shouldShowBlockCursor): (FrameSelection): * testing/Internals.cpp: (WebCore): (WebCore::Internals::selectionBounds): Added a new method which returns the IntRect issued by FrameSelection::bounds(). * testing/Internals.h: Ditto. * testing/Internals.idl: Ditto. Source/WebKit: Export three more WebCore symbols. * WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in: Source/WebKit/win: Export three more WebCore symbols. * WebKit.vcproj/WebKitExports.def.in: LayoutTests: New test case for the new block cursor to be used in overtype mode. The test verifies that the 1-pixel long caret is replaced by a selection like 1-character long block cursor when in overtype mode. This test covers LTR and RTL text in LTR and RTL blocks and bidi text. * editing/selection/block-cursor-overtype-mode-expected.txt: Added. * editing/selection/block-cursor-overtype-mode.html: Added. Modified Paths trunk/ChangeLog trunk/LayoutTests/ChangeLog trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/WebCore.exp.in trunk/Source/WebCore/WebCore.order trunk/Source/WebCore/editing/Editor.cpp trunk/Source/WebCore/editing/Editor.h trunk/Source/WebCore/editing/FrameSelection.cpp trunk/Source/WebCore/editing/FrameSelection.h trunk/Source/WebCore/testing/Internals.cpp trunk/Source/WebCore/testing/Internals.h trunk/Source/WebCore/testing/Internals.idl trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in trunk/Source/WebKit/win/ChangeLog trunk/Source/WebKit/win/WebKit.vcproj/WebKitExports.def.in trunk/Source/autotools/symbols.filter Added Paths trunk/LayoutTests/editing/selection/block-cursor-overtype-mode-expected.txt trunk/LayoutTests/editing/selection/block-cursor-overtype-mode.html Diff Modified: trunk/ChangeLog (149431 => 149432) --- trunk/ChangeLog 2013-05-01 11:22:13 UTC (rev 149431) +++ trunk/ChangeLog 2013-05-01 14:17:12 UTC (rev 149432) @@ -1,3 +1,13 @@ +2013-05-01 Sergio Villar Senin + +Show a block cursor in overtype mode +https://bugs.webkit.org/show_bug.cgi?id=114819 + +Reviewed by Ryosuke Niwa. + +* Source/autotools/symbols.filter: export some extra symbols for +testing purposes. + 2013-04-30 Christophe Dumez [EFL] Enable scaled cursors Modified: trunk/LayoutTests/ChangeLog (149431 => 149432) --- trunk/LayoutTests/ChangeLog 2013-05-01 11:22:13 UTC (rev 149431) +++ trunk/LayoutTests/ChangeLog 2013-05-01 14:17:12 UTC (rev 149432) @@ -1,3 +1,19 @@ +2013-05-01 Sergio Villar Senin + +Show a block cursor in overtype mode +https://bugs.webkit.org/show_bug.cgi?id=114819 + +Reviewed by Ryosuke Niwa. + +New test case for the new block cursor to be used in overtype +mode. The test verifies that the 1-pixel long caret is replaced by +a selection like 1-character long block cursor when in overtype +mode. This test covers LTR and RTL text in LTR and RTL blocks and +bidi text. + +* editing/selection/block-cursor-overtype-mode-expected.txt: Added. +* editing/selection/block-cursor-overtype-mode.html: Added. + 2013-04-30 David Hyatt ignores margin-bottom. Added: trunk/LayoutTests/editing/selection/block-cursor-overtype-mode-expected.txt (0 => 149432) --- trunk/LayoutTests/editing/selection/block-cursor-overtype-mode-expected.txt (rev 0) +++ trunk/LayoutTests/editing/selection/block-cursor-overtype-mode-expected.txt 2013-05-01 14:17:12 UTC (rev 149432) @@ -0,0 +1,156 @@ +This test checks that the cursor covers the next character to be overwritten in overtype mode instea
[webkit-changes] [149431] trunk/Source/WebKit2
Title: [149431] trunk/Source/WebKit2 Revision 149431 Author ser...@webkit.org Date 2013-05-01 04:22:13 -0700 (Wed, 01 May 2013) Log Message Unreviewed GTK build fix after r149417. * GNUmakefile.list.am: Added PageBanner.[cpp|h] to the list of sources. Modified Paths trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/GNUmakefile.list.am Diff Modified: trunk/Source/WebKit2/ChangeLog (149430 => 149431) --- trunk/Source/WebKit2/ChangeLog 2013-05-01 10:14:33 UTC (rev 149430) +++ trunk/Source/WebKit2/ChangeLog 2013-05-01 11:22:13 UTC (rev 149431) @@ -1,3 +1,10 @@ +2013-05-01 Sergio Villar Senin + +Unreviewed GTK build fix after r149417. + +* GNUmakefile.list.am: Added PageBanner.[cpp|h] to the list of +sources. + 2013-05-01 Ryuan Choi [EFL] Unreviewed buildfix after r149416 and r149417. Modified: trunk/Source/WebKit2/GNUmakefile.list.am (149430 => 149431) --- trunk/Source/WebKit2/GNUmakefile.list.am 2013-05-01 10:14:33 UTC (rev 149430) +++ trunk/Source/WebKit2/GNUmakefile.list.am 2013-05-01 11:22:13 UTC (rev 149431) @@ -1209,6 +1209,8 @@ Source/WebKit2/WebProcess/WebPage/gtk/WebPrintOperationGtk.h \ Source/WebKit2/WebProcess/WebPage/LayerTreeHost.cpp \ Source/WebKit2/WebProcess/WebPage/LayerTreeHost.h \ + Source/WebKit2/WebProcess/WebPage/PageBanner.cpp \ + Source/WebKit2/WebProcess/WebPage/PageBanner.h \ Source/WebKit2/WebProcess/WebPage/PageOverlay.cpp \ Source/WebKit2/WebProcess/WebPage/PageOverlay.h \ Source/WebKit2/WebProcess/WebPage/WebBackForwardListProxy.cpp \ ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
