[webkit-changes] [150625] trunk/Source/WebKit/blackberry

[commit-queue]

Title: [150625] trunk/Source/WebKit/blackberry








Revision 150625
Author commit-qu...@webkit.org
Date 2013-05-23 23:07:56 -0700 (Thu, 23 May 2013)


Log Message
[BlackBerry] Compositor API change: Don't pass the unused viewport parameter.
https://bugs.webkit.org/show_bug.cgi?id=116545
Internal PR 189775

Patch by Jakob Petsovits jpetsov...@blackberry.com on 2013-05-23
Reviewed by Rob Buis.

Also change the name of the documentContents parameter
to the more descriptive documentSrcRect.

* Api/WebPageCompositor.cpp:
(BlackBerry::WebKit::WebPageCompositorPrivate::render):
(BlackBerry::WebKit::WebPageCompositor::render):
* Api/WebPageCompositor.h:
* Api/WebPageCompositor_p.h:
(WebPageCompositorPrivate):

Modified Paths

trunk/Source/WebKit/blackberry/Api/WebPageCompositor.cpp
trunk/Source/WebKit/blackberry/Api/WebPageCompositor.h
trunk/Source/WebKit/blackberry/Api/WebPageCompositor_p.h
trunk/Source/WebKit/blackberry/ChangeLog




Diff

Modified: trunk/Source/WebKit/blackberry/Api/WebPageCompositor.cpp (150624 => 150625)

--- trunk/Source/WebKit/blackberry/Api/WebPageCompositor.cpp	2013-05-24 05:14:54 UTC (rev 150624)
+++ trunk/Source/WebKit/blackberry/Api/WebPageCompositor.cpp	2013-05-24 06:07:56 UTC (rev 150625)
@@ -144,7 +144,7 @@
 m_layerRenderer-prepareFrame(animationTime, m_compositingThreadOverlayLayer.get());
 }
 
-void WebPageCompositorPrivate::render(const IntRect targetRect, const IntRect clipRect, const TransformationMatrix transformIn, const FloatRect documentContents, const FloatRect /*viewport*/)
+void WebPageCompositorPrivate::render(const IntRect targetRect, const IntRect clipRect, const TransformationMatrix transformIn, const FloatRect documentSrcRect)
 {
 // m_layerRenderer should have been created in prepareFrame
 if (!m_layerRenderer)
@@ -157,13 +157,13 @@
 if (!m_webPage || m_webPage-compositor() != this)
 return;
 
-m_layerRenderer-setViewport(targetRect, clipRect, documentContents, m_layoutRect, m_documentRect.size());
+m_layerRenderer-setViewport(targetRect, clipRect, documentSrcRect, m_layoutRect, m_documentRect.size());
 
 TransformationMatrix transform(transformIn);
 transform.translate(-m_documentRect.x(), -m_documentRect.y());
 
 if (!drawsRootLayer())
-m_webPage-m_backingStore-d-compositeContents(m_layerRenderer.get(), transform, documentContents, !m_backgroundColor.hasAlpha());
+m_webPage-m_backingStore-d-compositeContents(m_layerRenderer.get(), transform, documentSrcRect, !m_backgroundColor.hasAlpha());
 
 compositeLayers(transform);
 }
@@ -344,10 +344,10 @@
 d-prepareFrame(animationTime);
 }
 
-void WebPageCompositor::render(Platform::Graphics::GLES2Context* context, const Platform::IntRect targetRect, const Platform::IntRect clipRect, const Platform::TransformationMatrix transform, const Platform::FloatRect documentContents, const Platform::FloatRect viewport)
+void WebPageCompositor::render(Platform::Graphics::GLES2Context* context, const Platform::IntRect targetRect, const Platform::IntRect clipRect, const Platform::TransformationMatrix transform, const Platform::FloatRect documentSrcRect)
 {
 d-setContext(context);
-d-render(targetRect, clipRect, TransformationMatrix(reinterpret_castconst TransformationMatrix(transform)), documentContents, viewport);
+d-render(targetRect, clipRect, TransformationMatrix(reinterpret_castconst TransformationMatrix(transform)), documentSrcRect);
 }
 
 void WebPageCompositor::cleanup(Platform::Graphics::GLES2Context*)
@@ -397,7 +397,6 @@
 const Platform::IntRect,
 const Platform::IntRect,
 const Platform::TransformationMatrix,
-const Platform::FloatRect,
 const Platform::FloatRect)
 {
 }


Modified: trunk/Source/WebKit/blackberry/Api/WebPageCompositor.h (150624 => 150625)

--- trunk/Source/WebKit/blackberry/Api/WebPageCompositor.h	2013-05-24 05:14:54 UTC (rev 150624)
+++ trunk/Source/WebKit/blackberry/Api/WebPageCompositor.h	2013-05-24 06:07:56 UTC (rev 150625)
@@ -54,8 +54,7 @@
 const Platform::IntRect targetRect,
 const Platform::IntRect clipRect,
 const Platform::TransformationMatrix,
-const Platform::FloatRect documentContents,
-const Platform::FloatRect viewport);
+const Platform::FloatRect documentSrcRect);
 
 void cleanup(Platform::Graphics::GLES2Context*);
 


Modified: trunk/Source/WebKit/blackberry/Api/WebPageCompositor_p.h (150624 => 150625)

--- trunk/Source/WebKit/blackberry/Api/WebPageCompositor_p.h	2013-05-24 05:14:54 UTC (rev 150624)
+++ trunk/Source/WebKit/blackberry/Api/WebPageCompositor_p.h	2013-05-24 06:07:56 UTC (rev 150625)
@@ -58,11 +58,7 @@
 // Public API
 void setChildWindowPlacement(WebPageCompositor::ChildWindowPlacement placement) { m_childWindowPlacement = placement; }
 void prepareFrame(double animationTime);
-void render(const WebCore::IntRect targetRect,
-const WebCore::IntRect clipRect,
-const 

[webkit-changes] [150627] trunk/Source/WebCore

[commit-queue]

Title: [150627] trunk/Source/WebCore








Revision 150627
Author commit-qu...@webkit.org
Date 2013-05-23 23:20:19 -0700 (Thu, 23 May 2013)


Log Message
[WinCairo] Build fails to link.
https://bugs.webkit.org/show_bug.cgi?id=116671

Patch by pe...@outlook.com pe...@outlook.com on 2013-05-23
Reviewed by Brent Fulgham.

* page/FrameView.h: Added guard for ACCELERATED_COMPOSITING.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/FrameView.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (150626 => 150627)

--- trunk/Source/WebCore/ChangeLog	2013-05-24 06:15:13 UTC (rev 150626)
+++ trunk/Source/WebCore/ChangeLog	2013-05-24 06:20:19 UTC (rev 150627)
@@ -1,3 +1,12 @@
+2013-05-23  pe...@outlook.com  pe...@outlook.com
+
+[WinCairo] Build fails to link.
+https://bugs.webkit.org/show_bug.cgi?id=116671
+
+Reviewed by Brent Fulgham.
+
+* page/FrameView.h: Added guard for ACCELERATED_COMPOSITING.
+
 2013-05-23  Roger Fong  roger_f...@apple.com
 
 Unreviewed. Modify WebCore for AppleWin 2010 production build.


Modified: trunk/Source/WebCore/page/FrameView.h (150626 => 150627)

--- trunk/Source/WebCore/page/FrameView.h	2013-05-24 06:15:13 UTC (rev 150626)
+++ trunk/Source/WebCore/page/FrameView.h	2013-05-24 06:20:19 UTC (rev 150627)
@@ -419,7 +419,9 @@
 virtual void willStartLiveResize() OVERRIDE;
 virtual void willEndLiveResize() OVERRIDE;
 
+#if USE(ACCELERATED_COMPOSITING)
 virtual bool scrollbarAnimationsAreSuppressed() const OVERRIDE;
+#endif
 
 void addPaintPendingMilestones(LayoutMilestones);
 void firePaintRelatedMilestones();






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [150628] trunk/Source/WebKit/blackberry

[commit-queue]

Title: [150628] trunk/Source/WebKit/blackberry








Revision 150628
Author commit-qu...@webkit.org
Date 2013-05-23 23:23:20 -0700 (Thu, 23 May 2013)


Log Message
[BlackBerry] Need to forward the opener frame url to client when creating a new window
https://bugs.webkit.org/show_bug.cgi?id=116566

Patch by Andy Chen andc...@blackberry.com on 2013-05-23
Reviewed by Rob Buis.

PR 337935
Internally reviewed by Arvid Nilsson.
When creating a new window, forward the opener frame url to client.

* Api/WebPageClient.h:
* WebCoreSupport/ChromeClientBlackBerry.cpp:
(WebCore::ChromeClientBlackBerry::createWindow):
* WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
(WebCore::FrameLoaderClientBlackBerry::dispatchCreatePage):

Modified Paths

trunk/Source/WebKit/blackberry/Api/WebPageClient.h
trunk/Source/WebKit/blackberry/ChangeLog
trunk/Source/WebKit/blackberry/WebCoreSupport/ChromeClientBlackBerry.cpp
trunk/Source/WebKit/blackberry/WebCoreSupport/FrameLoaderClientBlackBerry.cpp




Diff

Modified: trunk/Source/WebKit/blackberry/Api/WebPageClient.h (150627 => 150628)

--- trunk/Source/WebKit/blackberry/Api/WebPageClient.h	2013-05-24 06:20:19 UTC (rev 150627)
+++ trunk/Source/WebKit/blackberry/Api/WebPageClient.h	2013-05-24 06:23:20 UTC (rev 150628)
@@ -171,7 +171,7 @@
 virtual void openPopupList(bool multiple, int size, const ScopeArrayBlackBerry::Platform::String labels, const bool* enableds, const int* itemType, const bool* selecteds) = 0;
 virtual bool chooseFilenames(bool allowMultiple, const SharedArrayBlackBerry::Platform::String acceptTypes, const SharedArrayBlackBerry::Platform::String initialFiles, const BlackBerry::Platform::String capture, SharedArrayBlackBerry::Platform::String chosenFiles) = 0;
 
-virtual WebPage* createWindow(int x, int y, int width, int height, unsigned flags, const BlackBerry::Platform::String url, const BlackBerry::Platform::String windowName, bool userGesture) = 0;
+virtual WebPage* createWindow(int x, int y, int width, int height, unsigned flags, const BlackBerry::Platform::String url, const BlackBerry::Platform::String windowName, const BlackBerry::Platform::String openerFrameUrl, bool userGesture) = 0;
 
 virtual void scheduleCloseWindow() = 0;
 


Modified: trunk/Source/WebKit/blackberry/ChangeLog (150627 => 150628)

--- trunk/Source/WebKit/blackberry/ChangeLog	2013-05-24 06:20:19 UTC (rev 150627)
+++ trunk/Source/WebKit/blackberry/ChangeLog	2013-05-24 06:23:20 UTC (rev 150628)
@@ -1,3 +1,20 @@
+2013-05-23  Andy Chen  andc...@blackberry.com
+
+[BlackBerry] Need to forward the opener frame url to client when creating a new window
+https://bugs.webkit.org/show_bug.cgi?id=116566
+
+Reviewed by Rob Buis.
+
+PR 337935
+Internally reviewed by Arvid Nilsson.
+When creating a new window, forward the opener frame url to client.
+
+* Api/WebPageClient.h:
+* WebCoreSupport/ChromeClientBlackBerry.cpp:
+(WebCore::ChromeClientBlackBerry::createWindow):
+* WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
+(WebCore::FrameLoaderClientBlackBerry::dispatchCreatePage):
+
 2013-05-23  Jakob Petsovits  jpetsov...@blackberry.com
 
 [BlackBerry] Compositor API change: Don't pass the unused viewport parameter.


Modified: trunk/Source/WebKit/blackberry/WebCoreSupport/ChromeClientBlackBerry.cpp (150627 => 150628)

--- trunk/Source/WebKit/blackberry/WebCoreSupport/ChromeClientBlackBerry.cpp	2013-05-24 06:20:19 UTC (rev 150627)
+++ trunk/Source/WebKit/blackberry/WebCoreSupport/ChromeClientBlackBerry.cpp	2013-05-24 06:23:20 UTC (rev 150628)
@@ -256,7 +256,7 @@
 if (features.dialog)
 flags |= WebPageClient::FlagWindowIsDialog;
 
-WebPage* webPage = m_webPagePrivate-m_client-createWindow(x, y, width, height, flags, url.string(), request.frameName(), ScriptController::processingUserGesture());
+WebPage* webPage = m_webPagePrivate-m_client-createWindow(x, y, width, height, flags, url.string(), request.frameName(), frame-document()-url().string(), ScriptController::processingUserGesture());
 if (!webPage)
 return 0;
 


Modified: trunk/Source/WebKit/blackberry/WebCoreSupport/FrameLoaderClientBlackBerry.cpp (150627 => 150628)

--- trunk/Source/WebKit/blackberry/WebCoreSupport/FrameLoaderClientBlackBerry.cpp	2013-05-24 06:20:19 UTC (rev 150627)
+++ trunk/Source/WebKit/blackberry/WebCoreSupport/FrameLoaderClientBlackBerry.cpp	2013-05-24 06:23:20 UTC (rev 150628)
@@ -942,7 +942,7 @@
 
 Frame* FrameLoaderClientBlackBerry::dispatchCreatePage(const NavigationAction navigation)
 {
-WebPage* webPage = m_webPagePrivate-m_client-createWindow(0, 0, -1, -1, WebPageClient::FlagWindowDefault, navigation.url().string(), BlackBerry::Platform::String::emptyString(), ScriptController::processingUserGesture());
+WebPage* webPage = m_webPagePrivate-m_client-createWindow(0, 0, -1, -1, WebPageClient::FlagWindowDefault, navigation.url().string(), 

[webkit-changes] [150629] trunk/Source/WebKit/blackberry

[commit-queue]

Title: [150629] trunk/Source/WebKit/blackberry








Revision 150629
Author commit-qu...@webkit.org
Date 2013-05-23 23:26:26 -0700 (Thu, 23 May 2013)


Log Message
[BlackBerry] Need to suspend/resume RootLayerCommit when the application becomes inactive/active
https://bugs.webkit.org/show_bug.cgi?id=115245

Patch by Xiaobo Wang xiaobw...@blackberry.com on 2013-05-23
Reviewed by Rob Buis.

PR 330917.
Internally reviewed by Arvid Nilsson.

1. Suspend/resumeRootLayerCommit when notified app activation state
change.
2. Schedule root layer commit in resumeRootLayerCommit() to explicitly
start root layer commit timer, so that there's a commit even if
BackingStore got disabled/removed.

* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::notifyAppActivationStateChange):
(BlackBerry::WebKit::WebPagePrivate::resumeRootLayerCommit):

Modified Paths

trunk/Source/WebKit/blackberry/Api/WebPage.cpp
trunk/Source/WebKit/blackberry/ChangeLog




Diff

Modified: trunk/Source/WebKit/blackberry/Api/WebPage.cpp (150628 => 150629)

--- trunk/Source/WebKit/blackberry/Api/WebPage.cpp	2013-05-24 06:23:20 UTC (rev 150628)
+++ trunk/Source/WebKit/blackberry/Api/WebPage.cpp	2013-05-24 06:26:26 UTC (rev 150629)
@@ -5024,6 +5024,13 @@
 {
 m_activationState = activationState;
 
+#if USE(ACCELERATED_COMPOSITING)
+if (activationState == ActivationActive)
+resumeRootLayerCommit();
+else
+suspendRootLayerCommit();
+#endif
+
 #if ENABLE(PAGE_VISIBILITY_API)
 setPageVisibilityState();
 #endif
@@ -5673,6 +5680,9 @@
 
 m_suspendRootLayerCommit = false;
 m_needsCommit = true;
+// PR 330917, explicitly start root layer commit timer, so that there's a commit
+// even if BackingStore got disabled/removed.
+scheduleRootLayerCommit();
 }
 
 bool WebPagePrivate::needsOneShotDrawingSynchronization()


Modified: trunk/Source/WebKit/blackberry/ChangeLog (150628 => 150629)

--- trunk/Source/WebKit/blackberry/ChangeLog	2013-05-24 06:23:20 UTC (rev 150628)
+++ trunk/Source/WebKit/blackberry/ChangeLog	2013-05-24 06:26:26 UTC (rev 150629)
@@ -1,3 +1,23 @@
+2013-05-23  Xiaobo Wang  xiaobw...@blackberry.com
+
+[BlackBerry] Need to suspend/resume RootLayerCommit when the application becomes inactive/active
+https://bugs.webkit.org/show_bug.cgi?id=115245
+
+Reviewed by Rob Buis.
+
+PR 330917.
+Internally reviewed by Arvid Nilsson.
+
+1. Suspend/resumeRootLayerCommit when notified app activation state
+change.
+2. Schedule root layer commit in resumeRootLayerCommit() to explicitly
+start root layer commit timer, so that there's a commit even if
+BackingStore got disabled/removed.
+
+* Api/WebPage.cpp:
+(BlackBerry::WebKit::WebPagePrivate::notifyAppActivationStateChange):
+(BlackBerry::WebKit::WebPagePrivate::resumeRootLayerCommit):
+
 2013-05-23  Andy Chen  andc...@blackberry.com
 
 [BlackBerry] Need to forward the opener frame url to client when creating a new window






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [150630] trunk/Source/JavaScriptCore

[commit-queue]

Title: [150630] trunk/Source/_javascript_Core








Revision 150630
Author commit-qu...@webkit.org
Date 2013-05-23 23:56:30 -0700 (Thu, 23 May 2013)


Log Message
CLoop llint backend should not use the d8 register as scratch register
https://bugs.webkit.org/show_bug.cgi?id=116019

Patch by Peter Wang peter.w...@torchmobile.com.cn on 2013-05-23
Reviewed by Csaba Osztrogonác.

* offlineasm/cloop.rb:

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/offlineasm/cloop.rb




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (150629 => 150630)

--- trunk/Source/_javascript_Core/ChangeLog	2013-05-24 06:26:26 UTC (rev 150629)
+++ trunk/Source/_javascript_Core/ChangeLog	2013-05-24 06:56:30 UTC (rev 150630)
@@ -1,3 +1,12 @@
+2013-05-23  Peter Wang  peter.w...@torchmobile.com.cn
+
+CLoop llint backend should not use the d8 register as scratch register
+https://bugs.webkit.org/show_bug.cgi?id=116019
+
+Reviewed by Csaba Osztrogonác.
+
+* offlineasm/cloop.rb:
+
 2013-05-22  Peter Wang  peter.w...@torchmobile.com.cn
 
 Use uninitialized register in JIT::emit_op_neq_null and emit_op_eq_null


Modified: trunk/Source/_javascript_Core/offlineasm/cloop.rb (150629 => 150630)

--- trunk/Source/_javascript_Core/offlineasm/cloop.rb	2013-05-24 06:26:26 UTC (rev 150629)
+++ trunk/Source/_javascript_Core/offlineasm/cloop.rb	2013-05-24 06:56:30 UTC (rev 150630)
@@ -63,7 +63,7 @@
 end
 end
 
-C_LOOP_SCRATCH_FPR = SpecialRegister.new(d8)
+C_LOOP_SCRATCH_FPR = SpecialRegister.new(d6)
 
 class RegisterID
 def clDump






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [150631] trunk/Source/WebCore

[bdakin]

Title: [150631] trunk/Source/WebCore








Revision 150631
Author bda...@apple.com
Date 2013-05-24 00:02:26 -0700 (Fri, 24 May 2013)


Log Message
https://bugs.webkit.org/show_bug.cgi?id=116702
REGRESSION (r150399): Scrollbar missing for all overflow scroll
-and corresponding-
rdar://problem/13963712

Reviewed by Simon Fraser.

This was a silly copy-paste error.
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::scrollbarAnimationsAreSuppressed):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderLayer.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (150630 => 150631)

--- trunk/Source/WebCore/ChangeLog	2013-05-24 06:56:30 UTC (rev 150630)
+++ trunk/Source/WebCore/ChangeLog	2013-05-24 07:02:26 UTC (rev 150631)
@@ -1,3 +1,16 @@
+2013-05-23  Beth Dakin  bda...@apple.com
+
+https://bugs.webkit.org/show_bug.cgi?id=116702
+REGRESSION (r150399): Scrollbar missing for all overflow scroll
+-and corresponding-
+rdar://problem/13963712
+
+Reviewed by Simon Fraser.
+
+This was a silly copy-paste error.
+* rendering/RenderLayer.cpp:
+(WebCore::RenderLayer::scrollbarAnimationsAreSuppressed):
+
 2013-05-23  pe...@outlook.com  pe...@outlook.com
 
 [WinCairo] Build fails to link.


Modified: trunk/Source/WebCore/rendering/RenderLayer.cpp (150630 => 150631)

--- trunk/Source/WebCore/rendering/RenderLayer.cpp	2013-05-24 06:56:30 UTC (rev 150630)
+++ trunk/Source/WebCore/rendering/RenderLayer.cpp	2013-05-24 07:02:26 UTC (rev 150631)
@@ -1400,7 +1400,7 @@
 RenderView* view = renderer()-view();
 if (!view)
 return false;
-return view-frameView()-scrollbarsCanBeActive();
+return view-frameView()-scrollbarAnimationsAreSuppressed();
 }
 
 RenderLayer* RenderLayer::enclosingTransformedAncestor() const






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [150632] trunk/LayoutTests

[rniwa]

Title: [150632] trunk/LayoutTests








Revision 150632
Author rn...@webkit.org
Date 2013-05-24 00:05:01 -0700 (Fri, 24 May 2013)


Log Message
Add back a failing test expectation on fast/canvas/webgl/object-deletion-behaviour.html
after r150558 on Lion Debug WK1.

* platform/mac-wk2/TestExpectations:
* platform/mac/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac/TestExpectations
trunk/LayoutTests/platform/mac-wk2/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (150631 => 150632)

--- trunk/LayoutTests/ChangeLog	2013-05-24 07:02:26 UTC (rev 150631)
+++ trunk/LayoutTests/ChangeLog	2013-05-24 07:05:01 UTC (rev 150632)
@@ -1,3 +1,11 @@
+2013-05-24  Ryosuke Niwa  rn...@webkit.org
+
+Add back a failing test expectation on fast/canvas/webgl/object-deletion-behaviour.html
+after r150558 on Lion Debug WK1.
+
+* platform/mac-wk2/TestExpectations:
+* platform/mac/TestExpectations:
+
 2013-05-23  Seokju Kwon  seokju.k...@gmail.com
 
 [EFL] Rebaseline after r150593


Modified: trunk/LayoutTests/platform/mac/TestExpectations (150631 => 150632)

--- trunk/LayoutTests/platform/mac/TestExpectations	2013-05-24 07:02:26 UTC (rev 150631)
+++ trunk/LayoutTests/platform/mac/TestExpectations	2013-05-24 07:05:01 UTC (rev 150632)
@@ -576,6 +576,7 @@
 webkit.org/b/82762 fast/animation/request-animation-frame-during-modal.html
 
 webkit.org/b/82805 fast/canvas/webgl/framebuffer-object-attachment.html [ Failure ]
+webkit.org/b/82805 [ Lion Debug ] fast/canvas/webgl/object-deletion-behaviour.html [ Failure ]
 
 webkit.org/b/82817 storage/domstorage/localstorage/storagetracker/storage-tracker-1-prepare.html [ Pass Failure ]
 webkit.org/b/82817 storage/domstorage/localstorage/storagetracker/storage-tracker-2-create.html [ Pass Failure ]


Modified: trunk/LayoutTests/platform/mac-wk2/TestExpectations (150631 => 150632)

--- trunk/LayoutTests/platform/mac-wk2/TestExpectations	2013-05-24 07:02:26 UTC (rev 150631)
+++ trunk/LayoutTests/platform/mac-wk2/TestExpectations	2013-05-24 07:05:01 UTC (rev 150632)
@@ -284,6 +284,9 @@
 
 webkit.org/b/116684 [ Lion ] compositing/overflow/overflow-compositing-descendant.html [ Timeout Failure ]
 
+# Only fails on WK1
+webkit.org/b/82805 [ Lion Debug ] fast/canvas/webgl/object-deletion-behaviour.html [ Pass ]
+
 ### END OF (1) Classified failures with bug reports
 
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [150633] trunk/Source

[akling]

Title: [150633] trunk/Source








Revision 150633
Author akl...@apple.com
Date 2013-05-24 00:12:19 -0700 (Fri, 24 May 2013)


Log Message
Typing in Safari's unified field causes unnecessary web content repaints.
http://webkit.org/b/116703

Reviewed by Andy Estes.

Source/WebCore:

Break out an alternate version of Page::markAllMatchesForText() that only counts the number of times
a string occurs in the page, but doesn't try to mark the occurrences.
This allows Safari to count matches for the 'Find foo on This Page' functionality in the unified
location bar without causing tile repaints.

* WebCore.exp.in:
* page/Page.h:
* page/Page.cpp:
(WebCore::Page::findMatchesForText):
(WebCore::Page::markAllMatchesForText):
(WebCore::Page::countFindMatches):

Renamed markAllMatchesForText() to findMatchesForText() and gave it a boolean parameter to control whether
matches should be marked or not. countFindMatches() is the new helper that doesn't mark.

Source/WebKit2:

* WebProcess/WebPage/FindController.cpp:
(WebKit::FindController::countStringMatches):

Call WebCore::Page::countMatchesForText() instead of markAllMatchesForText(). If the search string
is found inside the page content, the renderer containing that text will no longer be repainted.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/WebCore.exp.in
trunk/Source/WebCore/page/Page.cpp
trunk/Source/WebCore/page/Page.h
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/WebProcess/WebPage/FindController.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (150632 => 150633)

--- trunk/Source/WebCore/ChangeLog	2013-05-24 07:05:01 UTC (rev 150632)
+++ trunk/Source/WebCore/ChangeLog	2013-05-24 07:12:19 UTC (rev 150633)
@@ -1,3 +1,25 @@
+2013-05-24  Andreas Kling  akl...@apple.com
+
+Typing in Safari's unified field causes unnecessary web content repaints.
+http://webkit.org/b/116703
+
+Reviewed by Andy Estes.
+
+Break out an alternate version of Page::markAllMatchesForText() that only counts the number of times
+a string occurs in the page, but doesn't try to mark the occurrences.
+This allows Safari to count matches for the 'Find foo on This Page' functionality in the unified
+location bar without causing tile repaints.
+
+* WebCore.exp.in:
+* page/Page.h:
+* page/Page.cpp:
+(WebCore::Page::findMatchesForText):
+(WebCore::Page::markAllMatchesForText):
+(WebCore::Page::countFindMatches):
+
+Renamed markAllMatchesForText() to findMatchesForText() and gave it a boolean parameter to control whether
+matches should be marked or not. countFindMatches() is the new helper that doesn't mark.
+
 2013-05-23  Beth Dakin  bda...@apple.com
 
 https://bugs.webkit.org/show_bug.cgi?id=116702


Modified: trunk/Source/WebCore/WebCore.exp.in (150632 => 150633)

--- trunk/Source/WebCore/WebCore.exp.in	2013-05-24 07:05:01 UTC (rev 150632)
+++ trunk/Source/WebCore/WebCore.exp.in	2013-05-24 07:12:19 UTC (rev 150633)
@@ -855,6 +855,7 @@
 __ZN7WebCore4Page14setMediaVolumeEf
 __ZN7WebCore4Page15addSchedulePairEN3WTF10PassRefPtrINS1_12SchedulePairEEE
 __ZN7WebCore4Page15didMoveOnscreenEv
+__ZN7WebCore4Page16countFindMatchesERKN3WTF6StringEjj
 __ZN7WebCore4Page16setCanStartMediaEb
 __ZN7WebCore4Page16setDefersLoadingEb
 __ZN7WebCore4Page17willMoveOffscreenEv


Modified: trunk/Source/WebCore/page/Page.cpp (150632 => 150633)

--- trunk/Source/WebCore/page/Page.cpp	2013-05-24 07:05:01 UTC (rev 150632)
+++ trunk/Source/WebCore/page/Page.cpp	2013-05-24 07:12:19 UTC (rev 150633)
@@ -644,28 +644,34 @@
 return 0;
 }
 
-unsigned int Page::markAllMatchesForText(const String target, TextCaseSensitivity caseSensitivity, bool shouldHighlight, unsigned limit)
+unsigned Page::findMatchesForText(const String target, FindOptions options, unsigned maxMatchCount, bool shouldHighlight, bool markMatches)
 {
-return markAllMatchesForText(target, caseSensitivity == TextCaseInsensitive ? CaseInsensitive : 0, shouldHighlight, limit);
-}
-
-unsigned int Page::markAllMatchesForText(const String target, FindOptions options, bool shouldHighlight, unsigned limit)
-{
 if (target.isEmpty() || !mainFrame())
 return 0;
 
-unsigned matches = 0;
+unsigned matchCount = 0;
 
 Frame* frame = mainFrame();
 do {
-frame-editor().setMarkedTextMatchesAreHighlighted(shouldHighlight);
-matches += frame-editor().countMatchesForText(target, 0, options, limit ? (limit - matches) : 0, true, 0);
+if (markMatches)
+frame-editor().setMarkedTextMatchesAreHighlighted(shouldHighlight);
+matchCount += frame-editor().countMatchesForText(target, 0, options, maxMatchCount ? (maxMatchCount - matchCount) : 0, markMatches, 0);
 frame = incrementFrame(frame, true, false);
 } while (frame);
 
-return matches;
+return matchCount;
 }
 
+unsigned Page::markAllMatchesForText(const 

[webkit-changes] [150634] trunk/Source/WebKit/blackberry

[commit-queue]

Title: [150634] trunk/Source/WebKit/blackberry








Revision 150634
Author commit-qu...@webkit.org
Date 2013-05-24 00:32:54 -0700 (Fri, 24 May 2013)


Log Message
[BlackBerry] Remove SKIA leftovers from WebPage.cpp
https://bugs.webkit.org/show_bug.cgi?id=116656

Patch by Jeff Rogers jrog...@rim.com on 2013-05-24
Reviewed by Rob Buis.

* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::setLoadState):

Modified Paths

trunk/Source/WebKit/blackberry/Api/WebPage.cpp
trunk/Source/WebKit/blackberry/ChangeLog




Diff

Modified: trunk/Source/WebKit/blackberry/Api/WebPage.cpp (150633 => 150634)

--- trunk/Source/WebKit/blackberry/Api/WebPage.cpp	2013-05-24 07:12:19 UTC (rev 150633)
+++ trunk/Source/WebKit/blackberry/Api/WebPage.cpp	2013-05-24 07:32:54 UTC (rev 150634)
@@ -185,11 +185,6 @@
 #include memalloc.h
 #endif
 
-#if ENABLE(ACCELERATED_2D_CANVAS)
-#include GrContext.h
-#include SharedGraphicsContext3D.h
-#endif
-
 #if ENABLE(REQUEST_ANIMATION_FRAME)
 #include PlatformScreen.h
 #endif
@@ -1064,16 +1059,6 @@
 break;
 case Committed:
 {
-#if ENABLE(ACCELERATED_2D_CANVAS)
-if (m_page-settings()-canvasUsesAcceleratedDrawing()) {
-// Free GPU resources as we're on a new page.
-// This will help us to free memory pressure.
-SharedGraphicsContext3D::get()-makeContextCurrent();
-GrContext* grContext = Platform::Graphics::getGrContext();
-grContext-freeGpuResources();
-}
-#endif
-
 #if USE(ACCELERATED_COMPOSITING)
 releaseLayerResources();
 #endif


Modified: trunk/Source/WebKit/blackberry/ChangeLog (150633 => 150634)

--- trunk/Source/WebKit/blackberry/ChangeLog	2013-05-24 07:12:19 UTC (rev 150633)
+++ trunk/Source/WebKit/blackberry/ChangeLog	2013-05-24 07:32:54 UTC (rev 150634)
@@ -1,3 +1,13 @@
+2013-05-24  Jeff Rogers  jrog...@rim.com
+
+[BlackBerry] Remove SKIA leftovers from WebPage.cpp
+https://bugs.webkit.org/show_bug.cgi?id=116656
+
+Reviewed by Rob Buis.
+
+* Api/WebPage.cpp:
+(BlackBerry::WebKit::WebPagePrivate::setLoadState):
+
 2013-05-23  Xiaobo Wang  xiaobw...@blackberry.com
 
 [BlackBerry] Need to suspend/resume RootLayerCommit when the application becomes inactive/active






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [150635] trunk/Source/WebCore

[commit-queue]

Title: [150635] trunk/Source/WebCore








Revision 150635
Author commit-qu...@webkit.org
Date 2013-05-24 01:05:49 -0700 (Fri, 24 May 2013)


Log Message
[BlackBerry] DRT - crashed on GraphicsContext3D::makeContextCurrent
https://bugs.webkit.org/show_bug.cgi?id=116654

Patch by Xiaobo Wang xiaobw...@blackberry.com on 2013-05-24
Reviewed by Carlos Garcia Campos.

PR 331552.
Internally reviewed and amended by Arvid Nilsson.

No new tests, this patch is to fix DRT crashes in fast/canvas/webgl.
The instance of GraphicsContext3D has already been destroyed but
WebGLLayerWebKitThread is not aware of that. This is because compositor
layer of the WebGL graphics context was referenced outside the context.
So when destructing GraphicsContext3D the compositing layer was not
destructed.
Fix by setting m_webGLContext to 0 when destructing GrapthicsContext3D
after releasing the compositor layer, so that it won't be de-referenced
again later.

* platform/graphics/blackberry/GraphicsContext3DBlackBerry.cpp:
(WebCore::GraphicsContext3D::~GraphicsContext3D):
* platform/graphics/blackberry/WebGLLayerWebKitThread.cpp:
(WebCore::WebGLLayerWebKitThread::~WebGLLayerWebKitThread):
(WebCore::WebGLLayerWebKitThread::webGLContextDestroyed):
(WebCore):
* platform/graphics/blackberry/WebGLLayerWebKitThread.h:
(WebGLLayerWebKitThread):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/blackberry/GraphicsContext3DBlackBerry.cpp
trunk/Source/WebCore/platform/graphics/blackberry/WebGLLayerWebKitThread.cpp
trunk/Source/WebCore/platform/graphics/blackberry/WebGLLayerWebKitThread.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (150634 => 150635)

--- trunk/Source/WebCore/ChangeLog	2013-05-24 07:32:54 UTC (rev 150634)
+++ trunk/Source/WebCore/ChangeLog	2013-05-24 08:05:49 UTC (rev 150635)
@@ -1,3 +1,32 @@
+2013-05-24  Xiaobo Wang  xiaobw...@blackberry.com
+
+[BlackBerry] DRT - crashed on GraphicsContext3D::makeContextCurrent
+https://bugs.webkit.org/show_bug.cgi?id=116654
+
+Reviewed by Carlos Garcia Campos.
+
+PR 331552.
+Internally reviewed and amended by Arvid Nilsson.
+
+No new tests, this patch is to fix DRT crashes in fast/canvas/webgl.
+The instance of GraphicsContext3D has already been destroyed but
+WebGLLayerWebKitThread is not aware of that. This is because compositor
+layer of the WebGL graphics context was referenced outside the context.
+So when destructing GraphicsContext3D the compositing layer was not
+destructed.
+Fix by setting m_webGLContext to 0 when destructing GrapthicsContext3D
+after releasing the compositor layer, so that it won't be de-referenced
+again later.
+
+* platform/graphics/blackberry/GraphicsContext3DBlackBerry.cpp:
+(WebCore::GraphicsContext3D::~GraphicsContext3D):
+* platform/graphics/blackberry/WebGLLayerWebKitThread.cpp:
+(WebCore::WebGLLayerWebKitThread::~WebGLLayerWebKitThread):
+(WebCore::WebGLLayerWebKitThread::webGLContextDestroyed):
+(WebCore):
+* platform/graphics/blackberry/WebGLLayerWebKitThread.h:
+(WebGLLayerWebKitThread):
+
 2013-05-24  Andreas Kling  akl...@apple.com
 
 Typing in Safari's unified field causes unnecessary web content repaints.


Modified: trunk/Source/WebCore/platform/graphics/blackberry/GraphicsContext3DBlackBerry.cpp (150634 => 150635)

--- trunk/Source/WebCore/platform/graphics/blackberry/GraphicsContext3DBlackBerry.cpp	2013-05-24 07:32:54 UTC (rev 150634)
+++ trunk/Source/WebCore/platform/graphics/blackberry/GraphicsContext3DBlackBerry.cpp	2013-05-24 08:05:49 UTC (rev 150635)
@@ -127,7 +127,7 @@
 ::glDeleteFramebuffers(1, m_fbo);
 }
 
-m_compositingLayer = 0; // Must release compositing layer before destroying the context.
+static_castWebGLLayerWebKitThread *(m_compositingLayer.get())-webGLContextDestroyed(); // Must release compositing layer before destroying the context.
 BlackBerry::Platform::Graphics::destroyWebGLContext(m_context);
 }
 


Modified: trunk/Source/WebCore/platform/graphics/blackberry/WebGLLayerWebKitThread.cpp (150634 => 150635)

--- trunk/Source/WebCore/platform/graphics/blackberry/WebGLLayerWebKitThread.cpp	2013-05-24 07:32:54 UTC (rev 150634)
+++ trunk/Source/WebCore/platform/graphics/blackberry/WebGLLayerWebKitThread.cpp	2013-05-24 08:05:49 UTC (rev 150635)
@@ -34,8 +34,7 @@
 
 WebGLLayerWebKitThread::~WebGLLayerWebKitThread()
 {
-if (m_webGLContext  m_webGLContext-makeContextCurrent())
-deleteFrontBuffer();
+deleteTextures();
 }
 
 void WebGLLayerWebKitThread::updateTextureContentsIfNeeded()
@@ -54,6 +53,12 @@
 deleteFrontBuffer();
 }
 
+void WebGLLayerWebKitThread::webGLContextDestroyed()
+{
+deleteTextures();
+m_webGLContext = 0;
+}
+
 } // namespace WebCore
 
 #endif // USE(ACCELERATED_COMPOSITING)  ENABLE(WEBGL)


Modified: 

[webkit-changes] [150636] trunk/Tools

[sfalken]

Title: [150636] trunk/Tools








Revision 150636
Author sfal...@apple.com
Date 2013-05-24 01:41:00 -0700 (Fri, 24 May 2013)


Log Message
Update prepareConsistentTestingEnvironment to use a non-deprecated API.
https://bugs.webkit.org/show_bug.cgi?id=116710

Reviewed by Mark Rowe.

* DumpRenderTree/mac/DumpRenderTree.mm:
(prepareConsistentTestingEnvironment): Use beginActivityWithOptions instead of beginSuspensionOfSystemBehaviors.

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/DumpRenderTree/mac/DumpRenderTree.mm




Diff

Modified: trunk/Tools/ChangeLog (150635 => 150636)

--- trunk/Tools/ChangeLog	2013-05-24 08:05:49 UTC (rev 150635)
+++ trunk/Tools/ChangeLog	2013-05-24 08:41:00 UTC (rev 150636)
@@ -1,3 +1,13 @@
+2013-05-24  Steve Falkenburg  sfal...@apple.com
+
+Update prepareConsistentTestingEnvironment to use a non-deprecated API.
+https://bugs.webkit.org/show_bug.cgi?id=116710
+
+Reviewed by Mark Rowe.
+
+* DumpRenderTree/mac/DumpRenderTree.mm:
+(prepareConsistentTestingEnvironment): Use beginActivityWithOptions instead of beginSuspensionOfSystemBehaviors.
+
 2013-05-23  Lauro Neto  lauro.n...@openbossa.org
 
 Add missing dependencies to deps script.


Modified: trunk/Tools/DumpRenderTree/mac/DumpRenderTree.mm (150635 => 150636)

--- trunk/Tools/DumpRenderTree/mac/DumpRenderTree.mm	2013-05-24 08:05:49 UTC (rev 150635)
+++ trunk/Tools/DumpRenderTree/mac/DumpRenderTree.mm	2013-05-24 08:41:00 UTC (rev 150636)
@@ -860,8 +860,8 @@
 makeLargeMallocFailSilently();
 
 #if __MAC_OS_X_VERSION_MIN_REQUIRED = 1090
-static id assertion = [[[NSProcessInfo processInfo] beginSuspensionOfSystemBehaviors:NSSystemBehaviorCommonBehaviors
-reason:@DumpRenderTree should not be subject to process suppression] retain];
+NSActivityOptions options = (NSActivityUserInitiatedAllowingIdleSystemSleep | NSActivityLatencyCritical)  ~(NSActivitySuddenTerminationDisabled | NSActivityAutomaticTerminationDisabled);
+static id assertion = [[[NSProcessInfo processInfo] beginActivityWithOptions:options reason:@DumpRenderTree should not be subject to process suppression] retain];
 ASSERT_UNUSED(assertion, assertion);
 #endif
 }






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [150637] trunk/Source/WebKit/blackberry

[mifenton]

Title: [150637] trunk/Source/WebKit/blackberry








Revision 150637
Author mifen...@rim.com
Date 2013-05-24 05:47:18 -0700 (Fri, 24 May 2013)


Log Message
[BlackBerry] Respect tabindex when using form controls.
https://bugs.webkit.org/show_bug.cgi?id=116676

Reviewed by Xan Lopez.

PR 337419.

Update form control navigation tracking to take tabindex
order into account when calculating next and previous nodes.

The order to follow is tab index 1 - N, followed by all items
without a tab index or tab index 0 in rendering order to match
with standard desktop behavior.

Internally Reviewed by Genevieve Mak and Nima Ghanavatian.

* WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::InputHandler::updateFormState):

Modified Paths

trunk/Source/WebKit/blackberry/ChangeLog
trunk/Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp




Diff

Modified: trunk/Source/WebKit/blackberry/ChangeLog (150636 => 150637)

--- trunk/Source/WebKit/blackberry/ChangeLog	2013-05-24 08:41:00 UTC (rev 150636)
+++ trunk/Source/WebKit/blackberry/ChangeLog	2013-05-24 12:47:18 UTC (rev 150637)
@@ -1,3 +1,24 @@
+2013-05-24  Mike Fenton  mifen...@rim.com
+
+[BlackBerry] Respect tabindex when using form controls.
+https://bugs.webkit.org/show_bug.cgi?id=116676
+
+Reviewed by Xan Lopez.
+
+PR 337419.
+
+Update form control navigation tracking to take tabindex
+order into account when calculating next and previous nodes.
+
+The order to follow is tab index 1 - N, followed by all items
+without a tab index or tab index 0 in rendering order to match
+with standard desktop behavior.
+
+Internally Reviewed by Genevieve Mak and Nima Ghanavatian.
+
+* WebKitSupport/InputHandler.cpp:
+(BlackBerry::WebKit::InputHandler::updateFormState):
+
 2013-05-24  Jeff Rogers  jrog...@rim.com
 
 [BlackBerry] Remove SKIA leftovers from WebPage.cpp


Modified: trunk/Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp (150636 => 150637)

--- trunk/Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp	2013-05-24 08:41:00 UTC (rev 150636)
+++ trunk/Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp	2013-05-24 12:47:18 UTC (rev 150637)
@@ -947,35 +947,104 @@
 if (formElementCount  2)
 return;
 
-InputLog(Platform::LogLevelInfo, InputHandler::updateFormState form has %d fields, formElementCount);
+m_hasSubmitButton = true;
 
-m_hasSubmitButton = true;
+// Walk all elements in the form to determine next/prev elements.
+// For each element in the form we need to do the following:
+// If it's the focus node, use render order to try to find the next/prev directly.
+// For all other nodes:
+// 1) If the focused node has a specific tab index, compare the elements tab
+//index with the current prev/next looking for the best match.
+// 2) If the focused node does not have a tab index, update the maximum
+//tab index value, required for prev navigation.
+int focusTabIndex = static_castNode*(m_currentFocusElement.get())-tabIndex();
+int prevTabIndex = -1;
+int nextTabIndex = std::numeric_limitsshort::max() + 1;
+InputLog(Platform::LogLevelInfo, InputHandler::updateFormState form has %d fields and tabIndex %d, formElementCount, focusTabIndex);
+
+Element* firstInFieldWithoutTabIndex = 0;
+Element* highestTabIndexElement = 0;
 for (int focusElementId = 0; focusElementId  formElementCount; focusElementId++) {
-if (toHTMLElement(formElementList[focusElementId]) != m_currentFocusElement)
-continue;
+// Check for the focused element, and if we don't have any target nodes, use the form order next
+// and previous as placeholders. In a form without provided tab indices, this will determine the
+// control fields.
+Element* element = const_castHTMLElement*(toHTMLElement(formElementList[focusElementId]));
+if (element == m_currentFocusElement) {
+InputLog(Platform::LogLevelInfo, InputHandler::updateFormState found focused element.);
 
-// Found the focused element, get the next and previous elements if they exist.
+// If the focus tab index is set for the node, don't use the logical ordering.
+// Jump from last tab index to un-ordered is done separately.
+if (focusTabIndex)
+continue;
 
-// Previous
-for (int previousElementId = focusElementId - 1; previousElementId = 0; previousElementId--) {
-Element* element = const_castHTMLElement*(toHTMLElement(formElementList[previousElementId]));
-if (DOMSupport::isTextBasedContentEditableElement(element)  !DOMSupport::isElementReadOnly(element)) {
-m_previousFocusableTextElement = element;
-InputLog(Platform::LogLevelInfo, InputHandler::updateFormState found previous element);
-break;
+// Get the next/prev 

[webkit-changes] [150640] trunk/Tools

[commit-queue]

Title: [150640] trunk/Tools








Revision 150640
Author commit-qu...@webkit.org
Date 2013-05-24 07:48:21 -0700 (Fri, 24 May 2013)


Log Message
Update WTF::Vector pretty printers
https://bugs.webkit.org/show_bug.cgi?id=116719

Patch by Simon Pena simon.p...@samsung.com on 2013-05-24
Reviewed by Anders Carlsson.

After r148891, WTF::Vector pretty printers were left outdated, as
the WTF::Vector was made to extend a VectorBuffer, instead of keeping
one as a member. This patch updates the pretty printers so they work
again.

* gdb/webkit.py:
(WTFVectorPrinter.children):
(WTFVectorPrinter.to_string):

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/gdb/webkit.py




Diff

Modified: trunk/Tools/ChangeLog (150639 => 150640)

--- trunk/Tools/ChangeLog	2013-05-24 14:20:35 UTC (rev 150639)
+++ trunk/Tools/ChangeLog	2013-05-24 14:48:21 UTC (rev 150640)
@@ -1,3 +1,19 @@
+2013-05-24  Simon Pena  simon.p...@samsung.com
+
+Update WTF::Vector pretty printers
+https://bugs.webkit.org/show_bug.cgi?id=116719
+
+Reviewed by Anders Carlsson.
+
+After r148891, WTF::Vector pretty printers were left outdated, as
+the WTF::Vector was made to extend a VectorBuffer, instead of keeping
+one as a member. This patch updates the pretty printers so they work
+again. 
+
+* gdb/webkit.py:
+(WTFVectorPrinter.children):
+(WTFVectorPrinter.to_string):
+
 2013-05-24  Steve Falkenburg  sfal...@apple.com
 
 Update prepareConsistentTestingEnvironment to use a non-deprecated API.


Modified: trunk/Tools/gdb/webkit.py (150639 => 150640)

--- trunk/Tools/gdb/webkit.py	2013-05-24 14:20:35 UTC (rev 150639)
+++ trunk/Tools/gdb/webkit.py	2013-05-24 14:48:21 UTC (rev 150640)
@@ -261,12 +261,12 @@
 self.val = val
 
 def children(self):
-start = self.val['m_buffer']['m_buffer']
+start = self.val['m_buffer']
 return self.Iterator(start, start + self.val['m_size'])
 
 def to_string(self):
 return ('%s of length %d, capacity %d'
-% ('WTF::Vector', self.val['m_size'], self.val['m_buffer']['m_capacity']))
+% ('WTF::Vector', self.val['m_size'], self.val['m_capacity']))
 
 def display_hint(self):
 return 'array'






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [150641] trunk/Source/WebKit/blackberry

[mifenton]

Title: [150641] trunk/Source/WebKit/blackberry








Revision 150641
Author mifen...@rim.com
Date 2013-05-24 08:51:18 -0700 (Fri, 24 May 2013)


Log Message
[BlackBerry] Fix bad type warning in InputHandler log.
https://bugs.webkit.org/show_bug.cgi?id=116720

Reviewed by Carlos Garcia Campos.

Fix warning in inputLog string.

* WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::InputHandler::handleKeyboardInput):

Modified Paths

trunk/Source/WebKit/blackberry/ChangeLog
trunk/Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp




Diff

Modified: trunk/Source/WebKit/blackberry/ChangeLog (150640 => 150641)

--- trunk/Source/WebKit/blackberry/ChangeLog	2013-05-24 14:48:21 UTC (rev 150640)
+++ trunk/Source/WebKit/blackberry/ChangeLog	2013-05-24 15:51:18 UTC (rev 150641)
@@ -1,5 +1,17 @@
 2013-05-24  Mike Fenton  mifen...@rim.com
 
+[BlackBerry] Fix bad type warning in InputHandler log.
+https://bugs.webkit.org/show_bug.cgi?id=116720
+
+Reviewed by Carlos Garcia Campos.
+
+Fix warning in inputLog string.
+
+* WebKitSupport/InputHandler.cpp:
+(BlackBerry::WebKit::InputHandler::handleKeyboardInput):
+
+2013-05-24  Mike Fenton  mifen...@rim.com
+
 [BlackBerry] Respect tabindex when using form controls.
 https://bugs.webkit.org/show_bug.cgi?id=116676
 


Modified: trunk/Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp (150640 => 150641)

--- trunk/Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp	2013-05-24 14:48:21 UTC (rev 150640)
+++ trunk/Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp	2013-05-24 15:51:18 UTC (rev 150641)
@@ -1798,7 +1798,7 @@
 bool InputHandler::handleKeyboardInput(const Platform::KeyboardEvent keyboardEvent, bool changeIsPartOfComposition)
 {
 InputLog(Platform::LogLevelInfo,
-InputHandler::handleKeyboardInput received character='%lc', type=%d,
+InputHandler::handleKeyboardInput received character='%c', type=%d,
 keyboardEvent.character(), keyboardEvent.type());
 
 // Clearing the m_shouldNotifyWebView state on any KeyboardEvent.






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [150642] trunk/Source/WebCore

[robert]

Title: [150642] trunk/Source/WebCore








Revision 150642
Author rob...@webkit.org
Date 2013-05-24 09:18:16 -0700 (Fri, 24 May 2013)


Log Message
Refactor shouldAddBorderPaddingMargin()
https://bugs.webkit.org/show_bug.cgi?id=98803

Reviewed by Ryosuke Niwa.

Make this helper function less clever-stupid in its misguided sacrifice of intelligibility
for the sake of concision.

No new tests, refactoring.

* rendering/RenderBlockLineLayout.cpp:
(WebCore::shouldAddBorderPaddingMargin):
(WebCore::inlineLogicalWidth):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderBlockLineLayout.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (150641 => 150642)

--- trunk/Source/WebCore/ChangeLog	2013-05-24 15:51:18 UTC (rev 150641)
+++ trunk/Source/WebCore/ChangeLog	2013-05-24 16:18:16 UTC (rev 150642)
@@ -1,3 +1,19 @@
+2013-05-24  Robert Hogan  rob...@webkit.org
+
+Refactor shouldAddBorderPaddingMargin()
+https://bugs.webkit.org/show_bug.cgi?id=98803
+
+Reviewed by Ryosuke Niwa.
+
+Make this helper function less clever-stupid in its misguided sacrifice of intelligibility
+for the sake of concision.
+
+No new tests, refactoring.
+
+* rendering/RenderBlockLineLayout.cpp:
+(WebCore::shouldAddBorderPaddingMargin):
+(WebCore::inlineLogicalWidth):
+
 2013-05-24  Xiaobo Wang  xiaobw...@blackberry.com
 
 [BlackBerry] DRT - crashed on GraphicsContext3D::makeContextCurrent


Modified: trunk/Source/WebCore/rendering/RenderBlockLineLayout.cpp (150641 => 150642)

--- trunk/Source/WebCore/rendering/RenderBlockLineLayout.cpp	2013-05-24 15:51:18 UTC (rev 150641)
+++ trunk/Source/WebCore/rendering/RenderBlockLineLayout.cpp	2013-05-24 16:18:16 UTC (rev 150642)
@@ -348,12 +348,10 @@
 return child-marginEnd() + child-paddingEnd() + child-borderEnd();
 }
 
-static bool shouldAddBorderPaddingMargin(RenderObject* child, bool checkSide)
+static inline bool shouldAddBorderPaddingMargin(RenderObject* child)
 {
-if (!child || (child-isText()  !toRenderText(child)-textLength()))
-return true;
-checkSide = false;
-return checkSide;
+// When deciding whether we're at the edge of an inline, adjacent collapsed whitespace is the same as no sibling at all.
+return !child || (child-isText()  !toRenderText(child)-textLength());
 }
 
 static RenderObject* previousInFlowSibling(RenderObject* child)
@@ -364,7 +362,7 @@
 return child;
 }
 
-static LayoutUnit inlineLogicalWidth(RenderObject* child, bool start = true, bool end = true)
+static LayoutUnit inlineLogicalWidth(RenderObject* child, bool checkStartEdge = true, bool checkEndEdge = true)
 {
 unsigned lineDepth = 1;
 LayoutUnit extraWidth = 0;
@@ -372,11 +370,13 @@
 while (parent-isRenderInline()  lineDepth++  cMaxLineDepth) {
 RenderInline* parentAsRenderInline = toRenderInline(parent);
 if (!isEmptyInline(parentAsRenderInline)) {
-if (start  shouldAddBorderPaddingMargin(previousInFlowSibling(child), start))
+checkStartEdge = checkStartEdge  shouldAddBorderPaddingMargin(previousInFlowSibling(child));
+if (checkStartEdge)
 extraWidth += borderPaddingMarginStart(parentAsRenderInline);
-if (end  shouldAddBorderPaddingMargin(child-nextSibling(), end))
+checkEndEdge = checkEndEdge  shouldAddBorderPaddingMargin(child-nextSibling());
+if (checkEndEdge)
 extraWidth += borderPaddingMarginEnd(parentAsRenderInline);
-if (!start  !end)
+if (!checkStartEdge  !checkEndEdge)
 return extraWidth;
 }
 child = parent;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [150643] trunk

[commit-queue]

Title: [150643] trunk








Revision 150643
Author commit-qu...@webkit.org
Date 2013-05-24 09:34:46 -0700 (Fri, 24 May 2013)


Log Message
WebProcess is crashing on http://achicu.github.io/css-presentation when direct pattern compositing is enabled
https://bugs.webkit.org/show_bug.cgi?id=115135

Patch by Noam Rosenthal n...@webkit.org on 2013-05-24
Reviewed by Antti Koivisto.

Source/WebCore:

Issue is invoked when there is a visibility:hidden layer with a non-compositable
background image (e.g. a radial gradient).
The layer is treated as a no-contents layer because of its visibility, however
updateDirectlyCompositedBackgroundImage() later mistakenly treats it as a layer
with direct background-image compositing.

Fixed by returning early from updating directly composited contents for layers
with hidden contents.

Test: compositing/patterns/direct-pattern-compositing-hidden-radial-gradient.html

* rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::updateDirectlyCompositedContents):
(WebCore::RenderLayerBacking::updateDirectlyCompositedBackgroundImage):
(WebCore::RenderLayerBacking::paintsChildren):
(WebCore::RenderLayerBacking::isDirectlyCompositedImage):

LayoutTests:

Added a ref-test that makes sure that a layer with a hidden radial gradient does not
cause the web process to crash.

* compositing/patterns/direct-pattern-compositing-hidden-radial-gradient-expected.html: Added.
* compositing/patterns/direct-pattern-compositing-hidden-radial-gradient.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderLayerBacking.cpp


Added Paths

trunk/LayoutTests/compositing/patterns/direct-pattern-compositing-hidden-radial-gradient-expected.html
trunk/LayoutTests/compositing/patterns/direct-pattern-compositing-hidden-radial-gradient.html




Diff

Modified: trunk/LayoutTests/ChangeLog (150642 => 150643)

--- trunk/LayoutTests/ChangeLog	2013-05-24 16:18:16 UTC (rev 150642)
+++ trunk/LayoutTests/ChangeLog	2013-05-24 16:34:46 UTC (rev 150643)
@@ -1,3 +1,16 @@
+2013-05-24  Noam Rosenthal  n...@webkit.org
+
+WebProcess is crashing on http://achicu.github.io/css-presentation when direct pattern compositing is enabled
+https://bugs.webkit.org/show_bug.cgi?id=115135
+
+Reviewed by Antti Koivisto.
+
+Added a ref-test that makes sure that a layer with a hidden radial gradient does not
+cause the web process to crash.
+
+* compositing/patterns/direct-pattern-compositing-hidden-radial-gradient-expected.html: Added.
+* compositing/patterns/direct-pattern-compositing-hidden-radial-gradient.html: Added.
+
 2013-05-24  Gabor Abraham  ab...@inf.u-szeged.hu
 
 [Qt] Unreviewed gardening. Update qt-5.0-wk2 expected pictures after r150506.


Added: trunk/LayoutTests/compositing/patterns/direct-pattern-compositing-hidden-radial-gradient-expected.html (0 => 150643)

--- trunk/LayoutTests/compositing/patterns/direct-pattern-compositing-hidden-radial-gradient-expected.html	(rev 0)
+++ trunk/LayoutTests/compositing/patterns/direct-pattern-compositing-hidden-radial-gradient-expected.html	2013-05-24 16:34:46 UTC (rev 150643)
@@ -0,0 +1,14 @@
+html lang=en
+head
+  style
+.composited { -webkit-transform: rotate3d(0, 0, 1, 0); }
+.test {
+  height: 200px;
+  width: 260px;
+}
+   /style
+/head
+body
+  div class=test style=visibility: hidden; background-image: radial-gradient(black, white)/div
+/body
+/html


Added: trunk/LayoutTests/compositing/patterns/direct-pattern-compositing-hidden-radial-gradient.html (0 => 150643)

--- trunk/LayoutTests/compositing/patterns/direct-pattern-compositing-hidden-radial-gradient.html	(rev 0)
+++ trunk/LayoutTests/compositing/patterns/direct-pattern-compositing-hidden-radial-gradient.html	2013-05-24 16:34:46 UTC (rev 150643)
@@ -0,0 +1,14 @@
+html lang=en
+head
+  style
+.composited { -webkit-transform: rotate3d(0, 0, 1, 0); }
+.test {
+  height: 200px;
+  width: 260px;
+}
+   /style
+/head
+body
+  div class=test composited style=visibility: hidden; background-image: radial-gradient(black, white)/div
+/body
+/html


Modified: trunk/Source/WebCore/ChangeLog (150642 => 150643)

--- trunk/Source/WebCore/ChangeLog	2013-05-24 16:18:16 UTC (rev 150642)
+++ trunk/Source/WebCore/ChangeLog	2013-05-24 16:34:46 UTC (rev 150643)
@@ -1,3 +1,27 @@
+2013-05-24  Noam Rosenthal  n...@webkit.org
+
+WebProcess is crashing on http://achicu.github.io/css-presentation when direct pattern compositing is enabled
+https://bugs.webkit.org/show_bug.cgi?id=115135
+
+Reviewed by Antti Koivisto.
+
+Issue is invoked when there is a visibility:hidden layer with a non-compositable
+background image (e.g. a radial gradient).
+The layer is treated as a no-contents layer because of its visibility, however
+updateDirectlyCompositedBackgroundImage() later 

[webkit-changes] [150644] trunk/Source/JavaScriptCore

[commit-queue]

Title: [150644] trunk/Source/_javascript_Core








Revision 150644
Author commit-qu...@webkit.org
Date 2013-05-24 09:46:10 -0700 (Fri, 24 May 2013)


Log Message
[sh4] Optimize LLINT generated code and fix few bugs in baseline JIT.
https://bugs.webkit.org/show_bug.cgi?id=116716

Patch by Julien Brianceau jbrianc...@nds.com on 2013-05-24
Reviewed by Geoffrey Garen.

* assembler/MacroAssemblerSH4.h:
(JSC::MacroAssemblerSH4::mul32): Cosmetic changes.
(JSC::MacroAssemblerSH4::convertInt32ToDouble): Absolute address was not dereferenced.
(JSC::MacroAssemblerSH4::branch32): Absolute address was not dereferenced.
(JSC::MacroAssemblerSH4::revertJumpReplacementToBranchPtrWithPatch): Use all 32 bits of pointer for revertJump call.
* assembler/SH4Assembler.h:
(JSC::SH4Assembler::revertJump): Use changePCrelativeAddress to patch the whole pointer.
(JSC::SH4Assembler::linkJump): Cosmetic change.
* offlineasm/sh4.rb: Optimize LLINT generated code.

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/assembler/MacroAssemblerSH4.h
trunk/Source/_javascript_Core/assembler/SH4Assembler.h
trunk/Source/_javascript_Core/offlineasm/sh4.rb




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (150643 => 150644)

--- trunk/Source/_javascript_Core/ChangeLog	2013-05-24 16:34:46 UTC (rev 150643)
+++ trunk/Source/_javascript_Core/ChangeLog	2013-05-24 16:46:10 UTC (rev 150644)
@@ -1,3 +1,20 @@
+2013-05-24  Julien Brianceau  jbrianc...@nds.com
+
+[sh4] Optimize LLINT generated code and fix few bugs in baseline JIT.
+https://bugs.webkit.org/show_bug.cgi?id=116716
+
+Reviewed by Geoffrey Garen.
+
+* assembler/MacroAssemblerSH4.h:
+(JSC::MacroAssemblerSH4::mul32): Cosmetic changes.
+(JSC::MacroAssemblerSH4::convertInt32ToDouble): Absolute address was not dereferenced.
+(JSC::MacroAssemblerSH4::branch32): Absolute address was not dereferenced.
+(JSC::MacroAssemblerSH4::revertJumpReplacementToBranchPtrWithPatch): Use all 32 bits of pointer for revertJump call.
+* assembler/SH4Assembler.h:
+(JSC::SH4Assembler::revertJump): Use changePCrelativeAddress to patch the whole pointer.
+(JSC::SH4Assembler::linkJump): Cosmetic change.
+* offlineasm/sh4.rb: Optimize LLINT generated code.
+
 2013-05-23  Peter Wang  peter.w...@torchmobile.com.cn
 
 CLoop llint backend should not use the d8 register as scratch register


Modified: trunk/Source/_javascript_Core/assembler/MacroAssemblerSH4.h (150643 => 150644)

--- trunk/Source/_javascript_Core/assembler/MacroAssemblerSH4.h	2013-05-24 16:34:46 UTC (rev 150643)
+++ trunk/Source/_javascript_Core/assembler/MacroAssemblerSH4.h	2013-05-24 16:46:10 UTC (rev 150644)
@@ -232,9 +232,9 @@
 {
 RegisterID scr = claimScratch();
 move(imm, scr);
-if  (src != dest)
+if (src != dest)
 move(src, dest);
-mul32(scr,  dest);
+mul32(scr, dest);
 releaseScratch(scr);
 }
 
@@ -1137,7 +1137,7 @@
 void convertInt32ToDouble(AbsoluteAddress src, FPRegisterID dest)
 {
 RegisterID scr = claimScratch();
-m_assembler.loadConstant(reinterpret_castuint32_t(src.m_ptr), scr);
+load32(src.m_ptr, scr);
 convertInt32ToDouble(scr, dest);
 releaseScratch(scr);
 }
@@ -1661,7 +1661,7 @@
 {
 RegisterID scr = claimScratch();
 
-move(TrustedImm32(reinterpret_castuint32_t(left.m_ptr)), scr);
+load32(left.m_ptr, scr);
 m_assembler.cmplRegReg(right, scr, SH4Condition(cond));
 releaseScratch(scr);
 
@@ -2192,7 +2192,7 @@
 
 static void revertJumpReplacementToBranchPtrWithPatch(CodeLocationLabel instructionStart, RegisterID, void* initialValue)
 {
-SH4Assembler::revertJump(instructionStart.dataLocation(), reinterpret_castuintptr_t(initialValue)  0x);
+SH4Assembler::revertJump(instructionStart.dataLocation(), initialValue);
 }
 
 static CodeLocationLabel startOfPatchableBranchPtrWithPatchOnAddress(CodeLocationDataLabelPtr)


Modified: trunk/Source/_javascript_Core/assembler/SH4Assembler.h (150643 => 150644)

--- trunk/Source/_javascript_Core/assembler/SH4Assembler.h	2013-05-24 16:34:46 UTC (rev 150643)
+++ trunk/Source/_javascript_Core/assembler/SH4Assembler.h	2013-05-24 16:46:10 UTC (rev 150644)
@@ -1528,18 +1528,11 @@
 cacheFlush(instruction, sizeof(SH4Word) * nbinst);
 }
 
-static void revertJump(void* instructionStart, SH4Word imm)
+static void revertJump(void* instructionStart, void *immptr)
 {
 SH4Word *insn = reinterpret_castSH4Word*(instructionStart);
-SH4Word disp;
-
 ASSERT((insn[0]  0xf000) == MOVL_READ_OFFPC_OPCODE);
-
-disp = insn[0]  0x00ff;
-insn += 2 + (disp  1); // PC += 4 + (disp*4)
-insn = (SH4Word *) ((unsigned) insn  (~3));
-insn[0] = imm;
-cacheFlush(insn, sizeof(SH4Word));
+

[webkit-changes] [150645] trunk/LayoutTests

[commit-queue]

Title: [150645] trunk/LayoutTests








Revision 150645
Author commit-qu...@webkit.org
Date 2013-05-24 10:16:24 -0700 (Fri, 24 May 2013)


Log Message
Improve loader/go-back-cached-main-resource.html test
https://bugs.webkit.org/show_bug.cgi?id=116709

Patch by Manuel Rego Casasnovas r...@igalia.com on 2013-05-24
Reviewed by Alexey Proskuryakov.

It is only needed to register the listeners on the initial load as they
are already present when restoring from page cache. Modified the test to
use event.persisted property to know if we are handling the first load
in order to register the listeners only once.

* loader/resources/first-page.html: Rename registerListeners() function
to a more accurate name didShowPage() and use event.persisted to
register the listeners only in the first load.
* loader/resources/other-page.html: Ditto.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/loader/resources/first-page.html
trunk/LayoutTests/loader/resources/other-page.html




Diff

Modified: trunk/LayoutTests/ChangeLog (150644 => 150645)

--- trunk/LayoutTests/ChangeLog	2013-05-24 16:46:10 UTC (rev 150644)
+++ trunk/LayoutTests/ChangeLog	2013-05-24 17:16:24 UTC (rev 150645)
@@ -1,3 +1,20 @@
+2013-05-24  Manuel Rego Casasnovas  r...@igalia.com
+
+Improve loader/go-back-cached-main-resource.html test
+https://bugs.webkit.org/show_bug.cgi?id=116709
+
+Reviewed by Alexey Proskuryakov.
+
+It is only needed to register the listeners on the initial load as they
+are already present when restoring from page cache. Modified the test to
+use event.persisted property to know if we are handling the first load
+in order to register the listeners only once.
+
+* loader/resources/first-page.html: Rename registerListeners() function
+to a more accurate name didShowPage() and use event.persisted to
+register the listeners only in the first load.
+* loader/resources/other-page.html: Ditto.
+
 2013-05-24  Noam Rosenthal  n...@webkit.org
 
 WebProcess is crashing on http://achicu.github.io/css-presentation when direct pattern compositing is enabled


Modified: trunk/LayoutTests/loader/resources/first-page.html (150644 => 150645)

--- trunk/LayoutTests/loader/resources/first-page.html	2013-05-24 16:46:10 UTC (rev 150644)
+++ trunk/LayoutTests/loader/resources/first-page.html	2013-05-24 17:16:24 UTC (rev 150645)
@@ -1,23 +1,27 @@
 html
 head
 script
-function registerListeners() {
+function didShowPage() {
 // Notify opener.
 opener.postMessage('first-page', '*');
 
-// Our opener will tell us to perform various loads.
-window.addEventListener('message', function(event) {
+// We register the listeners in the initial load (this is not needed
+// when the page is restored from cache).
+if (!event.persisted) {
+// Our opener will tell us to perform various loads.
+window.addEventListener('message', function(event) {
 
-// Navigate to other page.
-if (event.data ="" 'navigate-other-page') {
-window.location = 'other-page.html';
-return;
-}
+// Navigate to other page.
+if (event.data ="" 'navigate-other-page') {
+window.location = 'other-page.html';
+return;
+}
 
-}, false);
+}, false);
+}
 }
 /script
 /head
-body _onpageshow_=registerListeners();
+body _onpageshow_=didShowPage();
 /body
 /html


Modified: trunk/LayoutTests/loader/resources/other-page.html (150644 => 150645)

--- trunk/LayoutTests/loader/resources/other-page.html	2013-05-24 16:46:10 UTC (rev 150644)
+++ trunk/LayoutTests/loader/resources/other-page.html	2013-05-24 17:16:24 UTC (rev 150645)
@@ -1,29 +1,33 @@
 html
 head
 script
-function registerListeners() {
+function didShowPage() {
 // Notify opener.
 opener.postMessage('other-page', '*');
 
-// Our opener will tell us to perform various loads.
-window.addEventListener('message', function(event) {
+// We register the listeners in the initial load (this is not needed
+// when the page is restored from cache).
+if (!event.persisted) {
+// Our opener will tell us to perform various loads.
+window.addEventListener('message', function(event) {
 
-// Navigate first resource.
-if (event.data ="" 'navigate-first-page') {
-window.location = 'first-page.html';
-return;
-}
+// Navigate first resource.
+if (event.data ="" 'navigate-first-page') {
+window.location = 'first-page.html';
+return;
+}
 
-// Navigate back.
-if (event.data ="" 'navigate-back') {
-

[webkit-changes] [150646] trunk/Source/WebCore

[commit-queue]

Title: [150646] trunk/Source/WebCore








Revision 150646
Author commit-qu...@webkit.org
Date 2013-05-24 10:28:38 -0700 (Fri, 24 May 2013)


Log Message
Path: upstream the missing bits from the BlackBerry port
https://bugs.webkit.org/show_bug.cgi?id=116658

Patch by Alberto Garcia agar...@igalia.com on 2013-05-24
Reviewed by Xan Lopez.

PathBlackBerry was upstreamed a while ago (r144612) but a few bits
were missing from the cross-platform code.

* platform/graphics/Path.cpp:
(WebCore::Path::addPathForRoundedRect):
* platform/graphics/Path.h:
(Graphics):
(Path):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/Path.cpp
trunk/Source/WebCore/platform/graphics/Path.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (150645 => 150646)

--- trunk/Source/WebCore/ChangeLog	2013-05-24 17:16:24 UTC (rev 150645)
+++ trunk/Source/WebCore/ChangeLog	2013-05-24 17:28:38 UTC (rev 150646)
@@ -1,3 +1,19 @@
+2013-05-24  Alberto Garcia  agar...@igalia.com
+
+Path: upstream the missing bits from the BlackBerry port
+https://bugs.webkit.org/show_bug.cgi?id=116658
+
+Reviewed by Xan Lopez.
+
+PathBlackBerry was upstreamed a while ago (r144612) but a few bits
+were missing from the cross-platform code.
+
+* platform/graphics/Path.cpp:
+(WebCore::Path::addPathForRoundedRect):
+* platform/graphics/Path.h:
+(Graphics):
+(Path):
+
 2013-05-24  Noam Rosenthal  n...@webkit.org
 
 WebProcess is crashing on http://achicu.github.io/css-presentation when direct pattern compositing is enabled


Modified: trunk/Source/WebCore/platform/graphics/Path.cpp (150645 => 150646)

--- trunk/Source/WebCore/platform/graphics/Path.cpp	2013-05-24 17:16:24 UTC (rev 150645)
+++ trunk/Source/WebCore/platform/graphics/Path.cpp	2013-05-24 17:28:38 UTC (rev 150646)
@@ -150,7 +150,7 @@
 return;
 }
 
-#if USE(CG)
+#if USE(CG) || PLATFORM(BLACKBERRY)
 platformAddPathForRoundedRect(rect, topLeftRadius, topRightRadius, bottomLeftRadius, bottomRightRadius);
 #else
 addBeziersForRoundedRect(rect, topLeftRadius, topRightRadius, bottomLeftRadius, bottomRightRadius);


Modified: trunk/Source/WebCore/platform/graphics/Path.h (150645 => 150646)

--- trunk/Source/WebCore/platform/graphics/Path.h	2013-05-24 17:16:24 UTC (rev 150645)
+++ trunk/Source/WebCore/platform/graphics/Path.h	2013-05-24 17:28:38 UTC (rev 150646)
@@ -47,6 +47,11 @@
 class PlatformPath;
 }
 typedef WebCore::PlatformPath PlatformPath;
+#elif PLATFORM(BLACKBERRY)
+namespace BlackBerry { namespace Platform { namespace Graphics {
+class Path;
+} } }
+typedef BlackBerry::Platform::Graphics::Path PlatformPath;
 #else
 typedef void PlatformPath;
 #endif
@@ -157,12 +162,12 @@
 void addPathForRoundedRect(const FloatRect, const FloatSize topLeftRadius, const FloatSize topRightRadius, const FloatSize bottomLeftRadius, const FloatSize bottomRightRadius, RoundedRectStrategy = PreferNativeRoundedRect);
 void addBeziersForRoundedRect(const FloatRect, const FloatSize topLeftRadius, const FloatSize topRightRadius, const FloatSize bottomLeftRadius, const FloatSize bottomRightRadius);
 
-#if USE(CG)
+#if USE(CG) || PLATFORM(BLACKBERRY)
 void platformAddPathForRoundedRect(const FloatRect, const FloatSize topLeftRadius, const FloatSize topRightRadius, const FloatSize bottomLeftRadius, const FloatSize bottomRightRadius);
 #endif
 
 #if PLATFORM(BLACKBERRY)
-Path(const SkPath);
+Path(const PlatformPath);
 #endif
 
 private:






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [150647] branches/safari-537.43-branch/Source

[lforschler]

Title: [150647] branches/safari-537.43-branch/Source








Revision 150647
Author lforsch...@apple.com
Date 2013-05-24 11:01:28 -0700 (Fri, 24 May 2013)


Log Message
Versioning.

Modified Paths

branches/safari-537.43-branch/Source/_javascript_Core/Configurations/Version.xcconfig
branches/safari-537.43-branch/Source/WebCore/Configurations/Version.xcconfig
branches/safari-537.43-branch/Source/WebKit/mac/Configurations/Version.xcconfig
branches/safari-537.43-branch/Source/WebKit2/Configurations/Version.xcconfig




Diff

Modified: branches/safari-537.43-branch/Source/_javascript_Core/Configurations/Version.xcconfig (150646 => 150647)

--- branches/safari-537.43-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2013-05-24 17:28:38 UTC (rev 150646)
+++ branches/safari-537.43-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2013-05-24 18:01:28 UTC (rev 150647)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 537;
 MINOR_VERSION = 43;
-TINY_VERSION = 1;
+TINY_VERSION = 2;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-537.43-branch/Source/WebCore/Configurations/Version.xcconfig (150646 => 150647)

--- branches/safari-537.43-branch/Source/WebCore/Configurations/Version.xcconfig	2013-05-24 17:28:38 UTC (rev 150646)
+++ branches/safari-537.43-branch/Source/WebCore/Configurations/Version.xcconfig	2013-05-24 18:01:28 UTC (rev 150647)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 537;
 MINOR_VERSION = 43;
-TINY_VERSION = 1;
+TINY_VERSION = 2;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-537.43-branch/Source/WebKit/mac/Configurations/Version.xcconfig (150646 => 150647)

--- branches/safari-537.43-branch/Source/WebKit/mac/Configurations/Version.xcconfig	2013-05-24 17:28:38 UTC (rev 150646)
+++ branches/safari-537.43-branch/Source/WebKit/mac/Configurations/Version.xcconfig	2013-05-24 18:01:28 UTC (rev 150647)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 537;
 MINOR_VERSION = 43;
-TINY_VERSION = 1;
+TINY_VERSION = 2;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-537.43-branch/Source/WebKit2/Configurations/Version.xcconfig (150646 => 150647)

--- branches/safari-537.43-branch/Source/WebKit2/Configurations/Version.xcconfig	2013-05-24 17:28:38 UTC (rev 150646)
+++ branches/safari-537.43-branch/Source/WebKit2/Configurations/Version.xcconfig	2013-05-24 18:01:28 UTC (rev 150647)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 537;
 MINOR_VERSION = 43;
-TINY_VERSION = 1;
+TINY_VERSION = 2;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [150648] trunk/Source/WebKit2

[andersca]

Title: [150648] trunk/Source/WebKit2








Revision 150648
Author ander...@apple.com
Date 2013-05-24 11:09:09 -0700 (Fri, 24 May 2013)


Log Message
Intermittent crash when typing in Address Bar
https://bugs.webkit.org/show_bug.cgi?id=116728
rdar://problem/13976781

Reviewed by Sam Weinig.

If a web process connection has been removed from the storage manager because we disconnected it
since there were no more active pages associated with the web process, we'll fail to find it here
so just return early instead of crashing.

* UIProcess/Storage/StorageManager.cpp:
(WebKit::StorageManager::destroyStorageMap):

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/Storage/StorageManager.cpp




Diff

Modified: trunk/Source/WebKit2/ChangeLog (150647 => 150648)

--- trunk/Source/WebKit2/ChangeLog	2013-05-24 18:01:28 UTC (rev 150647)
+++ trunk/Source/WebKit2/ChangeLog	2013-05-24 18:09:09 UTC (rev 150648)
@@ -1,3 +1,18 @@
+2013-05-24  Anders Carlsson  ander...@apple.com
+
+Intermittent crash when typing in Address Bar
+https://bugs.webkit.org/show_bug.cgi?id=116728
+rdar://problem/13976781
+
+Reviewed by Sam Weinig.
+
+If a web process connection has been removed from the storage manager because we disconnected it
+since there were no more active pages associated with the web process, we'll fail to find it here
+so just return early instead of crashing.
+
+* UIProcess/Storage/StorageManager.cpp:
+(WebKit::StorageManager::destroyStorageMap):
+
 2013-05-24  Andreas Kling  akl...@apple.com
 
 Typing in Safari's unified field causes unnecessary web content repaints.


Modified: trunk/Source/WebKit2/UIProcess/Storage/StorageManager.cpp (150647 => 150648)

--- trunk/Source/WebKit2/UIProcess/Storage/StorageManager.cpp	2013-05-24 18:01:28 UTC (rev 150647)
+++ trunk/Source/WebKit2/UIProcess/Storage/StorageManager.cpp	2013-05-24 18:09:09 UTC (rev 150648)
@@ -496,10 +496,11 @@
 ASSERT((HashMapstd::pairRefPtrCoreIPC::Connection, uint64_t, RefPtrStorageArea::isValidKey(connectionAndStorageMapIDPair)));
 
 HashMapstd::pairRefPtrCoreIPC::Connection, uint64_t, RefPtrStorageArea::iterator it = m_storageAreasByConnection.find(connectionAndStorageMapIDPair);
+if (it == m_storageAreasByConnection.end()) {
+// The connection has been removed because the last page was closed.
+return;
+}
 
-// FIXME: This should be a message check.
-ASSERT(it != m_storageAreasByConnection.end());
-
 it-value-removeListener(connection, storageMapID);
 m_storageAreasByConnection.remove(connectionAndStorageMapIDPair);
 }






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [150649] branches/safari-537.43-branch/Source/WebKit2

[lforschler]

Title: [150649] branches/safari-537.43-branch/Source/WebKit2








Revision 150649
Author lforsch...@apple.com
Date 2013-05-24 11:42:31 -0700 (Fri, 24 May 2013)


Log Message
Merged r150620.  rdar://problem/13938510

Modified Paths

branches/safari-537.43-branch/Source/WebKit2/ChangeLog
branches/safari-537.43-branch/Source/WebKit2/PluginProcess/PluginProcess.h
branches/safari-537.43-branch/Source/WebKit2/PluginProcess/mac/PluginProcessMac.mm
branches/safari-537.43-branch/Source/WebKit2/UIProcess/Plugins/PluginProcessProxy.cpp
branches/safari-537.43-branch/Source/WebKit2/UIProcess/Plugins/PluginProcessProxy.h
branches/safari-537.43-branch/Source/WebKit2/UIProcess/Plugins/PluginProcessProxy.messages.in
branches/safari-537.43-branch/Source/WebKit2/UIProcess/Plugins/mac/PluginProcessProxyMac.mm




Diff

Modified: branches/safari-537.43-branch/Source/WebKit2/ChangeLog (150648 => 150649)

--- branches/safari-537.43-branch/Source/WebKit2/ChangeLog	2013-05-24 18:09:09 UTC (rev 150648)
+++ branches/safari-537.43-branch/Source/WebKit2/ChangeLog	2013-05-24 18:42:31 UTC (rev 150649)
@@ -1,3 +1,42 @@
+2013-05-24  Lucas Forschler  lforsch...@apple.com
+
+Merge r150620
+
+2013-05-23  Anders Carlsson  ander...@apple.com
+
+Shim Flash plug-in to allow its updater to run
+https://bugs.webkit.org/show_bug.cgi?id=116692
+rdar://problem/13938510
+
+Reviewed by Sam Weinig.
+
+* PluginProcess/PluginProcess.h:
+* PluginProcess/mac/PluginProcessMac.mm:
+(WebKit::replacedNSConcreteTask_launch):
+(WebKit::initializeCocoaOverrides):
+Patch -[NSConcreteTask launch] to call PluginProcess::launchProcess.
+
+(WebKit::PluginProcess::launchProcess):
+Send a LaunchProcess message to the UI process.
+
+* UIProcess/Plugins/PluginProcessProxy.cpp:
+* UIProcess/Plugins/PluginProcessProxy.h:
+Remove PluginProcessProxy::didReceiveMessage.
+
+(PluginProcessProxy):
+* UIProcess/Plugins/PluginProcessProxy.messages.in:
+Add LaunchProcess message and remove LegacyReceiver attribute.
+
+* UIProcess/Plugins/mac/PluginProcessProxyMac.mm:
+(WebKit::isFlashUpdater):
+Helper function to determine whether the process is the flash updater.
+
+(WebKit::shouldLaunchProcess):
+Return whether we should launch this process.
+
+(WebKit::PluginProcessProxy::launchProcess):
+Determine if we should launch this process and then do so.
+
 2013-05-23  Lucas Forschler  lforsch...@apple.com
 
 Merge r150610


Modified: branches/safari-537.43-branch/Source/WebKit2/PluginProcess/PluginProcess.h (150648 => 150649)

--- branches/safari-537.43-branch/Source/WebKit2/PluginProcess/PluginProcess.h	2013-05-24 18:09:09 UTC (rev 150648)
+++ branches/safari-537.43-branch/Source/WebKit2/PluginProcess/PluginProcess.h	2013-05-24 18:42:31 UTC (rev 150649)
@@ -56,6 +56,8 @@
 #if USE(ACCELERATED_COMPOSITING)
 mach_port_t compositingRenderServerPort() const { return m_compositingRenderServerPort; }
 #endif
+
+bool launchProcess(const String launchPath, const VectorString arguments);
 #endif
 
 private:


Modified: branches/safari-537.43-branch/Source/WebKit2/PluginProcess/mac/PluginProcessMac.mm (150648 => 150649)

--- branches/safari-537.43-branch/Source/WebKit2/PluginProcess/mac/PluginProcessMac.mm	2013-05-24 18:09:09 UTC (rev 150648)
+++ branches/safari-537.43-branch/Source/WebKit2/PluginProcess/mac/PluginProcessMac.mm	2013-05-24 18:42:31 UTC (rev 150649)
@@ -29,6 +29,7 @@
 
 #if ENABLE(PLUGIN_PROCESS)
 
+#import ArgumentCoders.h
 #import NetscapePlugin.h
 #import PluginProcessCreationParameters.h
 #import PluginProcessProxyMessages.h
@@ -249,8 +250,30 @@
 }
 #endif
 
+static IMP NSConcreteTask_launch;
+
+static void replacedNSConcreteTask_launch(NSTask *self, SEL _cmd)
+{
+String launchPath = self.launchPath;
+
+VectorString arguments;
+arguments.reserveInitialCapacity(self.arguments.count);
+for (NSString *argument in self.arguments)
+arguments.uncheckedAppend(argument);
+
+if (PluginProcess::shared().launchProcess(launchPath, arguments))
+return;
+
+NSConcreteTask_launch(self, _cmd);
+}
+
 static void initializeCocoaOverrides()
 {
+// Override -[NSConcreteTask launch:]
+Method launchMethod = class_getInstanceMethod(objc_getClass(NSConcreteTask), @selector(launch));
+
+NSConcreteTask_launch = method_setImplementation(launchMethod, reinterpret_castIMP(replacedNSConcreteTask_launch));
+
 // Override -[NSApplication runModalForWindow:]
 Method runModalForWindowMethod = class_getInstanceMethod(objc_getClass(NSApplication), @selector(runModalForWindow:));
 NSApplication_RunModalForWindow = method_setImplementation(runModalForWindowMethod, reinterpret_castIMP(replacedRunModalForWindow));
@@ -283,6 +306,15 @@
 

[webkit-changes] [150650] branches/safari-537.43-branch/Source/WebCore

[lforschler]

Title: [150650] branches/safari-537.43-branch/Source/WebCore








Revision 150650
Author lforsch...@apple.com
Date 2013-05-24 11:46:41 -0700 (Fri, 24 May 2013)


Log Message
Merged r150631.  rdar://problem/13963712

Modified Paths

branches/safari-537.43-branch/Source/WebCore/ChangeLog
branches/safari-537.43-branch/Source/WebCore/rendering/RenderLayer.cpp




Diff

Modified: branches/safari-537.43-branch/Source/WebCore/ChangeLog (150649 => 150650)

--- branches/safari-537.43-branch/Source/WebCore/ChangeLog	2013-05-24 18:42:31 UTC (rev 150649)
+++ branches/safari-537.43-branch/Source/WebCore/ChangeLog	2013-05-24 18:46:41 UTC (rev 150650)
@@ -1,3 +1,20 @@
+2013-05-24  Lucas Forschler  lforsch...@apple.com
+
+Merge r150631
+
+2013-05-23  Beth Dakin  bda...@apple.com
+
+https://bugs.webkit.org/show_bug.cgi?id=116702
+REGRESSION (r150399): Scrollbar missing for all overflow scroll
+-and corresponding-
+rdar://problem/13963712
+
+Reviewed by Simon Fraser.
+
+This was a silly copy-paste error.
+* rendering/RenderLayer.cpp:
+(WebCore::RenderLayer::scrollbarAnimationsAreSuppressed):
+
 2013-05-23  Lucas Forschler  lforsch...@apple.com
 
 Merge r150556


Modified: branches/safari-537.43-branch/Source/WebCore/rendering/RenderLayer.cpp (150649 => 150650)

--- branches/safari-537.43-branch/Source/WebCore/rendering/RenderLayer.cpp	2013-05-24 18:42:31 UTC (rev 150649)
+++ branches/safari-537.43-branch/Source/WebCore/rendering/RenderLayer.cpp	2013-05-24 18:46:41 UTC (rev 150650)
@@ -1400,7 +1400,7 @@
 RenderView* view = renderer()-view();
 if (!view)
 return false;
-return view-frameView()-scrollbarsCanBeActive();
+return view-frameView()-scrollbarAnimationsAreSuppressed();
 }
 
 RenderLayer* RenderLayer::enclosingTransformedAncestor() const






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [150653] trunk/Source

[commit-queue]

Title: [150653] trunk/Source








Revision 150653
Author commit-qu...@webkit.org
Date 2013-05-24 12:41:37 -0700 (Fri, 24 May 2013)


Log Message
Add more lines to the context during Dictionary lookups
https://bugs.webkit.org/show_bug.cgi?id=115256

Patch by Thomas Deniau den...@apple.com on 2013-05-24
Reviewed by Ryosuke Niwa.

Source/WebCore:

No new tests - no new functionality.

* WebCore.exp.in: Export a few methods in VisibleUnits needed to be able
to call previousLinePosition(), nextLinePosition(), startOfLine() and
endOfLine() in WebPageMac.mm when determining the context while looking
up a dictionary definition. These symbols used to be exported for iOS
only, export them on the desktop too.

Source/WebKit2:

* WebProcess/WebPage/mac/WebPageMac.mm:
(WebKit::WebPage::performDictionaryLookupAtLocation):
Instead of using the current paragraph as the context (which stops at
line breaks), get a few lines before and after the point, so that the
context contains at least four lines in each direction.
This way the Dictionary will be able to look up things that extend past
the current line.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/WebCore.exp.in
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/WebProcess/WebPage/mac/WebPageMac.mm




Diff

Modified: trunk/Source/WebCore/ChangeLog (150652 => 150653)

--- trunk/Source/WebCore/ChangeLog	2013-05-24 19:07:02 UTC (rev 150652)
+++ trunk/Source/WebCore/ChangeLog	2013-05-24 19:41:37 UTC (rev 150653)
@@ -1,3 +1,18 @@
+2013-05-24  Thomas Deniau  den...@apple.com
+
+Add more lines to the context during Dictionary lookups
+https://bugs.webkit.org/show_bug.cgi?id=115256
+
+Reviewed by Ryosuke Niwa.
+
+No new tests - no new functionality.
+
+* WebCore.exp.in: Export a few methods in VisibleUnits needed to be able
+to call previousLinePosition(), nextLinePosition(), startOfLine() and
+endOfLine() in WebPageMac.mm when determining the context while looking
+up a dictionary definition. These symbols used to be exported for iOS
+only, export them on the desktop too.
+
 2013-05-24  Anders Carlsson  ander...@apple.com
 
 Remove PagePopup code


Modified: trunk/Source/WebCore/WebCore.exp.in (150652 => 150653)

--- trunk/Source/WebCore/WebCore.exp.in	2013-05-24 19:07:02 UTC (rev 150652)
+++ trunk/Source/WebCore/WebCore.exp.in	2013-05-24 19:41:37 UTC (rev 150653)
@@ -168,6 +168,7 @@
 __ZN7WebCore11URLWithDataEP6NSDataP5NSURL
 __ZN7WebCore11iBeamCursorEv
 __ZN7WebCore11memoryCacheEv
+__ZN7WebCore11startOfLineERKNS_15VisiblePositionE
 __ZN7WebCore11startOfWordERKNS_15VisiblePositionENS_9EWordSideE
 __ZN7WebCore11writeToFileEiPKci
 __ZN7WebCore12ChromeClient23paintCustomOverhangAreaEPNS_15GraphicsContextERKNS_7IntRectES5_S5_
@@ -566,6 +567,7 @@
 __ZN7WebCore16enclosingIntRectERKNS_9FloatRectE
 __ZN7WebCore16isEndOfParagraphERKNS_15VisiblePositionENS_27EditingBoundaryCrossingRuleE
 __ZN7WebCore16isUserVisibleURLEP8NSString
+__ZN7WebCore16nextLinePositionERKNS_15VisiblePositionEiNS_12EditableTypeE
 __ZN7WebCore16scriptNameToCodeERKN3WTF6StringE
 __ZN7WebCore16startOfParagraphERKNS_15VisiblePositionENS_27EditingBoundaryCrossingRuleE
 __ZN7WebCore17CredentialStorage24getFromPersistentStorageERKNS_15ProtectionSpaceE
@@ -686,6 +688,7 @@
 __ZN7WebCore20UserGestureIndicatorD1Ev
 __ZN7WebCore20deleteEmptyDirectoryERKN3WTF6StringE
 __ZN7WebCore20makeRGBA32FromFloatsE
+__ZN7WebCore20previousLinePositionERKNS_15VisiblePositionEiNS_12EditableTypeE
 __ZN7WebCore20protocolIsJavaScriptERKN3WTF6StringE
 __ZN7WebCore20toUInt32EnforceRangeEPN3JSC9ExecStateENS0_7JSValueE
 __ZN7WebCore21BackForwardController11itemAtIndexEi
@@ -1264,6 +1267,7 @@
 __ZN7WebCore9TimerBaseC2Ev
 __ZN7WebCore9TimerBaseD2Ev
 __ZN7WebCore9closeFileERi
+__ZN7WebCore9endOfLineERKNS_15VisiblePositionE
 __ZN7WebCore9endOfWordERKNS_15VisiblePositionENS_9EWordSideE
 __ZN7WebCore9fontCacheEv
 __ZN7WebCore9makeRangeERKNS_15VisiblePositionES2_
@@ -1449,6 +1453,7 @@
 __ZNK7WebCore15VisiblePosition14characterAfterEv
 __ZNK7WebCore15VisiblePosition14localCaretRectERPNS_12RenderObjectE
 __ZNK7WebCore15VisiblePosition19absoluteCaretBoundsEv
+__ZNK7WebCore15VisiblePosition45lineDirectionPointForBlockDirectionNavigationEv
 __ZNK7WebCore15VisiblePosition4nextENS_27EditingBoundaryCrossingRuleE
 __ZNK7WebCore15VisiblePosition8previousENS_27EditingBoundaryCrossingRuleE
 __ZNK7WebCore16EventListenerMap8containsERKN3WTF12AtomicStringE
@@ -1638,6 +1643,7 @@
 __ZNK7WebCore8Position24parentAnchoredEquivalentEv
 __ZNK7WebCore8Position25leadingWhitespacePositionENS_9EAffinityEb
 __ZNK7WebCore8Position26trailingWhitespacePositionENS_9EAffinityEb
+__ZNK7WebCore8Position28offsetForPositionAfterAnchorEv
 __ZNK7WebCore8Position8upstreamENS_27EditingBoundaryCrossingRuleE
 __ZNK7WebCore9DOMWindow27pendingUnloadEventListenersEv
 __ZNK7WebCore9FloatQuad11boundingBoxEv
@@ -2070,7 +2076,6 @@
 __ZN7WebCore11MemoryCache18pruneLiveResourcesEb
 

[webkit-changes] [150654] trunk/LayoutTests

[g . czajkowski]

Title: [150654] trunk/LayoutTests








Revision 150654
Author g.czajkow...@samsung.com
Date 2013-05-24 12:43:41 -0700 (Fri, 24 May 2013)


Log Message
[WK2] Spelling tests gardening
https://bugs.webkit.org/show_bug.cgi?id=116718

Unreviewed gardening.

The most spelling tests are skipped for wk2 platforms and they have deprecated comments.
Move the tests from global wk2/TestExpectations to the ports' TestExpectations as
the core spellchecking implementation is delivered for wk2.
This change will allow to run spelling tests easier and using [ Pass ] keyword
in TestExpectations won't be needed.


* platform/efl-wk2/TestExpectations:
* platform/gtk-wk2/TestExpectations:
* platform/mac-wk2/TestExpectations:
* platform/qt-5.0-wk2/TestExpectations:
* platform/wk2/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/efl-wk2/TestExpectations
trunk/LayoutTests/platform/gtk-wk2/TestExpectations
trunk/LayoutTests/platform/mac-wk2/TestExpectations
trunk/LayoutTests/platform/qt-5.0-wk2/TestExpectations
trunk/LayoutTests/platform/wk2/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (150653 => 150654)

--- trunk/LayoutTests/ChangeLog	2013-05-24 19:41:37 UTC (rev 150653)
+++ trunk/LayoutTests/ChangeLog	2013-05-24 19:43:41 UTC (rev 150654)
@@ -1,3 +1,22 @@
+2013-05-24  Grzegorz Czajkowski  g.czajkow...@samsung.com
+
+[WK2] Spelling tests gardening
+https://bugs.webkit.org/show_bug.cgi?id=116718
+
+Unreviewed gardening.
+
+The most spelling tests are skipped for wk2 platforms and they have deprecated comments.
+Move the tests from global wk2/TestExpectations to the ports' TestExpectations as
+the core spellchecking implementation is delivered for wk2.
+This change will allow to run spelling tests easier and using [ Pass ] keyword
+in TestExpectations won't be needed.
+
+* platform/efl-wk2/TestExpectations:
+* platform/gtk-wk2/TestExpectations:
+* platform/mac-wk2/TestExpectations:
+* platform/qt-5.0-wk2/TestExpectations:
+* platform/wk2/TestExpectations:
+
 2013-05-24  Anders Carlsson  ander...@apple.com
 
 Remove PagePopup code


Modified: trunk/LayoutTests/platform/efl-wk2/TestExpectations (150653 => 150654)

--- trunk/LayoutTests/platform/efl-wk2/TestExpectations	2013-05-24 19:41:37 UTC (rev 150653)
+++ trunk/LayoutTests/platform/efl-wk2/TestExpectations	2013-05-24 19:43:41 UTC (rev 150654)
@@ -33,19 +33,6 @@
 #
 # PASSING TESTS
 #
-editing/spelling/design-mode-spellcheck-off.html [ Pass ]
-editing/spelling/spellcheck-api-crash.html [ Pass ]
-editing/spelling/spellcheck-attribute.html [ Pass ]
-editing/spelling/spellcheck-input-search-crash.html [ Pass ]
-editing/spelling/spelling-attribute-at-child.html [ Pass ]
-editing/spelling/spelling-attribute-change.html [ Pass ]
-editing/spelling/spelling-backspace-between-lines.html [ Pass ]
-editing/spelling/spelling-double-clicked-word.html [ Pass ]
-editing/spelling/spelling-exactly-selected-word.html [ Pass ]
-editing/spelling/spelling-hasspellingmarker.html [ Pass ]
-editing/spelling/spelling-linebreak.html [ Pass ]
-editing/spelling/spelling-with-punctuation-selection.html [ Pass ]
-editing/spelling/spelling-with-whitespace-selection.html [ Pass ]
 
 #
 # TESTS EXPECTED TO FAIL
@@ -298,6 +285,7 @@
 Bug(EFL) fast/events/touch/basic-single-touch-events.html [ Failure ]
 
 # Needs grammar checking
+Bug(EFL) editing/spelling/grammar.html [ Failure ]
 Bug(EFL) editing/spelling/grammar-edit-word.html [ Failure ]
 Bug(EFL) editing/spelling/grammar-markers.html [ Failure ]
 Bug(EFL) editing/spelling/grammar-markers-hidpi.html [ Failure ]
@@ -309,7 +297,6 @@
 
 # WK2's contextClick() returns array of objects instead of strings.
 editing/spelling/spelling-exactly-selected-multiple-words.html [ Failure ]
-editing/spelling/spelling-exactly-selected-word.html [ Failure ]
 editing/spelling/spelling-multiword-selection.html [ Failure ]
 editing/spelling/spelling-should-select-multiple-words.html [ Failure ]
 editing/spelling/spelling-subword-selection.html [ Failure ]


Modified: trunk/LayoutTests/platform/gtk-wk2/TestExpectations (150653 => 150654)

--- trunk/LayoutTests/platform/gtk-wk2/TestExpectations	2013-05-24 19:41:37 UTC (rev 150653)
+++ trunk/LayoutTests/platform/gtk-wk2/TestExpectations	2013-05-24 19:43:41 UTC (rev 150654)
@@ -190,6 +190,24 @@
 Bug(GTK) editing/spelling/spellcheck-sequencenum.html [ Skip ]
 Bug(GTK) editing/spelling/spelling-marker-description.html [ Skip ]
 
+# Spellcheck tests don't seem to work.
+Bug(GTK) editing/spelling/spelling-backspace-between-lines.html [ Skip ]
+Bug(GTK) editing/spelling/design-mode-spellcheck-off.html [ Skip 

[webkit-changes] [150655] trunk/LayoutTests

[sergio]

Title: [150655] trunk/LayoutTests








Revision 150655
Author ser...@webkit.org
Date 2013-05-24 13:07:02 -0700 (Fri, 24 May 2013)


Log Message
REGRESSION (r150215): broke a test case in inspector/console/console-css-warnings.html
https://bugs.webkit.org/show_bug.cgi?id=116731

Reviewed by Ryosuke Niwa.

The mentioned revision removed a layering violation added just to
support some IE7 hack. That was removed but the test case
supporting it was left untouched, remove it.

* inspector/console/console-css-warnings-expected.txt:
* inspector/console/console-css-warnings.html:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/inspector/console/console-css-warnings-expected.txt
trunk/LayoutTests/inspector/console/console-css-warnings.html




Diff

Modified: trunk/LayoutTests/ChangeLog (150654 => 150655)

--- trunk/LayoutTests/ChangeLog	2013-05-24 19:43:41 UTC (rev 150654)
+++ trunk/LayoutTests/ChangeLog	2013-05-24 20:07:02 UTC (rev 150655)
@@ -1,3 +1,17 @@
+2013-05-24  Sergio Villar Senin  svil...@igalia.com
+
+REGRESSION (r150215): broke a test case in inspector/console/console-css-warnings.html
+https://bugs.webkit.org/show_bug.cgi?id=116731
+
+Reviewed by Ryosuke Niwa.
+
+The mentioned revision removed a layering violation added just to
+support some IE7 hack. That was removed but the test case
+supporting it was left untouched, remove it.
+
+* inspector/console/console-css-warnings-expected.txt:
+* inspector/console/console-css-warnings.html:
+
 2013-05-24  Grzegorz Czajkowski  g.czajkow...@samsung.com
 
 [WK2] Spelling tests gardening


Modified: trunk/LayoutTests/inspector/console/console-css-warnings-expected.txt (150654 => 150655)

--- trunk/LayoutTests/inspector/console/console-css-warnings-expected.txt	2013-05-24 19:43:41 UTC (rev 150654)
+++ trunk/LayoutTests/inspector/console/console-css-warnings-expected.txt	2013-05-24 20:07:02 UTC (rev 150655)
@@ -10,6 +10,5 @@
 Unexpected CSS token: { console-css-warnings.html:38
 Unexpected CSS token: { console-css-warnings.html:39
 Unexpected CSS token: { console-css-warnings.html:40
-Unexpected CSS token: @ console-css-warnings.html:45
-Unexpected CSS token: @ console-css-warnings.html:49
+Unexpected CSS token: @ console-css-warnings.html:44
 


Modified: trunk/LayoutTests/inspector/console/console-css-warnings.html (150654 => 150655)

--- trunk/LayoutTests/inspector/console/console-css-warnings.html	2013-05-24 19:43:41 UTC (rev 150654)
+++ trunk/LayoutTests/inspector/console/console-css-warnings.html	2013-05-24 20:07:02 UTC (rev 150655)
@@ -41,11 +41,6 @@
 }
 
 x {
-*zoom: @1;  /* IE hack. Ignored */
-color: @;
-}
-
-x {
 color: @;  /* Test simple error to ensure parsing recovered. */
 }
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [150656] trunk/Source/WebCore

[commit-queue]

Title: [150656] trunk/Source/WebCore








Revision 150656
Author commit-qu...@webkit.org
Date 2013-05-24 13:26:00 -0700 (Fri, 24 May 2013)


Log Message
[AC] Needs to be guarded by USE(ACCELERATED_COMPOSITING)
https://bugs.webkit.org/show_bug.cgi?id=116712

Patch by Seokju Kwon seokju.k...@gmail.com on 2013-05-24
Reviewed by Andreas Kling.

renderView is used when ACCELERATED_COMPOSITING is enabled.
So, this patch allows it to be guarded by USE(ACCELERATED_COMPOSITING).

No new tests, no behavior change.

* page/FrameView.cpp:
(WebCore::FrameView::setFrameRect):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/FrameView.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (150655 => 150656)

--- trunk/Source/WebCore/ChangeLog	2013-05-24 20:07:02 UTC (rev 150655)
+++ trunk/Source/WebCore/ChangeLog	2013-05-24 20:26:00 UTC (rev 150656)
@@ -1,3 +1,18 @@
+2013-05-24  Seokju Kwon  seokju.k...@gmail.com
+
+[AC] Needs to be guarded by USE(ACCELERATED_COMPOSITING)
+https://bugs.webkit.org/show_bug.cgi?id=116712
+
+Reviewed by Andreas Kling.
+
+renderView is used when ACCELERATED_COMPOSITING is enabled.
+So, this patch allows it to be guarded by USE(ACCELERATED_COMPOSITING).
+
+No new tests, no behavior change.
+
+* page/FrameView.cpp:
+(WebCore::FrameView::setFrameRect):
+
 2013-05-24  Thomas Deniau  den...@apple.com
 
 Add more lines to the context during Dictionary lookups


Modified: trunk/Source/WebCore/page/FrameView.cpp (150655 => 150656)

--- trunk/Source/WebCore/page/FrameView.cpp	2013-05-24 20:07:02 UTC (rev 150655)
+++ trunk/Source/WebCore/page/FrameView.cpp	2013-05-24 20:26:00 UTC (rev 150656)
@@ -469,10 +469,8 @@
 
 updateScrollableAreaSet();
 
-RenderView* renderView = this-renderView();
-
 #if USE(ACCELERATED_COMPOSITING)
-if (renderView) {
+if (RenderView* renderView = this-renderView()) {
 if (renderView-usesCompositing())
 renderView-compositor()-frameViewDidChangeSize();
 }






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [150657] branches/dfgFourthTier/Source/JavaScriptCore

[fpizlo]

Title: [150657] branches/dfgFourthTier/Source/_javascript_Core








Revision 150657
Author fpi...@apple.com
Date 2013-05-24 14:06:07 -0700 (Fri, 24 May 2013)


Log Message
fourthTier: add heuristics to reduce the likelihood of a trivially inlineable function being independently compiled by the concurrent JIT
https://bugs.webkit.org/show_bug.cgi?id=116557

Reviewed by Geoffrey Garen.

This introduces a fairly comprehensive mechanism for preventing trivially inlineable
functions from being compiled independently of all of the things into which they end
up being inlined.

The trick is CodeBlock::m_shouldAlwaysBeInlined, or SABI for short (that's what the
debug logging calls it). A SABI function is one that we currently believe should
never be DFG optimized because it should always be inlined into the functions that
call it. SABI follows innocent until proven guilty: all functions start out SABI
and have SABI set to false if we see proof that that function may be called in some
possibly non-inlineable way. So long as a function is SABI, it will not tier up to
the DFG: cti_optimize will perpetually postpone its optimization. Because SABI has
such a severe effect, we make the burden of proof of guilt quite low. SABI gets
cleared if any of the following happen:

- You get called from native code (either through CallData or CachedCall).

- You get called from an eval, since eval code takes a long time to get DFG
  optimized.

- You get called from global code, since often global code doesn't tier-up since
  it's run-once.

- You get called recursively, where recursion is detected by a stack walk of depth
  Options::maximumInliningDepth().

- You get called through an unlinked virtual call.

- You get called from DFG code, since if the caller was already DFG optimized and
  didn't inline you then obviously, you might not get inlined.

- You've tiered up to the baseline JIT and you get called from the interpreter.
  The idea here is that this kind of ensures that you stay SABI only if you're
  called no more frequently than any of your callers.

- You get called from a code block that isn't a DFG candidate.

- You aren't an inlining candidate.

Most of the heuristics for SABI are in CodeBlock::noticeIncomingCall().

This is neutral on SunSpider and V8Spider, and appears to be a slight speed-up on
V8v7, which was previously adversely affected by concurrent compilation. I also
confirmed that for example on V8/richards, it dramatically reduces the number of
code blocks that get DFG compiled. It is a speed-up on those V8v7 benchmarks that
saw regressions from concurrent compilation.

* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::dumpAssumingJITType):
(JSC::CodeBlock::CodeBlock):
(JSC::CodeBlock::linkIncomingCall):
(JSC):
(JSC::CodeBlock::noticeIncomingCall):
* bytecode/CodeBlock.h:
(CodeBlock):
* dfg/DFGCapabilities.h:
(JSC::DFG::mightInlineFunction):
(DFG):
* dfg/DFGPlan.cpp:
(JSC::DFG::Plan::compileInThread):
* dfg/DFGRepatch.cpp:
(JSC::DFG::dfgLinkFor):
* interpreter/Interpreter.cpp:
(JSC::Interpreter::executeCall):
(JSC::Interpreter::executeConstruct):
(JSC::Interpreter::prepareForRepeatCall):
* jit/JIT.cpp:
(JSC::JIT::privateCompile):
(JSC::JIT::linkFor):
* jit/JIT.h:
(JIT):
* jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
(JSC::lazyLinkFor):
* llint/LLIntSlowPaths.cpp:
(JSC::LLInt::setUpCall):

Modified Paths

branches/dfgFourthTier/Source/_javascript_Core/ChangeLog
branches/dfgFourthTier/Source/_javascript_Core/bytecode/CodeBlock.cpp
branches/dfgFourthTier/Source/_javascript_Core/bytecode/CodeBlock.h
branches/dfgFourthTier/Source/_javascript_Core/dfg/DFGCapabilities.h
branches/dfgFourthTier/Source/_javascript_Core/dfg/DFGPlan.cpp
branches/dfgFourthTier/Source/_javascript_Core/dfg/DFGRepatch.cpp
branches/dfgFourthTier/Source/_javascript_Core/interpreter/Interpreter.cpp
branches/dfgFourthTier/Source/_javascript_Core/jit/JIT.cpp
branches/dfgFourthTier/Source/_javascript_Core/jit/JIT.h
branches/dfgFourthTier/Source/_javascript_Core/jit/JITStubs.cpp
branches/dfgFourthTier/Source/_javascript_Core/llint/LLIntSlowPaths.cpp




Diff

Modified: branches/dfgFourthTier/Source/_javascript_Core/ChangeLog (150656 => 150657)

--- branches/dfgFourthTier/Source/_javascript_Core/ChangeLog	2013-05-24 20:26:00 UTC (rev 150656)
+++ branches/dfgFourthTier/Source/_javascript_Core/ChangeLog	2013-05-24 21:06:07 UTC (rev 150657)
@@ -1,5 +1,88 @@
 2013-05-23  Filip Pizlo  fpi...@apple.com
 
+fourthTier: add heuristics to reduce the likelihood of a trivially inlineable function being independently compiled by the concurrent JIT
+https://bugs.webkit.org/show_bug.cgi?id=116557
+
+Reviewed by Geoffrey Garen.
+
+This introduces a fairly comprehensive mechanism for preventing trivially inlineable
+functions from being compiled independently of all of the things into which they end
+   

[webkit-changes] [150658] branches/dfgFourthTier/Source/JavaScriptCore

[fpizlo]

Title: [150658] branches/dfgFourthTier/Source/_javascript_Core








Revision 150658
Author fpi...@apple.com
Date 2013-05-24 14:45:44 -0700 (Fri, 24 May 2013)


Log Message
fourthTier: FTL should support LogicalNot and Branch on Int32 and Number
https://bugs.webkit.org/show_bug.cgi?id=116739

Reviewed by Gavin Barraclough.

* ftl/FTLCapabilities.cpp:
(JSC::FTL::canCompile):
* ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::LowerDFGToLLVM::compileLogicalNot):
(JSC::FTL::LowerDFGToLLVM::compileBranch):
(JSC::FTL::LowerDFGToLLVM::boolify):
(LowerDFGToLLVM):
* ftl/FTLOutput.h:
(JSC::FTL::Output::isZero32):
(JSC::FTL::Output::notZero32):

Modified Paths

branches/dfgFourthTier/Source/_javascript_Core/ChangeLog
branches/dfgFourthTier/Source/_javascript_Core/ftl/FTLCapabilities.cpp
branches/dfgFourthTier/Source/_javascript_Core/ftl/FTLLowerDFGToLLVM.cpp
branches/dfgFourthTier/Source/_javascript_Core/ftl/FTLOutput.h




Diff

Modified: branches/dfgFourthTier/Source/_javascript_Core/ChangeLog (150657 => 150658)

--- branches/dfgFourthTier/Source/_javascript_Core/ChangeLog	2013-05-24 21:06:07 UTC (rev 150657)
+++ branches/dfgFourthTier/Source/_javascript_Core/ChangeLog	2013-05-24 21:45:44 UTC (rev 150658)
@@ -1,3 +1,21 @@
+2013-05-24  Filip Pizlo  fpi...@apple.com
+
+fourthTier: FTL should support LogicalNot and Branch on Int32 and Number
+https://bugs.webkit.org/show_bug.cgi?id=116739
+
+Reviewed by Gavin Barraclough.
+
+* ftl/FTLCapabilities.cpp:
+(JSC::FTL::canCompile):
+* ftl/FTLLowerDFGToLLVM.cpp:
+(JSC::FTL::LowerDFGToLLVM::compileLogicalNot):
+(JSC::FTL::LowerDFGToLLVM::compileBranch):
+(JSC::FTL::LowerDFGToLLVM::boolify):
+(LowerDFGToLLVM):
+* ftl/FTLOutput.h:
+(JSC::FTL::Output::isZero32):
+(JSC::FTL::Output::notZero32):
+
 2013-05-23  Filip Pizlo  fpi...@apple.com
 
 fourthTier: add heuristics to reduce the likelihood of a trivially inlineable function being independently compiled by the concurrent JIT


Modified: branches/dfgFourthTier/Source/_javascript_Core/ftl/FTLCapabilities.cpp (150657 => 150658)

--- branches/dfgFourthTier/Source/_javascript_Core/ftl/FTLCapabilities.cpp	2013-05-24 21:06:07 UTC (rev 150657)
+++ branches/dfgFourthTier/Source/_javascript_Core/ftl/FTLCapabilities.cpp	2013-05-24 21:45:44 UTC (rev 150658)
@@ -124,9 +124,15 @@
 return false;
 case Branch:
 case LogicalNot:
-if (node-child1().useKind() == BooleanUse)
+switch (node-child1().useKind()) {
+case BooleanUse:
+case Int32Use:
+case NumberUse:
 break;
-return false;
+default:
+return false;
+}
+break;
 default:
 // Don't know how to handle anything else.
 return false;
@@ -163,12 +169,21 @@
 break;
 default:
 // Don't know how to handle anything else.
+if (verboseCompilationEnabled()) {
+dataLog(FTL rejecting node because of bad use kind: , edge.useKind(),  in node:\n);
+graph.dump(WTF::dataFile(), , node);
+}
 return false;
 }
 }
 
-if (!canCompile(node))
+if (!canCompile(node)) {
+if (verboseCompilationEnabled()) {
+dataLog(FTL rejecting node:\n);
+graph.dump(WTF::dataFile(), , node);
+}
 return false;
+}
 }
 }
 


Modified: branches/dfgFourthTier/Source/_javascript_Core/ftl/FTLLowerDFGToLLVM.cpp (150657 => 150658)

--- branches/dfgFourthTier/Source/_javascript_Core/ftl/FTLLowerDFGToLLVM.cpp	2013-05-24 21:06:07 UTC (rev 150657)
+++ branches/dfgFourthTier/Source/_javascript_Core/ftl/FTLLowerDFGToLLVM.cpp	2013-05-24 21:45:44 UTC (rev 150658)
@@ -1126,16 +1126,7 @@
 
 void compileLogicalNot()
 {
-switch (m_node-child1().useKind()) {
-case BooleanUse: {
-m_booleanValues.add(m_node, m_out.bitNot(lowBoolean(m_node-child1(;
-break;
-}
-
-default:
-RELEASE_ASSERT_NOT_REACHED();
-break;
-}
+m_booleanValues.add(m_node, m_out.bitNot(boolify(m_node-child1(;
 }
 
 void compileJump()
@@ -1145,19 +1136,10 @@
 
 void compileBranch()
 {
-switch (m_node-child1().useKind()) {
-case BooleanUse: {
-m_out.branch(
-lowBoolean(m_node-child1()),
-m_blocks.get(m_graph.m_blocks[m_node-takenBlockIndex()].get()),
-m_blocks.get(m_graph.m_blocks[m_node-notTakenBlockIndex()].get()));
-break;
-}
-
-default:
-RELEASE_ASSERT_NOT_REACHED();
-break;
-}
+m_out.branch(
+

[webkit-changes] [150659] trunk

[fpizlo]

Title: [150659] trunk








Revision 150659
Author fpi...@apple.com
Date 2013-05-24 15:00:21 -0700 (Fri, 24 May 2013)


Log Message
We broke !(0/0)
https://bugs.webkit.org/show_bug.cgi?id=116736

Reviewed by Gavin Barraclough.

Source/_javascript_Core: 

* parser/ASTBuilder.h:
(JSC::ASTBuilder::createLogicalNot):
* runtime/JSCJSValueInlines.h:
(JSC::JSValue::pureToBoolean):

Source/WTF: 

* wtf/MathExtras.h:
(isNotZeroAndOrdered):
(isZeroOrUnordered):

LayoutTests: 

* fast/js/constant-fold-not-nan.html: Added.
* fast/js/constant-fold-not-nan-expected.txt: Added.
* fast/js/jsc-test-list:
* fast/js/script-tests/constant-fold-not-nan.js: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/js/jsc-test-list
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/parser/ASTBuilder.h
trunk/Source/_javascript_Core/runtime/JSCJSValueInlines.h
trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/MathExtras.h


Added Paths

trunk/LayoutTests/fast/js/constant-fold-not-nan-expected.txt
trunk/LayoutTests/fast/js/constant-fold-not-nan.html
trunk/LayoutTests/fast/js/script-tests/constant-fold-not-nan.js




Diff

Modified: trunk/LayoutTests/ChangeLog (150658 => 150659)

--- trunk/LayoutTests/ChangeLog	2013-05-24 21:45:44 UTC (rev 150658)
+++ trunk/LayoutTests/ChangeLog	2013-05-24 22:00:21 UTC (rev 150659)
@@ -1,3 +1,15 @@
+2013-05-24  Filip Pizlo  fpi...@apple.com
+
+We broke !(0/0)
+https://bugs.webkit.org/show_bug.cgi?id=116736
+
+Reviewed by Gavin Barraclough.
+
+* fast/js/constant-fold-not-nan.html: Added.
+* fast/js/constant-fold-not-nan-expected.txt: Added.
+* fast/js/jsc-test-list:
+* fast/js/script-tests/constant-fold-not-nan.js: Added.
+
 2013-05-24  Sergio Villar Senin  svil...@igalia.com
 
 REGRESSION (r150215): broke a test case in inspector/console/console-css-warnings.html


Added: trunk/LayoutTests/fast/js/constant-fold-not-nan-expected.txt (0 => 150659)

--- trunk/LayoutTests/fast/js/constant-fold-not-nan-expected.txt	(rev 0)
+++ trunk/LayoutTests/fast/js/constant-fold-not-nan-expected.txt	2013-05-24 22:00:21 UTC (rev 150659)
@@ -0,0 +1,10 @@
+Tests that our parse-time constant folding treats !(0/0) correctly.
+
+On success, you will see a series of PASS messages, followed by TEST COMPLETE.
+
+
+PASS !(0/0) is true
+PASS successfullyParsed is true
+
+TEST COMPLETE
+


Added: trunk/LayoutTests/fast/js/constant-fold-not-nan.html (0 => 150659)

--- trunk/LayoutTests/fast/js/constant-fold-not-nan.html	(rev 0)
+++ trunk/LayoutTests/fast/js/constant-fold-not-nan.html	2013-05-24 22:00:21 UTC (rev 150659)
@@ -0,0 +1,10 @@
+!DOCTYPE HTML PUBLIC -//IETF//DTD HTML//EN
+html
+head
+script src=""
+/head
+body
+script src=""
+script src=""
+/body
+/html


Modified: trunk/LayoutTests/fast/js/jsc-test-list (150658 => 150659)

--- trunk/LayoutTests/fast/js/jsc-test-list	2013-05-24 21:45:44 UTC (rev 150658)
+++ trunk/LayoutTests/fast/js/jsc-test-list	2013-05-24 22:00:21 UTC (rev 150659)
@@ -54,6 +54,7 @@
 fast/js/constant-count
 fast/js/constant-encoding
 fast/js/constant-folding
+fast/js/constant-fold-not-nan
 fast/js/continue-break-multiple-labels
 fast/js/convert-nan-to-bool
 fast/js/cyclic-prototypes


Added: trunk/LayoutTests/fast/js/script-tests/constant-fold-not-nan.js (0 => 150659)

--- trunk/LayoutTests/fast/js/script-tests/constant-fold-not-nan.js	(rev 0)
+++ trunk/LayoutTests/fast/js/script-tests/constant-fold-not-nan.js	2013-05-24 22:00:21 UTC (rev 150659)
@@ -0,0 +1,5 @@
+description(
+Tests that our parse-time constant folding treats !(0/0) correctly.
+);
+
+shouldBe(!(0/0), true);


Modified: trunk/Source/_javascript_Core/ChangeLog (150658 => 150659)

--- trunk/Source/_javascript_Core/ChangeLog	2013-05-24 21:45:44 UTC (rev 150658)
+++ trunk/Source/_javascript_Core/ChangeLog	2013-05-24 22:00:21 UTC (rev 150659)
@@ -1,3 +1,15 @@
+2013-05-24  Filip Pizlo  fpi...@apple.com
+
+We broke !(0/0)
+https://bugs.webkit.org/show_bug.cgi?id=116736
+
+Reviewed by Gavin Barraclough.
+
+* parser/ASTBuilder.h:
+(JSC::ASTBuilder::createLogicalNot):
+* runtime/JSCJSValueInlines.h:
+(JSC::JSValue::pureToBoolean):
+
 2013-05-24  Julien Brianceau  jbrianc...@nds.com
 
 [sh4] Optimize LLINT generated code and fix few bugs in baseline JIT.


Modified: trunk/Source/_javascript_Core/parser/ASTBuilder.h (150658 => 150659)

--- trunk/Source/_javascript_Core/parser/ASTBuilder.h	2013-05-24 21:45:44 UTC (rev 150658)
+++ trunk/Source/_javascript_Core/parser/ASTBuilder.h	2013-05-24 22:00:21 UTC (rev 150659)
@@ -148,7 +148,7 @@
 ExpressionNode* createLogicalNot(const JSTokenLocation location, ExpressionNode* expr)
 {
 if (expr-isNumber())
-return createBoolean(location, !static_castNumberNode*(expr)-value());
+return createBoolean(location, 

[webkit-changes] [150660] trunk/Source/WebKit/win

[andersca]

Title: [150660] trunk/Source/WebKit/win








Revision 150660
Author ander...@apple.com
Date 2013-05-24 15:05:57 -0700 (Fri, 24 May 2013)


Log Message
Remove unused code to read/write history
https://bugs.webkit.org/show_bug.cgi?id=116738

Reviewed by Brent Fulgham.

* Interfaces/IWebHistory.idl:
Replace loadFromURL and saveToURL with unused1/unused2.

* Interfaces/IWebHistoryPrivate.idl:
Replace data with unused1.

* WebHistory.cpp:
Remove history loading/saving code.

(WebHistory::unused1):
(WebHistory::unused2):
Add implementations.

* WebHistory.h:
(WebHistory):

Modified Paths

trunk/Source/WebKit/win/ChangeLog
trunk/Source/WebKit/win/Interfaces/IWebHistory.idl
trunk/Source/WebKit/win/Interfaces/IWebHistoryPrivate.idl
trunk/Source/WebKit/win/WebHistory.cpp
trunk/Source/WebKit/win/WebHistory.h




Diff

Modified: trunk/Source/WebKit/win/ChangeLog (150659 => 150660)

--- trunk/Source/WebKit/win/ChangeLog	2013-05-24 22:00:21 UTC (rev 150659)
+++ trunk/Source/WebKit/win/ChangeLog	2013-05-24 22:05:57 UTC (rev 150660)
@@ -1,3 +1,26 @@
+2013-05-24  Anders Carlsson  ander...@apple.com
+
+Remove unused code to read/write history
+https://bugs.webkit.org/show_bug.cgi?id=116738
+
+Reviewed by Brent Fulgham.
+
+* Interfaces/IWebHistory.idl:
+Replace loadFromURL and saveToURL with unused1/unused2.
+
+* Interfaces/IWebHistoryPrivate.idl:
+Replace data with unused1.
+
+* WebHistory.cpp:
+Remove history loading/saving code.
+
+(WebHistory::unused1):
+(WebHistory::unused2):
+Add implementations.
+
+* WebHistory.h:
+(WebHistory):
+
 2013-05-21  Mark Salisbury  mark.salisb...@hp.com
 
 [Windows, curl] WebDownloadCurl.cpp should not include SystemTime.h


Modified: trunk/Source/WebKit/win/Interfaces/IWebHistory.idl (150659 => 150660)

--- trunk/Source/WebKit/win/Interfaces/IWebHistory.idl	2013-05-24 22:00:21 UTC (rev 150659)
+++ trunk/Source/WebKit/win/Interfaces/IWebHistory.idl	2013-05-24 22:05:57 UTC (rev 150660)
@@ -80,27 +80,10 @@
 */
 HRESULT setOptionalSharedHistory([in] IWebHistory* history);
 
-/*!
-@method loadFromURL:error:
-@param URL The URL to use to initialize the WebHistory.
-@param error Set to nil or an NSError instance if an error occurred.
-@abstract The designated initializer for WebHistory.
-@result Returns YES if successful, NO otherwise.
-- (BOOL)loadFromURL:(NSURL *)URL error:(NSError **)error;
-*/
-HRESULT loadFromURL([in] BSTR url, [out] IWebError** error, [out, retval] BOOL* succeeded);
+HRESULT unused1();
+HRESULT unused2();
 
 /*!
-@method saveToURL:error:
-@discussion Save history to URL. It is the client's responsibility to call this at appropriate times.
-@param URL The URL to use to save the WebHistory.
-@param error Set to nil or an NSError instance if an error occurred.
-@result Returns YES if successful, NO otherwise.
-- (BOOL)saveToURL:(NSURL *)URL error:(NSError **)error;
-*/
-HRESULT saveToURL([in] BSTR url, [out] IWebError** error, [out, retval] BOOL* succeeded);
-
-/*!
 @method addItems:
 @param newItems An array of WebHistoryItems to add to the WebHistory.
 - (void)addItems:(NSArray *)newItems;


Modified: trunk/Source/WebKit/win/Interfaces/IWebHistoryPrivate.idl (150659 => 150660)

--- trunk/Source/WebKit/win/Interfaces/IWebHistoryPrivate.idl	2013-05-24 22:00:21 UTC (rev 150659)
+++ trunk/Source/WebKit/win/Interfaces/IWebHistoryPrivate.idl	2013-05-24 22:05:57 UTC (rev 150660)
@@ -35,7 +35,7 @@
 interface IWebHistoryPrivate : IUnknown
 {
 HRESULT allItems([in, out] int* count, [out, retval] IWebHistoryItem** items);
-HRESULT data([out, retval] IStream**);
+HRESULT unused1();
 HRESULT setVisitedLinkTrackingEnabled([in] BOOL visitedLinkTrackingEnable);
 HRESULT removeAllVisitedLinks();
 }


Modified: trunk/Source/WebKit/win/WebHistory.cpp (150659 => 150660)

--- trunk/Source/WebKit/win/WebHistory.cpp	2013-05-24 22:00:21 UTC (rev 150659)
+++ trunk/Source/WebKit/win/WebHistory.cpp	2013-05-24 22:05:57 UTC (rev 150660)
@@ -38,7 +38,6 @@
 #include CoreFoundation/CoreFoundation.h
 #include WebCore/BString.h
 #include WebCore/HistoryItem.h
-#include WebCore/HistoryPropertyList.h
 #include WebCore/KURL.h
 #include WebCore/PageGroup.h
 #include WebCore/SharedBuffer.h
@@ -49,46 +48,6 @@
 using namespace WebCore;
 using namespace std;
 
-CFStringRef DatesArrayKey = CFSTR(WebHistoryDates);
-CFStringRef FileVersionKey = CFSTR(WebHistoryFileVersion);
-
-#define currentFileVersion 1
-
-class WebHistoryWriter : public HistoryPropertyListWriter {
-public:
-WebHistoryWriter(const WebHistory::DateToEntriesMap);
-
-private:
-virtual void writeHistoryItems(BinaryPropertyListObjectStream);
-
-const WebHistory::DateToEntriesMap m_entriesByDate;
-VectorWebHistory::DateKey m_dateKeys;
-};

[webkit-changes] [150661] branches/dfgFourthTier/Source/JavaScriptCore

[fpizlo]

Title: [150661] branches/dfgFourthTier/Source/_javascript_Core








Revision 150661
Author fpi...@apple.com
Date 2013-05-24 15:27:57 -0700 (Fri, 24 May 2013)


Log Message
fourthTier: FTL boolify should support ObjectOrOtherUse
https://bugs.webkit.org/show_bug.cgi?id=116741

Reviewed by Geoffrey Garen.

Just reusing what was already there in equalNullOrUndefined(). Note that we will
sometimes generate some redundant IR - like having some spurious bitNot's in
places - but it's safe to assume that LLVM will simplify those, and that it won't
be the longest pole in the tent for compile times.

* ftl/FTLCapabilities.cpp:
(JSC::FTL::canCompile):
* ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::LowerDFGToLLVM::compileCompareEqConstant):
(JSC::FTL::LowerDFGToLLVM::compileCompareStrictEqConstant):
(JSC::FTL::LowerDFGToLLVM::boolify):
(JSC::FTL::LowerDFGToLLVM::equalNullOrUndefined):

Modified Paths

branches/dfgFourthTier/Source/_javascript_Core/ChangeLog
branches/dfgFourthTier/Source/_javascript_Core/ftl/FTLCapabilities.cpp
branches/dfgFourthTier/Source/_javascript_Core/ftl/FTLLowerDFGToLLVM.cpp




Diff

Modified: branches/dfgFourthTier/Source/_javascript_Core/ChangeLog (150660 => 150661)

--- branches/dfgFourthTier/Source/_javascript_Core/ChangeLog	2013-05-24 22:05:57 UTC (rev 150660)
+++ branches/dfgFourthTier/Source/_javascript_Core/ChangeLog	2013-05-24 22:27:57 UTC (rev 150661)
@@ -1,5 +1,25 @@
 2013-05-24  Filip Pizlo  fpi...@apple.com
 
+fourthTier: FTL boolify should support ObjectOrOtherUse
+https://bugs.webkit.org/show_bug.cgi?id=116741
+
+Reviewed by Geoffrey Garen.
+
+Just reusing what was already there in equalNullOrUndefined(). Note that we will
+sometimes generate some redundant IR - like having some spurious bitNot's in
+places - but it's safe to assume that LLVM will simplify those, and that it won't
+be the longest pole in the tent for compile times.
+
+* ftl/FTLCapabilities.cpp:
+(JSC::FTL::canCompile):
+* ftl/FTLLowerDFGToLLVM.cpp:
+(JSC::FTL::LowerDFGToLLVM::compileCompareEqConstant):
+(JSC::FTL::LowerDFGToLLVM::compileCompareStrictEqConstant):
+(JSC::FTL::LowerDFGToLLVM::boolify):
+(JSC::FTL::LowerDFGToLLVM::equalNullOrUndefined):
+
+2013-05-24  Filip Pizlo  fpi...@apple.com
+
 fourthTier: FTL should support LogicalNot and Branch on Int32 and Number
 https://bugs.webkit.org/show_bug.cgi?id=116739
 


Modified: branches/dfgFourthTier/Source/_javascript_Core/ftl/FTLCapabilities.cpp (150660 => 150661)

--- branches/dfgFourthTier/Source/_javascript_Core/ftl/FTLCapabilities.cpp	2013-05-24 22:05:57 UTC (rev 150660)
+++ branches/dfgFourthTier/Source/_javascript_Core/ftl/FTLCapabilities.cpp	2013-05-24 22:27:57 UTC (rev 150661)
@@ -128,6 +128,7 @@
 case BooleanUse:
 case Int32Use:
 case NumberUse:
+case ObjectOrOtherUse:
 break;
 default:
 return false;
@@ -165,6 +166,7 @@
 case CellUse:
 case KnownCellUse:
 case ObjectUse:
+case ObjectOrOtherUse:
 // These are OK.
 break;
 default:


Modified: branches/dfgFourthTier/Source/_javascript_Core/ftl/FTLLowerDFGToLLVM.cpp (150660 => 150661)

--- branches/dfgFourthTier/Source/_javascript_Core/ftl/FTLLowerDFGToLLVM.cpp	2013-05-24 22:05:57 UTC (rev 150660)
+++ branches/dfgFourthTier/Source/_javascript_Core/ftl/FTLLowerDFGToLLVM.cpp	2013-05-24 22:27:57 UTC (rev 150661)
@@ -990,7 +990,9 @@
 {
 ASSERT(m_graph.valueOfJSConstant(m_node-child2().node()).isNull());
 masqueradesAsUndefinedWatchpointIfIsStillValid();
-equalNullOrUndefined(m_node-child1(), EqualNullOrUndefined);
+m_booleanValues.add(
+m_node, equalNullOrUndefined(
+m_node-child1(), AllCellsAreFalse, EqualNullOrUndefined));
 }
 
 void compileCompareStrictEq()
@@ -1028,12 +1030,14 @@
 if (constant.isUndefinedOrNull()
  !masqueradesAsUndefinedWatchpointIfIsStillValid()) {
 if (constant.isNull()) {
-equalNullOrUndefined(m_node-child1(), EqualNull);
+m_booleanValues.add(
+m_node, equalNullOrUndefined(m_node-child1(), AllCellsAreFalse, EqualNull));
 return;
 }
 
 ASSERT(constant.isUndefined());
-equalNullOrUndefined(m_node-child1(), EqualUndefined);
+m_booleanValues.add(
+m_node, equalNullOrUndefined(m_node-child1(), AllCellsAreFalse, EqualUndefined));
 return;
 }
 
@@ -1163,22 +1167,38 @@
 return m_out.notZero32(lowInt32(m_node-child1()));
 case NumberUse:
 return m_out.doubleNotEqual(lowDouble(edge), m_out.doubleZero);
+case ObjectOrOtherUse:
+return m_out.bitNot(
+

[webkit-changes] [150666] trunk/Source

[timothy_horton]

Title: [150666] trunk/Source








Revision 150666
Author timothy_hor...@apple.com
Date 2013-05-24 16:37:12 -0700 (Fri, 24 May 2013)


Log Message
Animated GIFs don't repaint after TiledCoreAnimationDrawingArea un-suspends painting
https://bugs.webkit.org/show_bug.cgi?id=116744
rdar://problem/13973514

Reviewed by Simon Fraser.

* WebCore.exp.in: Export FrameView::resumeAnimatingImages.
* page/FrameView.cpp:
(WebCore::FrameView::setIsInWindow):
(WebCore::FrameView::resumeAnimatingImages):
Factor the code to restart animated images out of frameView::setIsInWindow.

* page/FrameView.h:
(FrameView):

* WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
(WebKit::TiledCoreAnimationDrawingArea::resumePainting):
Force WebCore to repaint animated images when painting is resumed.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/WebCore.exp.in
trunk/Source/WebCore/page/FrameView.cpp
trunk/Source/WebCore/page/FrameView.h
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm




Diff

Modified: trunk/Source/WebCore/ChangeLog (150665 => 150666)

--- trunk/Source/WebCore/ChangeLog	2013-05-24 23:30:36 UTC (rev 150665)
+++ trunk/Source/WebCore/ChangeLog	2013-05-24 23:37:12 UTC (rev 150666)
@@ -1,3 +1,20 @@
+2013-05-24  Tim Horton  timothy_hor...@apple.com
+
+Animated GIFs don't repaint after TiledCoreAnimationDrawingArea un-suspends painting
+https://bugs.webkit.org/show_bug.cgi?id=116744
+rdar://problem/13973514
+
+Reviewed by Simon Fraser.
+
+* WebCore.exp.in: Export FrameView::resumeAnimatingImages.
+* page/FrameView.cpp:
+(WebCore::FrameView::setIsInWindow):
+(WebCore::FrameView::resumeAnimatingImages):
+Factor the code to restart animated images out of frameView::setIsInWindow.
+
+* page/FrameView.h:
+(FrameView):
+
 2013-05-24  Anders Carlsson  ander...@apple.com
 
 Move history property list writer to WebKit


Modified: trunk/Source/WebCore/WebCore.exp.in (150665 => 150666)

--- trunk/Source/WebCore/WebCore.exp.in	2013-05-24 23:30:36 UTC (rev 150665)
+++ trunk/Source/WebCore/WebCore.exp.in	2013-05-24 23:37:12 UTC (rev 150666)
@@ -1153,6 +1153,7 @@
 __ZN7WebCore9FrameView20removeScrollableAreaEPNS_14ScrollableAreaE
 __ZN7WebCore9FrameView20resetTrackedRepaintsEv
 __ZN7WebCore9FrameView21flushDeferredRepaintsEv
+__ZN7WebCore9FrameView21resumeAnimatingImagesEv
 __ZN7WebCore9FrameView22setBaseBackgroundColorERKNS_5ColorE
 __ZN7WebCore9FrameView23updateCanHaveScrollbarsEv
 __ZN7WebCore9FrameView24forceLayoutForPaginationERKNS_9FloatSizeES3_fNS_19AdjustViewSizeOrNotE


Modified: trunk/Source/WebCore/page/FrameView.cpp (150665 => 150666)

--- trunk/Source/WebCore/page/FrameView.cpp	2013-05-24 23:30:36 UTC (rev 150665)
+++ trunk/Source/WebCore/page/FrameView.cpp	2013-05-24 23:37:12 UTC (rev 150666)
@@ -1069,12 +1069,16 @@
 if (RenderView* renderView = this-renderView())
 renderView-setIsInWindow(isInWindow);
 
-if (isInWindow) {
-// Drawing models which cache painted content while out-of-window (WebKit2's composited drawing areas, etc.)
-// require that we repaint animated images to kickstart the animation loop.
+if (isInWindow)
+resumeAnimatingImages();
+}
 
-CachedImage::resumeAnimatingImagesForLoader(frame()-document()-cachedResourceLoader());
-}
+void FrameView::resumeAnimatingImages()
+{
+// Drawing models which cache painted content while out-of-window (WebKit2's composited drawing areas, etc.)
+// require that we repaint animated images to kickstart the animation loop.
+
+CachedImage::resumeAnimatingImagesForLoader(frame()-document()-cachedResourceLoader());
 }
 
 RenderObject* FrameView::layoutRoot(bool onlyDuringLayout) const


Modified: trunk/Source/WebCore/page/FrameView.h (150665 => 150666)

--- trunk/Source/WebCore/page/FrameView.h	2013-05-24 23:30:36 UTC (rev 150665)
+++ trunk/Source/WebCore/page/FrameView.h	2013-05-24 23:37:12 UTC (rev 150666)
@@ -430,6 +430,8 @@
 bool visualUpdatesAllowedByClient() const { return m_visualUpdatesAllowedByClient; }
 void setVisualUpdatesAllowedByClient(bool);
 
+void resumeAnimatingImages();
+
 protected:
 virtual bool scrollContentsFastPath(const IntSize scrollDelta, const IntRect rectToScroll, const IntRect clipRect);
 virtual void scrollContentsSlowPath(const IntRect updateRect);


Modified: trunk/Source/WebKit2/ChangeLog (150665 => 150666)

--- trunk/Source/WebKit2/ChangeLog	2013-05-24 23:30:36 UTC (rev 150665)
+++ trunk/Source/WebKit2/ChangeLog	2013-05-24 23:37:12 UTC (rev 150666)
@@ -1,3 +1,15 @@
+2013-05-24  Tim Horton  timothy_hor...@apple.com
+
+Animated GIFs don't repaint after TiledCoreAnimationDrawingArea un-suspends painting
+https://bugs.webkit.org/show_bug.cgi?id=116744
+rdar://problem/13973514
+
+Reviewed by Simon Fraser.
+
+* 

[webkit-changes] [150667] trunk/Source/WebCore

[andersca]

Title: [150667] trunk/Source/WebCore








Revision 150667
Author ander...@apple.com
Date 2013-05-24 16:46:04 -0700 (Fri, 24 May 2013)


Log Message
Fix Windows build.

* WebCore.vcproj/WebCore.vcproj:
* WebCore.vcxproj/WebCore.vcxproj:
* WebCore.vcxproj/WebCore.vcxproj.filters:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/WebCore.vcproj/WebCore.vcproj
trunk/Source/WebCore/WebCore.vcxproj/WebCore.vcxproj
trunk/Source/WebCore/WebCore.vcxproj/WebCore.vcxproj.filters




Diff

Modified: trunk/Source/WebCore/ChangeLog (150666 => 150667)

--- trunk/Source/WebCore/ChangeLog	2013-05-24 23:37:12 UTC (rev 150666)
+++ trunk/Source/WebCore/ChangeLog	2013-05-24 23:46:04 UTC (rev 150667)
@@ -1,3 +1,11 @@
+2013-05-24  Anders Carlsson  ander...@apple.com
+
+Fix Windows build.
+
+* WebCore.vcproj/WebCore.vcproj:
+* WebCore.vcxproj/WebCore.vcxproj:
+* WebCore.vcxproj/WebCore.vcxproj.filters:
+
 2013-05-24  Tim Horton  timothy_hor...@apple.com
 
 Animated GIFs don't repaint after TiledCoreAnimationDrawingArea un-suspends painting


Modified: trunk/Source/WebCore/WebCore.vcproj/WebCore.vcproj (150666 => 150667)

--- trunk/Source/WebCore/WebCore.vcproj/WebCore.vcproj	2013-05-24 23:37:12 UTC (rev 150666)
+++ trunk/Source/WebCore/WebCore.vcproj/WebCore.vcproj	2013-05-24 23:46:04 UTC (rev 150667)
@@ -29730,14 +29730,6 @@
 Name=cf
 
 File
-	RelativePath=..\platform\cf\BinaryPropertyList.cpp
-	
-/File
-File
-	RelativePath=..\platform\cf\BinaryPropertyList.h
-	
-/File
-File
 	RelativePath=..\platform\cf\FileSystemCF.cpp
 	
 /File
@@ -75010,18 +75002,6 @@
 RelativePath=..\history\PageCache.h
 
 			/File
-			Filter
-Name=cf
-
-File
-	RelativePath=..\history\cf\HistoryPropertyList.cpp
-	
-/File
-File
-	RelativePath=..\history\cf\HistoryPropertyList.h
-	
-/File
-			/Filter
 		/Filter
 		Filter
 			Name=storage


Modified: trunk/Source/WebCore/WebCore.vcxproj/WebCore.vcxproj (150666 => 150667)

--- trunk/Source/WebCore/WebCore.vcxproj/WebCore.vcxproj	2013-05-24 23:37:12 UTC (rev 150666)
+++ trunk/Source/WebCore/WebCore.vcxproj/WebCore.vcxproj	2013-05-24 23:46:04 UTC (rev 150667)
@@ -4222,7 +4222,6 @@
 ClCompile Include=..\platform\win\WheelEventWin.cpp /
 ClCompile Include=..\platform\win\WidgetWin.cpp /
 ClCompile Include=..\platform\win\WindowMessageBroadcaster.cpp /
-ClCompile Include=..\platform\cf\BinaryPropertyList.cpp /
 ClCompile Include=..\platform\cf\FileSystemCF.cpp /
 ClCompile Include=..\platform\cf\KURLCFNet.cpp /
 ClCompile Include=..\platform\cf\SharedBufferCF.cpp /
@@ -10242,7 +10241,6 @@
 ClCompile Include=..\history\CachedPage.cpp /
 ClCompile Include=..\history\HistoryItem.cpp /
 ClCompile Include=..\history\PageCache.cpp /
-ClCompile Include=..\history\cf\HistoryPropertyList.cpp /
 ClCompile Include=..\storage\Storage.cpp /
 ClCompile Include=..\storage\StorageAreaImpl.cpp /
 ClCompile Include=..\storage\StorageAreaSync.cpp /
@@ -11612,7 +11610,6 @@
 ClInclude Include=..\platform\win\WindowMessageBroadcaster.h /
 ClInclude Include=..\platform\win\WindowMessageListener.h /
 ClInclude Include=..\platform\win\WindowsTouch.h /
-ClInclude Include=..\platform\cf\BinaryPropertyList.h /
 ClInclude Include=..\platform\cf\win\CertificateCFWin.h /
 ClInclude Include=..\platform\graphics\BitmapImage.h /
 ClInclude Include=..\platform\graphics\Color.h /
@@ -13165,7 +13162,6 @@
 ClInclude Include=..\history\CachedPage.h /
 ClInclude Include=..\history\HistoryItem.h /
 ClInclude Include=..\history\PageCache.h /
-ClInclude Include=..\history\cf\HistoryPropertyList.h /
 ClInclude Include=..\storage\Storage.h /
 ClInclude Include=..\storage\StorageArea.h /
 ClInclude Include=..\storage\StorageAreaImpl.h /


Modified: trunk/Source/WebCore/WebCore.vcxproj/WebCore.vcxproj.filters (150666 => 150667)

--- trunk/Source/WebCore/WebCore.vcxproj/WebCore.vcxproj.filters	2013-05-24 23:37:12 UTC (rev 150666)
+++ trunk/Source/WebCore/WebCore.vcxproj/WebCore.vcxproj.filters	2013-05-24 23:46:04 UTC (rev 150667)
@@ -259,9 +259,6 @@
 Filter Include=history
   UniqueIdentifier{6f39dedf-2d3a-414e-83fe-7bf64f911cfb}/UniqueIdentifier
 /Filter
-Filter Include=history\cf
-  UniqueIdentifier{99868b4c-8965-4d92-bddf-31bd5cf62812}/UniqueIdentifier
-/Filter
 Filter Include=storage
   UniqueIdentifier{e5121f0f-9548-4aa4-b23c-23d197118a0d}/UniqueIdentifier
 /Filter
@@ -4890,9 +4887,6 @@
 ClCompile Include=..\history\PageCache.cpp
   Filterhistory/Filter
 /ClCompile
-ClCompile Include=..\history\cf\HistoryPropertyList.cpp
-  Filterhistory\cf/Filter
-/ClCompile
 ClCompile Include=..\storage\Storage.cpp
   Filterstorage/Filter
 /ClCompile
@@ -5184,9 +5178,6 @@
 ClCompile Include=..\platform\cf\SharedBufferCF.cpp
 

[webkit-changes] [150668] trunk/Source/WebKit/mac

[andersca]

Title: [150668] trunk/Source/WebKit/mac








Revision 150668
Author ander...@apple.com
Date 2013-05-24 16:52:21 -0700 (Fri, 24 May 2013)


Log Message
Remove using namespace std from Mac WebKit1
https://bugs.webkit.org/show_bug.cgi?id=116747

Reviewed by Sam Weinig.

Use explicit std:: qualifiers instead.

* History/BinaryPropertyList.cpp:
(IntegerArray::deletedValueSize):
(BinaryPropertyListPlan::invalidObjectReference):
(bytesNeeded):
* History/WebHistory.mm:
(-[WebHistoryPrivate orderedLastVisitedDays]):
(WebHistoryWriter::WebHistoryWriter):
* History/WebHistoryItem.mm:
(-[WebHistoryItem initFromDictionaryRepresentation:]):
* Plugins/Hosted/NetscapePluginHostManager.mm:
(WebKit::NetscapePluginHostManager::instantiatePlugin):
* Plugins/Hosted/NetscapePluginHostProxy.mm:
* Plugins/Hosted/NetscapePluginInstanceProxy.mm:
(WebKit::NetscapePluginInstanceProxy::LocalObjectMap::idForObject):
(WebKit::NetscapePluginInstanceProxy::wheelEvent):
(WebKit::NetscapePluginInstanceProxy::print):
(WebKit::NetscapePluginInstanceProxy::snapshot):
(WebKit::NetscapePluginInstanceProxy::loadURL):
(WebKit::NetscapePluginInstanceProxy::createBindingsInstance):
* Plugins/Hosted/ProxyInstance.mm:
(WebKit::ProxyInstance::invoke):
(WebKit::ProxyInstance::supportsInvokeDefaultMethod):
(WebKit::ProxyInstance::supportsConstruct):
(WebKit::ProxyInstance::getPropertyNames):
(WebKit::ProxyInstance::methodNamed):
(WebKit::ProxyInstance::fieldNamed):
(WebKit::ProxyInstance::fieldValue):
(WebKit::ProxyInstance::setFieldValue):
* Plugins/WebBasePluginPackage.mm:
(-[WebBasePluginPackage supportsExtension:]):
(-[WebBasePluginPackage MIMETypeForExtension:]):
* Plugins/WebNetscapePluginStream.mm:
(WebNetscapePluginStream::deliverData):
* Plugins/WebNetscapePluginView.mm:
(PluginTimer::start):
(-[WebNetscapePluginView _postURL:target:len:buf:file:notifyData:sendNotification:allowHeaders:]):
* WebCoreSupport/WebFrameLoaderClient.mm:
* WebView/WebFrame.mm:
* WebView/WebHTMLView.mm:
(-[WebHTMLView _adjustedBottomOfPageWithTop:bottom:limit:]):
* WebView/WebTextCompletionController.mm:
(-[WebTextCompletionController _placePopupWindow:]):

Modified Paths

trunk/Source/WebKit/mac/ChangeLog
trunk/Source/WebKit/mac/History/BinaryPropertyList.cpp
trunk/Source/WebKit/mac/History/WebHistory.mm
trunk/Source/WebKit/mac/History/WebHistoryItem.mm
trunk/Source/WebKit/mac/Plugins/Hosted/NetscapePluginHostManager.mm
trunk/Source/WebKit/mac/Plugins/Hosted/NetscapePluginHostProxy.mm
trunk/Source/WebKit/mac/Plugins/Hosted/NetscapePluginInstanceProxy.mm
trunk/Source/WebKit/mac/Plugins/Hosted/ProxyInstance.mm
trunk/Source/WebKit/mac/Plugins/WebBasePluginPackage.mm
trunk/Source/WebKit/mac/Plugins/WebNetscapePluginStream.mm
trunk/Source/WebKit/mac/Plugins/WebNetscapePluginView.mm
trunk/Source/WebKit/mac/WebCoreSupport/WebFrameLoaderClient.mm
trunk/Source/WebKit/mac/WebView/WebFrame.mm
trunk/Source/WebKit/mac/WebView/WebHTMLView.mm
trunk/Source/WebKit/mac/WebView/WebTextCompletionController.mm




Diff

Modified: trunk/Source/WebKit/mac/ChangeLog (150667 => 150668)

--- trunk/Source/WebKit/mac/ChangeLog	2013-05-24 23:46:04 UTC (rev 150667)
+++ trunk/Source/WebKit/mac/ChangeLog	2013-05-24 23:52:21 UTC (rev 150668)
@@ -1,5 +1,57 @@
 2013-05-24  Anders Carlsson  ander...@apple.com
 
+Remove using namespace std from Mac WebKit1
+https://bugs.webkit.org/show_bug.cgi?id=116747
+
+Reviewed by Sam Weinig.
+
+Use explicit std:: qualifiers instead.
+
+* History/BinaryPropertyList.cpp:
+(IntegerArray::deletedValueSize):
+(BinaryPropertyListPlan::invalidObjectReference):
+(bytesNeeded):
+* History/WebHistory.mm:
+(-[WebHistoryPrivate orderedLastVisitedDays]):
+(WebHistoryWriter::WebHistoryWriter):
+* History/WebHistoryItem.mm:
+(-[WebHistoryItem initFromDictionaryRepresentation:]):
+* Plugins/Hosted/NetscapePluginHostManager.mm:
+(WebKit::NetscapePluginHostManager::instantiatePlugin):
+* Plugins/Hosted/NetscapePluginHostProxy.mm:
+* Plugins/Hosted/NetscapePluginInstanceProxy.mm:
+(WebKit::NetscapePluginInstanceProxy::LocalObjectMap::idForObject):
+(WebKit::NetscapePluginInstanceProxy::wheelEvent):
+(WebKit::NetscapePluginInstanceProxy::print):
+(WebKit::NetscapePluginInstanceProxy::snapshot):
+(WebKit::NetscapePluginInstanceProxy::loadURL):
+(WebKit::NetscapePluginInstanceProxy::createBindingsInstance):
+* Plugins/Hosted/ProxyInstance.mm:
+(WebKit::ProxyInstance::invoke):
+(WebKit::ProxyInstance::supportsInvokeDefaultMethod):
+(WebKit::ProxyInstance::supportsConstruct):
+(WebKit::ProxyInstance::getPropertyNames):
+(WebKit::ProxyInstance::methodNamed):
+(WebKit::ProxyInstance::fieldNamed):
+(WebKit::ProxyInstance::fieldValue):
+(WebKit::ProxyInstance::setFieldValue):
+* Plugins/WebBasePluginPackage.mm:
+

[webkit-changes] [150670] trunk

[bfulgham]

Title: [150670] trunk








Revision 150670
Author bfulg...@apple.com
Date 2013-05-24 17:19:40 -0700 (Fri, 24 May 2013)


Log Message
[Windows] Expose database storage and cache locations via preferences.
https://bugs.webkit.org/show_bug.cgi?id=116729

Reviewed by Tim Horton.

Source/WebKit: 

* WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in: Export
three symbols needed to implement the feature.

Source/WebKit/win: 

* WebDatabaseManager.cpp: Update to check preferences for the
desired location of the database store.
(databasesDirectory): Added.
(WebKitInitializeWebDatabasesIfNecessary): Use new databasesDirectory
method to determine what system path to use for file storage.
* WebKit.vcproj/WebKitExports.def.in: Export three symbols
needed to implement the feature.
* WebView.cpp: Update to check preferences for the desired location
of the various caches used by WebKit.
(WebView::setCacheModel): Update to check preferences for URL cache
storage.
(WebKitSetApplicationCachePathIfNecessary): Update to check
preferences for ccache storage.

Tools: 

Update DumpRenderTree to use CFPreferences to control where WebKit
stores its local databases, URL caches, etc.

* DumpRenderTree/win/DumpRenderTree.cpp:
(libraryPathForDumpRenderTree): Added.
(dllLauncherEntryPoint): Set up DRT-specific cache locations.
* Scripts/webkitpy/port/base.py:
(Port._driver_tempdir): Added (to allow port-specific overload).
(Port._driver_tempdir_for_environment): Ditto
* Scripts/webkitpy/port/driver.py:
(Driver._setup_environ_for_driver): Use new overload to set
environment variable.
(Driver._start): Use new overload for temp directory location.
* Scripts/webkitpy/port/win.py:
(WinPort._driver_tempdir_for_environment): New overload to supply
Windows path to DumpRenderTree environment (while still using
cygwin paths for internal operations.

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in
trunk/Source/WebKit/win/ChangeLog
trunk/Source/WebKit/win/WebDatabaseManager.cpp
trunk/Source/WebKit/win/WebKit.vcproj/WebKitExports.def.in
trunk/Source/WebKit/win/WebView.cpp
trunk/Tools/ChangeLog
trunk/Tools/DumpRenderTree/win/DumpRenderTree.cpp
trunk/Tools/Scripts/webkitpy/port/base.py
trunk/Tools/Scripts/webkitpy/port/driver.py
trunk/Tools/Scripts/webkitpy/port/win.py




Diff

Modified: trunk/Source/WebKit/ChangeLog (150669 => 150670)

--- trunk/Source/WebKit/ChangeLog	2013-05-25 00:17:20 UTC (rev 150669)
+++ trunk/Source/WebKit/ChangeLog	2013-05-25 00:19:40 UTC (rev 150670)
@@ -1,3 +1,13 @@
+2013-05-24  Brent Fulgham  bfulg...@apple.com
+
+[Windows] Expose database storage and cache locations via preferences.
+https://bugs.webkit.org/show_bug.cgi?id=116729
+
+Reviewed by Tim Horton.
+
+* WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in: Export
+three symbols needed to implement the feature.
+
 2013-05-24  Anders Carlsson  ander...@apple.com
 
 Move history property list writer to WebKit


Modified: trunk/Source/WebKit/WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in (150669 => 150670)

--- trunk/Source/WebKit/WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in	2013-05-25 00:17:20 UTC (rev 150669)
+++ trunk/Source/WebKit/WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in	2013-05-25 00:19:40 UTC (rev 150670)
@@ -178,6 +178,9 @@
 ?childItemWithTarget@HistoryItem@WebCore@@QBEPAV12@ABVString@WTF@@@Z
 ?create@Range@WebCore@@SA?AV?$PassRefPtr@VRange@WebCore@@@WTF@@V?$PassRefPtr@VDocument@WebCore@@@4@V?$PassRefPtr@VNode@WebCore@@@4@H1H@Z
 ?create@SerializedScriptValue@WebCore@@SA?AV?$PassRefPtr@VSerializedScriptValue@WebCore@@@WTF@@ABVString@4@@Z
+#if USE(CF)
+?createCFString@String@WTF@@QBE?AV?$RetainPtr@PBU__CFString@@@2@XZ
+#endif
 ?createShadowRoot@Element@WebCore@@QAE?AV?$PassRefPtr@VShadowRoot@WebCore@@@WTF@@AAH@Z
 ?createWrapper@WebCore@@YA?AVJSValue@JSC@@PAVExecState@3@PAVJSDOMGlobalObject@1@PAVNode@1@@Z
 ?deprecatedShadowAncestorNode@Node@WebCore@@QBEPAV12@XZ
@@ -222,6 +225,7 @@
 ?setProperty@Settings@InspectorFrontendClientLocal@WebCore@@UAEXABVString@WTF@@0@Z
 ?windowObjectCleared@InspectorFrontendClientLocal@WebCore@@UAEXXZ
 ?setResourcesDataSizeLimitsFromInternals@InspectorController@WebCore@@QAEXHH@Z
+?pathByAppendingComponent@WebCore@@YA?AVString@WTF@@ABV23@0@Z
 ?profilerEnabled@InspectorController@WebCore@@QAE_NXZ
 ?setProfilerEnabled@InspectorController@WebCore@@QAEX_N@Z
 ?disconnectFrontend@InspectorController@WebCore@@QAEXXZ
@@ -237,6 +241,7 @@
 ?firstChild@ComposedShadowTreeWalker@WebCore@@QAEXXZ
 ?lastChild@ComposedShadowTreeWalker@WebCore@@QAEXXZ
 ?length@StaticNodeList@WebCore@@UBEIXZ
+?localUserSpecificStorageDirectory@WebCore@@YA?AVString@WTF@@XZ
 ?namedItem@StaticNodeList@WebCore@@UBEPAVNode@2@ABVAtomicString@WTF@@@Z
 

[webkit-changes] [150671] trunk/Source/WebCore

[bdakin]

Title: [150671] trunk/Source/WebCore








Revision 150671
Author bda...@apple.com
Date 2013-05-24 17:48:37 -0700 (Fri, 24 May 2013)


Log Message
DidFirstFlushForHeaderLayer can be called too soon on pages that redirect
https://bugs.webkit.org/show_bug.cgi?id=116749
-and corresponding-
rdar://problem/13886753

Reviewed by Simon Fraser.

Only start m_paintRelatedMilestonesTimer if we have actually painted.
* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::flushPendingLayerChanges):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderLayerCompositor.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (150670 => 150671)

--- trunk/Source/WebCore/ChangeLog	2013-05-25 00:19:40 UTC (rev 150670)
+++ trunk/Source/WebCore/ChangeLog	2013-05-25 00:48:37 UTC (rev 150671)
@@ -1,3 +1,17 @@
+
+2013-05-24  Beth Dakin  bda...@apple.com
+
+DidFirstFlushForHeaderLayer can be called too soon on pages that redirect
+https://bugs.webkit.org/show_bug.cgi?id=116749
+-and corresponding-
+rdar://problem/13886753
+
+Reviewed by Simon Fraser.
+
+Only start m_paintRelatedMilestonesTimer if we have actually painted.
+* rendering/RenderLayerCompositor.cpp:
+(WebCore::RenderLayerCompositor::flushPendingLayerChanges):
+
 2013-05-24  Anders Carlsson  ander...@apple.com
 
 Fix Windows build.


Modified: trunk/Source/WebCore/rendering/RenderLayerCompositor.cpp (150670 => 150671)

--- trunk/Source/WebCore/rendering/RenderLayerCompositor.cpp	2013-05-25 00:19:40 UTC (rev 150670)
+++ trunk/Source/WebCore/rendering/RenderLayerCompositor.cpp	2013-05-25 00:48:37 UTC (rev 150671)
@@ -373,7 +373,7 @@
 ASSERT(m_flushingLayers);
 m_flushingLayers = false;
 
-if (!m_paintRelatedMilestonesTimer.isActive())
+if (!m_paintRelatedMilestonesTimer.isActive()  frameView-hasEverPainted())
 m_paintRelatedMilestonesTimer.startOneShot(0);
 
 if (!m_viewportConstrainedLayersNeedingUpdate.isEmpty()) {






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [150672] trunk

[commit-queue]

Title: [150672] trunk








Revision 150672
Author commit-qu...@webkit.org
Date 2013-05-24 17:49:39 -0700 (Fri, 24 May 2013)


Log Message
Fixing invalid block recovery in some declaration list.
https://bugs.webkit.org/show_bug.cgi?id=115159

Patch by Sergio Villar Senin svil...@igalia.com on 2013-05-24
Reviewed by Darin Adler.

>From Blink r148889 by se...@chromium.org

Source/WebCore:

Improves the detection of some invalid block declarations inside a
declaration list. This allows the parser not to completely discard
a whole declaration list that contains an invalid block. In
particular grammar failed in tests 8, 12, 13, 15, 16 and 17 in the
new test added by this change.

Test: fast/css/parsing-invalid-block-recovery.html

* css/CSSGrammar.y.in:

LayoutTests:

* fast/css/parsing-invalid-block-recovery-expected.txt: Added.
* fast/css/parsing-invalid-block-recovery.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/CSSGrammar.y.in


Added Paths

trunk/LayoutTests/fast/css/parsing-invalid-block-recovery-expected.txt
trunk/LayoutTests/fast/css/parsing-invalid-block-recovery.html




Diff

Modified: trunk/LayoutTests/ChangeLog (150671 => 150672)

--- trunk/LayoutTests/ChangeLog	2013-05-25 00:48:37 UTC (rev 150671)
+++ trunk/LayoutTests/ChangeLog	2013-05-25 00:49:39 UTC (rev 150672)
@@ -1,3 +1,15 @@
+2013-05-24  Sergio Villar Senin  svil...@igalia.com
+
+Fixing invalid block recovery in some declaration list.
+https://bugs.webkit.org/show_bug.cgi?id=115159
+
+Reviewed by Darin Adler.
+
+From Blink r148889 by se...@chromium.org
+
+* fast/css/parsing-invalid-block-recovery-expected.txt: Added.
+* fast/css/parsing-invalid-block-recovery.html: Added.
+
 2013-05-24  Christophe Dumez  ch.du...@sisa.samsung.com
 
 Global constructors exposed in worker environment have wrong attributes


Added: trunk/LayoutTests/fast/css/parsing-invalid-block-recovery-expected.txt (0 => 150672)

--- trunk/LayoutTests/fast/css/parsing-invalid-block-recovery-expected.txt	(rev 0)
+++ trunk/LayoutTests/fast/css/parsing-invalid-block-recovery-expected.txt	2013-05-25 00:49:39 UTC (rev 150672)
@@ -0,0 +1,3 @@
+This test passes if nothing but END OF TEST is displayed
+
+END OF TEST


Added: trunk/LayoutTests/fast/css/parsing-invalid-block-recovery.html (0 => 150672)

--- trunk/LayoutTests/fast/css/parsing-invalid-block-recovery.html	(rev 0)
+++ trunk/LayoutTests/fast/css/parsing-invalid-block-recovery.html	2013-05-25 00:49:39 UTC (rev 150672)
@@ -0,0 +1,138 @@
+html
+head
+script type=text/_javascript_
+if (window.testRunner)
+testRunner.dumpAsText();
+/script
+style
+.to_be_hidden {
+  display:block;
+  color:red;
+}
+/style
+style
+.malformed1 {{}}
+#test1 {
+display:none;
+}
+/style
+style
+.malformed2 {#{}}
+#test2 {
+display:none;
+}
+/style
+style
+.malformed3 {{#}}
+#test3 {
+display:none;
+}
+/style
+style
+.malformed4 {{}#}
+#test4 {
+display:none;
+}
+/style
+style
+.malformed5 {color: red; {}}
+#test5 {
+display:none;
+}
+/style
+style
+.malformed6 {color: red; #{}}
+#test6 {
+display:none;
+}
+/style
+style
+.malformed7 {color: red; {#}}
+#test7 {
+display:none;
+}
+/style
+style
+.malformed8 {color: red; {##}#}
+#test8 {
+display:none;
+}
+/style
+style
+.malformed9 {color: red; color: red; {}}
+#test9 {
+display:none;
+}
+/style
+style
+.malformed10 {color: red; color: red; #{}}
+#test10 {
+display:none;
+}
+/style
+style
+.malformed11 {color: red; color: red; {#}}
+#test11 {
+display:none;
+}
+/style
+style
+.malformed12 {color: red; color: red; {##}#}
+#test12 {
+display:none;
+}
+/style
+style
+.malformed13 {color: red; color: red; {}; color: red}
+#test13 {
+display:none;
+}
+/style
+style
+.malformed14 {color: red; color: red; #{}; color: red}
+#test14 {
+display:none;
+}
+/style
+style
+.malformed15 {color: red; color: red; {#}; color: red}
+#test15 {
+display:none;
+}
+/style
+style
+.malformed16 {color: red; color: red; {##}#; color: red}
+#test16 {
+display:none;
+}
+/style
+style
+#test17 {
+color: red !important {};
+display: none;
+}
+/style

[webkit-changes] [150673] tags/Safari-537.43.2/

[lforschler]

Title: [150673] tags/Safari-537.43.2/








Revision 150673
Author lforsch...@apple.com
Date 2013-05-24 17:56:16 -0700 (Fri, 24 May 2013)


Log Message
New Tag.

Added Paths

tags/Safari-537.43.2/




Diff

Property changes: tags/Safari-537.43.2



Added: svn:ignore
depcomp
compile
config.guess
GNUmakefile.in
config.sub
ltmain.sh
aconfig.h.in
autom4te.cache
missing
aclocal.m4
install-sh
autotoolsconfig.h.in
INSTALL
README
gtk-doc.make
out
Makefile.chromium
WebKitSupportLibrary.zip
WebKitBuild

Added: svn:mergeinfo




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [150674] branches/safari-537.43-branch/Source

[lforschler]

Title: [150674] branches/safari-537.43-branch/Source








Revision 150674
Author lforsch...@apple.com
Date 2013-05-24 17:59:58 -0700 (Fri, 24 May 2013)


Log Message
Versioning.

Modified Paths

branches/safari-537.43-branch/Source/_javascript_Core/Configurations/Version.xcconfig
branches/safari-537.43-branch/Source/WebCore/Configurations/Version.xcconfig
branches/safari-537.43-branch/Source/WebKit/mac/Configurations/Version.xcconfig
branches/safari-537.43-branch/Source/WebKit2/Configurations/Version.xcconfig




Diff

Modified: branches/safari-537.43-branch/Source/_javascript_Core/Configurations/Version.xcconfig (150673 => 150674)

--- branches/safari-537.43-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2013-05-25 00:56:16 UTC (rev 150673)
+++ branches/safari-537.43-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2013-05-25 00:59:58 UTC (rev 150674)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 537;
 MINOR_VERSION = 43;
-TINY_VERSION = 2;
+TINY_VERSION = 3;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-537.43-branch/Source/WebCore/Configurations/Version.xcconfig (150673 => 150674)

--- branches/safari-537.43-branch/Source/WebCore/Configurations/Version.xcconfig	2013-05-25 00:56:16 UTC (rev 150673)
+++ branches/safari-537.43-branch/Source/WebCore/Configurations/Version.xcconfig	2013-05-25 00:59:58 UTC (rev 150674)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 537;
 MINOR_VERSION = 43;
-TINY_VERSION = 2;
+TINY_VERSION = 3;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-537.43-branch/Source/WebKit/mac/Configurations/Version.xcconfig (150673 => 150674)

--- branches/safari-537.43-branch/Source/WebKit/mac/Configurations/Version.xcconfig	2013-05-25 00:56:16 UTC (rev 150673)
+++ branches/safari-537.43-branch/Source/WebKit/mac/Configurations/Version.xcconfig	2013-05-25 00:59:58 UTC (rev 150674)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 537;
 MINOR_VERSION = 43;
-TINY_VERSION = 2;
+TINY_VERSION = 3;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-537.43-branch/Source/WebKit2/Configurations/Version.xcconfig (150673 => 150674)

--- branches/safari-537.43-branch/Source/WebKit2/Configurations/Version.xcconfig	2013-05-25 00:56:16 UTC (rev 150673)
+++ branches/safari-537.43-branch/Source/WebKit2/Configurations/Version.xcconfig	2013-05-25 00:59:58 UTC (rev 150674)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 537;
 MINOR_VERSION = 43;
-TINY_VERSION = 2;
+TINY_VERSION = 3;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [150675] trunk/Source/WebCore

[rniwa]

Title: [150675] trunk/Source/WebCore








Revision 150675
Author rn...@webkit.org
Date 2013-05-24 18:02:48 -0700 (Fri, 24 May 2013)


Log Message
Build fix after r150664.

* bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (150674 => 150675)

--- trunk/Source/WebCore/ChangeLog	2013-05-25 00:59:58 UTC (rev 150674)
+++ trunk/Source/WebCore/ChangeLog	2013-05-25 01:02:48 UTC (rev 150675)
@@ -1,3 +1,10 @@
+2013-05-24  Ryosuke Niwa  rn...@webkit.org
+
+Build fix after r150664.
+
+* bindings/scripts/test/JS/JSTestObj.cpp:
+(WebCore):
+
 2013-05-24  Sergio Villar Senin  svil...@igalia.com
 
 Fixing invalid block recovery in some declaration list.


Modified: trunk/Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp (150674 => 150675)

--- trunk/Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp	2013-05-25 00:59:58 UTC (rev 150674)
+++ trunk/Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp	2013-05-25 01:02:48 UTC (rev 150675)
@@ -122,13 +122,13 @@
 { conditionalAttr3, DontDelete, (intptr_t)static_castPropertySlot::GetValueFunc(jsTestObjConditionalAttr3), (intptr_t)setJSTestObjConditionalAttr3, NoIntrinsic },
 #endif
 #if ENABLE(Condition1)
-{ conditionalAttr4, DontDelete, (intptr_t)static_castPropertySlot::GetValueFunc(jsTestObjConditionalAttr4Constructor), (intptr_t)setJSTestObjConditionalAttr4Constructor, NoIntrinsic },
+{ conditionalAttr4, DontEnum, (intptr_t)static_castPropertySlot::GetValueFunc(jsTestObjConditionalAttr4Constructor), (intptr_t)setJSTestObjConditionalAttr4Constructor, NoIntrinsic },
 #endif
 #if ENABLE(Condition1)  ENABLE(Condition2)
-{ conditionalAttr5, DontDelete, (intptr_t)static_castPropertySlot::GetValueFunc(jsTestObjConditionalAttr5Constructor), (intptr_t)setJSTestObjConditionalAttr5Constructor, NoIntrinsic },
+{ conditionalAttr5, DontEnum, (intptr_t)static_castPropertySlot::GetValueFunc(jsTestObjConditionalAttr5Constructor), (intptr_t)setJSTestObjConditionalAttr5Constructor, NoIntrinsic },
 #endif
 #if ENABLE(Condition1) || ENABLE(Condition2)
-{ conditionalAttr6, DontDelete, (intptr_t)static_castPropertySlot::GetValueFunc(jsTestObjConditionalAttr6Constructor), (intptr_t)setJSTestObjConditionalAttr6Constructor, NoIntrinsic },
+{ conditionalAttr6, DontEnum, (intptr_t)static_castPropertySlot::GetValueFunc(jsTestObjConditionalAttr6Constructor), (intptr_t)setJSTestObjConditionalAttr6Constructor, NoIntrinsic },
 #endif
 { cachedAttribute1, DontDelete | ReadOnly, (intptr_t)static_castPropertySlot::GetValueFunc(jsTestObjCachedAttribute1), (intptr_t)0, NoIntrinsic },
 { cachedAttribute2, DontDelete | ReadOnly, (intptr_t)static_castPropertySlot::GetValueFunc(jsTestObjCachedAttribute2), (intptr_t)0, NoIntrinsic },






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [150676] trunk/Source/WTF

[benjamin]

Title: [150676] trunk/Source/WTF








Revision 150676
Author benja...@webkit.org
Date 2013-05-24 18:12:22 -0700 (Fri, 24 May 2013)


Log Message
Inline TCMalloc_Central_FreeList's RemoveRange and FetchFromSpansSafe
https://bugs.webkit.org/show_bug.cgi?id=116700

Patch by Benjamin Poulain bpoul...@apple.com on 2013-05-24
Reviewed by Darin Adler.

The two functions only have one call site each.

* wtf/FastMalloc.cpp:
(WTF::TCMalloc_Central_FreeList::RemoveRange):
(WTF::TCMalloc_Central_FreeList::FetchFromSpansSafe):

Modified Paths

trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/FastMalloc.cpp




Diff

Modified: trunk/Source/WTF/ChangeLog (150675 => 150676)

--- trunk/Source/WTF/ChangeLog	2013-05-25 01:02:48 UTC (rev 150675)
+++ trunk/Source/WTF/ChangeLog	2013-05-25 01:12:22 UTC (rev 150676)
@@ -1,3 +1,16 @@
+2013-05-24  Benjamin Poulain  bpoul...@apple.com
+
+Inline TCMalloc_Central_FreeList's RemoveRange and FetchFromSpansSafe
+https://bugs.webkit.org/show_bug.cgi?id=116700
+
+Reviewed by Darin Adler.
+
+The two functions only have one call site each.
+
+* wtf/FastMalloc.cpp:
+(WTF::TCMalloc_Central_FreeList::RemoveRange):
+(WTF::TCMalloc_Central_FreeList::FetchFromSpansSafe):
+
 2013-05-24  Filip Pizlo  fpi...@apple.com
 
 We broke !(0/0)


Modified: trunk/Source/WTF/wtf/FastMalloc.cpp (150675 => 150676)

--- trunk/Source/WTF/wtf/FastMalloc.cpp	2013-05-25 01:02:48 UTC (rev 150675)
+++ trunk/Source/WTF/wtf/FastMalloc.cpp	2013-05-25 01:12:22 UTC (rev 150676)
@@ -3051,7 +3051,7 @@
   ReleaseListToSpans(start);
 }
 
-void TCMalloc_Central_FreeList::RemoveRange(HardenedSLL* start, HardenedSLL* end, int *N) {
+ALWAYS_INLINE void TCMalloc_Central_FreeList::RemoveRange(HardenedSLL* start, HardenedSLL* end, int *N) {
   int num = *N;
   ASSERT(num  0);
 
@@ -3089,7 +3089,7 @@
 }
 
 
-HardenedSLL TCMalloc_Central_FreeList::FetchFromSpansSafe() {
+ALWAYS_INLINE HardenedSLL TCMalloc_Central_FreeList::FetchFromSpansSafe() {
   HardenedSLL t = FetchFromSpans();
   if (!t) {
 Populate();






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [150677] trunk/Tools

[bfulgham]

Title: [150677] trunk/Tools








Revision 150677
Author bfulg...@apple.com
Date 2013-05-24 18:18:56 -0700 (Fri, 24 May 2013)


Log Message
Unreviewed build fix. Don't use new NRWT logic needed
by Windows yet. Activate (and fix test) when we cut over.

* Scripts/webkitpy/port/driver.py:
(Driver._setup_environ_for_driver):
(Driver._start):

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/port/driver.py




Diff

Modified: trunk/Tools/ChangeLog (150676 => 150677)

--- trunk/Tools/ChangeLog	2013-05-25 01:12:22 UTC (rev 150676)
+++ trunk/Tools/ChangeLog	2013-05-25 01:18:56 UTC (rev 150677)
@@ -1,5 +1,14 @@
 2013-05-24  Brent Fulgham  bfulg...@apple.com
 
+Unreviewed build fix. Don't use new NRWT logic needed
+by Windows yet. Activate (and fix test) when we cut over.
+
+* Scripts/webkitpy/port/driver.py:
+(Driver._setup_environ_for_driver):
+(Driver._start):
+
+2013-05-24  Brent Fulgham  bfulg...@apple.com
+
 [Windows] Expose database storage and cache locations via preferences.
 https://bugs.webkit.org/show_bug.cgi?id=116729
 


Modified: trunk/Tools/Scripts/webkitpy/port/driver.py (150676 => 150677)

--- trunk/Tools/Scripts/webkitpy/port/driver.py	2013-05-25 01:12:22 UTC (rev 150676)
+++ trunk/Tools/Scripts/webkitpy/port/driver.py	2013-05-25 01:18:56 UTC (rev 150677)
@@ -284,7 +284,10 @@
 environment['DYLD_LIBRARY_PATH'] = self._port._build_path()
 environment['DYLD_FRAMEWORK_PATH'] = self._port._build_path()
 # FIXME: We're assuming that WebKitTestRunner checks this DumpRenderTree-named environment variable.
-environment['DUMPRENDERTREE_TEMP'] = str(self._port._driver_tempdir_for_environment())
+# FIXME: Commented out for now to avoid tests breaking. Re-enable after
+# we cut over to NRWT
+#environment['DUMPRENDERTREE_TEMP'] = str(self._port._driver_tempdir_for_environment())
+environment['DUMPRENDERTREE_TEMP'] = str(self._driver_tempdir)
 environment['LOCAL_RESOURCE_ROOT'] = self._port.layout_tests_dir()
 if 'WEBKITOUTPUTDIR' in os.environ:
 environment['WEBKITOUTPUTDIR'] = os.environ['WEBKITOUTPUTDIR']






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [150678] trunk/LayoutTests

[bfulgham]

Title: [150678] trunk/LayoutTests








Revision 150678
Author bfulg...@apple.com
Date 2013-05-24 18:28:01 -0700 (Fri, 24 May 2013)


Log Message
Unreviewed change to get Windows bots green.  Disable a number
of crashes and failures.  Crashes are tracked under
https://bugs.webkit.org/show_bug.cgi?id=116562, failures under
https://bugs.webkit.org/show_bug.cgi?id=116564.

* platform/win/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/win/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (150677 => 150678)

--- trunk/LayoutTests/ChangeLog	2013-05-25 01:18:56 UTC (rev 150677)
+++ trunk/LayoutTests/ChangeLog	2013-05-25 01:28:01 UTC (rev 150678)
@@ -1,3 +1,12 @@
+2013-05-24  Brent Fulgham  bfulg...@apple.com
+
+Unreviewed change to get Windows bots green.  Disable a number
+of crashes and failures.  Crashes are tracked under
+https://bugs.webkit.org/show_bug.cgi?id=116562, failures under
+https://bugs.webkit.org/show_bug.cgi?id=116564.
+
+* platform/win/TestExpectations:
+
 2013-05-24  Sergio Villar Senin  svil...@igalia.com
 
 Fixing invalid block recovery in some declaration list.


Modified: trunk/LayoutTests/platform/win/TestExpectations (150677 => 150678)

--- trunk/LayoutTests/platform/win/TestExpectations	2013-05-25 01:18:56 UTC (rev 150677)
+++ trunk/LayoutTests/platform/win/TestExpectations	2013-05-25 01:28:01 UTC (rev 150678)
@@ -2740,13 +2740,18 @@
 # Disable crashing tests, being investigated under https://bugs.webkit.org/show_bug.cgi?id=116562
 webkit.org/b/116562 fast/dom/Window/window-postmessage-clone-deep-array.html
 webkit.org/b/116562 fast/js/callback-function-with-handle-event.html
+webkit.org/b/116562 fast/js/global-constructors-attributes-worker.html
 webkit.org/b/116562 fast/js/large-expressions.html
 webkit.org/b/116562 fast/js/string-replace-exception-crash.html
 webkit.org/b/116562 fast/text/custom-font-data-crash.html
 webkit.org/b/116562 loader/go-back-cached-main-resource.html
+webkit.org/b/116562 svg/filters/feMorphology-crash.html
 
 # Test failures being investigated under https://bugs.webkit.org/show_bug.cgi?id=116564
+webkit.org/b/116564 compositing/contents-opaque/filter.html
+webkit.org/b/116564 compositing/layer-creation/animation-overlap-with-children.html
 webkit.org/b/116564 css1/units/rounding.html
+webkit.org/b/116564 editing/pasteboard/copy-without-selection.html
 webkit.org/b/116564 editing/selection/user-drag-element-and-user-select-none.html
 webkit.org/b/116564 editing/style/block-style-005.html
 webkit.org/b/116564 fast/block/lineboxcontain/block-with-ideographs.xhtml
@@ -2759,12 +2764,10 @@
 webkit.org/b/116564 fast/writing-mode/Kusa-Makura-background-canvas.html
 webkit.org/b/116564 media/click-volume-bar-not-pausing.html
 webkit.org/b/116564 media/track/track-css-user-override.html
+webkit.org/b/116564 printing/allowed-page-breaks.html
 webkit.org/b/116564 svg/zoom/page/zoom-replaced-intrinsic-ratio-001.htm
 webkit.org/b/116564 transitions/svg-text-shadow-transition.html
 
-# Enable storage tests, but exclude the following (see https://webkit.org/b/116559).
-webkit.org/b/116559 storage/websql/change-version.html
-webkit.org/b/116559 storage/websql/database-lock-after-reload.html
-webkit.org/b/116559 storage/websql/open-database-creation-callback.html
-webkit.org/b/116559 storage/websql/quota-tracking.html
+# Enable storage tests, but exclude the websql tests (see https://webkit.org/b/116559).
+webkit.org/b/116559 storage/websql
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [150679] trunk/Source/WebKit2

[commit-queue]

Title: [150679] trunk/Source/WebKit2








Revision 150679
Author commit-qu...@webkit.org
Date 2013-05-24 19:19:12 -0700 (Fri, 24 May 2013)


Log Message
[EFL] Build fix after r150669
https://bugs.webkit.org/show_bug.cgi?id=116750

Patch by Seokju Kwon seokju.k...@gmail.com on 2013-05-24
Reviewed by Anders Carlsson.

* CMakeLists.txt:
* WebProcess/Battery/WebBatteryManager.cpp:
(WebKit::WebBatteryManager::registerWebPage):
(WebKit::WebBatteryManager::unregisterWebPage):
* WebProcess/NetworkInfo/WebNetworkInfoManager.cpp:
(WebKit::WebNetworkInfoManager::registerWebPage):
(WebKit::WebNetworkInfoManager::unregisterWebPage):
(WebKit::WebNetworkInfoManager::bandwidth):
(WebKit::WebNetworkInfoManager::metered):
* WebProcess/WebCoreSupport/WebVibrationClient.cpp:
(WebKit::WebVibrationClient::vibrate):
(WebKit::WebVibrationClient::cancelVibration):
* WebProcess/soup/WebSoupRequestManager.cpp:
(WebKit::WebSoupRequestManager::didReceiveURIRequestData):
(WebKit::WebSoupRequestManager::send):

Modified Paths

trunk/Source/WebKit2/CMakeLists.txt
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/WebProcess/Battery/WebBatteryManager.cpp
trunk/Source/WebKit2/WebProcess/NetworkInfo/WebNetworkInfoManager.cpp
trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebVibrationClient.cpp
trunk/Source/WebKit2/WebProcess/soup/WebSoupRequestManager.cpp




Diff

Modified: trunk/Source/WebKit2/CMakeLists.txt (150678 => 150679)

--- trunk/Source/WebKit2/CMakeLists.txt	2013-05-25 01:28:01 UTC (rev 150678)
+++ trunk/Source/WebKit2/CMakeLists.txt	2013-05-25 02:19:12 UTC (rev 150679)
@@ -143,6 +143,7 @@
 Platform/CoreIPC/MessageDecoder.cpp
 Platform/CoreIPC/MessageEncoder.cpp
 Platform/CoreIPC/MessageReceiverMap.cpp
+Platform/CoreIPC/MessageSender.cpp
 Platform/CoreIPC/StringReference.cpp
 
 PluginProcess/PluginControllerProxy.cpp


Modified: trunk/Source/WebKit2/ChangeLog (150678 => 150679)

--- trunk/Source/WebKit2/ChangeLog	2013-05-25 01:28:01 UTC (rev 150678)
+++ trunk/Source/WebKit2/ChangeLog	2013-05-25 02:19:12 UTC (rev 150679)
@@ -1,3 +1,26 @@
+2013-05-24  Seokju Kwon  seokju.k...@gmail.com
+
+[EFL] Build fix after r150669
+https://bugs.webkit.org/show_bug.cgi?id=116750
+
+Reviewed by Anders Carlsson.
+
+* CMakeLists.txt:
+* WebProcess/Battery/WebBatteryManager.cpp:
+(WebKit::WebBatteryManager::registerWebPage):
+(WebKit::WebBatteryManager::unregisterWebPage):
+* WebProcess/NetworkInfo/WebNetworkInfoManager.cpp:
+(WebKit::WebNetworkInfoManager::registerWebPage):
+(WebKit::WebNetworkInfoManager::unregisterWebPage):
+(WebKit::WebNetworkInfoManager::bandwidth):
+(WebKit::WebNetworkInfoManager::metered):
+* WebProcess/WebCoreSupport/WebVibrationClient.cpp:
+(WebKit::WebVibrationClient::vibrate):
+(WebKit::WebVibrationClient::cancelVibration):
+* WebProcess/soup/WebSoupRequestManager.cpp:
+(WebKit::WebSoupRequestManager::didReceiveURIRequestData):
+(WebKit::WebSoupRequestManager::send):
+
 2013-05-24  Anders Carlsson  ander...@apple.com
 
 MessageSender shouldn't be a class template


Modified: trunk/Source/WebKit2/WebProcess/Battery/WebBatteryManager.cpp (150678 => 150679)

--- trunk/Source/WebKit2/WebProcess/Battery/WebBatteryManager.cpp	2013-05-25 01:28:01 UTC (rev 150678)
+++ trunk/Source/WebKit2/WebProcess/Battery/WebBatteryManager.cpp	2013-05-25 02:19:12 UTC (rev 150679)
@@ -62,7 +62,7 @@
 m_pageSet.add(page);
 
 if (wasEmpty)
-m_process-connection()-send(Messages::WebBatteryManagerProxy::StartUpdating(), 0);
+m_process-parentProcessConnection()-send(Messages::WebBatteryManagerProxy::StartUpdating(), 0);
 }
 
 void WebBatteryManager::unregisterWebPage(WebPage* page)
@@ -70,7 +70,7 @@
 m_pageSet.remove(page);
 
 if (m_pageSet.isEmpty())
-m_process-connection()-send(Messages::WebBatteryManagerProxy::StopUpdating(), 0);
+m_process-parentProcessConnection()-send(Messages::WebBatteryManagerProxy::StopUpdating(), 0);
 }
 
 void WebBatteryManager::didChangeBatteryStatus(const WTF::AtomicString eventType, const WebBatteryStatus::Data data)


Modified: trunk/Source/WebKit2/WebProcess/NetworkInfo/WebNetworkInfoManager.cpp (150678 => 150679)

--- trunk/Source/WebKit2/WebProcess/NetworkInfo/WebNetworkInfoManager.cpp	2013-05-25 01:28:01 UTC (rev 150678)
+++ trunk/Source/WebKit2/WebProcess/NetworkInfo/WebNetworkInfoManager.cpp	2013-05-25 02:19:12 UTC (rev 150679)
@@ -62,7 +62,7 @@
 m_pageSet.add(page);
 
 if (wasEmpty)
-m_process-connection()-send(Messages::WebNetworkInfoManagerProxy::StartUpdating(), 0);
+m_process-parentProcessConnection()-send(Messages::WebNetworkInfoManagerProxy::StartUpdating(), 0);
 }
 
 void WebNetworkInfoManager::unregisterWebPage(WebPage* page)
@@ -70,21 +70,21 @@
 m_pageSet.remove(page);
 
 if (m_pageSet.isEmpty())
-

[webkit-changes] [150680] trunk/Source/WebKit/efl

[commit-queue]

Title: [150680] trunk/Source/WebKit/efl








Revision 150680
Author commit-qu...@webkit.org
Date 2013-05-24 21:01:55 -0700 (Fri, 24 May 2013)


Log Message
[EFL] Remove obsolete Page forward declaration from InspectorClientEfl.h
https://bugs.webkit.org/show_bug.cgi?id=116752

Patch by Seokju Kwon seokju.k...@gmail.com on 2013-05-24
Reviewed by Christophe Dumez.

* WebCoreSupport/InspectorClientEfl.h:

Modified Paths

trunk/Source/WebKit/efl/ChangeLog
trunk/Source/WebKit/efl/WebCoreSupport/InspectorClientEfl.h




Diff

Modified: trunk/Source/WebKit/efl/ChangeLog (150679 => 150680)

--- trunk/Source/WebKit/efl/ChangeLog	2013-05-25 02:19:12 UTC (rev 150679)
+++ trunk/Source/WebKit/efl/ChangeLog	2013-05-25 04:01:55 UTC (rev 150680)
@@ -1,3 +1,12 @@
+2013-05-24  Seokju Kwon  seokju.k...@gmail.com
+
+[EFL] Remove obsolete Page forward declaration from InspectorClientEfl.h
+https://bugs.webkit.org/show_bug.cgi?id=116752
+
+Reviewed by Christophe Dumez.
+
+* WebCoreSupport/InspectorClientEfl.h:
+
 2013-05-24  Christophe Dumez  ch.du...@sisa.samsung.com
 
 Remove custom code for webkitAudioContext global constructor getter


Modified: trunk/Source/WebKit/efl/WebCoreSupport/InspectorClientEfl.h (150679 => 150680)

--- trunk/Source/WebKit/efl/WebCoreSupport/InspectorClientEfl.h	2013-05-25 02:19:12 UTC (rev 150679)
+++ trunk/Source/WebKit/efl/WebCoreSupport/InspectorClientEfl.h	2013-05-25 04:01:55 UTC (rev 150680)
@@ -42,7 +42,6 @@
 
 namespace WebCore {
 class InspectorFrontendClientEfl;
-class Page;
 
 class InspectorClientEfl : public InspectorClient, public InspectorFrontendChannel {
 public:






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [150681] trunk/Source/WebKit2

[commit-queue]

Title: [150681] trunk/Source/WebKit2








Revision 150681
Author commit-qu...@webkit.org
Date 2013-05-24 21:20:37 -0700 (Fri, 24 May 2013)


Log Message
[Qt][GTK] Build fix after r150669
https://bugs.webkit.org/show_bug.cgi?id=116751

Patch by Seokju Kwon seokju.k...@gmail.com on 2013-05-24
Reviewed by Christophe Dumez.

* GNUmakefile.list.am:
* Target.pri:
* WebProcess/WebCoreSupport/gtk/WebEditorClientGtk.cpp:
(WebKit::WebEditorClient::getEditorCommandsForKeyEvent):

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/GNUmakefile.list.am
trunk/Source/WebKit2/Target.pri
trunk/Source/WebKit2/WebProcess/WebCoreSupport/gtk/WebEditorClientGtk.cpp




Diff

Modified: trunk/Source/WebKit2/ChangeLog (150680 => 150681)

--- trunk/Source/WebKit2/ChangeLog	2013-05-25 04:01:55 UTC (rev 150680)
+++ trunk/Source/WebKit2/ChangeLog	2013-05-25 04:20:37 UTC (rev 150681)
@@ -1,5 +1,17 @@
 2013-05-24  Seokju Kwon  seokju.k...@gmail.com
 
+[Qt][GTK] Build fix after r150669
+https://bugs.webkit.org/show_bug.cgi?id=116751
+
+Reviewed by Christophe Dumez.
+
+* GNUmakefile.list.am:
+* Target.pri:
+* WebProcess/WebCoreSupport/gtk/WebEditorClientGtk.cpp:
+(WebKit::WebEditorClient::getEditorCommandsForKeyEvent):
+
+2013-05-24  Seokju Kwon  seokju.k...@gmail.com
+
 [EFL] Build fix after r150669
 https://bugs.webkit.org/show_bug.cgi?id=116750
 


Modified: trunk/Source/WebKit2/GNUmakefile.list.am (150680 => 150681)

--- trunk/Source/WebKit2/GNUmakefile.list.am	2013-05-25 04:01:55 UTC (rev 150680)
+++ trunk/Source/WebKit2/GNUmakefile.list.am	2013-05-25 04:20:37 UTC (rev 150681)
@@ -270,6 +270,7 @@
 	Source/WebKit2/Platform/CoreIPC/MessageReceiver.h \
 	Source/WebKit2/Platform/CoreIPC/MessageReceiverMap.cpp \
 	Source/WebKit2/Platform/CoreIPC/MessageReceiverMap.h \
+	Source/WebKit2/Platform/CoreIPC/MessageSender.cpp \
 	Source/WebKit2/Platform/CoreIPC/MessageSender.h \
 	Source/WebKit2/Platform/CoreIPC/StringReference.cpp \
 	Source/WebKit2/Platform/CoreIPC/StringReference.h \


Modified: trunk/Source/WebKit2/Target.pri (150680 => 150681)

--- trunk/Source/WebKit2/Target.pri	2013-05-25 04:01:55 UTC (rev 150680)
+++ trunk/Source/WebKit2/Target.pri	2013-05-25 04:20:37 UTC (rev 150681)
@@ -390,6 +390,7 @@
 Platform/CoreIPC/MessageDecoder.cpp \
 Platform/CoreIPC/MessageEncoder.cpp \
 Platform/CoreIPC/MessageReceiverMap.cpp \
+Platform/CoreIPC/MessageSender.cpp \
 Platform/CoreIPC/StringReference.cpp \
 Platform/Logging.cpp \
 Platform/Module.cpp \


Modified: trunk/Source/WebKit2/WebProcess/WebCoreSupport/gtk/WebEditorClientGtk.cpp (150680 => 150681)

--- trunk/Source/WebKit2/WebProcess/WebCoreSupport/gtk/WebEditorClientGtk.cpp	2013-05-25 04:01:55 UTC (rev 150680)
+++ trunk/Source/WebKit2/WebProcess/WebCoreSupport/gtk/WebEditorClientGtk.cpp	2013-05-25 04:20:37 UTC (rev 150681)
@@ -41,7 +41,7 @@
 
 /* First try to interpret the command in the UI and get the commands.
UI needs to receive event type because only knows current NativeWebKeyboardEvent.*/
-WebProcess::shared().connection()-sendSync(Messages::WebPageProxy::GetEditorCommandsForKeyEvent(event-type()),
+WebProcess::shared().parentProcessConnection()-sendSync(Messages::WebPageProxy::GetEditorCommandsForKeyEvent(event-type()),
 Messages::WebPageProxy::GetEditorCommandsForKeyEvent::Reply(pendingEditorCommands),
 m_page-pageID(), CoreIPC::Connection::NoTimeout);
 }






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes