[webkit-changes] [167003] trunk/Source/WebCore
Title: [167003] trunk/Source/WebCore
Revision 167003
Author commit-qu...@webkit.org
Date 2014-04-08 23:31:24 -0700 (Tue, 08 Apr 2014)
Log Message
nil should only be used for objects
https://bugs.webkit.org/show_bug.cgi?id=131431
Patch by Conrad Shultz on 2014-04-08
Reviewed by Chris Fleizach.
* accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
(-[WebAccessibilityObjectWrapper accessibilityIsAttributeSettable:]):
nil -> NO.
* platform/mac/WebVideoFullscreenController.mm:
(-[WebVideoFullscreenController setMediaElement:]):
nil -> 0; change a NULL to nullptr while we're here.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm
trunk/Source/WebCore/platform/mac/WebVideoFullscreenController.mm
Diff
Modified: trunk/Source/WebCore/ChangeLog (167002 => 167003)
--- trunk/Source/WebCore/ChangeLog 2014-04-09 06:25:37 UTC (rev 167002)
+++ trunk/Source/WebCore/ChangeLog 2014-04-09 06:31:24 UTC (rev 167003)
@@ -1,3 +1,18 @@
+2014-04-08 Conrad Shultz
+
+nil should only be used for objects
+https://bugs.webkit.org/show_bug.cgi?id=131431
+
+Reviewed by Chris Fleizach.
+
+* accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
+(-[WebAccessibilityObjectWrapper accessibilityIsAttributeSettable:]):
+nil -> NO.
+
+* platform/mac/WebVideoFullscreenController.mm:
+(-[WebVideoFullscreenController setMediaElement:]):
+nil -> 0; change a NULL to nullptr while we're here.
+
2014-04-08 Mihnea Ovidenie
[CSSRegions] Crash when video in region exits fullscreen
Modified: trunk/Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm (167002 => 167003)
--- trunk/Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm 2014-04-09 06:25:37 UTC (rev 167002)
+++ trunk/Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm 2014-04-09 06:31:24 UTC (rev 167003)
@@ -2968,7 +2968,7 @@
- (BOOL)accessibilityIsAttributeSettable:(NSString*)attributeName
{
if (![self updateObjectBackingStore])
-return nil;
+return NO;
if ([attributeName isEqualToString: @"AXSelectedTextMarkerRange"])
return YES;
Modified: trunk/Source/WebCore/platform/mac/WebVideoFullscreenController.mm (167002 => 167003)
--- trunk/Source/WebCore/platform/mac/WebVideoFullscreenController.mm 2014-04-09 06:25:37 UTC (rev 167002)
+++ trunk/Source/WebCore/platform/mac/WebVideoFullscreenController.mm 2014-04-09 06:31:24 UTC (rev 167003)
@@ -144,7 +144,7 @@
[self setupVideoOverlay:layer];
[layer setPlayer:player];
-[player addObserver:self forKeyPath:@"rate" options:nil context:NULL];
+[player addObserver:self forKeyPath:@"rate" options:0 context:nullptr];
}
}
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [167002] trunk/Source/WebKit2
Title: [167002] trunk/Source/WebKit2
Revision 167002
Author commit-qu...@webkit.org
Date 2014-04-08 23:25:37 -0700 (Tue, 08 Apr 2014)
Log Message
Fix EFL Build errors since r166975.
https://bugs.webkit.org/show_bug.cgi?id=131421
Patch by Hyowon Kim on 2014-04-08
Reviewed by Gyuyoung Kim.
This patch is just for fixing EFL build errors.
The page overlay functionality is not working yet.
* CMakeLists.txt:
* WebProcess/WebPage/CoordinatedGraphics/CoordinatedDrawingArea.cpp:
(WebKit::CoordinatedDrawingArea::display):
* WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp:
(WebKit::CoordinatedLayerTreeHost::CoordinatedLayerTreeHost):
(WebKit::CoordinatedLayerTreeHost::paintLayerContents):
* WebProcess/WebPage/PageOverlayController.cpp:
* WebProcess/WebPage/TapHighlightController.cpp:
(WebKit::TapHighlightController::hideHighlight):
Modified Paths
trunk/Source/WebKit2/CMakeLists.txt
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/CoordinatedDrawingArea.cpp
trunk/Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp
trunk/Source/WebKit2/WebProcess/WebPage/PageOverlayController.cpp
trunk/Source/WebKit2/WebProcess/WebPage/TapHighlightController.cpp
Diff
Modified: trunk/Source/WebKit2/CMakeLists.txt (167001 => 167002)
--- trunk/Source/WebKit2/CMakeLists.txt 2014-04-09 06:18:00 UTC (rev 167001)
+++ trunk/Source/WebKit2/CMakeLists.txt 2014-04-09 06:25:37 UTC (rev 167002)
@@ -543,6 +543,7 @@
WebProcess/WebPage/LayerTreeHost.cpp
WebProcess/WebPage/PageBanner.cpp
WebProcess/WebPage/PageOverlay.cpp
+WebProcess/WebPage/PageOverlayController.cpp
WebProcess/WebPage/TapHighlightController.cpp
WebProcess/WebPage/WebBackForwardListProxy.cpp
WebProcess/WebPage/WebContextMenu.cpp
Modified: trunk/Source/WebKit2/ChangeLog (167001 => 167002)
--- trunk/Source/WebKit2/ChangeLog 2014-04-09 06:18:00 UTC (rev 167001)
+++ trunk/Source/WebKit2/ChangeLog 2014-04-09 06:25:37 UTC (rev 167002)
@@ -1,3 +1,23 @@
+2014-04-08 Hyowon Kim
+
+Fix EFL Build errors since r166975.
+https://bugs.webkit.org/show_bug.cgi?id=131421
+
+Reviewed by Gyuyoung Kim.
+
+This patch is just for fixing EFL build errors.
+The page overlay functionality is not working yet.
+
+* CMakeLists.txt:
+* WebProcess/WebPage/CoordinatedGraphics/CoordinatedDrawingArea.cpp:
+(WebKit::CoordinatedDrawingArea::display):
+* WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp:
+(WebKit::CoordinatedLayerTreeHost::CoordinatedLayerTreeHost):
+(WebKit::CoordinatedLayerTreeHost::paintLayerContents):
+* WebProcess/WebPage/PageOverlayController.cpp:
+* WebProcess/WebPage/TapHighlightController.cpp:
+(WebKit::TapHighlightController::hideHighlight):
+
2014-04-08 Jon Lee
Turn MSE on by default
Modified: trunk/Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/CoordinatedDrawingArea.cpp (167001 => 167002)
--- trunk/Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/CoordinatedDrawingArea.cpp 2014-04-09 06:18:00 UTC (rev 167001)
+++ trunk/Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/CoordinatedDrawingArea.cpp 2014-04-09 06:25:37 UTC (rev 167002)
@@ -607,14 +607,6 @@
for (size_t i = 0; i < rects.size(); ++i) {
m_webPage->drawRect(*graphicsContext, rects[i]);
-
-if (m_webPage->hasPageOverlay()) {
-PageOverlayList& pageOverlays = m_webPage->pageOverlays();
-PageOverlayList::iterator end = pageOverlays.end();
-for (PageOverlayList::iterator it = pageOverlays.begin(); it != end; ++it)
-m_webPage->drawPageOverlay(it->get(), *graphicsContext, rects[i]);
-}
-
updateInfo.updateRects.append(rects[i]);
}
Modified: trunk/Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp (167001 => 167002)
--- trunk/Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp 2014-04-09 06:18:00 UTC (rev 167001)
+++ trunk/Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp 2014-04-09 06:25:37 UTC (rev 167002)
@@ -73,9 +73,6 @@
CoordinatedSurface::setFactory(createCoordinatedSurface);
-if (webPage->hasPageOverlay())
-createPageOverlayLayer();
-
scheduleLayerFlush();
}
@@ -265,12 +262,6 @@
void CoordinatedLayerTreeHost::paintLayerContents(const GraphicsLayer* graphicsLayer, GraphicsContext& graphicsContext, const IntRect& clipRect)
{
-if (graphicsLayer == m_pageOverlayLayer.get()) {
-// Overlays contain transparent contents and won't clear the context as part of their rendering, so we do it here.
-graphicsContext.clearRect(clipRect);
-m_webPage->drawPageOverlay(m_pageOverlay.get(), graphicsContext, clipRect);
-return;
-}
}
void CoordinatedLayerTreeHost::commitScene
[webkit-changes] [167000] trunk/LayoutTests
Title: [167000] trunk/LayoutTests Revision 167000 Author a...@apple.com Date 2014-04-08 23:13:10 -0700 (Tue, 08 Apr 2014) Log Message Trying to unbreak flakiness dashboard after Gtk TextExpectations reshuffling. * platform/gtk-wk2/TestExpectations: Added. Modified Paths trunk/LayoutTests/ChangeLog Added Paths trunk/LayoutTests/platform/gtk-wk2/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (166999 => 167000) --- trunk/LayoutTests/ChangeLog 2014-04-09 05:25:36 UTC (rev 166999) +++ trunk/LayoutTests/ChangeLog 2014-04-09 06:13:10 UTC (rev 167000) @@ -1,3 +1,9 @@ +2014-04-08 Alexey Proskuryakov + +Trying to unbreak flakiness dashboard after Gtk TextExpectations reshuffling. + +* platform/gtk-wk2/TestExpectations: Added. + 2014-04-08 Zalan Bujtas Subpixel rendering: Clip outer rounded border rect on device pixel boundaries. Added: trunk/LayoutTests/platform/gtk-wk2/TestExpectations (0 => 167000) --- trunk/LayoutTests/platform/gtk-wk2/TestExpectations (rev 0) +++ trunk/LayoutTests/platform/gtk-wk2/TestExpectations 2014-04-09 06:13:10 UTC (rev 167000) @@ -0,0 +1,2 @@ +# This empty file is needed for flakiness dashboard to work. +# FIXME: Remove once the flakiness dashboard is updated to not load this file. ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [166999] trunk/Source/WebCore
Title: [166999] trunk/Source/WebCore
Revision 166999
Author cfleiz...@apple.com
Date 2014-04-08 22:25:36 -0700 (Tue, 08 Apr 2014)
Log Message
Unreviewed build fix for iOS (redux).
* accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:
(-[WebAccessibilityObjectWrapper accessibilityARIAIsBusy]):
(-[WebAccessibilityObjectWrapper accessibilityARIALiveRegionIsAtomic]):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm
Diff
Modified: trunk/Source/WebCore/ChangeLog (166998 => 166999)
--- trunk/Source/WebCore/ChangeLog 2014-04-09 05:23:27 UTC (rev 166998)
+++ trunk/Source/WebCore/ChangeLog 2014-04-09 05:25:36 UTC (rev 166999)
@@ -1,4 +1,12 @@
2014-04-08 Chris Fleizach
+
+Unreviewed build fix for iOS (redux).
+
+* accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:
+(-[WebAccessibilityObjectWrapper accessibilityARIAIsBusy]):
+(-[WebAccessibilityObjectWrapper accessibilityARIALiveRegionIsAtomic]):
+
+2014-04-08 Chris Fleizach
Unreviewed build fix for iOS.
Modified: trunk/Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm (166998 => 166999)
--- trunk/Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm 2014-04-09 05:23:27 UTC (rev 166998)
+++ trunk/Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm 2014-04-09 05:25:36 UTC (rev 166999)
@@ -2065,7 +2065,7 @@
- (BOOL)accessibilityARIAIsBusy
{
if (![self _prepareAccessibilityCall])
-return nil;
+return NO;
return m_object->ariaLiveRegionBusy();
}
@@ -2089,7 +2089,7 @@
- (BOOL)accessibilityARIALiveRegionIsAtomic
{
if (![self _prepareAccessibilityCall])
-return nil;
+return NO;
return m_object->ariaLiveRegionAtomic();
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [166998] trunk/Source/WebCore
Title: [166998] trunk/Source/WebCore
Revision 166998
Author cfleiz...@apple.com
Date 2014-04-08 22:23:27 -0700 (Tue, 08 Apr 2014)
Log Message
Unreviewed build fix for iOS.
* accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:
(-[WebAccessibilityObjectWrapper accessibilityElementCount]):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm
Diff
Modified: trunk/Source/WebCore/ChangeLog (166997 => 166998)
--- trunk/Source/WebCore/ChangeLog 2014-04-09 05:01:54 UTC (rev 166997)
+++ trunk/Source/WebCore/ChangeLog 2014-04-09 05:23:27 UTC (rev 166998)
@@ -1,3 +1,10 @@
+2014-04-08 Chris Fleizach
+
+Unreviewed build fix for iOS.
+
+* accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:
+(-[WebAccessibilityObjectWrapper accessibilityElementCount]):
+
2014-04-08 Antti Koivisto
Factor tile coverage map into a class
Modified: trunk/Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm (166997 => 166998)
--- trunk/Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm 2014-04-09 05:01:54 UTC (rev 166997)
+++ trunk/Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm 2014-04-09 05:23:27 UTC (rev 166998)
@@ -335,7 +335,7 @@
- (NSInteger)accessibilityElementCount
{
if (![self _prepareAccessibilityCall])
-return nil;
+return 0;
AXAttributeCacheEnabler enableCache(m_object->axObjectCache());
if ([self isAttachment])
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [166997] trunk/Source/WebCore
Title: [166997] trunk/Source/WebCore Revision 166997 Author an...@apple.com Date 2014-04-08 22:01:54 -0700 (Tue, 08 Apr 2014) Log Message Factor tile coverage map into a class https://bugs.webkit.org/show_bug.cgi?id=131417 Reviewed by Tim Horton. * WebCore.xcodeproj/project.pbxproj: * platform/graphics/ca/PlatformCALayerClient.h: (WebCore::PlatformCALayerClient::platformCALayerLayoutSublayersOfLayer): (WebCore::PlatformCALayerClient::platformCALayerRespondsToLayoutChanges): (WebCore::PlatformCALayerClient::platformCALayerAnimationStarted): (WebCore::PlatformCALayerClient::platformCALayerContentsOrientation): (WebCore::PlatformCALayerClient::platformCALayerShowDebugBorders): (WebCore::PlatformCALayerClient::platformCALayerShowRepaintCounter): (WebCore::PlatformCALayerClient::platformCALayerIncrementRepaintCount): (WebCore::PlatformCALayerClient::platformCALayerLayerDidDisplay): Added default implementation to some of these to make clients less messy. * platform/graphics/ca/mac/TileController.h: * platform/graphics/ca/mac/TileController.mm: (WebCore::TileController::~TileController): (WebCore::TileController::platformCALayerPaintContents): (WebCore::TileController::setTiledScrollingIndicatorPosition): (WebCore::TileController::updateTileCoverageMap): (WebCore::TileController::tiledScrollingIndicatorLayer): * platform/graphics/ca/mac/TileCoverageMap.h: Added. (WebCore::TileCoverageMap::setPosition): (WebCore::TileCoverageMap::layer): * platform/graphics/ca/mac/TileCoverageMap.mm: Added. The new class. (WebCore::TileCoverageMap::TileCoverageMap): (WebCore::TileCoverageMap::~TileCoverageMap): (WebCore::TileCoverageMap::update): (WebCore::TileCoverageMap::platformCALayerPaintContents): (WebCore::TileCoverageMap::platformCALayerDeviceScaleFactor): * platform/graphics/ca/mac/TileGrid.h: * platform/graphics/ca/mac/TileGrid.mm: (WebCore::TileGrid::drawTileMapContents): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj trunk/Source/WebCore/platform/graphics/ca/PlatformCALayerClient.h trunk/Source/WebCore/platform/graphics/ca/mac/TileController.h trunk/Source/WebCore/platform/graphics/ca/mac/TileController.mm trunk/Source/WebCore/platform/graphics/ca/mac/TileGrid.h trunk/Source/WebCore/platform/graphics/ca/mac/TileGrid.mm Added Paths trunk/Source/WebCore/platform/graphics/ca/mac/TileCoverageMap.h trunk/Source/WebCore/platform/graphics/ca/mac/TileCoverageMap.mm Diff Modified: trunk/Source/WebCore/ChangeLog (166996 => 166997) --- trunk/Source/WebCore/ChangeLog 2014-04-09 03:52:53 UTC (rev 166996) +++ trunk/Source/WebCore/ChangeLog 2014-04-09 05:01:54 UTC (rev 166997) @@ -1,3 +1,46 @@ +2014-04-08 Antti Koivisto + +Factor tile coverage map into a class +https://bugs.webkit.org/show_bug.cgi?id=131417 + +Reviewed by Tim Horton. + +* WebCore.xcodeproj/project.pbxproj: +* platform/graphics/ca/PlatformCALayerClient.h: +(WebCore::PlatformCALayerClient::platformCALayerLayoutSublayersOfLayer): +(WebCore::PlatformCALayerClient::platformCALayerRespondsToLayoutChanges): +(WebCore::PlatformCALayerClient::platformCALayerAnimationStarted): +(WebCore::PlatformCALayerClient::platformCALayerContentsOrientation): +(WebCore::PlatformCALayerClient::platformCALayerShowDebugBorders): +(WebCore::PlatformCALayerClient::platformCALayerShowRepaintCounter): +(WebCore::PlatformCALayerClient::platformCALayerIncrementRepaintCount): +(WebCore::PlatformCALayerClient::platformCALayerLayerDidDisplay): + +Added default implementation to some of these to make clients less messy. + +* platform/graphics/ca/mac/TileController.h: +* platform/graphics/ca/mac/TileController.mm: +(WebCore::TileController::~TileController): +(WebCore::TileController::platformCALayerPaintContents): +(WebCore::TileController::setTiledScrollingIndicatorPosition): +(WebCore::TileController::updateTileCoverageMap): +(WebCore::TileController::tiledScrollingIndicatorLayer): +* platform/graphics/ca/mac/TileCoverageMap.h: Added. +(WebCore::TileCoverageMap::setPosition): +(WebCore::TileCoverageMap::layer): +* platform/graphics/ca/mac/TileCoverageMap.mm: Added. + +The new class. + +(WebCore::TileCoverageMap::TileCoverageMap): +(WebCore::TileCoverageMap::~TileCoverageMap): +(WebCore::TileCoverageMap::update): +(WebCore::TileCoverageMap::platformCALayerPaintContents): +(WebCore::TileCoverageMap::platformCALayerDeviceScaleFactor): +* platform/graphics/ca/mac/TileGrid.h: +* platform/graphics/ca/mac/TileGrid.mm: +(WebCore::TileGrid::drawTileMapContents): + 2014-04-08 Zalan Bujtas Subpixel rendering: Clip outer rounded border rect on device pixel boundaries. Modified: trunk/Source/WebCore
[webkit-changes] [166996] trunk
Title: [166996] trunk
Revision 166996
Author za...@apple.com
Date 2014-04-08 20:52:53 -0700 (Tue, 08 Apr 2014)
Log Message
Subpixel rendering: Clip outer rounded border rect on device pixel boundaries.
https://bugs.webkit.org/show_bug.cgi?id=131404
Reviewed by Simon Fraser.
Use device pixel snapped rectangle to clip out rounded rects, when not all sides are solid/double.
Snapping it to device pixel boundaries ensures that when we call drawRect(devicePixelSnappedRect) later,
it leaves no cruft behind.
Source/WebCore:
Test: fast/borders/hidpi-rounded-border-on-subpixel-position.html
* rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::paintBorder):
LayoutTests:
* fast/borders/hidpi-rounded-border-on-subpixel-position-expected.html: Added.
* fast/borders/hidpi-rounded-border-on-subpixel-position.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderBoxModelObject.cpp
Added Paths
trunk/LayoutTests/fast/borders/hidpi-rounded-border-on-subpixel-position-expected.html
trunk/LayoutTests/fast/borders/hidpi-rounded-border-on-subpixel-position.html
Diff
Modified: trunk/LayoutTests/ChangeLog (166995 => 166996)
--- trunk/LayoutTests/ChangeLog 2014-04-09 03:25:45 UTC (rev 166995)
+++ trunk/LayoutTests/ChangeLog 2014-04-09 03:52:53 UTC (rev 166996)
@@ -1,3 +1,17 @@
+2014-04-08 Zalan Bujtas
+
+Subpixel rendering: Clip outer rounded border rect on device pixel boundaries.
+https://bugs.webkit.org/show_bug.cgi?id=131404
+
+Reviewed by Simon Fraser.
+
+Use device pixel snapped rectangle to clip out rounded rects, when not all sides are solid/double.
+Snapping it to device pixel boundaries ensures that when we call drawRect(devicePixelSnappedRect) later,
+it leaves no cruft behind.
+
+* fast/borders/hidpi-rounded-border-on-subpixel-position-expected.html: Added.
+* fast/borders/hidpi-rounded-border-on-subpixel-position.html: Added.
+
2014-04-08 Simon Fraser
REGRESSION (r155998): Elements render at very low resolution with some 3d transforms
Added: trunk/LayoutTests/fast/borders/hidpi-rounded-border-on-subpixel-position-expected.html (0 => 166996)
--- trunk/LayoutTests/fast/borders/hidpi-rounded-border-on-subpixel-position-expected.html (rev 0)
+++ trunk/LayoutTests/fast/borders/hidpi-rounded-border-on-subpixel-position-expected.html 2014-04-09 03:52:53 UTC (rev 166996)
@@ -0,0 +1,7 @@
+
+
+
+ This test if rounded rects on subpixel positions leave cruft behind.
+
+
+
Added: trunk/LayoutTests/fast/borders/hidpi-rounded-border-on-subpixel-position.html (0 => 166996)
--- trunk/LayoutTests/fast/borders/hidpi-rounded-border-on-subpixel-position.html (rev 0)
+++ trunk/LayoutTests/fast/borders/hidpi-rounded-border-on-subpixel-position.html 2014-04-09 03:52:53 UTC (rev 166996)
@@ -0,0 +1,49 @@
+
+
+
+This test if rounded rects on subpixel positions leave cruft behind.
+
+ div {
+position: fixed;
+ }
+
+ .roundedRect {
+ border-width: 0px 0px 0px 1px;
+ border-style: solid;
+ border-top-left-radius: 1px;
+ border-color: black;
+ }
+
+
+
+
+
+ var container = document.getElementById("container");
+ adjustment = 0.1;
+ w = 5; h = 5;
+ for (i = 0; i < 20; ++i) {
+adjustment += 0.1;
+for (j = 0; j < 15; ++j) {
+ var e = document.createElement("div");
+ e.className = "roundedRect";
+ e.style.top = ((w + 1) * i + j * adjustment) + "px";
+ e.style.left = ((w + 1) * j + i * adjustment) + "px";
+ e.style.width = w + "px";
+ e.style.height = h + "px";
+ container.appendChild(e);
+
+ var p = document.createElement("div");
+ p.style.top = ((w + 1) * i + j * adjustment) + "px";
+ p.style.left = ((w + 1) * j + i * adjustment) + "px";
+ p.style.width = w + "px";
+ p.style.height = h + "px";
+ p.style.borderLeft = "solid 1px white";
+ container.appendChild(p);
+
+ w += 0.1;
+ h += 0.1;
+}
+ }
+
+
+
Modified: trunk/Source/WebCore/ChangeLog (166995 => 166996)
--- trunk/Source/WebCore/ChangeLog 2014-04-09 03:25:45 UTC (rev 166995)
+++ trunk/Source/WebCore/ChangeLog 2014-04-09 03:52:53 UTC (rev 166996)
@@ -1,3 +1,19 @@
+2014-04-08 Zalan Bujtas
+
+Subpixel rendering: Clip outer rounded border rect on device pixel boundaries.
+https://bugs.webkit.org/show_bug.cgi?id=131404
+
+Reviewed by Simon Fraser.
+
+Use device pixel snapped rectangle to clip out rounded rects, when not all sides are solid/double.
+Snapping it to device pixel boundaries ensures that when we call drawRect(devicePixelSnappedRect) later,
+it leaves no cruft behind.
+
+Test: fast/borders/hidpi-rounded-border-on-subpixel-position.html
+
+* rendering/RenderBoxModelObject.cpp:
+(WebCore::RenderBoxModelObject::paintBorder):
+
2014-04-08 Jon Lee
Turn MSE
[webkit-changes] [166995] trunk/Websites/perf.webkit.org
Title: [166995] trunk/Websites/perf.webkit.org
Revision 166995
Author rn...@webkit.org
Date 2014-04-08 20:25:45 -0700 (Tue, 08 Apr 2014)
Log Message
Build fix after r166479. 'bytes' is now abbreviated as 'B'.
* public/js/helper-classes.js:
(PerfTestRuns.smallerIsBetter):
Modified Paths
trunk/Websites/perf.webkit.org/ChangeLog
trunk/Websites/perf.webkit.org/public/js/helper-classes.js
Diff
Modified: trunk/Websites/perf.webkit.org/ChangeLog (166994 => 166995)
--- trunk/Websites/perf.webkit.org/ChangeLog 2014-04-09 02:54:45 UTC (rev 166994)
+++ trunk/Websites/perf.webkit.org/ChangeLog 2014-04-09 03:25:45 UTC (rev 166995)
@@ -1,5 +1,12 @@
2014-04-08 Ryosuke Niwa
+Build fix after r166479. 'bytes' is now abbreviated as 'B'.
+
+* public/js/helper-classes.js:
+(PerfTestRuns.smallerIsBetter):
+
+2014-04-08 Ryosuke Niwa
+
Some CSS teaks.
* public/common.css:
Modified: trunk/Websites/perf.webkit.org/public/js/helper-classes.js (166994 => 166995)
--- trunk/Websites/perf.webkit.org/public/js/helper-classes.js 2014-04-09 02:54:45 UTC (rev 166994)
+++ trunk/Websites/perf.webkit.org/public/js/helper-classes.js 2014-04-09 03:25:45 UTC (rev 166995)
@@ -247,7 +247,7 @@
computeScalingFactorIfNeeded();
return cachedUnit;
}
-this.smallerIsBetter = function() { return unit == 'ms' || unit == 'bytes' || unit == ''; }
+this.smallerIsBetter = function() { return unit == 'ms' || unit == 'B' || unit == ''; }
}
var URLState = new (function () {
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [166994] trunk/Websites/perf.webkit.org
Title: [166994] trunk/Websites/perf.webkit.org
Revision 166994
Author rn...@webkit.org
Date 2014-04-08 19:54:45 -0700 (Tue, 08 Apr 2014)
Log Message
Some CSS teaks.
* public/common.css:
(#title):
* public/index.html:
(#charts .pane):
(#charts .arrow):
Modified Paths
trunk/Websites/perf.webkit.org/ChangeLog
trunk/Websites/perf.webkit.org/public/common.css
trunk/Websites/perf.webkit.org/public/index.html
Diff
Modified: trunk/Websites/perf.webkit.org/ChangeLog (166993 => 166994)
--- trunk/Websites/perf.webkit.org/ChangeLog 2014-04-09 02:18:52 UTC (rev 166993)
+++ trunk/Websites/perf.webkit.org/ChangeLog 2014-04-09 02:54:45 UTC (rev 166994)
@@ -1,3 +1,13 @@
+2014-04-08 Ryosuke Niwa
+
+Some CSS teaks.
+
+* public/common.css:
+(#title):
+* public/index.html:
+(#charts .pane):
+(#charts .arrow):
+
2014-04-03 Ryosuke Niwa
WebKitPerfMonitor: There should be a way to add all metrics of a suite without also adding subtests
Modified: trunk/Websites/perf.webkit.org/public/common.css (166993 => 166994)
--- trunk/Websites/perf.webkit.org/public/common.css 2014-04-09 02:18:52 UTC (rev 166993)
+++ trunk/Websites/perf.webkit.org/public/common.css 2014-04-09 02:54:45 UTC (rev 166994)
@@ -12,6 +12,7 @@
#title {
position: relative;
+padding-bottom: 0.5em;
}
#title h1 {
Modified: trunk/Websites/perf.webkit.org/public/index.html (166993 => 166994)
--- trunk/Websites/perf.webkit.org/public/index.html 2014-04-09 02:18:52 UTC (rev 166993)
+++ trunk/Websites/perf.webkit.org/public/index.html 2014-04-09 02:54:45 UTC (rev 166994)
@@ -59,7 +59,7 @@
position: absolute;
left: 10px;
top: 10px;
-width: 220px;
+width: 230px;
}
.chart header {
@@ -206,7 +206,7 @@
height: 40px;
position: absolute;
top: 10px;
-left: 220px;
+left: 240px;
}
.chart svg {
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [166993] trunk/Source
Title: [166993] trunk/Source Revision 166993 Author jon...@apple.com Date 2014-04-08 19:18:52 -0700 (Tue, 08 Apr 2014) Log Message Turn MSE on by default https://bugs.webkit.org/show_bug.cgi?id=131313 Reviewed by Jer Noble. Source/_javascript_Core: * Configurations/FeatureDefines.xcconfig: Source/WebCore: * Configurations/FeatureDefines.xcconfig: * page/Settings.in: Add MEDIA_SOURCE conditional. Source/WebKit/mac: * Configurations/FeatureDefines.xcconfig: * WebView/WebPreferences.mm: (+[WebPreferences initialize]): Set default to true. Source/WebKit2: * Configurations/FeatureDefines.xcconfig: * Shared/WebPreferencesStore.h: Set default to true. * UIProcess/API/C/WKPreferencesRefPrivate.h: Modified Paths trunk/Source/_javascript_Core/ChangeLog trunk/Source/_javascript_Core/Configurations/FeatureDefines.xcconfig trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/Configurations/FeatureDefines.xcconfig trunk/Source/WebCore/page/Settings.in trunk/Source/WebKit/mac/ChangeLog trunk/Source/WebKit/mac/Configurations/FeatureDefines.xcconfig trunk/Source/WebKit/mac/WebView/WebPreferences.mm trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/Configurations/FeatureDefines.xcconfig trunk/Source/WebKit2/Shared/WebPreferencesStore.h trunk/Source/WebKit2/UIProcess/API/C/WKPreferencesRefPrivate.h Diff Modified: trunk/Source/_javascript_Core/ChangeLog (166992 => 166993) --- trunk/Source/_javascript_Core/ChangeLog 2014-04-09 01:45:43 UTC (rev 166992) +++ trunk/Source/_javascript_Core/ChangeLog 2014-04-09 02:18:52 UTC (rev 166993) @@ -1,3 +1,13 @@ +2014-04-08 Jon Lee + +Turn MSE on by default +https://bugs.webkit.org/show_bug.cgi?id=131313 + + +Reviewed by Jer Noble. + +* Configurations/FeatureDefines.xcconfig: + 2014-04-08 Joseph Pecoraro Web Inspector: Prevent deadlocks receiving WIRPermissionDenied message Modified: trunk/Source/_javascript_Core/Configurations/FeatureDefines.xcconfig (166992 => 166993) --- trunk/Source/_javascript_Core/Configurations/FeatureDefines.xcconfig 2014-04-09 01:45:43 UTC (rev 166992) +++ trunk/Source/_javascript_Core/Configurations/FeatureDefines.xcconfig 2014-04-09 02:18:52 UTC (rev 166993) @@ -142,7 +142,10 @@ ENABLE_LINK_PREFETCH = ; ENABLE_MATHML = ENABLE_MATHML; ENABLE_MEDIA_CONTROLS_SCRIPT = ENABLE_MEDIA_CONTROLS_SCRIPT; -ENABLE_MEDIA_SOURCE = ENABLE_MEDIA_SOURCE; + +ENABLE_MEDIA_SOURCE = $(ENABLE_MEDIA_SOURCE_$(PLATFORM_NAME)); +ENABLE_MEDIA_SOURCE_macosx = ENABLE_MEDIA_SOURCE; + ENABLE_MEDIA_STATISTICS = ; ENABLE_METER_ELEMENT = $(ENABLE_METER_ELEMENT_$(PLATFORM_NAME)); ENABLE_METER_ELEMENT_macosx = ENABLE_METER_ELEMENT; Modified: trunk/Source/WebCore/ChangeLog (166992 => 166993) --- trunk/Source/WebCore/ChangeLog 2014-04-09 01:45:43 UTC (rev 166992) +++ trunk/Source/WebCore/ChangeLog 2014-04-09 02:18:52 UTC (rev 166993) @@ -1,3 +1,14 @@ +2014-04-08 Jon Lee + +Turn MSE on by default +https://bugs.webkit.org/show_bug.cgi?id=131313 + + +Reviewed by Jer Noble. + +* Configurations/FeatureDefines.xcconfig: +* page/Settings.in: Add MEDIA_SOURCE conditional. + 2014-04-08 Anders Carlsson Remove an unused parameter from loadResource. Modified: trunk/Source/WebCore/Configurations/FeatureDefines.xcconfig (166992 => 166993) --- trunk/Source/WebCore/Configurations/FeatureDefines.xcconfig 2014-04-09 01:45:43 UTC (rev 166992) +++ trunk/Source/WebCore/Configurations/FeatureDefines.xcconfig 2014-04-09 02:18:52 UTC (rev 166993) @@ -142,7 +142,10 @@ ENABLE_LINK_PREFETCH = ; ENABLE_MATHML = ENABLE_MATHML; ENABLE_MEDIA_CONTROLS_SCRIPT = ENABLE_MEDIA_CONTROLS_SCRIPT; -ENABLE_MEDIA_SOURCE = ENABLE_MEDIA_SOURCE; + +ENABLE_MEDIA_SOURCE = $(ENABLE_MEDIA_SOURCE_$(PLATFORM_NAME)); +ENABLE_MEDIA_SOURCE_macosx = ENABLE_MEDIA_SOURCE; + ENABLE_MEDIA_STATISTICS = ; ENABLE_METER_ELEMENT = $(ENABLE_METER_ELEMENT_$(PLATFORM_NAME)); ENABLE_METER_ELEMENT_macosx = ENABLE_METER_ELEMENT; Modified: trunk/Source/WebCore/page/Settings.in (166992 => 166993) --- trunk/Source/WebCore/page/Settings.in 2014-04-09 01:45:43 UTC (rev 166992) +++ trunk/Source/WebCore/page/Settings.in 2014-04-09 02:18:52 UTC (rev 166993) @@ -197,7 +197,7 @@ simpleLineLayoutEnabled initial=true, setNeedsStyleRecalcInAllFrames=1 simpleLineLayoutDebugBordersEnabled initial=false, setNeedsStyleRecalcInAllFrames=1 -mediaSourceEnabled initial=false +mediaSourceEnabled initial=true, conditional=MEDIA_SOURCE # FIXME: Rename to allowMultiElementImplicitFormSubmission once we upstream the iOS changes to WebView.mm. allowMultiElementImplicitSubmission initial=false Modified: trunk/Source/WebKit/mac/ChangeLog (166992 => 166993) --- trunk/Source/WebKit/mac/ChangeLog 2014-04-09 01:45:43 UTC (rev 166992) +++ trunk/Source/WebKit/mac/ChangeLog 2014-04-09 02:18:52 UTC (rev 166993) @@ -1,3 +1,15 @@ +2014-04-08 Jon Lee + +Turn MSE on by default +https://bugs.webkit.org/show_
[webkit-changes] [166992] trunk/Source/WebCore
Title: [166992] trunk/Source/WebCore
Revision 166992
Author ander...@apple.com
Date 2014-04-08 18:45:43 -0700 (Tue, 08 Apr 2014)
Log Message
Remove an unused parameter from loadResource.
Reviewed by Darin Adler.
Since the CachedResourceRequest has the charset in it, we don't need to pass it separately to loadRequest.
* loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::requestResource):
(WebCore::CachedResourceLoader::loadResource):
* loader/cache/CachedResourceLoader.h:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/loader/cache/CachedResourceLoader.cpp
trunk/Source/WebCore/loader/cache/CachedResourceLoader.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (166991 => 166992)
--- trunk/Source/WebCore/ChangeLog 2014-04-09 01:25:35 UTC (rev 166991)
+++ trunk/Source/WebCore/ChangeLog 2014-04-09 01:45:43 UTC (rev 166992)
@@ -1,3 +1,16 @@
+2014-04-08 Anders Carlsson
+
+Remove an unused parameter from loadResource.
+
+Reviewed by Darin Adler.
+
+Since the CachedResourceRequest has the charset in it, we don't need to pass it separately to loadRequest.
+
+* loader/cache/CachedResourceLoader.cpp:
+(WebCore::CachedResourceLoader::requestResource):
+(WebCore::CachedResourceLoader::loadResource):
+* loader/cache/CachedResourceLoader.h:
+
2014-04-08 Ryuan Choi
Unreviewed EFL build fix attempt since r166956
Modified: trunk/Source/WebCore/loader/cache/CachedResourceLoader.cpp (166991 => 166992)
--- trunk/Source/WebCore/loader/cache/CachedResourceLoader.cpp 2014-04-09 01:25:35 UTC (rev 166991)
+++ trunk/Source/WebCore/loader/cache/CachedResourceLoader.cpp 2014-04-09 01:45:43 UTC (rev 166992)
@@ -451,7 +451,7 @@
memoryCache()->remove(resource.get());
FALLTHROUGH;
case Load:
-resource = loadResource(type, request, request.charset());
+resource = loadResource(type, request);
break;
case Revalidate:
resource = revalidateResource(request, resource.get());
@@ -514,13 +514,13 @@
return newResource;
}
-CachedResourceHandle CachedResourceLoader::loadResource(CachedResource::Type type, CachedResourceRequest& request, const String& charset)
+CachedResourceHandle CachedResourceLoader::loadResource(CachedResource::Type type, CachedResourceRequest& request)
{
ASSERT(!memoryCache()->resourceForRequest(request.resourceRequest(), sessionID()));
LOG(ResourceLoading, "Loading CachedResource for '%s'.", request.resourceRequest().url().stringCenterEllipsizedToLength().latin1().data());
-CachedResourceHandle resource = createResource(type, request.mutableResourceRequest(), charset, sessionID());
+CachedResourceHandle resource = createResource(type, request.mutableResourceRequest(), request.charset(), sessionID());
if (!memoryCache()->add(resource.get()))
resource->setOwningCachedResourceLoader(this);
Modified: trunk/Source/WebCore/loader/cache/CachedResourceLoader.h (166991 => 166992)
--- trunk/Source/WebCore/loader/cache/CachedResourceLoader.h 2014-04-09 01:25:35 UTC (rev 166991)
+++ trunk/Source/WebCore/loader/cache/CachedResourceLoader.h 2014-04-09 01:45:43 UTC (rev 166992)
@@ -138,7 +138,7 @@
CachedResourceHandle requestResource(CachedResource::Type, CachedResourceRequest&);
CachedResourceHandle revalidateResource(const CachedResourceRequest&, CachedResource*);
-CachedResourceHandle loadResource(CachedResource::Type, CachedResourceRequest&, const String& charset);
+CachedResourceHandle loadResource(CachedResource::Type, CachedResourceRequest&);
#if ENABLE(RESOURCE_TIMING)
void storeResourceTimingInitiatorInformation(const CachedResourceHandle&, const CachedResourceRequest&);
#endif
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [166989] trunk/Source/WebCore
Title: [166989] trunk/Source/WebCore
Revision 166989
Author ander...@apple.com
Date 2014-04-08 18:11:15 -0700 (Tue, 08 Apr 2014)
Log Message
Don't call CGPathAddPath with invalid CGAffineTransform objects
https://bugs.webkit.org/show_bug.cgi?id=131413
Reviewed by Darin Adler.
Covered by existing tests.
* platform/graphics/cg/PathCG.cpp:
(WebCore::Path::addPath):
Don't try to add the path if the affine transform isn't invertible.
* platform/graphics/transforms/AffineTransform.cpp:
(WebCore::AffineTransform::isInvertible):
Handle infinite and NaN determinants.
(WebCore::AffineTransform::inverse):
Handle infinite and NaN determinants.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/cg/PathCG.cpp
trunk/Source/WebCore/platform/graphics/transforms/AffineTransform.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (166988 => 166989)
--- trunk/Source/WebCore/ChangeLog 2014-04-09 00:47:21 UTC (rev 166988)
+++ trunk/Source/WebCore/ChangeLog 2014-04-09 01:11:15 UTC (rev 166989)
@@ -1,3 +1,24 @@
+2014-04-08 Anders Carlsson
+
+Don't call CGPathAddPath with invalid CGAffineTransform objects
+https://bugs.webkit.org/show_bug.cgi?id=131413
+
+
+Reviewed by Darin Adler.
+
+Covered by existing tests.
+
+* platform/graphics/cg/PathCG.cpp:
+(WebCore::Path::addPath):
+Don't try to add the path if the affine transform isn't invertible.
+
+* platform/graphics/transforms/AffineTransform.cpp:
+(WebCore::AffineTransform::isInvertible):
+Handle infinite and NaN determinants.
+
+(WebCore::AffineTransform::inverse):
+Handle infinite and NaN determinants.
+
2014-04-08 Brian J. Burg
Web Replay: memoize nondeterministic attributes of the Screen interface
Modified: trunk/Source/WebCore/platform/graphics/cg/PathCG.cpp (166988 => 166989)
--- trunk/Source/WebCore/platform/graphics/cg/PathCG.cpp 2014-04-09 00:47:21 UTC (rev 166988)
+++ trunk/Source/WebCore/platform/graphics/cg/PathCG.cpp 2014-04-09 01:11:15 UTC (rev 166989)
@@ -304,6 +304,9 @@
if (!path.platformPath())
return;
+if (!transform.isInvertible())
+return;
+
CGAffineTransform transformCG = transform;
// CG doesn't allow adding a path to itself. Optimize for the common case
// and copy the path for the self referencing case.
Modified: trunk/Source/WebCore/platform/graphics/transforms/AffineTransform.cpp (166988 => 166989)
--- trunk/Source/WebCore/platform/graphics/transforms/AffineTransform.cpp 2014-04-09 00:47:21 UTC (rev 166988)
+++ trunk/Source/WebCore/platform/graphics/transforms/AffineTransform.cpp 2014-04-09 01:11:15 UTC (rev 166989)
@@ -86,13 +86,15 @@
bool AffineTransform::isInvertible() const
{
-return det() != 0.0;
+double determinant = det();
+
+return std::isfinite(determinant) && determinant != 0;
}
AffineTransform AffineTransform::inverse() const
{
double determinant = det();
-if (determinant == 0.0)
+if (!std::isfinite(determinant) || determinant == 0)
return AffineTransform();
AffineTransform result;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [166990] trunk
Title: [166990] trunk
Revision 166990
Author simon.fra...@apple.com
Date 2014-04-08 18:11:52 -0700 (Tue, 08 Apr 2014)
Log Message
Source/WebCore: REGRESSION (r155998): Elements render at very low resolution with some 3d transforms
https://bugs.webkit.org/show_bug.cgi?id=131412
Reviewed by Tim Horton.
In r155998 we started to compute a root-relative transform in order to choose
a good contentsScale to avoid blurring on scaling.
However, the code failed to update this transform when passing over
GraphicsLayerCAs with no uncommitted changes, which caused us to choose
an incorrect contentsScale sometimes, resulting in blurriness.
Fix by updating the root-relative transform on layers with no uncommitted
changes.
Test: compositing/contents-scale/incremental-change.html
* platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::GraphicsLayerCA::commitLayerChangesBeforeSublayers):
LayoutTests: REGRESSION (r155998): Elements render at very low resolution with some 3d transforms
https://bugs.webkit.org/show_bug.cgi?id=131412
Reviewed by Tim Horton.
Test that makes an incremental change to a layer property in a tree with
interesting 3d transforms.
* compositing/contents-scale/incremental-change-expected.html: Added.
* compositing/contents-scale/incremental-change.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp
Added Paths
trunk/LayoutTests/compositing/contents-scale/incremental-change-expected.html
trunk/LayoutTests/compositing/contents-scale/incremental-change.html
Diff
Modified: trunk/LayoutTests/ChangeLog (166989 => 166990)
--- trunk/LayoutTests/ChangeLog 2014-04-09 01:11:15 UTC (rev 166989)
+++ trunk/LayoutTests/ChangeLog 2014-04-09 01:11:52 UTC (rev 166990)
@@ -1,3 +1,16 @@
+2014-04-08 Simon Fraser
+
+REGRESSION (r155998): Elements render at very low resolution with some 3d transforms
+https://bugs.webkit.org/show_bug.cgi?id=131412
+
+Reviewed by Tim Horton.
+
+Test that makes an incremental change to a layer property in a tree with
+interesting 3d transforms.
+
+* compositing/contents-scale/incremental-change-expected.html: Added.
+* compositing/contents-scale/incremental-change.html: Added.
+
2014-04-08 Adenilson Cavalcanti
[SVG] Fix CSS transform handling when zoomed
Added: trunk/LayoutTests/compositing/contents-scale/incremental-change-expected.html (0 => 166990)
--- trunk/LayoutTests/compositing/contents-scale/incremental-change-expected.html (rev 0)
+++ trunk/LayoutTests/compositing/contents-scale/incremental-change-expected.html 2014-04-09 01:11:52 UTC (rev 166990)
@@ -0,0 +1,47 @@
+
+
+
+
+
+* {
+box-sizing: border-box;
+}
+.container {
+width: 100px;
+height: 100px;
+margin: 200px;
+-webkit-perspective: 1000px;
+border: 1px solid black;
+}
+
+.middle {
+-webkit-transform-style: preserve-3d;
+-webkit-transform: translate3d(0px, 0px, 800px);
+width: 100px;
+height: 100px;
+}
+
+#leaf {
+width: 400px;
+height: 401px;
+position: absolute;
+border: 5px solid blue;
+-webkit-transform-origin: top left;
+-webkit-transform: matrix3d(
+0.2, 0, 0, 0,
+0, 0.2, 0, 0,
+0, 0, 0.2, 0,
+0, 0, 0, 1);
+background-image: repeating-linear-gradient(white, black 50px, white 50px);
+}
+
+
+
+
+
+
+
+
+
+
+
Added: trunk/LayoutTests/compositing/contents-scale/incremental-change.html (0 => 166990)
--- trunk/LayoutTests/compositing/contents-scale/incremental-change.html (rev 0)
+++ trunk/LayoutTests/compositing/contents-scale/incremental-change.html 2014-04-09 01:11:52 UTC (rev 166990)
@@ -0,0 +1,65 @@
+
+
+
+
+
+* {
+box-sizing: border-box;
+}
+.container {
+width: 100px;
+height: 100px;
+margin: 200px;
+-webkit-perspective: 1000px;
+border: 1px solid black;
+}
+
+.middle {
+-webkit-transform-style: preserve-3d;
+-webkit-transform: translate3d(0px, 0px, 800px);
+width: 100px;
+height: 100px;
+}
+
+#leaf {
+width: 400px;
+height: 400px;
+position: absolute;
+border: 5px solid blue;
+-webkit-transform-origin: top left;
+-webkit-transform: matrix3d(
+0.2, 0, 0, 0,
+0, 0.2, 0, 0,
+0, 0, 0.2, 0,
+0, 0, 0, 1);
+
[webkit-changes] [166988] trunk/Source/WTF
Title: [166988] trunk/Source/WTF
Revision 166988
Author gga...@apple.com
Date 2014-04-08 17:47:21 -0700 (Tue, 08 Apr 2014)
Log Message
2014-04-08 Geoffrey Garen
Stop linking WTF against bmalloc.
Reviewed by Enrica Casucci.
This seems to have broken an iOS buildbot script. Disable it for now
until we can fix the script.
* WTF.xcodeproj/project.pbxproj:
Modified Paths
trunk/Source/WTF/ChangeLog
trunk/Source/WTF/WTF.xcodeproj/project.pbxproj
Diff
Modified: trunk/Source/WTF/ChangeLog (166987 => 166988)
--- trunk/Source/WTF/ChangeLog 2014-04-09 00:40:55 UTC (rev 166987)
+++ trunk/Source/WTF/ChangeLog 2014-04-09 00:47:21 UTC (rev 166988)
@@ -1,5 +1,16 @@
2014-04-08 Geoffrey Garen
+Stop linking WTF against bmalloc.
+
+Reviewed by Enrica Casucci.
+
+This seems to have broken an iOS buildbot script. Disable it for now
+until we can fix the script.
+
+* WTF.xcodeproj/project.pbxproj:
+
+2014-04-08 Geoffrey Garen
+
WTF should link against bmalloc
https://bugs.webkit.org/show_bug.cgi?id=131403
Modified: trunk/Source/WTF/WTF.xcodeproj/project.pbxproj (166987 => 166988)
--- trunk/Source/WTF/WTF.xcodeproj/project.pbxproj 2014-04-09 00:40:55 UTC (rev 166987)
+++ trunk/Source/WTF/WTF.xcodeproj/project.pbxproj 2014-04-09 00:47:21 UTC (rev 166988)
@@ -50,7 +50,6 @@
1469419C16EAB10A0024E146 /* AutodrainedPool.h in Headers */ = {isa = PBXBuildFile; fileRef = 1469419A16EAB10A0024E146 /* AutodrainedPool.h */; };
1469419D16EAB10A0024E146 /* AutodrainedPoolMac.mm in Sources */ = {isa = PBXBuildFile; fileRef = 1469419B16EAB10A0024E146 /* AutodrainedPoolMac.mm */; };
149EF16316BBFE0D000A4331 /* TriState.h in Headers */ = {isa = PBXBuildFile; fileRef = 149EF16216BBFE0D000A4331 /* TriState.h */; settings = {ATTRIBUTES = (); }; };
- 14DD78D318F4B05A00950702 /* libbmalloc.a in Frameworks */ = {isa = PBXBuildFile; fileRef = 14DD78D218F4B05A00950702 /* libbmalloc.a */; };
14F3B0F715E45E4600210069 /* SaturatedArithmetic.h in Headers */ = {isa = PBXBuildFile; fileRef = 14F3B0F615E45E4600210069 /* SaturatedArithmetic.h */; settings = {ATTRIBUTES = (); }; };
1A1D8B9C173186CE00141DA4 /* FunctionDispatcher.h in Headers */ = {isa = PBXBuildFile; fileRef = 1A1D8B9B173186CE00141DA4 /* FunctionDispatcher.h */; };
1A1D8B9E1731879800141DA4 /* FunctionDispatcher.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 1A1D8B9D1731879800141DA4 /* FunctionDispatcher.cpp */; };
@@ -320,7 +319,6 @@
1469419A16EAB10A0024E146 /* AutodrainedPool.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = AutodrainedPool.h; sourceTree = ""; };
1469419B16EAB10A0024E146 /* AutodrainedPoolMac.mm */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.objcpp; path = AutodrainedPoolMac.mm; sourceTree = ""; };
149EF16216BBFE0D000A4331 /* TriState.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = TriState.h; sourceTree = ""; };
- 14DD78D218F4B05A00950702 /* libbmalloc.a */ = {isa = PBXFileReference; lastKnownFileType = archive.ar; path = libbmalloc.a; sourceTree = BUILT_PRODUCTS_DIR; };
14F3B0F615E45E4600210069 /* SaturatedArithmetic.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = SaturatedArithmetic.h; sourceTree = ""; };
1A1D8B9B173186CE00141DA4 /* FunctionDispatcher.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = FunctionDispatcher.h; sourceTree = ""; };
1A1D8B9D1731879800141DA4 /* FunctionDispatcher.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = FunctionDispatcher.cpp; sourceTree = ""; };
@@ -563,21 +561,12 @@
isa = PBXFrameworksBuildPhase;
buildActionMask = 2147483647;
files = (
-14DD78D318F4B05A00950702 /* libbmalloc.a in Frameworks */,
);
runOnlyForDeploymentPostprocessing = 0;
};
/* End PBXFrameworksBuildPhase section */
/* Begin PBXGroup section */
- 14DD78D418F4B0BE00950702 /* Frameworks */ = {
- isa = PBXGroup;
- children = (
-14DD78D218F4B05A00950702 /* libbmalloc.a */,
- );
- name = Frameworks;
- sourceTree = "";
- };
1FA47C87152502DA00568D1B /* ios */ = {
isa = PBXGroup;
children = (
@@ -599,7 +588,6 @@
isa = PBXGroup;
children = (
5D247B6D14689C4700E78B76 /* Configurations */,
-14DD78D418F4B0BE00950702 /* Frameworks */,
5D247B6314689B8600E78B76 /* Products */,
5D247B7614689D7600E78B76 /* Source */,
);
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [166987] trunk/Tools
Title: [166987] trunk/Tools
Revision 166987
Author gga...@apple.com
Date 2014-04-08 17:40:55 -0700 (Tue, 08 Apr 2014)
Log Message
Fix the build-jsc build
https://bugs.webkit.org/show_bug.cgi?id=131410
Reviewed by Michael Saboff.
* Scripts/build-jsc: Make sure to build bmalloc before WTF, since
WTF depends on it.
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/build-jsc
Diff
Modified: trunk/Tools/ChangeLog (166986 => 166987)
--- trunk/Tools/ChangeLog 2014-04-09 00:38:58 UTC (rev 166986)
+++ trunk/Tools/ChangeLog 2014-04-09 00:40:55 UTC (rev 166987)
@@ -1,3 +1,13 @@
+2014-04-08 Geoffrey Garen
+
+Fix the build-jsc build
+https://bugs.webkit.org/show_bug.cgi?id=131410
+
+Reviewed by Michael Saboff.
+
+* Scripts/build-jsc: Make sure to build bmalloc before WTF, since
+WTF depends on it.
+
2014-04-08 Martin Robinson
[GTK] Remove WebKit1 unit tests
Modified: trunk/Tools/Scripts/build-jsc (166986 => 166987)
--- trunk/Tools/Scripts/build-jsc 2014-04-09 00:38:58 UTC (rev 166986)
+++ trunk/Tools/Scripts/build-jsc 2014-04-09 00:40:55 UTC (rev 166987)
@@ -127,6 +127,7 @@
chdirWebKit();
}
+buildMyProject("Source/bmalloc", "bmalloc");
buildMyProject("Source/WTF", "WTF");
buildMyProject("Source/_javascript_Core", "_javascript_Core");
if (isAppleMacWebKit() && $cli) {
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [166986] trunk/Source/WebKit2
Title: [166986] trunk/Source/WebKit2 Revision 166986 Author rn...@webkit.org Date 2014-04-08 17:38:58 -0700 (Tue, 08 Apr 2014) Log Message Fix the typo in the previous commit. * WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::close): Modified Paths trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp Diff Modified: trunk/Source/WebKit2/ChangeLog (166985 => 166986) --- trunk/Source/WebKit2/ChangeLog 2014-04-09 00:37:57 UTC (rev 166985) +++ trunk/Source/WebKit2/ChangeLog 2014-04-09 00:38:58 UTC (rev 166986) @@ -1,5 +1,12 @@ 2014-04-08 Ryosuke Niwa +Fix the typo in the previous commit. + +* WebProcess/WebPage/WebPage.cpp: +(WebKit::WebPage::close): + +2014-04-08 Ryosuke Niwa + REGRESSION(r 166890): Crash inside WebKit::WebEditorClient::textFieldDidEndEditing https://bugs.webkit.org/show_bug.cgi?id=131409 Modified: trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp (166985 => 166986) --- trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp 2014-04-09 00:37:57 UTC (rev 166985) +++ trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp 2014-04-09 00:38:58 UTC (rev 166986) @@ -886,7 +886,7 @@ m_contextMenuClient.initialize(0); #endif m_editorClient.initialize(0); -m_formClient = std::make_ptr(); +m_formClient = std::make_unique(); m_loaderClient.initialize(0); m_policyClient.initialize(0); m_resourceLoadClient.initialize(0); ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [166985] trunk/Source/WebKit2
Title: [166985] trunk/Source/WebKit2 Revision 166985 Author rn...@webkit.org Date 2014-04-08 17:37:57 -0700 (Tue, 08 Apr 2014) Log Message REGRESSION(r 166890): Crash inside WebKit::WebEditorClient::textFieldDidEndEditing https://bugs.webkit.org/show_bug.cgi?id=131409 Reviewed by Anders Carlsson. Create an empty API::InjectedBundle::FormClient to avoid crashing inside m_mainFrame->coreFrame()->loader().detachFromParent(). * WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::close): Modified Paths trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp Diff Modified: trunk/Source/WebKit2/ChangeLog (166984 => 166985) --- trunk/Source/WebKit2/ChangeLog 2014-04-09 00:22:46 UTC (rev 166984) +++ trunk/Source/WebKit2/ChangeLog 2014-04-09 00:37:57 UTC (rev 166985) @@ -1,3 +1,16 @@ +2014-04-08 Ryosuke Niwa + +REGRESSION(r 166890): Crash inside WebKit::WebEditorClient::textFieldDidEndEditing +https://bugs.webkit.org/show_bug.cgi?id=131409 + +Reviewed by Anders Carlsson. + +Create an empty API::InjectedBundle::FormClient to avoid crashing inside +m_mainFrame->coreFrame()->loader().detachFromParent(). + +* WebProcess/WebPage/WebPage.cpp: +(WebKit::WebPage::close): + 2014-04-08 Tim Horton Unify and factor out page overlay implementations Modified: trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp (166984 => 166985) --- trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp 2014-04-09 00:22:46 UTC (rev 166984) +++ trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp 2014-04-09 00:37:57 UTC (rev 166985) @@ -886,7 +886,7 @@ m_contextMenuClient.initialize(0); #endif m_editorClient.initialize(0); -m_formClient = std::unique_ptr(); +m_formClient = std::make_ptr(); m_loaderClient.initialize(0); m_policyClient.initialize(0); m_resourceLoadClient.initialize(0); ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [166984] trunk
Title: [166984] trunk
Revision 166984
Author b...@cs.washington.edu
Date 2014-04-08 17:22:46 -0700 (Tue, 08 Apr 2014)
Log Message
Web Replay: memoize nondeterministic attributes of the Screen interface
https://bugs.webkit.org/show_bug.cgi?id=131339
Reviewed by Timothy Hatcher.
.:
* ManualTests/inspector/replay-window-screen.html: Added.
Source/WebCore:
The values from the screen interface are nondeterministic. Since we can't
change the physical screen dimensions, instead memoize values of attributes.
Test: ManualTests/inspector/replay-window-screen.html
* page/Screen.idl: Add Nondeterministic attribute.
Modified Paths
trunk/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/Screen.idl
Added Paths
trunk/ManualTests/inspector/replay-window-screen.html
Diff
Modified: trunk/ChangeLog (166983 => 166984)
--- trunk/ChangeLog 2014-04-09 00:13:43 UTC (rev 166983)
+++ trunk/ChangeLog 2014-04-09 00:22:46 UTC (rev 166984)
@@ -1,3 +1,12 @@
+2014-04-08 Brian J. Burg
+
+Web Replay: memoize nondeterministic attributes of the Screen interface
+https://bugs.webkit.org/show_bug.cgi?id=131339
+
+Reviewed by Timothy Hatcher.
+
+* ManualTests/inspector/replay-window-screen.html: Added.
+
2014-04-08 Martin Robinson
[GTK] Remove the WebKitGTK+ WebKit 1 code
Added: trunk/ManualTests/inspector/replay-window-screen.html (0 => 166984)
--- trunk/ManualTests/inspector/replay-window-screen.html (rev 0)
+++ trunk/ManualTests/inspector/replay-window-screen.html 2014-04-09 00:22:46 UTC (rev 166984)
@@ -0,0 +1,111 @@
+
+
+
+
+
+window.dumpedStates = [];
+
+function dumpState() {
+obj = {
+ height: window.screen.height,
+ width: window.screen.width,
+ colorDepth: window.screen.colorDepth,
+ pixelDepth: window.screen.pixelDepth,
+ availLeft: window.screen.availLeft,
+ availTop: window.screen.availTop,
+ availHeight: window.screen.availHeight,
+ availWidth: window.screen.availWidth,
+};
+
+dumpedStates.push(obj);
+
+var block = createBlock(hex_md5(JSON.stringify(obj)));
+var blocksContainer = document.getElementById("blocks");
+blocksContainer.appendChild(block);
+
+var hashLabel = document.getElementById("hash");
+hash.textContent = hex_md5(JSON.stringify(dumpedStates));
+
+appendDetails(obj);
+}
+
+function appendDetails(obj) {
+var detailsContainer = document.getElementById("details");
+var tableElement = document.createElement("table");
+for (var key in obj) {
+var rowElement = document.createElement("tr");
+var keyElement = document.createElement("td");
+keyElement.textContent = key;
+rowElement.appendChild(keyElement);
+var valueElement = document.createElement("td");
+valueElement.textContent = obj[key];
+rowElement.appendChild(valueElement);
+tableElement.appendChild(rowElement);
+}
+detailsContainer.appendChild(tableElement);
+detailsContainer.appendChild(document.createElement("hr"));
+}
+
+function createBlock(hash) {
+var color = "#" + hash.substr(0,6);
+var block = document.createElement("span");
+block.style.backgroundColor = color;
+return block;
+}
+
+
+
+
+body {
+max-width: 800px;
+}
+#blocks {
+display: -webkit-flex;
+width: 600px;
+-webkit-flex-flow: row wrap;
+}
+
+table {
+text-decoration: bold;
+font-family: monospace;
+}
+
+#blocks > span {
+width: 20px;
+height: 20px;
+border-radius: 10px;
+font-size: 18px;
+font-weight: bold;
+font-family: sans-serif;
+color: #fff;
+text-align: center;
+}
+
+
+
+This page is a manual test for capture and replay of the Screen API.
+Below, a block is created for each button press that dumps state. The color is derived from a hash of the state. At the bottom is a cumulative hash of all dumped data.
+
+
+To test the replay functionality, open the Web Inspector and start capturing. Then perform one of the following to change screen state:
+
+
+If you have two monitors, move the menu bar from one display to the other.
+Change the monitor's resolution.
+Change the monitor's color depth.
+Move the browser window between monitors with different color depth, size, or pixel ratio.
+
+
+Then, stop capturing and replay the recording. The replayed execution should produce the same sequence of blocks. More importantly, the cumulative hash value should be the same at the end of capturing and at the end of any subsequent replays.
+
+
+
+
+
+
+
+
+
+
Modified: trunk/Source/WebCore/ChangeLog (166983 => 166984)
--- trunk/Source/WebCore/ChangeLog 2014-04-09 00:13:43 UTC (rev 166983)
+++ trunk/Source/WebCore/ChangeLog 2014-04-09 00:22:46 UTC (rev 16
[webkit-changes] [166983] trunk/Source/WebCore
Title: [166983] trunk/Source/WebCore
Revision 166983
Author bda...@apple.com
Date 2014-04-08 17:13:43 -0700 (Tue, 08 Apr 2014)
Log Message
https://bugs.webkit.org/show_bug.cgi?id=131408
Scrollbars layers don't dynamically update when device scale factor changes
-and corresponding-
Reviewed by Tim Horton.
The scrollbar layers are not children of the RenderView's layer, so they were
completely skipped over by this function before. We need to start this higher up
the tree in the rootGraphicsLayer(), which will typically return the
m_overflowControlsHostLayer.
* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::deviceOrPageScaleFactorChanged):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderLayerCompositor.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (166982 => 166983)
--- trunk/Source/WebCore/ChangeLog 2014-04-09 00:12:11 UTC (rev 166982)
+++ trunk/Source/WebCore/ChangeLog 2014-04-09 00:13:43 UTC (rev 166983)
@@ -1,3 +1,19 @@
+2014-04-08 Beth Dakin
+
+https://bugs.webkit.org/show_bug.cgi?id=131408
+Scrollbars layers don't dynamically update when device scale factor changes
+-and corresponding-
+
+
+Reviewed by Tim Horton.
+
+The scrollbar layers are not children of the RenderView's layer, so they were
+completely skipped over by this function before. We need to start this higher up
+the tree in the rootGraphicsLayer(), which will typically return the
+m_overflowControlsHostLayer.
+* rendering/RenderLayerCompositor.cpp:
+(WebCore::RenderLayerCompositor::deviceOrPageScaleFactorChanged):
+
2014-04-08 Ryosuke Niwa
HTMLConverter::aggregatedAttributesForAncestors should cache intermediate results
Modified: trunk/Source/WebCore/rendering/RenderLayerCompositor.cpp (166982 => 166983)
--- trunk/Source/WebCore/rendering/RenderLayerCompositor.cpp 2014-04-09 00:12:11 UTC (rev 166982)
+++ trunk/Source/WebCore/rendering/RenderLayerCompositor.cpp 2014-04-09 00:13:43 UTC (rev 166983)
@@ -3362,12 +3362,10 @@
void RenderLayerCompositor::deviceOrPageScaleFactorChanged()
{
-// Start at the RenderView's layer, since that's where the scale is applied.
-RenderLayer* viewLayer = m_renderView.layer();
-if (!viewLayer->isComposited())
-return;
-
-if (GraphicsLayer* rootLayer = viewLayer->backing()->childForSuperlayers())
+// Page scale will only be applied at to the RenderView and sublayers, but the device scale factor
+// needs to be applied at the level of rootGraphicsLayer().
+GraphicsLayer* rootLayer = rootGraphicsLayer();
+if (rootLayer)
rootLayer->noteDeviceOrPageScaleFactorChangedIncludingDescendants();
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [166982] trunk/Source/JavaScriptCore
Title: [166982] trunk/Source/_javascript_Core
Revision 166982
Author commit-qu...@webkit.org
Date 2014-04-08 17:12:11 -0700 (Tue, 08 Apr 2014)
Log Message
Web Inspector: Prevent deadlocks receiving WIRPermissionDenied message
https://bugs.webkit.org/show_bug.cgi?id=131406
Patch by Joseph Pecoraro on 2014-04-08
Reviewed by Timothy Hatcher.
* inspector/remote/RemoteInspector.h:
* inspector/remote/RemoteInspector.mm:
(Inspector::RemoteInspector::stop):
(Inspector::RemoteInspector::stopInternal):
(Inspector::RemoteInspector::xpcConnectionReceivedMessage):
Provide a way to stop externally and a path to stop when in
the middle of handling a message already with the locked mutex.
* inspector/remote/RemoteInspectorXPCConnection.h:
* inspector/remote/RemoteInspectorXPCConnection.mm:
(Inspector::RemoteInspectorXPCConnection::close):
(Inspector::RemoteInspectorXPCConnection::closeFromMessage):
Provide a way to close externally and a path to close when in
the middle of handling a message already with a mutex.
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/inspector/remote/RemoteInspector.h
trunk/Source/_javascript_Core/inspector/remote/RemoteInspector.mm
trunk/Source/_javascript_Core/inspector/remote/RemoteInspectorXPCConnection.h
trunk/Source/_javascript_Core/inspector/remote/RemoteInspectorXPCConnection.mm
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (166981 => 166982)
--- trunk/Source/_javascript_Core/ChangeLog 2014-04-09 00:06:09 UTC (rev 166981)
+++ trunk/Source/_javascript_Core/ChangeLog 2014-04-09 00:12:11 UTC (rev 166982)
@@ -1,5 +1,27 @@
2014-04-08 Joseph Pecoraro
+Web Inspector: Prevent deadlocks receiving WIRPermissionDenied message
+https://bugs.webkit.org/show_bug.cgi?id=131406
+
+Reviewed by Timothy Hatcher.
+
+* inspector/remote/RemoteInspector.h:
+* inspector/remote/RemoteInspector.mm:
+(Inspector::RemoteInspector::stop):
+(Inspector::RemoteInspector::stopInternal):
+(Inspector::RemoteInspector::xpcConnectionReceivedMessage):
+Provide a way to stop externally and a path to stop when in
+the middle of handling a message already with the locked mutex.
+
+* inspector/remote/RemoteInspectorXPCConnection.h:
+* inspector/remote/RemoteInspectorXPCConnection.mm:
+(Inspector::RemoteInspectorXPCConnection::close):
+(Inspector::RemoteInspectorXPCConnection::closeFromMessage):
+Provide a way to close externally and a path to close when in
+the middle of handling a message already with a mutex.
+
+2014-04-08 Joseph Pecoraro
+
Web Inspector: Address stale FIXMEs concerning console in JSContext inspection
https://bugs.webkit.org/show_bug.cgi?id=131398
Modified: trunk/Source/_javascript_Core/inspector/remote/RemoteInspector.h (166981 => 166982)
--- trunk/Source/_javascript_Core/inspector/remote/RemoteInspector.h 2014-04-09 00:06:09 UTC (rev 166981)
+++ trunk/Source/_javascript_Core/inspector/remote/RemoteInspector.h 2014-04-09 00:12:11 UTC (rev 166982)
@@ -65,6 +65,9 @@
unsigned nextAvailableIdentifier();
+enum class StopSource { API, XPCMessage };
+void stopInternal(StopSource);
+
void setupXPCConnectionIfNeeded();
NSDictionary *listingForDebuggable(const RemoteInspectorDebuggableInfo&) const;
Modified: trunk/Source/_javascript_Core/inspector/remote/RemoteInspector.mm (166981 => 166982)
--- trunk/Source/_javascript_Core/inspector/remote/RemoteInspector.mm 2014-04-09 00:06:09 UTC (rev 166981)
+++ trunk/Source/_javascript_Core/inspector/remote/RemoteInspector.mm 2014-04-09 00:12:11 UTC (rev 166982)
@@ -196,6 +196,11 @@
{
std::lock_guard lock(m_mutex);
+stopInternal(StopSource::API);
+}
+
+void RemoteInspector::stopInternal(StopSource source)
+{
if (!m_enabled)
return;
@@ -210,7 +215,15 @@
updateHasActiveDebugSession();
if (m_xpcConnection) {
-m_xpcConnection->close();
+switch (source) {
+case StopSource::API:
+m_xpcConnection->close();
+break;
+case StopSource::XPCMessage:
+m_xpcConnection->closeFromMessage();
+break;
+}
+
m_xpcConnection = nullptr;
}
@@ -239,13 +252,13 @@
void RemoteInspector::xpcConnectionReceivedMessage(RemoteInspectorXPCConnection*, NSString *messageName, NSDictionary *userInfo)
{
+std::lock_guard lock(m_mutex);
+
if ([messageName isEqualToString:WIRPermissionDenied]) {
-stop();
+stopInternal(StopSource::XPCMessage);
return;
}
-std::lock_guard lock(m_mutex);
-
if ([messageName isEqualToString:WIRSocketDataMessage])
receivedDataMessage(userInfo);
else if ([messageName isEqualToString:WIRSocketSetupMessage])
Modified: trunk/Source/_javascript_Core/inspector/remote/RemoteInspectorXPCConnection.h (166981 => 166982)
--- trunk/Source/_j
[webkit-changes] [166981] trunk/Source/WebCore
Title: [166981] trunk/Source/WebCore
Revision 166981
Author rn...@webkit.org
Date 2014-04-08 17:06:09 -0700 (Tue, 08 Apr 2014)
Log Message
HTMLConverter::aggregatedAttributesForAncestors should cache intermediate results
https://bugs.webkit.org/show_bug.cgi?id=131400
Reviewed by Sam Weinig.
Instead of accumulating attributes from a character node to the highest ancestor,
recursively call aggregatedAttributesForElementAndItsAncestors so that aggregated
attributes are cached on each ancestor to eliminate the old O(n^2) behavior.
* editing/cocoa/HTMLConverter.mm:
(HTMLConverter::aggregatedAttributesForAncestors):
(HTMLConverter::aggregatedAttributesForElementAndItsAncestors): Extracted from aggregatedAttributesForAncestors.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/editing/cocoa/HTMLConverter.mm
Diff
Modified: trunk/Source/WebCore/ChangeLog (166980 => 166981)
--- trunk/Source/WebCore/ChangeLog 2014-04-08 23:53:29 UTC (rev 166980)
+++ trunk/Source/WebCore/ChangeLog 2014-04-09 00:06:09 UTC (rev 166981)
@@ -1,3 +1,18 @@
+2014-04-08 Ryosuke Niwa
+
+HTMLConverter::aggregatedAttributesForAncestors should cache intermediate results
+https://bugs.webkit.org/show_bug.cgi?id=131400
+
+Reviewed by Sam Weinig.
+
+Instead of accumulating attributes from a character node to the highest ancestor,
+recursively call aggregatedAttributesForElementAndItsAncestors so that aggregated
+attributes are cached on each ancestor to eliminate the old O(n^2) behavior.
+
+* editing/cocoa/HTMLConverter.mm:
+(HTMLConverter::aggregatedAttributesForAncestors):
+(HTMLConverter::aggregatedAttributesForElementAndItsAncestors): Extracted from aggregatedAttributesForAncestors.
+
2014-04-08 Jinwoo Song
Unreviewed CMake build fix after r166965.
Modified: trunk/Source/WebCore/editing/cocoa/HTMLConverter.mm (166980 => 166981)
--- trunk/Source/WebCore/editing/cocoa/HTMLConverter.mm 2014-04-08 23:53:29 UTC (rev 166980)
+++ trunk/Source/WebCore/editing/cocoa/HTMLConverter.mm 2014-04-09 00:06:09 UTC (rev 166981)
@@ -449,7 +449,7 @@
HashMap, RetainPtr> m_attributesForElements;
HashMap, RefPtr> m_textTableFooters;
-HashMap, RetainPtr> m_aggregatedAttributesForElements;
+HashMap, RetainPtr> m_aggregatedAttributesForElements;
NSMutableAttributedString *_attrStr;
NSMutableDictionary *_documentAttrs;
@@ -487,7 +487,8 @@
NSDictionary *computedAttributesForElement(Element&);
NSDictionary *attributesForElement(Element&);
NSDictionary *aggregatedAttributesForAncestors(CharacterData&);
-
+NSDictionary* aggregatedAttributesForElementAndItsAncestors(Element&);
+
Element* _blockLevelElementForNode(Node*);
void _newParagraphForElement(Element&, NSString *tag, BOOL flag, BOOL suppressTrailingSpace);
@@ -1357,25 +1358,32 @@
ancestor = ancestor->parentNode();
if (!ancestor)
return nullptr;
+return aggregatedAttributesForElementAndItsAncestors(*toElement(ancestor));
+}
-auto& attributes = m_aggregatedAttributesForElements.add(toElement(ancestor), nullptr).iterator->value;
-if (!attributes) {
-Vector ancestorElements;
-ancestorElements.append(toElement(ancestor));
-for (; ancestor; ancestor = ancestor->parentNode()) {
-if (ancestor->isElementNode())
-ancestorElements.append(toElement(ancestor));
-}
+NSDictionary* HTMLConverter::aggregatedAttributesForElementAndItsAncestors(Element& element)
+{
+auto& cachedAttributes = m_aggregatedAttributesForElements.add(&element, nullptr).iterator->value;
+if (cachedAttributes)
+return cachedAttributes.get();
-attributes = [NSMutableDictionary dictionary];
-// Fill attrs dictionary with attributes from the highest to the lowest, not overwriting ones deeper in the tree
-for (unsigned index = ancestorElements.size(); index;) {
-index--;
-[attributes addEntriesFromDictionary:attributesForElement(*ancestorElements[index])];
-}
+NSDictionary* attributesForCurrentElement = attributesForElement(element);
+ASSERT(attributesForCurrentElement);
+
+Node* ancestor = element.parentNode();
+while (ancestor && !ancestor->isElementNode())
+ancestor = ancestor->parentNode();
+
+if (!ancestor) {
+cachedAttributes = attributesForCurrentElement;
+return attributesForCurrentElement;
}
-return attributes.get();
+RetainPtr attributesForAncestors = adoptNS([aggregatedAttributesForElementAndItsAncestors(*toElement(ancestor)) mutableCopy]);
+[attributesForAncestors addEntriesFromDictionary:attributesForCurrentElement];
+m_aggregatedAttributesForElements.set(&element, attributesForAncestors);
+
+return attributesForAncestors.get();
}
void HTMLConverter::_newParagraphForElement(Element& element, NSString *tag, BOOL
[webkit-changes] [166978] trunk/Source/WebKit2
Title: [166978] trunk/Source/WebKit2
Revision 166978
Author timothy_hor...@apple.com
Date 2014-04-08 16:40:43 -0700 (Tue, 08 Apr 2014)
Log Message
Unify and factor out page overlay implementations
https://bugs.webkit.org/show_bug.cgi?id=131353
Reviewed by Anders Carlsson.
* WebProcess/WebPage/PageOverlayController.cpp:
(WebKit::PageOverlayController::uninstallPageOverlay):
Don't turn fast scrolling back off unless the last overlay is removed.
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/WebProcess/WebPage/PageOverlayController.cpp
Diff
Modified: trunk/Source/WebKit2/ChangeLog (166977 => 166978)
--- trunk/Source/WebKit2/ChangeLog 2014-04-08 23:36:28 UTC (rev 166977)
+++ trunk/Source/WebKit2/ChangeLog 2014-04-08 23:40:43 UTC (rev 166978)
@@ -1,3 +1,14 @@
+2014-04-08 Tim Horton
+
+Unify and factor out page overlay implementations
+https://bugs.webkit.org/show_bug.cgi?id=131353
+
+Reviewed by Anders Carlsson.
+
+* WebProcess/WebPage/PageOverlayController.cpp:
+(WebKit::PageOverlayController::uninstallPageOverlay):
+Don't turn fast scrolling back off unless the last overlay is removed.
+
2014-04-08 Anders Carlsson
Add a WKNavigationAction property indicating whether it resulted from processing a user gesture
Modified: trunk/Source/WebKit2/WebProcess/WebPage/PageOverlayController.cpp (166977 => 166978)
--- trunk/Source/WebKit2/WebProcess/WebPage/PageOverlayController.cpp 2014-04-08 23:36:28 UTC (rev 166977)
+++ trunk/Source/WebKit2/WebProcess/WebPage/PageOverlayController.cpp 2014-04-08 23:40:43 UTC (rev 166978)
@@ -102,6 +102,9 @@
ASSERT(overlayIndex != notFound);
m_pageOverlays.remove(overlayIndex);
+if (!m_pageOverlays.isEmpty())
+return;
+
#if ENABLE(ASYNC_SCROLLING)
if (Page* page = m_webPage->corePage()) {
if (ScrollingCoordinator* scrollingCoordinator = page->scrollingCoordinator())
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [166976] trunk/Source/WebKit2
Title: [166976] trunk/Source/WebKit2
Revision 166976
Author ander...@apple.com
Date 2014-04-08 16:19:32 -0700 (Tue, 08 Apr 2014)
Log Message
Add a WKNavigationAction property indicating whether it resulted from processing a user gesture
https://bugs.webkit.org/show_bug.cgi?id=131405
Reviewed by Tim Horton.
* Shared/NavigationActionData.cpp:
(WebKit::NavigationActionData::NavigationActionData):
(WebKit::NavigationActionData::encode):
(WebKit::NavigationActionData::decode):
* Shared/NavigationActionData.h:
* UIProcess/API/Cocoa/WKNavigationActionInternal.h:
* UIProcess/API/Cocoa/WKNavigationActionPrivate.h:
* UIProcess/Cocoa/NavigationState.mm:
(WebKit::NavigationState::PolicyClient::decidePolicyForNavigationAction):
* UIProcess/Cocoa/UIDelegate.mm:
(WebKit::UIDelegate::UIClient::createNewPage):
* WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::createWindow):
* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/Shared/NavigationActionData.cpp
trunk/Source/WebKit2/Shared/NavigationActionData.h
trunk/Source/WebKit2/UIProcess/API/Cocoa/WKNavigationActionInternal.h
trunk/Source/WebKit2/UIProcess/API/Cocoa/WKNavigationActionPrivate.h
trunk/Source/WebKit2/UIProcess/Cocoa/NavigationState.mm
trunk/Source/WebKit2/UIProcess/Cocoa/UIDelegate.mm
trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebChromeClient.cpp
trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp
Diff
Modified: trunk/Source/WebKit2/ChangeLog (166975 => 166976)
--- trunk/Source/WebKit2/ChangeLog 2014-04-08 23:09:52 UTC (rev 166975)
+++ trunk/Source/WebKit2/ChangeLog 2014-04-08 23:19:32 UTC (rev 166976)
@@ -1,3 +1,28 @@
+2014-04-08 Anders Carlsson
+
+Add a WKNavigationAction property indicating whether it resulted from processing a user gesture
+https://bugs.webkit.org/show_bug.cgi?id=131405
+
+
+Reviewed by Tim Horton.
+
+* Shared/NavigationActionData.cpp:
+(WebKit::NavigationActionData::NavigationActionData):
+(WebKit::NavigationActionData::encode):
+(WebKit::NavigationActionData::decode):
+* Shared/NavigationActionData.h:
+* UIProcess/API/Cocoa/WKNavigationActionInternal.h:
+* UIProcess/API/Cocoa/WKNavigationActionPrivate.h:
+* UIProcess/Cocoa/NavigationState.mm:
+(WebKit::NavigationState::PolicyClient::decidePolicyForNavigationAction):
+* UIProcess/Cocoa/UIDelegate.mm:
+(WebKit::UIDelegate::UIClient::createNewPage):
+* WebProcess/WebCoreSupport/WebChromeClient.cpp:
+(WebKit::WebChromeClient::createWindow):
+* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
+(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
+(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
+
2014-04-08 Tim Horton
Unify and factor out page overlay implementations
Modified: trunk/Source/WebKit2/Shared/NavigationActionData.cpp (166975 => 166976)
--- trunk/Source/WebKit2/Shared/NavigationActionData.cpp 2014-04-08 23:09:52 UTC (rev 166975)
+++ trunk/Source/WebKit2/Shared/NavigationActionData.cpp 2014-04-08 23:19:32 UTC (rev 166976)
@@ -35,6 +35,9 @@
NavigationActionData::NavigationActionData()
: navigationType(NavigationTypeOther)
+, modifiers()
+, mouseButton(WebMouseEvent::NoButton)
+, isProcessingUserGesture(false)
{
}
@@ -43,6 +46,7 @@
encoder.encodeEnum(navigationType);
encoder.encodeEnum(modifiers);
encoder.encodeEnum(mouseButton);
+encoder << isProcessingUserGesture;
}
bool NavigationActionData::decode(IPC::ArgumentDecoder& decoder, NavigationActionData& result)
@@ -53,6 +57,8 @@
return false;
if (!decoder.decodeEnum(result.mouseButton))
return false;
+if (!decoder.decode(result.isProcessingUserGesture))
+return false;
return true;
}
Modified: trunk/Source/WebKit2/Shared/NavigationActionData.h (166975 => 166976)
--- trunk/Source/WebKit2/Shared/NavigationActionData.h 2014-04-08 23:09:52 UTC (rev 166975)
+++ trunk/Source/WebKit2/Shared/NavigationActionData.h 2014-04-08 23:19:32 UTC (rev 166976)
@@ -45,6 +45,7 @@
WebCore::NavigationType navigationType;
WebEvent::Modifiers modifiers;
WebMouseEvent::Button mouseButton;
+bool isProcessingUserGesture;
};
}
Modified: trunk/Source/WebKit2/UIProcess/API/Cocoa/WKNavigationActionInternal.h (166975 => 166976)
--- trunk/Source/WebKit2/UIProcess/API/Cocoa/WKNavigationActionInternal.h 2014-04-08 23:09:52 UTC (rev 166975)
+++ trunk/Source/WebKit2/UIProcess/API/Cocoa/WKNavigationActionInternal.h 2014-04-08 23:19:32 UTC (rev 166976)
@@ -38,6 +38,7 @@
@property (nonatomic, readwrite, copy) NSURLRequest *request;
@property (nonatomic,
[webkit-changes] [166974] trunk/Tools
Title: [166974] trunk/Tools
Revision 166974
Author bfulg...@apple.com
Date 2014-04-08 15:59:27 -0700 (Tue, 08 Apr 2014)
Log Message
Unreviewed gardening (Take 2): Prevent users from attempting
to build with known invalid cURL.
* Scripts/webkitdirs.pm:
(checkInstalledTools): Check for 7.34.0 (the broken version), not
7.33.0 (the known good version).
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitdirs.pm
Diff
Modified: trunk/Tools/ChangeLog (166973 => 166974)
--- trunk/Tools/ChangeLog 2014-04-08 22:52:26 UTC (rev 166973)
+++ trunk/Tools/ChangeLog 2014-04-08 22:59:27 UTC (rev 166974)
@@ -1,3 +1,12 @@
+2014-04-08 Brent Fulgham
+
+Unreviewed gardening (Take 2): Prevent users from attempting
+to build with known invalid cURL.
+
+* Scripts/webkitdirs.pm:
+(checkInstalledTools): Check for 7.34.0 (the broken version), not
+7.33.0 (the known good version).
+
2014-04-08 Martin Robinson
[GTK] Remove DumpRenderTree and GtkLauncher
Modified: trunk/Tools/Scripts/webkitdirs.pm (166973 => 166974)
--- trunk/Tools/Scripts/webkitdirs.pm 2014-04-08 22:52:26 UTC (rev 166973)
+++ trunk/Tools/Scripts/webkitdirs.pm 2014-04-08 22:59:27 UTC (rev 166974)
@@ -1422,7 +1422,7 @@
# cURL 7.34.0 has a bug that prevents authentication with opensource.apple.com (and other things using SSL3).
my $curlVer = `curl --version | grep "curl"`;
chomp($curlVer);
-if (!$? and $curlVer =~ /libcurl\/7\.33\.0/) {
+if (!$? and $curlVer =~ /libcurl\/7\.34\.0/) {
print "cURL version 7.34.0 has a bug that prevents authentication with SSL v2 or v3.\n";
print "cURL 7.33.0 is known to work. The cURL projects is preparing an update to\n";
print "correct this problem.\n\n";
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [166972] trunk/Source/WTF
Title: [166972] trunk/Source/WTF
Revision 166972
Author gga...@apple.com
Date 2014-04-08 15:51:27 -0700 (Tue, 08 Apr 2014)
Log Message
WTF should link against bmalloc
https://bugs.webkit.org/show_bug.cgi?id=131403
Reviewed by Michael Saboff.
This is required to build successfullly with bmalloc enabled.
* WTF.xcodeproj/project.pbxproj:
Modified Paths
trunk/Source/WTF/ChangeLog
trunk/Source/WTF/WTF.xcodeproj/project.pbxproj
Diff
Modified: trunk/Source/WTF/ChangeLog (166971 => 166972)
--- trunk/Source/WTF/ChangeLog 2014-04-08 22:46:10 UTC (rev 166971)
+++ trunk/Source/WTF/ChangeLog 2014-04-08 22:51:27 UTC (rev 166972)
@@ -1,5 +1,16 @@
2014-04-08 Geoffrey Garen
+WTF should link against bmalloc
+https://bugs.webkit.org/show_bug.cgi?id=131403
+
+Reviewed by Michael Saboff.
+
+This is required to build successfullly with bmalloc enabled.
+
+* WTF.xcodeproj/project.pbxproj:
+
+2014-04-08 Geoffrey Garen
+
Added a bmalloc back-end for FastMalloc
https://bugs.webkit.org/show_bug.cgi?id=131387
Modified: trunk/Source/WTF/WTF.xcodeproj/project.pbxproj (166971 => 166972)
--- trunk/Source/WTF/WTF.xcodeproj/project.pbxproj 2014-04-08 22:46:10 UTC (rev 166971)
+++ trunk/Source/WTF/WTF.xcodeproj/project.pbxproj 2014-04-08 22:51:27 UTC (rev 166972)
@@ -50,6 +50,7 @@
1469419C16EAB10A0024E146 /* AutodrainedPool.h in Headers */ = {isa = PBXBuildFile; fileRef = 1469419A16EAB10A0024E146 /* AutodrainedPool.h */; };
1469419D16EAB10A0024E146 /* AutodrainedPoolMac.mm in Sources */ = {isa = PBXBuildFile; fileRef = 1469419B16EAB10A0024E146 /* AutodrainedPoolMac.mm */; };
149EF16316BBFE0D000A4331 /* TriState.h in Headers */ = {isa = PBXBuildFile; fileRef = 149EF16216BBFE0D000A4331 /* TriState.h */; settings = {ATTRIBUTES = (); }; };
+ 14DD78D318F4B05A00950702 /* libbmalloc.a in Frameworks */ = {isa = PBXBuildFile; fileRef = 14DD78D218F4B05A00950702 /* libbmalloc.a */; };
14F3B0F715E45E4600210069 /* SaturatedArithmetic.h in Headers */ = {isa = PBXBuildFile; fileRef = 14F3B0F615E45E4600210069 /* SaturatedArithmetic.h */; settings = {ATTRIBUTES = (); }; };
1A1D8B9C173186CE00141DA4 /* FunctionDispatcher.h in Headers */ = {isa = PBXBuildFile; fileRef = 1A1D8B9B173186CE00141DA4 /* FunctionDispatcher.h */; };
1A1D8B9E1731879800141DA4 /* FunctionDispatcher.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 1A1D8B9D1731879800141DA4 /* FunctionDispatcher.cpp */; };
@@ -319,6 +320,7 @@
1469419A16EAB10A0024E146 /* AutodrainedPool.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = AutodrainedPool.h; sourceTree = ""; };
1469419B16EAB10A0024E146 /* AutodrainedPoolMac.mm */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.objcpp; path = AutodrainedPoolMac.mm; sourceTree = ""; };
149EF16216BBFE0D000A4331 /* TriState.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = TriState.h; sourceTree = ""; };
+ 14DD78D218F4B05A00950702 /* libbmalloc.a */ = {isa = PBXFileReference; lastKnownFileType = archive.ar; path = libbmalloc.a; sourceTree = BUILT_PRODUCTS_DIR; };
14F3B0F615E45E4600210069 /* SaturatedArithmetic.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = SaturatedArithmetic.h; sourceTree = ""; };
1A1D8B9B173186CE00141DA4 /* FunctionDispatcher.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = FunctionDispatcher.h; sourceTree = ""; };
1A1D8B9D1731879800141DA4 /* FunctionDispatcher.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = FunctionDispatcher.cpp; sourceTree = ""; };
@@ -561,12 +563,21 @@
isa = PBXFrameworksBuildPhase;
buildActionMask = 2147483647;
files = (
+14DD78D318F4B05A00950702 /* libbmalloc.a in Frameworks */,
);
runOnlyForDeploymentPostprocessing = 0;
};
/* End PBXFrameworksBuildPhase section */
/* Begin PBXGroup section */
+ 14DD78D418F4B0BE00950702 /* Frameworks */ = {
+ isa = PBXGroup;
+ children = (
+14DD78D218F4B05A00950702 /* libbmalloc.a */,
+ );
+ name = Frameworks;
+ sourceTree = "";
+ };
1FA47C87152502DA00568D1B /* ios */ = {
isa = PBXGroup;
children = (
@@ -588,6 +599,7 @@
isa = PBXGroup;
children = (
5D247B6D14689C4700E78B76 /* Configurations */,
+14DD78D418F4B0BE00950702 /* Frameworks */,
5D247B6314689B8600E78B76 /* Products */,
5D247B7614689D7600E78B76 /* Source */,
);
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [166971] trunk/Source/JavaScriptCore
Title: [166971] trunk/Source/_javascript_Core
Revision 166971
Author commit-qu...@webkit.org
Date 2014-04-08 15:46:10 -0700 (Tue, 08 Apr 2014)
Log Message
Web Inspector: Address stale FIXMEs concerning console in JSContext inspection
https://bugs.webkit.org/show_bug.cgi?id=131398
Patch by Joseph Pecoraro on 2014-04-08
Reviewed by Timothy Hatcher.
* inspector/InjectedScriptSource.js:
The console object can be deleted from a page or JSContext,
so keep code that expects that it could have been deleted
to be resilient in those cases.
* inspector/JSGlobalObjectScriptDebugServer.h:
* inspector/agents/JSGlobalObjectDebuggerAgent.h:
* inspector/agents/JSGlobalObjectRuntimeAgent.h:
Change the FIXMEs to NOTEs that explain why these functions
have empty implementations for JSContext inspection.
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/inspector/InjectedScriptSource.js
trunk/Source/_javascript_Core/inspector/JSGlobalObjectScriptDebugServer.h
trunk/Source/_javascript_Core/inspector/agents/JSGlobalObjectDebuggerAgent.h
trunk/Source/_javascript_Core/inspector/agents/JSGlobalObjectRuntimeAgent.h
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (166970 => 166971)
--- trunk/Source/_javascript_Core/ChangeLog 2014-04-08 22:44:39 UTC (rev 166970)
+++ trunk/Source/_javascript_Core/ChangeLog 2014-04-08 22:46:10 UTC (rev 166971)
@@ -1,3 +1,21 @@
+2014-04-08 Joseph Pecoraro
+
+Web Inspector: Address stale FIXMEs concerning console in JSContext inspection
+https://bugs.webkit.org/show_bug.cgi?id=131398
+
+Reviewed by Timothy Hatcher.
+
+* inspector/InjectedScriptSource.js:
+The console object can be deleted from a page or JSContext,
+so keep code that expects that it could have been deleted
+to be resilient in those cases.
+
+* inspector/JSGlobalObjectScriptDebugServer.h:
+* inspector/agents/JSGlobalObjectDebuggerAgent.h:
+* inspector/agents/JSGlobalObjectRuntimeAgent.h:
+Change the FIXMEs to NOTEs that explain why these functions
+have empty implementations for JSContext inspection.
+
2014-04-08 Filip Pizlo
Unreviewed, fix a goofy assertion to fix debug.
Modified: trunk/Source/_javascript_Core/inspector/InjectedScriptSource.js (166970 => 166971)
--- trunk/Source/_javascript_Core/inspector/InjectedScriptSource.js 2014-04-08 22:44:39 UTC (rev 166970)
+++ trunk/Source/_javascript_Core/inspector/InjectedScriptSource.js 2014-04-08 22:46:10 UTC (rev 166971)
@@ -209,7 +209,6 @@
var argsArray = InjectedScriptHost.evaluate("(" + args + ")");
var result = this[methodName].apply(this, argsArray);
if (typeof result === "undefined") {
-// FIXME: JS Context inspection currently does not have a global.console object.
if (inspectedGlobalObject.console)
inspectedGlobalObject.console.error("Web Inspector error: InjectedScript.%s returns undefined", methodName);
result = null;
@@ -557,7 +556,6 @@
// When not evaluating on a call frame we use a 'with' statement to allow var and function statements to leak
// into the global scope. This allow them to stick around between evaluations.
-// FIXME: JS Context inspection currently does not have a global.console object.
try {
if (commandLineAPI) {
if (inspectedGlobalObject.console)
@@ -672,7 +670,6 @@
delete this._modules[name];
var moduleFunction = InjectedScriptHost.evaluate("(" + source + ")");
if (typeof moduleFunction !== "function") {
-// FIXME: JS Context inspection currently does not have a global.console object.
if (inspectedGlobalObject.console)
inspectedGlobalObject.console.error("Web Inspector error: A function was expected for module %s evaluation", name);
return null;
Modified: trunk/Source/_javascript_Core/inspector/JSGlobalObjectScriptDebugServer.h (166970 => 166971)
--- trunk/Source/_javascript_Core/inspector/JSGlobalObjectScriptDebugServer.h 2014-04-08 22:44:39 UTC (rev 166970)
+++ trunk/Source/_javascript_Core/inspector/JSGlobalObjectScriptDebugServer.h 2014-04-08 22:46:10 UTC (rev 166971)
@@ -53,7 +53,9 @@
virtual void runEventLoopWhilePaused() override;
virtual bool isContentScript(JSC::ExecState*) const override { return false; }
-// FIXME: _javascript_ inspection has no Console yet.
+// NOTE: Currently all exceptions are reported at the API boundary through reportAPIException.
+// Until a time comes where an exception can be caused outside of the API (e.g. setTimeout
+// or some other async operation in a pure JSContext) we can ignore exceptions reported here.
virtual void reportException(JSC::ExecState*, JSC::JSValue) const override { }
ListenerSet m_listeners;
Modified: trunk/Source/_javascript_Core/inspector/agents/JSGlobalOb
[webkit-changes] [166970] trunk/Source/WebCore
Title: [166970] trunk/Source/WebCore
Revision 166970
Author enr...@apple.com
Date 2014-04-08 15:44:39 -0700 (Tue, 08 Apr 2014)
Log Message
Unreviewed iOS build fix.
Return false instead of nil in a function that returns BOOL.
* accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:
(-[WebAccessibilityObjectWrapper accessibilityCanFuzzyHitTest]):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm
Diff
Modified: trunk/Source/WebCore/ChangeLog (166969 => 166970)
--- trunk/Source/WebCore/ChangeLog 2014-04-08 22:37:19 UTC (rev 166969)
+++ trunk/Source/WebCore/ChangeLog 2014-04-08 22:44:39 UTC (rev 166970)
@@ -1,3 +1,12 @@
+2014-04-08 Enrica Casucci
+
+Unreviewed iOS build fix.
+
+Return false instead of nil in a function that returns BOOL.
+
+* accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:
+(-[WebAccessibilityObjectWrapper accessibilityCanFuzzyHitTest]):
+
2014-04-08 Brady Eidson
Non-empty ranges misdetected as empty ranges, avoiding telephone number detection.
Modified: trunk/Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm (166969 => 166970)
--- trunk/Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm 2014-04-08 22:37:19 UTC (rev 166969)
+++ trunk/Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm 2014-04-08 22:44:39 UTC (rev 166970)
@@ -265,7 +265,7 @@
- (BOOL)accessibilityCanFuzzyHitTest
{
if (![self _prepareAccessibilityCall])
-return nil;
+return false;
AccessibilityRole role = m_object->roleValue();
// Elements that can be returned when performing fuzzy hit testing.
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [166969] trunk/Source/WebKit2
Title: [166969] trunk/Source/WebKit2
Revision 166969
Author ander...@apple.com
Date 2014-04-08 15:37:19 -0700 (Tue, 08 Apr 2014)
Log Message
Change WebPageProxy::CreateNewPage to take a NavigationActionData object
https://bugs.webkit.org/show_bug.cgi?id=131401
Reviewed by Dan Bernstein.
* UIProcess/API/APIUIClient.h:
(API::UIClient::createNewPage):
* UIProcess/API/C/WKPage.cpp:
(WKPageSetPageUIClient):
* UIProcess/API/Cocoa/WKNavigationAction.mm:
(toWKNavigationType):
* UIProcess/API/Cocoa/WKNavigationActionInternal.h:
* UIProcess/Cocoa/NavigationState.mm:
(WebKit::toWKNavigationType): Deleted.
* UIProcess/Cocoa/UIDelegate.h:
* UIProcess/Cocoa/UIDelegate.mm:
(WebKit::UIDelegate::UIClient::createNewPage):
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::createNewPage):
* UIProcess/WebPageProxy.h:
* UIProcess/WebPageProxy.messages.in:
* WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::createWindow):
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/APIUIClient.h
trunk/Source/WebKit2/UIProcess/API/C/WKPage.cpp
trunk/Source/WebKit2/UIProcess/API/Cocoa/WKNavigationAction.mm
trunk/Source/WebKit2/UIProcess/API/Cocoa/WKNavigationActionInternal.h
trunk/Source/WebKit2/UIProcess/Cocoa/NavigationState.mm
trunk/Source/WebKit2/UIProcess/Cocoa/UIDelegate.h
trunk/Source/WebKit2/UIProcess/Cocoa/UIDelegate.mm
trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp
trunk/Source/WebKit2/UIProcess/WebPageProxy.h
trunk/Source/WebKit2/UIProcess/WebPageProxy.messages.in
trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebChromeClient.cpp
Diff
Modified: trunk/Source/WebKit2/ChangeLog (166968 => 166969)
--- trunk/Source/WebKit2/ChangeLog 2014-04-08 22:36:06 UTC (rev 166968)
+++ trunk/Source/WebKit2/ChangeLog 2014-04-08 22:37:19 UTC (rev 166969)
@@ -1,5 +1,31 @@
2014-04-08 Anders Carlsson
+Change WebPageProxy::CreateNewPage to take a NavigationActionData object
+https://bugs.webkit.org/show_bug.cgi?id=131401
+
+Reviewed by Dan Bernstein.
+
+* UIProcess/API/APIUIClient.h:
+(API::UIClient::createNewPage):
+* UIProcess/API/C/WKPage.cpp:
+(WKPageSetPageUIClient):
+* UIProcess/API/Cocoa/WKNavigationAction.mm:
+(toWKNavigationType):
+* UIProcess/API/Cocoa/WKNavigationActionInternal.h:
+* UIProcess/Cocoa/NavigationState.mm:
+(WebKit::toWKNavigationType): Deleted.
+* UIProcess/Cocoa/UIDelegate.h:
+* UIProcess/Cocoa/UIDelegate.mm:
+(WebKit::UIDelegate::UIClient::createNewPage):
+* UIProcess/WebPageProxy.cpp:
+(WebKit::WebPageProxy::createNewPage):
+* UIProcess/WebPageProxy.h:
+* UIProcess/WebPageProxy.messages.in:
+* WebProcess/WebCoreSupport/WebChromeClient.cpp:
+(WebKit::WebChromeClient::createWindow):
+
+2014-04-08 Anders Carlsson
+
Fix build.
* WebKit2Prefix.h:
Modified: trunk/Source/WebKit2/UIProcess/API/APIUIClient.h (166968 => 166969)
--- trunk/Source/WebKit2/UIProcess/API/APIUIClient.h 2014-04-08 22:36:06 UTC (rev 166968)
+++ trunk/Source/WebKit2/UIProcess/API/APIUIClient.h 2014-04-08 22:37:19 UTC (rev 166969)
@@ -56,6 +56,7 @@
class WebOpenPanelResultListenerProxy;
class WebPageProxy;
class WebSecurityOrigin;
+struct NavigationActionData;
}
namespace API {
@@ -67,7 +68,7 @@
public:
virtual ~UIClient() { }
-virtual PassRefPtr createNewPage(WebKit::WebPageProxy*, WebKit::WebFrameProxy*, const WebCore::ResourceRequest&, const WebCore::WindowFeatures&, WebKit::WebEvent::Modifiers, WebKit::WebMouseEvent::Button) { return nullptr; }
+virtual PassRefPtr createNewPage(WebKit::WebPageProxy*, WebKit::WebFrameProxy*, const WebCore::ResourceRequest&, const WebCore::WindowFeatures&, const WebKit::NavigationActionData&) { return nullptr; }
virtual void showPage(WebKit::WebPageProxy*) { }
virtual void close(WebKit::WebPageProxy*) { }
Modified: trunk/Source/WebKit2/UIProcess/API/C/WKPage.cpp (166968 => 166969)
--- trunk/Source/WebKit2/UIProcess/API/C/WKPage.cpp 2014-04-08 22:36:06 UTC (rev 166968)
+++ trunk/Source/WebKit2/UIProcess/API/C/WKPage.cpp 2014-04-08 22:37:19 UTC (rev 166969)
@@ -1119,7 +1119,7 @@
}
private:
-virtual PassRefPtr createNewPage(WebPageProxy* page, WebFrameProxy*, const ResourceRequest& resourceRequest, const WindowFeatures& windowFeatures, WebEvent::Modifiers modifiers, WebMouseEvent::Button button) override
+virtual PassRefPtr createNewPage(WebPageProxy* page, WebFrameProxy*, const ResourceRequest& resourceRequest, const WindowFeatures& windowFeatures, const NavigationActionData& navigationActionData) override
{
if (!m_client.base.version && !m_client.createNewPage_deprecatedForUseWithV0)
return 0;
@@ -1147,10 +1147,10 @@
RefPtr featuresMap = ImmutableDictionary::create(std::move(map));
if (!m_client.base.version)
-
[webkit-changes] [166968] trunk/Source/WebCore
Title: [166968] trunk/Source/WebCore Revision 166968 Author beid...@apple.com Date 2014-04-08 15:36:06 -0700 (Tue, 08 Apr 2014) Log Message Non-empty ranges misdetected as empty ranges, avoiding telephone number detection. and https://bugs.webkit.org/show_bug.cgi?id=131397 Reviewed by Tim Horton. No new tests (Only affects a currently untested Mac-only WK2 feature) * editing/Editor.cpp: (WebCore::Editor::scanSelectionForTelephoneNumbers): Fix detection of empty ranges so we don’t early return erroneously. Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/editing/Editor.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (166967 => 166968) --- trunk/Source/WebCore/ChangeLog 2014-04-08 22:27:37 UTC (rev 166967) +++ trunk/Source/WebCore/ChangeLog 2014-04-08 22:36:06 UTC (rev 166968) @@ -1,3 +1,16 @@ +2014-04-08 Brady Eidson + +Non-empty ranges misdetected as empty ranges, avoiding telephone number detection. + and https://bugs.webkit.org/show_bug.cgi?id=131397 + +Reviewed by Tim Horton. + +No new tests (Only affects a currently untested Mac-only WK2 feature) + +* editing/Editor.cpp: +(WebCore::Editor::scanSelectionForTelephoneNumbers): Fix detection of empty ranges so we don’t + early return erroneously. + 2014-04-08 Adenilson Cavalcanti [SVG] Fix CSS transform handling when zoomed Modified: trunk/Source/WebCore/editing/Editor.cpp (166967 => 166968) --- trunk/Source/WebCore/editing/Editor.cpp 2014-04-08 22:27:37 UTC (rev 166967) +++ trunk/Source/WebCore/editing/Editor.cpp 2014-04-08 22:36:06 UTC (rev 166968) @@ -3348,7 +3348,7 @@ clearDataDetectedTelephoneNumbers(); RefPtr selectedRange = m_frame.selection().toNormalizedRange(); -if (!selectedRange || selectedRange->startOffset() == selectedRange->endOffset()) +if (!selectedRange || (selectedRange->startContainer() == selectedRange->endContainer() && selectedRange->startOffset() == selectedRange->endOffset())) return; // FIXME: This won't work if a phone number spans multiple chunks of text from the perspective of the TextIterator ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [166964] trunk/Source/WebCore
Title: [166964] trunk/Source/WebCore Revision 166964 Author jer.no...@apple.com Date 2014-04-08 14:41:02 -0700 (Tue, 08 Apr 2014) Log Message Unreviewed iOS build fix. Pass 0 instead of nil to the options parameter of addObserver:forKeyPath:options:context. * platform/graphics/ios/TextTrackRepresentationIOS.mm: (-[WebCoreTextTrackRepresentationIOSHelper setParent:]): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/platform/graphics/ios/TextTrackRepresentationIOS.mm Diff Modified: trunk/Source/WebCore/ChangeLog (166963 => 166964) --- trunk/Source/WebCore/ChangeLog 2014-04-08 21:33:37 UTC (rev 166963) +++ trunk/Source/WebCore/ChangeLog 2014-04-08 21:41:02 UTC (rev 166964) @@ -1,3 +1,10 @@ +2014-04-08 Jer Noble + +Unreviewed iOS build fix. Pass 0 instead of nil to the options parameter of addObserver:forKeyPath:options:context. + +* platform/graphics/ios/TextTrackRepresentationIOS.mm: +(-[WebCoreTextTrackRepresentationIOSHelper setParent:]): + 2014-04-08 Antti Koivisto Remove exposedRect from TileController Modified: trunk/Source/WebCore/platform/graphics/ios/TextTrackRepresentationIOS.mm (166963 => 166964) --- trunk/Source/WebCore/platform/graphics/ios/TextTrackRepresentationIOS.mm 2014-04-08 21:33:37 UTC (rev 166963) +++ trunk/Source/WebCore/platform/graphics/ios/TextTrackRepresentationIOS.mm 2014-04-08 21:41:02 UTC (rev 166964) @@ -69,7 +69,7 @@ _parent = parent; if (_parent) -[_parent->platformLayer() addObserver:self forKeyPath:@"bounds" options:nil context:0]; +[_parent->platformLayer() addObserver:self forKeyPath:@"bounds" options:0 context:0]; } - (TextTrackRepresentationIOS*)parent ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [166963] trunk/Source/WebKit2
Title: [166963] trunk/Source/WebKit2 Revision 166963 Author ander...@apple.com Date 2014-04-08 14:33:37 -0700 (Tue, 08 Apr 2014) Log Message Fix build. * WebKit2Prefix.h: Modified Paths trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/WebKit2Prefix.h Diff Modified: trunk/Source/WebKit2/ChangeLog (166962 => 166963) --- trunk/Source/WebKit2/ChangeLog 2014-04-08 21:29:09 UTC (rev 166962) +++ trunk/Source/WebKit2/ChangeLog 2014-04-08 21:33:37 UTC (rev 166963) @@ -1,5 +1,11 @@ 2014-04-08 Anders Carlsson +Fix build. + +* WebKit2Prefix.h: + +2014-04-08 Anders Carlsson + Use an explicit class when decoding individual bundle parameters https://bugs.webkit.org/show_bug.cgi?id=131392 Modified: trunk/Source/WebKit2/WebKit2Prefix.h (166962 => 166963) --- trunk/Source/WebKit2/WebKit2Prefix.h 2014-04-08 21:29:09 UTC (rev 166962) +++ trunk/Source/WebKit2/WebKit2Prefix.h 2014-04-08 21:33:37 UTC (rev 166963) @@ -69,6 +69,10 @@ #endif #if PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED == 1080 && defined(__OBJC__) +@interface NSKeyedArchiver (WKDetails) +- (void)setRequiresSecureCoding:(BOOL)requiresSecureCoding; +@end + @interface NSKeyedUnarchiver (WKDetails) - (void)setRequiresSecureCoding:(BOOL)requiresSecureCoding; @end ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [166962] trunk/Source/WebInspectorUI
Title: [166962] trunk/Source/WebInspectorUI
Revision 166962
Author bfulg...@apple.com
Date 2014-04-08 14:29:09 -0700 (Tue, 08 Apr 2014)
Log Message
[Windows] Generate Optimized WebInspectorUI in Release Build
https://bugs.webkit.org/show_bug.cgi?id=120120
Reviewed by Timothy Hatcher.
* Scripts/copy-user-interface-resources.pl: Copied from Scripts/copy-user-interface-resources.sh.
* Scripts/copy-user-interface-resources.sh: Removed.
* Scripts/remove-console-asserts.pl:
* WebInspectorUI.vcxproj/WebInspectorUI.make: Added.
* WebInspectorUI.vcxproj/WebInspectorUI.vcxproj: Switch to Makefile style.
* WebInspectorUI.vcxproj/WebInspectorUI.vcxproj.filters: Ditto.
* WebInspectorUI.vcxproj/WebInspectorUIPostBuild.cmd: More work should
be done in the new build-webinspectorui.sh file.
* WebInspectorUI.vcxproj/build-webinspectorui.sh: Added.
* WebInspectorUI.xcodeproj/project.pbxproj:
Modified Paths
trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/Scripts/remove-console-asserts.pl
trunk/Source/WebInspectorUI/WebInspectorUI.vcxproj/WebInspectorUI.vcxproj
trunk/Source/WebInspectorUI/WebInspectorUI.vcxproj/WebInspectorUI.vcxproj.filters
trunk/Source/WebInspectorUI/WebInspectorUI.xcodeproj/project.pbxproj
Added Paths
trunk/Source/WebInspectorUI/Scripts/copy-user-interface-resources.pl
trunk/Source/WebInspectorUI/WebInspectorUI.vcxproj/WebInspectorUI.make
trunk/Source/WebInspectorUI/WebInspectorUI.vcxproj/build-webinspectorui.sh
Removed Paths
trunk/Source/WebInspectorUI/Scripts/copy-user-interface-resources.sh
trunk/Source/WebInspectorUI/WebInspectorUI.vcxproj/WebInspectorUIPostBuild.cmd
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (166961 => 166962)
--- trunk/Source/WebInspectorUI/ChangeLog 2014-04-08 21:22:35 UTC (rev 166961)
+++ trunk/Source/WebInspectorUI/ChangeLog 2014-04-08 21:29:09 UTC (rev 166962)
@@ -1,3 +1,21 @@
+2014-04-08 Brent Fulgham
+
+[Windows] Generate Optimized WebInspectorUI in Release Build
+https://bugs.webkit.org/show_bug.cgi?id=120120
+
+Reviewed by Timothy Hatcher.
+
+* Scripts/copy-user-interface-resources.pl: Copied from Scripts/copy-user-interface-resources.sh.
+* Scripts/copy-user-interface-resources.sh: Removed.
+* Scripts/remove-console-asserts.pl:
+* WebInspectorUI.vcxproj/WebInspectorUI.make: Added.
+* WebInspectorUI.vcxproj/WebInspectorUI.vcxproj: Switch to Makefile style.
+* WebInspectorUI.vcxproj/WebInspectorUI.vcxproj.filters: Ditto.
+* WebInspectorUI.vcxproj/WebInspectorUIPostBuild.cmd: More work should
+be done in the new build-webinspectorui.sh file.
+* WebInspectorUI.vcxproj/build-webinspectorui.sh: Added.
+* WebInspectorUI.xcodeproj/project.pbxproj:
+
2014-04-08 Timothy Hatcher
Fix corrupt APPLE_IMAGES_LICENSE.rtf after r165676.
Copied: trunk/Source/WebInspectorUI/Scripts/copy-user-interface-resources.pl (from rev 166893, trunk/Source/WebInspectorUI/Scripts/copy-user-interface-resources.sh) (0 => 166962)
--- trunk/Source/WebInspectorUI/Scripts/copy-user-interface-resources.pl (rev 0)
+++ trunk/Source/WebInspectorUI/Scripts/copy-user-interface-resources.pl 2014-04-08 21:29:09 UTC (rev 166962)
@@ -0,0 +1,163 @@
+#!/usr/bin/perl -w
+
+use File::Copy qw(copy);
+use File::Path qw(make_path);
+use File::Spec;
+
+my $useDirCopy = 0;
+
+# Not all systems (e.g., OS X) include File::Copy::Recursive. Only
+# use it if we have it installed.
+eval "use File::Copy::Recursive";
+unless ($@) {
+$useDirCopy = 1;
+File::Copy::Recursive->import();
+}
+
+sub ditto($$)
+{
+my ($source, $destination) = @_;
+
+if ($useDirCopy) {
+File::Copy::Recursive::dircopy($source, $destination) or die "Unable to copy directory $source to $destination: $!";
+} elsif ($^O eq 'darwin') {
+system('ditto', $source, $destination);
+} else {
+die "Please install the PEP module File::Copy::Recursive";
+}
+}
+
+sub seedFile($$)
+{
+my ($targetFile, $seedText) = @_;
+
+if (open(TARGET_FILE, '>', $targetFile)) {
+print TARGET_FILE $seedText;
+close(TARGET_FILE);
+}
+}
+
+my $LICENSE = <<'EOF';
+/*
+ * Copyright (C) 2007-2014 Apple Inc. All rights reserved.
+ * Copyright (C) 2009-2011 Google Inc. All rights reserved.
+ * Copyright (C) 2009-2010 Joseph Pecoraro. All rights reserved.
+ * Copyright (C) 2008 Matt Lilek. All rights reserved.
+ * Copyright (C) 2008-2009 Anthony Ricaud
+ * Copyright (C) 2009 280 North Inc. All Rights Reserved.
+ * Copyright (C) 2010 Nikita Vasilyev. All rights reserved.
+ * Copyright (C) 2011 Brian Grinstead All rights reserved.
+ * Copyright (C) 2013 Matt Holden
+ * Copyright (C) 2013 Samsung Electronics. All rights reserved.
+ * Copyright (C) 2013 Seokju Kwon (seokju.k...@gmail.com)
+ * Copyright (C) 2013 Adobe Systems Inc. All rights reserved.
+ * Copyright (C) 2013 University of Washington. All rights reserved.
+ *
+ * Re
[webkit-changes] [166961] trunk/Source/WebKit2
Title: [166961] trunk/Source/WebKit2
Revision 166961
Author ander...@apple.com
Date 2014-04-08 14:22:35 -0700 (Tue, 08 Apr 2014)
Log Message
Use an explicit class when decoding individual bundle parameters
https://bugs.webkit.org/show_bug.cgi?id=131392
Reviewed by Dan Bernstein.
* WebProcess/InjectedBundle/mac/InjectedBundleMac.mm:
(WebKit::InjectedBundle::setBundleParameter):
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/WebProcess/InjectedBundle/mac/InjectedBundleMac.mm
Diff
Modified: trunk/Source/WebKit2/ChangeLog (166960 => 166961)
--- trunk/Source/WebKit2/ChangeLog 2014-04-08 21:18:57 UTC (rev 166960)
+++ trunk/Source/WebKit2/ChangeLog 2014-04-08 21:22:35 UTC (rev 166961)
@@ -1,5 +1,16 @@
2014-04-08 Anders Carlsson
+Use an explicit class when decoding individual bundle parameters
+https://bugs.webkit.org/show_bug.cgi?id=131392
+
+
+Reviewed by Dan Bernstein.
+
+* WebProcess/InjectedBundle/mac/InjectedBundleMac.mm:
+(WebKit::InjectedBundle::setBundleParameter):
+
+2014-04-08 Anders Carlsson
+
Move a Mountain Lion declaration to the WebKit2 prefix header
https://bugs.webkit.org/show_bug.cgi?id=131391
Modified: trunk/Source/WebKit2/WebProcess/InjectedBundle/mac/InjectedBundleMac.mm (166960 => 166961)
--- trunk/Source/WebKit2/WebProcess/InjectedBundle/mac/InjectedBundleMac.mm 2014-04-08 21:18:57 UTC (rev 166960)
+++ trunk/Source/WebKit2/WebProcess/InjectedBundle/mac/InjectedBundleMac.mm 2014-04-08 21:22:35 UTC (rev 166961)
@@ -147,7 +147,7 @@
id parameter = nil;
@try {
-parameter = [unarchiver decodeObjectForKey:@"parameter"];
+parameter = [unarchiver decodeObjectOfClass:[NSObject class] forKey:@"parameter"];
} @catch (NSException *exception) {
LOG_ERROR("Failed to decode bundle parameter: %@", exception);
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [166960] trunk/LayoutTests
Title: [166960] trunk/LayoutTests
Revision 166960
Author bfulg...@apple.com
Date 2014-04-08 14:18:57 -0700 (Tue, 08 Apr 2014)
Log Message
[Mac] Unreviewed test gardening.
Rebaseline scrolling tests to remove flakiness introduced by slight differences in
pixel scroll counts between WK1 and WK2 test runners.
* platform/mac/fast/scrolling/scroll-div-latched-div-expected.txt:
* platform/mac/fast/scrolling/scroll-div-latched-div.html:
* platform/mac/fast/scrolling/scroll-div-latched-mainframe-expected.txt:
* platform/mac/fast/scrolling/scroll-div-latched-mainframe.html:
* platform/mac/fast/scrolling/scroll-iframe-latched-iframe-expected.txt:
* platform/mac/fast/scrolling/scroll-iframe-latched-iframe.html:
* platform/mac/fast/scrolling/scroll-iframe-latched-mainframe-expected.txt:
* platform/mac/fast/scrolling/scroll-iframe-latched-mainframe.html:
* platform/mac/fast/scrolling/scroll-select-latched-mainframe-expected.txt:
* platform/mac/fast/scrolling/scroll-select-latched-mainframe.html:
* platform/mac/fast/scrolling/scroll-select-latched-select-expected.txt:
* platform/mac/fast/scrolling/scroll-select-latched-select.html:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac/fast/scrolling/scroll-div-latched-div-expected.txt
trunk/LayoutTests/platform/mac/fast/scrolling/scroll-div-latched-div.html
trunk/LayoutTests/platform/mac/fast/scrolling/scroll-div-latched-mainframe-expected.txt
trunk/LayoutTests/platform/mac/fast/scrolling/scroll-div-latched-mainframe.html
trunk/LayoutTests/platform/mac/fast/scrolling/scroll-iframe-latched-iframe-expected.txt
trunk/LayoutTests/platform/mac/fast/scrolling/scroll-iframe-latched-iframe.html
trunk/LayoutTests/platform/mac/fast/scrolling/scroll-iframe-latched-mainframe-expected.txt
trunk/LayoutTests/platform/mac/fast/scrolling/scroll-iframe-latched-mainframe.html
trunk/LayoutTests/platform/mac/fast/scrolling/scroll-select-latched-mainframe-expected.txt
trunk/LayoutTests/platform/mac/fast/scrolling/scroll-select-latched-mainframe.html
trunk/LayoutTests/platform/mac/fast/scrolling/scroll-select-latched-select-expected.txt
trunk/LayoutTests/platform/mac/fast/scrolling/scroll-select-latched-select.html
Diff
Modified: trunk/LayoutTests/ChangeLog (166959 => 166960)
--- trunk/LayoutTests/ChangeLog 2014-04-08 21:11:31 UTC (rev 166959)
+++ trunk/LayoutTests/ChangeLog 2014-04-08 21:18:57 UTC (rev 166960)
@@ -1,3 +1,23 @@
+2014-04-08 Brent Fulgham
+
+[Mac] Unreviewed test gardening.
+
+Rebaseline scrolling tests to remove flakiness introduced by slight differences in
+pixel scroll counts between WK1 and WK2 test runners.
+
+* platform/mac/fast/scrolling/scroll-div-latched-div-expected.txt:
+* platform/mac/fast/scrolling/scroll-div-latched-div.html:
+* platform/mac/fast/scrolling/scroll-div-latched-mainframe-expected.txt:
+* platform/mac/fast/scrolling/scroll-div-latched-mainframe.html:
+* platform/mac/fast/scrolling/scroll-iframe-latched-iframe-expected.txt:
+* platform/mac/fast/scrolling/scroll-iframe-latched-iframe.html:
+* platform/mac/fast/scrolling/scroll-iframe-latched-mainframe-expected.txt:
+* platform/mac/fast/scrolling/scroll-iframe-latched-mainframe.html:
+* platform/mac/fast/scrolling/scroll-select-latched-mainframe-expected.txt:
+* platform/mac/fast/scrolling/scroll-select-latched-mainframe.html:
+* platform/mac/fast/scrolling/scroll-select-latched-select-expected.txt:
+* platform/mac/fast/scrolling/scroll-select-latched-select.html:
+
2014-04-08 Carlos Alberto Lopez Perez
[GTK] Unreviewed GTK gardening.
Modified: trunk/LayoutTests/platform/mac/fast/scrolling/scroll-div-latched-div-expected.txt (166959 => 166960)
--- trunk/LayoutTests/platform/mac/fast/scrolling/scroll-div-latched-div-expected.txt 2014-04-08 21:11:31 UTC (rev 166959)
+++ trunk/LayoutTests/platform/mac/fast/scrolling/scroll-div-latched-div-expected.txt 2014-04-08 21:18:57 UTC (rev 166960)
@@ -54,7 +54,5 @@
TEST COMPLETE
div display height = 485
Mouse moved to (28, 610)
-Page before: 0, div before: 451
-Page after: 0, div after: 451
PASS Page did not receive wheel events.
Modified: trunk/LayoutTests/platform/mac/fast/scrolling/scroll-div-latched-div.html (166959 => 166960)
--- trunk/LayoutTests/platform/mac/fast/scrolling/scroll-div-latched-div.html 2014-04-08 21:11:31 UTC (rev 166959)
+++ trunk/LayoutTests/platform/mac/fast/scrolling/scroll-div-latched-div.html 2014-04-08 21:18:57 UTC (rev 166960)
@@ -46,8 +46,8 @@
var pageScrollPositionAfter = document.body.scrollTop;
var divScrollPositionAfter = divTarget.scrollTop;
-debug("Page before: " + pageScrollPositionBefore + ", div before: " + divScrollPositionBefore);
-debug("Page after: " + pageScrollPositionAfter + ", div after: " + divScrollPositionAfter);
+//debug("Page before: " + pageScrollPositionBefore + ", div before: " + divScrollPositionBef
[webkit-changes] [166959] trunk/Source/WebKit2
Title: [166959] trunk/Source/WebKit2
Revision 166959
Author ander...@apple.com
Date 2014-04-08 14:11:31 -0700 (Tue, 08 Apr 2014)
Log Message
Move a Mountain Lion declaration to the WebKit2 prefix header
https://bugs.webkit.org/show_bug.cgi?id=131391
Reviewed by Tim Horton.
* UIProcess/API/Cocoa/WKProcessPool.mm:
* UIProcess/ios/PageClientImplIOS.mm:
* UIProcess/mac/WebContextMac.mm:
* WebKit2Prefix.h:
* WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextController.mm:
* WebProcess/InjectedBundle/mac/InjectedBundleMac.mm:
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/Cocoa/WKProcessPool.mm
trunk/Source/WebKit2/UIProcess/ios/PageClientImplIOS.mm
trunk/Source/WebKit2/UIProcess/mac/WebContextMac.mm
trunk/Source/WebKit2/WebKit2Prefix.h
trunk/Source/WebKit2/WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextController.mm
trunk/Source/WebKit2/WebProcess/InjectedBundle/mac/InjectedBundleMac.mm
Diff
Modified: trunk/Source/WebKit2/ChangeLog (166958 => 166959)
--- trunk/Source/WebKit2/ChangeLog 2014-04-08 20:50:47 UTC (rev 166958)
+++ trunk/Source/WebKit2/ChangeLog 2014-04-08 21:11:31 UTC (rev 166959)
@@ -1,3 +1,17 @@
+2014-04-08 Anders Carlsson
+
+Move a Mountain Lion declaration to the WebKit2 prefix header
+https://bugs.webkit.org/show_bug.cgi?id=131391
+
+Reviewed by Tim Horton.
+
+* UIProcess/API/Cocoa/WKProcessPool.mm:
+* UIProcess/ios/PageClientImplIOS.mm:
+* UIProcess/mac/WebContextMac.mm:
+* WebKit2Prefix.h:
+* WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextController.mm:
+* WebProcess/InjectedBundle/mac/InjectedBundleMac.mm:
+
2014-04-08 Antti Koivisto
Remove exposedRect from TileController
Modified: trunk/Source/WebKit2/UIProcess/API/Cocoa/WKProcessPool.mm (166958 => 166959)
--- trunk/Source/WebKit2/UIProcess/API/Cocoa/WKProcessPool.mm 2014-04-08 20:50:47 UTC (rev 166958)
+++ trunk/Source/WebKit2/UIProcess/API/Cocoa/WKProcessPool.mm 2014-04-08 21:11:31 UTC (rev 166959)
@@ -56,12 +56,6 @@
};
#endif
-#if PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED == 1080
-@interface NSKeyedArchiver (WKDetails)
-- (void)setRequiresSecureCoding:(BOOL)b;
-@end
-#endif
-
@implementation WKProcessPool {
WebKit::WeakObjCPtr> _downloadDelegate;
Modified: trunk/Source/WebKit2/UIProcess/ios/PageClientImplIOS.mm (166958 => 166959)
--- trunk/Source/WebKit2/UIProcess/ios/PageClientImplIOS.mm 2014-04-08 20:50:47 UTC (rev 166958)
+++ trunk/Source/WebKit2/UIProcess/ios/PageClientImplIOS.mm 2014-04-08 21:11:31 UTC (rev 166959)
@@ -47,12 +47,6 @@
#import
#import
-#if PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED == 1080
-@interface NSKeyedUnarchiver (WKDetails)
-- (void)setRequiresSecureCoding:(BOOL)b;
-@end
-#endif
-
#define MESSAGE_CHECK(assertion) MESSAGE_CHECK_BASE(assertion, m_webView->_page->process().connection())
@interface UIView (IPI)
Modified: trunk/Source/WebKit2/UIProcess/mac/WebContextMac.mm (166958 => 166959)
--- trunk/Source/WebKit2/UIProcess/mac/WebContextMac.mm 2014-04-08 20:50:47 UTC (rev 166958)
+++ trunk/Source/WebKit2/UIProcess/mac/WebContextMac.mm 2014-04-08 21:11:31 UTC (rev 166959)
@@ -61,12 +61,6 @@
#endif
-#if PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED == 1080
-@interface NSKeyedArchiver (WKDetails)
-- (void)setRequiresSecureCoding:(BOOL)b;
-@end
-#endif
-
using namespace WebCore;
NSString *WebDatabaseDirectoryDefaultsKey = @"WebDatabaseDirectory";
Modified: trunk/Source/WebKit2/WebKit2Prefix.h (166958 => 166959)
--- trunk/Source/WebKit2/WebKit2Prefix.h 2014-04-08 20:50:47 UTC (rev 166958)
+++ trunk/Source/WebKit2/WebKit2Prefix.h 2014-04-08 21:11:31 UTC (rev 166959)
@@ -68,6 +68,12 @@
#define WTF_USE_XPC_SERVICES 1
#endif
+#if PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED == 1080 && defined(__OBJC__)
+@interface NSKeyedUnarchiver (WKDetails)
+- (void)setRequiresSecureCoding:(BOOL)requiresSecureCoding;
+@end
+#endif
+
#if PLATFORM(GTK)
#define ENABLE_NETWORK_PROCESS 1
#define ENABLE_CUSTOM_PROTOCOLS 1
Modified: trunk/Source/WebKit2/WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextController.mm (166958 => 166959)
--- trunk/Source/WebKit2/WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextController.mm 2014-04-08 20:50:47 UTC (rev 166958)
+++ trunk/Source/WebKit2/WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextController.mm 2014-04-08 21:11:31 UTC (rev 166959)
@@ -57,12 +57,6 @@
#import
#import
-#if PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED == 1080
-@interface NSKeyedArchiver (WKDetails)
-- (void)setRequiresSecureCoding:(BOOL)b;
-@end
-#endif
-
using namespace WebCore;
using namespace WebKit;
Modified: trunk/Source/WebKit2/WebProcess/InjectedBundle/mac/InjectedBundleMac.mm (166958 => 166959)
--- trunk/Source/WebKit2/WebProcess/InjectedBundle/mac/InjectedBundleMac.mm 2014-04-08 20:50:47 UTC
[webkit-changes] [166958] trunk/Source
Title: [166958] trunk/Source
Revision 166958
Author an...@apple.com
Date 2014-04-08 13:50:47 -0700 (Tue, 08 Apr 2014)
Log Message
Remove exposedRect from TileController
https://bugs.webkit.org/show_bug.cgi?id=131378
Reviewed by Simon Fraser.
Source/WebCore:
Having two separate visible rectangles is confusing. We should compute one on higher level.
* page/FrameView.cpp:
(WebCore::FrameView::setExposedRect):
Push exposed rect to tile controller by doing a layer flush (like the changed visible rect is normally passed).
* platform/graphics/TiledBacking.h:
* platform/graphics/ca/mac/TileController.h:
* platform/graphics/ca/mac/TileController.mm:
Remove exposedRect and just use visibleRect.
(WebCore::TileController::TileController):
(WebCore::TileController::setTiledScrollingIndicatorPosition):
Update the scrolling indicator position.
(WebCore::TileController::updateTileCoverageMap):
(WebCore::TileController::setExposedRect): Deleted.
* platform/graphics/ca/mac/TileGrid.h:
* platform/graphics/ca/mac/TileGrid.mm:
(WebCore::TileGrid::tilesWouldChangeForVisibleRect):
(WebCore::TileGrid::revalidateTiles):
(WebCore::TileGrid::scaledExposedRect): Deleted.
* rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::RenderLayerBacking):
No need to push exposedRect anymore.
* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::flushPendingLayerChanges):
Integrate exposed rect to visible rect when flushing layers.
Source/WebKit2:
* WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.mm:
(WebKit::RemoteLayerTreeDrawingArea::updateScrolledExposedRect):
* WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
(WebKit::TiledCoreAnimationDrawingArea::updateScrolledExposedRect):
Update the visible rect for pageOverlayLayers by calling flushCompositingState. This way
tile controller visible rect updates always happens via compositing flush (we assert
for this in TileController::setVisibleRect).
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/FrameView.cpp
trunk/Source/WebCore/platform/graphics/TiledBacking.h
trunk/Source/WebCore/platform/graphics/ca/mac/TileController.h
trunk/Source/WebCore/platform/graphics/ca/mac/TileController.mm
trunk/Source/WebCore/platform/graphics/ca/mac/TileGrid.h
trunk/Source/WebCore/platform/graphics/ca/mac/TileGrid.mm
trunk/Source/WebCore/rendering/RenderLayerBacking.cpp
trunk/Source/WebCore/rendering/RenderLayerCompositor.cpp
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.mm
trunk/Source/WebKit2/WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm
Diff
Modified: trunk/Source/WebCore/ChangeLog (166957 => 166958)
--- trunk/Source/WebCore/ChangeLog 2014-04-08 20:36:17 UTC (rev 166957)
+++ trunk/Source/WebCore/ChangeLog 2014-04-08 20:50:47 UTC (rev 166958)
@@ -1,3 +1,45 @@
+2014-04-08 Antti Koivisto
+
+Remove exposedRect from TileController
+https://bugs.webkit.org/show_bug.cgi?id=131378
+
+Reviewed by Simon Fraser.
+
+Having two separate visible rectangles is confusing. We should compute one on higher level.
+
+* page/FrameView.cpp:
+(WebCore::FrameView::setExposedRect):
+
+Push exposed rect to tile controller by doing a layer flush (like the changed visible rect is normally passed).
+
+* platform/graphics/TiledBacking.h:
+* platform/graphics/ca/mac/TileController.h:
+* platform/graphics/ca/mac/TileController.mm:
+
+Remove exposedRect and just use visibleRect.
+
+(WebCore::TileController::TileController):
+(WebCore::TileController::setTiledScrollingIndicatorPosition):
+
+Update the scrolling indicator position.
+
+(WebCore::TileController::updateTileCoverageMap):
+(WebCore::TileController::setExposedRect): Deleted.
+* platform/graphics/ca/mac/TileGrid.h:
+* platform/graphics/ca/mac/TileGrid.mm:
+(WebCore::TileGrid::tilesWouldChangeForVisibleRect):
+(WebCore::TileGrid::revalidateTiles):
+(WebCore::TileGrid::scaledExposedRect): Deleted.
+* rendering/RenderLayerBacking.cpp:
+(WebCore::RenderLayerBacking::RenderLayerBacking):
+
+No need to push exposedRect anymore.
+
+* rendering/RenderLayerCompositor.cpp:
+(WebCore::RenderLayerCompositor::flushPendingLayerChanges):
+
+Integrate exposed rect to visible rect when flushing layers.
+
2014-04-08 Andreas Kling
[Mac] Always do a full GC when simulating memory pressure.
Modified: trunk/Source/WebCore/page/FrameView.cpp (166957 => 166958)
--- trunk/Source/WebCore/page/FrameView.cpp 2014-04-08 20:36:17 UTC (rev 166957)
+++ trunk/Source/WebCore/page/FrameView.cpp 2014-04-08 20:50:47 UTC (rev 166958)
@@ -4290,14 +4290,16 @@
{
if (m_exposedRect == expose
[webkit-changes] [166957] trunk/Source/WTF
Title: [166957] trunk/Source/WTF
Revision 166957
Author gga...@apple.com
Date 2014-04-08 13:36:17 -0700 (Tue, 08 Apr 2014)
Log Message
Added a bmalloc back-end for FastMalloc
https://bugs.webkit.org/show_bug.cgi?id=131387
Reviewed by Andreas Kling.
We'll need to rethink some things if we adopt this back-end. For example,
fastMallocSize() and fastMallocGoodSize() are no longer real things. But,
this is enough to test for now.
* wtf/FastMalloc.cpp:
(WTF::fastMalloc):
(WTF::fastCalloc):
(WTF::fastRealloc):
(WTF::fastFree):
(WTF::fastMallocSize):
(WTF::fastMallocGoodSize):
(WTF::tryFastMalloc):
(WTF::tryFastRealloc):
(WTF::tryFastCalloc):
(WTF::releaseFastMallocFreeMemory):
(WTF::fastMallocStatistics):
Modified Paths
trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/FastMalloc.cpp
Diff
Modified: trunk/Source/WTF/ChangeLog (166956 => 166957)
--- trunk/Source/WTF/ChangeLog 2014-04-08 20:36:07 UTC (rev 166956)
+++ trunk/Source/WTF/ChangeLog 2014-04-08 20:36:17 UTC (rev 166957)
@@ -1,3 +1,27 @@
+2014-04-08 Geoffrey Garen
+
+Added a bmalloc back-end for FastMalloc
+https://bugs.webkit.org/show_bug.cgi?id=131387
+
+Reviewed by Andreas Kling.
+
+We'll need to rethink some things if we adopt this back-end. For example,
+fastMallocSize() and fastMallocGoodSize() are no longer real things. But,
+this is enough to test for now.
+
+* wtf/FastMalloc.cpp:
+(WTF::fastMalloc):
+(WTF::fastCalloc):
+(WTF::fastRealloc):
+(WTF::fastFree):
+(WTF::fastMallocSize):
+(WTF::fastMallocGoodSize):
+(WTF::tryFastMalloc):
+(WTF::tryFastRealloc):
+(WTF::tryFastCalloc):
+(WTF::releaseFastMallocFreeMemory):
+(WTF::fastMallocStatistics):
+
2014-04-08 Andres Gomez
[GTK] [EFL] Build fails with GCC < 4.8.x
Modified: trunk/Source/WTF/wtf/FastMalloc.cpp (166956 => 166957)
--- trunk/Source/WTF/wtf/FastMalloc.cpp 2014-04-08 20:36:07 UTC (rev 166956)
+++ trunk/Source/WTF/wtf/FastMalloc.cpp 2014-04-08 20:36:17 UTC (rev 166957)
@@ -423,6 +423,68 @@
extern "C" WTF_EXPORT_PRIVATE const int jscore_fastmalloc_introspection = 0;
#endif
+#elif defined(USE_BMALLOC) && USE_BMALLOC // FORCE_SYSTEM_MALLOC
+
+#include "bmalloc.h"
+
+namespace WTF {
+
+void* fastMalloc(size_t size)
+{
+ASSERT(!isForbidden());
+return bmalloc::api::malloc(size);
+}
+
+void* fastCalloc(size_t numElements, size_t elementSize)
+{
+return fastZeroedMalloc(numElements * elementSize);
+}
+
+void* fastRealloc(void* object, size_t size)
+{
+return bmalloc::api::realloc(object, size);
+}
+
+void fastFree(void* object)
+{
+bmalloc::api::free(object);
+}
+
+size_t fastMallocSize(const void*)
+{
+return 1;
+}
+
+size_t fastMallocGoodSize(size_t size)
+{
+return size;
+}
+
+TryMallocReturnValue tryFastMalloc(size_t size)
+{
+return fastMalloc(size);
+}
+
+TryMallocReturnValue tryFastRealloc(void* p, size_t n)
+{
+return fastRealloc(p, n);
+}
+
+TryMallocReturnValue tryFastCalloc(size_t numElements, size_t elementSize)
+{
+return fastCalloc(numElements, elementSize);
+}
+
+void releaseFastMallocFreeMemory() { }
+
+FastMallocStatistics fastMallocStatistics()
+{
+FastMallocStatistics statistics = { 0, 0, 0 };
+return statistics;
+}
+
+} // namespace WTF
+
#else // FORCE_SYSTEM_MALLOC
#include "TCPackedCache.h"
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [166955] trunk/Source/WebInspectorUI
Title: [166955] trunk/Source/WebInspectorUI
Revision 166955
Author timo...@apple.com
Date 2014-04-08 13:32:36 -0700 (Tue, 08 Apr 2014)
Log Message
Fix corrupt APPLE_IMAGES_LICENSE.rtf after r165676.
https://bugs.webkit.org/show_bug.cgi?id=131384
Reviewed by Joseph Pecoraro.
* APPLE_IMAGES_LICENSE.rtf:
Modified Paths
trunk/Source/WebInspectorUI/APPLE_IMAGES_LICENSE.rtf
trunk/Source/WebInspectorUI/ChangeLog
Diff
Modified: trunk/Source/WebInspectorUI/APPLE_IMAGES_LICENSE.rtf (166954 => 166955)
--- trunk/Source/WebInspectorUI/APPLE_IMAGES_LICENSE.rtf 2014-04-08 20:32:31 UTC (rev 166954)
+++ trunk/Source/WebInspectorUI/APPLE_IMAGES_LICENSE.rtf 2014-04-08 20:32:36 UTC (rev 166955)
@@ -1,8 +1,8 @@
-{\rtf1\ansi\ansicpg1252\cocoartf1187\cocoasubrtf340
+{\rtf1\ansi\ansicpg1252\cocoartf1265\cocoasubrtf190
{\fonttbl\f0\fnil\fcharset0 HelveticaNeue;}
{\colortbl;\red255\green255\blue255;\red0\green0\blue255;\red255\green0\blue0;}
{\info
-{\title Apple Inc.
+{\title Apple Inc.}
{\author Joyce Chow}
{\*\company Apple Inc.}}\margl1267\margr994\margb1080\margt634\vieww30680\viewh19140\viewkind0
\deftab720
Modified: trunk/Source/WebInspectorUI/ChangeLog (166954 => 166955)
--- trunk/Source/WebInspectorUI/ChangeLog 2014-04-08 20:32:31 UTC (rev 166954)
+++ trunk/Source/WebInspectorUI/ChangeLog 2014-04-08 20:32:36 UTC (rev 166955)
@@ -1,5 +1,14 @@
2014-04-08 Timothy Hatcher
+Fix corrupt APPLE_IMAGES_LICENSE.rtf after r165676.
+https://bugs.webkit.org/show_bug.cgi?id=131384
+
+Reviewed by Joseph Pecoraro.
+
+* APPLE_IMAGES_LICENSE.rtf:
+
+2014-04-08 Timothy Hatcher
+
Clean up old protocol JSON files to better match the latest
https://bugs.webkit.org/show_bug.cgi?id=131308
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [166954] trunk/Tools
Title: [166954] trunk/Tools
Revision 166954
Author mr...@apple.com
Date 2014-04-08 13:32:31 -0700 (Tue, 08 Apr 2014)
Log Message
XPC services launched by Safari have wrong DYLD_FRAMEWORK_PATH set when launched via run-safari / debug-safari
/
Reviewed by Alexey Proskuryakov.
* Scripts/webkitdirs.pm:
(runMacWebKitApp): Set __XPC_DYLD_FRAMEWORK_PATH to the absolute path to the built products directory.
(execMacWebKitAppForDebugging): Ditto.
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitdirs.pm
Diff
Modified: trunk/Tools/ChangeLog (166953 => 166954)
--- trunk/Tools/ChangeLog 2014-04-08 20:26:54 UTC (rev 166953)
+++ trunk/Tools/ChangeLog 2014-04-08 20:32:31 UTC (rev 166954)
@@ -1,3 +1,14 @@
+2014-04-08 Mark Rowe
+
+XPC services launched by Safari have wrong DYLD_FRAMEWORK_PATH set when launched via run-safari / debug-safari
+ /
+
+Reviewed by Alexey Proskuryakov.
+
+* Scripts/webkitdirs.pm:
+(runMacWebKitApp): Set __XPC_DYLD_FRAMEWORK_PATH to the absolute path to the built products directory.
+(execMacWebKitAppForDebugging): Ditto.
+
2014-04-08 Geoffrey Garen
Build bmalloc on iOS too
Modified: trunk/Tools/Scripts/webkitdirs.pm (166953 => 166954)
--- trunk/Tools/Scripts/webkitdirs.pm 2014-04-08 20:26:54 UTC (rev 166953)
+++ trunk/Tools/Scripts/webkitdirs.pm 2014-04-08 20:32:31 UTC (rev 166954)
@@ -2009,6 +2009,7 @@
my $productDir = productDir();
print "Starting @{[basename($appPath)]} with DYLD_FRAMEWORK_PATH set to point to built WebKit in $productDir.\n";
$ENV{DYLD_FRAMEWORK_PATH} = $productDir;
+$ENV{__XPC_DYLD_FRAMEWORK_PATH} = File::Spec->rel2abs($productDir);
$ENV{WEBKIT_UNSET_DYLD_FRAMEWORK_PATH} = "YES";
setUpGuardMallocIfNeeded();
@@ -2044,6 +2045,7 @@
my $productDir = productDir();
$ENV{DYLD_FRAMEWORK_PATH} = $productDir;
+$ENV{__XPC_DYLD_FRAMEWORK_PATH} = File::Spec->rel2abs($productDir);
$ENV{WEBKIT_UNSET_DYLD_FRAMEWORK_PATH} = "YES";
setUpGuardMallocIfNeeded();
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [166953] trunk/Source/WebCore
Title: [166953] trunk/Source/WebCore
Revision 166953
Author akl...@apple.com
Date 2014-04-08 13:26:54 -0700 (Tue, 08 Apr 2014)
Log Message
[Mac] Always do a full GC when simulating memory pressure.
To get more consistent accounting on automated memory testers,
add a synchronous GC as part of the simulated memory pressure event.
Reviewed by Geoffrey Garen.
* platform/mac/MemoryPressureHandlerMac.mm:
(WebCore::MemoryPressureHandler::install):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/mac/MemoryPressureHandlerMac.mm
Diff
Modified: trunk/Source/WebCore/ChangeLog (166952 => 166953)
--- trunk/Source/WebCore/ChangeLog 2014-04-08 20:25:34 UTC (rev 166952)
+++ trunk/Source/WebCore/ChangeLog 2014-04-08 20:26:54 UTC (rev 166953)
@@ -1,3 +1,16 @@
+2014-04-08 Andreas Kling
+
+[Mac] Always do a full GC when simulating memory pressure.
+
+
+To get more consistent accounting on automated memory testers,
+add a synchronous GC as part of the simulated memory pressure event.
+
+Reviewed by Geoffrey Garen.
+
+* platform/mac/MemoryPressureHandlerMac.mm:
+(WebCore::MemoryPressureHandler::install):
+
2014-04-08 Jer Noble
Unreviewed iOS build fix. Pass 0 instead of nil to setRate: when pausing.
Modified: trunk/Source/WebCore/platform/mac/MemoryPressureHandlerMac.mm (166952 => 166953)
--- trunk/Source/WebCore/platform/mac/MemoryPressureHandlerMac.mm 2014-04-08 20:25:34 UTC (rev 166952)
+++ trunk/Source/WebCore/platform/mac/MemoryPressureHandlerMac.mm 2014-04-08 20:26:54 UTC (rev 166953)
@@ -29,6 +29,7 @@
#if !PLATFORM(IOS)
#import "IOSurfacePool.h"
+#import "GCController.h"
#import "LayerPool.h"
#import "WebCoreSystemInterface.h"
#import
@@ -70,6 +71,11 @@
// Allow simulation of memory pressure with "notifyutil -p org.WebKit.lowMemory"
notify_register_dispatch("org.WebKit.lowMemory", &_notifyToken, dispatch_get_main_queue(), ^(int) {
+
+// We only do a synchronous GC when *simulating* memory pressure.
+// This gives us a more consistent picture of live objects at the end of testing.
+gcController().garbageCollectNow();
+
memoryPressureHandler().respondToMemoryPressure();
malloc_zone_pressure_relief(nullptr, 0);
});
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [166952] trunk/Source/JavaScriptCore
Title: [166952] trunk/Source/_javascript_Core
Revision 166952
Author fpi...@apple.com
Date 2014-04-08 13:25:34 -0700 (Tue, 08 Apr 2014)
Log Message
Unreviewed, fix a goofy assertion to fix debug.
* bytecode/PolymorphicPutByIdList.h:
(JSC::PutByIdAccess::isSetter):
(JSC::PutByIdAccess::oldStructure):
(JSC::PutByIdAccess::chain):
(JSC::PutByIdAccess::stubRoutine):
(JSC::PutByIdAccess::customSetter):
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/bytecode/PolymorphicPutByIdList.h
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (166951 => 166952)
--- trunk/Source/_javascript_Core/ChangeLog 2014-04-08 20:24:19 UTC (rev 166951)
+++ trunk/Source/_javascript_Core/ChangeLog 2014-04-08 20:25:34 UTC (rev 166952)
@@ -1,5 +1,16 @@
2014-04-08 Filip Pizlo
+Unreviewed, fix a goofy assertion to fix debug.
+
+* bytecode/PolymorphicPutByIdList.h:
+(JSC::PutByIdAccess::isSetter):
+(JSC::PutByIdAccess::oldStructure):
+(JSC::PutByIdAccess::chain):
+(JSC::PutByIdAccess::stubRoutine):
+(JSC::PutByIdAccess::customSetter):
+
+2014-04-08 Filip Pizlo
+
Fail silently if the LLVM dylib isn't found
https://bugs.webkit.org/show_bug.cgi?id=131385
Modified: trunk/Source/_javascript_Core/bytecode/PolymorphicPutByIdList.h (166951 => 166952)
--- trunk/Source/_javascript_Core/bytecode/PolymorphicPutByIdList.h 2014-04-08 20:24:19 UTC (rev 166951)
+++ trunk/Source/_javascript_Core/bytecode/PolymorphicPutByIdList.h 2014-04-08 20:25:34 UTC (rev 166952)
@@ -118,13 +118,14 @@
bool isTransition() const { return m_type == Transition; }
bool isReplace() const { return m_type == Replace; }
+bool isSetter() const { return m_type == Setter; }
bool isCustom() const { return m_type == CustomSetter; }
Structure* oldStructure() const
{
// Using this instead of isSet() to make this assertion robust against the possibility
// of additional access types being added.
-ASSERT(isTransition() || isReplace() || isCustom());
+ASSERT(isTransition() || isReplace() || isSetter() || isCustom());
return m_oldStructure.get();
}
@@ -143,17 +144,21 @@
StructureChain* chain() const
{
-ASSERT(isTransition() || isCustom());
+ASSERT(isTransition() || isSetter() || isCustom());
return m_chain.get();
}
JITStubRoutine* stubRoutine() const
{
-ASSERT(isTransition() || isReplace() || isCustom());
+ASSERT(isTransition() || isReplace() || isSetter() || isCustom());
return m_stubRoutine.get();
}
-PutPropertySlot::PutValueFunc customSetter() const { ASSERT(isCustom()); return m_customSetter; }
+PutPropertySlot::PutValueFunc customSetter() const
+{
+ASSERT(isCustom());
+return m_customSetter;
+}
bool visitWeak(RepatchBuffer&) const;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [166951] trunk/Source/WebCore
Title: [166951] trunk/Source/WebCore Revision 166951 Author jer.no...@apple.com Date 2014-04-08 13:24:19 -0700 (Tue, 08 Apr 2014) Log Message Unreviewed iOS build fix. Pass 0 instead of nil to setRate: when pausing. * platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm: (WebCore::MediaPlayerPrivateAVFoundationObjC::platformPause): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm Diff Modified: trunk/Source/WebCore/ChangeLog (166950 => 166951) --- trunk/Source/WebCore/ChangeLog 2014-04-08 20:05:07 UTC (rev 166950) +++ trunk/Source/WebCore/ChangeLog 2014-04-08 20:24:19 UTC (rev 166951) @@ -1,3 +1,10 @@ +2014-04-08 Jer Noble + +Unreviewed iOS build fix. Pass 0 instead of nil to setRate: when pausing. + +* platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm: +(WebCore::MediaPlayerPrivateAVFoundationObjC::platformPause): + 2014-04-08 Mark Lam Refactor to make JSMainThreadExecState's constructor and destructor private. Modified: trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm (166950 => 166951) --- trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm 2014-04-08 20:05:07 UTC (rev 166950) +++ trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm 2014-04-08 20:24:19 UTC (rev 166951) @@ -917,7 +917,7 @@ setDelayCallbacks(true); m_cachedRate = 0; -[m_avPlayer.get() setRate:nil]; +[m_avPlayer.get() setRate:0]; setDelayCallbacks(false); } ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [166950] trunk
Title: [166950] trunk Revision 166950 Author m...@apple.com Date 2014-04-08 13:05:07 -0700 (Tue, 08 Apr 2014) Log Message Added bmalloc to the WebKit workspace. https://bugs.webkit.org/show_bug.cgi?id=131362 Reviewed by Geoff Garen. * WebKit.xcworkspace/contents.xcworkspacedata: * WebKit.xcworkspace/xcshareddata/xcschemes/All Source (target WebProcess).xcscheme: * WebKit.xcworkspace/xcshareddata/xcschemes/All Source.xcscheme: Modified Paths trunk/ChangeLog trunk/WebKit.xcworkspace/contents.xcworkspacedata trunk/WebKit.xcworkspace/xcshareddata/xcschemes/All Source (target WebProcess).xcscheme trunk/WebKit.xcworkspace/xcshareddata/xcschemes/All Source.xcscheme Diff Modified: trunk/ChangeLog (166949 => 166950) --- trunk/ChangeLog 2014-04-08 20:04:39 UTC (rev 166949) +++ trunk/ChangeLog 2014-04-08 20:05:07 UTC (rev 166950) @@ -1,3 +1,14 @@ +2014-04-08 Dan Bernstein + +Added bmalloc to the WebKit workspace. +https://bugs.webkit.org/show_bug.cgi?id=131362 + +Reviewed by Geoff Garen. + +* WebKit.xcworkspace/contents.xcworkspacedata: +* WebKit.xcworkspace/xcshareddata/xcschemes/All Source (target WebProcess).xcscheme: +* WebKit.xcworkspace/xcshareddata/xcschemes/All Source.xcscheme: + 2014-04-08 Geoffrey Garen Build bmalloc on iOS too Modified: trunk/WebKit.xcworkspace/contents.xcworkspacedata (166949 => 166950) --- trunk/WebKit.xcworkspace/contents.xcworkspacedata 2014-04-08 20:04:39 UTC (rev 166949) +++ trunk/WebKit.xcworkspace/contents.xcworkspacedata 2014-04-08 20:05:07 UTC (rev 166950) @@ -2,6 +2,9 @@ version = "1.0"> + location = "group:Source/bmalloc/bmalloc.xcodeproj"> + + location = "group:Source/WTF/WTF.xcodeproj"> Modified: trunk/WebKit.xcworkspace/xcshareddata/xcschemes/All Source (target WebProcess).xcscheme (166949 => 166950) --- trunk/WebKit.xcworkspace/xcshareddata/xcschemes/All Source (target WebProcess).xcscheme 2014-04-08 20:04:39 UTC (rev 166949) +++ trunk/WebKit.xcworkspace/xcshareddata/xcschemes/All Source (target WebProcess).xcscheme 2014-04-08 20:05:07 UTC (rev 166950) @@ -31,6 +31,20 @@ buildForAnalyzing = "YES"> BuildableIdentifier = "primary" + BlueprintIdentifier = "14F271BD18EA3963008C152F" + BuildableName = "libbmalloc.a" + BlueprintName = "bmalloc" + ReferencedContainer = "container:Source/bmalloc/bmalloc.xcodeproj"> + + + +BlueprintIdentifier = "5D247B6114689B8600E78B76" BuildableName = "libWTF.a" BlueprintName = "WTF" Modified: trunk/WebKit.xcworkspace/xcshareddata/xcschemes/All Source.xcscheme (166949 => 166950) --- trunk/WebKit.xcworkspace/xcshareddata/xcschemes/All Source.xcscheme 2014-04-08 20:04:39 UTC (rev 166949) +++ trunk/WebKit.xcworkspace/xcshareddata/xcschemes/All Source.xcscheme 2014-04-08 20:05:07 UTC (rev 166950) @@ -31,6 +31,20 @@ buildForAnalyzing = "YES"> BuildableIdentifier = "primary" + BlueprintIdentifier = "14F271BD18EA3963008C152F" + BuildableName = "libbmalloc.a" + BlueprintName = "bmalloc" + ReferencedContainer = "container:Source/bmalloc/bmalloc.xcodeproj"> + + + +BlueprintIdentifier = "5D247B6114689B8600E78B76" BuildableName = "libWTF.a" BlueprintName = "WTF" ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [166949] trunk/LayoutTests
Title: [166949] trunk/LayoutTests
Revision 166949
Author commit-qu...@webkit.org
Date 2014-04-08 13:04:39 -0700 (Tue, 08 Apr 2014)
Log Message
[GTK] Unreviewed GTK gardening.
Update text expectations for failing tests:
accessibility/children-changed-sends-notification.html
accessibility/notification-listeners.html
fast/repaint/blend-mode-isolate-stacking-context.html
fast/repaint/hidpi-absolute-positioned-element-wrong-cliprect-after-move.html
Rebaseline fast/multicol/client-rects-expected.txt after r165991
Patch by Carlos Alberto Lopez Perez on 2014-04-08
* platform/gtk/TestExpectations:
* platform/gtk/fast/multicol/client-rects-expected.txt:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/gtk/TestExpectations
trunk/LayoutTests/platform/gtk/fast/multicol/client-rects-expected.txt
Diff
Modified: trunk/LayoutTests/ChangeLog (166948 => 166949)
--- trunk/LayoutTests/ChangeLog 2014-04-08 20:03:41 UTC (rev 166948)
+++ trunk/LayoutTests/ChangeLog 2014-04-08 20:04:39 UTC (rev 166949)
@@ -1,3 +1,18 @@
+2014-04-08 Carlos Alberto Lopez Perez
+
+[GTK] Unreviewed GTK gardening.
+
+Update text expectations for failing tests:
+ accessibility/children-changed-sends-notification.html
+ accessibility/notification-listeners.html
+ fast/repaint/blend-mode-isolate-stacking-context.html
+ fast/repaint/hidpi-absolute-positioned-element-wrong-cliprect-after-move.html
+
+Rebaseline fast/multicol/client-rects-expected.txt after r165991
+
+* platform/gtk/TestExpectations:
+* platform/gtk/fast/multicol/client-rects-expected.txt:
+
2014-04-07 Filip Pizlo
Repatch should support setters and plant calls to them directly
Modified: trunk/LayoutTests/platform/gtk/TestExpectations (166948 => 166949)
--- trunk/LayoutTests/platform/gtk/TestExpectations 2014-04-08 20:03:41 UTC (rev 166948)
+++ trunk/LayoutTests/platform/gtk/TestExpectations 2014-04-08 20:04:39 UTC (rev 166949)
@@ -406,7 +406,7 @@
webkit.org/b/131347 fast/backgrounds/hidpi-bitmap-background-repeat-on-subpixel-position.html [ ImageOnlyFailure ]
webkit.org/b/131347 fast/borders/hidpi-simple-hairline-border-painting.html [ ImageOnlyFailure ]
webkit.org/b/131347 fast/layers/hidpi-box-positioned-off-by-one-when-transform-is-present.html [ ImageOnlyFailure ]
-webkit.org/b/131347 fast/repaint/hidpi-absolute-positioned-element-wrong-cliprect-after-move.html [ ImageOnlyFailure ]
+webkit.org/b/131347 fast/repaint/hidpi-absolute-positioned-element-wrong-cliprect-after-move.html [ Failure ]
webkit.org/b/131347 fast/repaint/hidpi-device-pixel-based-repaint-rect-tracking.html [ Failure ]
webkit.org/b/131347 svg/custom/hidpi-masking-clipping.svg [ Failure ]
@@ -1066,6 +1066,9 @@
webkit.org/b/106340 accessibility/img-fallsback-to-title.html [ Failure ]
+webkit.org/b/131380 accessibility/children-changed-sends-notification.html [ Failure ]
+webkit.org/b/131380 accessibility/notification-listeners.html [ Failure ]
+
# svg/ failures
webkit.org/b/42457 svg/custom/embedded-svg-allowed-in-dashboard.xml [ Failure ]
webkit.org/b/42457 svg/custom/manually-parsed-embedded-svg-allowed-in-dashboard.html [ Failure ]
@@ -1829,6 +1832,8 @@
# Test globally skipped, passing on GTK port
webkit.org/b/124349 fast/hidpi/image-srcset-relative-svg-canvas.html [ Pass ]
+webkit.org/b/131377 fast/repaint/blend-mode-isolate-stacking-context.html [ Failure Timeout ]
+
#
# End of Tests failing
#
Modified: trunk/LayoutTests/platform/gtk/fast/multicol/client-rects-expected.txt (166948 => 166949)
--- trunk/LayoutTests/platform/gtk/fast/multicol/client-rects-expected.txt 2014-04-08 20:03:41 UTC (rev 166948)
+++ trunk/LayoutTests/platform/gtk/fast/multicol/client-rects-expected.txt 2014-04-08 20:04:39 UTC (rev 166949)
@@ -1,9 +1,9 @@
-layer at (0,0) size 785x693
- RenderView at (0,0) size 785x600
-layer at (0,0) size 785x693
- RenderBlock {HTML} at (0,0) size 785x693
-RenderBody {BODY} at (8,8) size 769x675
- RenderBlock {P} at (0,0) size 769x28
+layer at (0,0) size 800x600
+ RenderView at (0,0) size 800x600
+layer at (0,0) size 800x600
+ RenderBlock {HTML} at (0,0) size 800x600
+RenderBody {BODY} at (8,8) size 784x584
+ RenderBlock {P} at (0,0) size 784x28
RenderText {#text} at (0,11) size 421x17
text run at (0,11) width 421: "The blue borders should coincide with light blue squares, like this: "
RenderBlock {SPAN} at (421,0) size 25x25 [bgcolor=#ADD8E6] [border: (3px solid #FF7F)]
@@ -17,88 +17,290 @@
RenderBlock {SPAN} at (718,0) size 25x25 [border: (3px solid #FF7F)]
RenderText {#text} at (743,11) size 4x17
text run at (743,11) width 4: "."
- RenderBlock {P} at (0,566) size 769x17
-
[webkit-changes] [166948] trunk/Source/JavaScriptCore
Title: [166948] trunk/Source/_javascript_Core
Revision 166948
Author fpi...@apple.com
Date 2014-04-08 13:03:41 -0700 (Tue, 08 Apr 2014)
Log Message
Fail silently if the LLVM dylib isn't found
https://bugs.webkit.org/show_bug.cgi?id=131385
Reviewed by Mark Hahnenberg.
* dfg/DFGPlan.cpp:
(JSC::DFG::Plan::compileInThreadImpl):
* llvm/InitializeLLVM.cpp:
(JSC::initializeLLVM):
* llvm/InitializeLLVM.h:
* llvm/InitializeLLVMPOSIX.cpp:
(JSC::initializeLLVMPOSIX):
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/dfg/DFGPlan.cpp
trunk/Source/_javascript_Core/llvm/InitializeLLVM.cpp
trunk/Source/_javascript_Core/llvm/InitializeLLVM.h
trunk/Source/_javascript_Core/llvm/InitializeLLVMPOSIX.cpp
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (166947 => 166948)
--- trunk/Source/_javascript_Core/ChangeLog 2014-04-08 19:48:42 UTC (rev 166947)
+++ trunk/Source/_javascript_Core/ChangeLog 2014-04-08 20:03:41 UTC (rev 166948)
@@ -1,3 +1,18 @@
+2014-04-08 Filip Pizlo
+
+Fail silently if the LLVM dylib isn't found
+https://bugs.webkit.org/show_bug.cgi?id=131385
+
+Reviewed by Mark Hahnenberg.
+
+* dfg/DFGPlan.cpp:
+(JSC::DFG::Plan::compileInThreadImpl):
+* llvm/InitializeLLVM.cpp:
+(JSC::initializeLLVM):
+* llvm/InitializeLLVM.h:
+* llvm/InitializeLLVMPOSIX.cpp:
+(JSC::initializeLLVMPOSIX):
+
2014-04-07 Filip Pizlo
Repatch should support setters and plant calls to them directly
Modified: trunk/Source/_javascript_Core/dfg/DFGPlan.cpp (166947 => 166948)
--- trunk/Source/_javascript_Core/dfg/DFGPlan.cpp 2014-04-08 19:48:42 UTC (rev 166947)
+++ trunk/Source/_javascript_Core/dfg/DFGPlan.cpp 2014-04-08 20:03:41 UTC (rev 166948)
@@ -321,10 +321,16 @@
dumpAndVerifyGraph(dfg, "Graph just before FTL lowering:");
+bool haveLLVM;
{
GraphSafepoint safepoint(dfg);
-initializeLLVM();
+haveLLVM = initializeLLVM();
}
+
+if (!haveLLVM) {
+finalizer = adoptPtr(new FailedFinalizer(*this));
+return FailPath;
+}
FTL::State state(dfg);
FTL::lowerDFGToLLVM(state);
Modified: trunk/Source/_javascript_Core/llvm/InitializeLLVM.cpp (166947 => 166948)
--- trunk/Source/_javascript_Core/llvm/InitializeLLVM.cpp 2014-04-08 19:48:42 UTC (rev 166947)
+++ trunk/Source/_javascript_Core/llvm/InitializeLLVM.cpp 2014-04-08 20:03:41 UTC (rev 166948)
@@ -1,5 +1,5 @@
/*
- * Copyright (C) 2013 Apple Inc. All rights reserved.
+ * Copyright (C) 2013, 2014 Apple Inc. All rights reserved.
*
* Redistribution and use in source and binary forms, with or without
* modification, are permitted provided that the following conditions
@@ -35,9 +35,10 @@
static pthread_once_t initializeLLVMOnceKey = PTHREAD_ONCE_INIT;
-void initializeLLVM()
+bool initializeLLVM()
{
pthread_once(&initializeLLVMOnceKey, initializeLLVMImpl);
+return !!llvm;
}
} // namespace JSC
Modified: trunk/Source/_javascript_Core/llvm/InitializeLLVM.h (166947 => 166948)
--- trunk/Source/_javascript_Core/llvm/InitializeLLVM.h 2014-04-08 19:48:42 UTC (rev 166947)
+++ trunk/Source/_javascript_Core/llvm/InitializeLLVM.h 2014-04-08 20:03:41 UTC (rev 166948)
@@ -1,5 +1,5 @@
/*
- * Copyright (C) 2013 Apple Inc. All rights reserved.
+ * Copyright (C) 2013, 2014 Apple Inc. All rights reserved.
*
* Redistribution and use in source and binary forms, with or without
* modification, are permitted provided that the following conditions
@@ -32,7 +32,9 @@
void initializeLLVMImpl();
-void initializeLLVM(); // It's safe to call this multiple times.
+// You msut call this before using JSC::llvm. It's safe to call this multiple times.
+// Returns true if we successfully loaded LLVM. Returns false if we didn't.
+bool initializeLLVM();
} // namespace JSC
Modified: trunk/Source/_javascript_Core/llvm/InitializeLLVMPOSIX.cpp (166947 => 166948)
--- trunk/Source/_javascript_Core/llvm/InitializeLLVMPOSIX.cpp 2014-04-08 19:48:42 UTC (rev 166947)
+++ trunk/Source/_javascript_Core/llvm/InitializeLLVMPOSIX.cpp 2014-04-08 20:03:41 UTC (rev 166948)
@@ -1,5 +1,5 @@
/*
- * Copyright (C) 2013 Apple Inc. All rights reserved.
+ * Copyright (C) 2013, 2014 Apple Inc. All rights reserved.
*
* Redistribution and use in source and binary forms, with or without
* modification, are permitted provided that the following conditions
@@ -29,7 +29,9 @@
#if HAVE(LLVM)
#include "LLVMAPI.h"
+#include "Options.h"
#include
+#include
namespace JSC {
@@ -37,14 +39,34 @@
void initializeLLVMPOSIX(const char* libraryName)
{
+const bool verbose =
+Options::verboseFTLCompilation()
+|| Options::showFTLDisassembly()
+|| Options::verboseFTLFailure()
+|| Options::verboseCompilation()
+|| Options::showDFGDisassembly()
+|| Options:
[webkit-changes] [166947] trunk
Title: [166947] trunk
Revision 166947
Author gga...@apple.com
Date 2014-04-08 12:48:42 -0700 (Tue, 08 Apr 2014)
Log Message
Build bmalloc on iOS too
https://bugs.webkit.org/show_bug.cgi?id=131381
Reviewed by Andreas Kling.
.:
* Source/Makefile: Build it.
Tools:
* Scripts/build-webkit:
Modified Paths
trunk/ChangeLog
trunk/Source/Makefile
trunk/Tools/ChangeLog
trunk/Tools/Scripts/build-webkit
Diff
Modified: trunk/ChangeLog (166946 => 166947)
--- trunk/ChangeLog 2014-04-08 19:42:08 UTC (rev 166946)
+++ trunk/ChangeLog 2014-04-08 19:48:42 UTC (rev 166947)
@@ -1,3 +1,12 @@
+2014-04-08 Geoffrey Garen
+
+Build bmalloc on iOS too
+https://bugs.webkit.org/show_bug.cgi?id=131381
+
+Reviewed by Andreas Kling.
+
+* Source/Makefile: Build it.
+
2014-04-07 Geoffrey Garen
Build bmalloc on Mac
Modified: trunk/Source/Makefile (166946 => 166947)
--- trunk/Source/Makefile 2014-04-08 19:42:08 UTC (rev 166946)
+++ trunk/Source/Makefile 2014-04-08 19:48:42 UTC (rev 166947)
@@ -1,9 +1,9 @@
MODULES = bmalloc WTF _javascript_Core ThirdParty/ANGLE WebCore WebInspectorUI WebKit2 WebKit
ifneq (,$(findstring iphoneos,$(SDKROOT)))
- MODULES = WTF _javascript_Core ThirdParty/ANGLE WebCore WebKit WebKit2
+ MODULES = bmalloc WTF _javascript_Core ThirdParty/ANGLE WebCore WebKit WebKit2
else ifneq (,$(findstring iphonesimulator,$(SDKROOT)))
- MODULES = WTF _javascript_Core ThirdParty/ANGLE WebCore WebKit WebKit2
+ MODULES = bmalloc WTF _javascript_Core ThirdParty/ANGLE WebCore WebKit WebKit2
endif
all:
Modified: trunk/Tools/ChangeLog (166946 => 166947)
--- trunk/Tools/ChangeLog 2014-04-08 19:42:08 UTC (rev 166946)
+++ trunk/Tools/ChangeLog 2014-04-08 19:48:42 UTC (rev 166947)
@@ -1,3 +1,12 @@
+2014-04-08 Geoffrey Garen
+
+Build bmalloc on iOS too
+https://bugs.webkit.org/show_bug.cgi?id=131381
+
+Reviewed by Andreas Kling.
+
+* Scripts/build-webkit:
+
2014-04-08 Brent Fulgham
Unreviewed gardening: Prevent users from attempting
Modified: trunk/Tools/Scripts/build-webkit (166946 => 166947)
--- trunk/Tools/Scripts/build-webkit 2014-04-08 19:42:08 UTC (rev 166946)
+++ trunk/Tools/Scripts/build-webkit 2014-04-08 19:48:42 UTC (rev 166947)
@@ -165,7 +165,7 @@
# Build WTF as a separate static library on ports which support it.
splice @projects, 0, 0, "Source/WTF" if isAppleMacWebKit() or isAppleWinWebKit() or isWinCairo();
-splice @projects, 0, 0, "Source/bmalloc" if isAppleMacWebKit() && !isIOSWebKit();
+splice @projects, 0, 0, "Source/bmalloc" if isAppleMacWebKit();
for my $dir (@projects) {
if (! -d $dir) {
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [166946] trunk/Source/WebKit2
Title: [166946] trunk/Source/WebKit2
Revision 166946
Author a...@apple.com
Date 2014-04-08 12:42:08 -0700 (Tue, 08 Apr 2014)
Log Message
FlagsChanged events are not delivered to input methods when using async text input
https://bugs.webkit.org/show_bug.cgi?id=131383
Reviewed by Anders Carlsson.
* UIProcess/API/mac/WKView.mm: (-[WKView _interpretKeyEvent:completionHandler:]):
The early return is no longer needed.
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/mac/WKView.mm
Diff
Modified: trunk/Source/WebKit2/ChangeLog (166945 => 166946)
--- trunk/Source/WebKit2/ChangeLog 2014-04-08 19:39:55 UTC (rev 166945)
+++ trunk/Source/WebKit2/ChangeLog 2014-04-08 19:42:08 UTC (rev 166946)
@@ -1,3 +1,13 @@
+2014-04-08 Alexey Proskuryakov
+
+FlagsChanged events are not delivered to input methods when using async text input
+https://bugs.webkit.org/show_bug.cgi?id=131383
+
+Reviewed by Anders Carlsson.
+
+* UIProcess/API/mac/WKView.mm: (-[WKView _interpretKeyEvent:completionHandler:]):
+The early return is no longer needed.
+
2014-04-08 Tim Horton
WebKit2 View Gestures (Swipe): Swipe-start hysteresis
Modified: trunk/Source/WebKit2/UIProcess/API/mac/WKView.mm (166945 => 166946)
--- trunk/Source/WebKit2/UIProcess/API/mac/WKView.mm 2014-04-08 19:39:55 UTC (rev 166945)
+++ trunk/Source/WebKit2/UIProcess/API/mac/WKView.mm 2014-04-08 19:42:08 UTC (rev 166946)
@@ -1349,10 +1349,6 @@
return;
}
-// FIXME: Remove the special case for NSFlagsChanged once is fixed.
-if ([event type] == NSFlagsChanged)
-return;
-
LOG(TextInput, "-> handleEventByInputMethod:%p %@", event, event);
[[self inputContext] handleEventByInputMethod:event completionHandler:^(BOOL handled) {
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [166945] trunk
Title: [166945] trunk
Revision 166945
Author fpi...@apple.com
Date 2014-04-08 12:39:55 -0700 (Tue, 08 Apr 2014)
Log Message
Repatch should support setters and plant calls to them directly
https://bugs.webkit.org/show_bug.cgi?id=130750
Source/_javascript_Core:
Reviewed by Geoffrey Garen.
All of the infrastructure was in place so this just enables setter optimization.
This is a 12x speed-up on setter microbenchmarks. This is a 1% speed-up on Octane.
* bytecode/PolymorphicPutByIdList.cpp:
(JSC::PutByIdAccess::visitWeak):
* bytecode/PolymorphicPutByIdList.h:
(JSC::PutByIdAccess::setter):
(JSC::PutByIdAccess::customSetter): Deleted.
* bytecode/PutByIdStatus.cpp:
(JSC::PutByIdStatus::computeForStubInfo):
* jit/Repatch.cpp:
(JSC::toString):
(JSC::kindFor):
(JSC::customFor):
(JSC::generateByIdStub):
(JSC::tryCachePutByID):
(JSC::tryBuildPutByIdList):
* runtime/JSObject.cpp:
(JSC::JSObject::put):
* runtime/Lookup.h:
(JSC::putEntry):
* runtime/PutPropertySlot.h:
(JSC::PutPropertySlot::setCacheableSetter):
(JSC::PutPropertySlot::isCacheableSetter):
(JSC::PutPropertySlot::isCacheableCustom):
(JSC::PutPropertySlot::setCacheableCustomProperty): Deleted.
(JSC::PutPropertySlot::isCacheableCustomProperty): Deleted.
* tests/stress/setter.js: Added.
(foo):
LayoutTests:
Reviewed by Geoffrey Garen.
* js/regress/script-tests/setter.js: Added.
* js/regress/setter-expected.txt: Added.
* js/regress/setter.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/bytecode/PolymorphicPutByIdList.cpp
trunk/Source/_javascript_Core/bytecode/PolymorphicPutByIdList.h
trunk/Source/_javascript_Core/bytecode/PutByIdStatus.cpp
trunk/Source/_javascript_Core/jit/Repatch.cpp
trunk/Source/_javascript_Core/runtime/JSObject.cpp
trunk/Source/_javascript_Core/runtime/Lookup.h
trunk/Source/_javascript_Core/runtime/PutPropertySlot.h
Added Paths
trunk/LayoutTests/js/regress/script-tests/setter.js
trunk/LayoutTests/js/regress/setter-expected.txt
trunk/LayoutTests/js/regress/setter.html
trunk/Source/_javascript_Core/tests/stress/setter.js
Diff
Modified: trunk/LayoutTests/ChangeLog (166944 => 166945)
--- trunk/LayoutTests/ChangeLog 2014-04-08 19:26:17 UTC (rev 166944)
+++ trunk/LayoutTests/ChangeLog 2014-04-08 19:39:55 UTC (rev 166945)
@@ -1,3 +1,14 @@
+2014-04-07 Filip Pizlo
+
+Repatch should support setters and plant calls to them directly
+https://bugs.webkit.org/show_bug.cgi?id=130750
+
+Reviewed by Geoffrey Garen.
+
+* js/regress/script-tests/setter.js: Added.
+* js/regress/setter-expected.txt: Added.
+* js/regress/setter.html: Added.
+
2014-04-08 Morten Stenshorne
[New Multicolumn] Child top margin sometimes ignored for column balancing
Added: trunk/LayoutTests/js/regress/script-tests/setter.js (0 => 166945)
--- trunk/LayoutTests/js/regress/script-tests/setter.js (rev 0)
+++ trunk/LayoutTests/js/regress/script-tests/setter.js 2014-04-08 19:39:55 UTC (rev 166945)
@@ -0,0 +1,10 @@
+(function() {
+var o = {_f:42};
+o.__defineSetter__("f", function(value) { this._f = value; });
+var n = 200;
+for (var i = 0; i < n; ++i)
+o.f = i;
+if (o._f != n - 1)
+throw "Error: bad result: " + o._f;
+})();
+
Added: trunk/LayoutTests/js/regress/setter-expected.txt (0 => 166945)
--- trunk/LayoutTests/js/regress/setter-expected.txt (rev 0)
+++ trunk/LayoutTests/js/regress/setter-expected.txt 2014-04-08 19:39:55 UTC (rev 166945)
@@ -0,0 +1,10 @@
+JSRegress/setter
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+PASS no exception thrown
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
Added: trunk/LayoutTests/js/regress/setter.html (0 => 166945)
--- trunk/LayoutTests/js/regress/setter.html (rev 0)
+++ trunk/LayoutTests/js/regress/setter.html 2014-04-08 19:39:55 UTC (rev 166945)
@@ -0,0 +1,12 @@
+
+
+
+
[webkit-changes] [166944] trunk/Source/bmalloc
Title: [166944] trunk/Source/bmalloc
Revision 166944
Author gga...@apple.com
Date 2014-04-08 12:26:17 -0700 (Tue, 08 Apr 2014)
Log Message
2014-04-08 Geoffrey Garen
Removed an unused file.
Unreviewed.
* bmalloc/AsyncTask.cpp: Removed.
Modified Paths
trunk/Source/bmalloc/ChangeLog
Removed Paths
trunk/Source/bmalloc/bmalloc/AsyncTask.cpp
Diff
Modified: trunk/Source/bmalloc/ChangeLog (166943 => 166944)
--- trunk/Source/bmalloc/ChangeLog 2014-04-08 19:12:37 UTC (rev 166943)
+++ trunk/Source/bmalloc/ChangeLog 2014-04-08 19:26:17 UTC (rev 166944)
@@ -1,3 +1,11 @@
+2014-04-08 Geoffrey Garen
+
+Removed an unused file.
+
+Unreviewed.
+
+* bmalloc/AsyncTask.cpp: Removed.
+
2014-04-07 Geoffrey Garen
Build bmalloc on Mac
Deleted: trunk/Source/bmalloc/bmalloc/AsyncTask.cpp (166943 => 166944)
--- trunk/Source/bmalloc/bmalloc/AsyncTask.cpp 2014-04-08 19:12:37 UTC (rev 166943)
+++ trunk/Source/bmalloc/bmalloc/AsyncTask.cpp 2014-04-08 19:26:17 UTC (rev 166944)
@@ -1,55 +0,0 @@
-#include "AsyncTask.h"
-#include "NoInline.h"
-
-namespace bmalloc {
-
-template
-NO_INLINE void AsyncTask::runSlowCase()
-{
-State oldState = m_state.exchange(Signaled);
-if (oldState == Signaled || oldState == Running)
-return;
-
-if (oldState == Sleeping) {
-m_condition.notify_one();
-return;
-}
-
-ASSERT(oldState == Exited);
-pthread_create(&m_thread, nullptr, &pthreadEntryPoint, this);
-pthread_detach(m_thread);
-}
-
-template
-void* AsyncTask::pthreadEntryPoint(void* asyncTask)
-{
-static_cast(asyncTask)->entryPoint();
-return nullptr;
-}
-
-template
-void AsyncTask::entryPoint()
-{
-State expectedState;
-while (1) {
-expectedState = Signaled;
-if (m_state.compare_exchange_weak(expectedState, Running)) {
-m_function();
-continue;
-}
-
-expectedState = Running;
-if (m_state.compare_exchange_weak(expectedState, Sleeping)) {
-std::mutex dummy; // No need for a real mutex because there's only one waiting thread.
-std::unique_lock lock(dummy);
-m_condition.wait_for(lock, std::chrono::milliseconds(2), [=]() { return this->m_state != Sleeping; });
-continue;
-}
-
-expectedState = Sleeping;
-if (m_state.compare_exchange_weak(expectedState, Exited))
-break;
-}
-}
-
-} // namespace bmalloc
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [166943] trunk/Source/WebCore
Title: [166943] trunk/Source/WebCore
Revision 166943
Author mark@apple.com
Date 2014-04-08 12:12:37 -0700 (Tue, 08 Apr 2014)
Log Message
Refactor to make JSMainThreadExecState's constructor and destructor private.
Reviewed by Mark Hahnenberg.
This is in preparation for subsequent patches to ensure that we don't
exit the VM with an exception still pending.
No new tests required. This is only a refactor of existing behavior.
* bindings/js/JSDOMGlobalObjectTask.cpp:
* bindings/js/JSMainThreadExecState.h:
(WebCore::JSMainThreadExecState::runTask):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/js/JSDOMGlobalObjectTask.cpp
trunk/Source/WebCore/bindings/js/JSMainThreadExecState.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (166942 => 166943)
--- trunk/Source/WebCore/ChangeLog 2014-04-08 19:07:06 UTC (rev 166942)
+++ trunk/Source/WebCore/ChangeLog 2014-04-08 19:12:37 UTC (rev 166943)
@@ -1,3 +1,19 @@
+2014-04-08 Mark Lam
+
+Refactor to make JSMainThreadExecState's constructor and destructor private.
+
+
+Reviewed by Mark Hahnenberg.
+
+This is in preparation for subsequent patches to ensure that we don't
+exit the VM with an exception still pending.
+
+No new tests required. This is only a refactor of existing behavior.
+
+* bindings/js/JSDOMGlobalObjectTask.cpp:
+* bindings/js/JSMainThreadExecState.h:
+(WebCore::JSMainThreadExecState::runTask):
+
2014-04-07 Jer Noble
[WK2][iOS] Consecutive videos in full screen display only black
Modified: trunk/Source/WebCore/bindings/js/JSDOMGlobalObjectTask.cpp (166942 => 166943)
--- trunk/Source/WebCore/bindings/js/JSDOMGlobalObjectTask.cpp 2014-04-08 19:07:06 UTC (rev 166942)
+++ trunk/Source/WebCore/bindings/js/JSDOMGlobalObjectTask.cpp 2014-04-08 19:12:37 UTC (rev 166943)
@@ -60,11 +60,10 @@
// When on the main thread (e.g. the document's thread), we need to make sure to
// push the current ExecState on to the JSMainThreadExecState stack.
-if (context->isDocument()) {
-JSMainThreadExecState currentState(exec);
+if (context->isDocument())
+JSMainThreadExecState::runTask(exec, *m_task.get());
+else
m_task->run(exec);
-} else
-m_task->run(exec);
}
private:
Modified: trunk/Source/WebCore/bindings/js/JSMainThreadExecState.h (166942 => 166943)
--- trunk/Source/WebCore/bindings/js/JSMainThreadExecState.h 2014-04-08 19:07:06 UTC (rev 166942)
+++ trunk/Source/WebCore/bindings/js/JSMainThreadExecState.h 2014-04-08 19:12:37 UTC (rev 166943)
@@ -28,6 +28,7 @@
#include "JSDOMBinding.h"
#include
+#include
#include
#if PLATFORM(IOS)
@@ -62,8 +63,15 @@
return JSC::evaluate(exec, source, thisValue, exception);
};
+static void runTask(JSC::ExecState* exec, JSC::Microtask& task)
+{
+JSMainThreadExecState currentState(exec);
+task.run(exec);
+}
+
static InspectorInstrumentationCookie instrumentFunctionCall(ScriptExecutionContext*, JSC::CallType, const JSC::CallData&);
+private:
explicit JSMainThreadExecState(JSC::ExecState* exec)
: m_previousState(s_mainThreadState)
{
@@ -83,7 +91,6 @@
didLeaveScriptContext();
}
-private:
static JSC::ExecState* s_mainThreadState;
JSC::ExecState* m_previousState;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [166942] trunk/Source/WebInspectorUI
Title: [166942] trunk/Source/WebInspectorUI
Revision 166942
Author timo...@apple.com
Date 2014-04-08 12:07:06 -0700 (Tue, 08 Apr 2014)
Log Message
Clean up old protocol JSON files to better match the latest
https://bugs.webkit.org/show_bug.cgi?id=131308
Reviewed by Joseph Pecoraro.
* Versions/Inspector-iOS-6.0.json:
* Versions/Inspector-iOS-7.0.json:
Modified Paths
trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/Versions/Inspector-iOS-6.0.json
trunk/Source/WebInspectorUI/Versions/Inspector-iOS-7.0.json
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (166941 => 166942)
--- trunk/Source/WebInspectorUI/ChangeLog 2014-04-08 19:00:26 UTC (rev 166941)
+++ trunk/Source/WebInspectorUI/ChangeLog 2014-04-08 19:07:06 UTC (rev 166942)
@@ -1,3 +1,13 @@
+2014-04-08 Timothy Hatcher
+
+Clean up old protocol JSON files to better match the latest
+https://bugs.webkit.org/show_bug.cgi?id=131308
+
+Reviewed by Joseph Pecoraro.
+
+* Versions/Inspector-iOS-6.0.json:
+* Versions/Inspector-iOS-7.0.json:
+
2014-04-05 Brian J. Burg
Enable WEB_REPLAY for PLATFORM(MAC)
Modified: trunk/Source/WebInspectorUI/Versions/Inspector-iOS-6.0.json (166941 => 166942)
--- trunk/Source/WebInspectorUI/Versions/Inspector-iOS-6.0.json 2014-04-08 19:00:26 UTC (rev 166941)
+++ trunk/Source/WebInspectorUI/Versions/Inspector-iOS-6.0.json 2014-04-08 19:07:06 UTC (rev 166942)
@@ -1,8 +1,6 @@
{
-"version": { "major": "1", "minor": "0" },
"domains": [{
"domain": "Inspector",
-"hidden": true,
"types": [],
"commands": [
{
@@ -67,8 +65,7 @@
{ "name": "url", "type": "string", "description": "Frame document's URL." },
{ "name": "securityOrigin", "type": "string", "optional": true, "description": "Frame document's security origin." },
{ "name": "mimeType", "type": "string", "description": "Frame document's mimeType as determined by the browser." }
-],
-"hidden": true
+]
},
{
"id": "FrameResourceTree",
@@ -90,8 +87,7 @@
},
"description": "Information about frame resources."
}
-],
-"hidden": true
+]
},
{
"id": "SearchMatch",
@@ -100,8 +96,7 @@
"properties": [
{ "name": "lineNumber", "type": "number", "description": "Line number in resource content." },
{ "name": "lineContent", "type": "string", "description": "Line with match content." }
-],
-"hidden": true
+]
},
{
"id": "SearchResult",
@@ -111,8 +106,7 @@
{ "name": "url", "type": "string", "description": "Resource URL." },
{ "name": "frameId", "$ref": "Network.FrameId", "description": "Resource frame id." },
{ "name": "matchesCount", "type": "number", "description": "Number of matches in the resource content." }
-],
-"hidden": true
+]
},
{
"id": "Cookie",
@@ -128,14 +122,12 @@
{ "name": "httpOnly", "type": "boolean", "description": "True if cookie is http-only." },
{ "name": "secure", "type": "boolean", "description": "True if cookie is secure." },
{ "name": "session", "type": "boolean", "description": "True in case of session cookie." }
-],
-"hidden": true
+]
},
{
"id": "ScriptIdentifier",
"type": "string",
-"description": "Unique script identifier.",
-"hidden": true
+"description": "Unique script identifier."
}
],
"commands": [
@@ -154,15 +146,13 @@
],
"returns": [
{ "name": "identifier", "$ref": "ScriptIdentifier", "description": "Identifier of the added script." }
-],
-"hidden": true
+]
},
{
"name": "removeScriptToEvaluateOnLoad",
"parameters": [
{ "name": "identifier", "$ref": "ScriptIdentifier" }
-],
-"hidden": true
+]
},
{
"name": "reload",
@@ -185,8 +175,7 @@
{ "name": "cookies", "type": "array", "items": { "$ref": "Cookie"}, "description": "Array of cookie objects." },
{ "name": "cookiesString", "type": "string", "description": "document.cookie string representation of the cookies."
[webkit-changes] [166941] trunk/Source/WebKit2
Title: [166941] trunk/Source/WebKit2
Revision 166941
Author timothy_hor...@apple.com
Date 2014-04-08 12:00:26 -0700 (Tue, 08 Apr 2014)
Log Message
WebKit2 View Gestures (Swipe): Swipe-start hysteresis
https://bugs.webkit.org/show_bug.cgi?id=127393
Reviewed by Anders Carlsson.
We shouldn't start a swipe immediately upon very small scrolls in the correct direction,
because we don't want to get the user trapped in a swipe when they want to scroll.
We'll accumulate the scroll deltas and wait until the user has scrolled at least 15px horizontally.
In addition, we'll drop the swipe completely if any event has a vertical delta equal to half (or more)
of the horizontal delta.
* UIProcess/mac/ViewGestureController.h:
* UIProcess/mac/ViewGestureControllerMac.mm:
(WebKit::ViewGestureController::ViewGestureController):
(WebKit::ViewGestureController::deltaIsSufficientToBeginSwipe):
(WebKit::ViewGestureController::handleScrollWheelEvent):
(WebKit::ViewGestureController::wheelEventWasNotHandledByWebCore):
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/mac/ViewGestureController.h
trunk/Source/WebKit2/UIProcess/mac/ViewGestureControllerMac.mm
Diff
Modified: trunk/Source/WebKit2/ChangeLog (166940 => 166941)
--- trunk/Source/WebKit2/ChangeLog 2014-04-08 18:26:51 UTC (rev 166940)
+++ trunk/Source/WebKit2/ChangeLog 2014-04-08 19:00:26 UTC (rev 166941)
@@ -1,3 +1,25 @@
+2014-04-08 Tim Horton
+
+WebKit2 View Gestures (Swipe): Swipe-start hysteresis
+https://bugs.webkit.org/show_bug.cgi?id=127393
+
+
+Reviewed by Anders Carlsson.
+
+We shouldn't start a swipe immediately upon very small scrolls in the correct direction,
+because we don't want to get the user trapped in a swipe when they want to scroll.
+
+We'll accumulate the scroll deltas and wait until the user has scrolled at least 15px horizontally.
+In addition, we'll drop the swipe completely if any event has a vertical delta equal to half (or more)
+of the horizontal delta.
+
+* UIProcess/mac/ViewGestureController.h:
+* UIProcess/mac/ViewGestureControllerMac.mm:
+(WebKit::ViewGestureController::ViewGestureController):
+(WebKit::ViewGestureController::deltaIsSufficientToBeginSwipe):
+(WebKit::ViewGestureController::handleScrollWheelEvent):
+(WebKit::ViewGestureController::wheelEventWasNotHandledByWebCore):
+
2014-04-07 Jer Noble
[Mac][WK2] Videos do not have access to session cookies
Modified: trunk/Source/WebKit2/UIProcess/mac/ViewGestureController.h (166940 => 166941)
--- trunk/Source/WebKit2/UIProcess/mac/ViewGestureController.h 2014-04-08 18:26:51 UTC (rev 166940)
+++ trunk/Source/WebKit2/UIProcess/mac/ViewGestureController.h 2014-04-08 19:00:26 UTC (rev 166941)
@@ -60,7 +60,7 @@
enum class ViewGestureType {
None,
-#if !PLATFORM(IOS)
+#if PLATFORM(MAC)
Magnification,
SmartMagnification,
#endif
@@ -76,8 +76,14 @@
Left,
Right
};
+
+enum class PendingSwipeReason {
+None,
+WebCoreMayScroll,
+InsufficientMagnitude
+};
-#if !PLATFORM(IOS)
+#if PLATFORM(MAC)
double magnification() const;
void handleMagnificationGesture(double scale, WebCore::FloatPoint origin);
@@ -105,7 +111,7 @@
void removeSwipeSnapshot();
void swipeSnapshotWatchdogTimerFired(WebCore::Timer*);
-#if !PLATFORM(IOS)
+#if PLATFORM(MAC)
// Message handlers.
void didCollectGeometryForMagnificationGesture(WebCore::FloatRect visibleContentBounds, bool frameHandlesMagnificationGesture);
void didCollectGeometryForSmartMagnificationGesture(WebCore::FloatPoint origin, WebCore::FloatRect renderRect, WebCore::FloatRect visibleContentBounds, bool isReplacedElement, double viewportMinimumScale, double viewportMaximumScale);
@@ -118,6 +124,7 @@
void beginSwipeGesture(WebBackForwardListItem* targetItem, SwipeDirection);
void handleSwipeGesture(WebBackForwardListItem* targetItem, double progress, SwipeDirection);
void endSwipeGesture(WebBackForwardListItem* targetItem, bool cancelled);
+bool deltaIsSufficientToBeginSwipe(NSEvent *);
#endif
WebPageProxy& m_webPageProxy;
@@ -129,7 +136,7 @@
RefPtr m_currentSwipeSnapshotSurface;
#endif
-#if !PLATFORM(IOS)
+#if PLATFORM(MAC)
double m_magnification;
WebCore::FloatPoint m_magnificationOrigin;
@@ -150,8 +157,9 @@
// If we need to wait for content to decide if it is going to consume
// the scroll event that would have started a swipe, we'll fill these in.
-bool m_hasPendingSwipe;
+PendingSwipeReason m_pendingSwipeReason;
SwipeDirection m_pendingSwipeDirection;
+WebCore::FloatSize m_cumulativeDeltaForPendingSwipe;
#else
UIView *m_liveSwipeView;
RetainPtr m_snapshotView;
Modified: trunk/Source/WebKit2/UIProcess/mac/ViewGestureControllerMac.mm (166940 => 166941)
-
[webkit-changes] [166940] trunk/Source/WebKit2
Title: [166940] trunk/Source/WebKit2
Revision 166940
Author jer.no...@apple.com
Date 2014-04-08 11:26:51 -0700 (Tue, 08 Apr 2014)
Log Message
[Mac][WK2] Videos do not have access to session cookies
https://bugs.webkit.org/show_bug.cgi?id=129687
Reviewed by Eric Carlson.
Update the CookieStorageShim to track changes in underlying networking stack.
* Shared/mac/CookieStorageShim.mm:
(WebKit::CookieStorageShim::initialize):
(-[WKNSURLSessionLocal _getCookieHeadersForTask:completionHandler:]):
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/Shared/mac/CookieStorageShim.mm
Diff
Modified: trunk/Source/WebKit2/ChangeLog (166939 => 166940)
--- trunk/Source/WebKit2/ChangeLog 2014-04-08 18:22:56 UTC (rev 166939)
+++ trunk/Source/WebKit2/ChangeLog 2014-04-08 18:26:51 UTC (rev 166940)
@@ -1,3 +1,16 @@
+2014-04-07 Jer Noble
+
+[Mac][WK2] Videos do not have access to session cookies
+https://bugs.webkit.org/show_bug.cgi?id=129687
+
+Reviewed by Eric Carlson.
+
+Update the CookieStorageShim to track changes in underlying networking stack.
+
+* Shared/mac/CookieStorageShim.mm:
+(WebKit::CookieStorageShim::initialize):
+(-[WKNSURLSessionLocal _getCookieHeadersForTask:completionHandler:]):
+
2014-04-08 Dan Bernstein
[Cocoa] Add a way to tell whether a WKWebProcessPlugInNodeHandle is a text-type HTML input element
Modified: trunk/Source/WebKit2/Shared/mac/CookieStorageShim.mm (166939 => 166940)
--- trunk/Source/WebKit2/Shared/mac/CookieStorageShim.mm 2014-04-08 18:22:56 UTC (rev 166939)
+++ trunk/Source/WebKit2/Shared/mac/CookieStorageShim.mm 2014-04-08 18:26:51 UTC (rev 166940)
@@ -31,17 +31,18 @@
#include "CookieStorageShimLibrary.h"
#include "NetworkConnectionToWebProcess.h"
#include "NetworkProcessConnection.h"
-#include
#include "WebCoreArgumentCoders.h"
#include "WebProcess.h"
+#include
+#include
#include
-#include
#include
#include
#include
#include
typedef const struct _CFURLRequest* CFURLRequestRef;
+@class NSURLSessionTask;
SOFT_LINK_FRAMEWORK(CFNetwork)
SOFT_LINK(CFNetwork, CFURLRequestGetURL, CFURLRef, (CFURLRequestRef request), (request))
@@ -50,6 +51,9 @@
@interface WKNSURLSessionLocal : NSObject
- (CFDictionaryRef) _copyCookiesForRequestUsingAllAppropriateStorageSemantics:(CFURLRequestRef) request;
+#if PLATFORM(IOS) || __MAC_OS_X_VERSION_MIN_REQUIRED >= 1090
+- (void)_getCookieHeadersForTask:(NSURLSessionTask*)task completionHandler:(void (^)(CFDictionaryRef))completionHandler;
+#endif
@end
namespace WebKit {
@@ -87,14 +91,19 @@
if (!__NSURLSessionLocalClass)
return;
-Method original = class_getInstanceMethod(__NSURLSessionLocalClass, @selector(_copyCookiesForRequestUsingAllAppropriateStorageSemantics:));
-if (!original)
-return;
+if (Method original = class_getInstanceMethod(__NSURLSessionLocalClass, @selector(_copyCookiesForRequestUsingAllAppropriateStorageSemantics:))) {
+Method replacement = class_getInstanceMethod([WKNSURLSessionLocal class], @selector(_copyCookiesForRequestUsingAllAppropriateStorageSemantics:));
+ASSERT(replacement);
+method_exchangeImplementations(original, replacement);
+}
-Method replacement = class_getInstanceMethod([WKNSURLSessionLocal class], @selector(_copyCookiesForRequestUsingAllAppropriateStorageSemantics:));
-ASSERT(replacement);
-
-method_exchangeImplementations(original, replacement);
+#if PLATFORM(IOS) || __MAC_OS_X_VERSION_MIN_REQUIRED >= 1090
+if (Method original = class_getInstanceMethod(__NSURLSessionLocalClass, @selector(_getCookieHeadersForTask:completionHandler:))) {
+Method replacement = class_getInstanceMethod([WKNSURLSessionLocal class], @selector(_getCookieHeadersForTask:completionHandler:));
+ASSERT(replacement);
+method_exchangeImplementations(original, replacement);
+}
+#endif
}
}
@@ -104,6 +113,18 @@
{
return WebKit::webKitCookieStorageCopyRequestHeaderFieldsForURL(nullptr, CFURLRequestGetURL(request));
}
+
+#if PLATFORM(IOS) || __MAC_OS_X_VERSION_MIN_REQUIRED >= 1090
+- (void)_getCookieHeadersForTask:(NSURLSessionTask*)task completionHandler:(void (^)(CFDictionaryRef))completionHandler
+{
+if (!completionHandler)
+return;
+
+dispatch_async(dispatch_get_main_queue(), ^{
+completionHandler(WebKit::webKitCookieStorageCopyRequestHeaderFieldsForURL(nullptr, (CFURLRef)[[task currentRequest] URL]));
+});
+}
+#endif
@end
#endif // ENABLE(NETWORK_PROCESS)
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [166939] trunk/Source/WebCore
Title: [166939] trunk/Source/WebCore Revision 166939 Author jer.no...@apple.com Date 2014-04-08 11:22:56 -0700 (Tue, 08 Apr 2014) Log Message [WK2][iOS] Consecutive videos in full screen display only black https://bugs.webkit.org/show_bug.cgi?id=131316 Reviewed by Eric Carlson. Update the MediaPlayer's full screen attributes whenever the underlying engine changes, not just when the engine is initially created. Also, clear the videoLayer out of the fullscreen layer when destroying the videoLayer. * html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::parseAttribute): * platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm: (WebCore::MediaPlayerPrivateAVFoundationObjC::destroyVideoLayer): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/html/HTMLMediaElement.cpp trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm Diff Modified: trunk/Source/WebCore/ChangeLog (166938 => 166939) --- trunk/Source/WebCore/ChangeLog 2014-04-08 18:19:47 UTC (rev 166938) +++ trunk/Source/WebCore/ChangeLog 2014-04-08 18:22:56 UTC (rev 166939) @@ -1,3 +1,19 @@ +2014-04-07 Jer Noble + +[WK2][iOS] Consecutive videos in full screen display only black +https://bugs.webkit.org/show_bug.cgi?id=131316 + +Reviewed by Eric Carlson. + +Update the MediaPlayer's full screen attributes whenever the underlying engine changes, +not just when the engine is initially created. Also, clear the videoLayer out of the +fullscreen layer when destroying the videoLayer. + +* html/HTMLMediaElement.cpp: +(WebCore::HTMLMediaElement::parseAttribute): +* platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm: +(WebCore::MediaPlayerPrivateAVFoundationObjC::destroyVideoLayer): + 2014-04-08 Morten Stenshorne [New Multicolumn] Child top margin sometimes ignored for column balancing Modified: trunk/Source/WebCore/html/HTMLMediaElement.cpp (166938 => 166939) --- trunk/Source/WebCore/html/HTMLMediaElement.cpp 2014-04-08 18:19:47 UTC (rev 166938) +++ trunk/Source/WebCore/html/HTMLMediaElement.cpp 2014-04-08 18:22:56 UTC (rev 166939) @@ -4230,6 +4230,14 @@ #if ENABLE(MEDIA_SOURCE) m_droppedVideoFrames = 0; #endif + +#if PLATFORM(IOS) +if (!m_player) +return; +m_player->setVideoFullscreenFrame(m_videoFullscreenFrame); +m_player->setVideoFullscreenGravity(m_videoFullscreenGravity); +m_player->setVideoFullscreenLayer(m_videoFullscreenLayer.get()); +#endif } void HTMLMediaElement::mediaPlayerFirstVideoFrameAvailable(MediaPlayer*) @@ -5505,12 +5513,6 @@ enqueuePlaybackTargetAvailabilityChangedEvent(); // Ensure the event listener gets at least one event. } #endif - -#if PLATFORM(IOS) -m_player->setVideoFullscreenFrame(m_videoFullscreenFrame); -m_player->setVideoFullscreenGravity(m_videoFullscreenGravity); -m_player->setVideoFullscreenLayer(m_videoFullscreenLayer.get()); -#endif } #if ENABLE(WEB_AUDIO) Modified: trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm (166938 => 166939) --- trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm 2014-04-08 18:19:47 UTC (rev 166938) +++ trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm 2014-04-08 18:22:56 UTC (rev 166939) @@ -533,6 +533,11 @@ [m_videoLayer.get() setPlayer:nil]; +#if PLATFORM(IOS) +if (m_videoFullscreenLayer) +[m_videoLayer removeFromSuperlayer]; +#endif + m_videoLayer = 0; } ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [166938] trunk
Title: [166938] trunk Revision 166938 Author commit-qu...@webkit.org Date 2014-04-08 11:19:47 -0700 (Tue, 08 Apr 2014) Log Message [New Multicolumn] Child top margin sometimes ignored for column balancing https://bugs.webkit.org/show_bug.cgi?id=122754 Patch by Morten Stenshorne on 2014-04-08 Reviewed by David Hyatt. Source/WebCore: We need to set zero page logical height in LayoutState when column height is unknown (when the columns haven't yet been balanced). There's code that assumes that non-zero page height means that page height is known. Lying about this makes the pagination code believe that every top margin is adjacent to a column break, which makes it eat and ignore all top margins. This should be cleaned up, but it's easier to wait until the old multicol code has been removed. Tests: fast/multicol/break-in-scrollable.html fast/multicol/newmulticol/leading-and-trailing-margin.html fast/multicol/newmulticol/leading-margin.html * rendering/LayoutState.cpp: (WebCore::LayoutState::LayoutState): * rendering/RenderBlockFlow.cpp: (WebCore::RenderBlockFlow::checkForPaginationLogicalHeightChange): * rendering/RenderFlowThread.h: * rendering/RenderMultiColumnFlowThread.cpp: (WebCore::RenderMultiColumnFlowThread::isPageLogicalHeightKnown): * rendering/RenderMultiColumnFlowThread.h: LayoutTests: * fast/multicol/break-in-scrollable-expected.html: Added. * fast/multicol/break-in-scrollable.html: Added. * fast/multicol/newmulticol/leading-and-trailing-margin-expected.html: Added. * fast/multicol/newmulticol/leading-and-trailing-margin.html: Added. * fast/multicol/newmulticol/leading-margin-expected.html: Added. * fast/multicol/newmulticol/leading-margin.html: Added. Modified Paths trunk/LayoutTests/ChangeLog trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/rendering/LayoutState.cpp trunk/Source/WebCore/rendering/RenderBlockFlow.cpp trunk/Source/WebCore/rendering/RenderFlowThread.h trunk/Source/WebCore/rendering/RenderMultiColumnFlowThread.cpp trunk/Source/WebCore/rendering/RenderMultiColumnFlowThread.h Added Paths trunk/LayoutTests/fast/multicol/break-in-scrollable-expected.html trunk/LayoutTests/fast/multicol/break-in-scrollable.html trunk/LayoutTests/fast/multicol/newmulticol/leading-and-trailing-margin-expected.html trunk/LayoutTests/fast/multicol/newmulticol/leading-and-trailing-margin.html trunk/LayoutTests/fast/multicol/newmulticol/leading-margin-expected.html trunk/LayoutTests/fast/multicol/newmulticol/leading-margin.html Diff Modified: trunk/LayoutTests/ChangeLog (166937 => 166938) --- trunk/LayoutTests/ChangeLog 2014-04-08 18:06:11 UTC (rev 166937) +++ trunk/LayoutTests/ChangeLog 2014-04-08 18:19:47 UTC (rev 166938) @@ -1,3 +1,17 @@ +2014-04-08 Morten Stenshorne + +[New Multicolumn] Child top margin sometimes ignored for column balancing +https://bugs.webkit.org/show_bug.cgi?id=122754 + +Reviewed by David Hyatt. + +* fast/multicol/break-in-scrollable-expected.html: Added. +* fast/multicol/break-in-scrollable.html: Added. +* fast/multicol/newmulticol/leading-and-trailing-margin-expected.html: Added. +* fast/multicol/newmulticol/leading-and-trailing-margin.html: Added. +* fast/multicol/newmulticol/leading-margin-expected.html: Added. +* fast/multicol/newmulticol/leading-margin.html: Added. + 2014-04-07 Brent Fulgham [WebVTT] Begin Enabling W3C VTT Tests Added: trunk/LayoutTests/fast/multicol/break-in-scrollable-expected.html (0 => 166938) --- trunk/LayoutTests/fast/multicol/break-in-scrollable-expected.html (rev 0) +++ trunk/LayoutTests/fast/multicol/break-in-scrollable-expected.html 2014-04-08 18:19:47 UTC (rev 166938) @@ -0,0 +1,19 @@ + + + +Forced break inside scrollable container + +if (window.internals) +internals.settings.setRegionBasedColumnsEnabled(true); + + + +The word 'PASS' should be seen on the left below. The scrollbars shouldn't be scrollable. + + + +PASS + + + + Added: trunk/LayoutTests/fast/multicol/break-in-scrollable.html (0 => 166938) --- trunk/LayoutTests/fast/multicol/break-in-scrollable.html (rev 0) +++ trunk/LayoutTests/fast/multicol/break-in-scrollable.html 2014-04-08 18:19:47 UTC (rev 166938) @@ -0,0 +1,19 @@ + + + +Forced break inside scrollable container + +if (window.internals) +internals.settings.setRegionBasedColumnsEnabled(true); + + + +The word 'PASS' should be seen on the left below. The scrollbars shouldn't be scrollable. + + + +PASS + + + + Added: trunk/LayoutTests/fast/multicol/newmulticol/leading-and-trailing-margin-expected.html (0 => 166938) --- trunk/LayoutTests/fast/multicol/newmul
[webkit-changes] [166937] trunk/Source/WebCore
Title: [166937] trunk/Source/WebCore
Revision 166937
Author d...@apple.com
Date 2014-04-08 11:06:11 -0700 (Tue, 08 Apr 2014)
Log Message
Allow elements to register for changes in page scale
https://bugs.webkit.org/show_bug.cgi?id=131319
Reviewed by Eric Carlson.
Some parts of WebCore need to react to changes in the page
scale factor, such as resizing when the user zooms. A followup
patch will enable this for media controls - this simply lays
the groundwork.
At the moment we only allow HTMLMediaElements to register, but if
necessary this could be expanded in the future.
* dom/Document.cpp: New methods to keep a list of HTMLMediaElements that
are interested in updates.
(WebCore::Document::registerForPageScaleFactorChangedCallbacks):
(WebCore::Document::unregisterForPageScaleFactorChangedCallbacks):
(WebCore::Document::pageScaleFactorChanged):
* dom/Document.h:
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::HTMLMediaElement):
(WebCore::HTMLMediaElement::registerWithDocument): Add ourselves to the
the document's pageScale callback.
(WebCore::HTMLMediaElement::unregisterWithDocument): Remove ourselves from the
the document's pageScale callback.
(WebCore::HTMLMediaElement::setMediaControlsDependOnPageScaleFactor): Add/remove ourselves to/from
the callback if necessary.
(WebCore::HTMLMediaElement::pageScaleFactorChanged): The callback function. Empty for now.
* html/HTMLMediaElement.h:
(WebCore::HTMLMediaElement::mediaControlsDependOnPageScaleFactor): Accessor.
* page/Page.cpp:
(WebCore::Page::setPageScaleFactor): Tell all documents that the user has zoomed.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/Document.cpp
trunk/Source/WebCore/dom/Document.h
trunk/Source/WebCore/html/HTMLMediaElement.cpp
trunk/Source/WebCore/html/HTMLMediaElement.h
trunk/Source/WebCore/page/Page.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (166936 => 166937)
--- trunk/Source/WebCore/ChangeLog 2014-04-08 18:04:59 UTC (rev 166936)
+++ trunk/Source/WebCore/ChangeLog 2014-04-08 18:06:11 UTC (rev 166937)
@@ -1,3 +1,38 @@
+2014-04-07 Dean Jackson
+
+Allow elements to register for changes in page scale
+https://bugs.webkit.org/show_bug.cgi?id=131319
+
+Reviewed by Eric Carlson.
+
+Some parts of WebCore need to react to changes in the page
+scale factor, such as resizing when the user zooms. A followup
+patch will enable this for media controls - this simply lays
+the groundwork.
+
+At the moment we only allow HTMLMediaElements to register, but if
+necessary this could be expanded in the future.
+
+* dom/Document.cpp: New methods to keep a list of HTMLMediaElements that
+are interested in updates.
+(WebCore::Document::registerForPageScaleFactorChangedCallbacks):
+(WebCore::Document::unregisterForPageScaleFactorChangedCallbacks):
+(WebCore::Document::pageScaleFactorChanged):
+* dom/Document.h:
+* html/HTMLMediaElement.cpp:
+(WebCore::HTMLMediaElement::HTMLMediaElement):
+(WebCore::HTMLMediaElement::registerWithDocument): Add ourselves to the
+the document's pageScale callback.
+(WebCore::HTMLMediaElement::unregisterWithDocument): Remove ourselves from the
+the document's pageScale callback.
+(WebCore::HTMLMediaElement::setMediaControlsDependOnPageScaleFactor): Add/remove ourselves to/from
+the callback if necessary.
+(WebCore::HTMLMediaElement::pageScaleFactorChanged): The callback function. Empty for now.
+* html/HTMLMediaElement.h:
+(WebCore::HTMLMediaElement::mediaControlsDependOnPageScaleFactor): Accessor.
+* page/Page.cpp:
+(WebCore::Page::setPageScaleFactor): Tell all documents that the user has zoomed.
+
2014-04-08 pe...@outlook.com
[WinCairo] Compile error in TextureMapper.h
Modified: trunk/Source/WebCore/dom/Document.cpp (166936 => 166937)
--- trunk/Source/WebCore/dom/Document.cpp 2014-04-08 18:04:59 UTC (rev 166936)
+++ trunk/Source/WebCore/dom/Document.cpp 2014-04-08 18:06:11 UTC (rev 166937)
@@ -4195,6 +4195,24 @@
}
#endif
+#if ENABLE(MEDIA_CONTROLS_SCRIPT)
+void Document::registerForPageScaleFactorChangedCallbacks(HTMLMediaElement* element)
+{
+m_pageScaleFactorChangedElements.add(element);
+}
+
+void Document::unregisterForPageScaleFactorChangedCallbacks(HTMLMediaElement* element)
+{
+m_pageScaleFactorChangedElements.remove(element);
+}
+
+void Document::pageScaleFactorChanged()
+{
+for (HTMLMediaElement* mediaElement : m_pageScaleFactorChangedElements)
+mediaElement->pageScaleFactorChanged();
+}
+#endif
+
void Document::setShouldCreateRenderers(bool f)
{
m_createRenderers = f;
Modified: trunk/Source/WebCore/dom/Document.h (166936 => 166937)
--- trunk/Source/WebCore/dom/Document.h 2014-04-08 18:04:59 UTC (rev 166936)
+++ trunk/Source/WebCore/dom/Document.h 2014-04-08 18:06:11 UTC (rev 166937)
@@ -
[webkit-changes] [166936] trunk/Source/WebKit2
Title: [166936] trunk/Source/WebKit2
Revision 166936
Author m...@apple.com
Date 2014-04-08 11:04:59 -0700 (Tue, 08 Apr 2014)
Log Message
[Cocoa] Add a way to tell whether a WKWebProcessPlugInNodeHandle is a text-type HTML input element
https://bugs.webkit.org/show_bug.cgi?id=131374
Reviewed by Anders Carlsson.
* WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInNodeHandle.h:
* WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInNodeHandle.mm:
(-[WKWebProcessPlugInNodeHandle isTextField]): Added this getter. Calls
InjectedBundleNodeHandle::isTextField.
* WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp:
(WebKit::InjectedBundleNodeHandle::isTextField): Added. Uses
WebCore::HTMLInputElement::isText, which is consistent with what
WebChromeClient::focusedElementChanged uses to decide whether to call didFocusTextField.
* WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.h:
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInNodeHandle.h
trunk/Source/WebKit2/WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInNodeHandle.mm
trunk/Source/WebKit2/WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp
trunk/Source/WebKit2/WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.h
Diff
Modified: trunk/Source/WebKit2/ChangeLog (166935 => 166936)
--- trunk/Source/WebKit2/ChangeLog 2014-04-08 17:45:50 UTC (rev 166935)
+++ trunk/Source/WebKit2/ChangeLog 2014-04-08 18:04:59 UTC (rev 166936)
@@ -1,5 +1,22 @@
2014-04-08 Dan Bernstein
+[Cocoa] Add a way to tell whether a WKWebProcessPlugInNodeHandle is a text-type HTML input element
+https://bugs.webkit.org/show_bug.cgi?id=131374
+
+Reviewed by Anders Carlsson.
+
+* WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInNodeHandle.h:
+* WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInNodeHandle.mm:
+(-[WKWebProcessPlugInNodeHandle isTextField]): Added this getter. Calls
+InjectedBundleNodeHandle::isTextField.
+* WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp:
+(WebKit::InjectedBundleNodeHandle::isTextField): Added. Uses
+WebCore::HTMLInputElement::isText, which is consistent with what
+WebChromeClient::focusedElementChanged uses to decide whether to call didFocusTextField.
+* WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.h:
+
+2014-04-08 Dan Bernstein
+
[Cocoa] Add a _certificateChain property to WKWebProcessPlugInFrame
https://bugs.webkit.org/show_bug.cgi?id=131370
Modified: trunk/Source/WebKit2/WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInNodeHandle.h (166935 => 166936)
--- trunk/Source/WebKit2/WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInNodeHandle.h 2014-04-08 17:45:50 UTC (rev 166935)
+++ trunk/Source/WebKit2/WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInNodeHandle.h 2014-04-08 18:04:59 UTC (rev 166936)
@@ -44,6 +44,8 @@
@property (nonatomic, readonly) BOOL HTMLTextAreaElementIsUserEdited;
@property (nonatomic, readonly) WKWebProcessPlugInNodeHandle *HTMLTableCellElementCellAbove;
+- (BOOL)isTextField;
+
@end
#endif // WK_API_ENABLED
Modified: trunk/Source/WebKit2/WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInNodeHandle.mm (166935 => 166936)
--- trunk/Source/WebKit2/WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInNodeHandle.mm 2014-04-08 17:45:50 UTC (rev 166935)
+++ trunk/Source/WebKit2/WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInNodeHandle.mm 2014-04-08 18:04:59 UTC (rev 166936)
@@ -88,6 +88,11 @@
return _nodeHandle->htmlTextAreaElementLastChangeWasUserEdit();
}
+- (BOOL)isTextField
+{
+return _nodeHandle->isTextField();
+}
+
- (WKWebProcessPlugInNodeHandle *)HTMLTableCellElementCellAbove
{
auto nodeHandle = _nodeHandle->htmlTableCellElementCellAbove();
Modified: trunk/Source/WebKit2/WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp (166935 => 166936)
--- trunk/Source/WebKit2/WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp 2014-04-08 17:45:50 UTC (rev 166935)
+++ trunk/Source/WebKit2/WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp 2014-04-08 18:04:59 UTC (rev 166936)
@@ -215,6 +215,11 @@
return toHTMLTextAreaElement(m_node.get())->lastChangeWasUserEdit();
}
+bool InjectedBundleNodeHandle::isTextField() const
+{
+return isHTMLInputElement(m_node.get()) && toHTMLInputElement(m_node.get())->isText();
+}
+
PassRefPtr InjectedBundleNodeHandle::htmlTableCellElementCellAbove()
{
if (!m_node->hasTagName(tdTag))
Modified: trunk/Source/WebKit2/WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.h (166935 => 166936)
--- trunk/Source/WebKit2/WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.h 2014-04-08 17:45:50 UTC (rev 166935)
+++ trunk/Source/WebKit2/WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.h 2014-04-08 18:04:59 UTC (rev 166936)
@@ -66,6 +66,7 @@
void set
[webkit-changes] [166935] trunk/Source/WebKit2
Title: [166935] trunk/Source/WebKit2
Revision 166935
Author m...@apple.com
Date 2014-04-08 10:45:50 -0700 (Tue, 08 Apr 2014)
Log Message
[Cocoa] Add a _certificateChain property to WKWebProcessPlugInFrame
https://bugs.webkit.org/show_bug.cgi?id=131370
Reviewed by Anders Carlsson.
* WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInFrame.mm:
(-[WKWebProcessPlugInFrame _certificateChain]): Added this getter, which uses the new
WebFrame::certificateInfo.
* WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInFramePrivate.h:
* WebProcess/WebPage/WebFrame.cpp:
(WebKit::WebFrame::certificateInfo): Added this getter.
* WebProcess/WebPage/WebFrame.h:
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInFrame.mm
trunk/Source/WebKit2/WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInFramePrivate.h
trunk/Source/WebKit2/WebProcess/WebPage/WebFrame.cpp
trunk/Source/WebKit2/WebProcess/WebPage/WebFrame.h
Diff
Modified: trunk/Source/WebKit2/ChangeLog (166934 => 166935)
--- trunk/Source/WebKit2/ChangeLog 2014-04-08 17:36:39 UTC (rev 166934)
+++ trunk/Source/WebKit2/ChangeLog 2014-04-08 17:45:50 UTC (rev 166935)
@@ -1,5 +1,20 @@
2014-04-08 Dan Bernstein
+[Cocoa] Add a _certificateChain property to WKWebProcessPlugInFrame
+https://bugs.webkit.org/show_bug.cgi?id=131370
+
+Reviewed by Anders Carlsson.
+
+* WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInFrame.mm:
+(-[WKWebProcessPlugInFrame _certificateChain]): Added this getter, which uses the new
+WebFrame::certificateInfo.
+* WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInFramePrivate.h:
+* WebProcess/WebPage/WebFrame.cpp:
+(WebKit::WebFrame::certificateInfo): Added this getter.
+* WebProcess/WebPage/WebFrame.h:
+
+2014-04-08 Dan Bernstein
+
[Cocoa] Add a bundle form delegate method corresponding to textDidChangeInTextField
https://bugs.webkit.org/show_bug.cgi?id=131369
Modified: trunk/Source/WebKit2/WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInFrame.mm (166934 => 166935)
--- trunk/Source/WebKit2/WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInFrame.mm 2014-04-08 17:36:39 UTC (rev 166934)
+++ trunk/Source/WebKit2/WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInFrame.mm 2014-04-08 17:45:50 UTC (rev 166935)
@@ -37,6 +37,7 @@
#import "WebProcess.h"
#import "_WKFrameHandleInternal.h"
#import <_javascript_Core/JSValue.h>
+#import
#import
using namespace WebKit;
@@ -110,6 +111,11 @@
return _frame->page()->mainFrameHasCustomContentProvider();
}
+- (NSArray *)_certificateChain
+{
+return (NSArray *)_frame->certificateInfo().certificateChain();
+}
+
#pragma mark WKObject protocol implementation
- (API::Object&)_apiObject
Modified: trunk/Source/WebKit2/WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInFramePrivate.h (166934 => 166935)
--- trunk/Source/WebKit2/WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInFramePrivate.h 2014-04-08 17:36:39 UTC (rev 166934)
+++ trunk/Source/WebKit2/WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInFramePrivate.h 2014-04-08 17:45:50 UTC (rev 166935)
@@ -36,6 +36,7 @@
@property (nonatomic, readonly) WKWebProcessPlugInBrowserContextController *_browserContextController;
@property (nonatomic, readonly) BOOL _hasCustomContentProvider;
+@property (nonatomic, readonly) NSArray *_certificateChain;
@end
Modified: trunk/Source/WebKit2/WebProcess/WebPage/WebFrame.cpp (166934 => 166935)
--- trunk/Source/WebKit2/WebProcess/WebPage/WebFrame.cpp 2014-04-08 17:36:39 UTC (rev 166934)
+++ trunk/Source/WebKit2/WebProcess/WebPage/WebFrame.cpp 2014-04-08 17:45:50 UTC (rev 166935)
@@ -44,6 +44,7 @@
#include <_javascript_Core/JSLock.h>
#include <_javascript_Core/JSValueRef.h>
#include
+#include
#include
#include
#include
@@ -401,6 +402,18 @@
return documentLoader->url().string();
}
+const WebCore::CertificateInfo& WebFrame::certificateInfo() const
+{
+if (!m_coreFrame)
+return std::move(CertificateInfo());
+
+DocumentLoader* documentLoader = m_coreFrame->loader().documentLoader();
+if (!documentLoader)
+return std::move(CertificateInfo());
+
+return std::move(CertificateInfo(documentLoader->response()));
+}
+
String WebFrame::innerText() const
{
if (!m_coreFrame)
Modified: trunk/Source/WebKit2/WebProcess/WebPage/WebFrame.h (166934 => 166935)
--- trunk/Source/WebKit2/WebProcess/WebPage/WebFrame.h 2014-04-08 17:36:39 UTC (rev 166934)
+++ trunk/Source/WebKit2/WebProcess/WebPage/WebFrame.h 2014-04-08 17:45:50 UTC (rev 166935)
@@ -43,6 +43,7 @@
}
namespace WebCore {
+class CertificateInfo;
class Frame;
class HTMLFrameOwnerElement;
class IntPoint;
@@ -91,6 +92,7 @@
bool isMainFrame() const;
String name() const;
String url() const;
+const WebCore::CertificateInfo& certificateInfo() const;
String i
[webkit-changes] [166934] trunk/Source/WebKit2
Title: [166934] trunk/Source/WebKit2
Revision 166934
Author m...@apple.com
Date 2014-04-08 10:36:39 -0700 (Tue, 08 Apr 2014)
Log Message
[Cocoa] Add a bundle form delegate method corresponding to textDidChangeInTextField
https://bugs.webkit.org/show_bug.cgi?id=131369
Reviewed by Anders Carlsson.
* WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInFormDelegatePrivate.h: Declared
new delegate method.
* WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextController.mm:
(-[WKWebProcessPlugInBrowserContextController _setFormDelegate:]): Added an override
of API::InjectedBundle::FormClient::textDidChangeInTextField which calls the new delegate
method.
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInFormDelegatePrivate.h
trunk/Source/WebKit2/WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextController.mm
Diff
Modified: trunk/Source/WebKit2/ChangeLog (166933 => 166934)
--- trunk/Source/WebKit2/ChangeLog 2014-04-08 17:17:44 UTC (rev 166933)
+++ trunk/Source/WebKit2/ChangeLog 2014-04-08 17:36:39 UTC (rev 166934)
@@ -1,5 +1,19 @@
2014-04-08 Dan Bernstein
+[Cocoa] Add a bundle form delegate method corresponding to textDidChangeInTextField
+https://bugs.webkit.org/show_bug.cgi?id=131369
+
+Reviewed by Anders Carlsson.
+
+* WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInFormDelegatePrivate.h: Declared
+new delegate method.
+* WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextController.mm:
+(-[WKWebProcessPlugInBrowserContextController _setFormDelegate:]): Added an override
+of API::InjectedBundle::FormClient::textDidChangeInTextField which calls the new delegate
+method.
+
+2014-04-08 Dan Bernstein
+
[Cocoa] Add WKFormDelegate
https://bugs.webkit.org/show_bug.cgi?id=131343
Modified: trunk/Source/WebKit2/WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInFormDelegatePrivate.h (166933 => 166934)
--- trunk/Source/WebKit2/WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInFormDelegatePrivate.h 2014-04-08 17:17:44 UTC (rev 166933)
+++ trunk/Source/WebKit2/WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInFormDelegatePrivate.h 2014-04-08 17:36:39 UTC (rev 166934)
@@ -37,6 +37,7 @@
- (void)_webProcessPlugInBrowserContextController:(WKWebProcessPlugInBrowserContextController *)controller didFocusTextField:(WKWebProcessPlugInNodeHandle *)textField inFrame:(WKWebProcessPlugInFrame *)frame;
- (void)_webProcessPlugInBrowserContextController:(WKWebProcessPlugInBrowserContextController *)controller willSubmitForm:(WKWebProcessPlugInNodeHandle *)form toFrame:(WKWebProcessPlugInFrame *)frame fromFrame:(WKWebProcessPlugInFrame *)sourceFrame withValues:(NSDictionary *)values;
+- (void)_webProcessPlugInBrowserContextController:(WKWebProcessPlugInBrowserContextController *)controller textDidChangeInTextField:(WKWebProcessPlugInNodeHandle *)textField inFrame:(WKWebProcessPlugInFrame *)frame;
// The return value is exposed in the UI process via the userObject property of the _WKFormInputSession object.
- (NSObject *)_webProcessPlugInBrowserContextController:(WKWebProcessPlugInBrowserContextController *)controller willBeginInputSessionForElement:(WKWebProcessPlugInNodeHandle *)node inFrame:(WKWebProcessPlugInFrame *)frame;
Modified: trunk/Source/WebKit2/WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextController.mm (166933 => 166934)
--- trunk/Source/WebKit2/WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextController.mm 2014-04-08 17:17:44 UTC (rev 166933)
+++ trunk/Source/WebKit2/WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextController.mm 2014-04-08 17:36:39 UTC (rev 166934)
@@ -412,6 +412,14 @@
}
}
+virtual void textDidChangeInTextField(WebPage*, HTMLInputElement* inputElement, WebFrame* frame) override
+{
+auto formDelegate = m_controller->_formDelegate.get();
+
+if ([formDelegate respondsToSelector:@selector(_webProcessPlugInBrowserContextController:textDidChangeInTextField:inFrame:)])
+[formDelegate _webProcessPlugInBrowserContextController:m_controller textDidChangeInTextField:wrapper(*WebKit::InjectedBundleNodeHandle::getOrCreate(inputElement)) inFrame:wrapper(*frame)];
+}
+
static void releaseNSData(unsigned char*, const void* untypedData)
{
[(NSData *)untypedData release];
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [166933] trunk/Source
Title: [166933] trunk/Source Revision 166933 Author m...@apple.com Date 2014-04-08 10:17:44 -0700 (Tue, 08 Apr 2014) Log Message ../WebKit/mac: WebKit part of [Cocoa] Add WKFormDelegate https://bugs.webkit.org/show_bug.cgi?id=131343 Reviewed by Anders Carlsson. * MigrateHeaders.make: Added new WebKit2 headers to WEBKIT2_HEADERS. ../WebKit2: [Cocoa] Add WKFormDelegate https://bugs.webkit.org/show_bug.cgi?id=131343 Reviewed by Anders Carlsson. * UIProcess/API/Cocoa/WKWebView.mm: (-[WKWebView _formDelegate]): Added this accessor. (-[WKWebView _setFormDelegate:]): Ditto. * UIProcess/API/Cocoa/WKWebViewPrivate.h: Declared _formDelegate property. * UIProcess/API/Cocoa/_WKFormDelegate.h: Added. * UIProcess/API/Cocoa/_WKFormInputSession.h: Added. * UIProcess/ios/WKContentView.h: Moved _webView ivar into the @interface… * UIProcess/ios/WKContentView.mm: …from the @implementation. * UIProcess/ios/WKContentViewInteraction.h: Added _formInputSession ivar and formAccessoryView property. * UIProcess/ios/WKContentViewInteraction.mm: (-[WKFormInputSession initWithContentView:userObject:]): Added. (-[WKFormInputSession dealloc]): Added. (-[WKFormInputSession userObject]): Added. (-[WKFormInputSession isValid]): Added. (-[WKFormInputSession accessoryViewCustomButtonTitle]): Added. (-[WKFormInputSession setAccessoryViewCustomButtonTitle:]): Added. (-[WKFormInputSession invalidate]): Added. (-[WKContentView cleanupInteraction]): Invalidate and release the input session. (-[WKContentView formAccessoryView]): Added this accessor. (-[WKContentView _startAssistingNode:userObject:]): Create an input session and message the form delegate. (-[WKContentView _stopAssistingNode]): Invalidate and release the input session. * WebKit2.xcodeproj/project.pbxproj: Added references to new files. * WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInFormDelegatePrivate.h: Added comment. Modified Paths trunk/Source/WebKit/mac/ChangeLog trunk/Source/WebKit/mac/MigrateHeaders.make trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebViewPrivate.h trunk/Source/WebKit2/UIProcess/ios/WKContentView.h trunk/Source/WebKit2/UIProcess/ios/WKContentView.mm trunk/Source/WebKit2/UIProcess/ios/WKContentViewInteraction.h trunk/Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm trunk/Source/WebKit2/WebKit2.xcodeproj/project.pbxproj trunk/Source/WebKit2/WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInFormDelegatePrivate.h Added Paths trunk/Source/WebKit2/UIProcess/API/Cocoa/_WKFormDelegate.h trunk/Source/WebKit2/UIProcess/API/Cocoa/_WKFormInputSession.h Diff Modified: trunk/Source/WebKit/mac/ChangeLog (166932 => 166933) --- trunk/Source/WebKit/mac/ChangeLog 2014-04-08 16:47:12 UTC (rev 166932) +++ trunk/Source/WebKit/mac/ChangeLog 2014-04-08 17:17:44 UTC (rev 166933) @@ -1,3 +1,12 @@ +2014-04-08 Dan Bernstein + +WebKit part of [Cocoa] Add WKFormDelegate +https://bugs.webkit.org/show_bug.cgi?id=131343 + +Reviewed by Anders Carlsson. + +* MigrateHeaders.make: Added new WebKit2 headers to WEBKIT2_HEADERS. + 2014-04-08 Daniel Bates Fallback to default storage session when there isn't a valid session ID Modified: trunk/Source/WebKit/mac/MigrateHeaders.make (166932 => 166933) --- trunk/Source/WebKit/mac/MigrateHeaders.make 2014-04-08 16:47:12 UTC (rev 166932) +++ trunk/Source/WebKit/mac/MigrateHeaders.make 2014-04-08 17:17:44 UTC (rev 166933) @@ -287,6 +287,8 @@ WKWebViewPrivate.h \ _WKActivatedElementInfo.h \ _WKElementAction.h \ +_WKFormDelegate.h \ +_WKFormInputSession.h \ _WKProcessPoolConfiguration.h \ _WKScriptWorld.h \ _WKThumbnailView.h \ Modified: trunk/Source/WebKit2/ChangeLog (166932 => 166933) --- trunk/Source/WebKit2/ChangeLog 2014-04-08 16:47:12 UTC (rev 166932) +++ trunk/Source/WebKit2/ChangeLog 2014-04-08 17:17:44 UTC (rev 166933) @@ -1,3 +1,43 @@ +2014-04-08 Dan Bernstein + +[Cocoa] Add WKFormDelegate +https://bugs.webkit.org/show_bug.cgi?id=131343 + +Reviewed by Anders Carlsson. + +* UIProcess/API/Cocoa/WKWebView.mm: +(-[WKWebView _formDelegate]): Added this accessor. +(-[WKWebView _setFormDelegate:]): Ditto. +* UIProcess/API/Cocoa/WKWebViewPrivate.h: Declared _formDelegate property. + +* UIProcess/API/Cocoa/_WKFormDelegate.h: Added. + +* UIProcess/API/Cocoa/_WKFormInputSession.h: Added. + +* UIProcess/ios/WKContentView.h: Moved _webView ivar into the @interface… +* UIProcess/ios/WKContentView.mm: …from the @implementation. + +* UIProcess/ios/WKContentViewInteraction.h: Added _formInputSession ivar and +formAccessoryView property. +* UIProcess/ios/WKContentViewInteraction.mm: +(-[WKFormInputSession initWithContentView:userObject:]): Added. +(-[WKFormInputSession dealloc]): Added. +(-[WKFormInputSess
[webkit-changes] [166932] trunk/Tools
Title: [166932] trunk/Tools
Revision 166932
Author bfulg...@apple.com
Date 2014-04-08 09:47:12 -0700 (Tue, 08 Apr 2014)
Log Message
Unreviewed gardening: Prevent users from attempting
to build with known invalid cURL.
* Scripts/webkitdirs.pm:
(checkInstalledTools): Block build attempts with bad
Cygwin tool set.
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitdirs.pm
Diff
Modified: trunk/Tools/ChangeLog (166931 => 166932)
--- trunk/Tools/ChangeLog 2014-04-08 16:40:04 UTC (rev 166931)
+++ trunk/Tools/ChangeLog 2014-04-08 16:47:12 UTC (rev 166932)
@@ -1,3 +1,12 @@
+2014-04-08 Brent Fulgham
+
+Unreviewed gardening: Prevent users from attempting
+to build with known invalid cURL.
+
+* Scripts/webkitdirs.pm:
+(checkInstalledTools): Block build attempts with bad
+Cygwin tool set.
+
2014-04-07 Geoffrey Garen
Build bmalloc on Mac
Modified: trunk/Tools/Scripts/webkitdirs.pm (166931 => 166932)
--- trunk/Tools/Scripts/webkitdirs.pm 2014-04-08 16:40:04 UTC (rev 166931)
+++ trunk/Tools/Scripts/webkitdirs.pm 2014-04-08 16:47:12 UTC (rev 166932)
@@ -1419,6 +1419,16 @@
die "You must have Python installed to build WebKit.\n" if ($?);
die "Python 2.7.3 is not compatible with the WebKit build. Please downgrade to Python 2.6.8.\n" if ($pythonVer =~ /2\.7\.3/);
+# cURL 7.34.0 has a bug that prevents authentication with opensource.apple.com (and other things using SSL3).
+my $curlVer = `curl --version | grep "curl"`;
+chomp($curlVer);
+if (!$? and $curlVer =~ /libcurl\/7\.33\.0/) {
+print "cURL version 7.34.0 has a bug that prevents authentication with SSL v2 or v3.\n";
+print "cURL 7.33.0 is known to work. The cURL projects is preparing an update to\n";
+print "correct this problem.\n\n";
+die "Please install a working cURL and try again.\n";
+}
+
# MathML requires fonts that do not ship with Windows (at least through Windows 8). Warn the user if they are missing
my @fonts = qw(STIXGeneral-Regular MathJax_Main-Regular);
my @missing = ();
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [166931] trunk/Source/WebCore
Title: [166931] trunk/Source/WebCore
Revision 166931
Author commit-qu...@webkit.org
Date 2014-04-08 09:40:04 -0700 (Tue, 08 Apr 2014)
Log Message
[WinCairo] Compile error in TextureMapper.h
https://bugs.webkit.org/show_bug.cgi?id=131360
Patch by pe...@outlook.com on 2014-04-08
Reviewed by Brent Fulgham.
The TextureMapper class has pure virtual methods, and cannot be instantiated.
* platform/graphics/texmap/TextureMapper.h:
(WebCore::TextureMapper::platformCreateAccelerated):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/texmap/TextureMapper.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (166930 => 166931)
--- trunk/Source/WebCore/ChangeLog 2014-04-08 16:26:24 UTC (rev 166930)
+++ trunk/Source/WebCore/ChangeLog 2014-04-08 16:40:04 UTC (rev 166931)
@@ -1,3 +1,15 @@
+2014-04-08 pe...@outlook.com
+
+[WinCairo] Compile error in TextureMapper.h
+https://bugs.webkit.org/show_bug.cgi?id=131360
+
+Reviewed by Brent Fulgham.
+
+The TextureMapper class has pure virtual methods, and cannot be instantiated.
+
+* platform/graphics/texmap/TextureMapper.h:
+(WebCore::TextureMapper::platformCreateAccelerated):
+
2014-04-08 Zalan Bujtas
Subpixel rendering: Slow paint path for inlines should snap to device pixels.
Modified: trunk/Source/WebCore/platform/graphics/texmap/TextureMapper.h (166930 => 166931)
--- trunk/Source/WebCore/platform/graphics/texmap/TextureMapper.h 2014-04-08 16:26:24 UTC (rev 166930)
+++ trunk/Source/WebCore/platform/graphics/texmap/TextureMapper.h 2014-04-08 16:40:04 UTC (rev 166931)
@@ -177,7 +177,7 @@
#else
static std::unique_ptr platformCreateAccelerated()
{
-return std::make_unique();
+return nullptr;
}
#endif
InterpolationQuality m_interpolationQuality;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [166929] trunk
Title: [166929] trunk
Revision 166929
Author za...@apple.com
Date 2014-04-08 09:19:56 -0700 (Tue, 08 Apr 2014)
Log Message
Subpixel rendering: Slow paint path for inlines should snap to device pixels.
https://bugs.webkit.org/show_bug.cgi?id=131259
Reviewed by Simon Fraser.
InlineTextBox::paint needs to round to the same device pixel position as SimpleLineLayout does.
Source/WebCore:
Test: fast/inline/hidpi-slow-path-text-on-subpixel-position.html
* rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::paint):
* rendering/TextPainter.h: Cleanup. No reason to have them as references here.
LayoutTests:
* fast/inline/hidpi-slow-path-text-on-subpixel-position-expected.html: Added.
* fast/inline/hidpi-slow-path-text-on-subpixel-position.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/InlineTextBox.cpp
trunk/Source/WebCore/rendering/TextPainter.h
Added Paths
trunk/LayoutTests/fast/inline/hidpi-slow-path-text-on-subpixel-position-expected.html
trunk/LayoutTests/fast/inline/hidpi-slow-path-text-on-subpixel-position.html
Diff
Modified: trunk/LayoutTests/ChangeLog (166928 => 166929)
--- trunk/LayoutTests/ChangeLog 2014-04-08 16:09:29 UTC (rev 166928)
+++ trunk/LayoutTests/ChangeLog 2014-04-08 16:19:56 UTC (rev 166929)
@@ -1,5 +1,17 @@
2014-04-08 Zalan Bujtas
+Subpixel rendering: Slow paint path for inlines should snap to device pixels.
+https://bugs.webkit.org/show_bug.cgi?id=131259
+
+Reviewed by Simon Fraser.
+
+InlineTextBox::paint needs to round to the same device pixel position as SimpleLineLayout does.
+
+* fast/inline/hidpi-slow-path-text-on-subpixel-position-expected.html: Added.
+* fast/inline/hidpi-slow-path-text-on-subpixel-position.html: Added.
+
+2014-04-08 Zalan Bujtas
+
Subpixel rendering: Paint the filter effect result image on device pixel position.
https://bugs.webkit.org/show_bug.cgi?id=131255
Added: trunk/LayoutTests/fast/inline/hidpi-slow-path-text-on-subpixel-position-expected.html (0 => 166929)
--- trunk/LayoutTests/fast/inline/hidpi-slow-path-text-on-subpixel-position-expected.html (rev 0)
+++ trunk/LayoutTests/fast/inline/hidpi-slow-path-text-on-subpixel-position-expected.html 2014-04-08 16:19:56 UTC (rev 166929)
@@ -0,0 +1,23 @@
+
+
+
+
+ .outer {
+display: -webkit-flex;
+-webkit-align-items: center;
+box-sizing: border-box;
+padding-top: 1px;
+height: 25px;
+ }
+ .inner {
+font: -webkit-small-control;
+font-size: 9px;
+}
+
+
+
+
+This tests that slow paint for inlines draws the text on the same position as fast path.
+
+
+
Added: trunk/LayoutTests/fast/inline/hidpi-slow-path-text-on-subpixel-position.html (0 => 166929)
--- trunk/LayoutTests/fast/inline/hidpi-slow-path-text-on-subpixel-position.html (rev 0)
+++ trunk/LayoutTests/fast/inline/hidpi-slow-path-text-on-subpixel-position.html 2014-04-08 16:19:56 UTC (rev 166929)
@@ -0,0 +1,24 @@
+
+
+
+
+ .outer {
+display: -webkit-flex;
+-webkit-align-items: center;
+box-sizing: border-box;
+padding-top: 1px;
+height: 25px;
+ }
+ .inner {
+font: -webkit-small-control;
+font-size: 9px;
+-webkit-transform: translateX(0);
+}
+
+
+
+
+This tests that slow paint for inlines draws the text on the same position as fast path.
+
+
+
Modified: trunk/Source/WebCore/ChangeLog (166928 => 166929)
--- trunk/Source/WebCore/ChangeLog 2014-04-08 16:09:29 UTC (rev 166928)
+++ trunk/Source/WebCore/ChangeLog 2014-04-08 16:19:56 UTC (rev 166929)
@@ -1,3 +1,18 @@
+2014-04-08 Zalan Bujtas
+
+Subpixel rendering: Slow paint path for inlines should snap to device pixels.
+https://bugs.webkit.org/show_bug.cgi?id=131259
+
+Reviewed by Simon Fraser.
+
+InlineTextBox::paint needs to round to the same device pixel position as SimpleLineLayout does.
+
+Test: fast/inline/hidpi-slow-path-text-on-subpixel-position.html
+
+* rendering/InlineTextBox.cpp:
+(WebCore::InlineTextBox::paint):
+* rendering/TextPainter.h: Cleanup. No reason to have them as references here.
+
2014-04-07 Brent Fulgham
Keep 'webkitClosedCaptionsVisible' API in sync with captions display preferences
Modified: trunk/Source/WebCore/rendering/InlineTextBox.cpp (166928 => 166929)
--- trunk/Source/WebCore/rendering/InlineTextBox.cpp 2014-04-08 16:09:29 UTC (rev 166928)
+++ trunk/Source/WebCore/rendering/InlineTextBox.cpp 2014-04-08 16:19:56 UTC (rev 166929)
@@ -517,7 +517,7 @@
LayoutUnit paintEnd = isHorizontal() ? paintInfo.rect.maxX() : paintInfo.rect.maxY();
LayoutUnit paintStart = isHorizontal() ? paintInfo.rect.x() : paintInfo.rect.y();
-LayoutPoint adjustedPaintOffset = roundedIntPoint(paintOffset);
+FloatPoint adjustedPaintOffset = roundedForPainting(paintOffset, renderer().document().deviceSca
[webkit-changes] [166928] trunk/Source
Title: [166928] trunk/Source
Revision 166928
Author dba...@webkit.org
Date 2014-04-08 09:09:29 -0700 (Tue, 08 Apr 2014)
Log Message
Fallback to default storage session when there isn't a valid session ID
https://bugs.webkit.org/show_bug.cgi?id=131326
Reviewed by Alexey Proskuryakov.
Fixes and issue where we may use the wrong storage session after disabling
a private browsing session.
Currently WebKit1 and WebKit2 without NetworkProcess assume that there
is always a non-null private browsing storage session so long as the page
has a non-default session ID. Instead we should only use the private browsing
storage session when it's non-null and the page has a non-default session ID;
otherwise, we should use the default storage session. This change will make
the behavior in WebKit1 and WebKit2 without NetworkProcess consistent with
the behavior in WebKit2 with NetworkProcess.
Source/WebKit/mac:
* WebCoreSupport/WebFrameNetworkingContext.mm:
(WebFrameNetworkingContext::storageSession):
Source/WebKit2:
* WebProcess/WebCoreSupport/mac/WebFrameNetworkingContext.mm:
(WebKit::WebFrameNetworkingContext::storageSession):
Modified Paths
trunk/Source/WebKit/mac/ChangeLog
trunk/Source/WebKit/mac/WebCoreSupport/WebFrameNetworkingContext.mm
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/WebProcess/WebCoreSupport/mac/WebFrameNetworkingContext.mm
Diff
Modified: trunk/Source/WebKit/mac/ChangeLog (166927 => 166928)
--- trunk/Source/WebKit/mac/ChangeLog 2014-04-08 16:01:38 UTC (rev 166927)
+++ trunk/Source/WebKit/mac/ChangeLog 2014-04-08 16:09:29 UTC (rev 166928)
@@ -1,3 +1,25 @@
+2014-04-08 Daniel Bates
+
+Fallback to default storage session when there isn't a valid session ID
+https://bugs.webkit.org/show_bug.cgi?id=131326
+
+
+Reviewed by Alexey Proskuryakov.
+
+Fixes and issue where we may use the wrong storage session after disabling
+a private browsing session.
+
+Currently WebKit1 and WebKit2 without NetworkProcess assume that there
+is always a non-null private browsing storage session so long as the page
+has a non-default session ID. Instead we should only use the private browsing
+storage session when it's non-null and the page has a non-default session ID;
+otherwise, we should use the default storage session. This change will make
+the behavior in WebKit1 and WebKit2 without NetworkProcess consistent with
+the behavior in WebKit2 with NetworkProcess.
+
+* WebCoreSupport/WebFrameNetworkingContext.mm:
+(WebFrameNetworkingContext::storageSession):
+
2014-04-06 Sam Weinig
Document user content related APIs
Modified: trunk/Source/WebKit/mac/WebCoreSupport/WebFrameNetworkingContext.mm (166927 => 166928)
--- trunk/Source/WebKit/mac/WebCoreSupport/WebFrameNetworkingContext.mm 2014-04-08 16:01:38 UTC (rev 166927)
+++ trunk/Source/WebKit/mac/WebCoreSupport/WebFrameNetworkingContext.mm 2014-04-08 16:09:29 UTC (rev 166928)
@@ -112,9 +112,11 @@
NetworkStorageSession& WebFrameNetworkingContext::storageSession() const
{
ASSERT(isMainThread());
-
-if (frame() && frame()->page()->sessionID().isEphemeral())
-return *privateSession();
-
+if (frame() && frame()->page()->sessionID().isEphemeral()) {
+if (NetworkStorageSession* session = privateSession().get())
+return *session;
+// Some requests may still be coming shortly before WebCore updates the session ID and after WebKit destroys the private browsing session.
+LOG_ERROR("Invalid session ID. Please file a bug unless you just disabled private browsing, in which case it's an expected race.");
+}
return NetworkStorageSession::defaultStorageSession();
}
Modified: trunk/Source/WebKit2/ChangeLog (166927 => 166928)
--- trunk/Source/WebKit2/ChangeLog 2014-04-08 16:01:38 UTC (rev 166927)
+++ trunk/Source/WebKit2/ChangeLog 2014-04-08 16:09:29 UTC (rev 166928)
@@ -1,3 +1,25 @@
+2014-04-08 Daniel Bates
+
+Fallback to default storage session when there isn't a valid session ID
+https://bugs.webkit.org/show_bug.cgi?id=131326
+
+
+Reviewed by Alexey Proskuryakov.
+
+Fixes and issue where we may use the wrong storage session after disabling
+a private browsing session.
+
+Currently WebKit1 and WebKit2 without NetworkProcess assume that there
+is always a non-null private browsing storage session so long as the page
+has a non-default session ID. Instead we should only use the private browsing
+storage session when it's non-null and the page has a non-default session ID;
+otherwise, we should use the default storage session. This change will make
+the behavior in WebKit1 and WebKit2 without NetworkProcess consistent with
+the behavior in WebKit2 with NetworkProcess.
+
+* WebProcess/WebCoreSupport/mac/WebFrameNetworkingContext.mm:
+(WebKit
[webkit-changes] [166927] trunk/Source/WebCore
Title: [166927] trunk/Source/WebCore
Revision 166927
Author bfulg...@apple.com
Date 2014-04-08 09:01:38 -0700 (Tue, 08 Apr 2014)
Log Message
Keep 'webkitClosedCaptionsVisible' API in sync with captions display preferences
https://bugs.webkit.org/show_bug.cgi?id=131344
Reviewed by Eric Carlson.
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::configureTextTrackGroup) If we decide that captions should
be active (due to user preferences) make sure the 'webkitClosedCaptionsVisible' state
is turned on.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/HTMLMediaElement.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (166926 => 166927)
--- trunk/Source/WebCore/ChangeLog 2014-04-08 14:52:33 UTC (rev 166926)
+++ trunk/Source/WebCore/ChangeLog 2014-04-08 16:01:38 UTC (rev 166927)
@@ -1,3 +1,15 @@
+2014-04-07 Brent Fulgham
+
+Keep 'webkitClosedCaptionsVisible' API in sync with captions display preferences
+https://bugs.webkit.org/show_bug.cgi?id=131344
+
+Reviewed by Eric Carlson.
+
+* html/HTMLMediaElement.cpp:
+(WebCore::HTMLMediaElement::configureTextTrackGroup) If we decide that captions should
+be active (due to user preferences) make sure the 'webkitClosedCaptionsVisible' state
+is turned on.
+
2014-04-08 Zalan Bujtas
Subpixel rendering: Paint the filter effect result image on device pixel position.
Modified: trunk/Source/WebCore/html/HTMLMediaElement.cpp (166926 => 166927)
--- trunk/Source/WebCore/html/HTMLMediaElement.cpp 2014-04-08 14:52:33 UTC (rev 166926)
+++ trunk/Source/WebCore/html/HTMLMediaElement.cpp 2014-04-08 16:01:38 UTC (rev 166927)
@@ -3672,9 +3672,15 @@
}
}
-if (trackToEnable)
+if (trackToEnable) {
trackToEnable->setMode(TextTrack::showingKeyword());
+// If user preferences indicate we should always display captions, make sure we reflect the
+// proper status via the webkitClosedCaptionsVisible API call:
+if (!webkitClosedCaptionsVisible() && closedCaptionsVisible() && displayMode == CaptionUserPreferences::AlwaysOn)
+m_webkitLegacyClosedCaptionOverride = true;
+}
+
m_processingPreferenceChange = false;
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [166926] trunk
Title: [166926] trunk
Revision 166926
Author za...@apple.com
Date 2014-04-08 07:52:33 -0700 (Tue, 08 Apr 2014)
Log Message
Subpixel rendering: Paint the filter effect result image on device pixel position.
https://bugs.webkit.org/show_bug.cgi?id=131255
Reviewed by Simon Fraser.
This patch moves filter effect images from integral to device pixel position. However,
result images are still integral based.
Source/WebCore:
Test: css3/filters/hidpi-filter-is-on-subpixel-position.html
* rendering/FilterEffectRenderer.cpp:
(WebCore::FilterEffectRendererHelper::applyFilterEffect):
LayoutTests:
* css3/filters/hidpi-filter-is-on-subpixel-position-expected.html: Added.
* css3/filters/hidpi-filter-is-on-subpixel-position.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/FilterEffectRenderer.cpp
Added Paths
trunk/LayoutTests/css3/filters/hidpi-filter-is-on-subpixel-position-expected.html
trunk/LayoutTests/css3/filters/hidpi-filter-is-on-subpixel-position.html
Diff
Modified: trunk/LayoutTests/ChangeLog (166925 => 166926)
--- trunk/LayoutTests/ChangeLog 2014-04-08 14:50:38 UTC (rev 166925)
+++ trunk/LayoutTests/ChangeLog 2014-04-08 14:52:33 UTC (rev 166926)
@@ -1,5 +1,18 @@
2014-04-08 Zalan Bujtas
+Subpixel rendering: Paint the filter effect result image on device pixel position.
+https://bugs.webkit.org/show_bug.cgi?id=131255
+
+Reviewed by Simon Fraser.
+
+This patch moves filter effect images from integral to device pixel position. However,
+result images are still integral based.
+
+* css3/filters/hidpi-filter-is-on-subpixel-position-expected.html: Added.
+* css3/filters/hidpi-filter-is-on-subpixel-position.html: Added.
+
+2014-04-08 Zalan Bujtas
+
Subpixel rendering: Make border images device pixel aware.
https://bugs.webkit.org/show_bug.cgi?id=131209
Added: trunk/LayoutTests/css3/filters/hidpi-filter-is-on-subpixel-position-expected.html (0 => 166926)
--- trunk/LayoutTests/css3/filters/hidpi-filter-is-on-subpixel-position-expected.html (rev 0)
+++ trunk/LayoutTests/css3/filters/hidpi-filter-is-on-subpixel-position-expected.html 2014-04-08 14:52:33 UTC (rev 166926)
@@ -0,0 +1,40 @@
+
+
+
+This tests that filter effects don't push content to different position when RenderLayer is present.
+
+ p {
+position: fixed;
+display: -webkit-flex;
+-webkit-align-items: center;
+ }
+
+ div {
+width: 10px;
+height: 10px;
+background: black;
+border: 2px solid white;
+-webkit-filter: drop-shadow(black 0 0px 0px);
+ }
+
+
+
+
+
+ var container = document.getElementById("container");
+ w = 15; h = 15;
+ for (i = 0; i < 10; ++i) {
+for (j = 0; j < 10; ++j) {
+ var e = document.createElement("p");
+ e.style.top = ((w + 1) * i) + "px";
+ e.style.left = ((w + 1) * j) + "px";
+ e.style.height = h + "px";
+ e.appendChild(document.createElement("div"));
+ container.appendChild(e);
+ w+=1;
+ h+=1;
+}
+ }
+
+
+
Added: trunk/LayoutTests/css3/filters/hidpi-filter-is-on-subpixel-position.html (0 => 166926)
--- trunk/LayoutTests/css3/filters/hidpi-filter-is-on-subpixel-position.html (rev 0)
+++ trunk/LayoutTests/css3/filters/hidpi-filter-is-on-subpixel-position.html 2014-04-08 14:52:33 UTC (rev 166926)
@@ -0,0 +1,41 @@
+
+
+
+This tests that filter effects don't push content to different position when RenderLayer is present.
+
+ p {
+position: fixed;
+display: -webkit-flex;
+-webkit-align-items: center;
+ }
+
+ div {
+width: 10px;
+height: 10px;
+background: black;
+border: 2px solid white;
+-webkit-filter: drop-shadow(black 0 0px 0px);
+-webkit-transform: translateX(0);
+ }
+
+
+
+
+
+ var container = document.getElementById("container");
+ w = 15; h = 15;
+ for (i = 0; i < 10; ++i) {
+for (j = 0; j < 10; ++j) {
+ var e = document.createElement("p");
+ e.style.top = ((w + 1) * i) + "px";
+ e.style.left = ((w + 1) * j) + "px";
+ e.style.height = h + "px";
+ e.appendChild(document.createElement("div"));
+ container.appendChild(e);
+ w+=1;
+ h+=1;
+}
+ }
+
+
+
Modified: trunk/Source/WebCore/ChangeLog (166925 => 166926)
--- trunk/Source/WebCore/ChangeLog 2014-04-08 14:50:38 UTC (rev 166925)
+++ trunk/Source/WebCore/ChangeLog 2014-04-08 14:52:33 UTC (rev 166926)
@@ -1,5 +1,20 @@
2014-04-08 Zalan Bujtas
+Subpixel rendering: Paint the filter effect result image on device pixel position.
+https://bugs.webkit.org/show_bug.cgi?id=131255
+
+Reviewed by Simon Fraser.
+
+This patch moves filter effect images from integral to device pixel position. However,
+result images are still integral based.
+
+Test: css3/filters/hidpi-filter-is-on-subpixel-position.html
+
+* rendering/FilterEffe
[webkit-changes] [166925] trunk
Title: [166925] trunk
Revision 166925
Author za...@apple.com
Date 2014-04-08 07:50:38 -0700 (Tue, 08 Apr 2014)
Log Message
Subpixel rendering: Make border images device pixel aware.
https://bugs.webkit.org/show_bug.cgi?id=131209
Reviewed by Simon Fraser.
Snap border-image size and position to device pixels. It works both on generated and bitmap images.
Source/WebCore:
Test: fast/borders/hidpi-border-image-gradient-on-subpixels.html
* rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::paintNinePieceImage):
LayoutTests:
* fast/borders/hidpi-border-image-gradient-on-subpixels-expected.html: Added.
* fast/borders/hidpi-border-image-gradient-on-subpixels.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderBoxModelObject.cpp
Added Paths
trunk/LayoutTests/fast/borders/hidpi-border-image-gradient-on-subpixels-expected.html
trunk/LayoutTests/fast/borders/hidpi-border-image-gradient-on-subpixels.html
Diff
Modified: trunk/LayoutTests/ChangeLog (166924 => 166925)
--- trunk/LayoutTests/ChangeLog 2014-04-08 12:09:51 UTC (rev 166924)
+++ trunk/LayoutTests/ChangeLog 2014-04-08 14:50:38 UTC (rev 166925)
@@ -1,3 +1,15 @@
+2014-04-08 Zalan Bujtas
+
+Subpixel rendering: Make border images device pixel aware.
+https://bugs.webkit.org/show_bug.cgi?id=131209
+
+Reviewed by Simon Fraser.
+
+Snap border-image size and position to device pixels. It works both on generated and bitmap images.
+
+* fast/borders/hidpi-border-image-gradient-on-subpixels-expected.html: Added.
+* fast/borders/hidpi-border-image-gradient-on-subpixels.html: Added.
+
2014-04-08 Youenn Fablet
[SOUP] Control cookie management according ResourceRequest.allowCookies()
Added: trunk/LayoutTests/fast/borders/hidpi-border-image-gradient-on-subpixels-expected.html (0 => 166925)
--- trunk/LayoutTests/fast/borders/hidpi-border-image-gradient-on-subpixels-expected.html (rev 0)
+++ trunk/LayoutTests/fast/borders/hidpi-border-image-gradient-on-subpixels-expected.html 2014-04-08 14:50:38 UTC (rev 166925)
@@ -0,0 +1,36 @@
+
+
+
+This tests that border images sized and positioned properly on subpixels.
+
+ div {
+border-width:0px 0px 0px 0.5px;
+border-color: black;
+border-style: solid;
+position: fixed;
+ }
+
+
+
+
+
+ var container = document.getElementById("container");
+ w=5; h=5;
+ for (i = 0; i < 15; ++i) {
+b = 0;
+for (j = 0; j < 15; ++j) {
+ var e = document.createElement("div");
+ e.style.top = ((w + 1) * i) + "px";
+ e.style.left = ((w + 1) * j) + "px";
+ e.style.width = w + "px";
+ e.style.height = h + "px";
+ e.style.borderLeftWidth = b + "px";
+ container.appendChild(e);
+ w+=0.1;
+ h+=0.1;
+ b+=0.5;
+}
+ }
+
+
+
Added: trunk/LayoutTests/fast/borders/hidpi-border-image-gradient-on-subpixels.html (0 => 166925)
--- trunk/LayoutTests/fast/borders/hidpi-border-image-gradient-on-subpixels.html (rev 0)
+++ trunk/LayoutTests/fast/borders/hidpi-border-image-gradient-on-subpixels.html 2014-04-08 14:50:38 UTC (rev 166925)
@@ -0,0 +1,35 @@
+
+
+
+This tests that border images sized and positioned properly on subpixels.
+
+ div {
+border-width:0px 0px 0px 0.5px;
+position: fixed;
+-webkit-border-image: -webkit-linear-gradient(black, black) 1 100%;
+ }
+
+
+
+
+
+ var container = document.getElementById("container");
+ w=5; h=5;
+ for (i = 0; i < 15; ++i) {
+b = 0;
+for (j = 0; j < 15; ++j) {
+ var e = document.createElement("div");
+ e.style.top = ((w + 1) * i) + "px";
+ e.style.left = ((w + 1) * j) + "px";
+ e.style.width = w + "px";
+ e.style.height = h + "px";
+ e.style.borderLeftWidth = b + "px";
+ container.appendChild(e);
+ w+=0.1;
+ h+=0.1;
+ b+=0.5;
+}
+ }
+
+
+
Modified: trunk/Source/WebCore/ChangeLog (166924 => 166925)
--- trunk/Source/WebCore/ChangeLog 2014-04-08 12:09:51 UTC (rev 166924)
+++ trunk/Source/WebCore/ChangeLog 2014-04-08 14:50:38 UTC (rev 166925)
@@ -1,3 +1,17 @@
+2014-04-08 Zalan Bujtas
+
+Subpixel rendering: Make border images device pixel aware.
+https://bugs.webkit.org/show_bug.cgi?id=131209
+
+Reviewed by Simon Fraser.
+
+Snap border-image size and position to device pixels. It works both on generated and bitmap images.
+
+Test: fast/borders/hidpi-border-image-gradient-on-subpixels.html
+
+* rendering/RenderBoxModelObject.cpp:
+(WebCore::RenderBoxModelObject::paintNinePieceImage):
+
2014-04-08 Youenn Fablet
[SOUP] Control cookie management according ResourceRequest.allowCookies()
Modified: trunk/Source/WebCore/rendering/RenderBoxModelObject.cpp (166924 => 166925)
--- trunk/Source/WebCore/rendering/RenderBoxModelObject.cpp 2014-04-08 12:09:51 UTC (rev 166924)
+++ trunk/Sou
[webkit-changes] [166924] trunk
Title: [166924] trunk Revision 166924 Author commit-qu...@webkit.org Date 2014-04-08 05:09:51 -0700 (Tue, 08 Apr 2014) Log Message [SOUP] Control cookie management according ResourceRequest.allowCookies() https://bugs.webkit.org/show_bug.cgi?id=131026 Patch by Youenn Fablet on 2014-04-08 Reviewed by Sergio Villar Senin. Source/WebCore: Added per soup-message disabling of cookie jar manager when related ResourceRequest does not allow cookies (e.g. some cross-origin requests). Patch is covered by unskipped test http/tests/xmlhttprequest/cross-origin-cookie-storage.html. * platform/network/soup/ResourceRequestSoup.cpp: (WebCore::ResourceRequest::updateSoupMessageMembers): Added disabling of cookie jar manager if cookies are not allowed. Source/WebKit2: Added setting of accept cookies policy for the current soup network session cookie jar and all tracked sessions. Moved the implementation of cookie policy setting from WebCookieManager to WebFrameNetworkingContext. * WebProcess/Cookies/soup/WebCookieManagerSoup.cpp: (WebKit::WebCookieManager::platformSetHTTPCookieAcceptPolicy): Moved implementation to WebCookieManager::platformSetHTTPCookieAcceptPolicy. * WebProcess/WebCoreSupport/soup/WebFrameNetworkingContext.cpp: (WebKit::WebFrameNetworkingContext::setCookieAcceptPolicyForAllContexts): Moved implementation from WebCookieManager::platformSetHTTPCookieAcceptPolicy and set the cookie jar accept policy to the cookie jars of all sessions in addition to the default cookie jar. * WebProcess/WebCoreSupport/soup/WebFrameNetworkingContext.h: Added method prototype. LayoutTests: * platform/efl/TestExpectations: Unskipped test http/tests/xmlhttprequest/cross-origin-cookie-storage.html. * platform/gtk/TestExpectations: Ditto. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/efl/TestExpectations trunk/LayoutTests/platform/gtk/TestExpectations trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/platform/network/soup/ResourceRequestSoup.cpp trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/WebProcess/Cookies/soup/WebCookieManagerSoup.cpp trunk/Source/WebKit2/WebProcess/WebCoreSupport/soup/WebFrameNetworkingContext.cpp trunk/Source/WebKit2/WebProcess/WebCoreSupport/soup/WebFrameNetworkingContext.h Diff Modified: trunk/LayoutTests/ChangeLog (166923 => 166924) --- trunk/LayoutTests/ChangeLog 2014-04-08 12:05:33 UTC (rev 166923) +++ trunk/LayoutTests/ChangeLog 2014-04-08 12:09:51 UTC (rev 166924) @@ -1,3 +1,13 @@ +2014-04-08 Youenn Fablet + +[SOUP] Control cookie management according ResourceRequest.allowCookies() +https://bugs.webkit.org/show_bug.cgi?id=131026 + +Reviewed by Sergio Villar Senin. + +* platform/efl/TestExpectations: Unskipped test http/tests/xmlhttprequest/cross-origin-cookie-storage.html. +* platform/gtk/TestExpectations: Ditto. + 2014-04-08 Sergio Villar Senin [CSS Grid Layout] Handle min/max height in the grid element Modified: trunk/LayoutTests/platform/efl/TestExpectations (166923 => 166924) --- trunk/LayoutTests/platform/efl/TestExpectations 2014-04-08 12:05:33 UTC (rev 166923) +++ trunk/LayoutTests/platform/efl/TestExpectations 2014-04-08 12:09:51 UTC (rev 166924) @@ -237,7 +237,6 @@ http/tests/security/xss-DENIED-xsl-document-redirect.xml http/tests/security/xss-DENIED-xsl-external-entity-redirect.xml http/tests/xmlhttprequest/access-control-basic-whitelist-request-headers.html -http/tests/xmlhttprequest/cross-origin-cookie-storage.html http/tests/xmlhttprequest/cross-origin-no-authorization.html http/tests/xmlhttprequest/logout.html http/tests/xmlhttprequest/redirect-cross-origin-tripmine.html Modified: trunk/LayoutTests/platform/gtk/TestExpectations (166923 => 166924) --- trunk/LayoutTests/platform/gtk/TestExpectations 2014-04-08 12:05:33 UTC (rev 166923) +++ trunk/LayoutTests/platform/gtk/TestExpectations 2014-04-08 12:09:51 UTC (rev 166924) @@ -1253,8 +1253,6 @@ Bug(GTK) http/tests/xmlhttprequest/logout.html [ Failure ] -# We don't seem to support neither of these for now -Bug(GTK) http/tests/xmlhttprequest/cross-origin-cookie-storage.html [ Failure ] Bug(GTK) http/tests/xmlhttprequest/cross-origin-no-authorization.html [ Failure ] Bug(GTK) media/video-size-intrinsic-scale.html [ Failure ] Modified: trunk/Source/WebCore/ChangeLog (166923 => 166924) --- trunk/Source/WebCore/ChangeLog 2014-04-08 12:05:33 UTC (rev 166923) +++ trunk/Source/WebCore/ChangeLog 2014-04-08 12:09:51 UTC (rev 166924) @@ -1,3 +1,17 @@ +2014-04-08 Youenn Fablet + +[SOUP] Control cookie management according ResourceRequest.allowCookies() +https://bugs.webkit.org/show_bug.cgi?id=131026 + +Reviewed by Sergio Villar Senin. + +Added per soup-message disabling of cookie jar manager when related ResourceRequest does not allow cookies (e.g. some cross-origin requests). + +Patch is covered by unskipped test http/tests/xmlhttprequest/cross-origin-cookie-storage.html
[webkit-changes] [166921] trunk/Source/WebCore
Title: [166921] trunk/Source/WebCore
Revision 166921
Author commit-qu...@webkit.org
Date 2014-04-08 02:15:06 -0700 (Tue, 08 Apr 2014)
Log Message
Buildfix after r166917
https://bugs.webkit.org/show_bug.cgi?id=131351
Patch by Zsolt Borbely on 2014-04-08
Reviewed by Andrei Bucur.
* accessibility/AccessibilityNodeObject.cpp:
(WebCore::accessibleNameForNode):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/accessibility/AccessibilityNodeObject.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (166920 => 166921)
--- trunk/Source/WebCore/ChangeLog 2014-04-08 08:58:43 UTC (rev 166920)
+++ trunk/Source/WebCore/ChangeLog 2014-04-08 09:15:06 UTC (rev 166921)
@@ -1,3 +1,13 @@
+2014-04-08 Zsolt Borbely
+
+Buildfix after r166917
+https://bugs.webkit.org/show_bug.cgi?id=131351
+
+Reviewed by Andrei Bucur.
+
+* accessibility/AccessibilityNodeObject.cpp:
+(WebCore::accessibleNameForNode):
+
2014-04-08 Darin Adler
Fix assertions triggered by CSS calc changes in r166860
Modified: trunk/Source/WebCore/accessibility/AccessibilityNodeObject.cpp (166920 => 166921)
--- trunk/Source/WebCore/accessibility/AccessibilityNodeObject.cpp 2014-04-08 08:58:43 UTC (rev 166920)
+++ trunk/Source/WebCore/accessibility/AccessibilityNodeObject.cpp 2014-04-08 09:15:06 UTC (rev 166921)
@@ -1848,7 +1848,7 @@
// ARIA Implementer's Guide.
static String accessibleNameForNode(Node* node)
{
-assert(node);
+ASSERT(node);
if (!node || !node->isElementNode())
return String();
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [166920] trunk/Source/WebCore
Title: [166920] trunk/Source/WebCore Revision 166920 Author da...@apple.com Date 2014-04-08 01:58:43 -0700 (Tue, 08 Apr 2014) Log Message Fix assertions triggered by CSS calc changes in r166860 https://bugs.webkit.org/show_bug.cgi?id=131346 Reviewed by Andrei Bucur. * css/CSSComputedStyleDeclaration.cpp: (WebCore::getBorderRadiusCornerValues): Use isPercentNotCalculated() instead of type() == Percent; no behavior change. (WebCore::getBorderRadiusCornerValue): Ditto. (WebCore::lineHeightFromStyle): Use isPercentNotCalculated() before code that calls percent(), which won't work for a calculated length. * css/DeprecatedStyleBuilder.cpp: (WebCore::ApplyPropertyBorderRadius::applyValue): Use isNegative and isZero rather than calling value() unconditionally. Should make calculated values work better. * html/HTMLPlugInImageElement.cpp: (WebCore::is100Percent): Use isPercentNotCalculated() before code that calls percent(), which won't work for a calculated length. * platform/Length.cpp: (WebCore::CalculationValueMap::deref): Use adoptRef here instead of calling deref immediately, so the deref will happen after calling remove. This makes the code work properly even if it's reentered inside the calculation value's destructor. * platform/Length.h: (WebCore::Length::percent): Change assert to isPercentNotCalculated, since the value function this calls only works for non-calculated values anyway. (WebCore::Length::isPercentNotCalculated): Added. (WebCore::Length::isPercent): Changed to call isPercentNotCalculated. (WebCore::Length::isSpecified): Changed to call isPercent. * platform/graphics/transforms/TranslateTransformOperation.h: (WebCore::TranslateTransformOperation::apply): Use isPercentNotCalculated() instead of type() == Percent; no behavior change. * rendering/AutoTableLayout.cpp: (WebCore::AutoTableLayout::recalcColumn): Use isPercentNotCalculated() before code that calls value() or percent(), which won't work for a calculated length. (WebCore::AutoTableLayout::computeIntrinsicLogicalWidths): Ditto. (WebCore::AutoTableLayout::calcEffectiveLogicalWidth): Ditto. (WebCore::AutoTableLayout::layout): Ditto. * rendering/FixedTableLayout.cpp: (WebCore::FixedTableLayout::layout): Ditto. * rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::calculateImageIntrinsicDimensions): Ditto. * rendering/RenderTableSection.cpp: (WebCore::updateLogicalHeightForCell): Ditto. (WebCore::RenderTableSection::distributeExtraLogicalHeightToPercentRows): Ditto. (WebCore::RenderTableSection::distributeExtraLogicalHeightToRows): Ditto. * rendering/style/RenderStyle.cpp: (WebCore::requireTransformOrigin): Use modern for loop. Also marked function static, since it's private to this file. (WebCore::RenderStyle::applyTransform): Use isPercentNotCalculated() instead of type() == Percent; no behavior change. Also use a modern for loop and auto& to avoid a really long type name. * rendering/svg/RenderSVGRoot.cpp: (WebCore::RenderSVGRoot::computeIntrinsicRatioInformation): Use isPercentNotCalculated() before code that calls percent(), which won't work for a calculated length. * platform/Length.h: (WebCore::Length::percent): (WebCore::Length::isPercentNotCalculated): (WebCore::Length::isPercent): (WebCore::Length::isSpecified): * platform/graphics/transforms/TranslateTransformOperation.h: (WebCore::TranslateTransformOperation::apply): * rendering/AutoTableLayout.cpp: (WebCore::AutoTableLayout::recalcColumn): (WebCore::AutoTableLayout::computeIntrinsicLogicalWidths): (WebCore::AutoTableLayout::calcEffectiveLogicalWidth): (WebCore::AutoTableLayout::layout): * rendering/FixedTableLayout.cpp: (WebCore::FixedTableLayout::layout): * rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::calculateImageIntrinsicDimensions): * rendering/RenderTableSection.cpp: (WebCore::updateLogicalHeightForCell): (WebCore::RenderTableSection::distributeExtraLogicalHeightToPercentRows): (WebCore::RenderTableSection::distributeExtraLogicalHeightToRows): * rendering/style/RenderStyle.cpp: (WebCore::requireTransformOrigin): (WebCore::RenderStyle::applyTransform): * rendering/svg/RenderSVGRoot.cpp: (WebCore::RenderSVGRoot::computeIntrinsicRatioInformation): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/css/CSSComputedStyleDeclaration.cpp trunk/Source/WebCore/css/DeprecatedStyleBuilder.cpp trunk/Source/WebCore/html/HTMLPlugInImageElement.cpp trunk/Source/WebCore/platform/Length.cpp trunk/Source/WebCore/platform/Length.h trunk/Source/WebCore/platform/graphics/transforms/TranslateTransformOperation.h trunk/Source/WebCore/rendering/AutoTableLayout.cpp trunk/Source/WebCore/rendering/FixedTableLayout.cpp trunk/Source/WebCore/rendering/RenderBoxModelObject.cpp trunk/Source/WebCore/rendering/RenderTableSection.cpp trunk/Source/WebCore/rendering/style/RenderStyle.cpp trunk/Source/WebCore/rendering/svg/RenderSVGRoot.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (166919 => 166920) --- trunk/Source/WebCore/
[webkit-changes] [166919] trunk/Source/WebCore
Title: [166919] trunk/Source/WebCore
Revision 166919
Author calva...@igalia.com
Date 2014-04-08 01:15:39 -0700 (Tue, 08 Apr 2014)
Log Message
[GTK] Remove media controls dead code
https://bugs.webkit.org/show_bug.cgi?id=131300
Reviewed by Eric Carlson.
MediaControlsGtk.cpp is no longer used so we can remove it from
the repo.
No new tests needed.
* PlatformGTK.cmake: Remove html/shadow/MediaControlsGtk.cpp from
compilation.
* html/shadow/MediaControlsGtk.cpp: Removed.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/PlatformGTK.cmake
Removed Paths
trunk/Source/WebCore/html/shadow/MediaControlsGtk.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (166918 => 166919)
--- trunk/Source/WebCore/ChangeLog 2014-04-08 08:13:11 UTC (rev 166918)
+++ trunk/Source/WebCore/ChangeLog 2014-04-08 08:15:39 UTC (rev 166919)
@@ -1,3 +1,19 @@
+2014-04-08 Xabier Rodriguez Calvar
+
+[GTK] Remove media controls dead code
+https://bugs.webkit.org/show_bug.cgi?id=131300
+
+Reviewed by Eric Carlson.
+
+MediaControlsGtk.cpp is no longer used so we can remove it from
+the repo.
+
+No new tests needed.
+
+* PlatformGTK.cmake: Remove html/shadow/MediaControlsGtk.cpp from
+compilation.
+* html/shadow/MediaControlsGtk.cpp: Removed.
+
2014-04-08 Mihnea Ovidenie
[CSSRegions] Fixed positioned elements in named flows have fragmented content
Modified: trunk/Source/WebCore/PlatformGTK.cmake (166918 => 166919)
--- trunk/Source/WebCore/PlatformGTK.cmake 2014-04-08 08:13:11 UTC (rev 166918)
+++ trunk/Source/WebCore/PlatformGTK.cmake 2014-04-08 08:15:39 UTC (rev 166919)
@@ -27,8 +27,6 @@
list(APPEND WebCore_SOURCES
editing/SmartReplace.cpp
-html/shadow/MediaControlsGtk.cpp
-
loader/soup/CachedRawResourceSoup.cpp
loader/soup/SubresourceLoaderSoup.cpp
Deleted: trunk/Source/WebCore/html/shadow/MediaControlsGtk.cpp (166918 => 166919)
--- trunk/Source/WebCore/html/shadow/MediaControlsGtk.cpp 2014-04-08 08:13:11 UTC (rev 166918)
+++ trunk/Source/WebCore/html/shadow/MediaControlsGtk.cpp 2014-04-08 08:15:39 UTC (rev 166919)
@@ -1,378 +0,0 @@
-/*
- * Copyright (C) 2007, 2008, 2009, 2010 Apple Inc. All rights reserved.
- * Copyright (C) 2011, 2012 Google Inc. All rights reserved.
- * Copyright (C) 2012 Zan Dobersek
- * Copyright (C) 2012 Igalia S.L.
- *
- * Redistribution and use in source and binary forms, with or without
- * modification, are permitted provided that the following conditions
- * are met:
- * 1. Redistributions of source code must retain the above copyright
- *notice, this list of conditions and the following disclaimer.
- * 2. Redistributions in binary form must reproduce the above copyright
- *notice, this list of conditions and the following disclaimer in the
- *documentation and/or other materials provided with the distribution.
- *
- * THIS SOFTWARE IS PROVIDED BY APPLE INC. ``AS IS'' AND ANY
- * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
- * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
- * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR
- * CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL,
- * EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO,
- * PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR
- * PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY
- * OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
- * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
- * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
- */
-
-#include "config.h"
-
-#if ENABLE(VIDEO)
-#include "MediaControlsGtk.h"
-
-namespace WebCore {
-
-class MediaControlsGtkEventListener : public EventListener {
-public:
-static PassRefPtr create(MediaControlsGtk* mediaControls) { return adoptRef(new MediaControlsGtkEventListener(mediaControls)); }
-static const MediaControlsGtkEventListener* cast(const EventListener* listener)
-{
-return listener->type() == GObjectEventListenerType
-? static_cast(listener)
-: 0;
-}
-
-virtual bool operator==(const EventListener& other);
-
-private:
-MediaControlsGtkEventListener(MediaControlsGtk* mediaControls)
-: EventListener(GObjectEventListenerType)
-, m_mediaControls(mediaControls)
-{
-}
-
-virtual void handleEvent(ScriptExecutionContext*, Event*);
-
-MediaControlsGtk* m_mediaControls;
-};
-
-MediaControlsGtk::MediaControlsGtk(Document& document)
-: MediaControls(document)
-, m_durationDisplay(0)
-, m_enclosure(0)
-, m_closedCaptionsTrackList(0)
-, m_closedCaptionsContainer(0)
-, m_eventListener(0)
-{
-}
-
-PassRefPtr MediaControls::create(Document& document)
-{
-return MediaControlsGtk::createControls(document);
-}
-
-PassRefPtr MediaControlsGtk::createControls(Document& docume
[webkit-changes] [166917] trunk
Title: [166917] trunk Revision 166917 Author cfleiz...@apple.com Date 2014-04-08 00:59:22 -0700 (Tue, 08 Apr 2014) Log Message Regression: AX: image labels no longer exposed to AX API in SVG test case https://bugs.webkit.org/show_bug.cgi?id=131208 Reviewed by Daniel Bates. Source/WebCore: accessibleNameForNode should work on any Element, not just HTML elements. Test: accessibility/svg-labelledby.html * accessibility/AccessibilityNodeObject.cpp: (WebCore::accessibleNameForNode): LayoutTests: * accessibility/svg-labelledby-expected.txt: Added. * accessibility/svg-labelledby.html: Added. Modified Paths trunk/LayoutTests/ChangeLog trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/accessibility/AccessibilityNodeObject.cpp Added Paths trunk/LayoutTests/accessibility/svg-labelledby-expected.txt trunk/LayoutTests/accessibility/svg-labelledby.html Diff Modified: trunk/LayoutTests/ChangeLog (166916 => 166917) --- trunk/LayoutTests/ChangeLog 2014-04-08 07:37:37 UTC (rev 166916) +++ trunk/LayoutTests/ChangeLog 2014-04-08 07:59:22 UTC (rev 166917) @@ -1,3 +1,13 @@ +2014-04-07 Chris Fleizach + +Regression: AX: image labels no longer exposed to AX API in SVG test case +https://bugs.webkit.org/show_bug.cgi?id=131208 + +Reviewed by Daniel Bates. + +* accessibility/svg-labelledby-expected.txt: Added. +* accessibility/svg-labelledby.html: Added. + 2014-04-07 Martin Robinson Skipped some HighDPI tests for GTK+ Added: trunk/LayoutTests/accessibility/svg-labelledby-expected.txt (0 => 166917) --- trunk/LayoutTests/accessibility/svg-labelledby-expected.txt (rev 0) +++ trunk/LayoutTests/accessibility/svg-labelledby-expected.txt 2014-04-08 07:59:22 UTC (rev 166917) @@ -0,0 +1,11 @@ + +This tests that aria-labelledby works on SVG elements. + +On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE". + + +SVG Element: AXDescription: Sudan +PASS successfullyParsed is true + +TEST COMPLETE + Added: trunk/LayoutTests/accessibility/svg-labelledby.html (0 => 166917) --- trunk/LayoutTests/accessibility/svg-labelledby.html (rev 0) +++ trunk/LayoutTests/accessibility/svg-labelledby.html 2014-04-08 07:59:22 UTC (rev 166917) @@ -0,0 +1,38 @@ + + + + + + + + + + + +