[webkit-changes] [174419] trunk
Title: [174419] trunk Revision 174419 Author commit-qu...@webkit.org Date 2014-10-07 23:37:40 -0700 (Tue, 07 Oct 2014) Log Message [EFL] Enable custom URI schemes with CustomProtocols https://bugs.webkit.org/show_bug.cgi?id=128177 Patch by Pascal Jacquemart on 2014-10-07 Reviewed by Gyuyoung Kim. Fixing ewk_context_url_scheme_register() ewebkit2 API rely on r162449 - CustomProtocols implementation from Carlos Garcia Campos .: * Source/cmake/OptionsEfl.cmake: Forcing CUSTOM_PROTOCOLS flag Source/WebKit2: * PlatformEfl.cmake: * UIProcess/API/efl/ewk_context.h: * UIProcess/API/efl/ewk_url_scheme_request.cpp: (EwkUrlSchemeRequest::EwkUrlSchemeRequest): (EwkUrlSchemeRequest::finish): * UIProcess/API/efl/ewk_url_scheme_request_private.h: (EwkUrlSchemeRequest::create): * UIProcess/API/efl/tests/test_ewk2_context.cpp: (TEST_F): * UIProcess/Network/CustomProtocols/soup/WebSoupCustomProtocolRequestManager.cpp: * UIProcess/efl/RequestManagerClientEfl.cpp: (WebKit::RequestManagerClientEfl::RequestManagerClientEfl): (WebKit::RequestManagerClientEfl::startLoading): (WebKit::RequestManagerClientEfl::stopLoading): (WebKit::RequestManagerClientEfl::registerURLSchemeHandler): (WebKit::EwkUrlSchemeHandler::EwkUrlSchemeHandler): Deleted. (WebKit::RequestManagerClientEfl::didReceiveURIRequest): Deleted. * UIProcess/efl/RequestManagerClientEfl.h: * UIProcess/efl/WebContextEfl.cpp: (WebKit::WebContext::platformInitializeWebProcess): * UIProcess/soup/WebContextSoup.cpp: (WebKit::WebContext::platformInitializeNetworkProcess): Modified Paths trunk/ChangeLog trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/PlatformEfl.cmake trunk/Source/WebKit2/UIProcess/API/efl/ewk_context.h trunk/Source/WebKit2/UIProcess/API/efl/ewk_url_scheme_request.cpp trunk/Source/WebKit2/UIProcess/API/efl/ewk_url_scheme_request_private.h trunk/Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_context.cpp trunk/Source/WebKit2/UIProcess/Network/CustomProtocols/soup/WebSoupCustomProtocolRequestManager.cpp trunk/Source/WebKit2/UIProcess/efl/RequestManagerClientEfl.cpp trunk/Source/WebKit2/UIProcess/efl/RequestManagerClientEfl.h trunk/Source/WebKit2/UIProcess/efl/WebContextEfl.cpp trunk/Source/WebKit2/UIProcess/soup/WebContextSoup.cpp trunk/Source/cmake/OptionsEfl.cmake Diff Modified: trunk/ChangeLog (174418 => 174419) --- trunk/ChangeLog 2014-10-08 05:36:24 UTC (rev 174418) +++ trunk/ChangeLog 2014-10-08 06:37:40 UTC (rev 174419) @@ -1,3 +1,15 @@ +2014-10-07 Pascal Jacquemart + +[EFL] Enable custom URI schemes with CustomProtocols +https://bugs.webkit.org/show_bug.cgi?id=128177 + +Reviewed by Gyuyoung Kim. + +Fixing ewk_context_url_scheme_register() ewebkit2 API +rely on r162449 - CustomProtocols implementation from Carlos Garcia Campos + +* Source/cmake/OptionsEfl.cmake: Forcing CUSTOM_PROTOCOLS flag + 2014-10-01 Michael Catanzaro Bump version to 2.7.0 Modified: trunk/Source/WebKit2/ChangeLog (174418 => 174419) --- trunk/Source/WebKit2/ChangeLog 2014-10-08 05:36:24 UTC (rev 174418) +++ trunk/Source/WebKit2/ChangeLog 2014-10-08 06:37:40 UTC (rev 174419) @@ -1,3 +1,36 @@ +2014-10-07 Pascal Jacquemart + +[EFL] Enable custom URI schemes with CustomProtocols +https://bugs.webkit.org/show_bug.cgi?id=128177 + +Reviewed by Gyuyoung Kim. + +Fixing ewk_context_url_scheme_register() ewebkit2 API +rely on r162449 - CustomProtocols implementation from Carlos Garcia Campos + +* PlatformEfl.cmake: +* UIProcess/API/efl/ewk_context.h: +* UIProcess/API/efl/ewk_url_scheme_request.cpp: +(EwkUrlSchemeRequest::EwkUrlSchemeRequest): +(EwkUrlSchemeRequest::finish): +* UIProcess/API/efl/ewk_url_scheme_request_private.h: +(EwkUrlSchemeRequest::create): +* UIProcess/API/efl/tests/test_ewk2_context.cpp: +(TEST_F): +* UIProcess/Network/CustomProtocols/soup/WebSoupCustomProtocolRequestManager.cpp: +* UIProcess/efl/RequestManagerClientEfl.cpp: +(WebKit::RequestManagerClientEfl::RequestManagerClientEfl): +(WebKit::RequestManagerClientEfl::startLoading): +(WebKit::RequestManagerClientEfl::stopLoading): +(WebKit::RequestManagerClientEfl::registerURLSchemeHandler): +(WebKit::EwkUrlSchemeHandler::EwkUrlSchemeHandler): Deleted. +(WebKit::RequestManagerClientEfl::didReceiveURIRequest): Deleted. +* UIProcess/efl/RequestManagerClientEfl.h: +* UIProcess/efl/WebContextEfl.cpp: +(WebKit::WebContext::platformInitializeWebProcess): +* UIProcess/soup/WebContextSoup.cpp: +(WebKit::WebContext::platformInitializeNetworkProcess): + 2014-10-07 Sungmann Cho Remove WKPageCreateSnapshotOfVisibleContent API. Modified: trunk/Source/WebKit2/PlatformEfl.cmake (174418 => 174419) --- trunk/Source/WebKit2/PlatformEfl.cmake 2014-10-08 05:36:24 UTC (rev 174418) +++ trunk/Source/WebKit2/PlatformEfl
[webkit-changes] [174418] trunk/Tools
Title: [174418] trunk/Tools
Revision 174418
Author commit-qu...@webkit.org
Date 2014-10-07 22:36:24 -0700 (Tue, 07 Oct 2014)
Log Message
Remove build warnings in Hashmap API tests
https://bugs.webkit.org/show_bug.cgi?id=137484
Patch by Tanay C on 2014-10-07
Reviewed by Darin Adler.
* TestWebKitAPI/Tests/WTF/HashMap.cpp:
(TestWebKitAPI::TEST): Changed EXPECT_EQ(false, addResult.isNewEntry) to EXPECT_FALSE(addResult.isNewEntry)
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WTF/HashMap.cpp
Diff
Modified: trunk/Tools/ChangeLog (174417 => 174418)
--- trunk/Tools/ChangeLog 2014-10-08 05:17:29 UTC (rev 174417)
+++ trunk/Tools/ChangeLog 2014-10-08 05:36:24 UTC (rev 174418)
@@ -1,3 +1,13 @@
+2014-10-07 Tanay C
+
+Remove build warnings in Hashmap API tests
+https://bugs.webkit.org/show_bug.cgi?id=137484
+
+Reviewed by Darin Adler.
+
+* TestWebKitAPI/Tests/WTF/HashMap.cpp:
+(TestWebKitAPI::TEST): Changed EXPECT_EQ(false, addResult.isNewEntry) to EXPECT_FALSE(addResult.isNewEntry)
+
2014-10-07 Jake Nielsen
Commit queue doesn't drop obsolete patches sometimes
Modified: trunk/Tools/TestWebKitAPI/Tests/WTF/HashMap.cpp (174417 => 174418)
--- trunk/Tools/TestWebKitAPI/Tests/WTF/HashMap.cpp 2014-10-08 05:17:29 UTC (rev 174417)
+++ trunk/Tools/TestWebKitAPI/Tests/WTF/HashMap.cpp 2014-10-08 05:36:24 UTC (rev 174418)
@@ -447,7 +447,7 @@
{
RefPtr ptr2(&a);
auto addResult = map.add(ptr2, 0);
-EXPECT_EQ(false, addResult.isNewEntry);
+EXPECT_FALSE(addResult.isNewEntry);
}
EXPECT_STREQ("ref(a) deref(a) ", takeLogStr().c_str());
@@ -469,7 +469,7 @@
{
RefPtr ptr2(&a);
auto addResult = map.add(ptr2.release(), 0);
-EXPECT_EQ(false, addResult.isNewEntry);
+EXPECT_FALSE(addResult.isNewEntry);
}
EXPECT_STREQ("ref(a) deref(a) ", takeLogStr().c_str());
@@ -491,7 +491,7 @@
{
RefPtr ptr2(&a);
auto addResult = map.add(WTF::move(ptr2), 0);
-EXPECT_EQ(false, addResult.isNewEntry);
+EXPECT_FALSE(addResult.isNewEntry);
}
EXPECT_STREQ("ref(a) deref(a) ", takeLogStr().c_str());
@@ -556,7 +556,7 @@
{
RefPtr ptr2(&a);
auto addResult = map.set(ptr2, 1);
-EXPECT_EQ(false, addResult.isNewEntry);
+EXPECT_FALSE(addResult.isNewEntry);
EXPECT_EQ(1, map.get(ptr.get()));
}
@@ -577,7 +577,7 @@
{
RefPtr ptr2(&a);
auto addResult = map.set(ptr2.release(), 1);
-EXPECT_EQ(false, addResult.isNewEntry);
+EXPECT_FALSE(addResult.isNewEntry);
EXPECT_EQ(1, map.get(ptr.get()));
}
@@ -598,7 +598,7 @@
{
RefPtr ptr2(&a);
auto addResult = map.set(WTF::move(ptr2), 1);
-EXPECT_EQ(false, addResult.isNewEntry);
+EXPECT_FALSE(addResult.isNewEntry);
EXPECT_EQ(1, map.get(ptr.get()));
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [174417] trunk/Source/WebKit2
Title: [174417] trunk/Source/WebKit2
Revision 174417
Author commit-qu...@webkit.org
Date 2014-10-07 22:17:29 -0700 (Tue, 07 Oct 2014)
Log Message
Remove WKPageCreateSnapshotOfVisibleContent API.
https://bugs.webkit.org/show_bug.cgi?id=66979
Patch by Sungmann Cho on 2014-10-07
Reviewed by Darin Adler.
After the landing of the first patch of webkit.org/b/66979,
WKPageCreateSnapshotOfVisibleContent API has been neglected for years.
Currently, this is not used anywhere and does not break the nightlies.
So we can remove this.
* UIProcess/API/C/WKPage.cpp:
(WKPageCreateSnapshotOfVisibleContent): Deleted.
* UIProcess/API/C/WKPagePrivate.h:
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/C/WKPage.cpp
trunk/Source/WebKit2/UIProcess/API/C/WKPagePrivate.h
Diff
Modified: trunk/Source/WebKit2/ChangeLog (174416 => 174417)
--- trunk/Source/WebKit2/ChangeLog 2014-10-08 04:51:35 UTC (rev 174416)
+++ trunk/Source/WebKit2/ChangeLog 2014-10-08 05:17:29 UTC (rev 174417)
@@ -1,5 +1,21 @@
2014-10-07 Sungmann Cho
+Remove WKPageCreateSnapshotOfVisibleContent API.
+https://bugs.webkit.org/show_bug.cgi?id=66979
+
+Reviewed by Darin Adler.
+
+After the landing of the first patch of webkit.org/b/66979,
+WKPageCreateSnapshotOfVisibleContent API has been neglected for years.
+Currently, this is not used anywhere and does not break the nightlies.
+So we can remove this.
+
+* UIProcess/API/C/WKPage.cpp:
+(WKPageCreateSnapshotOfVisibleContent): Deleted.
+* UIProcess/API/C/WKPagePrivate.h:
+
+2014-10-07 Sungmann Cho
+
Remove WKPageSetInvalidMessageFunction.
https://bugs.webkit.org/show_bug.cgi?id=137509
Modified: trunk/Source/WebKit2/UIProcess/API/C/WKPage.cpp (174416 => 174417)
--- trunk/Source/WebKit2/UIProcess/API/C/WKPage.cpp 2014-10-08 04:51:35 UTC (rev 174416)
+++ trunk/Source/WebKit2/UIProcess/API/C/WKPage.cpp 2014-10-08 05:17:29 UTC (rev 174417)
@@ -1776,11 +1776,6 @@
}
#endif
-WKImageRef WKPageCreateSnapshotOfVisibleContent(WKPageRef)
-{
-return 0;
-}
-
void WKPageSetShouldSendEventsSynchronously(WKPageRef page, bool sync)
{
toImpl(page)->setShouldSendEventsSynchronously(sync);
Modified: trunk/Source/WebKit2/UIProcess/API/C/WKPagePrivate.h (174416 => 174417)
--- trunk/Source/WebKit2/UIProcess/API/C/WKPagePrivate.h 2014-10-08 04:51:35 UTC (rev 174416)
+++ trunk/Source/WebKit2/UIProcess/API/C/WKPagePrivate.h 2014-10-08 05:17:29 UTC (rev 174417)
@@ -82,9 +82,6 @@
WK_EXPORT void WKPageDrawPagesToPDF(WKPageRef page, WKFrameRef frame, WKPrintInfo printInfo, uint32_t first, uint32_t count, WKPageDrawToPDFFunction callback, void* context);
WK_EXPORT void WKPageEndPrinting(WKPageRef page);
-// FIXME https://bugs.webkit.org/show_bug.cgi?id=66979: Remove this sync call.
-WK_EXPORT WKImageRef WKPageCreateSnapshotOfVisibleContent(WKPageRef page);
-
WK_EXPORT void WKPageSetShouldSendEventsSynchronously(WKPageRef page, bool sync);
WK_EXPORT bool WKPageGetAllowsRemoteInspection(WKPageRef page);
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [174415] trunk/Source/WebKit2
Title: [174415] trunk/Source/WebKit2
Revision 174415
Author commit-qu...@webkit.org
Date 2014-10-07 20:48:00 -0700 (Tue, 07 Oct 2014)
Log Message
Remove WKPageSetInvalidMessageFunction.
https://bugs.webkit.org/show_bug.cgi?id=137509
Patch by Sungmann Cho on 2014-10-07
Reviewed by Benjamin Poulain.
According to the FIXME comment in WKPageSetInvalidMessageFunction,
we can remove this function when doing so won't break the nightlies.
Currently, this is not used anywhere and does not break the nightlies.
So we can remove this.
* UIProcess/API/C/WKPage.cpp:
(WKPageSetInvalidMessageFunction): Deleted.
* UIProcess/API/C/WKPagePrivate.h:
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/C/WKPage.cpp
trunk/Source/WebKit2/UIProcess/API/C/WKPagePrivate.h
Diff
Modified: trunk/Source/WebKit2/ChangeLog (174414 => 174415)
--- trunk/Source/WebKit2/ChangeLog 2014-10-08 02:23:10 UTC (rev 174414)
+++ trunk/Source/WebKit2/ChangeLog 2014-10-08 03:48:00 UTC (rev 174415)
@@ -1,3 +1,19 @@
+2014-10-07 Sungmann Cho
+
+Remove WKPageSetInvalidMessageFunction.
+https://bugs.webkit.org/show_bug.cgi?id=137509
+
+Reviewed by Benjamin Poulain.
+
+According to the FIXME comment in WKPageSetInvalidMessageFunction,
+we can remove this function when doing so won't break the nightlies.
+Currently, this is not used anywhere and does not break the nightlies.
+So we can remove this.
+
+* UIProcess/API/C/WKPage.cpp:
+(WKPageSetInvalidMessageFunction): Deleted.
+* UIProcess/API/C/WKPagePrivate.h:
+
2014-10-07 Christophe Dumez
[WK2] Use is<>() / downcast<>() for DrawingArea subclasses
Modified: trunk/Source/WebKit2/UIProcess/API/C/WKPage.cpp (174414 => 174415)
--- trunk/Source/WebKit2/UIProcess/API/C/WKPage.cpp 2014-10-08 02:23:10 UTC (rev 174414)
+++ trunk/Source/WebKit2/UIProcess/API/C/WKPage.cpp 2014-10-08 03:48:00 UTC (rev 174415)
@@ -1898,11 +1898,6 @@
return false;
}
-void WKPageSetInvalidMessageFunction(WKPageInvalidMessageFunction)
-{
-// FIXME: Remove this function when doing so won't break WebKit nightlies.
-}
-
#if ENABLE(NETSCAPE_PLUGIN_API)
// -- DEPRECATED --
Modified: trunk/Source/WebKit2/UIProcess/API/C/WKPagePrivate.h (174414 => 174415)
--- trunk/Source/WebKit2/UIProcess/API/C/WKPagePrivate.h 2014-10-08 02:23:10 UTC (rev 174414)
+++ trunk/Source/WebKit2/UIProcess/API/C/WKPagePrivate.h 2014-10-08 03:48:00 UTC (rev 174415)
@@ -98,9 +98,6 @@
WK_EXPORT WKArrayRef WKPageCopyRelatedPages(WKPageRef page);
-typedef void (*WKPageInvalidMessageFunction)(uint32_t messageID);
-WK_EXPORT void WKPageSetInvalidMessageFunction(WKPageInvalidMessageFunction function);
-
enum {
kWKScrollPinningBehaviorDoNotPin,
kWKScrollPinningBehaviorPinToTop,
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [174414] trunk/Source/WebCore
Title: [174414] trunk/Source/WebCore
Revision 174414
Author d...@apple.com
Date 2014-10-07 19:23:10 -0700 (Tue, 07 Oct 2014)
Log Message
Safari 8 on OSX 10.10 does not run WebGL in Retina HiDPI mode.
https://bugs.webkit.org/show_bug.cgi?id=134854
Reviewed by Tim Horton.
The NSOpenGLLayer has to have its contentScale property
set accordingly when on a retina display. Do this by
adding another value to the GraphicsContext3D creation
attribute dictionary, representing the device pixel ratio.
Then, when we come to draw into the layer, make sure
we set our GL viewport to the correct value.
This is currently untestable because:
- we can't just read from the GL buffer as it is always correct
- WebGL isn't working in reftests
- a layer dump doesn't show the change since it was done in a CALayer subclass.
* html/canvas/WebGLRenderingContext.cpp:
(WebCore::WebGLRenderingContext::create): Pass the devicePixelRatio into the attribute dictionary.
* platform/graphics/GraphicsContext3D.h:
(WebCore::GraphicsContext3D::Attributes::Attributes): Add a devicePixelRatio attribute.
* platform/graphics/mac/WebGLLayer.h: New property to save us looking up the attributes
each frame.
* platform/graphics/mac/WebGLLayer.mm:
(-[WebGLLayer initWithGraphicsContext3D:]): Store the devicePixelRatio, and set our
contents scale appropriately.
(-[WebGLLayer drawInCGLContext:pixelFormat:forLayerTime:displayTime:]): Draw into
a correctly sized backbuffer.
(-[WebGLLayer copyImageSnapshotWithColorSpace:]): Generate an image of the correct size.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/canvas/WebGLRenderingContext.cpp
trunk/Source/WebCore/platform/graphics/GraphicsContext3D.h
trunk/Source/WebCore/platform/graphics/mac/WebGLLayer.h
trunk/Source/WebCore/platform/graphics/mac/WebGLLayer.mm
Diff
Modified: trunk/Source/WebCore/ChangeLog (174413 => 174414)
--- trunk/Source/WebCore/ChangeLog 2014-10-08 00:41:42 UTC (rev 174413)
+++ trunk/Source/WebCore/ChangeLog 2014-10-08 02:23:10 UTC (rev 174414)
@@ -1,3 +1,36 @@
+2014-10-08 Dean Jackson
+
+Safari 8 on OSX 10.10 does not run WebGL in Retina HiDPI mode.
+https://bugs.webkit.org/show_bug.cgi?id=134854
+
+
+Reviewed by Tim Horton.
+
+The NSOpenGLLayer has to have its contentScale property
+set accordingly when on a retina display. Do this by
+adding another value to the GraphicsContext3D creation
+attribute dictionary, representing the device pixel ratio.
+Then, when we come to draw into the layer, make sure
+we set our GL viewport to the correct value.
+
+This is currently untestable because:
+- we can't just read from the GL buffer as it is always correct
+- WebGL isn't working in reftests
+- a layer dump doesn't show the change since it was done in a CALayer subclass.
+
+* html/canvas/WebGLRenderingContext.cpp:
+(WebCore::WebGLRenderingContext::create): Pass the devicePixelRatio into the attribute dictionary.
+* platform/graphics/GraphicsContext3D.h:
+(WebCore::GraphicsContext3D::Attributes::Attributes): Add a devicePixelRatio attribute.
+* platform/graphics/mac/WebGLLayer.h: New property to save us looking up the attributes
+each frame.
+* platform/graphics/mac/WebGLLayer.mm:
+(-[WebGLLayer initWithGraphicsContext3D:]): Store the devicePixelRatio, and set our
+contents scale appropriately.
+(-[WebGLLayer drawInCGLContext:pixelFormat:forLayerTime:displayTime:]): Draw into
+a correctly sized backbuffer.
+(-[WebGLLayer copyImageSnapshotWithColorSpace:]): Generate an image of the correct size.
+
2014-10-07 Simon Fraser
Roll-over Changelogs.
Modified: trunk/Source/WebCore/html/canvas/WebGLRenderingContext.cpp (174413 => 174414)
--- trunk/Source/WebCore/html/canvas/WebGLRenderingContext.cpp 2014-10-08 00:41:42 UTC (rev 174413)
+++ trunk/Source/WebCore/html/canvas/WebGLRenderingContext.cpp 2014-10-08 02:23:10 UTC (rev 174414)
@@ -434,6 +434,9 @@
if (frame->settings().forceSoftwareWebGLRendering())
attributes.forceSoftwareRenderer = true;
+if (page)
+attributes.devicePixelRatio = page->deviceScaleFactor();
+
if (isPendingPolicyResolution) {
LOG(WebGL, "Create a WebGL context that looks real, but will require a policy resolution if used.");
std::unique_ptr renderingContext(new WebGLRenderingContext(canvas, attributes));
Modified: trunk/Source/WebCore/platform/graphics/GraphicsContext3D.h (174413 => 174414)
--- trunk/Source/WebCore/platform/graphics/GraphicsContext3D.h 2014-10-08 00:41:42 UTC (rev 174413)
+++ trunk/Source/WebCore/platform/graphics/GraphicsContext3D.h 2014-10-08 02:23:10 UTC (rev 174414)
@@ -442,6 +442,7 @@
, shareResources(true)
, preferDiscreteGPU(false)
, forceSoftwareRenderer(false)
+, devicePixelRatio(1)
[webkit-changes] [174413] trunk/Source/WebKit2
Title: [174413] trunk/Source/WebKit2
Revision 174413
Author cdu...@apple.com
Date 2014-10-07 17:41:42 -0700 (Tue, 07 Oct 2014)
Log Message
[WK2] Use is<>() / downcast<>() for DrawingArea subclasses
https://bugs.webkit.org/show_bug.cgi?id=137497
Reviewed by Benjamin Poulain.
Use is<>() / downcast<>() for DrawingArea subclasses.
* WebProcess/WebPage/DrawingArea.h:
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::didCommitLoad):
* WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::synchronizeDynamicViewportUpdate):
* WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.h:
* WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/WebProcess/WebPage/DrawingArea.h
trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp
trunk/Source/WebKit2/WebProcess/WebPage/ios/WebPageIOS.mm
trunk/Source/WebKit2/WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.h
trunk/Source/WebKit2/WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h
Diff
Modified: trunk/Source/WebKit2/ChangeLog (174412 => 174413)
--- trunk/Source/WebKit2/ChangeLog 2014-10-07 23:17:04 UTC (rev 174412)
+++ trunk/Source/WebKit2/ChangeLog 2014-10-08 00:41:42 UTC (rev 174413)
@@ -1,3 +1,20 @@
+2014-10-07 Christophe Dumez
+
+[WK2] Use is<>() / downcast<>() for DrawingArea subclasses
+https://bugs.webkit.org/show_bug.cgi?id=137497
+
+Reviewed by Benjamin Poulain.
+
+Use is<>() / downcast<>() for DrawingArea subclasses.
+
+* WebProcess/WebPage/DrawingArea.h:
+* WebProcess/WebPage/WebPage.cpp:
+(WebKit::WebPage::didCommitLoad):
+* WebProcess/WebPage/ios/WebPageIOS.mm:
+(WebKit::WebPage::synchronizeDynamicViewportUpdate):
+* WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.h:
+* WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:
+
2014-10-07 Simon Fraser
Roll-over Changelogs.
Modified: trunk/Source/WebKit2/WebProcess/WebPage/DrawingArea.h (174412 => 174413)
--- trunk/Source/WebKit2/WebProcess/WebPage/DrawingArea.h 2014-10-07 23:17:04 UTC (rev 174412)
+++ trunk/Source/WebKit2/WebProcess/WebPage/DrawingArea.h 2014-10-08 00:41:42 UTC (rev 174413)
@@ -37,6 +37,7 @@
#include
#include
#include
+#include
namespace IPC {
class Connection;
@@ -152,9 +153,11 @@
#endif
};
-#define DRAWING_AREA_TYPE_CASTS(ToValueTypeName, predicate) \
-TYPE_CASTS_BASE(ToValueTypeName, DrawingArea, value, value->predicate, value.predicate)
-
} // namespace WebKit
+#define SPECIALIZE_TYPE_TRAITS_DRAWING_AREA(ToValueTypeName, AreaType) \
+SPECIALIZE_TYPE_TRAITS_BEGIN(WebKit::ToValueTypeName) \
+static bool isType(const WebKit::DrawingArea& area) { return area.type() == WebKit::AreaType; } \
+SPECIALIZE_TYPE_TRAITS_END()
+
#endif // DrawingArea_h
Modified: trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp (174412 => 174413)
--- trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp 2014-10-07 23:17:04 UTC (rev 174412)
+++ trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp 2014-10-08 00:41:42 UTC (rev 174413)
@@ -4455,7 +4455,7 @@
#if PLATFORM(IOS)
m_hasReceivedVisibleContentRectsAfterDidCommitLoad = false;
m_scaleWasSetByUIProcess = false;
-m_firstLayerTreeTransactionIDAfterDidCommitLoad = toRemoteLayerTreeDrawingArea(*m_drawingArea).nextTransactionID();
+m_firstLayerTreeTransactionIDAfterDidCommitLoad = downcast(*m_drawingArea).nextTransactionID();
m_userHasChangedPageScaleFactor = false;
m_estimatedLatency = std::chrono::milliseconds(1000 / 60);
Modified: trunk/Source/WebKit2/WebProcess/WebPage/ios/WebPageIOS.mm (174412 => 174413)
--- trunk/Source/WebKit2/WebProcess/WebPage/ios/WebPageIOS.mm 2014-10-07 23:17:04 UTC (rev 174412)
+++ trunk/Source/WebKit2/WebProcess/WebPage/ios/WebPageIOS.mm 2014-10-08 00:41:42 UTC (rev 174413)
@@ -2396,7 +2396,7 @@
{
newTargetScale = pageScaleFactor();
newScrollPosition = m_page->mainFrame().view()->scrollPosition();
-nextValidLayerTreeTransactionID = toRemoteLayerTreeDrawingArea(*m_drawingArea).nextTransactionID();
+nextValidLayerTreeTransactionID = downcast(*m_drawingArea).nextTransactionID();
}
void WebPage::resetViewportDefaultConfiguration(WebFrame* frame)
Modified: trunk/Source/WebKit2/WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.h (174412 => 174413)
--- trunk/Source/WebKit2/WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.h 2014-10-07 23:17:04 UTC (rev 174412)
+++ trunk/Source/WebKit2/WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.h 2014-10-08 00:41:42 UTC (rev 174413)
@@ -167,8 +167,8 @@
WebCore::GraphicsLayer* m_viewOverlayRootLayer;
};
-DRAWING_AREA_TYPE_CASTS(RemoteLayerTreeDrawingArea, type() == DrawingAreaTypeRemoteLayerTree);
-
} // namespace WebKit
+SPECIALIZE_TYPE_TRAITS_DRAWING_AREA(RemoteLayerTreeDrawingArea, DrawingAreaTypeRemoteLayerTree)
+
#endif // RemoteLayerTreeDrawingArea_h
Modified: trunk/Source/WebKit2/WebProcess/WebPage/mac/Ti
[webkit-changes] [174412] trunk/Source/WTF
Title: [174412] trunk/Source/WTF
Revision 174412
Author bfulg...@apple.com
Date 2014-10-07 16:17:04 -0700 (Tue, 07 Oct 2014)
Log Message
[Win] Resolve some MSVC static analyzer warnings
https://bugs.webkit.org/show_bug.cgi?id=137504
Reviewed by Dean Jackson.
* wtf/GregorianDateTime.cpp:
(WTF::GregorianDateTime::setToCurrentLocalTime): Properly handle
possible timezone error case.
* wtf/OSAllocatorWin.cpp:
(WTF::OSAllocator::decommit): Silence a spurious warning about using
MEM_DECOMMIT instead of MEM_RELEASE.
* wtf/ThreadingWin.cpp: Silence a spurious warning about how the
tryLock method is implemented.
Modified Paths
trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/GregorianDateTime.cpp
trunk/Source/WTF/wtf/OSAllocatorWin.cpp
trunk/Source/WTF/wtf/ThreadingWin.cpp
Diff
Modified: trunk/Source/WTF/ChangeLog (174411 => 174412)
--- trunk/Source/WTF/ChangeLog 2014-10-07 22:28:25 UTC (rev 174411)
+++ trunk/Source/WTF/ChangeLog 2014-10-07 23:17:04 UTC (rev 174412)
@@ -1,3 +1,19 @@
+2014-10-07 Brent Fulgham
+
+[Win] Resolve some MSVC static analyzer warnings
+https://bugs.webkit.org/show_bug.cgi?id=137504
+
+Reviewed by Dean Jackson.
+
+* wtf/GregorianDateTime.cpp:
+(WTF::GregorianDateTime::setToCurrentLocalTime): Properly handle
+possible timezone error case.
+* wtf/OSAllocatorWin.cpp:
+(WTF::OSAllocator::decommit): Silence a spurious warning about using
+MEM_DECOMMIT instead of MEM_RELEASE.
+* wtf/ThreadingWin.cpp: Silence a spurious warning about how the
+tryLock method is implemented.
+
2014-10-07 Christophe Dumez
[WK2] Use is<>() / downcast<>() for DrawingAreaProxy subclasses
Modified: trunk/Source/WTF/wtf/GregorianDateTime.cpp (174411 => 174412)
--- trunk/Source/WTF/wtf/GregorianDateTime.cpp 2014-10-07 22:28:25 UTC (rev 174411)
+++ trunk/Source/WTF/wtf/GregorianDateTime.cpp 2014-10-07 23:17:04 UTC (rev 174412)
@@ -1,5 +1,5 @@
/*
- * Copyright (C) 2012 Patrick Gansterer
+ * Copyright (C) 2012, 2014 Patrick Gansterer
*
* Redistribution and use in source and binary forms, with or without
* modification, are permitted provided that the following conditions
@@ -43,13 +43,16 @@
TIME_ZONE_INFORMATION timeZoneInformation;
DWORD timeZoneId = GetTimeZoneInformation(&timeZoneInformation);
-LONG bias = timeZoneInformation.Bias;
-if (timeZoneId == TIME_ZONE_ID_DAYLIGHT)
-bias += timeZoneInformation.DaylightBias;
-else if (timeZoneId == TIME_ZONE_ID_STANDARD)
-bias += timeZoneInformation.StandardBias;
-else
-ASSERT(timeZoneId == TIME_ZONE_ID_UNKNOWN);
+LONG bias = 0;
+if (timeZoneId != TIME_ZONE_ID_INVALID) {
+bias = timeZoneInformation.Bias;
+if (timeZoneId == TIME_ZONE_ID_DAYLIGHT)
+bias += timeZoneInformation.DaylightBias;
+else if ((timeZoneId == TIME_ZONE_ID_STANDARD) || (timeZoneId == TIME_ZONE_ID_UNKNOWN))
+bias += timeZoneInformation.StandardBias;
+else
+ASSERT(0);
+}
m_year = systemTime.wYear;
m_month = systemTime.wMonth - 1;
Modified: trunk/Source/WTF/wtf/OSAllocatorWin.cpp (174411 => 174412)
--- trunk/Source/WTF/wtf/OSAllocatorWin.cpp 2014-10-07 22:28:25 UTC (rev 174411)
+++ trunk/Source/WTF/wtf/OSAllocatorWin.cpp 2014-10-07 23:17:04 UTC (rev 174412)
@@ -1,5 +1,5 @@
/*
- * Copyright (C) 2010 Apple Inc. All rights reserved.
+ * Copyright (C) 2010, 2014 Apple Inc. All rights reserved.
*
* Redistribution and use in source and binary forms, with or without
* modification, are permitted provided that the following conditions
@@ -73,6 +73,8 @@
// See: https://bugs.webkit.org/show_bug.cgi?id=121972.
if (!bytes)
return;
+// Silence warning about using MEM_DECOMMIT instead of MEM_RELEASE:
+#pragma warning(suppress: 6250)
bool result = VirtualFree(address, bytes, MEM_DECOMMIT);
if (!result)
CRASH();
Modified: trunk/Source/WTF/wtf/ThreadingWin.cpp (174411 => 174412)
--- trunk/Source/WTF/wtf/ThreadingWin.cpp 2014-10-07 22:28:25 UTC (rev 174411)
+++ trunk/Source/WTF/wtf/ThreadingWin.cpp 2014-10-07 23:17:04 UTC (rev 174412)
@@ -296,6 +296,7 @@
++m_mutex.m_recursionCount;
}
+#pragma warning(suppress: 26115)
bool Mutex::tryLock()
{
// This method is modeled after the behavior of pthread_mutex_trylock,
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [174410] trunk/Source
Title: [174410] trunk/Source
Revision 174410
Author akl...@apple.com
Date 2014-10-07 15:26:25 -0700 (Tue, 07 Oct 2014)
Log Message
Use more Ref and PassRef for Gradient.
Codify the fact that CanvasGradient always has an internal WebCore::Gradient
and make GraphicsContext gradient setters take PassRef, exposing some
unnecessary null checks.
Reviewed by Christophe Dumez.
* WebCore.exp.in:
* html/canvas/CanvasGradient.h:
(WebCore::CanvasGradient::gradient):
* platform/graphics/Gradient.h:
(WebCore::Gradient::create):
* platform/graphics/GraphicsContext.cpp:
(WebCore::GraphicsContext::setStrokeGradient):
(WebCore::GraphicsContext::setFillGradient):
* platform/graphics/GraphicsContext.h:
* rendering/RenderThemeIOS.mm:
(WebCore::RenderThemeIOS::paintProgressBar):
* rendering/svg/RenderSVGPath.cpp:
(WebCore::useStrokeStyleToFill):
* rendering/svg/RenderSVGResourceGradient.cpp:
(WebCore::RenderSVGResourceGradient::applyResource):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/WebCore.exp.in
trunk/Source/WebCore/html/canvas/CanvasGradient.h
trunk/Source/WebCore/platform/graphics/Gradient.h
trunk/Source/WebCore/platform/graphics/GraphicsContext.cpp
trunk/Source/WebCore/platform/graphics/GraphicsContext.h
trunk/Source/WebCore/rendering/RenderThemeIOS.mm
trunk/Source/WebCore/rendering/svg/RenderSVGPath.cpp
trunk/Source/WebCore/rendering/svg/RenderSVGResourceGradient.cpp
trunk/Source/WebKit2/UIProcess/FindIndicator.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (174409 => 174410)
--- trunk/Source/WebCore/ChangeLog 2014-10-07 22:17:09 UTC (rev 174409)
+++ trunk/Source/WebCore/ChangeLog 2014-10-07 22:26:25 UTC (rev 174410)
@@ -1,3 +1,30 @@
+2014-10-07 Andreas Kling
+
+Use more Ref and PassRef for Gradient.
+
+
+Codify the fact that CanvasGradient always has an internal WebCore::Gradient
+and make GraphicsContext gradient setters take PassRef, exposing some
+unnecessary null checks.
+
+Reviewed by Christophe Dumez.
+
+* WebCore.exp.in:
+* html/canvas/CanvasGradient.h:
+(WebCore::CanvasGradient::gradient):
+* platform/graphics/Gradient.h:
+(WebCore::Gradient::create):
+* platform/graphics/GraphicsContext.cpp:
+(WebCore::GraphicsContext::setStrokeGradient):
+(WebCore::GraphicsContext::setFillGradient):
+* platform/graphics/GraphicsContext.h:
+* rendering/RenderThemeIOS.mm:
+(WebCore::RenderThemeIOS::paintProgressBar):
+* rendering/svg/RenderSVGPath.cpp:
+(WebCore::useStrokeStyleToFill):
+* rendering/svg/RenderSVGResourceGradient.cpp:
+(WebCore::RenderSVGResourceGradient::applyResource):
+
2014-10-07 Martin Hock
Defer resolution of viewport size.
Modified: trunk/Source/WebCore/WebCore.exp.in (174409 => 174410)
--- trunk/Source/WebCore/WebCore.exp.in 2014-10-07 22:17:09 UTC (rev 174409)
+++ trunk/Source/WebCore/WebCore.exp.in 2014-10-07 22:26:25 UTC (rev 174410)
@@ -526,7 +526,7 @@
__ZN7WebCore15GraphicsContext12setFillColorERKNS_5ColorENS_10ColorSpaceE
__ZN7WebCore15GraphicsContext14setStrokeColorERKNS_5ColorENS_10ColorSpaceE
__ZN7WebCore15GraphicsContext15drawNativeImageEP7CGImageRKNS_9FloatSizeENS_10ColorSpaceERKNS_9FloatRectES9_NS_17CompositeOperatorENS_9BlendModeENS_16ImageOrientationE
-__ZN7WebCore15GraphicsContext15setFillGradientEN3WTF10PassRefPtrINS_8GradientEEE
+__ZN7WebCore15GraphicsContext15setFillGradientEN3WTF7PassRefINS_8GradientEEE
__ZN7WebCore15GraphicsContext18setShouldAntialiasEb
__ZN7WebCore15GraphicsContext19setIsCALayerContextEb
__ZN7WebCore15GraphicsContext20endTransparencyLayerEv
Modified: trunk/Source/WebCore/html/canvas/CanvasGradient.h (174409 => 174410)
--- trunk/Source/WebCore/html/canvas/CanvasGradient.h 2014-10-07 22:17:09 UTC (rev 174409)
+++ trunk/Source/WebCore/html/canvas/CanvasGradient.h 2014-10-07 22:26:25 UTC (rev 174410)
@@ -47,7 +47,8 @@
return adoptRef(new CanvasGradient(p0, r0, p1, r1));
}
-Gradient* gradient() const { return m_gradient.get(); }
+Gradient& gradient() { return m_gradient.get(); }
+const Gradient& gradient() const { return m_gradient.get(); }
void addColorStop(float value, const String& color, ExceptionCode&);
@@ -59,7 +60,7 @@
CanvasGradient(const FloatPoint& p0, const FloatPoint& p1);
CanvasGradient(const FloatPoint& p0, float r0, const FloatPoint& p1, float r1);
-RefPtr m_gradient;
+Ref m_gradient;
#if ENABLE(DASHBOARD_SUPPORT)
bool m_dashbardCompatibilityMode;
#endif
Modified: trunk/Source/WebCore/platform/graphics/Gradient.h (174409 => 174410)
--- trunk/Source/WebCore/platform/graphics/Gradient.h 2014-10-07 22:17:09 UTC (rev 174409)
+++ trunk/Source/WebCore/platform/graphics/Gradient.h 2014-10-07 22:26:25 UTC (rev 174410)
@@ -57,13 +57,13 @@
class Gradient : public RefCounted {
public:
-
[webkit-changes] [174409] trunk/LayoutTests
Title: [174409] trunk/LayoutTests Revision 174409 Author simon.fra...@apple.com Date 2014-10-07 15:17:09 -0700 (Tue, 07 Oct 2014) Log Message Bug link should be at the beginning of the line. * platform/mac/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/mac/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (174408 => 174409) --- trunk/LayoutTests/ChangeLog 2014-10-07 22:14:01 UTC (rev 174408) +++ trunk/LayoutTests/ChangeLog 2014-10-07 22:17:09 UTC (rev 174409) @@ -1,3 +1,9 @@ +2014-10-07 Simon Fraser + +Bug link should be at the beginning of the line. + +* platform/mac/TestExpectations: + 2014-10-07 Daniel Bates [iOS] Teach run-webkit-tests to honor TestExpectation file for iOS Simulator 64-bit builds Modified: trunk/LayoutTests/platform/mac/TestExpectations (174408 => 174409) --- trunk/LayoutTests/platform/mac/TestExpectations 2014-10-07 22:14:01 UTC (rev 174408) +++ trunk/LayoutTests/platform/mac/TestExpectations 2014-10-07 22:17:09 UTC (rev 174409) @@ -1407,4 +1407,4 @@ webkit.org/b/137157 inspector/page/main-frame-resource.html [ Failure Crash ] webkit.org/b/137157 inspector/protocol-promise-result.html [ Failure Crash ] -[ MountainLion ] webkit.org/b/137319 fast/css/test-setting-canvas-color.html [ Pass Crash Timeout ] +webkit.org/b/137319 [ MountainLion ] fast/css/test-setting-canvas-color.html [ Pass Crash Timeout ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [174408] trunk/Tools
Title: [174408] trunk/Tools
Revision 174408
Author commit-qu...@webkit.org
Date 2014-10-07 15:14:01 -0700 (Tue, 07 Oct 2014)
Log Message
Commit queue doesn't drop obsolete patches sometimes
https://bugs.webkit.org/show_bug.cgi?id=137460
Patch by Jake Nielsen on 2014-10-07
Reviewed by Alexey Proskuryakov.
* Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py:
Adds another test patch for use in queues_unittest.py.
courtesy of Csaba Osztrogonác
(MockBugzilla):
* Scripts/webkitpy/tool/bot/commitqueuetask.py:
Raises a PatchIsNotValid exception in the case of validate() returning
false.
(CommitQueueTask.run):
* Scripts/webkitpy/tool/bot/earlywarningsystemtask.py:
Raises a PatchIsNotValid exception in the case of validate() returning
false.
(EarlyWarningSystemTask.run):
* Scripts/webkitpy/tool/bot/patchanalysistask.py:
Defines PatchIsNotValid exception.
(PatchIsNotValid):
(PatchIsNotValid.__init__):
* Scripts/webkitpy/tool/commands/earlywarningsystem.py:
Remove call to validate() and instead catches the PatchIsNotValid
exception.
(AbstractEarlyWarningSystem.review_patch):
* Scripts/webkitpy/tool/commands/queues.py:
Adds logic to catch the PatchIsNotValid exception.
(CommitQueue.process_work_item):
* Scripts/webkitpy/tool/commands/queues_unittest.py:
Adds the test_non_valid_patch test to ensure that invalid patches are
handled properly, and don't just result in indefinite spinning.
courtesy of Csaba Osztrogonác
(test_non_valid_patch):
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py
trunk/Tools/Scripts/webkitpy/tool/bot/commitqueuetask.py
trunk/Tools/Scripts/webkitpy/tool/bot/earlywarningsystemtask.py
trunk/Tools/Scripts/webkitpy/tool/bot/patchanalysistask.py
trunk/Tools/Scripts/webkitpy/tool/commands/earlywarningsystem.py
trunk/Tools/Scripts/webkitpy/tool/commands/queues.py
trunk/Tools/Scripts/webkitpy/tool/commands/queues_unittest.py
Diff
Modified: trunk/Tools/ChangeLog (174407 => 174408)
--- trunk/Tools/ChangeLog 2014-10-07 21:35:26 UTC (rev 174407)
+++ trunk/Tools/ChangeLog 2014-10-07 22:14:01 UTC (rev 174408)
@@ -1,3 +1,39 @@
+2014-10-07 Jake Nielsen
+
+Commit queue doesn't drop obsolete patches sometimes
+https://bugs.webkit.org/show_bug.cgi?id=137460
+
+Reviewed by Alexey Proskuryakov.
+
+* Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py:
+Adds another test patch for use in queues_unittest.py.
+courtesy of Csaba Osztrogonác
+(MockBugzilla):
+* Scripts/webkitpy/tool/bot/commitqueuetask.py:
+Raises a PatchIsNotValid exception in the case of validate() returning
+false.
+(CommitQueueTask.run):
+* Scripts/webkitpy/tool/bot/earlywarningsystemtask.py:
+Raises a PatchIsNotValid exception in the case of validate() returning
+false.
+(EarlyWarningSystemTask.run):
+* Scripts/webkitpy/tool/bot/patchanalysistask.py:
+Defines PatchIsNotValid exception.
+(PatchIsNotValid):
+(PatchIsNotValid.__init__):
+* Scripts/webkitpy/tool/commands/earlywarningsystem.py:
+Remove call to validate() and instead catches the PatchIsNotValid
+exception.
+(AbstractEarlyWarningSystem.review_patch):
+* Scripts/webkitpy/tool/commands/queues.py:
+Adds logic to catch the PatchIsNotValid exception.
+(CommitQueue.process_work_item):
+* Scripts/webkitpy/tool/commands/queues_unittest.py:
+Adds the test_non_valid_patch test to ensure that invalid patches are
+handled properly, and don't just result in indefinite spinning.
+courtesy of Csaba Osztrogonác
+(test_non_valid_patch):
+
2014-10-07 Daniel Bates
[iOS] Teach run-webkit-tests to honor TestExpectation file for iOS Simulator 64-bit builds
Modified: trunk/Tools/Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py (174407 => 174408)
--- trunk/Tools/Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py 2014-10-07 21:35:26 UTC (rev 174407)
+++ trunk/Tools/Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py 2014-10-07 22:14:01 UTC (rev 174408)
@@ -141,6 +141,15 @@
"attacher_email": "e...@webkit.org",
}
+_patch8 = { # Resolved bug, without review flag, not marked obsolete (maybe already landed)
+"id": 10007,
+"bug_id": 50005,
+"url": "http://example.com/10002",
+"name": "Patch8",
+"is_obsolete": False,
+"is_patch": True,
+"attacher_email": "e...@webkit.org",
+}
# This matches one of Bug.unassigned_emails
_unassigned_email = "webkit-unassig...@lists.webkit.org"
@@ -242,7 +251,7 @@
"reporter_email": _commit_queue_email,
"assigned_to_email": "f...@foo.com",
"cc_emails": [],
-"attachments": [],
+"attachments": [_patch8],
"bug_status": "RESOLVED",
"comments": [{"comment_date": datetime.datetime(2011, 6, 11, 9, 4, 3),
"comment_email": "b...@foo.com",
@@ -343,7 +35
[webkit-changes] [174407] trunk/Source/WebKit2
Title: [174407] trunk/Source/WebKit2
Revision 174407
Author cdu...@apple.com
Date 2014-10-07 14:35:26 -0700 (Tue, 07 Oct 2014)
Log Message
Unreviewed iOS build fix after r174400.
Missing explicit WebKit:: namespace.
* UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _didCommitLoadForMainFrame]):
(-[WKWebView _restorePageStateToExposedRect:scale:]):
(-[WKWebView _restorePageStateToUnobscuredCenter:scale:]):
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm
Diff
Modified: trunk/Source/WebKit2/ChangeLog (174406 => 174407)
--- trunk/Source/WebKit2/ChangeLog 2014-10-07 21:35:06 UTC (rev 174406)
+++ trunk/Source/WebKit2/ChangeLog 2014-10-07 21:35:26 UTC (rev 174407)
@@ -1,3 +1,14 @@
+2014-10-07 Chris Dumez
+
+Unreviewed iOS build fix after r174400.
+
+Missing explicit WebKit:: namespace.
+
+* UIProcess/API/Cocoa/WKWebView.mm:
+(-[WKWebView _didCommitLoadForMainFrame]):
+(-[WKWebView _restorePageStateToExposedRect:scale:]):
+(-[WKWebView _restorePageStateToUnobscuredCenter:scale:]):
+
2014-10-07 Christophe Dumez
Use is<>() / downcast<>() for RenderText / RenderTextFragment
Modified: trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm (174406 => 174407)
--- trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm 2014-10-07 21:35:06 UTC (rev 174406)
+++ trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm 2014-10-07 21:35:26 UTC (rev 174407)
@@ -799,7 +799,7 @@
- (void)_didCommitLoadForMainFrame
{
-_firstPaintAfterCommitLoadTransactionID = downcast(*_page->drawingArea()).nextLayerTreeTransactionID();
+_firstPaintAfterCommitLoadTransactionID = downcast(*_page->drawingArea()).nextLayerTreeTransactionID();
_hasCommittedLoadForMainFrame = YES;
_needsResetViewStateAfterCommitLoadForMainFrame = YES;
@@ -935,7 +935,7 @@
_needsToRestoreUnobscuredCenter = NO;
_needsToRestoreExposedRect = YES;
-_firstTransactionIDAfterPageRestore = downcast(*_page->drawingArea()).nextLayerTreeTransactionID();
+_firstTransactionIDAfterPageRestore = downcast(*_page->drawingArea()).nextLayerTreeTransactionID();
_exposedRectToRestore = exposedRect;
_scaleToRestore = scale;
}
@@ -950,7 +950,7 @@
_needsToRestoreExposedRect = NO;
_needsToRestoreUnobscuredCenter = YES;
-_firstTransactionIDAfterPageRestore = downcast(*_page->drawingArea()).nextLayerTreeTransactionID();
+_firstTransactionIDAfterPageRestore = downcast(*_page->drawingArea()).nextLayerTreeTransactionID();
_unobscuredCenterToRestore = center;
_scaleToRestore = scale;
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [174406] trunk
Title: [174406] trunk Revision 174406 Author commit-qu...@webkit.org Date 2014-10-07 14:35:06 -0700 (Tue, 07 Oct 2014) Log Message [iOS] Teach run-webkit-tests to honor TestExpectation file for iOS Simulator 64-bit builds https://bugs.webkit.org/show_bug.cgi?id=137499 Patch by Daniel Bates on 2014-10-07 Reviewed by Simon Fraser. Tools: Fixes an issue where the TestExpectation file for the iOS Simulator platform was only honored when running run-webkit-tests with a 32-bit simulator build of iOS WebKit. We should honor the TestExpectation file for the iOS Simulator platform for both 32- and 64- bit simulator builds of iOS WebKit. * Scripts/webkitpy/port/ios.py: (IOSSimulatorPort._generate_all_test_configurations): LayoutTests: Add a new platform directory, called ios-simulator, and associated TestExpectation file. For now, there is a single entry to skip all accessibility tests on iOS due to significant API differences. We'll likely update TestExpectations as we rebaseline iOS Simulator layout test results. * platform/ios-simulator/TestExpectations: Added. Modified Paths trunk/LayoutTests/ChangeLog trunk/Tools/ChangeLog trunk/Tools/Scripts/webkitpy/port/ios.py Added Paths trunk/LayoutTests/platform/ios-simulator/ trunk/LayoutTests/platform/ios-simulator/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (174405 => 174406) --- trunk/LayoutTests/ChangeLog 2014-10-07 20:52:26 UTC (rev 174405) +++ trunk/LayoutTests/ChangeLog 2014-10-07 21:35:06 UTC (rev 174406) @@ -1,3 +1,17 @@ +2014-10-07 Daniel Bates + +[iOS] Teach run-webkit-tests to honor TestExpectation file for iOS Simulator 64-bit builds +https://bugs.webkit.org/show_bug.cgi?id=137499 + +Reviewed by Simon Fraser. + +Add a new platform directory, called ios-simulator, and associated TestExpectation file. +For now, there is a single entry to skip all accessibility tests on iOS due to significant +API differences. We'll likely update TestExpectations as we rebaseline iOS Simulator +layout test results. + +* platform/ios-simulator/TestExpectations: Added. + 2014-10-07 Jer Noble [Media] Expose AudioTracks in the "captions" menu. Added: trunk/LayoutTests/platform/ios-simulator/TestExpectations (0 => 174406) --- trunk/LayoutTests/platform/ios-simulator/TestExpectations (rev 0) +++ trunk/LayoutTests/platform/ios-simulator/TestExpectations 2014-10-07 21:35:06 UTC (rev 174406) @@ -0,0 +1,7 @@ +# These are the layout test expectations for Apple's iOS port of WebKit. +# +# See http://trac.webkit.org/wiki/TestExpectations for more information on this file. + +# Cannot enable AX tests because there are too many differences between what is available +# through the iPhone AX API and the OS X AX API. +accessibility Modified: trunk/Tools/ChangeLog (174405 => 174406) --- trunk/Tools/ChangeLog 2014-10-07 20:52:26 UTC (rev 174405) +++ trunk/Tools/ChangeLog 2014-10-07 21:35:06 UTC (rev 174406) @@ -1,3 +1,18 @@ +2014-10-07 Daniel Bates + +[iOS] Teach run-webkit-tests to honor TestExpectation file for iOS Simulator 64-bit builds +https://bugs.webkit.org/show_bug.cgi?id=137499 + +Reviewed by Simon Fraser. + +Fixes an issue where the TestExpectation file for the iOS Simulator platform was only +honored when running run-webkit-tests with a 32-bit simulator build of iOS WebKit. We +should honor the TestExpectation file for the iOS Simulator platform for both 32- and 64- +bit simulator builds of iOS WebKit. + +* Scripts/webkitpy/port/ios.py: +(IOSSimulatorPort._generate_all_test_configurations): + 2014-10-07 Youenn Fablet [GTK] jhbuild modules should build xserver with the --without-dtrace option. Modified: trunk/Tools/Scripts/webkitpy/port/ios.py (174405 => 174406) --- trunk/Tools/Scripts/webkitpy/port/ios.py 2014-10-07 20:52:26 UTC (rev 174405) +++ trunk/Tools/Scripts/webkitpy/port/ios.py 2014-10-07 21:35:06 UTC (rev 174406) @@ -134,7 +134,8 @@ def _generate_all_test_configurations(self): configurations = [] for build_type in self.ALL_BUILD_TYPES: -configurations.append(TestConfiguration(version=self._version, architecture='x86', build_type=build_type)) +for architecture in self.ARCHITECTURES: +configurations.append(TestConfiguration(version=self._version, architecture=architecture, build_type=build_type)) return configurations def _driver_class(self): ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [174405] trunk/Source/WebCore
Title: [174405] trunk/Source/WebCore
Revision 174405
Author mh...@apple.com
Date 2014-10-07 13:52:26 -0700 (Tue, 07 Oct 2014)
Log Message
Defer resolution of viewport size.
https://bugs.webkit.org/show_bug.cgi?id=137376
rdar://problem/18558094
Reviewed by Benjamin Poulain.
ViewportConfiguration should resolve the viewport size on configuration update.
* dom/Document.cpp:
(WebCore::Document::processViewport): Defer resolution of viewport size.
* dom/ViewportArguments.cpp:
(WebCore::finalizeViewportArguments): Deleted.
* dom/ViewportArguments.h:
* page/ViewportConfiguration.cpp:
(WebCore::ViewportConfiguration::updateConfiguration): Resolve viewport size.
(WebCore::ViewportConfiguration::viewportArgumentsLength): Resolves width or height based on viewport arguments.
* page/ViewportConfiguration.h:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/Document.cpp
trunk/Source/WebCore/dom/ViewportArguments.cpp
trunk/Source/WebCore/dom/ViewportArguments.h
trunk/Source/WebCore/page/ViewportConfiguration.cpp
trunk/Source/WebCore/page/ViewportConfiguration.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (174404 => 174405)
--- trunk/Source/WebCore/ChangeLog 2014-10-07 20:37:48 UTC (rev 174404)
+++ trunk/Source/WebCore/ChangeLog 2014-10-07 20:52:26 UTC (rev 174405)
@@ -1,3 +1,23 @@
+2014-10-07 Martin Hock
+
+Defer resolution of viewport size.
+https://bugs.webkit.org/show_bug.cgi?id=137376
+rdar://problem/18558094
+
+Reviewed by Benjamin Poulain.
+
+ViewportConfiguration should resolve the viewport size on configuration update.
+
+* dom/Document.cpp:
+(WebCore::Document::processViewport): Defer resolution of viewport size.
+* dom/ViewportArguments.cpp:
+(WebCore::finalizeViewportArguments): Deleted.
+* dom/ViewportArguments.h:
+* page/ViewportConfiguration.cpp:
+(WebCore::ViewportConfiguration::updateConfiguration): Resolve viewport size.
+(WebCore::ViewportConfiguration::viewportArgumentsLength): Resolves width or height based on viewport arguments.
+* page/ViewportConfiguration.h:
+
2014-10-07 Pratik Solanki
[iOS] WebKit1 clients crash in DiskCacheMonitor::tryGetFileBackedSharedBufferFromCFURLCachedResponse()
Modified: trunk/Source/WebCore/dom/Document.cpp (174404 => 174405)
--- trunk/Source/WebCore/dom/Document.cpp 2014-10-07 20:37:48 UTC (rev 174404)
+++ trunk/Source/WebCore/dom/Document.cpp 2014-10-07 20:52:26 UTC (rev 174405)
@@ -3001,15 +3001,6 @@
m_viewportArguments = ViewportArguments(origin);
processArguments(features, (void*)&m_viewportArguments, &setViewportFeature);
-#if PLATFORM(IOS)
-// FIXME: Investigate moving to ToT WebKit's extended Viewport Implementation
-// Moving to ToT's implementation would mean calling findConfigurationForViewportData, which does
-// bounds checking and determining concrete values for ValueAuto which we already do in UIKit.
-// To maintain old behavior, we just need to update a few values, leaving Auto's for UIKit.
-if (Page* page = this->page())
-finalizeViewportArguments(m_viewportArguments, page->chrome().screenSize());
-#endif
-
updateViewportArguments();
}
Modified: trunk/Source/WebCore/dom/ViewportArguments.cpp (174404 => 174405)
--- trunk/Source/WebCore/dom/ViewportArguments.cpp 2014-10-07 20:37:48 UTC (rev 174404)
+++ trunk/Source/WebCore/dom/ViewportArguments.cpp 2014-10-07 20:52:26 UTC (rev 174405)
@@ -401,21 +401,6 @@
reportViewportWarning(document, UnrecognizedViewportArgumentKeyError, keyString, String());
}
-#if PLATFORM(IOS)
-void finalizeViewportArguments(ViewportArguments& arguments, const FloatSize& screenSize)
-{
-if (arguments.width == ViewportArguments::ValueDeviceWidth)
-arguments.width = screenSize.width();
-else if (arguments.width == ViewportArguments::ValueDeviceHeight)
-arguments.width = screenSize.height();
-
-if (arguments.height == ViewportArguments::ValueDeviceWidth)
-arguments.height = screenSize.width();
-else if (arguments.height == ViewportArguments::ValueDeviceHeight)
-arguments.height = screenSize.height();
-}
-#endif
-
static const char* viewportErrorMessageTemplate(ViewportErrorCode errorCode)
{
static const char* const errors[] = {
Modified: trunk/Source/WebCore/dom/ViewportArguments.h (174404 => 174405)
--- trunk/Source/WebCore/dom/ViewportArguments.h 2014-10-07 20:37:48 UTC (rev 174404)
+++ trunk/Source/WebCore/dom/ViewportArguments.h 2014-10-07 20:52:26 UTC (rev 174405)
@@ -152,10 +152,6 @@
void setViewportFeature(const String& keyString, const String& valueString, Document*, void* data);
void reportViewportWarning(Document*, ViewportErrorCode, const String& replacement1, const String& replacement2);
-#if PLATFORM(IOS)
-void finalizeViewportArguments(ViewportArguments&, const FloatSize& screenSize);
-#endif
-
} // namespace WebCore
#en
[webkit-changes] [174404] trunk/Source/WebCore
Title: [174404] trunk/Source/WebCore
Revision 174404
Author psola...@apple.com
Date 2014-10-07 13:37:48 -0700 (Tue, 07 Oct 2014)
Log Message
[iOS] WebKit1 clients crash in DiskCacheMonitor::tryGetFileBackedSharedBufferFromCFURLCachedResponse()
https://bugs.webkit.org/show_bug.cgi?id=137495
Reviewed by Andreas Kling.
Retain/release the CFCachedURLResponseRef object otherwise we could access a deleted object
and crash on the web thread.
* loader/cocoa/DiskCacheMonitorCocoa.mm:
(WebCore::DiskCacheMonitor::DiskCacheMonitor):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/loader/cocoa/DiskCacheMonitorCocoa.mm
Diff
Modified: trunk/Source/WebCore/ChangeLog (174403 => 174404)
--- trunk/Source/WebCore/ChangeLog 2014-10-07 19:33:53 UTC (rev 174403)
+++ trunk/Source/WebCore/ChangeLog 2014-10-07 20:37:48 UTC (rev 174404)
@@ -1,3 +1,17 @@
+2014-10-07 Pratik Solanki
+
+[iOS] WebKit1 clients crash in DiskCacheMonitor::tryGetFileBackedSharedBufferFromCFURLCachedResponse()
+https://bugs.webkit.org/show_bug.cgi?id=137495
+
+
+Reviewed by Andreas Kling.
+
+Retain/release the CFCachedURLResponseRef object otherwise we could access a deleted object
+and crash on the web thread.
+
+* loader/cocoa/DiskCacheMonitorCocoa.mm:
+(WebCore::DiskCacheMonitor::DiskCacheMonitor):
+
2014-10-07 Christophe Dumez
Use is<>() / downcast<>() for RenderText / RenderTextFragment
Modified: trunk/Source/WebCore/loader/cocoa/DiskCacheMonitorCocoa.mm (174403 => 174404)
--- trunk/Source/WebCore/loader/cocoa/DiskCacheMonitorCocoa.mm 2014-10-07 19:33:53 UTC (rev 174403)
+++ trunk/Source/WebCore/loader/cocoa/DiskCacheMonitorCocoa.mm 2014-10-07 20:37:48 UTC (rev 174404)
@@ -110,8 +110,10 @@
#if USE(WEB_THREAD)
CFCachedURLResponseCallBackBlock blockToRun = ^ (CFCachedURLResponseRef response)
{
+CFRetain(response);
WebThreadRun(^ {
block(response);
+CFRelease(response);
});
};
#else
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [174401] trunk/Source/JavaScriptCore
Title: [174401] trunk/Source/_javascript_Core
Revision 174401
Author oli...@apple.com
Date 2014-10-07 11:57:57 -0700 (Tue, 07 Oct 2014)
Log Message
Remove op_new_captured_func
https://bugs.webkit.org/show_bug.cgi?id=137491
Reviewed by Mark Lam.
Removes the op_captured_new_func opcode as part of the work
towards having any magical opcodes that write directly to
named "registers" and then have a follow on op to ensure that
the environment record correctly represents the stack state.
For this we add a non-captured scratch register so we don't
have to have any kind of magic opcode, and instead simply
have sensible creation and move semantics for capturing new
functions.
* bytecode/BytecodeList.json:
* bytecode/BytecodeUseDef.h:
(JSC::computeUsesForBytecodeOffset):
(JSC::computeDefsForBytecodeOffset):
* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::dumpBytecode):
(JSC::CodeBlock::CodeBlock):
* bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::BytecodeGenerator):
(JSC::BytecodeGenerator::emitNewFunction):
(JSC::BytecodeGenerator::emitLazyNewFunction):
(JSC::BytecodeGenerator::emitNewFunctionInternal):
* bytecompiler/BytecodeGenerator.h:
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parseBlock):
* dfg/DFGCapabilities.cpp:
(JSC::DFG::capabilityLevel):
* jit/JIT.cpp:
(JSC::JIT::privateCompileMainPass):
* jit/JIT.h:
* jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_new_captured_func): Deleted.
* llint/LowLevelInterpreter32_64.asm:
* llint/LowLevelInterpreter64.asm:
* runtime/CommonSlowPaths.cpp:
(JSC::SLOW_PATH_DECL): Deleted.
* runtime/CommonSlowPaths.h:
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/bytecode/BytecodeList.json
trunk/Source/_javascript_Core/bytecode/BytecodeUseDef.h
trunk/Source/_javascript_Core/bytecode/CodeBlock.cpp
trunk/Source/_javascript_Core/bytecompiler/BytecodeGenerator.cpp
trunk/Source/_javascript_Core/bytecompiler/BytecodeGenerator.h
trunk/Source/_javascript_Core/dfg/DFGByteCodeParser.cpp
trunk/Source/_javascript_Core/dfg/DFGCapabilities.cpp
trunk/Source/_javascript_Core/jit/JIT.cpp
trunk/Source/_javascript_Core/jit/JIT.h
trunk/Source/_javascript_Core/jit/JITOpcodes.cpp
trunk/Source/_javascript_Core/llint/LowLevelInterpreter32_64.asm
trunk/Source/_javascript_Core/llint/LowLevelInterpreter64.asm
trunk/Source/_javascript_Core/runtime/CommonSlowPaths.cpp
trunk/Source/_javascript_Core/runtime/CommonSlowPaths.h
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (174400 => 174401)
--- trunk/Source/_javascript_Core/ChangeLog 2014-10-07 18:41:49 UTC (rev 174400)
+++ trunk/Source/_javascript_Core/ChangeLog 2014-10-07 18:57:57 UTC (rev 174401)
@@ -1,3 +1,48 @@
+2014-10-07 Oliver Hunt
+
+Remove op_new_captured_func
+https://bugs.webkit.org/show_bug.cgi?id=137491
+
+Reviewed by Mark Lam.
+
+Removes the op_captured_new_func opcode as part of the work
+towards having any magical opcodes that write directly to
+named "registers" and then have a follow on op to ensure that
+the environment record correctly represents the stack state.
+
+For this we add a non-captured scratch register so we don't
+have to have any kind of magic opcode, and instead simply
+have sensible creation and move semantics for capturing new
+functions.
+
+* bytecode/BytecodeList.json:
+* bytecode/BytecodeUseDef.h:
+(JSC::computeUsesForBytecodeOffset):
+(JSC::computeDefsForBytecodeOffset):
+* bytecode/CodeBlock.cpp:
+(JSC::CodeBlock::dumpBytecode):
+(JSC::CodeBlock::CodeBlock):
+* bytecompiler/BytecodeGenerator.cpp:
+(JSC::BytecodeGenerator::BytecodeGenerator):
+(JSC::BytecodeGenerator::emitNewFunction):
+(JSC::BytecodeGenerator::emitLazyNewFunction):
+(JSC::BytecodeGenerator::emitNewFunctionInternal):
+* bytecompiler/BytecodeGenerator.h:
+* dfg/DFGByteCodeParser.cpp:
+(JSC::DFG::ByteCodeParser::parseBlock):
+* dfg/DFGCapabilities.cpp:
+(JSC::DFG::capabilityLevel):
+* jit/JIT.cpp:
+(JSC::JIT::privateCompileMainPass):
+* jit/JIT.h:
+* jit/JITOpcodes.cpp:
+(JSC::JIT::emit_op_new_captured_func): Deleted.
+* llint/LowLevelInterpreter32_64.asm:
+* llint/LowLevelInterpreter64.asm:
+* runtime/CommonSlowPaths.cpp:
+(JSC::SLOW_PATH_DECL): Deleted.
+* runtime/CommonSlowPaths.h:
+
2014-10-06 Andy Estes
Objective-C objects must be fully defined when used in a WTF::Vector
Modified: trunk/Source/_javascript_Core/bytecode/BytecodeList.json (174400 => 174401)
--- trunk/Source/_javascript_Core/bytecode/BytecodeList.json 2014-10-07 18:41:49 UTC (rev 174400)
+++ trunk/Source/_javascript_Core/bytecode/BytecodeList.json 2014-10-07 18:57:57 UTC (rev 174401)
@@ -93,7 +93,6 @@
{ "name" : "op_switch_char", "length" : 4 },
{ "name" : "op_switch_
[webkit-changes] [174400] trunk/Source
Title: [174400] trunk/Source
Revision 174400
Author cdu...@apple.com
Date 2014-10-07 11:41:49 -0700 (Tue, 07 Oct 2014)
Log Message
[WK2] Use is<>() / downcast<>() for DrawingAreaProxy subclasses
https://bugs.webkit.org/show_bug.cgi?id=137477
Reviewed by Andreas Kling.
Source/WebCore:
Include TypeCastsCF.h now that the header was renamed.
No new tests, no behavior change.
* platform/cf/SharedBufferCF.cpp:
Source/WebKit2:
Use is<>() / downcast<>() for DrawingAreaProxy subclasses.
* Shared/cf/KeyedDecoder.cpp:
* UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _didCommitLoadForMainFrame]):
(-[WKWebView _restorePageStateToExposedRect:scale:]):
(-[WKWebView _restorePageStateToUnobscuredCenter:scale:]):
* UIProcess/Cocoa/WebPageProxyCocoa.mm:
* UIProcess/DrawingAreaProxy.h:
* UIProcess/Scrolling/RemoteScrollingCoordinatorProxy.cpp:
(WebKit::RemoteScrollingCoordinatorProxy::layerTreeHost):
* UIProcess/ios/WebPageProxyIOS.mm:
(WebKit::WebPageProxy::updateVisibleContentRects):
(WebKit::WebPageProxy::dynamicViewportUpdateChangedTarget):
* UIProcess/ios/WebVideoFullscreenManagerProxy.mm:
(WebKit::WebVideoFullscreenManagerProxy::setupFullscreenWithID):
* UIProcess/mac/LegacySessionStateCoding.cpp:
* UIProcess/mac/RemoteLayerTreeDrawingAreaProxy.h:
* UIProcess/mac/TiledCoreAnimationDrawingAreaProxy.h:
Source/WTF:
Rename wtf/cf/TypeCasts.h to wtf/cf/TypeCastsCF.h to avoid conflict
with wtf/TypeCasts.h. They were using the same #ifndef guard and it
was causing problems when both were included in the same context.
* WTF.xcodeproj/project.pbxproj:
* wtf/cf/TypeCastsCF.h: Renamed from Source/WTF/wtf/cf/TypeCasts.h.
(WTF::dynamic_cf_cast):
(WTF::checked_cf_cast):
Modified Paths
trunk/Source/WTF/ChangeLog
trunk/Source/WTF/WTF.xcodeproj/project.pbxproj
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/cf/SharedBufferCF.cpp
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/Shared/cf/KeyedDecoder.cpp
trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm
trunk/Source/WebKit2/UIProcess/Cocoa/WebPageProxyCocoa.mm
trunk/Source/WebKit2/UIProcess/DrawingAreaProxy.h
trunk/Source/WebKit2/UIProcess/Scrolling/RemoteScrollingCoordinatorProxy.cpp
trunk/Source/WebKit2/UIProcess/ios/WebPageProxyIOS.mm
trunk/Source/WebKit2/UIProcess/ios/WebVideoFullscreenManagerProxy.mm
trunk/Source/WebKit2/UIProcess/mac/LegacySessionStateCoding.cpp
trunk/Source/WebKit2/UIProcess/mac/RemoteLayerTreeDrawingAreaProxy.h
trunk/Source/WebKit2/UIProcess/mac/TiledCoreAnimationDrawingAreaProxy.h
Added Paths
trunk/Source/WTF/wtf/cf/TypeCastsCF.h
Removed Paths
trunk/Source/WTF/wtf/cf/TypeCasts.h
Diff
Modified: trunk/Source/WTF/ChangeLog (174399 => 174400)
--- trunk/Source/WTF/ChangeLog 2014-10-07 17:15:40 UTC (rev 174399)
+++ trunk/Source/WTF/ChangeLog 2014-10-07 18:41:49 UTC (rev 174400)
@@ -1,3 +1,19 @@
+2014-10-07 Christophe Dumez
+
+[WK2] Use is<>() / downcast<>() for DrawingAreaProxy subclasses
+https://bugs.webkit.org/show_bug.cgi?id=137477
+
+Reviewed by Andreas Kling.
+
+Rename wtf/cf/TypeCasts.h to wtf/cf/TypeCastsCF.h to avoid conflict
+with wtf/TypeCasts.h. They were using the same #ifndef guard and it
+was causing problems when both were included in the same context.
+
+* WTF.xcodeproj/project.pbxproj:
+* wtf/cf/TypeCastsCF.h: Renamed from Source/WTF/wtf/cf/TypeCasts.h.
+(WTF::dynamic_cf_cast):
+(WTF::checked_cf_cast):
+
2014-10-07 Anders Carlsson
Try to fix the Mountain Lion build.
Modified: trunk/Source/WTF/WTF.xcodeproj/project.pbxproj (174399 => 174400)
--- trunk/Source/WTF/WTF.xcodeproj/project.pbxproj 2014-10-07 17:15:40 UTC (rev 174399)
+++ trunk/Source/WTF/WTF.xcodeproj/project.pbxproj 2014-10-07 18:41:49 UTC (rev 174400)
@@ -62,7 +62,7 @@
1A6BB769162F300500DD16DB /* StreamBuffer.h in Headers */ = {isa = PBXBuildFile; fileRef = 1A6BB768162F300500DD16DB /* StreamBuffer.h */; };
1A6EB1E0187D0BD30030126F /* StringView.h in Headers */ = {isa = PBXBuildFile; fileRef = 1A6EB1DF187D0BD30030126F /* StringView.h */; };
1ACADD841884480100D8B71D /* DeprecatedSymbolsUsedBySafari.mm in Sources */ = {isa = PBXBuildFile; fileRef = 1ACADD821884480100D8B71D /* DeprecatedSymbolsUsedBySafari.mm */; };
- 1AFDE648195201C300C48FFA /* TypeCasts.h in Headers */ = {isa = PBXBuildFile; fileRef = 1AFDE647195201C300C48FFA /* TypeCasts.h */; };
+ 1AFDE648195201C300C48FFA /* TypeCastsCF.h in Headers */ = {isa = PBXBuildFile; fileRef = 1AFDE647195201C300C48FFA /* TypeCastsCF.h */; };
1AFDE6531953B23D00C48FFA /* Optional.h in Headers */ = {isa = PBXBuildFile; fileRef = 1AFDE6521953B23D00C48FFA /* Optional.h */; };
1FA47C8A152502DA00568D1B /* WebCoreThread.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 1FA47C88152502DA00568D1B /* WebCoreThread.cpp */; };
1FA47C8B152502DA00568D1B /* WebCoreThread.h in Headers */ = {isa = PBXBuildFile; fileRef = 1FA47C89152502DA00568D1B /* WebCoreThread.h */; };
@@ -347,7 +347,7 @@
[webkit-changes] [174399] trunk/Source/WTF
Title: [174399] trunk/Source/WTF
Revision 174399
Author ander...@apple.com
Date 2014-10-07 10:15:40 -0700 (Tue, 07 Oct 2014)
Log Message
Try to fix the Mountain Lion build.
* wtf/text/StringView.h:
(WTF::StringView::underlyingStringIsValid):
(WTF::StringView::setUnderlyingString):
(WTF::StringView::invalidate):
Modified Paths
trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/text/StringView.h
Diff
Modified: trunk/Source/WTF/ChangeLog (174398 => 174399)
--- trunk/Source/WTF/ChangeLog 2014-10-07 16:36:00 UTC (rev 174398)
+++ trunk/Source/WTF/ChangeLog 2014-10-07 17:15:40 UTC (rev 174399)
@@ -1,5 +1,14 @@
2014-10-07 Anders Carlsson
+Try to fix the Mountain Lion build.
+
+* wtf/text/StringView.h:
+(WTF::StringView::underlyingStringIsValid):
+(WTF::StringView::setUnderlyingString):
+(WTF::StringView::invalidate):
+
+2014-10-07 Anders Carlsson
+
Use "1", not "true".
* wtf/text/StringView.h:
Modified: trunk/Source/WTF/wtf/text/StringView.h (174398 => 174399)
--- trunk/Source/WTF/wtf/text/StringView.h 2014-10-07 16:36:00 UTC (rev 174398)
+++ trunk/Source/WTF/wtf/text/StringView.h 2014-10-07 17:15:40 UTC (rev 174399)
@@ -116,9 +116,15 @@
void initialize(const LChar*, unsigned length);
void initialize(const UChar*, unsigned length);
+#if CHECK_STRINGVIEW_LIFETIME
WTF_EXPORT_STRING_API bool underlyingStringIsValid() const;
WTF_EXPORT_STRING_API void setUnderlyingString(const StringImpl*);
WTF_EXPORT_STRING_API void setUnderlyingString(const StringView&);
+#else
+bool underlyingStringIsValid() const { return true; }
+void setUnderlyingString(const StringImpl*) { }
+void setUnderlyingString(const StringView&) { }
+#endif
static const unsigned is16BitStringFlag = 1u << 31;
@@ -413,24 +419,9 @@
}
#if !CHECK_STRINGVIEW_LIFETIME
-
inline void StringView::invalidate(const StringImpl&)
{
}
-
-inline bool StringView::underlyingStringIsValid() const
-{
-return true;
-}
-
-inline void StringView::setUnderlyingString(const StringImpl*)
-{
-}
-
-inline void StringView::setUnderlyingString(const StringView&)
-{
-}
-
#endif
template class StringTypeAdapter;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [174398] trunk/Source/WTF
Title: [174398] trunk/Source/WTF Revision 174398 Author ander...@apple.com Date 2014-10-07 09:36:00 -0700 (Tue, 07 Oct 2014) Log Message Use "1", not "true". * wtf/text/StringView.h: Modified Paths trunk/Source/WTF/ChangeLog trunk/Source/WTF/wtf/text/StringView.h Diff Modified: trunk/Source/WTF/ChangeLog (174397 => 174398) --- trunk/Source/WTF/ChangeLog 2014-10-07 16:20:35 UTC (rev 174397) +++ trunk/Source/WTF/ChangeLog 2014-10-07 16:36:00 UTC (rev 174398) @@ -1,5 +1,11 @@ 2014-10-07 Anders Carlsson +Use "1", not "true". + +* wtf/text/StringView.h: + +2014-10-07 Anders Carlsson + Temporarily disable the StringView lifetime checking. * wtf/text/StringView.h: Modified: trunk/Source/WTF/wtf/text/StringView.h (174397 => 174398) --- trunk/Source/WTF/wtf/text/StringView.h 2014-10-07 16:20:35 UTC (rev 174397) +++ trunk/Source/WTF/wtf/text/StringView.h 2014-10-07 16:36:00 UTC (rev 174398) @@ -34,7 +34,7 @@ // FIXME: Enabling the StringView lifetime checking causes the MSVC build to fail. Figure out why. // FIXME: Enable StringView lifetime checking once the underlying assertions have been fixed. -#if defined(NDEBUG) || COMPILER(MSVC) || true +#if defined(NDEBUG) || COMPILER(MSVC) || 1 #define CHECK_STRINGVIEW_LIFETIME 0 #else #define CHECK_STRINGVIEW_LIFETIME 1 ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [174397] trunk/Source/WTF
Title: [174397] trunk/Source/WTF Revision 174397 Author ander...@apple.com Date 2014-10-07 09:20:35 -0700 (Tue, 07 Oct 2014) Log Message Temporarily disable the StringView lifetime checking. * wtf/text/StringView.h: Modified Paths trunk/Source/WTF/ChangeLog trunk/Source/WTF/wtf/text/StringView.h Diff Modified: trunk/Source/WTF/ChangeLog (174396 => 174397) --- trunk/Source/WTF/ChangeLog 2014-10-07 16:12:02 UTC (rev 174396) +++ trunk/Source/WTF/ChangeLog 2014-10-07 16:20:35 UTC (rev 174397) @@ -1,5 +1,11 @@ 2014-10-07 Anders Carlsson +Temporarily disable the StringView lifetime checking. + +* wtf/text/StringView.h: + +2014-10-07 Anders Carlsson + Another build fix attempt. * wtf/text/StringView.cpp: Modified: trunk/Source/WTF/wtf/text/StringView.h (174396 => 174397) --- trunk/Source/WTF/wtf/text/StringView.h 2014-10-07 16:12:02 UTC (rev 174396) +++ trunk/Source/WTF/wtf/text/StringView.h 2014-10-07 16:20:35 UTC (rev 174397) @@ -32,7 +32,9 @@ #include #include -#ifdef NDEBUG +// FIXME: Enabling the StringView lifetime checking causes the MSVC build to fail. Figure out why. +// FIXME: Enable StringView lifetime checking once the underlying assertions have been fixed. +#if defined(NDEBUG) || COMPILER(MSVC) || true #define CHECK_STRINGVIEW_LIFETIME 0 #else #define CHECK_STRINGVIEW_LIFETIME 1 ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [174396] trunk/Tools
Title: [174396] trunk/Tools Revision 174396 Author commit-qu...@webkit.org Date 2014-10-07 09:12:02 -0700 (Tue, 07 Oct 2014) Log Message [GTK] jhbuild modules should build xserver with the --without-dtrace option. https://bugs.webkit.org/show_bug.cgi?id=137482 Patch by Youenn Fablet on 2014-10-07 Reviewed by Martin Robinson. * gtk/jhbuild.modules: Added --without-dtrace option to xserver jhbuild.modules config. Modified Paths trunk/Tools/ChangeLog trunk/Tools/gtk/jhbuild.modules Diff Modified: trunk/Tools/ChangeLog (174395 => 174396) --- trunk/Tools/ChangeLog 2014-10-07 16:06:53 UTC (rev 174395) +++ trunk/Tools/ChangeLog 2014-10-07 16:12:02 UTC (rev 174396) @@ -1,3 +1,12 @@ +2014-10-07 Youenn Fablet + +[GTK] jhbuild modules should build xserver with the --without-dtrace option. +https://bugs.webkit.org/show_bug.cgi?id=137482 + +Reviewed by Martin Robinson. + +* gtk/jhbuild.modules: Added --without-dtrace option to xserver jhbuild.modules config. + 2014-10-07 Carlos Garcia Campos [SOUP] TLS errors should take precedence over HTTP authentication Modified: trunk/Tools/gtk/jhbuild.modules (174395 => 174396) --- trunk/Tools/gtk/jhbuild.modules 2014-10-07 16:06:53 UTC (rev 174395) +++ trunk/Tools/gtk/jhbuild.modules 2014-10-07 16:12:02 UTC (rev 174396) @@ -327,7 +327,7 @@ md5sum="4c300da1cf14b4e167d65cd5d8de1ef1"/> - + ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [174395] trunk/Source/WTF
Title: [174395] trunk/Source/WTF
Revision 174395
Author ander...@apple.com
Date 2014-10-07 09:06:53 -0700 (Tue, 07 Oct 2014)
Log Message
Another build fix attempt.
* wtf/text/StringView.cpp:
(WTF::StringView::UnderlyingString::UnderlyingString):
Modified Paths
trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/text/StringView.cpp
Diff
Modified: trunk/Source/WTF/ChangeLog (174394 => 174395)
--- trunk/Source/WTF/ChangeLog 2014-10-07 15:49:07 UTC (rev 174394)
+++ trunk/Source/WTF/ChangeLog 2014-10-07 16:06:53 UTC (rev 174395)
@@ -1,5 +1,12 @@
2014-10-07 Anders Carlsson
+Another build fix attempt.
+
+* wtf/text/StringView.cpp:
+(WTF::StringView::UnderlyingString::UnderlyingString):
+
+2014-10-07 Anders Carlsson
+
Try to fix the Windows build.
* wtf/text/StringView.cpp:
Modified: trunk/Source/WTF/wtf/text/StringView.cpp (174394 => 174395)
--- trunk/Source/WTF/wtf/text/StringView.cpp 2014-10-07 15:49:07 UTC (rev 174394)
+++ trunk/Source/WTF/wtf/text/StringView.cpp 2014-10-07 16:06:53 UTC (rev 174395)
@@ -38,15 +38,14 @@
// Manage reference count manually so UnderlyingString does not need to be defined in the header.
struct StringView::UnderlyingString {
-std::atomic_uint refCount;
+std::atomic_uint refCount { 1u };
bool isValid { true };
const StringImpl& string;
explicit UnderlyingString(const StringImpl&);
};
StringView::UnderlyingString::UnderlyingString(const StringImpl& string)
-: refCount(1)
-, string(string)
+: string(string)
{
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [174394] trunk
Title: [174394] trunk
Revision 174394
Author carlo...@webkit.org
Date 2014-10-07 08:49:07 -0700 (Tue, 07 Oct 2014)
Log Message
[SOUP] TLS errors should take precedence over HTTP authentication
https://bugs.webkit.org/show_bug.cgi?id=137300
Reviewed by Sergio Villar Senin.
Source/WebCore:
Handle TLS errors in got-headers callback to make sure it happens
before starting the authentication process.
* platform/network/soup/ResourceHandleSoup.cpp:
(WebCore::handleUnignoredTLSErrors): Refactored to receive the
soup message.
(WebCore::gotHeadersCallback): Return early and cancel the request in case of TLS errors.
(WebCore::sendRequestCallback): Do not handle TLS errors here, the request should have already been
cancelled at this point in case of TLS errors.
Tools:
Add a test case to check that authenticate signal is not emitted
in case of TLS errors, and the load fails instead.
* TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp:
(webViewAuthenticationCallback):
(testTLSErrorsHTTPAuth):
(httpsServerCallback):
(beforeAll):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/network/soup/ResourceHandleSoup.cpp
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (174393 => 174394)
--- trunk/Source/WebCore/ChangeLog 2014-10-07 15:47:15 UTC (rev 174393)
+++ trunk/Source/WebCore/ChangeLog 2014-10-07 15:49:07 UTC (rev 174394)
@@ -1,3 +1,20 @@
+2014-10-07 Carlos Garcia Campos
+
+[SOUP] TLS errors should take precedence over HTTP authentication
+https://bugs.webkit.org/show_bug.cgi?id=137300
+
+Reviewed by Sergio Villar Senin.
+
+Handle TLS errors in got-headers callback to make sure it happens
+before starting the authentication process.
+
+* platform/network/soup/ResourceHandleSoup.cpp:
+(WebCore::handleUnignoredTLSErrors): Refactored to receive the
+soup message.
+(WebCore::gotHeadersCallback): Return early and cancel the request in case of TLS errors.
+(WebCore::sendRequestCallback): Do not handle TLS errors here, the request should have already been
+cancelled at this point in case of TLS errors.
+
2014-10-07 Andy Estes
Fix a warning when passing an NSInteger to abs().
Modified: trunk/Source/WebCore/platform/network/soup/ResourceHandleSoup.cpp (174393 => 174394)
--- trunk/Source/WebCore/platform/network/soup/ResourceHandleSoup.cpp 2014-10-07 15:47:15 UTC (rev 174393)
+++ trunk/Source/WebCore/platform/network/soup/ResourceHandleSoup.cpp 2014-10-07 15:49:07 UTC (rev 174394)
@@ -306,12 +306,42 @@
return httpStatusCode == SOUP_STATUS_PROXY_AUTHENTICATION_REQUIRED || httpStatusCode == SOUP_STATUS_UNAUTHORIZED;
}
+static bool handleUnignoredTLSErrors(ResourceHandle* handle, SoupMessage* message)
+{
+if (gIgnoreSSLErrors)
+return false;
+
+GTlsCertificate* certificate = nullptr;
+GTlsCertificateFlags tlsErrors = static_cast(0);
+soup_message_get_https_status(message, &certificate, &tlsErrors);
+if (!tlsErrors)
+return false;
+
+String lowercaseHostURL = handle->firstRequest().url().host().lower();
+if (allowsAnyHTTPSCertificateHosts().contains(lowercaseHostURL))
+return false;
+
+// We aren't ignoring errors globally, but the user may have already decided to accept this certificate.
+auto it = clientCertificates().find(lowercaseHostURL);
+if (it != clientCertificates().end() && it->value.contains(certificate))
+return false;
+
+ResourceHandleInternal* d = handle->getInternal();
+handle->client()->didFail(handle, ResourceError::tlsError(d->m_soupRequest.get(), tlsErrors, certificate));
+return true;
+}
+
static void gotHeadersCallback(SoupMessage* message, gpointer data)
{
ResourceHandle* handle = static_cast(data);
if (!handle || handle->cancelledOrClientless())
return;
+if (handleUnignoredTLSErrors(handle, message)) {
+handle->cancel();
+return;
+}
+
ResourceHandleInternal* d = handle->getInternal();
#if PLATFORM(GTK)
@@ -569,27 +599,6 @@
handle->deref();
}
-static bool handleUnignoredTLSErrors(ResourceHandle* handle)
-{
-ResourceHandleInternal* d = handle->getInternal();
-const ResourceResponse& response = d->m_response;
-
-if (!response.soupMessageTLSErrors() || gIgnoreSSLErrors)
-return false;
-
-String lowercaseHostURL = handle->firstRequest().url().host().lower();
-if (allowsAnyHTTPSCertificateHosts().contains(lowercaseHostURL))
-return false;
-
-// We aren't ignoring errors globally, but the user may have already decided to accept this certificate.
-CertificatesMap::iterator i = clientCertificates().find(lowercaseHostURL);
-if (i != clientCertificates().end() && i->value.contains(response.soupMessageCertificate()))
-return false;
-
-handle->client()->didFail(handle, ResourceError::tls
[webkit-changes] [174393] trunk/Source/WTF
Title: [174393] trunk/Source/WTF
Revision 174393
Author ander...@apple.com
Date 2014-10-07 08:47:15 -0700 (Tue, 07 Oct 2014)
Log Message
Try to fix the Windows build.
* wtf/text/StringView.cpp:
(WTF::StringView::UnderlyingString::UnderlyingString):
Modified Paths
trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/text/StringView.cpp
Diff
Modified: trunk/Source/WTF/ChangeLog (174392 => 174393)
--- trunk/Source/WTF/ChangeLog 2014-10-07 07:42:40 UTC (rev 174392)
+++ trunk/Source/WTF/ChangeLog 2014-10-07 15:47:15 UTC (rev 174393)
@@ -1,3 +1,10 @@
+2014-10-07 Anders Carlsson
+
+Try to fix the Windows build.
+
+* wtf/text/StringView.cpp:
+(WTF::StringView::UnderlyingString::UnderlyingString):
+
2014-10-06 Darin Adler
Make StringView check the lifetime of the StringImpl it's created from
Modified: trunk/Source/WTF/wtf/text/StringView.cpp (174392 => 174393)
--- trunk/Source/WTF/wtf/text/StringView.cpp 2014-10-07 07:42:40 UTC (rev 174392)
+++ trunk/Source/WTF/wtf/text/StringView.cpp 2014-10-07 15:47:15 UTC (rev 174393)
@@ -38,14 +38,15 @@
// Manage reference count manually so UnderlyingString does not need to be defined in the header.
struct StringView::UnderlyingString {
-std::atomic_uint refCount { 1 };
+std::atomic_uint refCount;
bool isValid { true };
const StringImpl& string;
explicit UnderlyingString(const StringImpl&);
};
StringView::UnderlyingString::UnderlyingString(const StringImpl& string)
-: string(string)
+: refCount(1)
+, string(string)
{
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [174392] releases/WebKitGTK/webkit-2.6/Source
Title: [174392] releases/WebKitGTK/webkit-2.6/Source Revision 174392 Author carlo...@webkit.org Date 2014-10-07 00:42:40 -0700 (Tue, 07 Oct 2014) Log Message Merge r173776 - Multithreaded WebGL is a bad idea - remove it https://bugs.webkit.org/show_bug.cgi?id=136964 Reviewed by Brent Fulgham. Source/WebCore: We should not allow multithreaded GL access. Remove the feature. * html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::create): * page/Settings.in: * platform/graphics/GraphicsContext3D.h: (WebCore::GraphicsContext3D::Attributes::Attributes): * platform/graphics/mac/GraphicsContext3DMac.mm: (WebCore::GraphicsContext3D::GraphicsContext3D): Source/WebKit/mac: Remove the setting to allow multithreaded WebGL. * WebView/WebPreferenceKeysPrivate.h: * WebView/WebPreferences.mm: (+[WebPreferences initialize]): (-[WebPreferences multithreadedWebGLEnabled]): Deleted. (-[WebPreferences setMultithreadedWebGLEnabled:]): Deleted. * WebView/WebPreferencesPrivate.h: * WebView/WebView.mm: (-[WebView _preferencesChanged:]): Source/WebKit2: Remove the setting to allow multithreaded WebGL. * Shared/WebPreferencesDefinitions.h: * UIProcess/API/C/WKPreferences.cpp: (WKPreferencesSetMultithreadedWebGLEnabled): Deleted. (WKPreferencesGetMultithreadedWebGLEnabled): Deleted. * UIProcess/API/C/WKPreferencesRefPrivate.h: * WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::updatePreferences): Modified Paths releases/WebKitGTK/webkit-2.6/Source/WebCore/ChangeLog releases/WebKitGTK/webkit-2.6/Source/WebCore/html/canvas/WebGLRenderingContext.cpp releases/WebKitGTK/webkit-2.6/Source/WebCore/page/Settings.in releases/WebKitGTK/webkit-2.6/Source/WebCore/platform/graphics/GraphicsContext3D.h releases/WebKitGTK/webkit-2.6/Source/WebCore/platform/graphics/mac/GraphicsContext3DMac.mm releases/WebKitGTK/webkit-2.6/Source/WebKit/mac/ChangeLog releases/WebKitGTK/webkit-2.6/Source/WebKit/mac/WebView/WebPreferenceKeysPrivate.h releases/WebKitGTK/webkit-2.6/Source/WebKit/mac/WebView/WebPreferences.mm releases/WebKitGTK/webkit-2.6/Source/WebKit/mac/WebView/WebPreferencesPrivate.h releases/WebKitGTK/webkit-2.6/Source/WebKit/mac/WebView/WebView.mm releases/WebKitGTK/webkit-2.6/Source/WebKit2/ChangeLog releases/WebKitGTK/webkit-2.6/Source/WebKit2/Shared/WebPreferencesDefinitions.h releases/WebKitGTK/webkit-2.6/Source/WebKit2/UIProcess/API/C/WKPreferences.cpp releases/WebKitGTK/webkit-2.6/Source/WebKit2/UIProcess/API/C/WKPreferencesRefPrivate.h releases/WebKitGTK/webkit-2.6/Source/WebKit2/WebProcess/WebPage/WebPage.cpp Diff Modified: releases/WebKitGTK/webkit-2.6/Source/WebCore/ChangeLog (174391 => 174392) --- releases/WebKitGTK/webkit-2.6/Source/WebCore/ChangeLog 2014-10-07 07:26:41 UTC (rev 174391) +++ releases/WebKitGTK/webkit-2.6/Source/WebCore/ChangeLog 2014-10-07 07:42:40 UTC (rev 174392) @@ -1,3 +1,22 @@ +2014-09-19 Dean Jackson + +Multithreaded WebGL is a bad idea - remove it +https://bugs.webkit.org/show_bug.cgi?id=136964 + + +Reviewed by Brent Fulgham. + +We should not allow multithreaded GL access. Remove the +feature. + +* html/canvas/WebGLRenderingContext.cpp: +(WebCore::WebGLRenderingContext::create): +* page/Settings.in: +* platform/graphics/GraphicsContext3D.h: +(WebCore::GraphicsContext3D::Attributes::Attributes): +* platform/graphics/mac/GraphicsContext3DMac.mm: +(WebCore::GraphicsContext3D::GraphicsContext3D): + 2014-09-26 Lorenzo Tilve [GTK] Fix support for the initial-letter CSS property to first-letter Modified: releases/WebKitGTK/webkit-2.6/Source/WebCore/html/canvas/WebGLRenderingContext.cpp (174391 => 174392) --- releases/WebKitGTK/webkit-2.6/Source/WebCore/html/canvas/WebGLRenderingContext.cpp 2014-10-07 07:26:41 UTC (rev 174391) +++ releases/WebKitGTK/webkit-2.6/Source/WebCore/html/canvas/WebGLRenderingContext.cpp 2014-10-07 07:42:40 UTC (rev 174392) @@ -431,9 +431,6 @@ attributes.shareResources = false; attributes.preferDiscreteGPU = true; -if (frame->settings().multithreadedWebGLEnabled()) -attributes.multithreaded = true; - if (frame->settings().forceSoftwareWebGLRendering()) attributes.forceSoftwareRenderer = true; Modified: releases/WebKitGTK/webkit-2.6/Source/WebCore/page/Settings.in (174391 => 174392) --- releases/WebKitGTK/webkit-2.6/Source/WebCore/page/Settings.in 2014-10-07 07:26:41 UTC (rev 174391) +++ releases/WebKitGTK/webkit-2.6/Source/WebCore/page/Settings.in 2014-10-07 07:42:40 UTC (rev 174392) @@ -100,7 +100,6 @@ webGLEnabled initial=false webGLErrorsToConsoleEnabled initial=true openGLMultisamplingEnabled initial=true -multithreadedWebGLEnabled initial=false privilegedWebGLExtensionsEnabled initial=false forceSoftwareWebGLRendering initial=false accelerated2dCanvasEnabled initial=false Modified: releases/WebKitGTK/webkit-2.6/Source/WebCore/platform/graphics/GraphicsContext3D.h (174391 =
[webkit-changes] [174391] releases/WebKitGTK/webkit-2.6
Title: [174391] releases/WebKitGTK/webkit-2.6
Revision 174391
Author carlo...@webkit.org
Date 2014-10-07 00:26:41 -0700 (Tue, 07 Oct 2014)
Log Message
Merge r174002 - [GTK] Fix support for the initial-letter CSS property to first-letter
https://bugs.webkit.org/show_bug.cgi?id=137108
Patch by Lorenzo Tilve on 2014-09-26
Reviewed by Alejandro G. Castro.
Source/WebCore:
Add support for cap-height to the font system.
* platform/graphics/freetype/SimpleFontDataFreeType.cpp:
(WebCore::SimpleFontData::platformInit):
LayoutTests:
Add missing GTK test expectation files after http://webkit.org/b/136484
* platform/gtk/fast/css-generated-content/initial-letter-basic-expected.txt: Added.
* platform/gtk/fast/css-generated-content/initial-letter-border-padding-expected.txt: Added.
* platform/gtk/fast/css-generated-content/initial-letter-clearance-expected.txt: Added.
* platform/gtk/fast/css-generated-content/initial-letter-descender-expected.txt: Added.
* platform/gtk/fast/css-generated-content/initial-letter-raised-expected.txt: Added.
* platform/gtk/fast/css-generated-content/initial-letter-sunken-expected.txt: Added.
Modified Paths
releases/WebKitGTK/webkit-2.6/LayoutTests/ChangeLog
releases/WebKitGTK/webkit-2.6/Source/WebCore/ChangeLog
releases/WebKitGTK/webkit-2.6/Source/WebCore/platform/graphics/freetype/SimpleFontDataFreeType.cpp
Added Paths
releases/WebKitGTK/webkit-2.6/LayoutTests/platform/gtk/fast/css-generated-content/initial-letter-basic-expected.txt
releases/WebKitGTK/webkit-2.6/LayoutTests/platform/gtk/fast/css-generated-content/initial-letter-border-padding-expected.txt
releases/WebKitGTK/webkit-2.6/LayoutTests/platform/gtk/fast/css-generated-content/initial-letter-clearance-expected.txt
releases/WebKitGTK/webkit-2.6/LayoutTests/platform/gtk/fast/css-generated-content/initial-letter-descender-expected.txt
releases/WebKitGTK/webkit-2.6/LayoutTests/platform/gtk/fast/css-generated-content/initial-letter-raised-expected.txt
releases/WebKitGTK/webkit-2.6/LayoutTests/platform/gtk/fast/css-generated-content/initial-letter-sunken-expected.txt
Diff
Modified: releases/WebKitGTK/webkit-2.6/LayoutTests/ChangeLog (174390 => 174391)
--- releases/WebKitGTK/webkit-2.6/LayoutTests/ChangeLog 2014-10-07 07:23:14 UTC (rev 174390)
+++ releases/WebKitGTK/webkit-2.6/LayoutTests/ChangeLog 2014-10-07 07:26:41 UTC (rev 174391)
@@ -1,3 +1,19 @@
+2014-09-26 Lorenzo Tilve
+
+[GTK] Fix support for the initial-letter CSS property to first-letter
+https://bugs.webkit.org/show_bug.cgi?id=137108
+
+Reviewed by Alejandro G. Castro.
+
+Add missing GTK test expectation files after http://webkit.org/b/136484
+
+* platform/gtk/fast/css-generated-content/initial-letter-basic-expected.txt: Added.
+* platform/gtk/fast/css-generated-content/initial-letter-border-padding-expected.txt: Added.
+* platform/gtk/fast/css-generated-content/initial-letter-clearance-expected.txt: Added.
+* platform/gtk/fast/css-generated-content/initial-letter-descender-expected.txt: Added.
+* platform/gtk/fast/css-generated-content/initial-letter-raised-expected.txt: Added.
+* platform/gtk/fast/css-generated-content/initial-letter-sunken-expected.txt: Added.
+
2014-09-22 David Hyatt
Bad cast in isValidColumnSpanner.
Added: releases/WebKitGTK/webkit-2.6/LayoutTests/platform/gtk/fast/css-generated-content/initial-letter-basic-expected.txt (0 => 174391)
--- releases/WebKitGTK/webkit-2.6/LayoutTests/platform/gtk/fast/css-generated-content/initial-letter-basic-expected.txt (rev 0)
+++ releases/WebKitGTK/webkit-2.6/LayoutTests/platform/gtk/fast/css-generated-content/initial-letter-basic-expected.txt 2014-10-07 07:26:41 UTC (rev 174391)
@@ -0,0 +1,27 @@
+layer at (0,0) size 800x600
+ RenderView at (0,0) size 800x600
+layer at (0,0) size 800x600
+ RenderBlock {HTML} at (0,0) size 800x600
+RenderBody {BODY} at (8,16) size 784x568
+ RenderBlock {DIV} at (16,0) size 400x85
+RenderBlock (floating) at (2,-3) size 33x52
+ RenderText {#text} at (0,10) size 33x51
+text run at (0,10) width 33: "A"
+RenderText {#text} at (37,0) size 398x85
+ text run at (37,0) width 358: "n example of first-letter. This letter should span 3 lines of"
+ text run at (37,17) width 334: "text, and so it should align itself cleanly with the cap-"
+ text run at (37,34) width 348: "height of the A lining up with the cap-height of the first"
+ text run at (0,51) width 398: "line, and the baseline of the A lining up with the baseline of the"
+ text run at (0,68) width 60: "third line."
+ RenderBlock {SPAN} at (0,101) size 784x85
+RenderBlock {DIV} at (368,0) size 400x85
+ RenderBlock (floating) at (365,-3) size 33x52
+RenderText {#text} at (0,10) size 33x51
+ text run at (0,10) width 33: "A"
+ RenderText {#text} at (20
[webkit-changes] [174389] trunk/Source/WebCore
Title: [174389] trunk/Source/WebCore Revision 174389 Author aes...@apple.com Date 2014-10-07 00:06:27 -0700 (Tue, 07 Oct 2014) Log Message Fix a warning when passing an NSInteger to abs(). https://bugs.webkit.org/show_bug.cgi?id=137480 Reviewed by Mark Rowe. Use std::abs() instead, which is overloaded for both long (a.k.a. NSInteger) and int. * platform/graphics/avfoundation/objc/CDMSessionMediaSourceAVFObjC.mm: (WebCore::CDMSessionMediaSourceAVFObjC::layerDidReceiveError): (WebCore::CDMSessionMediaSourceAVFObjC::rendererDidReceiveError): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/platform/graphics/avfoundation/objc/CDMSessionMediaSourceAVFObjC.mm Diff Modified: trunk/Source/WebCore/ChangeLog (174388 => 174389) --- trunk/Source/WebCore/ChangeLog 2014-10-07 06:58:41 UTC (rev 174388) +++ trunk/Source/WebCore/ChangeLog 2014-10-07 07:06:27 UTC (rev 174389) @@ -1,3 +1,16 @@ +2014-10-07 Andy Estes + +Fix a warning when passing an NSInteger to abs(). +https://bugs.webkit.org/show_bug.cgi?id=137480 + +Reviewed by Mark Rowe. + +Use std::abs() instead, which is overloaded for both long (a.k.a. NSInteger) and int. + +* platform/graphics/avfoundation/objc/CDMSessionMediaSourceAVFObjC.mm: +(WebCore::CDMSessionMediaSourceAVFObjC::layerDidReceiveError): +(WebCore::CDMSessionMediaSourceAVFObjC::rendererDidReceiveError): + 2014-10-06 Darin Adler Make StringView check the lifetime of the StringImpl it's created from Modified: trunk/Source/WebCore/platform/graphics/avfoundation/objc/CDMSessionMediaSourceAVFObjC.mm (174388 => 174389) --- trunk/Source/WebCore/platform/graphics/avfoundation/objc/CDMSessionMediaSourceAVFObjC.mm 2014-10-07 06:58:41 UTC (rev 174388) +++ trunk/Source/WebCore/platform/graphics/avfoundation/objc/CDMSessionMediaSourceAVFObjC.mm 2014-10-07 07:06:27 UTC (rev 174389) @@ -37,6 +37,7 @@ #import "SoftLinking.h" #import "UUID.h" #import +#import #import #import #import @@ -216,7 +217,7 @@ if (!m_client) return; -m_client->sendError(CDMSessionClient::MediaKeyErrorDomain, abs([error code])); +m_client->sendError(CDMSessionClient::MediaKeyErrorDomain, std::abs([error code])); } void CDMSessionMediaSourceAVFObjC::rendererDidReceiveError(AVSampleBufferAudioRenderer *, NSError *error) @@ -224,7 +225,7 @@ if (!m_client) return; -m_client->sendError(CDMSessionClient::MediaKeyErrorDomain, abs([error code])); +m_client->sendError(CDMSessionClient::MediaKeyErrorDomain, std::abs([error code])); } void CDMSessionMediaSourceAVFObjC::addSourceBuffer(SourceBufferPrivateAVFObjC* sourceBuffer) ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
