[webkit-changes] [182839] trunk/LayoutTests

[ap]

Title: [182839] trunk/LayoutTests








Revision 182839
Author a...@apple.com
Date 2015-04-14 22:44:01 -0700 (Tue, 14 Apr 2015)


Log Message
inspector/console/console-api.html is very slow, frequently timing out
https://bugs.webkit.org/show_bug.cgi?id=143719

* TestExpectations: Further adjusted the expectations.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (182838 => 182839)

--- trunk/LayoutTests/ChangeLog	2015-04-15 05:28:29 UTC (rev 182838)
+++ trunk/LayoutTests/ChangeLog	2015-04-15 05:44:01 UTC (rev 182839)
@@ -1,5 +1,12 @@
 2015-04-14  Alexey Proskuryakov  
 
+inspector/console/console-api.html is very slow, frequently timing out
+https://bugs.webkit.org/show_bug.cgi?id=143719
+
+* TestExpectations: Further adjusted the expectations.
+
+2015-04-14  Alexey Proskuryakov  
+
 fast/dom/Window/timer-resume-on-navigation-back.html is flaky
 https://bugs.webkit.org/show_bug.cgi?id=33685
 


Modified: trunk/LayoutTests/TestExpectations (182838 => 182839)

--- trunk/LayoutTests/TestExpectations	2015-04-15 05:28:29 UTC (rev 182838)
+++ trunk/LayoutTests/TestExpectations	2015-04-15 05:44:01 UTC (rev 182839)
@@ -105,7 +105,7 @@
 # Doesn't work yet, relies on network replay functionality (webkit.org/b/130728, webkit.org/b/129391)
 webkit.org/b/131318 http/tests/inspector/replay/document-last-modified-fallback-value.html [ Skip ]
 
-[ Debug ] inspector/console/console-api.html [ Slow ]
+[ Debug ] inspector/console/console-api.html [ Pass Timeout ]
 
 # Collecting region's children in a named flow not supported yet
 webkit.org/b/74144 fast/regions/flow-body-in-html.html [ Skip ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [182838] trunk/LayoutTests

[ap]

Title: [182838] trunk/LayoutTests








Revision 182838
Author a...@apple.com
Date 2015-04-14 22:28:29 -0700 (Tue, 14 Apr 2015)


Log Message
fast/dom/Window/timer-resume-on-navigation-back.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=33685

Reviewed by Brady Eidson.

If the timer fired before navigation, the test passed without going down the code
path that it was supposed to test. If it fired when navigation was in provisional
state, then dumping results was delayed until the navigation was finished, and
thus the intermediate page got dumped, and the test failed.

* fast/dom/Window/timer-resume-on-navigation-back.html:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/dom/Window/timer-resume-on-navigation-back.html




Diff

Modified: trunk/LayoutTests/ChangeLog (182837 => 182838)

--- trunk/LayoutTests/ChangeLog	2015-04-15 04:43:42 UTC (rev 182837)
+++ trunk/LayoutTests/ChangeLog	2015-04-15 05:28:29 UTC (rev 182838)
@@ -1,3 +1,17 @@
+2015-04-14  Alexey Proskuryakov  
+
+fast/dom/Window/timer-resume-on-navigation-back.html is flaky
+https://bugs.webkit.org/show_bug.cgi?id=33685
+
+Reviewed by Brady Eidson.
+
+If the timer fired before navigation, the test passed without going down the code
+path that it was supposed to test. If it fired when navigation was in provisional
+state, then dumping results was delayed until the navigation was finished, and
+thus the intermediate page got dumped, and the test failed.
+
+* fast/dom/Window/timer-resume-on-navigation-back.html:
+
 2015-04-14  Zalan Bujtas  
 
 Make inline continuation style change logic consistent.


Modified: trunk/LayoutTests/fast/dom/Window/timer-resume-on-navigation-back.html (182837 => 182838)

--- trunk/LayoutTests/fast/dom/Window/timer-resume-on-navigation-back.html	2015-04-15 04:43:42 UTC (rev 182837)
+++ trunk/LayoutTests/fast/dom/Window/timer-resume-on-navigation-back.html	2015-04-15 05:28:29 UTC (rev 182838)
@@ -2,8 +2,20 @@
 

[webkit-changes] [182837] branches/safari-600.6-branch/Source

[lforschler]

Title: [182837] branches/safari-600.6-branch/Source








Revision 182837
Author lforsch...@apple.com
Date 2015-04-14 21:43:42 -0700 (Tue, 14 Apr 2015)


Log Message
Versioning.

Modified Paths

branches/safari-600.6-branch/Source/_javascript_Core/Configurations/Version.xcconfig
branches/safari-600.6-branch/Source/WebCore/Configurations/Version.xcconfig
branches/safari-600.6-branch/Source/WebInspectorUI/Configurations/Version.xcconfig
branches/safari-600.6-branch/Source/WebKit/mac/Configurations/Version.xcconfig
branches/safari-600.6-branch/Source/WebKit2/Configurations/Version.xcconfig




Diff

Modified: branches/safari-600.6-branch/Source/_javascript_Core/Configurations/Version.xcconfig (182836 => 182837)

--- branches/safari-600.6-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2015-04-15 04:37:50 UTC (rev 182836)
+++ branches/safari-600.6-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2015-04-15 04:43:42 UTC (rev 182837)
@@ -22,8 +22,8 @@
 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 
 
 MAJOR_VERSION = 600;
-MINOR_VERSION = 5;
-TINY_VERSION = 18;
+MINOR_VERSION = 6;
+TINY_VERSION = 1;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: branches/safari-600.6-branch/Source/WebCore/Configurations/Version.xcconfig (182836 => 182837)

--- branches/safari-600.6-branch/Source/WebCore/Configurations/Version.xcconfig	2015-04-15 04:37:50 UTC (rev 182836)
+++ branches/safari-600.6-branch/Source/WebCore/Configurations/Version.xcconfig	2015-04-15 04:43:42 UTC (rev 182837)
@@ -22,8 +22,8 @@
 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 
 
 MAJOR_VERSION = 600;
-MINOR_VERSION = 5;
-TINY_VERSION = 18;
+MINOR_VERSION = 6;
+TINY_VERSION = 1;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: branches/safari-600.6-branch/Source/WebInspectorUI/Configurations/Version.xcconfig (182836 => 182837)

--- branches/safari-600.6-branch/Source/WebInspectorUI/Configurations/Version.xcconfig	2015-04-15 04:37:50 UTC (rev 182836)
+++ branches/safari-600.6-branch/Source/WebInspectorUI/Configurations/Version.xcconfig	2015-04-15 04:43:42 UTC (rev 182837)
@@ -1,6 +1,6 @@
 MAJOR_VERSION = 600;
-MINOR_VERSION = 5;
-TINY_VERSION = 18;
+MINOR_VERSION = 6;
+TINY_VERSION = 1;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: branches/safari-600.6-branch/Source/WebKit/mac/Configurations/Version.xcconfig (182836 => 182837)

--- branches/safari-600.6-branch/Source/WebKit/mac/Configurations/Version.xcconfig	2015-04-15 04:37:50 UTC (rev 182836)
+++ branches/safari-600.6-branch/Source/WebKit/mac/Configurations/Version.xcconfig	2015-04-15 04:43:42 UTC (rev 182837)
@@ -22,8 +22,8 @@
 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 
 
 MAJOR_VERSION = 600;
-MINOR_VERSION = 5;
-TINY_VERSION = 18;
+MINOR_VERSION = 6;
+TINY_VERSION = 1;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: branches/safari-600.6-branch/Source/WebKit2/Configurations/Version.xcconfig (182836 => 182837)

--- branches/safari-600.6-branch/Source/WebKit2/Configurations/Version.xcconfig	2015-04-15 04:37:50 UTC (rev 182836)
+++ branches/safari-600.6-branch/Source/WebKit2/Configurations/Version.xcconfig	2015-04-15 04:43:42 UTC (rev 182837)
@@ -22,8 +22,8 @@
 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 
 
 MAJOR_VERSION = 600;
-MINOR_VERSION = 5;
-TINY_VERSION = 18;
+MINOR_VERSION = 6;
+TINY_VERSION = 1;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [182836] branches/safari-600.6-branch/

[lforschler]

Title: [182836] branches/safari-600.6-branch/








Revision 182836
Author lforsch...@apple.com
Date 2015-04-14 21:37:50 -0700 (Tue, 14 Apr 2015)


Log Message
New branch.

Added Paths

branches/safari-600.6-branch/




Diff

Property changes: branches/safari-600.6-branch



Added: svn:ignore
depcomp
compile
config.guess
GNUmakefile.in
config.sub
ltmain.sh
aconfig.h.in
autom4te.cache
missing
aclocal.m4
install-sh
autotoolsconfig.h.in
INSTALL
README
gtk-doc.make
out
Makefile.chromium
WebKitSupportLibrary.zip
WebKitBuild

Added: svn:mergeinfo




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [182835] trunk

[zalan]

Title: [182835] trunk








Revision 182835
Author za...@apple.com
Date 2015-04-14 21:24:14 -0700 (Tue, 14 Apr 2015)


Log Message
Make inline continuation style change logic consistent.
https://bugs.webkit.org/show_bug.cgi?id=143737
rdar://problem/20486596

Reviewed by Simon Fraser.

Do not force RenderBlock type-casting on the first sibling of the continuation's container.
The first sibling of the container of a continuation should be handled as the rest of the siblings.

Source/WebCore:

Test: fast/inline/inline-with-column-span-and-remove-block-child-crash.html

* rendering/RenderInline.cpp:
(WebCore::updateStyleOfAnonymousBlockContinuations):
(WebCore::RenderInline::styleDidChange):

LayoutTests:

* fast/inline/inline-with-column-span-and-remove-block-child-crash-expected.txt: Added.
* fast/inline/inline-with-column-span-and-remove-block-child-crash.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderInline.cpp


Added Paths

trunk/LayoutTests/fast/inline/inline-with-column-span-and-remove-block-child-crash-expected.txt
trunk/LayoutTests/fast/inline/inline-with-column-span-and-remove-block-child-crash.html




Diff

Modified: trunk/LayoutTests/ChangeLog (182834 => 182835)

--- trunk/LayoutTests/ChangeLog	2015-04-15 03:57:19 UTC (rev 182834)
+++ trunk/LayoutTests/ChangeLog	2015-04-15 04:24:14 UTC (rev 182835)
@@ -1,3 +1,17 @@
+2015-04-14  Zalan Bujtas  
+
+Make inline continuation style change logic consistent.
+https://bugs.webkit.org/show_bug.cgi?id=143737
+rdar://problem/20486596
+
+Reviewed by Simon Fraser.
+
+Do not force RenderBlock type-casting on the first sibling of the continuation's container.
+The first sibling of the container of a continuation should be handled as the rest of the siblings.
+
+* fast/inline/inline-with-column-span-and-remove-block-child-crash-expected.txt: Added.
+* fast/inline/inline-with-column-span-and-remove-block-child-crash.html: Added.
+
 2015-04-14  Daniel Bates  
 
 Rename test LayoutTests/fast/events/drag-link.html to drag-and-drop-link-into-focused-contenteditable.html


Added: trunk/LayoutTests/fast/inline/inline-with-column-span-and-remove-block-child-crash-expected.txt (0 => 182835)

--- trunk/LayoutTests/fast/inline/inline-with-column-span-and-remove-block-child-crash-expected.txt	(rev 0)
+++ trunk/LayoutTests/fast/inline/inline-with-column-span-and-remove-block-child-crash-expected.txt	2015-04-15 04:24:14 UTC (rev 182835)
@@ -0,0 +1,2 @@
+Pass if no crash or assert in debug.
+


Added: trunk/LayoutTests/fast/inline/inline-with-column-span-and-remove-block-child-crash.html (0 => 182835)

--- trunk/LayoutTests/fast/inline/inline-with-column-span-and-remove-block-child-crash.html	(rev 0)
+++ trunk/LayoutTests/fast/inline/inline-with-column-span-and-remove-block-child-crash.html	2015-04-15 04:24:14 UTC (rev 182835)
@@ -0,0 +1,34 @@
+
+
+
+  This test that when the block element is removed from an inline element when column span is present, we do not crash.
+  
+#container {
+  -webkit-column-count: 2; 
+}
+#after {
+  -webkit-column-span: all;
+}
+  
+
+
+
+  Pass if no crash or assert in debug.
+
+  
+  
+
+
+
+
+  if (window.testRunner)
+testRunner.dumpAsText();
+
+  document.execCommand("SelectAll");
+
+  var elem = document.getElementById("removethis");
+  elem.parentNode.removeChild(elem);
+
+  document.getElementById("outer").style.position = "relative";
+
+


Modified: trunk/Source/WebCore/ChangeLog (182834 => 182835)

--- trunk/Source/WebCore/ChangeLog	2015-04-15 03:57:19 UTC (rev 182834)
+++ trunk/Source/WebCore/ChangeLog	2015-04-15 04:24:14 UTC (rev 182835)
@@ -1,3 +1,20 @@
+2015-04-14  Zalan Bujtas  
+
+Make inline continuation style change logic consistent.
+https://bugs.webkit.org/show_bug.cgi?id=143737
+rdar://problem/20486596
+
+Reviewed by Simon Fraser.
+
+Do not force RenderBlock type-casting on the first sibling of the continuation's container.
+The first sibling of the container of a continuation should be handled as the rest of the siblings.
+
+Test: fast/inline/inline-with-column-span-and-remove-block-child-crash.html
+
+* rendering/RenderInline.cpp:
+(WebCore::updateStyleOfAnonymousBlockContinuations):
+(WebCore::RenderInline::styleDidChange):
+
 2015-04-14  Chris Dumez  
 
 Regression(r180020): Web Inspector crashes on pages that have a stylesheet with an invalid MIME type


Modified: trunk/Source/WebCore/rendering/RenderInline.cpp (182834 => 182835)

--- trunk/Source/WebCore/rendering/RenderInline.cpp	2015-04-15 03:57:19 UTC (rev 182834)
+++ trunk/Source/WebCore/rendering/RenderInline.cpp	2015-04-15 04:24:14 UTC (rev 182835)
@@ -139,9 +139,10 @@
 return 0;
 }
 
-static void updateStyleOfAnonymousBlockContinuations(RenderBlo

[webkit-changes] [182834] trunk/Source/WebInspectorUI

[commit-queue]

Title: [182834] trunk/Source/WebInspectorUI








Revision 182834
Author commit-qu...@webkit.org
Date 2015-04-14 20:57:19 -0700 (Tue, 14 Apr 2015)


Log Message
Web Inspector: Uncaught exception in JSContext inspector when opening
https://bugs.webkit.org/show_bug.cgi?id=143741

Patch by Joseph Pecoraro  on 2015-04-14
Reviewed by Timothy Hatcher.

* UserInterface/Controllers/TimelineManager.js:
(WebInspector.TimelineManager.shouldShowViewForTimeline):
(WebInspector.TimelineManager.prototype._loadNewRecording):
Before using TimelineAgent, check for its existence first. It may
not exist in JSContext inspection.

Modified Paths

trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/Controllers/TimelineManager.js




Diff

Modified: trunk/Source/WebInspectorUI/ChangeLog (182833 => 182834)

--- trunk/Source/WebInspectorUI/ChangeLog	2015-04-15 02:29:21 UTC (rev 182833)
+++ trunk/Source/WebInspectorUI/ChangeLog	2015-04-15 03:57:19 UTC (rev 182834)
@@ -1,3 +1,16 @@
+2015-04-14  Joseph Pecoraro  
+
+Web Inspector: Uncaught exception in JSContext inspector when opening
+https://bugs.webkit.org/show_bug.cgi?id=143741
+
+Reviewed by Timothy Hatcher.
+
+* UserInterface/Controllers/TimelineManager.js:
+(WebInspector.TimelineManager.shouldShowViewForTimeline):
+(WebInspector.TimelineManager.prototype._loadNewRecording):
+Before using TimelineAgent, check for its existence first. It may
+not exist in JSContext inspection.
+
 2015-04-14  Nikita Vasilyev  
 
 Web Inspector: Align array's indices and set's bullet points under the property icon


Modified: trunk/Source/WebInspectorUI/UserInterface/Controllers/TimelineManager.js (182833 => 182834)

--- trunk/Source/WebInspectorUI/UserInterface/Controllers/TimelineManager.js	2015-04-15 02:29:21 UTC (rev 182833)
+++ trunk/Source/WebInspectorUI/UserInterface/Controllers/TimelineManager.js	2015-04-15 03:57:19 UTC (rev 182834)
@@ -56,7 +56,7 @@
 {
 // COMPATIBILITY (iOS 8): TimelineAgent.EventType.RenderingFrame did not exist,
 // fallback to displaying all other timelines.
-if (!TimelineAgent.EventType.RenderingFrame)
+if (window.TimelineAgent && !TimelineAgent.EventType.RenderingFrame)
 return timeline.type !== WebInspector.TimelineRecord.Type.RenderingFrame;
 
 // Don't show the Layout timeline view when the RenderingFrame timeline exists.
@@ -437,7 +437,7 @@
 newRecording.addTimeline(WebInspector.Timeline.create(WebInspector.TimelineRecord.Type.Network, newRecording));
 
 // COMPATIBILITY (iOS 8): TimelineAgent.EventType.RenderingFrame did not exist.
-if (TimelineAgent.EventType.RenderingFrame)
+if (window.TimelineAgent && TimelineAgent.EventType.RenderingFrame)
 newRecording.addTimeline(WebInspector.Timeline.create(WebInspector.TimelineRecord.Type.RenderingFrame, newRecording));
 
 newRecording.addTimeline(WebInspector.Timeline.create(WebInspector.TimelineRecord.Type.Layout, newRecording));






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [182833] trunk/Source

[bshafiei]

Title: [182833] trunk/Source








Revision 182833
Author bshaf...@apple.com
Date 2015-04-14 19:29:21 -0700 (Tue, 14 Apr 2015)


Log Message
Versioning.

Modified Paths

trunk/Source/_javascript_Core/Configurations/Version.xcconfig
trunk/Source/WebCore/Configurations/Version.xcconfig
trunk/Source/WebInspectorUI/Configurations/Version.xcconfig
trunk/Source/WebKit/mac/Configurations/Version.xcconfig
trunk/Source/WebKit2/Configurations/Version.xcconfig




Diff

Modified: trunk/Source/_javascript_Core/Configurations/Version.xcconfig (182832 => 182833)

--- trunk/Source/_javascript_Core/Configurations/Version.xcconfig	2015-04-15 02:27:26 UTC (rev 182832)
+++ trunk/Source/_javascript_Core/Configurations/Version.xcconfig	2015-04-15 02:29:21 UTC (rev 182833)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 601;
 MINOR_VERSION = 1;
-TINY_VERSION = 27;
+TINY_VERSION = 28;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: trunk/Source/WebCore/Configurations/Version.xcconfig (182832 => 182833)

--- trunk/Source/WebCore/Configurations/Version.xcconfig	2015-04-15 02:27:26 UTC (rev 182832)
+++ trunk/Source/WebCore/Configurations/Version.xcconfig	2015-04-15 02:29:21 UTC (rev 182833)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 601;
 MINOR_VERSION = 1;
-TINY_VERSION = 27;
+TINY_VERSION = 28;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: trunk/Source/WebInspectorUI/Configurations/Version.xcconfig (182832 => 182833)

--- trunk/Source/WebInspectorUI/Configurations/Version.xcconfig	2015-04-15 02:27:26 UTC (rev 182832)
+++ trunk/Source/WebInspectorUI/Configurations/Version.xcconfig	2015-04-15 02:29:21 UTC (rev 182833)
@@ -1,6 +1,6 @@
 MAJOR_VERSION = 601;
 MINOR_VERSION = 1;
-TINY_VERSION = 27;
+TINY_VERSION = 28;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: trunk/Source/WebKit/mac/Configurations/Version.xcconfig (182832 => 182833)

--- trunk/Source/WebKit/mac/Configurations/Version.xcconfig	2015-04-15 02:27:26 UTC (rev 182832)
+++ trunk/Source/WebKit/mac/Configurations/Version.xcconfig	2015-04-15 02:29:21 UTC (rev 182833)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 601;
 MINOR_VERSION = 1;
-TINY_VERSION = 27;
+TINY_VERSION = 28;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: trunk/Source/WebKit2/Configurations/Version.xcconfig (182832 => 182833)

--- trunk/Source/WebKit2/Configurations/Version.xcconfig	2015-04-15 02:27:26 UTC (rev 182832)
+++ trunk/Source/WebKit2/Configurations/Version.xcconfig	2015-04-15 02:29:21 UTC (rev 182833)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 601;
 MINOR_VERSION = 1;
-TINY_VERSION = 27;
+TINY_VERSION = 28;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [182832] tags/Safari-601.1.27/

[bshafiei]

Title: [182832] tags/Safari-601.1.27/








Revision 182832
Author bshaf...@apple.com
Date 2015-04-14 19:27:26 -0700 (Tue, 14 Apr 2015)


Log Message
New tag.

Added Paths

tags/Safari-601.1.27/




Diff

Property changes: tags/Safari-601.1.27



Added: svn:ignore
depcomp
compile
config.guess
GNUmakefile.in
config.sub
ltmain.sh
aconfig.h.in
autom4te.cache
missing
aclocal.m4
install-sh
autotoolsconfig.h.in
INSTALL
README
gtk-doc.make
out
Makefile.chromium
WebKitSupportLibrary.zip
WebKitBuild

Added: svn:mergeinfo




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [182831] trunk/Source/JavaScriptCore

[msaboff]

Title: [182831] trunk/Source/_javascript_Core








Revision 182831
Author msab...@apple.com
Date 2015-04-14 19:16:39 -0700 (Tue, 14 Apr 2015)


Log Message
Remove _javascript_CoreUseJIT default from _javascript_Core
https://bugs.webkit.org/show_bug.cgi?id=143746

Reviewed by Mark Lam.

* runtime/VM.cpp:
(JSC::enableAssembler):

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/runtime/VM.cpp




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (182830 => 182831)

--- trunk/Source/_javascript_Core/ChangeLog	2015-04-15 01:59:39 UTC (rev 182830)
+++ trunk/Source/_javascript_Core/ChangeLog	2015-04-15 02:16:39 UTC (rev 182831)
@@ -1,3 +1,13 @@
+2015-04-14  Michael Saboff  
+
+Remove _javascript_CoreUseJIT default from _javascript_Core
+https://bugs.webkit.org/show_bug.cgi?id=143746
+
+Reviewed by Mark Lam.
+
+* runtime/VM.cpp:
+(JSC::enableAssembler):
+
 2015-04-14  Chris Dumez  
 
 Regression(r180020): Web Inspector crashes on pages that have a stylesheet with an invalid MIME type


Modified: trunk/Source/_javascript_Core/runtime/VM.cpp (182830 => 182831)

--- trunk/Source/_javascript_Core/runtime/VM.cpp	2015-04-15 01:59:39 UTC (rev 182830)
+++ trunk/Source/_javascript_Core/runtime/VM.cpp	2015-04-15 02:16:39 UTC (rev 182831)
@@ -127,13 +127,6 @@
 return false;
 }
 
-#if USE(CF)
-CFStringRef canUseJITKey = CFSTR("_javascript_CoreUseJIT");
-RetainPtr canUseJIT = adoptCF(CFPreferencesCopyAppValue(canUseJITKey, kCFPreferencesCurrentApplication));
-if (canUseJIT)
-return kCFBooleanTrue == canUseJIT.get();
-#endif
-
 #if USE(CF) || OS(UNIX)
 char* canUseJITString = getenv("_javascript_CoreUseJIT");
 return !canUseJITString || atoi(canUseJITString);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [182830] trunk/LayoutTests

[dbates]

Title: [182830] trunk/LayoutTests








Revision 182830
Author dba...@webkit.org
Date 2015-04-14 18:59:39 -0700 (Tue, 14 Apr 2015)


Log Message
Rename test LayoutTests/fast/events/drag-link.html to drag-and-drop-link-into-focused-contenteditable.html
https://bugs.webkit.org/show_bug.cgi?id=143683

Reviewed by Alexey Proskuryakov.

The name of the test LayoutTests/fast/events/drag-link.html is too generic given its purpose, which is
to test that we do not cause an assertion failure when dragging and dropping an HTML hyperlink into
a focused content editable element. We should come up with a more descriptive name for this test that
better describes what it tests.

* fast/events/drag-and-drop-link-into-focused-contenteditable-expected.txt: Renamed from LayoutTests/fast/events/drag-link-expected.txt.
* fast/events/drag-and-drop-link-into-focused-contenteditable.html: Renamed from LayoutTests/fast/events/drag-link.html.
* platform/efl/TestExpectations: Update file because of the rename.
* platform/gtk/TestExpectations: Ditto.
* platform/ios-simulator/TestExpectations: Ditto.
* platform/mac-wk2/TestExpectations: Ditto.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/efl/TestExpectations
trunk/LayoutTests/platform/gtk/TestExpectations
trunk/LayoutTests/platform/ios-simulator/TestExpectations
trunk/LayoutTests/platform/mac-wk2/TestExpectations


Added Paths

trunk/LayoutTests/fast/events/drag-and-drop-link-into-focused-contenteditable-expected.txt
trunk/LayoutTests/fast/events/drag-and-drop-link-into-focused-contenteditable.html


Removed Paths

trunk/LayoutTests/fast/events/drag-link-expected.txt
trunk/LayoutTests/fast/events/drag-link.html




Diff

Modified: trunk/LayoutTests/ChangeLog (182829 => 182830)

--- trunk/LayoutTests/ChangeLog	2015-04-15 01:39:05 UTC (rev 182829)
+++ trunk/LayoutTests/ChangeLog	2015-04-15 01:59:39 UTC (rev 182830)
@@ -1,3 +1,22 @@
+2015-04-14  Daniel Bates  
+
+Rename test LayoutTests/fast/events/drag-link.html to drag-and-drop-link-into-focused-contenteditable.html
+https://bugs.webkit.org/show_bug.cgi?id=143683
+
+Reviewed by Alexey Proskuryakov.
+
+The name of the test LayoutTests/fast/events/drag-link.html is too generic given its purpose, which is
+to test that we do not cause an assertion failure when dragging and dropping an HTML hyperlink into
+a focused content editable element. We should come up with a more descriptive name for this test that
+better describes what it tests.
+
+* fast/events/drag-and-drop-link-into-focused-contenteditable-expected.txt: Renamed from LayoutTests/fast/events/drag-link-expected.txt.
+* fast/events/drag-and-drop-link-into-focused-contenteditable.html: Renamed from LayoutTests/fast/events/drag-link.html.
+* platform/efl/TestExpectations: Update file because of the rename.
+* platform/gtk/TestExpectations: Ditto.
+* platform/ios-simulator/TestExpectations: Ditto.
+* platform/mac-wk2/TestExpectations: Ditto.
+
 2015-04-14  Chris Dumez  
 
 Regression(r180020): Web Inspector crashes on pages that have a stylesheet with an invalid MIME type


Copied: trunk/LayoutTests/fast/events/drag-and-drop-link-into-focused-contenteditable-expected.txt (from rev 182829, trunk/LayoutTests/fast/events/drag-link-expected.txt) (0 => 182830)

--- trunk/LayoutTests/fast/events/drag-and-drop-link-into-focused-contenteditable-expected.txt	(rev 0)
+++ trunk/LayoutTests/fast/events/drag-and-drop-link-into-focused-contenteditable-expected.txt	2015-04-15 01:59:39 UTC (rev 182830)
@@ -0,0 +1,8 @@
+Test for bug 70277. This tests that a link is dragged and dropped properly in an already focused editable area. This test passes only if it does not hit an assertion.
+
+Test Link
+Editable area
+
+Test Link
+
+PASS


Copied: trunk/LayoutTests/fast/events/drag-and-drop-link-into-focused-contenteditable.html (from rev 182829, trunk/LayoutTests/fast/events/drag-link.html) (0 => 182830)

--- trunk/LayoutTests/fast/events/drag-and-drop-link-into-focused-contenteditable.html	(rev 0)
+++ trunk/LayoutTests/fast/events/drag-and-drop-link-into-focused-contenteditable.html	2015-04-15 01:59:39 UTC (rev 182830)
@@ -0,0 +1,40 @@
+
+
+
+
+Test for .
+This tests that a link is dragged and dropped properly in an already focused editable area.
+This test passes only if it does not hit an assertion.
+
+Test Link
+
+
+Editable area
+
+
+
+
+
+
+function dragElement(srcElement, destElement) 
+{
+eventSender.mouseMoveTo(srcElement.offsetLeft + srcElement.offsetWidth / 2,
+srcElement.offsetTop + srcElement.offsetHeight / 2);
+eventSender.mouseDown();
+eventSender.leapForward(100);
+eventSender.mouseMoveTo(destElement.offsetLeft + destElement.offsetWidth / 2,
+destElement.offsetTop + destElement.offsetHeight / 2);
+eventSender.mouseUp();
+
+document.getElementById('result').innerHTML

[webkit-changes] [182829] trunk

[cdumez]

Title: [182829] trunk








Revision 182829
Author cdu...@apple.com
Date 2015-04-14 18:39:05 -0700 (Tue, 14 Apr 2015)


Log Message
Regression(r180020): Web Inspector crashes on pages that have a stylesheet with an invalid MIME type
https://bugs.webkit.org/show_bug.cgi?id=143745


Reviewed by Joseph Pecoraro.

Source/_javascript_Core:

Add assertion in ContentSearchUtilities::findMagicComment() to make
sure the content String is not null or we would crash in
JSC::Yarr::interpret() later.

* inspector/ContentSearchUtilities.cpp:
(Inspector::ContentSearchUtilities::findMagicComment):

Source/WebCore:

After r180020, we are stricter and no longer accept CSS resources that
are not served with a CSS MIME type. Showing Web inspector on a page
with such bad resource would crash because
InspectorPageAgent::cachedResourceContent() would return true but
the result String would be null. This null String would then later
be passed to the Yarr interpreter and crash on a String::is8Bit()
call.

cachedResourceContent() calls CachedCSSStyleSheet::sheetText(). Before
r180020, it would return the text, even if the MIME type was incorrect.
However, this is no longer the case and we now need to make sure that
cachedResourceContent() returns false if sheetText() returns a null
String.

Test: http/tests/inspector/css/bad-mime-type.html

* inspector/InspectorPageAgent.cpp:
(WebCore::InspectorPageAgent::cachedResourceContent):

LayoutTests:

Add layout test that shows the Web inspector on a page that has
a stylesheet with an invalid MIME type, to make sure we don't
crash.

* http/tests/inspector/css/bad-mime-type-expected.txt: Added.
* http/tests/inspector/css/bad-mime-type.html: Added.
* http/tests/misc/css-accept-any-type.html:
* http/tests/misc/css-reject-any-type-in-strict-mode.html:
* http/tests/misc/resources/stylesheet-bad-mime-type.php: Renamed from LayoutTests/http/tests/misc/resources/stylesheet.php.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/http/tests/misc/css-accept-any-type.html
trunk/LayoutTests/http/tests/misc/css-reject-any-type-in-strict-mode.html
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/inspector/ContentSearchUtilities.cpp
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/InspectorPageAgent.cpp


Added Paths

trunk/LayoutTests/http/tests/inspector/css/
trunk/LayoutTests/http/tests/inspector/css/bad-mime-type-expected.txt
trunk/LayoutTests/http/tests/inspector/css/bad-mime-type.html
trunk/LayoutTests/http/tests/misc/resources/stylesheet-bad-mime-type.php


Removed Paths

trunk/LayoutTests/http/tests/misc/resources/stylesheet.php




Diff

Modified: trunk/LayoutTests/ChangeLog (182828 => 182829)

--- trunk/LayoutTests/ChangeLog	2015-04-15 01:34:25 UTC (rev 182828)
+++ trunk/LayoutTests/ChangeLog	2015-04-15 01:39:05 UTC (rev 182829)
@@ -1,3 +1,21 @@
+2015-04-14  Chris Dumez  
+
+Regression(r180020): Web Inspector crashes on pages that have a stylesheet with an invalid MIME type
+https://bugs.webkit.org/show_bug.cgi?id=143745
+
+
+Reviewed by Joseph Pecoraro.
+
+Add layout test that shows the Web inspector on a page that has
+a stylesheet with an invalid MIME type, to make sure we don't
+crash.
+
+* http/tests/inspector/css/bad-mime-type-expected.txt: Added.
+* http/tests/inspector/css/bad-mime-type.html: Added.
+* http/tests/misc/css-accept-any-type.html:
+* http/tests/misc/css-reject-any-type-in-strict-mode.html:
+* http/tests/misc/resources/stylesheet-bad-mime-type.php: Renamed from LayoutTests/http/tests/misc/resources/stylesheet.php.
+
 2015-04-14  Brady Eidson  
 
 Make sure media element loads hit content filter extensions.


Added: trunk/LayoutTests/http/tests/inspector/css/bad-mime-type-expected.txt (0 => 182829)

--- trunk/LayoutTests/http/tests/inspector/css/bad-mime-type-expected.txt	(rev 0)
+++ trunk/LayoutTests/http/tests/inspector/css/bad-mime-type-expected.txt	2015-04-15 01:39:05 UTC (rev 182829)
@@ -0,0 +1,3 @@
+Tests that showing Web Inspector on a page that has a stylesheet with an invalid MIME type does not crash.
+
+This test passes if it does not crash.


Added: trunk/LayoutTests/http/tests/inspector/css/bad-mime-type.html (0 => 182829)

--- trunk/LayoutTests/http/tests/inspector/css/bad-mime-type.html	(rev 0)
+++ trunk/LayoutTests/http/tests/inspector/css/bad-mime-type.html	2015-04-15 01:39:05 UTC (rev 182829)
@@ -0,0 +1,20 @@
+
+
+
+
+
+function test()
+{
+InspectorTest.completeTest();
+}
+
+
+
+Tests that showing Web Inspector on a page that has a stylesheet with an invalid MIME type does not crash.
+This test passes if it does not crash.
+
+


Modified: trunk/LayoutTests/http/tests/misc/css-accept-any-type.html (182828 => 182829)

--- trunk/LayoutTests/http/tests/misc/css-accept-any-type.html	2015-04-15 01:34:25 UTC (rev 182828)
+++ 

[webkit-changes] [182828] trunk

[commit-queue]

Title: [182828] trunk








Revision 182828
Author commit-qu...@webkit.org
Date 2015-04-14 18:34:25 -0700 (Tue, 14 Apr 2015)


Log Message
textPath layout performance improvement.
https://bugs.webkit.org/show_bug.cgi?id=141570.

Patch by Said Abou-Hallawa  on 2015-04-14
Reviewed by Darin Adler.

PerformanceTests:

Cut down the time spent in traversing the path for text by 50%. Instead
of traversing the path twice at a certain length: one time for the position
and the second time for the angle, we can merge these two passes into one.

* SVG/TextOnPathSimple.html: Added.
* SVG/resources/TextOnPathSimple.svg: Added.

Source/WebCore:

The bottleneck of the text-on-path performance is the position and angle
calculations for every single character. If the number of characters is
'n' and the number of path elements is 'm', the total number of processing
the path elements is O(2 x n x m). What makes it really worse is, for every
curve we keep splitting the curve till the split curve is almost a straight
line. The changes we need to do are:
1. Merge the position and the angle traversals in one pass since they are
   returning info for the same length on the path. There is a degenerate
   case for the starting point when calculating the angle. The original
   code was solving this problem by passing an epsilon instead of zero but
   because traversing the path for position and angle are now merged, we
   will pass zero for the starting point as is. All we need is to move one
   step ahead without moving the position. We need the extra step forward
   to calculate the slope of the path at the starting point.
2. We need to add a new mode to traversing a path. The new mode will take
   a vector of lengths and returns a vector of arrow vectors. Every arrow
   vector represents a position and an angle on the path at a certain length.
   This requires changing the SVGTextLayoutEngine to calculate the lengths
   of the characters on the curve first and then passing all of them to the
   path traversal function. Instead of traversing the path for every length,
   we are going to get the required point and angle from the vector of arrow
   vectors.

This patch is addressing the first fix only. The second one will require
refactoring the SVGTextLayoutEngine so I am going to address it in a
different patch.

* platform/graphics/Path.cpp:
(WebCore::pathLengthApplierFunction): It is cleaner to move the function
of this method to PathTraversalState::processPathElement().

(WebCore::Path::length): Use new enum Action value and access methods.

(WebCore::Path::traversalStateAtLength): New function which returns the
traversalState at a certain length on a path.

(WebCore::Path::pointAtLength):
(WebCore::Path::normalAngleAtLength): Use traversalStateAtLength() to get
the traversalState and from it return either the position or the angle.

* platform/graphics/Path.h: Define traversalStateAtLength().

* platform/graphics/PathTraversalState.cpp:
(WebCore::distanceLine): Code clean up.

(WebCore::curveLength): Make the setting of m_previous and m_current happens
only in this function.

(WebCore::PathTraversalState::PathTraversalState): Add an optional parameter
for the desired length and move the initialization of the other members to
the class definition.

(WebCore::PathTraversalState::closeSubpath):
(WebCore::PathTraversalState::moveTo):
(WebCore::PathTraversalState::lineTo): Add the distance to the m_totalLength
instead of returning it since this is what all the callers were doing.

(WebCore::PathTraversalState::quadraticBezierTo):
(WebCore::PathTraversalState::cubicBezierTo): Add the distance to the
m_totalLength. Move the setting of m_previous and m_current to curveLength().
Remove unused members m_control1 and m_control2.

(WebCore::PathTraversalState::processSegment): Deleted.
(WebCore::PathTraversalState::finalizeAppendPathElement): Create a new
name for the function. Handle the case of the angle at the starting point
where m_desiredLength is set to zero. The new flag m_isZeroVector will be
set to notify the caller that the  next iteration will be the last one and
it is only needed for the calculating the angle of a zero vector. m_current
should not change by this last iteration.

(WebCore::PathTraversalState::appendPathElement): This code is moved from
pathLengthApplierFunction().

(WebCore::PathTraversalState::processPathElement): This function is used
by the class Path. It is a wrapper for appendPathElement(). If m_isZeroVector
is set we append the new element to a copy for the PathTraversalState just
to get the angle for the zero vector.

* platform/graphics/PathTraversalState.h: Change the enum values to not
not include the class or the enum class. Make the data members private and
expose the needed ones through access methods. Make all the internal methods
to be private.

(WebCore::PathTraversalState::processPathElement):  Another wrapper for
appendPathElement() which is used by SVGPathTraversalStateBuilder.

(WebCore::Pa

[webkit-changes] [182827] trunk/Source/JavaScriptCore

[msaboff]

Title: [182827] trunk/Source/_javascript_Core








Revision 182827
Author msab...@apple.com
Date 2015-04-14 17:49:03 -0700 (Tue, 14 Apr 2015)


Log Message
DFG register fillSpeculate*() functions should validate incoming spill format is compatible with requested fill format
https://bugs.webkit.org/show_bug.cgi?id=143727

Reviewed by Geoffrey Garen.

Used the result of AbstractInterpreter<>::filter() to check that the current spill format is compatible
with the requested fill format.  If filter() reports a contradiction, then we force an OSR exit.
Removed individual checks made redundant by the new check.

* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::fillSpeculateInt32Internal):
(JSC::DFG::SpeculativeJIT::fillSpeculateCell):
(JSC::DFG::SpeculativeJIT::fillSpeculateBoolean):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::fillSpeculateInt32Internal):
(JSC::DFG::SpeculativeJIT::fillSpeculateInt52):
(JSC::DFG::SpeculativeJIT::fillSpeculateCell):
(JSC::DFG::SpeculativeJIT::fillSpeculateBoolean):

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT32_64.cpp
trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT64.cpp




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (182826 => 182827)

--- trunk/Source/_javascript_Core/ChangeLog	2015-04-15 00:47:25 UTC (rev 182826)
+++ trunk/Source/_javascript_Core/ChangeLog	2015-04-15 00:49:03 UTC (rev 182827)
@@ -1,3 +1,24 @@
+2015-04-14  Michael Saboff  
+
+DFG register fillSpeculate*() functions should validate incoming spill format is compatible with requested fill format
+https://bugs.webkit.org/show_bug.cgi?id=143727
+
+Reviewed by Geoffrey Garen.
+
+Used the result of AbstractInterpreter<>::filter() to check that the current spill format is compatible
+with the requested fill format.  If filter() reports a contradiction, then we force an OSR exit.
+Removed individual checks made redundant by the new check.
+
+* dfg/DFGSpeculativeJIT32_64.cpp:
+(JSC::DFG::SpeculativeJIT::fillSpeculateInt32Internal):
+(JSC::DFG::SpeculativeJIT::fillSpeculateCell):
+(JSC::DFG::SpeculativeJIT::fillSpeculateBoolean):
+* dfg/DFGSpeculativeJIT64.cpp:
+(JSC::DFG::SpeculativeJIT::fillSpeculateInt32Internal):
+(JSC::DFG::SpeculativeJIT::fillSpeculateInt52):
+(JSC::DFG::SpeculativeJIT::fillSpeculateCell):
+(JSC::DFG::SpeculativeJIT::fillSpeculateBoolean):
+
 2015-04-14  Joseph Pecoraro  
 
 Replace _javascript_CoreOutputConsoleMessagesToSystemConsole default with an SPI


Modified: trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT32_64.cpp (182826 => 182827)

--- trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT32_64.cpp	2015-04-15 00:47:25 UTC (rev 182826)
+++ trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT32_64.cpp	2015-04-15 00:49:03 UTC (rev 182827)
@@ -845,16 +845,16 @@
 AbstractValue& value = m_state.forNode(edge);
 SpeculatedType type = value.m_type;
 ASSERT(edge.useKind() != KnownInt32Use || !(value.m_type & ~SpecInt32));
-m_interpreter.filter(value, SpecInt32);
-VirtualRegister virtualRegister = edge->virtualRegister();
-GenerationInfo& info = generationInfoFromVirtualRegister(virtualRegister);
 
-if (edge->hasConstant() && !edge->isInt32Constant()) {
+if (m_interpreter.filter(value, SpecInt32) == Contradiction) {
 terminateSpeculativeExecution(Uncountable, JSValueRegs(), 0);
 returnFormat = DataFormatInt32;
 return allocate();
 }
-
+
+VirtualRegister virtualRegister = edge->virtualRegister();
+GenerationInfo& info = generationInfoFromVirtualRegister(virtualRegister);
+
 switch (info.registerFormat()) {
 case DataFormatNone: {
 if (edge->hasConstant()) {
@@ -869,12 +869,6 @@
 
 DataFormat spillFormat = info.spillFormat();
 
-if (spillFormat == DataFormatCell) {
-terminateSpeculativeExecution(BadType, JSValueRegs(), edge);
-returnFormat = DataFormatInt32;
-return allocate();
-}
-
 ASSERT_UNUSED(spillFormat, (spillFormat & DataFormatJS) || spillFormat == DataFormatInt32);
 
 // If we know this was spilled as an integer we can fill without checking.
@@ -920,10 +914,6 @@
 case DataFormatJSDouble:
 case DataFormatJSCell:
 case DataFormatJSBoolean:
-terminateSpeculativeExecution(Uncountable, JSValueRegs(), 0);
-returnFormat = DataFormatInt32;
-return allocate();
-
 case DataFormatDouble:
 case DataFormatStorage:
 default:
@@ -982,26 +972,17 @@
 AbstractValue& value = m_state.forNode(edge);
 SpeculatedType type = value.m_type;
 ASSERT((edge.useKind() != KnownCellUse && edge.useKind() != KnownStringUse) || !(value.m_type & ~SpecCell));
-m_interpreter.filter(value, SpecCell);
-VirtualRegister virtualRegister = edge->virtualRegister();
-Generat

[webkit-changes] [182826] trunk/Source/JavaScriptCore

[joepeck]

Title: [182826] trunk/Source/_javascript_Core








Revision 182826
Author joep...@webkit.org
Date 2015-04-14 17:47:25 -0700 (Tue, 14 Apr 2015)


Log Message
Replace _javascript_CoreOutputConsoleMessagesToSystemConsole default with an SPI
https://bugs.webkit.org/show_bug.cgi?id=143691

Reviewed by Geoffrey Garen.

* API/JSRemoteInspector.h:
* API/JSRemoteInspector.cpp:
(JSRemoteInspectorSetLogToSystemConsole):
Add SPI to enable/disable logging to the system console.
This only affects JSContext `console` logs and warnings.

* inspector/JSGlobalObjectConsoleClient.h:
* inspector/JSGlobalObjectConsoleClient.cpp:
(Inspector::JSGlobalObjectConsoleClient::logToSystemConsole):
(Inspector::JSGlobalObjectConsoleClient::setLogToSystemConsole):
(Inspector::JSGlobalObjectConsoleClient::messageWithTypeAndLevel):
(Inspector::JSGlobalObjectConsoleClient::initializeLogToSystemConsole): Deleted.
Simplify access to the setting now that it doesn't need to
initialize its value from preferences.

Modified Paths

trunk/Source/_javascript_Core/API/JSRemoteInspector.cpp
trunk/Source/_javascript_Core/API/JSRemoteInspector.h
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/inspector/JSGlobalObjectConsoleClient.cpp
trunk/Source/_javascript_Core/inspector/JSGlobalObjectConsoleClient.h




Diff

Modified: trunk/Source/_javascript_Core/API/JSRemoteInspector.cpp (182825 => 182826)

--- trunk/Source/_javascript_Core/API/JSRemoteInspector.cpp	2015-04-15 00:27:26 UTC (rev 182825)
+++ trunk/Source/_javascript_Core/API/JSRemoteInspector.cpp	2015-04-15 00:47:25 UTC (rev 182826)
@@ -26,11 +26,14 @@
 #include "config.h"
 #include "JSRemoteInspector.h"
 
+#include "JSGlobalObjectConsoleClient.h"
+
 #if ENABLE(REMOTE_INSPECTOR)
 #include "RemoteInspector.h"
-using namespace Inspector;
 #endif
 
+using namespace Inspector;
+
 void JSRemoteInspectorDisableAutoStart(void)
 {
 #if ENABLE(REMOTE_INSPECTOR)
@@ -56,3 +59,8 @@
 UNUSED_PARAM(auditLength);
 #endif
 }
+
+void JSRemoteInspectorSetLogToSystemConsole(bool logToSystemConsole)
+{
+JSGlobalObjectConsoleClient::setLogToSystemConsole(logToSystemConsole);
+}


Modified: trunk/Source/_javascript_Core/API/JSRemoteInspector.h (182825 => 182826)

--- trunk/Source/_javascript_Core/API/JSRemoteInspector.h	2015-04-15 00:27:26 UTC (rev 182825)
+++ trunk/Source/_javascript_Core/API/JSRemoteInspector.h	2015-04-15 00:47:25 UTC (rev 182826)
@@ -37,6 +37,8 @@
 JS_EXPORT void JSRemoteInspectorStart(void) CF_AVAILABLE(10_11, 9_0);
 JS_EXPORT void JSRemoteInspectorSetParentProcessInformation(pid_t, const uint8_t* auditData, size_t auditLength) CF_AVAILABLE(10_11, 9_0);
 
+JS_EXPORT void JSRemoteInspectorSetLogToSystemConsole(bool) CF_AVAILABLE(10_11, 9_0);
+
 #ifdef __cplusplus
 }
 #endif


Modified: trunk/Source/_javascript_Core/ChangeLog (182825 => 182826)

--- trunk/Source/_javascript_Core/ChangeLog	2015-04-15 00:27:26 UTC (rev 182825)
+++ trunk/Source/_javascript_Core/ChangeLog	2015-04-15 00:47:25 UTC (rev 182826)
@@ -1,5 +1,27 @@
 2015-04-14  Joseph Pecoraro  
 
+Replace _javascript_CoreOutputConsoleMessagesToSystemConsole default with an SPI
+https://bugs.webkit.org/show_bug.cgi?id=143691
+
+Reviewed by Geoffrey Garen.
+
+* API/JSRemoteInspector.h:
+* API/JSRemoteInspector.cpp:
+(JSRemoteInspectorSetLogToSystemConsole):
+Add SPI to enable/disable logging to the system console.
+This only affects JSContext `console` logs and warnings.
+
+* inspector/JSGlobalObjectConsoleClient.h:
+* inspector/JSGlobalObjectConsoleClient.cpp:
+(Inspector::JSGlobalObjectConsoleClient::logToSystemConsole):
+(Inspector::JSGlobalObjectConsoleClient::setLogToSystemConsole):
+(Inspector::JSGlobalObjectConsoleClient::messageWithTypeAndLevel):
+(Inspector::JSGlobalObjectConsoleClient::initializeLogToSystemConsole): Deleted.
+Simplify access to the setting now that it doesn't need to
+initialize its value from preferences.
+
+2015-04-14  Joseph Pecoraro  
+
 Web Inspector: Auto-attach fails after r179562, initialization too late after dispatch
 https://bugs.webkit.org/show_bug.cgi?id=143682
 


Modified: trunk/Source/_javascript_Core/inspector/JSGlobalObjectConsoleClient.cpp (182825 => 182826)

--- trunk/Source/_javascript_Core/inspector/JSGlobalObjectConsoleClient.cpp	2015-04-15 00:27:26 UTC (rev 182825)
+++ trunk/Source/_javascript_Core/inspector/JSGlobalObjectConsoleClient.cpp	2015-04-15 00:47:25 UTC (rev 182826)
@@ -32,51 +32,26 @@
 #include "ScriptCallStack.h"
 #include "ScriptCallStackFactory.h"
 
-#if USE(CF)
-#include 
-#endif
-
 using namespace JSC;
 
 namespace Inspector {
 
+#if !LOG_DISABLED
+static bool sLogToSystemConsole = true;
+#else
 static bool sLogToSystemConsole = false;
-static bool sSetLogToSystemConsole = false;
+#endif
 
 bool JSGlobalObjectConsoleClient::logToSystemConsole()
 {
-if (!sSetLogToSystemConsole) {
-static std::once_

[webkit-changes] [182825] trunk/Source/JavaScriptCore

[joepeck]

Title: [182825] trunk/Source/_javascript_Core








Revision 182825
Author joep...@webkit.org
Date 2015-04-14 17:27:26 -0700 (Tue, 14 Apr 2015)


Log Message
Web Inspector: Auto-attach fails after r179562, initialization too late after dispatch
https://bugs.webkit.org/show_bug.cgi?id=143682

Reviewed by Timothy Hatcher.

* inspector/remote/RemoteInspector.mm:
(Inspector::RemoteInspector::singleton):
If we are on the main thread, run the initialization immediately.
Otherwise dispatch to the main thread. This way if the first JSContext
was created on the main thread it can get auto-attached if applicable.

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/inspector/remote/RemoteInspector.mm




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (182824 => 182825)

--- trunk/Source/_javascript_Core/ChangeLog	2015-04-15 00:26:23 UTC (rev 182824)
+++ trunk/Source/_javascript_Core/ChangeLog	2015-04-15 00:27:26 UTC (rev 182825)
@@ -1,5 +1,18 @@
 2015-04-14  Joseph Pecoraro  
 
+Web Inspector: Auto-attach fails after r179562, initialization too late after dispatch
+https://bugs.webkit.org/show_bug.cgi?id=143682
+
+Reviewed by Timothy Hatcher.
+
+* inspector/remote/RemoteInspector.mm:
+(Inspector::RemoteInspector::singleton):
+If we are on the main thread, run the initialization immediately.
+Otherwise dispatch to the main thread. This way if the first JSContext
+was created on the main thread it can get auto-attached if applicable.
+
+2015-04-14  Joseph Pecoraro  
+
 Unreviewed build fix for Mavericks.
 
 Mavericks includes this file but does not enable ENABLE_REMOTE_INSPECTOR


Modified: trunk/Source/_javascript_Core/inspector/remote/RemoteInspector.mm (182824 => 182825)

--- trunk/Source/_javascript_Core/inspector/remote/RemoteInspector.mm	2015-04-15 00:26:23 UTC (rev 182824)
+++ trunk/Source/_javascript_Core/inspector/remote/RemoteInspector.mm	2015-04-15 00:27:26 UTC (rev 182825)
@@ -84,12 +84,17 @@
 static dispatch_once_t once;
 dispatch_once(&once, ^{
 if (canAccessWebInspectorMachPort()) {
-dispatch_async(dispatch_get_main_queue(), ^{
+dispatch_block_t initialize = ^{
 WTF::initializeMainThread();
 JSC::initializeThreading();
 if (RemoteInspector::startEnabled)
 shared.get().start();
-});
+};
+
+if ([NSThread isMainThread])
+initialize();
+else
+dispatch_async(dispatch_get_main_queue(), initialize);
 }
 });
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [182824] trunk

[simon . fraser]

Title: [182824] trunk








Revision 182824
Author simon.fra...@apple.com
Date 2015-04-14 17:26:23 -0700 (Tue, 14 Apr 2015)


Log Message
Re-enable custom dilation for antialiased fonts
https://bugs.webkit.org/show_bug.cgi?id=143738

Reviewed by Tim Horton.

Enabling custom dilation for antialised fonts broke layout tests, so re-land it,
but disable in WebKitTestRunner and DumpRenderTree. The latter requires adding
a private WebKit pref. This pref defaults to YES, enabling the feature by default
in WK1 as we do for WK2.

Source/WebCore:

* platform/graphics/cocoa/FontCascadeCocoa.mm:
(WebCore::dilationSizeForTextColor):
(WebCore::FontCascade::drawGlyphs):

Source/WebKit/mac:

* WebView/WebPreferenceKeysPrivate.h:
* WebView/WebPreferences.mm:
(+[WebPreferences initialize]):
(-[WebPreferences setAntialiasedFontDilationEnabled:]):
(-[WebPreferences antialiasedFontDilationEnabled]):
* WebView/WebPreferencesPrivate.h:
* WebView/WebView.mm:
(-[WebView _preferencesChanged:]):

Tools:

* DumpRenderTree/mac/DumpRenderTree.mm:
(resetWebPreferencesToConsistentValues):
* WebKitTestRunner/TestController.cpp:
(WTR::TestController::resetPreferencesToConsistentValues):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/cocoa/FontCascadeCocoa.mm
trunk/Source/WebKit/mac/ChangeLog
trunk/Source/WebKit/mac/WebView/WebPreferenceKeysPrivate.h
trunk/Source/WebKit/mac/WebView/WebPreferences.mm
trunk/Source/WebKit/mac/WebView/WebPreferencesPrivate.h
trunk/Source/WebKit/mac/WebView/WebView.mm
trunk/Tools/ChangeLog
trunk/Tools/DumpRenderTree/mac/DumpRenderTree.mm
trunk/Tools/WebKitTestRunner/TestController.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (182823 => 182824)

--- trunk/Source/WebCore/ChangeLog	2015-04-15 00:20:54 UTC (rev 182823)
+++ trunk/Source/WebCore/ChangeLog	2015-04-15 00:26:23 UTC (rev 182824)
@@ -1,3 +1,19 @@
+2015-04-14  Simon Fraser  
+
+Re-enable custom dilation for antialiased fonts
+https://bugs.webkit.org/show_bug.cgi?id=143738
+
+Reviewed by Tim Horton.
+
+Enabling custom dilation for antialised fonts broke layout tests, so re-land it,
+but disable in WebKitTestRunner and DumpRenderTree. The latter requires adding
+a private WebKit pref. This pref defaults to YES, enabling the feature by default
+in WK1 as we do for WK2.
+
+* platform/graphics/cocoa/FontCascadeCocoa.mm:
+(WebCore::dilationSizeForTextColor):
+(WebCore::FontCascade::drawGlyphs):
+
 2015-04-14  Andy Estes  
 
 [Content Filtering] Use ASSERT_WITH_SECURITY_IMPLICATION for verifying types from NEFilterSource


Modified: trunk/Source/WebCore/platform/graphics/cocoa/FontCascadeCocoa.mm (182823 => 182824)

--- trunk/Source/WebCore/platform/graphics/cocoa/FontCascadeCocoa.mm	2015-04-15 00:20:54 UTC (rev 182823)
+++ trunk/Source/WebCore/platform/graphics/cocoa/FontCascadeCocoa.mm	2015-04-15 00:26:23 UTC (rev 182824)
@@ -203,6 +203,26 @@
 }
 #endif
 
+#if PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 101100
+static CGSize dilationSizeForTextColor(const Color& color)
+{
+double hue;
+double saturation;
+double lightness;
+color.getHSL(hue, saturation, lightness);
+
+// These values were derived empirically, and are only experimental.
+if (lightness < 0.) // Dark
+return CGSizeMake(0.007, 0.019);
+
+if (lightness < 0.6667) // Medium
+return CGSizeMake(0.032, 0.032);
+
+// Light
+return CGSizeMake(0.0475, 0.039);
+}
+#endif
+
 void FontCascade::drawGlyphs(GraphicsContext* context, const Font* font, const GlyphBuffer& glyphBuffer, int from, int numGlyphs, const FloatPoint& anchorPoint) const
 {
 const FontPlatformData& platformData = font->platformData();
@@ -257,7 +277,18 @@
 originalShouldUseFontSmoothing = CGContextGetShouldSmoothFonts(cgContext);
 CGContextSetShouldSmoothFonts(cgContext, shouldSmoothFonts);
 }
+
+#if __MAC_OS_X_VERSION_MIN_REQUIRED >= 101100
+CGFontAntialiasingStyle oldAntialiasingStyle;
+bool resetAntialiasingStyle = false;
+if (antialiasedFontDilationEnabled() && !CGContextGetShouldSmoothFonts(cgContext) && matchAntialiasedAndSmoothedFonts) {
+resetAntialiasingStyle = true;
+oldAntialiasingStyle = CGContextGetFontAntialiasingStyle(cgContext);
+CGContextSetFontAntialiasingStyle(cgContext, kCGFontAntialiasingStyleUnfilteredCustomDilation);
+CGContextSetFontDilation(cgContext, dilationSizeForTextColor(context->fillColor()));
+}
 #endif
+#endif
 
 #if !PLATFORM(IOS)
 NSFont* drawFont = [platformData.nsFont() printerFont];
@@ -374,6 +405,11 @@
 context->setShadow(shadowOffset, shadowBlur, shadowColor, shadowColorSpace);
 
 #if !PLATFORM(IOS)
+#if __MAC_OS_X_VERSION_MIN_REQUIRED >= 101100
+if (resetAntialiasingStyle)
+CGContextSetFontAntialiasingStyle(cgContext, oldAntialiasingStyle);
+#endif
+
 if (changeFontSmoothing)

[webkit-changes] [182823] trunk/Source/WebCore

[aestes]

Title: [182823] trunk/Source/WebCore








Revision 182823
Author aes...@apple.com
Date 2015-04-14 17:20:54 -0700 (Tue, 14 Apr 2015)


Log Message
[Content Filtering] Use ASSERT_WITH_SECURITY_IMPLICATION for verifying types from NEFilterSource
https://bugs.webkit.org/show_bug.cgi?id=143742

Reviewed by David Kilzer.

* platform/cocoa/NetworkExtensionContentFilter.mm:
(replacementDataFromDecisionInfo): ASSERT_WITH_SECURITY_IMPLICATION that decisionInfo is really a NSDictionary.
(WebCore::NetworkExtensionContentFilter::handleDecision): ASSERT_WITH_SECURITY_IMPLICATION that replacementData is really a NSData.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/cocoa/NetworkExtensionContentFilter.mm




Diff

Modified: trunk/Source/WebCore/ChangeLog (182822 => 182823)

--- trunk/Source/WebCore/ChangeLog	2015-04-15 00:02:53 UTC (rev 182822)
+++ trunk/Source/WebCore/ChangeLog	2015-04-15 00:20:54 UTC (rev 182823)
@@ -1,3 +1,14 @@
+2015-04-14  Andy Estes  
+
+[Content Filtering] Use ASSERT_WITH_SECURITY_IMPLICATION for verifying types from NEFilterSource
+https://bugs.webkit.org/show_bug.cgi?id=143742
+
+Reviewed by David Kilzer.
+
+* platform/cocoa/NetworkExtensionContentFilter.mm:
+(replacementDataFromDecisionInfo): ASSERT_WITH_SECURITY_IMPLICATION that decisionInfo is really a NSDictionary.
+(WebCore::NetworkExtensionContentFilter::handleDecision): ASSERT_WITH_SECURITY_IMPLICATION that replacementData is really a NSData.
+
 2015-04-14  Brent Fulgham  
 
 Correct layering violation in DumpRenderTree Build


Modified: trunk/Source/WebCore/platform/cocoa/NetworkExtensionContentFilter.mm (182822 => 182823)

--- trunk/Source/WebCore/platform/cocoa/NetworkExtensionContentFilter.mm	2015-04-15 00:02:53 UTC (rev 182822)
+++ trunk/Source/WebCore/platform/cocoa/NetworkExtensionContentFilter.mm	2015-04-15 00:20:54 UTC (rev 182823)
@@ -44,9 +44,8 @@
 #if HAVE(MODERN_NE_FILTER_SOURCE)
 static inline NSData *replacementDataFromDecisionInfo(NSDictionary *decisionInfo)
 {
-id replacementData = decisionInfo[NEFilterSourceOptionsPageData];
-ASSERT(!replacementData || [replacementData isKindOfClass:[NSData class]]);
-return replacementData;
+ASSERT_WITH_SECURITY_IMPLICATION(!decisionInfo || [decisionInfo isKindOfClass:[NSDictionary class]]);
+return decisionInfo[NEFilterSourceOptionsPageData];
 }
 #endif
 
@@ -217,6 +216,7 @@
 
 void NetworkExtensionContentFilter::handleDecision(NEFilterSourceStatus status, NSData *replacementData)
 {
+ASSERT_WITH_SECURITY_IMPLICATION(!replacementData || [replacementData isKindOfClass:[NSData class]]);
 m_status = status;
 if (status == NEFilterSourceStatusBlock)
 m_replacementData = replacementData;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [182822] trunk/Source/WebKit2

[timothy_horton]

Title: [182822] trunk/Source/WebKit2








Revision 182822
Author timothy_hor...@apple.com
Date 2015-04-14 17:02:53 -0700 (Tue, 14 Apr 2015)


Log Message
Update gesture swipe shadow style
https://bugs.webkit.org/show_bug.cgi?id=143616


Reviewed by Darin Adler.

* UIProcess/mac/ViewGestureController.h:
* UIProcess/mac/ViewGestureControllerMac.mm:
(WebKit::ViewGestureController::beginSwipeGesture):
For the modern shadow style, use a layer stretched along the edge of the swiping content
with the newly added PNGs as the layer contents.

Add a dimming layer over the lower layer of content which fades in/out
during the swipe.

(WebKit::ViewGestureController::handleSwipeGesture):
Fade the dimming layer in and out during the entire swipe.
Fade the shadow layer out during the last few pixels of the swipe.

(WebKit::ViewGestureController::removeSwipeSnapshot):
Unparent the new layers.

* WebKit2.xcodeproj/project.pbxproj:
* Resources/SwipeShadow.png:
* Resources/swipesha...@2x.png:
Add the new resources.

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/mac/ViewGestureController.h
trunk/Source/WebKit2/UIProcess/mac/ViewGestureControllerMac.mm
trunk/Source/WebKit2/WebKit2.xcodeproj/project.pbxproj


Added Paths

trunk/Source/WebKit2/Resources/SwipeShadow.png
trunk/Source/WebKit2/Resources/swipesha...@2x.png




Diff

Modified: trunk/Source/WebKit2/ChangeLog (182821 => 182822)

--- trunk/Source/WebKit2/ChangeLog	2015-04-14 23:48:00 UTC (rev 182821)
+++ trunk/Source/WebKit2/ChangeLog	2015-04-15 00:02:53 UTC (rev 182822)
@@ -1,3 +1,32 @@
+2015-04-14  Tim Horton  
+
+Update gesture swipe shadow style
+https://bugs.webkit.org/show_bug.cgi?id=143616
+
+
+Reviewed by Darin Adler.
+
+* UIProcess/mac/ViewGestureController.h:
+* UIProcess/mac/ViewGestureControllerMac.mm:
+(WebKit::ViewGestureController::beginSwipeGesture):
+For the modern shadow style, use a layer stretched along the edge of the swiping content
+with the newly added PNGs as the layer contents.
+
+Add a dimming layer over the lower layer of content which fades in/out
+during the swipe.
+
+(WebKit::ViewGestureController::handleSwipeGesture):
+Fade the dimming layer in and out during the entire swipe.
+Fade the shadow layer out during the last few pixels of the swipe.
+
+(WebKit::ViewGestureController::removeSwipeSnapshot):
+Unparent the new layers.
+
+* WebKit2.xcodeproj/project.pbxproj:
+* Resources/SwipeShadow.png:
+* Resources/swipesha...@2x.png:
+Add the new resources.
+
 2015-04-14  Brian Weinstein  
 
 Add SPI to clear HSTS hosts added since a date.


Added: trunk/Source/WebKit2/Resources/SwipeShadow.png

(Binary files differ)

Property changes on: trunk/Source/WebKit2/Resources/SwipeShadow.png
___

Added: svn:mime-type

Added: trunk/Source/WebKit2/Resources/swipesha...@2x.png

(Binary files differ)

Property changes on: trunk/Source/WebKit2/Resources/swipesha...@2x.png
___

Added: svn:mime-type

Modified: trunk/Source/WebKit2/UIProcess/mac/ViewGestureController.h (182821 => 182822)

--- trunk/Source/WebKit2/UIProcess/mac/ViewGestureController.h	2015-04-14 23:48:00 UTC (rev 182821)
+++ trunk/Source/WebKit2/UIProcess/mac/ViewGestureController.h	2015-04-15 00:02:53 UTC (rev 182822)
@@ -186,6 +186,8 @@
 RetainPtr m_swipeCancellationTracker;
 RetainPtr m_swipeLayer;
 RetainPtr m_swipeSnapshotLayer;
+RetainPtr m_swipeShadowLayer;
+RetainPtr m_swipeDimmingLayer;
 Vector> m_currentSwipeLiveLayers;
 
 SwipeTransitionStyle m_swipeTransitionStyle { SwipeTransitionStyle::Overlap };


Modified: trunk/Source/WebKit2/UIProcess/mac/ViewGestureControllerMac.mm (182821 => 182822)

--- trunk/Source/WebKit2/UIProcess/mac/ViewGestureControllerMac.mm	2015-04-14 23:48:00 UTC (rev 182821)
+++ trunk/Source/WebKit2/UIProcess/mac/ViewGestureControllerMac.mm	2015-04-15 00:02:53 UTC (rev 182822)
@@ -46,6 +46,12 @@
 
 using namespace WebCore;
 
+#if PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED < 101000
+#define ENABLE_LEGACY_SWIPE_SHADOW_STYLE 1
+#else
+#define ENABLE_LEGACY_SWIPE_SHADOW_STYLE 0
+#endif
+
 static const double minMagnification = 1;
 static const double maxMagnification = 3;
 
@@ -58,8 +64,13 @@
 static const float smartMagnificationElementPadding = 0.05;
 static const float smartMagnificationPanScrollThreshold = 100;
 
+#if ENABLE(LEGACY_SWIPE_SHADOW_STYLE)
 static const double swipeOverlayShadowOpacity = 0.66;
 static const double swipeOverlayShadowRadius = 3;
+#else
+static const double swipeOverlayShadowOpacity = 0.47;
+static const double swipeOverlayDimmingOpacity = 0.12;
+#endif
 
 static const CGFloat minimumHorizontalSwipeDistance = 15;
 static const float minimumScrollEventRatioForSwipe = 0.5;
@@ -564,8 +5

[webkit-changes] [182821] trunk

[bfulgham]

Title: [182821] trunk








Revision 182821
Author bfulg...@apple.com
Date 2015-04-14 16:48:00 -0700 (Tue, 14 Apr 2015)


Log Message
Correct layering violation in DumpRenderTree Build
https://bugs.webkit.org/show_bug.cgi?id=143732

Reviewed by Simon Fraser.

Source/WebCore:

* testing/js/WebCoreTestSupport.cpp:
(WebCoreTestSupport::monitorWheelEvents): Added. Provides a wrapper around
the internal WebCore objects needed to implement this function.
(WebCoreTestSupport::setTestCallbackAndStartNotificationTimer): Ditto.
* testing/js/WebCoreTestSupport.h:

Tools:

Correct a layering violation in DumpRenderTree by calling functions on the
WebCoreTestSupport library, rather than attempting to work with WebCore
types directly.

* DumpRenderTree/mac/EventSendingController.mm:
(-[EventSendingController monitorWheelEvents]): Call methods on WebCoreTestSupport, rather
than WebCore itself.,
(-[EventSendingController callAfterScrollingCompletes:]): Ditto.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/testing/js/WebCoreTestSupport.cpp
trunk/Source/WebCore/testing/js/WebCoreTestSupport.h
trunk/Tools/ChangeLog
trunk/Tools/DumpRenderTree/mac/EventSendingController.mm




Diff

Modified: trunk/Source/WebCore/ChangeLog (182820 => 182821)

--- trunk/Source/WebCore/ChangeLog	2015-04-14 23:47:01 UTC (rev 182820)
+++ trunk/Source/WebCore/ChangeLog	2015-04-14 23:48:00 UTC (rev 182821)
@@ -1,3 +1,16 @@
+2015-04-14  Brent Fulgham  
+
+Correct layering violation in DumpRenderTree Build
+https://bugs.webkit.org/show_bug.cgi?id=143732
+
+Reviewed by Simon Fraser.
+
+* testing/js/WebCoreTestSupport.cpp:
+(WebCoreTestSupport::monitorWheelEvents): Added. Provides a wrapper around
+the internal WebCore objects needed to implement this function.
+(WebCoreTestSupport::setTestCallbackAndStartNotificationTimer): Ditto.
+* testing/js/WebCoreTestSupport.h:
+
 2015-04-14  Brady Eidson  
 
 Make sure media element loads hit content filter extensions.


Modified: trunk/Source/WebCore/testing/js/WebCoreTestSupport.cpp (182820 => 182821)

--- trunk/Source/WebCore/testing/js/WebCoreTestSupport.cpp	2015-04-14 23:47:01 UTC (rev 182820)
+++ trunk/Source/WebCore/testing/js/WebCoreTestSupport.cpp	2015-04-14 23:48:00 UTC (rev 182821)
@@ -31,7 +31,10 @@
 #include "Internals.h"
 #include "JSDocument.h"
 #include "JSInternals.h"
+#include "MainFrame.h"
+#include "WheelEventTestTrigger.h"
 #include <_javascript_Core/APICast.h>
+#include <_javascript_Core/JSValueRef.h>
 #include <_javascript_Core/Profile.h>
 #include 
 #include 
@@ -62,4 +65,20 @@
 InternalSettings::from(page)->resetToConsistentState();
 }
 
+void monitorWheelEvents(WebCore::Frame& frame)
+{
+frame.mainFrame().ensureTestTrigger();
 }
+
+void setTestCallbackAndStartNotificationTimer(WebCore::Frame& frame, JSContextRef context, JSObjectRef jsCallbackFunction)
+{
+WheelEventTestTrigger* trigger = frame.mainFrame().ensureTestTrigger();
+JSValueProtect(context, jsCallbackFunction);
+
+trigger->setTestCallbackAndStartNotificationTimer([=](void) {
+JSObjectCallAsFunction(context, jsCallbackFunction, nullptr, 0, nullptr, nullptr);
+JSValueUnprotect(context, jsCallbackFunction);
+});
+}
+
+}


Modified: trunk/Source/WebCore/testing/js/WebCoreTestSupport.h (182820 => 182821)

--- trunk/Source/WebCore/testing/js/WebCoreTestSupport.h	2015-04-14 23:47:01 UTC (rev 182820)
+++ trunk/Source/WebCore/testing/js/WebCoreTestSupport.h	2015-04-14 23:48:00 UTC (rev 182821)
@@ -27,6 +27,7 @@
 #define WebCoreTestSupport_h
 
 typedef const struct OpaqueJSContext* JSContextRef;
+typedef struct OpaqueJSValue* JSObjectRef;
 
 #if PLATFORM(COCOA)
 #define TEST_SUPPORT_EXPORT WTF_EXPORT_PRIVATE
@@ -34,10 +35,16 @@
 #define TEST_SUPPORT_EXPORT
 #endif
 
+namespace WebCore {
+class Frame;
+}
+
 namespace WebCoreTestSupport {
 
 void injectInternalsObject(JSContextRef) TEST_SUPPORT_EXPORT;
 void resetInternalsObject(JSContextRef) TEST_SUPPORT_EXPORT;
+void monitorWheelEvents(WebCore::Frame&) TEST_SUPPORT_EXPORT;
+void setTestCallbackAndStartNotificationTimer(WebCore::Frame&, JSContextRef, JSObjectRef) TEST_SUPPORT_EXPORT;
 
 } // namespace WebCore
 


Modified: trunk/Tools/ChangeLog (182820 => 182821)

--- trunk/Tools/ChangeLog	2015-04-14 23:47:01 UTC (rev 182820)
+++ trunk/Tools/ChangeLog	2015-04-14 23:48:00 UTC (rev 182821)
@@ -1,3 +1,19 @@
+2015-04-14  Brent Fulgham  
+
+Correct layering violation in DumpRenderTree Build
+https://bugs.webkit.org/show_bug.cgi?id=143732
+
+Reviewed by Simon Fraser.
+
+Correct a layering violation in DumpRenderTree by calling functions on the
+WebCoreTestSupport library, rather than attempting to work with WebCore
+types directly.
+
+* DumpRenderTree/mac/EventSendingController.mm:
+(-[EventSendingController monitorWheelEvents]): Call methods on WebCoreTestSupport, rather
+than WebCore

[webkit-changes] [182820] trunk

[beidson]

Title: [182820] trunk








Revision 182820
Author beid...@apple.com
Date 2015-04-14 16:47:01 -0700 (Tue, 14 Apr 2015)


Log Message
Make sure media element loads hit content filter extensions.
 and https://bugs.webkit.org/show_bug.cgi?id=143731

Reviewed by Jer Noble.

Source/WebCore:

Tests: http/tests/contentextensions/media-filtered.html
   http/tests/contentextensions/text-track-blocked.html

* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::parseAttribute): Skip loads that are filtered.

LayoutTests:

* http/tests/contentextensions/media-filtered-expected.txt: Added.
* http/tests/contentextensions/media-filtered.html: Added.
* http/tests/contentextensions/media-filtered.html.json: Added.
* http/tests/contentextensions/text-track-blocked-expected.txt: Added.
* http/tests/contentextensions/text-track-blocked.html: Added.
* http/tests/contentextensions/text-track-blocked.html.json: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/HTMLMediaElement.cpp


Added Paths

trunk/LayoutTests/http/tests/contentextensions/media-filtered-expected.txt
trunk/LayoutTests/http/tests/contentextensions/media-filtered.html
trunk/LayoutTests/http/tests/contentextensions/media-filtered.html.json
trunk/LayoutTests/http/tests/contentextensions/text-track-blocked-expected.txt
trunk/LayoutTests/http/tests/contentextensions/text-track-blocked.html
trunk/LayoutTests/http/tests/contentextensions/text-track-blocked.html.json




Diff

Modified: trunk/LayoutTests/ChangeLog (182819 => 182820)

--- trunk/LayoutTests/ChangeLog	2015-04-14 23:45:17 UTC (rev 182819)
+++ trunk/LayoutTests/ChangeLog	2015-04-14 23:47:01 UTC (rev 182820)
@@ -1,3 +1,17 @@
+2015-04-14  Brady Eidson  
+
+Make sure media element loads hit content filter extensions.
+ and https://bugs.webkit.org/show_bug.cgi?id=143731
+
+Reviewed by Jer Noble.
+
+* http/tests/contentextensions/media-filtered-expected.txt: Added.
+* http/tests/contentextensions/media-filtered.html: Added.
+* http/tests/contentextensions/media-filtered.html.json: Added.
+* http/tests/contentextensions/text-track-blocked-expected.txt: Added.
+* http/tests/contentextensions/text-track-blocked.html: Added.
+* http/tests/contentextensions/text-track-blocked.html.json: Added.
+
 2015-04-14  Brent Fulgham  
 
 [Win] Skip failling test due to list box scroll behavior.


Added: trunk/LayoutTests/http/tests/contentextensions/media-filtered-expected.txt (0 => 182820)

--- trunk/LayoutTests/http/tests/contentextensions/media-filtered-expected.txt	(rev 0)
+++ trunk/LayoutTests/http/tests/contentextensions/media-filtered-expected.txt	2015-04-14 23:47:01 UTC (rev 182820)
@@ -0,0 +1,12 @@
+CONSOLE MESSAGE: line 14: Video error
+layer at (0,0) size 800x600
+  RenderView at (0,0) size 800x600
+layer at (0,0) size 800x600
+  RenderBlock {HTML} at (0,0) size 800x600
+RenderBody {BODY} at (8,8) size 784x584
+  RenderText {#text} at (0,0) size 238x18
+text run at (0,0) width 238: "The following video should not load."
+  RenderBR {BR} at (237,14) size 1x0
+  RenderText {#text} at (0,0) size 0x0
+layer at (8,26) size 300x150
+  RenderVideo {VIDEO} at (0,18) size 300x150


Added: trunk/LayoutTests/http/tests/contentextensions/media-filtered.html (0 => 182820)

--- trunk/LayoutTests/http/tests/contentextensions/media-filtered.html	(rev 0)
+++ trunk/LayoutTests/http/tests/contentextensions/media-filtered.html	2015-04-14 23:47:01 UTC (rev 182820)
@@ -0,0 +1,21 @@
+
+if (window.testRunner)
+testRunner.waitUntilDone();
+
+function videoCanPlay()
+{
+console.log("Video can play");
+if (window.testRunner)
+testRunner.notifyDone();
+}
+
+function videoError()
+{
+console.log("Video error");
+if (window.testRunner)
+testRunner.notifyDone();
+}
+
+
+The following video should not load.
+


Added: trunk/LayoutTests/http/tests/contentextensions/media-filtered.html.json (0 => 182820)

--- trunk/LayoutTests/http/tests/contentextensions/media-filtered.html.json	(rev 0)
+++ trunk/LayoutTests/http/tests/contentextensions/media-filtered.html.json	2015-04-14 23:47:01 UTC (rev 182820)
@@ -0,0 +1,10 @@
+[
+{
+"action": {
+"type": "block"
+},
+"trigger": {
+"url-filter": ".*test.mp4"
+}
+}
+]


Added: trunk/LayoutTests/http/tests/contentextensions/text-track-blocked-expected.txt (0 => 182820)

--- trunk/LayoutTests/http/tests/contentextensions/text-track-blocked-expected.txt	(rev 0)
+++ trunk/LayoutTests/http/tests/contentextensions/text-track-blocked-expected.txt	2015-04-14 23:47:01 UTC (rev 182820)
@@ -0,0 +1,15 @@
+CONSOLE MESSAGE: line 21: video loaded
+CONSOLE MESSAGE: line 14: vttError
+layer at (0,0) size 800x600
+  RenderView at (0,0) size 800x600
+layer at (0,0) size 8

[webkit-changes] [182819] trunk/Source/JavaScriptCore

[joepeck]

Title: [182819] trunk/Source/_javascript_Core








Revision 182819
Author joep...@webkit.org
Date 2015-04-14 16:45:17 -0700 (Tue, 14 Apr 2015)


Log Message
Unreviewed build fix for Mavericks.

Mavericks includes this file but does not enable ENABLE_REMOTE_INSPECTOR
so the Inspector namespace is not available when compiling this file.

* API/JSRemoteInspector.cpp:

Modified Paths

trunk/Source/_javascript_Core/API/JSRemoteInspector.cpp
trunk/Source/_javascript_Core/ChangeLog




Diff

Modified: trunk/Source/_javascript_Core/API/JSRemoteInspector.cpp (182818 => 182819)

--- trunk/Source/_javascript_Core/API/JSRemoteInspector.cpp	2015-04-14 23:36:56 UTC (rev 182818)
+++ trunk/Source/_javascript_Core/API/JSRemoteInspector.cpp	2015-04-14 23:45:17 UTC (rev 182819)
@@ -28,10 +28,9 @@
 
 #if ENABLE(REMOTE_INSPECTOR)
 #include "RemoteInspector.h"
+using namespace Inspector;
 #endif
 
-using namespace Inspector;
-
 void JSRemoteInspectorDisableAutoStart(void)
 {
 #if ENABLE(REMOTE_INSPECTOR)


Modified: trunk/Source/_javascript_Core/ChangeLog (182818 => 182819)

--- trunk/Source/_javascript_Core/ChangeLog	2015-04-14 23:36:56 UTC (rev 182818)
+++ trunk/Source/_javascript_Core/ChangeLog	2015-04-14 23:45:17 UTC (rev 182819)
@@ -1,5 +1,14 @@
 2015-04-14  Joseph Pecoraro  
 
+Unreviewed build fix for Mavericks.
+
+Mavericks includes this file but does not enable ENABLE_REMOTE_INSPECTOR
+so the Inspector namespace is not available when compiling this file.
+
+* API/JSRemoteInspector.cpp:
+
+2015-04-14  Joseph Pecoraro  
+
 Web Inspector: Expose private APIs to interact with RemoteInspector instead of going through WebKit
 https://bugs.webkit.org/show_bug.cgi?id=143729
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [182818] trunk/LayoutTests

[bfulgham]

Title: [182818] trunk/LayoutTests








Revision 182818
Author bfulg...@apple.com
Date 2015-04-14 16:36:56 -0700 (Tue, 14 Apr 2015)


Log Message
[Win] Skip failling test due to list box scroll behavior.
https://bugs.webkit.org/show_bug.cgi?id=143739

* platform/win/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/win/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (182817 => 182818)

--- trunk/LayoutTests/ChangeLog	2015-04-14 23:34:33 UTC (rev 182817)
+++ trunk/LayoutTests/ChangeLog	2015-04-14 23:36:56 UTC (rev 182818)
@@ -1,5 +1,12 @@
 2015-04-14  Brent Fulgham  
 
+[Win] Skip failling test due to list box scroll behavior.
+https://bugs.webkit.org/show_bug.cgi?id=143739
+
+* platform/win/TestExpectations:
+
+2015-04-14  Brent Fulgham  
+
 [Win] Unreviewed test correction after r182737.
 
 New test expectation was missing a newline at the end of the file.


Modified: trunk/LayoutTests/platform/win/TestExpectations (182817 => 182818)

--- trunk/LayoutTests/platform/win/TestExpectations	2015-04-14 23:34:33 UTC (rev 182817)
+++ trunk/LayoutTests/platform/win/TestExpectations	2015-04-14 23:36:56 UTC (rev 182818)
@@ -2034,6 +2034,7 @@
 
 # Not putting 'focused' text
 fast/forms/legend-access-key.html [ Failure ]
+webkit.org/b/143739 fast/forms/listbox-visible-size.html [ Failure ]
 
 webkit.org/b/97026 fast/forms/state-restore-broken-state.html [ Failure ]
 fast/forms/select/listbox-click-on-scrollbar.html [ Failure ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [182817] trunk/LayoutTests

[bfulgham]

Title: [182817] trunk/LayoutTests








Revision 182817
Author bfulg...@apple.com
Date 2015-04-14 16:34:33 -0700 (Tue, 14 Apr 2015)


Log Message
[Win] Unreviewed test correction after r182737.

New test expectation was missing a newline at the end of the file.

* platform/win/printing/single-line-must-not-be-split-into-two-pages-expected.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/win/printing/single-line-must-not-be-split-into-two-pages-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (182816 => 182817)

--- trunk/LayoutTests/ChangeLog	2015-04-14 23:26:21 UTC (rev 182816)
+++ trunk/LayoutTests/ChangeLog	2015-04-14 23:34:33 UTC (rev 182817)
@@ -1,3 +1,11 @@
+2015-04-14  Brent Fulgham  
+
+[Win] Unreviewed test correction after r182737.
+
+New test expectation was missing a newline at the end of the file.
+
+* platform/win/printing/single-line-must-not-be-split-into-two-pages-expected.txt:
+
 2015-04-14  Simon Fraser  
 
 Set the font size to 11px explicitly to try to fix this test on Windows.


Modified: trunk/LayoutTests/platform/win/printing/single-line-must-not-be-split-into-two-pages-expected.txt (182816 => 182817)

--- trunk/LayoutTests/platform/win/printing/single-line-must-not-be-split-into-two-pages-expected.txt	2015-04-14 23:26:21 UTC (rev 182816)
+++ trunk/LayoutTests/platform/win/printing/single-line-must-not-be-split-into-two-pages-expected.txt	2015-04-14 23:34:33 UTC (rev 182817)
@@ -2408,3 +2408,4 @@
 RenderText {#text} at (0,7182) size 4710x18
   text run at (0,7182) width 4710: "WW"
 RenderBR {BR} at (4710,7196) size 0x0
+






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [182816] trunk/Source/JavaScriptCore

[joepeck]

Title: [182816] trunk/Source/_javascript_Core








Revision 182816
Author joep...@webkit.org
Date 2015-04-14 16:26:21 -0700 (Tue, 14 Apr 2015)


Log Message
Web Inspector: Expose private APIs to interact with RemoteInspector instead of going through WebKit
https://bugs.webkit.org/show_bug.cgi?id=143729

Reviewed by Timothy Hatcher.

* API/JSRemoteInspector.h: Added.
* API/JSRemoteInspector.cpp: Added.
(JSRemoteInspectorDisableAutoStart):
(JSRemoteInspectorStart):
(JSRemoteInspectorSetParentProcessInformation):
Add the new SPIs for basic remote inspection behavior.

* _javascript_Core.xcodeproj/project.pbxproj:
Add the new files to Mac only, since remote inspection is only
enabled there anyways.

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/_javascript_Core.xcodeproj/project.pbxproj


Added Paths

trunk/Source/_javascript_Core/API/JSRemoteInspector.cpp
trunk/Source/_javascript_Core/API/JSRemoteInspector.h




Diff

Added: trunk/Source/_javascript_Core/API/JSRemoteInspector.cpp (0 => 182816)

--- trunk/Source/_javascript_Core/API/JSRemoteInspector.cpp	(rev 0)
+++ trunk/Source/_javascript_Core/API/JSRemoteInspector.cpp	2015-04-14 23:26:21 UTC (rev 182816)
@@ -0,0 +1,59 @@
+/*
+ * Copyright (C) 2015 Apple Inc. All rights reserved.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions
+ * are met:
+ * 1. Redistributions of source code must retain the above copyright
+ *notice, this list of conditions and the following disclaimer.
+ * 2. Redistributions in binary form must reproduce the above copyright
+ *notice, this list of conditions and the following disclaimer in the
+ *documentation and/or other materials provided with the distribution.
+ *
+ * THIS SOFTWARE IS PROVIDED BY APPLE INC. ``AS IS'' AND ANY
+ * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
+ * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
+ * PURPOSE ARE DISCLAIMED.  IN NO EVENT SHALL APPLE INC. OR
+ * CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL,
+ * EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO,
+ * PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR
+ * PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY
+ * OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
+ * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
+ * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+ */
+
+#include "config.h"
+#include "JSRemoteInspector.h"
+
+#if ENABLE(REMOTE_INSPECTOR)
+#include "RemoteInspector.h"
+#endif
+
+using namespace Inspector;
+
+void JSRemoteInspectorDisableAutoStart(void)
+{
+#if ENABLE(REMOTE_INSPECTOR)
+RemoteInspector::startDisabled();
+#endif
+}
+
+void JSRemoteInspectorStart(void)
+{
+#if ENABLE(REMOTE_INSPECTOR)
+RemoteInspector::singleton();
+#endif
+}
+
+void JSRemoteInspectorSetParentProcessInformation(pid_t pid, const UInt8* auditData, size_t auditLength)
+{
+#if ENABLE(REMOTE_INSPECTOR)
+RetainPtr auditDataRef = adoptCF(CFDataCreate(kCFAllocatorDefault, auditData, auditLength));
+RemoteInspector::singleton().setParentProcessInformation(pid, auditDataRef);
+#else
+UNUSED_PARAM(pid);
+UNUSED_PARAM(auditData);
+UNUSED_PARAM(auditLength);
+#endif
+}


Added: trunk/Source/_javascript_Core/API/JSRemoteInspector.h (0 => 182816)

--- trunk/Source/_javascript_Core/API/JSRemoteInspector.h	(rev 0)
+++ trunk/Source/_javascript_Core/API/JSRemoteInspector.h	2015-04-14 23:26:21 UTC (rev 182816)
@@ -0,0 +1,44 @@
+/*
+ * Copyright (C) 2015 Apple Inc.  All rights reserved.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions
+ * are met:
+ * 1. Redistributions of source code must retain the above copyright
+ *notice, this list of conditions and the following disclaimer.
+ * 2. Redistributions in binary form must reproduce the above copyright
+ *notice, this list of conditions and the following disclaimer in the
+ *documentation and/or other materials provided with the distribution.
+ *
+ * THIS SOFTWARE IS PROVIDED BY APPLE INC. ``AS IS'' AND ANY
+ * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
+ * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
+ * PURPOSE ARE DISCLAIMED.  IN NO EVENT SHALL APPLE INC. OR
+ * CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL,
+ * EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO,
+ * PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR
+ * PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY
+ * OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
+ * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
+ *

[webkit-changes] [182815] trunk/Source

[bweinstein]

Title: [182815] trunk/Source








Revision 182815
Author bweinst...@apple.com
Date 2015-04-14 15:56:59 -0700 (Tue, 14 Apr 2015)


Log Message
Add SPI to clear HSTS hosts added since a date.
https://bugs.webkit.org/show_bug.cgi?id=143726
and
rdar://problem/16664597

Source/WebCore:

Declare _CFNetworkResetHSTSHostsSinceDate in CFNetworkSPI.h.

Reviewed by Anders Carlsson.

* platform/spi/cf/CFNetworkSPI.h:

Source/WebKit2:

Reviewed by Anders Carlsson.

* UIProcess/API/C/mac/WKContextPrivateMac.h:
* UIProcess/API/C/mac/WKContextPrivateMac.mm:
(WKContextResetHSTSHostsAddedAfterDate): Call into the WebProcessPool.
* UIProcess/Cocoa/WebProcessPoolCocoa.mm:
(WebKit::WebProcessPool::resetHSTSHostsAddedAfterDate): Call CFNetwork SPI to clear HSTS hosts added
after the given date.
* UIProcess/WebProcessPool.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/spi/cf/CFNetworkSPI.h
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/C/mac/WKContextPrivateMac.h
trunk/Source/WebKit2/UIProcess/API/C/mac/WKContextPrivateMac.mm
trunk/Source/WebKit2/UIProcess/Cocoa/WebProcessPoolCocoa.mm
trunk/Source/WebKit2/UIProcess/WebProcessPool.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (182814 => 182815)

--- trunk/Source/WebCore/ChangeLog	2015-04-14 21:55:46 UTC (rev 182814)
+++ trunk/Source/WebCore/ChangeLog	2015-04-14 22:56:59 UTC (rev 182815)
@@ -1,3 +1,16 @@
+2015-04-14  Brian Weinstein  
+
+Add SPI to clear HSTS hosts added since a date.
+https://bugs.webkit.org/show_bug.cgi?id=143726
+and
+rdar://problem/16664597
+
+Declare _CFNetworkResetHSTSHostsSinceDate in CFNetworkSPI.h.
+
+Reviewed by Anders Carlsson.
+
+* platform/spi/cf/CFNetworkSPI.h:
+
 2015-04-14  Roger Fong  
 
 Unreviewed. Time numbers on media controls move as they update on OSX.


Modified: trunk/Source/WebCore/platform/spi/cf/CFNetworkSPI.h (182814 => 182815)

--- trunk/Source/WebCore/platform/spi/cf/CFNetworkSPI.h	2015-04-14 21:55:46 UTC (rev 182814)
+++ trunk/Source/WebCore/platform/spi/cf/CFNetworkSPI.h	2015-04-14 22:56:59 UTC (rev 182815)
@@ -116,4 +116,8 @@
 EXTERN_C Boolean _CFNetworkSetATSContext(CFDataRef);
 #endif
 
+#if PLATFORM(IOS) || (PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 101000)
+EXTERN_C void _CFNetworkResetHSTSHostsSinceDate(CFURLStorageSessionRef, CFDateRef);
+#endif
+
 #endif // CFNetworkSPI_h


Modified: trunk/Source/WebKit2/ChangeLog (182814 => 182815)

--- trunk/Source/WebKit2/ChangeLog	2015-04-14 21:55:46 UTC (rev 182814)
+++ trunk/Source/WebKit2/ChangeLog	2015-04-14 22:56:59 UTC (rev 182815)
@@ -1,3 +1,20 @@
+2015-04-14  Brian Weinstein  
+
+Add SPI to clear HSTS hosts added since a date.
+https://bugs.webkit.org/show_bug.cgi?id=143726
+and
+rdar://problem/16664597
+
+Reviewed by Anders Carlsson.
+
+* UIProcess/API/C/mac/WKContextPrivateMac.h:
+* UIProcess/API/C/mac/WKContextPrivateMac.mm:
+(WKContextResetHSTSHostsAddedAfterDate): Call into the WebProcessPool.
+* UIProcess/Cocoa/WebProcessPoolCocoa.mm:
+(WebKit::WebProcessPool::resetHSTSHostsAddedAfterDate): Call CFNetwork SPI to clear HSTS hosts added
+after the given date.
+* UIProcess/WebProcessPool.h:
+
 2015-04-14  Anders Carlsson  
 
 More work on making the SharedMemory interface more sane


Modified: trunk/Source/WebKit2/UIProcess/API/C/mac/WKContextPrivateMac.h (182814 => 182815)

--- trunk/Source/WebKit2/UIProcess/API/C/mac/WKContextPrivateMac.h	2015-04-14 21:55:46 UTC (rev 182814)
+++ trunk/Source/WebKit2/UIProcess/API/C/mac/WKContextPrivateMac.h	2015-04-14 22:56:59 UTC (rev 182815)
@@ -48,6 +48,9 @@
 
 WK_EXPORT void WKContextResetHSTSHosts(WKContextRef context);
 
+// The time here is relative to the Unix epoch.
+WK_EXPORT void WKContextResetHSTSHostsAddedAfterDate(WKContextRef context, double startDateIntervalSince1970);
+
 WK_EXPORT void WKContextRegisterSchemeForCustomProtocol(WKContextRef context, WKStringRef scheme);
 WK_EXPORT void WKContextUnregisterSchemeForCustomProtocol(WKContextRef context, WKStringRef scheme);
 


Modified: trunk/Source/WebKit2/UIProcess/API/C/mac/WKContextPrivateMac.mm (182814 => 182815)

--- trunk/Source/WebKit2/UIProcess/API/C/mac/WKContextPrivateMac.mm	2015-04-14 21:55:46 UTC (rev 182814)
+++ trunk/Source/WebKit2/UIProcess/API/C/mac/WKContextPrivateMac.mm	2015-04-14 22:56:59 UTC (rev 182815)
@@ -107,8 +107,11 @@
 return toImpl(context)->resetHSTSHosts();
 }
 
+void WKContextResetHSTSHostsAddedAfterDate(WKContextRef context, double startDateIntervalSince1970)
+{
+return toImpl(context)->resetHSTSHostsAddedAfterDate(startDateIntervalSince1970);
+}
 
-
 void WKContextRegisterSchemeForCustomProtocol(WKContextRef context, WKStringRef scheme)
 {
 WebProcessPool::registerGlobalURLSchemeAsHavingCustomProtocolHandlers(toWTFString(scheme));


Modified: trunk/Source/WebKit2/UIProcess/Cocoa/WebProcessPoolCoco

[webkit-changes] [182814] trunk/LayoutTests

[simon . fraser]

Title: [182814] trunk/LayoutTests








Revision 182814
Author simon.fra...@apple.com
Date 2015-04-14 14:55:46 -0700 (Tue, 14 Apr 2015)


Log Message
Set the font size to 11px explicitly to try to fix this test on Windows.

* fast/forms/listbox-visible-size.html:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/forms/listbox-visible-size.html




Diff

Modified: trunk/LayoutTests/ChangeLog (182813 => 182814)

--- trunk/LayoutTests/ChangeLog	2015-04-14 21:42:00 UTC (rev 182813)
+++ trunk/LayoutTests/ChangeLog	2015-04-14 21:55:46 UTC (rev 182814)
@@ -1,3 +1,9 @@
+2015-04-14  Simon Fraser  
+
+Set the font size to 11px explicitly to try to fix this test on Windows.
+
+* fast/forms/listbox-visible-size.html:
+
 2015-04-14  Alexey Proskuryakov  
 
 inspector/console/console-api.html is very slow, frequently timing out


Modified: trunk/LayoutTests/fast/forms/listbox-visible-size.html (182813 => 182814)

--- trunk/LayoutTests/fast/forms/listbox-visible-size.html	2015-04-14 21:42:00 UTC (rev 182813)
+++ trunk/LayoutTests/fast/forms/listbox-visible-size.html	2015-04-14 21:55:46 UTC (rev 182814)
@@ -4,6 +4,7 @@
 
 
 select {
+font-size: 11x;
 width: 12em;
 }
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [182813] trunk/Source/WebCore

[roger_fong]

Title: [182813] trunk/Source/WebCore








Revision 182813
Author roger_f...@apple.com
Date 2015-04-14 14:42:00 -0700 (Tue, 14 Apr 2015)


Log Message
Unreviewed. Time numbers on media controls move as they update on OSX.
.

* Modules/mediacontrols/mediaControlsApple.css:
(audio::-webkit-media-controls-current-time-display):
(audio::-webkit-media-controls-time-remaining-display):
Don't bother justifying content to end. We size the box to fit the time displays exactly anyways.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/mediacontrols/mediaControlsApple.css




Diff

Modified: trunk/Source/WebCore/ChangeLog (182812 => 182813)

--- trunk/Source/WebCore/ChangeLog	2015-04-14 21:35:02 UTC (rev 182812)
+++ trunk/Source/WebCore/ChangeLog	2015-04-14 21:42:00 UTC (rev 182813)
@@ -1,5 +1,15 @@
 2015-04-14  Roger Fong  
 
+Unreviewed. Time numbers on media controls move as they update on OSX.
+.
+
+* Modules/mediacontrols/mediaControlsApple.css:
+(audio::-webkit-media-controls-current-time-display):
+(audio::-webkit-media-controls-time-remaining-display):
+Don't bother justifying content to end. We size the box to fit the time displays exactly anyways.
+
+2015-04-14  Roger Fong  
+
 Insert volume control in correct place after exiting wireless play.
 https://bugs.webkit.org/show_bug.cgi?id=143721.
 


Modified: trunk/Source/WebCore/Modules/mediacontrols/mediaControlsApple.css (182812 => 182813)

--- trunk/Source/WebCore/Modules/mediacontrols/mediaControlsApple.css	2015-04-14 21:35:02 UTC (rev 182812)
+++ trunk/Source/WebCore/Modules/mediacontrols/mediaControlsApple.css	2015-04-14 21:42:00 UTC (rev 182813)
@@ -492,8 +492,6 @@
 margin-right: 8px;
 width: 32px;
 min-width: 32px;
--webkit-align-items: flex-end;
--webkit-justify-content: flex-end;
 }
 
 video::-webkit-media-controls-time-remaining-display,
@@ -502,8 +500,6 @@
 margin-right: 16px;
 width: 36px;
 min-width: 36px;
--webkit-align-items: flex-start;
--webkit-justify-content: flex-start;
 }
 
 video::-webkit-media-controls-time-remaining-display.five-digit-time,






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [182812] trunk/Source/WebCore

[roger_fong]

Title: [182812] trunk/Source/WebCore








Revision 182812
Author roger_f...@apple.com
Date 2015-04-14 14:35:02 -0700 (Tue, 14 Apr 2015)


Log Message
Insert volume control in correct place after exiting wireless play.
https://bugs.webkit.org/show_bug.cgi?id=143721.


Reviewed by Darin Adler.

* Modules/mediacontrols/mediaControlsApple.js:
(Controller.prototype.updateWirelessPlaybackStatus):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/mediacontrols/mediaControlsApple.js




Diff

Modified: trunk/Source/WebCore/ChangeLog (182811 => 182812)

--- trunk/Source/WebCore/ChangeLog	2015-04-14 21:25:22 UTC (rev 182811)
+++ trunk/Source/WebCore/ChangeLog	2015-04-14 21:35:02 UTC (rev 182812)
@@ -1,3 +1,14 @@
+2015-04-14  Roger Fong  
+
+Insert volume control in correct place after exiting wireless play.
+https://bugs.webkit.org/show_bug.cgi?id=143721.
+
+
+Reviewed by Darin Adler.
+
+* Modules/mediacontrols/mediaControlsApple.js:
+(Controller.prototype.updateWirelessPlaybackStatus):
+
 2015-04-14  Brady Eidson  
 
 Media elements not in a page shouldn't load.


Modified: trunk/Source/WebCore/Modules/mediacontrols/mediaControlsApple.js (182811 => 182812)

--- trunk/Source/WebCore/Modules/mediacontrols/mediaControlsApple.js	2015-04-14 21:25:22 UTC (rev 182811)
+++ trunk/Source/WebCore/Modules/mediacontrols/mediaControlsApple.js	2015-04-14 21:35:02 UTC (rev 182812)
@@ -1767,19 +1767,16 @@
 this.controls.inlinePlaybackPlaceholderTextBottom.classList.remove(this.ClassNames.small);
 }
 if (this.isFullScreen())
-this.controls.panel.removeChild(this.controls.volumeBox);
+this.controls.volumeBox.style.display = "none";
 else
-this.controls.panel.removeChild(this.controls.muteBox);
+this.controls.muteBox.style.display = "none";
 } else {
 this.controls.inlinePlaybackPlaceholder.classList.add(this.ClassNames.hidden);
 this.controls.wirelessTargetPicker.classList.remove(this.ClassNames.playing);
-if (this.isFullScreen()) {
-if (!this.controls.volumeBox.parentNode)
-this.controls.panel.appendChild(this.controls.volumeBox);
-} else {
-if (!this.controls.muteBox.parentNode)
-this.controls.panel.appendChild(this.controls.muteBox);
-}
+if (this.isFullScreen())
+this.controls.volumeBox.style.display = "-webkit-flex";
+else
+this.controls.muteBox.style.display = "-webkit-flex";
 }
 },
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [182810] trunk/Source/WebCore

[beidson]

Title: [182810] trunk/Source/WebCore








Revision 182810
Author beid...@apple.com
Date 2015-04-14 14:24:45 -0700 (Tue, 14 Apr 2015)


Log Message
Media elements not in a page shouldn't load.
https://bugs.webkit.org/show_bug.cgi?id=143720

Reviewed by Jer Noble.

No new tests (Theoretical problem noticed in code review).

* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::loadResource): Make sure the frame is in a page.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/HTMLMediaElement.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (182809 => 182810)

--- trunk/Source/WebCore/ChangeLog	2015-04-14 21:14:07 UTC (rev 182809)
+++ trunk/Source/WebCore/ChangeLog	2015-04-14 21:24:45 UTC (rev 182810)
@@ -1,3 +1,15 @@
+2015-04-14  Brady Eidson  
+
+Media elements not in a page shouldn't load.
+https://bugs.webkit.org/show_bug.cgi?id=143720
+
+Reviewed by Jer Noble.
+
+No new tests (Theoretical problem noticed in code review).
+
+* html/HTMLMediaElement.cpp:
+(WebCore::HTMLMediaElement::loadResource): Make sure the frame is in a page.
+
 2015-04-14  Simon Fraser  
 
 [iOS] Clean up registration of layers with the ScrollingCoordinator


Modified: trunk/Source/WebCore/html/HTMLMediaElement.cpp (182809 => 182810)

--- trunk/Source/WebCore/html/HTMLMediaElement.cpp	2015-04-14 21:14:07 UTC (rev 182809)
+++ trunk/Source/WebCore/html/HTMLMediaElement.cpp	2015-04-14 21:24:45 UTC (rev 182810)
@@ -1090,12 +1090,17 @@
 return;
 }
 
+if (!frame->page()) {
+mediaLoadingFailed(MediaPlayer::FormatError);
+return;
+}
+
 URL url = ""
 if (!frame->loader().willLoadMediaElementURL(url)) {
 mediaLoadingFailed(MediaPlayer::FormatError);
 return;
 }
-
+
 // The resource fetch algorithm 
 m_networkState = NETWORK_LOADING;
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [182811] trunk/Source/JavaScriptCore

[mark . lam]

Title: [182811] trunk/Source/_javascript_Core








Revision 182811
Author mark@apple.com
Date 2015-04-14 14:25:22 -0700 (Tue, 14 Apr 2015)


Log Message
Rename JSC_dfgFunctionWhitelistFile to JSC_dfgWhitelist.
https://bugs.webkit.org/show_bug.cgi?id=143722

Reviewed by Michael Saboff.

Renaming JSC_dfgFunctionWhitelistFile to JSC_dfgWhitelist so that it is
shorter, and easier to remember (without having to look it up) and to
type.  JSC options now support descriptions, and one can always look up
the description if the option's purpose is not already obvious.

* dfg/DFGFunctionWhitelist.cpp:
(JSC::DFG::FunctionWhitelist::ensureGlobalWhitelist):
(JSC::DFG::FunctionWhitelist::contains):
* runtime/Options.h:

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/dfg/DFGFunctionWhitelist.cpp
trunk/Source/_javascript_Core/runtime/Options.h




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (182810 => 182811)

--- trunk/Source/_javascript_Core/ChangeLog	2015-04-14 21:24:45 UTC (rev 182810)
+++ trunk/Source/_javascript_Core/ChangeLog	2015-04-14 21:25:22 UTC (rev 182811)
@@ -1,3 +1,20 @@
+2015-04-14  Mark Lam  
+
+Rename JSC_dfgFunctionWhitelistFile to JSC_dfgWhitelist.
+https://bugs.webkit.org/show_bug.cgi?id=143722
+
+Reviewed by Michael Saboff.
+
+Renaming JSC_dfgFunctionWhitelistFile to JSC_dfgWhitelist so that it is
+shorter, and easier to remember (without having to look it up) and to
+type.  JSC options now support descriptions, and one can always look up
+the description if the option's purpose is not already obvious.
+
+* dfg/DFGFunctionWhitelist.cpp:
+(JSC::DFG::FunctionWhitelist::ensureGlobalWhitelist):
+(JSC::DFG::FunctionWhitelist::contains):
+* runtime/Options.h:
+
 2015-04-13  Filip Pizlo  
 
 Unreviewed, fix Windows build. Windows doesn't take kindly to private classes that use FAST_ALLOCATED.


Modified: trunk/Source/_javascript_Core/dfg/DFGFunctionWhitelist.cpp (182810 => 182811)

--- trunk/Source/_javascript_Core/dfg/DFGFunctionWhitelist.cpp	2015-04-14 21:24:45 UTC (rev 182810)
+++ trunk/Source/_javascript_Core/dfg/DFGFunctionWhitelist.cpp	2015-04-14 21:25:22 UTC (rev 182811)
@@ -42,7 +42,7 @@
 static LazyNeverDestroyed functionWhitelist;
 static std::once_flag initializeWhitelistFlag;
 std::call_once(initializeWhitelistFlag, [] {
-const char* functionWhitelistFile = Options::dfgFunctionWhitelistFile();
+const char* functionWhitelistFile = Options::dfgWhitelist();
 functionWhitelist.construct(functionWhitelistFile);
 });
 return functionWhitelist;
@@ -92,7 +92,7 @@
 bool FunctionWhitelist::contains(CodeBlock* codeBlock) const 
 {
 ASSERT(!isCompilationThread());
-if (!Options::dfgFunctionWhitelistFile())
+if (!Options::dfgWhitelist())
 return true;
 
 if (m_entries.isEmpty())


Modified: trunk/Source/_javascript_Core/runtime/Options.h (182810 => 182811)

--- trunk/Source/_javascript_Core/runtime/Options.h	2015-04-14 21:24:45 UTC (rev 182810)
+++ trunk/Source/_javascript_Core/runtime/Options.h	2015-04-14 21:25:22 UTC (rev 182811)
@@ -125,7 +125,7 @@
 v(bool, showFTLDisassembly, false, "dumps disassembly of FTL function upon compilation") \
 v(bool, showAllDFGNodes, false, nullptr) \
 v(optionRange, bytecodeRangeToDFGCompile, 0, "bytecode size range to allow DFG compilation on, e.g. 1:100") \
-v(optionString, dfgFunctionWhitelistFile, nullptr, "file with list of function signatures to allow DFG compilation on") \
+v(optionString, dfgWhitelist, nullptr, "file with list of function signatures to allow DFG compilation on") \
 v(bool, dumpSourceAtDFGTime, false, "dumps source code of JS function being DFG compiled") \
 v(bool, dumpBytecodeAtDFGTime, false, "dumps bytecode of JS function being DFG compiled") \
 v(bool, dumpGraphAfterParsing, false, nullptr) \






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [182809] trunk/Source/WebCore

[simon . fraser]

Title: [182809] trunk/Source/WebCore








Revision 182809
Author simon.fra...@apple.com
Date 2015-04-14 14:14:07 -0700 (Tue, 14 Apr 2015)


Log Message
[iOS] Clean up registration of layers with the ScrollingCoordinator
https://bugs.webkit.org/show_bug.cgi?id=143725

Reviewed by Tim Horton.

Simplify a couple of bits of code related to the registration of layers with
the ScrollingCoordinator in RenderLayerCompositor.

First, RenderLayerBacking was using ScrollingNodeTypes to choose which scrolling
roles a layer has, which let to ambiguous code where we hardcoded a ScrollingNodeType
with knowledge of what RenderLayerBacking did with it. Clean up by using LayerScrollCoordinationRole,
which is moved to RenderLayer.h so that RenderLayerCompositor.h and RenderLayerBacking.h
both see it.

Secondly, avoid having both detachFromScrollingCoordinator() and detachFromScrollingCoordinatorForRole()
by passing in the bitmask of roles.

* page/FrameView.cpp:
(WebCore::FrameView::scrollLayerID):
* rendering/RenderLayer.h:
* rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::~RenderLayerBacking):
(WebCore::RenderLayerBacking::detachFromScrollingCoordinator):
(WebCore::RenderLayerBacking::detachFromScrollingCoordinatorForRole): Deleted.
* rendering/RenderLayerBacking.h:
* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::updateScrollCoordinatedStatus):
(WebCore::RenderLayerCompositor::removeFromScrollCoordinatedLayers):
(WebCore::scrollCoordinationRoleForNodeType):
(WebCore::RenderLayerCompositor::attachScrollingNode):
(WebCore::RenderLayerCompositor::detachScrollCoordinatedLayer):
(WebCore::RenderLayerCompositor::updateScrollCoordinatedLayer):
(WebCore::RenderLayerCompositor::willRemoveScrollingLayerWithBacking):
(WebCore::RenderLayerCompositor::detachScrollCoordinatedLayerForRole): Deleted.
* rendering/RenderLayerCompositor.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/FrameView.cpp
trunk/Source/WebCore/rendering/RenderLayer.h
trunk/Source/WebCore/rendering/RenderLayerBacking.cpp
trunk/Source/WebCore/rendering/RenderLayerBacking.h
trunk/Source/WebCore/rendering/RenderLayerCompositor.cpp
trunk/Source/WebCore/rendering/RenderLayerCompositor.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (182808 => 182809)

--- trunk/Source/WebCore/ChangeLog	2015-04-14 21:08:02 UTC (rev 182808)
+++ trunk/Source/WebCore/ChangeLog	2015-04-14 21:14:07 UTC (rev 182809)
@@ -1,3 +1,41 @@
+2015-04-14  Simon Fraser  
+
+[iOS] Clean up registration of layers with the ScrollingCoordinator
+https://bugs.webkit.org/show_bug.cgi?id=143725
+
+Reviewed by Tim Horton.
+
+Simplify a couple of bits of code related to the registration of layers with
+the ScrollingCoordinator in RenderLayerCompositor.
+
+First, RenderLayerBacking was using ScrollingNodeTypes to choose which scrolling
+roles a layer has, which let to ambiguous code where we hardcoded a ScrollingNodeType
+with knowledge of what RenderLayerBacking did with it. Clean up by using LayerScrollCoordinationRole,
+which is moved to RenderLayer.h so that RenderLayerCompositor.h and RenderLayerBacking.h
+both see it.
+
+Secondly, avoid having both detachFromScrollingCoordinator() and detachFromScrollingCoordinatorForRole()
+by passing in the bitmask of roles.
+
+* page/FrameView.cpp:
+(WebCore::FrameView::scrollLayerID):
+* rendering/RenderLayer.h:
+* rendering/RenderLayerBacking.cpp:
+(WebCore::RenderLayerBacking::~RenderLayerBacking):
+(WebCore::RenderLayerBacking::detachFromScrollingCoordinator):
+(WebCore::RenderLayerBacking::detachFromScrollingCoordinatorForRole): Deleted.
+* rendering/RenderLayerBacking.h:
+* rendering/RenderLayerCompositor.cpp:
+(WebCore::RenderLayerCompositor::updateScrollCoordinatedStatus):
+(WebCore::RenderLayerCompositor::removeFromScrollCoordinatedLayers):
+(WebCore::scrollCoordinationRoleForNodeType):
+(WebCore::RenderLayerCompositor::attachScrollingNode):
+(WebCore::RenderLayerCompositor::detachScrollCoordinatedLayer):
+(WebCore::RenderLayerCompositor::updateScrollCoordinatedLayer):
+(WebCore::RenderLayerCompositor::willRemoveScrollingLayerWithBacking):
+(WebCore::RenderLayerCompositor::detachScrollCoordinatedLayerForRole): Deleted.
+* rendering/RenderLayerCompositor.h:
+
 2015-04-14  Benjamin Poulain  
 
 Add a conservative DFA minimizer for the content extension matcher


Modified: trunk/Source/WebCore/page/FrameView.cpp (182808 => 182809)

--- trunk/Source/WebCore/page/FrameView.cpp	2015-04-14 21:08:02 UTC (rev 182808)
+++ trunk/Source/WebCore/page/FrameView.cpp	2015-04-14 21:14:07 UTC (rev 182809)
@@ -835,7 +835,7 @@
 if (!backing)
 return 0;
 
-return backing->scrollingNodeIDForRole(FrameScrollingNode);
+return backing->scrollingNodeIDF

[webkit-changes] [182808] trunk

[benjamin]

Title: [182808] trunk








Revision 182808
Author benja...@webkit.org
Date 2015-04-14 14:08:02 -0700 (Tue, 14 Apr 2015)


Log Message
Add a conservative DFA minimizer for the content extension matcher
https://bugs.webkit.org/show_bug.cgi?id=143501

Reviewed by Alex Christensen.

Source/WebCore:

This patch adds a simple minimizer for DFA graphs. It is not a perfect minimizer:
some indistinguishable are not merged, but no two distinguishable are merged.

The general idea of the algorithm is to put all the state into a single set
and partition iteratively until it is impossible to split any subset by using
a transition to distinguish two states.

Let's ignore fallback transition for now, and I'll explain later how they fit in
the big picture.


The first thing we do is create a partition of the transition by grouping every
transition by the same character in the same subset. This partition of transitions
is the base by which we will partition the states.

Each subset in the transition partition is a "distinguisher" by which we can
separate the state partition.

We also create a second partition, the state partition. This is where we keep
all the subsets of states that have been split so far.

Let say we have the following graph.

1 --a--> 2
1 --b--> 3
2 --c--> 4 (final)
3 --c--> 4 (final)

The partition of transition would start with:
Set 0:
1 --a--> 2
Set 1:
1 --b--> 3
Set 2:
2 --c--> 4
3 --c--> 4

The state partition would have a single set with { 1, 2, 3, 4 }.


Next, we split the state partition by distinguishable final states. In this case,
we would split it into { 1, 2, 3 }, { 4 }.

We then refine the transition partition by splitting it by the states that have
been distinguished. Here, the only transitions to 4 are both is the same set (set 2),
so the transition partition remains the same.


We can now execute the main loop of the algorithm:
1) Split the states by the transitions.
2) Split the transitions that are now reaching two different sets of the state partition.
3) Add any newly discovered "distinguisher" (the ones we split) to the list of "distinguisher"
   to process.

In this case, we just iterate over the partition set in order, and add newly split transitions
to the end of the list.

In the example, we would first visit set 0. We have that state 1 is distinguishable
by "a", and the state partition would become { 1 }, { 2, 3 }, { 4 }.

We then visit transition set 1, it distinguishes state 1 which is already alone -> nothing to do.

Finally, we process the transition set 2, it distinguishes 2 and 3, they are already in the same
set -> nothing to do.

There is no more transition to process, we have 3 unique subsets and we should merge 2 and 3.

---

Okay, now how to we fit fallback transition in this model. In this patch, I take the conservative
approach: we split everything assuming fallback transition do not exist, then we refine
by the fallback transitions.

Let's take the following example:
1 --a--> 3
2 --a--> 3
1 -[f]-> 4
2 -[f]-> 5

and at this stage in the algorithm, we have the sets { 1, 2 }, { 3 }, { 4 }, { 5 }.
The states 1 and 2 are together because they cannot be distinguished by 'a', but
the fallback transition distinguishes them.

Since we have done every other split, we have one useful property: we know that every
state in every set transition with the exact set of characters within that set.
If that was not true, there would be one "distinguisher" 'x' that could spit the set
into two subsets: the one with the transition 'x' and the ones without.

Since all the transitions are the same, there is no overlap between the defined transition
and the fallback transition. Consequently, we can use the fallback transition as a whole
transition and use it to distinguish the states.

The fallback transitions are handled like any other transition, we have a partition of such
transitions and split by each of them. BUT, we can only use them after every unique transition
has been covered.

This trick is also what makes the minimization imperfect: it should be possible to merge
states with overlap in their fallback transitions but we would split them.

---

Antti Valmari, Petri Lehtinen, Marie-Pierre Béal and Maxime Crochemore deserve credit for their indirect
work on this patch. Thanks for your wonderful papers about DFA minimization.

* WebCore.xcodeproj/project.pbxproj:
* contentextensions/ContentExtensionCompiler.cpp:
(WebCore::ContentExtensions::compileRuleList):
* contentextensions/DFA.cpp:
(WebCore::ContentExtensions::DFA::minimize):
(WebCore::ContentExtensions::DFA::debugPrintDot):
* contentextensions/DFA.h:
* contentextensions/DFABytecodeCompiler.cpp:
(WebCore::ContentExtensions::DFABytecodeCompiler::compileNode):
* contentextensions/DFAMinimizer.cpp: Added.
(WebCore::ContentExtensions::DFAMinimizer::simplifyTransitions):
(WebCore::ContentExtensions::DFAMinimizer::Partition::initialize):
(WebCore::ContentExtensions::DFAMinimizer::Par

[webkit-changes] [182807] trunk/Source/WebCore

[cdumez]

Title: [182807] trunk/Source/WebCore








Revision 182807
Author cdu...@apple.com
Date 2015-04-14 13:54:36 -0700 (Tue, 14 Apr 2015)


Log Message
ASSERT(frame().view() == this) assertion hit in FrameView::windowClipRect() on Windows bots
https://bugs.webkit.org/show_bug.cgi?id=143723

Reviewed by Brent Fulgham.

ASSERT(frame().view() == this) in FrameView::windowClipRect() can be hit
if the post layout timer timer fires after the page has entered page
cache. Upon entering page cache, we call FrameView::unscheduleRelayout()
to stop the layout timer if it is active, however, we don't stop the
post-layout timer. Therefore, there was nothing preventing the
post-layout timer from firing after entering page cache.

In this patch, we unschedule the post-layout timer in
FrameView::unscheduleRelayout() to protect ourselves against this.

I think we were only seeing the assertion hit on Windows because this
timer probably gets scheduled more frequently on Windows. On Mac, I
rarely see it getting scheduled.

No new tests, should fix crashing tests on the bots.

* page/FrameView.cpp:
(WebCore::FrameView::unscheduleRelayout):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/FrameView.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (182806 => 182807)

--- trunk/Source/WebCore/ChangeLog	2015-04-14 19:35:32 UTC (rev 182806)
+++ trunk/Source/WebCore/ChangeLog	2015-04-14 20:54:36 UTC (rev 182807)
@@ -1,5 +1,31 @@
 2015-04-14  Chris Dumez  
 
+ASSERT(frame().view() == this) assertion hit in FrameView::windowClipRect() on Windows bots
+https://bugs.webkit.org/show_bug.cgi?id=143723
+
+Reviewed by Brent Fulgham.
+
+ASSERT(frame().view() == this) in FrameView::windowClipRect() can be hit
+if the post layout timer timer fires after the page has entered page
+cache. Upon entering page cache, we call FrameView::unscheduleRelayout()
+to stop the layout timer if it is active, however, we don't stop the
+post-layout timer. Therefore, there was nothing preventing the
+post-layout timer from firing after entering page cache.
+
+In this patch, we unschedule the post-layout timer in
+FrameView::unscheduleRelayout() to protect ourselves against this.
+
+I think we were only seeing the assertion hit on Windows because this
+timer probably gets scheduled more frequently on Windows. On Mac, I
+rarely see it getting scheduled.
+
+No new tests, should fix crashing tests on the bots.
+
+* page/FrameView.cpp:
+(WebCore::FrameView::unscheduleRelayout):
+
+2015-04-14  Chris Dumez  
+
 FrameView::m_frame should be a Ref
 https://bugs.webkit.org/show_bug.cgi?id=143716
 


Modified: trunk/Source/WebCore/page/FrameView.cpp (182806 => 182807)

--- trunk/Source/WebCore/page/FrameView.cpp	2015-04-14 19:35:32 UTC (rev 182806)
+++ trunk/Source/WebCore/page/FrameView.cpp	2015-04-14 20:54:36 UTC (rev 182807)
@@ -2620,6 +2620,9 @@
 
 void FrameView::unscheduleRelayout()
 {
+if (m_postLayoutTasksTimer.isActive())
+m_postLayoutTasksTimer.stop();
+
 if (!m_layoutTimer.isActive())
 return;
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [182806] trunk/LayoutTests

[ap]

Title: [182806] trunk/LayoutTests








Revision 182806
Author a...@apple.com
Date 2015-04-14 12:35:32 -0700 (Tue, 14 Apr 2015)


Log Message
inspector/console/console-api.html is very slow, frequently timing out
https://bugs.webkit.org/show_bug.cgi?id=143719

* TestExpectations: Marking as slow.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (182805 => 182806)

--- trunk/LayoutTests/ChangeLog	2015-04-14 19:22:35 UTC (rev 182805)
+++ trunk/LayoutTests/ChangeLog	2015-04-14 19:35:32 UTC (rev 182806)
@@ -1,5 +1,12 @@
 2015-04-14  Alexey Proskuryakov  
 
+inspector/console/console-api.html is very slow, frequently timing out
+https://bugs.webkit.org/show_bug.cgi?id=143719
+
+* TestExpectations: Marking as slow.
+
+2015-04-14  Alexey Proskuryakov  
+
 fast/sub-pixel/input-caret-on-subpixel-bound.html is flaky
 https://bugs.webkit.org/show_bug.cgi?id=143697
 


Modified: trunk/LayoutTests/TestExpectations (182805 => 182806)

--- trunk/LayoutTests/TestExpectations	2015-04-14 19:22:35 UTC (rev 182805)
+++ trunk/LayoutTests/TestExpectations	2015-04-14 19:35:32 UTC (rev 182806)
@@ -105,6 +105,8 @@
 # Doesn't work yet, relies on network replay functionality (webkit.org/b/130728, webkit.org/b/129391)
 webkit.org/b/131318 http/tests/inspector/replay/document-last-modified-fallback-value.html [ Skip ]
 
+[ Debug ] inspector/console/console-api.html [ Slow ]
+
 # Collecting region's children in a named flow not supported yet
 webkit.org/b/74144 fast/regions/flow-body-in-html.html [ Skip ]
 webkit.org/b/74144 fast/regions/universal-selector-children-to-the-same-region.html [ Skip ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [182805] trunk/Source/WebCore

[cdumez]

Title: [182805] trunk/Source/WebCore








Revision 182805
Author cdu...@apple.com
Date 2015-04-14 12:22:35 -0700 (Tue, 14 Apr 2015)


Log Message
FrameView::m_frame should be a Ref
https://bugs.webkit.org/show_bug.cgi?id=143716

Reviewed by Andreas Kling.

FrameView::m_frame should be a Ref instead of a RefPtr as
it can never be null.

* page/FrameView.cpp:
(WebCore::FrameView::FrameView):
(WebCore::FrameView::flushCompositingStateForThisFrame):
(WebCore::FrameView::hasCompositedContentIncludingDescendants):
(WebCore::FrameView::flushCompositingStateIncludingSubframes):
(WebCore::FrameView::updateCanBlitOnScrollRecursively):
(WebCore::FrameView::setIsOverlapped):
(WebCore::FrameView::shouldUpdateCompositingLayersAfterScrolling):
(WebCore::FrameView::renderedCharactersExceed):
(WebCore::FrameView::updateLayerFlushThrottling):
(WebCore::FrameView::serviceScriptedAnimations):
(WebCore::FrameView::updateBackgroundRecursively):
(WebCore::FrameView::adjustScrollStepForFixedContent):
(WebCore::FrameView::paintContentsForSnapshot):
(WebCore::FrameView::notifyWidgetsInAllFrames):
(WebCore::FrameView::setExposedRect):
(WebCore::FrameView::setViewportSizeForCSSViewportUnits):
* page/FrameView.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/FrameView.cpp
trunk/Source/WebCore/page/FrameView.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (182804 => 182805)

--- trunk/Source/WebCore/ChangeLog	2015-04-14 19:15:28 UTC (rev 182804)
+++ trunk/Source/WebCore/ChangeLog	2015-04-14 19:22:35 UTC (rev 182805)
@@ -1,3 +1,32 @@
+2015-04-14  Chris Dumez  
+
+FrameView::m_frame should be a Ref
+https://bugs.webkit.org/show_bug.cgi?id=143716
+
+Reviewed by Andreas Kling.
+
+FrameView::m_frame should be a Ref instead of a RefPtr as
+it can never be null.
+
+* page/FrameView.cpp:
+(WebCore::FrameView::FrameView):
+(WebCore::FrameView::flushCompositingStateForThisFrame):
+(WebCore::FrameView::hasCompositedContentIncludingDescendants):
+(WebCore::FrameView::flushCompositingStateIncludingSubframes):
+(WebCore::FrameView::updateCanBlitOnScrollRecursively):
+(WebCore::FrameView::setIsOverlapped):
+(WebCore::FrameView::shouldUpdateCompositingLayersAfterScrolling):
+(WebCore::FrameView::renderedCharactersExceed):
+(WebCore::FrameView::updateLayerFlushThrottling):
+(WebCore::FrameView::serviceScriptedAnimations):
+(WebCore::FrameView::updateBackgroundRecursively):
+(WebCore::FrameView::adjustScrollStepForFixedContent):
+(WebCore::FrameView::paintContentsForSnapshot):
+(WebCore::FrameView::notifyWidgetsInAllFrames):
+(WebCore::FrameView::setExposedRect):
+(WebCore::FrameView::setViewportSizeForCSSViewportUnits):
+* page/FrameView.h:
+
 2015-04-13  Simon Fraser  
 
 [iOS WK2] Interactive elements of developer.apple.com are broken


Modified: trunk/Source/WebCore/page/FrameView.cpp (182804 => 182805)

--- trunk/Source/WebCore/page/FrameView.cpp	2015-04-14 19:15:28 UTC (rev 182804)
+++ trunk/Source/WebCore/page/FrameView.cpp	2015-04-14 19:22:35 UTC (rev 182805)
@@ -161,7 +161,7 @@
 }
 
 FrameView::FrameView(Frame& frame)
-: m_frame(&frame)
+: m_frame(frame)
 , m_canHaveScrollbars(true)
 , m_layoutTimer(*this, &FrameView::layoutTimerFired)
 , m_layoutRoot(nullptr)
@@ -909,7 +909,7 @@
 tileCache->doPendingRepaints();
 #endif
 
-renderView->compositor().flushPendingLayerChanges(rootFrameForFlush == &frame());
+renderView->compositor().flushPendingLayerChanges(rootFrameForFlush == m_frame.ptr());
 
 return true;
 }
@@ -1014,7 +1014,7 @@
 
 bool FrameView::hasCompositedContentIncludingDescendants() const
 {
-for (Frame* frame = m_frame.get(); frame; frame = frame->tree().traverseNext(m_frame.get())) {
+for (auto* frame = m_frame.ptr(); frame; frame = frame->tree().traverseNext(m_frame.ptr())) {
 RenderView* renderView = frame->contentRenderer();
 if (RenderLayerCompositor* compositor = renderView ? &renderView->compositor() : nullptr) {
 if (compositor->inCompositingMode())
@@ -1063,7 +1063,7 @@
 {
 bool allFramesFlushed = flushCompositingStateForThisFrame(&frame());
 
-for (Frame* child = frame().tree().firstChild(); child; child = child->tree().traverseNext(&frame())) {
+for (Frame* child = frame().tree().firstChild(); child; child = child->tree().traverseNext(m_frame.ptr())) {
 bool flushed = child->view()->flushCompositingStateForThisFrame(&frame());
 allFramesFlushed &= flushed;
 }
@@ -1511,7 +1511,7 @@
 
 void FrameView::updateCanBlitOnScrollRecursively()
 {
-for (Frame* frame = m_frame.get(); frame; frame = frame->tree().traverseNext(m_frame.get())) {
+for (auto* frame = m_frame.ptr(); frame; frame = frame->tree().traverseNext(m_frame.ptr())) {
 if (FrameView* view = frame->view())
 v

[webkit-changes] [182804] trunk/Source/WebKit2

[andersca]

Title: [182804] trunk/Source/WebKit2








Revision 182804
Author ander...@apple.com
Date 2015-04-14 12:15:28 -0700 (Tue, 14 Apr 2015)


Log Message
More work on making the SharedMemory interface more sane
https://bugs.webkit.org/show_bug.cgi?id=143718

Reviewed by Andreas Kling.

Get rid of m_shouldVMDeallocateData. The idea is that shared memory created by calling
SharedMemory::allocate has a non-null m_data pointer, and a null m_port. Shared memory created
by calling SharedMemory::create with a pointer and a length has a non-null port but a null m_data
since the data can be unmapped by the caller and we don't want to hold on to dangling pointers.

* Platform/SharedMemory.h:
(WebKit::SharedMemory::data):
* Platform/mac/SharedMemoryMac.cpp:
(WebKit::SharedMemory::allocate):
(WebKit::SharedMemory::create):
(WebKit::SharedMemory::map):
(WebKit::SharedMemory::~SharedMemory):
(WebKit::SharedMemory::createHandle):

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/Platform/SharedMemory.h
trunk/Source/WebKit2/Platform/mac/SharedMemoryMac.cpp




Diff

Modified: trunk/Source/WebKit2/ChangeLog (182803 => 182804)

--- trunk/Source/WebKit2/ChangeLog	2015-04-14 18:40:27 UTC (rev 182803)
+++ trunk/Source/WebKit2/ChangeLog	2015-04-14 19:15:28 UTC (rev 182804)
@@ -1,3 +1,24 @@
+2015-04-14  Anders Carlsson  
+
+More work on making the SharedMemory interface more sane
+https://bugs.webkit.org/show_bug.cgi?id=143718
+
+Reviewed by Andreas Kling.
+
+Get rid of m_shouldVMDeallocateData. The idea is that shared memory created by calling
+SharedMemory::allocate has a non-null m_data pointer, and a null m_port. Shared memory created
+by calling SharedMemory::create with a pointer and a length has a non-null port but a null m_data
+since the data can be unmapped by the caller and we don't want to hold on to dangling pointers.
+
+* Platform/SharedMemory.h:
+(WebKit::SharedMemory::data):
+* Platform/mac/SharedMemoryMac.cpp:
+(WebKit::SharedMemory::allocate):
+(WebKit::SharedMemory::create):
+(WebKit::SharedMemory::map):
+(WebKit::SharedMemory::~SharedMemory):
+(WebKit::SharedMemory::createHandle):
+
 2015-04-14  Antti Koivisto  
 
 Network Cache: Deduplicate body data


Modified: trunk/Source/WebKit2/Platform/SharedMemory.h (182803 => 182804)

--- trunk/Source/WebKit2/Platform/SharedMemory.h	2015-04-14 18:40:27 UTC (rev 182803)
+++ trunk/Source/WebKit2/Platform/SharedMemory.h	2015-04-14 19:15:28 UTC (rev 182804)
@@ -85,7 +85,11 @@
 bool createHandle(Handle&, Protection);
 
 size_t size() const { return m_size; }
-void* data() const { return m_data; }
+void* data() const
+{
+ASSERT(m_data);
+return m_data;
+}
 
 // Return the system page size in bytes.
 static unsigned systemPageSize();
@@ -93,7 +97,6 @@
 private:
 size_t m_size;
 void* m_data;
-bool m_shouldVMDeallocateData;
 Protection m_protection;
 
 #if OS(DARWIN)


Modified: trunk/Source/WebKit2/Platform/mac/SharedMemoryMac.cpp (182803 => 182804)

--- trunk/Source/WebKit2/Platform/mac/SharedMemoryMac.cpp	2015-04-14 18:40:27 UTC (rev 182803)
+++ trunk/Source/WebKit2/Platform/mac/SharedMemoryMac.cpp	2015-04-14 19:15:28 UTC (rev 182804)
@@ -106,17 +106,16 @@
 kern_return_t kr = mach_vm_allocate(mach_task_self(), &address, round_page(size), VM_FLAGS_ANYWHERE);
 if (kr != KERN_SUCCESS) {
 LOG_ERROR("Failed to allocate mach_vm_allocate shared memory (%zu bytes). %s (%x)", size, mach_error_string(kr), kr);
-return 0;
+return nullptr;
 }
 
-RefPtr sharedMemory = create(toPointer(address), size, Protection::ReadWrite);
-if (!sharedMemory) {
-mach_vm_deallocate(mach_task_self(), address, round_page(size));
-return 0;
-}
-
-sharedMemory->m_shouldVMDeallocateData = true;
-return sharedMemory.release();
+RefPtr sharedMemory = adoptRef(*new SharedMemory);
+sharedMemory->m_size = size;
+sharedMemory->m_data = toPointer(address);
+sharedMemory->m_port = MACH_PORT_NULL;
+sharedMemory->m_protection = Protection::ReadWrite;
+
+return sharedMemory;
 }
 
 static inline vm_prot_t machProtection(SharedMemory::Protection protection)
@@ -155,8 +154,7 @@
 
 RefPtr sharedMemory(adoptRef(new SharedMemory));
 sharedMemory->m_size = size;
-sharedMemory->m_data = data;
-sharedMemory->m_shouldVMDeallocateData = false;
+sharedMemory->m_data = nullptr;
 sharedMemory->m_port = port;
 sharedMemory->m_protection = protection;
 
@@ -179,7 +177,6 @@
 RefPtr sharedMemory(adoptRef(new SharedMemory));
 sharedMemory->m_size = handle.m_size;
 sharedMemory->m_data = toPointer(mappedAddress);
-sharedMemory->m_shouldVMDeallocateData = true;
 sharedMemory->m_port = MACH_PORT_NULL;
 sharedMemory->m_protection = protection;
 
@@ -188,7 +185,7 @@
 
 SharedMemory::~Sha

[webkit-changes] [182803] trunk/Source/WebKit2

[antti]

Title: [182803] trunk/Source/WebKit2








Revision 182803
Author an...@apple.com
Date 2015-04-14 11:40:27 -0700 (Tue, 14 Apr 2015)


Log Message
Network Cache: Deduplicate body data
https://bugs.webkit.org/show_bug.cgi?id=143652

Reviewed by Darin Adler.

It is common to have cache entries with identical body data. This happens when the same resource is loaded from
a different URL (https vs http, slash vs no-slash at end, etc.). It also happens when the same URL is
referenced from different cache partitions.

We can improve disk space efficiency and use less memory by sharing identical body data between cache entries.

This patch splits the body data out from the record file. The new record file contains meta data and response
headers only. Body data is stored using the new BlobStorage interface. Files are deduplicated by computing
SHA1 hash over the data and looking for an existing blob with the same hash. If found the existing entry
is reused by creating a hard link to it.

The new disk structure looks like this:

WebKitCache/
Version 3/
Blobs/
0A3C9A970ADA27FAE9BD7BC630BAD0B929C293C0
0A6B8060BA77DF92C82A2FD7AF58F79524D8F34C
...
Records/
apple.com/
0B8645B04E7EC78C178B7460052601C2
0B8645B04E7EC78C178B7460052601C2-body
0CB1A3638D1C5A09C5E3283A74FA040B
0CB1A3638D1C5A09C5E3283A74FA040B-body
...

Each record file has an associated -body which is a hard link to a file in the Blobs directory.

The patch increases effective capacity by 10-20% with a typical cache. It also saves memory especially when identical
resources are used in multiple tabs.

Currently all >0 sized resources are stored as shared blobs. In future small resources should be integrated into record
files and blobs used for larger files only.

* NetworkProcess/cache/NetworkCache.cpp:
(WebKit::NetworkCache::Cache::store):
(WebKit::NetworkCache::Cache::update):

Adopt the new storage interface.

(WebKit::NetworkCache::Cache::dumpContentsToFile):
* NetworkProcess/cache/NetworkCacheBlobStorage.cpp: Added.
(WebKit::NetworkCache::BlobStorage::BlobStorage):
(WebKit::NetworkCache::BlobStorage::synchronize):

Compute size and delete unused files from the Blobs directory (link count == 1).

(WebKit::NetworkCache::BlobStorage::blobPath):
(WebKit::NetworkCache::BlobStorage::add):
(WebKit::NetworkCache::BlobStorage::get):

Interface for storing and retrieving data blobs. Blobs are deduplicated on add.

(WebKit::NetworkCache::BlobStorage::remove):

Removes the link but doesn't remove the blob even if there are no other clients. That happens on next synchronize().

(WebKit::NetworkCache::BlobStorage::shareCount):

Checks the link count to get the number of clients.

* NetworkProcess/cache/NetworkCacheBlobStorage.h: Added.
(WebKit::NetworkCache::BlobStorage::approximateSize):
* NetworkProcess/cache/NetworkCacheCoders.cpp:
(WebKit::NetworkCache::Coder::encode):
(WebKit::NetworkCache::Coder::decode):
* NetworkProcess/cache/NetworkCacheCoders.h:
* NetworkProcess/cache/NetworkCacheData.h:
(WebKit::NetworkCache::Data::isEmpty):
* NetworkProcess/cache/NetworkCacheDataCocoa.mm:
(WebKit::NetworkCache::Data::empty):
(WebKit::NetworkCache::Data::fromMap):
(WebKit::NetworkCache::mapFile):
(WebKit::NetworkCache::computeSHA1):
(WebKit::NetworkCache::bytesEqual):

Add some helpers.

* NetworkProcess/cache/NetworkCacheEntry.cpp:
(WebKit::NetworkCache::Entry::asJSON):
* NetworkProcess/cache/NetworkCacheIOChannelCocoa.mm:
(WebKit::NetworkCache::IOChannel::IOChannel):
* NetworkProcess/cache/NetworkCacheStorage.cpp:
(WebKit::NetworkCache::makeRecordDirectoryPath):
(WebKit::NetworkCache::makeBlobDirectoryPath):
(WebKit::NetworkCache::Storage::Storage):
(WebKit::NetworkCache::Storage::approximateSize):
(WebKit::NetworkCache::Storage::synchronize):
(WebKit::NetworkCache::partitionPathForKey):
(WebKit::NetworkCache::recordPathForKey):
(WebKit::NetworkCache::bodyPath):
(WebKit::NetworkCache::decodeRecordMetaData):
(WebKit::NetworkCache::decodeRecordHeader):
(WebKit::NetworkCache::createRecord):
(WebKit::NetworkCache::encodeRecordMetaData):
(WebKit::NetworkCache::encodeRecordHeader):
(WebKit::NetworkCache::Storage::remove):
(WebKit::NetworkCache::Storage::updateFileModificationTime):
(WebKit::NetworkCache::Storage::dispatchReadOperation):

Read both the blob and the record entry.

(WebKit::NetworkCache::Storage::finishReadOperation):

Factor to a function.

(WebKit::NetworkCache::Storage::store):
(WebKit::NetworkCache::Storage::traverse):
(WebKit::NetworkCache::Storage::dispatchPendingWriteOperations):
(WebKit::NetworkCache::Storage::dispatchWriteOperation):

We don't need separate full write and header write paths anymore. Everything is treated
as a full write and deduplication stops us writing the body again.

This simplifies the code and data structures.

(WebKit::NetworkCache::Storage::fini

[webkit-changes] [182802] trunk/Tools

[dbates]

Title: [182802] trunk/Tools








Revision 182802
Author dba...@webkit.org
Date 2015-04-14 10:57:36 -0700 (Tue, 14 Apr 2015)


Log Message
Skip failing test Tests/WebKit2Cocoa/FixedLayoutSize.mm on iOS
https://bugs.webkit.org/show_bug.cgi?id=143693


Reviewed by Tim Horton.

Skip the test Tests/WebKit2Cocoa/FixedLayoutSize.mm as we do not plan
to use the fixed layout code on iOS at this time.

* TestWebKitAPI/Tests/WebKit2Cocoa/FixedLayoutSize.mm: Add !PLATFORM(IOS)-guard.

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/FixedLayoutSize.mm




Diff

Modified: trunk/Tools/ChangeLog (182801 => 182802)

--- trunk/Tools/ChangeLog	2015-04-14 17:34:03 UTC (rev 182801)
+++ trunk/Tools/ChangeLog	2015-04-14 17:57:36 UTC (rev 182802)
@@ -1,3 +1,16 @@
+2015-04-14  Daniel Bates  
+
+Skip failing test Tests/WebKit2Cocoa/FixedLayoutSize.mm on iOS
+https://bugs.webkit.org/show_bug.cgi?id=143693
+
+
+Reviewed by Tim Horton.
+
+Skip the test Tests/WebKit2Cocoa/FixedLayoutSize.mm as we do not plan
+to use the fixed layout code on iOS at this time.
+
+* TestWebKitAPI/Tests/WebKit2Cocoa/FixedLayoutSize.mm: Add !PLATFORM(IOS)-guard.
+
 2015-04-14  Dominik Röttsches  
 
 Remove myself from watchlist, remove empty Cairo and HarfBuzz watchlists


Modified: trunk/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/FixedLayoutSize.mm (182801 => 182802)

--- trunk/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/FixedLayoutSize.mm	2015-04-14 17:34:03 UTC (rev 182801)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/FixedLayoutSize.mm	2015-04-14 17:57:36 UTC (rev 182802)
@@ -30,7 +30,7 @@
 #import 
 #import 
 
-#if WK_API_ENABLED
+#if WK_API_ENABLED && !PLATFORM(IOS)
 
 static bool fixedLayoutSizeDone;
 static bool fixedLayoutSizeAfterNavigationDone;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [182801] trunk/LayoutTests

[ap]

Title: [182801] trunk/LayoutTests








Revision 182801
Author a...@apple.com
Date 2015-04-14 10:34:03 -0700 (Tue, 14 Apr 2015)


Log Message
fast/sub-pixel/input-caret-on-subpixel-bound.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=143697

Reviewed by Anders Carlsson.

* fast/sub-pixel/input-caret-on-subpixel-bound.html: Don't wait for a timer to fire
after removing the last character.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/sub-pixel/input-caret-on-subpixel-bound.html




Diff

Modified: trunk/LayoutTests/ChangeLog (182800 => 182801)

--- trunk/LayoutTests/ChangeLog	2015-04-14 17:30:42 UTC (rev 182800)
+++ trunk/LayoutTests/ChangeLog	2015-04-14 17:34:03 UTC (rev 182801)
@@ -1,5 +1,15 @@
 2015-04-14  Alexey Proskuryakov  
 
+fast/sub-pixel/input-caret-on-subpixel-bound.html is flaky
+https://bugs.webkit.org/show_bug.cgi?id=143697
+
+Reviewed by Anders Carlsson.
+
+* fast/sub-pixel/input-caret-on-subpixel-bound.html: Don't wait for a timer to fire
+after removing the last character.
+
+2015-04-14  Alexey Proskuryakov  
+
 Two flaky tests in http/tests/security/mixedContent
 https://bugs.webkit.org/show_bug.cgi?id=143695
 


Modified: trunk/LayoutTests/fast/sub-pixel/input-caret-on-subpixel-bound.html (182800 => 182801)

--- trunk/LayoutTests/fast/sub-pixel/input-caret-on-subpixel-bound.html	2015-04-14 17:30:42 UTC (rev 182800)
+++ trunk/LayoutTests/fast/sub-pixel/input-caret-on-subpixel-bound.html	2015-04-14 17:34:03 UTC (rev 182801)
@@ -35,10 +35,10 @@
 el.focus();
 var step = function() {
 var value = el.value;
-if (value) {
+if (el.value)
 el.value = value.substr(0, value.length - 1);
+if (el.value)
 window.setTimeout(step, 10);
-}
 else if (window.testRunner)
 testRunner.notifyDone();
 };






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [182800] trunk/LayoutTests

[ap]

Title: [182800] trunk/LayoutTests








Revision 182800
Author a...@apple.com
Date 2015-04-14 10:30:42 -0700 (Tue, 14 Apr 2015)


Log Message
Two flaky tests in http/tests/security/mixedContent
https://bugs.webkit.org/show_bug.cgi?id=143695

Reviewed by Csaba Osztrogonác.

Speculative fix. Do not start opening a secondary window until fully done with the
main document.

* http/tests/security/mixedContent/data-url-iframe-in-main-frame-expected.txt:
* http/tests/security/mixedContent/data-url-iframe-in-main-frame.html:
* http/tests/security/mixedContent/insecure-css-in-main-frame-expected.txt:
* http/tests/security/mixedContent/insecure-css-in-main-frame.html:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/http/tests/security/mixedContent/data-url-iframe-in-main-frame-expected.txt
trunk/LayoutTests/http/tests/security/mixedContent/data-url-iframe-in-main-frame.html
trunk/LayoutTests/http/tests/security/mixedContent/insecure-css-in-main-frame-expected.txt
trunk/LayoutTests/http/tests/security/mixedContent/insecure-css-in-main-frame.html




Diff

Modified: trunk/LayoutTests/ChangeLog (182799 => 182800)

--- trunk/LayoutTests/ChangeLog	2015-04-14 17:25:31 UTC (rev 182799)
+++ trunk/LayoutTests/ChangeLog	2015-04-14 17:30:42 UTC (rev 182800)
@@ -1,3 +1,18 @@
+2015-04-14  Alexey Proskuryakov  
+
+Two flaky tests in http/tests/security/mixedContent
+https://bugs.webkit.org/show_bug.cgi?id=143695
+
+Reviewed by Csaba Osztrogonác.
+
+Speculative fix. Do not start opening a secondary window until fully done with the
+main document.
+
+* http/tests/security/mixedContent/data-url-iframe-in-main-frame-expected.txt:
+* http/tests/security/mixedContent/data-url-iframe-in-main-frame.html:
+* http/tests/security/mixedContent/insecure-css-in-main-frame-expected.txt:
+* http/tests/security/mixedContent/insecure-css-in-main-frame.html:
+
 2015-04-13  Simon Fraser  
 
 [iOS WK2] Interactive elements of developer.apple.com are broken


Modified: trunk/LayoutTests/http/tests/security/mixedContent/data-url-iframe-in-main-frame-expected.txt (182799 => 182800)

--- trunk/LayoutTests/http/tests/security/mixedContent/data-url-iframe-in-main-frame-expected.txt	2015-04-14 17:25:31 UTC (rev 182799)
+++ trunk/LayoutTests/http/tests/security/mixedContent/data-url-iframe-in-main-frame-expected.txt	2015-04-14 17:30:42 UTC (rev 182800)
@@ -1,5 +1,5 @@
+main frame - didFinishDocumentLoadForFrame
 main frame - didStartProvisionalLoadForFrame
-main frame - didFinishDocumentLoadForFrame
 main frame - didHandleOnloadEventsForFrame
 main frame - didFinishLoadForFrame
 main frame - didCommitLoadForFrame


Modified: trunk/LayoutTests/http/tests/security/mixedContent/data-url-iframe-in-main-frame.html (182799 => 182800)

--- trunk/LayoutTests/http/tests/security/mixedContent/data-url-iframe-in-main-frame.html	2015-04-14 17:25:31 UTC (rev 182799)
+++ trunk/LayoutTests/http/tests/security/mixedContent/data-url-iframe-in-main-frame.html	2015-04-14 17:30:42 UTC (rev 182800)
@@ -19,7 +19,9 @@
 *not* trigger a mixed content callback because the data URL cannot be corrupted
 by active network attackers.
 
-window.open("https://127.0.0.1:8443/security/mixedContent/resources/frame-with-data-url-frame.html");
+_onload_ = function() {
+window.open("https://127.0.0.1:8443/security/mixedContent/resources/frame-with-data-url-frame.html");
+}
 
 
 


Modified: trunk/LayoutTests/http/tests/security/mixedContent/insecure-css-in-main-frame-expected.txt (182799 => 182800)

--- trunk/LayoutTests/http/tests/security/mixedContent/insecure-css-in-main-frame-expected.txt	2015-04-14 17:25:31 UTC (rev 182799)
+++ trunk/LayoutTests/http/tests/security/mixedContent/insecure-css-in-main-frame-expected.txt	2015-04-14 17:30:42 UTC (rev 182800)
@@ -1,5 +1,5 @@
+main frame - didFinishDocumentLoadForFrame
 main frame - didStartProvisionalLoadForFrame
-main frame - didFinishDocumentLoadForFrame
 main frame - didHandleOnloadEventsForFrame
 main frame - didFinishLoadForFrame
 main frame - didCommitLoadForFrame


Modified: trunk/LayoutTests/http/tests/security/mixedContent/insecure-css-in-main-frame.html (182799 => 182800)

--- trunk/LayoutTests/http/tests/security/mixedContent/insecure-css-in-main-frame.html	2015-04-14 17:25:31 UTC (rev 182799)
+++ trunk/LayoutTests/http/tests/security/mixedContent/insecure-css-in-main-frame.html	2015-04-14 17:30:42 UTC (rev 182800)
@@ -19,7 +19,9 @@
 trigger a mixed content callback because the main frame in the window is HTTPS
 but is running insecure content.
 
-window.open("https://127.0.0.1:8443/security/mixedContent/resources/frame-with-insecure-css.html");
+_onload_ = function() {
+window.open("https://127.0.0.1:8443/security/mixedContent/resources/frame-with-insecure-css.html");
+}
 
 
 






___
webkit-chan

[webkit-changes] [182799] trunk

[simon . fraser]

Title: [182799] trunk








Revision 182799
Author simon.fra...@apple.com
Date 2015-04-14 10:25:31 -0700 (Tue, 14 Apr 2015)


Log Message
[iOS WK2] Interactive elements of developer.apple.com are broken
https://bugs.webkit.org/show_bug.cgi?id=143692
Source/WebCore:

rdar://problem/19320087

Reviewed by Sam Weinig.

When a composited RenderLayer had nodes in the scrolling tree by virtue of
both position and overflow:scroll, and one of those reasons disappeared,
we'd fail to remove the corresponding node from the scrolling tree. This
could leave an overflow:scroll element behaving as if it were position:fixed.

Fix by having RenderLayerCompositor::updateScrollCoordinationForThisFrame()
detach the layer on a per-role basis.

Test: platform/ios-simulator-wk2/scrolling/remove-scrolling-role.html

* rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::detachFromScrollingCoordinatorForRole):
* rendering/RenderLayerBacking.h:
* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::detachScrollCoordinatedLayerForRole):
(WebCore::RenderLayerCompositor::detachScrollCoordinatedLayer): Just moved.
(WebCore::RenderLayerCompositor::updateScrollCoordinatedLayer): Call detachScrollCoordinatedLayerForRole()
if the layer doesn't have the relevant scrolling reasons.
* rendering/RenderLayerCompositor.h:

LayoutTests:

Reviewed by Sam Weinig.

* platform/ios-simulator-wk2/scrolling/remove-scrolling-role-expected.txt: Added.
* platform/ios-simulator-wk2/scrolling/remove-scrolling-role.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderLayerBacking.cpp
trunk/Source/WebCore/rendering/RenderLayerBacking.h
trunk/Source/WebCore/rendering/RenderLayerCompositor.cpp
trunk/Source/WebCore/rendering/RenderLayerCompositor.h


Added Paths

trunk/LayoutTests/platform/ios-simulator-wk2/scrolling/
trunk/LayoutTests/platform/ios-simulator-wk2/scrolling/remove-scrolling-role-expected.txt
trunk/LayoutTests/platform/ios-simulator-wk2/scrolling/remove-scrolling-role.html




Diff

Modified: trunk/LayoutTests/ChangeLog (182798 => 182799)

--- trunk/LayoutTests/ChangeLog	2015-04-14 17:07:11 UTC (rev 182798)
+++ trunk/LayoutTests/ChangeLog	2015-04-14 17:25:31 UTC (rev 182799)
@@ -1,3 +1,13 @@
+2015-04-13  Simon Fraser  
+
+[iOS WK2] Interactive elements of developer.apple.com are broken
+https://bugs.webkit.org/show_bug.cgi?id=143692
+
+Reviewed by Sam Weinig.
+
+* platform/ios-simulator-wk2/scrolling/remove-scrolling-role-expected.txt: Added.
+* platform/ios-simulator-wk2/scrolling/remove-scrolling-role.html: Added.
+
 2015-04-14  Commit Queue  
 
 Unreviewed, rolling out r182794.


Added: trunk/LayoutTests/platform/ios-simulator-wk2/scrolling/remove-scrolling-role-expected.txt (0 => 182799)

--- trunk/LayoutTests/platform/ios-simulator-wk2/scrolling/remove-scrolling-role-expected.txt	(rev 0)
+++ trunk/LayoutTests/platform/ios-simulator-wk2/scrolling/remove-scrolling-role-expected.txt	2015-04-14 17:25:31 UTC (rev 182799)
@@ -0,0 +1,12 @@
+(Frame scrolling node
+  (scrollable area size 800 600)
+  (contents size 800 2513)
+  (children 1
+(Overflow scrolling node
+  (scrollable area size 300 400)
+  (contents size 300 2000)
+  (scrolled contents layer 22)
+)
+  )
+)
+


Added: trunk/LayoutTests/platform/ios-simulator-wk2/scrolling/remove-scrolling-role.html (0 => 182799)

--- trunk/LayoutTests/platform/ios-simulator-wk2/scrolling/remove-scrolling-role.html	(rev 0)
+++ trunk/LayoutTests/platform/ios-simulator-wk2/scrolling/remove-scrolling-role.html	2015-04-14 17:25:31 UTC (rev 182799)
@@ -0,0 +1,63 @@
+
+
+
+
+
+body {
+margin: 0;
+height: 2500px;
+}
+
+#fixed {
+position: fixed;
+left: 10px;
+top: 10px;
+-webkit-overflow-scrolling: touch;
+height: 400px;
+width: 300px;
+overflow: auto;
+border: 4px solid black;
+}
+
+#fixed.changed {
+position: absolute;
+border: 4px solid green;
+}
+
+.content {
+height: 2000px;
+background-color: silver;
+}
+
+
+
+if (window.testRunner) {
+testRunner.waitUntilDone();
+testRunner.dumpAsText();
+}
+
+function doTest()
+{
+window.setTimeout(function() {
+document.getElementById('fixed').classList.add('changed');
+
+if (window.internals)
+document.getElementById('results').innerText = internals.scrollingStateTreeAsText();
+
+if (window.testRunner)
+testRunner.notifyDone();
+
+}, 0);
+}
+
+window.addEventListener('load', doTest, false);
+
+
+
+  
+  
+
+
+  
+
+


Modifi

[webkit-changes] [182798] trunk/Source/WebKit2

[cdumez]

Title: [182798] trunk/Source/WebKit2








Revision 182798
Author cdu...@apple.com
Date 2015-04-14 10:07:11 -0700 (Tue, 14 Apr 2015)


Log Message
REGRESSION(r182603): [GTK] More than 500 crashes on the layout tests with the debug build.
https://bugs.webkit.org/show_bug.cgi?id=143715

Reviewed by Darin Adler.

Enable assertions checking that calling editorState() does not cause a
synchronous layout only on Mac and iOS. This assertion does not
necessarily hold true on other ports as each one as its own
platformEditorState() implementation. In particular, this assertion
was being hit on GTK.

* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::didChangeSelection):

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp




Diff

Modified: trunk/Source/WebKit2/ChangeLog (182797 => 182798)

--- trunk/Source/WebKit2/ChangeLog	2015-04-14 16:13:32 UTC (rev 182797)
+++ trunk/Source/WebKit2/ChangeLog	2015-04-14 17:07:11 UTC (rev 182798)
@@ -1,3 +1,19 @@
+2015-04-14  Chris Dumez  
+
+REGRESSION(r182603): [GTK] More than 500 crashes on the layout tests with the debug build.
+https://bugs.webkit.org/show_bug.cgi?id=143715
+
+Reviewed by Darin Adler.
+
+Enable assertions checking that calling editorState() does not cause a
+synchronous layout only on Mac and iOS. This assertion does not
+necessarily hold true on other ports as each one as its own
+platformEditorState() implementation. In particular, this assertion
+was being hit on GTK.
+
+* WebProcess/WebPage/WebPage.cpp:
+(WebKit::WebPage::didChangeSelection):
+
 2015-04-13  Alexey Proskuryakov  
 
 Build fixes after r182772.


Modified: trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp (182797 => 182798)

--- trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp	2015-04-14 16:13:32 UTC (rev 182797)
+++ trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp	2015-04-14 17:07:11 UTC (rev 182798)
@@ -4400,7 +4400,9 @@
 // trigger a synchronous layout every time the selection changes. sendPostLayoutEditorStateIfNeeded() will be called
 // to send the full editor state after layout is done if we send a partial editor state here.
 auto editorState = this->editorState(needsLayout ? IncludePostLayoutDataHint::No : IncludePostLayoutDataHint::Yes);
+#if PLATFORM(COCOA)
 ASSERT_WITH_MESSAGE(needsLayout == (view && view->needsLayout()), "Calling editorState() should not cause a synchronous layout.");
+#endif
 m_isEditorStateMissingPostLayoutData = editorState.isMissingPostLayoutData;
 
 #if PLATFORM(MAC) && USE(ASYNC_NSTEXTINPUTCLIENT)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [182797] trunk

[commit-queue]

Title: [182797] trunk








Revision 182797
Author commit-qu...@webkit.org
Date 2015-04-14 09:13:32 -0700 (Tue, 14 Apr 2015)


Log Message
Unreviewed, rolling out r182794.
https://bugs.webkit.org/show_bug.cgi?id=143714

readable-stream-templated.html fails on Debug bots (Requested
by youenn on #webkit).

Reverted changeset:

"[Streams API] ReadableStream constructor start function
should be able to close the stream"
https://bugs.webkit.org/show_bug.cgi?id=143363
http://trac.webkit.org/changeset/182794

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/streams/reference-implementation/readable-stream-reader-expected.txt
trunk/LayoutTests/streams/reference-implementation/readable-stream-templated-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/streams/ReadableStream.cpp
trunk/Source/WebCore/Modules/streams/ReadableStream.h
trunk/Source/WebCore/Modules/streams/ReadableStreamReader.cpp
trunk/Source/WebCore/Modules/streams/ReadableStreamReader.h
trunk/Source/WebCore/bindings/js/JSDOMPromise.h
trunk/Source/WebCore/bindings/js/JSReadableStreamReaderCustom.cpp
trunk/Source/WebCore/bindings/js/ReadableStreamJSSource.cpp




Diff

Modified: trunk/LayoutTests/ChangeLog (182796 => 182797)

--- trunk/LayoutTests/ChangeLog	2015-04-14 15:15:35 UTC (rev 182796)
+++ trunk/LayoutTests/ChangeLog	2015-04-14 16:13:32 UTC (rev 182797)
@@ -1,3 +1,18 @@
+2015-04-14  Commit Queue  
+
+Unreviewed, rolling out r182794.
+https://bugs.webkit.org/show_bug.cgi?id=143714
+
+readable-stream-templated.html fails on Debug bots (Requested
+by youenn on #webkit).
+
+Reverted changeset:
+
+"[Streams API] ReadableStream constructor start function
+should be able to close the stream"
+https://bugs.webkit.org/show_bug.cgi?id=143363
+http://trac.webkit.org/changeset/182794
+
 2015-04-14  Xabier Rodriguez Calvar   and Youenn Fablet  
 
 [Streams API] ReadableStream constructor start function should be able to close the stream


Modified: trunk/LayoutTests/streams/reference-implementation/readable-stream-reader-expected.txt (182796 => 182797)

--- trunk/LayoutTests/streams/reference-implementation/readable-stream-reader-expected.txt	2015-04-14 15:15:35 UTC (rev 182796)
+++ trunk/LayoutTests/streams/reference-implementation/readable-stream-reader-expected.txt	2015-04-14 16:13:32 UTC (rev 182797)
@@ -11,7 +11,7 @@
 PASS Constructing a ReadableStreamReader directly should be OK if the stream is errored 
 FAIL Reading from a reader for an empty stream will wait until a chunk is available read is not implemented
 FAIL cancel() on a reader releases the reader before calling through cancel is not implemented
-PASS closed should be fulfilled after stream is closed (.closed access before acquiring) 
+TIMEOUT closed should be fulfilled after stream is closed (.closed access before acquiring) Test timed out
 FAIL closed should be fulfilled after reader releases its lock (multiple stream locks) releaseLock is not implemented
 FAIL Multiple readers can access the stream in sequence read is not implemented
 FAIL Cannot use an already-released reader to unlock a stream again releaseLock is not implemented


Modified: trunk/LayoutTests/streams/reference-implementation/readable-stream-templated-expected.txt (182796 => 182797)

--- trunk/LayoutTests/streams/reference-implementation/readable-stream-templated-expected.txt	2015-04-14 15:15:35 UTC (rev 182796)
+++ trunk/LayoutTests/streams/reference-implementation/readable-stream-templated-expected.txt	2015-04-14 16:13:32 UTC (rev 182797)
@@ -15,10 +15,10 @@
 PASS Running templatedRSClosed with ReadableStream (closed via call in start) 
 FAIL cancel() should return a distinct fulfilled promise each time cancel is not implemented
 PASS getReader() should be OK 
-PASS should be able to acquire multiple readers, since they are all auto-released 
+FAIL should be able to acquire multiple readers, since they are all auto-released ReadableStream is locked
 PASS Running templatedRSClosedReader with ReadableStream (closed via call in start) reader 
 FAIL read() should fulfill with { value: undefined, done: true } read is not implemented
-PASS closed should fulfill with undefined 
+TIMEOUT closed should fulfill with undefined Test timed out
 FAIL cancel() should return a distinct fulfilled promise each time cancel is not implemented
 PASS Running templatedRSClosed with ReadableStream (closed via cancel) 
 FAIL cancel() should return a distinct fulfilled promise each time cancel is not implemented


Modified: trunk/Source/WebCore/ChangeLog (182796 => 182797)

--- trunk/Source/WebCore/ChangeLog	2015-04-14 15:15:35 UTC (rev 182796)
+++ trunk/Source/WebCore/ChangeLog	2015-04-14 16:13:32 UTC (rev 182797)
@@ -1,3 +1,18 @@
+2015-04-14  Commit Queue  
+
+Unreviewed, rolling out r182794.
+https://bugs.webkit.org/show_bug.cgi?id=143714
+
+readable-stream-templated.html fails on Debug bots (Requested

[webkit-changes] [182796] trunk/Source/WebInspectorUI

[nvasilyev]

Title: [182796] trunk/Source/WebInspectorUI








Revision 182796
Author nvasil...@apple.com
Date 2015-04-14 08:15:35 -0700 (Tue, 14 Apr 2015)


Log Message
Web Inspector: Align array's indices and set's bullet points under the property icon
https://bugs.webkit.org/show_bug.cgi?id=143698

Reviewed by Timothy Hatcher.

* UserInterface/Views/ObjectTreeMapEntryTreeElement.css:
(.object-tree-array-index.object-tree-map-entry > .titles > .title > .index-name):
* UserInterface/Views/ObjectTreeArrayIndexTreeElement.css:
(.object-tree-array-index .index-name):
Right align array's and set's indices.

(.object-tree-map-entry):
Overwrite left property from .object-tree-array-index.

(.object-tree-property + ol .object-tree-map-entry):
Overwrite left property from .object-tree-property + ol .object-tree-array-index.

Modified Paths

trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/Views/ObjectTreeArrayIndexTreeElement.css
trunk/Source/WebInspectorUI/UserInterface/Views/ObjectTreeMapEntryTreeElement.css




Diff

Modified: trunk/Source/WebInspectorUI/ChangeLog (182795 => 182796)

--- trunk/Source/WebInspectorUI/ChangeLog	2015-04-14 13:59:36 UTC (rev 182795)
+++ trunk/Source/WebInspectorUI/ChangeLog	2015-04-14 15:15:35 UTC (rev 182796)
@@ -1,3 +1,22 @@
+2015-04-14  Nikita Vasilyev  
+
+Web Inspector: Align array's indices and set's bullet points under the property icon
+https://bugs.webkit.org/show_bug.cgi?id=143698
+
+Reviewed by Timothy Hatcher.
+
+* UserInterface/Views/ObjectTreeMapEntryTreeElement.css:
+(.object-tree-array-index.object-tree-map-entry > .titles > .title > .index-name):
+* UserInterface/Views/ObjectTreeArrayIndexTreeElement.css:
+(.object-tree-array-index .index-name):
+Right align array's and set's indices.
+
+(.object-tree-map-entry):
+Overwrite left property from .object-tree-array-index.
+
+(.object-tree-property + ol .object-tree-map-entry):
+Overwrite left property from .object-tree-property + ol .object-tree-array-index.
+
 2015-04-13  Joseph Pecoraro  
 
 Web Inspector: Expanding window.navigator.mimeTypes in ObjectTree shows no native properties


Modified: trunk/Source/WebInspectorUI/UserInterface/Views/ObjectTreeArrayIndexTreeElement.css (182795 => 182796)

--- trunk/Source/WebInspectorUI/UserInterface/Views/ObjectTreeArrayIndexTreeElement.css	2015-04-14 13:59:36 UTC (rev 182795)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/ObjectTreeArrayIndexTreeElement.css	2015-04-14 15:15:35 UTC (rev 182796)
@@ -45,9 +45,9 @@
 top: -1px;
 
 display: inline-block;
-width: 22px;
-margin-left: 13px;
-text-align: center;
+width: 30px;
+margin-right: 7px;
+text-align: right;
 }
 
 /* An array inside an array we should reduce the padding-start. */


Modified: trunk/Source/WebInspectorUI/UserInterface/Views/ObjectTreeMapEntryTreeElement.css (182795 => 182796)

--- trunk/Source/WebInspectorUI/UserInterface/Views/ObjectTreeMapEntryTreeElement.css	2015-04-14 13:59:36 UTC (rev 182795)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/ObjectTreeMapEntryTreeElement.css	2015-04-14 15:15:35 UTC (rev 182796)
@@ -24,7 +24,7 @@
  */
 
 .object-tree-array-index.object-tree-map-entry > .titles > .title > .index-name {
-width: 37px;
+width: 40px;
 text-align: right;
 margin-right: 5px;
 }
@@ -36,4 +36,9 @@
 .object-tree-map-entry {
 padding-top: 2px;
 padding-bottom: 2px;
+left: -2px;
 }
+
+.object-tree-property + ol .object-tree-map-entry {
+left: -8px;
+}






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [182793] trunk/LayoutTests

[commit-queue]

Title: [182793] trunk/LayoutTests








Revision 182793
Author commit-qu...@webkit.org
Date 2015-04-14 06:10:30 -0700 (Tue, 14 Apr 2015)


Log Message
[GTK] Gardening 14th April
https://bugs.webkit.org/show_bug.cgi?id=143701

Unreviewed.

Patch by Marcos Chavarría Teijeiro  on 2015-04-14

* platform/gtk/TestExpectations:
* platform/gtk/http/tests/w3c/webperf/approved/navigation-timing/html/test_timing_xserver_redirect-expected.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/gtk/TestExpectations
trunk/LayoutTests/platform/gtk/http/tests/w3c/webperf/approved/navigation-timing/html/test_timing_xserver_redirect-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (182792 => 182793)

--- trunk/LayoutTests/ChangeLog	2015-04-14 13:08:23 UTC (rev 182792)
+++ trunk/LayoutTests/ChangeLog	2015-04-14 13:10:30 UTC (rev 182793)
@@ -1,5 +1,15 @@
 2015-04-14  Marcos Chavarría Teijeiro  
 
+[GTK] Gardening 14th April
+https://bugs.webkit.org/show_bug.cgi?id=143701
+
+Unreviewed.
+
+* platform/gtk/TestExpectations:
+* platform/gtk/http/tests/w3c/webperf/approved/navigation-timing/html/test_timing_xserver_redirect-expected.txt:
+
+2015-04-14  Marcos Chavarría Teijeiro  
+
 [GTK] Gardening: Rebaseline tests after r182620
 https://bugs.webkit.org/show_bug.cgi?id=143700
 


Modified: trunk/LayoutTests/platform/gtk/TestExpectations (182792 => 182793)

--- trunk/LayoutTests/platform/gtk/TestExpectations	2015-04-14 13:08:23 UTC (rev 182792)
+++ trunk/LayoutTests/platform/gtk/TestExpectations	2015-04-14 13:10:30 UTC (rev 182793)
@@ -136,7 +136,7 @@
 # Legacy full screen API tests are now obsolete.
 # This passes while it's marked as a WontFix - check it.
 media/media-fullscreen-inline.html [ WontFix Pass ]
-media/media-fullscreen-not-in-document.html [ WontFix Timeout ]
+media/media-fullscreen-not-in-document.html [ WontFix Timeout Crash ]
 
 # Pre-HMTL5 parser quirks only apply to the mac port for now.
 fast/parser/pre-html5-parser-quirks.html [ WontFix Failure ]
@@ -636,6 +636,8 @@
 contentfiltering [ Skip ]
 http/tests/contentfiltering [ Skip ]
 
+webkit.org/b/143703 fast/forms/listbox-visible-size.html [ Failure ]
+
 #
 # End of Expected failures
 #
@@ -710,8 +712,6 @@
 webkit.org/b/105870 [ Debug ] webaudio/audionode-channel-rules.html [ Crash Pass ]
 webkit.org/b/105870 [ Debug ] webaudio/audionode-connect-order.html [ Crash ]
 
-webkit.org/b/133797 fast/dom/NavigatorContentUtils/register-protocol-handler.html [ Crash ]
-
 webkit.org/b/135050 animations/animation-end-event-short-iterations.html [ Crash Pass ]
 
 webkit.org/b/135051 fast/regions/repaint/region-painting-composited-element.html [ Crash Pass ]
@@ -1137,6 +1137,9 @@
 
 webkit.org/b/131545 media/media-event-listeners.html [ Failure Pass ]
 
+webkit.org/b/143702 media/progress-events-generated-correctly.html [ Timeout Crash ]
+webkit.org/b/143704 media/media-source/media-source-append-media-segment-without-init.html [ Failure Pass ]
+
 #
 # End of Flaky tests
 #
@@ -1223,8 +1226,6 @@
 # EventSender::dumpFilenameBeingDragged not implemented.
 webkit.org/b/61826 fast/events/drag-image-filename.html [ Timeout ]
 
-Bug(GTK) media/progress-events-generated-correctly.html [ Timeout ]
-
 webkit.org/b/108925 http/tests/media/video-play-stall.html [ Failure Timeout ]
 
 webkit.org/b/114789 fast/events/page-visibility-transition-test.html [ Timeout ]
@@ -1278,7 +1279,7 @@
 
 webkit.org/b/132128 fast/text/international/embed-bidi-style-in-isolate-crash.html [ Timeout Pass ]
 
-webkit.org/b/132266 js/slow-stress/emscripten-memops.html [ Timeout ]
+webkit.org/b/132266 js/slow-stress/emscripten-memops.html [ Timeout Pass ]
 
 webkit.org/b/133148 accessibility/content-editable-as-textarea.html [ Crash Timeout ]
 webkit.org/b/133148 accessibility/content-editable-set-inner-text-generates-axvalue-notification.html [ Timeout ]
@@ -1327,12 +1328,17 @@
 webkit.org/b/142490 inspector/css/selector-dynamic-specificity.html [ Timeout ]
 webkit.org/b/142491 media/media-source/media-source-stalled-holds-sleep-assertion.html [ Timeout ]
 
-webkit.org/b/142820 fast/images/animated-gif-body-outside-viewport.html [ Timeout ]
+webkit.org/b/142820 fast/images/animated-gif-body-outside-viewport.html [ Timeout Pass ]
 webkit.org/b/142491 media/click-volume-bar-not-pausing.html [ Timeout ]
 webkit.org/b/143473 editing/pasteboard/drag-and-drop-attachment-contenteditable.html [ Timeout ]
 
 webkit.org/b/143477 fast/writing-mode/broken-ideograph-small-caps.html [ Timeout Pass ]
 
+webkit.org/b/143706 media/media-source/media-source-end-of-stream-readyState.html [ T

[webkit-changes] [182792] trunk/LayoutTests

[commit-queue]

Title: [182792] trunk/LayoutTests








Revision 182792
Author commit-qu...@webkit.org
Date 2015-04-14 06:08:23 -0700 (Tue, 14 Apr 2015)


Log Message
[GTK] Gardening: Rebaseline tests after r182620
https://bugs.webkit.org/show_bug.cgi?id=143700

Unreviewed.

This revision updates some tests after changing the way  is
rendered. We need to change the GTK+ expectations for these tests.

Patch by Marcos Chavarría Teijeiro  on 2015-04-14

* platform/gtk/fast/css/text-overflow-ellipsis-bidi-expected.txt:
* platform/gtk/fast/dom/focus-contenteditable-expected.txt:
* platform/gtk/fast/forms/listbox-hit-test-zoomed-expected.png:
* platform/gtk/fast/forms/listbox-hit-test-zoomed-expected.txt:
* platform/gtk/fast/forms/range/slider-padding-expected.txt:
* platform/gtk/fast/forms/textarea-scroll-height-expected.txt:
* platform/gtk/fast/parser/open-comment-in-textarea-expected.txt:
* platform/gtk/fast/text/international/bidi-layout-across-linebreak-expected.txt:
* platform/gtk/http/tests/navigation/_javascript_link-frames-expected.txt:
* platform/gtk/http/tests/navigation/postredirect-basic-expected.txt:
* platform/gtk/http/tests/navigation/postredirect-goback1-expected.txt:
* platform/gtk/svg/wicd/test-rightsizing-b-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug106795-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug1224-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug131020-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug131020_iframe-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug1430-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug16252-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug19599-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug20579-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug32205-3-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug82946-2-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug92143-expected.txt:
* platform/gtk/tables/mozilla/marvin/tables_cellpadding-expected.txt:
* platform/gtk/tables/mozilla/marvin/tables_cellspacing-expected.txt:
* platform/gtk/tables/mozilla/other/wa_table_thtd_rowspan-expected.txt:
* platform/gtk/tables/mozilla_expected_failures/bugs/bug1262-expected.txt:
* platform/gtk/tables/mozilla_expected_failures/bugs/bug56024-expected.txt:
* platform/gtk/tables/mozilla_expected_failures/other/test4-expected.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/gtk/fast/css/text-overflow-ellipsis-bidi-expected.txt
trunk/LayoutTests/platform/gtk/fast/dom/focus-contenteditable-expected.txt
trunk/LayoutTests/platform/gtk/fast/forms/listbox-hit-test-zoomed-expected.png
trunk/LayoutTests/platform/gtk/fast/forms/listbox-hit-test-zoomed-expected.txt
trunk/LayoutTests/platform/gtk/fast/forms/range/slider-padding-expected.txt
trunk/LayoutTests/platform/gtk/fast/forms/textarea-scroll-height-expected.txt
trunk/LayoutTests/platform/gtk/fast/parser/open-comment-in-textarea-expected.txt
trunk/LayoutTests/platform/gtk/fast/text/international/bidi-layout-across-linebreak-expected.txt
trunk/LayoutTests/platform/gtk/http/tests/navigation/_javascript_link-frames-expected.txt
trunk/LayoutTests/platform/gtk/http/tests/navigation/postredirect-basic-expected.txt
trunk/LayoutTests/platform/gtk/http/tests/navigation/postredirect-goback1-expected.txt
trunk/LayoutTests/platform/gtk/svg/wicd/test-rightsizing-b-expected.txt
trunk/LayoutTests/platform/gtk/tables/mozilla/bugs/bug106795-expected.txt
trunk/LayoutTests/platform/gtk/tables/mozilla/bugs/bug1224-expected.txt
trunk/LayoutTests/platform/gtk/tables/mozilla/bugs/bug131020-expected.txt
trunk/LayoutTests/platform/gtk/tables/mozilla/bugs/bug131020_iframe-expected.txt
trunk/LayoutTests/platform/gtk/tables/mozilla/bugs/bug1430-expected.txt
trunk/LayoutTests/platform/gtk/tables/mozilla/bugs/bug16252-expected.txt
trunk/LayoutTests/platform/gtk/tables/mozilla/bugs/bug19599-expected.txt
trunk/LayoutTests/platform/gtk/tables/mozilla/bugs/bug20579-expected.txt
trunk/LayoutTests/platform/gtk/tables/mozilla/bugs/bug32205-3-expected.txt
trunk/LayoutTests/platform/gtk/tables/mozilla/bugs/bug82946-2-expected.txt
trunk/LayoutTests/platform/gtk/tables/mozilla/bugs/bug92143-expected.txt
trunk/LayoutTests/platform/gtk/tables/mozilla/marvin/tables_cellpadding-expected.txt
trunk/LayoutTests/platform/gtk/tables/mozilla/marvin/tables_cellspacing-expected.txt
trunk/LayoutTests/platform/gtk/tables/mozilla/other/wa_table_thtd_rowspan-expected.txt
trunk/LayoutTests/platform/gtk/tables/mozilla_expected_failures/bugs/bug1262-expected.txt
trunk/LayoutTests/platform/gtk/tables/mozilla_expected_failures/bugs/bug56024-expected.txt
trunk/LayoutTests/platform/gtk/tables/mozilla_expected_failures/other/test4-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (182791 => 182792)

--- trunk/LayoutTests/ChangeLog	2015-04-14 11:27:44 UTC (rev 182791)
+++ trunk/LayoutTests/ChangeLog	2015-04-14 13:08:23 UTC (rev 182792)
@@ -1,3 +1,43 @@
+2015-04-14  Marcos Chavarría Teijeiro  
+
+[GTK] Gardening: Rebaseline t

[webkit-changes] [182791] trunk/Tools

[dominik . rottsches]

Title: [182791] trunk/Tools








Revision 182791
Author dominik.rottsc...@intel.com
Date 2015-04-14 04:27:44 -0700 (Tue, 14 Apr 2015)


Log Message
Remove myself from watchlist, remove empty Cairo and HarfBuzz watchlists
https://bugs.webkit.org/show_bug.cgi?id=143705

Unreviewed change to watchlist file.


* Scripts/webkitpy/common/config/watchlist:

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/common/config/watchlist




Diff

Modified: trunk/Tools/ChangeLog (182790 => 182791)

--- trunk/Tools/ChangeLog	2015-04-14 11:01:09 UTC (rev 182790)
+++ trunk/Tools/ChangeLog	2015-04-14 11:27:44 UTC (rev 182791)
@@ -1,3 +1,12 @@
+2015-04-14  Dominik Röttsches  
+
+Remove myself from watchlist, remove empty Cairo and HarfBuzz watchlists
+https://bugs.webkit.org/show_bug.cgi?id=143705
+
+Unreviewed change to watchlist file.
+
+* Scripts/webkitpy/common/config/watchlist:
+
 2015-04-14  KwangHyuk Kim  
 
 [EFL] favicon wasn't updated for google.com sometimes.


Modified: trunk/Tools/Scripts/webkitpy/common/config/watchlist (182790 => 182791)

--- trunk/Tools/Scripts/webkitpy/common/config/watchlist	2015-04-14 11:01:09 UTC (rev 182790)
+++ trunk/Tools/Scripts/webkitpy/common/config/watchlist	2015-04-14 11:27:44 UTC (rev 182791)
@@ -222,12 +222,6 @@
 "filename": r"Source/WebCore/accessibility"
 r"|LayoutTests/.*accessibility",
 },
-"Cairo": {
-"filename": r"Source/WebCore/platform/graphics/cairo",
-},
-"Harfbuzz": {
-"filename": r"Source/WebCore/platform/graphics/harfbuzz",
-},
 "PerformanceTests": {
 "filename": r"PerformanceTests"
 r"|Tools/Scripts/webkitpy/performance_tests",
@@ -334,7 +328,6 @@
 "AppleMacPublicApi": [ "timo...@apple.com" ],
 "Battery": [ "gyuyoung@webkit.org", "dch...@gmail.com" ],
 "BindingsScripts": [ "dch...@gmail.com", "cgar...@igalia.com" ],
-"Cairo": [ "dominik.rottsc...@intel.com" ],
 "CMake": [ "rak...@webkit.org", "gyuyoung@webkit.org", "ryuan.c...@gmail.com", "sergio.corr...@openbossa.org" ],
 "CoordinatedGraphics" : [ "n...@webkit.org", "z...@webkit.org", "cmarc...@webkit.org", "l...@webkit.org", "ryuan.c...@gmail.com", "sergio.corr...@openbossa.org", "gyuyoung@webkit.org" ],
 "ConsoleUsage" : [ "mk...@chromium.org" ],
@@ -357,7 +350,6 @@
 "GStreamerGraphics": [ "ale...@webkit.org", "pnorm...@igalia.com", "g...@gnome.org", "mrobin...@webkit.org", "cgar...@igalia.com", "calva...@igalia.com", "vjaq...@igalia.com", "ago...@igalia.com" ],
 "GStreamerAudio": [ "pnorm...@igalia.com", "dch...@gmail.com", "sergio.corr...@openbossa.org", "calva...@igalia.com", "vjaq...@igalia.com", "ago...@igalia.com" ],
 "GtkWebKit2PublicAPI": [ "cgar...@igalia.com", "g...@gnome.org", "mrobin...@webkit.org", "be...@igalia.com" ],
-"Harfbuzz": [ "dominik.rottsc...@intel.com" ],
 "HTML": [ "esprehn+aut...@chromium.org", "gyuyoung@webkit.org" ],
 "IndexedDB": [ "alecfl...@chromium.org", "jsb...@chromium.org" ],
 "Loader": [ "jap...@chromium.org" ],
@@ -373,7 +365,7 @@
 "RegionsDevelopment|RegionsExpectationsMore|RegionsExpectationsLess|RegionsUsage": [ "webkitbugtrac...@adobe.com" ],
 "Rendering": [ "esprehn+aut...@chromium.org", "gl...@skynav.com", "kondapallykal...@gmail.com" ],
 "RenderLayers" : [ "simon.fra...@apple.com", "kondapallykal...@gmail.com" ],
-"SVG": ["schen...@chromium.org", "p...@google.com", "fmal...@chromium.org", "dominik.rottsc...@intel.com", "gyuyoung@webkit.org", "sergio.corr...@openbossa.org" ],
+"SVG": ["schen...@chromium.org", "p...@google.com", "fmal...@chromium.org", "gyuyoung@webkit.org", "sergio.corr...@openbossa.org" ],
 "SVNScripts": [ "dba...@webkit.org" ],
 "ScrollingCoordinator": [ "jam...@chromium.org", "toniki...@webkit.org", "cmarc...@webkit.org", "l...@webkit.org" ],
 "Selectors": [ "allan.jen...@digia.com" ],






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [182789] releases/WebKitGTK/webkit-2.8.1/

[carlosgc]

Title: [182789] releases/WebKitGTK/webkit-2.8.1/








Revision 182789
Author carlo...@webkit.org
Date 2015-04-14 03:21:14 -0700 (Tue, 14 Apr 2015)


Log Message
WebKitGTK+ 2.8.1

Added Paths

releases/WebKitGTK/webkit-2.8.1/




Diff

Property changes: releases/WebKitGTK/webkit-2.8.1



Added: svn:ignore
depcomp
compile
config.guess
GNUmakefile.in
config.sub
ltmain.sh
aconfig.h.in
autom4te.cache
missing
aclocal.m4
install-sh
autotoolsconfig.h.in
INSTALL
README
gtk-doc.make
out
Makefile.chromium
WebKitSupportLibrary.zip
WebKitBuild

Added: svn:mergeinfo




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [182788] releases/WebKitGTK/webkit-2.8

[carlosgc]

Title: [182788] releases/WebKitGTK/webkit-2.8








Revision 182788
Author carlo...@webkit.org
Date 2015-04-14 03:20:30 -0700 (Tue, 14 Apr 2015)


Log Message
Unreviewed. Update OptionsGTK.cmake and NEWS for 2.8.1 release.

.:

* Source/cmake/OptionsGTK.cmake: Bump version numbers.

Source/WebKit2:

* gtk/NEWS: Add release notes for 2.8.1.

Modified Paths

releases/WebKitGTK/webkit-2.8/ChangeLog
releases/WebKitGTK/webkit-2.8/Source/WebKit2/ChangeLog
releases/WebKitGTK/webkit-2.8/Source/WebKit2/gtk/NEWS
releases/WebKitGTK/webkit-2.8/Source/cmake/OptionsGTK.cmake




Diff

Modified: releases/WebKitGTK/webkit-2.8/ChangeLog (182787 => 182788)

--- releases/WebKitGTK/webkit-2.8/ChangeLog	2015-04-14 09:01:50 UTC (rev 182787)
+++ releases/WebKitGTK/webkit-2.8/ChangeLog	2015-04-14 10:20:30 UTC (rev 182788)
@@ -1,3 +1,9 @@
+2015-04-14  Carlos Garcia Campos  
+
+Unreviewed. Update OptionsGTK.cmake and NEWS for 2.8.1 release.
+
+* Source/cmake/OptionsGTK.cmake: Bump version numbers.
+
 2015-04-06  Alberto Garcia  
 
 [GTK] Fix HPPA build


Modified: releases/WebKitGTK/webkit-2.8/Source/WebKit2/ChangeLog (182787 => 182788)

--- releases/WebKitGTK/webkit-2.8/Source/WebKit2/ChangeLog	2015-04-14 09:01:50 UTC (rev 182787)
+++ releases/WebKitGTK/webkit-2.8/Source/WebKit2/ChangeLog	2015-04-14 10:20:30 UTC (rev 182788)
@@ -1,3 +1,9 @@
+2015-04-14  Carlos Garcia Campos  
+
+Unreviewed. Update OptionsGTK.cmake and NEWS for 2.8.1 release.
+
+* gtk/NEWS: Add release notes for 2.8.1.
+
 2015-04-12  Sungmann Cho  
 
 Remove PluginModuleInfo.cpp from WebKit2


Modified: releases/WebKitGTK/webkit-2.8/Source/WebKit2/gtk/NEWS (182787 => 182788)

--- releases/WebKitGTK/webkit-2.8/Source/WebKit2/gtk/NEWS	2015-04-14 09:01:50 UTC (rev 182787)
+++ releases/WebKitGTK/webkit-2.8/Source/WebKit2/gtk/NEWS	2015-04-14 10:20:30 UTC (rev 182788)
@@ -1,4 +1,18 @@
 =
+WebKitGTK+  2.8.1
+=
+
+What's new in WebKitGTK+ 2.8.1?
+
+  - Handle keep-alive connections in GStreamer HTTP source element.
+  - Fix a crash in DOMObjectCache when a wrapped object owned by the cache is
+unreffed by the user.
+  - Fix rendering of drag and drop icon.
+  - Fix the build with REDIRECTED_XCOMPOSITE_WINDOW disabled in X11 platform.
+  - Fix the build with Wayland target enabled.
+  - Fix the build for HPPA.
+
+=
 WebKitGTK+  2.8.0
 =
 


Modified: releases/WebKitGTK/webkit-2.8/Source/cmake/OptionsGTK.cmake (182787 => 182788)

--- releases/WebKitGTK/webkit-2.8/Source/cmake/OptionsGTK.cmake	2015-04-14 09:01:50 UTC (rev 182787)
+++ releases/WebKitGTK/webkit-2.8/Source/cmake/OptionsGTK.cmake	2015-04-14 10:20:30 UTC (rev 182788)
@@ -2,14 +2,14 @@
 
 set(PROJECT_VERSION_MAJOR 2)
 set(PROJECT_VERSION_MINOR 8)
-set(PROJECT_VERSION_MICRO 0)
+set(PROJECT_VERSION_MICRO 1)
 set(PROJECT_VERSION ${PROJECT_VERSION_MAJOR}.${PROJECT_VERSION_MINOR}.${PROJECT_VERSION_MICRO})
 set(WEBKITGTK_API_VERSION 4.0)
 
 # Libtool library version, not to be confused with API version.
 # See http://www.gnu.org/software/libtool/manual/html_node/Libtool-versioning.html
-CALCULATE_LIBRARY_VERSIONS_FROM_LIBTOOL_TRIPLE(WEBKIT2 43 3 6)
-CALCULATE_LIBRARY_VERSIONS_FROM_LIBTOOL_TRIPLE(_javascript_CORE 19 7 1)
+CALCULATE_LIBRARY_VERSIONS_FROM_LIBTOOL_TRIPLE(WEBKIT2 43 4 6)
+CALCULATE_LIBRARY_VERSIONS_FROM_LIBTOOL_TRIPLE(_javascript_CORE 19 8 1)
 
 set(ENABLE_CREDENTIAL_STORAGE ON CACHE BOOL "Whether or not to enable support for credential storage using libsecret.")
 set(ENABLE_GTKDOC OFF CACHE BOOL "Whether or not to use generate gtkdoc.")






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [182787] releases/WebKitGTK/webkit-2.8/Source/WebCore

[carlosgc]

Title: [182787] releases/WebKitGTK/webkit-2.8/Source/WebCore








Revision 182787
Author carlo...@webkit.org
Date 2015-04-14 02:01:50 -0700 (Tue, 14 Apr 2015)


Log Message
Merge r182773 - Regression: Scrolling on popsci.com spends too much time in FrameView::viewportsContentsChanged()
https://bugs.webkit.org/show_bug.cgi?id=143675

Reviewed by Simon Fraser.

Optimize resumeVisibleImageAnimationsIncludingSubframes() so that the FrameViews'
windowClipRect gets computed less often:
- Cache the FrameView's windowClipRect before resuming image animations in subframes
  as calling windowClipRect() on those subframes' view is going to call windowClipRect()
  on their ancestors. This avoids a lot of unnecessary windowClipRect recomputations
  in deep frame trees.
- Stop traversing the Frame tree if the current frame does not have a content
  renderer, as this means the subframes won't have one either.
- Stop traversing the Frame tree if the current frame's view has an empty
  windowClipRect() as this means the windowClipRect will be empty for those
  subframes as well.

On popsci.com, this cuts down the number of uncached windowClipRect() calls by
approximately half. I see viewportsContentsChanged() at ~0.4% when scrolling
on popsci.com after this change.

* page/FrameView.cpp:
(WebCore::FrameView::resumeVisibleImageAnimationsIncludingSubframes):
(WebCore::FrameView::windowClipRect):
* page/FrameView.h:
* rendering/RenderView.cpp:
(WebCore::RenderView::resumePausedImageAnimationsIfNeeded):
* rendering/RenderView.h:

Modified Paths

releases/WebKitGTK/webkit-2.8/Source/WebCore/ChangeLog
releases/WebKitGTK/webkit-2.8/Source/WebCore/page/FrameView.cpp
releases/WebKitGTK/webkit-2.8/Source/WebCore/page/FrameView.h
releases/WebKitGTK/webkit-2.8/Source/WebCore/rendering/RenderView.cpp
releases/WebKitGTK/webkit-2.8/Source/WebCore/rendering/RenderView.h




Diff

Modified: releases/WebKitGTK/webkit-2.8/Source/WebCore/ChangeLog (182786 => 182787)

--- releases/WebKitGTK/webkit-2.8/Source/WebCore/ChangeLog	2015-04-14 08:40:07 UTC (rev 182786)
+++ releases/WebKitGTK/webkit-2.8/Source/WebCore/ChangeLog	2015-04-14 09:01:50 UTC (rev 182787)
@@ -1,3 +1,34 @@
+2015-04-13  Chris Dumez  
+
+Regression: Scrolling on popsci.com spends too much time in FrameView::viewportsContentsChanged()
+https://bugs.webkit.org/show_bug.cgi?id=143675
+
+Reviewed by Simon Fraser.
+
+Optimize resumeVisibleImageAnimationsIncludingSubframes() so that the FrameViews'
+windowClipRect gets computed less often:
+- Cache the FrameView's windowClipRect before resuming image animations in subframes
+  as calling windowClipRect() on those subframes' view is going to call windowClipRect()
+  on their ancestors. This avoids a lot of unnecessary windowClipRect recomputations
+  in deep frame trees.
+- Stop traversing the Frame tree if the current frame does not have a content
+  renderer, as this means the subframes won't have one either.
+- Stop traversing the Frame tree if the current frame's view has an empty
+  windowClipRect() as this means the windowClipRect will be empty for those
+  subframes as well.
+
+On popsci.com, this cuts down the number of uncached windowClipRect() calls by
+approximately half. I see viewportsContentsChanged() at ~0.4% when scrolling
+on popsci.com after this change.
+
+* page/FrameView.cpp:
+(WebCore::FrameView::resumeVisibleImageAnimationsIncludingSubframes):
+(WebCore::FrameView::windowClipRect):
+* page/FrameView.h:
+* rendering/RenderView.cpp:
+(WebCore::RenderView::resumePausedImageAnimationsIfNeeded):
+* rendering/RenderView.h:
+
 2015-04-13  Said Abou-Hallawa  
 
 Canvas drawImage() has a security hole when the image isn't yet fully loaded.


Modified: releases/WebKitGTK/webkit-2.8/Source/WebCore/page/FrameView.cpp (182786 => 182787)

--- releases/WebKitGTK/webkit-2.8/Source/WebCore/page/FrameView.cpp	2015-04-14 08:40:07 UTC (rev 182786)
+++ releases/WebKitGTK/webkit-2.8/Source/WebCore/page/FrameView.cpp	2015-04-14 09:01:50 UTC (rev 182787)
@@ -2140,10 +2140,23 @@
 
 void FrameView::resumeVisibleImageAnimationsIncludingSubframes()
 {
-// A change in scroll position may affect image visibility in subframes.
-for (auto* frame = m_frame.get(); frame; frame = frame->tree().traverseNext(m_frame.get())) {
-if (auto* renderView = frame->contentRenderer())
-renderView->resumePausedImageAnimationsIfNeeded();
+auto* renderView = frame().contentRenderer();
+if (!renderView)
+return;
+
+IntRect windowClipRect = this->windowClipRect();
+auto visibleRect = windowToContents(windowClipRect);
+if (visibleRect.isEmpty())
+return;
+
+// Resume paused image animations in this frame.
+renderView->resumePausedImageAnimationsIfNeeded(visibleRect);
+
+// Recursive call for

[webkit-changes] [182786] releases/WebKitGTK/webkit-2.8

[carlosgc]

Title: [182786] releases/WebKitGTK/webkit-2.8








Revision 182786
Author carlo...@webkit.org
Date 2015-04-14 01:40:07 -0700 (Tue, 14 Apr 2015)


Log Message
Merge r182750 - Canvas drawImage() has a security hole when the image isn't yet fully loaded.
https://bugs.webkit.org/show_bug.cgi?id=58681.

Reviewed by Darin Adler.

Source/WebCore:

There is a race condition which may happen if an image from a different
origin is drawn on a canvas before it finishes loading. The check to taint
the canvas comes before drawing it. This check returns false if the image
is not completely loaded because we check the URL of the resource response.
If after this check and before the drawing, the image finishes loading, the
canvas will not be tainted but the image will be drawn.

The fix is to move the check to taint the canvas after drawing the image.
The only problem with this solution is basically the opposite of this bug:
we will become stricter than before with images which are from a different
origin and before they finish loading. The image has not finished loading,
so we do not draw it. Before we check for tainting, the image finishes
loading. So we decide to taint the canvas even the image is not drawn.

But this should not be a security issue anymore. I personally do not know
if it is even a correctness issue or not.

Test: http/tests/canvas/canvas-tainted-after-draw-image.html

* html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::drawImage):

LayoutTests:

This test confirms when we load an image from a different origin and try
drawing it on a canvas, the canvas is tainted if the image is completely
loaded and drawn. Otherwise the image is not drawn.

* http/tests/canvas/canvas-tainted-after-draw-image-expected.txt: Added.
* http/tests/canvas/canvas-tainted-after-draw-image.html: Added.
* http/tests/canvas/resources: Added.
* http/tests/canvas/resources/100x100-lime-rect.svg: Added.

Modified Paths

releases/WebKitGTK/webkit-2.8/LayoutTests/ChangeLog
releases/WebKitGTK/webkit-2.8/Source/WebCore/ChangeLog
releases/WebKitGTK/webkit-2.8/Source/WebCore/html/canvas/CanvasRenderingContext2D.cpp


Added Paths

releases/WebKitGTK/webkit-2.8/LayoutTests/http/tests/canvas/canvas-tainted-after-draw-image-expected.txt
releases/WebKitGTK/webkit-2.8/LayoutTests/http/tests/canvas/canvas-tainted-after-draw-image.html
releases/WebKitGTK/webkit-2.8/LayoutTests/http/tests/canvas/resources/
releases/WebKitGTK/webkit-2.8/LayoutTests/http/tests/canvas/resources/100x100-lime-rect.svg




Diff

Modified: releases/WebKitGTK/webkit-2.8/LayoutTests/ChangeLog (182785 => 182786)

--- releases/WebKitGTK/webkit-2.8/LayoutTests/ChangeLog	2015-04-14 08:37:03 UTC (rev 182785)
+++ releases/WebKitGTK/webkit-2.8/LayoutTests/ChangeLog	2015-04-14 08:40:07 UTC (rev 182786)
@@ -1,3 +1,33 @@
+2015-04-13  Said Abou-Hallawa  
+
+Fix LayoutTests/http/tests/canvas/canvas-tainted-after-draw-image.html on all bots
+following http://trac.webkit.org/changeset/182750.
+
+Reviewed by Daniel Bates.
+
+* http/tests/canvas/canvas-tainted-after-draw-image-expected.txt:
+* http/tests/canvas/canvas-tainted-after-draw-image.html:
+Set window.jsTestIsAsync true and call finishJSTest() to make the test 
+asynchronous, so the "TEST COMPLETE" message will be output after all the
+test messages. Also delete the synchronous tests for data url image and
+same-domain image since they can't be reliably tested.
+
+2015-04-13  Said Abou-Hallawa  
+
+Canvas drawImage() has a security hole when the image isn't yet fully loaded.
+https://bugs.webkit.org/show_bug.cgi?id=58681.
+
+Reviewed by Darin Adler.
+
+This test confirms when we load an image from a different origin and try
+drawing it on a canvas, the canvas is tainted if the image is completely
+loaded and drawn. Otherwise the image is not drawn.
+
+* http/tests/canvas/canvas-tainted-after-draw-image-expected.txt: Added.
+* http/tests/canvas/canvas-tainted-after-draw-image.html: Added.
+* http/tests/canvas/resources: Added.
+* http/tests/canvas/resources/100x100-lime-rect.svg: Added.
+
 2015-04-13  Simon Fraser  
 
 Fixed position element is truncated if moved onscreen by a transform


Added: releases/WebKitGTK/webkit-2.8/LayoutTests/http/tests/canvas/canvas-tainted-after-draw-image-expected.txt (0 => 182786)

--- releases/WebKitGTK/webkit-2.8/LayoutTests/http/tests/canvas/canvas-tainted-after-draw-image-expected.txt	(rev 0)
+++ releases/WebKitGTK/webkit-2.8/LayoutTests/http/tests/canvas/canvas-tainted-after-draw-image-expected.txt	2015-04-14 08:40:07 UTC (rev 182786)
@@ -0,0 +1,9 @@
+CONSOLE MESSAGE: line 58: Unable to get image data from canvas because the canvas has been tainted by cross-origin data.
+Tainting works correctly.
+Tainting works correctly.
+Tainting works correctly.
+Tainting works correctly.
+PASS suc

[webkit-changes] [182785] releases/WebKitGTK/webkit-2.8

[carlosgc]

Title: [182785] releases/WebKitGTK/webkit-2.8








Revision 182785
Author carlo...@webkit.org
Date 2015-04-14 01:37:03 -0700 (Tue, 14 Apr 2015)


Log Message
Merge r182743 - Fixed position element is truncated if moved onscreen by a transform
https://bugs.webkit.org/show_bug.cgi?id=143655
Source/WebCore:

rdar://problem/15020044

Reviewed by Darin Adler.

Our "don't do layout if transform changes" code was too aggressive.
If an element changes between having a transform and not having one, we
really need to do a layout since so much else depends on transforms. In
this particular case, we clip position:fixed elements to the viewport if
they are not transformed, and were failing to re-evaluate this when a
transform was added. Doing a layout fixes this.

Test: compositing/geometry/fixed-transformed.html

* rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::changeRequiresLayout):
* rendering/style/StyleTransformData.h:
(WebCore::StyleTransformData::hasTransform):

LayoutTests:

Reviewed by Darin Adler.

Test that moves a position:fixed element on-screen using a transform.

* compositing/geometry/fixed-transformed.html: Added.

Modified Paths

releases/WebKitGTK/webkit-2.8/LayoutTests/ChangeLog
releases/WebKitGTK/webkit-2.8/Source/WebCore/ChangeLog
releases/WebKitGTK/webkit-2.8/Source/WebCore/rendering/style/RenderStyle.cpp
releases/WebKitGTK/webkit-2.8/Source/WebCore/rendering/style/StyleTransformData.h


Added Paths

releases/WebKitGTK/webkit-2.8/LayoutTests/compositing/geometry/fixed-transformed.html




Diff

Modified: releases/WebKitGTK/webkit-2.8/LayoutTests/ChangeLog (182784 => 182785)

--- releases/WebKitGTK/webkit-2.8/LayoutTests/ChangeLog	2015-04-14 08:27:45 UTC (rev 182784)
+++ releases/WebKitGTK/webkit-2.8/LayoutTests/ChangeLog	2015-04-14 08:37:03 UTC (rev 182785)
@@ -1,3 +1,14 @@
+2015-04-13  Simon Fraser  
+
+Fixed position element is truncated if moved onscreen by a transform
+https://bugs.webkit.org/show_bug.cgi?id=143655
+
+Reviewed by Darin Adler.
+
+Test that moves a position:fixed element on-screen using a transform.
+
+* compositing/geometry/fixed-transformed.html: Added.
+
 2015-04-12  Simon Fraser  
 
 Selects don't scroll at some aspect ratios


Added: releases/WebKitGTK/webkit-2.8/LayoutTests/compositing/geometry/fixed-transformed.html (0 => 182785)

--- releases/WebKitGTK/webkit-2.8/LayoutTests/compositing/geometry/fixed-transformed.html	(rev 0)
+++ releases/WebKitGTK/webkit-2.8/LayoutTests/compositing/geometry/fixed-transformed.html	2015-04-14 08:37:03 UTC (rev 182785)
@@ -0,0 +1,40 @@
+
+
+
+
+
+#slider {
+position: fixed;
+top: 100px;
+left: -100px;
+width: 200px;
+height: 100px;
+background-color: blue;
+border: 10px solid gray;
+}
+#slider.out {
+-webkit-transform: translateX(100px);
+}
+
+
+if (window.testRunner) {
+testRunner.dumpAsText();
+testRunner.waitUntilDone();
+}
+window.addEventListener('load', function() {
+window.setTimeout(function() {
+document.getElementById('slider').classList.add('out');
+if (window.testRunner) {
+document.getElementById('layertree').innerText = window.internals.layerTreeAsText(document);
+testRunner.notifyDone();
+}
+}, 0);
+}, false);
+
+
+
+
+
+
+
+


Modified: releases/WebKitGTK/webkit-2.8/Source/WebCore/ChangeLog (182784 => 182785)

--- releases/WebKitGTK/webkit-2.8/Source/WebCore/ChangeLog	2015-04-14 08:27:45 UTC (rev 182784)
+++ releases/WebKitGTK/webkit-2.8/Source/WebCore/ChangeLog	2015-04-14 08:37:03 UTC (rev 182785)
@@ -1,3 +1,25 @@
+2015-04-13  Simon Fraser  
+
+Fixed position element is truncated if moved onscreen by a transform
+https://bugs.webkit.org/show_bug.cgi?id=143655
+rdar://problem/15020044
+
+Reviewed by Darin Adler.
+
+Our "don't do layout if transform changes" code was too aggressive.
+If an element changes between having a transform and not having one, we
+really need to do a layout since so much else depends on transforms. In
+this particular case, we clip position:fixed elements to the viewport if
+they are not transformed, and were failing to re-evaluate this when a
+transform was added. Doing a layout fixes this.
+
+Test: compositing/geometry/fixed-transformed.html
+
+* rendering/style/RenderStyle.cpp:
+(WebCore::RenderStyle::changeRequiresLayout):
+* rendering/style/StyleTransformData.h:
+(WebCore::StyleTransformData::hasTransform):
+
 2015-04-13  Darin Adler  
 
 Remove needless recreation of URL in NavigationScheduler::scheduleLocationChange


Modified: releases/WebKitGTK/webkit-2

[webkit-changes] [182784] releases/WebKitGTK/webkit-2.8/Source/WebCore

[carlosgc]

Title: [182784] releases/WebKitGTK/webkit-2.8/Source/WebCore








Revision 182784
Author carlo...@webkit.org
Date 2015-04-14 01:27:45 -0700 (Tue, 14 Apr 2015)


Log Message
Merge r182734 - Remove needless recreation of URL in NavigationScheduler::scheduleLocationChange
https://bugs.webkit.org/show_bug.cgi?id=143662

Reviewed by Sam Weinig.

* loader/NavigationScheduler.cpp:
(WebCore::NavigationScheduler::scheduleLocationChange): Removed unnecessary code
to convert a URL to a String and then back into a URL.

Modified Paths

releases/WebKitGTK/webkit-2.8/Source/WebCore/ChangeLog
releases/WebKitGTK/webkit-2.8/Source/WebCore/loader/NavigationScheduler.cpp




Diff

Modified: releases/WebKitGTK/webkit-2.8/Source/WebCore/ChangeLog (182783 => 182784)

--- releases/WebKitGTK/webkit-2.8/Source/WebCore/ChangeLog	2015-04-14 08:20:40 UTC (rev 182783)
+++ releases/WebKitGTK/webkit-2.8/Source/WebCore/ChangeLog	2015-04-14 08:27:45 UTC (rev 182784)
@@ -1,3 +1,14 @@
+2015-04-13  Darin Adler  
+
+Remove needless recreation of URL in NavigationScheduler::scheduleLocationChange
+https://bugs.webkit.org/show_bug.cgi?id=143662
+
+Reviewed by Sam Weinig.
+
+* loader/NavigationScheduler.cpp:
+(WebCore::NavigationScheduler::scheduleLocationChange): Removed unnecessary code
+to convert a URL to a String and then back into a URL.
+
 2015-04-12  Simon Fraser  
 
 Selects don't scroll at some aspect ratios


Modified: releases/WebKitGTK/webkit-2.8/Source/WebCore/loader/NavigationScheduler.cpp (182783 => 182784)

--- releases/WebKitGTK/webkit-2.8/Source/WebCore/loader/NavigationScheduler.cpp	2015-04-14 08:20:40 UTC (rev 182783)
+++ releases/WebKitGTK/webkit-2.8/Source/WebCore/loader/NavigationScheduler.cpp	2015-04-14 08:27:45 UTC (rev 182784)
@@ -366,8 +366,7 @@
 
 // If the URL we're going to navigate to is the same as the current one, except for the
 // fragment part, we don't need to schedule the location change.
-URL parsedURL(ParsedURLString, url);
-if (parsedURL.hasFragmentIdentifier() && equalIgnoringFragmentIdentifier(m_frame.document()->url(), parsedURL)) {
+if (url.hasFragmentIdentifier() && equalIgnoringFragmentIdentifier(m_frame.document()->url(), url)) {
 loader.changeLocation(securityOrigin, m_frame.document()->completeURL(url), referrer, lockHistory, lockBackForwardList, false, AllowNavigationToInvalidURL::No);
 return;
 }






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [182783] trunk/LayoutTests

[calvaris]

Title: [182783] trunk/LayoutTests








Revision 182783
Author calva...@igalia.com
Date 2015-04-14 01:20:40 -0700 (Tue, 14 Apr 2015)


Log Message
Sync Streams API tests with spec
https://bugs.webkit.org/show_bug.cgi?id=143669

Reviewed by Darin Adler.

Some tests were moved from the spec tests to our custom ones
because they were not approved (yet, or they won't be).

Some nuances from the spec tests were also fixed.

* streams/readable-stream-expected.txt: Added.
* streams/readable-stream-reader-expected.txt: Added.
* streams/readable-stream-reader.html: Added.
* streams/readable-stream.html: Added.
* streams/reference-implementation/readable-stream-expected.txt:
* streams/reference-implementation/readable-stream-reader-expected.txt:
* streams/reference-implementation/readable-stream-reader.html:
* streams/reference-implementation/readable-stream.html: Nuances
fixed and tests moved to custom.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/streams/reference-implementation/readable-stream-expected.txt
trunk/LayoutTests/streams/reference-implementation/readable-stream-reader-expected.txt
trunk/LayoutTests/streams/reference-implementation/readable-stream-reader.html
trunk/LayoutTests/streams/reference-implementation/readable-stream.html


Added Paths

trunk/LayoutTests/streams/readable-stream-expected.txt
trunk/LayoutTests/streams/readable-stream-reader-expected.txt
trunk/LayoutTests/streams/readable-stream-reader.html
trunk/LayoutTests/streams/readable-stream.html




Diff

Modified: trunk/LayoutTests/ChangeLog (182782 => 182783)

--- trunk/LayoutTests/ChangeLog	2015-04-14 05:48:23 UTC (rev 182782)
+++ trunk/LayoutTests/ChangeLog	2015-04-14 08:20:40 UTC (rev 182783)
@@ -1,3 +1,25 @@
+2015-04-14  Youenn Fablet   and Xabier Rodriguez Calvar 
+
+Sync Streams API tests with spec
+https://bugs.webkit.org/show_bug.cgi?id=143669
+
+Reviewed by Darin Adler.
+
+Some tests were moved from the spec tests to our custom ones
+because they were not approved (yet, or they won't be).
+
+Some nuances from the spec tests were also fixed.
+
+* streams/readable-stream-expected.txt: Added.
+* streams/readable-stream-reader-expected.txt: Added.
+* streams/readable-stream-reader.html: Added.
+* streams/readable-stream.html: Added.
+* streams/reference-implementation/readable-stream-expected.txt:
+* streams/reference-implementation/readable-stream-reader-expected.txt:
+* streams/reference-implementation/readable-stream-reader.html:
+* streams/reference-implementation/readable-stream.html: Nuances
+fixed and tests moved to custom.
+
 2015-04-13  Manuel Rego Casasnovas  
 
 [CSS Grid Layout] Columns set in percentages collapse to auto width


Added: trunk/LayoutTests/streams/readable-stream-expected.txt (0 => 182783)

--- trunk/LayoutTests/streams/readable-stream-expected.txt	(rev 0)
+++ trunk/LayoutTests/streams/readable-stream-expected.txt	2015-04-14 08:20:40 UTC (rev 182783)
@@ -0,0 +1,6 @@
+
+PASS ReadableStream can't be constructed with garbage 
+FAIL ReadableStream start should be called with the proper parameters null is not an object (evaluating 'Object.getOwnPropertyNames(Object.getPrototypeOf(controller))')
+FAIL ReadableStream start controller parameter should be updatable null is not an object (evaluating 'Object.getOwnPropertyNames(Object.getPrototypeOf(controller))')
+PASS ReadableStream should be able to call start method within prototype chain of its source 
+


Added: trunk/LayoutTests/streams/readable-stream-reader-expected.txt (0 => 182783)

--- trunk/LayoutTests/streams/readable-stream-reader-expected.txt	(rev 0)
+++ trunk/LayoutTests/streams/readable-stream-reader-expected.txt	2015-04-14 08:20:40 UTC (rev 182783)
@@ -0,0 +1,3 @@
+
+PASS Collecting a ReadableStreamReader should not unlock its stream 
+


Added: trunk/LayoutTests/streams/readable-stream-reader.html (0 => 182783)

--- trunk/LayoutTests/streams/readable-stream-reader.html	(rev 0)
+++ trunk/LayoutTests/streams/readable-stream-reader.html	2015-04-14 08:20:40 UTC (rev 182783)
@@ -0,0 +1,12 @@
+
+
+
+
+
+test(function() {
+var rs = new ReadableStream({});
+rs.getReader();
+window.gc();
+assert_throws(new TypeError(), function() { rs.getReader(); }, 'old reader should still be locking a new one even after garbage collection');
+}, 'Collecting a ReadableStreamReader should not unlock its stream');
+


Added: trunk/LayoutTests/streams/readable-stream.html (0 => 182783)

--- trunk/LayoutTests/streams/readable-stream.html	(rev 0)
+++ trunk/LayoutTests/streams/readable-stream.html	2015-04-14 08:20:40 UTC (rev 182783)
@@ -0,0 +1,82 @@
+
+
+
+
+test(function() {
+assert_throws(new TypeError(), function() {
+new ReadableStream(null);
+}, 'constructor should throw when the source is null');
+},