[webkit-changes] [183668] trunk/Source/WebInspectorUI
Title: [183668] trunk/Source/WebInspectorUI Revision 183668 Author nvasil...@apple.com Date 2015-04-30 22:57:26 -0700 (Thu, 30 Apr 2015) Log Message REGRESSION: Web Inspector: Console message repeat count overlapped by icon https://bugs.webkit.org/show_bug.cgi?id=144344 Reviewed by Timothy Hatcher. * UserInterface/Views/ConsoleMessageView.css: (.console-message .repeat-count): Modified Paths trunk/Source/WebInspectorUI/ChangeLog trunk/Source/WebInspectorUI/UserInterface/Views/ConsoleMessageView.css Diff Modified: trunk/Source/WebInspectorUI/ChangeLog (183667 => 183668) --- trunk/Source/WebInspectorUI/ChangeLog 2015-05-01 05:01:17 UTC (rev 183667) +++ trunk/Source/WebInspectorUI/ChangeLog 2015-05-01 05:57:26 UTC (rev 183668) @@ -1,3 +1,13 @@ +2015-04-30 Nikita Vasilyev + +REGRESSION: Web Inspector: Console message repeat count overlapped by icon +https://bugs.webkit.org/show_bug.cgi?id=144344 + +Reviewed by Timothy Hatcher. + +* UserInterface/Views/ConsoleMessageView.css: +(.console-message .repeat-count): + 2015-04-30 Jon Davis Web Inspector: console should show an icon for console.info() messages Modified: trunk/Source/WebInspectorUI/UserInterface/Views/ConsoleMessageView.css (183667 => 183668) --- trunk/Source/WebInspectorUI/UserInterface/Views/ConsoleMessageView.css 2015-05-01 05:01:17 UTC (rev 183667) +++ trunk/Source/WebInspectorUI/UserInterface/Views/ConsoleMessageView.css 2015-05-01 05:57:26 UTC (rev 183668) @@ -34,7 +34,7 @@ float: left; padding: 1px 4px; -margin: 0 2px 0 -18px; +margin: 0 4px 0 0; height: 15px; background-color: rgb(128, 151, 189); ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [183667] trunk/Source/WebCore
Title: [183667] trunk/Source/WebCore
Revision 183667
Author achristen...@apple.com
Date 2015-04-30 22:01:17 -0700 (Thu, 30 Apr 2015)
Log Message
Compile fix when using content extensions debugging code.
* contentextensions/ContentExtensionCompiler.cpp:
(WebCore::ContentExtensions::compileRuleList):
* contentextensions/ContentExtensionsDebugging.h:
* contentextensions/DFA.cpp:
(WebCore::ContentExtensions::printTransitions):
(WebCore::ContentExtensions::DFA::debugPrintDot):
* contentextensions/DFANode.h:
* contentextensions/NFA.cpp:
(WebCore::ContentExtensions::NFA::memoryUsed):
(WebCore::ContentExtensions::NFA::debugPrintDot):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/contentextensions/ContentExtensionCompiler.cpp
trunk/Source/WebCore/contentextensions/ContentExtensionsDebugging.h
trunk/Source/WebCore/contentextensions/DFA.cpp
trunk/Source/WebCore/contentextensions/DFANode.h
trunk/Source/WebCore/contentextensions/NFA.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (183666 => 183667)
--- trunk/Source/WebCore/ChangeLog 2015-05-01 04:24:40 UTC (rev 183666)
+++ trunk/Source/WebCore/ChangeLog 2015-05-01 05:01:17 UTC (rev 183667)
@@ -1,3 +1,18 @@
+2015-04-30 Alex Christensen
+
+Compile fix when using content extensions debugging code.
+
+* contentextensions/ContentExtensionCompiler.cpp:
+(WebCore::ContentExtensions::compileRuleList):
+* contentextensions/ContentExtensionsDebugging.h:
+* contentextensions/DFA.cpp:
+(WebCore::ContentExtensions::printTransitions):
+(WebCore::ContentExtensions::DFA::debugPrintDot):
+* contentextensions/DFANode.h:
+* contentextensions/NFA.cpp:
+(WebCore::ContentExtensions::NFA::memoryUsed):
+(WebCore::ContentExtensions::NFA::debugPrintDot):
+
2015-04-30 Dan Bernstein
Fixed the build for
Modified: trunk/Source/WebCore/contentextensions/ContentExtensionCompiler.cpp (183666 => 183667)
--- trunk/Source/WebCore/contentextensions/ContentExtensionCompiler.cpp 2015-05-01 04:24:40 UTC (rev 183666)
+++ trunk/Source/WebCore/contentextensions/ContentExtensionCompiler.cpp 2015-05-01 05:01:17 UTC (rev 183667)
@@ -214,7 +214,7 @@
#if CONTENT_EXTENSIONS_PERFORMANCE_REPORTING
double dfaBuildTimeEnd = monotonicallyIncreasingTime();
-dataLogF("Time spent building the DFA %zu: %f\n", i, (dfaBuildTimeEnd - dfaBuildTimeStart));
+dataLogF("Time spent building the DFA: %f\n", (dfaBuildTimeEnd - dfaBuildTimeStart));
#endif
#if CONTENT_EXTENSIONS_PERFORMANCE_REPORTING
@@ -223,11 +223,11 @@
dfa.minimize();
#if CONTENT_EXTENSIONS_PERFORMANCE_REPORTING
double dfaMinimizationTimeEnd = monotonicallyIncreasingTime();
-dataLogF("Time spent miniminizing the DFA %zu: %f\n", i, (dfaMinimizationTimeEnd - dfaMinimizationTimeStart));
+dataLogF("Time spent miniminizing the DFA: %f\n", (dfaMinimizationTimeEnd - dfaMinimizationTimeStart));
#endif
#if CONTENT_EXTENSIONS_STATE_MACHINE_DEBUGGING
-WTFLogAlways("DFA %zu", i);
+WTFLogAlways("DFA");
dfa.debugPrintDot();
#endif
ASSERT_WITH_MESSAGE(!dfa.nodes[dfa.root].hasActions(), "All actions on the DFA root should come from regular expressions that match everything.");
@@ -266,7 +266,6 @@
double totalNFAToByteCodeBuildTimeEnd = monotonicallyIncreasingTime();
dataLogF("Time spent building and compiling the DFAs: %f\n", (totalNFAToByteCodeBuildTimeEnd - totalNFAToByteCodeBuildTimeStart));
dataLogF("Bytecode size %zu\n", bytecode.size());
-dataLogF("DFA count %zu\n", nfas.size());
#endif
LOG_LARGE_STRUCTURES(bytecode, bytecode.capacity() * sizeof(uint8_t));
Modified: trunk/Source/WebCore/contentextensions/ContentExtensionsDebugging.h (183666 => 183667)
--- trunk/Source/WebCore/contentextensions/ContentExtensionsDebugging.h 2015-05-01 04:24:40 UTC (rev 183666)
+++ trunk/Source/WebCore/contentextensions/ContentExtensionsDebugging.h 2015-05-01 05:01:17 UTC (rev 183667)
@@ -36,7 +36,7 @@
#define CONTENT_EXTENSIONS_PAGE_SIZE 16384
#if CONTENT_EXTENSIONS_PERFORMANCE_REPORTING
-#define LOG_LARGE_STRUCTURES(name, size) if (size > 100) { WTFLogAlways("NAME: %s SIZE %d", #name, (int)(size)); };
+#define LOG_LARGE_STRUCTURES(name, size) if (size > 100) { dataLogF("NAME: %s SIZE %d", #name, (int)(size)); };
#else
#define LOG_LARGE_STRUCTURES(name, size)
#endif
Modified: trunk/Source/WebCore/contentextensions/DFA.cpp (183666 => 183667)
--- trunk/Source/WebCore/contentextensions/DFA.cpp 2015-05-01 04:24:40 UTC (rev 183666)
+++ trunk/Source/WebCore/contentextensions/DFA.cpp 2015-05-01 05:01:17 UTC (rev 183667)
@@ -137,22 +137,22 @@
dataLogF("%d-%d", rangeStart, rangeEnd);
}
-static void printTransitions(const Vector& graph, unsigned sourceNodeId)
+static void printTransitions(const DFA& dfa, unsigned sourceNodeId)
{
-const DFANode& sourceNode
[webkit-changes] [183666] trunk/Source/WebCore
Title: [183666] trunk/Source/WebCore
Revision 183666
Author m...@apple.com
Date 2015-04-30 21:24:40 -0700 (Thu, 30 Apr 2015)
Log Message
Fixed the build for
* platform/graphics/avfoundation/AudioSourceProviderAVFObjC.mm:
(WebCore::AudioSourceProviderAVFObjC::destroyMix): Don’t pass nil to
-[AVMutableAudioMix setInputParameters:].
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/avfoundation/AudioSourceProviderAVFObjC.mm
Diff
Modified: trunk/Source/WebCore/ChangeLog (183665 => 183666)
--- trunk/Source/WebCore/ChangeLog 2015-05-01 03:42:31 UTC (rev 183665)
+++ trunk/Source/WebCore/ChangeLog 2015-05-01 04:24:40 UTC (rev 183666)
@@ -1,3 +1,11 @@
+2015-04-30 Dan Bernstein
+
+Fixed the build for
+
+* platform/graphics/avfoundation/AudioSourceProviderAVFObjC.mm:
+(WebCore::AudioSourceProviderAVFObjC::destroyMix): Don’t pass nil to
+-[AVMutableAudioMix setInputParameters:].
+
2015-04-30 Daniel Bates
Clean up: Remove unnecessary runtime computation of string length
Modified: trunk/Source/WebCore/platform/graphics/avfoundation/AudioSourceProviderAVFObjC.mm (183665 => 183666)
--- trunk/Source/WebCore/platform/graphics/avfoundation/AudioSourceProviderAVFObjC.mm 2015-05-01 03:42:31 UTC (rev 183665)
+++ trunk/Source/WebCore/platform/graphics/avfoundation/AudioSourceProviderAVFObjC.mm 2015-05-01 04:24:40 UTC (rev 183666)
@@ -172,7 +172,7 @@
{
if (m_avPlayerItem)
[m_avPlayerItem setAudioMix:nil];
-[m_avAudioMix setInputParameters:nil];
+[m_avAudioMix setInputParameters:@[ ]];
m_avAudioMix.clear();
m_tap.clear();
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [183665] trunk/LayoutTests
Title: [183665] trunk/LayoutTests
Revision 183665
Author joep...@webkit.org
Date 2015-04-30 20:42:31 -0700 (Thu, 30 Apr 2015)
Log Message
Unreviewed gardening. Update results of inspector tests.
* inspector-protocol/debugger/breakpoint-eval-with-exception-expected.txt:
* inspector-protocol/debugger/regress-133182-expected.txt:
* inspector-protocol/debugger/regress-133182.html:
* inspector-protocol/debugger/setBreakpoint-actions-expected.txt:
* inspector-protocol/debugger/terminate-dedicated-worker-while-paused-expected.txt:
* inspector-protocol/page/deny-X-FrameOption-expected.txt:
* inspector/debugger/search-scripts-expected.txt:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/inspector/debugger/search-scripts-expected.txt
trunk/LayoutTests/inspector-protocol/debugger/breakpoint-eval-with-exception-expected.txt
trunk/LayoutTests/inspector-protocol/debugger/regress-133182-expected.txt
trunk/LayoutTests/inspector-protocol/debugger/regress-133182.html
trunk/LayoutTests/inspector-protocol/debugger/setBreakpoint-actions-expected.txt
trunk/LayoutTests/inspector-protocol/debugger/terminate-dedicated-worker-while-paused-expected.txt
trunk/LayoutTests/inspector-protocol/page/deny-X-FrameOption-expected.txt
Diff
Modified: trunk/LayoutTests/ChangeLog (183664 => 183665)
--- trunk/LayoutTests/ChangeLog 2015-05-01 03:42:28 UTC (rev 183664)
+++ trunk/LayoutTests/ChangeLog 2015-05-01 03:42:31 UTC (rev 183665)
@@ -1,5 +1,17 @@
2015-04-30 Joseph Pecoraro
+Unreviewed gardening. Update results of inspector tests.
+
+* inspector-protocol/debugger/breakpoint-eval-with-exception-expected.txt:
+* inspector-protocol/debugger/regress-133182-expected.txt:
+* inspector-protocol/debugger/regress-133182.html:
+* inspector-protocol/debugger/setBreakpoint-actions-expected.txt:
+* inspector-protocol/debugger/terminate-dedicated-worker-while-paused-expected.txt:
+* inspector-protocol/page/deny-X-FrameOption-expected.txt:
+* inspector/debugger/search-scripts-expected.txt:
+
+2015-04-30 Joseph Pecoraro
+
Unreviewed gardening. Remove skipped and broken inspector test.
This is the last test relying on the old model interface.
Modified: trunk/LayoutTests/inspector/debugger/search-scripts-expected.txt (183664 => 183665)
--- trunk/LayoutTests/inspector/debugger/search-scripts-expected.txt 2015-05-01 03:42:28 UTC (rev 183664)
+++ trunk/LayoutTests/inspector/debugger/search-scripts-expected.txt 2015-05-01 03:42:31 UTC (rev 183665)
@@ -13,8 +13,8 @@
SCRIPT: LayoutTests/inspector/debugger/search-scripts.html
RESULTS: 1
- LINE: 0
- CONTENT: (function(event) {runTest(); // SEARCHTEST: onload attribute string
+ LINE: 1
+ CONTENT: runTest(); // SEARCHTEST: onload attribute string
SCRIPT: eval1.js
RESULTS: 1
Modified: trunk/LayoutTests/inspector-protocol/debugger/breakpoint-eval-with-exception-expected.txt (183664 => 183665)
--- trunk/LayoutTests/inspector-protocol/debugger/breakpoint-eval-with-exception-expected.txt 2015-05-01 03:42:28 UTC (rev 183664)
+++ trunk/LayoutTests/inspector-protocol/debugger/breakpoint-eval-with-exception-expected.txt 2015-05-01 03:42:31 UTC (rev 183665)
@@ -2,6 +2,6 @@
Found breakpoint.js
inside breakpointBasic
-PASS: Paused in debugger: reason = "other"
+PASS: Paused in debugger: reason = "Breakpoint"
PASS: The debugger should not stop on the exception thrown by a console command while paused on a breakpoint.
Modified: trunk/LayoutTests/inspector-protocol/debugger/regress-133182-expected.txt (183664 => 183665)
--- trunk/LayoutTests/inspector-protocol/debugger/regress-133182-expected.txt 2015-05-01 03:42:28 UTC (rev 183664)
+++ trunk/LayoutTests/inspector-protocol/debugger/regress-133182-expected.txt 2015-05-01 03:42:31 UTC (rev 183665)
@@ -1,44 +1,44 @@
-CONSOLE MESSAGE: line 48: [1] Testing statement '({}).a.b.c.d;'
-CONSOLE MESSAGE: line 49: [1] Paused and about to step
-CONSOLE MESSAGE: line 61: [1] Resumed
-CONSOLE MESSAGE: line 53: [1] Paused after stepping
-CONSOLE MESSAGE: line 61: [1] Resumed
+CONSOLE MESSAGE: line 47: [1] Testing statement '({}).a.b.c.d;'
+CONSOLE MESSAGE: line 48: [1] Paused and about to step
+CONSOLE MESSAGE: line 60: [1] Resumed
+CONSOLE MESSAGE: line 52: [1] Paused after stepping
+CONSOLE MESSAGE: line 60: [1] Resumed
CONSOLE MESSAGE: line 1: TypeError: undefined is not an object (evaluating '({}).a.b')
-CONSOLE MESSAGE: line 48: [2] Testing statement 'exceptionBasic();'
-CONSOLE MESSAGE: line 49: [2] Paused and about to step
-CONSOLE MESSAGE: line 61: [2] Resumed
-CONSOLE MESSAGE: line 53: [2] Paused after stepping
-CONSOLE MESSAGE: line 61: [2] Resumed
+CONSOLE MESSAGE: line 47: [2] Testing statement 'exceptionBasic();'
+CONSOLE MESSAGE: line 48: [2] Paused and about to step
+CONSOLE MESSAGE: line 60: [2] Resumed
+CONSOLE MESSAGE: line 52: [2] Paused after stepping
+CONSOLE MESSAGE: line 60: [2] Resumed
CONSOLE MESSAGE: line 3: TypeError: un
[webkit-changes] [183664] trunk/LayoutTests
Title: [183664] trunk/LayoutTests
Revision 183664
Author joep...@webkit.org
Date 2015-04-30 20:42:28 -0700 (Thu, 30 Apr 2015)
Log Message
Unreviewed gardening. Remove skipped and broken inspector test.
This is the last test relying on the old model interface.
* TestExpectations:
* http/tests/inspector-protocol/resources/InspectorTest.js:
(InspectorTest.initializeInspectorModels.console.error.window.onerror): Deleted.
(InspectorTest.initializeInspectorModels.console.assert): Deleted.
(InspectorTest.initializeInspectorModels): Deleted.
* inspector-protocol/indexeddb/basics-expected.txt: Removed.
* inspector-protocol/indexeddb/basics.html: Removed.
* platform/efl/TestExpectations:
* platform/gtk/TestExpectations:
* platform/win/TestExpectations:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/TestExpectations
trunk/LayoutTests/http/tests/inspector-protocol/resources/InspectorTest.js
trunk/LayoutTests/platform/efl/TestExpectations
trunk/LayoutTests/platform/gtk/TestExpectations
trunk/LayoutTests/platform/win/TestExpectations
Removed Paths
trunk/LayoutTests/inspector-protocol/indexeddb/
Diff
Modified: trunk/LayoutTests/ChangeLog (183663 => 183664)
--- trunk/LayoutTests/ChangeLog 2015-05-01 02:40:34 UTC (rev 183663)
+++ trunk/LayoutTests/ChangeLog 2015-05-01 03:42:28 UTC (rev 183664)
@@ -1,3 +1,20 @@
+2015-04-30 Joseph Pecoraro
+
+Unreviewed gardening. Remove skipped and broken inspector test.
+
+This is the last test relying on the old model interface.
+
+* TestExpectations:
+* http/tests/inspector-protocol/resources/InspectorTest.js:
+(InspectorTest.initializeInspectorModels.console.error.window.onerror): Deleted.
+(InspectorTest.initializeInspectorModels.console.assert): Deleted.
+(InspectorTest.initializeInspectorModels): Deleted.
+* inspector-protocol/indexeddb/basics-expected.txt: Removed.
+* inspector-protocol/indexeddb/basics.html: Removed.
+* platform/efl/TestExpectations:
+* platform/gtk/TestExpectations:
+* platform/win/TestExpectations:
+
2015-04-30 Dean Jackson
Expose -apple-system as a font family
Modified: trunk/LayoutTests/TestExpectations (183663 => 183664)
--- trunk/LayoutTests/TestExpectations 2015-05-01 02:40:34 UTC (rev 183663)
+++ trunk/LayoutTests/TestExpectations 2015-05-01 03:42:28 UTC (rev 183664)
@@ -84,7 +84,6 @@
webkit.org/b/133761 inspector-protocol/debugger/breakpoint-action-detach.html [ Skip ]
webkit.org/b/129639 inspector-protocol/dom/dom-search-crash.html [ Skip ]
-webkit.org/b/129327 inspector-protocol/indexeddb/basics.html [ Pass Failure ]
webkit.org/b/127414 inspector-protocol/page/deny-X-FrameOption.html [ Pass Failure ]
# These tests cause assertion failures in subsequent tests
Modified: trunk/LayoutTests/http/tests/inspector-protocol/resources/InspectorTest.js (183663 => 183664)
--- trunk/LayoutTests/http/tests/inspector-protocol/resources/InspectorTest.js 2015-05-01 02:40:34 UTC (rev 183663)
+++ trunk/LayoutTests/http/tests/inspector-protocol/resources/InspectorTest.js 2015-05-01 03:42:28 UTC (rev 183664)
@@ -158,121 +158,6 @@
window.eval(script);
}
-// FIXME: Move model tests off of the stub inspector page, and delete this function
-// since it's now implemented as Test.html.
-InspectorTest.initializeInspectorModels = function()
-{
-// Catch any errors and finish the test early.
-console.error = window._onerror_ = function()
-{
-InspectorTest.log(Array.prototype.join.call(arguments, ', '));
-InspectorTest.completeTest();
-};
-
-console.assert = function(assertion, message)
-{
-if (assertion)
-return;
-
-InspectorTest.log("ASSERT:" + message);
-InspectorTest.completeTest();
-};
-
-// Note: This function overwrites the InspectorFrontendAPI, so there's currently no
-// way to intercept the messages from the backend.
-
-var inspectorScripts = [
-"Base/WebInspector",
-"Base/Object",
-
-"Base/DOMUtilities",
-"Base/URLUtilities",
-"Base/Utilities",
-
-"Protocol/CSSObserver",
-"Protocol/DOMObserver",
-"Protocol/DebuggerObserver",
-"Protocol/InspectorBackend",
-"Protocol/InspectorFrontendAPI",
-"Protocol/InspectorFrontendHostStub",
-"Protocol/InspectorJSBackendCommands",
-"Protocol/InspectorObserver",
-"Protocol/InspectorWebBackendCommands",
-"Protocol/MessageDispatcher",
-"Protocol/PageObserver",
-"Protocol/RemoteObject",
-"Protocol/RuntimeObserver",
-
-"Models/BreakpointAction",
-"Models/SourceCode",
-
-"Models/Breakpoint",
-"Models/Color",
-"Models/ContentFlow",
-"Models/DOMNode",
-"Models/DOMStorageObject",
-"Models/DOMTree",
-"Models/ExecutionContext",
-"Models/ExecutionContextList",
-"
[webkit-changes] [183663] trunk/Source/WebCore
Title: [183663] trunk/Source/WebCore
Revision 183663
Author dba...@webkit.org
Date 2015-04-30 19:40:34 -0700 (Thu, 30 Apr 2015)
Log Message
Clean up: Remove unnecessary runtime computation of string length
https://bugs.webkit.org/show_bug.cgi?id=144483
Reviewed by Joseph Pecoraro.
Following , WebCore::fullyQualifiedInfoTableName()
computes strlen() of the first string literal as part of concatenating two string literals.
It is sufficient to use sizeof() - 1 instead of strlen() to compute the length of the first
string literal because the size of the string literal is known at compile time.
* Modules/webdatabase/DatabaseBackendBase.cpp:
(WebCore::fullyQualifiedInfoTableName):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/webdatabase/DatabaseBackendBase.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (183662 => 183663)
--- trunk/Source/WebCore/ChangeLog 2015-05-01 01:56:32 UTC (rev 183662)
+++ trunk/Source/WebCore/ChangeLog 2015-05-01 02:40:34 UTC (rev 183663)
@@ -1,3 +1,18 @@
+2015-04-30 Daniel Bates
+
+Clean up: Remove unnecessary runtime computation of string length
+https://bugs.webkit.org/show_bug.cgi?id=144483
+
+Reviewed by Joseph Pecoraro.
+
+Following , WebCore::fullyQualifiedInfoTableName()
+computes strlen() of the first string literal as part of concatenating two string literals.
+It is sufficient to use sizeof() - 1 instead of strlen() to compute the length of the first
+string literal because the size of the string literal is known at compile time.
+
+* Modules/webdatabase/DatabaseBackendBase.cpp:
+(WebCore::fullyQualifiedInfoTableName):
+
2015-04-30 Dean Jackson
Expose -apple-system as a font family
Modified: trunk/Source/WebCore/Modules/webdatabase/DatabaseBackendBase.cpp (183662 => 183663)
--- trunk/Source/WebCore/Modules/webdatabase/DatabaseBackendBase.cpp 2015-05-01 01:56:32 UTC (rev 183662)
+++ trunk/Source/WebCore/Modules/webdatabase/DatabaseBackendBase.cpp 2015-05-01 02:40:34 UTC (rev 183663)
@@ -97,7 +97,7 @@
static std::once_flag onceFlag;
std::call_once(onceFlag, []{
strcpy(qualifiedName, qualifier);
-strcpy(qualifiedName + strlen(qualifier), unqualifiedInfoTableName);
+strcpy(qualifiedName + sizeof(qualifier) - 1, unqualifiedInfoTableName);
});
return qualifiedName;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [183662] trunk
Title: [183662] trunk Revision 183662 Author d...@apple.com Date 2015-04-30 18:56:32 -0700 (Thu, 30 Apr 2015) Log Message Expose -apple-system as a font family https://bugs.webkit.org/show_bug.cgi?id=144484 Reviewed by Tim Horton. Source/WebCore: Accept "-apple-system" for the font-family property, and rename "-apple-system-font-monospaced-numbers" to "-apple-system-monospaced-numbers". Also change the media controls to use the new name. Covered by existing tests and this new one: fast/text/system-font-legacy-name.html * Modules/mediacontrols/mediaControlsApple.css: (audio::-webkit-media-controls-time-remaining-display): * Modules/mediacontrols/mediaControlsiOS.css: (::-webkit-media-controls): (audio::-webkit-media-controls-time-remaining-display): (audio::-webkit-media-controls-status-display): * platform/graphics/ios/FontCacheIOS.mm: Add support for the new name. (WebCore::createCTFontWithFamilyNameAndWeight): * platform/graphics/mac/FontCacheMac.mm: Ditto. (WebCore::fontWithFamily): LayoutTests: Change a bunch of tests to use "-apple-system" instead of "-apple-system-font" for font-family. Add a test to make sure the old name still works. * fast/text/system-font-legacy-name.html * platform/ios-simulator/fast/text/system-monospaced-numbers.html: * platform/ios-simulator/ios/fast/text/apple-logo-expected.txt: * platform/ios-simulator/ios/fast/text/apple-logo.html: * platform/ios-simulator/ios/fast/text/opticalFont-expected.txt: * platform/ios-simulator/ios/fast/text/opticalFont.html: * platform/ios-simulator/ios/fast/text/opticalFontWithWeight-expected.txt: * platform/ios-simulator/ios/fast/text/opticalFontWithWeight.html: * platform/ios-simulator/ios/fast/text/underline-scaling-expected.txt: * platform/ios-simulator/ios/fast/text/underline-scaling.html: * platform/mac/fast/text/systemFont-expected.txt: * platform/mac/fast/text/systemFont.html: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/ios-simulator/fast/text/system-monospaced-numbers.html trunk/LayoutTests/platform/ios-simulator/ios/fast/text/apple-logo-expected.txt trunk/LayoutTests/platform/ios-simulator/ios/fast/text/apple-logo.html trunk/LayoutTests/platform/ios-simulator/ios/fast/text/opticalFont-expected.txt trunk/LayoutTests/platform/ios-simulator/ios/fast/text/opticalFont.html trunk/LayoutTests/platform/ios-simulator/ios/fast/text/opticalFontWithWeight-expected.txt trunk/LayoutTests/platform/ios-simulator/ios/fast/text/opticalFontWithWeight.html trunk/LayoutTests/platform/ios-simulator/ios/fast/text/underline-scaling-expected.txt trunk/LayoutTests/platform/ios-simulator/ios/fast/text/underline-scaling.html trunk/LayoutTests/platform/mac/fast/text/systemFont-expected.txt trunk/LayoutTests/platform/mac/fast/text/systemFont.html trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/Modules/mediacontrols/mediaControlsApple.css trunk/Source/WebCore/Modules/mediacontrols/mediaControlsiOS.css trunk/Source/WebCore/platform/graphics/ios/FontCacheIOS.mm trunk/Source/WebCore/platform/graphics/mac/FontCacheMac.mm Added Paths trunk/LayoutTests/fast/text/system-font-legacy-name-expected.txt trunk/LayoutTests/fast/text/system-font-legacy-name.html Diff Modified: trunk/LayoutTests/ChangeLog (183661 => 183662) --- trunk/LayoutTests/ChangeLog 2015-05-01 01:38:27 UTC (rev 183661) +++ trunk/LayoutTests/ChangeLog 2015-05-01 01:56:32 UTC (rev 183662) @@ -1,3 +1,29 @@ +2015-04-30 Dean Jackson + +Expose -apple-system as a font family +https://bugs.webkit.org/show_bug.cgi?id=144484 + + +Reviewed by Tim Horton. + +Change a bunch of tests to use "-apple-system" instead +of "-apple-system-font" for font-family. + +Add a test to make sure the old name still works. + +* fast/text/system-font-legacy-name.html +* platform/ios-simulator/fast/text/system-monospaced-numbers.html: +* platform/ios-simulator/ios/fast/text/apple-logo-expected.txt: +* platform/ios-simulator/ios/fast/text/apple-logo.html: +* platform/ios-simulator/ios/fast/text/opticalFont-expected.txt: +* platform/ios-simulator/ios/fast/text/opticalFont.html: +* platform/ios-simulator/ios/fast/text/opticalFontWithWeight-expected.txt: +* platform/ios-simulator/ios/fast/text/opticalFontWithWeight.html: +* platform/ios-simulator/ios/fast/text/underline-scaling-expected.txt: +* platform/ios-simulator/ios/fast/text/underline-scaling.html: +* platform/mac/fast/text/systemFont-expected.txt: +* platform/mac/fast/text/systemFont.html: + 2015-04-30 Javier Fernandez [CSS Grid Layout] overflow-position keyword for align and justify properties. Added: trunk/LayoutTests/fast/text/system-font-legacy-name-expected.txt (0 => 183662) --- trunk/LayoutTests/fast/text/system-font-legacy-name-expected.txt (rev 0) +++ trunk/LayoutTests/fast/text/system-font-legacy-name-expected.txt 2015-
[webkit-changes] [183661] trunk/Source/WTF
Title: [183661] trunk/Source/WTF
Revision 183661
Author commit-qu...@webkit.org
Date 2015-04-30 18:38:27 -0700 (Thu, 30 Apr 2015)
Log Message
Decrease minimum Vector size.
https://bugs.webkit.org/show_bug.cgi?id=144453
Patch by Alex Christensen on 2015-04-30
Reviewed by Andreas Kling.
* wtf/Vector.h:
Make the default min size 4 to save memory on small Vectors.
Modified Paths
trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/Vector.h
Diff
Modified: trunk/Source/WTF/ChangeLog (183660 => 183661)
--- trunk/Source/WTF/ChangeLog 2015-05-01 01:14:20 UTC (rev 183660)
+++ trunk/Source/WTF/ChangeLog 2015-05-01 01:38:27 UTC (rev 183661)
@@ -1,3 +1,13 @@
+2015-04-30 Alex Christensen
+
+Decrease minimum Vector size.
+https://bugs.webkit.org/show_bug.cgi?id=144453
+
+Reviewed by Andreas Kling.
+
+* wtf/Vector.h:
+Make the default min size 4 to save memory on small Vectors.
+
2015-04-30 Yusuke Suzuki
Use the default hash value for Symbolized StringImpl
Modified: trunk/Source/WTF/wtf/Vector.h (183660 => 183661)
--- trunk/Source/WTF/wtf/Vector.h 2015-05-01 01:14:20 UTC (rev 183660)
+++ trunk/Source/WTF/wtf/Vector.h 2015-05-01 01:38:27 UTC (rev 183661)
@@ -581,7 +581,7 @@
}
};
-template
+template
class Vector : private VectorBuffer {
WTF_MAKE_FAST_ALLOCATED;
private:
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [183660] trunk
Title: [183660] trunk Revision 183660 Author jfernan...@igalia.com Date 2015-04-30 18:14:20 -0700 (Thu, 30 Apr 2015) Log Message [CSS Grid Layout] overflow-position keyword for align and justify properties. https://bugs.webkit.org/show_bug.cgi?id=144235 Reviewed by Sergio Villar Senin. Source/WebCore: When the alignment subject is larger than the alignment container, it will overflow. Some alignment modes, if honored in this situation, may cause data loss; an overflow alignment mode can be explicitly specified to avoid this. This patch implements overflow-keyword handling for Grid Layout on align-self and justify-self properties. Test: fast/css-grid-layout/grid-align-justify-overflow.html * rendering/RenderGrid.cpp: (WebCore::computeOverflowAlignmentOffset): (WebCore::RenderGrid::rowPositionForChild): (WebCore::RenderGrid::columnPositionForChild): (WebCore::RenderGrid::rowAxisPositionForChild): Deleted. * rendering/style/RenderStyle.cpp: (WebCore::resolveAlignmentData): (WebCore::resolveJustificationData): (WebCore::RenderStyle::resolveAlignment): (WebCore::RenderStyle::resolveAlignmentOverflow): (WebCore::RenderStyle::resolveJustification): (WebCore::RenderStyle::resolveJustificationOverflow): * rendering/style/RenderStyle.h: LayoutTests: Implementation of overflow-keyword handling for Grid Layout on align-self and justify-self properties. * fast/css-grid-layout/grid-align-justify-overflow-expected.txt: Added. * fast/css-grid-layout/grid-align-justify-overflow.html: Added. Modified Paths trunk/LayoutTests/ChangeLog trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/rendering/RenderGrid.cpp trunk/Source/WebCore/rendering/style/RenderStyle.cpp trunk/Source/WebCore/rendering/style/RenderStyle.h Added Paths trunk/LayoutTests/fast/css-grid-layout/grid-align-justify-overflow-expected.txt trunk/LayoutTests/fast/css-grid-layout/grid-align-justify-overflow.html Diff Modified: trunk/LayoutTests/ChangeLog (183659 => 183660) --- trunk/LayoutTests/ChangeLog 2015-05-01 01:10:43 UTC (rev 183659) +++ trunk/LayoutTests/ChangeLog 2015-05-01 01:14:20 UTC (rev 183660) @@ -1,3 +1,16 @@ +2015-04-30 Javier Fernandez + +[CSS Grid Layout] overflow-position keyword for align and justify properties. +https://bugs.webkit.org/show_bug.cgi?id=144235 + +Reviewed by Sergio Villar Senin. + +Implementation of overflow-keyword handling for Grid Layout on +align-self and justify-self properties. + +* fast/css-grid-layout/grid-align-justify-overflow-expected.txt: Added. +* fast/css-grid-layout/grid-align-justify-overflow.html: Added. + 2015-04-30 Jon Davis Web Inspector: console should show an icon for console.info() messages Added: trunk/LayoutTests/fast/css-grid-layout/grid-align-justify-overflow-expected.txt (0 => 183660) --- trunk/LayoutTests/fast/css-grid-layout/grid-align-justify-overflow-expected.txt (rev 0) +++ trunk/LayoutTests/fast/css-grid-layout/grid-align-justify-overflow-expected.txt 2015-05-01 01:14:20 UTC (rev 183660) @@ -0,0 +1,10 @@ +This test checks that the 'overflow' keyword is applied correctly for 'align' and 'justify' properties. + +PASS +PASS +PASS +PASS +PASS +PASS +PASS +PASS Added: trunk/LayoutTests/fast/css-grid-layout/grid-align-justify-overflow.html (0 => 183660) --- trunk/LayoutTests/fast/css-grid-layout/grid-align-justify-overflow.html (rev 0) +++ trunk/LayoutTests/fast/css-grid-layout/grid-align-justify-overflow.html 2015-05-01 01:14:20 UTC (rev 183660) @@ -0,0 +1,150 @@ + + + + +
[webkit-changes] [183659] trunk
Title: [183659] trunk
Revision 183659
Author j...@apple.com
Date 2015-04-30 18:10:43 -0700 (Thu, 30 Apr 2015)
Log Message
Web Inspector: console should show an icon for console.info() messages
https://bugs.webkit.org/show_bug.cgi?id=18530
Reviewed by Timothy Hatcher.
Source/_javascript_Core:
* inspector/ConsoleMessage.cpp:
(Inspector::messageLevelValue):
* inspector/protocol/Console.json:
* runtime/ConsoleClient.cpp:
(JSC::appendMessagePrefix):
* runtime/ConsolePrototype.cpp:
(JSC::ConsolePrototype::finishCreation):
(JSC::consoleProtoFuncInfo):
* runtime/ConsoleTypes.h:
Source/WebInspectorUI:
Added icons for console.log, console.info and console.debug messages.
Separated console.info from console.log.
* UserInterface/Images/Debug.svg: Added.
* UserInterface/Images/Info.svg: Added.
* UserInterface/Images/Log.svg: Added.
New icon files.
* UserInterface/Models/ConsoleMessage.js:
* UserInterface/Views/ConsoleMessageView.css:
(.console-log-level::before):
(.console-info-level::before):
(.console-debug-level::before):
(:matches(.console-warning-level, .console-error-level, .console-log-level, .console-info-level, .console-debug-level).console-message):
(:matches(.console-warning-level, .console-error-level, .console-log-level, .console-info-level, .console-debug-level)::before):
(:matches(.console-warning-level, .console-error-level, .console-log-level).console-message): Deleted.
(:matches(.console-warning-level, .console-error-level, .console-log-level)::before): Deleted.
Include console.info messages in layout adjustments.
* UserInterface/Views/ConsoleMessageView.js:
(WebInspector.ConsoleMessageView):
(WebInspector.ConsoleMessageView.prototype._levelString):
Source/WebKit/mac:
* WebCoreSupport/WebChromeClient.mm:
(stringForMessageLevel):
* WebView/WebUIDelegatePrivate.h:
LayoutTests:
* inspector/console/console-api-expected.txt:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/inspector/console/console-api-expected.txt
trunk/LayoutTests/inspector-protocol/console/console-message-expected.txt
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/inspector/ConsoleMessage.cpp
trunk/Source/_javascript_Core/inspector/protocol/Console.json
trunk/Source/_javascript_Core/runtime/ConsoleClient.cpp
trunk/Source/_javascript_Core/runtime/ConsolePrototype.cpp
trunk/Source/_javascript_Core/runtime/ConsoleTypes.h
trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js
trunk/Source/WebInspectorUI/UserInterface/Models/ConsoleMessage.js
trunk/Source/WebInspectorUI/UserInterface/Views/ConsoleMessageView.css
trunk/Source/WebInspectorUI/UserInterface/Views/ConsoleMessageView.js
trunk/Source/WebInspectorUI/UserInterface/Views/LogContentView.js
trunk/Source/WebKit/mac/ChangeLog
trunk/Source/WebKit/mac/WebCoreSupport/WebChromeClient.mm
trunk/Source/WebKit/mac/WebView/WebUIDelegatePrivate.h
Added Paths
trunk/Source/WebInspectorUI/UserInterface/Images/Debug.svg
trunk/Source/WebInspectorUI/UserInterface/Images/Info.svg
trunk/Source/WebInspectorUI/UserInterface/Images/Log.svg
Diff
Modified: trunk/LayoutTests/ChangeLog (183658 => 183659)
--- trunk/LayoutTests/ChangeLog 2015-05-01 01:04:52 UTC (rev 183658)
+++ trunk/LayoutTests/ChangeLog 2015-05-01 01:10:43 UTC (rev 183659)
@@ -1,3 +1,12 @@
+2015-04-30 Jon Davis
+
+Web Inspector: console should show an icon for console.info() messages
+https://bugs.webkit.org/show_bug.cgi?id=18530
+
+Reviewed by Timothy Hatcher.
+
+* inspector/console/console-api-expected.txt:
+
2015-04-30 Dean Jackson
-apple-system-font-monospaced-numbers doesn't work on iOS
Modified: trunk/LayoutTests/inspector/console/console-api-expected.txt (183658 => 183659)
--- trunk/LayoutTests/inspector/console/console-api-expected.txt 2015-05-01 01:04:52 UTC (rev 183658)
+++ trunk/LayoutTests/inspector/console/console-api-expected.txt 2015-05-01 01:10:43 UTC (rev 183659)
@@ -108,7 +108,7 @@
STEP: console.info('console.info')
{
"_source": "console-api",
- "_level": "log",
+ "_level": "info",
"_messageText": "console.info",
"_type": "log",
"_url": null,
@@ -382,7 +382,7 @@
STEP: console.info('message', object)
{
"_source": "console-api",
- "_level": "log",
+ "_level": "info",
"_messageText": "message",
"_type": "log",
"_url": null,
Modified: trunk/LayoutTests/inspector-protocol/console/console-message-expected.txt (183658 => 183659)
--- trunk/LayoutTests/inspector-protocol/console/console-message-expected.txt 2015-05-01 01:04:52 UTC (rev 183658)
+++ trunk/LayoutTests/inspector-protocol/console/console-message-expected.txt 2015-05-01 01:10:43 UTC (rev 183659)
@@ -5,7 +5,7 @@
CONSOLE MESSAGE: line 11: debug
Tests that console log messages make it to the frontend and have expected source, type, and levels.
{"source":"console-api","level":"log","text":"log","location":"console-message.html:7:16","parameters":[{"type":"string"}]}
-{"s
[webkit-changes] [183658] trunk/Source/WebKit2
Title: [183658] trunk/Source/WebKit2
Revision 183658
Author timothy_hor...@apple.com
Date 2015-04-30 18:04:52 -0700 (Thu, 30 Apr 2015)
Log Message
Remove long-deprecated unused WKView minimumLayoutWidth properties
https://bugs.webkit.org/show_bug.cgi?id=144480
Reviewed by Alexey Proskuryakov.
* UIProcess/API/Cocoa/WKViewPrivate.h:
* UIProcess/API/mac/WKView.mm:
(-[WKView minimumLayoutWidth]): Deleted.
(-[WKView setMinimumLayoutWidth:]): Deleted.
(-[WKView minimumWidthForAutoLayout]): Deleted.
(-[WKView setMinimumWidthForAutoLayout:]): Deleted.
These were replaced with minimumSizeForAutoLayout long ago.
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/Cocoa/WKViewPrivate.h
trunk/Source/WebKit2/UIProcess/API/mac/WKView.mm
Diff
Modified: trunk/Source/WebKit2/ChangeLog (183657 => 183658)
--- trunk/Source/WebKit2/ChangeLog 2015-05-01 00:34:24 UTC (rev 183657)
+++ trunk/Source/WebKit2/ChangeLog 2015-05-01 01:04:52 UTC (rev 183658)
@@ -1,3 +1,18 @@
+2015-04-30 Timothy Horton
+
+Remove long-deprecated unused WKView minimumLayoutWidth properties
+https://bugs.webkit.org/show_bug.cgi?id=144480
+
+Reviewed by Alexey Proskuryakov.
+
+* UIProcess/API/Cocoa/WKViewPrivate.h:
+* UIProcess/API/mac/WKView.mm:
+(-[WKView minimumLayoutWidth]): Deleted.
+(-[WKView setMinimumLayoutWidth:]): Deleted.
+(-[WKView minimumWidthForAutoLayout]): Deleted.
+(-[WKView setMinimumWidthForAutoLayout:]): Deleted.
+These were replaced with minimumSizeForAutoLayout long ago.
+
2015-04-30 Simon Fraser
Fixed elements end up in the middle of the view with pageScale < 1
Modified: trunk/Source/WebKit2/UIProcess/API/Cocoa/WKViewPrivate.h (183657 => 183658)
--- trunk/Source/WebKit2/UIProcess/API/Cocoa/WKViewPrivate.h 2015-05-01 00:34:24 UTC (rev 183657)
+++ trunk/Source/WebKit2/UIProcess/API/Cocoa/WKViewPrivate.h 2015-05-01 01:04:52 UTC (rev 183658)
@@ -77,8 +77,6 @@
+ (void)hideWordDefinitionWindow;
-@property (readwrite) CGFloat minimumLayoutWidth;
-@property (readwrite) CGFloat minimumWidthForAutoLayout;
@property (readwrite) NSSize minimumSizeForAutoLayout;
@property (readwrite) BOOL shouldClipToVisibleRect;
@property (readwrite) BOOL shouldExpandToViewHeightForAutoLayout;
Modified: trunk/Source/WebKit2/UIProcess/API/mac/WKView.mm (183657 => 183658)
--- trunk/Source/WebKit2/UIProcess/API/mac/WKView.mm 2015-05-01 00:34:24 UTC (rev 183657)
+++ trunk/Source/WebKit2/UIProcess/API/mac/WKView.mm 2015-05-01 01:04:52 UTC (rev 183658)
@@ -4149,40 +4149,6 @@
[getLULookupDefinitionModuleClass() hideDefinition];
}
-- (CGFloat)minimumLayoutWidth
-{
-static BOOL loggedDeprecationWarning = NO;
-
-if (!loggedDeprecationWarning) {
-NSLog(@"Please use minimumSizeForAutoLayout instead of minimumLayoutWidth.");
-loggedDeprecationWarning = YES;
-}
-
-return self.minimumSizeForAutoLayout.width;
-}
-
-- (void)setMinimumLayoutWidth:(CGFloat)minimumLayoutWidth
-{
-static BOOL loggedDeprecationWarning = NO;
-
-if (!loggedDeprecationWarning) {
-NSLog(@"Please use setMinimumSizeForAutoLayout: instead of setMinimumLayoutWidth:.");
-loggedDeprecationWarning = YES;
-}
-
-[self setMinimumWidthForAutoLayout:minimumLayoutWidth];
-}
-
-- (CGFloat)minimumWidthForAutoLayout
-{
-return self.minimumSizeForAutoLayout.width;
-}
-
-- (void)setMinimumWidthForAutoLayout:(CGFloat)minimumLayoutWidth
-{
-self.minimumSizeForAutoLayout = NSMakeSize(minimumLayoutWidth, self.minimumSizeForAutoLayout.height);
-}
-
- (NSSize)minimumSizeForAutoLayout
{
return _data->_page->minimumLayoutSize();
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [183657] trunk/Source/WebCore
Title: [183657] trunk/Source/WebCore Revision 183657 Author jhoneyc...@apple.com Date 2015-04-30 17:34:24 -0700 (Thu, 30 Apr 2015) Log Message Rebaseline bindings tests results after r183648. Unreviewed. * bindings/scripts/test/JS/JSTestActiveDOMObject.cpp: (WebCore::jsTestActiveDOMObjectPrototypeFunctionPostMessage): * bindings/scripts/test/JS/JSTestCustomNamedGetter.cpp: (WebCore::jsTestCustomNamedGetterPrototypeFunctionAnotherFunction): * bindings/scripts/test/JS/JSTestInterface.cpp: (WebCore::JSTestInterfaceConstructor::constructJSTestInterface): (WebCore::setJSTestInterfaceConstructorImplementsStaticAttr): (WebCore::setJSTestInterfaceImplementsStr2): (WebCore::setJSTestInterfaceConstructorSupplementalStaticAttr): (WebCore::setJSTestInterfaceSupplementalStr2): (WebCore::jsTestInterfacePrototypeFunctionImplementsMethod2): (WebCore::jsTestInterfacePrototypeFunctionSupplementalMethod2): * bindings/scripts/test/JS/JSTestNamedConstructor.cpp: (WebCore::JSTestNamedConstructorNamedConstructor::constructJSTestNamedConstructor): * bindings/scripts/test/JS/JSTestNondeterministic.cpp: (WebCore::setJSTestNondeterministicNondeterministicWriteableAttr): (WebCore::setJSTestNondeterministicNondeterministicExceptionAttr): (WebCore::setJSTestNondeterministicNondeterministicGetterExceptionAttr): (WebCore::setJSTestNondeterministicNondeterministicSetterExceptionAttr): * bindings/scripts/test/JS/JSTestObj.cpp: (WebCore::setJSTestObjConstructorStaticStringAttr): (WebCore::setJSTestObjStringAttr): (WebCore::setJSTestObjReflectedStringAttr): (WebCore::setJSTestObjReflectedURLAttr): (WebCore::setJSTestObjReflectedCustomURLAttr): (WebCore::setJSTestObjStringAttrWithGetterException): (WebCore::setJSTestObjStringAttrWithSetterException): (WebCore::jsTestObjPrototypeFunctionVoidMethodWithArgs): (WebCore::jsTestObjPrototypeFunctionByteMethodWithArgs): (WebCore::jsTestObjPrototypeFunctionOctetMethodWithArgs): (WebCore::jsTestObjPrototypeFunctionLongMethodWithArgs): (WebCore::jsTestObjPrototypeFunctionObjMethodWithArgs): (WebCore::jsTestObjPrototypeFunctionMethodThatRequiresAllArgsAndThrows): (WebCore::jsTestObjPrototypeFunctionMethodWithOptionalString): (WebCore::jsTestObjPrototypeFunctionMethodWithOptionalStringIsUndefined): (WebCore::jsTestObjPrototypeFunctionMethodWithOptionalStringIsNullString): (WebCore::jsTestObjPrototypeFunctionOverloadedMethod1): (WebCore::jsTestObjPrototypeFunctionOverloadedMethod3): (WebCore::jsTestObjPrototypeFunctionOverloadedMethod11): (WebCore::jsTestObjConstructorFunctionOverloadedMethod12): (WebCore::jsTestObjPrototypeFunctionStrictFunction): (WebCore::jsTestObjPrototypeFunctionVariadicStringMethod): * bindings/scripts/test/JS/JSTestOverloadedConstructors.cpp: (WebCore::JSTestOverloadedConstructorsConstructor::constructJSTestOverloadedConstructors4): * bindings/scripts/test/JS/JSTestTypedefs.cpp: (WebCore::JSTestTypedefsConstructor::constructJSTestTypedefs): (WebCore::setJSTestTypedefsStringAttrWithGetterException): (WebCore::setJSTestTypedefsStringAttrWithSetterException): (WebCore::jsTestTypedefsPrototypeFunctionSetShadow): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/bindings/scripts/test/JS/JSTestActiveDOMObject.cpp trunk/Source/WebCore/bindings/scripts/test/JS/JSTestCustomNamedGetter.cpp trunk/Source/WebCore/bindings/scripts/test/JS/JSTestInterface.cpp trunk/Source/WebCore/bindings/scripts/test/JS/JSTestNamedConstructor.cpp trunk/Source/WebCore/bindings/scripts/test/JS/JSTestNondeterministic.cpp trunk/Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp trunk/Source/WebCore/bindings/scripts/test/JS/JSTestOverloadedConstructors.cpp trunk/Source/WebCore/bindings/scripts/test/JS/JSTestTypedefs.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (183656 => 183657) --- trunk/Source/WebCore/ChangeLog 2015-05-01 00:06:48 UTC (rev 183656) +++ trunk/Source/WebCore/ChangeLog 2015-05-01 00:34:24 UTC (rev 183657) @@ -1,3 +1,59 @@ +2015-04-30 Jon Honeycutt + +Rebaseline bindings tests results after r183648. + +Unreviewed. + +* bindings/scripts/test/JS/JSTestActiveDOMObject.cpp: +(WebCore::jsTestActiveDOMObjectPrototypeFunctionPostMessage): +* bindings/scripts/test/JS/JSTestCustomNamedGetter.cpp: +(WebCore::jsTestCustomNamedGetterPrototypeFunctionAnotherFunction): +* bindings/scripts/test/JS/JSTestInterface.cpp: +(WebCore::JSTestInterfaceConstructor::constructJSTestInterface): +(WebCore::setJSTestInterfaceConstructorImplementsStaticAttr): +(WebCore::setJSTestInterfaceImplementsStr2): +(WebCore::setJSTestInterfaceConstructorSupplementalStaticAttr): +(WebCore::setJSTestInterfaceSupplementalStr2): +(WebCore::jsTestInterfacePrototypeFunctionImplementsMethod2): +(WebCore::jsTestInterfacePrototypeFunctionSupplementalMethod2): +* bindings/scripts/test/JS/JSTestNamedConstructor.cpp: +(WebCore::JSTestNamedConstructorNamedConstructor::constructJSTest
[webkit-changes] [183656] trunk/Source/JavaScriptCore
Title: [183656] trunk/Source/_javascript_Core Revision 183656 Author fpi...@apple.com Date 2015-04-30 17:06:48 -0700 (Thu, 30 Apr 2015) Log Message Move all of the branchIs helpers from SpeculativeJIT into AssemblyHelpers https://bugs.webkit.org/show_bug.cgi?id=144462 Reviewed by Geoffrey Garen and Mark Lam. At some point we started adding representation-agnostic helpers for doing common type tests. We added some in SpeculativeJIT, and then some in AssemblyHelpers. Prior to this change, they had overlapping powers, though SpeculativeJIT was a bit better. This removes SpeculativeJIT's helpers and strengthens AssemblyHelpers' helpers. This is better because now all of these helpers can be used in all of the assembly-based JITs, not just the DFG. It also settles on what I find to be a slightly better naming convention. For example where we previously would have said branchIsString, now we say branchIfString. Similarly, branchNotString becomes branchIfNotString. * dfg/DFGSpeculativeJIT.cpp: (JSC::DFG::SpeculativeJIT::compilePeepHoleObjectEquality): (JSC::DFG::SpeculativeJIT::compileValueToInt32): (JSC::DFG::SpeculativeJIT::compileInstanceOfForObject): (JSC::DFG::SpeculativeJIT::compileInstanceOf): (JSC::DFG::SpeculativeJIT::compileStringToUntypedEquality): (JSC::DFG::SpeculativeJIT::compileStringIdentToNotStringVarEquality): (JSC::DFG::SpeculativeJIT::compileGetByValOnScopedArguments): (JSC::DFG::SpeculativeJIT::compileToStringOrCallStringConstructorOnCell): (JSC::DFG::SpeculativeJIT::speculateObject): (JSC::DFG::SpeculativeJIT::speculateObjectOrOther): (JSC::DFG::SpeculativeJIT::speculateString): (JSC::DFG::SpeculativeJIT::speculateNotStringVar): (JSC::DFG::SpeculativeJIT::speculateNotCell): (JSC::DFG::SpeculativeJIT::speculateOther): (JSC::DFG::SpeculativeJIT::emitSwitchChar): (JSC::DFG::SpeculativeJIT::emitSwitchString): (JSC::DFG::SpeculativeJIT::branchIsObject): Deleted. (JSC::DFG::SpeculativeJIT::branchNotObject): Deleted. (JSC::DFG::SpeculativeJIT::branchIsString): Deleted. (JSC::DFG::SpeculativeJIT::branchNotString): Deleted. * dfg/DFGSpeculativeJIT.h: * dfg/DFGSpeculativeJIT32_64.cpp: (JSC::DFG::SpeculativeJIT::nonSpeculativeNonPeepholeCompareNull): (JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeBranchNull): (JSC::DFG::SpeculativeJIT::emitCall): (JSC::DFG::SpeculativeJIT::fillSpeculateCell): (JSC::DFG::SpeculativeJIT::compileObjectEquality): (JSC::DFG::SpeculativeJIT::compileObjectToObjectOrOtherEquality): (JSC::DFG::SpeculativeJIT::compilePeepHoleObjectToObjectOrOtherEquality): (JSC::DFG::SpeculativeJIT::compileObjectOrOtherLogicalNot): (JSC::DFG::SpeculativeJIT::emitObjectOrOtherBranch): (JSC::DFG::SpeculativeJIT::compile): (JSC::DFG::SpeculativeJIT::branchIsCell): Deleted. (JSC::DFG::SpeculativeJIT::branchNotCell): Deleted. (JSC::DFG::SpeculativeJIT::branchIsOther): Deleted. (JSC::DFG::SpeculativeJIT::branchNotOther): Deleted. * dfg/DFGSpeculativeJIT64.cpp: (JSC::DFG::SpeculativeJIT::nonSpeculativeNonPeepholeCompareNull): (JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeBranchNull): (JSC::DFG::SpeculativeJIT::fillSpeculateCell): (JSC::DFG::SpeculativeJIT::compileObjectEquality): (JSC::DFG::SpeculativeJIT::compileObjectToObjectOrOtherEquality): (JSC::DFG::SpeculativeJIT::compilePeepHoleObjectToObjectOrOtherEquality): (JSC::DFG::SpeculativeJIT::compileObjectOrOtherLogicalNot): (JSC::DFG::SpeculativeJIT::emitObjectOrOtherBranch): (JSC::DFG::SpeculativeJIT::compile): (JSC::DFG::SpeculativeJIT::writeBarrier): (JSC::DFG::SpeculativeJIT::branchIsCell): Deleted. (JSC::DFG::SpeculativeJIT::branchNotCell): Deleted. (JSC::DFG::SpeculativeJIT::branchIsOther): Deleted. (JSC::DFG::SpeculativeJIT::branchNotOther): Deleted. * jit/AssemblyHelpers.h: (JSC::AssemblyHelpers::branchIfCell): (JSC::AssemblyHelpers::branchIfOther): (JSC::AssemblyHelpers::branchIfNotOther): (JSC::AssemblyHelpers::branchIfObject): (JSC::AssemblyHelpers::branchIfNotObject): (JSC::AssemblyHelpers::branchIfType): (JSC::AssemblyHelpers::branchIfNotType): (JSC::AssemblyHelpers::branchIfString): (JSC::AssemblyHelpers::branchIfNotString): (JSC::AssemblyHelpers::branchIfSymbol): (JSC::AssemblyHelpers::branchIfNotSymbol): (JSC::AssemblyHelpers::branchIfFunction): (JSC::AssemblyHelpers::branchIfNotFunction): (JSC::AssemblyHelpers::branchIfEmpty): (JSC::AssemblyHelpers::branchIsEmpty): Deleted. (JSC::AssemblyHelpers::branchIfCellNotObject): Deleted. * jit/JITPropertyAccess.cpp: (JSC::JIT::emitScopedArgumentsGetByVal): Modified Paths trunk/Source/_javascript_Core/ChangeLog trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.cpp trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.h trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT32_64.cpp trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT64.cpp trunk/Source/_javascript_Core/jit/AssemblyHelpers.h trunk/Source/_javascript_Core/jit/JITPropertyAccess.cpp Diff Modified: trunk/Source/_javascript_Core/ChangeLog (183655 => 183656) --- trunk/Source/_javascript_Core/Cha
[webkit-changes] [183655] trunk/Source
Title: [183655] trunk/Source Revision 183655 Author simon.fra...@apple.com Date 2015-04-30 16:44:49 -0700 (Thu, 30 Apr 2015) Log Message Fixed elements end up in the middle of the view with pageScale < 1 https://bugs.webkit.org/show_bug.cgi?id=144428 rdar://problem/20404982 Reviewed by Tim Horton. Source/WebCore: When pageScale is < 1, we used fixed layout mode, and FrameView::fixedElementsLayoutRelativeToFrame() returns true. However, the scrolling thread was calling the static scrollOffsetForFixedPosition() hardcoding 'false' for this parameter. Fix by sending the value of fixedElementsLayoutRelativeToFrame over to the scrolling thread, so we can use it when doing scrolling-thread fixed position stuff. Not testable. * page/scrolling/AsyncScrollingCoordinator.cpp: (WebCore::AsyncScrollingCoordinator::frameViewLayoutUpdated): * page/scrolling/ScrollingStateFrameScrollingNode.cpp: (WebCore::ScrollingStateFrameScrollingNode::ScrollingStateFrameScrollingNode): (WebCore::ScrollingStateFrameScrollingNode::setFixedElementsLayoutRelativeToFrame): * page/scrolling/ScrollingStateFrameScrollingNode.h: * page/scrolling/ScrollingTreeFrameScrollingNode.cpp: (WebCore::ScrollingTreeFrameScrollingNode::ScrollingTreeFrameScrollingNode): (WebCore::ScrollingTreeFrameScrollingNode::updateBeforeChildren): * page/scrolling/ScrollingTreeFrameScrollingNode.h: (WebCore::ScrollingTreeFrameScrollingNode::fixedElementsLayoutRelativeToFrame): (WebCore::ScrollingTreeFrameScrollingNode::shouldUpdateScrollLayerPositionSynchronously): Deleted. * page/scrolling/mac/ScrollingTreeFrameScrollingNodeMac.mm: (WebCore::ScrollingTreeFrameScrollingNodeMac::setScrollLayerPosition): Source/WebKit2: Encode/decode fixedElementsLayoutRelativeToFrame. * Shared/Scrolling/RemoteScrollingCoordinatorTransaction.cpp: (ArgumentCoder::encode): (ArgumentCoder::decode): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/page/scrolling/AsyncScrollingCoordinator.cpp trunk/Source/WebCore/page/scrolling/ScrollingStateFrameScrollingNode.cpp trunk/Source/WebCore/page/scrolling/ScrollingStateFrameScrollingNode.h trunk/Source/WebCore/page/scrolling/ScrollingTreeFrameScrollingNode.cpp trunk/Source/WebCore/page/scrolling/ScrollingTreeFrameScrollingNode.h trunk/Source/WebCore/page/scrolling/ios/ScrollingTreeFrameScrollingNodeIOS.mm trunk/Source/WebCore/page/scrolling/mac/ScrollingTreeFrameScrollingNodeMac.mm trunk/Source/WebCore/platform/graphics/mac/WebLayer.mm trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/Shared/Scrolling/RemoteScrollingCoordinatorTransaction.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (183654 => 183655) --- trunk/Source/WebCore/ChangeLog 2015-04-30 23:35:26 UTC (rev 183654) +++ trunk/Source/WebCore/ChangeLog 2015-04-30 23:44:49 UTC (rev 183655) @@ -1,3 +1,35 @@ +2015-04-30 Simon Fraser + +Fixed elements end up in the middle of the view with pageScale < 1 +https://bugs.webkit.org/show_bug.cgi?id=144428 +rdar://problem/20404982 + +Reviewed by Tim Horton. + +When pageScale is < 1, we used fixed layout mode, and FrameView::fixedElementsLayoutRelativeToFrame() +returns true. However, the scrolling thread was calling the static scrollOffsetForFixedPosition() +hardcoding 'false' for this parameter. + +Fix by sending the value of fixedElementsLayoutRelativeToFrame over to the scrolling thread, +so we can use it when doing scrolling-thread fixed position stuff. + +Not testable. + +* page/scrolling/AsyncScrollingCoordinator.cpp: +(WebCore::AsyncScrollingCoordinator::frameViewLayoutUpdated): +* page/scrolling/ScrollingStateFrameScrollingNode.cpp: +(WebCore::ScrollingStateFrameScrollingNode::ScrollingStateFrameScrollingNode): +(WebCore::ScrollingStateFrameScrollingNode::setFixedElementsLayoutRelativeToFrame): +* page/scrolling/ScrollingStateFrameScrollingNode.h: +* page/scrolling/ScrollingTreeFrameScrollingNode.cpp: +(WebCore::ScrollingTreeFrameScrollingNode::ScrollingTreeFrameScrollingNode): +(WebCore::ScrollingTreeFrameScrollingNode::updateBeforeChildren): +* page/scrolling/ScrollingTreeFrameScrollingNode.h: +(WebCore::ScrollingTreeFrameScrollingNode::fixedElementsLayoutRelativeToFrame): +(WebCore::ScrollingTreeFrameScrollingNode::shouldUpdateScrollLayerPositionSynchronously): Deleted. +* page/scrolling/mac/ScrollingTreeFrameScrollingNodeMac.mm: +(WebCore::ScrollingTreeFrameScrollingNodeMac::setScrollLayerPosition): + 2015-04-30 Beth Dakin Remove invalid assertion from MouseEvent::create() Modified: trunk/Source/WebCore/page/scrolling/AsyncScrollingCoordinator.cpp (183654 => 183655) --- trunk/Source/WebCore/page/scrolling/AsyncScrollingCoordinator.cpp 2015-04-30 23:35:26 UTC (rev 183654) +++ trunk/Source/WebCore/page/scrolling/AsyncScrollingCoordinator.cpp 2015-04-30 23:44:49 UTC (rev 183655)
[webkit-changes] [183654] trunk/Source/WebCore
Title: [183654] trunk/Source/WebCore
Revision 183654
Author bda...@apple.com
Date 2015-04-30 16:35:26 -0700 (Thu, 30 Apr 2015)
Log Message
Remove invalid assertion from MouseEvent::create()
https://bugs.webkit.org/show_bug.cgi?id=144477
Reviewed by Tim Horton.
mouseforcechanged events and mouseforcewillbegin trigger this assertion. The
assertion does not seem valuable, so rather than changing it, just remove it.
* dom/MouseEvent.cpp:
(WebCore::MouseEvent::create):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/MouseEvent.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (183653 => 183654)
--- trunk/Source/WebCore/ChangeLog 2015-04-30 23:26:11 UTC (rev 183653)
+++ trunk/Source/WebCore/ChangeLog 2015-04-30 23:35:26 UTC (rev 183654)
@@ -1,3 +1,15 @@
+2015-04-30 Beth Dakin
+
+Remove invalid assertion from MouseEvent::create()
+https://bugs.webkit.org/show_bug.cgi?id=144477
+
+Reviewed by Tim Horton.
+
+mouseforcechanged events and mouseforcewillbegin trigger this assertion. The
+assertion does not seem valuable, so rather than changing it, just remove it.
+* dom/MouseEvent.cpp:
+(WebCore::MouseEvent::create):
+
2015-04-30 Dean Jackson
-apple-system-font-monospaced-numbers doesn't work on iOS
Modified: trunk/Source/WebCore/dom/MouseEvent.cpp (183653 => 183654)
--- trunk/Source/WebCore/dom/MouseEvent.cpp 2015-04-30 23:26:11 UTC (rev 183653)
+++ trunk/Source/WebCore/dom/MouseEvent.cpp 2015-04-30 23:35:26 UTC (rev 183654)
@@ -54,8 +54,6 @@
Ref MouseEvent::create(const AtomicString& eventType, PassRefPtr view, const PlatformMouseEvent& event, int detail, PassRefPtr relatedTarget)
{
-ASSERT(event.type() == PlatformEvent::MouseMoved || event.button() != NoButton);
-
bool isMouseEnterOrLeave = eventType == eventNames().mouseenterEvent || eventType == eventNames().mouseleaveEvent;
bool isCancelable = eventType != eventNames().mousemoveEvent && !isMouseEnterOrLeave;
bool canBubble = !isMouseEnterOrLeave;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [183653] trunk
Title: [183653] trunk
Revision 183653
Author d...@apple.com
Date 2015-04-30 16:26:11 -0700 (Thu, 30 Apr 2015)
Log Message
-apple-system-font-monospaced-numbers doesn't work on iOS
https://bugs.webkit.org/show_bug.cgi?id=144478
Reviewed by Brent Fulgham.
Source/WebCore:
Make sure to start from the system font descriptor when
asking for a monospaced numeric alternate.
Test: platform/ios-simulator/fast/text/system-monospaced-numbers.html
* platform/graphics/ios/FontCacheIOS.mm:
(WebCore::createCTFontWithFamilyNameAndWeight):
LayoutTests:
A test that draws two lines of different numbers and checks
they are the same width.
* platform/ios-simulator/fast/text/system-monospaced-numbers-expected.txt: Added.
* platform/ios-simulator/fast/text/system-monospaced-numbers.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/ios/FontCacheIOS.mm
Added Paths
trunk/LayoutTests/platform/ios-simulator/fast/text/system-monospaced-numbers-expected.txt
trunk/LayoutTests/platform/ios-simulator/fast/text/system-monospaced-numbers.html
Diff
Modified: trunk/LayoutTests/ChangeLog (183652 => 183653)
--- trunk/LayoutTests/ChangeLog 2015-04-30 23:16:22 UTC (rev 183652)
+++ trunk/LayoutTests/ChangeLog 2015-04-30 23:26:11 UTC (rev 183653)
@@ -1,3 +1,17 @@
+2015-04-30 Dean Jackson
+
+-apple-system-font-monospaced-numbers doesn't work on iOS
+https://bugs.webkit.org/show_bug.cgi?id=144478
+
+
+Reviewed by Brent Fulgham.
+
+A test that draws two lines of different numbers and checks
+they are the same width.
+
+* platform/ios-simulator/fast/text/system-monospaced-numbers-expected.txt: Added.
+* platform/ios-simulator/fast/text/system-monospaced-numbers.html: Added.
+
2015-04-30 Joseph Pecoraro
Unreviewed, ios-simulator gardening
Added: trunk/LayoutTests/platform/ios-simulator/fast/text/system-monospaced-numbers-expected.txt (0 => 183653)
--- trunk/LayoutTests/platform/ios-simulator/fast/text/system-monospaced-numbers-expected.txt (rev 0)
+++ trunk/LayoutTests/platform/ios-simulator/fast/text/system-monospaced-numbers-expected.txt 2015-04-30 23:26:11 UTC (rev 183653)
@@ -0,0 +1,7 @@
+These next two lines should be the same width
+
+00:11:22.33
+
+11:11:11.11
+
+PASS: widths were the same
Property changes on: trunk/LayoutTests/platform/ios-simulator/fast/text/system-monospaced-numbers-expected.txt
___
Added: svn:mime-type
Added: svn:keywords
Added: svn:eol-style
Added: trunk/LayoutTests/platform/ios-simulator/fast/text/system-monospaced-numbers.html (0 => 183653)
--- trunk/LayoutTests/platform/ios-simulator/fast/text/system-monospaced-numbers.html (rev 0)
+++ trunk/LayoutTests/platform/ios-simulator/fast/text/system-monospaced-numbers.html 2015-04-30 23:26:11 UTC (rev 183653)
@@ -0,0 +1,31 @@
+
+span {
+font-family: -apple-system-font-monospaced-numbers;
+font-size: 24px
+}
+
+
+if (window.testRunner)
+window.testRunner.dumpAsText();
+
+window.addEventListener("load", run, false);
+
+function run() {
+var a = document.getElementById("a");
+var b = document.getElementById("b");
+var result = document.getElementById("result");
+
+var aRect = a.getBoundingClientRect();
+var bRect = b.getBoundingClientRect();
+
+if (aRect.width == bRect.width)
+result.textContent = "PASS: widths were the same";
+else
+result.textContent = "FAIL: widths were not the same";
+}
+
+These next two lines should be the same width
+00:11:22.33
+11:11:11.11
+
+
Property changes on: trunk/LayoutTests/platform/ios-simulator/fast/text/system-monospaced-numbers.html
___
Added: svn:mime-type
Added: svn:keywords
Added: svn:eol-style
Modified: trunk/Source/WebCore/ChangeLog (183652 => 183653)
--- trunk/Source/WebCore/ChangeLog 2015-04-30 23:16:22 UTC (rev 183652)
+++ trunk/Source/WebCore/ChangeLog 2015-04-30 23:26:11 UTC (rev 183653)
@@ -1,3 +1,19 @@
+2015-04-30 Dean Jackson
+
+-apple-system-font-monospaced-numbers doesn't work on iOS
+https://bugs.webkit.org/show_bug.cgi?id=144478
+
+
+Reviewed by Brent Fulgham.
+
+Make sure to start from the system font descriptor when
+asking for a monospaced numeric alternate.
+
+Test: platform/ios-simulator/fast/text/system-monospaced-numbers.html
+
+* platform/graphics/ios/FontCacheIOS.mm:
+(WebCore::createCTFontWithFamilyNameAndWeight):
+
2015-04-30 Oliver Hunt
DOM bindings should not be using a reference type to point to a temporary object
Modified: trunk/Source/WebCore/platform/graphics/ios/FontCacheIOS.mm (183652 => 183653)
--- trunk/Source/WebCore/platform/graphics/ios/FontCacheIOS.mm 2015-04-30 23:16:22 UTC (rev 183652)
[webkit-changes] [183652] trunk/LayoutTests
Title: [183652] trunk/LayoutTests Revision 183652 Author joep...@webkit.org Date 2015-04-30 16:16:22 -0700 (Thu, 30 Apr 2015) Log Message Unreviewed, ios-simulator gardening * Address linter warnings. * Unskip some tests that pass. * More generically skip unsupported iOS features. * Address FIXMEs. * platform/ios-simulator-wk1/TestExpectations: * platform/ios-simulator-wk2/TestExpectations: * platform/ios-simulator/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/ios-simulator/TestExpectations trunk/LayoutTests/platform/ios-simulator-wk1/TestExpectations trunk/LayoutTests/platform/ios-simulator-wk2/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (183651 => 183652) --- trunk/LayoutTests/ChangeLog 2015-04-30 23:13:52 UTC (rev 183651) +++ trunk/LayoutTests/ChangeLog 2015-04-30 23:16:22 UTC (rev 183652) @@ -1,3 +1,16 @@ +2015-04-30 Joseph Pecoraro + +Unreviewed, ios-simulator gardening + +* Address linter warnings. +* Unskip some tests that pass. +* More generically skip unsupported iOS features. +* Address FIXMEs. + +* platform/ios-simulator-wk1/TestExpectations: +* platform/ios-simulator-wk2/TestExpectations: +* platform/ios-simulator/TestExpectations: + 2015-04-30 Filip Pizlo js/regress/is-string-fold-tricky.html and js/regress/is-string-fold.html are crashing Modified: trunk/LayoutTests/platform/ios-simulator/TestExpectations (183651 => 183652) --- trunk/LayoutTests/platform/ios-simulator/TestExpectations 2015-04-30 23:13:52 UTC (rev 183651) +++ trunk/LayoutTests/platform/ios-simulator/TestExpectations 2015-04-30 23:16:22 UTC (rev 183652) @@ -82,14 +82,8 @@ # webkit.org/b/61138, webkit.org/b/84893, webkit.org/b/133321 http/tests/w3c/webperf -# FIXME: Move this skip list to ios-simulator-wk1/TestExpectations. -# IndexedDB is not supported on iOS WK1. -storage/indexeddb -inspector-protocol/indexeddb/basics.html -crypto/subtle/rsa-indexeddb-non-exportable.html -crypto/subtle/rsa-indexeddb.html -fast/history/page-cache-indexed-closed-db.html -fast/history/page-cache-indexed-opened-db.html +# IndexedDB tests have numerous unexpected failures on iOS +webkit.org/b/144475 storage/indexeddb # Quota API is not supported on iOS storage/domstorage/quota.html @@ -102,15 +96,8 @@ storage/websql/quota-tracking.html # iOS doesn't have a local inspector -inspector/event-listener-set.html -inspector/protocol-promise-result.html -inspector/event-listener.html -inspector/test-harness-trivially-works.html -inspector/model/parse-script-syntax-tree.html -inspector/page/main-frame-resource.html -inspector/css/selector-specificity.html -inspector/css/matched-style-properties.html -inspector/css/pseudo-element-matches.html +inspector/ [ Skip ] +http/tests/inspector/ [ Skip ] # ShadowDOM is not enabled on iOS fast/dom/shadow @@ -311,7 +298,6 @@ webkit.org/b/137530 canvas/philip/tests/2d.fillStyle.parse.rgba-eof.html [ Failure ] webkit.org/b/137530 canvas/philip/tests/2d.missingargs.html [ Failure ] webkit.org/b/137530 canvas/philip/tests/2d.path.rect.winding.html [ Failure ] -webkit.org/b/137530 canvas/philip/tests/2d.pattern.image.incomplete.omitted.html [ Failure ] webkit.org/b/137530 canvas/philip/tests/2d.text.draw.baseline.bottom.html [ Failure ] webkit.org/b/137530 canvas/philip/tests/2d.text.draw.baseline.hanging.html [ Failure ] webkit.org/b/137530 canvas/philip/tests/2d.text.draw.baseline.ideographic.html [ Failure ] @@ -1292,15 +1278,6 @@ tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_cell_sibling.html [ Failure ] tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_row.html [ Failure ] - -# ASSERT(structureID && structureID < m_capacity) fails in JSC::StructureIDTable::get -inspector-protocol/debugger/setBreakpoint-dfg.html - -# Inspector protocol tests that fail: -inspector-protocol/debugger/nested-inspectors.html [ Failure ] -inspector-protocol/debugger/regress-133182.html [ Failure ] -inspector-protocol/dom/getAccessibilityPropertiesForNode.html [ Failure ] - # Scrolling coordinator tests that fail: scrollingcoordinator/non-fast-scrollable-region-scaled-iframe.html [ Failure ] scrollingcoordinator/non-fast-scrollable-region-transformed-iframe.html [ Failure ] @@ -2623,6 +2600,4 @@ webkit.org/b/138970 fast/css/line-height-text-autosizing.html [ Pass ] # Skipped for mac as well: -webkit.org/b/141118 inspector/css/selector-dynamic-specificity.html [ Skip ] -webkit.org/b/141601 inspector/css/stylesheet-with-mutations.html [ Skip ] webkit.org/b/129758 js/dom/create-lots-of-workers.html [ Skip ] Modified: trunk/LayoutTests/platform/ios-simulator-wk1/TestExpectations (183651 => 183652) --- trunk/LayoutTests/platform/ios-simulator-wk1/TestExpectations 2015-04-30 23:13:52 UTC (rev 183651) +++ trunk/LayoutTests/platform/ios-simulator-wk1/TestExpectations 2015-04-30 23:16:22 UTC (rev 183652) @@ -1439,3 +
[webkit-changes] [183651] trunk/Tools
Title: [183651] trunk/Tools Revision 183651 Author bfulg...@apple.com Date 2015-04-30 16:13:52 -0700 (Thu, 30 Apr 2015) Log Message Provide a runtime flag to run-webkit-tests that shows the test view https://bugs.webkit.org/show_bug.cgi?id=144079. Reviewed by Dean Jackson. Add a new flag (--show-webview) that causes DumpRenderTree and WebKitTestRunner to display their WebViews on-screen. This can be used when running tests via the "--additional-drt-flag" option: --additional-drt-flag="--show-webview" * DumpRenderTree/mac/DumpRenderTree.mm: (createWebViewAndOffscreenWindow): Use an on-screen window rect if the user passed the '--show-webview' flag. (initializeGlobalsFromCommandLineOptions): Recognize the "--show-webview" option. * WebKitTestRunner/Options.cpp: (WTR::Options::Options): (WTR::handleOptionShowWebView): (WTR::OptionsHandler::OptionsHandler): Recognize the new "--show-webview" option. * WebKitTestRunner/Options.h: * WebKitTestRunner/TestController.cpp: (WTR::TestController::TestController): (WTR::TestController::initialize): Use value of 'shouldShowWebView' from the Options bundle. * WebKitTestRunner/TestController.h: (WTR::TestController::shouldShowWebView): * WebKitTestRunner/mac/PlatformWebViewMac.mm: (WTR::PlatformWebView::PlatformWebView): Retrieve the value of the 'ShouldShowWebView' key from the options dictionary. If it is true, display the web view while running the test. Modified Paths trunk/Tools/ChangeLog trunk/Tools/DumpRenderTree/mac/DumpRenderTree.mm trunk/Tools/WebKitTestRunner/Options.cpp trunk/Tools/WebKitTestRunner/Options.h trunk/Tools/WebKitTestRunner/TestController.cpp trunk/Tools/WebKitTestRunner/TestController.h trunk/Tools/WebKitTestRunner/mac/PlatformWebViewMac.mm Diff Modified: trunk/Tools/ChangeLog (183650 => 183651) --- trunk/Tools/ChangeLog 2015-04-30 23:02:33 UTC (rev 183650) +++ trunk/Tools/ChangeLog 2015-04-30 23:13:52 UTC (rev 183651) @@ -1,3 +1,34 @@ +2015-04-30 Brent Fulgham + +Provide a runtime flag to run-webkit-tests that shows the test view +https://bugs.webkit.org/show_bug.cgi?id=144079. + +Reviewed by Dean Jackson. + +Add a new flag (--show-webview) that causes DumpRenderTree and WebKitTestRunner to display +their WebViews on-screen. This can be used when running tests via the "--additional-drt-flag" +option: + +--additional-drt-flag="--show-webview" + +* DumpRenderTree/mac/DumpRenderTree.mm: +(createWebViewAndOffscreenWindow): Use an on-screen window rect if the user passed the +'--show-webview' flag. +(initializeGlobalsFromCommandLineOptions): Recognize the "--show-webview" option. +* WebKitTestRunner/Options.cpp: +(WTR::Options::Options): +(WTR::handleOptionShowWebView): +(WTR::OptionsHandler::OptionsHandler): Recognize the new "--show-webview" option. +* WebKitTestRunner/Options.h: +* WebKitTestRunner/TestController.cpp: +(WTR::TestController::TestController): +(WTR::TestController::initialize): Use value of 'shouldShowWebView' from the Options bundle. +* WebKitTestRunner/TestController.h: +(WTR::TestController::shouldShowWebView): +* WebKitTestRunner/mac/PlatformWebViewMac.mm: +(WTR::PlatformWebView::PlatformWebView): Retrieve the value of the 'ShouldShowWebView' key from the +options dictionary. If it is true, display the web view while running the test. + 2015-04-30 Alexey Proskuryakov r183355 didn't trigger Mac tests Modified: trunk/Tools/DumpRenderTree/mac/DumpRenderTree.mm (183650 => 183651) --- trunk/Tools/DumpRenderTree/mac/DumpRenderTree.mm 2015-04-30 23:02:33 UTC (rev 183650) +++ trunk/Tools/DumpRenderTree/mac/DumpRenderTree.mm 2015-04-30 23:13:52 UTC (rev 183651) @@ -1,5 +1,5 @@ /* - * Copyright (C) 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights reserved. + * Copyright (C) 2005-2009, 2015 Apple Inc. All rights reserved. * (C) 2007 Graham Dennis (graham.den...@gmail.com) * * Redistribution and use in source and binary forms, with or without @@ -205,6 +205,7 @@ static int forceComplexText; static int useAcceleratedDrawing; static int gcBetweenTests; +static int showWebView = NO; static BOOL printSeparators; static RetainPtr persistentUserStyleSheetLocation; static std::set allowedHosts; @@ -784,13 +785,16 @@ // To make things like certain NSViews, dragging, and plug-ins work, put the WebView a window, but put it off-screen so you don't see it. // Put it at -1, -1 in "flipped coordinates", since WebCore and the DOM use flipped coordinates. NSScreen *firstScreen = [[NSScreen screens] firstObject]; -NSRect windowRect = NSOffsetRect(rect, -1, [firstScreen frame].size.height - rect.size.height + 1); +NSRect windowRect = (showWebView) ? NSOffsetRect(rect, 100, 100) : NSOffsetRect(rect, -1, [firstScreen frame].size.height - rect.size
[webkit-changes] [183650] trunk
Title: [183650] trunk
Revision 183650
Author fpi...@apple.com
Date 2015-04-30 16:02:33 -0700 (Thu, 30 Apr 2015)
Log Message
js/regress/is-string-fold-tricky.html and js/regress/is-string-fold.html are crashing
https://bugs.webkit.org/show_bug.cgi?id=144463
Reviewed by Benjamin Poulain.
Source/_javascript_Core:
Fixup phase was super cleverly folding an IsString(@x) when @x is predicted SpecString
into a Check(String:@x) followed by JSConstant(true). Then in these tests the
ValueAdd(IsString(@x), @stuff) would try to turn this into an integer add by cleverly
converting the boolean into an integer. But as part of doing that, it would try to
short-circuit any profiling by leveraging the fact that the IsString is now a constant,
and it would try to figure out if the addition might overflow. Part of that logic
involved checking if the immediate is either a boolean or a sufficiently small integer.
But: it would check if it's a sufficiently small integer before checking if it was a
boolean, so it would try to call asNumber() on the boolean.
All of this cleverness was very deliberate, but apparently the @stuff + booleanConstant
case was previously never hit until I wrote these tests, and so we never knew that
calling asNumber() on a boolean was wrong.
The fix is super simple: the _expression_ should just check for boolean first.
This bug was benign in release builds. JSValue::asNumber() on a boolean would return
garbage, and that's OK, since we'd take the boolean case anyway.
* dfg/DFGGraph.h:
(JSC::DFG::Graph::addImmediateShouldSpeculateInt32):
LayoutTests:
Unskip now that the bug is fixed.
* TestExpectations:
* js/regress/script-tests/is-string-fold-tricky.js:
* js/regress/script-tests/is-string-fold.js:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/TestExpectations
trunk/LayoutTests/js/regress/script-tests/is-string-fold-tricky.js
trunk/LayoutTests/js/regress/script-tests/is-string-fold.js
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/dfg/DFGGraph.h
Diff
Modified: trunk/LayoutTests/ChangeLog (183649 => 183650)
--- trunk/LayoutTests/ChangeLog 2015-04-30 22:57:28 UTC (rev 183649)
+++ trunk/LayoutTests/ChangeLog 2015-04-30 23:02:33 UTC (rev 183650)
@@ -1,3 +1,16 @@
+2015-04-30 Filip Pizlo
+
+js/regress/is-string-fold-tricky.html and js/regress/is-string-fold.html are crashing
+https://bugs.webkit.org/show_bug.cgi?id=144463
+
+Reviewed by Benjamin Poulain.
+
+Unskip now that the bug is fixed.
+
+* TestExpectations:
+* js/regress/script-tests/is-string-fold-tricky.js:
+* js/regress/script-tests/is-string-fold.js:
+
2015-04-30 Brady Eidson
_javascript_ using WebSQL can create their own WebKit info table.
Modified: trunk/LayoutTests/TestExpectations (183649 => 183650)
--- trunk/LayoutTests/TestExpectations 2015-04-30 22:57:28 UTC (rev 183649)
+++ trunk/LayoutTests/TestExpectations 2015-04-30 23:02:33 UTC (rev 183650)
@@ -527,6 +527,3 @@
webkit.org/b/143778 streams/reference-implementation/readable-stream.html [ Pass Failure ]
webkit.org/b/144258 [ Debug ] js/class-syntax-semicolon.html [ Skip ]
-
-webkit.org/b/144463 js/regress/is-string-fold.html [ Skip ]
-webkit.org/b/144463 js/regress/is-string-fold-tricky.html [ Skip ]
Modified: trunk/LayoutTests/js/regress/script-tests/is-string-fold-tricky.js (183649 => 183650)
--- trunk/LayoutTests/js/regress/script-tests/is-string-fold-tricky.js 2015-04-30 22:57:28 UTC (rev 183649)
+++ trunk/LayoutTests/js/regress/script-tests/is-string-fold-tricky.js 2015-04-30 23:02:33 UTC (rev 183650)
@@ -1,6 +1,3 @@
-// webkit.org/b/144463
-//@ skip
-
var object = {};
(function() {
var result = 0;
Modified: trunk/LayoutTests/js/regress/script-tests/is-string-fold.js (183649 => 183650)
--- trunk/LayoutTests/js/regress/script-tests/is-string-fold.js 2015-04-30 22:57:28 UTC (rev 183649)
+++ trunk/LayoutTests/js/regress/script-tests/is-string-fold.js 2015-04-30 23:02:33 UTC (rev 183650)
@@ -1,6 +1,3 @@
-// webkit.org/b/144463
-//@ skip
-
var value1 = "hello";
var value2 = 42;
(function() {
Modified: trunk/Source/_javascript_Core/ChangeLog (183649 => 183650)
--- trunk/Source/_javascript_Core/ChangeLog 2015-04-30 22:57:28 UTC (rev 183649)
+++ trunk/Source/_javascript_Core/ChangeLog 2015-04-30 23:02:33 UTC (rev 183650)
@@ -1,5 +1,34 @@
2015-04-30 Filip Pizlo
+js/regress/is-string-fold-tricky.html and js/regress/is-string-fold.html are crashing
+https://bugs.webkit.org/show_bug.cgi?id=144463
+
+Reviewed by Benjamin Poulain.
+
+Fixup phase was super cleverly folding an IsString(@x) when @x is predicted SpecString
+into a Check(String:@x) followed by JSConstant(true). Then in these tests the
+ValueAdd(IsString(@x), @stuff) would try to turn this into an integer add by cleverly
+converting the boolean into an integer. But as part
[webkit-changes] [183649] trunk/Source/WebCore
Title: [183649] trunk/Source/WebCore
Revision 183649
Author beid...@apple.com
Date 2015-04-30 15:57:28 -0700 (Thu, 30 Apr 2015)
Log Message
Build fix after r183646 for less enlightened platforms.
Unreviewed.
* Modules/webdatabase/DatabaseBackendBase.cpp:
(WebCore::fullyQualifiedInfoTableName): Windows doesn’t have stpcpy :(
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/webdatabase/DatabaseBackendBase.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (183648 => 183649)
--- trunk/Source/WebCore/ChangeLog 2015-04-30 22:40:30 UTC (rev 183648)
+++ trunk/Source/WebCore/ChangeLog 2015-04-30 22:57:28 UTC (rev 183649)
@@ -16,6 +16,15 @@
2015-04-30 Brady Eidson
+Build fix after r183646 for less enlightened platforms.
+
+Unreviewed.
+
+* Modules/webdatabase/DatabaseBackendBase.cpp:
+(WebCore::fullyQualifiedInfoTableName): Windows doesn’t have stpcpy :(
+
+2015-04-30 Brady Eidson
+
_javascript_ using WebSQL can create their own WebKit info table.
and https://bugs.webkit.org/show_bug.cgi?id=144466
Modified: trunk/Source/WebCore/Modules/webdatabase/DatabaseBackendBase.cpp (183648 => 183649)
--- trunk/Source/WebCore/Modules/webdatabase/DatabaseBackendBase.cpp 2015-04-30 22:40:30 UTC (rev 183648)
+++ trunk/Source/WebCore/Modules/webdatabase/DatabaseBackendBase.cpp 2015-04-30 22:57:28 UTC (rev 183649)
@@ -96,8 +96,8 @@
static std::once_flag onceFlag;
std::call_once(onceFlag, []{
-char* newDestination = stpcpy(qualifiedName, qualifier);
-strcpy(newDestination, unqualifiedInfoTableName);
+strcpy(qualifiedName, qualifier);
+strcpy(qualifiedName + strlen(qualifier), unqualifiedInfoTableName);
});
return qualifiedName;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [183648] trunk/Source/WebCore
Title: [183648] trunk/Source/WebCore
Revision 183648
Author oli...@apple.com
Date 2015-04-30 15:40:30 -0700 (Thu, 30 Apr 2015)
Log Message
DOM bindings should not be using a reference type to point to a temporary object
https://bugs.webkit.org/show_bug.cgi?id=144474
Reviewed by Beth Dakin.
The DOM bindings will currently try and use a local reference to point
to a temporary object. This currently works as a by product of the compiler's
stack layout. This patch removes the dependency on undefined behaviour
by ensuring that we use a value rather than reference type.
* bindings/scripts/CodeGeneratorJS.pm:
(GenerateParametersCheck):
(GetNativeTypeForCallbacks):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm
Diff
Modified: trunk/Source/WebCore/ChangeLog (183647 => 183648)
--- trunk/Source/WebCore/ChangeLog 2015-04-30 22:16:42 UTC (rev 183647)
+++ trunk/Source/WebCore/ChangeLog 2015-04-30 22:40:30 UTC (rev 183648)
@@ -1,3 +1,19 @@
+2015-04-30 Oliver Hunt
+
+DOM bindings should not be using a reference type to point to a temporary object
+https://bugs.webkit.org/show_bug.cgi?id=144474
+
+Reviewed by Beth Dakin.
+
+The DOM bindings will currently try and use a local reference to point
+to a temporary object. This currently works as a by product of the compiler's
+stack layout. This patch removes the dependency on undefined behaviour
+by ensuring that we use a value rather than reference type.
+
+* bindings/scripts/CodeGeneratorJS.pm:
+(GenerateParametersCheck):
+(GetNativeTypeForCallbacks):
+
2015-04-30 Brady Eidson
_javascript_ using WebSQL can create their own WebKit info table.
Modified: trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm (183647 => 183648)
--- trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm 2015-04-30 22:16:42 UTC (rev 183647)
+++ trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm 2015-04-30 22:40:30 UTC (rev 183648)
@@ -3303,7 +3303,7 @@
push(@$outputArray, "AtomicStringImpl* existing_$name = exec->argument($argsIndex).isEmpty() ? nullptr : exec->argument($argsIndex).toString(exec)->toExistingAtomicString(exec);\n");
push(@$outputArray, "if (!existing_$name)\n");
push(@$outputArray, "return JSValue::encode(jsNull());\n");
-push(@$outputArray, "const AtomicString& $name(existing_$name);\n");
+push(@$outputArray, "const AtomicString $name(existing_$name);\n");
} else {
push(@$outputArray, "" . GetNativeTypeFromSignature($parameter) . " $name(" . JSValueToNative($parameter, $optional && $defaultAttribute && $defaultAttribute eq "NullString" ? "argumentOrNull(exec, $argsIndex)" : "exec->argument($argsIndex)", $function->signature->extendedAttributes->{"Conditional"}) . ");\n");
}
@@ -3644,7 +3644,7 @@
my %nativeType = (
"CompareHow" => "Range::CompareHow",
-"DOMString" => "const String&",
+"DOMString" => "const String",
"NodeFilter" => "RefPtr",
"SerializedScriptValue" => "RefPtr",
"Date" => "double",
@@ -3704,6 +3704,7 @@
my $type = shift;
return "PassRefPtr" if $type eq "SerializedScriptValue";
return "PassRefPtr" if $type eq "DOMStringList";
+return "const String&" if $type eq "DOMString";
return GetNativeType($type);
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [183647] trunk/Source/WebKit2
Title: [183647] trunk/Source/WebKit2
Revision 183647
Author timothy_hor...@apple.com
Date 2015-04-30 15:16:42 -0700 (Thu, 30 Apr 2015)
Log Message
Asynchronous (or timed-out synchronous) resize flashes white instead of page background color
https://bugs.webkit.org/show_bug.cgi?id=144468
Reviewed by Simon Fraser and Dan Bernstein.
* UIProcess/API/mac/WKView.mm:
(-[WKView _viewBackgroundColor]):
(-[WKView updateLayer]):
Use the pageExtendedBackgroundColor for the background color of the WKView,
if we have one (and aren't using a transparent background). This means
during asynchronous resize or other cases where the Web process isn't keeping
up with the UI process during a resize, we'll see background color instead of white.
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/mac/WKView.mm
Diff
Modified: trunk/Source/WebKit2/ChangeLog (183646 => 183647)
--- trunk/Source/WebKit2/ChangeLog 2015-04-30 22:15:29 UTC (rev 183646)
+++ trunk/Source/WebKit2/ChangeLog 2015-04-30 22:16:42 UTC (rev 183647)
@@ -1,3 +1,18 @@
+2015-04-30 Tim Horton
+
+Asynchronous (or timed-out synchronous) resize flashes white instead of page background color
+https://bugs.webkit.org/show_bug.cgi?id=144468
+
+Reviewed by Simon Fraser and Dan Bernstein.
+
+* UIProcess/API/mac/WKView.mm:
+(-[WKView _viewBackgroundColor]):
+(-[WKView updateLayer]):
+Use the pageExtendedBackgroundColor for the background color of the WKView,
+if we have one (and aren't using a transparent background). This means
+during asynchronous resize or other cases where the Web process isn't keeping
+up with the UI process during a resize, we'll see background color instead of white.
+
2015-04-30 Beth Dakin
Should choose UIScrollView indicatorStyle based on the document background color
Modified: trunk/Source/WebKit2/UIProcess/API/mac/WKView.mm (183646 => 183647)
--- trunk/Source/WebKit2/UIProcess/API/mac/WKView.mm 2015-04-30 22:15:29 UTC (rev 183646)
+++ trunk/Source/WebKit2/UIProcess/API/mac/WKView.mm 2015-04-30 22:16:42 UTC (rev 183647)
@@ -4061,12 +4061,20 @@
return YES;
}
+- (CGColorRef)_viewBackgroundColor
+{
+if (self.drawsBackground && !self.drawsTransparentBackground) {
+if (NSColor *backgroundColor = self._pageExtendedBackgroundColor)
+return backgroundColor.CGColor;
+return CGColorGetConstantColor(kCGColorWhite);
+}
+
+return CGColorGetConstantColor(kCGColorClear);
+}
+
- (void)updateLayer
{
-if ([self drawsBackground] && ![self drawsTransparentBackground])
-self.layer.backgroundColor = CGColorGetConstantColor(kCGColorWhite);
-else
-self.layer.backgroundColor = CGColorGetConstantColor(kCGColorClear);
+self.layer.backgroundColor = self._viewBackgroundColor;
// If asynchronous geometry updates have been sent by forceAsyncDrawingAreaSizeUpdate,
// then subsequent calls to setFrameSize should not result in us waiting for the did
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [183646] trunk
Title: [183646] trunk Revision 183646 Author beid...@apple.com Date 2015-04-30 15:15:29 -0700 (Thu, 30 Apr 2015) Log Message _javascript_ using WebSQL can create their own WebKit info table. and https://bugs.webkit.org/show_bug.cgi?id=144466 Reviewed by Alex Christensen. Source/WebCore: Test: storage/websql/alter-to-info-table.html * Modules/webdatabase/DatabaseBackendBase.cpp: (WebCore::DatabaseBackendBase::databaseInfoTableName): Return the info table name. (WebCore::fullyQualifiedInfoTableName): Append "main." to the info table name. (WebCore::DatabaseBackendBase::DatabaseBackendBase): Use the fully qualified name. (WebCore::DatabaseBackendBase::performOpenAndVerify): Ditto. (WebCore::DatabaseBackendBase::getVersionFromDatabase): Ditto. (WebCore::DatabaseBackendBase::setVersionInDatabase): Ditto. LayoutTests: * storage/websql/alter-to-info-table-expected.txt: Added. * storage/websql/alter-to-info-table.html: Added. * storage/websql/alter-to-info-table.js: Added. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/storage/websql/test-authorizer-expected.txt trunk/LayoutTests/storage/websql/test-authorizer.js trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/Modules/webdatabase/DatabaseBackendBase.cpp Added Paths trunk/LayoutTests/storage/websql/alter-to-info-table-expected.txt trunk/LayoutTests/storage/websql/alter-to-info-table.html trunk/LayoutTests/storage/websql/alter-to-info-table.js Diff Modified: trunk/LayoutTests/ChangeLog (183645 => 183646) --- trunk/LayoutTests/ChangeLog 2015-04-30 22:00:47 UTC (rev 183645) +++ trunk/LayoutTests/ChangeLog 2015-04-30 22:15:29 UTC (rev 183646) @@ -1,3 +1,14 @@ +2015-04-30 Brady Eidson + +_javascript_ using WebSQL can create their own WebKit info table. + and https://bugs.webkit.org/show_bug.cgi?id=144466 + +Reviewed by Alex Christensen. + +* storage/websql/alter-to-info-table-expected.txt: Added. +* storage/websql/alter-to-info-table.html: Added. +* storage/websql/alter-to-info-table.js: Added. + 2015-04-30 Martin Robinson Unskip isolated words tests on WebKitGTK+ Added: trunk/LayoutTests/storage/websql/alter-to-info-table-expected.txt (0 => 183646) --- trunk/LayoutTests/storage/websql/alter-to-info-table-expected.txt (rev 0) +++ trunk/LayoutTests/storage/websql/alter-to-info-table-expected.txt 2015-04-30 22:15:29 UTC (rev 183646) @@ -0,0 +1,10 @@ +This tests that a tricky way to setup your own info table fails. +CREATE TABLE statement succeeded. +CREATE TEMP TABLE statement succeeded. +INSERT IN TEMP TABLE statement succeeded. +CREATE TRIGGER statement succeeded. +ALTER TO INFO TABLE statement succeeded. +Step 1 transaction succeeded. +Successfully changed DB version +Step 2 transaction succeeded. + Added: trunk/LayoutTests/storage/websql/alter-to-info-table.html (0 => 183646) --- trunk/LayoutTests/storage/websql/alter-to-info-table.html (rev 0) +++ trunk/LayoutTests/storage/websql/alter-to-info-table.html 2015-04-30 22:15:29 UTC (rev 183646) @@ -0,0 +1,12 @@ + + +
[webkit-changes] [183645] trunk/Source
Title: [183645] trunk/Source
Revision 183645
Author bda...@apple.com
Date 2015-04-30 15:00:47 -0700 (Thu, 30 Apr 2015)
Log Message
Should choose UIScrollView indicatorStyle based on the document background color
https://bugs.webkit.org/show_bug.cgi?id=144473
-and corresponding-
rdar://problem/19897699
Reviewed by Simon Fraser.
Source/WebCore:
Export this function.
* platform/graphics/Color.h:
Source/WebKit2:
Update the indicator style whenever the background color changes.
* UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _updateScrollViewBackground]):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/Color.h
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm
Diff
Modified: trunk/Source/WebCore/ChangeLog (183644 => 183645)
--- trunk/Source/WebCore/ChangeLog 2015-04-30 21:26:49 UTC (rev 183644)
+++ trunk/Source/WebCore/ChangeLog 2015-04-30 22:00:47 UTC (rev 183645)
@@ -1,3 +1,15 @@
+2015-04-30 Beth Dakin
+
+Should choose UIScrollView indicatorStyle based on the document background color
+https://bugs.webkit.org/show_bug.cgi?id=144473
+-and corresponding-
+rdar://problem/19897699
+
+Reviewed by Simon Fraser.
+
+Export this function.
+* platform/graphics/Color.h:
+
2015-04-30 Brent Fulgham
[Win] Allow WebKit to build without ANGLE support
Modified: trunk/Source/WebCore/platform/graphics/Color.h (183644 => 183645)
--- trunk/Source/WebCore/platform/graphics/Color.h 2015-04-30 21:26:49 UTC (rev 183644)
+++ trunk/Source/WebCore/platform/graphics/Color.h 2015-04-30 22:00:47 UTC (rev 183645)
@@ -116,7 +116,7 @@
void setRGB(RGBA32 rgb) { m_color = rgb; m_valid = true; }
WEBCORE_EXPORT void getRGBA(float& r, float& g, float& b, float& a) const;
WEBCORE_EXPORT void getRGBA(double& r, double& g, double& b, double& a) const;
-void getHSL(double& h, double& s, double& l) const;
+WEBCORE_EXPORT void getHSL(double& h, double& s, double& l) const;
Color light() const;
Color dark() const;
Modified: trunk/Source/WebKit2/ChangeLog (183644 => 183645)
--- trunk/Source/WebKit2/ChangeLog 2015-04-30 21:26:49 UTC (rev 183644)
+++ trunk/Source/WebKit2/ChangeLog 2015-04-30 22:00:47 UTC (rev 183645)
@@ -1,3 +1,16 @@
+2015-04-30 Beth Dakin
+
+Should choose UIScrollView indicatorStyle based on the document background color
+https://bugs.webkit.org/show_bug.cgi?id=144473
+-and corresponding-
+rdar://problem/19897699
+
+Reviewed by Simon Fraser.
+
+Update the indicator style whenever the background color changes.
+* UIProcess/API/Cocoa/WKWebView.mm:
+(-[WKWebView _updateScrollViewBackground]):
+
2015-04-30 Enrica Casucci
[iOS] tapping in the middle of a word in editable content should not select the word.
Modified: trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm (183644 => 183645)
--- trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm 2015-04-30 21:26:49 UTC (rev 183644)
+++ trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm 2015-04-30 22:00:47 UTC (rev 183645)
@@ -795,6 +795,14 @@
auto uiBackgroundColor = adoptNS([[UIColor alloc] initWithCGColor:cachedCGColor(color, WebCore::ColorSpaceDeviceRGB)]);
[_scrollView setBackgroundColor:uiBackgroundColor.get()];
+
+// Update the indicator style based on the lightness/darkness of the background color.
+double hue, saturation, lightness;
+color.getHSL(hue, saturation, lightness);
+if (lightness <= .5 && color.alpha() > 0)
+[_scrollView setIndicatorStyle:UIScrollViewIndicatorStyleWhite];
+else
+[_scrollView setIndicatorStyle:UIScrollViewIndicatorStyleDefault];
}
- (CGPoint)_adjustedContentOffset:(CGPoint)point
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [183644] trunk/LayoutTests
Title: [183644] trunk/LayoutTests Revision 183644 Author mrobin...@webkit.org Date 2015-04-30 14:26:49 -0700 (Thu, 30 Apr 2015) Log Message Unskip isolated words tests on WebKitGTK+ * platform/gtk/TestExpectations: Unskip tests. We've been able to run these since the switch to WebKitTestRunner. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/gtk/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (183643 => 183644) --- trunk/LayoutTests/ChangeLog 2015-04-30 20:55:00 UTC (rev 183643) +++ trunk/LayoutTests/ChangeLog 2015-04-30 21:26:49 UTC (rev 183644) @@ -1,3 +1,10 @@ +2015-04-30 Martin Robinson + +Unskip isolated words tests on WebKitGTK+ + +* platform/gtk/TestExpectations: Unskip tests. We've been able to run these +since the switch to WebKitTestRunner. + 2015-04-30 Filip Pizlo Unreviewed, skip new tests js/regress/is-string-fold.html and js/regress/is-string-fold-tricky.html because they are crashing in RJST as well. Modified: trunk/LayoutTests/platform/gtk/TestExpectations (183643 => 183644) --- trunk/LayoutTests/platform/gtk/TestExpectations 2015-04-30 20:55:00 UTC (rev 183643) +++ trunk/LayoutTests/platform/gtk/TestExpectations 2015-04-30 21:26:49 UTC (rev 183644) @@ -378,16 +378,6 @@ webkit.org/b/79203 webaudio/mediastreamaudiodestinationnode.html [ Skip ] webkit.org/b/79203 webaudio/mediastreamaudiosourcenode.html [ Skip ] -# New test infrastructure required -- need isolated worlds -webkit.org/b/31508 http/tests/security/isolatedWorld [ Skip ] -webkit.org/b/31508 plugins/npruntime/overrides-all-properties.html [ Skip ] -webkit.org/b/31508 storage/websql/open-database-creation-callback-isolated-world.html [ Skip ] -webkit.org/b/31508 storage/websql/statement-error-callback-isolated-world.html [ Skip ] -webkit.org/b/31508 storage/websql/statement-success-callback-isolated-world.html [ Skip ] -webkit.org/b/31508 storage/websql/transaction-callback-isolated-world.html [ Skip ] -webkit.org/b/31508 storage/websql/transaction-error-callback-isolated-world.html [ Skip ] -webkit.org/b/31508 storage/websql/transaction-success-callback-isolated-world.html [ Skip ] - # Text Autosizing is not yet enabled. webkit.org/b/99063 fast/text-autosizing [ Skip ] @@ -642,6 +632,9 @@ fast/events/mouse-force-down.html [ Skip ] fast/events/mouse-force-up.html [ Skip ] +# JSC does not support setIsolatedWorldSecurityOrigin +webkit.org/b/61540 http/tests/security/isolatedWorld/cross-origin-xhr.html + # # End of Expected failures # ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [183643] trunk/LayoutTests
Title: [183643] trunk/LayoutTests
Revision 183643
Author fpi...@apple.com
Date 2015-04-30 13:55:00 -0700 (Thu, 30 Apr 2015)
Log Message
Unreviewed, skip new tests js/regress/is-string-fold.html and js/regress/is-string-fold-tricky.html because they are crashing in RJST as well.
* js/regress/script-tests/is-string-fold-tricky.js:
* js/regress/script-tests/is-string-fold.js:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/js/regress/script-tests/is-string-fold-tricky.js
trunk/LayoutTests/js/regress/script-tests/is-string-fold.js
Diff
Modified: trunk/LayoutTests/ChangeLog (183642 => 183643)
--- trunk/LayoutTests/ChangeLog 2015-04-30 20:03:57 UTC (rev 183642)
+++ trunk/LayoutTests/ChangeLog 2015-04-30 20:55:00 UTC (rev 183643)
@@ -1,3 +1,10 @@
+2015-04-30 Filip Pizlo
+
+Unreviewed, skip new tests js/regress/is-string-fold.html and js/regress/is-string-fold-tricky.html because they are crashing in RJST as well.
+
+* js/regress/script-tests/is-string-fold-tricky.js:
+* js/regress/script-tests/is-string-fold.js:
+
2015-04-30 Martin Robinson
Rebaseline some editing tests for WebKitGTK+
Modified: trunk/LayoutTests/js/regress/script-tests/is-string-fold-tricky.js (183642 => 183643)
--- trunk/LayoutTests/js/regress/script-tests/is-string-fold-tricky.js 2015-04-30 20:03:57 UTC (rev 183642)
+++ trunk/LayoutTests/js/regress/script-tests/is-string-fold-tricky.js 2015-04-30 20:55:00 UTC (rev 183643)
@@ -1,3 +1,6 @@
+// webkit.org/b/144463
+//@ skip
+
var object = {};
(function() {
var result = 0;
Modified: trunk/LayoutTests/js/regress/script-tests/is-string-fold.js (183642 => 183643)
--- trunk/LayoutTests/js/regress/script-tests/is-string-fold.js 2015-04-30 20:03:57 UTC (rev 183642)
+++ trunk/LayoutTests/js/regress/script-tests/is-string-fold.js 2015-04-30 20:55:00 UTC (rev 183643)
@@ -1,3 +1,6 @@
+// webkit.org/b/144463
+//@ skip
+
var value1 = "hello";
var value2 = 42;
(function() {
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [183642] trunk/Source/WebInspectorUI
Title: [183642] trunk/Source/WebInspectorUI
Revision 183642
Author timo...@apple.com
Date 2015-04-30 13:03:57 -0700 (Thu, 30 Apr 2015)
Log Message
Web Inspector: Scope Chain sidebar should be selected immediately when paused
https://bugs.webkit.org/show_bug.cgi?id=144352
Reviewed by Joseph Pecoraro.
* UserInterface/Base/Main.js:
(WebInspector.showDebuggerTab): Added showScopeChainDetailsSidebarPanel argument.
(WebInspector._debuggerDidPause): Pass true for showScopeChainDetailsSidebarPanel.
* UserInterface/Views/ContentBrowserTabContentView.js:
(WebInspector.ContentBrowserTabContentView): Wire the event to showDetailsSidebarPanels instead of
_contentBrowserRepresentedObjectsDidChange, allowing subclasses to do work during the event.
(WebInspector.ContentBrowserTabContentView.prototype.showDetailsSidebarPanels): Moved content of
_contentBrowserRepresentedObjectsDidChange here.
(WebInspector.ContentBrowserTabContentView.prototype._contentBrowserRepresentedObjectsDidChange): Deleted.
* UserInterface/Views/DebuggerTabContentView.js:
(WebInspector.DebuggerTabContentView.prototype.showDetailsSidebarPanels): Added. Show the scope sidebar panel
if it is available and it was requested by showScopeChainDetailsSidebarPanel().
(WebInspector.DebuggerTabContentView.prototype.showScopeChainDetailsSidebarPanel): Added.
Modified Paths
trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/Base/Main.js
trunk/Source/WebInspectorUI/UserInterface/Views/ContentBrowserTabContentView.js
trunk/Source/WebInspectorUI/UserInterface/Views/DebuggerTabContentView.js
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (183641 => 183642)
--- trunk/Source/WebInspectorUI/ChangeLog 2015-04-30 20:01:18 UTC (rev 183641)
+++ trunk/Source/WebInspectorUI/ChangeLog 2015-04-30 20:03:57 UTC (rev 183642)
@@ -1,3 +1,24 @@
+2015-04-30 Timothy Hatcher
+
+Web Inspector: Scope Chain sidebar should be selected immediately when paused
+https://bugs.webkit.org/show_bug.cgi?id=144352
+
+Reviewed by Joseph Pecoraro.
+
+* UserInterface/Base/Main.js:
+(WebInspector.showDebuggerTab): Added showScopeChainDetailsSidebarPanel argument.
+(WebInspector._debuggerDidPause): Pass true for showScopeChainDetailsSidebarPanel.
+* UserInterface/Views/ContentBrowserTabContentView.js:
+(WebInspector.ContentBrowserTabContentView): Wire the event to showDetailsSidebarPanels instead of
+_contentBrowserRepresentedObjectsDidChange, allowing subclasses to do work during the event.
+(WebInspector.ContentBrowserTabContentView.prototype.showDetailsSidebarPanels): Moved content of
+_contentBrowserRepresentedObjectsDidChange here.
+(WebInspector.ContentBrowserTabContentView.prototype._contentBrowserRepresentedObjectsDidChange): Deleted.
+* UserInterface/Views/DebuggerTabContentView.js:
+(WebInspector.DebuggerTabContentView.prototype.showDetailsSidebarPanels): Added. Show the scope sidebar panel
+if it is available and it was requested by showScopeChainDetailsSidebarPanel().
+(WebInspector.DebuggerTabContentView.prototype.showScopeChainDetailsSidebarPanel): Added.
+
2015-04-30 Andres Gomez
[GTK] Web Inspector: New Images for ObjectTreeView - Setter
Modified: trunk/Source/WebInspectorUI/UserInterface/Base/Main.js (183641 => 183642)
--- trunk/Source/WebInspectorUI/UserInterface/Base/Main.js 2015-04-30 20:01:18 UTC (rev 183641)
+++ trunk/Source/WebInspectorUI/UserInterface/Base/Main.js 2015-04-30 20:03:57 UTC (rev 183642)
@@ -738,7 +738,7 @@
this.tabBrowser.showTabForContentView(tabContentView);
};
-WebInspector.showDebuggerTab = function(breakpointToSelect)
+WebInspector.showDebuggerTab = function(breakpointToSelect, showScopeChainDetailsSidebarPanel)
{
var tabContentView = this.tabBrowser.bestTabContentViewForClass(WebInspector.DebuggerTabContentView);
if (!tabContentView)
@@ -747,6 +747,9 @@
if (breakpointToSelect instanceof WebInspector.Breakpoint)
tabContentView.revealAndSelectBreakpoint(breakpointToSelect);
+if (showScopeChainDetailsSidebarPanel)
+tabContentView.showScopeChainDetailsSidebarPanel();
+
this.tabBrowser.showTabForContentView(tabContentView);
};
@@ -1068,7 +1071,7 @@
WebInspector._debuggerDidPause = function(event)
{
-this.showDebuggerTab();
+this.showDebuggerTab(null, true);
this._dashboardContainer.showDashboardViewForRepresentedObject(this.dashboardManager.dashboards.debugger);
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/ContentBrowserTabContentView.js (183641 => 183642)
--- trunk/Source/WebInspectorUI/UserInterface/Views/ContentBrowserTabContentView.js 2015-04-30 20:01:18 UTC (rev 183641)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/ContentBrowserTabContentView.js 2015-04-30 20:03:57 UTC (rev 183642)
@@ -38,7 +38,7 @@
this._lastSelectedDetailsSidebarPanelSetting = new WebInspe
[webkit-changes] [183641] trunk/Tools
Title: [183641] trunk/Tools
Revision 183641
Author a...@apple.com
Date 2015-04-30 13:01:18 -0700 (Thu, 30 Apr 2015)
Log Message
r183355 didn't trigger Mac tests
https://bugs.webkit.org/show_bug.cgi?id=144464
Reviewed by Simon Fraser.
Update badly neglected filters and unit tests.
* BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
(_should_file_trigger_build):
* BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
(ShouldBuildTest):
(ShouldBuildTest.test_should_build):
Modified Paths
trunk/Tools/BuildSlaveSupport/build.webkit.org-config/wkbuild.py
trunk/Tools/BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py
trunk/Tools/ChangeLog
Diff
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/wkbuild.py (183640 => 183641)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/wkbuild.py 2015-04-30 19:51:56 UTC (rev 183640)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/wkbuild.py 2015-04-30 20:01:18 UTC (rev 183641)
@@ -47,30 +47,28 @@
("Tools/BuildSlaveSupport/build.webkit.org-config/public_html", []),
("Websites", []),
("efl", []),
-("iphone", []),
+("ios", []),
("opengl", []),
("opentype", []),
("openvg", []),
("wx", []),
# Directories that should trigger builds on only some bots.
+("LayoutTests/platform/mac-mavericks", ["mac-mavericks"]),
+("LayoutTests/platform/mac-yosemite", ["mac-mavericks", "mac-yosemite"]),
+("LayoutTests/platform/mac-wk2", ["mac-mavericks", "mac-yosemite"]),
+("LayoutTests/platform/mac-wk1", ["mac-mavericks", "mac-yosemite"]),
("LayoutTests/platform/mac", ["mac", "win"]),
+("LayoutTests/platform/wk2", ["mac"]),
("cairo", ["gtk", "wincairo"]),
-("cf", ["mac", "qt", "win"]),
+("cf", ["mac", "win"]),
("cocoa", ["mac"]),
("curl", ["gtk", "wincairo"]),
("gobject", ["gtk"]),
-("gpu", ["mac"]),
("gstreamer", ["gtk"]),
("gtk", ["gtk"]),
("mac", ["mac"]),
-("mac-leopard", ["mac-leopard"]),
-("mac-lion", ["mac-leopard", "mac-lion", "mac-snowleopard", "win"]),
-("mac-mountainlion", ["mac-leopard", "mac-lion", "mac-mountainlion", "mac-snowleopard", "win"]),
-("mac-snowleopard", ["mac-leopard", "mac-snowleopard"]),
-("mac-wk2", ["mac-lion", "mac-snowleopard", "mac-mavericks", "mac-mountainlion", "win"]),
("objc", ["mac"]),
-("qt", ["qt"]),
("soup", ["gtk"]),
("win", ["win"]),
]
@@ -91,7 +89,6 @@
(r"\.(?:vcproj|vsprops|sln|vcxproj|props|filters)$", ["win"]),
(r"\.exp(?:\.in)?$", ["mac"]),
(r"\.order$", ["mac"]),
-(r"\.pr[io]$", ["qt"]),
(r"\.(?:vcproj|vcxproj)/", ["win"]),
(r"\.xcconfig$", ["mac"]),
(r"\.xcodeproj/", ["mac"]),
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py (183640 => 183641)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py 2015-04-30 19:51:56 UTC (rev 183640)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py 2015-04-30 20:01:18 UTC (rev 183641)
@@ -27,28 +27,29 @@
class ShouldBuildTest(unittest.TestCase):
_should_build_tests = [
(["ChangeLog", "Source/WebCore/ChangeLog", "Source/WebKit2/ChangeLog-2011-02-11"], []),
-(["GNUmakefile.am", "Source/WebCore/GNUmakefile.am"], ["gtk"]),
(["Websites/bugs.webkit.org/foo", "Source/WebCore/bar"], ["*"]),
(["Websites/bugs.webkit.org/foo"], []),
-(["Source/_javascript_Core/_javascript_Core.xcodeproj/foo"], ["mac-leopard", "mac-lion", "mac-mountainlion", "mac-snowleopard"]),
+(["Source/_javascript_Core/_javascript_Core.xcodeproj/foo"], ["mac-mavericks", "mac-yosemite"]),
(["Source/_javascript_Core/_javascript_Core.vcproj/foo", "Source/WebKit2/win/WebKit2.vcproj", "Source/WebKit/win/WebKit.sln", "Tools/WebKitTestRunner/Configurations/WebKitTestRunnerCommon.vsprops"], ["win"]),
(["LayoutTests/platform/mac/foo", "Source/WebCore/bar"], ["*"]),
(["LayoutTests/foo"], ["*"]),
(["LayoutTests/canvas/philip/tests/size.attributes.parse.exp-expected.txt", "LayoutTests/canvas/philip/tests/size.attributes.parse.exp.html"], ["*"]),
-(["LayoutTests/platform/mac-leopard/foo"], ["mac-leopard"]),
-(["LayoutTests/platform/mac-lion/foo"], ["mac-leopard", "mac-lion", "mac-snowleopard", "win"]),
-(["LayoutTests/platform/mac-snowleopard/foo"], ["mac-leopard", "mac-snowleopard"]),
-(["LayoutTests/platform/mac-wk2/Skipped"], ["mac-lion", "mac-mountainlion", "mac-snowleopard", "win"]),
-(["LayoutTests/platform/mac/foo"], ["mac-leopard", "mac-lion", "mac-mountainlion", "mac-snowleopard", "win"]),
+(["LayoutTests/platform/mac-mavericks/foo"], ["mac-mavericks"]),
+(["LayoutTests/platform/mac-yosemite/f
[webkit-changes] [183640] trunk/LayoutTests
Title: [183640] trunk/LayoutTests
Revision 183640
Author mrobin...@webkit.org
Date 2015-04-30 12:51:56 -0700 (Thu, 30 Apr 2015)
Log Message
Rebaseline some editing tests for WebKitGTK+
Also add some missing baselines.
* fast/hidpi/broken-image-icon-very-hidpi-expected.png: Added.
* fast/hidpi/broken-image-icon-very-hidpi-expected.txt: Added.
* platform/gtk/editing/execCommand/5142012-1-expected.png:
* platform/gtk/editing/execCommand/5142012-1-expected.txt:
* platform/gtk/editing/inserting/insert-at-end-02-expected.txt:
* platform/gtk/editing/pasteboard/4989774-expected.txt:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/gtk/editing/execCommand/5142012-1-expected.png
trunk/LayoutTests/platform/gtk/editing/execCommand/5142012-1-expected.txt
trunk/LayoutTests/platform/gtk/editing/inserting/insert-at-end-02-expected.txt
trunk/LayoutTests/platform/gtk/editing/pasteboard/4989774-expected.txt
Added Paths
trunk/LayoutTests/fast/hidpi/broken-image-icon-very-hidpi-expected.png
trunk/LayoutTests/fast/hidpi/broken-image-icon-very-hidpi-expected.txt
Diff
Modified: trunk/LayoutTests/ChangeLog (183639 => 183640)
--- trunk/LayoutTests/ChangeLog 2015-04-30 19:04:36 UTC (rev 183639)
+++ trunk/LayoutTests/ChangeLog 2015-04-30 19:51:56 UTC (rev 183640)
@@ -1,3 +1,16 @@
+2015-04-30 Martin Robinson
+
+Rebaseline some editing tests for WebKitGTK+
+
+Also add some missing baselines.
+
+* fast/hidpi/broken-image-icon-very-hidpi-expected.png: Added.
+* fast/hidpi/broken-image-icon-very-hidpi-expected.txt: Added.
+* platform/gtk/editing/execCommand/5142012-1-expected.png:
+* platform/gtk/editing/execCommand/5142012-1-expected.txt:
+* platform/gtk/editing/inserting/insert-at-end-02-expected.txt:
+* platform/gtk/editing/pasteboard/4989774-expected.txt:
+
2015-04-30 Filip Pizlo
Unreviewed, skip new tests js/regress/is-string-fold.html and js/regress/is-string-fold-tricky.html because they are crashing.
Added: trunk/LayoutTests/fast/hidpi/broken-image-icon-very-hidpi-expected.png
(Binary files differ)
Property changes on: trunk/LayoutTests/fast/hidpi/broken-image-icon-very-hidpi-expected.png
___
Added: svn:mime-type
Added: trunk/LayoutTests/fast/hidpi/broken-image-icon-very-hidpi-expected.txt (0 => 183640)
--- trunk/LayoutTests/fast/hidpi/broken-image-icon-very-hidpi-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/hidpi/broken-image-icon-very-hidpi-expected.txt 2015-04-30 19:51:56 UTC (rev 183640)
@@ -0,0 +1,11 @@
+layer at (0,0) size 800x600
+ RenderView at (0,0) size 800x600
+layer at (0,0) size 800x600
+ RenderBlock {HTML} at (0,0) size 800x600
+RenderBody {BODY} at (8,8) size 784x584
+ RenderBlock {DIV} at (0,0) size 784x17
+RenderText {#text} at (0,0) size 738x17
+ text run at (0,0) width 738: "This test passes if the broken image icon appears high-resolution in HiDPI and if the outline is of the appropriate size."
+ RenderBlock (anonymous) at (0,17) size 784x20
+RenderImage {IMG} at (0,0) size 20x20
+RenderText {#text} at (0,0) size 0x0
Property changes on: trunk/LayoutTests/fast/hidpi/broken-image-icon-very-hidpi-expected.txt
___
Added: svn:eol-style
Modified: trunk/LayoutTests/platform/gtk/editing/execCommand/5142012-1-expected.png
(Binary files differ)
Modified: trunk/LayoutTests/platform/gtk/editing/execCommand/5142012-1-expected.txt (183639 => 183640)
--- trunk/LayoutTests/platform/gtk/editing/execCommand/5142012-1-expected.txt 2015-04-30 19:04:36 UTC (rev 183639)
+++ trunk/LayoutTests/platform/gtk/editing/execCommand/5142012-1-expected.txt 2015-04-30 19:51:56 UTC (rev 183640)
@@ -9,7 +9,6 @@
text run at (449,0) width 317: "There shouldn't be any links *inside the selection*"
text run at (0,17) width 43: "below."
RenderBlock {DIV} at (0,50) size 784x34
-RenderBlock (anonymous) at (0,0) size 784x0
RenderBlock {DIV} at (0,0) size 784x17
RenderInline {A} at (0,0) size 23x17 [color=#EE]
RenderText {#text} at (0,0) size 23x17
@@ -17,6 +16,7 @@
RenderInline {SPAN} at (0,0) size 12x17
RenderText {#text} at (23,0) size 12x17
text run at (23,0) width 12: "lo"
+RenderBlock (anonymous) at (0,17) size 784x0
RenderBlock {DIV} at (0,17) size 784x17
RenderInline {SPAN} at (0,0) size 15x17
RenderText {#text} at (0,0) size 15x17
Modified: trunk/LayoutTests/platform/gtk/editing/inserting/insert-at-end-02-expected.txt (183639 => 183640)
--- trunk/LayoutTests/platform/gtk/editing/inserting/insert-at-end-02-expected.txt 2015-04-30 19:04:36 UTC (rev 183639)
+++ trunk/LayoutTests/platform/gtk/editing/inserting/insert-at-end-02-expected.txt 2015-04-30 19:51:
[webkit-changes] [183639] trunk/Source/WebCore
Title: [183639] trunk/Source/WebCore Revision 183639 Author bfulg...@apple.com Date 2015-04-30 12:04:36 -0700 (Thu, 30 Apr 2015) Log Message [Win] Allow WebKit to build without ANGLE support https://bugs.webkit.org/show_bug.cgi?id=144459 Reviewed by Dean Jackson. * platform/graphics/GLContext.cpp: Use the ENABLE(GRAPHICS_CONTEXT_3D) macro to avoid compiling this code if not using WEBGL/3D contexts. Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/platform/graphics/GLContext.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (183638 => 183639) --- trunk/Source/WebCore/ChangeLog 2015-04-30 18:54:02 UTC (rev 183638) +++ trunk/Source/WebCore/ChangeLog 2015-04-30 19:04:36 UTC (rev 183639) @@ -1,3 +1,14 @@ +2015-04-30 Brent Fulgham + +[Win] Allow WebKit to build without ANGLE support +https://bugs.webkit.org/show_bug.cgi?id=144459 + + +Reviewed by Dean Jackson. + +* platform/graphics/GLContext.cpp: Use the ENABLE(GRAPHICS_CONTEXT_3D) +macro to avoid compiling this code if not using WEBGL/3D contexts. + 2015-04-29 David Hyatt Avoid containingBlock() calls when no writing mode flipping is needed. Modified: trunk/Source/WebCore/platform/graphics/GLContext.cpp (183638 => 183639) --- trunk/Source/WebCore/platform/graphics/GLContext.cpp 2015-04-30 18:54:02 UTC (rev 183638) +++ trunk/Source/WebCore/platform/graphics/GLContext.cpp 2015-04-30 19:04:36 UTC (rev 183639) @@ -17,6 +17,9 @@ */ #include "config.h" + +#if ENABLE(GRAPHICS_CONTEXT_3D) + #include "GLContext.h" #if USE(EGL) @@ -197,4 +200,4 @@ } // namespace WebCore - +#endif ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [183638] trunk/LayoutTests
Title: [183638] trunk/LayoutTests Revision 183638 Author fpi...@apple.com Date 2015-04-30 11:54:02 -0700 (Thu, 30 Apr 2015) Log Message Unreviewed, skip new tests js/regress/is-string-fold.html and js/regress/is-string-fold-tricky.html because they are crashing. * TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (183637 => 183638) --- trunk/LayoutTests/ChangeLog 2015-04-30 18:50:11 UTC (rev 183637) +++ trunk/LayoutTests/ChangeLog 2015-04-30 18:54:02 UTC (rev 183638) @@ -1,3 +1,9 @@ +2015-04-30 Filip Pizlo + +Unreviewed, skip new tests js/regress/is-string-fold.html and js/regress/is-string-fold-tricky.html because they are crashing. + +* TestExpectations: + 2015-04-30 Jon Honeycutt Add image failure expectation for Modified: trunk/LayoutTests/TestExpectations (183637 => 183638) --- trunk/LayoutTests/TestExpectations 2015-04-30 18:50:11 UTC (rev 183637) +++ trunk/LayoutTests/TestExpectations 2015-04-30 18:54:02 UTC (rev 183638) @@ -527,3 +527,6 @@ webkit.org/b/143778 streams/reference-implementation/readable-stream.html [ Pass Failure ] webkit.org/b/144258 [ Debug ] js/class-syntax-semicolon.html [ Skip ] + +webkit.org/b/144463 js/regress/is-string-fold.html [ Skip ] +webkit.org/b/144463 js/regress/is-string-fold-tricky.html [ Skip ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [183637] trunk/LayoutTests
Title: [183637] trunk/LayoutTests Revision 183637 Author jhoneyc...@apple.com Date 2015-04-30 11:50:11 -0700 (Thu, 30 Apr 2015) Log Message Add image failure expectation for svg/filters/sourceAlpha-input-filter-effect.html on Windows Unreviewed. * platform/win/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/win/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (183636 => 183637) --- trunk/LayoutTests/ChangeLog 2015-04-30 18:36:56 UTC (rev 183636) +++ trunk/LayoutTests/ChangeLog 2015-04-30 18:50:11 UTC (rev 183637) @@ -1,3 +1,12 @@ +2015-04-30 Jon Honeycutt + +Add image failure expectation for +svg/filters/sourceAlpha-input-filter-effect.html on Windows + +Unreviewed. + +* platform/win/TestExpectations: + 2015-04-29 Filip Pizlo DFG Is versions of TypeOf should fold based on proven input type Modified: trunk/LayoutTests/platform/win/TestExpectations (183636 => 183637) --- trunk/LayoutTests/platform/win/TestExpectations 2015-04-30 18:36:56 UTC (rev 183636) +++ trunk/LayoutTests/platform/win/TestExpectations 2015-04-30 18:50:11 UTC (rev 183637) @@ -1843,6 +1843,7 @@ webkit.org/b/116564 transitions/svg-text-shadow-transition.html [ Failure ] webkit.org/b/117322 svg/animations/mozilla/animateMotion-mpath-targetChange-1.svg [ ImageOnlyFailure ] webkit.org/b/117322 svg/filters/feDisplacementMap-filterUnits.svg [ ImageOnlyFailure ] +webkit.org/b/144417 svg/filters/sourceAlpha-input-filter-effect.html [ ImageOnlyFailure ] # Subpixel rendering: borders are reporting float values. webkit.org/b/128061 svg/zoom/page/zoom-img-preserveAspectRatio-support-1.html [ Failure ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [183636] trunk/Source/WebCore
Title: [183636] trunk/Source/WebCore
Revision 183636
Author hy...@apple.com
Date 2015-04-30 11:36:56 -0700 (Thu, 30 Apr 2015)
Log Message
Avoid containingBlock() calls when no writing mode flipping is needed.
https://bugs.webkit.org/show_bug.cgi?id=144407
Reviewed by Simon Fraser.
Add a bool to RenderView that indicates whether or not any flipped blocks have been
added to the view. Once tainted, the view just stays dirty forever. If no flipped
blocks are ever seen, we can then optimize away calls to containingBlock().
The motivation for this patch is to improve layer position updating, which makes many
calls to topLeftLocationOffset(), one of the functions that can be optimized by this
change.
* rendering/RenderBox.cpp:
(WebCore::RenderBox::layoutOverflowRectForPropagation):
* rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::updateFromStyle):
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::calculateClipRects):
* rendering/RenderLineBoxList.cpp:
(WebCore::RenderLineBoxList::rangeIntersectsRect):
* rendering/RenderView.cpp:
(WebCore::RenderView::RenderView):
* rendering/RenderView.h:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderBox.cpp
trunk/Source/WebCore/rendering/RenderBoxModelObject.cpp
trunk/Source/WebCore/rendering/RenderLayer.cpp
trunk/Source/WebCore/rendering/RenderLineBoxList.cpp
trunk/Source/WebCore/rendering/RenderView.cpp
trunk/Source/WebCore/rendering/RenderView.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (183635 => 183636)
--- trunk/Source/WebCore/ChangeLog 2015-04-30 18:21:01 UTC (rev 183635)
+++ trunk/Source/WebCore/ChangeLog 2015-04-30 18:36:56 UTC (rev 183636)
@@ -1,3 +1,30 @@
+2015-04-29 David Hyatt
+
+Avoid containingBlock() calls when no writing mode flipping is needed.
+https://bugs.webkit.org/show_bug.cgi?id=144407
+
+Reviewed by Simon Fraser.
+
+Add a bool to RenderView that indicates whether or not any flipped blocks have been
+added to the view. Once tainted, the view just stays dirty forever. If no flipped
+blocks are ever seen, we can then optimize away calls to containingBlock().
+
+The motivation for this patch is to improve layer position updating, which makes many
+calls to topLeftLocationOffset(), one of the functions that can be optimized by this
+change.
+
+* rendering/RenderBox.cpp:
+(WebCore::RenderBox::layoutOverflowRectForPropagation):
+* rendering/RenderBoxModelObject.cpp:
+(WebCore::RenderBoxModelObject::updateFromStyle):
+* rendering/RenderLayer.cpp:
+(WebCore::RenderLayer::calculateClipRects):
+* rendering/RenderLineBoxList.cpp:
+(WebCore::RenderLineBoxList::rangeIntersectsRect):
+* rendering/RenderView.cpp:
+(WebCore::RenderView::RenderView):
+* rendering/RenderView.h:
+
2015-04-29 Jer Noble
Make GenericTaskQueue even more generic (and usable inside platform/)
Modified: trunk/Source/WebCore/rendering/RenderBox.cpp (183635 => 183636)
--- trunk/Source/WebCore/rendering/RenderBox.cpp 2015-04-30 18:21:01 UTC (rev 183635)
+++ trunk/Source/WebCore/rendering/RenderBox.cpp 2015-04-30 18:36:56 UTC (rev 183636)
@@ -4828,6 +4828,9 @@
LayoutPoint RenderBox::topLeftLocation() const
{
+if (!view().hasFlippedBlockDescendants())
+return location();
+
RenderBlock* containerBlock = containingBlock();
if (!containerBlock || containerBlock == this)
return location();
@@ -4836,6 +4839,9 @@
LayoutSize RenderBox::topLeftLocationOffset() const
{
+if (!view().hasFlippedBlockDescendants())
+return LayoutSize(m_frameRect.x(), m_frameRect.y());
+
RenderBlock* containerBlock = containingBlock();
if (!containerBlock || containerBlock == this)
return locationOffset();
Modified: trunk/Source/WebCore/rendering/RenderBoxModelObject.cpp (183635 => 183636)
--- trunk/Source/WebCore/rendering/RenderBoxModelObject.cpp 2015-04-30 18:21:01 UTC (rev 183635)
+++ trunk/Source/WebCore/rendering/RenderBoxModelObject.cpp 2015-04-30 18:36:56 UTC (rev 183636)
@@ -219,6 +219,8 @@
setInline(styleToUse.isDisplayInlineType());
setPositionState(styleToUse.position());
setHorizontalWritingMode(styleToUse.isHorizontalWritingMode());
+if (styleToUse.isFlippedBlocksWritingMode())
+view().setHasFlippedBlockDescendants(true);
}
static LayoutSize accumulateInFlowPositionOffsets(const RenderObject* child)
Modified: trunk/Source/WebCore/rendering/RenderLayer.cpp (183635 => 183636)
--- trunk/Source/WebCore/rendering/RenderLayer.cpp 2015-04-30 18:21:01 UTC (rev 183635)
+++ trunk/Source/WebCore/rendering/RenderLayer.cpp 2015-04-30 18:36:56 UTC (rev 183636)
@@ -5819,11 +5819,13 @@
LayoutRect RenderLayer::boundingBox(const RenderLayer* ancestorLayer, const LayoutSize& offsetFromRoot, CalculateLayerBoundsFlags flags) const
{
LayoutRect result = local
[webkit-changes] [183635] trunk/Source/WebKit2
Title: [183635] trunk/Source/WebKit2
Revision 183635
Author enr...@apple.com
Date 2015-04-30 11:21:01 -0700 (Thu, 30 Apr 2015)
Log Message
[iOS] tapping in the middle of a word in editable content should not select the word.
https://bugs.webkit.org/show_bug.cgi?id=144421
rdar://problem/20710948
Reviewed by Tim Horton.
Reverting to the original behavior.
* WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::selectWithGesture):
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/WebProcess/WebPage/ios/WebPageIOS.mm
Diff
Modified: trunk/Source/WebKit2/ChangeLog (183634 => 183635)
--- trunk/Source/WebKit2/ChangeLog 2015-04-30 18:20:47 UTC (rev 183634)
+++ trunk/Source/WebKit2/ChangeLog 2015-04-30 18:21:01 UTC (rev 183635)
@@ -1,3 +1,16 @@
+2015-04-30 Enrica Casucci
+
+[iOS] tapping in the middle of a word in editable content should not select the word.
+https://bugs.webkit.org/show_bug.cgi?id=144421
+rdar://problem/20710948
+
+Reviewed by Tim Horton.
+
+Reverting to the original behavior.
+
+* WebProcess/WebPage/ios/WebPageIOS.mm:
+(WebKit::WebPage::selectWithGesture):
+
2015-04-29 Hunseop Jeong
Fix the EFL build after r183595
Modified: trunk/Source/WebKit2/WebProcess/WebPage/ios/WebPageIOS.mm (183634 => 183635)
--- trunk/Source/WebKit2/WebProcess/WebPage/ios/WebPageIOS.mm 2015-04-30 18:20:47 UTC (rev 183634)
+++ trunk/Source/WebKit2/WebProcess/WebPage/ios/WebPageIOS.mm 2015-04-30 18:21:01 UTC (rev 183635)
@@ -964,11 +964,13 @@
// Don't cross line boundaries.
result = position;
} else if (withinTextUnitOfGranularity(position, WordGranularity, DirectionForward)) {
-// The position lies within a word, we want to select the word.
-if (frame.selection().isCaret())
-range = enclosingTextUnitOfGranularity(position, WordGranularity, DirectionForward);
-else if (frame.selection().isRange() && (position < frame.selection().selection().start() || position > frame.selection().selection().end()))
-result = position;
+// The position lies within a word.
+RefPtr wordRange = enclosingTextUnitOfGranularity(position, WordGranularity, DirectionForward);
+if (wordRange) {
+result = wordRange->startPosition();
+if (distanceBetweenPositions(position, result) > 1)
+result = wordRange->endPosition();
+}
} else if (atBoundaryOfGranularity(position, WordGranularity, DirectionBackward)) {
// The position is at the end of a word.
result = position;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [183634] trunk/Tools
Title: [183634] trunk/Tools Revision 183634 Author calva...@igalia.com Date 2015-04-30 11:20:47 -0700 (Thu, 30 Apr 2015) Log Message [GTK] Add libhyphen-dev to the build dependencies https://bugs.webkit.org/show_bug.cgi?id=144452 Reviewed by Martin Robinson. * gtk/install-dependencies: Added libhyphen-dev to the WebKitGTK+ build dependencies. Modified Paths trunk/Tools/ChangeLog trunk/Tools/gtk/install-dependencies Diff Modified: trunk/Tools/ChangeLog (183633 => 183634) --- trunk/Tools/ChangeLog 2015-04-30 18:00:44 UTC (rev 183633) +++ trunk/Tools/ChangeLog 2015-04-30 18:20:47 UTC (rev 183634) @@ -1,3 +1,13 @@ +2015-04-30 Xabier Rodriguez Calvar + +[GTK] Add libhyphen-dev to the build dependencies +https://bugs.webkit.org/show_bug.cgi?id=144452 + +Reviewed by Martin Robinson. + +* gtk/install-dependencies: Added libhyphen-dev to the WebKitGTK+ +build dependencies. + 2015-04-30 Martin Robinson [GTK] Testing dictionaries are not installed automatically Modified: trunk/Tools/gtk/install-dependencies (183633 => 183634) --- trunk/Tools/gtk/install-dependencies 2015-04-30 18:00:44 UTC (rev 183633) +++ trunk/Tools/gtk/install-dependencies 2015-04-30 18:20:47 UTC (rev 183634) @@ -75,6 +75,7 @@ libgtk-3-dev \ libgudev-1.0-dev \ libharfbuzz-dev \ +libhyphen-dev \ libicu-dev \ libjpeg-dev \ libmpg123-dev \ ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [183633] trunk/Source/WebInspectorUI
Title: [183633] trunk/Source/WebInspectorUI Revision 183633 Author ago...@igalia.com Date 2015-04-30 11:00:44 -0700 (Thu, 30 Apr 2015) Log Message [GTK] Web Inspector: New Images for ObjectTreeView - Setter https://bugs.webkit.org/show_bug.cgi?id=143173 Reviewed by Martin Robinson. * UserInterface/Images/gtk/Pencil.svg: Added. Modified Paths trunk/Source/WebInspectorUI/ChangeLog Added Paths trunk/Source/WebInspectorUI/UserInterface/Images/gtk/Pencil.svg Diff Modified: trunk/Source/WebInspectorUI/ChangeLog (183632 => 183633) --- trunk/Source/WebInspectorUI/ChangeLog 2015-04-30 17:50:16 UTC (rev 183632) +++ trunk/Source/WebInspectorUI/ChangeLog 2015-04-30 18:00:44 UTC (rev 183633) @@ -1,5 +1,14 @@ 2015-04-30 Andres Gomez +[GTK] Web Inspector: New Images for ObjectTreeView - Setter +https://bugs.webkit.org/show_bug.cgi?id=143173 + +Reviewed by Martin Robinson. + +* UserInterface/Images/gtk/Pencil.svg: Added. + +2015-04-30 Andres Gomez + [GTK] Web Inspector: Remove some unused Images https://bugs.webkit.org/show_bug.cgi?id=15 Added: trunk/Source/WebInspectorUI/UserInterface/Images/gtk/Pencil.svg (0 => 183633) --- trunk/Source/WebInspectorUI/UserInterface/Images/gtk/Pencil.svg (rev 0) +++ trunk/Source/WebInspectorUI/UserInterface/Images/gtk/Pencil.svg 2015-04-30 18:00:44 UTC (rev 183633) @@ -0,0 +1,12 @@ + + + + + + + + + + + + ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [183632] trunk/Tools
Title: [183632] trunk/Tools Revision 183632 Author mrobin...@webkit.org Date 2015-04-30 10:50:16 -0700 (Thu, 30 Apr 2015) Log Message [GTK] Testing dictionaries are not installed automatically https://bugs.webkit.org/show_bug.cgi?id=144460 Reviewed by Carlos Garcia Campos. * gtk/jhbuild.modules: Add the testing dictionaries to the main moduleset. Modified Paths trunk/Tools/ChangeLog trunk/Tools/gtk/jhbuild.modules Diff Modified: trunk/Tools/ChangeLog (183631 => 183632) --- trunk/Tools/ChangeLog 2015-04-30 17:44:23 UTC (rev 183631) +++ trunk/Tools/ChangeLog 2015-04-30 17:50:16 UTC (rev 183632) @@ -1,3 +1,12 @@ +2015-04-30 Martin Robinson + +[GTK] Testing dictionaries are not installed automatically +https://bugs.webkit.org/show_bug.cgi?id=144460 + +Reviewed by Carlos Garcia Campos. + +* gtk/jhbuild.modules: Add the testing dictionaries to the main moduleset. + 2015-04-30 Dewei Zhu Fix return code issue, check return code of safari process and dump results to log Modified: trunk/Tools/gtk/jhbuild.modules (183631 => 183632) --- trunk/Tools/gtk/jhbuild.modules 2015-04-30 17:44:23 UTC (rev 183631) +++ trunk/Tools/gtk/jhbuild.modules 2015-04-30 17:50:16 UTC (rev 183632) @@ -7,6 +7,7 @@ + ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [183631] trunk/Source/JavaScriptCore
Title: [183631] trunk/Source/_javascript_Core
Revision 183631
Author fpi...@apple.com
Date 2015-04-30 10:44:23 -0700 (Thu, 30 Apr 2015)
Log Message
Unreviewed, add a FIXME comment referencing https://bugs.webkit.org/show_bug.cgi?id=144458.
* jit/JITOperations.cpp:
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/jit/JITOperations.cpp
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (183630 => 183631)
--- trunk/Source/_javascript_Core/ChangeLog 2015-04-30 17:40:31 UTC (rev 183630)
+++ trunk/Source/_javascript_Core/ChangeLog 2015-04-30 17:44:23 UTC (rev 183631)
@@ -1,5 +1,11 @@
2015-04-30 Filip Pizlo
+Unreviewed, add a FIXME comment referencing https://bugs.webkit.org/show_bug.cgi?id=144458.
+
+* jit/JITOperations.cpp:
+
+2015-04-30 Filip Pizlo
+
Add a comment clarifying the behavior and semantics of getCallData/getConstructData, in
particular that they cannot change their minds and may be called from compiler threads.
Modified: trunk/Source/_javascript_Core/jit/JITOperations.cpp (183630 => 183631)
--- trunk/Source/_javascript_Core/jit/JITOperations.cpp 2015-04-30 17:40:31 UTC (rev 183630)
+++ trunk/Source/_javascript_Core/jit/JITOperations.cpp 2015-04-30 17:44:23 UTC (rev 183631)
@@ -721,8 +721,12 @@
JSValue calleeAsValue = execCallee->calleeAsValue();
JSCell* calleeAsFunctionCell = getJSFunction(calleeAsValue);
-if (!calleeAsFunctionCell)
+if (!calleeAsFunctionCell) {
+// FIXME: We should cache these kinds of calls. They can be common and currently they are
+// expensive.
+// https://bugs.webkit.org/show_bug.cgi?id=144458
return reinterpret_cast(handleHostCall(execCallee, calleeAsValue, kind));
+}
JSFunction* callee = jsCast(calleeAsFunctionCell);
JSScope* scope = callee->scopeUnchecked();
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [183630] trunk/Source/JavaScriptCore
Title: [183630] trunk/Source/_javascript_Core Revision 183630 Author fpi...@apple.com Date 2015-04-30 10:40:31 -0700 (Thu, 30 Apr 2015) Log Message Add a comment clarifying the behavior and semantics of getCallData/getConstructData, in particular that they cannot change their minds and may be called from compiler threads. Rubber stamped by Geoffrey Garen. * runtime/JSCell.h: Modified Paths trunk/Source/_javascript_Core/ChangeLog trunk/Source/_javascript_Core/runtime/JSCell.h Diff Modified: trunk/Source/_javascript_Core/ChangeLog (183629 => 183630) --- trunk/Source/_javascript_Core/ChangeLog 2015-04-30 17:36:26 UTC (rev 183629) +++ trunk/Source/_javascript_Core/ChangeLog 2015-04-30 17:40:31 UTC (rev 183630) @@ -1,3 +1,12 @@ +2015-04-30 Filip Pizlo + +Add a comment clarifying the behavior and semantics of getCallData/getConstructData, in +particular that they cannot change their minds and may be called from compiler threads. + +Rubber stamped by Geoffrey Garen. + +* runtime/JSCell.h: + 2015-04-29 Filip Pizlo DFG Is versions of TypeOf should fold based on proven input type Modified: trunk/Source/_javascript_Core/runtime/JSCell.h (183629 => 183630) --- trunk/Source/_javascript_Core/runtime/JSCell.h 2015-04-30 17:36:26 UTC (rev 183629) +++ trunk/Source/_javascript_Core/runtime/JSCell.h 2015-04-30 17:40:31 UTC (rev 183630) @@ -112,6 +112,12 @@ JS_EXPORT_PRIVATE JSObject* getObject(); // NULL if not an object const JSObject* getObject() const; // NULL if not an object +// Returns information about how to call/construct this cell as a function/constructor. May tell +// you that the cell is not callable or constructor (default is that it's not either). If it +// says that the function is callable, and the TypeOfShouldCallGetCallData type flag is set, and +// this is an object, then typeof will return "function" instead of "object". These methods +// cannot change their minds and must be thread-safe. They are sometimes called from compiler +// threads. JS_EXPORT_PRIVATE static CallType getCallData(JSCell*, CallData&); JS_EXPORT_PRIVATE static ConstructType getConstructData(JSCell*, ConstructData&); ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [183629] trunk
Title: [183629] trunk Revision 183629 Author fpi...@apple.com Date 2015-04-30 10:36:26 -0700 (Thu, 30 Apr 2015) Log Message DFG Is versions of TypeOf should fold based on proven input type https://bugs.webkit.org/show_bug.cgi?id=144409 Reviewed by Geoffrey Garen. Source/_javascript_Core: We were missing some obvious folding opportunities here. I don't know how this affects real code, but in general, we like to ensure that our constant folding is comprehensive. So this is more about placating my static analysis OCD than anything else. I added a bunch of speed/correctness tests for this in LayoutTests/js/regress. * dfg/DFGAbstractInterpreterInlines.h: (JSC::DFG::AbstractInterpreter::executeEffects): LayoutTests: * js/regress/is-boolean-fold-expected.txt: Added. * js/regress/is-boolean-fold-tricky-expected.txt: Added. * js/regress/is-boolean-fold-tricky.html: Added. * js/regress/is-boolean-fold.html: Added. * js/regress/is-function-fold-expected.txt: Added. * js/regress/is-function-fold-tricky-expected.txt: Added. * js/regress/is-function-fold-tricky-internal-function-expected.txt: Added. * js/regress/is-function-fold-tricky-internal-function.html: Added. * js/regress/is-function-fold-tricky.html: Added. * js/regress/is-function-fold.html: Added. * js/regress/is-number-fold-expected.txt: Added. * js/regress/is-number-fold-tricky-expected.txt: Added. * js/regress/is-number-fold-tricky.html: Added. * js/regress/is-number-fold.html: Added. * js/regress/is-object-or-null-fold-expected.txt: Added. * js/regress/is-object-or-null-fold-functions-expected.txt: Added. * js/regress/is-object-or-null-fold-functions.html: Added. * js/regress/is-object-or-null-fold-less-tricky-expected.txt: Added. * js/regress/is-object-or-null-fold-less-tricky.html: Added. * js/regress/is-object-or-null-fold-tricky-expected.txt: Added. * js/regress/is-object-or-null-fold-tricky.html: Added. * js/regress/is-object-or-null-fold.html: Added. * js/regress/is-object-or-null-trickier-function-expected.txt: Added. * js/regress/is-object-or-null-trickier-function.html: Added. * js/regress/is-object-or-null-trickier-internal-function-expected.txt: Added. * js/regress/is-object-or-null-trickier-internal-function.html: Added. * js/regress/is-object-or-null-tricky-function-expected.txt: Added. * js/regress/is-object-or-null-tricky-function.html: Added. * js/regress/is-object-or-null-tricky-internal-function-expected.txt: Added. * js/regress/is-object-or-null-tricky-internal-function.html: Added. * js/regress/is-string-fold-expected.txt: Added. * js/regress/is-string-fold-tricky-expected.txt: Added. * js/regress/is-string-fold-tricky.html: Added. * js/regress/is-string-fold.html: Added. * js/regress/is-undefined-fold-expected.txt: Added. * js/regress/is-undefined-fold-tricky-expected.txt: Added. * js/regress/is-undefined-fold-tricky.html: Added. * js/regress/is-undefined-fold.html: Added. * js/regress/script-tests/is-boolean-fold-tricky.js: Added. * js/regress/script-tests/is-boolean-fold.js: Added. * js/regress/script-tests/is-function-fold-tricky-internal-function.js: Added. * js/regress/script-tests/is-function-fold-tricky.js: Added. (func): (func2): * js/regress/script-tests/is-function-fold.js: Added. (value1): * js/regress/script-tests/is-number-fold-tricky.js: Added. * js/regress/script-tests/is-number-fold.js: Added. * js/regress/script-tests/is-object-or-null-fold-functions.js: Added. (value2): * js/regress/script-tests/is-object-or-null-fold-less-tricky.js: Added. * js/regress/script-tests/is-object-or-null-fold-tricky.js: Added. * js/regress/script-tests/is-object-or-null-fold.js: Added. * js/regress/script-tests/is-object-or-null-trickier-function.js: Added. (func): (func2): * js/regress/script-tests/is-object-or-null-trickier-internal-function.js: Added. * js/regress/script-tests/is-object-or-null-tricky-function.js: Added. (func): * js/regress/script-tests/is-object-or-null-tricky-internal-function.js: Added. * js/regress/script-tests/is-string-fold-tricky.js: Added. * js/regress/script-tests/is-string-fold.js: Added. * js/regress/script-tests/is-undefined-fold-tricky.js: Added. * js/regress/script-tests/is-undefined-fold.js: Added. * js/regress/sink-function-expected.txt: Added. * js/regress/sink-function.html: Added. Modified Paths trunk/LayoutTests/ChangeLog trunk/Source/_javascript_Core/ChangeLog trunk/Source/_javascript_Core/dfg/DFGAbstractInterpreterInlines.h Added Paths trunk/LayoutTests/js/regress/is-boolean-fold-expected.txt trunk/LayoutTests/js/regress/is-boolean-fold-tricky-expected.txt trunk/LayoutTests/js/regress/is-boolean-fold-tricky.html trunk/LayoutTests/js/regress/is-boolean-fold.html trunk/LayoutTests/js/regress/is-function-fold-expected.txt trunk/LayoutTests/js/regress/is-function-fold-tricky-expected.txt trunk/LayoutTests/js/regress/is-function-fold-tricky-internal-function-expected.txt trunk/LayoutTests/js/regress/is-function-fold-tricky-internal-function.html trunk/LayoutTests
[webkit-changes] [183628] trunk/LayoutTests
Title: [183628] trunk/LayoutTests Revision 183628 Author bfulg...@apple.com Date 2015-04-30 10:21:55 -0700 (Thu, 30 Apr 2015) Log Message [Mac] Expand test infrastructure to support scrolling tests (Part 3) https://bugs.webkit.org/show_bug.cgi?id=144131 Reviewed by Eric Carlson. Update the WK2 scrolling tests to use the new scroll trigger infrastructure to reduce the use of timeouts. * platform/mac-wk2/tiled-drawing/scrolling/fast-scroll-div-latched-div-expected.txt: * platform/mac-wk2/tiled-drawing/scrolling/fast-scroll-div-latched-div-with-handler-expected.txt: * platform/mac-wk2/tiled-drawing/scrolling/fast-scroll-div-latched-div-with-handler.html: * platform/mac-wk2/tiled-drawing/scrolling/fast-scroll-div-latched-div.html: * platform/mac-wk2/tiled-drawing/scrolling/fast-scroll-div-latched-mainframe-expected.txt: * platform/mac-wk2/tiled-drawing/scrolling/fast-scroll-div-latched-mainframe-with-handler-expected.txt: * platform/mac-wk2/tiled-drawing/scrolling/fast-scroll-div-latched-mainframe-with-handler.html: * platform/mac-wk2/tiled-drawing/scrolling/fast-scroll-div-latched-mainframe.html: * platform/mac-wk2/tiled-drawing/scrolling/fast-scroll-iframe-latched-iframe-expected.txt: * platform/mac-wk2/tiled-drawing/scrolling/fast-scroll-iframe-latched-iframe-with-handler-expected.txt: * platform/mac-wk2/tiled-drawing/scrolling/fast-scroll-iframe-latched-iframe-with-handler.html: * platform/mac-wk2/tiled-drawing/scrolling/fast-scroll-iframe-latched-iframe.html: * platform/mac-wk2/tiled-drawing/scrolling/fast-scroll-iframe-latched-mainframe-expected.txt: * platform/mac-wk2/tiled-drawing/scrolling/fast-scroll-iframe-latched-mainframe-with-handler-expected.txt: * platform/mac-wk2/tiled-drawing/scrolling/fast-scroll-iframe-latched-mainframe-with-handler.html: * platform/mac-wk2/tiled-drawing/scrolling/fast-scroll-iframe-latched-mainframe.html: * platform/mac-wk2/tiled-drawing/scrolling/fast-scroll-select-latched-mainframe-expected.txt: * platform/mac-wk2/tiled-drawing/scrolling/fast-scroll-select-latched-mainframe-with-handler-expected.txt: * platform/mac-wk2/tiled-drawing/scrolling/fast-scroll-select-latched-mainframe-with-handler.html: * platform/mac-wk2/tiled-drawing/scrolling/fast-scroll-select-latched-mainframe.html: * platform/mac-wk2/tiled-drawing/scrolling/fast-scroll-select-latched-select-expected.txt: * platform/mac-wk2/tiled-drawing/scrolling/fast-scroll-select-latched-select-with-handler-expected.txt: * platform/mac-wk2/tiled-drawing/scrolling/fast-scroll-select-latched-select-with-handler.html: * platform/mac-wk2/tiled-drawing/scrolling/fast-scroll-select-latched-select.html: * platform/mac-wk2/tiled-drawing/scrolling/overflow-scroll-zero-delta-wheel-events.html: * platform/mac-wk2/tiled-drawing/scrolling/root-overflow-with-mousewheel.html: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/mac-wk2/tiled-drawing/scrolling/fast-scroll-div-latched-div-expected.txt trunk/LayoutTests/platform/mac-wk2/tiled-drawing/scrolling/fast-scroll-div-latched-div-with-handler-expected.txt trunk/LayoutTests/platform/mac-wk2/tiled-drawing/scrolling/fast-scroll-div-latched-div-with-handler.html trunk/LayoutTests/platform/mac-wk2/tiled-drawing/scrolling/fast-scroll-div-latched-div.html trunk/LayoutTests/platform/mac-wk2/tiled-drawing/scrolling/fast-scroll-div-latched-mainframe-expected.txt trunk/LayoutTests/platform/mac-wk2/tiled-drawing/scrolling/fast-scroll-div-latched-mainframe-with-handler-expected.txt trunk/LayoutTests/platform/mac-wk2/tiled-drawing/scrolling/fast-scroll-div-latched-mainframe-with-handler.html trunk/LayoutTests/platform/mac-wk2/tiled-drawing/scrolling/fast-scroll-div-latched-mainframe.html trunk/LayoutTests/platform/mac-wk2/tiled-drawing/scrolling/fast-scroll-iframe-latched-iframe-expected.txt trunk/LayoutTests/platform/mac-wk2/tiled-drawing/scrolling/fast-scroll-iframe-latched-iframe-with-handler-expected.txt trunk/LayoutTests/platform/mac-wk2/tiled-drawing/scrolling/fast-scroll-iframe-latched-iframe-with-handler.html trunk/LayoutTests/platform/mac-wk2/tiled-drawing/scrolling/fast-scroll-iframe-latched-iframe.html trunk/LayoutTests/platform/mac-wk2/tiled-drawing/scrolling/fast-scroll-iframe-latched-mainframe-expected.txt trunk/LayoutTests/platform/mac-wk2/tiled-drawing/scrolling/fast-scroll-iframe-latched-mainframe-with-handler-expected.txt trunk/LayoutTests/platform/mac-wk2/tiled-drawing/scrolling/fast-scroll-iframe-latched-mainframe-with-handler.html trunk/LayoutTests/platform/mac-wk2/tiled-drawing/scrolling/fast-scroll-iframe-latched-mainframe.html trunk/LayoutTests/platform/mac-wk2/tiled-drawing/scrolling/fast-scroll-select-latched-mainframe-expected.txt trunk/LayoutTests/platform/mac-wk2/tiled-drawing/scrolling/fast-scroll-select-latched-mainframe-with-handler-expected.txt trunk/LayoutTests/platform/mac-wk2/tiled-drawing/scrolling/fast-scroll-select-latched-mainframe-with-handler.html trunk/LayoutTests/platform/mac-wk2/tiled-drawing/scrolling/fast-scroll-se
[webkit-changes] [183627] trunk/Source/WebInspectorUI
Title: [183627] trunk/Source/WebInspectorUI Revision 183627 Author ago...@igalia.com Date 2015-04-30 10:17:59 -0700 (Thu, 30 Apr 2015) Log Message [GTK] Web Inspector: Remove some unused Images https://bugs.webkit.org/show_bug.cgi?id=15 Reviewed by Carlos Garcia Campos. * UserInterface/Images/gtk/BottomUpTree.svg: Removed. * UserInterface/Images/gtk/Log.png: Removed. * UserInterface/Images/gtk/l...@2x.png: Removed. * UserInterface/Images/gtk/NavigationItemAngleBrackets.svg: Removed. * UserInterface/Images/gtk/NavigationItemBrushAndRuler.svg: Removed. * UserInterface/Images/gtk/NavigationItemBug.svg: Removed. * UserInterface/Images/gtk/NavigationItemFile.svg: Removed. * UserInterface/Images/gtk/NavigationItemLayers.svg: Removed. * UserInterface/Images/gtk/NavigationItemLog.svg: Removed. * UserInterface/Images/gtk/NavigationItemProbes.svg: Removed. * UserInterface/Images/gtk/NavigationItemStopwatch.svg: Removed. * UserInterface/Images/gtk/NavigationItemStorage.svg: Removed. * UserInterface/Images/gtk/NavigationItemVariable.svg: Removed. * UserInterface/Images/gtk/Percent.svg: Removed. * UserInterface/Images/gtk/Reload.svg: Removed. * UserInterface/Images/gtk/SplitToggleDown.svg: Removed. * UserInterface/Images/gtk/Time.svg: Removed. * UserInterface/Images/gtk/Weight.svg: Removed. Modified Paths trunk/Source/WebInspectorUI/ChangeLog Removed Paths trunk/Source/WebInspectorUI/UserInterface/Images/gtk/BottomUpTree.svg trunk/Source/WebInspectorUI/UserInterface/Images/gtk/Log.png trunk/Source/WebInspectorUI/UserInterface/Images/gtk/l...@2x.png trunk/Source/WebInspectorUI/UserInterface/Images/gtk/NavigationItemAngleBrackets.svg trunk/Source/WebInspectorUI/UserInterface/Images/gtk/NavigationItemBrushAndRuler.svg trunk/Source/WebInspectorUI/UserInterface/Images/gtk/NavigationItemBug.svg trunk/Source/WebInspectorUI/UserInterface/Images/gtk/NavigationItemFile.svg trunk/Source/WebInspectorUI/UserInterface/Images/gtk/NavigationItemLayers.svg trunk/Source/WebInspectorUI/UserInterface/Images/gtk/NavigationItemLog.svg trunk/Source/WebInspectorUI/UserInterface/Images/gtk/NavigationItemProbes.svg trunk/Source/WebInspectorUI/UserInterface/Images/gtk/NavigationItemStopwatch.svg trunk/Source/WebInspectorUI/UserInterface/Images/gtk/NavigationItemStorage.svg trunk/Source/WebInspectorUI/UserInterface/Images/gtk/NavigationItemVariable.svg trunk/Source/WebInspectorUI/UserInterface/Images/gtk/Percent.svg trunk/Source/WebInspectorUI/UserInterface/Images/gtk/Reload.svg trunk/Source/WebInspectorUI/UserInterface/Images/gtk/SplitToggleDown.svg trunk/Source/WebInspectorUI/UserInterface/Images/gtk/Time.svg trunk/Source/WebInspectorUI/UserInterface/Images/gtk/Weight.svg Diff Modified: trunk/Source/WebInspectorUI/ChangeLog (183626 => 183627) --- trunk/Source/WebInspectorUI/ChangeLog 2015-04-30 16:17:08 UTC (rev 183626) +++ trunk/Source/WebInspectorUI/ChangeLog 2015-04-30 17:17:59 UTC (rev 183627) @@ -1,3 +1,29 @@ +2015-04-30 Andres Gomez + +[GTK] Web Inspector: Remove some unused Images +https://bugs.webkit.org/show_bug.cgi?id=15 + +Reviewed by Carlos Garcia Campos. + +* UserInterface/Images/gtk/BottomUpTree.svg: Removed. +* UserInterface/Images/gtk/Log.png: Removed. +* UserInterface/Images/gtk/l...@2x.png: Removed. +* UserInterface/Images/gtk/NavigationItemAngleBrackets.svg: Removed. +* UserInterface/Images/gtk/NavigationItemBrushAndRuler.svg: Removed. +* UserInterface/Images/gtk/NavigationItemBug.svg: Removed. +* UserInterface/Images/gtk/NavigationItemFile.svg: Removed. +* UserInterface/Images/gtk/NavigationItemLayers.svg: Removed. +* UserInterface/Images/gtk/NavigationItemLog.svg: Removed. +* UserInterface/Images/gtk/NavigationItemProbes.svg: Removed. +* UserInterface/Images/gtk/NavigationItemStopwatch.svg: Removed. +* UserInterface/Images/gtk/NavigationItemStorage.svg: Removed. +* UserInterface/Images/gtk/NavigationItemVariable.svg: Removed. +* UserInterface/Images/gtk/Percent.svg: Removed. +* UserInterface/Images/gtk/Reload.svg: Removed. +* UserInterface/Images/gtk/SplitToggleDown.svg: Removed. +* UserInterface/Images/gtk/Time.svg: Removed. +* UserInterface/Images/gtk/Weight.svg: Removed. + 2015-04-30 Joseph Pecoraro Web Inspector: Copy not working in Console Deleted: trunk/Source/WebInspectorUI/UserInterface/Images/gtk/BottomUpTree.svg (183626 => 183627) --- trunk/Source/WebInspectorUI/UserInterface/Images/gtk/BottomUpTree.svg 2015-04-30 16:17:08 UTC (rev 183626) +++ trunk/Source/WebInspectorUI/UserInterface/Images/gtk/BottomUpTree.svg 2015-04-30 17:17:59 UTC (rev 183627) @@ -1,5 +0,0 @@ - - - - - Deleted: trunk/Source/WebInspectorUI/UserInterface/Images/gtk/Log.png (Binary files differ) Deleted: trunk/Source/WebInspectorUI/UserInterface/Images/gtk/l...@2x.png (Binary files differ) Deleted: trunk/Source/WebInspec
[webkit-changes] [183626] trunk
Title: [183626] trunk
Revision 183626
Author mrobin...@webkit.org
Date 2015-04-30 09:17:08 -0700 (Thu, 30 Apr 2015)
Log Message
[CMake] Automatically expose WTF_USE_FOO to the build when USE_FOO is exposed
https://bugs.webkit.org/show_bug.cgi?id=144394
Reviewed by Carlos Garcia Campos.
Automatically expose WTF_USE_FOO when USE_FOO is exposed. A side-effect of this change
is that it fixes the redirected XComposite window for GTK+, which was accidentally
disabled in previous reworking of the CMake configuration.
* Source/cmake/OptionsGTK.cmake: We no longer need to expose the WTF_ prefixed
version of USE variables.
* Source/cmake/WebKitFeatures.cmake: Automatically expose WTF_USE_FOO when USE_FOO
is exposed to the build.
Modified Paths
trunk/ChangeLog
trunk/Source/cmake/OptionsGTK.cmake
trunk/Source/cmake/WebKitFeatures.cmake
Diff
Modified: trunk/ChangeLog (183625 => 183626)
--- trunk/ChangeLog 2015-04-30 08:54:05 UTC (rev 183625)
+++ trunk/ChangeLog 2015-04-30 16:17:08 UTC (rev 183626)
@@ -1,3 +1,19 @@
+2015-04-30 Martin Robinson
+
+[CMake] Automatically expose WTF_USE_FOO to the build when USE_FOO is exposed
+https://bugs.webkit.org/show_bug.cgi?id=144394
+
+Reviewed by Carlos Garcia Campos.
+
+Automatically expose WTF_USE_FOO when USE_FOO is exposed. A side-effect of this change
+is that it fixes the redirected XComposite window for GTK+, which was accidentally
+disabled in previous reworking of the CMake configuration.
+
+* Source/cmake/OptionsGTK.cmake: We no longer need to expose the WTF_ prefixed
+version of USE variables.
+* Source/cmake/WebKitFeatures.cmake: Automatically expose WTF_USE_FOO when USE_FOO
+is exposed to the build.
+
2015-04-30 Carlos Garcia Campos
Unreviewed. Bump GTK+ version numbers.
Modified: trunk/Source/cmake/OptionsGTK.cmake (183625 => 183626)
--- trunk/Source/cmake/OptionsGTK.cmake 2015-04-30 08:54:05 UTC (rev 183625)
+++ trunk/Source/cmake/OptionsGTK.cmake 2015-04-30 16:17:08 UTC (rev 183626)
@@ -352,14 +352,12 @@
if (NOT PC_GSTREAMER_MPEGTS_FOUND)
message(FATAL_ERROR "GStreamer MPEG-TS is needed for USE_GSTREAMER_MPEGTS.")
endif ()
-SET_AND_EXPOSE_TO_BUILD(WTF_USE_GSTREAMER_MPEGTS TRUE)
endif ()
if (USE_GSTREAMER_GL)
if (NOT PC_GSTREAMER_GL_FOUND)
message(FATAL_ERROR "GStreamerGL is needed for USE_GSTREAMER_GL.")
endif ()
-SET_AND_EXPOSE_TO_BUILD(WTF_USE_GSTREAMER_GL TRUE)
endif ()
endif ()
@@ -376,7 +374,6 @@
if (NOT LIBNOTIFY_FOUND)
message(FATAL_ERROR "libnotify is needed for USE_LIBNOTIFY.")
endif ()
-SET_AND_EXPOSE_TO_BUILD(WTF_USE_LIBNOTIFY TRUE)
endif ()
if (USE_LIBHYPHEN)
@@ -384,7 +381,6 @@
if (NOT HYPHEN_FOUND)
message(FATAL_ERROR "libhyphen is needed for USE_LIBHYPHEN.")
endif ()
-SET_AND_EXPOSE_TO_BUILD(WTF_USE_LIBHYPHEN 1)
endif ()
set(DERIVED_SOURCES_GOBJECT_DOM_BINDINGS_DIR ${DERIVED_SOURCES_DIR}/webkitdom)
Modified: trunk/Source/cmake/WebKitFeatures.cmake (183625 => 183626)
--- trunk/Source/cmake/WebKitFeatures.cmake 2015-04-30 08:54:05 UTC (rev 183625)
+++ trunk/Source/cmake/WebKitFeatures.cmake 2015-04-30 16:17:08 UTC (rev 183626)
@@ -290,15 +290,28 @@
EXPOSE_VARIABLE_TO_BUILD(${_variable_name})
endmacro()
+macro(_ADD_CONFIGURATION_LINE_TO_HEADER_STRING _string _variable_name _output_variable_name)
+if (${${_variable_name}})
+set(${_string} "${_file_contents}#define ${_output_variable_name} 1\n")
+else ()
+set(${_string} "${_file_contents}#define ${_output_variable_name} 0\n")
+endif ()
+endmacro()
+
macro(CREATE_CONFIGURATION_HEADER)
list(SORT _WEBKIT_CONFIG_FILE_VARIABLES)
set(_file_contents "#ifndef CMAKECONFIG_H\n")
set(_file_contents "${_file_contents}#define CMAKECONFIG_H\n\n")
+
foreach (_variable_name ${_WEBKIT_CONFIG_FILE_VARIABLES})
-if (${${_variable_name}})
-set(_file_contents "${_file_contents}#define ${_variable_name} 1\n")
-else ()
-set(_file_contents "${_file_contents}#define ${_variable_name} 0\n")
+_ADD_CONFIGURATION_LINE_TO_HEADER_STRING(_file_contents ${_variable_name} ${_variable_name})
+
+# WebKit looks for WTF_USE_FOO when calling the USE(FOO) macro. Automatically exposing
+# this definition when USE_FOO is exposed, prevents us from having to expose both (or
+# forgetting to do so).
+string(FIND ${_variable_name} "USE_" _use_string_location)
+if (${_use_string_location} EQUAL 0)
+_ADD_CONFIGURATION_LINE_TO_HEADER_STRING(_file_contents ${_variable_name} "WTF_${_variable_name}")
endif ()
endforeach ()
set(_file_contents "${_file_contents}\n#endif /* CMAKECONFIG_H */\n")
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists
[webkit-changes] [183625] trunk/Source/WebInspectorUI
Title: [183625] trunk/Source/WebInspectorUI
Revision 183625
Author commit-qu...@webkit.org
Date 2015-04-30 01:54:05 -0700 (Thu, 30 Apr 2015)
Log Message
Web Inspector: Copy not working in Console
https://bugs.webkit.org/show_bug.cgi?id=144354
Patch by Joseph Pecoraro on 2015-04-30
Reviewed by Timothy Hatcher.
* UserInterface/Base/Main.js:
(WebInspector._focusedContentView):
Select the inner most content view to check if handleCopyEvent exists.
Previously we were stopping at the top level TabContentView.
Modified Paths
trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/Base/Main.js
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (183624 => 183625)
--- trunk/Source/WebInspectorUI/ChangeLog 2015-04-30 08:37:51 UTC (rev 183624)
+++ trunk/Source/WebInspectorUI/ChangeLog 2015-04-30 08:54:05 UTC (rev 183625)
@@ -1,3 +1,15 @@
+2015-04-30 Joseph Pecoraro
+
+Web Inspector: Copy not working in Console
+https://bugs.webkit.org/show_bug.cgi?id=144354
+
+Reviewed by Timothy Hatcher.
+
+* UserInterface/Base/Main.js:
+(WebInspector._focusedContentView):
+Select the inner most content view to check if handleCopyEvent exists.
+Previously we were stopping at the top level TabContentView.
+
2015-04-29 Timothy Hatcher
Web Inspector: Remove some unused Images
Modified: trunk/Source/WebInspectorUI/UserInterface/Base/Main.js (183624 => 183625)
--- trunk/Source/WebInspectorUI/UserInterface/Base/Main.js 2015-04-30 08:37:51 UTC (rev 183624)
+++ trunk/Source/WebInspectorUI/UserInterface/Base/Main.js 2015-04-30 08:54:05 UTC (rev 183625)
@@ -1534,8 +1534,12 @@
WebInspector._focusedContentView = function()
{
-if (this.tabBrowser.element.isSelfOrAncestor(this.currentFocusElement))
-return this.tabBrowser.selectedTabContentView;
+if (this.tabBrowser.element.isSelfOrAncestor(this.currentFocusElement)) {
+var tabContentView = this.tabBrowser.selectedTabContentView;
+if (tabContentView instanceof WebInspector.ContentBrowserTabContentView)
+return tabContentView.contentBrowser.currentContentView;
+return tabContentView;
+}
if (this.splitContentBrowser.element.isSelfOrAncestor(this.currentFocusElement))
return this.splitContentBrowser.currentContentView;
return null;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [183623] trunk/LayoutTests
Title: [183623] trunk/LayoutTests
Revision 183623
Author an...@apple.com
Date 2015-04-30 00:39:21 -0700 (Thu, 30 Apr 2015)
Log Message
These should be saying HTTP/1.1 not HTTP/1.0
* http/tests/cache/resources/iframe304.php:
* http/tests/cache/resources/iframe304body.php:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/http/tests/cache/resources/iframe304.php
trunk/LayoutTests/http/tests/cache/resources/iframe304body.php
Diff
Modified: trunk/LayoutTests/ChangeLog (183622 => 183623)
--- trunk/LayoutTests/ChangeLog 2015-04-30 07:13:07 UTC (rev 183622)
+++ trunk/LayoutTests/ChangeLog 2015-04-30 07:39:21 UTC (rev 183623)
@@ -1,3 +1,10 @@
+2015-04-30 Antti Koivisto
+
+These should be saying HTTP/1.1 not HTTP/1.0
+
+* http/tests/cache/resources/iframe304.php:
+* http/tests/cache/resources/iframe304body.php:
+
2015-04-29 Joseph Pecoraro
[Win] Update baselines after r183610.
Modified: trunk/LayoutTests/http/tests/cache/resources/iframe304.php (183622 => 183623)
--- trunk/LayoutTests/http/tests/cache/resources/iframe304.php 2015-04-30 07:13:07 UTC (rev 183622)
+++ trunk/LayoutTests/http/tests/cache/resources/iframe304.php 2015-04-30 07:39:21 UTC (rev 183623)
@@ -4,7 +4,7 @@
clearstatcache();
if ($_SERVER["HTTP_IF_MODIFIED_SINCE"]) {
-header("HTTP/1.0 304 Not Modified");
+header("HTTP/1.1 304 Not Modified");
exit();
}
$_one_year_ = 12 * 31 * 24 * 60 * 60;
Modified: trunk/LayoutTests/http/tests/cache/resources/iframe304body.php (183622 => 183623)
--- trunk/LayoutTests/http/tests/cache/resources/iframe304body.php 2015-04-30 07:13:07 UTC (rev 183622)
+++ trunk/LayoutTests/http/tests/cache/resources/iframe304body.php 2015-04-30 07:39:21 UTC (rev 183623)
@@ -4,7 +4,7 @@
clearstatcache();
if ($_SERVER["HTTP_IF_MODIFIED_SINCE"]) {
-header("HTTP/1.0 304 Not Modified");
+header("HTTP/1.1 304 Not Modified");
exit();
}
header('Cache-Control: no-cache');
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [183622] trunk
Title: [183622] trunk
Revision 183622
Author carlo...@webkit.org
Date 2015-04-30 00:13:07 -0700 (Thu, 30 Apr 2015)
Log Message
Unreviewed. Bump GTK+ version numbers.
* Source/cmake/OptionsGTK.cmake:
Modified Paths
trunk/ChangeLog
trunk/Source/cmake/OptionsGTK.cmake
Diff
Modified: trunk/ChangeLog (183621 => 183622)
--- trunk/ChangeLog 2015-04-30 07:08:19 UTC (rev 183621)
+++ trunk/ChangeLog 2015-04-30 07:13:07 UTC (rev 183622)
@@ -1,3 +1,9 @@
+2015-04-30 Carlos Garcia Campos
+
+Unreviewed. Bump GTK+ version numbers.
+
+* Source/cmake/OptionsGTK.cmake:
+
2015-04-29 Ryuan Choi
[EFL] CMake should be failed if openwebrtc package does not exist but ENABLE_MEDIA_STREAM is ON
Modified: trunk/Source/cmake/OptionsGTK.cmake (183621 => 183622)
--- trunk/Source/cmake/OptionsGTK.cmake 2015-04-30 07:08:19 UTC (rev 183621)
+++ trunk/Source/cmake/OptionsGTK.cmake 2015-04-30 07:13:07 UTC (rev 183622)
@@ -2,15 +2,15 @@
include(GNUInstallDirs)
set(PROJECT_VERSION_MAJOR 2)
-set(PROJECT_VERSION_MINOR 7)
-set(PROJECT_VERSION_MICRO 4)
+set(PROJECT_VERSION_MINOR 9)
+set(PROJECT_VERSION_MICRO 0)
set(PROJECT_VERSION ${PROJECT_VERSION_MAJOR}.${PROJECT_VERSION_MINOR}.${PROJECT_VERSION_MICRO})
set(WEBKITGTK_API_VERSION 4.0)
# Libtool library version, not to be confused with API version.
# See http://www.gnu.org/software/libtool/manual/html_node/Libtool-versioning.html
-CALCULATE_LIBRARY_VERSIONS_FROM_LIBTOOL_TRIPLE(WEBKIT2 42 0 5)
-CALCULATE_LIBRARY_VERSIONS_FROM_LIBTOOL_TRIPLE(_javascript_CORE 19 3 1)
+CALCULATE_LIBRARY_VERSIONS_FROM_LIBTOOL_TRIPLE(WEBKIT2 44 0 7)
+CALCULATE_LIBRARY_VERSIONS_FROM_LIBTOOL_TRIPLE(_javascript_CORE 20 0 2)
# These are shared variables, but we special case their definition so that we can use the
# CMAKE_INSTALL_* variables that are populated by the GNUInstallDirs macro.
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [183621] trunk/Tools
Title: [183621] trunk/Tools
Revision 183621
Author commit-qu...@webkit.org
Date 2015-04-30 00:08:19 -0700 (Thu, 30 Apr 2015)
Log Message
Fix return code issue, check return code of safari process and dump results to log
https://bugs.webkit.org/show_bug.cgi?id=144436
Patch by Dewei Zhu on 2015-04-30
Reviewed by Ryosuke Niwa.
* Scripts/run-benchmark:
* Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
(BenchmarkRunner.dump): Correct typo.
(BenchmarkRunner.wrap): Add results to console.
* Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py: Check return code to detect Safari crashes.
(OSXSafariDriver.prepareEnv):
(OSXSafariDriver.launchUrl):
(OSXSafariDriver.closeBrowsers):
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/run-benchmark
trunk/Tools/Scripts/webkitpy/benchmark_runner/benchmark_runner.py
trunk/Tools/Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py
Diff
Modified: trunk/Tools/ChangeLog (183620 => 183621)
--- trunk/Tools/ChangeLog 2015-04-30 06:43:57 UTC (rev 183620)
+++ trunk/Tools/ChangeLog 2015-04-30 07:08:19 UTC (rev 183621)
@@ -1,3 +1,19 @@
+2015-04-30 Dewei Zhu
+
+Fix return code issue, check return code of safari process and dump results to log
+https://bugs.webkit.org/show_bug.cgi?id=144436
+
+Reviewed by Ryosuke Niwa.
+
+* Scripts/run-benchmark:
+* Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
+(BenchmarkRunner.dump): Correct typo.
+(BenchmarkRunner.wrap): Add results to console.
+* Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py: Check return code to detect Safari crashes.
+(OSXSafariDriver.prepareEnv):
+(OSXSafariDriver.launchUrl):
+(OSXSafariDriver.closeBrowsers):
+
2015-04-29 Joseph Pecoraro
Should no longer need to worry about very old versions of Xcode
Modified: trunk/Tools/Scripts/run-benchmark (183620 => 183621)
--- trunk/Tools/Scripts/run-benchmark 2015-04-30 06:43:57 UTC (rev 183620)
+++ trunk/Tools/Scripts/run-benchmark 2015-04-30 07:08:19 UTC (rev 183621)
@@ -2,6 +2,8 @@
import argparse
import logging
+import sys
+
from webkitpy.benchmark_runner.benchmark_runner import BenchmarkRunner
@@ -34,4 +36,4 @@
return runner.execute()
if __name__ == '__main__':
-main()
+sys.exit(main())
Modified: trunk/Tools/Scripts/webkitpy/benchmark_runner/benchmark_runner.py (183620 => 183621)
--- trunk/Tools/Scripts/webkitpy/benchmark_runner/benchmark_runner.py 2015-04-30 06:43:57 UTC (rev 183620)
+++ trunk/Tools/Scripts/webkitpy/benchmark_runner/benchmark_runner.py 2015-04-30 07:08:19 UTC (rev 183621)
@@ -72,7 +72,7 @@
@classmethod
def dump(cls, results, outputFile):
-_log.info('Dumpping the results to file')
+_log.info('Dumping the results to file')
try:
with open(outputFile, 'w') as fp:
json.dump(results, fp)
@@ -82,11 +82,13 @@
@classmethod
def wrap(cls, dicts):
+_log.info('Merging following results:\n%s', json.dumps(dicts))
if not dicts:
return None
ret = {}
for dic in dicts:
ret = cls.merge(ret, dic)
+_log.info('Results after merging:\n%s', json.dumps(ret))
return ret
@classmethod
Modified: trunk/Tools/Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py (183620 => 183621)
--- trunk/Tools/Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py 2015-04-30 06:43:57 UTC (rev 183620)
+++ trunk/Tools/Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py 2015-04-30 07:08:19 UTC (rev 183621)
@@ -17,6 +17,7 @@
class OSXSafariDriver(BrowserDriver):
def prepareEnv(self):
+self.safariProcess = None
self.closeBrowsers()
forceRemove(os.path.join(os.path.expanduser('~'), 'Library/Saved Application State/com.apple.Safari.savedState'))
forceRemove(os.path.join(os.path.expanduser('~'), 'Library/Safari/LastSession.plist'))
@@ -26,7 +27,7 @@
args = [os.path.join(browserBuildPath, 'Safari.app/Contents/MacOS/Safari')]
args.extend(self.safariPreferences)
_log.info('Launching safari: %s with url: %s' % (args[0], url))
-subprocess.Popen(args, env={'DYLD_FRAMEWORK_PATH': browserBuildPath, 'DYLD_LIBRARY_PATH': browserBuildPath}, stdin=subprocess.PIPE, stdout=subprocess.PIPE, stderr=subprocess.PIPE)
+self.safariProcess = subprocess.Popen(args, env={'DYLD_FRAMEWORK_PATH': browserBuildPath, 'DYLD_LIBRARY_PATH': browserBuildPath}, stdin=subprocess.PIPE, stdout=subprocess.PIPE, stderr=subprocess.PIPE)
# Stop for initialization of the safari process, otherwise, open
# command may use the system safari.
time.sleep(3)
@@ -37,3 +38,7 @@
safariInstances = NSRunningApplication.runningApplicationsWithBundleIdentifier_('com.apple.Safari')
for safariInstance
