[webkit-changes] [188224] branches/safari-601.1-branch/Source/WebCore
Title: [188224] branches/safari-601.1-branch/Source/WebCore Revision 188224 Author dburk...@apple.com Date 2015-08-10 13:36:48 -0700 (Mon, 10 Aug 2015) Log Message Merge r188196. rdar://problem/22192773 Modified Paths branches/safari-601.1-branch/Source/WebCore/ChangeLog branches/safari-601.1-branch/Source/WebCore/Modules/mediasession/WebMediaSessionManager.cpp Diff Modified: branches/safari-601.1-branch/Source/WebCore/ChangeLog (188223 => 188224) --- branches/safari-601.1-branch/Source/WebCore/ChangeLog 2015-08-10 20:36:10 UTC (rev 188223) +++ branches/safari-601.1-branch/Source/WebCore/ChangeLog 2015-08-10 20:36:48 UTC (rev 188224) @@ -1,5 +1,23 @@ 2015-08-10 Dana Burkart +Merge r188196. rdar://problem/22192773 + +2015-08-09 Eric Carlson + +[Mac] Always require ExternalDeviceAutoPlayCandidate flag to AirPlay automatically +https://bugs.webkit.org/show_bug.cgi?id=147801 + +Reviewed by Dean Jackson. + +Test: http/tests/media/video-media-document-disposition-download.html + +* Modules/mediasession/WebMediaSessionManager.cpp: +(WebCore::WebMediaSessionManager::configurePlaybackTargetClients): Don't tell the last element + to begin playing to the target unless the ExternalDeviceAutoPlayCandidate flag is set and + it is not currently playing. + +2015-08-10 Dana Burkart + Merge r188190. rdar://problem/22191482 2015-08-08 Commit Queue Modified: branches/safari-601.1-branch/Source/WebCore/Modules/mediasession/WebMediaSessionManager.cpp (188223 => 188224) --- branches/safari-601.1-branch/Source/WebCore/Modules/mediasession/WebMediaSessionManager.cpp 2015-08-10 20:36:10 UTC (rev 188223) +++ branches/safari-601.1-branch/Source/WebCore/Modules/mediasession/WebMediaSessionManager.cpp 2015-08-10 20:36:48 UTC (rev 188224) @@ -272,7 +272,7 @@ indexOfClientWillPlayToTarget = indexOfClientThatRequestedPicker; if (indexOfClientWillPlayToTarget == notFound && indexOfLastClientToRequestPicker != notFound) indexOfClientWillPlayToTarget = indexOfLastClientToRequestPicker; -if (indexOfClientWillPlayToTarget == notFound && haveActiveRoute) +if (indexOfClientWillPlayToTarget == notFound && haveActiveRoute && flagsAreSet(m_clientState[0]->flags, MediaProducer::ExternalDeviceAutoPlayCandidate) && !flagsAreSet(m_clientState[0]->flags, MediaProducer::IsPlayingVideo)) indexOfClientWillPlayToTarget = 0; LOG(Media, "WebMediaSessionManager::configurePlaybackTargetClients - indexOfClientWillPlayToTarget = %zu", indexOfClientWillPlayToTarget); ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [188225] branches/safari-601.1-branch
Title: [188225] branches/safari-601.1-branch Revision 188225 Author dburk...@apple.com Date 2015-08-10 13:38:50 -0700 (Mon, 10 Aug 2015) Log Message Merge r188182. rdar://problem/21254835 Modified Paths branches/safari-601.1-branch/LayoutTests/ChangeLog branches/safari-601.1-branch/LayoutTests/http/tests/contentextensions/text-track-blocked-expected.txt branches/safari-601.1-branch/LayoutTests/platform/mac/media/track/track-cue-rendering-horizontal-expected.txt branches/safari-601.1-branch/Source/WebCore/ChangeLog branches/safari-601.1-branch/Source/WebCore/English.lproj/mediaControlsLocalizedStrings.js branches/safari-601.1-branch/Source/WebCore/Modules/mediacontrols/mediaControlsApple.css branches/safari-601.1-branch/Source/WebCore/Modules/mediacontrols/mediaControlsApple.js branches/safari-601.1-branch/Source/WebCore/Modules/mediacontrols/mediaControlsiOS.css Added Paths branches/safari-601.1-branch/LayoutTests/media/video-controls-show-on-kb-or-ax-event-expected.txt branches/safari-601.1-branch/LayoutTests/media/video-controls-show-on-kb-or-ax-event.html Diff Modified: branches/safari-601.1-branch/LayoutTests/ChangeLog (188224 => 188225) --- branches/safari-601.1-branch/LayoutTests/ChangeLog 2015-08-10 20:36:48 UTC (rev 188224) +++ branches/safari-601.1-branch/LayoutTests/ChangeLog 2015-08-10 20:38:50 UTC (rev 188225) @@ -1,5 +1,21 @@ 2015-08-10 Dana Burkart +Merge r188182. rdar://problem/21254835 + +2015-08-07 James Craig + +REGRESSION(r184722) AX: WebKit video playback toolbar removed from DOM; no longer accessible to VoiceOver +https://bugs.webkit.org/show_bug.cgi?id=145684 + +Reviewed by Dean Jackson. + +* http/tests/contentextensions/text-track-blocked-expected.txt: Minor update to test case expectation. +* media/video-controls-show-on-kb-or-ax-event-expected.txt: Added. +* media/video-controls-show-on-kb-or-ax-event.html: New test validates video controls can be displayed without the need for a mouse. +* platform/mac/media/track/track-cue-rendering-horizontal-expected.txt: Minor update to test case expectation. + +2015-08-10 Dana Burkart + Merge r188190. rdar://problem/22191482 2015-08-08 Commit Queue Modified: branches/safari-601.1-branch/LayoutTests/http/tests/contentextensions/text-track-blocked-expected.txt (188224 => 188225) --- branches/safari-601.1-branch/LayoutTests/http/tests/contentextensions/text-track-blocked-expected.txt 2015-08-10 20:36:48 UTC (rev 188224) +++ branches/safari-601.1-branch/LayoutTests/http/tests/contentextensions/text-track-blocked-expected.txt 2015-08-10 20:38:50 UTC (rev 188225) @@ -14,3 +14,5 @@ RenderVideo {VIDEO} at (0,18) size 320x240 layer at (8,26) size 320x240 RenderFlexibleBox {DIV} at (0,0) size 320x240 +layer at (8,256) size 320x10 + RenderButton {BUTTON} at (0,230) size 320x10 [bgcolor=#C0C0C0] [border: (2px outset #C0C0C0)] Added: branches/safari-601.1-branch/LayoutTests/media/video-controls-show-on-kb-or-ax-event-expected.txt (0 => 188225) --- branches/safari-601.1-branch/LayoutTests/media/video-controls-show-on-kb-or-ax-event-expected.txt (rev 0) +++ branches/safari-601.1-branch/LayoutTests/media/video-controls-show-on-kb-or-ax-event-expected.txt 2015-08-10 20:38:50 UTC (rev 188225) @@ -0,0 +1,6 @@ +This tests that, after the video controls fade out, they can be shown when VoiceOver or a keyboard user clicks the hidden "Show Controls" button. + +PASS + + + Added: branches/safari-601.1-branch/LayoutTests/media/video-controls-show-on-kb-or-ax-event.html (0 => 188225) --- branches/safari-601.1-branch/LayoutTests/media/video-controls-show-on-kb-or-ax-event.html (rev 0) +++ branches/safari-601.1-branch/LayoutTests/media/video-controls-show-on-kb-or-ax-event.html 2015-08-10 20:38:50 UTC (rev 188225) @@ -0,0 +1,42 @@ + + +This tests that, after the video controls fade out, they can be shown when VoiceOver or a keyboard user clicks the hidden "Show Controls" button. + + +FAIL: Test did not run. + + +if (window.testRunner) { +testRunner.waitUntilDone(); +testRunner.dumpAsText(); +} + +function playing() { + +// Mouse over the video then mouse out to hide controls more quickly. +eventSender.mouseMoveTo(100,100); +eventSender.mouseMoveTo(1,1); + +setTimeout(function() { +var result = document.getElementById("result"); +result.innerHTML = ""; +var root = internals.shadowRoot(document.getElementById("video")) + +var button = root.firstChild.querySelector('button'); +if (button) { +button.focus(); +eventSender.keyDown(' '); // Use keyboard to press the selected button. +} else { +result.innerHTML += 'FAIL: "Show Controls" button is not available.'; +
[webkit-changes] [188226] trunk/Source/WebInspectorUI
Title: [188226] trunk/Source/WebInspectorUI Revision 188226 Author drou...@apple.com Date 2015-08-10 13:49:47 -0700 (Mon, 10 Aug 2015) Log Message Web Inspector: Add VisualStyleSelectorSection https://bugs.webkit.org/show_bug.cgi?id=147572 Reviewed by Brian Burg. Adds a section to the new Visual style sidebar panel that contains the list of styles for the currently selected node. * UserInterface/Models/CSSRule.js: (WebInspector.CSSRule.prototype.get mediaText): Returns a string containing the list of media queries. * UserInterface/Models/CSSStyleDeclaration.js: (WebInspector.CSSStyleDeclaration): (WebInspector.CSSStyleDeclaration.prototype.set text): (WebInspector.CSSStyleDeclaration.prototype.get modified): (WebInspector.CSSStyleDeclaration.prototype.resetText): (WebInspector.CSSStyleDeclaration.prototype.generateCSSRuleString): Generates a formatted string of the style text. * UserInterface/Views/CSSStyleDeclarationSection.js: (WebInspector.CSSStyleDeclarationSection.prototype._handleContextMenuEvent): (WebInspector.CSSStyleDeclarationSection.prototype._generateCSSRuleString): Deleted. * UserInterface/Views/VisualStyleSelectorSection.css: Added. (.details-section.visual-style-selector-section > .header): (.details-section.visual-style-selector-section:not(.collapsed) > .header): (@media (-webkit-min-device-pixel-ratio: 2)): (.details-section.visual-style-selector-section > .header > .current-selector): (.visual-style-selector-section.details-section:not(.collapsed) > .header > .current-selector): (.details-section.visual-style-selector-section > .header > .current-selector > .icon): (.details-section.visual-style-selector-section > .header > .current-selector > span): (.details-section.visual-style-selector-section > .header > .controls): (.details-section.visual-style-selector-section.collapsed > .header > .controls): (.details-section.visual-style-selector-section > .header > .controls > .visual-style-selector-section-add-rule): (.details-section.visual-style-selector-section > .content > .selectors): (.details-section.visual-style-selector-section > .content > .selectors > .selector-list): (.details-section.visual-style-selector-section > .content > .selectors > .selector-list > .visual-style-selector-item:nth-child(odd)): (.details-section.visual-style-selector-section > .content > .selectors > .selector-list > .section-divider): (.details-section.visual-style-selector-section > .content > .selectors > .selector-list > .section-divider > .icon): (.details-section.visual-style-selector-section > .content > .selectors > .selector-list > .section-divider > :matches(.disclosure-button, .icon)): (.details-section.visual-style-selector-section > .content > .selectors > .selector-list > .section-divider > .titles > .title): (.details-section.visual-style-selector-section > .content > .selectors > .selector-list > .section-divider ~ .visual-style-selector-item:nth-child(even)): (.details-section.visual-style-selector-section > .content > .selectors > .selector-list > .section-divider ~ .visual-style-selector-item:nth-child(odd)): * UserInterface/Views/VisualStyleSelectorSection.js: Added. (WebInspector.VisualStyleSelectorSection): (WebInspector.VisualStyleSelectorSection.prototype.update.createSelectorItem): (WebInspector.VisualStyleSelectorSection.prototype.update.uniqueOrderedRules): (WebInspector.VisualStyleSelectorSection.prototype.update.insertAllMatchingPseudoRules): (WebInspector.VisualStyleSelectorSection.prototype.update): (WebInspector.VisualStyleSelectorSection.prototype.currentStyle): (WebInspector.VisualStyleSelectorSection.prototype._selectorChanged): (WebInspector.VisualStyleSelectorSection.prototype._styleTextReset): (WebInspector.VisualStyleSelectorSection.prototype._addNewRule): (WebInspector.VisualStyleSelectorSection.prototype._treeElementCheckboxToggled): (WebInspector.VisualStyleSelectorSection.prototype._handleMouseOver): (WebInspector.VisualStyleSelectorSection.prototype._handleMouseOut): * UserInterface/Views/VisualStyleSelectorTreeItem.css: (.item.visual-style-selector-item): (.item.visual-style-selector-item.selected): (.item.visual-style-selector-item > .disclosure-button): (.item.visual-style-selector-item > input[type="checkbox"]): (.item.visual-style-selector-item > .icon): (.item.visual-style-selector-item.modified > .icon): (.item.visual-style-selector-item.selector-invalid > .icon): (.item.visual-style-selector-item.selector-invalid > .titles > .title): (.item.visual-style-selector-item.selector-invalid > .titles > .title::before): (.item.visual-style-selector-item > .titles): (.item.visual-style-selector-item:not(.dom-element-icon) > .titles > .title): (.item.visual-style-selector-item:not(.dom-element-icon).editable > .titles > .title): (.item.visual-style-selector-item:not(.dom-element-icon).editable > .titles > .title:focus): (.item.visual-style-selector-item > .titles > .subtitle::before): (.item.visual-style-selector-item > .titles > .subtitle): * Us
[webkit-changes] [188227] trunk/Source/WebCore
Title: [188227] trunk/Source/WebCore Revision 188227 Author drou...@apple.com Date 2015-08-10 13:51:32 -0700 (Mon, 10 Aug 2015) Log Message Web Inspector: [iOS] Allow inspector to retrieve a list of system fonts https://bugs.webkit.org/show_bug.cgi?id=147033 Reviewed by Joseph Pecoraro. Implement systemFontFamilies for iOS. * platform/graphics/ios/FontCacheIOS.mm: (WebCore::FontCache::systemFontFamilies): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/platform/graphics/ios/FontCacheIOS.mm Diff Modified: trunk/Source/WebCore/ChangeLog (188226 => 188227) --- trunk/Source/WebCore/ChangeLog 2015-08-10 20:49:47 UTC (rev 188226) +++ trunk/Source/WebCore/ChangeLog 2015-08-10 20:51:32 UTC (rev 188227) @@ -1,5 +1,17 @@ 2015-08-10 Devin Rousso +Web Inspector: [iOS] Allow inspector to retrieve a list of system fonts +https://bugs.webkit.org/show_bug.cgi?id=147033 + +Reviewed by Joseph Pecoraro. + +Implement systemFontFamilies for iOS. + +* platform/graphics/ios/FontCacheIOS.mm: +(WebCore::FontCache::systemFontFamilies): + +2015-08-10 Devin Rousso + Web Inspector: Invalid selectors can be applied to the stylesheet https://bugs.webkit.org/show_bug.cgi?id=147230 Modified: trunk/Source/WebCore/platform/graphics/ios/FontCacheIOS.mm (188226 => 188227) --- trunk/Source/WebCore/platform/graphics/ios/FontCacheIOS.mm 2015-08-10 20:49:47 UTC (rev 188226) +++ trunk/Source/WebCore/platform/graphics/ios/FontCacheIOS.mm 2015-08-10 20:51:32 UTC (rev 188227) @@ -33,6 +33,7 @@ #import "CoreTextSPI.h" #import "FontCascade.h" #import "RenderThemeIOS.h" +#import #import #import #import @@ -472,8 +473,25 @@ Vector FontCache::systemFontFamilies() { -// FIXME: Web Inspector: [iOS] Allow inspector to retrieve a list of system fonts +// FIXME: Vector fontFamilies; +auto emptyFontDescriptor = adoptCF(CTFontDescriptorCreateWithAttributes((CFDictionaryRef) @{ })); +auto matchedDescriptors = adoptCF(CTFontDescriptorCreateMatchingFontDescriptors(emptyFontDescriptor.get(), nullptr)); +if (!matchedDescriptors) +return fontFamilies; + +CFIndex numMatches = CFArrayGetCount(matchedDescriptors.get()); +if (!numMatches) +return fontFamilies; + +HashSet visited; +for (CFIndex i = 0; i < numMatches; ++i) { +auto fontDescriptor = static_cast(CFArrayGetValueAtIndex(matchedDescriptors.get(), i)); +if (auto familyName = adoptCF(static_cast(CTFontDescriptorCopyAttribute(fontDescriptor, kCTFontFamilyNameAttribute +visited.add(familyName.get()); +} + +copyToVector(visited, fontFamilies); return fontFamilies; } ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [188228] trunk/Source/WebKit2
Title: [188228] trunk/Source/WebKit2 Revision 188228 Author wei...@apple.com Date 2015-08-10 13:51:54 -0700 (Mon, 10 Aug 2015) Log Message Replace WebPageConfiguration with API::PageConfiguration and expose a C-SPI accessor for it https://bugs.webkit.org/show_bug.cgi?id=147811 Reviewed by Darin Adler. - Adds the missing pieces from WebPageConfiguration into API::PageConfiguration. - Adds C-SPI to set and get the WebsiteDataStore on the WKPageConfigurationRef. - Uses API::PageConfiguration to pass configuration information from WKWebView/WKView to WebPageProxy. - Stores the API::PageConfiguration on the WebPageProxy and exposes a new C-SPI function, WKPageCopyPageConfiguration, to get a copy of it. * UIProcess/API/APIPageConfiguration.cpp: (API::PageConfiguration::create): (API::PageConfiguration::PageConfiguration): (API::PageConfiguration::~PageConfiguration): (API::PageConfiguration::copy): (API::PageConfiguration::processPool): (API::PageConfiguration::setRelatedPage): (API::PageConfiguration::visitedLinkProvider): (API::PageConfiguration::setVisitedLinkProvider): (API::PageConfiguration::websiteDataStore): (API::PageConfiguration::setWebsiteDataStore): (API::PageConfiguration::sessionID): (API::PageConfiguration::setSessionID): (API::PageConfiguration::webPageConfiguration): Deleted. * UIProcess/API/APIPageConfiguration.h: (API::PageConfiguration::preferenceValues): (API::PageConfiguration::treatsSHA1SignedCertificatesAsInsecure): (API::PageConfiguration::setTreatsSHA1SignedCertificatesAsInsecure): (API::PageConfiguration::alwaysRunsAtForegroundPriority): (API::PageConfiguration::setAlwaysRunsAtForegroundPriority): (API::PageConfiguration::create): Deleted. * UIProcess/API/C/WKPage.cpp: (WKPageGetPageGroup): (WKPageCopyPageConfiguration): (WKPageLoadURL): * UIProcess/API/C/WKPage.h: * UIProcess/API/C/WKPageConfigurationRef.cpp: (WKPageConfigurationSetRelatedPage): (WKPageConfigurationGetWebsiteDataStore): (WKPageConfigurationSetWebsiteDataStore): * UIProcess/API/C/WKPageConfigurationRef.h: * UIProcess/API/Cocoa/WKWebView.mm: (-[WKWebView initWithFrame:configuration:]): * UIProcess/API/ios/WKViewIOS.mm: (-[WKView _commonInitializationWithContextRef:pageGroupRef:relatedToPage:]): * UIProcess/API/mac/WKView.mm: (-[WKView _setPrimaryTrackingArea:]): (-[WKView initWithFrame:processPool:configuration:webView:]): (-[WKView initWithFrame:contextRef:pageGroupRef:relatedToPage:]): (-[WKView initWithFrame:configurationRef:]): (-[WKView wantsUpdateLayer]): * UIProcess/API/mac/WKViewInternal.h: * UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::create): (WebKit::WebPageProxy::WebPageProxy): (WebKit::WebPageProxy::~WebPageProxy): (WebKit::WebPageProxy::configuration): (WebKit::WebPageProxy::processIdentifier): * UIProcess/WebPageProxy.h: (WebKit::WebPageProxy::pageID): (WebKit::WebPageProxy::sessionID): * UIProcess/WebProcessPool.cpp: (WebKit::WebProcessPool::createNewWebProcessRespectingProcessCountLimit): (WebKit::WebProcessPool::createWebPage): (WebKit::WebProcessPool::download): * UIProcess/WebProcessPool.h: * UIProcess/WebProcessProxy.cpp: (WebKit::WebProcessProxy::webPage): (WebKit::WebProcessProxy::createWebPage): * UIProcess/WebProcessProxy.h: (WebKit::WebProcessProxy::processPool): * UIProcess/ios/WKContentView.h: * UIProcess/ios/WKContentView.mm: (-[WKContentView _commonInitializationWithProcessPool:configuration:]): (-[WKContentView initWithFrame:processPool:configuration:webView:]): (-[WKContentView initWithFrame:processPool:configuration:wkView:]): (-[WKContentView dealloc]): Modified Paths trunk/Source/WebKit2/CMakeLists.txt trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/UIProcess/API/APIPageConfiguration.cpp trunk/Source/WebKit2/UIProcess/API/APIPageConfiguration.h trunk/Source/WebKit2/UIProcess/API/C/WKPage.cpp trunk/Source/WebKit2/UIProcess/API/C/WKPage.h trunk/Source/WebKit2/UIProcess/API/C/WKPageConfigurationRef.cpp trunk/Source/WebKit2/UIProcess/API/C/WKPageConfigurationRef.h trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebContext.cpp trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebViewBase.cpp trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebViewBasePrivate.h trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebsiteDataManager.cpp trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebsiteDataManagerPrivate.h trunk/Source/WebKit2/UIProcess/API/ios/WKViewIOS.mm trunk/Source/WebKit2/UIProcess/API/mac/WKView.mm trunk/Source/WebKit2/UIProcess/API/mac/WKViewInternal.h trunk/Source/WebKit2/UIProcess/CoordinatedGraphics/WebView.cpp trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp trunk/Source/WebKit2/UIProcess/WebPageProxy.h trunk/Source/WebKit2/UIProcess/WebProcessPool.cpp trunk/Source/WebKit2/UIProcess/WebProcessPool.h trunk/Source/WebKit2/UIProcess/WebProcessProxy.cpp trunk/Source/WebKit2/UIProcess/WebProcessProxy.h trunk/Source/WebKit2/UIProcess/ios/WKContentView.h trunk/Source/WebKit2/UIProcess/ios/WKContentView.mm Diff Modifi
[webkit-changes] [188229] trunk/Source/WebInspectorUI
Title: [188229] trunk/Source/WebInspectorUI Revision 188229 Author drou...@apple.com Date 2015-08-10 13:56:18 -0700 (Mon, 10 Aug 2015) Log Message Web Inspector: Add different types of non-numerical Visual editors for CSS properties https://bugs.webkit.org/show_bug.cgi?id=147711 Added editors for keyword based CSS properties for use in the Visual style details panel in the CSS sidebar. Also added images for keyword values that are simple enough to be conveyed in an image. Reviewed by Brian Burg. * UserInterface/Images/ClearBoth.svg: Added. * UserInterface/Images/ClearLeft.svg: Added. * UserInterface/Images/ClearRight.svg: Added. * UserInterface/Images/FloatLeft.svg: Added. * UserInterface/Images/FloatRight.svg: Added. * UserInterface/Images/FontStyleItalic.svg: Added. * UserInterface/Images/FontStyleNormal.svg: Added. * UserInterface/Images/FontVariantSmallCaps.svg: Added. * UserInterface/Images/TextAlignCenter.svg: Added. * UserInterface/Images/TextAlignJustify.svg: Added. * UserInterface/Images/TextAlignLeft.svg: Added. * UserInterface/Images/TextAlignRight.svg: Added. * UserInterface/Images/TextDecorationLineThrough.svg: Added. * UserInterface/Images/TextDecorationOverline.svg: Added. * UserInterface/Images/TextDecorationUnderline.svg: Added. * UserInterface/Images/TextTransformCapitalize.svg: Added. * UserInterface/Images/TextTransformLowercase.svg: Added. * UserInterface/Images/TextTransformUppercase.svg: Added. * UserInterface/Images/VisualStyleNone.svg: Added. * UserInterface/Views/CSSStyleDeclarationTextEditor.js: (WebInspector.CSSStyleDeclarationTextEditor.prototype._createColorSwatches.update): (WebInspector.CSSStyleDeclarationTextEditor.prototype._createColorSwatches): Changed color swatch title. * UserInterface/Views/Slider.js: (WebInspector.Slider): (WebInspector.Slider.prototype.set value): (WebInspector.Slider.prototype.set knobX): (WebInspector.Slider.prototype.get maxX): If the given value is below 0, reset it to 0. (WebInspector.Slider.prototype._handleMousedown): (WebInspector.Slider.prototype._handleMousemove): (WebInspector.Slider.prototype.get _maxX): Deleted. * UserInterface/Views/VisualStyleColorPicker.css: Added. (.visual-style-property-container.input-color-picker > .visual-style-property-value-container): (.visual-style-property-container.input-color-picker > .visual-style-property-value-container > .visual-style-special-property-placeholder): (.visual-style-property-container.input-color-picker > .visual-style-property-value-container > .color-swatch): (.visual-style-property-container.input-color-picker > .visual-style-property-value-container > .color-swatch:hover): (.visual-style-property-container.input-color-picker > .visual-style-property-value-container > .color-swatch:active): (.visual-style-property-container.input-color-picker > .visual-style-property-value-container > .color-swatch > span): (.visual-style-property-container.input-color-picker > .visual-style-property-value-container > input): (.visual-style-property-container.input-color-picker.multiple > .visual-style-property-value-container > .visual-style-multiple-property-placeholder): * UserInterface/Views/VisualStyleColorPicker.js: Added. (WebInspector.VisualStyleColorPicker): (WebInspector.VisualStyleColorPicker.prototype.get value): (WebInspector.VisualStyleColorPicker.prototype.set value): (WebInspector.VisualStyleColorPicker.prototype.get placeholder): (WebInspector.VisualStyleColorPicker.prototype.set placeholder): (WebInspector.VisualStyleColorPicker.prototype.get synthesizedValue): (WebInspector.VisualStyleColorPicker.prototype.get hasCompletions): (WebInspector.VisualStyleColorPicker.prototype.set completions): (WebInspector.VisualStyleColorPicker.prototype._updateColorSwatch): (WebInspector.VisualStyleColorPicker.prototype._colorSwatchClicked): (WebInspector.VisualStyleColorPicker.prototype._colorPickerColorDidChange): (WebInspector.VisualStyleColorPicker.prototype._completionClicked): (WebInspector.VisualStyleColorPicker.prototype._textInputKeyDown): (WebInspector.VisualStyleColorPicker.prototype._textInputKeyUp): (WebInspector.VisualStyleColorPicker.prototype._showCompletionsIfAble): (WebInspector.VisualStyleColorPicker.prototype._hideCompletions): (WebInspector.VisualStyleColorPicker.prototype._toggleTabbingOfSelectableElements): * UserInterface/Views/VisualStyleKeywordCheckbox.css: Added. (.visual-style-property-container.keyword-checkbox > .visual-style-property-value-container): (.visual-style-property-container.keyword-checkbox > .visual-style-property-value-container > input): (.visual-style-property-container.keyword-checkbox > .visual-style-property-value-container > div): * UserInterface/Views/VisualStyleKeywordCheckbox.js: Added. (WebInspector.VisualStyleKeywordCheckbox): (WebInspector.VisualStyleKeywordCheckbox.prototype.get value): (WebInspector.VisualStyleKeywordCheckbox.prototype.set value): (WebInspector.VisualStyleKeywordCheckbox.prototype.get synthesizedValue): (We
[webkit-changes] [188230] trunk/Websites/test-results
Title: [188230] trunk/Websites/test-results Revision 188230 Author dburk...@apple.com Date 2015-08-10 14:35:54 -0700 (Mon, 10 Aug 2015) Log Message Fix flakiness dashboard stability and performance issues. https://bugs.webkit.org/show_bug.cgi?id=147835 Reviewed by Ryosuke Niwa. * init-database.sql: * public/.htaccess: * public/include/json-shared.php: * public/include/test-results.php: Modified Paths trunk/Websites/test-results/ChangeLog trunk/Websites/test-results/init-database.sql trunk/Websites/test-results/public/.htaccess trunk/Websites/test-results/public/include/json-shared.php trunk/Websites/test-results/public/include/test-results.php Diff Modified: trunk/Websites/test-results/ChangeLog (188229 => 188230) --- trunk/Websites/test-results/ChangeLog 2015-08-10 20:56:18 UTC (rev 188229) +++ trunk/Websites/test-results/ChangeLog 2015-08-10 21:35:54 UTC (rev 188230) @@ -1,3 +1,15 @@ +2015-08-10 Dana Burkart + +Fix flakiness dashboard stability and performance issues. +https://bugs.webkit.org/show_bug.cgi?id=147835 + +Reviewed by Ryosuke Niwa. + +* init-database.sql: +* public/.htaccess: +* public/include/json-shared.php: +* public/include/test-results.php: + 2014-01-23 Ryosuke Niwa Upstream changes to json-shared.php from the perf dashboard @@ -535,7 +547,7 @@ (TestResultsView._createResultCell): Show the test time and the expected result. (TestResultsView._createTestResultRow): Compute the slowest run and also round time to tenth of second for time less than 10s or second if it's more than 10s so that the test time will always be shown in two digits. -Also show the bug number and the latest expected result on the left columns after linkifying the bug numbers. +Also show the bug number and the latest expected result on the left columns after linkifying the bug numbers. (TestResultsView._matchesFailureType): Added. Determines whether results is of a particular failure type. (TestResultsView._populateBuilderPane): (TestResultsView.fetchFailingTestsForBuilder): Store the failure type such as flaky, wrongtestexpectations. @@ -576,4 +588,3 @@ loadTestsFromLocationHash. (TestResultsView.loadTestsFromLocationHash): Take care of both 'tests' and 'builder' components. (fetchManifest): Setup the UI to select a builder. - Modified: trunk/Websites/test-results/init-database.sql (188229 => 188230) --- trunk/Websites/test-results/init-database.sql 2015-08-10 20:56:18 UTC (rev 188229) +++ trunk/Websites/test-results/init-database.sql 2015-08-10 21:35:54 UTC (rev 188230) @@ -51,7 +51,7 @@ reftest_type varchar(64)); CREATE TABLE results ( -id serial PRIMARY KEY, +id bigserial PRIMARY KEY, test integer REFERENCES tests ON DELETE CASCADE, build integer REFERENCES builds ON DELETE CASCADE, expected varchar(64) NOT NULL, @@ -64,4 +64,4 @@ CREATE INDEX results_build ON results(build); CREATE INDEX results_is_flaky ON results(is_flaky); -SET work_mem='50MB'; +SET work_mem='1024MB'; Modified: trunk/Websites/test-results/public/.htaccess (188229 => 188230) --- trunk/Websites/test-results/public/.htaccess 2015-08-10 20:56:18 UTC (rev 188229) +++ trunk/Websites/test-results/public/.htaccess 2015-08-10 21:35:54 UTC (rev 188230) @@ -5,4 +5,5 @@ php_value post_max_size 11000 php_value memory_limit 12000 php_value max_input_time 60 +php_value max_execution_time 240 Modified: trunk/Websites/test-results/public/include/json-shared.php (188229 => 188230) --- trunk/Websites/test-results/public/include/json-shared.php 2015-08-10 20:56:18 UTC (rev 188229) +++ trunk/Websites/test-results/public/include/json-shared.php 2015-08-10 21:35:54 UTC (rev 188230) @@ -1,4 +1,5 @@ +ini_set('memory_limit','1024M'); require_once('db.php'); Modified: trunk/Websites/test-results/public/include/test-results.php (188229 => 188230) --- trunk/Websites/test-results/public/include/test-results.php 2015-08-10 20:56:18 UTC (rev 188229) +++ trunk/Websites/test-results/public/include/test-results.php 2015-08-10 21:35:54 UTC (rev 188230) @@ -1,4 +1,5 @@ +ini_set('memory_limit', '1024M'); require_once('db.php'); @@ -67,7 +68,7 @@ require_format('test_time', $tests['time'], '/^\d*$/'); $modifiers = array_get($tests, 'modifiers'); if ($modifiers) -require_format('test_modifiers', $modifiers, '/^[A-Za-z0-9 \.\/]+$/'); +require_format('test_modifiers', $modifiers, '/^[A-Za-z0-9 \.\/\+]+$/'); else $modifiers = NULL; $category = 'LayoutTest'; // FIXME: Support other test categories. ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [188231] trunk/Source/JavaScriptCore
Title: [188231] trunk/Source/_javascript_Core Revision 188231 Author mark@apple.com Date 2015-08-10 14:54:36 -0700 (Mon, 10 Aug 2015) Log Message Refactor LiveObjectList and LiveObjectData into their own files. https://bugs.webkit.org/show_bug.cgi?id=147843 Reviewed by Saam Barati. There is no behavior change in this patch. * CMakeLists.txt: * _javascript_Core.vcxproj/_javascript_Core.vcxproj: * _javascript_Core.vcxproj/_javascript_Core.vcxproj.filters: * _javascript_Core.xcodeproj/project.pbxproj: * heap/HeapVerifier.cpp: (JSC::HeapVerifier::HeapVerifier): (JSC::LiveObjectList::findObject): Deleted. * heap/HeapVerifier.h: (JSC::LiveObjectData::LiveObjectData): Deleted. (JSC::LiveObjectList::LiveObjectList): Deleted. (JSC::LiveObjectList::reset): Deleted. * heap/LiveObjectData.h: Added. (JSC::LiveObjectData::LiveObjectData): * heap/LiveObjectList.cpp: Added. (JSC::LiveObjectList::findObject): * heap/LiveObjectList.h: Added. (JSC::LiveObjectList::LiveObjectList): (JSC::LiveObjectList::reset): Modified Paths trunk/Source/_javascript_Core/CMakeLists.txt trunk/Source/_javascript_Core/ChangeLog trunk/Source/_javascript_Core/_javascript_Core.vcxproj/_javascript_Core.vcxproj trunk/Source/_javascript_Core/_javascript_Core.vcxproj/_javascript_Core.vcxproj.filters trunk/Source/_javascript_Core/_javascript_Core.xcodeproj/project.pbxproj trunk/Source/_javascript_Core/heap/HeapVerifier.cpp trunk/Source/_javascript_Core/heap/HeapVerifier.h Added Paths trunk/Source/_javascript_Core/heap/LiveObjectData.h trunk/Source/_javascript_Core/heap/LiveObjectList.cpp trunk/Source/_javascript_Core/heap/LiveObjectList.h Diff Modified: trunk/Source/_javascript_Core/CMakeLists.txt (188230 => 188231) --- trunk/Source/_javascript_Core/CMakeLists.txt 2015-08-10 21:35:54 UTC (rev 188230) +++ trunk/Source/_javascript_Core/CMakeLists.txt 2015-08-10 21:54:36 UTC (rev 188231) @@ -291,6 +291,7 @@ heap/HeapVerifier.cpp heap/IncrementalSweeper.cpp heap/JITStubRoutineSet.cpp +heap/LiveObjectList.cpp heap/MachineStackMarker.cpp heap/MarkStack.cpp heap/MarkedAllocator.cpp Modified: trunk/Source/_javascript_Core/ChangeLog (188230 => 188231) --- trunk/Source/_javascript_Core/ChangeLog 2015-08-10 21:35:54 UTC (rev 188230) +++ trunk/Source/_javascript_Core/ChangeLog 2015-08-10 21:54:36 UTC (rev 188231) @@ -1,3 +1,31 @@ +2015-08-10 Mark Lam + +Refactor LiveObjectList and LiveObjectData into their own files. +https://bugs.webkit.org/show_bug.cgi?id=147843 + +Reviewed by Saam Barati. + +There is no behavior change in this patch. + +* CMakeLists.txt: +* _javascript_Core.vcxproj/_javascript_Core.vcxproj: +* _javascript_Core.vcxproj/_javascript_Core.vcxproj.filters: +* _javascript_Core.xcodeproj/project.pbxproj: +* heap/HeapVerifier.cpp: +(JSC::HeapVerifier::HeapVerifier): +(JSC::LiveObjectList::findObject): Deleted. +* heap/HeapVerifier.h: +(JSC::LiveObjectData::LiveObjectData): Deleted. +(JSC::LiveObjectList::LiveObjectList): Deleted. +(JSC::LiveObjectList::reset): Deleted. +* heap/LiveObjectData.h: Added. +(JSC::LiveObjectData::LiveObjectData): +* heap/LiveObjectList.cpp: Added. +(JSC::LiveObjectList::findObject): +* heap/LiveObjectList.h: Added. +(JSC::LiveObjectList::LiveObjectList): +(JSC::LiveObjectList::reset): + 2015-08-07 Geoffrey Garen Let's rename FunctionBodyNode Modified: trunk/Source/_javascript_Core/_javascript_Core.vcxproj/_javascript_Core.vcxproj (188230 => 188231) --- trunk/Source/_javascript_Core/_javascript_Core.vcxproj/_javascript_Core.vcxproj 2015-08-10 21:35:54 UTC (rev 188230) +++ trunk/Source/_javascript_Core/_javascript_Core.vcxproj/_javascript_Core.vcxproj 2015-08-10 21:54:36 UTC (rev 188231) @@ -565,6 +565,7 @@ + @@ -1321,6 +1322,8 @@ + + Modified: trunk/Source/_javascript_Core/_javascript_Core.vcxproj/_javascript_Core.vcxproj.filters (188230 => 188231) --- trunk/Source/_javascript_Core/_javascript_Core.vcxproj/_javascript_Core.vcxproj.filters 2015-08-10 21:35:54 UTC (rev 188230) +++ trunk/Source/_javascript_Core/_javascript_Core.vcxproj/_javascript_Core.vcxproj.filters 2015-08-10 21:54:36 UTC (rev 188231) @@ -294,6 +294,9 @@ heap + + heap + heap @@ -2237,6 +2240,12 @@ heap + + heap + + + heap + heap Modified: trunk/Source/_javascript_Core/_javascript_Core.xcodeproj/project.pbxproj (188230 => 188231) --- trunk/Source/_javascript_Core/_javascript_Core.xcodeproj/project.pbxproj 2015-08-10 21:35:54 UTC (rev 188230) +++ trunk/Source/_javascript_Core/_javascript_Core.xcodeproj/project.pbxproj 2015-08-10 21:54:36 UTC (rev 188231) @@ -1705,6 +1705,9 @@ FE384EE61ADDB7AD0055DE2C
[webkit-changes] [188232] trunk/Source/WebKit2
Title: [188232] trunk/Source/WebKit2 Revision 188232 Author wei...@apple.com Date 2015-08-10 15:09:22 -0700 (Mon, 10 Aug 2015) Log Message Try to fix the 32-bit build. * UIProcess/API/mac/WKViewInternal.h: Modified Paths trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/UIProcess/API/mac/WKViewInternal.h Diff Modified: trunk/Source/WebKit2/ChangeLog (188231 => 188232) --- trunk/Source/WebKit2/ChangeLog 2015-08-10 21:54:36 UTC (rev 188231) +++ trunk/Source/WebKit2/ChangeLog 2015-08-10 22:09:22 UTC (rev 188232) @@ -1,3 +1,9 @@ +2015-08-10 Sam Weinig + +Try to fix the 32-bit build. + +* UIProcess/API/mac/WKViewInternal.h: + 2015-08-08 Sam Weinig Replace WebPageConfiguration with API::PageConfiguration and expose a C-SPI accessor for it Modified: trunk/Source/WebKit2/UIProcess/API/mac/WKViewInternal.h (188231 => 188232) --- trunk/Source/WebKit2/UIProcess/API/mac/WKViewInternal.h 2015-08-10 21:54:36 UTC (rev 188231) +++ trunk/Source/WebKit2/UIProcess/API/mac/WKViewInternal.h 2015-08-10 22:09:22 UTC (rev 188232) @@ -68,7 +68,9 @@ #endif @interface WKView () -- (instancetype)initWithFrame:(CGRect)frame processPool:(WebKit::WebProcessPool&)processPool configuration:(Ref&&)configuration webView:(WKWebView *)webView; +#if WK_API_ENABLED +- (instancetype)initWithFrame:(NSRect)frame processPool:(WebKit::WebProcessPool&)processPool configuration:(Ref&&)configuration webView:(WKWebView *)webView; +#endif - (std::unique_ptr)_createDrawingAreaProxy; - (BOOL)_isFocused; ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [188233] trunk/Source/WebCore
Title: [188233] trunk/Source/WebCore Revision 188233 Author cdu...@apple.com Date 2015-08-10 15:58:16 -0700 (Mon, 10 Aug 2015) Log Message Simplify code for making Page-cacheability decision https://bugs.webkit.org/show_bug.cgi?id=147829 Reviewed by Antti Koivisto. Simplify code for making Page-cacheability decision by merging logging code and decision making code. Having the same checks in two places was redundant and error-prone as we needed to keep them in sync. Also get rid of failure reason enum values as those have not been used in a while. * history/PageCache.cpp: (WebCore::canCacheFrame): (WebCore::canCachePage): (WebCore::PageCache::canCache): (WebCore::logPageCacheFailureDiagnosticMessage): Deleted. (WebCore::PageCache::singleton): Deleted. (WebCore::PageCache::setMaxSize): Deleted. (WebCore::PageCache::frameCount): Deleted. (WebCore::PageCache::markPagesForVisitedLinkStyleRecalc): Deleted. (WebCore::PageCache::markPagesForFullStyleRecalc): Deleted. (WebCore::PageCache::markPagesForDeviceOrPageScaleChanged): Deleted. (WebCore::PageCache::markPagesForContentsSizeChanged): Deleted. (WebCore::PageCache::markPagesForCaptionPreferencesChanged): Deleted. (WebCore::pruningReasonToDiagnosticLoggingKey): Deleted. * page/DiagnosticLoggingKeys.cpp: (WebCore::DiagnosticLoggingKeys::isDisabledKey): (WebCore::DiagnosticLoggingKeys::redirectKey): (WebCore::DiagnosticLoggingKeys::replaceKey): (WebCore::DiagnosticLoggingKeys::sourceKey): (WebCore::DiagnosticLoggingKeys::underMemoryPressureKey): (WebCore::DiagnosticLoggingKeys::reloadFromOriginKey): Deleted. * page/DiagnosticLoggingKeys.h: Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/history/PageCache.cpp trunk/Source/WebCore/page/DiagnosticLoggingKeys.cpp trunk/Source/WebCore/page/DiagnosticLoggingKeys.h Diff Modified: trunk/Source/WebCore/ChangeLog (188232 => 188233) --- trunk/Source/WebCore/ChangeLog 2015-08-10 22:09:22 UTC (rev 188232) +++ trunk/Source/WebCore/ChangeLog 2015-08-10 22:58:16 UTC (rev 188233) @@ -1,3 +1,40 @@ +2015-08-10 Chris Dumez + +Simplify code for making Page-cacheability decision +https://bugs.webkit.org/show_bug.cgi?id=147829 + +Reviewed by Antti Koivisto. + +Simplify code for making Page-cacheability decision by merging logging +code and decision making code. Having the same checks in two places was +redundant and error-prone as we needed to keep them in sync. + +Also get rid of failure reason enum values as those have not been used +in a while. + +* history/PageCache.cpp: +(WebCore::canCacheFrame): +(WebCore::canCachePage): +(WebCore::PageCache::canCache): +(WebCore::logPageCacheFailureDiagnosticMessage): Deleted. +(WebCore::PageCache::singleton): Deleted. +(WebCore::PageCache::setMaxSize): Deleted. +(WebCore::PageCache::frameCount): Deleted. +(WebCore::PageCache::markPagesForVisitedLinkStyleRecalc): Deleted. +(WebCore::PageCache::markPagesForFullStyleRecalc): Deleted. +(WebCore::PageCache::markPagesForDeviceOrPageScaleChanged): Deleted. +(WebCore::PageCache::markPagesForContentsSizeChanged): Deleted. +(WebCore::PageCache::markPagesForCaptionPreferencesChanged): Deleted. +(WebCore::pruningReasonToDiagnosticLoggingKey): Deleted. +* page/DiagnosticLoggingKeys.cpp: +(WebCore::DiagnosticLoggingKeys::isDisabledKey): +(WebCore::DiagnosticLoggingKeys::redirectKey): +(WebCore::DiagnosticLoggingKeys::replaceKey): +(WebCore::DiagnosticLoggingKeys::sourceKey): +(WebCore::DiagnosticLoggingKeys::underMemoryPressureKey): +(WebCore::DiagnosticLoggingKeys::reloadFromOriginKey): Deleted. +* page/DiagnosticLoggingKeys.h: + 2015-08-10 Devin Rousso Web Inspector: [iOS] Allow inspector to retrieve a list of system fonts Modified: trunk/Source/WebCore/history/PageCache.cpp (188232 => 188233) --- trunk/Source/WebCore/history/PageCache.cpp 2015-08-10 22:09:22 UTC (rev 188232) +++ trunk/Source/WebCore/history/PageCache.cpp 2015-08-10 22:58:16 UTC (rev 188233) @@ -39,7 +39,6 @@ #include "DocumentLoader.h" #include "FrameLoader.h" #include "FrameLoaderClient.h" -#include "FrameLoaderStateMachine.h" #include "FrameView.h" #include "HistoryController.h" #include "Logging.h" @@ -58,44 +57,10 @@ #include "DeviceProximityController.h" #endif -#if PLATFORM(IOS) -#include "MemoryPressureHandler.h" -#endif - namespace WebCore { -#if !defined(NDEBUG) - #define PCLOG(...) LOG(PageCache, "%*s%s", indentLevel*4, "", makeString(__VA_ARGS__).utf8().data()) -#else - -#define PCLOG(...) ((void)0) - -#endif // !defined(NDEBUG) - -// Used in histograms, please only add at the end, and do not remove elements (renaming e.g. to "FooEnumUnused1" is fine). -// This is because statistics may be gathered from histograms between versions over time, and re-using values c
[webkit-changes] [188234] trunk/Source/WebCore
Title: [188234] trunk/Source/WebCore Revision 188234 Author mdai...@apple.com Date 2015-08-10 16:27:55 -0700 (Mon, 10 Aug 2015) Log Message HTMLMediaElement needs way to find MediaDeviceInfo https://bugs.webkit.org/show_bug.cgi?id=147842 Reviewed by Jer Noble. * html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::mediaPlayerMediaDeviceIdentifierStorageDirectory): * html/HTMLMediaElement.h: * page/Settings.h: (WebCore::Settings::setMediaDeviceIdentifierStorageDirectory): (WebCore::Settings::mediaDeviceIdentifierStorageDirectory): * platform/graphics/MediaPlayer.h: (WebCore::MediaPlayerClient::mediaPlayerMediaDeviceIdentifierStorageDirectory): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/html/HTMLMediaElement.cpp trunk/Source/WebCore/html/HTMLMediaElement.h trunk/Source/WebCore/page/Settings.h trunk/Source/WebCore/platform/graphics/MediaPlayer.h Diff Modified: trunk/Source/WebCore/ChangeLog (188233 => 188234) --- trunk/Source/WebCore/ChangeLog 2015-08-10 22:58:16 UTC (rev 188233) +++ trunk/Source/WebCore/ChangeLog 2015-08-10 23:27:55 UTC (rev 188234) @@ -1,3 +1,19 @@ +2015-08-10 Matthew Daiter + +HTMLMediaElement needs way to find MediaDeviceInfo +https://bugs.webkit.org/show_bug.cgi?id=147842 + +Reviewed by Jer Noble. + +* html/HTMLMediaElement.cpp: +(WebCore::HTMLMediaElement::mediaPlayerMediaDeviceIdentifierStorageDirectory): +* html/HTMLMediaElement.h: +* page/Settings.h: +(WebCore::Settings::setMediaDeviceIdentifierStorageDirectory): +(WebCore::Settings::mediaDeviceIdentifierStorageDirectory): +* platform/graphics/MediaPlayer.h: +(WebCore::MediaPlayerClient::mediaPlayerMediaDeviceIdentifierStorageDirectory): + 2015-08-10 Chris Dumez Simplify code for making Page-cacheability decision Modified: trunk/Source/WebCore/html/HTMLMediaElement.cpp (188233 => 188234) --- trunk/Source/WebCore/html/HTMLMediaElement.cpp 2015-08-10 22:58:16 UTC (rev 188233) +++ trunk/Source/WebCore/html/HTMLMediaElement.cpp 2015-08-10 23:27:55 UTC (rev 188234) @@ -2358,6 +2358,25 @@ } #endif +#if ENABLE(MEDIA_STREAM) +String HTMLMediaElement::mediaPlayerMediaDeviceIdentifierStorageDirectory() const +{ +Settings* settings = document().settings(); +if (!settings) +return emptyString(); + +String storageDirectory = settings->mediaDeviceIdentifierStorageDirectory(); +if (storageDirectory.isEmpty()) +return emptyString(); + +SecurityOrigin* origin = document().securityOrigin(); +if (!origin) +return emptyString(); + +return pathByAppendingComponent(storageDirectory, origin->databaseIdentifier()); +} +#endif + void HTMLMediaElement::progressEventTimerFired() { ASSERT(m_player); Modified: trunk/Source/WebCore/html/HTMLMediaElement.h (188233 => 188234) --- trunk/Source/WebCore/html/HTMLMediaElement.h 2015-08-10 22:58:16 UTC (rev 188233) +++ trunk/Source/WebCore/html/HTMLMediaElement.h 2015-08-10 23:27:55 UTC (rev 188234) @@ -559,6 +559,10 @@ virtual bool mediaPlayerKeyNeeded(MediaPlayer*, Uint8Array*) override; virtual String mediaPlayerMediaKeysStorageDirectory() const override; #endif + +#if ENABLE(MEDIA_STREAM) +virtual String mediaPlayerMediaDeviceIdentifierStorageDirectory() const override; +#endif #if ENABLE(WIRELESS_PLAYBACK_TARGET) virtual void mediaPlayerCurrentPlaybackTargetIsWirelessChanged(MediaPlayer*) override; Modified: trunk/Source/WebCore/page/Settings.h (188233 => 188234) --- trunk/Source/WebCore/page/Settings.h 2015-08-10 22:58:16 UTC (rev 188233) +++ trunk/Source/WebCore/page/Settings.h 2015-08-10 23:27:55 UTC (rev 188234) @@ -269,6 +269,11 @@ void setMediaKeysStorageDirectory(const String& directory) { m_mediaKeysStorageDirectory = directory; } const String& mediaKeysStorageDirectory() const { return m_mediaKeysStorageDirectory; } #endif + +#if ENABLE(MEDIA_STREAM) +void setMediaDeviceIdentifierStorageDirectory(const String& directory) { m_mediaDeviceIdentifierStorageDirectory = directory; } +const String& mediaDeviceIdentifierStorageDirectory() const { return m_mediaDeviceIdentifierStorageDirectory; } +#endif WEBCORE_EXPORT void setForcePendingWebGLPolicy(bool); bool isForcePendingWebGLPolicy() const { return m_forcePendingWebGLPolicy; } @@ -353,6 +358,10 @@ #if ENABLE(ENCRYPTED_MEDIA_V2) String m_mediaKeysStorageDirectory; #endif + +#if ENABLE(MEDIA_STREAM) +String m_mediaDeviceIdentifierStorageDirectory; +#endif static bool gLowPowerVideoAudioBufferSizeEnabled; }; Modified: trunk/Source/WebCore/platform/graphics/MediaPlayer.h (188233 => 188234) --- trunk/Source/WebCore/platform/graphics/MediaPlayer.h 2015-08-10 22:58:16 UTC (rev 188233) +++ trunk/Source/WebCore/platform/graphics/MediaPlayer.h 2015-08-10 23:27:55 UTC (rev 188234) @@ -229,6 +229,11 @@ virtual String mediaPlayerMediaKeysStorageDirectory() cons
[webkit-changes] [188235] branches/safari-601.1.46-branch/Source/WebKit2
Title: [188235] branches/safari-601.1.46-branch/Source/WebKit2 Revision 188235 Author bshaf...@apple.com Date 2015-08-10 16:33:19 -0700 (Mon, 10 Aug 2015) Log Message Merged r188223. rdar://problem/21465328 Modified Paths branches/safari-601.1.46-branch/Source/WebKit2/ChangeLog branches/safari-601.1.46-branch/Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm Diff Modified: branches/safari-601.1.46-branch/Source/WebKit2/ChangeLog (188234 => 188235) --- branches/safari-601.1.46-branch/Source/WebKit2/ChangeLog 2015-08-10 23:27:55 UTC (rev 188234) +++ branches/safari-601.1.46-branch/Source/WebKit2/ChangeLog 2015-08-10 23:33:19 UTC (rev 188235) @@ -1,3 +1,26 @@ +2015-08-10 Babak Shafiei + +Merge r188223. + +2015-08-10 Commit Queue + +Unreviewed, rolling out r187131 and r187286. +https://bugs.webkit.org/show_bug.cgi?id=147839 + + Causing mroe frequent crashes with invalid layer bounds +(rdar://problem/21465328) (Requested by smfr on #webkit). + +Reverted changesets: + +"[iOS] Menu drop down such as on nike.com does not stay" +https://bugs.webkit.org/show_bug.cgi?id=147047 +http://trac.webkit.org/changeset/187131 + +"[iOS] REGRESSION (187131): Loading CuteOverload zooms in to +the top left corner." +https://bugs.webkit.org/show_bug.cgi?id=147251 +http://trac.webkit.org/changeset/187286 + 2015-08-09 Babak Shafiei Merge r188162. Modified: branches/safari-601.1.46-branch/Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm (188234 => 188235) --- branches/safari-601.1.46-branch/Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm 2015-08-10 23:27:55 UTC (rev 188234) +++ branches/safari-601.1.46-branch/Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm 2015-08-10 23:33:19 UTC (rev 188235) @@ -987,24 +987,9 @@ [_scrollView setMinimumZoomScale:layerTreeTransaction.minimumScaleFactor()]; [_scrollView setMaximumZoomScale:layerTreeTransaction.maximumScaleFactor()]; [_scrollView setZoomEnabled:layerTreeTransaction.allowsUserScaling()]; -if (!layerTreeTransaction.scaleWasSetByUIProcess() && ![_scrollView isZooming] && ![_scrollView isZoomBouncing] && ![_scrollView _isAnimatingZoom]) { -float newPageScaleFactor = layerTreeTransaction.pageScaleFactor(); +if (!layerTreeTransaction.scaleWasSetByUIProcess() && ![_scrollView isZooming] && ![_scrollView isZoomBouncing] && ![_scrollView _isAnimatingZoom]) +[_scrollView setZoomScale:layerTreeTransaction.pageScaleFactor()]; -if (!areEssentiallyEqualAsFloat(contentZoomScale(self), newPageScaleFactor)) { -// FIXME: We need to handle stick to bottom. -WebCore::FloatRect oldUnobscuredContentRect = _page->unobscuredContentRect(); -if (!oldUnobscuredContentRect.isEmpty() && oldUnobscuredContentRect.y() < 1) { -CGFloat relativeHorizontalPosition = oldUnobscuredContentRect.x() / oldUnobscuredContentRect.width(); -CGPoint newTopLeft = { relativeHorizontalPosition * newContentSize.width, 0 }; -CGSize scrollViewSize = [_scrollView bounds].size; -CGSize rectToZoomSize = CGSizeMake(scrollViewSize.width / newPageScaleFactor, scrollViewSize.height / newPageScaleFactor); -[_scrollView zoomToRect: { newTopLeft, rectToZoomSize } animated:NO]; -ASSERT(areEssentiallyEqualAsFloat(newPageScaleFactor, contentZoomScale(self))); -} else -[_scrollView setZoomScale:newPageScaleFactor]; -} -} - [self _updateScrollViewBackground]; if (_gestureController) ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [188236] trunk/Source/WebKit2
Title: [188236] trunk/Source/WebKit2 Revision 188236 Author mdai...@apple.com Date 2015-08-10 16:40:40 -0700 (Mon, 10 Aug 2015) Log Message Add MediaDeviceIdentifier to WebsiteDataTypes https://bugs.webkit.org/show_bug.cgi?id=147853 Reviewed by Jer Noble. * Shared/WebsiteData/WebsiteDataTypes.h: Modified Paths trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/Shared/WebsiteData/WebsiteDataTypes.h Diff Modified: trunk/Source/WebKit2/ChangeLog (188235 => 188236) --- trunk/Source/WebKit2/ChangeLog 2015-08-10 23:33:19 UTC (rev 188235) +++ trunk/Source/WebKit2/ChangeLog 2015-08-10 23:40:40 UTC (rev 188236) @@ -1,3 +1,12 @@ +2015-08-10 Matthew Daiter + +Add MediaDeviceIdentifier to WebsiteDataTypes +https://bugs.webkit.org/show_bug.cgi?id=147853 + +Reviewed by Jer Noble. + +* Shared/WebsiteData/WebsiteDataTypes.h: + 2015-08-10 Sam Weinig Try to fix the 32-bit build. Modified: trunk/Source/WebKit2/Shared/WebsiteData/WebsiteDataTypes.h (188235 => 188236) --- trunk/Source/WebKit2/Shared/WebsiteData/WebsiteDataTypes.h 2015-08-10 23:33:19 UTC (rev 188235) +++ trunk/Source/WebKit2/Shared/WebsiteData/WebsiteDataTypes.h 2015-08-10 23:40:40 UTC (rev 188236) @@ -42,6 +42,9 @@ #if ENABLE(NETSCAPE_PLUGIN_API) WebsiteDataTypePlugInData = 1 << 10, #endif +#if ENABLE(MEDIA_STREAM) +WebsiteDataTypeMediaDeviceIdentifier = 1 << 11, +#endif }; }; ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [188237] trunk/Tools
Title: [188237] trunk/Tools Revision 188237 Author commit-qu...@webkit.org Date 2015-08-10 16:44:10 -0700 (Mon, 10 Aug 2015) Log Message Make cleanup more robust and minor code cleaning in run benchmark script. https://bugs.webkit.org/show_bug.cgi?id=147800 Patch by Dewei Zhu on 2015-08-10 Reviewed by Ryosuke Niwa. Use 'finnaly' block to make sure cleanup code is always executed. * Scripts/webkitpy/benchmark_runner/benchmark_runner.py: (built_benchmark): (built_benchmark.__init__): (built_benchmark.__enter__): (built_benchmark.__exit__): (test_environment): (test_environment.__init__): (test_environment.__enter__): (test_environment.__exit__): (BenchmarkRunner.__init__): (BenchmarkRunner.execute): (BenchmarkRunner._dump): (BenchmarkRunner._wrap): (BenchmarkRunner): Deleted. (BenchmarkRunner._cleanup): Deleted. * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py: (BrowserDriver.close_browsers): (BrowserDriver): (BrowserDriver.restore_env): * Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py: (SimpleHTTPServerDriver.__init__): We do not actually need to know external ip address for now. Modified Paths trunk/Tools/ChangeLog trunk/Tools/Scripts/webkitpy/benchmark_runner/benchmark_builder.py trunk/Tools/Scripts/webkitpy/benchmark_runner/benchmark_runner.py trunk/Tools/Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py trunk/Tools/Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py Diff Modified: trunk/Tools/ChangeLog (188236 => 188237) --- trunk/Tools/ChangeLog 2015-08-10 23:40:40 UTC (rev 188236) +++ trunk/Tools/ChangeLog 2015-08-10 23:44:10 UTC (rev 188237) @@ -1,3 +1,34 @@ +2015-08-10 Dewei Zhu + +Make cleanup more robust and minor code cleaning in run benchmark script. +https://bugs.webkit.org/show_bug.cgi?id=147800 + +Reviewed by Ryosuke Niwa. + +Use 'finnaly' block to make sure cleanup code is always executed. + +* Scripts/webkitpy/benchmark_runner/benchmark_runner.py: +(built_benchmark): +(built_benchmark.__init__): +(built_benchmark.__enter__): +(built_benchmark.__exit__): +(test_environment): +(test_environment.__init__): +(test_environment.__enter__): +(test_environment.__exit__): +(BenchmarkRunner.__init__): +(BenchmarkRunner.execute): +(BenchmarkRunner._dump): +(BenchmarkRunner._wrap): +(BenchmarkRunner): Deleted. +(BenchmarkRunner._cleanup): Deleted. +* Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py: +(BrowserDriver.close_browsers): +(BrowserDriver): +(BrowserDriver.restore_env): +* Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py: +(SimpleHTTPServerDriver.__init__): We do not actually need to know external ip address for now. + 2015-08-10 Youenn Fablet Compile warning (-Wsign-compare) on 32-bits at WebCore/platform/FileSystem.cpp Modified: trunk/Tools/Scripts/webkitpy/benchmark_runner/benchmark_builder.py (188236 => 188237) --- trunk/Tools/Scripts/webkitpy/benchmark_runner/benchmark_builder.py 2015-08-10 23:40:40 UTC (rev 188236) +++ trunk/Tools/Scripts/webkitpy/benchmark_runner/benchmark_builder.py 2015-08-10 23:44:10 UTC (rev 188237) @@ -16,30 +16,36 @@ class BenchmarkBuilder(object): -def prepare(self, name, plan): +def __init__(self, name, plan): self._name = name +self._plan = plan + +def __enter__(self): self._web_root = tempfile.mkdtemp() self._dest = os.path.join(self._web_root, self._name) -if 'local_copy' in plan: -self._copy_benchmark_to_temp_dir(plan['local_copy']) -elif 'remote_archive' in plan: -self._fetch_remote_archive(plan['remote_archive']) -elif 'svn_source' in plan: -self._checkout_with_subversion(plan['svn_source']) +if 'local_copy' in self._plan: +self._copy_benchmark_to_temp_dir(self._plan['local_copy']) +elif 'remote_archive' in self._plan: +self._fetch_remote_archive(self._plan['remote_archive']) +elif 'svn_source' in self._plan: +self._checkout_with_subversion(self._plan['svn_source']) else: raise Exception('The benchmark location was not specified') _log.info('Copied the benchmark into: %s' % self._dest) try: -if 'create_script' in plan: +if 'create_script' in self._plan: self._run_create_script(plan['create_script']) -if 'benchmark_patch' in plan: -self._apply_patch(plan['benchmark_patch']) +if 'benchmark_patch' in self._plan: +self._apply_patch(self._plan['benchmark_patch']) return self._web_root except Exception: -self.clean() +self.
[webkit-changes] [188238] trunk/Source/WebInspectorUI
Title: [188238] trunk/Source/WebInspectorUI Revision 188238 Author drou...@apple.com Date 2015-08-10 16:56:51 -0700 (Mon, 10 Aug 2015) Log Message Web Inspector: Add numerical input and slider based Visual editors for CSS properties https://bugs.webkit.org/show_bug.cgi?id=147712 Reviewed by Brian Burg. Added editors for CSS properties with numerical values for use in the Visual style details panel in the CSS sidebar, in the form of a combined select and input or an input range. Also added optional visual linkages to sync values between multiple editors of this type. * UserInterface/Images/VisualStylePropertyLinked.svg: Added. * UserInterface/Images/VisualStylePropertyUnlinked.svg: Added. * UserInterface/Views/VisualStyleNumberInputBox.css: Added. (.visual-style-property-container > .visual-style-property-value-container.focused > .focus-ring): (.visual-style-property-container > .visual-style-property-value-container > .number-input-keyword-select): (.visual-style-property-container > .visual-style-property-value-container > .number-input-container): (.visual-style-property-container > .visual-style-property-value-container:not(.number-input-editable) > .number-input-container): (.visual-style-property-container > .visual-style-property-value-container > .number-input-container > .number-input-value): (.visual-style-property-container > .visual-style-property-value-container > .number-input-container > span): * UserInterface/Views/VisualStyleNumberInputBox.js: Added. (WebInspector.VisualStyleNumberInputBox): (WebInspector.VisualStyleNumberInputBox.prototype.get value): (WebInspector.VisualStyleNumberInputBox.prototype.set value): (WebInspector.VisualStyleNumberInputBox.prototype.get units): (WebInspector.VisualStyleNumberInputBox.prototype.set units): (WebInspector.VisualStyleNumberInputBox.prototype.get placeholder): (WebInspector.VisualStyleNumberInputBox.prototype.set placeholder): (WebInspector.VisualStyleNumberInputBox.prototype.get synthesizedValue): (WebInspector.VisualStyleNumberInputBox.prototype.get numberInputEditable): (WebInspector.VisualStyleNumberInputBox.prototype.updateValueFromText): (WebInspector.VisualStyleNumberInputBox.prototype.parseValue): (WebInspector.VisualStyleNumberInputBox.prototype._keywordChanged): (WebInspector.VisualStyleNumberInputBox.prototype._valueNumberInputKeyDown.shiftValue): (WebInspector.VisualStyleNumberInputBox.prototype._valueNumberInputKeyDown): (WebInspector.VisualStyleNumberInputBox.prototype._numberInputChanged): (WebInspector.VisualStyleNumberInputBox.prototype._keywordSelectMouseDown): (WebInspector.VisualStyleNumberInputBox.prototype._createValueOptions): (WebInspector.VisualStyleNumberInputBox.prototype._createUnitOptions): (WebInspector.VisualStyleNumberInputBox.prototype._addAdvancedUnits): (WebInspector.VisualStyleNumberInputBox.prototype._removeAdvancedUnits): (WebInspector.VisualStyleNumberInputBox.prototype._focusContentElement): (WebInspector.VisualStyleNumberInputBox.prototype._blurContentElement): (WebInspector.VisualStyleNumberInputBox.prototype._toggleTabbingOfSelectableElements): * UserInterface/Views/VisualStylePropertyEditorLink.css: Added. (.visual-style-property-editor-link): (.visual-style-property-editor-link.disabled): (.visual-style-property-editor-link.link-all): (.visual-style-property-editor-link.link-all.linked): (.visual-style-property-editor-link > .visual-style-property-editor-link-border): (.visual-style-property-editor-link.link-all.linked > .visual-style-property-editor-link-icon:hover + .visual-style-property-editor-link-border.right): (.visual-style-property-editor-link.link-all.linked > .visual-style-property-editor-link-border.left): (.visual-style-property-editor-link.link-all.linked > .visual-style-property-editor-link-border.right): (.visual-style-property-editor-link.linked > .visual-style-property-editor-link-border): (.visual-style-property-editor-link > .visual-style-property-editor-link-border.left): (.visual-style-property-editor-link > .visual-style-property-editor-link-border.right): (.visual-style-property-editor-link:not(.link-all) > .visual-style-property-editor-link-border): (.visual-style-property-editor-link:not(.link-all).linked > .visual-style-property-editor-link-border): (.visual-style-property-editor-link > .visual-style-property-editor-link-icon): (.visual-style-property-editor-link > .visual-style-property-editor-link-icon > .unlinked-icon): (.visual-style-property-editor-link > .visual-style-property-editor-link-icon > .unlinked-icon svg .filled): (.visual-style-property-editor-link > .visual-style-property-editor-link-icon > .unlinked-icon svg .stroked): (.visual-style-property-editor-link:not(.link-all) > .visual-style-property-editor-link-icon): (.visual-style-property-editor-link.link-all > .visual-style-property-editor-link-icon): * UserInterface/Views/VisualStylePropertyEditorLink.js: Added. (WebInspector.VisualStylePropertyEditorLink): (WebInspector.VisualStylePropertyEd
[webkit-changes] [188239] trunk
Title: [188239] trunk Revision 188239 Author achristen...@apple.com Date 2015-08-10 17:09:07 -0700 (Mon, 10 Aug 2015) Log Message Build TestWebKitAPI with CMake on Windows https://bugs.webkit.org/show_bug.cgi?id=147851 Reviewed by Chris Dumez. .: * Source/cmake/OptionsWindows.cmake: Enable api tests and set USE_SYSTEM_MALLOC to avoid warnings when redefining it. Source/ThirdParty: * gtest/CMakeLists.txt: Include DerivedSources to find WTF/WTFHeaderDetection.h. Source/WebCore: * PlatformWin.cmake: Remove RenderThemeWin.cpp which is included in RenderingAllInOne.cpp. * WebCorePrefix.h: Include cmakeconfig.h before wtf/Platform.h like we do in _javascript_Core's config.h to avoid warnings and redefining ENABLE_* macros. Source/WebKit: * PlatformWin.cmake: WinCairo libraries conflict with LIBCMT.lib, AppleWin libraries conflict with MSVCRT.lib, so different /NODEFAULTLIB is needed to link WebKit.dll successfully. Tools: * CMakeLists.txt: * TestWebKitAPI/CMakeLists.txt: Removed TestJavaScriptCore because _javascript_Core's API tests are elsewhere and this was just making an empty binary. Surrounded WebKit2-specific features with ENABLE_WEBKIT2 checks. Include directories after the Platform*.cmake is included because HostWindow.h needs to be found in Tools/TestWebKitAPI/win before we look in Source/WebCore/platform, where another file named HostWindow.h exists. * TestWebKitAPI/PlatformEfl.cmake: * TestWebKitAPI/PlatformGTK.cmake: Windows needs all the binaries to be in the same directory to find gtest.dll and the other dlls. I did this without changing the directory structure of the existing EFL and GTK builds. * TestWebKitAPI/PlatformWin.cmake: Added. * TestWebKitAPI/win/main.cpp: (main): (dllLauncherEntryPoint): Added so we can launch TestWebKitAPI executables after finding the AAS directory. * WinLauncher/CMakeLists.txt: AppleWin port needs /NODEFAULTLIB:MSVCRT. Modified Paths trunk/ChangeLog trunk/Source/ThirdParty/ChangeLog trunk/Source/ThirdParty/gtest/CMakeLists.txt trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/PlatformWin.cmake trunk/Source/WebCore/WebCorePrefix.h trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/PlatformWin.cmake trunk/Source/cmake/OptionsWindows.cmake trunk/Tools/CMakeLists.txt trunk/Tools/ChangeLog trunk/Tools/TestWebKitAPI/CMakeLists.txt trunk/Tools/TestWebKitAPI/PlatformEfl.cmake trunk/Tools/TestWebKitAPI/PlatformGTK.cmake trunk/Tools/TestWebKitAPI/win/main.cpp trunk/Tools/WinLauncher/CMakeLists.txt Added Paths trunk/Tools/TestWebKitAPI/PlatformWin.cmake Diff Modified: trunk/ChangeLog (188238 => 188239) --- trunk/ChangeLog 2015-08-10 23:56:51 UTC (rev 188238) +++ trunk/ChangeLog 2015-08-11 00:09:07 UTC (rev 188239) @@ -1,3 +1,13 @@ +2015-08-10 Alex Christensen + +Build TestWebKitAPI with CMake on Windows +https://bugs.webkit.org/show_bug.cgi?id=147851 + +Reviewed by Chris Dumez. + +* Source/cmake/OptionsWindows.cmake: +Enable api tests and set USE_SYSTEM_MALLOC to avoid warnings when redefining it. + 2015-08-06 Alex Christensen [Win] CMake build fix after r188098. Modified: trunk/Source/ThirdParty/ChangeLog (188238 => 188239) --- trunk/Source/ThirdParty/ChangeLog 2015-08-10 23:56:51 UTC (rev 188238) +++ trunk/Source/ThirdParty/ChangeLog 2015-08-11 00:09:07 UTC (rev 188239) @@ -1,3 +1,13 @@ +2015-08-10 Alex Christensen + +Build TestWebKitAPI with CMake on Windows +https://bugs.webkit.org/show_bug.cgi?id=147851 + +Reviewed by Chris Dumez. + +* gtest/CMakeLists.txt: +Include DerivedSources to find WTF/WTFHeaderDetection.h. + 2015-05-26 Dan Bernstein Update build settings Modified: trunk/Source/ThirdParty/gtest/CMakeLists.txt (188238 => 188239) --- trunk/Source/ThirdParty/gtest/CMakeLists.txt 2015-08-10 23:56:51 UTC (rev 188238) +++ trunk/Source/ThirdParty/gtest/CMakeLists.txt 2015-08-11 00:09:07 UTC (rev 188239) @@ -9,6 +9,7 @@ "${GTEST_DIR}" "${GTEST_DIR}/include" "${_javascript_CORE_DIR}" +"${DERIVED_SOURCES_DIR}" "${DERIVED_SOURCES_JAVASCRIPTCORE_DIR}" "${WTF_DIR}" ) Modified: trunk/Source/WebCore/ChangeLog (188238 => 188239) --- trunk/Source/WebCore/ChangeLog 2015-08-10 23:56:51 UTC (rev 188238) +++ trunk/Source/WebCore/ChangeLog 2015-08-11 00:09:07 UTC (rev 188239) @@ -1,3 +1,15 @@ +2015-08-10 Alex Christensen + +Build TestWebKitAPI with CMake on Windows +https://bugs.webkit.org/show_bug.cgi?id=147851 + +Reviewed by Chris Dumez. + +* PlatformWin.cmake: +Remove RenderThemeWin.cpp which is included in RenderingAllInOne.cpp. +* WebCorePrefix.h: +Include cmakeconfig.h before wtf/Platform.h like we do in _javascript_Core's config.h to avoid warnings and redefining ENABLE_* macros. + 2015-08-10 Matthew Daiter HTMLMediaElement needs way to find MediaDeviceInfo Modified: trunk/Source/WebCore/PlatformWin.cmake (188238 =>
[webkit-changes] [188240] tags/Safari-601.1.46.7/
Title: [188240] tags/Safari-601.1.46.7/ Revision 188240 Author bshaf...@apple.com Date 2015-08-10 17:38:14 -0700 (Mon, 10 Aug 2015) Log Message New tag. Added Paths tags/Safari-601.1.46.7/ Diff Property changes: tags/Safari-601.1.46.7 Added: svn:ignore depcomp compile config.guess GNUmakefile.in config.sub ltmain.sh aconfig.h.in autom4te.cache missing aclocal.m4 install-sh autotoolsconfig.h.in INSTALL README gtk-doc.make out Makefile.chromium WebKitSupportLibrary.zip WebKitBuild Added: svn:mergeinfo ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [188241] tags/Safari-601.1.49/
Title: [188241] tags/Safari-601.1.49/ Revision 188241 Author bshaf...@apple.com Date 2015-08-10 18:11:11 -0700 (Mon, 10 Aug 2015) Log Message New tag. Added Paths tags/Safari-601.1.49/ Diff Property changes: tags/Safari-601.1.49 Added: svn:ignore depcomp compile config.guess GNUmakefile.in config.sub ltmain.sh aconfig.h.in autom4te.cache missing aclocal.m4 install-sh autotoolsconfig.h.in INSTALL README gtk-doc.make out Makefile.chromium WebKitSupportLibrary.zip WebKitBuild Added: svn:mergeinfo ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [188242] trunk/Source/JavaScriptCore
Title: [188242] trunk/Source/_javascript_Core Revision 188242 Author gga...@apple.com Date 2015-08-10 18:26:30 -0700 (Mon, 10 Aug 2015) Log Message Start beating UnlinkedCodeBlock.h/.cpp with the "One Class per File" stick https://bugs.webkit.org/show_bug.cgi?id=147856 Reviewed by Saam Barati. Split out UnlinkedFunctionExecutable.h/.cpp and ExecutableInfo.h into separate files. * CMakeLists.txt: * _javascript_Core.vcxproj/_javascript_Core.vcxproj: * _javascript_Core.vcxproj/_javascript_Core.vcxproj.filters: * _javascript_Core.xcodeproj/project.pbxproj: * bytecode/ExecutableInfo.h: Copied from Source/_javascript_Core/bytecode/UnlinkedCodeBlock.h. (JSC::ExecutableInfo::ExecutableInfo): (JSC::UnlinkedStringJumpTable::offsetForValue): Deleted. (JSC::UnlinkedSimpleJumpTable::add): Deleted. (JSC::UnlinkedInstruction::UnlinkedInstruction): Deleted. (JSC::UnlinkedCodeBlock::isConstructor): Deleted. (JSC::UnlinkedCodeBlock::isStrictMode): Deleted. (JSC::UnlinkedCodeBlock::usesEval): Deleted. (JSC::UnlinkedCodeBlock::needsFullScopeChain): Deleted. (JSC::UnlinkedCodeBlock::hasExpressionInfo): Deleted. (JSC::UnlinkedCodeBlock::setThisRegister): Deleted. (JSC::UnlinkedCodeBlock::setScopeRegister): Deleted. (JSC::UnlinkedCodeBlock::setActivationRegister): Deleted. (JSC::UnlinkedCodeBlock::usesGlobalObject): Deleted. (JSC::UnlinkedCodeBlock::setGlobalObjectRegister): Deleted. (JSC::UnlinkedCodeBlock::globalObjectRegister): Deleted. (JSC::UnlinkedCodeBlock::setNumParameters): Deleted. (JSC::UnlinkedCodeBlock::addParameter): Deleted. (JSC::UnlinkedCodeBlock::numParameters): Deleted. (JSC::UnlinkedCodeBlock::addRegExp): Deleted. (JSC::UnlinkedCodeBlock::numberOfRegExps): Deleted. (JSC::UnlinkedCodeBlock::regexp): Deleted. (JSC::UnlinkedCodeBlock::numberOfIdentifiers): Deleted. (JSC::UnlinkedCodeBlock::addIdentifier): Deleted. (JSC::UnlinkedCodeBlock::identifier): Deleted. (JSC::UnlinkedCodeBlock::identifiers): Deleted. (JSC::UnlinkedCodeBlock::addConstant): Deleted. (JSC::UnlinkedCodeBlock::registerIndexForLinkTimeConstant): Deleted. (JSC::UnlinkedCodeBlock::constantRegisters): Deleted. (JSC::UnlinkedCodeBlock::constantRegister): Deleted. (JSC::UnlinkedCodeBlock::isConstantRegisterIndex): Deleted. (JSC::UnlinkedCodeBlock::constantsSourceCodeRepresentation): Deleted. (JSC::UnlinkedCodeBlock::numberOfJumpTargets): Deleted. (JSC::UnlinkedCodeBlock::addJumpTarget): Deleted. (JSC::UnlinkedCodeBlock::jumpTarget): Deleted. (JSC::UnlinkedCodeBlock::lastJumpTarget): Deleted. (JSC::UnlinkedCodeBlock::isBuiltinFunction): Deleted. (JSC::UnlinkedCodeBlock::constructorKind): Deleted. (JSC::UnlinkedCodeBlock::shrinkToFit): Deleted. (JSC::UnlinkedCodeBlock::numberOfSwitchJumpTables): Deleted. (JSC::UnlinkedCodeBlock::addSwitchJumpTable): Deleted. (JSC::UnlinkedCodeBlock::switchJumpTable): Deleted. (JSC::UnlinkedCodeBlock::numberOfStringSwitchJumpTables): Deleted. (JSC::UnlinkedCodeBlock::addStringSwitchJumpTable): Deleted. (JSC::UnlinkedCodeBlock::stringSwitchJumpTable): Deleted. (JSC::UnlinkedCodeBlock::addFunctionDecl): Deleted. (JSC::UnlinkedCodeBlock::functionDecl): Deleted. (JSC::UnlinkedCodeBlock::numberOfFunctionDecls): Deleted. (JSC::UnlinkedCodeBlock::addFunctionExpr): Deleted. (JSC::UnlinkedCodeBlock::functionExpr): Deleted. (JSC::UnlinkedCodeBlock::numberOfFunctionExprs): Deleted. (JSC::UnlinkedCodeBlock::numberOfExceptionHandlers): Deleted. (JSC::UnlinkedCodeBlock::addExceptionHandler): Deleted. (JSC::UnlinkedCodeBlock::exceptionHandler): Deleted. (JSC::UnlinkedCodeBlock::vm): Deleted. (JSC::UnlinkedCodeBlock::addArrayProfile): Deleted. (JSC::UnlinkedCodeBlock::numberOfArrayProfiles): Deleted. (JSC::UnlinkedCodeBlock::addArrayAllocationProfile): Deleted. (JSC::UnlinkedCodeBlock::numberOfArrayAllocationProfiles): Deleted. (JSC::UnlinkedCodeBlock::addObjectAllocationProfile): Deleted. (JSC::UnlinkedCodeBlock::numberOfObjectAllocationProfiles): Deleted. (JSC::UnlinkedCodeBlock::addValueProfile): Deleted. (JSC::UnlinkedCodeBlock::numberOfValueProfiles): Deleted. (JSC::UnlinkedCodeBlock::addLLIntCallLinkInfo): Deleted. (JSC::UnlinkedCodeBlock::numberOfLLintCallLinkInfos): Deleted. (JSC::UnlinkedCodeBlock::codeType): Deleted. (JSC::UnlinkedCodeBlock::thisRegister): Deleted. (JSC::UnlinkedCodeBlock::scopeRegister): Deleted. (JSC::UnlinkedCodeBlock::activationRegister): Deleted. (JSC::UnlinkedCodeBlock::hasActivationRegister): Deleted. (JSC::UnlinkedCodeBlock::addPropertyAccessInstruction): Deleted. (JSC::UnlinkedCodeBlock::numberOfPropertyAccessInstructions): Deleted. (JSC::UnlinkedCodeBlock::propertyAccessInstructions): Deleted. (JSC::UnlinkedCodeBlock::constantBufferCount): Deleted. (JSC::UnlinkedCodeBlock::addConstantBuffer): Deleted. (JSC::UnlinkedCodeBlock::constantBuffer): Deleted. (JSC::UnlinkedCodeBlock::hasRareData): Deleted. (JSC::UnlinkedCodeBlock::recordParse): Deleted. (JSC::UnlinkedCodeBlock::codeFeatures): Deleted. (JSC::UnlinkedCodeBlock::hasCapturedVariables): Deleted. (JSC::UnlinkedCodeBlock::firstLine):
[webkit-changes] [188243] trunk/Source/WebCore
Title: [188243] trunk/Source/WebCore Revision 188243 Author mmaxfi...@apple.com Date 2015-08-10 19:49:35 -0700 (Mon, 10 Aug 2015) Log Message Post-review fixup after r188195 https://bugs.webkit.org/show_bug.cgi?id=147806 Unreviewed. Covered by fast/text/crash-obscure-text.html. * platform/graphics/cocoa/FontPlatformDataCocoa.mm: (WebCore::FontPlatformData::objectForEqualityCheck): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/platform/graphics/cocoa/FontPlatformDataCocoa.mm Diff Modified: trunk/Source/WebCore/ChangeLog (188242 => 188243) --- trunk/Source/WebCore/ChangeLog 2015-08-11 01:26:30 UTC (rev 188242) +++ trunk/Source/WebCore/ChangeLog 2015-08-11 02:49:35 UTC (rev 188243) @@ -1,3 +1,15 @@ +2015-08-10 Myles C. Maxfield + +Post-review fixup after r188195 +https://bugs.webkit.org/show_bug.cgi?id=147806 + +Unreviewed. + +Covered by fast/text/crash-obscure-text.html. + +* platform/graphics/cocoa/FontPlatformDataCocoa.mm: +(WebCore::FontPlatformData::objectForEqualityCheck): + 2015-08-10 Alex Christensen Build TestWebKitAPI with CMake on Windows Modified: trunk/Source/WebCore/platform/graphics/cocoa/FontPlatformDataCocoa.mm (188242 => 188243) --- trunk/Source/WebCore/platform/graphics/cocoa/FontPlatformDataCocoa.mm 2015-08-11 01:26:30 UTC (rev 188242) +++ trunk/Source/WebCore/platform/graphics/cocoa/FontPlatformDataCocoa.mm 2015-08-11 02:49:35 UTC (rev 188243) @@ -214,7 +214,7 @@ // FIXME: https://bugs.webkit.org/show_bug.cgi?id=138683 This is a shallow pointer compare for web fonts // because the URL contains the address of the font. This means we might erroneously get false negatives. RetainPtr url = "" kCTFontReferenceURLAttribute))); -ASSERT(CFGetTypeID(url.get()) == CFURLGetTypeID()); +ASSERT(!url || CFGetTypeID(url.get()) == CFURLGetTypeID()); return url; } ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [188244] trunk/Tools
Title: [188244] trunk/Tools Revision 188244 Author commit-qu...@webkit.org Date 2015-08-10 20:15:00 -0700 (Mon, 10 Aug 2015) Log Message Update ReadMe and correct the way to use abstract abstract class. https://bugs.webkit.org/show_bug.cgi?id=147860 Patch by Dewei Zhu on 2015-08-10 Reviewed by Ryosuke Niwa. Update ReadMe according to recent changes. And set ABCMeta to be the __metaclass__ of BrowserDriver and HTTPServerDriver, so that all methods annotated by 'abstractmethod' will check whether they are implememnt by subclasses. * Scripts/webkitpy/benchmark_runner/README.md: * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py: (BrowserDriver): * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py: (OSXBrowserDriver.restore_env): * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server_driver.py: (HTTPServerDriver): (HTTPServerDriver.set_device_id): * Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py: (SimpleHTTPServerDriver.get_return_code): (SimpleHTTPServerDriver): (SimpleHTTPServerDriver.set_device_id): Modified Paths trunk/Tools/ChangeLog trunk/Tools/Scripts/webkitpy/benchmark_runner/README.md trunk/Tools/Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py trunk/Tools/Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py trunk/Tools/Scripts/webkitpy/benchmark_runner/http_server_driver/http_server_driver.py trunk/Tools/Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py Diff Modified: trunk/Tools/ChangeLog (188243 => 188244) --- trunk/Tools/ChangeLog 2015-08-11 02:49:35 UTC (rev 188243) +++ trunk/Tools/ChangeLog 2015-08-11 03:15:00 UTC (rev 188244) @@ -1,3 +1,26 @@ +2015-08-10 Dewei Zhu + +Update ReadMe and correct the way to use abstract abstract class. +https://bugs.webkit.org/show_bug.cgi?id=147860 + +Reviewed by Ryosuke Niwa. + +Update ReadMe according to recent changes. And set ABCMeta to be the __metaclass__ of BrowserDriver and HTTPServerDriver, +so that all methods annotated by 'abstractmethod' will check whether they are implememnt by subclasses. + +* Scripts/webkitpy/benchmark_runner/README.md: +* Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py: +(BrowserDriver): +* Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py: +(OSXBrowserDriver.restore_env): +* Scripts/webkitpy/benchmark_runner/http_server_driver/http_server_driver.py: +(HTTPServerDriver): +(HTTPServerDriver.set_device_id): +* Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py: +(SimpleHTTPServerDriver.get_return_code): +(SimpleHTTPServerDriver): +(SimpleHTTPServerDriver.set_device_id): + 2015-08-10 Alex Christensen Build TestWebKitAPI with CMake on Windows Modified: trunk/Tools/Scripts/webkitpy/benchmark_runner/README.md (188243 => 188244) --- trunk/Tools/Scripts/webkitpy/benchmark_runner/README.md 2015-08-11 02:49:35 UTC (rev 188243) +++ trunk/Tools/Scripts/webkitpy/benchmark_runner/README.md 2015-08-11 03:15:00 UTC (rev 188244) @@ -5,27 +5,37 @@ benchmark_runner ├── README.md ├── __init__.py -├── benchmark_builder -│  ├── __init__.py -│  ├── benchmark_builder_factory.py -│  ├── benchmark_builders.json -│  ├── generic_benchmark_builder.py -│  └── jetstream_benchmark_builder.py +├── benchmark_builder.py +├── benchmark_results.py +├── benchmark_results_unittest.py ├── benchmark_runner.py ├── browser_driver │  ├── __init__.py │  ├── browser_driver.py │  ├── browser_driver_factory.py -│  ├── browser_drivers.json +│  ├── osx_browser_driver.py │  ├── osx_chrome_driver.py +│  ├── osx_firefox_driver.py │  └── osx_safari_driver.py ├── data │  ├── patches +│  │  ├── Dromaeo.patch +│  │  ├── JSBench.patch │  │  ├── JetStream.patch -│  │  └── Speedometer.patch +│  │  ├── Kraken.patch +│  │  ├── Octane.patch +│  │  ├── Speedometer.patch +│  │  └── SunSpider.patch │  └── plans +│  ├── dromaeo-cssquery.plan +│  ├── dromaeo-dom.plan +│  ├── dromaeo-jslib.plan │  ├── jetstream.plan -│  └── speedometer.plan +│  ├── jsbench.plan +│  ├── kraken.plan +│  ├── octane.plan +│  ├── speedometer.plan +│  └── sunspider.plan ├── generic_factory.py ├── http_server_driver │  ├── __init__.py @@ -33,8 +43,8 @@ │  │  └── twisted_http_server.py │  ├── http_server_driver.py │  ├── http_server_driver_factory.py -│  ├── http_server_drivers.json │  └── simple_http_server_driver.py +├── run_benchmark.py └── utils.py ``` ## Requirements @@ -54,10 +64,8 @@ To create a plan, you may refer to Plans/jetstream.plan. ```json { -"http_server_driver": "SimpleHTTPServerDriver", "timeout" : 600, "count": 5, -"benchmark_builder": "JetStreamBenchmarkBuilder", "local
[webkit-changes] [188245] trunk/Tools
Title: [188245] trunk/Tools Revision 188245 Author rn...@webkit.org Date 2015-08-10 20:46:43 -0700 (Mon, 10 Aug 2015) Log Message Build fix after r188237. * Scripts/webkitpy/benchmark_runner/benchmark_builder.py: (BenchmarkBuilder.__enter__): Modified Paths trunk/Tools/ChangeLog trunk/Tools/Scripts/webkitpy/benchmark_runner/benchmark_builder.py Diff Modified: trunk/Tools/ChangeLog (188244 => 188245) --- trunk/Tools/ChangeLog 2015-08-11 03:15:00 UTC (rev 188244) +++ trunk/Tools/ChangeLog 2015-08-11 03:46:43 UTC (rev 188245) @@ -1,3 +1,10 @@ +2015-08-10 Ryosuke Niwa + +Build fix after r188237. + +* Scripts/webkitpy/benchmark_runner/benchmark_builder.py: +(BenchmarkBuilder.__enter__): + 2015-08-10 Dewei Zhu Update ReadMe and correct the way to use abstract abstract class. Modified: trunk/Tools/Scripts/webkitpy/benchmark_runner/benchmark_builder.py (188244 => 188245) --- trunk/Tools/Scripts/webkitpy/benchmark_runner/benchmark_builder.py 2015-08-11 03:15:00 UTC (rev 188244) +++ trunk/Tools/Scripts/webkitpy/benchmark_runner/benchmark_builder.py 2015-08-11 03:46:43 UTC (rev 188245) @@ -35,7 +35,7 @@ _log.info('Copied the benchmark into: %s' % self._dest) try: if 'create_script' in self._plan: -self._run_create_script(plan['create_script']) +self._run_create_script(self._plan['create_script']) if 'benchmark_patch' in self._plan: self._apply_patch(self._plan['benchmark_patch']) return self._web_root ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [188246] trunk/Source/ThirdParty
Title: [188246] trunk/Source/ThirdParty Revision 188246 Author achristen...@apple.com Date 2015-08-10 21:25:22 -0700 (Mon, 10 Aug 2015) Log Message [Win] Unreviewed build fix after r188239. * gtest/CMakeLists.txt: VS2015 requires __STDC_LIMIT_MACROS to be defined for INTMAX_MAX to be defined. Modified Paths trunk/Source/ThirdParty/ChangeLog trunk/Source/ThirdParty/gtest/CMakeLists.txt Diff Modified: trunk/Source/ThirdParty/ChangeLog (188245 => 188246) --- trunk/Source/ThirdParty/ChangeLog 2015-08-11 03:46:43 UTC (rev 188245) +++ trunk/Source/ThirdParty/ChangeLog 2015-08-11 04:25:22 UTC (rev 188246) @@ -1,5 +1,12 @@ 2015-08-10 Alex Christensen +[Win] Unreviewed build fix after r188239. + +* gtest/CMakeLists.txt: +VS2015 requires __STDC_LIMIT_MACROS to be defined for INTMAX_MAX to be defined. + +2015-08-10 Alex Christensen + Build TestWebKitAPI with CMake on Windows https://bugs.webkit.org/show_bug.cgi?id=147851 Modified: trunk/Source/ThirdParty/gtest/CMakeLists.txt (188245 => 188246) --- trunk/Source/ThirdParty/gtest/CMakeLists.txt 2015-08-11 03:46:43 UTC (rev 188245) +++ trunk/Source/ThirdParty/gtest/CMakeLists.txt 2015-08-11 04:25:22 UTC (rev 188246) @@ -24,6 +24,11 @@ ${GTEST_DIR}/src/gtest-typed-test.cc ) +if (WIN32) +# MSVC 2015 requires this definition for INTMAX_MAX to be defined. +add_definitions(-D__STDC_LIMIT_MACROS) +endif () + add_library(gtest SHARED ${GTEST_SOURCES}) include_directories(${GTEST_INCLUDE_DIRECTORIES}) add_definitions(-DGTEST_CREATE_SHARED_LIBRARY=1 -DGTEST_HAS_RTTI=0) ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [188247] trunk/Source/WebCore
Title: [188247] trunk/Source/WebCore Revision 188247 Author achristen...@apple.com Date 2015-08-10 21:46:28 -0700 (Mon, 10 Aug 2015) Log Message Build fix after r188239. * PlatformWinCairo.cmake: MediaPlayerPrivateMediaFoundation is needed on WinCairo with video properly enabled. Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/PlatformWinCairo.cmake Diff Modified: trunk/Source/WebCore/ChangeLog (188246 => 188247) --- trunk/Source/WebCore/ChangeLog 2015-08-11 04:25:22 UTC (rev 188246) +++ trunk/Source/WebCore/ChangeLog 2015-08-11 04:46:28 UTC (rev 188247) @@ -1,3 +1,10 @@ +2015-08-10 Alex Christensen + +Build fix after r188239. + +* PlatformWinCairo.cmake: +MediaPlayerPrivateMediaFoundation is needed on WinCairo with video properly enabled. + 2015-08-10 Myles C. Maxfield Post-review fixup after r188195 Modified: trunk/Source/WebCore/PlatformWinCairo.cmake (188246 => 188247) --- trunk/Source/WebCore/PlatformWinCairo.cmake 2015-08-11 04:25:22 UTC (rev 188246) +++ trunk/Source/WebCore/PlatformWinCairo.cmake 2015-08-11 04:46:28 UTC (rev 188247) @@ -81,6 +81,7 @@ platform/graphics/win/GraphicsContextCairoWin.cpp platform/graphics/win/GraphicsContextWin.cpp platform/graphics/win/ImageCairoWin.cpp +platform/graphics/win/MediaPlayerPrivateMediaFoundation.cpp platform/graphics/win/SimpleFontDataCairoWin.cpp platform/graphics/win/SimpleFontDataWin.cpp platform/graphics/win/TransformationMatrixWin.cpp ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [188248] trunk/Source/WebKit
Title: [188248] trunk/Source/WebKit Revision 188248 Author achristen...@apple.com Date 2015-08-10 21:59:07 -0700 (Mon, 10 Aug 2015) Log Message Another build fix after r188239. * PlatformWin.cmake: Link WinCairo with Media Foundation libraries. Modified Paths trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/PlatformWin.cmake Diff Modified: trunk/Source/WebKit/ChangeLog (188247 => 188248) --- trunk/Source/WebKit/ChangeLog 2015-08-11 04:46:28 UTC (rev 188247) +++ trunk/Source/WebKit/ChangeLog 2015-08-11 04:59:07 UTC (rev 188248) @@ -1,5 +1,12 @@ 2015-08-10 Alex Christensen +Another build fix after r188239. + +* PlatformWin.cmake: +Link WinCairo with Media Foundation libraries. + +2015-08-10 Alex Christensen + Build TestWebKitAPI with CMake on Windows https://bugs.webkit.org/show_bug.cgi?id=147851 Modified: trunk/Source/WebKit/PlatformWin.cmake (188247 => 188248) --- trunk/Source/WebKit/PlatformWin.cmake 2015-08-11 04:46:28 UTC (rev 188247) +++ trunk/Source/WebKit/PlatformWin.cmake 2015-08-11 04:59:07 UTC (rev 188248) @@ -12,7 +12,9 @@ ) list(APPEND WebKit_LIBRARIES PRIVATE libeay32.lib +PRIVATE mfuuid.lib PRIVATE ssleay32.lib +PRIVATE strmiids.lib ) else () list(APPEND WebKit_SOURCES_Classes ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [188249] branches/safari-601.1.46-branch/Source
Title: [188249] branches/safari-601.1.46-branch/Source Revision 188249 Author bshaf...@apple.com Date 2015-08-10 22:06:28 -0700 (Mon, 10 Aug 2015) Log Message Versioning. Modified Paths branches/safari-601.1.46-branch/Source/_javascript_Core/Configurations/Version.xcconfig branches/safari-601.1.46-branch/Source/WebCore/Configurations/Version.xcconfig branches/safari-601.1.46-branch/Source/WebInspectorUI/Configurations/Version.xcconfig branches/safari-601.1.46-branch/Source/WebKit/mac/Configurations/Version.xcconfig branches/safari-601.1.46-branch/Source/WebKit2/Configurations/Version.xcconfig Diff Modified: branches/safari-601.1.46-branch/Source/_javascript_Core/Configurations/Version.xcconfig (188248 => 188249) --- branches/safari-601.1.46-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2015-08-11 04:59:07 UTC (rev 188248) +++ branches/safari-601.1.46-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2015-08-11 05:06:28 UTC (rev 188249) @@ -24,7 +24,7 @@ MAJOR_VERSION = 601; MINOR_VERSION = 1; TINY_VERSION = 46; -MICRO_VERSION = 7; +MICRO_VERSION = 8; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION); Modified: branches/safari-601.1.46-branch/Source/WebCore/Configurations/Version.xcconfig (188248 => 188249) --- branches/safari-601.1.46-branch/Source/WebCore/Configurations/Version.xcconfig 2015-08-11 04:59:07 UTC (rev 188248) +++ branches/safari-601.1.46-branch/Source/WebCore/Configurations/Version.xcconfig 2015-08-11 05:06:28 UTC (rev 188249) @@ -24,7 +24,7 @@ MAJOR_VERSION = 601; MINOR_VERSION = 1; TINY_VERSION = 46; -MICRO_VERSION = 7; +MICRO_VERSION = 8; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION); Modified: branches/safari-601.1.46-branch/Source/WebInspectorUI/Configurations/Version.xcconfig (188248 => 188249) --- branches/safari-601.1.46-branch/Source/WebInspectorUI/Configurations/Version.xcconfig 2015-08-11 04:59:07 UTC (rev 188248) +++ branches/safari-601.1.46-branch/Source/WebInspectorUI/Configurations/Version.xcconfig 2015-08-11 05:06:28 UTC (rev 188249) @@ -1,7 +1,7 @@ MAJOR_VERSION = 601; MINOR_VERSION = 1; TINY_VERSION = 46; -MICRO_VERSION = 7; +MICRO_VERSION = 8; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION); Modified: branches/safari-601.1.46-branch/Source/WebKit/mac/Configurations/Version.xcconfig (188248 => 188249) --- branches/safari-601.1.46-branch/Source/WebKit/mac/Configurations/Version.xcconfig 2015-08-11 04:59:07 UTC (rev 188248) +++ branches/safari-601.1.46-branch/Source/WebKit/mac/Configurations/Version.xcconfig 2015-08-11 05:06:28 UTC (rev 188249) @@ -24,7 +24,7 @@ MAJOR_VERSION = 601; MINOR_VERSION = 1; TINY_VERSION = 46; -MICRO_VERSION = 7; +MICRO_VERSION = 8; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION); Modified: branches/safari-601.1.46-branch/Source/WebKit2/Configurations/Version.xcconfig (188248 => 188249) --- branches/safari-601.1.46-branch/Source/WebKit2/Configurations/Version.xcconfig 2015-08-11 04:59:07 UTC (rev 188248) +++ branches/safari-601.1.46-branch/Source/WebKit2/Configurations/Version.xcconfig 2015-08-11 05:06:28 UTC (rev 188249) @@ -24,7 +24,7 @@ MAJOR_VERSION = 601; MINOR_VERSION = 1; TINY_VERSION = 46; -MICRO_VERSION = 7; +MICRO_VERSION = 8; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION); ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [188250] branches/safari-601.1-branch/Source
Title: [188250] branches/safari-601.1-branch/Source Revision 188250 Author bshaf...@apple.com Date 2015-08-10 22:07:07 -0700 (Mon, 10 Aug 2015) Log Message Versioning. Modified Paths branches/safari-601.1-branch/Source/_javascript_Core/Configurations/Version.xcconfig branches/safari-601.1-branch/Source/WebCore/Configurations/Version.xcconfig branches/safari-601.1-branch/Source/WebInspectorUI/Configurations/Version.xcconfig branches/safari-601.1-branch/Source/WebKit/mac/Configurations/Version.xcconfig branches/safari-601.1-branch/Source/WebKit2/Configurations/Version.xcconfig Diff Modified: branches/safari-601.1-branch/Source/_javascript_Core/Configurations/Version.xcconfig (188249 => 188250) --- branches/safari-601.1-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2015-08-11 05:06:28 UTC (rev 188249) +++ branches/safari-601.1-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2015-08-11 05:07:07 UTC (rev 188250) @@ -23,7 +23,7 @@ MAJOR_VERSION = 601; MINOR_VERSION = 1; -TINY_VERSION = 49; +TINY_VERSION = 50; MICRO_VERSION = 0; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); Modified: branches/safari-601.1-branch/Source/WebCore/Configurations/Version.xcconfig (188249 => 188250) --- branches/safari-601.1-branch/Source/WebCore/Configurations/Version.xcconfig 2015-08-11 05:06:28 UTC (rev 188249) +++ branches/safari-601.1-branch/Source/WebCore/Configurations/Version.xcconfig 2015-08-11 05:07:07 UTC (rev 188250) @@ -23,7 +23,7 @@ MAJOR_VERSION = 601; MINOR_VERSION = 1; -TINY_VERSION = 49; +TINY_VERSION = 50; MICRO_VERSION = 0; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); Modified: branches/safari-601.1-branch/Source/WebInspectorUI/Configurations/Version.xcconfig (188249 => 188250) --- branches/safari-601.1-branch/Source/WebInspectorUI/Configurations/Version.xcconfig 2015-08-11 05:06:28 UTC (rev 188249) +++ branches/safari-601.1-branch/Source/WebInspectorUI/Configurations/Version.xcconfig 2015-08-11 05:07:07 UTC (rev 188250) @@ -1,6 +1,6 @@ MAJOR_VERSION = 601; MINOR_VERSION = 1; -TINY_VERSION = 49; +TINY_VERSION = 50; MICRO_VERSION = 0; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); Modified: branches/safari-601.1-branch/Source/WebKit/mac/Configurations/Version.xcconfig (188249 => 188250) --- branches/safari-601.1-branch/Source/WebKit/mac/Configurations/Version.xcconfig 2015-08-11 05:06:28 UTC (rev 188249) +++ branches/safari-601.1-branch/Source/WebKit/mac/Configurations/Version.xcconfig 2015-08-11 05:07:07 UTC (rev 188250) @@ -23,7 +23,7 @@ MAJOR_VERSION = 601; MINOR_VERSION = 1; -TINY_VERSION = 49; +TINY_VERSION = 50; MICRO_VERSION = 0; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); Modified: branches/safari-601.1-branch/Source/WebKit2/Configurations/Version.xcconfig (188249 => 188250) --- branches/safari-601.1-branch/Source/WebKit2/Configurations/Version.xcconfig 2015-08-11 05:06:28 UTC (rev 188249) +++ branches/safari-601.1-branch/Source/WebKit2/Configurations/Version.xcconfig 2015-08-11 05:07:07 UTC (rev 188250) @@ -23,7 +23,7 @@ MAJOR_VERSION = 601; MINOR_VERSION = 1; -TINY_VERSION = 49; +TINY_VERSION = 50; MICRO_VERSION = 0; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [188251] trunk/Tools
Title: [188251] trunk/Tools Revision 188251 Author achristen...@apple.com Date 2015-08-10 23:40:56 -0700 (Mon, 10 Aug 2015) Log Message Another build fix after r188239. * TestWebKitAPI/PlatformWin.cmake: Link with more libraries. * WinLauncher/CMakeLists.txt: /NODEFAULTLIB:MSVCRT is not just needed for AppleWin. Modified Paths trunk/Tools/ChangeLog trunk/Tools/TestWebKitAPI/PlatformWin.cmake trunk/Tools/WinLauncher/CMakeLists.txt Diff Modified: trunk/Tools/ChangeLog (188250 => 188251) --- trunk/Tools/ChangeLog 2015-08-11 05:07:07 UTC (rev 188250) +++ trunk/Tools/ChangeLog 2015-08-11 06:40:56 UTC (rev 188251) @@ -1,3 +1,12 @@ +2015-08-10 Alex Christensen + +Another build fix after r188239. + +* TestWebKitAPI/PlatformWin.cmake: +Link with more libraries. +* WinLauncher/CMakeLists.txt: +/NODEFAULTLIB:MSVCRT is not just needed for AppleWin. + 2015-08-10 Ryosuke Niwa Build fix after r188237. Modified: trunk/Tools/TestWebKitAPI/PlatformWin.cmake (188250 => 188251) --- trunk/Tools/TestWebKitAPI/PlatformWin.cmake 2015-08-11 05:07:07 UTC (rev 188250) +++ trunk/Tools/TestWebKitAPI/PlatformWin.cmake 2015-08-11 06:40:56 UTC (rev 188251) @@ -27,7 +27,12 @@ if (${WTF_PLATFORM_WIN_CAIRO}) list(APPEND test_webcore_LIBRARIES cairo -curl +libANGLE +libeay32 +mfuuid +ssleay32 +strmiids +vcruntime ) else () list(APPEND test_webcore_LIBRARIES Modified: trunk/Tools/WinLauncher/CMakeLists.txt (188250 => 188251) --- trunk/Tools/WinLauncher/CMakeLists.txt 2015-08-11 05:07:07 UTC (rev 188250) +++ trunk/Tools/WinLauncher/CMakeLists.txt 2015-08-11 06:40:56 UTC (rev 188251) @@ -40,12 +40,12 @@ CFLite ) else () -set(CMAKE_SHARED_LINKER_FLAGS "${CMAKE_SHARED_LINKER_FLAGS} /NODEFAULTLIB:MSVCRT") list(APPEND WinLauncher_LIBRARIES CoreFoundation ) endif () +set(CMAKE_SHARED_LINKER_FLAGS "${CMAKE_SHARED_LINKER_FLAGS} /NODEFAULTLIB:MSVCRT") set(CMAKE_EXE_LINKER_FLAGS "${CMAKE_EXE_LINKER_FLAGS} /ENTRY:wWinMainCRTStartup") if (${WTF_PLATFORM_WIN_CAIRO}) ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [188252] trunk
Title: [188252] trunk Revision 188252 Author cdu...@apple.com Date 2015-08-10 23:42:09 -0700 (Mon, 10 Aug 2015) Log Message The 'prototype' property on interface objects should not be enumerable https://bugs.webkit.org/show_bug.cgi?id=147861 Reviewed by Darin Adler. Source/WebCore: 1. Make the 'prototype' property not enumerable on interface object to comply with the Web IDL specification [1] and to align our behavior with Firefox 38 and Chrome 44. 2. Also update the 'prototype' property on named constructors to have the following attributes: { [[Writable]]: false, [[Enumerable]]: false, [[Configurable]]: false } Previously, all these were true in WebKit. The new behavior complies with the Web IDL specification [2] and aligns our behavior with Firefox 38. On Chrome 44, the attributes are as follows: { [[Writable]]: true, [[Enumerable]]: false, [[Configurable]]: false } This behavior is also covered by the following W3C test suite: http://w3c-test.org/dom/interfaces.html [1] http://heycam.github.io/webidl/#interface-object [2] http://heycam.github.io/webidl/#named-constructors Test: fast/dom/prototype-property-not-enumerable.html * bindings/scripts/CodeGeneratorJS.pm: (GenerateConstructorHelperMethods): LayoutTests: Add layout test to check that the 'prototype' property on interface objects has the following attributes: { [[Writable]]: false, [[Enumerable]]: false, [[Configurable]]: false } * fast/dom/prototype-property-not-enumerable-expected.txt: Added. * fast/dom/prototype-property-not-enumerable.html: Added. Modified Paths trunk/LayoutTests/ChangeLog trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm Added Paths trunk/LayoutTests/fast/dom/prototype-property-not-enumerable-expected.txt trunk/LayoutTests/fast/dom/prototype-property-not-enumerable.html Diff Modified: trunk/LayoutTests/ChangeLog (188251 => 188252) --- trunk/LayoutTests/ChangeLog 2015-08-11 06:40:56 UTC (rev 188251) +++ trunk/LayoutTests/ChangeLog 2015-08-11 06:42:09 UTC (rev 188252) @@ -1,3 +1,17 @@ +2015-08-10 Chris Dumez + +The 'prototype' property on interface objects should not be enumerable +https://bugs.webkit.org/show_bug.cgi?id=147861 + +Reviewed by Darin Adler. + +Add layout test to check that the 'prototype' property on interface +objects has the following attributes: +{ [[Writable]]: false, [[Enumerable]]: false, [[Configurable]]: false } + +* fast/dom/prototype-property-not-enumerable-expected.txt: Added. +* fast/dom/prototype-property-not-enumerable.html: Added. + 2015-08-10 Antti Koivisto http/tests/cache/disk-cache/disk-cache-validation.html has too many subtests Added: trunk/LayoutTests/fast/dom/prototype-property-not-enumerable-expected.txt (0 => 188252) --- trunk/LayoutTests/fast/dom/prototype-property-not-enumerable-expected.txt (rev 0) +++ trunk/LayoutTests/fast/dom/prototype-property-not-enumerable-expected.txt 2015-08-11 06:42:09 UTC (rev 188252) @@ -0,0 +1,33 @@ +The 'prototype' property on interface objects should have attributes { [[Writable]]: false, [[Enumerable]]: false, [[Configurable]]: false } + +On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE". + + +* Event +PASS descriptor.writable is false +PASS descriptor.enumerable is false +PASS descriptor.configurable is false +* Element +PASS descriptor.writable is false +PASS descriptor.enumerable is false +PASS descriptor.configurable is false +* Document +PASS descriptor.writable is false +PASS descriptor.enumerable is false +PASS descriptor.configurable is false +* Window +PASS descriptor.writable is false +PASS descriptor.enumerable is false +PASS descriptor.configurable is false +* HTMLOptionElement +PASS descriptor.writable is false +PASS descriptor.enumerable is false +PASS descriptor.configurable is false +* Option +PASS descriptor.writable is false +PASS descriptor.enumerable is false +PASS descriptor.configurable is false +PASS successfullyParsed is true + +TEST COMPLETE + Added: trunk/LayoutTests/fast/dom/prototype-property-not-enumerable.html (0 => 188252) --- trunk/LayoutTests/fast/dom/prototype-property-not-enumerable.html (rev 0) +++ trunk/LayoutTests/fast/dom/prototype-property-not-enumerable.html 2015-08-11 06:42:09 UTC (rev 188252) @@ -0,0 +1,46 @@ + + + + +description("The 'prototype' property on interface objects should have attributes { [[Writable]]: false, [[Enumerable]]: false, [[Configurable]]: false }"); + +debug("* Event"); +var descriptor = Object.getOwnPropertyDescriptor(Event, "prototype"); +shouldBeFalse("descriptor.writable"); +shouldBeFalse("descriptor.enumerable"); +shouldBeFalse("descriptor.configurable"); + +debug("* Element"); +var descriptor = Object.getOwnPropertyDescriptor(Element, "prototype"); +shouldBeFalse("descriptor.writable"); +shouldBeFalse("descriptor.enumerable"
[webkit-changes] [188207] trunk/Tools
Title: [188207] trunk/Tools Revision 188207 Author carlo...@webkit.org Date 2015-08-10 01:24:59 -0700 (Mon, 10 Aug 2015) Log Message [GTK] Test /webkit2/WebKitWebView/submit-form is flaky https://bugs.webkit.org/show_bug.cgi?id=147727 Reviewed by Sergio Villar Senin. I think it was not this test in particular, but /webkit2/WebKitWebView/custom-charset that is affecting the others. This is because changing the encoding reloads the page, but we don't wait for the page to be reloaded, so when the test finishes and other test starts the web process is still reloading the page. * Scripts/run-gtk-tests: (TestRunner): Unskip /webkit2/WebKitWebView/submit-form. * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp: (testWebViewCustomCharset): Wait until page is reloaded after changing the charset. Modified Paths trunk/Tools/ChangeLog trunk/Tools/Scripts/run-gtk-tests trunk/Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp Diff Modified: trunk/Tools/ChangeLog (188206 => 188207) --- trunk/Tools/ChangeLog 2015-08-10 06:50:56 UTC (rev 188206) +++ trunk/Tools/ChangeLog 2015-08-10 08:24:59 UTC (rev 188207) @@ -1,3 +1,23 @@ +2015-08-10 Carlos Garcia Campos + +[GTK] Test /webkit2/WebKitWebView/submit-form is flaky +https://bugs.webkit.org/show_bug.cgi?id=147727 + +Reviewed by Sergio Villar Senin. + +I think it was not this test in particular, but +/webkit2/WebKitWebView/custom-charset that is affecting the +others. This is because changing the encoding reloads the page, +but we don't wait for the page to be reloaded, so when the test +finishes and other test starts the web process is still reloading +the page. + +* Scripts/run-gtk-tests: +(TestRunner): Unskip /webkit2/WebKitWebView/submit-form. +* TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp: +(testWebViewCustomCharset): Wait until page is reloaded after +changing the charset. + 2015-08-09 Carlos Garcia Campos Unreviewed. Skip GTK+ test /webkit2/WebKitWebView/install-missing-plugins-permission-request. Modified: trunk/Tools/Scripts/run-gtk-tests (188206 => 188207) --- trunk/Tools/Scripts/run-gtk-tests 2015-08-10 06:50:56 UTC (rev 188206) +++ trunk/Tools/Scripts/run-gtk-tests 2015-08-10 08:24:59 UTC (rev 188207) @@ -63,7 +63,6 @@ SKIPPED = [ SkippedTest("WebKit2Gtk/TestUIClient", "/webkit2/WebKitWebView/mouse-target", "Test times out after r150890", 117689), SkippedTest("WebKit2Gtk/TestCookieManager", "/webkit2/WebKitCookieManager/persistent-storage", "Test is flaky", 134580), -SkippedTest("WebKit2Gtk/TestWebKitWebView", "/webkit2/WebKitWebView/submit-form", "Test is flaky", 147727), SkippedTest("WebKit2Gtk/TestWebExtensions", "/webkit2/WebKitWebView/install-missing-plugins-permission-request", "Test times out", 147822), SkippedTest("WebKit2/TestWebKit2", "WebKit2.MouseMoveAfterCrash", "Test is flaky", 85066), SkippedTest("WebKit2/TestWebKit2", "WebKit2.NewFirstVisuallyNonEmptyLayoutForImages", "Test is flaky", 85066), Modified: trunk/Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp (188206 => 188207) --- trunk/Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp 2015-08-10 06:50:56 UTC (rev 188206) +++ trunk/Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp 2015-08-10 08:24:59 UTC (rev 188207) @@ -96,11 +96,16 @@ static void testWebViewCustomCharset(WebViewTest* test, gconstpointer) { +test->loadHtml("WebKitGTK+ custom encoding test", nullptr); g_assert(!webkit_web_view_get_custom_charset(test->m_webView)); webkit_web_view_set_custom_charset(test->m_webView, "utf8"); +// Changing the charset reloads the page, so wait until reloaded. +test->waitUntilLoadFinished(); g_assert_cmpstr(webkit_web_view_get_custom_charset(test->m_webView), ==, "utf8"); -// Go back to the default charset. -webkit_web_view_set_custom_charset(test->m_webView, 0); + +// Go back to the default charset and wait until reloaded. +webkit_web_view_set_custom_charset(test->m_webView, nullptr); +test->waitUntilLoadFinished(); g_assert(!webkit_web_view_get_custom_charset(test->m_webView)); } ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [188208] trunk/Source/WebKit2
Title: [188208] trunk/Source/WebKit2 Revision 188208 Author carlo...@webkit.org Date 2015-08-10 01:27:52 -0700 (Mon, 10 Aug 2015) Log Message [GTK] Crash when the web view is destroyed while the screensaver DBUs proxy is being created https://bugs.webkit.org/show_bug.cgi?id=147780 Reviewed by Sergio Villar Senin. We should cancel the screenSaverInhibitCancellable on dispose. Also use adoptGRef() when creating the cancellable object to not leak it. * UIProcess/API/gtk/WebKitWebViewBase.cpp: (webkitWebViewBaseDispose): (webkitWebViewBaseSendInhibitMessageToScreenSaver): (webkitWebViewBaseInhibitScreenSaver): Modified Paths trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebViewBase.cpp Diff Modified: trunk/Source/WebKit2/ChangeLog (188207 => 188208) --- trunk/Source/WebKit2/ChangeLog 2015-08-10 08:24:59 UTC (rev 188207) +++ trunk/Source/WebKit2/ChangeLog 2015-08-10 08:27:52 UTC (rev 188208) @@ -1,3 +1,19 @@ +2015-08-10 Carlos Garcia Campos + +[GTK] Crash when the web view is destroyed while the screensaver DBUs proxy is being created +https://bugs.webkit.org/show_bug.cgi?id=147780 + +Reviewed by Sergio Villar Senin. + +We should cancel the screenSaverInhibitCancellable on +dispose. Also use adoptGRef() when creating the cancellable object +to not leak it. + +* UIProcess/API/gtk/WebKitWebViewBase.cpp: +(webkitWebViewBaseDispose): +(webkitWebViewBaseSendInhibitMessageToScreenSaver): +(webkitWebViewBaseInhibitScreenSaver): + 2015-08-09 Chris Dumez Follow-up nit fixes after r187691. Modified: trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebViewBase.cpp (188207 => 188208) --- trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebViewBase.cpp 2015-08-10 08:24:59 UTC (rev 188207) +++ trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebViewBase.cpp 2015-08-10 08:27:52 UTC (rev 188208) @@ -450,6 +450,7 @@ static void webkitWebViewBaseDispose(GObject* gobject) { WebKitWebViewBase* webView = WEBKIT_WEB_VIEW_BASE(gobject); +g_cancellable_cancel(webView->priv->screenSaverInhibitCancellable.get()); webkitWebViewBaseSetToplevelOnScreenWindow(webView, nullptr); webView->priv->pageProxy->close(); G_OBJECT_CLASS(webkit_web_view_base_parent_class)->dispose(gobject); @@ -1134,7 +1135,7 @@ ASSERT(priv->screenSaverProxy); priv->screenSaverCookie = 0; if (!priv->screenSaverInhibitCancellable) -priv->screenSaverInhibitCancellable = g_cancellable_new(); +priv->screenSaverInhibitCancellable = adoptGRef(g_cancellable_new()); g_dbus_proxy_call(priv->screenSaverProxy.get(), "Inhibit", g_variant_new("(ss)", g_get_prgname(), _("Website running in fullscreen mode")), G_DBUS_CALL_FLAGS_NONE, -1, priv->screenSaverInhibitCancellable.get(), reinterpret_cast(screenSaverInhibitedCallback), webViewBase); } @@ -1162,7 +1163,7 @@ return; } -priv->screenSaverInhibitCancellable = g_cancellable_new(); +priv->screenSaverInhibitCancellable = adoptGRef(g_cancellable_new()); g_dbus_proxy_new_for_bus(G_BUS_TYPE_SESSION, static_cast(G_DBUS_PROXY_FLAGS_DO_NOT_LOAD_PROPERTIES | G_DBUS_PROXY_FLAGS_DO_NOT_CONNECT_SIGNALS), nullptr, "org.freedesktop.ScreenSaver", "/ScreenSaver", "org.freedesktop.ScreenSaver", priv->screenSaverInhibitCancellable.get(), reinterpret_cast(screenSaverProxyCreatedCallback), webViewBase); ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [188209] trunk/Source/WebCore
Title: [188209] trunk/Source/WebCore Revision 188209 Author youenn.fab...@crf.canon.fr Date 2015-08-10 03:01:31 -0700 (Mon, 10 Aug 2015) Log Message [Streams API] ReadableStreamReader closed promise should use CachedAttribute https://bugs.webkit.org/show_bug.cgi?id=147487 Reviewed by Darin Adler. Covered by existing tests. * Modules/streams/ReadableStreamReader.idl: Made closed a CachedAttribute. * bindings/js/JSReadableStreamReaderCustom.cpp: (WebCore::JSReadableStreamReader::closed): Updated according CachedAttribute specific field. Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/Modules/streams/ReadableStreamReader.idl trunk/Source/WebCore/bindings/js/JSReadableStreamReaderCustom.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (188208 => 188209) --- trunk/Source/WebCore/ChangeLog 2015-08-10 08:27:52 UTC (rev 188208) +++ trunk/Source/WebCore/ChangeLog 2015-08-10 10:01:31 UTC (rev 188209) @@ -1,3 +1,16 @@ +2015-08-10 Youenn Fablet + +[Streams API] ReadableStreamReader closed promise should use CachedAttribute +https://bugs.webkit.org/show_bug.cgi?id=147487 + +Reviewed by Darin Adler. + +Covered by existing tests. + +* Modules/streams/ReadableStreamReader.idl: Made closed a CachedAttribute. +* bindings/js/JSReadableStreamReaderCustom.cpp: +(WebCore::JSReadableStreamReader::closed): Updated according CachedAttribute specific field. + 2015-08-09 Hunseop Jeong [EFL] Use the non-overlay scrollbar Modified: trunk/Source/WebCore/Modules/streams/ReadableStreamReader.idl (188208 => 188209) --- trunk/Source/WebCore/Modules/streams/ReadableStreamReader.idl 2015-08-10 08:27:52 UTC (rev 188208) +++ trunk/Source/WebCore/Modules/streams/ReadableStreamReader.idl 2015-08-10 10:01:31 UTC (rev 188209) @@ -37,5 +37,5 @@ Promise cancel([Default=Undefined] optional any reason); [RaisesException] void releaseLock(); -[CustomGetter] readonly attribute Promise closed; +[CustomGetter, CachedAttribute] readonly attribute Promise closed; }; Modified: trunk/Source/WebCore/bindings/js/JSReadableStreamReaderCustom.cpp (188208 => 188209) --- trunk/Source/WebCore/bindings/js/JSReadableStreamReaderCustom.cpp 2015-08-10 08:27:52 UTC (rev 188208) +++ trunk/Source/WebCore/bindings/js/JSReadableStreamReaderCustom.cpp 2015-08-10 10:01:31 UTC (rev 188209) @@ -46,13 +46,12 @@ JSValue JSReadableStreamReader::closed(ExecState* exec) const { -if (m_closedPromiseDeferred) -return m_closedPromiseDeferred->promise(); - -const_cast(this)->m_closedPromiseDeferred.set(exec->vm(), JSPromiseDeferred::create(exec, globalObject())); -impl().closed(DeferredWrapper(exec, globalObject(), m_closedPromiseDeferred.get())); - -return m_closedPromiseDeferred->promise(); +if (!m_closed) { +JSPromiseDeferred* closedPromise = JSPromiseDeferred::create(exec, globalObject()); +const_cast(this)->m_closed.set(exec->vm(), this, closedPromise->promise()); +impl().closed(DeferredWrapper(exec, globalObject(), closedPromise)); +} +return m_closed.get(); } EncodedJSValue JSC_HOST_CALL constructJSReadableStreamReader(ExecState* exec) ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [188210] trunk
Title: [188210] trunk Revision 188210 Author youenn.fab...@crf.canon.fr Date 2015-08-10 03:05:40 -0700 (Mon, 10 Aug 2015) Log Message Compile warning (-Wsign-compare) on 32-bits at WebCore/platform/FileSystem.cpp https://bugs.webkit.org/show_bug.cgi?id=146414 Reviewed by Darin Adler. Source/WebCore: No behavioral changes. * platform/FileSystem.cpp: (WebCore::MappedFileData::MappedFileData): Making use of convertSafely. * platform/posix/SharedBufferPOSIX.cpp: (WebCore::SharedBuffer::createFromReadingFile): Making use of convertSafely. Source/WTF: Added convertSafely routine based on isInBounds routine. Updated BoundChecker by adding a third boolean parameter to this template giving whether Target has greater or equal precision than Source. Removed BoundCheckElider, which is no longer necessary and had some issues. * wtf/CheckedArithmetic.h: (WTF::isInBounds): (WTF::convertSafely): Tools: * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp: (TestWebKitAPI::TEST): Improving testing of WTF::isInBounds. Modified Paths trunk/Source/WTF/ChangeLog trunk/Source/WTF/wtf/CheckedArithmetic.h trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/platform/FileSystem.cpp trunk/Source/WebCore/platform/posix/SharedBufferPOSIX.cpp trunk/Tools/ChangeLog trunk/Tools/TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp Diff Modified: trunk/Source/WTF/ChangeLog (188209 => 188210) --- trunk/Source/WTF/ChangeLog 2015-08-10 10:01:31 UTC (rev 188209) +++ trunk/Source/WTF/ChangeLog 2015-08-10 10:05:40 UTC (rev 188210) @@ -1,3 +1,18 @@ +2015-08-10 Youenn Fablet + +Compile warning (-Wsign-compare) on 32-bits at WebCore/platform/FileSystem.cpp +https://bugs.webkit.org/show_bug.cgi?id=146414 + +Reviewed by Darin Adler. + +Added convertSafely routine based on isInBounds routine. +Updated BoundChecker by adding a third boolean parameter to this template giving whether Target has greater or equal precision than Source. +Removed BoundCheckElider, which is no longer necessary and had some issues. + +* wtf/CheckedArithmetic.h: +(WTF::isInBounds): +(WTF::convertSafely): + 2015-08-07 Filip Pizlo Lightweight locks should be adaptive Modified: trunk/Source/WTF/wtf/CheckedArithmetic.h (188209 => 188210) --- trunk/Source/WTF/wtf/CheckedArithmetic.h 2015-08-10 10:01:31 UTC (rev 188209) +++ trunk/Source/WTF/wtf/CheckedArithmetic.h 2015-08-10 10:05:40 UTC (rev 188210) @@ -122,65 +122,86 @@ template struct RemoveChecked; template struct RemoveChecked>; -template ::is_signed, bool sourceSigned = std::numeric_limits::is_signed> struct BoundsChecker; -template struct BoundsChecker { +template = sizeof(Source), bool targetSigned = std::numeric_limits::is_signed, bool sourceSigned = std::numeric_limits::is_signed> struct BoundsChecker; +template struct BoundsChecker { static bool inBounds(Source value) { -// Same signedness so implicit type conversion will always increase precision -// to widest type +// Same signedness so implicit type conversion will always increase precision to widest type. return value <= std::numeric_limits::max(); } }; - -template struct BoundsChecker { +template struct BoundsChecker { static bool inBounds(Source value) { -// Same signedness so implicit type conversion will always increase precision -// to widest type +// Same signedness so implicit type conversion will always increase precision to widest type. return std::numeric_limits::min() <= value && value <= std::numeric_limits::max(); } }; -template struct BoundsChecker { +template struct BoundsChecker { static bool inBounds(Source value) { -// Target is unsigned so any value less than zero is clearly unsafe -if (value < 0) -return false; -// If our (unsigned) Target is the same or greater width we can -// convert value to type Target without losing precision -if (sizeof(Target) >= sizeof(Source)) -return static_cast(value) <= std::numeric_limits::max(); -// The signed Source type has greater precision than the target so -// max(Target) -> Source will widen. -return value <= static_cast(std::numeric_limits::max()); +// When converting value to unsigned Source, value will become a big value if value is negative. +// Casted value will become bigger than Target::max as Source is bigger than Target. +return static_cast::type>(value) <= std::numeric_limits::max(); } }; -template struct BoundsChecker { +template struct BoundsChecker { static bool inBounds(Source value) { -// Signed target with an unsigned source -if (sizeof(Target) <= sizeof(Source)) -return value <= static_cast(std::numeric_limits::max()); -// Target is Wider than Source so we're guaranteed to fit any va
[webkit-changes] [188212] trunk/Source/WebKit2
Title: [188212] trunk/Source/WebKit2 Revision 188212 Author zandober...@gmail.com Date 2015-08-10 07:12:19 -0700 (Mon, 10 Aug 2015) Log Message [CoordinatedGraphics] Fix forward declarations of CoordinatedGraphicsLayerState, ViewportAttributes https://bugs.webkit.org/show_bug.cgi?id=147823 Reviewed by Carlos Garcia Campos. * WebProcess/WebPage/CoordinatedGraphics/ThreadedCoordinatedLayerTreeHost.h: * WebProcess/WebPage/LayerTreeHost.h: Modified Paths trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/ThreadedCoordinatedLayerTreeHost.h trunk/Source/WebKit2/WebProcess/WebPage/LayerTreeHost.h Diff Modified: trunk/Source/WebKit2/ChangeLog (188211 => 188212) --- trunk/Source/WebKit2/ChangeLog 2015-08-10 12:48:53 UTC (rev 188211) +++ trunk/Source/WebKit2/ChangeLog 2015-08-10 14:12:19 UTC (rev 188212) @@ -1,3 +1,13 @@ +2015-08-10 Zan Dobersek + +[CoordinatedGraphics] Fix forward declarations of CoordinatedGraphicsLayerState, ViewportAttributes +https://bugs.webkit.org/show_bug.cgi?id=147823 + +Reviewed by Carlos Garcia Campos. + +* WebProcess/WebPage/CoordinatedGraphics/ThreadedCoordinatedLayerTreeHost.h: +* WebProcess/WebPage/LayerTreeHost.h: + 2015-08-10 Carlos Garcia Campos [GTK] Crash when the web view is destroyed while the screensaver DBUs proxy is being created Modified: trunk/Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/ThreadedCoordinatedLayerTreeHost.h (188211 => 188212) --- trunk/Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/ThreadedCoordinatedLayerTreeHost.h 2015-08-10 12:48:53 UTC (rev 188211) +++ trunk/Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/ThreadedCoordinatedLayerTreeHost.h 2015-08-10 14:12:19 UTC (rev 188212) @@ -45,13 +45,13 @@ #include namespace WebCore { -class CoordinatedGraphicsLayerState; -struct CoordinatedGraphicsState; class CoordinatedSurface; class GraphicsContext; class GraphicsLayer; class GraphicsLayerFactory; class GraphicsLayerFactory; +struct CoordinatedGraphicsLayerState; +struct CoordinatedGraphicsState; } namespace WebKit { Modified: trunk/Source/WebKit2/WebProcess/WebPage/LayerTreeHost.h (188211 => 188212) --- trunk/Source/WebKit2/WebProcess/WebPage/LayerTreeHost.h 2015-08-10 12:48:53 UTC (rev 188211) +++ trunk/Source/WebKit2/WebProcess/WebPage/LayerTreeHost.h 2015-08-10 14:12:19 UTC (rev 188212) @@ -44,7 +44,7 @@ class GraphicsLayer; class GraphicsLayerFactory; #if USE(COORDINATED_GRAPHICS_THREADED) -class ViewportAttributes; +struct ViewportAttributes; #endif } ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [188213] trunk
Title: [188213] trunk Revision 188213 Author jcr...@apple.com Date 2015-08-10 09:01:19 -0700 (Mon, 10 Aug 2015) Log Message AX: Address follow-up comments in bug 145684 https://bugs.webkit.org/show_bug.cgi?id=147817 Reviewed by Dean Jackson. Minor cleanup and style updates requested by Dean. Source/WebCore: Updated Existing Test Expectations. * Modules/mediacontrols/mediaControlsApple.css: (video::-webkit-media-show-controls): * Modules/mediacontrols/mediaControlsiOS.css: (video::-webkit-media-show-controls): LayoutTests: * http/tests/contentextensions/text-track-blocked-expected.txt: * media/video-controls-show-on-kb-or-ax-event.html: * platform/mac/media/track/track-cue-rendering-horizontal-expected.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/http/tests/contentextensions/text-track-blocked-expected.txt trunk/LayoutTests/media/video-controls-show-on-kb-or-ax-event.html trunk/LayoutTests/platform/mac/media/track/track-cue-rendering-horizontal-expected.txt trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/Modules/mediacontrols/mediaControlsApple.css trunk/Source/WebCore/Modules/mediacontrols/mediaControlsiOS.css Diff Modified: trunk/LayoutTests/ChangeLog (188212 => 188213) --- trunk/LayoutTests/ChangeLog 2015-08-10 14:12:19 UTC (rev 188212) +++ trunk/LayoutTests/ChangeLog 2015-08-10 16:01:19 UTC (rev 188213) @@ -1,3 +1,16 @@ +2015-08-10 James Craig + +AX: Address follow-up comments in bug 145684 +https://bugs.webkit.org/show_bug.cgi?id=147817 + +Reviewed by Dean Jackson. + +Minor cleanup and style updates requested by Dean. + +* http/tests/contentextensions/text-track-blocked-expected.txt: +* media/video-controls-show-on-kb-or-ax-event.html: +* platform/mac/media/track/track-cue-rendering-horizontal-expected.txt: + 2015-08-07 Antti Koivisto Expand network cache tests to cover memory cache behavior Modified: trunk/LayoutTests/http/tests/contentextensions/text-track-blocked-expected.txt (188212 => 188213) --- trunk/LayoutTests/http/tests/contentextensions/text-track-blocked-expected.txt 2015-08-10 14:12:19 UTC (rev 188212) +++ trunk/LayoutTests/http/tests/contentextensions/text-track-blocked-expected.txt 2015-08-10 16:01:19 UTC (rev 188213) @@ -15,4 +15,4 @@ layer at (8,26) size 320x240 RenderFlexibleBox {DIV} at (0,0) size 320x240 layer at (8,256) size 320x10 - RenderButton {BUTTON} at (0,230) size 320x10 [bgcolor=#C0C0C0] [border: (2px outset #C0C0C0)] + RenderButton {BUTTON} at (0,230) size 320x10 Modified: trunk/LayoutTests/media/video-controls-show-on-kb-or-ax-event.html (188212 => 188213) --- trunk/LayoutTests/media/video-controls-show-on-kb-or-ax-event.html 2015-08-10 14:12:19 UTC (rev 188212) +++ trunk/LayoutTests/media/video-controls-show-on-kb-or-ax-event.html 2015-08-10 16:01:19 UTC (rev 188213) @@ -27,9 +27,8 @@ if (button) { button.focus(); eventSender.keyDown(' '); // Use keyboard to press the selected button. -} else { +} else result.innerHTML += 'FAIL: "Show Controls" button is not available.'; -} // Verifies the toolbar is back in the DOM. var controls = root.firstChild.querySelector('[role="toolbar"]'); Modified: trunk/LayoutTests/platform/mac/media/track/track-cue-rendering-horizontal-expected.txt (188212 => 188213) --- trunk/LayoutTests/platform/mac/media/track/track-cue-rendering-horizontal-expected.txt 2015-08-10 14:12:19 UTC (rev 188212) +++ trunk/LayoutTests/platform/mac/media/track/track-cue-rendering-horizontal-expected.txt 2015-08-10 16:01:19 UTC (rev 188213) @@ -61,4 +61,4 @@ RenderText {#text} at (0,0) size 275x14 text run at (0,0) width 275: "Cue 6: should be on top of bottom positioned cue 5." layer at (8,238) size 320x10 - RenderButton {BUTTON} at (0,230) size 320x10 [bgcolor=#C0C0C0] [border: (2px outset #C0C0C0)] + RenderButton {BUTTON} at (0,230) size 320x10 Modified: trunk/Source/WebCore/ChangeLog (188212 => 188213) --- trunk/Source/WebCore/ChangeLog 2015-08-10 14:12:19 UTC (rev 188212) +++ trunk/Source/WebCore/ChangeLog 2015-08-10 16:01:19 UTC (rev 188213) @@ -1,3 +1,18 @@ +2015-08-10 James Craig + +AX: Address follow-up comments in bug 145684 +https://bugs.webkit.org/show_bug.cgi?id=147817 + +Reviewed by Dean Jackson. + +Minor cleanup and style updates requested by Dean. +Updated Existing Test Expectations. + +* Modules/mediacontrols/mediaControlsApple.css: +(video::-webkit-media-show-controls): +* Modules/mediacontrols/mediaControlsiOS.css: +(video::-webkit-media-show-controls): + 2015-08-07 Antti Koivisto Expand network cache tests to cover memory cache behavior Modified: trunk/Source/WebCore/Modules/mediacontrols/mediaControlsApple.css (188212 => 188213) --- trunk/Source/WebCore/Modules/med
[webkit-changes] [188214] trunk/LayoutTests
Title: [188214] trunk/LayoutTests Revision 188214 Author an...@apple.com Date 2015-08-10 09:09:27 -0700 (Mon, 10 Aug 2015) Log Message http/tests/cache/disk-cache/disk-cache-validation.html has too many subtests https://bugs.webkit.org/show_bug.cgi?id=147827 Reviewed by Chris Dumez. Looks like it occasionally times out because a bot is running slowly and 243 subtests take >30s. * http/tests/cache/disk-cache/disk-cache-validation-expected.txt: * http/tests/cache/disk-cache/disk-cache-validation.html: Split Vary header cases to a separate test. * http/tests/cache/disk-cache/disk-cache-vary-expected.txt: * http/tests/cache/disk-cache/disk-cache-vary.html: Reduce test matrix size by no testing Expires header here. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/http/tests/cache/disk-cache/disk-cache-validation-expected.txt trunk/LayoutTests/http/tests/cache/disk-cache/disk-cache-validation.html Added Paths trunk/LayoutTests/http/tests/cache/disk-cache/disk-cache-vary-expected.txt trunk/LayoutTests/http/tests/cache/disk-cache/disk-cache-vary.html Diff Modified: trunk/LayoutTests/ChangeLog (188213 => 188214) --- trunk/LayoutTests/ChangeLog 2015-08-10 16:01:19 UTC (rev 188213) +++ trunk/LayoutTests/ChangeLog 2015-08-10 16:09:27 UTC (rev 188214) @@ -1,3 +1,22 @@ +2015-08-10 Antti Koivisto + +http/tests/cache/disk-cache/disk-cache-validation.html has too many subtests +https://bugs.webkit.org/show_bug.cgi?id=147827 + +Reviewed by Chris Dumez. + +Looks like it occasionally times out because a bot is running slowly and 243 subtests take >30s. + +* http/tests/cache/disk-cache/disk-cache-validation-expected.txt: +* http/tests/cache/disk-cache/disk-cache-validation.html: + +Split Vary header cases to a separate test. + +* http/tests/cache/disk-cache/disk-cache-vary-expected.txt: +* http/tests/cache/disk-cache/disk-cache-vary.html: + +Reduce test matrix size by no testing Expires header here. + 2015-08-10 James Craig AX: Address follow-up comments in bug 145684 Modified: trunk/LayoutTests/http/tests/cache/disk-cache/disk-cache-validation-expected.txt (188213 => 188214) --- trunk/LayoutTests/http/tests/cache/disk-cache/disk-cache-validation-expected.txt 2015-08-10 16:01:19 UTC (rev 188213) +++ trunk/LayoutTests/http/tests/cache/disk-cache/disk-cache-validation-expected.txt 2015-08-10 16:09:27 UTC (rev 188214) @@ -3,7 +3,7 @@ On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE". -running 243 tests +running 81 tests Testing loads from disk cache response headers: undefined @@ -249,654 +249,6 @@ response headers: {"Cache-control":"max-age=100, no-cache","Expires":"now(100)","ETag":"nomatch"} response source: Network -response headers: {"Vary":"Accept-Language"} -request headers: {"Accept-Language":"en"} -response source: Network - -response headers: {"Cache-control":"max-age=0","Vary":"Accept-Language"} -request headers: {"Accept-Language":"en"} -response source: Network - -response headers: {"Cache-control":"max-age=100","Vary":"Accept-Language"} -request headers: {"Accept-Language":"en"} -response source: Disk cache - -response headers: {"Expires":"now(0)","Vary":"Accept-Language"} -request headers: {"Accept-Language":"en"} -response source: Network - -response headers: {"Cache-control":"max-age=0","Expires":"now(0)","Vary":"Accept-Language"} -request headers: {"Accept-Language":"en"} -response source: Network - -response headers: {"Cache-control":"max-age=100","Expires":"now(0)","Vary":"Accept-Language"} -request headers: {"Accept-Language":"en"} -response source: Disk cache - -response headers: {"Expires":"now(100)","Vary":"Accept-Language"} -request headers: {"Accept-Language":"en"} -response source: Disk cache - -response headers: {"Cache-control":"max-age=0","Expires":"now(100)","Vary":"Accept-Language"} -request headers: {"Accept-Language":"en"} -response source: Network - -response headers: {"Cache-control":"max-age=100","Expires":"now(100)","Vary":"Accept-Language"} -request headers: {"Accept-Language":"en"} -response source: Disk cache - -response headers: {"Cache-control":"no-store","Vary":"Accept-Language"} -request headers: {"Accept-Language":"en"} -response source: Network - -response headers: {"Cache-control":"max-age=0, no-store","Vary":"Accept-Language"} -request headers: {"Accept-Language":"en"} -response source: Network - -response headers: {"Cache-control":"max-age=100, no-store","Vary":"Accept-Language"} -request headers: {"Accept-Language":"en"} -response source: Network - -response headers: {"Expires":"now(0)","Cache-control":"no-store","Vary":"Accept-Language"} -request headers: {"Accept-Language":"en"} -response source: Network - -response headers: {"Cache-control":"max-age=0, no-store","Expires":"now(0)","Vary":"Accept-Language"} -request headers: {"Accept-Language":"en"} -response source: Network - -re
[webkit-changes] [188216] trunk/LayoutTests
Title: [188216] trunk/LayoutTests Revision 188216 Author an...@apple.com Date 2015-08-10 11:06:12 -0700 (Mon, 10 Aug 2015) Log Message http/tests/cache/disk-cache/disk-cache-validation.html has too many subtests https://bugs.webkit.org/show_bug.cgi?id=147827 Rubber-stamped by Alexey Proskuryakov. Also split the no-body variant of this. * http/tests/cache/disk-cache/disk-cache-validation-no-body-expected.txt: * http/tests/cache/disk-cache/disk-cache-validation-no-body.html: * http/tests/cache/disk-cache/disk-cache-vary-no-body-expected.txt: Added. * http/tests/cache/disk-cache/disk-cache-vary-no-body.html: Added. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/http/tests/cache/disk-cache/disk-cache-validation-no-body-expected.txt trunk/LayoutTests/http/tests/cache/disk-cache/disk-cache-validation-no-body.html Added Paths trunk/LayoutTests/http/tests/cache/disk-cache/disk-cache-vary-no-body-expected.txt trunk/LayoutTests/http/tests/cache/disk-cache/disk-cache-vary-no-body.html Diff Modified: trunk/LayoutTests/ChangeLog (188215 => 188216) --- trunk/LayoutTests/ChangeLog 2015-08-10 17:56:52 UTC (rev 188215) +++ trunk/LayoutTests/ChangeLog 2015-08-10 18:06:12 UTC (rev 188216) @@ -3,6 +3,20 @@ http/tests/cache/disk-cache/disk-cache-validation.html has too many subtests https://bugs.webkit.org/show_bug.cgi?id=147827 +Rubber-stamped by Alexey Proskuryakov. + +Also split the no-body variant of this. + +* http/tests/cache/disk-cache/disk-cache-validation-no-body-expected.txt: +* http/tests/cache/disk-cache/disk-cache-validation-no-body.html: +* http/tests/cache/disk-cache/disk-cache-vary-no-body-expected.txt: Added. +* http/tests/cache/disk-cache/disk-cache-vary-no-body.html: Added. + +2015-08-10 Antti Koivisto + +http/tests/cache/disk-cache/disk-cache-validation.html has too many subtests +https://bugs.webkit.org/show_bug.cgi?id=147827 + Reviewed by Chris Dumez. Looks like it occasionally times out because a bot is running slowly and 243 subtests take >30s. Modified: trunk/LayoutTests/http/tests/cache/disk-cache/disk-cache-validation-no-body-expected.txt (188215 => 188216) --- trunk/LayoutTests/http/tests/cache/disk-cache/disk-cache-validation-no-body-expected.txt 2015-08-10 17:56:52 UTC (rev 188215) +++ trunk/LayoutTests/http/tests/cache/disk-cache/disk-cache-validation-no-body-expected.txt 2015-08-10 18:06:12 UTC (rev 188216) @@ -3,7 +3,7 @@ On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE". -running 243 tests +running 81 tests Testing loads from disk cache response headers: undefined @@ -249,654 +249,6 @@ response headers: {"Cache-control":"max-age=100, no-cache","Expires":"now(100)","ETag":"nomatch"} response source: Network -response headers: {"Vary":"Accept-Language"} -request headers: {"Accept-Language":"en"} -response source: Network - -response headers: {"Cache-control":"max-age=0","Vary":"Accept-Language"} -request headers: {"Accept-Language":"en"} -response source: Network - -response headers: {"Cache-control":"max-age=100","Vary":"Accept-Language"} -request headers: {"Accept-Language":"en"} -response source: Disk cache - -response headers: {"Expires":"now(0)","Vary":"Accept-Language"} -request headers: {"Accept-Language":"en"} -response source: Network - -response headers: {"Cache-control":"max-age=0","Expires":"now(0)","Vary":"Accept-Language"} -request headers: {"Accept-Language":"en"} -response source: Network - -response headers: {"Cache-control":"max-age=100","Expires":"now(0)","Vary":"Accept-Language"} -request headers: {"Accept-Language":"en"} -response source: Disk cache - -response headers: {"Expires":"now(100)","Vary":"Accept-Language"} -request headers: {"Accept-Language":"en"} -response source: Disk cache - -response headers: {"Cache-control":"max-age=0","Expires":"now(100)","Vary":"Accept-Language"} -request headers: {"Accept-Language":"en"} -response source: Network - -response headers: {"Cache-control":"max-age=100","Expires":"now(100)","Vary":"Accept-Language"} -request headers: {"Accept-Language":"en"} -response source: Disk cache - -response headers: {"Cache-control":"no-store","Vary":"Accept-Language"} -request headers: {"Accept-Language":"en"} -response source: Network - -response headers: {"Cache-control":"max-age=0, no-store","Vary":"Accept-Language"} -request headers: {"Accept-Language":"en"} -response source: Network - -response headers: {"Cache-control":"max-age=100, no-store","Vary":"Accept-Language"} -request headers: {"Accept-Language":"en"} -response source: Network - -response headers: {"Expires":"now(0)","Cache-control":"no-store","Vary":"Accept-Language"} -request headers: {"Accept-Language":"en"} -response source: Network - -response headers: {"Cache-control":"max-age=0, no-store","Expires":"now(0)","Vary":"Accept-Language"} -request headers: {"Accept-Language":"en"}
[webkit-changes] [188217] trunk/Source/WebKit/mac
Title: [188217] trunk/Source/WebKit/mac Revision 188217 Author cdu...@apple.com Date 2015-08-10 11:57:47 -0700 (Mon, 10 Aug 2015) Log Message Align WebKit1's PageCache size with WebKit2's https://bugs.webkit.org/show_bug.cgi?id=147831 Reviewed by Sam Weinig. Align WebKit1's PageCache size with WebKit2's for consistency. Also, we have data showing that keeping more than 3 pages in the PageCache is not really useful. * WebView/WebView.mm: (+[WebView _setCacheModel:]): Modified Paths trunk/Source/WebKit/mac/ChangeLog trunk/Source/WebKit/mac/WebView/WebView.mm Diff Modified: trunk/Source/WebKit/mac/ChangeLog (188216 => 188217) --- trunk/Source/WebKit/mac/ChangeLog 2015-08-10 18:06:12 UTC (rev 188216) +++ trunk/Source/WebKit/mac/ChangeLog 2015-08-10 18:57:47 UTC (rev 188217) @@ -1,3 +1,17 @@ +2015-08-10 Chris Dumez + +Align WebKit1's PageCache size with WebKit2's +https://bugs.webkit.org/show_bug.cgi?id=147831 + +Reviewed by Sam Weinig. + +Align WebKit1's PageCache size with WebKit2's for consistency. Also, we +have data showing that keeping more than 3 pages in the PageCache is +not really useful. + +* WebView/WebView.mm: +(+[WebView _setCacheModel:]): + 2015-08-06 Anders Carlsson Crashes when calling swizzled setNeedsDisplayInRect: on heartbeat thread Modified: trunk/Source/WebKit/mac/WebView/WebView.mm (188216 => 188217) --- trunk/Source/WebKit/mac/WebView/WebView.mm 2015-08-10 18:06:12 UTC (rev 188216) +++ trunk/Source/WebKit/mac/WebView/WebView.mm 2015-08-10 18:57:47 UTC (rev 188217) @@ -7838,26 +7838,16 @@ } case WebCacheModelPrimaryWebBrowser: { // Page cache capacity (in pages) -// (Research indicates that value / page drops substantially after 3 pages.) -if (memSize >= 2048) -pageCacheSize = 5; -else if (memSize >= 1024) -pageCacheSize = 4; -else if (memSize >= 512) +// Research indicates that value / page drops substantially after 3 pages. +if (memSize >= 1024) pageCacheSize = 3; -else if (memSize >= 256) +else if (memSize >= 512) pageCacheSize = 2; -else +else if (memSize >= 256) pageCacheSize = 1; +else +pageCacheSize = 0; -#if PLATFORM(IOS) -// Cache page less aggressively in iOS to reduce the chance of being jettisoned. -// FIXME (): Avoiding jettisoning should not have to require reducing the page cache capacity. -// Reducing the capacity by 1 reduces overall back-forward performance. -if (pageCacheSize > 0) -pageCacheSize -= 1; -#endif - // Object cache capacities (in bytes) // (Testing indicates that value / MB depends heavily on content and // browsing pattern. Even growth above 128MB can have substantial ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [188218] trunk/Source/WebKit2
Title: [188218] trunk/Source/WebKit2 Revision 188218 Author mra...@apple.com Date 2015-08-10 12:18:50 -0700 (Mon, 10 Aug 2015) Log Message Media Session: generalize isFocusedContentMediaElementPlaying so it works with other playback attributes https://bugs.webkit.org/show_bug.cgi?id=147797 Reviewed by Simon Fraser. * UIProcess/API/C/WKMediaSessionFocusManager.cpp: (WKMediaSessionFocusManagerValueForPlaybackAttribute): (WKMediaSessionFocusManagerIsFocusedContentMediaElementPlaying): Deleted. * UIProcess/API/C/WKMediaSessionFocusManager.h: * UIProcess/WebMediaSessionFocusManager.cpp: (WebKit::WebMediaSessionFocusManager::valueForPlaybackAttribute): (WebKit::WebMediaSessionFocusManager::mediaControlIsEnabledDidChange): (WebKit::WebMediaSessionFocusManager::isFocusedContentMediaElementPlaying): Deleted. (WebKit::WebMediaSessionFocusManager::mediaElementIsPlayingDidChange): Deleted. * UIProcess/WebMediaSessionFocusManager.h: Modified Paths trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/UIProcess/API/C/WKMediaSessionFocusManager.cpp trunk/Source/WebKit2/UIProcess/API/C/WKMediaSessionFocusManager.h trunk/Source/WebKit2/UIProcess/WebMediaSessionFocusManager.cpp trunk/Source/WebKit2/UIProcess/WebMediaSessionFocusManager.h Diff Modified: trunk/Source/WebKit2/ChangeLog (188217 => 188218) --- trunk/Source/WebKit2/ChangeLog 2015-08-10 18:57:47 UTC (rev 188217) +++ trunk/Source/WebKit2/ChangeLog 2015-08-10 19:18:50 UTC (rev 188218) @@ -1,3 +1,21 @@ +2015-08-07 Matt Rajca + +Media Session: generalize isFocusedContentMediaElementPlaying so it works with other playback attributes +https://bugs.webkit.org/show_bug.cgi?id=147797 + +Reviewed by Simon Fraser. + +* UIProcess/API/C/WKMediaSessionFocusManager.cpp: +(WKMediaSessionFocusManagerValueForPlaybackAttribute): +(WKMediaSessionFocusManagerIsFocusedContentMediaElementPlaying): Deleted. +* UIProcess/API/C/WKMediaSessionFocusManager.h: +* UIProcess/WebMediaSessionFocusManager.cpp: +(WebKit::WebMediaSessionFocusManager::valueForPlaybackAttribute): +(WebKit::WebMediaSessionFocusManager::mediaControlIsEnabledDidChange): +(WebKit::WebMediaSessionFocusManager::isFocusedContentMediaElementPlaying): Deleted. +(WebKit::WebMediaSessionFocusManager::mediaElementIsPlayingDidChange): Deleted. +* UIProcess/WebMediaSessionFocusManager.h: + 2015-08-10 Zan Dobersek [CoordinatedGraphics] Fix forward declarations of CoordinatedGraphicsLayerState, ViewportAttributes Modified: trunk/Source/WebKit2/UIProcess/API/C/WKMediaSessionFocusManager.cpp (188217 => 188218) --- trunk/Source/WebKit2/UIProcess/API/C/WKMediaSessionFocusManager.cpp 2015-08-10 18:57:47 UTC (rev 188217) +++ trunk/Source/WebKit2/UIProcess/API/C/WKMediaSessionFocusManager.cpp 2015-08-10 19:18:50 UTC (rev 188218) @@ -50,12 +50,13 @@ #endif } -bool WKMediaSessionFocusManagerIsFocusedContentMediaElementPlaying(WKMediaSessionFocusManagerRef manager) +bool WKMediaSessionFocusManagerValueForPlaybackAttribute(WKMediaSessionFocusManagerRef manager, WKMediaSessionFocusManagerPlaybackAttribute attribute) { #if ENABLE(MEDIA_SESSION) -return toImpl(manager)->isFocusedContentMediaElementPlaying(); +return toImpl(manager)->valueForPlaybackAttribute(attribute); #else UNUSED_PARAM(manager); +UNUSED_PARAM(attribute); return false; #endif } Modified: trunk/Source/WebKit2/UIProcess/API/C/WKMediaSessionFocusManager.h (188217 => 188218) --- trunk/Source/WebKit2/UIProcess/API/C/WKMediaSessionFocusManager.h 2015-08-10 18:57:47 UTC (rev 188217) +++ trunk/Source/WebKit2/UIProcess/API/C/WKMediaSessionFocusManager.h 2015-08-10 19:18:50 UTC (rev 188218) @@ -36,10 +36,12 @@ extern "C" { #endif -enum { -IsPlaying = 1 << 0 +enum WKMediaSessionFocusManagerPlaybackAttribute { +IsPlaying = 1 << 0, +IsPreviousTrackControlEnabled = 1 << 1, +IsNextTrackControlEnabled = 1 << 2, }; -typedef uint32_t WKMediaSessionFocusManagerPlaybackAttribute; +typedef uint32_t WKMediaSessionFocusManagerPlaybackAttributes; // Media Session Focus Manager Client typedef void (*WKMediaSessionFocusManagerDidChangePlaybackAttribute)(WKMediaSessionFocusManagerRef manager, WKMediaSessionFocusManagerPlaybackAttribute playbackAttribute, bool value, const void *clientInfo); @@ -60,7 +62,7 @@ WK_EXPORT void WKMediaSessionFocusManagerSetClient(WKMediaSessionFocusManagerRef manager, const WKMediaSessionFocusManagerClientBase* client); -WK_EXPORT bool WKMediaSessionFocusManagerIsFocusedContentMediaElementPlaying(WKMediaSessionFocusManagerRef manager); +WK_EXPORT bool WKMediaSessionFocusManagerValueForPlaybackAttribute(WKMediaSessionFocusManagerRef, WKMediaSessionFocusManagerPlaybackAttribute); #ifdef __cplusplus } Modified: trunk/Source/WebKit2/UIProcess/WebMediaSessionFocusManager.cpp (188217 => 188218) --- trunk/Source/WebKit2/UIProcess/WebMediaSessionFocus
[webkit-changes] [188219] trunk/Source/JavaScriptCore
Title: [188219] trunk/Source/_javascript_Core Revision 188219 Author gga...@apple.com Date 2015-08-10 13:24:35 -0700 (Mon, 10 Aug 2015) Log Message Let's rename FunctionBodyNode https://bugs.webkit.org/show_bug.cgi?id=147292 Reviewed by Mark Lam & Saam Barati. FunctionBodyNode => FunctionMetadataNode Make FunctionMetadataNode inherit from Node instead of StatementNode because a FunctionMetadataNode can appear in _expression_ context and does not have a next statement. (I decided to continue allocating FunctionMetadataNode in the AST arena, and to retain "Node" in its name, because it really is a parsing construct, and we transform its data before consuming it elsewhere. There is still room for a future patch to distill and simplify the metadata we track about functions between FunDeclNode/FuncExprNode, FunctionMetadataNode, and UnlinkedFunctionExecutable. But this is a start.) * builtins/BuiltinExecutables.cpp: (JSC::BuiltinExecutables::createExecutableInternal): * bytecode/UnlinkedCodeBlock.cpp: (JSC::generateFunctionCodeBlock): (JSC::UnlinkedFunctionExecutable::UnlinkedFunctionExecutable): * bytecode/UnlinkedCodeBlock.h: * bytecompiler/BytecodeGenerator.cpp: (JSC::BytecodeGenerator::generate): (JSC::BytecodeGenerator::BytecodeGenerator): (JSC::BytecodeGenerator::emitNewArray): (JSC::BytecodeGenerator::emitNewFunction): (JSC::BytecodeGenerator::emitNewFunctionExpression): * bytecompiler/BytecodeGenerator.h: (JSC::BytecodeGenerator::makeFunction): * bytecompiler/NodesCodegen.cpp: (JSC::EvalNode::emitBytecode): (JSC::FunctionNode::emitBytecode): (JSC::FunctionBodyNode::emitBytecode): Deleted. * parser/ASTBuilder.h: (JSC::ASTBuilder::createFunctionExpr): (JSC::ASTBuilder::createFunctionBody): * parser/NodeConstructors.h: (JSC::FunctionParameters::FunctionParameters): (JSC::FuncExprNode::FuncExprNode): (JSC::FuncDeclNode::FuncDeclNode): * parser/Nodes.cpp: (JSC::EvalNode::EvalNode): (JSC::FunctionMetadataNode::FunctionMetadataNode): (JSC::FunctionMetadataNode::finishParsing): (JSC::FunctionMetadataNode::setEndPosition): (JSC::FunctionBodyNode::FunctionBodyNode): Deleted. (JSC::FunctionBodyNode::finishParsing): Deleted. (JSC::FunctionBodyNode::setEndPosition): Deleted. * parser/Nodes.h: (JSC::FuncExprNode::body): (JSC::FuncDeclNode::body): * parser/Parser.h: (JSC::Parser::isFunctionMetadataNode): (JSC::Parser::next): (JSC::Parser::parse): (JSC::Parser::isFunctionBodyNode): Deleted. * runtime/CodeCache.cpp: (JSC::CodeCache::getFunctionExecutableFromGlobalCode): * runtime/CodeCache.h: Modified Paths trunk/Source/_javascript_Core/ChangeLog trunk/Source/_javascript_Core/builtins/BuiltinExecutables.cpp trunk/Source/_javascript_Core/bytecode/UnlinkedCodeBlock.cpp trunk/Source/_javascript_Core/bytecode/UnlinkedCodeBlock.h trunk/Source/_javascript_Core/bytecompiler/BytecodeGenerator.cpp trunk/Source/_javascript_Core/bytecompiler/BytecodeGenerator.h trunk/Source/_javascript_Core/bytecompiler/NodesCodegen.cpp trunk/Source/_javascript_Core/parser/ASTBuilder.h trunk/Source/_javascript_Core/parser/NodeConstructors.h trunk/Source/_javascript_Core/parser/Nodes.cpp trunk/Source/_javascript_Core/parser/Nodes.h trunk/Source/_javascript_Core/parser/Parser.cpp trunk/Source/_javascript_Core/parser/Parser.h trunk/Source/_javascript_Core/parser/SyntaxChecker.h trunk/Source/_javascript_Core/runtime/CodeCache.cpp trunk/Source/_javascript_Core/runtime/CodeCache.h Diff Modified: trunk/Source/_javascript_Core/ChangeLog (188218 => 188219) --- trunk/Source/_javascript_Core/ChangeLog 2015-08-10 19:18:50 UTC (rev 188218) +++ trunk/Source/_javascript_Core/ChangeLog 2015-08-10 20:24:35 UTC (rev 188219) @@ -1,3 +1,69 @@ +2015-08-07 Geoffrey Garen + +Let's rename FunctionBodyNode +https://bugs.webkit.org/show_bug.cgi?id=147292 + +Reviewed by Mark Lam & Saam Barati. + +FunctionBodyNode => FunctionMetadataNode + +Make FunctionMetadataNode inherit from Node instead of StatementNode +because a FunctionMetadataNode can appear in _expression_ context and does +not have a next statement. + +(I decided to continue allocating FunctionMetadataNode in the AST arena, +and to retain "Node" in its name, because it really is a parsing +construct, and we transform its data before consuming it elsewhere. + +There is still room for a future patch to distill and simplify the +metadata we track about functions between FunDeclNode/FuncExprNode, +FunctionMetadataNode, and UnlinkedFunctionExecutable. But this is a start.) + +* builtins/BuiltinExecutables.cpp: +(JSC::BuiltinExecutables::createExecutableInternal): +* bytecode/UnlinkedCodeBlock.cpp: +(JSC::generateFunctionCodeBlock): +(JSC::UnlinkedFunctionExecutable::UnlinkedFunctionExecutable): +* bytecode/UnlinkedCodeBlock.h: +* bytecompiler/BytecodeGenerator.cpp: +(JSC::BytecodeGenerator::generate): +(JSC::BytecodeGen
[webkit-changes] [188220] branches/safari-601.1-branch
Title: [188220] branches/safari-601.1-branch Revision 188220 Author dburk...@apple.com Date 2015-08-10 13:32:06 -0700 (Mon, 10 Aug 2015) Log Message Merge r188190. rdar://problem/22191482 Modified Paths branches/safari-601.1-branch/LayoutTests/ChangeLog branches/safari-601.1-branch/Source/WebCore/ChangeLog branches/safari-601.1-branch/Source/WebCore/rendering/RenderBox.cpp branches/safari-601.1-branch/Source/WebCore/rendering/RenderLayerBacking.cpp Removed Paths branches/safari-601.1-branch/LayoutTests/compositing/backgrounds/background-image-with-negative-zindex-expected.html branches/safari-601.1-branch/LayoutTests/compositing/backgrounds/background-image-with-negative-zindex.html Diff Modified: branches/safari-601.1-branch/LayoutTests/ChangeLog (188219 => 188220) --- branches/safari-601.1-branch/LayoutTests/ChangeLog 2015-08-10 20:24:35 UTC (rev 188219) +++ branches/safari-601.1-branch/LayoutTests/ChangeLog 2015-08-10 20:32:06 UTC (rev 188220) @@ -1,3 +1,21 @@ +2015-08-10 Dana Burkart + +Merge r188190. rdar://problem/22191482 + +2015-08-08 Commit Queue + +Unreviewed, rolling out r179871. +https://bugs.webkit.org/show_bug.cgi?id=147810 + +Breaks product images on http://www.apple.com/shop/buy- +mac/macbook (Requested by smfr on #webkit). + +Reverted changeset: + +"Render: properly update body's background image" +https://bugs.webkit.org/show_bug.cgi?id=140183 +http://trac.webkit.org/changeset/179871 + 2015-08-07 Alexey Proskuryakov Correct expectations for platform/mac/fast/scrolling/scroll-div-with-nested-nonscrollable-iframe.html. Deleted: branches/safari-601.1-branch/LayoutTests/compositing/backgrounds/background-image-with-negative-zindex-expected.html (188219 => 188220) --- branches/safari-601.1-branch/LayoutTests/compositing/backgrounds/background-image-with-negative-zindex-expected.html 2015-08-10 20:24:35 UTC (rev 188219) +++ branches/safari-601.1-branch/LayoutTests/compositing/backgrounds/background-image-with-negative-zindex-expected.html 2015-08-10 20:32:06 UTC (rev 188220) @@ -1,24 +0,0 @@ - - - - - -body { -width: 1024px; -height: 720px; -left: 0px; -top: 0px; -margin: 0px; -position: absolute; -background-image: url(../resources/apple.jpg); -} - - - - - - - - - - Deleted: branches/safari-601.1-branch/LayoutTests/compositing/backgrounds/background-image-with-negative-zindex.html (188219 => 188220) --- branches/safari-601.1-branch/LayoutTests/compositing/backgrounds/background-image-with-negative-zindex.html 2015-08-10 20:24:35 UTC (rev 188219) +++ branches/safari-601.1-branch/LayoutTests/compositing/backgrounds/background-image-with-negative-zindex.html 2015-08-10 20:32:06 UTC (rev 188220) @@ -1,49 +0,0 @@ - - - - - -function onLoad() { -document.body.style.background = "" - -var div = document.getElementById("div"); -div.style.zIndex = "-1"; - -var trans = document.createElement("div"); -trans.style.backgroundColor = "blue"; -trans.style.width = "360px"; -trans.style.height = "150px"; -trans.style.position = "absolute"; -trans.style.top = "100px"; -trans.style.left = "100px"; -trans.style.webkitTransform = "translateZ(0)"; - -div.appendChild(trans); - -if (window.testRunner) -testRunner.notifyDone(); -} - -if (window.testRunner) -testRunner.waitUntilDone(); - - - - -body { -width: 1024px; -height: 720px; -left: 0px; -top: 0px; -margin: 0px; -position: absolute; -z-index: -1; -} - - - - - - - - Modified: branches/safari-601.1-branch/Source/WebCore/ChangeLog (188219 => 188220) --- branches/safari-601.1-branch/Source/WebCore/ChangeLog 2015-08-10 20:24:35 UTC (rev 188219) +++ branches/safari-601.1-branch/Source/WebCore/ChangeLog 2015-08-10 20:32:06 UTC (rev 188220) @@ -1,3 +1,21 @@ +2015-08-10 Dana Burkart + +Merge r188190. rdar://problem/22191482 + +2015-08-08 Commit Queue + +Unreviewed, rolling out r179871. +https://bugs.webkit.org/show_bug.cgi?id=147810 + +Breaks product images on http://www.apple.com/shop/buy- +mac/macbook (Requested by smfr on #webkit). + +Reverted changeset: + +"Render: properly update body's background image" +https://bugs.webkit.org/show_bug.cgi?id=140183 +http://trac.webkit.org/changeset/179871 + 2015-08-06 Dana Burkart Merge r187962. rdar://problem/21827815 Modified: branches/safari-601.1-branch/Source/WebCore/rendering/RenderBox.cpp (188219 => 188220) --- branches/safari-601.1-branch/Source/WebCore/rendering/RenderBox.cpp 2015-08-10 20:24:35 UTC (rev 188219) +++ branches/safari-601.1-branch/Source/WebCore/rendering/RenderBox.cpp 2015-08-10 20:32:06 UTC (rev 188220) @@ -53,7 +53,6 @@ #include "RenderInline.h" #include "RenderIterator.h" #include "RenderLayer.h"
[webkit-changes] [188221] trunk/Source/WebInspectorUI
Title: [188221] trunk/Source/WebInspectorUI Revision 188221 Author commit-qu...@webkit.org Date 2015-08-10 13:33:26 -0700 (Mon, 10 Aug 2015) Log Message Web Inspector: TDZ in ProbeSetDataGrid construction https://bugs.webkit.org/show_bug.cgi?id=147834 Patch by Joseph Pecoraro on 2015-08-10 Reviewed by Timothy Hatcher. * UserInterface/Views/ProbeSetDataGrid.js: (WebInspector.ProbeSetDataGrid): Do not use "this" before calling super. Modified Paths trunk/Source/WebInspectorUI/ChangeLog trunk/Source/WebInspectorUI/UserInterface/Views/ProbeSetDataGrid.js Diff Modified: trunk/Source/WebInspectorUI/ChangeLog (188220 => 188221) --- trunk/Source/WebInspectorUI/ChangeLog 2015-08-10 20:32:06 UTC (rev 188220) +++ trunk/Source/WebInspectorUI/ChangeLog 2015-08-10 20:33:26 UTC (rev 188221) @@ -1,3 +1,14 @@ +2015-08-10 Joseph Pecoraro + +Web Inspector: TDZ in ProbeSetDataGrid construction +https://bugs.webkit.org/show_bug.cgi?id=147834 + +Reviewed by Timothy Hatcher. + +* UserInterface/Views/ProbeSetDataGrid.js: +(WebInspector.ProbeSetDataGrid): +Do not use "this" before calling super. + 2015-08-08 Devin Rousso Web Inspector: Timeline ruler handle tooltip shows wrong value when handles overlap Modified: trunk/Source/WebInspectorUI/UserInterface/Views/ProbeSetDataGrid.js (188220 => 188221) --- trunk/Source/WebInspectorUI/UserInterface/Views/ProbeSetDataGrid.js 2015-08-10 20:32:06 UTC (rev 188220) +++ trunk/Source/WebInspectorUI/UserInterface/Views/ProbeSetDataGrid.js 2015-08-10 20:33:26 UTC (rev 188221) @@ -29,7 +29,6 @@ constructor(probeSet) { console.assert(probeSet instanceof WebInspector.ProbeSet, "Invalid ProbeSet argument: ", probeSet); -this.probeSet = probeSet; var columns = {}; for (var probe of probeSet.probes) { @@ -39,6 +38,8 @@ super(columns); +this.probeSet = probeSet; + this.element.classList.add("inline"); this._frameNodes = new Map; ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [188222] trunk/Source/WebCore
Title: [188222] trunk/Source/WebCore Revision 188222 Author drou...@apple.com Date 2015-08-10 13:33:38 -0700 (Mon, 10 Aug 2015) Log Message Web Inspector: Invalid selectors can be applied to the stylesheet https://bugs.webkit.org/show_bug.cgi?id=147230 Reviewed by Timothy Hatcher. * inspector/InspectorStyleSheet.cpp: (WebCore::isValidSelectorListString): (WebCore::InspectorStyleSheet::setRuleSelector): Now checks to see that the supplied selector is valid before trying to commit it to the rule. (WebCore::InspectorStyleSheet::addRule): (WebCore::checkStyleRuleSelector): Deleted. Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/inspector/InspectorStyleSheet.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (188221 => 188222) --- trunk/Source/WebCore/ChangeLog 2015-08-10 20:33:26 UTC (rev 188221) +++ trunk/Source/WebCore/ChangeLog 2015-08-10 20:33:38 UTC (rev 188222) @@ -1,3 +1,17 @@ +2015-08-10 Devin Rousso + +Web Inspector: Invalid selectors can be applied to the stylesheet +https://bugs.webkit.org/show_bug.cgi?id=147230 + +Reviewed by Timothy Hatcher. + +* inspector/InspectorStyleSheet.cpp: +(WebCore::isValidSelectorListString): +(WebCore::InspectorStyleSheet::setRuleSelector): +Now checks to see that the supplied selector is valid before trying to commit it to the rule. +(WebCore::InspectorStyleSheet::addRule): +(WebCore::checkStyleRuleSelector): Deleted. + 2015-08-10 James Craig AX: Address follow-up comments in bug 145684 Modified: trunk/Source/WebCore/inspector/InspectorStyleSheet.cpp (188221 => 188222) --- trunk/Source/WebCore/inspector/InspectorStyleSheet.cpp 2015-08-10 20:33:26 UTC (rev 188221) +++ trunk/Source/WebCore/inspector/InspectorStyleSheet.cpp 2015-08-10 20:33:38 UTC (rev 188222) @@ -637,15 +637,30 @@ return rule->selectorText(); } +static bool isValidSelectorListString(const String& selector, Document* document) +{ +CSSSelectorList selectorList; +createCSSParser(document)->parseSelector(selector, selectorList); +return selectorList.isValid(); +} + bool InspectorStyleSheet::setRuleSelector(const InspectorCSSId& id, const String& selector, ExceptionCode& ec) { if (!checkPageStyleSheet(ec)) return false; + +// If the selector is invalid, do not proceed any further. +if (!isValidSelectorListString(selector, m_pageStyleSheet->ownerDocument())) { +ec = SYNTAX_ERR; +return false; +} + CSSStyleRule* rule = ruleForId(id); if (!rule) { ec = NOT_FOUND_ERR; return false; } + CSSStyleSheet* styleSheet = rule->parentStyleSheet(); if (!styleSheet || !ensureParsedDataReady()) { ec = NOT_FOUND_ERR; @@ -671,18 +686,11 @@ return true; } -static bool checkStyleRuleSelector(Document* document, const String& selector) -{ -CSSSelectorList selectorList; -createCSSParser(document)->parseSelector(selector, selectorList); -return selectorList.isValid(); -} - CSSStyleRule* InspectorStyleSheet::addRule(const String& selector, ExceptionCode& ec) { if (!checkPageStyleSheet(ec)) return nullptr; -if (!checkStyleRuleSelector(m_pageStyleSheet->ownerDocument(), selector)) { +if (!isValidSelectorListString(selector, m_pageStyleSheet->ownerDocument())) { ec = SYNTAX_ERR; return nullptr; } ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [188223] trunk/Source/WebKit2
Title: [188223] trunk/Source/WebKit2 Revision 188223 Author commit-qu...@webkit.org Date 2015-08-10 13:36:10 -0700 (Mon, 10 Aug 2015) Log Message Unreviewed, rolling out r187131 and r187286. https://bugs.webkit.org/show_bug.cgi?id=147839 Causing mroe frequent crashes with invalid layer bounds (rdar://problem/21465328) (Requested by smfr on #webkit). Reverted changesets: "[iOS] Menu drop down such as on nike.com does not stay" https://bugs.webkit.org/show_bug.cgi?id=147047 http://trac.webkit.org/changeset/187131 "[iOS] REGRESSION (187131): Loading CuteOverload zooms in to the top left corner." https://bugs.webkit.org/show_bug.cgi?id=147251 http://trac.webkit.org/changeset/187286 Modified Paths trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm Diff Modified: trunk/Source/WebKit2/ChangeLog (188222 => 188223) --- trunk/Source/WebKit2/ChangeLog 2015-08-10 20:33:38 UTC (rev 188222) +++ trunk/Source/WebKit2/ChangeLog 2015-08-10 20:36:10 UTC (rev 188223) @@ -1,3 +1,22 @@ +2015-08-10 Commit Queue + +Unreviewed, rolling out r187131 and r187286. +https://bugs.webkit.org/show_bug.cgi?id=147839 + + Causing mroe frequent crashes with invalid layer bounds +(rdar://problem/21465328) (Requested by smfr on #webkit). + +Reverted changesets: + +"[iOS] Menu drop down such as on nike.com does not stay" +https://bugs.webkit.org/show_bug.cgi?id=147047 +http://trac.webkit.org/changeset/187131 + +"[iOS] REGRESSION (187131): Loading CuteOverload zooms in to +the top left corner." +https://bugs.webkit.org/show_bug.cgi?id=147251 +http://trac.webkit.org/changeset/187286 + 2015-08-07 Matt Rajca Media Session: generalize isFocusedContentMediaElementPlaying so it works with other playback attributes Modified: trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm (188222 => 188223) --- trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm 2015-08-10 20:33:38 UTC (rev 188222) +++ trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm 2015-08-10 20:36:10 UTC (rev 188223) @@ -987,24 +987,9 @@ [_scrollView setMinimumZoomScale:layerTreeTransaction.minimumScaleFactor()]; [_scrollView setMaximumZoomScale:layerTreeTransaction.maximumScaleFactor()]; [_scrollView setZoomEnabled:layerTreeTransaction.allowsUserScaling()]; -if (!layerTreeTransaction.scaleWasSetByUIProcess() && ![_scrollView isZooming] && ![_scrollView isZoomBouncing] && ![_scrollView _isAnimatingZoom]) { -float newPageScaleFactor = layerTreeTransaction.pageScaleFactor(); +if (!layerTreeTransaction.scaleWasSetByUIProcess() && ![_scrollView isZooming] && ![_scrollView isZoomBouncing] && ![_scrollView _isAnimatingZoom]) +[_scrollView setZoomScale:layerTreeTransaction.pageScaleFactor()]; -if (!areEssentiallyEqualAsFloat(contentZoomScale(self), newPageScaleFactor)) { -// FIXME: We need to handle stick to bottom. -WebCore::FloatRect oldUnobscuredContentRect = _page->unobscuredContentRect(); -if (!oldUnobscuredContentRect.isEmpty() && oldUnobscuredContentRect.y() < 1) { -CGFloat relativeHorizontalPosition = oldUnobscuredContentRect.x() / oldUnobscuredContentRect.width(); -CGPoint newTopLeft = { relativeHorizontalPosition * newContentSize.width, 0 }; -CGSize scrollViewSize = [_scrollView bounds].size; -CGSize rectToZoomSize = CGSizeMake(scrollViewSize.width / newPageScaleFactor, scrollViewSize.height / newPageScaleFactor); -[_scrollView zoomToRect: { newTopLeft, rectToZoomSize } animated:NO]; -ASSERT(areEssentiallyEqualAsFloat(newPageScaleFactor, contentZoomScale(self))); -} else -[_scrollView setZoomScale:newPageScaleFactor]; -} -} - [self _updateScrollViewBackground]; if (_gestureController) ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes