[webkit-changes] [197064] releases/WebKitGTK/webkit-2.10/Source

[carlosgc]

Title: [197064] releases/WebKitGTK/webkit-2.10/Source








Revision 197064
Author carlo...@webkit.org
Date 2016-02-24 23:45:13 -0800 (Wed, 24 Feb 2016)


Log Message
Merge r197062 - [GTK] Tearing when entering AC mode
https://bugs.webkit.org/show_bug.cgi?id=150955

Reviewed by Michael Catanzaro.

Source/WebCore:

* platform/gtk/GtkUtilities.cpp:
(WebCore::widgetIsOnscreenToplevelWindow): Allow passing nullptr.

Source/WebKit2:

When entering accelerated compositing mode, we keep rendering the
non accelerated contents until we have the first frame of
accelerated compositing contents. When the view is created hidden,
for example when the browser opens a link in a new tab, the view
is not realized until it is mapped. The native surface handle for
compositing, needed by the web process to render accelerated
compositing contents, is not available until the view is realized,
because it depends on the properties of the parent. When a web
view is mapped for the first time, and then realized, we send the
native surface handle for compositing to the web process, and keep
rendering the non composited contents until we get the first
frame, but in this case we never had non composited contents and
we end up rendering an untinitalized surface. This sometimes just
produces flickering and sometimes rendering artifacts.
We can prevent this from happening by realizing the web view as
soon as possible. A GtkWidget can't be realized until it has been
added to a toplevel, so we can realize our view right after it is
added to a toplevel window, and wait until the view is actually
mapped to notify the web process that it has been added to a
window. This way can we enter accelerated compositing mode before
the web view is mapped, so that when mapped we don't try to paint
the previous contents and don't need to wait for the first frame.

* UIProcess/API/gtk/WebKitWebViewBase.cpp:
(toplevelWindowFocusInEvent): Handle the case of the window being
hidden when receiving focus in. According to
gtk_window_focus_in_event, this can happen.
(webkitWebViewBaseSetToplevelOnScreenWindow): When the web view is
removed from its toplevel parent, update the IsInWindow and
WindowIsActive flags accordingly. When the view is added to a
toplevel, realize it and don't update the window flags, they will be
updated when the view is mapped the first time.
(webkitWebViewBaseMap): Also update IsInWindow and WindowIsActive
flags if needed. This way, if for example you open a youtube video
in a new tab, the video won't start playing until you visit the
tab, like we did when the view was realized on map.
(webkitWebViewBaseHierarchyChanged): Use hierarchy-changed signal
instead of parent-set to be notified when the view is added to or
removed from a toplevel.
(webkit_web_view_base_class_init): Implement hierarchy-changed
instead of parent-set.
(webkitWebViewBaseRealize): Do not call
webkitWebViewBaseSetToplevelOnScreenWindow on realize, it's now
webkitWebViewBaseSetToplevelOnScreenWindow the one realizing the view.
* UIProcess/cairo/BackingStoreCairo.cpp:
(WebKit::BackingStore::createBackend): Do not realize the view
here, it should be realized already at this point. If it's not
realized at this point is because it hasn't been added to a
toplevel and gtk_widget_realize will not work anyway.
(WebKit::BackingStore::paint): This is changing the cairo source
operator, so save/restore the cairo context to ensure it doesn't
affect other drawing done after this.

Modified Paths

releases/WebKitGTK/webkit-2.10/Source/WebCore/ChangeLog
releases/WebKitGTK/webkit-2.10/Source/WebCore/platform/gtk/GtkUtilities.cpp
releases/WebKitGTK/webkit-2.10/Source/WebKit2/ChangeLog
releases/WebKitGTK/webkit-2.10/Source/WebKit2/UIProcess/API/gtk/WebKitWebViewBase.cpp
releases/WebKitGTK/webkit-2.10/Source/WebKit2/UIProcess/cairo/BackingStoreCairo.cpp




Diff

Modified: releases/WebKitGTK/webkit-2.10/Source/WebCore/ChangeLog (197063 => 197064)

--- releases/WebKitGTK/webkit-2.10/Source/WebCore/ChangeLog	2016-02-25 07:43:49 UTC (rev 197063)
+++ releases/WebKitGTK/webkit-2.10/Source/WebCore/ChangeLog	2016-02-25 07:45:13 UTC (rev 197064)
@@ -1,3 +1,13 @@
+2016-02-24  Carlos Garcia Campos  
+
+[GTK] Tearing when entering AC mode
+https://bugs.webkit.org/show_bug.cgi?id=150955
+
+Reviewed by Michael Catanzaro.
+
+* platform/gtk/GtkUtilities.cpp:
+(WebCore::widgetIsOnscreenToplevelWindow): Allow passing nullptr.
+
 2016-02-19  Philippe Normand  
 
 [GStreamer] clean-up various leaks


Modified: releases/WebKitGTK/webkit-2.10/Source/WebCore/platform/gtk/GtkUtilities.cpp (197063 => 197064)

--- releases/WebKitGTK/webkit-2.10/Source/WebCore/platform/gtk/GtkUtilities.cpp	2016-02-25 07:43:49 UTC (rev 197063)
+++ releases/WebKitGTK/webkit-2.10/Source/WebCore/platform/gtk/GtkUtilities.cpp	2016-02-25 07:45:13 UTC (rev 197064)
@@ -51,7 +51,7 @@
 
 bool widgetIsOnscreenToplevelWindow(GtkWidget* widget)
 {
-

[webkit-changes] [197063] releases/WebKitGTK/webkit-2.10/Source/WebKit2

[carlosgc]

Title: [197063] releases/WebKitGTK/webkit-2.10/Source/WebKit2








Revision 197063
Author carlo...@webkit.org
Date 2016-02-24 23:43:49 -0800 (Wed, 24 Feb 2016)


Log Message
Merge r196062 - [GTK] Reduce IPC traffic due to view state changes
https://bugs.webkit.org/show_bug.cgi?id=153745

Reviewed by Sergio Villar Senin.

Very often view state changes happen one after another in a very
short period of time, even in the same run loop iteration. For
example, when you switch to the web view window, the view is
focused and the active window flag changes as well. In that case
we are sending two messages to the web process and the page
updates its status according to the new flags in two steps. So, we
could group all state changes happening in the same run loop
iteration and notify about them all in the next iteration. This
also prevents unnecessary changes of state when we quickly go back
to a previous state, for example in focus follows mouse
configurations if you move the mouse outside the window and then
inside the window again quickly.

* UIProcess/API/gtk/WebKitWebViewBase.cpp:
(_WebKitWebViewBasePrivate::_WebKitWebViewBasePrivate): Use
VirewState::Flags to keep the web view state instead of
boolean, and also to keep the flags that need to be updated. Use a
timer to update web view state flags.
(_WebKitWebViewBasePrivate::updateViewStateTimerFired): Call
WebPageProxy::viewStateDidChange() and reset the flags that need
to be updated.
(webkitWebViewBaseScheduleUpdateViewState): Update the flags that
need to be updated and schedule the timer if it's not active.
(toplevelWindowFocusInEvent): Use the flags and schedule an update.
(toplevelWindowFocusOutEvent): Ditto.
(toplevelWindowStateEvent): Also mark the view as hidden when minimized.
(webkitWebViewBaseSetToplevelOnScreenWindow): Connect to
window-state-event instead of deprecated visibility-notify-event.
(webkitWebViewBaseMap): Use the flags and schedule an update.
(webkitWebViewBaseUnmap): Ditto.
(webkitWebViewBaseSetFocus): Ditto.
(webkitWebViewBaseIsInWindowActive): Use the flags.
(webkitWebViewBaseIsFocused): Ditto
(webkitWebViewBaseIsVisible): Ditto.
(webkitWebViewBaseIsInWindow): Removed this since it was unused.
* UIProcess/API/gtk/WebKitWebViewBasePrivate.h:

Modified Paths

releases/WebKitGTK/webkit-2.10/Source/WebKit2/ChangeLog
releases/WebKitGTK/webkit-2.10/Source/WebKit2/UIProcess/API/gtk/WebKitWebViewBase.cpp
releases/WebKitGTK/webkit-2.10/Source/WebKit2/UIProcess/API/gtk/WebKitWebViewBasePrivate.h




Diff

Modified: releases/WebKitGTK/webkit-2.10/Source/WebKit2/ChangeLog (197062 => 197063)

--- releases/WebKitGTK/webkit-2.10/Source/WebKit2/ChangeLog	2016-02-25 07:37:40 UTC (rev 197062)
+++ releases/WebKitGTK/webkit-2.10/Source/WebKit2/ChangeLog	2016-02-25 07:43:49 UTC (rev 197063)
@@ -1,3 +1,47 @@
+2016-02-03  Carlos Garcia Campos  
+
+[GTK] Reduce IPC traffic due to view state changes
+https://bugs.webkit.org/show_bug.cgi?id=153745
+
+Reviewed by Sergio Villar Senin.
+
+Very often view state changes happen one after another in a very
+short period of time, even in the same run loop iteration. For
+example, when you switch to the web view window, the view is
+focused and the active window flag changes as well. In that case
+we are sending two messages to the web process and the page
+updates its status according to the new flags in two steps. So, we
+could group all state changes happening in the same run loop
+iteration and notify about them all in the next iteration. This
+also prevents unnecessary changes of state when we quickly go back
+to a previous state, for example in focus follows mouse
+configurations if you move the mouse outside the window and then
+inside the window again quickly.
+
+* UIProcess/API/gtk/WebKitWebViewBase.cpp:
+(_WebKitWebViewBasePrivate::_WebKitWebViewBasePrivate): Use
+VirewState::Flags to keep the web view state instead of
+boolean, and also to keep the flags that need to be updated. Use a
+timer to update web view state flags.
+(_WebKitWebViewBasePrivate::updateViewStateTimerFired): Call
+WebPageProxy::viewStateDidChange() and reset the flags that need
+to be updated.
+(webkitWebViewBaseScheduleUpdateViewState): Update the flags that
+need to be updated and schedule the timer if it's not active.
+(toplevelWindowFocusInEvent): Use the flags and schedule an update.
+(toplevelWindowFocusOutEvent): Ditto.
+(toplevelWindowStateEvent): Also mark the view as hidden when minimized.
+(webkitWebViewBaseSetToplevelOnScreenWindow): Connect to
+window-state-event instead of deprecated visibility-notify-event.
+(webkitWebViewBaseMap): Use the flags and schedule an update.
+(webkitWebViewBaseUnmap): Ditto.
+(webkitWebViewBaseSetFocus): 

[webkit-changes] [197062] trunk/Source

[carlosgc]

Title: [197062] trunk/Source








Revision 197062
Author carlo...@webkit.org
Date 2016-02-24 23:37:40 -0800 (Wed, 24 Feb 2016)


Log Message
[GTK] Tearing when entering AC mode
https://bugs.webkit.org/show_bug.cgi?id=150955

Reviewed by Michael Catanzaro.

Source/WebCore:

* platform/gtk/GtkUtilities.cpp:
(WebCore::widgetIsOnscreenToplevelWindow): Allow passing nullptr.

Source/WebKit2:

When entering accelerated compositing mode, we keep rendering the
non accelerated contents until we have the first frame of
accelerated compositing contents. When the view is created hidden,
for example when the browser opens a link in a new tab, the view
is not realized until it is mapped. The native surface handle for
compositing, needed by the web process to render accelerated
compositing contents, is not available until the view is realized,
because it depends on the properties of the parent. When a web
view is mapped for the first time, and then realized, we send the
native surface handle for compositing to the web process, and keep
rendering the non composited contents until we get the first
frame, but in this case we never had non composited contents and
we end up rendering an untinitalized surface. This sometimes just
produces flickering and sometimes rendering artifacts.
We can prevent this from happening by realizing the web view as
soon as possible. A GtkWidget can't be realized until it has been
added to a toplevel, so we can realize our view right after it is
added to a toplevel window, and wait until the view is actually
mapped to notify the web process that it has been added to a
window. This way can we enter accelerated compositing mode before
the web view is mapped, so that when mapped we don't try to paint
the previous contents and don't need to wait for the first frame.

* UIProcess/API/gtk/WebKitWebViewBase.cpp:
(toplevelWindowFocusInEvent): Handle the case of the window being
hidden when receiving focus in. According to
gtk_window_focus_in_event, this can happen.
(webkitWebViewBaseSetToplevelOnScreenWindow): When the web view is
removed from its toplevel parent, update the IsInWindow and
WindowIsActive flags accordingly. When the view is added to a
toplevel, realize it and don't update the window flags, they will be
updated when the view is mapped the first time.
(webkitWebViewBaseMap): Also update IsInWindow and WindowIsActive
flags if needed. This way, if for example you open a youtube video
in a new tab, the video won't start playing until you visit the
tab, like we did when the view was realized on map.
(webkitWebViewBaseHierarchyChanged): Use hierarchy-changed signal
instead of parent-set to be notified when the view is added to or
removed from a toplevel.
(webkit_web_view_base_class_init): Implement hierarchy-changed
instead of parent-set.
(webkitWebViewBaseRealize): Do not call
webkitWebViewBaseSetToplevelOnScreenWindow on realize, it's now
webkitWebViewBaseSetToplevelOnScreenWindow the one realizing the view.
* UIProcess/cairo/BackingStoreCairo.cpp:
(WebKit::BackingStore::createBackend): Do not realize the view
here, it should be realized already at this point. If it's not
realized at this point is because it hasn't been added to a
toplevel and gtk_widget_realize will not work anyway.
(WebKit::BackingStore::paint): This is changing the cairo source
operator, so save/restore the cairo context to ensure it doesn't
affect other drawing done after this.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/gtk/GtkUtilities.cpp
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebViewBase.cpp
trunk/Source/WebKit2/UIProcess/cairo/BackingStoreCairo.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (197061 => 197062)

--- trunk/Source/WebCore/ChangeLog	2016-02-25 04:59:18 UTC (rev 197061)
+++ trunk/Source/WebCore/ChangeLog	2016-02-25 07:37:40 UTC (rev 197062)
@@ -1,3 +1,13 @@
+2016-02-24  Carlos Garcia Campos  
+
+[GTK] Tearing when entering AC mode
+https://bugs.webkit.org/show_bug.cgi?id=150955
+
+Reviewed by Michael Catanzaro.
+
+* platform/gtk/GtkUtilities.cpp:
+(WebCore::widgetIsOnscreenToplevelWindow): Allow passing nullptr.
+
 2016-02-24  Chris Dumez  
 
 Drop [TreatReturnedNullStringAs=Null] WebKit-specific IDL attribute


Modified: trunk/Source/WebCore/platform/gtk/GtkUtilities.cpp (197061 => 197062)

--- trunk/Source/WebCore/platform/gtk/GtkUtilities.cpp	2016-02-25 04:59:18 UTC (rev 197061)
+++ trunk/Source/WebCore/platform/gtk/GtkUtilities.cpp	2016-02-25 07:37:40 UTC (rev 197062)
@@ -51,7 +51,7 @@
 
 bool widgetIsOnscreenToplevelWindow(GtkWidget* widget)
 {
-return gtk_widget_is_toplevel(widget) && GTK_IS_WINDOW(widget) && !GTK_IS_OFFSCREEN_WINDOW(widget);
+return widget && gtk_widget_is_toplevel(widget) && GTK_IS_WINDOW(widget) && !GTK_IS_OFFSCREEN_WINDOW(widget);
 }
 
 #if ENABLE(DEVELOPER_MODE)


Modified: trunk/Source/WebKit2/ChangeLog 

[webkit-changes] [197061] trunk

[commit-queue]

Title: [197061] trunk








Revision 197061
Author commit-qu...@webkit.org
Date 2016-02-24 20:59:18 -0800 (Wed, 24 Feb 2016)


Log Message
Web Inspector: Expose Proxy target and handler internal properties to Inspector
https://bugs.webkit.org/show_bug.cgi?id=154663

Patch by Joseph Pecoraro  on 2016-02-24
Reviewed by Timothy Hatcher.

Source/_javascript_Core:

* inspector/JSInjectedScriptHost.cpp:
(Inspector::JSInjectedScriptHost::getInternalProperties):
Expose the ProxyObject's target and handler.

Source/WebInspectorUI:

* UserInterface/Models/NativeFunctionParameters.js:
* UserInterface/Views/ObjectTreePropertyTreeElement.js:
(WebInspector.ObjectTreePropertyTreeElement.prototype._functionParameterString):
Improve the native parameter list for the global Reflect object methods.
Include "enumerate" even though it is deprecated, because we implement it.

LayoutTests:

* inspector/model/remote-object.html:
* platform/mac/inspector/model/remote-object-expected.txt:
Test that a Proxy object includes the internal properties.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/inspector/model/remote-object-expected.txt
trunk/LayoutTests/inspector/model/remote-object.html
trunk/LayoutTests/platform/mac/inspector/model/remote-object-expected.txt
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/inspector/JSInjectedScriptHost.cpp
trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/Models/NativeFunctionParameters.js
trunk/Source/WebInspectorUI/UserInterface/Views/ObjectTreePropertyTreeElement.js




Diff

Modified: trunk/LayoutTests/ChangeLog (197060 => 197061)

--- trunk/LayoutTests/ChangeLog	2016-02-25 02:39:19 UTC (rev 197060)
+++ trunk/LayoutTests/ChangeLog	2016-02-25 04:59:18 UTC (rev 197061)
@@ -1,3 +1,14 @@
+2016-02-24  Joseph Pecoraro  
+
+Web Inspector: Expose Proxy target and handler internal properties to Inspector
+https://bugs.webkit.org/show_bug.cgi?id=154663
+
+Reviewed by Timothy Hatcher.
+
+* inspector/model/remote-object.html:
+* platform/mac/inspector/model/remote-object-expected.txt:
+Test that a Proxy object includes the internal properties.
+
 2016-02-24  Ryan Haddad  
 
 Marking storage/indexeddb/odd-strings.html as flaky on mac-wk1


Modified: trunk/LayoutTests/inspector/model/remote-object-expected.txt (197060 => 197061)

--- trunk/LayoutTests/inspector/model/remote-object-expected.txt	2016-02-25 02:39:19 UTC (rev 197060)
+++ trunk/LayoutTests/inspector/model/remote-object-expected.txt	2016-02-25 04:59:18 UTC (rev 197061)
@@ -4656,6 +4656,74 @@
 }
 
 -
+_expression_: new Proxy({x:1, y:1}, {handler: true})
+{
+  "_type": "object",
+  "_objectId": "",
+  "_description": "ProxyObject",
+  "_preview": {
+"_listeners": null,
+"_type": "object",
+"_description": "ProxyObject",
+"_lossless": true,
+"_overflow": false,
+"_properties": [
+  {
+"_listeners": null,
+"_name": "target",
+"_type": "object",
+"_valuePreview": {
+  "_listeners": null,
+  "_type": "object",
+  "_description": "Object",
+  "_lossless": true,
+  "_overflow": false,
+  "_properties": [
+{
+  "_listeners": null,
+  "_name": "x",
+  "_type": "number",
+  "_value": "1"
+},
+{
+  "_listeners": null,
+  "_name": "y",
+  "_type": "number",
+  "_value": "1"
+}
+  ],
+  "_entries": null
+},
+"_internal": true
+  },
+  {
+"_listeners": null,
+"_name": "handler",
+"_type": "object",
+"_valuePreview": {
+  "_listeners": null,
+  "_type": "object",
+  "_description": "Object",
+  "_lossless": true,
+  "_overflow": false,
+  "_properties": [
+{
+  "_listeners": null,
+  "_name": "handler",
+  "_type": "boolean",
+  "_value": "true"
+}
+  ],
+  "_entries": null
+},
+"_internal": true
+  }
+],
+"_entries": null
+  }
+}
+
+-
 _expression_: Person = class Person { constructor(name){} get fullName(){} methodName(p1, p2){} }; Person
 {
   "_type": "function",


Modified: trunk/LayoutTests/inspector/model/remote-object.html (197060 => 197061)

--- trunk/LayoutTests/inspector/model/remote-object.html	2016-02-25 02:39:19 UTC (rev 197060)
+++ trunk/LayoutTests/inspector/model/remote-object.html	2016-02-25 04:59:18 UTC (rev 197061)
@@ -168,6 +168,9 @@
 {_expression_: "Promise.resolve()"},
 {_expression_: "Promise.resolve({result:1})"},
 
+// Proxy
+

[webkit-changes] [197060] trunk/Source/WebCore

[cdumez]

Title: [197060] trunk/Source/WebCore








Revision 197060
Author cdu...@apple.com
Date 2016-02-24 18:39:19 -0800 (Wed, 24 Feb 2016)


Log Message
Drop [TreatReturnedNullStringAs=Null] WebKit-specific IDL attribute
https://bugs.webkit.org/show_bug.cgi?id=154659

Reviewed by Sam Weinig.

Drop [TreatReturnedNullStringAs=Null] WebKit-specific IDL attribute and
use nullable DOMString types instead:
http://heycam.github.io/webidl/#idl-nullable-type

This is the standard way of doing things. We already had support
in the bindings generator for nullable DOMString attributes so
we now just leverage this support. However, our IDL parser did
not correctly parse nullable DOMString return values for operations.
This patch fixes this.

This patch also drops [TreatNullAs=NullString] and
[TreatUndefinedAs=NullString] for writable DOMString attributes that
are now marked as nullable because they are implied.

* Modules/fetch/FetchHeaders.idl:
* Modules/indexeddb/IDBObjectStore.idl:
* Modules/mediasource/DOMURLMediaSource.idl:
* Modules/mediastream/DOMURLMediaStream.idl:
* Modules/websockets/WebSocket.idl:
* bindings/scripts/CodeGeneratorJS.pm:
(NativeToJSValue): Deleted.
* bindings/scripts/IDLAttributes.txt:
* bindings/scripts/IDLParser.pm:
(parseAttributeOrOperationRest):
(parseOperationOrIterator):
(parseSpecialOperation):
* bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:
(webkit_dom_test_obj_nullable_string_method):
(webkit_dom_test_obj_nullable_string_special_method):
(webkit_dom_test_obj_conditional_method3): Deleted.
(webkit_dom_test_obj_convert1): Deleted.
* bindings/scripts/test/GObject/WebKitDOMTestObj.h:
* bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore::JSTestObj::getOwnPropertySlot):
(WebCore::JSTestObj::getOwnPropertySlotByIndex):
(WebCore::JSTestObj::getOwnPropertyNames):
(WebCore::jsTestObjPrototypeFunctionNullableStringMethod):
(WebCore::jsTestObjConstructorFunctionNullableStringStaticMethod):
(WebCore::jsTestObjPrototypeFunctionNullableStringSpecialMethod):
(WebCore::jsTestObjPrototypeFunctionMethodWithAndWithoutNullableSequence): Deleted.
(WebCore::jsTestObjPrototypeFunctionMethodWithAndWithoutNullableSequence2): Deleted.
* bindings/scripts/test/JS/JSTestObj.h:
* bindings/scripts/test/ObjC/DOMTestObj.h:
* bindings/scripts/test/ObjC/DOMTestObj.mm:
(-[DOMTestObj nullableStringMethod]):
(-[DOMTestObj nullableStringStaticMethod]):
(-[DOMTestObj nullableStringSpecialMethod:]):
(-[DOMTestObj overloadedMethod1:]): Deleted.
(-[DOMTestObj getSVGDocument]): Deleted.
* bindings/scripts/test/TestObj.idl:
* css/CSSCharsetRule.idl:
* css/CSSImportRule.idl:
* css/CSSKeyframesRule.idl:
* css/CSSPageRule.idl:
* css/CSSRule.idl:
* css/CSSStyleDeclaration.idl:
* css/CSSStyleRule.idl:
* css/CSSValue.idl:
* css/MediaList.idl:
* css/StyleSheet.idl:
* dom/Attr.idl:
* dom/CharacterData.idl:
* dom/DOMStringList.idl:
* dom/Document.idl:
* dom/DocumentType.idl:
* dom/Element.idl:
* dom/Entity.idl:
* dom/MutationRecord.idl:
* dom/Node.idl:
* dom/ProcessingInstruction.idl:
* html/DOMSettableTokenList.idl:
* html/DOMTokenList.idl:
* html/DOMURL.idl:
* html/canvas/WebGLDebugShaders.idl:
* html/canvas/WebGLRenderingContextBase.idl:
* page/DOMWindow.idl:
* storage/Storage.idl:
* storage/StorageEvent.idl:
* xml/XMLHttpRequest.idl:
* xml/XPathNSResolver.idl:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/fetch/FetchHeaders.idl
trunk/Source/WebCore/Modules/indexeddb/IDBObjectStore.idl
trunk/Source/WebCore/Modules/mediasource/DOMURLMediaSource.idl
trunk/Source/WebCore/Modules/mediastream/DOMURLMediaStream.idl
trunk/Source/WebCore/Modules/websockets/WebSocket.idl
trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm
trunk/Source/WebCore/bindings/scripts/IDLAttributes.txt
trunk/Source/WebCore/bindings/scripts/IDLParser.pm
trunk/Source/WebCore/bindings/scripts/test/GObject/WebKitDOMTestObj.cpp
trunk/Source/WebCore/bindings/scripts/test/GObject/WebKitDOMTestObj.h
trunk/Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp
trunk/Source/WebCore/bindings/scripts/test/JS/JSTestObj.h
trunk/Source/WebCore/bindings/scripts/test/ObjC/DOMTestObj.h
trunk/Source/WebCore/bindings/scripts/test/ObjC/DOMTestObj.mm
trunk/Source/WebCore/bindings/scripts/test/TestObj.idl
trunk/Source/WebCore/css/CSSCharsetRule.idl
trunk/Source/WebCore/css/CSSImportRule.idl
trunk/Source/WebCore/css/CSSKeyframesRule.idl
trunk/Source/WebCore/css/CSSPageRule.idl
trunk/Source/WebCore/css/CSSRule.idl
trunk/Source/WebCore/css/CSSStyleDeclaration.idl
trunk/Source/WebCore/css/CSSStyleRule.idl
trunk/Source/WebCore/css/CSSValue.idl
trunk/Source/WebCore/css/MediaList.idl
trunk/Source/WebCore/css/StyleSheet.idl
trunk/Source/WebCore/dom/Attr.idl
trunk/Source/WebCore/dom/CharacterData.idl
trunk/Source/WebCore/dom/DOMStringList.idl
trunk/Source/WebCore/dom/Document.idl
trunk/Source/WebCore/dom/DocumentType.idl
trunk/Source/WebCore/dom/Element.idl
trunk/Source/WebCore/dom/Entity.idl
trunk/Source/WebCore/dom/MutationRecord.idl

[webkit-changes] [197059] trunk/Source/WebInspectorUI

[commit-queue]

Title: [197059] trunk/Source/WebInspectorUI








Revision 197059
Author commit-qu...@webkit.org
Date 2016-02-24 17:28:51 -0800 (Wed, 24 Feb 2016)


Log Message
Web Inspector: Visual Styles sidebar should support multiple animations
https://bugs.webkit.org/show_bug.cgi?id=154546


Patch by Devin Rousso  on 2016-02-24
Reviewed by Timothy Hatcher.

* UserInterface/Views/VisualStyleDetailsPanel.js:
(WebInspector.VisualStyleDetailsPanel.prototype._populateTransitionSection):
Set additional flags on the optional properties of transition to ensure
that the initial value of a new row is not considered invalid.

(WebInspector.VisualStyleDetailsPanel.prototype._populateAnimationSection):
Added a comma-separated keyword list to provide support for multiple
animations per rule.

Modified Paths

trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/Views/VisualStyleDetailsPanel.js




Diff

Modified: trunk/Source/WebInspectorUI/ChangeLog (197058 => 197059)

--- trunk/Source/WebInspectorUI/ChangeLog	2016-02-25 01:11:54 UTC (rev 197058)
+++ trunk/Source/WebInspectorUI/ChangeLog	2016-02-25 01:28:51 UTC (rev 197059)
@@ -1,3 +1,20 @@
+2016-02-24  Devin Rousso  
+
+Web Inspector: Visual Styles sidebar should support multiple animations
+https://bugs.webkit.org/show_bug.cgi?id=154546
+
+
+Reviewed by Timothy Hatcher.
+
+* UserInterface/Views/VisualStyleDetailsPanel.js:
+(WebInspector.VisualStyleDetailsPanel.prototype._populateTransitionSection):
+Set additional flags on the optional properties of transition to ensure
+that the initial value of a new row is not considered invalid.
+
+(WebInspector.VisualStyleDetailsPanel.prototype._populateAnimationSection):
+Added a comma-separated keyword list to provide support for multiple
+animations per rule.
+
 2016-02-24  Timothy Hatcher  
 
 Web Inspector: Remove unused Profile.png images


Modified: trunk/Source/WebInspectorUI/UserInterface/Views/VisualStyleDetailsPanel.js (197058 => 197059)

--- trunk/Source/WebInspectorUI/UserInterface/Views/VisualStyleDetailsPanel.js	2016-02-25 01:11:54 UTC (rev 197058)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/VisualStyleDetailsPanel.js	2016-02-25 01:28:51 UTC (rev 197059)
@@ -1264,7 +1264,9 @@
 let transitionPropertyRow = new WebInspector.DetailsSectionRow;
 
 let transitionProperty = new WebInspector.VisualStylePropertyNameInput("transition-property", WebInspector.UIString("Property"));
+transitionProperty.masterProperty = true;
 let transitionTiming = new WebInspector.VisualStyleTimingEditor("transition-timing-function", WebInspector.UIString("Timing"), ["Linear", "Ease", "Ease In", "Ease Out", "Ease In Out"]);
+transitionTiming.optionalProperty = true;
 
 transitionPropertyRow.element.appendChild(transitionProperty.element);
 transitionPropertyRow.element.appendChild(transitionTiming.element);
@@ -1273,13 +1275,14 @@
 
 let transitionTimeKeywords = ["s", "ms"];
 let transitionDuration = new WebInspector.VisualStyleNumberInputBox("transition-duration", WebInspector.UIString("Duration"), null, transitionTimeKeywords);
+transitionDuration.optionalProperty = true;
 let transitionDelay = new WebInspector.VisualStyleNumberInputBox("transition-delay", WebInspector.UIString("Delay"), null, transitionTimeKeywords);
 transitionDelay.optionalProperty = true;
 
 transitionDurationRow.element.appendChild(transitionDuration.element);
 transitionDurationRow.element.appendChild(transitionDelay.element);
 
-let transitionProperties = [transitionProperty, transitionTiming, transitionDuration, transitionDelay];
+let transitionProperties = [transitionProperty, transitionDuration, transitionTiming, transitionDelay];
 let transitionPropertyCombiner = new WebInspector.VisualStylePropertyCombiner("transition", transitionProperties);
 
 let noRemainingCommaSeparatedEditorItems = this._noRemainingCommaSeparatedEditorItems.bind(this, transitionPropertyCombiner, transitionProperties);
@@ -1303,47 +1306,84 @@
 let group = this._groups.animation;
 let properties = group.properties;
 
+let animationRow = new WebInspector.DetailsSectionRow;
+
+properties.animation = new WebInspector.VisualStyleCommaSeparatedKeywordEditor("animation", null, {
+"animation-name": "none",
+"animation-timing-function": "ease",
+"animation-iteration-count": "1",
+"animation-duration": "0",
+"animation-delay": "0",
+"animation-direction": "normal",
+"animation-fill-mode": "none",
+"animation-play-state": "running"
+});
+
+animationRow.element.appendChild(properties.animation.element);
+
 let 

[webkit-changes] [197058] trunk

[dino]

Title: [197058] trunk








Revision 197058
Author d...@apple.com
Date 2016-02-24 17:11:54 -0800 (Wed, 24 Feb 2016)


Log Message
[web-animations] Add AnimationTimeline, DocumentTimeline and add extensions to Document interface
https://bugs.webkit.org/show_bug.cgi?id=151688

Patch by Nikos Andronikos  on 2016-02-24
Reviewed by Dean Jackson.

.:

Enables the WEB_ANIMATIONS compiler switch.

* Source/cmake/OptionsWin.cmake:

Source/_javascript_Core:

Enables the WEB_ANIMATIONS compiler switch.

* Configurations/FeatureDefines.xcconfig:

Source/WebCore:

- Adds DocumentTimeline interface and class implementation
- Implements the DocumentAnimation extension to the Document Interface that contains a default DocumentTimeline
- Add AnimationTimeline interface stub (i.e. without getAnimations and currentTime)
- Adds AnimationTimeline class implementation for AnimationTimeline interface stub
- Adds _javascript_ bindings for the above classes and interfaces
- Enables the WEB_ANIMATIONS compiler switch

No tests yet.  Tests will be added as class functionality is added incrementally.

* CMakeLists.txt:
* Configurations/FeatureDefines.xcconfig:
* DerivedSources.make:
* PlatformGTK.cmake:
* WebCore.vcxproj/WebCore.vcxproj:
* WebCore.vcxproj/WebCore.vcxproj.filters:
* WebCore.vcxproj/WebCoreIncludeCommon.props:
* WebCore.vcxproj/copyForwardingHeaders.cmd:
* WebCore.xcodeproj/project.pbxproj:
* animation/AnimationTimeline.cpp: Added.
(WebCore::AnimationTimeline::AnimationTimeline):
(WebCore::AnimationTimeline::~AnimationTimeline):
(WebCore::AnimationTimeline::destroy):
* animation/AnimationTimeline.h: Added.
(WebCore::AnimationTimeline::deref):
(WebCore::AnimationTimeline::isDocumentTimeline):
(WebCore::AnimationTimeline::classType):
* animation/AnimationTimeline.idl: Added.
* animation/DocumentAnimation.cpp: Added.
(WebCore::DocumentAnimation::DocumentAnimation):
(WebCore::DocumentAnimation::~DocumentAnimation):
(WebCore::DocumentAnimation::timeline):
(WebCore::DocumentAnimation::supplementName):
(WebCore::DocumentAnimation::from):
* animation/DocumentAnimation.h: Added.
* animation/DocumentAnimation.idl: Added.
* animation/DocumentTimeline.cpp: Added.
(WebCore::DocumentTimeline::create):
(WebCore::DocumentTimeline::DocumentTimeline):
(WebCore::DocumentTimeline::~DocumentTimeline):
* animation/DocumentTimeline.h: Added.
* animation/DocumentTimeline.idl: Added.
* bindings/js/JSAnimationTimelineCustom.cpp: Added.
(WebCore::toJS):
* bindings/js/JSBindingsAllInOne.cpp:
* bindings/scripts/CodeGeneratorGObject.pm:
* dom/Document.h:

Source/WebKit/mac:

Enables the WEB_ANIMATIONS compiler switch.

* Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

Enables the WEB_ANIMATIONS compiler switch.

* Configurations/FeatureDefines.xcconfig:

Source/WTF:

Enables the WEB_ANIMATIONS compiler switch.

* wtf/FeatureDefines.h:

Tools:

Enables the WEB_ANIMATIONS compiler switch by default.

* Scripts/webkitperl/FeatureList.pm:

WebKitLibraries:

Enables the WEB_ANIMATIONS compiler switch.

* win/tools/vsprops/FeatureDefines.props:
* win/tools/vsprops/FeatureDefinesCairo.props:

Modified Paths

trunk/ChangeLog
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/Configurations/FeatureDefines.xcconfig
trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/FeatureDefines.h
trunk/Source/WebCore/CMakeLists.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Configurations/FeatureDefines.xcconfig
trunk/Source/WebCore/DerivedSources.make
trunk/Source/WebCore/PlatformGTK.cmake
trunk/Source/WebCore/WebCore.vcxproj/WebCore.vcxproj
trunk/Source/WebCore/WebCore.vcxproj/WebCore.vcxproj.filters
trunk/Source/WebCore/WebCore.vcxproj/WebCoreIncludeCommon.props
trunk/Source/WebCore/WebCore.vcxproj/copyForwardingHeaders.cmd
trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj
trunk/Source/WebCore/bindings/js/JSBindingsAllInOne.cpp
trunk/Source/WebCore/bindings/scripts/CodeGeneratorGObject.pm
trunk/Source/WebCore/dom/Document.h
trunk/Source/WebKit/mac/ChangeLog
trunk/Source/WebKit/mac/Configurations/FeatureDefines.xcconfig
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/Configurations/FeatureDefines.xcconfig
trunk/Source/cmake/OptionsWin.cmake
trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitperl/FeatureList.pm
trunk/WebKitLibraries/ChangeLog
trunk/WebKitLibraries/win/tools/vsprops/FeatureDefines.props
trunk/WebKitLibraries/win/tools/vsprops/FeatureDefinesCairo.props


Added Paths

trunk/Source/WebCore/animation/
trunk/Source/WebCore/animation/AnimationTimeline.cpp
trunk/Source/WebCore/animation/AnimationTimeline.h
trunk/Source/WebCore/animation/AnimationTimeline.idl
trunk/Source/WebCore/animation/DocumentAnimation.cpp
trunk/Source/WebCore/animation/DocumentAnimation.h
trunk/Source/WebCore/animation/DocumentAnimation.idl
trunk/Source/WebCore/animation/DocumentTimeline.cpp
trunk/Source/WebCore/animation/DocumentTimeline.h
trunk/Source/WebCore/animation/DocumentTimeline.idl

[webkit-changes] [197057] trunk/Source/WebCore

[beidson]

Title: [197057] trunk/Source/WebCore








Revision 197057
Author beid...@apple.com
Date 2016-02-24 16:23:38 -0800 (Wed, 24 Feb 2016)


Log Message
Modern IDB: Some w3c objectstore tests crash under GuardMalloc.
https://bugs.webkit.org/show_bug.cgi?id=154460

Reviewed by Alex Christensen.

No new tests (Covered by existing tests).

* Modules/indexeddb/server/UniqueIDBDatabase.cpp:
(WebCore::IDBServer::UniqueIDBDatabase::~UniqueIDBDatabase):
(WebCore::IDBServer::UniqueIDBDatabase::performCurrentDeleteOperation):
(WebCore::IDBServer::UniqueIDBDatabase::didDeleteBackingStore):  Don't delete the UniqueIDBDatabase yet
  if there are still any connections pending close.
(WebCore::IDBServer::UniqueIDBDatabase::didPerformCommitTransaction):
(WebCore::IDBServer::UniqueIDBDatabase::didPerformAbortTransaction):
(WebCore::IDBServer::UniqueIDBDatabase::inProgressTransactionCompleted): It's possible that with this
  transaction completing, and a connection finished its close process, that the UniqueIDBDatabase is
  now ready to be deleted.

* Modules/indexeddb/server/UniqueIDBDatabaseConnection.cpp:
(WebCore::IDBServer::UniqueIDBDatabaseConnection::abortTransactionWithoutCallback):
* Modules/indexeddb/server/UniqueIDBDatabaseConnection.h:

* Modules/indexeddb/server/UniqueIDBDatabaseTransaction.cpp:
(WebCore::IDBServer::UniqueIDBDatabaseTransaction::abortWithoutCallback):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/indexeddb/server/UniqueIDBDatabase.cpp
trunk/Source/WebCore/Modules/indexeddb/server/UniqueIDBDatabaseConnection.cpp
trunk/Source/WebCore/Modules/indexeddb/server/UniqueIDBDatabaseConnection.h
trunk/Source/WebCore/Modules/indexeddb/server/UniqueIDBDatabaseTransaction.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (197056 => 197057)

--- trunk/Source/WebCore/ChangeLog	2016-02-24 23:47:25 UTC (rev 197056)
+++ trunk/Source/WebCore/ChangeLog	2016-02-25 00:23:38 UTC (rev 197057)
@@ -1,3 +1,30 @@
+2016-02-24  Brady Eidson  
+
+Modern IDB: Some w3c objectstore tests crash under GuardMalloc.
+https://bugs.webkit.org/show_bug.cgi?id=154460
+
+Reviewed by Alex Christensen.
+
+No new tests (Covered by existing tests).
+
+* Modules/indexeddb/server/UniqueIDBDatabase.cpp:
+(WebCore::IDBServer::UniqueIDBDatabase::~UniqueIDBDatabase):
+(WebCore::IDBServer::UniqueIDBDatabase::performCurrentDeleteOperation):
+(WebCore::IDBServer::UniqueIDBDatabase::didDeleteBackingStore):  Don't delete the UniqueIDBDatabase yet 
+  if there are still any connections pending close.
+(WebCore::IDBServer::UniqueIDBDatabase::didPerformCommitTransaction):
+(WebCore::IDBServer::UniqueIDBDatabase::didPerformAbortTransaction):
+(WebCore::IDBServer::UniqueIDBDatabase::inProgressTransactionCompleted): It's possible that with this
+  transaction completing, and a connection finished its close process, that the UniqueIDBDatabase is
+  now ready to be deleted.
+
+* Modules/indexeddb/server/UniqueIDBDatabaseConnection.cpp:
+(WebCore::IDBServer::UniqueIDBDatabaseConnection::abortTransactionWithoutCallback):
+* Modules/indexeddb/server/UniqueIDBDatabaseConnection.h:
+
+* Modules/indexeddb/server/UniqueIDBDatabaseTransaction.cpp:
+(WebCore::IDBServer::UniqueIDBDatabaseTransaction::abortWithoutCallback):
+
 2016-02-24  Konstantin Tokarev  
 
 [cmake] Moved PRE/POST_BUILD_COMMAND to WEBKIT_FRAMEWORK.


Modified: trunk/Source/WebCore/Modules/indexeddb/server/UniqueIDBDatabase.cpp (197056 => 197057)

--- trunk/Source/WebCore/Modules/indexeddb/server/UniqueIDBDatabase.cpp	2016-02-24 23:47:25 UTC (rev 197056)
+++ trunk/Source/WebCore/Modules/indexeddb/server/UniqueIDBDatabase.cpp	2016-02-25 00:23:38 UTC (rev 197057)
@@ -59,6 +59,7 @@
 ASSERT(m_inProgressTransactions.isEmpty());
 ASSERT(m_pendingTransactions.isEmpty());
 ASSERT(m_openDatabaseConnections.isEmpty());
+ASSERT(m_closePendingDatabaseConnections.isEmpty());
 }
 
 const IDBDatabaseInfo& UniqueIDBDatabase::info() const
@@ -181,12 +182,8 @@
 return;
 }
 
-// Even though we have no open database connections, we might have close-pending database connections
-// that are waiting on transactions to complete.
-if (!m_inProgressTransactions.isEmpty()) {
-ASSERT(!m_closePendingDatabaseConnections.isEmpty());
+if (!m_inProgressTransactions.isEmpty())
 return;
-}
 
 ASSERT(!hasAnyPendingCallbacks());
 ASSERT(m_pendingTransactions.isEmpty());
@@ -241,10 +238,12 @@
 m_deletePending = false;
 m_deleteBackingStoreInProgress = false;
 
-if (m_pendingOpenDBRequests.isEmpty())
-m_server.deleteUniqueIDBDatabase(*this);
-else
-invokeOperationAndTransactionTimer();
+if (m_closePendingDatabaseConnections.isEmpty()) {
+if (m_pendingOpenDBRequests.isEmpty())
+

[webkit-changes] [197056] trunk

[commit-queue]

Title: [197056] trunk








Revision 197056
Author commit-qu...@webkit.org
Date 2016-02-24 15:47:25 -0800 (Wed, 24 Feb 2016)


Log Message
[cmake] Moved PRE/POST_BUILD_COMMAND to WEBKIT_FRAMEWORK.
https://bugs.webkit.org/show_bug.cgi?id=154651

Patch by Konstantin Tokarev  on 2016-02-24
Reviewed by Alex Christensen.

.:

* Source/cmake/WebKitMacros.cmake:

Source/_javascript_Core:

* CMakeLists.txt: Moved shared code to WEBKIT_FRAMEWORK macro.

Source/WebCore:

No new tests needed.

* CMakeLists.txt: Moved shared code to WEBKIT_FRAMEWORK macro.

Source/WTF:

* CMakeLists.txt: Moved shared code to WEBKIT_FRAMEWORK macro.

Modified Paths

trunk/ChangeLog
trunk/Source/_javascript_Core/CMakeLists.txt
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/CMakeLists.txt
trunk/Source/WebCore/CMakeLists.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/cmake/WebKitMacros.cmake




Diff

Modified: trunk/ChangeLog (197055 => 197056)

--- trunk/ChangeLog	2016-02-24 23:37:51 UTC (rev 197055)
+++ trunk/ChangeLog	2016-02-24 23:47:25 UTC (rev 197056)
@@ -1,3 +1,12 @@
+2016-02-24  Konstantin Tokarev  
+
+[cmake] Moved PRE/POST_BUILD_COMMAND to WEBKIT_FRAMEWORK.
+https://bugs.webkit.org/show_bug.cgi?id=154651
+
+Reviewed by Alex Christensen.
+
+* Source/cmake/WebKitMacros.cmake:
+
 2016-02-22  Konstantin Tokarev  
 
 [cmake] Moved library setup code to WEBKIT_FRAMEWORK macro.


Modified: trunk/Source/_javascript_Core/CMakeLists.txt (197055 => 197056)

--- trunk/Source/_javascript_Core/CMakeLists.txt	2016-02-24 23:37:51 UTC (rev 197055)
+++ trunk/Source/_javascript_Core/CMakeLists.txt	2016-02-24 23:47:25 UTC (rev 197056)
@@ -1312,14 +1312,6 @@
 WEBKIT_WRAP_SOURCELIST(${_javascript_Core_SOURCES})
 WEBKIT_FRAMEWORK(_javascript_Core)
 
-if (_javascript_Core_PRE_BUILD_COMMAND)
-add_custom_command(TARGET _javascript_Core PRE_BUILD COMMAND ${_javascript_Core_PRE_BUILD_COMMAND} VERBATIM)
-endif ()
-
-if (_javascript_Core_POST_BUILD_COMMAND)
-add_custom_command(TARGET _javascript_Core POST_BUILD COMMAND ${_javascript_Core_POST_BUILD_COMMAND} VERBATIM)
-endif ()
-
 if (${_javascript_Core_LIBRARY_TYPE} STREQUAL "SHARED")
 POPULATE_LIBRARY_VERSION(_javascript_CORE)
 set_target_properties(_javascript_Core PROPERTIES VERSION ${_javascript_CORE_VERSION} SOVERSION ${_javascript_CORE_VERSION_MAJOR})


Modified: trunk/Source/_javascript_Core/ChangeLog (197055 => 197056)

--- trunk/Source/_javascript_Core/ChangeLog	2016-02-24 23:37:51 UTC (rev 197055)
+++ trunk/Source/_javascript_Core/ChangeLog	2016-02-24 23:47:25 UTC (rev 197056)
@@ -1,3 +1,12 @@
+2016-02-24  Konstantin Tokarev  
+
+[cmake] Moved PRE/POST_BUILD_COMMAND to WEBKIT_FRAMEWORK.
+https://bugs.webkit.org/show_bug.cgi?id=154651
+
+Reviewed by Alex Christensen.
+
+* CMakeLists.txt: Moved shared code to WEBKIT_FRAMEWORK macro.
+
 2016-02-24  Commit Queue  
 
 Unreviewed, rolling out r197033.


Modified: trunk/Source/WTF/ChangeLog (197055 => 197056)

--- trunk/Source/WTF/ChangeLog	2016-02-24 23:37:51 UTC (rev 197055)
+++ trunk/Source/WTF/ChangeLog	2016-02-24 23:47:25 UTC (rev 197056)
@@ -1,3 +1,12 @@
+2016-02-24  Konstantin Tokarev  
+
+[cmake] Moved PRE/POST_BUILD_COMMAND to WEBKIT_FRAMEWORK.
+https://bugs.webkit.org/show_bug.cgi?id=154651
+
+Reviewed by Alex Christensen.
+
+* CMakeLists.txt: Moved shared code to WEBKIT_FRAMEWORK macro.
+
 2016-02-23  Dan Bernstein  
 
 [Xcode] Linker errors display mangled names, but no longer should


Modified: trunk/Source/WTF/wtf/CMakeLists.txt (197055 => 197056)

--- trunk/Source/WTF/wtf/CMakeLists.txt	2016-02-24 23:37:51 UTC (rev 197055)
+++ trunk/Source/WTF/wtf/CMakeLists.txt	2016-02-24 23:47:25 UTC (rev 197056)
@@ -290,7 +290,3 @@
 set(CMAKE_SHARED_LINKER_FLAGS "${CMAKE_SHARED_LINKER_FLAGS} /SUBSYSTEM:WINDOWS")
 set(CMAKE_EXE_LINKER_FLAGS "${CMAKE_EXE_LINKER_FLAGS} /SUBSYSTEM:WINDOWS")
 endif ()
-
-if (WTF_PRE_BUILD_COMMAND)
-add_custom_command(TARGET WTF PRE_BUILD COMMAND ${WTF_PRE_BUILD_COMMAND} VERBATIM)
-endif ()


Modified: trunk/Source/WebCore/CMakeLists.txt (197055 => 197056)

--- trunk/Source/WebCore/CMakeLists.txt	2016-02-24 23:37:51 UTC (rev 197055)
+++ trunk/Source/WebCore/CMakeLists.txt	2016-02-24 23:47:25 UTC (rev 197056)
@@ -3788,15 +3788,6 @@
 ADD_TARGET_PROPERTIES(WebCore COMPILE_FLAGS "-fno-tree-sra")
 endif ()
 
-if (WebCore_PRE_BUILD_COMMAND)
-add_custom_target(WebCorePreBuild COMMAND ${WebCore_PRE_BUILD_COMMAND} VERBATIM)
-add_dependencies(WebCore WebCorePreBuild)
-endif ()
-
-if (WebCore_POST_BUILD_COMMAND)
-add_custom_command(TARGET WebCore POST_BUILD COMMAND ${WebCore_POST_BUILD_COMMAND} VERBATIM)
-endif ()
-
 if (MSVC)
 ADD_PRECOMPILED_HEADER("WebCoreTestSupportPrefix.h" 

[webkit-changes] [197055] trunk/Source/WebCore

[rniwa]

Title: [197055] trunk/Source/WebCore








Revision 197055
Author rn...@webkit.org
Date 2016-02-24 15:37:51 -0800 (Wed, 24 Feb 2016)


Log Message
Use more references in FocusNavigationScope
https://bugs.webkit.org/show_bug.cgi?id=154637

Reviewed by Chris Dumez.

Use references in various functions of FocusNavigationScope as well as m_treeScope.

* page/FocusController.cpp:
(WebCore::FocusNavigationScope::FocusNavigationScope): Takes TreeScope& instead of TreeScope*.
(WebCore::FocusNavigationScope::rootNode): Returns ContainerNode& instead of ContainerNode*.
(WebCore::FocusNavigationScope::owner):
(WebCore::FocusNavigationScope::scopeOf): Takes Node& instead of Node*. Renamed from focusNavigationScopeOf.
(WebCore::FocusNavigationScope::scopeOwnedByShadowHost): Ditto. Renamed from focusNavigationScopeOwnedByShadowHost.
(WebCore::FocusNavigationScope::scopeOwnedByIFrame): Ditto. Renamed from focusNavigationScopeOwnedByIFrame.
(WebCore::FocusController::findFocusableElementDescendingDownIntoFrameDocument):
(WebCore::FocusController::advanceFocusInDocumentOrder):
(WebCore::FocusController::findFocusableElementAcrossFocusScope): Define currentScope inside the loop now that
the copy constructor of FocusNavigationScope no longer exists (since m_treeScope is a reference).
(WebCore::FocusController::findFocusableElementRecursively):
(WebCore::nextElementWithGreaterTabIndex):
(WebCore::FocusController::nextFocusableElement):
(WebCore::FocusController::previousFocusableElement):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/FocusController.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (197054 => 197055)

--- trunk/Source/WebCore/ChangeLog	2016-02-24 23:19:18 UTC (rev 197054)
+++ trunk/Source/WebCore/ChangeLog	2016-02-24 23:37:51 UTC (rev 197055)
@@ -1,3 +1,28 @@
+2016-02-24  Ryosuke Niwa  
+
+Use more references in FocusNavigationScope
+https://bugs.webkit.org/show_bug.cgi?id=154637
+
+Reviewed by Chris Dumez.
+
+Use references in various functions of FocusNavigationScope as well as m_treeScope.
+
+* page/FocusController.cpp:
+(WebCore::FocusNavigationScope::FocusNavigationScope): Takes TreeScope& instead of TreeScope*.
+(WebCore::FocusNavigationScope::rootNode): Returns ContainerNode& instead of ContainerNode*.
+(WebCore::FocusNavigationScope::owner):
+(WebCore::FocusNavigationScope::scopeOf): Takes Node& instead of Node*. Renamed from focusNavigationScopeOf.
+(WebCore::FocusNavigationScope::scopeOwnedByShadowHost): Ditto. Renamed from focusNavigationScopeOwnedByShadowHost.
+(WebCore::FocusNavigationScope::scopeOwnedByIFrame): Ditto. Renamed from focusNavigationScopeOwnedByIFrame.
+(WebCore::FocusController::findFocusableElementDescendingDownIntoFrameDocument):
+(WebCore::FocusController::advanceFocusInDocumentOrder):
+(WebCore::FocusController::findFocusableElementAcrossFocusScope): Define currentScope inside the loop now that
+the copy constructor of FocusNavigationScope no longer exists (since m_treeScope is a reference).
+(WebCore::FocusController::findFocusableElementRecursively):
+(WebCore::nextElementWithGreaterTabIndex):
+(WebCore::FocusController::nextFocusableElement):
+(WebCore::FocusController::previousFocusableElement):
+
 2016-02-24  Adam Bergkvist  
 
 WebRTC: Add MediaEndpoint interface (WebRTC backend abstraction)


Modified: trunk/Source/WebCore/page/FocusController.cpp (197054 => 197055)

--- trunk/Source/WebCore/page/FocusController.cpp	2016-02-24 23:19:18 UTC (rev 197054)
+++ trunk/Source/WebCore/page/FocusController.cpp	2016-02-24 23:37:51 UTC (rev 197055)
@@ -69,11 +69,11 @@
 
 class FocusNavigationScope {
 public:
-ContainerNode* rootNode() const;
+ContainerNode& rootNode() const;
 Element* owner() const;
-WEBCORE_EXPORT static FocusNavigationScope focusNavigationScopeOf(Node*);
-static FocusNavigationScope focusNavigationScopeOwnedByShadowHost(Node*);
-static FocusNavigationScope focusNavigationScopeOwnedByIFrame(HTMLFrameOwnerElement*);
+WEBCORE_EXPORT static FocusNavigationScope scopeOf(Node&);
+static FocusNavigationScope scopeOwnedByShadowHost(Element&);
+static FocusNavigationScope scopeOwnedByIFrame(HTMLFrameOwnerElement&);
 
 Node* nextInScope(const Node*) const;
 Node* previousInScope(const Node*) const;
@@ -82,8 +82,8 @@
 private:
 Node* firstChildInScope(const Node*) const;
 
-explicit FocusNavigationScope(TreeScope*);
-TreeScope* m_rootTreeScope;
+explicit FocusNavigationScope(TreeScope&);
+TreeScope& m_rootTreeScope;
 };
 
 // FIXME: Focus navigation should work with shadow trees that have slots.
@@ -137,50 +137,47 @@
 return parentInScope(node);
 }
 
-FocusNavigationScope::FocusNavigationScope(TreeScope* treeScope)
+FocusNavigationScope::FocusNavigationScope(TreeScope& 

[webkit-changes] [197054] trunk/Source/WebKit2

[barraclough]

Title: [197054] trunk/Source/WebKit2








Revision 197054
Author barraclo...@apple.com
Date 2016-02-24 15:19:18 -0800 (Wed, 24 Feb 2016)


Log Message
Add WKPreference for HiddenPageDOMTimerThrottlingAutoIncreases
https://bugs.webkit.org/show_bug.cgi?id=154655

Reviewed by Geoff Garen.

Just plumbing WebCore.settings.setHiddenPageDOMTimerThrottlingAutoIncreases through as
WKPreferencesSetHiddenPageDOMTimerThrottlingAutoIncreases.

* Shared/WebPreferencesDefinitions.h:
* UIProcess/API/C/WKPreferences.cpp:
(WKPreferencesSetHiddenPageDOMTimerThrottlingAutoIncreases):
(WKPreferencesGetHiddenPageDOMTimerThrottlingAutoIncreases):
* UIProcess/API/C/WKPreferencesRefPrivate.h:
* UIProcess/API/Cocoa/WKPreferences.mm:
(-[WKPreferences _hiddenPageDOMTimerThrottlingAutoIncreases]):
(-[WKPreferences _setHiddenPageDOMTimerThrottlingAutoIncreases:]):
* UIProcess/API/Cocoa/WKPreferencesPrivate.h:
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updatePreferences):

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/Shared/WebPreferencesDefinitions.h
trunk/Source/WebKit2/UIProcess/API/C/WKPreferences.cpp
trunk/Source/WebKit2/UIProcess/API/C/WKPreferencesRefPrivate.h
trunk/Source/WebKit2/UIProcess/API/Cocoa/WKPreferences.mm
trunk/Source/WebKit2/UIProcess/API/Cocoa/WKPreferencesPrivate.h
trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp




Diff

Modified: trunk/Source/WebKit2/ChangeLog (197053 => 197054)

--- trunk/Source/WebKit2/ChangeLog	2016-02-24 22:23:53 UTC (rev 197053)
+++ trunk/Source/WebKit2/ChangeLog	2016-02-24 23:19:18 UTC (rev 197054)
@@ -1,3 +1,25 @@
+2016-02-24  Gavin Barraclough  
+
+Add WKPreference for HiddenPageDOMTimerThrottlingAutoIncreases
+https://bugs.webkit.org/show_bug.cgi?id=154655
+
+Reviewed by Geoff Garen.
+
+Just plumbing WebCore.settings.setHiddenPageDOMTimerThrottlingAutoIncreases through as
+WKPreferencesSetHiddenPageDOMTimerThrottlingAutoIncreases.
+
+* Shared/WebPreferencesDefinitions.h:
+* UIProcess/API/C/WKPreferences.cpp:
+(WKPreferencesSetHiddenPageDOMTimerThrottlingAutoIncreases):
+(WKPreferencesGetHiddenPageDOMTimerThrottlingAutoIncreases):
+* UIProcess/API/C/WKPreferencesRefPrivate.h:
+* UIProcess/API/Cocoa/WKPreferences.mm:
+(-[WKPreferences _hiddenPageDOMTimerThrottlingAutoIncreases]):
+(-[WKPreferences _setHiddenPageDOMTimerThrottlingAutoIncreases:]):
+* UIProcess/API/Cocoa/WKPreferencesPrivate.h:
+* WebProcess/WebPage/WebPage.cpp:
+(WebKit::WebPage::updatePreferences):
+
 2016-02-24  Alex Christensen  
 
 Fix downloads when using NetworkSession


Modified: trunk/Source/WebKit2/Shared/WebPreferencesDefinitions.h (197053 => 197054)

--- trunk/Source/WebKit2/Shared/WebPreferencesDefinitions.h	2016-02-24 22:23:53 UTC (rev 197053)
+++ trunk/Source/WebKit2/Shared/WebPreferencesDefinitions.h	2016-02-24 23:19:18 UTC (rev 197054)
@@ -199,6 +199,7 @@
 macro(ShowsURLsInToolTipsEnabled, showsURLsInToolTipsEnabled, Bool, bool, false) \
 macro(AcceleratedCompositingForOverflowScrollEnabled, acceleratedCompositingForOverflowScrollEnabled, Bool, bool, false) \
 macro(HiddenPageDOMTimerThrottlingEnabled, hiddenPageDOMTimerThrottlingEnabled, Bool, bool, DEFAULT_HIDDEN_PAGE_DOM_TIMER_THROTTLING_ENABLED) \
+macro(HiddenPageDOMTimerThrottlingAutoIncreases, hiddenPageDOMTimerThrottlingAutoIncreases, Bool, bool, false) \
 macro(HiddenPageCSSAnimationSuspensionEnabled, hiddenPageCSSAnimationSuspensionEnabled, Bool, bool, DEFAULT_HIDDEN_PAGE_CSS_ANIMATION_SUSPENSION_ENABLED) \
 macro(LowPowerVideoAudioBufferSizeEnabled, lowPowerVideoAudioBufferSizeEnabled, Bool, bool, false) \
 macro(ThreadedScrollingEnabled, threadedScrollingEnabled, Bool, bool, true) \


Modified: trunk/Source/WebKit2/UIProcess/API/C/WKPreferences.cpp (197053 => 197054)

--- trunk/Source/WebKit2/UIProcess/API/C/WKPreferences.cpp	2016-02-24 22:23:53 UTC (rev 197053)
+++ trunk/Source/WebKit2/UIProcess/API/C/WKPreferences.cpp	2016-02-24 23:19:18 UTC (rev 197054)
@@ -1172,11 +1172,21 @@
 toImpl(preferencesRef)->setHiddenPageDOMTimerThrottlingEnabled(enabled);
 }
 
+void WKPreferencesSetHiddenPageDOMTimerThrottlingAutoIncreases(WKPreferencesRef preferencesRef, bool enabled)
+{
+toImpl(preferencesRef)->setHiddenPageDOMTimerThrottlingAutoIncreases(enabled);
+}
+
 bool WKPreferencesGetHiddenPageDOMTimerThrottlingEnabled(WKPreferencesRef preferencesRef)
 {
 return toImpl(preferencesRef)->hiddenPageDOMTimerThrottlingEnabled();
 }
 
+bool WKPreferencesGetHiddenPageDOMTimerThrottlingAutoIncreases(WKPreferencesRef preferencesRef)
+{
+return toImpl(preferencesRef)->hiddenPageDOMTimerThrottlingAutoIncreases();
+}
+
 void WKPreferencesSetHiddenPageCSSAnimationSuspensionEnabled(WKPreferencesRef preferencesRef, bool enabled)
 {
 

[webkit-changes] [197052] trunk/LayoutTests

[ryanhaddad]

Title: [197052] trunk/LayoutTests








Revision 197052
Author ryanhad...@apple.com
Date 2016-02-24 14:22:12 -0800 (Wed, 24 Feb 2016)


Log Message
Marking storage/indexeddb/odd-strings.html as flaky on mac-wk1
https://bugs.webkit.org/show_bug.cgi?id=154619

Unreviewed test gardening.

* platform/mac-wk1/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac-wk1/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (197051 => 197052)

--- trunk/LayoutTests/ChangeLog	2016-02-24 22:11:49 UTC (rev 197051)
+++ trunk/LayoutTests/ChangeLog	2016-02-24 22:22:12 UTC (rev 197052)
@@ -1,5 +1,14 @@
 2016-02-24  Ryan Haddad  
 
+Marking storage/indexeddb/odd-strings.html as flaky on mac-wk1
+https://bugs.webkit.org/show_bug.cgi?id=154619
+
+Unreviewed test gardening.
+
+* platform/mac-wk1/TestExpectations:
+
+2016-02-24  Ryan Haddad  
+
 Marking imported/w3c/indexeddb/idbcursor-advance.htm as flaky on Yosemite Release WK2
 https://bugs.webkit.org/show_bug.cgi?id=154618
 


Modified: trunk/LayoutTests/platform/mac-wk1/TestExpectations (197051 => 197052)

--- trunk/LayoutTests/platform/mac-wk1/TestExpectations	2016-02-24 22:11:49 UTC (rev 197051)
+++ trunk/LayoutTests/platform/mac-wk1/TestExpectations	2016-02-24 22:22:12 UTC (rev 197052)
@@ -66,6 +66,8 @@
 
 webkit.org/b/154297 [ Debug ] fast/events/keydown-1.html [ Pass Failure ]
 
+webkit.org/b/154619 storage/indexeddb/odd-strings.html [ Pass Timeout ]
+
 ### END OF (1) Failures with bug reports
 
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [197051] trunk/LayoutTests

[ryanhaddad]

Title: [197051] trunk/LayoutTests








Revision 197051
Author ryanhad...@apple.com
Date 2016-02-24 14:11:49 -0800 (Wed, 24 Feb 2016)


Log Message
Marking imported/w3c/indexeddb/idbcursor-advance.htm as flaky on Yosemite Release WK2
https://bugs.webkit.org/show_bug.cgi?id=154618

Unreviewed test gardening.

* platform/mac-wk2/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac-wk2/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (197050 => 197051)

--- trunk/LayoutTests/ChangeLog	2016-02-24 21:44:00 UTC (rev 197050)
+++ trunk/LayoutTests/ChangeLog	2016-02-24 22:11:49 UTC (rev 197051)
@@ -1,3 +1,12 @@
+2016-02-24  Ryan Haddad  
+
+Marking imported/w3c/indexeddb/idbcursor-advance.htm as flaky on Yosemite Release WK2
+https://bugs.webkit.org/show_bug.cgi?id=154618
+
+Unreviewed test gardening.
+
+* platform/mac-wk2/TestExpectations:
+
 2016-02-24  Youenn Fablet  
 
 [Fetch API] Implement Fetch API Response


Modified: trunk/LayoutTests/platform/mac-wk2/TestExpectations (197050 => 197051)

--- trunk/LayoutTests/platform/mac-wk2/TestExpectations	2016-02-24 21:44:00 UTC (rev 197050)
+++ trunk/LayoutTests/platform/mac-wk2/TestExpectations	2016-02-24 22:11:49 UTC (rev 197051)
@@ -499,6 +499,7 @@
 
 webkit.org/b/153849 [ Yosemite Release ] imported/w3c/indexeddb/idbcursor-direction-index-keyrange.htm [ Skip ]
 webkit.org/b/153848 [ Yosemite Release ] imported/w3c/indexeddb/idbcursor-advance-invalid.htm [ Skip ]
+webkit.org/b/154618 [ Yosemite Release ] imported/w3c/indexeddb/idbcursor-advance.htm [ Pass Timeout ]
 
 ### END OF (5) IndexedDB related failures
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [197050] trunk/Source/WebKit2

[achristensen]

Title: [197050] trunk/Source/WebKit2








Revision 197050
Author achristen...@apple.com
Date 2016-02-24 13:44:00 -0800 (Wed, 24 Feb 2016)


Log Message
Fix downloads when using NetworkSession
https://bugs.webkit.org/show_bug.cgi?id=154620

Reviewed by Brady Eidson.

This fixes all the _WKDownload API tests when using NetworkSession.

* NetworkProcess/Downloads/DownloadManager.cpp:
(WebKit::DownloadManager::willDecidePendingDownloadDestination):
When we store the NetworkDataTask in m_downloadsWaitingForDestination, we want to remove its owner
from m_pendingDownloads to prevent memory leaks.
(WebKit::DownloadManager::continueDecidePendingDownloadDestination):
If a file exists and the UIProcess has told us to overwrite the file, delete the file
before starting a new download in its place.  This used to be done by CFNetwork in
NSURLDownload's setDestination:allowOverwrite:, but the NSURLSession equivalent (setting
NSURLSessionDataTask's _pathToDownloadTaskFile attribute) does not overwrite the file for us.
(WebKit::DownloadManager::cancelDownload):
If a download is canceled while it is waiting for its destination from the UIProcess, the Download
object does not exist yet.  Instead, we have a completion handler stored in m_downloadsWaitingForDestination.
In this case, we want to send the UIProcess a DownloadProxy::DidCancel message, which I did through
NetworkProcess::pendingDownloadCanceled because the DownloadManager is not a MessageSender, and then
call the completion handler with PolicyIgnore to cancel the download.
(WebKit::DownloadManager::downloadFinished):
* NetworkProcess/Downloads/DownloadManager.h:
* NetworkProcess/Downloads/PendingDownload.cpp:
(WebKit::PendingDownload::continueCanAuthenticateAgainstProtectionSpace):
(WebKit::PendingDownload::didBecomeDownload):
(WebKit::PendingDownload::didFailLoading):
(WebKit::PendingDownload::messageSenderConnection):
(WebKit::PendingDownload::didConvertToDownload): Deleted.
* NetworkProcess/Downloads/PendingDownload.h:
* NetworkProcess/Downloads/cocoa/DownloadCocoa.mm:
(WebKit::Download::cancel):
Send a didCancel message to the UIProcess when a download was cancelled.
Use cancelByProducingResumeData so we can resume canceled downloads.
* NetworkProcess/NetworkConnectionToWebProcess.cpp:
(WebKit::NetworkConnectionToWebProcess::convertMainResourceLoadToDownload):
didConvertToDownload is needed when using NetworkSession to tell the NetworkResourceLoader
not to call cancel on the NetworkLoad after converting it to a download.
* NetworkProcess/NetworkDataTask.h:
(WebKit::NetworkDataTask::setPendingDownload):
(WebKit::NetworkDataTask::pendingDownloadLocation):
* NetworkProcess/NetworkLoad.cpp:
(WebKit::NetworkLoad::convertTaskToDownload):
(WebKit::NetworkLoad::setPendingDownloadID):
(WebKit::NetworkLoad::didReceiveResponseNetworkSession):
Don't call findPendingDownloadLocation as a method on the NetworkDataTask to avoid memory leaks
in DownloadManager.m_pendingDownloads.
(WebKit::NetworkLoad::didBecomeDownload):
Call m_client.didBecomeDownload which is being separated from didConvertToDownload.  The former is
called after the NetworkDataTask becomes a Download, the latter is called as soon as 
convertMainResourceLoadToDownload is called.
* NetworkProcess/NetworkLoadClient.h:
* NetworkProcess/NetworkProcess.cpp:
(WebKit::NetworkProcess::continueWillSendRequest):
(WebKit::NetworkProcess::pendingDownloadCanceled):
Send a DownloadProxy::DidCancel message when a pending download is canceled.
(WebKit::NetworkProcess::findPendingDownloadLocation):
(WebKit::NetworkProcess::continueDecidePendingDownloadDestination):
* NetworkProcess/NetworkProcess.h:
* NetworkProcess/NetworkProcess.messages.in:
* NetworkProcess/NetworkResourceLoader.cpp:
(WebKit::NetworkResourceLoader::didConvertToDownload):
(WebKit::NetworkResourceLoader::didBecomeDownload):
Separate setting m_didConvertToDownload, which needs to happen before the didReceiveResponse completion
handler is called to tell the NetworkResourceLoader not to call cancel in NetworkResourceLoader::abort,
from deleting the NetworkLoad, which can be done after the NSURLSessionDataTask has been converted to a
NSURLSessionDownloadTask.
* NetworkProcess/NetworkResourceLoader.h:
* NetworkProcess/cache/NetworkCacheSpeculativeLoad.h:
* NetworkProcess/cocoa/NetworkDataTaskCocoa.mm:
(WebKit::NetworkDataTask::failureTimerFired):
(WebKit::NetworkDataTask::setPendingDownloadLocation):
(WebKit::NetworkDataTask::transferSandboxExtensionToDownload):
(WebKit::NetworkDataTask::suggestedFilename):
(WebKit::NetworkDataTask::currentRequest):
(WebKit::NetworkDataTask::findPendingDownloadLocation): Deleted.
* NetworkProcess/cocoa/NetworkSessionCocoa.mm:
(-[WKNetworkSessionDelegate URLSession:task:didCompleteWithError:]):
Take the downloadID if it failed because we will report that download as failed and not use it again.
(WebKit::NetworkSession::takeDownloadID):
* UIProcess/Downloads/DownloadProxy.cpp:

[webkit-changes] [197049] trunk

[youenn . fablet]

Title: [197049] trunk








Revision 197049
Author youenn.fab...@crf.canon.fr
Date 2016-02-24 13:41:51 -0800 (Wed, 24 Feb 2016)


Log Message
[Fetch API] Implement Fetch API Response
https://bugs.webkit.org/show_bug.cgi?id=154536

Reviewed by Alex Christensen.

LayoutTests/imported/w3c:

New tests covering fetch API.

* web-platform-tests/fetch/api/response/response-clone-expected.txt: Added.
* web-platform-tests/fetch/api/response/response-clone.html: Added.
* web-platform-tests/fetch/api/response/response-consume-expected.txt: Added.
* web-platform-tests/fetch/api/response/response-consume.html: Added.
* web-platform-tests/fetch/api/response/response-error-expected.txt: Added.
* web-platform-tests/fetch/api/response/response-error.html: Added.
* web-platform-tests/fetch/api/response/response-idl-expected.txt: Added.
* web-platform-tests/fetch/api/response/response-idl.html: Added.
* web-platform-tests/fetch/api/response/response-init-001-expected.txt: Added.
* web-platform-tests/fetch/api/response/response-init-001.html: Added.
* web-platform-tests/fetch/api/response/response-init-002-expected.txt: Added.
* web-platform-tests/fetch/api/response/response-init-002.html: Added.
* web-platform-tests/fetch/api/response/response-static-error-expected.txt: Added.
* web-platform-tests/fetch/api/response/response-static-error.html: Added.
* web-platform-tests/fetch/api/response/response-static-redirect-expected.txt: Added.
* web-platform-tests/fetch/api/response/response-static-redirect.html: Added.

Source/WebCore:

Tests: imported/w3c/web-platform-tests/fetch/api/response/response-clone.html
   imported/w3c/web-platform-tests/fetch/api/response/response-consume.html
   imported/w3c/web-platform-tests/fetch/api/response/response-error.html
   imported/w3c/web-platform-tests/fetch/api/response/response-idl.html
   imported/w3c/web-platform-tests/fetch/api/response/response-init-001.html
   imported/w3c/web-platform-tests/fetch/api/response/response-init-002.html
   imported/w3c/web-platform-tests/fetch/api/response/response-static-error.html
   imported/w3c/web-platform-tests/fetch/api/response/response-static-redirect.html

Adding Fetch Response as FetchResponse class.
Constructor uses a built-in to pre-process the parameters.
Support of body as ReadableStream is missing.

* CMakeLists.txt:
* DerivedSources.make:
* Modules/fetch/FetchBody.h:
(WebCore::FetchBody::empty):
* Modules/fetch/FetchResponse.cpp: Added.
(WebCore::JSFetchResponse::body):
(WebCore::isRedirectStatus):
(WebCore::isNullBodyStatus):
(WebCore::FetchResponse::error):
(WebCore::FetchResponse::redirect):
(WebCore::FetchResponse::initializeWith):
(WebCore::FetchResponse::FetchResponse):
(WebCore::FetchResponse::clone):
(WebCore::FetchResponse::type):
* Modules/fetch/FetchResponse.h: Added.
(WebCore::FetchResponse::create):
(WebCore::FetchResponse::redirect):
(WebCore::FetchResponse::url):
(WebCore::FetchResponse::redirected):
(WebCore::FetchResponse::status):
(WebCore::FetchResponse::ok):
(WebCore::FetchResponse::statusText):
(WebCore::FetchResponse::headers):
(WebCore::FetchResponse::isDisturbed):
(WebCore::FetchResponse::arrayBuffer):
(WebCore::FetchResponse::formData):
(WebCore::FetchResponse::blob):
(WebCore::FetchResponse::json):
(WebCore::FetchResponse::text):
* Modules/fetch/FetchResponse.idl: Added.
* Modules/fetch/FetchResponse.js: Added.
(initializeFetchResponse):
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/WebCoreJSBuiltins.cpp:
* bindings/js/WebCoreJSBuiltins.h:
(WebCore::JSBuiltinFunctions::JSBuiltinFunctions):
(WebCore::JSBuiltinFunctions::fetchResponseBuiltins):

LayoutTests:

Adding Response as constructor in global and worker scopes.

* js/dom/global-constructors-attributes-dedicated-worker-expected.txt:
* js/dom/global-constructors-attributes-expected.txt:
* platform/efl/js/dom/global-constructors-attributes-dedicated-worker-expected.txt:
* platform/efl/js/dom/global-constructors-attributes-expected.txt:
* platform/gtk/js/dom/global-constructors-attributes-expected.txt:
* platform/mac-mavericks/js/dom/global-constructors-attributes-expected.txt:
* platform/mac-yosemite/js/dom/global-constructors-attributes-expected.txt:
* platform/mac/js/dom/global-constructors-attributes-expected.txt:
* platform/win/js/dom/global-constructors-attributes-expected.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/imported/w3c/ChangeLog
trunk/LayoutTests/js/dom/global-constructors-attributes-dedicated-worker-expected.txt
trunk/LayoutTests/js/dom/global-constructors-attributes-expected.txt
trunk/LayoutTests/platform/efl/js/dom/global-constructors-attributes-dedicated-worker-expected.txt
trunk/LayoutTests/platform/efl/js/dom/global-constructors-attributes-expected.txt
trunk/LayoutTests/platform/gtk/js/dom/global-constructors-attributes-expected.txt
trunk/LayoutTests/platform/mac/js/dom/global-constructors-attributes-expected.txt

[webkit-changes] [197047] branches/safari-601-branch/LayoutTests

[ryanhaddad]

Title: [197047] branches/safari-601-branch/LayoutTests








Revision 197047
Author ryanhad...@apple.com
Date 2016-02-24 13:37:22 -0800 (Wed, 24 Feb 2016)


Log Message
Rebaseline fast/text/small-caps-web-font.html for Mavericks. rdar://problem/24748533

* platform/mac-mavericks/fast/text/small-caps-web-font-expected.png: Added.

Modified Paths

branches/safari-601-branch/LayoutTests/ChangeLog


Added Paths

branches/safari-601-branch/LayoutTests/platform/mac-mavericks/fast/text/small-caps-web-font-expected.png




Diff

Modified: branches/safari-601-branch/LayoutTests/ChangeLog (197046 => 197047)

--- branches/safari-601-branch/LayoutTests/ChangeLog	2016-02-24 21:29:53 UTC (rev 197046)
+++ branches/safari-601-branch/LayoutTests/ChangeLog	2016-02-24 21:37:22 UTC (rev 197047)
@@ -1,3 +1,9 @@
+2016-02-24  Ryan Haddad  
+
+Rebaseline fast/text/small-caps-web-font.html for Mavericks. rdar://problem/24748533
+
+* platform/mac-mavericks/fast/text/small-caps-web-font-expected.png: Added.
+
 2016-02-22  Matthew Hanson  
 
 Rebaseline Mavericks expected results for emoji tests. rdar://problem/24724222


Added: branches/safari-601-branch/LayoutTests/platform/mac-mavericks/fast/text/small-caps-web-font-expected.png (0 => 197047)

--- branches/safari-601-branch/LayoutTests/platform/mac-mavericks/fast/text/small-caps-web-font-expected.png	(rev 0)
+++ branches/safari-601-branch/LayoutTests/platform/mac-mavericks/fast/text/small-caps-web-font-expected.png	2016-02-24 21:37:22 UTC (rev 197047)
@@ -0,0 +1,51 @@
+\x89PNG
+
++IHDR X\x9Av\x82p)tEXtchecksum38115f85ffeda49ebd118e8fef0b16ae{\xBA\xD9@IDATx
\xED\xDD	\xDC=\xED\?\xF0yx\xB2UH*[\xF65d\xC9Nd\xA9xe)\xFB\x96-d'"D\x94\xBDl\xA9\x90}ɚ\xA5\xAC\xB2dKD\x91RQ\x8Ah-\x9A\xFF\xF5\xB9v\xC4\xE4~\xF4\xA3\xBE\xF8\xC5/\xD1\xEF\xE4\xF8a\xC7\xE1/\xFE\xE2/\x8E\xFA\xAC\xFF\xF3?\xFF\xF3\xF0W\xF5W\xC7\xFB\xFF\xF1\xC3\xDF\xFD\xDD\xDFm,\xB3\xAB/\xB3\x9D\x
 FF\xD7\xFD׾\xE1\xFF\xEC\xCF\xFElx\xDF\xFB\xDE7\xFC\xCF\xFF\xFCϾeOj\xF6۾\xBF\xFE\xF5\xAF\xFC\xC7\xB4\xEF\xF6\xFD\xAEw\xBDk\xB8\xECe/{\xB2\xDFN\xB6\xBDW\xB9t}\xFAf\xD8?o\xDB\xF5\xB0\xF1>\xF0\x81\xBB\xD8ņ\xDB\xDD\xEEv+Cl\xF3\x98qr\xAAGl\xD3m\xBE`r,\xFF\xCE\xEF\xFC\xCE\xE1\xB7\xFB\xB7罛޿\xFF\xFD\xEF.s\x99\xCB7\xBC\xE1+\x9B\xCA\xCDBI\xAA\xB6Y\xEF>Q\xF6\xE5l\xD5\xC6\xEEG~\xE4Gƿ\xF9\x9B\xBFY\x949\xCDiN3\x96+o\xF1\xF9	Ox\xC2X\xF0X\xCE\xC4\xE4\xB4\xD7X\xCE
+,\xBE[~S2\xDB\xF1_\xFF\xF5_\x97{7}~\xE3\xDF\xD8TnS\xA1\xAF}\xEDk\xE3\xDB\xDE\xF6\xB6ME\xB6\xFAݕ\xAF|\xE5\xF1\x9E\xF7\xBC\xE7Vc\x9E\x94\x82-{\x96J\xE2x\xC9K^\xF2Г\xF8\x91\x8F|d,g)=\xFC\xB6\xBC\xFC\xE5/\xC4r+g\xEA\xBA\xFD\xCEw\xBEs[\xA38f\xE3<\xF9\xC9O\xCFr\x96\xB3\xF5\xE9/\xFD\xF1\x9F\xF8\xC4\xE3]^_.r\x91\x8B\x8C\x8Fzԣ\x8E(s4>\xBC\xE3\xEF\xA8\xEBǦu\xF7%/y\xC9XN\xE0\xD4\xC9)\x89\xCAX\x92\xD9\xEEI[\xDE\xFE0\xAEW\xB8\xC2\x83\xBE\xE65\xAF\xA9\xF3\xF2\xFA׿~\xD1/\xDF\xE9K_\xF7۾\xFF\xF7\xFFw\xFC\xA3?\xFA\xA3\xC5py\xB3\x8Dy\xC9\xF8\xB6\xE7 Ӿ벫\[֧e\x8B\xFD\x96߮\xE7c\xD7\xF1\xB7QGh\x9D\xC6{\xDC\xE3㕮t\xA5\xB5ŷy\xCC8\xB1\xEB\xCB\xFBٵ3\xBD\x85/\xB6\xE96\x9F\x9Crrj|ғ\x9E4\xEF\xD5\xFC\xFE\xF1\x8F\xFC\x98\xE1O\x8Aݶ\xEB\xDDG{\xB1\xEF\x90\xFB\xDE\xF7\xBE\xF5\xEC޺\xCC\xEE\xA7\xFA\xA7\x87\x8B^\xF4\xA2÷|˷\xAC+\xB2\xE8\x9Fr\xA7?\xFD\xE9\x9F\xA77e\xC1NoW\xBE\xFE\xD6o\xFD\xD6\xF0s?\xF7s+\xBF[\xD73g\x88\xE6]\x9A<\xFC\xE4O\xFE䐳I\xBB\xE8\xCAAbO\x
 D8S\x9F\xFA\xD4\xF5\xEC\xE1\x9E/\xD0c?\x9B)\xD4\xF2\xFCN\xFDw\xF5\xBAʳe

[webkit-changes] [197048] branches/safari-601-branch/LayoutTests

[ryanhaddad]

Title: [197048] branches/safari-601-branch/LayoutTests








Revision 197048
Author ryanhad...@apple.com
Date 2016-02-24 13:37:24 -0800 (Wed, 24 Feb 2016)


Log Message
Rebaseline fast/writing-mode/broken-ideograph-small-caps.html for Mavericks. rdar://problem/24748658

* platform/mac-mavericks/fast/writing-mode/broken-ideograph-small-caps-expected.txt:

Modified Paths

branches/safari-601-branch/LayoutTests/ChangeLog
branches/safari-601-branch/LayoutTests/platform/mac-mavericks/fast/writing-mode/broken-ideograph-small-caps-expected.txt




Diff

Modified: branches/safari-601-branch/LayoutTests/ChangeLog (197047 => 197048)

--- branches/safari-601-branch/LayoutTests/ChangeLog	2016-02-24 21:37:22 UTC (rev 197047)
+++ branches/safari-601-branch/LayoutTests/ChangeLog	2016-02-24 21:37:24 UTC (rev 197048)
@@ -1,5 +1,11 @@
 2016-02-24  Ryan Haddad  
 
+Rebaseline fast/writing-mode/broken-ideograph-small-caps.html for Mavericks. rdar://problem/24748658
+
+* platform/mac-mavericks/fast/writing-mode/broken-ideograph-small-caps-expected.txt:
+
+2016-02-24  Ryan Haddad  
+
 Rebaseline fast/text/small-caps-web-font.html for Mavericks. rdar://problem/24748533
 
 * platform/mac-mavericks/fast/text/small-caps-web-font-expected.png: Added.


Modified: branches/safari-601-branch/LayoutTests/platform/mac-mavericks/fast/writing-mode/broken-ideograph-small-caps-expected.txt (197047 => 197048)

--- branches/safari-601-branch/LayoutTests/platform/mac-mavericks/fast/writing-mode/broken-ideograph-small-caps-expected.txt	2016-02-24 21:37:22 UTC (rev 197047)
+++ branches/safari-601-branch/LayoutTests/platform/mac-mavericks/fast/writing-mode/broken-ideograph-small-caps-expected.txt	2016-02-24 21:37:24 UTC (rev 197048)
@@ -6,17 +6,15 @@
   RenderBlock {DIV} at (0,0) size 556x277 [bgcolor=#EE]
 RenderBlock {DIV} at (1,1) size 277x129 [bgcolor=#FF]
   RenderBlock {P} at (14,28) size 249x23 [bgcolor=#FF] [border: none (20px solid #FF) none (20px solid #FF)]
-RenderText {#text} at (21,1) size 176x20
-  text run at (21,1) width 176: "\x{7B2C}\x{4E00}\x{6BB5}\x{843D} Paragraph 1"
+RenderText {#text} at (21,1) size 200x20
+  text run at (21,1) width 200: "\x{7B2C}\x{4E00}\x{6BB5}\x{843D} Paragraph 1"
   RenderBlock {P} at (14,78) size 249x22 [bgcolor=#FF] [border: none (20px solid #FF) none (20px solid #FF)]
-RenderText {#text} at (21,1) size 176x20
-  text run at (21,1) width 176: "\x{7B2C}\x{4E8C}\x{6BB5}\x{843D} Paragraph 2"
+RenderText {#text} at (21,1) size 200x20
+  text run at (21,1) width 200: "\x{7B2C}\x{4E8C}\x{6BB5}\x{843D} Paragraph 2"
 RenderBlock {DIV} at (278,1) size 277x275 [bgcolor=#EE]
-  RenderBlock {P} at (14,28) size 83x219 [bgcolor=#FF] [border: none (20px solid #FF) none (20px solid #FF)]
-RenderText {#text} at (21,1) size 40x207
-  text run at (21,1) width 207: "\x{7B2C}\x{4E00}\x{6BB5}\x{843D} Paragraph"
-  text run at (41,1) width 10: "1"
-  RenderBlock {P} at (110,28) size 83x219 [bgcolor=#FF] [border: none (20px solid #FF) none (20px solid #FF)]
-RenderText {#text} at (21,1) size 40x207
-  text run at (21,1) width 207: "\x{7B2C}\x{4E8C}\x{6BB5}\x{843D} Paragraph"
-  text run at (41,1) width 10: "2"
+  RenderBlock {P} at (14,28) size 63x219 [bgcolor=#FF] [border: none (20px solid #FF) none (20px solid #FF)]
+RenderText {#text} at (21,1) size 20x207
+  text run at (21,1) width 207: "\x{7B2C}\x{4E00}\x{6BB5}\x{843D} Paragraph 1"
+  RenderBlock {P} at (90,28) size 63x219 [bgcolor=#FF] [border: none (20px solid #FF) none (20px solid #FF)]
+RenderText {#text} at (21,1) size 20x213
+  text run at (21,1) width 213: "\x{7B2C}\x{4E8C}\x{6BB5}\x{843D} Paragraph 2"






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [197046] trunk/Source/WebInspectorUI

[timothy]

Title: [197046] trunk/Source/WebInspectorUI








Revision 197046
Author timo...@apple.com
Date 2016-02-24 13:29:53 -0800 (Wed, 24 Feb 2016)


Log Message
Web Inspector: Remove unused Profile.png images

https://bugs.webkit.org/show_bug.cgi?id=154647
rdar://problem/24820825

Reviewed by Brian Burg.

* UserInterface/Images/Profile.png: Removed.
* UserInterface/Images/prof...@2x.png: Removed.
* UserInterface/Images/gtk/Profile.png: Removed.
* UserInterface/Images/gtk/prof...@2x.png: Removed.
* UserInterface/Views/TimelineIcons.css:
(.profile-icon .icon): Deleted.

Modified Paths

trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/Views/TimelineIcons.css


Removed Paths

trunk/Source/WebInspectorUI/UserInterface/Images/Profile.png
trunk/Source/WebInspectorUI/UserInterface/Images/prof...@2x.png
trunk/Source/WebInspectorUI/UserInterface/Images/gtk/Profile.png
trunk/Source/WebInspectorUI/UserInterface/Images/gtk/prof...@2x.png




Diff

Modified: trunk/Source/WebInspectorUI/ChangeLog (197045 => 197046)

--- trunk/Source/WebInspectorUI/ChangeLog	2016-02-24 21:01:34 UTC (rev 197045)
+++ trunk/Source/WebInspectorUI/ChangeLog	2016-02-24 21:29:53 UTC (rev 197046)
@@ -1,3 +1,19 @@
+2016-02-24  Timothy Hatcher  
+
+Web Inspector: Remove unused Profile.png images
+
+https://bugs.webkit.org/show_bug.cgi?id=154647
+rdar://problem/24820825
+
+Reviewed by Brian Burg.
+
+* UserInterface/Images/Profile.png: Removed.
+* UserInterface/Images/prof...@2x.png: Removed.
+* UserInterface/Images/gtk/Profile.png: Removed.
+* UserInterface/Images/gtk/prof...@2x.png: Removed.
+* UserInterface/Views/TimelineIcons.css:
+(.profile-icon .icon): Deleted.
+
 2016-02-24  Matt Baker  
 
 Web Inspector: TimelineViews should use the recording's end time when entire ruler range is selected


Deleted: trunk/Source/WebInspectorUI/UserInterface/Images/Profile.png (197045 => 197046)

--- trunk/Source/WebInspectorUI/UserInterface/Images/Profile.png	2016-02-24 21:01:34 UTC (rev 197045)
+++ trunk/Source/WebInspectorUI/UserInterface/Images/Profile.png	2016-02-24 21:29:53 UTC (rev 197046)
@@ -1,27 +0,0 @@
-\x89PNG
-
--IHDR\xF3\xFFa\x99iTXtXML:com.adobe.xmp
-   
-  
- 
-
-   Copyright © 2013 Apple Inc. All rights reserved.
-
- 
-  
-  
- Adobe ImageReady
-  
-   
-
-Yp\xC5
\xFAIDAT8u\x92\xDBn\xD3@\x86\xFF]\xC7$'VL\ \x85\xAA\xA0\xB4\xE2(\xE1\xE8/\x92\x8B\xBCH\xDE%\x97yZ.\x90@\xAA\xAAB\xAB\x82Z$JHb㜃\xCD\xCCҵ\x9Cʬ4^\xCF\xC1\xDF\xFC\x9E]\x86!x	!vh\xCB)'\xE1Au\xEF\xC2Hł\xB9\x8B\xCF'G\xEC\x8FF#
-\x85(u|z\xCE-^\xE2\xAA\xF0<\xBE\xEF#\x95\xFA\x97\xE2\xD8d2A\xBF\xDF?\xA2\xF7ATM\x8F0\x8F\xE1O|HC\xC2\xFB\xED\xE9H)\x91\xCDfrx\x88\xDAv]u\x87p'\xF4\xFAo\x91N\xA7\x95-yEJ9\xB0
\xE0N,]\x9B&\x86\x81v\xBB\xAD\\xD34y:\xC8\xC5b\x81\xD5j\x85N\xA7\xA3$\xEF\xEE\xEE\xC1\xBCe\xA2V\xAB\xA1T*\xC1\xB6md2\xB4Z-\x99Z
5-\|\xF9
-\x93\xBA\xFF8w\x94\xCBe\xDCT\x91X\xD8\xF8\xFF\xAF\xBE}\xC7\xF6\xC3:\x9E=\xD8B\xDE.\xA0\xD7\xEB\x81\x85\x8Dk\xB5\x82-\x80eY\xC8\xE7\xF31\xF0\xE4\xE9sܡb\xBBt[\x8F\xF7\xB0^\xAFU\x8Ek\xE2\x80\xF8\x94\xCE\xF2,:\xFF\xFB\xF5G\xD40\xBC\xFC\x81\xF9|\xAE\xBA\xB3\xC2\xFF
\xE4l6~-8\xFBt\x8C \xD8A\x88\xE7g'\xEAv2\x84/\xADH\xF9\x86\x95\xA1\xFB/\xF6\xD1\xEDv\xF1\xE1\xE3{\x9E\xEB\xE2\xF5\xC1\x81\x9A7\xA0\xCD`pMG\xB5ZE\xB3لKJ)`Y9,\x97K\xFEP+H\xA8\xB3\xE7\xA2\xE9t\x8Ab\xB1\x88J\xA5®Z\x83\xC1 \xCA\xEB\xEFq.)xC\xB1\xDBd 197046)

--- trunk/Source/WebInspectorUI/UserInterface/Images/prof...@2x.png	2016-02-24 21:01:34 UTC (rev 197045)
+++ trunk/Source/WebInspectorUI/UserInterface/Images/prof...@2x.png	2016-02-24 21:29:53 UTC (rev 197046)
@@ -1,28 +0,0 @@
-\x89PNG
-
--IHDR  szz\xF4\x99iTXtXML:com.adobe.xmp
-   
-  
- 
-
-   Copyright © 2013 Apple Inc. All rights reserved.
-
- 
-  
-  
- Adobe ImageReady
-  
-   
-
-Yp\xC5zIDATX	\xADWKOdE>\xFD\xA6y6\xD0(axt\x93qa\xD8c;\xF4\x94I\x9C\xD1\x9Cw\xC6+\xFE!Y8l\x8Ca\xE3\xCEdLt\xA1'\x91Dt\xA24h\x84\x90ȣ
\xE8\xD0\xF4\xBB\xDB\xF3T{\xB9\xD4&\xF1\x84\xA2\xEE\xAD:\x8F\xAFΫn\x9B
-\x85i\xC9d2\xBD\xCA\xEF\xED\xDA5\x9F\x8F\x98o\x83\xF5m^\x93_\xB0Y̞\xB5?_+\xD6\xC5R$\xA1jW5
x>\x9F\xA7l6K\xF1\xD3S\xCAd\xF3\x9F|:\xF3\xE0\xDE\xDB0\x92ׯ\xAB\x98\xC1t||\xAC\xE7\xEF\xF1\x938Y-V
 r\xE24\xA7\xA3x\xA2nbbb2\x9DN\xDB\xC4W\xD7\xA1`#\x93\x89\xFFLJX\x97\xB0\x98\xCDd\xB3\xD9(q\xA2\xA3\xA3#\xC7\xF4\xF4\xF4\xAC_\x84
-\x80\xB6\x8D\xF0Fq\xCF\xCC\xC6a\xCCf\xB7\x93\xC3n\xA3\xE0\xF66\xB5\xB7\xB7[\xA7\xA6\xA6\xE4r9Va\xFA\xF2*O\xA8\x88\x93
\xC0\xBAv 

[webkit-changes] [197045] trunk/Source

[bshafiei]

Title: [197045] trunk/Source








Revision 197045
Author bshaf...@apple.com
Date 2016-02-24 13:01:34 -0800 (Wed, 24 Feb 2016)


Log Message
Versioning.

Modified Paths

trunk/Source/_javascript_Core/Configurations/Version.xcconfig
trunk/Source/WebCore/Configurations/Version.xcconfig
trunk/Source/WebInspectorUI/Configurations/Version.xcconfig
trunk/Source/WebKit/mac/Configurations/Version.xcconfig
trunk/Source/WebKit2/Configurations/Version.xcconfig




Diff

Modified: trunk/Source/_javascript_Core/Configurations/Version.xcconfig (197044 => 197045)

--- trunk/Source/_javascript_Core/Configurations/Version.xcconfig	2016-02-24 21:00:07 UTC (rev 197044)
+++ trunk/Source/_javascript_Core/Configurations/Version.xcconfig	2016-02-24 21:01:34 UTC (rev 197045)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 602;
 MINOR_VERSION = 1;
-TINY_VERSION = 20;
+TINY_VERSION = 21;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: trunk/Source/WebCore/Configurations/Version.xcconfig (197044 => 197045)

--- trunk/Source/WebCore/Configurations/Version.xcconfig	2016-02-24 21:00:07 UTC (rev 197044)
+++ trunk/Source/WebCore/Configurations/Version.xcconfig	2016-02-24 21:01:34 UTC (rev 197045)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 602;
 MINOR_VERSION = 1;
-TINY_VERSION = 20;
+TINY_VERSION = 21;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: trunk/Source/WebInspectorUI/Configurations/Version.xcconfig (197044 => 197045)

--- trunk/Source/WebInspectorUI/Configurations/Version.xcconfig	2016-02-24 21:00:07 UTC (rev 197044)
+++ trunk/Source/WebInspectorUI/Configurations/Version.xcconfig	2016-02-24 21:01:34 UTC (rev 197045)
@@ -1,6 +1,6 @@
 MAJOR_VERSION = 602;
 MINOR_VERSION = 1;
-TINY_VERSION = 20;
+TINY_VERSION = 21;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: trunk/Source/WebKit/mac/Configurations/Version.xcconfig (197044 => 197045)

--- trunk/Source/WebKit/mac/Configurations/Version.xcconfig	2016-02-24 21:00:07 UTC (rev 197044)
+++ trunk/Source/WebKit/mac/Configurations/Version.xcconfig	2016-02-24 21:01:34 UTC (rev 197045)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 602;
 MINOR_VERSION = 1;
-TINY_VERSION = 20;
+TINY_VERSION = 21;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: trunk/Source/WebKit2/Configurations/Version.xcconfig (197044 => 197045)

--- trunk/Source/WebKit2/Configurations/Version.xcconfig	2016-02-24 21:00:07 UTC (rev 197044)
+++ trunk/Source/WebKit2/Configurations/Version.xcconfig	2016-02-24 21:01:34 UTC (rev 197045)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 602;
 MINOR_VERSION = 1;
-TINY_VERSION = 20;
+TINY_VERSION = 21;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [197044] tags/Safari-602.1.20/

[bshafiei]

Title: [197044] tags/Safari-602.1.20/








Revision 197044
Author bshaf...@apple.com
Date 2016-02-24 13:00:07 -0800 (Wed, 24 Feb 2016)


Log Message
New tag.

Added Paths

tags/Safari-602.1.20/




Diff

Property changes: tags/Safari-602.1.20



Added: svn:ignore
depcomp
compile
config.guess
GNUmakefile.in
config.sub
ltmain.sh
aconfig.h.in
autom4te.cache
missing
aclocal.m4
install-sh
autotoolsconfig.h.in
INSTALL
README
gtk-doc.make
out
Makefile.chromium
WebKitSupportLibrary.zip
WebKitBuild

Added: svn:mergeinfo




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [197043] trunk

[commit-queue]

Title: [197043] trunk








Revision 197043
Author commit-qu...@webkit.org
Date 2016-02-24 12:46:44 -0800 (Wed, 24 Feb 2016)


Log Message
Unreviewed, rolling out r197033.
https://bugs.webkit.org/show_bug.cgi?id=154649

"It broke JSC tests when 'this' was loaded from global scope"
(Requested by saamyjoon on #webkit).

Reverted changeset:

"[ES6] Arrow function syntax. Emit loading this/super
only if they are used in arrow function"
https://bugs.webkit.org/show_bug.cgi?id=153981
http://trac.webkit.org/changeset/197033

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/js/regress/script-tests/arrowfunction-call.js
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/bytecode/ExecutableInfo.h
trunk/Source/_javascript_Core/bytecode/UnlinkedCodeBlock.cpp
trunk/Source/_javascript_Core/bytecode/UnlinkedCodeBlock.h
trunk/Source/_javascript_Core/bytecode/UnlinkedFunctionExecutable.cpp
trunk/Source/_javascript_Core/bytecode/UnlinkedFunctionExecutable.h
trunk/Source/_javascript_Core/bytecompiler/BytecodeGenerator.cpp
trunk/Source/_javascript_Core/bytecompiler/BytecodeGenerator.h
trunk/Source/_javascript_Core/bytecompiler/NodesCodegen.cpp
trunk/Source/_javascript_Core/parser/ASTBuilder.h
trunk/Source/_javascript_Core/parser/Nodes.cpp
trunk/Source/_javascript_Core/parser/Nodes.h
trunk/Source/_javascript_Core/parser/Parser.cpp
trunk/Source/_javascript_Core/parser/Parser.h
trunk/Source/_javascript_Core/parser/ParserModes.h
trunk/Source/_javascript_Core/parser/SourceProviderCacheItem.h
trunk/Source/_javascript_Core/parser/SyntaxChecker.h
trunk/Source/_javascript_Core/tests/stress/arrowfunction-lexical-bind-arguments-non-strict-1.js
trunk/Source/_javascript_Core/tests/stress/arrowfunction-lexical-bind-arguments-strict.js
trunk/Source/_javascript_Core/tests/stress/arrowfunction-lexical-bind-newtarget.js
trunk/Source/_javascript_Core/tests/stress/arrowfunction-lexical-bind-superproperty.js


Removed Paths

trunk/LayoutTests/js/regress/arrowfunction-call-in-class-constructor-expected.txt
trunk/LayoutTests/js/regress/arrowfunction-call-in-class-constructor.html
trunk/LayoutTests/js/regress/arrowfunction-call-in-class-method-expected.txt
trunk/LayoutTests/js/regress/arrowfunction-call-in-class-method.html
trunk/LayoutTests/js/regress/arrowfunction-call-in-function-expected.txt
trunk/LayoutTests/js/regress/arrowfunction-call-in-function.html
trunk/LayoutTests/js/regress/script-tests/arrowfunction-call-in-class-constructor.js
trunk/LayoutTests/js/regress/script-tests/arrowfunction-call-in-class-method.js
trunk/LayoutTests/js/regress/script-tests/arrowfunction-call-in-function.js
trunk/Source/_javascript_Core/tests/stress/arrowfunction-lexical-bind-this-8.js




Diff

Modified: trunk/LayoutTests/ChangeLog (197042 => 197043)

--- trunk/LayoutTests/ChangeLog	2016-02-24 20:43:21 UTC (rev 197042)
+++ trunk/LayoutTests/ChangeLog	2016-02-24 20:46:44 UTC (rev 197043)
@@ -1,3 +1,18 @@
+2016-02-24  Commit Queue  
+
+Unreviewed, rolling out r197033.
+https://bugs.webkit.org/show_bug.cgi?id=154649
+
+"It broke JSC tests when 'this' was loaded from global scope"
+(Requested by saamyjoon on #webkit).
+
+Reverted changeset:
+
+"[ES6] Arrow function syntax. Emit loading this/super
+only if they are used in arrow function"
+https://bugs.webkit.org/show_bug.cgi?id=153981
+http://trac.webkit.org/changeset/197033
+
 2016-02-24  Daniel Bates  
 
 CSP: Enable plugin-types directive by default


Deleted: trunk/LayoutTests/js/regress/arrowfunction-call-in-class-constructor-expected.txt (197042 => 197043)

--- trunk/LayoutTests/js/regress/arrowfunction-call-in-class-constructor-expected.txt	2016-02-24 20:43:21 UTC (rev 197042)
+++ trunk/LayoutTests/js/regress/arrowfunction-call-in-class-constructor-expected.txt	2016-02-24 20:46:44 UTC (rev 197043)
@@ -1,10 +0,0 @@
-JSRegress/arrowfunction-call-in-class-constructor
-
-On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
-
-
-PASS no exception thrown
-PASS successfullyParsed is true
-
-TEST COMPLETE
-


Deleted: trunk/LayoutTests/js/regress/arrowfunction-call-in-class-constructor.html (197042 => 197043)

--- trunk/LayoutTests/js/regress/arrowfunction-call-in-class-constructor.html	2016-02-24 20:43:21 UTC (rev 197042)
+++ trunk/LayoutTests/js/regress/arrowfunction-call-in-class-constructor.html	2016-02-24 20:46:44 UTC (rev 197043)
@@ -1,12 +0,0 @@
-
-
-

[webkit-changes] [197042] trunk/Source/JavaScriptCore

[sbarati]

Title: [197042] trunk/Source/_javascript_Core








Revision 197042
Author sbar...@apple.com
Date 2016-02-24 12:43:21 -0800 (Wed, 24 Feb 2016)


Log Message
[ES6] Implement Proxy.[[Delete]]
https://bugs.webkit.org/show_bug.cgi?id=154607

Reviewed by Mark Lam.

This patch implements Proxy.[[Delete]] with respect to section 9.5.10 of the ECMAScript spec.
https://tc39.github.io/ecma262/#sec-proxy-object-internal-methods-and-internal-slots-delete-p

* runtime/ProxyObject.cpp:
(JSC::ProxyObject::getConstructData):
(JSC::ProxyObject::performDelete):
(JSC::ProxyObject::deleteProperty):
(JSC::ProxyObject::deletePropertyByIndex):
* runtime/ProxyObject.h:
* tests/es6.yaml:
* tests/stress/proxy-delete.js: Added.
(assert):
(throw.new.Error.let.handler.get deleteProperty):
(throw.new.Error):
(assert.let.handler.deleteProperty):
(let.handler.deleteProperty):

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/runtime/ProxyObject.cpp
trunk/Source/_javascript_Core/runtime/ProxyObject.h
trunk/Source/_javascript_Core/tests/es6.yaml


Added Paths

trunk/Source/_javascript_Core/tests/stress/proxy-delete.js




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (197041 => 197042)

--- trunk/Source/_javascript_Core/ChangeLog	2016-02-24 20:31:40 UTC (rev 197041)
+++ trunk/Source/_javascript_Core/ChangeLog	2016-02-24 20:43:21 UTC (rev 197042)
@@ -1,3 +1,27 @@
+2016-02-24  Saam Barati  
+
+[ES6] Implement Proxy.[[Delete]]
+https://bugs.webkit.org/show_bug.cgi?id=154607
+
+Reviewed by Mark Lam.
+
+This patch implements Proxy.[[Delete]] with respect to section 9.5.10 of the ECMAScript spec.
+https://tc39.github.io/ecma262/#sec-proxy-object-internal-methods-and-internal-slots-delete-p
+
+* runtime/ProxyObject.cpp:
+(JSC::ProxyObject::getConstructData):
+(JSC::ProxyObject::performDelete):
+(JSC::ProxyObject::deleteProperty):
+(JSC::ProxyObject::deletePropertyByIndex):
+* runtime/ProxyObject.h:
+* tests/es6.yaml:
+* tests/stress/proxy-delete.js: Added.
+(assert):
+(throw.new.Error.let.handler.get deleteProperty):
+(throw.new.Error):
+(assert.let.handler.deleteProperty):
+(let.handler.deleteProperty):
+
 2016-02-24  Filip Pizlo  
 
 Stackmaps have problems with double register constraints


Modified: trunk/Source/_javascript_Core/runtime/ProxyObject.cpp (197041 => 197042)

--- trunk/Source/_javascript_Core/runtime/ProxyObject.cpp	2016-02-24 20:31:40 UTC (rev 197041)
+++ trunk/Source/_javascript_Core/runtime/ProxyObject.cpp	2016-02-24 20:43:21 UTC (rev 197042)
@@ -405,4 +405,75 @@
 return ConstructTypeHost;
 }
 
+template 
+bool ProxyObject::performDelete(ExecState* exec, PropertyName propertyName, DefaultDeleteFunction defaultDeleteFunction)
+{
+VM& vm = exec->vm();
+JSValue handlerValue = this->handler();
+if (handlerValue.isNull()) {
+throwVMTypeError(exec, ASCIILiteral("Proxy 'handler' is null. It should be an Object."));
+return false;
+}
+
+JSObject* handler = jsCast(handlerValue);
+CallData callData;
+CallType callType;
+JSValue deletePropertyMethod = handler->getMethod(exec, callData, callType, makeIdentifier(vm, "deleteProperty"), ASCIILiteral("'deleteProperty' property of a Proxy's handler should be callable."));
+if (exec->hadException())
+return false;
+JSObject* target = this->target();
+if (deletePropertyMethod.isUndefined())
+return defaultDeleteFunction();
+
+MarkedArgumentBuffer arguments;
+arguments.append(target);
+arguments.append(identifierToSafePublicJSValue(vm, Identifier::fromUid(, propertyName.uid(;
+JSValue trapResult = call(exec, deletePropertyMethod, callType, callData, handler, arguments);
+if (exec->hadException())
+return false;
+
+bool trapResultAsBool = trapResult.toBoolean(exec);
+if (exec->hadException())
+return false;
+
+if (!trapResultAsBool)
+return false;
+
+PropertyDescriptor descriptor;
+if (target->getOwnPropertyDescriptor(exec, propertyName, descriptor)) {
+if (!descriptor.configurable()) {
+throwVMTypeError(exec, ASCIILiteral("Proxy handler's 'deleteProperty' method should return false when the target's property is not configurable."));
+return false;
+}
+}
+
+if (exec->hadException())
+return false;
+
+return true;
+}
+
+bool ProxyObject::deleteProperty(JSCell* cell, ExecState* exec, PropertyName propertyName)
+{
+ProxyObject* thisObject = jsCast(cell);
+auto defaultDelete = [&] () -> bool {
+JSObject* target = jsCast(thisObject->target());
+return target->methodTable(exec->vm())->deleteProperty(target, exec, propertyName);
+};
+return thisObject->performDelete(exec, propertyName, 

[webkit-changes] [197041] trunk/Source

[andersca]

Title: [197041] trunk/Source








Revision 197041
Author ander...@apple.com
Date 2016-02-24 12:31:40 -0800 (Wed, 24 Feb 2016)


Log Message
Add more WebKitAdditions extension points
https://bugs.webkit.org/show_bug.cgi?id=154648
rdar://problem/24820040

Reviewed by Beth Dakin.

* Shared/WebPreferencesDefinitions.h:
* UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _initializeWithConfiguration:]):
* UIProcess/API/Cocoa/WKWebViewConfiguration.mm:
(-[WKWebViewConfiguration copyWithZone:]):
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updatePreferences):

Modified Paths

trunk/Source/WebCore/page/Settings.h
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/Shared/WebPreferencesDefinitions.h
trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm
trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebViewConfiguration.mm
trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp




Diff

Modified: trunk/Source/WebCore/page/Settings.h (197040 => 197041)

--- trunk/Source/WebCore/page/Settings.h	2016-02-24 20:26:01 UTC (rev 197040)
+++ trunk/Source/WebCore/page/Settings.h	2016-02-24 20:31:40 UTC (rev 197041)
@@ -287,6 +287,10 @@
 WEBCORE_EXPORT static float defaultMinimumZoomFontSize();
 #endif
 
+#if USE(APPLE_INTERNAL_SDK)
+#import 
+#endif
+
 private:
 explicit Settings(Page*);
 
@@ -381,6 +385,10 @@
 
 static bool gLowPowerVideoAudioBufferSizeEnabled;
 static bool gResourceLoadStatisticsEnabledEnabled;
+
+#if USE(APPLE_INTERNAL_SDK)
+#import 
+#endif
 };
 
 } // namespace WebCore


Modified: trunk/Source/WebKit2/ChangeLog (197040 => 197041)

--- trunk/Source/WebKit2/ChangeLog	2016-02-24 20:26:01 UTC (rev 197040)
+++ trunk/Source/WebKit2/ChangeLog	2016-02-24 20:31:40 UTC (rev 197041)
@@ -1,3 +1,19 @@
+2016-02-24  Anders Carlsson  
+
+Add more WebKitAdditions extension points
+https://bugs.webkit.org/show_bug.cgi?id=154648
+rdar://problem/24820040
+
+Reviewed by Beth Dakin.
+
+* Shared/WebPreferencesDefinitions.h:
+* UIProcess/API/Cocoa/WKWebView.mm:
+(-[WKWebView _initializeWithConfiguration:]):
+* UIProcess/API/Cocoa/WKWebViewConfiguration.mm:
+(-[WKWebViewConfiguration copyWithZone:]):
+* WebProcess/WebPage/WebPage.cpp:
+(WebKit::WebPage::updatePreferences):
+
 2016-02-24  Ryosuke Niwa  
 
 Move FocusNavigationScope into FocusController.cpp


Modified: trunk/Source/WebKit2/Shared/WebPreferencesDefinitions.h (197040 => 197041)

--- trunk/Source/WebKit2/Shared/WebPreferencesDefinitions.h	2016-02-24 20:26:01 UTC (rev 197040)
+++ trunk/Source/WebKit2/Shared/WebPreferencesDefinitions.h	2016-02-24 20:31:40 UTC (rev 197041)
@@ -26,6 +26,14 @@
 #ifndef WebPreferencesDefinitions_h
 #define WebPreferencesDefinitions_h
 
+#if USE(APPLE_INTERNAL_SDK)
+#import 
+#endif
+
+#if !defined(FOR_EACH_ADDITIONAL_WEBKIT_BOOL_PREFERENCE)
+#define FOR_EACH_ADDITIONAL_WEBKIT_BOOL_PREFERENCE(macro)
+#endif
+
 #if PLATFORM(GTK)
 #define DEFAULT_WEBKIT_TABSTOLINKS_ENABLED true
 #else
@@ -216,6 +224,8 @@
 macro(AntialiasedFontDilationEnabled, antialiasedFontDilationEnabled, Bool, bool, false) \
 macro(HTTPEquivEnabled, httpEquivEnabled, Bool, bool, true) \
 macro(MockCaptureDevicesEnabled, mockCaptureDevicesEnabled, Bool, bool, false) \
+FOR_EACH_ADDITIONAL_WEBKIT_BOOL_PREFERENCE(macro) \
+\
 
 #define FOR_EACH_WEBKIT_DOUBLE_PREFERENCE(macro) \
 macro(IncrementalRenderingSuppressionTimeout, incrementalRenderingSuppressionTimeout, Double, double, 5) \


Modified: trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm (197040 => 197041)

--- trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm	2016-02-24 20:26:01 UTC (rev 197040)
+++ trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm	2016-02-24 20:31:40 UTC (rev 197041)
@@ -410,6 +410,10 @@
 pageConfiguration->preferenceValues().set(WebKit::WebPreferencesKey::allowsAirPlayForMediaPlaybackKey(), WebKit::WebPreferencesStore::Value(!![_configuration allowsAirPlayForMediaPlayback]));
 #endif
 
+#if USE(APPLE_INTERNAL_SDK)
+#import 
+#endif
+
 #if PLATFORM(IOS)
 CGRect bounds = self.bounds;
 _scrollView = adoptNS([[WKScrollView alloc] initWithFrame:bounds]);


Modified: trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebViewConfiguration.mm (197040 => 197041)

--- trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebViewConfiguration.mm	2016-02-24 20:26:01 UTC (rev 197040)
+++ trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebViewConfiguration.mm	2016-02-24 20:31:40 UTC (rev 197041)
@@ -112,6 +112,10 @@
 BOOL _serviceControlsEnabled;
 BOOL _imageControlsEnabled;
 #endif
+
+#if USE(APPLE_INTERNAL_SDK)
+#import 
+#endif
 }
 
 - (instancetype)init
@@ -252,6 +256,10 @@
 configuration->_allowsAirPlayForMediaPlayback = self->_allowsAirPlayForMediaPlayback;
 #endif
 
+#if USE(APPLE_INTERNAL_SDK)
+#import 
+#endif
+
 return configuration;
 }
 
@@ -573,6 +581,10 @@
 }
 #endif // PLATFORM(MAC)
 
+#if 

[webkit-changes] [197040] trunk/Source/WebCore

[rniwa]

Title: [197040] trunk/Source/WebCore








Revision 197040
Author rn...@webkit.org
Date 2016-02-24 12:26:01 -0800 (Wed, 24 Feb 2016)


Log Message
A function named canTakeNextToken executing blocking scripts is misleading
https://bugs.webkit.org/show_bug.cgi?id=154636

Reviewed by Darin Adler.

Merged canTakeNextToken into pumpTokenizer and extracted pumpTokenizerLoop out of pumpTokenizer.

Inlined m_parserChunkSize in HTMLParserScheduler into checkForYieldBeforeToken, and removed needsYield
from PumpSession in favor of making checkForYieldBeforeToken and checkForYieldBeforeScript return a bool.

No new tests since this is a pure refactoring.

* html/parser/HTMLDocumentParser.cpp:
(WebCore::HTMLDocumentParser::canTakeNextToken): Deleted.
(WebCore::HTMLDocumentParser::pumpTokenizerLoop): Extracted from pumpTokenizer. We don't have to check
isStopped() at the beginning since pumpTokenizer asserts that. Return true when session.needsYield would
have been set to true in the old code and return false elsewhere (for stopping or incomplete token).
(WebCore::HTMLDocumentParser::pumpTokenizer):
* html/parser/HTMLDocumentParser.h:
* html/parser/HTMLParserScheduler.cpp:
(WebCore::PumpSession::PumpSession):
(WebCore::HTMLParserScheduler::HTMLParserScheduler):
(WebCore::HTMLParserScheduler::shouldYieldBeforeExecutingScript): Renamed from checkForYieldBeforeScript.
* html/parser/HTMLParserScheduler.h:
(WebCore::HTMLParserScheduler::shouldYieldBeforeToken): Renamed from checkForYieldBeforeToken.
(WebCore::HTMLParserScheduler::isScheduledForResume):
(WebCore::HTMLParserScheduler::checkForYield): Extracted from checkForYieldBeforeToken. Reset
processedTokens to 1 instead of setting it to 0 here and incrementing it later as done in the old code.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/parser/HTMLDocumentParser.cpp
trunk/Source/WebCore/html/parser/HTMLDocumentParser.h
trunk/Source/WebCore/html/parser/HTMLParserScheduler.cpp
trunk/Source/WebCore/html/parser/HTMLParserScheduler.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (197039 => 197040)

--- trunk/Source/WebCore/ChangeLog	2016-02-24 20:19:47 UTC (rev 197039)
+++ trunk/Source/WebCore/ChangeLog	2016-02-24 20:26:01 UTC (rev 197040)
@@ -1,3 +1,34 @@
+2016-02-24  Ryosuke Niwa  
+
+A function named canTakeNextToken executing blocking scripts is misleading
+https://bugs.webkit.org/show_bug.cgi?id=154636
+
+Reviewed by Darin Adler.
+
+Merged canTakeNextToken into pumpTokenizer and extracted pumpTokenizerLoop out of pumpTokenizer.
+
+Inlined m_parserChunkSize in HTMLParserScheduler into checkForYieldBeforeToken, and removed needsYield
+from PumpSession in favor of making checkForYieldBeforeToken and checkForYieldBeforeScript return a bool.
+
+No new tests since this is a pure refactoring.
+
+* html/parser/HTMLDocumentParser.cpp:
+(WebCore::HTMLDocumentParser::canTakeNextToken): Deleted.
+(WebCore::HTMLDocumentParser::pumpTokenizerLoop): Extracted from pumpTokenizer. We don't have to check
+isStopped() at the beginning since pumpTokenizer asserts that. Return true when session.needsYield would
+have been set to true in the old code and return false elsewhere (for stopping or incomplete token).
+(WebCore::HTMLDocumentParser::pumpTokenizer):
+* html/parser/HTMLDocumentParser.h:
+* html/parser/HTMLParserScheduler.cpp:
+(WebCore::PumpSession::PumpSession):
+(WebCore::HTMLParserScheduler::HTMLParserScheduler):
+(WebCore::HTMLParserScheduler::shouldYieldBeforeExecutingScript): Renamed from checkForYieldBeforeScript.
+* html/parser/HTMLParserScheduler.h:
+(WebCore::HTMLParserScheduler::shouldYieldBeforeToken): Renamed from checkForYieldBeforeToken.
+(WebCore::HTMLParserScheduler::isScheduledForResume):
+(WebCore::HTMLParserScheduler::checkForYield): Extracted from checkForYieldBeforeToken. Reset
+processedTokens to 1 instead of setting it to 0 here and incrementing it later as done in the old code.
+
 2016-02-24  Daniel Bates  
 
 CSP: Enable plugin-types directive by default


Modified: trunk/Source/WebCore/html/parser/HTMLDocumentParser.cpp (197039 => 197040)

--- trunk/Source/WebCore/html/parser/HTMLDocumentParser.cpp	2016-02-24 20:19:47 UTC (rev 197039)
+++ trunk/Source/WebCore/html/parser/HTMLDocumentParser.cpp	2016-02-24 20:26:01 UTC (rev 197040)
@@ -196,38 +196,6 @@
 }
 }
 
-bool HTMLDocumentParser::canTakeNextToken(SynchronousMode mode, PumpSession& session)
-{
-if (isStopped())
-return false;
-
-if (isWaitingForScripts()) {
-if (mode == AllowYield)
-m_parserScheduler->checkForYieldBeforeScript(session);
-
-// If we don't run the script, we cannot allow the next token to be taken.
-if (session.needsYield)
-return false;
-
-// If we're 

[webkit-changes] [197039] trunk/Source/WebInspectorUI

[mattbaker]

Title: [197039] trunk/Source/WebInspectorUI








Revision 197039
Author mattba...@apple.com
Date 2016-02-24 12:19:47 -0800 (Wed, 24 Feb 2016)


Log Message
Web Inspector: TimelineViews should use the recording's end time when entire ruler range is selected
https://bugs.webkit.org/show_bug.cgi?id=154644


Reviewed by Timothy Hatcher.

* UserInterface/Views/TimelineRecordingContentView.js:
(WebInspector.TimelineRecordingContentView):
(WebInspector.TimelineRecordingContentView.prototype._currentContentViewDidChange):
(WebInspector.TimelineRecordingContentView.prototype._timeRangeSelectionChanged):
Update current timeline view when entire range selected.

(WebInspector.TimelineRecordingContentView.prototype._updateTimes):
Live-update the OverviewTimelineView during recording when entire range selected.

(WebInspector.TimelineRecordingContentView.prototype._updateTimelineViewSelection):
Update timeline view start and end times. When entire range selected, use the recording
end time or current time (while capturing).

Modified Paths

trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/Views/TimelineRecordingContentView.js




Diff

Modified: trunk/Source/WebInspectorUI/ChangeLog (197038 => 197039)

--- trunk/Source/WebInspectorUI/ChangeLog	2016-02-24 18:51:58 UTC (rev 197038)
+++ trunk/Source/WebInspectorUI/ChangeLog	2016-02-24 20:19:47 UTC (rev 197039)
@@ -1,3 +1,24 @@
+2016-02-24  Matt Baker  
+
+Web Inspector: TimelineViews should use the recording's end time when entire ruler range is selected
+https://bugs.webkit.org/show_bug.cgi?id=154644
+
+
+Reviewed by Timothy Hatcher.
+
+* UserInterface/Views/TimelineRecordingContentView.js:
+(WebInspector.TimelineRecordingContentView):
+(WebInspector.TimelineRecordingContentView.prototype._currentContentViewDidChange):
+(WebInspector.TimelineRecordingContentView.prototype._timeRangeSelectionChanged):
+Update current timeline view when entire range selected.
+
+(WebInspector.TimelineRecordingContentView.prototype._updateTimes):
+Live-update the OverviewTimelineView during recording when entire range selected.
+
+(WebInspector.TimelineRecordingContentView.prototype._updateTimelineViewSelection):
+Update timeline view start and end times. When entire range selected, use the recording
+end time or current time (while capturing).
+
 2016-02-24  Timothy Hatcher  
 
 Follow up fix for the TimelineRuler "select all" mode to fix zeroTime.


Modified: trunk/Source/WebInspectorUI/UserInterface/Views/TimelineRecordingContentView.js (197038 => 197039)

--- trunk/Source/WebInspectorUI/UserInterface/Views/TimelineRecordingContentView.js	2016-02-24 18:51:58 UTC (rev 197038)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/TimelineRecordingContentView.js	2016-02-24 20:19:47 UTC (rev 197039)
@@ -336,8 +336,7 @@
 this._timelineSidebarPanel.contentTreeOutlineLabel = timelineView.navigationSidebarTreeOutlineLabel;
 this._timelineSidebarPanel.contentTreeOutlineScopeBar = timelineView.navigationSidebarTreeOutlineScopeBar;
 
-timelineView.startTime = this._timelineOverview.selectionStartTime;
-timelineView.endTime = this._timelineOverview.selectionStartTime + this._timelineOverview.selectionDuration;
+this._updateTimelineViewSelection(timelineView);
 timelineView.currentTime = this._currentTime;
 }
 
@@ -419,6 +418,9 @@
 if (this.currentTimelineView)
 this.currentTimelineView.currentTime = currentTime;
 
+if (this._timelineOverview.timelineRuler.entireRangeSelected)
+this._updateTimelineViewSelection(this._overviewTimelineView);
+
 this._timelineSidebarPanel.updateFilter();
 
 // Force a layout now since we are already in an animation frame and don't need to delay it until the next.
@@ -622,8 +624,7 @@
 _timeRangeSelectionChanged(event)
 {
 if (this.currentTimelineView) {
-this.currentTimelineView.startTime = this._timelineOverview.selectionStartTime;
-this.currentTimelineView.endTime = this._timelineOverview.selectionStartTime + this._timelineOverview.selectionDuration;
+this._updateTimelineViewSelection(this.currentTimelineView);
 
 if (this.currentTimelineView.representedObject.type === WebInspector.TimelineRecord.Type.RenderingFrame)
 this._updateFrameSelection();
@@ -677,6 +678,25 @@
 let endIndex = startIndex + this._timelineOverview.selectionDuration - 1;
 this._timelineSidebarPanel.updateFrameSelection(startIndex, endIndex);
 }
+
+_updateTimelineViewSelection(timelineView)
+{
+let timelineRuler = this._timelineOverview.timelineRuler;
+let entireRangeSelected = timelineRuler.entireRangeSelected;
+let endTime = 

[webkit-changes] [197038] trunk

[dbates]

Title: [197038] trunk








Revision 197038
Author dba...@webkit.org
Date 2016-02-24 10:51:58 -0800 (Wed, 24 Feb 2016)


Log Message
CSP: Enable plugin-types directive by default
https://bugs.webkit.org/show_bug.cgi?id=154420


Reviewed by Brent Fulgham.

Source/WebCore:

* page/csp/ContentSecurityPolicyDirectiveList.cpp:
(WebCore::isExperimentalDirectiveName): Move plugin-types from the directives considered
experimental to...
(WebCore::isCSPDirectiveName): ...the list of standard directives.
(WebCore::ContentSecurityPolicyDirectiveList::addDirective): Move logic to parse the plugin-types
directive outside the ENABLE(CSP_NEXT) macro guarded section/experimental feature runtime flag.

LayoutTests:

* TestExpectations: Mark http/tests/security/contentSecurityPolicy/1.1/plugintypes*.html tests as PASS so that we run them.
* http/tests/security/contentSecurityPolicy/1.1/plugintypes-invalid-expected.txt: Update expected result.
* http/tests/security/contentSecurityPolicy/1.1/plugintypes-invalid.html: Call runTests() following changes to multiple-iframe-plugin-test.js.
Also add closing tags for  and  to make the document well-formed.
* http/tests/security/contentSecurityPolicy/1.1/plugintypes-mismatched-data.html: Substitute "Content-Security-Policy" for "X-WebKit-CSP";
no behavior change.
* http/tests/security/contentSecurityPolicy/1.1/plugintypes-mismatched-url.html: Ditto.
* http/tests/security/contentSecurityPolicy/1.1/plugintypes-notype-data.html: Ditto.
* http/tests/security/contentSecurityPolicy/1.1/plugintypes-notype-url-expected.txt: Update expected result.
* http/tests/security/contentSecurityPolicy/1.1/plugintypes-notype-url.html: Substitute "Content-Security-Policy" for "X-WebKit-CSP";
no behavior change.
* http/tests/security/contentSecurityPolicy/1.1/plugintypes-nourl-allowed.html: Ditto.
* http/tests/security/contentSecurityPolicy/1.1/plugintypes-nourl-blocked.html: Ditto.
* http/tests/security/contentSecurityPolicy/1.1/plugintypes-url-01.html: Call runTests() following changes to multiple-iframe-plugin-test.js.
Also add closing tags for  and  to make the document well-formed.
* http/tests/security/contentSecurityPolicy/1.1/plugintypes-url-02.html: Ditto.
* http/tests/security/contentSecurityPolicy/resources/echo-object-data.pl: Remove logic to support Content Security Policy header X-WebKit-CSP
as it is sufficient to make use of the standardized header Content-Security-Policy.
* http/tests/security/contentSecurityPolicy/resources/multiple-iframe-plugin-test.js: Simplify code now that we do not pass query string parameter
experimental to script echo-object-data.pl.
(runTests): Runs all the sub-tests.
(runNextTest.iframe.onload): Formerly named testImpl.iframe.onload.
(runNextTest): Formerly named testImpl. Runs the next sub-test.
(testExperimentalPolicy): Deleted.
(test): Deleted.
(testImpl.iframe.onload): Deleted.
(testImpl): Deleted.
(finishTesting): Deleted.
* http/tests/security/contentSecurityPolicy/source-list-parsing-no-semicolon-expected.txt: Update expected result based on change to test (below).
* http/tests/security/contentSecurityPolicy/source-list-parsing-no-semicolon.html: Modified to test that we emit
a console warning when plugin-types is used as a source _expression_.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/TestExpectations
trunk/LayoutTests/http/tests/security/contentSecurityPolicy/1.1/plugintypes-invalid-expected.txt
trunk/LayoutTests/http/tests/security/contentSecurityPolicy/1.1/plugintypes-invalid.html
trunk/LayoutTests/http/tests/security/contentSecurityPolicy/1.1/plugintypes-mismatched-data.html
trunk/LayoutTests/http/tests/security/contentSecurityPolicy/1.1/plugintypes-mismatched-url.html
trunk/LayoutTests/http/tests/security/contentSecurityPolicy/1.1/plugintypes-notype-data.html
trunk/LayoutTests/http/tests/security/contentSecurityPolicy/1.1/plugintypes-notype-url-expected.txt
trunk/LayoutTests/http/tests/security/contentSecurityPolicy/1.1/plugintypes-notype-url.html
trunk/LayoutTests/http/tests/security/contentSecurityPolicy/1.1/plugintypes-nourl-allowed.html
trunk/LayoutTests/http/tests/security/contentSecurityPolicy/1.1/plugintypes-nourl-blocked.html
trunk/LayoutTests/http/tests/security/contentSecurityPolicy/1.1/plugintypes-url-01.html
trunk/LayoutTests/http/tests/security/contentSecurityPolicy/1.1/plugintypes-url-02.html
trunk/LayoutTests/http/tests/security/contentSecurityPolicy/resources/echo-object-data.pl
trunk/LayoutTests/http/tests/security/contentSecurityPolicy/resources/multiple-iframe-plugin-test.js
trunk/LayoutTests/http/tests/security/contentSecurityPolicy/source-list-parsing-no-semicolon-expected.txt
trunk/LayoutTests/http/tests/security/contentSecurityPolicy/source-list-parsing-no-semicolon.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/csp/ContentSecurityPolicyDirectiveList.cpp




Diff

Modified: trunk/LayoutTests/ChangeLog (197037 => 197038)

--- trunk/LayoutTests/ChangeLog	2016-02-24 18:49:45 UTC (rev 197037)

[webkit-changes] [197037] trunk/Source/JavaScriptCore

[fpizlo]

Title: [197037] trunk/Source/_javascript_Core








Revision 197037
Author fpi...@apple.com
Date 2016-02-24 10:49:45 -0800 (Wed, 24 Feb 2016)


Log Message
Stackmaps have problems with double register constraints
https://bugs.webkit.org/show_bug.cgi?id=154643

Reviewed by Geoffrey Garen.

This is currently a benign bug. I found it while playing.

* b3/B3LowerToAir.cpp:
(JSC::B3::Air::LowerToAir::fillStackmap):
* b3/testb3.cpp:
(JSC::B3::testURShiftSelf64):
(JSC::B3::testPatchpointDoubleRegs):
(JSC::B3::zero):
(JSC::B3::run):

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/b3/B3LowerToAir.cpp
trunk/Source/_javascript_Core/b3/testb3.cpp




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (197036 => 197037)

--- trunk/Source/_javascript_Core/ChangeLog	2016-02-24 18:14:41 UTC (rev 197036)
+++ trunk/Source/_javascript_Core/ChangeLog	2016-02-24 18:49:45 UTC (rev 197037)
@@ -1,3 +1,20 @@
+2016-02-24  Filip Pizlo  
+
+Stackmaps have problems with double register constraints
+https://bugs.webkit.org/show_bug.cgi?id=154643
+
+Reviewed by Geoffrey Garen.
+
+This is currently a benign bug. I found it while playing.
+
+* b3/B3LowerToAir.cpp:
+(JSC::B3::Air::LowerToAir::fillStackmap):
+* b3/testb3.cpp:
+(JSC::B3::testURShiftSelf64):
+(JSC::B3::testPatchpointDoubleRegs):
+(JSC::B3::zero):
+(JSC::B3::run):
+
 2016-02-24  Skachkov Oleksandr  
 
 [ES6] Arrow function syntax. Emit loading this/super only if they are used in arrow function


Modified: trunk/Source/_javascript_Core/b3/B3LowerToAir.cpp (197036 => 197037)

--- trunk/Source/_javascript_Core/b3/B3LowerToAir.cpp	2016-02-24 18:14:41 UTC (rev 197036)
+++ trunk/Source/_javascript_Core/b3/B3LowerToAir.cpp	2016-02-24 18:49:45 UTC (rev 197037)
@@ -991,7 +991,7 @@
 case ValueRep::Register:
 stackmap->earlyClobbered().clear(value.rep().reg());
 arg = Tmp(value.rep().reg());
-append(Move, immOrTmp(value.value()), arg);
+append(relaxedMoveForType(value.value()->type()), immOrTmp(value.value()), arg);
 break;
 case ValueRep::StackArgument:
 arg = Arg::callArg(value.rep().offsetFromSP());


Modified: trunk/Source/_javascript_Core/b3/testb3.cpp (197036 => 197037)

--- trunk/Source/_javascript_Core/b3/testb3.cpp	2016-02-24 18:14:41 UTC (rev 197036)
+++ trunk/Source/_javascript_Core/b3/testb3.cpp	2016-02-24 18:49:45 UTC (rev 197037)
@@ -10426,6 +10426,30 @@
 check(64);
 }
 
+void testPatchpointDoubleRegs()
+{
+Procedure proc;
+BasicBlock* root = proc.addBlock();
+
+Value* arg = root->appendNew(proc, Origin(), FPRInfo::argumentFPR0);
+
+PatchpointValue* patchpoint = root->appendNew(proc, Double, Origin());
+patchpoint->append(arg, ValueRep(FPRInfo::fpRegT0));
+patchpoint->resultConstraint = ValueRep(FPRInfo::fpRegT0);
+
+unsigned numCalls = 0;
+patchpoint->setGenerator(
+[&] (CCallHelpers&, const StackmapGenerationParams&) {
+numCalls++;
+});
+
+root->appendNew(proc, Return, Origin(), patchpoint);
+
+auto code = compile(proc);
+CHECK(numCalls == 1);
+CHECK(invoke(*code, 42.5) == 42.5);
+}
+
 // Make sure the compiler does not try to optimize anything out.
 NEVER_INLINE double zero()
 {
@@ -11842,6 +11866,8 @@
 RUN(testURShiftSelf64());
 RUN(testLShiftSelf64());
 
+RUN(testPatchpointDoubleRegs());
+
 if (tasks.isEmpty())
 usage();
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [197036] trunk/LayoutTests

[ryanhaddad]

Title: [197036] trunk/LayoutTests








Revision 197036
Author ryanhad...@apple.com
Date 2016-02-24 10:14:41 -0800 (Wed, 24 Feb 2016)


Log Message
Rebaseline two W3C tests for ios-simulator after r197014

Unreviewed test gardening.

* platform/ios-simulator/imported/w3c/web-platform-tests/html/dom/reflection-embedded-expected.txt:
* platform/ios-simulator/imported/w3c/web-platform-tests/html/dom/reflection-forms-expected.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/ios-simulator/imported/w3c/web-platform-tests/html/dom/reflection-embedded-expected.txt
trunk/LayoutTests/platform/ios-simulator/imported/w3c/web-platform-tests/html/dom/reflection-forms-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (197035 => 197036)

--- trunk/LayoutTests/ChangeLog	2016-02-24 17:56:11 UTC (rev 197035)
+++ trunk/LayoutTests/ChangeLog	2016-02-24 18:14:41 UTC (rev 197036)
@@ -1,3 +1,12 @@
+2016-02-24  Ryan Haddad  
+
+Rebaseline two W3C tests for ios-simulator after r197014
+
+Unreviewed test gardening.
+
+* platform/ios-simulator/imported/w3c/web-platform-tests/html/dom/reflection-embedded-expected.txt:
+* platform/ios-simulator/imported/w3c/web-platform-tests/html/dom/reflection-forms-expected.txt:
+
 2016-02-24  Skachkov Oleksandr  
 
 [ES6] Arrow function syntax. Emit loading this/super only if they are used in arrow function


Modified: trunk/LayoutTests/platform/ios-simulator/imported/w3c/web-platform-tests/html/dom/reflection-embedded-expected.txt (197035 => 197036)

--- trunk/LayoutTests/platform/ios-simulator/imported/w3c/web-platform-tests/html/dom/reflection-embedded-expected.txt	2016-02-24 17:56:11 UTC (rev 197035)
+++ trunk/LayoutTests/platform/ios-simulator/imported/w3c/web-platform-tests/html/dom/reflection-embedded-expected.txt	2016-02-24 18:14:41 UTC (rev 197036)
@@ -563,7 +563,7 @@
 PASS img.tabIndex: setAttribute() to 2147483647 followed by getAttribute() 
 FAIL img.tabIndex: setAttribute() to 2147483647 followed by IDL get assert_equals: expected 2147483647 but got 32767
 PASS img.tabIndex: setAttribute() to -2147483648 followed by getAttribute() 
-FAIL img.tabIndex: setAttribute() to -2147483648 followed by IDL get assert_equals: expected -2147483648 but got 32767
+FAIL img.tabIndex: setAttribute() to -2147483648 followed by IDL get assert_equals: expected -2147483648 but got -32768
 PASS img.tabIndex: setAttribute() to "-1" followed by getAttribute() 
 PASS img.tabIndex: setAttribute() to "-1" followed by IDL get 
 PASS img.tabIndex: setAttribute() to "-0" followed by getAttribute() 
@@ -603,7 +603,7 @@
 FAIL img.tabIndex: IDL set to 2147483647 followed by IDL get assert_equals: expected 2147483647 but got 32767
 PASS img.tabIndex: IDL set to -2147483648 should not throw 
 PASS img.tabIndex: IDL set to -2147483648 followed by getAttribute() 
-FAIL img.tabIndex: IDL set to -2147483648 followed by IDL get assert_equals: expected -2147483648 but got 32767
+FAIL img.tabIndex: IDL set to -2147483648 followed by IDL get assert_equals: expected -2147483648 but got -32768
 PASS img.alt: typeof IDL attribute 
 PASS img.alt: IDL get with DOM attribute unset 
 PASS img.alt: setAttribute() to "" followed by getAttribute() 
@@ -1462,7 +1462,7 @@
 PASS img.hspace: setAttribute() to "\t7" followed by getAttribute() 
 PASS img.hspace: setAttribute() to "\t7" followed by IDL get 
 PASS img.hspace: setAttribute() to "\v7" followed by getAttribute() 
-FAIL img.hspace: setAttribute() to "\v7" followed by IDL get assert_equals: expected 0 but got 7
+PASS img.hspace: setAttribute() to "\v7" followed by IDL get 
 PASS img.hspace: setAttribute() to "\f7" followed by getAttribute() 
 PASS img.hspace: setAttribute() to "\f7" followed by IDL get 
 PASS img.hspace: setAttribute() to " 7" followed by getAttribute() 
@@ -1476,39 +1476,39 @@
 PASS img.hspace: setAttribute() to "\r7" followed by getAttribute() 
 PASS img.hspace: setAttribute() to "\r7" followed by IDL get 
 PASS img.hspace: setAttribute() to "
7" followed by getAttribute() 
-FAIL img.hspace: setAttribute() to "
7" followed by IDL get assert_equals: expected 0 but got 7
+PASS img.hspace: setAttribute() to "
7" followed by IDL get 
 PASS img.hspace: setAttribute() to "
7" followed by getAttribute() 
 PASS img.hspace: setAttribute() to "
7" followed by IDL get 
 PASS img.hspace: setAttribute() to " 7" followed by getAttribute() 
-FAIL img.hspace: setAttribute() to " 7" followed by IDL get assert_equals: expected 0 but got 7
+PASS img.hspace: setAttribute() to " 7" followed by IDL get 
 PASS img.hspace: setAttribute() to "᠎7" followed by getAttribute() 
 PASS img.hspace: setAttribute() to "᠎7" followed by IDL get 
 PASS img.hspace: setAttribute() to " 7" followed by getAttribute() 
-FAIL img.hspace: setAttribute() to " 7" followed by IDL get assert_equals: expected 0 but got 7
+PASS img.hspace: setAttribute() to " 7" followed by IDL get 
 PASS 

[webkit-changes] [197035] trunk/Source/WebInspectorUI

[timothy]

Title: [197035] trunk/Source/WebInspectorUI








Revision 197035
Author timo...@apple.com
Date 2016-02-24 09:56:11 -0800 (Wed, 24 Feb 2016)


Log Message
Follow up fix for the TimelineRuler "select all" mode to fix zeroTime.

https://bugs.webkit.org/show_bug.cgi?id=154561
rdar://problem/24779872

* UserInterface/Views/TimelineRuler.js:
(WebInspector.TimelineRuler.prototype.set zeroTime): Change selectionStartTime
before _zeroTime so the check for entireRangeSelected still works.

Modified Paths

trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/Views/TimelineRuler.js




Diff

Modified: trunk/Source/WebInspectorUI/ChangeLog (197034 => 197035)

--- trunk/Source/WebInspectorUI/ChangeLog	2016-02-24 17:41:42 UTC (rev 197034)
+++ trunk/Source/WebInspectorUI/ChangeLog	2016-02-24 17:56:11 UTC (rev 197035)
@@ -1,3 +1,14 @@
+2016-02-24  Timothy Hatcher  
+
+Follow up fix for the TimelineRuler "select all" mode to fix zeroTime.
+
+https://bugs.webkit.org/show_bug.cgi?id=154561
+rdar://problem/24779872
+
+* UserInterface/Views/TimelineRuler.js:
+(WebInspector.TimelineRuler.prototype.set zeroTime): Change selectionStartTime
+before _zeroTime so the check for entireRangeSelected still works.
+
 2016-02-24  Matt Baker  
 
 Web Inspector: TimelineRuler should have a "select all" mode


Modified: trunk/Source/WebInspectorUI/UserInterface/Views/TimelineRuler.js (197034 => 197035)

--- trunk/Source/WebInspectorUI/UserInterface/Views/TimelineRuler.js	2016-02-24 17:41:42 UTC (rev 197034)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/TimelineRuler.js	2016-02-24 17:56:11 UTC (rev 197035)
@@ -174,10 +174,11 @@
 if (this._zeroTime === x)
 return;
 
-this._zeroTime = x;
 if (this.entireRangeSelected)
-this.selectionStartTime = this._zeroTime;
+this.selectionStartTime = x;
 
+this._zeroTime = x;
+
 this.needsLayout();
 }
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [197034] trunk/Source/WebInspectorUI

[mattbaker]

Title: [197034] trunk/Source/WebInspectorUI








Revision 197034
Author mattba...@apple.com
Date 2016-02-24 09:41:42 -0800 (Wed, 24 Feb 2016)


Log Message
Web Inspector: TimelineRuler should have a "select all" mode
https://bugs.webkit.org/show_bug.cgi?id=154561


Reviewed by Timothy Hatcher.

TimelineRuler is initialized with a selected range of [0, Number.MAX_VALUE),
indicating the entire timeline is selected. This patch makes it possible to
return the ruler to this state, after being overwritten by a custom selection.
When no custom selection exists, the selection handles are hidden.

* UserInterface/Views/TimelineRuler.css:
(.timeline-ruler.selection-hidden > :matches(.selection-drag, .selection-handle, .shaded-area)):
Style for hiding selection controls as needed.

* UserInterface/Views/TimelineRuler.js:
(WebInspector.TimelineRuler):
Represent unbounded selection interval as [0, Number.MAX_VALUE).

(WebInspector.TimelineRuler.prototype.set allowsTimeRangeSelection):
Register double-click event listener.

(WebInspector.TimelineRuler.prototype.set zeroTime):
(WebInspector.TimelineRuler.prototype.get entireRangeSelected):
(WebInspector.TimelineRuler.prototype.selectEntireRange):
Let clients check and set the selection of the entire range without needing
to use the internal sentinel values 0 and Number.MAX_VALUE.

(WebInspector.TimelineRuler.prototype._updateSelection):
Update ruler styles and dispatch selection change event when entire
range is selected.

(WebInspector.TimelineRuler.prototype._handleDoubleClick):
If a user-defined selection exists, select the entire range.

Modified Paths

trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/Views/TimelineRuler.css
trunk/Source/WebInspectorUI/UserInterface/Views/TimelineRuler.js




Diff

Modified: trunk/Source/WebInspectorUI/ChangeLog (197033 => 197034)

--- trunk/Source/WebInspectorUI/ChangeLog	2016-02-24 17:36:12 UTC (rev 197033)
+++ trunk/Source/WebInspectorUI/ChangeLog	2016-02-24 17:41:42 UTC (rev 197034)
@@ -1,3 +1,40 @@
+2016-02-24  Matt Baker  
+
+Web Inspector: TimelineRuler should have a "select all" mode
+https://bugs.webkit.org/show_bug.cgi?id=154561
+
+
+Reviewed by Timothy Hatcher.
+
+TimelineRuler is initialized with a selected range of [0, Number.MAX_VALUE),
+indicating the entire timeline is selected. This patch makes it possible to
+return the ruler to this state, after being overwritten by a custom selection.
+When no custom selection exists, the selection handles are hidden.
+
+* UserInterface/Views/TimelineRuler.css:
+(.timeline-ruler.selection-hidden > :matches(.selection-drag, .selection-handle, .shaded-area)):
+Style for hiding selection controls as needed.
+
+* UserInterface/Views/TimelineRuler.js:
+(WebInspector.TimelineRuler):
+Represent unbounded selection interval as [0, Number.MAX_VALUE).
+
+(WebInspector.TimelineRuler.prototype.set allowsTimeRangeSelection):
+Register double-click event listener.
+
+(WebInspector.TimelineRuler.prototype.set zeroTime):
+(WebInspector.TimelineRuler.prototype.get entireRangeSelected):
+(WebInspector.TimelineRuler.prototype.selectEntireRange):
+Let clients check and set the selection of the entire range without needing
+to use the internal sentinel values 0 and Number.MAX_VALUE.
+
+(WebInspector.TimelineRuler.prototype._updateSelection):
+Update ruler styles and dispatch selection change event when entire
+range is selected.
+
+(WebInspector.TimelineRuler.prototype._handleDoubleClick):
+If a user-defined selection exists, select the entire range.
+
 2016-02-24  Nikita Vasilyev  
 
 Web Inspector: Dim selected items when docked Inspector window is inactive


Modified: trunk/Source/WebInspectorUI/UserInterface/Views/TimelineRuler.css (197033 => 197034)

--- trunk/Source/WebInspectorUI/UserInterface/Views/TimelineRuler.css	2016-02-24 17:36:12 UTC (rev 197033)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/TimelineRuler.css	2016-02-24 17:41:42 UTC (rev 197034)
@@ -178,6 +178,10 @@
 z-index: 15;
 }
 
+.timeline-ruler.selection-hidden > :matches(.selection-drag, .selection-handle, .shaded-area) {
+display: none;
+}
+
 .timeline-ruler > .selection-handle.clamped {
 border-color: hsl(0, 0%, 64%);
 background-color: white;


Modified: trunk/Source/WebInspectorUI/UserInterface/Views/TimelineRuler.js (197033 => 197034)

--- trunk/Source/WebInspectorUI/UserInterface/Views/TimelineRuler.js	2016-02-24 17:36:12 UTC (rev 197033)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/TimelineRuler.js	2016-02-24 17:41:42 UTC (rev 197034)
@@ -45,7 +45,7 @@
 this._duration = NaN;
 this._secondsPerPixel = 0;
 this._selectionStartTime = 0;
-this._selectionEndTime = Infinity;
+   

[webkit-changes] [197033] trunk

[commit-queue]

Title: [197033] trunk








Revision 197033
Author commit-qu...@webkit.org
Date 2016-02-24 09:36:12 -0800 (Wed, 24 Feb 2016)


Log Message
[ES6] Arrow function syntax. Emit loading this/super only if they are used in arrow function
https://bugs.webkit.org/show_bug.cgi?id=153981

Patch by Skachkov Oleksandr  on 2016-02-24
Reviewed by Saam Barati.
Source/_javascript_Core:

In first iteration of implemenation arrow function, we emit load and store variables 'this', 'arguments',
'super', 'new.target' in case if arrow function is exist even variables are not used in arrow function.
Current patch added logic that prevent from emiting those varibles if they are not used in arrow function.
During syntax analyze parser store information about using variables in arrow function inside of
the ordinary function scope and then put to BytecodeGenerator through UnlinkedCodeBlock

* bytecode/ExecutableInfo.h:
(JSC::ExecutableInfo::ExecutableInfo):
(JSC::ExecutableInfo::arrowFunctionCodeFeatures):
* bytecode/UnlinkedCodeBlock.cpp:
(JSC::UnlinkedCodeBlock::UnlinkedCodeBlock):
* bytecode/UnlinkedCodeBlock.h:
(JSC::UnlinkedCodeBlock::arrowFunctionCodeFeatures):
(JSC::UnlinkedCodeBlock::doAnyInnerArrowFunctionsUseArguments):
(JSC::UnlinkedCodeBlock::doAnyInnerArrowFunctionsUseSuperCall):
(JSC::UnlinkedCodeBlock::doAnyInnerArrowFunctionsUseSuperProperty):
(JSC::UnlinkedCodeBlock::doAnyInnerArrowFunctionsUseEval):
(JSC::UnlinkedCodeBlock::doAnyInnerArrowFunctionsUseThis):
(JSC::UnlinkedCodeBlock::doAnyInnerArrowFunctionsUseNewTarget):
* bytecode/UnlinkedFunctionExecutable.cpp:
(JSC::generateUnlinkedFunctionCodeBlock):
(JSC::UnlinkedFunctionExecutable::UnlinkedFunctionExecutable):
* bytecode/UnlinkedFunctionExecutable.h:
* bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::BytecodeGenerator):
(JSC::BytecodeGenerator::initializeArrowFunctionContextScopeIfNeeded):
(JSC::BytecodeGenerator::emitLoadArrowFunctionLexicalEnvironment):
(JSC::BytecodeGenerator::emitLoadThisFromArrowFunctionLexicalEnvironment):
(JSC::BytecodeGenerator::emitLoadNewTargetFromArrowFunctionLexicalEnvironment):
(JSC::BytecodeGenerator::emitLoadDerivedConstructorFromArrowFunctionLexicalEnvironment):
(JSC::BytecodeGenerator::isThisUsedInInnerArrowFunction):
(JSC::BytecodeGenerator::isArgumentsUsedInInnerArrowFunction):
(JSC::BytecodeGenerator::isNewTargetUsedInInnerArrowFunction):
(JSC::BytecodeGenerator::isSuperUsedInInnerArrowFunction):
(JSC::BytecodeGenerator::emitPutNewTargetToArrowFunctionContextScope):
(JSC::BytecodeGenerator::emitPutDerivedConstructorToArrowFunctionContextScope):
(JSC::BytecodeGenerator::emitPutThisToArrowFunctionContextScope):
* bytecompiler/BytecodeGenerator.h:
* bytecompiler/NodesCodegen.cpp:
(JSC::ThisNode::emitBytecode):
(JSC::EvalFunctionCallNode::emitBytecode):
(JSC::FunctionCallValueNode::emitBytecode):
(JSC::FunctionNode::emitBytecode):
* parser/ASTBuilder.h:
(JSC::ASTBuilder::createFunctionMetadata):
* parser/Nodes.cpp:
(JSC::FunctionMetadataNode::FunctionMetadataNode):
* parser/Nodes.h:
* parser/Parser.cpp:
(JSC::Parser::parseGeneratorFunctionSourceElements):
(JSC::Parser::parseFunctionBody):
(JSC::Parser::parseFunctionInfo):
(JSC::Parser::parseProperty):
(JSC::Parser::parsePrimaryExpression):
(JSC::Parser::parseMemberExpression):
* parser/Parser.h:
(JSC::Scope::Scope):
(JSC::Scope::isArrowFunctionBoundary):
(JSC::Scope::innerArrowFunctionFeatures):
(JSC::Scope::setInnerArrowFunctionUseSuperCall):
(JSC::Scope::setInnerArrowFunctionUseSuperProperty):
(JSC::Scope::setInnerArrowFunctionUseEval):
(JSC::Scope::setInnerArrowFunctionUseThis):
(JSC::Scope::setInnerArrowFunctionUseNewTarget):
(JSC::Scope::setInnerArrowFunctionUseArguments):
(JSC::Scope::setInnerArrowFunctionUseEvalAndUseArgumentsIfNeeded):
(JSC::Scope::collectFreeVariables):
(JSC::Scope::mergeInnerArrowFunctionFeatures):
(JSC::Scope::fillParametersForSourceProviderCache):
(JSC::Scope::restoreFromSourceProviderCache):
(JSC::Scope::setIsFunction):
(JSC::Scope::setIsArrowFunction):
(JSC::Parser::closestParentNonArrowFunctionNonLexicalScope):
(JSC::Parser::pushScope):
(JSC::Parser::popScopeInternal):
* parser/ParserModes.h:
* parser/SourceProviderCacheItem.h:
(JSC::SourceProviderCacheItem::SourceProviderCacheItem):
* parser/SyntaxChecker.h:
(JSC::SyntaxChecker::createFunctionMetadata):
* tests/stress/arrowfunction-lexical-bind-arguments-non-strict-1.js:
* tests/stress/arrowfunction-lexical-bind-arguments-strict.js:
* tests/stress/arrowfunction-lexical-bind-newtarget.js:
* tests/stress/arrowfunction-lexical-bind-superproperty.js:
* tests/stress/arrowfunction-lexical-bind-this-8.js: Added.

LayoutTests:

Added new benchmark tests for invoking arrow function within function, class's constructor and method

* js/regress/arrowfunction-call-in-class-constructor-expected.txt: Added.
* js/regress/arrowfunction-call-in-class-constructor.html: Added.
* js/regress/arrowfunction-call-in-class-method-expected.txt: Added.
* 

[webkit-changes] [197032] trunk/Source/WebCore

[ryanhaddad]

Title: [197032] trunk/Source/WebCore








Revision 197032
Author ryanhad...@apple.com
Date 2016-02-24 09:26:52 -0800 (Wed, 24 Feb 2016)


Log Message
Speculative fix for ios build.

Unreviewed build fix.

* bindings/objc/DOM.mm:
(-[DOMNode nextFocusNode]):
(-[DOMNode previousFocusNode]):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/objc/DOM.mm




Diff

Modified: trunk/Source/WebCore/ChangeLog (197031 => 197032)

--- trunk/Source/WebCore/ChangeLog	2016-02-24 17:19:23 UTC (rev 197031)
+++ trunk/Source/WebCore/ChangeLog	2016-02-24 17:26:52 UTC (rev 197032)
@@ -1,3 +1,13 @@
+2016-02-24  Ryan Haddad  
+
+Speculative fix for ios build.
+
+Unreviewed build fix.
+
+* bindings/objc/DOM.mm:
+(-[DOMNode nextFocusNode]):
+(-[DOMNode previousFocusNode]):
+
 2016-02-24  Zalan Bujtas  
 
 Background of an absolutely positioned inline element inside text-indented parent is positioned statically.


Modified: trunk/Source/WebCore/bindings/objc/DOM.mm (197031 => 197032)

--- trunk/Source/WebCore/bindings/objc/DOM.mm	2016-02-24 17:19:23 UTC (rev 197031)
+++ trunk/Source/WebCore/bindings/objc/DOM.mm	2016-02-24 17:26:52 UTC (rev 197032)
@@ -520,7 +520,7 @@
 
 // FIXME: using KeyboardEvent::createForDummy() here should be deprecated,
 // should use one that is not for bindings.
-return kit(page->focusController().nextFocusableElement(*core(self));
+return kit(page->focusController().nextFocusableElement(*core(self)));
 }
 
 - (DOMNode *)previousFocusNode
@@ -531,7 +531,7 @@
 
 // FIXME: using KeyboardEvent::createForDummy() here should be deprecated,
 // should use one that is not for bindings.
-return kit(page->focusController().previousFocusableElement(*core(self));
+return kit(page->focusController().previousFocusableElement(*core(self)));
 }
 
 #endif // PLATFORM(IOS)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [197030] trunk

[zalan]

Title: [197030] trunk








Revision 197030
Author za...@apple.com
Date 2016-02-24 09:13:33 -0800 (Wed, 24 Feb 2016)


Log Message
Background of an absolutely positioned inline element inside text-indented parent is positioned statically.
https://bugs.webkit.org/show_bug.cgi?id=154019

Reviewed by Simon Fraser.

This patch ensures that statically positioned out-of-flow renderers are also text-aligned
even when none of the renderers on the first line generate a linebox (so we end up with no bidi runs at all).
The fix is to pass IndentTextOrNot information to startAlignedOffsetForLine through updateStaticInlinePositionForChild
so that we can compute the left position for this statically positioned out of flow renderer.

Source/WebCore:

Test: fast/css3-text/css3-text-indent/text-indent-with-absolute-pos-child.html

* rendering/RenderBlockFlow.cpp:
(WebCore::RenderBlockFlow::adjustPositionedBlock):
(WebCore::RenderBlockFlow::updateStaticInlinePositionForChild):
* rendering/RenderBlockFlow.h:
* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlockFlow::layoutRunsAndFloatsInRange):
(WebCore::RenderBlockFlow::startAlignedOffsetForLine):
* rendering/line/LineBreaker.cpp:
(WebCore::LineBreaker::skipTrailingWhitespace):
(WebCore::LineBreaker::skipLeadingWhitespace):
* rendering/line/LineInlineHeaders.h: webkit.org/b/154628 fixes the bool vs IndentTextOrNot issue.
(WebCore::setStaticPositions):

LayoutTests:

* fast/css3-text/css3-text-indent/text-indent-with-absolute-pos-child-expected.html: Added.
* fast/css3-text/css3-text-indent/text-indent-with-absolute-pos-child.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj
trunk/Source/WebCore/rendering/RenderBlockFlow.cpp
trunk/Source/WebCore/rendering/RenderBlockFlow.h
trunk/Source/WebCore/rendering/RenderBlockLineLayout.cpp
trunk/Source/WebCore/rendering/line/LineBreaker.cpp
trunk/Source/WebCore/rendering/line/LineInlineHeaders.h


Added Paths

trunk/LayoutTests/fast/css3-text/css3-text-indent/text-indent-with-absolute-pos-child-expected.html
trunk/LayoutTests/fast/css3-text/css3-text-indent/text-indent-with-absolute-pos-child.html




Diff

Modified: trunk/LayoutTests/ChangeLog (197029 => 197030)

--- trunk/LayoutTests/ChangeLog	2016-02-24 17:06:50 UTC (rev 197029)
+++ trunk/LayoutTests/ChangeLog	2016-02-24 17:13:33 UTC (rev 197030)
@@ -1,3 +1,18 @@
+2016-02-24  Zalan Bujtas  
+
+Background of an absolutely positioned inline element inside text-indented parent is positioned statically.
+https://bugs.webkit.org/show_bug.cgi?id=154019
+
+Reviewed by Simon Fraser.
+
+This patch ensures that statically positioned out-of-flow renderers are also text-aligned
+even when none of the renderers on the first line generate a linebox (so we end up with no bidi runs at all).
+The fix is to pass IndentTextOrNot information to startAlignedOffsetForLine through updateStaticInlinePositionForChild
+so that we can compute the left position for this statically positioned out of flow renderer.
+
+* fast/css3-text/css3-text-indent/text-indent-with-absolute-pos-child-expected.html: Added.
+* fast/css3-text/css3-text-indent/text-indent-with-absolute-pos-child.html: Added.
+
 2016-02-24  Carlos Garcia Campos  
 
 REGRESSION(r195949): [GTK] Test /webkit2/WebKitWebView/insert/link is failing since r195949


Added: trunk/LayoutTests/fast/css3-text/css3-text-indent/text-indent-with-absolute-pos-child-expected.html (0 => 197030)

--- trunk/LayoutTests/fast/css3-text/css3-text-indent/text-indent-with-absolute-pos-child-expected.html	(rev 0)
+++ trunk/LayoutTests/fast/css3-text/css3-text-indent/text-indent-with-absolute-pos-child-expected.html	2016-02-24 17:13:33 UTC (rev 197030)
@@ -0,0 +1,58 @@
+
+
+
+This tests that first line text-indent is applied properly when the child is a statically positioned out-of-flow renderer.
+
+ body {
+ 	margin: 40px;
+ }
+ 
+.container {
+  display: block;
+  background-color: green;
+  width: 100px;
+  height: 20px;
+  color: green;
+  font-family: Ahem;
+  font-size: 10px;
+}
+
+.inner {
+  display: block;
+  background-color: blue;
+  width: 20px;
+  height: 20px;
+}
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
\ No newline at end of file


Added: trunk/LayoutTests/fast/css3-text/css3-text-indent/text-indent-with-absolute-pos-child.html (0 => 197030)

--- trunk/LayoutTests/fast/css3-text/css3-text-indent/text-indent-with-absolute-pos-child.html	(rev 0)
+++ trunk/LayoutTests/fast/css3-text/css3-text-indent/text-indent-with-absolute-pos-child.html	2016-02-24 17:13:33 UTC (rev 197030)
@@ -0,0 +1,59 @@
+
+
+
+This tests that first line text-indent is applied properly when the child is a statically positioned out-of-flow renderer.
+
+ body {
+ 	margin: 40px;
+ }
+ 
+.container {
+  

[webkit-changes] [197029] trunk/Source/WebInspectorUI

[nvasilyev]

Title: [197029] trunk/Source/WebInspectorUI








Revision 197029
Author nvasil...@apple.com
Date 2016-02-24 09:06:50 -0800 (Wed, 24 Feb 2016)


Log Message
Web Inspector: Dim selected items when docked Inspector window is inactive
https://bugs.webkit.org/show_bug.cgi?id=154526


Abstract selected item and SVG glyph colors into CSS variables.

Reviewed by Timothy Hatcher.

* UserInterface/Views/BezierEditor.css:
(.bezier-editor > .bezier-preview > div):
* UserInterface/Views/ButtonNavigationItem.css:
(.navigation-bar .item.button > .glyph):
(.navigation-bar .item.button:not(.disabled):active > .glyph):
(.navigation-bar .item.button:not(.disabled):matches(:focus, .activate.activated, .radio.selected) > .glyph):
(.navigation-bar .item.button:not(.disabled):active:matches(:focus, .activate.activated, .radio.selected) > .glyph):
(.navigation-bar .item.button.disabled > .glyph):
* UserInterface/Views/ButtonToolbarItem.css:
(.toolbar .item.button:not(.disabled):matches(:focus, .activate.activated) > .glyph):
(.toolbar .item.button:not(.disabled):active:matches(:focus, .activate.activated) > .glyph):
* UserInterface/Views/CSSStyleDetailsSidebarPanel.css:
(.sidebar > .panel.details.css-style > .content ~ .options-container > .toggle-class-toggle.selected):
(.sidebar > .panel.details.css-style > .content ~ .options-container > .toggle-class-toggle:not(.selected):hover):
* UserInterface/Views/ConsoleMessageView.css:
(.console-user-command.special-user-log > .console-message-text):
* UserInterface/Views/DOMTreeOutline.css:
(.tree-outline.dom li.pseudo-class-enabled > .selection::before):
* UserInterface/Views/Main.css:
(input[type=range]::-webkit-slider-runnable-track::before):
* UserInterface/Views/RadioButtonNavigationItem.css:
(.navigation-bar .item.radio.button.text-only:hover):
(.navigation-bar .item.radio.button.text-only.selected):
(.navigation-bar .item.radio.button.text-only:active):
(.navigation-bar .item.radio.button.text-only.selected:active):
* UserInterface/Views/ScopeBar.css:
(.scope-bar > li.multiple:matches(.selected, :hover, :active) > .arrows):
(.scope-bar > li:hover):
(.scope-bar > li.selected):
(.scope-bar > li:active):
(.scope-bar > li.selected:active):
* UserInterface/Views/Variables.css:
(:root):
(body.window-inactive):
* UserInterface/Views/VisualStyleDetailsPanel.css:
(.sidebar > .panel.details.css-style .visual > .details-section .details-section.has-set-property > .header > span::after):
* UserInterface/Views/VisualStyleKeywordIconList.css:
(.visual-style-property-container.keyword-icon-list > .visual-style-property-value-container > .keyword-icon-list-container > .keyword-icon:matches(.computed, .selected)):
(.visual-style-property-container.keyword-icon-list > .visual-style-property-value-container > .keyword-icon-list-container > .keyword-icon.selected):

Modified Paths

trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/Views/BezierEditor.css
trunk/Source/WebInspectorUI/UserInterface/Views/ButtonNavigationItem.css
trunk/Source/WebInspectorUI/UserInterface/Views/ButtonToolbarItem.css
trunk/Source/WebInspectorUI/UserInterface/Views/CSSStyleDetailsSidebarPanel.css
trunk/Source/WebInspectorUI/UserInterface/Views/ConsoleMessageView.css
trunk/Source/WebInspectorUI/UserInterface/Views/DOMTreeOutline.css
trunk/Source/WebInspectorUI/UserInterface/Views/Main.css
trunk/Source/WebInspectorUI/UserInterface/Views/RadioButtonNavigationItem.css
trunk/Source/WebInspectorUI/UserInterface/Views/ScopeBar.css
trunk/Source/WebInspectorUI/UserInterface/Views/Variables.css
trunk/Source/WebInspectorUI/UserInterface/Views/VisualStyleDetailsPanel.css
trunk/Source/WebInspectorUI/UserInterface/Views/VisualStyleKeywordIconList.css




Diff

Modified: trunk/Source/WebInspectorUI/ChangeLog (197028 => 197029)

--- trunk/Source/WebInspectorUI/ChangeLog	2016-02-24 14:17:48 UTC (rev 197028)
+++ trunk/Source/WebInspectorUI/ChangeLog	2016-02-24 17:06:50 UTC (rev 197029)
@@ -1,3 +1,53 @@
+2016-02-24  Nikita Vasilyev  
+
+Web Inspector: Dim selected items when docked Inspector window is inactive
+https://bugs.webkit.org/show_bug.cgi?id=154526
+
+
+Abstract selected item and SVG glyph colors into CSS variables.
+
+Reviewed by Timothy Hatcher.
+
+* UserInterface/Views/BezierEditor.css:
+(.bezier-editor > .bezier-preview > div):
+* UserInterface/Views/ButtonNavigationItem.css:
+(.navigation-bar .item.button > .glyph):
+(.navigation-bar .item.button:not(.disabled):active > .glyph):
+(.navigation-bar .item.button:not(.disabled):matches(:focus, .activate.activated, .radio.selected) > .glyph):
+(.navigation-bar .item.button:not(.disabled):active:matches(:focus, .activate.activated, .radio.selected) > .glyph):
+(.navigation-bar .item.button.disabled > .glyph):
+* UserInterface/Views/ButtonToolbarItem.css:
+(.toolbar .item.button:not(.disabled):matches(:focus, 

[webkit-changes] [197028] trunk/Source/WebCore

[youenn . fablet]

Title: [197028] trunk/Source/WebCore








Revision 197028
Author youenn.fab...@crf.canon.fr
Date 2016-02-24 06:17:48 -0800 (Wed, 24 Feb 2016)


Log Message
Remove IteratorKey and IteratorValue declarations from JSXX class declarations.
https://bugs.webkit.org/show_bug.cgi?id=154577

Reviewed by Myles C. Maxfield.

No change of behavior.

* bindings/scripts/CodeGeneratorJS.pm:
(GenerateHeader): Deleted declaration of IteratorKey and IteratorValue.
* bindings/scripts/test/JS/JSTestObj.h:
(WebCore::JSTestObj::createStructure): Rebasing of binding test expectation.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm
trunk/Source/WebCore/bindings/scripts/test/JS/JSTestObj.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (197027 => 197028)

--- trunk/Source/WebCore/ChangeLog	2016-02-24 12:14:30 UTC (rev 197027)
+++ trunk/Source/WebCore/ChangeLog	2016-02-24 14:17:48 UTC (rev 197028)
@@ -1,5 +1,19 @@
 2016-02-24  Youenn Fablet  
 
+Remove IteratorKey and IteratorValue declarations from JSXX class declarations.
+https://bugs.webkit.org/show_bug.cgi?id=154577
+
+Reviewed by Myles C. Maxfield.
+
+No change of behavior.
+
+* bindings/scripts/CodeGeneratorJS.pm:
+(GenerateHeader): Deleted declaration of IteratorKey and IteratorValue.
+* bindings/scripts/test/JS/JSTestObj.h:
+(WebCore::JSTestObj::createStructure): Rebasing of binding test expectation.
+
+2016-02-24  Youenn Fablet  
+
 [Fetch API] Refactor FetchHeaders initialization with iterators
 https://bugs.webkit.org/show_bug.cgi?id=154537
 


Modified: trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm (197027 => 197028)

--- trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm	2016-02-24 12:14:30 UTC (rev 197027)
+++ trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm	2016-02-24 14:17:48 UTC (rev 197028)
@@ -1050,16 +1050,6 @@
 push(@headerContent, "static void destroy(JSC::JSCell*);\n");
 }
 
-if ($interface->iterable) {
-push(@headerContent, "\n");
-if ($interface->iterable->keyType) {
-my $keyType = GetNativeType($interface->iterable->keyType);
-push(@headerContent, "using IteratorKey = $keyType;\n");
-}
-my $valueType = GetNativeType($interface->iterable->valueType);
-push(@headerContent, "using IteratorValue = $valueType;\n");
-}
-
 # Class info
 if ($interfaceName eq "Node") {
 push(@headerContent, "\n");
@@ -4039,7 +4029,6 @@
 my $svgNativeType = $codeGenerator->GetSVGTypeNeedingTearOff($type);
 return "${svgNativeType}*" if $svgNativeType;
 return "RefPtr" if $type eq "DOMStringList";
-return "RefPtr" if $type eq "FontFace";
 return "RefPtr<${type}>" if $codeGenerator->IsTypedArrayType($type) and not $type eq "ArrayBuffer";
 return $nativeType{$type} if exists $nativeType{$type};
 


Modified: trunk/Source/WebCore/bindings/scripts/test/JS/JSTestObj.h (197027 => 197028)

--- trunk/Source/WebCore/bindings/scripts/test/JS/JSTestObj.h	2016-02-24 12:14:30 UTC (rev 197027)
+++ trunk/Source/WebCore/bindings/scripts/test/JS/JSTestObj.h	2016-02-24 14:17:48 UTC (rev 197028)
@@ -45,9 +45,6 @@
 static bool getOwnPropertySlot(JSC::JSObject*, JSC::ExecState*, JSC::PropertyName, JSC::PropertySlot&);
 static void destroy(JSC::JSCell*);
 
-using IteratorKey = String;
-using IteratorValue = TestObj*;
-
 DECLARE_INFO;
 
 static JSC::Structure* createStructure(JSC::VM& vm, JSC::JSGlobalObject* globalObject, JSC::JSValue prototype)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [197027] trunk

[youenn . fablet]

Title: [197027] trunk








Revision 197027
Author youenn.fab...@crf.canon.fr
Date 2016-02-24 04:14:30 -0800 (Wed, 24 Feb 2016)


Log Message
W3C importer should generate all web-platform-tests submodules descriptions
https://bugs.webkit.org/show_bug.cgi?id=154587

Reviewed by Darin Adler.

LayoutTests/imported/w3c:

* resources/TestRepositories: Reactivated submodules description generation.
* resources/web-platform-tests-modules.json: Updated according modified scripts.

Tools:

Updated submodules description format (removing submodule name as it is the last string of the path really).
Added git subroutines.

* Scripts/webkitpy/common/checkout/scm/git.py:
(Git.origin_url):
(Git):
(Git.init_submodules):
(Git.submodules_status):
(Git.deinit_submodules):
* Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
(WebPlatformTestServer._install_modules): Updated to submodule name removal.
* Scripts/webkitpy/w3c/test_downloader.py:
(TestDownloader._git_submodules_description): Updated to cope with recursive submodules (use of submodule init/deinit).
* Scripts/webkitpy/w3c/test_importer_unittest.py:
(TestImporterTest.test_submodules_generation): Reactivated partially this test.

Modified Paths

trunk/LayoutTests/imported/w3c/ChangeLog
trunk/LayoutTests/imported/w3c/resources/TestRepositories
trunk/LayoutTests/imported/w3c/resources/web-platform-tests-modules.json
trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/common/checkout/scm/git.py
trunk/Tools/Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py
trunk/Tools/Scripts/webkitpy/w3c/test_downloader.py
trunk/Tools/Scripts/webkitpy/w3c/test_importer_unittest.py




Diff

Modified: trunk/LayoutTests/imported/w3c/ChangeLog (197026 => 197027)

--- trunk/LayoutTests/imported/w3c/ChangeLog	2016-02-24 12:11:15 UTC (rev 197026)
+++ trunk/LayoutTests/imported/w3c/ChangeLog	2016-02-24 12:14:30 UTC (rev 197027)
@@ -1,3 +1,13 @@
+2016-02-24  Youenn Fablet  
+
+W3C importer should generate all web-platform-tests submodules descriptions
+https://bugs.webkit.org/show_bug.cgi?id=154587
+
+Reviewed by Darin Adler.
+
+* resources/TestRepositories: Reactivated submodules description generation.
+* resources/web-platform-tests-modules.json: Updated according modified scripts.
+
 2016-02-23  Chris Dumez  
 
 [Reflected] IDL attributes of integer types should use HTML rules for parsing integers


Modified: trunk/LayoutTests/imported/w3c/resources/TestRepositories (197026 => 197027)

--- trunk/LayoutTests/imported/w3c/resources/TestRepositories	2016-02-24 12:11:15 UTC (rev 197026)
+++ trunk/LayoutTests/imported/w3c/resources/TestRepositories	2016-02-24 12:14:30 UTC (rev 197027)
@@ -30,6 +30,6 @@
 "config.default.json",
 "serve.py"
 ],
-"import_options": []
+"import_options": ["generate_git_submodules_description"]
 }
 ]


Modified: trunk/LayoutTests/imported/w3c/resources/web-platform-tests-modules.json (197026 => 197027)

--- trunk/LayoutTests/imported/w3c/resources/web-platform-tests-modules.json	2016-02-24 12:11:15 UTC (rev 197026)
+++ trunk/LayoutTests/imported/w3c/resources/web-platform-tests-modules.json	2016-02-24 12:14:30 UTC (rev 197027)
@@ -1,58 +1,77 @@
 [
 {
-"name": "resources", 
 "path": [
-"."
+"resources"
 ], 
-"url": "https://github.com/w3c/testharness.js/archive/698441212391d5177b2f1806d97c7fd15cc46715.tar.gz",
+"url": "https://github.com/w3c/testharness.js/archive/698441212391d5177b2f1806d97c7fd15cc46715.tar.gz", 
 "url_subpath": "testharness.js-698441212391d5177b2f1806d97c7fd15cc46715"
 }, 
 {
-"name": "webidl2",
 "path": [
-"resources"
-],
-"url": "https://github.com/darobin/webidl2.js/archive/bd216bcd5596d60734450adc938155deab1e1a80.tar.gz",
+"resources", 
+"webidl2"
+], 
+"url": "https://github.com/darobin/webidl2.js/archive/bd216bcd5596d60734450adc938155deab1e1a80.tar.gz", 
 "url_subpath": "webidl2.js-bd216bcd5596d60734450adc938155deab1e1a80"
-},
+}, 
 {
-"name": "tools", 
 "path": [
-"."
+"resources", 
+"webidl2", 
+"test", 
+"widlproc"
 ], 
+"url": "https://github.com/dontcallmedom/widlproc/archive/4ef8dde69c0ba3d0167bccfa2775eea7f0d6c7fe.tar.gz", 
+"url_subpath": "widlproc-4ef8dde69c0ba3d0167bccfa2775eea7f0d6c7fe"
+}, 
+{
+"path": [
+"tools"
+], 
 "url": "https://github.com/w3c/wpt-tools/archive/80bc792988aff1422f43b9e1d5909673eca960a2.tar.gz", 
 "url_subpath": "wpt-tools-80bc792988aff1422f43b9e1d5909673eca960a2"
-},
+}, 
 {
-"name": "html5lib", 
 "path": [
-"tools"
+"tools", 
+"html5lib"
 

[webkit-changes] [197026] trunk/Source/WebCore

[youenn . fablet]

Title: [197026] trunk/Source/WebCore








Revision 197026
Author youenn.fab...@crf.canon.fr
Date 2016-02-24 04:11:15 -0800 (Wed, 24 Feb 2016)


Log Message
[Fetch API] Refactor FetchHeaders initialization with iterators
https://bugs.webkit.org/show_bug.cgi?id=154537

Reviewed by Darin Adler.

Covered by existing tests.

* Modules/fetch/FetchHeaders.cpp:
(WebCore::initializeWith): Deleted.
* Modules/fetch/FetchHeaders.h: Removed FetchHeaders::initializeWith.
* Modules/fetch/FetchHeaders.idl: Ditto.
* Modules/fetch/FetchHeaders.js:
(initializeFetchHeaders): Making use of iterators to fill headers.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/fetch/FetchHeaders.cpp
trunk/Source/WebCore/Modules/fetch/FetchHeaders.h
trunk/Source/WebCore/Modules/fetch/FetchHeaders.idl
trunk/Source/WebCore/Modules/fetch/FetchHeaders.js




Diff

Modified: trunk/Source/WebCore/ChangeLog (197025 => 197026)

--- trunk/Source/WebCore/ChangeLog	2016-02-24 11:13:58 UTC (rev 197025)
+++ trunk/Source/WebCore/ChangeLog	2016-02-24 12:11:15 UTC (rev 197026)
@@ -1,3 +1,19 @@
+2016-02-24  Youenn Fablet  
+
+[Fetch API] Refactor FetchHeaders initialization with iterators
+https://bugs.webkit.org/show_bug.cgi?id=154537
+
+Reviewed by Darin Adler.
+
+Covered by existing tests.
+
+* Modules/fetch/FetchHeaders.cpp:
+(WebCore::initializeWith): Deleted.
+* Modules/fetch/FetchHeaders.h: Removed FetchHeaders::initializeWith.
+* Modules/fetch/FetchHeaders.idl: Ditto.
+* Modules/fetch/FetchHeaders.js:
+(initializeFetchHeaders): Making use of iterators to fill headers.
+
 2016-02-24  Carlos Garcia Campos  
 
 Unreviewed. Fix GObject DOM bindings API break after r196998.


Modified: trunk/Source/WebCore/Modules/fetch/FetchHeaders.cpp (197025 => 197026)

--- trunk/Source/WebCore/Modules/fetch/FetchHeaders.cpp	2016-02-24 11:13:58 UTC (rev 197025)
+++ trunk/Source/WebCore/Modules/fetch/FetchHeaders.cpp	2016-02-24 12:11:15 UTC (rev 197026)
@@ -36,13 +36,6 @@
 
 namespace WebCore {
 
-void FetchHeaders::initializeWith(const FetchHeaders* headers, ExceptionCode&)
-{
-if (!headers)
-return;
-m_headers = headers->m_headers;
-}
-
 // FIXME: Optimize these routines for HTTPHeaderMap keys and/or refactor them with XMLHttpRequest code.
 static bool isForbiddenHeaderName(const String& name)
 {


Modified: trunk/Source/WebCore/Modules/fetch/FetchHeaders.h (197025 => 197026)

--- trunk/Source/WebCore/Modules/fetch/FetchHeaders.h	2016-02-24 11:13:58 UTC (rev 197025)
+++ trunk/Source/WebCore/Modules/fetch/FetchHeaders.h	2016-02-24 12:11:15 UTC (rev 197026)
@@ -62,7 +62,6 @@
 bool has(const String&, ExceptionCode&) const;
 void set(const String& name, const String& value, ExceptionCode&);
 
-void initializeWith(const FetchHeaders*, ExceptionCode&);
 void fill(const FetchHeaders*);
 
 String fastGet(HTTPHeaderName name) const { return m_headers.get(name); }


Modified: trunk/Source/WebCore/Modules/fetch/FetchHeaders.idl (197025 => 197026)

--- trunk/Source/WebCore/Modules/fetch/FetchHeaders.idl	2016-02-24 11:13:58 UTC (rev 197025)
+++ trunk/Source/WebCore/Modules/fetch/FetchHeaders.idl	2016-02-24 12:11:15 UTC (rev 197026)
@@ -43,5 +43,4 @@
 iterable;
 
 [Private, RaisesException, ImplementedAs=append] void appendFromJS(DOMString name, DOMString value);
-[Private, RaisesException] void initializeWith(FetchHeaders headers);
 };


Modified: trunk/Source/WebCore/Modules/fetch/FetchHeaders.js (197025 => 197026)

--- trunk/Source/WebCore/Modules/fetch/FetchHeaders.js	2016-02-24 11:13:58 UTC (rev 197025)
+++ trunk/Source/WebCore/Modules/fetch/FetchHeaders.js	2016-02-24 12:11:15 UTC (rev 197026)
@@ -36,8 +36,9 @@
 throw new @TypeError("headersInit must be an object");
 
 if (this.constructor === headersInit.constructor) {
- // FIXME: Use iterators when available?
- this.@initializeWith(headersInit);
+ headersInit.forEach((value, name) => {
+ this.@appendFromJS(name, value);
+ });
 }
 
 if (headersInit instanceof @Array) {






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [197025] trunk/Source/WebCore

[carlosgc]

Title: [197025] trunk/Source/WebCore








Revision 197025
Author carlo...@webkit.org
Date 2016-02-24 03:13:58 -0800 (Wed, 24 Feb 2016)


Log Message
Unreviewed. Fix GObject DOM bindings API break after r196998.

webkit_dom_node_clone_node can now raise exceptions, so rename it
as webkit_dom_node_clone_node_with_error and deprecate the old one
that calls the new one ignoring the error.

* bindings/gobject/WebKitDOMDeprecated.cpp:
(webkit_dom_node_clone_node):
* bindings/gobject/WebKitDOMDeprecated.h:
* bindings/gobject/WebKitDOMDeprecated.symbols:
* bindings/gobject/webkitdom.symbols:
* bindings/scripts/CodeGeneratorGObject.pm:
(FunctionUsedToNotRaiseException):
(GenerateFunction):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/gobject/WebKitDOMDeprecated.cpp
trunk/Source/WebCore/bindings/gobject/WebKitDOMDeprecated.h
trunk/Source/WebCore/bindings/gobject/WebKitDOMDeprecated.symbols
trunk/Source/WebCore/bindings/gobject/webkitdom.symbols
trunk/Source/WebCore/bindings/scripts/CodeGeneratorGObject.pm




Diff

Modified: trunk/Source/WebCore/ChangeLog (197024 => 197025)

--- trunk/Source/WebCore/ChangeLog	2016-02-24 10:41:11 UTC (rev 197024)
+++ trunk/Source/WebCore/ChangeLog	2016-02-24 11:13:58 UTC (rev 197025)
@@ -1,5 +1,22 @@
 2016-02-24  Carlos Garcia Campos  
 
+Unreviewed. Fix GObject DOM bindings API break after r196998.
+
+webkit_dom_node_clone_node can now raise exceptions, so rename it
+as webkit_dom_node_clone_node_with_error and deprecate the old one
+that calls the new one ignoring the error.
+
+* bindings/gobject/WebKitDOMDeprecated.cpp:
+(webkit_dom_node_clone_node):
+* bindings/gobject/WebKitDOMDeprecated.h:
+* bindings/gobject/WebKitDOMDeprecated.symbols:
+* bindings/gobject/webkitdom.symbols:
+* bindings/scripts/CodeGeneratorGObject.pm:
+(FunctionUsedToNotRaiseException):
+(GenerateFunction):
+
+2016-02-24  Carlos Garcia Campos  
+
 REGRESSION(r195949): [GTK] Test /webkit2/WebKitWebView/insert/link is failing since r195949
 https://bugs.webkit.org/show_bug.cgi?id=153747
 


Modified: trunk/Source/WebCore/bindings/gobject/WebKitDOMDeprecated.cpp (197024 => 197025)

--- trunk/Source/WebCore/bindings/gobject/WebKitDOMDeprecated.cpp	2016-02-24 10:41:11 UTC (rev 197024)
+++ trunk/Source/WebCore/bindings/gobject/WebKitDOMDeprecated.cpp	2016-02-24 11:13:58 UTC (rev 197025)
@@ -127,6 +127,11 @@
 return WebKit::kit(nodeList.get());
 }
 
+WebKitDOMNode* webkit_dom_node_clone_node(WebKitDOMNode* self, gboolean deep)
+{
+return webkit_dom_node_clone_node_with_error(self, deep, nullptr);
+}
+
 G_DEFINE_TYPE(WebKitDOMEntityReference, webkit_dom_entity_reference, WEBKIT_DOM_TYPE_NODE)
 
 static void webkit_dom_entity_reference_init(WebKitDOMEntityReference*)


Modified: trunk/Source/WebCore/bindings/gobject/WebKitDOMDeprecated.h (197024 => 197025)

--- trunk/Source/WebCore/bindings/gobject/WebKitDOMDeprecated.h	2016-02-24 10:41:11 UTC (rev 197024)
+++ trunk/Source/WebCore/bindings/gobject/WebKitDOMDeprecated.h	2016-02-24 11:13:58 UTC (rev 197025)
@@ -159,7 +159,19 @@
 WEBKIT_DEPRECATED_FOR(webkit_dom_element_get_elements_by_class_name_as_html_collection) WebKitDOMNodeList*
 webkit_dom_element_get_elements_by_class_name(WebKitDOMElement* self, const gchar* class_name);
 
+/**
+ * webkit_dom_node_clone_node:
+ * @self: A #WebKitDOMNode
+ * @deep: A #gboolean
+ *
+ * Returns: (transfer none): A #WebKitDOMNode
+ *
+ * Deprecated: 2.14: Use webkit_dom_node_clone_node_with_error() instead.
+ */
+WEBKIT_DEPRECATED_FOR(webkit_dom_node_clone_node_with_error) WebKitDOMNode*
+webkit_dom_node_clone_node(WebKitDOMNode* self, gboolean deep, GError** error);
 
+
 #define WEBKIT_DOM_TYPE_ENTITY_REFERENCE(webkit_dom_entity_reference_get_type())
 #define WEBKIT_DOM_ENTITY_REFERENCE(obj)(G_TYPE_CHECK_INSTANCE_CAST((obj), WEBKIT_DOM_TYPE_ENTITY_REFERENCE, WebKitDOMEntityReference))
 #define WEBKIT_DOM_ENTITY_REFERENCE_CLASS(klass)(G_TYPE_CHECK_CLASS_CAST((klass),  WEBKIT_DOM_TYPE_ENTITY_REFERENCE, WebKitDOMEntityReferenceClass)


Modified: trunk/Source/WebCore/bindings/gobject/WebKitDOMDeprecated.symbols (197024 => 197025)

--- trunk/Source/WebCore/bindings/gobject/WebKitDOMDeprecated.symbols	2016-02-24 10:41:11 UTC (rev 197024)
+++ trunk/Source/WebCore/bindings/gobject/WebKitDOMDeprecated.symbols	2016-02-24 11:13:58 UTC (rev 197025)
@@ -20,3 +20,4 @@
 void webkit_dom_html_base_font_element_set_color(WebKitDOMHTMLBaseFontElement*, const gchar*)
 void webkit_dom_html_base_font_element_set_face(WebKitDOMHTMLBaseFontElement*, const gchar*)
 void webkit_dom_html_base_font_element_set_size(WebKitDOMHTMLBaseFontElement*, glong)
+WebKitDOMNode* webkit_dom_node_clone_node(WebKitDOMNode*, gboolean)


Modified: trunk/Source/WebCore/bindings/gobject/webkitdom.symbols (197024 => 197025)

--- 

[webkit-changes] [197024] trunk

[carlosgc]

Title: [197024] trunk








Revision 197024
Author carlo...@webkit.org
Date 2016-02-24 02:41:11 -0800 (Wed, 24 Feb 2016)


Log Message
REGRESSION(r195949): [GTK] Test /webkit2/WebKitWebView/insert/link is failing since r195949
https://bugs.webkit.org/show_bug.cgi?id=153747

Reviewed by Michael Catanzaro.

Source/WebCore:

Do not return early when reaching a boundary if there's a range
selection. In that case, the selection will be cleared and
accessibility will be notified.

Test: editing/selection/move-to-line-boundary-clear-selection.html

* editing/FrameSelection.cpp:
(WebCore::FrameSelection::modify):

LayoutTests:

Add test to check that moving to line boundary clears the
selection even if the cursor is already at the boundary.

* editing/selection/move-to-line-boundary-clear-selection-expected.txt: Added.
* editing/selection/move-to-line-boundary-clear-selection.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/editing/FrameSelection.cpp


Added Paths

trunk/LayoutTests/editing/selection/move-to-line-boundary-clear-selection-expected.txt
trunk/LayoutTests/editing/selection/move-to-line-boundary-clear-selection.html




Diff

Modified: trunk/LayoutTests/ChangeLog (197023 => 197024)

--- trunk/LayoutTests/ChangeLog	2016-02-24 10:12:54 UTC (rev 197023)
+++ trunk/LayoutTests/ChangeLog	2016-02-24 10:41:11 UTC (rev 197024)
@@ -1,3 +1,16 @@
+2016-02-24  Carlos Garcia Campos  
+
+REGRESSION(r195949): [GTK] Test /webkit2/WebKitWebView/insert/link is failing since r195949
+https://bugs.webkit.org/show_bug.cgi?id=153747
+
+Reviewed by Michael Catanzaro.
+
+Add test to check that moving to line boundary clears the
+selection even if the cursor is already at the boundary.
+
+* editing/selection/move-to-line-boundary-clear-selection-expected.txt: Added.
+* editing/selection/move-to-line-boundary-clear-selection.html: Added.
+
 2016-02-23  Sergio Villar Senin  
 
 [css-grid] Swap the order of columns/rows in grid-gap shorthand


Added: trunk/LayoutTests/editing/selection/move-to-line-boundary-clear-selection-expected.txt (0 => 197024)

--- trunk/LayoutTests/editing/selection/move-to-line-boundary-clear-selection-expected.txt	(rev 0)
+++ trunk/LayoutTests/editing/selection/move-to-line-boundary-clear-selection-expected.txt	2016-02-24 10:41:11 UTC (rev 197024)
@@ -0,0 +1,3 @@
+PASS getSelection().toString() is ''
+PASS getSelection().toString() is ''
+webkit


Added: trunk/LayoutTests/editing/selection/move-to-line-boundary-clear-selection.html (0 => 197024)

--- trunk/LayoutTests/editing/selection/move-to-line-boundary-clear-selection.html	(rev 0)
+++ trunk/LayoutTests/editing/selection/move-to-line-boundary-clear-selection.html	2016-02-24 10:41:11 UTC (rev 197024)
@@ -0,0 +1,26 @@
+
+
+