date:20160418

[webkit-changes] [199707] trunk/Source/WebCore

2016-04-18 Thread achristensen

Title: [199707] trunk/Source/WebCore








Revision 199707
Author achristen...@apple.com
Date 2016-04-18 22:08:53 -0700 (Mon, 18 Apr 2016)


Log Message
Fix iOS build after r199701

* platform/ios/WebAVPlayerController.mm:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/ios/WebAVPlayerController.mm




Diff

Modified: trunk/Source/WebCore/ChangeLog (199706 => 199707)

--- trunk/Source/WebCore/ChangeLog	2016-04-19 05:05:42 UTC (rev 199706)
+++ trunk/Source/WebCore/ChangeLog	2016-04-19 05:08:53 UTC (rev 199707)
@@ -1,3 +1,9 @@
+2016-04-18  Alex Christensen  
+
+Fix iOS build after r199701
+
+* platform/ios/WebAVPlayerController.mm:
+
 2016-04-18  Darin Adler  
 
 Updated binding test result to reflect the change to not use Deprecated::ScriptValue.


Modified: trunk/Source/WebCore/platform/ios/WebAVPlayerController.mm (199706 => 199707)

--- trunk/Source/WebCore/platform/ios/WebAVPlayerController.mm	2016-04-19 05:05:42 UTC (rev 199706)
+++ trunk/Source/WebCore/platform/ios/WebAVPlayerController.mm	2016-04-19 05:08:53 UTC (rev 199707)
@@ -50,7 +50,7 @@
 
 - (instancetype)init
 {
-if (!getAVPlayerController())
+if (!getAVPlayerControllerClass())
 return nil;
 
 if (!(self = [super init]))






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [199706] trunk/Source/WebCore

2016-04-18 Thread darin

Title: [199706] trunk/Source/WebCore








Revision 199706
Author da...@apple.com
Date 2016-04-18 22:05:42 -0700 (Mon, 18 Apr 2016)


Log Message
Updated binding test result to reflect the change to not use Deprecated::ScriptValue.

* bindings/scripts/test/JS/JSTestObj.cpp: Regenerated with new script.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (199705 => 199706)

--- trunk/Source/WebCore/ChangeLog	2016-04-19 04:05:30 UTC (rev 199705)
+++ trunk/Source/WebCore/ChangeLog	2016-04-19 05:05:42 UTC (rev 199706)
@@ -1,5 +1,11 @@
 2016-04-18  Darin Adler  
 
+Updated binding test result to reflect the change to not use Deprecated::ScriptValue.
+
+* bindings/scripts/test/JS/JSTestObj.cpp: Regenerated with new script.
+
+2016-04-18  Darin Adler  
+
 Remove all use of Deprecated::ScriptValue in generated bindings
 https://bugs.webkit.org/show_bug.cgi?id=156706
 


Modified: trunk/Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp (199705 => 199706)

--- trunk/Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp	2016-04-19 04:05:30 UTC (rev 199705)
+++ trunk/Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp	2016-04-19 05:05:42 UTC (rev 199706)
@@ -59,7 +59,6 @@
 #include "URL.h"
 #include "WebCoreJSClientData.h"
 #include "bool.h"
-#include 
 #include 
 #include 
 #include 
@@ -1767,7 +1766,7 @@
 if (JSValue cachedValue = castedThis->m_cachedAttribute1.get())
 return JSValue::encode(cachedValue);
 auto& impl = castedThis->wrapped();
-JSValue result = (impl.cachedAttribute1().hasNoValue() ? jsNull() : impl.cachedAttribute1().jsValue());
+JSValue result = impl.cachedAttribute1();
 castedThis->m_cachedAttribute1.set(state->vm(), castedThis, result);
 return JSValue::encode(result);
 }
@@ -1785,7 +1784,7 @@
 if (JSValue cachedValue = castedThis->m_cachedAttribute2.get())
 return JSValue::encode(cachedValue);
 auto& impl = castedThis->wrapped();
-JSValue result = (impl.cachedAttribute2().hasNoValue() ? jsNull() : impl.cachedAttribute2().jsValue());
+JSValue result = impl.cachedAttribute2();
 castedThis->m_cachedAttribute2.set(state->vm(), castedThis, result);
 return JSValue::encode(result);
 }
@@ -1801,7 +1800,7 @@
 return throwGetterTypeError(*state, "TestObj", "anyAttribute");
 }
 auto& impl = castedThis->wrapped();
-JSValue result = (impl.anyAttribute().hasNoValue() ? jsNull() : impl.anyAttribute().jsValue());
+JSValue result = impl.anyAttribute();
 return JSValue::encode(result);
 }
 
@@ -3027,7 +3026,7 @@
 return throwSetterTypeError(*state, "TestObj", "anyAttribute");
 }
 auto& impl = castedThis->wrapped();
-Deprecated::ScriptValue nativeValue = { state->vm(), value };
+JSC::JSValue nativeValue = value;
 if (UNLIKELY(state->hadException()))
 return false;
 impl.setAnyAttribute(nativeValue);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [199705] trunk/Tools

2016-04-18 Thread mitz

Title: [199705] trunk/Tools








Revision 199705
Author m...@apple.com
Date 2016-04-18 21:05:30 -0700 (Mon, 18 Apr 2016)


Log Message
Fixed building with old Xcode.

* TestWebKitAPI/Tests/WebKit2Cocoa/Preferences.mm:
(TEST):

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/Preferences.mm




Diff

Modified: trunk/Tools/ChangeLog (199704 => 199705)

--- trunk/Tools/ChangeLog	2016-04-19 02:58:44 UTC (rev 199704)
+++ trunk/Tools/ChangeLog	2016-04-19 04:05:30 UTC (rev 199705)
@@ -1,3 +1,10 @@
+2016-04-18  Dan Bernstein  
+
+Fixed building with old Xcode.
+
+* TestWebKitAPI/Tests/WebKit2Cocoa/Preferences.mm:
+(TEST):
+
 2016-04-18  Dean Jackson  
 
 New SPI to export a dictionary of runtime features


Modified: trunk/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/Preferences.mm (199704 => 199705)

--- trunk/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/Preferences.mm	2016-04-19 02:58:44 UTC (rev 199704)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/Preferences.mm	2016-04-19 04:05:30 UTC (rev 199705)
@@ -44,7 +44,7 @@
 
 TEST(WebKit2, ExperimentalFeatures)
 {
-NSArray<_WKExperimentalFeature *> *features = [WKPreferences _experimentalFeatures];
+NSArray *features = [WKPreferences _experimentalFeatures];
 EXPECT_NOT_NULL(features);
 
 RetainPtr preferences = adoptNS([[WKPreferences alloc] init]);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [199704] trunk/Source/WebCore

2016-04-18 Thread darin

Title: [199704] trunk/Source/WebCore








Revision 199704
Author da...@apple.com
Date 2016-04-18 19:58:44 -0700 (Mon, 18 Apr 2016)


Log Message
Remove all use of Deprecated::ScriptValue in generated bindings
https://bugs.webkit.org/show_bug.cgi?id=156706

Reviewed by Brady Eidson.

* Modules/indexeddb/IDBCursor.idl: Removed unneeded [ImplementationReturnType=JSValue].
* Modules/indexeddb/IDBCursorWithValue.idl: Ditto.

* Modules/indexeddb/IDBKeyRange.cpp:
(WebCore::IDBKeyRange::lowerValue): Deleted.
(WebCore::IDBKeyRange::upperValue): Deleted.
(WebCore::IDBKeyRange::only): Changed to take ExecState since the old code just used
the ScriptExecutionContext to get back to the (potentially wrong) ExecState. Also kept
one overload that takes ScriptExecutionContext because I could not change all callers.
(WebCore::IDBKeyRange::lowerBound): Ditto.
(WebCore::IDBKeyRange::upperBound): Ditto.
(WebCore::IDBKeyRange::bound): Ditto.

* Modules/indexeddb/IDBKeyRange.h: Updated for above.

* Modules/indexeddb/IDBKeyRange.idl: Use [ImplementationReturnType=IDBKey].
Use ScriptState instead of ScriptExecutionContext.

* Modules/streams/ReadableStreamSource.h: Take JSValue instead of Deprecated::ScriptValue
for the ignored argument to the cancel function.

* bindings/js/IDBBindingUtilities.cpp:
(WebCore::toJS): Renamed idbKeyToJSValue to this, the traditional name used in the
bindings generator for all these functions. Also changed to take references.
(WebCore::injectIDBKeyIntoScriptValue): Updated to call with the new name and types.
(WebCore::idbKeyDataToScriptValue): Ditto.

* bindings/js/IDBBindingUtilities.h: Added declaration of toJS for IDBKey.

* bindings/scripts/CodeGeneratorJS.pm: Use JSC::JSValue instead of Deprecated::ScriptValue
for the "any" type.
(JSValueToNative): Just return the value with no transformation when type is "any".
(NativeToJSValue): Changed default behavior for "any" to just pass the value as is with
no transfomration. Removed unused ImplementationReturnType case for inside Document.
Removed JSValue case since it's the default now. Added IDBKey case that matches the
IDBKeyPath case (still wondering if we can do those without an attribute). Removed bogus
second check for type "any".

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/indexeddb/IDBCursor.idl
trunk/Source/WebCore/Modules/indexeddb/IDBCursorWithValue.idl
trunk/Source/WebCore/Modules/indexeddb/IDBKeyRange.cpp
trunk/Source/WebCore/Modules/indexeddb/IDBKeyRange.h
trunk/Source/WebCore/Modules/indexeddb/IDBKeyRange.idl
trunk/Source/WebCore/Modules/streams/ReadableStreamSource.h
trunk/Source/WebCore/bindings/js/IDBBindingUtilities.cpp
trunk/Source/WebCore/bindings/js/IDBBindingUtilities.h
trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm




Diff

Modified: trunk/Source/WebCore/ChangeLog (199703 => 199704)

--- trunk/Source/WebCore/ChangeLog	2016-04-19 02:33:24 UTC (rev 199703)
+++ trunk/Source/WebCore/ChangeLog	2016-04-19 02:58:44 UTC (rev 199704)
@@ -1,3 +1,48 @@
+2016-04-18  Darin Adler  
+
+Remove all use of Deprecated::ScriptValue in generated bindings
+https://bugs.webkit.org/show_bug.cgi?id=156706
+
+Reviewed by Brady Eidson.
+
+* Modules/indexeddb/IDBCursor.idl: Removed unneeded [ImplementationReturnType=JSValue].
+* Modules/indexeddb/IDBCursorWithValue.idl: Ditto.
+
+* Modules/indexeddb/IDBKeyRange.cpp:
+(WebCore::IDBKeyRange::lowerValue): Deleted.
+(WebCore::IDBKeyRange::upperValue): Deleted.
+(WebCore::IDBKeyRange::only): Changed to take ExecState since the old code just used
+the ScriptExecutionContext to get back to the (potentially wrong) ExecState. Also kept
+one overload that takes ScriptExecutionContext because I could not change all callers.
+(WebCore::IDBKeyRange::lowerBound): Ditto.
+(WebCore::IDBKeyRange::upperBound): Ditto.
+(WebCore::IDBKeyRange::bound): Ditto.
+
+* Modules/indexeddb/IDBKeyRange.h: Updated for above.
+
+* Modules/indexeddb/IDBKeyRange.idl: Use [ImplementationReturnType=IDBKey].
+Use ScriptState instead of ScriptExecutionContext.
+
+* Modules/streams/ReadableStreamSource.h: Take JSValue instead of Deprecated::ScriptValue
+for the ignored argument to the cancel function.
+
+* bindings/js/IDBBindingUtilities.cpp:
+(WebCore::toJS): Renamed idbKeyToJSValue to this, the traditional name used in the
+bindings generator for all these functions. Also changed to take references.
+(WebCore::injectIDBKeyIntoScriptValue): Updated to call with the new name and types.
+(WebCore::idbKeyDataToScriptValue): Ditto.
+
+* bindings/js/IDBBindingUtilities.h: Added declaration of toJS for IDBKey.
+
+* bindings/scripts/CodeGeneratorJS.pm: Use JSC::JSValue instead of Deprecated::ScriptValue
+for the "any" type.
+(JSValueToNative): Just return the value

[webkit-changes] [199703] trunk

2016-04-18 Thread commit-queue

Title: [199703] trunk








Revision 199703
Author commit-qu...@webkit.org
Date 2016-04-18 19:33:24 -0700 (Mon, 18 Apr 2016)


Log Message
[GTK] Possible off-by-one in hyphenation code
https://bugs.webkit.org/show_bug.cgi?id=156661

Patch by Martin Robinson  on 2016-04-18
Reviewed by Michael Catanzaro.

Source/WebCore:

No new tests. This is covered by older tests.

* platform/text/hyphen/HyphenationLibHyphen.cpp:
(WebCore::lastHyphenLocation): Fix an off by one error in hyphen location.

LayoutTests:

* platform/gtk/TestExpectations: Unskip a test that is now passing.
* platform/gtk/fast/text/hyphenate-character-expected.png:
* platform/gtk/fast/text/hyphenate-character-expected.txt:
* platform/gtk/fast/text/hyphenate-first-word-expected.png:
* platform/gtk/fast/text/hyphenate-first-word-expected.txt:
* platform/gtk/fast/text/hyphenate-limit-before-after-expected.png:
* platform/gtk/fast/text/hyphenate-limit-before-after-expected.txt:
* platform/gtk/fast/text/hyphenate-limit-lines-expected.png:
* platform/gtk/fast/text/hyphenate-limit-lines-expected.txt:
* platform/gtk/fast/text/hyphenate-locale-expected.png:
* platform/gtk/fast/text/hyphenate-locale-expected.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/gtk/TestExpectations
trunk/LayoutTests/platform/gtk/fast/text/hyphenate-character-expected.png
trunk/LayoutTests/platform/gtk/fast/text/hyphenate-character-expected.txt
trunk/LayoutTests/platform/gtk/fast/text/hyphenate-first-word-expected.png
trunk/LayoutTests/platform/gtk/fast/text/hyphenate-first-word-expected.txt
trunk/LayoutTests/platform/gtk/fast/text/hyphenate-limit-before-after-expected.png
trunk/LayoutTests/platform/gtk/fast/text/hyphenate-limit-before-after-expected.txt
trunk/LayoutTests/platform/gtk/fast/text/hyphenate-limit-lines-expected.png
trunk/LayoutTests/platform/gtk/fast/text/hyphenate-limit-lines-expected.txt
trunk/LayoutTests/platform/gtk/fast/text/hyphenate-locale-expected.png
trunk/LayoutTests/platform/gtk/fast/text/hyphenate-locale-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/text/hyphen/HyphenationLibHyphen.cpp




Diff

Modified: trunk/LayoutTests/ChangeLog (199702 => 199703)

--- trunk/LayoutTests/ChangeLog	2016-04-19 02:18:45 UTC (rev 199702)
+++ trunk/LayoutTests/ChangeLog	2016-04-19 02:33:24 UTC (rev 199703)
@@ -1,3 +1,22 @@
+2016-04-18  Martin Robinson  
+
+[GTK] Possible off-by-one in hyphenation code
+https://bugs.webkit.org/show_bug.cgi?id=156661
+
+Reviewed by Michael Catanzaro.
+
+* platform/gtk/TestExpectations: Unskip a test that is now passing.
+* platform/gtk/fast/text/hyphenate-character-expected.png:
+* platform/gtk/fast/text/hyphenate-character-expected.txt:
+* platform/gtk/fast/text/hyphenate-first-word-expected.png:
+* platform/gtk/fast/text/hyphenate-first-word-expected.txt:
+* platform/gtk/fast/text/hyphenate-limit-before-after-expected.png:
+* platform/gtk/fast/text/hyphenate-limit-before-after-expected.txt:
+* platform/gtk/fast/text/hyphenate-limit-lines-expected.png:
+* platform/gtk/fast/text/hyphenate-limit-lines-expected.txt:
+* platform/gtk/fast/text/hyphenate-locale-expected.png:
+* platform/gtk/fast/text/hyphenate-locale-expected.txt:
+
 2016-04-18  Brent Fulgham  
 
 Unreviewed test fix after r199696.


Modified: trunk/LayoutTests/platform/gtk/TestExpectations (199702 => 199703)

--- trunk/LayoutTests/platform/gtk/TestExpectations	2016-04-19 02:18:45 UTC (rev 199702)
+++ trunk/LayoutTests/platform/gtk/TestExpectations	2016-04-19 02:33:24 UTC (rev 199703)
@@ -2400,8 +2400,6 @@
 webkit.org/b/143471 canvas/philip/tests/2d.drawImage.animated.poster.html [ Failure ]
 webkit.org/b/143871 svg/W3C-SVG-1.1-SE/linking-uri-01-b.svg [ Failure ]
 
-webkit.org/b/143924 fast/text/hyphen-min-preferred-width.html [ Skip ]
-
 webkit.org/b/144575 http/tests/loading/promote-img-preload-priority.html [ Failure ]
 
 webkit.org/b/144673 fast/forms/button-line-height.html [ ImageOnlyFailure ]


Modified: trunk/LayoutTests/platform/gtk/fast/text/hyphenate-character-expected.png

(Binary files differ)


Modified: trunk/LayoutTests/platform/gtk/fast/text/hyphenate-character-expected.txt (199702 => 199703)

--- trunk/LayoutTests/platform/gtk/fast/text/hyphenate-character-expected.txt	2016-04-19 02:18:45 UTC (rev 199702)
+++ trunk/LayoutTests/platform/gtk/fast/text/hyphenate-character-expected.txt	2016-04-19 02:33:24 UTC (rev 199703)
@@ -17,18 +17,18 @@
   RenderText {#text} at (7,7) size 330x200
 text run at (7,7) width 245: "The chief difficulty Alice found"
 text run at (7,27) width 245: "at first was in managing her"
-text run at (7,47) width 245: "flamingo: she succeeded in ge" + hyphen string "\x{2010}"
-text run at (7,67) width 222: "tting its body tucked away, "
-

[webkit-changes] [199702] trunk/Source/WebKit2

2016-04-18 Thread dino

Title: [199702] trunk/Source/WebKit2








Revision 199702
Author d...@apple.com
Date 2016-04-18 19:18:45 -0700 (Mon, 18 Apr 2016)


Log Message
New SPI to export a dictionary of runtime features
https://bugs.webkit.org/show_bug.cgi?id=156645


Trying to fix GTK and EFL builds. I forgot to add files
to CMake.

* CMakeLists.txt:
* PlatformMac.cmake:

Modified Paths

trunk/Source/WebKit2/CMakeLists.txt
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/PlatformMac.cmake




Diff

Modified: trunk/Source/WebKit2/CMakeLists.txt (199701 => 199702)

--- trunk/Source/WebKit2/CMakeLists.txt	2016-04-19 01:52:24 UTC (rev 199701)
+++ trunk/Source/WebKit2/CMakeLists.txt	2016-04-19 02:18:45 UTC (rev 199702)
@@ -396,6 +396,7 @@
 UIProcess/WebVibrationProxy.cpp
 UIProcess/WebViewportAttributes.cpp
 
+UIProcess/API/APIExperimentalFeature.cpp
 UIProcess/API/APIFrameInfo.cpp
 UIProcess/API/APIHitTestResult.cpp
 UIProcess/API/APINavigation.cpp


Modified: trunk/Source/WebKit2/ChangeLog (199701 => 199702)

--- trunk/Source/WebKit2/ChangeLog	2016-04-19 01:52:24 UTC (rev 199701)
+++ trunk/Source/WebKit2/ChangeLog	2016-04-19 02:18:45 UTC (rev 199702)
@@ -4,6 +4,18 @@
 https://bugs.webkit.org/show_bug.cgi?id=156645
 
 
+Trying to fix GTK and EFL builds. I forgot to add files
+to CMake.
+
+* CMakeLists.txt:
+* PlatformMac.cmake:
+
+2016-04-18  Dean Jackson  
+
+New SPI to export a dictionary of runtime features
+https://bugs.webkit.org/show_bug.cgi?id=156645
+
+
 Reviewed by Darin Adler.
 
 Add a new type of Preference for experimental features so that we


Modified: trunk/Source/WebKit2/PlatformMac.cmake (199701 => 199702)

--- trunk/Source/WebKit2/PlatformMac.cmake	2016-04-19 01:52:24 UTC (rev 199701)
+++ trunk/Source/WebKit2/PlatformMac.cmake	2016-04-19 02:18:45 UTC (rev 199702)
@@ -73,6 +73,7 @@
 Shared/API/Cocoa/WKRemoteObject.mm
 Shared/API/Cocoa/WKRemoteObjectCoder.mm
 Shared/API/Cocoa/WebKit.m
+Shared/API/Cocoa/_WKExperimentalFeature.mm
 Shared/API/Cocoa/_WKFrameHandle.mm
 Shared/API/Cocoa/_WKHitTestResult.mm
 Shared/API/Cocoa/_WKNSFileManagerExtras.mm






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [199701] trunk/Source/WebCore

2016-04-18 Thread eric . carlson

Title: [199701] trunk/Source/WebCore








Revision 199701
Author eric.carl...@apple.com
Date 2016-04-18 18:52:24 -0700 (Mon, 18 Apr 2016)


Log Message
[OSX] AVKit is not available on all systems
https://bugs.webkit.org/show_bug.cgi?id=156724


Reviewed by Dean Jackson.

* platform/graphics/avfoundation/objc/MediaPlaybackTargetPickerMac.mm: Add _OPTIONAL to all
  AVKit softlink macros.
* platform/ios/WebAVPlayerController.mm: Ditto.
* platform/ios/WebPlaybackSessionInterfaceAVKit.mm: Ditto.
* platform/ios/WebVideoFullscreenInterfaceAVKit.mm: Ditto.
* platform/mac/WebPlaybackSessionInterfaceMac.mm: Ditto.
* platform/mac/WebVideoFullscreenInterfaceMac.mm: Ditto.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlaybackTargetPickerMac.mm
trunk/Source/WebCore/platform/ios/WebAVPlayerController.mm
trunk/Source/WebCore/platform/ios/WebPlaybackSessionInterfaceAVKit.mm
trunk/Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm
trunk/Source/WebCore/platform/mac/WebPlaybackSessionInterfaceMac.mm
trunk/Source/WebCore/platform/mac/WebVideoFullscreenInterfaceMac.mm




Diff

Modified: trunk/Source/WebCore/ChangeLog (199700 => 199701)

--- trunk/Source/WebCore/ChangeLog	2016-04-19 01:46:48 UTC (rev 199700)
+++ trunk/Source/WebCore/ChangeLog	2016-04-19 01:52:24 UTC (rev 199701)
@@ -1,3 +1,19 @@
+2016-04-18  Eric Carlson  
+
+[OSX] AVKit is not available on all systems
+https://bugs.webkit.org/show_bug.cgi?id=156724
+
+
+Reviewed by Dean Jackson.
+
+* platform/graphics/avfoundation/objc/MediaPlaybackTargetPickerMac.mm: Add _OPTIONAL to all
+  AVKit softlink macros.
+* platform/ios/WebAVPlayerController.mm: Ditto.
+* platform/ios/WebPlaybackSessionInterfaceAVKit.mm: Ditto.
+* platform/ios/WebVideoFullscreenInterfaceAVKit.mm: Ditto.
+* platform/mac/WebPlaybackSessionInterfaceMac.mm: Ditto.
+* platform/mac/WebVideoFullscreenInterfaceMac.mm: Ditto.
+
 2016-04-18  Gavin Barraclough  
 
 WebKit should adopt journal_mode=wal for all SQLite databases.


Modified: trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlaybackTargetPickerMac.mm (199700 => 199701)

--- trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlaybackTargetPickerMac.mm	2016-04-19 01:46:48 UTC (rev 199700)
+++ trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlaybackTargetPickerMac.mm	2016-04-19 01:52:24 UTC (rev 199701)
@@ -43,8 +43,8 @@
 SOFT_LINK_FRAMEWORK_OPTIONAL(AVFoundation)
 SOFT_LINK_FRAMEWORK_OPTIONAL(AVKit)
 
-SOFT_LINK_CLASS(AVFoundation, AVOutputContext)
-SOFT_LINK_CLASS(AVKit, AVOutputDeviceMenuController)
+SOFT_LINK_CLASS_OPTIONAL(AVFoundation, AVOutputContext)
+SOFT_LINK_CLASS_OPTIONAL(AVKit, AVOutputDeviceMenuController)
 
 using namespace WebCore;
 


Modified: trunk/Source/WebCore/platform/ios/WebAVPlayerController.mm (199700 => 199701)

--- trunk/Source/WebCore/platform/ios/WebAVPlayerController.mm	2016-04-19 01:46:48 UTC (rev 199700)
+++ trunk/Source/WebCore/platform/ios/WebAVPlayerController.mm	2016-04-19 01:52:24 UTC (rev 199701)
@@ -41,8 +41,8 @@
 
 #import "CoreMediaSoftLink.h"
 
-SOFT_LINK_FRAMEWORK(AVKit)
-SOFT_LINK_CLASS(AVKit, AVPlayerController)
+SOFT_LINK_FRAMEWORK_OPTIONAL(AVKit)
+SOFT_LINK_CLASS_OPTIONAL(AVKit, AVPlayerController)
 
 using namespace WebCore;
 
@@ -50,6 +50,9 @@
 
 - (instancetype)init
 {
+if (!getAVPlayerController())
+return nil;
+
 if (!(self = [super init]))
 return self;
 


Modified: trunk/Source/WebCore/platform/ios/WebPlaybackSessionInterfaceAVKit.mm (199700 => 199701)

--- trunk/Source/WebCore/platform/ios/WebPlaybackSessionInterfaceAVKit.mm	2016-04-19 01:46:48 UTC (rev 199700)
+++ trunk/Source/WebCore/platform/ios/WebPlaybackSessionInterfaceAVKit.mm	2016-04-19 01:52:24 UTC (rev 199701)
@@ -42,8 +42,8 @@
 
 #import "CoreMediaSoftLink.h"
 
-SOFT_LINK_FRAMEWORK(AVKit)
-SOFT_LINK_CLASS(AVKit, AVValueTiming)
+SOFT_LINK_FRAMEWORK_OPTIONAL(AVKit)
+SOFT_LINK_CLASS_OPTIONAL(AVKit, AVValueTiming)
 
 namespace WebCore {
 


Modified: trunk/Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm (199700 => 199701)

--- trunk/Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm	2016-04-19 01:46:48 UTC (rev 199700)
+++ trunk/Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm	2016-04-19 01:52:24 UTC (rev 199701)
@@ -61,10 +61,10 @@
 SOFT_LINK_CONSTANT(AVFoundation, AVLayerVideoGravityResizeAspect, NSString *)
 SOFT_LINK_CONSTANT(AVFoundation, AVLayerVideoGravityResizeAspectFill, NSString *)
 
-SOFT_LINK_FRAMEWORK(AVKit)
-SOFT_LINK_CLASS(AVKit, AVPictureInPictureController)
-SOFT_LINK_CLASS(AVKit, AVPlayerViewController)
-SOFT_LINK_CLASS(AVKit, __AVPlayerLayerView)
+SOFT_LINK_FRAMEWORK_OPTIONAL(AVKit)
+SOFT_LINK_CLASS_OPTIONAL(AVKit, AVPictureInPictureController)
+SOFT_LINK_CLASS_OPTIONAL(AVKit,

[webkit-changes] [199700] trunk

2016-04-18 Thread dino

Title: [199700] trunk

Revision 199700
Author d...@apple.com
Date 2016-04-18 18:46:48 -0700 (Mon, 18 Apr 2016)

Log Message
New SPI to export a dictionary of runtime features
https://bugs.webkit.org/show_bug.cgi?id=156645

Reviewed by Darin Adler.

Source/WebKit2:

Add a new type of Preference for experimental features so that we
can dynamically toggle them from a WebKit2 host. These are special
keys that are tied to runtime flags. The host process can ask WebKit
for the list of keys, each with a small description, in order to
display UI.

- Add HumanReadableName and HumanReadableDescription parameters to our
macros, which are used when building a ExperimentalFeature.
These are both empty strings for the existing preferences. At some
point we should probably move all this to code generation rather
than macros, so that we don't have to carry around unused parameters.

- I've included two sample experimental features: WebGL2 and ShadowDOM.
They are not actually hooked up to the runtime settings yet, but its
pretty clear how that will happen. Note that these are new preferences
that have an "Experimental" prefix. This is so toggling an experimental
feature to off won't cause the feature to not work once it becomes
stable enough to enable by default. In other words, when it moves
out of the experimental stage, the experimental feature flag will be
removed, and you'll no longer check for values with that key.

- The ExperimentalFeature object is what the host process
will read in order to show some UI. It contains the human readable info,
as well as the actual key that can be used to query and toggle the
experimental feature.

* Shared/API/APIObject.h: Add the ExperimentalFeature.

* Shared/Cocoa/APIObject.mm:
(API::Object::newObject): Exposes a wrapper around a _WKExperimentalFeature ObjC type.

* Shared/WebPreferencesDefinitions.h: Change all the existing macros to take the new
parameters, and add the initial experimental keys.

* Shared/WebPreferencesKeys.cpp: Add new parameters to existing macros.
* Shared/WebPreferencesKeys.h: Ditto.
* Shared/WebPreferencesStore.cpp: Ditto.
(WebKit::defaults):

* UIProcess/API/APIExperimentalFeature.cpp: The API side of the ExperimentalFeature.
(API::ExperimentalFeature::create):
(API::ExperimentalFeature::ExperimentalFeature):
(API::ExperimentalFeature::~ExperimentalFeature):
* UIProcess/API/APIExperimentalFeature.h:

* UIProcess/API/Cocoa/WKPreferences.mm: The actual implementation of the SPI.
(+[WKPreferences _experimentalFeatures]): Create and return a list of feature descriptors.
(-[WKPreferences _isEnabledForFeature:]): Get the value.
(-[WKPreferences _setEnabled:forFeature:]): Set the value.
* UIProcess/API/Cocoa/WKPreferencesPrivate.h:

* UIProcess/API/Cocoa/_WKExperimentalFeature.h: The ObjC version.
* UIProcess/API/Cocoa/_WKExperimentalFeature.mm:
(-[_WKExperimentalFeature dealloc]):
(-[_WKExperimentalFeature description]):
(-[_WKExperimentalFeature name]):
(-[_WKExperimentalFeature key]):
(-[_WKExperimentalFeature details]):
(-[_WKExperimentalFeature _apiObject]):
* UIProcess/API/Cocoa/_WKExperimentalFeatureInternal.h: Implementation of the wrapper.
(WebKit::wrapper):

* UIProcess/WebPreferences.cpp: The C++ implementation that provides the data for the ObjC API.
(WebKit::globalExperimentalFeatures):
(WebKit::WebPreferences::ExperimentalFeatures):
(WebKit::WebPreferences::isEnabledForFeature):
(WebKit::WebPreferences::setEnabledForFeature):
* UIProcess/WebPreferences.h:

* UIProcess/mac/WebPreferencesMac.mm: Update some macros.
(WebKit::WebPreferences::platformInitializeStore):
* WebProcess/WebPage/WebPage.cpp: Ditto
(WebKit::WebPage::updatePreferences):

* WebKit2.xcodeproj/project.pbxproj: Add the new files.

Tools:

Test the experimental features SPI on WKPreferences.

* TestWebKitAPI/Tests/WebKit2Cocoa/Preferences.mm:

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/Shared/API/APIObject.h
trunk/Source/WebKit2/Shared/Cocoa/APIObject.mm
trunk/Source/WebKit2/Shared/WebPreferencesDefinitions.h
trunk/Source/WebKit2/Shared/WebPreferencesKeys.cpp
trunk/Source/WebKit2/Shared/WebPreferencesKeys.h
trunk/Source/WebKit2/Shared/WebPreferencesStore.cpp
trunk/Source/WebKit2/UIProcess/API/C/WKAPICast.h
trunk/Source/WebKit2/UIProcess/API/Cocoa/WKPreferences.mm
trunk/Source/WebKit2/UIProcess/API/Cocoa/WKPreferencesPrivate.h
trunk/Source/WebKit2/UIProcess/WebPreferences.cpp
trunk/Source/WebKit2/UIProcess/WebPreferences.h
trunk/Source/WebKit2/UIProcess/mac/WebPreferencesMac.mm
trunk/Source/WebKit2/WebKit2.xcodeproj/project.pbxproj
trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/Preferences.mm

Added Paths

trunk/Source/WebKit2/UIProcess/API/APIExperimentalFeature.cpp
trunk/Source/WebKit2/UIProcess/API/APIExperimentalFeature.h
trunk/Source/WebKit2/UIProcess/API/Cocoa/_WKExperimentalFeature.h

[webkit-changes] [199699] trunk/Source/JavaScriptCore

2016-04-18 Thread sbarati

Title: [199699] trunk/Source/_javascript_Core








Revision 199699
Author sbar...@apple.com
Date 2016-04-18 18:38:30 -0700 (Mon, 18 Apr 2016)


Log Message
implement dynamic scope accesses in the DFG/FTL
https://bugs.webkit.org/show_bug.cgi?id=156567

Reviewed by Geoffrey Garen.

This patch adds dynamic scope operations to the DFG/FTL.
This patch adds three new DFG nodes: ResolveScope, PutDynamicVar and GetDynamicVar.
When we encounter a Dynamic/UnresolvedProperty/UnresolvedPropertyWithVarInjectionChecks
resolve type, we will compile dynamic scope resolution nodes. When we encounter
a resolve type that needs var injection checks and the var injection
watchpoint has already been fired, we will compile dynamic scope resolution
nodes.

This patch also adds a new value to the InitializationMode enum: ConstInitialization.
There was a subtle bug where we used to never compile the var injection variant of the
resolve type for an eval that injected a var where there was also a global lexical variable with the same name.
For example, the store compiled in this eval("var foo = 20;") wouldn't be compiled
with var injection checks if there was global let/const variable named "foo".
So there was the potential for the injected var to store to the GlobalLexicalObject.
I found this bug because my initial implementation in the DFG/FTL ran into it.
The reason this bug existed is because when we compile a const initialization,
we never need a var injections check. The const initialization always
knows where to store its value. This same logic leaked into the above eval's
"var foo = 20" store. This new enum value allows us to distinguish const
initialization stores from non-const initialization stores.

(I also changed InitializationMode to be an enum class instead of an enum).

* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::finishCreation):
* bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::generate):
(JSC::BytecodeGenerator::BytecodeGenerator):
(JSC::BytecodeGenerator::initializeDefaultParameterValuesAndSetupFunctionScopeStack):
(JSC::BytecodeGenerator::initializeBlockScopedFunctions):
(JSC::BytecodeGenerator::hoistSloppyModeFunctionIfNecessary):
(JSC::BytecodeGenerator::prepareLexicalScopeForNextForLoopIteration):
(JSC::BytecodeGenerator::emitGetFromScope):
(JSC::BytecodeGenerator::initializeVariable):
(JSC::BytecodeGenerator::emitInstanceOf):
(JSC::BytecodeGenerator::emitPushFunctionNameScope):
(JSC::BytecodeGenerator::pushScopedControlFlowContext):
(JSC::BytecodeGenerator::emitPutNewTargetToArrowFunctionContextScope):
(JSC::BytecodeGenerator::emitPutDerivedConstructorToArrowFunctionContextScope):
(JSC::BytecodeGenerator::emitPutThisToArrowFunctionContextScope):
* bytecompiler/NodesCodegen.cpp:
(JSC::PostfixNode::emitResolve):
(JSC::PrefixNode::emitResolve):
(JSC::ReadModifyResolveNode::emitBytecode):
(JSC::initializationModeForAssignmentContext):
(JSC::AssignResolveNode::emitBytecode):
(JSC::EmptyLetExpression::emitBytecode):
(JSC::ForInNode::emitLoopHeader):
(JSC::ForOfNode::emitBytecode):
(JSC::ClassExprNode::emitBytecode):
(JSC::BindingNode::bindValue):
(JSC::AssignmentElementNode::bindValue):
(JSC::RestParameterNode::emit):
* dfg/DFGAbstractInterpreterInlines.h:
(JSC::DFG::AbstractInterpreter::executeEffects):
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::noticeArgumentsUse):
(JSC::DFG::ByteCodeParser::promoteToConstant):
(JSC::DFG::ByteCodeParser::needsDynamicLookup):
(JSC::DFG::ByteCodeParser::planLoad):
(JSC::DFG::ByteCodeParser::parseBlock):
* dfg/DFGCapabilities.cpp:
(JSC::DFG::capabilityLevel):
* dfg/DFGClobberize.h:
(JSC::DFG::clobberize):
* dfg/DFGDoesGC.cpp:
(JSC::DFG::doesGC):
* dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::fixupNode):
* dfg/DFGNode.h:
(JSC::DFG::Node::hasIdentifier):
(JSC::DFG::Node::identifierNumber):
(JSC::DFG::Node::hasGetPutInfo):
(JSC::DFG::Node::getPutInfo):
(JSC::DFG::Node::hasAccessorAttributes):
* dfg/DFGNodeType.h:
* dfg/DFGOperations.cpp:
* dfg/DFGOperations.h:
* dfg/DFGPredictionPropagationPhase.cpp:
(JSC::DFG::PredictionPropagationPhase::propagate):
* dfg/DFGSafeToExecute.h:
(JSC::DFG::safeToExecute):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compilePutGetterSetterById):
(JSC::DFG::SpeculativeJIT::compileResolveScope):
(JSC::DFG::SpeculativeJIT::compileGetDynamicVar):
(JSC::DFG::SpeculativeJIT::compilePutDynamicVar):
(JSC::DFG::SpeculativeJIT::compilePutAccessorByVal):
* dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::callOperation):
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* ftl/FTLCapabilities.cpp:
(JSC::FTL::canCompile):
* ftl/FTLLowerDFGToB3.cpp:
(JSC::FTL::DFG::LowerDFGToB3::compileNode):
(JSC::FTL::DFG::LowerDFGToB3::compare):
(JSC::FTL::DFG::LowerDFGToB3::compileResolveScope):
(JSC::FTL::DFG::LowerDFGToB3::compileGetDynamicVar):
(JSC::FTL::DFG::LowerDFGToB3::compilePutDynamicVar):

[webkit-changes] [199698] trunk/LayoutTests

2016-04-18 Thread bfulgham

Title: [199698] trunk/LayoutTests








Revision 199698
Author bfulg...@apple.com
Date 2016-04-18 17:25:12 -0700 (Mon, 18 Apr 2016)


Log Message
Unreviewed test fix after r199696.

* inspector/console/x-frame-options-message-expected.txt: Rebaseline.):

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/inspector/console/x-frame-options-message-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (199697 => 199698)

--- trunk/LayoutTests/ChangeLog	2016-04-19 00:21:20 UTC (rev 199697)
+++ trunk/LayoutTests/ChangeLog	2016-04-19 00:25:12 UTC (rev 199698)
@@ -1,3 +1,9 @@
+2016-04-18  Brent Fulgham  
+
+Unreviewed test fix after r199696.
+
+* inspector/console/x-frame-options-message-expected.txt: Rebaseline.):
+
 2016-04-18  Gavin Barraclough  
 
 WebKit should adopt journal_mode=wal for all SQLite databases.


Modified: trunk/LayoutTests/inspector/console/x-frame-options-message-expected.txt (199697 => 199698)

--- trunk/LayoutTests/inspector/console/x-frame-options-message-expected.txt	2016-04-19 00:21:20 UTC (rev 199697)
+++ trunk/LayoutTests/inspector/console/x-frame-options-message-expected.txt	2016-04-19 00:25:12 UTC (rev 199698)
@@ -1,4 +1,4 @@
-CONSOLE MESSAGE: line 41: X-Frame-Options may only be set via an HTTP header sent along with a document. It may not be set inside .
+CONSOLE MESSAGE: line 41: The X-Frame-Option 'deny' supplied in a  element was ignored. X-Frame-Options may only be provided by an HTTP header sent with the document.
 
 
 == Running test suite: Console.XFrameOptionsMessages






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [199697] trunk

2016-04-18 Thread barraclough

Title: [199697] trunk








Revision 199697
Author barraclo...@apple.com
Date 2016-04-18 17:21:20 -0700 (Mon, 18 Apr 2016)


Log Message
WebKit should adopt journal_mode=wal for all SQLite databases.
https://bugs.webkit.org/show_bug.cgi?id=133496

Reviewed by Brady Eidson.

Enabling sqlite3 WAL mode on iOS causes a test failure, but appears just be something that should fail still failing, only in a different way.
Enabling & marking test as failing for now. Tracking test failure here:
https://bugs.webkit.org/show_bug.cgi?id=156718

Source/WebCore:

* platform/sql/SQLiteDatabase.cpp:
(WebCore::SQLiteDatabase::open):
- enable on iOS.

LayoutTests:

* platform/ios-simulator/TestExpectations:
- storage/websql/alter-to-info-table.html [ Failure ]

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/ios-simulator/TestExpectations
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/sql/SQLiteDatabase.cpp




Diff

Modified: trunk/LayoutTests/ChangeLog (199696 => 199697)

--- trunk/LayoutTests/ChangeLog	2016-04-18 23:07:54 UTC (rev 199696)
+++ trunk/LayoutTests/ChangeLog	2016-04-19 00:21:20 UTC (rev 199697)
@@ -1,3 +1,17 @@
+2016-04-18  Gavin Barraclough  
+
+WebKit should adopt journal_mode=wal for all SQLite databases.
+https://bugs.webkit.org/show_bug.cgi?id=133496
+
+Reviewed by Brady Eidson.
+
+Enabling sqlite3 WAL mode on iOS causes a test failure, but appears just be something that should fail still failing, only in a different way.
+Enabling & marking test as failing for now. Tracking test failure here:
+https://bugs.webkit.org/show_bug.cgi?id=156718
+
+* platform/ios-simulator/TestExpectations:
+- storage/websql/alter-to-info-table.html [ Failure ]
+
 2016-04-18  Chris Dumez  
 
 Crash in ElementDescendantIterator::operator--() when calling m_ancestorSiblingStack.last()


Modified: trunk/LayoutTests/platform/ios-simulator/TestExpectations (199696 => 199697)

--- trunk/LayoutTests/platform/ios-simulator/TestExpectations	2016-04-18 23:07:54 UTC (rev 199696)
+++ trunk/LayoutTests/platform/ios-simulator/TestExpectations	2016-04-19 00:21:20 UTC (rev 199697)
@@ -2541,6 +2541,7 @@
 
 # storage tests that fail:
 storage/websql/sql-error-codes.html [ Failure ]
+storage/websql/alter-to-info-table.html [ Failure ]
 
 # iOS-specific tests that fail:
 platform/ios-simulator/ios/compositing/overlap-page-scale.html [ Failure ]


Modified: trunk/Source/WebCore/ChangeLog (199696 => 199697)

--- trunk/Source/WebCore/ChangeLog	2016-04-18 23:07:54 UTC (rev 199696)
+++ trunk/Source/WebCore/ChangeLog	2016-04-19 00:21:20 UTC (rev 199697)
@@ -1,3 +1,18 @@
+2016-04-18  Gavin Barraclough  
+
+WebKit should adopt journal_mode=wal for all SQLite databases.
+https://bugs.webkit.org/show_bug.cgi?id=133496
+
+Reviewed by Brady Eidson.
+
+Enabling sqlite3 WAL mode on iOS causes a test failure, but appears just be something that should fail still failing, only in a different way.
+Enabling & marking test as failing for now. Tracking test failure here:
+https://bugs.webkit.org/show_bug.cgi?id=156718
+
+* platform/sql/SQLiteDatabase.cpp:
+(WebCore::SQLiteDatabase::open):
+- enable on iOS.
+
 2016-04-18  Brent Fulgham  
 
 Remove support for X-Frame-Options in ``


Modified: trunk/Source/WebCore/platform/sql/SQLiteDatabase.cpp (199696 => 199697)

--- trunk/Source/WebCore/platform/sql/SQLiteDatabase.cpp	2016-04-18 23:07:54 UTC (rev 199696)
+++ trunk/Source/WebCore/platform/sql/SQLiteDatabase.cpp	2016-04-19 00:21:20 UTC (rev 199697)
@@ -115,7 +115,6 @@
 if (!SQLiteStatement(*this, ASCIILiteral("PRAGMA temp_store = MEMORY;")).executeCommand())
 LOG_ERROR("SQLite database could not set temp_store to memory");
 
-#if !PLATFORM(IOS)
 SQLiteStatement walStatement(*this, ASCIILiteral("PRAGMA journal_mode=WAL;"));
 if (walStatement.prepareAndStep() == SQLITE_ROW) {
 #ifndef NDEBUG
@@ -125,7 +124,6 @@
 #endif
 } else
 LOG_ERROR("SQLite database failed to set journal_mode to WAL, error: %s", lastErrorMsg());
-#endif
 
 return isOpen();
 }






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [199696] trunk

2016-04-18 Thread bfulgham

Title: [199696] trunk








Revision 199696
Author bfulg...@apple.com
Date 2016-04-18 16:07:54 -0700 (Mon, 18 Apr 2016)


Log Message

Source/WebCore:
Remove support for X-Frame-Options in ``
https://bugs.webkit.org/show_bug.cgi?id=156625


Rubberstamped by Darin Adler.

* dom/Document.cpp:
(WebCore::Document::processHttpEquiv): Revise messaging based on Darin's comments.

LayoutTests:
Crash in ElementDescendantIterator::operator--() when calling m_ancestorSiblingStack.last()
https://bugs.webkit.org/show_bug.cgi?id=156715


Patch by Chris Dumez  on 2016-04-18
Reviewed by Antti Koivisto.

Add regression test that reproduced the crash.

* fast/dom/collection-backward-traversal-crash-expected.txt: Added.
* fast/dom/collection-backward-traversal-crash.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/http/tests/security/XFrameOptions/x-frame-options-ignore-deny-meta-tag-expected.txt
trunk/LayoutTests/http/tests/security/XFrameOptions/x-frame-options-ignore-deny-meta-tag-in-body-expected.txt
trunk/LayoutTests/http/tests/security/XFrameOptions/x-frame-options-ignore-deny-meta-tag-parent-same-origin-allow-expected.txt
trunk/LayoutTests/http/tests/security/XFrameOptions/x-frame-options-ignore-deny-meta-tag-parent-same-origin-deny-expected.txt
trunk/LayoutTests/http/tests/security/xssAuditor/meta-tag-http-refresh-x-frame-options-ignored-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/Document.cpp




Diff

Modified: trunk/LayoutTests/ChangeLog (199695 => 199696)

--- trunk/LayoutTests/ChangeLog	2016-04-18 23:00:29 UTC (rev 199695)
+++ trunk/LayoutTests/ChangeLog	2016-04-18 23:07:54 UTC (rev 199696)
@@ -13,6 +13,20 @@
 
 2016-04-18  Brent Fulgham  
 
+Remove support for X-Frame-Options in ``
+https://bugs.webkit.org/show_bug.cgi?id=156625
+
+
+Rubberstamped by Darin Adler.
+
+* http/tests/security/XFrameOptions/x-frame-options-ignore-deny-meta-tag-expected.txt:
+* http/tests/security/XFrameOptions/x-frame-options-ignore-deny-meta-tag-in-body-expected.txt:
+* http/tests/security/XFrameOptions/x-frame-options-ignore-deny-meta-tag-parent-same-origin-allow-expected.txt:
+* http/tests/security/XFrameOptions/x-frame-options-ignore-deny-meta-tag-parent-same-origin-deny-expected.txt:
+* http/tests/security/xssAuditor/meta-tag-http-refresh-x-frame-options-ignored-expected.txt:
+
+2016-04-18  Brent Fulgham  
+
 CSP: Remove stubs for dynamically-added favicons (via link rel="icon")
 https://bugs.webkit.org/show_bug.cgi?id=153151
 


Modified: trunk/LayoutTests/http/tests/security/XFrameOptions/x-frame-options-ignore-deny-meta-tag-expected.txt (199695 => 199696)

--- trunk/LayoutTests/http/tests/security/XFrameOptions/x-frame-options-ignore-deny-meta-tag-expected.txt	2016-04-18 23:00:29 UTC (rev 199695)
+++ trunk/LayoutTests/http/tests/security/XFrameOptions/x-frame-options-ignore-deny-meta-tag-expected.txt	2016-04-18 23:07:54 UTC (rev 199696)
@@ -1,7 +1,7 @@
 http://127.0.0.1:8000/security/XFrameOptions/resources/x-frame-options-deny-meta-tag-subframe.html - willSendRequest  redirectResponse (null)
 http://127.0.0.1:8000/security/XFrameOptions/x-frame-options-ignore-deny-meta-tag.html - didFinishLoading
 http://127.0.0.1:8000/security/XFrameOptions/resources/x-frame-options-deny-meta-tag-subframe.html - didReceiveResponse 
-CONSOLE MESSAGE: line 3: X-Frame-Options may only be set via an HTTP header sent along with a document. It may not be set inside .
+CONSOLE MESSAGE: line 3: The X-Frame-Option 'deny' supplied in a  element was ignored. X-Frame-Options may only be provided by an HTTP header sent with the document.
 CONSOLE MESSAGE: line 15: PASS: Could read contentWindow.location.href
 There should be content in the iframe below
 


Modified: trunk/LayoutTests/http/tests/security/XFrameOptions/x-frame-options-ignore-deny-meta-tag-in-body-expected.txt (199695 => 199696)

--- trunk/LayoutTests/http/tests/security/XFrameOptions/x-frame-options-ignore-deny-meta-tag-in-body-expected.txt	2016-04-18 23:00:29 UTC (rev 199695)
+++ trunk/LayoutTests/http/tests/security/XFrameOptions/x-frame-options-ignore-deny-meta-tag-in-body-expected.txt	2016-04-18 23:07:54 UTC (rev 199696)
@@ -1,7 +1,7 @@
 http://127.0.0.1:8000/security/XFrameOptions/resources/x-frame-options-deny-meta-tag-subframe-in-body.html - willSendRequest  redirectResponse (null)
 http://127.0.0.1:8000/security/XFrameOptions/x-frame-options-ignore-deny-meta-tag-in-body.html - didFinishLoading
 http://127.0.0.1:8000/security/XFrameOptions/resources/x-frame-options-deny-meta-tag-subframe-in-body.html - didReceiveResponse 
-CONSOLE MESSAGE: line 6: X-Frame-Options may only be set via an HTTP header sent along with a document. It may not be set inside .
+CONSOLE MESSAGE: line 6: The X-Frame-Option 'deny' supplied in a  element was ignored. X-Frame-Options may only be provided by

[webkit-changes] [199695] trunk/Source/WebKit2

2016-04-18 Thread timothy_horton

Title: [199695] trunk/Source/WebKit2








Revision 199695
Author timothy_hor...@apple.com
Date 2016-04-18 16:00:29 -0700 (Mon, 18 Apr 2016)


Log Message
Swipe view gesture should be reversed in right-to-left contexts
https://bugs.webkit.org/show_bug.cgi?id=156714

Reviewed by Anders Carlsson.

* UIProcess/API/gtk/PageClientImpl.h:
* UIProcess/PageClient.h:
* UIProcess/UserInterfaceLayoutDirection.h: Added.
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::userInterfaceLayoutDirection):
* UIProcess/WebPageProxy.h:
* UIProcess/ios/PageClientImplIOS.h:
* UIProcess/ios/PageClientImplIOS.mm:
(WebKit::PageClientImpl::userInterfaceLayoutDirection):
* UIProcess/mac/PageClientImpl.h:
* UIProcess/mac/PageClientImpl.mm:
(WebKit::PageClientImpl::userInterfaceLayoutDirection):
Plumb RTL-ness through to WebPageProxy.
We look at the WK(Web)View's UI layout direction.
For other platforms, we just assume LTR.

* UIProcess/mac/ViewGestureController.h:
* UIProcess/mac/ViewGestureControllerMac.mm:
(WebKit::ViewGestureController::PendingSwipeTracker::scrollEventCanBecomeSwipe):
Decide which way to swipe (and which way to look for back-forward items)
based on the WebPageProxy's reported RTLness.

(WebKit::ViewGestureController::isPhysicallySwipingLeft):
"Back" means "swiping left" in LTR and "swiping right" in RTL.

(WebKit::ViewGestureController::trackSwipeGesture):
(WebKit::ViewGestureController::determineLayerAdjacentToSnapshotForParent):
(WebKit::ViewGestureController::beginSwipeGesture):
(WebKit::ViewGestureController::handleSwipeGesture):
Make things that were equating "back" with "left" instead check isPhysicallySwipingLeft.

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/gtk/PageClientImpl.h
trunk/Source/WebKit2/UIProcess/PageClient.h
trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp
trunk/Source/WebKit2/UIProcess/WebPageProxy.h
trunk/Source/WebKit2/UIProcess/efl/WebView.h
trunk/Source/WebKit2/UIProcess/ios/PageClientImplIOS.h
trunk/Source/WebKit2/UIProcess/ios/PageClientImplIOS.mm
trunk/Source/WebKit2/UIProcess/mac/PageClientImpl.h
trunk/Source/WebKit2/UIProcess/mac/PageClientImpl.mm
trunk/Source/WebKit2/UIProcess/mac/ViewGestureController.h
trunk/Source/WebKit2/UIProcess/mac/ViewGestureControllerMac.mm


Added Paths

trunk/Source/WebKit2/UIProcess/UserInterfaceLayoutDirection.h




Diff

Modified: trunk/Source/WebKit2/ChangeLog (199694 => 199695)

--- trunk/Source/WebKit2/ChangeLog	2016-04-18 22:59:31 UTC (rev 199694)
+++ trunk/Source/WebKit2/ChangeLog	2016-04-18 23:00:29 UTC (rev 199695)
@@ -1,3 +1,41 @@
+2016-04-18  Tim Horton  
+
+Swipe view gesture should be reversed in right-to-left contexts
+https://bugs.webkit.org/show_bug.cgi?id=156714
+
+Reviewed by Anders Carlsson.
+
+* UIProcess/API/gtk/PageClientImpl.h:
+* UIProcess/PageClient.h:
+* UIProcess/UserInterfaceLayoutDirection.h: Added.
+* UIProcess/WebPageProxy.cpp:
+(WebKit::WebPageProxy::userInterfaceLayoutDirection):
+* UIProcess/WebPageProxy.h:
+* UIProcess/ios/PageClientImplIOS.h:
+* UIProcess/ios/PageClientImplIOS.mm:
+(WebKit::PageClientImpl::userInterfaceLayoutDirection):
+* UIProcess/mac/PageClientImpl.h:
+* UIProcess/mac/PageClientImpl.mm:
+(WebKit::PageClientImpl::userInterfaceLayoutDirection):
+Plumb RTL-ness through to WebPageProxy.
+We look at the WK(Web)View's UI layout direction.
+For other platforms, we just assume LTR.
+
+* UIProcess/mac/ViewGestureController.h:
+* UIProcess/mac/ViewGestureControllerMac.mm:
+(WebKit::ViewGestureController::PendingSwipeTracker::scrollEventCanBecomeSwipe):
+Decide which way to swipe (and which way to look for back-forward items)
+based on the WebPageProxy's reported RTLness.
+
+(WebKit::ViewGestureController::isPhysicallySwipingLeft):
+"Back" means "swiping left" in LTR and "swiping right" in RTL.
+
+(WebKit::ViewGestureController::trackSwipeGesture):
+(WebKit::ViewGestureController::determineLayerAdjacentToSnapshotForParent):
+(WebKit::ViewGestureController::beginSwipeGesture):
+(WebKit::ViewGestureController::handleSwipeGesture):
+Make things that were equating "back" with "left" instead check isPhysicallySwipingLeft.
+
 2016-04-18  Anders Carlsson  
 
 Fix build with newer versions of clang.


Modified: trunk/Source/WebKit2/UIProcess/API/gtk/PageClientImpl.h (199694 => 199695)

--- trunk/Source/WebKit2/UIProcess/API/gtk/PageClientImpl.h	2016-04-18 22:59:31 UTC (rev 199694)
+++ trunk/Source/WebKit2/UIProcess/API/gtk/PageClientImpl.h	2016-04-18 23:00:29 UTC (rev 199695)
@@ -142,6 +142,8 @@
 bool decidePolicyForInstallMissingMediaPluginsPermissionRequest(InstallMissingMediaPluginsPermissionRequest&) override;
 #endif
 
+UserInterfaceLayoutDirection

[webkit-changes] [199693] trunk

2016-04-18 Thread cdumez

Title: [199693] trunk








Revision 199693
Author cdu...@apple.com
Date 2016-04-18 15:36:18 -0700 (Mon, 18 Apr 2016)


Log Message
Crash in ElementDescendantIterator::operator--() when calling m_ancestorSiblingStack.last()
https://bugs.webkit.org/show_bug.cgi?id=156715


Reviewed by Antti Koivisto.

Source/WebCore:

Fix correctness of ElementDescendantIterator::operator--(). The last element
in the m_ancestorSiblingStack stack is nullptr. However, if our parent does
not have a sibling, m_current->nextSibling() == m_ancestorSiblingStack.last()
would be true and we would end up removing the nullptr element from
m_ancestorSiblingStack. We would crash on a follow-up call to operator--()
because m_ancestorSiblingStack.last() would do an out-of-bound access, given
that m_ancestorSiblingStack is empty.

Test: fast/dom/collection-backward-traversal-crash.html

* dom/ElementDescendantIterator.h:
(WebCore::ElementDescendantIterator::operator--):

LayoutTests:

Add regression test that reproduced the crash.

* fast/dom/collection-backward-traversal-crash-expected.txt: Added.
* fast/dom/collection-backward-traversal-crash.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/ElementDescendantIterator.h


Added Paths

trunk/LayoutTests/fast/dom/collection-backward-traversal-crash-expected.txt
trunk/LayoutTests/fast/dom/collection-backward-traversal-crash.html




Diff

Modified: trunk/LayoutTests/ChangeLog (199692 => 199693)

--- trunk/LayoutTests/ChangeLog	2016-04-18 22:29:48 UTC (rev 199692)
+++ trunk/LayoutTests/ChangeLog	2016-04-18 22:36:18 UTC (rev 199693)
@@ -1,3 +1,16 @@
+2016-04-18  Chris Dumez  
+
+Crash in ElementDescendantIterator::operator--() when calling m_ancestorSiblingStack.last()
+https://bugs.webkit.org/show_bug.cgi?id=156715
+
+
+Reviewed by Antti Koivisto.
+
+Add regression test that reproduced the crash.
+
+* fast/dom/collection-backward-traversal-crash-expected.txt: Added.
+* fast/dom/collection-backward-traversal-crash.html: Added.
+
 2016-04-18  Brent Fulgham  
 
 CSP: Remove stubs for dynamically-added favicons (via link rel="icon")


Added: trunk/LayoutTests/fast/dom/collection-backward-traversal-crash-expected.txt (0 => 199693)

--- trunk/LayoutTests/fast/dom/collection-backward-traversal-crash-expected.txt	(rev 0)
+++ trunk/LayoutTests/fast/dom/collection-backward-traversal-crash-expected.txt	2016-04-18 22:36:18 UTC (rev 199693)
@@ -0,0 +1,13 @@
+Tests that backward traversal of an HTMLCollection works as expected and does not crash.
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+PASS divs.item(3).id is "D"
+PASS divs.item(2).id is "C"
+PASS divs.item(1).id is "B"
+PASS divs.item(0).id is "A"
+PASS successfullyParsed is true
+
+TEST COMPLETE
+


Added: trunk/LayoutTests/fast/dom/collection-backward-traversal-crash.html (0 => 199693)

--- trunk/LayoutTests/fast/dom/collection-backward-traversal-crash.html	(rev 0)
+++ trunk/LayoutTests/fast/dom/collection-backward-traversal-crash.html	2016-04-18 22:36:18 UTC (rev 199693)
@@ -0,0 +1,18 @@
+
+
+
+