[webkit-changes] [201694] trunk/Source/WebKit2
Title: [201694] trunk/Source/WebKit2
Revision 201694
Author beid...@apple.com
Date 2016-06-05 07:45:52 -0700 (Sun, 05 Jun 2016)
Log Message
Fix the build after r201693.
https://bugs.webkit.org/show_bug.cgi?id=158394
Reviewed by NOBODY (Build fix).
r201693 landed without the Source/WebKit2 changes, and I didn't have EWS/CQ available to check myself. *sigh*
* NetworkProcess/FileAPI/NetworkBlobRegistry.cpp:
(WebKit::NetworkBlobRegistry::writeBlobsToTemporaryFiles):
* NetworkProcess/FileAPI/NetworkBlobRegistry.h:
* WebProcess/FileAPI/BlobRegistryProxy.cpp:
(WebKit::BlobRegistryProxy::writeBlobsToTemporaryFiles):
* WebProcess/FileAPI/BlobRegistryProxy.h:
* WebProcess/Network/NetworkProcessConnection.cpp:
(WebKit::NetworkProcessConnection::didClose):
(WebKit::NetworkProcessConnection::writeBlobsToTemporaryFiles):
* WebProcess/Network/NetworkProcessConnection.h:
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/NetworkProcess/FileAPI/NetworkBlobRegistry.cpp
trunk/Source/WebKit2/NetworkProcess/FileAPI/NetworkBlobRegistry.h
trunk/Source/WebKit2/WebProcess/FileAPI/BlobRegistryProxy.cpp
trunk/Source/WebKit2/WebProcess/FileAPI/BlobRegistryProxy.h
trunk/Source/WebKit2/WebProcess/Network/NetworkProcessConnection.cpp
trunk/Source/WebKit2/WebProcess/Network/NetworkProcessConnection.h
Diff
Modified: trunk/Source/WebKit2/ChangeLog (201693 => 201694)
--- trunk/Source/WebKit2/ChangeLog 2016-06-05 03:46:42 UTC (rev 201693)
+++ trunk/Source/WebKit2/ChangeLog 2016-06-05 14:45:52 UTC (rev 201694)
@@ -1,3 +1,25 @@
+2016-06-05 Brady Eidson
+
+Fix the build after r201693.
+https://bugs.webkit.org/show_bug.cgi?id=158394
+
+Reviewed by NOBODY (Build fix).
+
+r201693 landed without the Source/WebKit2 changes, and I didn't have EWS/CQ available to check myself. *sigh*
+
+* NetworkProcess/FileAPI/NetworkBlobRegistry.cpp:
+(WebKit::NetworkBlobRegistry::writeBlobsToTemporaryFiles):
+* NetworkProcess/FileAPI/NetworkBlobRegistry.h:
+
+* WebProcess/FileAPI/BlobRegistryProxy.cpp:
+(WebKit::BlobRegistryProxy::writeBlobsToTemporaryFiles):
+* WebProcess/FileAPI/BlobRegistryProxy.h:
+
+* WebProcess/Network/NetworkProcessConnection.cpp:
+(WebKit::NetworkProcessConnection::didClose):
+(WebKit::NetworkProcessConnection::writeBlobsToTemporaryFiles):
+* WebProcess/Network/NetworkProcessConnection.h:
+
2016-06-03 Commit Queue
Unreviewed, rolling out r201663.
Modified: trunk/Source/WebKit2/NetworkProcess/FileAPI/NetworkBlobRegistry.cpp (201693 => 201694)
--- trunk/Source/WebKit2/NetworkProcess/FileAPI/NetworkBlobRegistry.cpp 2016-06-05 03:46:42 UTC (rev 201693)
+++ trunk/Source/WebKit2/NetworkProcess/FileAPI/NetworkBlobRegistry.cpp 2016-06-05 14:45:52 UTC (rev 201694)
@@ -132,9 +132,9 @@
return blobRegistry().blobSize(url);
}
-void NetworkBlobRegistry::writeBlobsToTemporaryFiles(const Vector& blobURLs, std::function&)> completionHandler)
+void NetworkBlobRegistry::writeBlobsToTemporaryFiles(const Vector& blobURLs, NoncopyableFunction&)>&& completionHandler)
{
-blobRegistry().writeBlobsToTemporaryFiles(blobURLs, completionHandler);
+blobRegistry().writeBlobsToTemporaryFiles(blobURLs, WTFMove(completionHandler));
}
void NetworkBlobRegistry::connectionToWebProcessDidClose(NetworkConnectionToWebProcess* connection)
Modified: trunk/Source/WebKit2/NetworkProcess/FileAPI/NetworkBlobRegistry.h (201693 => 201694)
--- trunk/Source/WebKit2/NetworkProcess/FileAPI/NetworkBlobRegistry.h 2016-06-05 03:46:42 UTC (rev 201693)
+++ trunk/Source/WebKit2/NetworkProcess/FileAPI/NetworkBlobRegistry.h 2016-06-05 14:45:52 UTC (rev 201694)
@@ -30,6 +30,7 @@
#include
#include
#include
+#include
namespace WebCore {
class BlobDataFileReference;
@@ -54,7 +55,7 @@
void registerBlobURLForSlice(NetworkConnectionToWebProcess*, const WebCore::URL&, const WebCore::URL& srcURL, int64_t start, int64_t end);
void unregisterBlobURL(NetworkConnectionToWebProcess*, const WebCore::URL&);
uint64_t blobSize(NetworkConnectionToWebProcess*, const WebCore::URL&);
-void writeBlobsToTemporaryFiles(const Vector& blobURLs, std::function&)> completionHandler);
+void writeBlobsToTemporaryFiles(const Vector& blobURLs, NoncopyableFunction&)>&& completionHandler);
void connectionToWebProcessDidClose(NetworkConnectionToWebProcess*);
Modified: trunk/Source/WebKit2/WebProcess/FileAPI/BlobRegistryProxy.cpp (201693 => 201694)
--- trunk/Source/WebKit2/WebProcess/FileAPI/BlobRegistryProxy.cpp 2016-06-05 03:46:42 UTC (rev 201693)
+++ trunk/Source/WebKit2/WebProcess/FileAPI/BlobRegistryProxy.cpp 2016-06-05 14:45:52 UTC (rev 201694)
@@ -81,9 +81,9 @@
return resultSize;
}
-void BlobRegistryProxy::writeBlobsToTemporaryFiles(const Vector& blobURLs, std::function& filePaths)> completionHandler)
+void BlobRegistryProxy::writeBlobsToTemporaryFiles(const Ve
[webkit-changes] [201695] trunk/Source/WebKit2
Title: [201695] trunk/Source/WebKit2
Revision 201695
Author beid...@apple.com
Date 2016-06-05 07:53:28 -0700 (Sun, 05 Jun 2016)
Log Message
Unreviewed, rolling out r201694.
201693
Reverted changeset:
"Fix the build after r201693."
https://bugs.webkit.org/show_bug.cgi?id=158394
http://trac.webkit.org/changeset/201694
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/NetworkProcess/FileAPI/NetworkBlobRegistry.cpp
trunk/Source/WebKit2/NetworkProcess/FileAPI/NetworkBlobRegistry.h
trunk/Source/WebKit2/WebProcess/FileAPI/BlobRegistryProxy.cpp
trunk/Source/WebKit2/WebProcess/FileAPI/BlobRegistryProxy.h
trunk/Source/WebKit2/WebProcess/Network/NetworkProcessConnection.cpp
trunk/Source/WebKit2/WebProcess/Network/NetworkProcessConnection.h
Diff
Modified: trunk/Source/WebKit2/ChangeLog (201694 => 201695)
--- trunk/Source/WebKit2/ChangeLog 2016-06-05 14:45:52 UTC (rev 201694)
+++ trunk/Source/WebKit2/ChangeLog 2016-06-05 14:53:28 UTC (rev 201695)
@@ -1,5 +1,17 @@
2016-06-05 Brady Eidson
+Unreviewed, rolling out r201694.
+
+201693
+
+Reverted changeset:
+
+"Fix the build after r201693."
+https://bugs.webkit.org/show_bug.cgi?id=158394
+http://trac.webkit.org/changeset/201694
+
+2016-06-05 Brady Eidson
+
Fix the build after r201693.
https://bugs.webkit.org/show_bug.cgi?id=158394
Modified: trunk/Source/WebKit2/NetworkProcess/FileAPI/NetworkBlobRegistry.cpp (201694 => 201695)
--- trunk/Source/WebKit2/NetworkProcess/FileAPI/NetworkBlobRegistry.cpp 2016-06-05 14:45:52 UTC (rev 201694)
+++ trunk/Source/WebKit2/NetworkProcess/FileAPI/NetworkBlobRegistry.cpp 2016-06-05 14:53:28 UTC (rev 201695)
@@ -132,9 +132,9 @@
return blobRegistry().blobSize(url);
}
-void NetworkBlobRegistry::writeBlobsToTemporaryFiles(const Vector& blobURLs, NoncopyableFunction&)>&& completionHandler)
+void NetworkBlobRegistry::writeBlobsToTemporaryFiles(const Vector& blobURLs, std::function&)> completionHandler)
{
-blobRegistry().writeBlobsToTemporaryFiles(blobURLs, WTFMove(completionHandler));
+blobRegistry().writeBlobsToTemporaryFiles(blobURLs, completionHandler);
}
void NetworkBlobRegistry::connectionToWebProcessDidClose(NetworkConnectionToWebProcess* connection)
Modified: trunk/Source/WebKit2/NetworkProcess/FileAPI/NetworkBlobRegistry.h (201694 => 201695)
--- trunk/Source/WebKit2/NetworkProcess/FileAPI/NetworkBlobRegistry.h 2016-06-05 14:45:52 UTC (rev 201694)
+++ trunk/Source/WebKit2/NetworkProcess/FileAPI/NetworkBlobRegistry.h 2016-06-05 14:53:28 UTC (rev 201695)
@@ -30,7 +30,6 @@
#include
#include
#include
-#include
namespace WebCore {
class BlobDataFileReference;
@@ -55,7 +54,7 @@
void registerBlobURLForSlice(NetworkConnectionToWebProcess*, const WebCore::URL&, const WebCore::URL& srcURL, int64_t start, int64_t end);
void unregisterBlobURL(NetworkConnectionToWebProcess*, const WebCore::URL&);
uint64_t blobSize(NetworkConnectionToWebProcess*, const WebCore::URL&);
-void writeBlobsToTemporaryFiles(const Vector& blobURLs, NoncopyableFunction&)>&& completionHandler);
+void writeBlobsToTemporaryFiles(const Vector& blobURLs, std::function&)> completionHandler);
void connectionToWebProcessDidClose(NetworkConnectionToWebProcess*);
Modified: trunk/Source/WebKit2/WebProcess/FileAPI/BlobRegistryProxy.cpp (201694 => 201695)
--- trunk/Source/WebKit2/WebProcess/FileAPI/BlobRegistryProxy.cpp 2016-06-05 14:45:52 UTC (rev 201694)
+++ trunk/Source/WebKit2/WebProcess/FileAPI/BlobRegistryProxy.cpp 2016-06-05 14:53:28 UTC (rev 201695)
@@ -81,9 +81,9 @@
return resultSize;
}
-void BlobRegistryProxy::writeBlobsToTemporaryFiles(const Vector& blobURLs, NoncopyableFunction& filePaths)>&& completionHandler)
+void BlobRegistryProxy::writeBlobsToTemporaryFiles(const Vector& blobURLs, std::function& filePaths)> completionHandler)
{
-WebProcess::singleton().networkConnection()->writeBlobsToTemporaryFiles(blobURLs, WTFMove(completionHandler));
+WebProcess::singleton().networkConnection()->writeBlobsToTemporaryFiles(blobURLs, completionHandler);
}
}
Modified: trunk/Source/WebKit2/WebProcess/FileAPI/BlobRegistryProxy.h (201694 => 201695)
--- trunk/Source/WebKit2/WebProcess/FileAPI/BlobRegistryProxy.h 2016-06-05 14:45:52 UTC (rev 201694)
+++ trunk/Source/WebKit2/WebProcess/FileAPI/BlobRegistryProxy.h 2016-06-05 14:53:28 UTC (rev 201695)
@@ -39,7 +39,7 @@
void unregisterBlobURL(const WebCore::URL&) override;
void registerBlobURLForSlice(const WebCore::URL&, const WebCore::URL& srcURL, long long start, long long end) override;
unsigned long long blobSize(const WebCore::URL&) override;
-void writeBlobsToTemporaryFiles(const Vector& blobURLs, NoncopyableFunction& filePaths)>&& completionHandler) override;
+void writeBlobsToTemporaryFiles(const Vector& blobURLs, std::function& filePaths)> completionHandler) override;
};
}
Modified: trunk/Source/WebKit2/
[webkit-changes] [201696] trunk/Source/WebCore
Title: [201696] trunk/Source/WebCore
Revision 201696
Author beid...@apple.com
Date 2016-06-05 07:54:36 -0700 (Sun, 05 Jun 2016)
Log Message
Unreviewed, rolling out r201693.
Can't fix right now
Reverted changeset:
"Modern IDB: Crash seen in IDBConnectionProxy::putOrAdd on
GuardMalloc bot"
https://bugs.webkit.org/show_bug.cgi?id=158124
http://trac.webkit.org/changeset/201693
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/indexeddb/IDBTransaction.cpp
trunk/Source/WebCore/Modules/indexeddb/client/IDBConnectionProxy.cpp
trunk/Source/WebCore/Modules/indexeddb/client/IDBConnectionProxy.h
trunk/Source/WebCore/bindings/js/SerializedScriptValue.cpp
trunk/Source/WebCore/bindings/js/SerializedScriptValue.h
trunk/Source/WebCore/platform/network/BlobRegistry.h
trunk/Source/WebCore/platform/network/BlobRegistryImpl.cpp
trunk/Source/WebCore/platform/network/BlobRegistryImpl.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (201695 => 201696)
--- trunk/Source/WebCore/ChangeLog 2016-06-05 14:53:28 UTC (rev 201695)
+++ trunk/Source/WebCore/ChangeLog 2016-06-05 14:54:36 UTC (rev 201696)
@@ -1,3 +1,16 @@
+2016-06-05 Brady Eidson
+
+Unreviewed, rolling out r201693.
+
+Can't fix right now
+
+Reverted changeset:
+
+"Modern IDB: Crash seen in IDBConnectionProxy::putOrAdd on
+GuardMalloc bot"
+https://bugs.webkit.org/show_bug.cgi?id=158124
+http://trac.webkit.org/changeset/201693
+
2016-06-04 Brady Eidson
Modern IDB: Crash seen in IDBConnectionProxy::putOrAdd on GuardMalloc bot
Modified: trunk/Source/WebCore/Modules/indexeddb/IDBTransaction.cpp (201695 => 201696)
--- trunk/Source/WebCore/Modules/indexeddb/IDBTransaction.cpp 2016-06-05 14:53:28 UTC (rev 201695)
+++ trunk/Source/WebCore/Modules/indexeddb/IDBTransaction.cpp 2016-06-05 14:54:36 UTC (rev 201696)
@@ -966,18 +966,20 @@
return;
}
-value->writeBlobsToDiskForIndexedDB([protectedThis = Ref(*this), this, protectedOperation = Ref(operation), keyData = IDBKeyData(key.get()).isolatedCopy(), overwriteMode](const IDBValue& idbValue) mutable {
+RefPtr protectedThis(this);
+RefPtr protectedOperation(&operation);
+value->writeBlobsToDiskForIndexedDB([protectedThis = WTFMove(protectedThis), this, protectedOperation = WTFMove(protectedOperation), key = WTFMove(key), overwriteMode](const IDBValue& idbValue) mutable {
ASSERT(currentThread() == originThreadID());
ASSERT(isMainThread());
if (idbValue.data().data()) {
-m_database->connectionProxy().putOrAdd(protectedOperation.get(), WTFMove(keyData), idbValue, overwriteMode);
+m_database->connectionProxy().putOrAdd(*protectedOperation, key.get(), idbValue, overwriteMode);
return;
}
// If the IDBValue doesn't have any data, then something went wrong writing the blobs to disk.
// In that case, we cannot successfully store this record, so we callback with an error.
auto result = IDBResultData::error(protectedOperation->identifier(), { IDBDatabaseException::UnknownError, ASCIILiteral("Error preparing Blob/File data to be stored in object store") });
-callOnMainThread([protectedThis = WTFMove(protectedThis), protectedOperation = WTFMove(protectedOperation), result = WTFMove(result)]() mutable {
+callOnMainThread([protectedThis = WTFMove(protectedThis), protectedOperation = WTFMove(protectedOperation), result = WTFMove(result)]() {
protectedOperation->completed(result);
});
});
Modified: trunk/Source/WebCore/Modules/indexeddb/client/IDBConnectionProxy.cpp (201695 => 201696)
--- trunk/Source/WebCore/Modules/indexeddb/client/IDBConnectionProxy.cpp 2016-06-05 14:53:28 UTC (rev 201695)
+++ trunk/Source/WebCore/Modules/indexeddb/client/IDBConnectionProxy.cpp 2016-06-05 14:54:36 UTC (rev 201696)
@@ -156,12 +156,12 @@
callConnectionOnMainThread(&IDBConnectionToServer::deleteIndex, requestData, WTFMove(objectStoreIdentifier), indexName);
}
-void IDBConnectionProxy::putOrAdd(TransactionOperation& operation, IDBKeyData&& keyData, const IDBValue& value, const IndexedDB::ObjectStoreOverwriteMode mode)
+void IDBConnectionProxy::putOrAdd(TransactionOperation& operation, IDBKey* key, const IDBValue& value, const IndexedDB::ObjectStoreOverwriteMode mode)
{
const IDBRequestData requestData(operation);
saveOperation(operation);
-callConnectionOnMainThread(&IDBConnectionToServer::putOrAdd, requestData, keyData, value, mode);
+callConnectionOnMainThread(&IDBConnectionToServer::putOrAdd, requestData, IDBKeyData(key), value, mode);
}
void IDBConnectionProxy::getRecord(TransactionOperation& operation, const IDBKeyRangeData& keyRange)
Modified: trunk/Source/WebCore/Modules/indexeddb/client/IDBConnectionProxy.h (201695 => 201696)
--- trunk/Source/WebCore/Modules/indexeddb/client/IDBConnectionProxy.h 2016-06-05 14:53:28 UTC (rev 201695)
++
[webkit-changes] [201697] trunk/Source/WebCore
Title: [201697] trunk/Source/WebCore
Revision 201697
Author akl...@apple.com
Date 2016-06-05 08:20:06 -0700 (Sun, 05 Jun 2016)
Log Message
Give RuleFeatures::classesMatchingAncestors some inline capacity.
Reviewed by Darin Adler.
Avoid 362'000 heap allocations on PLUM (1.3% of all transient fastMallocs) by giving
RuleFeatures::classesMatchingAncestors some inline capacity (32).
This class is only ever allocated on the stack anyway.
* css/RuleFeature.h:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/RuleFeature.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (201696 => 201697)
--- trunk/Source/WebCore/ChangeLog 2016-06-05 14:54:36 UTC (rev 201696)
+++ trunk/Source/WebCore/ChangeLog 2016-06-05 15:20:06 UTC (rev 201697)
@@ -1,3 +1,16 @@
+2016-06-05 Andreas Kling
+
+Give RuleFeatures::classesMatchingAncestors some inline capacity.
+
+
+Reviewed by Darin Adler.
+
+Avoid 362'000 heap allocations on PLUM (1.3% of all transient fastMallocs) by giving
+RuleFeatures::classesMatchingAncestors some inline capacity (32).
+This class is only ever allocated on the stack anyway.
+
+* css/RuleFeature.h:
+
2016-06-05 Brady Eidson
Unreviewed, rolling out r201693.
Modified: trunk/Source/WebCore/css/RuleFeature.h (201696 => 201697)
--- trunk/Source/WebCore/css/RuleFeature.h 2016-06-05 14:54:36 UTC (rev 201696)
+++ trunk/Source/WebCore/css/RuleFeature.h 2016-06-05 15:20:06 UTC (rev 201697)
@@ -74,7 +74,7 @@
private:
struct SelectorFeatures {
bool hasSiblingSelector { false };
-Vector classesMatchingAncestors;
+Vector classesMatchingAncestors;
Vector attributeSelectorsMatchingAncestors;
};
void recursivelyCollectFeaturesFromSelector(SelectorFeatures&, const CSSSelector&, bool matchesAncestor = false);
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [201698] trunk/Source/WebInspectorUI
Title: [201698] trunk/Source/WebInspectorUI Revision 201698 Author mattba...@apple.com Date 2016-06-05 08:23:05 -0700 (Sun, 05 Jun 2016) Log Message REGRESSION (r201686): Web Inspector: Fix typo causing an internal error https://bugs.webkit.org/show_bug.cgi?id=158392 Reviewed by Joseph Pecoraro. * UserInterface/Views/HeapAllocationsTimelineOverviewGraph.js: Fixed typo. Modified Paths trunk/Source/WebInspectorUI/ChangeLog trunk/Source/WebInspectorUI/UserInterface/Views/HeapAllocationsTimelineOverviewGraph.js Diff Modified: trunk/Source/WebInspectorUI/ChangeLog (201697 => 201698) --- trunk/Source/WebInspectorUI/ChangeLog 2016-06-05 15:20:06 UTC (rev 201697) +++ trunk/Source/WebInspectorUI/ChangeLog 2016-06-05 15:23:05 UTC (rev 201698) @@ -1,3 +1,14 @@ +2016-06-05 Matt Baker + +REGRESSION (r201686): Web Inspector: Fix typo causing an internal error +https://bugs.webkit.org/show_bug.cgi?id=158392 + + +Reviewed by Joseph Pecoraro. + +* UserInterface/Views/HeapAllocationsTimelineOverviewGraph.js: +Fixed typo. + 2016-06-04 Brian Burg Web Inspector: add a keyboard shortcut to open the new tab tab Modified: trunk/Source/WebInspectorUI/UserInterface/Views/HeapAllocationsTimelineOverviewGraph.js (201697 => 201698) --- trunk/Source/WebInspectorUI/UserInterface/Views/HeapAllocationsTimelineOverviewGraph.js 2016-06-05 15:20:06 UTC (rev 201697) +++ trunk/Source/WebInspectorUI/UserInterface/Views/HeapAllocationsTimelineOverviewGraph.js 2016-06-05 15:23:05 UTC (rev 201698) @@ -57,7 +57,7 @@ this._selectedImageElement = null; // This may display records past the current time marker. -let visibleRecords = this._heapAllocations.recordsInTimeRange(this.startTime, this.endTime); +let visibleRecords = this._heapAllocationsTimeline.recordsInTimeRange(this.startTime, this.endTime); if (!visibleRecords.length) return; ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [201699] trunk/Source/WebKit/mac
Title: [201699] trunk/Source/WebKit/mac Revision 201699 Author ander...@apple.com Date 2016-06-05 09:35:43 -0700 (Sun, 05 Jun 2016) Log Message Attempt to fix plug-in hangs by adding back empty slots for the removed messages. * Plugins/Hosted/WebKitPluginClient.defs: * Plugins/Hosted/WebKitPluginHost.defs: Modified Paths trunk/Source/WebKit/mac/ChangeLog trunk/Source/WebKit/mac/Plugins/Hosted/WebKitPluginClient.defs trunk/Source/WebKit/mac/Plugins/Hosted/WebKitPluginHost.defs Diff Modified: trunk/Source/WebKit/mac/ChangeLog (201698 => 201699) --- trunk/Source/WebKit/mac/ChangeLog 2016-06-05 15:23:05 UTC (rev 201698) +++ trunk/Source/WebKit/mac/ChangeLog 2016-06-05 16:35:43 UTC (rev 201699) @@ -1,3 +1,10 @@ +2016-06-05 Anders Carlsson + +Attempt to fix plug-in hangs by adding back empty slots for the removed messages. + +* Plugins/Hosted/WebKitPluginClient.defs: +* Plugins/Hosted/WebKitPluginHost.defs: + 2016-06-04 Anders Carlsson Remove NPSPI that is no longer used Modified: trunk/Source/WebKit/mac/Plugins/Hosted/WebKitPluginClient.defs (201698 => 201699) --- trunk/Source/WebKit/mac/Plugins/Hosted/WebKitPluginClient.defs 2016-06-05 15:23:05 UTC (rev 201698) +++ trunk/Source/WebKit/mac/Plugins/Hosted/WebKitPluginClient.defs 2016-06-05 16:35:43 UTC (rev 201699) @@ -191,6 +191,15 @@ simpleroutine PCSetModal(clientPort :mach_port_t; modal :boolean_t); +// Was PCCheckIfAllowedToLoadURL. +skip; + +// Was PCCancelCheckIfAllowedToLoadURL. +skip; + +// Was PCResolveURL. +skip; + // Replies simpleroutine PCInstantiatePluginReply(clientPort :mach_port_t; pluginID :uint32_t; Modified: trunk/Source/WebKit/mac/Plugins/Hosted/WebKitPluginHost.defs (201698 => 201699) --- trunk/Source/WebKit/mac/Plugins/Hosted/WebKitPluginHost.defs 2016-06-05 15:23:05 UTC (rev 201698) +++ trunk/Source/WebKit/mac/Plugins/Hosted/WebKitPluginHost.defs 2016-06-05 16:35:43 UTC (rev 201699) @@ -130,6 +130,9 @@ pluginID :uint32_t; requestID :uint32_t); +// Was PHCheckIfAllowedToLoadURLResult. +skip; + // Streams simpleroutine PHStartStream(pluginHostPort :mach_port_t; pluginID :uint32_t; ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [201701] trunk
Title: [201701] trunk Revision 201701 Author an...@apple.com Date 2016-06-05 12:48:26 -0700 (Sun, 05 Jun 2016) Log Message Source/WebCore: Find on page finds too many matches https://bugs.webkit.org/show_bug.cgi?id=158395 rdar://problem/7440637 Reviewed by Dan Bernstein and Darin Adler. There is a long standing bug where in some cases WebKit may find non-visible text matches when doing find on page. For example searching patch review view in bugs.webkit.org returns twice as many matches as there actually are on the page. This happens because the text content is replicated in an invisible subframe. Fix by making TextIterator ignore content in non-visible subframes in findPlainText. Test: editing/text-iterator/count-matches-in-frames.html * editing/TextIterator.cpp: (WebCore::nextInPreOrderCrossingShadowBoundaries): Remove support for an uninteresting assertion. (WebCore::fullyClipsContents): Elements without renderer clip their content (except for display:contents). Test the content rect instead of the size rect for emptiness. (WebCore::ignoresContainerClip): (WebCore::pushFullyClippedState): (WebCore::setUpFullyClippedStack): (WebCore::isClippedByFrameAncestor): Test if the frame owner element is clipped in any of the parent frames. (WebCore::TextIterator::TextIterator): If the frame is clipped by its ancestors the iterator is initialized to end state. Clipped frame never renders anything so there is no need to maintain clip stack and traverse. (WebCore::findPlainText): Use TextIteratorClipsToFrameAncestors behavior. There might be other places where this behavior should be used (or perhaps it should be used always?) but limit this to text search for now. (WebCore::depthCrossingShadowBoundaries): Deleted. * editing/TextIterator.h: * editing/TextIteratorBehavior.h: Add TextIteratorClipsToFrameAncestors behavior. * testing/Internals.cpp: (WebCore::Internals::countMatchesForText): (WebCore::Internals::countFindMatches): (WebCore::Internals::numberOfLiveNodes): * testing/Internals.h: * testing/Internals.idl: Testing support LayoutTests: TextIterator should ignore non-visible frames in findPlainText https://bugs.webkit.org/show_bug.cgi?id=158395 Reviewed by Dan Bernstein and Darin Adler. * editing/text-iterator/count-matches-in-frames-expected.txt: Added. * editing/text-iterator/count-matches-in-frames.html: Added. * imported/blink/fast/shapes/shape-outside-floats/shape-outside-negative-height-crash-width.html: Non-rendered whitespace change. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/imported/blink/fast/shapes/shape-outside-floats/shape-outside-negative-height-crash-width-expected.txt trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/editing/TextIterator.cpp trunk/Source/WebCore/editing/TextIteratorBehavior.h trunk/Source/WebCore/rendering/RenderBox.h trunk/Source/WebCore/testing/Internals.cpp trunk/Source/WebCore/testing/Internals.h trunk/Source/WebCore/testing/Internals.idl Added Paths trunk/LayoutTests/editing/text-iterator/count-matches-in-frames-expected.txt trunk/LayoutTests/editing/text-iterator/count-matches-in-frames.html Diff Modified: trunk/LayoutTests/ChangeLog (201700 => 201701) --- trunk/LayoutTests/ChangeLog 2016-06-05 19:38:57 UTC (rev 201700) +++ trunk/LayoutTests/ChangeLog 2016-06-05 19:48:26 UTC (rev 201701) @@ -1,3 +1,14 @@ +2016-06-05 Antti Koivisto + +TextIterator should ignore non-visible frames in findPlainText +https://bugs.webkit.org/show_bug.cgi?id=158395 + +Reviewed by Dan Bernstein and Darin Adler. + +* editing/text-iterator/count-matches-in-frames-expected.txt: Added. +* editing/text-iterator/count-matches-in-frames.html: Added. +* imported/blink/fast/shapes/shape-outside-floats/shape-outside-negative-height-crash-width.html: Non-rendered whitespace change. + 2016-06-04 Brady Eidson Modern IDB: Add -private.html variants of crypto/subtle IndexedDB tests. Added: trunk/LayoutTests/editing/text-iterator/count-matches-in-frames-expected.txt (0 => 201701) --- trunk/LayoutTests/editing/text-iterator/count-matches-in-frames-expected.txt (rev 0) +++ trunk/LayoutTests/editing/text-iterator/count-matches-in-frames-expected.txt 2016-06-05 19:48:26 UTC (rev 201701) @@ -0,0 +1,12 @@ +findme0 + +findme1 +findme2 + +findme3 + +PASS Search from frame in normal tree +PASS Search from frame in display:none subtree +PASS Search from frame in zero sized subtree +PASS Search from frame in zero sized subtree with overflow:hidden + Added: trunk/LayoutTests/editing/text-iterator/count-matches-in-frames.html (0 => 201701) --- trunk/LayoutTests/editing/text-iterator/count-matches-in-frames.html (rev 0) +++ trunk/LayoutTests/editing/text-iterator/count-matches-in-frames.html 2016-06-05 19:48:26 UTC (rev 201701) @@ -0,0 +1,48 @@ + + + +Text search from frames + + + + +
[webkit-changes] [201702] trunk
Title: [201702] trunk Revision 201702 Author barraclo...@apple.com Date 2016-06-05 17:59:33 -0700 (Sun, 05 Jun 2016) Log Message Deprecate remaining uses of Lookup getStatic*, use HasStaticPropertyTable instead. https://bugs.webkit.org/show_bug.cgi?id=158178 Reviewed by Darin Adler. As of bug #158059 most JSC static table property access no longer requires getOwnPropertySlot to be overridden. Port remaining calls to the getStatic* functions in Lookup.h over to the new mechanism. Source/_javascript_Core: Part 1: Switch JSGlobalObject & JSDOMWindow to use HasStaticPropertyTable. * runtime/JSGlobalObject.cpp: (JSC::JSGlobalObject::getOwnPropertySlot): - Override is still required for symbol table, but regular property access is now via Base::getOwnPropertySlot. * runtime/JSGlobalObject.h: - add HasStaticPropertyTable to structureFlags. Source/WebCore: Part 1: Switch JSGlobalObject & JSDOMWindow to use HasStaticPropertyTable. * bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::getOwnPropertySlot): - getStaticPropertySlot -> Base::getOwnPropertySlot. * bindings/js/JSPluginElementFunctions.h: (WebCore::pluginElementCustomGetOwnPropertySlot): - Switch call from getStaticValueSlot to Type::getOwnPropertySlot. For any element where Type::hasStaticPropertyTable is true the HasStaticPropertyTable structure flag will also be set, so Type::getOwnPropertySlot will do the same thing. * bindings/scripts/CodeGeneratorJS.pm: (PrototypeHasStaticPropertyTable): - Was PrototypeOverridesGetOwnPropertySlot; prototypes now never need override getOwnPropertySlot so renaming accordingly. (GenerateImplementation): - Removed generation of getOwnPropertySlot body for DOMGlobalObjects. (GeneratePrototypeDeclaration): - For DOMGlobalObjects, set HasStaticPropertyTable instead of OverridesGetOwnPropertySlot & removed getOwnPropertySlot declaration. (PrototypeOverridesGetOwnPropertySlot): Deleted. Renamed to PrototypeHasStaticPropertyTable. * bindings/scripts/test/JS/JSTestGlobalObject.cpp: * bindings/scripts/test/JS/JSTestGlobalObject.h: - Updating bindings test results. LayoutTests: Switch JSGlobalObject & WebCore DOM instance bindings to use HasStaticPropertyTable. * fast/dom/unforgeable-attributes-expected.txt: - Progression, similar to the getOwnPropertyDescriptor test below. Previously we were reporting an error with a message appropriate to a disallowed value->value redefinition. This is actually a disallowed accessor->value reconfiguration, now reporting the correct error message for this. * http/tests/security/cross-origin-window-property-access-expected.txt: - Newly reporting previously missing CORS error. * js/dom/getOwnPropertyDescriptor-expected.txt: * js/resources/getOwnPropertyDescriptor.js: - This test was previously incorrect - was expecting window.window property to reflect as a value decriptor. This now reflect as an accesor descriptor. New behaviour is correct per spec & matches Firefox. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/fast/dom/unforgeable-attributes-expected.txt trunk/LayoutTests/http/tests/security/cross-origin-window-property-access-expected.txt trunk/LayoutTests/js/dom/getOwnPropertyDescriptor-expected.txt trunk/LayoutTests/js/resources/getOwnPropertyDescriptor.js trunk/Source/_javascript_Core/ChangeLog trunk/Source/_javascript_Core/runtime/JSGlobalObject.cpp trunk/Source/_javascript_Core/runtime/JSGlobalObject.h trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/bindings/js/JSDOMWindowCustom.cpp trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm trunk/Source/WebCore/bindings/scripts/test/JS/JSTestGlobalObject.cpp trunk/Source/WebCore/bindings/scripts/test/JS/JSTestGlobalObject.h Diff Modified: trunk/LayoutTests/ChangeLog (201701 => 201702) --- trunk/LayoutTests/ChangeLog 2016-06-05 19:48:26 UTC (rev 201701) +++ trunk/LayoutTests/ChangeLog 2016-06-06 00:59:33 UTC (rev 201702) @@ -1,3 +1,28 @@ +2016-06-05 Gavin & Ellie Barraclough + +Deprecate remaining uses of Lookup getStatic*, use HasStaticPropertyTable instead. +https://bugs.webkit.org/show_bug.cgi?id=158178 + +Reviewed by Darin Adler. + +As of bug #158059 most JSC static table property access no longer requires getOwnPropertySlot to be +overridden. Port remaining calls to the getStatic* functions in Lookup.h over to the new mechanism. + +Switch JSGlobalObject & WebCore DOM instance bindings to use HasStaticPropertyTable. + +* fast/dom/unforgeable-attributes-expected.txt: +- Progression, similar to the getOwnPropertyDescriptor test below. Previously we + were reporting an error with a message appropriate to a disallowed value->value + redefinition. This is actually a disallowed accessor->value reconfiguration, now + reporting the correct error message for this. +* http/tests/secur
[webkit-changes] [201704] trunk/Source/WebCore
Title: [201704] trunk/Source/WebCore
Revision 201704
Author za...@apple.com
Date 2016-06-05 20:19:21 -0700 (Sun, 05 Jun 2016)
Log Message
Addressing post-review comments on r201635.
Reviewed by Chris Dumez.
* rendering/RenderInline.h:
(WebCore::RenderInline::computeRectForRepaint):
* rendering/RenderObject.h:
(WebCore::RenderObject::RepaintContext::RepaintContext):
(WebCore::RenderObject::computeRectForRepaint):
* rendering/RenderTableCell.h:
* rendering/RenderView.h:
* rendering/svg/RenderSVGForeignObject.h:
* rendering/svg/RenderSVGText.h:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderInline.h
trunk/Source/WebCore/rendering/RenderObject.h
trunk/Source/WebCore/rendering/RenderTableCell.h
trunk/Source/WebCore/rendering/RenderView.h
trunk/Source/WebCore/rendering/svg/RenderSVGForeignObject.h
trunk/Source/WebCore/rendering/svg/RenderSVGText.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (201703 => 201704)
--- trunk/Source/WebCore/ChangeLog 2016-06-06 01:56:11 UTC (rev 201703)
+++ trunk/Source/WebCore/ChangeLog 2016-06-06 03:19:21 UTC (rev 201704)
@@ -1,3 +1,19 @@
+2016-06-05 Zalan Bujtas
+
+Addressing post-review comments on r201635.
+
+Reviewed by Chris Dumez.
+
+* rendering/RenderInline.h:
+(WebCore::RenderInline::computeRectForRepaint):
+* rendering/RenderObject.h:
+(WebCore::RenderObject::RepaintContext::RepaintContext):
+(WebCore::RenderObject::computeRectForRepaint):
+* rendering/RenderTableCell.h:
+* rendering/RenderView.h:
+* rendering/svg/RenderSVGForeignObject.h:
+* rendering/svg/RenderSVGText.h:
+
2016-06-05 Yusuke Suzuki
Change ProxyObject.[[Get]] not to use custom accessor
Modified: trunk/Source/WebCore/rendering/RenderInline.h (201703 => 201704)
--- trunk/Source/WebCore/rendering/RenderInline.h 2016-06-06 01:56:11 UTC (rev 201703)
+++ trunk/Source/WebCore/rendering/RenderInline.h 2016-06-06 03:19:21 UTC (rev 201704)
@@ -145,7 +145,7 @@
LayoutRect clippedOverflowRectForRepaint(const RenderLayerModelObject* repaintContainer) const override;
LayoutRect rectWithOutlineForRepaint(const RenderLayerModelObject* repaintContainer, LayoutUnit outlineWidth) const final;
-LayoutRect computeRectForRepaint(const LayoutRect&, const RenderLayerModelObject* repaintContainer, RepaintContext = { false, false }) const final;
+LayoutRect computeRectForRepaint(const LayoutRect&, const RenderLayerModelObject* repaintContainer, RepaintContext = { }) const final;
void mapLocalToContainer(const RenderLayerModelObject* repaintContainer, TransformState&, MapCoordinatesFlags, bool* wasFixed) const override;
const RenderObject* pushMappingToContainer(const RenderLayerModelObject* ancestorToStopAt, RenderGeometryMap&) const override;
Modified: trunk/Source/WebCore/rendering/RenderObject.h (201703 => 201704)
--- trunk/Source/WebCore/rendering/RenderObject.h 2016-06-06 01:56:11 UTC (rev 201703)
+++ trunk/Source/WebCore/rendering/RenderObject.h 2016-06-06 03:19:21 UTC (rev 201704)
@@ -747,15 +747,15 @@
// Given a rect in the object's coordinate space, compute a rect suitable for repainting
// that rect in the coordinate space of repaintContainer.
struct RepaintContext {
-RepaintContext(bool hasPositionFixedDescendant, bool dirtyRectIsFlipped)
+RepaintContext(bool hasPositionFixedDescendant = false, bool dirtyRectIsFlipped = false)
: m_hasPositionFixedDescendant(hasPositionFixedDescendant)
, m_dirtyRectIsFlipped(dirtyRectIsFlipped)
{
}
-bool m_hasPositionFixedDescendant { false };
-bool m_dirtyRectIsFlipped { false };
+bool m_hasPositionFixedDescendant;
+bool m_dirtyRectIsFlipped;
};
-virtual LayoutRect computeRectForRepaint(const LayoutRect&, const RenderLayerModelObject* repaintContainer, RepaintContext = { false, false }) const;
+virtual LayoutRect computeRectForRepaint(const LayoutRect&, const RenderLayerModelObject* repaintContainer, RepaintContext = { }) const;
virtual FloatRect computeFloatRectForRepaint(const FloatRect&, const RenderLayerModelObject* repaintContainer, bool fixed = false) const;
virtual unsigned int length() const { return 1; }
Modified: trunk/Source/WebCore/rendering/RenderTableCell.h (201703 => 201704)
--- trunk/Source/WebCore/rendering/RenderTableCell.h 2016-06-06 01:56:11 UTC (rev 201703)
+++ trunk/Source/WebCore/rendering/RenderTableCell.h 2016-06-06 03:19:21 UTC (rev 201704)
@@ -153,7 +153,7 @@
bool boxShadowShouldBeAppliedToBackground(const LayoutPoint& paintOffset, BackgroundBleedAvoidance, InlineFlowBox*) const override;
LayoutSize offsetFromContainer(RenderElement&, const LayoutPoint&, bool* offsetDependsOnPoint = 0) const override;
-LayoutRect computeRectForRepaint(const LayoutRect&, const RenderLayerModelObject* repaintContainer, RepaintCo
[webkit-changes] [201705] trunk/LayoutTests
Title: [201705] trunk/LayoutTests Revision 201705 Author gyuyoung@webkit.org Date 2016-06-05 20:59:46 -0700 (Sun, 05 Jun 2016) Log Message Unreviewed EFL gardening on June 6. Unskip passing tests and mark failing tests. New bug is filed for new failing tests. * platform/efl/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/efl/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (201704 => 201705) --- trunk/LayoutTests/ChangeLog 2016-06-06 03:19:21 UTC (rev 201704) +++ trunk/LayoutTests/ChangeLog 2016-06-06 03:59:46 UTC (rev 201705) @@ -1,3 +1,10 @@ +2016-06-05 Gyuyoung Kim + +Unreviewed EFL gardening on June 6. Unskip passing tests and mark failing tests. +New bug is filed for new failing tests. + +* platform/efl/TestExpectations: + 2016-06-05 Gavin & Ellie Barraclough Deprecate remaining uses of Lookup getStatic*, use HasStaticPropertyTable instead. Modified: trunk/LayoutTests/platform/efl/TestExpectations (201704 => 201705) --- trunk/LayoutTests/platform/efl/TestExpectations 2016-06-06 03:19:21 UTC (rev 201704) +++ trunk/LayoutTests/platform/efl/TestExpectations 2016-06-06 03:59:46 UTC (rev 201705) @@ -630,18 +630,13 @@ mathml/presentation/fractions-box.html [ Skip ] webkit.org/b/155875 svg/W3C-SVG-1.1/animate-elem-22-b.svg [ Crash ] -webkit.org/b/155875 svg/W3C-SVG-1.1/animate-elem-23-t.svg [ Crash ] webkit.org/b/155875 svg/W3C-SVG-1.1/animate-elem-28-t.svg [ Crash ] webkit.org/b/155875 svg/W3C-SVG-1.1/interact-order-01-b.svg [ Crash ] webkit.org/b/155875 svg/W3C-SVG-1.1/interact-order-02-b.svg [ Crash ] -webkit.org/b/155875 svg/W3C-SVG-1.1/linking-a-01-b.svg [ Crash ] webkit.org/b/155875 svg/W3C-SVG-1.1/paths-data-04-t.svg [ Crash ] -webkit.org/b/155875 svg/W3C-SVG-1.1/paths-data-07-t.svg [ Crash ] webkit.org/b/155875 svg/W3C-SVG-1.1/paths-data-08-t.svg [ Crash ] webkit.org/b/155875 svg/W3C-SVG-1.1/paths-data-13-t.svg [ Crash ] webkit.org/b/155875 svg/W3C-SVG-1.1/pservers-grad-01-b.svg [ Crash ] -webkit.org/b/155875 svg/W3C-SVG-1.1/script-handle-03-b.svg [ Crash ] -webkit.org/b/155875 svg/W3C-SVG-1.1/shapes-ellipse-01-t.svg [ Crash ] Bug(EFL) fast/dom/Window/property-access-on-cached-window-after-frame-removed.html [ Crash ] Bug(EFL) fast/selectors/querySelector-in-range-crash.html [ Crash ] @@ -1072,6 +1067,9 @@ webkit.org/b/148470 css1/box_properties/padding_top.html [ Failure ImageOnlyFailure Pass ] webkit.org/b/148470 css1/box_properties/width.html [ Failure ImageOnlyFailure Pass ] +webkit.org/b/158412 imported/w3c/web-platform-tests/html/dom/reflection-grouping.html [ Timeout Pass ] +webkit.org/b/158412 imported/w3c/web-platform-tests/html/semantics/grouping-content/the-ul-element/grouping-ul.html [ Timeout Pass ] + # # PASSING TESTS WITH INCORRECT EXPECTATIONS # @@ -1847,12 +1845,10 @@ # Missing EFL's accessibility functions webkit.org/b/111984 accessibility/aria-hidden-updates-alldescendants.html [ Failure ] webkit.org/b/111988 accessibility/aria-readonly.html [ Failure ] -webkit.org/b/111991 accessibility/aria-text-role.html [ Failure ] webkit.org/b/111996 accessibility/canvas-fallback-content-2.html [ Failure ] webkit.org/b/111999 accessibility/disabled-controls-not-focusable.html [ Failure ] webkit.org/b/112002 accessibility/inline-continuations.html [ Failure ] webkit.org/b/112005 accessibility/onclick-handlers.html [ Failure ] -webkit.org/b/112008 accessibility/spinbutton-value.html [ Failure ] webkit.org/b/112012 accessibility/svg-bounds.html [ Failure ] webkit.org/b/112014 accessibility/textarea-insertion-point-line-number.html [ Failure ] webkit.org/b/112018 accessibility/th-as-title-ui.html [ Failure ] @@ -1860,9 +1856,6 @@ webkit.org/b/133148 accessibility/set-selected-text-range-contenteditable.html [ Skip ] webkit.org/b/156045 accessibility/attachment-element.html [ Skip ] -# New accessibility test added in r151079 that is failing for EFL. -webkit.org/b/117182 accessibility/text-role-with-aria-hidden-inside.html [ Failure ] - webkit.org/b/141072 accessibility/frame-disconnect-textmarker-cache-crash.html [ Failure ] webkit.org/b/137109 accessibility/legend-children-are-visible.html [ Failure ] webkit.org/b/139352 accessibility/inline-block-assertion.html [ Failure ] @@ -1988,8 +1981,6 @@ webkit.org/b/124890 accessibility/media-emits-object-replacement.html [ Failure ] -webkit.org/b/125506 accessibility/alt-tag-on-image-with-nonimage-role.html [ Failure ] - # QuickTime plug-in not relevant to this port plugins/quicktime-plugin-replacement.html [ Skip ] @@ -2530,9 +2521,6 @@ webkit.org/b/155875 svg/batik/text/textPosition2.svg [ Failure ] webkit.org/b/155875 svg/foreignObject/text-tref-02-b.svg [ Failure ] -webkit.org/b/155934 accessibility/svg-group-
[webkit-changes] [201706] trunk
Title: [201706] trunk Revision 201706 Author commit-qu...@webkit.org Date 2016-06-05 21:56:38 -0700 (Sun, 05 Jun 2016) Log Message Add experimental support for spring based CSS animations https://bugs.webkit.org/show_bug.cgi?id=158403 Patch by Sam Weinig on 2016-06-05 Reviewed by Dean Jackson. Source/WebCore: Adds experimental support for a new CSS animation timing function that uses spring to model the time function. To use it you replace your normal timing function, be it cubic-bezier or steps, with a new function called spring(). For instance, for a transition you would write: transition-timing-function: spring(1 100 10 0); The parameters are, in order: - Mass - Stiffness - Damping - Initial Velocity Tests: animations/spring-computed-style.html animations/spring-function.html animations/spring-parsing.html * WebCore.xcodeproj/project.pbxproj: Add new file. * css/CSSComputedStyleDeclaration.cpp: (WebCore::createTimingFunctionValue): Modernize and add support for the spring function. * css/CSSParser.cpp: (WebCore::CSSParserContext::CSSParserContext): (WebCore::operator==): (WebCore::CSSParser::CSSParser): (WebCore::CSSParser::parseTransformOriginShorthand): (WebCore::CSSParser::isSpringTimingFunctionEnabled): (WebCore::CSSParser::parseCubicBezierTimingFunctionValue): (WebCore::CSSParser::parseSpringTimingFunctionValue): (WebCore::CSSParser::parseAnimationTimingFunction): * css/CSSParser.h: * css/CSSParserMode.h: Add parsing support for the spring() function. * css/CSSTimingFunctionValue.cpp: (WebCore::CSSCubicBezierTimingFunctionValue::customCSSText): (WebCore::CSSCubicBezierTimingFunctionValue::equals): (WebCore::CSSStepsTimingFunctionValue::customCSSText): (WebCore::CSSStepsTimingFunctionValue::equals): (WebCore::CSSSpringTimingFunctionValue::customCSSText): (WebCore::CSSSpringTimingFunctionValue::equals): * css/CSSTimingFunctionValue.h: (WebCore::CSSSpringTimingFunctionValue::create): (WebCore::CSSSpringTimingFunctionValue::mass): (WebCore::CSSSpringTimingFunctionValue::stiffness): (WebCore::CSSSpringTimingFunctionValue::damping): (WebCore::CSSSpringTimingFunctionValue::initialVelocity): (WebCore::CSSSpringTimingFunctionValue::CSSSpringTimingFunctionValue): Modernize and add support for the spring function. * css/CSSToStyleMap.cpp: (WebCore::CSSToStyleMap::mapAnimationTimingFunction): Pipe the spring function into the animation. * css/CSSValue.cpp: (WebCore::CSSValue::equals): (WebCore::CSSValue::cssText): (WebCore::CSSValue::destroy): * css/CSSValue.h: (WebCore::CSSValue::isSpringTimingFunctionValue): Add support for the spring function. * page/Settings.in: Add a setting to control if the spring function is enabled. * page/animation/AnimationBase.cpp: (WebCore::solveSpringFunction): (WebCore::AnimationBase::progress): Add support for solving the spring function. Since the spring requires time to be absolute, get the real time by multiplying the ratio t, to the total duration. * platform/animation/TimingFunction.cpp: (WebCore::operator<<): * platform/animation/TimingFunction.h: (WebCore::TimingFunction::~TimingFunction): (WebCore::TimingFunction::isSpringTimingFunction): Add support for the spring timing function. * platform/graphics/SpringSolver.h: Added. (WebCore::SpringSolver::SpringSolver): (WebCore::SpringSolver::solve): Add a Spring solver that matches the one in CoreAnimation. * platform/graphics/ca/GraphicsLayerCA.cpp: (WebCore::GraphicsLayerCA::createAnimationFromKeyframes): (WebCore::GraphicsLayerCA::appendToUncommittedAnimations): (WebCore::GraphicsLayerCA::createBasicAnimation): (WebCore::GraphicsLayerCA::createSpringAnimation): (WebCore::GraphicsLayerCA::setupAnimation): * platform/graphics/ca/GraphicsLayerCA.h: Map animations with spring timing functions to CASpringAnimations. * platform/graphics/ca/PlatformCAAnimation.cpp: (WebCore::operator<<): (WebCore::PlatformCAAnimation::isBasicAnimation): * platform/graphics/ca/PlatformCAAnimation.h: (WebCore::PlatformCAAnimation::setActualStartTimeIfNeeded): (WebCore::PlatformCAAnimation::PlatformCAAnimation): * platform/graphics/ca/cocoa/PlatformCAAnimationCocoa.mm: (WebCore::toCAMediaTimingFunction): (PlatformCAAnimationCocoa::PlatformCAAnimationCocoa): (PlatformCAAnimationCocoa::setTimingFunction): (PlatformCAAnimationCocoa::copyTimingFunctionFrom): (PlatformCAAnimationCocoa::setFromValue): (PlatformCAAnimationCocoa::copyFromValueFrom): (PlatformCAAnimationCocoa::setToValue): (PlatformCAAnimationCocoa::copyToValueFrom): Add a new type of PlatformCAAnimation, Spring, which is a sub-type of Basic. Source/WebKit2: * Shared/WebCoreArgumentCoders.cpp: (IPC::ArgumentCoder::decode): (IPC::ArgumentCoder::encode): (IPC::ArgumentCoder::decode): (IPC::ArgumentCoder::encode): * Shared/WebCoreArgumentCoders.h: * Shared/WebPreferencesDefinitions.h: * WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::updatePreferences): * WebProcess/WebPage/mac/PlatformCAAnimationRemote.mm: (WebKit::PlatformCAAn
[webkit-changes] [201707] trunk
Title: [201707] trunk Revision 201707 Author gyuyoung@webkit.org Date 2016-06-05 22:09:51 -0700 (Sun, 05 Jun 2016) Log Message [EFL] Sync EFL features with featureList.pm https://bugs.webkit.org/show_bug.cgi?id=158410 Reviewed by Antonio Gomes. In OptionsEfl, some features on/off status are different with featureList.pm definitions. Sync with it. * Source/cmake/OptionsEfl.cmake: Modified Paths trunk/ChangeLog trunk/Source/cmake/OptionsEfl.cmake Diff Modified: trunk/ChangeLog (201706 => 201707) --- trunk/ChangeLog 2016-06-06 04:56:38 UTC (rev 201706) +++ trunk/ChangeLog 2016-06-06 05:09:51 UTC (rev 201707) @@ -1,3 +1,15 @@ +2016-06-05 Gyuyoung Kim + +[EFL] Sync EFL features with featureList.pm +https://bugs.webkit.org/show_bug.cgi?id=158410 + +Reviewed by Antonio Gomes. + +In OptionsEfl, some features on/off status are different with +featureList.pm definitions. Sync with it. + +* Source/cmake/OptionsEfl.cmake: + 2016-06-03 Per Arne Vollan [Win] IndexedDB worker tests are failing. Modified: trunk/Source/cmake/OptionsEfl.cmake (201706 => 201707) --- trunk/Source/cmake/OptionsEfl.cmake 2016-06-06 04:56:38 UTC (rev 201706) +++ trunk/Source/cmake/OptionsEfl.cmake 2016-06-06 05:09:51 UTC (rev 201707) @@ -82,7 +82,7 @@ WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_BATTERY_STATUS PUBLIC ON) WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_CSS3_TEXT PUBLIC ON) WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_CSS_DEVICE_ADAPTATION PUBLIC ON) -WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_CSS_GRID_LAYOUT PUBLIC OFF) +WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_CSS_GRID_LAYOUT PUBLIC ON) WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_CSS_IMAGE_SET PUBLIC ON) WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_CSS_REGIONS PUBLIC ON) WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_CSS_SCROLL_SNAP PUBLIC OFF) @@ -109,7 +109,7 @@ WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_MEDIA_CAPTURE PUBLIC ON) WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_MEDIA_CONTROLS_SCRIPT PUBLIC ON) WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_MEDIA_SOURCE PUBLIC ON) -WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_MEDIA_STREAM PUBLIC ON) +WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_MEDIA_STREAM PUBLIC OFF) WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_MEMORY_SAMPLER PUBLIC ON) WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_MHTML PUBLIC ON) WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_MOUSE_CURSOR_SCALE PUBLIC ON) @@ -134,7 +134,7 @@ WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_VIDEO_TRACK PUBLIC ON) WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_VIEW_MODE_CSS_MEDIA PUBLIC ON) WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_WEB_AUDIO PUBLIC ON) -WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_WEB_RTC PUBLIC ON) +WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_WEB_RTC PUBLIC OFF) WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_WEB_TIMING PUBLIC ON) WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_WEBGL PUBLIC ON) ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
