[webkit-changes] [210849] trunk/Source/JavaScriptCore
Title: [210849] trunk/Source/_javascript_Core Revision 210849 Author o...@webkit.org Date 2017-01-18 02:24:49 -0800 (Wed, 18 Jan 2017) Log Message Fix the JSCOnly build after r210844 https://bugs.webkit.org/show_bug.cgi?id=167155 Unreviewed buildfix. * heap/EdenGCActivityCallback.cpp: Modified Paths trunk/Source/_javascript_Core/ChangeLog trunk/Source/_javascript_Core/heap/EdenGCActivityCallback.cpp Diff Modified: trunk/Source/_javascript_Core/ChangeLog (210848 => 210849) --- trunk/Source/_javascript_Core/ChangeLog 2017-01-18 09:05:37 UTC (rev 210848) +++ trunk/Source/_javascript_Core/ChangeLog 2017-01-18 10:24:49 UTC (rev 210849) @@ -1,3 +1,12 @@ +2017-01-18 Csaba Osztrogonác + +Fix the JSCOnly build after r210844 +https://bugs.webkit.org/show_bug.cgi?id=167155 + +Unreviewed buildfix. + +* heap/EdenGCActivityCallback.cpp: + 2017-01-16 Filip Pizlo Make opaque root scanning truly constraint-based Modified: trunk/Source/_javascript_Core/heap/EdenGCActivityCallback.cpp (210848 => 210849) --- trunk/Source/_javascript_Core/heap/EdenGCActivityCallback.cpp 2017-01-18 09:05:37 UTC (rev 210848) +++ trunk/Source/_javascript_Core/heap/EdenGCActivityCallback.cpp 2017-01-18 10:24:49 UTC (rev 210849) @@ -25,6 +25,7 @@ #include "config.h" #include "EdenGCActivityCallback.h" +#include "HeapInlines.h" #include "VM.h" ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [210850] trunk/Tools
Title: [210850] trunk/Tools Revision 210850 Author pvol...@apple.com Date 2017-01-18 05:00:51 -0800 (Wed, 18 Jan 2017) Log Message [Win] Clipboard tests are flaky. https://bugs.webkit.org/show_bug.cgi?id=167088 Reviewed by Brent Fulgham. Tests involving the clipboard are flaky when running with multiple DRTs, since the clipboard is global. We can fix this by assigning each DRT a separate window station (each window station has its own clipboard). * DumpRenderTree/win/DumpRenderTree.cpp: (main): Modified Paths trunk/Tools/ChangeLog trunk/Tools/DumpRenderTree/win/DumpRenderTree.cpp Diff Modified: trunk/Tools/ChangeLog (210849 => 210850) --- trunk/Tools/ChangeLog 2017-01-18 10:24:49 UTC (rev 210849) +++ trunk/Tools/ChangeLog 2017-01-18 13:00:51 UTC (rev 210850) @@ -1,3 +1,16 @@ +2017-01-18 Per Arne Vollan + +[Win] Clipboard tests are flaky. +https://bugs.webkit.org/show_bug.cgi?id=167088 + +Reviewed by Brent Fulgham. + +Tests involving the clipboard are flaky when running with multiple DRTs, since the clipboard is global. +We can fix this by assigning each DRT a separate window station (each window station has its own clipboard). + +* DumpRenderTree/win/DumpRenderTree.cpp: +(main): + 2017-01-18 Antoine Quint [Modern Media Controls] Turn modern media controls on by default Modified: trunk/Tools/DumpRenderTree/win/DumpRenderTree.cpp (210849 => 210850) --- trunk/Tools/DumpRenderTree/win/DumpRenderTree.cpp 2017-01-18 10:24:49 UTC (rev 210849) +++ trunk/Tools/DumpRenderTree/win/DumpRenderTree.cpp 2017-01-18 13:00:51 UTC (rev 210850) @@ -1471,6 +1471,28 @@ // Redirect stdout to stderr. int result = _dup2(_fileno(stderr), 1); +// Tests involving the clipboard are flaky when running with multiple DRTs, since the clipboard is global. +// We can fix this by assigning each DRT a separate window station (each window station has its own clipboard). +DWORD processId = ::GetCurrentProcessId(); +String windowStationName = String::format("windowStation%d", processId); +String desktopName = String::format("desktop%d", processId); +HDESK desktop = nullptr; + +auto windowsStation = ::CreateWindowStation(windowStationName.charactersWithNullTermination().data(), CWF_CREATE_ONLY, WINSTA_ALL_ACCESS, nullptr); +if (windowsStation) { +if (!::SetProcessWindowStation(windowsStation)) +fprintf(stderr, "SetProcessWindowStation failed with error %d\n", ::GetLastError()); + +desktop = ::CreateDesktop(desktopName.charactersWithNullTermination().data(), nullptr, nullptr, 0, GENERIC_ALL, nullptr); +if (!desktop) +fprintf(stderr, "Failed to create desktop with error %d\n", ::GetLastError()); +} else { +DWORD error = ::GetLastError(); +fprintf(stderr, "Failed to create window station with error %d\n", error); +if (error == ERROR_ACCESS_DENIED) +fprintf(stderr, "DumpRenderTree should be run as Administrator!\n"); +} + initialize(); setDefaultsToConsistentValuesForTesting(); @@ -1573,6 +1595,11 @@ _CrtDumpMemoryLeaks(); #endif +if (desktop) +::CloseDesktop(desktop); +if (windowsStation) +::CloseWindowStation(windowsStation); + ::OleUninitialize(); return 0; ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [210851] trunk/Source/WebCore
Title: [210851] trunk/Source/WebCore Revision 210851 Author g...@gnome.org Date 2017-01-18 08:42:46 -0800 (Wed, 18 Jan 2017) Log Message [GStreamer] media source tests crashing https://bugs.webkit.org/show_bug.cgi?id=167158 Reviewed by Carlos Garcia Campos. This fixes several media source tests which are asserting on debug builds, such as: - fast/history/page-cache-removed-source-buffer.html - imported/w3c/web-platform-tests/media-source/ * platform/graphics/gstreamer/mse/AppendPipeline.cpp: (WebCore::AppendPipeline::AppendPipeline): do not adopt the GStPipeline upon creation. A regular assignment will do the right thing, sinking the floating ref. Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/platform/graphics/gstreamer/mse/AppendPipeline.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (210850 => 210851) --- trunk/Source/WebCore/ChangeLog 2017-01-18 13:00:51 UTC (rev 210850) +++ trunk/Source/WebCore/ChangeLog 2017-01-18 16:42:46 UTC (rev 210851) @@ -1,3 +1,21 @@ +2017-01-18 Gustavo Noronha Silva + +[GStreamer] media source tests crashing +https://bugs.webkit.org/show_bug.cgi?id=167158 + +Reviewed by Carlos Garcia Campos. + +This fixes several media source tests which are asserting on debug builds, +such as: + +- fast/history/page-cache-removed-source-buffer.html +- imported/w3c/web-platform-tests/media-source/ + +* platform/graphics/gstreamer/mse/AppendPipeline.cpp: +(WebCore::AppendPipeline::AppendPipeline): do not adopt the GStPipeline +upon creation. A regular assignment will do the right thing, sinking the +floating ref. + 2017-01-18 Antoine Quint [Modern Media Controls] Turn modern media controls on by default Modified: trunk/Source/WebCore/platform/graphics/gstreamer/mse/AppendPipeline.cpp (210850 => 210851) --- trunk/Source/WebCore/platform/graphics/gstreamer/mse/AppendPipeline.cpp 2017-01-18 13:00:51 UTC (rev 210850) +++ trunk/Source/WebCore/platform/graphics/gstreamer/mse/AppendPipeline.cpp 2017-01-18 16:42:46 UTC (rev 210851) @@ -107,7 +107,7 @@ // FIXME: give a name to the pipeline, maybe related with the track it's managing. // The track name is still unknown at this time, though. -m_pipeline = adoptGRef(gst_pipeline_new(nullptr)); +m_pipeline = gst_pipeline_new(nullptr); m_bus = adoptGRef(gst_pipeline_get_bus(GST_PIPELINE(m_pipeline.get(; gst_bus_add_signal_watch(m_bus.get()); ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [210852] trunk/Source/JavaScriptCore
Title: [210852] trunk/Source/_javascript_Core Revision 210852 Author bb...@apple.com Date 2017-01-18 09:55:06 -0800 (Wed, 18 Jan 2017) Log Message Web Inspector: remove an unnecessary include in generated Objective-C Inspector protocol code https://bugs.webkit.org/show_bug.cgi?id=167156 Rubber-stamped by Geoffrey Garen. * inspector/scripts/codegen/objc_generator_templates.py: This include of config.h doesn't make sense when using the code generator outside of _javascript_Core/WebKit. It is not necessary either, so remove it. * inspector/scripts/tests/all/expected/definitions-with-mac-platform.json-result: * inspector/scripts/tests/generic/expected/commands-with-async-attribute.json-result: * inspector/scripts/tests/generic/expected/commands-with-optional-call-return-parameters.json-result: * inspector/scripts/tests/generic/expected/definitions-with-mac-platform.json-result: * inspector/scripts/tests/generic/expected/domains-with-varying-command-sizes.json-result: * inspector/scripts/tests/generic/expected/enum-values.json-result: * inspector/scripts/tests/generic/expected/events-with-optional-parameters.json-result: * inspector/scripts/tests/generic/expected/generate-domains-with-feature-guards.json-result: * inspector/scripts/tests/generic/expected/same-type-id-different-domain.json-result: * inspector/scripts/tests/generic/expected/shadowed-optional-type-setters.json-result: * inspector/scripts/tests/generic/expected/type-declaration-aliased-primitive-type.json-result: * inspector/scripts/tests/generic/expected/type-declaration-array-type.json-result: * inspector/scripts/tests/generic/expected/type-declaration-enum-type.json-result: * inspector/scripts/tests/generic/expected/type-declaration-object-type.json-result: * inspector/scripts/tests/generic/expected/type-requiring-runtime-casts.json-result: * inspector/scripts/tests/ios/expected/definitions-with-mac-platform.json-result: * inspector/scripts/tests/mac/expected/definitions-with-mac-platform.json-result: Rebaseline test results. Modified Paths trunk/Source/_javascript_Core/ChangeLog trunk/Source/_javascript_Core/inspector/scripts/codegen/objc_generator_templates.py trunk/Source/_javascript_Core/inspector/scripts/tests/all/expected/definitions-with-mac-platform.json-result trunk/Source/_javascript_Core/inspector/scripts/tests/generic/expected/commands-with-async-attribute.json-result trunk/Source/_javascript_Core/inspector/scripts/tests/generic/expected/commands-with-optional-call-return-parameters.json-result trunk/Source/_javascript_Core/inspector/scripts/tests/generic/expected/definitions-with-mac-platform.json-result trunk/Source/_javascript_Core/inspector/scripts/tests/generic/expected/domains-with-varying-command-sizes.json-result trunk/Source/_javascript_Core/inspector/scripts/tests/generic/expected/enum-values.json-result trunk/Source/_javascript_Core/inspector/scripts/tests/generic/expected/events-with-optional-parameters.json-result trunk/Source/_javascript_Core/inspector/scripts/tests/generic/expected/generate-domains-with-feature-guards.json-result trunk/Source/_javascript_Core/inspector/scripts/tests/generic/expected/same-type-id-different-domain.json-result trunk/Source/_javascript_Core/inspector/scripts/tests/generic/expected/shadowed-optional-type-setters.json-result trunk/Source/_javascript_Core/inspector/scripts/tests/generic/expected/type-declaration-aliased-primitive-type.json-result trunk/Source/_javascript_Core/inspector/scripts/tests/generic/expected/type-declaration-array-type.json-result trunk/Source/_javascript_Core/inspector/scripts/tests/generic/expected/type-declaration-enum-type.json-result trunk/Source/_javascript_Core/inspector/scripts/tests/generic/expected/type-declaration-object-type.json-result trunk/Source/_javascript_Core/inspector/scripts/tests/generic/expected/type-requiring-runtime-casts.json-result trunk/Source/_javascript_Core/inspector/scripts/tests/ios/expected/definitions-with-mac-platform.json-result trunk/Source/_javascript_Core/inspector/scripts/tests/mac/expected/definitions-with-mac-platform.json-result Diff Modified: trunk/Source/_javascript_Core/ChangeLog (210851 => 210852) --- trunk/Source/_javascript_Core/ChangeLog 2017-01-18 16:42:46 UTC (rev 210851) +++ trunk/Source/_javascript_Core/ChangeLog 2017-01-18 17:55:06 UTC (rev 210852) @@ -1,3 +1,33 @@ +2017-01-18 Brian Burg + +Web Inspector: remove an unnecessary include in generated Objective-C Inspector protocol code +https://bugs.webkit.org/show_bug.cgi?id=167156 + +Rubber-stamped by Geoffrey Garen. + +* inspector/scripts/codegen/objc_generator_templates.py: +This include of config.h doesn't make sense when using the code generator +outside of _javascript_Core/WebKit. It is not necessary either, so remove it. + +* inspector/scripts/tests/all/expected/definitions-with-mac-platform.json-result: +* inspector/scripts/tests/generic/expected/commands-with-async-attr
[webkit-changes] [210853] trunk
Title: [210853] trunk Revision 210853 Author commit-qu...@webkit.org Date 2017-01-18 10:37:30 -0800 (Wed, 18 Jan 2017) Log Message [Fetch API] Update content-type in case of form data https://bugs.webkit.org/show_bug.cgi?id=167143 Patch by Youenn Fablet on 2017-01-18 Reviewed by Alex Christensen. LayoutTests/imported/w3c: * web-platform-tests/fetch/api/basic/request-headers-expected.txt: Source/WebCore: Covered by rebased test. * Modules/fetch/FetchBody.cpp: (WebCore::FetchBody::extract): Adding a space to the content-type in case of form data. LayoutTests: * TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/TestExpectations trunk/LayoutTests/imported/w3c/ChangeLog trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/basic/request-headers-expected.txt trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/Modules/fetch/FetchBody.cpp Diff Modified: trunk/LayoutTests/ChangeLog (210852 => 210853) --- trunk/LayoutTests/ChangeLog 2017-01-18 17:55:06 UTC (rev 210852) +++ trunk/LayoutTests/ChangeLog 2017-01-18 18:37:30 UTC (rev 210853) @@ -1,3 +1,12 @@ +2017-01-18 Youenn Fablet + +[Fetch API] Update content-type in case of form data +https://bugs.webkit.org/show_bug.cgi?id=167143 + +Reviewed by Alex Christensen. + +* TestExpectations: + 2017-01-18 Antoine Quint [Modern Media Controls] Turn modern media controls on by default Modified: trunk/LayoutTests/TestExpectations (210852 => 210853) --- trunk/LayoutTests/TestExpectations 2017-01-18 17:55:06 UTC (rev 210852) +++ trunk/LayoutTests/TestExpectations 2017-01-18 18:37:30 UTC (rev 210853) @@ -311,10 +311,6 @@ webkit.org/b/157145 imported/w3c/web-platform-tests/fetch/nosniff/stylesheet.html [ Failure Pass ] webkit.org/b/161312 imported/w3c/web-platform-tests/html/semantics/document-metadata/the-link-element/document-without-browsing-context.html [ Failure Pass ] -# Flaky tests due to always changing assertion error message -imported/w3c/web-platform-tests/fetch/api/basic/request-headers.html [ Failure ] -imported/w3c/web-platform-tests/html/semantics/forms/form-submission-0/url-encoded.html [ Failure ] - [ Debug ] imported/w3c/web-platform-tests/fetch/api/basic/request-upload.html [ Skip ] [ Debug ] imported/w3c/web-platform-tests/fetch/api/basic/request-upload-worker.html [ Skip ] @@ -326,6 +322,9 @@ webkit.org/b/159724 imported/w3c/web-platform-tests/XMLHttpRequest/send-redirect-post-upload.htm [ Failure Pass ] +# Flaky tests due to always changing assertion error message +imported/w3c/web-platform-tests/html/semantics/forms/form-submission-0/url-encoded.html [ Failure ] + # New W3C ref tests that are failing. webkit.org/b/148856 imported/w3c/web-platform-tests/html/semantics/embedded-content/the-video-element/video_initially_paused.html [ ImageOnlyFailure ] Modified: trunk/LayoutTests/imported/w3c/ChangeLog (210852 => 210853) --- trunk/LayoutTests/imported/w3c/ChangeLog 2017-01-18 17:55:06 UTC (rev 210852) +++ trunk/LayoutTests/imported/w3c/ChangeLog 2017-01-18 18:37:30 UTC (rev 210853) @@ -1,3 +1,12 @@ +2017-01-18 Youenn Fablet + +[Fetch API] Update content-type in case of form data +https://bugs.webkit.org/show_bug.cgi?id=167143 + +Reviewed by Alex Christensen. + +* web-platform-tests/fetch/api/basic/request-headers-expected.txt: + 2017-01-17 Youenn Fablet Refresh WPT tests up to 73f4ad361ca56d890b5f46d62c3bc84371a77e10 Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/basic/request-headers-expected.txt (210852 => 210853) --- trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/basic/request-headers-expected.txt 2017-01-18 17:55:06 UTC (rev 210852) +++ trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/basic/request-headers-expected.txt 2017-01-18 18:37:30 UTC (rev 210853) @@ -5,7 +5,7 @@ PASS Fetch with PUT with body PASS Fetch with POST without body PASS Fetch with POST with text body -FAIL Fetch with POST with FormData body assert_true: Request should have header content-type starting with multipart/form-data; boundary=, but got multipart/form-data;boundary=WebKitFormBoundary7HBc13pIcNoBV6R5 expected true got false +PASS Fetch with POST with FormData body PASS Fetch with POST with URLSearchParams body FAIL Fetch with POST with Blob body assert_equals: Request should have header content-type: null expected (object) null but got (string) "" FAIL Fetch with POST with ArrayBuffer body assert_equals: Request should have header content-type: null expected (object) null but got (string) "application/x-www-form-urlencoded" Modified: trunk/Source/WebCore/ChangeLog (210852 => 210853) --- trunk/Source/WebCore/ChangeLog 2017-01-18 17:55:06 UTC (rev 210852) +++ trunk/Source/WebCore/ChangeLog 2017-01-18 18:37:30 UTC (rev 210853) @@ -1,3 +1,15 @@ +2017-01-18 Youenn Fablet + +[Fetch API] Update content-type in case of form dat
[webkit-changes] [210854] branches/safari-603-branch
Title: [210854] branches/safari-603-branch Revision 210854 Author matthew_han...@apple.com Date 2017-01-18 10:45:12 -0800 (Wed, 18 Jan 2017) Log Message Merge r210837. rdar://problem/29432371 Modified Paths branches/safari-603-branch/JSTests/ChangeLog branches/safari-603-branch/Source/_javascript_Core/ChangeLog branches/safari-603-branch/Source/_javascript_Core/yarr/YarrInterpreter.cpp branches/safari-603-branch/Source/_javascript_Core/yarr/YarrInterpreter.h branches/safari-603-branch/Source/_javascript_Core/yarr/YarrJIT.cpp branches/safari-603-branch/Source/_javascript_Core/yarr/YarrPattern.cpp branches/safari-603-branch/Source/_javascript_Core/yarr/YarrPattern.h Added Paths branches/safari-603-branch/JSTests/microbenchmarks/regexp-nested-nonzero-min-counted-parens.js Diff Modified: branches/safari-603-branch/JSTests/ChangeLog (210853 => 210854) --- branches/safari-603-branch/JSTests/ChangeLog 2017-01-18 18:37:30 UTC (rev 210853) +++ branches/safari-603-branch/JSTests/ChangeLog 2017-01-18 18:45:12 UTC (rev 210854) @@ -1,3 +1,18 @@ +2017-01-18 Matthew Hanson + +Merge r210837. rdar://problem/29432371 + +2017-01-17 Michael Saboff + +Nested parenthesized regular expressions with non-zero minimum counts appear to hang and use lots of memory +https://bugs.webkit.org/show_bug.cgi?id=167125 + +Reviewed by Filip Pizlo. + +* microbenchmarks/regexp-nested-nonzero-min-counted-parens.js: Added. +New test with limits that run slow and take a reasonable amount of memory +before the change and run fast, using little memory with the change. + 2017-01-12 Matthew Hanson Merge r210563. rdar://problem/29940224 Added: branches/safari-603-branch/JSTests/microbenchmarks/regexp-nested-nonzero-min-counted-parens.js (0 => 210854) --- branches/safari-603-branch/JSTests/microbenchmarks/regexp-nested-nonzero-min-counted-parens.js (rev 0) +++ branches/safari-603-branch/JSTests/microbenchmarks/regexp-nested-nonzero-min-counted-parens.js 2017-01-18 18:45:12 UTC (rev 210854) @@ -0,0 +1,11 @@ +// This checks that we didn't regress the performance of regular expressions with nested, counted parenthesis +// where the minimum count is not 0. + +/$($($($($($($($($($($($($($($($($($($($(${-2,16}+)+)+)+)+)+)+)+)+)+)+)+)+)+)+)+)+)+)+)+)+/.exec("a"); + +/$(?:$(?:$(?:$(?:$(?:$(?:$(?:$(?:$(?:$(?:$(?:$(?:$(?:$(?:$(?:$(?:$(?:$(?:$(?:$(?:${-2,16}+)+)+)+)+)+)+)+)+)+)+)+)+)+)+)+)+)+)+)+)+/.exec("a"); + +/$(?=$(?=$(?=$(?=$(?=$(?=$(?=$(?=$(?=$(?=$(?=$(?=$(?=$(?=$(?=$(?=$(?=$(?=$(?=$(?=${-2,16}+)+)+)+)+)+)+)+)+)+)+)+)+)+)+)+)+)+)+)+)+/.exec("a"); + + + Modified: branches/safari-603-branch/Source/_javascript_Core/ChangeLog (210853 => 210854) --- branches/safari-603-branch/Source/_javascript_Core/ChangeLog 2017-01-18 18:37:30 UTC (rev 210853) +++ branches/safari-603-branch/Source/_javascript_Core/ChangeLog 2017-01-18 18:45:12 UTC (rev 210854) @@ -1,3 +1,83 @@ +2017-01-18 Matthew Hanson + +Merge r210837. rdar://problem/29432371 + +2017-01-17 Michael Saboff + +Nested parenthesized regular expressions with non-zero minimum counts appear to hang and use lots of memory +https://bugs.webkit.org/show_bug.cgi?id=167125 + +Reviewed by Filip Pizlo. + +Changed Yarr to handle nested parenthesized subexpressions where the minimum count is +not 0 directly in the Yarr interpreter. Previously we'd factor an _expression_ like +(a|b)+ into (a|b)(a|b)* with special handling for captures. This factoring was done +using a deep copy that doubled the size of the resulting expresion for each nested +parenthesized subexpression. Now the Yarr interpreter can directly process a regexp +like (a|b){2,42}. + +The parser will allow one level of nested, non-zero minimum, counted parenthesis using +the old copy method. After one level, it will generate parenthesis terms with a non-zero +minimum. Such an _expression_ wasn't handled by the Yarr JIT before the change, so this +change isn't a performance regression. + +Added a minimum count to the YarrPattern and ByteTerm classes, and then factored that +minimum into the interpreter. A non-zero minimum is only handled by the Yarr interpreter. +If the Yarr JIT see such a term, it punts back to the interpreter. + +* yarr/YarrInterpreter.cpp: +(JSC::Yarr::Interpreter::backtrackPatternCharacter): +(JSC::Yarr::Interpreter::backtrackPatternCasedCharacter): +(JSC::Yarr::Interpreter::matchCharacterClass): +(JSC::Yarr::Interpreter::backtrackCharacterClass): +(JSC::Yarr::Interpreter::matchBackReference): +(JSC::Yarr::Interpreter::backtrackBackReference): +(JSC::Yarr::Interpreter::matchParenthese
[webkit-changes] [210855] trunk/Source/WebCore
Title: [210855] trunk/Source/WebCore Revision 210855 Author pvol...@apple.com Date 2017-01-18 10:45:59 -0800 (Wed, 18 Jan 2017) Log Message Crash when changing video subtitles. https://bugs.webkit.org/show_bug.cgi?id=167159 Reviewed by Xabier Rodriguez-Calvar. Add null pointer check. * html/track/VTTCue.cpp: (WebCore::VTTCue::removeDisplayTree): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/html/track/VTTCue.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (210854 => 210855) --- trunk/Source/WebCore/ChangeLog 2017-01-18 18:45:12 UTC (rev 210854) +++ trunk/Source/WebCore/ChangeLog 2017-01-18 18:45:59 UTC (rev 210855) @@ -1,3 +1,15 @@ +2017-01-18 Per Arne Vollan + +Crash when changing video subtitles. +https://bugs.webkit.org/show_bug.cgi?id=167159 + +Reviewed by Xabier Rodriguez-Calvar. + +Add null pointer check. + +* html/track/VTTCue.cpp: +(WebCore::VTTCue::removeDisplayTree): + 2017-01-18 Youenn Fablet [Fetch API] Update content-type in case of form data Modified: trunk/Source/WebCore/html/track/VTTCue.cpp (210854 => 210855) --- trunk/Source/WebCore/html/track/VTTCue.cpp 2017-01-18 18:45:12 UTC (rev 210854) +++ trunk/Source/WebCore/html/track/VTTCue.cpp 2017-01-18 18:45:59 UTC (rev 210855) @@ -838,7 +838,8 @@ if (m_notifyRegion && track()) { if (VTTRegionList* regions = track()->regions()) { if (VTTRegion* region = regions->getRegionById(m_regionId)) -region->willRemoveTextTrackCueBox(m_displayTree.get()); +if (hasDisplayTree()) +region->willRemoveTextTrackCueBox(m_displayTree.get()); } } ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [210856] branches/safari-603-branch/Source
Title: [210856] branches/safari-603-branch/Source Revision 210856 Author matthew_han...@apple.com Date 2017-01-18 11:09:13 -0800 (Wed, 18 Jan 2017) Log Message Merge r210822. rdar://problem/15607819 Modified Paths branches/safari-603-branch/Source/WebCore/ChangeLog branches/safari-603-branch/Source/WebCore/inspector/InspectorController.cpp branches/safari-603-branch/Source/WebCore/inspector/PageScriptDebugServer.cpp branches/safari-603-branch/Source/WebCore/page/Page.cpp branches/safari-603-branch/Source/WebCore/page/Page.h branches/safari-603-branch/Source/WebKit/mac/ChangeLog branches/safari-603-branch/Source/WebKit/mac/WebView/WebView.mm branches/safari-603-branch/Source/WebKit2/ChangeLog branches/safari-603-branch/Source/WebKit2/WebProcess/WebPage/WebPage.cpp branches/safari-603-branch/Source/WebKit2/WebProcess/WebPage/ios/WebPageIOS.mm Diff Modified: branches/safari-603-branch/Source/WebCore/ChangeLog (210855 => 210856) --- branches/safari-603-branch/Source/WebCore/ChangeLog 2017-01-18 18:45:59 UTC (rev 210855) +++ branches/safari-603-branch/Source/WebCore/ChangeLog 2017-01-18 19:09:13 UTC (rev 210856) @@ -1,3 +1,42 @@ +2017-01-18 Matthew Hanson + +Merge r210822. rdar://problem/15607819 + +2017-01-17 Joseph Pecoraro + +Crash when closing tab with debugger paused +https://bugs.webkit.org/show_bug.cgi?id=161746 + + +Reviewed by Brian Burg and Brent Fulgham. + +* page/Page.h: +(WebCore::Page::incrementNestedRunLoopCount): +(WebCore::Page::decrementNestedRunLoopCount): +(WebCore::Page::insideNestedRunLoop): +Keep track of whether or not this Page is inside of a nested run loop. +Currently the only nested run loop we know about is EventLoop used +by Web Inspector when debugging _javascript_. + +(WebCore::Page::whenUnnested): +Callback that can be called when we are no longer inside of a nested +run loop. + +(WebCore::Page::~Page): +Ensure we are not in a known nested run loop when destructing, since +that could be unsafe. + +* inspector/PageScriptDebugServer.cpp: +(WebCore::PageScriptDebugServer::runEventLoopWhilePausedInternal): +Increment and decrement as we go into or leave the nested runloop. + +* inspector/InspectorController.cpp: +(WebCore::InspectorController::inspectedPageDestroyed): +(WebCore::InspectorController::disconnectAllFrontends): +Rework destruction to allow disconnectAllFrontends to happen earlier +if necessary. WebKit clients may use this to disconnect remote +frontends when closing a Page. + 2017-01-12 Matthew Hanson Merge r210447. rdar://problem/29872292 Modified: branches/safari-603-branch/Source/WebCore/inspector/InspectorController.cpp (210855 => 210856) --- branches/safari-603-branch/Source/WebCore/inspector/InspectorController.cpp 2017-01-18 18:45:59 UTC (rev 210855) +++ branches/safari-603-branch/Source/WebCore/inspector/InspectorController.cpp 2017-01-18 19:09:13 UTC (rev 210856) @@ -203,16 +203,13 @@ { m_injectedScriptManager->disconnect(); -// If the local frontend page was destroyed, close the window. -if (m_inspectorFrontendClient) -m_inspectorFrontendClient->closeWindow(); - -// The frontend should call setInspectorFrontendClient(nullptr) under closeWindow(). -ASSERT(!m_inspectorFrontendClient); - // Clean up resources and disconnect local and remote frontends. disconnectAllFrontends(); +// Disconnect the client. +m_inspectorClient->inspectedPageDestroyed(); +m_inspectorClient = nullptr; + m_agents.discardValues(); } @@ -300,9 +297,16 @@ void InspectorController::disconnectAllFrontends() { -// The local frontend client should be disconnected already. +// If the local frontend page was destroyed, close the window. +if (m_inspectorFrontendClient) +m_inspectorFrontendClient->closeWindow(); + +// The frontend should call setInspectorFrontendClient(nullptr) under closeWindow(). ASSERT(!m_inspectorFrontendClient); +if (!m_frontendRouter->hasFrontends()) +return; + for (unsigned i = 0; i < m_frontendRouter->frontendCount(); ++i) InspectorInstrumentation::frontendDeleted(); @@ -315,10 +319,6 @@ // Destroy the inspector overlay's page. m_overlay->freePage(); -// Disconnect local WK2 frontend and destroy the client. -m_inspectorClient->inspectedPageDestroyed(); -m_inspectorClient = nullptr; - // Disconnect any remaining remote frontends. m_frontendRouter->disconnectAllFrontends(); m_isAutomaticInspection = false; Modified: branches/safari-603-branch/Source/WebCore/inspector/PageScriptDebugServer.cpp (210855 => 210856) --- branches/safari-603-branch/Source/We
[webkit-changes] [210857] trunk/Source/WebCore
Title: [210857] trunk/Source/WebCore Revision 210857 Author ryanhad...@apple.com Date 2017-01-18 11:27:48 -0800 (Wed, 18 Jan 2017) Log Message Remove WEBCORE_EXPORT from newly inlined functions after r210845. Unreviewed build fix. * loader/DocumentLoader.h: Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/loader/DocumentLoader.h Diff Modified: trunk/Source/WebCore/ChangeLog (210856 => 210857) --- trunk/Source/WebCore/ChangeLog 2017-01-18 19:09:13 UTC (rev 210856) +++ trunk/Source/WebCore/ChangeLog 2017-01-18 19:27:48 UTC (rev 210857) @@ -1,3 +1,11 @@ +2017-01-18 Ryan Haddad + +Remove WEBCORE_EXPORT from newly inlined functions after r210845. + +Unreviewed build fix. + +* loader/DocumentLoader.h: + 2017-01-18 Per Arne Vollan Crash when changing video subtitles. Modified: trunk/Source/WebCore/loader/DocumentLoader.h (210856 => 210857) --- trunk/Source/WebCore/loader/DocumentLoader.h 2017-01-18 19:09:13 UTC (rev 210856) +++ trunk/Source/WebCore/loader/DocumentLoader.h 2017-01-18 19:27:48 UTC (rev 210857) @@ -99,22 +99,22 @@ DocumentWriter& writer() const { return m_writer; } -WEBCORE_EXPORT const ResourceRequest& originalRequest() const; -WEBCORE_EXPORT const ResourceRequest& originalRequestCopy() const; +const ResourceRequest& originalRequest() const; +const ResourceRequest& originalRequestCopy() const; -WEBCORE_EXPORT const ResourceRequest& request() const; -WEBCORE_EXPORT ResourceRequest& request(); +const ResourceRequest& request() const; +ResourceRequest& request(); CachedResourceLoader& cachedResourceLoader() { return m_cachedResourceLoader; } const SubstituteData& substituteData() const { return m_substituteData; } -WEBCORE_EXPORT const URL& url() const; -WEBCORE_EXPORT const URL& unreachableURL() const; +const URL& url() const; +const URL& unreachableURL() const; const URL& originalURL() const; -WEBCORE_EXPORT const URL& responseURL() const; -WEBCORE_EXPORT const String& responseMIMEType() const; +const URL& responseURL() const; +const String& responseMIMEType() const; #if PLATFORM(IOS) // FIXME: This method seems to violate the encapsulation of this class. WEBCORE_EXPORT void setResponseMIMEType(const String&); ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [210858] trunk/Source/JavaScriptCore
Title: [210858] trunk/Source/_javascript_Core Revision 210858 Author fpi...@apple.com Date 2017-01-18 11:30:50 -0800 (Wed, 18 Jan 2017) Log Message JSObjectSetPrivate should not use jsCast<> rdar://problem/30069096 Reviewed by Keith Miller. * API/JSObjectRef.cpp: (JSObjectSetPrivate): Modified Paths trunk/Source/_javascript_Core/API/JSObjectRef.cpp trunk/Source/_javascript_Core/ChangeLog Diff Modified: trunk/Source/_javascript_Core/API/JSObjectRef.cpp (210857 => 210858) --- trunk/Source/_javascript_Core/API/JSObjectRef.cpp 2017-01-18 19:27:48 UTC (rev 210857) +++ trunk/Source/_javascript_Core/API/JSObjectRef.cpp 2017-01-18 19:30:50 UTC (rev 210858) @@ -425,21 +425,21 @@ // Get wrapped object if proxied if (classInfo->isSubClassOf(JSProxy::info())) { -jsObject = jsCast(jsObject)->target(); +jsObject = static_cast(jsObject)->target(); classInfo = jsObject->classInfo(); } if (classInfo->isSubClassOf(JSCallbackObject::info())) { -jsCast*>(jsObject)->setPrivate(data); +static_cast*>(jsObject)->setPrivate(data); return true; } if (classInfo->isSubClassOf(JSCallbackObject::info())) { -jsCast*>(jsObject)->setPrivate(data); +static_cast*>(jsObject)->setPrivate(data); return true; } #if JSC_OBJC_API_ENABLED if (classInfo->isSubClassOf(JSCallbackObject::info())) { -jsCast*>(jsObject)->setPrivate(data); +static_cast*>(jsObject)->setPrivate(data); return true; } #endif Modified: trunk/Source/_javascript_Core/ChangeLog (210857 => 210858) --- trunk/Source/_javascript_Core/ChangeLog 2017-01-18 19:27:48 UTC (rev 210857) +++ trunk/Source/_javascript_Core/ChangeLog 2017-01-18 19:30:50 UTC (rev 210858) @@ -1,3 +1,13 @@ +2017-01-18 Filip Pizlo + +JSObjectSetPrivate should not use jsCast<> +rdar://problem/30069096 + +Reviewed by Keith Miller. + +* API/JSObjectRef.cpp: +(JSObjectSetPrivate): + 2017-01-18 Brian Burg Web Inspector: remove an unnecessary include in generated Objective-C Inspector protocol code ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [210860] trunk
Title: [210860] trunk Revision 210860 Author commit-qu...@webkit.org Date 2017-01-18 11:51:49 -0800 (Wed, 18 Jan 2017) Log Message Reject fetch promise in case of ReadableStream upload https://bugs.webkit.org/show_bug.cgi?id=167145 Patch by Youenn Fablet on 2017-01-18 Reviewed by Alex Christensen. LayoutTests/imported/w3c: * web-platform-tests/fetch/api/basic/request-upload-expected.txt: * web-platform-tests/fetch/api/basic/request-upload-worker-expected.txt: Source/WebCore: Covered by rebased tests. * Modules/fetch/FetchBody.cpp: (WebCore::FetchBody::extract): Storing the fact that body data is represented as a ReadableStream. * Modules/fetch/FetchBody.h: (WebCore::FetchBody::isReadableStream): * Modules/fetch/FetchRequest.h: * Modules/fetch/FetchResponse.cpp: (WebCore::FetchResponse::fetch): Rejecting if request body data is a ReadableStream. LayoutTests: * TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/TestExpectations trunk/LayoutTests/imported/w3c/ChangeLog trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/basic/request-upload-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/basic/request-upload-worker-expected.txt trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/Modules/fetch/FetchBody.cpp trunk/Source/WebCore/Modules/fetch/FetchBody.h trunk/Source/WebCore/Modules/fetch/FetchRequest.h trunk/Source/WebCore/Modules/fetch/FetchResponse.cpp Diff Modified: trunk/LayoutTests/ChangeLog (210859 => 210860) --- trunk/LayoutTests/ChangeLog 2017-01-18 19:35:49 UTC (rev 210859) +++ trunk/LayoutTests/ChangeLog 2017-01-18 19:51:49 UTC (rev 210860) @@ -1,5 +1,14 @@ 2017-01-18 Youenn Fablet +Reject fetch promise in case of ReadableStream upload +https://bugs.webkit.org/show_bug.cgi?id=167145 + +Reviewed by Alex Christensen. + +* TestExpectations: + +2017-01-18 Youenn Fablet + [Fetch API] Update content-type in case of form data https://bugs.webkit.org/show_bug.cgi?id=167143 Modified: trunk/LayoutTests/TestExpectations (210859 => 210860) --- trunk/LayoutTests/TestExpectations 2017-01-18 19:35:49 UTC (rev 210859) +++ trunk/LayoutTests/TestExpectations 2017-01-18 19:51:49 UTC (rev 210860) @@ -311,9 +311,6 @@ webkit.org/b/157145 imported/w3c/web-platform-tests/fetch/nosniff/stylesheet.html [ Failure Pass ] webkit.org/b/161312 imported/w3c/web-platform-tests/html/semantics/document-metadata/the-link-element/document-without-browsing-context.html [ Failure Pass ] -[ Debug ] imported/w3c/web-platform-tests/fetch/api/basic/request-upload.html [ Skip ] -[ Debug ] imported/w3c/web-platform-tests/fetch/api/basic/request-upload-worker.html [ Skip ] - imported/w3c/web-platform-tests/fetch/api/cors/cors-origin.html [ DumpJSConsoleLogInStdErr ] imported/w3c/web-platform-tests/fetch/api/cors/cors-preflight.html [ DumpJSConsoleLogInStdErr ] imported/w3c/web-platform-tests/fetch/api/cors/cors-preflight-redirect.html [ DumpJSConsoleLogInStdErr ] Modified: trunk/LayoutTests/imported/w3c/ChangeLog (210859 => 210860) --- trunk/LayoutTests/imported/w3c/ChangeLog 2017-01-18 19:35:49 UTC (rev 210859) +++ trunk/LayoutTests/imported/w3c/ChangeLog 2017-01-18 19:51:49 UTC (rev 210860) @@ -1,5 +1,15 @@ 2017-01-18 Youenn Fablet +Reject fetch promise in case of ReadableStream upload +https://bugs.webkit.org/show_bug.cgi?id=167145 + +Reviewed by Alex Christensen. + +* web-platform-tests/fetch/api/basic/request-upload-expected.txt: +* web-platform-tests/fetch/api/basic/request-upload-worker-expected.txt: + +2017-01-18 Youenn Fablet + [Fetch API] Update content-type in case of form data https://bugs.webkit.org/show_bug.cgi?id=167143 Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/basic/request-upload-expected.txt (210859 => 210860) --- trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/basic/request-upload-expected.txt 2017-01-18 19:35:49 UTC (rev 210859) +++ trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/basic/request-upload-expected.txt 2017-01-18 19:51:49 UTC (rev 210860) @@ -10,7 +10,7 @@ PASS Fetch with POST with Float64Array body PASS Fetch with POST with DataView body PASS Fetch with POST with Blob body with mime type -FAIL Fetch with POST with ReadableStream assert_equals: expected "Test" but got "" +FAIL Fetch with POST with ReadableStream promise_test: Unhandled rejection with value: object "TypeError: ReadableStream uploading is not supported" FAIL Fetch with POST with ReadableStream containing String undefined is not an object (evaluating 'promise.then') FAIL Fetch with POST with ReadableStream containing null undefined is not an object (evaluating 'promise.then') FAIL Fetch with POST with ReadableStream containing number undefined is not an object (evaluating 'promise.then') Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/bas
[webkit-changes] [210861] trunk/Source/WebKit2
Title: [210861] trunk/Source/WebKit2 Revision 210861 Author megan_gard...@apple.com Date 2017-01-18 11:57:16 -0800 (Wed, 18 Jan 2017) Log Message Ignore Connection Assertion if we are not using connection to send messages https://bugs.webkit.org/show_bug.cgi?id=167022 Reviewed by Darin Adler. Ask the process about a particular connection rather that getting it and making the comparison ourselves. * UIProcess/ChildProcessProxy.h: (WebKit::ChildProcessProxy::hasConnection): Check to see the the ProcessProxy has this particular connection. This get around the assert that we would run into when just requesting the connection directly. * UIProcess/Cocoa/WebPasteboardProxyCocoa.mm: (WebKit::WebPasteboardProxy::setPasteboardPathnamesForType): Use the new check instead of getting the raw connection. Modified Paths trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/UIProcess/ChildProcessProxy.h trunk/Source/WebKit2/UIProcess/Cocoa/WebPasteboardProxyCocoa.mm Diff Modified: trunk/Source/WebKit2/ChangeLog (210860 => 210861) --- trunk/Source/WebKit2/ChangeLog 2017-01-18 19:51:49 UTC (rev 210860) +++ trunk/Source/WebKit2/ChangeLog 2017-01-18 19:57:16 UTC (rev 210861) @@ -1,3 +1,21 @@ +2017-01-18 Megan Gardner + +Ignore Connection Assertion if we are not using connection to send messages +https://bugs.webkit.org/show_bug.cgi?id=167022 + +Reviewed by Darin Adler. + +Ask the process about a particular connection rather that getting it and making the +comparison ourselves. + +* UIProcess/ChildProcessProxy.h: +(WebKit::ChildProcessProxy::hasConnection): +Check to see the the ProcessProxy has this particular connection. This get around the assert +that we would run into when just requesting the connection directly. +* UIProcess/Cocoa/WebPasteboardProxyCocoa.mm: +(WebKit::WebPasteboardProxy::setPasteboardPathnamesForType): +Use the new check instead of getting the raw connection. + 2017-01-18 Andreas Kling Document::securityOrigin() should return a reference. Modified: trunk/Source/WebKit2/UIProcess/ChildProcessProxy.h (210860 => 210861) --- trunk/Source/WebKit2/UIProcess/ChildProcessProxy.h 2017-01-18 19:51:49 UTC (rev 210860) +++ trunk/Source/WebKit2/UIProcess/ChildProcessProxy.h 2017-01-18 19:57:16 UTC (rev 210861) @@ -51,6 +51,11 @@ ASSERT(m_connection); return m_connection.get(); } + +bool hasConnection(const IPC::Connection& connection) const +{ +return m_connection == &connection; +} void addMessageReceiver(IPC::StringReference messageReceiverName, IPC::MessageReceiver&); void addMessageReceiver(IPC::StringReference messageReceiverName, uint64_t destinationID, IPC::MessageReceiver&); Modified: trunk/Source/WebKit2/UIProcess/Cocoa/WebPasteboardProxyCocoa.mm (210860 => 210861) --- trunk/Source/WebKit2/UIProcess/Cocoa/WebPasteboardProxyCocoa.mm 2017-01-18 19:51:49 UTC (rev 210860) +++ trunk/Source/WebKit2/UIProcess/Cocoa/WebPasteboardProxyCocoa.mm 2017-01-18 19:57:16 UTC (rev 210861) @@ -102,7 +102,7 @@ void WebPasteboardProxy::setPasteboardPathnamesForType(IPC::Connection& connection, const String& pasteboardName, const String& pasteboardType, const Vector& pathnames, uint64_t& newChangeCount) { for (auto* webProcessProxy : m_webProcessProxyList) { -if (webProcessProxy->connection() != &connection) +if (!webProcessProxy->hasConnection(connection)) continue; for (const auto& pathname : pathnames) { ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [210862] trunk
Title: [210862] trunk Revision 210862 Author commit-qu...@webkit.org Date 2017-01-18 12:06:46 -0800 (Wed, 18 Jan 2017) Log Message [Streams API] ReadableStream generic reader constructor does not need to call ReadableStream getReader https://bugs.webkit.org/show_bug.cgi?id=167137 Patch by Youenn Fablet on 2017-01-18 Reviewed by Xabier Rodriguez-Calvar. Source/WebCore: Test: streams/shadowing-getReader.html * bindings/js/JSReadableStreamPrivateConstructors.cpp: (WebCore::constructJSReadableStreamDefaultReader): Using private constructor instead of getReader. LayoutTests: * streams/shadowing-getReader-expected.txt: Added. * streams/shadowing-getReader.html: Added. Modified Paths trunk/LayoutTests/ChangeLog trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/bindings/js/JSReadableStreamPrivateConstructors.cpp Added Paths trunk/LayoutTests/streams/shadowing-getReader-expected.txt trunk/LayoutTests/streams/shadowing-getReader.html Diff Modified: trunk/LayoutTests/ChangeLog (210861 => 210862) --- trunk/LayoutTests/ChangeLog 2017-01-18 19:57:16 UTC (rev 210861) +++ trunk/LayoutTests/ChangeLog 2017-01-18 20:06:46 UTC (rev 210862) @@ -1,5 +1,15 @@ 2017-01-18 Youenn Fablet +[Streams API] ReadableStream generic reader constructor does not need to call ReadableStream getReader +https://bugs.webkit.org/show_bug.cgi?id=167137 + +Reviewed by Xabier Rodriguez-Calvar. + +* streams/shadowing-getReader-expected.txt: Added. +* streams/shadowing-getReader.html: Added. + +2017-01-18 Youenn Fablet + Reject fetch promise in case of ReadableStream upload https://bugs.webkit.org/show_bug.cgi?id=167145 Added: trunk/LayoutTests/streams/shadowing-getReader-expected.txt (0 => 210862) --- trunk/LayoutTests/streams/shadowing-getReader-expected.txt (rev 0) +++ trunk/LayoutTests/streams/shadowing-getReader-expected.txt 2017-01-18 20:06:46 UTC (rev 210862) @@ -0,0 +1,10 @@ +This test should run without throwing an exception. + +On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE". + + +PASS new readerConstructor(stream) instanceof readerConstructor is true +PASS successfullyParsed is true + +TEST COMPLETE + Added: trunk/LayoutTests/streams/shadowing-getReader.html (0 => 210862) --- trunk/LayoutTests/streams/shadowing-getReader.html (rev 0) +++ trunk/LayoutTests/streams/shadowing-getReader.html 2017-01-18 20:06:46 UTC (rev 210862) @@ -0,0 +1,20 @@ + + + + + +