[webkit-changes] [215174] trunk/LayoutTests
Title: [215174] trunk/LayoutTests Revision 215174 Author carlo...@webkit.org Date 2017-04-10 01:28:40 -0700 (Mon, 10 Apr 2017) Log Message Unreviewed GTK+ gardening. Mark several tests as failing/timing out. * platform/gtk/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/gtk/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (215173 => 215174) --- trunk/LayoutTests/ChangeLog 2017-04-10 08:02:21 UTC (rev 215173) +++ trunk/LayoutTests/ChangeLog 2017-04-10 08:28:40 UTC (rev 215174) @@ -1,3 +1,9 @@ +2017-04-10 Carlos Garcia Campos + +Unreviewed GTK+ gardening. Mark several tests as failing/timing out. + +* platform/gtk/TestExpectations: + 2017-04-10 Miguel Gomez REGRESSION(r205841): [GTK] Test fast/images/animated-png.html is failing since r205841 Modified: trunk/LayoutTests/platform/gtk/TestExpectations (215173 => 215174) --- trunk/LayoutTests/platform/gtk/TestExpectations 2017-04-10 08:02:21 UTC (rev 215173) +++ trunk/LayoutTests/platform/gtk/TestExpectations 2017-04-10 08:28:40 UTC (rev 215174) @@ -646,6 +646,7 @@ webrtc/video-replace-track-to-null.html [ Failure ] webrtc/video-replace-track.html [ Failure ] webrtc/video-getParameters.html [ Failure ] +webrtc/ephemeral-certificates-and-cnames.html [ Failure ] imported/w3c/web-platform-tests/webrtc/datachannel-emptystring.html [ Failure ] imported/w3c/web-platform-tests/webrtc/no-media-call.html [ Failure ] imported/w3c/web-platform-tests/webrtc/promises-call.html [ Failure ] @@ -768,22 +769,30 @@ webkit.org/b/133320 crypto/webkitSubtle/hmac-sign-verify-empty-key.html [ Pass ] webkit.org/b/133320 crypto/webkitSubtle/hmac-sign-verify.html [ Pass ] +webkit.org/b/133122 imported/w3c/web-platform-tests/WebCryptoAPI/derive_bits_keys/test_hkdf.html [ Timeout ] webkit.org/b/133122 imported/w3c/web-platform-tests/WebCryptoAPI/encrypt_decrypt/aes_cbc.worker.html [ Failure ] +webkit.org/b/133122 imported/w3c/web-platform-tests/WebCryptoAPI/encrypt_decrypt/test_aes_ctr.html [ Failure ] +webkit.org/b/133122 imported/w3c/web-platform-tests/WebCryptoAPI/encrypt_decrypt/aes_ctr.worker.html [ Failure ] webkit.org/b/133122 imported/w3c/web-platform-tests/WebCryptoAPI/encrypt_decrypt/aes_gcm.worker.html [ Failure ] webkit.org/b/133122 imported/w3c/web-platform-tests/WebCryptoAPI/encrypt_decrypt/rsa.worker.html [ Failure ] webkit.org/b/133122 imported/w3c/web-platform-tests/WebCryptoAPI/encrypt_decrypt/test_aes_cbc.html [ Failure ] webkit.org/b/133122 imported/w3c/web-platform-tests/WebCryptoAPI/encrypt_decrypt/test_aes_gcm.html [ Failure ] webkit.org/b/133122 imported/w3c/web-platform-tests/WebCryptoAPI/encrypt_decrypt/test_rsa_oaep.html [ Failure ] +webkit.org/b/133122 imported/w3c/web-platform-tests/WebCryptoAPI/generateKey/failures_AES-CTR.worker.html [ Failure ] webkit.org/b/133122 imported/w3c/web-platform-tests/WebCryptoAPI/generateKey/failures_AES-GCM.worker.html [ Failure ] webkit.org/b/133122 imported/w3c/web-platform-tests/WebCryptoAPI/generateKey/failures_RSA-OAEP.worker.html [ Failure ] webkit.org/b/133122 imported/w3c/web-platform-tests/WebCryptoAPI/generateKey/failures_RSASSA-PKCS1-v1_5.worker.html [ Failure ] +webkit.org/b/133122 imported/w3c/web-platform-tests/WebCryptoAPI/generateKey/successes_AES-CTR.worker.html [ Failure ] webkit.org/b/133122 imported/w3c/web-platform-tests/WebCryptoAPI/generateKey/successes_AES-GCM.worker.html [ Failure ] webkit.org/b/133122 imported/w3c/web-platform-tests/WebCryptoAPI/generateKey/successes_RSASSA-PKCS1-v1_5.worker.html [ Failure ] +webkit.org/b/133122 imported/w3c/web-platform-tests/WebCryptoAPI/generateKey/test_aes-ctr.html [ Failure ] +webkit.org/b/133122 imported/w3c/web-platform-tests/WebCryptoAPI/generateKey/test_failures_AES-CTR.html [ Failure ] webkit.org/b/133122 imported/w3c/web-platform-tests/WebCryptoAPI/generateKey/test_failures_AES-GCM.html [ Failure ] -webkit.org/b/133122 imported/w3c/web-platform-tests/WebCryptoAPI/generateKey/test_failures_RSA-OAEP.html [ Failure ] -webkit.org/b/133122 imported/w3c/web-platform-tests/WebCryptoAPI/generateKey/test_failures_RSASSA-PKCS1-v1_5.html [ Failure ] +webkit.org/b/133122 imported/w3c/web-platform-tests/WebCryptoAPI/generateKey/test_failures_RSA-OAEP.html [ Failure Timeout ] +webkit.org/b/133122 imported/w3c/web-platform-tests/WebCryptoAPI/generateKey/test_failures_RSASSA-PKCS1-v1_5.html [ Failure Timeout ] +webkit.org/b/133122 imported/w3c/web-platform-tests/WebCryptoAPI/generateKey/test_successes_AES-CTR.html [ Failure ] webkit.org/b/133122 imported/w3c/web-platform-tests/WebCryptoAPI/generateKey/test_successes_AES-GCM.html [ Failure ] -webkit.org/b/133122 imported/w3c/web-platform-tests/WebCryptoAPI/generateKey/test_successes_RSASSA-PKCS1-v1_5.html [ Failure ] +webkit.org/b/133122 imported/w3c/web-platform-tests/WebCryptoAPI/generateKey/test_successes_RSASSA-PKCS1-v1_5.html [ Failure Timeout ] webkit.org/b/133122 imported/w3c/web-platform-
[webkit-changes] [215175] trunk/Source/WebCore
Title: [215175] trunk/Source/WebCore
Revision 215175
Author pvol...@apple.com
Date 2017-04-10 03:01:46 -0700 (Mon, 10 Apr 2017)
Log Message
Add fallback fonts to video captions stylesheet.
https://bugs.webkit.org/show_bug.cgi?id=170495
Reviewed by Myles C. Maxfield.
The kCTFontCascadeListAttribute key is used to obtain the cascade list for a font reference.
I have not added a test, since CaptionUserPreferences::testingMode() returns true when running tests,
preventing this code path from being executed.
* page/CaptionUserPreferencesMediaAF.cpp:
(WebCore::CaptionUserPreferencesMediaAF::captionsDefaultFontCSS):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/CaptionUserPreferencesMediaAF.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (215174 => 215175)
--- trunk/Source/WebCore/ChangeLog 2017-04-10 08:28:40 UTC (rev 215174)
+++ trunk/Source/WebCore/ChangeLog 2017-04-10 10:01:46 UTC (rev 215175)
@@ -1,3 +1,18 @@
+2017-04-10 Per Arne Vollan
+
+Add fallback fonts to video captions stylesheet.
+https://bugs.webkit.org/show_bug.cgi?id=170495
+
+Reviewed by Myles C. Maxfield.
+
+The kCTFontCascadeListAttribute key is used to obtain the cascade list for a font reference.
+
+I have not added a test, since CaptionUserPreferences::testingMode() returns true when running tests,
+preventing this code path from being executed.
+
+* page/CaptionUserPreferencesMediaAF.cpp:
+(WebCore::CaptionUserPreferencesMediaAF::captionsDefaultFontCSS):
+
2017-04-10 Chris Dumez
Drop Timer::startOneShot() overload taking a double
Modified: trunk/Source/WebCore/page/CaptionUserPreferencesMediaAF.cpp (215174 => 215175)
--- trunk/Source/WebCore/page/CaptionUserPreferencesMediaAF.cpp 2017-04-10 08:28:40 UTC (rev 215174)
+++ trunk/Source/WebCore/page/CaptionUserPreferencesMediaAF.cpp 2017-04-10 10:01:46 UTC (rev 215175)
@@ -83,6 +83,8 @@
SOFT_LINK_AVF_FRAMEWORK_IMPORT(CoreText, CTFontDescriptorCopyAttribute, CFTypeRef, (CTFontDescriptorRef descriptor, CFStringRef attribute), (descriptor, attribute));
SOFT_LINK_AVF_POINTER(CoreText, kCTFontNameAttribute, CFStringRef)
#define kCTFontNameAttribute getkCTFontNameAttribute()
+SOFT_LINK_AVF_POINTER(CoreText, kCTFontCascadeListAttribute, CFStringRef)
+#define kCTFontCascadeListAttribute getkCTFontCascadeListAttribute()
#define CTFontDescriptorCopyAttribute softLink_CTFontDescriptorCopyAttribute
@@ -424,7 +426,7 @@
RetainPtr name = adoptCF(CTFontDescriptorCopyAttribute(font.get(), kCTFontNameAttribute));
if (!name)
return emptyString();
-
+
StringBuilder builder;
builder.append(getPropertyNameString(CSSPropertyFontFamily));
@@ -431,6 +433,17 @@
builder.appendLiteral(": \"");
builder.append(static_cast(name.get()));
builder.append('"');
+
+auto cascadeList = adoptCF(static_cast(CTFontDescriptorCopyAttribute(font.get(), kCTFontCascadeListAttribute)));
+
+for (CFIndex i = 0; i < CFArrayGetCount(cascadeList.get()); i++) {
+auto fontCascade = static_cast(CFArrayGetValueAtIndex(cascadeList.get(), i));
+auto fontCascadeName = adoptCF(CTFontDescriptorCopyAttribute(fontCascade, kCTFontNameAttribute));
+builder.append(", \"");
+builder.append(static_cast(fontCascadeName.get()));
+builder.append('"');
+}
+
if (behavior == kMACaptionAppearanceBehaviorUseValue)
builder.appendLiteral(" !important");
builder.append(';');
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [215176] trunk/Tools
Title: [215176] trunk/Tools Revision 215176 Author commit-qu...@webkit.org Date 2017-04-10 03:16:26 -0700 (Mon, 10 Apr 2017) Log Message WTR: Avoid conversion from platform image to WKImage and then to platform image again when dumping pixel results https://bugs.webkit.org/show_bug.cgi?id=170653 Patch by Carlos Garcia Campos on 2017-04-10 Reviewed by Tim Horton. When dumping pixels from a web view snapshot, we create a platform image that is then converted to a WKImage, which is a ShareableBitmap, so the image is rendered into a graphics context. Then we immediately extract the platform image back from the WKImage to dump the pixels. We could avoid that conversion by taking the web snapshot from TestInvocation::dumpPixelsAndCompareWithExpected(). * WebKitTestRunner/PlatformWebView.h: Add PlatformImage typedef and use it as return value of windowSnapshotImage(). * WebKitTestRunner/TestInvocation.cpp: (WTR::TestInvocation::dumpResults): Pass the WKImage to dumpPixelsAndCompareWithExpected() only when pixel results were created in the web process. * WebKitTestRunner/TestInvocation.h: Make WKImage a default paramater of dumpPixelsAndCompareWithExpected(). * WebKitTestRunner/cairo/TestInvocationCairo.cpp: (WTR::TestInvocation::dumpPixelsAndCompareWithExpected): Create the cairo surface from the given WKimage in case of web contents snapshot, and use PlatformWebView::windowSnapshotImage() in case of web view snapshot. * WebKitTestRunner/cg/TestInvocationCG.cpp: (WTR::createCGContextFromCGImage): Changed to receive a CGImageRef and renamed. (WTR::createCGContextFromImage): Get the CGImageRef from the WKImage and call createCGContextFromCGImage(). (WTR::paintRepaintRectOverlay): It receives now the image size instead of the WKImage. (WTR::TestInvocation::dumpPixelsAndCompareWithExpected): Create the CGContextRef from the WKImage in case of web contents snpashot, and use PlatformWebView::windowSnapshotImage() in case of web view snapshot. * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp: (WTR::PlatformWebView::windowSnapshotImage): Return the cairo surface instead of creating a WKImage. Also use RGB24 format to match what mac does (kCGWindowImageShouldBeOpaque). * WebKitTestRunner/ios/PlatformWebViewIOS.mm: (WTR::PlatformWebView::windowSnapshotImage): Return the CGImageRef instead of creating a WKImage. * WebKitTestRunner/mac/PlatformWebViewMac.mm: (WTR::PlatformWebView::windowSnapshotImage): Ditto. Modified Paths trunk/Tools/ChangeLog trunk/Tools/WebKitTestRunner/PlatformWebView.h trunk/Tools/WebKitTestRunner/TestInvocation.cpp trunk/Tools/WebKitTestRunner/TestInvocation.h trunk/Tools/WebKitTestRunner/cairo/TestInvocationCairo.cpp trunk/Tools/WebKitTestRunner/cg/TestInvocationCG.cpp trunk/Tools/WebKitTestRunner/gtk/PlatformWebViewGtk.cpp trunk/Tools/WebKitTestRunner/ios/PlatformWebViewIOS.mm trunk/Tools/WebKitTestRunner/mac/PlatformWebViewMac.mm Diff Modified: trunk/Tools/ChangeLog (215175 => 215176) --- trunk/Tools/ChangeLog 2017-04-10 10:01:46 UTC (rev 215175) +++ trunk/Tools/ChangeLog 2017-04-10 10:16:26 UTC (rev 215176) @@ -1,3 +1,37 @@ +2017-04-10 Carlos Garcia Campos + +WTR: Avoid conversion from platform image to WKImage and then to platform image again when dumping pixel results +https://bugs.webkit.org/show_bug.cgi?id=170653 + +Reviewed by Tim Horton. + +When dumping pixels from a web view snapshot, we create a platform image that is then converted to a WKImage, +which is a ShareableBitmap, so the image is rendered into a graphics context. Then we immediately extract the +platform image back from the WKImage to dump the pixels. We could avoid that conversion by taking the web +snapshot from TestInvocation::dumpPixelsAndCompareWithExpected(). + +* WebKitTestRunner/PlatformWebView.h: Add PlatformImage typedef and use it as return value of windowSnapshotImage(). +* WebKitTestRunner/TestInvocation.cpp: +(WTR::TestInvocation::dumpResults): Pass the WKImage to dumpPixelsAndCompareWithExpected() only when pixel +results were created in the web process. +* WebKitTestRunner/TestInvocation.h: Make WKImage a default paramater of dumpPixelsAndCompareWithExpected(). +* WebKitTestRunner/cairo/TestInvocationCairo.cpp: +(WTR::TestInvocation::dumpPixelsAndCompareWithExpected): Create the cairo surface from the given WKimage in case +of web contents snapshot, and use PlatformWebView::windowSnapshotImage() in case of web view snapshot. +* WebKitTestRunner/cg/TestInvocationCG.cpp: +(WTR::createCGContextFromCGImage): Changed to receive a CGImageRef and renamed. +(WTR::createCGContextFromImage): Get the CGImageRef from the WKImage and call createCGContextFromCGImage(). +(WTR::paintRepaintRectOverlay): It receives now the image size instead of the WKImage. +(WTR::TestInvocation::dumpPixelsAndCompareWithExpected): Create the CGContextRef from the WKI
[webkit-changes] [215177] trunk/Source/WebKit2
Title: [215177] trunk/Source/WebKit2 Revision 215177 Author carlo...@webkit.org Date 2017-04-10 04:04:34 -0700 (Mon, 10 Apr 2017) Log Message [GTK] Enable DOM timer throttling and CSS animations suspension https://bugs.webkit.org/show_bug.cgi?id=170669 Reviewed by Žan Doberšek. * Shared/WebPreferencesDefinitions.h: Modified Paths trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/Shared/WebPreferencesDefinitions.h Diff Modified: trunk/Source/WebKit2/ChangeLog (215176 => 215177) --- trunk/Source/WebKit2/ChangeLog 2017-04-10 10:16:26 UTC (rev 215176) +++ trunk/Source/WebKit2/ChangeLog 2017-04-10 11:04:34 UTC (rev 215177) @@ -1,3 +1,12 @@ +2017-04-10 Carlos Garcia Campos + +[GTK] Enable DOM timer throttling and CSS animations suspension +https://bugs.webkit.org/show_bug.cgi?id=170669 + +Reviewed by Žan Doberšek. + +* Shared/WebPreferencesDefinitions.h: + 2017-04-10 Chris Dumez Drop Timer::startOneShot() overload taking a double Modified: trunk/Source/WebKit2/Shared/WebPreferencesDefinitions.h (215176 => 215177) --- trunk/Source/WebKit2/Shared/WebPreferencesDefinitions.h 2017-04-10 10:16:26 UTC (rev 215176) +++ trunk/Source/WebKit2/Shared/WebPreferencesDefinitions.h 2017-04-10 11:04:34 UTC (rev 215177) @@ -37,13 +37,17 @@ #define DEFAULT_WEBKIT_SCROLL_ANIMATOR_ENABLED false #endif -#if PLATFORM(COCOA) +#if PLATFORM(COCOA) || PLATFORM(GTK) #define DEFAULT_HIDDEN_PAGE_DOM_TIMER_THROTTLING_ENABLED true #define DEFAULT_HIDDEN_PAGE_CSS_ANIMATION_SUSPENSION_ENABLED true -#define DEFAULT_PDFPLUGIN_ENABLED true #else #define DEFAULT_HIDDEN_PAGE_DOM_TIMER_THROTTLING_ENABLED false #define DEFAULT_HIDDEN_PAGE_CSS_ANIMATION_SUSPENSION_ENABLED false +#endif + +#if PLATFORM(COCOA) +#define DEFAULT_PDFPLUGIN_ENABLED true +#else #define DEFAULT_PDFPLUGIN_ENABLED false #endif ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [215178] trunk
Title: [215178] trunk
Revision 215178
Author carlo...@webkit.org
Date 2017-04-10 04:44:21 -0700 (Mon, 10 Apr 2017)
Log Message
REGRESSION(r214426): [GTK] Test media/video-click-dblckick-standalone.html started to fail in the bots after r214426
https://bugs.webkit.org/show_bug.cgi?id=170667
Reviewed by Žan Doberšek.
Tools:
In r214666 we disabled modern media controls runtime feature for the GTK+ port, but layout tests still override
that value.
* WebKitTestRunner/gtk/TestControllerGtk.cpp:
(WTR::TestController::updatePlatformSpecificTestOptionsForTest): Disable modern media controls.
LayoutTests:
Unskip then test that is passing now.
* platform/gtk/TestExpectations:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/gtk/TestExpectations
trunk/Tools/ChangeLog
trunk/Tools/WebKitTestRunner/gtk/TestControllerGtk.cpp
Diff
Modified: trunk/LayoutTests/ChangeLog (215177 => 215178)
--- trunk/LayoutTests/ChangeLog 2017-04-10 11:04:34 UTC (rev 215177)
+++ trunk/LayoutTests/ChangeLog 2017-04-10 11:44:21 UTC (rev 215178)
@@ -1,5 +1,16 @@
2017-04-10 Carlos Garcia Campos
+REGRESSION(r214426): [GTK] Test media/video-click-dblckick-standalone.html started to fail in the bots after r214426
+https://bugs.webkit.org/show_bug.cgi?id=170667
+
+Reviewed by Žan Doberšek.
+
+Unskip then test that is passing now.
+
+* platform/gtk/TestExpectations:
+
+2017-04-10 Carlos Garcia Campos
+
Unreviewed GTK+ gardening. Mark several tests as failing/timing out.
* platform/gtk/TestExpectations:
Modified: trunk/LayoutTests/platform/gtk/TestExpectations (215177 => 215178)
--- trunk/LayoutTests/platform/gtk/TestExpectations 2017-04-10 11:04:34 UTC (rev 215177)
+++ trunk/LayoutTests/platform/gtk/TestExpectations 2017-04-10 11:44:21 UTC (rev 215178)
@@ -3495,8 +3495,6 @@
webkit.org/b/170335 canvas/philip/tests/2d.pattern.animated.gif.html [ Failure ]
webkit.org/b/170335 svg/animations/animated-svg-image-outside-viewport-paused.html [ Failure ]
-webkit.org/b/170667 media/video-click-dblckick-standalone.html [ Failure ]
-
#
# End of non-crashing, non-flaky tests failing
#
Modified: trunk/Tools/ChangeLog (215177 => 215178)
--- trunk/Tools/ChangeLog 2017-04-10 11:04:34 UTC (rev 215177)
+++ trunk/Tools/ChangeLog 2017-04-10 11:44:21 UTC (rev 215178)
@@ -1,5 +1,18 @@
2017-04-10 Carlos Garcia Campos
+REGRESSION(r214426): [GTK] Test media/video-click-dblckick-standalone.html started to fail in the bots after r214426
+https://bugs.webkit.org/show_bug.cgi?id=170667
+
+Reviewed by Žan Doberšek.
+
+In r214666 we disabled modern media controls runtime feature for the GTK+ port, but layout tests still override
+that value.
+
+* WebKitTestRunner/gtk/TestControllerGtk.cpp:
+(WTR::TestController::updatePlatformSpecificTestOptionsForTest): Disable modern media controls.
+
+2017-04-10 Carlos Garcia Campos
+
WTR: Avoid conversion from platform image to WKImage and then to platform image again when dumping pixel results
https://bugs.webkit.org/show_bug.cgi?id=170653
Modified: trunk/Tools/WebKitTestRunner/gtk/TestControllerGtk.cpp (215177 => 215178)
--- trunk/Tools/WebKitTestRunner/gtk/TestControllerGtk.cpp 2017-04-10 11:04:34 UTC (rev 215177)
+++ trunk/Tools/WebKitTestRunner/gtk/TestControllerGtk.cpp 2017-04-10 11:44:21 UTC (rev 215178)
@@ -155,8 +155,9 @@
m_mainWebView->dismissAllPopupMenus();
}
-void TestController::updatePlatformSpecificTestOptionsForTest(TestOptions&, const std::string&) const
+void TestController::updatePlatformSpecificTestOptionsForTest(TestOptions& options, const std::string&) const
{
+options.enableModernMediaControls = false;
}
} // namespace WTR
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [215179] trunk/Tools
Title: [215179] trunk/Tools
Revision 215179
Author carlo...@webkit.org
Date 2017-04-10 04:48:22 -0700 (Mon, 10 Apr 2017)
Log Message
[GTK] Remove the GDK dependency from ImageDiff
https://bugs.webkit.org/show_bug.cgi?id=85299
Reviewed by Žan Doberšek.
Add a cairo only implementation of ImageDiff. We currently have 3 different implementations of ImageDiff: the
Gdk based one used by GTK+ port, the cairo based one used by WinCairo and the CG based one. Most of the code is
actually common in all of them, but it's duplicated. So, I've taken advantage of this patch to refactor the
ImageDiff code to share the common implementation. This patch adds the cross-platform code, and the cairo
implementation and enables it in the GTK+ port. In follow up patches we can move WinCairo to this implementation
and also add CG implementation.
* ImageDiff/CMakeLists.txt:
* ImageDiff/Cairo.cmake: Added.
* ImageDiff/ImageDiff.cpp: Added.
(main):
* ImageDiff/PlatformGTK.cmake:
* ImageDiff/PlatformImage.cpp: Added.
(ImageDiff::PlatformImage::isCompatible):
(ImageDiff::PlatformImage::difference):
* ImageDiff/PlatformImage.h: Added.
* ImageDiff/cairo/PlatformImageCairo.cpp: Added.
(ImageDiff::PlatformImage::createFromStdin):
(ImageDiff::PlatformImage::createFromDiffData):
(ImageDiff::PlatformImage::PlatformImage):
(ImageDiff::PlatformImage::~PlatformImage):
(ImageDiff::PlatformImage::width):
(ImageDiff::PlatformImage::height):
(ImageDiff::PlatformImage::rowBytes):
(ImageDiff::PlatformImage::hasAlpha):
(ImageDiff::PlatformImage::pixels):
(ImageDiff::PlatformImage::writeAsPNGToStdout):
* ImageDiff/gtk/ImageDiff.cpp: Removed.
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/ImageDiff/CMakeLists.txt
trunk/Tools/ImageDiff/PlatformGTK.cmake
Added Paths
trunk/Tools/ImageDiff/Cairo.cmake
trunk/Tools/ImageDiff/ImageDiff.cpp
trunk/Tools/ImageDiff/PlatformImage.cpp
trunk/Tools/ImageDiff/PlatformImage.h
trunk/Tools/ImageDiff/cairo/
trunk/Tools/ImageDiff/cairo/PlatformImageCairo.cpp
Removed Paths
trunk/Tools/ImageDiff/gtk/
Diff
Modified: trunk/Tools/ChangeLog (215178 => 215179)
--- trunk/Tools/ChangeLog 2017-04-10 11:44:21 UTC (rev 215178)
+++ trunk/Tools/ChangeLog 2017-04-10 11:48:22 UTC (rev 215179)
@@ -1,5 +1,41 @@
2017-04-10 Carlos Garcia Campos
+[GTK] Remove the GDK dependency from ImageDiff
+https://bugs.webkit.org/show_bug.cgi?id=85299
+
+Reviewed by Žan Doberšek.
+
+Add a cairo only implementation of ImageDiff. We currently have 3 different implementations of ImageDiff: the
+Gdk based one used by GTK+ port, the cairo based one used by WinCairo and the CG based one. Most of the code is
+actually common in all of them, but it's duplicated. So, I've taken advantage of this patch to refactor the
+ImageDiff code to share the common implementation. This patch adds the cross-platform code, and the cairo
+implementation and enables it in the GTK+ port. In follow up patches we can move WinCairo to this implementation
+and also add CG implementation.
+
+* ImageDiff/CMakeLists.txt:
+* ImageDiff/Cairo.cmake: Added.
+* ImageDiff/ImageDiff.cpp: Added.
+(main):
+* ImageDiff/PlatformGTK.cmake:
+* ImageDiff/PlatformImage.cpp: Added.
+(ImageDiff::PlatformImage::isCompatible):
+(ImageDiff::PlatformImage::difference):
+* ImageDiff/PlatformImage.h: Added.
+* ImageDiff/cairo/PlatformImageCairo.cpp: Added.
+(ImageDiff::PlatformImage::createFromStdin):
+(ImageDiff::PlatformImage::createFromDiffData):
+(ImageDiff::PlatformImage::PlatformImage):
+(ImageDiff::PlatformImage::~PlatformImage):
+(ImageDiff::PlatformImage::width):
+(ImageDiff::PlatformImage::height):
+(ImageDiff::PlatformImage::rowBytes):
+(ImageDiff::PlatformImage::hasAlpha):
+(ImageDiff::PlatformImage::pixels):
+(ImageDiff::PlatformImage::writeAsPNGToStdout):
+* ImageDiff/gtk/ImageDiff.cpp: Removed.
+
+2017-04-10 Carlos Garcia Campos
+
REGRESSION(r214426): [GTK] Test media/video-click-dblckick-standalone.html started to fail in the bots after r214426
https://bugs.webkit.org/show_bug.cgi?id=170667
Modified: trunk/Tools/ImageDiff/CMakeLists.txt (215178 => 215179)
--- trunk/Tools/ImageDiff/CMakeLists.txt 2017-04-10 11:44:21 UTC (rev 215178)
+++ trunk/Tools/ImageDiff/CMakeLists.txt 2017-04-10 11:48:22 UTC (rev 215179)
@@ -2,6 +2,15 @@
set(IMAGE_DIFF_SYSTEM_INCLUDE_DIRECTORIES "")
+set(IMAGE_DIFF_SOURCES
+${IMAGE_DIFF_DIR}/ImageDiff.cpp
+${IMAGE_DIFF_DIR}/PlatformImage.cpp
+)
+
+list(APPEND IMAGE_DIFF_INCLUDE_DIRECTORIES
+${IMAGE_DIFF_DIR}
+)
+
set(IMAGE_DIFF_LIBRARIES
WTF
)
Added: trunk/Tools/ImageDiff/Cairo.cmake (0 => 215179)
--- trunk/Tools/ImageDiff/Cairo.cmake (rev 0)
+++ trunk/Tools/ImageDiff/Cairo.cmake 2017-04-10 11:48:22 UTC (rev 215179)
@@ -0,0 +1,11 @@
[webkit-changes] [215180] trunk/Source/WTF
Title: [215180] trunk/Source/WTF Revision 215180 Author be...@igalia.com Date 2017-04-10 05:55:07 -0700 (Mon, 10 Apr 2017) Log Message [GTK] Fix x32 build https://bugs.webkit.org/show_bug.cgi?id=170673 Patch by Thorsten Glaser on 2017-04-10 Reviewed by Carlos Alberto Lopez Perez. * wtf/Platform.h: Modified Paths trunk/Source/WTF/ChangeLog trunk/Source/WTF/wtf/Platform.h Diff Modified: trunk/Source/WTF/ChangeLog (215179 => 215180) --- trunk/Source/WTF/ChangeLog 2017-04-10 11:48:22 UTC (rev 215179) +++ trunk/Source/WTF/ChangeLog 2017-04-10 12:55:07 UTC (rev 215180) @@ -1,3 +1,12 @@ +2017-04-10 Thorsten Glaser + +[GTK] Fix x32 build +https://bugs.webkit.org/show_bug.cgi?id=170673 + +Reviewed by Carlos Alberto Lopez Perez. + +* wtf/Platform.h: + 2017-04-09 Yusuke Suzuki [WTF] Annotate Seconds' member functions and operators with constexpr Modified: trunk/Source/WTF/wtf/Platform.h (215179 => 215180) --- trunk/Source/WTF/wtf/Platform.h 2017-04-10 11:48:22 UTC (rev 215179) +++ trunk/Source/WTF/wtf/Platform.h 2017-04-10 12:55:07 UTC (rev 215180) @@ -673,7 +673,7 @@ #endif #if !defined(USE_JSVALUE64) && !defined(USE_JSVALUE32_64) -#if (CPU(X86_64) && (OS(UNIX) || OS(WINDOWS))) \ +#if (CPU(X86_64) && !defined(__ILP32__) && (OS(UNIX) || OS(WINDOWS))) \ || (CPU(IA64) && !CPU(IA64_32)) \ || CPU(ALPHA) \ || CPU(ARM64) \ ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [215181] trunk
Title: [215181] trunk Revision 215181 Author akl...@apple.com Date 2017-04-10 06:49:18 -0700 (Mon, 10 Apr 2017) Log Message Don't generate extra scrolling tiles for non-visible pages. https://bugs.webkit.org/show_bug.cgi?id=167213 Reviewed by Antti Koivisto. Source/WebCore: Reduce the tiling coverage to a minimum when the page is non-visible. On macOS, this means that fully occluded web views can maintain a smaller set of tiles in non-volatile surfaces, reducing net footprint. Test: compositing/tiling/non-visible-window-tile-coverage.html * rendering/RenderLayerBacking.cpp: (WebCore::computePageTiledBackingCoverage): If the page's activity state is non-visible, use minimal tile coverage. * platform/ScrollView.h: * page/FrameView.h: * page/FrameView.cpp: (WebCore::FrameView::hide): Call adjustTiledBackingCoverage() in hide() since it now takes page visibility into account. (WebCore::FrameView::enableSpeculativeTilingIfNeeded): * testing/Internals.cpp: (WebCore::Internals::setSpeculativeTilingDelayDisabledForTesting): * testing/Internals.h: * testing/Internals.idl: Add an internals API for disabling the 500ms delay before speculative tiling begins after the main frame load finishes. This is needed for reliably testing this change. LayoutTests: * TestExpectations: * compositing/tiling/non-visible-window-tile-coverage-expected.txt: Added. * compositing/tiling/non-visible-window-tile-coverage.html: Added. * platform/mac-wk2/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/TestExpectations trunk/LayoutTests/platform/mac-wk2/TestExpectations trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/page/FrameView.cpp trunk/Source/WebCore/page/FrameView.h trunk/Source/WebCore/platform/ScrollView.h trunk/Source/WebCore/rendering/RenderLayerBacking.cpp trunk/Source/WebCore/testing/Internals.cpp trunk/Source/WebCore/testing/Internals.h trunk/Source/WebCore/testing/Internals.idl Added Paths trunk/LayoutTests/compositing/tiling/non-visible-window-tile-coverage-expected.txt trunk/LayoutTests/compositing/tiling/non-visible-window-tile-coverage.html Diff Modified: trunk/LayoutTests/ChangeLog (215180 => 215181) --- trunk/LayoutTests/ChangeLog 2017-04-10 12:55:07 UTC (rev 215180) +++ trunk/LayoutTests/ChangeLog 2017-04-10 13:49:18 UTC (rev 215181) @@ -1,3 +1,16 @@ +2017-04-10 Andreas Kling + +Don't generate extra scrolling tiles for non-visible pages. +https://bugs.webkit.org/show_bug.cgi?id=167213 + + +Reviewed by Antti Koivisto. + +* TestExpectations: +* compositing/tiling/non-visible-window-tile-coverage-expected.txt: Added. +* compositing/tiling/non-visible-window-tile-coverage.html: Added. +* platform/mac-wk2/TestExpectations: + 2017-04-10 Carlos Garcia Campos REGRESSION(r214426): [GTK] Test media/video-click-dblckick-standalone.html started to fail in the bots after r214426 Modified: trunk/LayoutTests/TestExpectations (215180 => 215181) --- trunk/LayoutTests/TestExpectations 2017-04-10 12:55:07 UTC (rev 215180) +++ trunk/LayoutTests/TestExpectations 2017-04-10 13:49:18 UTC (rev 215181) @@ -1247,3 +1247,6 @@ webkit.org/b/170355 [ Release ] fast/mediastream/MediaStream-page-muted.html [ Pass Timeout ] webkit.org/b/170355 [ Debug ] fast/mediastream/MediaStream-page-muted.html [ Pass Crash ] + +# Only relevant on Mac-WK2 +compositing/tiling/non-visible-window-tile-coverage.html [ Skip ] Added: trunk/LayoutTests/compositing/tiling/non-visible-window-tile-coverage-expected.txt (0 => 215181) --- trunk/LayoutTests/compositing/tiling/non-visible-window-tile-coverage-expected.txt (rev 0) +++ trunk/LayoutTests/compositing/tiling/non-visible-window-tile-coverage-expected.txt 2017-04-10 13:49:18 UTC (rev 215181) @@ -0,0 +1,49 @@ +Tiles when window is visible: + +(GraphicsLayer + (anchor 0.00 0.00) + (bounds 3008.00 3092.00) + (visible rect 0.00, 0.00 785.00 x 585.00) + (coverage rect 0.00, 0.00 785.00 x 585.00) + (intersects coverage rect 1) + (contentsScale 1.00) + (children 1 +(GraphicsLayer + (bounds 3008.00 3092.00) + (contentsOpaque 1) + (visible rect 0.00, 0.00 785.00 x 585.00) + (coverage rect 0.00, 0.00 1570.00 x 1755.00) + (intersects coverage rect 1) + (contentsScale 1.00) + (tile cache coverage 0, 0 2048 x 2048) + (tile size 512 x 512) + (top left tile 0, 0 tiles grid 4 x 4) + (in window 1) +) + ) +) +Tiles when window is not visible: + +(GraphicsLayer + (anchor 0.00 0.00) + (bounds 3008.00 3438.00) + (visible rect 0.00, 0.00 785.00 x 585.00) + (coverage rect 0.00, 0.00 785.00 x 585.00) + (intersects coverage rect 1) + (contentsScale 1.00) + (children 1 +(GraphicsLayer + (bounds 3008.00 3438.00) + (contentsOpaque 1) + (visible rect 0.00, 0.00 785.00 x 585.00) + (coverage rect 0.00, 0.00 785.00 x 585.00) + (intersects coverage rect 1) + (contentsSca
[webkit-changes] [215182] trunk/Source
Title: [215182] trunk/Source
Revision 215182
Author jon...@apple.com
Date 2017-04-10 09:05:16 -0700 (Mon, 10 Apr 2017)
Log Message
Update localizable strings to "full screen" from "fullscreen"
https://bugs.webkit.org/show_bug.cgi?id=170675
rdar://problem/28207034
Reviewed by Antoine Quint.
Source/WebCore:
For localizable strings, it should consistently be "full screen" instead of "fullscreen".
* English.lproj/Localizable.strings:
* English.lproj/modern-media-controls-localized-strings.js:
* platform/LocalizedStrings.cpp:
(WebCore::contextMenuItemTagExitVideoFullscreen):
(WebCore::localizedMediaControlElementString):
* platform/cocoa/LocalizedStringsCocoa.mm:
(WebCore::exitFullScreenButtonAccessibilityTitle):
Source/WebInspectorUI:
* UserInterface/Models/ScriptTimelineRecord.js:
(WebInspector.ScriptTimelineRecord.EventType.displayName): For localizable strings, it should consistently be
"full screen" instead of "fullscreen".
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/English.lproj/Localizable.strings
trunk/Source/WebCore/English.lproj/modern-media-controls-localized-strings.js
trunk/Source/WebCore/platform/LocalizedStrings.cpp
trunk/Source/WebCore/platform/cocoa/LocalizedStringsCocoa.mm
trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/Models/ScriptTimelineRecord.js
Diff
Modified: trunk/Source/WebCore/ChangeLog (215181 => 215182)
--- trunk/Source/WebCore/ChangeLog 2017-04-10 13:49:18 UTC (rev 215181)
+++ trunk/Source/WebCore/ChangeLog 2017-04-10 16:05:16 UTC (rev 215182)
@@ -1,3 +1,21 @@
+2017-04-10 Jon Lee
+
+Update localizable strings to "full screen" from "fullscreen"
+https://bugs.webkit.org/show_bug.cgi?id=170675
+rdar://problem/28207034
+
+Reviewed by Antoine Quint.
+
+For localizable strings, it should consistently be "full screen" instead of "fullscreen".
+
+* English.lproj/Localizable.strings:
+* English.lproj/modern-media-controls-localized-strings.js:
+* platform/LocalizedStrings.cpp:
+(WebCore::contextMenuItemTagExitVideoFullscreen):
+(WebCore::localizedMediaControlElementString):
+* platform/cocoa/LocalizedStringsCocoa.mm:
+(WebCore::exitFullScreenButtonAccessibilityTitle):
+
2017-04-10 Andreas Kling
Don't generate extra scrolling tiles for non-visible pages.
Modified: trunk/Source/WebCore/English.lproj/Localizable.strings (215181 => 215182)
--- trunk/Source/WebCore/English.lproj/Localizable.strings 2017-04-10 13:49:18 UTC (rev 215181)
+++ trunk/Source/WebCore/English.lproj/Localizable.strings 2017-04-10 16:05:16 UTC (rev 215182)
@@ -247,11 +247,11 @@
/* Validation message for input form controls of type 'email' that have an invalid value */
"Enter an email address" = "Enter an email address";
-/* Video Exit Fullscreen context menu item */
+/* Button for exiting full screen when in full screen media playback */
"Exit Full Screen" = "Exit Full Screen";
-/* Button for exiting fullscreen when in fullscreen media playback */
-"Exit Fullscreen" = "Exit Fullscreen";
+/* Video Exit Fullscreen context menu item */
+"Exit Full Screen (context menu)" = "Exit Full Screen";
/* menu item */
"Exit Picture in Picture" = "Exit Picture in Picture";
@@ -883,11 +883,11 @@
/* accessibility role description for an email field. */
"email field" = "email field";
-/* accessibility label for enter fullscreen button */
-"enter fullscreen" = "enter fullscreen";
+/* accessibility label for enter full screen button */
+"enter full screen" = "enter full screen";
-/* accessibility label for exit fullscreen button */
-"exit fullscreen" = "exit fullscreen";
+/* accessibility label for exit full screen button */
+"exit full screen" = "exit full screen";
/* HTTP result code string */
"expectation failed" = "expectation failed";
Modified: trunk/Source/WebCore/English.lproj/modern-media-controls-localized-strings.js (215181 => 215182)
--- trunk/Source/WebCore/English.lproj/modern-media-controls-localized-strings.js 2017-04-10 13:49:18 UTC (rev 215181)
+++ trunk/Source/WebCore/English.lproj/modern-media-controls-localized-strings.js 2017-04-10 16:05:16 UTC (rev 215182)
@@ -1,7 +1,7 @@
const UIStrings = {
"AirPlay": "AirPlay",
"Audio": "Audio",
-"Enter Fullscreen": "Enter Fullscreen",
+"Enter Full Screen": "Enter Full Screen",
"Enter Picture in Picture": "Enter Picture in Picture",
"Exit Full Screen": "Exit Full Screen",
"Error": "Error",
Modified: trunk/Source/WebCore/platform/LocalizedStrings.cpp (215181 => 215182)
--- trunk/Source/WebCore/platform/LocalizedStrings.cpp 2017-04-10 13:49:18 UTC (rev 215181)
+++ trunk/Source/WebCore/platform/LocalizedStrings.cpp 2017-04-10 16:05:16 UTC (rev 215182)
@@ -388,7 +388,7 @@
String contextMenuItemTagExitVideoFullscreen()
{
-return WEB_UI_STRING("Exit Full Screen", "Video Exit Fullscreen context menu item");
+return WEB_UI_STRIN
[webkit-changes] [215183] trunk/LayoutTests
Title: [215183] trunk/LayoutTests
Revision 215183
Author ryanhad...@apple.com
Date 2017-04-10 09:44:01 -0700 (Mon, 10 Apr 2017)
Log Message
Rebaseline js/dom/global-constructors-attributes.html after r215131.
Unreviewed test gardening.
* platform/mac-elcapitan/js/dom/global-constructors-attributes-expected.txt:
* platform/mac-wk1/js/dom/global-constructors-attributes-expected.txt:
* platform/mac/js/dom/global-constructors-attributes-expected.txt:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac/js/dom/global-constructors-attributes-expected.txt
trunk/LayoutTests/platform/mac-elcapitan/js/dom/global-constructors-attributes-expected.txt
trunk/LayoutTests/platform/mac-wk1/js/dom/global-constructors-attributes-expected.txt
Diff
Modified: trunk/LayoutTests/ChangeLog (215182 => 215183)
--- trunk/LayoutTests/ChangeLog 2017-04-10 16:05:16 UTC (rev 215182)
+++ trunk/LayoutTests/ChangeLog 2017-04-10 16:44:01 UTC (rev 215183)
@@ -1,3 +1,13 @@
+2017-04-10 Ryan Haddad
+
+Rebaseline js/dom/global-constructors-attributes.html after r215131.
+
+Unreviewed test gardening.
+
+* platform/mac-elcapitan/js/dom/global-constructors-attributes-expected.txt:
+* platform/mac-wk1/js/dom/global-constructors-attributes-expected.txt:
+* platform/mac/js/dom/global-constructors-attributes-expected.txt:
+
2017-04-10 Andreas Kling
Don't generate extra scrolling tiles for non-visible pages.
Modified: trunk/LayoutTests/platform/mac/js/dom/global-constructors-attributes-expected.txt (215182 => 215183)
--- trunk/LayoutTests/platform/mac/js/dom/global-constructors-attributes-expected.txt 2017-04-10 16:05:16 UTC (rev 215182)
+++ trunk/LayoutTests/platform/mac/js/dom/global-constructors-attributes-expected.txt 2017-04-10 16:44:01 UTC (rev 215183)
@@ -2443,6 +2443,16 @@
PASS Object.getOwnPropertyDescriptor(global, 'WebGPUCommandQueue').hasOwnProperty('set') is false
PASS Object.getOwnPropertyDescriptor(global, 'WebGPUCommandQueue').enumerable is false
PASS Object.getOwnPropertyDescriptor(global, 'WebGPUCommandQueue').configurable is true
+PASS Object.getOwnPropertyDescriptor(global, 'WebGPUComputeCommandEncoder').value is WebGPUComputeCommandEncoder
+PASS Object.getOwnPropertyDescriptor(global, 'WebGPUComputeCommandEncoder').hasOwnProperty('get') is false
+PASS Object.getOwnPropertyDescriptor(global, 'WebGPUComputeCommandEncoder').hasOwnProperty('set') is false
+PASS Object.getOwnPropertyDescriptor(global, 'WebGPUComputeCommandEncoder').enumerable is false
+PASS Object.getOwnPropertyDescriptor(global, 'WebGPUComputeCommandEncoder').configurable is true
+PASS Object.getOwnPropertyDescriptor(global, 'WebGPUComputePipelineState').value is WebGPUComputePipelineState
+PASS Object.getOwnPropertyDescriptor(global, 'WebGPUComputePipelineState').hasOwnProperty('get') is false
+PASS Object.getOwnPropertyDescriptor(global, 'WebGPUComputePipelineState').hasOwnProperty('set') is false
+PASS Object.getOwnPropertyDescriptor(global, 'WebGPUComputePipelineState').enumerable is false
+PASS Object.getOwnPropertyDescriptor(global, 'WebGPUComputePipelineState').configurable is true
PASS Object.getOwnPropertyDescriptor(global, 'WebGPUDepthStencilDescriptor').value is WebGPUDepthStencilDescriptor
PASS Object.getOwnPropertyDescriptor(global, 'WebGPUDepthStencilDescriptor').hasOwnProperty('get') is false
PASS Object.getOwnPropertyDescriptor(global, 'WebGPUDepthStencilDescriptor').hasOwnProperty('set') is false
Modified: trunk/LayoutTests/platform/mac-elcapitan/js/dom/global-constructors-attributes-expected.txt (215182 => 215183)
--- trunk/LayoutTests/platform/mac-elcapitan/js/dom/global-constructors-attributes-expected.txt 2017-04-10 16:05:16 UTC (rev 215182)
+++ trunk/LayoutTests/platform/mac-elcapitan/js/dom/global-constructors-attributes-expected.txt 2017-04-10 16:44:01 UTC (rev 215183)
@@ -2433,6 +2433,16 @@
PASS Object.getOwnPropertyDescriptor(global, 'WebGPUCommandQueue').hasOwnProperty('set') is false
PASS Object.getOwnPropertyDescriptor(global, 'WebGPUCommandQueue').enumerable is false
PASS Object.getOwnPropertyDescriptor(global, 'WebGPUCommandQueue').configurable is true
+PASS Object.getOwnPropertyDescriptor(global, 'WebGPUComputeCommandEncoder').value is WebGPUComputeCommandEncoder
+PASS Object.getOwnPropertyDescriptor(global, 'WebGPUComputeCommandEncoder').hasOwnProperty('get') is false
+PASS Object.getOwnPropertyDescriptor(global, 'WebGPUComputeCommandEncoder').hasOwnProperty('set') is false
+PASS Object.getOwnPropertyDescriptor(global, 'WebGPUComputeCommandEncoder').enumerable is false
+PASS Object.getOwnPropertyDescriptor(global, 'WebGPUComputeCommandEncoder').configurable is true
+PASS Object.getOwnPropertyDescriptor(global, 'WebGPUComputePipelineState').value is WebGPUComputePipelineState
+PASS Object.getOwnPropertyDescriptor(global, 'WebGPUComputePipelineState').hasOwnProperty('get') is false
+PASS Object.getOwnPropertyDescriptor(global, '
[webkit-changes] [215184] trunk
Title: [215184] trunk
Revision 215184
Author wenson_hs...@apple.com
Date 2017-04-10 10:07:44 -0700 (Mon, 10 Apr 2017)
Log Message
Data interaction on an image enclosed by an anchor should vend the anchor's URL
https://bugs.webkit.org/show_bug.cgi?id=170660
Reviewed by Tim Horton.
Source/WebCore:
When writing an image embedded inside an anchor to the pasteboard, actually use the enclosing anchor's href if
it exists. Previously, we were simply dropping this argument on the floor.
Covered by 2 new DataInteractionTests: ImageInLinkToInput and ImageInLinkWithoutHREFToInput.
* editing/ios/EditorIOS.mm:
(WebCore::Editor::writeImageToPasteboard):
Tools:
Adds two new unit tests covering cases where data interaction is triggered from an image nested underneath an
anchor. In one of the tests, the link has an href, and in the other, its href is missing, in which case we
should fall back to the image URL instead. Also fixes a related unit test that was trying to check selection
rects, but should not be.
See WebCore ChangeLog for more details.
* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
* TestWebKitAPI/Tests/WebKit2Cocoa/image-in-link-and-input.html: Added.
* TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
(TestWebKitAPI::TEST):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/editing/ios/EditorIOS.mm
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj
trunk/Tools/TestWebKitAPI/Tests/ios/DataInteractionTests.mm
Added Paths
trunk/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/image-in-link-and-input.html
Diff
Modified: trunk/Source/WebCore/ChangeLog (215183 => 215184)
--- trunk/Source/WebCore/ChangeLog 2017-04-10 16:44:01 UTC (rev 215183)
+++ trunk/Source/WebCore/ChangeLog 2017-04-10 17:07:44 UTC (rev 215184)
@@ -1,3 +1,19 @@
+2017-04-10 Wenson Hsieh
+
+Data interaction on an image enclosed by an anchor should vend the anchor's URL
+https://bugs.webkit.org/show_bug.cgi?id=170660
+
+
+Reviewed by Tim Horton.
+
+When writing an image embedded inside an anchor to the pasteboard, actually use the enclosing anchor's href if
+it exists. Previously, we were simply dropping this argument on the floor.
+
+Covered by 2 new DataInteractionTests: ImageInLinkToInput and ImageInLinkWithoutHREFToInput.
+
+* editing/ios/EditorIOS.mm:
+(WebCore::Editor::writeImageToPasteboard):
+
2017-04-10 Jon Lee
Update localizable strings to "full screen" from "fullscreen"
Modified: trunk/Source/WebCore/editing/ios/EditorIOS.mm (215183 => 215184)
--- trunk/Source/WebCore/editing/ios/EditorIOS.mm 2017-04-10 16:44:01 UTC (rev 215183)
+++ trunk/Source/WebCore/editing/ios/EditorIOS.mm 2017-04-10 17:07:44 UTC (rev 215184)
@@ -197,7 +197,7 @@
cachedImage = tentativeCachedImage;
}
-void Editor::writeImageToPasteboard(Pasteboard& pasteboard, Element& imageElement, const URL&, const String& title)
+void Editor::writeImageToPasteboard(Pasteboard& pasteboard, Element& imageElement, const URL& url, const String& title)
{
PasteboardImage pasteboardImage;
@@ -207,7 +207,7 @@
return;
ASSERT(cachedImage);
-pasteboardImage.url.url = ""
+pasteboardImage.url.url = "" ? imageElement.document().completeURL(stripLeadingAndTrailingHTMLSpaces(imageElement.imageSourceURL())) : url;
pasteboardImage.url.title = title;
pasteboardImage.resourceMIMEType = pasteboard.resourceMIMEType(cachedImage->response().mimeType());
pasteboardImage.resourceData = cachedImage->resourceBuffer();
Modified: trunk/Tools/ChangeLog (215183 => 215184)
--- trunk/Tools/ChangeLog 2017-04-10 16:44:01 UTC (rev 215183)
+++ trunk/Tools/ChangeLog 2017-04-10 17:07:44 UTC (rev 215184)
@@ -1,3 +1,23 @@
+2017-04-10 Wenson Hsieh
+
+Data interaction on an image enclosed by an anchor should vend the anchor's URL
+https://bugs.webkit.org/show_bug.cgi?id=170660
+
+
+Reviewed by Tim Horton.
+
+Adds two new unit tests covering cases where data interaction is triggered from an image nested underneath an
+anchor. In one of the tests, the link has an href, and in the other, its href is missing, in which case we
+should fall back to the image URL instead. Also fixes a related unit test that was trying to check selection
+rects, but should not be.
+
+See WebCore ChangeLog for more details.
+
+* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
+* TestWebKitAPI/Tests/WebKit2Cocoa/image-in-link-and-input.html: Added.
+* TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
+(TestWebKitAPI::TEST):
+
2017-04-10 Carlos Garcia Campos
[GTK] Remove the GDK dependency from ImageDiff
Modified: trunk/Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj (215183 => 215184)
--- trunk/Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj 2017-04-10 16:44:01 UTC (rev 2
[webkit-changes] [215185] trunk/Source/WebCore
Title: [215185] trunk/Source/WebCore
Revision 215185
Author ryanhad...@apple.com
Date 2017-04-10 10:28:02 -0700 (Mon, 10 Apr 2017)
Log Message
Unreviewed, rolling out r215175.
This change caused a flaky crash in existing media tests.
Reverted changeset:
"Add fallback fonts to video captions stylesheet."
https://bugs.webkit.org/show_bug.cgi?id=170495
http://trac.webkit.org/changeset/215175
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/CaptionUserPreferencesMediaAF.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (215184 => 215185)
--- trunk/Source/WebCore/ChangeLog 2017-04-10 17:07:44 UTC (rev 215184)
+++ trunk/Source/WebCore/ChangeLog 2017-04-10 17:28:02 UTC (rev 215185)
@@ -1,3 +1,15 @@
+2017-04-10 Ryan Haddad
+
+Unreviewed, rolling out r215175.
+
+This change caused a flaky crash in existing media tests.
+
+Reverted changeset:
+
+"Add fallback fonts to video captions stylesheet."
+https://bugs.webkit.org/show_bug.cgi?id=170495
+http://trac.webkit.org/changeset/215175
+
2017-04-10 Wenson Hsieh
Data interaction on an image enclosed by an anchor should vend the anchor's URL
Modified: trunk/Source/WebCore/page/CaptionUserPreferencesMediaAF.cpp (215184 => 215185)
--- trunk/Source/WebCore/page/CaptionUserPreferencesMediaAF.cpp 2017-04-10 17:07:44 UTC (rev 215184)
+++ trunk/Source/WebCore/page/CaptionUserPreferencesMediaAF.cpp 2017-04-10 17:28:02 UTC (rev 215185)
@@ -83,8 +83,6 @@
SOFT_LINK_AVF_FRAMEWORK_IMPORT(CoreText, CTFontDescriptorCopyAttribute, CFTypeRef, (CTFontDescriptorRef descriptor, CFStringRef attribute), (descriptor, attribute));
SOFT_LINK_AVF_POINTER(CoreText, kCTFontNameAttribute, CFStringRef)
#define kCTFontNameAttribute getkCTFontNameAttribute()
-SOFT_LINK_AVF_POINTER(CoreText, kCTFontCascadeListAttribute, CFStringRef)
-#define kCTFontCascadeListAttribute getkCTFontCascadeListAttribute()
#define CTFontDescriptorCopyAttribute softLink_CTFontDescriptorCopyAttribute
@@ -426,7 +424,7 @@
RetainPtr name = adoptCF(CTFontDescriptorCopyAttribute(font.get(), kCTFontNameAttribute));
if (!name)
return emptyString();
-
+
StringBuilder builder;
builder.append(getPropertyNameString(CSSPropertyFontFamily));
@@ -433,17 +431,6 @@
builder.appendLiteral(": \"");
builder.append(static_cast(name.get()));
builder.append('"');
-
-auto cascadeList = adoptCF(static_cast(CTFontDescriptorCopyAttribute(font.get(), kCTFontCascadeListAttribute)));
-
-for (CFIndex i = 0; i < CFArrayGetCount(cascadeList.get()); i++) {
-auto fontCascade = static_cast(CFArrayGetValueAtIndex(cascadeList.get(), i));
-auto fontCascadeName = adoptCF(CTFontDescriptorCopyAttribute(fontCascade, kCTFontNameAttribute));
-builder.append(", \"");
-builder.append(static_cast(fontCascadeName.get()));
-builder.append('"');
-}
-
if (behavior == kMACaptionAppearanceBehaviorUseValue)
builder.appendLiteral(" !important");
builder.append(';');
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [215186] trunk/Tools
Title: [215186] trunk/Tools
Revision 215186
Author commit-qu...@webkit.org
Date 2017-04-10 10:35:20 -0700 (Mon, 10 Apr 2017)
Log Message
update-webkit-dependency should report $response->message for diagnose
https://bugs.webkit.org/show_bug.cgi?id=170666
Patch by Fujii Hironori on 2017-04-10
Reviewed by Alex Christensen.
* Scripts/update-webkit-dependency: Print $response->message to STDERR if an error happens.
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/update-webkit-dependency
Diff
Modified: trunk/Tools/ChangeLog (215185 => 215186)
--- trunk/Tools/ChangeLog 2017-04-10 17:28:02 UTC (rev 215185)
+++ trunk/Tools/ChangeLog 2017-04-10 17:35:20 UTC (rev 215186)
@@ -1,3 +1,12 @@
+2017-04-10 Fujii Hironori
+
+update-webkit-dependency should report $response->message for diagnose
+https://bugs.webkit.org/show_bug.cgi?id=170666
+
+Reviewed by Alex Christensen.
+
+* Scripts/update-webkit-dependency: Print $response->message to STDERR if an error happens.
+
2017-04-10 Wenson Hsieh
Data interaction on an image enclosed by an anchor should vend the anchor's URL
Modified: trunk/Tools/Scripts/update-webkit-dependency (215185 => 215186)
--- trunk/Tools/Scripts/update-webkit-dependency 2017-04-10 17:28:02 UTC (rev 215185)
+++ trunk/Tools/Scripts/update-webkit-dependency 2017-04-10 17:35:20 UTC (rev 215186)
@@ -99,7 +99,9 @@
$ua->max_size(undef);
if (! $response->is_success) {
-print STDERR "Could not access $libsURL:\n", $response->headers_as_string, "\n";
+print STDERR "Could not access $libsURL:\n";
+print STDERR $response->message, "\n";
+print STDERR $response->headers_as_string, "\n";
print STDERR "Please ensure that $libsURL is reachable";
if ($libsURL =~ /^https/i) {
print STDERR " and that Perl can use LWP::Simple to connect to HTTPS URLs.\n";
@@ -165,7 +167,9 @@
$response = $ua->get($headerURL);
if (! $response->is_success) {
-print STDERR "Could not access $headerURL:\n", $response->headers_as_string, "\n";
+print STDERR "Could not access $headerURL:\n";
+print STDERR $response->message, "\n";
+print STDERR $response->headers_as_string, "\n";
print STDERR "Please ensure that $headerURL is reachable";
if ($headerURL =~ /^https/i) {
print STDERR " and that Perl can use LWP::Simple to connect to HTTPS URLs.\n";
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [215187] trunk/LayoutTests
Title: [215187] trunk/LayoutTests Revision 215187 Author ryanhad...@apple.com Date 2017-04-10 10:54:49 -0700 (Mon, 10 Apr 2017) Log Message Mark media/modern-media-controls/volume-up-support/volume-up-support.html as flaky. https://bugs.webkit.org/show_bug.cgi?id=170682 Unreviewed test gardening. * platform/mac-wk1/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/mac-wk1/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (215186 => 215187) --- trunk/LayoutTests/ChangeLog 2017-04-10 17:35:20 UTC (rev 215186) +++ trunk/LayoutTests/ChangeLog 2017-04-10 17:54:49 UTC (rev 215187) @@ -1,5 +1,14 @@ 2017-04-10 Ryan Haddad +Mark media/modern-media-controls/volume-up-support/volume-up-support.html as flaky. +https://bugs.webkit.org/show_bug.cgi?id=170682 + +Unreviewed test gardening. + +* platform/mac-wk1/TestExpectations: + +2017-04-10 Ryan Haddad + Rebaseline js/dom/global-constructors-attributes.html after r215131. Unreviewed test gardening. Modified: trunk/LayoutTests/platform/mac-wk1/TestExpectations (215186 => 215187) --- trunk/LayoutTests/platform/mac-wk1/TestExpectations 2017-04-10 17:35:20 UTC (rev 215186) +++ trunk/LayoutTests/platform/mac-wk1/TestExpectations 2017-04-10 17:54:49 UTC (rev 215187) @@ -344,6 +344,7 @@ webkit.org/b/170456 media/modern-media-controls/macos-inline-media-controls/macos-inline-media-controls-buttons-styles.html [ Pass Timeout ] webkit.org/b/167752 media/modern-media-controls/icon-button/icon-button-active-state.html [ Pass Timeout ] webkit.org/b/167477 [ Debug ] media/modern-media-controls/play-pause-button/play-pause-button.html [ Pass Timeout ] +webkit.org/b/170682 [ Debug ] media/modern-media-controls/volume-up-support/volume-up-support.html [ Pass Timeout ] # There is not NetworkProcess in WK1, so it can't crash. http/tests/websocket/tests/hybi/network-process-crash-error.html [ Skip ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [215188] trunk/Source/WebKit2
Title: [215188] trunk/Source/WebKit2 Revision 215188 Author commit-qu...@webkit.org Date 2017-04-10 10:55:50 -0700 (Mon, 10 Apr 2017) Log Message [GTK] Opening a popup menu does not pre-select the active item https://bugs.webkit.org/show_bug.cgi?id=170680 Patch by Adrian Perez de Castro on 2017-04-10 Reviewed by Michael Catanzaro. * UIProcess/gtk/WebPopupMenuProxyGtk.cpp: (WebKit::WebPopupMenuProxyGtk::showPopupMenu): Use gtk_menu_shell_select_item() to ensure that the active item appears selected right after popping up the menu. Modified Paths trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/UIProcess/gtk/WebPopupMenuProxyGtk.cpp Diff Modified: trunk/Source/WebKit2/ChangeLog (215187 => 215188) --- trunk/Source/WebKit2/ChangeLog 2017-04-10 17:54:49 UTC (rev 215187) +++ trunk/Source/WebKit2/ChangeLog 2017-04-10 17:55:50 UTC (rev 215188) @@ -1,3 +1,14 @@ +2017-04-10 Adrian Perez de Castro + +[GTK] Opening a popup menu does not pre-select the active item +https://bugs.webkit.org/show_bug.cgi?id=170680 + +Reviewed by Michael Catanzaro. + +* UIProcess/gtk/WebPopupMenuProxyGtk.cpp: +(WebKit::WebPopupMenuProxyGtk::showPopupMenu): Use gtk_menu_shell_select_item() to +ensure that the active item appears selected right after popping up the menu. + 2017-04-10 Carlos Garcia Campos [GTK] Enable DOM timer throttling and CSS animations suspension Modified: trunk/Source/WebKit2/UIProcess/gtk/WebPopupMenuProxyGtk.cpp (215187 => 215188) --- trunk/Source/WebKit2/UIProcess/gtk/WebPopupMenuProxyGtk.cpp 2017-04-10 17:54:49 UTC (rev 215187) +++ trunk/Source/WebKit2/UIProcess/gtk/WebPopupMenuProxyGtk.cpp 2017-04-10 17:55:50 UTC (rev 215188) @@ -142,6 +142,12 @@ m_client->failedToShowPopupMenu(); return; } + +// This ensures that the active item gets selected after popping up the menu, and +// as it says in "gtkcombobox.c" (line ~1606): it's ugly, but gets the job done. +GtkWidget* activeChild = gtk_menu_get_active(GTK_MENU(m_popup)); +if (activeChild && gtk_widget_get_visible(activeChild)) +gtk_menu_shell_select_item(GTK_MENU_SHELL(m_popup), activeChild); } void WebPopupMenuProxyGtk::hidePopupMenu() ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [215189] trunk
Title: [215189] trunk Revision 215189 Author wenson_hs...@apple.com Date 2017-04-10 10:58:58 -0700 (Mon, 10 Apr 2017) Log Message REGRESSION (r214403): fast/events/drag-to-navigate.html and fast/events/only-valid-drop-targets-receive-file-drop.html failing https://bugs.webkit.org/show_bug.cgi?id=170677 Reviewed by Tim Horton. Tools: Fixes two drag and drop LayoutTests by introducing and enabling a TestOptions switch (enableDragDestinationActionLoad) to allow dropping URLs to trigger page navigation. * DumpRenderTree/TestOptions.h: * DumpRenderTree/TestOptions.mm: (TestOptions::TestOptions): * DumpRenderTree/mac/DumpRenderTree.mm: (resetWebViewToConsistentStateBeforeTesting): * DumpRenderTree/mac/UIDelegate.h: * DumpRenderTree/mac/UIDelegate.mm: (-[UIDelegate resetToConsistentStateBeforeTesting:]): (-[UIDelegate webView:dragDestinationActionMaskForDraggingInfo:]): LayoutTests: Turn enableDragDestinationActionLoad on in these two LayoutTests via WKTR options. * fast/events/drag-to-navigate.html: * fast/events/only-valid-drop-targets-receive-file-drop.html: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/fast/events/drag-to-navigate.html trunk/LayoutTests/fast/events/only-valid-drop-targets-receive-file-drop.html trunk/Tools/ChangeLog trunk/Tools/DumpRenderTree/TestOptions.h trunk/Tools/DumpRenderTree/TestOptions.mm trunk/Tools/DumpRenderTree/mac/DumpRenderTree.mm trunk/Tools/DumpRenderTree/mac/UIDelegate.h trunk/Tools/DumpRenderTree/mac/UIDelegate.mm Diff Modified: trunk/LayoutTests/ChangeLog (215188 => 215189) --- trunk/LayoutTests/ChangeLog 2017-04-10 17:55:50 UTC (rev 215188) +++ trunk/LayoutTests/ChangeLog 2017-04-10 17:58:58 UTC (rev 215189) @@ -1,3 +1,16 @@ +2017-04-10 Wenson Hsieh + +REGRESSION (r214403): fast/events/drag-to-navigate.html and fast/events/only-valid-drop-targets-receive-file-drop.html failing +https://bugs.webkit.org/show_bug.cgi?id=170677 + + +Reviewed by Tim Horton. + +Turn enableDragDestinationActionLoad on in these two LayoutTests via WKTR options. + +* fast/events/drag-to-navigate.html: +* fast/events/only-valid-drop-targets-receive-file-drop.html: + 2017-04-10 Ryan Haddad Mark media/modern-media-controls/volume-up-support/volume-up-support.html as flaky. Modified: trunk/LayoutTests/fast/events/drag-to-navigate.html (215188 => 215189) --- trunk/LayoutTests/fast/events/drag-to-navigate.html 2017-04-10 17:55:50 UTC (rev 215188) +++ trunk/LayoutTests/fast/events/drag-to-navigate.html 2017-04-10 17:58:58 UTC (rev 215189) @@ -1,3 +1,4 @@ + FAIL
[webkit-changes] [215190] trunk
Title: [215190] trunk
Revision 215190
Author commit-qu...@webkit.org
Date 2017-04-10 11:06:32 -0700 (Mon, 10 Apr 2017)
Log Message
[GTK] Misplaced right click menu on web page due to deprecated gtk_menu_popup()
https://bugs.webkit.org/show_bug.cgi?id=170553
Patch by Adrian Perez de Castro on 2017-04-10
Reviewed by Michael Catanzaro.
Source/WebKit2:
Use gtk_menu_popup_at_pointer() and gtk_menu_popup_at_rect() when building with GTK+ 3.22 or
newer. This allows the Wayland GTK+ backend to properly position popup menus, and also avoids
using functions which were deprecated starting at that GTK+ release.
* UIProcess/gtk/WebContextMenuProxyGtk.cpp:
(WebKit::WebContextMenuProxyGtk::show): Use gtk_menu_popup_at_pointer() as there is always a
pointer event that can be passed to it.
* UIProcess/gtk/WebPopupMenuProxyGtk.cpp:
(WebKit::WebPopupMenuProxyGtk::showPopupMenu): Use gtk_menu_popup_at_rect(), using the coordinates
of the control passed as reference rectangle. Some conditional code is needed because with newer
GTK+ versions a relative offset instead of an absolute position is needed.
Tools:
Use gtk_menu_popup_at_pointer() and gtk_menu_popup_at_rect() when
building with GTK+ 3.22 or newer. This allows the Wayland GTK+ backend
to properly position popup menus, and also avoids using functions
which were deprecated starting at that GTK+ release.
* MiniBrowser/gtk/BrowserSearchBar.c:
(searchEntryMenuIconPressedCallback):
Update MiniBrowser to use gtk_menu_popup_at_pointer().
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/gtk/WebContextMenuProxyGtk.cpp
trunk/Source/WebKit2/UIProcess/gtk/WebPopupMenuProxyGtk.cpp
trunk/Tools/ChangeLog
trunk/Tools/MiniBrowser/gtk/BrowserSearchBar.c
Diff
Modified: trunk/Source/WebKit2/ChangeLog (215189 => 215190)
--- trunk/Source/WebKit2/ChangeLog 2017-04-10 17:58:58 UTC (rev 215189)
+++ trunk/Source/WebKit2/ChangeLog 2017-04-10 18:06:32 UTC (rev 215190)
@@ -1,5 +1,24 @@
2017-04-10 Adrian Perez de Castro
+[GTK] Misplaced right click menu on web page due to deprecated gtk_menu_popup()
+https://bugs.webkit.org/show_bug.cgi?id=170553
+
+Reviewed by Michael Catanzaro.
+
+Use gtk_menu_popup_at_pointer() and gtk_menu_popup_at_rect() when building with GTK+ 3.22 or
+newer. This allows the Wayland GTK+ backend to properly position popup menus, and also avoids
+using functions which were deprecated starting at that GTK+ release.
+
+* UIProcess/gtk/WebContextMenuProxyGtk.cpp:
+(WebKit::WebContextMenuProxyGtk::show): Use gtk_menu_popup_at_pointer() as there is always a
+pointer event that can be passed to it.
+* UIProcess/gtk/WebPopupMenuProxyGtk.cpp:
+(WebKit::WebPopupMenuProxyGtk::showPopupMenu): Use gtk_menu_popup_at_rect(), using the coordinates
+of the control passed as reference rectangle. Some conditional code is needed because with newer
+GTK+ versions a relative offset instead of an absolute position is needed.
+
+2017-04-10 Adrian Perez de Castro
+
[GTK] Opening a popup menu does not pre-select the active item
https://bugs.webkit.org/show_bug.cgi?id=170680
Modified: trunk/Source/WebKit2/UIProcess/gtk/WebContextMenuProxyGtk.cpp (215189 => 215190)
--- trunk/Source/WebKit2/UIProcess/gtk/WebContextMenuProxyGtk.cpp 2017-04-10 17:58:58 UTC (rev 215189)
+++ trunk/Source/WebKit2/UIProcess/gtk/WebContextMenuProxyGtk.cpp 2017-04-10 18:06:32 UTC (rev 215190)
@@ -167,8 +167,13 @@
NativeWebMouseEvent* mouseEvent = m_page->currentlyProcessedMouseDownEvent();
const GdkEvent* event = mouseEvent ? mouseEvent->nativeEvent() : 0;
gtk_menu_attach_to_widget(m_menu, GTK_WIDGET(m_webView), nullptr);
+
+#if GTK_CHECK_VERSION(3, 22, 0)
+gtk_menu_popup_at_pointer(m_menu, event);
+#else
gtk_menu_popup(m_menu, nullptr, nullptr, reinterpret_cast(menuPositionFunction), this,
event ? event->button.button : 3, event ? event->button.time : GDK_CURRENT_TIME);
+#endif
}
void WebContextMenuProxyGtk::showContextMenuWithItems(const Vector& items)
@@ -204,6 +209,7 @@
gtk_widget_destroy(GTK_WIDGET(m_menu));
}
+#if !GTK_CHECK_VERSION(3, 22, 0)
void WebContextMenuProxyGtk::menuPositionFunction(GtkMenu* menu, gint* x, gint* y, gboolean* pushIn, WebContextMenuProxyGtk* popupMenu)
{
GtkRequisition menuSize;
@@ -220,6 +226,7 @@
*pushIn = FALSE;
}
+#endif
} // namespace WebKit
#endif // ENABLE(CONTEXT_MENUS)
Modified: trunk/Source/WebKit2/UIProcess/gtk/WebPopupMenuProxyGtk.cpp (215189 => 215190)
--- trunk/Source/WebKit2/UIProcess/gtk/WebPopupMenuProxyGtk.cpp 2017-04-10 17:58:58 UTC (rev 215189)
+++ trunk/Source/WebKit2/UIProcess/gtk/WebPopupMenuProxyGtk.cpp 2017-04-10 18:06:32 UTC (rev 215190)
@@ -95,9 +95,6 @@
resetTypeAheadFindState();
-IntPoint menuPosition = convertWidgetPointToScreenPoint(m_webView, rect.location());
-menuPosition.move(0, rect.hei
[webkit-changes] [215192] trunk/Source/WebInspectorUI
Title: [215192] trunk/Source/WebInspectorUI
Revision 215192
Author nvasil...@apple.com
Date 2017-04-10 11:11:59 -0700 (Mon, 10 Apr 2017)
Log Message
Web Inspector: Placeholder text is clipped in the 'Enter Class Name' field at the bottom of Rules style sidebar in some localizations
https://bugs.webkit.org/show_bug.cgi?id=167641
Reviewed by Joseph Pecoraro.
Make the "Enter Class Name" text field span the entire width of the Styles sidebar.
* UserInterface/Views/CSSStyleDetailsSidebarPanel.css:
(.sidebar > .panel.details.css-style > .content ~ .class-list-container > .new-class):
(.sidebar > .panel.details.css-style > .content ~ .class-list-container > .new-class > .class-name-input):
(.sidebar > .panel.details.css-style > .content ~ .class-list-container > .new-class > input[type="checkbox"]): Deleted.
(.sidebar > .panel.details.css-style > .content ~ .class-list-container > .new-class > .add-class-icon): Deleted.
(.sidebar > .panel.details.css-style > .content ~ .class-list-container > .new-class.active > .add-class-icon,): Deleted.
* UserInterface/Views/CSSStyleDetailsSidebarPanel.js:
(WebInspector.CSSStyleDetailsSidebarPanel.prototype.initialLayout):
Remove the checkbox, which didn't do anything, and the plus icon. Make the "Enter Class Name" text field visible by default.
Modified Paths
trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/Views/CSSStyleDetailsSidebarPanel.css
trunk/Source/WebInspectorUI/UserInterface/Views/CSSStyleDetailsSidebarPanel.js
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (215191 => 215192)
--- trunk/Source/WebInspectorUI/ChangeLog 2017-04-10 18:11:55 UTC (rev 215191)
+++ trunk/Source/WebInspectorUI/ChangeLog 2017-04-10 18:11:59 UTC (rev 215192)
@@ -1,3 +1,23 @@
+2017-04-10 Nikita Vasilyev
+
+Web Inspector: Placeholder text is clipped in the 'Enter Class Name' field at the bottom of Rules style sidebar in some localizations
+https://bugs.webkit.org/show_bug.cgi?id=167641
+
+
+Reviewed by Joseph Pecoraro.
+
+Make the "Enter Class Name" text field span the entire width of the Styles sidebar.
+
+* UserInterface/Views/CSSStyleDetailsSidebarPanel.css:
+(.sidebar > .panel.details.css-style > .content ~ .class-list-container > .new-class):
+(.sidebar > .panel.details.css-style > .content ~ .class-list-container > .new-class > .class-name-input):
+(.sidebar > .panel.details.css-style > .content ~ .class-list-container > .new-class > input[type="checkbox"]): Deleted.
+(.sidebar > .panel.details.css-style > .content ~ .class-list-container > .new-class > .add-class-icon): Deleted.
+(.sidebar > .panel.details.css-style > .content ~ .class-list-container > .new-class.active > .add-class-icon,): Deleted.
+* UserInterface/Views/CSSStyleDetailsSidebarPanel.js:
+(WebInspector.CSSStyleDetailsSidebarPanel.prototype.initialLayout):
+Remove the checkbox, which didn't do anything, and the plus icon. Make the "Enter Class Name" text field visible by default.
+
2017-04-10 Jon Lee
Update localizable strings to "full screen" from "fullscreen"
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/CSSStyleDetailsSidebarPanel.css (215191 => 215192)
--- trunk/Source/WebInspectorUI/UserInterface/Views/CSSStyleDetailsSidebarPanel.css 2017-04-10 18:11:55 UTC (rev 215191)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/CSSStyleDetailsSidebarPanel.css 2017-04-10 18:11:59 UTC (rev 215192)
@@ -156,20 +156,11 @@
.sidebar > .panel.details.css-style > .content ~ .class-list-container > .new-class {
display: flex;
-align-items: center;
+width: 100%;
}
-.sidebar > .panel.details.css-style > .content ~ .class-list-container > .new-class > input[type="checkbox"] {
-pointer-events: none;
-}
-
-.sidebar > .panel.details.css-style > .content ~ .class-list-container > .new-class > .add-class-icon {
-width: 12px;
-height: 12px;
-}
-
.sidebar > .panel.details.css-style > .content ~ .class-list-container > .new-class > .class-name-input {
-width: 100px;
+flex-grow: 1;
height: 18px;
margin: 0;
@@ -184,11 +175,6 @@
margin-right: var(--panel-details-css-style-content-class-list-container-new-class-class-name-input-margin-start);
}
-.sidebar > .panel.details.css-style > .content ~ .class-list-container > .new-class.active > .add-class-icon,
-.sidebar > .panel.details.css-style > .content ~ .class-list-container > .new-class:not(.active) > .class-name-input {
-display: none;
-}
-
.sidebar > .panel.details.css-style > .content ~ .class-list-container > *:matches(.new-class, .class-toggle) {
margin: 1px 3px;
}
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/CSSStyleDetailsSidebarPanel.js (215191 => 215192)
--- trunk/Source/WebInspectorUI/UserInterface/Views/CSSStyleDetailsSidebarPanel.js 2017-04-10 18:11:55 UTC (rev 215191)
+++ trunk/Source/WebInspectorUI/U
[webkit-changes] [215191] trunk/Tools
Title: [215191] trunk/Tools
Revision 215191
Author jbed...@apple.com
Date 2017-04-10 11:11:55 -0700 (Mon, 10 Apr 2017)
Log Message
webkitpy: Increase estimate for processes run by iOS Simulators
https://bugs.webkit.org/show_bug.cgi?id=170678
Reviewed by Aakash Jain.
Previously, it was estimated that each simulated iOS device would run about 100
processes. With newer versions of iOS, this is closer to 125.
* Scripts/webkitpy/port/ios_simulator.py:
(IOSSimulatorPort): Increase process estimate from 100 to 125.
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/port/ios_simulator.py
Diff
Modified: trunk/Tools/ChangeLog (215190 => 215191)
--- trunk/Tools/ChangeLog 2017-04-10 18:06:32 UTC (rev 215190)
+++ trunk/Tools/ChangeLog 2017-04-10 18:11:55 UTC (rev 215191)
@@ -1,3 +1,17 @@
+2017-04-10 Jonathan Bedard
+
+webkitpy: Increase estimate for processes run by iOS Simulators
+https://bugs.webkit.org/show_bug.cgi?id=170678
+
+
+Reviewed by Aakash Jain.
+
+Previously, it was estimated that each simulated iOS device would run about 100
+processes. With newer versions of iOS, this is closer to 125.
+
+* Scripts/webkitpy/port/ios_simulator.py:
+(IOSSimulatorPort): Increase process estimate from 100 to 125.
+
2017-04-10 Adrian Perez de Castro
[GTK] Misplaced right click menu on web page due to deprecated gtk_menu_popup()
Modified: trunk/Tools/Scripts/webkitpy/port/ios_simulator.py (215190 => 215191)
--- trunk/Tools/Scripts/webkitpy/port/ios_simulator.py 2017-04-10 18:06:32 UTC (rev 215190)
+++ trunk/Tools/Scripts/webkitpy/port/ios_simulator.py 2017-04-10 18:11:55 UTC (rev 215191)
@@ -52,7 +52,7 @@
SIMULATOR_BUNDLE_ID = 'com.apple.iphonesimulator'
SIMULATOR_DIRECTORY = "/tmp/WebKitTestingSimulators/"
LSREGISTER_PATH = "/System/Library/Frameworks/CoreServices.framework/Frameworks/LaunchServices.framework/Versions/Current/Support/lsregister"
-PROCESS_COUNT_ESTIMATE_PER_SIMULATOR_INSTANCE = 100
+PROCESS_COUNT_ESTIMATE_PER_SIMULATOR_INSTANCE = 125
DEVICE_CLASS_MAP = {
'x86_64': {
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [215193] trunk/Source/JavaScriptCore
Title: [215193] trunk/Source/_javascript_Core
Revision 215193
Author keith_mil...@apple.com
Date 2017-04-10 11:31:22 -0700 (Mon, 10 Apr 2017)
Log Message
WebAssembly: Fix B3IRGenerator for BrTable
https://bugs.webkit.org/show_bug.cgi?id=170685
Reviewed by JF Bastien.
For some reason this didn't get included in r215141.
This fixes an issue with BrTable and loops where we would use the loop's return type
as the branch target type.
* wasm/WasmB3IRGenerator.cpp:
(JSC::Wasm::B3IRGenerator::ControlData::resultForBranch):
(JSC::Wasm::B3IRGenerator::unifyValuesWithBlock):
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/wasm/WasmB3IRGenerator.cpp
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (215192 => 215193)
--- trunk/Source/_javascript_Core/ChangeLog 2017-04-10 18:11:59 UTC (rev 215192)
+++ trunk/Source/_javascript_Core/ChangeLog 2017-04-10 18:31:22 UTC (rev 215193)
@@ -1,3 +1,19 @@
+2017-04-10 Keith Miller
+
+WebAssembly: Fix B3IRGenerator for BrTable
+https://bugs.webkit.org/show_bug.cgi?id=170685
+
+Reviewed by JF Bastien.
+
+For some reason this didn't get included in r215141.
+
+This fixes an issue with BrTable and loops where we would use the loop's return type
+as the branch target type.
+
+* wasm/WasmB3IRGenerator.cpp:
+(JSC::Wasm::B3IRGenerator::ControlData::resultForBranch):
+(JSC::Wasm::B3IRGenerator::unifyValuesWithBlock):
+
2017-04-08 Oliver Hunt
Remove use of strcpy from JSC
Modified: trunk/Source/_javascript_Core/wasm/WasmB3IRGenerator.cpp (215192 => 215193)
--- trunk/Source/_javascript_Core/wasm/WasmB3IRGenerator.cpp 2017-04-10 18:11:59 UTC (rev 215192)
+++ trunk/Source/_javascript_Core/wasm/WasmB3IRGenerator.cpp 2017-04-10 18:31:22 UTC (rev 215193)
@@ -131,18 +131,27 @@
special = nullptr;
}
+using ResultList = Vector;
+
+ResultList resultForBranch() const
+{
+if (type() == BlockType::Loop)
+return ResultList();
+return result;
+}
+
private:
friend class B3IRGenerator;
BlockType blockType;
BasicBlock* continuation;
BasicBlock* special;
-Vector result;
+ResultList result;
};
typedef Value* ExpressionType;
typedef ControlData ControlType;
typedef Vector ExpressionList;
-typedef Vector ResultList;
+typedef ControlData::ResultList ResultList;
typedef FunctionParser::ControlEntry ControlEntry;
static constexpr ExpressionType emptyExpression = nullptr;
@@ -223,7 +232,7 @@
void emitStoreOp(StoreOpType, ExpressionType pointer, ExpressionType value, uint32_t offset);
void unify(Variable* target, const ExpressionType source);
-void unifyValuesWithBlock(const ExpressionList& resultStack, ResultList& stack);
+void unifyValuesWithBlock(const ExpressionList& resultStack, const ResultList& stack);
void emitChecksForModOrDiv(B3::Opcode, ExpressionType left, ExpressionType right);
@@ -821,8 +830,7 @@
auto B3IRGenerator::addBranch(ControlData& data, ExpressionType condition, const ExpressionList& returnValues) -> PartialResult
{
-if (data.type() != BlockType::Loop)
-unifyValuesWithBlock(returnValues, data.result);
+unifyValuesWithBlock(returnValues, data.resultForBranch());
BasicBlock* target = data.targetBlockForBranch();
if (condition) {
@@ -843,8 +851,8 @@
auto B3IRGenerator::addSwitch(ExpressionType condition, const Vector& targets, ControlData& defaultTarget, const ExpressionList& expressionStack) -> PartialResult
{
for (size_t i = 0; i < targets.size(); ++i)
-unifyValuesWithBlock(expressionStack, targets[i]->result);
-unifyValuesWithBlock(expressionStack, defaultTarget.result);
+unifyValuesWithBlock(expressionStack, targets[i]->resultForBranch());
+unifyValuesWithBlock(expressionStack, defaultTarget.resultForBranch());
SwitchValue* switchValue = m_currentBlock->appendNew(m_proc, origin(), condition);
switchValue->setFallThrough(FrequentedBlock(defaultTarget.targetBlockForBranch()));
@@ -1060,7 +1068,7 @@
m_currentBlock->appendNew(m_proc, Set, origin(), variable, source);
}
-void B3IRGenerator::unifyValuesWithBlock(const ExpressionList& resultStack, ResultList& result)
+void B3IRGenerator::unifyValuesWithBlock(const ExpressionList& resultStack, const ResultList& result)
{
ASSERT(result.size() <= resultStack.size());
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [215195] trunk/Tools
Title: [215195] trunk/Tools Revision 215195 Author commit-qu...@webkit.org Date 2017-04-10 12:01:57 -0700 (Mon, 10 Apr 2017) Log Message [JSC] Do not run FTL stress tests on MIPS https://bugs.webkit.org/show_bug.cgi?id=170684 Patch by Guillaume Emont on 2017-04-10 Reviewed by Carlos Alberto Lopez Perez. run-jsc-stress-tests does not correctly detect MIPS platforms, and its logic to detect if the platform supports FTL ignores that MIPS does not support FTL. This adds detection of MIPS (with the magic number determined empirically) and fixes the determination of whether we support FTL. * Scripts/run-jsc-stress-tests: Modified Paths trunk/Tools/ChangeLog trunk/Tools/Scripts/run-jsc-stress-tests Diff Modified: trunk/Tools/ChangeLog (215194 => 215195) --- trunk/Tools/ChangeLog 2017-04-10 18:34:53 UTC (rev 215194) +++ trunk/Tools/ChangeLog 2017-04-10 19:01:57 UTC (rev 215195) @@ -1,3 +1,18 @@ +2017-04-10 Guillaume Emont + +[JSC] Do not run FTL stress tests on MIPS +https://bugs.webkit.org/show_bug.cgi?id=170684 + +Reviewed by Carlos Alberto Lopez Perez. + +run-jsc-stress-tests does not correctly detect MIPS platforms, and its +logic to detect if the platform supports FTL ignores that MIPS does +not support FTL. This adds detection of MIPS (with the magic number +determined empirically) and fixes the determination of whether we +support FTL. + +* Scripts/run-jsc-stress-tests: + 2017-04-10 Jonathan Bedard webkitpy: Increase estimate for processes run by iOS Simulators Modified: trunk/Tools/Scripts/run-jsc-stress-tests (215194 => 215195) --- trunk/Tools/Scripts/run-jsc-stress-tests 2017-04-10 18:34:53 UTC (rev 215194) +++ trunk/Tools/Scripts/run-jsc-stress-tests 2017-04-10 19:01:57 UTC (rev 215195) @@ -340,6 +340,8 @@ case code when 3 "x86" +when 8 +"mips" when 62 "x86-64" when 40 @@ -411,7 +413,7 @@ $hostOS = determineOS unless $hostOS $architecture = determineArchitecture unless $architecture -$isFTLPlatform = !($architecture == "x86" || $architecture == "arm" || $hostOS == "windows" || $hostOS == "linux" && $architecture == "arm64") +$isFTLPlatform = !($architecture == "x86" || $architecture == "arm" || $architecture == "mips" || $hostOS == "windows" || $hostOS == "linux" && $architecture == "arm64") if !$testRunnerType if $remote and $hostOS == "darwin" ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [215196] trunk/Source/JavaScriptCore
Title: [215196] trunk/Source/_javascript_Core
Revision 215196
Author mark@apple.com
Date 2017-04-10 12:38:44 -0700 (Mon, 10 Apr 2017)
Log Message
Move ProbeContext and ProbeFunction out of AbstractMacroAssembler.
https://bugs.webkit.org/show_bug.cgi?id=170681
Reviewed by Michael Saboff.
This is a refactoring step towards enabling custom probe printers the way printInternal() works for dataLog.
* assembler/AbstractMacroAssembler.h:
(JSC::AbstractMacroAssembler::ProbeContext::gpr): Deleted.
(JSC::AbstractMacroAssembler::ProbeContext::fpr): Deleted.
(JSC::AbstractMacroAssembler::ProbeContext::gprName): Deleted.
(JSC::AbstractMacroAssembler::ProbeContext::fprName): Deleted.
* assembler/MacroAssembler.cpp:
(JSC::stdFunctionCallback):
(JSC::MacroAssembler::probe):
* assembler/MacroAssembler.h:
(JSC::ProbeContext::gpr):
(JSC::ProbeContext::fpr):
(JSC::ProbeContext::gprName):
(JSC::ProbeContext::fprName):
* assembler/MacroAssemblerARM.cpp:
(JSC::MacroAssemblerARM::probe):
* assembler/MacroAssemblerARM64.cpp:
(JSC::arm64ProbeTrampoline):
(JSC::MacroAssemblerARM64::probe):
* assembler/MacroAssemblerARMv7.cpp:
(JSC::MacroAssemblerARMv7::probe):
* assembler/MacroAssemblerPrinter.cpp:
* assembler/MacroAssemblerPrinter.h:
* assembler/MacroAssemblerX86Common.cpp:
(JSC::MacroAssemblerX86Common::probe):
* ftl/FTLLowerDFGToB3.cpp:
(JSC::FTL::DFG::LowerDFGToB3::abstractStructure):
(JSC::FTL::DFG::LowerDFGToB3::probe): Deleted.
- Deleted because this became a useless place-holder after the transition to B3.
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/assembler/AbstractMacroAssembler.h
trunk/Source/_javascript_Core/assembler/MacroAssembler.cpp
trunk/Source/_javascript_Core/assembler/MacroAssembler.h
trunk/Source/_javascript_Core/assembler/MacroAssemblerARM.cpp
trunk/Source/_javascript_Core/assembler/MacroAssemblerARM64.cpp
trunk/Source/_javascript_Core/assembler/MacroAssemblerARMv7.cpp
trunk/Source/_javascript_Core/assembler/MacroAssemblerPrinter.cpp
trunk/Source/_javascript_Core/assembler/MacroAssemblerPrinter.h
trunk/Source/_javascript_Core/assembler/MacroAssemblerX86Common.cpp
trunk/Source/_javascript_Core/ftl/FTLLowerDFGToB3.cpp
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (215195 => 215196)
--- trunk/Source/_javascript_Core/ChangeLog 2017-04-10 19:01:57 UTC (rev 215195)
+++ trunk/Source/_javascript_Core/ChangeLog 2017-04-10 19:38:44 UTC (rev 215196)
@@ -1,3 +1,41 @@
+2017-04-10 Mark Lam
+
+Move ProbeContext and ProbeFunction out of AbstractMacroAssembler.
+https://bugs.webkit.org/show_bug.cgi?id=170681
+
+Reviewed by Michael Saboff.
+
+This is a refactoring step towards enabling custom probe printers the way printInternal() works for dataLog.
+
+* assembler/AbstractMacroAssembler.h:
+(JSC::AbstractMacroAssembler::ProbeContext::gpr): Deleted.
+(JSC::AbstractMacroAssembler::ProbeContext::fpr): Deleted.
+(JSC::AbstractMacroAssembler::ProbeContext::gprName): Deleted.
+(JSC::AbstractMacroAssembler::ProbeContext::fprName): Deleted.
+* assembler/MacroAssembler.cpp:
+(JSC::stdFunctionCallback):
+(JSC::MacroAssembler::probe):
+* assembler/MacroAssembler.h:
+(JSC::ProbeContext::gpr):
+(JSC::ProbeContext::fpr):
+(JSC::ProbeContext::gprName):
+(JSC::ProbeContext::fprName):
+* assembler/MacroAssemblerARM.cpp:
+(JSC::MacroAssemblerARM::probe):
+* assembler/MacroAssemblerARM64.cpp:
+(JSC::arm64ProbeTrampoline):
+(JSC::MacroAssemblerARM64::probe):
+* assembler/MacroAssemblerARMv7.cpp:
+(JSC::MacroAssemblerARMv7::probe):
+* assembler/MacroAssemblerPrinter.cpp:
+* assembler/MacroAssemblerPrinter.h:
+* assembler/MacroAssemblerX86Common.cpp:
+(JSC::MacroAssemblerX86Common::probe):
+* ftl/FTLLowerDFGToB3.cpp:
+(JSC::FTL::DFG::LowerDFGToB3::abstractStructure):
+(JSC::FTL::DFG::LowerDFGToB3::probe): Deleted.
+- Deleted because this became a useless place-holder after the transition to B3.
+
2017-04-10 Keith Miller
WebAssembly: Fix B3IRGenerator for BrTable
Modified: trunk/Source/_javascript_Core/assembler/AbstractMacroAssembler.h (215195 => 215196)
--- trunk/Source/_javascript_Core/assembler/AbstractMacroAssembler.h 2017-04-10 19:01:57 UTC (rev 215195)
+++ trunk/Source/_javascript_Core/assembler/AbstractMacroAssembler.h 2017-04-10 19:38:44 UTC (rev 215196)
@@ -43,6 +43,11 @@
#if ENABLE(ASSEMBLER)
+#if ENABLE(MASM_PROBE)
+struct ProbeContext;
+typedef void (*ProbeFunction)(struct ProbeContext*);
+#endif
+
class AllowMacroScratchRegisterUsage;
class DisallowMacroScratchRegisterUsage;
class LinkBuffer;
@@ -878,22 +883,6 @@
}
};
-struct ProbeContext;
-typedef void (*ProbeFunction)(struct ProbeContext*);
-
-struct ProbeContext {
-ProbeFunction probeFunctio
[webkit-changes] [215197] trunk
Title: [215197] trunk
Revision 215197
Author bfulg...@apple.com
Date 2017-04-10 12:53:49 -0700 (Mon, 10 Apr 2017)
Log Message
[WK2][macOS] Block access to Apple Events before launch.
https://bugs.webkit.org/show_bug.cgi?id=170626
Reviewed by Alexey Proskuryakov.
Source/WebKit2:
Clear the environment of the AppleEvent server name before initializing
AppKit so we never bother connecting.
* Shared/EntryPointUtilities/mac/XPCService/XPCServiceMain.mm:
(main):
Tools:
Add a new TestWebKitAPI test that fails if Apple Events are sent.
* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add new files.
* TestWebKitAPI/Tests/WebKit2/mac/InjectedBundleAppleEvent.cpp: Added.
(TestWebKitAPI::didReceiveMessageFromInjectedBundle):
(TestWebKitAPI::didFinishLoadForFrame):
(TestWebKitAPI::TEST):
* TestWebKitAPI/Tests/WebKit2/mac/InjectedBundleAppleEvent_Bundle.cpp: Added.
(TestWebKitAPI::InjectedBundleAppleEventTest::InjectedBundleAppleEventTest):
(TestWebKitAPI::InjectedBundleAppleEventTest::didCreatePage):
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/Shared/EntryPointUtilities/mac/XPCService/XPCServiceMain.mm
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj
Added Paths
trunk/Tools/TestWebKitAPI/Tests/WebKit2/mac/InjectedBundleAppleEvent.cpp
trunk/Tools/TestWebKitAPI/Tests/WebKit2/mac/InjectedBundleAppleEvent_Bundle.cpp
Diff
Modified: trunk/Source/WebKit2/ChangeLog (215196 => 215197)
--- trunk/Source/WebKit2/ChangeLog 2017-04-10 19:38:44 UTC (rev 215196)
+++ trunk/Source/WebKit2/ChangeLog 2017-04-10 19:53:49 UTC (rev 215197)
@@ -1,3 +1,17 @@
+2017-04-10 Brent Fulgham
+
+[WK2][macOS] Block access to Apple Events before launch.
+https://bugs.webkit.org/show_bug.cgi?id=170626
+
+
+Reviewed by Alexey Proskuryakov.
+
+Clear the environment of the AppleEvent server name before initializing
+AppKit so we never bother connecting.
+
+* Shared/EntryPointUtilities/mac/XPCService/XPCServiceMain.mm:
+(main):
+
2017-04-10 Adrian Perez de Castro
[GTK] Misplaced right click menu on web page due to deprecated gtk_menu_popup()
Modified: trunk/Source/WebKit2/Shared/EntryPointUtilities/mac/XPCService/XPCServiceMain.mm (215196 => 215197)
--- trunk/Source/WebKit2/Shared/EntryPointUtilities/mac/XPCService/XPCServiceMain.mm 2017-04-10 19:38:44 UTC (rev 215196)
+++ trunk/Source/WebKit2/Shared/EntryPointUtilities/mac/XPCService/XPCServiceMain.mm 2017-04-10 19:53:49 UTC (rev 215197)
@@ -1,5 +1,5 @@
/*
- * Copyright (C) 2013, 2015, 2016 Apple Inc. All rights reserved.
+ * Copyright (C) 2013-2017 Apple Inc. All rights reserved.
*
* Redistribution and use in source and binary forms, with or without
* modification, are permitted provided that the following conditions
@@ -140,6 +140,11 @@
}
}
+#if PLATFORM(MAC)
+// Don't allow Apple Events in WebKit processes. This can be removed when is fixed.
+setenv("__APPLEEVENTSSERVICENAME", "", 1);
+#endif
+
xpc_main(XPCServiceEventHandler);
return 0;
}
Modified: trunk/Tools/ChangeLog (215196 => 215197)
--- trunk/Tools/ChangeLog 2017-04-10 19:38:44 UTC (rev 215196)
+++ trunk/Tools/ChangeLog 2017-04-10 19:53:49 UTC (rev 215197)
@@ -1,3 +1,22 @@
+2017-04-10 Brent Fulgham
+
+[WK2][macOS] Block access to Apple Events before launch.
+https://bugs.webkit.org/show_bug.cgi?id=170626
+
+
+Reviewed by Alexey Proskuryakov.
+
+Add a new TestWebKitAPI test that fails if Apple Events are sent.
+
+* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add new files.
+* TestWebKitAPI/Tests/WebKit2/mac/InjectedBundleAppleEvent.cpp: Added.
+(TestWebKitAPI::didReceiveMessageFromInjectedBundle):
+(TestWebKitAPI::didFinishLoadForFrame):
+(TestWebKitAPI::TEST):
+* TestWebKitAPI/Tests/WebKit2/mac/InjectedBundleAppleEvent_Bundle.cpp: Added.
+(TestWebKitAPI::InjectedBundleAppleEventTest::InjectedBundleAppleEventTest):
+(TestWebKitAPI::InjectedBundleAppleEventTest::didCreatePage):
+
2017-04-10 Guillaume Emont
[JSC] Do not run FTL stress tests on MIPS
Modified: trunk/Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj (215196 => 215197)
--- trunk/Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj 2017-04-10 19:38:44 UTC (rev 215196)
+++ trunk/Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj 2017-04-10 19:53:49 UTC (rev 215197)
@@ -214,6 +214,8 @@
7A909A811D877480007E10F8 /* IntPoint.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 7A909A731D877475007E10F8 /* IntPoint.cpp */; };
7A909A821D877480007E10F8 /* IntRect.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 7A909A741D877475007E10F8 /* IntRect.cpp */; };
7A909A831D877480007E10F8 /* IntSize.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 7A909A751D877475007E10F8 /* IntSize.cpp */; };
+ 7A95BDE11E9BEC
[webkit-changes] [215198] trunk/Source/WebCore
Title: [215198] trunk/Source/WebCore
Revision 215198
Author commit-qu...@webkit.org
Date 2017-04-10 12:59:26 -0700 (Mon, 10 Apr 2017)
Log Message
Remove deprecated parts of media stream spec
https://bugs.webkit.org/show_bug.cgi?id=169879
Patch by Youenn Fablet on 2017-04-10
Reviewed by Jon Lee.
Removing MediaStreamTrackState 'new' value which was unused.
Removing MediaStreamTrack _readonly attribute which was unused.
* Modules/mediastream/MediaStreamTrack.cpp:
(WebCore::MediaStreamTrack::readonly): Deleted.
* Modules/mediastream/MediaStreamTrack.h:
* Modules/mediastream/MediaStreamTrack.idl:
* platform/mediastream/MediaStreamTrackPrivate.cpp:
(WebCore::MediaStreamTrackPrivate::readonly): Deleted.
* platform/mediastream/MediaStreamTrackPrivate.h:
* platform/mediastream/RealtimeMediaSource.h:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/mediastream/MediaStreamTrack.cpp
trunk/Source/WebCore/Modules/mediastream/MediaStreamTrack.h
trunk/Source/WebCore/Modules/mediastream/MediaStreamTrack.idl
trunk/Source/WebCore/platform/mediastream/MediaStreamTrackPrivate.cpp
trunk/Source/WebCore/platform/mediastream/MediaStreamTrackPrivate.h
trunk/Source/WebCore/platform/mediastream/RealtimeMediaSource.cpp
trunk/Source/WebCore/platform/mediastream/RealtimeMediaSource.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (215197 => 215198)
--- trunk/Source/WebCore/ChangeLog 2017-04-10 19:53:49 UTC (rev 215197)
+++ trunk/Source/WebCore/ChangeLog 2017-04-10 19:59:26 UTC (rev 215198)
@@ -1,3 +1,22 @@
+2017-04-10 Youenn Fablet
+
+Remove deprecated parts of media stream spec
+https://bugs.webkit.org/show_bug.cgi?id=169879
+
+Reviewed by Jon Lee.
+
+Removing MediaStreamTrackState 'new' value which was unused.
+Removing MediaStreamTrack _readonly attribute which was unused.
+
+* Modules/mediastream/MediaStreamTrack.cpp:
+(WebCore::MediaStreamTrack::readonly): Deleted.
+* Modules/mediastream/MediaStreamTrack.h:
+* Modules/mediastream/MediaStreamTrack.idl:
+* platform/mediastream/MediaStreamTrackPrivate.cpp:
+(WebCore::MediaStreamTrackPrivate::readonly): Deleted.
+* platform/mediastream/MediaStreamTrackPrivate.h:
+* platform/mediastream/RealtimeMediaSource.h:
+
2017-04-10 Ryan Haddad
Unreviewed, rolling out r215175.
Modified: trunk/Source/WebCore/Modules/mediastream/MediaStreamTrack.cpp (215197 => 215198)
--- trunk/Source/WebCore/Modules/mediastream/MediaStreamTrack.cpp 2017-04-10 19:53:49 UTC (rev 215197)
+++ trunk/Source/WebCore/Modules/mediastream/MediaStreamTrack.cpp 2017-04-10 19:59:26 UTC (rev 215198)
@@ -98,11 +98,6 @@
return m_private->muted();
}
-bool MediaStreamTrack::readonly() const
-{
-return m_private->readonly();
-}
-
auto MediaStreamTrack::readyState() const -> State
{
return ended() ? State::Ended : State::Live;
Modified: trunk/Source/WebCore/Modules/mediastream/MediaStreamTrack.h (215197 => 215198)
--- trunk/Source/WebCore/Modules/mediastream/MediaStreamTrack.h 2017-04-10 19:53:49 UTC (rev 215197)
+++ trunk/Source/WebCore/Modules/mediastream/MediaStreamTrack.h 2017-04-10 19:59:26 UTC (rev 215198)
@@ -64,9 +64,8 @@
void setEnabled(bool);
bool muted() const;
-bool readonly() const;
-enum class State { New, Live, Ended };
+enum class State { Live, Ended };
State readyState() const;
bool ended() const;
Modified: trunk/Source/WebCore/Modules/mediastream/MediaStreamTrack.idl (215197 => 215198)
--- trunk/Source/WebCore/Modules/mediastream/MediaStreamTrack.idl 2017-04-10 19:53:49 UTC (rev 215197)
+++ trunk/Source/WebCore/Modules/mediastream/MediaStreamTrack.idl 2017-04-10 19:59:26 UTC (rev 215198)
@@ -24,7 +24,7 @@
*/
// FIXME 169871: remove "new"
-enum MediaStreamTrackState { "new", "live", "ended" };
+enum MediaStreamTrackState { "live", "ended" };
[
ActiveDOMObject,
@@ -53,9 +53,6 @@
Promise applyConstraints(optional MediaTrackConstraints constraints);
attribute EventHandler onoverconstrained;
-
-// FIXME 169871: legacy or remove?
-readonly attribute boolean _readonly;
};
[
Modified: trunk/Source/WebCore/platform/mediastream/MediaStreamTrackPrivate.cpp (215197 => 215198)
--- trunk/Source/WebCore/platform/mediastream/MediaStreamTrackPrivate.cpp 2017-04-10 19:53:49 UTC (rev 215197)
+++ trunk/Source/WebCore/platform/mediastream/MediaStreamTrackPrivate.cpp 2017-04-10 19:59:26 UTC (rev 215198)
@@ -80,11 +80,6 @@
return m_source->muted();
}
-bool MediaStreamTrackPrivate::readonly() const
-{
-return m_source->readonly();
-}
-
bool MediaStreamTrackPrivate::isCaptureTrack() const
{
return m_source->isCaptureSource();
Modified: trunk/Source/WebCore/platform/mediastream/MediaStreamTrackPrivate.h (215197 => 215198)
--- trunk/Source/WebCore/platform/mediastream/MediaStreamTrackPrivate.h 2017-04-10 19:53:49 UTC (rev 215197)
+++ trunk/Source/WebCo
[webkit-changes] [215199] trunk/LayoutTests
Title: [215199] trunk/LayoutTests Revision 215199 Author ryanhad...@apple.com Date 2017-04-10 13:00:55 -0700 (Mon, 10 Apr 2017) Log Message Mark media/modern-media-controls/volume-slider/volume-slider-value.html as flaky. https://bugs.webkit.org/show_bug.cgi?id=167475 Unreviewed test gardening. * platform/mac-wk1/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/mac-wk1/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (215198 => 215199) --- trunk/LayoutTests/ChangeLog 2017-04-10 19:59:26 UTC (rev 215198) +++ trunk/LayoutTests/ChangeLog 2017-04-10 20:00:55 UTC (rev 215199) @@ -1,3 +1,12 @@ +2017-04-10 Ryan Haddad + +Mark media/modern-media-controls/volume-slider/volume-slider-value.html as flaky. +https://bugs.webkit.org/show_bug.cgi?id=167475 + +Unreviewed test gardening. + +* platform/mac-wk1/TestExpectations: + 2017-04-10 Wenson Hsieh REGRESSION (r214403): fast/events/drag-to-navigate.html and fast/events/only-valid-drop-targets-receive-file-drop.html failing Modified: trunk/LayoutTests/platform/mac-wk1/TestExpectations (215198 => 215199) --- trunk/LayoutTests/platform/mac-wk1/TestExpectations 2017-04-10 19:59:26 UTC (rev 215198) +++ trunk/LayoutTests/platform/mac-wk1/TestExpectations 2017-04-10 20:00:55 UTC (rev 215199) @@ -344,6 +344,7 @@ webkit.org/b/170456 media/modern-media-controls/macos-inline-media-controls/macos-inline-media-controls-buttons-styles.html [ Pass Timeout ] webkit.org/b/167752 media/modern-media-controls/icon-button/icon-button-active-state.html [ Pass Timeout ] webkit.org/b/167477 [ Debug ] media/modern-media-controls/play-pause-button/play-pause-button.html [ Pass Timeout ] +webkit.org/b/167475 [ Debug ] media/modern-media-controls/volume-slider/volume-slider-value.html [ Pass Timeout ] webkit.org/b/170682 [ Debug ] media/modern-media-controls/volume-up-support/volume-up-support.html [ Pass Timeout ] # There is not NetworkProcess in WK1, so it can't crash. ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [215200] trunk/Source/WebCore
Title: [215200] trunk/Source/WebCore
Revision 215200
Author commit-qu...@webkit.org
Date 2017-04-10 14:02:16 -0700 (Mon, 10 Apr 2017)
Log Message
Wrap legacy MediaStream API in runtime flag
https://bugs.webkit.org/show_bug.cgi?id=169877
Patch by Youenn Fablet on 2017-04-10
Reviewed by Alex Christensen.
Covered by binding tests.
Marking navigator.getUserMedia and MediaStreamEvent as runtime enabled if mediastream and webrtclegacy api flags
are on.
Updated binding generator to support multiple runtime flags.
* Modules/mediastream/MediaStreamEvent.idl:
* Modules/mediastream/NavigatorUserMedia.idl:
* bindings/scripts/CodeGeneratorJS.pm:
(GetRuntimeEnableFunctionName):
(GenerateImplementation):
* bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore::JSTestObjPrototype::finishCreation):
* bindings/scripts/test/TestObj.idl:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/mediastream/MediaStreamEvent.idl
trunk/Source/WebCore/Modules/mediastream/NavigatorUserMedia.idl
trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm
trunk/Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp
trunk/Source/WebCore/bindings/scripts/test/TestObj.idl
Diff
Modified: trunk/Source/WebCore/ChangeLog (215199 => 215200)
--- trunk/Source/WebCore/ChangeLog 2017-04-10 20:00:55 UTC (rev 215199)
+++ trunk/Source/WebCore/ChangeLog 2017-04-10 21:02:16 UTC (rev 215200)
@@ -1,5 +1,27 @@
2017-04-10 Youenn Fablet
+Wrap legacy MediaStream API in runtime flag
+https://bugs.webkit.org/show_bug.cgi?id=169877
+
+Reviewed by Alex Christensen.
+
+Covered by binding tests.
+
+Marking navigator.getUserMedia and MediaStreamEvent as runtime enabled if mediastream and webrtclegacy api flags
+are on.
+Updated binding generator to support multiple runtime flags.
+
+* Modules/mediastream/MediaStreamEvent.idl:
+* Modules/mediastream/NavigatorUserMedia.idl:
+* bindings/scripts/CodeGeneratorJS.pm:
+(GetRuntimeEnableFunctionName):
+(GenerateImplementation):
+* bindings/scripts/test/JS/JSTestObj.cpp:
+(WebCore::JSTestObjPrototype::finishCreation):
+* bindings/scripts/test/TestObj.idl:
+
+2017-04-10 Youenn Fablet
+
Remove deprecated parts of media stream spec
https://bugs.webkit.org/show_bug.cgi?id=169879
Modified: trunk/Source/WebCore/Modules/mediastream/MediaStreamEvent.idl (215199 => 215200)
--- trunk/Source/WebCore/Modules/mediastream/MediaStreamEvent.idl 2017-04-10 20:00:55 UTC (rev 215199)
+++ trunk/Source/WebCore/Modules/mediastream/MediaStreamEvent.idl 2017-04-10 21:02:16 UTC (rev 215200)
@@ -22,11 +22,10 @@
* SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
*/
-// FIXME 169871: legacy or remove
[
Conditional=WEB_RTC,
Constructor(DOMString type, optional MediaStreamEventInit eventInitDict),
-EnabledAtRuntime=MediaStream,
+EnabledAtRuntime=WebRTCLegacyAPI&MediaStream,
] interface MediaStreamEvent : Event {
readonly attribute MediaStream? stream;
};
Modified: trunk/Source/WebCore/Modules/mediastream/NavigatorUserMedia.idl (215199 => 215200)
--- trunk/Source/WebCore/Modules/mediastream/NavigatorUserMedia.idl 2017-04-10 20:00:55 UTC (rev 215199)
+++ trunk/Source/WebCore/Modules/mediastream/NavigatorUserMedia.idl 2017-04-10 21:02:16 UTC (rev 215200)
@@ -29,9 +29,8 @@
*/
[
-Conditional=MEDIA_STREAM,
-EnabledAtRuntime=MediaStream,
+Conditional=MEDIA_STREAM&WEB_RTC,
+EnabledAtRuntime=WebRTCLegacyAPI&MediaStream,
] partial interface Navigator {
-// FIXME 169871: wrap legacy setting
[JSBuiltin] void getUserMedia(MediaStreamConstraints constraints, NavigatorUserMediaSuccessCallback successCallback, NavigatorUserMediaErrorCallback errorCallback);
};
Modified: trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm (215199 => 215200)
--- trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm 2017-04-10 20:00:55 UTC (rev 215199)
+++ trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm 2017-04-10 21:02:16 UTC (rev 215200)
@@ -2910,7 +2910,7 @@
}
# Returns the RuntimeEnabledFeatures function name that is hooked up to check if a method/attribute is enabled.
-# NOTE: Parameter passed in must have both an 'extendedAttributes' property.
+# NOTE: Parameter passed in must have an 'extendedAttributes' property.
# (e.g. DOMInterface, DOMAttribute, DOMOperation, DOMIterable, etc.)
sub GetRuntimeEnableFunctionName
{
@@ -2917,18 +2917,25 @@
my $context = shift;
AddToImplIncludes("RuntimeEnabledFeatures.h");
-
+
if ($context->extendedAttributes->{EnabledForWorld}) {
-return "worldForDOMObject(this)." . ToMethodName($context->extendedAttributes->{EnabledForWorld});
+return "worldForDOMObject(this)." . ToMethodName($context->extendedAttributes->{EnabledForWorld}) . "()";
}
# If a parameter is given (e.g. "EnabledAtRuntime=FeatureName") return the Runt
[webkit-changes] [215201] trunk/Source
Title: [215201] trunk/Source Revision 215201 Author commit-qu...@webkit.org Date 2017-04-10 14:24:13 -0700 (Mon, 10 Apr 2017) Log Message Add CoreAudioCaptureSource. https://bugs.webkit.org/show_bug.cgi?id=170112 rdar://problem/30293338 Patch by Jeremy Jones on 2017-04-10 Source/WebCore: Reviewed by Eric Carlson. No new tests because this provides the same funcitonality as AVAudioCaptureSource. Funcionality is covered by existing test cases. Add CoreAudioCaptureSource for audio capture. And use it by default in AVCaptureDeviceManager. Add UseAVFoundationAudioCapture setting to switch back to AVFoundation for audio capture. * WebCore.xcodeproj/project.pbxproj: * page/Settings.cpp: (WebCore::Settings::useAVFoundationAudioCapture): (WebCore::Settings::setUseAVFoundationAudioCapture): * page/Settings.h: * platform/mediastream/mac/AVCaptureDeviceManager.h: * platform/mediastream/mac/AVCaptureDeviceManager.mm: (WebCore::AVCaptureDeviceManager::setUseAVFoundationAudioCapture): * platform/mediastream/mac/CoreAudioCaptureSource.cpp: Added. (WebCore::CoreAudioCaptureSource::create): (WebCore::CoreAudioCaptureSource::factory): (WebCore::CoreAudioCaptureSource::CoreAudioCaptureSource): (WebCore::CoreAudioCaptureSource::~CoreAudioCaptureSource): (WebCore::CoreAudioCaptureSource::preferredSampleRate): (WebCore::CoreAudioCaptureSource::preferredIOBufferDuration): (WebCore::CoreAudioCaptureSource::configureMicrophoneProc): (WebCore::CoreAudioCaptureSource::configureSpeakerProc): (WebCore::CoreAudioCaptureSource::addMicrophoneDataConsumer): (WebCore::CoreAudioCaptureSource::removeMicrophoneDataConsumer): (WebCore::CoreAudioCaptureSource::addEchoCancellationSource): (WebCore::CoreAudioCaptureSource::removeEchoCancellationSource): (WebCore::CoreAudioCaptureSource::checkTimestamps): (WebCore::CoreAudioCaptureSource::provideSpeakerData): (WebCore::CoreAudioCaptureSource::speakerCallback): (WebCore::CoreAudioCaptureSource::processMicrophoneSamples): (WebCore::CoreAudioCaptureSource::microphoneCallback): (WebCore::CoreAudioCaptureSource::defaultOutputDevice): (WebCore::CoreAudioCaptureSource::defaultInputDevice): (WebCore::CoreAudioCaptureSource::setupAudioUnits): (WebCore::CoreAudioCaptureSource::startProducingData): (WebCore::CoreAudioCaptureSource::stopProducingData): (WebCore::CoreAudioCaptureSource::suspend): (WebCore::CoreAudioCaptureSource::resume): (WebCore::CoreAudioCaptureSource::capabilities): (WebCore::CoreAudioCaptureSource::settings): * platform/mediastream/mac/CoreAudioCaptureSource.h: Added. * platform/mediastream/mac/RealtimeMediaSourceCenterMac.cpp: (WebCore::RealtimeMediaSourceCenterMac::RealtimeMediaSourceCenterMac): (WebCore::RealtimeMediaSourceCenterMac::defaultAudioFactory): Source/WebKit/mac: Reviewed by Eric Carlson. Add UseAVFoundationAudioCapture preference to switch back from the new default of CoreAudio. * WebView/WebPreferenceKeysPrivate.h: * WebView/WebPreferences.mm: (+[WebPreferences initialize]): (-[WebPreferences useAVFoundationAudioCapture]): (-[WebPreferences setUseAVFoundationAudioCapture:]): * WebView/WebPreferencesPrivate.h: * WebView/WebView.mm: (-[WebView _preferencesChanged:]): Source/WebKit2: Reviewed by Tim Horton. Add UseAVFoundationAudioCapture preference to switch back from the new default of CoreAudio. * Shared/WebPreferencesDefinitions.h: * UIProcess/API/C/WKPreferences.cpp: (WKPreferencesSetUseAVFoundationAudioCapture): (WKPreferencesGetUseAVFoundationAudioCapture): * UIProcess/API/C/WKPreferencesRefPrivate.h: * UIProcess/Cocoa/UserMediaCaptureManagerProxy.cpp: (WebKit::UserMediaCaptureManagerProxy::createMediaSourceForCaptureDeviceWithConstraints): * UIProcess/UserMediaPermissionRequestManagerProxy.cpp: (WebKit::UserMediaPermissionRequestManagerProxy::syncWithWebCorePrefs): * WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::updatePreferences): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj trunk/Source/WebCore/page/Settings.cpp trunk/Source/WebCore/page/Settings.h trunk/Source/WebCore/platform/mediastream/mac/AVCaptureDeviceManager.h trunk/Source/WebCore/platform/mediastream/mac/AVCaptureDeviceManager.mm trunk/Source/WebCore/platform/mediastream/mac/RealtimeMediaSourceCenterMac.cpp trunk/Source/WebKit/mac/ChangeLog trunk/Source/WebKit/mac/WebView/WebPreferenceKeysPrivate.h trunk/Source/WebKit/mac/WebView/WebPreferences.mm trunk/Source/WebKit/mac/WebView/WebPreferencesPrivate.h trunk/Source/WebKit/mac/WebView/WebView.mm trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/Shared/WebPreferencesDefinitions.h trunk/Source/WebKit2/UIProcess/API/C/WKPreferences.cpp trunk/Source/WebKit2/UIProcess/API/C/WKPreferencesRefPrivate.h trunk/Source/WebKit2/UIProcess/Cocoa/UserMediaCaptureManagerProxy.cpp trunk/Source/WebKit2/UIProcess/UserMediaPermissionRequestManagerProxy.cpp trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp Added Paths trunk/Source/WebCore/platform/mediastream/mac/CoreAudioCaptureSource.cpp
[webkit-changes] [215203] trunk
Title: [215203] trunk Revision 215203 Author rn...@webkit.org Date 2017-04-10 14:43:11 -0700 (Mon, 10 Apr 2017) Log Message .: Elftoolchain ar doesn't support response files https://bugs.webkit.org/show_bug.cgi?id=170105 Patch by Ting-Wei Lan on 2017-04-08 Reviewed by Michael Catanzaro. WebKit enables the use of response files when cmake and ninja is used. However, the default implementation of ar command used in FreeBSD, which is part of elftoolchain project, doesn't support reading arguments from response files. To avoid causing undefined reference error on FreeBSD, we disable the use of response files when elftoolchain ar is detected. * Source/cmake/OptionsCommon.cmake: Websites/perf.webkit.org: Unreviewed, rolling out r215202. https://bugs.webkit.org/show_bug.cgi?id=170694 Committed incorrectly (Requested by rniwa on #webkit). Reverted changeset: "Add the UI for scheduling a A/B testing with a custom root" https://bugs.webkit.org/show_bug.cgi?id=170622 http://trac.webkit.org/changeset/215202 Patch by Commit Queue on 2017-04-10 Modified Paths trunk/ChangeLog trunk/Websites/perf.webkit.org/ChangeLog trunk/Websites/perf.webkit.org/ReadMe.md trunk/Websites/perf.webkit.org/init-database.sql trunk/Websites/perf.webkit.org/public/api/build-requests.php trunk/Websites/perf.webkit.org/public/api/commits.php trunk/Websites/perf.webkit.org/public/api/test-groups.php trunk/Websites/perf.webkit.org/public/include/build-requests-fetcher.php trunk/Websites/perf.webkit.org/public/include/commit-log-fetcher.php trunk/Websites/perf.webkit.org/public/privileged-api/create-test-group.php trunk/Websites/perf.webkit.org/public/privileged-api/upload-file.php trunk/Websites/perf.webkit.org/public/v3/index.html trunk/Websites/perf.webkit.org/public/v3/models/analysis-task.js trunk/Websites/perf.webkit.org/public/v3/models/build-request.js trunk/Websites/perf.webkit.org/public/v3/models/commit-log.js trunk/Websites/perf.webkit.org/public/v3/models/commit-set.js trunk/Websites/perf.webkit.org/public/v3/models/manifest.js trunk/Websites/perf.webkit.org/public/v3/models/metric.js trunk/Websites/perf.webkit.org/public/v3/models/test-group.js trunk/Websites/perf.webkit.org/public/v3/models/triggerable.js trunk/Websites/perf.webkit.org/public/v3/models/uploaded-file.js trunk/Websites/perf.webkit.org/public/v3/pages/analysis-category-page.js trunk/Websites/perf.webkit.org/public/v3/pages/analysis-task-page.js trunk/Websites/perf.webkit.org/public/v3/pages/chart-pane-status-view.js trunk/Websites/perf.webkit.org/public/v3/pages/chart-pane.js trunk/Websites/perf.webkit.org/public/v3/pages/create-analysis-task-page.js trunk/Websites/perf.webkit.org/public/v3/pages/page-router.js trunk/Websites/perf.webkit.org/server-tests/api-build-requests-tests.js trunk/Websites/perf.webkit.org/server-tests/api-commits-tests.js trunk/Websites/perf.webkit.org/server-tests/privileged-api-create-test-group-tests.js trunk/Websites/perf.webkit.org/server-tests/resources/mock-data.js trunk/Websites/perf.webkit.org/tools/js/remote.js trunk/Websites/perf.webkit.org/unit-tests/analysis-task-tests.js trunk/Websites/perf.webkit.org/unit-tests/build-request-tests.js trunk/Websites/perf.webkit.org/unit-tests/buildbot-syncer-tests.js trunk/Websites/perf.webkit.org/unit-tests/test-groups-tests.js Removed Paths trunk/public/ Diff Modified: trunk/ChangeLog (215202 => 215203) --- trunk/ChangeLog 2017-04-10 21:38:04 UTC (rev 215202) +++ trunk/ChangeLog 2017-04-10 21:43:11 UTC (rev 215203) @@ -1,237 +1,3 @@ -2017-04-10 Ryosuke Niwa - -Add the UI for scheduling a A/B testing with a custom root -https://bugs.webkit.org/show_bug.cgi?id=170622 - -Reviewed by Anders Carlsson. - -This patch adds the support for creating a new analysis task with a custom darwinup roots. A follow up patch -would update the syncing script to schedule such an A/B testing job to a buildbot instance. - - -* ReadMe.md: Updated instructions for backing up and restoring the database so that it's easier to replace -the file path for the backup. - -* init-database.sql: Make task_platform and task_metric optional in each analysis task. Also added a column -to store the root file in commit_set_relationships. - -* public/api/build-requests.php: -(main): Include the uploaded files. - -* public/api/commits.php: -(main): Added the support for querying the latest commits for a given platform. This is used in a new page -to create a custom analysis task to autofill the latest revisions for a given platform. - -* public/api/test-groups.php: -(main): Include the uploaded files. - -* public/include/build-requests-fetcher.php: -(BuildRequestsFetcher::__construct): Added a list of uploaded_files and a map from its id. -(BuildRequestsFetcher::uploaded_files): Added. -(BuildRequestsFetcher::fetch_commits_for_set_if_needed): Added
[webkit-changes] [215204] trunk/Source/WebKit/mac
Title: [215204] trunk/Source/WebKit/mac
Revision 215204
Author ander...@apple.com
Date 2017-04-10 14:44:20 -0700 (Mon, 10 Apr 2017)
Log Message
Remove call to WKShowKeyAndMain
https://bugs.webkit.org/show_bug.cgi?id=170691
rdar://problem/31050032
Reviewed by Beth Dakin.
* Carbon/CarbonWindowAdapter.mm:
(-[CarbonWindowAdapter makeKeyWindow]):
Modified Paths
trunk/Source/WebKit/mac/Carbon/CarbonWindowAdapter.mm
trunk/Source/WebKit/mac/ChangeLog
Diff
Modified: trunk/Source/WebKit/mac/Carbon/CarbonWindowAdapter.mm (215203 => 215204)
--- trunk/Source/WebKit/mac/Carbon/CarbonWindowAdapter.mm 2017-04-10 21:43:11 UTC (rev 215203)
+++ trunk/Source/WebKit/mac/Carbon/CarbonWindowAdapter.mm 2017-04-10 21:44:20 UTC (rev 215204)
@@ -661,14 +661,13 @@
}
}
-- (void)makeKeyWindow {
- [NSApp _setMouseActivationInProgress:NO];
- [NSApp setIsActive:YES];
- [super makeKeyWindow];
- WKShowKeyAndMain();
+- (void)makeKeyWindow
+{
+[NSApp _setMouseActivationInProgress:NO];
+[NSApp setIsActive:YES];
+[super makeKeyWindow];
}
-
// Do the right thing for a Carbon window.
- (BOOL)canBecomeKeyWindow {
Modified: trunk/Source/WebKit/mac/ChangeLog (215203 => 215204)
--- trunk/Source/WebKit/mac/ChangeLog 2017-04-10 21:43:11 UTC (rev 215203)
+++ trunk/Source/WebKit/mac/ChangeLog 2017-04-10 21:44:20 UTC (rev 215204)
@@ -1,3 +1,14 @@
+2017-04-10 Anders Carlsson
+
+Remove call to WKShowKeyAndMain
+https://bugs.webkit.org/show_bug.cgi?id=170691
+rdar://problem/31050032
+
+Reviewed by Beth Dakin.
+
+* Carbon/CarbonWindowAdapter.mm:
+(-[CarbonWindowAdapter makeKeyWindow]):
+
2017-04-10 Jeremy Jones
Add CoreAudioCaptureSource.
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [215206] trunk/Source/WebInspectorUI
Title: [215206] trunk/Source/WebInspectorUI
Revision 215206
Author nvasil...@apple.com
Date 2017-04-10 14:46:04 -0700 (Mon, 10 Apr 2017)
Log Message
Web Inspector: WebSockets: Don't clip data in the data grid
https://bugs.webkit.org/show_bug.cgi?id=170559
Reviewed by Timothy Hatcher.
Long lines without spaces should be broken down into several lines instead of being ellipsized.
* UserInterface/Views/WebSocketContentView.css:
(.web-socket.content-view > .data-grid td.data-column,):
Modified Paths
trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/Views/WebSocketContentView.css
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (215205 => 215206)
--- trunk/Source/WebInspectorUI/ChangeLog 2017-04-10 21:45:11 UTC (rev 215205)
+++ trunk/Source/WebInspectorUI/ChangeLog 2017-04-10 21:46:04 UTC (rev 215206)
@@ -1,5 +1,17 @@
2017-04-10 Nikita Vasilyev
+Web Inspector: WebSockets: Don't clip data in the data grid
+https://bugs.webkit.org/show_bug.cgi?id=170559
+
+Reviewed by Timothy Hatcher.
+
+Long lines without spaces should be broken down into several lines instead of being ellipsized.
+
+* UserInterface/Views/WebSocketContentView.css:
+(.web-socket.content-view > .data-grid td.data-column,):
+
+2017-04-10 Nikita Vasilyev
+
Web Inspector: Placeholder text is clipped in the 'Enter Class Name' field at the bottom of Rules style sidebar in some localizations
https://bugs.webkit.org/show_bug.cgi?id=167641
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/WebSocketContentView.css (215205 => 215206)
--- trunk/Source/WebInspectorUI/UserInterface/Views/WebSocketContentView.css 2017-04-10 21:45:11 UTC (rev 215205)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/WebSocketContentView.css 2017-04-10 21:46:04 UTC (rev 215206)
@@ -36,6 +36,7 @@
.web-socket.content-view .data-grid td.data-column > div {
height: auto;
white-space: pre-wrap;
+overflow-wrap: break-word;
}
body[dir=ltr] .web-socket.content-view > .data-grid .data-column > div {
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [215207] trunk/Tools
Title: [215207] trunk/Tools
Revision 215207
Author wenson_hs...@apple.com
Date 2017-04-10 15:22:39 -0700 (Mon, 10 Apr 2017)
Log Message
Refactor DataInteractionTests.UnresponsivePageDoesNotHangUI to not check against a fixed time interval
https://bugs.webkit.org/show_bug.cgi?id=170658
Reviewed by Tim Horton.
Uses ignoreSynchronousMessagingTimeoutsForTesting to ensure that this test times out if data interaction
preparation is synchronous, or passes if it is asynchronous.
* TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
(TestWebKitAPI::TEST):
* TestWebKitAPI/cocoa/TestWKWebView.h:
* TestWebKitAPI/cocoa/TestWKWebView.mm:
(-[TestWKWebView initWithFrame:]):
(-[TestWKWebView initWithFrame:configuration:processPoolConfiguration:]):
(-[TestWKWebView _setUpTestWindow:]):
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/ios/DataInteractionTests.mm
trunk/Tools/TestWebKitAPI/cocoa/TestWKWebView.h
trunk/Tools/TestWebKitAPI/cocoa/TestWKWebView.mm
Diff
Modified: trunk/Tools/ChangeLog (215206 => 215207)
--- trunk/Tools/ChangeLog 2017-04-10 21:46:04 UTC (rev 215206)
+++ trunk/Tools/ChangeLog 2017-04-10 22:22:39 UTC (rev 215207)
@@ -1,3 +1,21 @@
+2017-04-10 Wenson Hsieh
+
+Refactor DataInteractionTests.UnresponsivePageDoesNotHangUI to not check against a fixed time interval
+https://bugs.webkit.org/show_bug.cgi?id=170658
+
+Reviewed by Tim Horton.
+
+Uses ignoreSynchronousMessagingTimeoutsForTesting to ensure that this test times out if data interaction
+preparation is synchronous, or passes if it is asynchronous.
+
+* TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
+(TestWebKitAPI::TEST):
+* TestWebKitAPI/cocoa/TestWKWebView.h:
+* TestWebKitAPI/cocoa/TestWKWebView.mm:
+(-[TestWKWebView initWithFrame:]):
+(-[TestWKWebView initWithFrame:configuration:processPoolConfiguration:]):
+(-[TestWKWebView _setUpTestWindow:]):
+
2017-04-10 Brent Fulgham
[WK2][macOS] Block access to Apple Events before launch.
Modified: trunk/Tools/TestWebKitAPI/Tests/ios/DataInteractionTests.mm (215206 => 215207)
--- trunk/Tools/TestWebKitAPI/Tests/ios/DataInteractionTests.mm 2017-04-10 21:46:04 UTC (rev 215206)
+++ trunk/Tools/TestWebKitAPI/Tests/ios/DataInteractionTests.mm 2017-04-10 22:22:39 UTC (rev 215207)
@@ -35,6 +35,7 @@
#import
#import
#import
+#import
@implementation TestWKWebView (DataInteractionTests)
@@ -387,14 +388,15 @@
TEST(DataInteractionTests, UnresponsivePageDoesNotHangUI)
{
-RetainPtr webView = adoptNS([[TestWKWebView alloc] initWithFrame:CGRectMake(0, 0, 320, 500)]);
+_WKProcessPoolConfiguration *processPoolConfiguration = [[[_WKProcessPoolConfiguration alloc] init] autorelease];
+processPoolConfiguration.ignoreSynchronousMessagingTimeoutsForTesting = YES;
+
+RetainPtr webView = adoptNS([[TestWKWebView alloc] initWithFrame:CGRectMake(0, 0, 320, 500) configuration:[[[WKWebViewConfiguration alloc] init] autorelease] processPoolConfiguration:processPoolConfiguration]);
[webView synchronouslyLoadTestPageNamed:@"simple"];
[webView evaluateJavaScript:@"while(1);" completionHandler:nil];
-NSTimeInterval startTime = [NSDate timeIntervalSinceReferenceDate];
+// The test passes if we can prepare for data interaction without timing out.
[webView _simulatePrepareForDataInteractionSession:nil completion:^() { }];
-
-EXPECT_LT([NSDate timeIntervalSinceReferenceDate] - startTime, 1);
}
} // namespace TestWebKitAPI
Modified: trunk/Tools/TestWebKitAPI/cocoa/TestWKWebView.h (215206 => 215207)
--- trunk/Tools/TestWebKitAPI/cocoa/TestWKWebView.h 2017-04-10 21:46:04 UTC (rev 215206)
+++ trunk/Tools/TestWebKitAPI/cocoa/TestWKWebView.h 2017-04-10 22:22:39 UTC (rev 215207)
@@ -28,11 +28,14 @@
#if WK_API_ENABLED
+@class _WKProcessPoolConfiguration;
+
@interface TestMessageHandler : NSObject
- (void)addMessage:(NSString *)message withHandler:(dispatch_block_t)handler;
@end
@interface TestWKWebView : WKWebView
+- (instancetype)initWithFrame:(CGRect)frame configuration:(WKWebViewConfiguration *)configuration processPoolConfiguration:(_WKProcessPoolConfiguration *)processPoolConfiguration;
- (void)clearMessageHandlers:(NSArray *)messageNames;
- (void)performAfterReceivingMessage:(NSString *)message action:(dispatch_block_t)action;
- (void)loadTestPageNamed:(NSString *)pageName;
Modified: trunk/Tools/TestWebKitAPI/cocoa/TestWKWebView.mm (215206 => 215207)
--- trunk/Tools/TestWebKitAPI/cocoa/TestWKWebView.mm 2017-04-10 21:46:04 UTC (rev 215206)
+++ trunk/Tools/TestWebKitAPI/cocoa/TestWKWebView.mm 2017-04-10 22:22:39 UTC (rev 215207)
@@ -31,7 +31,9 @@
#import "TestNavigationDelegate.h"
#import "Utilities.h"
+#import
#import
+#import
#import
#import
@@ -159,13 +161,13 @@
@end
@implementation TestWKWebView {
-TestWKWebViewHostWindow *_hostWindow;
+RetainPtr _hostWindow;
RetainPtr _testHandl
[webkit-changes] [215208] trunk/Source/WebCore
Title: [215208] trunk/Source/WebCore
Revision 215208
Author mmaxfi...@apple.com
Date 2017-04-10 16:59:41 -0700 (Mon, 10 Apr 2017)
Log Message
Mark SVG-Within-OpenType as "Under Consideration"
https://bugs.webkit.org/show_bug.cgi?id=170706
Reviewed by Brady Eidson.
* features.json:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/features.json
Diff
Modified: trunk/Source/WebCore/ChangeLog (215207 => 215208)
--- trunk/Source/WebCore/ChangeLog 2017-04-10 22:22:39 UTC (rev 215207)
+++ trunk/Source/WebCore/ChangeLog 2017-04-10 23:59:41 UTC (rev 215208)
@@ -1,3 +1,12 @@
+2017-04-10 Myles C. Maxfield
+
+Mark SVG-Within-OpenType as "Under Consideration"
+https://bugs.webkit.org/show_bug.cgi?id=170706
+
+Reviewed by Brady Eidson.
+
+* features.json:
+
2017-04-10 Jeremy Jones
Add CoreAudioCaptureSource.
Modified: trunk/Source/WebCore/features.json (215207 => 215208)
--- trunk/Source/WebCore/features.json 2017-04-10 22:22:39 UTC (rev 215207)
+++ trunk/Source/WebCore/features.json 2017-04-10 23:59:41 UTC (rev 215208)
@@ -470,6 +470,21 @@
}
},
{
+"name": "SVG in OpenType Fonts",
+"status": {
+"status": "Under Consideration"
+},
+"url": "https://www.microsoft.com/typography/otspec/svg.htm/",
+"keywords": ["svg", "font", "opentype", "OT-SVG"],
+"category": "rendering",
+"description": "Allows Scalable Vector Graphics content within font files.",
+"contact": {
+"name": "Myles C. Maxfield",
+"twitter": "@Litherum",
+"email": "mmaxfi...@apple.com"
+}
+},
+{
"name": "Service Workers",
"status": {
"status": "Under Consideration"
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [215209] trunk
Title: [215209] trunk
Revision 215209
Author achristen...@apple.com
Date 2017-04-10 17:11:15 -0700 (Mon, 10 Apr 2017)
Log Message
Add API to get available content extension identifiers in a WKContentExtensionStore
https://bugs.webkit.org/show_bug.cgi?id=170093
Reviewed by Geoffrey Garen.
Source/WebKit2:
* UIProcess/API/APIContentExtensionStore.cpp:
(API::constructedPathPrefix):
(API::constructedPathFilter):
(API::constructedPath):
(API::ContentExtensionStore::getAvailableContentExtensionIdentifiers):
* UIProcess/API/APIContentExtensionStore.h:
* UIProcess/API/Cocoa/WKContentExtensionStore.h:
* UIProcess/API/Cocoa/WKContentExtensionStore.mm:
(-[WKContentExtensionStore _compileContentExtensionForIdentifier:encodedContentExtension:completionHandler:releasesArgument:]):
(-[WKContentExtensionStore lookUpContentExtensionForIdentifier:completionHandler:]):
(-[WKContentExtensionStore getAvailableContentExtensionIdentifiers:]):
(-[WKContentExtensionStore removeContentExtensionForIdentifier:completionHandler:]):
Tools:
* TestWebKitAPI/Tests/WebKit2Cocoa/WKUserContentExtensionStore.mm:
(TEST_F):
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/APIContentExtensionStore.cpp
trunk/Source/WebKit2/UIProcess/API/APIContentExtensionStore.h
trunk/Source/WebKit2/UIProcess/API/Cocoa/WKContentExtensionStore.h
trunk/Source/WebKit2/UIProcess/API/Cocoa/WKContentExtensionStore.mm
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/WKUserContentExtensionStore.mm
Diff
Modified: trunk/Source/WebKit2/ChangeLog (215208 => 215209)
--- trunk/Source/WebKit2/ChangeLog 2017-04-10 23:59:41 UTC (rev 215208)
+++ trunk/Source/WebKit2/ChangeLog 2017-04-11 00:11:15 UTC (rev 215209)
@@ -1,3 +1,23 @@
+2017-04-10 Alex Christensen
+
+Add API to get available content extension identifiers in a WKContentExtensionStore
+https://bugs.webkit.org/show_bug.cgi?id=170093
+
+Reviewed by Geoffrey Garen.
+
+* UIProcess/API/APIContentExtensionStore.cpp:
+(API::constructedPathPrefix):
+(API::constructedPathFilter):
+(API::constructedPath):
+(API::ContentExtensionStore::getAvailableContentExtensionIdentifiers):
+* UIProcess/API/APIContentExtensionStore.h:
+* UIProcess/API/Cocoa/WKContentExtensionStore.h:
+* UIProcess/API/Cocoa/WKContentExtensionStore.mm:
+(-[WKContentExtensionStore _compileContentExtensionForIdentifier:encodedContentExtension:completionHandler:releasesArgument:]):
+(-[WKContentExtensionStore lookUpContentExtensionForIdentifier:completionHandler:]):
+(-[WKContentExtensionStore getAvailableContentExtensionIdentifiers:]):
+(-[WKContentExtensionStore removeContentExtensionForIdentifier:completionHandler:]):
+
2017-04-10 Jeremy Jones
Add CoreAudioCaptureSource.
Modified: trunk/Source/WebKit2/UIProcess/API/APIContentExtensionStore.cpp (215208 => 215209)
--- trunk/Source/WebKit2/UIProcess/API/APIContentExtensionStore.cpp 2017-04-10 23:59:41 UTC (rev 215208)
+++ trunk/Source/WebKit2/UIProcess/API/APIContentExtensionStore.cpp 2017-04-11 00:11:15 UTC (rev 215209)
@@ -75,9 +75,20 @@
{
}
+static const String& constructedPathPrefix()
+{
+static NeverDestroyed prefix("ContentExtension-");
+return prefix;
+}
+
+static const String constructedPathFilter()
+{
+return makeString(constructedPathPrefix(), '*');
+}
+
static String constructedPath(const String& base, const String& identifier)
{
-return WebCore::pathByAppendingComponent(base, "ContentExtension-" + WebCore::encodeForFileName(identifier));
+return WebCore::pathByAppendingComponent(base, makeString(constructedPathPrefix(), WebCore::encodeForFileName(identifier)));
}
// The size and offset of the densely packed bytes in the file, not sizeof and offsetof, which would
@@ -378,6 +389,23 @@
});
}
+void ContentExtensionStore::getAvailableContentExtensionIdentifiers(Function)> completionHandler)
+{
+m_readQueue->dispatch([protectedThis = makeRef(*this), storePath = m_storePath.isolatedCopy(), completionHandler = WTFMove(completionHandler)]() mutable {
+
+Vector fullPaths = WebCore::listDirectory(storePath, constructedPathFilter());
+Vector identifiers;
+identifiers.reserveInitialCapacity(fullPaths.size());
+const auto prefixLength = constructedPathPrefix().length();
+for (const auto& path : fullPaths)
+identifiers.uncheckedAppend(path.substring(path.reverseFind('/') + 1 + prefixLength));
+
+RunLoop::main().dispatch([protectedThis = WTFMove(protectedThis), completionHandler = WTFMove(completionHandler), identifiers = WTFMove(identifiers)]() mutable {
+completionHandler(WTFMove(identifiers));
+});
+});
+}
+
void ContentExtensionStore::compileContentExtension(const WTF::String& identifier, WTF::String&& json, Function, std::error_code)> completionHandler)
{
AtomicString::init();
[webkit-changes] [215210] trunk/LayoutTests
Title: [215210] trunk/LayoutTests Revision 215210 Author ryanhad...@apple.com Date 2017-04-10 17:23:03 -0700 (Mon, 10 Apr 2017) Log Message Mark two newly imported web-platform-tests as failing. Unreviewed test gardening. * TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (215209 => 215210) --- trunk/LayoutTests/ChangeLog 2017-04-11 00:11:15 UTC (rev 215209) +++ trunk/LayoutTests/ChangeLog 2017-04-11 00:23:03 UTC (rev 215210) @@ -1,5 +1,13 @@ 2017-04-10 Ryan Haddad +Mark two newly imported web-platform-tests as failing. + +Unreviewed test gardening. + +* TestExpectations: + +2017-04-10 Ryan Haddad + Mark media/modern-media-controls/volume-slider/volume-slider-value.html as flaky. https://bugs.webkit.org/show_bug.cgi?id=167475 Modified: trunk/LayoutTests/TestExpectations (215209 => 215210) --- trunk/LayoutTests/TestExpectations 2017-04-11 00:11:15 UTC (rev 215209) +++ trunk/LayoutTests/TestExpectations 2017-04-11 00:23:03 UTC (rev 215210) @@ -1250,3 +1250,7 @@ # Only relevant on Mac-WK2 compositing/tiling/non-visible-window-tile-coverage.html [ Skip ] + +webkit.org/b/170698 [ Debug ] imported/w3c/web-platform-tests/IndexedDB/interleaved-cursors.html [ Failure ] + +webkit.org/b/170699 [ Debug ] imported/w3c/web-platform-tests/html/webappapis/timers/negative-settimeout.html [ Failure ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [215211] trunk/Source/WebCore
Title: [215211] trunk/Source/WebCore Revision 215211 Author commit-qu...@webkit.org Date 2017-04-10 17:24:17 -0700 (Mon, 10 Apr 2017) Log Message CachedImage should stop decoding images when unknown type is detected https://bugs.webkit.org/show_bug.cgi?id=170530 Patch by Said Abou-Hallawa on 2017-04-10 Reviewed by Tim Horton. If the status of the encoded data is "unknown type", WebKit should stop decoding the rest of the data. Ideally WebKit should also cancel loading the rest of the encoded data. To do that we need to add a function to the ImageDecoder to return the encodedDataStatus(). We also need to change the return type of Image::setData() and Image::dataChanged() form bool to EncodedDataStatus. * WebCore.xcodeproj/project.pbxproj: Add ImageTypes.h to the WebCore project. * loader/cache/CachedImage.cpp: (WebCore::CachedImage::addIncrementalDataBuffer): Replace checking !sizeAvailable by checking if encodedDataStatus isn't an error but it has not reached sizeAvailable state * loader/cache/CachedResourceClientWalker.h: (WebCore::CachedResourceClientWalker::CachedResourceClientWalker): Unrelated clean-up. (WebCore::CachedResourceClientWalker::next): Ditto. * loader/icon/IconRecord.cpp: (WebCore::IconRecord::setImageData): Image::setData() used to return a bool. Now it returns an EncodedDataStatus. !setData() now means setData() < EncodedDataStatus::SizeAvailable. * platform/graphics/BitmapImage.cpp: (WebCore::BitmapImage::dataChanged): Replace the return of dataChanged() from bool by EncodedDataStatus. * platform/graphics/BitmapImage.h: Replace isSizeAvailable() by a new function named encodedDataStatus(). * platform/graphics/Image.cpp: (WebCore::Image::setData): Code clean-up and adding a clarification comment. * platform/graphics/Image.h: Change the return of setData() and dataChanged() to be EncodedDataStatus. (WebCore::Image::dataChanged): Return EncodedDataStatus::Unknown as an indication the size is not available but we do not have an error. * platform/graphics/ImageTypes.h: Added. Image definitions which are shared among Image, ImageDecoder, ImageSource, ImageFrameCache and ImageFrame used to be added to ImageFrame.h. This has been annoying since these definitions aren't related to ImageFrame only. A new header file named ImageTypes.h is to the to include such definitions. (WebCore::operator++): * platform/graphics/ImageFrame.h: (WebCore::operator++): Deleted. * platform/graphics/ImageFrameCache.cpp: (WebCore::ImageFrameCache::ImageFrameCache): This is the case of a BitmapImage without a decoder but with a NativeImage. The status has to be EncodedDataStatus::Complete. (WebCore::ImageFrameCache::growFrames): Replace if (isSizeAvailable()) by if (encodedDataStatus() >= EncodedDataStatus::SizeAvailable). (WebCore::ImageFrameCache::metadata): Ditto. (WebCore::ImageFrameCache::encodedDataStatus): This is a replacement for isSizeAvailable(). Don't cache the EncodedDataStatus until it is Complete. Don't call didDecodeProperties() until the status >= EncodedDataStatus::SizeAvailable. (WebCore::ImageFrameCache::isSizeAvailable): Deleted. * platform/graphics/ImageFrameCache.h: Replace isSizeAvailable() by encodedDataStatus(). * platform/graphics/ImageSource.cpp: (WebCore::ImageSource::dataChanged): Make return an EncodedDataStatus instead of returning a bool for isSizeAvailable. * platform/graphics/ImageSource.h: (WebCore::ImageSource::encodedDataStatus): Replace isSizeAvailable() by encodedDataStatus(). (WebCore::ImageSource::isSizeAvailable): Deleted. * platform/graphics/cg/ImageDecoderCG.cpp: (WebCore::ImageDecoder::encodedDataStatus): Replace isSizeAvailable() by encodedDataStatus(). The logic of this function is the following: -- CGImageSourceGetStatus() can return kCGImageStatusUnexpectedEOF, kCGImageStatusInvalidData or kCGImageStatusReadingHeader even if CG will end up recovering form the error and drawing the image. Actually CG initializes the status of CGImageSource before receiving any data with kCGImageStatusInvalidData. So the status will be considered an error only if all the data is received but CG does not move the status of this CGImageSource to Complete. -- If CGImageSourceGetStatus() returns Incomplete, this means CG already created the image reader and therefore the image type is known. -- If CGImageSourceGetStatus() returns UnknownType, this means CG could not create the image reader and this should be considered an error. (WebCore::ImageDecoder::isSizeAvailable): Deleted. * platform/graphics/cg/ImageDecoderCG.h: Replace isSizeAvailable() by encodedDataStatus(). * platform/graphics/cg/PDFDocumentImage.cpp: (WebCore::PDFDocumentImage::dataChanged): The PDFDocument is created only when allDataReceived. * platform/graphics/cg/PDFDocumentImage.h: Change the return type from bool to EncodedDataStatus. * platform/image-decoders/ImageDecoder.h: (WebCore::ImageDecoder::encodedDataStatus): Add a new function encodedDataStatus(). Deduce the stat
[webkit-changes] [215212] trunk
Title: [215212] trunk Revision 215212 Author commit-qu...@webkit.org Date 2017-04-10 17:40:00 -0700 (Mon, 10 Apr 2017) Log Message REGRESSION(r195479) First main resource load in new WebProcess bypasses content extensions https://bugs.webkit.org/show_bug.cgi?id=170707 Patch by Alex Christensen on 2017-04-10 Reviewed by Tim Horton. Source/WebKit2: We fix this by sending the UserContentController with the WebPageCreationParameters instead of in a IPC message immediately following creation. By the time the WebPage receives its second message, it has already started loading the first main resource. I also changed all instances of calling ChildProcessProxy::connection() to send a message in favor of calling ChildProcessProxy::send, which does the same thing except if a child process has not started, it will put the message in a queue and send it when the process is finished launching. This was necessary because the UserContentController is now connected to the process sooner, so there were some API tests that would try to send messages between initiating a process launch and finishing a process launch, and this change preserves the existing behavior in those cases. * Shared/WebPageCreationParameters.cpp: (WebKit::WebPageCreationParameters::encode): (WebKit::WebPageCreationParameters::decode): * Shared/WebPageCreationParameters.h: * UIProcess/Databases/DatabaseProcessProxy.cpp: (WebKit::DatabaseProcessProxy::getDatabaseProcessConnection): (WebKit::DatabaseProcessProxy::didFinishLaunching): * UIProcess/Downloads/DownloadProxy.cpp: (WebKit::DownloadProxy::cancel): (WebKit::DownloadProxy::canAuthenticateAgainstProtectionSpace): (WebKit::DownloadProxy::willSendRequest): (WebKit::DownloadProxy::decideDestinationWithSuggestedFilenameAsync): * UIProcess/UserContent/WebUserContentControllerProxy.cpp: (WebKit::WebUserContentControllerProxy::addProcess): (WebKit::WebUserContentControllerProxy::addUserContentWorldUse): (WebKit::WebUserContentControllerProxy::removeUserContentWorldUses): (WebKit::WebUserContentControllerProxy::addUserScript): (WebKit::WebUserContentControllerProxy::removeUserScript): (WebKit::WebUserContentControllerProxy::removeAllUserScripts): (WebKit::WebUserContentControllerProxy::addUserStyleSheet): (WebKit::WebUserContentControllerProxy::removeUserStyleSheet): (WebKit::WebUserContentControllerProxy::removeAllUserStyleSheets): (WebKit::WebUserContentControllerProxy::addUserScriptMessageHandler): (WebKit::WebUserContentControllerProxy::removeUserMessageHandlerForName): (WebKit::WebUserContentControllerProxy::removeAllUserMessageHandlers): (WebKit::WebUserContentControllerProxy::addContentExtension): (WebKit::WebUserContentControllerProxy::removeContentExtension): (WebKit::WebUserContentControllerProxy::removeAllContentExtensions): * UIProcess/UserContent/WebUserContentControllerProxy.h: * UIProcess/VisitedLinkStore.cpp: (WebKit::VisitedLinkStore::removeAll): (WebKit::VisitedLinkStore::pendingVisitedLinksTimerFired): (WebKit::VisitedLinkStore::sendTable): * UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::finishInitializingWebPageAfterProcessLaunch): (WebKit::WebPageProxy::creationParameters): * UIProcess/WebProcessProxy.cpp: (WebKit::WebProcessProxy::addWebUserContentControllerProxy): * UIProcess/WebProcessProxy.h: * WebProcess/UserContent/WebUserContentController.h: * WebProcess/WebPage/WebPage.cpp: (WebKit::m_backgroundCPULimit): Tools: * TestWebKitAPI/Tests/WebKit2Cocoa/WKUserContentExtensionStore.mm: (-[ContentExtensionDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]): (TEST_F): * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm: (-[ContentBlockingWebsitePoliciesDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]): (-[ContentBlockingWebsitePoliciesDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]): (TEST): Modified Paths trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/Shared/WebPageCreationParameters.cpp trunk/Source/WebKit2/Shared/WebPageCreationParameters.h trunk/Source/WebKit2/UIProcess/Databases/DatabaseProcessProxy.cpp trunk/Source/WebKit2/UIProcess/Downloads/DownloadProxy.cpp trunk/Source/WebKit2/UIProcess/UserContent/WebUserContentControllerProxy.cpp trunk/Source/WebKit2/UIProcess/UserContent/WebUserContentControllerProxy.h trunk/Source/WebKit2/UIProcess/VisitedLinkStore.cpp trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp trunk/Source/WebKit2/UIProcess/WebProcessProxy.cpp trunk/Source/WebKit2/UIProcess/WebProcessProxy.h trunk/Source/WebKit2/WebProcess/UserContent/WebUserContentController.h trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp trunk/Tools/ChangeLog trunk/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/WKUserContentExtensionStore.mm trunk/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm Diff Modified: trunk/Source/WebKit2/ChangeLog (215211 => 215212) --- trunk/Source/WebKit2/ChangeLog 2017-04-11 00:24:17 UTC (rev 215211) +++ trunk/Source/WebKit2/Cha
[webkit-changes] [215213] trunk/LayoutTests
Title: [215213] trunk/LayoutTests Revision 215213 Author jiewen_...@apple.com Date 2017-04-10 18:14:15 -0700 (Mon, 10 Apr 2017) Log Message Unreviewed, test expectations update * platform/wk2/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/wk2/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (215212 => 215213) --- trunk/LayoutTests/ChangeLog 2017-04-11 00:40:00 UTC (rev 215212) +++ trunk/LayoutTests/ChangeLog 2017-04-11 01:14:15 UTC (rev 215213) @@ -1,3 +1,9 @@ +2017-04-10 Jiewen Tan + +Unreviewed, test expectations update + +* platform/wk2/TestExpectations: + 2017-04-10 Ryan Haddad Mark two newly imported web-platform-tests as failing. Modified: trunk/LayoutTests/platform/wk2/TestExpectations (215212 => 215213) --- trunk/LayoutTests/platform/wk2/TestExpectations 2017-04-11 00:40:00 UTC (rev 215212) +++ trunk/LayoutTests/platform/wk2/TestExpectations 2017-04-11 01:14:15 UTC (rev 215213) @@ -207,9 +207,7 @@ webkit.org/b/149087 http/tests/cache/disk-cache/disk-cache-cancel.html [ Pass Failure ] -webkit.org/b/148890 http/tests/contentfiltering/load-substitute-data-from-appcache.html [ Pass Crash ] -# One the bug is fixed, the below test will need a Pass expectation, because it's skipped in root TestExpectations. -webkit.org/b/148890 http/tests/appcache/decide-navigation-policy-after-delay.html [ Pass Crash ] +http/tests/appcache/decide-navigation-policy-after-delay.html [ Pass ] # DatabaseProcess cannot open some of these database filenames (DRT can open the exact same database filenames) webkit.org/b/154681 storage/indexeddb/database-odd-names.html ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [215214] trunk/Tools
Title: [215214] trunk/Tools
Revision 215214
Author aakash_j...@apple.com
Date 2017-04-10 19:49:59 -0700 (Mon, 10 Apr 2017)
Log Message
Add test262 _javascript_Core tests to dashboard
https://bugs.webkit.org/show_bug.cgi?id=170711
Rubber-stamped by Joseph Pecoraro.
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
(WebKitBuildbot): Added test262 JSC tests to dashboard.
Modified Paths
trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js
trunk/Tools/ChangeLog
Diff
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js (215213 => 215214)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js 2017-04-11 01:14:15 UTC (rev 215213)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js 2017-04-11 02:49:59 UTC (rev 215214)
@@ -53,6 +53,8 @@
"Apple El Capitan LLINT CLoop (BuildAndTest)": {heading: "LLINT CLoop (BuildAndTest)"},
"Apple El Capitan Debug JSC (Tests)": {heading: "Debug JSC (Tests)"},
"Apple El Capitan Release JSC (Tests)": {heading: "Release JSC (Tests)"},
+"Apple El Capitan Debug Test262 (Tests)": {heading: "Debug Test262 (Tests)"},
+"Apple El Capitan Release Test262 (Tests)": {heading: "Release Test262 (Tests)"},
}},
"Apple iOS 10 Release (Build)": {platform: Dashboard.Platform.iOS10Device, debug: false, builder: true, architecture: Buildbot.BuildArchitecture.Universal},
"Apple iOS 10 Simulator Release (Build)": {platform: Dashboard.Platform.iOS10Simulator, debug: false, builder: true, architecture: Buildbot.BuildArchitecture.SixtyFourBit},
Modified: trunk/Tools/ChangeLog (215213 => 215214)
--- trunk/Tools/ChangeLog 2017-04-11 01:14:15 UTC (rev 215213)
+++ trunk/Tools/ChangeLog 2017-04-11 02:49:59 UTC (rev 215214)
@@ -1,3 +1,13 @@
+2017-04-10 Aakash Jain
+
+Add test262 _javascript_Core tests to dashboard
+https://bugs.webkit.org/show_bug.cgi?id=170711
+
+Rubber-stamped by Joseph Pecoraro.
+
+* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
+(WebKitBuildbot): Added test262 JSC tests to dashboard.
+
2017-04-10 Alex Christensen
REGRESSION(r195479) First main resource load in new WebProcess bypasses content extensions
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [215215] trunk/Tools
Title: [215215] trunk/Tools
Revision 215215
Author commit-qu...@webkit.org
Date 2017-04-10 20:33:56 -0700 (Mon, 10 Apr 2017)
Log Message
Have parseRevisionProperty use default repo name as the Buildbot key.
https://bugs.webkit.org/show_bug.cgi?id=170696
Patch by Kocsen Chung on 2017-04-10
Reviewed by Daniel Bates.
Previously, we needed to set a key and a fallbackKey when addressing
Buildbot data for Internal. That is no longer necessary as we can make a safe assumption
that the repo name maps exactly to that key for every repository other
than WebKit.
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
Set `key = repositoryName` and only use fallback keys when dealing with WebKit.
Modified Paths
trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js
trunk/Tools/ChangeLog
Diff
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js (215214 => 215215)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js 2017-04-11 02:49:59 UTC (rev 215214)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js 2017-04-11 03:33:56 UTC (rev 215215)
@@ -201,21 +201,21 @@
return property[0] === "got_revision";
});
var branches = this.queue.branches;
+
for (var i = 0; i < branches.length; ++i) {
var repository = branches[i].repository;
var repositoryName = repository.name;
var key;
var fallbackKey;
+
if (repository === Dashboard.Repository.OpenSource) {
key = "WebKit";
fallbackKey = "opensource";
-} else if (repository === Dashboard.Repository.Internal) {
-key = "Internal";
-fallbackKey = "internal";
} else {
key = repositoryName;
fallbackKey = null;
}
+
var revision = parseRevisionProperty(revisionProperty, key, fallbackKey);
this.revision[repositoryName] = revision;
}
Modified: trunk/Tools/ChangeLog (215214 => 215215)
--- trunk/Tools/ChangeLog 2017-04-11 02:49:59 UTC (rev 215214)
+++ trunk/Tools/ChangeLog 2017-04-11 03:33:56 UTC (rev 215215)
@@ -1,3 +1,18 @@
+2017-04-10 Kocsen Chung
+
+Have parseRevisionProperty use default repo name as the Buildbot key.
+https://bugs.webkit.org/show_bug.cgi?id=170696
+
+Reviewed by Daniel Bates.
+
+Previously, we needed to set a key and a fallbackKey when addressing
+Buildbot data for Internal. That is no longer necessary as we can make a safe assumption
+that the repo name maps exactly to that key for every repository other
+than WebKit.
+
+* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
+Set `key = repositoryName` and only use fallback keys when dealing with WebKit.
+
2017-04-10 Aakash Jain
Add test262 _javascript_Core tests to dashboard
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [215216] trunk/Source/WebCore
Title: [215216] trunk/Source/WebCore
Revision 215216
Author commit-qu...@webkit.org
Date 2017-04-10 21:57:59 -0700 (Mon, 10 Apr 2017)
Log Message
PlayerLayerView +layerClass methods should use return type Class.
https://bugs.webkit.org/show_bug.cgi?id=165406
Patch by Jeremy Jones on 2017-04-10
Reviewed by Sam Weinig.
No new tests because not behavior change.
* platform/ios/WebVideoFullscreenInterfaceAVKit.mm:
(WebAVPictureInPicturePlayerLayerView_layerClass):
(WebAVPlayerLayerView_layerClass):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm
Diff
Modified: trunk/Source/WebCore/ChangeLog (215215 => 215216)
--- trunk/Source/WebCore/ChangeLog 2017-04-11 03:33:56 UTC (rev 215215)
+++ trunk/Source/WebCore/ChangeLog 2017-04-11 04:57:59 UTC (rev 215216)
@@ -1,3 +1,16 @@
+2017-04-10 Jeremy Jones
+
+PlayerLayerView +layerClass methods should use return type Class.
+https://bugs.webkit.org/show_bug.cgi?id=165406
+
+Reviewed by Sam Weinig.
+
+No new tests because not behavior change.
+
+* platform/ios/WebVideoFullscreenInterfaceAVKit.mm:
+(WebAVPictureInPicturePlayerLayerView_layerClass):
+(WebAVPlayerLayerView_layerClass):
+
2017-04-10 Said Abou-Hallawa
CachedImage should stop decoding images when unknown type is detected
Modified: trunk/Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm (215215 => 215216)
--- trunk/Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm 2017-04-11 03:33:56 UTC (rev 215215)
+++ trunk/Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm 2017-04-11 04:57:59 UTC (rev 215216)
@@ -351,7 +351,7 @@
@interface WebAVPictureInPicturePlayerLayerView : UIView
@end
-static CALayer* WebAVPictureInPicturePlayerLayerView_layerClass(id, SEL)
+static Class WebAVPictureInPicturePlayerLayerView_layerClass(id, SEL)
{
return [WebAVPlayerLayer class];
}
@@ -374,7 +374,7 @@
@property (retain) UIView* videoView;
@end
-static CALayer *WebAVPlayerLayerView_layerClass(id, SEL)
+static Class WebAVPlayerLayerView_layerClass(id, SEL)
{
return [WebAVPlayerLayer class];
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [215217] trunk
Title: [215217] trunk Revision 215217 Author achristen...@apple.com Date 2017-04-10 22:05:33 -0700 (Mon, 10 Apr 2017) Log Message Continue enabling WebRTC https://bugs.webkit.org/show_bug.cgi?id=170703 Reviewed by Youenn Fablet. Source/_javascript_Core: * Configurations/FeatureDefines.xcconfig: Source/WebCore: * Configurations/FeatureDefines.xcconfig: Source/WebCore/PAL: * Configurations/FeatureDefines.xcconfig: Source/WebKit/mac: * Configurations/FeatureDefines.xcconfig: Source/WebKit2: * Configurations/FeatureDefines.xcconfig: Tools: * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: Modified Paths trunk/Source/_javascript_Core/ChangeLog trunk/Source/_javascript_Core/Configurations/FeatureDefines.xcconfig trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/Configurations/FeatureDefines.xcconfig trunk/Source/WebCore/PAL/ChangeLog trunk/Source/WebCore/PAL/Configurations/FeatureDefines.xcconfig trunk/Source/WebKit/mac/ChangeLog trunk/Source/WebKit/mac/Configurations/FeatureDefines.xcconfig trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/Configurations/FeatureDefines.xcconfig trunk/Tools/ChangeLog trunk/Tools/TestWebKitAPI/Configurations/FeatureDefines.xcconfig Diff Modified: trunk/Source/_javascript_Core/ChangeLog (215216 => 215217) --- trunk/Source/_javascript_Core/ChangeLog 2017-04-11 04:57:59 UTC (rev 215216) +++ trunk/Source/_javascript_Core/ChangeLog 2017-04-11 05:05:33 UTC (rev 215217) @@ -1,3 +1,12 @@ +2017-04-10 Alex Christensen + +Continue enabling WebRTC +https://bugs.webkit.org/show_bug.cgi?id=170703 + +Reviewed by Youenn Fablet. + +* Configurations/FeatureDefines.xcconfig: + 2017-04-10 Mark Lam Move ProbeContext and ProbeFunction out of AbstractMacroAssembler. Modified: trunk/Source/_javascript_Core/Configurations/FeatureDefines.xcconfig (215216 => 215217) --- trunk/Source/_javascript_Core/Configurations/FeatureDefines.xcconfig 2017-04-11 04:57:59 UTC (rev 215216) +++ trunk/Source/_javascript_Core/Configurations/FeatureDefines.xcconfig 2017-04-11 05:05:33 UTC (rev 215217) @@ -197,6 +197,7 @@ ENABLE_WEB_RTC_macosx_Debug = ENABLE_WEB_RTC; ENABLE_WEB_RTC_macosx_Release = ENABLE_WEB_RTC; ENABLE_WEB_RTC_macosx_Production = $(ENABLE_WEB_RTC_macosx_Production_$(TARGET_MAC_OS_X_VERSION_MAJOR)); +ENABLE_WEB_RTC_macosx_Production_101100 = ENABLE_WEB_RTC; ENABLE_WEB_RTC_macosx_Production_101300 = ENABLE_WEB_RTC; ENABLE_WRITABLE_STREAM_API = ENABLE_WRITABLE_STREAM_API; Modified: trunk/Source/WebCore/ChangeLog (215216 => 215217) --- trunk/Source/WebCore/ChangeLog 2017-04-11 04:57:59 UTC (rev 215216) +++ trunk/Source/WebCore/ChangeLog 2017-04-11 05:05:33 UTC (rev 215217) @@ -1,3 +1,12 @@ +2017-04-10 Alex Christensen + +Continue enabling WebRTC +https://bugs.webkit.org/show_bug.cgi?id=170703 + +Reviewed by Youenn Fablet. + +* Configurations/FeatureDefines.xcconfig: + 2017-04-10 Jeremy Jones PlayerLayerView +layerClass methods should use return type Class. Modified: trunk/Source/WebCore/Configurations/FeatureDefines.xcconfig (215216 => 215217) --- trunk/Source/WebCore/Configurations/FeatureDefines.xcconfig 2017-04-11 04:57:59 UTC (rev 215216) +++ trunk/Source/WebCore/Configurations/FeatureDefines.xcconfig 2017-04-11 05:05:33 UTC (rev 215217) @@ -197,6 +197,7 @@ ENABLE_WEB_RTC_macosx_Debug = ENABLE_WEB_RTC; ENABLE_WEB_RTC_macosx_Release = ENABLE_WEB_RTC; ENABLE_WEB_RTC_macosx_Production = $(ENABLE_WEB_RTC_macosx_Production_$(TARGET_MAC_OS_X_VERSION_MAJOR)); +ENABLE_WEB_RTC_macosx_Production_101100 = ENABLE_WEB_RTC; ENABLE_WEB_RTC_macosx_Production_101300 = ENABLE_WEB_RTC; ENABLE_WRITABLE_STREAM_API = ENABLE_WRITABLE_STREAM_API; Modified: trunk/Source/WebCore/PAL/ChangeLog (215216 => 215217) --- trunk/Source/WebCore/PAL/ChangeLog 2017-04-11 04:57:59 UTC (rev 215216) +++ trunk/Source/WebCore/PAL/ChangeLog 2017-04-11 05:05:33 UTC (rev 215217) @@ -1,3 +1,12 @@ +2017-04-10 Alex Christensen + +Continue enabling WebRTC +https://bugs.webkit.org/show_bug.cgi?id=170703 + +Reviewed by Youenn Fablet. + +* Configurations/FeatureDefines.xcconfig: + 2017-04-08 Youenn Fablet WebRTC tests gardening Modified: trunk/Source/WebCore/PAL/Configurations/FeatureDefines.xcconfig (215216 => 215217) --- trunk/Source/WebCore/PAL/Configurations/FeatureDefines.xcconfig 2017-04-11 04:57:59 UTC (rev 215216) +++ trunk/Source/WebCore/PAL/Configurations/FeatureDefines.xcconfig 2017-04-11 05:05:33 UTC (rev 215217) @@ -197,6 +197,7 @@ ENABLE_WEB_RTC_macosx_Debug = ENABLE_WEB_RTC; ENABLE_WEB_RTC_macosx_Release = ENABLE_WEB_RTC; ENABLE_WEB_RTC_macosx_Production = $(ENABLE_WEB_RTC_macosx_Production_$(TARGET_MAC_OS_X_VERSION_MAJOR)); +ENABLE_WEB_RTC_macosx_Production_101100 = ENABLE_WEB_RTC; ENABLE_WEB_RTC_macosx_Production_101300 = ENABLE_WEB_RTC; ENABLE_WRITABLE_STREAM_API = ENABLE_WRITABLE_STREAM_API; Modified: trunk/Source/W
[webkit-changes] [215218] trunk/Source/WebCore
Title: [215218] trunk/Source/WebCore
Revision 215218
Author cdu...@apple.com
Date 2017-04-10 22:46:34 -0700 (Mon, 10 Apr 2017)
Log Message
Fix bad change in r215167.
https://bugs.webkit.org/show_bug.cgi?id=170656
Reviewed by Yusuke Suzuki.
Revert mistake made in r215167.
* rendering/RenderThemeGtk.cpp:
(WebCore::RenderThemeGtk::caretBlinkInterval):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderThemeGtk.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (215217 => 215218)
--- trunk/Source/WebCore/ChangeLog 2017-04-11 05:05:33 UTC (rev 215217)
+++ trunk/Source/WebCore/ChangeLog 2017-04-11 05:46:34 UTC (rev 215218)
@@ -1,3 +1,15 @@
+2017-04-10 Chris Dumez
+
+Fix bad change in r215167.
+https://bugs.webkit.org/show_bug.cgi?id=170656
+
+Reviewed by Yusuke Suzuki.
+
+Revert mistake made in r215167.
+
+* rendering/RenderThemeGtk.cpp:
+(WebCore::RenderThemeGtk::caretBlinkInterval):
+
2017-04-10 Alex Christensen
Continue enabling WebRTC
Modified: trunk/Source/WebCore/rendering/RenderThemeGtk.cpp (215217 => 215218)
--- trunk/Source/WebCore/rendering/RenderThemeGtk.cpp 2017-04-11 05:05:33 UTC (rev 215217)
+++ trunk/Source/WebCore/rendering/RenderThemeGtk.cpp 2017-04-11 05:46:34 UTC (rev 215218)
@@ -1814,7 +1814,7 @@
if (!shouldBlink)
return 0_s;
-return 2_ms * time;
+return 500_us * time;
}
enum StyleColorType { StyleColorBackground, StyleColorForeground };
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [215219] trunk
Title: [215219] trunk Revision 215219 Author achristen...@apple.com Date 2017-04-10 23:18:55 -0700 (Mon, 10 Apr 2017) Log Message Revert r215217 https://bugs.webkit.org/show_bug.cgi?id=170703 Source/_javascript_Core: * Configurations/FeatureDefines.xcconfig: Source/WebCore: * Configurations/FeatureDefines.xcconfig: Source/WebCore/PAL: * Configurations/FeatureDefines.xcconfig: Source/WebKit/mac: * Configurations/FeatureDefines.xcconfig: Source/WebKit2: * Configurations/FeatureDefines.xcconfig: Tools: * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: Modified Paths trunk/Source/_javascript_Core/ChangeLog trunk/Source/_javascript_Core/Configurations/FeatureDefines.xcconfig trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/Configurations/FeatureDefines.xcconfig trunk/Source/WebCore/PAL/ChangeLog trunk/Source/WebCore/PAL/Configurations/FeatureDefines.xcconfig trunk/Source/WebKit/mac/ChangeLog trunk/Source/WebKit/mac/Configurations/FeatureDefines.xcconfig trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/Configurations/FeatureDefines.xcconfig trunk/Tools/ChangeLog trunk/Tools/TestWebKitAPI/Configurations/FeatureDefines.xcconfig Diff Modified: trunk/Source/_javascript_Core/ChangeLog (215218 => 215219) --- trunk/Source/_javascript_Core/ChangeLog 2017-04-11 05:46:34 UTC (rev 215218) +++ trunk/Source/_javascript_Core/ChangeLog 2017-04-11 06:18:55 UTC (rev 215219) @@ -1,5 +1,12 @@ 2017-04-10 Alex Christensen +Revert r215217 +https://bugs.webkit.org/show_bug.cgi?id=170703 + +* Configurations/FeatureDefines.xcconfig: + +2017-04-10 Alex Christensen + Continue enabling WebRTC https://bugs.webkit.org/show_bug.cgi?id=170703 Modified: trunk/Source/_javascript_Core/Configurations/FeatureDefines.xcconfig (215218 => 215219) --- trunk/Source/_javascript_Core/Configurations/FeatureDefines.xcconfig 2017-04-11 05:46:34 UTC (rev 215218) +++ trunk/Source/_javascript_Core/Configurations/FeatureDefines.xcconfig 2017-04-11 06:18:55 UTC (rev 215219) @@ -197,7 +197,6 @@ ENABLE_WEB_RTC_macosx_Debug = ENABLE_WEB_RTC; ENABLE_WEB_RTC_macosx_Release = ENABLE_WEB_RTC; ENABLE_WEB_RTC_macosx_Production = $(ENABLE_WEB_RTC_macosx_Production_$(TARGET_MAC_OS_X_VERSION_MAJOR)); -ENABLE_WEB_RTC_macosx_Production_101100 = ENABLE_WEB_RTC; ENABLE_WEB_RTC_macosx_Production_101300 = ENABLE_WEB_RTC; ENABLE_WRITABLE_STREAM_API = ENABLE_WRITABLE_STREAM_API; Modified: trunk/Source/WebCore/ChangeLog (215218 => 215219) --- trunk/Source/WebCore/ChangeLog 2017-04-11 05:46:34 UTC (rev 215218) +++ trunk/Source/WebCore/ChangeLog 2017-04-11 06:18:55 UTC (rev 215219) @@ -1,3 +1,10 @@ +2017-04-10 Alex Christensen + +Revert r215217 +https://bugs.webkit.org/show_bug.cgi?id=170703 + +* Configurations/FeatureDefines.xcconfig: + 2017-04-10 Chris Dumez Fix bad change in r215167. Modified: trunk/Source/WebCore/Configurations/FeatureDefines.xcconfig (215218 => 215219) --- trunk/Source/WebCore/Configurations/FeatureDefines.xcconfig 2017-04-11 05:46:34 UTC (rev 215218) +++ trunk/Source/WebCore/Configurations/FeatureDefines.xcconfig 2017-04-11 06:18:55 UTC (rev 215219) @@ -197,7 +197,6 @@ ENABLE_WEB_RTC_macosx_Debug = ENABLE_WEB_RTC; ENABLE_WEB_RTC_macosx_Release = ENABLE_WEB_RTC; ENABLE_WEB_RTC_macosx_Production = $(ENABLE_WEB_RTC_macosx_Production_$(TARGET_MAC_OS_X_VERSION_MAJOR)); -ENABLE_WEB_RTC_macosx_Production_101100 = ENABLE_WEB_RTC; ENABLE_WEB_RTC_macosx_Production_101300 = ENABLE_WEB_RTC; ENABLE_WRITABLE_STREAM_API = ENABLE_WRITABLE_STREAM_API; Modified: trunk/Source/WebCore/PAL/ChangeLog (215218 => 215219) --- trunk/Source/WebCore/PAL/ChangeLog 2017-04-11 05:46:34 UTC (rev 215218) +++ trunk/Source/WebCore/PAL/ChangeLog 2017-04-11 06:18:55 UTC (rev 215219) @@ -1,5 +1,12 @@ 2017-04-10 Alex Christensen +Revert r215217 +https://bugs.webkit.org/show_bug.cgi?id=170703 + +* Configurations/FeatureDefines.xcconfig: + +2017-04-10 Alex Christensen + Continue enabling WebRTC https://bugs.webkit.org/show_bug.cgi?id=170703 Modified: trunk/Source/WebCore/PAL/Configurations/FeatureDefines.xcconfig (215218 => 215219) --- trunk/Source/WebCore/PAL/Configurations/FeatureDefines.xcconfig 2017-04-11 05:46:34 UTC (rev 215218) +++ trunk/Source/WebCore/PAL/Configurations/FeatureDefines.xcconfig 2017-04-11 06:18:55 UTC (rev 215219) @@ -197,7 +197,6 @@ ENABLE_WEB_RTC_macosx_Debug = ENABLE_WEB_RTC; ENABLE_WEB_RTC_macosx_Release = ENABLE_WEB_RTC; ENABLE_WEB_RTC_macosx_Production = $(ENABLE_WEB_RTC_macosx_Production_$(TARGET_MAC_OS_X_VERSION_MAJOR)); -ENABLE_WEB_RTC_macosx_Production_101100 = ENABLE_WEB_RTC; ENABLE_WEB_RTC_macosx_Production_101300 = ENABLE_WEB_RTC; ENABLE_WRITABLE_STREAM_API = ENABLE_WRITABLE_STREAM_API; Modified: trunk/Source/WebKit/mac/ChangeLog (215218 => 215219) --- trunk/Source/WebKit/mac/ChangeLog 2017-04-11 05:46:34 UTC (rev 215218) +++ trunk/Source/Web
