[webkit-changes] [215795] trunk/Source/WebInspectorUI
Title: [215795] trunk/Source/WebInspectorUI
Revision 215795
Author nvasil...@apple.com
Date 2017-04-25 23:39:00 -0700 (Tue, 25 Apr 2017)
Log Message
REGRESSION (r209882): Web Inspector: Command-G does not work in the console
https://bugs.webkit.org/show_bug.cgi?id=170555
Reviewed by Brian Burg.
Command-G didn't work in the console when the console content view was in focus. It only
worked when the search input field was focused.
* UserInterface/Views/LogContentView.js:
(WebInspector.LogContentView.prototype.findBannerRevealPreviousResult):
(WebInspector.LogContentView.prototype.highlightPreviousSearchMatch): Added.
(WebInspector.LogContentView.prototype.findBannerRevealNextResult):
(WebInspector.LogContentView.prototype.highlightNextSearchMatch): Added.
Re-introduce highlightPreviousSearchMatch and highlightNextSearchMatch methods that were
removed in r209882.
Modified Paths
trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/Views/LogContentView.js
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (215794 => 215795)
--- trunk/Source/WebInspectorUI/ChangeLog 2017-04-26 06:38:37 UTC (rev 215794)
+++ trunk/Source/WebInspectorUI/ChangeLog 2017-04-26 06:39:00 UTC (rev 215795)
@@ -1,3 +1,22 @@
+2017-04-25 Nikita Vasilyev
+
+REGRESSION (r209882): Web Inspector: Command-G does not work in the console
+https://bugs.webkit.org/show_bug.cgi?id=170555
+
+
+Reviewed by Brian Burg.
+
+Command-G didn't work in the console when the console content view was in focus. It only
+worked when the search input field was focused.
+
+* UserInterface/Views/LogContentView.js:
+(WebInspector.LogContentView.prototype.findBannerRevealPreviousResult):
+(WebInspector.LogContentView.prototype.highlightPreviousSearchMatch): Added.
+(WebInspector.LogContentView.prototype.findBannerRevealNextResult):
+(WebInspector.LogContentView.prototype.highlightNextSearchMatch): Added.
+Re-introduce highlightPreviousSearchMatch and highlightNextSearchMatch methods that were
+removed in r209882.
+
2017-04-25 Joseph Pecoraro
Web Inspector: Network Tab - Sorting by Priority Column hides all rows in the datagrid (uncaught exception)
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/LogContentView.js (215794 => 215795)
--- trunk/Source/WebInspectorUI/UserInterface/Views/LogContentView.js 2017-04-26 06:38:37 UTC (rev 215794)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/LogContentView.js 2017-04-26 06:39:00 UTC (rev 215795)
@@ -229,6 +229,11 @@
findBannerRevealPreviousResult()
{
+this.highlightPreviousSearchMatch();
+}
+
+highlightPreviousSearchMatch()
+{
if (!this.hasPerformedSearch || isEmptyObject(this._searchMatches))
return;
@@ -238,6 +243,11 @@
findBannerRevealNextResult()
{
+this.highlightNextSearchMatch();
+}
+
+highlightNextSearchMatch()
+{
if (!this.hasPerformedSearch || isEmptyObject(this._searchMatches))
return;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [215794] trunk/LayoutTests
Title: [215794] trunk/LayoutTests Revision 215794 Author commit-qu...@webkit.org Date 2017-04-25 23:38:37 -0700 (Tue, 25 Apr 2017) Log Message [mac-wk1 Debug] LayoutTest http/tests/inspector/network/resource-sizes-network.html is a flaky failure https://bugs.webkit.org/show_bug.cgi?id=170953 Patch by Joseph Pecoraro on 2017-04-25 Reviewed by Brian Burg. * http/tests/inspector/network/resource-sizes-disk-cache.html: * http/tests/inspector/network/resource-sizes-network.html: Read the entire data to ensure the load is complete before we notify the frontend. * platform/mac-wk1/TestExpectations: * platform/mac-wk2/TestExpectations: Unflake these tests, they should be more reliable now. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/http/tests/inspector/network/resource-sizes-disk-cache.html trunk/LayoutTests/http/tests/inspector/network/resource-sizes-network.html trunk/LayoutTests/platform/mac-wk1/TestExpectations trunk/LayoutTests/platform/mac-wk2/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (215793 => 215794) --- trunk/LayoutTests/ChangeLog 2017-04-26 06:35:04 UTC (rev 215793) +++ trunk/LayoutTests/ChangeLog 2017-04-26 06:38:37 UTC (rev 215794) @@ -1,3 +1,18 @@ +2017-04-25 Joseph Pecoraro + +[mac-wk1 Debug] LayoutTest http/tests/inspector/network/resource-sizes-network.html is a flaky failure +https://bugs.webkit.org/show_bug.cgi?id=170953 + +Reviewed by Brian Burg. + +* http/tests/inspector/network/resource-sizes-disk-cache.html: +* http/tests/inspector/network/resource-sizes-network.html: +Read the entire data to ensure the load is complete before we notify the frontend. + +* platform/mac-wk1/TestExpectations: +* platform/mac-wk2/TestExpectations: +Unflake these tests, they should be more reliable now. + 2017-04-25 Youenn Fablet fast/mediastream/RTCPeerConnection-icecandidate-event.html is flaky Modified: trunk/LayoutTests/http/tests/inspector/network/resource-sizes-disk-cache.html (215793 => 215794) --- trunk/LayoutTests/http/tests/inspector/network/resource-sizes-disk-cache.html 2017-04-26 06:35:04 UTC (rev 215793) +++ trunk/LayoutTests/http/tests/inspector/network/resource-sizes-disk-cache.html 2017-04-26 06:38:37 UTC (rev 215794) @@ -7,7 +7,7 @@
[webkit-changes] [215793] trunk/Source/WebInspectorUI
Title: [215793] trunk/Source/WebInspectorUI
Revision 215793
Author commit-qu...@webkit.org
Date 2017-04-25 23:35:04 -0700 (Tue, 25 Apr 2017)
Log Message
Web Inspector: Network Tab - Sorting by Priority Column hides all rows in the datagrid (uncaught exception)
https://bugs.webkit.org/show_bug.cgi?id=171312
Patch by Joseph Pecoraro on 2017-04-25
Reviewed by Brian Burg.
* UserInterface/Models/Resource.js:
(WebInspector.Resource.comparePriority):
Provide a helper for compariting NetworkPriority enum values.
* UserInterface/Views/NetworkGridContentView.js:
(WebInspector.NetworkGridContentView):
(WebInspector.NetworkGridContentView.prototype.dataGridSortComparator):
* UserInterface/Views/NetworkTimelineView.js:
(WebInspector.NetworkTimelineView.prototype.dataGridSortComparator):
Custom sort handler for priority.
Modified Paths
trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/Models/Resource.js
trunk/Source/WebInspectorUI/UserInterface/Views/NetworkGridContentView.js
trunk/Source/WebInspectorUI/UserInterface/Views/NetworkTimelineView.js
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (215792 => 215793)
--- trunk/Source/WebInspectorUI/ChangeLog 2017-04-26 05:18:09 UTC (rev 215792)
+++ trunk/Source/WebInspectorUI/ChangeLog 2017-04-26 06:35:04 UTC (rev 215793)
@@ -1,3 +1,22 @@
+2017-04-25 Joseph Pecoraro
+
+Web Inspector: Network Tab - Sorting by Priority Column hides all rows in the datagrid (uncaught exception)
+https://bugs.webkit.org/show_bug.cgi?id=171312
+
+
+Reviewed by Brian Burg.
+
+* UserInterface/Models/Resource.js:
+(WebInspector.Resource.comparePriority):
+Provide a helper for compariting NetworkPriority enum values.
+
+* UserInterface/Views/NetworkGridContentView.js:
+(WebInspector.NetworkGridContentView):
+(WebInspector.NetworkGridContentView.prototype.dataGridSortComparator):
+* UserInterface/Views/NetworkTimelineView.js:
+(WebInspector.NetworkTimelineView.prototype.dataGridSortComparator):
+Custom sort handler for priority.
+
2017-04-25 Nikita Vasilyev
REGRESSION (r214863): Web Inspector: Uncaught Exception when losing focus from a selector field
Modified: trunk/Source/WebInspectorUI/UserInterface/Models/Resource.js (215792 => 215793)
--- trunk/Source/WebInspectorUI/UserInterface/Models/Resource.js 2017-04-26 05:18:09 UTC (rev 215792)
+++ trunk/Source/WebInspectorUI/UserInterface/Models/Resource.js 2017-04-26 06:35:04 UTC (rev 215793)
@@ -169,6 +169,23 @@
}
}
+static comparePriority(a, b)
+{
+console.assert(typeof a === "symbol");
+console.assert(typeof b === "symbol");
+
+const map = {
+[WebInspector.Resource.NetworkPriority.Unknown]: 0,
+[WebInspector.Resource.NetworkPriority.Low]: 1,
+[WebInspector.Resource.NetworkPriority.Medium]: 2,
+[WebInspector.Resource.NetworkPriority.High]: 3,
+};
+
+let aNum = map[a] || 0;
+let bNum = map[b] || 0;
+return aNum - bNum;
+}
+
static displayNameForPriority(priority)
{
switch (priority) {
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/NetworkGridContentView.js (215792 => 215793)
--- trunk/Source/WebInspectorUI/UserInterface/Views/NetworkGridContentView.js 2017-04-26 05:18:09 UTC (rev 215792)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/NetworkGridContentView.js 2017-04-26 06:35:04 UTC (rev 215793)
@@ -117,6 +117,7 @@
this._dataGrid = new WebInspector.TimelineDataGrid(columns, this._contentTreeOutline);
this._dataGrid.addEventListener(WebInspector.DataGrid.Event.SelectedNodeChanged, this._dataGridNodeSelected, this);
+this._dataGrid.sortDelegate = this;
this._dataGrid.sortColumnIdentifier = "requestSent";
this._dataGrid.sortOrder = WebInspector.DataGrid.SortOrder.Ascending;
this._dataGrid.createSettings("network-grid-content-view");
@@ -267,6 +268,16 @@
this.reset();
}
+// TimelineDataGrid sort delegate
+
+dataGridSortComparator(sortColumnIdentifier, sortDirection, node1, node2)
+{
+if (sortColumnIdentifier === "priority")
+return WebInspector.Resource.comparePriority(node1.data.priority, node2.data.priority) * sortDirection;
+
+return null;
+}
+
// Private
_resourceCachingDisabledSettingChanged()
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/NetworkTimelineView.js (215792 => 215793)
--- trunk/Source/WebInspectorUI/UserInterface/Views/NetworkTimelineView.js 2017-04-26 05:18:09 UTC (rev 215792)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/NetworkTimelineView.js 2017-04-26 06:35:04 UTC (rev 215793)
@@ -190,15 +190,20 @@
dataGridSortComparator(sortColumnIdentifier, sortDirection, node1, node2)
{
-if (sortColumnIdentifier !== "name")
-re
[webkit-changes] [215792] trunk/Source/JavaScriptCore
Title: [215792] trunk/Source/_javascript_Core Revision 215792 Author commit-qu...@webkit.org Date 2017-04-25 22:18:09 -0700 (Tue, 25 Apr 2017) Log Message Unhandled enumeration values in IntlDateTimeFormat.cpp https://bugs.webkit.org/show_bug.cgi?id=171241 Patch by Andy VanWagoner on 2017-04-25 Reviewed by JF Bastien. Added some missing cases of the UDateFormatField to partTypeString, and made them conditional to the ICU version that added them. This should remove the warnings that appear on platform builds using the newer system ICU headers. * runtime/IntlDateTimeFormat.cpp: (JSC::IntlDateTimeFormat::partTypeString): Modified Paths trunk/Source/_javascript_Core/ChangeLog trunk/Source/_javascript_Core/runtime/IntlDateTimeFormat.cpp Diff Modified: trunk/Source/_javascript_Core/ChangeLog (215791 => 215792) --- trunk/Source/_javascript_Core/ChangeLog 2017-04-26 04:31:57 UTC (rev 215791) +++ trunk/Source/_javascript_Core/ChangeLog 2017-04-26 05:18:09 UTC (rev 215792) @@ -1,3 +1,18 @@ +2017-04-25 Andy VanWagoner + +Unhandled enumeration values in IntlDateTimeFormat.cpp +https://bugs.webkit.org/show_bug.cgi?id=171241 + +Reviewed by JF Bastien. + +Added some missing cases of the UDateFormatField to partTypeString, +and made them conditional to the ICU version that added them. +This should remove the warnings that appear on platform builds using the +newer system ICU headers. + +* runtime/IntlDateTimeFormat.cpp: +(JSC::IntlDateTimeFormat::partTypeString): + 2017-04-25 Commit Queue Unreviewed, rolling out r215476. Modified: trunk/Source/_javascript_Core/runtime/IntlDateTimeFormat.cpp (215791 => 215792) --- trunk/Source/_javascript_Core/runtime/IntlDateTimeFormat.cpp 2017-04-26 04:31:57 UTC (rev 215791) +++ trunk/Source/_javascript_Core/runtime/IntlDateTimeFormat.cpp 2017-04-26 05:18:09 UTC (rev 215792) @@ -933,6 +933,10 @@ case UDAT_STANDALONE_DAY_FIELD: return "weekday"; case UDAT_AM_PM_FIELD: +#if U_ICU_VERSION_MAJOR_NUM >= 57 +case UDAT_AM_PM_MIDNIGHT_NOON_FIELD: +case UDAT_FLEXIBLE_DAY_PERIOD_FIELD: +#endif return "dayPeriod"; case UDAT_TIMEZONE_FIELD: case UDAT_TIMEZONE_RFC_FIELD: ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [215791] trunk/Source/WebCore
Title: [215791] trunk/Source/WebCore Revision 215791 Author jiewen_...@apple.com Date 2017-04-25 21:31:57 -0700 (Tue, 25 Apr 2017) Log Message [WebCrypto] Enhance ways to convert an ECDSA signature binary into DER format https://bugs.webkit.org/show_bug.cgi?id=171287 Reviewed by Brent Fulgham. Covered by existing tests. * crypto/mac/CryptoAlgorithmECDSAMac.cpp: (WebCore::verifyECDSA): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/crypto/mac/CryptoAlgorithmECDSAMac.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (215790 => 215791) --- trunk/Source/WebCore/ChangeLog 2017-04-26 04:27:53 UTC (rev 215790) +++ trunk/Source/WebCore/ChangeLog 2017-04-26 04:31:57 UTC (rev 215791) @@ -1,3 +1,16 @@ +2017-04-25 Jiewen Tan + +[WebCrypto] Enhance ways to convert an ECDSA signature binary into DER format +https://bugs.webkit.org/show_bug.cgi?id=171287 + + +Reviewed by Brent Fulgham. + +Covered by existing tests. + +* crypto/mac/CryptoAlgorithmECDSAMac.cpp: +(WebCore::verifyECDSA): + 2017-04-25 Brent Fulgham Relax the event firing ASSERT for Attr changes Modified: trunk/Source/WebCore/crypto/mac/CryptoAlgorithmECDSAMac.cpp (215790 => 215791) --- trunk/Source/WebCore/crypto/mac/CryptoAlgorithmECDSAMac.cpp 2017-04-26 04:27:53 UTC (rev 215790) +++ trunk/Source/WebCore/crypto/mac/CryptoAlgorithmECDSAMac.cpp 2017-04-26 04:31:57 UTC (rev 215791) @@ -135,19 +135,34 @@ // FIXME: // Convert the signature into DER format. -// tag + length(1) + tag + length(1) + InitialOctet + r + tag + length(1) + InitialOctet + s +// tag + length(1) + tag + length(1) + InitialOctet(?) + r + tag + length(1) + InitialOctet(?) + s +// Skip any heading 0s of r and s. +size_t rStart = 0; +while (rStart < keyLengthInBytes && !signature[rStart]) +rStart++; +size_t sStart = keyLengthInBytes; +while (rStart < signature.size() && !signature[sStart]) +sStart++; + +// InitialOctet is needed when the first byte of r/s is larger than or equal to 128. +bool rNeedsInitialOctet = signature[rStart] >= 128; +bool sNeedsInitialOctet = signature[sStart] >= 128; + +// Construct the DER signature. Vector newSignature; -newSignature.reserveCapacity(8 + keyLengthInBytes * 2); +newSignature.reserveCapacity(6 + keyLengthInBytes * 3 + rNeedsInitialOctet + sNeedsInitialOctet - rStart - sStart); newSignature.append(SequenceMark); -addEncodedASN1Length(newSignature, 6 + keyLengthInBytes * 2); +addEncodedASN1Length(newSignature, 4 + keyLengthInBytes * 3 + rNeedsInitialOctet + sNeedsInitialOctet - rStart - sStart); newSignature.append(IntegerMark); -addEncodedASN1Length(newSignature, keyLengthInBytes + 1); -newSignature.append(InitialOctet); -newSignature.append(signature.data(), keyLengthInBytes); +addEncodedASN1Length(newSignature, keyLengthInBytes + rNeedsInitialOctet - rStart); +if (rNeedsInitialOctet) +newSignature.append(InitialOctet); +newSignature.append(signature.data() + rStart, keyLengthInBytes - rStart); newSignature.append(IntegerMark); -addEncodedASN1Length(newSignature, keyLengthInBytes + 1); -newSignature.append(InitialOctet); -newSignature.append(signature.data() + keyLengthInBytes, keyLengthInBytes); +addEncodedASN1Length(newSignature, keyLengthInBytes * 2 + sNeedsInitialOctet - sStart); +if (sNeedsInitialOctet) +newSignature.append(InitialOctet); +newSignature.append(signature.data() + sStart, keyLengthInBytes * 2 - sStart); uint32_t valid; CCCryptorStatus status = CCECCryptorVerifyHash(key, digestData.data(), digestData.size(), newSignature.data(), newSignature.size(), &valid); ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [215790] trunk
Title: [215790] trunk
Revision 215790
Author achristen...@apple.com
Date 2017-04-25 21:27:53 -0700 (Tue, 25 Apr 2017)
Log Message
REGRESSION(206450): WebKit2PlatformMouseEvent m_modifierFlags not set
https://bugs.webkit.org/show_bug.cgi?id=171297
Reviewed by Geoffrey Garen.
Source/WebKit2:
* Shared/WebEventConversion.cpp:
(WebKit::WebKit2PlatformMouseEvent::WebKit2PlatformMouseEvent):
Tools:
* TestWebKitAPI/PlatformWebView.h:
* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
* TestWebKitAPI/Tests/WebKit2/EventModifiers.cpp: Added.
(TestWebKitAPI::didFinishLoadForFrame):
(TestWebKitAPI::mouseDidMoveOverElement):
(TestWebKitAPI::setClients):
(TestWebKitAPI::TEST):
* TestWebKitAPI/mac/PlatformWebViewMac.mm:
(TestWebKitAPI::PlatformWebView::simulateRightClick):
(TestWebKitAPI::PlatformWebView::simulateMouseMove):
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/Shared/WebEventConversion.cpp
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/PlatformWebView.h
trunk/Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj
trunk/Tools/TestWebKitAPI/gtk/PlatformWebViewGtk.cpp
trunk/Tools/TestWebKitAPI/mac/PlatformWebViewMac.mm
Added Paths
trunk/Tools/TestWebKitAPI/Tests/WebKit2/EventModifiers.cpp
Diff
Modified: trunk/Source/WebKit2/ChangeLog (215789 => 215790)
--- trunk/Source/WebKit2/ChangeLog 2017-04-26 04:27:37 UTC (rev 215789)
+++ trunk/Source/WebKit2/ChangeLog 2017-04-26 04:27:53 UTC (rev 215790)
@@ -1,3 +1,14 @@
+2017-04-25 Alex Christensen
+
+REGRESSION(206450): WebKit2PlatformMouseEvent m_modifierFlags not set
+https://bugs.webkit.org/show_bug.cgi?id=171297
+
+
+Reviewed by Geoffrey Garen.
+
+* Shared/WebEventConversion.cpp:
+(WebKit::WebKit2PlatformMouseEvent::WebKit2PlatformMouseEvent):
+
2017-04-25 Wenson Hsieh
Unreviewed, speculative build fix
Modified: trunk/Source/WebKit2/Shared/WebEventConversion.cpp (215789 => 215790)
--- trunk/Source/WebKit2/Shared/WebEventConversion.cpp 2017-04-26 04:27:37 UTC (rev 215789)
+++ trunk/Source/WebKit2/Shared/WebEventConversion.cpp 2017-04-26 04:27:53 UTC (rev 215790)
@@ -109,6 +109,15 @@
m_eventNumber = webEvent.eventNumber();
m_menuTypeForEvent = webEvent.menuTypeForEvent();
#endif
+m_modifierFlags = 0;
+if (webEvent.shiftKey())
+m_modifierFlags |= WebEvent::ShiftKey;
+if (webEvent.controlKey())
+m_modifierFlags |= WebEvent::ControlKey;
+if (webEvent.altKey())
+m_modifierFlags |= WebEvent::AltKey;
+if (webEvent.metaKey())
+m_modifierFlags |= WebEvent::MetaKey;
}
};
Modified: trunk/Tools/ChangeLog (215789 => 215790)
--- trunk/Tools/ChangeLog 2017-04-26 04:27:37 UTC (rev 215789)
+++ trunk/Tools/ChangeLog 2017-04-26 04:27:53 UTC (rev 215790)
@@ -1,3 +1,22 @@
+2017-04-25 Alex Christensen
+
+REGRESSION(206450): WebKit2PlatformMouseEvent m_modifierFlags not set
+https://bugs.webkit.org/show_bug.cgi?id=171297
+
+
+Reviewed by Geoffrey Garen.
+
+* TestWebKitAPI/PlatformWebView.h:
+* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
+* TestWebKitAPI/Tests/WebKit2/EventModifiers.cpp: Added.
+(TestWebKitAPI::didFinishLoadForFrame):
+(TestWebKitAPI::mouseDidMoveOverElement):
+(TestWebKitAPI::setClients):
+(TestWebKitAPI::TEST):
+* TestWebKitAPI/mac/PlatformWebViewMac.mm:
+(TestWebKitAPI::PlatformWebView::simulateRightClick):
+(TestWebKitAPI::PlatformWebView::simulateMouseMove):
+
2017-04-25 Wenson Hsieh
Unreviewed, temporarily disable the data interaction unit tests.
Modified: trunk/Tools/TestWebKitAPI/PlatformWebView.h (215789 => 215790)
--- trunk/Tools/TestWebKitAPI/PlatformWebView.h 2017-04-26 04:27:37 UTC (rev 215789)
+++ trunk/Tools/TestWebKitAPI/PlatformWebView.h 2017-04-26 04:27:53 UTC (rev 215790)
@@ -69,7 +69,7 @@
void simulateSpacebarKeyPress();
void simulateAltKeyPress();
void simulateRightClick(unsigned x, unsigned y);
-void simulateMouseMove(unsigned x, unsigned y);
+void simulateMouseMove(unsigned x, unsigned y, WKEventModifiers = 0);
#if PLATFORM(MAC)
void simulateButtonClick(WKEventMouseButton, unsigned x, unsigned y, WKEventModifiers);
#endif
Modified: trunk/Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj (215789 => 215790)
--- trunk/Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj 2017-04-26 04:27:37 UTC (rev 215789)
+++ trunk/Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj 2017-04-26 04:27:53 UTC (rev 215790)
@@ -196,6 +196,7 @@
5C2936961D5C00ED00DEAB1E /* CookieMessage.html in Copy Resources */ = {isa = PBXBuildFile; fileRef = 5C2936941D5BFD1900DEAB1E /* CookieMessage.html */; };
5C6E65441D5CEFD400F7862E /* URLParser.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 5C6E65411D5CEF8500F7862E /* URLParser.cpp */; };
[webkit-changes] [215789] trunk/Source/WebInspectorUI
Title: [215789] trunk/Source/WebInspectorUI
Revision 215789
Author nvasil...@apple.com
Date 2017-04-25 21:27:37 -0700 (Tue, 25 Apr 2017)
Log Message
REGRESSION (r214863): Web Inspector: Uncaught Exception when losing focus from a selector field
https://bugs.webkit.org/show_bug.cgi?id=171254
Reviewed by Joseph Pecoraro.
The event.relatedTarget of a blur event contains the element where focus moved to.
In some cases this can be null, such as if the user leaves the application window.
For example Command+Tab to switch to another application.
* UserInterface/Views/CSSStyleDeclarationSection.js:
(WebInspector.CSSStyleDeclarationSection.prototype._handleSelectorPaste):
Modified Paths
trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/Views/CSSStyleDeclarationSection.js
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (215788 => 215789)
--- trunk/Source/WebInspectorUI/ChangeLog 2017-04-26 04:24:21 UTC (rev 215788)
+++ trunk/Source/WebInspectorUI/ChangeLog 2017-04-26 04:27:37 UTC (rev 215789)
@@ -1,5 +1,20 @@
2017-04-25 Nikita Vasilyev
+REGRESSION (r214863): Web Inspector: Uncaught Exception when losing focus from a selector field
+https://bugs.webkit.org/show_bug.cgi?id=171254
+
+
+Reviewed by Joseph Pecoraro.
+
+The event.relatedTarget of a blur event contains the element where focus moved to.
+In some cases this can be null, such as if the user leaves the application window.
+For example Command+Tab to switch to another application.
+
+* UserInterface/Views/CSSStyleDeclarationSection.js:
+(WebInspector.CSSStyleDeclarationSection.prototype._handleSelectorPaste):
+
+2017-04-25 Nikita Vasilyev
+
Web Inspector: Open the new bug page in the new tab
https://bugs.webkit.org/show_bug.cgi?id=171253
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/CSSStyleDeclarationSection.js (215788 => 215789)
--- trunk/Source/WebInspectorUI/UserInterface/Views/CSSStyleDeclarationSection.js 2017-04-26 04:24:21 UTC (rev 215788)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/CSSStyleDeclarationSection.js 2017-04-26 04:27:37 UTC (rev 215789)
@@ -696,7 +696,7 @@
return;
}
-if (event.relatedTarget.isDescendant(this.element)) {
+if (event.relatedTarget && event.relatedTarget.isDescendant(this.element)) {
this._editorActive = true;
this.focus();
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [215788] trunk/LayoutTests
Title: [215788] trunk/LayoutTests Revision 215788 Author commit-qu...@webkit.org Date 2017-04-25 21:24:21 -0700 (Tue, 25 Apr 2017) Log Message fast/mediastream/RTCPeerConnection-icecandidate-event.html is flaky https://bugs.webkit.org/show_bug.cgi?id=171242 Patch by Youenn Fablet on 2017-04-25 Reviewed by Alex Christensen. * TestExpectations: * fast/mediastream/RTCPeerConnection-icecandidate-event-expected.txt: * fast/mediastream/RTCPeerConnection-icecandidate-event.html: Updating test to be more deterministic. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/TestExpectations trunk/LayoutTests/fast/mediastream/RTCPeerConnection-icecandidate-event-expected.txt trunk/LayoutTests/fast/mediastream/RTCPeerConnection-icecandidate-event.html Diff Modified: trunk/LayoutTests/ChangeLog (215787 => 215788) --- trunk/LayoutTests/ChangeLog 2017-04-26 02:26:05 UTC (rev 215787) +++ trunk/LayoutTests/ChangeLog 2017-04-26 04:24:21 UTC (rev 215788) @@ -1,3 +1,14 @@ +2017-04-25 Youenn Fablet + +fast/mediastream/RTCPeerConnection-icecandidate-event.html is flaky +https://bugs.webkit.org/show_bug.cgi?id=171242 + +Reviewed by Alex Christensen. + +* TestExpectations: +* fast/mediastream/RTCPeerConnection-icecandidate-event-expected.txt: +* fast/mediastream/RTCPeerConnection-icecandidate-event.html: Updating test to be more deterministic. + 2017-04-25 Brent Fulgham Relax the event firing ASSERT for Attr changes Modified: trunk/LayoutTests/TestExpectations (215787 => 215788) --- trunk/LayoutTests/TestExpectations 2017-04-26 02:26:05 UTC (rev 215787) +++ trunk/LayoutTests/TestExpectations 2017-04-26 04:24:21 UTC (rev 215788) @@ -733,7 +733,6 @@ fast/mediastream/RTCPeerConnection-more-media-to-negotiate.html [ Skip ] fast/mediastream/RTCPeerConnection-overloaded-operations-params.html [ Skip ] fast/mediastream/RTCRtpSender-replaceTrack.html [ Skip ] -fast/mediastream/RTCPeerConnection-icecandidate-event.html [ Pass Failure ] fast/mediastream/RTCPeerConnection-dtmf.html [ Failure ] # libwebrtc backend doesn't generate a=bundle-only lines fast/mediastream/RTCPeerConnection-inspect-offer-bundlePolicy-bundle-only.html [ Failure ] Modified: trunk/LayoutTests/fast/mediastream/RTCPeerConnection-icecandidate-event-expected.txt (215787 => 215788) --- trunk/LayoutTests/fast/mediastream/RTCPeerConnection-icecandidate-event-expected.txt 2017-04-26 02:26:05 UTC (rev 215787) +++ trunk/LayoutTests/fast/mediastream/RTCPeerConnection-icecandidate-event-expected.txt 2017-04-26 04:24:21 UTC (rev 215788) @@ -3,25 +3,25 @@ On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE". -PASS Got candidate -PASS event.candidate instanceof RTCIceCandidate is true -PASS event.candidate.sdpMLineIndex is 0 -FAIL event.candidate.sdpMid should be null (of type object). Was 1 (of type string). -PASS event.candidate.candidate: 2013266431 1 udp 2013266432 192.168.0.100 38838 typ host generation 0 PASS Local description set PASS End of test promise chain PASS Got candidate -PASS event.candidate instanceof RTCIceCandidate is true -PASS event.candidate.sdpMLineIndex is 0 -FAIL event.candidate.sdpMid should be null (of type object). Was 1 (of type string). -PASS event.candidate.candidate: 1019216383 1 tcp 1019216384 192.168.0.100 9 typ host tcptype passive generation 0 +PASS candidate instanceof RTCIceCandidate is true +PASS candidate.sdpMLineIndex is 0 +FAIL candidate.sdpMid should be null (of type object). Was 1 (of type string). +PASS candidate.candidate: 2013266431 1 udp 2013266432 192.168.0.100 38838 typ host generation 0 PASS Got candidate -PASS event.candidate instanceof RTCIceCandidate is true -PASS event.candidate.sdpMLineIndex is 0 -FAIL event.candidate.sdpMid should be null (of type object). Was 1 (of type string). -PASS event.candidate.candidate: 1677722111 1 tcp 1677722112 172.18.0.1 47989 typ srflx raddr 192.168.0.100 rport 47989 generation 0 +PASS candidate instanceof RTCIceCandidate is true +PASS candidate.sdpMLineIndex is 0 +FAIL candidate.sdpMid should be null (of type object). Was 1 (of type string). +PASS candidate.candidate: 1019216383 1 tcp 1019216384 192.168.0.100 9 typ host tcptype passive generation 0 +PASS Got candidate +PASS candidate instanceof RTCIceCandidate is true +PASS candidate.sdpMLineIndex is 0 +FAIL candidate.sdpMid should be null (of type object). Was 1 (of type string). +PASS candidate.candidate: 1677722111 1 tcp 1677722112 172.18.0.1 47989 typ srflx raddr 192.168.0.100 rport 47989 generation 0 PASS Got end of candidates -PASS event.candidate is null +PASS candidate is null PASS successfullyParsed is true TEST COMPLETE Modified: trunk/LayoutTests/fast/mediastream/RTCPeerConnection-icecandidate-event.html (215787 => 215788) --- trunk/LayoutTests/fast/mediastream/RTCPeerConnection-icecandidate-event.html 2017-04-26 02:26:05 UTC (rev 215787) +++ trunk/LayoutTests/fast/mediastream/RTCPeer
[webkit-changes] [215787] trunk
Title: [215787] trunk
Revision 215787
Author bfulg...@apple.com
Date 2017-04-25 19:26:05 -0700 (Tue, 25 Apr 2017)
Log Message
Relax the event firing ASSERT for Attr changes
https://bugs.webkit.org/show_bug.cgi?id=171236
Reviewed by Dean Jackson.
Source/WebCore:
The assertions added in Bug 167318 were overly strict, and trigger for valid behavior.
Relax the assertion preventing event dispatch for the case of Attr elements at the
end of childrenChanged.
Test: fast/dom/HTMLLinkElement/event-while-removing-attribute.html
* dom/Attr.cpp:
(WebCore::Attr::childrenChanged):
LayoutTests:
* fast/dom/HTMLLinkElement/event-while-removing-attribute-expected.txt: Added.
* fast/dom/HTMLLinkElement/event-while-removing-attribute.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/Attr.cpp
trunk/Source/WebCore/dom/ContainerNode.cpp
trunk/Source/WebCore/dom/NoEventDispatchAssertion.h
Added Paths
trunk/LayoutTests/fast/dom/HTMLLinkElement/event-while-removing-attribute-expected.txt
trunk/LayoutTests/fast/dom/HTMLLinkElement/event-while-removing-attribute.html
Diff
Modified: trunk/LayoutTests/ChangeLog (215786 => 215787)
--- trunk/LayoutTests/ChangeLog 2017-04-26 02:16:26 UTC (rev 215786)
+++ trunk/LayoutTests/ChangeLog 2017-04-26 02:26:05 UTC (rev 215787)
@@ -1,3 +1,14 @@
+2017-04-25 Brent Fulgham
+
+Relax the event firing ASSERT for Attr changes
+https://bugs.webkit.org/show_bug.cgi?id=171236
+
+
+Reviewed by Dean Jackson.
+
+* fast/dom/HTMLLinkElement/event-while-removing-attribute-expected.txt: Added.
+* fast/dom/HTMLLinkElement/event-while-removing-attribute.html: Added.
+
2017-04-25 Dean Jackson
REGRESSION (r214129): fast/media/mq-prefers-reduced-motion.html fails
Added: trunk/LayoutTests/fast/dom/HTMLLinkElement/event-while-removing-attribute-expected.txt (0 => 215787)
--- trunk/LayoutTests/fast/dom/HTMLLinkElement/event-while-removing-attribute-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/dom/HTMLLinkElement/event-while-removing-attribute-expected.txt 2017-04-26 02:26:05 UTC (rev 215787)
@@ -0,0 +1,14 @@
+Check that we do not Debug ASSERT when modifying attribute data for a link.
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+PASS Before load event handled for original link element.
+PASS Before load event handled for original link element.
+PASS Before load event handled for original link element.
+PASS Before load event handled for original link element.
+PASS successfullyParsed is true
+
+TEST COMPLETE
+PASS Test did not generate a Debug ASSERT.
+
Added: trunk/LayoutTests/fast/dom/HTMLLinkElement/event-while-removing-attribute.html (0 => 215787)
--- trunk/LayoutTests/fast/dom/HTMLLinkElement/event-while-removing-attribute.html (rev 0)
+++ trunk/LayoutTests/fast/dom/HTMLLinkElement/event-while-removing-attribute.html 2017-04-26 02:26:05 UTC (rev 215787)
@@ -0,0 +1,50 @@
+
+
+
+
+description("Check that we do not Debug ASSERT when modifying attribute data for a link.");
+
+function testOriginalBeforeLoad()
+{
+testPassed("Before load event handled for original link element.");
+}
+
+
+
+
+function testBeforeLoad()
+{
+testPassed("Before load event handled.");
+}
+
+function test()
+{
+if (window.testRunner) {
+testRunner.dumpAsText();
+testRunner.waitUntilDone();
+}
+
+var origLink = document.getElementById('link');
+
+var relAttr = origLink.getAttributeNode('rel');
+var textNode = relAttr.childNodes[0];
+
+var newTextNode = document.createTextNode("author");
+
+relAttr.replaceChild(newTextNode, textNode);
+
+setTimeout(step2, 0);
+}
+
+function step2()
+{
+testPassed("Test did not generate a Debug ASSERT.");
+if (window.testRunner)
+testRunner.notifyDone();
+}
+
+
+
+
+
Modified: trunk/Source/WebCore/ChangeLog (215786 => 215787)
--- trunk/Source/WebCore/ChangeLog 2017-04-26 02:16:26 UTC (rev 215786)
+++ trunk/Source/WebCore/ChangeLog 2017-04-26 02:26:05 UTC (rev 215787)
@@ -1,3 +1,20 @@
+2017-04-25 Brent Fulgham
+
+Relax the event firing ASSERT for Attr changes
+https://bugs.webkit.org/show_bug.cgi?id=171236
+
+
+Reviewed by Dean Jackson.
+
+The assertions added in Bug 167318 were overly strict, and trigger for valid behavior.
+Relax the assertion preventing event dispatch for the case of Attr elements at the
+end of childrenChanged.
+
+Test: fast/dom/HTMLLinkElement/event-while-removing-attribute.html
+
+* dom/Attr.cpp:
+(WebCore::Attr::childrenChanged):
+
2017-04-25 John Wilander
Resource Load Statistics: Introduce shorter time-to-live for cookie partition whitelisting
Modified: trunk/Source/WebCore/dom/Attr.cpp (215786 => 215787)
--- trunk/Source/WebCore/dom/Attr.cpp 2017-0
[webkit-changes] [215786] trunk/Source/WebKit2
Title: [215786] trunk/Source/WebKit2 Revision 215786 Author wenson_hs...@apple.com Date 2017-04-25 19:16:26 -0700 (Tue, 25 Apr 2017) Log Message Unreviewed, speculative build fix * UIProcess/API/Cocoa/WKUIDelegatePrivate.h: For the time being, remove all references to UIItemProviders from this private header. This should be fixed to use unavailability macros in a followup. See . Modified Paths trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/UIProcess/API/Cocoa/WKUIDelegatePrivate.h Diff Modified: trunk/Source/WebKit2/ChangeLog (215785 => 215786) --- trunk/Source/WebKit2/ChangeLog 2017-04-26 02:02:43 UTC (rev 215785) +++ trunk/Source/WebKit2/ChangeLog 2017-04-26 02:16:26 UTC (rev 215786) @@ -1,3 +1,12 @@ +2017-04-25 Wenson Hsieh + +Unreviewed, speculative build fix + +* UIProcess/API/Cocoa/WKUIDelegatePrivate.h: + +For the time being, remove all references to UIItemProviders from this private header. +This should be fixed to use unavailability macros in a followup. See . + 2017-04-25 Brent Fulgham Limit allowed size of document.title to avoid locking WebKit clients Modified: trunk/Source/WebKit2/UIProcess/API/Cocoa/WKUIDelegatePrivate.h (215785 => 215786) --- trunk/Source/WebKit2/UIProcess/API/Cocoa/WKUIDelegatePrivate.h 2017-04-26 02:02:43 UTC (rev 215785) +++ trunk/Source/WebKit2/UIProcess/API/Cocoa/WKUIDelegatePrivate.h 2017-04-26 02:16:26 UTC (rev 215786) @@ -32,7 +32,6 @@ #import #import -@class UIItemProvider; @class UIScrollView; @class UIViewController; @class WKFrameInfo; @@ -94,11 +93,11 @@ - (void)_webView:(WKWebView *)webView getAlternateURLFromImage:(UIImage *)image completionHandler:(void (^)(NSURL *alternateURL, NSDictionary *userInfo))completionHandler WK_API_AVAILABLE(ios(WK_IOS_TBA)); - (NSURL *)_webView:(WKWebView *)webView alternateURLFromImage:(UIImage *)image userInfo:(NSDictionary **)userInfo WK_API_AVAILABLE(ios(WK_IOS_TBA)); - (UIViewController *)_webView:(WKWebView *)webView previewViewControllerForImage:(UIImage *)image alternateURL:(NSURL *)url defaultActions:(NSArray<_WKElementAction *> *)actions elementInfo:(_WKActivatedElementInfo *)elementInfo WK_API_AVAILABLE(ios(WK_IOS_TBA)); -- (NSArray *)_webView:(WKWebView *)webView adjustedDataInteractionItemProviders:(NSArray *)originalItemProviders WK_API_AVAILABLE(ios(WK_IOS_TBA)); -- (BOOL)_webView:(WKWebView *)webView performDataInteractionOperationWithItemProviders:(NSArray *)itemProviders WK_API_AVAILABLE(ios(WK_IOS_TBA)); +- (NSArray *)_webView:(WKWebView *)webView adjustedDataInteractionItemProviders:(NSArray *)originalItemProviders WK_API_AVAILABLE(ios(WK_IOS_TBA)); +- (BOOL)_webView:(WKWebView *)webView performDataInteractionOperationWithItemProviders:(NSArray *)itemProviders WK_API_AVAILABLE(ios(WK_IOS_TBA)); - (void)_webView:(WKWebView *)webView dataInteraction:(id)interaction sessionWillBegin:(id)session WK_API_AVAILABLE(ios(WK_IOS_TBA)); - (void)_webView:(WKWebView *)webView dataInteraction:(id)interaction session:(id)session didEndWithOperation:(NSUInteger)operation WK_API_AVAILABLE(ios(WK_IOS_TBA)); -- (void)_webView:(WKWebView *)webView dataInteractionOperationWasHandled:(BOOL)handled forSession:(id)session itemProviders:(NSArray *)itemProviders WK_API_AVAILABLE(ios(WK_IOS_TBA)); +- (void)_webView:(WKWebView *)webView dataInteractionOperationWasHandled:(BOOL)handled forSession:(id)session itemProviders:(NSArray *)itemProviders WK_API_AVAILABLE(ios(WK_IOS_TBA)); - (NSUInteger)_webView:(WKWebView *)webView willUpdateDataInteractionOperationToOperation:(NSUInteger)operation forSession:(id)session WK_API_AVAILABLE(ios(WK_IOS_TBA)); #else - (NSMenu *)_webView:(WKWebView *)webView contextMenu:(NSMenu *)menu forElement:(_WKContextMenuElementInfo *)element WK_API_AVAILABLE(macosx(10.12)); ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [215785] trunk/Tools
Title: [215785] trunk/Tools Revision 215785 Author wenson_hs...@apple.com Date 2017-04-25 19:02:43 -0700 (Tue, 25 Apr 2017) Log Message Unreviewed, temporarily disable the data interaction unit tests. The API around data interaction will change significantly in the near future, and these tests will begin to fail. These will be reenabled once the bots are on an SDK that supports the updated data interaction API. * TestWebKitAPI/Tests/ios/DataInteractionTests.mm: * TestWebKitAPI/ios/DataInteractionSimulator.h: * TestWebKitAPI/ios/DataInteractionSimulator.mm: Modified Paths trunk/Tools/ChangeLog trunk/Tools/TestWebKitAPI/Tests/ios/DataInteractionTests.mm trunk/Tools/TestWebKitAPI/ios/DataInteractionSimulator.h trunk/Tools/TestWebKitAPI/ios/DataInteractionSimulator.mm Diff Modified: trunk/Tools/ChangeLog (215784 => 215785) --- trunk/Tools/ChangeLog 2017-04-26 01:53:06 UTC (rev 215784) +++ trunk/Tools/ChangeLog 2017-04-26 02:02:43 UTC (rev 215785) @@ -1,3 +1,15 @@ +2017-04-25 Wenson Hsieh + +Unreviewed, temporarily disable the data interaction unit tests. + +The API around data interaction will change significantly in the near future, and +these tests will begin to fail. These will be reenabled once the bots are on an SDK +that supports the updated data interaction API. + +* TestWebKitAPI/Tests/ios/DataInteractionTests.mm: +* TestWebKitAPI/ios/DataInteractionSimulator.h: +* TestWebKitAPI/ios/DataInteractionSimulator.mm: + 2017-04-25 Brent Fulgham Limit allowed size of document.title to avoid locking WebKit clients Modified: trunk/Tools/TestWebKitAPI/Tests/ios/DataInteractionTests.mm (215784 => 215785) --- trunk/Tools/TestWebKitAPI/Tests/ios/DataInteractionTests.mm 2017-04-26 01:53:06 UTC (rev 215784) +++ trunk/Tools/TestWebKitAPI/Tests/ios/DataInteractionTests.mm 2017-04-26 02:02:43 UTC (rev 215785) @@ -25,7 +25,7 @@ #include "config.h" -#if ENABLE(DATA_INTERACTION) +#if 0 #import "DataInteractionSimulator.h" #import "PlatformUtilities.h" Modified: trunk/Tools/TestWebKitAPI/ios/DataInteractionSimulator.h (215784 => 215785) --- trunk/Tools/TestWebKitAPI/ios/DataInteractionSimulator.h 2017-04-26 01:53:06 UTC (rev 215784) +++ trunk/Tools/TestWebKitAPI/ios/DataInteractionSimulator.h 2017-04-26 02:02:43 UTC (rev 215785) @@ -23,7 +23,7 @@ * THE POSSIBILITY OF SUCH DAMAGE. */ -#if ENABLE(DATA_INTERACTION) +#if 0 #import "TestWKWebView.h" #import Modified: trunk/Tools/TestWebKitAPI/ios/DataInteractionSimulator.mm (215784 => 215785) --- trunk/Tools/TestWebKitAPI/ios/DataInteractionSimulator.mm 2017-04-26 01:53:06 UTC (rev 215784) +++ trunk/Tools/TestWebKitAPI/ios/DataInteractionSimulator.mm 2017-04-26 02:02:43 UTC (rev 215785) @@ -26,7 +26,7 @@ #include "config.h" #include "DataInteractionSimulator.h" -#if ENABLE(DATA_INTERACTION) +#if 0 #import "InstanceMethodSwizzler.h" #import "PlatformUtilities.h" ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [215784] trunk
Title: [215784] trunk
Revision 215784
Author bfulg...@apple.com
Date 2017-04-25 18:53:06 -0700 (Tue, 25 Apr 2017)
Log Message
Limit allowed size of document.title to avoid locking WebKit clients
https://bugs.webkit.org/show_bug.cgi?id=165113
Reviewed by Darin Adler.
Source/WebKit/mac:
When a web application attempts to set an extremely long title, truncate the
title to a more reasonable size.
We do this at at the presentation layer, rather than in the DOM, so that we do
not affect script function. Instead, we merely limit display to a level that is
reasonable for normal GUI widgets. Anything else needs to be truncated in the UI
layer, so it is a waste of effort to send across IPC.
* WebCoreSupport/WebFrameLoaderClient.h:
* WebCoreSupport/WebFrameLoaderClient.mm:
(WebFrameLoaderClient::dispatchDidReceiveTitle):
Source/WebKit2:
When a web application attempts to set an extremely long title, truncate the
title to a more reasonable size.
We do this at at the presentation layer, rather than in the DOM, so that we do
not affect script function. Instead, we merely limit display to a level that is
reasonable for normal GUI widgets. Anything else needs to be truncated in the UI
layer, so it is a waste of effort to send across IPC.
* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::dispatchDidReceiveTitle):
* WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
Tools:
* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add new files.
* TestWebKitAPI/Tests/WebKit2/LimitTitleSize.cpp: Added.
* TestWebKitAPI/Tests/WebKit2/set-long-title.html: Added.
* TestWebKitAPI/Tests/mac/LimitTitleSize.mm: Added.
Modified Paths
trunk/Source/WebCore/platform/text/StringWithDirection.h
trunk/Source/WebKit/mac/ChangeLog
trunk/Source/WebKit/mac/WebCoreSupport/WebFrameLoaderClient.mm
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj
Added Paths
trunk/Tools/TestWebKitAPI/Tests/WebKit2/LimitTitleSize.cpp
trunk/Tools/TestWebKitAPI/Tests/WebKit2/set-long-title.html
trunk/Tools/TestWebKitAPI/Tests/mac/LimitTitleSize.mm
Diff
Modified: trunk/Source/WebCore/platform/text/StringWithDirection.h (215783 => 215784)
--- trunk/Source/WebCore/platform/text/StringWithDirection.h 2017-04-26 01:45:04 UTC (rev 215783)
+++ trunk/Source/WebCore/platform/text/StringWithDirection.h 2017-04-26 01:53:06 UTC (rev 215784)
@@ -1,5 +1,6 @@
/*
* Copyright (C) 2011 Google Inc. All rights reserved.
+ * Copyright (C) 2017 Apple Inc. All rights reserved.
*
* Redistribution and use in source and binary forms, with or without
* modification, are permitted provided that the following conditions are
@@ -62,4 +63,11 @@
return !(a == b);
}
+inline StringWithDirection truncateFromEnd(const StringWithDirection& string, unsigned maxLength)
+{
+if (string.direction == LTR)
+return StringWithDirection(string.string.left(maxLength), LTR);
+return StringWithDirection(string.string.right(maxLength), RTL);
}
+
+}
Modified: trunk/Source/WebKit/mac/ChangeLog (215783 => 215784)
--- trunk/Source/WebKit/mac/ChangeLog 2017-04-26 01:45:04 UTC (rev 215783)
+++ trunk/Source/WebKit/mac/ChangeLog 2017-04-26 01:53:06 UTC (rev 215784)
@@ -1,3 +1,23 @@
+2017-04-25 Brent Fulgham
+
+Limit allowed size of document.title to avoid locking WebKit clients
+https://bugs.webkit.org/show_bug.cgi?id=165113
+
+
+Reviewed by Darin Adler.
+
+When a web application attempts to set an extremely long title, truncate the
+title to a more reasonable size.
+
+We do this at at the presentation layer, rather than in the DOM, so that we do
+not affect script function. Instead, we merely limit display to a level that is
+reasonable for normal GUI widgets. Anything else needs to be truncated in the UI
+layer, so it is a waste of effort to send across IPC.
+
+* WebCoreSupport/WebFrameLoaderClient.h:
+* WebCoreSupport/WebFrameLoaderClient.mm:
+(WebFrameLoaderClient::dispatchDidReceiveTitle):
+
2017-04-25 Daniel Bates
[Cocoa][Win] Enable of X-Content-Type-Options: nosniff header
Modified: trunk/Source/WebKit/mac/WebCoreSupport/WebFrameLoaderClient.mm (215783 => 215784)
--- trunk/Source/WebKit/mac/WebCoreSupport/WebFrameLoaderClient.mm 2017-04-26 01:45:04 UTC (rev 215783)
+++ trunk/Source/WebKit/mac/WebCoreSupport/WebFrameLoaderClient.mm 2017-04-26 01:53:06 UTC (rev 215784)
@@ -681,13 +681,17 @@
CallFrameLoadDelegate(implementations->didStartProvisionalLoadForFrameFunc, webView, @selector(webView:didStartProvisionalLoadForFrame:), m_webFrame.get());
}
+static constexpr unsigned maxTitleLength = 1000; // Closest power of 10 above the W3C recommendation for Title length.
+
void WebFrameLoaderClient::dispatchDidReceiveTitle(const StringWithDirection& t
[webkit-changes] [215783] trunk/LayoutTests
Title: [215783] trunk/LayoutTests
Revision 215783
Author d...@apple.com
Date 2017-04-25 18:45:04 -0700 (Tue, 25 Apr 2017)
Log Message
REGRESSION (r214129): fast/media/mq-prefers-reduced-motion.html fails
https://bugs.webkit.org/show_bug.cgi?id=171303
Reviewed by Brent Fulgham.
This particular test was calling notifyDone() from within
a callback triggered by the UIScriptController script, which
meant that by the time the controller tried to call its callback,
the test had finished.
* fast/media/mq-prefers-reduced-motion-matchMedia.html: Make sure
notifyDone is called after both the callback-like functions have
triggered.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/media/mq-prefers-reduced-motion-matchMedia.html
Diff
Modified: trunk/LayoutTests/ChangeLog (215782 => 215783)
--- trunk/LayoutTests/ChangeLog 2017-04-26 01:22:55 UTC (rev 215782)
+++ trunk/LayoutTests/ChangeLog 2017-04-26 01:45:04 UTC (rev 215783)
@@ -1,3 +1,20 @@
+2017-04-25 Dean Jackson
+
+REGRESSION (r214129): fast/media/mq-prefers-reduced-motion.html fails
+https://bugs.webkit.org/show_bug.cgi?id=171303
+
+
+Reviewed by Brent Fulgham.
+
+This particular test was calling notifyDone() from within
+a callback triggered by the UIScriptController script, which
+meant that by the time the controller tried to call its callback,
+the test had finished.
+
+* fast/media/mq-prefers-reduced-motion-matchMedia.html: Make sure
+notifyDone is called after both the callback-like functions have
+triggered.
+
2017-04-25 John Wilander
Resource Load Statistics: Introduce shorter time-to-live for cookie partition whitelisting
Modified: trunk/LayoutTests/fast/media/mq-prefers-reduced-motion-matchMedia.html (215782 => 215783)
--- trunk/LayoutTests/fast/media/mq-prefers-reduced-motion-matchMedia.html 2017-04-26 01:22:55 UTC (rev 215782)
+++ trunk/LayoutTests/fast/media/mq-prefers-reduced-motion-matchMedia.html 2017-04-26 01:45:04 UTC (rev 215783)
@@ -15,21 +15,31 @@
var motionQuery = window.matchMedia("(prefers-reduced-motion)");
motionQuery.addListener(() => {
document.getElementById("after").textContent = motionQuery.matches ? "true" : "false";
-testRunner.notifyDone();
+queryFired = true;
+checkDone();
});
document.getElementById("before").textContent = motionQuery.matches ? "true" : "false";
window.internals.settings.forcedPrefersReducedMotionAccessibilityValue = "on";
-if (testRunner.runUIScript) {
-testRunner.runUIScript(`
-(function() {
-uiController.simulateAccessibilitySettingsChangeNotification(function() {
-uiController.uiScriptComplete("Done");
-});
-})();`);
-}
+testRunner.runUIScript(`
+(function() {
+uiController.simulateAccessibilitySettingsChangeNotification(function() {
+uiController.uiScriptComplete("Done");
+});
+})();`, function (result) {
+scriptRan = true;
+checkDone();
+});
}
+let queryFired = false;
+let scriptRan = false;
+
+function checkDone() {
+if (queryFired && scriptRan)
+testRunner.notifyDone();
+}
+
window.addEventListener("load", runTest, false);
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [215782] trunk
Title: [215782] trunk Revision 215782 Author wilan...@apple.com Date 2017-04-25 18:22:55 -0700 (Tue, 25 Apr 2017) Log Message Resource Load Statistics: Introduce shorter time-to-live for cookie partition whitelisting https://bugs.webkit.org/show_bug.cgi?id=171295 Reviewed by Brent Fulgham. Source/WebCore: Test: http/tests/loading/resourceLoadStatistics/partitioned-and-unpartitioned-cookie-with-partitioning-timeout.html * loader/ResourceLoadObserver.cpp: (WebCore::reduceTimeResolutionToOneDay): Deleted. (WebCore::reduceTimeResolution): Changed name to no longer lock this to a specific resolution. (WebCore::ResourceLoadObserver::logUserInteractionWithReducedTimeResolution): Now calls WebCore::reduceTimeResolution(). (WebCore::ResourceLoadObserver::setTimeToLiveCookiePartitionFree): Added for testing purposes. (WebCore::ResourceLoadObserver::fireShouldPartitionCookiesHandler): Added for testing purposes. * loader/ResourceLoadObserver.h: * loader/ResourceLoadStatisticsStore.cpp: (WebCore::shouldPartitionCookies): Static inline convenience function. (WebCore::ResourceLoadStatisticsStore::fireShouldPartitionCookiesHandler): Now decides whether a domain should get partitioned cookies based on timeToLiveCookiePartitionFree. Removed clearFirst parameter since it's not needed here and it introduced complexity in keeping the store and the network process cache in sync. (WebCore::ResourceLoadStatisticsStore::setTimeToLiveCookiePartitionFree): Added for testing purposes. * loader/ResourceLoadStatisticsStore.h: Source/WebKit2: * UIProcess/API/C/WKResourceLoadStatisticsManager.cpp: (WKResourceLoadStatisticsManagerSetTimeToLiveCookiePartitionFree): (WKResourceLoadStatisticsManagerFireShouldPartitionCookiesHandler): (WKResourceLoadStatisticsManagerFireShouldPartitionCookiesHandlerForOneDomain): Changes and additions to test infrastructure. * UIProcess/API/C/WKResourceLoadStatisticsManager.h: * UIProcess/WebResourceLoadStatisticsManager.cpp: (WebKit::WebResourceLoadStatisticsManager::setTimeToLiveCookiePartitionFree): (WebKit::WebResourceLoadStatisticsManager::fireShouldPartitionCookiesHandler): (WebKit::WebResourceLoadStatisticsManager::fireShouldPartitionCookiesHandlerForOneDomain): (WebKit::WebResourceLoadStatisticsManager::resetToConsistentState): Changes and additions to test infrastructure. * UIProcess/WebResourceLoadStatisticsManager.h: * UIProcess/WebResourceLoadStatisticsStore.cpp: (WebKit::WebResourceLoadStatisticsStore::resourceLoadStatisticsUpdated): No longer sends a boolean parameter to WebCore::ResourceLoadStatisticsStore::fireShouldPartitionCookiesHandler(). Tools: * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl: * WebKitTestRunner/InjectedBundle/TestRunner.cpp: (WTR::TestRunner::setStatisticsTimeToLiveCookiePartitionFree): (WTR::TestRunner::statisticsFireShouldPartitionCookiesHandler): (WTR::TestRunner::statisticsFireShouldPartitionCookiesHandlerForOneDomain): * WebKitTestRunner/InjectedBundle/TestRunner.h: * WebKitTestRunner/TestController.cpp: (WTR::TestController::setStatisticsTimeToLiveCookiePartitionFree): (WTR::TestController::statisticsFireShouldPartitionCookiesHandler): (WTR::TestController::statisticsFireShouldPartitionCookiesHandlerForOneDomain): * WebKitTestRunner/TestController.h: * WebKitTestRunner/TestInvocation.cpp: (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle): LayoutTests: * http/tests/loading/resourceLoadStatistics/partitioned-and-unpartitioned-cookie-deletion.html: Changed a TestRunner function name to statisticsFireShouldPartitionCookiesHandlerForOneDomain(). * http/tests/loading/resourceLoadStatistics/partitioned-and-unpartitioned-cookie-with-partitioning-timeout-expected.txt: Added. * http/tests/loading/resourceLoadStatistics/partitioned-and-unpartitioned-cookie-with-partitioning-timeout.html: Added. * http/tests/loading/resourceLoadStatistics/partitioned-cookies-with-and-without-user-interaction.html: Changed a TestRunner function name to statisticsFireShouldPartitionCookiesHandlerForOneDomain(). Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/http/tests/loading/resourceLoadStatistics/partitioned-and-unpartitioned-cookie-deletion.html trunk/LayoutTests/http/tests/loading/resourceLoadStatistics/partitioned-cookies-with-and-without-user-interaction.html trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/loader/ResourceLoadObserver.cpp trunk/Source/WebCore/loader/ResourceLoadObserver.h trunk/Source/WebCore/loader/ResourceLoadStatisticsStore.cpp trunk/Source/WebCore/loader/ResourceLoadStatisticsStore.h trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/UIProcess/API/C/WKResourceLoadStatisticsManager.cpp trunk/Source/WebKit2/UIProcess/API/C/WKResourceLoadStatisticsManager.h trunk/Source/WebKit2/UIProcess/WebResourceLoadStatisticsManager.cpp trunk/Source/WebKit2/UIProcess/WebResourceLoadStatisticsManager.h trunk/Source/WebKit2/UIProcess/WebResou
[webkit-changes] [215781] branches/safari-603-branch/Source
Title: [215781] branches/safari-603-branch/Source Revision 215781 Author matthew_han...@apple.com Date 2017-04-25 18:11:56 -0700 (Tue, 25 Apr 2017) Log Message Versioning. Modified Paths branches/safari-603-branch/Source/_javascript_Core/Configurations/Version.xcconfig branches/safari-603-branch/Source/WebCore/Configurations/Version.xcconfig branches/safari-603-branch/Source/WebInspectorUI/Configurations/Version.xcconfig branches/safari-603-branch/Source/WebKit/mac/Configurations/Version.xcconfig branches/safari-603-branch/Source/WebKit2/Configurations/Version.xcconfig Diff Modified: branches/safari-603-branch/Source/_javascript_Core/Configurations/Version.xcconfig (215780 => 215781) --- branches/safari-603-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2017-04-26 01:11:11 UTC (rev 215780) +++ branches/safari-603-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2017-04-26 01:11:56 UTC (rev 215781) @@ -23,7 +23,7 @@ MAJOR_VERSION = 603; MINOR_VERSION = 2; -TINY_VERSION = 5; +TINY_VERSION = 6; MICRO_VERSION = 0; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); Modified: branches/safari-603-branch/Source/WebCore/Configurations/Version.xcconfig (215780 => 215781) --- branches/safari-603-branch/Source/WebCore/Configurations/Version.xcconfig 2017-04-26 01:11:11 UTC (rev 215780) +++ branches/safari-603-branch/Source/WebCore/Configurations/Version.xcconfig 2017-04-26 01:11:56 UTC (rev 215781) @@ -23,7 +23,7 @@ MAJOR_VERSION = 603; MINOR_VERSION = 2; -TINY_VERSION = 5; +TINY_VERSION = 6; MICRO_VERSION = 0; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); Modified: branches/safari-603-branch/Source/WebInspectorUI/Configurations/Version.xcconfig (215780 => 215781) --- branches/safari-603-branch/Source/WebInspectorUI/Configurations/Version.xcconfig 2017-04-26 01:11:11 UTC (rev 215780) +++ branches/safari-603-branch/Source/WebInspectorUI/Configurations/Version.xcconfig 2017-04-26 01:11:56 UTC (rev 215781) @@ -1,6 +1,6 @@ MAJOR_VERSION = 603; MINOR_VERSION = 2; -TINY_VERSION = 5; +TINY_VERSION = 6; MICRO_VERSION = 0; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); Modified: branches/safari-603-branch/Source/WebKit/mac/Configurations/Version.xcconfig (215780 => 215781) --- branches/safari-603-branch/Source/WebKit/mac/Configurations/Version.xcconfig 2017-04-26 01:11:11 UTC (rev 215780) +++ branches/safari-603-branch/Source/WebKit/mac/Configurations/Version.xcconfig 2017-04-26 01:11:56 UTC (rev 215781) @@ -23,7 +23,7 @@ MAJOR_VERSION = 603; MINOR_VERSION = 2; -TINY_VERSION = 5; +TINY_VERSION = 6; MICRO_VERSION = 0; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); Modified: branches/safari-603-branch/Source/WebKit2/Configurations/Version.xcconfig (215780 => 215781) --- branches/safari-603-branch/Source/WebKit2/Configurations/Version.xcconfig 2017-04-26 01:11:11 UTC (rev 215780) +++ branches/safari-603-branch/Source/WebKit2/Configurations/Version.xcconfig 2017-04-26 01:11:56 UTC (rev 215781) @@ -23,7 +23,7 @@ MAJOR_VERSION = 603; MINOR_VERSION = 2; -TINY_VERSION = 5; +TINY_VERSION = 6; MICRO_VERSION = 0; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [215780] trunk/Source/WebKit2
Title: [215780] trunk/Source/WebKit2
Revision 215780
Author simon.fra...@apple.com
Date 2017-04-25 18:11:11 -0700 (Tue, 25 Apr 2017)
Log Message
REGRESSION (r213719): WebGL content on cubeslam.com is 1/4 expected size
https://bugs.webkit.org/show_bug.cgi?id=171300
rdar://problem/31051538
Reviewed by Dean Jackson.
Propagating the contentsScale to the UI process for canvas content layers causes
scaling issues, so don't do it for contents-provided layers.
No test because WebGL can't be tested in the iOS simulator.
* WebProcess/WebPage/mac/PlatformCALayerRemote.cpp:
(WebKit::PlatformCALayerRemote::PlatformCALayerRemote):
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/WebProcess/WebPage/mac/PlatformCALayerRemote.cpp
Diff
Modified: trunk/Source/WebKit2/ChangeLog (215779 => 215780)
--- trunk/Source/WebKit2/ChangeLog 2017-04-26 00:57:59 UTC (rev 215779)
+++ trunk/Source/WebKit2/ChangeLog 2017-04-26 01:11:11 UTC (rev 215780)
@@ -1,3 +1,19 @@
+2017-04-25 Simon Fraser
+
+REGRESSION (r213719): WebGL content on cubeslam.com is 1/4 expected size
+https://bugs.webkit.org/show_bug.cgi?id=171300
+rdar://problem/31051538
+
+Reviewed by Dean Jackson.
+
+Propagating the contentsScale to the UI process for canvas content layers causes
+scaling issues, so don't do it for contents-provided layers.
+
+No test because WebGL can't be tested in the iOS simulator.
+
+* WebProcess/WebPage/mac/PlatformCALayerRemote.cpp:
+(WebKit::PlatformCALayerRemote::PlatformCALayerRemote):
+
2017-04-25 Brady Eidson
Update WebProcess(Pool) to assume there's always a WebsiteDataStore
Modified: trunk/Source/WebKit2/WebProcess/WebPage/mac/PlatformCALayerRemote.cpp (215779 => 215780)
--- trunk/Source/WebKit2/WebProcess/WebPage/mac/PlatformCALayerRemote.cpp 2017-04-26 00:57:59 UTC (rev 215779)
+++ trunk/Source/WebKit2/WebProcess/WebPage/mac/PlatformCALayerRemote.cpp 2017-04-26 01:11:11 UTC (rev 215780)
@@ -76,7 +76,7 @@
: PlatformCALayer(layerType, owner)
, m_context(&context)
{
-if (owner) {
+if (owner && layerType != LayerTypeContentsProvidedLayer) {
m_properties.contentsScale = owner->platformCALayerDeviceScaleFactor();
m_properties.notePropertiesChanged(RemoteLayerTreeTransaction::ContentsScaleChanged);
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [215774] trunk/Source/WebCore
Title: [215774] trunk/Source/WebCore
Revision 215774
Author d...@apple.com
Date 2017-04-25 17:38:11 -0700 (Tue, 25 Apr 2017)
Log Message
Skip WebKitAdditions for Safari Technology Preview media controls
https://bugs.webkit.org/show_bug.cgi?id=171302
Reviewed by Simon Fraser.
Safari Technology Preview should use the same controls
as OpenSource.
* WebCore.xcodeproj/project.pbxproj:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj
Diff
Modified: trunk/Source/WebCore/ChangeLog (215773 => 215774)
--- trunk/Source/WebCore/ChangeLog 2017-04-26 00:16:21 UTC (rev 215773)
+++ trunk/Source/WebCore/ChangeLog 2017-04-26 00:38:11 UTC (rev 215774)
@@ -1,3 +1,16 @@
+2017-04-25 Dean Jackson
+
+Skip WebKitAdditions for Safari Technology Preview media controls
+https://bugs.webkit.org/show_bug.cgi?id=171302
+
+
+Reviewed by Simon Fraser.
+
+Safari Technology Preview should use the same controls
+as OpenSource.
+
+* WebCore.xcodeproj/project.pbxproj:
+
2017-04-25 Ryan Haddad
Unreviewed, rolling out r215730.
Modified: trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj (215773 => 215774)
--- trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj 2017-04-26 00:16:21 UTC (rev 215773)
+++ trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj 2017-04-26 00:38:11 UTC (rev 215774)
@@ -30337,7 +30337,7 @@
);
runOnlyForDeploymentPostprocessing = 0;
shellPath = /bin/sh;
- shellScript = "WKA_DIR=\"$BUILT_PRODUCTS_DIR/usr/local/include/WebKitAdditions/modern-media-controls\"\nSRC_DIR=\"$SRCROOT/Modules/modern-media-controls\"\nDST_DIR=\"$BUILT_PRODUCTS_DIR/$UNLOCALIZED_RESOURCES_FOLDER_PATH/modern-media-controls\"\n\nif [ -d \"$WKA_DIR\" ]; then\nMMC_DIR=$WKA_DIR;\nelse\nMMC_DIR=$SRC_DIR\nfi\n\nmkdir -p \"$DST_DIR\"\n\nif [ \"${PLATFORM_NAME}\" == \"macosx\" ]; then\nIMG_OS_PREFIX=\"macOS\"\nfi\n\nif [ \"${PLATFORM_NAME}\" == \"iphoneos\" ] || [ \"${PLATFORM_NAME}\" == \"iphonesimulator\" ]; then\nIMG_OS_PREFIX=\"iOS\"\nfi\n\nif [ -n \"$IMG_OS_PREFIX\" ]; then\nrsync -aq --exclude \".svn\" --exclude \".DS_Store\" \"$MMC_DIR/images/$IMG_OS_PREFIX/\" \"$DST_DIR/images\"\nfi\n\ncd \"$MMC_DIR\"\ncat controls/*.css > \"$DST
_DIR/modern-media-controls.css\"\ncat `cat js-files` > \"$DST_DIR/modern-media-controls.js\"";
+ shellScript = "WKA_DIR=\"$BUILT_PRODUCTS_DIR/usr/local/include/WebKitAdditions/modern-media-controls\"\nSRC_DIR=\"$SRCROOT/Modules/modern-media-controls\"\nDST_DIR=\"$BUILT_PRODUCTS_DIR/$UNLOCALIZED_RESOURCES_FOLDER_PATH/modern-media-controls\"\n\nif [[ -d \"$WKA_DIR\" && $SAFARI_TECHNOLOGY_PREVIEW_TYPE != \"TECHNOLOGY_PREVIEW\" ]]; then\nMMC_DIR=$WKA_DIR;\nelse\nMMC_DIR=$SRC_DIR\nfi\n\nmkdir -p \"$DST_DIR\"\n\nif [ \"${PLATFORM_NAME}\" == \"macosx\" ]; then\nIMG_OS_PREFIX=\"macOS\"\nfi\n\nif [ \"${PLATFORM_NAME}\" == \"iphoneos\" ] || [ \"${PLATFORM_NAME}\" == \"iphonesimulator\" ]; then\nIMG_OS_PREFIX=\"iOS\"\nfi\n\nif [ -n \"$IMG_OS_PREFIX\" ]; then\nrsync -aq --exclude \".svn\" --exclude \".DS_Store\" \"$MMC_DIR/images/$IMG_OS_PREFIX/\" \"$DST_DIR/ima
ges\"\nfi\n\ncd \"$MMC_DIR\"\ncat controls/*.css > \"$DST_DIR/modern-media-controls.css\"\ncat `cat js-files` > \"$DST_DIR/modern-media-controls.js\"\n";
};
A5E79CEC1E67F2CF00FB8153 /* Make Frameworks Symbolic Link */ = {
isa = PBXShellScriptBuildPhase;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [215778] trunk/Source/WebKit2
Title: [215778] trunk/Source/WebKit2
Revision 215778
Author beid...@apple.com
Date 2017-04-25 17:52:44 -0700 (Tue, 25 Apr 2017)
Log Message
Update WebProcess(Pool) to assume there's always a WebsiteDataStore
https://bugs.webkit.org/show_bug.cgi?id=171299
Reviewed by Alex Christensen.
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::reattachToWebProcess):
* UIProcess/WebProcessPool.cpp:
(WebKit::WebProcessPool::createNewWebProcess):
(WebKit::WebProcessPool::warmInitialProcess):
(WebKit::WebProcessPool::createNewWebProcessRespectingProcessCountLimit):
(WebKit::WebProcessPool::createWebPage):
* UIProcess/WebProcessPool.h:
* UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::create):
(WebKit::WebProcessProxy::WebProcessProxy):
(WebKit::m_userMediaCaptureManagerProxy):
* UIProcess/WebProcessProxy.h:
(WebKit::WebProcessProxy::websiteDataStore):
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp
trunk/Source/WebKit2/UIProcess/WebProcessPool.cpp
trunk/Source/WebKit2/UIProcess/WebProcessPool.h
trunk/Source/WebKit2/UIProcess/WebProcessProxy.cpp
trunk/Source/WebKit2/UIProcess/WebProcessProxy.h
Diff
Modified: trunk/Source/WebKit2/ChangeLog (215777 => 215778)
--- trunk/Source/WebKit2/ChangeLog 2017-04-26 00:52:35 UTC (rev 215777)
+++ trunk/Source/WebKit2/ChangeLog 2017-04-26 00:52:44 UTC (rev 215778)
@@ -1,3 +1,25 @@
+2017-04-25 Brady Eidson
+
+Update WebProcess(Pool) to assume there's always a WebsiteDataStore
+https://bugs.webkit.org/show_bug.cgi?id=171299
+
+Reviewed by Alex Christensen.
+
+* UIProcess/WebPageProxy.cpp:
+(WebKit::WebPageProxy::reattachToWebProcess):
+* UIProcess/WebProcessPool.cpp:
+(WebKit::WebProcessPool::createNewWebProcess):
+(WebKit::WebProcessPool::warmInitialProcess):
+(WebKit::WebProcessPool::createNewWebProcessRespectingProcessCountLimit):
+(WebKit::WebProcessPool::createWebPage):
+* UIProcess/WebProcessPool.h:
+* UIProcess/WebProcessProxy.cpp:
+(WebKit::WebProcessProxy::create):
+(WebKit::WebProcessProxy::WebProcessProxy):
+(WebKit::m_userMediaCaptureManagerProxy):
+* UIProcess/WebProcessProxy.h:
+(WebKit::WebProcessProxy::websiteDataStore):
+
2017-04-25 Ryan Haddad
Unreviewed, rolling out r215730.
Modified: trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp (215777 => 215778)
--- trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp 2017-04-26 00:52:35 UTC (rev 215777)
+++ trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp 2017-04-26 00:52:44 UTC (rev 215778)
@@ -715,7 +715,7 @@
m_process->removeWebPage(m_pageID);
m_process->removeMessageReceiver(Messages::WebPageProxy::messageReceiverName(), m_pageID);
-m_process = m_process->processPool().createNewWebProcessRespectingProcessCountLimit(m_websiteDataStore.ptr());
+m_process = m_process->processPool().createNewWebProcessRespectingProcessCountLimit(m_websiteDataStore.get());
ASSERT(m_process->state() != ChildProcessProxy::State::Terminated);
if (m_process->state() == ChildProcessProxy::State::Running)
Modified: trunk/Source/WebKit2/UIProcess/WebProcessPool.cpp (215777 => 215778)
--- trunk/Source/WebKit2/UIProcess/WebProcessPool.cpp 2017-04-26 00:52:35 UTC (rev 215777)
+++ trunk/Source/WebKit2/UIProcess/WebProcessPool.cpp 2017-04-26 00:52:44 UTC (rev 215778)
@@ -621,7 +621,7 @@
platformResolvePathsForSandboxExtensions();
}
-WebProcessProxy& WebProcessPool::createNewWebProcess(WebsiteDataStore* websiteDataStore)
+WebProcessProxy& WebProcessPool::createNewWebProcess(WebsiteDataStore& websiteDataStore)
{
ensureNetworkProcess();
@@ -629,8 +629,7 @@
WebProcessCreationParameters parameters;
-if (websiteDataStore)
-websiteDataStore->resolveDirectoriesIfNecessary();
+websiteDataStore.resolveDirectoriesIfNecessary();
parameters.injectedBundlePath = m_resolvedPaths.injectedBundlePath;
if (!parameters.injectedBundlePath.isEmpty())
@@ -640,7 +639,7 @@
for (size_t i = 0, size = m_resolvedPaths.additionalWebProcessSandboxExtensionPaths.size(); i < size; ++i)
SandboxExtension::createHandleWithoutResolvingPath(m_resolvedPaths.additionalWebProcessSandboxExtensionPaths[i], SandboxExtension::ReadOnly, parameters.additionalSandboxExtensionHandles[i]);
-parameters.applicationCacheDirectory = websiteDataStore ? websiteDataStore->resolvedApplicationCacheDirectory() : m_resolvedPaths.applicationCacheDirectory;
+parameters.applicationCacheDirectory = websiteDataStore.resolvedApplicationCacheDirectory();
if (parameters.applicationCacheDirectory.isEmpty())
parameters.applicationCacheDirectory = m_resolvedPaths.applicationCacheDirectory;
if (!parameters.applicationCacheDirectory.isEmpty())
@@ -648,19 +647,19 @@
parameters.applicationCacheFlatFileSubdirectoryName = m_configuration->applicationCacheFlatFileSubdirectoryNam
[webkit-changes] [215777] trunk
Title: [215777] trunk Revision 215777 Author sbar...@apple.com Date 2017-04-25 17:52:35 -0700 (Tue, 25 Apr 2017) Log Message JSArray::isArrayPrototypeIteratorProtocolFastAndNonObservable is wrong because it does not do the necessary checks on the base object https://bugs.webkit.org/show_bug.cgi?id=171150 Reviewed by Sam Weinig. JSTests: * stress/spread-optimized-properly.js: Added. (assert): (test): (shallowEq): (makeArrayIterator): (test.bar): (test.callback): (test.arr.__proto__.Symbol.iterator): (test.arr.Symbol.iterator): (test.get bar): (test.hackedNext): (test.test): (test.): Source/_javascript_Core: This patch fixes a huge oversight from the patch that introduced op_spread/Spread. The original patch did not account for the base object having Symbol.iterator or getters that could change the iterator protocol. This patch fixes the oversight both in the C code, as well as the DFG/FTL backends. We only perform the memcpy version of spread if we've proven that it's guaranteed to be side-effect free (no indexed getters), and if the iterator protocol is guaranteed to be the original protocol. To do this, we must prove that: 1. The protocol on Array.prototype hasn't changed (this is the same as the introductory patch for op_spread). 2. The base object's __proto__ is Array.prototype 3. The base object does not have indexed getters 4. The base object does not have Symbol.iterator property. * dfg/DFGGraph.cpp: (JSC::DFG::Graph::canDoFastSpread): * dfg/DFGGraph.h: * dfg/DFGSpeculativeJIT.cpp: (JSC::DFG::SpeculativeJIT::compileSpread): * ftl/FTLLowerDFGToB3.cpp: (JSC::FTL::DFG::LowerDFGToB3::compileSpread): * runtime/JSArray.cpp: (JSC::JSArray::isIteratorProtocolFastAndNonObservable): * runtime/JSArray.h: * runtime/JSArrayInlines.h: (JSC::JSArray::isIteratorProtocolFastAndNonObservable): Deleted. * runtime/JSGlobalObject.h: * runtime/JSGlobalObjectInlines.h: (JSC::JSGlobalObject::isArrayPrototypeIteratorProtocolFastAndNonObservable): (JSC::JSGlobalObject::isArrayIteratorProtocolFastAndNonObservable): Deleted. Source/WebCore: This patch moves the sequence converters to use the now fixed JSArray::isArrayPrototypeIteratorProtocolFastAndNonObservable test inside JSC. This patch also fixes a few bugs: 1. Converting to a sequence of numbers must prove that the JSArray is filled only with Int32/Double. If there is a chance the array contains objects, the conversion to a numeric IDLType can be observable (via valueOf()), and can change the iterator protocol. 2. There are other conversions that can have side effects a-la valueOf(). This patch introduces a new static constant in the various Converter classes that tell the sequence converter if the conversion operation can have JS side effects. If it does have side effects, we fall back to the generic conversion that uses the iterator protocol. If not, we can do a faster version that iterates over each element of the array, reading it directly, and converting it. Tests: js/sequence-iterator-protocol-2.html js/sequence-iterator-protocol.html * bindings/js/JSDOMConvertAny.h: Does not have side effects. * bindings/js/JSDOMConvertBase.h: We pessimistically assume inside DefaultConverter that converions have side effects. * bindings/js/JSDOMConvertBoolean.h: Does not have side effects. * bindings/js/JSDOMConvertCallbacks.h: Does not have side effects. * bindings/js/JSDOMConvertObject.h: Does not have side effects. * bindings/js/JSDOMConvertSequences.h: (WebCore::Detail::NumericSequenceConverter::convert): (WebCore::Detail::SequenceConverter::convert): LayoutTests: * js/sequence-iterator-protocol-2-expected.txt: Added. * js/sequence-iterator-protocol-2.html: Added. * js/sequence-iterator-protocol-expected.txt: Added. * js/sequence-iterator-protocol.html: Added. Modified Paths trunk/JSTests/ChangeLog trunk/LayoutTests/ChangeLog trunk/Source/_javascript_Core/ChangeLog trunk/Source/_javascript_Core/dfg/DFGGraph.cpp trunk/Source/_javascript_Core/dfg/DFGGraph.h trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.cpp trunk/Source/_javascript_Core/ftl/FTLLowerDFGToB3.cpp trunk/Source/_javascript_Core/runtime/JSArray.cpp trunk/Source/_javascript_Core/runtime/JSArray.h trunk/Source/_javascript_Core/runtime/JSArrayInlines.h trunk/Source/_javascript_Core/runtime/JSGlobalObject.h trunk/Source/_javascript_Core/runtime/JSGlobalObjectInlines.h trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/bindings/js/JSDOMConvertAny.h trunk/Source/WebCore/bindings/js/JSDOMConvertBase.h trunk/Source/WebCore/bindings/js/JSDOMConvertBoolean.h trunk/Source/WebCore/bindings/js/JSDOMConvertCallbacks.h trunk/Source/WebCore/bindings/js/JSDOMConvertObject.h trunk/Source/WebCore/bindings/js/JSDOMConvertSequences.h Added Paths trunk/JSTests/stress/spread-optimized-properly.js trunk/LayoutTests/js/sequence-iterator-protocol-2-expected.txt trunk/LayoutTests/js/sequence-iterator-protocol-2.html trunk/LayoutTests/js/sequence-iterator-protocol-expected.txt trunk/LayoutTests/js/sequenc
[webkit-changes] [215776] trunk/LayoutTests
Title: [215776] trunk/LayoutTests Revision 215776 Author ryanhad...@apple.com Date 2017-04-25 17:42:32 -0700 (Tue, 25 Apr 2017) Log Message Mark media/modern-media-controls/pip-support/pip-support-click.html as flaky. https://bugs.webkit.org/show_bug.cgi?id=165311 Unreviewed test gardening. * platform/mac/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/mac/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (215775 => 215776) --- trunk/LayoutTests/ChangeLog 2017-04-26 00:39:22 UTC (rev 215775) +++ trunk/LayoutTests/ChangeLog 2017-04-26 00:42:32 UTC (rev 215776) @@ -1,5 +1,14 @@ 2017-04-25 Ryan Haddad +Mark media/modern-media-controls/pip-support/pip-support-click.html as flaky. +https://bugs.webkit.org/show_bug.cgi?id=165311 + +Unreviewed test gardening. + +* platform/mac/TestExpectations: + +2017-04-25 Ryan Haddad + Mark http/tests/security/contentSecurityPolicy/1.1/module-scriptnonce-invalidnonce.html as flaky. https://bugs.webkit.org/show_bug.cgi?id=171301 Modified: trunk/LayoutTests/platform/mac/TestExpectations (215775 => 215776) --- trunk/LayoutTests/platform/mac/TestExpectations 2017-04-26 00:39:22 UTC (rev 215775) +++ trunk/LayoutTests/platform/mac/TestExpectations 2017-04-26 00:42:32 UTC (rev 215776) @@ -1491,6 +1491,8 @@ webkit.org/b/167266 media/modern-media-controls/media-controller/media-controller-auto-hide-mouse-enter-over-controls-bar.html [ Pass Failure ] webkit.org/b/168540 media/modern-media-controls/media-controller/media-controller-auto-hide-mouse-leave-after-play.html [ Pass Failure ] +webkit.org/b/165311 [ Sierra Debug ] media/modern-media-controls/pip-support/pip-support-click.html [ Pass Failure Timeout ] + webkit.org/b/165386 media/modern-media-controls/seek-backward-support/seek-backward-support.html [ Pass Timeout ] webkit.org/b/169679 [ Debug ] media/modern-media-controls/time-label/time-label-white-space-nowrap.html [ Pass Failure ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [215775] trunk/Source
Title: [215775] trunk/Source
Revision 215775
Author msab...@apple.com
Date 2017-04-25 17:39:22 -0700 (Tue, 25 Apr 2017)
Log Message
Call bmalloc scavenger first when handling a memory pressure event
https://bugs.webkit.org/show_bug.cgi?id=171289
Reviewed by Geoffrey Garen.
Source/bmalloc:
Registered a critical memory pressure handler. We add this handler in addition to the
call to release bmalloc memory in the WebCore releaseMemory handler for the case of
JSC API users that don't use WebCore. When both handlers are in the process, it is
basically a race. One will win, but the loser won't do any more work, so it is harmless.
* bmalloc/Heap.cpp:
(bmalloc::Heap::Heap):
Source/WebCore:
Let bmalloc free any pages to the OS that it can before doing anything else.
* page/MemoryRelease.cpp:
(WebCore::releaseMemory):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/MemoryRelease.cpp
trunk/Source/bmalloc/ChangeLog
trunk/Source/bmalloc/bmalloc/Heap.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (215774 => 215775)
--- trunk/Source/WebCore/ChangeLog 2017-04-26 00:38:11 UTC (rev 215774)
+++ trunk/Source/WebCore/ChangeLog 2017-04-26 00:39:22 UTC (rev 215775)
@@ -1,3 +1,15 @@
+2017-04-25 Michael Saboff
+
+Call bmalloc scavenger first when handling a memory pressure event
+https://bugs.webkit.org/show_bug.cgi?id=171289
+
+Reviewed by Geoffrey Garen.
+
+Let bmalloc free any pages to the OS that it can before doing anything else.
+
+* page/MemoryRelease.cpp:
+(WebCore::releaseMemory):
+
2017-04-25 Dean Jackson
Skip WebKitAdditions for Safari Technology Preview media controls
Modified: trunk/Source/WebCore/page/MemoryRelease.cpp (215774 => 215775)
--- trunk/Source/WebCore/page/MemoryRelease.cpp 2017-04-26 00:38:11 UTC (rev 215774)
+++ trunk/Source/WebCore/page/MemoryRelease.cpp 2017-04-26 00:39:22 UTC (rev 215775)
@@ -110,6 +110,9 @@
{
TraceScope scope(MemoryPressureHandlerStart, MemoryPressureHandlerEnd, static_cast(critical), static_cast(synchronous));
+// Return unused pages back to the OS now as this will likely give us a little memory to work with.
+WTF::releaseFastMallocFreeMemory();
+
if (critical == Critical::Yes)
releaseCriticalMemory(synchronous);
Modified: trunk/Source/bmalloc/ChangeLog (215774 => 215775)
--- trunk/Source/bmalloc/ChangeLog 2017-04-26 00:38:11 UTC (rev 215774)
+++ trunk/Source/bmalloc/ChangeLog 2017-04-26 00:39:22 UTC (rev 215775)
@@ -1,3 +1,18 @@
+2017-04-25 Michael Saboff
+
+Call bmalloc scavenger first when handling a memory pressure event
+https://bugs.webkit.org/show_bug.cgi?id=171289
+
+Reviewed by Geoffrey Garen.
+
+Registered a critical memory pressure handler. We add this handler in addition to the
+call to release bmalloc memory in the WebCore releaseMemory handler for the case of
+JSC API users that don't use WebCore. When both handlers are in the process, it is
+basically a race. One will win, but the loser won't do any more work, so it is harmless.
+
+* bmalloc/Heap.cpp:
+(bmalloc::Heap::Heap):
+
2017-04-14 Mark Lam
Update architectures in xcconfig files.
Modified: trunk/Source/bmalloc/bmalloc/Heap.cpp (215774 => 215775)
--- trunk/Source/bmalloc/bmalloc/Heap.cpp 2017-04-26 00:38:11 UTC (rev 215774)
+++ trunk/Source/bmalloc/bmalloc/Heap.cpp 2017-04-26 00:39:22 UTC (rev 215775)
@@ -30,6 +30,10 @@
#include "PerProcess.h"
#include "SmallLine.h"
#include "SmallPage.h"
+#if BOS(DARWIN)
+#include "bmalloc.h"
+#include
+#endif
#include
namespace bmalloc {
@@ -48,6 +52,15 @@
if (m_environment.isDebugHeapEnabled())
m_debugHeap = PerProcess::get();
+
+#if BOS(DARWIN)
+auto queue = dispatch_queue_create("WebKit Malloc Memory Pressure Handler", DISPATCH_QUEUE_SERIAL);
+auto source = dispatch_source_create(DISPATCH_SOURCE_TYPE_MEMORYPRESSURE, 0, DISPATCH_MEMORYPRESSURE_CRITICAL, queue);
+dispatch_source_set_event_handler(source, ^{
+api::scavenge();
+});
+dispatch_resume(source);
+#endif
}
void Heap::initializeLineMetadata()
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [215773] trunk/LayoutTests
Title: [215773] trunk/LayoutTests Revision 215773 Author ryanhad...@apple.com Date 2017-04-25 17:16:21 -0700 (Tue, 25 Apr 2017) Log Message Mark http/tests/security/contentSecurityPolicy/1.1/module-scriptnonce-invalidnonce.html as flaky. https://bugs.webkit.org/show_bug.cgi?id=171301 Unreviewed test gardening. * platform/ios-wk2/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/ios-wk2/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (215772 => 215773) --- trunk/LayoutTests/ChangeLog 2017-04-26 00:07:13 UTC (rev 215772) +++ trunk/LayoutTests/ChangeLog 2017-04-26 00:16:21 UTC (rev 215773) @@ -1,5 +1,14 @@ 2017-04-25 Ryan Haddad +Mark http/tests/security/contentSecurityPolicy/1.1/module-scriptnonce-invalidnonce.html as flaky. +https://bugs.webkit.org/show_bug.cgi?id=171301 + +Unreviewed test gardening. + +* platform/ios-wk2/TestExpectations: + +2017-04-25 Ryan Haddad + Unreviewed, rolling out r215730. The LayoutTest for this change is a flaky timeout on mac-wk1 Modified: trunk/LayoutTests/platform/ios-wk2/TestExpectations (215772 => 215773) --- trunk/LayoutTests/platform/ios-wk2/TestExpectations 2017-04-26 00:07:13 UTC (rev 215772) +++ trunk/LayoutTests/platform/ios-wk2/TestExpectations 2017-04-26 00:16:21 UTC (rev 215773) @@ -1940,3 +1940,5 @@ webkit.org/b/170153 fast/scrolling/ios/touch-scroll-visibility-hidden.html [ Failure ] webkit.org/b/169719 fast/mediacapturefromelement/CanvasCaptureMediaStream-request-frame-events.html [ Pass Failure ] + +webkit.org/b/171301 [ Release ] http/tests/security/contentSecurityPolicy/1.1/module-scriptnonce-invalidnonce.html [ Pass Timeout ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [215772] trunk
Title: [215772] trunk
Revision 215772
Author ryanhad...@apple.com
Date 2017-04-25 17:07:13 -0700 (Tue, 25 Apr 2017)
Log Message
Unreviewed, rolling out r215730.
The LayoutTest for this change is a flaky timeout on mac-wk1
debug.
Reverted changeset:
"Enable expired-only reload policy on Mac and iOS"
https://bugs.webkit.org/show_bug.cgi?id=171264
http://trac.webkit.org/changeset/215730
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/loader/display-image-unset-can-block-image-and-can-reload-in-place.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/loader/NavigationAction.cpp
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/C/WKPage.cpp
trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm
trunk/Source/WebKit2/UIProcess/Cocoa/VersionChecks.h
Diff
Modified: trunk/LayoutTests/ChangeLog (215771 => 215772)
--- trunk/LayoutTests/ChangeLog 2017-04-26 00:02:59 UTC (rev 215771)
+++ trunk/LayoutTests/ChangeLog 2017-04-26 00:07:13 UTC (rev 215772)
@@ -1,3 +1,16 @@
+2017-04-25 Ryan Haddad
+
+Unreviewed, rolling out r215730.
+
+The LayoutTest for this change is a flaky timeout on mac-wk1
+debug.
+
+Reverted changeset:
+
+"Enable expired-only reload policy on Mac and iOS"
+https://bugs.webkit.org/show_bug.cgi?id=171264
+http://trac.webkit.org/changeset/215730
+
2017-04-25 Said Abou-Hallawa
Restrict WebKit image formats to a known whitelist
Modified: trunk/LayoutTests/fast/loader/display-image-unset-can-block-image-and-can-reload-in-place.html (215771 => 215772)
--- trunk/LayoutTests/fast/loader/display-image-unset-can-block-image-and-can-reload-in-place.html 2017-04-26 00:02:59 UTC (rev 215771)
+++ trunk/LayoutTests/fast/loader/display-image-unset-can-block-image-and-can-reload-in-place.html 2017-04-26 00:07:13 UTC (rev 215772)
@@ -10,7 +10,6 @@
testRunner.dumpAsText();
window.internals.settings.setImagesEnabled(true);
testRunner.overridePreference('WebKitDisplayImagesKey', 0);
-window.internals.clearMemoryCache();
testRunner.queueReload();
}
Modified: trunk/Source/WebCore/ChangeLog (215771 => 215772)
--- trunk/Source/WebCore/ChangeLog 2017-04-26 00:02:59 UTC (rev 215771)
+++ trunk/Source/WebCore/ChangeLog 2017-04-26 00:07:13 UTC (rev 215772)
@@ -1,3 +1,16 @@
+2017-04-25 Ryan Haddad
+
+Unreviewed, rolling out r215730.
+
+The LayoutTest for this change is a flaky timeout on mac-wk1
+debug.
+
+Reverted changeset:
+
+"Enable expired-only reload policy on Mac and iOS"
+https://bugs.webkit.org/show_bug.cgi?id=171264
+http://trac.webkit.org/changeset/215730
+
2017-04-24 Matt Rajca
Indicate presence of audio when handling autoplay events.
Modified: trunk/Source/WebCore/loader/NavigationAction.cpp (215771 => 215772)
--- trunk/Source/WebCore/loader/NavigationAction.cpp 2017-04-26 00:02:59 UTC (rev 215771)
+++ trunk/Source/WebCore/loader/NavigationAction.cpp 2017-04-26 00:07:13 UTC (rev 215772)
@@ -41,7 +41,7 @@
return NavigationType::FormSubmitted;
if (haveEvent)
return NavigationType::LinkClicked;
-if (isReload(frameLoadType))
+if (frameLoadType == FrameLoadType::Reload || frameLoadType == FrameLoadType::ReloadFromOrigin)
return NavigationType::Reload;
if (isBackForwardLoadType(frameLoadType))
return NavigationType::BackForward;
Modified: trunk/Source/WebKit2/ChangeLog (215771 => 215772)
--- trunk/Source/WebKit2/ChangeLog 2017-04-26 00:02:59 UTC (rev 215771)
+++ trunk/Source/WebKit2/ChangeLog 2017-04-26 00:07:13 UTC (rev 215772)
@@ -1,3 +1,16 @@
+2017-04-25 Ryan Haddad
+
+Unreviewed, rolling out r215730.
+
+The LayoutTest for this change is a flaky timeout on mac-wk1
+debug.
+
+Reverted changeset:
+
+"Enable expired-only reload policy on Mac and iOS"
+https://bugs.webkit.org/show_bug.cgi?id=171264
+http://trac.webkit.org/changeset/215730
+
2017-04-24 Matt Rajca
Indicate presence of audio when handling autoplay events.
Modified: trunk/Source/WebKit2/UIProcess/API/C/WKPage.cpp (215771 => 215772)
--- trunk/Source/WebKit2/UIProcess/API/C/WKPage.cpp 2017-04-26 00:02:59 UTC (rev 215771)
+++ trunk/Source/WebKit2/UIProcess/API/C/WKPage.cpp 2017-04-26 00:07:13 UTC (rev 215772)
@@ -93,10 +93,6 @@
#include
#endif
-#if PLATFORM(COCOA)
-#include "VersionChecks.h"
-#endif
-
using namespace WebCore;
using namespace WebKit;
@@ -246,13 +242,7 @@
void WKPageReload(WKPageRef pageRef)
{
-OptionSet reloadOptions;
-#if PLATFORM(COCOA)
-if (linkedOnOrAfter(WebKit::SDKVersion::FirstWithExpiredOnlyReloadBehavior))
-reloadOptions |= WebCore::ReloadOption::ExpiredOnly;
-#endif
-
-toImpl(pageRef)->reload(reloadOptions);
+toImpl(pageRef)->reload({ });
}
void WKPageReloadWithoutContentBlockers(WKPageRef pageRef)
Modified: trunk/Source/WebKit2/
[webkit-changes] [215771] trunk
Title: [215771] trunk
Revision 215771
Author mra...@apple.com
Date 2017-04-25 17:02:59 -0700 (Tue, 25 Apr 2017)
Log Message
Indicate presence of audio when handling autoplay events.
https://bugs.webkit.org/show_bug.cgi?id=171227
Reviewed by Alex Christensen.
Source/WebCore:
Added API tests.
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::handleAutoplayEvent):
(WebCore::HTMLMediaElement::playInternal):
(WebCore::HTMLMediaElement::mediaPlayerTimeChanged):
(WebCore::HTMLMediaElement::stopWithoutDestroyingMediaPlayer):
(WebCore::HTMLMediaElement::userDidInterfereWithAutoplay):
(WebCore::HTMLMediaElement::setPlaybackWithoutUserGesture):
* html/HTMLMediaElement.h:
* page/AutoplayEvent.h:
* page/ChromeClient.h:
Source/WebKit2:
* UIProcess/API/APIUIClient.h:
(API::UIClient::handleAutoplayEvent):
* UIProcess/API/C/WKPage.cpp:
(WKPageSetPageUIClient):
* UIProcess/API/C/WKPageUIClient.h:
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::handleAutoplayEvent):
* UIProcess/WebPageProxy.h:
* UIProcess/WebPageProxy.messages.in:
* WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::handleAutoplayEvent):
* WebProcess/WebCoreSupport/WebChromeClient.h:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/HTMLMediaElement.cpp
trunk/Source/WebCore/html/HTMLMediaElement.h
trunk/Source/WebCore/page/AutoplayEvent.h
trunk/Source/WebCore/page/ChromeClient.h
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/Scripts/webkit/messages.py
trunk/Source/WebKit2/Shared/WebCoreArgumentCoders.h
trunk/Source/WebKit2/UIProcess/API/APIUIClient.h
trunk/Source/WebKit2/UIProcess/API/C/WKPage.cpp
trunk/Source/WebKit2/UIProcess/API/C/WKPageUIClient.h
trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp
trunk/Source/WebKit2/UIProcess/WebPageProxy.h
trunk/Source/WebKit2/UIProcess/WebPageProxy.messages.in
trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebChromeClient.cpp
trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebChromeClient.h
trunk/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm
Diff
Modified: trunk/Source/WebCore/ChangeLog (215770 => 215771)
--- trunk/Source/WebCore/ChangeLog 2017-04-25 23:50:59 UTC (rev 215770)
+++ trunk/Source/WebCore/ChangeLog 2017-04-26 00:02:59 UTC (rev 215771)
@@ -1,3 +1,23 @@
+2017-04-24 Matt Rajca
+
+Indicate presence of audio when handling autoplay events.
+https://bugs.webkit.org/show_bug.cgi?id=171227
+
+Reviewed by Alex Christensen.
+
+Added API tests.
+
+* html/HTMLMediaElement.cpp:
+(WebCore::HTMLMediaElement::handleAutoplayEvent):
+(WebCore::HTMLMediaElement::playInternal):
+(WebCore::HTMLMediaElement::mediaPlayerTimeChanged):
+(WebCore::HTMLMediaElement::stopWithoutDestroyingMediaPlayer):
+(WebCore::HTMLMediaElement::userDidInterfereWithAutoplay):
+(WebCore::HTMLMediaElement::setPlaybackWithoutUserGesture):
+* html/HTMLMediaElement.h:
+* page/AutoplayEvent.h:
+* page/ChromeClient.h:
+
2017-04-25 Aakash Jain
WebCore.framework should restrict allowable_clients
Modified: trunk/Source/WebCore/html/HTMLMediaElement.cpp (215770 => 215771)
--- trunk/Source/WebCore/html/HTMLMediaElement.cpp 2017-04-25 23:50:59 UTC (rev 215770)
+++ trunk/Source/WebCore/html/HTMLMediaElement.cpp 2017-04-26 00:02:59 UTC (rev 215771)
@@ -3242,8 +3242,7 @@
if (ScriptController::processingUserGestureForMedia()) {
if (m_playbackWithoutUserGesture == PlaybackWithoutUserGesture::Prevented) {
-if (Page* page = document().page())
-page->chrome().client().handleAutoplayEvent(AutoplayEvent::DidPlayMediaPreventedFromPlaying);
+handleAutoplayEvent(AutoplayEvent::DidPlayMediaPreventedFromPlaying);
setPlaybackWithoutUserGesture(PlaybackWithoutUserGesture::None);
}
} else
@@ -3383,16 +3382,16 @@
bool mutedStateChanged = m_muted != muted;
if (mutedStateChanged || !m_explicitlyMuted) {
-m_muted = muted;
-m_explicitlyMuted = true;
-
if (ScriptController::processingUserGestureForMedia()) {
removeBehaviorsRestrictionsAfterFirstUserGesture(MediaElementSession::AllRestrictions & ~MediaElementSession::RequireUserGestureToControlControlsManager);
-if (hasAudio() && m_muted)
+if (hasAudio() && muted)
userDidInterfereWithAutoplay();
}
+m_muted = muted;
+m_explicitlyMuted = true;
+
// Avoid recursion when the player reports volume changes.
if (!processingMediaPlayerCallback()) {
if (m_player) {
@@ -4467,10 +4466,9 @@
if (!wasSeeking)
addBehaviorRestrictionsOnEndIfNecessary();
-if (m_playbackWithoutUserGesture == PlaybackWithoutUserGesture::Started) {
-if (Page* page = document().page())
-page->chrome().client().handleAutoplayE
[webkit-changes] [215770] trunk/JSTests
Title: [215770] trunk/JSTests
Revision 215770
Author mark@apple.com
Date 2017-04-25 16:50:59 -0700 (Tue, 25 Apr 2017)
Log Message
[Follow up] Array.prototype.slice() should ensure that end >= begin.
https://bugs.webkit.org/show_bug.cgi?id=170989
Not reviewed.
Follow up to rename a test file that was accidentally named wrongly.
* stress/regress-170989.js: Copied from JSTests/stress/regress-170989.patch.
* stress/regress-170989.patch: Removed.
Modified Paths
trunk/JSTests/ChangeLog
Added Paths
trunk/JSTests/stress/regress-170989.js
Removed Paths
trunk/JSTests/stress/regress-170989.patch
Diff
Modified: trunk/JSTests/ChangeLog (215769 => 215770)
--- trunk/JSTests/ChangeLog 2017-04-25 23:49:14 UTC (rev 215769)
+++ trunk/JSTests/ChangeLog 2017-04-25 23:50:59 UTC (rev 215770)
@@ -1,5 +1,18 @@
2017-04-25 Mark Lam
+[Follow up] Array.prototype.slice() should ensure that end >= begin.
+https://bugs.webkit.org/show_bug.cgi?id=170989
+
+
+Not reviewed.
+
+Follow up to rename a test file that was accidentally named wrongly.
+
+* stress/regress-170989.js: Copied from JSTests/stress/regress-170989.patch.
+* stress/regress-170989.patch: Removed.
+
+2017-04-25 Mark Lam
+
Array.prototype.slice() should ensure that end >= begin.
https://bugs.webkit.org/show_bug.cgi?id=170989
Copied: trunk/JSTests/stress/regress-170989.js (from rev 215769, trunk/JSTests/stress/regress-170989.patch) (0 => 215770)
--- trunk/JSTests/stress/regress-170989.js (rev 0)
+++ trunk/JSTests/stress/regress-170989.js 2017-04-25 23:50:59 UTC (rev 215770)
@@ -0,0 +1,7 @@
+class C extends Array {}
+var c = new C();
+c.push(2,4,6);
+var result = c.slice(9,2);
+if (result.length)
+throw ("FAILED: expected 0, actual " + result.length);
+
Deleted: trunk/JSTests/stress/regress-170989.patch (215769 => 215770)
--- trunk/JSTests/stress/regress-170989.patch 2017-04-25 23:49:14 UTC (rev 215769)
+++ trunk/JSTests/stress/regress-170989.patch 2017-04-25 23:50:59 UTC (rev 215770)
@@ -1,7 +0,0 @@
-class C extends Array {}
-var c = new C();
-c.push(2,4,6);
-var result = c.slice(9,2);
-if (result.length)
-throw ("FAILED: expected 0, actual " + result.length);
-
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [215769] trunk/Source/WebCore
Title: [215769] trunk/Source/WebCore Revision 215769 Author aakash_j...@apple.com Date 2017-04-25 16:49:14 -0700 (Tue, 25 Apr 2017) Log Message WebCore.framework should restrict allowable_clients https://bugs.webkit.org/show_bug.cgi?id=171260 Reviewed by Alexey Proskuryakov. * Configurations/WebCore.xcconfig: Adding allowable_client to all platform, in order to restrict WebCore from being directly linked on any platform. Moved WebKitLegacy and WebCoreTestSupport to OTHER_LDFLAGS_BASE. Removed WebKit2 as allowable_client from mac. Added iTunesU, Casablanca and Remote to OTHER_LDFLAGS_BASE_ios for iTunes related projects. Added WebKit, TVBooks, DumpRenderTree, WebKitTestRunner and TestWebKitAPI to OTHER_LDFLAGS_BASE_ios. Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/Configurations/WebCore.xcconfig Diff Modified: trunk/Source/WebCore/ChangeLog (215768 => 215769) --- trunk/Source/WebCore/ChangeLog 2017-04-25 23:45:45 UTC (rev 215768) +++ trunk/Source/WebCore/ChangeLog 2017-04-25 23:49:14 UTC (rev 215769) @@ -1,3 +1,17 @@ +2017-04-25 Aakash Jain + +WebCore.framework should restrict allowable_clients +https://bugs.webkit.org/show_bug.cgi?id=171260 + +Reviewed by Alexey Proskuryakov. + +* Configurations/WebCore.xcconfig: Adding allowable_client to all platform, in order to restrict WebCore +from being directly linked on any platform. +Moved WebKitLegacy and WebCoreTestSupport to OTHER_LDFLAGS_BASE. +Removed WebKit2 as allowable_client from mac. +Added iTunesU, Casablanca and Remote to OTHER_LDFLAGS_BASE_ios for iTunes related projects. +Added WebKit, TVBooks, DumpRenderTree, WebKitTestRunner and TestWebKitAPI to OTHER_LDFLAGS_BASE_ios. + 2017-04-25 Said Abou-Hallawa Restrict WebKit image formats to a known whitelist Modified: trunk/Source/WebCore/Configurations/WebCore.xcconfig (215768 => 215769) --- trunk/Source/WebCore/Configurations/WebCore.xcconfig 2017-04-25 23:45:45 UTC (rev 215768) +++ trunk/Source/WebCore/Configurations/WebCore.xcconfig 2017-04-25 23:49:14 UTC (rev 215769) @@ -78,11 +78,12 @@ LIBWEBRTC_LIBRARY_DIR_USE_OVERRIDE_FRAMEWORKS_DIR_YES = $(WK_OVERRIDE_FRAMEWORKS_DIR); OTHER_LDFLAGS = $(inherited) $(WK_RELOCATABLE_FRAMEWORK_LDFLAGS) $(OTHER_LDFLAGS_PLATFORM); -OTHER_LDFLAGS_BASE = -lsqlite3 -lobjc -lANGLE -framework Metal; -OTHER_LDFLAGS_BASE_ios = $(OTHER_LDFLAGS_BASE) -framework CFNetwork -framework CoreGraphics -framework CoreText -framework Foundation -framework ImageIO -framework MobileCoreServices -framework OpenGLES -lMobileGestalt $(WK_IOS_BINCOMPAT_LDFLAGS); +OTHER_LDFLAGS_BASE = -lsqlite3 -lobjc -lANGLE -framework Metal -allowable_client WebCoreTestSupport -allowable_client WebKitLegacy; +// FIXME: Reduce the number of allowable_client +OTHER_LDFLAGS_BASE_ios = $(OTHER_LDFLAGS_BASE) -framework CFNetwork -framework CoreGraphics -framework CoreText -framework Foundation -framework ImageIO -framework MobileCoreServices -framework OpenGLES -lMobileGestalt $(WK_IOS_BINCOMPAT_LDFLAGS) -allowable_client WebKit -allowable_client iTunesU -allowable_client Casablanca -allowable_client Remote -allowable_client TVBooks -allowable_client DumpRenderTree -allowable_client WebKitTestRunner -allowable_client TestWebKitAPI; OTHER_LDFLAGS_PLATFORM[sdk=iphoneos*] = $(OTHER_LDFLAGS_BASE_ios) -framework IOSurface -framework GraphicsServices $(LIBWEBRTC_LDFLAGS); OTHER_LDFLAGS_PLATFORM[sdk=iphonesimulator*] = $(OTHER_LDFLAGS_BASE_ios) $(LIBWEBRTC_LDFLAGS); -OTHER_LDFLAGS_PLATFORM[sdk=macosx*] = $(OTHER_LDFLAGS_BASE) -sub_library libobjc -umbrella WebKit -allowable_client WebCoreTestSupport -allowable_client WebKit2 -allowable_client WebKitLegacy -framework ApplicationServices -framework AudioUnit -framework Carbon -framework Cocoa -framework CoreAudio -framework DataDetectorsCore -framework IOSurface -framework OpenGL -framework SystemConfiguration $(LIBWEBRTC_LDFLAGS); +OTHER_LDFLAGS_PLATFORM[sdk=macosx*] = $(OTHER_LDFLAGS_BASE) -sub_library libobjc -umbrella WebKit -framework ApplicationServices -framework AudioUnit -framework Carbon -framework Cocoa -framework CoreAudio -framework DataDetectorsCore -framework IOSurface -framework OpenGL -framework SystemConfiguration $(LIBWEBRTC_LDFLAGS); SECTORDER_FLAGS = $(SECTORDER_FLAGS_$(CONFIGURATION)); SECTORDER_FLAGS_Production[sdk=iphoneos*] = -Wl,-order_file,$(SDKROOT)/AppleInternal/OrderFiles/WebCore.order; ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [215768] trunk
Title: [215768] trunk
Revision 215768
Author mark@apple.com
Date 2017-04-25 16:45:45 -0700 (Tue, 25 Apr 2017)
Log Message
Array.prototype.slice() should ensure that end >= begin.
https://bugs.webkit.org/show_bug.cgi?id=170989
Reviewed by Saam Barati.
JSTests:
* stress/regress-170989.patch: Added.
Source/_javascript_Core:
* runtime/ArrayPrototype.cpp:
(JSC::arrayProtoFuncSlice):
Modified Paths
trunk/JSTests/ChangeLog
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/runtime/ArrayPrototype.cpp
Added Paths
trunk/JSTests/stress/regress-170989.patch
Diff
Modified: trunk/JSTests/ChangeLog (215767 => 215768)
--- trunk/JSTests/ChangeLog 2017-04-25 22:23:56 UTC (rev 215767)
+++ trunk/JSTests/ChangeLog 2017-04-25 23:45:45 UTC (rev 215768)
@@ -1,5 +1,15 @@
2017-04-25 Mark Lam
+Array.prototype.slice() should ensure that end >= begin.
+https://bugs.webkit.org/show_bug.cgi?id=170989
+
+
+Reviewed by Saam Barati.
+
+* stress/regress-170989.patch: Added.
+
+2017-04-25 Mark Lam
+
Local CSE wrongly CSEs array accesses with different result types.
https://bugs.webkit.org/show_bug.cgi?id=170990
Added: trunk/JSTests/stress/regress-170989.patch (0 => 215768)
--- trunk/JSTests/stress/regress-170989.patch (rev 0)
+++ trunk/JSTests/stress/regress-170989.patch 2017-04-25 23:45:45 UTC (rev 215768)
@@ -0,0 +1,7 @@
+class C extends Array {}
+var c = new C();
+c.push(2,4,6);
+var result = c.slice(9,2);
+if (result.length)
+throw ("FAILED: expected 0, actual " + result.length);
+
Modified: trunk/Source/_javascript_Core/ChangeLog (215767 => 215768)
--- trunk/Source/_javascript_Core/ChangeLog 2017-04-25 22:23:56 UTC (rev 215767)
+++ trunk/Source/_javascript_Core/ChangeLog 2017-04-25 23:45:45 UTC (rev 215768)
@@ -1,3 +1,14 @@
+2017-04-25 Mark Lam
+
+Array.prototype.slice() should ensure that end >= begin.
+https://bugs.webkit.org/show_bug.cgi?id=170989
+
+
+Reviewed by Saam Barati.
+
+* runtime/ArrayPrototype.cpp:
+(JSC::arrayProtoFuncSlice):
+
2017-04-25 Don Olmstead
[Win] Use Clang's __has_declspec_attribute for export macros
Modified: trunk/Source/_javascript_Core/runtime/ArrayPrototype.cpp (215767 => 215768)
--- trunk/Source/_javascript_Core/runtime/ArrayPrototype.cpp 2017-04-25 22:23:56 UTC (rev 215767)
+++ trunk/Source/_javascript_Core/runtime/ArrayPrototype.cpp 2017-04-25 23:45:45 UTC (rev 215768)
@@ -931,6 +931,8 @@
RETURN_IF_EXCEPTION(scope, { });
unsigned end = argumentClampedIndexFromStartOrEnd(exec, 1, length, length);
RETURN_IF_EXCEPTION(scope, { });
+if (end < begin)
+end = begin;
std::pair speciesResult = speciesConstructArray(exec, thisObj, end - begin);
// We can only get an exception if we call some user function.
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [215767] trunk
Title: [215767] trunk
Revision 215767
Author commit-qu...@webkit.org
Date 2017-04-25 15:23:56 -0700 (Tue, 25 Apr 2017)
Log Message
Restrict WebKit image formats to a known whitelist
https://bugs.webkit.org/show_bug.cgi?id=170700
Patch by Said Abou-Hallawa on 2017-04-25
Reviewed by Tim Horton.
Source/WebCore:
If the image format is not supported, the load should be canceled and the
image is marked a broken image.
Test: fast/images/image-formats-support.html
* loader/cache/CachedImage.cpp:
(WebCore::CachedImage::addIncrementalDataBuffer):
(WebCore::CachedImage::setImageDataBuffer):
(WebCore::CachedImage::finishLoading):
* loader/cache/CachedImage.h:
LayoutTests:
* fast/images/image-formats-support-expected.txt: Added.
* fast/images/image-formats-support.html: Added.
* fast/images/resources/100x100-red-psd-renamed.png: Added.
* fast/images/resources/100x100-red-tga-renamed.png: Added.
* fast/images/resources/100x100-red.psd: Added.
* fast/images/resources/100x100-red.tga: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/loader/cache/CachedImage.cpp
trunk/Source/WebCore/loader/cache/CachedImage.h
Added Paths
trunk/LayoutTests/fast/images/image-formats-support-expected.txt
trunk/LayoutTests/fast/images/image-formats-support.html
trunk/LayoutTests/fast/images/resources/100x100-red-psd-renamed.png
trunk/LayoutTests/fast/images/resources/100x100-red-tga-renamed.png
trunk/LayoutTests/fast/images/resources/100x100-red.psd
trunk/LayoutTests/fast/images/resources/100x100-red.tga
Diff
Modified: trunk/LayoutTests/ChangeLog (215766 => 215767)
--- trunk/LayoutTests/ChangeLog 2017-04-25 21:46:54 UTC (rev 215766)
+++ trunk/LayoutTests/ChangeLog 2017-04-25 22:23:56 UTC (rev 215767)
@@ -1,3 +1,17 @@
+2017-04-25 Said Abou-Hallawa
+
+Restrict WebKit image formats to a known whitelist
+https://bugs.webkit.org/show_bug.cgi?id=170700
+
+Reviewed by Tim Horton.
+
+* fast/images/image-formats-support-expected.txt: Added.
+* fast/images/image-formats-support.html: Added.
+* fast/images/resources/100x100-red-psd-renamed.png: Added.
+* fast/images/resources/100x100-red-tga-renamed.png: Added.
+* fast/images/resources/100x100-red.psd: Added.
+* fast/images/resources/100x100-red.tga: Added.
+
2017-04-25 Tim Horton
Deduplicate some lines in the toplevel TestExpectations
Added: trunk/LayoutTests/fast/images/image-formats-support-expected.txt (0 => 215767)
--- trunk/LayoutTests/fast/images/image-formats-support-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/images/image-formats-support-expected.txt 2017-04-25 22:23:56 UTC (rev 215767)
@@ -0,0 +1,13 @@
+Test the whitelist of the image formats in WebKit.
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+PASS shouldBeSupported('resources/100x100-red.psd').toString() is 'false'
+PASS shouldBeSupported('resources/100x100-red.tga').toString() is 'false'
+PASS shouldBeSupported('resources/100x100-red-psd-renamed.png').toString() is 'false'
+PASS shouldBeSupported('resources/100x100-red-tga-renamed.png').toString() is 'false'
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
Added: trunk/LayoutTests/fast/images/image-formats-support.html (0 => 215767)
--- trunk/LayoutTests/fast/images/image-formats-support.html (rev 0)
+++ trunk/LayoutTests/fast/images/image-formats-support.html 2017-04-25 22:23:56 UTC (rev 215767)
@@ -0,0 +1,74 @@
+
+
+
+img {
+width: 100px;
+height: 100px;
+}
+
+
+
+![]()
+// The test finishes after getting the results of loading all the images.
+jsTestIsAsync = true;
+
+description("Test the whitelist of the image formats in WebKit.");
+
+var images = [
+{ id: "image-1", src: "resources/100x100-red.psd", shouldBeSupported: false },
+{ id: "image-2", src: "resources/100x100-red.tga", shouldBeSupported: false },
+{ id: "image-3", src: "resources/100x100-red-psd-renamed.png", shouldBeSupported: false },
+{ id: "image-4", src: "resources/100x100-red-tga-renamed.png", shouldBeSupported: false },
+];
+
+var finishedImages = 0;
+
+function trimImageSource(src) {
+var index = src.lastIndexOf('/');
+if (index != -1)
+index = src.lastIndexOf('/', index - 1);
+return index != -1 ? src.slice(index + 1) : src;
+}
+
+function shouldBeSupported(src) {
+var image = images.find(function(image) {
+return image.src == src;
+});
+
+if (image == undefined) {
+debug("Error: Unknown image src.");
+return false;
[webkit-changes] [215766] trunk/Source
Title: [215766] trunk/Source
Revision 215766
Author commit-qu...@webkit.org
Date 2017-04-25 14:46:54 -0700 (Tue, 25 Apr 2017)
Log Message
[Win] Use Clang's __has_declspec_attribute for export macros
https://bugs.webkit.org/show_bug.cgi?id=171240
Patch by Don Olmstead on 2017-04-25
Reviewed by Alex Christensen.
Source/_javascript_Core:
* runtime/JSExportMacros.h:
Source/WTF:
* wtf/Compiler.h:
* wtf/ExportMacros.h:
* wtf/Platform.h:
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/runtime/JSExportMacros.h
trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/Compiler.h
trunk/Source/WTF/wtf/ExportMacros.h
trunk/Source/WTF/wtf/Platform.h
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (215765 => 215766)
--- trunk/Source/_javascript_Core/ChangeLog 2017-04-25 21:45:24 UTC (rev 215765)
+++ trunk/Source/_javascript_Core/ChangeLog 2017-04-25 21:46:54 UTC (rev 215766)
@@ -1,3 +1,12 @@
+2017-04-25 Don Olmstead
+
+[Win] Use Clang's __has_declspec_attribute for export macros
+https://bugs.webkit.org/show_bug.cgi?id=171240
+
+Reviewed by Alex Christensen.
+
+* runtime/JSExportMacros.h:
+
2017-04-25 Saam Barati
Unreviewed. Attempt armv7k build fix after r215720
Modified: trunk/Source/_javascript_Core/runtime/JSExportMacros.h (215765 => 215766)
--- trunk/Source/_javascript_Core/runtime/JSExportMacros.h 2017-04-25 21:45:24 UTC (rev 215765)
+++ trunk/Source/_javascript_Core/runtime/JSExportMacros.h 2017-04-25 21:46:54 UTC (rev 215766)
@@ -46,7 +46,7 @@
#else // !USE(EXPORT_MACROS)
-#if OS(WINDOWS) && !COMPILER(GCC_OR_CLANG)
+#if USE(DECLSPEC_ATTRIBUTE)
#if defined(BUILDING_JavaScriptCore) || defined(STATICALLY_LINKED_WITH_JavaScriptCore)
#define JS_EXPORTDATA __declspec(dllexport)
Modified: trunk/Source/WTF/ChangeLog (215765 => 215766)
--- trunk/Source/WTF/ChangeLog 2017-04-25 21:45:24 UTC (rev 215765)
+++ trunk/Source/WTF/ChangeLog 2017-04-25 21:46:54 UTC (rev 215766)
@@ -1,3 +1,14 @@
+2017-04-25 Don Olmstead
+
+[Win] Use Clang's __has_declspec_attribute for export macros
+https://bugs.webkit.org/show_bug.cgi?id=171240
+
+Reviewed by Alex Christensen.
+
+* wtf/Compiler.h:
+* wtf/ExportMacros.h:
+* wtf/Platform.h:
+
2017-04-25 Keith Miller
Our signal handler shouldn't print when sigaction succeeds
Modified: trunk/Source/WTF/wtf/Compiler.h (215765 => 215766)
--- trunk/Source/WTF/wtf/Compiler.h 2017-04-25 21:45:24 UTC (rev 215765)
+++ trunk/Source/WTF/wtf/Compiler.h 2017-04-25 21:46:54 UTC (rev 215766)
@@ -50,6 +50,14 @@
#define COMPILER_HAS_CLANG_FEATURE(x) 0
#endif
+/* COMPILER_HAS_CLANG_DECLSPEC() - whether the compiler supports a Microsoft style __declspec attribute. */
+/* https://clang.llvm.org/docs/LanguageExtensions.html#has-declspec-attribute */
+#ifdef __has_declspec_attribute
+#define COMPILER_HAS_CLANG_DECLSPEC(x) __has_declspec_attribute(x)
+#else
+#define COMPILER_HAS_CLANG_DECLSPEC(x) 0
+#endif
+
/* COMPILER() - primary detection of the compiler being used to build the project, in alphabetical order */
/* COMPILER(CLANG) - Clang */
Modified: trunk/Source/WTF/wtf/ExportMacros.h (215765 => 215766)
--- trunk/Source/WTF/wtf/ExportMacros.h 2017-04-25 21:45:24 UTC (rev 215765)
+++ trunk/Source/WTF/wtf/ExportMacros.h 2017-04-25 21:46:54 UTC (rev 215766)
@@ -38,10 +38,10 @@
// being local to the target being generated, and thus not subject to (e.g.) ELF
// symbol interposition rules.
-#if OS(WINDOWS)
+#if USE(DECLSPEC_ATTRIBUTE)
#define HAVE_INTERNAL_VISIBILITY 1
#define WTF_INTERNAL
-#elif defined(__GNUC__) && !defined(__CC_ARM) && !defined(__ARMCC__)
+#elif USE(VISIBILITY_ATTRIBUTE)
#define HAVE_INTERNAL_VISIBILITY 1
#define WTF_INTERNAL __attribute__((visibility("hidden")))
#else
@@ -48,13 +48,13 @@
#define WTF_INTERNAL
#endif
-#if OS(WINDOWS)
+#if USE(DECLSPEC_ATTRIBUTE)
#define WTF_EXPORT_DECLARATION __declspec(dllexport)
#define WTF_IMPORT_DECLARATION __declspec(dllimport)
#define WTF_HIDDEN_DECLARATION
-#elif defined(__GNUC__) && !defined(__CC_ARM) && !defined(__ARMCC__)
+#elif USE(VISIBILITY_ATTRIBUTE)
#define WTF_EXPORT_DECLARATION __attribute__((visibility("default")))
#define WTF_IMPORT_DECLARATION WTF_EXPORT_DECLARATION
@@ -89,7 +89,7 @@
#else // !USE(EXPORT_MACROS)
-#if OS(WINDOWS) && !COMPILER(GCC_OR_CLANG)
+#if USE(DECLSPEC_ATTRIBUTE)
#if defined(BUILDING_WTF) || defined(STATICALLY_LINKED_WITH_WTF)
#define WTF_EXPORTDATA __declspec(dllexport)
#else
Modified: trunk/Source/WTF/wtf/Platform.h (215765 => 215766)
--- trunk/Source/WTF/wtf/Platform.h 2017-04-25 21:45:24 UTC (rev 215765)
+++ trunk/Source/WTF/wtf/Platform.h 2017-04-25 21:46:54 UTC (rev 215766)
@@ -434,6 +434,20 @@
/* Operating environments */
+/* Export macro support. Detects the attributes available for shared library symbol export
+ decorations. */
+#if OS(WINDOWS) \
+|| (COMPILER_HAS_C
[webkit-changes] [215765] trunk/LayoutTests
Title: [215765] trunk/LayoutTests Revision 215765 Author timothy_hor...@apple.com Date 2017-04-25 14:45:24 -0700 (Tue, 25 Apr 2017) Log Message Deduplicate some lines in the toplevel TestExpectations * TestExpectations: Remove a duplicate line and consolidate another. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (215764 => 215765) --- trunk/LayoutTests/ChangeLog 2017-04-25 21:41:31 UTC (rev 215764) +++ trunk/LayoutTests/ChangeLog 2017-04-25 21:45:24 UTC (rev 215765) @@ -1,3 +1,10 @@ +2017-04-25 Tim Horton + +Deduplicate some lines in the toplevel TestExpectations + +* TestExpectations: +Remove a duplicate line and consolidate another. + 2017-04-25 Chris Dumez Element.dataset.name incorrectly returns undefined Modified: trunk/LayoutTests/TestExpectations (215764 => 215765) --- trunk/LayoutTests/TestExpectations 2017-04-25 21:41:31 UTC (rev 215764) +++ trunk/LayoutTests/TestExpectations 2017-04-25 21:45:24 UTC (rev 215765) @@ -791,9 +791,7 @@ webkit.org/b/148950 imported/w3c/web-platform-tests/html/semantics/document-metadata/the-base-element/base_href_specified.sub.html [ Skip ] imported/w3c/web-platform-tests/WebCryptoAPI/sign_verify/test_ecdsa.html [ Pass Failure ] -imported/w3c/web-platform-tests/html/semantics/text-level-semantics/the-a-element/a-download-click.html [ Pass Failure ] imported/w3c/web-platform-tests/html/browsers/history/the-history-interface/history_go_zero.html [ Pass Failure ] -imported/w3c/web-platform-tests/html/browsers/history/the-history-interface/history_go_zero.html [ Pass Failure ] # FIXME: The following failures need individual bugs. webkit.org/b/148805 imported/w3c/css/css-multicol-1/multicol-inherit-003.xht [ ImageOnlyFailure ] @@ -1106,7 +1104,7 @@ webkit.org/b/168175 imported/w3c/web-platform-tests/html/semantics/embedded-content/the-area-element/area-download-click.html [ Pass Failure ] webkit.org/b/168175 imported/w3c/web-platform-tests/html/browsers/browsing-the-web/history-traversal/same-url.html [ Pass Failure ] webkit.org/b/168175 imported/w3c/web-platform-tests/html/browsers/offline/browser-state/navigator_online_online.html [ Pass Failure ] -webkit.org/b/168175 imported/w3c/web-platform-tests/html/semantics/text-level-semantics/the-a-element/a-download-click.html [ Timeout Pass ] +webkit.org/b/168175 imported/w3c/web-platform-tests/html/semantics/text-level-semantics/the-a-element/a-download-click.html [ Timeout Pass Failure ] webkit.org/b/169264 imported/w3c/web-platform-tests/html/browsers/browsing-the-web/history-traversal/persisted-user-state-restoration/scroll-restoration-navigation-samedoc.html [ Failure ] webkit.org/b/168066 performance-api/performance-now-api.html [ Pass Failure ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [215764] trunk/LayoutTests
Title: [215764] trunk/LayoutTests Revision 215764 Author cdu...@apple.com Date 2017-04-25 14:41:31 -0700 (Tue, 25 Apr 2017) Log Message Element.dataset.name incorrectly returns undefined https://bugs.webkit.org/show_bug.cgi?id=161454 Reviewed by Mark Lam. Add layout test for JS caching bug on DOMStringMap that was fixed as part of a large named property getter refactoring in r210667. * fast/dom/dataset-caching-bug-expected.txt: Added. * fast/dom/dataset-caching-bug.html: Added. Modified Paths trunk/LayoutTests/ChangeLog Added Paths trunk/LayoutTests/fast/dom/dataset-caching-bug-expected.txt trunk/LayoutTests/fast/dom/dataset-caching-bug.html Diff Modified: trunk/LayoutTests/ChangeLog (215763 => 215764) --- trunk/LayoutTests/ChangeLog 2017-04-25 21:36:21 UTC (rev 215763) +++ trunk/LayoutTests/ChangeLog 2017-04-25 21:41:31 UTC (rev 215764) @@ -1,3 +1,17 @@ +2017-04-25 Chris Dumez + +Element.dataset.name incorrectly returns undefined +https://bugs.webkit.org/show_bug.cgi?id=161454 + + +Reviewed by Mark Lam. + +Add layout test for JS caching bug on DOMStringMap that was fixed as part +of a large named property getter refactoring in r210667. + +* fast/dom/dataset-caching-bug-expected.txt: Added. +* fast/dom/dataset-caching-bug.html: Added. + 2017-04-25 Myles C. Maxfield Supplementary Multilingual Plane Complex Scripts Rendered Incorrectly Added: trunk/LayoutTests/fast/dom/dataset-caching-bug-expected.txt (0 => 215764) --- trunk/LayoutTests/fast/dom/dataset-caching-bug-expected.txt (rev 0) +++ trunk/LayoutTests/fast/dom/dataset-caching-bug-expected.txt 2017-04-25 21:41:31 UTC (rev 215764) @@ -0,0 +1,10 @@ +Tests for a caching bug on DOMStringMap causing us to return an outdated value. + +On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE". + + +PASS The bug did not reproduce. +PASS successfullyParsed is true + +TEST COMPLETE + Added: trunk/LayoutTests/fast/dom/dataset-caching-bug.html (0 => 215764) --- trunk/LayoutTests/fast/dom/dataset-caching-bug.html (rev 0) +++ trunk/LayoutTests/fast/dom/dataset-caching-bug.html 2017-04-25 21:41:31 UTC (rev 215764) @@ -0,0 +1,35 @@ + + + +