[webkit-changes] [221665] trunk/Source/WebCore
Title: [221665] trunk/Source/WebCore Revision 221665 Author zandober...@gmail.com Date 2017-09-05 23:48:49 -0700 (Tue, 05 Sep 2017) Log Message [WebCrypto] Downcast parameters and keys at the platform operation callsites https://bugs.webkit.org/show_bug.cgi?id=176392 Reviewed by Sam Weinig. Downcast to algorithm-specific parameter and key types in the shared code that then invokes platform-specific operation implementations. This reduces the duplicated downcasts across different implementations that don't differ at all in this behavior. Covered by existing tests. * crypto/algorithms/CryptoAlgorithmAES_CBC.cpp: (WebCore::CryptoAlgorithmAES_CBC::encrypt): (WebCore::CryptoAlgorithmAES_CBC::decrypt): * crypto/algorithms/CryptoAlgorithmAES_CBC.h: * crypto/algorithms/CryptoAlgorithmAES_CFB.cpp: (WebCore::CryptoAlgorithmAES_CFB::encrypt): (WebCore::CryptoAlgorithmAES_CFB::decrypt): * crypto/algorithms/CryptoAlgorithmAES_CFB.h: * crypto/algorithms/CryptoAlgorithmAES_CTR.cpp: (WebCore::CryptoAlgorithmAES_CTR::encrypt): (WebCore::CryptoAlgorithmAES_CTR::decrypt): * crypto/algorithms/CryptoAlgorithmAES_CTR.h: * crypto/algorithms/CryptoAlgorithmAES_GCM.cpp: (WebCore::CryptoAlgorithmAES_GCM::encrypt): (WebCore::CryptoAlgorithmAES_GCM::decrypt): * crypto/algorithms/CryptoAlgorithmAES_GCM.h: * crypto/algorithms/CryptoAlgorithmAES_KW.cpp: (WebCore::CryptoAlgorithmAES_KW::wrapKey): (WebCore::CryptoAlgorithmAES_KW::unwrapKey): * crypto/algorithms/CryptoAlgorithmAES_KW.h: * crypto/algorithms/CryptoAlgorithmECDH.cpp: (WebCore::CryptoAlgorithmECDH::deriveBits): * crypto/algorithms/CryptoAlgorithmECDH.h: * crypto/algorithms/CryptoAlgorithmECDSA.cpp: (WebCore::CryptoAlgorithmECDSA::sign): (WebCore::CryptoAlgorithmECDSA::verify): * crypto/algorithms/CryptoAlgorithmECDSA.h: * crypto/algorithms/CryptoAlgorithmHKDF.cpp: (WebCore::CryptoAlgorithmHKDF::deriveBits): * crypto/algorithms/CryptoAlgorithmHKDF.h: * crypto/algorithms/CryptoAlgorithmHMAC.cpp: (WebCore::CryptoAlgorithmHMAC::sign): (WebCore::CryptoAlgorithmHMAC::verify): * crypto/algorithms/CryptoAlgorithmHMAC.h: * crypto/algorithms/CryptoAlgorithmPBKDF2.cpp: (WebCore::CryptoAlgorithmPBKDF2::deriveBits): * crypto/algorithms/CryptoAlgorithmPBKDF2.h: * crypto/algorithms/CryptoAlgorithmRSAES_PKCS1_v1_5.cpp: (WebCore::CryptoAlgorithmRSAES_PKCS1_v1_5::encrypt): (WebCore::CryptoAlgorithmRSAES_PKCS1_v1_5::decrypt): * crypto/algorithms/CryptoAlgorithmRSAES_PKCS1_v1_5.h: * crypto/algorithms/CryptoAlgorithmRSASSA_PKCS1_v1_5.cpp: (WebCore::CryptoAlgorithmRSASSA_PKCS1_v1_5::sign): (WebCore::CryptoAlgorithmRSASSA_PKCS1_v1_5::verify): * crypto/algorithms/CryptoAlgorithmRSASSA_PKCS1_v1_5.h: * crypto/algorithms/CryptoAlgorithmRSA_OAEP.cpp: (WebCore::CryptoAlgorithmRSA_OAEP::encrypt): (WebCore::CryptoAlgorithmRSA_OAEP::decrypt): * crypto/algorithms/CryptoAlgorithmRSA_OAEP.h: * crypto/algorithms/CryptoAlgorithmRSA_PSS.cpp: (WebCore::CryptoAlgorithmRSA_PSS::sign): (WebCore::CryptoAlgorithmRSA_PSS::verify): * crypto/algorithms/CryptoAlgorithmRSA_PSS.h: * crypto/gcrypt/CryptoAlgorithmAES_CBCGCrypt.cpp: (WebCore::CryptoAlgorithmAES_CBC::platformEncrypt): (WebCore::CryptoAlgorithmAES_CBC::platformDecrypt): * crypto/gcrypt/CryptoAlgorithmAES_CFBGCrypt.cpp: (WebCore::CryptoAlgorithmAES_CFB::platformEncrypt): (WebCore::CryptoAlgorithmAES_CFB::platformDecrypt): * crypto/gcrypt/CryptoAlgorithmAES_CTRGCrypt.cpp: (WebCore::CryptoAlgorithmAES_CTR::platformEncrypt): (WebCore::CryptoAlgorithmAES_CTR::platformDecrypt): * crypto/gcrypt/CryptoAlgorithmAES_GCMGCrypt.cpp: (WebCore::CryptoAlgorithmAES_GCM::platformEncrypt): (WebCore::CryptoAlgorithmAES_GCM::platformDecrypt): * crypto/gcrypt/CryptoAlgorithmAES_KWGCrypt.cpp: (WebCore::CryptoAlgorithmAES_KW::platformWrapKey): (WebCore::CryptoAlgorithmAES_KW::platformUnwrapKey): * crypto/gcrypt/CryptoAlgorithmECDHGCrypt.cpp: (WebCore::CryptoAlgorithmECDH::platformDeriveBits): * crypto/gcrypt/CryptoAlgorithmECDSAGCrypt.cpp: (WebCore::CryptoAlgorithmECDSA::platformSign): (WebCore::CryptoAlgorithmECDSA::platformVerify): * crypto/gcrypt/CryptoAlgorithmHKDFGCrypt.cpp: (WebCore::CryptoAlgorithmHKDF::platformDeriveBits): * crypto/gcrypt/CryptoAlgorithmHMACGCrypt.cpp: (WebCore::CryptoAlgorithmHMAC::platformSign): (WebCore::CryptoAlgorithmHMAC::platformVerify): * crypto/gcrypt/CryptoAlgorithmPBKDF2GCrypt.cpp: (WebCore::CryptoAlgorithmPBKDF2::platformDeriveBits): * crypto/gcrypt/CryptoAlgorithmRSAES_PKCS1_v1_5GCrypt.cpp: (WebCore::CryptoAlgorithmRSAES_PKCS1_v1_5::platformEncrypt): (WebCore::CryptoAlgorithmRSAES_PKCS1_v1_5::platformDecrypt): * crypto/gcrypt/CryptoAlgorithmRSASSA_PKCS1_v1_5GCrypt.cpp: (WebCore::CryptoAlgorithmRSASSA_PKCS1_v1_5::platformSign): (WebCore::CryptoAlgorithmRSASSA_PKCS1_v1_5::platformVerify): * crypto/gcrypt/CryptoAlgorithmRSA_OAEPGCrypt.cpp: (WebCore::CryptoAlgorithmRSA_OAEP::platformEncrypt): (WebCore::CryptoAlgorithmRSA_OAEP::platformDecrypt): * crypto/gcrypt/CryptoAlgorithmRSA_PSSGCrypt.cpp: (WebCore::CryptoAlgorithmRSA_PSS::platformSign
[webkit-changes] [221664] trunk/Websites/perf.webkit.org
Title: [221664] trunk/Websites/perf.webkit.org
Revision 221664
Author rn...@webkit.org
Date 2017-09-05 22:25:14 -0700 (Tue, 05 Sep 2017)
Log Message
Add a button to show two weeks of data to perf dashboard
https://bugs.webkit.org/show_bug.cgi?id=176438
Reviewed by Saam Barati.
Add "2W" button to show 14 days of data on dashboard pages.
* public/v3/pages/dashboard-toolbar.js:
(DashboardToolbar):
Modified Paths
trunk/Websites/perf.webkit.org/ChangeLog
trunk/Websites/perf.webkit.org/public/v3/pages/dashboard-toolbar.js
Diff
Modified: trunk/Websites/perf.webkit.org/ChangeLog (221663 => 221664)
--- trunk/Websites/perf.webkit.org/ChangeLog 2017-09-06 05:02:43 UTC (rev 221663)
+++ trunk/Websites/perf.webkit.org/ChangeLog 2017-09-06 05:25:14 UTC (rev 221664)
@@ -1,3 +1,15 @@
+2017-09-05 Ryosuke Niwa
+
+Add a button to show two weeks of data to perf dashboard
+https://bugs.webkit.org/show_bug.cgi?id=176438
+
+Reviewed by Saam Barati.
+
+Add "2W" button to show 14 days of data on dashboard pages.
+
+* public/v3/pages/dashboard-toolbar.js:
+(DashboardToolbar):
+
2017-08-29 Ryosuke Niwa
Build fix. OS X "revision" can have a space.
Modified: trunk/Websites/perf.webkit.org/public/v3/pages/dashboard-toolbar.js (221663 => 221664)
--- trunk/Websites/perf.webkit.org/public/v3/pages/dashboard-toolbar.js 2017-09-06 05:02:43 UTC (rev 221663)
+++ trunk/Websites/perf.webkit.org/public/v3/pages/dashboard-toolbar.js 2017-09-06 05:25:14 UTC (rev 221664)
@@ -5,6 +5,7 @@
var options = [
{label: '1D', days: 1},
{label: '1W', days: 7},
+{label: '2W', days: 14},
{label: '1M', days: 30},
{label: '3M', days: 90},
];
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [221663] trunk/LayoutTests
Title: [221663] trunk/LayoutTests
Revision 221663
Author cdu...@apple.com
Date 2017-09-05 22:02:43 -0700 (Tue, 05 Sep 2017)
Log Message
Unreviewed, rebaseline test after r221639.
* fast/forms/file/entries-api/drag-folder-webkitEntries-expected.txt:
* fast/forms/file/entries-api/drag-folder-webkitEntries.html:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/forms/file/entries-api/drag-folder-webkitEntries-expected.txt
trunk/LayoutTests/fast/forms/file/entries-api/drag-folder-webkitEntries.html
Diff
Modified: trunk/LayoutTests/ChangeLog (221662 => 221663)
--- trunk/LayoutTests/ChangeLog 2017-09-06 03:55:27 UTC (rev 221662)
+++ trunk/LayoutTests/ChangeLog 2017-09-06 05:02:43 UTC (rev 221663)
@@ -1,3 +1,10 @@
+2017-09-05 Chris Dumez
+
+Unreviewed, rebaseline test after r221639.
+
+* fast/forms/file/entries-api/drag-folder-webkitEntries-expected.txt:
+* fast/forms/file/entries-api/drag-folder-webkitEntries.html:
+
2017-09-05 Darin Adler
Fix a few minor problems found while working toward removing unneeded calls to updateStyle
Modified: trunk/LayoutTests/fast/forms/file/entries-api/drag-folder-webkitEntries-expected.txt (221662 => 221663)
--- trunk/LayoutTests/fast/forms/file/entries-api/drag-folder-webkitEntries-expected.txt 2017-09-06 03:55:27 UTC (rev 221662)
+++ trunk/LayoutTests/fast/forms/file/entries-api/drag-folder-webkitEntries-expected.txt 2017-09-06 05:02:43 UTC (rev 221663)
@@ -16,7 +16,7 @@
PASS files[0].size is 5
PASS files[0].type is "text/plain"
PASS files[1].name is "testFiles"
-PASS files[1].size is 204
+PASS files[1].size is 272
PASS files[1].type is ""
PASS successfullyParsed is true
Modified: trunk/LayoutTests/fast/forms/file/entries-api/drag-folder-webkitEntries.html (221662 => 221663)
--- trunk/LayoutTests/fast/forms/file/entries-api/drag-folder-webkitEntries.html 2017-09-06 03:55:27 UTC (rev 221662)
+++ trunk/LayoutTests/fast/forms/file/entries-api/drag-folder-webkitEntries.html 2017-09-06 05:02:43 UTC (rev 221663)
@@ -48,7 +48,7 @@
shouldBeEqualToString("files[0].type", "text/plain");
shouldBeEqualToString("files[1].name", "testFiles");
-shouldBe("files[1].size", "204");
+shouldBe("files[1].size", "272");
shouldBeEqualToString("files[1].type", "");
finishJSTest();
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [221662] trunk/Source/WebInspectorUI
Title: [221662] trunk/Source/WebInspectorUI
Revision 221662
Author nvasil...@apple.com
Date 2017-09-05 20:55:27 -0700 (Tue, 05 Sep 2017)
Log Message
Web Inspector: Styles Redesign: display "Inherited From" section headers
https://bugs.webkit.org/show_bug.cgi?id=176033
Reviewed by Devin Rousso.
Compared to the old styles sidebar, the new "Inherited From" sections are more compact.
One of the goals of the styles redesign is to make it fit more data vertically.
The contrast is inceased. The text is darker while the background stayed the same.
* UserInterface/Views/SpreadsheetRulesStyleDetailsPanel.css:
(.spreadsheet-style-panel .section-inherited):
(.spreadsheet-style-panel .section-inherited .node-link):
(.spreadsheet-style-panel .section-inherited .node-link:hover):
* UserInterface/Views/SpreadsheetRulesStyleDetailsPanel.js:
(WI.SpreadsheetRulesStyleDetailsPanel):
(WI.SpreadsheetRulesStyleDetailsPanel.prototype.refresh):
Don't show two identical "Inherited From" sections.
Modified Paths
trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/Views/SpreadsheetRulesStyleDetailsPanel.css
trunk/Source/WebInspectorUI/UserInterface/Views/SpreadsheetRulesStyleDetailsPanel.js
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (221661 => 221662)
--- trunk/Source/WebInspectorUI/ChangeLog 2017-09-06 03:35:42 UTC (rev 221661)
+++ trunk/Source/WebInspectorUI/ChangeLog 2017-09-06 03:55:27 UTC (rev 221662)
@@ -1,5 +1,27 @@
2017-09-05 Nikita Vasilyev
+Web Inspector: Styles Redesign: display "Inherited From" section headers
+https://bugs.webkit.org/show_bug.cgi?id=176033
+
+
+Reviewed by Devin Rousso.
+
+Compared to the old styles sidebar, the new "Inherited From" sections are more compact.
+One of the goals of the styles redesign is to make it fit more data vertically.
+
+The contrast is inceased. The text is darker while the background stayed the same.
+
+* UserInterface/Views/SpreadsheetRulesStyleDetailsPanel.css:
+(.spreadsheet-style-panel .section-inherited):
+(.spreadsheet-style-panel .section-inherited .node-link):
+(.spreadsheet-style-panel .section-inherited .node-link:hover):
+* UserInterface/Views/SpreadsheetRulesStyleDetailsPanel.js:
+(WI.SpreadsheetRulesStyleDetailsPanel):
+(WI.SpreadsheetRulesStyleDetailsPanel.prototype.refresh):
+Don't show two identical "Inherited From" sections.
+
+2017-09-05 Nikita Vasilyev
+
Web Inspector: Layout flashing for internal View.prototype.layout
https://bugs.webkit.org/show_bug.cgi?id=176389
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/SpreadsheetRulesStyleDetailsPanel.css (221661 => 221662)
--- trunk/Source/WebInspectorUI/UserInterface/Views/SpreadsheetRulesStyleDetailsPanel.css 2017-09-06 03:35:42 UTC (rev 221661)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/SpreadsheetRulesStyleDetailsPanel.css 2017-09-06 03:55:27 UTC (rev 221662)
@@ -102,12 +102,23 @@
color: hsl(0, 0%, 33%);
}
-.style-spreadsheet .inherited {
-color: hsl(0, 0%, 60%);
+.spreadsheet-style-panel .section-inherited {
+margin: 0;
padding: 4px 6px;
+font-size: inherit;
+font-weight: inherit;
+color: hsl(0, 0%, 30%);
border-bottom: 0.5px solid hsla(0, 0%, 0%, 0.2);
}
+.spreadsheet-style-panel .section-inherited .node-link {
+color: inherit;
+}
+
+.spreadsheet-style-panel .section-inherited .node-link:hover {
+color: black;
+}
+
.style-spreadsheet .declarations {
clear: left;
position: relative;
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/SpreadsheetRulesStyleDetailsPanel.js (221661 => 221662)
--- trunk/Source/WebInspectorUI/UserInterface/Views/SpreadsheetRulesStyleDetailsPanel.js 2017-09-06 03:35:42 UTC (rev 221661)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/SpreadsheetRulesStyleDetailsPanel.js 2017-09-06 03:55:27 UTC (rev 221662)
@@ -32,6 +32,8 @@
const label = WI.UIString("Styles \u2014 Rules");
super(delegate, className, identifier, label);
+this.element.classList.add("spreadsheet-style-panel");
+
this._sections = [];
this._inspectorSection = null;
this._isInspectorSectionPendingFocus = false;
@@ -81,12 +83,29 @@
return uniqueStyles;
};
+let createInheritedHeader = (style) => {
+let inheritedHeader = document.createElement("h2");
+inheritedHeader.classList.add("section-inherited");
+inheritedHeader.append(WI.UIString("Inherited From: "), WI.linkifyNodeReference(style.node, {
+maxLength: 100,
+excludeRevealElement: true,
+}));
+
+return inheritedHeader;
+};
+
this.removeAllSubviews();
let orderedStyles = uniqueOrderedStyles(this.nodeStyles.orderedStyles);
+let previousStyle = null;
+
for (le
[webkit-changes] [221661] trunk
Title: [221661] trunk Revision 221661 Author da...@apple.com Date 2017-09-05 20:35:42 -0700 (Tue, 05 Sep 2017) Log Message Fix a few minor problems found while working toward removing unneeded calls to updateStyle https://bugs.webkit.org/show_bug.cgi?id=176279 Reviewed by Antti Koivisto. Source/WebCore: * dom/Document.cpp: (WebCore::Document::updateTitleElement): Fix the algorithm so that an SVG title won't ever become the title when the document element is not an SVG element. We had this wrong before but we were passing the test because SVGTitleElement::insertedInto had a bug that hid the problem. (WebCore::Document::titleElementAdded): Pass a reference instead of a pointer. (WebCore::Document::titleElementRemoved): Pass a reference instead of nullptr since we want to know which element is being removed. * dom/Document.h: Update the argument name and type for updateTitleElement. * html/HTMLTitleElement.cpp: (WebCore::HTMLTitleElement::insertedInto): Call titleElementAdded unconditionally. The checks to see if the title element is connected to the document and not in the shadow tree are now handled by the Document class. (WebCore::HTMLTitleElement::removedFrom): Same for titleElementRemoved. * platform/mock/MockRealtimeVideoSource.cpp: (WebCore::MockRealtimeVideoSource::applySize): Removed incorrect caching of FontCascade objects; these need to be created each time we draw. (WebCore::MockRealtimeVideoSource::drawText): Create all the fonts here. Since this is a mock for testing, there is no real performance concern with doing this. * platform/mock/MockRealtimeVideoSource.h: Removed the FontCascade data members. * rendering/RenderTreeAsText.cpp: (WebCore::updateLayoutIgnoringPendingStylesheetsIncludingSubframes): Added. Used below to update layout more thoroughly. (WebCore::externalRepresentation): Update layout of all descendant frames, not just the top level frame. * svg/SVGTitleElement.cpp: (WebCore::SVGTitleElement::insertedInto): Removed bogus firstChild check, bogus isSVGDocument check, and unneeded isConnected check and call titleElementAdded unconditionally. The checks are now handled by the Document class. (WebCore::SVGTitleElement::removedFrom): Same for titleElementRemoved. * testing/Internals.cpp: (WebCore::Internals::layerTreeAsText const): Added missing updateLayoutIgnorePendingStylesheets, since dumping the layer tree without first doing a layout will yield stale results. (WebCore::Internals::layerIDForElement): Added missing updateLayoutIgnorePendingStylesheets, since using a renderer to check if a layer exists without first doing a layout will yield stale results. (WebCore::Internals::setElementUsesDisplayListDrawing): Ditto. (WebCore::Internals::setElementTracksDisplayListReplay): Ditto. (WebCore::Internals::displayListForElement): Ditto. (WebCore::Internals::replayDisplayListForElement): Ditto. (WebCore::Internals::isSelectPopupVisible): Added missing updateLayoutIgnorePendingStylesheets, since working with the RenderMenuList without first doing a layout will yield stale results. Also removed unneeded strict handling of null renderer, instead just returning false. (WebCore::Internals::isPluginUnavailabilityIndicatorObscured): Removed unnneeded check of renderer class, since the HTMLPlugInElement::isReplacementObscured already handles that correctly. (WebCore::Internals::pageOverlayLayerTreeAsText const): Use updateLayoutIgnorePendingStylesheets instead of the normal updateLayout for consistency with the behavior of the other functions in this file, and because we need a real answer here. (WebCore::Internals::scrollSnapOffsets): Ditto. Also rearranged the code so the renderer check is done after updating the renderer tree. Tools: * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm: (WTR::AccessibilityUIElement::setSelectedChild const): Handle null here. The old code instead would trigger an Objective-C exception unnecessarily. LayoutTests: * svg/hittest/svg-tooltip.svg: Made this test easier to run outside of WebKitTestRunnner, by removing some overzealous checks. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/svg/hittest/svg-tooltip.svg trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/dom/Document.cpp trunk/Source/WebCore/dom/Document.h trunk/Source/WebCore/html/HTMLTitleElement.cpp trunk/Source/WebCore/platform/mock/MockRealtimeVideoSource.cpp trunk/Source/WebCore/platform/mock/MockRealtimeVideoSource.h trunk/Source/WebCore/rendering/RenderTreeAsText.cpp trunk/Source/WebCore/svg/SVGTitleElement.cpp trunk/Source/WebCore/testing/Internals.cpp trunk/Tools/ChangeLog trunk/Tools/WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm Diff Modified: trunk/LayoutTests/ChangeLog (221660 => 221661) --- trunk/LayoutTests/ChangeLog 2017-09-06 02:41:52 UTC (rev 221660) +++ trunk/LayoutTests/ChangeLog 2017-09-06 03:35:42 UTC (rev 221661) @@ -1,3 +1,13 @@ +2017-09-05 Darin Adler + +Fix a few minor problems found while w
[webkit-changes] [221660] trunk
Title: [221660] trunk Revision 221660 Author wenson_hs...@apple.com Date 2017-09-05 19:41:52 -0700 (Tue, 05 Sep 2017) Log Message [iOS WK2] Add plumbing for WKContentView to ask the web process for additional drag items https://bugs.webkit.org/show_bug.cgi?id=176348 Work towards Reviewed by Tim Horton. Source/WebKit: Adds boilerplate plumbing to request additional items to an existing session. This implements some UI-side logic in WKContentView to send an additional drag items request and handle a response from the web process. To start, WebPageProxy::requestAdditionalItemsForDragSession is invoked by -_dragInteraction: itemsForAddingToSession:withTouchAtPoint:completion: in WKContentView, and the response from the web process is handled in -[WKContentView _didHandleAdditionalDragItemsRequest:]. * UIProcess/API/Cocoa/WKWebView.mm: (-[WKWebView _simulateItemsForAddingToSession:atLocation:completion:]): * UIProcess/API/Cocoa/WKWebViewPrivate.h: Add SPI to simulate a request for additional drag items. See Tools/ChangeLog for more detail. * UIProcess/PageClient.h: * UIProcess/WebPageProxy.h: * UIProcess/WebPageProxy.messages.in: Add an IPC message handler for the additional drag items response from the web process. * UIProcess/ios/DragDropInteractionState.h: (WebKit::DragDropInteractionState::BlockPtr for more information. (-[WKContentView dragInteraction:itemsForBeginningSession:]): Refactored to use -_itemsForBeginningOrAddingToSessionWithRegistrationList:stagedDragSource:. (-[WKContentView _simulateItemsForAddingToSession:atLocation:completion:]): * UIProcess/ios/WebPageProxyIOS.mm: (WebKit::WebPageProxy::didHandleAdditionalDragItemsRequest): (WebKit::WebPageProxy::requestAdditionalItemsForDragSession): * WebProcess/WebPage/WebPage.h: * WebProcess/WebPage/WebPage.messages.in: Add an IPC message handler for the additional drag items request from the UI process. * WebProcess/WebPage/ios/WebPageIOS.mm: (WebKit::WebPage::requestAdditionalItemsForDragSession): Tools: Introduces new test infrastructure to simulate tapping to add additional items to the current drag session. We add -[DataInteractionSimulator runFrom:to:additionalItemRequestLocations:], for which the last argument is a dictionary mapping progress (a double between 0 and 1) to NSValues representing the location from which the drag and drop simulation will request an additional drag item. During the simulated drag and drop, when the progress value exceeds a value in the map of remaining additional item request locations, we halt drag simulation progress for that runloop and instead request additional items from the location specified. The only (useful) passing test we can create using the new machinery is one that verifies that preventDefault() on dragstart works as expected, preventing additional items from being added. While this trivially passes now, since the web-process-side of the additional items flow is not yet implemented, it should continue to pass after the web process portion is implemented. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: * TestWebKitAPI/Tests/WebKitCocoa/selected-text-image-link-and-editable.html: Added. Add a new test page that contains some non-editable text, an image, a link, and a rich text editable area. * TestWebKitAPI/Tests/ios/DataInteractionTests.mm: (TestWebKitAPI::TEST): * TestWebKitAPI/ios/DataInteractionSimulator.h: * TestWebKitAPI/ios/DataInteractionSimulator.mm: (-[MockDragDropSession addItems:]): Convenience method to add additional mock drag items to a drag or drop session. (-[DataInteractionSimulator _resetSimulatedState]): (-[DataInteractionSimulator runFrom:to:]): Converted into a convenience wrapper around the latter version, passing in nil for the additional item request locations dictionary. (-[DataInteractionSimulator runFrom:to:additionalItemRequestLocations:]): (-[DataInteractionSimulator _enqueuePendingAdditionalItemRequestLocations]): (-[DataInteractionSimulator _sendQueuedAdditionalItemRequest]): New helper methods to detect when and where additional items should be "added", and subsequently simulate adding drag items at these given locations. (-[DataInteractionSimulator _advanceProgress]): Modified Paths trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebViewPrivate.h trunk/Source/WebKit/UIProcess/PageClient.h trunk/Source/WebKit/UIProcess/WebPageProxy.h trunk/Source/WebKit/UIProcess/WebPageProxy.messages.in trunk/Source/WebKit/UIProcess/ios/DragDropInteractionState.h trunk/Source/WebKit/UIProcess/ios/DragDropInteractionState.mm trunk/Source/WebKit/UIProcess/ios/PageClientImplIOS.h trunk/Source/WebKit/UIProcess/ios/PageClientImplIOS.mm trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.h trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm trunk/Source/WebKit/UIProcess/ios/WebPageProxyIOS.mm trunk/Source/WebKit/WebProcess/WebPage/WebPage.h trunk/Source/
[webkit-changes] [221659] trunk/PerformanceTests
Title: [221659] trunk/PerformanceTests Revision 221659 Author rn...@webkit.org Date 2017-09-05 19:37:41 -0700 (Tue, 05 Sep 2017) Log Message Compute the final score using geometric mean in Speedometer 2.0 https://bugs.webkit.org/show_bug.cgi?id=172968 Reviewed by Saam Barati. Make Speedometer 2.0 use the geometric mean of the subtotal of each test suite instead of the total.. In Speedometer 1.0, we used the total time to compute the final score because we wanted to make the slowest framework and library faster. The fastest suite (FlightJS) still accounted for ~6% and the slowest case (React) accounted for ~25% so we felt the total time, or the arithmetic mean with a constant factor, was a good metric to track. In the latest version of Speedometer 2.0, however, the fastest suite (Preact) runs in ~55ms whereas the slowest suite (Inferno) takes 1.5s on Safari. Since the total time is 6.5s, Preact's suite only accounts for ~0.8% of the total score while Inferno's suite accounts for ~23% of the total score. Since the goal of Speedometer is to approximate different kinds of DOM API use patterns on the Web, we want each framework & library to have some measurement impact on the overall benchmark score. Furthermore, after r221205, we're testing both debug build of Ember.js as well as release build. Since debug build is 4x slower, using the total time or the arithmetic mean thereof will effectively give 4x as much weight to debug build of Ember.js relative to release build of Ember.js. Given only ~5% of websites that deploy Ember.js use debug build, this weighting is clearly not right. This patch, therefore, replaces the arithmetic mean by the geometric mean to compute the final score. It also moves the code to compute the final score to BenchmarkRunner to be shared between main.js and InteractiveRunner.html. * Speedometer/InteractiveRunner.html: (.didRunSuites): Show geometric mean, arithmetic mean, total, as well as the score for completeness since this is a debugging page for developers. * Speedometer/resources/benchmark-runner.js: (BenchmarkRunner.prototype.step): Added mean, geomean, and score as measuredValues' properties. (BenchmarkRunner.prototype._runTestAndRecordResults): Removed the dead code. (BenchmarkRunner.prototype._finalize): Compute and add total, arithmetic mean (just mean in the code), and geometric mean (geomean) to measuredValues. * Speedometer/resources/main.js: (window.benchmarkClient): Replaced testsCount by stepsCount and _timeValues by _measuredValuesList. (window.benchmarkClient.willRunTest): (window.benchmarkClient.didRunTest): (window.benchmarkClient.didRunSuites): Store measuredValues object instead of just the total time. (window.benchmarkClient.didFinishLastIteration): (window.benchmarkClient._computeResults): (window.benchmarkClient._computeResults.valueForUnit): Renamed from totalTimeInDisplayUnit. Now simply retrieves the values computed by BenchmarkRunner's_finalize. (startBenchmark): (computeScore): Deleted. Modified Paths trunk/PerformanceTests/ChangeLog trunk/PerformanceTests/Speedometer/InteractiveRunner.html trunk/PerformanceTests/Speedometer/resources/benchmark-runner.js trunk/PerformanceTests/Speedometer/resources/main.js Diff Modified: trunk/PerformanceTests/ChangeLog (221658 => 221659) --- trunk/PerformanceTests/ChangeLog 2017-09-06 01:23:38 UTC (rev 221658) +++ trunk/PerformanceTests/ChangeLog 2017-09-06 02:37:41 UTC (rev 221659) @@ -1,3 +1,52 @@ +2017-09-05 Ryosuke Niwa + +Compute the final score using geometric mean in Speedometer 2.0 +https://bugs.webkit.org/show_bug.cgi?id=172968 + +Reviewed by Saam Barati. + +Make Speedometer 2.0 use the geometric mean of the subtotal of each test suite instead of the total.. + +In Speedometer 1.0, we used the total time to compute the final score because we wanted to make +the slowest framework and library faster. The fastest suite (FlightJS) still accounted for ~6% and +the slowest case (React) accounted for ~25% so we felt the total time, or the arithmetic mean with +a constant factor, was a good metric to track. + +In the latest version of Speedometer 2.0, however, the fastest suite (Preact) runs in ~55ms whereas +the slowest suite (Inferno) takes 1.5s on Safari. Since the total time is 6.5s, Preact's suite only +accounts for ~0.8% of the total score while Inferno's suite accounts for ~23% of the total score. +Since the goal of Speedometer is to approximate different kinds of DOM API use patterns on the Web, +we want each framework & library to have some measurement impact on the overall benchmark score. + +Furthermore, after r221205, we're testing both debug build of Ember.js as well as release build. +Since debug build is 4x slower, using the total time or the arithmetic mean thereof will effectively +give 4x as much weight to debug build of Ember.js relative to release b
[webkit-changes] [221658] trunk
Title: [221658] trunk Revision 221658 Author commit-qu...@webkit.org Date 2017-09-05 18:23:38 -0700 (Tue, 05 Sep 2017) Log Message Add WKUIDelegatePrivate equivalent of WKPageUIClient's mouseDidMoveOverElement https://bugs.webkit.org/show_bug.cgi?id=176428 Patch by Alex Christensen on 2017-09-05 Reviewed by Tim Horton. Source/WebKit: Covered by a new API test. * UIProcess/API/APIUIClient.h: (API::UIClient::mouseDidMoveOverElement): * UIProcess/API/C/WKPage.cpp: (WKPageSetPageUIClient): * UIProcess/API/Cocoa/WKUIDelegatePrivate.h: * UIProcess/Cocoa/UIDelegate.h: * UIProcess/Cocoa/UIDelegate.mm: (WebKit::UIDelegate::setDelegate): (WebKit::UIDelegate::ContextMenuClient::menuFromProposedMenu): (WebKit::UIDelegate::UIClient::createNewPageCommon): (WebKit::UIDelegate::UIClient::runJavaScriptAlert): (WebKit::UIDelegate::UIClient::runJavaScriptConfirm): (WebKit::UIDelegate::UIClient::runJavaScriptPrompt): (WebKit::UIDelegate::UIClient::runBeforeUnloadConfirmPanel): (WebKit::UIDelegate::UIClient::takeFocus): (WebKit::UIDelegate::UIClient::focus): (WebKit::UIDelegate::UIClient::unfocus): (WebKit::UIDelegate::UIClient::didExceedBackgroundResourceLimitWhileInForeground): (WebKit::UIDelegate::UIClient::didNotHandleWheelEvent): (WebKit::toNSEventModifierFlags): (WebKit::UIDelegate::UIClient::mouseDidMoveOverElement): (WebKit::UIDelegate::UIClient::toolbarsAreVisible): (WebKit::UIDelegate::UIClient::didClickAutoFillButton): (WebKit::UIDelegate::UIClient::handleAutoplayEvent): (WebKit::requestUserMediaAuthorizationForDevices): (WebKit::UIDelegate::UIClient::decidePolicyForUserMediaPermissionRequest): (WebKit::UIDelegate::UIClient::checkUserMediaPermissionForOrigin): (WebKit::UIDelegate::UIClient::printFrame): (WebKit::UIDelegate::UIClient::close): (WebKit::UIDelegate::UIClient::fullscreenMayReturnToInline): (WebKit::UIDelegate::UIClient::didEnterFullscreen): (WebKit::UIDelegate::UIClient::didExitFullscreen): (WebKit::UIDelegate::UIClient::requestPointerLock): (WebKit::UIDelegate::UIClient::didLosePointerLock): (WebKit::UIDelegate::UIClient::hasVideoInPictureInPictureDidChange): * UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::mouseDidMoveOverElement): * UIProcess/WebPageProxy.h: Tools: * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm: (-[MouseMoveOverElementDelegate _webView:mouseDidMoveOverElement:withFlags:userInfo:]): (TEST): * TestWebKitAPI/cocoa/TestWKWebView.h: * TestWebKitAPI/cocoa/TestWKWebView.mm: (-[TestWKWebView mouseMoveToPoint:withFlags:]): Modified Paths trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/UIProcess/API/APIUIClient.h trunk/Source/WebKit/UIProcess/API/C/WKPage.cpp trunk/Source/WebKit/UIProcess/API/Cocoa/WKUIDelegatePrivate.h trunk/Source/WebKit/UIProcess/API/glib/WebKitUIClient.cpp trunk/Source/WebKit/UIProcess/Cocoa/UIDelegate.h trunk/Source/WebKit/UIProcess/Cocoa/UIDelegate.mm trunk/Source/WebKit/UIProcess/WebPageProxy.cpp trunk/Source/WebKit/UIProcess/WebPageProxy.h trunk/Tools/ChangeLog trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm trunk/Tools/TestWebKitAPI/cocoa/TestWKWebView.h trunk/Tools/TestWebKitAPI/cocoa/TestWKWebView.mm Diff Modified: trunk/Source/WebKit/ChangeLog (221657 => 221658) --- trunk/Source/WebKit/ChangeLog 2017-09-06 01:18:15 UTC (rev 221657) +++ trunk/Source/WebKit/ChangeLog 2017-09-06 01:23:38 UTC (rev 221658) @@ -1,3 +1,52 @@ +2017-09-05 Alex Christensen + +Add WKUIDelegatePrivate equivalent of WKPageUIClient's mouseDidMoveOverElement +https://bugs.webkit.org/show_bug.cgi?id=176428 + + +Reviewed by Tim Horton. + +Covered by a new API test. + +* UIProcess/API/APIUIClient.h: +(API::UIClient::mouseDidMoveOverElement): +* UIProcess/API/C/WKPage.cpp: +(WKPageSetPageUIClient): +* UIProcess/API/Cocoa/WKUIDelegatePrivate.h: +* UIProcess/Cocoa/UIDelegate.h: +* UIProcess/Cocoa/UIDelegate.mm: +(WebKit::UIDelegate::setDelegate): +(WebKit::UIDelegate::ContextMenuClient::menuFromProposedMenu): +(WebKit::UIDelegate::UIClient::createNewPageCommon): +(WebKit::UIDelegate::UIClient::runJavaScriptAlert): +(WebKit::UIDelegate::UIClient::runJavaScriptConfirm): +(WebKit::UIDelegate::UIClient::runJavaScriptPrompt): +(WebKit::UIDelegate::UIClient::runBeforeUnloadConfirmPanel): +(WebKit::UIDelegate::UIClient::takeFocus): +(WebKit::UIDelegate::UIClient::focus): +(WebKit::UIDelegate::UIClient::unfocus): +(WebKit::UIDelegate::UIClient::didExceedBackgroundResourceLimitWhileInForeground): +(WebKit::UIDelegate::UIClient::didNotHandleWheelEvent): +(WebKit::toNSEventModifierFlags): +(WebKit::UIDelegate::UIClient::mouseDidMoveOverElement): +(WebKit::UIDelegate::UIClient::toolbarsAreVisible): +(WebKit::UIDelegate::UIClient::didClickAutoFillButton): +(WebKit::UIDelegate::UIClient::handleAutoplayEvent): +(WebKit::requestUserMediaA
[webkit-changes] [221657] trunk
Title: [221657] trunk
Revision 221657
Author sbar...@apple.com
Date 2017-09-05 18:18:15 -0700 (Tue, 05 Sep 2017)
Log Message
isNotCellSpeculation is wrong with respect to SpecEmpty
https://bugs.webkit.org/show_bug.cgi?id=176429
Reviewed by Michael Saboff.
JSTests:
* microbenchmarks/is-not-cell-speculation-for-empty-value.js: Added.
(Foo):
Source/_javascript_Core:
The isNotCellSpeculation(SpeculatedType t) function was not taking into account
SpecEmpty in the set for t. It should return false when SpecEmpty is present, since
the empty value will fail a NotCell check. This bug would cause us to erroneously
generate NotCellUse UseKinds for inputs that are the empty value, causing repeated OSR exits.
* bytecode/SpeculatedType.h:
(JSC::isNotCellSpeculation):
Modified Paths
trunk/JSTests/ChangeLog
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/bytecode/SpeculatedType.h
Added Paths
trunk/JSTests/microbenchmarks/is-not-cell-speculation-for-empty-value.js
Diff
Modified: trunk/JSTests/ChangeLog (221656 => 221657)
--- trunk/JSTests/ChangeLog 2017-09-06 01:01:36 UTC (rev 221656)
+++ trunk/JSTests/ChangeLog 2017-09-06 01:18:15 UTC (rev 221657)
@@ -1,3 +1,13 @@
+2017-09-05 Saam Barati
+
+isNotCellSpeculation is wrong with respect to SpecEmpty
+https://bugs.webkit.org/show_bug.cgi?id=176429
+
+Reviewed by Michael Saboff.
+
+* microbenchmarks/is-not-cell-speculation-for-empty-value.js: Added.
+(Foo):
+
2017-09-05 Joseph Pecoraro
test262: Completion values for control flow do not match the spec
Added: trunk/JSTests/microbenchmarks/is-not-cell-speculation-for-empty-value.js (0 => 221657)
--- trunk/JSTests/microbenchmarks/is-not-cell-speculation-for-empty-value.js (rev 0)
+++ trunk/JSTests/microbenchmarks/is-not-cell-speculation-for-empty-value.js 2017-09-06 01:18:15 UTC (rev 221657)
@@ -0,0 +1,13 @@
+class Foo extends Object {
+constructor() {
+super();
+let arrow = () => {
+this.foo = 20;
+};
+this.arrow = arrow;
+}
+}
+noInline(Foo);
+
+for (let i = 0; i < 40; ++i)
+new Foo();
Modified: trunk/Source/_javascript_Core/ChangeLog (221656 => 221657)
--- trunk/Source/_javascript_Core/ChangeLog 2017-09-06 01:01:36 UTC (rev 221656)
+++ trunk/Source/_javascript_Core/ChangeLog 2017-09-06 01:18:15 UTC (rev 221657)
@@ -1,5 +1,20 @@
2017-09-05 Saam Barati
+isNotCellSpeculation is wrong with respect to SpecEmpty
+https://bugs.webkit.org/show_bug.cgi?id=176429
+
+Reviewed by Michael Saboff.
+
+The isNotCellSpeculation(SpeculatedType t) function was not taking into account
+SpecEmpty in the set for t. It should return false when SpecEmpty is present, since
+the empty value will fail a NotCell check. This bug would cause us to erroneously
+generate NotCellUse UseKinds for inputs that are the empty value, causing repeated OSR exits.
+
+* bytecode/SpeculatedType.h:
+(JSC::isNotCellSpeculation):
+
+2017-09-05 Saam Barati
+
Make the distinction between entrypoints and CFG roots more clear by naming things better
https://bugs.webkit.org/show_bug.cgi?id=176336
Modified: trunk/Source/_javascript_Core/bytecode/SpeculatedType.h (221656 => 221657)
--- trunk/Source/_javascript_Core/bytecode/SpeculatedType.h 2017-09-06 01:01:36 UTC (rev 221656)
+++ trunk/Source/_javascript_Core/bytecode/SpeculatedType.h 2017-09-06 01:18:15 UTC (rev 221657)
@@ -119,7 +119,7 @@
inline bool isNotCellSpeculation(SpeculatedType value)
{
-return !(value & SpecCell) && value;
+return !(value & SpecCellCheck) && value;
}
inline bool isObjectSpeculation(SpeculatedType value)
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [221656] trunk/Tools
Title: [221656] trunk/Tools
Revision 221656
Author commit-qu...@webkit.org
Date 2017-09-05 18:01:36 -0700 (Tue, 05 Sep 2017)
Log Message
Benchmark Runner WebDriver maximize window on browser launch
https://bugs.webkit.org/show_bug.cgi?id=175702
Patch by Matthew Stewart on 2017-09-05
Reviewed by Stephanie Lewis.
* Scripts/webkitpy/benchmark_runner/browser_driver/linux_browser_driver.py:
(LinuxBrowserDriver.launch_webdriver): added driver.maximize_window()
* Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
(OSXBrowserDriver._launch_webdriver): added driver.maximize_window()
* Scripts/webkitpy/benchmark_runner/webdriver_benchmark_runner.py:
(WebDriverBenchmarkRunner._run_one_test): added driver.quit()
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/benchmark_runner/browser_driver/linux_browser_driver.py
trunk/Tools/Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py
trunk/Tools/Scripts/webkitpy/benchmark_runner/webdriver_benchmark_runner.py
Diff
Modified: trunk/Tools/ChangeLog (221655 => 221656)
--- trunk/Tools/ChangeLog 2017-09-06 01:00:48 UTC (rev 221655)
+++ trunk/Tools/ChangeLog 2017-09-06 01:01:36 UTC (rev 221656)
@@ -1,5 +1,19 @@
2017-09-05 Matthew Stewart
+Benchmark Runner WebDriver maximize window on browser launch
+https://bugs.webkit.org/show_bug.cgi?id=175702
+
+Reviewed by Stephanie Lewis.
+
+* Scripts/webkitpy/benchmark_runner/browser_driver/linux_browser_driver.py:
+(LinuxBrowserDriver.launch_webdriver): added driver.maximize_window()
+* Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
+(OSXBrowserDriver._launch_webdriver): added driver.maximize_window()
+* Scripts/webkitpy/benchmark_runner/webdriver_benchmark_runner.py:
+(WebDriverBenchmarkRunner._run_one_test): added driver.quit()
+
+2017-09-05 Matthew Stewart
+
Fix Benchmark Runner selenium autoinstall imports
https://bugs.webkit.org/show_bug.cgi?id=175727
Modified: trunk/Tools/Scripts/webkitpy/benchmark_runner/browser_driver/linux_browser_driver.py (221655 => 221656)
--- trunk/Tools/Scripts/webkitpy/benchmark_runner/browser_driver/linux_browser_driver.py 2017-09-06 01:00:48 UTC (rev 221655)
+++ trunk/Tools/Scripts/webkitpy/benchmark_runner/browser_driver/linux_browser_driver.py 2017-09-06 01:01:36 UTC (rev 221656)
@@ -98,6 +98,10 @@
stderr=subprocess.STDOUT)
def launch_webdriver(self, url, driver):
+try:
+driver.maximize_window()
+except Exception as error:
+_log.error('Failed to maximize {browser} window - Error: {error}'.format(browser=driver.name, error=error))
_log.info('Launching "%s" with url "%s"' % (driver.name, url))
driver.get(url)
Modified: trunk/Tools/Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py (221655 => 221656)
--- trunk/Tools/Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py 2017-09-06 01:00:48 UTC (rev 221655)
+++ trunk/Tools/Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py 2017-09-06 01:01:36 UTC (rev 221656)
@@ -44,6 +44,10 @@
@classmethod
def _launch_webdriver(cls, url, driver):
+try:
+driver.maximize_window()
+except Exception as error:
+_log.error('Failed to maximize {browser} window - Error: {error}'.format(browser=driver.name, error=error))
_log.info('Launching "%s" with url "%s"' % (driver.name, url))
driver.get(url)
Modified: trunk/Tools/Scripts/webkitpy/benchmark_runner/webdriver_benchmark_runner.py (221655 => 221656)
--- trunk/Tools/Scripts/webkitpy/benchmark_runner/webdriver_benchmark_runner.py 2017-09-06 01:00:48 UTC (rev 221655)
+++ trunk/Tools/Scripts/webkitpy/benchmark_runner/webdriver_benchmark_runner.py 2017-09-06 01:01:36 UTC (rev 221656)
@@ -25,6 +25,7 @@
driver = self._browser_driver.launch_driver(url, self._plan['options'], self._build_dir)
_log.info('Waiting on results from web browser')
result = WebDriverWait(driver, self._plan['timeout'], poll_frequency=1.0).until(self._get_result)
+driver.quit()
finally:
self._browser_driver.close_browsers()
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [221655] trunk/Tools
Title: [221655] trunk/Tools
Revision 221655
Author commit-qu...@webkit.org
Date 2017-09-05 18:00:48 -0700 (Tue, 05 Sep 2017)
Log Message
Fix Benchmark Runner selenium autoinstall imports
https://bugs.webkit.org/show_bug.cgi?id=175727
Patch by Matthew Stewart on 2017-09-05
Reviewed by Stephanie Lewis.
This fixes run-benchmark taking a long time to start with WebDriver.
Inside webdriver's __init__.py file, it imports many other modules.
So if we try to directly import autoinstalled.selenium.webdriver, it
will re-run the autoinstall __init__.py for each new imported module
that contains ".selenium"
TODO: fix this inside the autoinstall code, to only do one install per
import.
* Scripts/webkitpy/benchmark_runner/browser_driver/linux_chrome_driver.py:
(LinuxChromeDriver.launch_driver):
* Scripts/webkitpy/benchmark_runner/browser_driver/linux_firefox_driver.py:
(LinuxFirefoxDriver.launch_driver):
* Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
(OSXChromeDriver.launch_driver):
(OSXChromeCanaryDriver.launch_driver):
(create_chrome_options):
* Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py:
(OSXFirefoxDriver.launch_driver):
(OSXFirefoxNightlyDriver.launch_driver):
* Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
(OSXSafariDriver.launch_driver):
* Scripts/webkitpy/benchmark_runner/webdriver_benchmark_runner.py:
(WebDriverBenchmarkRunner._run_one_test):
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/benchmark_runner/browser_driver/linux_chrome_driver.py
trunk/Tools/Scripts/webkitpy/benchmark_runner/browser_driver/linux_firefox_driver.py
trunk/Tools/Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py
trunk/Tools/Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py
trunk/Tools/Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py
trunk/Tools/Scripts/webkitpy/benchmark_runner/webdriver_benchmark_runner.py
Diff
Modified: trunk/Tools/ChangeLog (221654 => 221655)
--- trunk/Tools/ChangeLog 2017-09-06 00:58:33 UTC (rev 221654)
+++ trunk/Tools/ChangeLog 2017-09-06 01:00:48 UTC (rev 221655)
@@ -1,3 +1,35 @@
+2017-09-05 Matthew Stewart
+
+Fix Benchmark Runner selenium autoinstall imports
+https://bugs.webkit.org/show_bug.cgi?id=175727
+
+Reviewed by Stephanie Lewis.
+
+This fixes run-benchmark taking a long time to start with WebDriver.
+
+Inside webdriver's __init__.py file, it imports many other modules.
+So if we try to directly import autoinstalled.selenium.webdriver, it
+will re-run the autoinstall __init__.py for each new imported module
+that contains ".selenium"
+TODO: fix this inside the autoinstall code, to only do one install per
+import.
+
+* Scripts/webkitpy/benchmark_runner/browser_driver/linux_chrome_driver.py:
+(LinuxChromeDriver.launch_driver):
+* Scripts/webkitpy/benchmark_runner/browser_driver/linux_firefox_driver.py:
+(LinuxFirefoxDriver.launch_driver):
+* Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
+(OSXChromeDriver.launch_driver):
+(OSXChromeCanaryDriver.launch_driver):
+(create_chrome_options):
+* Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py:
+(OSXFirefoxDriver.launch_driver):
+(OSXFirefoxNightlyDriver.launch_driver):
+* Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
+(OSXSafariDriver.launch_driver):
+* Scripts/webkitpy/benchmark_runner/webdriver_benchmark_runner.py:
+(WebDriverBenchmarkRunner._run_one_test):
+
2017-09-05 Aakash Jain
EWS should report when a step succeeds
Modified: trunk/Tools/Scripts/webkitpy/benchmark_runner/browser_driver/linux_chrome_driver.py (221654 => 221655)
--- trunk/Tools/Scripts/webkitpy/benchmark_runner/browser_driver/linux_chrome_driver.py 2017-09-06 00:58:33 UTC (rev 221654)
+++ trunk/Tools/Scripts/webkitpy/benchmark_runner/browser_driver/linux_chrome_driver.py 2017-09-06 01:00:48 UTC (rev 221655)
@@ -39,7 +39,9 @@
super(LinuxChromeDriver, self).launch_url(url, options, browser_build_path)
def launch_driver(self, url, options, browser_build_path):
-from webkitpy.thirdparty.autoinstalled.selenium.webdriver.chrome.options import Options
+import webkitpy.thirdparty.autoinstalled.selenium
+from selenium import webdriver
+from selenium.webdriver.chrome.options import Options
options = Options()
options.add_argument("--disable-web-security")
options.add_argument("--user-data-dir")
@@ -49,7 +51,6 @@
binary_path = os.path.join(browser_build_path, 'chromium-browser')
options.binary_location = binary_path
driver_executable = self.webdriver_binary_path
-from webkitpy.thirdparty.autoinstalled.selenium import webdri
[webkit-changes] [221654] tags/Safari-605.1.4.1/Source/WebKit
Title: [221654] tags/Safari-605.1.4.1/Source/WebKit
Revision 221654
Author matthew_han...@apple.com
Date 2017-09-05 17:58:33 -0700 (Tue, 05 Sep 2017)
Log Message
Cherry-pick r221457. rdar://problem/34186977
Modified Paths
tags/Safari-605.1.4.1/Source/WebKit/ChangeLog
tags/Safari-605.1.4.1/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm
Diff
Modified: tags/Safari-605.1.4.1/Source/WebKit/ChangeLog (221653 => 221654)
--- tags/Safari-605.1.4.1/Source/WebKit/ChangeLog 2017-09-06 00:58:30 UTC (rev 221653)
+++ tags/Safari-605.1.4.1/Source/WebKit/ChangeLog 2017-09-06 00:58:33 UTC (rev 221654)
@@ -1,3 +1,19 @@
+2017-09-05 Matthew Hanson
+
+Cherry-pick r221457. rdar://problem/34186977
+
+2017-08-31 Megan Gardner
+
+Fix error in protocol revving
+https://bugs.webkit.org/show_bug.cgi?id=176191
+
+Protocol definition was mastered out of later iOS submissions, causing them to not build.
+
+Reviewed by Tim Horton.
+
+* UIProcess/ios/WKContentViewInteraction.mm:
+(-[WKContentView changeSelectionWithGestureAt:withGesture:withState:]):
+
2017-08-30 Jason Marcell
Revert r221068. rdar://problem/33925559
Modified: tags/Safari-605.1.4.1/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm (221653 => 221654)
--- tags/Safari-605.1.4.1/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm 2017-09-06 00:58:30 UTC (rev 221653)
+++ tags/Safari-605.1.4.1/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm 2017-09-06 00:58:33 UTC (rev 221654)
@@ -2544,12 +2544,10 @@
return _textSelectionAssistant != nil;
}
-#if __IPHONE_OS_VERSION_MAX_ALLOWED < 12
- (void)changeSelectionWithGestureAt:(CGPoint)point withGesture:(UIWKGestureType)gestureType withState:(UIGestureRecognizerState)state
{
[self changeSelectionWithGestureAt:point withGesture:gestureType withState:state withFlags:UIWKNone];
}
-#endif
- (void)changeSelectionWithGestureAt:(CGPoint)point withGesture:(UIWKGestureType)gestureType withState:(UIGestureRecognizerState)state withFlags:(UIWKSelectionFlags)flags
{
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [221653] tags/Safari-605.1.4.1/Source
Title: [221653] tags/Safari-605.1.4.1/Source Revision 221653 Author matthew_han...@apple.com Date 2017-09-05 17:58:30 -0700 (Tue, 05 Sep 2017) Log Message Versioning. Modified Paths tags/Safari-605.1.4.1/Source/_javascript_Core/Configurations/Version.xcconfig tags/Safari-605.1.4.1/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig tags/Safari-605.1.4.1/Source/WebCore/Configurations/Version.xcconfig tags/Safari-605.1.4.1/Source/WebCore/PAL/Configurations/Version.xcconfig tags/Safari-605.1.4.1/Source/WebInspectorUI/Configurations/Version.xcconfig tags/Safari-605.1.4.1/Source/WebKit/Configurations/Version.xcconfig tags/Safari-605.1.4.1/Source/WebKitLegacy/mac/Configurations/Version.xcconfig Diff Modified: tags/Safari-605.1.4.1/Source/_javascript_Core/Configurations/Version.xcconfig (221652 => 221653) --- tags/Safari-605.1.4.1/Source/_javascript_Core/Configurations/Version.xcconfig 2017-09-06 00:53:57 UTC (rev 221652) +++ tags/Safari-605.1.4.1/Source/_javascript_Core/Configurations/Version.xcconfig 2017-09-06 00:58:30 UTC (rev 221653) @@ -24,9 +24,9 @@ MAJOR_VERSION = 605; MINOR_VERSION = 1; TINY_VERSION = 4; -MICRO_VERSION = 0; +MICRO_VERSION = 1; NANO_VERSION = 0; -FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); +FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION)); Modified: tags/Safari-605.1.4.1/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (221652 => 221653) --- tags/Safari-605.1.4.1/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig 2017-09-06 00:53:57 UTC (rev 221652) +++ tags/Safari-605.1.4.1/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig 2017-09-06 00:58:30 UTC (rev 221653) @@ -24,9 +24,9 @@ MAJOR_VERSION = 605; MINOR_VERSION = 1; TINY_VERSION = 4; -MICRO_VERSION = 0; +MICRO_VERSION = 1; NANO_VERSION = 0; -FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); +FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION)); Modified: tags/Safari-605.1.4.1/Source/WebCore/Configurations/Version.xcconfig (221652 => 221653) --- tags/Safari-605.1.4.1/Source/WebCore/Configurations/Version.xcconfig 2017-09-06 00:53:57 UTC (rev 221652) +++ tags/Safari-605.1.4.1/Source/WebCore/Configurations/Version.xcconfig 2017-09-06 00:58:30 UTC (rev 221653) @@ -24,9 +24,9 @@ MAJOR_VERSION = 605; MINOR_VERSION = 1; TINY_VERSION = 4; -MICRO_VERSION = 0; +MICRO_VERSION = 1; NANO_VERSION = 0; -FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); +FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION)); Modified: tags/Safari-605.1.4.1/Source/WebCore/PAL/Configurations/Version.xcconfig (221652 => 221653) --- tags/Safari-605.1.4.1/Source/WebCore/PAL/Configurations/Version.xcconfig 2017-09-06 00:53:57 UTC (rev 221652) +++ tags/Safari-605.1.4.1/Source/WebCore/PAL/Configurations/Version.xcconfig 2017-09-06 00:58:30 UTC (rev 221653) @@ -24,9 +24,9 @@ MAJOR_VERSION = 605; MINOR_VERSION = 1; TINY_VERSION = 4; -MICRO_VERSION = 0; +MICRO_VERSION = 1; NANO_VERSION = 0; -FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); +FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION)); Modified: tags/Safari-605.1.4.1/Source/WebInspectorUI/Configurations/Version.xcconfig (221652 => 221653) --- tags/Safari-605.1.4.1/Source/WebInspectorUI/Configurations/Version.xcconfig 2017-09-06 00:53:57 UTC (rev 221652) +++ tags/Safari-605.1.4.1/Source/WebInspectorUI/Configurations/Version.xcconfig 2017-09-06 00:58:30 UTC (rev 221653) @@ -1,9 +1,9 @@ MAJOR_VERSION = 605; MINOR_VERSION = 1; TINY_VERSION = 4; -MICRO_VERSION = 0; +MICRO_VERSION = 1; NANO_VERSION = 0; -FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); +FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION); // The system version prefix is based on the current system version. SYSTEM_VERSION_PREFIX[sdk=iphone*] = 8; Modified: tags/Safari-605.1.4.1/Source/WebKit/Configurations/Version.xcconfig (221652 => 221653) --- tags/Safari-605.1.4.1/Source/WebKit/Configurations/Version.xcconfig 2017-09-06 00:53:57 UTC (rev 221652) +++ tags/Safari-605.1.4.1/Source/WebKit/Configurations/Version.xcconfig 2017-09-06 00:58:30 UTC (rev 221653) @@ -24,9 +24,9 @@ MAJOR_VERSION =
[webkit-changes] [221652] tags/Safari-605.1.4.1/
Title: [221652] tags/Safari-605.1.4.1/ Revision 221652 Author matthew_han...@apple.com Date 2017-09-05 17:53:57 -0700 (Tue, 05 Sep 2017) Log Message New Tag. Added Paths tags/Safari-605.1.4.1/ Diff ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [221651] tags/Safari-604.1.38.1.7/
Title: [221651] tags/Safari-604.1.38.1.7/ Revision 221651 Author matthew_han...@apple.com Date 2017-09-05 17:10:34 -0700 (Tue, 05 Sep 2017) Log Message Tag Safari-604.1.38.1.7. Added Paths tags/Safari-604.1.38.1.7/ Diff ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [221650] tags/Safari-604.2.8/
Title: [221650] tags/Safari-604.2.8/ Revision 221650 Author matthew_han...@apple.com Date 2017-09-05 17:09:48 -0700 (Tue, 05 Sep 2017) Log Message Tag Safari-604.2.8. Added Paths tags/Safari-604.2.8/ Diff ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [221649] trunk/Tools
Title: [221649] trunk/Tools Revision 221649 Author aakash_j...@apple.com Date 2017-09-05 16:54:17 -0700 (Tue, 05 Sep 2017) Log Message EWS should report when a step succeeds https://bugs.webkit.org/show_bug.cgi?id=176332 Reviewed by Sam Weinig. Most of the EWSes report only if a step fails, but do not report when a step succeed. For e.g.: If a build succeeds, EWS does not report it. Information about a step passing is sometimes very valuable, especially when waiting for a patch to complete processing. Sometimes, patch authors know that their changes are not covered by any tests. Having EWS display that build was successful and it is currently running tests is valuable. * Scripts/webkitpy/tool/commands/earlywarningsystem.py: (AbstractEarlyWarningSystem.command_passed): Update the EWS status server when a command pass. This is similar to what is done in Commit Queue and Style Queue. * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py: (EarlyWarningSystemTest._default_expected_logs): Updated unit-tests appropriately. Modified Paths trunk/Tools/ChangeLog trunk/Tools/Scripts/webkitpy/tool/commands/earlywarningsystem.py trunk/Tools/Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py Diff Modified: trunk/Tools/ChangeLog (221648 => 221649) --- trunk/Tools/ChangeLog 2017-09-05 23:38:11 UTC (rev 221648) +++ trunk/Tools/ChangeLog 2017-09-05 23:54:17 UTC (rev 221649) @@ -1,3 +1,22 @@ +2017-09-05 Aakash Jain + +EWS should report when a step succeeds +https://bugs.webkit.org/show_bug.cgi?id=176332 + + +Reviewed by Sam Weinig. + +Most of the EWSes report only if a step fails, but do not report when a step succeed. For e.g.: If a build succeeds, +EWS does not report it. Information about a step passing is sometimes very valuable, especially when waiting for a +patch to complete processing. Sometimes, patch authors know that their changes are not covered by any tests. Having EWS +display that build was successful and it is currently running tests is valuable. + +* Scripts/webkitpy/tool/commands/earlywarningsystem.py: +(AbstractEarlyWarningSystem.command_passed): Update the EWS status server when a command pass. This is +similar to what is done in Commit Queue and Style Queue. +* Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py: +(EarlyWarningSystemTest._default_expected_logs): Updated unit-tests appropriately. + 2017-09-05 Myles C. Maxfield WSL should support the bool type Modified: trunk/Tools/Scripts/webkitpy/tool/commands/earlywarningsystem.py (221648 => 221649) --- trunk/Tools/Scripts/webkitpy/tool/commands/earlywarningsystem.py 2017-09-05 23:38:11 UTC (rev 221648) +++ trunk/Tools/Scripts/webkitpy/tool/commands/earlywarningsystem.py 2017-09-05 23:54:17 UTC (rev 221649) @@ -127,7 +127,7 @@ self.run_webkit_patch(command + [self._deprecated_port.flag()] + (['--architecture=%s' % self._port.architecture()] if self._port.architecture() and self._port.did_override_architecture else [])) def command_passed(self, message, patch): -pass +self._update_status(message, patch=patch) def command_failed(self, message, script_error, patch): failure_log = self._log_from_script_error_for_upload(script_error) Modified: trunk/Tools/Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py (221648 => 221649) --- trunk/Tools/Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py 2017-09-05 23:38:11 UTC (rev 221648) +++ trunk/Tools/Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py 2017-09-05 23:54:17 UTC (rev 221649) @@ -119,13 +119,13 @@ } if ews.should_build: -build_line = "Running: webkit-patch --status-host=example.com build --no-clean --no-update --build-style=%(build_style)s --group=%(group)s --port=%(port)s%(architecture)s\n" % string_replacements +build_line = "Running: webkit-patch --status-host=example.com build --no-clean --no-update --build-style=%(build_style)s --group=%(group)s --port=%(port)s%(architecture)s\nMOCK: update_status: %(name)s Built patch\n" % string_replacements else: build_line = "" string_replacements['build_line'] = build_line if ews.run_tests: -run_tests_line = "Running: webkit-patch --status-host=example.com build-and-test --no-clean --no-update --test --non-interactive --build-style=%(build_style)s --group=%(group)s --port=%(port)s%(architecture)s\n" % string_replacements +run_tests_line = "Running: webkit-patch --status-host=example.com build-and-test --no-clean --no-update --test --non-interactive --build-style=%(build_style)s --group=%(group)s --port=%(port)s%(architecture)s\nMOCK: update_status: %(name)s Passed tests\n" % string_replacements else: run_tests_line = "" string_replacements['run_tests_line'] = run_te
[webkit-changes] [221648] trunk/Source/WebInspectorUI
Title: [221648] trunk/Source/WebInspectorUI
Revision 221648
Author nvasil...@apple.com
Date 2017-09-05 16:38:11 -0700 (Tue, 05 Sep 2017)
Log Message
Web Inspector: Layout flashing for internal View.prototype.layout
https://bugs.webkit.org/show_bug.cgi?id=176389
Reviewed by Matt Baker.
Add a checkbox to Settings (Debug panel) to draw an orange outline around an element every time View.prototype.layout is called.
This is similar to paint flashing, except this is only for View.prototype.layout.
* UserInterface/Base/Setting.js:
* UserInterface/Views/SettingsTabContentView.js:
(WI.SettingsTabContentView.prototype._createDebugSettingsView):
* UserInterface/Views/View.js:
(WI.View.prototype._layoutSubtree):
(WI.View.prototype._drawLayoutFlashingOutline):
Modified Paths
trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/Base/Setting.js
trunk/Source/WebInspectorUI/UserInterface/Views/SettingsTabContentView.js
trunk/Source/WebInspectorUI/UserInterface/Views/View.js
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (221647 => 221648)
--- trunk/Source/WebInspectorUI/ChangeLog 2017-09-05 23:36:59 UTC (rev 221647)
+++ trunk/Source/WebInspectorUI/ChangeLog 2017-09-05 23:38:11 UTC (rev 221648)
@@ -1,3 +1,20 @@
+2017-09-05 Nikita Vasilyev
+
+Web Inspector: Layout flashing for internal View.prototype.layout
+https://bugs.webkit.org/show_bug.cgi?id=176389
+
+Reviewed by Matt Baker.
+
+Add a checkbox to Settings (Debug panel) to draw an orange outline around an element every time View.prototype.layout is called.
+This is similar to paint flashing, except this is only for View.prototype.layout.
+
+* UserInterface/Base/Setting.js:
+* UserInterface/Views/SettingsTabContentView.js:
+(WI.SettingsTabContentView.prototype._createDebugSettingsView):
+* UserInterface/Views/View.js:
+(WI.View.prototype._layoutSubtree):
+(WI.View.prototype._drawLayoutFlashingOutline):
+
2017-09-04 Nikita Vasilyev
Web Inspector: Styles Redesign: hook up real data to spreadsheet style editor
Modified: trunk/Source/WebInspectorUI/UserInterface/Base/Setting.js (221647 => 221648)
--- trunk/Source/WebInspectorUI/UserInterface/Base/Setting.js 2017-09-05 23:36:59 UTC (rev 221647)
+++ trunk/Source/WebInspectorUI/UserInterface/Base/Setting.js 2017-09-05 23:38:11 UTC (rev 221648)
@@ -106,6 +106,7 @@
autoLogProtocolMessages: new WI.Setting("auto-collect-protocol-messages", false),
autoLogTimeStats: new WI.Setting("auto-collect-time-stats", false),
enableUncaughtExceptionReporter: new WI.Setting("enable-uncaught-exception-reporter", true),
+enableLayoutFlashing: new WI.Setting("enable-layout-flashing", false),
enableLineWrapping: new WI.Setting("enable-line-wrapping", false),
indentUnit: new WI.Setting("indent-unit", 4),
tabSize: new WI.Setting("tab-size", 4),
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/SettingsTabContentView.js (221647 => 221648)
--- trunk/Source/WebInspectorUI/UserInterface/Views/SettingsTabContentView.js 2017-09-05 23:36:59 UTC (rev 221647)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/SettingsTabContentView.js 2017-09-05 23:38:11 UTC (rev 221648)
@@ -292,6 +292,10 @@
this._debugSettingsView.addSeparator();
+this._debugSettingsView.addSetting(WI.unlocalizedString("Layout Flashing:"), WI.settings.enableLayoutFlashing, WI.unlocalizedString("Draw borders when a view performs a layout"));
+
+this._debugSettingsView.addSeparator();
+
this._debugSettingsView.addSetting(WI.unlocalizedString("Uncaught Exception Reporter:"), WI.settings.enableUncaughtExceptionReporter, WI.unlocalizedString("Enabled"));
this._debugSettingsView.addSeparator();
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/View.js (221647 => 221648)
--- trunk/Source/WebInspectorUI/UserInterface/Views/View.js 2017-09-05 23:36:59 UTC (rev 221647)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/View.js 2017-09-05 23:38:11 UTC (rev 221648)
@@ -260,6 +260,9 @@
this.layout();
+if (WI.settings.enableLayoutFlashing.value)
+this._drawLayoutFlashingOutline();
+
for (let view of this._subviews) {
view._setLayoutReason(this._layoutReason);
view._layoutSubtree();
@@ -276,6 +279,24 @@
this._layoutReason = layoutReason || WI.View.LayoutReason.Dirty;
}
+_drawLayoutFlashingOutline()
+{
+if (this._layoutFlashingTimeout)
+clearTimeout(this._layoutFlashingTimeout);
+else
+this._layoutFlashingPreviousOutline = this._element.style.outline;
+
+this._element.style.outline = "1px solid hsla(39, 100%, 51%, 0.8)";
+
+this._layoutFlashingTimeout = setTimeout(() => {
+if (this._element)
+this._element.style.outline = this._layoutFlashingPreviousOutline;
+
+
[webkit-changes] [221647] trunk/Source/WebKit
Title: [221647] trunk/Source/WebKit Revision 221647 Author bfulg...@apple.com Date 2017-09-05 16:36:59 -0700 (Tue, 05 Sep 2017) Log Message Relax keychain access to permit users to permanently allow client certificates https://bugs.webkit.org/show_bug.cgi?id=175857 Reviewed by Alex Christensen. Further relax the write permissions on the user's Keychain directory to support local certificates. * NetworkProcess/mac/com.apple.WebKit.NetworkProcess.sb.in: * WebProcess/com.apple.WebProcess.sb.in: Modified Paths trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/NetworkProcess/mac/com.apple.WebKit.NetworkProcess.sb.in trunk/Source/WebKit/WebProcess/com.apple.WebProcess.sb.in Diff Modified: trunk/Source/WebKit/ChangeLog (221646 => 221647) --- trunk/Source/WebKit/ChangeLog 2017-09-05 23:33:49 UTC (rev 221646) +++ trunk/Source/WebKit/ChangeLog 2017-09-05 23:36:59 UTC (rev 221647) @@ -1,3 +1,16 @@ +2017-09-05 Brent Fulgham + +Relax keychain access to permit users to permanently allow client certificates +https://bugs.webkit.org/show_bug.cgi?id=175857 + + +Reviewed by Alex Christensen. + +Further relax the write permissions on the user's Keychain directory to support local certificates. + +* NetworkProcess/mac/com.apple.WebKit.NetworkProcess.sb.in: +* WebProcess/com.apple.WebProcess.sb.in: + 2017-09-05 Youenn Fablet Cache Storage Engine should not mix different origin caches Modified: trunk/Source/WebKit/NetworkProcess/mac/com.apple.WebKit.NetworkProcess.sb.in (221646 => 221647) --- trunk/Source/WebKit/NetworkProcess/mac/com.apple.WebKit.NetworkProcess.sb.in 2017-09-05 23:33:49 UTC (rev 221646) +++ trunk/Source/WebKit/NetworkProcess/mac/com.apple.WebKit.NetworkProcess.sb.in 2017-09-05 23:36:59 UTC (rev 221647) @@ -165,7 +165,7 @@ ;; FIXME: This should be removed when is fixed. ;; Restrict AppSandboxed processes from creating /Library/Keychains, but allow access to the contents of /Library/Keychains: -(allow file-read-data file-read-metadata file-write-create file-write-data +(allow file-read-data file-read-metadata file-write* (subpath "/Library/Keychains") (home-subpath "/Library/Keychains")) Modified: trunk/Source/WebKit/WebProcess/com.apple.WebProcess.sb.in (221646 => 221647) --- trunk/Source/WebKit/WebProcess/com.apple.WebProcess.sb.in 2017-09-05 23:33:49 UTC (rev 221646) +++ trunk/Source/WebKit/WebProcess/com.apple.WebProcess.sb.in 2017-09-05 23:36:59 UTC (rev 221647) @@ -430,7 +430,7 @@ ;; FIXME: This should be removed when is fixed. ;; Restrict AppSandboxed processes from creating /Library/Keychains, but allow access to the contents of /Library/Keychains: -(allow file-read-data file-read-metadata file-write-create file-write-data +(allow file-read-data file-read-metadata file-write* (subpath "/Library/Keychains")) ;; Do permit creating per-user keychains ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [221646] trunk/Source/WebCore
Title: [221646] trunk/Source/WebCore
Revision 221646
Author ryanhad...@apple.com
Date 2017-09-05 16:33:49 -0700 (Tue, 05 Sep 2017)
Log Message
Unreviewed, rolling out r221495.
This change introduced assertion failures on El Capitan Debug
WK2.
Reverted changeset:
"Move ServiceWorkerJob from FetchLoader to ThreadableLoader."
https://bugs.webkit.org/show_bug.cgi?id=176231
http://trac.webkit.org/changeset/221495
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj
trunk/Source/WebCore/loader/ThreadableLoader.h
trunk/Source/WebCore/loader/ThreadableLoaderClient.h
trunk/Source/WebCore/workers/service/ServiceWorkerJob.cpp
trunk/Source/WebCore/workers/service/ServiceWorkerJob.h
trunk/Source/WebCore/workers/service/server/SWClientConnection.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (221645 => 221646)
--- trunk/Source/WebCore/ChangeLog 2017-09-05 23:28:54 UTC (rev 221645)
+++ trunk/Source/WebCore/ChangeLog 2017-09-05 23:33:49 UTC (rev 221646)
@@ -1,3 +1,16 @@
+2017-09-05 Ryan Haddad
+
+Unreviewed, rolling out r221495.
+
+This change introduced assertion failures on El Capitan Debug
+WK2.
+
+Reverted changeset:
+
+"Move ServiceWorkerJob from FetchLoader to ThreadableLoader."
+https://bugs.webkit.org/show_bug.cgi?id=176231
+http://trac.webkit.org/changeset/221495
+
2017-09-05 Chris Dumez
Add support for input.webkitEntries
Modified: trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj (221645 => 221646)
--- trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj 2017-09-05 23:28:54 UTC (rev 221645)
+++ trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj 2017-09-05 23:33:49 UTC (rev 221646)
@@ -2306,8 +2306,8 @@
517A53461F50C17F00DCDC0A /* SWServerWorker.h in Headers */ = {isa = PBXBuildFile; fileRef = 517A53421F50C16100DCDC0A /* SWServerWorker.h */; settings = {ATTRIBUTES = (Private, ); }; };
517A534E1F54A8BA00DCDC0A /* ServiceWorkerRegistrationData.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 517A534B1F549D4A00DCDC0A /* ServiceWorkerRegistrationData.cpp */; };
517A534F1F54A8BA00DCDC0A /* ServiceWorkerRegistrationData.h in Headers */ = {isa = PBXBuildFile; fileRef = 517A534C1F549D4A00DCDC0A /* ServiceWorkerRegistrationData.h */; settings = {ATTRIBUTES = (Private, ); }; };
- 517A53581F5889E800DCDC0A /* FetchLoaderClient.h in Headers */ = {isa = PBXBuildFile; fileRef = 4147E2B61C89912600A7E715 /* FetchLoaderClient.h */; };
- 517A535A1F5889EF00DCDC0A /* FetchLoader.h in Headers */ = {isa = PBXBuildFile; fileRef = 4147E2B51C89912600A7E715 /* FetchLoader.h */; };
+ 517A53581F5889E800DCDC0A /* FetchLoaderClient.h in Headers */ = {isa = PBXBuildFile; fileRef = 4147E2B61C89912600A7E715 /* FetchLoaderClient.h */; settings = {ATTRIBUTES = (Private, ); }; };
+ 517A535A1F5889EF00DCDC0A /* FetchLoader.h in Headers */ = {isa = PBXBuildFile; fileRef = 4147E2B51C89912600A7E715 /* FetchLoader.h */; settings = {ATTRIBUTES = (Private, ); }; };
517A535B1F588A4C00DCDC0A /* FetchBodyConsumer.h in Headers */ = {isa = PBXBuildFile; fileRef = 41CF8BE51D46222000707DC9 /* FetchBodyConsumer.h */; settings = {ATTRIBUTES = (Private, ); }; };
517A535D1F5899FE00DCDC0A /* ServiceWorkerFetchResult.h in Headers */ = {isa = PBXBuildFile; fileRef = 517A535C1F5899F200DCDC0A /* ServiceWorkerFetchResult.h */; settings = {ATTRIBUTES = (Private, ); }; };
517A63C31B74318700E7DCDC /* KeyedDecoderCF.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 517A63BF1B74317E00E7DCDC /* KeyedDecoderCF.cpp */; };
@@ -11518,8 +11518,8 @@
7CBA5BA61F0B4BDE0034D745 /* JSDOMConvertWebGL.cpp */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.cpp.cpp; path = JSDOMConvertWebGL.cpp; sourceTree = ""; };
7CBBBCC41F560567005EFAAC /* DOMMatrix2DInit.idl */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = text; path = DOMMatrix2DInit.idl; sourceTree = ""; };
7CBBBCC61F560568005EFAAC /* DOMMatrix2DInit.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = DOMMatrix2DInit.h; sourceTree = ""; };
- 7CBBBCC81F5617C0005EFAAC /* JSDOMMatrix2DInit.cpp */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.cpp.cpp; path = JSDOMMatrix2DInit.cpp; sourceTree = ""; };
- 7CBBBCC91F5617C0005EFAAC /* JSDOMMatrix2DInit.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; path = JSDOMMatrix2DInit.h; sourceTree = ""; };
+ 7CBBBCC81F5617C0005EFAAC /* JSDOMMatrix2DInit.cpp */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.cpp.cpp; name = JSDOMMatrix2DInit.cpp; path = JSDOMMatrix2DInit.cpp; sourceTree = ""; };
+ 7CBBBCC91F5617C0005EFAAC /* JSDOMMatrix2DInit.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; name = JSDOMMatrix2DInit.h; path = JSDOMMatrix2DInit.h; sourceTree = ""; };
7CC2DDF81EC9415A0027B774 /* NotificationPermission.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.
[webkit-changes] [221645] trunk
Title: [221645] trunk Revision 221645 Author cdu...@apple.com Date 2017-09-05 16:28:54 -0700 (Tue, 05 Sep 2017) Log Message Add support for input.webkitEntries https://bugs.webkit.org/show_bug.cgi?id=176257 Reviewed by Andreas Kling. Source/WebCore: Add support for input.webkitEntries as per: - https://wicg.github.io/entries-api/#html-forms Our behavior matches Chrome and Firefox, rather than the specification. This means that webkitEntries is only populated if the webkitdirectory flag is unset. Tests: fast/forms/file/entries-api/drag-folder-webkitEntries.html fast/forms/file/entries-api/webkitdirectory-drag-folder-webkitEntries.html * CMakeLists.txt: * DerivedSources.make: * Modules/entriesapi/HTMLInputElementEntriesAPI.cpp: Added. (WebCore::HTMLInputElementEntriesAPI::webkitEntries): * Modules/entriesapi/HTMLInputElementEntriesAPI.h: Added. * Modules/entriesapi/HTMLInputElementEntriesAPI.idl: Added. * WebCore.xcodeproj/project.pbxproj: * bindings/scripts/generate-bindings.pl: * bindings/scripts/test/JS/JSTestInterface.cpp: (WebCore::jsTestInterfaceReflectAttributeGetter): (WebCore::jsTestInterfaceReflectAttribute): (WebCore::setJSTestInterfaceReflectAttributeSetter): (WebCore::setJSTestInterfaceReflectAttribute): * bindings/scripts/test/TestSupplemental.idl: * html/HTMLInputElement.idl: LayoutTests: Add layout test coverage. * fast/forms/file/entries-api/drag-folder-webkitEntries-expected.txt: Added. * fast/forms/file/entries-api/drag-folder-webkitEntries.html: Added. * fast/forms/file/entries-api/webkitdirectory-drag-folder-webkitEntries-expected.txt: Added. * fast/forms/file/entries-api/webkitdirectory-drag-folder-webkitEntries.html: Added. * http/wpt/entries-api/interfaces-expected.txt: * platform/wk2/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/http/wpt/entries-api/interfaces-expected.txt trunk/LayoutTests/platform/wk2/TestExpectations trunk/Source/WebCore/CMakeLists.txt trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/DerivedSources.make trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj trunk/Source/WebCore/bindings/scripts/generate-bindings.pl trunk/Source/WebCore/bindings/scripts/test/JS/JSTestInterface.cpp trunk/Source/WebCore/bindings/scripts/test/TestSupplemental.idl trunk/Source/WebCore/html/HTMLInputElement.idl Added Paths trunk/LayoutTests/fast/forms/file/entries-api/drag-folder-webkitEntries-expected.txt trunk/LayoutTests/fast/forms/file/entries-api/drag-folder-webkitEntries.html trunk/LayoutTests/fast/forms/file/entries-api/webkitdirectory-drag-folder-webkitEntries-expected.txt trunk/LayoutTests/fast/forms/file/entries-api/webkitdirectory-drag-folder-webkitEntries.html trunk/Source/WebCore/Modules/entriesapi/HTMLInputElementEntriesAPI.cpp trunk/Source/WebCore/Modules/entriesapi/HTMLInputElementEntriesAPI.h trunk/Source/WebCore/Modules/entriesapi/HTMLInputElementEntriesAPI.idl Diff Modified: trunk/LayoutTests/ChangeLog (221644 => 221645) --- trunk/LayoutTests/ChangeLog 2017-09-05 23:25:32 UTC (rev 221644) +++ trunk/LayoutTests/ChangeLog 2017-09-05 23:28:54 UTC (rev 221645) @@ -1,3 +1,20 @@ +2017-09-05 Chris Dumez + +Add support for input.webkitEntries +https://bugs.webkit.org/show_bug.cgi?id=176257 + + +Reviewed by Andreas Kling. + +Add layout test coverage. + +* fast/forms/file/entries-api/drag-folder-webkitEntries-expected.txt: Added. +* fast/forms/file/entries-api/drag-folder-webkitEntries.html: Added. +* fast/forms/file/entries-api/webkitdirectory-drag-folder-webkitEntries-expected.txt: Added. +* fast/forms/file/entries-api/webkitdirectory-drag-folder-webkitEntries.html: Added. +* http/wpt/entries-api/interfaces-expected.txt: +* platform/wk2/TestExpectations: + 2017-09-05 Per Arne Vollan Marked imported/w3c/web-platform-tests/html/browsers/history/the-history-interface/joint_session_history/001.html as slow. Added: trunk/LayoutTests/fast/forms/file/entries-api/drag-folder-webkitEntries-expected.txt (0 => 221645) --- trunk/LayoutTests/fast/forms/file/entries-api/drag-folder-webkitEntries-expected.txt (rev 0) +++ trunk/LayoutTests/fast/forms/file/entries-api/drag-folder-webkitEntries-expected.txt 2017-09-05 23:28:54 UTC (rev 221645) @@ -0,0 +1,24 @@ +Tests dragging a folder onto a file input without webkitdirectory set and querying input.webkitEntries. + +On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE". + + +PASS inputElement.webkitdirectory is false +PASS entries.length is 2 +PASS entries[0].name is "test.txt" +PASS entries[0].fullPath is "/test.txt" +PASS entries[0].isFile is true +PASS entries[1].name is "testFiles" +PASS entries[1].fullPath is "/testFiles" +PASS entries[1].isDirectory is true +PASS files.length is 2 +PASS files[0].name is "test.txt" +PASS files[0].size is 5 +PASS files[0].type is "text/plain" +PASS files[1].name is "testFiles
[webkit-changes] [221644] tags/Safari-605.1.4/Source
Title: [221644] tags/Safari-605.1.4/Source Revision 221644 Author matthew_han...@apple.com Date 2017-09-05 16:25:32 -0700 (Tue, 05 Sep 2017) Log Message Revert r221640. rdar://problem/34186977 Modified Paths tags/Safari-605.1.4/Source/_javascript_Core/Configurations/Version.xcconfig tags/Safari-605.1.4/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig tags/Safari-605.1.4/Source/WebCore/Configurations/Version.xcconfig tags/Safari-605.1.4/Source/WebCore/PAL/Configurations/Version.xcconfig tags/Safari-605.1.4/Source/WebInspectorUI/Configurations/Version.xcconfig tags/Safari-605.1.4/Source/WebKit/Configurations/Version.xcconfig tags/Safari-605.1.4/Source/WebKitLegacy/mac/Configurations/Version.xcconfig Diff Modified: tags/Safari-605.1.4/Source/_javascript_Core/Configurations/Version.xcconfig (221643 => 221644) --- tags/Safari-605.1.4/Source/_javascript_Core/Configurations/Version.xcconfig 2017-09-05 23:25:28 UTC (rev 221643) +++ tags/Safari-605.1.4/Source/_javascript_Core/Configurations/Version.xcconfig 2017-09-05 23:25:32 UTC (rev 221644) @@ -24,9 +24,9 @@ MAJOR_VERSION = 605; MINOR_VERSION = 1; TINY_VERSION = 4; -MICRO_VERSION = 1; +MICRO_VERSION = 0; NANO_VERSION = 0; -FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION); +FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION)); Modified: tags/Safari-605.1.4/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (221643 => 221644) --- tags/Safari-605.1.4/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig 2017-09-05 23:25:28 UTC (rev 221643) +++ tags/Safari-605.1.4/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig 2017-09-05 23:25:32 UTC (rev 221644) @@ -24,9 +24,9 @@ MAJOR_VERSION = 605; MINOR_VERSION = 1; TINY_VERSION = 4; -MICRO_VERSION = 1; +MICRO_VERSION = 0; NANO_VERSION = 0; -FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION); +FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION)); Modified: tags/Safari-605.1.4/Source/WebCore/Configurations/Version.xcconfig (221643 => 221644) --- tags/Safari-605.1.4/Source/WebCore/Configurations/Version.xcconfig 2017-09-05 23:25:28 UTC (rev 221643) +++ tags/Safari-605.1.4/Source/WebCore/Configurations/Version.xcconfig 2017-09-05 23:25:32 UTC (rev 221644) @@ -24,9 +24,9 @@ MAJOR_VERSION = 605; MINOR_VERSION = 1; TINY_VERSION = 4; -MICRO_VERSION = 1; +MICRO_VERSION = 0; NANO_VERSION = 0; -FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION); +FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION)); Modified: tags/Safari-605.1.4/Source/WebCore/PAL/Configurations/Version.xcconfig (221643 => 221644) --- tags/Safari-605.1.4/Source/WebCore/PAL/Configurations/Version.xcconfig 2017-09-05 23:25:28 UTC (rev 221643) +++ tags/Safari-605.1.4/Source/WebCore/PAL/Configurations/Version.xcconfig 2017-09-05 23:25:32 UTC (rev 221644) @@ -24,9 +24,9 @@ MAJOR_VERSION = 605; MINOR_VERSION = 1; TINY_VERSION = 4; -MICRO_VERSION = 1; +MICRO_VERSION = 0; NANO_VERSION = 0; -FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION); +FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION)); Modified: tags/Safari-605.1.4/Source/WebInspectorUI/Configurations/Version.xcconfig (221643 => 221644) --- tags/Safari-605.1.4/Source/WebInspectorUI/Configurations/Version.xcconfig 2017-09-05 23:25:28 UTC (rev 221643) +++ tags/Safari-605.1.4/Source/WebInspectorUI/Configurations/Version.xcconfig 2017-09-05 23:25:32 UTC (rev 221644) @@ -1,9 +1,9 @@ MAJOR_VERSION = 605; MINOR_VERSION = 1; TINY_VERSION = 4; -MICRO_VERSION = 1; +MICRO_VERSION = 0; NANO_VERSION = 0; -FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION); +FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); // The system version prefix is based on the current system version. SYSTEM_VERSION_PREFIX[sdk=iphone*] = 8; Modified: tags/Safari-605.1.4/Source/WebKit/Configurations/Version.xcconfig (221643 => 221644) --- tags/Safari-605.1.4/Source/WebKit/Configurations/Version.xcconfig 2017-09-05 23:25:28 UTC (rev 221643) +++ tags/Safari-605.1.4/Source/WebKit/Configurations/Version.xcconfig 2017-09-05 23:25:32 UTC (rev 221644) @@ -24,9 +24,9 @@ MAJOR_VERSION = 605; MINOR_VERSION = 1;
[webkit-changes] [221643] tags/Safari-605.1.4/Source/WebKit
Title: [221643] tags/Safari-605.1.4/Source/WebKit
Revision 221643
Author matthew_han...@apple.com
Date 2017-09-05 16:25:28 -0700 (Tue, 05 Sep 2017)
Log Message
Revert r221641. rdar://problem/34186977
Modified Paths
tags/Safari-605.1.4/Source/WebKit/ChangeLog
tags/Safari-605.1.4/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm
Diff
Modified: tags/Safari-605.1.4/Source/WebKit/ChangeLog (221642 => 221643)
--- tags/Safari-605.1.4/Source/WebKit/ChangeLog 2017-09-05 23:18:44 UTC (rev 221642)
+++ tags/Safari-605.1.4/Source/WebKit/ChangeLog 2017-09-05 23:25:28 UTC (rev 221643)
@@ -1,5 +1,9 @@
2017-09-05 Matthew Hanson
+Revert r221641. rdar://problem/34186977
+
+2017-09-05 Matthew Hanson
+
Cherry-pick r221457. rdar://problem/34186977
2017-08-31 Megan Gardner
Modified: tags/Safari-605.1.4/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm (221642 => 221643)
--- tags/Safari-605.1.4/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm 2017-09-05 23:18:44 UTC (rev 221642)
+++ tags/Safari-605.1.4/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm 2017-09-05 23:25:28 UTC (rev 221643)
@@ -2544,10 +2544,12 @@
return _textSelectionAssistant != nil;
}
+#if __IPHONE_OS_VERSION_MAX_ALLOWED < 12
- (void)changeSelectionWithGestureAt:(CGPoint)point withGesture:(UIWKGestureType)gestureType withState:(UIGestureRecognizerState)state
{
[self changeSelectionWithGestureAt:point withGesture:gestureType withState:state withFlags:UIWKNone];
}
+#endif
- (void)changeSelectionWithGestureAt:(CGPoint)point withGesture:(UIWKGestureType)gestureType withState:(UIGestureRecognizerState)state withFlags:(UIWKSelectionFlags)flags
{
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [221642] trunk/LayoutTests
Title: [221642] trunk/LayoutTests Revision 221642 Author pvol...@apple.com Date 2017-09-05 16:18:44 -0700 (Tue, 05 Sep 2017) Log Message Marked imported/w3c/web-platform-tests/html/browsers/history/the-history-interface/joint_session_history/001.html as slow. Unreviewed test gardening. * platform/win/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/win/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (221641 => 221642) --- trunk/LayoutTests/ChangeLog 2017-09-05 23:04:00 UTC (rev 221641) +++ trunk/LayoutTests/ChangeLog 2017-09-05 23:18:44 UTC (rev 221642) @@ -1,3 +1,11 @@ +2017-09-05 Per Arne Vollan + +Marked imported/w3c/web-platform-tests/html/browsers/history/the-history-interface/joint_session_history/001.html as slow. + +Unreviewed test gardening. + +* platform/win/TestExpectations: + 2017-09-05 Chris Dumez FileSystemEntry API should ignore hidden files Modified: trunk/LayoutTests/platform/win/TestExpectations (221641 => 221642) --- trunk/LayoutTests/platform/win/TestExpectations 2017-09-05 23:04:00 UTC (rev 221641) +++ trunk/LayoutTests/platform/win/TestExpectations 2017-09-05 23:18:44 UTC (rev 221642) @@ -4051,6 +4051,7 @@ imported/w3c/web-platform-tests/encoding/api-basics.html [ Slow ] imported/w3c/web-platform-tests/fetch/api/basic/accept-header.any.html [ Slow ] imported/w3c/web-platform-tests/fetch/api/cors/cors-basic.any.html [ Slow ] +imported/w3c/web-platform-tests/html/browsers/history/the-history-interface/joint_session_history/001.html [ Slow ] # No service worker implementation for WK1 http/tests/workers/service [ Skip ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [221641] tags/Safari-605.1.4/Source/WebKit
Title: [221641] tags/Safari-605.1.4/Source/WebKit
Revision 221641
Author matthew_han...@apple.com
Date 2017-09-05 16:04:00 -0700 (Tue, 05 Sep 2017)
Log Message
Cherry-pick r221457. rdar://problem/34186977
Modified Paths
tags/Safari-605.1.4/Source/WebKit/ChangeLog
tags/Safari-605.1.4/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm
Diff
Modified: tags/Safari-605.1.4/Source/WebKit/ChangeLog (221640 => 221641)
--- tags/Safari-605.1.4/Source/WebKit/ChangeLog 2017-09-05 23:01:04 UTC (rev 221640)
+++ tags/Safari-605.1.4/Source/WebKit/ChangeLog 2017-09-05 23:04:00 UTC (rev 221641)
@@ -1,3 +1,19 @@
+2017-09-05 Matthew Hanson
+
+Cherry-pick r221457. rdar://problem/34186977
+
+2017-08-31 Megan Gardner
+
+Fix error in protocol revving
+https://bugs.webkit.org/show_bug.cgi?id=176191
+
+Protocol definition was mastered out of later iOS submissions, causing them to not build.
+
+Reviewed by Tim Horton.
+
+* UIProcess/ios/WKContentViewInteraction.mm:
+(-[WKContentView changeSelectionWithGestureAt:withGesture:withState:]):
+
2017-08-30 Jason Marcell
Revert r221068. rdar://problem/33925559
Modified: tags/Safari-605.1.4/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm (221640 => 221641)
--- tags/Safari-605.1.4/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm 2017-09-05 23:01:04 UTC (rev 221640)
+++ tags/Safari-605.1.4/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm 2017-09-05 23:04:00 UTC (rev 221641)
@@ -2544,12 +2544,10 @@
return _textSelectionAssistant != nil;
}
-#if __IPHONE_OS_VERSION_MAX_ALLOWED < 12
- (void)changeSelectionWithGestureAt:(CGPoint)point withGesture:(UIWKGestureType)gestureType withState:(UIGestureRecognizerState)state
{
[self changeSelectionWithGestureAt:point withGesture:gestureType withState:state withFlags:UIWKNone];
}
-#endif
- (void)changeSelectionWithGestureAt:(CGPoint)point withGesture:(UIWKGestureType)gestureType withState:(UIGestureRecognizerState)state withFlags:(UIWKSelectionFlags)flags
{
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [221640] tags/Safari-605.1.4/Source
Title: [221640] tags/Safari-605.1.4/Source Revision 221640 Author matthew_han...@apple.com Date 2017-09-05 16:01:04 -0700 (Tue, 05 Sep 2017) Log Message Versioning. Modified Paths tags/Safari-605.1.4/Source/_javascript_Core/Configurations/Version.xcconfig tags/Safari-605.1.4/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig tags/Safari-605.1.4/Source/WebCore/Configurations/Version.xcconfig tags/Safari-605.1.4/Source/WebCore/PAL/Configurations/Version.xcconfig tags/Safari-605.1.4/Source/WebInspectorUI/Configurations/Version.xcconfig tags/Safari-605.1.4/Source/WebKit/Configurations/Version.xcconfig tags/Safari-605.1.4/Source/WebKitLegacy/mac/Configurations/Version.xcconfig Diff Modified: tags/Safari-605.1.4/Source/_javascript_Core/Configurations/Version.xcconfig (221639 => 221640) --- tags/Safari-605.1.4/Source/_javascript_Core/Configurations/Version.xcconfig 2017-09-05 22:53:59 UTC (rev 221639) +++ tags/Safari-605.1.4/Source/_javascript_Core/Configurations/Version.xcconfig 2017-09-05 23:01:04 UTC (rev 221640) @@ -24,9 +24,9 @@ MAJOR_VERSION = 605; MINOR_VERSION = 1; TINY_VERSION = 4; -MICRO_VERSION = 0; +MICRO_VERSION = 1; NANO_VERSION = 0; -FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); +FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION)); Modified: tags/Safari-605.1.4/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (221639 => 221640) --- tags/Safari-605.1.4/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig 2017-09-05 22:53:59 UTC (rev 221639) +++ tags/Safari-605.1.4/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig 2017-09-05 23:01:04 UTC (rev 221640) @@ -24,9 +24,9 @@ MAJOR_VERSION = 605; MINOR_VERSION = 1; TINY_VERSION = 4; -MICRO_VERSION = 0; +MICRO_VERSION = 1; NANO_VERSION = 0; -FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); +FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION)); Modified: tags/Safari-605.1.4/Source/WebCore/Configurations/Version.xcconfig (221639 => 221640) --- tags/Safari-605.1.4/Source/WebCore/Configurations/Version.xcconfig 2017-09-05 22:53:59 UTC (rev 221639) +++ tags/Safari-605.1.4/Source/WebCore/Configurations/Version.xcconfig 2017-09-05 23:01:04 UTC (rev 221640) @@ -24,9 +24,9 @@ MAJOR_VERSION = 605; MINOR_VERSION = 1; TINY_VERSION = 4; -MICRO_VERSION = 0; +MICRO_VERSION = 1; NANO_VERSION = 0; -FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); +FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION)); Modified: tags/Safari-605.1.4/Source/WebCore/PAL/Configurations/Version.xcconfig (221639 => 221640) --- tags/Safari-605.1.4/Source/WebCore/PAL/Configurations/Version.xcconfig 2017-09-05 22:53:59 UTC (rev 221639) +++ tags/Safari-605.1.4/Source/WebCore/PAL/Configurations/Version.xcconfig 2017-09-05 23:01:04 UTC (rev 221640) @@ -24,9 +24,9 @@ MAJOR_VERSION = 605; MINOR_VERSION = 1; TINY_VERSION = 4; -MICRO_VERSION = 0; +MICRO_VERSION = 1; NANO_VERSION = 0; -FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); +FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION)); Modified: tags/Safari-605.1.4/Source/WebInspectorUI/Configurations/Version.xcconfig (221639 => 221640) --- tags/Safari-605.1.4/Source/WebInspectorUI/Configurations/Version.xcconfig 2017-09-05 22:53:59 UTC (rev 221639) +++ tags/Safari-605.1.4/Source/WebInspectorUI/Configurations/Version.xcconfig 2017-09-05 23:01:04 UTC (rev 221640) @@ -1,9 +1,9 @@ MAJOR_VERSION = 605; MINOR_VERSION = 1; TINY_VERSION = 4; -MICRO_VERSION = 0; +MICRO_VERSION = 1; NANO_VERSION = 0; -FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); +FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION); // The system version prefix is based on the current system version. SYSTEM_VERSION_PREFIX[sdk=iphone*] = 8; Modified: tags/Safari-605.1.4/Source/WebKit/Configurations/Version.xcconfig (221639 => 221640) --- tags/Safari-605.1.4/Source/WebKit/Configurations/Version.xcconfig 2017-09-05 22:53:59 UTC (rev 221639) +++ tags/Safari-605.1.4/Source/WebKit/Configurations/Version.xcconfig 2017-09-05 23:01:04 UTC (rev 221640) @@ -24,9 +24,9 @@ MAJOR_VERSION = 605; MINOR_VERSION = 1; TINY_VERSION = 4; -MICRO_V
[webkit-changes] [221639] trunk
Title: [221639] trunk
Revision 221639
Author cdu...@apple.com
Date 2017-09-05 15:53:59 -0700 (Tue, 05 Sep 2017)
Log Message
FileSystemEntry API should ignore hidden files
https://bugs.webkit.org/show_bug.cgi?id=176292
Reviewed by Andreas Kling.
Source/WebCore:
FileSystemEntry API should ignore hidden files as the user likely does not mean
to expose those when drag'n dropping a folder.
Test: editing/pasteboard/enties-api/datatransfer-items-drop-hidden-file.html
* Modules/entriesapi/DOMFileSystem.cpp:
(WebCore::listDirectoryWithMetadata):
(WebCore::validatePathIsExpectedType):
(WebCore::fileType):
(WebCore::DOMFileSystem::getEntry):
LayoutTests:
Add layout test coverage.
* editing/pasteboard/enties-api/datatransfer-items-drop-getAsEntry-expected.txt:
* editing/pasteboard/enties-api/datatransfer-items-drop-getAsEntry.html:
* editing/pasteboard/enties-api/datatransfer-items-drop-hidden-file-expected.txt: Added.
* editing/pasteboard/enties-api/datatransfer-items-drop-hidden-file.html: Added.
* fast/forms/file/entries-api/resources/testFiles/.hidden.txt: Added.
* fast/forms/file/entries-api/resources/testFiles/.hidden/hidden.txt: Added.
* platform/win/TestExpectations:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/editing/pasteboard/enties-api/datatransfer-items-drop-getAsEntry-expected.txt
trunk/LayoutTests/editing/pasteboard/enties-api/datatransfer-items-drop-getAsEntry.html
trunk/LayoutTests/platform/win/TestExpectations
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/entriesapi/DOMFileSystem.cpp
Added Paths
trunk/LayoutTests/editing/pasteboard/enties-api/datatransfer-items-drop-hidden-file-expected.txt
trunk/LayoutTests/editing/pasteboard/enties-api/datatransfer-items-drop-hidden-file.html
trunk/LayoutTests/fast/forms/file/entries-api/resources/testFiles/.hidden/
trunk/LayoutTests/fast/forms/file/entries-api/resources/testFiles/.hidden/hidden.txt
trunk/LayoutTests/fast/forms/file/entries-api/resources/testFiles/.hidden.txt
Diff
Modified: trunk/LayoutTests/ChangeLog (221638 => 221639)
--- trunk/LayoutTests/ChangeLog 2017-09-05 22:36:10 UTC (rev 221638)
+++ trunk/LayoutTests/ChangeLog 2017-09-05 22:53:59 UTC (rev 221639)
@@ -1,3 +1,21 @@
+2017-09-05 Chris Dumez
+
+FileSystemEntry API should ignore hidden files
+https://bugs.webkit.org/show_bug.cgi?id=176292
+
+
+Reviewed by Andreas Kling.
+
+Add layout test coverage.
+
+* editing/pasteboard/enties-api/datatransfer-items-drop-getAsEntry-expected.txt:
+* editing/pasteboard/enties-api/datatransfer-items-drop-getAsEntry.html:
+* editing/pasteboard/enties-api/datatransfer-items-drop-hidden-file-expected.txt: Added.
+* editing/pasteboard/enties-api/datatransfer-items-drop-hidden-file.html: Added.
+* fast/forms/file/entries-api/resources/testFiles/.hidden.txt: Added.
+* fast/forms/file/entries-api/resources/testFiles/.hidden/hidden.txt: Added.
+* platform/win/TestExpectations:
+
2017-09-05 Matt Lewis
Marked svg/as-image/svg-image-with-data-uri-background.html as flaky.
Modified: trunk/LayoutTests/editing/pasteboard/enties-api/datatransfer-items-drop-getAsEntry-expected.txt (221638 => 221639)
--- trunk/LayoutTests/editing/pasteboard/enties-api/datatransfer-items-drop-getAsEntry-expected.txt 2017-09-05 22:36:10 UTC (rev 221638)
+++ trunk/LayoutTests/editing/pasteboard/enties-api/datatransfer-items-drop-getAsEntry-expected.txt 2017-09-05 22:53:59 UTC (rev 221639)
@@ -16,7 +16,7 @@
PASS secondDataTransferItem.kind is "file"
PASS secondDataTransferItem.type is ""
PASS secondFile.name is "testFiles"
-PASS secondFile.size is 204
+PASS secondFile.size is 272
PASS secondFile.type is ""
PASS secondEntry.isDirectory is true
PASS secondEntry.isFile is false
Modified: trunk/LayoutTests/editing/pasteboard/enties-api/datatransfer-items-drop-getAsEntry.html (221638 => 221639)
--- trunk/LayoutTests/editing/pasteboard/enties-api/datatransfer-items-drop-getAsEntry.html 2017-09-05 22:36:10 UTC (rev 221638)
+++ trunk/LayoutTests/editing/pasteboard/enties-api/datatransfer-items-drop-getAsEntry.html 2017-09-05 22:53:59 UTC (rev 221639)
@@ -37,7 +37,7 @@
shouldBeEqualToString("secondDataTransferItem.type", "");
secondFile = secondDataTransferItem.getAsFile();
shouldBeEqualToString("secondFile.name", "testFiles");
-shouldBe("secondFile.size", "204"); // Chrome returns folder size, Firefox returns 0.
+shouldBe("secondFile.size", "272"); // Chrome returns folder size, Firefox returns 0.
shouldBeEqualToString("secondFile.type", "");
secondEntry = secondDataTransferItem.webkitGetAsEntry();
Added: trunk/LayoutTests/editing/pasteboard/enties-api/datatransfer-items-drop-hidden-file-expected.txt (0 => 221639)
--- trunk/LayoutTests/editing/pasteboard/enties-api/datatransfer-items-drop-hidden-file-expected.txt (rev 0)
+++ trunk/LayoutTests/editing/pasteboard/en
[webkit-changes] [221638] trunk/LayoutTests
Title: [221638] trunk/LayoutTests Revision 221638 Author jlew...@apple.com Date 2017-09-05 15:36:10 -0700 (Tue, 05 Sep 2017) Log Message Marked svg/as-image/svg-image-with-data-uri-background.html as flaky. https://bugs.webkit.org/show_bug.cgi?id=172877 Unreviewed test gardening. * platform/mac-wk1/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/mac-wk1/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (221637 => 221638) --- trunk/LayoutTests/ChangeLog 2017-09-05 21:30:05 UTC (rev 221637) +++ trunk/LayoutTests/ChangeLog 2017-09-05 22:36:10 UTC (rev 221638) @@ -1,3 +1,12 @@ +2017-09-05 Matt Lewis + +Marked svg/as-image/svg-image-with-data-uri-background.html as flaky. +https://bugs.webkit.org/show_bug.cgi?id=172877 + +Unreviewed test gardening. + +* platform/mac-wk1/TestExpectations: + 2017-09-05 Per Arne Vollan DataTransferItem tests are timing out on Windows. Modified: trunk/LayoutTests/platform/mac-wk1/TestExpectations (221637 => 221638) --- trunk/LayoutTests/platform/mac-wk1/TestExpectations 2017-09-05 21:30:05 UTC (rev 221637) +++ trunk/LayoutTests/platform/mac-wk1/TestExpectations 2017-09-05 22:36:10 UTC (rev 221638) @@ -400,3 +400,5 @@ webkit.org/b/172334 webrtc/datachannel/bufferedAmountLowThreshold.html [ Pass Failure ] +webkit.org/b/172877 svg/as-image/svg-image-with-data-uri-background.html [ Pass ImageOnlyFailure ] + ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [221637] trunk/Source/JavaScriptCore
Title: [221637] trunk/Source/_javascript_Core Revision 221637 Author sbar...@apple.com Date 2017-09-05 14:30:05 -0700 (Tue, 05 Sep 2017) Log Message Make the distinction between entrypoints and CFG roots more clear by naming things better https://bugs.webkit.org/show_bug.cgi?id=176336 Reviewed by Mark Lam and Keith Miller and Michael Saboff. This patch does renaming to make the distinction between Graph::m_entrypoints and Graph::m_numberOfEntrypoints more clear. The source of confusion is that Graph::m_entrypoints.size() is not equivalent to Graph::m_numberOfEntrypoints. Graph::m_entrypoints is really just the CFG roots. In CPS, this vector has size >= 1. In SSA, the size is always 1. This patch renames Graph::m_entrypoints to Graph::m_roots. To be consistent, this patch also renames Graph's m_entrypointToArguments field to m_rootToArguments. Graph::m_numberOfEntrypoints retains its name. This field is only used in SSA when compiling with EntrySwitch. It represents the logical number of entrypoints the compilation will end up with. Each EntrySwitch has m_numberOfEntrypoints cases. * dfg/DFGByteCodeParser.cpp: (JSC::DFG::ByteCodeParser::parseBlock): (JSC::DFG::ByteCodeParser::parseCodeBlock): * dfg/DFGCFG.h: (JSC::DFG::CFG::roots): (JSC::DFG::CPSCFG::CPSCFG): * dfg/DFGCPSRethreadingPhase.cpp: (JSC::DFG::CPSRethreadingPhase::specialCaseArguments): * dfg/DFGDCEPhase.cpp: (JSC::DFG::DCEPhase::run): * dfg/DFGGraph.cpp: (JSC::DFG::Graph::dump): (JSC::DFG::Graph::determineReachability): (JSC::DFG::Graph::blocksInPreOrder): (JSC::DFG::Graph::blocksInPostOrder): (JSC::DFG::Graph::methodOfGettingAValueProfileFor): * dfg/DFGGraph.h: (JSC::DFG::Graph::isRoot): (JSC::DFG::Graph::isEntrypoint): Deleted. * dfg/DFGInPlaceAbstractState.cpp: (JSC::DFG::InPlaceAbstractState::initialize): * dfg/DFGLoopPreHeaderCreationPhase.cpp: (JSC::DFG::createPreHeader): * dfg/DFGMaximalFlushInsertionPhase.cpp: (JSC::DFG::MaximalFlushInsertionPhase::run): (JSC::DFG::MaximalFlushInsertionPhase::treatRegularBlock): * dfg/DFGOSREntrypointCreationPhase.cpp: (JSC::DFG::OSREntrypointCreationPhase::run): * dfg/DFGPredictionInjectionPhase.cpp: (JSC::DFG::PredictionInjectionPhase::run): * dfg/DFGSSAConversionPhase.cpp: (JSC::DFG::SSAConversionPhase::run): * dfg/DFGSpeculativeJIT.cpp: (JSC::DFG::SpeculativeJIT::checkArgumentTypes): (JSC::DFG::SpeculativeJIT::linkOSREntries): * dfg/DFGTypeCheckHoistingPhase.cpp: (JSC::DFG::TypeCheckHoistingPhase::run): * dfg/DFGValidate.cpp: Modified Paths trunk/Source/_javascript_Core/ChangeLog trunk/Source/_javascript_Core/dfg/DFGByteCodeParser.cpp trunk/Source/_javascript_Core/dfg/DFGCFG.h trunk/Source/_javascript_Core/dfg/DFGCPSRethreadingPhase.cpp trunk/Source/_javascript_Core/dfg/DFGDCEPhase.cpp trunk/Source/_javascript_Core/dfg/DFGGraph.cpp trunk/Source/_javascript_Core/dfg/DFGGraph.h trunk/Source/_javascript_Core/dfg/DFGInPlaceAbstractState.cpp trunk/Source/_javascript_Core/dfg/DFGLoopPreHeaderCreationPhase.cpp trunk/Source/_javascript_Core/dfg/DFGMaximalFlushInsertionPhase.cpp trunk/Source/_javascript_Core/dfg/DFGOSREntrypointCreationPhase.cpp trunk/Source/_javascript_Core/dfg/DFGPredictionInjectionPhase.cpp trunk/Source/_javascript_Core/dfg/DFGSSAConversionPhase.cpp trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.cpp trunk/Source/_javascript_Core/dfg/DFGTypeCheckHoistingPhase.cpp trunk/Source/_javascript_Core/dfg/DFGValidate.cpp Diff Modified: trunk/Source/_javascript_Core/ChangeLog (221636 => 221637) --- trunk/Source/_javascript_Core/ChangeLog 2017-09-05 21:18:24 UTC (rev 221636) +++ trunk/Source/_javascript_Core/ChangeLog 2017-09-05 21:30:05 UTC (rev 221637) @@ -1,3 +1,62 @@ +2017-09-05 Saam Barati + +Make the distinction between entrypoints and CFG roots more clear by naming things better +https://bugs.webkit.org/show_bug.cgi?id=176336 + +Reviewed by Mark Lam and Keith Miller and Michael Saboff. + +This patch does renaming to make the distinction between Graph::m_entrypoints +and Graph::m_numberOfEntrypoints more clear. The source of confusion is that +Graph::m_entrypoints.size() is not equivalent to Graph::m_numberOfEntrypoints. +Graph::m_entrypoints is really just the CFG roots. In CPS, this vector has +size >= 1. In SSA, the size is always 1. This patch renames Graph::m_entrypoints +to Graph::m_roots. To be consistent, this patch also renames Graph's m_entrypointToArguments +field to m_rootToArguments. + +Graph::m_numberOfEntrypoints retains its name. This field is only used in SSA +when compiling with EntrySwitch. It represents the logical number of entrypoints +the compilation will end up with. Each EntrySwitch has m_numberOfEntrypoints +cases. + +* dfg/DFGByteCodeParser.cpp: +(JSC::DFG::ByteCodeParser::parseBlock): +(JSC::DFG::ByteCodeParser::parseCodeBlock): +* dfg/DFGCFG.h: +(JSC::DFG::CFG::roots): +(JS
[webkit-changes] [221636] trunk/PerformanceTests
Title: [221636] trunk/PerformanceTests Revision 221636 Author jfbast...@apple.com Date 2017-09-05 14:18:24 -0700 (Tue, 05 Sep 2017) Log Message StitchMarker: build fix Modified Paths trunk/PerformanceTests/ChangeLog trunk/PerformanceTests/StitchMarker/ck.sh Diff Modified: trunk/PerformanceTests/ChangeLog (221635 => 221636) --- trunk/PerformanceTests/ChangeLog 2017-09-05 21:17:42 UTC (rev 221635) +++ trunk/PerformanceTests/ChangeLog 2017-09-05 21:18:24 UTC (rev 221636) @@ -1,3 +1,11 @@ +2017-09-05 JF Bastien + +StitchMarker build fix + +Unreviewed + +* StitchMarker/ck.sh: was missing `cd ck` + 2017-09-05 Shiyu Zhang Speedometer 2.0: Add dummy node to notify app is ready for Backbone suite Modified: trunk/PerformanceTests/StitchMarker/ck.sh (221635 => 221636) --- trunk/PerformanceTests/StitchMarker/ck.sh 2017-09-05 21:17:42 UTC (rev 221635) +++ trunk/PerformanceTests/StitchMarker/ck.sh 2017-09-05 21:18:24 UTC (rev 221636) @@ -4,4 +4,5 @@ set -u set -x +cd ck make regressions ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [221635] trunk/LayoutTests
Title: [221635] trunk/LayoutTests Revision 221635 Author pvol...@apple.com Date 2017-09-05 14:17:42 -0700 (Tue, 05 Sep 2017) Log Message DataTransferItem tests are timing out on Windows. https://bugs.webkit.org/show_bug.cgi?id=176423. Unreviewed test gardening. * platform/win/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/win/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (221634 => 221635) --- trunk/LayoutTests/ChangeLog 2017-09-05 21:11:59 UTC (rev 221634) +++ trunk/LayoutTests/ChangeLog 2017-09-05 21:17:42 UTC (rev 221635) @@ -1,3 +1,12 @@ +2017-09-05 Per Arne Vollan + +DataTransferItem tests are timing out on Windows. +https://bugs.webkit.org/show_bug.cgi?id=176423. + +Unreviewed test gardening. + +* platform/win/TestExpectations: + 2017-09-05 Youenn Fablet Cache Storage Engine should not mix different origin caches Modified: trunk/LayoutTests/platform/win/TestExpectations (221634 => 221635) --- trunk/LayoutTests/platform/win/TestExpectations 2017-09-05 21:11:59 UTC (rev 221634) +++ trunk/LayoutTests/platform/win/TestExpectations 2017-09-05 21:17:42 UTC (rev 221635) @@ -4085,3 +4085,17 @@ # This test is flaky on Windows. webkit.org/b/157916 http/tests/misc/slow-loading-animated-image.html [ Pass ImageOnlyFailure ] + +# DatatransferItem tests are timing out. +webkit.org/b/176423 editing/pasteboard/datatransfer-items-copy-plaintext.html [ Skip ] +webkit.org/b/176423 editing/pasteboard/datatransfer-items-paste-plaintext.html [ Skip ] +webkit.org/b/176423 editing/pasteboard/enties-api/datatransfer-items-drop-directoryReader-error.html [ Skip ] +webkit.org/b/176423 editing/pasteboard/enties-api/datatransfer-items-drop-directoryReader-root.html [ Skip ] +webkit.org/b/176423 editing/pasteboard/enties-api/datatransfer-items-drop-directoryReader.html [ Skip ] +webkit.org/b/176423 editing/pasteboard/enties-api/datatransfer-items-drop-fileEntry-file.html [ Skip ] +webkit.org/b/176423 editing/pasteboard/enties-api/datatransfer-items-drop-getAsEntry.html [ Skip ] +webkit.org/b/176423 editing/pasteboard/enties-api/datatransfer-items-drop-getDirectory.html [ Skip ] +webkit.org/b/176423 editing/pasteboard/enties-api/datatransfer-items-drop-getFile.html [ Skip ] +webkit.org/b/176423 editing/pasteboard/enties-api/datatransfer-items-drop-getParent-root.html [ Skip ] +webkit.org/b/176423 editing/pasteboard/enties-api/datatransfer-items-drop-getParent.html [ Skip ] +webkit.org/b/176423 editing/pasteboard/enties-api/datatransfer-items-drop-getParent2.html [ Skip ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [221634] trunk/Tools
Title: [221634] trunk/Tools Revision 221634 Author mmaxfi...@apple.com Date 2017-09-05 14:11:59 -0700 (Tue, 05 Sep 2017) Log Message WSL should support the bool type https://bugs.webkit.org/show_bug.cgi?id=176285 Reviewed by Filip Pizlo. Very similar to the int and uint types. This patch also adds support for a logical negation _expression_ "!x". This patch also reverts the ability of the program author to create their own "operator!()", and instead adds the ability of the program author to create their own "operator bool()". The code is generic, so programmers can make two arbitrary types Foo and Bar, and implement a "operator Bar(Foo)." The logical negation _expression_ is a built-in, and requires its argument be a bool. * WebGPUShadingLanguageRI/All.js: * WebGPUShadingLanguageRI/BoolLiteral.js: Copied from Tools/WebGPUShadingLanguageRI/NativeFunc.js. (BoolLiteral): (BoolLiteral.prototype.get value): (BoolLiteral.prototype.get isConstexpr): (BoolLiteral.prototype.toString): * WebGPUShadingLanguageRI/Checker.js: * WebGPUShadingLanguageRI/Evaluator.js: (Evaluator.prototype.visitBoolLiteral): (Evaluator.prototype.visitLogicalNot): * WebGPUShadingLanguageRI/Func.js: (Func): (Func.prototype.get isCast): (Func.prototype.toDeclString): * WebGPUShadingLanguageRI/FuncDef.js: (FuncDef): (FuncDef.prototype.get body): (FuncDef.prototype.rewrite): * WebGPUShadingLanguageRI/Intrinsics.js: (Intrinsics): * WebGPUShadingLanguageRI/Lexer.js: (Lexer.prototype.next): (Lexer): * WebGPUShadingLanguageRI/LogicalNot.js: Copied from Tools/WebGPUShadingLanguageRI/NativeFunc.js. (LogicalNot): (LogicalNot.prototype.get operand): (LogicalNot.prototype.toString): * WebGPUShadingLanguageRI/NativeFunc.js: (NativeFunc): * WebGPUShadingLanguageRI/Parse.js: (parseTerm): (parsePossiblePrefix): (parsePossibleRelationalEquality): (parseFuncName): (parseOperatorFuncDefValues): (parseNonOperatorFuncDefValues): (parseGenericFuncDefValues): (parseFuncDecl): (parseProtocolFuncDecl): (parseFuncDef): (parseNative): (parse): * WebGPUShadingLanguageRI/Rewriter.js: (Rewriter.prototype.visitBoolLiteral): (Rewriter.prototype.visitLogicalNot): (Rewriter): * WebGPUShadingLanguageRI/StandardLibrary.js: * WebGPUShadingLanguageRI/Test.html: * WebGPUShadingLanguageRI/Test.js: (makeUInt): (makeBool): (checkUInt): (checkBool): (TEST_literalBool): (TEST_identityBool): (TEST_intSimpleMath): (TEST_uintSimpleMath): (TEST_equality): (TEST_logicalNegation): (TEST_notEquality): (TEST_equalityTypeFailure): (TEST_add1): Deleted. * WebGPUShadingLanguageRI/TypeDefResolver.js: (TypeDefResolver.prototype.visitFuncDef): * WebGPUShadingLanguageRI/Visitor.js: (Visitor.prototype.visitBoolLiteral): (Visitor.prototype.visitLogicalNot): Modified Paths trunk/Tools/ChangeLog trunk/Tools/WebGPUShadingLanguageRI/All.js trunk/Tools/WebGPUShadingLanguageRI/Checker.js trunk/Tools/WebGPUShadingLanguageRI/Evaluator.js trunk/Tools/WebGPUShadingLanguageRI/Func.js trunk/Tools/WebGPUShadingLanguageRI/FuncDef.js trunk/Tools/WebGPUShadingLanguageRI/Intrinsics.js trunk/Tools/WebGPUShadingLanguageRI/Lexer.js trunk/Tools/WebGPUShadingLanguageRI/NativeFunc.js trunk/Tools/WebGPUShadingLanguageRI/Parse.js trunk/Tools/WebGPUShadingLanguageRI/Rewriter.js trunk/Tools/WebGPUShadingLanguageRI/StandardLibrary.js trunk/Tools/WebGPUShadingLanguageRI/Test.html trunk/Tools/WebGPUShadingLanguageRI/Test.js trunk/Tools/WebGPUShadingLanguageRI/TypeDefResolver.js trunk/Tools/WebGPUShadingLanguageRI/Visitor.js Added Paths trunk/Tools/WebGPUShadingLanguageRI/BoolLiteral.js trunk/Tools/WebGPUShadingLanguageRI/LogicalNot.js Diff Modified: trunk/Tools/ChangeLog (221633 => 221634) --- trunk/Tools/ChangeLog 2017-09-05 21:00:23 UTC (rev 221633) +++ trunk/Tools/ChangeLog 2017-09-05 21:11:59 UTC (rev 221634) @@ -1,3 +1,84 @@ +2017-09-05 Myles C. Maxfield + +WSL should support the bool type +https://bugs.webkit.org/show_bug.cgi?id=176285 + +Reviewed by Filip Pizlo. + +Very similar to the int and uint types. This patch also adds support for a logical negation _expression_ "!x". +This patch also reverts the ability of the program author to create their own "operator!()", and instead +adds the ability of the program author to create their own "operator bool()". The code is generic, so +programmers can make two arbitrary types Foo and Bar, and implement a "operator Bar(Foo)." The logical +negation _expression_ is a built-in, and requires its argument be a bool. + +* WebGPUShadingLanguageRI/All.js: +* WebGPUShadingLanguageRI/BoolLiteral.js: Copied from Tools/WebGPUShadingLanguageRI/NativeFunc.js. +(BoolLiteral): +(BoolLiteral.prototype.get value): +(BoolLiteral.prototype.get isConstexpr): +(BoolLiteral.prototype.toString): +* WebGPUShadingLanguageRI/Checker.js: +* WebGPUShadingLanguageRI/Evaluator.js: +(Evaluator.prototype.visitBoolLiteral): +(Evaluator.prototype.
[webkit-changes] [221633] trunk
Title: [221633] trunk Revision 221633 Author commit-qu...@webkit.org Date 2017-09-05 14:00:23 -0700 (Tue, 05 Sep 2017) Log Message Cache Storage Engine should not mix different origin caches https://bugs.webkit.org/show_bug.cgi?id=176394 Patch by Youenn Fablet on 2017-09-05 Reviewed by Alex Christensen. Source/WebKit: * NetworkProcess/cache/CacheStorageEngine.cpp: (WebKit::CacheStorage::Engine::readCachesFromDisk): Initializing the salt before creating the Caches object so that its persistency path is correctly computed. * NetworkProcess/cache/CacheStorageEngineCaches.cpp: (WebKit::CacheStorage::cachesRootPath): Setting origin as partition string. LayoutTests: * http/tests/cache-storage/cache-origins.https-expected.txt: Added. * http/tests/cache-storage/cache-origins.https.html: Added. * http/tests/cache-storage/resources/cache-persistency-iframe.html: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/http/tests/cache-storage/resources/cache-persistency-iframe.html trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/NetworkProcess/cache/CacheStorageEngine.cpp trunk/Source/WebKit/NetworkProcess/cache/CacheStorageEngineCaches.cpp Added Paths trunk/LayoutTests/http/tests/cache-storage/cache-origins.https-expected.txt trunk/LayoutTests/http/tests/cache-storage/cache-origins.https.html Diff Modified: trunk/LayoutTests/ChangeLog (221632 => 221633) --- trunk/LayoutTests/ChangeLog 2017-09-05 20:41:31 UTC (rev 221632) +++ trunk/LayoutTests/ChangeLog 2017-09-05 21:00:23 UTC (rev 221633) @@ -1,3 +1,14 @@ +2017-09-05 Youenn Fablet + +Cache Storage Engine should not mix different origin caches +https://bugs.webkit.org/show_bug.cgi?id=176394 + +Reviewed by Alex Christensen. + +* http/tests/cache-storage/cache-origins.https-expected.txt: Added. +* http/tests/cache-storage/cache-origins.https.html: Added. +* http/tests/cache-storage/resources/cache-persistency-iframe.html: + 2017-09-05 Per Arne Vollan Unskip two tests which was skipped by mistake. Added: trunk/LayoutTests/http/tests/cache-storage/cache-origins.https-expected.txt (0 => 221633) --- trunk/LayoutTests/http/tests/cache-storage/cache-origins.https-expected.txt (rev 0) +++ trunk/LayoutTests/http/tests/cache-storage/cache-origins.https-expected.txt 2017-09-05 21:00:23 UTC (rev 221633) @@ -0,0 +1,5 @@ + + +PASS Create a cache storage and look at the representation +PASS Caches from different origins should not mix + Added: trunk/LayoutTests/http/tests/cache-storage/cache-origins.https.html (0 => 221633) --- trunk/LayoutTests/http/tests/cache-storage/cache-origins.https.html (rev 0) +++ trunk/LayoutTests/http/tests/cache-storage/cache-origins.https.html 2017-09-05 21:00:23 UTC (rev 221633) @@ -0,0 +1,43 @@ + + + +Cache Storage: testing persistency of different origins + + +