date:20180411

[webkit-changes] [230557] trunk

2018-04-11 Thread zandobersek

Title: [230557] trunk








Revision 230557
Author zandober...@gmail.com
Date 2018-04-11 22:53:26 -0700 (Wed, 11 Apr 2018)


Log Message
[WPE] Make WebKitWebViewBackend object mandatory for webkit_web_view_new*() constructors
https://bugs.webkit.org/show_bug.cgi?id=184513

Reviewed by Michael Catanzaro.

Source/WebKit:

webkit_web_view_new*() constructors should always expect a non-null
WebKitWebViewBackend object, forcing the user to specify how the
wpe_view_backend object is managed for the WebKitWebView that's being
created.

webkitWebViewBackendCreateDefault() and the default
_WebKitWebViewBackend() constructor are removed. WPE-specific
webkit_web_view_new*() entrypoints are updated to bail if the passed-in
WebKitWebViewBackend object is null. Documentation is updated
accordingly.

* UIProcess/API/glib/WebKitWebView.cpp:
(webkitWebViewConstructed):
* UIProcess/API/wpe/WebKitWebViewBackend.cpp:
(webkitWebViewBackendCreateDefault): Deleted.
* UIProcess/API/wpe/WebKitWebViewBackendPrivate.h:
* UIProcess/API/wpe/WebKitWebViewWPE.cpp:
(webkit_web_view_new):
(webkit_web_view_new_with_context):
(webkit_web_view_new_with_related_view):
(webkit_web_view_new_with_settings):
(webkit_web_view_new_with_user_content_manager):

Tools:

Update the WPE-specific testWebViewWebBackend() test case, removing the
test that passes a null WebKitWebViewBackend object to the
webkit_web_view_new() call.

Helper createWebViewBackend() that's called via Test::createWebView()
variations is updated to, in case of not using the headless backend,
return a WebKitWebViewBackend instance that wraps around a
default wpe_view_backend object.

* TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
(testWebViewWebBackend):
* TestWebKitAPI/glib/WebKitGLib/TestMain.h:
(Test::createWebViewBackend):

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/API/glib/WebKitWebView.cpp
trunk/Source/WebKit/UIProcess/API/wpe/WebKitWebViewBackend.cpp
trunk/Source/WebKit/UIProcess/API/wpe/WebKitWebViewBackendPrivate.h
trunk/Source/WebKit/UIProcess/API/wpe/WebKitWebViewWPE.cpp
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp
trunk/Tools/TestWebKitAPI/glib/WebKitGLib/TestMain.h




Diff

Modified: trunk/Source/WebKit/ChangeLog (230556 => 230557)

--- trunk/Source/WebKit/ChangeLog	2018-04-12 04:27:24 UTC (rev 230556)
+++ trunk/Source/WebKit/ChangeLog	2018-04-12 05:53:26 UTC (rev 230557)
@@ -1,3 +1,33 @@
+2018-04-11  Zan Dobersek  
+
+[WPE] Make WebKitWebViewBackend object mandatory for webkit_web_view_new*() constructors
+https://bugs.webkit.org/show_bug.cgi?id=184513
+
+Reviewed by Michael Catanzaro.
+
+webkit_web_view_new*() constructors should always expect a non-null
+WebKitWebViewBackend object, forcing the user to specify how the
+wpe_view_backend object is managed for the WebKitWebView that's being
+created.
+
+webkitWebViewBackendCreateDefault() and the default
+_WebKitWebViewBackend() constructor are removed. WPE-specific
+webkit_web_view_new*() entrypoints are updated to bail if the passed-in
+WebKitWebViewBackend object is null. Documentation is updated
+accordingly.
+
+* UIProcess/API/glib/WebKitWebView.cpp:
+(webkitWebViewConstructed):
+* UIProcess/API/wpe/WebKitWebViewBackend.cpp:
+(webkitWebViewBackendCreateDefault): Deleted.
+* UIProcess/API/wpe/WebKitWebViewBackendPrivate.h:
+* UIProcess/API/wpe/WebKitWebViewWPE.cpp:
+(webkit_web_view_new):
+(webkit_web_view_new_with_context):
+(webkit_web_view_new_with_related_view):
+(webkit_web_view_new_with_settings):
+(webkit_web_view_new_with_user_content_manager):
+
 2018-04-11  Fujii Hironori  
 
 [curl][WebKit] Implement NetworkDataTaskCurl


Modified: trunk/Source/WebKit/UIProcess/API/glib/WebKitWebView.cpp (230556 => 230557)

--- trunk/Source/WebKit/UIProcess/API/glib/WebKitWebView.cpp	2018-04-12 04:27:24 UTC (rev 230556)
+++ trunk/Source/WebKit/UIProcess/API/glib/WebKitWebView.cpp	2018-04-12 05:53:26 UTC (rev 230557)
@@ -623,10 +623,6 @@
 
 WebKitWebView* webView = WEBKIT_WEB_VIEW(object);
 WebKitWebViewPrivate* priv = webView->priv;
-#if PLATFORM(WPE)
-if (!priv->backend)
-priv->backend = webkitWebViewBackendCreateDefault();
-#endif
 if (priv->relatedView) {
 priv->context = webkit_web_view_get_context(priv->relatedView);
 priv->isEphemeral = webkit_web_view_is_ephemeral(priv->relatedView);


Modified: trunk/Source/WebKit/UIProcess/API/wpe/WebKitWebViewBackend.cpp (230556 => 230557)

--- trunk/Source/WebKit/UIProcess/API/wpe/WebKitWebViewBackend.cpp	2018-04-12 04:27:24 UTC (rev 230556)
+++ trunk/Source/WebKit/UIProcess/API/wpe/WebKitWebViewBackend.cpp	2018-04-12 05:53:26 UTC (rev 230557)
@@ -46,13 +46,6 @@
 ASSERT(notifyCallbackData);
 }
 
-

[webkit-changes] [230556] trunk/Source/JavaScriptCore

2018-04-11 Thread utatane . tea

Title: [230556] trunk/Source/_javascript_Core








Revision 230556
Author utatane@gmail.com
Date 2018-04-11 21:27:24 -0700 (Wed, 11 Apr 2018)


Log Message
[JSC] Add CCallHelpers::CellValue to wrap JSCell GPR to convert it to EncodedJSValue
https://bugs.webkit.org/show_bug.cgi?id=184500

Reviewed by Mark Lam.

Instead of passing JSValue::JSCellTag to callOperation meta-program to convert
JSCell GPR to EncodedJSValue in 32bit code, we add CallHelpers::CellValue.
It is a wrapper for GPRReg, like TrustedImmPtr for pointer value. When poking
CellValue, 32bit code emits JSValue::CellTag automatically. In 64bit, we just
poke held GPR. The benefit from this CellValue is that we can use the same code
for 32bit and 64bit. This patch removes several ifdefs.

* bytecode/AccessCase.cpp:
(JSC::AccessCase::generateImpl):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileCallDOMGetter):
(JSC::DFG::SpeculativeJIT::compileGetDirectPname):
(JSC::DFG::SpeculativeJIT::cachedPutById):
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::cachedGetById):
(JSC::DFG::SpeculativeJIT::cachedGetByIdWithThis):
* jit/CCallHelpers.h:
(JSC::CCallHelpers::CellValue::CellValue):
(JSC::CCallHelpers::CellValue::gpr const):
(JSC::CCallHelpers::setupArgumentsImpl):

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/bytecode/AccessCase.cpp
trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.cpp
trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT32_64.cpp
trunk/Source/_javascript_Core/jit/CCallHelpers.h




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (230555 => 230556)

--- trunk/Source/_javascript_Core/ChangeLog	2018-04-12 04:19:30 UTC (rev 230555)
+++ trunk/Source/_javascript_Core/ChangeLog	2018-04-12 04:27:24 UTC (rev 230556)
@@ -1,3 +1,31 @@
+2018-04-11  Yusuke Suzuki  
+
+[JSC] Add CCallHelpers::CellValue to wrap JSCell GPR to convert it to EncodedJSValue
+https://bugs.webkit.org/show_bug.cgi?id=184500
+
+Reviewed by Mark Lam.
+
+Instead of passing JSValue::JSCellTag to callOperation meta-program to convert
+JSCell GPR to EncodedJSValue in 32bit code, we add CallHelpers::CellValue.
+It is a wrapper for GPRReg, like TrustedImmPtr for pointer value. When poking
+CellValue, 32bit code emits JSValue::CellTag automatically. In 64bit, we just
+poke held GPR. The benefit from this CellValue is that we can use the same code
+for 32bit and 64bit. This patch removes several ifdefs.
+
+* bytecode/AccessCase.cpp:
+(JSC::AccessCase::generateImpl):
+* dfg/DFGSpeculativeJIT.cpp:
+(JSC::DFG::SpeculativeJIT::compileCallDOMGetter):
+(JSC::DFG::SpeculativeJIT::compileGetDirectPname):
+(JSC::DFG::SpeculativeJIT::cachedPutById):
+* dfg/DFGSpeculativeJIT32_64.cpp:
+(JSC::DFG::SpeculativeJIT::cachedGetById):
+(JSC::DFG::SpeculativeJIT::cachedGetByIdWithThis):
+* jit/CCallHelpers.h:
+(JSC::CCallHelpers::CellValue::CellValue):
+(JSC::CCallHelpers::CellValue::gpr const):
+(JSC::CCallHelpers::setupArgumentsImpl):
+
 2018-04-11  Mark Lam  
 
 [Build fix] Replace CompactJITCodeMap with JITCodeMap.


Modified: trunk/Source/_javascript_Core/bytecode/AccessCase.cpp (230555 => 230556)

--- trunk/Source/_javascript_Core/bytecode/AccessCase.cpp	2018-04-12 04:19:30 UTC (rev 230555)
+++ trunk/Source/_javascript_Core/bytecode/AccessCase.cpp	2018-04-12 04:27:24 UTC (rev 230556)
@@ -844,24 +844,15 @@
 // FIXME: Remove this differences in custom values and custom accessors.
 // https://bugs.webkit.org/show_bug.cgi?id=158014
 GPRReg baseForCustom = m_type == CustomValueGetter || m_type == CustomValueSetter ? baseForAccessGPR : baseForCustomGetGPR; 
-#if USE(JSVALUE64)
 if (m_type == CustomValueGetter || m_type == CustomAccessorGetter) {
 jit.setupArguments(
-baseForCustom,
+CCallHelpers::CellValue(baseForCustom),
 CCallHelpers::TrustedImmPtr(ident.impl()));
-} else
-jit.setupArguments(baseForCustom, valueRegs.gpr());
-#else
-if (m_type == CustomValueGetter || m_type == CustomAccessorGetter) {
-jit.setupArguments(
-JSValue::JSCellType, baseForCustom,
-CCallHelpers::TrustedImmPtr(ident.impl()));
 } else {
 jit.setupArguments(
-JSValue::JSCellType, baseForCustom,
+CCallHelpers::CellValue(baseForCustom),
 valueRegs);
 }
-#endif
 jit.storePtr(GPRInfo::callFrameRegister, );
 
 PtrTag callTag = ptrTag(GetterSetterPtrTag, nextPtrTagID());


Modified: trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.cpp (230555 => 230556)

---

[webkit-changes] [230555] trunk/Tools

2018-04-11 Thread zalan

Title: [230555] trunk/Tools








Revision 230555
Author za...@apple.com
Date 2018-04-11 21:19:30 -0700 (Wed, 11 Apr 2018)


Log Message
[LayoutReloaded] Introduce needsLayout flag
https://bugs.webkit.org/show_bug.cgi?id=184527

Reviewed by Antti Koivisto.

Use the formatting state to mark boxes dirty.

* LayoutReloaded/FormattingContext/BlockFormatting/BlockFormattingContext.js:
(BlockFormattingContext.prototype.layout):
(BlockFormattingContext.prototype._firstInFlowChildWithNeedsLayout):
(BlockFormattingContext.prototype._nextInFlowSiblingWithNeedsLayout):
(BlockFormattingContext):
* LayoutReloaded/FormattingContext/FormattingContext.js:
(FormattingContext.prototype._layoutOutOfFlowDescendants):
* LayoutReloaded/FormattingState/FormattingState.js:
(FormattingState):
(FormattingState.prototype.markNeedsLayout):
(FormattingState.prototype.clearNeedsLayout):
(FormattingState.prototype.needsLayout):
(FormattingState.prototype.layoutNeeded):
(FormattingState.prototype._markSubTreeNeedsLayout):
* LayoutReloaded/LayoutState.js:
(LayoutState.prototype.formattingStateForBox):
(LayoutState.prototype.setNeedsLayout):
(LayoutState.prototype.needsLayout):
* LayoutReloaded/LayoutTree/Box.js:
(Layout.Box.prototype.isFormattingContextDescendant):
* LayoutReloaded/LayoutTree/Container.js:
(Layout.Container.prototype.isContainingBlockDescendant):

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/LayoutReloaded/FormattingContext/BlockFormatting/BlockFormattingContext.js
trunk/Tools/LayoutReloaded/FormattingContext/FormattingContext.js
trunk/Tools/LayoutReloaded/FormattingState/FormattingState.js
trunk/Tools/LayoutReloaded/LayoutState.js
trunk/Tools/LayoutReloaded/LayoutTree/Box.js
trunk/Tools/LayoutReloaded/LayoutTree/Container.js




Diff

Modified: trunk/Tools/ChangeLog (230554 => 230555)

--- trunk/Tools/ChangeLog	2018-04-12 03:55:51 UTC (rev 230554)
+++ trunk/Tools/ChangeLog	2018-04-12 04:19:30 UTC (rev 230555)
@@ -1,3 +1,35 @@
+2018-04-11  Zalan Bujtas  
+
+[LayoutReloaded] Introduce needsLayout flag
+https://bugs.webkit.org/show_bug.cgi?id=184527
+
+Reviewed by Antti Koivisto.
+
+Use the formatting state to mark boxes dirty.
+
+* LayoutReloaded/FormattingContext/BlockFormatting/BlockFormattingContext.js:
+(BlockFormattingContext.prototype.layout):
+(BlockFormattingContext.prototype._firstInFlowChildWithNeedsLayout):
+(BlockFormattingContext.prototype._nextInFlowSiblingWithNeedsLayout):
+(BlockFormattingContext):
+* LayoutReloaded/FormattingContext/FormattingContext.js:
+(FormattingContext.prototype._layoutOutOfFlowDescendants):
+* LayoutReloaded/FormattingState/FormattingState.js:
+(FormattingState):
+(FormattingState.prototype.markNeedsLayout):
+(FormattingState.prototype.clearNeedsLayout):
+(FormattingState.prototype.needsLayout):
+(FormattingState.prototype.layoutNeeded):
+(FormattingState.prototype._markSubTreeNeedsLayout):
+* LayoutReloaded/LayoutState.js:
+(LayoutState.prototype.formattingStateForBox):
+(LayoutState.prototype.setNeedsLayout):
+(LayoutState.prototype.needsLayout):
+* LayoutReloaded/LayoutTree/Box.js:
+(Layout.Box.prototype.isFormattingContextDescendant):
+* LayoutReloaded/LayoutTree/Container.js:
+(Layout.Container.prototype.isContainingBlockDescendant):
+
 2018-04-11  Jonathan Bedard  
 
 Fix TestInvocation class for newer versions of clang.


Modified: trunk/Tools/LayoutReloaded/FormattingContext/BlockFormatting/BlockFormattingContext.js (230554 => 230555)

--- trunk/Tools/LayoutReloaded/FormattingContext/BlockFormatting/BlockFormattingContext.js	2018-04-12 03:55:51 UTC (rev 230554)
+++ trunk/Tools/LayoutReloaded/FormattingContext/BlockFormatting/BlockFormattingContext.js	2018-04-12 04:19:30 UTC (rev 230555)
@@ -35,8 +35,7 @@
 
 // This is a post-order tree traversal layout.
 // The root container layout is done in the formatting context it lives in, not that one it creates, so let's start with the first child.
-if (this.formattingRoot().firstInFlowOrFloatChild())
-this._addToLayoutQueue(this.formattingRoot().firstInFlowOrFloatChild());
+this._addToLayoutQueue(this._firstInFlowChildWithNeedsLayout(this.formattingRoot()));
 // 1. Go all the way down to the leaf node
 // 2. Compute static position and width as we travers down
 // 3. As we climb back on the tree, compute height and finialize position
@@ -51,9 +50,10 @@
 this.layoutState().layout(layoutBox);
 break;
 }
-if (!layoutBox.isContainer() || !layoutBox.hasInFlowOrFloatChild())
+let childToLayout = this._firstInFlowChildWithNeedsLayout(layoutBox);
+if (!childToLayout)
 break;
-

[webkit-changes] [230554] trunk

2018-04-11 Thread cdumez

Title: [230554] trunk








Revision 230554
Author cdu...@apple.com
Date 2018-04-11 20:55:51 -0700 (Wed, 11 Apr 2018)


Log Message
input.webkitEntries does not work as expected when folder contains accented chars
https://bugs.webkit.org/show_bug.cgi?id=184517


Reviewed by Ryosuke Niwa.

Source/WebCore:

Use String::fromUTF8() to construct a WTF String from the char* returned by
dirname() in FileSystem::directoryName(). Previously, we were just calling
the String constructor, which would treat the input as latin 1 instead of
UTF-8.

Test: fast/forms/file/entries-api/webkitEntries-nonascii-folder-name.html

* platform/posix/FileSystemPOSIX.cpp:
(WebCore::FileSystem::directoryName):

LayoutTests:

Add layout test coverage.

* fast/forms/file/entries-api/webkitEntries-nonascii-folder-name-expected.txt: Added.
* fast/forms/file/entries-api/webkitEntries-nonascii-folder-name.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/posix/FileSystemPOSIX.cpp


Added Paths

trunk/LayoutTests/fast/forms/file/entries-api/resources/älo/
trunk/LayoutTests/fast/forms/file/entries-api/resources/älo/test.txt
trunk/LayoutTests/fast/forms/file/entries-api/webkitEntries-nonascii-folder-name-expected.txt
trunk/LayoutTests/fast/forms/file/entries-api/webkitEntries-nonascii-folder-name.html




Diff

Modified: trunk/LayoutTests/ChangeLog (230553 => 230554)

--- trunk/LayoutTests/ChangeLog	2018-04-12 02:44:06 UTC (rev 230553)
+++ trunk/LayoutTests/ChangeLog	2018-04-12 03:55:51 UTC (rev 230554)
@@ -1,3 +1,16 @@
+2018-04-11  Chris Dumez  
+
+input.webkitEntries does not work as expected when folder contains accented chars
+https://bugs.webkit.org/show_bug.cgi?id=184517
+
+
+Reviewed by Ryosuke Niwa.
+
+Add layout test coverage.
+
+* fast/forms/file/entries-api/webkitEntries-nonascii-folder-name-expected.txt: Added.
+* fast/forms/file/entries-api/webkitEntries-nonascii-folder-name.html: Added.
+
 2018-04-11  Youenn Fablet  
 
 Preventively expect UTF8 strings from libwebrtc SDP and error messages






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [230553] trunk/Source/bmalloc

2018-04-11 Thread sbarati

Title: [230553] trunk/Source/bmalloc








Revision 230553
Author sbar...@apple.com
Date 2018-04-11 19:44:06 -0700 (Wed, 11 Apr 2018)


Log Message
raise partial scavenge interval on x86-64
https://bugs.webkit.org/show_bug.cgi?id=184521

Rubber-stamped by Filip Pizlo.

This patch is an attempt to recover the 1-3% JetStream regression
my initial partial scavenging patch introduced on some Macs.

* bmalloc/Scavenger.cpp:
(bmalloc::Scavenger::threadRunLoop):

Modified Paths

trunk/Source/bmalloc/ChangeLog
trunk/Source/bmalloc/bmalloc/Scavenger.cpp




Diff

Modified: trunk/Source/bmalloc/ChangeLog (230552 => 230553)

--- trunk/Source/bmalloc/ChangeLog	2018-04-12 01:09:15 UTC (rev 230552)
+++ trunk/Source/bmalloc/ChangeLog	2018-04-12 02:44:06 UTC (rev 230553)
@@ -1,3 +1,16 @@
+2018-04-11  Saam Barati  
+
+raise partial scavenge interval on x86-64
+https://bugs.webkit.org/show_bug.cgi?id=184521
+
+Rubber-stamped by Filip Pizlo.
+
+This patch is an attempt to recover the 1-3% JetStream regression
+my initial partial scavenging patch introduced on some Macs.
+
+* bmalloc/Scavenger.cpp:
+(bmalloc::Scavenger::threadRunLoop):
+
 2018-04-10  Saam Barati  
 
 IsoHeapImpl::scavenge* needs to grab the lock


Modified: trunk/Source/bmalloc/bmalloc/Scavenger.cpp (230552 => 230553)

--- trunk/Source/bmalloc/bmalloc/Scavenger.cpp	2018-04-12 01:09:15 UTC (rev 230552)
+++ trunk/Source/bmalloc/bmalloc/Scavenger.cpp	2018-04-12 02:44:06 UTC (rev 230553)
@@ -407,7 +407,12 @@
 return ScavengeMode::Full;
 }
 
-if (timeSinceLastScavenge < std::chrono::milliseconds(8000)) {
+#if BCPU(X86_64)
+auto partialScavengeInterval = std::chrono::milliseconds(2);
+#else
+auto partialScavengeInterval = std::chrono::milliseconds(8000);
+#endif
+if (timeSinceLastScavenge < partialScavengeInterval) {
 // Rate limit partial scavenges.
 return ScavengeMode::None;
 }






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [230552] trunk/Source/WTF

2018-04-11 Thread said

Title: [230552] trunk/Source/WTF








Revision 230552
Author s...@apple.com
Date 2018-04-11 18:09:15 -0700 (Wed, 11 Apr 2018)


Log Message
Unreviewed, rolling out r230523.

Introduced MotionMark regression

Reverted changeset:

"Deactivate the WindowServer connection for the WebContent
process."
https://bugs.webkit.org/show_bug.cgi?id=184451
https://trac.webkit.org/changeset/230523

Modified Paths

trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/FeatureDefines.h




Diff

Modified: trunk/Source/WTF/ChangeLog (230551 => 230552)

--- trunk/Source/WTF/ChangeLog	2018-04-12 00:53:26 UTC (rev 230551)
+++ trunk/Source/WTF/ChangeLog	2018-04-12 01:09:15 UTC (rev 230552)
@@ -1,3 +1,16 @@
+2018-04-11  Said Abou-Hallawa  
+
+Unreviewed, rolling out r230523.
+
+Introduced MotionMark regression
+
+Reverted changeset:
+
+"Deactivate the WindowServer connection for the WebContent
+process."
+https://bugs.webkit.org/show_bug.cgi?id=184451
+https://trac.webkit.org/changeset/230523
+
 2018-04-11  Per Arne Vollan  
 
 Deactivate the WindowServer connection for the WebContent process.


Modified: trunk/Source/WTF/wtf/FeatureDefines.h (230551 => 230552)

--- trunk/Source/WTF/wtf/FeatureDefines.h	2018-04-12 00:53:26 UTC (rev 230551)
+++ trunk/Source/WTF/wtf/FeatureDefines.h	2018-04-12 01:09:15 UTC (rev 230552)
@@ -238,7 +238,7 @@
 #endif
 
 #if !defined(ENABLE_WEBPROCESS_WINDOWSERVER_BLOCKING)
-#define ENABLE_WEBPROCESS_WINDOWSERVER_BLOCKING __MAC_OS_X_VERSION_MIN_REQUIRED >= 101400
+#define ENABLE_WEBPROCESS_WINDOWSERVER_BLOCKING 0
 #endif
 
 #endif /* PLATFORM(MAC) */






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [230551] trunk/Source/WebKit

2018-04-11 Thread Hironori . Fujii

Title: [230551] trunk/Source/WebKit








Revision 230551
Author hironori.fu...@sony.com
Date 2018-04-11 17:53:26 -0700 (Wed, 11 Apr 2018)


Log Message
[curl][WebKit] Implement NetworkDataTaskCurl
https://bugs.webkit.org/show_bug.cgi?id=184488

Reviewed by Alex Christensen.

* NetworkProcess/NetworkDataTask.cpp:
(WebKit::NetworkDataTask::create):
* NetworkProcess/curl/NetworkDataTaskCurl.cpp: Added.
(WebKit::NetworkDataTaskCurl::NetworkDataTaskCurl):
(WebKit::NetworkDataTaskCurl::~NetworkDataTaskCurl):
(WebKit::NetworkDataTaskCurl::resume):
(WebKit::NetworkDataTaskCurl::suspend):
(WebKit::NetworkDataTaskCurl::cancel):
(WebKit::NetworkDataTaskCurl::invalidateAndCancel):
(WebKit::NetworkDataTaskCurl::state const):
(WebKit::NetworkDataTaskCurl::createCurlRequest):
(WebKit::NetworkDataTaskCurl::curlDidSendData):
(WebKit::NetworkDataTaskCurl::curlDidReceiveResponse):
(WebKit::NetworkDataTaskCurl::curlDidReceiveBuffer):
(WebKit::NetworkDataTaskCurl::curlDidComplete):
(WebKit::NetworkDataTaskCurl::curlDidFailWithError):
(WebKit::NetworkDataTaskCurl::shouldRedirectAsGET):
(WebKit::NetworkDataTaskCurl::willPerformHTTPRedirection):
(WebKit::NetworkDataTaskCurl::tryHttpAuthentication):
(WebKit::NetworkDataTaskCurl::restartWithCredential):
(WebKit::NetworkDataTaskCurl::appendCookieHeader):
(WebKit::NetworkDataTaskCurl::handleCookieHeaders):
* NetworkProcess/curl/NetworkDataTaskCurl.h: Added.
* PlatformWin.cmake:

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/NetworkProcess/NetworkDataTask.cpp
trunk/Source/WebKit/PlatformWin.cmake


Added Paths

trunk/Source/WebKit/NetworkProcess/curl/NetworkDataTaskCurl.cpp
trunk/Source/WebKit/NetworkProcess/curl/NetworkDataTaskCurl.h




Diff

Modified: trunk/Source/WebKit/ChangeLog (230550 => 230551)

--- trunk/Source/WebKit/ChangeLog	2018-04-11 22:46:55 UTC (rev 230550)
+++ trunk/Source/WebKit/ChangeLog	2018-04-12 00:53:26 UTC (rev 230551)
@@ -1,3 +1,35 @@
+2018-04-11  Fujii Hironori  
+
+[curl][WebKit] Implement NetworkDataTaskCurl
+https://bugs.webkit.org/show_bug.cgi?id=184488
+
+Reviewed by Alex Christensen.
+
+* NetworkProcess/NetworkDataTask.cpp:
+(WebKit::NetworkDataTask::create):
+* NetworkProcess/curl/NetworkDataTaskCurl.cpp: Added.
+(WebKit::NetworkDataTaskCurl::NetworkDataTaskCurl):
+(WebKit::NetworkDataTaskCurl::~NetworkDataTaskCurl):
+(WebKit::NetworkDataTaskCurl::resume):
+(WebKit::NetworkDataTaskCurl::suspend):
+(WebKit::NetworkDataTaskCurl::cancel):
+(WebKit::NetworkDataTaskCurl::invalidateAndCancel):
+(WebKit::NetworkDataTaskCurl::state const):
+(WebKit::NetworkDataTaskCurl::createCurlRequest):
+(WebKit::NetworkDataTaskCurl::curlDidSendData):
+(WebKit::NetworkDataTaskCurl::curlDidReceiveResponse):
+(WebKit::NetworkDataTaskCurl::curlDidReceiveBuffer):
+(WebKit::NetworkDataTaskCurl::curlDidComplete):
+(WebKit::NetworkDataTaskCurl::curlDidFailWithError):
+(WebKit::NetworkDataTaskCurl::shouldRedirectAsGET):
+(WebKit::NetworkDataTaskCurl::willPerformHTTPRedirection):
+(WebKit::NetworkDataTaskCurl::tryHttpAuthentication):
+(WebKit::NetworkDataTaskCurl::restartWithCredential):
+(WebKit::NetworkDataTaskCurl::appendCookieHeader):
+(WebKit::NetworkDataTaskCurl::handleCookieHeaders):
+* NetworkProcess/curl/NetworkDataTaskCurl.h: Added.
+* PlatformWin.cmake:
+
 2018-04-11  Wenson Hsieh  
 
 [Extra zoom mode] Support pushing input view controllers onto the navigation stack


Modified: trunk/Source/WebKit/NetworkProcess/NetworkDataTask.cpp (230550 => 230551)

--- trunk/Source/WebKit/NetworkProcess/NetworkDataTask.cpp	2018-04-11 22:46:55 UTC (rev 230550)
+++ trunk/Source/WebKit/NetworkProcess/NetworkDataTask.cpp	2018-04-12 00:53:26 UTC (rev 230551)
@@ -40,6 +40,9 @@
 #if USE(SOUP)
 #include "NetworkDataTaskSoup.h"
 #endif
+#if USE(CURL)
+#include "NetworkDataTaskCurl.h"
+#endif
 
 using namespace WebCore;
 
@@ -56,6 +59,9 @@
 #if USE(SOUP)
 return NetworkDataTaskSoup::create(session, client, parameters.request, parameters.storedCredentialsPolicy, parameters.contentSniffingPolicy, parameters.contentEncodingSniffingPolicy, parameters.shouldClearReferrerOnHTTPSToHTTPRedirect);
 #endif
+#if USE(CURL)
+return NetworkDataTaskCurl::create(session, client, parameters.request, parameters.storedCredentialsPolicy, parameters.contentSniffingPolicy, parameters.contentEncodingSniffingPolicy, parameters.shouldClearReferrerOnHTTPSToHTTPRedirect);
+#endif
 }
 
 NetworkDataTask::NetworkDataTask(NetworkSession& session, NetworkDataTaskClient& client, const ResourceRequest& requestWithCredentials, StoredCredentialsPolicy storedCredentialsPolicy, bool shouldClearReferrerOnHTTPSToHTTPRedirect)


Added: trunk/Source/WebKit/NetworkProcess/curl/NetworkDataTaskCurl.cpp (0 => 230551)

---

[webkit-changes] [230550] trunk/Source/JavaScriptCore

2018-04-11 Thread mark . lam

Title: [230550] trunk/Source/_javascript_Core








Revision 230550
Author mark@apple.com
Date 2018-04-11 15:46:55 -0700 (Wed, 11 Apr 2018)


Log Message
[Build fix] Replace CompactJITCodeMap with JITCodeMap.
https://bugs.webkit.org/show_bug.cgi?id=184512


Not reviewed.

* bytecode/CodeBlock.h:
* jit/JITCodeMap.h:

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/bytecode/CodeBlock.h
trunk/Source/_javascript_Core/jit/JITCodeMap.h




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (230549 => 230550)

--- trunk/Source/_javascript_Core/ChangeLog	2018-04-11 22:09:09 UTC (rev 230549)
+++ trunk/Source/_javascript_Core/ChangeLog	2018-04-11 22:46:55 UTC (rev 230550)
@@ -1,5 +1,16 @@
 2018-04-11  Mark Lam  
 
+[Build fix] Replace CompactJITCodeMap with JITCodeMap.
+https://bugs.webkit.org/show_bug.cgi?id=184512
+
+
+Not reviewed.
+
+* bytecode/CodeBlock.h:
+* jit/JITCodeMap.h:
+
+2018-04-11  Mark Lam  
+
 Replace CompactJITCodeMap with JITCodeMap.
 https://bugs.webkit.org/show_bug.cgi?id=184512
 


Modified: trunk/Source/_javascript_Core/bytecode/CodeBlock.h (230549 => 230550)

--- trunk/Source/_javascript_Core/bytecode/CodeBlock.h	2018-04-11 22:09:09 UTC (rev 230549)
+++ trunk/Source/_javascript_Core/bytecode/CodeBlock.h	2018-04-11 22:46:55 UTC (rev 230550)
@@ -301,6 +301,7 @@
 
 void linkIncomingCall(ExecState* callerFrame, LLIntCallLinkInfo*);
 
+#if ENABLE(JIT)
 void setJITCodeMap(JITCodeMap&& jitCodeMap)
 {
 m_jitCodeMap = WTFMove(jitCodeMap);
@@ -309,7 +310,8 @@
 {
 return m_jitCodeMap;
 }
-
+#endif
+
 typedef JSC::Instruction Instruction;
 typedef PoisonedRefCountedArray& UnpackedInstructions;
 
@@ -986,8 +988,8 @@
 SentinelLinkedList m_incomingCalls;
 SentinelLinkedList m_incomingPolymorphicCalls;
 std::unique_ptr m_pcToCodeOriginMap;
+JITCodeMap m_jitCodeMap;
 #endif
-JITCodeMap m_jitCodeMap;
 #if ENABLE(DFG_JIT)
 // This is relevant to non-DFG code blocks that serve as the profiled code block
 // for DFG code blocks.


Modified: trunk/Source/_javascript_Core/jit/JITCodeMap.h (230549 => 230550)

--- trunk/Source/_javascript_Core/jit/JITCodeMap.h	2018-04-11 22:09:09 UTC (rev 230549)
+++ trunk/Source/_javascript_Core/jit/JITCodeMap.h	2018-04-11 22:46:55 UTC (rev 230550)
@@ -25,6 +25,8 @@
 
 #pragma once
 
+#if ENABLE(JIT)
+
 #include "CodeLocation.h"
 #include 
 #include 
@@ -76,3 +78,5 @@
 };
 
 } // namespace JSC
+
+#endif // ENABLE(JIT)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [230549] trunk/Source/JavaScriptCore

2018-04-11 Thread mark . lam

Title: [230549] trunk/Source/_javascript_Core








Revision 230549
Author mark@apple.com
Date 2018-04-11 15:09:09 -0700 (Wed, 11 Apr 2018)


Log Message
Replace CompactJITCodeMap with JITCodeMap.
https://bugs.webkit.org/show_bug.cgi?id=184512


Reviewed by Filip Pizlo.

* CMakeLists.txt:
* _javascript_Core.xcodeproj/project.pbxproj:
* bytecode/CodeBlock.h:
(JSC::CodeBlock::setJITCodeMap):
(JSC::CodeBlock::jitCodeMap const):
(JSC::CodeBlock::jitCodeMap): Deleted.
* dfg/DFGOSRExit.cpp:
(JSC::DFG::OSRExit::executeOSRExit):
* dfg/DFGOSRExitCompilerCommon.cpp:
(JSC::DFG::adjustAndJumpToTarget):
* jit/AssemblyHelpers.cpp:
(JSC::AssemblyHelpers::decodedCodeMapFor): Deleted.
* jit/AssemblyHelpers.h:
* jit/CompactJITCodeMap.h: Removed.
* jit/JIT.cpp:
(JSC::JIT::link):
* jit/JITCodeMap.h: Added.
(JSC::JITCodeMap::Entry::Entry):
(JSC::JITCodeMap::Entry::bytecodeIndex const):
(JSC::JITCodeMap::Entry::codeLocation):
(JSC::JITCodeMap::append):
(JSC::JITCodeMap::finish):
(JSC::JITCodeMap::find const):
(JSC::JITCodeMap::operator bool const):
* llint/LLIntSlowPaths.cpp:
(JSC::LLInt::LLINT_SLOW_PATH_DECL):

Modified Paths

trunk/Source/_javascript_Core/CMakeLists.txt
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/_javascript_Core.xcodeproj/project.pbxproj
trunk/Source/_javascript_Core/bytecode/CodeBlock.h
trunk/Source/_javascript_Core/dfg/DFGOSRExit.cpp
trunk/Source/_javascript_Core/dfg/DFGOSRExitCompilerCommon.cpp
trunk/Source/_javascript_Core/jit/AssemblyHelpers.cpp
trunk/Source/_javascript_Core/jit/AssemblyHelpers.h
trunk/Source/_javascript_Core/jit/JIT.cpp
trunk/Source/_javascript_Core/llint/LLIntSlowPaths.cpp


Added Paths

trunk/Source/_javascript_Core/jit/JITCodeMap.h


Removed Paths

trunk/Source/_javascript_Core/jit/CompactJITCodeMap.h




Diff

Modified: trunk/Source/_javascript_Core/CMakeLists.txt (230548 => 230549)

--- trunk/Source/_javascript_Core/CMakeLists.txt	2018-04-11 21:49:28 UTC (rev 230548)
+++ trunk/Source/_javascript_Core/CMakeLists.txt	2018-04-11 22:09:09 UTC (rev 230549)
@@ -615,7 +615,6 @@
 
 jit/AssemblyHelpers.h
 jit/CCallHelpers.h
-jit/CompactJITCodeMap.h
 jit/ExecutableAllocator.h
 jit/FPRInfo.h
 jit/GCAwareJITStubRoutine.h
@@ -622,6 +621,7 @@
 jit/GPRInfo.h
 jit/JITAllocator.h
 jit/JITCode.h
+jit/JITCodeMap.h
 jit/JITCompilationEffort.h
 jit/JITMathICForwards.h
 jit/JITOperations.h


Modified: trunk/Source/_javascript_Core/ChangeLog (230548 => 230549)

--- trunk/Source/_javascript_Core/ChangeLog	2018-04-11 21:49:28 UTC (rev 230548)
+++ trunk/Source/_javascript_Core/ChangeLog	2018-04-11 22:09:09 UTC (rev 230549)
@@ -1,3 +1,38 @@
+2018-04-11  Mark Lam  
+
+Replace CompactJITCodeMap with JITCodeMap.
+https://bugs.webkit.org/show_bug.cgi?id=184512
+
+
+Reviewed by Filip Pizlo.
+
+* CMakeLists.txt:
+* _javascript_Core.xcodeproj/project.pbxproj:
+* bytecode/CodeBlock.h:
+(JSC::CodeBlock::setJITCodeMap):
+(JSC::CodeBlock::jitCodeMap const):
+(JSC::CodeBlock::jitCodeMap): Deleted.
+* dfg/DFGOSRExit.cpp:
+(JSC::DFG::OSRExit::executeOSRExit):
+* dfg/DFGOSRExitCompilerCommon.cpp:
+(JSC::DFG::adjustAndJumpToTarget):
+* jit/AssemblyHelpers.cpp:
+(JSC::AssemblyHelpers::decodedCodeMapFor): Deleted.
+* jit/AssemblyHelpers.h:
+* jit/CompactJITCodeMap.h: Removed.
+* jit/JIT.cpp:
+(JSC::JIT::link):
+* jit/JITCodeMap.h: Added.
+(JSC::JITCodeMap::Entry::Entry):
+(JSC::JITCodeMap::Entry::bytecodeIndex const):
+(JSC::JITCodeMap::Entry::codeLocation):
+(JSC::JITCodeMap::append):
+(JSC::JITCodeMap::finish):
+(JSC::JITCodeMap::find const):
+(JSC::JITCodeMap::operator bool const):
+* llint/LLIntSlowPaths.cpp:
+(JSC::LLInt::LLINT_SLOW_PATH_DECL):
+
 2018-04-11  Yusuke Suzuki  
 
 [DFG] Remove CompareSlowPathGenerator


Modified: trunk/Source/_javascript_Core/_javascript_Core.xcodeproj/project.pbxproj (230548 => 230549)

--- trunk/Source/_javascript_Core/_javascript_Core.xcodeproj/project.pbxproj	2018-04-11 21:49:28 UTC (rev 230548)
+++ trunk/Source/_javascript_Core/_javascript_Core.xcodeproj/project.pbxproj	2018-04-11 22:09:09 UTC (rev 230549)
@@ -549,7 +549,6 @@
 		0FD3E40E1B618B6600C80E1E /* PropertyCondition.h in Headers */ = {isa = PBXBuildFile; fileRef = 0FD3E4081B618B6600C80E1E /* PropertyCondition.h */; settings = {ATTRIBUTES = (Private, ); }; };
 		0FD79A2D1EBBBDBB00DA88D3 /* Synchronousness.h in Headers */ = {isa = PBXBuildFile; fileRef = 0FD79A2C1EBBBDB200DA88D3 /* Synchronousness.h */; settings = {ATTRIBUTES = (Private, ); }; };
 		0FD81AD3154FB4F000983E72 /* DFGDominators.h in Headers */ = {isa = PBXBuildFile; fileRef = 0FD81AD0154FB4EB00983E72 /* DFGDominators.h */; };
-		0FD82E39141AB14D00179C94 /* CompactJITCodeMap.h in Headers */ = {isa

[webkit-changes] [230548] trunk

2018-04-11 Thread youenn

Title: [230548] trunk








Revision 230548
Author you...@apple.com
Date 2018-04-11 14:49:28 -0700 (Wed, 11 Apr 2018)


Log Message
Preventively expect UTF8 strings from libwebrtc SDP and error messages
https://bugs.webkit.org/show_bug.cgi?id=184509

Reviewed by Eric Carlson.

Source/WebCore:

Make WebCore code expect any libwebrtc string to contain UTF-8.
Currently SDPs do not contain any UTF-8 specific character
but https://tools.ietf.org/html/rfc4566 allows it.

Add Internals API to set track id so that we can inject UTF-8 inside some WebRTC tests.
Test: webrtc/utf8-sdp.html

* Modules/mediastream/MediaStreamTrack.h:
(WebCore::MediaStreamTrack::setIdForTesting):
* Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp:
(WebCore::fromStdString):
(WebCore::fromSessionDescription):
(WebCore::LibWebRTCMediaEndpoint::doSetLocalDescription):
(WebCore::LibWebRTCMediaEndpoint::doSetRemoteDescription):
(WebCore::LibWebRTCMediaEndpoint::mediaStreamFromRTCStream):
(WebCore::LibWebRTCMediaEndpoint::addRemoteTrack):
(WebCore::LibWebRTCMediaEndpoint::addDataChannel):
(WebCore::LibWebRTCMediaEndpoint::OnIceCandidate):
(WebCore::LibWebRTCMediaEndpoint::createSessionDescriptionSucceeded):
(WebCore::LibWebRTCMediaEndpoint::createSessionDescriptionFailed):
(WebCore::LibWebRTCMediaEndpoint::setLocalSessionDescriptionFailed):
(WebCore::LibWebRTCMediaEndpoint::setRemoteSessionDescriptionFailed):
(WebCore::trackId): Deleted.
* Modules/mediastream/libwebrtc/LibWebRTCPeerConnectionBackend.cpp:
(WebCore::fromStdString):
(WebCore::LibWebRTCPeerConnectionBackend::doAddIceCandidate):
(WebCore::createReceiverForSource):
* platform/mediastream/MediaStreamTrackPrivate.h:
(WebCore::MediaStreamTrackPrivate::setIdForTesting):
* testing/Internals.cpp:
(WebCore::Internals::setMediaStreamTrackIdentifier):
* testing/Internals.h:
* testing/Internals.idl:

LayoutTests:

* webrtc/utf8-sdp-expected.txt: Added.
* webrtc/utf8-sdp.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/mediastream/MediaStreamTrack.h
trunk/Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp
trunk/Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCPeerConnectionBackend.cpp
trunk/Source/WebCore/platform/mediastream/MediaStreamTrackPrivate.h
trunk/Source/WebCore/testing/Internals.cpp
trunk/Source/WebCore/testing/Internals.h
trunk/Source/WebCore/testing/Internals.idl


Added Paths

trunk/LayoutTests/webrtc/utf8-sdp-expected.txt
trunk/LayoutTests/webrtc/utf8-sdp.html




Diff

Modified: trunk/LayoutTests/ChangeLog (230547 => 230548)

--- trunk/LayoutTests/ChangeLog	2018-04-11 21:06:48 UTC (rev 230547)
+++ trunk/LayoutTests/ChangeLog	2018-04-11 21:49:28 UTC (rev 230548)
@@ -1,3 +1,13 @@
+2018-04-11  Youenn Fablet  
+
+Preventively expect UTF8 strings from libwebrtc SDP and error messages
+https://bugs.webkit.org/show_bug.cgi?id=184509
+
+Reviewed by Eric Carlson.
+
+* webrtc/utf8-sdp-expected.txt: Added.
+* webrtc/utf8-sdp.html: Added.
+
 2018-04-11  Alicia Boya García  
 
 [GTK] Unreviewed test gardening


Added: trunk/LayoutTests/webrtc/utf8-sdp-expected.txt (0 => 230548)

--- trunk/LayoutTests/webrtc/utf8-sdp-expected.txt	(rev 0)
+++ trunk/LayoutTests/webrtc/utf8-sdp-expected.txt	2018-04-11 21:49:28 UTC (rev 230548)
@@ -0,0 +1,4 @@
+
+
+PASS Testing video exchange with UTF-8 track id 
+


Added: trunk/LayoutTests/webrtc/utf8-sdp.html (0 => 230548)

--- trunk/LayoutTests/webrtc/utf8-sdp.html	(rev 0)
+++ trunk/LayoutTests/webrtc/utf8-sdp.html	2018-04-11 21:49:28 UTC (rev 230548)
@@ -0,0 +1,39 @@
+
+
+
+
+Testing UTF-8 content in SDP
+
+
+
+