[webkit-changes] [232828] tags/Safari-606.1.21/Source
Title: [232828] tags/Safari-606.1.21/Source
Revision 232828
Author kocsen_ch...@apple.com
Date 2018-06-13 21:56:42 -0700 (Wed, 13 Jun 2018)
Log Message
Revert r232741. rdar://problem/41108295
Modified Paths
tags/Safari-606.1.21/Source/_javascript_Core/ChangeLog
tags/Safari-606.1.21/Source/_javascript_Core/b3/B3Validate.cpp
tags/Safari-606.1.21/Source/_javascript_Core/b3/air/AirValidate.cpp
tags/Safari-606.1.21/Source/_javascript_Core/b3/testb3.cpp
tags/Safari-606.1.21/Source/_javascript_Core/dfg/DFGGraph.cpp
tags/Safari-606.1.21/Source/_javascript_Core/dfg/DFGValidate.cpp
tags/Safari-606.1.21/Source/WTF/ChangeLog
tags/Safari-606.1.21/Source/WTF/wtf/NaturalLoops.h
Diff
Modified: tags/Safari-606.1.21/Source/_javascript_Core/ChangeLog (232827 => 232828)
--- tags/Safari-606.1.21/Source/_javascript_Core/ChangeLog 2018-06-14 04:14:50 UTC (rev 232827)
+++ tags/Safari-606.1.21/Source/_javascript_Core/ChangeLog 2018-06-14 04:56:42 UTC (rev 232828)
@@ -1,3 +1,7 @@
+2018-06-13 Kocsen Chung
+
+Revert r232741. rdar://problem/41108295
+
2018-06-12 Saam Barati
Remove JSVirtualMachine shrinkFootprint when clients move to shrinkFootprintWhenIdle
Modified: tags/Safari-606.1.21/Source/_javascript_Core/b3/B3Validate.cpp (232827 => 232828)
--- tags/Safari-606.1.21/Source/_javascript_Core/b3/B3Validate.cpp 2018-06-14 04:14:50 UTC (rev 232827)
+++ tags/Safari-606.1.21/Source/_javascript_Core/b3/B3Validate.cpp 2018-06-14 04:56:42 UTC (rev 232828)
@@ -536,14 +536,6 @@
for (Variable* variable : m_procedure.variables())
VALIDATE(variable->type() != Void, ("At ", *variable));
-
-for (BasicBlock* block : m_procedure) {
-// We expect the predecessor list to be de-duplicated.
-HashSet predecessors;
-for (BasicBlock* predecessor : block->predecessors())
-predecessors.add(predecessor);
-VALIDATE(block->numPredecessors() == predecessors.size(), ("At ", *block));
-}
}
private:
Modified: tags/Safari-606.1.21/Source/_javascript_Core/b3/air/AirValidate.cpp (232827 => 232828)
--- tags/Safari-606.1.21/Source/_javascript_Core/b3/air/AirValidate.cpp 2018-06-14 04:14:50 UTC (rev 232827)
+++ tags/Safari-606.1.21/Source/_javascript_Core/b3/air/AirValidate.cpp 2018-06-14 04:56:42 UTC (rev 232828)
@@ -112,14 +112,6 @@
for (BasicBlock* successor : block->successorBlocks())
VALIDATE(validBlocks.contains(successor), ("In ", *block));
}
-
-for (BasicBlock* block : m_code) {
-// We expect the predecessor list to be de-duplicated.
-HashSet predecessors;
-for (BasicBlock* predecessor : block->predecessors())
-predecessors.add(predecessor);
-VALIDATE(block->numPredecessors() == predecessors.size(), ("At ", *block));
-}
}
private:
Modified: tags/Safari-606.1.21/Source/_javascript_Core/b3/testb3.cpp (232827 => 232828)
--- tags/Safari-606.1.21/Source/_javascript_Core/b3/testb3.cpp 2018-06-14 04:14:50 UTC (rev 232827)
+++ tags/Safari-606.1.21/Source/_javascript_Core/b3/testb3.cpp 2018-06-14 04:56:42 UTC (rev 232828)
@@ -10830,49 +10830,6 @@
CHECK(compileAndRun(proc, numerator, denominator) == chillMod(numerator, denominator));
}
-void testLoopWithMultipleHeaderEdges()
-{
-Procedure proc;
-BasicBlock* root = proc.addBlock();
-BasicBlock* innerHeader = proc.addBlock();
-BasicBlock* innerEnd = proc.addBlock();
-BasicBlock* outerHeader = proc.addBlock();
-BasicBlock* outerEnd = proc.addBlock();
-BasicBlock* end = proc.addBlock();
-
-auto* ne42 = outerHeader->appendNew(
-proc, NotEqual, Origin(),
-root->appendNew(proc, Origin(), GPRInfo::argumentGPR0),
-root->appendNew(proc, Origin(), 42));
-outerHeader->appendNewControlValue(
-proc, Branch, Origin(),
-ne42,
-FrequentedBlock(innerHeader), FrequentedBlock(outerEnd));
-outerEnd->appendNewControlValue(
-proc, Branch, Origin(),
-root->appendNew(
-proc, Trunc, Origin(),
-root->appendNew(proc, Origin(), GPRInfo::argumentGPR0)),
-FrequentedBlock(outerHeader), FrequentedBlock(end));
-
-SwitchValue* switchValue = innerHeader->appendNew(
-proc, Origin(), root->appendNew(proc, Origin(), GPRInfo::argumentGPR1));
-switchValue->setFallThrough(FrequentedBlock(innerEnd));
-for (unsigned i = 0; i < 20; ++i) {
-switchValue->appendCase(SwitchCase(i, FrequentedBlock(innerHeader)));
-}
-
-root->appendNewControlValue(proc, Jump, Origin(), FrequentedBlock(outerHeader));
-
-innerEnd->appendNewControlValue(proc, Jump, Origin(), FrequentedBlock(outerEnd));
-end->appendNewControlValue(
-proc, Return, Origin(),
-end->appendNew(proc, Origin(), 5678));
-
-auto code = compileProc(proc); // This shouldn't crash in computing NaturalLoops.
-
[webkit-changes] [232830] tags/Safari-606.1.21
Title: [232830] tags/Safari-606.1.21
Revision 232830
Author kocsen_ch...@apple.com
Date 2018-06-13 21:56:47 -0700 (Wed, 13 Jun 2018)
Log Message
Revert r231850. rdar://problem/41113111
Modified Paths
tags/Safari-606.1.21/Source/WebKit/ChangeLog
tags/Safari-606.1.21/Source/WebKit/NetworkProcess/mac/RemoteNetworkingContext.mm
tags/Safari-606.1.21/Source/WebKit/UIProcess/API/APIHTTPCookieStore.cpp
tags/Safari-606.1.21/Source/WebKit/UIProcess/WebProcessPool.cpp
tags/Safari-606.1.21/Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.cpp
tags/Safari-606.1.21/Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.h
tags/Safari-606.1.21/Tools/ChangeLog
tags/Safari-606.1.21/Tools/TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm
Diff
Modified: tags/Safari-606.1.21/Source/WebKit/ChangeLog (232829 => 232830)
--- tags/Safari-606.1.21/Source/WebKit/ChangeLog 2018-06-14 04:56:44 UTC (rev 232829)
+++ tags/Safari-606.1.21/Source/WebKit/ChangeLog 2018-06-14 04:56:47 UTC (rev 232830)
@@ -1,3 +1,7 @@
+2018-06-13 Kocsen Chung
+
+Revert r231850. rdar://problem/39111626
+
2018-06-12 Brent Fulgham
Turn CSS Spring Animations and Link Preload off by default for production builds.
Modified: tags/Safari-606.1.21/Source/WebKit/NetworkProcess/mac/RemoteNetworkingContext.mm (232829 => 232830)
--- tags/Safari-606.1.21/Source/WebKit/NetworkProcess/mac/RemoteNetworkingContext.mm 2018-06-14 04:56:44 UTC (rev 232829)
+++ tags/Safari-606.1.21/Source/WebKit/NetworkProcess/mac/RemoteNetworkingContext.mm 2018-06-14 04:56:47 UTC (rev 232830)
@@ -36,7 +36,6 @@
#import "WebsiteDataStoreParameters.h"
#import
#import
-#import
#import
using namespace WebCore;
@@ -46,12 +45,8 @@
void RemoteNetworkingContext::ensureWebsiteDataStoreSession(WebsiteDataStoreParameters&& parameters)
{
auto sessionID = parameters.networkSessionParameters.sessionID;
-if (auto* session = NetworkStorageSession::storageSession(sessionID)) {
-ASSERT(parameters.pendingCookies.isEmpty() || sessionID == PAL::SessionID::defaultSessionID());
-for (const auto& cookie : parameters.pendingCookies)
-session->setCookie(cookie);
+if (NetworkStorageSession::storageSession(sessionID))
return;
-}
String base;
if (SessionTracker::getIdentifierBase().isNull())
Modified: tags/Safari-606.1.21/Source/WebKit/UIProcess/API/APIHTTPCookieStore.cpp (232829 => 232830)
--- tags/Safari-606.1.21/Source/WebKit/UIProcess/API/APIHTTPCookieStore.cpp 2018-06-14 04:56:44 UTC (rev 232829)
+++ tags/Safari-606.1.21/Source/WebKit/UIProcess/API/APIHTTPCookieStore.cpp 2018-06-14 04:56:47 UTC (rev 232830)
@@ -54,7 +54,7 @@
unregisterForNewProcessPoolNotifications();
}
-void HTTPCookieStore::cookies(Function&)>&& completionHandler)
+void HTTPCookieStore::cookies(Function&)>&& completionHandler)
{
auto* pool = m_owningDataStore->processPoolForCookieStorageOperations();
if (!pool) {
@@ -61,7 +61,8 @@
Vector allCookies;
if (m_owningDataStore->sessionID() == PAL::SessionID::defaultSessionID())
allCookies = WebCore::NetworkStorageSession::defaultStorageSession().getAllCookies();
-allCookies.appendVector(m_owningDataStore->pendingCookies());
+else
+allCookies = m_owningDataStore->pendingCookies();
callOnMainThread([completionHandler = WTFMove(completionHandler), allCookies]() {
completionHandler(allCookies);
@@ -79,8 +80,7 @@
{
auto* pool = m_owningDataStore->processPoolForCookieStorageOperations();
if (!pool) {
-// FIXME: pendingCookies used for defaultSession because session cookies cannot be propagated to Network Process with uiProcessCookieStorageIdentifier.
-if (m_owningDataStore->sessionID() == PAL::SessionID::defaultSessionID() && !cookie.session)
+if (m_owningDataStore->sessionID() == PAL::SessionID::defaultSessionID())
WebCore::NetworkStorageSession::defaultStorageSession().setCookie(cookie);
else
m_owningDataStore->addPendingCookie(cookie);
@@ -101,11 +101,10 @@
{
auto* pool = m_owningDataStore->processPoolForCookieStorageOperations();
if (!pool) {
-if (m_owningDataStore->sessionID() == PAL::SessionID::defaultSessionID() && !cookie.session)
+if (m_owningDataStore->sessionID() == PAL::SessionID::defaultSessionID())
WebCore::NetworkStorageSession::defaultStorageSession().deleteCookie(cookie);
else
m_owningDataStore->removePendingCookie(cookie);
-
callOnMainThread([completionHandler = WTFMove(completionHandler)]() {
completionHandler();
});
Modified: tags/Safari-606.1.21/Source/WebKit/UIProcess/WebProcessPool.cpp (232829 => 232830)
--- tags/Safari-606.1.21/Source/WebKit/UIProcess/WebProcessPool.cpp 2018-06-14 04:56:44 UTC (rev 232829)
+++ tags/Safari-606.1.21/Source/WebKit/UIProcess/WebProcessPool.cpp 2018-06-14 04:56:47 UTC
[webkit-changes] [232829] tags/Safari-606.1.21/Tools/ChangeLog
Title: [232829] tags/Safari-606.1.21/Tools/ChangeLog Revision 232829 Author kocsen_ch...@apple.com Date 2018-06-13 21:56:44 -0700 (Wed, 13 Jun 2018) Log Message Revert r231999. rdar://problem/41113111 Modified Paths tags/Safari-606.1.21/Tools/ChangeLog Diff Modified: tags/Safari-606.1.21/Tools/ChangeLog (232828 => 232829) --- tags/Safari-606.1.21/Tools/ChangeLog 2018-06-14 04:56:42 UTC (rev 232828) +++ tags/Safari-606.1.21/Tools/ChangeLog 2018-06-14 04:56:44 UTC (rev 232829) @@ -2329,20 +2329,6 @@ * MiniBrowser/gtk/BrowserWindow.c: (webViewLoadProgressChanged): Stop any pending reset task when progress != 1. -2018-05-19 Sihui Liu - -Flaky API test WebKit.WKHTTPCookieStoreWithoutProcessPool: incorrect order of cookies -https://bugs.webkit.org/show_bug.cgi?id=185624 - - -Reviewed by Chris Dumez. - -Modified expectation to make test more robust as cookies can be returned in different orders. - -* TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm: -(-[CookieUIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]): -(TEST): - 2018-05-18 Commit Queue Unreviewed, rolling out r231982. ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [232827] trunk/Source/ThirdParty/libwebrtc
Title: [232827] trunk/Source/ThirdParty/libwebrtc
Revision 232827
Author you...@apple.com
Date 2018-06-13 21:14:50 -0700 (Wed, 13 Jun 2018)
Log Message
Eliminate static initializers in libwebrtc.dylib
https://bugs.webkit.org/show_bug.cgi?id=186570
Reviewed by Darin Adler.
* Source/webrtc/rtc_base/flags.h: Changed macro to create the static into a function.
* Source/webrtc/rtc_base/logging.cc: Ditto.
Made sure that the scope is created on instantiation of the first Log instance that might use it.
* Source/webrtc/sdk/objc/Framework/Classes/PeerConnection/RTCVideoCodec.mm:
* Source/webrtc/system_wrappers/source/runtime_enabled_features_default.cc:
Modified Paths
trunk/Source/ThirdParty/libwebrtc/ChangeLog
trunk/Source/ThirdParty/libwebrtc/Source/webrtc/rtc_base/flags.h
trunk/Source/ThirdParty/libwebrtc/Source/webrtc/rtc_base/logging.cc
trunk/Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/Framework/Classes/PeerConnection/RTCVideoCodec.mm
trunk/Source/ThirdParty/libwebrtc/Source/webrtc/system_wrappers/source/runtime_enabled_features_default.cc
Diff
Modified: trunk/Source/ThirdParty/libwebrtc/ChangeLog (232826 => 232827)
--- trunk/Source/ThirdParty/libwebrtc/ChangeLog 2018-06-14 02:51:50 UTC (rev 232826)
+++ trunk/Source/ThirdParty/libwebrtc/ChangeLog 2018-06-14 04:14:50 UTC (rev 232827)
@@ -1,3 +1,16 @@
+2018-06-13 Youenn Fablet
+
+Eliminate static initializers in libwebrtc.dylib
+https://bugs.webkit.org/show_bug.cgi?id=186570
+
+Reviewed by Darin Adler.
+
+* Source/webrtc/rtc_base/flags.h: Changed macro to create the static into a function.
+* Source/webrtc/rtc_base/logging.cc: Ditto.
+Made sure that the scope is created on instantiation of the first Log instance that might use it.
+* Source/webrtc/sdk/objc/Framework/Classes/PeerConnection/RTCVideoCodec.mm:
+* Source/webrtc/system_wrappers/source/runtime_enabled_features_default.cc:
+
2018-06-09 Dan Bernstein
[Xcode] Clean up and modernize some build setting definitions
Modified: trunk/Source/ThirdParty/libwebrtc/Source/webrtc/rtc_base/flags.h (232826 => 232827)
--- trunk/Source/ThirdParty/libwebrtc/Source/webrtc/rtc_base/flags.h 2018-06-14 02:51:50 UTC (rev 232826)
+++ trunk/Source/ThirdParty/libwebrtc/Source/webrtc/rtc_base/flags.h 2018-06-14 04:14:50 UTC (rev 232827)
@@ -151,19 +151,25 @@
// Internal use only.
-#define DEFINE_FLAG(type, c_type, name, default, comment) \
- /* define and initialize the flag */\
- c_type FLAG_##name = (default); \
- /* register the flag */ \
- static rtc::Flag Flag_##name(__FILE__, #name, (comment), \
- rtc::Flag::type, _##name, \
- rtc::FlagValue::New_##type(default))
+#define DEFINE_FLAG(type, c_type, name, default, comment)\
+ static std::pair, std::reference_wrapper> name() { \
+/* define and initialize the flag */ \
+c_type FLAG_##name = (default); \
+/* register the flag */ \
+static rtc::Flag Flag_##name(__FILE__, #name, (comment), \
+ rtc::Flag::type, _##name, \
+ rtc::FlagValue::New_##type(default)); \
+return std::make_pair, std::reference_wrapper>(FLAG_##name, Flag_##name); \
+ } \
+ c_type& FLAG_##name() { \
+return name().first; \
+ }
// Internal use only.
#define DECLARE_FLAG(c_type, name) \
- /* declare the external flag */ \
- extern c_type FLAG_##name
+ /* declare the flag getter */ \
+ c_type& FLAG_##name();
// Use the following macros to define a new flag:
Modified: trunk/Source/ThirdParty/libwebrtc/Source/webrtc/rtc_base/logging.cc (232826 => 232827)
--- trunk/Source/ThirdParty/libwebrtc/Source/webrtc/rtc_base/logging.cc 2018-06-14 02:51:50 UTC (rev 232826)
+++ trunk/Source/ThirdParty/libwebrtc/Source/webrtc/rtc_base/logging.cc 2018-06-14 04:14:50 UTC (rev 232827)
@@ -36,8 +36,10 @@
#include
#include
+#include
#include
#include
+#include
#include "rtc_base/criticalsection.h"
#include "rtc_base/logging.h"
@@ -103,8 +105,14 @@
bool LogMessage::log_to_stderr_ = true;
namespace {
+
// Global lock for log subsystem, only needed to serialize access to streams_.
-CriticalSection g_log_crit;
+CriticalSection& logCriticalScope() {
+ static std::aligned_storage::value>::type g_log_crit_storage;
+ static CriticalSection* g_log_crit = new (_log_crit_storage) CriticalSection;
+ return *g_log_crit;
+}
+
} // namespace
// The list of logging streams currently configured.
@@ -111,7 +119,7 @@
// Note: we explicitly do not clean this up, because of the uncertain ordering
// of destructors at program exit. Let the person who sets the stream trigger
// cleanup by setting to null, or let it leak
[webkit-changes] [232826] branches/safari-606.1.20.40-branch/Source
Title: [232826] branches/safari-606.1.20.40-branch/Source Revision 232826 Author bshaf...@apple.com Date 2018-06-13 19:51:50 -0700 (Wed, 13 Jun 2018) Log Message Versioning. Modified Paths branches/safari-606.1.20.40-branch/Source/_javascript_Core/Configurations/Version.xcconfig branches/safari-606.1.20.40-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig branches/safari-606.1.20.40-branch/Source/WebCore/Configurations/Version.xcconfig branches/safari-606.1.20.40-branch/Source/WebCore/PAL/Configurations/Version.xcconfig branches/safari-606.1.20.40-branch/Source/WebInspectorUI/Configurations/Version.xcconfig branches/safari-606.1.20.40-branch/Source/WebKit/Configurations/Version.xcconfig branches/safari-606.1.20.40-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig Diff Modified: branches/safari-606.1.20.40-branch/Source/_javascript_Core/Configurations/Version.xcconfig (232825 => 232826) --- branches/safari-606.1.20.40-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2018-06-14 02:39:20 UTC (rev 232825) +++ branches/safari-606.1.20.40-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2018-06-14 02:51:50 UTC (rev 232826) @@ -25,7 +25,7 @@ MINOR_VERSION = 1; TINY_VERSION = 20; MICRO_VERSION = 40; -NANO_VERSION = 2; +NANO_VERSION = 3; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-606.1.20.40-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (232825 => 232826) --- branches/safari-606.1.20.40-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig 2018-06-14 02:39:20 UTC (rev 232825) +++ branches/safari-606.1.20.40-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig 2018-06-14 02:51:50 UTC (rev 232826) @@ -25,7 +25,7 @@ MINOR_VERSION = 1; TINY_VERSION = 20; MICRO_VERSION = 40; -NANO_VERSION = 2; +NANO_VERSION = 3; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-606.1.20.40-branch/Source/WebCore/Configurations/Version.xcconfig (232825 => 232826) --- branches/safari-606.1.20.40-branch/Source/WebCore/Configurations/Version.xcconfig 2018-06-14 02:39:20 UTC (rev 232825) +++ branches/safari-606.1.20.40-branch/Source/WebCore/Configurations/Version.xcconfig 2018-06-14 02:51:50 UTC (rev 232826) @@ -25,7 +25,7 @@ MINOR_VERSION = 1; TINY_VERSION = 20; MICRO_VERSION = 40; -NANO_VERSION = 2; +NANO_VERSION = 3; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-606.1.20.40-branch/Source/WebCore/PAL/Configurations/Version.xcconfig (232825 => 232826) --- branches/safari-606.1.20.40-branch/Source/WebCore/PAL/Configurations/Version.xcconfig 2018-06-14 02:39:20 UTC (rev 232825) +++ branches/safari-606.1.20.40-branch/Source/WebCore/PAL/Configurations/Version.xcconfig 2018-06-14 02:51:50 UTC (rev 232826) @@ -25,7 +25,7 @@ MINOR_VERSION = 1; TINY_VERSION = 20; MICRO_VERSION = 40; -NANO_VERSION = 2; +NANO_VERSION = 3; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-606.1.20.40-branch/Source/WebInspectorUI/Configurations/Version.xcconfig (232825 => 232826) --- branches/safari-606.1.20.40-branch/Source/WebInspectorUI/Configurations/Version.xcconfig 2018-06-14 02:39:20 UTC (rev 232825) +++ branches/safari-606.1.20.40-branch/Source/WebInspectorUI/Configurations/Version.xcconfig 2018-06-14 02:51:50 UTC (rev 232826) @@ -2,7 +2,7 @@ MINOR_VERSION = 1; TINY_VERSION = 20; MICRO_VERSION = 40; -NANO_VERSION = 2; +NANO_VERSION = 3; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The system version prefix is based on the current system version. Modified: branches/safari-606.1.20.40-branch/Source/WebKit/Configurations/Version.xcconfig (232825 => 232826) --- branches/safari-606.1.20.40-branch/Source/WebKit/Configurations/Version.xcconfig 2018-06-14 02:39:20 UTC (rev 232825) +++ branches/safari-606.1.20.40-branch/Source/WebKit/Configurations/Version.xcconfig 2018-06-14 02:51:50 UTC (rev 232826) @@ -25,7 +25,7 @@ MINOR_VERSION = 1; TINY_VERSION = 20; MICRO_VERSION = 40; -NANO_VERSION = 2; +NANO_VERSION = 3; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration,
[webkit-changes] [232825] tags/Safari-606.1.20.40.2/
Title: [232825] tags/Safari-606.1.20.40.2/ Revision 232825 Author bshaf...@apple.com Date 2018-06-13 19:39:20 -0700 (Wed, 13 Jun 2018) Log Message Tag Safari-606.1.20.40.2. Added Paths tags/Safari-606.1.20.40.2/ Diff ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [232824] trunk/Source
Title: [232824] trunk/Source Revision 232824 Author cdu...@apple.com Date 2018-06-13 19:31:29 -0700 (Wed, 13 Jun 2018) Log Message Crash under SWServer::unregisterConnection(Connection&) https://bugs.webkit.org/show_bug.cgi?id=186584 Reviewed by Youenn Fablet. Source/WebCore: The crash was due to SWServer::Connection objects outliving their SWServer, even though SWServer::Connection::m_server is a C++ reference. This was possible because SWServer does not own the connections, StorageToWebProcessConnection does. This started crashing recently, after r232423, because SWServer can get destroyed now. The SWServer might get destroyed before the StorageToWebProcessConnection, in which case the SWServer::Connection objects will get destroyed later. We were crashing because the SWServer::Connection destructor tries to unregister the connection from the SWServer (which is dead). To address the issue, the SWServer now owns the connections. StorageToWebProcessConnection merely has weak pointers to the connections. * workers/service/server/SWServer.cpp: (WebCore::SWServer::Connection::Connection): (WebCore::SWServer::addConnection): (WebCore::SWServer::removeConnection): (WebCore::SWServer::resolveRegistrationReadyRequests): * workers/service/server/SWServer.h: (WebCore::SWServer::Connection::~Connection): (WebCore::SWServer::Connection::server): (WebCore::SWServer::connection): * workers/service/server/SWServerRegistration.cpp: (WebCore::SWServerRegistration::forEachConnection): (WebCore::SWServerRegistration::notifyClientsOfControllerChange): (WebCore::SWServerRegistration::controlClient): Source/WebKit: * StorageProcess/ServiceWorker/WebSWServerConnection.cpp: * StorageProcess/ServiceWorker/WebSWServerConnection.h: * StorageProcess/StorageToWebProcessConnection.cpp: (WebKit::StorageToWebProcessConnection::~StorageToWebProcessConnection): (WebKit::StorageToWebProcessConnection::didReceiveMessage): (WebKit::StorageToWebProcessConnection::didReceiveSyncMessage): (WebKit::StorageToWebProcessConnection::didClose): (WebKit::StorageToWebProcessConnection::unregisterSWConnections): (WebKit::StorageToWebProcessConnection::establishSWServerConnection): * StorageProcess/StorageToWebProcessConnection.h: Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/workers/service/server/SWServer.cpp trunk/Source/WebCore/workers/service/server/SWServer.h trunk/Source/WebCore/workers/service/server/SWServerRegistration.cpp trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/StorageProcess/ServiceWorker/WebSWServerConnection.cpp trunk/Source/WebKit/StorageProcess/ServiceWorker/WebSWServerConnection.h trunk/Source/WebKit/StorageProcess/StorageToWebProcessConnection.cpp trunk/Source/WebKit/StorageProcess/StorageToWebProcessConnection.h Diff Modified: trunk/Source/WebCore/ChangeLog (232823 => 232824) --- trunk/Source/WebCore/ChangeLog 2018-06-14 01:36:24 UTC (rev 232823) +++ trunk/Source/WebCore/ChangeLog 2018-06-14 02:31:29 UTC (rev 232824) @@ -1,3 +1,37 @@ +2018-06-13 Chris Dumez + +Crash under SWServer::unregisterConnection(Connection&) +https://bugs.webkit.org/show_bug.cgi?id=186584 + + +Reviewed by Youenn Fablet. + +The crash was due to SWServer::Connection objects outliving their SWServer, even +though SWServer::Connection::m_server is a C++ reference. This was possible because +SWServer does not own the connections, StorageToWebProcessConnection does. This +started crashing recently, after r232423, because SWServer can get destroyed now. +The SWServer might get destroyed before the StorageToWebProcessConnection, in which +case the SWServer::Connection objects will get destroyed later. We were crashing +because the SWServer::Connection destructor tries to unregister the connection from +the SWServer (which is dead). + +To address the issue, the SWServer now owns the connections. StorageToWebProcessConnection +merely has weak pointers to the connections. + +* workers/service/server/SWServer.cpp: +(WebCore::SWServer::Connection::Connection): +(WebCore::SWServer::addConnection): +(WebCore::SWServer::removeConnection): +(WebCore::SWServer::resolveRegistrationReadyRequests): +* workers/service/server/SWServer.h: +(WebCore::SWServer::Connection::~Connection): +(WebCore::SWServer::Connection::server): +(WebCore::SWServer::connection): +* workers/service/server/SWServerRegistration.cpp: +(WebCore::SWServerRegistration::forEachConnection): +(WebCore::SWServerRegistration::notifyClientsOfControllerChange): +(WebCore::SWServerRegistration::controlClient): + 2018-06-13 Zalan Bujtas [Mail] Use the Mail Viewer width as the base for resolving horizontal viewport units Modified: trunk/Source/WebCore/workers/service/server/SWServer.cpp (232823 => 232824) ---
[webkit-changes] [232823] trunk
Title: [232823] trunk
Revision 232823
Author za...@apple.com
Date 2018-06-13 18:36:24 -0700 (Wed, 13 Jun 2018)
Log Message
[Mail] Use the Mail Viewer width as the base for resolving horizontal viewport units
https://bugs.webkit.org/show_bug.cgi?id=186585
Reviewed by Tim Horton.
Source/WebCore:
Use the existing "override viewport size for viewport units" mechanism to compute the preferred
viewport unit values for the Mail Viewer html content.
Test: fast/dynamic/mail-autosize-viewport-unit.html
* page/FrameView.cpp:
(WebCore::FrameView::FrameView):
(WebCore::FrameView::enableAutoSizeMode):
(WebCore::FrameView::clearViewportSizeOverrideForCSSViewportUnits):
(WebCore::FrameView::setViewportSizeForCSSViewportUnits):
(WebCore::FrameView::overrideViewportSizeForCSSViewportUnits):
(WebCore::FrameView::viewportSizeForCSSViewportUnits const):
* page/FrameView.h:
LayoutTests:
* fast/dynamic/mail-autosize-viewport-unit-expected.txt: Added.
* fast/dynamic/mail-autosize-viewport-unit.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/ios/TestExpectations
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/FrameView.cpp
trunk/Source/WebCore/page/FrameView.h
trunk/Tools/DumpRenderTree/mac/DumpRenderTree.mm
Added Paths
trunk/LayoutTests/fast/dynamic/mail-autosize-viewport-unit-expected.txt
trunk/LayoutTests/fast/dynamic/mail-autosize-viewport-unit.html
Diff
Modified: trunk/LayoutTests/ChangeLog (232822 => 232823)
--- trunk/LayoutTests/ChangeLog 2018-06-14 01:23:26 UTC (rev 232822)
+++ trunk/LayoutTests/ChangeLog 2018-06-14 01:36:24 UTC (rev 232823)
@@ -1,3 +1,14 @@
+2018-06-13 Zalan Bujtas
+
+[Mail] Use the Mail Viewer width as the base for resolving horizontal viewport units
+https://bugs.webkit.org/show_bug.cgi?id=186585
+
+
+Reviewed by Tim Horton.
+
+* fast/dynamic/mail-autosize-viewport-unit-expected.txt: Added.
+* fast/dynamic/mail-autosize-viewport-unit.html: Added.
+
2018-06-13 Chris Dumez
PSON: http/tests/resourceLoadStatistics/classify-as-prevalent-based-on-top-frame-redirect-collusion.html ASSERTS with process swap enabled
Added: trunk/LayoutTests/fast/dynamic/mail-autosize-viewport-unit-expected.txt (0 => 232823)
--- trunk/LayoutTests/fast/dynamic/mail-autosize-viewport-unit-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/dynamic/mail-autosize-viewport-unit-expected.txt 2018-06-14 01:36:24 UTC (rev 232823)
@@ -0,0 +1,2 @@
+
+2000px 1000px 200px 0px
Added: trunk/LayoutTests/fast/dynamic/mail-autosize-viewport-unit.html (0 => 232823)
--- trunk/LayoutTests/fast/dynamic/mail-autosize-viewport-unit.html (rev 0)
+++ trunk/LayoutTests/fast/dynamic/mail-autosize-viewport-unit.html 2018-06-14 01:36:24 UTC (rev 232823)
@@ -0,0 +1,49 @@
+
+
+
+This tests that autosize uses the min-width as the base for resolving viewport unit values
+
+#w100 {
+width: 100vw;
+height: 10px;
+}
+
+#w50 {
+width: 50vw;
+height: 10px;
+}
+
+#w10 {
+width: 10vw;
+height: 10px;
+}
+
+#w0 {
+width: 0vw;
+height: 10px;
+}
+
+
+if (window.internals)
+internals.enableAutoSizeMode(true, 2000, 600, 4000, 1000);
+
+if (window.testRunner)
+testRunner.dumpAsText();
+
+
+
+
+
+
+
+
+
+
+document.body.offsetWidth;
+result.textContent = window.getComputedStyle(w100, null).getPropertyValue("width") + " "
++ window.getComputedStyle(w50, null).getPropertyValue("width") + " "
++ window.getComputedStyle(w10, null).getPropertyValue("width") + " "
+ + window.getComputedStyle(w0, null).getPropertyValue("width");
+
+
+
Modified: trunk/LayoutTests/platform/ios/TestExpectations (232822 => 232823)
--- trunk/LayoutTests/platform/ios/TestExpectations 2018-06-14 01:23:26 UTC (rev 232822)
+++ trunk/LayoutTests/platform/ios/TestExpectations 2018-06-14 01:36:24 UTC (rev 232823)
@@ -3305,3 +3305,6 @@
webkit.org/b/183258 imported/w3c/web-platform-tests/css/css-text/i18n/css3-text-line-break-opclns-115.html [ ImageOnlyFailure ]
webkit.org/b/183258 imported/w3c/web-platform-tests/css/css-text/i18n/css3-text-line-break-opclns-116.html [ ImageOnlyFailure ]
webkit.org/b/183258 imported/w3c/web-platform-tests/css/css-text/word-break/word-break-break-all-006.html [ ImageOnlyFailure ]
+
+# unsupported
+fast/dynamic/mail-autosize-viewport-unit.html [ Failure ]
Modified: trunk/Source/WebCore/ChangeLog (232822 => 232823)
--- trunk/Source/WebCore/ChangeLog 2018-06-14 01:23:26 UTC (rev 232822)
+++ trunk/Source/WebCore/ChangeLog 2018-06-14 01:36:24 UTC (rev 232823)
@@ -1,3 +1,25 @@
+2018-06-13 Zalan Bujtas
+
+[Mail] Use the Mail Viewer width as the base for resolving horizontal viewport units
+https://bugs.webkit.org/show_bug.cgi?id=186585
+
+
+Reviewed by Tim Horton.
+
+Use the existing "override viewport size for viewport units" mechanism to compute the preferred
+viewport unit values for the
[webkit-changes] [232822] branches/safari-606.1.20.40-branch
Title: [232822] branches/safari-606.1.20.40-branch
Revision 232822
Author kocsen_ch...@apple.com
Date 2018-06-13 18:23:26 -0700 (Wed, 13 Jun 2018)
Log Message
Revert r231850. rdar://problem/39111626
Modified Paths
branches/safari-606.1.20.40-branch/Source/WebKit/ChangeLog
branches/safari-606.1.20.40-branch/Source/WebKit/NetworkProcess/mac/RemoteNetworkingContext.mm
branches/safari-606.1.20.40-branch/Source/WebKit/UIProcess/API/APIHTTPCookieStore.cpp
branches/safari-606.1.20.40-branch/Source/WebKit/UIProcess/WebProcessPool.cpp
branches/safari-606.1.20.40-branch/Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.cpp
branches/safari-606.1.20.40-branch/Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.h
branches/safari-606.1.20.40-branch/Tools/ChangeLog
branches/safari-606.1.20.40-branch/Tools/TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm
Diff
Modified: branches/safari-606.1.20.40-branch/Source/WebKit/ChangeLog (232821 => 232822)
--- branches/safari-606.1.20.40-branch/Source/WebKit/ChangeLog 2018-06-14 01:23:23 UTC (rev 232821)
+++ branches/safari-606.1.20.40-branch/Source/WebKit/ChangeLog 2018-06-14 01:23:26 UTC (rev 232822)
@@ -1,3 +1,7 @@
+2018-06-13 Kocsen Chung
+
+Revert r231850. rdar://problem/39111626
+
2018-06-08 Kocsen Chung
Cherry-pick r232585. rdar://problem/39117121
Modified: branches/safari-606.1.20.40-branch/Source/WebKit/NetworkProcess/mac/RemoteNetworkingContext.mm (232821 => 232822)
--- branches/safari-606.1.20.40-branch/Source/WebKit/NetworkProcess/mac/RemoteNetworkingContext.mm 2018-06-14 01:23:23 UTC (rev 232821)
+++ branches/safari-606.1.20.40-branch/Source/WebKit/NetworkProcess/mac/RemoteNetworkingContext.mm 2018-06-14 01:23:26 UTC (rev 232822)
@@ -36,7 +36,6 @@
#import "WebsiteDataStoreParameters.h"
#import
#import
-#import
#import
using namespace WebCore;
@@ -46,12 +45,8 @@
void RemoteNetworkingContext::ensureWebsiteDataStoreSession(WebsiteDataStoreParameters&& parameters)
{
auto sessionID = parameters.networkSessionParameters.sessionID;
-if (auto* session = NetworkStorageSession::storageSession(sessionID)) {
-ASSERT(parameters.pendingCookies.isEmpty() || sessionID == PAL::SessionID::defaultSessionID());
-for (const auto& cookie : parameters.pendingCookies)
-session->setCookie(cookie);
+if (NetworkStorageSession::storageSession(sessionID))
return;
-}
String base;
if (SessionTracker::getIdentifierBase().isNull())
Modified: branches/safari-606.1.20.40-branch/Source/WebKit/UIProcess/API/APIHTTPCookieStore.cpp (232821 => 232822)
--- branches/safari-606.1.20.40-branch/Source/WebKit/UIProcess/API/APIHTTPCookieStore.cpp 2018-06-14 01:23:23 UTC (rev 232821)
+++ branches/safari-606.1.20.40-branch/Source/WebKit/UIProcess/API/APIHTTPCookieStore.cpp 2018-06-14 01:23:26 UTC (rev 232822)
@@ -54,7 +54,7 @@
unregisterForNewProcessPoolNotifications();
}
-void HTTPCookieStore::cookies(Function&)>&& completionHandler)
+void HTTPCookieStore::cookies(Function&)>&& completionHandler)
{
auto* pool = m_owningDataStore->processPoolForCookieStorageOperations();
if (!pool) {
@@ -61,7 +61,8 @@
Vector allCookies;
if (m_owningDataStore->sessionID() == PAL::SessionID::defaultSessionID())
allCookies = WebCore::NetworkStorageSession::defaultStorageSession().getAllCookies();
-allCookies.appendVector(m_owningDataStore->pendingCookies());
+else
+allCookies = m_owningDataStore->pendingCookies();
callOnMainThread([completionHandler = WTFMove(completionHandler), allCookies]() {
completionHandler(allCookies);
@@ -79,8 +80,7 @@
{
auto* pool = m_owningDataStore->processPoolForCookieStorageOperations();
if (!pool) {
-// FIXME: pendingCookies used for defaultSession because session cookies cannot be propagated to Network Process with uiProcessCookieStorageIdentifier.
-if (m_owningDataStore->sessionID() == PAL::SessionID::defaultSessionID() && !cookie.session)
+if (m_owningDataStore->sessionID() == PAL::SessionID::defaultSessionID())
WebCore::NetworkStorageSession::defaultStorageSession().setCookie(cookie);
else
m_owningDataStore->addPendingCookie(cookie);
@@ -101,11 +101,10 @@
{
auto* pool = m_owningDataStore->processPoolForCookieStorageOperations();
if (!pool) {
-if (m_owningDataStore->sessionID() == PAL::SessionID::defaultSessionID() && !cookie.session)
+if (m_owningDataStore->sessionID() == PAL::SessionID::defaultSessionID())
WebCore::NetworkStorageSession::defaultStorageSession().deleteCookie(cookie);
else
m_owningDataStore->removePendingCookie(cookie);
-
callOnMainThread([completionHandler = WTFMove(completionHandler)]() {
completionHandler();
});
Modified:
[webkit-changes] [232821] branches/safari-606.1.20.40-branch/Tools/ChangeLog
Title: [232821] branches/safari-606.1.20.40-branch/Tools/ChangeLog Revision 232821 Author kocsen_ch...@apple.com Date 2018-06-13 18:23:23 -0700 (Wed, 13 Jun 2018) Log Message Revert r231999. rdar://problem/39111626 Modified Paths branches/safari-606.1.20.40-branch/Tools/ChangeLog Diff Modified: branches/safari-606.1.20.40-branch/Tools/ChangeLog (232820 => 232821) --- branches/safari-606.1.20.40-branch/Tools/ChangeLog 2018-06-14 01:04:46 UTC (rev 232820) +++ branches/safari-606.1.20.40-branch/Tools/ChangeLog 2018-06-14 01:23:23 UTC (rev 232821) @@ -1584,20 +1584,6 @@ * MiniBrowser/gtk/BrowserWindow.c: (webViewLoadProgressChanged): Stop any pending reset task when progress != 1. -2018-05-19 Sihui Liu - -Flaky API test WebKit.WKHTTPCookieStoreWithoutProcessPool: incorrect order of cookies -https://bugs.webkit.org/show_bug.cgi?id=185624 - - -Reviewed by Chris Dumez. - -Modified expectation to make test more robust as cookies can be returned in different orders. - -* TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm: -(-[CookieUIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]): -(TEST): - 2018-05-18 Commit Queue Unreviewed, rolling out r231982. ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [232820] trunk/Tools
Title: [232820] trunk/Tools
Revision 232820
Author clo...@igalia.com
Date 2018-06-13 18:04:46 -0700 (Wed, 13 Jun 2018)
Log Message
[GTK] Add a script to upload the data generated with run-benchmark to a browserperfdash server and use it on the gtk perf bot
https://bugs.webkit.org/show_bug.cgi?id=166885
Reviewed by Michael Catanzaro.
This patch adds a new script that will execute run-benchmark and upload the results it generates to a browserperfdash web app.
It also modifies the buildbot config file so the GTK performance bot runs this script on the perf-test step.
* BuildSlaveSupport/build.webkit.org-config/steps.py:
(RunBenchmarkTests):
* Scripts/browserperfdash-benchmark: Added.
* Scripts/webkitpy/browserperfdash/README: Added.
* Scripts/webkitpy/browserperfdash/__init__.py: Added.
* Scripts/webkitpy/browserperfdash/browserperfdash_runner.py: Added.
(parse_args):
(BrowserPerfDashRunner):
(BrowserPerfDashRunner.__init__):
(BrowserPerfDashRunner._parse_config_file):
(BrowserPerfDashRunner._get_test_version_string):
(BrowserPerfDashRunner._get_test_data_json_string):
(BrowserPerfDashRunner._upload_result):
(BrowserPerfDashRunner.run):
(format_logger):
(main):
* Scripts/webkitpy/browserperfdash/browserperfdash_unittest.py: Added.
(FakeBenchmarkRunner):
(FakeBenchmarkRunner.__init__):
(FakeBenchmarkRunner.execute):
(BrowserPerfDashRunnerTest):
(BrowserPerfDashRunnerTest.test_list_plans_at_least_five):
(BrowserPerfDashRunnerTest.test_benchmark_runner_subclasses_at_least_two):
(BrowserPerfDashRunnerTest.test_can_construct_runner_object_minimum_parameters):
* Scripts/webkitpy/browserperfdash/config-file-example.txt: Added.
Modified Paths
trunk/Tools/BuildSlaveSupport/build.webkit.org-config/steps.py
trunk/Tools/ChangeLog
Added Paths
trunk/Tools/Scripts/browserperfdash-benchmark
trunk/Tools/Scripts/webkitpy/browserperfdash/
trunk/Tools/Scripts/webkitpy/browserperfdash/README
trunk/Tools/Scripts/webkitpy/browserperfdash/__init__.py
trunk/Tools/Scripts/webkitpy/browserperfdash/browserperfdash_runner.py
trunk/Tools/Scripts/webkitpy/browserperfdash/browserperfdash_unittest.py
trunk/Tools/Scripts/webkitpy/browserperfdash/config-file-example.txt
Diff
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/steps.py (232819 => 232820)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/steps.py 2018-06-13 23:46:06 UTC (rev 232819)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/steps.py 2018-06-14 01:04:46 UTC (rev 232820)
@@ -829,7 +829,9 @@
# The current maximum timeout for a benchmark plan is also 1200.
# So raise the buildbot timeout to avoid aborting this whole step when a test timeouts.
timeout = 1500
-command = ["python", "./Tools/Scripts/run-benchmark", "--allplans"]
+command = ["python", "./Tools/Scripts/browserperfdash-benchmark", "--allplans",
+ "--config-file", "../../browserperfdash-benchmark-config.txt",
+ "--browser-version", WithProperties("r%(got_revision)s")]
def start(self):
platform = self.getProperty("platform")
Modified: trunk/Tools/ChangeLog (232819 => 232820)
--- trunk/Tools/ChangeLog 2018-06-13 23:46:06 UTC (rev 232819)
+++ trunk/Tools/ChangeLog 2018-06-14 01:04:46 UTC (rev 232820)
@@ -1,3 +1,40 @@
+2018-06-11 Carlos Alberto Lopez Perez
+
+[GTK] Add a script to upload the data generated with run-benchmark to a browserperfdash server and use it on the gtk perf bot
+https://bugs.webkit.org/show_bug.cgi?id=166885
+
+Reviewed by Michael Catanzaro.
+
+This patch adds a new script that will execute run-benchmark and upload the results it generates to a browserperfdash web app.
+
+It also modifies the buildbot config file so the GTK performance bot runs this script on the perf-test step.
+
+* BuildSlaveSupport/build.webkit.org-config/steps.py:
+(RunBenchmarkTests):
+* Scripts/browserperfdash-benchmark: Added.
+* Scripts/webkitpy/browserperfdash/README: Added.
+* Scripts/webkitpy/browserperfdash/__init__.py: Added.
+* Scripts/webkitpy/browserperfdash/browserperfdash_runner.py: Added.
+(parse_args):
+(BrowserPerfDashRunner):
+(BrowserPerfDashRunner.__init__):
+(BrowserPerfDashRunner._parse_config_file):
+(BrowserPerfDashRunner._get_test_version_string):
+(BrowserPerfDashRunner._get_test_data_json_string):
+(BrowserPerfDashRunner._upload_result):
+(BrowserPerfDashRunner.run):
+(format_logger):
+(main):
+* Scripts/webkitpy/browserperfdash/browserperfdash_unittest.py: Added.
+(FakeBenchmarkRunner):
+(FakeBenchmarkRunner.__init__):
+(FakeBenchmarkRunner.execute):
+(BrowserPerfDashRunnerTest):
+(BrowserPerfDashRunnerTest.test_list_plans_at_least_five):
+(BrowserPerfDashRunnerTest.test_benchmark_runner_subclasses_at_least_two):
+
[webkit-changes] [232818] branches/safari-606.1.20.20-branch/Tools/ChangeLog
Title: [232818] branches/safari-606.1.20.20-branch/Tools/ChangeLog Revision 232818 Author kocsen_ch...@apple.com Date 2018-06-13 16:46:02 -0700 (Wed, 13 Jun 2018) Log Message Revert r231999. rdar://problem/39111626 Modified Paths branches/safari-606.1.20.20-branch/Tools/ChangeLog Diff Modified: branches/safari-606.1.20.20-branch/Tools/ChangeLog (232817 => 232818) --- branches/safari-606.1.20.20-branch/Tools/ChangeLog 2018-06-13 23:20:49 UTC (rev 232817) +++ branches/safari-606.1.20.20-branch/Tools/ChangeLog 2018-06-13 23:46:02 UTC (rev 232818) @@ -1584,20 +1584,6 @@ * MiniBrowser/gtk/BrowserWindow.c: (webViewLoadProgressChanged): Stop any pending reset task when progress != 1. -2018-05-19 Sihui Liu - -Flaky API test WebKit.WKHTTPCookieStoreWithoutProcessPool: incorrect order of cookies -https://bugs.webkit.org/show_bug.cgi?id=185624 - - -Reviewed by Chris Dumez. - -Modified expectation to make test more robust as cookies can be returned in different orders. - -* TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm: -(-[CookieUIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]): -(TEST): - 2018-05-18 Commit Queue Unreviewed, rolling out r231982. ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [232819] branches/safari-606.1.20.20-branch
Title: [232819] branches/safari-606.1.20.20-branch
Revision 232819
Author kocsen_ch...@apple.com
Date 2018-06-13 16:46:06 -0700 (Wed, 13 Jun 2018)
Log Message
Revert r231850. rdar://problem/39111626
Modified Paths
branches/safari-606.1.20.20-branch/Source/WebKit/ChangeLog
branches/safari-606.1.20.20-branch/Source/WebKit/NetworkProcess/mac/RemoteNetworkingContext.mm
branches/safari-606.1.20.20-branch/Source/WebKit/UIProcess/API/APIHTTPCookieStore.cpp
branches/safari-606.1.20.20-branch/Source/WebKit/UIProcess/WebProcessPool.cpp
branches/safari-606.1.20.20-branch/Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.cpp
branches/safari-606.1.20.20-branch/Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.h
branches/safari-606.1.20.20-branch/Tools/ChangeLog
branches/safari-606.1.20.20-branch/Tools/TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm
Diff
Modified: branches/safari-606.1.20.20-branch/Source/WebKit/ChangeLog (232818 => 232819)
--- branches/safari-606.1.20.20-branch/Source/WebKit/ChangeLog 2018-06-13 23:46:02 UTC (rev 232818)
+++ branches/safari-606.1.20.20-branch/Source/WebKit/ChangeLog 2018-06-13 23:46:06 UTC (rev 232819)
@@ -1,3 +1,7 @@
+2018-06-13 Kocsen Chung
+
+Revert r231850. rdar://problem/39111626
+
2018-06-08 Kocsen Chung
Cherry-pick r232585. rdar://problem/39117121
Modified: branches/safari-606.1.20.20-branch/Source/WebKit/NetworkProcess/mac/RemoteNetworkingContext.mm (232818 => 232819)
--- branches/safari-606.1.20.20-branch/Source/WebKit/NetworkProcess/mac/RemoteNetworkingContext.mm 2018-06-13 23:46:02 UTC (rev 232818)
+++ branches/safari-606.1.20.20-branch/Source/WebKit/NetworkProcess/mac/RemoteNetworkingContext.mm 2018-06-13 23:46:06 UTC (rev 232819)
@@ -36,7 +36,6 @@
#import "WebsiteDataStoreParameters.h"
#import
#import
-#import
#import
using namespace WebCore;
@@ -46,12 +45,8 @@
void RemoteNetworkingContext::ensureWebsiteDataStoreSession(WebsiteDataStoreParameters&& parameters)
{
auto sessionID = parameters.networkSessionParameters.sessionID;
-if (auto* session = NetworkStorageSession::storageSession(sessionID)) {
-ASSERT(parameters.pendingCookies.isEmpty() || sessionID == PAL::SessionID::defaultSessionID());
-for (const auto& cookie : parameters.pendingCookies)
-session->setCookie(cookie);
+if (NetworkStorageSession::storageSession(sessionID))
return;
-}
String base;
if (SessionTracker::getIdentifierBase().isNull())
Modified: branches/safari-606.1.20.20-branch/Source/WebKit/UIProcess/API/APIHTTPCookieStore.cpp (232818 => 232819)
--- branches/safari-606.1.20.20-branch/Source/WebKit/UIProcess/API/APIHTTPCookieStore.cpp 2018-06-13 23:46:02 UTC (rev 232818)
+++ branches/safari-606.1.20.20-branch/Source/WebKit/UIProcess/API/APIHTTPCookieStore.cpp 2018-06-13 23:46:06 UTC (rev 232819)
@@ -54,7 +54,7 @@
unregisterForNewProcessPoolNotifications();
}
-void HTTPCookieStore::cookies(Function&)>&& completionHandler)
+void HTTPCookieStore::cookies(Function&)>&& completionHandler)
{
auto* pool = m_owningDataStore->processPoolForCookieStorageOperations();
if (!pool) {
@@ -61,7 +61,8 @@
Vector allCookies;
if (m_owningDataStore->sessionID() == PAL::SessionID::defaultSessionID())
allCookies = WebCore::NetworkStorageSession::defaultStorageSession().getAllCookies();
-allCookies.appendVector(m_owningDataStore->pendingCookies());
+else
+allCookies = m_owningDataStore->pendingCookies();
callOnMainThread([completionHandler = WTFMove(completionHandler), allCookies]() {
completionHandler(allCookies);
@@ -79,8 +80,7 @@
{
auto* pool = m_owningDataStore->processPoolForCookieStorageOperations();
if (!pool) {
-// FIXME: pendingCookies used for defaultSession because session cookies cannot be propagated to Network Process with uiProcessCookieStorageIdentifier.
-if (m_owningDataStore->sessionID() == PAL::SessionID::defaultSessionID() && !cookie.session)
+if (m_owningDataStore->sessionID() == PAL::SessionID::defaultSessionID())
WebCore::NetworkStorageSession::defaultStorageSession().setCookie(cookie);
else
m_owningDataStore->addPendingCookie(cookie);
@@ -101,11 +101,10 @@
{
auto* pool = m_owningDataStore->processPoolForCookieStorageOperations();
if (!pool) {
-if (m_owningDataStore->sessionID() == PAL::SessionID::defaultSessionID() && !cookie.session)
+if (m_owningDataStore->sessionID() == PAL::SessionID::defaultSessionID())
WebCore::NetworkStorageSession::defaultStorageSession().deleteCookie(cookie);
else
m_owningDataStore->removePendingCookie(cookie);
-
callOnMainThread([completionHandler = WTFMove(completionHandler)]() {
completionHandler();
});
Modified:
[webkit-changes] [232817] trunk
Title: [232817] trunk
Revision 232817
Author d...@apple.com
Date 2018-06-13 16:20:49 -0700 (Wed, 13 Jun 2018)
Log Message
Disable AR support in WKWebView clients
https://bugs.webkit.org/show_bug.cgi?id=186611
Reviewed by Jon Lee.
Since it hasn't been adequately tested, System Preview (AR) should
be disabled by default for WKWebViews.
Source/WebCore:
Add a new RuntimeEnabledFeature to control this, and guard for
this case everywhere we use system previews.
* html/HTMLAnchorElement.cpp:
(WebCore::HTMLAnchorElement::isSystemPreviewLink const):
(WebCore::HTMLAnchorElement::handleClick):
* html/HTMLImageElement.cpp:
(WebCore::HTMLImageElement::isSystemPreviewImage const):
* html/HTMLPictureElement.cpp:
(WebCore::HTMLPictureElement::isSystemPreviewImage const):
* page/RuntimeEnabledFeatures.h:
(WebCore::RuntimeEnabledFeatures::setSystemPreviewEnabled):
(WebCore::RuntimeEnabledFeatures::systemPreviewEnabled const):
* rendering/RenderImage.cpp:
(WebCore::RenderImage::paintIntoRect):
Source/WebKit:
Add a new WebPreference, and SPI into WKWebViewConfiguration. Also
don't register the WebViewContentProvider if the feature is
disabled.
* Shared/WebPreferences.yaml:
* UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _initializeWithConfiguration:]):
* UIProcess/API/Cocoa/WKWebViewConfiguration.mm:
(-[WKWebViewConfiguration init]):
(-[WKWebViewConfiguration encodeWithCoder:]):
(-[WKWebViewConfiguration initWithCoder:]):
(-[WKWebViewConfiguration copyWithZone:]):
(-[WKWebViewConfiguration _contentProviderRegistry]):
(-[WKWebViewConfiguration _systemPreviewEnabled]):
(-[WKWebViewConfiguration _setSystemPreviewEnabled:]):
* UIProcess/API/Cocoa/WKWebViewConfigurationPrivate.h:
* UIProcess/Cocoa/WKWebViewContentProviderRegistry.h:
* UIProcess/Cocoa/WKWebViewContentProviderRegistry.mm:
(-[WKWebViewContentProviderRegistry initWithConfiguration:]):
(-[WKWebViewContentProviderRegistry init]): Deleted.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/HTMLAnchorElement.cpp
trunk/Source/WebCore/html/HTMLImageElement.cpp
trunk/Source/WebCore/html/HTMLPictureElement.cpp
trunk/Source/WebCore/page/RuntimeEnabledFeatures.h
trunk/Source/WebCore/rendering/RenderImage.cpp
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Shared/WebPreferences.yaml
trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm
trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebViewConfiguration.mm
trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebViewConfigurationPrivate.h
trunk/Source/WebKit/UIProcess/Cocoa/WKWebViewContentProviderRegistry.h
trunk/Source/WebKit/UIProcess/Cocoa/WKWebViewContentProviderRegistry.mm
trunk/Tools/WebKitTestRunner/cocoa/TestControllerCocoa.mm
Diff
Modified: trunk/Source/WebCore/ChangeLog (232816 => 232817)
--- trunk/Source/WebCore/ChangeLog 2018-06-13 22:51:29 UTC (rev 232816)
+++ trunk/Source/WebCore/ChangeLog 2018-06-13 23:20:49 UTC (rev 232817)
@@ -1,3 +1,30 @@
+2018-06-13 Dean Jackson
+
+Disable AR support in WKWebView clients
+https://bugs.webkit.org/show_bug.cgi?id=186611
+
+
+Reviewed by Jon Lee.
+
+Since it hasn't been adequately tested, System Preview (AR) should
+be disabled by default for WKWebViews.
+
+Add a new RuntimeEnabledFeature to control this, and guard for
+this case everywhere we use system previews.
+
+* html/HTMLAnchorElement.cpp:
+(WebCore::HTMLAnchorElement::isSystemPreviewLink const):
+(WebCore::HTMLAnchorElement::handleClick):
+* html/HTMLImageElement.cpp:
+(WebCore::HTMLImageElement::isSystemPreviewImage const):
+* html/HTMLPictureElement.cpp:
+(WebCore::HTMLPictureElement::isSystemPreviewImage const):
+* page/RuntimeEnabledFeatures.h:
+(WebCore::RuntimeEnabledFeatures::setSystemPreviewEnabled):
+(WebCore::RuntimeEnabledFeatures::systemPreviewEnabled const):
+* rendering/RenderImage.cpp:
+(WebCore::RenderImage::paintIntoRect):
+
2018-06-13 Youenn Fablet
Supported plugin check should be based on plugin identifier
Modified: trunk/Source/WebCore/html/HTMLAnchorElement.cpp (232816 => 232817)
--- trunk/Source/WebCore/html/HTMLAnchorElement.cpp 2018-06-13 22:51:29 UTC (rev 232816)
+++ trunk/Source/WebCore/html/HTMLAnchorElement.cpp 2018-06-13 23:20:49 UTC (rev 232817)
@@ -380,6 +380,9 @@
#if USE(SYSTEM_PREVIEW)
bool HTMLAnchorElement::isSystemPreviewLink() const
{
+if (!RuntimeEnabledFeatures::sharedFeatures().systemPreviewEnabled())
+return false;
+
#if USE(APPLE_INTERNAL_SDK)
auto systemPreviewRelValue = getSystemPreviewRelValue();
#else
@@ -428,7 +431,7 @@
SystemPreviewInfo systemPreviewInfo;
#if USE(SYSTEM_PREVIEW)
-systemPreviewInfo.isSystemPreview = isSystemPreviewLink();
+systemPreviewInfo.isSystemPreview = isSystemPreviewLink() && RuntimeEnabledFeatures::sharedFeatures().systemPreviewEnabled();
if (systemPreviewInfo.isSystemPreview) {
if
[webkit-changes] [232816] trunk/Source/JavaScriptCore
Title: [232816] trunk/Source/_javascript_Core
Revision 232816
Author ca...@igalia.com
Date 2018-06-13 15:51:29 -0700 (Wed, 13 Jun 2018)
Log Message
[LLInt] use loadp consistently for get_from_scope/put_to_scope
https://bugs.webkit.org/show_bug.cgi?id=132333
Reviewed by Mark Lam.
Using `loadis` for register indexes and `loadp` for constant scopes /
symboltables makes sense, but is problematic for big-endian
architectures.
Consistently treating the operand as a pointer simplifies determining
how to access the operand, and helps avoid bad accesses and crashes on
big-endian ports.
* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::finishCreation):
* bytecode/Instruction.h:
* jit/JITOperations.cpp:
* llint/LLIntSlowPaths.cpp:
(JSC::LLInt::LLINT_SLOW_PATH_DECL):
* llint/LowLevelInterpreter32_64.asm:
* llint/LowLevelInterpreter64.asm:
* runtime/CommonSlowPaths.h:
(JSC::CommonSlowPaths::tryCachePutToScopeGlobal):
(JSC::CommonSlowPaths::tryCacheGetFromScopeGlobal):
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/bytecode/CodeBlock.cpp
trunk/Source/_javascript_Core/bytecode/Instruction.h
trunk/Source/_javascript_Core/jit/JITOperations.cpp
trunk/Source/_javascript_Core/llint/LLIntSlowPaths.cpp
trunk/Source/_javascript_Core/llint/LowLevelInterpreter32_64.asm
trunk/Source/_javascript_Core/llint/LowLevelInterpreter64.asm
trunk/Source/_javascript_Core/runtime/CommonSlowPaths.h
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (232815 => 232816)
--- trunk/Source/_javascript_Core/ChangeLog 2018-06-13 22:22:07 UTC (rev 232815)
+++ trunk/Source/_javascript_Core/ChangeLog 2018-06-13 22:51:29 UTC (rev 232816)
@@ -1,3 +1,30 @@
+2018-06-13 Caitlin Potter
+
+[LLInt] use loadp consistently for get_from_scope/put_to_scope
+https://bugs.webkit.org/show_bug.cgi?id=132333
+
+Reviewed by Mark Lam.
+
+Using `loadis` for register indexes and `loadp` for constant scopes /
+symboltables makes sense, but is problematic for big-endian
+architectures.
+
+Consistently treating the operand as a pointer simplifies determining
+how to access the operand, and helps avoid bad accesses and crashes on
+big-endian ports.
+
+* bytecode/CodeBlock.cpp:
+(JSC::CodeBlock::finishCreation):
+* bytecode/Instruction.h:
+* jit/JITOperations.cpp:
+* llint/LLIntSlowPaths.cpp:
+(JSC::LLInt::LLINT_SLOW_PATH_DECL):
+* llint/LowLevelInterpreter32_64.asm:
+* llint/LowLevelInterpreter64.asm:
+* runtime/CommonSlowPaths.h:
+(JSC::CommonSlowPaths::tryCachePutToScopeGlobal):
+(JSC::CommonSlowPaths::tryCacheGetFromScopeGlobal):
+
2018-06-13 Keith Miller
AutomaticThread should have a way to provide a thread name
Modified: trunk/Source/_javascript_Core/bytecode/CodeBlock.cpp (232815 => 232816)
--- trunk/Source/_javascript_Core/bytecode/CodeBlock.cpp 2018-06-13 22:22:07 UTC (rev 232815)
+++ trunk/Source/_javascript_Core/bytecode/CodeBlock.cpp 2018-06-13 22:51:29 UTC (rev 232816)
@@ -694,7 +694,7 @@
instructions[i + 5].u.watchpointSet = op.watchpointSet;
else if (op.structure)
instructions[i + 5].u.structure.set(vm, this, op.structure);
-instructions[i + 6].u.pointer = reinterpret_cast(op.operand);
+instructions[i + 6].u.operandPointer = op.operand;
break;
}
@@ -731,7 +731,7 @@
op.watchpointSet->invalidate(vm, PutToScopeFireDetail(this, ident));
} else if (op.structure)
instructions[i + 5].u.structure.set(vm, this, op.structure);
-instructions[i + 6].u.pointer = reinterpret_cast(op.operand);
+instructions[i + 6].u.operandPointer = op.operand;
break;
}
Modified: trunk/Source/_javascript_Core/bytecode/Instruction.h (232815 => 232816)
--- trunk/Source/_javascript_Core/bytecode/Instruction.h 2018-06-13 22:22:07 UTC (rev 232815)
+++ trunk/Source/_javascript_Core/bytecode/Instruction.h 2018-06-13 22:51:29 UTC (rev 232816)
@@ -123,6 +123,7 @@
Opcode opcode;
int operand;
unsigned unsignedValue;
+intptr_t operandPointer;
WriteBarrierBase structure;
StructureID structureID;
WriteBarrierBase symbolTable;
Modified: trunk/Source/_javascript_Core/jit/JITOperations.cpp (232815 => 232816)
--- trunk/Source/_javascript_Core/jit/JITOperations.cpp 2018-06-13 22:22:07 UTC (rev 232815)
+++ trunk/Source/_javascript_Core/jit/JITOperations.cpp 2018-06-13 22:51:29 UTC (rev 232816)
@@ -2381,7 +2381,7 @@
if (getPutInfo.resolveType() == LocalClosureVar) {
JSLexicalEnvironment* environment = jsCast(scope);
-environment->variableAt(ScopeOffset(pc[6].u.operand)).set(vm, environment, value);
+environment->variableAt(ScopeOffset(pc[6].u.operandPointer)).set(vm, environment, value);
[webkit-changes] [232815] trunk/Source
Title: [232815] trunk/Source
Revision 232815
Author you...@apple.com
Date 2018-06-13 15:22:07 -0700 (Wed, 13 Jun 2018)
Log Message
Supported plugin check should be based on plugin identifier
https://bugs.webkit.org/show_bug.cgi?id=186578
Reviewed by Darin Adler.
Source/WebCore:
Rename SupportedPluginName in SupportedPluginIdentifier.
Add cross-platform support for plug-in identifier.
Update built-in PDF plug-in to check its identifier instead of its name.
This is stronger as the name may change according localization.
* loader/EmptyClients.cpp:
* plugins/PluginData.cpp:
(WebCore::isBuiltInPDFPlugIn):
(WebCore::PluginData::initPlugins):
* plugins/PluginData.h:
(WebCore::operator==):
(WebCore::isSupportedPlugin):
(WebCore::SupportedPluginIdentifier::decode):
(WebCore::SupportedPluginIdentifier::encode const):
(WebCore::SupportedPluginName::decode): Deleted.
(WebCore::SupportedPluginName::encode const): Deleted.
* plugins/PluginInfoProvider.h:
Source/WebKit:
Refactoring to move from Plugin name to Plugin identifier.
Set built-in pdf plugin identifier.
This allows making sure that the PDF plug-in check might not change according localization.
* Scripts/webkit/messages.py:
* Shared/WebCoreArgumentCoders.cpp:
(IPC::ArgumentCoder::encode):
(IPC::ArgumentCoder::decode):
* UIProcess/Plugins/PluginInfoStore.cpp:
(WebKit::PluginInfoStore::supportedPluginIdentifiers):
(WebKit::PluginInfoStore::addSupportedPlugin):
(WebKit::PluginInfoStore::supportedPluginNames): Deleted.
* UIProcess/Plugins/PluginInfoStore.h:
* UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::getPlugins):
* UIProcess/WebProcessProxy.h:
* UIProcess/WebProcessProxy.messages.in:
* WebProcess/Plugins/PDF/PDFPlugin.mm:
(WebKit::PDFPlugin::pluginInfo):
* WebProcess/Plugins/WebPluginInfoProvider.cpp:
(WebKit::WebPluginInfoProvider::pluginInfo):
(WebKit::WebPluginInfoProvider::webVisiblePluginInfo):
(WebKit::WebPluginInfoProvider::populatePluginCache):
* WebProcess/Plugins/WebPluginInfoProvider.h:
Source/WebKitLegacy/mac:
* WebCoreSupport/WebPluginInfoProvider.h:
* WebCoreSupport/WebPluginInfoProvider.mm:
(WebPluginInfoProvider::pluginInfo):
(WebPluginInfoProvider::webVisiblePluginInfo):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/loader/EmptyClients.cpp
trunk/Source/WebCore/plugins/PluginData.cpp
trunk/Source/WebCore/plugins/PluginData.h
trunk/Source/WebCore/plugins/PluginInfoProvider.h
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Scripts/webkit/messages.py
trunk/Source/WebKit/Shared/WebCoreArgumentCoders.cpp
trunk/Source/WebKit/UIProcess/Plugins/PluginInfoStore.cpp
trunk/Source/WebKit/UIProcess/Plugins/PluginInfoStore.h
trunk/Source/WebKit/UIProcess/WebProcessProxy.cpp
trunk/Source/WebKit/UIProcess/WebProcessProxy.h
trunk/Source/WebKit/UIProcess/WebProcessProxy.messages.in
trunk/Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.mm
trunk/Source/WebKit/WebProcess/Plugins/WebPluginInfoProvider.cpp
trunk/Source/WebKit/WebProcess/Plugins/WebPluginInfoProvider.h
trunk/Source/WebKitLegacy/mac/ChangeLog
trunk/Source/WebKitLegacy/mac/WebCoreSupport/WebPluginInfoProvider.h
trunk/Source/WebKitLegacy/mac/WebCoreSupport/WebPluginInfoProvider.mm
Diff
Modified: trunk/Source/WebCore/ChangeLog (232814 => 232815)
--- trunk/Source/WebCore/ChangeLog 2018-06-13 22:16:10 UTC (rev 232814)
+++ trunk/Source/WebCore/ChangeLog 2018-06-13 22:22:07 UTC (rev 232815)
@@ -1,3 +1,30 @@
+2018-06-13 Youenn Fablet
+
+Supported plugin check should be based on plugin identifier
+https://bugs.webkit.org/show_bug.cgi?id=186578
+
+
+Reviewed by Darin Adler.
+
+Rename SupportedPluginName in SupportedPluginIdentifier.
+Add cross-platform support for plug-in identifier.
+
+Update built-in PDF plug-in to check its identifier instead of its name.
+This is stronger as the name may change according localization.
+
+* loader/EmptyClients.cpp:
+* plugins/PluginData.cpp:
+(WebCore::isBuiltInPDFPlugIn):
+(WebCore::PluginData::initPlugins):
+* plugins/PluginData.h:
+(WebCore::operator==):
+(WebCore::isSupportedPlugin):
+(WebCore::SupportedPluginIdentifier::decode):
+(WebCore::SupportedPluginIdentifier::encode const):
+(WebCore::SupportedPluginName::decode): Deleted.
+(WebCore::SupportedPluginName::encode const): Deleted.
+* plugins/PluginInfoProvider.h:
+
2018-06-13 Chris Dumez
PSON: http/tests/resourceLoadStatistics/classify-as-prevalent-based-on-top-frame-redirect-collusion.html ASSERTS with process swap enabled
Modified: trunk/Source/WebCore/loader/EmptyClients.cpp (232814 => 232815)
--- trunk/Source/WebCore/loader/EmptyClients.cpp 2018-06-13 22:16:10 UTC (rev 232814)
+++ trunk/Source/WebCore/loader/EmptyClients.cpp 2018-06-13 22:22:07 UTC (rev 232815)
@@ -326,7 +326,7 @@
class EmptyPluginInfoProvider final : public PluginInfoProvider {
void refreshPlugins()
[webkit-changes] [232814] trunk
Title: [232814] trunk Revision 232814 Author cdu...@apple.com Date 2018-06-13 15:16:10 -0700 (Wed, 13 Jun 2018) Log Message PSON: http/tests/resourceLoadStatistics/classify-as-prevalent-based-on-top-frame-redirect-collusion.html ASSERTS with process swap enabled https://bugs.webkit.org/show_bug.cgi?id=186545 Reviewed by Brady Eidson. Source/WebCore: Move frame navigation logging for ITP purposes from the WebProcess to the UIProcess. This information was previously logged in DocumentLoader::willSendRequest() and was getting sync'd to the UIProcess at regular intervals or when the layout tests call testRunner's statisticsNotifyObserver(). We now do the logging directly in the UIProcess, in WebPageProxy::decidePolicyForNavigationAction (which was getting called via IPC from DocumentLoader::willSendRequest()). This is more efficient and will also be needed soon due to the way process swap on navigation deals with cross-origin redirects. On cross-origin redirect of the main frame, PSON cancels the load and started a new load to the redirected to URL in the new WebProcess. As a result, the new WebProcess is not aware that the load is a redirect, which is information that ITP requires. By moving the ITP logging to the UIProcess, we still have access to this information. * loader/DocumentLoader.cpp: (WebCore::DocumentLoader::willSendRequest): Stop logging the navigation now that it is logged in the UIProcess. * loader/EmptyClients.cpp: (WebCore::EmptyFrameLoaderClient::dispatchDecidePolicyForNavigationAction): * loader/EmptyFrameLoaderClient.h: * loader/FrameLoader.cpp: (WebCore::FrameLoader::loadURL): (WebCore::FrameLoader::loadWithDocumentLoader): * loader/FrameLoaderClient.h: * loader/PolicyChecker.cpp: (WebCore::PolicyChecker::checkNavigationPolicy): * loader/PolicyChecker.h: We now pass the full redirect request to the decidePolicyForNavigationAction delegate instead of a simple isRedirect boolean, so that we have the redirect response URL in the UIProcess for ITP logging. * loader/ResourceLoadObserver.cpp: (WebCore::areDomainsAssociated): (WebCore::ResourceLoadObserver::logSubresourceLoading): (WebCore::ResourceLoadObserver::logWebSocketLoading): (WebCore::ResourceLoadObserver::logUserInteractionWithReducedTimeResolution): * loader/ResourceLoadObserver.h: * loader/ResourceLoadStatistics.cpp: (WebCore::ResourceLoadStatistics::areDomainsAssociated): (WebCore::ResourceLoadStatistics::reduceTimeResolution): * loader/ResourceLoadStatistics.h: - Remove ResourceLoadObserver::logFrameNavigation() now that it is on the WebResourceLoadStatisticsStore. - Move some code from ResourceLoadObserver to ResourceLoadStatistics so that it can be called from the UIProcess and to avoid code duplication. Source/WebKit: Move frame navigation logging for ITP purposes from the WebProcess to the UIProcess. This information was previously logged in DocumentLoader::willSendRequest() and was getting sync'd to the UIProcess at regular intervals or when the layout tests call testRunner's statisticsNotifyObserver(). We now do the logging directly in the UIProcess, in WebPageProxy::decidePolicyForNavigationAction (which was getting called via IPC from DocumentLoader::willSendRequest()). This is more efficient and will also be needed soon due to the way process swap on navigation deals with cross-origin redirects. On cross-origin redirect of the main frame, PSON cancels the load and started a new load to the redirected to URL in the new WebProcess. As a result, the new WebProcess is not aware that the load is a redirect, which is information that ITP requires. By moving the ITP logging to the UIProcess, we still have access to this information. * UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::decidePolicyForNavigationAction): (WebKit::WebPageProxy::decidePolicyForNavigationActionSync): * UIProcess/WebPageProxy.h: * UIProcess/WebPageProxy.messages.in: - We now pass the full redirect response the the delegate method instead of a simple isRedirect boolean. - Log the navigation in the WebResourceLoadStatisticsStore for ITP purposes. * UIProcess/WebResourceLoadStatisticsStore.cpp: (WebKit::areDomainsAssociated): Equivalent of ResourceLoadObserver's areDomainsAssociated(). Most of the logic was moved to ResourceLoadStatistics::areDomainsAssociated() to avoid code duplication. (WebKit::WebResourceLoadStatisticsStore::resourceLoadStatisticsUpdated): This is called whenever a WebProcess sends new resource load statistics to the UIProcess. Whenever this happens, we call processStatisticsAndDataRecords() right away, which is sometimes the tests currently rely on. As a result, we can cancels any pending statistics processing request that was scheduled by logFrameNavigation(). (WebKit::WebResourceLoadStatisticsStore::scheduleStatisticsProcessingRequestIfNecessary): (WebKit::WebResourceLoadStatisticsStore::cancelPendingStatisticsProcessingRequest): Whenever a navigation is logged and statistics have been updated, we need to
[webkit-changes] [232813] trunk/Tools
Title: [232813] trunk/Tools
Revision 232813
Author david_fen...@apple.com
Date 2018-06-13 14:54:44 -0700 (Wed, 13 Jun 2018)
Log Message
Unreviewed, add myself as a WebKit committer.
* Scripts/webkitpy/common/config/contributors.json:
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/common/config/contributors.json
Diff
Modified: trunk/Tools/ChangeLog (232812 => 232813)
--- trunk/Tools/ChangeLog 2018-06-13 21:48:57 UTC (rev 232812)
+++ trunk/Tools/ChangeLog 2018-06-13 21:54:44 UTC (rev 232813)
@@ -1,3 +1,9 @@
+2018-06-13 David Fenton
+
+Unreviewed, add myself as a WebKit committer.
+
+* Scripts/webkitpy/common/config/contributors.json:
+
2018-06-13 Carlos Alberto Lopez Perez
[JSCOnly] Add a MIPS32el JSCOnly EWS (follow-up fix)
Modified: trunk/Tools/Scripts/webkitpy/common/config/contributors.json (232812 => 232813)
--- trunk/Tools/Scripts/webkitpy/common/config/contributors.json 2018-06-13 21:48:57 UTC (rev 232812)
+++ trunk/Tools/Scripts/webkitpy/common/config/contributors.json 2018-06-13 21:54:44 UTC (rev 232813)
@@ -1499,6 +1499,15 @@
],
"status" : "committer"
},
+"David Fenton" : {
+"emails" : [
+ "david_fen...@apple.com"
+],
+"nicks" : [
+ "realdawei"
+],
+"status" : "committer"
+},
"David Grogan" : {
"emails" : [
"dgro...@chromium.org",
@@ -6036,4 +6045,5 @@
],
"status" : "reviewer"
}
+
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [232812] trunk/LayoutTests
Title: [232812] trunk/LayoutTests Revision 232812 Author ryanhad...@apple.com Date 2018-06-13 14:48:57 -0700 (Wed, 13 Jun 2018) Log Message [macOS Debug WK1] LayoutTest fast/parser/xml-error-adopted.xml is a flaky timeout. https://bugs.webkit.org/show_bug.cgi?id=186581 Unreviewed test gardening. Patch by David Fenton on 2018-06-13 * platform/mac-wk1/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/mac-wk1/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (232811 => 232812) --- trunk/LayoutTests/ChangeLog 2018-06-13 21:26:34 UTC (rev 232811) +++ trunk/LayoutTests/ChangeLog 2018-06-13 21:48:57 UTC (rev 232812) @@ -1,3 +1,12 @@ +2018-06-13 David Fenton + +[macOS Debug WK1] LayoutTest fast/parser/xml-error-adopted.xml is a flaky timeout. +https://bugs.webkit.org/show_bug.cgi?id=186581 + +Unreviewed test gardening. + +* platform/mac-wk1/TestExpectations: + 2018-06-13 Mark Lam Gardening: Layout Test js/error-should-not-strong-reference-global-object.html is a flaky failure Modified: trunk/LayoutTests/platform/mac-wk1/TestExpectations (232811 => 232812) --- trunk/LayoutTests/platform/mac-wk1/TestExpectations 2018-06-13 21:26:34 UTC (rev 232811) +++ trunk/LayoutTests/platform/mac-wk1/TestExpectations 2018-06-13 21:48:57 UTC (rev 232812) @@ -556,3 +556,5 @@ webkit.org/b/184458 media/remote-control-command-is-user-gesture.html [ Pass Timeout ] webkit.org/b/185404 http/tests/security/contentSecurityPolicy/block-all-mixed-content/insecure-iframe-in-main-frame.html [ Pass Failure ] + +webkit.org/b/186581 [ Debug ] fast/parser/xml-error-adopted.xml [ Timeout Pass ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [232811] trunk/Source/WebInspectorUI
Title: [232811] trunk/Source/WebInspectorUI Revision 232811 Author nvasil...@apple.com Date 2018-06-13 14:26:34 -0700 (Wed, 13 Jun 2018) Log Message Web Inspector: open source Dark Mode https://bugs.webkit.org/show_bug.cgi?id=186606 Reviewed by Timothy Hatcher. The dark mode is currently only available on macOS Mojave via prefers-dark-interface CSS media query. * UserInterface/Main.html: * UserInterface/Views/DarkMode.css: Added. (@media (prefers-dark-interface)): (:root): (body.window-inactive): (body.window-inactive *): (#main): (.tree-outline.dom li.selected .selection-area): (.tab-bar > .item > .icon): (.go-to-arrow): (.resource-link,): (.expand-list-button): (:matches(img, canvas).show-grid): (.formatted-object,): (.formatted-null,): (.editing): (.editing, .editing *): (.text-editor > .CodeMirror .execution-line): (.text-editor > .CodeMirror .execution-range-highlight:not(.CodeMirror-selectedtext),): (.details-section > .header): (.details-section > .header > label): (.details-section .details-section,): (.details-section .details-section:not(.collapsed) > .header): (.details-section > .content > .group > .row.simple > .label): (.details-section > .content > .group:nth-child(even)): (.details-section > .content > .group > .row:matches(.empty, .text)): (.data-grid th): (.data-grid td .subtitle): (.data-grid:matches(:focus, .force-focus) tr.selected td .subtitle): (body:not(.window-inactive, .window-docked-inactive) .data-grid:matches(:focus, .force-focus) tr.editable.selected .cell-content > input): (.data-grid tr.editable .cell-content > input): (.data-grid td.spanning): (.object-tree,): (.object-preview .name): (.object-preview > .size): (.tab-bar): (.tab-bar > .item): (.tab-bar > .item > .title): (.tab-bar > .item:not(.disabled).selected): (.tab-bar:not(.animating) > .item:not(.selected):hover): (.tab-bar > .item > .close): (body.window-inactive .tab-bar): (body.window-inactive .tab-bar > .item): (body.window-inactive .tab-bar > .item.selected): (body.window-inactive .tab-bar > .item > .title): (body .toolbar): (body.window-inactive .toolbar): (body.latest-mac .toolbar .item.button,): (body.latest-mac .toolbar .search-bar > input[type="search"]): (body.latest-mac .toolbar .search-bar > input[type="search"]:focus): (body.latest-mac .toolbar .search-bar > input[type="search"]::placeholder): (body.latest-mac.window-inactive .toolbar .search-bar > input[type="search"]::placeholder): (body.latest-mac.window-inactive .toolbar .search-bar > input[type="search"]::-webkit-search-results-button): (body.latest-mac .toolbar .dashboard-container): (body.latest-mac .toolbar .item.button:active): (body.latest-mac.window-inactive .toolbar .item.button,): (.navigation-bar .item.divider): (.toolbar .item.button): (.toolbar .item.button:not(.disabled):active): (.toolbar .item.button:not(.disabled):matches(:focus, .activate.activated)): (.toolbar .item.button:not(.disabled):active:matches(:focus, .activate.activated)): (.toolbar .dashboard.default > .item > div): (.toolbar .dashboard.default > .item.enabled > div): (.toolbar .dashboard.default > .item.enabled:hover): (.toolbar .dashboard.default > .item.enabled:hover > div): (.toolbar .dashboard.default > .resourcesCount > img,): (body.latest-mac .toolbar .dashboard .item.button): (.dashboard-container .advance-arrow): (.toolbar .dashboard.debugger): (.dashboard.debugger .navigation-bar .item.button > .glyph): (.dashboard.debugger > .location .function-name): (.dashboard.debugger > .location .go-to-link): (.dashboard.debugger > .divider): (.popover .edit-breakpoint-popover-content > label.toggle): (.popover .edit-breakpoint-popover-content > table > tr > th): (.breakpoint-action-block-body): (.breakpoint-action-block-body > .description): (.breakpoint-action-append-button,): (.popover .xhr-breakpoint-content > .editor-wrapper > .editor): (.navigation-bar .item.button): (.spreadsheet-style-declaration-editor .property:not(.disabled) .value): (.spreadsheet-css-declaration): (.spreadsheet-css-declaration .selector:focus,): (.spreadsheet-css-declaration.locked .origin::after): (.spreadsheet-css-declaration .origin .go-to-link,): (.spreadsheet-style-declaration-editor :matches(.name, .value).editing): (.spreadsheet-style-declaration-editor .property.has-warning): (.spreadsheet-style-declaration-editor .property.has-warning .warning): (.spreadsheet-css-declaration .media-label): (.quick-console): (.syntax-highlighted,): (.cm-s-default,): (.CodeMirror .jump-to-symbol-highlight,): (.console-prompt): (.completion-suggestions): (.completion-suggestions-container > .item): (.CodeMirror-cursor): (.CodeMirror .CodeMirror-gutters): (.cm-s-default .cm-link): (.cm-s-default .cm-m-xml.cm-attribute,): (.cm-s-default .cm-meta): (.cm-s-default .cm-variable-3): (.cm-s-default .cm-builtin): (.tree-outline .item .subtitle): (.object-tree-property .getter,): (.item.object-tree-property.prototype-property): (.object-tree-property.prototype-property:hover,): (.object-tree-property
[webkit-changes] [232810] trunk/LayoutTests
Title: [232810] trunk/LayoutTests
Revision 232810
Author mark@apple.com
Date 2018-06-13 14:21:21 -0700 (Wed, 13 Jun 2018)
Log Message
Gardening: Layout Test js/error-should-not-strong-reference-global-object.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=186372
Not reviewed.
Speculative fix to green the bots plus improved the error message logging to get
more info if this fails again.
* js/error-should-not-strong-reference-global-object.html:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/js/error-should-not-strong-reference-global-object.html
Diff
Modified: trunk/LayoutTests/ChangeLog (232809 => 232810)
--- trunk/LayoutTests/ChangeLog 2018-06-13 20:57:49 UTC (rev 232809)
+++ trunk/LayoutTests/ChangeLog 2018-06-13 21:21:21 UTC (rev 232810)
@@ -1,3 +1,15 @@
+2018-06-13 Mark Lam
+
+Gardening: Layout Test js/error-should-not-strong-reference-global-object.html is a flaky failure
+https://bugs.webkit.org/show_bug.cgi?id=186372
+
+Not reviewed.
+
+Speculative fix to green the bots plus improved the error message logging to get
+more info if this fails again.
+
+* js/error-should-not-strong-reference-global-object.html:
+
2018-06-13 Timothy Hatcher
Input form controls have a white background in dark mode, when they should not.
Modified: trunk/LayoutTests/js/error-should-not-strong-reference-global-object.html (232809 => 232810)
--- trunk/LayoutTests/js/error-should-not-strong-reference-global-object.html 2018-06-13 20:57:49 UTC (rev 232809)
+++ trunk/LayoutTests/js/error-should-not-strong-reference-global-object.html 2018-06-13 21:21:21 UTC (rev 232810)
@@ -40,10 +40,13 @@
for (let i = 0; i < 50; i++)
run();
-$vm.gc();
-// We shouldn't have more than 10% of the global objects we allocated.
-if ($vm.globalObjectCount() >= 51)
-throw new Error("There are more global objects than there should be");
+setTimeout(() => {
+$vm.gc();
+// We shouldn't have more than 10% of the global objects we allocated.
+var globalObjectCount = $vm.globalObjectCount();
+if (globalObjectCount >= 51)
+throw new Error("There are more global objects than there should be: actual count = " + globalObjectCount);
+}, 1);
[webkit-changes] [232809] trunk/Source/WebCore
Title: [232809] trunk/Source/WebCore
Revision 232809
Author mark@apple.com
Date 2018-06-13 13:57:49 -0700 (Wed, 13 Jun 2018)
Log Message
FloatingPointEnvironment is only needed for ARM CPUs.
https://bugs.webkit.org/show_bug.cgi?id=186567
Reviewed by Michael Saboff.
No new tests. This behavior is already covered by existing tests.
* platform/ios/wak/FloatingPointEnvironment.cpp:
* platform/ios/wak/FloatingPointEnvironment.h:
(WebCore::FloatingPointEnvironment::enableDenormalSupport):
(WebCore::FloatingPointEnvironment::saveMainThreadEnvironment):
(WebCore::FloatingPointEnvironment::propagateMainThreadEnvironment):
(WebCore::FloatingPointEnvironment::singleton):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/ios/wak/FloatingPointEnvironment.cpp
trunk/Source/WebCore/platform/ios/wak/FloatingPointEnvironment.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (232808 => 232809)
--- trunk/Source/WebCore/ChangeLog 2018-06-13 20:47:17 UTC (rev 232808)
+++ trunk/Source/WebCore/ChangeLog 2018-06-13 20:57:49 UTC (rev 232809)
@@ -1,3 +1,20 @@
+2018-06-13 Mark Lam
+
+FloatingPointEnvironment is only needed for ARM CPUs.
+https://bugs.webkit.org/show_bug.cgi?id=186567
+
+
+Reviewed by Michael Saboff.
+
+No new tests. This behavior is already covered by existing tests.
+
+* platform/ios/wak/FloatingPointEnvironment.cpp:
+* platform/ios/wak/FloatingPointEnvironment.h:
+(WebCore::FloatingPointEnvironment::enableDenormalSupport):
+(WebCore::FloatingPointEnvironment::saveMainThreadEnvironment):
+(WebCore::FloatingPointEnvironment::propagateMainThreadEnvironment):
+(WebCore::FloatingPointEnvironment::singleton):
+
2018-06-13 Timothy Hatcher
Input form controls have a white background in dark mode, when they should not.
Modified: trunk/Source/WebCore/platform/ios/wak/FloatingPointEnvironment.cpp (232808 => 232809)
--- trunk/Source/WebCore/platform/ios/wak/FloatingPointEnvironment.cpp 2018-06-13 20:47:17 UTC (rev 232808)
+++ trunk/Source/WebCore/platform/ios/wak/FloatingPointEnvironment.cpp 2018-06-13 20:57:49 UTC (rev 232809)
@@ -29,8 +29,6 @@
#include
#include
-#if PLATFORM(IOS)
-
namespace WebCore {
FloatingPointEnvironment& FloatingPointEnvironment::singleton()
@@ -39,6 +37,8 @@
return floatingPointEnvironment;
}
+#if PLATFORM(IOS) && (CPU(ARM) || CPU(ARM64))
+
FloatingPointEnvironment::FloatingPointEnvironment()
: m_isInitialized(false)
{
@@ -48,7 +48,7 @@
{
RELEASE_ASSERT(isUIThread());
#if defined _ARM_ARCH_7
-fenv_t env;
+fenv_t env;
fegetenv();
env.__fpscr &= ~0x0100U;
fesetenv();
@@ -71,6 +71,6 @@
fesetenv(_mainThreadEnvironment);
}
+#endif // PLATFORM(IOS) && (CPU(ARM) || CPU(ARM64))
+
} // namespace WebCore
-
-#endif // PLATFORM(IOS)
Modified: trunk/Source/WebCore/platform/ios/wak/FloatingPointEnvironment.h (232808 => 232809)
--- trunk/Source/WebCore/platform/ios/wak/FloatingPointEnvironment.h 2018-06-13 20:47:17 UTC (rev 232808)
+++ trunk/Source/WebCore/platform/ios/wak/FloatingPointEnvironment.h 2018-06-13 20:57:49 UTC (rev 232809)
@@ -26,12 +26,12 @@
#ifndef FloatingPointEnvironment_h
#define FloatingPointEnvironment_h
-#if TARGET_OS_IPHONE
-
#import
namespace WebCore {
+#if PLATFORM(IOS) && (CPU(ARM) || CPU(ARM64))
+
class FloatingPointEnvironment {
public:
FloatingPointEnvironment();
@@ -48,11 +48,22 @@
bool m_isInitialized;
};
+#else // not PLATFORM(IOS) && (CPU(ARM) || CPU(ARM64))
+
+class FloatingPointEnvironment {
+public:
+FloatingPointEnvironment() = default;
+void enableDenormalSupport() { }
+void saveMainThreadEnvironment() { }
+void propagateMainThreadEnvironment() { }
+WEBCORE_EXPORT static FloatingPointEnvironment& singleton();
+};
+
+#endif // PLATFORM(IOS) && (CPU(ARM) || CPU(ARM64))
+
} // namespace WebCore
using WebCore::FloatingPointEnvironment;
-#endif // TARGET_OS_IPHONE
-
#endif // FloatingPointEnvironment_h
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [232808] trunk/Source/WebKit
Title: [232808] trunk/Source/WebKit
Revision 232808
Author bfulg...@apple.com
Date 2018-06-13 13:47:17 -0700 (Wed, 13 Jun 2018)
Log Message
Crash during interrupted process termination
https://bugs.webkit.org/show_bug.cgi?id=185373
Reviewed by Alex Christensen.
It's possible to encounter a crash if a user agent feature (such as Safari's responsiveness timer) decides
to kill a Web Process around the same time that a user decides to trigger a new page load. One of the two
termination operations may attempt to call methods on a nulled process pointer.
We can avoid this by holding our own reference to the terminating process until the termination steps have
been completed.
* UIProcess/API/C/WKPage.cpp:
(WKPageTerminate): Ref<> the active process while the termination call is performed.
* UIProcess/API/Cocoa/WKWebView.mm:
([WKWebView _killWebContentProcessAndResetState]): Ditto.
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/API/C/WKPage.cpp
trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm
Diff
Modified: trunk/Source/WebKit/ChangeLog (232807 => 232808)
--- trunk/Source/WebKit/ChangeLog 2018-06-13 20:29:08 UTC (rev 232807)
+++ trunk/Source/WebKit/ChangeLog 2018-06-13 20:47:17 UTC (rev 232808)
@@ -1,3 +1,23 @@
+2018-06-13 Brent Fulgham
+
+Crash during interrupted process termination
+https://bugs.webkit.org/show_bug.cgi?id=185373
+
+
+Reviewed by Alex Christensen.
+
+It's possible to encounter a crash if a user agent feature (such as Safari's responsiveness timer) decides
+to kill a Web Process around the same time that a user decides to trigger a new page load. One of the two
+termination operations may attempt to call methods on a nulled process pointer.
+
+We can avoid this by holding our own reference to the terminating process until the termination steps have
+been completed.
+
+* UIProcess/API/C/WKPage.cpp:
+(WKPageTerminate): Ref<> the active process while the termination call is performed.
+* UIProcess/API/Cocoa/WKWebView.mm:
+([WKWebView _killWebContentProcessAndResetState]): Ditto.
+
2018-06-13 Brian Burg
[Cocoa] Web Automation: wrong modifiers sent for 'Help' virtual key
Modified: trunk/Source/WebKit/UIProcess/API/C/WKPage.cpp (232807 => 232808)
--- trunk/Source/WebKit/UIProcess/API/C/WKPage.cpp 2018-06-13 20:29:08 UTC (rev 232807)
+++ trunk/Source/WebKit/UIProcess/API/C/WKPage.cpp 2018-06-13 20:47:17 UTC (rev 232808)
@@ -413,7 +413,8 @@
void WKPageTerminate(WKPageRef pageRef)
{
-toImpl(pageRef)->process().requestTermination(ProcessTerminationReason::RequestedByClient);
+Ref protectedProcessProxy(toImpl(pageRef)->process());
+protectedProcessProxy->requestTermination(ProcessTerminationReason::RequestedByClient);
}
WKStringRef WKPageGetSessionHistoryURLValueType()
Modified: trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm (232807 => 232808)
--- trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm 2018-06-13 20:29:08 UTC (rev 232807)
+++ trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm 2018-06-13 20:47:17 UTC (rev 232808)
@@ -4300,7 +4300,8 @@
- (void)_killWebContentProcessAndResetState
{
-_page->process().requestTermination(WebKit::ProcessTerminationReason::RequestedByClient);
+Ref protectedProcessProxy(_page->process());
+protectedProcessProxy->requestTermination(WebKit::ProcessTerminationReason::RequestedByClient);
}
#if PLATFORM(MAC)
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [232807] trunk/Source/WebKit
Title: [232807] trunk/Source/WebKit Revision 232807 Author bb...@apple.com Date 2018-06-13 13:29:08 -0700 (Wed, 13 Jun 2018) Log Message [Cocoa] Web Automation: wrong modifiers sent for 'Help' virtual key https://bugs.webkit.org/show_bug.cgi?id=186600 Reviewed by Timothy Hatcher. This fixes a hang when running W3C test: special_keys.py::test_webdriver_special_key_sends_keydown[HELP-expected2] * UIProcess/Automation/mac/WebAutomationSessionMac.mm: (WebKit::eventModifierFlagsForVirtualKey): The help modifier doesn't seem to be used when pressing the Help key. I verified this using the Help key on the Keyboard Viewer, since no keyboards from the past decade actually have this physical button. Modified Paths trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/UIProcess/Automation/mac/WebAutomationSessionMac.mm Diff Modified: trunk/Source/WebKit/ChangeLog (232806 => 232807) --- trunk/Source/WebKit/ChangeLog 2018-06-13 20:26:32 UTC (rev 232806) +++ trunk/Source/WebKit/ChangeLog 2018-06-13 20:29:08 UTC (rev 232807) @@ -1,3 +1,21 @@ +2018-06-13 Brian Burg + +[Cocoa] Web Automation: wrong modifiers sent for 'Help' virtual key +https://bugs.webkit.org/show_bug.cgi?id=186600 + + +Reviewed by Timothy Hatcher. + +This fixes a hang when running W3C test: + +special_keys.py::test_webdriver_special_key_sends_keydown[HELP-expected2] + +* UIProcess/Automation/mac/WebAutomationSessionMac.mm: +(WebKit::eventModifierFlagsForVirtualKey): +The help modifier doesn't seem to be used when pressing the Help key. +I verified this using the Help key on the Keyboard Viewer, since no +keyboards from the past decade actually have this physical button. + 2018-06-13 Thibault Saunier [WPE] Build getUserMedia support Modified: trunk/Source/WebKit/UIProcess/Automation/mac/WebAutomationSessionMac.mm (232806 => 232807) --- trunk/Source/WebKit/UIProcess/Automation/mac/WebAutomationSessionMac.mm 2018-06-13 20:26:32 UTC (rev 232806) +++ trunk/Source/WebKit/UIProcess/Automation/mac/WebAutomationSessionMac.mm 2018-06-13 20:29:08 UTC (rev 232807) @@ -372,8 +372,6 @@ return NSEventModifierFlagCommand; case VirtualKey::Help: -return NSEventModifierFlagHelp | NSEventModifierFlagFunction; - case VirtualKey::PageUp: case VirtualKey::PageDown: case VirtualKey::End: ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [232806] trunk
Title: [232806] trunk Revision 232806 Author timo...@apple.com Date 2018-06-13 13:26:32 -0700 (Wed, 13 Jun 2018) Log Message Input form controls have a white background in dark mode, when they should not. https://bugs.webkit.org/show_bug.cgi?id=186577 rdar://problem/39258325 Reviewed by Tim Horton. Source/WebCore: * DerivedSources.make: Allow WTF_PLATFORM_MAC ifdefs to preprocess in html.css. * css/CSSValueKeywords.in: Added -apple-system-control-background. * css/MediaQueryExpression.cpp: (WebCore::featureWithValidIdent): Allow dark mode media query in user agent stylesheets. (WebCore::isFeatureValidWithoutValue): Ditto. * css/MediaQueryParserContext.cpp: (WebCore::MediaQueryParserContext::MediaQueryParserContext): Transfer the CSSParserMode from CSSParserContext. * css/MediaQueryParserContext.h: * css/html.css: Set color and background-color to semantic colors for input, textarea, and select. Make input background-color transparent in dark mode to match AppKit. * rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::systemColor const): Added -apple-system-control-background. (WebCore::RenderThemeMac::paintTextField): Adjust the drawing rect to match new artwork in macOS 10.14. LayoutTests: * fast/css/apple-system-control-colors-expected.txt: Updated. * fast/css/apple-system-control-colors.html: Added -apple-system-control-background. * platform/gtk/fast/css/apple-system-control-colors-expected.txt: Updated. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/fast/css/apple-system-control-colors-expected.txt trunk/LayoutTests/fast/css/apple-system-control-colors.html trunk/LayoutTests/platform/gtk/fast/css/apple-system-control-colors-expected.txt trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/DerivedSources.make trunk/Source/WebCore/css/CSSValueKeywords.in trunk/Source/WebCore/css/MediaQueryExpression.cpp trunk/Source/WebCore/css/MediaQueryParserContext.cpp trunk/Source/WebCore/css/MediaQueryParserContext.h trunk/Source/WebCore/css/html.css trunk/Source/WebCore/rendering/RenderThemeMac.mm Diff Modified: trunk/LayoutTests/ChangeLog (232805 => 232806) --- trunk/LayoutTests/ChangeLog 2018-06-13 20:24:27 UTC (rev 232805) +++ trunk/LayoutTests/ChangeLog 2018-06-13 20:26:32 UTC (rev 232806) @@ -1,3 +1,16 @@ +2018-06-13 Timothy Hatcher + +Input form controls have a white background in dark mode, when they should not. + +https://bugs.webkit.org/show_bug.cgi?id=186577 +rdar://problem/39258325 + +Reviewed by Tim Horton. + +* fast/css/apple-system-control-colors-expected.txt: Updated. +* fast/css/apple-system-control-colors.html: Added -apple-system-control-background. +* platform/gtk/fast/css/apple-system-control-colors-expected.txt: Updated. + 2018-06-13 John Wilander Add console logging to test case to help investigate flaky timeouts Modified: trunk/LayoutTests/fast/css/apple-system-control-colors-expected.txt (232805 => 232806) --- trunk/LayoutTests/fast/css/apple-system-control-colors-expected.txt 2018-06-13 20:24:27 UTC (rev 232805) +++ trunk/LayoutTests/fast/css/apple-system-control-colors-expected.txt 2018-06-13 20:26:32 UTC (rev 232806) @@ -1,5 +1,6 @@ -apple-system-header-text : rgba(0, 0, 0, 0.85098) -apple-system-text-background : rgb(255, 255, 255) +-apple-system-control-background : rgb(255, 255, 255) -apple-system-alternate-selected-text : rgb(255, 255, 255) -apple-system-label : rgba(0, 0, 0, 0.85098) -apple-system-secondary-label : rgba(0, 0, 0, 0.498039) Modified: trunk/LayoutTests/fast/css/apple-system-control-colors.html (232805 => 232806) --- trunk/LayoutTests/fast/css/apple-system-control-colors.html 2018-06-13 20:24:27 UTC (rev 232805) +++ trunk/LayoutTests/fast/css/apple-system-control-colors.html 2018-06-13 20:26:32 UTC (rev 232806) @@ -23,6 +23,7 @@ -apple-system-header-text -apple-system-text-background +-apple-system-control-background -apple-system-alternate-selected-text -apple-system-label -apple-system-secondary-label Modified: trunk/LayoutTests/platform/gtk/fast/css/apple-system-control-colors-expected.txt (232805 => 232806) --- trunk/LayoutTests/platform/gtk/fast/css/apple-system-control-colors-expected.txt 2018-06-13 20:24:27 UTC (rev 232805) +++ trunk/LayoutTests/platform/gtk/fast/css/apple-system-control-colors-expected.txt 2018-06-13 20:26:32 UTC (rev 232806) @@ -1,5 +1,6 @@ -apple-system-header-text : rgba(0, 0, 0, 0) -apple-system-text-background : rgba(0, 0, 0, 0) +-apple-system-control-background : rgba(0, 0, 0, 0) -apple-system-alternate-selected-text : rgba(0, 0, 0, 0) -apple-system-label : rgba(0, 0, 0, 0) -apple-system-secondary-label : rgba(0, 0, 0, 0) Modified: trunk/Source/WebCore/ChangeLog (232805 => 232806) --- trunk/Source/WebCore/ChangeLog 2018-06-13 20:24:27 UTC (rev 232805) +++ trunk/Source/WebCore/ChangeLog 2018-06-13 20:26:32 UTC (rev 232806) @@ -1,3 +1,26 @@ +2018-06-13 Timothy Hatcher + +Input form controls
[webkit-changes] [232805] trunk/LayoutTests
Title: [232805] trunk/LayoutTests
Revision 232805
Author wilan...@apple.com
Date 2018-06-13 13:24:27 -0700 (Wed, 13 Jun 2018)
Log Message
Add console logging to test case to help investigate flaky timeouts
https://bugs.webkit.org/show_bug.cgi?id=186603
Unreviewed test gardening.
* http/tests/resourceLoadStatistics/partitioned-and-unpartitioned-cookie-with-partitioning-timeout-expected.txt:
* http/tests/resourceLoadStatistics/partitioned-and-unpartitioned-cookie-with-partitioning-timeout.html:
Now has step-by-step console logging so that (hopefully) the flaky timeouts don't produce empty output.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/http/tests/resourceLoadStatistics/partitioned-and-unpartitioned-cookie-with-partitioning-timeout-expected.txt
trunk/LayoutTests/http/tests/resourceLoadStatistics/partitioned-and-unpartitioned-cookie-with-partitioning-timeout.html
Diff
Modified: trunk/LayoutTests/ChangeLog (232804 => 232805)
--- trunk/LayoutTests/ChangeLog 2018-06-13 20:01:11 UTC (rev 232804)
+++ trunk/LayoutTests/ChangeLog 2018-06-13 20:24:27 UTC (rev 232805)
@@ -1,3 +1,15 @@
+2018-06-13 John Wilander
+
+Add console logging to test case to help investigate flaky timeouts
+https://bugs.webkit.org/show_bug.cgi?id=186603
+
+
+Unreviewed test gardening.
+
+* http/tests/resourceLoadStatistics/partitioned-and-unpartitioned-cookie-with-partitioning-timeout-expected.txt:
+* http/tests/resourceLoadStatistics/partitioned-and-unpartitioned-cookie-with-partitioning-timeout.html:
+Now has step-by-step console logging so that (hopefully) the flaky timeouts don't produce empty output.
+
2018-06-13 Said Abou-Hallawa
TileFirstPaint strategy for async image decoding should be disabled for non root RenderLayers
Modified: trunk/LayoutTests/http/tests/resourceLoadStatistics/partitioned-and-unpartitioned-cookie-with-partitioning-timeout-expected.txt (232804 => 232805)
--- trunk/LayoutTests/http/tests/resourceLoadStatistics/partitioned-and-unpartitioned-cookie-with-partitioning-timeout-expected.txt 2018-06-13 20:01:11 UTC (rev 232804)
+++ trunk/LayoutTests/http/tests/resourceLoadStatistics/partitioned-and-unpartitioned-cookie-with-partitioning-timeout-expected.txt 2018-06-13 20:24:27 UTC (rev 232805)
@@ -1,3 +1,15 @@
+CONSOLE MESSAGE: line 114: Bootstrapping test.
+CONSOLE MESSAGE: line 65: Step 1.
+CONSOLE MESSAGE: line 70: Step 2.
+CONSOLE MESSAGE: line 77: Step 3.
+CONSOLE MESSAGE: line 84: Step 4.
+CONSOLE MESSAGE: line 54: setNormalCookiePartitioningTimeOutPlusUserInteractionAndContinue().
+CONSOLE MESSAGE: line 91: Step 5.
+CONSOLE MESSAGE: line 48: setShortCookiePartitioningTimeOutPlusFireShouldPartitionCookiesHandlerAndContinue().
+CONSOLE MESSAGE: line 43: fireShouldPartitionCookiesHandlerAndContinue().
+CONSOLE MESSAGE: line 98: Step 6.
+CONSOLE MESSAGE: line 54: setNormalCookiePartitioningTimeOutPlusUserInteractionAndContinue().
+CONSOLE MESSAGE: line 105: Step 7.
PASS successfullyParsed is true
TEST COMPLETE
Modified: trunk/LayoutTests/http/tests/resourceLoadStatistics/partitioned-and-unpartitioned-cookie-with-partitioning-timeout.html (232804 => 232805)
--- trunk/LayoutTests/http/tests/resourceLoadStatistics/partitioned-and-unpartitioned-cookie-with-partitioning-timeout.html 2018-06-13 20:01:11 UTC (rev 232804)
+++ trunk/LayoutTests/http/tests/resourceLoadStatistics/partitioned-and-unpartitioned-cookie-with-partitioning-timeout.html 2018-06-13 20:24:27 UTC (rev 232805)
@@ -40,15 +40,18 @@
}
function fireShouldPartitionCookiesHandlerAndContinue() {
+console.log("fireShouldPartitionCookiesHandlerAndContinue().");
testRunner.statisticsUpdateCookiePartitioning(runTest);
}
function setShortCookiePartitioningTimeOutPlusFireShouldPartitionCookiesHandlerAndContinue() {
+console.log("setShortCookiePartitioningTimeOutPlusFireShouldPartitionCookiesHandlerAndContinue().");
testRunner.setStatisticsTimeToLiveCookiePartitionFree(1);
setTimeout(fireShouldPartitionCookiesHandlerAndContinue, 2000);
}
function setNormalCookiePartitioningTimeOutPlusUserInteractionAndContinue() {
+console.log("setNormalCookiePartitioningTimeOutPlusUserInteractionAndContinue().");
testRunner.setStatisticsTimeToLiveCookiePartitionFree(86400);
testRunner.setStatisticsHasHadUserInteraction(thirdPartyOrigin, true);
if (!testRunner.isStatisticsHasHadUserInteraction(thirdPartyOrigin))
@@ -59,10 +62,12 @@
function runTest() {
switch (document.location.hash) {
case "#step1":
+console.log("Step 1.");
// Set first-party cookie for http://localhost:8000
document.location.href = "" + subPathToSetFirstPartyCookie + "#" + fragmentWithReturnUrl + "#step2";
break;
case "#step2":
+console.log("Step 2.");
[webkit-changes] [232804] trunk/Source
Title: [232804] trunk/Source Revision 232804 Author kocsen_ch...@apple.com Date 2018-06-13 13:01:11 -0700 (Wed, 13 Jun 2018) Log Message Versioning. Modified Paths trunk/Source/_javascript_Core/Configurations/Version.xcconfig trunk/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig trunk/Source/WebCore/Configurations/Version.xcconfig trunk/Source/WebCore/PAL/Configurations/Version.xcconfig trunk/Source/WebInspectorUI/Configurations/Version.xcconfig trunk/Source/WebKit/Configurations/Version.xcconfig trunk/Source/WebKitLegacy/mac/Configurations/Version.xcconfig Diff Modified: trunk/Source/_javascript_Core/Configurations/Version.xcconfig (232803 => 232804) --- trunk/Source/_javascript_Core/Configurations/Version.xcconfig 2018-06-13 19:59:30 UTC (rev 232803) +++ trunk/Source/_javascript_Core/Configurations/Version.xcconfig 2018-06-13 20:01:11 UTC (rev 232804) @@ -23,7 +23,7 @@ MAJOR_VERSION = 606; MINOR_VERSION = 1; -TINY_VERSION = 21; +TINY_VERSION = 22; MICRO_VERSION = 0; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); Modified: trunk/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (232803 => 232804) --- trunk/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig 2018-06-13 19:59:30 UTC (rev 232803) +++ trunk/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig 2018-06-13 20:01:11 UTC (rev 232804) @@ -23,7 +23,7 @@ MAJOR_VERSION = 606; MINOR_VERSION = 1; -TINY_VERSION = 21; +TINY_VERSION = 22; MICRO_VERSION = 0; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); Modified: trunk/Source/WebCore/Configurations/Version.xcconfig (232803 => 232804) --- trunk/Source/WebCore/Configurations/Version.xcconfig 2018-06-13 19:59:30 UTC (rev 232803) +++ trunk/Source/WebCore/Configurations/Version.xcconfig 2018-06-13 20:01:11 UTC (rev 232804) @@ -23,7 +23,7 @@ MAJOR_VERSION = 606; MINOR_VERSION = 1; -TINY_VERSION = 21; +TINY_VERSION = 22; MICRO_VERSION = 0; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); Modified: trunk/Source/WebCore/PAL/Configurations/Version.xcconfig (232803 => 232804) --- trunk/Source/WebCore/PAL/Configurations/Version.xcconfig 2018-06-13 19:59:30 UTC (rev 232803) +++ trunk/Source/WebCore/PAL/Configurations/Version.xcconfig 2018-06-13 20:01:11 UTC (rev 232804) @@ -23,7 +23,7 @@ MAJOR_VERSION = 606; MINOR_VERSION = 1; -TINY_VERSION = 21; +TINY_VERSION = 22; MICRO_VERSION = 0; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); Modified: trunk/Source/WebInspectorUI/Configurations/Version.xcconfig (232803 => 232804) --- trunk/Source/WebInspectorUI/Configurations/Version.xcconfig 2018-06-13 19:59:30 UTC (rev 232803) +++ trunk/Source/WebInspectorUI/Configurations/Version.xcconfig 2018-06-13 20:01:11 UTC (rev 232804) @@ -1,6 +1,6 @@ MAJOR_VERSION = 606; MINOR_VERSION = 1; -TINY_VERSION = 21; +TINY_VERSION = 22; MICRO_VERSION = 0; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); Modified: trunk/Source/WebKit/Configurations/Version.xcconfig (232803 => 232804) --- trunk/Source/WebKit/Configurations/Version.xcconfig 2018-06-13 19:59:30 UTC (rev 232803) +++ trunk/Source/WebKit/Configurations/Version.xcconfig 2018-06-13 20:01:11 UTC (rev 232804) @@ -23,7 +23,7 @@ MAJOR_VERSION = 606; MINOR_VERSION = 1; -TINY_VERSION = 21; +TINY_VERSION = 22; MICRO_VERSION = 0; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); Modified: trunk/Source/WebKitLegacy/mac/Configurations/Version.xcconfig (232803 => 232804) --- trunk/Source/WebKitLegacy/mac/Configurations/Version.xcconfig 2018-06-13 19:59:30 UTC (rev 232803) +++ trunk/Source/WebKitLegacy/mac/Configurations/Version.xcconfig 2018-06-13 20:01:11 UTC (rev 232804) @@ -23,7 +23,7 @@ MAJOR_VERSION = 606; MINOR_VERSION = 1; -TINY_VERSION = 21; +TINY_VERSION = 22; MICRO_VERSION = 0; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [232803] tags/Safari-606.1.21/
Title: [232803] tags/Safari-606.1.21/ Revision 232803 Author kocsen_ch...@apple.com Date 2018-06-13 12:59:30 -0700 (Wed, 13 Jun 2018) Log Message Tag Safari-606.1.21. Added Paths tags/Safari-606.1.21/ Diff ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [232802] trunk
Title: [232802] trunk
Revision 232802
Author commit-qu...@webkit.org
Date 2018-06-13 12:10:16 -0700 (Wed, 13 Jun 2018)
Log Message
TileFirstPaint strategy for async image decoding should be disabled for non root RenderLayers
https://bugs.webkit.org/show_bug.cgi?id=186336
Patch by Said Abou-Hallawa on 2018-06-13
Reviewed by Simon Fraser.
Source/WebCore:
When showing a composited RenderLayer for the first time, the images in
this layer have to be decoded synchronously to avoid unwanted flashing.
To create a layout test for this patch, FrameDecodingDurationForTesting
needs to be generalized for large and animated images. The decoding thread
now forces the decoding time to be at least equal to
FrameDecodingDurationForTesting.
Test: fast/images/async-image-composited-show.html
* platform/graphics/BitmapImage.cpp:
(WebCore::BitmapImage::shouldUseAsyncDecodingForAnimatedImages const):
(WebCore::BitmapImage::internalStartAnimation):
(WebCore::BitmapImage::advanceAnimation):
* platform/graphics/BitmapImage.h:
* platform/graphics/ImageSource.cpp:
(WebCore::ImageSource::startAsyncDecodingQueue):
* platform/graphics/ImageSource.h:
(WebCore::ImageSource::setFrameDecodingDurationForTesting):
(WebCore::ImageSource::frameDecodingDurationForTesting const):
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::paintLayerContents):
LayoutTests:
* fast/images/async-image-composited-show-expected.html: Added.
* fast/images/async-image-composited-show.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/BitmapImage.cpp
trunk/Source/WebCore/platform/graphics/BitmapImage.h
trunk/Source/WebCore/platform/graphics/ImageSource.cpp
trunk/Source/WebCore/platform/graphics/ImageSource.h
trunk/Source/WebCore/rendering/RenderLayer.cpp
Added Paths
trunk/LayoutTests/fast/images/async-image-composited-show-expected.html
trunk/LayoutTests/fast/images/async-image-composited-show.html
Diff
Modified: trunk/LayoutTests/ChangeLog (232801 => 232802)
--- trunk/LayoutTests/ChangeLog 2018-06-13 19:07:22 UTC (rev 232801)
+++ trunk/LayoutTests/ChangeLog 2018-06-13 19:10:16 UTC (rev 232802)
@@ -1,3 +1,14 @@
+2018-06-13 Said Abou-Hallawa
+
+TileFirstPaint strategy for async image decoding should be disabled for non root RenderLayers
+https://bugs.webkit.org/show_bug.cgi?id=186336
+
+
+Reviewed by Simon Fraser.
+
+* fast/images/async-image-composited-show-expected.html: Added.
+* fast/images/async-image-composited-show.html: Added.
+
2018-06-13 Carlos Alberto Lopez Perez
[GTK] Mark some flaky tests and expected failures.
Added: trunk/LayoutTests/fast/images/async-image-composited-show-expected.html (0 => 232802)
--- trunk/LayoutTests/fast/images/async-image-composited-show-expected.html (rev 0)
+++ trunk/LayoutTests/fast/images/async-image-composited-show-expected.html 2018-06-13 19:10:16 UTC (rev 232802)
@@ -0,0 +1,16 @@
+
+
+
+
+.container {
+position: relative;
+width: 400px;
+height: 400px;
+background-color: green;
+}
+
+
+
+
+
+
Added: trunk/LayoutTests/fast/images/async-image-composited-show.html (0 => 232802)
--- trunk/LayoutTests/fast/images/async-image-composited-show.html (rev 0)
+++ trunk/LayoutTests/fast/images/async-image-composited-show.html 2018-06-13 19:10:16 UTC (rev 232802)
@@ -0,0 +1,52 @@
+
+.container {
+position: relative;
+width: 400px;
+height: 400px;
+background-color: #ff;
+}
+.composited {
+position: absolute;
+top: 0;
+left: 0;
+width: 100%;
+height: 100%;
+background-repeat: no-repeat;
+z-index: 0;
+}
+body {
+opacity: 0;
+background: rgba(0, 0, 0, 0);
+}
+body.background-loaded {
+opacity: 1;
+}
+
+
+
+
+
+
+if (window.testRunner) {
+internals.clearMemoryCache();
+internals.settings.setLargeImageAsyncDecodingEnabled(true);
+testRunner.waitUntilDone();
+}
+
+var image = new Image();
+image._onload_ = function() {
+// Force very long async image decoding for this image.
+if (window.internals)
+internals.setImageFrameDecodingDuration(image, 5000);
+
+// Change the background of the element.
+let element = document.querySelector(".composited");
+element.style.backgroundImage = 'url(' + image.src + ')';
+
+// Show the body element and end the test.
+document.body.classList.add("background-loaded");
+testRunner.notifyDone();
+};
+image.src = ""
+
+
Modified: trunk/Source/WebCore/ChangeLog (232801 => 232802)
--- trunk/Source/WebCore/ChangeLog 2018-06-13 19:07:22 UTC (rev
[webkit-changes] [232801] trunk/Source
Title: [232801] trunk/Source
Revision 232801
Author keith_mil...@apple.com
Date 2018-06-13 12:07:22 -0700 (Wed, 13 Jun 2018)
Log Message
AutomaticThread should have a way to provide a thread name
https://bugs.webkit.org/show_bug.cgi?id=186604
Reviewed by Filip Pizlo.
Source/_javascript_Core:
Add names for JSC's automatic threads.
* dfg/DFGWorklist.cpp:
* heap/Heap.cpp:
* jit/JITWorklist.cpp:
* runtime/VMTraps.cpp:
* wasm/WasmWorklist.cpp:
Source/WTF:
AutomaticThread now has a virtual method to get a name, which can be
overridden to provide a custom name to the thread.
* wtf/AutomaticThread.cpp:
(WTF::AutomaticThread::start):
* wtf/AutomaticThread.h:
* wtf/WorkerPool.cpp:
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/dfg/DFGWorklist.cpp
trunk/Source/_javascript_Core/heap/Heap.cpp
trunk/Source/_javascript_Core/jit/JITWorklist.cpp
trunk/Source/_javascript_Core/runtime/VMTraps.cpp
trunk/Source/_javascript_Core/wasm/WasmWorklist.cpp
trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/AutomaticThread.cpp
trunk/Source/WTF/wtf/AutomaticThread.h
trunk/Source/WTF/wtf/WorkerPool.cpp
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (232800 => 232801)
--- trunk/Source/_javascript_Core/ChangeLog 2018-06-13 19:04:10 UTC (rev 232800)
+++ trunk/Source/_javascript_Core/ChangeLog 2018-06-13 19:07:22 UTC (rev 232801)
@@ -1,3 +1,18 @@
+2018-06-13 Keith Miller
+
+AutomaticThread should have a way to provide a thread name
+https://bugs.webkit.org/show_bug.cgi?id=186604
+
+Reviewed by Filip Pizlo.
+
+Add names for JSC's automatic threads.
+
+* dfg/DFGWorklist.cpp:
+* heap/Heap.cpp:
+* jit/JITWorklist.cpp:
+* runtime/VMTraps.cpp:
+* wasm/WasmWorklist.cpp:
+
2018-06-13 Saam Barati
CFGSimplificationPhase should de-dupe jettisonedBlocks
Modified: trunk/Source/_javascript_Core/dfg/DFGWorklist.cpp (232800 => 232801)
--- trunk/Source/_javascript_Core/dfg/DFGWorklist.cpp 2018-06-13 19:04:10 UTC (rev 232800)
+++ trunk/Source/_javascript_Core/dfg/DFGWorklist.cpp 2018-06-13 19:07:22 UTC (rev 232801)
@@ -46,7 +46,12 @@
, m_relativePriority(relativePriority)
{
}
-
+
+const char* name() const override
+{
+return m_worklist.m_threadName.data();
+}
+
protected:
PollResult poll(const AbstractLocker& locker) override
{
@@ -160,7 +165,7 @@
m_compilationScope = nullptr;
m_plan = nullptr;
}
-
+
private:
Worklist& m_worklist;
ThreadData& m_data;
Modified: trunk/Source/_javascript_Core/heap/Heap.cpp (232800 => 232801)
--- trunk/Source/_javascript_Core/heap/Heap.cpp 2018-06-13 19:04:10 UTC (rev 232800)
+++ trunk/Source/_javascript_Core/heap/Heap.cpp 2018-06-13 19:07:22 UTC (rev 232801)
@@ -238,6 +238,11 @@
, m_heap(heap)
{
}
+
+const char* name() const override
+{
+return "JSC Heap Collector Thread";
+}
protected:
PollResult poll(const AbstractLocker& locker) override
Modified: trunk/Source/_javascript_Core/jit/JITWorklist.cpp (232800 => 232801)
--- trunk/Source/_javascript_Core/jit/JITWorklist.cpp 2018-06-13 19:04:10 UTC (rev 232800)
+++ trunk/Source/_javascript_Core/jit/JITWorklist.cpp 2018-06-13 19:07:22 UTC (rev 232801)
@@ -105,6 +105,11 @@
{
m_worklist.m_numAvailableThreads++;
}
+
+const char* name() const override
+{
+return "JIT Worklist Helper Thread";
+}
protected:
PollResult poll(const AbstractLocker&) override
Modified: trunk/Source/_javascript_Core/runtime/VMTraps.cpp (232800 => 232801)
--- trunk/Source/_javascript_Core/runtime/VMTraps.cpp 2018-06-13 19:04:10 UTC (rev 232800)
+++ trunk/Source/_javascript_Core/runtime/VMTraps.cpp 2018-06-13 19:07:22 UTC (rev 232801)
@@ -220,6 +220,11 @@
});
}
+const char* name() const override
+{
+return "JSC VMTraps Signal Sender Thread";
+}
+
VMTraps& traps() { return m_vm.traps(); }
protected:
Modified: trunk/Source/_javascript_Core/wasm/WasmWorklist.cpp (232800 => 232801)
--- trunk/Source/_javascript_Core/wasm/WasmWorklist.cpp 2018-06-13 19:04:10 UTC (rev 232800)
+++ trunk/Source/_javascript_Core/wasm/WasmWorklist.cpp 2018-06-13 19:07:22 UTC (rev 232801)
@@ -117,6 +117,11 @@
return complete(holdLock(*worklist.m_lock));
}
+const char* name() const override
+{
+return "Wasm Worklist Helper Thread";
+}
+
public:
Condition synchronize;
Worklist& worklist;
Modified: trunk/Source/WTF/ChangeLog (232800 => 232801)
--- trunk/Source/WTF/ChangeLog 2018-06-13 19:04:10 UTC (rev 232800)
+++ trunk/Source/WTF/ChangeLog 2018-06-13 19:07:22 UTC (rev 232801)
@@ -1,3 +1,18 @@
+2018-06-13 Keith Miller
+
+AutomaticThread should have a way to provide a thread name
+https://bugs.webkit.org/show_bug.cgi?id=186604
+
+Reviewed by Filip Pizlo.
+
+
[webkit-changes] [232800] trunk/Source/JavaScriptCore
Title: [232800] trunk/Source/_javascript_Core
Revision 232800
Author sbar...@apple.com
Date 2018-06-13 12:04:10 -0700 (Wed, 13 Jun 2018)
Log Message
CFGSimplificationPhase should de-dupe jettisonedBlocks
https://bugs.webkit.org/show_bug.cgi?id=186583
Reviewed by Filip Pizlo.
When making the predecessors list unique in r232741, it revealed a bug inside
of CFG simplification, where we try to remove the same predecessor more than
once from a blocks predecessors list. We built the list of blocks to remove
from the list of successors, which is not unique, causing us to try to remove
the same predecessor more than once. The solution here is to just add to this
list of blocks to remove only if the block is not already in the list.
* dfg/DFGCFGSimplificationPhase.cpp:
(JSC::DFG::CFGSimplificationPhase::run):
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/dfg/DFGCFGSimplificationPhase.cpp
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (232799 => 232800)
--- trunk/Source/_javascript_Core/ChangeLog 2018-06-13 18:51:17 UTC (rev 232799)
+++ trunk/Source/_javascript_Core/ChangeLog 2018-06-13 19:04:10 UTC (rev 232800)
@@ -1,3 +1,20 @@
+2018-06-13 Saam Barati
+
+CFGSimplificationPhase should de-dupe jettisonedBlocks
+https://bugs.webkit.org/show_bug.cgi?id=186583
+
+Reviewed by Filip Pizlo.
+
+When making the predecessors list unique in r232741, it revealed a bug inside
+of CFG simplification, where we try to remove the same predecessor more than
+once from a blocks predecessors list. We built the list of blocks to remove
+from the list of successors, which is not unique, causing us to try to remove
+the same predecessor more than once. The solution here is to just add to this
+list of blocks to remove only if the block is not already in the list.
+
+* dfg/DFGCFGSimplificationPhase.cpp:
+(JSC::DFG::CFGSimplificationPhase::run):
+
2018-06-13 Yusuke Suzuki
[JSC] Always use Nuke & Set procedure for x86
Modified: trunk/Source/_javascript_Core/dfg/DFGCFGSimplificationPhase.cpp (232799 => 232800)
--- trunk/Source/_javascript_Core/dfg/DFGCFGSimplificationPhase.cpp 2018-06-13 18:51:17 UTC (rev 232799)
+++ trunk/Source/_javascript_Core/dfg/DFGCFGSimplificationPhase.cpp 2018-06-13 19:04:10 UTC (rev 232800)
@@ -182,7 +182,7 @@
Vector jettisonedBlocks;
for (BasicBlock* successor : terminal->successors()) {
-if (successor != targetBlock)
+if (successor != targetBlock && !jettisonedBlocks.contains(successor))
jettisonedBlocks.append(successor);
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [232799] trunk/Source/WebCore
Title: [232799] trunk/Source/WebCore
Revision 232799
Author wenson_hs...@apple.com
Date 2018-06-13 11:51:17 -0700 (Wed, 13 Jun 2018)
Log Message
CSS "background-color" style no longer affects natively rendered text fields
https://bugs.webkit.org/show_bug.cgi?id=186597
Reviewed by Tim Horton.
AppKit currently does not support rendering background color to the edges of a text field cell. This means that
in WebCore, when natively rendering text inputs with background color, we need to only draw the bezels of a text
field, such that the background color we paint behind the text field will be shown. Currently, the way we
accomplish this is by intercepting an internal NSTextField method that computes drawing options for CoreUI, and
inserting a `"borders only" => true` entry.
However, in a recent build of macOS Mojave, AppKit tweaked -_coreUIDrawOptionsWithFrame:inView:includeFocus: to
add an extra argument (such that it's now -_coreUIDrawOptionsWithFrame:inView:includeFocus:maskOnly:), which
negates the above workaround. To fix this in the short term, augment the workaround to apply to the latest macOS
Mojave as well. A longer-term fix is already tracked in , which would allow WebKit to
simply specify a background color on the text field cell, and have AppKit render it properly to the edges of the
bezels.
Covered by a test that is currently failing on Mojave: fast/forms/hidpi-textfield-background-bleeding.html
* rendering/RenderThemeMac.mm:
(-[WebCoreTextFieldCell _adjustedCoreUIDrawOptionsForDrawingBordersOnly:]):
(-[WebCoreTextFieldCell _coreUIDrawOptionsWithFrame:inView:includeFocus:]):
(-[WebCoreTextFieldCell _coreUIDrawOptionsWithFrame:inView:includeFocus:maskOnly:]):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderThemeMac.mm
Diff
Modified: trunk/Source/WebCore/ChangeLog (232798 => 232799)
--- trunk/Source/WebCore/ChangeLog 2018-06-13 18:32:56 UTC (rev 232798)
+++ trunk/Source/WebCore/ChangeLog 2018-06-13 18:51:17 UTC (rev 232799)
@@ -1,3 +1,31 @@
+2018-06-13 Wenson Hsieh
+
+CSS "background-color" style no longer affects natively rendered text fields
+https://bugs.webkit.org/show_bug.cgi?id=186597
+
+
+Reviewed by Tim Horton.
+
+AppKit currently does not support rendering background color to the edges of a text field cell. This means that
+in WebCore, when natively rendering text inputs with background color, we need to only draw the bezels of a text
+field, such that the background color we paint behind the text field will be shown. Currently, the way we
+accomplish this is by intercepting an internal NSTextField method that computes drawing options for CoreUI, and
+inserting a `"borders only" => true` entry.
+
+However, in a recent build of macOS Mojave, AppKit tweaked -_coreUIDrawOptionsWithFrame:inView:includeFocus: to
+add an extra argument (such that it's now -_coreUIDrawOptionsWithFrame:inView:includeFocus:maskOnly:), which
+negates the above workaround. To fix this in the short term, augment the workaround to apply to the latest macOS
+Mojave as well. A longer-term fix is already tracked in , which would allow WebKit to
+simply specify a background color on the text field cell, and have AppKit render it properly to the edges of the
+bezels.
+
+Covered by a test that is currently failing on Mojave: fast/forms/hidpi-textfield-background-bleeding.html
+
+* rendering/RenderThemeMac.mm:
+(-[WebCoreTextFieldCell _adjustedCoreUIDrawOptionsForDrawingBordersOnly:]):
+(-[WebCoreTextFieldCell _coreUIDrawOptionsWithFrame:inView:includeFocus:]):
+(-[WebCoreTextFieldCell _coreUIDrawOptionsWithFrame:inView:includeFocus:maskOnly:]):
+
2018-06-13 Thibault Saunier
[WPE] Build getUserMedia support
Modified: trunk/Source/WebCore/rendering/RenderThemeMac.mm (232798 => 232799)
--- trunk/Source/WebCore/rendering/RenderThemeMac.mm 2018-06-13 18:32:56 UTC (rev 232798)
+++ trunk/Source/WebCore/rendering/RenderThemeMac.mm 2018-06-13 18:51:17 UTC (rev 232799)
@@ -115,6 +115,7 @@
// FIXME: This should go into an SPI.h file in the spi directory.
@interface NSTextFieldCell ()
- (CFDictionaryRef)_coreUIDrawOptionsWithFrame:(NSRect)cellFrame inView:(NSView *)controlView includeFocus:(BOOL)includeFocus;
+- (CFDictionaryRef)_coreUIDrawOptionsWithFrame:(NSRect)cellFrame inView:(NSView *)controlView includeFocus:(BOOL)includeFocus maskOnly:(BOOL)maskOnly;
@end
// FIXME: This should go into an SPI.h file in the spi directory.
@@ -153,15 +154,26 @@
@implementation WebCoreTextFieldCell
-- (CFDictionaryRef)_coreUIDrawOptionsWithFrame:(NSRect)cellFrame inView:(NSView *)controlView includeFocus:(BOOL)includeFocus
+- (CFDictionaryRef)_adjustedCoreUIDrawOptionsForDrawingBordersOnly:(CFDictionaryRef)defaultOptions
{
-// FIXME: This is a workaround for . When that bug is resolved, we should
[webkit-changes] [232798] trunk/Source/JavaScriptCore
Title: [232798] trunk/Source/_javascript_Core
Revision 232798
Author utatane@gmail.com
Date 2018-06-13 11:32:56 -0700 (Wed, 13 Jun 2018)
Log Message
[JSC] Always use Nuke & Set procedure for x86
https://bugs.webkit.org/show_bug.cgi?id=186592
Reviewed by Keith Miller.
We always use nukeStructureAndStoreButterfly for Contiguous -> ArrayStorage conversion if the architecture is x86.
By doing so, we can concurrently load structure and butterfly at least in x86 environment even in non-collector
threads.
* runtime/JSObject.cpp:
(JSC::JSObject::convertContiguousToArrayStorage):
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/runtime/JSObject.cpp
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (232797 => 232798)
--- trunk/Source/_javascript_Core/ChangeLog 2018-06-13 18:29:16 UTC (rev 232797)
+++ trunk/Source/_javascript_Core/ChangeLog 2018-06-13 18:32:56 UTC (rev 232798)
@@ -1,3 +1,17 @@
+2018-06-13 Yusuke Suzuki
+
+[JSC] Always use Nuke & Set procedure for x86
+https://bugs.webkit.org/show_bug.cgi?id=186592
+
+Reviewed by Keith Miller.
+
+We always use nukeStructureAndStoreButterfly for Contiguous -> ArrayStorage conversion if the architecture is x86.
+By doing so, we can concurrently load structure and butterfly at least in x86 environment even in non-collector
+threads.
+
+* runtime/JSObject.cpp:
+(JSC::JSObject::convertContiguousToArrayStorage):
+
2018-06-12 Saam Barati
Remove JSVirtualMachine shrinkFootprint when clients move to shrinkFootprintWhenIdle
Modified: trunk/Source/_javascript_Core/runtime/JSObject.cpp (232797 => 232798)
--- trunk/Source/_javascript_Core/runtime/JSObject.cpp 2018-06-13 18:29:16 UTC (rev 232797)
+++ trunk/Source/_javascript_Core/runtime/JSObject.cpp 2018-06-13 18:32:56 UTC (rev 232798)
@@ -1344,7 +1344,9 @@
newStorage->m_numValuesInVector++;
}
-Structure* newStructure = Structure::nonPropertyTransition(vm, structure(vm), transition);
+StructureID oldStructureID = this->structureID();
+Structure* oldStructure = vm.getStructure(oldStructureID);
+Structure* newStructure = Structure::nonPropertyTransition(vm, oldStructure, transition);
// This has a crazy race with the garbage collector. When changing the butterfly and structure,
// the mutator always sets the structure last. The collector will always read the structure
@@ -1357,19 +1359,13 @@
// because it will fail to decode two consecutive int32s as if it was a JSValue.
//
// Fortunately, we have the JSCell lock for this purpose!
+
+Locker locker(NoLockingNecessary);
+if (vm.heap.mutatorShouldBeFenced())
+locker = holdLock(cellLock());
+nukeStructureAndSetButterfly(vm, oldStructureID, newStorage->butterfly());
+setStructure(vm, newStructure);
-if (vm.heap.mutatorShouldBeFenced()) {
-auto locker = holdLock(cellLock());
-setStructureIDDirectly(nuke(structureID()));
-WTF::storeStoreFence();
-m_butterfly.set(vm, this, newStorage->butterfly());
-WTF::storeStoreFence();
-setStructure(vm, newStructure);
-} else {
-m_butterfly.set(vm, this, newStorage->butterfly());
-setStructure(vm, newStructure);
-}
-
return newStorage;
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [232797] trunk/LayoutTests
Title: [232797] trunk/LayoutTests Revision 232797 Author clo...@igalia.com Date 2018-06-13 11:29:16 -0700 (Wed, 13 Jun 2018) Log Message [GTK] Mark some flaky tests and expected failures. Unreviewed test gardening. * platform/gtk/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/gtk/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (232796 => 232797) --- trunk/LayoutTests/ChangeLog 2018-06-13 18:22:40 UTC (rev 232796) +++ trunk/LayoutTests/ChangeLog 2018-06-13 18:29:16 UTC (rev 232797) @@ -1,3 +1,11 @@ +2018-06-13 Carlos Alberto Lopez Perez + +[GTK] Mark some flaky tests and expected failures. + +Unreviewed test gardening. + +* platform/gtk/TestExpectations: + 2018-06-13 Thibault Saunier [WPE] Build getUserMedia support Modified: trunk/LayoutTests/platform/gtk/TestExpectations (232796 => 232797) --- trunk/LayoutTests/platform/gtk/TestExpectations 2018-06-13 18:22:40 UTC (rev 232796) +++ trunk/LayoutTests/platform/gtk/TestExpectations 2018-06-13 18:29:16 UTC (rev 232797) @@ -1163,6 +1163,8 @@ # Font collections webkit.org/b/186086 fast/text/font-collection.html [ ImageOnlyFailure ] +webkit.org/b/186601 fullscreen/full-screen-layer-dump.html [ Failure ] + # # End of Expected failures. # @@ -1920,6 +1922,9 @@ webkit.org/b/184569 storage/indexeddb/modern/transactions-stop-on-navigation.html [ Pass Failure ] +webkit.org/b/186598 http/tests/media/hls/hls-audio-tracks.html [ Timeout Pass ] +webkit.org/b/186598 http/tests/media/hls/hls-audio-tracks-has-audio.html [ Timeout Pass ] + # # End of Flaky tests # @@ -2254,7 +2259,7 @@ webkit.org/b/186253 http/tests/security/contentSecurityPolicy/media-src-allowed.html [ Timeout ] webkit.org/b/186341 fast/animation/css-animation-resuming-when-visible-with-style-change.html [ Timeout Failure ] -webkit.org/b/186252 legacy-animation-engine/css3/filters/backdrop/animation.html [ Failure ] +webkit.org/b/186252 legacy-animation-engine/css3/filters/backdrop/animation.html [ Timeout ] # # End of Tests timing out ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [232796] trunk
Title: [232796] trunk Revision 232796 Author commit-qu...@webkit.org Date 2018-06-13 11:22:40 -0700 (Wed, 13 Jun 2018) Log Message [WPE] Build getUserMedia support https://bugs.webkit.org/show_bug.cgi?id=186547 Patch by Thibault Saunier on 2018-06-13 Reviewed by Alejandro G. Castro. .: * Source/cmake/OptionsWPE.cmake: Build MediaStream support Source/WebCore: Enable mediastream tests. * PlatformWPE.cmake: Build MediaStream support. * SourcesGTK.txt: Moved GStreamer related files to GStreamer.cmake. * SourcesWPE.txt: Removed `platform/mediastream/libwebrtc/LibWebRTCProviderGlib.cpp` which is now in GStreamer.cmake. * platform/GStreamer.cmake: Build more MediaStream/webrtc related files. * platform/graphics/ImageBuffer.cpp: Handle the fact that toBGRAData is now built directly into the Cairo backend and not GTK anymore. * platform/graphics/cairo/ImageBufferCairo.cpp: Implement `toBGRAData` * platform/graphics/gtk/ImageBufferGtk.cpp: Removed `toBGRAData` as it is now implemented in the Cairo backend itself. * platform/mediastream/gstreamer/GStreamerMediaStreamSource.cpp: Switch an ASSERT to RELEASE_ASSERT when adding the GhostPad to itself. This was making test fail when built in RELEASE mode. (WebCore::webkitMediaStreamSrcChain): Minor variable name change to make it more accurate. (WebCore::webkitMediaStreamSrcAddPad): Now add the ghost pad to the element before setting its chain function, making things clearer. (WebCore::webkitMediaStreamSrcSetupSrc): Remove extra new line. Source/WebKit: * SourcesWPE.txt: Compile files necessary for MediaStream/webrtc. LayoutTests: * platform/gtk/TestExpectations: Mark some tests as potentially passing (they fail only when built in debug mode). * platform/wpe/TestExpectations: Enable MediaStream tests. Modified Paths trunk/ChangeLog trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/gtk/TestExpectations trunk/LayoutTests/platform/wpe/TestExpectations trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/PlatformWPE.cmake trunk/Source/WebCore/SourcesGTK.txt trunk/Source/WebCore/SourcesWPE.txt trunk/Source/WebCore/platform/GStreamer.cmake trunk/Source/WebCore/platform/graphics/ImageBuffer.cpp trunk/Source/WebCore/platform/graphics/cairo/ImageBufferCairo.cpp trunk/Source/WebCore/platform/graphics/gtk/ImageBufferGtk.cpp trunk/Source/WebCore/platform/mediastream/gstreamer/GStreamerMediaStreamSource.cpp trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/SourcesWPE.txt trunk/Source/cmake/OptionsWPE.cmake trunk/Tools/wpe/install-dependencies Diff Modified: trunk/ChangeLog (232795 => 232796) --- trunk/ChangeLog 2018-06-13 17:58:05 UTC (rev 232795) +++ trunk/ChangeLog 2018-06-13 18:22:40 UTC (rev 232796) @@ -1,3 +1,12 @@ +2018-06-13 Thibault Saunier + +[WPE] Build getUserMedia support +https://bugs.webkit.org/show_bug.cgi?id=186547 + +Reviewed by Alejandro G. Castro. + +* Source/cmake/OptionsWPE.cmake: Build MediaStream support + 2018-06-12 Philippe Normand [GStreamer] Bump required version to 1.8.3 Modified: trunk/LayoutTests/ChangeLog (232795 => 232796) --- trunk/LayoutTests/ChangeLog 2018-06-13 17:58:05 UTC (rev 232795) +++ trunk/LayoutTests/ChangeLog 2018-06-13 18:22:40 UTC (rev 232796) @@ -1,3 +1,14 @@ +2018-06-13 Thibault Saunier + +[WPE] Build getUserMedia support +https://bugs.webkit.org/show_bug.cgi?id=186547 + +Reviewed by Alejandro G. Castro. + +* platform/gtk/TestExpectations: Mark some tests as potentially passing (they fail only +when built in debug mode). +* platform/wpe/TestExpectations: Enable MediaStream tests. + 2018-06-13 Ms2ger Update expectations for WebCryptoAPI generateKey tests Modified: trunk/LayoutTests/platform/gtk/TestExpectations (232795 => 232796) --- trunk/LayoutTests/platform/gtk/TestExpectations 2018-06-13 17:58:05 UTC (rev 232795) +++ trunk/LayoutTests/platform/gtk/TestExpectations 2018-06-13 18:22:40 UTC (rev 232796) @@ -581,7 +581,7 @@ webkit.org/b/79203 fast/mediastream/MediaStream-video-element-track-stop.html [ Timeout ] webkit.org/b/79203 fast/mediastream/RTCPeerConnection-dtmf.html [ Timeout ] webkit.org/b/79203 fast/mediastream/RTCPeerConnection-icecandidate-event.html [ Failure Crash ] -webkit.org/b/79203 fast/mediastream/RTCPeerConnection-media-setup-two-dialogs.html [ Failure Crash ] +webkit.org/b/79203 fast/mediastream/RTCPeerConnection-media-setup-two-dialogs.html [ Pass Failure Crash ] webkit.org/b/79203 fast/mediastream/RTCRtpSender-replaceTrack.html [ Failure ] # Crash is webkit.org/b/184292 webkit.org/b/79203 fast/mediastream/RTCPeerConnection-addIceCandidate.html [ Failure Pass Crash ] @@ -591,7 +591,7 @@ webkit.org/b/79203 fast/mediastream/RTCPeerConnection-inspect-offer-bundlePolicy-bundle-only.html [ Failure ] webkit.org/b/79203 fast/mediastream/RTCPeerConnection-inspect-offer.html [ Failure ] webkit.org/b/79203
[webkit-changes] [232795] trunk/Source/WebCore
Title: [232795] trunk/Source/WebCore
Revision 232795
Author ph...@webkit.org
Date 2018-06-13 10:58:05 -0700 (Wed, 13 Jun 2018)
Log Message
[GStreamer] fast/canvas/webgl crashes
https://bugs.webkit.org/show_bug.cgi?id=186590
Reviewed by Carlos Alberto Lopez Perez.
After r232747 the sample managed by the player can be empty,
without buffer. So we need to check for this before mapping video
frames. Also use the GstVideoFrameHolder in more places to reduce
copy-paste churn.
* platform/graphics/gstreamer/ImageGStreamer.h:
* platform/graphics/gstreamer/ImageGStreamerCairo.cpp:
(ImageGStreamer::ImageGStreamer):
(ImageGStreamer::~ImageGStreamer):
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:
(WebCore::GstVideoFrameHolder::GstVideoFrameHolder):
(WebCore::MediaPlayerPrivateGStreamerBase::copyVideoTextureToPlatformTexture):
(WebCore::MediaPlayerPrivateGStreamerBase::nativeImageForCurrentTime):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/gstreamer/ImageGStreamer.h
trunk/Source/WebCore/platform/graphics/gstreamer/ImageGStreamerCairo.cpp
trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (232794 => 232795)
--- trunk/Source/WebCore/ChangeLog 2018-06-13 17:06:30 UTC (rev 232794)
+++ trunk/Source/WebCore/ChangeLog 2018-06-13 17:58:05 UTC (rev 232795)
@@ -1,5 +1,26 @@
2018-06-13 Philippe Normand
+[GStreamer] fast/canvas/webgl crashes
+https://bugs.webkit.org/show_bug.cgi?id=186590
+
+Reviewed by Carlos Alberto Lopez Perez.
+
+After r232747 the sample managed by the player can be empty,
+without buffer. So we need to check for this before mapping video
+frames. Also use the GstVideoFrameHolder in more places to reduce
+copy-paste churn.
+
+* platform/graphics/gstreamer/ImageGStreamer.h:
+* platform/graphics/gstreamer/ImageGStreamerCairo.cpp:
+(ImageGStreamer::ImageGStreamer):
+(ImageGStreamer::~ImageGStreamer):
+* platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:
+(WebCore::GstVideoFrameHolder::GstVideoFrameHolder):
+(WebCore::MediaPlayerPrivateGStreamerBase::copyVideoTextureToPlatformTexture):
+(WebCore::MediaPlayerPrivateGStreamerBase::nativeImageForCurrentTime):
+
+2018-06-13 Philippe Normand
+
Unreviewed GTK build fix for --cmakeargs=-DUSE_GSTREAMER_GL=OFF
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
Modified: trunk/Source/WebCore/platform/graphics/gstreamer/ImageGStreamer.h (232794 => 232795)
--- trunk/Source/WebCore/platform/graphics/gstreamer/ImageGStreamer.h 2018-06-13 17:06:30 UTC (rev 232794)
+++ trunk/Source/WebCore/platform/graphics/gstreamer/ImageGStreamer.h 2018-06-13 17:58:05 UTC (rev 232795)
@@ -63,9 +63,9 @@
ImageGStreamer(GstSample*);
RefPtr m_image;
FloatRect m_cropRect;
-
#if USE(CAIRO)
GstVideoFrame m_videoFrame;
+bool m_frameMapped { false };
#endif
};
}
Modified: trunk/Source/WebCore/platform/graphics/gstreamer/ImageGStreamerCairo.cpp (232794 => 232795)
--- trunk/Source/WebCore/platform/graphics/gstreamer/ImageGStreamerCairo.cpp 2018-06-13 17:06:30 UTC (rev 232794)
+++ trunk/Source/WebCore/platform/graphics/gstreamer/ImageGStreamerCairo.cpp 2018-06-13 17:58:05 UTC (rev 232795)
@@ -43,9 +43,13 @@
ASSERT(GST_VIDEO_INFO_N_PLANES() == 1);
GstBuffer* buffer = gst_sample_get_buffer(sample);
-if (!gst_video_frame_map(_videoFrame, , buffer, GST_MAP_READ))
+if (UNLIKELY(!GST_IS_BUFFER(buffer)))
return;
+m_frameMapped = gst_video_frame_map(_videoFrame, , buffer, GST_MAP_READ);
+if (!m_frameMapped)
+return;
+
unsigned char* bufferData = reinterpret_cast(GST_VIDEO_FRAME_PLANE_DATA(_videoFrame, 0));
int stride = GST_VIDEO_FRAME_PLANE_STRIDE(_videoFrame, 0);
int width = GST_VIDEO_FRAME_WIDTH(_videoFrame);
@@ -110,6 +114,7 @@
// We keep the buffer memory mapped until the image is destroyed because the internal
// cairo_surface_t was created using cairo_image_surface_create_for_data().
-gst_video_frame_unmap(_videoFrame);
+if (m_frameMapped)
+gst_video_frame_unmap(_videoFrame);
}
#endif // USE(GSTREAMER)
Modified: trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp (232794 => 232795)
--- trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp 2018-06-13 17:06:30 UTC (rev 232794)
+++ trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp 2018-06-13 17:58:05 UTC (rev 232795)
@@ -211,6 +211,8 @@
m_size = IntSize(GST_VIDEO_INFO_WIDTH(), GST_VIDEO_INFO_HEIGHT());
m_hasAlphaChannel = GST_VIDEO_INFO_HAS_ALPHA();
m_buffer = gst_sample_get_buffer(sample);
+if (UNLIKELY(!GST_IS_BUFFER(m_buffer)))
+
[webkit-changes] [232794] trunk/Source/WebKit
Title: [232794] trunk/Source/WebKit
Revision 232794
Author aes...@apple.com
Date 2018-06-13 10:06:30 -0700 (Wed, 13 Jun 2018)
Log Message
[iOS] Synchronize PDF resizing with device rotation
https://bugs.webkit.org/show_bug.cgi?id=186587
Reviewed by Darin Adler.
Both -beginPDFViewRotation and -endPDFViewRotation need to be called as part of
the transition coordinator's -animateAlongsideTransition: block to be synchronized
with rotation. Additionally, updateBlock needs to be invoked between the two calls
so that PDFKit can capture the frame geometry before and after the update.
* UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _beginAnimatedResizeWithUpdates:]):
* UIProcess/Cocoa/WKWebViewContentProvider.h:
* UIProcess/ios/WKPDFView.mm:
(-[WKPDFView web_beginAnimatedResizeWithUpdates:]):
(-[WKPDFView web_beginAnimatedResize]): Renamed to web_beginAnimatedResizeWithUpdates:.
(-[WKPDFView web_endAnimatedResize]): Deleted.
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm
trunk/Source/WebKit/UIProcess/Cocoa/WKWebViewContentProvider.h
trunk/Source/WebKit/UIProcess/ios/WKPDFView.mm
Diff
Modified: trunk/Source/WebKit/ChangeLog (232793 => 232794)
--- trunk/Source/WebKit/ChangeLog 2018-06-13 16:35:07 UTC (rev 232793)
+++ trunk/Source/WebKit/ChangeLog 2018-06-13 17:06:30 UTC (rev 232794)
@@ -1,3 +1,24 @@
+2018-06-13 Andy Estes
+
+[iOS] Synchronize PDF resizing with device rotation
+https://bugs.webkit.org/show_bug.cgi?id=186587
+
+
+Reviewed by Darin Adler.
+
+Both -beginPDFViewRotation and -endPDFViewRotation need to be called as part of
+the transition coordinator's -animateAlongsideTransition: block to be synchronized
+with rotation. Additionally, updateBlock needs to be invoked between the two calls
+so that PDFKit can capture the frame geometry before and after the update.
+
+* UIProcess/API/Cocoa/WKWebView.mm:
+(-[WKWebView _beginAnimatedResizeWithUpdates:]):
+* UIProcess/Cocoa/WKWebViewContentProvider.h:
+* UIProcess/ios/WKPDFView.mm:
+(-[WKPDFView web_beginAnimatedResizeWithUpdates:]):
+(-[WKPDFView web_beginAnimatedResize]): Renamed to web_beginAnimatedResizeWithUpdates:.
+(-[WKPDFView web_endAnimatedResize]): Deleted.
+
2018-06-12 Brent Fulgham
Turn CSS Spring Animations and Link Preload off by default for production builds.
Modified: trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm (232793 => 232794)
--- trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm 2018-06-13 16:35:07 UTC (rev 232793)
+++ trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm 2018-06-13 17:06:30 UTC (rev 232794)
@@ -5235,9 +5235,10 @@
WebCore::FloatRect oldUnobscuredContentRect = _page->unobscuredContentRect();
if (![self usesStandardContentView] || !_hasCommittedLoadForMainFrame || CGRectIsEmpty(oldBounds) || oldUnobscuredContentRect.isEmpty()) {
-updateBlock();
-if ([_customContentView respondsToSelector:@selector(web_beginAnimatedResize)])
-[_customContentView web_beginAnimatedResize];
+if ([_customContentView respondsToSelector:@selector(web_beginAnimatedResizeWithUpdates:)])
+[_customContentView web_beginAnimatedResizeWithUpdates:updateBlock];
+else
+updateBlock();
return;
}
@@ -5358,9 +5359,6 @@
{
LOG_WITH_STREAM(VisibleRects, stream << "-[WKWebView " << _page->pageID() << " _endAnimatedResize:] " << " _dynamicViewportUpdateMode " << (int)_dynamicViewportUpdateMode);
-if ([_customContentView respondsToSelector:@selector(web_endAnimatedResize)])
-[_customContentView web_endAnimatedResize];
-
// If we already have an up-to-date layer tree, immediately complete
// the resize. Otherwise, we will defer completion until we do.
_waitingForEndAnimatedResize = NO;
Modified: trunk/Source/WebKit/UIProcess/Cocoa/WKWebViewContentProvider.h (232793 => 232794)
--- trunk/Source/WebKit/UIProcess/Cocoa/WKWebViewContentProvider.h 2018-06-13 16:35:07 UTC (rev 232793)
+++ trunk/Source/WebKit/UIProcess/Cocoa/WKWebViewContentProvider.h 2018-06-13 17:06:30 UTC (rev 232794)
@@ -59,8 +59,7 @@
- (void)web_scrollViewWillBeginZooming:(UIScrollView *)scrollView withView:(UIView *)view;
- (void)web_scrollViewDidEndZooming:(UIScrollView *)scrollView withView:(UIView *)view atScale:(CGFloat)scale;
- (void)web_scrollViewDidZoom:(UIScrollView *)scrollView;
-- (void)web_beginAnimatedResize;
-- (void)web_endAnimatedResize;
+- (void)web_beginAnimatedResizeWithUpdates:(void (^)(void))updateBlock;
@property (nonatomic, readonly) NSData *web_dataRepresentation;
@property (nonatomic, readonly) NSString *web_suggestedFilename;
@property (nonatomic, readonly) BOOL web_isBackground;
Modified: trunk/Source/WebKit/UIProcess/ios/WKPDFView.mm (232793 => 232794)
--- trunk/Source/WebKit/UIProcess/ios/WKPDFView.mm 2018-06-13
[webkit-changes] [232792] trunk/LayoutTests
Title: [232792] trunk/LayoutTests Revision 232792 Author pvol...@apple.com Date 2018-06-13 09:16:35 -0700 (Wed, 13 Jun 2018) Log Message A few layout tests are failing on Windows. https://bugs.webkit.org/show_bug.cgi?id=186562 Unreviewed test gardening. * platform/win/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/win/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (232791 => 232792) --- trunk/LayoutTests/ChangeLog 2018-06-13 15:46:27 UTC (rev 232791) +++ trunk/LayoutTests/ChangeLog 2018-06-13 16:16:35 UTC (rev 232792) @@ -1,3 +1,12 @@ +2018-06-13 Per Arne Vollan + +A few layout tests are failing on Windows. +https://bugs.webkit.org/show_bug.cgi?id=186562 + +Unreviewed test gardening. + +* platform/win/TestExpectations: + 2018-06-12 Zalan Bujtas Complex text handling should opt out of bounded text layout. Modified: trunk/LayoutTests/platform/win/TestExpectations (232791 => 232792) --- trunk/LayoutTests/platform/win/TestExpectations 2018-06-13 15:46:27 UTC (rev 232791) +++ trunk/LayoutTests/platform/win/TestExpectations 2018-06-13 16:16:35 UTC (rev 232792) @@ -2948,7 +2948,7 @@ [ Release ] fast/images/animated-gif-webkit-transform.html [ Skip ] # Timeout [ Release ] fast/repaint/animation-after-layer-scroll.html [ Pass Failure ] [ Release ] fast/text/international/float-as-only-child-of-isolate-crash.html [ Pass Failure ] -[ Release ] js/slow-stress/emscripten-memops.html [ Pass Failure ] +[ Release ] js/slow-stress/emscripten-memops.html [ Skip ] # Timeout [ Release ] js/slow-stress/fold-strict-eq.html [ Skip ] # Crashes on EWS [ Release ] inspector/layers/layers-anonymous.html [ Skip ] # Timeouts [ Release ] inspector/layers/layers-blending-compositing-reasons.html [ Skip ] # Timeouts @@ -4114,5 +4114,4 @@ webkit.org/b/186562 js/dom/line-column-numbers.html [ Failure ] webkit.org/b/186562 storage/indexeddb/modern/leak-1.html [ Failure ] webkit.org/b/186562 svg/animations/animation-leak-list-property-instances.html [ Failure ] -webkit.org/b/186562 js/slow-stress/emscripten-memops.html [ Skip ] webkit.org/b/186562 workers/bomb.html [ Skip ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [232791] trunk/Source/WebCore
Title: [232791] trunk/Source/WebCore
Revision 232791
Author ph...@webkit.org
Date 2018-06-13 08:46:27 -0700 (Wed, 13 Jun 2018)
Log Message
Unreviewed GTK build fix for --cmakeargs=-DUSE_GSTREAMER_GL=OFF
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::load):
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:
(WebCore::MediaPlayerPrivateGStreamerBase::pushTextureToCompositor):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp
trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (232790 => 232791)
--- trunk/Source/WebCore/ChangeLog 2018-06-13 13:39:13 UTC (rev 232790)
+++ trunk/Source/WebCore/ChangeLog 2018-06-13 15:46:27 UTC (rev 232791)
@@ -1,3 +1,12 @@
+2018-06-13 Philippe Normand
+
+Unreviewed GTK build fix for --cmakeargs=-DUSE_GSTREAMER_GL=OFF
+
+* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
+(WebCore::MediaPlayerPrivateGStreamer::load):
+* platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:
+(WebCore::MediaPlayerPrivateGStreamerBase::pushTextureToCompositor):
+
2018-06-12 Philippe Normand
[GStreamer] Video freezes when GStreamerGL is not installed
Modified: trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp (232790 => 232791)
--- trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp 2018-06-13 13:39:13 UTC (rev 232790)
+++ trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp 2018-06-13 15:46:27 UTC (rev 232791)
@@ -306,7 +306,9 @@
#if GST_CHECK_VERSION(1, 10, 0)
m_streamPrivate =
loadFull(String("mediastream://") + stream.id(), "playbin3");
+#if USE(GSTREAMER_GL)
ensureGLVideoSinkContext();
+#endif
m_player->play();
#else
// Properly fail so the global MediaPlayer tries to fallback to the next MediaPlayerPrivate.
Modified: trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp (232790 => 232791)
--- trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp 2018-06-13 13:39:13 UTC (rev 232790)
+++ trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp 2018-06-13 15:46:27 UTC (rev 232791)
@@ -53,6 +53,10 @@
#include "WebKitClearKeyDecryptorGStreamer.h"
#endif
+#if ENABLE(MEDIA_STREAM) && GST_CHECK_VERSION(1, 10, 0)
+#include "GStreamerMediaStreamSource.h"
+#endif
+
#if USE(GSTREAMER_GL)
#if G_BYTE_ORDER == G_LITTLE_ENDIAN
#define GST_GL_CAPS_FORMAT "{ BGRx, BGRA }"
@@ -81,10 +85,6 @@
#endif // !GST_CHECK_VERSION(1, 14, 0)
#endif // USE(LIBEPOXY)
-#if ENABLE(MEDIA_STREAM) && GST_CHECK_VERSION(1, 10, 0)
-#include "GStreamerMediaStreamSource.h"
-#endif
-
#define GST_USE_UNSTABLE_API
#include
#undef GST_USE_UNSTABLE_API
@@ -756,12 +756,15 @@
std::unique_ptr frameHolder = std::make_unique(m_sample.get(), texMapFlagFromOrientation(m_videoSourceOrientation), !m_usingFallbackVideoSink);
+#if USE(GSTREAMER_GL)
GLuint textureID = frameHolder->textureID();
if (textureID) {
std::unique_ptr layerBuffer = std::make_unique(textureID, frameHolder->size(), frameHolder->flags(), GraphicsContext3D::RGBA);
layerBuffer->setUnmanagedBufferDataHolder(WTFMove(frameHolder));
m_platformLayerProxy->pushNextBuffer(WTFMove(layerBuffer));
-} else {
+} else
+#endif
+{
std::unique_ptr buffer = m_platformLayerProxy->getAvailableBuffer(frameHolder->size(), GL_DONT_CARE);
if (UNLIKELY(!buffer)) {
auto texture = BitmapTextureGL::create(TextureMapperContextAttributes::get());
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [232790] trunk/Source/WebCore
Title: [232790] trunk/Source/WebCore
Revision 232790
Author ph...@webkit.org
Date 2018-06-13 06:39:13 -0700 (Wed, 13 Jun 2018)
Log Message
[GStreamer] Video freezes when GStreamerGL is not installed
https://bugs.webkit.org/show_bug.cgi?id=184925
Reviewed by Žan Doberšek.
At runtime when the GStreamer opengl plugin isn't available the
player will fallback to the internal WebKit video sink. The
VideoFrameHolder was refactored to handle both cases (opengl,
non-opengl).
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:
(WebCore::GstVideoFrameHolder::GstVideoFrameHolder):
(WebCore::GstVideoFrameHolder::~GstVideoFrameHolder):
(WebCore::GstVideoFrameHolder::frame const):
(WebCore::GstVideoFrameHolder::updateTexture):
(WebCore::MediaPlayerPrivateGStreamerBase::pushTextureToCompositor):
(WebCore::MediaPlayerPrivateGStreamerBase::triggerRepaint):
(WebCore::GstVideoFrameHolder::isValid const): Deleted.
(WebCore::MediaPlayerPrivateGStreamerBase::updateTexture): Deleted.
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.h:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp
trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (232789 => 232790)
--- trunk/Source/WebCore/ChangeLog 2018-06-13 10:50:29 UTC (rev 232789)
+++ trunk/Source/WebCore/ChangeLog 2018-06-13 13:39:13 UTC (rev 232790)
@@ -1,3 +1,26 @@
+2018-06-12 Philippe Normand
+
+[GStreamer] Video freezes when GStreamerGL is not installed
+https://bugs.webkit.org/show_bug.cgi?id=184925
+
+Reviewed by Žan Doberšek.
+
+At runtime when the GStreamer opengl plugin isn't available the
+player will fallback to the internal WebKit video sink. The
+VideoFrameHolder was refactored to handle both cases (opengl,
+non-opengl).
+
+* platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:
+(WebCore::GstVideoFrameHolder::GstVideoFrameHolder):
+(WebCore::GstVideoFrameHolder::~GstVideoFrameHolder):
+(WebCore::GstVideoFrameHolder::frame const):
+(WebCore::GstVideoFrameHolder::updateTexture):
+(WebCore::MediaPlayerPrivateGStreamerBase::pushTextureToCompositor):
+(WebCore::MediaPlayerPrivateGStreamerBase::triggerRepaint):
+(WebCore::GstVideoFrameHolder::isValid const): Deleted.
+(WebCore::MediaPlayerPrivateGStreamerBase::updateTexture): Deleted.
+* platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.h:
+
2018-06-12 Zalan Bujtas
Complex text handling should opt out of bounded text layout.
Modified: trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp (232789 => 232790)
--- trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp 2018-06-13 10:50:29 UTC (rev 232789)
+++ trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp 2018-06-13 13:39:13 UTC (rev 232790)
@@ -199,10 +199,10 @@
}
#endif
-#if USE(GSTREAMER_GL)
+#if USE(TEXTURE_MAPPER_GL)
class GstVideoFrameHolder : public TextureMapperPlatformLayerBuffer::UnmanagedBufferDataHolder {
public:
-explicit GstVideoFrameHolder(GstSample* sample, TextureMapperGL::Flags flags)
+explicit GstVideoFrameHolder(GstSample* sample, TextureMapperGL::Flags flags, bool gstGLEnabled)
{
GstVideoInfo videoInfo;
if (UNLIKELY(!getSampleVideoInfo(sample, videoInfo)))
@@ -209,19 +209,32 @@
return;
m_size = IntSize(GST_VIDEO_INFO_WIDTH(), GST_VIDEO_INFO_HEIGHT());
-m_flags = flags | (GST_VIDEO_INFO_HAS_ALPHA() ? TextureMapperGL::ShouldBlend : 0) | TEXTURE_MAPPER_COLOR_CONVERT_FLAG;
+m_hasAlphaChannel = GST_VIDEO_INFO_HAS_ALPHA();
+m_buffer = gst_sample_get_buffer(sample);
-GstBuffer* buffer = gst_sample_get_buffer(sample);
-if (UNLIKELY(!gst_video_frame_map(_videoFrame, , buffer, static_cast(GST_MAP_READ | GST_MAP_GL
-return;
+#if USE(GSTREAMER_GL)
+m_flags = flags | (m_hasAlphaChannel ? TextureMapperGL::ShouldBlend : 0) | TEXTURE_MAPPER_COLOR_CONVERT_FLAG;
-m_textureID = *reinterpret_cast(m_videoFrame.data[0]);
-m_isValid = true;
+if (gstGLEnabled) {
+m_isMapped = gst_video_frame_map(_videoFrame, , m_buffer, static_cast(GST_MAP_READ | GST_MAP_GL));
+if (m_isMapped)
+m_textureID = *reinterpret_cast(m_videoFrame.data[0]);
+} else
+#endif // USE(GSTREAMER_GL)
+
+{
+m_textureID = 0;
+m_isMapped = gst_video_frame_map(_videoFrame, , m_buffer, GST_MAP_READ);
+if (m_isMapped) {
+// Right now the TextureMapper only supports chromas with one plane
+ASSERT(GST_VIDEO_INFO_N_PLANES() == 1);
+}
+}
}
virtual
[webkit-changes] [232789] trunk/Tools
Title: [232789] trunk/Tools
Revision 232789
Author clo...@igalia.com
Date 2018-06-13 03:50:29 -0700 (Wed, 13 Jun 2018)
Log Message
[JSCOnly] Add a MIPS32el JSCOnly EWS (follow-up fix)
https://bugs.webkit.org/show_bug.cgi?id=186523
Unreviewed follow-up fix after r232748
* Scripts/webkitpy/common/config/ports.py:
(JscOnlyPort.build_jsc_command): It is needed to pass a --jsc-only argument to the build-jsc script.
* Scripts/webkitpy/common/config/ports_unittest.py:
(DeprecatedPortTest.test_jsconly_port):
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/common/config/ports.py
trunk/Tools/Scripts/webkitpy/common/config/ports_unittest.py
Diff
Modified: trunk/Tools/ChangeLog (232788 => 232789)
--- trunk/Tools/ChangeLog 2018-06-13 06:24:58 UTC (rev 232788)
+++ trunk/Tools/ChangeLog 2018-06-13 10:50:29 UTC (rev 232789)
@@ -1,3 +1,15 @@
+2018-06-13 Carlos Alberto Lopez Perez
+
+[JSCOnly] Add a MIPS32el JSCOnly EWS (follow-up fix)
+https://bugs.webkit.org/show_bug.cgi?id=186523
+
+Unreviewed follow-up fix after r232748
+
+* Scripts/webkitpy/common/config/ports.py:
+(JscOnlyPort.build_jsc_command): It is needed to pass a --jsc-only argument to the build-jsc script.
+* Scripts/webkitpy/common/config/ports_unittest.py:
+(DeprecatedPortTest.test_jsconly_port):
+
2018-06-12 Thibault Saunier
webkitpy: Implement coredumpctl support on linux
Modified: trunk/Tools/Scripts/webkitpy/common/config/ports.py (232788 => 232789)
--- trunk/Tools/Scripts/webkitpy/common/config/ports.py 2018-06-13 06:24:58 UTC (rev 232788)
+++ trunk/Tools/Scripts/webkitpy/common/config/ports.py 2018-06-13 10:50:29 UTC (rev 232789)
@@ -238,4 +238,5 @@
def build_jsc_command(self, build_style=None):
command = self.script_shell_command("build-jsc")
+command.append("--jsc-only")
return self._append_build_style_flag(command, build_style)
Modified: trunk/Tools/Scripts/webkitpy/common/config/ports_unittest.py (232788 => 232789)
--- trunk/Tools/Scripts/webkitpy/common/config/ports_unittest.py 2018-06-13 06:24:58 UTC (rev 232788)
+++ trunk/Tools/Scripts/webkitpy/common/config/ports_unittest.py 2018-06-13 10:50:29 UTC (rev 232789)
@@ -64,6 +64,6 @@
def test_jsconly_port(self):
self.assertEqual(JscOnlyPort().flag(), "--port=jsc-only")
-self.assertEqual(JscOnlyPort().build_jsc_command(), DeprecatedPort().script_shell_command("build-jsc"))
-self.assertEqual(JscOnlyPort().build_jsc_command(build_style="release"), DeprecatedPort().script_shell_command("build-jsc") + ["--release"])
-self.assertEqual(JscOnlyPort().build_jsc_command(build_style="debug"), DeprecatedPort().script_shell_command("build-jsc") + ["--debug"])
+self.assertEqual(JscOnlyPort().build_jsc_command(), DeprecatedPort().script_shell_command("build-jsc") + ["--jsc-only"])
+self.assertEqual(JscOnlyPort().build_jsc_command(build_style="release"), DeprecatedPort().script_shell_command("build-jsc") + ["--jsc-only", "--release"])
+self.assertEqual(JscOnlyPort().build_jsc_command(build_style="debug"), DeprecatedPort().script_shell_command("build-jsc") + ["--jsc-only", "--debug"])
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [232788] trunk/Source/JavaScriptCore
Title: [232788] trunk/Source/_javascript_Core
Revision 232788
Author sbar...@apple.com
Date 2018-06-12 23:24:58 -0700 (Tue, 12 Jun 2018)
Log Message
Remove JSVirtualMachine shrinkFootprint when clients move to shrinkFootprintWhenIdle
https://bugs.webkit.org/show_bug.cgi?id=186071
Reviewed by Mark Lam.
* API/JSVirtualMachine.mm:
(-[JSVirtualMachine shrinkFootprint]): Deleted.
* API/JSVirtualMachinePrivate.h:
Modified Paths
trunk/Source/_javascript_Core/API/JSVirtualMachine.mm
trunk/Source/_javascript_Core/API/JSVirtualMachinePrivate.h
trunk/Source/_javascript_Core/ChangeLog
Diff
Modified: trunk/Source/_javascript_Core/API/JSVirtualMachine.mm (232787 => 232788)
--- trunk/Source/_javascript_Core/API/JSVirtualMachine.mm 2018-06-13 02:59:19 UTC (rev 232787)
+++ trunk/Source/_javascript_Core/API/JSVirtualMachine.mm 2018-06-13 06:24:58 UTC (rev 232788)
@@ -268,13 +268,6 @@
return m_externalRememberedSet;
}
-- (void)shrinkFootprint
-{
-JSC::VM* vm = toJS(m_group);
-JSC::JSLockHolder locker(vm);
-vm->shrinkFootprintWhenIdle();
-}
-
- (void)shrinkFootprintWhenIdle
{
JSC::VM* vm = toJS(m_group);
Modified: trunk/Source/_javascript_Core/API/JSVirtualMachinePrivate.h (232787 => 232788)
--- trunk/Source/_javascript_Core/API/JSVirtualMachinePrivate.h 2018-06-13 02:59:19 UTC (rev 232787)
+++ trunk/Source/_javascript_Core/API/JSVirtualMachinePrivate.h 2018-06-13 06:24:58 UTC (rev 232788)
@@ -31,8 +31,6 @@
@interface JSVirtualMachine(JSPrivate)
-- (void)shrinkFootprint; // FIXME: Remove this SPI when clients move to shrinkFootprintWhenIdle: https://bugs.webkit.org/show_bug.cgi?id=186071
-
/*!
@method
@discussion Shrinks the memory footprint of the VM by deleting various internal caches,
Modified: trunk/Source/_javascript_Core/ChangeLog (232787 => 232788)
--- trunk/Source/_javascript_Core/ChangeLog 2018-06-13 02:59:19 UTC (rev 232787)
+++ trunk/Source/_javascript_Core/ChangeLog 2018-06-13 06:24:58 UTC (rev 232788)
@@ -1,3 +1,14 @@
+2018-06-12 Saam Barati
+
+Remove JSVirtualMachine shrinkFootprint when clients move to shrinkFootprintWhenIdle
+https://bugs.webkit.org/show_bug.cgi?id=186071
+
+Reviewed by Mark Lam.
+
+* API/JSVirtualMachine.mm:
+(-[JSVirtualMachine shrinkFootprint]): Deleted.
+* API/JSVirtualMachinePrivate.h:
+
2018-06-11 Saam Barati
Reduce graph size by replacing terminal nodes in blocks that have a ForceOSRExit with Unreachable
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
