[webkit-changes] [261779] trunk/Tools
Title: [261779] trunk/Tools
Revision 261779
Author lmo...@igalia.com
Date 2020-05-15 22:45:49 -0700 (Fri, 15 May 2020)
Log Message
[GTK][WPE] Add default initialization of WebsiteDataStore to WebKitTestRunner after r261758
https://bugs.webkit.org/show_bug.cgi?id=211977
As GTK/WPE does not explicitly create WebSiteDataStore for the tests,
assign the default one.
Not sure if this is the correct fix, but should allow running tests
again.
Reviewed by Žan Doberšek.
* WebKitTestRunner/TestController.cpp: Add GTK/WPE guards.
* WebKitTestRunner/gtk/TestControllerGtk.cpp:
(WTR::TestController::platformInitializeDataStore): Use default
WebsiteDataStore.
* WebKitTestRunner/wpe/TestControllerWPE.cpp:
(WTR::TestController::platformInitializeDataStore): Use default
websiteDataStore.
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/WebKitTestRunner/TestController.cpp
trunk/Tools/WebKitTestRunner/gtk/TestControllerGtk.cpp
trunk/Tools/WebKitTestRunner/wpe/TestControllerWPE.cpp
Diff
Modified: trunk/Tools/ChangeLog (261778 => 261779)
--- trunk/Tools/ChangeLog 2020-05-16 04:32:20 UTC (rev 261778)
+++ trunk/Tools/ChangeLog 2020-05-16 05:45:49 UTC (rev 261779)
@@ -1,3 +1,24 @@
+2020-05-15 Lauro Moura
+
+[GTK][WPE] Add default initialization of WebsiteDataStore to WebKitTestRunner after r261758
+https://bugs.webkit.org/show_bug.cgi?id=211977
+
+As GTK/WPE does not explicitly create WebSiteDataStore for the tests,
+assign the default one.
+
+Not sure if this is the correct fix, but should allow running tests
+again.
+
+Reviewed by Žan Doberšek.
+
+* WebKitTestRunner/TestController.cpp: Add GTK/WPE guards.
+* WebKitTestRunner/gtk/TestControllerGtk.cpp:
+(WTR::TestController::platformInitializeDataStore): Use default
+WebsiteDataStore.
+* WebKitTestRunner/wpe/TestControllerWPE.cpp:
+(WTR::TestController::platformInitializeDataStore): Use default
+websiteDataStore.
+
2020-05-15 Alex Christensen
Use enum serialization instead of casting to/from uint32_t
Modified: trunk/Tools/WebKitTestRunner/TestController.cpp (261778 => 261779)
--- trunk/Tools/WebKitTestRunner/TestController.cpp 2020-05-16 04:32:20 UTC (rev 261778)
+++ trunk/Tools/WebKitTestRunner/TestController.cpp 2020-05-16 05:45:49 UTC (rev 261779)
@@ -3116,10 +3116,12 @@
{
}
+#if !PLATFORM(GTK) && !PLATFORM(WPE)
void TestController::platformInitializeDataStore(WKPageConfigurationRef configuration, const TestOptions&)
{
m_websiteDataStore = WKPageConfigurationGetWebsiteDataStore(configuration);
}
+#endif
void TestController::platformCreateWebView(WKPageConfigurationRef configuration, const TestOptions& options)
{
Modified: trunk/Tools/WebKitTestRunner/gtk/TestControllerGtk.cpp (261778 => 261779)
--- trunk/Tools/WebKitTestRunner/gtk/TestControllerGtk.cpp 2020-05-16 04:32:20 UTC (rev 261778)
+++ trunk/Tools/WebKitTestRunner/gtk/TestControllerGtk.cpp 2020-05-16 05:45:49 UTC (rev 261779)
@@ -46,6 +46,11 @@
{
}
+void TestController::platformInitializeDataStore(WKPageConfigurationRef, const TestOptions& options)
+{
+m_websiteDataStore = defaultWebsiteDataStore();
+}
+
WKPreferencesRef TestController::platformPreferences()
{
return WKPageGroupGetPreferences(m_pageGroup.get());
Modified: trunk/Tools/WebKitTestRunner/wpe/TestControllerWPE.cpp (261778 => 261779)
--- trunk/Tools/WebKitTestRunner/wpe/TestControllerWPE.cpp 2020-05-16 04:32:20 UTC (rev 261778)
+++ trunk/Tools/WebKitTestRunner/wpe/TestControllerWPE.cpp 2020-05-16 05:45:49 UTC (rev 261779)
@@ -45,6 +45,11 @@
{
}
+void TestController::platformInitializeDataStore(WKPageConfigurationRef, const TestOptions& options)
+{
+m_websiteDataStore = defaultWebsiteDataStore();
+}
+
WKPreferencesRef TestController::platformPreferences()
{
return WKPageGroupGetPreferences(m_pageGroup.get());
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [261778] trunk
Title: [261778] trunk
Revision 261778
Author an...@apple.com
Date 2020-05-15 21:32:20 -0700 (Fri, 15 May 2020)
Log Message
Nullptr crash in MediaQueryMatcher::evaluateAll
https://bugs.webkit.org/show_bug.cgi?id=211963
Reviewed by Brent Fulgham.
Source/WebCore:
Test: fast/media/media-query-list-mutation.html
* css/MediaQueryMatcher.cpp:
(WebCore::MediaQueryMatcher::evaluateAll):
Copy the vector before iterating.
LayoutTests:
* fast/media/media-query-list-mutation-expected.txt: Added.
* fast/media/media-query-list-mutation.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/MediaQueryMatcher.cpp
Added Paths
trunk/LayoutTests/fast/media/media-query-list-mutation-expected.txt
trunk/LayoutTests/fast/media/media-query-list-mutation.html
Diff
Modified: trunk/LayoutTests/ChangeLog (261777 => 261778)
--- trunk/LayoutTests/ChangeLog 2020-05-16 04:09:51 UTC (rev 261777)
+++ trunk/LayoutTests/ChangeLog 2020-05-16 04:32:20 UTC (rev 261778)
@@ -1,3 +1,14 @@
+2020-05-15 Antti Koivisto
+
+Nullptr crash in MediaQueryMatcher::evaluateAll
+https://bugs.webkit.org/show_bug.cgi?id=211963
+
+
+Reviewed by Brent Fulgham.
+
+* fast/media/media-query-list-mutation-expected.txt: Added.
+* fast/media/media-query-list-mutation.html: Added.
+
2020-05-15 Jack Lee
Nullptr crash in WebCore::Node::treeScope() when processing nested list insertion commands.
Added: trunk/LayoutTests/fast/media/media-query-list-mutation-expected.txt (0 => 261778)
--- trunk/LayoutTests/fast/media/media-query-list-mutation-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/media/media-query-list-mutation-expected.txt 2020-05-16 04:32:20 UTC (rev 261778)
@@ -0,0 +1 @@
+This test passes if it doesn't crash.
Added: trunk/LayoutTests/fast/media/media-query-list-mutation.html (0 => 261778)
--- trunk/LayoutTests/fast/media/media-query-list-mutation.html (rev 0)
+++ trunk/LayoutTests/fast/media/media-query-list-mutation.html 2020-05-16 04:32:20 UTC (rev 261778)
@@ -0,0 +1,20 @@
+
+if (window.testRunner) {
+testRunner.dumpAsText();
+testRunner.waitUntilDone();
+}
+
+const queries = [];
+queries.push(window.matchMedia("screen"));
+queries.push(window.matchMedia("screen"));
+
+queries[0].addListener(() => {
+for (let i = 0; i < 20; ++i)
+queries.push(window.matchMedia("screen"))
+
+requestAnimationFrame(() => testRunner.notifyDone());
+});
+
+window.internals.settings.setMediaTypeOverride("handheld");
+
+This test passes if it doesn't crash.
Modified: trunk/Source/WebCore/ChangeLog (261777 => 261778)
--- trunk/Source/WebCore/ChangeLog 2020-05-16 04:09:51 UTC (rev 261777)
+++ trunk/Source/WebCore/ChangeLog 2020-05-16 04:32:20 UTC (rev 261778)
@@ -1,3 +1,18 @@
+2020-05-15 Antti Koivisto
+
+Nullptr crash in MediaQueryMatcher::evaluateAll
+https://bugs.webkit.org/show_bug.cgi?id=211963
+
+
+Reviewed by Brent Fulgham.
+
+Test: fast/media/media-query-list-mutation.html
+
+* css/MediaQueryMatcher.cpp:
+(WebCore::MediaQueryMatcher::evaluateAll):
+
+Copy the vector before iterating.
+
2020-05-15 Jack Lee
Nullptr crash in WebCore::Node::treeScope() when processing nested list insertion commands.
Modified: trunk/Source/WebCore/css/MediaQueryMatcher.cpp (261777 => 261778)
--- trunk/Source/WebCore/css/MediaQueryMatcher.cpp 2020-05-16 04:09:51 UTC (rev 261777)
+++ trunk/Source/WebCore/css/MediaQueryMatcher.cpp 2020-05-16 04:32:20 UTC (rev 261778)
@@ -118,7 +118,9 @@
LOG_WITH_STREAM(MediaQueries, stream << "MediaQueryMatcher::styleResolverChanged " << m_document->url());
MediaQueryEvaluator evaluator { mediaType(), *m_document, style.get() };
-for (auto& list : m_mediaQueryLists) {
+
+auto mediaQueryLists = m_mediaQueryLists;
+for (auto& list : mediaQueryLists) {
if (!list)
continue;
bool notify;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [261777] trunk
Title: [261777] trunk
Revision 261777
Author shihchieh_...@apple.com
Date 2020-05-15 21:09:51 -0700 (Fri, 15 May 2020)
Log Message
Nullptr crash in WebCore::Node::treeScope() when processing nested list insertion commands.
https://bugs.webkit.org/show_bug.cgi?id=211964
Reviewed by Geoffrey Garen.
Source/WebCore:
Load event may fire in fixOrphanedListChild() and change the node tree. In doApplyForSingleParagraph check for
disconnected node returned by fixOrphanedListChild() and bail out.
Test: editing/inserting/nested-list-insertion-crash.html
* editing/InsertListCommand.cpp:
(WebCore::InsertListCommand::doApplyForSingleParagraph):
LayoutTests:
Added a regression test for the crash.
* editing/inserting/nested-list-insertion-crash-expected.txt: Added.
* editing/inserting/nested-list-insertion-crash.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/editing/InsertListCommand.cpp
Added Paths
trunk/LayoutTests/editing/inserting/nested-list-insertion-crash-expected.txt
trunk/LayoutTests/editing/inserting/nested-list-insertion-crash.html
Diff
Modified: trunk/LayoutTests/ChangeLog (261776 => 261777)
--- trunk/LayoutTests/ChangeLog 2020-05-16 03:45:59 UTC (rev 261776)
+++ trunk/LayoutTests/ChangeLog 2020-05-16 04:09:51 UTC (rev 261777)
@@ -1,3 +1,16 @@
+2020-05-15 Jack Lee
+
+Nullptr crash in WebCore::Node::treeScope() when processing nested list insertion commands.
+https://bugs.webkit.org/show_bug.cgi?id=211964
+
+
+Reviewed by Geoffrey Garen.
+
+Added a regression test for the crash.
+
+* editing/inserting/nested-list-insertion-crash-expected.txt: Added.
+* editing/inserting/nested-list-insertion-crash.html: Added.
+
2020-05-15 Simon Fraser
REGRESSION (r249091): Can't click on a video in the second column of a paginated web view
Added: trunk/LayoutTests/editing/inserting/nested-list-insertion-crash-expected.txt (0 => 261777)
--- trunk/LayoutTests/editing/inserting/nested-list-insertion-crash-expected.txt (rev 0)
+++ trunk/LayoutTests/editing/inserting/nested-list-insertion-crash-expected.txt 2020-05-16 04:09:51 UTC (rev 261777)
@@ -0,0 +1,3 @@
+Test nested list insertion. The test passes if WebKit doesn't crash or hit an assertion.
+
+
Added: trunk/LayoutTests/editing/inserting/nested-list-insertion-crash.html (0 => 261777)
--- trunk/LayoutTests/editing/inserting/nested-list-insertion-crash.html (rev 0)
+++ trunk/LayoutTests/editing/inserting/nested-list-insertion-crash.html 2020-05-16 04:09:51 UTC (rev 261777)
@@ -0,0 +1,10 @@
+
+if (window.testRunner)
+testRunner.dumpAsText();
+
+function run() {
+window.getSelection().setPosition(li,1);
+document.execCommand("insertUnorderedList", false);
+}
+
+Test nested list insertion. The test passes if WebKit doesn't crash or hit an assertion.
Modified: trunk/Source/WebCore/ChangeLog (261776 => 261777)
--- trunk/Source/WebCore/ChangeLog 2020-05-16 03:45:59 UTC (rev 261776)
+++ trunk/Source/WebCore/ChangeLog 2020-05-16 04:09:51 UTC (rev 261777)
@@ -1,3 +1,19 @@
+2020-05-15 Jack Lee
+
+Nullptr crash in WebCore::Node::treeScope() when processing nested list insertion commands.
+https://bugs.webkit.org/show_bug.cgi?id=211964
+
+
+Reviewed by Geoffrey Garen.
+
+Load event may fire in fixOrphanedListChild() and change the node tree. In doApplyForSingleParagraph check for
+disconnected node returned by fixOrphanedListChild() and bail out.
+
+Test: editing/inserting/nested-list-insertion-crash.html
+
+* editing/InsertListCommand.cpp:
+(WebCore::InsertListCommand::doApplyForSingleParagraph):
+
2020-05-15 Alex Christensen
Use enum serialization instead of casting to/from uint32_t
Modified: trunk/Source/WebCore/editing/InsertListCommand.cpp (261776 => 261777)
--- trunk/Source/WebCore/editing/InsertListCommand.cpp 2020-05-16 03:45:59 UTC (rev 261776)
+++ trunk/Source/WebCore/editing/InsertListCommand.cpp 2020-05-16 04:09:51 UTC (rev 261777)
@@ -213,7 +213,7 @@
RefPtr listNode = enclosingList(listChildNode);
if (!listNode) {
RefPtr listElement = fixOrphanedListChild(*listChildNode);
-if (!listElement)
+if (!listElement || !listElement->isConnected())
return;
listNode = mergeWithNeighboringLists(*listElement);
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [261775] trunk/Source/WebCore
Title: [261775] trunk/Source/WebCore Revision 261775 Author simon.fra...@apple.com Date 2020-05-15 19:14:29 -0700 (Fri, 15 May 2020) Log Message Rename the mapLocalToContainer() container argument, since it's not just used for repaint https://bugs.webkit.org/show_bug.cgi?id=211974 Reviewed by Zalan Bujtas. mapLocalToContainer() is a generic geometry mapping function, and not just used for repaint, so rename the "repaintContainer" argument to "ancestorContainer". Also fix some weirdly named variables in RenderMultiColumnFlow. * rendering/RenderBox.cpp: (WebCore::RenderBox::mapLocalToContainer const): * rendering/RenderBox.h: * rendering/RenderFragmentedFlow.cpp: (WebCore::RenderFragmentedFlow::mapLocalToContainer const): * rendering/RenderFragmentedFlow.h: * rendering/RenderInline.cpp: (WebCore::RenderInline::mapLocalToContainer const): (WebCore::RenderInline::pushMappingToContainer const): * rendering/RenderMultiColumnFlow.cpp: (WebCore::RenderMultiColumnFlow::addFragmentToThread): (WebCore::RenderMultiColumnFlow::mapFromFlowToFragment const): (WebCore::RenderMultiColumnFlow::physicalTranslationOffsetFromFlowToFragment const): (WebCore::RenderMultiColumnFlow::physicalTranslationFromFlowToFragment const): * rendering/RenderObject.cpp: (WebCore::RenderObject::mapLocalToContainer const): (WebCore::RenderObject::localToContainerQuad const): (WebCore::RenderObject::localToContainerPoint const): * rendering/RenderObject.h: * rendering/RenderView.cpp: (WebCore::RenderView::mapLocalToContainer const): * rendering/svg/RenderSVGForeignObject.cpp: (WebCore::RenderSVGForeignObject::mapLocalToContainer const): * rendering/svg/RenderSVGForeignObject.h: * rendering/svg/RenderSVGInline.cpp: (WebCore::RenderSVGInline::mapLocalToContainer const): * rendering/svg/RenderSVGInline.h: * rendering/svg/RenderSVGModelObject.cpp: (WebCore::RenderSVGModelObject::mapLocalToContainer const): * rendering/svg/RenderSVGModelObject.h: * rendering/svg/RenderSVGRoot.cpp: (WebCore::RenderSVGRoot::mapLocalToContainer const): * rendering/svg/RenderSVGRoot.h: * rendering/svg/RenderSVGText.cpp: (WebCore::RenderSVGText::mapLocalToContainer const): * rendering/svg/RenderSVGText.h: * rendering/svg/SVGRenderSupport.cpp: (WebCore::SVGRenderSupport::mapLocalToContainer): * rendering/svg/SVGRenderSupport.h: Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/rendering/RenderBox.cpp trunk/Source/WebCore/rendering/RenderBox.h trunk/Source/WebCore/rendering/RenderFragmentedFlow.cpp trunk/Source/WebCore/rendering/RenderFragmentedFlow.h trunk/Source/WebCore/rendering/RenderInline.cpp trunk/Source/WebCore/rendering/RenderMultiColumnFlow.cpp trunk/Source/WebCore/rendering/RenderObject.cpp trunk/Source/WebCore/rendering/RenderObject.h trunk/Source/WebCore/rendering/RenderView.cpp trunk/Source/WebCore/rendering/svg/RenderSVGForeignObject.cpp trunk/Source/WebCore/rendering/svg/RenderSVGForeignObject.h trunk/Source/WebCore/rendering/svg/RenderSVGInline.cpp trunk/Source/WebCore/rendering/svg/RenderSVGInline.h trunk/Source/WebCore/rendering/svg/RenderSVGModelObject.cpp trunk/Source/WebCore/rendering/svg/RenderSVGModelObject.h trunk/Source/WebCore/rendering/svg/RenderSVGRoot.cpp trunk/Source/WebCore/rendering/svg/RenderSVGRoot.h trunk/Source/WebCore/rendering/svg/RenderSVGText.cpp trunk/Source/WebCore/rendering/svg/RenderSVGText.h trunk/Source/WebCore/rendering/svg/SVGRenderSupport.cpp trunk/Source/WebCore/rendering/svg/SVGRenderSupport.h Diff Modified: trunk/Source/WebCore/ChangeLog (261774 => 261775) --- trunk/Source/WebCore/ChangeLog 2020-05-16 02:07:00 UTC (rev 261774) +++ trunk/Source/WebCore/ChangeLog 2020-05-16 02:14:29 UTC (rev 261775) @@ -1,5 +1,57 @@ 2020-05-15 Simon Fraser +Rename the mapLocalToContainer() container argument, since it's not just used for repaint +https://bugs.webkit.org/show_bug.cgi?id=211974 + +Reviewed by Zalan Bujtas. + +mapLocalToContainer() is a generic geometry mapping function, and not just used for repaint, +so rename the "repaintContainer" argument to "ancestorContainer". + +Also fix some weirdly named variables in RenderMultiColumnFlow. + +* rendering/RenderBox.cpp: +(WebCore::RenderBox::mapLocalToContainer const): +* rendering/RenderBox.h: +* rendering/RenderFragmentedFlow.cpp: +(WebCore::RenderFragmentedFlow::mapLocalToContainer const): +* rendering/RenderFragmentedFlow.h: +* rendering/RenderInline.cpp: +(WebCore::RenderInline::mapLocalToContainer const): +(WebCore::RenderInline::pushMappingToContainer const): +* rendering/RenderMultiColumnFlow.cpp: +(WebCore::RenderMultiColumnFlow::addFragmentToThread): +(WebCore::RenderMultiColumnFlow::mapFromFlowToFragment const): +(WebCore::RenderMultiColumnFlow::physicalTranslationOffsetFromFlowToFragment const): +(WebCore::RenderMultiColumnFlow::physicalTranslationFromFlowToFragment
[webkit-changes] [261774] trunk
Title: [261774] trunk
Revision 261774
Author simon.fra...@apple.com
Date 2020-05-15 19:07:00 -0700 (Fri, 15 May 2020)
Log Message
REGRESSION (r249091): Can't click on a video in the second column of a paginated web view
https://bugs.webkit.org/show_bug.cgi?id=211973
Reviewed by Zalan Bujtas.
Source/WebCore:
In r249091 I made clip layer computation use offsetFromAncestor() by default, but this turns
out to give different behavior from mapping via renderers in columns.
The bug was that accumulateOffsetTowardsAncestor() would map through the
RenderMultiColumnFlow columns if the ancestorLayer was the one that was using columns,
but mapping via renderers only maps through columns if converting to some ancestor of
the columnated renderer.
I did not investigate why this only affects video.
Test: fast/multicol/clipped-video-in-second-column.html
* rendering/RenderLayer.cpp:
(WebCore::accumulateOffsetTowardsAncestor):
(WebCore::RenderLayer::calculateClipRects const):
LayoutTests:
* fast/multicol/clipped-video-in-second-column-expected.html: Added.
* fast/multicol/clipped-video-in-second-column.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderLayer.cpp
Added Paths
trunk/LayoutTests/fast/multicol/clipped-video-in-second-column-expected.html
trunk/LayoutTests/fast/multicol/clipped-video-in-second-column.html
Diff
Modified: trunk/LayoutTests/ChangeLog (261773 => 261774)
--- trunk/LayoutTests/ChangeLog 2020-05-16 01:23:40 UTC (rev 261773)
+++ trunk/LayoutTests/ChangeLog 2020-05-16 02:07:00 UTC (rev 261774)
@@ -1,3 +1,14 @@
+2020-05-15 Simon Fraser
+
+REGRESSION (r249091): Can't click on a video in the second column of a paginated web view
+https://bugs.webkit.org/show_bug.cgi?id=211973
+
+
+Reviewed by Zalan Bujtas.
+
+* fast/multicol/clipped-video-in-second-column-expected.html: Added.
+* fast/multicol/clipped-video-in-second-column.html: Added.
+
2020-05-15 Devin Rousso
Web Inspector: Fails to pretty-print a particular CSS file
Added: trunk/LayoutTests/fast/multicol/clipped-video-in-second-column-expected.html (0 => 261774)
--- trunk/LayoutTests/fast/multicol/clipped-video-in-second-column-expected.html (rev 0)
+++ trunk/LayoutTests/fast/multicol/clipped-video-in-second-column-expected.html 2020-05-16 02:07:00 UTC (rev 261774)
@@ -0,0 +1,38 @@
+
+
+
+
+.multicol {
+width: 680px;
+height: 500px;
+columns: 2;
+padding: 10px;
+border: 1px solid green;
+}
+
+img {
+margin: 10px;
+width: 300px;
+height: 200px;
+border: 5px solid black;
+background-color: silver;
+}
+
+.container {
+height: 400px;
+overflow: hidden;
+border: 1px solid gray;
+}
+
+
+
+
+
+
+
+
+
+
+
+
+
Added: trunk/LayoutTests/fast/multicol/clipped-video-in-second-column.html (0 => 261774)
--- trunk/LayoutTests/fast/multicol/clipped-video-in-second-column.html (rev 0)
+++ trunk/LayoutTests/fast/multicol/clipped-video-in-second-column.html 2020-05-16 02:07:00 UTC (rev 261774)
@@ -0,0 +1,38 @@
+
+
+
+
+.multicol {
+width: 680px;
+height: 500px;
+columns: 2;
+padding: 10px;
+border: 1px solid green;
+}
+
+video {
+margin: 10px;
+width: 300px;
+height: 200px;
+border: 5px solid black;
+background-color: silver;
+}
+
+.container {
+height: 400px;
+overflow: hidden;
+border: 1px solid gray;
+}
+
+
+
+
+
+
+
+
+
+
+
+
+
Modified: trunk/Source/WebCore/ChangeLog (261773 => 261774)
--- trunk/Source/WebCore/ChangeLog 2020-05-16 01:23:40 UTC (rev 261773)
+++ trunk/Source/WebCore/ChangeLog 2020-05-16 02:07:00 UTC (rev 261774)
@@ -1,3 +1,27 @@
+2020-05-15 Simon Fraser
+
+REGRESSION (r249091): Can't click on a video in the second column of a paginated web view
+https://bugs.webkit.org/show_bug.cgi?id=211973
+
+
+Reviewed by Zalan Bujtas.
+
+In r249091 I made clip layer computation use offsetFromAncestor() by default, but this turns
+out to give different behavior from mapping via renderers in columns.
+
+The bug was that accumulateOffsetTowardsAncestor() would map through the
+RenderMultiColumnFlow columns if the ancestorLayer was the one that was using columns,
+but mapping via renderers only maps through columns if converting to some ancestor of
+the columnated renderer.
+
+I did not investigate why this only
[webkit-changes] [261773] trunk
Title: [261773] trunk
Revision 261773
Author ysuz...@apple.com
Date 2020-05-15 18:23:40 -0700 (Fri, 15 May 2020)
Log Message
[JSC] getFunctionRealm should not use recursion
https://bugs.webkit.org/show_bug.cgi?id=211965
Reviewed by Saam Barati.
JSTests:
* stress/get-function-realm-not-doing-recursion.js: Added.
(canThrow):
(const.emptyFunction):
Source/_javascript_Core:
This patch avoids using recursion in getFunctionRealm to avoid stack-overflow.
* runtime/InternalFunction.cpp:
(JSC::getFunctionRealm):
Modified Paths
trunk/JSTests/ChangeLog
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/runtime/InternalFunction.cpp
Added Paths
trunk/JSTests/stress/get-function-realm-not-doing-recursion.js
Diff
Modified: trunk/JSTests/ChangeLog (261772 => 261773)
--- trunk/JSTests/ChangeLog 2020-05-16 01:17:21 UTC (rev 261772)
+++ trunk/JSTests/ChangeLog 2020-05-16 01:23:40 UTC (rev 261773)
@@ -1,3 +1,15 @@
+2020-05-15 Yusuke Suzuki
+
+[JSC] getFunctionRealm should not use recursion
+https://bugs.webkit.org/show_bug.cgi?id=211965
+
+
+Reviewed by Saam Barati.
+
+* stress/get-function-realm-not-doing-recursion.js: Added.
+(canThrow):
+(const.emptyFunction):
+
2020-05-15 Paulo Matos
Skip tests in ARM and MIPS post r261667
Added: trunk/JSTests/stress/get-function-realm-not-doing-recursion.js (0 => 261773)
--- trunk/JSTests/stress/get-function-realm-not-doing-recursion.js (rev 0)
+++ trunk/JSTests/stress/get-function-realm-not-doing-recursion.js 2020-05-16 01:23:40 UTC (rev 261773)
@@ -0,0 +1,31 @@
+//@ skip if $buildType != "debug"
+//@ runDefault("--useConcurrentJIT=0")
+
+function canThrow(func, errorMessage) {
+var errorThrown = false;
+var error = null;
+try {
+func();
+} catch (e) {
+errorThrown = true;
+error = e;
+print(error.message);
+}
+if (errorThrown && String(error) !== errorMessage)
+throw new Error(`bad error: ${String(error)}`);
+return false;
+}
+
+const emptyFunction = function() {};
+
+function makeLongProxyChain() {
+ let p = new Proxy(emptyFunction, {});
+ for (let i = 0; i < 20; i++)
+p = new Proxy(p, {});
+ return p;
+}
+
+let p = makeLongProxyChain();
+canThrow(() => {
+Reflect.construct(Object, [], p);
+}, `RangeError: Maximum call stack size exceeded.`);
Modified: trunk/Source/_javascript_Core/ChangeLog (261772 => 261773)
--- trunk/Source/_javascript_Core/ChangeLog 2020-05-16 01:17:21 UTC (rev 261772)
+++ trunk/Source/_javascript_Core/ChangeLog 2020-05-16 01:23:40 UTC (rev 261773)
@@ -1,3 +1,16 @@
+2020-05-15 Yusuke Suzuki
+
+[JSC] getFunctionRealm should not use recursion
+https://bugs.webkit.org/show_bug.cgi?id=211965
+
+
+Reviewed by Saam Barati.
+
+This patch avoids using recursion in getFunctionRealm to avoid stack-overflow.
+
+* runtime/InternalFunction.cpp:
+(JSC::getFunctionRealm):
+
2020-05-15 Keith Miller
Unreviewed, fix internal arm64e build.
Modified: trunk/Source/_javascript_Core/runtime/InternalFunction.cpp (261772 => 261773)
--- trunk/Source/_javascript_Core/runtime/InternalFunction.cpp 2020-05-16 01:17:21 UTC (rev 261772)
+++ trunk/Source/_javascript_Core/runtime/InternalFunction.cpp 2020-05-16 01:23:40 UTC (rev 261773)
@@ -157,20 +157,26 @@
{
ASSERT(object->isCallable(vm));
-if (object->inherits(vm))
-return getFunctionRealm(vm, jsCast(object)->targetFunction());
+while (true) {
+if (object->inherits(vm)) {
+object = jsCast(object)->targetFunction();
+continue;
+}
-if (object->type() == ProxyObjectType) {
-auto* proxy = jsCast(object);
-// Per step 4.a, a TypeError should be thrown for revoked Proxy, yet we skip it since:
-// a) It is barely observable anyway: "prototype" lookup in createSubclassStructure() will throw for revoked Proxy.
-// b) Throwing getFunctionRealm() will restrict calling it inline as an argument of createSubclassStructure().
-// c) There is ongoing discussion on removing it: https://github.com/tc39/ecma262/issues/1798.
-if (!proxy->isRevoked())
-return getFunctionRealm(vm, proxy->target());
+if (object->type() == ProxyObjectType) {
+auto* proxy = jsCast(object);
+// Per step 4.a, a TypeError should be thrown for revoked Proxy, yet we skip it since:
+// a) It is barely observable anyway: "prototype" lookup in createSubclassStructure() will throw for revoked Proxy.
+// b) Throwing getFunctionRealm() will restrict calling it inline as an argument of createSubclassStructure().
+// c) There is ongoing discussion on removing it: https://github.com/tc39/ecma262/issues/1798.
+if (!proxy->isRevoked()) {
+object = proxy->target();
+
[webkit-changes] [261772] trunk
Title: [261772] trunk
Revision 261772
Author drou...@apple.com
Date 2020-05-15 18:17:21 -0700 (Fri, 15 May 2020)
Log Message
Web Inspector: Fails to pretty-print a particular CSS file
https://bugs.webkit.org/show_bug.cgi?id=211930
Reviewed by Joseph Pecoraro.
Source/WebInspectorUI:
* UserInterface/Workers/Formatter/CSSFormatter.js:
(CSSFormatter.prototype._format):
Keep a stack of special sequences (e.g. `"`, `'`, `/*`, etc.), only outputting the text in
between the start and end of the sequence when the stack is empty. Ignore all other special
sequences when in a comma sequence. Add proper checks for if the star/end is escaped.
Drive-by: minor refactor so that the arrow functions are created outside the loop.
LayoutTests:
* inspector/formatting/formatting-css.html:
* inspector/formatting/formatting-css-expected.txt:
* inspector/formatting/resources/css-tests/url.css: Added.
* inspector/formatting/resources/css-tests/url-expected.css: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/inspector/formatting/formatting-css-expected.txt
trunk/LayoutTests/inspector/formatting/formatting-css.html
trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/Workers/Formatter/CSSFormatter.js
Added Paths
trunk/LayoutTests/inspector/formatting/resources/css-tests/url-expected.css
trunk/LayoutTests/inspector/formatting/resources/css-tests/url.css
Diff
Modified: trunk/LayoutTests/ChangeLog (261771 => 261772)
--- trunk/LayoutTests/ChangeLog 2020-05-16 00:43:54 UTC (rev 261771)
+++ trunk/LayoutTests/ChangeLog 2020-05-16 01:17:21 UTC (rev 261772)
@@ -1,3 +1,15 @@
+2020-05-15 Devin Rousso
+
+Web Inspector: Fails to pretty-print a particular CSS file
+https://bugs.webkit.org/show_bug.cgi?id=211930
+
+Reviewed by Joseph Pecoraro.
+
+* inspector/formatting/formatting-css.html:
+* inspector/formatting/formatting-css-expected.txt:
+* inspector/formatting/resources/css-tests/url.css: Added.
+* inspector/formatting/resources/css-tests/url-expected.css: Added.
+
2020-05-15 Ryan Haddad
media/video-poster-set-after-playback.html is a flaky failure
Modified: trunk/LayoutTests/inspector/formatting/formatting-css-expected.txt (261771 => 261772)
--- trunk/LayoutTests/inspector/formatting/formatting-css-expected.txt 2020-05-16 00:43:54 UTC (rev 261771)
+++ trunk/LayoutTests/inspector/formatting/formatting-css-expected.txt 2020-05-16 01:17:21 UTC (rev 261772)
@@ -9,5 +9,6 @@
PASS: keyframes.css
PASS: media-query.css
PASS: selectors.css
+PASS: url.css
PASS: wrapping.css
Modified: trunk/LayoutTests/inspector/formatting/formatting-css.html (261771 => 261772)
--- trunk/LayoutTests/inspector/formatting/formatting-css.html 2020-05-16 00:43:54 UTC (rev 261771)
+++ trunk/LayoutTests/inspector/formatting/formatting-css.html 2020-05-16 01:17:21 UTC (rev 261772)
@@ -15,6 +15,7 @@
"resources/css-tests/keyframes.css",
"resources/css-tests/media-query.css",
"resources/css-tests/selectors.css",
+"resources/css-tests/url.css",
"resources/css-tests/wrapping.css",
]);
Added: trunk/LayoutTests/inspector/formatting/resources/css-tests/url-expected.css (0 => 261772)
--- trunk/LayoutTests/inspector/formatting/resources/css-tests/url-expected.css (rev 0)
+++ trunk/LayoutTests/inspector/formatting/resources/css-tests/url-expected.css 2020-05-16 01:17:21 UTC (rev 261772)
@@ -0,0 +1,27 @@
+body {
+background: url(basic);
+background: url(with space);
+background: url(' single ');
+background: url(" double ");
+background: url(' nested " double " single ');
+background: url(" nested ' single ' double ");
+background: url(' escaped \' single \' single ');
+background: url(" escaped \" double \" double ");
+background: url(' escaped \\\' single \\\' single ');
+background: url(" escaped \\\" double \\\" double ");
+background: url(' nested /* comment */ single ');
+background: url(" nested /* comment */ dobule ");
+background: url( /* before */ ' single ' /* after */);
+background: url( /* before */ " double " /* after */);
+}
+
+body {
+background-size: cover;
+background-repeat: no-repeat;
+background-image: url("data:image/svg+xml;charset=utf-8,%3Csvg clip-rule='evenodd' fill-rule='evenodd' stroke-linejoin='round' stroke-miterlimit='1.5' viewBox='0 0 200 200' xmlns='http://www.w3.org/2000/svg' xmlns:xlink='http://www.w3.org/1999/xlink'%3E%3CclipPath id='a'%3E%3Cpath d='M0 0h200v200H0z'/%3E%3C/clipPath%3E%3Cg clip-path='url(%23a)' transform='scale(0.5)'%3E%3Cimage height='200' transform='scale(2 2)' width='200' xlink:href=''/%3E%3C/g%3E%3C/svg%3E")
+}
+
+body {
+background-image: linear-gradient(180deg, white, rgba(0, 0, 0, 0) 200px);
+min-height: 200px
+}
Added:
[webkit-changes] [261771] tags/Safari-610.1.13/
Title: [261771] tags/Safari-610.1.13/ Revision 261771 Author alanc...@apple.com Date 2020-05-15 17:43:54 -0700 (Fri, 15 May 2020) Log Message Tag Safari-610.1.13. Added Paths tags/Safari-610.1.13/ Diff ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [261770] trunk/LayoutTests
Title: [261770] trunk/LayoutTests Revision 261770 Author ryanhad...@apple.com Date 2020-05-15 17:03:31 -0700 (Fri, 15 May 2020) Log Message media/video-poster-set-after-playback.html is a flaky failure https://bugs.webkit.org/show_bug.cgi?id=211856 Unreviewed test gardening. * platform/ios/TestExpectations: Mark test as flaky. * platform/mac/TestExpectations: Ditto. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/ios/TestExpectations trunk/LayoutTests/platform/mac/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (261769 => 261770) --- trunk/LayoutTests/ChangeLog 2020-05-15 23:57:24 UTC (rev 261769) +++ trunk/LayoutTests/ChangeLog 2020-05-16 00:03:31 UTC (rev 261770) @@ -1,3 +1,13 @@ +2020-05-15 Ryan Haddad + +media/video-poster-set-after-playback.html is a flaky failure +https://bugs.webkit.org/show_bug.cgi?id=211856 + +Unreviewed test gardening. + +* platform/ios/TestExpectations: Mark test as flaky. +* platform/mac/TestExpectations: Ditto. + 2020-05-15 Antoine Quint Cursor should not update on a 20ms timer Modified: trunk/LayoutTests/platform/ios/TestExpectations (261769 => 261770) --- trunk/LayoutTests/platform/ios/TestExpectations 2020-05-15 23:57:24 UTC (rev 261769) +++ trunk/LayoutTests/platform/ios/TestExpectations 2020-05-16 00:03:31 UTC (rev 261770) @@ -3511,5 +3511,7 @@ media/media-document-audio-repaint.html [ Skip ] media/controls-styling.html [ Skip ] +webkit.org/b/211856 media/video-poster-set-after-playback.html [ Pass Failure ] + webkit.org/b/211261 compositing/iframes/border-radius-composited-frame.html [ Pass ImageOnlyFailure ] webkit.org/b/211261 compositing/iframes/border-uneven-radius-composited-frame.html [ Pass ImageOnlyFailure ] Modified: trunk/LayoutTests/platform/mac/TestExpectations (261769 => 261770) --- trunk/LayoutTests/platform/mac/TestExpectations 2020-05-15 23:57:24 UTC (rev 261769) +++ trunk/LayoutTests/platform/mac/TestExpectations 2020-05-16 00:03:31 UTC (rev 261770) @@ -1953,6 +1953,8 @@ webkit.org/b/210517 storage/indexeddb/result-request-cycle.html [ Pass Failure ] +webkit.org/b/211856 media/video-poster-set-after-playback.html [ Pass Failure ] + # These media controls tests are not relevant on macOS and iOS. media/media-document-audio-repaint.html [ Skip ] media/controls-styling.html [ Skip ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [261769] trunk/Source/WebCore
Title: [261769] trunk/Source/WebCore
Revision 261769
Author commit-qu...@webkit.org
Date 2020-05-15 16:57:24 -0700 (Fri, 15 May 2020)
Log Message
OES_texture_float internal format conversion must depend on WEBGL_color_buffer_float
https://bugs.webkit.org/show_bug.cgi?id=211971
Patch by Kenneth Russell on 2020-05-15
Reviewed by Dean Jackson.
Only adjust the internal formats of textures created for the WebGL
1.0 OES_texture_float extension if the WEBGL_color_buffer_float
extension has been enabled.
Covered by the WebGL 1.0 OES_texture_float conformance tests when
run on iOS with another forthcoming fix to ANGLE which will enable
the OES_texture_float extension on that platform.
* platform/graphics/angle/ExtensionsGLANGLE.cpp:
(WebCore::ExtensionsGLANGLE::ensureEnabled):
(WebCore::ExtensionsGLANGLE::adjustWebGL1TextureInternalFormat):
* platform/graphics/angle/ExtensionsGLANGLE.h:
* platform/graphics/angle/GraphicsContextGLANGLE.cpp:
(WebCore::GraphicsContextGLOpenGL::texImage2DDirect):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/angle/ExtensionsGLANGLE.cpp
trunk/Source/WebCore/platform/graphics/angle/ExtensionsGLANGLE.h
trunk/Source/WebCore/platform/graphics/angle/GraphicsContextGLANGLE.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (261768 => 261769)
--- trunk/Source/WebCore/ChangeLog 2020-05-15 23:43:04 UTC (rev 261768)
+++ trunk/Source/WebCore/ChangeLog 2020-05-15 23:57:24 UTC (rev 261769)
@@ -1,3 +1,25 @@
+2020-05-15 Kenneth Russell
+
+OES_texture_float internal format conversion must depend on WEBGL_color_buffer_float
+https://bugs.webkit.org/show_bug.cgi?id=211971
+
+Reviewed by Dean Jackson.
+
+Only adjust the internal formats of textures created for the WebGL
+1.0 OES_texture_float extension if the WEBGL_color_buffer_float
+extension has been enabled.
+
+Covered by the WebGL 1.0 OES_texture_float conformance tests when
+run on iOS with another forthcoming fix to ANGLE which will enable
+the OES_texture_float extension on that platform.
+
+* platform/graphics/angle/ExtensionsGLANGLE.cpp:
+(WebCore::ExtensionsGLANGLE::ensureEnabled):
+(WebCore::ExtensionsGLANGLE::adjustWebGL1TextureInternalFormat):
+* platform/graphics/angle/ExtensionsGLANGLE.h:
+* platform/graphics/angle/GraphicsContextGLANGLE.cpp:
+(WebCore::GraphicsContextGLOpenGL::texImage2DDirect):
+
2020-05-15 Oriol Brufau
[css-grid] Treat percentages as auto for the minimum contribution
Modified: trunk/Source/WebCore/platform/graphics/angle/ExtensionsGLANGLE.cpp (261768 => 261769)
--- trunk/Source/WebCore/platform/graphics/angle/ExtensionsGLANGLE.cpp 2020-05-15 23:43:04 UTC (rev 261768)
+++ trunk/Source/WebCore/platform/graphics/angle/ExtensionsGLANGLE.cpp 2020-05-15 23:57:24 UTC (rev 261769)
@@ -87,6 +87,11 @@
m_context->makeContextCurrent();
gl::RequestExtensionANGLE(name.ascii().data());
m_enabledExtensions.add(name);
+
+if (name == "GL_CHROMIUM_color_buffer_float_rgba"_s)
+m_webglColorBufferFloatRGBA = true;
+else if (name == "GL_CHROMIUM_color_buffer_float_rgb"_s)
+m_webglColorBufferFloatRGB = true;
}
}
@@ -249,13 +254,11 @@
GCGLenum ExtensionsGLANGLE::adjustWebGL1TextureInternalFormat(GCGLenum internalformat, GCGLenum format, GCGLenum type)
{
// The implementation of WEBGL_color_buffer_float for WebGL 1.0 / ES 2.0 requires a sized
-// internal format. Adjust it if necessary at this lowest level. Note that it does not matter at
-// this point whether the WEBGL_color_buffer_float extension has actually been enabled at higher
-// levels; the enum will be valid or invalid either way.
+// internal format. Adjust it if necessary at this lowest level.
if (type == GL_FLOAT) {
-if (format == GL_RGBA && internalformat == GL_RGBA)
+if (m_webglColorBufferFloatRGBA && format == GL_RGBA && internalformat == GL_RGBA)
return GL_RGBA32F;
-if (format == GL_RGB && internalformat == GL_RGB)
+if (m_webglColorBufferFloatRGB && format == GL_RGB && internalformat == GL_RGB)
return GL_RGB32F;
}
return internalformat;
Modified: trunk/Source/WebCore/platform/graphics/angle/ExtensionsGLANGLE.h (261768 => 261769)
--- trunk/Source/WebCore/platform/graphics/angle/ExtensionsGLANGLE.h 2020-05-15 23:43:04 UTC (rev 261768)
+++ trunk/Source/WebCore/platform/graphics/angle/ExtensionsGLANGLE.h 2020-05-15 23:57:24 UTC (rev 261769)
@@ -148,7 +148,7 @@
void getQueryObjectui64vRobustANGLE(GCGLuint id, GCGLenum pname, GCGLsizei bufSize, GCGLsizei *length, GCGLuint64 *params) override;
// Only for non-WebGL 2.0 contexts.
-static GCGLenum adjustWebGL1TextureInternalFormat(GCGLenum internalformat, GCGLenum format, GCGLenum type);
+GCGLenum adjustWebGL1TextureInternalFormat(GCGLenum
[webkit-changes] [261768] trunk/Tools
Title: [261768] trunk/Tools
Revision 261768
Author ryanhad...@apple.com
Date 2020-05-15 16:43:04 -0700 (Fri, 15 May 2020)
Log Message
[iOS EWS] TestWebKitAPI.WKWebsiteDataStore.RemoveAndFetchData is failing
https://bugs.webkit.org/show_bug.cgi?id=208451
Unreviewed test gardening.
* TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
(TestWebKitAPI::TEST): Re-enable the test for iOS.
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm
Diff
Modified: trunk/Tools/ChangeLog (261767 => 261768)
--- trunk/Tools/ChangeLog 2020-05-15 23:26:01 UTC (rev 261767)
+++ trunk/Tools/ChangeLog 2020-05-15 23:43:04 UTC (rev 261768)
@@ -1,3 +1,13 @@
+2020-05-15 Ryan Haddad
+
+[iOS EWS] TestWebKitAPI.WKWebsiteDataStore.RemoveAndFetchData is failing
+https://bugs.webkit.org/show_bug.cgi?id=208451
+
+Unreviewed test gardening.
+
+* TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
+(TestWebKitAPI::TEST): Re-enable the test for iOS.
+
2020-05-15 Geoffrey Garen
Update Sihui Liu's status to reviewer
Modified: trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm (261767 => 261768)
--- trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm 2020-05-15 23:26:01 UTC (rev 261767)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm 2020-05-15 23:43:04 UTC (rev 261768)
@@ -82,9 +82,6 @@
namespace TestWebKitAPI {
-
-// FIXME: Re-enable this test once webkit.org/b/208451 is resolved.
-#if !PLATFORM(IOS)
TEST(WKWebsiteDataStore, RemoveAndFetchData)
{
readyToContinue = false;
@@ -100,7 +97,6 @@
}];
TestWebKitAPI::Util::run();
}
-#endif // !PLATFORM(IOS)
TEST(WKWebsiteDataStore, RemoveEphemeralData)
{
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [261767] trunk
Title: [261767] trunk
Revision 261767
Author obru...@igalia.com
Date 2020-05-15 16:26:01 -0700 (Fri, 15 May 2020)
Log Message
[css-grid] Treat percentages as auto for the minimum contribution
https://bugs.webkit.org/show_bug.cgi?id=195967
Reviewed by Manuel Rego Casasnovas.
LayoutTests/imported/w3c:
Import WPT test.
* web-platform-tests/css/css-grid/grid-definition/grid-minimum-contribution-with-percentages-expected.txt: Added.
* web-platform-tests/css/css-grid/grid-definition/grid-minimum-contribution-with-percentages.html: Added.
* web-platform-tests/css/css-grid/grid-definition/w3c-import.log:
Source/WebCore:
The minimum contribution of a grid item is the outer size resulting from
the minimum size if the computed preferred size behaves as auto, or the
min-content contribution otherwise.
If the preferred size is a percentage, it should be resolved with
respect to the grid area, which depends on the minimum contribution
of the item. Thus the percentage is cyclic and behaves as auto.
Before this change, WebKit only checked whether the preferred size is
auto, not whether it behaves as auto. In fact this was according to
an older version of the spec, but it was changed in
https://github.com/w3c/csswg-drafts/issues/2367
Test: imported/w3c/web-platform-tests/css/css-grid/grid-definition/grid-minimum-contribution-with-percentages.html
Some cases in the test still fail due to bug 209461.
* rendering/GridTrackSizingAlgorithm.cpp:
(WebCore::GridTrackSizingAlgorithmStrategy::minSizeForChild const):
Modified Paths
trunk/LayoutTests/imported/w3c/ChangeLog
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-grid/grid-definition/w3c-import.log
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/GridTrackSizingAlgorithm.cpp
Added Paths
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-grid/grid-definition/grid-minimum-contribution-with-percentages-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-grid/grid-definition/grid-minimum-contribution-with-percentages.html
Diff
Modified: trunk/LayoutTests/imported/w3c/ChangeLog (261766 => 261767)
--- trunk/LayoutTests/imported/w3c/ChangeLog 2020-05-15 22:39:41 UTC (rev 261766)
+++ trunk/LayoutTests/imported/w3c/ChangeLog 2020-05-15 23:26:01 UTC (rev 261767)
@@ -1,3 +1,16 @@
+2020-05-15 Oriol Brufau
+
+[css-grid] Treat percentages as auto for the minimum contribution
+https://bugs.webkit.org/show_bug.cgi?id=195967
+
+Reviewed by Manuel Rego Casasnovas.
+
+Import WPT test.
+
+* web-platform-tests/css/css-grid/grid-definition/grid-minimum-contribution-with-percentages-expected.txt: Added.
+* web-platform-tests/css/css-grid/grid-definition/grid-minimum-contribution-with-percentages.html: Added.
+* web-platform-tests/css/css-grid/grid-definition/w3c-import.log:
+
2020-05-15 Alex Christensen
Make host parser fail on ^
Added: trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-grid/grid-definition/grid-minimum-contribution-with-percentages-expected.txt (0 => 261767)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-grid/grid-definition/grid-minimum-contribution-with-percentages-expected.txt (rev 0)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-grid/grid-definition/grid-minimum-contribution-with-percentages-expected.txt 2020-05-15 23:26:01 UTC (rev 261767)
@@ -0,0 +1,18 @@
+
+PASS auto - columns
+PASS auto - rows
+PASS min - columns
+FAIL min - rows assert_equals: grid-template-rows expected "50px" but got "150px"
+PASS max - columns
+PASS max - rows
+PASS size - columns
+PASS size - rows
+PASS min max - columns
+FAIL min max - rows assert_equals: grid-template-rows expected "50px" but got "150px"
+PASS min size - columns
+FAIL min size - rows assert_equals: grid-template-rows expected "50px" but got "200px"
+PASS max size - columns
+PASS max size - rows
+PASS min max size - columns
+FAIL min max size - rows assert_equals: grid-template-rows expected "50px" but got "150px"
+
Added: trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-grid/grid-definition/grid-minimum-contribution-with-percentages.html (0 => 261767)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-grid/grid-definition/grid-minimum-contribution-with-percentages.html (rev 0)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-grid/grid-definition/grid-minimum-contribution-with-percentages.html 2020-05-15 23:26:01 UTC (rev 261767)
@@ -0,0 +1,87 @@
+
+
+CSS Grid Layout Test: minimum contribution with percentages
+
+
+
+#grid {
+ display: grid;
+ height: 50px;
+ width: 50px;
+ grid: auto / auto;
+}
+#item {
+ background: cyan;
+}
+#content {
+ height: 100px;
+ width: 100px;
+}
+.min {
+ min-height: calc(100% + 50px);
+ min-width: calc(100% + 50px);
+}
+.max {
+ max-height: calc(100% - 50px);
+ max-width: calc(100% - 50px);
+}
+.size {
+
[webkit-changes] [261766] trunk/Tools
Title: [261766] trunk/Tools
Revision 261766
Author gga...@apple.com
Date 2020-05-15 15:39:41 -0700 (Fri, 15 May 2020)
Log Message
Update Sihui Liu's status to reviewer
https://bugs.webkit.org/show_bug.cgi?id=211966
Reviewed by Per Arne Vollan.
See email thread on webkit-reviewers on 5/7, "Reviewer nomination:
Sihui Liu".
* Scripts/webkitpy/common/config/contributors.json:
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/common/config/contributors.json
Diff
Modified: trunk/Tools/ChangeLog (261765 => 261766)
--- trunk/Tools/ChangeLog 2020-05-15 22:32:55 UTC (rev 261765)
+++ trunk/Tools/ChangeLog 2020-05-15 22:39:41 UTC (rev 261766)
@@ -1,3 +1,15 @@
+2020-05-15 Geoffrey Garen
+
+Update Sihui Liu's status to reviewer
+https://bugs.webkit.org/show_bug.cgi?id=211966
+
+Reviewed by Per Arne Vollan.
+
+See email thread on webkit-reviewers on 5/7, "Reviewer nomination:
+Sihui Liu".
+
+* Scripts/webkitpy/common/config/contributors.json:
+
2020-05-15 Alex Christensen
TestWebKitAPI.WKHTTPCookieStore.Basic is a flaky failure
Modified: trunk/Tools/Scripts/webkitpy/common/config/contributors.json (261765 => 261766)
--- trunk/Tools/Scripts/webkitpy/common/config/contributors.json 2020-05-15 22:32:55 UTC (rev 261765)
+++ trunk/Tools/Scripts/webkitpy/common/config/contributors.json 2020-05-15 22:39:41 UTC (rev 261766)
@@ -5053,7 +5053,7 @@
"nicks" : [
"sihuil"
],
- "status" : "committer"
+ "status" : "reviewer"
},
"Silvia Pfeiffer" : {
"emails" : [
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [261765] trunk/Tools
Title: [261765] trunk/Tools
Revision 261765
Author commit-qu...@webkit.org
Date 2020-05-15 15:32:55 -0700 (Fri, 15 May 2020)
Log Message
TestWebKitAPI.WKHTTPCookieStore.Basic is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=211752
Patch by Alex Christensen on 2020-05-15
Reviewed by Geoffrey Garen.
The ordering of cookiesDidChangeInCookieStore callbacks with regard to other callbacks isn't quite deterministic.
No problem. If the number of callbacks isn't what it is expected, wait until it is.
When I reproduce this test failure, I need to spin the run loop at max once to have it succeed, but the bots may take a few more run loop spins.
Spin until the number of callbacks is the expected value.
* TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm:
(runTestWithWebsiteDataStore):
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm
Diff
Modified: trunk/Tools/ChangeLog (261764 => 261765)
--- trunk/Tools/ChangeLog 2020-05-15 21:55:30 UTC (rev 261764)
+++ trunk/Tools/ChangeLog 2020-05-15 22:32:55 UTC (rev 261765)
@@ -1,5 +1,20 @@
2020-05-15 Alex Christensen
+TestWebKitAPI.WKHTTPCookieStore.Basic is a flaky failure
+https://bugs.webkit.org/show_bug.cgi?id=211752
+
+Reviewed by Geoffrey Garen.
+
+The ordering of cookiesDidChangeInCookieStore callbacks with regard to other callbacks isn't quite deterministic.
+No problem. If the number of callbacks isn't what it is expected, wait until it is.
+When I reproduce this test failure, I need to spin the run loop at max once to have it succeed, but the bots may take a few more run loop spins.
+Spin until the number of callbacks is the expected value.
+
+* TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm:
+(runTestWithWebsiteDataStore):
+
+2020-05-15 Alex Christensen
+
[iOS Simulator] TestWebKitAPI._WKDownload.Resume is a flaky crash
https://bugs.webkit.org/show_bug.cgi?id=211786
Modified: trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm (261764 => 261765)
--- trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm 2020-05-15 21:55:30 UTC (rev 261764)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm 2020-05-15 22:32:55 UTC (rev 261765)
@@ -139,7 +139,8 @@
gotFlag = false;
ASSERT_EQ(cookies.count, 2u);
-ASSERT_EQ(observerCallbacks, 4u);
+while (observerCallbacks != 4u)
+TestWebKitAPI::Util::spinRunLoop();
for (NSHTTPCookie *cookie : cookies) {
if ([cookie.name isEqual:@"CookieName"]) {
@@ -175,7 +176,8 @@
gotFlag = false;
ASSERT_EQ(cookies.count, 1u);
-ASSERT_EQ(observerCallbacks, 6u);
+while (observerCallbacks != 6u)
+TestWebKitAPI::Util::spinRunLoop();
for (NSHTTPCookie *cookie : cookies) {
ASSERT_TRUE([cookie1.get().path isEqualToString:cookie.path]);
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [261764] trunk
Title: [261764] trunk Revision 261764 Author commit-qu...@webkit.org Date 2020-05-15 14:55:30 -0700 (Fri, 15 May 2020) Log Message Make host parser fail on ^ https://bugs.webkit.org/show_bug.cgi?id=211901 Patch by Alex Christensen on 2020-05-15 Reviewed by Geoffrey Garen. LayoutTests/imported/w3c: * web-platform-tests/url/a-element-expected.txt: * web-platform-tests/url/a-element-origin-expected.txt: * web-platform-tests/url/a-element-origin-xhtml-expected.txt: * web-platform-tests/url/a-element-xhtml-expected.txt: * web-platform-tests/url/failure-expected.txt: * web-platform-tests/url/url-constructor-expected.txt: * web-platform-tests/url/url-origin-expected.txt: * web-platform-tests/url/urltestdata.json: Source/WTF: This matches the behavior of Chrome and Firefox, and now the specification! I updated the URL wpt data, and this introduces new PASSes. * wtf/URLParser.cpp: (WTF::isC0Control): (WTF::isForbiddenHostCodePoint): Modified Paths trunk/LayoutTests/imported/w3c/ChangeLog trunk/LayoutTests/imported/w3c/web-platform-tests/url/a-element-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/url/a-element-origin-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/url/a-element-origin-xhtml-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/url/a-element-xhtml-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/url/failure-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/url/url-constructor-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/url/url-origin-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/url/urltestdata.json trunk/Source/WTF/ChangeLog trunk/Source/WTF/wtf/URLParser.cpp Diff Modified: trunk/LayoutTests/imported/w3c/ChangeLog (261763 => 261764) --- trunk/LayoutTests/imported/w3c/ChangeLog 2020-05-15 21:40:16 UTC (rev 261763) +++ trunk/LayoutTests/imported/w3c/ChangeLog 2020-05-15 21:55:30 UTC (rev 261764) @@ -1,3 +1,19 @@ +2020-05-15 Alex Christensen + +Make host parser fail on ^ +https://bugs.webkit.org/show_bug.cgi?id=211901 + +Reviewed by Geoffrey Garen. + +* web-platform-tests/url/a-element-expected.txt: +* web-platform-tests/url/a-element-origin-expected.txt: +* web-platform-tests/url/a-element-origin-xhtml-expected.txt: +* web-platform-tests/url/a-element-xhtml-expected.txt: +* web-platform-tests/url/failure-expected.txt: +* web-platform-tests/url/url-constructor-expected.txt: +* web-platform-tests/url/url-origin-expected.txt: +* web-platform-tests/url/urltestdata.json: + 2020-05-12 Alexey Shvayka Implement @isConstructor bytecode intrinsic and bytecode for that Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/url/a-element-expected.txt (261763 => 261764) --- trunk/LayoutTests/imported/w3c/web-platform-tests/url/a-element-expected.txt 2020-05-15 21:40:16 UTC (rev 261763) +++ trunk/LayoutTests/imported/w3c/web-platform-tests/url/a-element-expected.txt 2020-05-15 21:55:30 UTC (rev 261764) @@ -85,7 +85,7 @@ PASS Parsing: against PASS Parsing: against PASS Parsing: against -FAIL Parsing: against assert_equals: href expected "gopher://example.com/" but got "gopher:/example.com/" +PASS Parsing: against PASS Parsing: against PASS Parsing: against PASS Parsing: against @@ -96,7 +96,7 @@ PASS Parsing: against PASS Parsing: against PASS Parsing: against -FAIL Parsing: against assert_equals: href expected "gopher://example.com/" but got "gopher:example.com/" +PASS Parsing: against PASS Parsing: against PASS Parsing: against PASS Parsing: against @@ -109,6 +109,7 @@ PASS Parsing: <#β> against PASS Parsing: against PASS Parsing: against +PASS Parsing: against PASS Parsing: against PASS Parsing: < File:c|foo\bar.html> against PASS Parsing: against @@ -182,7 +183,7 @@ PASS Parsing: against PASS Parsing: against PASS Parsing: against -FAIL Parsing: against assert_equals: href expected "gopher://foo/" but got "gopher://foo:70/" +PASS Parsing: against PASS Parsing: against PASS Parsing: against PASS Parsing: against @@ -198,7 +199,7 @@ PASS Parsing: against PASS Parsing: against PASS Parsing: against -FAIL Parsing: against assert_equals: href expected "gopher://example.com/" but got "gopher:/example.com/" +PASS Parsing: against PASS Parsing: against PASS Parsing: against PASS Parsing: against @@ -209,7 +210,7 @@ PASS Parsing: against PASS Parsing: against PASS Parsing: against -FAIL Parsing: against assert_equals: href expected "gopher://example.com/" but got "gopher:example.com/" +PASS Parsing: against PASS Parsing: against PASS Parsing: against PASS Parsing: against @@ -308,6 +309,8 @@ PASS Parsing: against PASS Parsing: against PASS Parsing: against +PASS Parsing: against +PASS Parsing:
[webkit-changes] [261763] trunk/Source/JavaScriptCore
Title: [261763] trunk/Source/_javascript_Core Revision 261763 Author keith_mil...@apple.com Date 2020-05-15 14:40:16 -0700 (Fri, 15 May 2020) Log Message Unreviewed, fix internal arm64e build. * dfg/DFGSpeculativeJIT.cpp: Modified Paths trunk/Source/_javascript_Core/ChangeLog trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.cpp Diff Modified: trunk/Source/_javascript_Core/ChangeLog (261762 => 261763) --- trunk/Source/_javascript_Core/ChangeLog 2020-05-15 21:32:37 UTC (rev 261762) +++ trunk/Source/_javascript_Core/ChangeLog 2020-05-15 21:40:16 UTC (rev 261763) @@ -1,5 +1,11 @@ 2020-05-15 Keith Miller +Unreviewed, fix internal arm64e build. + +* dfg/DFGSpeculativeJIT.cpp: + +2020-05-15 Keith Miller + Unreviewed, fix internal fast tls build. * jit/AssemblyHelpers.cpp: Modified: trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.cpp (261762 => 261763) --- trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.cpp 2020-05-15 21:32:37 UTC (rev 261762) +++ trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.cpp 2020-05-15 21:40:16 UTC (rev 261763) @@ -41,6 +41,7 @@ #include "DFGSlowPathGenerator.h" #include "DFGSnippetParams.h" #include "DirectArguments.h" +#include "DisallowMacroScratchRegisterUsage.h" #include "JITBitAndGenerator.h" #include "JITBitOrGenerator.h" #include "JITBitXorGenerator.h" ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [261762] trunk
Title: [261762] trunk
Revision 261762
Author commit-qu...@webkit.org
Date 2020-05-15 14:32:37 -0700 (Fri, 15 May 2020)
Log Message
[iOS Simulator] TestWebKitAPI._WKDownload.Resume is a flaky crash
https://bugs.webkit.org/show_bug.cgi?id=211786
Patch by Alex Christensen on 2020-05-15
Reviewed by Geoffrey Garen.
Source/WebCore/PAL:
* pal/spi/cf/CFNetworkSPI.h:
Use CFNetwork SPI to stop it from unlinking the downloaded file after resuming then completing.
Source/WebKit:
* NetworkProcess/cocoa/NetworkSessionCocoa.mm:
(-[WKNetworkSessionDelegate URLSession:downloadTask:didResumeAtOffset:expectedTotalBytes:]):
Tools:
* TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
(TEST):
Add a short sleep (<1/10s) to make this test so it would've almost always failed without this fix.
Checking the file immediately usually succeeded, but waiting a few run loop iterations revealed that CFNetwork
was deleting resumed then finished downloads.
Modified Paths
trunk/Source/WebCore/PAL/ChangeLog
trunk/Source/WebCore/PAL/pal/spi/cf/CFNetworkSPI.h
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/Download.mm
Diff
Modified: trunk/Source/WebCore/PAL/ChangeLog (261761 => 261762)
--- trunk/Source/WebCore/PAL/ChangeLog 2020-05-15 21:31:22 UTC (rev 261761)
+++ trunk/Source/WebCore/PAL/ChangeLog 2020-05-15 21:32:37 UTC (rev 261762)
@@ -1,3 +1,13 @@
+2020-05-15 Alex Christensen
+
+[iOS Simulator] TestWebKitAPI._WKDownload.Resume is a flaky crash
+https://bugs.webkit.org/show_bug.cgi?id=211786
+
+Reviewed by Geoffrey Garen.
+
+* pal/spi/cf/CFNetworkSPI.h:
+Use CFNetwork SPI to stop it from unlinking the downloaded file after resuming then completing.
+
2020-05-12 Per Arne Vollan
[iOS] Rebuild MobileGestalt cache if needed
Modified: trunk/Source/WebCore/PAL/pal/spi/cf/CFNetworkSPI.h (261761 => 261762)
--- trunk/Source/WebCore/PAL/pal/spi/cf/CFNetworkSPI.h 2020-05-15 21:31:22 UTC (rev 261761)
+++ trunk/Source/WebCore/PAL/pal/spi/cf/CFNetworkSPI.h 2020-05-15 21:32:37 UTC (rev 261762)
@@ -425,6 +425,16 @@
- (void)_setCookiesRemovedHandler:(void(^__nullable)(NSArray* __nullable removedCookies, NSString* __nullable domainForRemovedCookies, bool removeAllCookies))cookiesRemovedHandler onQueue:(dispatch_queue_t __nullable)queue;
@end
+@interface __NSCFLocalDownloadFile
+@end
+@interface __NSCFLocalDownloadFile ()
+@property (readwrite, assign) BOOL skipUnlink;
+@end
+
+@interface NSURLSessionDownloadTask ()
+- (__NSCFLocalDownloadFile *)downloadFile;
+@end
+
@interface NSURLResponse ()
- (void)_setMIMEType:(NSString *)type;
@end
Modified: trunk/Source/WebKit/ChangeLog (261761 => 261762)
--- trunk/Source/WebKit/ChangeLog 2020-05-15 21:31:22 UTC (rev 261761)
+++ trunk/Source/WebKit/ChangeLog 2020-05-15 21:32:37 UTC (rev 261762)
@@ -1,5 +1,15 @@
2020-05-15 Alex Christensen
+[iOS Simulator] TestWebKitAPI._WKDownload.Resume is a flaky crash
+https://bugs.webkit.org/show_bug.cgi?id=211786
+
+Reviewed by Geoffrey Garen.
+
+* NetworkProcess/cocoa/NetworkSessionCocoa.mm:
+(-[WKNetworkSessionDelegate URLSession:downloadTask:didResumeAtOffset:expectedTotalBytes:]):
+
+2020-05-15 Alex Christensen
+
Regression (iOS 13.4, r249142): WKWebView.loading is never reset after a Back navigation in an iframe
https://bugs.webkit.org/show_bug.cgi?id=211449
Modified: trunk/Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm (261761 => 261762)
--- trunk/Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm 2020-05-15 21:31:22 UTC (rev 261761)
+++ trunk/Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm 2020-05-15 21:32:37 UTC (rev 261762)
@@ -955,7 +955,10 @@
- (void)URLSession:(NSURLSession *)session downloadTask:(NSURLSessionDownloadTask *)downloadTask didResumeAtOffset:(int64_t)fileOffset expectedTotalBytes:(int64_t)expectedTotalBytes
{
-notImplemented();
+#if PLATFORM(IOS_FAMILY)
+// This is to work around rdar://problem/63249830
+downloadTask.downloadFile.skipUnlink = YES;
+#endif
}
- (void)URLSession:(NSURLSession *)session dataTask:(NSURLSessionDataTask *)dataTask didBecomeDownloadTask:(NSURLSessionDownloadTask *)downloadTask
Modified: trunk/Tools/ChangeLog (261761 => 261762)
--- trunk/Tools/ChangeLog 2020-05-15 21:31:22 UTC (rev 261761)
+++ trunk/Tools/ChangeLog 2020-05-15 21:32:37 UTC (rev 261762)
@@ -1,5 +1,18 @@
2020-05-15 Alex Christensen
+[iOS Simulator] TestWebKitAPI._WKDownload.Resume is a flaky crash
+https://bugs.webkit.org/show_bug.cgi?id=211786
+
+Reviewed by Geoffrey Garen.
+
+* TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
+(TEST):
+Add a short sleep (<1/10s) to make this test so it would've almost always failed without this fix.
+Checking the file immediately usually succeeded, but
[webkit-changes] [261761] trunk
Title: [261761] trunk
Revision 261761
Author commit-qu...@webkit.org
Date 2020-05-15 14:31:22 -0700 (Fri, 15 May 2020)
Log Message
Regression (iOS 13.4, r249142): WKWebView.loading is never reset after a Back navigation in an iframe
https://bugs.webkit.org/show_bug.cgi?id=211449
Patch by Alex Christensen on 2020-05-15
Reviewed by Geoffrey Garen.
Source/WebKit:
Always call clearPendingAPIRequest in WebPageProxy::didStartProvisionalLoadForFrameShared.
r249142 regressed this and caused more "loading appears to continue forever" bugs fixed in r249890.
This should fix both, by removing the problematic half of r249142.
Covered by an API test.
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::didStartProvisionalLoadForFrameShared):
Tools:
* TestWebKitAPI/Tests/WebKitCocoa/Navigation.mm:
(-[LoadingObserver changesObserved]):
(-[LoadingObserver observeValueForKeyPath:ofObject:change:context:]):
(TEST):
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/WebPageProxy.cpp
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/Navigation.mm
Diff
Modified: trunk/Source/WebKit/ChangeLog (261760 => 261761)
--- trunk/Source/WebKit/ChangeLog 2020-05-15 21:27:07 UTC (rev 261760)
+++ trunk/Source/WebKit/ChangeLog 2020-05-15 21:31:22 UTC (rev 261761)
@@ -1,3 +1,19 @@
+2020-05-15 Alex Christensen
+
+Regression (iOS 13.4, r249142): WKWebView.loading is never reset after a Back navigation in an iframe
+https://bugs.webkit.org/show_bug.cgi?id=211449
+
+Reviewed by Geoffrey Garen.
+
+Always call clearPendingAPIRequest in WebPageProxy::didStartProvisionalLoadForFrameShared.
+r249142 regressed this and caused more "loading appears to continue forever" bugs fixed in r249890.
+This should fix both, by removing the problematic half of r249142.
+
+Covered by an API test.
+
+* UIProcess/WebPageProxy.cpp:
+(WebKit::WebPageProxy::didStartProvisionalLoadForFrameShared):
+
2020-05-15 Adrian Perez de Castro
[GTK3] Bring back usage of GtkMenu for context menus
Modified: trunk/Source/WebKit/UIProcess/WebPageProxy.cpp (261760 => 261761)
--- trunk/Source/WebKit/UIProcess/WebPageProxy.cpp 2020-05-15 21:27:07 UTC (rev 261760)
+++ trunk/Source/WebKit/UIProcess/WebPageProxy.cpp 2020-05-15 21:31:22 UTC (rev 261761)
@@ -,9 +,7 @@
RELEASE_LOG_IF_ALLOWED(Loading, "didStartProvisionalLoadForFrame: frameID = %" PRIu64, frameID.toUInt64());
auto transaction = m_pageLoadState.transaction();
-bool fromAlternateHTMLAPI = !unreachableURL.isEmpty() && unreachableURL == m_pageLoadState.pendingAPIRequestURL();
-if (navigation || fromAlternateHTMLAPI)
-m_pageLoadState.clearPendingAPIRequest(transaction);
+m_pageLoadState.clearPendingAPIRequest(transaction);
if (frame->isMainFrame()) {
process->didStartProvisionalLoadForMainFrame(url);
Modified: trunk/Tools/ChangeLog (261760 => 261761)
--- trunk/Tools/ChangeLog 2020-05-15 21:27:07 UTC (rev 261760)
+++ trunk/Tools/ChangeLog 2020-05-15 21:31:22 UTC (rev 261761)
@@ -1,3 +1,15 @@
+2020-05-15 Alex Christensen
+
+Regression (iOS 13.4, r249142): WKWebView.loading is never reset after a Back navigation in an iframe
+https://bugs.webkit.org/show_bug.cgi?id=211449
+
+Reviewed by Geoffrey Garen.
+
+* TestWebKitAPI/Tests/WebKitCocoa/Navigation.mm:
+(-[LoadingObserver changesObserved]):
+(-[LoadingObserver observeValueForKeyPath:ofObject:change:context:]):
+(TEST):
+
2020-05-15 Chris Dumez
Make sure we use current data store in WKTR's TestController
Modified: trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/Navigation.mm (261760 => 261761)
--- trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/Navigation.mm 2020-05-15 21:27:07 UTC (rev 261760)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/Navigation.mm 2020-05-15 21:31:22 UTC (rev 261761)
@@ -25,6 +25,11 @@
#import "config.h"
+#import "HTTPServer.h"
+#import "PlatformUtilities.h"
+#import "Test.h"
+#import "TestUIDelegate.h"
+#import "TestURLSchemeHandler.h"
#import
#import
#import
@@ -33,9 +38,6 @@
#import
#import
#import
-#import "PlatformUtilities.h"
-#import "Test.h"
-#import "TestURLSchemeHandler.h"
static bool isDone;
static RetainPtr currentNavigation;
@@ -671,4 +673,68 @@
[[webView backForwardList] _removeAllItems];
TestWebKitAPI::Util::run();
}
+
#endif // PLATFORM(MAC)
+
+#if HAVE(NETWORK_FRAMEWORK)
+
+@interface LoadingObserver : NSObject
+@property (nonatomic, readonly) size_t changesObserved;
+@end
+
+@implementation LoadingObserver {
+size_t _changesObserved;
+}
+
+- (size_t)changesObserved
+{
+return _changesObserved;
+}
+
+- (void)observeValueForKeyPath:(NSString *)keyPath ofObject:(id)object change:(NSDictionary *)change context:(void *)context
+{
+EXPECT_WK_STREQ(keyPath, "loading");
+_changesObserved++;
+}
+
+@end
+
[webkit-changes] [261760] trunk/LayoutTests
Title: [261760] trunk/LayoutTests Revision 261760 Author grao...@webkit.org Date 2020-05-15 14:27:07 -0700 (Fri, 15 May 2020) Log Message Cursor should not update on a 20ms timer https://bugs.webkit.org/show_bug.cgi?id=211884 Unreviewed. This is a mouse-specific test and should not be run on iOS. * platform/ios/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/ios/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (261759 => 261760) --- trunk/LayoutTests/ChangeLog 2020-05-15 21:04:51 UTC (rev 261759) +++ trunk/LayoutTests/ChangeLog 2020-05-15 21:27:07 UTC (rev 261760) @@ -1,3 +1,15 @@ +2020-05-15 Antoine Quint + +Cursor should not update on a 20ms timer +https://bugs.webkit.org/show_bug.cgi?id=211884 + + +Unreviewed. + +This is a mouse-specific test and should not be run on iOS. + +* platform/ios/TestExpectations: + 2020-05-15 Jason Lawrence [ iOS wk2 ] css2.1/20110323/replaced-intrinsic-ratio-001.htm is flaky failing. Modified: trunk/LayoutTests/platform/ios/TestExpectations (261759 => 261760) --- trunk/LayoutTests/platform/ios/TestExpectations 2020-05-15 21:04:51 UTC (rev 261759) +++ trunk/LayoutTests/platform/ios/TestExpectations 2020-05-15 21:27:07 UTC (rev 261760) @@ -486,6 +486,7 @@ fast/events/mouse-cursor-image-set.html [ Skip ] fast/events/mouse-cursor-multiframecur.html [ Skip ] fast/events/mouse-cursor-no-mousemove.html [ Skip ] +fast/events/mouse-cursor-udpate-during-raf.html [ Skip ] fast/events/mouse-cursor.html [ Skip ] fast/events/mouse-drag-from-frame-to-other-frame.html [ Skip ] fast/events/mouse-drag-from-frame.html [ Skip ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [261759] trunk/LayoutTests
Title: [261759] trunk/LayoutTests Revision 261759 Author lawrenc...@apple.com Date 2020-05-15 14:04:51 -0700 (Fri, 15 May 2020) Log Message [ iOS wk2 ] css2.1/20110323/replaced-intrinsic-ratio-001.htm is flaky failing. https://bugs.webkit.org/show_bug.cgi?id=209350 Unreviewed test gardening. * platform/ios-wk2/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/ios-wk2/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (261758 => 261759) --- trunk/LayoutTests/ChangeLog 2020-05-15 20:50:18 UTC (rev 261758) +++ trunk/LayoutTests/ChangeLog 2020-05-15 21:04:51 UTC (rev 261759) @@ -1,3 +1,12 @@ +2020-05-15 Jason Lawrence + +[ iOS wk2 ] css2.1/20110323/replaced-intrinsic-ratio-001.htm is flaky failing. +https://bugs.webkit.org/show_bug.cgi?id=209350 + +Unreviewed test gardening. + +* platform/ios-wk2/TestExpectations: + 2020-05-15 Antoine Quint [Web Animations] Animation with a single keyframe is not accelerated Modified: trunk/LayoutTests/platform/ios-wk2/TestExpectations (261758 => 261759) --- trunk/LayoutTests/platform/ios-wk2/TestExpectations 2020-05-15 20:50:18 UTC (rev 261758) +++ trunk/LayoutTests/platform/ios-wk2/TestExpectations 2020-05-15 21:04:51 UTC (rev 261759) @@ -1725,8 +1725,6 @@ webkit.org/b/209281 imported/w3c/web-platform-tests/fetch/stale-while-revalidate/frame-removal.html [ Pass Failure ] -webkit.org/b/209350 css2.1/20110323/replaced-intrinsic-ratio-001.htm [ Pass Failure ] - webkit.org/b/209352 http/tests/security/stylesheet-href-redirect.html [ Pass Timeout ] # Flaky failure is tracked in webkit.org/b/211652 ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [261758] trunk/Tools
Title: [261758] trunk/Tools
Revision 261758
Author cdu...@apple.com
Date 2020-05-15 13:50:18 -0700 (Fri, 15 May 2020)
Log Message
Make sure we use current data store in WKTR's TestController
https://bugs.webkit.org/show_bug.cgi?id=211920
Reviewed by Alex Christensen.
Make sure we use current data store in WKTR's TestController. Currently, a lot of code
uses defaultDataStore(), even though the test may be using another data store (e.g. an
ephemeral one). I suspect this is contributing to test flakiness.
We now also make sure that TestController::websiteDataStore() returns the actual store
that will be used by the test when resetPreferencesToConsistentValues() is called.
Previously, it would not since it would get the store from the m_mainView and m_mainView
would only get initialized after calling resetPreferencesToConsistentValues(). To support
this, we now initialize a m_websiteDataStore member in platformInitializeDataStore(),
which gets called right before resetPreferencesToConsistentValues(). When
platformCreateWebView() gets called right after resetPreferencesToConsistentValues(),
it now simply relies on m_websiteDataStore instead of creating the data store at this
point.
* WebKitTestRunner/TestController.cpp:
(WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
(WTR::TestController::clearServiceWorkerRegistrations):
(WTR::TestController::clearDOMCache):
(WTR::TestController::clearDOMCaches):
(WTR::TestController::hasDOMCache):
(WTR::TestController::domCacheSize):
(WTR::TestController::clearStatisticsDataForDomain):
* WebKitTestRunner/TestInvocation.cpp:
(WTR::TestInvocation::invoke):
(WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/WebKitTestRunner/TestController.cpp
trunk/Tools/WebKitTestRunner/TestController.h
trunk/Tools/WebKitTestRunner/TestInvocation.cpp
trunk/Tools/WebKitTestRunner/cocoa/TestControllerCocoa.mm
Diff
Modified: trunk/Tools/ChangeLog (261757 => 261758)
--- trunk/Tools/ChangeLog 2020-05-15 20:42:09 UTC (rev 261757)
+++ trunk/Tools/ChangeLog 2020-05-15 20:50:18 UTC (rev 261758)
@@ -1,3 +1,36 @@
+2020-05-15 Chris Dumez
+
+Make sure we use current data store in WKTR's TestController
+https://bugs.webkit.org/show_bug.cgi?id=211920
+
+Reviewed by Alex Christensen.
+
+Make sure we use current data store in WKTR's TestController. Currently, a lot of code
+uses defaultDataStore(), even though the test may be using another data store (e.g. an
+ephemeral one). I suspect this is contributing to test flakiness.
+
+We now also make sure that TestController::websiteDataStore() returns the actual store
+that will be used by the test when resetPreferencesToConsistentValues() is called.
+Previously, it would not since it would get the store from the m_mainView and m_mainView
+would only get initialized after calling resetPreferencesToConsistentValues(). To support
+this, we now initialize a m_websiteDataStore member in platformInitializeDataStore(),
+which gets called right before resetPreferencesToConsistentValues(). When
+platformCreateWebView() gets called right after resetPreferencesToConsistentValues(),
+it now simply relies on m_websiteDataStore instead of creating the data store at this
+point.
+
+* WebKitTestRunner/TestController.cpp:
+(WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
+(WTR::TestController::clearServiceWorkerRegistrations):
+(WTR::TestController::clearDOMCache):
+(WTR::TestController::clearDOMCaches):
+(WTR::TestController::hasDOMCache):
+(WTR::TestController::domCacheSize):
+(WTR::TestController::clearStatisticsDataForDomain):
+* WebKitTestRunner/TestInvocation.cpp:
+(WTR::TestInvocation::invoke):
+(WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
+
2020-05-15 Diego Pino Garcia
[buildbot] Increase blocksize of file transfer in UploadTestResults step
Modified: trunk/Tools/WebKitTestRunner/TestController.cpp (261757 => 261758)
--- trunk/Tools/WebKitTestRunner/TestController.cpp 2020-05-15 20:42:09 UTC (rev 261757)
+++ trunk/Tools/WebKitTestRunner/TestController.cpp 2020-05-15 20:50:18 UTC (rev 261758)
@@ -556,7 +556,7 @@
WKWebsiteDataStoreRef TestController::websiteDataStore()
{
-return WKPageConfigurationGetWebsiteDataStore(adoptWK(WKPageCopyPageConfiguration(m_mainWebView->page())).get());
+return m_websiteDataStore.get();
}
WKRetainPtr TestController::generatePageConfiguration(const TestOptions& options)
@@ -650,6 +650,7 @@
#endif
auto configuration = generatePageConfiguration(options);
+platformInitializeDataStore(configuration.get(), options);
// Some preferences (notably mock scroll bars setting) currently cannot be re-applied to an existing view, so we need
[webkit-changes] [261757] trunk/Source/JavaScriptCore
Title: [261757] trunk/Source/_javascript_Core
Revision 261757
Author keith_mil...@apple.com
Date 2020-05-15 13:42:09 -0700 (Fri, 15 May 2020)
Log Message
Unreviewed, fix internal fast tls build.
* jit/AssemblyHelpers.cpp:
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/jit/AssemblyHelpers.cpp
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (261756 => 261757)
--- trunk/Source/_javascript_Core/ChangeLog 2020-05-15 20:07:26 UTC (rev 261756)
+++ trunk/Source/_javascript_Core/ChangeLog 2020-05-15 20:42:09 UTC (rev 261757)
@@ -1,3 +1,9 @@
+2020-05-15 Keith Miller
+
+Unreviewed, fix internal fast tls build.
+
+* jit/AssemblyHelpers.cpp:
+
2020-05-15 Ross Kirsling
[IWYU] Remove unnecessary includes from JSC implementation files
Modified: trunk/Source/_javascript_Core/jit/AssemblyHelpers.cpp (261756 => 261757)
--- trunk/Source/_javascript_Core/jit/AssemblyHelpers.cpp 2020-05-15 20:07:26 UTC (rev 261756)
+++ trunk/Source/_javascript_Core/jit/AssemblyHelpers.cpp 2020-05-15 20:42:09 UTC (rev 261757)
@@ -38,6 +38,7 @@
#if ENABLE(WEBASSEMBLY)
#include "WasmMemoryInformation.h"
+#include "WasmContextInlines.h"
#endif
namespace JSC {
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [261756] trunk
Title: [261756] trunk
Revision 261756
Author grao...@webkit.org
Date 2020-05-15 13:07:26 -0700 (Fri, 15 May 2020)
Log Message
[Web Animations] Animation with a single keyframe is not accelerated
https://bugs.webkit.org/show_bug.cgi?id=188730
Reviewed by Dean Jackson.
Source/WebCore:
Test: webanimations/accelerated-animation-single-keyframe.html
Prior to attempting to run an accelerated effect, ensure that the KeyframeList passed to
RenderLayerModelObject::startAnimation() does not have implicit keyframes since eventually
GraphicsLayerCA::animationCanBeAccelerated() would be called and would reject a single-keyframe
animation. To do this, we use the same code used in Style::Resolver::keyframeStylesForAnimation()
which we refactor in the new KeyframeList::fillImplicitKeyframes() method.
* animation/KeyframeEffect.cpp:
(WebCore::KeyframeEffect::copyPropertiesFromSource):
(WebCore::KeyframeEffect::applyPendingAcceleratedActions):
* rendering/style/KeyframeList.cpp:
(WebCore::KeyframeList::hasImplicitKeyframes const):
(WebCore::KeyframeList::copyKeyframes):
(WebCore::zeroPercentKeyframe):
(WebCore::hundredPercentKeyframe):
(WebCore::KeyframeList::fillImplicitKeyframes):
* rendering/style/KeyframeList.h:
* style/StyleResolver.cpp:
(WebCore::Style::Resolver::keyframeStylesForAnimation):
LayoutTests:
Add a new test that runs a single-keyframe transform animation and checks that it runs accelerated.
* webanimations/accelerated-animation-single-keyframe-expected.txt: Added.
* webanimations/accelerated-animation-single-keyframe.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/animation/KeyframeEffect.cpp
trunk/Source/WebCore/rendering/style/KeyframeList.cpp
trunk/Source/WebCore/rendering/style/KeyframeList.h
trunk/Source/WebCore/style/StyleResolver.cpp
Added Paths
trunk/LayoutTests/webanimations/accelerated-animation-single-keyframe-expected.txt
trunk/LayoutTests/webanimations/accelerated-animation-single-keyframe.html
Diff
Modified: trunk/LayoutTests/ChangeLog (261755 => 261756)
--- trunk/LayoutTests/ChangeLog 2020-05-15 19:39:36 UTC (rev 261755)
+++ trunk/LayoutTests/ChangeLog 2020-05-15 20:07:26 UTC (rev 261756)
@@ -1,3 +1,16 @@
+2020-05-15 Antoine Quint
+
+[Web Animations] Animation with a single keyframe is not accelerated
+https://bugs.webkit.org/show_bug.cgi?id=188730
+
+
+Reviewed by Dean Jackson.
+
+Add a new test that runs a single-keyframe transform animation and checks that it runs accelerated.
+
+* webanimations/accelerated-animation-single-keyframe-expected.txt: Added.
+* webanimations/accelerated-animation-single-keyframe.html: Added.
+
2020-05-15 Eric Carlson
media/video-poster-set-after-playback.html is a flaky failure
Added: trunk/LayoutTests/webanimations/accelerated-animation-single-keyframe-expected.txt (0 => 261756)
--- trunk/LayoutTests/webanimations/accelerated-animation-single-keyframe-expected.txt (rev 0)
+++ trunk/LayoutTests/webanimations/accelerated-animation-single-keyframe-expected.txt 2020-05-15 20:07:26 UTC (rev 261756)
@@ -0,0 +1,3 @@
+
+PASS A transform animation with a single keyframe should be able to run accelerated.
+
Added: trunk/LayoutTests/webanimations/accelerated-animation-single-keyframe.html (0 => 261756)
--- trunk/LayoutTests/webanimations/accelerated-animation-single-keyframe.html (rev 0)
+++ trunk/LayoutTests/webanimations/accelerated-animation-single-keyframe.html 2020-05-15 20:07:26 UTC (rev 261756)
@@ -0,0 +1,34 @@
+
+
+
+
+#target {
+position: absolute;
+left: 0;
+top: 0;
+width: 100px;
+height: 100px;
+background-color: black;
+}
+
+
+
+