date:20200806

[webkit-changes] [265363] trunk/LayoutTests

2020-08-06 Thread lmoura

Title: [265363] trunk/LayoutTests








Revision 265363
Author lmo...@igalia.com
Date 2020-08-06 22:29:02 -0700 (Thu, 06 Aug 2020)


Log Message
[GTK][WPE] Gardening some tests and rebaseline after imagebitmap update

Unreviewed test gardening.

* platform/glib/TestExpectations:
* platform/glib/animations/steps-transform-rendering-updates-expected.txt: Added.
* platform/glib/imported/w3c/web-platform-tests/html/canvas/element/imagebitmap/canvas-createImageBitmap-resize-expected.txt:
* platform/glib/imported/w3c/web-platform-tests/html/canvas/element/imagebitmap/createImageBitmap-drawImage-expected.txt:
* platform/glib/imported/w3c/web-platform-tests/html/canvas/element/imagebitmap/createImageBitmap-flipY-expected.txt:
* platform/glib/imported/w3c/web-platform-tests/html/canvas/element/imagebitmap/createImageBitmap-invalid-args-expected.txt:
* platform/glib/imported/w3c/web-platform-tests/html/canvas/element/imagebitmap/createImageBitmap-transfer-expected.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/glib/TestExpectations
trunk/LayoutTests/platform/glib/imported/w3c/web-platform-tests/html/canvas/element/imagebitmap/canvas-createImageBitmap-resize-expected.txt
trunk/LayoutTests/platform/glib/imported/w3c/web-platform-tests/html/canvas/element/imagebitmap/createImageBitmap-drawImage-expected.txt
trunk/LayoutTests/platform/glib/imported/w3c/web-platform-tests/html/canvas/element/imagebitmap/createImageBitmap-flipY-expected.txt
trunk/LayoutTests/platform/glib/imported/w3c/web-platform-tests/html/canvas/element/imagebitmap/createImageBitmap-invalid-args-expected.txt
trunk/LayoutTests/platform/glib/imported/w3c/web-platform-tests/html/canvas/element/imagebitmap/createImageBitmap-transfer-expected.txt


Added Paths

trunk/LayoutTests/platform/glib/animations/steps-transform-rendering-updates-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (265362 => 265363)

--- trunk/LayoutTests/ChangeLog	2020-08-07 05:12:24 UTC (rev 265362)
+++ trunk/LayoutTests/ChangeLog	2020-08-07 05:29:02 UTC (rev 265363)
@@ -1,3 +1,17 @@
+2020-08-06  Lauro Moura  
+
+[GTK][WPE] Gardening some tests and rebaseline after imagebitmap update
+
+Unreviewed test gardening.
+
+* platform/glib/TestExpectations:
+* platform/glib/animations/steps-transform-rendering-updates-expected.txt: Added.
+* platform/glib/imported/w3c/web-platform-tests/html/canvas/element/imagebitmap/canvas-createImageBitmap-resize-expected.txt:
+* platform/glib/imported/w3c/web-platform-tests/html/canvas/element/imagebitmap/createImageBitmap-drawImage-expected.txt:
+* platform/glib/imported/w3c/web-platform-tests/html/canvas/element/imagebitmap/createImageBitmap-flipY-expected.txt:
+* platform/glib/imported/w3c/web-platform-tests/html/canvas/element/imagebitmap/createImageBitmap-invalid-args-expected.txt:
+* platform/glib/imported/w3c/web-platform-tests/html/canvas/element/imagebitmap/createImageBitmap-transfer-expected.txt:
+
 2020-08-06  Yusuke Suzuki  
 
 Unreviewed, fix fast/css-custom-paint/out-of-memory-while-adding-worklet-module.html test


Modified: trunk/LayoutTests/platform/glib/TestExpectations (265362 => 265363)

--- trunk/LayoutTests/platform/glib/TestExpectations	2020-08-07 05:12:24 UTC (rev 265362)
+++ trunk/LayoutTests/platform/glib/TestExpectations	2020-08-07 05:29:02 UTC (rev 265363)
@@ -10,7 +10,7 @@
 #
 # Never add any tests to this file without opening a bug on bugzilla.webkit.org.
 #
-# Currently the following sections are used, but this is not a fixed list. Some sections
+# Initially the following sections were used, but this is not a fixed list. Some sections
 # (like WebAnimation, PageOverlay, WebGL) will mirror their top-level LayoutTests/
 # folders, but others like CSS and GStreamer may have entries from multiple folders.
 #
@@ -259,6 +259,8 @@
 
 webkit.org/b/214422 imported/w3c/web-platform-tests/webaudio/the-audio-api/the-audiocontext-interface/suspend-after-construct.html [ Failure Pass ]
 
+webkit.org/b/215255 imported/w3c/web-platform-tests/webaudio/the-audio-api/the-audiobuffersourcenode-interface/audiobuffersource-multi-channels.html [ Failure ]
+
 #
 # End of GStreamer-related bugs
 #
@@ -292,6 +294,18 @@
 
 
 #
+# MathML-related bugs
+#
+
+webkit.org/b/215217 [ Debug ] mathml/opentype/munderover-layout-resize.html [ Crash ]
+webkit.org/b/215217 [ Debug ] mathml/presentation/mo-invisible.html [ Crash ]
+
+#
+# End of MathML-related bugs

[webkit-changes] [265362] trunk/LayoutTests

2020-08-06 Thread ysuzuki

Title: [265362] trunk/LayoutTests








Revision 265362
Author ysuz...@apple.com
Date 2020-08-06 22:12:24 -0700 (Thu, 06 Aug 2020)


Log Message
Unreviewed, fix fast/css-custom-paint/out-of-memory-while-adding-worklet-module.html test

It may not throw an exception, depending on GC.

* TestExpectations:
* fast/css-custom-paint/out-of-memory-while-adding-worklet-module-expected.txt:
* fast/css-custom-paint/script-tests/out-of-memory-while-adding-worklet-module.js:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/TestExpectations
trunk/LayoutTests/fast/css-custom-paint/out-of-memory-while-adding-worklet-module-expected.txt
trunk/LayoutTests/fast/css-custom-paint/script-tests/out-of-memory-while-adding-worklet-module.js




Diff

Modified: trunk/LayoutTests/ChangeLog (265361 => 265362)

--- trunk/LayoutTests/ChangeLog	2020-08-07 01:24:05 UTC (rev 265361)
+++ trunk/LayoutTests/ChangeLog	2020-08-07 05:12:24 UTC (rev 265362)
@@ -1,3 +1,13 @@
+2020-08-06  Yusuke Suzuki  
+
+Unreviewed, fix fast/css-custom-paint/out-of-memory-while-adding-worklet-module.html test
+
+It may not throw an exception, depending on GC.
+
+* TestExpectations:
+* fast/css-custom-paint/out-of-memory-while-adding-worklet-module-expected.txt:
+* fast/css-custom-paint/script-tests/out-of-memory-while-adding-worklet-module.js:
+
 2020-08-06  Kenneth Russell  
 
 Implement createImageBitmap(ImageData)


Modified: trunk/LayoutTests/TestExpectations (265361 => 265362)

--- trunk/LayoutTests/TestExpectations	2020-08-07 01:24:05 UTC (rev 265361)
+++ trunk/LayoutTests/TestExpectations	2020-08-07 05:12:24 UTC (rev 265362)
@@ -1133,6 +1133,9 @@
 webkit.org/b/136078 fast/borders/border-painting-dotted.html [ ImageOnlyFailure ]
 webkit.org/b/136078 fast/borders/border-painting-double.html [ ImageOnlyFailure ]
 
+# Console log may not appear, which depends on GC behavior. So we silence them.
+[ Release ] fast/css-custom-paint/out-of-memory-while-adding-worklet-module.html [ DumpJSConsoleLogInStdErr ]
+
 # Skip this because it is too slow on debug builds.
 [ Debug ] fast/css-custom-paint/out-of-memory-while-adding-worklet-module.html [ Skip ]
 


Modified: trunk/LayoutTests/fast/css-custom-paint/out-of-memory-while-adding-worklet-module-expected.txt (265361 => 265362)

--- trunk/LayoutTests/fast/css-custom-paint/out-of-memory-while-adding-worklet-module-expected.txt	2020-08-07 01:24:05 UTC (rev 265361)
+++ trunk/LayoutTests/fast/css-custom-paint/out-of-memory-while-adding-worklet-module-expected.txt	2020-08-07 05:12:24 UTC (rev 265362)
@@ -1,2 +1 @@
-CONSOLE MESSAGE: RangeError: Out of memory
 


Modified: trunk/LayoutTests/fast/css-custom-paint/script-tests/out-of-memory-while-adding-worklet-module.js (265361 => 265362)

--- trunk/LayoutTests/fast/css-custom-paint/script-tests/out-of-memory-while-adding-worklet-module.js	2020-08-07 01:24:05 UTC (rev 265361)
+++ trunk/LayoutTests/fast/css-custom-paint/script-tests/out-of-memory-while-adding-worklet-module.js	2020-08-07 05:12:24 UTC (rev 265362)
@@ -14,7 +14,7 @@
 } catch { }
 }
 
-var exception;
+var exception = null;
 useAllMemory();
 try {
 for (let i = 0; i < 1000; i++) {
@@ -24,5 +24,8 @@
 exception = e;
 }
 
-if (exception != "RangeError: Out of memory")
-throw "FAIL: expect: 'RangeError: Out of memory', actual: '" + exception + "'";
+// Exception may not be thrown, depends on GC timing.
+if (exception !== null) {
+if (exception != "RangeError: Out of memory")
+throw "FAIL: expect: 'RangeError: Out of memory', actual: '" + exception + "'";
+}






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [265361] trunk

2020-08-06 Thread sihui_liu

Title: [265361] trunk








Revision 265361
Author sihui_...@apple.com
Date 2020-08-06 18:24:05 -0700 (Thu, 06 Aug 2020)


Log Message
Text manipulation: leading and trailing spaces should be ignored when comparing content
https://bugs.webkit.org/show_bug.cgi?id=214878


Reviewed by Ryosuke Niwa.

Source/WebCore:

TextIterator does not emit collapsed space if there is no text emitted before or the last emitted character is
collapsed space. When TextManipulationController starts observing paragraphs, it iterates the whole document and
the range of TextIterator is the range of document. For some text node A in the document, if TextIterator emits
text for some other text node B before it, the collapsed space at the beginning of A will be emitted, and
TextManipulationController would think the emitted space is part of A's content. When TextManipulationController
replaces content for A, and the range of TextIterator is set to the range of A, the collapsed space is not
emitted. The check to ensure A's content is unchanged would fail.

To solve this issue, for first and last token in the paragraph, TextManipulationController checks content after
removing leading and trailing spaces.

API test: TextManipulation.CompleteTextManipulationParagraphsContainCollapsedSpaces

* editing/TextManipulationController.cpp:
(WebCore::areEqualIgnoringLeadingAndTrailingWhitespaces):
(WebCore::TextManipulationController::replace):

Tools:

* TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm:
(TestWebKitAPI::TEST):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/editing/TextManipulationController.cpp
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm




Diff

Modified: trunk/Source/WebCore/ChangeLog (265360 => 265361)

--- trunk/Source/WebCore/ChangeLog	2020-08-07 01:18:37 UTC (rev 265360)
+++ trunk/Source/WebCore/ChangeLog	2020-08-07 01:24:05 UTC (rev 265361)
@@ -1,3 +1,28 @@
+2020-08-06  Sihui Liu  
+
+Text manipulation: leading and trailing spaces should be ignored when comparing content
+https://bugs.webkit.org/show_bug.cgi?id=214878
+
+
+Reviewed by Ryosuke Niwa.
+
+TextIterator does not emit collapsed space if there is no text emitted before or the last emitted character is 
+collapsed space. When TextManipulationController starts observing paragraphs, it iterates the whole document and
+the range of TextIterator is the range of document. For some text node A in the document, if TextIterator emits 
+text for some other text node B before it, the collapsed space at the beginning of A will be emitted, and 
+TextManipulationController would think the emitted space is part of A's content. When TextManipulationController
+replaces content for A, and the range of TextIterator is set to the range of A, the collapsed space is not 
+emitted. The check to ensure A's content is unchanged would fail.
+ 
+To solve this issue, for first and last token in the paragraph, TextManipulationController checks content after 
+removing leading and trailing spaces.
+ 
+API test: TextManipulation.CompleteTextManipulationParagraphsContainCollapsedSpaces
+
+* editing/TextManipulationController.cpp:
+(WebCore::areEqualIgnoringLeadingAndTrailingWhitespaces):
+(WebCore::TextManipulationController::replace):
+
 2020-08-06  Kenneth Russell  
 
 Implement createImageBitmap(ImageData)


Modified: trunk/Source/WebCore/editing/TextManipulationController.cpp (265360 => 265361)

--- trunk/Source/WebCore/editing/TextManipulationController.cpp	2020-08-07 01:18:37 UTC (rev 265360)
+++ trunk/Source/WebCore/editing/TextManipulationController.cpp	2020-08-07 01:24:05 UTC (rev 265361)
@@ -281,6 +281,11 @@
 return element.hasTagName(HTMLNames::titleTag) || element.hasTagName(HTMLNames::optionTag);
 }
 
+static bool areEqualIgnoringLeadingAndTrailingWhitespaces(const String& content, const String& originalContent)
+{
+return content.stripWhiteSpace() == originalContent.stripWhiteSpace();
+}
+
 static Optional tokenInfo(Node* node)
 {
 if (!node)
@@ -793,7 +798,13 @@
 return ManipulationFailureType::ContentChanged;
 
 auto& currentToken = item.tokens[currentTokenIndex++];
-if (!content.isReplacedContent && currentToken.content != token.content)
+bool isContentUnchanged = currentToken.content == token.content;
+if (!UNLIKELY(isContentUnchanged)) {
+bool isFirstOrLastToken = currentTokenIndex == 1 || currentTokenIndex == item.tokens.size();
+isContentUnchanged = isFirstOrLastToken && areEqualIgnoringLeadingAndTrailingWhitespaces(currentToken.content, token.content);
+}
+
+if (!content.isReplacedContent && !isContentUnchanged)
 return ManipulationFailureType::ContentChanged;

[webkit-changes] [265359] trunk/LayoutTests

2020-08-06 Thread hector_i_lopez

Title: [265359] trunk/LayoutTests








Revision 265359
Author hector_i_lo...@apple.com
Date 2020-08-06 18:05:51 -0700 (Thu, 06 Aug 2020)


Log Message
[macOS iOS] imported/w3c/web-platform-tests/webrtc/RTCRtpTransceiver.https.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=214197

Unreviewed test gardening.

* TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (265358 => 265359)

--- trunk/LayoutTests/ChangeLog	2020-08-07 00:57:45 UTC (rev 265358)
+++ trunk/LayoutTests/ChangeLog	2020-08-07 01:05:51 UTC (rev 265359)
@@ -1,3 +1,12 @@
+2020-08-06  Hector Lopez  
+
+[macOS iOS] imported/w3c/web-platform-tests/webrtc/RTCRtpTransceiver.https.html is a flaky failure
+https://bugs.webkit.org/show_bug.cgi?id=214197
+
+Unreviewed test gardening.
+
+* TestExpectations:
+
 2020-08-06  Simon Fraser  
 
 Avoid triggering redundant compositing updates when trying ot run a steps() animation on transform


Modified: trunk/LayoutTests/TestExpectations (265358 => 265359)

--- trunk/LayoutTests/TestExpectations	2020-08-07 00:57:45 UTC (rev 265358)
+++ trunk/LayoutTests/TestExpectations	2020-08-07 01:05:51 UTC (rev 265359)
@@ -1916,7 +1916,7 @@
 webrtc/h264-high.html [ Slow ]
 
 imported/w3c/web-platform-tests/webrtc/RTCRtpReceiver-getSynchronizationSources.https.html [ Slow ]
-webkit.org/b/214197 imported/w3c/web-platform-tests/webrtc/RTCRtpTransceiver.https.html [ Pass Failure ]
+webkit.org/b/214197 imported/w3c/web-platform-tests/webrtc/RTCRtpTransceiver.https.html [ Pass Failure Crash ]
 imported/w3c/web-platform-tests/webrtc/RTCPeerConnection-setLocalDescription-offer.html [ Failure ]
 imported/w3c/web-platform-tests/webrtc/RTCPeerConnection-setLocalDescription-answer.html [ Failure ]
 imported/w3c/web-platform-tests/webrtc/RTCPeerConnection-iceGatheringState.html [ Pass Failure ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [265358] trunk

2020-08-06 Thread simon . fraser

Title: [265358] trunk








Revision 265358
Author simon.fra...@apple.com
Date 2020-08-06 17:57:45 -0700 (Thu, 06 Aug 2020)


Log Message
Avoid triggering redundant compositing updates when trying ot run a steps() animation on transform
https://bugs.webkit.org/show_bug.cgi?id=215241


Reviewed by Zalan Bujtas.

Source/WebCore:

With a steps() timing function and keyframes animating the transform property, KeyframeEffect::applyPendingAcceleratedActions()
tries to restart the animation every time because the GraphicsLayer reports that it didn't start an accelerated animation.
r264856 patched some of this, but we still call animationFinished() every time, and this triggers a compositing update via
the m_owningLayer.setNeeds* calls in RenderLayerBacking::animationFinished().

So don't try to remove the animation if wasn't running. This makes those compositing updates a no-op, which is important
because these animations still invalidate style on every frame (webkit.org/b/215229).

Test: animations/steps-transform-compositing-updates.html

* animation/KeyframeEffect.cpp:
(WebCore::KeyframeEffect::applyPendingAcceleratedActions):

LayoutTests:

animations/steps-transform-rendering-updates.html was landed with a bug; it aliased
the global 'count' variable, and was thus testing the wrong thing. So land a failing
result for the test for now (webkit.org/b/215229 addresses the fix).

* animations/steps-transform-compositing-updates-expected.txt: Copied from LayoutTests/animations/steps-transform-rendering-updates-expected.txt.
* animations/steps-transform-compositing-updates.html: Copied from LayoutTests/animations/steps-transform-rendering-updates.html.
* animations/steps-transform-rendering-updates-expected.txt:
* animations/steps-transform-rendering-updates.html:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/animations/steps-transform-rendering-updates-expected.txt
trunk/LayoutTests/animations/steps-transform-rendering-updates.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/animation/KeyframeEffect.cpp


Added Paths

trunk/LayoutTests/animations/steps-transform-compositing-updates-expected.txt
trunk/LayoutTests/animations/steps-transform-compositing-updates.html
trunk/LayoutTests/platform/win/animations/steps-transform-rendering-updates-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (265357 => 265358)

--- trunk/LayoutTests/ChangeLog	2020-08-07 00:23:50 UTC (rev 265357)
+++ trunk/LayoutTests/ChangeLog	2020-08-07 00:57:45 UTC (rev 265358)
@@ -1,3 +1,20 @@
+2020-08-06  Simon Fraser  
+
+Avoid triggering redundant compositing updates when trying ot run a steps() animation on transform
+https://bugs.webkit.org/show_bug.cgi?id=215241
+
+
+Reviewed by Zalan Bujtas.
+
+animations/steps-transform-rendering-updates.html was landed with a bug; it aliased
+the global 'count' variable, and was thus testing the wrong thing. So land a failing
+result for the test for now (webkit.org/b/215229 addresses the fix).
+
+* animations/steps-transform-compositing-updates-expected.txt: Copied from LayoutTests/animations/steps-transform-rendering-updates-expected.txt.
+* animations/steps-transform-compositing-updates.html: Copied from LayoutTests/animations/steps-transform-rendering-updates.html.
+* animations/steps-transform-rendering-updates-expected.txt:
+* animations/steps-transform-rendering-updates.html:
+
 2020-08-06  Hector Lopez  
 
 [ macOS ] webgpu/whlsl/dont-crash-parsing-enum.html is a flaky failure


Copied: trunk/LayoutTests/animations/steps-transform-compositing-updates-expected.txt (from rev 265357, trunk/LayoutTests/animations/steps-transform-rendering-updates-expected.txt) (0 => 265358)

--- trunk/LayoutTests/animations/steps-transform-compositing-updates-expected.txt	(rev 0)
+++ trunk/LayoutTests/animations/steps-transform-compositing-updates-expected.txt	2020-08-07 00:57:45 UTC (rev 265358)
@@ -0,0 +1,6 @@
+PASS count is 0
+PASS count < 6 is true
+PASS successfullyParsed is true
+
+TEST COMPLETE
+


Copied: trunk/LayoutTests/animations/steps-transform-compositing-updates.html (from rev 265357, trunk/LayoutTests/animations/steps-transform-rendering-updates.html) (0 => 265358)

--- trunk/LayoutTests/animations/steps-transform-compositing-updates.html	(rev 0)
+++ trunk/LayoutTests/animations/steps-transform-compositing-updates.html	2020-08-07 00:57:45 UTC (rev 265358)
@@ -0,0 +1,48 @@
+
+
+
+
+#box {
+width: 100px;
+height: 100px;
+background-color: silver;
+}
+
+#box.animating {
+animation: spinner 0.25s steps(2) 1;
+}
+
+@keyframes spinner {
+from { transform: rotate(0deg); }
+to   { transform: rotate(360deg); }
+}
+
+