[webkit-changes] [279496] trunk/Tools
Title: [279496] trunk/Tools
Revision 279496
Author jbed...@apple.com
Date 2021-07-01 21:05:41 -0700 (Thu, 01 Jul 2021)
Log Message
[run-webkit-tests] Set software_variant from runtime
https://bugs.webkit.org/show_bug.cgi?id=227600
Reviewed by Stephanie Lewis.
* Scripts/webkitpy/xcode/device_type.py:
(DeviceType._define_software_variant_from_hardware_family):
(DeviceType.check_consistency):
(DeviceType.__contains__):
* Scripts/webkitpy/xcode/device_type_unittest.py:
(DeviceTypeTest.test_from_string):
(DeviceTypeTest.test_contained_in):
* Scripts/webkitpy/xcode/simulated_device.py:
(SimulatedDeviceManager._create_device_with_runtime):
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/xcode/device_type.py
trunk/Tools/Scripts/webkitpy/xcode/device_type_unittest.py
trunk/Tools/Scripts/webkitpy/xcode/simulated_device.py
Diff
Modified: trunk/Tools/ChangeLog (279495 => 279496)
--- trunk/Tools/ChangeLog 2021-07-02 03:14:26 UTC (rev 279495)
+++ trunk/Tools/ChangeLog 2021-07-02 04:05:41 UTC (rev 279496)
@@ -1,3 +1,21 @@
+2021-07-01 Jonathan Bedard
+
+[run-webkit-tests] Set software_variant from runtime
+https://bugs.webkit.org/show_bug.cgi?id=227600
+
+
+Reviewed by Stephanie Lewis.
+
+* Scripts/webkitpy/xcode/device_type.py:
+(DeviceType._define_software_variant_from_hardware_family):
+(DeviceType.check_consistency):
+(DeviceType.__contains__):
+* Scripts/webkitpy/xcode/device_type_unittest.py:
+(DeviceTypeTest.test_from_string):
+(DeviceTypeTest.test_contained_in):
+* Scripts/webkitpy/xcode/simulated_device.py:
+(SimulatedDeviceManager._create_device_with_runtime):
+
2021-07-01 Alex Christensen
loadSimulatedRequest: should do same delegate callbacks as loadHTMLString and loadData
Modified: trunk/Tools/Scripts/webkitpy/xcode/device_type.py (279495 => 279496)
--- trunk/Tools/Scripts/webkitpy/xcode/device_type.py 2021-07-02 03:14:26 UTC (rev 279495)
+++ trunk/Tools/Scripts/webkitpy/xcode/device_type.py 2021-07-02 04:05:41 UTC (rev 279496)
@@ -64,7 +64,7 @@
if self.software_variant:
return
-self.software_variant = 'iOS'
+self.software_variant = None
if self.hardware_family.lower().split(' ')[-1].startswith('watch'):
self.hardware_family = 'Apple Watch'
self.software_variant = 'watchOS'
@@ -71,21 +71,20 @@
elif self.hardware_family.lower().split(' ')[-1].startswith('tv'):
self.hardware_family = 'Apple TV'
self.software_variant = 'tvOS'
+elif self.hardware_family.lower().startswith('ipad') or self.hardware_family.lower().startswith('iphone'):
+self.software_variant = 'iOS'
def check_consistency(self):
if self.hardware_family is not None:
-assert self.software_variant is not None
if self.hardware_family == 'Apple Watch':
assert self.software_variant == 'watchOS'
elif self.hardware_family == 'Apple TV':
assert self.software_variant == 'tvOS'
-else:
+elif self.hardware_family in ('iPhone', 'iPad'):
assert self.software_variant == 'iOS'
if self.hardware_type is not None:
assert self.hardware_family is not None
-if self.software_version:
-assert self.software_variant is not None
def __init__(self, hardware_family=None, hardware_type=None, software_version=None, software_variant=None):
"""
@@ -146,11 +145,11 @@
def __contains__(self, other):
assert isinstance(other, DeviceType)
-if self.hardware_family is not None and (not other.hardware_family or self.hardware_family.lower() != other.hardware_family.lower()):
+if self.hardware_family is not None and other.hardware_family is not None and self.hardware_family.lower() != other.hardware_family.lower():
return False
-if self.standardized_hardware_type is not None and (not other.standardized_hardware_type or self.standardized_hardware_type.lower() != other.standardized_hardware_type.lower()):
+if self.standardized_hardware_type is not None and other.standardized_hardware_type is not None and self.standardized_hardware_type.lower() != other.standardized_hardware_type.lower():
return False
-if self.software_variant is not None and (not other.software_variant or self.software_variant.lower() != other.software_variant.lower()):
+if self.software_variant is not None and other.software_variant is not None and self.software_variant.lower() != other.software_variant.lower():
return False
if self.software_version is not None and other.software_version is not None and not other.software_version in self.software_version:
return False
Modified:
[webkit-changes] [279495] trunk/Source
Title: [279495] trunk/Source
Revision 279495
Author cdu...@apple.com
Date 2021-07-01 20:14:26 -0700 (Thu, 01 Jul 2021)
Log Message
[macOS] Suspend WebProcesses that are in the process cache
https://bugs.webkit.org/show_bug.cgi?id=227269
Reviewed by Geoffrey Garen.
Suspend WebProcesses that are in the process cache on macOS to make sure they use no CPU.
* UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::setIsInProcessCache):
(WebKit::WebProcessProxy::platformSuspendProcess):
(WebKit::WebProcessProxy::platformResumeProcess):
* UIProcess/WebProcessProxy.h:
* UIProcess/mac/WebProcessProxyMac.mm:
(WebKit::WebProcessProxy::platformSuspendProcess):
(WebKit::WebProcessProxy::platformResumeProcess):
* WebProcess/WebProcess.cpp:
(WebKit::WebProcess::setIsInProcessCache):
* WebProcess/WebProcess.h:
* WebProcess/WebProcess.messages.in:
Modified Paths
trunk/Source/WebCore/workers/service/context/SWContextManager.cpp
trunk/Source/WebCore/workers/service/context/SWContextManager.h
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/WebProcessProxy.cpp
trunk/Source/WebKit/UIProcess/WebProcessProxy.h
trunk/Source/WebKit/UIProcess/mac/WebProcessProxyMac.mm
trunk/Source/WebKit/WebProcess/WebProcess.cpp
trunk/Source/WebKit/WebProcess/WebProcess.h
trunk/Source/WebKit/WebProcess/WebProcess.messages.in
Diff
Modified: trunk/Source/WebCore/workers/service/context/SWContextManager.cpp (279494 => 279495)
--- trunk/Source/WebCore/workers/service/context/SWContextManager.cpp 2021-07-02 01:45:31 UTC (rev 279494)
+++ trunk/Source/WebCore/workers/service/context/SWContextManager.cpp 2021-07-02 03:14:26 UTC (rev 279495)
@@ -143,6 +143,11 @@
if (completionHandler)
completionHandler();
+if (m_pendingServiceWorkerTerminationRequests.isEmpty()) {
+for (auto& handler : std::exchange(m_whenTerminationRequestsAreDoneHandlers, { }))
+handler();
+}
+
// Spin the runloop before releasing the worker thread proxy, as there would otherwise be
// a race towards its destruction.
callOnMainThread([serviceWorker = WTFMove(serviceWorker)] { });
@@ -149,6 +154,14 @@
});
}
+void SWContextManager::whenTerminationRequestsAreDone(CompletionHandler&& completionHandler)
+{
+if (m_pendingServiceWorkerTerminationRequests.isEmpty())
+return completionHandler();
+
+m_whenTerminationRequestsAreDoneHandlers.append(WTFMove(completionHandler));
+}
+
void SWContextManager::forEachServiceWorkerThread(const WTF::Function& apply)
{
for (auto& workerThread : m_workerMap.values())
Modified: trunk/Source/WebCore/workers/service/context/SWContextManager.h (279494 => 279495)
--- trunk/Source/WebCore/workers/service/context/SWContextManager.h 2021-07-02 01:45:31 UTC (rev 279494)
+++ trunk/Source/WebCore/workers/service/context/SWContextManager.h 2021-07-02 03:14:26 UTC (rev 279495)
@@ -107,6 +107,8 @@
static constexpr Seconds workerTerminationTimeout { 10_s };
static constexpr Seconds syncWorkerTerminationTimeout { 100_ms }; // Only used by layout tests.
+WEBCORE_EXPORT void whenTerminationRequestsAreDone(CompletionHandler&&);
+
private:
SWContextManager() = default;
@@ -128,6 +130,7 @@
Timer m_timeoutTimer;
};
HashMap> m_pendingServiceWorkerTerminationRequests;
+Vector> m_whenTerminationRequestsAreDoneHandlers;
};
} // namespace WebCore
Modified: trunk/Source/WebKit/ChangeLog (279494 => 279495)
--- trunk/Source/WebKit/ChangeLog 2021-07-02 01:45:31 UTC (rev 279494)
+++ trunk/Source/WebKit/ChangeLog 2021-07-02 03:14:26 UTC (rev 279495)
@@ -1,3 +1,25 @@
+2021-07-01 Chris Dumez
+
+[macOS] Suspend WebProcesses that are in the process cache
+https://bugs.webkit.org/show_bug.cgi?id=227269
+
+Reviewed by Geoffrey Garen.
+
+Suspend WebProcesses that are in the process cache on macOS to make sure they use no CPU.
+
+* UIProcess/WebProcessProxy.cpp:
+(WebKit::WebProcessProxy::setIsInProcessCache):
+(WebKit::WebProcessProxy::platformSuspendProcess):
+(WebKit::WebProcessProxy::platformResumeProcess):
+* UIProcess/WebProcessProxy.h:
+* UIProcess/mac/WebProcessProxyMac.mm:
+(WebKit::WebProcessProxy::platformSuspendProcess):
+(WebKit::WebProcessProxy::platformResumeProcess):
+* WebProcess/WebProcess.cpp:
+(WebKit::WebProcess::setIsInProcessCache):
+* WebProcess/WebProcess.h:
+* WebProcess/WebProcess.messages.in:
+
2021-07-01 Alex Christensen
loadSimulatedRequest: should do same delegate callbacks as loadHTMLString and loadData
Modified: trunk/Source/WebKit/UIProcess/WebProcessProxy.cpp (279494 => 279495)
--- trunk/Source/WebKit/UIProcess/WebProcessProxy.cpp 2021-07-02 01:45:31 UTC (rev 279494)
+++ trunk/Source/WebKit/UIProcess/WebProcessProxy.cpp 2021-07-02 03:14:26 UTC (rev 279495)
@@ -289,8 +289,14 @@
[webkit-changes] [279494] trunk
Title: [279494] trunk
Revision 279494
Author commit-qu...@webkit.org
Date 2021-07-01 18:45:31 -0700 (Thu, 01 Jul 2021)
Log Message
loadSimulatedRequest: should do same delegate callbacks as loadHTMLString and loadData
https://bugs.webkit.org/show_bug.cgi?id=227599
Patch by Alex Christensen on 2021-07-01
Reviewed by Chris Dumez.
Source/WebKit:
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::loadSimulatedRequestAndResponse):
Tools:
* TestWebKitAPI/Tests/WebKitCocoa/WKWebViewLoadAPIs.mm:
(TEST):
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/WebProcess/WebPage/WebPage.cpp
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebViewLoadAPIs.mm
Diff
Modified: trunk/Source/WebKit/ChangeLog (279493 => 279494)
--- trunk/Source/WebKit/ChangeLog 2021-07-02 01:36:04 UTC (rev 279493)
+++ trunk/Source/WebKit/ChangeLog 2021-07-02 01:45:31 UTC (rev 279494)
@@ -1,3 +1,13 @@
+2021-07-01 Alex Christensen
+
+loadSimulatedRequest: should do same delegate callbacks as loadHTMLString and loadData
+https://bugs.webkit.org/show_bug.cgi?id=227599
+
+Reviewed by Chris Dumez.
+
+* WebProcess/WebPage/WebPage.cpp:
+(WebKit::WebPage::loadSimulatedRequestAndResponse):
+
2021-07-01 Youenn Fablet
Disable relay for UDP sockets when not needed
Modified: trunk/Source/WebKit/WebProcess/WebPage/WebPage.cpp (279493 => 279494)
--- trunk/Source/WebKit/WebProcess/WebPage/WebPage.cpp 2021-07-02 01:36:04 UTC (rev 279493)
+++ trunk/Source/WebKit/WebProcess/WebPage/WebPage.cpp 2021-07-02 01:45:31 UTC (rev 279494)
@@ -1793,7 +1793,8 @@
m_pendingNavigationID = loadParameters.navigationID;
m_pendingWebsitePolicies = WTFMove(loadParameters.websitePolicies);
-SubstituteData substituteData(WTFMove(sharedBuffer), loadParameters.request.url(), simulatedResponse, SubstituteData::SessionHistoryVisibility::Visible);
+auto unreachableURL = loadParameters.unreachableURLString.isEmpty() ? URL() : URL(URL(), loadParameters.unreachableURLString);
+SubstituteData substituteData(WTFMove(sharedBuffer), unreachableURL, simulatedResponse, SubstituteData::SessionHistoryVisibility::Visible);
// Let the InjectedBundle know we are about to start the load, passing the user data from the UIProcess
// to all the client to set up any needed state.
Modified: trunk/Tools/ChangeLog (279493 => 279494)
--- trunk/Tools/ChangeLog 2021-07-02 01:36:04 UTC (rev 279493)
+++ trunk/Tools/ChangeLog 2021-07-02 01:45:31 UTC (rev 279494)
@@ -1,3 +1,13 @@
+2021-07-01 Alex Christensen
+
+loadSimulatedRequest: should do same delegate callbacks as loadHTMLString and loadData
+https://bugs.webkit.org/show_bug.cgi?id=227599
+
+Reviewed by Chris Dumez.
+
+* TestWebKitAPI/Tests/WebKitCocoa/WKWebViewLoadAPIs.mm:
+(TEST):
+
2021-07-01 Jonathan Bedard
[webkitscmpy] Cache identifiers in Git checkouts (Follow-up fix)
Modified: trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebViewLoadAPIs.mm (279493 => 279494)
--- trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebViewLoadAPIs.mm 2021-07-02 01:36:04 UTC (rev 279493)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebViewLoadAPIs.mm 2021-07-02 01:45:31 UTC (rev 279494)
@@ -32,6 +32,7 @@
#import
#import
#import
+#import
#import
static NSString *exampleURLString = @"https://example.com/";
@@ -82,6 +83,61 @@
[delegate waitForDidFinishNavigation];
}
+TEST(WKWebView, LoadSimulatedRequestDelegateCallbacks)
+{
+enum class Callback : uint8_t {
+NavigationAction,
+NavigationResponse,
+StartProvisional,
+Commit,
+Finish
+};
+
+auto checkCallbacks = [] (const Vector vector) {
+ASSERT_EQ(vector.size(), 4u);
+EXPECT_EQ(vector[0], Callback::NavigationAction);
+EXPECT_EQ(vector[1], Callback::StartProvisional);
+EXPECT_EQ(vector[2], Callback::Commit);
+EXPECT_EQ(vector[3], Callback::Finish);
+};
+
+__block Vector callbacks;
+__block bool finished = false;
+auto delegate = adoptNS([TestNavigationDelegate new]);
+delegate.get().decidePolicyForNavigationAction = ^(WKNavigationAction *, void (^completionHandler)(WKNavigationActionPolicy)) {
+callbacks.append(Callback::NavigationAction);
+completionHandler(WKNavigationActionPolicyAllow);
+};
+delegate.get().decidePolicyForNavigationResponse = ^(WKNavigationResponse *, void (^completionHandler)(WKNavigationResponsePolicy)) {
+callbacks.append(Callback::NavigationResponse);
+completionHandler(WKNavigationResponsePolicyAllow);
+};
+delegate.get().didStartProvisionalNavigation = ^(WKWebView *, WKNavigation *) {
+callbacks.append(Callback::StartProvisional);
+};
+delegate.get().didCommitNavigation = ^(WKWebView *, WKNavigation *) {
+callbacks.append(Callback::Commit);
+};
+delegate.get().didFinishNavigation =
[webkit-changes] [279493] trunk/Source/WebInspectorUI
Title: [279493] trunk/Source/WebInspectorUI
Revision 279493
Author pan...@apple.com
Date 2021-07-01 18:36:04 -0700 (Thu, 01 Jul 2021)
Log Message
Web Inspector: [Regression: r279271] Sources: Breakpoints section in navigation sidebar disappears when Web Inspector becomes taller than 650px
https://bugs.webkit.org/show_bug.cgi?id=227597
Reviewed by Devin Rousso.
As of r279271, flex base size is no longer clamped by max-height. As a result the non-clamped element
(`resources-container`) was sized to the full height of the container, leaving no space for the other sections
to be shown. Removing the `height: 100%;` declaration resolves this by allowing the flex container to lay out
its children as needed. Because the resources container has no maximum height constraint, it still occupies the
remaining height of the container. Each container will also continue to shrink/grow at their prescribed ratio
just as they did before r279271.
* UserInterface/Views/SourcesNavigationSidebarPanel.css:
(@media (min-height: 650px) .sidebar > .panel.navigation.sources > .content > :matches(.call-stack-container, .breakpoints-container, .resources-container, .local-overrides-container)):
Modified Paths
trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/Views/SourcesNavigationSidebarPanel.css
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (279492 => 279493)
--- trunk/Source/WebInspectorUI/ChangeLog 2021-07-02 01:08:44 UTC (rev 279492)
+++ trunk/Source/WebInspectorUI/ChangeLog 2021-07-02 01:36:04 UTC (rev 279493)
@@ -1,3 +1,20 @@
+2021-07-01 Patrick Angle
+
+Web Inspector: [Regression: r279271] Sources: Breakpoints section in navigation sidebar disappears when Web Inspector becomes taller than 650px
+https://bugs.webkit.org/show_bug.cgi?id=227597
+
+Reviewed by Devin Rousso.
+
+As of r279271, flex base size is no longer clamped by max-height. As a result the non-clamped element
+(`resources-container`) was sized to the full height of the container, leaving no space for the other sections
+to be shown. Removing the `height: 100%;` declaration resolves this by allowing the flex container to lay out
+its children as needed. Because the resources container has no maximum height constraint, it still occupies the
+remaining height of the container. Each container will also continue to shrink/grow at their prescribed ratio
+just as they did before r279271.
+
+* UserInterface/Views/SourcesNavigationSidebarPanel.css:
+(@media (min-height: 650px) .sidebar > .panel.navigation.sources > .content > :matches(.call-stack-container, .breakpoints-container, .resources-container, .local-overrides-container)):
+
2021-06-30 Patrick Angle
Web Inspector: Styles: Autocomplete should support function completions
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/SourcesNavigationSidebarPanel.css (279492 => 279493)
--- trunk/Source/WebInspectorUI/UserInterface/Views/SourcesNavigationSidebarPanel.css 2021-07-02 01:08:44 UTC (rev 279492)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/SourcesNavigationSidebarPanel.css 2021-07-02 01:36:04 UTC (rev 279493)
@@ -131,7 +131,6 @@
}
.sidebar > .panel.navigation.sources > .content > :matches(.call-stack-container, .breakpoints-container, .resources-container, .local-overrides-container) {
-height: 100%;
overflow-y: auto;
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [279491] trunk/Source/WebCore
Title: [279491] trunk/Source/WebCore
Revision 279491
Author wilan...@apple.com
Date 2021-07-01 18:07:54 -0700 (Thu, 01 Jul 2021)
Log Message
PCM: Change import from CryptoKitCBridging to CryptoKitPrivate
https://bugs.webkit.org/show_bug.cgi?id=227556
Reviewed by Alex Christensen.
Source/WebCore:
No new tests since no functionality is changed.
* loader/cocoa/PrivateClickMeasurementCocoa.mm:
Changed import from CryptoKitCBridgingSoftLink.h to CryptoKitPrivateSoftLink.h.
Source/WebCore/PAL:
* PAL.xcodeproj/project.pbxproj:
* pal/PlatformMac.cmake:
* pal/cocoa/CryptoKitPrivateSoftLink.h: Renamed from Source/WebCore/PAL/pal/cocoa/CryptoKitCBridgingSoftLink.h.
* pal/cocoa/CryptoKitPrivateSoftLink.mm: Renamed from Source/WebCore/PAL/pal/cocoa/CryptoKitCBridgingSoftLink.mm.
* pal/spi/cocoa/CryptoKitPrivateSPI.h: Renamed from Source/WebCore/PAL/pal/spi/cocoa/CryptoKitCBridgingSPI.h.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/PAL/ChangeLog
trunk/Source/WebCore/PAL/PAL.xcodeproj/project.pbxproj
trunk/Source/WebCore/PAL/pal/PlatformMac.cmake
trunk/Source/WebCore/loader/cocoa/PrivateClickMeasurementCocoa.mm
Added Paths
trunk/Source/WebCore/PAL/pal/cocoa/CryptoKitPrivateSoftLink.h
trunk/Source/WebCore/PAL/pal/cocoa/CryptoKitPrivateSoftLink.mm
trunk/Source/WebCore/PAL/pal/spi/cocoa/CryptoKitPrivateSPI.h
Removed Paths
trunk/Source/WebCore/PAL/pal/cocoa/CryptoKitCBridgingSoftLink.h
trunk/Source/WebCore/PAL/pal/cocoa/CryptoKitCBridgingSoftLink.mm
trunk/Source/WebCore/PAL/pal/spi/cocoa/CryptoKitCBridgingSPI.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (279490 => 279491)
--- trunk/Source/WebCore/ChangeLog 2021-07-02 01:03:53 UTC (rev 279490)
+++ trunk/Source/WebCore/ChangeLog 2021-07-02 01:07:54 UTC (rev 279491)
@@ -1,3 +1,18 @@
+2021-07-01 John Wilander
+
+PCM: Change import from CryptoKitCBridging to CryptoKitPrivate
+https://bugs.webkit.org/show_bug.cgi?id=227556
+
+
+Reviewed by Alex Christensen.
+
+Patch by Frederic Jacobs.
+
+No new tests since no functionality is changed.
+
+* loader/cocoa/PrivateClickMeasurementCocoa.mm:
+Changed import from CryptoKitCBridgingSoftLink.h to CryptoKitPrivateSoftLink.h.
+
2021-07-01 Alex Christensen
Align beacon CORS mode with Chrome and Firefox
Modified: trunk/Source/WebCore/PAL/ChangeLog (279490 => 279491)
--- trunk/Source/WebCore/PAL/ChangeLog 2021-07-02 01:03:53 UTC (rev 279490)
+++ trunk/Source/WebCore/PAL/ChangeLog 2021-07-02 01:07:54 UTC (rev 279491)
@@ -1,3 +1,19 @@
+2021-07-01 John Wilander
+
+PCM: Change import from CryptoKitCBridging to CryptoKitPrivate
+https://bugs.webkit.org/show_bug.cgi?id=227556
+
+
+Reviewed by Alex Christensen.
+
+Patch by Frederic Jacobs.
+
+* PAL.xcodeproj/project.pbxproj:
+* pal/PlatformMac.cmake:
+* pal/cocoa/CryptoKitPrivateSoftLink.h: Renamed from Source/WebCore/PAL/pal/cocoa/CryptoKitCBridgingSoftLink.h.
+* pal/cocoa/CryptoKitPrivateSoftLink.mm: Renamed from Source/WebCore/PAL/pal/cocoa/CryptoKitCBridgingSoftLink.mm.
+* pal/spi/cocoa/CryptoKitPrivateSPI.h: Renamed from Source/WebCore/PAL/pal/spi/cocoa/CryptoKitCBridgingSPI.h.
+
2021-07-01 Amir Mark Jr
Unreviewed, reverting r279452.
Modified: trunk/Source/WebCore/PAL/PAL.xcodeproj/project.pbxproj (279490 => 279491)
--- trunk/Source/WebCore/PAL/PAL.xcodeproj/project.pbxproj 2021-07-02 01:03:53 UTC (rev 279490)
+++ trunk/Source/WebCore/PAL/PAL.xcodeproj/project.pbxproj 2021-07-02 01:07:54 UTC (rev 279491)
@@ -140,8 +140,8 @@
570AB8F920AF6E3D00B8BE87 /* NSXPCConnectionSPI.h in Headers */ = {isa = PBXBuildFile; fileRef = 570AB8F820AF6E3D00B8BE87 /* NSXPCConnectionSPI.h */; };
572A107822B456F500F410C8 /* AuthKitSPI.h in Headers */ = {isa = PBXBuildFile; fileRef = 572A107722B456F500F410C8 /* AuthKitSPI.h */; };
576CA9D622B854AB0030143C /* AppSSOSPI.h in Headers */ = {isa = PBXBuildFile; fileRef = 576CA9D522B854AB0030143C /* AppSSOSPI.h */; };
- 57F1C90925DCF0CF00E8F6EA /* CryptoKitCBridgingSoftLink.h in Headers */ = {isa = PBXBuildFile; fileRef = 57F1C90725DCF0CF00E8F6EA /* CryptoKitCBridgingSoftLink.h */; };
- 57F1C90A25DCF0CF00E8F6EA /* CryptoKitCBridgingSoftLink.mm in Sources */ = {isa = PBXBuildFile; fileRef = 57F1C90825DCF0CF00E8F6EA /* CryptoKitCBridgingSoftLink.mm */; };
+ 57F1C90925DCF0CF00E8F6EA /* CryptoKitPrivateSoftLink.h in Headers */ = {isa = PBXBuildFile; fileRef = 57F1C90725DCF0CF00E8F6EA /* CryptoKitPrivateSoftLink.h */; };
+ 57F1C90A25DCF0CF00E8F6EA /* CryptoKitPrivateSoftLink.mm in Sources */ = {isa = PBXBuildFile; fileRef = 57F1C90825DCF0CF00E8F6EA /* CryptoKitPrivateSoftLink.mm */; };
57FD318A22B3593E008D0E8B /* AppSSOSoftLink.mm in Sources */ = {isa = PBXBuildFile; fileRef = 57FD318922B3593E008D0E8B /* AppSSOSoftLink.mm */; };
57FD318B22B35989008D0E8B /* AppSSOSoftLink.h in Headers */ = {isa = PBXBuildFile;
[webkit-changes] [279490] trunk
Title: [279490] trunk
Revision 279490
Author commit-qu...@webkit.org
Date 2021-07-01 18:03:53 -0700 (Thu, 01 Jul 2021)
Log Message
Align beacon CORS mode with Chrome and Firefox
https://bugs.webkit.org/show_bug.cgi?id=227590
Patch by Alex Christensen on 2021-07-01
Reviewed by Chris Dumez.
LayoutTests/imported/w3c:
* web-platform-tests/beacon/beacon-cors.https.window-expected.txt:
Source/WebCore:
This follows https://w3c.github.io/beacon/#sec-processing-model step 6.3.
Now we pass a WPT test that Chrome and Firefox already passed.
* Modules/beacon/NavigatorBeacon.cpp:
(WebCore::NavigatorBeacon::sendBeacon):
Modified Paths
trunk/LayoutTests/imported/w3c/ChangeLog
trunk/LayoutTests/imported/w3c/web-platform-tests/beacon/beacon-cors.https.window-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/beacon/NavigatorBeacon.cpp
Diff
Modified: trunk/LayoutTests/imported/w3c/ChangeLog (279489 => 279490)
--- trunk/LayoutTests/imported/w3c/ChangeLog 2021-07-02 00:22:27 UTC (rev 279489)
+++ trunk/LayoutTests/imported/w3c/ChangeLog 2021-07-02 01:03:53 UTC (rev 279490)
@@ -1,3 +1,12 @@
+2021-07-01 Alex Christensen
+
+Align beacon CORS mode with Chrome and Firefox
+https://bugs.webkit.org/show_bug.cgi?id=227590
+
+Reviewed by Chris Dumez.
+
+* web-platform-tests/beacon/beacon-cors.https.window-expected.txt:
+
2021-07-01 Youenn Fablet
ReadableStream.getReader do not throw a proper exception when parameter is of wrong type
Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/beacon/beacon-cors.https.window-expected.txt (279489 => 279490)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/beacon/beacon-cors.https.window-expected.txt 2021-07-02 00:22:27 UTC (rev 279489)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/beacon/beacon-cors.https.window-expected.txt 2021-07-02 01:03:53 UTC (rev 279490)
@@ -1,9 +1,9 @@
PASS /common/redirect.py does not support CORS
PASS cross-origin, CORS-safelisted: type = string
-FAIL cross-origin, CORS-safelisted: type = arraybuffer assert_true: timeout expected true got false
+PASS cross-origin, CORS-safelisted: type = arraybuffer
PASS cross-origin, CORS-safelisted: type = form
-FAIL cross-origin, CORS-safelisted: type = blob assert_true: timeout expected true got false
+PASS cross-origin, CORS-safelisted: type = blob
PASS cross-origin, non-CORS-safelisted: failure case (with redirect)
PASS cross-origin, non-CORS-safelisted: failure case (without redirect)
PASS cross-origin, non-CORS-safelisted[credentials=false]
Modified: trunk/Source/WebCore/ChangeLog (279489 => 279490)
--- trunk/Source/WebCore/ChangeLog 2021-07-02 00:22:27 UTC (rev 279489)
+++ trunk/Source/WebCore/ChangeLog 2021-07-02 01:03:53 UTC (rev 279490)
@@ -1,3 +1,16 @@
+2021-07-01 Alex Christensen
+
+Align beacon CORS mode with Chrome and Firefox
+https://bugs.webkit.org/show_bug.cgi?id=227590
+
+Reviewed by Chris Dumez.
+
+This follows https://w3c.github.io/beacon/#sec-processing-model step 6.3.
+Now we pass a WPT test that Chrome and Firefox already passed.
+
+* Modules/beacon/NavigatorBeacon.cpp:
+(WebCore::NavigatorBeacon::sendBeacon):
+
2021-07-01 Amir Mark Jr
Unreviewed, reverting r279481.
Modified: trunk/Source/WebCore/Modules/beacon/NavigatorBeacon.cpp (279489 => 279490)
--- trunk/Source/WebCore/Modules/beacon/NavigatorBeacon.cpp 2021-07-02 00:22:27 UTC (rev 279489)
+++ trunk/Source/WebCore/Modules/beacon/NavigatorBeacon.cpp 2021-07-02 01:03:53 UTC (rev 279490)
@@ -130,7 +130,7 @@
options.sendLoadCallbacks = SendCallbackPolicy::SendCallbacks;
if (body) {
-options.mode = FetchOptions::Mode::Cors;
+options.mode = FetchOptions::Mode::NoCors;
String mimeType;
auto result = FetchBody::extract(WTFMove(body.value()), mimeType);
if (result.hasException())
@@ -142,8 +142,8 @@
request.setHTTPBody(fetchBody.bodyAsFormData());
if (!mimeType.isEmpty()) {
request.setHTTPContentType(mimeType);
-if (isCrossOriginSafeRequestHeader(HTTPHeaderName::ContentType, mimeType))
-options.mode = FetchOptions::Mode::NoCors;
+if (!isCrossOriginSafeRequestHeader(HTTPHeaderName::ContentType, mimeType))
+options.mode = FetchOptions::Mode::Cors;
}
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [279489] trunk/Source/WebCore
Title: [279489] trunk/Source/WebCore
Revision 279489
Author amir_m...@apple.com
Date 2021-07-01 17:22:27 -0700 (Thu, 01 Jul 2021)
Log Message
Unreviewed, reverting r279481.
Broke a pre-existing test
Reverted changeset:
"Move BottomControlsBarHeight and InsideMargin to be computed
at runtime"
https://bugs.webkit.org/show_bug.cgi?id=227505
https://commits.webkit.org/r279481
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/modern-media-controls/controls/inline-media-controls.js
trunk/Source/WebCore/Modules/modern-media-controls/controls/layout-node.js
trunk/Source/WebCore/Modules/modern-media-controls/controls/macos-inline-media-controls.js
trunk/Source/WebCore/Modules/modern-media-controls/controls/media-controls.css
Diff
Modified: trunk/Source/WebCore/ChangeLog (279488 => 279489)
--- trunk/Source/WebCore/ChangeLog 2021-07-02 00:20:52 UTC (rev 279488)
+++ trunk/Source/WebCore/ChangeLog 2021-07-02 00:22:27 UTC (rev 279489)
@@ -1,3 +1,16 @@
+2021-07-01 Amir Mark Jr
+
+Unreviewed, reverting r279481.
+
+Broke a pre-existing test
+
+Reverted changeset:
+
+"Move BottomControlsBarHeight and InsideMargin to be computed
+at runtime"
+https://bugs.webkit.org/show_bug.cgi?id=227505
+https://commits.webkit.org/r279481
+
2021-07-01 Eric Carlson
WebAudio auto-play policy should come from top document
Modified: trunk/Source/WebCore/Modules/modern-media-controls/controls/inline-media-controls.js (279488 => 279489)
--- trunk/Source/WebCore/Modules/modern-media-controls/controls/inline-media-controls.js 2021-07-02 00:20:52 UTC (rev 279488)
+++ trunk/Source/WebCore/Modules/modern-media-controls/controls/inline-media-controls.js 2021-07-02 00:22:27 UTC (rev 279489)
@@ -23,6 +23,9 @@
* OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
*/
+const InsideMargin = 6; // Minimum margin to guarantee around all controls, this constant needs to stay in sync with the --inline-controls-inside-margin CSS variable.
+const BottomControlsBarHeight = 31; // This constant needs to stay in sync with the --inline-controls-bar-height CSS variable.
+
class InlineMediaControls extends MediaControls
{
@@ -130,9 +133,7 @@
this.topLeftControlsBar.visible = this._topLeftControlsBarContainer.children.some(button => button.visible);
// Compute the visible size for the controls bar.
-if (!this._inlineInsideMargin)
-this._inlineInsideMargin = this.computedValueForStylePropertyInPx("--inline-controls-inside-margin");
-this.bottomControlsBar.width = this._shouldUseAudioLayout ? this.width : (this.width - 2 * this._inlineInsideMargin);
+this.bottomControlsBar.width = this._shouldUseAudioLayout ? this.width : (this.width - 2 * InsideMargin);
// Compute the absolute minimum width to display the center control (status label or time control).
const centerControl = this.statusLabel.enabled ? this.statusLabel : this.timeControl;
@@ -217,9 +218,7 @@
// Ensure we position the bottom controls bar at the bottom of the frame, accounting for
// the inside margin, unless this would yield a position outside of the frame.
-if (!this._inlineBottomControlsBarHeight)
-this._inlineBottomControlsBarHeight = this.computedValueForStylePropertyInPx("--inline-controls-bar-height");
-this.bottomControlsBar.y = Math.max(0, this.height - this._inlineBottomControlsBarHeight - this._inlineInsideMargin);
+this.bottomControlsBar.y = Math.max(0, this.height - BottomControlsBarHeight - InsideMargin);
this.bottomControlsBar.children = controlsBarChildren;
if (!this._shouldUseAudioLayout && !this._shouldUseSingleBarLayout)
Modified: trunk/Source/WebCore/Modules/modern-media-controls/controls/layout-node.js (279488 => 279489)
--- trunk/Source/WebCore/Modules/modern-media-controls/controls/layout-node.js 2021-07-02 00:20:52 UTC (rev 279488)
+++ trunk/Source/WebCore/Modules/modern-media-controls/controls/layout-node.js 2021-07-02 00:22:27 UTC (rev 279489)
@@ -229,21 +229,6 @@
this._updateDirtyState();
}
-computedValueForStyleProperty(propertyName)
-{
-return window.getComputedStyle(this.element).getPropertyValue(propertyName);
-}
-
-computedValueForStylePropertyInPx(propertyName)
-{
-const value = this.computedValueForStyleProperty(propertyName);
-if (!value)
-return 0;
-if (!value.endsWith("px"))
-return 0;
-return parseFloat(value);
-}
-
// Protected
layout()
Modified: trunk/Source/WebCore/Modules/modern-media-controls/controls/macos-inline-media-controls.js (279488 => 279489)
--- trunk/Source/WebCore/Modules/modern-media-controls/controls/macos-inline-media-controls.js 2021-07-02 00:20:52 UTC (rev 279488)
+++
[webkit-changes] [279488] trunk/Tools
Title: [279488] trunk/Tools
Revision 279488
Author jbed...@apple.com
Date 2021-07-01 17:20:52 -0700 (Thu, 01 Jul 2021)
Log Message
[webkitscmpy] Cache identifiers in Git checkouts (Follow-up fix)
https://bugs.webkit.org/show_bug.cgi?id=225616
Reviewed by Dewei Zhu.
Python 2's Subprocess is 10x slower than Python 3, which means generating
the cache is impractical in Python 2.
* Scripts/libraries/webkitscmpy/webkitscmpy/local/git.py:
(Git.__init__): Disable cache on Python 2 by default.
* Scripts/libraries/webkitscmpy/webkitscmpy/test/git_unittest.py:
(test_cache): Force Git to use cache.
(test_revision_cache): Ditto.
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/local/git.py
trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/test/git_unittest.py
Diff
Modified: trunk/Tools/ChangeLog (279487 => 279488)
--- trunk/Tools/ChangeLog 2021-07-02 00:08:31 UTC (rev 279487)
+++ trunk/Tools/ChangeLog 2021-07-02 00:20:52 UTC (rev 279488)
@@ -1,5 +1,22 @@
2021-07-01 Jonathan Bedard
+[webkitscmpy] Cache identifiers in Git checkouts (Follow-up fix)
+https://bugs.webkit.org/show_bug.cgi?id=225616
+
+
+Reviewed by Dewei Zhu.
+
+Python 2's Subprocess is 10x slower than Python 3, which means generating
+the cache is impractical in Python 2.
+
+* Scripts/libraries/webkitscmpy/webkitscmpy/local/git.py:
+(Git.__init__): Disable cache on Python 2 by default.
+* Scripts/libraries/webkitscmpy/webkitscmpy/test/git_unittest.py:
+(test_cache): Force Git to use cache.
+(test_revision_cache): Ditto.
+
+2021-07-01 Jonathan Bedard
+
[clean-webkit] Exclude autoinstalled directory
https://bugs.webkit.org/show_bug.cgi?id=227588
Modified: trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/local/git.py (279487 => 279488)
--- trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/local/git.py 2021-07-02 00:08:31 UTC (rev 279487)
+++ trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/local/git.py 2021-07-02 00:20:52 UTC (rev 279488)
@@ -260,10 +260,10 @@
def is_checkout(cls, path):
return run([cls.executable(), 'rev-parse', '--show-toplevel'], cwd=path, capture_output=True).returncode == 0
-def __init__(self, path, dev_branches=None, prod_branches=None, contributors=None, id=None):
+def __init__(self, path, dev_branches=None, prod_branches=None, contributors=None, id=None, cached=sys.version_info > (3, 0)):
super(Git, self).__init__(path, dev_branches=dev_branches, prod_branches=prod_branches, contributors=contributors, id=id)
self._branch = None
-self.cache = self.Cache(self) if self.root_path else None
+self.cache = self.Cache(self) if self.root_path and cached else None
if not self.root_path:
raise OSError('Provided path {} is not a git repository'.format(path))
Modified: trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/test/git_unittest.py (279487 => 279488)
--- trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/test/git_unittest.py 2021-07-02 00:08:31 UTC (rev 279487)
+++ trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/test/git_unittest.py 2021-07-02 00:20:52 UTC (rev 279488)
@@ -368,7 +368,7 @@
def test_cache(self):
for mock in [mocks.local.Git(self.path), mocks.local.Git(self.path, git_svn=True)]:
with mock, OutputCapture():
-repo = local.Git(self.path)
+repo = local.Git(self.path, cached=True)
self.assertEqual(repo.cache.to_hash(identifier='1@main'), '9b8311f25a77ba14923d9d5a6532103f54abefcb')
self.assertEqual(repo.cache.to_identifier(hash='d8bce26fa65c'), '5@main')
@@ -381,7 +381,7 @@
def test_revision_cache(self):
with mocks.local.Git(self.path, git_svn=True), OutputCapture():
-repo = local.Git(self.path)
+repo = local.Git(self.path, cached=True)
self.assertEqual(repo.cache.to_revision(identifier='1@main'), 1)
self.assertEqual(repo.cache.to_identifier(revision='r9'), '5@main')
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [279487] trunk
Title: [279487] trunk
Revision 279487
Author eric.carl...@apple.com
Date 2021-07-01 17:08:31 -0700 (Thu, 01 Jul 2021)
Log Message
WebAudio auto-play policy should come from top document
https://bugs.webkit.org/show_bug.cgi?id=227593
rdar://76920375
Reviewed by Chris Dumez.
Source/WebCore:
Tests: media/auto-play-video-in-about-blank-iframe.html
media/auto-play-web-audio-in-about-blank-iframe.html
* Modules/webaudio/AudioContext.cpp:
(WebCore::AudioContext::constructCommon): Get auto-play policy from document()->topDocument().
* testing/Internals.cpp:
(WebCore::Internals::setDocumentAutoplayPolicy): New method to test auto-play policy.
* testing/Internals.h:
* testing/Internals.idl:
LayoutTests:
* media/auto-play-video-in-about-blank-iframe-expected.txt: Added.
* media/auto-play-video-in-about-blank-iframe.html: Added.
* media/auto-play-web-audio-in-about-blank-iframe-expected.txt: Added.
* media/auto-play-web-audio-in-about-blank-iframe.html: Added.
* media/video-test.js:
(waitForEventWithTimeout): Return event.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/media/video-test.js
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/webaudio/AudioContext.cpp
trunk/Source/WebCore/testing/Internals.cpp
trunk/Source/WebCore/testing/Internals.h
trunk/Source/WebCore/testing/Internals.idl
Added Paths
trunk/LayoutTests/media/auto-play-video-in-about-blank-iframe-expected.txt
trunk/LayoutTests/media/auto-play-video-in-about-blank-iframe.html
trunk/LayoutTests/media/auto-play-web-audio-in-about-blank-iframe-expected.txt
trunk/LayoutTests/media/auto-play-web-audio-in-about-blank-iframe.html
Diff
Modified: trunk/LayoutTests/ChangeLog (279486 => 279487)
--- trunk/LayoutTests/ChangeLog 2021-07-01 23:57:13 UTC (rev 279486)
+++ trunk/LayoutTests/ChangeLog 2021-07-02 00:08:31 UTC (rev 279487)
@@ -1,3 +1,19 @@
+2021-07-01 Eric Carlson
+
+WebAudio auto-play policy should come from top document
+https://bugs.webkit.org/show_bug.cgi?id=227593
+rdar://76920375
+
+Reviewed by Chris Dumez.
+
+* media/auto-play-video-in-about-blank-iframe-expected.txt: Added.
+* media/auto-play-video-in-about-blank-iframe.html: Added.
+* media/auto-play-web-audio-in-about-blank-iframe-expected.txt: Added.
+* media/auto-play-web-audio-in-about-blank-iframe.html: Added.
+
+* media/video-test.js:
+(waitForEventWithTimeout): Return event.
+
2021-07-01 Cameron McCormack
Move some Mac MathML test expectation files around
Added: trunk/LayoutTests/media/auto-play-video-in-about-blank-iframe-expected.txt (0 => 279487)
--- trunk/LayoutTests/media/auto-play-video-in-about-blank-iframe-expected.txt (rev 0)
+++ trunk/LayoutTests/media/auto-play-video-in-about-blank-iframe-expected.txt 2021-07-02 00:08:31 UTC (rev 279487)
@@ -0,0 +1,19 @@
+
+
+*** Test with auto-play policy set to 'Allow'
+EVENT(load)
+EVENT(message)
+PASS: Video auto-played
+
+*** Test with auto-play policy set to 'AllowWithoutSound'
+EVENT(load)
+EVENT(message)
+PASS: Video did not auto-play
+
+*** Test with auto-play policy set to 'Deny'
+EVENT(load)
+EVENT(message)
+PASS: Video did not auto-play
+
+END OF TEST
+
Added: trunk/LayoutTests/media/auto-play-video-in-about-blank-iframe.html (0 => 279487)
--- trunk/LayoutTests/media/auto-play-video-in-about-blank-iframe.html (rev 0)
+++ trunk/LayoutTests/media/auto-play-video-in-about-blank-iframe.html 2021-07-02 00:08:31 UTC (rev 279487)
@@ -0,0 +1,80 @@
+
+
+iframe {
+width: 320px;
+height: 240px;
+}
+
+
+if (window.testRunner) {
+testRunner.waitUntilDone();
+testRunner.dumpAsText();
+}
+
+async function checkAutoPlay(allowed)
+{
+let message = allowed ? "Video auto-played" : "Video did not auto-play";
+let video = iframe.contentDocument.querySelector("video");
+
+let played;
+let counter = 0;
+while (++counter < 20) {
+played = video.ended || video.currentTime != 0;
+if (allowed === played)
+break;
+await new Promise(resolve => setTimeout(resolve, 50));
+}
+
+if (allowed == played)
+consoleWrite(`PASS: ${allowed ? "Video auto-played" : "Video did not auto-play"}`);
+else
+consoleWrite(`FAIL: ${allowed ? "Video did not auto-play" : "Video auto-played"}`);
+}
+
+async function loadVideo(policy, allow)
+{
+consoleWrite(`
*** Test with auto-play policy set to '${policy}'`);
+
+if (window.internals)
+internals.setDocumentAutoplayPolicy(document, policy)
+
+iframe.src = '';
+await waitForEventWithTimeout(iframe, 'load', 4000, '"about:blank" iframe failed to load!');
+
+let script =
[webkit-changes] [279486] trunk/Tools
Title: [279486] trunk/Tools Revision 279486 Author ryanhad...@apple.com Date 2021-07-01 16:57:13 -0700 (Thu, 01 Jul 2021) Log Message [clean-webkit] Exclude autoinstalled directory https://bugs.webkit.org/show_bug.cgi?id=227588 Patch by Jonathan Bedard on 2021-07-01 Reviewed by Alexey Proskuryakov. * Scripts/webkitpy/common/checkout/scm/scm.py: (SCM.discard_untracked_files): Never discard the autoinstalled directory. Modified Paths trunk/Tools/CISupport/ews-build/factories.py trunk/Tools/CISupport/ews-build/factories_unittest.py trunk/Tools/ChangeLog Diff Modified: trunk/Tools/CISupport/ews-build/factories.py (279485 => 279486) --- trunk/Tools/CISupport/ews-build/factories.py 2021-07-01 21:53:06 UTC (rev 279485) +++ trunk/Tools/CISupport/ews-build/factories.py 2021-07-01 23:57:13 UTC (rev 279486) @@ -154,7 +154,6 @@ self.addStep(WaitForCrashCollection()) self.addStep(KillOldProcesses()) self.addStep(RunWebKitTestsInStressMode()) -self.addStep(RunWebKitTestsInStressGuardmallocMode()) self.addStep(TriggerCrashLogSubmission()) self.addStep(SetBuildSummary()) Modified: trunk/Tools/CISupport/ews-build/factories_unittest.py (279485 => 279486) --- trunk/Tools/CISupport/ews-build/factories_unittest.py 2021-07-01 21:53:06 UTC (rev 279485) +++ trunk/Tools/CISupport/ews-build/factories_unittest.py 2021-07-01 23:57:13 UTC (rev 279486) @@ -611,7 +611,6 @@ _BuildStepFactory(steps.WaitForCrashCollection), _BuildStepFactory(steps.KillOldProcesses), _BuildStepFactory(steps.RunWebKitTestsInStressMode), -_BuildStepFactory(steps.RunWebKitTestsInStressGuardmallocMode), _BuildStepFactory(steps.TriggerCrashLogSubmission), _BuildStepFactory(steps.SetBuildSummary), ]) Modified: trunk/Tools/ChangeLog (279485 => 279486) --- trunk/Tools/ChangeLog 2021-07-01 21:53:06 UTC (rev 279485) +++ trunk/Tools/ChangeLog 2021-07-01 23:57:13 UTC (rev 279486) @@ -9,6 +9,21 @@ * Scripts/webkitpy/common/checkout/scm/scm.py: (SCM.discard_untracked_files): Never discard the autoinstalled directory. +2021-07-01 Ryan Haddad + +[Stress Test EWS] Temporarily disable GuardMalloc test mode to avoid false positives +https://bugs.webkit.org/show_bug.cgi?id=227595 + +Reviewed by Aakash Jain. + +Since the infrastructure issue in webkit.org/b/227365 is causing false positives on this queue, +disable it until we can investigate and address the root cause. + +* CISupport/ews-build/factories.py: +(StressTestFactory.__init__): +* CISupport/ews-build/factories_unittest.py: +(TestStressTestFactory.test_stress_test_factory): + 2021-07-01 Wenson Hsieh Selecting or dragging images that contain recognizable text is difficult in Mail compose ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [279485] trunk/LayoutTests
Title: [279485] trunk/LayoutTests Revision 279485 Author hey...@apple.com Date 2021-07-01 14:53:06 -0700 (Thu, 01 Jul 2021) Log Message Move some Mac MathML test expectation files around https://bugs.webkit.org/show_bug.cgi?id=227520 Reviewed by Frédéric Wang. This should make it so that the same test expectation files are used for Monterey as for Big Sur, without needing to add Monterey-specific files. * platform/mac-mojave-wk1/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/mo-minsize-maxsize-001-expected.txt: Renamed from LayoutTests/platform/mac-bigsur-wk1/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/mo-minsize-maxsize-001-expected.txt. * platform/mac-mojave-wk1/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-combining-expected.txt: Copied from LayoutTests/platform/mac-bigsur-wk1/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-combining-expected.txt. * platform/mac-mojave-wk1/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-stretchy-001-expected.txt: Renamed from LayoutTests/platform/mac-bigsur-wk1/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-stretchy-001-expected.txt. * platform/mac-mojave-wk1/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-stretchy-002-expected.txt: Renamed from LayoutTests/platform/mac-bigsur-wk1/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-stretchy-002-expected.txt. * platform/mac-mojave-wk1/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-symmetric-001-expected.txt: Renamed from LayoutTests/platform/mac-bigsur-wk1/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-symmetric-001-expected.txt. * platform/mac-mojave-wk1/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-symmetric-005-expected.txt: Renamed from LayoutTests/platform/mac-bigsur-wk1/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-symmetric-005-expected.txt. * platform/mac-mojave-wk1/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-symmetric-006-expected.txt: Renamed from LayoutTests/platform/mac-bigsur-wk1/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-symmetric-006-expected.txt. * platform/mac-mojave-wk1/imported/w3c/web-platform-tests/mathml/relations/css-styling/padding-border-margin/border-002-expected.txt: Renamed from LayoutTests/platform/mac-bigsur-wk1/imported/w3c/web-platform-tests/mathml/relations/css-styling/padding-border-margin/border-002-expected.txt. * platform/mac/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-combining-expected.txt: Renamed from LayoutTests/platform/mac-bigsur-wk1/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-combining-expected.txt. * platform/mac/imported/w3c/web-platform-tests/mathml/relations/css-styling/padding-border-margin/border-002-expected.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/mac/imported/w3c/web-platform-tests/mathml/relations/css-styling/padding-border-margin/border-002-expected.txt Added Paths trunk/LayoutTests/platform/mac/imported/w3c/web-platform-tests/mathml/presentation-markup/ trunk/LayoutTests/platform/mac/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/ trunk/LayoutTests/platform/mac/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-combining-expected.txt trunk/LayoutTests/platform/mac-mojave-wk1/imported/w3c/web-platform-tests/mathml/ trunk/LayoutTests/platform/mac-mojave-wk1/imported/w3c/web-platform-tests/mathml/presentation-markup/ trunk/LayoutTests/platform/mac-mojave-wk1/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/ trunk/LayoutTests/platform/mac-mojave-wk1/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/mo-minsize-maxsize-001-expected.txt trunk/LayoutTests/platform/mac-mojave-wk1/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-combining-expected.txt trunk/LayoutTests/platform/mac-mojave-wk1/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-stretchy-001-expected.txt trunk/LayoutTests/platform/mac-mojave-wk1/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-stretchy-002-expected.txt trunk/LayoutTests/platform/mac-mojave-wk1/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-symmetric-001-expected.txt
[webkit-changes] [279484] branches/safari-612.1.21-branch/Source
Title: [279484] branches/safari-612.1.21-branch/Source Revision 279484 Author repst...@apple.com Date 2021-07-01 14:32:22 -0700 (Thu, 01 Jul 2021) Log Message Versioning. WebKit-7612.1.21.2 Modified Paths branches/safari-612.1.21-branch/Source/_javascript_Core/Configurations/Version.xcconfig branches/safari-612.1.21-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig branches/safari-612.1.21-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig branches/safari-612.1.21-branch/Source/WebCore/Configurations/Version.xcconfig branches/safari-612.1.21-branch/Source/WebCore/PAL/Configurations/Version.xcconfig branches/safari-612.1.21-branch/Source/WebInspectorUI/Configurations/Version.xcconfig branches/safari-612.1.21-branch/Source/WebKit/Configurations/Version.xcconfig branches/safari-612.1.21-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig Diff Modified: branches/safari-612.1.21-branch/Source/_javascript_Core/Configurations/Version.xcconfig (279483 => 279484) --- branches/safari-612.1.21-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2021-07-01 20:56:00 UTC (rev 279483) +++ branches/safari-612.1.21-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2021-07-01 21:32:22 UTC (rev 279484) @@ -24,7 +24,7 @@ MAJOR_VERSION = 612; MINOR_VERSION = 1; TINY_VERSION = 21; -MICRO_VERSION = 1; +MICRO_VERSION = 2; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION); Modified: branches/safari-612.1.21-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig (279483 => 279484) --- branches/safari-612.1.21-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig 2021-07-01 20:56:00 UTC (rev 279483) +++ branches/safari-612.1.21-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig 2021-07-01 21:32:22 UTC (rev 279484) @@ -24,7 +24,7 @@ MAJOR_VERSION = 612; MINOR_VERSION = 1; TINY_VERSION = 21; -MICRO_VERSION = 1; +MICRO_VERSION = 2; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION); Modified: branches/safari-612.1.21-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (279483 => 279484) --- branches/safari-612.1.21-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig 2021-07-01 20:56:00 UTC (rev 279483) +++ branches/safari-612.1.21-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig 2021-07-01 21:32:22 UTC (rev 279484) @@ -24,7 +24,7 @@ MAJOR_VERSION = 612; MINOR_VERSION = 1; TINY_VERSION = 21; -MICRO_VERSION = 1; +MICRO_VERSION = 2; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION); Modified: branches/safari-612.1.21-branch/Source/WebCore/Configurations/Version.xcconfig (279483 => 279484) --- branches/safari-612.1.21-branch/Source/WebCore/Configurations/Version.xcconfig 2021-07-01 20:56:00 UTC (rev 279483) +++ branches/safari-612.1.21-branch/Source/WebCore/Configurations/Version.xcconfig 2021-07-01 21:32:22 UTC (rev 279484) @@ -24,7 +24,7 @@ MAJOR_VERSION = 612; MINOR_VERSION = 1; TINY_VERSION = 21; -MICRO_VERSION = 1; +MICRO_VERSION = 2; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION); Modified: branches/safari-612.1.21-branch/Source/WebCore/PAL/Configurations/Version.xcconfig (279483 => 279484) --- branches/safari-612.1.21-branch/Source/WebCore/PAL/Configurations/Version.xcconfig 2021-07-01 20:56:00 UTC (rev 279483) +++ branches/safari-612.1.21-branch/Source/WebCore/PAL/Configurations/Version.xcconfig 2021-07-01 21:32:22 UTC (rev 279484) @@ -24,7 +24,7 @@ MAJOR_VERSION = 612; MINOR_VERSION = 1; TINY_VERSION = 21; -MICRO_VERSION = 1; +MICRO_VERSION = 2; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION); Modified: branches/safari-612.1.21-branch/Source/WebInspectorUI/Configurations/Version.xcconfig (279483 => 279484) --- branches/safari-612.1.21-branch/Source/WebInspectorUI/Configurations/Version.xcconfig 2021-07-01 20:56:00 UTC (rev 279483) +++ branches/safari-612.1.21-branch/Source/WebInspectorUI/Configurations/Version.xcconfig 2021-07-01 21:32:22 UTC (rev 279484) @@ -1,7 +1,7 @@ MAJOR_VERSION = 612; MINOR_VERSION = 1; TINY_VERSION = 21; -MICRO_VERSION = 1; +MICRO_VERSION = 2; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION); Modified: branches/safari-612.1.21-branch/Source/WebKit/Configurations/Version.xcconfig (279483 => 279484) --- branches/safari-612.1.21-branch/Source/WebKit/Configurations/Version.xcconfig 2021-07-01 20:56:00 UTC (rev 279483) +++ branches/safari-612.1.21-branch/Source/WebKit/Configurations/Version.xcconfig 2021-07-01 21:32:22 UTC (rev 279484) @@ -24,7 +24,7 @@ MAJOR_VERSION = 612; MINOR_VERSION = 1; TINY_VERSION = 21; -MICRO_VERSION = 1; +MICRO_VERSION = 2; NANO_VERSION = 0; FULL_VERSION =
[webkit-changes] [279483] trunk/Source
Title: [279483] trunk/Source Revision 279483 Author you...@apple.com Date 2021-07-01 13:56:00 -0700 (Thu, 01 Jul 2021) Log Message Disable relay for UDP sockets when not needed https://bugs.webkit.org/show_bug.cgi?id=227253 Source/WebCore: Reviewed by Eric Carlson. * Modules/mediastream/PeerConnectionBackend.h: (WebCore::PeerConnectionBackend::shouldFilterICECandidates const): * Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp: (WebCore::LibWebRTCMediaEndpoint::setConfiguration): * Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.h: (WebCore::LibWebRTCMediaEndpoint::rtcSocketFactory): * Modules/mediastream/libwebrtc/LibWebRTCPeerConnectionBackend.cpp: (WebCore::LibWebRTCPeerConnectionBackend::disableICECandidateFiltering): * Modules/mediastream/libwebrtc/LibWebRTCPeerConnectionBackend.h: * platform/mediastream/libwebrtc/LibWebRTCProvider.h: Source/WebKit: Reviewed by Eric Carlson. * NetworkProcess/webrtc/NetworkRTCProvider.cpp: (WebKit::NetworkRTCProvider::createUDPSocket): * NetworkProcess/webrtc/NetworkRTCProvider.h: * NetworkProcess/webrtc/NetworkRTCProvider.messages.in: * NetworkProcess/webrtc/NetworkRTCUDPSocketCocoa.h: * NetworkProcess/webrtc/NetworkRTCUDPSocketCocoa.mm: (WebKit::NetworkRTCUDPSocketCocoaConnections::create): (WebKit::NetworkRTCUDPSocketCocoa::createUDPSocket): (WebKit::NetworkRTCUDPSocketCocoa::NetworkRTCUDPSocketCocoa): (WebKit::NetworkRTCUDPSocketCocoaConnections::NetworkRTCUDPSocketCocoaConnections): (WebKit::NetworkRTCUDPSocketCocoaConnections::createNWConnection): * WebKit.xcodeproj/project.pbxproj: * WebProcess/Network/webrtc/LibWebRTCProvider.cpp: (WebKit::RTCSocketFactory::RTCSocketFactory): (WebKit::RTCSocketFactory::CreateUdpSocket): (WebKit::LibWebRTCProvider::createSocketFactory): * WebProcess/Network/webrtc/LibWebRTCProvider.h: * WebProcess/Network/webrtc/LibWebRTCSocketFactory.cpp: (WebKit::LibWebRTCSocketFactory::createUdpSocket): * WebProcess/Network/webrtc/LibWebRTCSocketFactory.h: Source/WTF: Reviewed by Eric Carlson. * wtf/PlatformHave.h: Add a macro for new NW methods. Modified Paths trunk/Source/WTF/ChangeLog trunk/Source/WTF/wtf/PlatformHave.h trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/Modules/mediastream/PeerConnectionBackend.h trunk/Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp trunk/Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.h trunk/Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCPeerConnectionBackend.cpp trunk/Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCPeerConnectionBackend.h trunk/Source/WebCore/platform/mediastream/libwebrtc/LibWebRTCProvider.h trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/NetworkProcess/webrtc/NetworkRTCProvider.cpp trunk/Source/WebKit/NetworkProcess/webrtc/NetworkRTCProvider.h trunk/Source/WebKit/NetworkProcess/webrtc/NetworkRTCProvider.messages.in trunk/Source/WebKit/NetworkProcess/webrtc/NetworkRTCUDPSocketCocoa.h trunk/Source/WebKit/NetworkProcess/webrtc/NetworkRTCUDPSocketCocoa.mm trunk/Source/WebKit/WebKit.xcodeproj/project.pbxproj trunk/Source/WebKit/WebProcess/Network/webrtc/LibWebRTCProvider.cpp trunk/Source/WebKit/WebProcess/Network/webrtc/LibWebRTCProvider.h trunk/Source/WebKit/WebProcess/Network/webrtc/LibWebRTCSocketFactory.cpp trunk/Source/WebKit/WebProcess/Network/webrtc/LibWebRTCSocketFactory.h Added Paths trunk/Source/WebKit/Platform/spi/Cocoa/NWParametersSPI.h Diff Modified: trunk/Source/WTF/ChangeLog (279482 => 279483) --- trunk/Source/WTF/ChangeLog 2021-07-01 20:46:56 UTC (rev 279482) +++ trunk/Source/WTF/ChangeLog 2021-07-01 20:56:00 UTC (rev 279483) @@ -1,3 +1,14 @@ +2021-07-01 Youenn Fablet + +Disable relay for UDP sockets when not needed +https://bugs.webkit.org/show_bug.cgi?id=227253 + + +Reviewed by Eric Carlson. + +* wtf/PlatformHave.h: +Add a macro for new NW methods. + 2021-07-01 Antoine Quint [Model] Restrict IPC calls to ARKit SPI availability and runtime flag Modified: trunk/Source/WTF/wtf/PlatformHave.h (279482 => 279483) --- trunk/Source/WTF/wtf/PlatformHave.h 2021-07-01 20:46:56 UTC (rev 279482) +++ trunk/Source/WTF/wtf/PlatformHave.h 2021-07-01 20:56:00 UTC (rev 279483) @@ -546,6 +546,10 @@ #define HAVE_NSURLSESSION_WEBSOCKET 1 #endif +#if (PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 12) || (PLATFORM(IOS_FAMILY) && __IPHONE_OS_VERSION_MIN_REQUIRED >= 15) +#define HAVE_NWPARAMETERS_TRACKER_API 1 +#endif + #if PLATFORM(COCOA) && !(PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED < 101500) && !PLATFORM(MACCATALYST) #define HAVE_AVPLAYER_RESOURCE_CONSERVATION_LEVEL 1 #endif Modified: trunk/Source/WebCore/ChangeLog (279482 => 279483) --- trunk/Source/WebCore/ChangeLog 2021-07-01 20:46:56 UTC (rev 279482) +++ trunk/Source/WebCore/ChangeLog 2021-07-01 20:56:00 UTC (rev 279483) @@ -1,3 +1,21 @@ +2021-07-01 Youenn Fablet + +Disable relay for UDP sockets when not needed +
[webkit-changes] [279482] trunk/Tools
Title: [279482] trunk/Tools Revision 279482 Author jbed...@apple.com Date 2021-07-01 13:46:56 -0700 (Thu, 01 Jul 2021) Log Message [clean-webkit] Exclude autoinstalled directory https://bugs.webkit.org/show_bug.cgi?id=227588 Reviewed by Alexey Proskuryakov. * Scripts/webkitpy/common/checkout/scm/scm.py: (SCM.discard_untracked_files): Never discard the autoinstalled directory. Modified Paths trunk/Tools/ChangeLog trunk/Tools/Scripts/webkitpy/common/checkout/scm/scm.py Diff Modified: trunk/Tools/ChangeLog (279481 => 279482) --- trunk/Tools/ChangeLog 2021-07-01 20:28:32 UTC (rev 279481) +++ trunk/Tools/ChangeLog 2021-07-01 20:46:56 UTC (rev 279482) @@ -1,3 +1,14 @@ +2021-07-01 Jonathan Bedard + +[clean-webkit] Exclude autoinstalled directory +https://bugs.webkit.org/show_bug.cgi?id=227588 + + +Reviewed by Alexey Proskuryakov. + +* Scripts/webkitpy/common/checkout/scm/scm.py: +(SCM.discard_untracked_files): Never discard the autoinstalled directory. + 2021-07-01 Wenson Hsieh Selecting or dragging images that contain recognizable text is difficult in Mail compose Modified: trunk/Tools/Scripts/webkitpy/common/checkout/scm/scm.py (279481 => 279482) --- trunk/Tools/Scripts/webkitpy/common/checkout/scm/scm.py 2021-07-01 20:28:32 UTC (rev 279481) +++ trunk/Tools/Scripts/webkitpy/common/checkout/scm/scm.py 2021-07-01 20:46:56 UTC (rev 279482) @@ -219,6 +219,8 @@ if self._filesystem.isdir(filename): if keep_webkitbuild_directory and filename == "WebKitBuild": continue +if filename == 'Tools/Scripts/libraries/autoinstalled': +continue self._filesystem.rmtree(filename) else: self._filesystem.remove(filename) ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [279481] trunk/Source/WebCore
Title: [279481] trunk/Source/WebCore
Revision 279481
Author d...@apple.com
Date 2021-07-01 13:28:32 -0700 (Thu, 01 Jul 2021)
Log Message
Move BottomControlsBarHeight and InsideMargin to be computed at runtime
https://bugs.webkit.org/show_bug.cgi?id=227505
Reviewed by Devin Rousso.
Rather than having two JS constants that have to be kept in sync
with CSS, simply retrieve the value from the computed style.
No change in behaviour.
* Modules/modern-media-controls/controls/inline-media-controls.js:
(InlineMediaControls.prototype.layout):
* Modules/modern-media-controls/controls/media-controls.css:
(:host(audio), :host(video.media-document.audio), *):
* Modules/modern-media-controls/controls/layout-node.js: Add two helpers to
retrive computed style values.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/modern-media-controls/controls/inline-media-controls.js
trunk/Source/WebCore/Modules/modern-media-controls/controls/layout-node.js
trunk/Source/WebCore/Modules/modern-media-controls/controls/macos-inline-media-controls.js
trunk/Source/WebCore/Modules/modern-media-controls/controls/media-controls.css
Diff
Modified: trunk/Source/WebCore/ChangeLog (279480 => 279481)
--- trunk/Source/WebCore/ChangeLog 2021-07-01 20:22:16 UTC (rev 279480)
+++ trunk/Source/WebCore/ChangeLog 2021-07-01 20:28:32 UTC (rev 279481)
@@ -1,3 +1,23 @@
+2021-07-01 Dean Jackson
+
+Move BottomControlsBarHeight and InsideMargin to be computed at runtime
+https://bugs.webkit.org/show_bug.cgi?id=227505
+
+
+Reviewed by Devin Rousso.
+
+Rather than having two JS constants that have to be kept in sync
+with CSS, simply retrieve the value from the computed style.
+
+No change in behaviour.
+
+* Modules/modern-media-controls/controls/inline-media-controls.js:
+(InlineMediaControls.prototype.layout):
+* Modules/modern-media-controls/controls/media-controls.css:
+(:host(audio), :host(video.media-document.audio), *):
+* Modules/modern-media-controls/controls/layout-node.js: Add two helpers to
+retrive computed style values.
+
2021-07-01 Brady Eidson
HIDGamepadProvider adds an extra 50ms to all inputs
Modified: trunk/Source/WebCore/Modules/modern-media-controls/controls/inline-media-controls.js (279480 => 279481)
--- trunk/Source/WebCore/Modules/modern-media-controls/controls/inline-media-controls.js 2021-07-01 20:22:16 UTC (rev 279480)
+++ trunk/Source/WebCore/Modules/modern-media-controls/controls/inline-media-controls.js 2021-07-01 20:28:32 UTC (rev 279481)
@@ -23,9 +23,6 @@
* OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
*/
-const InsideMargin = 6; // Minimum margin to guarantee around all controls, this constant needs to stay in sync with the --inline-controls-inside-margin CSS variable.
-const BottomControlsBarHeight = 31; // This constant needs to stay in sync with the --inline-controls-bar-height CSS variable.
-
class InlineMediaControls extends MediaControls
{
@@ -133,7 +130,9 @@
this.topLeftControlsBar.visible = this._topLeftControlsBarContainer.children.some(button => button.visible);
// Compute the visible size for the controls bar.
-this.bottomControlsBar.width = this._shouldUseAudioLayout ? this.width : (this.width - 2 * InsideMargin);
+if (!this._inlineInsideMargin)
+this._inlineInsideMargin = this.computedValueForStylePropertyInPx("--inline-controls-inside-margin");
+this.bottomControlsBar.width = this._shouldUseAudioLayout ? this.width : (this.width - 2 * this._inlineInsideMargin);
// Compute the absolute minimum width to display the center control (status label or time control).
const centerControl = this.statusLabel.enabled ? this.statusLabel : this.timeControl;
@@ -218,7 +217,9 @@
// Ensure we position the bottom controls bar at the bottom of the frame, accounting for
// the inside margin, unless this would yield a position outside of the frame.
-this.bottomControlsBar.y = Math.max(0, this.height - BottomControlsBarHeight - InsideMargin);
+if (!this._inlineBottomControlsBarHeight)
+this._inlineBottomControlsBarHeight = this.computedValueForStylePropertyInPx("--inline-controls-bar-height");
+this.bottomControlsBar.y = Math.max(0, this.height - this._inlineBottomControlsBarHeight - this._inlineInsideMargin);
this.bottomControlsBar.children = controlsBarChildren;
if (!this._shouldUseAudioLayout && !this._shouldUseSingleBarLayout)
Modified: trunk/Source/WebCore/Modules/modern-media-controls/controls/layout-node.js (279480 => 279481)
--- trunk/Source/WebCore/Modules/modern-media-controls/controls/layout-node.js 2021-07-01 20:22:16 UTC (rev 279480)
+++ trunk/Source/WebCore/Modules/modern-media-controls/controls/layout-node.js 2021-07-01 20:28:32 UTC (rev 279481)
@@ -229,6 +229,21 @@
[webkit-changes] [279480] trunk/Source/WebCore
Title: [279480] trunk/Source/WebCore
Revision 279480
Author beid...@apple.com
Date 2021-07-01 13:22:16 -0700 (Thu, 01 Jul 2021)
Log Message
HIDGamepadProvider adds an extra 50ms to all inputs
and https://bugs.webkit.org/show_bug.cgi?id=217742
Reviewed by Alex Christensen.
No new tests.
Tried to write an API test to drive inputs in the delay range, but that was way too fragile
on a local developer machine, much less a bot that's under load.
These input delays were an early best-effort to get input to line up with RaF, which the spec
mentions as a goal.
Not sure how 50 slipped in for HID, vs the 16 on GCF.
Whether or not lining up perfectly with RaF is actually a useful goal, in the meantime driving
input as quickly as possible seems much more desirable.
We still want to coalesce multiple close together inputs into 1 logical event to smooth out jitter
with certain devices, and reduce IPC and DOM object churn during rapid input (or with buggy devices).
In testing with what I have on my desk, using a true 0-delay timer for that was not desirable.
But 1ms seems peachy keen.
* platform/gamepad/cocoa/GameControllerGamepadProvider.mm:
* platform/gamepad/mac/HIDGamepadProvider.mm:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/gamepad/cocoa/GameControllerGamepadProvider.mm
trunk/Source/WebCore/platform/gamepad/mac/HIDGamepadProvider.mm
Diff
Modified: trunk/Source/WebCore/ChangeLog (279479 => 279480)
--- trunk/Source/WebCore/ChangeLog 2021-07-01 20:22:09 UTC (rev 279479)
+++ trunk/Source/WebCore/ChangeLog 2021-07-01 20:22:16 UTC (rev 279480)
@@ -1,3 +1,32 @@
+2021-07-01 Brady Eidson
+
+HIDGamepadProvider adds an extra 50ms to all inputs
+ and https://bugs.webkit.org/show_bug.cgi?id=217742
+
+Reviewed by Alex Christensen.
+
+No new tests.
+Tried to write an API test to drive inputs in the delay range, but that was way too fragile
+on a local developer machine, much less a bot that's under load.
+
+These input delays were an early best-effort to get input to line up with RaF, which the spec
+mentions as a goal.
+
+Not sure how 50 slipped in for HID, vs the 16 on GCF.
+
+Whether or not lining up perfectly with RaF is actually a useful goal, in the meantime driving
+input as quickly as possible seems much more desirable.
+
+We still want to coalesce multiple close together inputs into 1 logical event to smooth out jitter
+with certain devices, and reduce IPC and DOM object churn during rapid input (or with buggy devices).
+
+In testing with what I have on my desk, using a true 0-delay timer for that was not desirable.
+
+But 1ms seems peachy keen.
+
+* platform/gamepad/cocoa/GameControllerGamepadProvider.mm:
+* platform/gamepad/mac/HIDGamepadProvider.mm:
+
2021-07-01 Dean Jackson
Add a layoutTrait for an additional controls scale factor
Modified: trunk/Source/WebCore/platform/gamepad/cocoa/GameControllerGamepadProvider.mm (279479 => 279480)
--- trunk/Source/WebCore/platform/gamepad/cocoa/GameControllerGamepadProvider.mm 2021-07-01 20:22:09 UTC (rev 279479)
+++ trunk/Source/WebCore/platform/gamepad/cocoa/GameControllerGamepadProvider.mm 2021-07-01 20:22:16 UTC (rev 279480)
@@ -68,7 +68,7 @@
#endif // !HAVE(GCCONTROLLER_HID_DEVICE_CHECK)
-static const Seconds inputNotificationDelay { 16_ms };
+static const Seconds inputNotificationDelay { 1_ms };
GameControllerGamepadProvider& GameControllerGamepadProvider::singleton()
{
Modified: trunk/Source/WebCore/platform/gamepad/mac/HIDGamepadProvider.mm (279479 => 279480)
--- trunk/Source/WebCore/platform/gamepad/mac/HIDGamepadProvider.mm 2021-07-01 20:22:09 UTC (rev 279479)
+++ trunk/Source/WebCore/platform/gamepad/mac/HIDGamepadProvider.mm 2021-07-01 20:22:16 UTC (rev 279480)
@@ -43,7 +43,7 @@
namespace WebCore {
static const Seconds connectionDelayInterval { 500_ms };
-static const Seconds hidInputNotificationDelay { 50_ms };
+static const Seconds hidInputNotificationDelay { 1_ms };
static RetainPtr deviceMatchingDictionary(uint32_t usagePage, uint32_t usage)
{
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [279479] trunk
Title: [279479] trunk Revision 279479 Author wenson_hs...@apple.com Date 2021-07-01 13:22:09 -0700 (Thu, 01 Jul 2021) Log Message Selecting or dragging images that contain recognizable text is difficult in Mail compose https://bugs.webkit.org/show_bug.cgi?id=227544 Reviewed by Devin Rousso. Source/WebKit: Long pressing images in editable content on iOS initiates dragging, and a tap-and-half gesture over the image selects the entire image. Both of these are common interactions for image attachments in Mail compose that take precedence over new Live Text interactions, so there's no advantage to triggering image analysis on images in editable content. Avoid doing this extra work by adjusting `-imageAnalysisGestureDidBegin:` to bail early if the image is inside editable content. Tests: ImageAnalysisTests.DoNotAnalyzeImagesInEditableContent ImageAnalysisTests.HandleImageAnalyzerError * Shared/ios/InteractionInformationAtPosition.h: * Shared/ios/InteractionInformationAtPosition.mm: (WebKit::InteractionInformationAtPosition::encode const): (WebKit::InteractionInformationAtPosition::decode): Add an `isContentEditable` flag. * UIProcess/API/ios/WKWebViewPrivateForTestingIOS.h: * UIProcess/API/ios/WKWebViewTestingIOS.mm: (-[WKWebView _imageAnalysisGestureRecognizer]): Add a testing hook to return the gesture recognizer used to trigger image analysis. * UIProcess/ios/WKContentViewInteraction.h: * UIProcess/ios/WKContentViewInteraction.mm: (-[WKContentView imageAnalysisGestureRecognizer]): (-[WKContentView imageAnalysisGestureDidBegin:]): Pull logic for avoiding image analysis out into a separate lambda, and add a check for `isContentEditable`. * WebProcess/WebPage/ios/WebPageIOS.mm: (WebKit::WebPage::positionInformation): Populate the `isContentEditable` flag based on whether or not the node found by the position information request is editable. Tools: See WebKit/ChangeLog for more details. * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig: Link against VisionKitCore on iOS 15+ and macOS 12+. * TestWebKitAPI/Configurations/WebKitTargetConditionals.xcconfig: Update WebKitTargetConditionals to be consistent with the other target conditions in WebKit, so that we can use `IOS_SINCE_15` in TestWebKitAPI.xcconfig. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: * TestWebKitAPI/Tests/WebKitCocoa/ImageAnalysisTests.mm: Added. Add new API tests that trigger the image analysis gesture recognizer and check whether or not we requested image analysis from VisionKit. (TestWebKitAPI::swizzledLocationInView): (TestWebKitAPI::swizzledProcessRequest): Modified Paths trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/Shared/ios/InteractionInformationAtPosition.h trunk/Source/WebKit/Shared/ios/InteractionInformationAtPosition.mm trunk/Source/WebKit/UIProcess/API/ios/WKWebViewPrivateForTestingIOS.h trunk/Source/WebKit/UIProcess/API/ios/WKWebViewTestingIOS.mm trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.h trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm trunk/Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm trunk/Tools/ChangeLog trunk/Tools/TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig trunk/Tools/TestWebKitAPI/Configurations/WebKitTargetConditionals.xcconfig trunk/Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj Added Paths trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/ImageAnalysisTests.mm Diff Modified: trunk/Source/WebKit/ChangeLog (279478 => 279479) --- trunk/Source/WebKit/ChangeLog 2021-07-01 19:59:38 UTC (rev 279478) +++ trunk/Source/WebKit/ChangeLog 2021-07-01 20:22:09 UTC (rev 279479) @@ -1,3 +1,47 @@ +2021-07-01 Wenson Hsieh + +Selecting or dragging images that contain recognizable text is difficult in Mail compose +https://bugs.webkit.org/show_bug.cgi?id=227544 + +Reviewed by Devin Rousso. + +Long pressing images in editable content on iOS initiates dragging, and a tap-and-half gesture over the image +selects the entire image. Both of these are common interactions for image attachments in Mail compose that +take precedence over new Live Text interactions, so there's no advantage to triggering image analysis on images +in editable content. + +Avoid doing this extra work by adjusting `-imageAnalysisGestureDidBegin:` to bail early if the image is inside +editable content. + +Tests: ImageAnalysisTests.DoNotAnalyzeImagesInEditableContent +ImageAnalysisTests.HandleImageAnalyzerError + +* Shared/ios/InteractionInformationAtPosition.h: +* Shared/ios/InteractionInformationAtPosition.mm: +(WebKit::InteractionInformationAtPosition::encode const): +(WebKit::InteractionInformationAtPosition::decode): + +Add an `isContentEditable` flag. + +* UIProcess/API/ios/WKWebViewPrivateForTestingIOS.h: +* UIProcess/API/ios/WKWebViewTestingIOS.mm: +(-[WKWebView
[webkit-changes] [279478] trunk/Source/WebCore
Title: [279478] trunk/Source/WebCore
Revision 279478
Author d...@apple.com
Date 2021-07-01 12:59:38 -0700 (Thu, 01 Jul 2021)
Log Message
Add a layoutTrait for an additional controls scale factor
https://bugs.webkit.org/show_bug.cgi?id=227561
Reviewed by Anders Carlsson.
Allow controls with different layout traits to apply
a scale factor to their buttons.
No change in behaviour.
* Modules/modern-media-controls/controls/button.js:
(Button.prototype._updateImageMetrics):
(Button):
* Modules/modern-media-controls/controls/layout-traits.js:
(LayoutTraits.prototype.additionalControlScaleFactor):
(LayoutTraits):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/modern-media-controls/controls/button.js
trunk/Source/WebCore/Modules/modern-media-controls/controls/layout-traits.js
Diff
Modified: trunk/Source/WebCore/ChangeLog (279477 => 279478)
--- trunk/Source/WebCore/ChangeLog 2021-07-01 19:37:13 UTC (rev 279477)
+++ trunk/Source/WebCore/ChangeLog 2021-07-01 19:59:38 UTC (rev 279478)
@@ -1,3 +1,23 @@
+2021-07-01 Dean Jackson
+
+Add a layoutTrait for an additional controls scale factor
+https://bugs.webkit.org/show_bug.cgi?id=227561
+
+
+Reviewed by Anders Carlsson.
+
+Allow controls with different layout traits to apply
+a scale factor to their buttons.
+
+No change in behaviour.
+
+* Modules/modern-media-controls/controls/button.js:
+(Button.prototype._updateImageMetrics):
+(Button):
+* Modules/modern-media-controls/controls/layout-traits.js:
+(LayoutTraits.prototype.additionalControlScaleFactor):
+(LayoutTraits):
+
2021-07-01 Antoine Quint
[Model] Restrict IPC calls to ARKit SPI availability and runtime flag
Modified: trunk/Source/WebCore/Modules/modern-media-controls/controls/button.js (279477 => 279478)
--- trunk/Source/WebCore/Modules/modern-media-controls/controls/button.js 2021-07-01 19:37:13 UTC (rev 279477)
+++ trunk/Source/WebCore/Modules/modern-media-controls/controls/button.js 2021-07-01 19:59:38 UTC (rev 279478)
@@ -202,8 +202,8 @@
_updateImageMetrics()
{
-let width = this._imageSource.width * this._scaleFactor;
-let height = this._imageSource.height * this._scaleFactor;
+let width = this._imageSource.width * this._scaleFactor * this.layoutTraits.additionalControlScaleFactor();
+let height = this._imageSource.height * this._scaleFactor * this.layoutTraits.additionalControlScaleFactor();
if (this._iconName.type === "png" || this._iconName.type === "pdf") {
width /= window.devicePixelRatio;
Modified: trunk/Source/WebCore/Modules/modern-media-controls/controls/layout-traits.js (279477 => 279478)
--- trunk/Source/WebCore/Modules/modern-media-controls/controls/layout-traits.js 2021-07-01 19:37:13 UTC (rev 279477)
+++ trunk/Source/WebCore/Modules/modern-media-controls/controls/layout-traits.js 2021-07-01 19:59:38 UTC (rev 279478)
@@ -75,21 +75,26 @@
{
throw "Derived class must implement this function.";
}
-
+
playPauseButtonScaleFactor()
{
throw "Derived class must implement this function.";
}
-
+
controlsDependOnPageScaleFactor()
{
throw "Derived class must implement this function.";
}
-
+
promoteSubMenusWhenShowingMediaControlsContextMenu()
{
throw "Derived class must implement this function.";
}
+
+additionalControlScaleFactor()
+{
+return 1;
+}
}
LayoutTraits.Mode = {
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [279477] trunk/Source
Title: [279477] trunk/Source Revision 279477 Author grao...@webkit.org Date 2021-07-01 12:37:13 -0700 (Thu, 01 Jul 2021) Log Message [Model] Restrict IPC calls to ARKit SPI availability and runtime flag https://bugs.webkit.org/show_bug.cgi?id=227581 Reviewed by Tim Horton. Source/WebCore: Guard all IPC calls related to by the most appropriate platform-specific flag and also ensure that those calls don't do anything unless the runtime flag is also enabled. * Modules/model-element/HTMLModelElement.cpp: * Modules/model-element/HTMLModelElement.h: * Modules/model-element/HTMLModelElementCocoa.mm: (WebCore::HTMLModelElement::inlinePreviewDidObtainContextId): * loader/EmptyClients.cpp: (WebCore::EmptyChromeClient::modelElementDidCreatePreview const): * loader/EmptyClients.h: * page/ChromeClient.h: Source/WebKit: Guard all IPC calls related to by the most appropriate platform-specific flag and also ensure that those calls don't do anything unless the runtime flag is also enabled. * Shared/WebProcessDataStoreParameters.h: (WebKit::WebProcessDataStoreParameters::encode const): (WebKit::WebProcessDataStoreParameters::decode): * UIProcess/Cocoa/ModelElementControllerCocoa.mm: (WebKit::ModelElementController::takeModelElementFullscreen): (WebKit::ModelElementController::modelElementDidCreatePreview): * UIProcess/ModelElementController.cpp: * UIProcess/ModelElementController.h: * UIProcess/PageClient.h: * UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::didAttachToRunningProcess): (WebKit::WebPageProxy::resetState): (WebKit::WebPageProxy::takeModelElementFullscreen): (WebKit::WebPageProxy::modelElementDidCreatePreview): (WebKit::WebPageProxy::modelElementPreviewDidObtainContextId): * UIProcess/WebPageProxy.h: * UIProcess/WebPageProxy.messages.in: * UIProcess/WebProcessPool.cpp: (WebKit::WebProcessPool::webProcessDataStoreParameters): * UIProcess/WebsiteData/Cocoa/WebsiteDataStoreCocoa.mm: * UIProcess/WebsiteData/WebsiteDataStore.cpp: (WebKit::WebsiteDataStore::resolveDirectoriesIfNecessary): * UIProcess/WebsiteData/WebsiteDataStore.h: * UIProcess/WebsiteData/WebsiteDataStoreConfiguration.cpp: (WebKit::WebsiteDataStoreConfiguration::WebsiteDataStoreConfiguration): (WebKit::WebsiteDataStoreConfiguration::copy const): * UIProcess/WebsiteData/WebsiteDataStoreConfiguration.h: * WebProcess/WebCoreSupport/WebChromeClient.cpp: (WebKit::WebChromeClient::modelElementDidCreatePreview const): * WebProcess/WebCoreSupport/WebChromeClient.h: * WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::modelElementPreviewDidObtainContextId): * WebProcess/WebPage/WebPage.h: * WebProcess/WebPage/WebPage.messages.in: * WebProcess/WebProcess.cpp: (WebKit::WebProcess::setWebsiteDataStoreParameters): * WebProcess/cocoa/WebProcessCocoa.mm: (WebKit::WebProcess::platformSetWebsiteDataStoreParameters): Source/WTF: Define a new compile-time flag when either of the iOS or macOS ARKit SPIs are available. * wtf/PlatformHave.h: Modified Paths trunk/Source/WTF/ChangeLog trunk/Source/WTF/wtf/PlatformHave.h trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/Modules/model-element/HTMLModelElement.cpp trunk/Source/WebCore/Modules/model-element/HTMLModelElement.h trunk/Source/WebCore/Modules/model-element/HTMLModelElementCocoa.mm trunk/Source/WebCore/loader/EmptyClients.cpp trunk/Source/WebCore/loader/EmptyClients.h trunk/Source/WebCore/page/ChromeClient.h trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/Shared/WebProcessDataStoreParameters.h trunk/Source/WebKit/UIProcess/Cocoa/ModelElementControllerCocoa.mm trunk/Source/WebKit/UIProcess/ModelElementController.cpp trunk/Source/WebKit/UIProcess/ModelElementController.h trunk/Source/WebKit/UIProcess/PageClient.h trunk/Source/WebKit/UIProcess/WebPageProxy.cpp trunk/Source/WebKit/UIProcess/WebPageProxy.h trunk/Source/WebKit/UIProcess/WebPageProxy.messages.in trunk/Source/WebKit/UIProcess/WebProcessPool.cpp trunk/Source/WebKit/UIProcess/WebsiteData/Cocoa/WebsiteDataStoreCocoa.mm trunk/Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.cpp trunk/Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.h trunk/Source/WebKit/UIProcess/WebsiteData/WebsiteDataStoreConfiguration.cpp trunk/Source/WebKit/UIProcess/WebsiteData/WebsiteDataStoreConfiguration.h trunk/Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.cpp trunk/Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.h trunk/Source/WebKit/WebProcess/WebPage/WebPage.cpp trunk/Source/WebKit/WebProcess/WebPage/WebPage.h trunk/Source/WebKit/WebProcess/WebPage/WebPage.messages.in trunk/Source/WebKit/WebProcess/WebProcess.cpp trunk/Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm Diff Modified: trunk/Source/WTF/ChangeLog (279476 => 279477) --- trunk/Source/WTF/ChangeLog 2021-07-01 18:52:04 UTC (rev 279476) +++ trunk/Source/WTF/ChangeLog 2021-07-01 19:37:13 UTC (rev 279477) @@ -1,3 +1,14 @@ +2021-07-01 Antoine Quint + +[Model] Restrict IPC calls to ARKit SPI availability and runtime flag +
[webkit-changes] [279476] trunk/Source/WebKit
Title: [279476] trunk/Source/WebKit Revision 279476 Author pvol...@apple.com Date 2021-07-01 11:52:04 -0700 (Thu, 01 Jul 2021) Log Message [macOS] Fix sandbox violations related to IOKit filtering https://bugs.webkit.org/show_bug.cgi?id=227572 Reviewed by Brent Fulgham. * WebProcess/com.apple.WebProcess.sb.in: Modified Paths trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/WebProcess/com.apple.WebProcess.sb.in Diff Modified: trunk/Source/WebKit/ChangeLog (279475 => 279476) --- trunk/Source/WebKit/ChangeLog 2021-07-01 18:34:39 UTC (rev 279475) +++ trunk/Source/WebKit/ChangeLog 2021-07-01 18:52:04 UTC (rev 279476) @@ -1,3 +1,13 @@ +2021-07-01 Per Arne + +[macOS] Fix sandbox violations related to IOKit filtering +https://bugs.webkit.org/show_bug.cgi?id=227572 + + +Reviewed by Brent Fulgham. + +* WebProcess/com.apple.WebProcess.sb.in: + 2021-07-01 Aditya Keerthi [iOS] menus should scroll to the selected option Modified: trunk/Source/WebKit/WebProcess/com.apple.WebProcess.sb.in (279475 => 279476) --- trunk/Source/WebKit/WebProcess/com.apple.WebProcess.sb.in 2021-07-01 18:34:39 UTC (rev 279475) +++ trunk/Source/WebKit/WebProcess/com.apple.WebProcess.sb.in 2021-07-01 18:52:04 UTC (rev 279476) @@ -119,7 +119,7 @@ iokit-external-method ) (allow iokit-async-external-method -#if __MAC_OS_X_VERSION_MIN_REQUIRED >= 12 +#if __MAC_OS_X_VERSION_MIN_REQUIRED >= 12 && __MAC_OS_X_VERSION_MIN_REQUIRED < 13 (iokit-method-number 0 47 @@ -127,7 +127,7 @@ #endif ) (allow iokit-external-method -#if __MAC_OS_X_VERSION_MIN_REQUIRED >= 12 +#if __MAC_OS_X_VERSION_MIN_REQUIRED >= 12 && __MAC_OS_X_VERSION_MIN_REQUIRED < 13 (iokit-method-number 0 1 @@ -173,7 +173,7 @@ ) #endif ) -#if __MAC_OS_X_VERSION_MIN_REQUIRED >= 12 +#if __MAC_OS_X_VERSION_MIN_REQUIRED >= 12 && __MAC_OS_X_VERSION_MIN_REQUIRED < 13 (if (equal? (param "CPU") "arm64") (allow iokit-external-method (iokit-method-number ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [279475] trunk/Source
Title: [279475] trunk/Source Revision 279475 Author akeer...@apple.com Date 2021-07-01 11:34:39 -0700 (Thu, 01 Jul 2021) Log Message [iOS] menus should scroll to the selected option https://bugs.webkit.org/show_bug.cgi?id=227562 Reviewed by Wenson Hsieh. Source/WebKit: Before iOS 15, pickers were implemented using UIPickerView on iPhone and UITableView on iPad. Both these views gave WebKit the ability to scroll the view to the currently selected option. In iOS 15, options are displayed in a context menu. WebKit does not have access to the menu's view hierarchy, and must rely on UIKit to perform the scrolling behavior. * UIProcess/ios/forms/WKFormSelectPicker.mm: (-[WKSelectPicker createMenu]): Adopt UIMenuOptionsSingleSelection to obtain UIKit behaviors for popup menus. Source/WTF: * wtf/PlatformHave.h: Add HAVE(UIMENUOPTIONS_SINGLE_SELECTION). Modified Paths trunk/Source/WTF/ChangeLog trunk/Source/WTF/wtf/PlatformHave.h trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/UIProcess/ios/forms/WKFormSelectPicker.mm Diff Modified: trunk/Source/WTF/ChangeLog (279474 => 279475) --- trunk/Source/WTF/ChangeLog 2021-07-01 18:24:30 UTC (rev 279474) +++ trunk/Source/WTF/ChangeLog 2021-07-01 18:34:39 UTC (rev 279475) @@ -1,3 +1,15 @@ +2021-07-01 Aditya Keerthi + +[iOS] menus should scroll to the selected option +https://bugs.webkit.org/show_bug.cgi?id=227562 + + +Reviewed by Wenson Hsieh. + +* wtf/PlatformHave.h: + +Add HAVE(UIMENUOPTIONS_SINGLE_SELECTION). + 2021-07-01 Youenn Fablet [Cocoa] Migrate WebRTC UDP socket handling to NW API Modified: trunk/Source/WTF/wtf/PlatformHave.h (279474 => 279475) --- trunk/Source/WTF/wtf/PlatformHave.h 2021-07-01 18:24:30 UTC (rev 279474) +++ trunk/Source/WTF/wtf/PlatformHave.h 2021-07-01 18:34:39 UTC (rev 279475) @@ -1027,6 +1027,7 @@ #if (PLATFORM(IOS) || PLATFORM(MACCATALYST)) && __IPHONE_OS_VERSION_MIN_REQUIRED >= 15 #define HAVE_UICONTEXTMENU_STYLE_CUSTOM_PRESENTATION 1 #define HAVE_UIDATEPICKER_INSETS 1 +#define HAVE_UIMENUOPTIONS_SINGLE_SELECTION 1 #endif #if (((PLATFORM(IOS) || PLATFORM(MACCATALYST)) && __IPHONE_OS_VERSION_MIN_REQUIRED >= 15) \ Modified: trunk/Source/WebKit/ChangeLog (279474 => 279475) --- trunk/Source/WebKit/ChangeLog 2021-07-01 18:24:30 UTC (rev 279474) +++ trunk/Source/WebKit/ChangeLog 2021-07-01 18:34:39 UTC (rev 279475) @@ -1,3 +1,24 @@ +2021-07-01 Aditya Keerthi + +[iOS] menus should scroll to the selected option +https://bugs.webkit.org/show_bug.cgi?id=227562 + + +Reviewed by Wenson Hsieh. + +Before iOS 15, pickers were implemented using UIPickerView on +iPhone and UITableView on iPad. Both these views gave WebKit the ability +to scroll the view to the currently selected option. + +In iOS 15, options are displayed in a context menu. WebKit does +not have access to the menu's view hierarchy, and must rely on UIKit to +perform the scrolling behavior. + +* UIProcess/ios/forms/WKFormSelectPicker.mm: +(-[WKSelectPicker createMenu]): + +Adopt UIMenuOptionsSingleSelection to obtain UIKit behaviors for popup menus. + 2021-07-01 Jer Noble [Mac] Adopt async GroupActivity.sessions() iterable instead of GroupSessionObserver Modified: trunk/Source/WebKit/UIProcess/ios/forms/WKFormSelectPicker.mm (279474 => 279475) --- trunk/Source/WebKit/UIProcess/ios/forms/WKFormSelectPicker.mm 2021-07-01 18:24:30 UTC (rev 279474) +++ trunk/Source/WebKit/UIProcess/ios/forms/WKFormSelectPicker.mm 2021-07-01 18:34:39 UTC (rev 279475) @@ -596,7 +596,12 @@ currentIndex++; } -return [UIMenu menuWithTitle:@"" image:nil identifier:nil options:UIMenuOptionsPrivateRemoveLineLimitForChildren children:items]; +UIMenuOptions options = UIMenuOptionsPrivateRemoveLineLimitForChildren; +#if HAVE(UIMENUOPTIONS_SINGLE_SELECTION) +options |= UIMenuOptionsSingleSelection; +#endif + +return [UIMenu menuWithTitle:@"" image:nil identifier:nil options:options children:items]; } - (UIAction *)actionForOptionItem:(const OptionItem&)option withIndex:(NSInteger)optionIndex ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [279473] trunk/Source/JavaScriptCore
Title: [279473] trunk/Source/_javascript_Core Revision 279473 Author commit-qu...@webkit.org Date 2021-07-01 11:24:09 -0700 (Thu, 01 Jul 2021) Log Message Remove unnecessary canBeInternal invocations to mitigate the cost of potential unmatched patterns in B3LowerToAir https://bugs.webkit.org/show_bug.cgi?id=227508 Patch by Yijia Huang on 2021-07-01 Reviewed by Filip Pizlo. The bit pattern doesn't cause worse code generation in the all-internals-are-captured case. So, they don't need canBeInternal checks which might terminate potential matched scenarios. The equivalent pattern of SBFIZ is ((src << amount) >> amount) << lsb. Given the code: a = x << C b = a >> C c = b << D print(a) print(b) print(c) The pattern won't match because of !canBeInternal for a and b (useCounts > 1). So, this would emit three separate instructions. But if we removed canBeInternal, it would still be just three separate instructions, and they wouldn't be any more expensive. Suppose the print(b) is removed, above. Then, with the canBeInternal check, it is emitting three instructions. Without the canBeInternal check, it would emit only two (x << C and SBFIZ to compute c). And that would be less expensive. * b3/B3LowerToAir.cpp: Modified Paths trunk/Source/_javascript_Core/ChangeLog trunk/Source/_javascript_Core/b3/B3LowerToAir.cpp Diff Modified: trunk/Source/_javascript_Core/ChangeLog (279472 => 279473) --- trunk/Source/_javascript_Core/ChangeLog 2021-07-01 17:41:51 UTC (rev 279472) +++ trunk/Source/_javascript_Core/ChangeLog 2021-07-01 18:24:09 UTC (rev 279473) @@ -1,5 +1,35 @@ 2021-07-01 Yijia Huang +Remove unnecessary canBeInternal invocations to mitigate the cost of potential unmatched patterns in B3LowerToAir +https://bugs.webkit.org/show_bug.cgi?id=227508 + +Reviewed by Filip Pizlo. + +The bit pattern doesn't cause worse code generation in the all-internals-are-captured +case. So, they don't need canBeInternal checks which might terminate potential matched +scenarios. + +The equivalent pattern of SBFIZ is ((src << amount) >> amount) << lsb. Given the code: + +a = x << C +b = a >> C +c = b << D + +print(a) +print(b) +print(c) + +The pattern won't match because of !canBeInternal for a and b (useCounts > 1). +So, this would emit three separate instructions. But if we removed canBeInternal, +it would still be just three separate instructions, and they wouldn't be any more +expensive. Suppose the print(b) is removed, above. Then, with the canBeInternal check, +it is emitting three instructions. Without the canBeInternal check, it would emit only +two (x << C and SBFIZ to compute c). And that would be less expensive. + +* b3/B3LowerToAir.cpp: + +2021-07-01 Yijia Huang + Add a new pattern to instruction selector to use EXTR supported by ARM64 https://bugs.webkit.org/show_bug.cgi?id=227171 Modified: trunk/Source/_javascript_Core/b3/B3LowerToAir.cpp (279472 => 279473) --- trunk/Source/_javascript_Core/b3/B3LowerToAir.cpp 2021-07-01 17:41:51 UTC (rev 279472) +++ trunk/Source/_javascript_Core/b3/B3LowerToAir.cpp 2021-07-01 18:24:09 UTC (rev 279473) @@ -2769,7 +2769,7 @@ Air::Opcode opcode = opcodeForType(ExtractUnsignedBitfield32, ExtractUnsignedBitfield64, m_value->type()); if (!isValidForm(opcode, Arg::Tmp, Arg::Imm, Arg::Imm, Arg::Tmp)) return false; -if (left->opcode() != ZShr || !canBeInternal(left)) +if (left->opcode() != ZShr) return false; Value* srcValue = left->child(0); @@ -2787,7 +2787,6 @@ return false; append(opcode, tmp(srcValue), imm(lsbValue), imm(width), tmp(m_value)); -commitInternal(left); return true; }; @@ -2799,7 +2798,7 @@ Air::Opcode opcode = opcodeForType(ClearBitsWithMask32, ClearBitsWithMask64, m_value->type()); if (!isValidForm(opcode, Arg::Tmp, Arg::Tmp, Arg::Tmp)) return false; -if (right->opcode() != BitXor || !canBeInternal(right)) +if (right->opcode() != BitXor) return false; Value* nValue = left; @@ -2809,7 +2808,6 @@ return false; append(opcode, tmp(nValue), tmp(mValue), tmp(m_value)); -commitInternal(right); return true; }; @@ -2872,12 +2870,8 @@ Air::Opcode opcode = opcodeForType(InsertBitField32, InsertBitField64, m_value->type()); if (!isValidForm(opcode, Arg::Tmp, Arg::Imm, Arg::Imm, Arg::Tmp)) return false; -if (left->opcode() != Shl || !canBeInternal(left)) +if
[webkit-changes] [279474] tags/Safari-612.1.21.1/
Title: [279474] tags/Safari-612.1.21.1/ Revision 279474 Author rubent...@apple.com Date 2021-07-01 11:24:30 -0700 (Thu, 01 Jul 2021) Log Message Tag Safari-612.1.21.1. Added Paths tags/Safari-612.1.21.1/ Diff ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [279472] trunk
Title: [279472] trunk
Revision 279472
Author you...@apple.com
Date 2021-07-01 10:41:51 -0700 (Thu, 01 Jul 2021)
Log Message
ReadableStream.getReader do not throw a proper exception when parameter is of wrong type
https://bugs.webkit.org/show_bug.cgi?id=226220
Reviewed by Chris Dumez.
LayoutTests/imported/w3c:
* web-platform-tests/streams/readable-streams/default-reader.any-expected.txt:
* web-platform-tests/streams/readable-streams/default-reader.any.worker-expected.txt:
* web-platform-tests/streams/readable-streams/general.any-expected.txt:
* web-platform-tests/streams/readable-streams/general.any.worker-expected.txt:
* web-platform-tests/streams/readable-streams/templated.any-expected.txt:
* web-platform-tests/streams/readable-streams/templated.any.worker-expected.txt:
Source/WebCore:
Covered by rebased tests.
* Modules/streams/ReadableStream.js:
(getReader):
Tighten option parameter check.
In case mode is bad, fire a type error instead of range error.
LayoutTests:
* streams/readable-stream-getReader-expected.txt:
* streams/readable-stream-getReader.html:
Update test to match latest spec.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/imported/w3c/ChangeLog
trunk/LayoutTests/imported/w3c/web-platform-tests/streams/readable-streams/default-reader.any-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/streams/readable-streams/default-reader.any.worker-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/streams/readable-streams/general.any-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/streams/readable-streams/general.any.worker-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/streams/readable-streams/templated.any-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/streams/readable-streams/templated.any.worker-expected.txt
trunk/LayoutTests/streams/readable-stream-getReader-expected.txt
trunk/LayoutTests/streams/readable-stream-getReader.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/streams/ReadableStream.js
trunk/Source/WebCore/Modules/streams/StreamInternals.js
Diff
Modified: trunk/LayoutTests/ChangeLog (279471 => 279472)
--- trunk/LayoutTests/ChangeLog 2021-07-01 17:37:38 UTC (rev 279471)
+++ trunk/LayoutTests/ChangeLog 2021-07-01 17:41:51 UTC (rev 279472)
@@ -1,3 +1,15 @@
+2021-07-01 Youenn Fablet
+
+ReadableStream.getReader do not throw a proper exception when parameter is of wrong type
+https://bugs.webkit.org/show_bug.cgi?id=226220
+
+
+Reviewed by Chris Dumez.
+
+* streams/readable-stream-getReader-expected.txt:
+* streams/readable-stream-getReader.html:
+Update test to match latest spec.
+
2021-07-01 Alan Bujtas
VisiblePosition::absoluteSelectionBoundsForLine fails on multiline vertical-rl content
Modified: trunk/LayoutTests/imported/w3c/ChangeLog (279471 => 279472)
--- trunk/LayoutTests/imported/w3c/ChangeLog 2021-07-01 17:37:38 UTC (rev 279471)
+++ trunk/LayoutTests/imported/w3c/ChangeLog 2021-07-01 17:41:51 UTC (rev 279472)
@@ -1,5 +1,20 @@
2021-07-01 Youenn Fablet
+ReadableStream.getReader do not throw a proper exception when parameter is of wrong type
+https://bugs.webkit.org/show_bug.cgi?id=226220
+
+
+Reviewed by Chris Dumez.
+
+* web-platform-tests/streams/readable-streams/default-reader.any-expected.txt:
+* web-platform-tests/streams/readable-streams/default-reader.any.worker-expected.txt:
+* web-platform-tests/streams/readable-streams/general.any-expected.txt:
+* web-platform-tests/streams/readable-streams/general.any.worker-expected.txt:
+* web-platform-tests/streams/readable-streams/templated.any-expected.txt:
+* web-platform-tests/streams/readable-streams/templated.any.worker-expected.txt:
+
+2021-07-01 Youenn Fablet
+
[Cocoa] Migrate WebRTC UDP socket handling to NW API
https://bugs.webkit.org/show_bug.cgi?id=227210
Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/streams/readable-streams/default-reader.any-expected.txt (279471 => 279472)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/streams/readable-streams/default-reader.any-expected.txt 2021-07-01 17:37:38 UTC (rev 279471)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/streams/readable-streams/default-reader.any-expected.txt 2021-07-01 17:41:51 UTC (rev 279472)
@@ -29,8 +29,6 @@
PASS Reading twice on a closed stream
PASS Reading twice on an errored stream
PASS Reading twice on a stream that gets errored
-FAIL getReader() should call ToString() on mode assert_throws_js: getReader() should throw function "() => rs.getReader({ mode })" threw object "RangeError: Invalid mode is specified" ("RangeError") expected instance of function "function TypeError() {
-[native code]
-}" ("TypeError")
+PASS getReader() should call ToString() on mode
PASS controller.close() should clear the list of pending
[webkit-changes] [279471] trunk/Source/ThirdParty/libwebrtc
Title: [279471] trunk/Source/ThirdParty/libwebrtc Revision 279471 Author you...@apple.com Date 2021-07-01 10:37:38 -0700 (Thu, 01 Jul 2021) Log Message Disable ABSL_HAVE_THREAD_LOCAL in libwebrtc https://bugs.webkit.org/show_bug.cgi?id=227577 Reviewed by Eric Carlson. We do no want to resort on thread local yet so disable ABSL_HAVE_THREAD_LOCAL until we can use it properly. * Source/third_party/abseil-cpp/absl/base/config.h: Modified Paths trunk/Source/ThirdParty/libwebrtc/ChangeLog trunk/Source/ThirdParty/libwebrtc/Source/third_party/abseil-cpp/absl/base/config.h Diff Modified: trunk/Source/ThirdParty/libwebrtc/ChangeLog (279470 => 279471) --- trunk/Source/ThirdParty/libwebrtc/ChangeLog 2021-07-01 17:25:26 UTC (rev 279470) +++ trunk/Source/ThirdParty/libwebrtc/ChangeLog 2021-07-01 17:37:38 UTC (rev 279471) @@ -1,5 +1,17 @@ 2021-07-01 Youenn Fablet +Disable ABSL_HAVE_THREAD_LOCAL in libwebrtc +https://bugs.webkit.org/show_bug.cgi?id=227577 + + +Reviewed by Eric Carlson. + +We do no want to resort on thread local yet so disable ABSL_HAVE_THREAD_LOCAL until we can use it properly. + +* Source/third_party/abseil-cpp/absl/base/config.h: + +2021-07-01 Youenn Fablet + [Cocoa] Migrate WebRTC UDP socket handling to NW API https://bugs.webkit.org/show_bug.cgi?id=227210 Modified: trunk/Source/ThirdParty/libwebrtc/Source/third_party/abseil-cpp/absl/base/config.h (279470 => 279471) --- trunk/Source/ThirdParty/libwebrtc/Source/third_party/abseil-cpp/absl/base/config.h 2021-07-01 17:25:26 UTC (rev 279470) +++ trunk/Source/ThirdParty/libwebrtc/Source/third_party/abseil-cpp/absl/base/config.h 2021-07-01 17:37:38 UTC (rev 279471) @@ -256,10 +256,13 @@ // * Xcode 10 moves the deployment target check for iOS < 9.0 to link time // making ABSL_HAVE_FEATURE unreliable there. // -#if ABSL_HAVE_FEATURE(cxx_thread_local) && \ -!(TARGET_OS_IPHONE && __IPHONE_OS_VERSION_MIN_REQUIRED < __IPHONE_9_0) -#define ABSL_HAVE_THREAD_LOCAL 1 -#endif + +// WEBRTC_WEBKIT_BUILD Start: Disable thread local for now and resort on pthread_getspecific/pthread_setspecific. See rdar://79915864. +// #if ABSL_HAVE_FEATURE(cxx_thread_local) && \ +// !(TARGET_OS_IPHONE && __IPHONE_OS_VERSION_MIN_REQUIRED < __IPHONE_9_0) +// #define ABSL_HAVE_THREAD_LOCAL 1 +// #endif +// WEBRTC_WEBKIT_BUILD End #else // !defined(__APPLE__) #define ABSL_HAVE_THREAD_LOCAL 1 #endif ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [279470] trunk/Source/JavaScriptCore
Title: [279470] trunk/Source/_javascript_Core Revision 279470 Author commit-qu...@webkit.org Date 2021-07-01 10:25:26 -0700 (Thu, 01 Jul 2021) Log Message Add a new pattern to instruction selector to use EXTR supported by ARM64 https://bugs.webkit.org/show_bug.cgi?id=227171 Patch by Yijia Huang on 2021-07-01 Reviewed by Robin Morisset. This patch includes two modifications: 1. Introduce a strength reduction rule to zero extend bitfield. 2. Add Extract Register (EXTR) to Air opcode to serve instruction selector. --- ### Part A zero extend bitfield ### --- A new strength reduction rule is added for the canonical form of the zero-extend bitfield. Turn this: ZShr(Shl(value, amount)), amount) Into this: BitAnd(value, mask) with constraints: 1. 0 <= amount < datasize 2. width = datasize - amount 3. mask is !(mask & (mask + 1)) where bitCount(mask) == width --- ### Part B EXTR ### --- Given instruction: extr Rd, Rn, Rm, lowWidth Extract register (EXTR) extracts a register from a pair of registers, where concat = Rn:Rm and Rd = concat. The equivalent pattern of this instruction is: d = ((n & mask) << highWidth) | (m >> lowWidth) highWidth = datasize - lowWidth mask = (1 << lowWidth) - 1 Given B3 IR: Int @0 = ArgumentReg(%x0) Int @1 = ArgumentReg(%x1) Int @2 = mask Int @3 = BitAnd(@0, @2) Int @4 = highWidth Int @5 = Shl(@3, @4) Int @6 = lowWidth Int @7 = ZShr(@1, @6) Int @8 = BitOr(@7, @5) Void@9 = Return(@10, Terminal) Before Adding BIC: // Old optimized AIR InsertUnsignedBitfieldInZero %x0, highWidth, lowWidth, %x0, @5 Urshift %x1, lowWidth, %x1, @7 Or %x0, %x1, %x0, @8 Ret %x0, @9 After Adding BIC: // New optimized AIR ExtractRegister %x0, %x1, lowWidth, %x0, @8 Ret %x0, @9 * assembler/MacroAssemblerARM64.h: (JSC::MacroAssemblerARM64::extractRegister32): (JSC::MacroAssemblerARM64::extractRegister64): * assembler/testmasm.cpp: (JSC::testExtractRegister32): (JSC::testExtractRegister64): * b3/B3LowerToAir.cpp: * b3/B3ReduceStrength.cpp: * b3/air/AirOpcode.opcodes: * b3/testb3.h: * b3/testb3_2.cpp: (testBitfieldZeroExtend32): (testBitfieldZeroExtend64): (testExtractRegister32): (testExtractRegister64): (addBitTests): Modified Paths trunk/Source/_javascript_Core/ChangeLog trunk/Source/_javascript_Core/assembler/MacroAssemblerARM64.h trunk/Source/_javascript_Core/assembler/testmasm.cpp trunk/Source/_javascript_Core/b3/B3LowerToAir.cpp trunk/Source/_javascript_Core/b3/B3ReduceStrength.cpp trunk/Source/_javascript_Core/b3/air/AirOpcode.opcodes trunk/Source/_javascript_Core/b3/testb3.h trunk/Source/_javascript_Core/b3/testb3_2.cpp Diff Modified: trunk/Source/_javascript_Core/ChangeLog (279469 => 279470) --- trunk/Source/_javascript_Core/ChangeLog 2021-07-01 17:14:18 UTC (rev 279469) +++ trunk/Source/_javascript_Core/ChangeLog 2021-07-01 17:25:26 UTC (rev 279470) @@ -1,3 +1,85 @@ +2021-07-01 Yijia Huang + +Add a new pattern to instruction selector to use EXTR supported by ARM64 +https://bugs.webkit.org/show_bug.cgi?id=227171 + +Reviewed by Robin Morisset. + +This patch includes two modifications: +1. Introduce a strength reduction rule to zero extend bitfield. +2. Add Extract Register (EXTR) to Air opcode to serve instruction selector. + +--- +### Part A zero extend bitfield ### +--- +A new strength reduction rule is added for the canonical form of the zero-extend +bitfield. + +Turn this: ZShr(Shl(value, amount)), amount) +Into this: BitAnd(value, mask) + +with constraints: +1. 0 <= amount < datasize +2. width = datasize - amount +3. mask is !(mask & (mask + 1)) where bitCount(mask) == width + +--- +### Part B EXTR ### +--- + +Given instruction: +extr Rd, Rn, Rm, lowWidth + +Extract register (EXTR) extracts a register from a pair of registers, where +concat = Rn:Rm and Rd = concat. + +The equivalent pattern of this instruction is: + +d = ((n & mask) << highWidth) | (m >> lowWidth) +highWidth = datasize - lowWidth +mask = (1 << lowWidth) - 1 + +Given B3 IR: +Int @0 = ArgumentReg(%x0) +Int @1 = ArgumentReg(%x1) +Int @2 = mask +Int @3 = BitAnd(@0, @2) +Int @4 = highWidth +Int @5 = Shl(@3, @4) +Int @6 = lowWidth +Int @7 = ZShr(@1, @6) +Int @8 = BitOr(@7, @5) +Void@9 = Return(@10, Terminal) + +Before Adding BIC: +// Old
[webkit-changes] [279469] branches/safari-612.1.21-branch/Source
Title: [279469] branches/safari-612.1.21-branch/Source Revision 279469 Author rubent...@apple.com Date 2021-07-01 10:14:18 -0700 (Thu, 01 Jul 2021) Log Message Versioning. WebKit-7612.1.21.1 Modified Paths branches/safari-612.1.21-branch/Source/_javascript_Core/Configurations/Version.xcconfig branches/safari-612.1.21-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig branches/safari-612.1.21-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig branches/safari-612.1.21-branch/Source/WebCore/Configurations/Version.xcconfig branches/safari-612.1.21-branch/Source/WebCore/PAL/Configurations/Version.xcconfig branches/safari-612.1.21-branch/Source/WebInspectorUI/Configurations/Version.xcconfig branches/safari-612.1.21-branch/Source/WebKit/Configurations/Version.xcconfig branches/safari-612.1.21-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig Diff Modified: branches/safari-612.1.21-branch/Source/_javascript_Core/Configurations/Version.xcconfig (279468 => 279469) --- branches/safari-612.1.21-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2021-07-01 17:09:00 UTC (rev 279468) +++ branches/safari-612.1.21-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2021-07-01 17:14:18 UTC (rev 279469) @@ -24,9 +24,9 @@ MAJOR_VERSION = 612; MINOR_VERSION = 1; TINY_VERSION = 21; -MICRO_VERSION = 0; +MICRO_VERSION = 1; NANO_VERSION = 0; -FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); +FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION)); Modified: branches/safari-612.1.21-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig (279468 => 279469) --- branches/safari-612.1.21-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig 2021-07-01 17:09:00 UTC (rev 279468) +++ branches/safari-612.1.21-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig 2021-07-01 17:14:18 UTC (rev 279469) @@ -24,9 +24,9 @@ MAJOR_VERSION = 612; MINOR_VERSION = 1; TINY_VERSION = 21; -MICRO_VERSION = 0; +MICRO_VERSION = 1; NANO_VERSION = 0; -FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); +FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION)); Modified: branches/safari-612.1.21-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (279468 => 279469) --- branches/safari-612.1.21-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig 2021-07-01 17:09:00 UTC (rev 279468) +++ branches/safari-612.1.21-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig 2021-07-01 17:14:18 UTC (rev 279469) @@ -24,9 +24,9 @@ MAJOR_VERSION = 612; MINOR_VERSION = 1; TINY_VERSION = 21; -MICRO_VERSION = 0; +MICRO_VERSION = 1; NANO_VERSION = 0; -FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); +FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION)); Modified: branches/safari-612.1.21-branch/Source/WebCore/Configurations/Version.xcconfig (279468 => 279469) --- branches/safari-612.1.21-branch/Source/WebCore/Configurations/Version.xcconfig 2021-07-01 17:09:00 UTC (rev 279468) +++ branches/safari-612.1.21-branch/Source/WebCore/Configurations/Version.xcconfig 2021-07-01 17:14:18 UTC (rev 279469) @@ -24,9 +24,9 @@ MAJOR_VERSION = 612; MINOR_VERSION = 1; TINY_VERSION = 21; -MICRO_VERSION = 0; +MICRO_VERSION = 1; NANO_VERSION = 0; -FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); +FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION)); Modified: branches/safari-612.1.21-branch/Source/WebCore/PAL/Configurations/Version.xcconfig (279468 => 279469) --- branches/safari-612.1.21-branch/Source/WebCore/PAL/Configurations/Version.xcconfig 2021-07-01 17:09:00 UTC (rev 279468) +++ branches/safari-612.1.21-branch/Source/WebCore/PAL/Configurations/Version.xcconfig 2021-07-01 17:14:18 UTC (rev 279469) @@ -24,9 +24,9 @@ MAJOR_VERSION = 612; MINOR_VERSION = 1; TINY_VERSION = 21; -MICRO_VERSION = 0; +MICRO_VERSION = 1; NANO_VERSION = 0; -FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); +FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below.
[webkit-changes] [279468] branches/safari-612.1.21-branch/Source/ThirdParty/ANGLE
Title: [279468] branches/safari-612.1.21-branch/Source/ThirdParty/ANGLE Revision 279468 Author rubent...@apple.com Date 2021-07-01 10:09:00 -0700 (Thu, 01 Jul 2021) Log Message Cherry-pick r279373. rdar://problem/80030448 ANGLE Metal primitive restart range computation could index with size_t https://bugs.webkit.org/show_bug.cgi?id=227449 Patch by Kimmo Kinnunen on 2021-06-29 Reviewed by Kenneth Russell. Make the `calculateRestartRanges()` a bit simpler in order for it to be easier to understand. * src/libANGLE/renderer/metal/BufferMtl.h: (rx::IndexRange::IndexRange): Add documentation what the mtl::IndexRange is. Add constructor so that `std::vector::emplace_back()` works. * src/libANGLE/renderer/metal/BufferMtl.mm: (rx::calculateRestartRanges): Index with size_t to make it simpler to understand if the index overflows or not. Use reinterpret_cast in order to not accidentally cast away const from `mtl::BufferRef::mapReadOnly()`. Skip the non-marker elements with `continue` to avoid deep nesting. Give a name to the restart range marker value. Remove intermediate variable `value = bufferData[i]` as it is never used more than once. This simplifies the code as the do-while loop does not need to check the if condition as the loop ending condition already checks. Make the array a returned result instead of out variable. (rx::BufferMtl::getRestartIndices): git-svn-id: https://svn.webkit.org/repository/webkit/trunk@279373 268f45cc-cd09-0410-ab3c-d52691b4dbfc Modified Paths branches/safari-612.1.21-branch/Source/ThirdParty/ANGLE/ChangeLog branches/safari-612.1.21-branch/Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/BufferMtl.h branches/safari-612.1.21-branch/Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/BufferMtl.mm Diff Modified: branches/safari-612.1.21-branch/Source/ThirdParty/ANGLE/ChangeLog (279467 => 279468) --- branches/safari-612.1.21-branch/Source/ThirdParty/ANGLE/ChangeLog 2021-07-01 17:08:26 UTC (rev 279467) +++ branches/safari-612.1.21-branch/Source/ThirdParty/ANGLE/ChangeLog 2021-07-01 17:09:00 UTC (rev 279468) @@ -1,3 +1,70 @@ +2021-07-01 Ruben Turcios + +Cherry-pick r279373. rdar://problem/80030448 + +ANGLE Metal primitive restart range computation could index with size_t +https://bugs.webkit.org/show_bug.cgi?id=227449 + +Patch by Kimmo Kinnunen on 2021-06-29 +Reviewed by Kenneth Russell. + +Make the `calculateRestartRanges()` a bit simpler in order +for it to be easier to understand. + +* src/libANGLE/renderer/metal/BufferMtl.h: +(rx::IndexRange::IndexRange): +Add documentation what the mtl::IndexRange is. +Add constructor so that `std::vector::emplace_back()` works. + +* src/libANGLE/renderer/metal/BufferMtl.mm: +(rx::calculateRestartRanges): +Index with size_t to make it simpler to understand if the index +overflows or not. +Use reinterpret_cast in order to not accidentally cast away +const from `mtl::BufferRef::mapReadOnly()`. +Skip the non-marker elements with `continue` to avoid deep nesting. +Give a name to the restart range marker value. +Remove intermediate variable `value = bufferData[i]` as it is never +used more than once. This simplifies the code as the do-while loop +does not need to check the if condition as the loop ending condition +already checks. +Make the array a returned result instead of out variable. + +(rx::BufferMtl::getRestartIndices): + +git-svn-id: https://svn.webkit.org/repository/webkit/trunk@279373 268f45cc-cd09-0410-ab3c-d52691b4dbfc + +2021-06-29 Kimmo Kinnunen + +ANGLE Metal primitive restart range computation could index with size_t +https://bugs.webkit.org/show_bug.cgi?id=227449 + +Reviewed by Kenneth Russell. + +Make the `calculateRestartRanges()` a bit simpler in order +for it to be easier to understand. + +* src/libANGLE/renderer/metal/BufferMtl.h: +(rx::IndexRange::IndexRange): +Add documentation what the mtl::IndexRange is. +Add constructor so that `std::vector::emplace_back()` works. + +* src/libANGLE/renderer/metal/BufferMtl.mm: +(rx::calculateRestartRanges): +Index with size_t to make it simpler to understand if the index +overflows or not. +Use reinterpret_cast in order to not accidentally cast away +const from `mtl::BufferRef::mapReadOnly()`. +Skip the non-marker elements with `continue` to avoid deep nesting. +Give a name to the restart range marker value. +Remove intermediate variable `value = bufferData[i]` as it is never +used more than once. This simplifies the code as the do-while loop +does not need to check the if condition as the loop
[webkit-changes] [279467] trunk/Source/WebCore
Title: [279467] trunk/Source/WebCore
Revision 279467
Author amir_m...@apple.com
Date 2021-07-01 10:08:26 -0700 (Thu, 01 Jul 2021)
Log Message
Unreviewed, reverting r279452.
Broke MacOS build
Reverted changeset:
"PCM: Change import from CryptoKitCBridging to
CryptoKitPrivate"
https://bugs.webkit.org/show_bug.cgi?id=227556
https://commits.webkit.org/r279452
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/PAL/ChangeLog
trunk/Source/WebCore/PAL/PAL.xcodeproj/project.pbxproj
trunk/Source/WebCore/PAL/pal/PlatformMac.cmake
trunk/Source/WebCore/loader/cocoa/PrivateClickMeasurementCocoa.mm
Added Paths
trunk/Source/WebCore/PAL/pal/cocoa/CryptoKitCBridgingSoftLink.h
trunk/Source/WebCore/PAL/pal/cocoa/CryptoKitCBridgingSoftLink.mm
trunk/Source/WebCore/PAL/pal/spi/cocoa/CryptoKitCBridgingSPI.h
Removed Paths
trunk/Source/WebCore/PAL/pal/cocoa/CryptoKitPrivateSoftLink.h
trunk/Source/WebCore/PAL/pal/cocoa/CryptoKitPrivateSoftLink.mm
trunk/Source/WebCore/PAL/pal/spi/cocoa/CryptoKitPrivateSPI.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (279466 => 279467)
--- trunk/Source/WebCore/ChangeLog 2021-07-01 17:03:17 UTC (rev 279466)
+++ trunk/Source/WebCore/ChangeLog 2021-07-01 17:08:26 UTC (rev 279467)
@@ -1,3 +1,16 @@
+2021-07-01 Amir Mark Jr
+
+Unreviewed, reverting r279452.
+
+Broke MacOS build
+
+Reverted changeset:
+
+"PCM: Change import from CryptoKitCBridging to
+CryptoKitPrivate"
+https://bugs.webkit.org/show_bug.cgi?id=227556
+https://commits.webkit.org/r279452
+
2021-07-01 Alan Bujtas
VisiblePosition::absoluteSelectionBoundsForLine fails on multiline vertical-rl content
Modified: trunk/Source/WebCore/PAL/ChangeLog (279466 => 279467)
--- trunk/Source/WebCore/PAL/ChangeLog 2021-07-01 17:03:17 UTC (rev 279466)
+++ trunk/Source/WebCore/PAL/ChangeLog 2021-07-01 17:08:26 UTC (rev 279467)
@@ -1,3 +1,16 @@
+2021-07-01 Amir Mark Jr
+
+Unreviewed, reverting r279452.
+
+Broke MacOS build
+
+Reverted changeset:
+
+"PCM: Change import from CryptoKitCBridging to
+CryptoKitPrivate"
+https://bugs.webkit.org/show_bug.cgi?id=227556
+https://commits.webkit.org/r279452
+
2021-06-30 John Wilander
PCM: Change import from CryptoKitCBridging to CryptoKitPrivate
Modified: trunk/Source/WebCore/PAL/PAL.xcodeproj/project.pbxproj (279466 => 279467)
--- trunk/Source/WebCore/PAL/PAL.xcodeproj/project.pbxproj 2021-07-01 17:03:17 UTC (rev 279466)
+++ trunk/Source/WebCore/PAL/PAL.xcodeproj/project.pbxproj 2021-07-01 17:08:26 UTC (rev 279467)
@@ -140,8 +140,8 @@
570AB8F920AF6E3D00B8BE87 /* NSXPCConnectionSPI.h in Headers */ = {isa = PBXBuildFile; fileRef = 570AB8F820AF6E3D00B8BE87 /* NSXPCConnectionSPI.h */; };
572A107822B456F500F410C8 /* AuthKitSPI.h in Headers */ = {isa = PBXBuildFile; fileRef = 572A107722B456F500F410C8 /* AuthKitSPI.h */; };
576CA9D622B854AB0030143C /* AppSSOSPI.h in Headers */ = {isa = PBXBuildFile; fileRef = 576CA9D522B854AB0030143C /* AppSSOSPI.h */; };
- 57F1C90925DCF0CF00E8F6EA /* CryptoKitPrivateSoftLink.h in Headers */ = {isa = PBXBuildFile; fileRef = 57F1C90725DCF0CF00E8F6EA /* CryptoKitPrivateSoftLink.h */; };
- 57F1C90A25DCF0CF00E8F6EA /* CryptoKitPrivateSoftLink.mm in Sources */ = {isa = PBXBuildFile; fileRef = 57F1C90825DCF0CF00E8F6EA /* CryptoKitPrivateSoftLink.mm */; };
+ 57F1C90925DCF0CF00E8F6EA /* CryptoKitCBridgingSoftLink.h in Headers */ = {isa = PBXBuildFile; fileRef = 57F1C90725DCF0CF00E8F6EA /* CryptoKitCBridgingSoftLink.h */; };
+ 57F1C90A25DCF0CF00E8F6EA /* CryptoKitCBridgingSoftLink.mm in Sources */ = {isa = PBXBuildFile; fileRef = 57F1C90825DCF0CF00E8F6EA /* CryptoKitCBridgingSoftLink.mm */; };
57FD318A22B3593E008D0E8B /* AppSSOSoftLink.mm in Sources */ = {isa = PBXBuildFile; fileRef = 57FD318922B3593E008D0E8B /* AppSSOSoftLink.mm */; };
57FD318B22B35989008D0E8B /* AppSSOSoftLink.h in Headers */ = {isa = PBXBuildFile; fileRef = 57FD318822B3592F008D0E8B /* AppSSOSoftLink.h */; };
5C7C787323AC3E770065F47E /* ManagedConfigurationSoftLink.h in Headers */ = {isa = PBXBuildFile; fileRef = 5C7C787123AC3E770065F47E /* ManagedConfigurationSoftLink.h */; };
@@ -200,7 +200,7 @@
CDACB361238742740018D7CE /* MediaToolboxSoftLink.h in Headers */ = {isa = PBXBuildFile; fileRef = CDACB35F23873E480018D7CE /* MediaToolboxSoftLink.h */; };
CDF91113220E4EEC001EA39E /* CelestialSPI.h in Headers */ = {isa = PBXBuildFile; fileRef = CDF91112220E4EEC001EA39E /* CelestialSPI.h */; };
CE5673872151A7B9002F92D7 /* IOKitSPI.h in Headers */ = {isa = PBXBuildFile; fileRef = CE5673862151A7B9002F92D7 /* IOKitSPI.h */; };
- DF83E209263734F1000825EF /* CryptoKitPrivateSPI.h in Headers */ = {isa = PBXBuildFile; fileRef = DF83E208263734F1000825EF /* CryptoKitPrivateSPI.h */; };
+ DF83E209263734F1000825EF /* CryptoKitCBridgingSPI.h in Headers */ = {isa = PBXBuildFile; fileRef = DF83E208263734F1000825EF /*
[webkit-changes] [279466] trunk/Source/ThirdParty/ANGLE
Title: [279466] trunk/Source/ThirdParty/ANGLE
Revision 279466
Author kpidding...@apple.com
Date 2021-07-01 10:03:17 -0700 (Thu, 01 Jul 2021)
Log Message
BabylonJS Under water demo is slower than it should be on Intel
https://bugs.webkit.org/show_bug.cgi?id=227226
Remove fastMath restriction on Intel
Removing fastmath in all scenarios leads to unacceptable performance on integrated graphics
Currently, webgl conformance tests and the Safari tests don't have any invariance tests that show invariance issues. deQP tests are similarly passing.
In Metal-ANGLE, gl_position and gl_fragcoord are valid attributes to be marked as invariant. All others will be ignored.
Reviewed by Kenneth Russell.
* src/compiler/translator/TranslatorMetalDirect/EmitMetal.cpp:
(GenMetalTraverser::emitPostQualifier):
* src/libANGLE/renderer/metal/mtl_utils.mm:
(rx::mtl::CreateShaderLibrary):
Modified Paths
trunk/Source/ThirdParty/ANGLE/ChangeLog
trunk/Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/mtl_utils.mm
Diff
Modified: trunk/Source/ThirdParty/ANGLE/ChangeLog (279465 => 279466)
--- trunk/Source/ThirdParty/ANGLE/ChangeLog 2021-07-01 16:34:58 UTC (rev 279465)
+++ trunk/Source/ThirdParty/ANGLE/ChangeLog 2021-07-01 17:03:17 UTC (rev 279466)
@@ -1,3 +1,20 @@
+2021-07-01 Kyle Piddington
+
+BabylonJS Under water demo is slower than it should be on Intel
+https://bugs.webkit.org/show_bug.cgi?id=227226
+
+Remove fastMath restriction on Intel
+Removing fastmath in all scenarios leads to unacceptable performance on integrated graphics
+Currently, webgl conformance tests and the Safari tests don't have any invariance tests that show invariance issues. deQP tests are similarly passing.
+In Metal-ANGLE, gl_position and gl_fragcoord are valid attributes to be marked as invariant. All others will be ignored.
+
+Reviewed by Kenneth Russell.
+
+* src/compiler/translator/TranslatorMetalDirect/EmitMetal.cpp:
+(GenMetalTraverser::emitPostQualifier):
+* src/libANGLE/renderer/metal/mtl_utils.mm:
+(rx::mtl::CreateShaderLibrary):
+
2021-06-30 Kimmo Kinnunen
ASSERT in webgl/1.0.x/conformance/glsl/misc/uninitialized-local-global-variables.html IdGen ASSERT(*base != '_');
Modified: trunk/Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/mtl_utils.mm (279465 => 279466)
--- trunk/Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/mtl_utils.mm 2021-07-01 16:34:58 UTC (rev 279465)
+++ trunk/Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/mtl_utils.mm 2021-07-01 17:03:17 UTC (rev 279466)
@@ -596,12 +596,6 @@
options.fastMathEnabled = false;
#endif
options.languageVersion = GetUserSetOrHighestMSLVersion(options.languageVersion);
-// TODO(jcunningham): workaround for intel driver not preserving invariance on all shaders
-const uint32_t vendor_id = GetDeviceVendorId(metalDevice);
-if (vendor_id == angle::kVendorID_Intel)
-{
-options.fastMathEnabled = false;
-}
options.preprocessorMacros = substitutionMacros;
auto library = [metalDevice newLibraryWithSource:nsSource options:options error:];
if (angle::GetEnvironmentVar(kANGLEPrintMSLEnv)[0] == '1')
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [279465] trunk/Source/WebKit
Title: [279465] trunk/Source/WebKit
Revision 279465
Author jer.no...@apple.com
Date 2021-07-01 09:34:58 -0700 (Thu, 01 Jul 2021)
Log Message
[Mac] Adopt async GroupActivity.sessions() iterable instead of GroupSessionObserver
https://bugs.webkit.org/show_bug.cgi?id=227548
Reviewed by Sam Weinig.
Rather than adopting GroupSessionObserver, which requires Combine, GroupActivity.sessions()
uses AsyncSequence, a new Swift 5.5 feature, to allow clients to be notified that new
sessions are avaliable.
* UIProcess/Cocoa/GroupActivities/WKGroupSession.swift:
(WKGroupSessionObserver.incomingSessionsTask):
(WKGroupSessionObserver.receivedSession(_:)):
(WKGroupSessionObserver.cancellables): Deleted.
(WKGroupSessionObserver.recievedSession(_:)): Deleted.
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/Cocoa/GroupActivities/WKGroupSession.swift
Diff
Modified: trunk/Source/WebKit/ChangeLog (279464 => 279465)
--- trunk/Source/WebKit/ChangeLog 2021-07-01 15:58:00 UTC (rev 279464)
+++ trunk/Source/WebKit/ChangeLog 2021-07-01 16:34:58 UTC (rev 279465)
@@ -1,3 +1,21 @@
+2021-07-01 Jer Noble
+
+[Mac] Adopt async GroupActivity.sessions() iterable instead of GroupSessionObserver
+https://bugs.webkit.org/show_bug.cgi?id=227548
+
+
+Reviewed by Sam Weinig.
+
+Rather than adopting GroupSessionObserver, which requires Combine, GroupActivity.sessions()
+uses AsyncSequence, a new Swift 5.5 feature, to allow clients to be notified that new
+sessions are avaliable.
+
+* UIProcess/Cocoa/GroupActivities/WKGroupSession.swift:
+(WKGroupSessionObserver.incomingSessionsTask):
+(WKGroupSessionObserver.receivedSession(_:)):
+(WKGroupSessionObserver.cancellables): Deleted.
+(WKGroupSessionObserver.recievedSession(_:)): Deleted.
+
2021-07-01 Youenn Fablet
[Cocoa] Migrate WebRTC UDP socket handling to NW API
Modified: trunk/Source/WebKit/UIProcess/Cocoa/GroupActivities/WKGroupSession.swift (279464 => 279465)
--- trunk/Source/WebKit/UIProcess/Cocoa/GroupActivities/WKGroupSession.swift 2021-07-01 15:58:00 UTC (rev 279464)
+++ trunk/Source/WebKit/UIProcess/Cocoa/GroupActivities/WKGroupSession.swift 2021-07-01 16:34:58 UTC (rev 279465)
@@ -128,18 +128,25 @@
public class WKGroupSessionObserver : NSObject {
@objc public var newSessionCallback: ((WKGroupSessionWrapper) -> Void)?
-private var observer = GroupSessionObserver(for: URLActivity.self)
-private var cancellables: Set = []
+private var incomingSessionsTask: Task.Handle?
@objc public override init() {
super.init()
-observer
-.sink { [unowned self] in self.recievedSession($0) }
-.store(in: )
+incomingSessionsTask = detach { [weak self] in
+for await newSession in URLActivity.self.sessions() {
+DispatchQueue.main.async { [weak self] in
+self?.receivedSession(newSession)
+}
+}
+}
}
-private func recievedSession(_ session: GroupSession) {
+deinit {
+incomingSessionsTask?.cancel()
+}
+
+private func receivedSession(_ session: GroupSession) {
guard let callback = newSessionCallback else {
return
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [279464] trunk/Source/WebKit
Title: [279464] trunk/Source/WebKit
Revision 279464
Author you...@apple.com
Date 2021-07-01 08:58:00 -0700 (Thu, 01 Jul 2021)
Log Message
[Cocoa] Migrate WebRTC UDP socket handling to NW API
https://bugs.webkit.org/show_bug.cgi?id=227210
Unreviewed, post commit fix.
* NetworkProcess/webrtc/NetworkRTCUDPSocketCocoa.h:
(WTF::HashTraits::constructDeletedValue):
(WTF::HashTraits::isDeletedValue):
No need to set all deleted value slots, instead just rely on scope id being equal to numeric_limits::min.
Also ensure we do not add an empty/deleted address to the map.
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/NetworkProcess/webrtc/NetworkRTCUDPSocketCocoa.h
trunk/Source/WebKit/NetworkProcess/webrtc/NetworkRTCUDPSocketCocoa.mm
Diff
Modified: trunk/Source/WebKit/ChangeLog (279463 => 279464)
--- trunk/Source/WebKit/ChangeLog 2021-07-01 13:29:07 UTC (rev 279463)
+++ trunk/Source/WebKit/ChangeLog 2021-07-01 15:58:00 UTC (rev 279464)
@@ -2,7 +2,21 @@
[Cocoa] Migrate WebRTC UDP socket handling to NW API
https://bugs.webkit.org/show_bug.cgi?id=227210
+
+Unreviewed, post commit fix.
+
+* NetworkProcess/webrtc/NetworkRTCUDPSocketCocoa.h:
+(WTF::HashTraits::constructDeletedValue):
+(WTF::HashTraits::isDeletedValue):
+No need to set all deleted value slots, instead just rely on scope id being equal to numeric_limits::min.
+Also ensure we do not add an empty/deleted address to the map.
+
+2021-07-01 Youenn Fablet
+
+[Cocoa] Migrate WebRTC UDP socket handling to NW API
+https://bugs.webkit.org/show_bug.cgi?id=227210
+
Reviewed by Eric Carlson.
Migrate UDP socket handling from WebRTC physical socket server to nw API for Cocoa ports.
Modified: trunk/Source/WebKit/NetworkProcess/webrtc/NetworkRTCUDPSocketCocoa.h (279463 => 279464)
--- trunk/Source/WebKit/NetworkProcess/webrtc/NetworkRTCUDPSocketCocoa.h 2021-07-01 13:29:07 UTC (rev 279463)
+++ trunk/Source/WebKit/NetworkProcess/webrtc/NetworkRTCUDPSocketCocoa.h 2021-07-01 15:58:00 UTC (rev 279464)
@@ -29,6 +29,7 @@
#include "NetworkRTCProvider.h"
#include
+#include
#include
#include
@@ -46,8 +47,8 @@
template<> struct HashTraits : GenericHashTraits {
static rtc::SocketAddress emptyValue() { return rtc::SocketAddress { }; }
-static void constructDeletedValue(rtc::SocketAddress& address) { address = { }; address.SetScopeID(-1); }
-static bool isDeletedValue(const rtc::SocketAddress& address) { return address.scope_id() == -1; }
+static void constructDeletedValue(rtc::SocketAddress& address) { address.SetScopeID(std::numeric_limits::min()); }
+static bool isDeletedValue(const rtc::SocketAddress& address) { return address.scope_id() == std::numeric_limits::min(); }
};
}
Modified: trunk/Source/WebKit/NetworkProcess/webrtc/NetworkRTCUDPSocketCocoa.mm (279463 => 279464)
--- trunk/Source/WebKit/NetworkProcess/webrtc/NetworkRTCUDPSocketCocoa.mm 2021-07-01 13:29:07 UTC (rev 279463)
+++ trunk/Source/WebKit/NetworkProcess/webrtc/NetworkRTCUDPSocketCocoa.mm 2021-07-01 15:58:00 UTC (rev 279464)
@@ -168,6 +168,8 @@
return;
auto remoteAddress = socketAddressFromIncomingConnection(connection);
+ASSERT(remoteAddress != HashTraits::emptyValue() && !HashTraits::isDeletedValue(remoteAddress));
+
protectedThis->m_nwConnections.set(remoteAddress, connection);
protectedThis->setupNWConnection(connection, remoteAddress);
}).get());
@@ -253,6 +255,11 @@
void NetworkRTCUDPSocketCocoaConnections::sendTo(const uint8_t* data, size_t size, const rtc::SocketAddress& remoteAddress, const rtc::PacketOptions& options)
{
+bool isInCorrectValue = (remoteAddress == HashTraits::emptyValue()) || HashTraits::isDeletedValue(remoteAddress);
+ASSERT(!isInCorrectValue);
+if (isInCorrectValue)
+return;
+
nw_connection_t nwConnection;
{
Locker locker { m_nwConnectionsLock };
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [279463] trunk
Title: [279463] trunk
Revision 279463
Author za...@apple.com
Date 2021-07-01 06:29:07 -0700 (Thu, 01 Jul 2021)
Log Message
VisiblePosition::absoluteSelectionBoundsForLine fails on multiline vertical-rl content
https://bugs.webkit.org/show_bug.cgi?id=227543
Reviewed by Simon Fraser.
Source/WebCore:
absoluteSelectionBoundsForLine flips the line's logical rect for the writing mode (horizontal vs. vertical)
but not for the block flow direction (ltr vs. rtl).
This adjustment is very similar to what we do in absoluteCaretBounds (see absoluteBoundsForLocalCaretRect).
* editing/VisiblePosition.cpp:
(WebCore::VisiblePosition::absoluteSelectionBoundsForLine const):
* testing/Internals.cpp:
(WebCore::Internals::absoluteLineRectFromPoint):
* testing/Internals.h:
* testing/Internals.idl:
LayoutTests:
* fast/inline/line-rect-from-point-expected.txt: Added.
* fast/inline/line-rect-from-point.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/editing/VisiblePosition.cpp
trunk/Source/WebCore/testing/Internals.cpp
trunk/Source/WebCore/testing/Internals.h
trunk/Source/WebCore/testing/Internals.idl
Added Paths
trunk/LayoutTests/fast/inline/line-rect-from-point-expected.txt
trunk/LayoutTests/fast/inline/line-rect-from-point.html
Diff
Modified: trunk/LayoutTests/ChangeLog (279462 => 279463)
--- trunk/LayoutTests/ChangeLog 2021-07-01 11:20:43 UTC (rev 279462)
+++ trunk/LayoutTests/ChangeLog 2021-07-01 13:29:07 UTC (rev 279463)
@@ -1,3 +1,14 @@
+2021-07-01 Alan Bujtas
+
+VisiblePosition::absoluteSelectionBoundsForLine fails on multiline vertical-rl content
+https://bugs.webkit.org/show_bug.cgi?id=227543
+
+
+Reviewed by Simon Fraser.
+
+* fast/inline/line-rect-from-point-expected.txt: Added.
+* fast/inline/line-rect-from-point.html: Added.
+
2021-07-01 Youenn Fablet
[Cocoa] Migrate WebRTC UDP socket handling to NW API
Added: trunk/LayoutTests/fast/inline/line-rect-from-point-expected.txt (0 => 279463)
--- trunk/LayoutTests/fast/inline/line-rect-from-point-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/inline/line-rect-from-point-expected.txt 2021-07-01 13:29:07 UTC (rev 279463)
@@ -0,0 +1,12 @@
+short text
+long enough to wrap to next line
+short text
+short text
+long enough to wrap to next line
+short text
+short text
+long enough to wrap to next line
+short text
+[1x11][190x10]
+[11x203][10x190]
+[181x405][10x190]
Added: trunk/LayoutTests/fast/inline/line-rect-from-point.html (0 => 279463)
--- trunk/LayoutTests/fast/inline/line-rect-from-point.html (rev 0)
+++ trunk/LayoutTests/fast/inline/line-rect-from-point.html 2021-07-01 13:29:07 UTC (rev 279463)
@@ -0,0 +1,47 @@
+
+
+
+
+body {
+ font-family: Ahem;
+ font-size: 10px;
+ margin: 0px;
+}
+.container {
+ border: 1px solid green;
+ width: 200px;
+ height: 200px;
+}
+
+
+
+
+ short text
+ long enough to wrap to next line
+ short text
+
+
+ short text
+ long enough to wrap to next line
+ short text
+
+
+ short text
+ long enough to wrap to next line
+ short text
+
+
+
+
+ document.body.offsetHeight;
+ if (window.internals) {
+testRunner.dumpAsText();
+let line1 = internals.absoluteLineRectFromPoint(first.offsetLeft + 5, first.offsetTop + 15);
+let line2 = internals.absoluteLineRectFromPoint(second.offsetLeft + 15, second.offsetTop + 5);
+let line3 = internals.absoluteLineRectFromPoint(third.offsetWidth - 15, third.offsetTop + 5);
+result.innerHTML= "[" + line1.x + "x" + line1.y + "]" + "[" + line1.width + "x" + line1.height + "]"
+ + "
[" + line2.x + "x" + line2.y + "]" + "[" + line2.width + "x" + line2.height + "]"
+ + "
[" + line3.x + "x" + line3.y + "]" + "[" + line3.width + "x" + line3.height + "]";
+}
+
+
Modified: trunk/Source/WebCore/ChangeLog (279462 => 279463)
--- trunk/Source/WebCore/ChangeLog 2021-07-01 11:20:43 UTC (rev 279462)
+++ trunk/Source/WebCore/ChangeLog 2021-07-01 13:29:07 UTC (rev 279463)
@@ -1,3 +1,22 @@
+2021-07-01 Alan Bujtas
+
+VisiblePosition::absoluteSelectionBoundsForLine fails on multiline vertical-rl content
+https://bugs.webkit.org/show_bug.cgi?id=227543
+
+
+Reviewed by Simon Fraser.
+
+absoluteSelectionBoundsForLine flips the line's logical rect for the writing mode (horizontal vs. vertical)
+but not for the block flow direction (ltr vs. rtl).
+This adjustment is very similar to what we do in absoluteCaretBounds (see absoluteBoundsForLocalCaretRect).
+
+* editing/VisiblePosition.cpp:
+(WebCore::VisiblePosition::absoluteSelectionBoundsForLine const):
+* testing/Internals.cpp:
+(WebCore::Internals::absoluteLineRectFromPoint):
+* testing/Internals.h:
+* testing/Internals.idl:
+
2021-07-01 Carlos Garcia Campos
REGRESSION(r278062): [Nicosia] Threaded rendering is broken
[webkit-changes] [279462] trunk/Source/WebCore
Title: [279462] trunk/Source/WebCore
Revision 279462
Author carlo...@webkit.org
Date 2021-07-01 04:20:43 -0700 (Thu, 01 Jul 2021)
Log Message
REGRESSION(r278062): [Nicosia] Threaded rendering is broken since r278062
https://bugs.webkit.org/show_bug.cgi?id=227578
Reviewed by Žan Doberšek.
Since r278062 NicosiaCairoOperationRecorder is a GraphicsContext class, so we need to bring back things
previously done by the base class and chain up to base class save/restore and being/end transparency.
* platform/graphics/nicosia/cairo/NicosiaCairoOperationRecorder.cpp:
(Nicosia::CairoOperationRecorder::fillPath):
(Nicosia::CairoOperationRecorder::strokePath):
(Nicosia::CairoOperationRecorder::drawLine):
(Nicosia::CairoOperationRecorder::drawLinesForText):
(Nicosia::CairoOperationRecorder::drawFocusRing):
(Nicosia::CairoOperationRecorder::save):
(Nicosia::CairoOperationRecorder::restore):
(Nicosia::CairoOperationRecorder::beginTransparencyLayer):
(Nicosia::CairoOperationRecorder::endTransparencyLayer):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/nicosia/cairo/NicosiaCairoOperationRecorder.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (279461 => 279462)
--- trunk/Source/WebCore/ChangeLog 2021-07-01 10:37:39 UTC (rev 279461)
+++ trunk/Source/WebCore/ChangeLog 2021-07-01 11:20:43 UTC (rev 279462)
@@ -1,3 +1,24 @@
+2021-07-01 Carlos Garcia Campos
+
+REGRESSION(r278062): [Nicosia] Threaded rendering is broken since r278062
+https://bugs.webkit.org/show_bug.cgi?id=227578
+
+Reviewed by Žan Doberšek.
+
+Since r278062 NicosiaCairoOperationRecorder is a GraphicsContext class, so we need to bring back things
+previously done by the base class and chain up to base class save/restore and being/end transparency.
+
+* platform/graphics/nicosia/cairo/NicosiaCairoOperationRecorder.cpp:
+(Nicosia::CairoOperationRecorder::fillPath):
+(Nicosia::CairoOperationRecorder::strokePath):
+(Nicosia::CairoOperationRecorder::drawLine):
+(Nicosia::CairoOperationRecorder::drawLinesForText):
+(Nicosia::CairoOperationRecorder::drawFocusRing):
+(Nicosia::CairoOperationRecorder::save):
+(Nicosia::CairoOperationRecorder::restore):
+(Nicosia::CairoOperationRecorder::beginTransparencyLayer):
+(Nicosia::CairoOperationRecorder::endTransparencyLayer):
+
2021-07-01 Youenn Fablet
[Cocoa] Migrate WebRTC UDP socket handling to NW API
Modified: trunk/Source/WebCore/platform/graphics/nicosia/cairo/NicosiaCairoOperationRecorder.cpp (279461 => 279462)
--- trunk/Source/WebCore/platform/graphics/nicosia/cairo/NicosiaCairoOperationRecorder.cpp 2021-07-01 10:37:39 UTC (rev 279461)
+++ trunk/Source/WebCore/platform/graphics/nicosia/cairo/NicosiaCairoOperationRecorder.cpp 2021-07-01 11:20:43 UTC (rev 279462)
@@ -37,6 +37,10 @@
#include
#include
+#if PLATFORM(WPE) || PLATFORM(GTK)
+#include "ThemeAdwaita.h"
+#endif
+
namespace Nicosia {
using namespace WebCore;
@@ -381,6 +385,9 @@
}
};
+if (path.isEmpty())
+return;
+
auto& state = this->state();
append(createCommand(path, Cairo::FillSource(state), Cairo::ShadowState(state)));
}
@@ -443,6 +450,9 @@
}
};
+if (path.isEmpty())
+return;
+
auto& state = this->state();
append(createCommand(path, Cairo::StrokeSource(state), Cairo::ShadowState(state)));
}
@@ -608,6 +618,9 @@
}
};
+if (strokeStyle() == NoStroke)
+return;
+
auto& state = this->state();
append(createCommand(point1, point2, state.strokeStyle, state.strokeColor, state.strokeThickness, state.shouldAntialias));
}
@@ -628,6 +641,9 @@
}
};
+if (widths.isEmpty())
+return;
+
auto& state = this->state();
append(createCommand(point, thickness, widths, printing, doubleUnderlines, state.strokeColor));
}
@@ -673,6 +689,10 @@
void CairoOperationRecorder::drawFocusRing(const Path& path, float width, float offset, const Color& color)
{
+#if PLATFORM(WPE) || PLATFORM(GTK)
+ThemeAdwaita::paintFocus(*this, path, color);
+UNUSED_PARAM(width);
+#else
struct DrawFocusRing final : PaintingOperation, OperationData {
virtual ~DrawFocusRing() = default;
@@ -687,12 +707,17 @@
}
};
+append(createCommand(path, width, color));
+#endif
UNUSED_PARAM(offset);
-append(createCommand(path, width, color));
}
void CairoOperationRecorder::drawFocusRing(const Vector& rects, float width, float offset, const Color& color)
{
+#if PLATFORM(WPE) || PLATFORM(GTK)
+ThemeAdwaita::paintFocus(*this, rects, color);
+UNUSED_PARAM(width);
+#else
struct DrawFocusRing final : PaintingOperation, OperationData, float, Color> {
virtual ~DrawFocusRing() = default;
@@ -707,8 +732,9 @@
}
};
+append(createCommand(rects, width, color));
+#endif
[webkit-changes] [279461] trunk
Title: [279461] trunk Revision 279461 Author you...@apple.com Date 2021-07-01 03:37:39 -0700 (Thu, 01 Jul 2021) Log Message [Cocoa] Migrate WebRTC UDP socket handling to NW API https://bugs.webkit.org/show_bug.cgi?id=227210 LayoutTests/imported/w3c: Reviewed by Eric Carlson. Rebasing tests as timing changes a bit. This aligns with Chrome and Firefox behavior. * web-platform-tests/webrtc/no-media-call-expected.txt: * web-platform-tests/webrtc/promises-call-expected.txt: Source/ThirdParty/libwebrtc: Reviewed by Eric Carlson. * Configurations/libwebrtc.iOS.exp: * Configurations/libwebrtc.iOSsim.exp: * Configurations/libwebrtc.mac.exp: Source/WebCore: Reviewed by Eric Carlson. Add infrastructure to new experimental feature flag for NW backed UDP sockets. * page/RuntimeEnabledFeatures.h: (WebCore::RuntimeEnabledFeatures::webRTCPlatformTCPSocketsEnabled const): (WebCore::RuntimeEnabledFeatures::setWebRTCPlatformTCPSocketsEnabled): (WebCore::RuntimeEnabledFeatures::webRTCPlatformUDPSocketsEnabled const): (WebCore::RuntimeEnabledFeatures::setWebRTCPlatformUDPSocketsEnabled): Source/WebKit: Reviewed by Eric Carlson. Migrate UDP socket handling from WebRTC physical socket server to nw API for Cocoa ports. For each UDP socket opened, we open a nw_listener that will listen to inbound connections. On inbound connection, we receive a nw_connection that we store in a address -> connection map. Whenever sending a packet, we look at the remote address. If needed, we create a nw_connection to that particular remote address and store it in the address -> connection map. We then use the pre-existing or newly created nw_connection to send the packet. Make sure to cancel NW connection in case of failure before releasing the socket. Covered by existing tests * NetworkProcess/webrtc/NetworkRTCProvider.cpp: (WebKit::NetworkRTCProvider::createUDPSocket): (WebKit::NetworkRTCProvider::createClientTCPSocket): * NetworkProcess/webrtc/NetworkRTCProvider.h: (WebKit::NetworkRTCProvider::setPlatformTCPSocketsEnabled): (WebKit::NetworkRTCProvider::setPlatformUDPSocketsEnabled): * NetworkProcess/webrtc/NetworkRTCProvider.messages.in: * NetworkProcess/webrtc/NetworkRTCTCPSocketCocoa.h: Copied from Source/WebKit/NetworkProcess/webrtc/NetworkRTCSocketCocoa.h. * NetworkProcess/webrtc/NetworkRTCTCPSocketCocoa.mm: Renamed from Source/WebKit/NetworkProcess/webrtc/NetworkRTCSocketCocoa.mm. (WebKit::tcpSocketQueue): (WebKit::NetworkRTCTCPSocketCocoa::createClientTCPSocket): (WebKit::NetworkRTCTCPSocketCocoa::NetworkRTCTCPSocketCocoa): (WebKit::NetworkRTCTCPSocketCocoa::close): (WebKit::NetworkRTCTCPSocketCocoa::setOption): (WebKit::NetworkRTCTCPSocketCocoa::createMessageBuffer): (WebKit::NetworkRTCTCPSocketCocoa::sendTo): * NetworkProcess/webrtc/NetworkRTCUDPSocketCocoa.h: Added. (WTF::DefaultHash::hash): (WTF::DefaultHash::equal): (WTF::HashTraits::emptyValue): (WTF::HashTraits::constructDeletedValue): (WTF::HashTraits::isDeletedValue): * NetworkProcess/webrtc/NetworkRTCUDPSocketCocoa.mm: Added. (WebKit::NetworkRTCUDPSocketCocoaConnections::create): (WebKit::NetworkRTCUDPSocketCocoaConnections::WTF_GUARDED_BY_LOCK): (WebKit::udpSocketQueue): (WebKit::NetworkRTCUDPSocketCocoa::createUDPSocket): (WebKit::NetworkRTCUDPSocketCocoa::NetworkRTCUDPSocketCocoa): (WebKit::NetworkRTCUDPSocketCocoa::~NetworkRTCUDPSocketCocoa): (WebKit::NetworkRTCUDPSocketCocoa::close): (WebKit::NetworkRTCUDPSocketCocoa::setOption): (WebKit::NetworkRTCUDPSocketCocoa::sendTo): (WebKit::NetworkRTCUDPSocketCocoaConnections::NetworkRTCUDPSocketCocoaConnections): (WebKit::NetworkRTCUDPSocketCocoaConnections::close): (WebKit::NetworkRTCUDPSocketCocoaConnections::setOption): (WebKit::processUDPData): (WebKit::NetworkRTCUDPSocketCocoaConnections::createNWConnection): (WebKit::NetworkRTCUDPSocketCocoaConnections::setupNWConnection): (WebKit::NetworkRTCUDPSocketCocoaConnections::sendTo): * SourcesCocoa.txt: * WebKit.xcodeproj/project.pbxproj: * WebProcess/Network/webrtc/LibWebRTCSocketFactory.cpp: (WebKit::LibWebRTCSocketFactory::setConnection): Source/WTF: Reviewed by Eric Carlson. Add a new experimental flag for NW backed UDP sockets. * Scripts/Preferences/WebPreferencesExperimental.yaml: LayoutTests: Reviewed by Eric Carlson. * platform/ios-simulator-wk2/TestExpectations: Mark test as failed, as this test is using unsupported API (transport). Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/imported/w3c/ChangeLog trunk/LayoutTests/imported/w3c/web-platform-tests/webrtc/no-media-call-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/webrtc/promises-call-expected.txt trunk/LayoutTests/platform/ios-simulator-wk2/TestExpectations trunk/Source/ThirdParty/libwebrtc/ChangeLog trunk/Source/ThirdParty/libwebrtc/Configurations/libwebrtc.iOS.exp trunk/Source/ThirdParty/libwebrtc/Configurations/libwebrtc.iOSsim.exp trunk/Source/ThirdParty/libwebrtc/Configurations/libwebrtc.mac.exp trunk/Source/WTF/ChangeLog
[webkit-changes] [279460] trunk/Source
Title: [279460] trunk/Source Revision 279460 Author carlo...@webkit.org Date 2021-07-01 03:35:07 -0700 (Thu, 01 Jul 2021) Log Message [Cairo] Simplify GraphicsContextCairo creation https://bugs.webkit.org/show_bug.cgi?id=227575 Reviewed by Žan Doberšek. Source/WebCore: Remove the constructors taking a PlatformContextCairo and add two that receive a RefPtr&& and cairo_surface_t*. In both cases the PlatformContextCairo is created, so it's now always owned and callers don't need to create it. No change in behavior, covered by existing tests. * platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContextCairo::GraphicsContextCairo): (WebCore::GraphicsContextCairo::drawLine): * platform/graphics/cairo/GraphicsContextCairo.h: * platform/graphics/cairo/ImageBufferCairoSurfaceBackend.cpp: (WebCore::ImageBufferCairoSurfaceBackend::ImageBufferCairoSurfaceBackend): (WebCore::ImageBufferCairoSurfaceBackend::context const): * platform/graphics/cairo/ImageBufferCairoSurfaceBackend.h: * platform/graphics/cairo/NativeImageCairo.cpp: * platform/graphics/cairo/PlatformContextCairo.cpp: (WebCore::PlatformContextCairo::PlatformContextCairo): * platform/graphics/cairo/PlatformContextCairo.h: (WebCore::PlatformContextCairo::cr const): (WebCore::PlatformContextCairo::cr): Deleted. (WebCore::PlatformContextCairo::setCr): Deleted. * platform/graphics/nicosia/cairo/NicosiaPaintingContextCairo.cpp: (Nicosia::PaintingContextCairo::ForPainting::ForPainting): (Nicosia::PaintingContextCairo::ForPainting::~ForPainting): (Nicosia::PaintingContextCairo::ForPainting::replay): * platform/graphics/nicosia/cairo/NicosiaPaintingContextCairo.h: * platform/graphics/win/GraphicsContextCairoWin.cpp: (WebCore::GraphicsContextCairo::GraphicsContextCairo): * platform/graphics/win/ImageCairoWin.cpp: (WebCore::BitmapImage::getHBITMAPOfSize): Source/WebKit: Use the new GraphicsContextCairo constructors. * Shared/cairo/ShareableBitmapCairo.cpp: (WebKit::ShareableBitmap::createGraphicsContext): * UIProcess/cairo/BackingStoreCairo.cpp: (WebKit::BackingStore::incorporateUpdate): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/platform/graphics/cairo/GraphicsContextCairo.cpp trunk/Source/WebCore/platform/graphics/cairo/GraphicsContextCairo.h trunk/Source/WebCore/platform/graphics/cairo/ImageBufferCairoSurfaceBackend.cpp trunk/Source/WebCore/platform/graphics/cairo/ImageBufferCairoSurfaceBackend.h trunk/Source/WebCore/platform/graphics/cairo/NativeImageCairo.cpp trunk/Source/WebCore/platform/graphics/cairo/PlatformContextCairo.cpp trunk/Source/WebCore/platform/graphics/cairo/PlatformContextCairo.h trunk/Source/WebCore/platform/graphics/nicosia/cairo/NicosiaPaintingContextCairo.cpp trunk/Source/WebCore/platform/graphics/nicosia/cairo/NicosiaPaintingContextCairo.h trunk/Source/WebCore/platform/graphics/win/GraphicsContextCairoWin.cpp trunk/Source/WebCore/platform/graphics/win/ImageCairoWin.cpp trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/Shared/cairo/ShareableBitmapCairo.cpp trunk/Source/WebKit/UIProcess/cairo/BackingStoreCairo.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (279459 => 279460) --- trunk/Source/WebCore/ChangeLog 2021-07-01 10:19:25 UTC (rev 279459) +++ trunk/Source/WebCore/ChangeLog 2021-07-01 10:35:07 UTC (rev 279460) @@ -1,3 +1,41 @@ +2021-07-01 Carlos Garcia Campos + +[Cairo] Simplify GraphicsContextCairo creation +https://bugs.webkit.org/show_bug.cgi?id=227575 + +Reviewed by Žan Doberšek. + +Remove the constructors taking a PlatformContextCairo and add two that receive a RefPtr&& and +cairo_surface_t*. In both cases the PlatformContextCairo is created, so it's now always owned and callers don't +need to create it. + +No change in behavior, covered by existing tests. + +* platform/graphics/cairo/GraphicsContextCairo.cpp: +(WebCore::GraphicsContextCairo::GraphicsContextCairo): +(WebCore::GraphicsContextCairo::drawLine): +* platform/graphics/cairo/GraphicsContextCairo.h: +* platform/graphics/cairo/ImageBufferCairoSurfaceBackend.cpp: +(WebCore::ImageBufferCairoSurfaceBackend::ImageBufferCairoSurfaceBackend): +(WebCore::ImageBufferCairoSurfaceBackend::context const): +* platform/graphics/cairo/ImageBufferCairoSurfaceBackend.h: +* platform/graphics/cairo/NativeImageCairo.cpp: +* platform/graphics/cairo/PlatformContextCairo.cpp: +(WebCore::PlatformContextCairo::PlatformContextCairo): +* platform/graphics/cairo/PlatformContextCairo.h: +(WebCore::PlatformContextCairo::cr const): +(WebCore::PlatformContextCairo::cr): Deleted. +(WebCore::PlatformContextCairo::setCr): Deleted. +* platform/graphics/nicosia/cairo/NicosiaPaintingContextCairo.cpp: +(Nicosia::PaintingContextCairo::ForPainting::ForPainting): +(Nicosia::PaintingContextCairo::ForPainting::~ForPainting): +
[webkit-changes] [279459] trunk
Title: [279459] trunk
Revision 279459
Author you...@apple.com
Date 2021-07-01 03:19:25 -0700 (Thu, 01 Jul 2021)
Log Message
RealtimeIncomingAudioSourceCocoa should support other sample rate than 48000
https://bugs.webkit.org/show_bug.cgi?id=227439
Reviewed by Eric Carlson.
Source/WebCore:
We reduced memory allocations by early allocating buffers for the most often used sample rate (48000), but this broke other sample rates, like for G722.
Make sure to update sample rate and buffers if it is not 48000.
Since the initial OnData call is often with a sample rate of 16000 and switches to 48000 after a few calls, early return for a few initial calls (20) or if sample rate is not 16000.
Covered by updated test.
* platform/mediastream/mac/RealtimeIncomingAudioSourceCocoa.cpp:
(WebCore::RealtimeIncomingAudioSourceCocoa::OnData):
* platform/mediastream/mac/RealtimeIncomingAudioSourceCocoa.h:
LayoutTests:
Improve test to validate received audio is not silence.
* webrtc/audio-peer-connection-g722-expected.txt:
* webrtc/audio-peer-connection-g722.html:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/webrtc/audio-peer-connection-g722-expected.txt
trunk/LayoutTests/webrtc/audio-peer-connection-g722.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/mediastream/mac/RealtimeIncomingAudioSourceCocoa.cpp
trunk/Source/WebCore/platform/mediastream/mac/RealtimeIncomingAudioSourceCocoa.h
Diff
Modified: trunk/LayoutTests/ChangeLog (279458 => 279459)
--- trunk/LayoutTests/ChangeLog 2021-07-01 09:10:25 UTC (rev 279458)
+++ trunk/LayoutTests/ChangeLog 2021-07-01 10:19:25 UTC (rev 279459)
@@ -1,3 +1,15 @@
+2021-07-01 Youenn Fablet
+
+RealtimeIncomingAudioSourceCocoa should support other sample rate than 48000
+https://bugs.webkit.org/show_bug.cgi?id=227439
+
+Reviewed by Eric Carlson.
+
+Improve test to validate received audio is not silence.
+
+* webrtc/audio-peer-connection-g722-expected.txt:
+* webrtc/audio-peer-connection-g722.html:
+
2021-07-01 Tim Nguyen
Unreviewed, unskip web-platform-tests/html/semantics/interactive-elements/the-dialog-element/dialog-form-submission.html
Modified: trunk/LayoutTests/webrtc/audio-peer-connection-g722-expected.txt (279458 => 279459)
--- trunk/LayoutTests/webrtc/audio-peer-connection-g722-expected.txt 2021-07-01 09:10:25 UTC (rev 279458)
+++ trunk/LayoutTests/webrtc/audio-peer-connection-g722-expected.txt 2021-07-01 10:19:25 UTC (rev 279459)
@@ -1,3 +1,5 @@
PASS Basic G722 audio playback through a peer connection
+PASS Mute remote track
+PASS Unmute remote track
Modified: trunk/LayoutTests/webrtc/audio-peer-connection-g722.html (279458 => 279459)
--- trunk/LayoutTests/webrtc/audio-peer-connection-g722.html 2021-07-01 09:10:25 UTC (rev 279458)
+++ trunk/LayoutTests/webrtc/audio-peer-connection-g722.html 2021-07-01 10:19:25 UTC (rev 279459)
@@ -2,7 +2,7 @@
-Testing local audio capture playback causes "playing" event to fire
+Testing G722 webrtc support