[webkit-changes] [281223] trunk/Source/WebCore

[ddkilzer]

Title: [281223] trunk/Source/WebCore








Revision 281223
Author ddkil...@apple.com
Date 2021-08-18 21:04:19 -0700 (Wed, 18 Aug 2021)


Log Message
Bug 229264: Leak of CMBufferQueueRef (up to 752 bytes each) in com.apple.WebKit.GPU.Development process



Reviewed by Anders Carlsson.

Covered by running layout tests with --leaks plus future patch
to check for leaks in the GPU process.

* platform/mediarecorder/cocoa/VideoSampleBufferCompressor.mm:
(WebCore::VideoSampleBufferCompressor::initialize):
- Use adoptCF() to fix the leak since CMBufferQueueCreate()
  returns a retained object.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/mediarecorder/cocoa/VideoSampleBufferCompressor.mm




Diff

Modified: trunk/Source/WebCore/ChangeLog (281222 => 281223)

--- trunk/Source/WebCore/ChangeLog	2021-08-19 03:42:16 UTC (rev 281222)
+++ trunk/Source/WebCore/ChangeLog	2021-08-19 04:04:19 UTC (rev 281223)
@@ -1,5 +1,21 @@
 2021-08-18  David Kilzer  
 
+Bug 229264: Leak of CMBufferQueueRef (up to 752 bytes each) in com.apple.WebKit.GPU.Development process
+
+
+
+Reviewed by Anders Carlsson.
+
+Covered by running layout tests with --leaks plus future patch
+to check for leaks in the GPU process.
+
+* platform/mediarecorder/cocoa/VideoSampleBufferCompressor.mm:
+(WebCore::VideoSampleBufferCompressor::initialize):
+- Use adoptCF() to fix the leak since CMBufferQueueCreate()
+  returns a retained object.
+
+2021-08-18  David Kilzer  
+
 Leak of CMSampleBufferRef (up to 2.25 KB each) in com.apple.WebKit.GPU.Development process
 
 


Modified: trunk/Source/WebCore/platform/mediarecorder/cocoa/VideoSampleBufferCompressor.mm (281222 => 281223)

--- trunk/Source/WebCore/platform/mediarecorder/cocoa/VideoSampleBufferCompressor.mm	2021-08-19 03:42:16 UTC (rev 281222)
+++ trunk/Source/WebCore/platform/mediarecorder/cocoa/VideoSampleBufferCompressor.mm	2021-08-19 04:04:19 UTC (rev 281223)
@@ -80,7 +80,7 @@
 RELEASE_LOG_ERROR(MediaStream, "VideoSampleBufferCompressor unable to create buffer queue %d", error);
 return false;
 }
-m_outputBufferQueue = outputBufferQueue;
+m_outputBufferQueue = adoptCF(outputBufferQueue);
 PAL::CMBufferQueueInstallTrigger(m_outputBufferQueue.get(), callback, callbackObject, kCMBufferQueueTrigger_WhenDataBecomesReady, PAL::kCMTimeZero, NULL);
 
 m_isEncoding = true;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [281222] trunk/Source/JavaScriptCore

[ysuzuki]

Title: [281222] trunk/Source/_javascript_Core








Revision 281222
Author ysuz...@apple.com
Date 2021-08-18 20:42:16 -0700 (Wed, 18 Aug 2021)


Log Message
[JSC] Remove op_has_indexed_property related code
https://bugs.webkit.org/show_bug.cgi?id=229271

Reviewed by Saam Barati.

After our new for-in protocol, op_has_indexed_property is removed.
As a result, we can remove many ByValInfo code that is used only
for op_has_indexed_property.

* jit/JIT.h:
* jit/JITInlines.h:
(JSC::JIT::emitLoadForArrayMode): Deleted.
* jit/JITOpcodes.cpp:
(JSC::JIT::privateCompileHasIndexedProperty): Deleted.
* jit/JITOpcodes32_64.cpp:
(JSC::JIT::privateCompileHasIndexedProperty): Deleted.
* jit/JITOperations.cpp:
* jit/JITOperations.h:
* jit/JITPropertyAccess.cpp:
(JSC::JIT::emitDoubleLoad): Deleted.
(JSC::JIT::emitContiguousLoad): Deleted.
(JSC::JIT::emitArrayStorageLoad): Deleted.

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/jit/JIT.h
trunk/Source/_javascript_Core/jit/JITInlines.h
trunk/Source/_javascript_Core/jit/JITOpcodes.cpp
trunk/Source/_javascript_Core/jit/JITOpcodes32_64.cpp
trunk/Source/_javascript_Core/jit/JITOperations.cpp
trunk/Source/_javascript_Core/jit/JITOperations.h
trunk/Source/_javascript_Core/jit/JITPropertyAccess.cpp




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (281221 => 281222)

--- trunk/Source/_javascript_Core/ChangeLog	2021-08-19 03:40:37 UTC (rev 281221)
+++ trunk/Source/_javascript_Core/ChangeLog	2021-08-19 03:42:16 UTC (rev 281222)
@@ -1,3 +1,28 @@
+2021-08-18  Yusuke Suzuki  
+
+[JSC] Remove op_has_indexed_property related code
+https://bugs.webkit.org/show_bug.cgi?id=229271
+
+Reviewed by Saam Barati.
+
+After our new for-in protocol, op_has_indexed_property is removed.
+As a result, we can remove many ByValInfo code that is used only
+for op_has_indexed_property.
+
+* jit/JIT.h:
+* jit/JITInlines.h:
+(JSC::JIT::emitLoadForArrayMode): Deleted.
+* jit/JITOpcodes.cpp:
+(JSC::JIT::privateCompileHasIndexedProperty): Deleted.
+* jit/JITOpcodes32_64.cpp:
+(JSC::JIT::privateCompileHasIndexedProperty): Deleted.
+* jit/JITOperations.cpp:
+* jit/JITOperations.h:
+* jit/JITPropertyAccess.cpp:
+(JSC::JIT::emitDoubleLoad): Deleted.
+(JSC::JIT::emitContiguousLoad): Deleted.
+(JSC::JIT::emitArrayStorageLoad): Deleted.
+
 2021-08-18  Michael Catanzaro  
 
 REGRESSION(r280382): [GTK] 2.33.3 does not build with gtk-doc enabled, installs broken pkg-config files


Modified: trunk/Source/_javascript_Core/jit/JIT.h (281221 => 281222)

--- trunk/Source/_javascript_Core/jit/JIT.h	2021-08-19 03:40:37 UTC (rev 281221)
+++ trunk/Source/_javascript_Core/jit/JIT.h	2021-08-19 03:42:16 UTC (rev 281222)
@@ -254,13 +254,6 @@
 jit.privateCompilePutPrivateNameWithCachedId(byValInfo, returnAddress, propertyName);
 }
 
-static void compileHasIndexedProperty(VM& vm, CodeBlock* codeBlock, ByValInfo* byValInfo, ReturnAddressPtr returnAddress, JITArrayMode arrayMode)
-{
-JIT jit(vm, codeBlock);
-jit.m_bytecodeIndex = byValInfo->bytecodeIndex;
-jit.privateCompileHasIndexedProperty(byValInfo, returnAddress, arrayMode);
-}
-
 static unsigned frameRegisterCountFor(CodeBlock*);
 static int stackPointerOffsetFor(CodeBlock*);
 
@@ -282,8 +275,6 @@
 
 void privateCompilePutPrivateNameWithCachedId(ByValInfo*, ReturnAddressPtr, CacheableIdentifier);
 
-void privateCompileHasIndexedProperty(ByValInfo*, ReturnAddressPtr, JITArrayMode);
-
 void privateCompilePatchGetArrayLength(ReturnAddressPtr returnAddress);
 
 // Add a call out from JIT code, without an exception check.
@@ -396,16 +387,6 @@
 
 JITArrayMode chooseArrayMode(ArrayProfile*);
 
-// Property is in regT1, base is in regT0. regT2 contains indexing type.
-// Property is int-checked and zero extended. Base is cell checked.
-// Structure is already profiled. Returns the slow cases. Fall-through
-// case contains result in regT0, and it is not yet profiled.
-JumpList emitInt32Load(const Instruction* instruction, PatchableJump& badType, ByValInfo* byValInfo) { return emitContiguousLoad(instruction, badType, byValInfo, Int32Shape); }
-JumpList emitDoubleLoad(const Instruction*, PatchableJump& badType, ByValInfo*);
-JumpList emitContiguousLoad(const Instruction*, PatchableJump& badType, ByValInfo*, IndexingType expectedShape = ContiguousShape);
-JumpList emitArrayStorageLoad(const Instruction*, PatchableJump& badType, ByValInfo*);
-JumpList emitLoadForArrayMode(const Instruction*, JITArrayMode, PatchableJump& badType, ByValInfo*);
-
 // Property is in regT1, base is in regT0. regT2 contains indecing type.
 // The value to store is not yet 

[webkit-changes] [281221] trunk

[ddkilzer]

Title: [281221] trunk








Revision 281221
Author ddkil...@apple.com
Date 2021-08-18 20:40:37 -0700 (Wed, 18 Aug 2021)


Log Message
Bug 229265: run-webkit-tests --leaks should check for leaks in the GPU process



Reviewed by Alex Christensen.

Source/WebKit:

* UIProcess/API/C/WKPage.cpp:
(WKPageGetGPUProcessIdentifier): Add.
* UIProcess/API/C/WKPagePrivate.h:
(WKPageGetGPUProcessIdentifier): Add.
- Add function to return the PID for the GPU process.

Tools:

* WebKitTestRunner/TestController.cpp:
(WTR::TestController::findAndDumpWebKitProcessIdentifiers):
- Include the GPU process PID if it's enabled when sending a
  list of PIDs back to run-webkit-tests.
(WTR::TestController::gpuProcessName): Add.
* WebKitTestRunner/TestController.h:
(WTR::TestController::databaseProcessName): Delete.
- The implementation was removed a while ago.
(WTR::TestController::gpuProcessName): Add.

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/API/C/WKPage.cpp
trunk/Source/WebKit/UIProcess/API/C/WKPagePrivate.h
trunk/Tools/ChangeLog
trunk/Tools/WebKitTestRunner/TestController.cpp
trunk/Tools/WebKitTestRunner/TestController.h




Diff

Modified: trunk/Source/WebKit/ChangeLog (281220 => 281221)

--- trunk/Source/WebKit/ChangeLog	2021-08-19 03:34:19 UTC (rev 281220)
+++ trunk/Source/WebKit/ChangeLog	2021-08-19 03:40:37 UTC (rev 281221)
@@ -1,3 +1,17 @@
+2021-08-18  David Kilzer  
+
+Bug 229265: run-webkit-tests --leaks should check for leaks in the GPU process
+
+
+
+Reviewed by Alex Christensen.
+
+* UIProcess/API/C/WKPage.cpp:
+(WKPageGetGPUProcessIdentifier): Add.
+* UIProcess/API/C/WKPagePrivate.h:
+(WKPageGetGPUProcessIdentifier): Add.
+- Add function to return the PID for the GPU process.
+
 2021-08-18  Megan Gardner  
 
 Remove unneeded UIKitSPI declarations


Modified: trunk/Source/WebKit/UIProcess/API/C/WKPage.cpp (281220 => 281221)

--- trunk/Source/WebKit/UIProcess/API/C/WKPage.cpp	2021-08-19 03:34:19 UTC (rev 281220)
+++ trunk/Source/WebKit/UIProcess/API/C/WKPage.cpp	2021-08-19 03:40:37 UTC (rev 281221)
@@ -3023,6 +3023,18 @@
 return toImpl(page)->processIdentifier();
 }
 
+ProcessID WKPageGetGPUProcessIdentifier(WKPageRef page)
+{
+#if ENABLE(GPU_PROCESS)
+auto* gpuProcess = toImpl(page)->process().processPool().gpuProcess();
+if (!gpuProcess)
+return 0;
+return gpuProcess->processIdentifier();
+#else
+return 0;
+#endif
+}
+
 #ifdef __BLOCKS__
 void WKPageGetApplicationManifest_b(WKPageRef pageRef, WKPageGetApplicationManifestBlock block)
 {


Modified: trunk/Source/WebKit/UIProcess/API/C/WKPagePrivate.h (281220 => 281221)

--- trunk/Source/WebKit/UIProcess/API/C/WKPagePrivate.h	2021-08-19 03:34:19 UTC (rev 281220)
+++ trunk/Source/WebKit/UIProcess/API/C/WKPagePrivate.h	2021-08-19 03:40:37 UTC (rev 281221)
@@ -163,6 +163,7 @@
 WK_EXPORT void WKPageSetIgnoresViewportScaleLimits(WKPageRef page, bool ignoresViewportScaleLimits);
 
 WK_EXPORT WKProcessID WKPageGetProcessIdentifier(WKPageRef page);
+WK_EXPORT WKProcessID WKPageGetGPUProcessIdentifier(WKPageRef page);
 
 #ifdef __BLOCKS__
 typedef void (^WKPageGetApplicationManifestBlock)(void);


Modified: trunk/Tools/ChangeLog (281220 => 281221)

--- trunk/Tools/ChangeLog	2021-08-19 03:34:19 UTC (rev 281220)
+++ trunk/Tools/ChangeLog	2021-08-19 03:40:37 UTC (rev 281221)
@@ -1,3 +1,21 @@
+2021-08-18  David Kilzer  
+
+Bug 229265: run-webkit-tests --leaks should check for leaks in the GPU process
+
+
+
+Reviewed by Alex Christensen.
+
+* WebKitTestRunner/TestController.cpp:
+(WTR::TestController::findAndDumpWebKitProcessIdentifiers):
+- Include the GPU process PID if it's enabled when sending a
+  list of PIDs back to run-webkit-tests.
+(WTR::TestController::gpuProcessName): Add.
+* WebKitTestRunner/TestController.h:
+(WTR::TestController::databaseProcessName): Delete.
+- The implementation was removed a while ago.
+(WTR::TestController::gpuProcessName): Add.
+
 2021-08-18  Jonathan Bedard  
 
 [run-webkit-tests] Remember failures when repeating test


Modified: trunk/Tools/WebKitTestRunner/TestController.cpp (281220 => 281221)

--- trunk/Tools/WebKitTestRunner/TestController.cpp	2021-08-19 03:34:19 UTC (rev 281220)
+++ trunk/Tools/WebKitTestRunner/TestController.cpp	2021-08-19 03:40:37 UTC (rev 281221)
@@ -1126,10 +1126,17 @@
 void TestController::findAndDumpWebKitProcessIdentifiers()
 {
 #if PLATFORM(COCOA)
-dumpResponse(makeString(TestController::webProcessName(), ": ",
-WKPageGetProcessIdentifier(TestController::singleton().mainWebView()->page()), '\n',
-TestController::networkProcessName(), ": ",
-WKWebsiteDataStoreGetNetworkProcessIdentifier(websiteDataStore()), '\n'));
+auto page = TestController::singleton().mainWebView()->page();
+dumpResponse(makeString(
+

[webkit-changes] [281220] trunk/Source/WebCore

[ddkilzer]

Title: [281220] trunk/Source/WebCore








Revision 281220
Author ddkil...@apple.com
Date 2021-08-18 20:34:19 -0700 (Wed, 18 Aug 2021)


Log Message
Leak of CMSampleBufferRef (up to 2.25 KB each) in com.apple.WebKit.GPU.Development process



Reviewed by Darin Adler.

Covered by running layout tests with --leaks plus future patch
to check for leaks in the GPU process.

* platform/mediarecorder/cocoa/AudioSampleBufferCompressor.h:
(WebCore::AudioSampleBufferCompressor::sampleBufferWithNumPackets):
- Update signature to return RetainPtr.

* platform/mediarecorder/cocoa/AudioSampleBufferCompressor.mm:
(WebCore::AudioSampleBufferCompressor::sampleBufferWithNumPackets):
- Update signature to return RetainPtr.
- Rename `sampleBuffer` to `rawSampleBuffer` to match similar
  pattern used in other code, then use `sampleBuffer` to store
  `rawSampleBuffer` wrapped in a RetainPtr<>.
(WebCore::AudioSampleBufferCompressor::processSampleBuffersUntilLowWaterTime):
- Add get() to `buffer` variable since it is now a RetainPtr<>.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/mediarecorder/cocoa/AudioSampleBufferCompressor.h
trunk/Source/WebCore/platform/mediarecorder/cocoa/AudioSampleBufferCompressor.mm




Diff

Modified: trunk/Source/WebCore/ChangeLog (281219 => 281220)

--- trunk/Source/WebCore/ChangeLog	2021-08-19 01:15:03 UTC (rev 281219)
+++ trunk/Source/WebCore/ChangeLog	2021-08-19 03:34:19 UTC (rev 281220)
@@ -1,3 +1,27 @@
+2021-08-18  David Kilzer  
+
+Leak of CMSampleBufferRef (up to 2.25 KB each) in com.apple.WebKit.GPU.Development process
+
+
+
+Reviewed by Darin Adler.
+
+Covered by running layout tests with --leaks plus future patch
+to check for leaks in the GPU process.
+
+* platform/mediarecorder/cocoa/AudioSampleBufferCompressor.h:
+(WebCore::AudioSampleBufferCompressor::sampleBufferWithNumPackets):
+- Update signature to return RetainPtr.
+
+* platform/mediarecorder/cocoa/AudioSampleBufferCompressor.mm:
+(WebCore::AudioSampleBufferCompressor::sampleBufferWithNumPackets):
+- Update signature to return RetainPtr.
+- Rename `sampleBuffer` to `rawSampleBuffer` to match similar
+  pattern used in other code, then use `sampleBuffer` to store
+  `rawSampleBuffer` wrapped in a RetainPtr<>.
+(WebCore::AudioSampleBufferCompressor::processSampleBuffersUntilLowWaterTime):
+- Add get() to `buffer` variable since it is now a RetainPtr<>.
+
 2021-08-18  Chris Dumez  
 
 Unreviewed, reverting r281206.


Modified: trunk/Source/WebCore/platform/mediarecorder/cocoa/AudioSampleBufferCompressor.h (281219 => 281220)

--- trunk/Source/WebCore/platform/mediarecorder/cocoa/AudioSampleBufferCompressor.h	2021-08-19 01:15:03 UTC (rev 281219)
+++ trunk/Source/WebCore/platform/mediarecorder/cocoa/AudioSampleBufferCompressor.h	2021-08-19 03:34:19 UTC (rev 281220)
@@ -60,7 +60,7 @@
 size_t computeBufferSizeForAudioFormat(AudioStreamBasicDescription, UInt32, Float32);
 void attachPrimingTrimsIfNeeded(CMSampleBufferRef);
 RetainPtr gradualDecoderRefreshCount();
-CMSampleBufferRef sampleBufferWithNumPackets(UInt32 numPackets, AudioBufferList);
+RetainPtr sampleBufferWithNumPackets(UInt32 numPackets, AudioBufferList);
 void processSampleBuffersUntilLowWaterTime(CMTime);
 OSStatus provideSourceDataNumOutputPackets(UInt32*, AudioBufferList*, AudioStreamPacketDescription**);
 


Modified: trunk/Source/WebCore/platform/mediarecorder/cocoa/AudioSampleBufferCompressor.mm (281219 => 281220)

--- trunk/Source/WebCore/platform/mediarecorder/cocoa/AudioSampleBufferCompressor.mm	2021-08-19 01:15:03 UTC (rev 281219)
+++ trunk/Source/WebCore/platform/mediarecorder/cocoa/AudioSampleBufferCompressor.mm	2021-08-19 03:34:19 UTC (rev 281220)
@@ -262,7 +262,7 @@
 return retainPtr([NSNumber numberWithInt:(primeInfo.leadingFrames / m_destinationFormat.mFramesPerPacket)]);
 }
 
-CMSampleBufferRef AudioSampleBufferCompressor::sampleBufferWithNumPackets(UInt32 numPackets, AudioBufferList fillBufferList)
+RetainPtr AudioSampleBufferCompressor::sampleBufferWithNumPackets(UInt32 numPackets, AudioBufferList fillBufferList)
 {
 Vector cookie;
 if (!m_destinationFormatDescription) {
@@ -302,15 +302,17 @@
 return nil;
 }
 
-CMSampleBufferRef sampleBuffer;
-auto error = PAL::CMAudioSampleBufferCreateWithPacketDescriptions(kCFAllocatorDefault, buffer.get(), true, NULL, NULL, m_destinationFormatDescription.get(), numPackets, m_currentNativePresentationTimeStamp, m_destinationPacketDescriptions.data(), );
+CMSampleBufferRef rawSampleBuffer;
+auto error = PAL::CMAudioSampleBufferCreateWithPacketDescriptions(kCFAllocatorDefault, buffer.get(), true, NULL, NULL, m_destinationFormatDescription.get(), numPackets, m_currentNativePresentationTimeStamp, m_destinationPacketDescriptions.data(), );
 if (error) {
 

[webkit-changes] [281219] trunk/LayoutTests

[clopez]

Title: [281219] trunk/LayoutTests








Revision 281219
Author clo...@igalia.com
Date 2021-08-18 18:15:03 -0700 (Wed, 18 Aug 2021)


Log Message
[GTK][WPE] Gardening of layout tests

Unreviewed test gardening.

Mark expected failures after r281108 and others and update list of flaky tests.
Rebaseline tests after r281136, r281127 and r281097.

* platform/glib/TestExpectations:
* platform/glib/imported/w3c/web-platform-tests/html/semantics/scripting-1/the-script-element/module/integrity-expected.txt: Added.
* platform/gtk/TestExpectations:
* platform/gtk/fast/repaint/line-layout-block-shrink-expected.txt: Added.
* platform/gtk/imported/w3c/web-platform-tests/css/css-typed-om/rotate-by-added-angle-expected.txt: Added.
* platform/gtk/imported/w3c/web-platform-tests/css/css-typed-om/width-by-max-px-em-expected.txt: Added.
* platform/gtk/imported/w3c/web-platform-tests/css/css-typed-om/width-by-min-px-em-expected.txt: Added.
* platform/wpe/imported/w3c/web-platform-tests/css/css-typed-om/rotate-by-added-angle-expected.txt: Added.
* platform/wpe/imported/w3c/web-platform-tests/css/css-typed-om/width-by-max-px-em-expected.txt: Added.
* platform/wpe/imported/w3c/web-platform-tests/css/css-typed-om/width-by-min-px-em-expected.txt: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/glib/TestExpectations
trunk/LayoutTests/platform/gtk/TestExpectations


Added Paths

trunk/LayoutTests/platform/glib/imported/w3c/web-platform-tests/html/semantics/scripting-1/the-script-element/module/
trunk/LayoutTests/platform/glib/imported/w3c/web-platform-tests/html/semantics/scripting-1/the-script-element/module/integrity-expected.txt
trunk/LayoutTests/platform/gtk/fast/repaint/line-layout-block-shrink-expected.txt
trunk/LayoutTests/platform/gtk/imported/w3c/web-platform-tests/css/css-typed-om/
trunk/LayoutTests/platform/gtk/imported/w3c/web-platform-tests/css/css-typed-om/rotate-by-added-angle-expected.txt
trunk/LayoutTests/platform/gtk/imported/w3c/web-platform-tests/css/css-typed-om/width-by-max-px-em-expected.txt
trunk/LayoutTests/platform/gtk/imported/w3c/web-platform-tests/css/css-typed-om/width-by-min-px-em-expected.txt
trunk/LayoutTests/platform/wpe/imported/w3c/web-platform-tests/css/css-typed-om/
trunk/LayoutTests/platform/wpe/imported/w3c/web-platform-tests/css/css-typed-om/rotate-by-added-angle-expected.txt
trunk/LayoutTests/platform/wpe/imported/w3c/web-platform-tests/css/css-typed-om/width-by-max-px-em-expected.txt
trunk/LayoutTests/platform/wpe/imported/w3c/web-platform-tests/css/css-typed-om/width-by-min-px-em-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (281218 => 281219)

--- trunk/LayoutTests/ChangeLog	2021-08-19 00:34:51 UTC (rev 281218)
+++ trunk/LayoutTests/ChangeLog	2021-08-19 01:15:03 UTC (rev 281219)
@@ -1,3 +1,23 @@
+2021-08-18  Carlos Alberto Lopez Perez  
+
+[GTK][WPE] Gardening of layout tests
+
+Unreviewed test gardening.
+
+Mark expected failures after r281108 and others and update list of flaky tests.
+Rebaseline tests after r281136, r281127 and r281097.
+
+* platform/glib/TestExpectations:
+* platform/glib/imported/w3c/web-platform-tests/html/semantics/scripting-1/the-script-element/module/integrity-expected.txt: Added.
+* platform/gtk/TestExpectations:
+* platform/gtk/fast/repaint/line-layout-block-shrink-expected.txt: Added.
+* platform/gtk/imported/w3c/web-platform-tests/css/css-typed-om/rotate-by-added-angle-expected.txt: Added.
+* platform/gtk/imported/w3c/web-platform-tests/css/css-typed-om/width-by-max-px-em-expected.txt: Added.
+* platform/gtk/imported/w3c/web-platform-tests/css/css-typed-om/width-by-min-px-em-expected.txt: Added.
+* platform/wpe/imported/w3c/web-platform-tests/css/css-typed-om/rotate-by-added-angle-expected.txt: Added.
+* platform/wpe/imported/w3c/web-platform-tests/css/css-typed-om/width-by-max-px-em-expected.txt: Added.
+* platform/wpe/imported/w3c/web-platform-tests/css/css-typed-om/width-by-min-px-em-expected.txt: Added.
+
 2021-08-18  Fujii Hironori  
 
 [Fetch API][WebKit1] http/tests/fetch/keepalive-fetch-2.html is randomly failing


Modified: trunk/LayoutTests/platform/glib/TestExpectations (281218 => 281219)

--- trunk/LayoutTests/platform/glib/TestExpectations	2021-08-19 00:34:51 UTC (rev 281218)
+++ trunk/LayoutTests/platform/glib/TestExpectations	2021-08-19 01:15:03 UTC (rev 281219)
@@ -352,6 +352,8 @@
 # Not supported. Skipped also in mac-wk1 and win ports.
 accessibility/nested-textareas-value-changed-notifications.html [ Skip ]
 
+webkit.org/b/229261 accessibility/element-line-rects-and-text.html [ Missing ]
+
 #
 # End of Accessibility-related bugs
 #
@@ -2352,6 +2354,10 @@
 # Test is a flaky timeout. The test is also 

[webkit-changes] [281218] trunk/LayoutTests

[Hironori . Fujii]

Title: [281218] trunk/LayoutTests








Revision 281218
Author hironori.fu...@sony.com
Date 2021-08-18 17:34:51 -0700 (Wed, 18 Aug 2021)


Log Message
[Fetch API][WebKit1] http/tests/fetch/keepalive-fetch-2.html is randomly failing
https://bugs.webkit.org/show_bug.cgi?id=229247

Unreviewed test gardening.

WebKit1 doesn't properly support keepalive fetch. Marked it as
flaky. Increased the number of fetches for testing WebKit2 more.

* http/tests/fetch/keepalive-fetch-2.html:
* http/tests/fetch/resources/keepalive-fetch-2-window.html:
* platform/ios-wk1/TestExpectations:
* platform/mac-wk1/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/http/tests/fetch/keepalive-fetch-2.html
trunk/LayoutTests/http/tests/fetch/resources/keepalive-fetch-2-window.html
trunk/LayoutTests/platform/ios-wk1/TestExpectations
trunk/LayoutTests/platform/mac-wk1/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (281217 => 281218)

--- trunk/LayoutTests/ChangeLog	2021-08-19 00:20:53 UTC (rev 281217)
+++ trunk/LayoutTests/ChangeLog	2021-08-19 00:34:51 UTC (rev 281218)
@@ -1,3 +1,18 @@
+2021-08-18  Fujii Hironori  
+
+[Fetch API][WebKit1] http/tests/fetch/keepalive-fetch-2.html is randomly failing
+https://bugs.webkit.org/show_bug.cgi?id=229247
+
+Unreviewed test gardening.
+
+WebKit1 doesn't properly support keepalive fetch. Marked it as
+flaky. Increased the number of fetches for testing WebKit2 more.
+
+* http/tests/fetch/keepalive-fetch-2.html:
+* http/tests/fetch/resources/keepalive-fetch-2-window.html:
+* platform/ios-wk1/TestExpectations:
+* platform/mac-wk1/TestExpectations:
+
 2021-08-18  Eric Hutchison  
 
 [Mac wk1 Debug] imported/w3c/web-platform-tests/IndexedDB/idbcursor-advance-continue-async.htm is a flaky timeout.


Modified: trunk/LayoutTests/http/tests/fetch/keepalive-fetch-2.html (281217 => 281218)

--- trunk/LayoutTests/http/tests/fetch/keepalive-fetch-2.html	2021-08-19 00:20:53 UTC (rev 281217)
+++ trunk/LayoutTests/http/tests/fetch/keepalive-fetch-2.html	2021-08-19 00:34:51 UTC (rev 281218)
@@ -6,7 +6,7 @@
 promise_test(async () => {
 // Clear
 let id = Math.random().toString();
-let suffixes = Array.from(Array(5).keys());
+let suffixes = Array.from(Array(10).keys());
 await Promise.all(suffixes.map((i) => {
 let filename = `keepalive-fetch-2.${id}.${i}.txt`;
 return fetch('resources/get-set-temp-file.py?cmd=clear=' + filename);


Modified: trunk/LayoutTests/http/tests/fetch/resources/keepalive-fetch-2-window.html (281217 => 281218)

--- trunk/LayoutTests/http/tests/fetch/resources/keepalive-fetch-2-window.html	2021-08-19 00:20:53 UTC (rev 281217)
+++ trunk/LayoutTests/http/tests/fetch/resources/keepalive-fetch-2-window.html	2021-08-19 00:34:51 UTC (rev 281218)
@@ -1,9 +1,9 @@
 
 
 var id = location.hash.substring(1);
-let suffixes = Array.from(Array(5).keys());
+let suffixes = Array.from(Array(10).keys());
 suffixes.map((i) => {
 let filename = `keepalive-fetch-2.${id}.${i}.txt`;
-fetch(`get-set-temp-file.py?cmd=set&delay=1000&filename=${filename}&data="" { keepalive: true });
+fetch(`get-set-temp-file.py?cmd=set&delay=500&filename=${filename}&data="" { keepalive: true });
 });
 


Modified: trunk/LayoutTests/platform/ios-wk1/TestExpectations (281217 => 281218)

--- trunk/LayoutTests/platform/ios-wk1/TestExpectations	2021-08-19 00:20:53 UTC (rev 281217)
+++ trunk/LayoutTests/platform/ios-wk1/TestExpectations	2021-08-19 00:34:51 UTC (rev 281218)
@@ -1953,3 +1953,5 @@
 imported/w3c/web-platform-tests/fetch/stale-while-revalidate [ Skip ]
 
 webkit.org/b/223193 imported/w3c/web-platform-tests/html/canvas/element/path-objects/2d.path.stroke.scale2.html [ Failure ]
+
+webkit.org/b/229247 http/tests/fetch/keepalive-fetch-2.html [ Pass Failure ]


Modified: trunk/LayoutTests/platform/mac-wk1/TestExpectations (281217 => 281218)

--- trunk/LayoutTests/platform/mac-wk1/TestExpectations	2021-08-19 00:20:53 UTC (rev 281217)
+++ trunk/LayoutTests/platform/mac-wk1/TestExpectations	2021-08-19 00:34:51 UTC (rev 281218)
@@ -1391,3 +1391,5 @@
 
 # webkit.org/b/228200 Adjusting test expectations for Monterey on Open Source :
 [ Monterey ] webrtc/h264-high.html [ Failure ]
+
+webkit.org/b/229247 http/tests/fetch/keepalive-fetch-2.html [ Pass Failure ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [281217] trunk/Source/WTF

[rniwa]

Title: [281217] trunk/Source/WTF








Revision 281217
Author rn...@webkit.org
Date 2021-08-18 17:20:53 -0700 (Wed, 18 Aug 2021)


Log Message
[ iOS Debug ] 12 TestWebKitAPI.WebKitLegacy. tests are crashing
https://bugs.webkit.org/show_bug.cgi?id=229250

Reviewed by Wenson Hsieh.

Disable the assertion when Web Thread is enabled for now.

* wtf/CheckedRef.h:
(WTF::SingleThreadIntegralWrapper::assertThread const):

Modified Paths

trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/CheckedRef.h




Diff

Modified: trunk/Source/WTF/ChangeLog (281216 => 281217)

--- trunk/Source/WTF/ChangeLog	2021-08-19 00:20:00 UTC (rev 281216)
+++ trunk/Source/WTF/ChangeLog	2021-08-19 00:20:53 UTC (rev 281217)
@@ -1,3 +1,15 @@
+2021-08-18  Ryosuke Niwa  
+
+[ iOS Debug ] 12 TestWebKitAPI.WebKitLegacy. tests are crashing
+https://bugs.webkit.org/show_bug.cgi?id=229250
+
+Reviewed by Wenson Hsieh.
+
+Disable the assertion when Web Thread is enabled for now.
+
+* wtf/CheckedRef.h:
+(WTF::SingleThreadIntegralWrapper::assertThread const):
+
 2021-08-18  Megan Gardner  
 
 Remove unneeded UIKitSPI declarations


Modified: trunk/Source/WTF/wtf/CheckedRef.h (281216 => 281217)

--- trunk/Source/WTF/wtf/CheckedRef.h	2021-08-19 00:20:00 UTC (rev 281216)
+++ trunk/Source/WTF/wtf/CheckedRef.h	2021-08-19 00:20:53 UTC (rev 281217)
@@ -248,10 +248,14 @@
 SingleThreadIntegralWrapper& operator--();
 
 private:
+#if ASSERT_ENABLED && !USE(WEB_THREAD)
 void assertThread() const { ASSERT(m_thread.ptr() == ::current()); }
+#else
+constexpr void assertThread() const { }
+#endif
 
 IntegralType m_value;
-#if ASSERT_ENABLED
+#if ASSERT_ENABLED && !USE(WEB_THREAD)
 Ref m_thread;
 #endif
 };
@@ -259,7 +263,7 @@
 template 
 inline SingleThreadIntegralWrapper::SingleThreadIntegralWrapper(IntegralType value)
 : m_value { value }
-#if ASSERT_ENABLED
+#if ASSERT_ENABLED && !USE(WEB_THREAD)
 , m_thread { Thread::current() }
 #endif
 { }






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [281216] trunk/Tools

[jbedard]

Title: [281216] trunk/Tools








Revision 281216
Author jbed...@apple.com
Date 2021-08-18 17:20:00 -0700 (Wed, 18 Aug 2021)


Log Message
[run-webkit-tests] Remember failures when repeating test
https://bugs.webkit.org/show_bug.cgi?id=229217


Reviewed by Ryan Haddad.

* Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
(LayoutTestRunner.update_summary_with_result): Replace existing result with unexpected result so
that unexpected results always take precedence over expected ones.
* Scripts/webkitpy/layout_tests/models/test_run_results.py:
(TestRunResults.add): Do not replace existing result.

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py
trunk/Tools/Scripts/webkitpy/layout_tests/models/test_run_results.py




Diff

Modified: trunk/Tools/ChangeLog (281215 => 281216)

--- trunk/Tools/ChangeLog	2021-08-18 23:14:15 UTC (rev 281215)
+++ trunk/Tools/ChangeLog	2021-08-19 00:20:00 UTC (rev 281216)
@@ -1,3 +1,17 @@
+2021-08-18  Jonathan Bedard  
+
+[run-webkit-tests] Remember failures when repeating test
+https://bugs.webkit.org/show_bug.cgi?id=229217
+
+
+Reviewed by Ryan Haddad.
+
+* Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
+(LayoutTestRunner.update_summary_with_result): Replace existing result with unexpected result so
+that unexpected results always take precedence over expected ones.
+* Scripts/webkitpy/layout_tests/models/test_run_results.py:
+(TestRunResults.add): Do not replace existing result.
+
 2021-08-18  Lauro Moura  
 
 REGRESSION(r279169) [WebDriver] WPT Tools now requires python3 to launch the server


Modified: trunk/Tools/Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py (281215 => 281216)

--- trunk/Tools/Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py	2021-08-18 23:14:15 UTC (rev 281215)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py	2021-08-19 00:20:00 UTC (rev 281216)
@@ -227,6 +227,7 @@
 if result.type == test_expectations.SKIP:
 exp_str = got_str = 'SKIP'
 expected = True
+expectations = None
 else:
 expectations = self._expectations.filtered_expectations_for_test(result.test_name, self._options.pixel_tests or bool(result.reftest_type), self._options.world_leaks)
 expected = self._expectations.matches_an_expected_result(result.test_name, result.type, expectations)
@@ -233,7 +234,11 @@
 exp_str = self._expectations.model().expectations_to_string(expectations)
 got_str = self._expectations.model().expectation_to_string(result.type)
 
+existing = self._current_run_results.results_by_name.get(result.test_name)
 self._current_run_results.add(result, expected)
+if existing and not expected:
+existing_expectation = self._expectations.matches_an_expected_result(result.test_name, existing.type, expectations)
+self._current_run_results.change_result_to_failure(existing, result, existing_expectation, expected)
 
 self.printer.print_finished_test(result, expected, exp_str, got_str)
 


Modified: trunk/Tools/Scripts/webkitpy/layout_tests/models/test_run_results.py (281215 => 281216)

--- trunk/Tools/Scripts/webkitpy/layout_tests/models/test_run_results.py	2021-08-18 23:14:15 UTC (rev 281215)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/models/test_run_results.py	2021-08-19 00:20:00 UTC (rev 281216)
@@ -69,7 +69,7 @@
 
 def add(self, test_result, expected):
 self.tests_by_expectation[test_result.type].add(test_result.test_name)
-self.results_by_name[test_result.test_name] = test_result
+self.results_by_name[test_result.test_name] = self.results_by_name.get(test_result.test_name, test_result)
 if test_result.is_other_crash:
 return
 if test_result.type != test_expectations.SKIP:






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [281215] trunk

[cdumez]

Title: [281215] trunk








Revision 281215
Author cdu...@apple.com
Date 2021-08-18 16:14:15 -0700 (Wed, 18 Aug 2021)


Log Message
Unreviewed, reverting r281206.

Reverting because of branching, will re-land soon

Reverted changeset:

"Implement Crypto.randomUUID()"
https://bugs.webkit.org/show_bug.cgi?id=229240
https://commits.webkit.org/r281206

Modified Paths

trunk/LayoutTests/imported/w3c/ChangeLog
trunk/LayoutTests/imported/w3c/web-platform-tests/WebCryptoAPI/randomUUID.https.any-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/WebCryptoAPI/randomUUID.https.any.worker-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/Crypto.cpp
trunk/Source/WebCore/page/Crypto.h
trunk/Source/WebCore/page/Crypto.idl




Diff

Modified: trunk/LayoutTests/imported/w3c/ChangeLog (281214 => 281215)

--- trunk/LayoutTests/imported/w3c/ChangeLog	2021-08-18 22:04:16 UTC (rev 281214)
+++ trunk/LayoutTests/imported/w3c/ChangeLog	2021-08-18 23:14:15 UTC (rev 281215)
@@ -1,5 +1,17 @@
 2021-08-18  Chris Dumez  
 
+Unreviewed, reverting r281206.
+
+Reverting because of branching, will re-land soon
+
+Reverted changeset:
+
+"Implement Crypto.randomUUID()"
+https://bugs.webkit.org/show_bug.cgi?id=229240
+https://commits.webkit.org/r281206
+
+2021-08-18  Chris Dumez  
+
 Implement Crypto.randomUUID()
 https://bugs.webkit.org/show_bug.cgi?id=229240
 


Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/WebCryptoAPI/randomUUID.https.any-expected.txt (281214 => 281215)

--- trunk/LayoutTests/imported/w3c/web-platform-tests/WebCryptoAPI/randomUUID.https.any-expected.txt	2021-08-18 22:04:16 UTC (rev 281214)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/WebCryptoAPI/randomUUID.https.any-expected.txt	2021-08-18 23:14:15 UTC (rev 281215)
@@ -1,5 +1,5 @@
 
-PASS namespace format
-PASS version set
-PASS variant set
+FAIL namespace format self.crypto.randomUUID is not a function. (In 'self.crypto.randomUUID()', 'self.crypto.randomUUID' is undefined)
+FAIL version set self.crypto.randomUUID is not a function. (In 'self.crypto.randomUUID()', 'self.crypto.randomUUID' is undefined)
+FAIL variant set self.crypto.randomUUID is not a function. (In 'self.crypto.randomUUID()', 'self.crypto.randomUUID' is undefined)
 


Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/WebCryptoAPI/randomUUID.https.any.worker-expected.txt (281214 => 281215)

--- trunk/LayoutTests/imported/w3c/web-platform-tests/WebCryptoAPI/randomUUID.https.any.worker-expected.txt	2021-08-18 22:04:16 UTC (rev 281214)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/WebCryptoAPI/randomUUID.https.any.worker-expected.txt	2021-08-18 23:14:15 UTC (rev 281215)
@@ -1,5 +1,5 @@
 
-PASS namespace format
-PASS version set
-PASS variant set
+FAIL namespace format self.crypto.randomUUID is not a function. (In 'self.crypto.randomUUID()', 'self.crypto.randomUUID' is undefined)
+FAIL version set self.crypto.randomUUID is not a function. (In 'self.crypto.randomUUID()', 'self.crypto.randomUUID' is undefined)
+FAIL variant set self.crypto.randomUUID is not a function. (In 'self.crypto.randomUUID()', 'self.crypto.randomUUID' is undefined)
 


Modified: trunk/Source/WebCore/ChangeLog (281214 => 281215)

--- trunk/Source/WebCore/ChangeLog	2021-08-18 22:04:16 UTC (rev 281214)
+++ trunk/Source/WebCore/ChangeLog	2021-08-18 23:14:15 UTC (rev 281215)
@@ -1,5 +1,17 @@
 2021-08-18  Chris Dumez  
 
+Unreviewed, reverting r281206.
+
+Reverting because of branching, will re-land soon
+
+Reverted changeset:
+
+"Implement Crypto.randomUUID()"
+https://bugs.webkit.org/show_bug.cgi?id=229240
+https://commits.webkit.org/r281206
+
+2021-08-18  Chris Dumez  
+
 Implement Crypto.randomUUID()
 https://bugs.webkit.org/show_bug.cgi?id=229240
 


Modified: trunk/Source/WebCore/page/Crypto.cpp (281214 => 281215)

--- trunk/Source/WebCore/page/Crypto.cpp	2021-08-18 22:04:16 UTC (rev 281214)
+++ trunk/Source/WebCore/page/Crypto.cpp	2021-08-18 23:14:15 UTC (rev 281215)
@@ -35,7 +35,6 @@
 #include "SubtleCrypto.h"
 #include <_javascript_Core/ArrayBufferView.h>
 #include 
-#include 
 
 #if OS(DARWIN)
 #include 
@@ -69,11 +68,6 @@
 return { };
 }
 
-String Crypto::randomUUID() const
-{
-return createCanonicalUUIDString();
-}
-
 #if ENABLE(WEB_CRYPTO)
 
 SubtleCrypto& Crypto::subtle()


Modified: trunk/Source/WebCore/page/Crypto.h (281214 => 281215)

--- trunk/Source/WebCore/page/Crypto.h	2021-08-18 22:04:16 UTC (rev 281214)
+++ trunk/Source/WebCore/page/Crypto.h	2021-08-18 23:14:15 UTC (rev 281215)
@@ -46,7 +46,6 @@
 virtual ~Crypto();
 
 ExceptionOr getRandomValues(JSC::ArrayBufferView&);
-String randomUUID() const;
 
 #if ENABLE(WEB_CRYPTO)
 SubtleCrypto& subtle();


Modified: trunk/Source/WebCore/page/Crypto.idl (281214 => 281215)

--- trunk/Source/WebCore/page/Crypto.idl	2021-08-18 22:04:16 UTC (rev 281214)
+++ 

[webkit-changes] [281214] branches/safari-612.1.27.0-branch

[repstein]

Title: [281214] branches/safari-612.1.27.0-branch








Revision 281214
Author repst...@apple.com
Date 2021-08-18 15:04:16 -0700 (Wed, 18 Aug 2021)


Log Message
Revert "Cherry-pick r280463. rdar://problem/82088775"

This reverts commit r281207.

Modified Paths

branches/safari-612.1.27.0-branch/JSTests/ChangeLog
branches/safari-612.1.27.0-branch/JSTests/stress/reflect-set-custom-value.js
branches/safari-612.1.27.0-branch/Source/_javascript_Core/ChangeLog
branches/safari-612.1.27.0-branch/Source/_javascript_Core/runtime/JSObject.cpp




Diff

Modified: branches/safari-612.1.27.0-branch/JSTests/ChangeLog (281213 => 281214)

--- branches/safari-612.1.27.0-branch/JSTests/ChangeLog	2021-08-18 22:04:13 UTC (rev 281213)
+++ branches/safari-612.1.27.0-branch/JSTests/ChangeLog	2021-08-18 22:04:16 UTC (rev 281214)
@@ -1,47 +1,3 @@
-2021-08-18  Russell Epstein  
-
-Cherry-pick r280463. rdar://problem/82088775
-
-definePropertyOnReceiver should check if receiver canPerformFastPutInline
-https://bugs.webkit.org/show_bug.cgi?id=227963
-
-
-Reviewed by Alexey Shvayka.
-
-JSTests:
-
-* stress/reflect-set-custom-value.js: Added.
-
-Source/_javascript_Core:
-
-definePropertyOnReceiver has a fast path if the slot is not opaque and the receiver doesn't
-have a custom defineOwnProperty implementation, in which case it calls putInlineFast (and
-transitively putDirectInternal). The issue is that putDirectInternal does not
-handle customValues correctly: it just overwrites the property without changing the attributes.
-To fix that, we should first check if the property might be a custom value, and if that's the case
-we now call `definePropertyOnReceiverSlow`, which has been updated to handle custom values correctly.
-I also added assertions to putInlineFastReplacingStaticPropertyIfNeeded and putDirectInternal
-to make sure we don't accidentally overwrite custom values in the future.
-
-* runtime/JSObject.cpp:
-(JSC::definePropertyOnReceiverSlow):
-(JSC::JSObject::definePropertyOnReceiver):
-(JSC::JSObject::putInlineFastReplacingStaticPropertyIfNeeded):
-* runtime/JSObjectInlines.h:
-(JSC::JSObject::putDirectInternal):
-
-git-svn-id: https://svn.webkit.org/repository/webkit/trunk@280463 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
-2021-07-29  Tadeu Zagallo  
-
-definePropertyOnReceiver should check if receiver canPerformFastPutInline
-https://bugs.webkit.org/show_bug.cgi?id=227963
-
-
-Reviewed by Alexey Shvayka.
-
-* stress/reflect-set-custom-value.js: Added.
-
 2021-08-02  Yusuke Suzuki  
 
 [JSC] Yarr BoyerMoore search should support character-class


Modified: branches/safari-612.1.27.0-branch/JSTests/stress/reflect-set-custom-value.js (281213 => 281214)

--- branches/safari-612.1.27.0-branch/JSTests/stress/reflect-set-custom-value.js	2021-08-18 22:04:13 UTC (rev 281213)
+++ branches/safari-612.1.27.0-branch/JSTests/stress/reflect-set-custom-value.js	2021-08-18 22:04:16 UTC (rev 281214)
@@ -1,3 +1,14 @@
-const testGetterSetter = $vm.createCustomTestGetterSetter();
-Reflect.set({}, 'customValue', 'foo', testGetterSetter);
-testGetterSetter.customValue = 42;
+{
+// reified
+const testGetterSetter = $vm.createCustomTestGetterSetter();
+Reflect.set({}, 'customValue', 'foo', testGetterSetter);
+testGetterSetter.customValue = 42;
+}
+
+{
+// non-reified
+let tester = $vm.createStaticCustomValue();
+Reflect.set({}, "testStaticValueSetFlag", 'foo', tester);
+if (!tester.testStaticValueSetterCalled)
+throw new Error('Custom value overriden');
+}


Modified: branches/safari-612.1.27.0-branch/Source/_javascript_Core/ChangeLog (281213 => 281214)

--- branches/safari-612.1.27.0-branch/Source/_javascript_Core/ChangeLog	2021-08-18 22:04:13 UTC (rev 281213)
+++ branches/safari-612.1.27.0-branch/Source/_javascript_Core/ChangeLog	2021-08-18 22:04:16 UTC (rev 281214)
@@ -1,63 +1,5 @@
 2021-08-18  Russell Epstein  
 
-Cherry-pick r280463. rdar://problem/82088775
-
-definePropertyOnReceiver should check if receiver canPerformFastPutInline
-https://bugs.webkit.org/show_bug.cgi?id=227963
-
-
-Reviewed by Alexey Shvayka.
-
-JSTests:
-
-* stress/reflect-set-custom-value.js: Added.
-
-Source/_javascript_Core:
-
-definePropertyOnReceiver has a fast path if the slot is not opaque and the receiver doesn't
-have a custom defineOwnProperty implementation, in which case it calls putInlineFast (and
-transitively putDirectInternal). The issue is that putDirectInternal does not
-handle customValues correctly: it just overwrites the property without changing the attributes.
-To fix that, we should first check if the property might be a custom value, and if that's the case
-we now call `definePropertyOnReceiverSlow`, which has been updated to handle 

[webkit-changes] [281213] branches/safari-612.1.27.0-branch

[repstein]

Title: [281213] branches/safari-612.1.27.0-branch








Revision 281213
Author repst...@apple.com
Date 2021-08-18 15:04:13 -0700 (Wed, 18 Aug 2021)


Log Message
Revert "Cherry-pick r280505. rdar://problem/82088775"

This reverts commit r281208.

Modified Paths

branches/safari-612.1.27.0-branch/JSTests/ChangeLog
branches/safari-612.1.27.0-branch/JSTests/stress/reflect-set-custom-value.js
branches/safari-612.1.27.0-branch/Source/_javascript_Core/ChangeLog
branches/safari-612.1.27.0-branch/Source/_javascript_Core/runtime/JSObject.cpp




Diff

Modified: branches/safari-612.1.27.0-branch/JSTests/ChangeLog (281212 => 281213)

--- branches/safari-612.1.27.0-branch/JSTests/ChangeLog	2021-08-18 22:00:58 UTC (rev 281212)
+++ branches/safari-612.1.27.0-branch/JSTests/ChangeLog	2021-08-18 22:04:13 UTC (rev 281213)
@@ -1,41 +1,5 @@
 2021-08-18  Russell Epstein  
 
-Cherry-pick r280505. rdar://problem/82088775
-
-putInlineFastReplacingStaticPropertyIfNeeded should handle custom values
-https://bugs.webkit.org/show_bug.cgi?id=227963
-
-Reviewed by Alexey Shvayka.
-
-JSTests:
-
-* stress/reflect-set-custom-value.js:
-
-Source/_javascript_Core:
-
-Follow up after r280463: as it turns out, putInlineFastReplacingStaticPropertyIfNeeded also needs to handle
-custom values, similar to how definePropertyOnReceiverSlow was updated. This function will be called when the
-target property of the receiver is a custom value and isn't reified. The previous test case was expanded to
-test both the reified and non-reified cases.
-
-* runtime/JSObject.cpp:
-(JSC::JSObject::putInlineFastReplacingStaticPropertyIfNeeded):
-* tools/JSDollarVM.cpp:
-
-
-git-svn-id: https://svn.webkit.org/repository/webkit/trunk@280505 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
-2021-07-30  Tadeu Zagallo  
-
-putInlineFastReplacingStaticPropertyIfNeeded should handle custom values
-https://bugs.webkit.org/show_bug.cgi?id=227963
-
-Reviewed by Alexey Shvayka.
-
-* stress/reflect-set-custom-value.js:
-
-2021-08-18  Russell Epstein  
-
 Cherry-pick r280463. rdar://problem/82088775
 
 definePropertyOnReceiver should check if receiver canPerformFastPutInline


Modified: branches/safari-612.1.27.0-branch/JSTests/stress/reflect-set-custom-value.js (281212 => 281213)

--- branches/safari-612.1.27.0-branch/JSTests/stress/reflect-set-custom-value.js	2021-08-18 22:00:58 UTC (rev 281212)
+++ branches/safari-612.1.27.0-branch/JSTests/stress/reflect-set-custom-value.js	2021-08-18 22:04:13 UTC (rev 281213)
@@ -1,14 +1,3 @@
-{
-// reified
-const testGetterSetter = $vm.createCustomTestGetterSetter();
-Reflect.set({}, 'customValue', 'foo', testGetterSetter);
-testGetterSetter.customValue = 42;
-}
-
-{
-// non-reified
-let tester = $vm.createStaticCustomValue();
-Reflect.set({}, "testStaticValueSetFlag", 'foo', tester);
-if (!tester.testStaticValueSetterCalled)
-throw new Error('Custom value overriden');
-}
+const testGetterSetter = $vm.createCustomTestGetterSetter();
+Reflect.set({}, 'customValue', 'foo', testGetterSetter);
+testGetterSetter.customValue = 42;


Modified: branches/safari-612.1.27.0-branch/Source/_javascript_Core/ChangeLog (281212 => 281213)

--- branches/safari-612.1.27.0-branch/Source/_javascript_Core/ChangeLog	2021-08-18 22:00:58 UTC (rev 281212)
+++ branches/safari-612.1.27.0-branch/Source/_javascript_Core/ChangeLog	2021-08-18 22:04:13 UTC (rev 281213)
@@ -1,48 +1,5 @@
 2021-08-18  Russell Epstein  
 
-Cherry-pick r280505. rdar://problem/82088775
-
-putInlineFastReplacingStaticPropertyIfNeeded should handle custom values
-https://bugs.webkit.org/show_bug.cgi?id=227963
-
-Reviewed by Alexey Shvayka.
-
-JSTests:
-
-* stress/reflect-set-custom-value.js:
-
-Source/_javascript_Core:
-
-Follow up after r280463: as it turns out, putInlineFastReplacingStaticPropertyIfNeeded also needs to handle
-custom values, similar to how definePropertyOnReceiverSlow was updated. This function will be called when the
-target property of the receiver is a custom value and isn't reified. The previous test case was expanded to
-test both the reified and non-reified cases.
-
-* runtime/JSObject.cpp:
-(JSC::JSObject::putInlineFastReplacingStaticPropertyIfNeeded):
-* tools/JSDollarVM.cpp:
-
-
-git-svn-id: https://svn.webkit.org/repository/webkit/trunk@280505 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
-2021-07-30  Tadeu Zagallo  
-
-putInlineFastReplacingStaticPropertyIfNeeded should handle custom values
-https://bugs.webkit.org/show_bug.cgi?id=227963
-
-Reviewed by Alexey Shvayka.
-
-Follow up after r280463: as it turns out, putInlineFastReplacingStaticPropertyIfNeeded also needs to handle
-custom values, similar to how 

[webkit-changes] [281212] trunk/LayoutTests

[ehutchison]

Title: [281212] trunk/LayoutTests








Revision 281212
Author ehutchi...@apple.com
Date 2021-08-18 15:00:58 -0700 (Wed, 18 Aug 2021)


Log Message
[Mac wk1 Debug] imported/w3c/web-platform-tests/IndexedDB/idbcursor-advance-continue-async.htm is a flaky timeout.
https://bugs.webkit.org/show_bug.cgi?id=229252.

Unreviewed test gardening.

* platform/mac-wk1/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac-wk1/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (281211 => 281212)

--- trunk/LayoutTests/ChangeLog	2021-08-18 21:41:54 UTC (rev 281211)
+++ trunk/LayoutTests/ChangeLog	2021-08-18 22:00:58 UTC (rev 281212)
@@ -1,3 +1,12 @@
+2021-08-18  Eric Hutchison  
+
+[Mac wk1 Debug] imported/w3c/web-platform-tests/IndexedDB/idbcursor-advance-continue-async.htm is a flaky timeout.
+https://bugs.webkit.org/show_bug.cgi?id=229252.
+
+Unreviewed test gardening.
+
+* platform/mac-wk1/TestExpectations:
+
 2021-08-18  Fujii Hironori  
 
 [Win] http/tests/fetch/keepalive-fetch-2.html is randomly failing


Modified: trunk/LayoutTests/platform/mac-wk1/TestExpectations (281211 => 281212)

--- trunk/LayoutTests/platform/mac-wk1/TestExpectations	2021-08-18 21:41:54 UTC (rev 281211)
+++ trunk/LayoutTests/platform/mac-wk1/TestExpectations	2021-08-18 22:00:58 UTC (rev 281212)
@@ -1387,5 +1387,7 @@
 #rdar://82039967 [ Monterey Debug ] inspector/css/getMatchedStylesForNodeMarkerPseudoId.html is a flaky failure)
 inspector/css/getMatchedStylesForNodeMarkerPseudoId.html [ Pass Failure ]
 
+webkit.org/b/229252 imported/w3c/web-platform-tests/IndexedDB/idbcursor-advance-continue-async.htm [ Pass Timeout ]
+
 # webkit.org/b/228200 Adjusting test expectations for Monterey on Open Source :
 [ Monterey ] webrtc/h264-high.html [ Failure ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [281211] trunk/Tools

[lmoura]

Title: [281211] trunk/Tools








Revision 281211
Author lmo...@igalia.com
Date 2021-08-18 14:41:54 -0700 (Wed, 18 Aug 2021)


Log Message
REGRESSION(r279169) [WebDriver] WPT Tools now requires python3 to launch the server
https://bugs.webkit.org/show_bug.cgi?id=229248

Reviewed by Chris Dumez.

239066@main updated the layout test WPT tools to
94d018bb5d7c0d46df7ba1 and this version requires Python3 to run the
WPT server.

* Scripts/webkitpy/webdriver_tests/webdriver_w3c_web_server.py:
(WebDriverW3CWebServer.start):

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/webdriver_tests/webdriver_w3c_web_server.py




Diff

Modified: trunk/Tools/ChangeLog (281210 => 281211)

--- trunk/Tools/ChangeLog	2021-08-18 21:17:26 UTC (rev 281210)
+++ trunk/Tools/ChangeLog	2021-08-18 21:41:54 UTC (rev 281211)
@@ -1,3 +1,17 @@
+2021-08-18  Lauro Moura  
+
+REGRESSION(r279169) [WebDriver] WPT Tools now requires python3 to launch the server
+https://bugs.webkit.org/show_bug.cgi?id=229248
+
+Reviewed by Chris Dumez.
+
+239066@main updated the layout test WPT tools to
+94d018bb5d7c0d46df7ba1 and this version requires Python3 to run the
+WPT server.
+
+* Scripts/webkitpy/webdriver_tests/webdriver_w3c_web_server.py:
+(WebDriverW3CWebServer.start):
+
 2021-08-18  Andres Gonzalez  
 
 Add layout test for WebAccessibilityObjectWrapper handler for attribute AXLineForTextMarker on MacOS.


Modified: trunk/Tools/Scripts/webkitpy/webdriver_tests/webdriver_w3c_web_server.py (281210 => 281211)

--- trunk/Tools/Scripts/webkitpy/webdriver_tests/webdriver_w3c_web_server.py	2021-08-18 21:17:26 UTC (rev 281210)
+++ trunk/Tools/Scripts/webkitpy/webdriver_tests/webdriver_w3c_web_server.py	2021-08-18 21:41:54 UTC (rev 281211)
@@ -104,7 +104,7 @@
 
 self._wsout = self._port.host.filesystem.open_text_file_for_writing(self._output_log_path)
 wpt_file = os.path.join(self._layout_doc_root, "wpt.py")
-cmd = ["python", wpt_file, "serve", "--config", os.path.join(self._layout_doc_root, 'config.json')]
+cmd = ["python3", wpt_file, "serve", "--config", os.path.join(self._layout_doc_root, 'config.json')]
 self._process = self._port._executive.popen(cmd, cwd=self._layout_doc_root, shell=False, stdin=self._port._executive.PIPE, stdout=self._wsout, stderr=self._wsout)
 self._pid = self._process.pid
 self._port.host.filesystem.write_text_file(self._pid_file, str(self._pid))






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [281210] trunk/Source

[megan_gardner]

Title: [281210] trunk/Source








Revision 281210
Author megan_gard...@apple.com
Date 2021-08-18 14:17:26 -0700 (Wed, 18 Aug 2021)


Log Message
Remove unneeded UIKitSPI declarations
https://bugs.webkit.org/show_bug.cgi?id=210075

Reviewed by Wenson Hsieh.

Source/WebKit:

No code changes, just using the now fully public API.

* Platform/spi/ios/UIKitSPI.h:
* UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView _webTouchEventsRecognized:]):
(-[WKContentView _highlightLongPressRecognized:]):
(-[WKContentView _doubleTapRecognizedForDoubleClick:]):
(-[WKContentView _twoFingerSingleTapGestureRecognized:]):
(-[WKContentView _singleTapRecognized:]):
(gestureRecognizerModifierFlags): Deleted.

Source/WTF:

Remove unneeded feature define.

* wtf/PlatformHave.h:

Modified Paths

trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/PlatformHave.h
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Platform/spi/ios/UIKitSPI.h
trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm




Diff

Modified: trunk/Source/WTF/ChangeLog (281209 => 281210)

--- trunk/Source/WTF/ChangeLog	2021-08-18 20:21:06 UTC (rev 281209)
+++ trunk/Source/WTF/ChangeLog	2021-08-18 21:17:26 UTC (rev 281210)
@@ -1,3 +1,14 @@
+2021-08-18  Megan Gardner  
+
+Remove unneeded UIKitSPI declarations
+https://bugs.webkit.org/show_bug.cgi?id=210075
+
+Reviewed by Wenson Hsieh.
+
+Remove unneeded feature define.
+
+* wtf/PlatformHave.h:
+
 2021-08-18  Xabier Rodriguez Calvar  
 
 [GStreamer][EME] Try to parse XML init datas that could possibly come from MPD manifests


Modified: trunk/Source/WTF/wtf/PlatformHave.h (281209 => 281210)

--- trunk/Source/WTF/wtf/PlatformHave.h	2021-08-18 20:21:06 UTC (rev 281209)
+++ trunk/Source/WTF/wtf/PlatformHave.h	2021-08-18 21:17:26 UTC (rev 281210)
@@ -501,10 +501,6 @@
 #define HAVE_UI_POINTER_INTERACTION 1
 #endif
 
-#if (PLATFORM(IOS) && __IPHONE_OS_VERSION_MIN_REQUIRED >= 130400) || PLATFORM(WATCHOS) || PLATFORM(APPLETV)
-#define HAVE_UI_GESTURE_RECOGNIZER_MODIFIER_FLAGS 1
-#endif
-
 #if (PLATFORM(IOS) && __IPHONE_OS_VERSION_MIN_REQUIRED >= 130400) || PLATFORM(MACCATALYST)
 #define HAVE_UIKIT_WITH_MOUSE_SUPPORT 1
 #define HAVE_UI_PARALLAX_TRANSITION_GESTURE_RECOGNIZER 1


Modified: trunk/Source/WebKit/ChangeLog (281209 => 281210)

--- trunk/Source/WebKit/ChangeLog	2021-08-18 20:21:06 UTC (rev 281209)
+++ trunk/Source/WebKit/ChangeLog	2021-08-18 21:17:26 UTC (rev 281210)
@@ -1,3 +1,21 @@
+2021-08-18  Megan Gardner  
+
+Remove unneeded UIKitSPI declarations
+https://bugs.webkit.org/show_bug.cgi?id=210075
+
+Reviewed by Wenson Hsieh.
+
+No code changes, just using the now fully public API.
+
+* Platform/spi/ios/UIKitSPI.h:
+* UIProcess/ios/WKContentViewInteraction.mm:
+(-[WKContentView _webTouchEventsRecognized:]):
+(-[WKContentView _highlightLongPressRecognized:]):
+(-[WKContentView _doubleTapRecognizedForDoubleClick:]):
+(-[WKContentView _twoFingerSingleTapGestureRecognized:]):
+(-[WKContentView _singleTapRecognized:]):
+(gestureRecognizerModifierFlags): Deleted.
+
 2021-08-18  Youenn Fablet  
 
 [MacOS] Use com.apple.webkit.microphone extension to gate microphone access in GPUProcess sandbox


Modified: trunk/Source/WebKit/Platform/spi/ios/UIKitSPI.h (281209 => 281210)

--- trunk/Source/WebKit/Platform/spi/ios/UIKitSPI.h	2021-08-18 20:21:06 UTC (rev 281209)
+++ trunk/Source/WebKit/Platform/spi/ios/UIKitSPI.h	2021-08-18 21:17:26 UTC (rev 281210)
@@ -456,12 +456,6 @@
 - (CGSize)_legacy_sizeWithFont:(UIFont *)font minFontSize:(CGFloat)minFontSize actualFontSize:(CGFloat *)actualFontSize forWidth:(CGFloat)width lineBreakMode:(NSLineBreakMode)lineBreakMode;
 @end
 
-@interface UIGestureRecognizer ()
-#if PLATFORM(IOS) && !defined(__IPHONE_13_4)
-@property (nonatomic, readonly, getter=_modifierFlags) UIKeyModifierFlags modifierFlags;
-#endif
-@end
-
 #if HAVE(UI_HOVER_EVENT_RESPONDABLE)
 
 @protocol _UIHoverEventRespondable 


Modified: trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm (281209 => 281210)

--- trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm	2021-08-18 20:21:06 UTC (rev 281209)
+++ trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm	2021-08-18 21:17:26 UTC (rev 281210)
@@ -1676,15 +1676,6 @@
 return std::nullopt;
 }
 
-inline static UIKeyModifierFlags gestureRecognizerModifierFlags(UIGestureRecognizer *recognizer)
-{
-#if HAVE(UI_GESTURE_RECOGNIZER_MODIFIER_FLAGS)
-return recognizer.modifierFlags;
-#else
-return [recognizer respondsToSelector:@selector(_modifierFlags)] ? [recognizer _modifierFlags] : 0;
-#endif
-}
-
 - (BOOL)_touchEventsMustRequireGestureRecognizerToFail:(UIGestureRecognizer *)gestureRecognizer
 {
 auto webView = self.webView;
@@ -1719,7 +1710,7 @@
 }
 
 #if ENABLE(TOUCH_EVENTS)
-WebKit::NativeWebTouchEvent nativeWebTouchEvent { lastTouchEvent, 

[webkit-changes] [281209] trunk/LayoutTests

[Hironori . Fujii]

Title: [281209] trunk/LayoutTests








Revision 281209
Author hironori.fu...@sony.com
Date 2021-08-18 13:21:06 -0700 (Wed, 18 Aug 2021)


Log Message
[Win] http/tests/fetch/keepalive-fetch-2.html is randomly failing
https://bugs.webkit.org/show_bug.cgi?id=229247

Unreviewed test gardening.

* platform/win/TestExpectations: Marked it as flaky.
* platform/wincairo-wk1/TestExpectations: Ditto.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/win/TestExpectations
trunk/LayoutTests/platform/wincairo-wk1/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (281208 => 281209)

--- trunk/LayoutTests/ChangeLog	2021-08-18 19:51:34 UTC (rev 281208)
+++ trunk/LayoutTests/ChangeLog	2021-08-18 20:21:06 UTC (rev 281209)
@@ -1,3 +1,13 @@
+2021-08-18  Fujii Hironori  
+
+[Win] http/tests/fetch/keepalive-fetch-2.html is randomly failing
+https://bugs.webkit.org/show_bug.cgi?id=229247
+
+Unreviewed test gardening.
+
+* platform/win/TestExpectations: Marked it as flaky.
+* platform/wincairo-wk1/TestExpectations: Ditto.
+
 2021-08-18  Eric Hutchison  
 
 [Mac Debug] imported/w3c/web-platform-tests/IndexedDB/key-generators/reading-autoincrement-indexes-cursors.any.worker.html is a flaky crash.


Modified: trunk/LayoutTests/platform/win/TestExpectations (281208 => 281209)

--- trunk/LayoutTests/platform/win/TestExpectations	2021-08-18 19:51:34 UTC (rev 281208)
+++ trunk/LayoutTests/platform/win/TestExpectations	2021-08-18 20:21:06 UTC (rev 281209)
@@ -4677,3 +4677,5 @@
 
 accessibility/selected-state-changed-notifications.html [ Skip ]
 accessibility/element-line-rects-and-text.html [ Skip ]
+
+webkit.org/b/229247 http/tests/fetch/keepalive-fetch-2.html [ Pass Failure ]


Modified: trunk/LayoutTests/platform/wincairo-wk1/TestExpectations (281208 => 281209)

--- trunk/LayoutTests/platform/wincairo-wk1/TestExpectations	2021-08-18 19:51:34 UTC (rev 281208)
+++ trunk/LayoutTests/platform/wincairo-wk1/TestExpectations	2021-08-18 20:21:06 UTC (rev 281209)
@@ -451,3 +451,5 @@
 http/wpt/fetch/disable-speculative-load-for-xhr-and-fetch-loads.html [ Failure ]
 http/wpt/fetch/dnt-header-after-redirection.html [ Failure ]
 http/wpt/fetch/inspect-preflight.html [ Failure ]
+
+webkit.org/b/229247 http/tests/fetch/keepalive-fetch-2.html [ Pass Failure ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [281208] branches/safari-612.1.27.0-branch

[repstein]

Title: [281208] branches/safari-612.1.27.0-branch








Revision 281208
Author repst...@apple.com
Date 2021-08-18 12:51:34 -0700 (Wed, 18 Aug 2021)


Log Message
Cherry-pick r280505. rdar://problem/82088775

putInlineFastReplacingStaticPropertyIfNeeded should handle custom values
https://bugs.webkit.org/show_bug.cgi?id=227963

Reviewed by Alexey Shvayka.

JSTests:

* stress/reflect-set-custom-value.js:

Source/_javascript_Core:

Follow up after r280463: as it turns out, putInlineFastReplacingStaticPropertyIfNeeded also needs to handle
custom values, similar to how definePropertyOnReceiverSlow was updated. This function will be called when the
target property of the receiver is a custom value and isn't reified. The previous test case was expanded to
test both the reified and non-reified cases.

* runtime/JSObject.cpp:
(JSC::JSObject::putInlineFastReplacingStaticPropertyIfNeeded):
* tools/JSDollarVM.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@280505 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

branches/safari-612.1.27.0-branch/JSTests/ChangeLog
branches/safari-612.1.27.0-branch/JSTests/stress/reflect-set-custom-value.js
branches/safari-612.1.27.0-branch/Source/_javascript_Core/ChangeLog
branches/safari-612.1.27.0-branch/Source/_javascript_Core/runtime/JSObject.cpp




Diff

Modified: branches/safari-612.1.27.0-branch/JSTests/ChangeLog (281207 => 281208)

--- branches/safari-612.1.27.0-branch/JSTests/ChangeLog	2021-08-18 19:51:29 UTC (rev 281207)
+++ branches/safari-612.1.27.0-branch/JSTests/ChangeLog	2021-08-18 19:51:34 UTC (rev 281208)
@@ -1,5 +1,41 @@
 2021-08-18  Russell Epstein  
 
+Cherry-pick r280505. rdar://problem/82088775
+
+putInlineFastReplacingStaticPropertyIfNeeded should handle custom values
+https://bugs.webkit.org/show_bug.cgi?id=227963
+
+Reviewed by Alexey Shvayka.
+
+JSTests:
+
+* stress/reflect-set-custom-value.js:
+
+Source/_javascript_Core:
+
+Follow up after r280463: as it turns out, putInlineFastReplacingStaticPropertyIfNeeded also needs to handle
+custom values, similar to how definePropertyOnReceiverSlow was updated. This function will be called when the
+target property of the receiver is a custom value and isn't reified. The previous test case was expanded to
+test both the reified and non-reified cases.
+
+* runtime/JSObject.cpp:
+(JSC::JSObject::putInlineFastReplacingStaticPropertyIfNeeded):
+* tools/JSDollarVM.cpp:
+
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@280505 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2021-07-30  Tadeu Zagallo  
+
+putInlineFastReplacingStaticPropertyIfNeeded should handle custom values
+https://bugs.webkit.org/show_bug.cgi?id=227963
+
+Reviewed by Alexey Shvayka.
+
+* stress/reflect-set-custom-value.js:
+
+2021-08-18  Russell Epstein  
+
 Cherry-pick r280463. rdar://problem/82088775
 
 definePropertyOnReceiver should check if receiver canPerformFastPutInline


Modified: branches/safari-612.1.27.0-branch/JSTests/stress/reflect-set-custom-value.js (281207 => 281208)

--- branches/safari-612.1.27.0-branch/JSTests/stress/reflect-set-custom-value.js	2021-08-18 19:51:29 UTC (rev 281207)
+++ branches/safari-612.1.27.0-branch/JSTests/stress/reflect-set-custom-value.js	2021-08-18 19:51:34 UTC (rev 281208)
@@ -1,3 +1,14 @@
-const testGetterSetter = $vm.createCustomTestGetterSetter();
-Reflect.set({}, 'customValue', 'foo', testGetterSetter);
-testGetterSetter.customValue = 42;
+{
+// reified
+const testGetterSetter = $vm.createCustomTestGetterSetter();
+Reflect.set({}, 'customValue', 'foo', testGetterSetter);
+testGetterSetter.customValue = 42;
+}
+
+{
+// non-reified
+let tester = $vm.createStaticCustomValue();
+Reflect.set({}, "testStaticValueSetFlag", 'foo', tester);
+if (!tester.testStaticValueSetterCalled)
+throw new Error('Custom value overriden');
+}


Modified: branches/safari-612.1.27.0-branch/Source/_javascript_Core/ChangeLog (281207 => 281208)

--- branches/safari-612.1.27.0-branch/Source/_javascript_Core/ChangeLog	2021-08-18 19:51:29 UTC (rev 281207)
+++ branches/safari-612.1.27.0-branch/Source/_javascript_Core/ChangeLog	2021-08-18 19:51:34 UTC (rev 281208)
@@ -1,5 +1,48 @@
 2021-08-18  Russell Epstein  
 
+Cherry-pick r280505. rdar://problem/82088775
+
+putInlineFastReplacingStaticPropertyIfNeeded should handle custom values
+https://bugs.webkit.org/show_bug.cgi?id=227963
+
+Reviewed by Alexey Shvayka.
+
+JSTests:
+
+* stress/reflect-set-custom-value.js:
+
+Source/_javascript_Core:
+
+Follow up after r280463: as it turns out, putInlineFastReplacingStaticPropertyIfNeeded also needs to handle
+custom values, similar to how definePropertyOnReceiverSlow was updated. This function will be called 

[webkit-changes] [281207] branches/safari-612.1.27.0-branch

[repstein]

Title: [281207] branches/safari-612.1.27.0-branch








Revision 281207
Author repst...@apple.com
Date 2021-08-18 12:51:29 -0700 (Wed, 18 Aug 2021)


Log Message
Cherry-pick r280463. rdar://problem/82088775

definePropertyOnReceiver should check if receiver canPerformFastPutInline
https://bugs.webkit.org/show_bug.cgi?id=227963


Reviewed by Alexey Shvayka.

JSTests:

* stress/reflect-set-custom-value.js: Added.

Source/_javascript_Core:

definePropertyOnReceiver has a fast path if the slot is not opaque and the receiver doesn't
have a custom defineOwnProperty implementation, in which case it calls putInlineFast (and
transitively putDirectInternal). The issue is that putDirectInternal does not
handle customValues correctly: it just overwrites the property without changing the attributes.
To fix that, we should first check if the property might be a custom value, and if that's the case
we now call `definePropertyOnReceiverSlow`, which has been updated to handle custom values correctly.
I also added assertions to putInlineFastReplacingStaticPropertyIfNeeded and putDirectInternal
to make sure we don't accidentally overwrite custom values in the future.

* runtime/JSObject.cpp:
(JSC::definePropertyOnReceiverSlow):
(JSC::JSObject::definePropertyOnReceiver):
(JSC::JSObject::putInlineFastReplacingStaticPropertyIfNeeded):
* runtime/JSObjectInlines.h:
(JSC::JSObject::putDirectInternal):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@280463 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

branches/safari-612.1.27.0-branch/JSTests/ChangeLog
branches/safari-612.1.27.0-branch/JSTests/stress/reflect-set-custom-value.js
branches/safari-612.1.27.0-branch/Source/_javascript_Core/ChangeLog
branches/safari-612.1.27.0-branch/Source/_javascript_Core/runtime/JSObject.cpp




Diff

Modified: branches/safari-612.1.27.0-branch/JSTests/ChangeLog (281206 => 281207)

--- branches/safari-612.1.27.0-branch/JSTests/ChangeLog	2021-08-18 19:13:37 UTC (rev 281206)
+++ branches/safari-612.1.27.0-branch/JSTests/ChangeLog	2021-08-18 19:51:29 UTC (rev 281207)
@@ -1,3 +1,47 @@
+2021-08-18  Russell Epstein  
+
+Cherry-pick r280463. rdar://problem/82088775
+
+definePropertyOnReceiver should check if receiver canPerformFastPutInline
+https://bugs.webkit.org/show_bug.cgi?id=227963
+
+
+Reviewed by Alexey Shvayka.
+
+JSTests:
+
+* stress/reflect-set-custom-value.js: Added.
+
+Source/_javascript_Core:
+
+definePropertyOnReceiver has a fast path if the slot is not opaque and the receiver doesn't
+have a custom defineOwnProperty implementation, in which case it calls putInlineFast (and
+transitively putDirectInternal). The issue is that putDirectInternal does not
+handle customValues correctly: it just overwrites the property without changing the attributes.
+To fix that, we should first check if the property might be a custom value, and if that's the case
+we now call `definePropertyOnReceiverSlow`, which has been updated to handle custom values correctly.
+I also added assertions to putInlineFastReplacingStaticPropertyIfNeeded and putDirectInternal
+to make sure we don't accidentally overwrite custom values in the future.
+
+* runtime/JSObject.cpp:
+(JSC::definePropertyOnReceiverSlow):
+(JSC::JSObject::definePropertyOnReceiver):
+(JSC::JSObject::putInlineFastReplacingStaticPropertyIfNeeded):
+* runtime/JSObjectInlines.h:
+(JSC::JSObject::putDirectInternal):
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@280463 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2021-07-29  Tadeu Zagallo  
+
+definePropertyOnReceiver should check if receiver canPerformFastPutInline
+https://bugs.webkit.org/show_bug.cgi?id=227963
+
+
+Reviewed by Alexey Shvayka.
+
+* stress/reflect-set-custom-value.js: Added.
+
 2021-08-02  Yusuke Suzuki  
 
 [JSC] Yarr BoyerMoore search should support character-class


Modified: branches/safari-612.1.27.0-branch/JSTests/stress/reflect-set-custom-value.js (281206 => 281207)

--- branches/safari-612.1.27.0-branch/JSTests/stress/reflect-set-custom-value.js	2021-08-18 19:13:37 UTC (rev 281206)
+++ branches/safari-612.1.27.0-branch/JSTests/stress/reflect-set-custom-value.js	2021-08-18 19:51:29 UTC (rev 281207)
@@ -1,14 +1,3 @@
-{
-// reified
-const testGetterSetter = $vm.createCustomTestGetterSetter();
-Reflect.set({}, 'customValue', 'foo', testGetterSetter);
-testGetterSetter.customValue = 42;
-}
-
-{
-// non-reified
-let tester = $vm.createStaticCustomValue();
-Reflect.set({}, "testStaticValueSetFlag", 'foo', tester);
-if (!tester.testStaticValueSetterCalled)
-throw new Error('Custom value overriden');
-}
+const testGetterSetter = $vm.createCustomTestGetterSetter();
+Reflect.set({}, 'customValue', 

[webkit-changes] [281206] trunk

[cdumez]

Title: [281206] trunk








Revision 281206
Author cdu...@apple.com
Date 2021-08-18 12:13:37 -0700 (Wed, 18 Aug 2021)


Log Message
Implement Crypto.randomUUID()
https://bugs.webkit.org/show_bug.cgi?id=229240

Reviewed by Geoffrey Garen.

LayoutTests/imported/w3c:

Rebaseline WPT tests that are now passing.

* web-platform-tests/WebCryptoAPI/randomUUID.https.any-expected.txt:
* web-platform-tests/WebCryptoAPI/randomUUID.https.any.worker-expected.txt:

Source/WebCore:

Implement Crypto.randomUUID():
- https://wicg.github.io/uuid/#extensions-to-the-crypto-interface

Chrome already implements this and Firefox seems to be working on it
(https://bugzilla.mozilla.org/show_bug.cgi?id=1705264).

No new tests, rebaselined existing tests.

* page/Crypto.cpp:
(WebCore::Crypto::randomUUID const):
* page/Crypto.h:
* page/Crypto.idl:

Modified Paths

trunk/LayoutTests/imported/w3c/ChangeLog
trunk/LayoutTests/imported/w3c/web-platform-tests/WebCryptoAPI/randomUUID.https.any-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/WebCryptoAPI/randomUUID.https.any.worker-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/Crypto.cpp
trunk/Source/WebCore/page/Crypto.h
trunk/Source/WebCore/page/Crypto.idl




Diff

Modified: trunk/LayoutTests/imported/w3c/ChangeLog (281205 => 281206)

--- trunk/LayoutTests/imported/w3c/ChangeLog	2021-08-18 19:05:11 UTC (rev 281205)
+++ trunk/LayoutTests/imported/w3c/ChangeLog	2021-08-18 19:13:37 UTC (rev 281206)
@@ -1,3 +1,15 @@
+2021-08-18  Chris Dumez  
+
+Implement Crypto.randomUUID()
+https://bugs.webkit.org/show_bug.cgi?id=229240
+
+Reviewed by Geoffrey Garen.
+
+Rebaseline WPT tests that are now passing.
+
+* web-platform-tests/WebCryptoAPI/randomUUID.https.any-expected.txt:
+* web-platform-tests/WebCryptoAPI/randomUUID.https.any.worker-expected.txt:
+
 2021-08-18  Martin Robinson  
 
 [css-scroll-snap] Don't snap to offscreen snap areas in unidirectional scrolls


Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/WebCryptoAPI/randomUUID.https.any-expected.txt (281205 => 281206)

--- trunk/LayoutTests/imported/w3c/web-platform-tests/WebCryptoAPI/randomUUID.https.any-expected.txt	2021-08-18 19:05:11 UTC (rev 281205)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/WebCryptoAPI/randomUUID.https.any-expected.txt	2021-08-18 19:13:37 UTC (rev 281206)
@@ -1,5 +1,5 @@
 
-FAIL namespace format self.crypto.randomUUID is not a function. (In 'self.crypto.randomUUID()', 'self.crypto.randomUUID' is undefined)
-FAIL version set self.crypto.randomUUID is not a function. (In 'self.crypto.randomUUID()', 'self.crypto.randomUUID' is undefined)
-FAIL variant set self.crypto.randomUUID is not a function. (In 'self.crypto.randomUUID()', 'self.crypto.randomUUID' is undefined)
+PASS namespace format
+PASS version set
+PASS variant set
 


Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/WebCryptoAPI/randomUUID.https.any.worker-expected.txt (281205 => 281206)

--- trunk/LayoutTests/imported/w3c/web-platform-tests/WebCryptoAPI/randomUUID.https.any.worker-expected.txt	2021-08-18 19:05:11 UTC (rev 281205)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/WebCryptoAPI/randomUUID.https.any.worker-expected.txt	2021-08-18 19:13:37 UTC (rev 281206)
@@ -1,5 +1,5 @@
 
-FAIL namespace format self.crypto.randomUUID is not a function. (In 'self.crypto.randomUUID()', 'self.crypto.randomUUID' is undefined)
-FAIL version set self.crypto.randomUUID is not a function. (In 'self.crypto.randomUUID()', 'self.crypto.randomUUID' is undefined)
-FAIL variant set self.crypto.randomUUID is not a function. (In 'self.crypto.randomUUID()', 'self.crypto.randomUUID' is undefined)
+PASS namespace format
+PASS version set
+PASS variant set
 


Modified: trunk/Source/WebCore/ChangeLog (281205 => 281206)

--- trunk/Source/WebCore/ChangeLog	2021-08-18 19:05:11 UTC (rev 281205)
+++ trunk/Source/WebCore/ChangeLog	2021-08-18 19:13:37 UTC (rev 281206)
@@ -1,3 +1,23 @@
+2021-08-18  Chris Dumez  
+
+Implement Crypto.randomUUID()
+https://bugs.webkit.org/show_bug.cgi?id=229240
+
+Reviewed by Geoffrey Garen.
+
+Implement Crypto.randomUUID():
+- https://wicg.github.io/uuid/#extensions-to-the-crypto-interface
+
+Chrome already implements this and Firefox seems to be working on it
+(https://bugzilla.mozilla.org/show_bug.cgi?id=1705264).
+
+No new tests, rebaselined existing tests.
+
+* page/Crypto.cpp:
+(WebCore::Crypto::randomUUID const):
+* page/Crypto.h:
+* page/Crypto.idl:
+
 2021-08-18  Andres Gonzalez  
 
 Add layout test for WebAccessibilityObjectWrapper handler for attribute AXLineForTextMarker on MacOS.


Modified: trunk/Source/WebCore/page/Crypto.cpp (281205 => 281206)

--- trunk/Source/WebCore/page/Crypto.cpp	2021-08-18 19:05:11 UTC (rev 281205)
+++ trunk/Source/WebCore/page/Crypto.cpp	2021-08-18 19:13:37 UTC (rev 281206)
@@ -35,6 

[webkit-changes] [281205] trunk/LayoutTests

[ehutchison]

Title: [281205] trunk/LayoutTests








Revision 281205
Author ehutchi...@apple.com
Date 2021-08-18 12:05:11 -0700 (Wed, 18 Aug 2021)


Log Message
[Mac Debug] imported/w3c/web-platform-tests/IndexedDB/key-generators/reading-autoincrement-indexes-cursors.any.worker.html is a flaky crash.
https://bugs.webkit.org/show_bug.cgi?id=229244.

Unreviewed test gardening.

* platform/mac/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (281204 => 281205)

--- trunk/LayoutTests/ChangeLog	2021-08-18 18:32:02 UTC (rev 281204)
+++ trunk/LayoutTests/ChangeLog	2021-08-18 19:05:11 UTC (rev 281205)
@@ -1,3 +1,12 @@
+2021-08-18  Eric Hutchison  
+
+[Mac Debug] imported/w3c/web-platform-tests/IndexedDB/key-generators/reading-autoincrement-indexes-cursors.any.worker.html is a flaky crash.
+https://bugs.webkit.org/show_bug.cgi?id=229244.
+
+Unreviewed test gardening.
+
+* platform/mac/TestExpectations:
+
 2021-08-18  Andres Gonzalez  
 
 Add layout test for WebAccessibilityObjectWrapper handler for attribute AXLineForTextMarker on MacOS.


Modified: trunk/LayoutTests/platform/mac/TestExpectations (281204 => 281205)

--- trunk/LayoutTests/platform/mac/TestExpectations	2021-08-18 18:32:02 UTC (rev 281204)
+++ trunk/LayoutTests/platform/mac/TestExpectations	2021-08-18 19:05:11 UTC (rev 281205)
@@ -2320,5 +2320,7 @@
 #rdar://82053210 ([Guard-Malloc] imported/w3c/web-platform-tests/mathml/relations/html5-tree/display-2.html is a flaky failure)
 imported/w3c/web-platform-tests/mathml/relations/html5-tree/display-2.html [ Pass ImageOnlyFailure ]
 
+webkit.org/b/229244 imported/w3c/web-platform-tests/IndexedDB/key-generators/reading-autoincrement-indexes-cursors.any.worker.html [ Pass Crash ]
+
 webkit.org/b/228396 fast/speechsynthesis/speech-synthesis-speak-empty-string.html [ Pass Failure ]
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [281202] branches/safari-612.1.27.0-branch/Source/JavaScriptCore

[repstein]

Title: [281202] branches/safari-612.1.27.0-branch/Source/_javascript_Core








Revision 281202
Author repst...@apple.com
Date 2021-08-18 11:31:56 -0700 (Wed, 18 Aug 2021)


Log Message
Cherry-pick r281178. rdar://problem/82083485

Add an option for canonicalizePrePostIncrements
https://bugs.webkit.org/show_bug.cgi?id=229211


Reviewed by Mark Lam.

The current phase has bugs. Let's disable it for now until the bugs
are fixed. See discussion about the bugs I spotted in:
https://bugs.webkit.org/show_bug.cgi?id=228538

* b3/B3Generate.cpp:
(JSC::B3::generateToAir):
* b3/testb3_3.cpp:
(addShrTests):
* runtime/OptionsList.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@281178 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

branches/safari-612.1.27.0-branch/Source/_javascript_Core/ChangeLog
branches/safari-612.1.27.0-branch/Source/_javascript_Core/b3/B3Generate.cpp
branches/safari-612.1.27.0-branch/Source/_javascript_Core/b3/testb3_3.cpp
branches/safari-612.1.27.0-branch/Source/_javascript_Core/runtime/OptionsList.h




Diff

Modified: branches/safari-612.1.27.0-branch/Source/_javascript_Core/ChangeLog (281201 => 281202)

--- branches/safari-612.1.27.0-branch/Source/_javascript_Core/ChangeLog	2021-08-18 18:04:09 UTC (rev 281201)
+++ branches/safari-612.1.27.0-branch/Source/_javascript_Core/ChangeLog	2021-08-18 18:31:56 UTC (rev 281202)
@@ -1,3 +1,43 @@
+2021-08-18  Russell Epstein  
+
+Cherry-pick r281178. rdar://problem/82083485
+
+Add an option for canonicalizePrePostIncrements
+https://bugs.webkit.org/show_bug.cgi?id=229211
+
+
+Reviewed by Mark Lam.
+
+The current phase has bugs. Let's disable it for now until the bugs
+are fixed. See discussion about the bugs I spotted in:
+https://bugs.webkit.org/show_bug.cgi?id=228538
+
+* b3/B3Generate.cpp:
+(JSC::B3::generateToAir):
+* b3/testb3_3.cpp:
+(addShrTests):
+* runtime/OptionsList.h:
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@281178 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2021-08-17  Saam Barati  
+
+Add an option for canonicalizePrePostIncrements
+https://bugs.webkit.org/show_bug.cgi?id=229211
+
+
+Reviewed by Mark Lam.
+
+The current phase has bugs. Let's disable it for now until the bugs
+are fixed. See discussion about the bugs I spotted in:
+https://bugs.webkit.org/show_bug.cgi?id=228538
+
+* b3/B3Generate.cpp:
+(JSC::B3::generateToAir):
+* b3/testb3_3.cpp:
+(addShrTests):
+* runtime/OptionsList.h:
+
 2021-08-13  Alan Coon  
 
 Cherry-pick r280996. rdar://problem/81901248


Modified: branches/safari-612.1.27.0-branch/Source/_javascript_Core/b3/B3Generate.cpp (281201 => 281202)

--- branches/safari-612.1.27.0-branch/Source/_javascript_Core/b3/B3Generate.cpp	2021-08-18 18:04:09 UTC (rev 281201)
+++ branches/safari-612.1.27.0-branch/Source/_javascript_Core/b3/B3Generate.cpp	2021-08-18 18:31:56 UTC (rev 281202)
@@ -118,11 +118,10 @@
 lowerMacrosAfterOptimizations(procedure);
 legalizeMemoryOffsets(procedure);
 moveConstants(procedure);
-eliminateDeadCode(procedure);
 
-if (procedure.optLevel() >= 2)
+if (Options::useB3CanonicalizePrePostIncrements() && procedure.optLevel() >= 2)
 canonicalizePrePostIncrements(procedure);
-
+eliminateDeadCode(procedure);
 // FIXME: We should run pureCSE here to clean up some platform specific changes from the previous phases.
 // https://bugs.webkit.org/show_bug.cgi?id=164873
 


Modified: branches/safari-612.1.27.0-branch/Source/_javascript_Core/b3/testb3_3.cpp (281201 => 281202)

--- branches/safari-612.1.27.0-branch/Source/_javascript_Core/b3/testb3_3.cpp	2021-08-18 18:04:09 UTC (rev 281201)
+++ branches/safari-612.1.27.0-branch/Source/_javascript_Core/b3/testb3_3.cpp	2021-08-18 18:31:56 UTC (rev 281202)
@@ -3992,10 +3992,12 @@
 RUN(testZShrArgImm32(0x, 1));
 RUN(testZShrArgImm32(0x, 63));
 
-RUN(testLoadPreIndex32());
-RUN(testLoadPreIndex64());
-RUN(testLoadPostIndex32());
-RUN(testLoadPostIndex64());
+if (Options::useB3CanonicalizePrePostIncrements()) {
+RUN(testLoadPreIndex32());
+RUN(testLoadPreIndex64());
+RUN(testLoadPostIndex32());
+RUN(testLoadPostIndex64());
+}
 }
 
 #endif // ENABLE(B3_JIT)


Modified: branches/safari-612.1.27.0-branch/Source/_javascript_Core/runtime/OptionsList.h (281201 => 281202)

--- branches/safari-612.1.27.0-branch/Source/_javascript_Core/runtime/OptionsList.h	2021-08-18 18:04:09 UTC (rev 281201)
+++ branches/safari-612.1.27.0-branch/Source/_javascript_Core/runtime/OptionsList.h	2021-08-18 18:31:56 UTC (rev 281202)
@@ -437,6 +437,7 @@
 v(Unsigned, maxB3TailDupBlockSize, 3, Normal, nullptr) \
 v(Unsigned, maxB3TailDupBlockSuccessors, 3, 

[webkit-changes] [281204] branches/safari-612.1.27.0-branch/LayoutTests

[repstein]

Title: [281204] branches/safari-612.1.27.0-branch/LayoutTests








Revision 281204
Author repst...@apple.com
Date 2021-08-18 11:32:02 -0700 (Wed, 18 Aug 2021)


Log Message
Cherry-pick r281195. rdar://problem/82083653

Add a layout test for webkit.org/b/229200
https://bugs.webkit.org/show_bug.cgi?id=229222
rdar://81636256

Reviewed by Simon Fraser.

Add a layout test to exercise the hang fixed in bug #229200. This test can be manually run by opening it in
browser and verifying that the page does not hang (and outputs the expected PASS messages).

* fast/canvas/draw-text-repeatedly-into-disconnected-canvas-expected.txt: Added.
* fast/canvas/draw-text-repeatedly-into-disconnected-canvas.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@281195 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

branches/safari-612.1.27.0-branch/LayoutTests/ChangeLog


Added Paths

branches/safari-612.1.27.0-branch/LayoutTests/fast/canvas/draw-text-repeatedly-into-disconnected-canvas-expected.txt
branches/safari-612.1.27.0-branch/LayoutTests/fast/canvas/draw-text-repeatedly-into-disconnected-canvas.html




Diff

Modified: branches/safari-612.1.27.0-branch/LayoutTests/ChangeLog (281203 => 281204)

--- branches/safari-612.1.27.0-branch/LayoutTests/ChangeLog	2021-08-18 18:31:59 UTC (rev 281203)
+++ branches/safari-612.1.27.0-branch/LayoutTests/ChangeLog	2021-08-18 18:32:02 UTC (rev 281204)
@@ -1,3 +1,36 @@
+2021-08-18  Russell Epstein  
+
+Cherry-pick r281195. rdar://problem/82083653
+
+Add a layout test for webkit.org/b/229200
+https://bugs.webkit.org/show_bug.cgi?id=229222
+rdar://81636256
+
+Reviewed by Simon Fraser.
+
+Add a layout test to exercise the hang fixed in bug #229200. This test can be manually run by opening it in
+browser and verifying that the page does not hang (and outputs the expected PASS messages).
+
+* fast/canvas/draw-text-repeatedly-into-disconnected-canvas-expected.txt: Added.
+* fast/canvas/draw-text-repeatedly-into-disconnected-canvas.html: Added.
+
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@281195 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2021-08-18  Wenson Hsieh  
+
+Add a layout test for webkit.org/b/229200
+https://bugs.webkit.org/show_bug.cgi?id=229222
+rdar://81636256
+
+Reviewed by Simon Fraser.
+
+Add a layout test to exercise the hang fixed in bug #229200. This test can be manually run by opening it in
+browser and verifying that the page does not hang (and outputs the expected PASS messages).
+
+* fast/canvas/draw-text-repeatedly-into-disconnected-canvas-expected.txt: Added.
+* fast/canvas/draw-text-repeatedly-into-disconnected-canvas.html: Added.
+
 2021-08-12  Alan Coon  
 
 Cherry-pick r280931. rdar://problem/81852494


Added: branches/safari-612.1.27.0-branch/LayoutTests/fast/canvas/draw-text-repeatedly-into-disconnected-canvas-expected.txt (0 => 281204)

--- branches/safari-612.1.27.0-branch/LayoutTests/fast/canvas/draw-text-repeatedly-into-disconnected-canvas-expected.txt	(rev 0)
+++ branches/safari-612.1.27.0-branch/LayoutTests/fast/canvas/draw-text-repeatedly-into-disconnected-canvas-expected.txt	2021-08-18 18:32:02 UTC (rev 281204)
@@ -0,0 +1,5 @@
+PASS Done painting
+PASS successfullyParsed is true
+
+TEST COMPLETE
+


Added: branches/safari-612.1.27.0-branch/LayoutTests/fast/canvas/draw-text-repeatedly-into-disconnected-canvas.html (0 => 281204)

--- branches/safari-612.1.27.0-branch/LayoutTests/fast/canvas/draw-text-repeatedly-into-disconnected-canvas.html	(rev 0)
+++ branches/safari-612.1.27.0-branch/LayoutTests/fast/canvas/draw-text-repeatedly-into-disconnected-canvas.html	2021-08-18 18:32:02 UTC (rev 281204)
@@ -0,0 +1,61 @@
+
+
+
+
+jsTestIsAsync = true;
+addEventListener("load", async () => {
+await document.fonts.load("16px Ahem");
+
+for (let i = 0; i < 3; ++i)
+await paintIntoCanvas();
+
+await paintIntoCanvas(document.getElementById("final-target"));
+
+testPassed("Done painting");
+finishJSTest();
+});
+
+async function paintIntoCanvas(target) {
+let canvas = target || document.createElement("canvas");
+let context = canvas.getContext("2d");
+
+context.font = "16px Ahem";
+context.strokeText("Hello world", 10, 10);
+context.strokeText("Hello world", 20, 20);
+
+for (let i = 0; i < 5; ++i)
+await UIHelper.renderingUpdate();
+
+delete context;
+delete canvas;
+gc();
+}
+
+function gc() {
+if (window.GCController)
+return GCController.collect();
+
+let strings = [];
+for (let i = 0; i < 100; ++i)
+strings.push(new String(i));
+}
+
+
+@font-face {
+font-family: Ahem;
+src: url("../../resources/Ahem.ttf");
+}
+
+canvas {
+width: 400px;
+height: 400px;
+

[webkit-changes] [281203] branches/safari-612.1.27.0-branch/Source/WebKit

[repstein]

Title: [281203] branches/safari-612.1.27.0-branch/Source/WebKit








Revision 281203
Author repst...@apple.com
Date 2021-08-18 11:31:59 -0700 (Wed, 18 Aug 2021)


Log Message
Cherry-pick r281186. rdar://problem/82083653

REGRESSION (iOS 15): DoubleDown Casino app won't load past launch page
https://bugs.webkit.org/show_bug.cgi?id=229200
rdar://81636256

Reviewed by Myles C. Maxfield.

The changes in https://webkit.org/b/228216 to fix rdar://80473805 introduced a mechanism to keep track of uses
of cached fonts and images in display list items in the web and GPU processes, via a `useCount` counter variable
that's incremented in the web process whenever the font or image is used in a display list item and decremented
in the GPU process whenever the item is processed.

However, the code to increment `useCount` in the web process currently only triggers at most once per rendering
update — this means that if there are multiple canvas drawing commands that use fonts in the same rendering
update, the web process' notion of `useCount` will fall out of sync with the GPU process' notion of `useCount`.

In most cases, this causes the cached font to remain for longer in the GPU process than necessary; however, in
this specific scenario, it's possible for the web process to tell the GPU process to release the cached font too
early, which causes the GPU process to prematurely purge the font from the cache, and subsequently wait for the
cached font to arrive (which will never arrive, since the web process has already released the font).

In other words, the timeline of events between the web and GPU processes looks like this (where `f` is a cached
web font, `A_f` is a drawing command that uses `f`, and `B_f` is another drawing command that uses `f`).

WEB GPU
==
1. Cache `f`
2. Append `A_f`
3. Cache `f`
4. Play back `A_f`
5. Append `B_f`
6. Release `f` (use count was 1 here)
7. Release `f` (use count dropped from 1 to 0)
8. Play back `B_f`
...and then display list playback stops due to `f` not being in
the cache.

To address this, we simply move the `useCount` increment in the web process out of the rendering update check.
The original intent of the fix for bug #228216 was to allow for `useCount` to increment as many times as needed
per rendering update, so this limitation was unintentional.

Unfortunately, I have not been able to come up with a layout test that reliably reproduces this scenario (yet).

* WebProcess/GPU/graphics/RemoteResourceCacheProxy.cpp:
(WebKit::RemoteResourceCacheProxy::recordFontUse):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@281186 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

branches/safari-612.1.27.0-branch/Source/WebKit/ChangeLog
branches/safari-612.1.27.0-branch/Source/WebKit/WebProcess/GPU/graphics/RemoteResourceCacheProxy.cpp




Diff

Modified: branches/safari-612.1.27.0-branch/Source/WebKit/ChangeLog (281202 => 281203)

--- branches/safari-612.1.27.0-branch/Source/WebKit/ChangeLog	2021-08-18 18:31:56 UTC (rev 281202)
+++ branches/safari-612.1.27.0-branch/Source/WebKit/ChangeLog	2021-08-18 18:31:59 UTC (rev 281203)
@@ -1,3 +1,102 @@
+2021-08-18  Russell Epstein  
+
+Cherry-pick r281186. rdar://problem/82083653
+
+REGRESSION (iOS 15): DoubleDown Casino app won't load past launch page
+https://bugs.webkit.org/show_bug.cgi?id=229200
+rdar://81636256
+
+Reviewed by Myles C. Maxfield.
+
+The changes in https://webkit.org/b/228216 to fix rdar://80473805 introduced a mechanism to keep track of uses
+of cached fonts and images in display list items in the web and GPU processes, via a `useCount` counter variable
+that's incremented in the web process whenever the font or image is used in a display list item and decremented
+in the GPU process whenever the item is processed.
+
+However, the code to increment `useCount` in the web process currently only triggers at most once per rendering
+update — this means that if there are multiple canvas drawing commands that use fonts in the same rendering
+update, the web process' notion of `useCount` will fall out of sync with the GPU process' notion of `useCount`.
+
+In most cases, this causes the cached font to remain for longer in the GPU process than necessary; however, in
+this specific scenario, it's possible for the web process to tell the GPU process to release the cached font too
+early, which causes the GPU process 

[webkit-changes] [281201] trunk/Source/WebKit

[youenn]

Title: [281201] trunk/Source/WebKit








Revision 281201
Author you...@apple.com
Date 2021-08-18 11:04:09 -0700 (Wed, 18 Aug 2021)


Log Message
[MacOS] Use com.apple.webkit.microphone extension to gate microphone access in GPUProcess sandbox
https://bugs.webkit.org/show_bug.cgi?id=229238

Reviewed by Eric Carlson.

Manually tested.

* GPUProcess/mac/com.apple.WebKit.GPUProcess.sb.in:
Align to iOS and only allow microphone access in sandbox if com.apple.webkit.microphone is sent to GPUProcess.
* Shared/WebPreferencesDefaultValues.cpp:
(WebKit::defaultCaptureAudioInGPUProcessEnabled):
Do audio capture in UIProcess for non Safari applications until rdar://problem/29448368 is fixed.

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/GPUProcess/mac/com.apple.WebKit.GPUProcess.sb.in
trunk/Source/WebKit/Shared/WebPreferencesDefaultValues.cpp




Diff

Modified: trunk/Source/WebKit/ChangeLog (281200 => 281201)

--- trunk/Source/WebKit/ChangeLog	2021-08-18 17:57:24 UTC (rev 281200)
+++ trunk/Source/WebKit/ChangeLog	2021-08-18 18:04:09 UTC (rev 281201)
@@ -1,3 +1,18 @@
+2021-08-18  Youenn Fablet  
+
+[MacOS] Use com.apple.webkit.microphone extension to gate microphone access in GPUProcess sandbox
+https://bugs.webkit.org/show_bug.cgi?id=229238
+
+Reviewed by Eric Carlson.
+
+Manually tested.
+
+* GPUProcess/mac/com.apple.WebKit.GPUProcess.sb.in:
+Align to iOS and only allow microphone access in sandbox if com.apple.webkit.microphone is sent to GPUProcess.
+* Shared/WebPreferencesDefaultValues.cpp:
+(WebKit::defaultCaptureAudioInGPUProcessEnabled):
+Do audio capture in UIProcess for non Safari applications until rdar://problem/29448368 is fixed.
+
 2021-08-18  Sihui Liu  
 
 Do not terminate relaunched network process when getting network process connection


Modified: trunk/Source/WebKit/GPUProcess/mac/com.apple.WebKit.GPUProcess.sb.in (281200 => 281201)

--- trunk/Source/WebKit/GPUProcess/mac/com.apple.WebKit.GPUProcess.sb.in	2021-08-18 17:57:24 UTC (rev 281200)
+++ trunk/Source/WebKit/GPUProcess/mac/com.apple.WebKit.GPUProcess.sb.in	2021-08-18 18:04:09 UTC (rev 281201)
@@ -933,8 +933,8 @@
 domains))
 
 ;; Media capture, microphone access
-;; FIXME: make device-microphone access gated by the "com.apple.webkit.microphone" extension.
-(allow device-microphone)
+(with-filter (extension "com.apple.webkit.microphone")
+(allow device-microphone))
 
 ;; Media capture, camera access
 (with-filter (extension "com.apple.webkit.camera")


Modified: trunk/Source/WebKit/Shared/WebPreferencesDefaultValues.cpp (281200 => 281201)

--- trunk/Source/WebKit/Shared/WebPreferencesDefaultValues.cpp	2021-08-18 17:57:24 UTC (rev 281200)
+++ trunk/Source/WebKit/Shared/WebPreferencesDefaultValues.cpp	2021-08-18 18:04:09 UTC (rev 281201)
@@ -190,6 +190,12 @@
 
 bool defaultCaptureAudioInGPUProcessEnabled()
 {
+#if PLATFORM(MAC)
+// FIXME: Enable GPU process audio capture when  is fixed.
+if (!WebCore::MacApplication::isSafari())
+return false;
+#endif
+
 #if ENABLE(GPU_PROCESS_BY_DEFAULT)
 bool defaultValue = true;
 #else






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [281200] trunk

[andresg_22]

Title: [281200] trunk








Revision 281200
Author andresg...@apple.com
Date 2021-08-18 10:57:24 -0700 (Wed, 18 Aug 2021)


Log Message
Add layout test for WebAccessibilityObjectWrapper handler for attribute AXLineForTextMarker on MacOS.
https://bugs.webkit.org/show_bug.cgi?id=229220


Reviewed by Chris Fleizach.

Source/WebCore:

Test: accessibility/mac/line-index-for-textmarker.html

There was not a layout test that exercised directly the handler for the
AXLineForTextMarker attribute in [WebAccessibilityObjectWrapper
accessibilityAttributeValue:withParameter:].
This patch adds the above test to exercise this method for textarea and
contenteditable elements. The text in these elements includes soft and
hard linebreaks, which are important test cases for this API.
The handler for AXLineForTextMarker in turn calls
AccessibilityObject::lineForPosition, and analyzing this method, made a
minor optimization by getting rid off of an unnecessary local variable
and object copy.

* accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::lineForPosition const):

Tools:

Added AccessibilityUIElement::lineIndexForTextMarker.

* WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
(WTR::AccessibilityUIElement::lineIndexForTextMarker const):
* WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
* WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
* WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
(WTR::AccessibilityUIElement::lineIndexForTextMarker const):

LayoutTests:

* accessibility/mac/line-index-for-textmarker-expected.txt: Added.
* accessibility/mac/line-index-for-textmarker.html: Added.
* platform/mac-wk1/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac-wk1/TestExpectations
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/accessibility/AccessibilityObject.cpp
trunk/Tools/ChangeLog
trunk/Tools/WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp
trunk/Tools/WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h
trunk/Tools/WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl
trunk/Tools/WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm


Added Paths

trunk/LayoutTests/accessibility/mac/line-index-for-textmarker-expected.txt
trunk/LayoutTests/accessibility/mac/line-index-for-textmarker.html




Diff

Modified: trunk/LayoutTests/ChangeLog (281199 => 281200)

--- trunk/LayoutTests/ChangeLog	2021-08-18 17:45:29 UTC (rev 281199)
+++ trunk/LayoutTests/ChangeLog	2021-08-18 17:57:24 UTC (rev 281200)
@@ -1,3 +1,15 @@
+2021-08-18  Andres Gonzalez  
+
+Add layout test for WebAccessibilityObjectWrapper handler for attribute AXLineForTextMarker on MacOS.
+https://bugs.webkit.org/show_bug.cgi?id=229220
+
+
+Reviewed by Chris Fleizach.
+
+* accessibility/mac/line-index-for-textmarker-expected.txt: Added.
+* accessibility/mac/line-index-for-textmarker.html: Added.
+* platform/mac-wk1/TestExpectations:
+
 2021-08-18  Wenson Hsieh  
 
 Add a layout test for webkit.org/b/229200


Added: trunk/LayoutTests/accessibility/mac/line-index-for-textmarker-expected.txt (0 => 281200)

--- trunk/LayoutTests/accessibility/mac/line-index-for-textmarker-expected.txt	(rev 0)
+++ trunk/LayoutTests/accessibility/mac/line-index-for-textmarker-expected.txt	2021-08-18 17:57:24 UTC (rev 281200)
@@ -0,0 +1,382 @@
+Test for lineIndexForTextMarker in editable text elements. The text contains soft and hard linebreaks.
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+textarea:
+0 a 0
+1 b 0
+2 c 0
+3 d 0
+4 e 0
+5 f 0
+6 g 0
+7 h 0
+8 i 0
+9 j 0
+10 k 0
+11 l 0
+12 m 0
+13 n 0
+14 o 0
+15 p 0
+16 q 0
+17 r 0
+18 s 0
+19 t 0
+20 u 0
+21 v 0
+22 w 0
+23 x 1
+24 y 1
+25 z 1
+26 0 1
+27 1 1
+28 2 1
+29 3 1
+30 4 1
+31 5 1
+32 6 1
+33 7 1
+34 8 1
+35 9 1
+36   1
+37 a 2
+38 b 2
+39 c 2
+40 d 2
+41 e 2
+42 f 2
+43 g 2
+44 h 2
+45 i 2
+46 j 2
+47 k 2
+48 l 2
+49 m 2
+50 n 2
+51 o 2
+52 p 2
+53 q 2
+54 r 2
+55 s 2
+56 t 2
+57 u 2
+58 v 2
+59 w 2
+60 x 3
+61 y 3
+62 z 3
+63 0 3
+64 1 3
+65 2 3
+66 3 3
+67 4 3
+68 5 3
+69 6 3
+70 7 3
+71 8 3
+72 9 3
+73   3
+74 a 4
+75 b 4
+76 c 4
+77 d 4
+78 e 4
+79 f 4
+80 g 4
+81 h 4
+82 i 4
+83 j 4
+84 k 4
+85 l 4
+86 m 4
+87 n 4
+88 o 4
+89 p 4
+90 q 4
+91 r 4
+92 s 4
+93 t 4
+94 u 4
+95 v 4
+96 w 4
+97 x 5
+98 y 5
+99 z 5
+100 0 5
+101 1 5
+102 2 5
+103 3 5
+104 4 5
+105 5 5
+106 6 5
+107 7 5
+108 8 5
+109 9 5
+110 - 5
+111 a 6
+112 b 6
+113 c 6
+114 d 6
+115 e 6
+116 f 6
+117 g 6
+118 h 6
+119 i 6
+120 j 6
+121 k 6
+122 l 6
+123 m 6
+124 n 6
+125 o 6
+126 p 6
+127 q 6
+128 r 6
+129 s 6
+130 t 6
+131 u 6
+132 v 6
+133 w 6
+134 x 7
+135 y 7
+136 z 7
+137 0 7
+138 1 7
+139 2 7
+140 3 7
+141 4 7
+142 5 7
+143 6 7
+144 7 7
+145 8 7
+146 9 7
+147 - 7
+148 a 8
+149 b 8
+150 c 8
+151 d 8
+152 e 8
+153 f 8
+154 g 8
+155 h 8
+156 i 8
+157 j 8
+158 k 8
+159 l 8

[webkit-changes] [281199] trunk/Source/WebKit

[sihui_liu]

Title: [281199] trunk/Source/WebKit








Revision 281199
Author sihui_...@apple.com
Date 2021-08-18 10:45:29 -0700 (Wed, 18 Aug 2021)


Log Message
Do not terminate relaunched network process when getting network process connection
https://bugs.webkit.org/show_bug.cgi?id=229236

Reviewed by Chris Dumez.

When UI process fails to get network process connection for the first time, it will retry on next runloop
iteration. On the retry, it terminates existing network process and relaunch a network process, because the
failure may indicate something is wrong in the network process. If existing network process is different from
the one on first try, the existing process can be functional and we should not terminate it.

* UIProcess/WebsiteData/WebsiteDataStore.cpp:
(WebKit::WebsiteDataStore::getNetworkProcessConnection):

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.cpp




Diff

Modified: trunk/Source/WebKit/ChangeLog (281198 => 281199)

--- trunk/Source/WebKit/ChangeLog	2021-08-18 17:42:30 UTC (rev 281198)
+++ trunk/Source/WebKit/ChangeLog	2021-08-18 17:45:29 UTC (rev 281199)
@@ -1,3 +1,18 @@
+2021-08-18  Sihui Liu  
+
+Do not terminate relaunched network process when getting network process connection
+https://bugs.webkit.org/show_bug.cgi?id=229236
+
+Reviewed by Chris Dumez.
+
+When UI process fails to get network process connection for the first time, it will retry on next runloop 
+iteration. On the retry, it terminates existing network process and relaunch a network process, because the 
+failure may indicate something is wrong in the network process. If existing network process is different from 
+the one on first try, the existing process can be functional and we should not terminate it.
+
+* UIProcess/WebsiteData/WebsiteDataStore.cpp:
+(WebKit::WebsiteDataStore::getNetworkProcessConnection):
+
 2021-08-18  Michael Catanzaro  
 
 REGRESSION(r280382): [GTK] 2.33.3 does not build with gtk-doc enabled, installs broken pkg-config files


Modified: trunk/Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.cpp (281198 => 281199)

--- trunk/Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.cpp	2021-08-18 17:42:30 UTC (rev 281198)
+++ trunk/Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.cpp	2021-08-18 17:45:29 UTC (rev 281199)
@@ -1731,7 +1731,7 @@
 auto& networkProcessProxy = networkProcess();
 networkProcessProxy.getNetworkProcessConnection(webProcessProxy, [weakThis = makeWeakPtr(*this), networkProcessProxy = makeWeakPtr(networkProcessProxy), webProcessProxy = makeWeakPtr(webProcessProxy), reply = WTFMove(reply), shouldRetryOnFailure] (auto& connectionInfo) mutable {
 if (UNLIKELY(!IPC::Connection::identifierIsValid(connectionInfo.identifier( {
-auto logError = [networkProcessProxy = WTFMove(networkProcessProxy), webProcessProxy]() {
+auto logError = [networkProcessProxy, webProcessProxy]() {
 #if OS(DARWIN)
 if (!os_variant_allows_internal_security_policies("com.apple.WebKit"))
 return;
@@ -1756,9 +1756,11 @@
 }
 
 // Retry on the next RunLoop iteration because we may be inside the WebsiteDataStore destructor.
-RunLoop::main().dispatch([weakThis = WTFMove(weakThis), webProcessProxy = WTFMove(webProcessProxy), reply = WTFMove(reply), logError = WTFMove(logError)] () mutable {
+RunLoop::main().dispatch([weakThis = WTFMove(weakThis), networkProcessProxy = WTFMove(networkProcessProxy), webProcessProxy = WTFMove(webProcessProxy), reply = WTFMove(reply), logError = WTFMove(logError)] () mutable {
 if (RefPtr strongThis = weakThis.get(); strongThis && webProcessProxy) {
-strongThis->terminateNetworkProcess();
+// Terminate if it is the same network process.
+if (networkProcessProxy && strongThis->m_networkProcess == networkProcessProxy.get())
+strongThis->terminateNetworkProcess();
 RELEASE_LOG_ERROR(Process, "getNetworkProcessConnection: Failed to get connection to network process, will retry ...");
 strongThis->getNetworkProcessConnection(*webProcessProxy, WTFMove(reply), ShouldRetryOnFailure::No);
 } else {






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [281198] trunk/Source/WebCore

[simon . fraser]

Title: [281198] trunk/Source/WebCore








Revision 281198
Author simon.fra...@apple.com
Date 2021-08-18 10:42:30 -0700 (Wed, 18 Aug 2021)


Log Message
Update feature statuses in features.json
https://bugs.webkit.org/show_bug.cgi?id=229212

Reviewed by Wenson Hsieh.

Update the status of various features in features.json to reflect their current state.

Remove `"enabled-by-default": true` from features that are marked as Supported.

* features.json:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/features.json




Diff

Modified: trunk/Source/WebCore/ChangeLog (281197 => 281198)

--- trunk/Source/WebCore/ChangeLog	2021-08-18 17:19:25 UTC (rev 281197)
+++ trunk/Source/WebCore/ChangeLog	2021-08-18 17:42:30 UTC (rev 281198)
@@ -1,3 +1,16 @@
+2021-08-18  Simon Fraser  
+
+Update feature statuses in features.json
+https://bugs.webkit.org/show_bug.cgi?id=229212
+
+Reviewed by Wenson Hsieh.
+
+Update the status of various features in features.json to reflect their current state.
+
+Remove `"enabled-by-default": true` from features that are marked as Supported.
+
+* features.json:
+
 2021-08-18  Megan Gardner  
 
 Add Highlight API to features.json


Modified: trunk/Source/WebCore/features.json (281197 => 281198)

--- trunk/Source/WebCore/features.json	2021-08-18 17:19:25 UTC (rev 281197)
+++ trunk/Source/WebCore/features.json	2021-08-18 17:42:30 UTC (rev 281198)
@@ -64,9 +64,10 @@
 {
 "name": "CSS Aspect ratio property",
 "status": {
-"status": "In Development"
+"status": "Supported"
 },
 "url": "https://drafts.csswg.org/css-sizing-4/#aspect-ratio",
+"webkit-url": "https://bugs.webkit.org/show_bug.cgi?id=47738",
 "keywords": ["css", "css-sizing", "aspect-ratio"],
 "category": "css"
 },
@@ -73,8 +74,7 @@
 {
 "name": "CSS Color Level 4",
 "status": {
-"status": "Supported",
-"enabled-by-default": true
+"status": "Supported"
 },
 "url": "https://drafts.csswg.org/css-color/",
 "keywords": ["css color", "color"],
@@ -84,10 +84,11 @@
 {
 "name": "CSS Containment Level 1",
 "status": {
-"status": "Under Consideration",
+"status": "In Development",
 "enabled-by-default": false
 },
 "url": "https://www.w3.org/TR/css-contain-1/",
+"webkit-url": "https://bugs.webkit.org/show_bug.cgi?id=172026",
 "keywords": ["css containment", "contain", "content", "layout", "size", "paint"],
 "category": "css",
 "description": "Allows content to specify that an element’s subtree is independent of the rest of the page to allow for optimizations by the browser."
@@ -121,6 +122,9 @@
 },
 {
 "name": "CSS Fonts Level 4",
+"status": {
+"status": "Partially Supported"
+},
 "url": "https://drafts.csswg.org/css-fonts-4/",
 "keywords": ["css fonts", "fonts"],
 "category": "css",
@@ -133,8 +137,7 @@
 {
 "name": "CSS Grid Layout Level 1",
 "status": {
-"status": "Supported",
-"enabled-by-default": true
+"status": "Supported"
 },
 "url": "http://dev.w3.org/csswg/css-grid/",
 "webkit-url": "https://bugs.webkit.org/show_bug.cgi?id=60731",
@@ -154,8 +157,7 @@
 {
 "name": "CSS Inline Layout Module Level 3",
 "status": {
-"status": "Supported",
-"enabled-by-default": true
+"status": "Supported"
 },
 "url": "http://dev.w3.org/csswg/css-inline/",
 "keywords": ["css inline layout", "css inline", "inline"],
@@ -187,8 +189,7 @@
 "name": "CSS Masking Level 1",
 "url": "https://drafts.fxtf.org/css-masking-1/",
 "status": {
-"status": "In Development",
-"enabled-by-default": true
+"status": "In Development"
 },
 "keywords": ["css masking", "clip-path", "clipping", "masking", "mask"],
 "category": "css",
@@ -250,8 +251,7 @@
 {
 "name": "CSS Scroll Snap Points Module Level 1",
 "status": {
-"status": "Supported",
-"enabled-by-default": true
+"status": "Supported"
 },
 "url": "http://dev.w3.org/csswg/css-snappoints/",
 "webkit-url": "https://bugs.webkit.org/show_bug.cgi?id=134283",
@@ -276,8 +276,7 @@
 {
 "name": "CSS Shadow Parts",
 "status": {
-"status": "Supported",
-"enabled-by-default": true
+"status": "Supported"
 },
 "url": "https://drafts.csswg.org/css-shadow-parts/",
 "webkit-url": "https://webkit.org/b/149443",
@@ -293,8 +292,7 @@
 {
 "name": "CSS Text Decoration Level 4",
 "status": {
-"status": "Supported",

[webkit-changes] [281197] trunk/Tools

[jbedard]

Title: [281197] trunk/Tools








Revision 281197
Author jbed...@apple.com
Date 2021-08-18 10:19:25 -0700 (Wed, 18 Aug 2021)


Log Message
[git-webkit] "IndexError: list index out of range" using log
https://bugs.webkit.org/show_bug.cgi?id=229232

Reviewed by Ryan Haddad.

* Scripts/libraries/webkitscmpy/setup.py: Bump version.
* Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py: Ditto.
* Scripts/libraries/webkitscmpy/webkitscmpy/program/command.py:
(FilteredCommand.pager):

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/libraries/webkitscmpy/setup.py
trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py
trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/command.py




Diff

Modified: trunk/Tools/ChangeLog (281196 => 281197)

--- trunk/Tools/ChangeLog	2021-08-18 17:16:10 UTC (rev 281196)
+++ trunk/Tools/ChangeLog	2021-08-18 17:19:25 UTC (rev 281197)
@@ -1,3 +1,15 @@
+2021-08-18  Jonathan Bedard  
+
+[git-webkit] "IndexError: list index out of range" using log
+https://bugs.webkit.org/show_bug.cgi?id=229232
+
+Reviewed by Ryan Haddad.
+
+* Scripts/libraries/webkitscmpy/setup.py: Bump version.
+* Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py: Ditto.
+* Scripts/libraries/webkitscmpy/webkitscmpy/program/command.py:
+(FilteredCommand.pager):
+
 2021-08-18  Michael Catanzaro  
 
 REGRESSION(r280382): [GTK] 2.33.3 does not build with gtk-doc enabled, installs broken pkg-config files


Modified: trunk/Tools/Scripts/libraries/webkitscmpy/setup.py (281196 => 281197)

--- trunk/Tools/Scripts/libraries/webkitscmpy/setup.py	2021-08-18 17:16:10 UTC (rev 281196)
+++ trunk/Tools/Scripts/libraries/webkitscmpy/setup.py	2021-08-18 17:19:25 UTC (rev 281197)
@@ -29,7 +29,7 @@
 
 setup(
 name='webkitscmpy',
-version='1.1.2',
+version='1.1.3',
 description='Library designed to interact with git and svn repositories.',
 long_description=readme(),
 classifiers=[


Modified: trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py (281196 => 281197)

--- trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py	2021-08-18 17:16:10 UTC (rev 281196)
+++ trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py	2021-08-18 17:19:25 UTC (rev 281197)
@@ -46,7 +46,7 @@
 "Please install webkitcorepy with `pip install webkitcorepy --extra-index-url `"
 )
 
-version = Version(1, 1, 2)
+version = Version(1, 1, 3)
 
 AutoInstall.register(Package('fasteners', Version(0, 15, 0)))
 AutoInstall.register(Package('monotonic', Version(1, 5)))


Modified: trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/command.py (281196 => 281197)

--- trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/command.py	2021-08-18 17:16:10 UTC (rev 281196)
+++ trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/command.py	2021-08-18 17:19:25 UTC (rev 281197)
@@ -122,7 +122,7 @@
 stdout=subprocess.PIPE,
 stderr=subprocess.PIPE,
 )
-more = subprocess.Popen([which('more')] + ['-F', '-R'] if platform.system() == 'Darwin' else [], stdin=child.stdout)
+more = subprocess.Popen([which('more')] + (['-F', '-R'] if platform.system() == 'Darwin' else []), stdin=child.stdout)
 
 try:
 while more.poll() is None and not child.poll():






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [281196] trunk/Source/WebCore

[megan_gardner]

Title: [281196] trunk/Source/WebCore








Revision 281196
Author megan_gard...@apple.com
Date 2021-08-18 10:16:10 -0700 (Wed, 18 Aug 2021)


Log Message
Add Highlight API to features.json
https://bugs.webkit.org/show_bug.cgi?id=208226

Reviewed by Simon Fraser.

* features.json:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/features.json




Diff

Modified: trunk/Source/WebCore/ChangeLog (281195 => 281196)

--- trunk/Source/WebCore/ChangeLog	2021-08-18 16:58:52 UTC (rev 281195)
+++ trunk/Source/WebCore/ChangeLog	2021-08-18 17:16:10 UTC (rev 281196)
@@ -1,3 +1,12 @@
+2021-08-18  Megan Gardner  
+
+Add Highlight API to features.json
+https://bugs.webkit.org/show_bug.cgi?id=208226
+
+Reviewed by Simon Fraser.
+
+* features.json:
+
 2021-08-18  Jer Noble  
 
 REGRESSION(r280723): Protected HLS + EME playback fails with "temporary error"


Modified: trunk/Source/WebCore/features.json (281195 => 281196)

--- trunk/Source/WebCore/features.json	2021-08-18 16:58:52 UTC (rev 281195)
+++ trunk/Source/WebCore/features.json	2021-08-18 17:16:10 UTC (rev 281196)
@@ -93,6 +93,17 @@
 "description": "Allows content to specify that an element’s subtree is independent of the rest of the page to allow for optimizations by the browser."
 },
 {
+"name": "CSS Custom Highlight API Module Level 1",
+"status": {
+"status": "In Development",
+"enabled-by-default": false
+},
+"url": "https://drafts.csswg.org/css-highlight-api-1/",
+"keywords": ["css pseudo-element", "highlight"],
+"category": "css",
+"description": "A mechanism for styling arbitrary ranges of a document identified by script."
+},
+{
 "name": "CSS Font Display",
 "status": {
 "status": "Supported",






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [281195] trunk/LayoutTests

[wenson_hsieh]

Title: [281195] trunk/LayoutTests








Revision 281195
Author wenson_hs...@apple.com
Date 2021-08-18 09:58:52 -0700 (Wed, 18 Aug 2021)


Log Message
Add a layout test for webkit.org/b/229200
https://bugs.webkit.org/show_bug.cgi?id=229222
rdar://81636256

Reviewed by Simon Fraser.

Add a layout test to exercise the hang fixed in bug #229200. This test can be manually run by opening it in
browser and verifying that the page does not hang (and outputs the expected PASS messages).

* fast/canvas/draw-text-repeatedly-into-disconnected-canvas-expected.txt: Added.
* fast/canvas/draw-text-repeatedly-into-disconnected-canvas.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog


Added Paths

trunk/LayoutTests/fast/canvas/draw-text-repeatedly-into-disconnected-canvas-expected.txt
trunk/LayoutTests/fast/canvas/draw-text-repeatedly-into-disconnected-canvas.html




Diff

Modified: trunk/LayoutTests/ChangeLog (281194 => 281195)

--- trunk/LayoutTests/ChangeLog	2021-08-18 16:58:30 UTC (rev 281194)
+++ trunk/LayoutTests/ChangeLog	2021-08-18 16:58:52 UTC (rev 281195)
@@ -1,3 +1,17 @@
+2021-08-18  Wenson Hsieh  
+
+Add a layout test for webkit.org/b/229200
+https://bugs.webkit.org/show_bug.cgi?id=229222
+rdar://81636256
+
+Reviewed by Simon Fraser.
+
+Add a layout test to exercise the hang fixed in bug #229200. This test can be manually run by opening it in
+browser and verifying that the page does not hang (and outputs the expected PASS messages).
+
+* fast/canvas/draw-text-repeatedly-into-disconnected-canvas-expected.txt: Added.
+* fast/canvas/draw-text-repeatedly-into-disconnected-canvas.html: Added.
+
 2021-08-18  Eric Hutchison  
 
 [Mac wk1] css/css-position/position-relative-table* tests fail.


Added: trunk/LayoutTests/fast/canvas/draw-text-repeatedly-into-disconnected-canvas-expected.txt (0 => 281195)

--- trunk/LayoutTests/fast/canvas/draw-text-repeatedly-into-disconnected-canvas-expected.txt	(rev 0)
+++ trunk/LayoutTests/fast/canvas/draw-text-repeatedly-into-disconnected-canvas-expected.txt	2021-08-18 16:58:52 UTC (rev 281195)
@@ -0,0 +1,5 @@
+PASS Done painting
+PASS successfullyParsed is true
+
+TEST COMPLETE
+


Added: trunk/LayoutTests/fast/canvas/draw-text-repeatedly-into-disconnected-canvas.html (0 => 281195)

--- trunk/LayoutTests/fast/canvas/draw-text-repeatedly-into-disconnected-canvas.html	(rev 0)
+++ trunk/LayoutTests/fast/canvas/draw-text-repeatedly-into-disconnected-canvas.html	2021-08-18 16:58:52 UTC (rev 281195)
@@ -0,0 +1,61 @@
+
+
+
+
+jsTestIsAsync = true;
+addEventListener("load", async () => {
+await document.fonts.load("16px Ahem");
+
+for (let i = 0; i < 3; ++i)
+await paintIntoCanvas();
+
+await paintIntoCanvas(document.getElementById("final-target"));
+
+testPassed("Done painting");
+finishJSTest();
+});
+
+async function paintIntoCanvas(target) {
+let canvas = target || document.createElement("canvas");
+let context = canvas.getContext("2d");
+
+context.font = "16px Ahem";
+context.strokeText("Hello world", 10, 10);
+context.strokeText("Hello world", 20, 20);
+
+for (let i = 0; i < 5; ++i)
+await UIHelper.renderingUpdate();
+
+delete context;
+delete canvas;
+gc();
+}
+
+function gc() {
+if (window.GCController)
+return GCController.collect();
+
+let strings = [];
+for (let i = 0; i < 100; ++i)
+strings.push(new String(i));
+}
+
+
+@font-face {
+font-family: Ahem;
+src: url("../../resources/Ahem.ttf");
+}
+
+canvas {
+width: 400px;
+height: 400px;
+margin-top: 0;
+}
+
+
+
+
+
+
\ No newline at end of file






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [281194] trunk/LayoutTests

[ehutchison]

Title: [281194] trunk/LayoutTests








Revision 281194
Author ehutchi...@apple.com
Date 2021-08-18 09:58:30 -0700 (Wed, 18 Aug 2021)


Log Message
[Mac wk1] css/css-position/position-relative-table* tests fail.
https://bugs.webkit.org/show_bug.cgi?id=203449.

Unreviewed test gardening.

* platform/mac-wk1/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac-wk1/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (281193 => 281194)

--- trunk/LayoutTests/ChangeLog	2021-08-18 16:50:30 UTC (rev 281193)
+++ trunk/LayoutTests/ChangeLog	2021-08-18 16:58:30 UTC (rev 281194)
@@ -1,3 +1,12 @@
+2021-08-18  Eric Hutchison  
+
+[Mac wk1] css/css-position/position-relative-table* tests fail.
+https://bugs.webkit.org/show_bug.cgi?id=203449.
+
+Unreviewed test gardening.
+
+* platform/mac-wk1/TestExpectations:
+
 2021-08-18  Ayumi Kojima  
 
 [ MacOS EWS ] inspector/canvas/recording-2d-memoryLimit.html is flaky crashing..


Modified: trunk/LayoutTests/platform/mac-wk1/TestExpectations (281193 => 281194)

--- trunk/LayoutTests/platform/mac-wk1/TestExpectations	2021-08-18 16:50:30 UTC (rev 281193)
+++ trunk/LayoutTests/platform/mac-wk1/TestExpectations	2021-08-18 16:58:30 UTC (rev 281194)
@@ -1376,6 +1376,10 @@
 
 webkit.org/b/229058 imported/w3c/web-platform-tests/FileAPI/url/url-in-tags.window.html [ Pass Failure ]
 
+#webkit.org/b/203449 Updating test expectations for two tests
+imported/w3c/web-platform-tests/css/css-position/position-relative-003.html [ Pass ImageOnlyFailure ]
+imported/w3c/web-platform-tests/css/css-position/position-relative-004.html [ Pass ImageOnlyFailure ]
+
 #rdar://82039288 ([Monterey wk1 Debug] inspector/timeline/timeline-event-TimerInstall.html is a flaky crash)
 inspector/timeline/timeline-event-TimerInstall.html [ Pass Crash ] 
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [281193] trunk/Source/WebCore

[jer . noble]

Title: [281193] trunk/Source/WebCore








Revision 281193
Author jer.no...@apple.com
Date 2021-08-18 09:50:30 -0700 (Wed, 18 Aug 2021)


Log Message
REGRESSION(r280723): Protected HLS + EME playback fails with "temporary error"
https://bugs.webkit.org/show_bug.cgi?id=229201


Reviewed by Eric Carlson.

In r280723, we stopped unconditionally creating an AVPlayerLayer when we create an AVPlayer. However,
we will still create an AVPlayerItemVideoOutput when we create an AVPlayerItem. This leaves our
AVPlayer in a state where AVFoundation will throw a "temporary error; try again later" when given
an otherwise valid protected HLS stream and key data through EME.

To work around this behavior, delay creating the AVPlayerItemVideoOutput until explicitly told to
create video renderers, typically simultaneous to creating an AVPlayerLayer.

* platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayerItem):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm




Diff

Modified: trunk/Source/WebCore/ChangeLog (281192 => 281193)

--- trunk/Source/WebCore/ChangeLog	2021-08-18 16:46:34 UTC (rev 281192)
+++ trunk/Source/WebCore/ChangeLog	2021-08-18 16:50:30 UTC (rev 281193)
@@ -1,3 +1,22 @@
+2021-08-18  Jer Noble  
+
+REGRESSION(r280723): Protected HLS + EME playback fails with "temporary error"
+https://bugs.webkit.org/show_bug.cgi?id=229201
+
+
+Reviewed by Eric Carlson.
+
+In r280723, we stopped unconditionally creating an AVPlayerLayer when we create an AVPlayer. However,
+we will still create an AVPlayerItemVideoOutput when we create an AVPlayerItem. This leaves our
+AVPlayer in a state where AVFoundation will throw a "temporary error; try again later" when given
+an otherwise valid protected HLS stream and key data through EME.
+
+To work around this behavior, delay creating the AVPlayerItemVideoOutput until explicitly told to
+create video renderers, typically simultaneous to creating an AVPlayerLayer.
+
+* platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
+(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayerItem):
+
 2021-08-18  Martin Robinson  
 
 [css-scroll-snap] Don't snap to offscreen snap areas in unidirectional scrolls


Modified: trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm (281192 => 281193)

--- trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm	2021-08-18 16:46:34 UTC (rev 281192)
+++ trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm	2021-08-18 16:50:30 UTC (rev 281193)
@@ -1160,8 +1160,6 @@
 }
 #endif
 
-createVideoOutput();
-
 m_metadataCollector = adoptNS([PAL::allocAVPlayerItemMetadataCollectorInstance() initWithIdentifiers:nil classifyingLabels:nil]);
 [m_metadataCollector.get() setDelegate:m_objcObserver.get() queue:dispatch_get_main_queue()];
 [m_avPlayerItem.get() addMediaDataCollector:m_metadataCollector.get()];






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [281192] trunk

[commit-queue]

Title: [281192] trunk








Revision 281192
Author commit-qu...@webkit.org
Date 2021-08-18 09:46:34 -0700 (Wed, 18 Aug 2021)


Log Message
REGRESSION(r280382): [GTK] 2.33.3 does not build with gtk-doc enabled, installs broken pkg-config files
https://bugs.webkit.org/show_bug.cgi?id=229152

Patch by Michael Catanzaro  on 2021-08-18
Reviewed by Philippe Normand.

Source/_javascript_Core:

* PlatformGTK.cmake:
* _javascript_coregtk.pc.in:

Source/WebKit:

CMake is expanding templates in the pkg-config files that are not supposed to be expanded.
Oops! Let's switch back to using @SVN_REVISION@ instead of ${SVN_REVISION} as the template
for inserting the SVN revision into the pkg-config file, so we can tell CMake to leave the
${} variables alone.

* PlatformGTK.cmake:
* PlatformWPE.cmake:
* Shared/glib/BuildRevision.h.in:
* gtk/webkit2gtk-web-extension.pc.in:
* gtk/webkit2gtk.pc.in:

Tools:

* glib/apply-build-revision-to-files.py:
(main):

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/PlatformGTK.cmake
trunk/Source/_javascript_Core/_javascript_coregtk.pc.in
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/PlatformGTK.cmake
trunk/Source/WebKit/PlatformWPE.cmake
trunk/Source/WebKit/Shared/glib/BuildRevision.h.in
trunk/Source/WebKit/gtk/webkit2gtk-web-extension.pc.in
trunk/Source/WebKit/gtk/webkit2gtk.pc.in
trunk/Tools/ChangeLog
trunk/Tools/glib/apply-build-revision-to-files.py




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (281191 => 281192)

--- trunk/Source/_javascript_Core/ChangeLog	2021-08-18 16:34:05 UTC (rev 281191)
+++ trunk/Source/_javascript_Core/ChangeLog	2021-08-18 16:46:34 UTC (rev 281192)
@@ -1,3 +1,13 @@
+2021-08-18  Michael Catanzaro  
+
+REGRESSION(r280382): [GTK] 2.33.3 does not build with gtk-doc enabled, installs broken pkg-config files
+https://bugs.webkit.org/show_bug.cgi?id=229152
+
+Reviewed by Philippe Normand.
+
+* PlatformGTK.cmake:
+* _javascript_coregtk.pc.in:
+
 2021-08-17  Saam Barati  
 
 Add an option for canonicalizePrePostIncrements


Modified: trunk/Source/_javascript_Core/PlatformGTK.cmake (281191 => 281192)

--- trunk/Source/_javascript_Core/PlatformGTK.cmake	2021-08-18 16:34:05 UTC (rev 281191)
+++ trunk/Source/_javascript_Core/PlatformGTK.cmake	2021-08-18 16:46:34 UTC (rev 281192)
@@ -3,8 +3,9 @@
 
 set(_javascript_Core_OUTPUT_NAME _javascript_coregtk-${WEBKITGTK_API_VERSION})
 
+configure_file(_javascript_coregtk.pc.in ${_javascript_Core_PKGCONFIG_FILE} @ONLY)
+
 if (EXISTS "${TOOLS_DIR}/glib/apply-build-revision-to-files.py")
-configure_file(_javascript_coregtk.pc.in ${_javascript_Core_PKGCONFIG_FILE} @ONLY)
 add_custom_target(_javascript_Core-build-revision
 ${PYTHON_EXECUTABLE} "${TOOLS_DIR}/glib/apply-build-revision-to-files.py" ${_javascript_Core_PKGCONFIG_FILE}
 DEPENDS ${_javascript_Core_PKGCONFIG_FILE}
@@ -12,8 +13,6 @@
 list(APPEND _javascript_Core_DEPENDENCIES
 _javascript_Core-build-revision
 )
-else ()
-configure_file(_javascript_coregtk.pc.in ${_javascript_Core_PKGCONFIG_FILE})
 endif ()
 
 install(FILES "${CMAKE_BINARY_DIR}/Source/_javascript_Core/_javascript_coregtk-${WEBKITGTK_API_VERSION}.pc"


Modified: trunk/Source/_javascript_Core/_javascript_coregtk.pc.in (281191 => 281192)

--- trunk/Source/_javascript_Core/_javascript_coregtk.pc.in	2021-08-18 16:34:05 UTC (rev 281191)
+++ trunk/Source/_javascript_Core/_javascript_coregtk.pc.in	2021-08-18 16:46:34 UTC (rev 281192)
@@ -2,7 +2,7 @@
 exec_prefix=${prefix}
 libdir=@LIB_INSTALL_DIR@
 includedir=${prefix}/include
-revision=${BUILD_REVISION}
+revision=@BUILD_REVISION@
 
 Name: _javascript_CoreGTK+
 Description: GTK+ version of the _javascript_Core engine


Modified: trunk/Source/WebKit/ChangeLog (281191 => 281192)

--- trunk/Source/WebKit/ChangeLog	2021-08-18 16:34:05 UTC (rev 281191)
+++ trunk/Source/WebKit/ChangeLog	2021-08-18 16:46:34 UTC (rev 281192)
@@ -1,3 +1,21 @@
+2021-08-18  Michael Catanzaro  
+
+REGRESSION(r280382): [GTK] 2.33.3 does not build with gtk-doc enabled, installs broken pkg-config files
+https://bugs.webkit.org/show_bug.cgi?id=229152
+
+Reviewed by Philippe Normand.
+
+CMake is expanding templates in the pkg-config files that are not supposed to be expanded.
+Oops! Let's switch back to using @SVN_REVISION@ instead of ${SVN_REVISION} as the template
+for inserting the SVN revision into the pkg-config file, so we can tell CMake to leave the
+${} variables alone.
+
+* PlatformGTK.cmake:
+* PlatformWPE.cmake:
+* Shared/glib/BuildRevision.h.in:
+* gtk/webkit2gtk-web-extension.pc.in:
+* gtk/webkit2gtk.pc.in:
+
 2021-08-18  Wenson Hsieh  
 
 REGRESSION (iOS 15): DoubleDown Casino app won't load past launch page


Modified: trunk/Source/WebKit/PlatformGTK.cmake (281191 => 281192)

--- trunk/Source/WebKit/PlatformGTK.cmake	2021-08-18 16:34:05 UTC 

[webkit-changes] [281191] trunk/Tools

[jbedard]

Title: [281191] trunk/Tools








Revision 281191
Author jbed...@apple.com
Date 2021-08-18 09:34:05 -0700 (Wed, 18 Aug 2021)


Log Message
[webkitcorepy] Add CallByNeed object
https://bugs.webkit.org/show_bug.cgi?id=229148


Reviewed by Dewei Zhu.

* Scripts/libraries/webkitcorepy/setup.py: Bump version.
* Scripts/libraries/webkitcorepy/webkitcorepy/__init__.py: Bump version, export Defer object.
* Scripts/libraries/webkitcorepy/webkitcorepy/call_by_need.py: Added.
(CallByNeed):
(CallByNeed.__init__):
(CallByNeed.__getattribute__): Depending on the request attribute, either return it or attempt to
resolve the underlying value before returning the attribute of the resolved value.
(CallByNeed.value): Resolve and return underlying object.
(CallByNeed.__call__): Ditto.
(CallByNeed.__repr__): Resolve object and return representation.
(CallByNeed.__str__): Resolve object and return string conversion.
* Scripts/libraries/webkitcorepy/webkitcorepy/tests/call_by_need_unittest.py: Added.
(TestCallByNeed):
(TestCallByNeed.test_basic):
(TestCallByNeed.test_string_conversion):
(TestCallByNeed.test_attribute_forwarding):
(TestCallByNeed.test_failed_attribute_forwarding):

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/libraries/webkitcorepy/setup.py
trunk/Tools/Scripts/libraries/webkitcorepy/webkitcorepy/__init__.py


Added Paths

trunk/Tools/Scripts/libraries/webkitcorepy/webkitcorepy/call_by_need.py
trunk/Tools/Scripts/libraries/webkitcorepy/webkitcorepy/tests/call_by_need_unittest.py




Diff

Modified: trunk/Tools/ChangeLog (281190 => 281191)

--- trunk/Tools/ChangeLog	2021-08-18 16:22:18 UTC (rev 281190)
+++ trunk/Tools/ChangeLog	2021-08-18 16:34:05 UTC (rev 281191)
@@ -1,3 +1,29 @@
+2021-08-18  Jonathan Bedard  
+
+[webkitcorepy] Add CallByNeed object
+https://bugs.webkit.org/show_bug.cgi?id=229148
+
+
+Reviewed by Dewei Zhu.
+
+* Scripts/libraries/webkitcorepy/setup.py: Bump version.
+* Scripts/libraries/webkitcorepy/webkitcorepy/__init__.py: Bump version, export Defer object.
+* Scripts/libraries/webkitcorepy/webkitcorepy/call_by_need.py: Added.
+(CallByNeed):
+(CallByNeed.__init__):
+(CallByNeed.__getattribute__): Depending on the request attribute, either return it or attempt to
+resolve the underlying value before returning the attribute of the resolved value.
+(CallByNeed.value): Resolve and return underlying object.
+(CallByNeed.__call__): Ditto.
+(CallByNeed.__repr__): Resolve object and return representation.
+(CallByNeed.__str__): Resolve object and return string conversion.
+* Scripts/libraries/webkitcorepy/webkitcorepy/tests/call_by_need_unittest.py: Added.
+(TestCallByNeed):
+(TestCallByNeed.test_basic):
+(TestCallByNeed.test_string_conversion):
+(TestCallByNeed.test_attribute_forwarding):
+(TestCallByNeed.test_failed_attribute_forwarding):
+
 2021-08-18  Martin Robinson  
 
 [Flatpak SDK] Increase the startup performance of webkit-flatpak


Modified: trunk/Tools/Scripts/libraries/webkitcorepy/setup.py (281190 => 281191)

--- trunk/Tools/Scripts/libraries/webkitcorepy/setup.py	2021-08-18 16:22:18 UTC (rev 281190)
+++ trunk/Tools/Scripts/libraries/webkitcorepy/setup.py	2021-08-18 16:34:05 UTC (rev 281191)
@@ -1,4 +1,4 @@
-# Copyright (C) 2020 Apple Inc. All rights reserved.
+# Copyright (C) 2020-2021 Apple Inc. All rights reserved.
 #
 # Redistribution and use in source and binary forms, with or without
 # modification, are permitted provided that the following conditions
@@ -30,7 +30,7 @@
 
 setup(
 name='webkitcorepy',
-version='0.8.3',
+version='0.9.0',
 description='Library containing various Python support classes and functions.',
 long_description=readme(),
 classifiers=[


Modified: trunk/Tools/Scripts/libraries/webkitcorepy/webkitcorepy/__init__.py (281190 => 281191)

--- trunk/Tools/Scripts/libraries/webkitcorepy/webkitcorepy/__init__.py	2021-08-18 16:22:18 UTC (rev 281190)
+++ trunk/Tools/Scripts/libraries/webkitcorepy/webkitcorepy/__init__.py	2021-08-18 16:34:05 UTC (rev 281191)
@@ -39,8 +39,9 @@
 from webkitcorepy.credentials import credentials
 from webkitcorepy.measure_time import MeasureTime
 from webkitcorepy.nested_fuzzy_dict import NestedFuzzyDict
+from webkitcorepy.call_by_need import CallByNeed
 
-version = Version(0, 8, 3)
+version = Version(0, 9, 0)
 
 from webkitcorepy.autoinstall import Package, AutoInstall
 if sys.version_info > (3, 0):


Added: trunk/Tools/Scripts/libraries/webkitcorepy/webkitcorepy/call_by_need.py (0 => 281191)

--- trunk/Tools/Scripts/libraries/webkitcorepy/webkitcorepy/call_by_need.py	(rev 0)
+++ trunk/Tools/Scripts/libraries/webkitcorepy/webkitcorepy/call_by_need.py	2021-08-18 16:34:05 UTC (rev 281191)
@@ -0,0 +1,56 @@
+# Copyright (C) 2021 Apple Inc. All rights reserved.
+#
+# Redistribution and use in source and binary 

[webkit-changes] [281190] trunk/LayoutTests

[ayumi_kojima]

Title: [281190] trunk/LayoutTests








Revision 281190
Author ayumi_koj...@apple.com
Date 2021-08-18 09:22:18 -0700 (Wed, 18 Aug 2021)


Log Message
[ MacOS EWS ] inspector/canvas/recording-2d-memoryLimit.html is flaky crashing..
https://bugs.webkit.org/show_bug.cgi?id=229237

Unreviewed test gardening.

* platform/mac-wk2/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac-wk2/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (281189 => 281190)

--- trunk/LayoutTests/ChangeLog	2021-08-18 15:59:48 UTC (rev 281189)
+++ trunk/LayoutTests/ChangeLog	2021-08-18 16:22:18 UTC (rev 281190)
@@ -1,3 +1,12 @@
+2021-08-18  Ayumi Kojima  
+
+[ MacOS EWS ] inspector/canvas/recording-2d-memoryLimit.html is flaky crashing..
+https://bugs.webkit.org/show_bug.cgi?id=229237
+
+Unreviewed test gardening.
+
+* platform/mac-wk2/TestExpectations:
+
 2021-08-18  Martin Robinson  
 
 position: sticky with display: inline-block


Modified: trunk/LayoutTests/platform/mac-wk2/TestExpectations (281189 => 281190)

--- trunk/LayoutTests/platform/mac-wk2/TestExpectations	2021-08-18 15:59:48 UTC (rev 281189)
+++ trunk/LayoutTests/platform/mac-wk2/TestExpectations	2021-08-18 16:22:18 UTC (rev 281190)
@@ -1534,6 +1534,7 @@
 webkit.org/b/229043 inspector/canvas/recording-webgl-snapshots.html [ Pass Failure ]
 webkit.org/b/229043 inspector/canvas/recording-bitmaprenderer-frameCount.html [ Pass Failure ]
 webkit.org/b/229043 inspector/canvas/recording-2d-full.html [ Pass Crash ]
+webkit.org/b/229237 inspector/canvas/recording-2d-memoryLimit.html [ Pass Crash ]
 
 webkit.org/b/228210 [ Debug ] inspector/model/remote-object/iterator-large.html [ Pass Timeout ]
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [281189] trunk

[mrobinson]

Title: [281189] trunk








Revision 281189
Author mrobin...@webkit.org
Date 2021-08-18 08:59:48 -0700 (Wed, 18 Aug 2021)


Log Message
[css-scroll-snap] Don't snap to offscreen snap areas in unidirectional scrolls
https://bugs.webkit.org/show_bug.cgi?id=227949


Reviewed by Frédéric Wang.

LayoutTests/imported/w3c:

* web-platform-tests/css/css-scroll-snap/snap-to-visible-areas-both-expected.txt: This bidirectional
scrolling test no longer snaps because we don't have support for choosing between two candidates
properly yet.
* web-platform-tests/css/css-scroll-snap/snap-to-visible-areas-x-axis-expected.txt: Updated to show newly passing test.
* web-platform-tests/css/css-scroll-snap/snap-to-visible-areas-y-axis-expected.txt: Ditto.

Source/WebCore:

No new tests. This is covered by two existing WPT tests.

* page/scrolling/ScrollSnapOffsetsInfo.cpp:
(WebCore::componentForAxis): Added this helper.
(WebCore::hasCompatibleSnapArea): Added this helper that checks to see if any of the snap areas
at a given scroll snap position are compatible with the viewport.
(WebCore::adjustPreviousAndNextForOnscreenSnapAreas): Adjusts the selected previous and next snap
positions by looking backward and forward for the first compatible snap position.
(WebCore::closestSnapOffsetWithInfoAndAxis): Use the new helper.

Modified Paths

trunk/LayoutTests/imported/w3c/ChangeLog
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-scroll-snap/snap-to-visible-areas-both-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-scroll-snap/snap-to-visible-areas-x-axis-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-scroll-snap/snap-to-visible-areas-y-axis-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/scrolling/ScrollSnapOffsetsInfo.cpp




Diff

Modified: trunk/LayoutTests/imported/w3c/ChangeLog (281188 => 281189)

--- trunk/LayoutTests/imported/w3c/ChangeLog	2021-08-18 15:25:04 UTC (rev 281188)
+++ trunk/LayoutTests/imported/w3c/ChangeLog	2021-08-18 15:59:48 UTC (rev 281189)
@@ -1,3 +1,17 @@
+2021-08-18  Martin Robinson  
+
+[css-scroll-snap] Don't snap to offscreen snap areas in unidirectional scrolls
+https://bugs.webkit.org/show_bug.cgi?id=227949
+
+
+Reviewed by Frédéric Wang.
+
+* web-platform-tests/css/css-scroll-snap/snap-to-visible-areas-both-expected.txt: This bidirectional
+scrolling test no longer snaps because we don't have support for choosing between two candidates
+properly yet.
+* web-platform-tests/css/css-scroll-snap/snap-to-visible-areas-x-axis-expected.txt: Updated to show newly passing test.
+* web-platform-tests/css/css-scroll-snap/snap-to-visible-areas-y-axis-expected.txt: Ditto.
+
 2021-08-17  Alex Christensen  
 
 Document load events should update timing in PerformanceNavigationTiming even after its instantiation


Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-scroll-snap/snap-to-visible-areas-both-expected.txt (281188 => 281189)

--- trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-scroll-snap/snap-to-visible-areas-both-expected.txt	2021-08-18 15:25:04 UTC (rev 281188)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-scroll-snap/snap-to-visible-areas-both-expected.txt	2021-08-18 15:59:48 UTC (rev 281189)
@@ -1,3 +1,3 @@
 
-FAIL Only snap to visible areas in the case where taking the closest snap point of   each axis does not snap to a visible area assert_equals: expected 0 but got 800
+FAIL Only snap to visible areas in the case where taking the closest snap point of   each axis does not snap to a visible area assert_equals: expected 800 but got 0
 


Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-scroll-snap/snap-to-visible-areas-x-axis-expected.txt (281188 => 281189)

--- trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-scroll-snap/snap-to-visible-areas-x-axis-expected.txt	2021-08-18 15:25:04 UTC (rev 281188)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-scroll-snap/snap-to-visible-areas-x-axis-expected.txt	2021-08-18 15:59:48 UTC (rev 281189)
@@ -1,3 +1,3 @@
 
-FAIL Only snap to visible area on X axis, even when the non-visible ones are closer assert_equals: expected 800 but got 700
+PASS Only snap to visible area on X axis, even when the non-visible ones are closer
 


Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-scroll-snap/snap-to-visible-areas-y-axis-expected.txt (281188 => 281189)

--- trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-scroll-snap/snap-to-visible-areas-y-axis-expected.txt	2021-08-18 15:25:04 UTC (rev 281188)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-scroll-snap/snap-to-visible-areas-y-axis-expected.txt	2021-08-18 15:59:48 UTC (rev 281189)
@@ -1,3 +1,3 @@
 
-FAIL Only snap to visible area on Y axis, even when the non-visible ones are closer assert_equals: expected 800 but got 700
+PASS Only snap to 

[webkit-changes] [281188] trunk/Source/WebCore

[cdumez]

Title: [281188] trunk/Source/WebCore








Revision 281188
Author cdu...@apple.com
Date 2021-08-18 08:25:04 -0700 (Wed, 18 Aug 2021)


Log Message
Crash under JSIntersectionObserverCallback::handleEvent()
https://bugs.webkit.org/show_bug.cgi?id=229196


Reviewed by Geoffrey Garen.

Early return in IntersectionObserver::notify() if the callback has already been destroyed.
This is not supposed to happen as we're supposed to be keeping the JSIntersectionObserver
wrapper alive as long as the IntersectionObserver may fire events, which should keep the
callback alive too. However, despite Ryosuke's fix in r280549, the crash is still happening
in the wild. To address the crash, I am simply doing an early return for now, similarly to
what we already do in MutationObserver::deliver(), while keeping a debug assertion around
in hope of finding the root cause at some point.

No new tests, we do not not how this is happening yet.

* page/IntersectionObserver.cpp:
(WebCore::IntersectionObserver::notify):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/LazyLoadFrameObserver.cpp
trunk/Source/WebCore/html/LazyLoadImageObserver.cpp
trunk/Source/WebCore/page/IntersectionObserver.cpp
trunk/Source/WebCore/page/IntersectionObserverCallback.h
trunk/Source/WebCore/page/ResizeObserver.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (281187 => 281188)

--- trunk/Source/WebCore/ChangeLog	2021-08-18 15:10:54 UTC (rev 281187)
+++ trunk/Source/WebCore/ChangeLog	2021-08-18 15:25:04 UTC (rev 281188)
@@ -1,3 +1,24 @@
+2021-08-18  Chris Dumez  
+
+Crash under JSIntersectionObserverCallback::handleEvent()
+https://bugs.webkit.org/show_bug.cgi?id=229196
+
+
+Reviewed by Geoffrey Garen.
+
+Early return in IntersectionObserver::notify() if the callback has already been destroyed.
+This is not supposed to happen as we're supposed to be keeping the JSIntersectionObserver
+wrapper alive as long as the IntersectionObserver may fire events, which should keep the
+callback alive too. However, despite Ryosuke's fix in r280549, the crash is still happening
+in the wild. To address the crash, I am simply doing an early return for now, similarly to
+what we already do in MutationObserver::deliver(), while keeping a debug assertion around
+in hope of finding the root cause at some point.
+
+No new tests, we do not not how this is happening yet.
+
+* page/IntersectionObserver.cpp:
+(WebCore::IntersectionObserver::notify):
+
 2021-08-18  Martin Robinson  
 
 position: sticky with display: inline-block


Modified: trunk/Source/WebCore/html/LazyLoadFrameObserver.cpp (281187 => 281188)

--- trunk/Source/WebCore/html/LazyLoadFrameObserver.cpp	2021-08-18 15:10:54 UTC (rev 281187)
+++ trunk/Source/WebCore/html/LazyLoadFrameObserver.cpp	2021-08-18 15:25:04 UTC (rev 281188)
@@ -43,6 +43,8 @@
 }
 
 private:
+bool hasCallback() const final { return true; }
+
 CallbackResult handleEvent(IntersectionObserver&, const Vector>& entries, IntersectionObserver&) final
 {
 ASSERT(!entries.isEmpty());


Modified: trunk/Source/WebCore/html/LazyLoadImageObserver.cpp (281187 => 281188)

--- trunk/Source/WebCore/html/LazyLoadImageObserver.cpp	2021-08-18 15:10:54 UTC (rev 281187)
+++ trunk/Source/WebCore/html/LazyLoadImageObserver.cpp	2021-08-18 15:25:04 UTC (rev 281188)
@@ -43,6 +43,8 @@
 }
 
 private:
+bool hasCallback() const final { return true; }
+
 CallbackResult handleEvent(IntersectionObserver&, const Vector>& entries, IntersectionObserver&) final
 {
 ASSERT(!entries.isEmpty());


Modified: trunk/Source/WebCore/page/IntersectionObserver.cpp (281187 => 281188)

--- trunk/Source/WebCore/page/IntersectionObserver.cpp	2021-08-18 15:10:54 UTC (rev 281187)
+++ trunk/Source/WebCore/page/IntersectionObserver.cpp	2021-08-18 15:25:04 UTC (rev 281188)
@@ -273,12 +273,17 @@
 return;
 }
 
+auto takenRecords = takeRecords();
+
+// FIXME: The JSIntersectionObserver wrapper should be kept alive as long as the intersection observer can fire events.
+ASSERT(m_callback->hasCallback());
+if (!m_callback->hasCallback())
+return;
+
 auto* context = m_callback->scriptExecutionContext();
 if (!context)
 return;
 
-auto takenRecords = takeRecords();
-
 InspectorInstrumentation::willFireObserverCallback(*context, "IntersectionObserver"_s);
 m_callback->handleEvent(*this, WTFMove(takenRecords.records), *this);
 InspectorInstrumentation::didFireObserverCallback(*context);


Modified: trunk/Source/WebCore/page/IntersectionObserverCallback.h (281187 => 281188)

--- trunk/Source/WebCore/page/IntersectionObserverCallback.h	2021-08-18 15:10:54 UTC (rev 281187)
+++ trunk/Source/WebCore/page/IntersectionObserverCallback.h	2021-08-18 15:25:04 UTC (rev 281188)
@@ -41,7 +41,7 @@
 public:
 using ActiveDOMCallback::ActiveDOMCallback;
 
-

[webkit-changes] [281187] branches/safari-612.1.28-branch/Source

[repstein]

Title: [281187] branches/safari-612.1.28-branch/Source








Revision 281187
Author repst...@apple.com
Date 2021-08-18 08:10:54 -0700 (Wed, 18 Aug 2021)


Log Message
Versioning.

WebKit-7612.1.28.4

Modified Paths

branches/safari-612.1.28-branch/Source/_javascript_Core/Configurations/Version.xcconfig
branches/safari-612.1.28-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig
branches/safari-612.1.28-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig
branches/safari-612.1.28-branch/Source/WebCore/Configurations/Version.xcconfig
branches/safari-612.1.28-branch/Source/WebCore/PAL/Configurations/Version.xcconfig
branches/safari-612.1.28-branch/Source/WebInspectorUI/Configurations/Version.xcconfig
branches/safari-612.1.28-branch/Source/WebKit/Configurations/Version.xcconfig
branches/safari-612.1.28-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig




Diff

Modified: branches/safari-612.1.28-branch/Source/_javascript_Core/Configurations/Version.xcconfig (281186 => 281187)

--- branches/safari-612.1.28-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2021-08-18 13:42:48 UTC (rev 281186)
+++ branches/safari-612.1.28-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2021-08-18 15:10:54 UTC (rev 281187)
@@ -24,7 +24,7 @@
 MAJOR_VERSION = 612;
 MINOR_VERSION = 1;
 TINY_VERSION = 28;
-MICRO_VERSION = 3;
+MICRO_VERSION = 4;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 


Modified: branches/safari-612.1.28-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig (281186 => 281187)

--- branches/safari-612.1.28-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig	2021-08-18 13:42:48 UTC (rev 281186)
+++ branches/safari-612.1.28-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig	2021-08-18 15:10:54 UTC (rev 281187)
@@ -24,7 +24,7 @@
 MAJOR_VERSION = 612;
 MINOR_VERSION = 1;
 TINY_VERSION = 28;
-MICRO_VERSION = 3;
+MICRO_VERSION = 4;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 


Modified: branches/safari-612.1.28-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (281186 => 281187)

--- branches/safari-612.1.28-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2021-08-18 13:42:48 UTC (rev 281186)
+++ branches/safari-612.1.28-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2021-08-18 15:10:54 UTC (rev 281187)
@@ -24,7 +24,7 @@
 MAJOR_VERSION = 612;
 MINOR_VERSION = 1;
 TINY_VERSION = 28;
-MICRO_VERSION = 3;
+MICRO_VERSION = 4;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 


Modified: branches/safari-612.1.28-branch/Source/WebCore/Configurations/Version.xcconfig (281186 => 281187)

--- branches/safari-612.1.28-branch/Source/WebCore/Configurations/Version.xcconfig	2021-08-18 13:42:48 UTC (rev 281186)
+++ branches/safari-612.1.28-branch/Source/WebCore/Configurations/Version.xcconfig	2021-08-18 15:10:54 UTC (rev 281187)
@@ -24,7 +24,7 @@
 MAJOR_VERSION = 612;
 MINOR_VERSION = 1;
 TINY_VERSION = 28;
-MICRO_VERSION = 3;
+MICRO_VERSION = 4;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 


Modified: branches/safari-612.1.28-branch/Source/WebCore/PAL/Configurations/Version.xcconfig (281186 => 281187)

--- branches/safari-612.1.28-branch/Source/WebCore/PAL/Configurations/Version.xcconfig	2021-08-18 13:42:48 UTC (rev 281186)
+++ branches/safari-612.1.28-branch/Source/WebCore/PAL/Configurations/Version.xcconfig	2021-08-18 15:10:54 UTC (rev 281187)
@@ -24,7 +24,7 @@
 MAJOR_VERSION = 612;
 MINOR_VERSION = 1;
 TINY_VERSION = 28;
-MICRO_VERSION = 3;
+MICRO_VERSION = 4;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 


Modified: branches/safari-612.1.28-branch/Source/WebInspectorUI/Configurations/Version.xcconfig (281186 => 281187)

--- branches/safari-612.1.28-branch/Source/WebInspectorUI/Configurations/Version.xcconfig	2021-08-18 13:42:48 UTC (rev 281186)
+++ branches/safari-612.1.28-branch/Source/WebInspectorUI/Configurations/Version.xcconfig	2021-08-18 15:10:54 UTC (rev 281187)
@@ -1,7 +1,7 @@
 MAJOR_VERSION = 612;
 MINOR_VERSION = 1;
 TINY_VERSION = 28;
-MICRO_VERSION = 3;
+MICRO_VERSION = 4;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 


Modified: branches/safari-612.1.28-branch/Source/WebKit/Configurations/Version.xcconfig (281186 => 281187)

--- branches/safari-612.1.28-branch/Source/WebKit/Configurations/Version.xcconfig	2021-08-18 13:42:48 UTC (rev 281186)
+++ branches/safari-612.1.28-branch/Source/WebKit/Configurations/Version.xcconfig	2021-08-18 15:10:54 UTC (rev 281187)
@@ -24,7 +24,7 @@
 MAJOR_VERSION = 612;
 MINOR_VERSION = 1;
 TINY_VERSION = 28;
-MICRO_VERSION = 3;
+MICRO_VERSION = 4;
 NANO_VERSION = 0;
 FULL_VERSION = 

[webkit-changes] [281186] trunk/Source/WebKit

[wenson_hsieh]

Title: [281186] trunk/Source/WebKit








Revision 281186
Author wenson_hs...@apple.com
Date 2021-08-18 06:42:48 -0700 (Wed, 18 Aug 2021)


Log Message
REGRESSION (iOS 15): DoubleDown Casino app won't load past launch page
https://bugs.webkit.org/show_bug.cgi?id=229200
rdar://81636256

Reviewed by Myles C. Maxfield.

The changes in https://webkit.org/b/228216 to fix rdar://80473805 introduced a mechanism to keep track of uses
of cached fonts and images in display list items in the web and GPU processes, via a `useCount` counter variable
that's incremented in the web process whenever the font or image is used in a display list item and decremented
in the GPU process whenever the item is processed.

However, the code to increment `useCount` in the web process currently only triggers at most once per rendering
update — this means that if there are multiple canvas drawing commands that use fonts in the same rendering
update, the web process' notion of `useCount` will fall out of sync with the GPU process' notion of `useCount`.

In most cases, this causes the cached font to remain for longer in the GPU process than necessary; however, in
this specific scenario, it's possible for the web process to tell the GPU process to release the cached font too
early, which causes the GPU process to prematurely purge the font from the cache, and subsequently wait for the
cached font to arrive (which will never arrive, since the web process has already released the font).

In other words, the timeline of events between the web and GPU processes looks like this (where `f` is a cached
web font, `A_f` is a drawing command that uses `f`, and `B_f` is another drawing command that uses `f`).

WEB GPU
==
1. Cache `f`
2. Append `A_f`
3. Cache `f`
4. Play back `A_f`
5. Append `B_f`
6. Release `f` (use count was 1 here)
7. Release `f` (use count dropped from 1 to 0)
8. Play back `B_f`
...and then display list playback stops due to `f` not being in
the cache.

To address this, we simply move the `useCount` increment in the web process out of the rendering update check.
The original intent of the fix for bug #228216 was to allow for `useCount` to increment as many times as needed
per rendering update, so this limitation was unintentional.

Unfortunately, I have not been able to come up with a layout test that reliably reproduces this scenario (yet).

* WebProcess/GPU/graphics/RemoteResourceCacheProxy.cpp:
(WebKit::RemoteResourceCacheProxy::recordFontUse):

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/WebProcess/GPU/graphics/RemoteResourceCacheProxy.cpp




Diff

Modified: trunk/Source/WebKit/ChangeLog (281185 => 281186)

--- trunk/Source/WebKit/ChangeLog	2021-08-18 13:30:04 UTC (rev 281185)
+++ trunk/Source/WebKit/ChangeLog	2021-08-18 13:42:48 UTC (rev 281186)
@@ -1,3 +1,50 @@
+2021-08-18  Wenson Hsieh  
+
+REGRESSION (iOS 15): DoubleDown Casino app won't load past launch page
+https://bugs.webkit.org/show_bug.cgi?id=229200
+rdar://81636256
+
+Reviewed by Myles C. Maxfield.
+
+The changes in https://webkit.org/b/228216 to fix rdar://80473805 introduced a mechanism to keep track of uses
+of cached fonts and images in display list items in the web and GPU processes, via a `useCount` counter variable
+that's incremented in the web process whenever the font or image is used in a display list item and decremented
+in the GPU process whenever the item is processed.
+
+However, the code to increment `useCount` in the web process currently only triggers at most once per rendering
+update — this means that if there are multiple canvas drawing commands that use fonts in the same rendering
+update, the web process' notion of `useCount` will fall out of sync with the GPU process' notion of `useCount`.
+
+In most cases, this causes the cached font to remain for longer in the GPU process than necessary; however, in
+this specific scenario, it's possible for the web process to tell the GPU process to release the cached font too
+early, which causes the GPU process to prematurely purge the font from the cache, and subsequently wait for the
+cached font to arrive (which will never arrive, since the web process has already released the font).
+
+In other words, the timeline of events between the web and GPU processes looks like this (where `f` is a cached
+web font, `A_f` is a drawing command that uses `f`, and `B_f` is another drawing command that uses `f`).
+
+WEB 

[webkit-changes] [281185] trunk

[mrobinson]

Title: [281185] trunk








Revision 281185
Author mrobin...@webkit.org
Date 2021-08-18 06:30:04 -0700 (Wed, 18 Aug 2021)


Log Message
position: sticky with display: inline-block
https://bugs.webkit.org/show_bug.cgi?id=224415


Reviewed by Simon Fraser.

Source/WebCore:

Improve sticky positioning applied to inline items. The first improvement is to
skip anonymous RenderBlock parents of inline display items when looking for the
containing block used to calculate sticky constraints. These anonymous parents
are not the containing block that constrains the movement of these kind of stickily
positioned items. Instead look for containing block for the anonymous parent,
which does limit the scroll boundaries of inline stickily position items.

Previously, when converting the frame rect from the coordinate space of the stickily
positioned item to that of the scrolling container, the code used to apply the offset
from the containing block to the scrolling ancestor directly to the frame rect. That
doesn't work when the containing block that determines sticky constraints is not the
direct containing block of the stickily positioned items (as it is for inlines).

Instead, the code now just maps the frame rect directly from the item parent to
the scrolling ancestor. This simplifies things a bit and allows it to work with
inline stickily positioned items.

Finally, this change adds comments to make it clearer what this method is doing.

No new tests. This is covered by existing WPT tests. Specifically the following
tests are now passing:
 imported/w3c/web-platform-tests/css/css-position/sticky/position-sticky-hyperlink.html
 imported/w3c/web-platform-tests/css/css-position/sticky/position-sticky-nested-table.html
 imported/w3c/web-platform-tests/css/css-position/sticky/position-sticky-table-parts.html
 imported/w3c/web-platform-tests/css/css-position/sticky/position-sticky-table-th-bottom.html
 imported/w3c/web-platform-tests/css/css-position/sticky/position-sticky-nested-thead-th.html

* css/CSSComputedStyleDeclaration.cpp:
(WebCore::positionOffsetValue): enclosingClippingBoxForStickyPosition now returns a pair
to avoid passing in a pointer. Only look at the first part of the pair here.
* rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::computeStickyPositionConstraints const): Modified this method
to return a pair in order to avoid dealing with input parameters. This allows simplifying this
method, making the code a bit simpler.
(WebCore::RenderBoxModelObject::enclosingClippingBoxForStickyPosition const): Deleted.
(WebCore::RenderBoxModelObject::computeStickyPositionConstraints const): Make two changes
to this method to improve sticky positioning for inline elements. The first change is
to be a bit better about finding the appropriate containing block for calculating sticky
constraints. The second is to more resiliently move from coordinate systems. In addition,
improve the comments for this method to make it clearer what is happening at each step.
* rendering/RenderBoxModelObject.h: Updated method declaration.

LayoutTests:

* TestExpectations: Unskip newly passing tests and skip one test which was
a false pass previously.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/TestExpectations
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/CSSComputedStyleDeclaration.cpp
trunk/Source/WebCore/rendering/RenderBoxModelObject.cpp
trunk/Source/WebCore/rendering/RenderBoxModelObject.h




Diff

Modified: trunk/LayoutTests/ChangeLog (281184 => 281185)

--- trunk/LayoutTests/ChangeLog	2021-08-18 09:13:47 UTC (rev 281184)
+++ trunk/LayoutTests/ChangeLog	2021-08-18 13:30:04 UTC (rev 281185)
@@ -1,3 +1,14 @@
+2021-08-18  Martin Robinson  
+
+position: sticky with display: inline-block
+https://bugs.webkit.org/show_bug.cgi?id=224415
+
+
+Reviewed by Simon Fraser.
+
+* TestExpectations: Unskip newly passing tests and skip one test which was
+a false pass previously.
+
 2021-08-17  Alex Christensen  
 
 Mark test as flaky: imported/w3c/web-platform-tests/navigation-timing/nav2_test_attributes_values.html


Modified: trunk/LayoutTests/TestExpectations (281184 => 281185)

--- trunk/LayoutTests/TestExpectations	2021-08-18 09:13:47 UTC (rev 281184)
+++ trunk/LayoutTests/TestExpectations	2021-08-18 13:30:04 UTC (rev 281185)
@@ -3482,17 +3482,13 @@
 webkit.org/b/228993 imported/w3c/web-platform-tests/css/css-position/multicol/static-position/vrl-ltr-rtl-in-multicol.tentative.html [ ImageOnlyFailure ]
 webkit.org/b/228993 imported/w3c/web-platform-tests/css/css-position/multicol/static-position/vrl-rtl-ltr-in-multicol.tentative.html [ ImageOnlyFailure ]
 webkit.org/b/228993 imported/w3c/web-platform-tests/css/css-position/multicol/static-position/vrl-rtl-rtl-in-multicol.html [ ImageOnlyFailure ]
-webkit.org/b/203450 imported/w3c/web-platform-tests/css/css-position/sticky/position-sticky-hyperlink.html [ ImageOnlyFailure ]
 webkit.org/b/203450 

[webkit-changes] [281184] trunk/Tools

[mrobinson]

Title: [281184] trunk/Tools








Revision 281184
Author mrobin...@webkit.org
Date 2021-08-18 02:13:47 -0700 (Wed, 18 Aug 2021)


Log Message
[Flatpak SDK] Increase the startup performance of webkit-flatpak
https://bugs.webkit.org/show_bug.cgi?id=229185

Reviewed by Philippe Normand.

Improve flatpakutils.py by ensuring that we don't make redundant
calls to flatpak during initialization of the data structures. This
saves 5 seconds on every call to build-webkit and run-webkit-tests.

Before:
$ time ./Tools/Scripts/webkit-flatpak -c true
real0m6,297s
user0m0,786s
sys 0m0,513s

After:
$ time ./Tools/Scripts/webkit-flatpak -c true
real0m1,243s
user0m0,375s
sys 0m0,162s

* flatpak/flatpakutils.py:
(FlatpakPackages.__init__): Separate the update into another
method so that it can be called directly when a package is installed.
Add new packages directly to self.packages.
(FlatpakRepos.__init__): Ensure that we only update our repositories
and package list once we've initialized our list of repositories.
(FlatpakRepos.add): Return True if this method actually changed anything
and accept a parameter determining whether an update is done to
the repository and package list.
(FlatpakRepos.is_package_installed): Added this method which replaces
FlatpakRepo.is_app_installed.
(FlatpakRepo.__init__): Remove the app registry because it is duplicated
by FlatpakPackages.
(FlatpakPackage.is_installed): Now call FlatpakRepos.is_package_installed.
(WebkitFlatpak._reset_repository): Set up both repositories here and
pass then as part of the FlatpakRepos constructor.
(WebkitFlatpak.main): Separate out the check which deletes the Flatpak
repository from the one that checks if the packages are installed. This
makes sure we don't install packages and then immediately delete them.
(WebkitFlatpak.check_installed_packages): rename _get_packages to _get_dependency_packages
in order to make it clear that it doesn't return installed packages.
(WebkitFlatpak._get_dependency_packages): Ditto.
(WebkitFlatpak.install_all): Ditto.
(FlatpakRepo.is_app_installed): Deleted.
(WebkitFlatpak._get_packages): Deleted.

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/flatpak/flatpakutils.py




Diff

Modified: trunk/Tools/ChangeLog (281183 => 281184)

--- trunk/Tools/ChangeLog	2021-08-18 08:26:33 UTC (rev 281183)
+++ trunk/Tools/ChangeLog	2021-08-18 09:13:47 UTC (rev 281184)
@@ -1,3 +1,52 @@
+2021-08-18  Martin Robinson  
+
+[Flatpak SDK] Increase the startup performance of webkit-flatpak
+https://bugs.webkit.org/show_bug.cgi?id=229185
+
+Reviewed by Philippe Normand.
+
+Improve flatpakutils.py by ensuring that we don't make redundant
+calls to flatpak during initialization of the data structures. This
+saves 5 seconds on every call to build-webkit and run-webkit-tests.
+
+Before:
+$ time ./Tools/Scripts/webkit-flatpak -c true
+real0m6,297s
+user0m0,786s
+sys 0m0,513s
+
+After:
+$ time ./Tools/Scripts/webkit-flatpak -c true
+real0m1,243s
+user0m0,375s
+sys 0m0,162s
+
+* flatpak/flatpakutils.py:
+(FlatpakPackages.__init__): Separate the update into another
+method so that it can be called directly when a package is installed.
+Add new packages directly to self.packages.
+(FlatpakRepos.__init__): Ensure that we only update our repositories
+and package list once we've initialized our list of repositories.
+(FlatpakRepos.add): Return True if this method actually changed anything
+and accept a parameter determining whether an update is done to
+the repository and package list.
+(FlatpakRepos.is_package_installed): Added this method which replaces
+FlatpakRepo.is_app_installed.
+(FlatpakRepo.__init__): Remove the app registry because it is duplicated
+by FlatpakPackages.
+(FlatpakPackage.is_installed): Now call FlatpakRepos.is_package_installed.
+(WebkitFlatpak._reset_repository): Set up both repositories here and
+pass then as part of the FlatpakRepos constructor.
+(WebkitFlatpak.main): Separate out the check which deletes the Flatpak
+repository from the one that checks if the packages are installed. This
+makes sure we don't install packages and then immediately delete them.
+(WebkitFlatpak.check_installed_packages): rename _get_packages to _get_dependency_packages
+in order to make it clear that it doesn't return installed packages.
+(WebkitFlatpak._get_dependency_packages): Ditto.
+(WebkitFlatpak.install_all): Ditto.
+(FlatpakRepo.is_app_installed): Deleted.
+(WebkitFlatpak._get_packages): Deleted.
+
 2021-08-17  Jonathan Bedard  
 
 [webkitcorepy] Return SourceFileLoader in find_module


Modified: 

[webkit-changes] [281183] trunk/Source

[calvaris]

Title: [281183] trunk/Source








Revision 281183
Author calva...@igalia.com
Date 2021-08-18 01:26:33 -0700 (Wed, 18 Aug 2021)


Log Message
[GStreamer][EME] Try to parse XML init datas that could possibly come from MPD manifests
https://bugs.webkit.org/show_bug.cgi?id=229145

Reviewed by Alicia Boya Garcia.

Source/WebCore:

Added GStreamerEMEUtilities to include implementation of
InitData::extractCencIfNeeded. This tries to parse the possible
XML inside an init data that could come from MPD manifests. If it
succeeds, it keeps the parsed init data, if not, it returns the
original one.

Based on a patch by Philippe Normand.

* platform/GStreamer.cmake:
* platform/graphics/gstreamer/eme/GStreamerEMEUtilities.cpp: Added.
(WebCore::markupStartElement):
(WebCore::markupEndElement):
(WebCore::markupText):
(WebCore::markupPassthrough):
(WebCore::markupError):
(WebCore::InitData::extractCencIfNeeded):
* platform/graphics/gstreamer/eme/GStreamerEMEUtilities.h:
(WebCore::InitData::InitData):

Source/WTF:

* wtf/glib/GUniquePtr.h: Added deleter for GMarkupParseContext.

Modified Paths

trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/glib/GUniquePtr.h
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/GStreamer.cmake
trunk/Source/WebCore/platform/graphics/gstreamer/eme/GStreamerEMEUtilities.h


Added Paths

trunk/Source/WebCore/platform/graphics/gstreamer/eme/GStreamerEMEUtilities.cpp




Diff

Modified: trunk/Source/WTF/ChangeLog (281182 => 281183)

--- trunk/Source/WTF/ChangeLog	2021-08-18 06:50:16 UTC (rev 281182)
+++ trunk/Source/WTF/ChangeLog	2021-08-18 08:26:33 UTC (rev 281183)
@@ -1,3 +1,12 @@
+2021-08-18  Xabier Rodriguez Calvar  
+
+[GStreamer][EME] Try to parse XML init datas that could possibly come from MPD manifests
+https://bugs.webkit.org/show_bug.cgi?id=229145
+
+Reviewed by Alicia Boya Garcia.
+
+* wtf/glib/GUniquePtr.h: Added deleter for GMarkupParseContext.
+
 2021-08-16  Alex Christensen  
 
 Enable PerformanceNavigationAPI by default


Modified: trunk/Source/WTF/wtf/glib/GUniquePtr.h (281182 => 281183)

--- trunk/Source/WTF/wtf/glib/GUniquePtr.h	2021-08-18 06:50:16 UTC (rev 281182)
+++ trunk/Source/WTF/wtf/glib/GUniquePtr.h	2021-08-18 08:26:33 UTC (rev 281183)
@@ -47,7 +47,8 @@
 macro(GKeyFile, g_key_file_free) \
 macro(char*, g_strfreev) \
 macro(GVariantIter, g_variant_iter_free) \
-macro(GVariantType, g_variant_type_free)
+macro(GVariantType, g_variant_type_free) \
+macro(GMarkupParseContext, g_markup_parse_context_free)
 
 #define WTF_DEFINE_GPTR_DELETER(typeName, deleterFunc) \
 template<> struct GPtrDeleter \


Modified: trunk/Source/WebCore/ChangeLog (281182 => 281183)

--- trunk/Source/WebCore/ChangeLog	2021-08-18 06:50:16 UTC (rev 281182)
+++ trunk/Source/WebCore/ChangeLog	2021-08-18 08:26:33 UTC (rev 281183)
@@ -1,3 +1,29 @@
+2021-08-18  Xabier Rodriguez Calvar  
+
+[GStreamer][EME] Try to parse XML init datas that could possibly come from MPD manifests
+https://bugs.webkit.org/show_bug.cgi?id=229145
+
+Reviewed by Alicia Boya Garcia.
+
+Added GStreamerEMEUtilities to include implementation of
+InitData::extractCencIfNeeded. This tries to parse the possible
+XML inside an init data that could come from MPD manifests. If it
+succeeds, it keeps the parsed init data, if not, it returns the
+original one.
+
+Based on a patch by Philippe Normand.
+
+* platform/GStreamer.cmake:
+* platform/graphics/gstreamer/eme/GStreamerEMEUtilities.cpp: Added.
+(WebCore::markupStartElement):
+(WebCore::markupEndElement):
+(WebCore::markupText):
+(WebCore::markupPassthrough):
+(WebCore::markupError):
+(WebCore::InitData::extractCencIfNeeded):
+* platform/graphics/gstreamer/eme/GStreamerEMEUtilities.h:
+(WebCore::InitData::InitData):
+
 2021-08-17  Devin Rousso  
 
 Web Inspector: match the undocked tab bar style when docked bottom/side


Modified: trunk/Source/WebCore/platform/GStreamer.cmake (281182 => 281183)

--- trunk/Source/WebCore/platform/GStreamer.cmake	2021-08-18 06:50:16 UTC (rev 281182)
+++ trunk/Source/WebCore/platform/GStreamer.cmake	2021-08-18 08:26:33 UTC (rev 281183)
@@ -29,6 +29,7 @@
 platform/graphics/gstreamer/WebKitAudioSinkGStreamer.cpp
 platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp
 
+platform/graphics/gstreamer/eme/GStreamerEMEUtilities.cpp
 platform/graphics/gstreamer/eme/WebKitClearKeyDecryptorGStreamer.cpp
 platform/graphics/gstreamer/eme/WebKitCommonEncryptionDecryptorGStreamer.cpp
 


Added: trunk/Source/WebCore/platform/graphics/gstreamer/eme/GStreamerEMEUtilities.cpp (0 => 281183)

--- trunk/Source/WebCore/platform/graphics/gstreamer/eme/GStreamerEMEUtilities.cpp	(rev 0)
+++ trunk/Source/WebCore/platform/graphics/gstreamer/eme/GStreamerEMEUtilities.cpp	2021-08-18 

[webkit-changes] [281182] trunk/Source

[drousso]

Title: [281182] trunk/Source








Revision 281182
Author drou...@apple.com
Date 2021-08-17 23:50:16 -0700 (Tue, 17 Aug 2021)


Log Message
Web Inspector: match the undocked tab bar style when docked bottom/side
https://bugs.webkit.org/show_bug.cgi?id=212398

Reviewed by Timothy Hatcher.

Source/WebCore:

* inspector/InspectorFrontendHost.cpp:
(WebCore::InspectorFrontendHost::platformVersionName const):
Add macOS Monterey.

Source/WebInspectorUI:

This will avoid confusion when switching from docked to undocked (and vice versa) as the tab
bar UI will no longer be significantly different.

* UserInterface/Views/TabBar.js:
(WI.TabBar):
(WI.TabBar.prototype.layout):
(WI.TabBar.prototype.layout.measureWidth):
(WI.TabBar.prototype._recordTabBarItemSizesAndPositions):
(WI.TabBar.prototype._applyTabBarItemSizesAndPositions):
(WI.TabBar.prototype._clearTabBarItemSizesAndPositions):
(WI.TabBar.prototype._handleMouseDown):
(WI.TabBar.prototype._handleMouseMoved):
(WI.TabBar.get horizontalPadding): Deleted.
(WI.TabBar.prototype._recordTabBarItemSizesAndPositions.add): Deleted.
* UserInterface/Views/TabBar.css:
(.tab-bar):
(body:is(.mac-platform.monterey, .mac-platform.big-sur) .tab-bar): Added.
(body:not(.mac-platform.monterey, .mac-platform.big-sur) .tab-bar): Added.
(body:is(.mac-platform.monterey, .mac-platform.big-sur).window-inactive .tab-bar, body:not(.mac-platform.monterey, .mac-platform.big-sur).window-inactive .tab-bar): Added.
(.tab-bar > .tabs > .item):
(body:is(.mac-platform.monterey, .mac-platform.big-sur) .tab-bar > .tabs > .item): Added.
(body:not(.mac-platform.monterey, .mac-platform.big-sur) .tab-bar > .tabs > .item): Added.
(.tab-bar > .tabs:not(.calculate-width) > .item:not(.pinned)):
(.tab-bar > .tabs > .item:nth-child(n + 2 of :not(.hidden)), .tab-bar > .tabs:not(.hide-border-start) > .item:nth-child(1 of :not(.hidden)), .tab-bar > .tabs.dragging-tab > .item.selected):
(.tab-bar > .tabs:not(.hide-border-end) > .item:nth-last-child(1 of :not(.hidden))):
(body:is(.mac-platform.monterey, .mac-platform.big-sur) .tab-bar > .tabs > .item:not(.disabled).selected): Added.
(body:is(.mac-platform.monterey, .mac-platform.big-sur):not(.docked) .tab-bar > .tabs > .item:not(.disabled).selected): Added.
(body:not(.mac-platform.monterey, .mac-platform.big-sur) .tab-bar > .tabs > .item:not(.disabled).selected): Added.
(body:is(.mac-platform.monterey, .mac-platform.big-sur) .tab-bar > .tabs:not(.animating) > .item:not(.selected, .disabled):hover): Added.
(body:not(.mac-platform.monterey, .mac-platform.big-sur) .tab-bar > .tabs:not(.animating) > .item:not(.selected, .disabled):hover): Added.
(.tab-bar > .tabs:not(.animating) > .item:not(.selected, .disabled):hover, .tab-bar > .tabs:not(.animating) > .item:not(.selected, .disabled):hover + .item):
(.tab-bar > .tabs:not(.animating) > .item:last-child:not(.selected, .disabled):hover):
(body:is(.mac-platform.monterey, .mac-platform.big-sur).window-inactive .tab-bar > .tabs > .item, body:not(.mac-platform.monterey, .mac-platform.big-sur).window-inactive .tab-bar > .tabs > .item): Added.
(body.window-inactive .tab-bar > .tabs > .item):
(body.window-inactive .tab-bar > .tabs > .item:not(.disabled).selected):
(.tab-bar > .tabs.dragging-tab > .item:not(.disabled).selected, .tab-bar > .tabs.static-layout:not(.animating.inserting-tab):not(.dragging-tab) > .item:nth-last-child(1 of :not(.pinned)), .tab-bar > .tabs.animating.closing-tab > .item:not(.disabled).selected):
(body.window-inactive .tab-bar > .tabs.dragging-tab > .item:not(.disabled).selected, body.window-inactive .tab-bar > .tabs.static-layout:not(.animating.inserting-tab):not(.dragging-tab) > .item:nth-last-child(1 of :not(.pinned)), body.window-inactive .tab-bar > .tabs.animating.closing-tab > .item:not(.disabled).selected):
(@media (prefers-color-scheme: dark) body:is(.mac-platform.monterey, .mac-platform.big-sur) .tab-bar, body:not(.mac-platform.monterey, .mac-platform.big-sur) .tab-bar): Added.
(@media (prefers-color-scheme: dark) body:is(.mac-platform.monterey, .mac-platform.big-sur) .tab-bar): Added.
(@media (prefers-color-scheme: dark) body:not(.mac-platform.monterey, .mac-platform.big-sur) .tab-bar): Added.
(@media (prefers-color-scheme: dark) body:not(.mac-platform.monterey, .mac-platform.big-sur) .tab-bar > .tabs > .item): Added.
(@media (prefers-color-scheme: dark) body:is(.mac-platform.monterey, .mac-platform.big-sur) .tab-bar > .tabs > .item:not(.disabled).selected): Added.
(@media (prefers-color-scheme: dark) body:not(.mac-platform.monterey, .mac-platform.big-sur) .tab-bar > .tabs > .item:not(.disabled).selected): Added.
(@media (prefers-color-scheme: dark) body:is(.mac-platform.monterey, .mac-platform.big-sur) .tab-bar > .tabs:not(.animating) > .item:not(.selected, .disabled):hover): Added.
(@media (prefers-color-scheme: dark) body:not(.mac-platform.monterey, .mac-platform.big-sur) .tab-bar > .tabs:not(.animating) > .item:not(.selected, .disabled):hover): Added.
(@media (prefers-color-scheme: dark) 

[webkit-changes] [281181] trunk/LayoutTests

[achristensen]

Title: [281181] trunk/LayoutTests








Revision 281181
Author achristen...@apple.com
Date 2021-08-17 23:26:20 -0700 (Tue, 17 Aug 2021)


Log Message
Mark test as flaky: imported/w3c/web-platform-tests/navigation-timing/nav2_test_attributes_values.html
https://bugs.webkit.org/show_bug.cgi?id=229181

* TestExpectations:
r281147 changed this test from flaky to differently flaky.
It used to pass sometimes because the whole document would load before any script was executed, so there was no PerformanceNavigationTiming
object to update as the document loaded.  r281147 fixed that, making it basically always pass when loaded over the real internet.
Now, sometimes it loads locally so fast that Performance::reduceTimeResolution makes some of the values 0, which is allowed by the spec but not
by the tests.  In practice, pages don't load over the internet in less than 1ms, so this isn't much of an issue, just in our test bots.
I'll propose a fix for the web platform test, but for now I mark it as flaky.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (281180 => 281181)

--- trunk/LayoutTests/ChangeLog	2021-08-18 03:55:56 UTC (rev 281180)
+++ trunk/LayoutTests/ChangeLog	2021-08-18 06:26:20 UTC (rev 281181)
@@ -1,3 +1,16 @@
+2021-08-17  Alex Christensen  
+
+Mark test as flaky: imported/w3c/web-platform-tests/navigation-timing/nav2_test_attributes_values.html
+https://bugs.webkit.org/show_bug.cgi?id=229181
+
+* TestExpectations:
+r281147 changed this test from flaky to differently flaky.
+It used to pass sometimes because the whole document would load before any script was executed, so there was no PerformanceNavigationTiming
+object to update as the document loaded.  r281147 fixed that, making it basically always pass when loaded over the real internet.
+Now, sometimes it loads locally so fast that Performance::reduceTimeResolution makes some of the values 0, which is allowed by the spec but not
+by the tests.  In practice, pages don't load over the internet in less than 1ms, so this isn't much of an issue, just in our test bots.
+I'll propose a fix for the web platform test, but for now I mark it as flaky.
+
 2021-08-17  Arcady Goldmints-Orlov  
 
 [GLIB] test http/tests/security/webaudio-render-remote-audio-allowed-crossorigin-redirect.html is a flaky timeout since r278004


Modified: trunk/LayoutTests/TestExpectations (281180 => 281181)

--- trunk/LayoutTests/TestExpectations	2021-08-18 03:55:56 UTC (rev 281180)
+++ trunk/LayoutTests/TestExpectations	2021-08-18 06:26:20 UTC (rev 281181)
@@ -1132,6 +1132,7 @@
 imported/w3c/web-platform-tests/resource-timing/crossorigin-sandwich-TAO.sub.html [ Pass Failure ]
 imported/w3c/web-platform-tests/resource-timing/crossorigin-sandwich-partial-TAO.sub.html [ Pass Failure ]
 imported/w3c/web-platform-tests/navigation-timing/secure_connection_start_non_zero.https.html [ Pass Failure ]
+imported/w3c/web-platform-tests/navigation-timing/nav2_test_attributes_values.html [ Pass Failure ]
 imported/w3c/web-platform-tests/resource-timing/TAO-match.html [ Pass Failure ]
 imported/w3c/web-platform-tests/resource-timing/iframe-failed-commit.html [ Pass Failure ]
 imported/w3c/web-platform-tests/resource-timing/fetch-cross-origin-redirect.https.html [ Pass Failure ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes