[webkit-changes] [281295] trunk
Title: [281295] trunk Revision 281295 Author an...@apple.com Date 2021-08-19 22:15:47 -0700 (Thu, 19 Aug 2021) Log Message [:has() pseudo-class] Basic support https://bugs.webkit.org/show_bug.cgi?id=228894 Reviewed by Simon Fraser. LayoutTests/imported/w3c: * web-platform-tests/css/selectors/has-basic-expected.txt: * web-platform-tests/css/selectors/has-relative-argument-expected.txt: * web-platform-tests/css/selectors/parsing/parse-has-expected.txt: * web-platform-tests/dom/nodes/Element-closest-expected.txt: Source/WebCore: This patch adds basic support for :has() pseudo-class, https://drafts.csswg.org/selectors/#has-pseudo. The initial implementation is very inefficient. There is no support for invalidation yet. The feature is disabled by default. * css/CSSSelector.cpp: (WebCore::CSSSelector::selectorText const): Serialization. * css/CSSSelector.h: * css/SelectorChecker.cpp: (WebCore::SelectorChecker::checkOne const): Selector matching using nested SelectorChecker. * css/SelectorPseudoClassAndCompatibilityElementMap.in: * css/parser/CSSParserContext.cpp: (WebCore::operator==): (WebCore::add): * css/parser/CSSParserContext.h: * css/parser/CSSParserSelector.h: (WebCore::CSSParserSelector::setPseudoClassType): * css/parser/CSSSelectorParser.cpp: (WebCore::CSSSelectorParser::consumeForgivingSelectorList): Add a template version of the forgiving parsing function. (WebCore::CSSSelectorParser::consumeForgivingComplexSelectorList): Use it for complex selector lists. (WebCore::CSSSelectorParser::consumeForgivingRelativeSelectorList): And the new relative selector lists. (WebCore::CSSSelectorParser::consumeRelativeSelector): Parse relative selectors like "> foo". (WebCore::CSSSelectorParser::consumePseudo): (WebCore::CSSSelectorParser::consumeComplexForgivingSelectorList): Deleted. * css/parser/CSSSelectorParser.h: * cssjit/SelectorCompiler.cpp: (WebCore::SelectorCompiler::addPseudoClassType): No compiler support yet. Source/WTF: * Scripts/Preferences/WebPreferencesExperimental.yaml: Add off-by-default HasPseudoClassEnabled preference value. Modified Paths trunk/LayoutTests/imported/w3c/ChangeLog trunk/LayoutTests/imported/w3c/web-platform-tests/css/selectors/has-basic-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/css/selectors/has-relative-argument-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/css/selectors/parsing/parse-has-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/dom/nodes/Element-closest-expected.txt trunk/Source/WTF/ChangeLog trunk/Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/css/CSSSelector.cpp trunk/Source/WebCore/css/CSSSelector.h trunk/Source/WebCore/css/SelectorChecker.cpp trunk/Source/WebCore/css/SelectorPseudoClassAndCompatibilityElementMap.in trunk/Source/WebCore/css/parser/CSSParserContext.cpp trunk/Source/WebCore/css/parser/CSSParserContext.h trunk/Source/WebCore/css/parser/CSSParserSelector.h trunk/Source/WebCore/css/parser/CSSSelectorParser.cpp trunk/Source/WebCore/css/parser/CSSSelectorParser.h trunk/Source/WebCore/cssjit/SelectorCompiler.cpp Diff Modified: trunk/LayoutTests/imported/w3c/ChangeLog (281294 => 281295) --- trunk/LayoutTests/imported/w3c/ChangeLog 2021-08-20 04:53:20 UTC (rev 281294) +++ trunk/LayoutTests/imported/w3c/ChangeLog 2021-08-20 05:15:47 UTC (rev 281295) @@ -1,3 +1,15 @@ +2021-08-19 Antti Koivisto + +[:has() pseudo-class] Basic support +https://bugs.webkit.org/show_bug.cgi?id=228894 + +Reviewed by Simon Fraser. + +* web-platform-tests/css/selectors/has-basic-expected.txt: +* web-platform-tests/css/selectors/has-relative-argument-expected.txt: +* web-platform-tests/css/selectors/parsing/parse-has-expected.txt: +* web-platform-tests/dom/nodes/Element-closest-expected.txt: + 2021-08-19 Chris Dumez Implement Crypto.randomUUID() Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/css/selectors/has-basic-expected.txt (281294 => 281295) --- trunk/LayoutTests/imported/w3c/web-platform-tests/css/selectors/has-basic-expected.txt 2021-08-20 04:53:20 UTC (rev 281294) +++ trunk/LayoutTests/imported/w3c/web-platform-tests/css/selectors/has-basic-expected.txt 2021-08-20 05:15:47 UTC (rev 281295) @@ -1,25 +1,25 @@ -FAIL :has(#a) matches expected elements The string did not match the expected pattern. -FAIL :has(.ancestor) matches expected elements The string did not match the expected pattern. -FAIL :has(.target) matches expected elements The string did not match the expected pattern. -FAIL :has(.descendant) matches expected elements The string did not match the expected pattern. -FAIL .parent:has(.target) matches expected elements The string did not match the expected pattern. -FAIL :has(.sibling ~ .target) matches expected elements The string did not match the expected pattern. -FAIL .parent:has(.sibling ~ .target) matches expected
[webkit-changes] [281294] trunk/Source/WebCore
Title: [281294] trunk/Source/WebCore Revision 281294 Author mmaxfi...@apple.com Date 2021-08-19 21:53:20 -0700 (Thu, 19 Aug 2021) Log Message The fast text codepath does not handle run initial advances https://bugs.webkit.org/show_bug.cgi?id=227979 Reviewed by Alan Bujtas. This is the next step to delete the complex text codepath from Cocoa ports. The initial advance contributes to the layout width of text. Its purpose is to move all the visually successive glyphs to the right. For the leftmost run, WidthIterator saves this initial advance to the GlyphBuffer, because knowing it is necessary to compute the paint location of glyphs (inside GlyphBuffer::flatten()). For all other runs other than the leftmost run, those runs' initial advance is added to the advance width of whichever glyph ends up being just to the left of the run. In LTR, this is the last glyph of the last (logical) run, whereas in RTL this is the first glyph of the next (logical) run. Because this is just adding infrastructure, it doesn't add any tests yet. This will be tested when we delete the complex text codepath. * platform/graphics/ComplexTextController.h: Because we're going to stop using ComplexTextController, we should move this (presumably helpful) comment somewhere where it will be accessible to the Cocoa ports. This would be GlyphBuffer::flatten(). * platform/graphics/Font.cpp: (WebCore::Font::applyTransforms const): Return the initial advance. * platform/graphics/Font.h: Ditto. * platform/graphics/FontCascade.cpp: (WebCore::FontCascade::widthOfTextRange const): (WebCore::FontCascade::widthForSimpleText const): Make sure that the initial advance contributes to layout width. (WebCore::FontCascade::layoutSimpleText const): The initial advance is actually NOT supposed to point directly to the first glyph's paint position. See https://bugs.webkit.org/show_bug.cgi?id=228180. (WebCore::FontCascade::drawEmphasisMarks const): * platform/graphics/GlyphBuffer.h: (WebCore::GlyphBuffer::flatten): (WebCore::GlyphBuffer::isFlattened const): * platform/graphics/WidthIterator.cpp: (WebCore::WidthIterator::applyFontTransforms): Return the initial advance. (WebCore::expandWithInitialAdvance): (WebCore::WidthIterator::applyInitialAdvance): This implements the logic above, where the initial advance of non-leftmost runs get added to the visually previous glyph's advance. For LTR, we can just add it directly to the previously-recorded glyph advance. However, for RTL, we have to save the initial advance to a variable, which is named m_leftoverInitialAdvance, and apply it when we encounter the next run. This is because WidthIterator encounters run in logical order. (WebCore::WidthIterator::commitCurrentFontRange): (WebCore::WidthIterator::finalize): For RTL, if the last run has an initial advance, we need to save it to the GlyphBuffer's initial advance field. We know if the last run has an initial advance because there will still be data in m_leftoverInitialAdvance left over. * platform/graphics/WidthIterator.h: * platform/graphics/coretext/FontCoreText.cpp: (WebCore::Font::applyTransforms const): Return the initial advance. Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/platform/graphics/ComplexTextController.h trunk/Source/WebCore/platform/graphics/Font.cpp trunk/Source/WebCore/platform/graphics/Font.h trunk/Source/WebCore/platform/graphics/FontCascade.cpp trunk/Source/WebCore/platform/graphics/GlyphBuffer.h trunk/Source/WebCore/platform/graphics/WidthIterator.cpp trunk/Source/WebCore/platform/graphics/WidthIterator.h trunk/Source/WebCore/platform/graphics/coretext/FontCoreText.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (281293 => 281294) --- trunk/Source/WebCore/ChangeLog 2021-08-20 04:07:08 UTC (rev 281293) +++ trunk/Source/WebCore/ChangeLog 2021-08-20 04:53:20 UTC (rev 281294) @@ -1,5 +1,61 @@ 2021-08-19 Myles C. Maxfield +The fast text codepath does not handle run initial advances +https://bugs.webkit.org/show_bug.cgi?id=227979 + +Reviewed by Alan Bujtas. + +This is the next step to delete the complex text codepath from Cocoa ports. + +The initial advance contributes to the layout width of text. Its purpose is to move +all the visually successive glyphs to the right. For the leftmost run, WidthIterator +saves this initial advance to the GlyphBuffer, because knowing it is necessary to +compute the paint location of glyphs (inside GlyphBuffer::flatten()). For all other +runs other than the leftmost run, those runs' initial advance is added to the advance +width of whichever glyph ends up being just to the left of the run. In LTR, this is +the last glyph of the last (logical) run, whereas in RTL this is the first glyph of +the next (logical) run. + +Because this is just adding infrastructure, it doesn't add any tests yet. This will be +tested when we delete the complex text codepath. +
[webkit-changes] [281293] trunk
Title: [281293] trunk
Revision 281293
Author mmaxfi...@apple.com
Date 2021-08-19 21:07:08 -0700 (Thu, 19 Aug 2021)
Log Message
[Cocoa] Stop honoring any dot-prefixed font names
https://bugs.webkit.org/show_bug.cgi?id=228177
Reviewed by Sam Weinig.
Source/WebCore:
Dot-prefixed fonts are intentionally unsupported. We should stop supporting them.
If authors want to access the various system fonts, they can use system-ui,
ui-serif, ui-monospace, or ui-rounded.
Test: fast/text/font-lookup-dot-prefix-case-sensitive.html
* platform/cocoa/VersionChecks.h:
* platform/graphics/cocoa/FontCacheCoreText.cpp:
(WebCore::isDotPrefixedForbiddenFont):
(WebCore::platformFontLookupWithFamily):
LayoutTests:
* fast/text/font-lookup-dot-prefix-case-sensitive-expected.html: Renamed from LayoutTests/fast/text/font-lookup-dot-prefix-case-sensitive-expected-mismatch.html.
* platform/ios/TestExpectations:
* platform/mac/TestExpectations:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/ios/TestExpectations
trunk/LayoutTests/platform/mac/TestExpectations
trunk/Source/WTF/wtf/spi/darwin/dyldSPI.h
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/cocoa/VersionChecks.h
trunk/Source/WebCore/platform/graphics/cocoa/FontCacheCoreText.cpp
Added Paths
trunk/LayoutTests/fast/text/font-lookup-dot-prefix-case-sensitive-expected.html
Removed Paths
trunk/LayoutTests/fast/text/font-lookup-dot-prefix-case-sensitive-expected-mismatch.html
Diff
Modified: trunk/LayoutTests/ChangeLog (281292 => 281293)
--- trunk/LayoutTests/ChangeLog 2021-08-20 03:53:48 UTC (rev 281292)
+++ trunk/LayoutTests/ChangeLog 2021-08-20 04:07:08 UTC (rev 281293)
@@ -1,5 +1,16 @@
2021-08-19 Myles C. Maxfield
+[Cocoa] Stop honoring any dot-prefixed font names
+https://bugs.webkit.org/show_bug.cgi?id=228177
+
+Reviewed by Sam Weinig.
+
+* fast/text/font-lookup-dot-prefix-case-sensitive-expected.html: Renamed from LayoutTests/fast/text/font-lookup-dot-prefix-case-sensitive-expected-mismatch.html.
+* platform/ios/TestExpectations:
+* platform/mac/TestExpectations:
+
+2021-08-19 Myles C. Maxfield
+
[Cocoa] Stop treating the system font as a non-variable font
https://bugs.webkit.org/show_bug.cgi?id=228176
Deleted: trunk/LayoutTests/fast/text/font-lookup-dot-prefix-case-sensitive-expected-mismatch.html (281292 => 281293)
--- trunk/LayoutTests/fast/text/font-lookup-dot-prefix-case-sensitive-expected-mismatch.html 2021-08-20 03:53:48 UTC (rev 281292)
+++ trunk/LayoutTests/fast/text/font-lookup-dot-prefix-case-sensitive-expected-mismatch.html 2021-08-20 04:07:08 UTC (rev 281293)
@@ -1,13 +0,0 @@
-
-
-
-
-if (window.internals) {
-internals.invalidateFontCache();
-
-
-
-Hello
-
-
-
Copied: trunk/LayoutTests/fast/text/font-lookup-dot-prefix-case-sensitive-expected.html (from rev 281292, trunk/LayoutTests/fast/text/font-lookup-dot-prefix-case-sensitive-expected-mismatch.html) (0 => 281293)
--- trunk/LayoutTests/fast/text/font-lookup-dot-prefix-case-sensitive-expected.html (rev 0)
+++ trunk/LayoutTests/fast/text/font-lookup-dot-prefix-case-sensitive-expected.html 2021-08-20 04:07:08 UTC (rev 281293)
@@ -0,0 +1,13 @@
+
+
+
+
+if (window.internals) {
+internals.invalidateFontCache();
+
+
+
+Hello
+
+
+
Modified: trunk/LayoutTests/platform/ios/TestExpectations (281292 => 281293)
--- trunk/LayoutTests/platform/ios/TestExpectations 2021-08-20 03:53:48 UTC (rev 281292)
+++ trunk/LayoutTests/platform/ios/TestExpectations 2021-08-20 04:07:08 UTC (rev 281293)
@@ -2623,7 +2623,7 @@
fast/text/accessibility-bold-system-font-2.html [ Pass ]
# This test is specific to Core Text.
-fast/text/font-lookup-dot-prefix-case-sensitive.html [ Pass ]
+fast/text/font-lookup-dot-prefix-case-sensitive.html [ ImageOnlyFailure ]
# Missing support for 521-bit elliptic curves.
crypto/subtle/ec-import-pkcs8-key-export-pkcs8-key-p521.html
Modified: trunk/LayoutTests/platform/mac/TestExpectations (281292 => 281293)
--- trunk/LayoutTests/platform/mac/TestExpectations 2021-08-20 03:53:48 UTC (rev 281292)
+++ trunk/LayoutTests/platform/mac/TestExpectations 2021-08-20 04:07:08 UTC (rev 281293)
@@ -1223,7 +1223,7 @@
webkit.org/b/175193 fast/images/async-image-body-background-image.html [ Pass Timeout ]
# This test is specific to Core Text.
-fast/text/font-lookup-dot-prefix-case-sensitive.html [ Pass ]
+webkit.org/b/228177 [ Mojave Catalina BigSur Monterey ] fast/text/font-lookup-dot-prefix-case-sensitive.html [ ImageOnlyFailure ]
webkit.org/b/173010 [ Debug ] js/slow-stress/Int32Array-alloc-huge.html [ Pass Timeout ]
Modified: trunk/Source/WTF/wtf/spi/darwin/dyldSPI.h (281292 => 281293)
--- trunk/Source/WTF/wtf/spi/darwin/dyldSPI.h 2021-08-20 03:53:48 UTC (rev 281292)
+++ trunk/Source/WTF/wtf/spi/darwin/dyldSPI.h 2021-08-20 04:07:08 UTC (rev 281293)
@@ -69,6 +69,10 @@
#define DYLD_IOS_VERSION_15_0 0x000f
#endif
+#ifndef
[webkit-changes] [281292] trunk/Source/WebCore
Title: [281292] trunk/Source/WebCore
Revision 281292
Author za...@apple.com
Date 2021-08-19 20:53:48 -0700 (Thu, 19 Aug 2021)
Log Message
[IFC][Integration] The root inlinebox's style is always the IFC's root style
https://bugs.webkit.org/show_bug.cgi?id=228062
Reviewed by Antti Koivisto.
This is in preparation for keeping the inline box structure private to the layout code.
* layout/integration/LayoutIntegrationInlineContentBuilder.cpp:
(WebCore::LayoutIntegration::InlineContentBuilder::computeLineLevelVisualAdjustmentsForRuns const):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/layout/integration/LayoutIntegrationInlineContentBuilder.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (281291 => 281292)
--- trunk/Source/WebCore/ChangeLog 2021-08-20 03:21:05 UTC (rev 281291)
+++ trunk/Source/WebCore/ChangeLog 2021-08-20 03:53:48 UTC (rev 281292)
@@ -1,3 +1,15 @@
+2021-08-19 Alan Bujtas
+
+[IFC][Integration] The root inlinebox's style is always the IFC's root style
+https://bugs.webkit.org/show_bug.cgi?id=228062
+
+Reviewed by Antti Koivisto.
+
+This is in preparation for keeping the inline box structure private to the layout code.
+
+* layout/integration/LayoutIntegrationInlineContentBuilder.cpp:
+(WebCore::LayoutIntegration::InlineContentBuilder::computeLineLevelVisualAdjustmentsForRuns const):
+
2021-08-19 Myles C. Maxfield
[Cocoa] Stop treating the system font as a non-variable font
Modified: trunk/Source/WebCore/layout/integration/LayoutIntegrationInlineContentBuilder.cpp (281291 => 281292)
--- trunk/Source/WebCore/layout/integration/LayoutIntegrationInlineContentBuilder.cpp 2021-08-20 03:21:05 UTC (rev 281291)
+++ trunk/Source/WebCore/layout/integration/LayoutIntegrationInlineContentBuilder.cpp 2021-08-20 03:53:48 UTC (rev 281292)
@@ -179,11 +179,10 @@
auto& rootStyle = m_layoutState.root().style();
auto shouldCheckHorizontalOverflowForContentReplacement = rootStyle.overflowX() == Overflow::Hidden && rootStyle.textOverflow() != TextOverflow::Clip;
-LineLevelVisualAdjustmentsForRunsList lineLevelVisualAdjustmentsForRuns(lines.size());
+auto lineLevelVisualAdjustmentsForRuns = LineLevelVisualAdjustmentsForRunsList { lines.size() };
for (size_t lineIndex = 0; lineIndex < lines.size(); ++lineIndex) {
auto lineNeedsLegacyIntegralVerticalPosition = [&] {
// Legacy inline tree integral rounds the vertical position for certain content (see LegacyInlineFlowBox::placeBoxesInBlockDirection and ::addToLine).
-auto& rootInlineBox = inlineFormattingState.lineBoxes()[lineIndex].rootInlineBox();
auto& nonRootInlineLevelBoxList = inlineFormattingState.lineBoxes()[lineIndex].nonRootInlineLevelBoxes();
if (nonRootInlineLevelBoxList.isEmpty()) {
// This is text content only with root inline box.
@@ -195,15 +194,14 @@
if (contentPreventsIntegralSnapping)
return false;
-auto& rootInlineBoxStyle = rootInlineBox.style();
auto& inlineLevelBoxStyle = inlineLevelBox.style();
-auto stylePreventsIntegralSnapping = rootInlineBoxStyle.lineHeight() != inlineLevelBoxStyle.lineHeight() || inlineLevelBoxStyle.verticalAlign() != VerticalAlign::Baseline;
+auto stylePreventsIntegralSnapping = rootStyle.lineHeight() != inlineLevelBoxStyle.lineHeight() || inlineLevelBoxStyle.verticalAlign() != VerticalAlign::Baseline;
if (stylePreventsIntegralSnapping)
return false;
-auto& rootInlineBoxFontMetrics = rootInlineBoxStyle.fontCascade().fontMetrics();
+auto& rootFontMetrics = rootStyle.fontCascade().fontMetrics();
auto& inlineLevelBoxFontMetrics = inlineLevelBoxStyle.fontCascade().fontMetrics();
-auto fontPreventsIntegralSnapping = !rootInlineBoxFontMetrics.hasIdenticalAscentDescentAndLineGap(inlineLevelBoxFontMetrics);
+auto fontPreventsIntegralSnapping = !rootFontMetrics.hasIdenticalAscentDescentAndLineGap(inlineLevelBoxFontMetrics);
if (fontPreventsIntegralSnapping)
return false;
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [281291] trunk
Title: [281291] trunk Revision 281291 Author mmaxfi...@apple.com Date 2021-08-19 20:21:05 -0700 (Thu, 19 Aug 2021) Log Message [Cocoa] Stop treating the system font as a non-variable font https://bugs.webkit.org/show_bug.cgi?id=228176 Reviewed by Sam Weinig. Source/WebCore: Modern versions of macOS and iOS can treat the system font as a variable font, and be able to apply weights like "342" instead of just "300" or "400". Tests: fast/text/variable-system-font-2.html fast/text/variable-system-font.html * platform/graphics/cocoa/FontCacheCoreText.cpp: (WebCore::preparePlatformFont): Source/WTF: * wtf/PlatformUse.h: LayoutTests: Update tests. * fast/text/resources/Ahem-trak.ttf: Added. This is a font which has a trak table. * fast/text/trak-optimizeLegibility-expected-mismatch.html: Added. * fast/text/trak-optimizeLegibility-expected.txt: Removed. * fast/text/trak-optimizeLegibility.html: * fast/text/variable-system-font-2-expected-mismatch.html: Added. * fast/text/variable-system-font-2.html: Added. * fast/text/variable-system-font-expected-mismatch.html: Added. * fast/text/variable-system-font.html: Added. * svg/dom/altGlyph-dom-expected.txt: * svg/dom/resources/altGlyph-dom.js: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/TestExpectations trunk/LayoutTests/fast/text/trak-optimizeLegibility.html trunk/LayoutTests/platform/ios/TestExpectations trunk/LayoutTests/platform/mac/TestExpectations trunk/LayoutTests/svg/dom/altGlyph-dom-expected.txt trunk/LayoutTests/svg/dom/resources/altGlyph-dom.js trunk/Source/WTF/ChangeLog trunk/Source/WTF/wtf/PlatformUse.h trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/platform/graphics/cocoa/FontCacheCoreText.cpp Added Paths trunk/LayoutTests/fast/text/resources/Ahem-trak.ttf trunk/LayoutTests/fast/text/trak-optimizeLegibility-expected-mismatch.html trunk/LayoutTests/fast/text/variable-system-font-2-expected-mismatch.html trunk/LayoutTests/fast/text/variable-system-font-2.html trunk/LayoutTests/fast/text/variable-system-font-expected-mismatch.html trunk/LayoutTests/fast/text/variable-system-font.html Removed Paths trunk/LayoutTests/fast/text/trak-optimizeLegibility-expected.txt Diff Modified: trunk/LayoutTests/ChangeLog (281290 => 281291) --- trunk/LayoutTests/ChangeLog 2021-08-20 02:46:43 UTC (rev 281290) +++ trunk/LayoutTests/ChangeLog 2021-08-20 03:21:05 UTC (rev 281291) @@ -1,3 +1,23 @@ +2021-08-19 Myles C. Maxfield + +[Cocoa] Stop treating the system font as a non-variable font +https://bugs.webkit.org/show_bug.cgi?id=228176 + +Reviewed by Sam Weinig. + +Update tests. + +* fast/text/resources/Ahem-trak.ttf: Added. This is a font which has a trak table. +* fast/text/trak-optimizeLegibility-expected-mismatch.html: Added. +* fast/text/trak-optimizeLegibility-expected.txt: Removed. +* fast/text/trak-optimizeLegibility.html: +* fast/text/variable-system-font-2-expected-mismatch.html: Added. +* fast/text/variable-system-font-2.html: Added. +* fast/text/variable-system-font-expected-mismatch.html: Added. +* fast/text/variable-system-font.html: Added. +* svg/dom/altGlyph-dom-expected.txt: +* svg/dom/resources/altGlyph-dom.js: + 2021-08-19 Eric Hutchison [iOS] 3 imported/w3c/web-platform-tests/css/css-typed-om/ tests are flaky failure. Modified: trunk/LayoutTests/TestExpectations (281290 => 281291) --- trunk/LayoutTests/TestExpectations 2021-08-20 02:46:43 UTC (rev 281290) +++ trunk/LayoutTests/TestExpectations 2021-08-20 03:21:05 UTC (rev 281291) @@ -5127,3 +5127,6 @@ http/wpt/crypto/aes-ctr-crash.any.html [ DumpJSConsoleLogInStdErr ] imported/w3c/web-platform-tests/WebCryptoAPI/encrypt_decrypt/aes_cbc.https.any.html [ DumpJSConsoleLogInStdErr ] imported/w3c/web-platform-tests/WebCryptoAPI/encrypt_decrypt/aes_ctr.https.any.html [ DumpJSConsoleLogInStdErr ] + +webkit.org/b/228176 fast/text/variable-system-font.html [ Pass ImageOnlyFailure ] +webkit.org/b/228176 fast/text/variable-system-font-2.html [ Pass ImageOnlyFailure ] Added: trunk/LayoutTests/fast/text/resources/Ahem-trak.ttf (0 => 281291) --- trunk/LayoutTests/fast/text/resources/Ahem-trak.ttf (rev 0) +++ trunk/LayoutTests/fast/text/resources/Ahem-trak.ttf 2021-08-20 03:21:05 UTC (rev 281291) @@ -0,0 +1,44 @@ +ÀÀÀÀ À\x80ÀÀ@OS/2sf\xF8ÀÀÀ\xCCÀÀÀ`cmap9\x96U\xEEÀÀ,ÀÀ gaspÀÀ ÀÀ8ÀÀÀglyf0* \xFDÀÀHÀÀ\xA8head\xDBP͵ÀÀ \xF0ÀÀÀ6hhea +7ÀÀ!(ÀÀÀ$hmtx+ÀÀ!LÀÀXloca\xBEÔ¸7ÀÀ%\xA4ÀÀ.maxpÀ ÀÀ'\xD4ÀÀÀ name\x80\xA9\xAElÀÀ'\xF4ÀÀ2 postc\xA1[#ÀÀZÀÀtrak\xF6À\x89ÀÀ]\x94ÀÀÀ"À\xD6\x90ÀÀÀ\xBC\x8AÀÀÀ\x8F\xBC\x8AÀÀ\xC5À2ÀÀÀÀÀÀÀÀÀÀ\x80ÀÀ\xAFÀ HÀÀÀÀÀÀÀÀW3C À@À \xFE\xFF \xFF8ÀÀ À\xC8\xFF\xFCÀÀ\xFF\xFF ÀÀÀ
[webkit-changes] [281290] trunk/Source/WebKit
Title: [281290] trunk/Source/WebKit
Revision 281290
Author simon.fra...@apple.com
Date 2021-08-19 19:46:43 -0700 (Thu, 19 Aug 2021)
Log Message
Use an ObjectIdentifier<> for text checker requests
https://bugs.webkit.org/show_bug.cgi?id=229302
Reviewed by Wenson Hsieh.
Introduce TextCheckerRequestID and use it to identify text checker requests in a type-safe
way.
* Scripts/webkit/messages.py:
(types_that_cannot_be_forward_declared):
(headers_for_type):
* Shared/IdentifierTypes.h:
* UIProcess/TextCheckerCompletion.cpp:
(WebKit::TextCheckerCompletion::create):
(WebKit::TextCheckerCompletion::TextCheckerCompletion):
* UIProcess/TextCheckerCompletion.h:
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::requestCheckingOfString):
(WebKit::WebPageProxy::didFinishCheckingText):
(WebKit::WebPageProxy::didCancelCheckingText):
* UIProcess/WebPageProxy.h:
* UIProcess/WebPageProxy.messages.in:
* WebProcess/WebCoreSupport/WebEditorClient.cpp:
(WebKit::WebEditorClient::requestCheckingOfString):
(WebKit::generateTextCheckingRequestID): Deleted.
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::addTextCheckingRequest):
(WebKit::WebPage::didFinishCheckingText):
(WebKit::WebPage::didCancelCheckingText):
* WebProcess/WebPage/WebPage.h:
* WebProcess/WebPage/WebPage.messages.in:
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Scripts/webkit/messages.py
trunk/Source/WebKit/Shared/IdentifierTypes.h
trunk/Source/WebKit/UIProcess/TextCheckerCompletion.cpp
trunk/Source/WebKit/UIProcess/TextCheckerCompletion.h
trunk/Source/WebKit/UIProcess/WebPageProxy.cpp
trunk/Source/WebKit/UIProcess/WebPageProxy.h
trunk/Source/WebKit/UIProcess/WebPageProxy.messages.in
trunk/Source/WebKit/WebProcess/WebCoreSupport/WebEditorClient.cpp
trunk/Source/WebKit/WebProcess/WebPage/WebPage.cpp
trunk/Source/WebKit/WebProcess/WebPage/WebPage.h
trunk/Source/WebKit/WebProcess/WebPage/WebPage.messages.in
Diff
Modified: trunk/Source/WebKit/ChangeLog (281289 => 281290)
--- trunk/Source/WebKit/ChangeLog 2021-08-20 02:35:35 UTC (rev 281289)
+++ trunk/Source/WebKit/ChangeLog 2021-08-20 02:46:43 UTC (rev 281290)
@@ -1,3 +1,37 @@
+2021-08-19 Simon Fraser
+
+Use an ObjectIdentifier<> for text checker requests
+https://bugs.webkit.org/show_bug.cgi?id=229302
+
+Reviewed by Wenson Hsieh.
+
+Introduce TextCheckerRequestID and use it to identify text checker requests in a type-safe
+way.
+
+* Scripts/webkit/messages.py:
+(types_that_cannot_be_forward_declared):
+(headers_for_type):
+* Shared/IdentifierTypes.h:
+* UIProcess/TextCheckerCompletion.cpp:
+(WebKit::TextCheckerCompletion::create):
+(WebKit::TextCheckerCompletion::TextCheckerCompletion):
+* UIProcess/TextCheckerCompletion.h:
+* UIProcess/WebPageProxy.cpp:
+(WebKit::WebPageProxy::requestCheckingOfString):
+(WebKit::WebPageProxy::didFinishCheckingText):
+(WebKit::WebPageProxy::didCancelCheckingText):
+* UIProcess/WebPageProxy.h:
+* UIProcess/WebPageProxy.messages.in:
+* WebProcess/WebCoreSupport/WebEditorClient.cpp:
+(WebKit::WebEditorClient::requestCheckingOfString):
+(WebKit::generateTextCheckingRequestID): Deleted.
+* WebProcess/WebPage/WebPage.cpp:
+(WebKit::WebPage::addTextCheckingRequest):
+(WebKit::WebPage::didFinishCheckingText):
+(WebKit::WebPage::didCancelCheckingText):
+* WebProcess/WebPage/WebPage.h:
+* WebProcess/WebPage/WebPage.messages.in:
+
2021-08-19 Wenson Hsieh
Fix the apple internal build after r281277
Modified: trunk/Source/WebKit/Scripts/webkit/messages.py (281289 => 281290)
--- trunk/Source/WebKit/Scripts/webkit/messages.py 2021-08-20 02:35:35 UTC (rev 281289)
+++ trunk/Source/WebKit/Scripts/webkit/messages.py 2021-08-20 02:46:43 UTC (rev 281290)
@@ -343,6 +343,7 @@
'WebKit::StorageAreaImplIdentifier',
'WebKit::StorageNamespaceIdentifier',
'WebKit::TapIdentifier',
+'WebKit::TextCheckerRequestID',
'WebKit::TrackPrivateRemoteIdentifier',
'WebKit::TransactionID',
'WebKit::UserContentControllerIdentifier',
@@ -780,6 +781,7 @@
'WebKit::SelectionFlags': ['"GestureTypes.h"'],
'WebKit::SelectionTouch': ['"GestureTypes.h"'],
'WebKit::TapIdentifier': ['"IdentifierTypes.h"'],
+'WebKit::TextCheckerRequestID': ['"IdentifierTypes.h"'],
'WebCore::MediaEngineSupportParameters': [''],
'WebCore::ISOWebVTTCue': [''],
'struct WebCore::Cookie': [''],
Modified: trunk/Source/WebKit/Shared/IdentifierTypes.h (281289 => 281290)
--- trunk/Source/WebKit/Shared/IdentifierTypes.h 2021-08-20 02:35:35 UTC (rev 281289)
+++ trunk/Source/WebKit/Shared/IdentifierTypes.h 2021-08-20 02:46:43 UTC (rev 281290)
@@ -32,4 +32,7 @@
enum TapIdentifierType { };
using TapIdentifier = ObjectIdentifier;
+enum TextCheckerRequestType {
[webkit-changes] [281289] trunk/Source/WebKit
Title: [281289] trunk/Source/WebKit
Revision 281289
Author wenson_hs...@apple.com
Date 2021-08-19 19:35:35 -0700 (Thu, 19 Aug 2021)
Log Message
Fix the apple internal build after r281277
https://bugs.webkit.org/show_bug.cgi?id=229100
Reviewed by Myles C. Maxfield.
Update code guarded by `USE(APPLE_INTERNAL_SDK)`, such that it works with a `Vector`.
Preserve the existing behavior of appending `handles` and `ids` in reverse order, but leave a FIXME questioning
the need for this.
* UIProcess/UserMediaProcessManager.cpp:
(WebKit::UserMediaProcessManager::willCreateMediaStream):
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/UserMediaProcessManager.cpp
Diff
Modified: trunk/Source/WebKit/ChangeLog (281288 => 281289)
--- trunk/Source/WebKit/ChangeLog 2021-08-20 01:41:03 UTC (rev 281288)
+++ trunk/Source/WebKit/ChangeLog 2021-08-20 02:35:35 UTC (rev 281289)
@@ -1,5 +1,20 @@
2021-08-19 Wenson Hsieh
+Fix the apple internal build after r281277
+https://bugs.webkit.org/show_bug.cgi?id=229100
+
+
+Reviewed by Myles C. Maxfield.
+
+Update code guarded by `USE(APPLE_INTERNAL_SDK)`, such that it works with a `Vector`.
+Preserve the existing behavior of appending `handles` and `ids` in reverse order, but leave a FIXME questioning
+the need for this.
+
+* UIProcess/UserMediaProcessManager.cpp:
+(WebKit::UserMediaProcessManager::willCreateMediaStream):
+
+2021-08-19 Wenson Hsieh
+
[iOS] Remove support for the meaningful tap heuristic
https://bugs.webkit.org/show_bug.cgi?id=229298
rdar://82130066
Modified: trunk/Source/WebKit/UIProcess/UserMediaProcessManager.cpp (281288 => 281289)
--- trunk/Source/WebKit/UIProcess/UserMediaProcessManager.cpp 2021-08-20 01:41:03 UTC (rev 281288)
+++ trunk/Source/WebKit/UIProcess/UserMediaProcessManager.cpp 2021-08-20 02:35:35 UTC (rev 281289)
@@ -97,7 +97,7 @@
Vector ids;
if (!proxy.page().preferences().mockCaptureDevicesEnabled()) {
-handles.allocate(extensionCount);
+handles.resize(extensionCount);
ids.reserveInitialCapacity(extensionCount);
if (needsAudioSandboxExtension) {
@@ -131,6 +131,8 @@
WTFLogAlways("Could not create a required sandbox extension, capture will fail!");
return false;
}
+
+// FIXME: Is it correct to ensure that the corresponding entries in `handles` and `ids` are in reverse order?
}
for (const auto& id : ids)
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [281288] trunk/Source/WebCore
Title: [281288] trunk/Source/WebCore
Revision 281288
Author j...@apple.com
Date 2021-08-19 18:41:03 -0700 (Thu, 19 Aug 2021)
Log Message
Touchbar not showing time scrubbing
https://bugs.webkit.org/show_bug.cgi?id=229269
rdar://81349236
Reviewed by Jer Noble.
AVKit uses canSeek to determine when to show the time scrubber
in the touch bar. This was a synthesized method determined on weither the video
is seekable and has a seekable range set.
Should the value of either boolean change which would impact the final value of
[AVTouchBarPlaybackControlsControlling canSeek] , no observers would be called.
Add the appropriate obj-c methods to explicitly set a dependency between properties
willChange/didChange.
Been unable to reproduce the problem programatically, the issue is highly timing
dependent.
An API test will be added with https://bugs.webkit.org/show_bug.cgi?id=229286.
* platform/mac/WebPlaybackControlsManager.mm:
(+[WebPlaybackControlsManager keyPathsForValuesAffectingCanSeek]):
(+[WebPlaybackControlsManager keyPathsForValuesAffectingContentDuration]):
(-[WebPlaybackControlsManager setSeekableTimeRanges:]):
(+[WebPlaybackControlsManager keyPathsForValuesAffectingValueCanBeginTouchBarScrubbing]):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/mac/WebPlaybackControlsManager.mm
Diff
Modified: trunk/Source/WebCore/ChangeLog (281287 => 281288)
--- trunk/Source/WebCore/ChangeLog 2021-08-20 01:12:25 UTC (rev 281287)
+++ trunk/Source/WebCore/ChangeLog 2021-08-20 01:41:03 UTC (rev 281288)
@@ -1,3 +1,28 @@
+2021-08-19 Jean-Yves Avenard
+
+Touchbar not showing time scrubbing
+https://bugs.webkit.org/show_bug.cgi?id=229269
+rdar://81349236
+
+Reviewed by Jer Noble.
+
+AVKit uses canSeek to determine when to show the time scrubber
+in the touch bar. This was a synthesized method determined on weither the video
+is seekable and has a seekable range set.
+Should the value of either boolean change which would impact the final value of
+[AVTouchBarPlaybackControlsControlling canSeek] , no observers would be called.
+Add the appropriate obj-c methods to explicitly set a dependency between properties
+willChange/didChange.
+Been unable to reproduce the problem programatically, the issue is highly timing
+dependent.
+An API test will be added with https://bugs.webkit.org/show_bug.cgi?id=229286.
+
+* platform/mac/WebPlaybackControlsManager.mm:
+(+[WebPlaybackControlsManager keyPathsForValuesAffectingCanSeek]):
+(+[WebPlaybackControlsManager keyPathsForValuesAffectingContentDuration]):
+(-[WebPlaybackControlsManager setSeekableTimeRanges:]):
+(+[WebPlaybackControlsManager keyPathsForValuesAffectingValueCanBeginTouchBarScrubbing]):
+
2021-08-19 Alan Bujtas
[LFC][IFC] Remove redundant inlineBoxEndSet in InlineFormattingContext::computeGeometryForLineContent
Modified: trunk/Source/WebCore/platform/mac/WebPlaybackControlsManager.mm (281287 => 281288)
--- trunk/Source/WebCore/platform/mac/WebPlaybackControlsManager.mm 2021-08-20 01:12:25 UTC (rev 281287)
+++ trunk/Source/WebCore/platform/mac/WebPlaybackControlsManager.mm 2021-08-20 01:41:03 UTC (rev 281288)
@@ -61,6 +61,16 @@
[super dealloc];
}
++ (NSSet *)keyPathsForValuesAffectingCanSeek
+{
+return [NSSet setWithObject:@"seekableTimeRanges"];
+}
+
++ (NSSet *)keyPathsForValuesAffectingContentDuration
+{
+return [NSSet setWithObject:@"seekableTimeRanges"];
+}
+
- (NSTimeInterval)contentDuration
{
return [_seekableTimeRanges count] ? _contentDuration : std::numeric_limits::infinity();
@@ -89,7 +99,6 @@
- (void)setSeekableTimeRanges:(NSArray *)timeRanges
{
_seekableTimeRanges = timeRanges;
-
_canSeek = timeRanges.count;
}
@@ -125,6 +134,11 @@
completionHandler(@[ ]);
}
++ (NSSet *)keyPathsForValuesAffectingValueCanBeginTouchBarScrubbing
+{
+return [NSSet setWithObjects:@"canSeek", "contentDuration", nil];
+}
+
- (BOOL)canBeginTouchBarScrubbing
{
// At this time, we return YES for all media that is not a live stream and media that is not Netflix. (A Netflix
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [281287] tags/Safari-612.1.28.4/
Title: [281287] tags/Safari-612.1.28.4/ Revision 281287 Author kocsen_ch...@apple.com Date 2021-08-19 18:12:25 -0700 (Thu, 19 Aug 2021) Log Message Tag Safari-612.1.28.4. Added Paths tags/Safari-612.1.28.4/ Diff ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [281286] trunk/Tools
Title: [281286] trunk/Tools
Revision 281286
Author clo...@igalia.com
Date 2021-08-19 17:38:54 -0700 (Thu, 19 Aug 2021)
Log Message
[build.webkit.org] Port old unit test with the expected build steps to the new buildbot
https://bugs.webkit.org/show_bug.cgi?id=229311
Reviewed by Aakash Jain.
Port the test that checked every worker and the expected steps to the new buildbot version.
Also delete the file steps_unittest_old.py because the gross of the other tests contained in
this old file are already ported in the current steps_unittests.py
* CISupport/build-webkit-org/factories_unittest.py: Added.
(TestExpectedBuildSteps):
(TestExpectedBuildSteps.setUp):
(TestExpectedBuildSteps.test_all_expected_results):
(TestExpectedBuildSteps.test_unnecessary_expected_results):
* CISupport/build-webkit-org/steps_unittest_old.py: Removed.
Modified Paths
trunk/Tools/ChangeLog
Added Paths
trunk/Tools/CISupport/build-webkit-org/factories_unittest.py
Removed Paths
trunk/Tools/CISupport/build-webkit-org/steps_unittest_old.py
Diff
Added: trunk/Tools/CISupport/build-webkit-org/factories_unittest.py (0 => 281286)
--- trunk/Tools/CISupport/build-webkit-org/factories_unittest.py (rev 0)
+++ trunk/Tools/CISupport/build-webkit-org/factories_unittest.py 2021-08-20 00:38:54 UTC (rev 281286)
@@ -0,0 +1,1392 @@
+# Copyright (C) 2011-2020 Apple Inc. All rights reserved.
+# Copyright (C) 2021 Igalia S.L.
+#
+# Redistribution and use in source and binary forms, with or without
+# modification, are permitted provided that the following conditions
+# are met:
+# 1. Redistributions of source code must retain the above copyright
+# notice, this list of conditions and the following disclaimer.
+# 2. Redistributions in binary form must reproduce the above copyright
+# notice, this list of conditions and the following disclaimer in the
+# documentation and/or other materials provided with the distribution.
+#
+# THIS SOFTWARE IS PROVIDED BY APPLE INC. AND ITS CONTRIBUTORS ``AS IS'' AND
+# ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED
+# WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
+# DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR ITS CONTRIBUTORS BE LIABLE FOR
+# ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
+# DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR
+# SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER
+# CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY,
+# OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
+# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+
+import loadConfig
+import os
+
+from twisted.trial import unittest
+
+
+class TestExpectedBuildSteps(unittest.TestCase):
+
+expected_steps = {
+"Apple-BigSur-Release-Build": [
+"configure-build",
+"configuration",
+"clean-and-update-working-directory",
+"show-identifier",
+"kill-old-processes",
+"delete-WebKitBuild-directory",
+"delete-stale-build-files",
+"compile-webkit",
+"archive-built-product",
+"upload",
+"archive-built-product",
+"upload",
+"transfer-to-s3",
+"trigger"
+],
+"Apple-BigSur-AppleSilicon-Release-Test262-Tests": [
+"configure-build",
+"configuration",
+"clean-and-update-working-directory",
+"show-identifier",
+"kill-old-processes",
+"delete-WebKitBuild-directory",
+"delete-stale-build-files",
+"download-built-product",
+"extract-built-product",
+"test262-test"
+],
+"Apple-BigSur-Release-Test262-Tests": [
+"configure-build",
+"configuration",
+"clean-and-update-working-directory",
+"show-identifier",
+"kill-old-processes",
+"delete-WebKitBuild-directory",
+"delete-stale-build-files",
+"download-built-product",
+"extract-built-product",
+"test262-test"
+],
+"Apple-BigSur-Release-WK1-Tests": [
+"configure-build",
+"configuration",
+"clean-and-update-working-directory",
+"show-identifier",
+"kill-old-processes",
+"delete-WebKitBuild-directory",
+"delete-stale-build-files",
+"download-built-product",
+"extract-built-product",
+"wait-for-crash-collection",
+"layout-test",
+"dashboard-tests",
+"archive-test-results",
+"upload",
+"extract-test-results",
+"set-permissions",
+"run-api-tests",
+"lldb-webkit-test",
+
[webkit-changes] [281285] trunk/Source/WebCore
Title: [281285] trunk/Source/WebCore
Revision 281285
Author za...@apple.com
Date 2021-08-19 17:37:14 -0700 (Thu, 19 Aug 2021)
Log Message
[LFC][IFC] Remove redundant inlineBoxEndSet in InlineFormattingContext::computeGeometryForLineContent
https://bugs.webkit.org/show_bug.cgi?id=228054
Reviewed by Antti Koivisto.
It's not used anymore.
* layout/formattingContexts/inline/InlineFormattingContext.cpp:
(WebCore::Layout::InlineFormattingContext::computeGeometryForLineContent):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/layout/formattingContexts/inline/InlineFormattingContext.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (281284 => 281285)
--- trunk/Source/WebCore/ChangeLog 2021-08-20 00:12:09 UTC (rev 281284)
+++ trunk/Source/WebCore/ChangeLog 2021-08-20 00:37:14 UTC (rev 281285)
@@ -1,3 +1,15 @@
+2021-08-19 Alan Bujtas
+
+[LFC][IFC] Remove redundant inlineBoxEndSet in InlineFormattingContext::computeGeometryForLineContent
+https://bugs.webkit.org/show_bug.cgi?id=228054
+
+Reviewed by Antti Koivisto.
+
+It's not used anymore.
+
+* layout/formattingContexts/inline/InlineFormattingContext.cpp:
+(WebCore::Layout::InlineFormattingContext::computeGeometryForLineContent):
+
2021-08-19 Chris Dumez
Implement Crypto.randomUUID()
Modified: trunk/Source/WebCore/layout/formattingContexts/inline/InlineFormattingContext.cpp (281284 => 281285)
--- trunk/Source/WebCore/layout/formattingContexts/inline/InlineFormattingContext.cpp 2021-08-20 00:12:09 UTC (rev 281284)
+++ trunk/Source/WebCore/layout/formattingContexts/inline/InlineFormattingContext.cpp 2021-08-20 00:37:14 UTC (rev 281285)
@@ -502,7 +502,6 @@
auto rootInlineBoxLogicalRect = lineBox.logicalRectForRootInlineBox();
auto enclosingTopAndBottom = InlineLineGeometry::EnclosingTopAndBottom { rootInlineBoxLogicalRect.top(), rootInlineBoxLogicalRect.bottom() };
HashSet inlineBoxStartSet;
-HashSet inlineBoxEndSet;
auto constructLineRunsAndUpdateBoxGeometry = [&] {
// Create the inline runs on the current line. This is mostly text and atomic inline runs.
@@ -556,7 +555,6 @@
continue;
}
if (lineRun.isInlineBoxEnd()) {
-inlineBoxEndSet.add();
if (!inlineBoxStartSet.contains()) {
// An inline box can span multiple lines. Use the [inline box end] signal to include it in the enclosing geometry
// only when it starts at a previous line.
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [281284] trunk
Title: [281284] trunk Revision 281284 Author cdu...@apple.com Date 2021-08-19 17:12:09 -0700 (Thu, 19 Aug 2021) Log Message Implement Crypto.randomUUID() https://bugs.webkit.org/show_bug.cgi?id=229240 Reviewed by Geoff Garen. LayoutTests/imported/w3c: Rebaseline WPT tests that are now passing. * web-platform-tests/WebCryptoAPI/randomUUID.https.any-expected.txt: * web-platform-tests/WebCryptoAPI/randomUUID.https.any.worker-expected.txt: Source/WebCore: Implement Crypto.randomUUID(): - https://wicg.github.io/uuid/#extensions-to-the-crypto-interface Chrome already implements this and Firefox seems to be working on it (https://bugzilla.mozilla.org/show_bug.cgi?id=1705264). No new tests, rebaselined existing tests. * page/Crypto.cpp: (WebCore::Crypto::randomUUID const): * page/Crypto.h: * page/Crypto.idl: Modified Paths trunk/LayoutTests/imported/w3c/ChangeLog trunk/LayoutTests/imported/w3c/web-platform-tests/WebCryptoAPI/randomUUID.https.any-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/WebCryptoAPI/randomUUID.https.any.worker-expected.txt trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/page/Crypto.cpp trunk/Source/WebCore/page/Crypto.h trunk/Source/WebCore/page/Crypto.idl Diff Modified: trunk/LayoutTests/imported/w3c/ChangeLog (281283 => 281284) --- trunk/LayoutTests/imported/w3c/ChangeLog 2021-08-19 23:58:26 UTC (rev 281283) +++ trunk/LayoutTests/imported/w3c/ChangeLog 2021-08-20 00:12:09 UTC (rev 281284) @@ -1,3 +1,15 @@ +2021-08-19 Chris Dumez + +Implement Crypto.randomUUID() +https://bugs.webkit.org/show_bug.cgi?id=229240 + +Reviewed by Geoff Garen. + +Rebaseline WPT tests that are now passing. + +* web-platform-tests/WebCryptoAPI/randomUUID.https.any-expected.txt: +* web-platform-tests/WebCryptoAPI/randomUUID.https.any.worker-expected.txt: + 2021-08-19 Zalan Bujtas [LFC][IFC] Add support for overflow-wrap: anywhere Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/WebCryptoAPI/randomUUID.https.any-expected.txt (281283 => 281284) --- trunk/LayoutTests/imported/w3c/web-platform-tests/WebCryptoAPI/randomUUID.https.any-expected.txt 2021-08-19 23:58:26 UTC (rev 281283) +++ trunk/LayoutTests/imported/w3c/web-platform-tests/WebCryptoAPI/randomUUID.https.any-expected.txt 2021-08-20 00:12:09 UTC (rev 281284) @@ -1,5 +1,5 @@ -FAIL namespace format self.crypto.randomUUID is not a function. (In 'self.crypto.randomUUID()', 'self.crypto.randomUUID' is undefined) -FAIL version set self.crypto.randomUUID is not a function. (In 'self.crypto.randomUUID()', 'self.crypto.randomUUID' is undefined) -FAIL variant set self.crypto.randomUUID is not a function. (In 'self.crypto.randomUUID()', 'self.crypto.randomUUID' is undefined) +PASS namespace format +PASS version set +PASS variant set Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/WebCryptoAPI/randomUUID.https.any.worker-expected.txt (281283 => 281284) --- trunk/LayoutTests/imported/w3c/web-platform-tests/WebCryptoAPI/randomUUID.https.any.worker-expected.txt 2021-08-19 23:58:26 UTC (rev 281283) +++ trunk/LayoutTests/imported/w3c/web-platform-tests/WebCryptoAPI/randomUUID.https.any.worker-expected.txt 2021-08-20 00:12:09 UTC (rev 281284) @@ -1,5 +1,5 @@ -FAIL namespace format self.crypto.randomUUID is not a function. (In 'self.crypto.randomUUID()', 'self.crypto.randomUUID' is undefined) -FAIL version set self.crypto.randomUUID is not a function. (In 'self.crypto.randomUUID()', 'self.crypto.randomUUID' is undefined) -FAIL variant set self.crypto.randomUUID is not a function. (In 'self.crypto.randomUUID()', 'self.crypto.randomUUID' is undefined) +PASS namespace format +PASS version set +PASS variant set Modified: trunk/Source/WebCore/ChangeLog (281283 => 281284) --- trunk/Source/WebCore/ChangeLog 2021-08-19 23:58:26 UTC (rev 281283) +++ trunk/Source/WebCore/ChangeLog 2021-08-20 00:12:09 UTC (rev 281284) @@ -1,3 +1,23 @@ +2021-08-19 Chris Dumez + +Implement Crypto.randomUUID() +https://bugs.webkit.org/show_bug.cgi?id=229240 + +Reviewed by Geoff Garen. + +Implement Crypto.randomUUID(): +- https://wicg.github.io/uuid/#extensions-to-the-crypto-interface + +Chrome already implements this and Firefox seems to be working on it +(https://bugzilla.mozilla.org/show_bug.cgi?id=1705264). + +No new tests, rebaselined existing tests. + +* page/Crypto.cpp: +(WebCore::Crypto::randomUUID const): +* page/Crypto.h: +* page/Crypto.idl: + 2021-08-19 Simon Fraser Remove unused RenderLayerCompositor member variable Modified: trunk/Source/WebCore/page/Crypto.cpp (281283 => 281284) --- trunk/Source/WebCore/page/Crypto.cpp 2021-08-19 23:58:26 UTC (rev 281283) +++ trunk/Source/WebCore/page/Crypto.cpp 2021-08-20 00:12:09 UTC (rev 281284) @@ -35,6 +35,7 @@ #include "SubtleCrypto.h" #include <_javascript_Core/ArrayBufferView.h> #include
[webkit-changes] [281283] trunk/Source/WebCore
Title: [281283] trunk/Source/WebCore
Revision 281283
Author simon.fra...@apple.com
Date 2021-08-19 16:58:26 -0700 (Thu, 19 Aug 2021)
Log Message
Remove unused RenderLayerCompositor member variable
https://bugs.webkit.org/show_bug.cgi?id=229257
Reviewed by Alan Bujtas.
m_inPostLayoutUpdate was unused.
* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::updateCompositingLayers):
* rendering/RenderLayerCompositor.h:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderLayerCompositor.cpp
trunk/Source/WebCore/rendering/RenderLayerCompositor.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (281282 => 281283)
--- trunk/Source/WebCore/ChangeLog 2021-08-19 23:53:12 UTC (rev 281282)
+++ trunk/Source/WebCore/ChangeLog 2021-08-19 23:58:26 UTC (rev 281283)
@@ -1,3 +1,16 @@
+2021-08-19 Simon Fraser
+
+Remove unused RenderLayerCompositor member variable
+https://bugs.webkit.org/show_bug.cgi?id=229257
+
+Reviewed by Alan Bujtas.
+
+m_inPostLayoutUpdate was unused.
+
+* rendering/RenderLayerCompositor.cpp:
+(WebCore::RenderLayerCompositor::updateCompositingLayers):
+* rendering/RenderLayerCompositor.h:
+
2021-08-19 Alan Bujtas
[LFC][IFC] Remove redundant LineBox functions
Modified: trunk/Source/WebCore/rendering/RenderLayerCompositor.cpp (281282 => 281283)
--- trunk/Source/WebCore/rendering/RenderLayerCompositor.cpp 2021-08-19 23:53:12 UTC (rev 281282)
+++ trunk/Source/WebCore/rendering/RenderLayerCompositor.cpp 2021-08-19 23:58:26 UTC (rev 281283)
@@ -865,8 +865,6 @@
++m_compositingUpdateCount;
-SetForScope postLayoutChange(m_inPostLayoutUpdate, true);
-
#if !LOG_DISABLED
MonotonicTime startTime;
if (compositingLogEnabled()) {
Modified: trunk/Source/WebCore/rendering/RenderLayerCompositor.h (281282 => 281283)
--- trunk/Source/WebCore/rendering/RenderLayerCompositor.h 2021-08-19 23:53:12 UTC (rev 281282)
+++ trunk/Source/WebCore/rendering/RenderLayerCompositor.h 2021-08-19 23:58:26 UTC (rev 281283)
@@ -591,7 +591,6 @@
bool m_flushingLayers { false };
bool m_shouldFlushOnReattach { false };
bool m_forceCompositingMode { false };
-bool m_inPostLayoutUpdate { false }; // true when it's OK to trust layout information (e.g. layer sizes and positions)
bool m_isTrackingRepaints { false }; // Used for testing.
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [281282] trunk/LayoutTests
Title: [281282] trunk/LayoutTests Revision 281282 Author ehutchi...@apple.com Date 2021-08-19 16:53:12 -0700 (Thu, 19 Aug 2021) Log Message [iOS] 3 imported/w3c/web-platform-tests/css/css-typed-om/ tests are flaky failure. . Unreviewed test gardening. * platform/ios/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/ios/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (281281 => 281282) --- trunk/LayoutTests/ChangeLog 2021-08-19 23:25:25 UTC (rev 281281) +++ trunk/LayoutTests/ChangeLog 2021-08-19 23:53:12 UTC (rev 281282) @@ -1,5 +1,14 @@ 2021-08-19 Eric Hutchison +[iOS] 3 imported/w3c/web-platform-tests/css/css-typed-om/ tests are flaky failure. +. + +Unreviewed test gardening. + +* platform/ios/TestExpectations: + +2021-08-19 Eric Hutchison + [Mac, iOS Release] imported/w3c/web-platform-tests/worklets/layout-worklet-csp.https.html is a flaky failure. . Modified: trunk/LayoutTests/platform/ios/TestExpectations (281281 => 281282) --- trunk/LayoutTests/platform/ios/TestExpectations 2021-08-19 23:25:25 UTC (rev 281281) +++ trunk/LayoutTests/platform/ios/TestExpectations 2021-08-19 23:53:12 UTC (rev 281282) @@ -3477,4 +3477,9 @@ #rdar://82146367 ([Mac, iOS Release] imported/w3c/web-platform-tests/worklets/layout-worklet-csp.https.html is a flaky failure) imported/w3c/web-platform-tests/worklets/layout-worklet-csp.https.html [ Pass Failure ] +#rdar://82147623 ([iOS] 3 imported/w3c/web-platform-tests/css/css-typed-om/ tests are flaky failure) +imported/w3c/web-platform-tests/css/css-typed-om/width-by-min-px-em.html [ Pass Failure ] +imported/w3c/web-platform-tests/css/css-typed-om/rotate-by-added-angle.html [ Pass Failure ] +imported/w3c/web-platform-tests/css/css-typed-om/width-by-max-px-em.html [ Pass Failure ] + webkit.org/b/228200 editing/selection/ios/scrolling-to-focused-element-inside-iframe.html [ Failure ] \ No newline at end of file ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [281281] trunk/LayoutTests
Title: [281281] trunk/LayoutTests Revision 281281 Author ehutchi...@apple.com Date 2021-08-19 16:25:25 -0700 (Thu, 19 Aug 2021) Log Message [Mac, iOS Release] imported/w3c/web-platform-tests/worklets/layout-worklet-csp.https.html is a flaky failure. . Unreviewed test gardening. * platform/ios/TestExpectations: * platform/mac/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/ios/TestExpectations trunk/LayoutTests/platform/mac/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (281280 => 281281) --- trunk/LayoutTests/ChangeLog 2021-08-19 23:21:48 UTC (rev 281280) +++ trunk/LayoutTests/ChangeLog 2021-08-19 23:25:25 UTC (rev 281281) @@ -1,3 +1,13 @@ +2021-08-19 Eric Hutchison + +[Mac, iOS Release] imported/w3c/web-platform-tests/worklets/layout-worklet-csp.https.html is a flaky failure. +. + +Unreviewed test gardening. + +* platform/ios/TestExpectations: +* platform/mac/TestExpectations: + 2021-08-19 Wenson Hsieh [iOS] Remove support for the meaningful tap heuristic Modified: trunk/LayoutTests/platform/ios/TestExpectations (281280 => 281281) --- trunk/LayoutTests/platform/ios/TestExpectations 2021-08-19 23:21:48 UTC (rev 281280) +++ trunk/LayoutTests/platform/ios/TestExpectations 2021-08-19 23:25:25 UTC (rev 281281) @@ -3475,4 +3475,6 @@ webkit.org/b/229291 imported/w3c/web-platform-tests/html/rendering/replaced-elements/images/revoked-blob-print.html [ Pass ImageOnlyFailure ] +#rdar://82146367 ([Mac, iOS Release] imported/w3c/web-platform-tests/worklets/layout-worklet-csp.https.html is a flaky failure) imported/w3c/web-platform-tests/worklets/layout-worklet-csp.https.html [ Pass Failure ] + webkit.org/b/228200 editing/selection/ios/scrolling-to-focused-element-inside-iframe.html [ Failure ] \ No newline at end of file Modified: trunk/LayoutTests/platform/mac/TestExpectations (281280 => 281281) --- trunk/LayoutTests/platform/mac/TestExpectations 2021-08-19 23:21:48 UTC (rev 281280) +++ trunk/LayoutTests/platform/mac/TestExpectations 2021-08-19 23:25:25 UTC (rev 281281) @@ -2324,5 +2324,7 @@ webkit.org/b/229291 imported/w3c/web-platform-tests/html/rendering/replaced-elements/images/revoked-blob-print.html [ Pass ImageOnlyFailure ] +#rdar://82146367 ([Mac, iOS Release] imported/w3c/web-platform-tests/worklets/layout-worklet-csp.https.html is a flaky failure) imported/w3c/web-platform-tests/worklets/layout-worklet-csp.https.html [ Pass Failure ] + webkit.org/b/228396 fast/speechsynthesis/speech-synthesis-speak-empty-string.html [ Pass Failure ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [281280] trunk/Source/WebCore
Title: [281280] trunk/Source/WebCore
Revision 281280
Author za...@apple.com
Date 2021-08-19 16:21:48 -0700 (Thu, 19 Aug 2021)
Log Message
[LFC][IFC] Remove redundant LineBox functions
https://bugs.webkit.org/show_bug.cgi?id=228046
Reviewed by Sam Weinig.
The line box's contentLogicalWidth always matches the root inlinebox's logical width.
* layout/formattingContexts/inline/InlineFormattingContext.cpp:
(WebCore::Layout::InlineFormattingContext::computeGeometryForLineContent):
* layout/formattingContexts/inline/InlineFormattingGeometry.cpp:
(WebCore::Layout::LineBoxBuilder::constructAndAlignInlineLevelBoxes):
(WebCore::Layout::LineBoxBuilder::computeLineBoxHeightAndAlignInlineLevelBoxesVertically):
* layout/formattingContexts/inline/InlineLineBox.cpp:
(WebCore::Layout::LineBox::LineBox):
* layout/formattingContexts/inline/InlineLineBox.h:
(WebCore::Layout::LineBox::logicalRect const):
(WebCore::Layout::LineBox::logicalWidth const): Deleted.
(WebCore::Layout::LineBox::logicalHeight const): Deleted.
(WebCore::Layout::LineBox::logicalTopLeft const): Deleted.
(WebCore::Layout::LineBox::logicalSize const): Deleted.
(WebCore::Layout::LineBox::contentLogicalWidth const): Deleted.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/layout/formattingContexts/inline/InlineFormattingContext.cpp
trunk/Source/WebCore/layout/formattingContexts/inline/InlineFormattingGeometry.cpp
trunk/Source/WebCore/layout/formattingContexts/inline/InlineLineBox.cpp
trunk/Source/WebCore/layout/formattingContexts/inline/InlineLineBox.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (281279 => 281280)
--- trunk/Source/WebCore/ChangeLog 2021-08-19 23:17:35 UTC (rev 281279)
+++ trunk/Source/WebCore/ChangeLog 2021-08-19 23:21:48 UTC (rev 281280)
@@ -1,3 +1,27 @@
+2021-08-19 Alan Bujtas
+
+[LFC][IFC] Remove redundant LineBox functions
+https://bugs.webkit.org/show_bug.cgi?id=228046
+
+Reviewed by Sam Weinig.
+
+The line box's contentLogicalWidth always matches the root inlinebox's logical width.
+
+* layout/formattingContexts/inline/InlineFormattingContext.cpp:
+(WebCore::Layout::InlineFormattingContext::computeGeometryForLineContent):
+* layout/formattingContexts/inline/InlineFormattingGeometry.cpp:
+(WebCore::Layout::LineBoxBuilder::constructAndAlignInlineLevelBoxes):
+(WebCore::Layout::LineBoxBuilder::computeLineBoxHeightAndAlignInlineLevelBoxesVertically):
+* layout/formattingContexts/inline/InlineLineBox.cpp:
+(WebCore::Layout::LineBox::LineBox):
+* layout/formattingContexts/inline/InlineLineBox.h:
+(WebCore::Layout::LineBox::logicalRect const):
+(WebCore::Layout::LineBox::logicalWidth const): Deleted.
+(WebCore::Layout::LineBox::logicalHeight const): Deleted.
+(WebCore::Layout::LineBox::logicalTopLeft const): Deleted.
+(WebCore::Layout::LineBox::logicalSize const): Deleted.
+(WebCore::Layout::LineBox::contentLogicalWidth const): Deleted.
+
2021-08-19 Wenson Hsieh
[iOS] Remove support for the meaningful tap heuristic
Modified: trunk/Source/WebCore/layout/formattingContexts/inline/InlineFormattingContext.cpp (281279 => 281280)
--- trunk/Source/WebCore/layout/formattingContexts/inline/InlineFormattingContext.cpp 2021-08-19 23:17:35 UTC (rev 281279)
+++ trunk/Source/WebCore/layout/formattingContexts/inline/InlineFormattingContext.cpp 2021-08-19 23:21:48 UTC (rev 281280)
@@ -474,7 +474,7 @@
auto& lineBoxLogicalRect = lineBox.logicalRect();
if (!lineBox.hasContent()) {
// Fast path for lines with no content e.g. or where we construct empty pre and post blocks.
-ASSERT(!lineBox.contentLogicalWidth() && !lineBoxLogicalRect.height());
+ASSERT(!lineBox.rootInlineBox().hasContent() && !lineBoxLogicalRect.height());
auto updateInlineBoxesGeometryIfApplicable = [&] {
if (!lineBox.hasInlineBox())
return;
Modified: trunk/Source/WebCore/layout/formattingContexts/inline/InlineFormattingGeometry.cpp (281279 => 281280)
--- trunk/Source/WebCore/layout/formattingContexts/inline/InlineFormattingGeometry.cpp 2021-08-19 23:17:35 UTC (rev 281279)
+++ trunk/Source/WebCore/layout/formattingContexts/inline/InlineFormattingGeometry.cpp 2021-08-19 23:21:48 UTC (rev 281280)
@@ -249,7 +249,7 @@
}
// Construct the missing LineBox::InlineBoxes starting with the topmost layout box.
for (auto* layoutBox : WTF::makeReversedRange(layoutBoxesWithoutInlineBoxes)) {
-auto inlineBox = InlineLevelBox::createInlineBox(*layoutBox, rootInlineBox.logicalLeft(), lineBox.contentLogicalWidth());
+auto inlineBox = InlineLevelBox::createInlineBox(*layoutBox, rootInlineBox.logicalLeft(), rootInlineBox.logicalWidth());
setVerticalGeometryForInlineBox(inlineBox);
simplifiedAlignVerticallyIfApplicable(inlineBox, { });
[webkit-changes] [281279] trunk
Title: [281279] trunk Revision 281279 Author wenson_hs...@apple.com Date 2021-08-19 16:17:35 -0700 (Thu, 19 Aug 2021) Log Message [iOS] Remove support for the meaningful tap heuristic https://bugs.webkit.org/show_bug.cgi?id=229298 rdar://82130066 Reviewed by Tim Horton. Source/WebCore: See WebKit ChangeLog for more details. * page/ChromeClient.h: (WebCore::ChromeClient::didHandleOrPreventMouseDownOrMouseUpEvent): Deleted. * page/EventHandler.cpp: (WebCore::EventHandler::handleMousePressEvent): (WebCore::EventHandler::handleMouseDoubleClickEvent): (WebCore::EventHandler::handleMouseReleaseEvent): Source/WebKit: Remove all support for the meaningful tap heuristic, which was used to allow users to toggle tab pill visibility in earlier versions of the Safari redesign. As of the latest iOS 15 beta, this heuristic is no longer necessary, so we don't need this SPI support anymore. * UIProcess/API/APIUIClient.h: (API::UIClient::didNotHandleTapAsClick): (API::UIClient::didTapAtPoint): Deleted. * UIProcess/API/Cocoa/WKUIDelegatePrivate.h: * UIProcess/API/ios/WKWebViewPrivateForTestingIOS.h: * UIProcess/API/ios/WKWebViewTestingIOS.mm: (-[WKWebView _didTapAtPoint:withResult:]): Deleted. * UIProcess/Cocoa/UIDelegate.h: * UIProcess/Cocoa/UIDelegate.mm: (WebKit::UIDelegate::setDelegate): (WebKit::UIDelegate::UIClient::didTapAtPoint): Deleted. * UIProcess/PageClient.h: * UIProcess/WebPageProxy.h: * UIProcess/WebPageProxy.messages.in: * UIProcess/ios/PageClientImplIOS.h: * UIProcess/ios/PageClientImplIOS.mm: (WebKit::PageClientImpl::didTapAtPoint): Deleted. * UIProcess/ios/WebPageProxyIOS.mm: (WebKit::WebPageProxy::didTapAtPoint): Deleted. * WebProcess/WebCoreSupport/WebChromeClient.cpp: (WebKit::WebChromeClient::didHandleOrPreventMouseDownOrMouseUpEvent): Deleted. * WebProcess/WebCoreSupport/WebChromeClient.h: * WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::isPlayingMediaDidChange): * WebProcess/WebPage/WebPage.h: Drive-by fix: initialize `m_appHighlightsVisible` using the correct type. (WebKit::WebPage::platformNeedsLayoutForEditorState const): (WebKit::WebPage::prepareToRunModalJavaScriptDialog): (WebKit::WebPage::didHandleOrPreventMouseDownOrMouseUpEvent): Deleted. (WebKit::WebPage::platformIsPlayingMediaDidChange): Deleted. * WebProcess/WebPage/ios/WebPageIOS.mm: (WebKit::WebPage::completeSyntheticClick): (WebKit::WebPage::attemptSyntheticClick): (WebKit::WebPage::handleTwoFingerTapAtPoint): (WebKit::WebPage::commitPotentialTapFailed): (WebKit::WebPage::clearSelectionAfterTapIfNeeded): (WebKit::isProbablyMeaningfulClick): Deleted. (WebKit::WebPage::didHandleOrPreventMouseDownOrMouseUpEvent): Deleted. (WebKit::WebPage::platformIsPlayingMediaDidChange): Deleted. Tools: Remove test runner support for testing the meaningful tap heuristic. * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl: * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: (WTR::InjectedBundle::didReceiveMessageToPage): * WebKitTestRunner/InjectedBundle/TestRunner.cpp: (WTR::TestRunner::installDidHandleTapCallback): Deleted. (WTR::TestRunner::callDidHandleTapCallback): Deleted. * WebKitTestRunner/InjectedBundle/TestRunner.h: * WebKitTestRunner/TestController.cpp: (WTR::TestController::didHandleTap): Deleted. * WebKitTestRunner/TestController.h: * WebKitTestRunner/TestInvocation.cpp: (WTR::TestInvocation::didHandleTap): Deleted. * WebKitTestRunner/TestInvocation.h: * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm: (-[TestRunnerWKWebView _didTapAtPoint:withResult:]): Deleted. LayoutTests: Remove all layout tests that exercised the meaningful tap heuristic. * fast/events/ios/did-not-handle-meaningful-click-expected.txt: Removed. * fast/events/ios/did-not-handle-meaningful-click.html: Removed. * fast/events/ios/meaningful-click-when-focusing-body-expected.txt: Removed. * fast/events/ios/meaningful-click-when-focusing-body.html: Removed. * fast/events/ios/meaningful-click-when-playing-media-expected.txt: Removed. * fast/events/ios/meaningful-click-when-playing-media.html: Removed. * fast/events/ios/meaningful-click-when-tapping-draggable-content-expected.txt: Removed. * fast/events/ios/meaningful-click-when-tapping-draggable-content.html: Removed. * fast/events/ios/non-meaningful-click-when-tapping-document-expected.txt: Removed. * fast/events/ios/non-meaningful-click-when-tapping-document.html: Removed. Modified Paths trunk/LayoutTests/ChangeLog trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/page/ChromeClient.h trunk/Source/WebCore/page/EventHandler.cpp trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/UIProcess/API/APIUIClient.h trunk/Source/WebKit/UIProcess/API/Cocoa/WKUIDelegatePrivate.h trunk/Source/WebKit/UIProcess/API/ios/WKWebViewPrivateForTestingIOS.h trunk/Source/WebKit/UIProcess/API/ios/WKWebViewTestingIOS.mm trunk/Source/WebKit/UIProcess/Cocoa/UIDelegate.h trunk/Source/WebKit/UIProcess/Cocoa/UIDelegate.mm trunk/Source/WebKit/UIProcess/PageClient.h trunk/Source/WebKit/UIProcess/WebPageProxy.h
[webkit-changes] [281278] trunk/Source
Title: [281278] trunk/Source
Revision 281278
Author akeer...@apple.com
Date 2021-08-19 16:13:51 -0700 (Thu, 19 Aug 2021)
Log Message
Remove __has_include guard for _UIDatePickerOverlayPresentation
https://bugs.webkit.org/show_bug.cgi?id=227298
rdar://79970171
Reviewed by Tim Horton.
Source/WebKit:
* Platform/spi/ios/UIKitSPI.h:
* UIProcess/ios/forms/WKDateTimeInputControl.mm:
(-[WKDateTimePicker showDateTimePicker]):
Source/WTF:
* wtf/PlatformHave.h:
Modified Paths
trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/PlatformHave.h
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Platform/spi/ios/UIKitSPI.h
trunk/Source/WebKit/UIProcess/ios/forms/WKDateTimeInputControl.mm
Diff
Modified: trunk/Source/WTF/ChangeLog (281277 => 281278)
--- trunk/Source/WTF/ChangeLog 2021-08-19 23:02:50 UTC (rev 281277)
+++ trunk/Source/WTF/ChangeLog 2021-08-19 23:13:51 UTC (rev 281278)
@@ -1,3 +1,13 @@
+2021-08-19 Aditya Keerthi
+
+Remove __has_include guard for _UIDatePickerOverlayPresentation
+https://bugs.webkit.org/show_bug.cgi?id=227298
+rdar://79970171
+
+Reviewed by Tim Horton.
+
+* wtf/PlatformHave.h:
+
2021-08-19 David Kilzer
[WTF] Fix static analyzer warnings for clang tidy bugprone-move-forwarding-reference checker
Modified: trunk/Source/WTF/wtf/PlatformHave.h (281277 => 281278)
--- trunk/Source/WTF/wtf/PlatformHave.h 2021-08-19 23:02:50 UTC (rev 281277)
+++ trunk/Source/WTF/wtf/PlatformHave.h 2021-08-19 23:13:51 UTC (rev 281278)
@@ -1038,6 +1038,7 @@
#if (PLATFORM(IOS) || PLATFORM(MACCATALYST)) && __IPHONE_OS_VERSION_MIN_REQUIRED >= 15
#define HAVE_UICONTEXTMENU_STYLE_CUSTOM_PRESENTATION 1
#define HAVE_UIDATEPICKER_INSETS 1
+#define HAVE_UIDATEPICKER_OVERLAY_PRESENTATION 1
#define HAVE_UIMENUOPTIONS_SINGLE_SELECTION 1
#endif
@@ -1086,11 +1087,6 @@
#define HAVE_QUICKLOOK_PREVIEW_ACTIVITY 1
#endif
-// FIXME: Replace the __has_include check with a version check once internal bots are updated (webkit.org/b/227298).
-#if PLATFORM(IOS_FAMILY) && defined __has_include && __has_include()
-#define HAVE_UIDATEPICKER_OVERLAY_PRESENTATION 1
-#endif
-
#if PLATFORM(IOS) || PLATFORM(MACCATALYST)
#define HAVE_UITOOLBAR_STANDARD_APPEARANCE 1
#endif
Modified: trunk/Source/WebKit/ChangeLog (281277 => 281278)
--- trunk/Source/WebKit/ChangeLog 2021-08-19 23:02:50 UTC (rev 281277)
+++ trunk/Source/WebKit/ChangeLog 2021-08-19 23:13:51 UTC (rev 281278)
@@ -1,3 +1,15 @@
+2021-08-19 Aditya Keerthi
+
+Remove __has_include guard for _UIDatePickerOverlayPresentation
+https://bugs.webkit.org/show_bug.cgi?id=227298
+rdar://79970171
+
+Reviewed by Tim Horton.
+
+* Platform/spi/ios/UIKitSPI.h:
+* UIProcess/ios/forms/WKDateTimeInputControl.mm:
+(-[WKDateTimePicker showDateTimePicker]):
+
2021-08-19 Alex Christensen
Use Vector instead of SandboxExtension::HandleArray
Modified: trunk/Source/WebKit/Platform/spi/ios/UIKitSPI.h (281277 => 281278)
--- trunk/Source/WebKit/Platform/spi/ios/UIKitSPI.h 2021-08-19 23:02:50 UTC (rev 281277)
+++ trunk/Source/WebKit/Platform/spi/ios/UIKitSPI.h 2021-08-19 23:13:51 UTC (rev 281278)
@@ -108,6 +108,10 @@
#import
#endif
+#if HAVE(UIDATEPICKER_OVERLAY_PRESENTATION)
+#import
+#endif
+
#if ENABLE(DRAG_SUPPORT)
#import
#endif
@@ -222,6 +226,28 @@
- (UIEdgeInsets)_appliedInsetsToEdgeOfContent;
@end
+#if HAVE(UIDATEPICKER_OVERLAY_PRESENTATION)
+
+typedef NS_ENUM(NSInteger, _UIDatePickerOverlayAnchor) {
+_UIDatePickerOverlayAnchorSourceRect = 2
+};
+
+@interface _UIDatePickerOverlayPresentation : NSObject
+
+- (instancetype)initWithSourceView:(UIView *)sourceView;
+- (void)presentDatePicker:(UIDatePicker *)datePicker onDismiss:(void(^)(BOOL retargeted))dismissHandler;
+- (void)dismissPresentationAnimated:(BOOL)animated;
+
+@property (nonatomic, weak, readonly) UIView *sourceView;
+@property (nonatomic, assign) CGRect sourceRect;
+@property (nonatomic, assign) _UIDatePickerOverlayAnchor overlayAnchor;
+@property (nonatomic, strong) UIView *accessoryView;
+@property (nonatomic, assign) BOOL accessoryViewIgnoresDefaultInsets;
+
+@end
+
+#endif
+
@interface UIDevice ()
- (void)setOrientation:(UIDeviceOrientation)orientation animated:(BOOL)animated;
@property (nonatomic, readonly, retain) NSString *buildVersion;
@@ -1454,30 +1480,6 @@
@end
#endif
-#if HAVE(UIDATEPICKER_OVERLAY_PRESENTATION)
-
-// FIXME: Import the header directly once bots are updated to a build containing rdar://78779655.
-
-typedef NS_ENUM(NSInteger, _UIDatePickerOverlayAnchor) {
-_UIDatePickerOverlayAnchorSourceRect = 2
-};
-
-@interface _UIDatePickerOverlayPresentation : NSObject
-
-- (instancetype)initWithSourceView:(UIView *)sourceView;
-- (void)presentDatePicker:(UIDatePicker *)datePicker onDismiss:(void(^)(BOOL retargeted))dismissHandler;
-- (void)dismissPresentationAnimated:(BOOL)animated;
-
-@property (nonatomic, weak, readonly) UIView *sourceView;
[webkit-changes] [281277] trunk/Source/WebKit
Title: [281277] trunk/Source/WebKit Revision 281277 Author commit-qu...@webkit.org Date 2021-08-19 16:02:50 -0700 (Thu, 19 Aug 2021) Log Message Use Vector instead of SandboxExtension::HandleArray https://bugs.webkit.org/show_bug.cgi?id=229100 Patch by Alex Christensen on 2021-08-19 Reviewed by Chris Dumez. No change in behavior. Just more modern code. * GPUProcess/GPUProcessCreationParameters.cpp: (WebKit::GPUProcessCreationParameters::decode): * GPUProcess/GPUProcessCreationParameters.h: * NetworkProcess/NetworkResourceLoadParameters.cpp: (WebKit::NetworkResourceLoadParameters::encode const): (WebKit::NetworkResourceLoadParameters::decode): * Platform/IPC/FormDataReference.h: (IPC::FormDataReference::encode const): (IPC::FormDataReference::decode): * Shared/Cocoa/LoadParametersCocoa.mm: (WebKit::LoadParameters::platformDecode): * Shared/Cocoa/SandboxExtensionCocoa.mm: (WebKit::createHandlesForResources): (WebKit::SandboxExtension::createReadOnlyHandlesForFiles): (WebKit::SandboxExtension::createHandlesForMachLookup): (WebKit::SandboxExtension::createHandlesForIOKitClassExtensions): (WebKit::SandboxExtension::consumePermanently): (WebKit::SandboxExtension::HandleArray::HandleArray): Deleted. (WebKit::SandboxExtension::HandleArray::~HandleArray): Deleted. (WebKit::SandboxExtension::HandleArray::allocate): Deleted. (WebKit::SandboxExtension::HandleArray::append): Deleted. (WebKit::SandboxExtension::HandleArray::operator[]): Deleted. (WebKit::SandboxExtension::HandleArray::operator[] const): Deleted. (WebKit::SandboxExtension::HandleArray::size const): Deleted. (WebKit::SandboxExtension::HandleArray::encode const): Deleted. (WebKit::SandboxExtension::HandleArray::decode): Deleted. * Shared/Databases/IndexedDB/WebIDBResult.cpp: (WebKit::WebIDBResult::encode const): (WebKit::WebIDBResult::decode): * Shared/Databases/IndexedDB/WebIDBResult.h: (WebKit::WebIDBResult::WebIDBResult): (WebKit::WebIDBResult::handles const): * Shared/LoadParameters.h: * Shared/SandboxExtension.h: (WebKit::SandboxExtension::Handle::decode): (WebKit::SandboxExtension::createReadOnlyHandlesForFiles): (WebKit::SandboxExtension::consumePermanently): (WebKit::SandboxExtension::HandleArray::at): Deleted. (WebKit::SandboxExtension::HandleArray::HandleArray): Deleted. (WebKit::SandboxExtension::HandleArray::~HandleArray): Deleted. (WebKit::SandboxExtension::HandleArray::allocate): Deleted. (WebKit::SandboxExtension::HandleArray::append): Deleted. (WebKit::SandboxExtension::HandleArray::size const): Deleted. (WebKit::SandboxExtension::HandleArray::operator[] const): Deleted. (WebKit::SandboxExtension::HandleArray::operator[]): Deleted. (WebKit::SandboxExtension::HandleArray::begin): Deleted. (WebKit::SandboxExtension::HandleArray::end): Deleted. (WebKit::SandboxExtension::HandleArray::begin const): Deleted. (WebKit::SandboxExtension::HandleArray::end const): Deleted. (WebKit::SandboxExtension::HandleArray::encode const): Deleted. (WebKit::SandboxExtension::HandleArray::decode): Deleted. * Shared/WebPageCreationParameters.cpp: (WebKit::WebPageCreationParameters::decode): * Shared/WebPageCreationParameters.h: * Shared/WebProcessCreationParameters.cpp: (WebKit::WebProcessCreationParameters::decode): * Shared/WebProcessCreationParameters.h: * UIProcess/Cocoa/WebPageProxyCocoa.mm: (WebKit::WebPageProxy::createSandboxExtensionsIfNeeded): (WebKit::WebPageProxy::createNetworkExtensionsSandboxExtensions): * UIProcess/Cocoa/WebPasteboardProxyCocoa.mm: (WebKit::WebPasteboardProxy::getPasteboardPathnamesForType): * UIProcess/Cocoa/WebProcessProxyCocoa.mm: (WebKit::WebProcessProxy::unblockAccessibilityServerIfNeeded): * UIProcess/Cocoa/WebViewImpl.mm: (WebKit::WebViewImpl::performDragOperation): * UIProcess/UserMediaProcessManager.cpp: (WebKit::UserMediaProcessManager::willCreateMediaStream): * UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::performDragOperation): (WebKit::WebPageProxy::performDragControllerAction): (WebKit::WebPageProxy::processNextQueuedMouseEvent): (WebKit::WebPageProxy::createNetworkExtensionsSandboxExtensions): * UIProcess/WebPageProxy.h: * UIProcess/WebPasteboardProxy.h: * UIProcess/WebPasteboardProxy.messages.in: * UIProcess/WebProcessPool.cpp: (WebKit::WebProcessPool::initializeNewWebProcess): * UIProcess/ios/WKContentViewInteraction.mm: (-[WKContentView dropInteraction:performDrop:]): * WebProcess/MediaStream/MediaDeviceSandboxExtensions.cpp: (WebKit::MediaDeviceSandboxExtensions::MediaDeviceSandboxExtensions): (WebKit::MediaDeviceSandboxExtensions::encode const): (WebKit::MediaDeviceSandboxExtensions::decode): * WebProcess/MediaStream/MediaDeviceSandboxExtensions.h: * WebProcess/WebCoreSupport/WebPlatformStrategies.cpp: (WebKit::WebPlatformStrategies::getPathnamesForType): * WebProcess/WebPage/Cocoa/WebPageCocoa.mm: (WebKit::WebPage::consumeNetworkExtensionSandboxExtensions): * WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::mouseEvent): (WebKit::WebPage::didReceivePolicyDecision):
[webkit-changes] [281276] trunk/Source/WebKit
Title: [281276] trunk/Source/WebKit Revision 281276 Author simon.fra...@apple.com Date 2021-08-19 15:48:25 -0700 (Thu, 19 Aug 2021) Log Message Replace the uint64_t used to identify taps with an ObjectIdentifier<> type https://bugs.webkit.org/show_bug.cgi?id=229278 Reviewed by Wenson Hsieh. Interaction code used "uint64_t requestID" to identify taps, but there are other things that used "uint64_t requestID", which may result in bugs. Fix by using a strongly typed ObjectIdentifier to identify taps. This is defined in IdentifierTypes.h since I expect to add more of them. * Scripts/webkit/messages.py: (types_that_cannot_be_forward_declared): (headers_for_type): * Shared/IdentifierTypes.h: Added. * UIProcess/PageClient.h: * UIProcess/WebPageProxy.h: * UIProcess/WebPageProxy.messages.in: * UIProcess/ios/PageClientImplIOS.h: * UIProcess/ios/PageClientImplIOS.mm: (WebKit::PageClientImpl::disableDoubleTapGesturesDuringTapIfNecessary): (WebKit::PageClientImpl::handleSmartMagnificationInformationForPotentialTap): (WebKit::PageClientImpl::didGetTapHighlightGeometries): * UIProcess/ios/WKContentViewInteraction.h: * UIProcess/ios/WKContentViewInteraction.mm: (-[WKContentView _didGetTapHighlightForRequest:color:quads:topLeftRadius:topRightRadius:bottomLeftRadius:bottomRightRadius:nodeHasBuiltInClickHandling:]): (-[WKContentView _disableDoubleTapGesturesDuringTapIfNecessary:]): (-[WKContentView _handleSmartMagnificationInformationForPotentialTap:renderRect:fitEntireRect:viewportMinimumScale:viewportMaximumScale:nodeIsRootLevel:]): (-[WKContentView nextTapIdentifier]): (-[WKContentView _highlightLongPressRecognized:]): (-[WKContentView _twoFingerSingleTapGestureRecognized:]): (-[WKContentView _singleTapIdentified:]): * UIProcess/ios/WebPageProxyIOS.mm: (WebKit::WebPageProxy::handleTwoFingerTapAtPoint): (WebKit::WebPageProxy::potentialTapAtPosition): (WebKit::WebPageProxy::tapHighlightAtPosition): (WebKit::WebPageProxy::didGetTapHighlightGeometries): (WebKit::WebPageProxy::disableDoubleTapGesturesDuringTapIfNecessary): (WebKit::WebPageProxy::handleSmartMagnificationInformationForPotentialTap): * WebKit.xcodeproj/project.pbxproj: * WebProcess/WebPage/WebPage.h: * WebProcess/WebPage/WebPage.messages.in: * WebProcess/WebPage/ios/WebPageIOS.mm: (WebKit::WebPage::sendTapHighlightForNodeIfNecessary): (WebKit::WebPage::handleTwoFingerTapAtPoint): (WebKit::WebPage::potentialTapAtPosition): (WebKit::WebPage::tapHighlightAtPosition): Modified Paths trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/Scripts/webkit/messages.py trunk/Source/WebKit/UIProcess/PageClient.h trunk/Source/WebKit/UIProcess/WebPageProxy.h trunk/Source/WebKit/UIProcess/WebPageProxy.messages.in trunk/Source/WebKit/UIProcess/ios/PageClientImplIOS.h trunk/Source/WebKit/UIProcess/ios/PageClientImplIOS.mm trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.h trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm trunk/Source/WebKit/UIProcess/ios/WebPageProxyIOS.mm trunk/Source/WebKit/WebKit.xcodeproj/project.pbxproj trunk/Source/WebKit/WebProcess/WebPage/WebPage.h trunk/Source/WebKit/WebProcess/WebPage/WebPage.messages.in trunk/Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm Added Paths trunk/Source/WebKit/Shared/IdentifierTypes.h Diff Modified: trunk/Source/WebKit/ChangeLog (281275 => 281276) --- trunk/Source/WebKit/ChangeLog 2021-08-19 22:32:47 UTC (rev 281275) +++ trunk/Source/WebKit/ChangeLog 2021-08-19 22:48:25 UTC (rev 281276) @@ -1,3 +1,53 @@ +2021-08-19 Simon Fraser + +Replace the uint64_t used to identify taps with an ObjectIdentifier<> type +https://bugs.webkit.org/show_bug.cgi?id=229278 + +Reviewed by Wenson Hsieh. + +Interaction code used "uint64_t requestID" to identify taps, but there are other +things that used "uint64_t requestID", which may result in bugs. + +Fix by using a strongly typed ObjectIdentifier to identify taps. +This is defined in IdentifierTypes.h since I expect to add more of them. + +* Scripts/webkit/messages.py: +(types_that_cannot_be_forward_declared): +(headers_for_type): +* Shared/IdentifierTypes.h: Added. +* UIProcess/PageClient.h: +* UIProcess/WebPageProxy.h: +* UIProcess/WebPageProxy.messages.in: +* UIProcess/ios/PageClientImplIOS.h: +* UIProcess/ios/PageClientImplIOS.mm: +(WebKit::PageClientImpl::disableDoubleTapGesturesDuringTapIfNecessary): +(WebKit::PageClientImpl::handleSmartMagnificationInformationForPotentialTap): +(WebKit::PageClientImpl::didGetTapHighlightGeometries): +* UIProcess/ios/WKContentViewInteraction.h: +* UIProcess/ios/WKContentViewInteraction.mm: +(-[WKContentView _didGetTapHighlightForRequest:color:quads:topLeftRadius:topRightRadius:bottomLeftRadius:bottomRightRadius:nodeHasBuiltInClickHandling:]): +(-[WKContentView _disableDoubleTapGesturesDuringTapIfNecessary:]): +
[webkit-changes] [281275] trunk/Tools
Title: [281275] trunk/Tools
Revision 281275
Author megan_gard...@apple.com
Date 2021-08-19 15:32:47 -0700 (Thu, 19 Aug 2021)
Log Message
Turn on TestWebKitAPI.WKAttachmentTests.CopyAndPasteBetweenWebViews as it is now passing again.
https://bugs.webkit.org/show_bug.cgi?id=204969
Reviewed by Tim Horton.
* TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
(TestWebKitAPI::TEST):
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm
Diff
Modified: trunk/Tools/ChangeLog (281274 => 281275)
--- trunk/Tools/ChangeLog 2021-08-19 22:28:50 UTC (rev 281274)
+++ trunk/Tools/ChangeLog 2021-08-19 22:32:47 UTC (rev 281275)
@@ -1,3 +1,13 @@
+2021-08-19 Megan Gardner
+
+Turn on TestWebKitAPI.WKAttachmentTests.CopyAndPasteBetweenWebViews as it is now passing again.
+https://bugs.webkit.org/show_bug.cgi?id=204969
+
+Reviewed by Tim Horton.
+
+* TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
+(TestWebKitAPI::TEST):
+
2021-08-19 Andres Gonzalez
Rename AccessibilityUIElement::setSelectedVisibleTextRange to setSelectedTextMarkerRange for naming consistency and maintainability.
Modified: trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm (281274 => 281275)
--- trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm 2021-08-19 22:28:50 UTC (rev 281274)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm 2021-08-19 22:32:47 UTC (rev 281275)
@@ -1487,8 +1487,6 @@
EXPECT_EQ([FileWrapper class], [insertedAttachments.firstObject.info.fileWrapper class]);
}
-// FIXME: Remove this version guard once rdar://51752593 is resolved.
-#if PLATFORM(IOS) && __IPHONE_OS_VERSION_MAX_ALLOWED < 13
TEST(WKAttachmentTests, CopyAndPasteBetweenWebViews)
{
auto file = adoptNS([[NSFileWrapper alloc] initRegularFileWithContents:testHTMLData()]);
@@ -1534,7 +1532,6 @@
EXPECT_WK_STREQ("public.directory", pastedFolderInfo.contentType);
EXPECT_WK_STREQ("application/zip", pastedArchiveInfo.contentType);
}
-#endif // PLATFORM(IOS) && __IPHONE_OS_VERSION_MAX_ALLOWED < 13
TEST(WKAttachmentTests, AttachmentIdentifierOfClonedAttachment)
{
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [281274] trunk
Title: [281274] trunk
Revision 281274
Author andresg...@apple.com
Date 2021-08-19 15:28:50 -0700 (Thu, 19 Aug 2021)
Log Message
Rename AccessibilityUIElement::setSelectedVisibleTextRange to setSelectedTextMarkerRange for naming consistency and maintainability.
https://bugs.webkit.org/show_bug.cgi?id=229290
Reviewed by Chris Fleizach.
Tools:
Renamed this method for consistency and to reflect what it is actually
doing. The goal is to avoid confusion with methods for VisiblePosition,
VisibleSelection and so forth, which are Core objects not exposed to AX
clients.
* DumpRenderTree/AccessibilityUIElement.cpp:
(setSelectedTextMarkerRangeCallback):
(AccessibilityUIElement::setSelectedTextMarkerRange):
(AccessibilityUIElement::getJSClass):
(setSelectedVisibleTextRangeCallback): Deleted.
(AccessibilityUIElement::setSelectedVisibleTextRange): Deleted.
* DumpRenderTree/AccessibilityUIElement.h:
* DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
(AccessibilityUIElement::setSelectedTextMarkerRange):
(AccessibilityUIElement::setSelectedVisibleTextRange): Deleted.
* DumpRenderTree/mac/AccessibilityUIElementMac.mm:
(AccessibilityUIElement::setSelectedTextMarkerRange):
(AccessibilityUIElement::setSelectedVisibleTextRange): Deleted.
* WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
* WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
* WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
(WTR::AccessibilityUIElement::setSelectedTextMarkerRange):
(WTR::AccessibilityUIElement::setSelectedVisibleTextRange): Deleted.
* WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
(WTR::AccessibilityUIElement::setSelectedTextMarkerRange):
(WTR::AccessibilityUIElement::setSelectedVisibleTextRange): Deleted.
* WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
(WTR::AccessibilityUIElement::setSelectedTextMarkerRange):
(WTR::AccessibilityUIElement::setSelectedVisibleTextRange): Deleted.
* WebKitTestRunner/InjectedBundle/win/AccessibilityUIElementWin.cpp:
(WTR::AccessibilityUIElement::setSelectedTextMarkerRange):
(WTR::AccessibilityUIElement::setSelectedVisibleTextRange): Deleted.
LayoutTests:
Updated all test files to use new name.
* accessibility/mac/selected-visible-position-range.html:
* accessibility/mac/selection-sync.html:
* accessibility/mac/wk1-set-selected-text-marker-range-input-element.html:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/accessibility/mac/selected-visible-position-range.html
trunk/LayoutTests/accessibility/mac/selection-sync.html
trunk/LayoutTests/accessibility/mac/wk1-set-selected-text-marker-range-input-element.html
trunk/Tools/ChangeLog
trunk/Tools/DumpRenderTree/AccessibilityUIElement.cpp
trunk/Tools/DumpRenderTree/AccessibilityUIElement.h
trunk/Tools/DumpRenderTree/ios/AccessibilityUIElementIOS.mm
trunk/Tools/DumpRenderTree/mac/AccessibilityUIElementMac.mm
trunk/Tools/WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h
trunk/Tools/WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl
trunk/Tools/WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp
trunk/Tools/WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm
trunk/Tools/WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm
trunk/Tools/WebKitTestRunner/InjectedBundle/win/AccessibilityUIElementWin.cpp
Diff
Modified: trunk/LayoutTests/ChangeLog (281273 => 281274)
--- trunk/LayoutTests/ChangeLog 2021-08-19 22:25:01 UTC (rev 281273)
+++ trunk/LayoutTests/ChangeLog 2021-08-19 22:28:50 UTC (rev 281274)
@@ -1,3 +1,17 @@
+2021-08-19 Andres Gonzalez
+
+Rename AccessibilityUIElement::setSelectedVisibleTextRange to setSelectedTextMarkerRange for naming consistency and maintainability.
+https://bugs.webkit.org/show_bug.cgi?id=229290
+
+
+Reviewed by Chris Fleizach.
+
+Updated all test files to use new name.
+
+* accessibility/mac/selected-visible-position-range.html:
+* accessibility/mac/selection-sync.html:
+* accessibility/mac/wk1-set-selected-text-marker-range-input-element.html:
+
2021-08-19 Alan Bujtas
[LFC][IFC] Add support for overflow-wrap: anywhere
Modified: trunk/LayoutTests/accessibility/mac/selected-visible-position-range.html (281273 => 281274)
--- trunk/LayoutTests/accessibility/mac/selected-visible-position-range.html 2021-08-19 22:25:01 UTC (rev 281273)
+++ trunk/LayoutTests/accessibility/mac/selected-visible-position-range.html 2021-08-19 22:28:50 UTC (rev 281274)
@@ -42,7 +42,7 @@
var end = content.startTextMarkerForTextMarkerRange(selectedRange);
var start = content.previousParagraphStartTextMarkerForTextMarker(end);
var range = content.textMarkerRangeForMarkers(start, end);
-content.setSelectedVisibleTextRange(range);
+content.setSelectedTextMarkerRange(range);
await waitFor(() => {
selectedRange =
[webkit-changes] [281273] trunk/Source/WebKitLegacy
Title: [281273] trunk/Source/WebKitLegacy
Revision 281273
Author megan_gard...@apple.com
Date 2021-08-19 15:25:01 -0700 (Thu, 19 Aug 2021)
Log Message
Remove old unused code and out of date comments.
https://bugs.webkit.org/show_bug.cgi?id=229210
Reviewed by Anders Carlsson.
Source/WebKitLegacy/ios:
* WebKit.iOS.exp:
Source/WebKitLegacy/mac:
* WebView/WebView.mm:
* WebView/WebViewPrivate.h:
Modified Paths
trunk/Source/WebKitLegacy/ios/ChangeLog
trunk/Source/WebKitLegacy/ios/WebKit.iOS.exp
trunk/Source/WebKitLegacy/mac/ChangeLog
trunk/Source/WebKitLegacy/mac/WebView/WebView.mm
trunk/Source/WebKitLegacy/mac/WebView/WebViewPrivate.h
Diff
Modified: trunk/Source/WebKitLegacy/ios/ChangeLog (281272 => 281273)
--- trunk/Source/WebKitLegacy/ios/ChangeLog 2021-08-19 22:23:31 UTC (rev 281272)
+++ trunk/Source/WebKitLegacy/ios/ChangeLog 2021-08-19 22:25:01 UTC (rev 281273)
@@ -1,3 +1,12 @@
+2021-08-19 Megan Gardner
+
+Remove old unused code and out of date comments.
+https://bugs.webkit.org/show_bug.cgi?id=229210
+
+Reviewed by Anders Carlsson.
+
+* WebKit.iOS.exp:
+
2021-05-30 Darin Adler
Remove WTF::Optional synonym for std::optional, using that class template directly instead
Modified: trunk/Source/WebKitLegacy/ios/WebKit.iOS.exp (281272 => 281273)
--- trunk/Source/WebKitLegacy/ios/WebKit.iOS.exp 2021-08-19 22:23:31 UTC (rev 281272)
+++ trunk/Source/WebKitLegacy/ios/WebKit.iOS.exp 2021-08-19 22:25:01 UTC (rev 281273)
@@ -40,8 +40,5 @@
_WebViewProgressBackgroundColorKey
_WebViewProgressEstimatedProgressKey
-# For WebInspector notifications
-__WebViewRemoteInspectorHasSessionChangedNotification
-
# WebKit1 internal types exposed for WebKit2.
.objc_class_name_WebGeolocationCoreLocationProvider
Modified: trunk/Source/WebKitLegacy/mac/ChangeLog (281272 => 281273)
--- trunk/Source/WebKitLegacy/mac/ChangeLog 2021-08-19 22:23:31 UTC (rev 281272)
+++ trunk/Source/WebKitLegacy/mac/ChangeLog 2021-08-19 22:25:01 UTC (rev 281273)
@@ -1,3 +1,13 @@
+2021-08-19 Megan Gardner
+
+Remove old unused code and out of date comments.
+https://bugs.webkit.org/show_bug.cgi?id=229210
+
+Reviewed by Anders Carlsson.
+
+* WebView/WebView.mm:
+* WebView/WebViewPrivate.h:
+
2021-08-19 Alex Christensen
Remove more non-inclusive language from Source
Modified: trunk/Source/WebKitLegacy/mac/WebView/WebView.mm (281272 => 281273)
--- trunk/Source/WebKitLegacy/mac/WebView/WebView.mm 2021-08-19 22:23:31 UTC (rev 281272)
+++ trunk/Source/WebKitLegacy/mac/WebView/WebView.mm 2021-08-19 22:25:01 UTC (rev 281273)
@@ -959,11 +959,6 @@
NSString *_WebViewDidStartAcceleratedCompositingNotification = @"_WebViewDidStartAcceleratedCompositing";
NSString * const WebViewWillCloseNotification = @"WebViewWillCloseNotification";
-#if ENABLE(REMOTE_INSPECTOR)
-// FIXME: Legacy, remove this, switch to something from _javascript_Core Inspector::RemoteInspectorServer.
-NSString *_WebViewRemoteInspectorHasSessionChangedNotification = @"_WebViewRemoteInspectorHasSessionChangedNotification";
-#endif
-
@interface WebProgressItem : NSObject
{
@public
@@ -8105,13 +8100,11 @@
#if !PLATFORM(IOS_FAMILY)
@implementation WebView (WebViewGrammarChecking)
-// FIXME: This method should be merged into WebViewEditing when we're not in API freeze
- (BOOL)isGrammarCheckingEnabled
{
return grammarCheckingEnabled;
}
-// FIXME: This method should be merged into WebViewEditing when we're not in API freeze
- (void)setGrammarCheckingEnabled:(BOOL)flag
{
if (grammarCheckingEnabled == flag)
@@ -8128,7 +8121,6 @@
[[self mainFrame] _unmarkAllBadGrammar];
}
-// FIXME: This method should be merged into WebIBActions when we're not in API freeze
- (void)toggleGrammarChecking:(id)sender
{
[self setGrammarCheckingEnabled:![self isGrammarCheckingEnabled]];
Modified: trunk/Source/WebKitLegacy/mac/WebView/WebViewPrivate.h (281272 => 281273)
--- trunk/Source/WebKitLegacy/mac/WebView/WebViewPrivate.h 2021-08-19 22:23:31 UTC (rev 281272)
+++ trunk/Source/WebKitLegacy/mac/WebView/WebViewPrivate.h 2021-08-19 22:25:01 UTC (rev 281273)
@@ -105,13 +105,6 @@
// One of the subviews of the WebView entered compositing mode.
extern NSString *_WebViewDidStartAcceleratedCompositingNotification;
-#if ENABLE_REMOTE_INSPECTOR
-// FIXME: Legacy, remove this, switch to something from _javascript_Core Inspector::RemoteInspectorServer.
-// Notification when the number of inspector sessions becomes non-zero or returns to 0.
-// Check the current state via -[WebView _hasRemoteInspectorSession].
-extern NSString *_WebViewRemoteInspectorHasSessionChangedNotification;
-#endif
-
#if TARGET_OS_IPHONE
extern NSString *WebQuickLookFileNameKey;
extern NSString *WebQuickLookUTIKey;
@@ -160,11 +153,6 @@
WebPaginationModeRightToLeft,
WebPaginationModeTopToBottom,
WebPaginationModeBottomToTop,
-#if TARGET_OS_IPHONE
-// FIXME:
[webkit-changes] [281272] trunk/Source/WebCore
Title: [281272] trunk/Source/WebCore
Revision 281272
Author za...@apple.com
Date 2021-08-19 15:23:31 -0700 (Thu, 19 Aug 2021)
Log Message
[Line layout] "zero width space" (U+200B) is a breaking space
https://bugs.webkit.org/show_bug.cgi?id=227858
Reviewed by Antti Koivisto.
This is a workaround for handling mismatching prior-context content in break iterators.
* layout/formattingContexts/inline/InlineLineBuilder.cpp:
(WebCore::Layout::endsWithSoftWrapOpportunity):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (281271 => 281272)
--- trunk/Source/WebCore/ChangeLog 2021-08-19 21:59:52 UTC (rev 281271)
+++ trunk/Source/WebCore/ChangeLog 2021-08-19 22:23:31 UTC (rev 281272)
@@ -1,5 +1,17 @@
2021-08-19 Alan Bujtas
+[Line layout] "zero width space" (U+200B) is a breaking space
+https://bugs.webkit.org/show_bug.cgi?id=227858
+
+Reviewed by Antti Koivisto.
+
+This is a workaround for handling mismatching prior-context content in break iterators.
+
+* layout/formattingContexts/inline/InlineLineBuilder.cpp:
+(WebCore::Layout::endsWithSoftWrapOpportunity):
+
+2021-08-19 Alan Bujtas
+
[LFC][IFC] Add support for negative horizontal margin (inline box)
https://bugs.webkit.org/show_bug.cgi?id=227837
Modified: trunk/Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.cpp (281271 => 281272)
--- trunk/Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.cpp 2021-08-19 21:59:52 UTC (rev 281271)
+++ trunk/Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.cpp 2021-08-19 22:23:31 UTC (rev 281272)
@@ -54,7 +54,13 @@
// [ex-][ample] <- second to last[x] last[-] current[a]
// We need at least 1 character in the current inline text item and 2 more from previous inline items.
auto previousContent = currentTextItem.inlineTextBox().content();
-auto lineBreakIterator = LazyLineBreakIterator { nextInlineTextItem.inlineTextBox().content() };
+auto currentContent = nextInlineTextItem.inlineTextBox().content();
+if (currentContent.is8Bit() && !previousContent.is8Bit()) {
+// FIXME: Remove this workaround when we move over to a better way of handling prior-context with unicode.
+// See the templated CharacterType in nextBreakablePosition for last and lastlast characters.
+currentContent = String::make16BitFrom8BitSource(currentContent.characters8(), currentContent.length());
+}
+auto lineBreakIterator = LazyLineBreakIterator { currentContent };
auto previousContentLength = previousContent.length();
// FIXME: We should look into the entire uncommitted content for more text context.
UChar lastCharacter = previousContentLength ? previousContent[previousContentLength - 1] : 0;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [281271] trunk/Source/WebCore
Title: [281271] trunk/Source/WebCore
Revision 281271
Author za...@apple.com
Date 2021-08-19 14:59:52 -0700 (Thu, 19 Aug 2021)
Log Message
[LFC][IFC] Add support for negative horizontal margin (inline box)
https://bugs.webkit.org/show_bug.cgi?id=227837
Reviewed by Antti Koivisto.
When building up the line for line breaking, each inline item is placed adjacent with no gaps
in-between the neighboring entries. They are considered atomic with their margins, padding, borders and content width.
Later when we form the inline runs out of these entries, we offset them by their horizontal margin values.
* layout/formattingContexts/inline/InlineLine.cpp:
(WebCore::Layout::Line::appendInlineBoxStart):
* layout/integration/LayoutIntegrationCoverage.cpp:
(WebCore::LayoutIntegration::printReason):
(WebCore::LayoutIntegration::canUseForChild):
* layout/integration/LayoutIntegrationCoverage.h:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/layout/formattingContexts/inline/InlineFormattingGeometry.cpp
trunk/Source/WebCore/layout/formattingContexts/inline/InlineLine.cpp
trunk/Source/WebCore/layout/integration/LayoutIntegrationCoverage.cpp
trunk/Source/WebCore/layout/integration/LayoutIntegrationCoverage.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (281270 => 281271)
--- trunk/Source/WebCore/ChangeLog 2021-08-19 21:25:12 UTC (rev 281270)
+++ trunk/Source/WebCore/ChangeLog 2021-08-19 21:59:52 UTC (rev 281271)
@@ -1,5 +1,23 @@
2021-08-19 Alan Bujtas
+[LFC][IFC] Add support for negative horizontal margin (inline box)
+https://bugs.webkit.org/show_bug.cgi?id=227837
+
+Reviewed by Antti Koivisto.
+
+When building up the line for line breaking, each inline item is placed adjacent with no gaps
+in-between the neighboring entries. They are considered atomic with their margins, padding, borders and content width.
+Later when we form the inline runs out of these entries, we offset them by their horizontal margin values.
+
+* layout/formattingContexts/inline/InlineLine.cpp:
+(WebCore::Layout::Line::appendInlineBoxStart):
+* layout/integration/LayoutIntegrationCoverage.cpp:
+(WebCore::LayoutIntegration::printReason):
+(WebCore::LayoutIntegration::canUseForChild):
+* layout/integration/LayoutIntegrationCoverage.h:
+
+2021-08-19 Alan Bujtas
+
[LFC][IFC] Add support for overflow-wrap: anywhere
https://bugs.webkit.org/show_bug.cgi?id=227695
Modified: trunk/Source/WebCore/layout/formattingContexts/inline/InlineFormattingGeometry.cpp (281270 => 281271)
--- trunk/Source/WebCore/layout/formattingContexts/inline/InlineFormattingGeometry.cpp 2021-08-19 21:25:12 UTC (rev 281270)
+++ trunk/Source/WebCore/layout/formattingContexts/inline/InlineFormattingGeometry.cpp 2021-08-19 21:59:52 UTC (rev 281271)
@@ -312,13 +312,11 @@
if (run.isInlineBoxStart()) {
// At this point we don't know yet how wide this inline box is. Let's assume it's as long as the line is
// and adjust it later if we come across an inlineBoxEnd run (see below).
-auto initialLogicalWidth = lineBox.contentLogicalWidth() - run.logicalLeft();
+// Inline box run is based on margin box. Let's convert it to border box.
+auto marginStart = formattingContext().geometryForBox(layoutBox).marginStart();
+auto initialLogicalWidth = lineBox.contentLogicalWidth() - (run.logicalLeft() + marginStart);
ASSERT(initialLogicalWidth >= 0);
-// Inline box run is based on margin box. Let's convert it to border box.
-auto marginStart = std::max(0_lu, formattingContext().geometryForBox(layoutBox).marginStart());
-logicalLeft += marginStart;
-initialLogicalWidth -= marginStart;
-auto inlineBox = InlineLevelBox::createInlineBox(layoutBox, logicalLeft, initialLogicalWidth);
+auto inlineBox = InlineLevelBox::createInlineBox(layoutBox, logicalLeft + marginStart, initialLogicalWidth);
setVerticalGeometryForInlineBox(inlineBox);
simplifiedAlignVerticallyIfApplicable(inlineBox, { });
lineBox.addInlineLevelBox(WTFMove(inlineBox));
@@ -326,12 +324,17 @@
}
if (run.isInlineBoxEnd()) {
// Adjust the logical width when the inline box closes on this line.
+// Note that margin end does not affect the logical width (e.g. positive margin right does not make the run wider).
auto& inlineBox = lineBox.inlineLevelBoxForLayoutBox(layoutBox);
ASSERT(inlineBox.isInlineBox());
// Inline box run is based on margin box. Let's convert it to border box.
-auto marginEnd = std::max(0_lu, formattingContext().geometryForBox(layoutBox).marginEnd());
-auto inlineBoxLogicalRight = logicalLeft + run.logicalWidth() - marginEnd;
-
[webkit-changes] [281270] trunk/Source/WTF
Title: [281270] trunk/Source/WTF
Revision 281270
Author ddkil...@apple.com
Date 2021-08-19 14:25:12 -0700 (Thu, 19 Aug 2021)
Log Message
[WTF] Fix static analyzer warnings for clang tidy bugprone-move-forwarding-reference checker
Reviewed by Darin Adler.
* wtf/Deque.h:
(WTF::inlineCapacity>::appendAndBubble):
* wtf/Scope.h:
(WTF::ScopeExit::ScopeExit):
* wtf/ScopedLambda.h:
(WTF::scopedLambda):
* wtf/SharedTask.h:
(WTF::createSharedTask):
- Replace WTFMove() with std::forward<>().
Modified Paths
trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/Deque.h
trunk/Source/WTF/wtf/Scope.h
trunk/Source/WTF/wtf/ScopedLambda.h
trunk/Source/WTF/wtf/SharedTask.h
Diff
Modified: trunk/Source/WTF/ChangeLog (281269 => 281270)
--- trunk/Source/WTF/ChangeLog 2021-08-19 20:50:17 UTC (rev 281269)
+++ trunk/Source/WTF/ChangeLog 2021-08-19 21:25:12 UTC (rev 281270)
@@ -1,3 +1,20 @@
+2021-08-19 David Kilzer
+
+[WTF] Fix static analyzer warnings for clang tidy bugprone-move-forwarding-reference checker
+
+
+Reviewed by Darin Adler.
+
+* wtf/Deque.h:
+(WTF::inlineCapacity>::appendAndBubble):
+* wtf/Scope.h:
+(WTF::ScopeExit::ScopeExit):
+* wtf/ScopedLambda.h:
+(WTF::scopedLambda):
+* wtf/SharedTask.h:
+(WTF::createSharedTask):
+- Replace WTFMove() with std::forward<>().
+
2021-08-19 Alex Christensen
Remove more non-inclusive language from Source
Modified: trunk/Source/WTF/wtf/Deque.h (281269 => 281270)
--- trunk/Source/WTF/wtf/Deque.h 2021-08-19 20:50:17 UTC (rev 281269)
+++ trunk/Source/WTF/wtf/Deque.h 2021-08-19 21:25:12 UTC (rev 281270)
@@ -575,7 +575,7 @@
template
inline void Deque::appendAndBubble(U&& value, const Func& func)
{
-append(WTFMove(value));
+append(std::forward(value));
iterator begin = this->begin();
iterator iter = end();
--iter;
Modified: trunk/Source/WTF/wtf/Scope.h (281269 => 281270)
--- trunk/Source/WTF/wtf/Scope.h 2021-08-19 20:50:17 UTC (rev 281269)
+++ trunk/Source/WTF/wtf/Scope.h 2021-08-19 21:25:12 UTC (rev 281270)
@@ -37,7 +37,7 @@
public:
template
explicit ScopeExit(ExitFunctionParameter&& exitFunction)
-: m_exitFunction(WTFMove(exitFunction))
+: m_exitFunction(std::forward(exitFunction))
{
}
Modified: trunk/Source/WTF/wtf/ScopedLambda.h (281269 => 281270)
--- trunk/Source/WTF/wtf/ScopedLambda.h 2021-08-19 20:50:17 UTC (rev 281269)
+++ trunk/Source/WTF/wtf/ScopedLambda.h 2021-08-19 21:25:12 UTC (rev 281270)
@@ -125,7 +125,7 @@
template
ScopedLambdaFunctor scopedLambda(Functor&& functor)
{
-return ScopedLambdaFunctor(WTFMove(functor));
+return ScopedLambdaFunctor(std::forward(functor));
}
template class ScopedLambdaRefFunctor;
Modified: trunk/Source/WTF/wtf/SharedTask.h (281269 => 281270)
--- trunk/Source/WTF/wtf/SharedTask.h 2021-08-19 20:50:17 UTC (rev 281269)
+++ trunk/Source/WTF/wtf/SharedTask.h 2021-08-19 21:25:12 UTC (rev 281270)
@@ -119,7 +119,7 @@
template
Ref> createSharedTask(Functor&& functor)
{
-return adoptRef(*new SharedTaskFunctor(WTFMove(functor)));
+return adoptRef(*new SharedTaskFunctor(std::forward(functor)));
}
} // namespace WTF
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [281269] branches/safari-612-branch/Source
Title: [281269] branches/safari-612-branch/Source Revision 281269 Author repst...@apple.com Date 2021-08-19 13:50:17 -0700 (Thu, 19 Aug 2021) Log Message Versioning. WebKit-7612.2.1 Modified Paths branches/safari-612-branch/Source/_javascript_Core/Configurations/Version.xcconfig branches/safari-612-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig branches/safari-612-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig branches/safari-612-branch/Source/WebCore/Configurations/Version.xcconfig branches/safari-612-branch/Source/WebCore/PAL/Configurations/Version.xcconfig branches/safari-612-branch/Source/WebInspectorUI/Configurations/Version.xcconfig branches/safari-612-branch/Source/WebKit/Configurations/Version.xcconfig branches/safari-612-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig Diff Modified: branches/safari-612-branch/Source/_javascript_Core/Configurations/Version.xcconfig (281268 => 281269) --- branches/safari-612-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2021-08-19 20:42:34 UTC (rev 281268) +++ branches/safari-612-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2021-08-19 20:50:17 UTC (rev 281269) @@ -22,8 +22,8 @@ // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. MAJOR_VERSION = 612; -MINOR_VERSION = 1; -TINY_VERSION = 29; +MINOR_VERSION = 2; +TINY_VERSION = 1; MICRO_VERSION = 0; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); Modified: branches/safari-612-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig (281268 => 281269) --- branches/safari-612-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig 2021-08-19 20:42:34 UTC (rev 281268) +++ branches/safari-612-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig 2021-08-19 20:50:17 UTC (rev 281269) @@ -22,8 +22,8 @@ // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. MAJOR_VERSION = 612; -MINOR_VERSION = 1; -TINY_VERSION = 29; +MINOR_VERSION = 2; +TINY_VERSION = 1; MICRO_VERSION = 0; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); Modified: branches/safari-612-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (281268 => 281269) --- branches/safari-612-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig 2021-08-19 20:42:34 UTC (rev 281268) +++ branches/safari-612-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig 2021-08-19 20:50:17 UTC (rev 281269) @@ -22,8 +22,8 @@ // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. MAJOR_VERSION = 612; -MINOR_VERSION = 1; -TINY_VERSION = 29; +MINOR_VERSION = 2; +TINY_VERSION = 1; MICRO_VERSION = 0; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); Modified: branches/safari-612-branch/Source/WebCore/Configurations/Version.xcconfig (281268 => 281269) --- branches/safari-612-branch/Source/WebCore/Configurations/Version.xcconfig 2021-08-19 20:42:34 UTC (rev 281268) +++ branches/safari-612-branch/Source/WebCore/Configurations/Version.xcconfig 2021-08-19 20:50:17 UTC (rev 281269) @@ -22,8 +22,8 @@ // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. MAJOR_VERSION = 612; -MINOR_VERSION = 1; -TINY_VERSION = 29; +MINOR_VERSION = 2; +TINY_VERSION = 1; MICRO_VERSION = 0; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); Modified: branches/safari-612-branch/Source/WebCore/PAL/Configurations/Version.xcconfig (281268 => 281269) --- branches/safari-612-branch/Source/WebCore/PAL/Configurations/Version.xcconfig 2021-08-19 20:42:34 UTC (rev 281268) +++ branches/safari-612-branch/Source/WebCore/PAL/Configurations/Version.xcconfig 2021-08-19 20:50:17 UTC (rev 281269) @@ -22,8 +22,8 @@ // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. MAJOR_VERSION = 612; -MINOR_VERSION = 1; -TINY_VERSION = 29; +MINOR_VERSION = 2; +TINY_VERSION = 1; MICRO_VERSION = 0; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); Modified: branches/safari-612-branch/Source/WebInspectorUI/Configurations/Version.xcconfig (281268 => 281269) --- branches/safari-612-branch/Source/WebInspectorUI/Configurations/Version.xcconfig 2021-08-19 20:42:34 UTC (rev 281268) +++ branches/safari-612-branch/Source/WebInspectorUI/Configurations/Version.xcconfig 2021-08-19 20:50:17 UTC (rev 281269) @@ -1,6 +1,6 @@ MAJOR_VERSION = 612; -MINOR_VERSION = 1; -TINY_VERSION = 29; +MINOR_VERSION = 2; +TINY_VERSION = 1; MICRO_VERSION = 0; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); Modified: branches/safari-612-branch/Source/WebKit/Configurations/Version.xcconfig (281268 => 281269) --- branches/safari-612-branch/Source/WebKit/Configurations/Version.xcconfig 2021-08-19 20:42:34 UTC (rev 281268) +++
[webkit-changes] [281265] branches/safari-612.1.29-branch/Source/WebCore
Title: [281265] branches/safari-612.1.29-branch/Source/WebCore
Revision 281265
Author repst...@apple.com
Date 2021-08-19 13:42:15 -0700 (Thu, 19 Aug 2021)
Log Message
Revert "Port HTMLDetailsElement to use modern event handling code"
This reverts commit r281230.
Modified Paths
branches/safari-612.1.29-branch/Source/WebCore/ChangeLog
branches/safari-612.1.29-branch/Source/WebCore/html/HTMLDetailsElement.cpp
branches/safari-612.1.29-branch/Source/WebCore/html/HTMLDetailsElement.h
Diff
Modified: branches/safari-612.1.29-branch/Source/WebCore/ChangeLog (281264 => 281265)
--- branches/safari-612.1.29-branch/Source/WebCore/ChangeLog 2021-08-19 20:36:11 UTC (rev 281264)
+++ branches/safari-612.1.29-branch/Source/WebCore/ChangeLog 2021-08-19 20:42:15 UTC (rev 281265)
@@ -20,23 +20,6 @@
2021-08-19 Tim Nguyen
-Port HTMLDetailsElement to use modern event handling code
-https://bugs.webkit.org/show_bug.cgi?id=228863
-
-Reviewed by Antti Koivisto.
-
-No behaviour change, follows: https://html.spec.whatwg.org/#details-notification-task-steps
-
-* html/HTMLDetailsElement.cpp:
-(WebCore::HTMLDetailsElement::parseAttribute):
-(WebCore::HTMLDetailsElement::toggleOpen):
-(WebCore::detailToggleEventSender): Deleted.
-(WebCore::HTMLDetailsElement::~HTMLDetailsElement): Deleted.
-(WebCore::HTMLDetailsElement::dispatchPendingEvent): Deleted.
-* html/HTMLDetailsElement.h:
-
-2021-08-19 Tim Nguyen
-
Implement ::backdrop pseudo element
https://bugs.webkit.org/show_bug.cgi?id=227801
Modified: branches/safari-612.1.29-branch/Source/WebCore/html/HTMLDetailsElement.cpp (281264 => 281265)
--- branches/safari-612.1.29-branch/Source/WebCore/html/HTMLDetailsElement.cpp 2021-08-19 20:36:11 UTC (rev 281264)
+++ branches/safari-612.1.29-branch/Source/WebCore/html/HTMLDetailsElement.cpp 2021-08-19 20:42:15 UTC (rev 281265)
@@ -24,8 +24,8 @@
#include "AXObjectCache.h"
#include "ElementIterator.h"
-#include "EventLoop.h"
#include "EventNames.h"
+#include "EventSender.h"
#include "HTMLSlotElement.h"
#include "HTMLSummaryElement.h"
#include "LocalizedStrings.h"
@@ -43,6 +43,12 @@
using namespace HTMLNames;
+static DetailEventSender& detailToggleEventSender()
+{
+static NeverDestroyed sharedToggleEventSender(eventNames().toggleEvent);
+return sharedToggleEventSender;
+}
+
static const AtomString& summarySlotName()
{
static MainThreadNeverDestroyed summarySlot("summarySlot");
@@ -92,6 +98,11 @@
ASSERT(hasTagName(detailsTag));
}
+HTMLDetailsElement::~HTMLDetailsElement()
+{
+detailToggleEventSender().cancelEvent(*this);
+}
+
RenderPtr HTMLDetailsElement::createElementRenderer(RenderStyle&& style, const RenderTreePosition&)
{
return createRenderer(*this, WTFMove(style));
@@ -128,6 +139,12 @@
return slot == m_summarySlot;
}
+void HTMLDetailsElement::dispatchPendingEvent(DetailEventSender* eventSender)
+{
+ASSERT_UNUSED(eventSender, eventSender == ());
+dispatchEvent(Event::create(eventNames().toggleEvent, Event::CanBubble::No, Event::IsCancelable::No));
+}
+
void HTMLDetailsElement::parseAttribute(const QualifiedName& name, const AtomString& value)
{
if (name == openAttr) {
@@ -141,15 +158,9 @@
else
root->removeChild(*m_defaultSlot);
-// https://html.spec.whatwg.org/#details-notification-task-steps
-if (m_isToggleEventTaskQueued)
-return;
-
-document().eventLoop().queueTask(TaskSource::DOMManipulation, [protectedThis = GCReachableRef { *this }] {
-protectedThis->dispatchEvent(Event::create(eventNames().toggleEvent, Event::CanBubble::No, Event::IsCancelable::No));
-protectedThis->m_isToggleEventTaskQueued = false;
-});
-m_isToggleEventTaskQueued = true;
+// https://html.spec.whatwg.org/#details-notification-task-steps.
+detailToggleEventSender().cancelEvent(*this);
+detailToggleEventSender().dispatchEventSoon(*this);
}
} else
HTMLElement::parseAttribute(name, value);
@@ -158,7 +169,7 @@
void HTMLDetailsElement::toggleOpen()
{
-setBooleanAttribute(openAttr, !m_isOpen);
+setAttributeWithoutSynchronization(openAttr, m_isOpen ? nullAtom() : emptyAtom());
// We need to post to the document because toggling this element will delete it.
if (AXObjectCache* cache = document().existingAXObjectCache())
Modified: branches/safari-612.1.29-branch/Source/WebCore/html/HTMLDetailsElement.h (281264 => 281265)
--- branches/safari-612.1.29-branch/Source/WebCore/html/HTMLDetailsElement.h 2021-08-19 20:36:11 UTC (rev 281264)
+++ branches/safari-612.1.29-branch/Source/WebCore/html/HTMLDetailsElement.h 2021-08-19 20:42:15 UTC (rev 281265)
@@ -27,10 +27,14 @@
class HTMLSlotElement;
+template class EventSender;
+using DetailEventSender =
[webkit-changes] [281267] branches/safari-612.1.29-branch/Source/WebCore
Title: [281267] branches/safari-612.1.29-branch/Source/WebCore
Revision 281267
Author repst...@apple.com
Date 2021-08-19 13:42:25 -0700 (Thu, 19 Aug 2021)
Log Message
Revert "RTCPeerConnection::m_transceiverSet does not need to be allocated separately from its RTCPeerConnection"
This reverts commit r281231.
Modified Paths
branches/safari-612.1.29-branch/Source/WebCore/ChangeLog
branches/safari-612.1.29-branch/Source/WebCore/Modules/mediastream/RTCPeerConnection.cpp
branches/safari-612.1.29-branch/Source/WebCore/Modules/mediastream/RTCPeerConnection.h
Diff
Modified: branches/safari-612.1.29-branch/Source/WebCore/ChangeLog (281266 => 281267)
--- branches/safari-612.1.29-branch/Source/WebCore/ChangeLog 2021-08-19 20:42:22 UTC (rev 281266)
+++ branches/safari-612.1.29-branch/Source/WebCore/ChangeLog 2021-08-19 20:42:25 UTC (rev 281267)
@@ -1,23 +1,3 @@
-2021-08-19 Youenn Fablet
-
-RTCPeerConnection::m_transceiverSet does not need to be allocated separately from its RTCPeerConnection
-https://bugs.webkit.org/show_bug.cgi?id=229183
-
-Reviewed by Eric Carlson.
-
-No change of behavior.
-
-* Modules/mediastream/RTCPeerConnection.cpp:
-(WebCore::RTCPeerConnection::addTrack):
-(WebCore::RTCPeerConnection::removeTrack):
-(WebCore::RTCPeerConnection::getStats):
-(WebCore::RTCPeerConnection::doClose):
-(WebCore::RTCPeerConnection::addInternalTransceiver):
-(WebCore::RTCPeerConnection::getSenders const):
-(WebCore::RTCPeerConnection::getReceivers const):
-(WebCore::RTCPeerConnection::getTransceivers const):
-* Modules/mediastream/RTCPeerConnection.h:
-
2021-08-19 Carlos Garcia Campos
document.hasFocus() returns true for unfocused pages
Modified: branches/safari-612.1.29-branch/Source/WebCore/Modules/mediastream/RTCPeerConnection.cpp (281266 => 281267)
--- branches/safari-612.1.29-branch/Source/WebCore/Modules/mediastream/RTCPeerConnection.cpp 2021-08-19 20:42:22 UTC (rev 281266)
+++ branches/safari-612.1.29-branch/Source/WebCore/Modules/mediastream/RTCPeerConnection.cpp 2021-08-19 20:42:25 UTC (rev 281267)
@@ -134,7 +134,7 @@
if (isClosed())
return Exception { InvalidStateError };
-for (auto& transceiver : m_transceiverSet.list()) {
+for (auto& transceiver : m_transceiverSet->list()) {
if (transceiver->sender().trackId() == track->id())
return Exception { InvalidAccessError };
}
@@ -158,7 +158,7 @@
bool shouldAbort = true;
RTCRtpTransceiver* senderTransceiver = nullptr;
-for (auto& transceiver : m_transceiverSet.list()) {
+for (auto& transceiver : m_transceiverSet->list()) {
if ( == >sender()) {
senderTransceiver = transceiver.get();
shouldAbort = sender.isStopped() || !sender.track();
@@ -465,7 +465,7 @@
void RTCPeerConnection::getStats(MediaStreamTrack* selector, Ref&& promise)
{
if (selector) {
-for (auto& transceiver : m_transceiverSet.list()) {
+for (auto& transceiver : m_transceiverSet->list()) {
if (transceiver->sender().track() == selector) {
m_backend->getStats(transceiver->sender(), WTFMove(promise));
return;
@@ -513,7 +513,7 @@
m_iceConnectionState = RTCIceConnectionState::Closed;
m_signalingState = RTCSignalingState::Closed;
-for (auto& transceiver : m_transceiverSet.list()) {
+for (auto& transceiver : m_transceiverSet->list()) {
transceiver->stop();
transceiver->sender().stop();
transceiver->receiver().stop();
@@ -610,7 +610,7 @@
void RTCPeerConnection::addInternalTransceiver(Ref&& transceiver)
{
transceiver->setConnection(*this);
-m_transceiverSet.append(WTFMove(transceiver));
+m_transceiverSet->append(WTFMove(transceiver));
}
void RTCPeerConnection::setSignalingState(RTCSignalingState newState)
@@ -777,19 +777,19 @@
Vector> RTCPeerConnection::getSenders() const
{
m_backend->collectTransceivers();
-return m_transceiverSet.senders();
+return m_transceiverSet->senders();
}
Vector> RTCPeerConnection::getReceivers() const
{
m_backend->collectTransceivers();
-return m_transceiverSet.receivers();
+return m_transceiverSet->receivers();
}
const Vector>& RTCPeerConnection::getTransceivers() const
{
m_backend->collectTransceivers();
-return m_transceiverSet.list();
+return m_transceiverSet->list();
}
void RTCPeerConnection::chainOperation(Ref&& promise, Function&&)>&& operation)
@@ -855,7 +855,7 @@
void RTCPeerConnection::updateTransceiverTransports()
{
-for (auto& transceiver : m_transceiverSet.list()) {
+for (auto& transceiver : m_transceiverSet->list()) {
auto& sender = transceiver->sender();
if (auto* senderBackend = sender.backend())
sender.setTransport(getOrCreateDtlsTransport(senderBackend->dtlsTransportBackend()));
[webkit-changes] [281266] branches/safari-612.1.29-branch
Title: [281266] branches/safari-612.1.29-branch Revision 281266 Author repst...@apple.com Date 2021-08-19 13:42:22 -0700 (Thu, 19 Aug 2021) Log Message Revert "Implement ::backdrop pseudo element" This reverts commit r281229. Modified Paths branches/safari-612.1.29-branch/LayoutTests/ChangeLog branches/safari-612.1.29-branch/LayoutTests/TestExpectations branches/safari-612.1.29-branch/LayoutTests/imported/w3c/ChangeLog branches/safari-612.1.29-branch/LayoutTests/imported/w3c/web-platform-tests/css/css-values/ch-empty-pseudo-recalc-on-font-load-expected.txt branches/safari-612.1.29-branch/Source/_javascript_Core/ChangeLog branches/safari-612.1.29-branch/Source/_javascript_Core/inspector/protocol/CSS.json branches/safari-612.1.29-branch/Source/WebCore/ChangeLog branches/safari-612.1.29-branch/Source/WebCore/css/CSSSelector.cpp branches/safari-612.1.29-branch/Source/WebCore/css/CSSSelector.h branches/safari-612.1.29-branch/Source/WebCore/css/SelectorPseudoElementTypeMap.in branches/safari-612.1.29-branch/Source/WebCore/css/dialog.css branches/safari-612.1.29-branch/Source/WebCore/inspector/agents/InspectorCSSAgent.cpp branches/safari-612.1.29-branch/Source/WebCore/rendering/RenderElement.cpp branches/safari-612.1.29-branch/Source/WebCore/rendering/RenderElement.h branches/safari-612.1.29-branch/Source/WebCore/rendering/RenderObject.h branches/safari-612.1.29-branch/Source/WebCore/rendering/style/RenderStyleConstants.cpp branches/safari-612.1.29-branch/Source/WebCore/rendering/style/RenderStyleConstants.h branches/safari-612.1.29-branch/Source/WebCore/rendering/updating/RenderTreeBuilder.cpp branches/safari-612.1.29-branch/Source/WebCore/rendering/updating/RenderTreeUpdater.cpp branches/safari-612.1.29-branch/Source/WebCore/rendering/updating/RenderTreeUpdaterGeneratedContent.cpp branches/safari-612.1.29-branch/Source/WebCore/rendering/updating/RenderTreeUpdaterGeneratedContent.h branches/safari-612.1.29-branch/Source/WebCore/style/StyleTreeResolver.cpp branches/safari-612.1.29-branch/Source/WebInspectorUI/ChangeLog branches/safari-612.1.29-branch/Source/WebInspectorUI/UserInterface/Controllers/CSSManager.js Diff Modified: branches/safari-612.1.29-branch/LayoutTests/ChangeLog (281265 => 281266) --- branches/safari-612.1.29-branch/LayoutTests/ChangeLog 2021-08-19 20:42:15 UTC (rev 281265) +++ branches/safari-612.1.29-branch/LayoutTests/ChangeLog 2021-08-19 20:42:22 UTC (rev 281266) @@ -20,18 +20,6 @@ * platform/glib/TestExpectations: http/tests/images/image-supports-video.html no longer crashes. -2021-08-19 Tim Nguyen - -Implement ::backdrop pseudo element -https://bugs.webkit.org/show_bug.cgi?id=227801 - -Reviewed by Antti Koivisto. - -This adds UA styles, RenderTreeBuilder support and WebInspector support for ::backdrop. -Some imported blink tests now start passing, some still need proper top layer support. - -* TestExpectations: - 2021-08-19 Fujii Hironori [WinCairo] Unreviewed test gardening Modified: branches/safari-612.1.29-branch/LayoutTests/TestExpectations (281265 => 281266) --- branches/safari-612.1.29-branch/LayoutTests/TestExpectations 2021-08-19 20:42:15 UTC (rev 281265) +++ branches/safari-612.1.29-branch/LayoutTests/TestExpectations 2021-08-19 20:42:22 UTC (rev 281266) @@ -2373,10 +2373,17 @@ imported/blink/fast/multicol/outlines-at-column-boundaries.html [ ImageOnlyFailure ] fast/multicol/multicol-with-child-renderLayer-for-input.html [ ImageOnlyFailure ] +# ::backdrop +webkit.org/b/227801 imported/blink/dialog/backdrop-descendant-selector.html [ ImageOnlyFailure ] +webkit.org/b/227801 imported/blink/dialog/backdrop-does-not-inherit.html [ ImageOnlyFailure ] +webkit.org/b/227801 imported/blink/dialog/backdrop-dynamic-style-change.html [ ImageOnlyFailure ] +webkit.org/b/227801 imported/blink/dialog/backdrop-in-flow.html [ ImageOnlyFailure ] +webkit.org/b/227801 imported/blink/dialog/backdrop-stacking-order.html [ ImageOnlyFailure ] + # Top layer tests -webkit.org/b/84796 imported/blink/dialog/backdrop-in-flow.html [ ImageOnlyFailure ] -webkit.org/b/84796 imported/blink/dialog/backdrop-stacking-order.html [ ImageOnlyFailure ] webkit.org/b/84796 imported/blink/dialog/dont-share-style-to-top-layer.html [ ImageOnlyFailure ] +webkit.org/b/84796 imported/blink/dialog/modal-dialog-backdrop.html [ ImageOnlyFailure ] +webkit.org/b/84796 imported/blink/dialog/modal-dialog-generated-content.html [ ImageOnlyFailure ] webkit.org/b/84796 imported/blink/dialog/modal-dialog-in-replaced-renderer.html [ ImageOnlyFailure ] webkit.org/b/84796 imported/blink/dialog/modal-dialog-in-table-column.html [ ImageOnlyFailure ] webkit.org/b/84796 imported/blink/dialog/removed-element-is-removed-from-top-layer.html [ ImageOnlyFailure ] Modified: branches/safari-612.1.29-branch/LayoutTests/imported/w3c/ChangeLog (281265 => 281266) --- branches/safari-612.1.29-branch/LayoutTests/imported/w3c/ChangeLog 2021-08-19
[webkit-changes] [281264] branches/safari-612.1.29-branch/
Title: [281264] branches/safari-612.1.29-branch/ Revision 281264 Author repst...@apple.com Date 2021-08-19 13:36:11 -0700 (Thu, 19 Aug 2021) Log Message New branch. Added Paths branches/safari-612.1.29-branch/ Diff ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [281263] branches/safari-612-branch
Title: [281263] branches/safari-612-branch Revision 281263 Author repst...@apple.com Date 2021-08-19 13:29:59 -0700 (Thu, 19 Aug 2021) Log Message Revert "Add support for RTCDtlsTransport" This reverts commit r281225. Modified Paths branches/safari-612-branch/LayoutTests/imported/w3c/ChangeLog branches/safari-612-branch/LayoutTests/imported/w3c/web-platform-tests/webrtc/RTCDtlsTransport-getRemoteCertificates-expected.txt branches/safari-612-branch/LayoutTests/imported/w3c/web-platform-tests/webrtc/RTCDtlsTransport-state-expected.txt branches/safari-612-branch/LayoutTests/imported/w3c/web-platform-tests/webrtc/RTCPeerConnection-addIceCandidate-connectionSetup-expected.txt branches/safari-612-branch/LayoutTests/imported/w3c/web-platform-tests/webrtc/RTCPeerConnection-helper-test-expected.txt branches/safari-612-branch/LayoutTests/imported/w3c/web-platform-tests/webrtc/RTCPeerConnection-iceConnectionState.https-expected.txt branches/safari-612-branch/LayoutTests/imported/w3c/web-platform-tests/webrtc/RTCPeerConnection-iceGatheringState-expected.txt branches/safari-612-branch/LayoutTests/imported/w3c/web-platform-tests/webrtc/RTCPeerConnection-onnegotiationneeded-expected.txt branches/safari-612-branch/LayoutTests/imported/w3c/web-platform-tests/webrtc/RTCPeerConnection-setLocalDescription-answer-expected.txt branches/safari-612-branch/LayoutTests/imported/w3c/web-platform-tests/webrtc/RTCPeerConnection-setLocalDescription-offer-expected.txt branches/safari-612-branch/LayoutTests/imported/w3c/web-platform-tests/webrtc/RTCRtpSender-transport.https-expected.txt branches/safari-612-branch/LayoutTests/imported/w3c/web-platform-tests/webrtc/RTCRtpTransceiver.https-expected.txt branches/safari-612-branch/LayoutTests/imported/w3c/web-platform-tests/webrtc/idlharness.https.window-expected.txt branches/safari-612-branch/LayoutTests/imported/w3c/web-platform-tests/webrtc/protocol/bundle.https-expected.txt branches/safari-612-branch/LayoutTests/imported/w3c/web-platform-tests/webrtc/protocol/crypto-suite.https-expected.txt branches/safari-612-branch/Source/ThirdParty/libwebrtc/ChangeLog branches/safari-612-branch/Source/ThirdParty/libwebrtc/Configurations/libwebrtc.iOS.exp branches/safari-612-branch/Source/ThirdParty/libwebrtc/Configurations/libwebrtc.iOSsim.exp branches/safari-612-branch/Source/ThirdParty/libwebrtc/Configurations/libwebrtc.mac.exp branches/safari-612-branch/Source/WebCore/CMakeLists.txt branches/safari-612-branch/Source/WebCore/ChangeLog branches/safari-612-branch/Source/WebCore/DerivedSources-input.xcfilelist branches/safari-612-branch/Source/WebCore/DerivedSources-output.xcfilelist branches/safari-612-branch/Source/WebCore/DerivedSources.make branches/safari-612-branch/Source/WebCore/Modules/mediastream/PeerConnectionBackend.cpp branches/safari-612-branch/Source/WebCore/Modules/mediastream/PeerConnectionBackend.h branches/safari-612-branch/Source/WebCore/Modules/mediastream/RTCPeerConnection.cpp branches/safari-612-branch/Source/WebCore/Modules/mediastream/RTCPeerConnection.h branches/safari-612-branch/Source/WebCore/Modules/mediastream/RTCRtpReceiver.h branches/safari-612-branch/Source/WebCore/Modules/mediastream/RTCRtpReceiver.idl branches/safari-612-branch/Source/WebCore/Modules/mediastream/RTCRtpReceiverBackend.h branches/safari-612-branch/Source/WebCore/Modules/mediastream/RTCRtpSender.h branches/safari-612-branch/Source/WebCore/Modules/mediastream/RTCRtpSender.idl branches/safari-612-branch/Source/WebCore/Modules/mediastream/RTCRtpSenderBackend.h branches/safari-612-branch/Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCRtpReceiverBackend.cpp branches/safari-612-branch/Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCRtpReceiverBackend.h branches/safari-612-branch/Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCRtpSenderBackend.cpp branches/safari-612-branch/Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCRtpSenderBackend.h branches/safari-612-branch/Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCUtils.cpp branches/safari-612-branch/Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCUtils.h branches/safari-612-branch/Source/WebCore/Sources.txt branches/safari-612-branch/Source/WebCore/WebCore.xcodeproj/project.pbxproj branches/safari-612-branch/Source/WebCore/bindings/js/WebCoreBuiltinNames.h branches/safari-612-branch/Source/WebCore/dom/EventTargetFactory.in Removed Paths branches/safari-612-branch/Source/WebCore/Modules/mediastream/RTCDtlsTransport.cpp branches/safari-612-branch/Source/WebCore/Modules/mediastream/RTCDtlsTransport.h branches/safari-612-branch/Source/WebCore/Modules/mediastream/RTCDtlsTransport.idl branches/safari-612-branch/Source/WebCore/Modules/mediastream/RTCDtlsTransportBackend.h branches/safari-612-branch/Source/WebCore/Modules/mediastream/RTCDtlsTransportState.h branches/safari-612-branch/Source/WebCore/Modules/mediastream/RTCDtlsTransportState.idl
[webkit-changes] [281262] branches/safari-612-branch/Source/WebCore
Title: [281262] branches/safari-612-branch/Source/WebCore
Revision 281262
Author repst...@apple.com
Date 2021-08-19 13:29:50 -0700 (Thu, 19 Aug 2021)
Log Message
Revert "RTCPeerConnection::m_transceiverSet does not need to be allocated separately from its RTCPeerConnection"
This reverts commit r281231.
Modified Paths
branches/safari-612-branch/Source/WebCore/ChangeLog
branches/safari-612-branch/Source/WebCore/Modules/mediastream/RTCPeerConnection.cpp
branches/safari-612-branch/Source/WebCore/Modules/mediastream/RTCPeerConnection.h
Diff
Modified: branches/safari-612-branch/Source/WebCore/ChangeLog (281261 => 281262)
--- branches/safari-612-branch/Source/WebCore/ChangeLog 2021-08-19 20:29:47 UTC (rev 281261)
+++ branches/safari-612-branch/Source/WebCore/ChangeLog 2021-08-19 20:29:50 UTC (rev 281262)
@@ -1,23 +1,3 @@
-2021-08-19 Youenn Fablet
-
-RTCPeerConnection::m_transceiverSet does not need to be allocated separately from its RTCPeerConnection
-https://bugs.webkit.org/show_bug.cgi?id=229183
-
-Reviewed by Eric Carlson.
-
-No change of behavior.
-
-* Modules/mediastream/RTCPeerConnection.cpp:
-(WebCore::RTCPeerConnection::addTrack):
-(WebCore::RTCPeerConnection::removeTrack):
-(WebCore::RTCPeerConnection::getStats):
-(WebCore::RTCPeerConnection::doClose):
-(WebCore::RTCPeerConnection::addInternalTransceiver):
-(WebCore::RTCPeerConnection::getSenders const):
-(WebCore::RTCPeerConnection::getReceivers const):
-(WebCore::RTCPeerConnection::getTransceivers const):
-* Modules/mediastream/RTCPeerConnection.h:
-
2021-08-19 Carlos Garcia Campos
document.hasFocus() returns true for unfocused pages
Modified: branches/safari-612-branch/Source/WebCore/Modules/mediastream/RTCPeerConnection.cpp (281261 => 281262)
--- branches/safari-612-branch/Source/WebCore/Modules/mediastream/RTCPeerConnection.cpp 2021-08-19 20:29:47 UTC (rev 281261)
+++ branches/safari-612-branch/Source/WebCore/Modules/mediastream/RTCPeerConnection.cpp 2021-08-19 20:29:50 UTC (rev 281262)
@@ -134,7 +134,7 @@
if (isClosed())
return Exception { InvalidStateError };
-for (auto& transceiver : m_transceiverSet.list()) {
+for (auto& transceiver : m_transceiverSet->list()) {
if (transceiver->sender().trackId() == track->id())
return Exception { InvalidAccessError };
}
@@ -158,7 +158,7 @@
bool shouldAbort = true;
RTCRtpTransceiver* senderTransceiver = nullptr;
-for (auto& transceiver : m_transceiverSet.list()) {
+for (auto& transceiver : m_transceiverSet->list()) {
if ( == >sender()) {
senderTransceiver = transceiver.get();
shouldAbort = sender.isStopped() || !sender.track();
@@ -465,7 +465,7 @@
void RTCPeerConnection::getStats(MediaStreamTrack* selector, Ref&& promise)
{
if (selector) {
-for (auto& transceiver : m_transceiverSet.list()) {
+for (auto& transceiver : m_transceiverSet->list()) {
if (transceiver->sender().track() == selector) {
m_backend->getStats(transceiver->sender(), WTFMove(promise));
return;
@@ -513,7 +513,7 @@
m_iceConnectionState = RTCIceConnectionState::Closed;
m_signalingState = RTCSignalingState::Closed;
-for (auto& transceiver : m_transceiverSet.list()) {
+for (auto& transceiver : m_transceiverSet->list()) {
transceiver->stop();
transceiver->sender().stop();
transceiver->receiver().stop();
@@ -610,7 +610,7 @@
void RTCPeerConnection::addInternalTransceiver(Ref&& transceiver)
{
transceiver->setConnection(*this);
-m_transceiverSet.append(WTFMove(transceiver));
+m_transceiverSet->append(WTFMove(transceiver));
}
void RTCPeerConnection::setSignalingState(RTCSignalingState newState)
@@ -777,19 +777,19 @@
Vector> RTCPeerConnection::getSenders() const
{
m_backend->collectTransceivers();
-return m_transceiverSet.senders();
+return m_transceiverSet->senders();
}
Vector> RTCPeerConnection::getReceivers() const
{
m_backend->collectTransceivers();
-return m_transceiverSet.receivers();
+return m_transceiverSet->receivers();
}
const Vector>& RTCPeerConnection::getTransceivers() const
{
m_backend->collectTransceivers();
-return m_transceiverSet.list();
+return m_transceiverSet->list();
}
void RTCPeerConnection::chainOperation(Ref&& promise, Function&&)>&& operation)
@@ -855,7 +855,7 @@
void RTCPeerConnection::updateTransceiverTransports()
{
-for (auto& transceiver : m_transceiverSet.list()) {
+for (auto& transceiver : m_transceiverSet->list()) {
auto& sender = transceiver->sender();
if (auto* senderBackend = sender.backend())
sender.setTransport(getOrCreateDtlsTransport(senderBackend->dtlsTransportBackend()));
Modified:
[webkit-changes] [281261] branches/safari-612-branch
Title: [281261] branches/safari-612-branch Revision 281261 Author repst...@apple.com Date 2021-08-19 13:29:47 -0700 (Thu, 19 Aug 2021) Log Message Revert "Implement ::backdrop pseudo element" This reverts commit r281229. Modified Paths branches/safari-612-branch/LayoutTests/ChangeLog branches/safari-612-branch/LayoutTests/TestExpectations branches/safari-612-branch/LayoutTests/imported/w3c/ChangeLog branches/safari-612-branch/LayoutTests/imported/w3c/web-platform-tests/css/css-values/ch-empty-pseudo-recalc-on-font-load-expected.txt branches/safari-612-branch/Source/_javascript_Core/ChangeLog branches/safari-612-branch/Source/_javascript_Core/inspector/protocol/CSS.json branches/safari-612-branch/Source/WebCore/ChangeLog branches/safari-612-branch/Source/WebCore/css/CSSSelector.cpp branches/safari-612-branch/Source/WebCore/css/CSSSelector.h branches/safari-612-branch/Source/WebCore/css/SelectorPseudoElementTypeMap.in branches/safari-612-branch/Source/WebCore/css/dialog.css branches/safari-612-branch/Source/WebCore/inspector/agents/InspectorCSSAgent.cpp branches/safari-612-branch/Source/WebCore/rendering/RenderElement.cpp branches/safari-612-branch/Source/WebCore/rendering/RenderElement.h branches/safari-612-branch/Source/WebCore/rendering/RenderObject.h branches/safari-612-branch/Source/WebCore/rendering/style/RenderStyleConstants.cpp branches/safari-612-branch/Source/WebCore/rendering/style/RenderStyleConstants.h branches/safari-612-branch/Source/WebCore/rendering/updating/RenderTreeBuilder.cpp branches/safari-612-branch/Source/WebCore/rendering/updating/RenderTreeUpdater.cpp branches/safari-612-branch/Source/WebCore/rendering/updating/RenderTreeUpdaterGeneratedContent.cpp branches/safari-612-branch/Source/WebCore/rendering/updating/RenderTreeUpdaterGeneratedContent.h branches/safari-612-branch/Source/WebCore/style/StyleTreeResolver.cpp branches/safari-612-branch/Source/WebInspectorUI/ChangeLog branches/safari-612-branch/Source/WebInspectorUI/UserInterface/Controllers/CSSManager.js Diff Modified: branches/safari-612-branch/LayoutTests/ChangeLog (281260 => 281261) --- branches/safari-612-branch/LayoutTests/ChangeLog 2021-08-19 20:29:40 UTC (rev 281260) +++ branches/safari-612-branch/LayoutTests/ChangeLog 2021-08-19 20:29:47 UTC (rev 281261) @@ -20,18 +20,6 @@ * platform/glib/TestExpectations: http/tests/images/image-supports-video.html no longer crashes. -2021-08-19 Tim Nguyen - -Implement ::backdrop pseudo element -https://bugs.webkit.org/show_bug.cgi?id=227801 - -Reviewed by Antti Koivisto. - -This adds UA styles, RenderTreeBuilder support and WebInspector support for ::backdrop. -Some imported blink tests now start passing, some still need proper top layer support. - -* TestExpectations: - 2021-08-19 Fujii Hironori [WinCairo] Unreviewed test gardening Modified: branches/safari-612-branch/LayoutTests/TestExpectations (281260 => 281261) --- branches/safari-612-branch/LayoutTests/TestExpectations 2021-08-19 20:29:40 UTC (rev 281260) +++ branches/safari-612-branch/LayoutTests/TestExpectations 2021-08-19 20:29:47 UTC (rev 281261) @@ -2373,10 +2373,17 @@ imported/blink/fast/multicol/outlines-at-column-boundaries.html [ ImageOnlyFailure ] fast/multicol/multicol-with-child-renderLayer-for-input.html [ ImageOnlyFailure ] +# ::backdrop +webkit.org/b/227801 imported/blink/dialog/backdrop-descendant-selector.html [ ImageOnlyFailure ] +webkit.org/b/227801 imported/blink/dialog/backdrop-does-not-inherit.html [ ImageOnlyFailure ] +webkit.org/b/227801 imported/blink/dialog/backdrop-dynamic-style-change.html [ ImageOnlyFailure ] +webkit.org/b/227801 imported/blink/dialog/backdrop-in-flow.html [ ImageOnlyFailure ] +webkit.org/b/227801 imported/blink/dialog/backdrop-stacking-order.html [ ImageOnlyFailure ] + # Top layer tests -webkit.org/b/84796 imported/blink/dialog/backdrop-in-flow.html [ ImageOnlyFailure ] -webkit.org/b/84796 imported/blink/dialog/backdrop-stacking-order.html [ ImageOnlyFailure ] webkit.org/b/84796 imported/blink/dialog/dont-share-style-to-top-layer.html [ ImageOnlyFailure ] +webkit.org/b/84796 imported/blink/dialog/modal-dialog-backdrop.html [ ImageOnlyFailure ] +webkit.org/b/84796 imported/blink/dialog/modal-dialog-generated-content.html [ ImageOnlyFailure ] webkit.org/b/84796 imported/blink/dialog/modal-dialog-in-replaced-renderer.html [ ImageOnlyFailure ] webkit.org/b/84796 imported/blink/dialog/modal-dialog-in-table-column.html [ ImageOnlyFailure ] webkit.org/b/84796 imported/blink/dialog/removed-element-is-removed-from-top-layer.html [ ImageOnlyFailure ] Modified: branches/safari-612-branch/LayoutTests/imported/w3c/ChangeLog (281260 => 281261) --- branches/safari-612-branch/LayoutTests/imported/w3c/ChangeLog 2021-08-19 20:29:40 UTC (rev 281260) +++ branches/safari-612-branch/LayoutTests/imported/w3c/ChangeLog 2021-08-19 20:29:47 UTC (rev 281261) @@ -1,15 +1,3 @@ -2021-08-19 Tim Nguyen
[webkit-changes] [281260] branches/safari-612-branch/Source/WebCore
Title: [281260] branches/safari-612-branch/Source/WebCore
Revision 281260
Author repst...@apple.com
Date 2021-08-19 13:29:40 -0700 (Thu, 19 Aug 2021)
Log Message
Revert "Port HTMLDetailsElement to use modern event handling code"
This reverts commit r281230.
Modified Paths
branches/safari-612-branch/Source/WebCore/ChangeLog
branches/safari-612-branch/Source/WebCore/html/HTMLDetailsElement.cpp
branches/safari-612-branch/Source/WebCore/html/HTMLDetailsElement.h
Diff
Modified: branches/safari-612-branch/Source/WebCore/ChangeLog (281259 => 281260)
--- branches/safari-612-branch/Source/WebCore/ChangeLog 2021-08-19 20:02:53 UTC (rev 281259)
+++ branches/safari-612-branch/Source/WebCore/ChangeLog 2021-08-19 20:29:40 UTC (rev 281260)
@@ -20,23 +20,6 @@
2021-08-19 Tim Nguyen
-Port HTMLDetailsElement to use modern event handling code
-https://bugs.webkit.org/show_bug.cgi?id=228863
-
-Reviewed by Antti Koivisto.
-
-No behaviour change, follows: https://html.spec.whatwg.org/#details-notification-task-steps
-
-* html/HTMLDetailsElement.cpp:
-(WebCore::HTMLDetailsElement::parseAttribute):
-(WebCore::HTMLDetailsElement::toggleOpen):
-(WebCore::detailToggleEventSender): Deleted.
-(WebCore::HTMLDetailsElement::~HTMLDetailsElement): Deleted.
-(WebCore::HTMLDetailsElement::dispatchPendingEvent): Deleted.
-* html/HTMLDetailsElement.h:
-
-2021-08-19 Tim Nguyen
-
Implement ::backdrop pseudo element
https://bugs.webkit.org/show_bug.cgi?id=227801
Modified: branches/safari-612-branch/Source/WebCore/html/HTMLDetailsElement.cpp (281259 => 281260)
--- branches/safari-612-branch/Source/WebCore/html/HTMLDetailsElement.cpp 2021-08-19 20:02:53 UTC (rev 281259)
+++ branches/safari-612-branch/Source/WebCore/html/HTMLDetailsElement.cpp 2021-08-19 20:29:40 UTC (rev 281260)
@@ -24,8 +24,8 @@
#include "AXObjectCache.h"
#include "ElementIterator.h"
-#include "EventLoop.h"
#include "EventNames.h"
+#include "EventSender.h"
#include "HTMLSlotElement.h"
#include "HTMLSummaryElement.h"
#include "LocalizedStrings.h"
@@ -43,6 +43,12 @@
using namespace HTMLNames;
+static DetailEventSender& detailToggleEventSender()
+{
+static NeverDestroyed sharedToggleEventSender(eventNames().toggleEvent);
+return sharedToggleEventSender;
+}
+
static const AtomString& summarySlotName()
{
static MainThreadNeverDestroyed summarySlot("summarySlot");
@@ -92,6 +98,11 @@
ASSERT(hasTagName(detailsTag));
}
+HTMLDetailsElement::~HTMLDetailsElement()
+{
+detailToggleEventSender().cancelEvent(*this);
+}
+
RenderPtr HTMLDetailsElement::createElementRenderer(RenderStyle&& style, const RenderTreePosition&)
{
return createRenderer(*this, WTFMove(style));
@@ -128,6 +139,12 @@
return slot == m_summarySlot;
}
+void HTMLDetailsElement::dispatchPendingEvent(DetailEventSender* eventSender)
+{
+ASSERT_UNUSED(eventSender, eventSender == ());
+dispatchEvent(Event::create(eventNames().toggleEvent, Event::CanBubble::No, Event::IsCancelable::No));
+}
+
void HTMLDetailsElement::parseAttribute(const QualifiedName& name, const AtomString& value)
{
if (name == openAttr) {
@@ -141,15 +158,9 @@
else
root->removeChild(*m_defaultSlot);
-// https://html.spec.whatwg.org/#details-notification-task-steps
-if (m_isToggleEventTaskQueued)
-return;
-
-document().eventLoop().queueTask(TaskSource::DOMManipulation, [protectedThis = GCReachableRef { *this }] {
-protectedThis->dispatchEvent(Event::create(eventNames().toggleEvent, Event::CanBubble::No, Event::IsCancelable::No));
-protectedThis->m_isToggleEventTaskQueued = false;
-});
-m_isToggleEventTaskQueued = true;
+// https://html.spec.whatwg.org/#details-notification-task-steps.
+detailToggleEventSender().cancelEvent(*this);
+detailToggleEventSender().dispatchEventSoon(*this);
}
} else
HTMLElement::parseAttribute(name, value);
@@ -158,7 +169,7 @@
void HTMLDetailsElement::toggleOpen()
{
-setBooleanAttribute(openAttr, !m_isOpen);
+setAttributeWithoutSynchronization(openAttr, m_isOpen ? nullAtom() : emptyAtom());
// We need to post to the document because toggling this element will delete it.
if (AXObjectCache* cache = document().existingAXObjectCache())
Modified: branches/safari-612-branch/Source/WebCore/html/HTMLDetailsElement.h (281259 => 281260)
--- branches/safari-612-branch/Source/WebCore/html/HTMLDetailsElement.h 2021-08-19 20:02:53 UTC (rev 281259)
+++ branches/safari-612-branch/Source/WebCore/html/HTMLDetailsElement.h 2021-08-19 20:29:40 UTC (rev 281260)
@@ -27,10 +27,14 @@
class HTMLSlotElement;
+template class EventSender;
+using DetailEventSender = EventSender;
+
class HTMLDetailsElement final : public HTMLElement {
[webkit-changes] [281259] trunk
Title: [281259] trunk Revision 281259 Author za...@apple.com Date 2021-08-19 13:02:53 -0700 (Thu, 19 Aug 2021) Log Message [LFC][IFC] Add support for overflow-wrap: anywhere https://bugs.webkit.org/show_bug.cgi?id=227695 LayoutTests/imported/w3c: Reviewed by Antti Koivisto. * web-platform-tests/css/css-text/overflow-wrap/overflow-wrap-anywhere-span-002-expected.txt: * web-platform-tests/css/css-text/parsing/overflow-wrap-computed-expected.txt: * web-platform-tests/css/css-text/parsing/overflow-wrap-valid-expected.txt: * web-platform-tests/css/css-text/parsing/word-wrap-computed-expected.txt: * web-platform-tests/css/css-text/parsing/word-wrap-valid-expected.txt: Source/WebCore: Reviewed by Antti Koivisto. Adjust the line breaking logic in IFC to support "overflow-wrap: anywhere". >From the line breaking point of view, "anywhere" and "break-word" work the same way (i.e. an unbreakable content can be broken at an arbitrary position if there are no other, previous break points in the line). https://drafts.csswg.org/css-text-3/#overflow-wrap-property * css/CSSPrimitiveValueMappings.h: (WebCore::CSSPrimitiveValue::CSSPrimitiveValue): (WebCore::CSSPrimitiveValue::operator OverflowWrap const): * css/parser/CSSParserFastPaths.cpp: (WebCore::CSSParserFastPaths::isValidKeywordPropertyAndValue): * layout/formattingContexts/inline/InlineContentBreaker.cpp: (WebCore::Layout::InlineContentBreaker::wordBreakBehavior const): * rendering/style/RenderStyle.h: (WebCore::RenderStyle::breakWords const): * rendering/style/RenderStyleConstants.cpp: (WebCore::operator<<): * rendering/style/RenderStyleConstants.h: * rendering/style/StyleRareInheritedData.h: LayoutTests: Reviewed by Antti Koivisto. * TestExpectations: Progressions. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/TestExpectations trunk/LayoutTests/imported/w3c/ChangeLog trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-text/overflow-wrap/overflow-wrap-anywhere-span-002-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-text/parsing/overflow-wrap-computed-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-text/parsing/overflow-wrap-valid-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-text/parsing/word-wrap-computed-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-text/parsing/word-wrap-valid-expected.txt trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/css/CSSPrimitiveValueMappings.h trunk/Source/WebCore/css/parser/CSSParserFastPaths.cpp trunk/Source/WebCore/layout/formattingContexts/inline/InlineContentBreaker.cpp trunk/Source/WebCore/rendering/style/RenderStyle.h trunk/Source/WebCore/rendering/style/RenderStyleConstants.cpp trunk/Source/WebCore/rendering/style/RenderStyleConstants.h trunk/Source/WebCore/rendering/style/StyleRareInheritedData.h Diff Modified: trunk/LayoutTests/ChangeLog (281258 => 281259) --- trunk/LayoutTests/ChangeLog 2021-08-19 19:58:33 UTC (rev 281258) +++ trunk/LayoutTests/ChangeLog 2021-08-19 20:02:53 UTC (rev 281259) @@ -1,3 +1,12 @@ +2021-08-19 Alan Bujtas + +[LFC][IFC] Add support for overflow-wrap: anywhere +https://bugs.webkit.org/show_bug.cgi?id=227695 + +Reviewed by Antti Koivisto. + +* TestExpectations: Progressions. + 2021-08-19 Eric Hutchison [iOS 15 wk2] storage/indexeddb/dont-wedge-private.html is a flaky failure. Modified: trunk/LayoutTests/TestExpectations (281258 => 281259) --- trunk/LayoutTests/TestExpectations 2021-08-19 19:58:33 UTC (rev 281258) +++ trunk/LayoutTests/TestExpectations 2021-08-19 20:02:53 UTC (rev 281259) @@ -2734,16 +2734,11 @@ webkit.org/b/186045 imported/w3c/web-platform-tests/css/css-animations/animation-delay-009.html [ ImageOnlyFailure Pass ] # overflow-wrap:anywhere feature is not implemented in legacy line layout. -webkit.org/b/195345 imported/w3c/web-platform-tests/css/css-text/overflow-wrap/overflow-wrap-anywhere-001.html [ ImageOnlyFailure ] webkit.org/b/195345 imported/w3c/web-platform-tests/css/css-text/overflow-wrap/overflow-wrap-anywhere-003.html [ ImageOnlyFailure ] -webkit.org/b/195345 imported/w3c/web-platform-tests/css/css-text/overflow-wrap/overflow-wrap-anywhere-005.html [ ImageOnlyFailure ] -webkit.org/b/195345 imported/w3c/web-platform-tests/css/css-text/overflow-wrap/overflow-wrap-anywhere-span-001.html [ ImageOnlyFailure ] webkit.org/b/195345 imported/w3c/web-platform-tests/css/css-text/overflow-wrap/overflow-wrap-min-content-size-001.html [ ImageOnlyFailure ] webkit.org/b/195345 imported/w3c/web-platform-tests/css/css-text/overflow-wrap/overflow-wrap-min-content-size-002.html [ ImageOnlyFailure ] webkit.org/b/195345 imported/w3c/web-platform-tests/css/css-text/overflow-wrap/overflow-wrap-min-content-size-003.html [ ImageOnlyFailure ] -webkit.org/b/195345 imported/w3c/web-platform-tests/css/css-text/word-break/word-break-break-word-overflow-wrap-interactions.html [ ImageOnlyFailure ]
[webkit-changes] [281258] trunk/Source
Title: [281258] trunk/Source
Revision 281258
Author commit-qu...@webkit.org
Date 2021-08-19 12:58:33 -0700 (Thu, 19 Aug 2021)
Log Message
Remove more non-inclusive language from Source
https://bugs.webkit.org/show_bug.cgi?id=229230
Patch by Alex Christensen on 2021-08-19
Reviewed by Myles C. Maxfield.
Source/WebCore:
No change in behavior.
* WebCore.order:
* features.json:
Source/WebInspectorUI:
* UserInterface/External/three.js/three.js:
(return.parseTrackName):
(parseTrackName):
* UserInterface/Views/ConsoleMessageView.js:
(WI.ConsoleMessageView.prototype._formatWithSubstitutionString.styleFormatter):
(WI.ConsoleMessageView.prototype._formatWithSubstitutionString.isAllowedProperty):
(WI.ConsoleMessageView.prototype._formatWithSubstitutionString.isWhitelistedProperty): Deleted.
* UserInterface/Views/DOMTreeElement.js:
(WI.DOMTreeElement.prototype.populateDOMNodeContextMenu):
Source/WebKit:
* mac/WebKit2.order:
Source/WebKitLegacy/mac:
* WebKit.order:
* WebView/WebViewPrivate.h:
Source/WTF:
* icu/unicode/uspoof.h:
This comment change comes from upstream ICU.
* wtf/URL.h:
Modified Paths
trunk/Source/WTF/ChangeLog
trunk/Source/WTF/icu/unicode/uspoof.h
trunk/Source/WTF/wtf/URL.h
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/WebCore.order
trunk/Source/WebCore/features.json
trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/External/three.js/three.js
trunk/Source/WebInspectorUI/UserInterface/Views/ConsoleMessageView.js
trunk/Source/WebInspectorUI/UserInterface/Views/DOMTreeElement.js
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/mac/WebKit2.order
trunk/Source/WebKitLegacy/mac/ChangeLog
trunk/Source/WebKitLegacy/mac/WebKit.order
trunk/Source/WebKitLegacy/mac/WebView/WebViewPrivate.h
Diff
Modified: trunk/Source/WTF/ChangeLog (281257 => 281258)
--- trunk/Source/WTF/ChangeLog 2021-08-19 19:46:00 UTC (rev 281257)
+++ trunk/Source/WTF/ChangeLog 2021-08-19 19:58:33 UTC (rev 281258)
@@ -1,3 +1,14 @@
+2021-08-19 Alex Christensen
+
+Remove more non-inclusive language from Source
+https://bugs.webkit.org/show_bug.cgi?id=229230
+
+Reviewed by Myles C. Maxfield.
+
+* icu/unicode/uspoof.h:
+This comment change comes from upstream ICU.
+* wtf/URL.h:
+
2021-08-18 Ryosuke Niwa
[ iOS Debug ] 12 TestWebKitAPI.WebKitLegacy. tests are crashing
Modified: trunk/Source/WTF/icu/unicode/uspoof.h (281257 => 281258)
--- trunk/Source/WTF/icu/unicode/uspoof.h 2021-08-19 19:46:00 UTC (rev 281257)
+++ trunk/Source/WTF/icu/unicode/uspoof.h 2021-08-19 19:58:33 UTC (rev 281258)
@@ -734,8 +734,9 @@
* }
*
*
- * To disable specific checks and enable all others, the "blacklisted" checks should be ANDed away from
- * ALL_CHECKS. For example, if you are not planning to use the {@link uspoof_areConfusable} functionality,
+ * To disable specific checks and enable all others,
+ * start with ALL_CHECKS and "AND away" the not-desired checks.
+ * For example, if you are not planning to use the {@link uspoof_areConfusable} functionality,
* it is good practice to disable the CONFUSABLE check:
*
*
Modified: trunk/Source/WTF/wtf/URL.h (281257 => 281258)
--- trunk/Source/WTF/wtf/URL.h 2021-08-19 19:46:00 UTC (rev 281257)
+++ trunk/Source/WTF/wtf/URL.h 2021-08-19 19:58:33 UTC (rev 281258)
@@ -262,7 +262,7 @@
WTF_EXPORT_PRIVATE std::optional defaultPortForProtocol(StringView protocol);
WTF_EXPORT_PRIVATE bool isDefaultPortForProtocol(uint16_t port, StringView protocol);
-WTF_EXPORT_PRIVATE bool portAllowed(const URL&); // Blacklist ports that should never be used for Web resources.
+WTF_EXPORT_PRIVATE bool portAllowed(const URL&); // Disallow ports that should never be used for Web resources.
WTF_EXPORT_PRIVATE void registerDefaultPortForProtocolForTesting(uint16_t port, const String& protocol);
WTF_EXPORT_PRIVATE void clearDefaultPortForProtocolMapForTesting();
Modified: trunk/Source/WebCore/ChangeLog (281257 => 281258)
--- trunk/Source/WebCore/ChangeLog 2021-08-19 19:46:00 UTC (rev 281257)
+++ trunk/Source/WebCore/ChangeLog 2021-08-19 19:58:33 UTC (rev 281258)
@@ -1,3 +1,15 @@
+2021-08-19 Alex Christensen
+
+Remove more non-inclusive language from Source
+https://bugs.webkit.org/show_bug.cgi?id=229230
+
+Reviewed by Myles C. Maxfield.
+
+No change in behavior.
+
+* WebCore.order:
+* features.json:
+
2021-08-19 Simon Fraser
Rename Element::clientRect() which does not return a value in web-exposed "client" coordinates
Modified: trunk/Source/WebCore/WebCore.order (281257 => 281258)
--- trunk/Source/WebCore/WebCore.order 2021-08-19 19:46:00 UTC (rev 281257)
+++ trunk/Source/WebCore/WebCore.order 2021-08-19 19:58:33 UTC (rev 281258)
@@ -1643,17 +1643,14 @@
__ZN7WebCore20ElementRuleCollector14addMatchedRuleEPKNS_8RuleDataE
__ZN7WebCore20ElementRuleCollector27sortAndTransferMatchedRulesEv
[webkit-changes] [281257] trunk/Tools
Title: [281257] trunk/Tools
Revision 281257
Author jbed...@apple.com
Date 2021-08-19 12:46:00 -0700 (Thu, 19 Aug 2021)
Log Message
[run-webkit-tests] Handle json crash logs (Part 1)
https://bugs.webkit.org/show_bug.cgi?id=229288
Reviewed by Alexey Proskuryakov.
* Scripts/webkitpy/common/system/crashlogs.py:
(CrashLogs._parse_darwin_crash_log): Attempt to parse crash logs as json, since Monterey .ips
(CrashLogs._find_newest_log_darwin.is_crash_log):
* Scripts/webkitpy/common/system/crashlogs_unittest.py:
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/common/system/crashlogs.py
trunk/Tools/Scripts/webkitpy/common/system/crashlogs_unittest.py
Diff
Modified: trunk/Tools/ChangeLog (281256 => 281257)
--- trunk/Tools/ChangeLog 2021-08-19 19:44:56 UTC (rev 281256)
+++ trunk/Tools/ChangeLog 2021-08-19 19:46:00 UTC (rev 281257)
@@ -1,3 +1,16 @@
+2021-08-19 Jonathan Bedard
+
+[run-webkit-tests] Handle json crash logs (Part 1)
+https://bugs.webkit.org/show_bug.cgi?id=229288
+
+
+Reviewed by Alexey Proskuryakov.
+
+* Scripts/webkitpy/common/system/crashlogs.py:
+(CrashLogs._parse_darwin_crash_log): Attempt to parse crash logs as json, since Monterey .ips
+(CrashLogs._find_newest_log_darwin.is_crash_log):
+* Scripts/webkitpy/common/system/crashlogs_unittest.py:
+
2021-08-19 Carlos Garcia Campos
document.hasFocus() returns true for unfocused pages
Modified: trunk/Tools/Scripts/webkitpy/common/system/crashlogs.py (281256 => 281257)
--- trunk/Tools/Scripts/webkitpy/common/system/crashlogs.py 2021-08-19 19:44:56 UTC (rev 281256)
+++ trunk/Tools/Scripts/webkitpy/common/system/crashlogs.py 2021-08-19 19:46:00 UTC (rev 281257)
@@ -1,5 +1,5 @@
# Copyright (c) 2011, Google Inc. All rights reserved.
-# Copyright (c) 2015, Apple Inc. All rights reserved.
+# Copyright (c) 2015, 2021 Apple Inc. All rights reserved.
#
# Redistribution and use in source and binary forms, with or without
# modification, are permitted provided that the following conditions are
@@ -28,6 +28,7 @@
# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
import datetime
+import json
import logging
import re
@@ -65,8 +66,21 @@
contents = self._host.symbolicate_crash_log_if_needed(path)
if not contents:
return (None, None, None)
+
+lines = contents.splitlines()
+if len(lines) >= 2 and lines[0].startswith('{') and lines[1].startswith('{'):
+try:
+json.loads(lines[0])
+decoded = json.loads('\n'.join(lines[1:]))
+name = decoded.get('procName')
+pid = decoded.get('pid')
+if name and pid:
+return (name, pid, contents)
+except ValueError:
+pass
+
is_sandbox_violation = False
-for line in contents.splitlines():
+for line in lines:
if line.startswith('Sandbox Violation:'):
is_sandbox_violation = True
match = CrashLogs.DARWIN_PROCESS_REGEX.match(line)
@@ -79,7 +93,7 @@
if self._crash_logs_to_skip and fs.join(dirpath, basename) in self._crash_logs_to_skip:
return False
return (basename.startswith(process_name + '_') and (basename.endswith('.crash')) or
-(process_name in basename and basename.endswith('.ips')))
+(process_name in basename and basename.endswith('.ips')))
logs = self._host.filesystem.files_under(self._crash_log_directory, file_filter=is_crash_log)
errors = ''
Modified: trunk/Tools/Scripts/webkitpy/common/system/crashlogs_unittest.py (281256 => 281257)
--- trunk/Tools/Scripts/webkitpy/common/system/crashlogs_unittest.py 2021-08-19 19:44:56 UTC (rev 281256)
+++ trunk/Tools/Scripts/webkitpy/common/system/crashlogs_unittest.py 2021-08-19 19:46:00 UTC (rev 281257)
@@ -1,4 +1,5 @@
# Copyright (C) 2011 Google Inc. All rights reserved.
+# Copyright (c) 2021, Apple Inc. All rights reserved.
#
# Redistribution and use in source and binary forms, with or without
# modification, are permitted provided that the following conditions
@@ -74,6 +75,24 @@
""".format(process_name=process_name, pid=pid)
+def make_mock_ips_crash_report_darwin(process_name, pid):
+return """{{"app_name":"{name}","timestamp":"2011-12-07 13:27:34.816 -0800","name":"{name}"}}
+{{
+ "uptime" : 6900,
+ "procRole" : "Non UI",
+ "version" : 2,
+ "userID" : 501,
+ "deployVersion" : 209,
+ "modelCode" : "MacBookPro16,4",
+ "coalitionID" : 512,
+ "captureTime" : "2011-12-07 13:27:34.816 -0800",
+ "incident" : "----",
+ "bug_type" : "309",
+ "pid" : {pid},
+ "procName" : "{name}"
+}}""".format(name=process_name, pid=pid)
+
+
def make_mock_sandbox_report_darwin(process_name, pid):
return """Incident Identifier:
[webkit-changes] [281256] branches/safari-612-branch/
Title: [281256] branches/safari-612-branch/ Revision 281256 Author repst...@apple.com Date 2021-08-19 12:44:56 -0700 (Thu, 19 Aug 2021) Log Message New branch. Added Paths branches/safari-612-branch/ Diff ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [281255] trunk/LayoutTests
Title: [281255] trunk/LayoutTests Revision 281255 Author ehutchi...@apple.com Date 2021-08-19 11:56:19 -0700 (Thu, 19 Aug 2021) Log Message [iOS 15 wk2] storage/indexeddb/dont-wedge-private.html is a flaky failure. rdar://82134088. Unreviewed test gardening. * platform/ios-wk2/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/ios-wk2/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (281254 => 281255) --- trunk/LayoutTests/ChangeLog 2021-08-19 18:24:00 UTC (rev 281254) +++ trunk/LayoutTests/ChangeLog 2021-08-19 18:56:19 UTC (rev 281255) @@ -1,3 +1,12 @@ +2021-08-19 Eric Hutchison + +[iOS 15 wk2] storage/indexeddb/dont-wedge-private.html is a flaky failure. +rdar://82134088. + +Unreviewed test gardening. + +* platform/ios-wk2/TestExpectations: + 2021-08-19 Ayumi Kojima [ Win EWS ] http/tests/security/no-_javascript_-refresh-spaces.py is flaky crashing. Modified: trunk/LayoutTests/platform/ios-wk2/TestExpectations (281254 => 281255) --- trunk/LayoutTests/platform/ios-wk2/TestExpectations 2021-08-19 18:24:00 UTC (rev 281254) +++ trunk/LayoutTests/platform/ios-wk2/TestExpectations 2021-08-19 18:56:19 UTC (rev 281255) @@ -1997,6 +1997,9 @@ webkit.org/b/228604 http/tests/cookies/same-site/fetch-in-same-origin-service-worker.html [ Pass Timeout ] webkit.org/b/228604 http/tests/cookies/same-site/fetch-in-cross-origin-service-worker.html [ Pass Timeout ] +#rdar://82134088 ([iOS 15] storage/indexeddb/dont-wedge-private.html is a flaky failure) +storage/indexeddb/dont-wedge-private.html [ Pass Failure ] + # These tests currently fail or are flaky in EWS on iOS 14. editing/selection/ios/changing-selection-does-not-trigger-autocapitalization.html [ Pass Timeout ] editing/selection/ios/do-not-hide-selection-in-visible-container.html [ Failure ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [281254] trunk/Source
Title: [281254] trunk/Source
Revision 281254
Author simon.fra...@apple.com
Date 2021-08-19 11:24:00 -0700 (Thu, 19 Aug 2021)
Log Message
Rename Element::clientRect() which does not return a value in web-exposed "client" coordinates
https://bugs.webkit.org/show_bug.cgi?id=229243
Reviewed by Wenson Hsieh.
The result of Element::clientRect() is in the coordinate space of the root view,
not in the space of the Element's Frame, so does not match the other functions on Element
with "client" in the name.
Rename to Element::boundingBoxInRootViewCoordinates() for clarity.
Source/WebCore:
* dom/Element.cpp:
(WebCore::Element::boundingBoxInRootViewCoordinates const):
(WebCore::Element::clientRect const): Deleted.
* dom/Element.h:
* html/MediaElementSession.cpp:
(WebCore::isElementMainContentForPurposesOfAutoplay):
(WebCore::isElementRectMostlyInMainFrame):
* page/Page.cpp:
(WebCore::Page::editableElementsInRect const):
Source/WebKit:
* WebProcess/WebCoreSupport/WebValidationMessageClient.cpp:
(WebKit::WebValidationMessageClient::showValidationMessage):
(WebKit::WebValidationMessageClient::updateValidationBubbleStateIfNeeded):
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::contextForElement const):
* WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::isObscuredElement):
(WebKit::WebPage::textInputContextsInRect):
Source/WebKitLegacy/mac:
* WebCoreSupport/WebValidationMessageClient.mm:
(WebValidationMessageClient::showValidationMessage):
(WebValidationMessageClient::updateValidationBubbleStateIfNeeded):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/Element.cpp
trunk/Source/WebCore/dom/Element.h
trunk/Source/WebCore/html/MediaElementSession.cpp
trunk/Source/WebCore/page/Page.cpp
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/WebProcess/WebCoreSupport/WebValidationMessageClient.cpp
trunk/Source/WebKit/WebProcess/WebPage/WebPage.cpp
trunk/Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm
trunk/Source/WebKitLegacy/mac/ChangeLog
trunk/Source/WebKitLegacy/mac/WebCoreSupport/WebValidationMessageClient.mm
Diff
Modified: trunk/Source/WebCore/ChangeLog (281253 => 281254)
--- trunk/Source/WebCore/ChangeLog 2021-08-19 18:12:29 UTC (rev 281253)
+++ trunk/Source/WebCore/ChangeLog 2021-08-19 18:24:00 UTC (rev 281254)
@@ -1,3 +1,26 @@
+2021-08-19 Simon Fraser
+
+Rename Element::clientRect() which does not return a value in web-exposed "client" coordinates
+https://bugs.webkit.org/show_bug.cgi?id=229243
+
+Reviewed by Wenson Hsieh.
+
+The result of Element::clientRect() is in the coordinate space of the root view,
+not in the space of the Element's Frame, so does not match the other functions on Element
+with "client" in the name.
+
+Rename to Element::boundingBoxInRootViewCoordinates() for clarity.
+
+* dom/Element.cpp:
+(WebCore::Element::boundingBoxInRootViewCoordinates const):
+(WebCore::Element::clientRect const): Deleted.
+* dom/Element.h:
+* html/MediaElementSession.cpp:
+(WebCore::isElementMainContentForPurposesOfAutoplay):
+(WebCore::isElementRectMostlyInMainFrame):
+* page/Page.cpp:
+(WebCore::Page::editableElementsInRect const):
+
2021-08-13 Tim Nguyen
Top layer: handle display: contents and non out-of-flow position values
Modified: trunk/Source/WebCore/dom/Element.cpp (281253 => 281254)
--- trunk/Source/WebCore/dom/Element.cpp 2021-08-19 18:12:29 UTC (rev 281253)
+++ trunk/Source/WebCore/dom/Element.cpp 2021-08-19 18:24:00 UTC (rev 281254)
@@ -1467,6 +1467,13 @@
return view->contentsToRootView(enclosingIntRect(unitedBoundingBoxes(quads)));
}
+IntRect Element::boundingBoxInRootViewCoordinates() const
+{
+if (RenderObject* renderer = this->renderer())
+return document().view()->contentsToRootView(renderer->absoluteBoundingBoxRect());
+return IntRect();
+}
+
static bool layoutOverflowRectContainsAllDescendants(const RenderBox& renderBox)
{
if (renderBox.isRenderView())
@@ -1682,14 +1689,6 @@
{
return DOMRect::create(boundingClientRect());
}
-
-// Note that this is not web-exposed, and does not use the same coordinate system as getBoundingClientRect() and friends.
-IntRect Element::clientRect() const
-{
-if (RenderObject* renderer = this->renderer())
-return document().view()->contentsToRootView(renderer->absoluteBoundingBoxRect());
-return IntRect();
-}
IntRect Element::screenRect() const
{
Modified: trunk/Source/WebCore/dom/Element.h (281253 => 281254)
--- trunk/Source/WebCore/dom/Element.h 2021-08-19 18:12:29 UTC (rev 281253)
+++ trunk/Source/WebCore/dom/Element.h 2021-08-19 18:24:00 UTC (rev 281254)
@@ -194,7 +194,10 @@
virtual int scrollWidth();
virtual int scrollHeight();
+// This updates layout, and has custom handling for SVG.
WEBCORE_EXPORT IntRect boundsInRootViewSpace();
+// This does not update layout, and uses
[webkit-changes] [281253] trunk/LayoutTests
Title: [281253] trunk/LayoutTests Revision 281253 Author ayumi_koj...@apple.com Date 2021-08-19 11:12:29 -0700 (Thu, 19 Aug 2021) Log Message [ Win EWS ] http/tests/security/no-_javascript_-refresh-spaces.py is flaky crashing. https://bugs.webkit.org/show_bug.cgi?id=229300 Unreviewed test gardening. * platform/win/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/win/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (281252 => 281253) --- trunk/LayoutTests/ChangeLog 2021-08-19 18:05:00 UTC (rev 281252) +++ trunk/LayoutTests/ChangeLog 2021-08-19 18:12:29 UTC (rev 281253) @@ -1,3 +1,12 @@ +2021-08-19 Ayumi Kojima + +[ Win EWS ] http/tests/security/no-_javascript_-refresh-spaces.py is flaky crashing. +https://bugs.webkit.org/show_bug.cgi?id=229300 + +Unreviewed test gardening. + +* platform/win/TestExpectations: + 2021-08-13 Tim Nguyen Top layer: handle display: contents and non out-of-flow position values Modified: trunk/LayoutTests/platform/win/TestExpectations (281252 => 281253) --- trunk/LayoutTests/platform/win/TestExpectations 2021-08-19 18:05:00 UTC (rev 281252) +++ trunk/LayoutTests/platform/win/TestExpectations 2021-08-19 18:12:29 UTC (rev 281253) @@ -4679,6 +4679,7 @@ webkit.org/b/229146 http/tests/security/contentSecurityPolicy/worker-blob-inherits-csp-importScripts-redirect-cross-origin-blocked.html [ Pass Failure ] webkit.org/b/229215 http/tests/security/no-_javascript_-refresh-percent-escaped.py [ Pass Crash ] +webkit.org/b/229300 http/tests/security/no-_javascript_-refresh-spaces.py [ Pass Crash ] accessibility/selected-state-changed-notifications.html [ Skip ] accessibility/element-line-rects-and-text.html [ Skip ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [281252] trunk
Title: [281252] trunk Revision 281252 Author n...@apple.com Date 2021-08-19 11:05:00 -0700 (Thu, 19 Aug 2021) Log Message Top layer: handle display: contents and non out-of-flow position values https://bugs.webkit.org/show_bug.cgi?id=229093 Reviewed by Simon Fraser. From: https://fullscreen.spec.whatwg.org/#new-stacking-layer If its specified display property is contents, it computes to block. If its specified position property is not absolute or fixed, it computes to absolute. Test: imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-dialog-element/modal-dialog-display-contents.html Source/WebCore: * style/StyleAdjuster.cpp: (WebCore::Style::Adjuster::adjust const): (WebCore::Style::Adjuster::adjustDisplayContentsStyle const): LayoutTests: * TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/TestExpectations trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/style/StyleAdjuster.cpp Diff Modified: trunk/LayoutTests/ChangeLog (281251 => 281252) --- trunk/LayoutTests/ChangeLog 2021-08-19 17:45:42 UTC (rev 281251) +++ trunk/LayoutTests/ChangeLog 2021-08-19 18:05:00 UTC (rev 281252) @@ -1,3 +1,18 @@ +2021-08-13 Tim Nguyen + +Top layer: handle display: contents and non out-of-flow position values +https://bugs.webkit.org/show_bug.cgi?id=229093 + +Reviewed by Simon Fraser. + +From: https://fullscreen.spec.whatwg.org/#new-stacking-layer +If its specified display property is contents, it computes to block. +If its specified position property is not absolute or fixed, it computes to absolute. + +Test: imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-dialog-element/modal-dialog-display-contents.html + +* TestExpectations: + 2021-08-19 Tim Nguyen Re-import html/semantics/interactive-elements/the-dialog-element WPT - August 19th 2021 Modified: trunk/LayoutTests/TestExpectations (281251 => 281252) --- trunk/LayoutTests/TestExpectations 2021-08-19 17:45:42 UTC (rev 281251) +++ trunk/LayoutTests/TestExpectations 2021-08-19 18:05:00 UTC (rev 281252) @@ -2374,9 +2374,7 @@ fast/multicol/multicol-with-child-renderLayer-for-input.html [ ImageOnlyFailure ] # Top layer tests -webkit.org/b/84796 imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-dialog-element/backdrop-in-flow.html [ ImageOnlyFailure ] webkit.org/b/84796 imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-dialog-element/backdrop-stacking-order.html [ ImageOnlyFailure ] -webkit.org/b/84796 imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-dialog-element/dont-share-style-to-top-layer.html [ ImageOnlyFailure ] webkit.org/b/84796 imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-dialog-element/modal-dialog-in-replaced-renderer.html [ ImageOnlyFailure ] webkit.org/b/84796 imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-dialog-element/modal-dialog-in-table-column.html [ ImageOnlyFailure ] webkit.org/b/84796 imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-dialog-element/removed-element-is-removed-from-top-layer.html [ ImageOnlyFailure ] @@ -2385,7 +2383,6 @@ webkit.org/b/84796 imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-dialog-element/top-layer-stacking-correct-order-remove-readd.html [ ImageOnlyFailure ] webkit.org/b/84796 imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-dialog-element/top-layer-stacking-dynamic.html [ ImageOnlyFailure ] webkit.org/b/84796 imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-dialog-element/top-layer-stacking.html [ ImageOnlyFailure ] -webkit.org/b/229093 imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-dialog-element/modal-dialog-display-contents.html [ ImageOnlyFailure ] # inert subtrees webkit.org/b/110952 imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-dialog-element/inert-node-is-not-highlighted.html [ ImageOnlyFailure ] Modified: trunk/Source/WebCore/ChangeLog (281251 => 281252) --- trunk/Source/WebCore/ChangeLog 2021-08-19 17:45:42 UTC (rev 281251) +++ trunk/Source/WebCore/ChangeLog 2021-08-19 18:05:00 UTC (rev 281252) @@ -1,3 +1,20 @@ +2021-08-13 Tim Nguyen + +Top layer: handle display: contents and non out-of-flow position values +https://bugs.webkit.org/show_bug.cgi?id=229093 + +Reviewed by Simon Fraser. + +From: https://fullscreen.spec.whatwg.org/#new-stacking-layer +If its specified display property is contents, it computes to block. +If its specified position property is not absolute or fixed, it computes to absolute. + +Test: imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-dialog-element/modal-dialog-display-contents.html + +* style/StyleAdjuster.cpp: +
[webkit-changes] [281250] trunk/Source/WebCore/Configurations/WebCoreTestSupport.xcconfig
Title: [281250] trunk/Source/WebCore/Configurations/WebCoreTestSupport.xcconfig Revision 281250 Author d...@apple.com Date 2021-08-19 10:23:25 -0700 (Thu, 19 Aug 2021) Log Message Build fix after r281245. Link with Metal.framework. * Configurations/WebCoreTestSupport.xcconfig: Modified Paths trunk/Source/WebCore/Configurations/WebCoreTestSupport.xcconfig Diff Modified: trunk/Source/WebCore/Configurations/WebCoreTestSupport.xcconfig (281249 => 281250) --- trunk/Source/WebCore/Configurations/WebCoreTestSupport.xcconfig 2021-08-19 17:14:52 UTC (rev 281249) +++ trunk/Source/WebCore/Configurations/WebCoreTestSupport.xcconfig 2021-08-19 17:23:25 UTC (rev 281250) @@ -58,10 +58,10 @@ EXECUTABLE_PREFIX = lib; EXPORTED_SYMBOLS_FILE = ; GCC_SYMBOLS_PRIVATE_EXTERN = YES; -OTHER_LDFLAGS = $(ASAN_OTHER_LDFLAGS) $(ANGLE_LDFLAGS); -OTHER_LDFLAGS[sdk=macos*] = $(ASAN_OTHER_LDFLAGS) -framework AppKit $(ANGLE_LDFLAGS) $(LIBWEBRTC_LDFLAGS); +OTHER_LDFLAGS = $(ASAN_OTHER_LDFLAGS) $(ANGLE_LDFLAGS) -framework Metal; +OTHER_LDFLAGS[sdk=macos*] = $(ASAN_OTHER_LDFLAGS) -framework AppKit -framework Metal $(ANGLE_LDFLAGS) $(LIBWEBRTC_LDFLAGS); -OTHER_LDFLAGS[sdk=iphone*] = $(ASAN_OTHER_LDFLAGS) -lAccessibility -framework CoreText $(ANGLE_LDFLAGS) $(LIBWEBRTC_LDFLAGS); +OTHER_LDFLAGS[sdk=iphone*] = $(ASAN_OTHER_LDFLAGS) -lAccessibility -framework CoreText -framework Metal $(ANGLE_LDFLAGS) $(LIBWEBRTC_LDFLAGS); SECT_ORDER_FLAGS = ; ENTITLEMENTS_REQUIRED = $(ENTITLEMENTS_REQUIRED_USE_INTERNAL_SDK_$(USE_INTERNAL_SDK)) ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [281249] tags/Safari-612.1.27.0.26/
Title: [281249] tags/Safari-612.1.27.0.26/ Revision 281249 Author repst...@apple.com Date 2021-08-19 10:14:52 -0700 (Thu, 19 Aug 2021) Log Message Tag Safari-612.1.27.0.26. Added Paths tags/Safari-612.1.27.0.26/ Diff ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [281248] trunk/LayoutTests
Title: [281248] trunk/LayoutTests Revision 281248 Author ehutchi...@apple.com Date 2021-08-19 09:43:04 -0700 (Thu, 19 Aug 2021) Log Message [Mac, iOS] imported/w3c/web-platform-tests/html/rendering/replaced-elements/images/revoked-blob-print.html is an image-only failure. https://bugs.webkit.org/show_bug.cgi?id=229291. Unreviewed test gardening. * platform/ios/TestExpectations: * platform/mac-wk1/TestExpectations: * platform/mac/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/ios/TestExpectations trunk/LayoutTests/platform/mac/TestExpectations trunk/LayoutTests/platform/mac-wk1/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (281247 => 281248) --- trunk/LayoutTests/ChangeLog 2021-08-19 16:38:07 UTC (rev 281247) +++ trunk/LayoutTests/ChangeLog 2021-08-19 16:43:04 UTC (rev 281248) @@ -1,3 +1,14 @@ +2021-08-19 Eric Hutchison + +[Mac, iOS] imported/w3c/web-platform-tests/html/rendering/replaced-elements/images/revoked-blob-print.html is an image-only failure. +https://bugs.webkit.org/show_bug.cgi?id=229291. + +Unreviewed test gardening. + +* platform/ios/TestExpectations: +* platform/mac-wk1/TestExpectations: +* platform/mac/TestExpectations: + 2021-08-19 Kyle Piddington WebGL via Metal experimental feature does not correctly toggle metal backend Modified: trunk/LayoutTests/platform/ios/TestExpectations (281247 => 281248) --- trunk/LayoutTests/platform/ios/TestExpectations 2021-08-19 16:38:07 UTC (rev 281247) +++ trunk/LayoutTests/platform/ios/TestExpectations 2021-08-19 16:43:04 UTC (rev 281248) @@ -3473,4 +3473,6 @@ [ Release ] imported/w3c/web-platform-tests/webrtc/RTCPeerConnection-addIceCandidate-connectionSetup.html [ Pass Failure ] [ Release ] imported/w3c/web-platform-tests/webrtc/RTCDtlsTransport-state.html [ Pass Failure ] +webkit.org/b/229291 imported/w3c/web-platform-tests/html/rendering/replaced-elements/images/revoked-blob-print.html [ Pass ImageOnlyFailure ] + webkit.org/b/228200 editing/selection/ios/scrolling-to-focused-element-inside-iframe.html [ Failure ] \ No newline at end of file Modified: trunk/LayoutTests/platform/mac/TestExpectations (281247 => 281248) --- trunk/LayoutTests/platform/mac/TestExpectations 2021-08-19 16:38:07 UTC (rev 281247) +++ trunk/LayoutTests/platform/mac/TestExpectations 2021-08-19 16:43:04 UTC (rev 281248) @@ -2322,5 +2322,7 @@ webkit.org/b/229244 imported/w3c/web-platform-tests/IndexedDB/key-generators/reading-autoincrement-indexes-cursors.any.worker.html [ Pass Crash ] +webkit.org/b/229291 imported/w3c/web-platform-tests/html/rendering/replaced-elements/images/revoked-blob-print.html [ Pass ImageOnlyFailure ] + webkit.org/b/228396 fast/speechsynthesis/speech-synthesis-speak-empty-string.html [ Pass Failure ] Modified: trunk/LayoutTests/platform/mac-wk1/TestExpectations (281247 => 281248) --- trunk/LayoutTests/platform/mac-wk1/TestExpectations 2021-08-19 16:38:07 UTC (rev 281247) +++ trunk/LayoutTests/platform/mac-wk1/TestExpectations 2021-08-19 16:43:04 UTC (rev 281248) @@ -528,8 +528,6 @@ # This newly imported test times out on WK1 but passes on WK2. webkit.org/b/17 imported/w3c/web-platform-tests/notifications/event-onclose.html [ Skip ] -imported/w3c/web-platform-tests/html/rendering/replaced-elements/images/revoked-blob-print.html [ ImageOnlyFailure ] - imported/w3c/web-platform-tests/html/browsers/history/the-history-interface/history_go_no_argument.html [ Pass Failure ] imported/w3c/web-platform-tests/html/browsers/history/the-history-interface/history_go_to_uri.html [ Pass Failure ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [281247] trunk/Source
Title: [281247] trunk/Source
Revision 281247
Author simon.fra...@apple.com
Date 2021-08-19 09:38:07 -0700 (Thu, 19 Aug 2021)
Log Message
Rename EventHandler::sendScrollEvent() to scheduleScrollEvent() since the event is not sent synchronously
https://bugs.webkit.org/show_bug.cgi?id=229256
Reviewed by Geoffrey Garen.
Rename EventHandler::sendScrollEvent() and FrameView::sendScrollEvent()
to scheduleScrollEvent() since the event dispatch happens via the next rendering update.
Source/WebCore:
* page/EventHandler.cpp:
(WebCore::EventHandler::scheduleScrollEvent):
(WebCore::EventHandler::sendScrollEvent): Deleted.
* page/EventHandler.h:
* page/FrameView.cpp:
(WebCore::FrameView::FrameView):
(WebCore::FrameView::scrollPositionChanged):
(WebCore::FrameView::scheduleScrollEvent):
(WebCore::FrameView::sendScrollEvent): Deleted.
* page/FrameView.h:
Source/WebKitLegacy/mac:
* WebView/WebFrame.mm:
(-[WebFrame sendScrollEvent]):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/EventHandler.cpp
trunk/Source/WebCore/page/EventHandler.h
trunk/Source/WebCore/page/FrameView.cpp
trunk/Source/WebCore/page/FrameView.h
trunk/Source/WebKitLegacy/mac/ChangeLog
trunk/Source/WebKitLegacy/mac/WebView/WebFrame.mm
Diff
Modified: trunk/Source/WebCore/ChangeLog (281246 => 281247)
--- trunk/Source/WebCore/ChangeLog 2021-08-19 16:32:22 UTC (rev 281246)
+++ trunk/Source/WebCore/ChangeLog 2021-08-19 16:38:07 UTC (rev 281247)
@@ -1,3 +1,24 @@
+2021-08-19 Simon Fraser
+
+Rename EventHandler::sendScrollEvent() to scheduleScrollEvent() since the event is not sent synchronously
+https://bugs.webkit.org/show_bug.cgi?id=229256
+
+Reviewed by Geoffrey Garen.
+
+Rename EventHandler::sendScrollEvent() and FrameView::sendScrollEvent()
+to scheduleScrollEvent() since the event dispatch happens via the next rendering update.
+
+* page/EventHandler.cpp:
+(WebCore::EventHandler::scheduleScrollEvent):
+(WebCore::EventHandler::sendScrollEvent): Deleted.
+* page/EventHandler.h:
+* page/FrameView.cpp:
+(WebCore::FrameView::FrameView):
+(WebCore::FrameView::scrollPositionChanged):
+(WebCore::FrameView::scheduleScrollEvent):
+(WebCore::FrameView::sendScrollEvent): Deleted.
+* page/FrameView.h:
+
2021-08-19 Kyle Piddington
WebGL via Metal experimental feature does not correctly toggle metal backend
Modified: trunk/Source/WebCore/page/EventHandler.cpp (281246 => 281247)
--- trunk/Source/WebCore/page/EventHandler.cpp 2021-08-19 16:32:22 UTC (rev 281246)
+++ trunk/Source/WebCore/page/EventHandler.cpp 2021-08-19 16:38:07 UTC (rev 281247)
@@ -4362,7 +4362,7 @@
event.setDefaultHandled();
}
-void EventHandler::sendScrollEvent()
+void EventHandler::scheduleScrollEvent()
{
Ref protectedFrame(m_frame);
setFrameWasScrolledByUser();
Modified: trunk/Source/WebCore/page/EventHandler.h (281246 => 281247)
--- trunk/Source/WebCore/page/EventHandler.h 2021-08-19 16:32:22 UTC (rev 281246)
+++ trunk/Source/WebCore/page/EventHandler.h 2021-08-19 16:38:07 UTC (rev 281247)
@@ -280,7 +280,7 @@
void focusDocumentView();
-WEBCORE_EXPORT void sendScrollEvent();
+WEBCORE_EXPORT void scheduleScrollEvent();
#if PLATFORM(MAC)
WEBCORE_EXPORT void mouseDown(NSEvent *, NSEvent *correspondingPressureEvent);
Modified: trunk/Source/WebCore/page/FrameView.cpp (281246 => 281247)
--- trunk/Source/WebCore/page/FrameView.cpp 2021-08-19 16:32:22 UTC (rev 281246)
+++ trunk/Source/WebCore/page/FrameView.cpp 2021-08-19 16:38:07 UTC (rev 281247)
@@ -187,7 +187,7 @@
, m_layoutContext(*this)
, m_updateEmbeddedObjectsTimer(*this, ::updateEmbeddedObjectsTimerFired)
, m_updateWidgetPositionsTimer(*this, ::updateWidgetPositionsTimerFired)
-, m_delayedScrollEventTimer(*this, ::sendScrollEvent)
+, m_delayedScrollEventTimer(*this, ::scheduleScrollEvent)
, m_delayedScrollToFocusedElementTimer(*this, ::scrollToFocusedElementTimerFired)
, m_speculativeTilingEnableTimer(*this, ::speculativeTilingEnableTimerFired)
{
@@ -2504,7 +2504,7 @@
if (throttlingDelay == 0_s) {
m_delayedScrollEventTimer.stop();
-sendScrollEvent();
+scheduleScrollEvent();
} else if (!m_delayedScrollEventTimer.isActive())
m_delayedScrollEventTimer.startOneShot(throttlingDelay);
@@ -5110,9 +5110,9 @@
scrollingCoordinator->frameViewEventTrackingRegionsChanged(*this);
}
-void FrameView::sendScrollEvent()
+void FrameView::scheduleScrollEvent()
{
-frame().eventHandler().sendScrollEvent();
+frame().eventHandler().scheduleScrollEvent();
frame().eventHandler().dispatchFakeMouseMoveEventSoon();
}
Modified: trunk/Source/WebCore/page/FrameView.h (281246 => 281247)
--- trunk/Source/WebCore/page/FrameView.h 2021-08-19 16:32:22 UTC (rev 281246)
+++ trunk/Source/WebCore/page/FrameView.h 2021-08-19 16:38:07 UTC
[webkit-changes] [281246] trunk/Source/WebKit
Title: [281246] trunk/Source/WebKit
Revision 281246
Author simon.fra...@apple.com
Date 2021-08-19 09:32:22 -0700 (Thu, 19 Aug 2021)
Log Message
Fix the typo in horiontalRubberbandAmountInContentCoordinates
https://bugs.webkit.org/show_bug.cgi?id=229255
Reviewed by Tim Horton.
* UIProcess/API/ios/WKWebViewIOS.mm:
(-[WKWebView _contentBoundsExtendedForRubberbandingWithScale:]):
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/API/ios/WKWebViewIOS.mm
Diff
Modified: trunk/Source/WebKit/ChangeLog (281245 => 281246)
--- trunk/Source/WebKit/ChangeLog 2021-08-19 16:28:04 UTC (rev 281245)
+++ trunk/Source/WebKit/ChangeLog 2021-08-19 16:32:22 UTC (rev 281246)
@@ -1,5 +1,15 @@
2021-08-19 Simon Fraser
+Fix the typo in horiontalRubberbandAmountInContentCoordinates
+https://bugs.webkit.org/show_bug.cgi?id=229255
+
+Reviewed by Tim Horton.
+
+* UIProcess/API/ios/WKWebViewIOS.mm:
+(-[WKWebView _contentBoundsExtendedForRubberbandingWithScale:]):
+
+2021-08-19 Simon Fraser
+
Rename WebPageProxy::headerHeight() and related to make it clear they are for printing
https://bugs.webkit.org/show_bug.cgi?id=229242
Modified: trunk/Source/WebKit/UIProcess/API/ios/WKWebViewIOS.mm (281245 => 281246)
--- trunk/Source/WebKit/UIProcess/API/ios/WKWebViewIOS.mm 2021-08-19 16:28:04 UTC (rev 281245)
+++ trunk/Source/WebKit/UIProcess/API/ios/WKWebViewIOS.mm 2021-08-19 16:32:22 UTC (rev 281246)
@@ -2092,16 +2092,16 @@
CGPoint contentOffset = [_scrollView contentOffset];
CGPoint boundedOffset = contentOffsetBoundedInValidRange(_scrollView.get(), contentOffset);
-CGFloat horiontalRubberbandAmountInContentCoordinates = (contentOffset.x - boundedOffset.x) / scaleFactor;
+CGFloat horizontalRubberbandAmountInContentCoordinates = (contentOffset.x - boundedOffset.x) / scaleFactor;
CGFloat verticalRubberbandAmountInContentCoordinates = (contentOffset.y - boundedOffset.y) / scaleFactor;
CGRect extendedBounds = [_contentView bounds];
-if (horiontalRubberbandAmountInContentCoordinates < 0) {
-extendedBounds.origin.x += horiontalRubberbandAmountInContentCoordinates;
-extendedBounds.size.width -= horiontalRubberbandAmountInContentCoordinates;
-} else if (horiontalRubberbandAmountInContentCoordinates > 0)
-extendedBounds.size.width += horiontalRubberbandAmountInContentCoordinates;
+if (horizontalRubberbandAmountInContentCoordinates < 0) {
+extendedBounds.origin.x += horizontalRubberbandAmountInContentCoordinates;
+extendedBounds.size.width -= horizontalRubberbandAmountInContentCoordinates;
+} else if (horizontalRubberbandAmountInContentCoordinates > 0)
+extendedBounds.size.width += horizontalRubberbandAmountInContentCoordinates;
if (verticalRubberbandAmountInContentCoordinates < 0) {
extendedBounds.origin.y += verticalRubberbandAmountInContentCoordinates;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [281245] trunk
Title: [281245] trunk
Revision 281245
Author d...@apple.com
Date 2021-08-19 09:28:04 -0700 (Thu, 19 Aug 2021)
Log Message
WebGL via Metal experimental feature does not correctly toggle metal backend
https://bugs.webkit.org/show_bug.cgi?id=229267
Source/WebCore:
Patch by Kyle Piddington on 2021-08-19
Reviewed by Dean Jackson.
GraphicsContextGLAttributes defines 'useMetal' as 'true' by default.
Since this branch was only checking if Metal was enabled via the
setting, rather than checking the status of the flag, the metal backend
was never disabled, even when requested.
Tests: webgl/webgl-metal-disabled.html
webgl/webgl-metal-enabled.html
* WebCore.xcodeproj/project.pbxproj:
* html/canvas/WebGLRenderingContextBase.cpp:
(WebCore::WebGLRenderingContextBase::create):
* testing/Internals.cpp:
(WebCore::Internals::requestedMetal):
* testing/Internals.h:
* testing/Internals.idl:
* testing/Internals.mm:
(WebCore::Internals::platformSupportsMetal):
LayoutTests:
Add tests to verify WebGL feature flag works as intended.
Patch by Kyle Piddington on 2021-08-19
Reviewed by Dean Jackson.
* webgl/webgl-metal-disabled-expected.txt: Added.
* webgl/webgl-metal-disabled.html: Added.
* webgl/webgl-metal-enabled-expected.txt: Added.
* webgl/webgl-metal-enabled.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp
trunk/Source/WebCore/testing/Internals.cpp
trunk/Source/WebCore/testing/Internals.h
trunk/Source/WebCore/testing/Internals.idl
trunk/Source/WebCore/testing/Internals.mm
Added Paths
trunk/LayoutTests/webgl/webgl-metal-disabled-expected.txt
trunk/LayoutTests/webgl/webgl-metal-disabled.html
trunk/LayoutTests/webgl/webgl-metal-enabled-expected.txt
trunk/LayoutTests/webgl/webgl-metal-enabled.html
Diff
Modified: trunk/LayoutTests/ChangeLog (281244 => 281245)
--- trunk/LayoutTests/ChangeLog 2021-08-19 16:26:00 UTC (rev 281244)
+++ trunk/LayoutTests/ChangeLog 2021-08-19 16:28:04 UTC (rev 281245)
@@ -1,3 +1,18 @@
+2021-08-19 Kyle Piddington
+
+WebGL via Metal experimental feature does not correctly toggle metal backend
+https://bugs.webkit.org/show_bug.cgi?id=229267
+
+
+Add tests to verify WebGL feature flag works as intended.
+
+Reviewed by Dean Jackson.
+
+* webgl/webgl-metal-disabled-expected.txt: Added.
+* webgl/webgl-metal-disabled.html: Added.
+* webgl/webgl-metal-enabled-expected.txt: Added.
+* webgl/webgl-metal-enabled.html: Added.
+
2021-08-19 Antti Koivisto
TextDecorationPainter should not depend on LegacyInlineTextBox
Added: trunk/LayoutTests/webgl/webgl-metal-disabled-expected.txt (0 => 281245)
--- trunk/LayoutTests/webgl/webgl-metal-disabled-expected.txt (rev 0)
+++ trunk/LayoutTests/webgl/webgl-metal-disabled-expected.txt 2021-08-19 16:28:04 UTC (rev 281245)
@@ -0,0 +1,2 @@
+Metal for WebGL1 disabled when requested: OK
+
Property changes on: trunk/LayoutTests/webgl/webgl-metal-disabled-expected.txt
___
Added: svn:eol-style
+native
\ No newline at end of property
Added: svn:keywords
+Date Revision
\ No newline at end of property
Added: svn:mime-type
+text/plain
\ No newline at end of property
Added: trunk/LayoutTests/webgl/webgl-metal-disabled.html (0 => 281245)
--- trunk/LayoutTests/webgl/webgl-metal-disabled.html (rev 0)
+++ trunk/LayoutTests/webgl/webgl-metal-disabled.html 2021-08-19 16:28:04 UTC (rev 281245)
@@ -0,0 +1,31 @@
+
+
+
+if (window.testRunner)
+window.testRunner.dumpAsText();
+
+function run()
+{
+const out = document.querySelector("p");
+let result = "";
+
+if (!window.internals) {
+out.innerText = "Test requires internals.";
+return;
+}
+
+const canvasA = document.getElementById("a");
+const glA = canvasA.getContext("webgl");
+const requested = internals.requestedMetal(glA);
+const supported = false;
+let resultStr = "OK";
+if (requested != supported)
+resultStr = "FAIL";
+
+result += `Metal for WebGL1 disabled when requested: ${resultStr}
`;
+out.innerHTML = result;
+}
+
+window.addEventListener("load", run, false);
+
+
Property changes on: trunk/LayoutTests/webgl/webgl-metal-disabled.html
___
Added: svn:eol-style
+native
\ No newline at end of property
Added: svn:keywords
+Date Revision
\ No newline at end of property
Added: svn:mime-type
+text/html
\ No newline at end of property
Added: trunk/LayoutTests/webgl/webgl-metal-enabled-expected.txt (0 => 281245)
--- trunk/LayoutTests/webgl/webgl-metal-enabled-expected.txt (rev 0)
+++ trunk/LayoutTests/webgl/webgl-metal-enabled-expected.txt 2021-08-19 16:28:04 UTC (rev 281245)
@@ -0,0 +1,2 @@
+Metal for WebGL1 enabled matches platform
[webkit-changes] [281244] trunk/Source/WebCore
Title: [281244] trunk/Source/WebCore
Revision 281244
Author simon.fra...@apple.com
Date 2021-08-19 09:26:00 -0700 (Thu, 19 Aug 2021)
Log Message
Avoid DOMRect overhead in VTTRegion
https://bugs.webkit.org/show_bug.cgi?id=229249
Reviewed by Eric Carlson.
Use Element::boundingClientRect() instead of Element::getBoundingClientRect() to
avoid DOMRect overhead. No behavior change.
* html/track/VTTRegion.cpp:
(WebCore::VTTRegion::displayLastTextTrackCueBox):
(WebCore::VTTRegion::willRemoveTextTrackCueBox):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/track/VTTRegion.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (281243 => 281244)
--- trunk/Source/WebCore/ChangeLog 2021-08-19 16:23:36 UTC (rev 281243)
+++ trunk/Source/WebCore/ChangeLog 2021-08-19 16:26:00 UTC (rev 281244)
@@ -1,3 +1,17 @@
+2021-08-19 Simon Fraser
+
+Avoid DOMRect overhead in VTTRegion
+https://bugs.webkit.org/show_bug.cgi?id=229249
+
+Reviewed by Eric Carlson.
+
+Use Element::boundingClientRect() instead of Element::getBoundingClientRect() to
+avoid DOMRect overhead. No behavior change.
+
+* html/track/VTTRegion.cpp:
+(WebCore::VTTRegion::displayLastTextTrackCueBox):
+(WebCore::VTTRegion::willRemoveTextTrackCueBox):
+
2021-08-19 Antti Koivisto
TextDecorationPainter should not depend on LegacyInlineTextBox
Modified: trunk/Source/WebCore/html/track/VTTRegion.cpp (281243 => 281244)
--- trunk/Source/WebCore/html/track/VTTRegion.cpp 2021-08-19 16:23:36 UTC (rev 281243)
+++ trunk/Source/WebCore/html/track/VTTRegion.cpp 2021-08-19 16:26:00 UTC (rev 281244)
@@ -304,13 +304,13 @@
if (isScrollingRegion())
m_cueContainer->classList().add(textTrackCueContainerScrollingClass());
-float regionBottom = m_regionDisplayTree->getBoundingClientRect()->bottom();
+float regionBottom = m_regionDisplayTree->boundingClientRect().maxY();
// Find first cue that is not entirely displayed and scroll it upwards.
for (auto& child : childrenOfType(*m_cueContainer)) {
-auto rect = child.getBoundingClientRect();
-float childTop = rect->top();
-float childBottom = rect->bottom();
+auto rect = child.boundingClientRect();
+float childTop = rect.y();
+float childBottom = rect.maxY();
if (regionBottom >= childBottom)
continue;
@@ -330,7 +330,7 @@
LOG(Media, "VTTRegion::willRemoveTextTrackCueBox");
ASSERT(m_cueContainer->contains(box));
-double boxHeight = box->getBoundingClientRect()->bottom() - box->getBoundingClientRect()->top();
+double boxHeight = box->boundingClientRect().height();
m_cueContainer->classList().remove(textTrackCueContainerScrollingClass());
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [281243] trunk/Source/WebKit
Title: [281243] trunk/Source/WebKit
Revision 281243
Author simon.fra...@apple.com
Date 2021-08-19 09:23:36 -0700 (Thu, 19 Aug 2021)
Log Message
Rename WebPageProxy::headerHeight() and related to make it clear they are for printing
https://bugs.webkit.org/show_bug.cgi?id=229242
Reviewed by Tim Horton.
Disambiguate WebPageProxy::headerHeight(), used for printing, from FrameView::headerHeight()
which is not.
* UIProcess/Cocoa/UIDelegate.h:
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::headerHeightForPrinting):
(WebKit::WebPageProxy::footerHeightForPrinting):
(WebKit::WebPageProxy::drawHeaderForPrinting):
(WebKit::WebPageProxy::drawFooterForPrinting):
(WebKit::WebPageProxy::headerHeight): Deleted.
(WebKit::WebPageProxy::footerHeight): Deleted.
(WebKit::WebPageProxy::drawHeader): Deleted.
(WebKit::WebPageProxy::drawFooter): Deleted.
* UIProcess/WebPageProxy.h:
* UIProcess/mac/WKPrintingView.mm:
(-[WKPrintingView _adjustPrintingMarginsForHeaderAndFooter]):
(-[WKPrintingView drawPageBorderWithSize:]):
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/Cocoa/UIDelegate.h
trunk/Source/WebKit/UIProcess/WebPageProxy.cpp
trunk/Source/WebKit/UIProcess/WebPageProxy.h
trunk/Source/WebKit/UIProcess/mac/WKPrintingView.mm
Diff
Modified: trunk/Source/WebKit/ChangeLog (281242 => 281243)
--- trunk/Source/WebKit/ChangeLog 2021-08-19 16:10:36 UTC (rev 281242)
+++ trunk/Source/WebKit/ChangeLog 2021-08-19 16:23:36 UTC (rev 281243)
@@ -1,5 +1,30 @@
2021-08-19 Simon Fraser
+Rename WebPageProxy::headerHeight() and related to make it clear they are for printing
+https://bugs.webkit.org/show_bug.cgi?id=229242
+
+Reviewed by Tim Horton.
+
+Disambiguate WebPageProxy::headerHeight(), used for printing, from FrameView::headerHeight()
+which is not.
+
+* UIProcess/Cocoa/UIDelegate.h:
+* UIProcess/WebPageProxy.cpp:
+(WebKit::WebPageProxy::headerHeightForPrinting):
+(WebKit::WebPageProxy::footerHeightForPrinting):
+(WebKit::WebPageProxy::drawHeaderForPrinting):
+(WebKit::WebPageProxy::drawFooterForPrinting):
+(WebKit::WebPageProxy::headerHeight): Deleted.
+(WebKit::WebPageProxy::footerHeight): Deleted.
+(WebKit::WebPageProxy::drawHeader): Deleted.
+(WebKit::WebPageProxy::drawFooter): Deleted.
+* UIProcess/WebPageProxy.h:
+* UIProcess/mac/WKPrintingView.mm:
+(-[WKPrintingView _adjustPrintingMarginsForHeaderAndFooter]):
+(-[WKPrintingView drawPageBorderWithSize:]):
+
+2021-08-19 Simon Fraser
+
Use a Ref<> argument to keep WebPage alive in TiledCoreAnimationDrawingArea::dispatchAfterEnsuringUpdatedScrollPosition()
https://bugs.webkit.org/show_bug.cgi?id=229239
Modified: trunk/Source/WebKit/UIProcess/Cocoa/UIDelegate.h (281242 => 281243)
--- trunk/Source/WebKit/UIProcess/Cocoa/UIDelegate.h 2021-08-19 16:10:36 UTC (rev 281242)
+++ trunk/Source/WebKit/UIProcess/Cocoa/UIDelegate.h 2021-08-19 16:23:36 UTC (rev 281243)
@@ -115,10 +115,13 @@
void setWindowFrame(WebPageProxy&, const WebCore::FloatRect&) final;
void windowFrame(WebPageProxy&, Function&&) final;
void didNotHandleWheelEvent(WebPageProxy*, const NativeWebWheelEvent&) final;
+
+// Printing.
float headerHeight(WebPageProxy&, WebFrameProxy&) final;
float footerHeight(WebPageProxy&, WebFrameProxy&) final;
void drawHeader(WebPageProxy&, WebFrameProxy&, WebCore::FloatRect&&) final;
void drawFooter(WebPageProxy&, WebFrameProxy&, WebCore::FloatRect&&) final;
+
void decidePolicyForNotificationPermissionRequest(WebPageProxy&, API::SecurityOrigin&, CompletionHandler&&) final;
void unavailablePluginButtonClicked(WebPageProxy&, WKPluginUnavailabilityReason, API::Dictionary&) final;
void mouseDidMoveOverElement(WebPageProxy&, const WebHitTestResultData&, OptionSet, API::Object*);
Modified: trunk/Source/WebKit/UIProcess/WebPageProxy.cpp (281242 => 281243)
--- trunk/Source/WebKit/UIProcess/WebPageProxy.cpp 2021-08-19 16:10:36 UTC (rev 281242)
+++ trunk/Source/WebKit/UIProcess/WebPageProxy.cpp 2021-08-19 16:23:36 UTC (rev 281243)
@@ -8662,7 +8662,7 @@
m_process->processPool().supplement()->didDestroyNotification(this, notificationID);
}
-float WebPageProxy::headerHeight(WebFrameProxy& frame)
+float WebPageProxy::headerHeightForPrinting(WebFrameProxy& frame)
{
if (frame.isDisplayingPDFDocument())
return 0;
@@ -8669,7 +8669,7 @@
return m_uiClient->headerHeight(*this, frame);
}
-float WebPageProxy::footerHeight(WebFrameProxy& frame)
+float WebPageProxy::footerHeightForPrinting(WebFrameProxy& frame)
{
if (frame.isDisplayingPDFDocument())
return 0;
@@ -8676,7 +8676,7 @@
return m_uiClient->footerHeight(*this, frame);
}
-void WebPageProxy::drawHeader(WebFrameProxy& frame, FloatRect&& rect)
+void
[webkit-changes] [281242] trunk/Source/WebKit
Title: [281242] trunk/Source/WebKit
Revision 281242
Author simon.fra...@apple.com
Date 2021-08-19 09:10:36 -0700 (Thu, 19 Aug 2021)
Log Message
Use a Ref<> argument to keep WebPage alive in TiledCoreAnimationDrawingArea::dispatchAfterEnsuringUpdatedScrollPosition()
https://bugs.webkit.org/show_bug.cgi?id=229239
Reviewed by Tim Horton.
Replace a manual ref()/deref() with a makeRef() argument to the function.
* WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
(WebKit::TiledCoreAnimationDrawingArea::dispatchAfterEnsuringUpdatedScrollPosition):
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm
Diff
Modified: trunk/Source/WebKit/ChangeLog (281241 => 281242)
--- trunk/Source/WebKit/ChangeLog 2021-08-19 16:08:54 UTC (rev 281241)
+++ trunk/Source/WebKit/ChangeLog 2021-08-19 16:10:36 UTC (rev 281242)
@@ -1,3 +1,15 @@
+2021-08-19 Simon Fraser
+
+Use a Ref<> argument to keep WebPage alive in TiledCoreAnimationDrawingArea::dispatchAfterEnsuringUpdatedScrollPosition()
+https://bugs.webkit.org/show_bug.cgi?id=229239
+
+Reviewed by Tim Horton.
+
+Replace a manual ref()/deref() with a makeRef() argument to the function.
+
+* WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
+(WebKit::TiledCoreAnimationDrawingArea::dispatchAfterEnsuringUpdatedScrollPosition):
+
2021-08-19 Kate Cheney
Unable to load downloaded HTML files in Safari
Modified: trunk/Source/WebKit/WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm (281241 => 281242)
--- trunk/Source/WebKit/WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm 2021-08-19 16:08:54 UTC (rev 281241)
+++ trunk/Source/WebKit/WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm 2021-08-19 16:10:36 UTC (rev 281242)
@@ -373,20 +373,14 @@
return;
}
-m_webPage.ref();
m_webPage.corePage()->scrollingCoordinator()->commitTreeStateIfNeeded();
if (!m_layerTreeStateIsFrozen)
invalidateRenderingUpdateRunLoopObserver();
-// It is possible for the drawing area to be destroyed before the bound block
-// is invoked, so grab a reference to the web page here so we can access the drawing area through it.
-// (The web page is already kept alive by dispatchAfterEnsuringUpdatedScrollPosition).
-WebPage* webPage = _webPage;
-
-ScrollingThread::dispatchBarrier([this, webPage, function = WTFMove(function)] {
-DrawingArea* drawingArea = webPage->drawingArea();
-if (!drawingArea)
+ScrollingThread::dispatchBarrier([this, retainedPage = makeRef(m_webPage), function = WTFMove(function)] {
+// It is possible for the drawing area to be destroyed before the bound block is invoked.
+if (!retainedPage->drawingArea())
return;
function();
@@ -393,8 +387,6 @@
if (!m_layerTreeStateIsFrozen)
scheduleRenderingUpdateRunLoopObserver();
-
-webPage->deref();
});
#else
function();
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [281241] trunk
Title: [281241] trunk Revision 281241 Author an...@apple.com Date 2021-08-19 09:08:54 -0700 (Thu, 19 Aug 2021) Log Message TextDecorationPainter should not depend on LegacyInlineTextBox https://bugs.webkit.org/show_bug.cgi?id=228814 Reviewed by Alan Bujtas. Source/WebCore: Use the inline iterator instead. * layout/integration/LayoutIntegrationLineIterator.h: (WebCore::LayoutIntegration::LineIterator::isFirst const): (WebCore::LayoutIntegration::PathLine::baselineType const): * layout/integration/LayoutIntegrationLineIteratorLegacyPath.h: (WebCore::LayoutIntegration::LineIteratorLegacyPath::baselineType const): * layout/integration/LayoutIntegrationLineIteratorModernPath.h: (WebCore::LayoutIntegration::LineIteratorModernPath::baselineType const): * layout/integration/LayoutIntegrationRunIterator.cpp: (WebCore::LayoutIntegration::RunIterator::line const): (WebCore::LayoutIntegration::PathRun::line const): (WebCore::LayoutIntegration::PathRun::style const): (WebCore::LayoutIntegration::textRunFor): * layout/integration/LayoutIntegrationRunIterator.h: (WebCore::LayoutIntegration::PathTextRun::renderer const): * layout/integration/LayoutIntegrationRunIteratorModernPath.h: * rendering/LegacyInlineFlowBox.cpp: (WebCore::LegacyInlineFlowBox::maxLogicalBottomForTextDecorationLine const): Deleted. (WebCore::LegacyInlineFlowBox::minLogicalTopForTextDecorationLine const): Deleted. * rendering/LegacyInlineFlowBox.h: * rendering/LegacyInlineTextBox.cpp: (WebCore::LegacyInlineTextBox::paintMarkedTextDecoration): * rendering/LegacyLineLayout.cpp: (WebCore::setLogicalWidthForTextRun): * rendering/RenderElement.cpp: (WebCore::RenderElement::enclosingRendererWithTextDecoration const): Deleted. * rendering/RenderElement.h: * rendering/TextDecorationPainter.cpp: (WebCore::TextDecorationPainter::paintTextDecoration): * rendering/TextDecorationPainter.h: (WebCore::TextDecorationPainter::setTextRunIterator): (WebCore::TextDecorationPainter::setInlineTextBox): Deleted. * rendering/style/RenderStyle.cpp: (WebCore::RenderStyle::changeAffectsVisualOverflow const): * style/InlineTextBoxStyle.cpp: (WebCore::isAncestorAndWithinBlock): (WebCore::minLogicalTopForTextDecorationLine): (WebCore::maxLogicalBottomForTextDecorationLine): Moved from LegacyInlineFlowBox. (WebCore::enclosingRendererWithTextDecoration): Moved from RenderElement. (WebCore::computeUnderlineOffset): (WebCore::visualOverflowForDecorations): * style/InlineTextBoxStyle.h: LayoutTests: Fix the expected results to not depend on inline culling (which this patch ignores). * fast/text/text-underline-first-line-decoration-expected.html: * fast/text/text-underline-vertical-first-line-decoration-expected.html: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/fast/text/text-underline-first-line-decoration-expected.html trunk/LayoutTests/fast/text/text-underline-vertical-first-line-decoration-expected.html trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/layout/integration/LayoutIntegrationLineIterator.h trunk/Source/WebCore/layout/integration/LayoutIntegrationLineIteratorLegacyPath.h trunk/Source/WebCore/layout/integration/LayoutIntegrationLineIteratorModernPath.h trunk/Source/WebCore/layout/integration/LayoutIntegrationRunIterator.cpp trunk/Source/WebCore/layout/integration/LayoutIntegrationRunIterator.h trunk/Source/WebCore/layout/integration/LayoutIntegrationRunIteratorModernPath.h trunk/Source/WebCore/rendering/LegacyInlineFlowBox.cpp trunk/Source/WebCore/rendering/LegacyInlineFlowBox.h trunk/Source/WebCore/rendering/LegacyInlineTextBox.cpp trunk/Source/WebCore/rendering/LegacyLineLayout.cpp trunk/Source/WebCore/rendering/RenderElement.cpp trunk/Source/WebCore/rendering/RenderElement.h trunk/Source/WebCore/rendering/TextDecorationPainter.cpp trunk/Source/WebCore/rendering/TextDecorationPainter.h trunk/Source/WebCore/rendering/style/RenderStyle.cpp trunk/Source/WebCore/style/InlineTextBoxStyle.cpp trunk/Source/WebCore/style/InlineTextBoxStyle.h Diff Modified: trunk/LayoutTests/ChangeLog (281240 => 281241) --- trunk/LayoutTests/ChangeLog 2021-08-19 16:05:09 UTC (rev 281240) +++ trunk/LayoutTests/ChangeLog 2021-08-19 16:08:54 UTC (rev 281241) @@ -1,3 +1,15 @@ +2021-08-19 Antti Koivisto + +TextDecorationPainter should not depend on LegacyInlineTextBox +https://bugs.webkit.org/show_bug.cgi?id=228814 + +Reviewed by Alan Bujtas. + +Fix the expected results to not depend on inline culling (which this patch ignores). + +* fast/text/text-underline-first-line-decoration-expected.html: +* fast/text/text-underline-vertical-first-line-decoration-expected.html: + 2021-08-19 Ayumi Kojima [ Win EWS ] fast/forms/* tests are flaky crashing FAULTING_IP: WebKit!WebCore::FontCache::lastResortFallbackFont+ec [C:\cygwin\home\buildbot\worker\Windows-EWS\build\Source\WebCore\platform\graphics\win\FontCacheWin.cpp @ 424]. Modified:
[webkit-changes] [281240] trunk/Source/WebCore
Title: [281240] trunk/Source/WebCore
Revision 281240
Author an...@apple.com
Date 2021-08-19 09:05:09 -0700 (Thu, 19 Aug 2021)
Log Message
Move MarkedTextStyle into StyledMarkedText scope
https://bugs.webkit.org/show_bug.cgi?id=228956
Reviewed by Alan Bujtas.
As StyledMarkedText::Style.
Also other cleanups and a file rename to match the type.
* Sources.txt:
* WebCore.xcodeproj/project.pbxproj:
* rendering/LegacyInlineTextBox.cpp:
(WebCore::LegacyInlineTextBox::paint):
* rendering/StyledMarkedText.cpp: Renamed from Source/WebCore/rendering/MarkedTextStyle.cpp.
(WebCore::resolveStyleForMarkedText):
(WebCore::computeStyleForUnmarkedMarkedText):
(WebCore::StyledMarkedText::subdivideAndResolve):
(WebCore::coalesceAdjacent):
(WebCore::StyledMarkedText::coalesceAdjacentWithEqualBackground):
(WebCore::StyledMarkedText::coalesceAdjacentWithEqualForeground):
(WebCore::StyledMarkedText::coalesceAdjacentWithEqualDecorations):
* rendering/StyledMarkedText.h: Renamed from Source/WebCore/rendering/MarkedTextStyle.h.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Sources.txt
trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj
trunk/Source/WebCore/rendering/LegacyInlineTextBox.cpp
Added Paths
trunk/Source/WebCore/rendering/StyledMarkedText.cpp
trunk/Source/WebCore/rendering/StyledMarkedText.h
Removed Paths
trunk/Source/WebCore/rendering/MarkedTextStyle.cpp
trunk/Source/WebCore/rendering/MarkedTextStyle.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (281239 => 281240)
--- trunk/Source/WebCore/ChangeLog 2021-08-19 15:51:31 UTC (rev 281239)
+++ trunk/Source/WebCore/ChangeLog 2021-08-19 16:05:09 UTC (rev 281240)
@@ -1,3 +1,27 @@
+2021-08-19 Antti Koivisto
+
+Move MarkedTextStyle into StyledMarkedText scope
+https://bugs.webkit.org/show_bug.cgi?id=228956
+
+Reviewed by Alan Bujtas.
+
+As StyledMarkedText::Style.
+Also other cleanups and a file rename to match the type.
+
+* Sources.txt:
+* WebCore.xcodeproj/project.pbxproj:
+* rendering/LegacyInlineTextBox.cpp:
+(WebCore::LegacyInlineTextBox::paint):
+* rendering/StyledMarkedText.cpp: Renamed from Source/WebCore/rendering/MarkedTextStyle.cpp.
+(WebCore::resolveStyleForMarkedText):
+(WebCore::computeStyleForUnmarkedMarkedText):
+(WebCore::StyledMarkedText::subdivideAndResolve):
+(WebCore::coalesceAdjacent):
+(WebCore::StyledMarkedText::coalesceAdjacentWithEqualBackground):
+(WebCore::StyledMarkedText::coalesceAdjacentWithEqualForeground):
+(WebCore::StyledMarkedText::coalesceAdjacentWithEqualDecorations):
+* rendering/StyledMarkedText.h: Renamed from Source/WebCore/rendering/MarkedTextStyle.h.
+
2021-08-19 Simon Fraser
Use an OptionSet in place of MapCoordinatesFlags
Modified: trunk/Source/WebCore/Sources.txt (281239 => 281240)
--- trunk/Source/WebCore/Sources.txt 2021-08-19 15:51:31 UTC (rev 281239)
+++ trunk/Source/WebCore/Sources.txt 2021-08-19 16:05:09 UTC (rev 281240)
@@ -2176,7 +2176,6 @@
rendering/LegacyRootInlineBox.cpp
rendering/LegacyInlineTextBox.cpp
rendering/MarkedText.cpp
-rendering/MarkedTextStyle.cpp
rendering/OrderIterator.cpp
rendering/PointerEventsHitRules.cpp
rendering/RenderAttachment.cpp
@@ -2264,6 +2263,7 @@
rendering/RenderWidget.cpp
rendering/ScrollAlignment.cpp
rendering/SelectionRangeData.cpp
+rendering/StyledMarkedText.cpp
rendering/TableLayout.cpp
rendering/TextDecorationPainter.cpp
rendering/TextPaintStyle.cpp
Modified: trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj (281239 => 281240)
--- trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj 2021-08-19 15:51:31 UTC (rev 281239)
+++ trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj 2021-08-19 16:05:09 UTC (rev 281240)
@@ -5200,7 +5200,7 @@
E43A023B17EB370A004CDD25 /* RenderElement.h in Headers */ = {isa = PBXBuildFile; fileRef = E43A023A17EB370A004CDD25 /* RenderElement.h */; settings = {ATTRIBUTES = (Private, ); }; };
E43AF8E71AC5B7EC00CA717E /* CacheValidation.h in Headers */ = {isa = PBXBuildFile; fileRef = E43AF8E51AC5B7DD00CA717E /* CacheValidation.h */; settings = {ATTRIBUTES = (Private, ); }; };
E440AA961C68420800A265CC /* ElementAndTextDescendantIterator.h in Headers */ = {isa = PBXBuildFile; fileRef = E440AA951C68420800A265CC /* ElementAndTextDescendantIterator.h */; };
- E440FD5325A4AFDF00F7C849 /* MarkedTextStyle.h in Headers */ = {isa = PBXBuildFile; fileRef = E440FD5125A4AFDF00F7C849 /* MarkedTextStyle.h */; };
+ E440FD5325A4AFDF00F7C849 /* StyledMarkedText.h in Headers */ = {isa = PBXBuildFile; fileRef = E440FD5125A4AFDF00F7C849 /* StyledMarkedText.h */; };
E44613A20CD6331000FADA75 /* HTMLAudioElement.h in Headers */ = {isa = PBXBuildFile; fileRef = E44613900CD6331000FADA75 /* HTMLAudioElement.h */; };
E44613A50CD6331000FADA75 /* HTMLMediaElement.h in Headers */ = {isa = PBXBuildFile; fileRef = E44613930CD6331000FADA75 /*
[webkit-changes] [281239] trunk/Source/WebCore
Title: [281239] trunk/Source/WebCore Revision 281239 Author simon.fra...@apple.com Date 2021-08-19 08:51:31 -0700 (Thu, 19 Aug 2021) Log Message Use an OptionSet in place of MapCoordinatesFlags https://bugs.webkit.org/show_bug.cgi?id=229170 Reviewed by Antti Koivisto. Replace MapCoordinatesFlags with OptionSet. No behavior change. * html/HTMLAnchorElement.cpp: (WebCore::appendServerMapMousePosition): * rendering/RenderBox.cpp: (WebCore::RenderBox::mapLocalToContainer const): (WebCore::RenderBox::mapAbsoluteToLocalPoint const): * rendering/RenderBox.h: * rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::mapAbsoluteToLocalPoint const): * rendering/RenderBoxModelObject.h: * rendering/RenderFragmentedFlow.cpp: (WebCore::RenderFragmentedFlow::mapLocalToContainer const): * rendering/RenderFragmentedFlow.h: * rendering/RenderGeometryMap.cpp: (WebCore::RenderGeometryMap::RenderGeometryMap): (WebCore::RenderGeometryMap::pushMappingsToAncestor): * rendering/RenderGeometryMap.h: (WebCore::RenderGeometryMap::mapCoordinatesFlags const): * rendering/RenderInline.cpp: (WebCore::RenderInline::mapLocalToContainer const): * rendering/RenderInline.h: * rendering/RenderMultiColumnFlow.cpp: (WebCore::RenderMultiColumnFlow::mapAbsoluteToLocalPoint const): * rendering/RenderMultiColumnFlow.h: * rendering/RenderObject.cpp: (WebCore::RenderObject::absoluteBoundingBoxRect const): (WebCore::RenderObject::localToAbsolute const): (WebCore::RenderObject::absoluteToLocal const): (WebCore::RenderObject::absoluteToLocalQuad const): (WebCore::RenderObject::mapLocalToContainer const): (WebCore::RenderObject::mapAbsoluteToLocalPoint const): (WebCore::RenderObject::localToContainerQuad const): (WebCore::RenderObject::localToContainerPoint const): * rendering/RenderObject.h: (WebCore::RenderObject::localToAbsolute): (WebCore::RenderObject::absoluteToLocal): (WebCore::RenderObject::localToAbsoluteQuad const): * rendering/RenderObjectEnums.h: * rendering/RenderTheme.cpp: (WebCore::RenderTheme::volumeSliderOffsetFromMuteButton const): * rendering/RenderView.cpp: (WebCore::RenderView::mapLocalToContainer const): (WebCore::RenderView::mapAbsoluteToLocalPoint const): * rendering/RenderView.h: * rendering/svg/RenderSVGForeignObject.cpp: (WebCore::RenderSVGForeignObject::mapLocalToContainer const): * rendering/svg/RenderSVGForeignObject.h: * rendering/svg/RenderSVGInline.cpp: (WebCore::RenderSVGInline::mapLocalToContainer const): * rendering/svg/RenderSVGInline.h: * rendering/svg/RenderSVGModelObject.cpp: (WebCore::RenderSVGModelObject::mapLocalToContainer const): * rendering/svg/RenderSVGModelObject.h: * rendering/svg/RenderSVGRoot.cpp: (WebCore::RenderSVGRoot::mapLocalToContainer const): * rendering/svg/RenderSVGRoot.h: * rendering/svg/RenderSVGText.cpp: (WebCore::RenderSVGText::mapLocalToContainer const): * rendering/svg/RenderSVGText.h: * rendering/svg/SVGRenderSupport.cpp: (WebCore::SVGRenderSupport::mapLocalToContainer): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/html/HTMLAnchorElement.cpp trunk/Source/WebCore/rendering/RenderBox.cpp trunk/Source/WebCore/rendering/RenderBox.h trunk/Source/WebCore/rendering/RenderBoxModelObject.cpp trunk/Source/WebCore/rendering/RenderBoxModelObject.h trunk/Source/WebCore/rendering/RenderFragmentedFlow.cpp trunk/Source/WebCore/rendering/RenderFragmentedFlow.h trunk/Source/WebCore/rendering/RenderGeometryMap.cpp trunk/Source/WebCore/rendering/RenderGeometryMap.h trunk/Source/WebCore/rendering/RenderInline.cpp trunk/Source/WebCore/rendering/RenderInline.h trunk/Source/WebCore/rendering/RenderMultiColumnFlow.cpp trunk/Source/WebCore/rendering/RenderMultiColumnFlow.h trunk/Source/WebCore/rendering/RenderObject.cpp trunk/Source/WebCore/rendering/RenderObject.h trunk/Source/WebCore/rendering/RenderObjectEnums.h trunk/Source/WebCore/rendering/RenderTheme.cpp trunk/Source/WebCore/rendering/RenderView.cpp trunk/Source/WebCore/rendering/RenderView.h trunk/Source/WebCore/rendering/svg/RenderSVGForeignObject.cpp trunk/Source/WebCore/rendering/svg/RenderSVGForeignObject.h trunk/Source/WebCore/rendering/svg/RenderSVGInline.cpp trunk/Source/WebCore/rendering/svg/RenderSVGInline.h trunk/Source/WebCore/rendering/svg/RenderSVGModelObject.cpp trunk/Source/WebCore/rendering/svg/RenderSVGModelObject.h trunk/Source/WebCore/rendering/svg/RenderSVGRoot.cpp trunk/Source/WebCore/rendering/svg/RenderSVGRoot.h trunk/Source/WebCore/rendering/svg/RenderSVGText.cpp trunk/Source/WebCore/rendering/svg/RenderSVGText.h trunk/Source/WebCore/rendering/svg/SVGRenderSupport.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (281238 => 281239) --- trunk/Source/WebCore/ChangeLog 2021-08-19 15:47:35 UTC (rev 281238) +++ trunk/Source/WebCore/ChangeLog 2021-08-19 15:51:31 UTC (rev 281239) @@ -1,5 +1,76 @@ 2021-08-19 Simon Fraser +Use an OptionSet in place of MapCoordinatesFlags +https://bugs.webkit.org/show_bug.cgi?id=229170 + +Reviewed by Antti Koivisto. + +
[webkit-changes] [281238] trunk/Source
Title: [281238] trunk/Source Revision 281238 Author simon.fra...@apple.com Date 2021-08-19 08:47:35 -0700 (Thu, 19 Aug 2021) Log Message Remove duplicate LayerTreeAsText enums and use an OptionSet<> https://bugs.webkit.org/show_bug.cgi?id=229226 Reviewed by Antti Koivisto. GraphicsLayerClient had enum LayerTreeAsTextBehaviorFlags and Frame had an anonymous enum and typedef unsigned LayerTreeFlags. Clean up by adding LayerTreeAsTextOptions.h and using OptionSet everywhere. * Headers.cmake: * WebCore.xcodeproj/project.pbxproj: * page/Frame.h: * page/PageOverlayController.cpp: (WebCore::PageOverlayController::shouldSkipLayerInDump const): * page/PageOverlayController.h: * platform/graphics/GraphicsLayer.cpp: (WebCore::GraphicsLayer::dumpLayer const): (WebCore::dumpChildren): (WebCore::GraphicsLayer::dumpProperties const): (WebCore::GraphicsLayer::layerTreeAsText const): (showGraphicsLayerTree): * platform/graphics/GraphicsLayer.h: (WebCore::GraphicsLayer::dumpLayer): (WebCore::GraphicsLayer::layerTreeAsText): (WebCore::GraphicsLayer::dumpAdditionalProperties const): * platform/graphics/GraphicsLayerClient.h: (WebCore::GraphicsLayerClient::shouldSkipLayerInDump const): (WebCore::GraphicsLayerClient::shouldDumpPropertyForLayer const): * platform/graphics/LayerTreeAsTextOptions.h: Added. * platform/graphics/ca/GraphicsLayerCA.cpp: (WebCore::GraphicsLayerCA::dumpAdditionalProperties const): * platform/graphics/ca/GraphicsLayerCA.h: * platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp: (WebCore::dumpInnerLayer): (WebCore::CoordinatedGraphicsLayer::dumpAdditionalProperties const): * platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.h: * rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::shouldSkipLayerInDump const): (WebCore::RenderLayerBacking::shouldDumpPropertyForLayer const): * rendering/RenderLayerBacking.h: * rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::layerTreeAsText): * rendering/RenderLayerCompositor.h: * testing/Internals.cpp: (WebCore::toLayerTreeAsTextOptions): (WebCore::Internals::layerTreeAsText const): (WebCore::Internals::pageOverlayLayerTreeAsText const): (WebCore::toLayerTreeFlags): Deleted. * testing/MockPageOverlayClient.cpp: (WebCore::MockPageOverlayClient::layerTreeAsText): * testing/MockPageOverlayClient.h: Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/Headers.cmake trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj trunk/Source/WebCore/page/Frame.h trunk/Source/WebCore/page/PageOverlayController.cpp trunk/Source/WebCore/page/PageOverlayController.h trunk/Source/WebCore/platform/graphics/GraphicsLayer.cpp trunk/Source/WebCore/platform/graphics/GraphicsLayer.h trunk/Source/WebCore/platform/graphics/GraphicsLayerClient.h trunk/Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp trunk/Source/WebCore/platform/graphics/ca/GraphicsLayerCA.h trunk/Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp trunk/Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.h trunk/Source/WebCore/rendering/RenderLayerBacking.cpp trunk/Source/WebCore/rendering/RenderLayerBacking.h trunk/Source/WebCore/rendering/RenderLayerCompositor.cpp trunk/Source/WebCore/rendering/RenderLayerCompositor.h trunk/Source/WebCore/testing/Internals.cpp trunk/Source/WebCore/testing/MockPageOverlayClient.cpp trunk/Source/WebCore/testing/MockPageOverlayClient.h trunk/Source/WebKitLegacy/win/WebCoreSupport/AcceleratedCompositingContext.cpp Added Paths trunk/Source/WebCore/platform/graphics/LayerTreeAsTextOptions.h Diff Modified: trunk/Source/WebCore/ChangeLog (281237 => 281238) --- trunk/Source/WebCore/ChangeLog 2021-08-19 15:46:32 UTC (rev 281237) +++ trunk/Source/WebCore/ChangeLog 2021-08-19 15:47:35 UTC (rev 281238) @@ -1,5 +1,59 @@ 2021-08-19 Simon Fraser +Remove duplicate LayerTreeAsText enums and use an OptionSet<> +https://bugs.webkit.org/show_bug.cgi?id=229226 + +Reviewed by Antti Koivisto. + +GraphicsLayerClient had enum LayerTreeAsTextBehaviorFlags and Frame had an anonymous +enum and typedef unsigned LayerTreeFlags. Clean up by adding LayerTreeAsTextOptions.h +and using OptionSet everywhere. + +* Headers.cmake: +* WebCore.xcodeproj/project.pbxproj: +* page/Frame.h: +* page/PageOverlayController.cpp: +(WebCore::PageOverlayController::shouldSkipLayerInDump const): +* page/PageOverlayController.h: +* platform/graphics/GraphicsLayer.cpp: +(WebCore::GraphicsLayer::dumpLayer const): +(WebCore::dumpChildren): +(WebCore::GraphicsLayer::dumpProperties const): +(WebCore::GraphicsLayer::layerTreeAsText const): +(showGraphicsLayerTree): +* platform/graphics/GraphicsLayer.h: +(WebCore::GraphicsLayer::dumpLayer): +(WebCore::GraphicsLayer::layerTreeAsText): +
[webkit-changes] [281237] trunk/Source/WebCore
Title: [281237] trunk/Source/WebCore
Revision 281237
Author simon.fra...@apple.com
Date 2021-08-19 08:46:32 -0700 (Thu, 19 Aug 2021)
Log Message
Use an enum for the forVisitedLink argument to BuilderState::colorFromPrimitiveValue()
https://bugs.webkit.org/show_bug.cgi?id=229224
Reviewed by Alex Christensen.
Convert the bool argument to an enum class.
* css/makeprop.pl:
(colorFromPrimitiveValue):
* style/StyleBuilderCustom.h:
(WebCore::Style::BuilderCustom::applyValueCaretColor):
(WebCore::Style::BuilderCustom::applyValueStrokeColor):
* style/StyleBuilderState.cpp:
(WebCore::Style::BuilderState::colorFromPrimitiveValue const):
* style/StyleBuilderState.h:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/makeprop.pl
trunk/Source/WebCore/style/StyleBuilderCustom.h
trunk/Source/WebCore/style/StyleBuilderState.cpp
trunk/Source/WebCore/style/StyleBuilderState.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (281236 => 281237)
--- trunk/Source/WebCore/ChangeLog 2021-08-19 15:32:57 UTC (rev 281236)
+++ trunk/Source/WebCore/ChangeLog 2021-08-19 15:46:32 UTC (rev 281237)
@@ -1,3 +1,21 @@
+2021-08-19 Simon Fraser
+
+Use an enum for the forVisitedLink argument to BuilderState::colorFromPrimitiveValue()
+https://bugs.webkit.org/show_bug.cgi?id=229224
+
+Reviewed by Alex Christensen.
+
+Convert the bool argument to an enum class.
+
+* css/makeprop.pl:
+(colorFromPrimitiveValue):
+* style/StyleBuilderCustom.h:
+(WebCore::Style::BuilderCustom::applyValueCaretColor):
+(WebCore::Style::BuilderCustom::applyValueStrokeColor):
+* style/StyleBuilderState.cpp:
+(WebCore::Style::BuilderState::colorFromPrimitiveValue const):
+* style/StyleBuilderState.h:
+
2021-08-19 Youenn Fablet
RTCPeerConnection::m_transceiverSet does not need to be allocated separately from its RTCPeerConnection
Modified: trunk/Source/WebCore/css/makeprop.pl (281236 => 281237)
--- trunk/Source/WebCore/css/makeprop.pl 2021-08-19 15:32:57 UTC (rev 281236)
+++ trunk/Source/WebCore/css/makeprop.pl 2021-08-19 15:46:32 UTC (rev 281237)
@@ -1013,7 +1013,7 @@
my $primitiveValue = shift;
my $forVisitedLink = @_ ? shift : NOT_FOR_VISITED_LINK;
- return "builderState.colorFromPrimitiveValue(" . $primitiveValue . ", /* forVisitedLink */ " . ($forVisitedLink ? "true" : "false") . ")";
+ return "builderState.colorFromPrimitiveValue(" . $primitiveValue . ", ForVisitedLink::" . ($forVisitedLink ? "Yes" : "No") . ")";
}
use constant {
Modified: trunk/Source/WebCore/style/StyleBuilderCustom.h (281236 => 281237)
--- trunk/Source/WebCore/style/StyleBuilderCustom.h 2021-08-19 15:32:57 UTC (rev 281236)
+++ trunk/Source/WebCore/style/StyleBuilderCustom.h 2021-08-19 15:46:32 UTC (rev 281237)
@@ -825,13 +825,13 @@
if (primitiveValue.valueID() == CSSValueAuto)
builderState.style().setHasAutoCaretColor();
else
-builderState.style().setCaretColor(builderState.colorFromPrimitiveValue(primitiveValue, /* forVisitedLink */ false));
+builderState.style().setCaretColor(builderState.colorFromPrimitiveValue(primitiveValue, ForVisitedLink::No));
}
if (builderState.applyPropertyToVisitedLinkStyle()) {
if (primitiveValue.valueID() == CSSValueAuto)
builderState.style().setHasVisitedLinkAutoCaretColor();
else
-builderState.style().setVisitedLinkCaretColor(builderState.colorFromPrimitiveValue(primitiveValue, /* forVisitedLink */ true));
+builderState.style().setVisitedLinkCaretColor(builderState.colorFromPrimitiveValue(primitiveValue, ForVisitedLink::Yes));
}
}
@@ -2024,9 +2024,9 @@
{
auto& primitiveValue = downcast(value);
if (builderState.applyPropertyToRegularStyle())
-builderState.style().setStrokeColor(builderState.colorFromPrimitiveValue(primitiveValue, /* forVisitedLink */ false));
+builderState.style().setStrokeColor(builderState.colorFromPrimitiveValue(primitiveValue, ForVisitedLink::No));
if (builderState.applyPropertyToVisitedLinkStyle())
-builderState.style().setVisitedLinkStrokeColor(builderState.colorFromPrimitiveValue(primitiveValue, /* forVisitedLink */ true));
+builderState.style().setVisitedLinkStrokeColor(builderState.colorFromPrimitiveValue(primitiveValue, ForVisitedLink::Yes));
builderState.style().setHasExplicitlySetStrokeColor(true);
}
Modified: trunk/Source/WebCore/style/StyleBuilderState.cpp (281236 => 281237)
--- trunk/Source/WebCore/style/StyleBuilderState.cpp 2021-08-19 15:32:57 UTC (rev 281236)
+++ trunk/Source/WebCore/style/StyleBuilderState.cpp 2021-08-19 15:46:32 UTC (rev 281237)
@@ -290,7 +290,7 @@
}
}
-Color BuilderState::colorFromPrimitiveValue(const CSSPrimitiveValue& value, bool forVisitedLink) const
+Color BuilderState::colorFromPrimitiveValue(const CSSPrimitiveValue& value, ForVisitedLink
[webkit-changes] [281236] trunk/LayoutTests
Title: [281236] trunk/LayoutTests Revision 281236 Author ayumi_koj...@apple.com Date 2021-08-19 08:32:57 -0700 (Thu, 19 Aug 2021) Log Message [ Win EWS ] fast/forms/* tests are flaky crashing FAULTING_IP: WebKit!WebCore::FontCache::lastResortFallbackFont+ec [C:\cygwin\home\buildbot\worker\Windows-EWS\build\Source\WebCore\platform\graphics\win\FontCacheWin.cpp @ 424]. https://bugs.webkit.org/show_bug.cgi?id=229009 Unreviewed test gardening. * platform/win/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/win/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (281235 => 281236) --- trunk/LayoutTests/ChangeLog 2021-08-19 13:05:50 UTC (rev 281235) +++ trunk/LayoutTests/ChangeLog 2021-08-19 15:32:57 UTC (rev 281236) @@ -1,3 +1,12 @@ +2021-08-19 Ayumi Kojima + +[ Win EWS ] fast/forms/* tests are flaky crashing FAULTING_IP: WebKit!WebCore::FontCache::lastResortFallbackFont+ec [C:\cygwin\home\buildbot\worker\Windows-EWS\build\Source\WebCore\platform\graphics\win\FontCacheWin.cpp @ 424]. +https://bugs.webkit.org/show_bug.cgi?id=229009 + +Unreviewed test gardening. + +* platform/win/TestExpectations: + 2021-08-19 Kate Cheney [App Privacy Report] Some HTTP Redirects from non app initiated requests are marked app initiated Modified: trunk/LayoutTests/platform/win/TestExpectations (281235 => 281236) --- trunk/LayoutTests/platform/win/TestExpectations 2021-08-19 13:05:50 UTC (rev 281235) +++ trunk/LayoutTests/platform/win/TestExpectations 2021-08-19 15:32:57 UTC (rev 281236) @@ -4664,6 +4664,11 @@ webkit.org/b/229009 fast/forms/form-element-geometry.html [ Pass Crash ] webkit.org/b/229009 fast/forms/focus-selection-input.html [ Pass Crash ] webkit.org/b/229009 fast/forms/select/listbox-in-multi-column.html [ Pass Crash ] +webkit.org/b/229009 fast/events/mouse-cursor-image-set.html [ Pass Crash ] +webkit.org/b/229009 fast/forms/input-button-sizes.html [ Pass Crash ] +webkit.org/b/229009 fast/forms/input-placeholder-paint-order-2.html [ Pass Crash ] +webkit.org/b/229009 fast/forms/select/select-painting.html [ Pass Crash ] +webkit.org/b/229009 fast/forms/textarea/textarea-placeholder-paint-order-2.html [ Pass Crash ] webkit.org/b/229143 fast/forms/input-appearance-spinbutton-size.html [ Pass Crash ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [281235] trunk/Source/WebKit
Title: [281235] trunk/Source/WebKit
Revision 281235
Author katherine_che...@apple.com
Date 2021-08-19 06:05:50 -0700 (Thu, 19 Aug 2021)
Log Message
Unable to load downloaded HTML files in Safari
https://bugs.webkit.org/show_bug.cgi?id=229254
Reviewed by Brent Fulgham.
Check quarantine bits for webarchive files only.
* UIProcess/Cocoa/WebPageProxyCocoa.mm:
(WebKit::WebPageProxy::isQuarantinedAndNotUserApproved):
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/Cocoa/WebPageProxyCocoa.mm
Diff
Modified: trunk/Source/WebKit/ChangeLog (281234 => 281235)
--- trunk/Source/WebKit/ChangeLog 2021-08-19 12:57:59 UTC (rev 281234)
+++ trunk/Source/WebKit/ChangeLog 2021-08-19 13:05:50 UTC (rev 281235)
@@ -1,5 +1,18 @@
2021-08-19 Kate Cheney
+Unable to load downloaded HTML files in Safari
+https://bugs.webkit.org/show_bug.cgi?id=229254
+
+
+Reviewed by Brent Fulgham.
+
+Check quarantine bits for webarchive files only.
+
+* UIProcess/Cocoa/WebPageProxyCocoa.mm:
+(WebKit::WebPageProxy::isQuarantinedAndNotUserApproved):
+
+2021-08-19 Kate Cheney
+
[App Privacy Report] Some HTTP Redirects from non app initiated requests are marked app initiated
https://bugs.webkit.org/show_bug.cgi?id=229202
Modified: trunk/Source/WebKit/UIProcess/Cocoa/WebPageProxyCocoa.mm (281234 => 281235)
--- trunk/Source/WebKit/UIProcess/Cocoa/WebPageProxyCocoa.mm 2021-08-19 12:57:59 UTC (rev 281234)
+++ trunk/Source/WebKit/UIProcess/Cocoa/WebPageProxyCocoa.mm 2021-08-19 13:05:50 UTC (rev 281235)
@@ -724,6 +724,9 @@
#if PLATFORM(MAC)
bool WebPageProxy::isQuarantinedAndNotUserApproved(const String& fileURLString)
{
+if (!fileURLString.endsWithIgnoringASCIICase(".webarchive"))
+return false;
+
NSURL *fileURL = [NSURL URLWithString:fileURLString];
qtn_file_t qf = qtn_file_alloc();
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [281234] trunk
Title: [281234] trunk Revision 281234 Author katherine_che...@apple.com Date 2021-08-19 05:57:59 -0700 (Thu, 19 Aug 2021) Log Message [App Privacy Report] Some HTTP Redirects from non app initiated requests are marked app initiated https://bugs.webkit.org/show_bug.cgi?id=229202 Reviewed by Brent Fulgham. Source/WebKit: Tests: http/tests/app-privacy-report/app-attribution-media-redirect.html http/tests/app-privacy-report/user-attribution-media-redirect.html The request returned in the completion handler of NetworkDataTaskCocoa::willPerformHTTPRedirection does not always have the attribution property of the original request. We should pass it along and set it. * NetworkProcess/cocoa/NetworkSessionCocoa.mm: (-[WKNetworkSessionDelegate URLSession:task:willPerformHTTPRedirection:newRequest:completionHandler:]): LayoutTests: Layout test coverage. This bug was only reproducing with media-related loading, so these tests redirect to load an mp4. * http/tests/app-privacy-report/app-attribution-media-redirect-expected.txt: Added. * http/tests/app-privacy-report/app-attribution-media-redirect.html: Added. * http/tests/app-privacy-report/user-attribution-media-redirect-expected.txt: Added. * http/tests/app-privacy-report/user-attribution-media-redirect.html: Added. Modified Paths trunk/LayoutTests/ChangeLog trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm Added Paths trunk/LayoutTests/http/tests/app-privacy-report/app-attribution-media-redirect-expected.txt trunk/LayoutTests/http/tests/app-privacy-report/app-attribution-media-redirect.html trunk/LayoutTests/http/tests/app-privacy-report/user-attribution-media-redirect-expected.txt trunk/LayoutTests/http/tests/app-privacy-report/user-attribution-media-redirect.html Diff Modified: trunk/LayoutTests/ChangeLog (281233 => 281234) --- trunk/LayoutTests/ChangeLog 2021-08-19 12:23:58 UTC (rev 281233) +++ trunk/LayoutTests/ChangeLog 2021-08-19 12:57:59 UTC (rev 281234) @@ -1,3 +1,19 @@ +2021-08-19 Kate Cheney + +[App Privacy Report] Some HTTP Redirects from non app initiated requests are marked app initiated +https://bugs.webkit.org/show_bug.cgi?id=229202 + + +Reviewed by Brent Fulgham. + +Layout test coverage. This bug was only reproducing with media-related +loading, so these tests redirect to load an mp4. + +* http/tests/app-privacy-report/app-attribution-media-redirect-expected.txt: Added. +* http/tests/app-privacy-report/app-attribution-media-redirect.html: Added. +* http/tests/app-privacy-report/user-attribution-media-redirect-expected.txt: Added. +* http/tests/app-privacy-report/user-attribution-media-redirect.html: Added. + 2021-08-19 Philippe Normand Unreviewed, GStreamer gardening Added: trunk/LayoutTests/http/tests/app-privacy-report/app-attribution-media-redirect-expected.txt (0 => 281234) --- trunk/LayoutTests/http/tests/app-privacy-report/app-attribution-media-redirect-expected.txt (rev 0) +++ trunk/LayoutTests/http/tests/app-privacy-report/app-attribution-media-redirect-expected.txt 2021-08-19 12:57:59 UTC (rev 281234) @@ -0,0 +1,10 @@ +Test media files loaded via redirect are marked app initiated + +On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE". + + +PASS successfully loaded only app initiated requests +PASS successfullyParsed is true + +TEST COMPLETE + Added: trunk/LayoutTests/http/tests/app-privacy-report/app-attribution-media-redirect.html (0 => 281234) --- trunk/LayoutTests/http/tests/app-privacy-report/app-attribution-media-redirect.html (rev 0) +++ trunk/LayoutTests/http/tests/app-privacy-report/app-attribution-media-redirect.html 2021-08-19 12:57:59 UTC (rev 281234) @@ -0,0 +1,45 @@ + + + + + +