[webkit-changes] [283303] trunk/LayoutTests
Title: [283303] trunk/LayoutTests Revision 283303 Author you...@apple.com Date 2021-09-29 22:41:18 -0700 (Wed, 29 Sep 2021) Log Message Import WPT push api tests https://bugs.webkit.org/show_bug.cgi?id=230945 Reviewed by Alex Christensen. LayoutTests/imported/w3c: * resources/import-expectations.json: * web-platform-tests/push-api/META.yml: Added. * web-platform-tests/push-api/idlharness.https.any-expected.txt: Added. * web-platform-tests/push-api/idlharness.https.any.html: Added. * web-platform-tests/push-api/idlharness.https.any.js: Added. * web-platform-tests/push-api/idlharness.https.any.serviceworker-expected.txt: Added. * web-platform-tests/push-api/idlharness.https.any.serviceworker.html: Added. * web-platform-tests/push-api/idlharness.https.any.worker-expected.txt: Added. * web-platform-tests/push-api/idlharness.https.any.worker.html: Added. * web-platform-tests/push-api/w3c-import.log: Added. LayoutTests: * platform/mac-wk1/TestExpectations: Skip tests in WK1 Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/imported/w3c/ChangeLog trunk/LayoutTests/imported/w3c/resources/import-expectations.json trunk/LayoutTests/platform/mac-wk1/TestExpectations Added Paths trunk/LayoutTests/imported/w3c/web-platform-tests/push-api/ trunk/LayoutTests/imported/w3c/web-platform-tests/push-api/META.yml trunk/LayoutTests/imported/w3c/web-platform-tests/push-api/idlharness.https.any-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/push-api/idlharness.https.any.html trunk/LayoutTests/imported/w3c/web-platform-tests/push-api/idlharness.https.any.js trunk/LayoutTests/imported/w3c/web-platform-tests/push-api/idlharness.https.any.serviceworker-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/push-api/idlharness.https.any.serviceworker.html trunk/LayoutTests/imported/w3c/web-platform-tests/push-api/idlharness.https.any.worker-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/push-api/idlharness.https.any.worker.html trunk/LayoutTests/imported/w3c/web-platform-tests/push-api/w3c-import.log Diff Modified: trunk/LayoutTests/ChangeLog (283302 => 283303) --- trunk/LayoutTests/ChangeLog 2021-09-30 05:39:59 UTC (rev 283302) +++ trunk/LayoutTests/ChangeLog 2021-09-30 05:41:18 UTC (rev 283303) @@ -1,5 +1,15 @@ 2021-09-29 Youenn Fablet +Import WPT push api tests +https://bugs.webkit.org/show_bug.cgi?id=230945 + +Reviewed by Alex Christensen. + +* platform/mac-wk1/TestExpectations: +Skip tests in WK1 + +2021-09-29 Youenn Fablet + Import WPT notification service worker test https://bugs.webkit.org/show_bug.cgi?id=230944 Modified: trunk/LayoutTests/imported/w3c/ChangeLog (283302 => 283303) --- trunk/LayoutTests/imported/w3c/ChangeLog 2021-09-30 05:39:59 UTC (rev 283302) +++ trunk/LayoutTests/imported/w3c/ChangeLog 2021-09-30 05:41:18 UTC (rev 283303) @@ -1,5 +1,23 @@ 2021-09-29 Youenn Fablet +Import WPT push api tests +https://bugs.webkit.org/show_bug.cgi?id=230945 + +Reviewed by Alex Christensen. + +* resources/import-expectations.json: +* web-platform-tests/push-api/META.yml: Added. +* web-platform-tests/push-api/idlharness.https.any-expected.txt: Added. +* web-platform-tests/push-api/idlharness.https.any.html: Added. +* web-platform-tests/push-api/idlharness.https.any.js: Added. +* web-platform-tests/push-api/idlharness.https.any.serviceworker-expected.txt: Added. +* web-platform-tests/push-api/idlharness.https.any.serviceworker.html: Added. +* web-platform-tests/push-api/idlharness.https.any.worker-expected.txt: Added. +* web-platform-tests/push-api/idlharness.https.any.worker.html: Added. +* web-platform-tests/push-api/w3c-import.log: Added. + +2021-09-29 Youenn Fablet + Import WPT notification service worker test https://bugs.webkit.org/show_bug.cgi?id=230944 Modified: trunk/LayoutTests/imported/w3c/resources/import-expectations.json (283302 => 283303) --- trunk/LayoutTests/imported/w3c/resources/import-expectations.json 2021-09-30 05:39:59 UTC (rev 283302) +++ trunk/LayoutTests/imported/w3c/resources/import-expectations.json 2021-09-30 05:41:18 UTC (rev 283303) @@ -390,6 +390,7 @@ "web-platform-tests/presentation-api": "skip", "web-platform-tests/progress-events": "skip", "web-platform-tests/proximity": "skip", +"web-platform-tests/push-api": "import", "web-platform-tests/quirks-mode": "skip", "web-platform-tests/quirks/unitless-length": "import", "web-platform-tests/referrer-policy": "import", Added: trunk/LayoutTests/imported/w3c/web-platform-tests/push-api/META.yml (0 => 283303) --- trunk/LayoutTests/imported/w3c/web-platform-tests/push-api/META.yml (rev 0) +++ trunk/LayoutTests/imported/w3c/web-platform-tests/push-api/META.yml 2021-09-30 05:41:18 UTC (rev 283303) @@ -0,0 +1,3 @@
[webkit-changes] [283302] trunk/LayoutTests
Title: [283302] trunk/LayoutTests Revision 283302 Author you...@apple.com Date 2021-09-29 22:39:59 -0700 (Wed, 29 Sep 2021) Log Message Import WPT notification service worker test https://bugs.webkit.org/show_bug.cgi?id=230944 Reviewed by Alex Christensen. LayoutTests/imported/w3c: * web-platform-tests/notifications/idlharness.https.any.serviceworker.html: Added. LayoutTests: * platform/mac-wk1/TestExpectations: Skip test in WK1 Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/imported/w3c/ChangeLog trunk/LayoutTests/platform/mac-wk1/TestExpectations Added Paths trunk/LayoutTests/imported/w3c/web-platform-tests/notifications/idlharness.https.any.serviceworker-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/notifications/idlharness.https.any.serviceworker.html Diff Modified: trunk/LayoutTests/ChangeLog (283301 => 283302) --- trunk/LayoutTests/ChangeLog 2021-09-30 05:30:32 UTC (rev 283301) +++ trunk/LayoutTests/ChangeLog 2021-09-30 05:39:59 UTC (rev 283302) @@ -1,3 +1,13 @@ +2021-09-29 Youenn Fablet + +Import WPT notification service worker test +https://bugs.webkit.org/show_bug.cgi?id=230944 + +Reviewed by Alex Christensen. + +* platform/mac-wk1/TestExpectations: +Skip test in WK1 + 2021-09-29 Saam Barati Print values in a nicer way in the jsc shell Modified: trunk/LayoutTests/imported/w3c/ChangeLog (283301 => 283302) --- trunk/LayoutTests/imported/w3c/ChangeLog 2021-09-30 05:30:32 UTC (rev 283301) +++ trunk/LayoutTests/imported/w3c/ChangeLog 2021-09-30 05:39:59 UTC (rev 283302) @@ -1,3 +1,12 @@ +2021-09-29 Youenn Fablet + +Import WPT notification service worker test +https://bugs.webkit.org/show_bug.cgi?id=230944 + +Reviewed by Alex Christensen. + +* web-platform-tests/notifications/idlharness.https.any.serviceworker.html: Added. + 2021-09-29 Kiet Ho Implement the 'ic' unit from CSS Values 4 Added: trunk/LayoutTests/imported/w3c/web-platform-tests/notifications/idlharness.https.any.serviceworker-expected.txt (0 => 283302) --- trunk/LayoutTests/imported/w3c/web-platform-tests/notifications/idlharness.https.any.serviceworker-expected.txt (rev 0) +++ trunk/LayoutTests/imported/w3c/web-platform-tests/notifications/idlharness.https.any.serviceworker-expected.txt 2021-09-30 05:39:59 UTC (rev 283302) @@ -0,0 +1,52 @@ + +PASS idl_test setup +PASS idl_test validation +PASS Partial interface ServiceWorkerRegistration: original interface defined +PASS Partial interface ServiceWorkerRegistration: member names are unique +PASS Partial interface ServiceWorkerGlobalScope: original interface defined +PASS Partial interface ServiceWorkerGlobalScope: member names are unique +PASS WorkerGlobalScope includes WindowOrWorkerGlobalScope: member names are unique +FAIL Notification interface: existence and properties of interface object assert_own_property: self does not have own property "Notification" expected property "Notification" missing +FAIL Notification interface object length assert_own_property: self does not have own property "Notification" expected property "Notification" missing +FAIL Notification interface object name assert_own_property: self does not have own property "Notification" expected property "Notification" missing +FAIL Notification interface: existence and properties of interface prototype object assert_own_property: self does not have own property "Notification" expected property "Notification" missing +FAIL Notification interface: existence and properties of interface prototype object's "constructor" property assert_own_property: self does not have own property "Notification" expected property "Notification" missing +FAIL Notification interface: existence and properties of interface prototype object's @@unscopables property assert_own_property: self does not have own property "Notification" expected property "Notification" missing +FAIL Notification interface: attribute permission assert_own_property: self does not have own property "Notification" expected property "Notification" missing +FAIL Notification interface: member requestPermission undefined is not an Object. (evaluating 'member.name in this.get_interface_object()') +FAIL Notification interface: attribute maxActions assert_own_property: self does not have own property "Notification" expected property "Notification" missing +FAIL Notification interface: attribute onclick assert_own_property: self does not have own property "Notification" expected property "Notification" missing +FAIL Notification interface: attribute onshow assert_own_property: self does not have own property "Notification" expected property "Notification" missing +FAIL Notification interface: attribute onerror assert_own_property: self does not have own property "Notification" expected property "Notification" missing +FAIL Notification interface: attribute onclose assert_own_property: sel
[webkit-changes] [283301] trunk/Source/WebCore
Title: [283301] trunk/Source/WebCore
Revision 283301
Author commit-qu...@webkit.org
Date 2021-09-29 22:30:32 -0700 (Wed, 29 Sep 2021)
Log Message
GPUP Cocoa GraphicsContextGLOpenGL should check for ANGLE presence
https://bugs.webkit.org/show_bug.cgi?id=230946
Patch by Kimmo Kinnunen on 2021-09-29
Reviewed by Antti Koivisto.
For consistency, avoid crashing the GPUP mode when trying
to create GraphicsContextGLOpenGL when the ANGLE-shared dylib
is not present.
No new tests, refactor.
* platform/graphics/cocoa/GraphicsContextGLOpenGLCocoa.mm:
(WebCore::isANGLEAvailable):
(WebCore::initializeEGLDisplay):
(WebCore::GraphicsContextGLOpenGL::create):
(WebCore::GraphicsContextGLOpenGL::GraphicsContextGLOpenGL):
(WebCore::GraphicsContextGLOpenGL::makeContextCurrent):
(WebCore::InitializeEGLDisplay): Deleted.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/cocoa/GraphicsContextGLOpenGLCocoa.mm
Diff
Modified: trunk/Source/WebCore/ChangeLog (283300 => 283301)
--- trunk/Source/WebCore/ChangeLog 2021-09-30 05:27:45 UTC (rev 283300)
+++ trunk/Source/WebCore/ChangeLog 2021-09-30 05:30:32 UTC (rev 283301)
@@ -1,5 +1,26 @@
2021-09-29 Kimmo Kinnunen
+GPUP Cocoa GraphicsContextGLOpenGL should check for ANGLE presence
+https://bugs.webkit.org/show_bug.cgi?id=230946
+
+Reviewed by Antti Koivisto.
+
+For consistency, avoid crashing the GPUP mode when trying
+to create GraphicsContextGLOpenGL when the ANGLE-shared dylib
+is not present.
+
+No new tests, refactor.
+
+* platform/graphics/cocoa/GraphicsContextGLOpenGLCocoa.mm:
+(WebCore::isANGLEAvailable):
+(WebCore::initializeEGLDisplay):
+(WebCore::GraphicsContextGLOpenGL::create):
+(WebCore::GraphicsContextGLOpenGL::GraphicsContextGLOpenGL):
+(WebCore::GraphicsContextGLOpenGL::makeContextCurrent):
+(WebCore::InitializeEGLDisplay): Deleted.
+
+2021-09-29 Kimmo Kinnunen
+
Cocoa GraphicsContextGLOpenGL should be more robust in destruction
https://bugs.webkit.org/show_bug.cgi?id=230940
Modified: trunk/Source/WebCore/platform/graphics/cocoa/GraphicsContextGLOpenGLCocoa.mm (283300 => 283301)
--- trunk/Source/WebCore/platform/graphics/cocoa/GraphicsContextGLOpenGLCocoa.mm 2021-09-30 05:27:45 UTC (rev 283300)
+++ trunk/Source/WebCore/platform/graphics/cocoa/GraphicsContextGLOpenGLCocoa.mm 2021-09-30 05:30:32 UTC (rev 283301)
@@ -59,6 +59,11 @@
namespace WebCore {
+static bool isANGLEAvailable()
+{
+return !!EGL_Initialize;
+}
+
// In isCurrentContextPredictable() == true case this variable is accessed in single-threaded manner.
// In isCurrentContextPredictable() == false case this variable is accessed from multiple threads but always sequentially
// and it always contains nullptr and nullptr is always written to it.
@@ -113,8 +118,13 @@
return false;
}
-static ScopedEGLDefaultDisplay InitializeEGLDisplay(const GraphicsContextGLAttributes& attrs)
+static ScopedEGLDefaultDisplay initializeEGLDisplay(const GraphicsContextGLAttributes& attrs)
{
+if (!isANGLEAvailable()) {
+WTFLogAlways("Failed to load ANGLE shared library.");
+return { };
+}
+
EGLint majorVersion = 0;
EGLint minorVersion = 0;
EGLDisplay display;
@@ -180,19 +190,8 @@
}
#endif
-static bool isANGLEAvailable()
-{
-return !!EGL_Initialize;
-}
-
RefPtr GraphicsContextGLOpenGL::create(GraphicsContextGLAttributes attrs, HostWindow* hostWindow)
{
-// If ANGLE is not loaded, we can fail immediately.
-if (!isANGLEAvailable()) {
-WTFLogAlways("ANGLE shared library was not loaded. Can't make GraphicsContextGL.");
-return nullptr;
-}
-
// Make space for the incoming context if we're full.
GraphicsContextGLOpenGLManager::sharedManager().recycleContextIfNecessary();
if (GraphicsContextGLOpenGLManager::sharedManager().hasTooManyContexts())
@@ -245,7 +244,7 @@
}
#endif
-m_displayObj = InitializeEGLDisplay(attrs);
+m_displayObj = initializeEGLDisplay(attrs);
if (!m_displayObj)
return;
@@ -519,7 +518,7 @@
return false;
if (currentContext == this)
return true;
-// Calling MakeCurrent is important to set volatile platform context. See InitializeEGLDisplay().
+// Calling MakeCurrent is important to set volatile platform context. See initializeEGLDisplay().
if (!EGL_MakeCurrent(m_displayObj, EGL_NO_SURFACE, EGL_NO_SURFACE, m_contextObj))
return false;
if (isCurrentContextPredictable())
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [283300] trunk
Title: [283300] trunk
Revision 283300
Author mark@apple.com
Date 2021-09-29 22:27:45 -0700 (Wed, 29 Sep 2021)
Log Message
DFG strength reduction on % operator should handle an INT_MIN divisor.
https://bugs.webkit.org/show_bug.cgi?id=230391
Reviewed by Robin Morisset.
JSTests:
* stress/dfg-strength-reduction-on-mod-should-handle-INT_MIN.js: Added.
Source/_javascript_Core:
* dfg/DFGStrengthReductionPhase.cpp:
(JSC::DFG::StrengthReductionPhase::handleNode):
Modified Paths
trunk/JSTests/ChangeLog
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/dfg/DFGStrengthReductionPhase.cpp
Added Paths
trunk/JSTests/stress/dfg-strength-reduction-on-mod-should-handle-INT_MIN.js
Diff
Modified: trunk/JSTests/ChangeLog (283299 => 283300)
--- trunk/JSTests/ChangeLog 2021-09-30 05:17:38 UTC (rev 283299)
+++ trunk/JSTests/ChangeLog 2021-09-30 05:27:45 UTC (rev 283300)
@@ -1,3 +1,13 @@
+2021-09-29 Mark Lam
+
+DFG strength reduction on % operator should handle an INT_MIN divisor.
+https://bugs.webkit.org/show_bug.cgi?id=230391
+
+
+Reviewed by Robin Morisset.
+
+* stress/dfg-strength-reduction-on-mod-should-handle-INT_MIN.js: Added.
+
2021-09-29 Saam Barati
Print values in a nicer way in the jsc shell
Added: trunk/JSTests/stress/dfg-strength-reduction-on-mod-should-handle-INT_MIN.js (0 => 283300)
--- trunk/JSTests/stress/dfg-strength-reduction-on-mod-should-handle-INT_MIN.js (rev 0)
+++ trunk/JSTests/stress/dfg-strength-reduction-on-mod-should-handle-INT_MIN.js 2021-09-30 05:27:45 UTC (rev 283300)
@@ -0,0 +1,11 @@
+function foo(num) {
+num |= 0;
+let x1 = num % -2147483648;
+let x2 = x1 % 5;
+
+if (x2 > 5)
+throw "Error";
+}
+
+for (let i = 0; i < 1; i++)
+foo(i);
Modified: trunk/Source/_javascript_Core/ChangeLog (283299 => 283300)
--- trunk/Source/_javascript_Core/ChangeLog 2021-09-30 05:17:38 UTC (rev 283299)
+++ trunk/Source/_javascript_Core/ChangeLog 2021-09-30 05:27:45 UTC (rev 283300)
@@ -1,3 +1,14 @@
+2021-09-29 Mark Lam
+
+DFG strength reduction on % operator should handle an INT_MIN divisor.
+https://bugs.webkit.org/show_bug.cgi?id=230391
+
+
+Reviewed by Robin Morisset.
+
+* dfg/DFGStrengthReductionPhase.cpp:
+(JSC::DFG::StrengthReductionPhase::handleNode):
+
2021-09-29 Saam Barati
Print values in a nicer way in the jsc shell
Modified: trunk/Source/_javascript_Core/dfg/DFGStrengthReductionPhase.cpp (283299 => 283300)
--- trunk/Source/_javascript_Core/dfg/DFGStrengthReductionPhase.cpp 2021-09-30 05:17:38 UTC (rev 283299)
+++ trunk/Source/_javascript_Core/dfg/DFGStrengthReductionPhase.cpp 2021-09-30 05:27:45 UTC (rev 283300)
@@ -1,5 +1,5 @@
/*
- * Copyright (C) 2013-2019 Apple Inc. All rights reserved.
+ * Copyright (C) 2013-2021 Apple Inc. All rights reserved.
*
* Redistribution and use in source and binary forms, with or without
* modification, are permitted provided that the following conditions
@@ -197,8 +197,15 @@
&& m_node->child2()->isInt32Constant()
&& m_node->child1()->op() == ArithMod
&& m_node->child1()->binaryUseKind() == Int32Use
-&& m_node->child1()->child2()->isInt32Constant()
-&& std::abs(m_node->child1()->child2()->asInt32()) <= std::abs(m_node->child2()->asInt32())) {
+&& m_node->child1()->child2()->isInt32Constant()) {
+
+int32_t const1 = m_node->child1()->child2()->asInt32();
+int32_t const2 = m_node->child2()->asInt32();
+
+if (const1 == INT_MIN || const2 == INT_MIN)
+break; // std::abs(INT_MIN) is undefined.
+
+if (std::abs(const1) <= std::abs(const2))
convertToIdentityOverChild1();
}
break;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [283299] trunk/Source/WebCore
Title: [283299] trunk/Source/WebCore
Revision 283299
Author commit-qu...@webkit.org
Date 2021-09-29 22:17:38 -0700 (Wed, 29 Sep 2021)
Log Message
Cocoa GraphicsContextGLOpenGL should be more robust in destruction
https://bugs.webkit.org/show_bug.cgi?id=230940
Patch by Kimmo Kinnunen on 2021-09-29
Reviewed by Antti Koivisto.
Delete resources based on checking if they exist, not based on
a flag that should cause them to exist. Currently the constructor can return early,
so various resources might not exist even if their flag condition would
indicate they should.
No new tests, refactor.
* platform/graphics/cocoa/GraphicsContextGLOpenGLCocoa.mm:
(WebCore::GraphicsContextGLOpenGL::~GraphicsContextGLOpenGL):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/cocoa/GraphicsContextGLOpenGLCocoa.mm
Diff
Modified: trunk/Source/WebCore/ChangeLog (283298 => 283299)
--- trunk/Source/WebCore/ChangeLog 2021-09-30 05:00:57 UTC (rev 283298)
+++ trunk/Source/WebCore/ChangeLog 2021-09-30 05:17:38 UTC (rev 283299)
@@ -1,3 +1,20 @@
+2021-09-29 Kimmo Kinnunen
+
+Cocoa GraphicsContextGLOpenGL should be more robust in destruction
+https://bugs.webkit.org/show_bug.cgi?id=230940
+
+Reviewed by Antti Koivisto.
+
+Delete resources based on checking if they exist, not based on
+a flag that should cause them to exist. Currently the constructor can return early,
+so various resources might not exist even if their flag condition would
+indicate they should.
+
+No new tests, refactor.
+
+* platform/graphics/cocoa/GraphicsContextGLOpenGLCocoa.mm:
+(WebCore::GraphicsContextGLOpenGL::~GraphicsContextGLOpenGL):
+
2021-09-29 Simon Fraser
Minor cleanup of some rubber-banding code in ScrollingEffectsController
Modified: trunk/Source/WebCore/platform/graphics/cocoa/GraphicsContextGLOpenGLCocoa.mm (283298 => 283299)
--- trunk/Source/WebCore/platform/graphics/cocoa/GraphicsContextGLOpenGLCocoa.mm 2021-09-30 05:00:57 UTC (rev 283298)
+++ trunk/Source/WebCore/platform/graphics/cocoa/GraphicsContextGLOpenGLCocoa.mm 2021-09-30 05:17:38 UTC (rev 283299)
@@ -429,19 +429,18 @@
{
GraphicsContextGLOpenGLManager::sharedManager().removeContext(this);
if (makeContextCurrent()) {
-GraphicsContextGLAttributes attrs = contextAttributes();
-gl::DeleteTextures(1, &m_texture);
-
-if (attrs.antialias) {
+if (m_texture)
+gl::DeleteTextures(1, &m_texture);
+if (m_multisampleColorBuffer)
gl::DeleteRenderbuffers(1, &m_multisampleColorBuffer);
-if (attrs.stencil || attrs.depth)
-gl::DeleteRenderbuffers(1, &m_multisampleDepthStencilBuffer);
+if (m_multisampleDepthStencilBuffer)
+gl::DeleteRenderbuffers(1, &m_multisampleDepthStencilBuffer);
+if (m_multisampleFBO)
gl::DeleteFramebuffers(1, &m_multisampleFBO);
-} else {
-if (attrs.stencil || attrs.depth)
-gl::DeleteRenderbuffers(1, &m_depthStencilBuffer);
-}
-gl::DeleteFramebuffers(1, &m_fbo);
+if (m_depthStencilBuffer)
+gl::DeleteRenderbuffers(1, &m_depthStencilBuffer);
+if (m_fbo)
+gl::DeleteFramebuffers(1, &m_fbo);
if (m_preserveDrawingBufferTexture)
gl::DeleteTextures(1, &m_preserveDrawingBufferTexture);
if (m_preserveDrawingBufferFBO)
@@ -453,8 +452,9 @@
for (auto& fence : m_frameCompletionFences)
fence.abandon();
}
-if (m_displayBufferPbuffer) {
+if (m_displayBufferPbuffer)
EGL_DestroySurface(m_displayObj, m_displayBufferPbuffer);
+if (m_swapChain) {
auto recycledBuffer = m_swapChain->recycleBuffer();
if (recycledBuffer.handle)
EGL_DestroySurface(m_displayObj, recycledBuffer.handle);
@@ -465,8 +465,8 @@
if (m_contextObj) {
clearCurrentContext();
EGL_DestroyContext(m_displayObj, m_contextObj);
-} else
-ASSERT(currentContext != this);
+}
+ASSERT(currentContext != this);
LOG(WebGL, "Destroyed a GraphicsContextGLOpenGL (%p).", this);
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [283298] trunk/Tools
Title: [283298] trunk/Tools
Revision 283298
Author achristen...@apple.com
Date 2021-09-29 22:00:57 -0700 (Wed, 29 Sep 2021)
Log Message
Terminate PCM daemon before and after unit test that uses it
https://bugs.webkit.org/show_bug.cgi?id=230191
In r282368 I added a unit test that creates a daemon, uses it, then terminates it.
On some bots it has been timing out. Once it starts timing out, it probably won't stop because
it won't get to the part of the test that terminates the problematic daemon.
* TestWebKitAPI/Tests/WebKitCocoa/EventAttribution.mm:
(TestWebKitAPI::TEST):
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/EventAttribution.mm
Diff
Modified: trunk/Tools/ChangeLog (283297 => 283298)
--- trunk/Tools/ChangeLog 2021-09-30 04:18:17 UTC (rev 283297)
+++ trunk/Tools/ChangeLog 2021-09-30 05:00:57 UTC (rev 283298)
@@ -1,3 +1,15 @@
+2021-09-29 Alex Christensen
+
+Terminate PCM daemon before and after unit test that uses it
+https://bugs.webkit.org/show_bug.cgi?id=230191
+
+In r282368 I added a unit test that creates a daemon, uses it, then terminates it.
+On some bots it has been timing out. Once it starts timing out, it probably won't stop because
+it won't get to the part of the test that terminates the problematic daemon.
+
+* TestWebKitAPI/Tests/WebKitCocoa/EventAttribution.mm:
+(TestWebKitAPI::TEST):
+
2021-09-29 Chris Dumez
Add support for running service workers on the main thread
Modified: trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/EventAttribution.mm (283297 => 283298)
--- trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/EventAttribution.mm 2021-09-30 04:18:17 UTC (rev 283297)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/EventAttribution.mm 2021-09-30 05:00:57 UTC (rev 283298)
@@ -452,6 +452,8 @@
[fileManager removeItemAtURL:tempDir error:&error];
EXPECT_NULL(error);
+system("killall AdAttributionDaemon -9 2> null");
+
auto plist = testDaemonPList(tempDir);
#if HAVE(OS_LAUNCHD_JOB)
auto launchDJob = adoptNS([[OSLaunchdJob alloc] initWithPlist:plist.get()]);
@@ -476,11 +478,6 @@
});
system("killall AdAttributionDaemon -9");
-#if HAVE(OS_LAUNCHD_JOB)
-// LaunchOnlyOnce takes care of cleanup with launchd.
-#else
-system([NSString stringWithFormat:@"launchctl unload %@", plistLocation.path].UTF8String);
-#endif
EXPECT_TRUE([fileManager fileExistsAtPath:tempDir.path]);
[fileManager removeItemAtURL:tempDir error:&error];
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [283297] trunk/Source/WebKit
Title: [283297] trunk/Source/WebKit
Revision 283297
Author commit-qu...@webkit.org
Date 2021-09-29 21:18:17 -0700 (Wed, 29 Sep 2021)
Log Message
[WebXR] Hold a foreground assertion for the duration of the immersive session
https://bugs.webkit.org/show_bug.cgi?id=230991
Patch by Ada Chan on 2021-09-29
Reviewed by Chris Dumez.
* UIProcess/XR/PlatformXRSystem.cpp:
(WebKit::PlatformXRSystem::initializeTrackingAndRendering):
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/XR/PlatformXRSystem.cpp
Diff
Modified: trunk/Source/WebKit/ChangeLog (283296 => 283297)
--- trunk/Source/WebKit/ChangeLog 2021-09-30 02:33:01 UTC (rev 283296)
+++ trunk/Source/WebKit/ChangeLog 2021-09-30 04:18:17 UTC (rev 283297)
@@ -1,3 +1,13 @@
+2021-09-29 Ada Chan
+
+[WebXR] Hold a foreground assertion for the duration of the immersive session
+https://bugs.webkit.org/show_bug.cgi?id=230991
+
+Reviewed by Chris Dumez.
+
+* UIProcess/XR/PlatformXRSystem.cpp:
+(WebKit::PlatformXRSystem::initializeTrackingAndRendering):
+
2021-09-29 Chris Dumez
Add support for running service workers on the main thread
Modified: trunk/Source/WebKit/UIProcess/XR/PlatformXRSystem.cpp (283296 => 283297)
--- trunk/Source/WebKit/UIProcess/XR/PlatformXRSystem.cpp 2021-09-30 02:33:01 UTC (rev 283296)
+++ trunk/Source/WebKit/UIProcess/XR/PlatformXRSystem.cpp 2021-09-30 04:18:17 UTC (rev 283297)
@@ -79,8 +79,10 @@
if (!xrCoordinator)
return;
-xrCoordinator->startSession(m_page, [weakThis = makeWeakPtr(*this)](XRDeviceIdentifier deviceIdentifier) {
-RunLoop::main().dispatch([weakThis, deviceIdentifier]() mutable {
+auto immersiveSessionActivity = m_page.process().throttler().foregroundActivity("XR immersive session"_s);
+
+xrCoordinator->startSession(m_page, [weakThis = makeWeakPtr(*this), immersiveSessionActivity = WTFMove(immersiveSessionActivity)](XRDeviceIdentifier deviceIdentifier) mutable {
+RunLoop::main().dispatch([weakThis, deviceIdentifier, immersiveSessionActivity = WTFMove(immersiveSessionActivity)]() mutable {
if (weakThis)
weakThis->m_page.send(Messages::PlatformXRSystemProxy::SessionDidEnd(deviceIdentifier));
});
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [283296] trunk/Source/WebCore
Title: [283296] trunk/Source/WebCore
Revision 283296
Author simon.fra...@apple.com
Date 2021-09-29 19:33:01 -0700 (Wed, 29 Sep 2021)
Log Message
Minor cleanup of some rubber-banding code in ScrollingEffectsController
https://bugs.webkit.org/show_bug.cgi?id=230981
Reviewed by Tim Horton.
As a precursor to unraveling some of the complexity of the rubber-banding code,
tidy up naming and code in ScrollingEffectsController::handleWheelEvent(). No
behavior change.
* platform/PlatformWheelEvent.h:
(WebCore::PlatformWheelEvent::unacceleratedScrollingDelta const):
(WebCore::PlatformWheelEvent::unacceleratedScrollingDeltaX const): Deleted.
(WebCore::PlatformWheelEvent::unacceleratedScrollingDeltaY const): Deleted.
* platform/ScrollingEffectsController.h:
* platform/mac/ScrollingEffectsController.mm:
(WebCore::convertToProminentAxisFavoringVertical):
(WebCore::ScrollingEffectsController::handleWheelEvent):
(WebCore::ScrollingEffectsController::wheelDeltaBiasingTowardsVertical):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/PlatformWheelEvent.h
trunk/Source/WebCore/platform/ScrollingEffectsController.h
trunk/Source/WebCore/platform/mac/ScrollingEffectsController.mm
Diff
Modified: trunk/Source/WebCore/ChangeLog (283295 => 283296)
--- trunk/Source/WebCore/ChangeLog 2021-09-30 02:19:59 UTC (rev 283295)
+++ trunk/Source/WebCore/ChangeLog 2021-09-30 02:33:01 UTC (rev 283296)
@@ -1,3 +1,24 @@
+2021-09-29 Simon Fraser
+
+Minor cleanup of some rubber-banding code in ScrollingEffectsController
+https://bugs.webkit.org/show_bug.cgi?id=230981
+
+Reviewed by Tim Horton.
+
+As a precursor to unraveling some of the complexity of the rubber-banding code,
+tidy up naming and code in ScrollingEffectsController::handleWheelEvent(). No
+behavior change.
+
+* platform/PlatformWheelEvent.h:
+(WebCore::PlatformWheelEvent::unacceleratedScrollingDelta const):
+(WebCore::PlatformWheelEvent::unacceleratedScrollingDeltaX const): Deleted.
+(WebCore::PlatformWheelEvent::unacceleratedScrollingDeltaY const): Deleted.
+* platform/ScrollingEffectsController.h:
+* platform/mac/ScrollingEffectsController.mm:
+(WebCore::convertToProminentAxisFavoringVertical):
+(WebCore::ScrollingEffectsController::handleWheelEvent):
+(WebCore::ScrollingEffectsController::wheelDeltaBiasingTowardsVertical):
+
2021-09-29 Chris Dumez
Add support for running service workers on the main thread
Modified: trunk/Source/WebCore/platform/PlatformWheelEvent.h (283295 => 283296)
--- trunk/Source/WebCore/platform/PlatformWheelEvent.h 2021-09-30 02:19:59 UTC (rev 283295)
+++ trunk/Source/WebCore/platform/PlatformWheelEvent.h 2021-09-30 02:33:01 UTC (rev 283296)
@@ -150,8 +150,7 @@
#if PLATFORM(COCOA)
unsigned scrollCount() const { return m_scrollCount; }
-float unacceleratedScrollingDeltaX() const { return m_unacceleratedScrollingDeltaX; }
-float unacceleratedScrollingDeltaY() const { return m_unacceleratedScrollingDeltaY; }
+FloatSize unacceleratedScrollingDelta() const { return { m_unacceleratedScrollingDeltaX, m_unacceleratedScrollingDeltaY }; }
#endif
#if ENABLE(ASYNC_SCROLLING)
Modified: trunk/Source/WebCore/platform/ScrollingEffectsController.h (283295 => 283296)
--- trunk/Source/WebCore/platform/ScrollingEffectsController.h 2021-09-30 02:19:59 UTC (rev 283295)
+++ trunk/Source/WebCore/platform/ScrollingEffectsController.h 2021-09-30 02:33:01 UTC (rev 283296)
@@ -234,7 +234,7 @@
#if PLATFORM(MAC)
WallTime m_lastMomentumScrollTimestamp;
-FloatSize m_overflowScrollDelta;
+FloatSize m_unappliedOverscrollDelta;
FloatSize m_stretchScrollForce;
FloatSize m_momentumVelocity;
Modified: trunk/Source/WebCore/platform/mac/ScrollingEffectsController.mm (283295 => 283296)
--- trunk/Source/WebCore/platform/mac/ScrollingEffectsController.mm 2021-09-30 02:19:59 UTC (rev 283295)
+++ trunk/Source/WebCore/platform/mac/ScrollingEffectsController.mm 2021-09-30 02:33:01 UTC (rev 283296)
@@ -83,6 +83,15 @@
#endif
}
+
+static FloatSize convertToProminentAxisFavoringVertical(FloatSize delta)
+{
+if (fabsf(delta.height()) >= fabsf(delta.width()))
+return { 0, delta.height() };
+
+return { delta.width(), 0 };
+}
+
bool ScrollingEffectsController::handleWheelEvent(const PlatformWheelEvent& wheelEvent)
{
if (processWheelEventForScrollSnap(wheelEvent))
@@ -109,7 +118,7 @@
IntSize stretchAmount = m_client.stretchAmount();
m_stretchScrollForce.setWidth(reboundDeltaForElasticDelta(stretchAmount.width()));
m_stretchScrollForce.setHeight(reboundDeltaForElasticDelta(stretchAmount.height()));
-m_overflowScrollDelta = { };
+m_unappliedOverscrollDelta = { };
stopSnapRubberbandAnimation();
updateRubberBandingState();
@@ -136,42 +145,24 @@
return false;
}
-float de
[webkit-changes] [283295] trunk
Title: [283295] trunk Revision 283295 Author cdu...@apple.com Date 2021-09-29 19:19:59 -0700 (Wed, 29 Sep 2021) Log Message Add support for running service workers on the main thread https://bugs.webkit.org/show_bug.cgi?id=230649 Reviewed by Alex Christensen. Source/WebCore: Add support for running service workers on the main thread (off by default). This is to support use cases where the InjectedBundle needs to have access to a service worker's JS global object and script it. It wouldn't be practical in such cases to have the service worker running off the main thread. Note that this is not meant to be used for service workers in general, only for some very specific service workers that require interaction with WebKit's injected bundle. * Headers.cmake: * Modules/indexeddb/client/IDBConnectionProxy.cpp: (WebCore::IDBClient::IDBConnectionProxy::forgetActivityForCurrentThread): * Modules/websockets/WorkerThreadableWebSocketChannel.cpp: (WebCore::WorkerThreadableWebSocketChannel::Bridge::waitForMethodCompletion): * WebCore.xcodeproj/project.pbxproj: * inspector/WorkerDebugger.cpp: (WebCore::WorkerDebugger::runEventLoopWhilePaused): * loader/WorkerThreadableLoader.cpp: (WebCore::WorkerThreadableLoader::loadResourceSynchronously): * page/PerformanceUserTiming.cpp: (WebCore::PerformanceUserTiming::convertMarkToTimestamp const): * workers/WorkerOrWorkletGlobalScope.h: * workers/WorkerOrWorkletScriptController.cpp: (WebCore::WorkerOrWorkletScriptController::loadModuleSynchronously): * workers/WorkerOrWorkletScriptController.h: * workers/WorkerOrWorkletThread.cpp: (WebCore::constructRunLoop): (WebCore::WorkerOrWorkletThread::WorkerOrWorkletThread): (WebCore::WorkerOrWorkletThread::startRunningDebuggerTasks): (WebCore::WorkerOrWorkletThread::runEventLoop): (WebCore::WorkerOrWorkletThread::workerOrWorkletThread): (WebCore::WorkerOrWorkletThread::stop): (WebCore::WorkerOrWorkletThread::suspend): (WebCore::WorkerOrWorkletThread::resume): * workers/WorkerOrWorkletThread.h: * workers/WorkerRunLoop.cpp: (WebCore::ModePredicate::operator() const): (WebCore::WorkerDedicatedRunLoop::WorkerDedicatedRunLoop): (WebCore::WorkerDedicatedRunLoop::~WorkerDedicatedRunLoop): (WebCore::RunLoopSetup::RunLoopSetup): (WebCore::WorkerDedicatedRunLoop::run): (WebCore::WorkerDedicatedRunLoop::runInDebuggerMode): (WebCore::WorkerDedicatedRunLoop::runInMode): (WebCore::WorkerDedicatedRunLoop::runCleanupTasks): (WebCore::WorkerDedicatedRunLoop::terminate): (WebCore::WorkerDedicatedRunLoop::postTaskAndTerminate): (WebCore::WorkerDedicatedRunLoop::postTaskForMode): (WebCore::WorkerDedicatedRunLoop::Task::performTask): (WebCore::WorkerDedicatedRunLoop::Task::Task): (WebCore::WorkerMainRunLoop::WorkerMainRunLoop): (WebCore::WorkerMainRunLoop::setGlobalScope): (WebCore::WorkerMainRunLoop::postTaskAndTerminate): (WebCore::WorkerMainRunLoop::postTaskForMode): (WebCore::WorkerMainRunLoop::runInMode): * workers/WorkerRunLoop.h: (WebCore::WorkerRunLoop::createUniqueId): (isType): * workers/WorkerThread.cpp: (WebCore::WorkerParameters::isolatedCopy const): (WebCore::WorkerThread::WorkerThread): (WebCore::WorkerThread::createThread): (WebCore::WorkerThread::evaluateScriptIfNecessary): * workers/WorkerThread.h: * workers/WorkerThreadMode.h: Added. * workers/service/ServiceWorkerGlobalScope.cpp: (WebCore::ServiceWorkerGlobalScope::updateExtendedEventsSet): * workers/service/context/ServiceWorkerThread.cpp: (WebCore::generateWorkerParameters): (WebCore::ServiceWorkerThread::ServiceWorkerThread): (WebCore::ServiceWorkerThread::finishedEvaluatingScript): (WebCore::ServiceWorkerThread::startHeartBeatTimer): * workers/service/context/ServiceWorkerThread.h: * workers/service/context/ServiceWorkerThreadProxy.cpp: (WebCore::ServiceWorkerThreadProxy::ServiceWorkerThreadProxy): * workers/service/context/ServiceWorkerThreadProxy.h: * workers/service/server/SWServer.cpp: (WebCore::SWServer::SWServer): (WebCore::SWServer::installContextData): (WebCore::SWServer::runServiceWorker): * workers/service/server/SWServer.h: * workers/service/server/SWServerToContextConnection.h: Source/WebKit: Add support for running service workers on the main thread (off by default). * NetworkProcess/NetworkProcess.cpp: (WebKit::NetworkProcess::swServerForSession): * NetworkProcess/NetworkSession.cpp: (WebKit::NetworkSession::NetworkSession): * NetworkProcess/NetworkSession.h: (WebKit::NetworkSession::shouldRunServiceWorkersOnMainThread const): * NetworkProcess/NetworkSessionCreationParameters.cpp: (WebKit::NetworkSessionCreationParameters::encode const): (WebKit::NetworkSessionCreationParameters::decode): * NetworkProcess/NetworkSessionCreationParameters.h: * NetworkProcess/ServiceWorker/WebSWServerToContextConnection.cpp: (WebKit::WebSWServerToContextConnection::installServiceWorkerContext): * NetworkProcess/ServiceWorker/WebSWServerToContextConnection.h: * UIProcess/API/Cocoa/_WKWebsiteDataStoreConfiguration.h: * UIProcess/API/Cocoa/_WKWebsiteDataStoreConfiguration.mm:
[webkit-changes] [283294] trunk/Source/WebKit
Title: [283294] trunk/Source/WebKit
Revision 283294
Author commit-qu...@webkit.org
Date 2021-09-29 19:01:37 -0700 (Wed, 29 Sep 2021)
Log Message
Add weakThis check in addition to null check added in r282881
https://bugs.webkit.org/show_bug.cgi?id=231000
Patch by Alex Christensen on 2021-09-29
Reviewed by Brady Eidson.
r282881 made NetworkLoad::start call didCompleteWithError, which can cause the
NetworkResourceLoader to be deleted. It added a null check on m_networkLoad which
sometimes reads freed memory. This certainly isn't great, but luckily we have a way
to check if this object has been deleted. Let's do that.
* NetworkProcess/NetworkResourceLoader.cpp:
(WebKit::NetworkResourceLoader::startNetworkLoad):
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/NetworkProcess/NetworkResourceLoader.cpp
Diff
Modified: trunk/Source/WebKit/ChangeLog (283293 => 283294)
--- trunk/Source/WebKit/ChangeLog 2021-09-30 01:39:22 UTC (rev 283293)
+++ trunk/Source/WebKit/ChangeLog 2021-09-30 02:01:37 UTC (rev 283294)
@@ -1,3 +1,19 @@
+2021-09-29 Alex Christensen
+
+Add weakThis check in addition to null check added in r282881
+https://bugs.webkit.org/show_bug.cgi?id=231000
+
+
+Reviewed by Brady Eidson.
+
+r282881 made NetworkLoad::start call didCompleteWithError, which can cause the
+NetworkResourceLoader to be deleted. It added a null check on m_networkLoad which
+sometimes reads freed memory. This certainly isn't great, but luckily we have a way
+to check if this object has been deleted. Let's do that.
+
+* NetworkProcess/NetworkResourceLoader.cpp:
+(WebKit::NetworkResourceLoader::startNetworkLoad):
+
2021-09-29 Per Arne Vollan
[macOS] Allow audio service in the WebContent process on older versions
Modified: trunk/Source/WebKit/NetworkProcess/NetworkResourceLoader.cpp (283293 => 283294)
--- trunk/Source/WebKit/NetworkProcess/NetworkResourceLoader.cpp 2021-09-30 01:39:22 UTC (rev 283293)
+++ trunk/Source/WebKit/NetworkProcess/NetworkResourceLoader.cpp 2021-09-30 02:01:37 UTC (rev 283294)
@@ -343,12 +343,13 @@
parameters.isNavigatingToAppBoundDomain = m_parameters.isNavigatingToAppBoundDomain;
m_networkLoad = makeUnique(*this, &networkSession->blobRegistry(), WTFMove(parameters), *networkSession);
+auto weakThis = makeWeakPtr(*this);
if (isSynchronous())
-m_networkLoad->start();
+m_networkLoad->start(); // May delete this object
else
m_networkLoad->startWithScheduling();
-if (m_networkLoad)
+if (weakThis && m_networkLoad)
LOADER_RELEASE_LOG("startNetworkLoad: Going to the network (description=%" PUBLIC_LOG_STRING ")", m_networkLoad->description().utf8().data());
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [283293] trunk
Title: [283293] trunk
Revision 283293
Author sbar...@apple.com
Date 2021-09-29 18:39:22 -0700 (Wed, 29 Sep 2021)
Log Message
Print values in a nicer way in the jsc shell
https://bugs.webkit.org/show_bug.cgi?id=230931
Reviewed by Tadeu Zagallo.
JSTests:
* ChakraCore/test/jsc-lib.js:
Source/_javascript_Core:
Currently, print(1), print("1"), and print([1]) all print to stdout
simply as "1" (without the quotes). Same for values when running the
REPL. This isn't super helpful. Let's print quotes for strings, and
brackets for arrays.
Some tests rely on the old print behavior. Those tests now use the legacyPrint
instead.
* jsc.cpp:
(toCString):
(printInternal):
(JSC_DEFINE_HOST_FUNCTION):
(runInteractive):
(cStringFromViewWithString): Deleted.
* runtime/JSCJSValue.cpp:
(JSC::JSValue::toWTFStringForConsole const):
* runtime/JSCJSValue.h:
LayoutTests:
* resources/standalone-pre.js:
Modified Paths
trunk/JSTests/ChakraCore/test/jsc-lib.js
trunk/JSTests/ChangeLog
trunk/JSTests/exceptionFuzz/3d-cube.js
trunk/JSTests/exceptionFuzz/date-format-xparb.js
trunk/JSTests/exceptionFuzz/earley-boyer.js
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/resources/standalone-pre.js
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/jsc.cpp
trunk/Source/_javascript_Core/runtime/JSCJSValue.cpp
trunk/Source/_javascript_Core/runtime/JSCJSValue.h
Diff
Modified: trunk/JSTests/ChakraCore/test/jsc-lib.js (283292 => 283293)
--- trunk/JSTests/ChakraCore/test/jsc-lib.js 2021-09-30 01:25:13 UTC (rev 283292)
+++ trunk/JSTests/ChakraCore/test/jsc-lib.js 2021-09-30 01:39:22 UTC (rev 283293)
@@ -1,3 +1,5 @@
+print = legacyPrint;
+
WScript = {
_jscGC: gc,
_jscLoad: load,
Modified: trunk/JSTests/ChangeLog (283292 => 283293)
--- trunk/JSTests/ChangeLog 2021-09-30 01:25:13 UTC (rev 283292)
+++ trunk/JSTests/ChangeLog 2021-09-30 01:39:22 UTC (rev 283293)
@@ -1,5 +1,14 @@
2021-09-29 Saam Barati
+Print values in a nicer way in the jsc shell
+https://bugs.webkit.org/show_bug.cgi?id=230931
+
+Reviewed by Tadeu Zagallo.
+
+* ChakraCore/test/jsc-lib.js:
+
+2021-09-29 Saam Barati
+
We need to load the baseline JIT's constant pool register after OSR exit to checkpoints if we return to baseline code
https://bugs.webkit.org/show_bug.cgi?id=230972
Modified: trunk/JSTests/exceptionFuzz/3d-cube.js (283292 => 283293)
--- trunk/JSTests/exceptionFuzz/3d-cube.js 2021-09-30 01:25:13 UTC (rev 283292)
+++ trunk/JSTests/exceptionFuzz/3d-cube.js 2021-09-30 01:39:22 UTC (rev 283293)
@@ -358,5 +358,5 @@
})();
} catch (e) {
-print("JSC EXCEPTION FUZZ: Caught exception: " + e);
+legacyPrint("JSC EXCEPTION FUZZ: Caught exception: " + e);
}
Modified: trunk/JSTests/exceptionFuzz/date-format-xparb.js (283292 => 283293)
--- trunk/JSTests/exceptionFuzz/date-format-xparb.js 2021-09-30 01:25:13 UTC (rev 283292)
+++ trunk/JSTests/exceptionFuzz/date-format-xparb.js 2021-09-30 01:39:22 UTC (rev 283293)
@@ -424,5 +424,5 @@
})();
} catch (e) {
-print("JSC EXCEPTION FUZZ: Caught exception: " + e);
+legacyPrint("JSC EXCEPTION FUZZ: Caught exception: " + e);
}
Modified: trunk/JSTests/exceptionFuzz/earley-boyer.js (283292 => 283293)
--- trunk/JSTests/exceptionFuzz/earley-boyer.js 2021-09-30 01:25:13 UTC (rev 283292)
+++ trunk/JSTests/exceptionFuzz/earley-boyer.js 2021-09-30 01:39:22 UTC (rev 283293)
@@ -4684,6 +4684,6 @@
}
})();
} catch (e) {
-print("JSC EXCEPTION FUZZ: Caught exception: " + e);
+legacyPrint("JSC EXCEPTION FUZZ: Caught exception: " + e);
}
Modified: trunk/LayoutTests/ChangeLog (283292 => 283293)
--- trunk/LayoutTests/ChangeLog 2021-09-30 01:25:13 UTC (rev 283292)
+++ trunk/LayoutTests/ChangeLog 2021-09-30 01:39:22 UTC (rev 283293)
@@ -1,3 +1,12 @@
+2021-09-29 Saam Barati
+
+Print values in a nicer way in the jsc shell
+https://bugs.webkit.org/show_bug.cgi?id=230931
+
+Reviewed by Tadeu Zagallo.
+
+* resources/standalone-pre.js:
+
2021-09-29 Chris Dumez
[ iOS Debug ] http/tests/xmlhttprequest/access-control-preflight-credential-sync.html is a flaky crash
Modified: trunk/LayoutTests/resources/standalone-pre.js (283292 => 283293)
--- trunk/LayoutTests/resources/standalone-pre.js 2021-09-30 01:25:13 UTC (rev 283292)
+++ trunk/LayoutTests/resources/standalone-pre.js 2021-09-30 01:39:22 UTC (rev 283293)
@@ -13,6 +13,8 @@
didPassSomeTestsSilently = false;
didFailSomeTests = false;
+print = legacyPrint;
+
function description(msg)
{
print(msg);
Modified: trunk/Source/_javascript_Core/ChangeLog (283292 => 283293)
--- trunk/Source/_javascript_Core/ChangeLog 2021-09-30 01:25:13 UTC (rev 283292)
+++ trunk/Source/_javascript_Core/ChangeLog 2021-09-30 01:39:22 UTC (rev 283293)
@@ -1,5 +1,30 @@
2021-09-29 Saam Barati
+Print values in a nicer way in the jsc shell
+https://bugs.webkit.org/show_bug.cgi?id=230931
+
+Reviewed b
[webkit-changes] [283292] trunk/Tools
Title: [283292] trunk/Tools
Revision 283292
Author jbed...@apple.com
Date 2021-09-29 18:25:13 -0700 (Wed, 29 Sep 2021)
Log Message
[webkitscmpy] Contributors may be undefined
https://bugs.webkit.org/show_bug.cgi?id=230997
Reviewed by Dewei Zhu.
* Scripts/libraries/webkitscmpy/setup.py: Bump version.
* Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py: Ditto.
* Scripts/libraries/webkitscmpy/webkitscmpy/program/__init__.py:
(main): Ensure that repositories always have defined contributors.
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/libraries/webkitscmpy/setup.py
trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py
trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/__init__.py
Diff
Modified: trunk/Tools/ChangeLog (283291 => 283292)
--- trunk/Tools/ChangeLog 2021-09-30 00:57:38 UTC (rev 283291)
+++ trunk/Tools/ChangeLog 2021-09-30 01:25:13 UTC (rev 283292)
@@ -1,3 +1,16 @@
+2021-09-29 Jonathan Bedard
+
+[webkitscmpy] Contributors may be undefined
+https://bugs.webkit.org/show_bug.cgi?id=230997
+
+
+Reviewed by Dewei Zhu.
+
+* Scripts/libraries/webkitscmpy/setup.py: Bump version.
+* Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py: Ditto.
+* Scripts/libraries/webkitscmpy/webkitscmpy/program/__init__.py:
+(main): Ensure that repositories always have defined contributors.
+
2021-09-29 Basuke Suzuki
[webkitpy] LOG_CHANNEL is widely used in the codebase and shouldn't be treated as error
Modified: trunk/Tools/Scripts/libraries/webkitscmpy/setup.py (283291 => 283292)
--- trunk/Tools/Scripts/libraries/webkitscmpy/setup.py 2021-09-30 00:57:38 UTC (rev 283291)
+++ trunk/Tools/Scripts/libraries/webkitscmpy/setup.py 2021-09-30 01:25:13 UTC (rev 283292)
@@ -29,7 +29,7 @@
setup(
name='webkitscmpy',
-version='2.2.1',
+version='2.2.2',
description='Library designed to interact with git and svn repositories.',
long_description=readme(),
classifiers=[
Modified: trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py (283291 => 283292)
--- trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py 2021-09-30 00:57:38 UTC (rev 283291)
+++ trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py 2021-09-30 01:25:13 UTC (rev 283292)
@@ -46,7 +46,7 @@
"Please install webkitcorepy with `pip install webkitcorepy --extra-index-url `"
)
-version = Version(2, 2, 1)
+version = Version(2, 2, 2)
AutoInstall.register(Package('fasteners', Version(0, 15, 0)))
AutoInstall.register(Package('monotonic', Version(1, 5)))
Modified: trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/__init__.py (283291 => 283292)
--- trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/__init__.py 2021-09-30 00:57:38 UTC (rev 283291)
+++ trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/__init__.py 2021-09-30 01:25:13 UTC (rev 283292)
@@ -104,7 +104,7 @@
repository = local.Scm.from_path(path=parsed.repository, contributors=None if callable(contributors) else contributors)
if callable(contributors):
-repository.contributors = contributors(repository)
+repository.contributors = contributors(repository) or repository.contributors
if callable(identifier_template):
identifier_template = identifier_template(repository)
if callable(subversion):
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [283291] branches/safari-613.1.3-branch/Tools
Title: [283291] branches/safari-613.1.3-branch/Tools Revision 283291 Author alanc...@apple.com Date 2021-09-29 17:57:38 -0700 (Wed, 29 Sep 2021) Log Message Cherry-pick r283172. rdar://problem/83697127 REGRESSION (r283102): [ MacOS Debug ] TestWebKitAPI.WebKit2.CaptureIndicatorDelay is failing https://bugs.webkit.org/show_bug.cgi?id=230847 Reviewed by Saam Barati. As identified by Saam, the promise resolution callback is racing with the stop function. To prevent this, we check in a loop whether the page has a stream and call stop when that is the case. * TestWebKitAPI/Tests/WebKit/GetUserMedia.mm: (TestWebKitAPI::TEST): * TestWebKitAPI/Tests/WebKit/getUserMedia.html: git-svn-id: https://svn.webkit.org/repository/webkit/trunk@283172 268f45cc-cd09-0410-ab3c-d52691b4dbfc Modified Paths branches/safari-613.1.3-branch/Tools/ChangeLog branches/safari-613.1.3-branch/Tools/TestWebKitAPI/Tests/WebKit/GetUserMedia.mm Diff Modified: branches/safari-613.1.3-branch/Tools/ChangeLog (283290 => 283291) --- branches/safari-613.1.3-branch/Tools/ChangeLog 2021-09-30 00:57:35 UTC (rev 283290) +++ branches/safari-613.1.3-branch/Tools/ChangeLog 2021-09-30 00:57:38 UTC (rev 283291) @@ -1,3 +1,38 @@ +2021-09-29 Alan Coon + +Cherry-pick r283172. rdar://problem/83697127 + +REGRESSION (r283102): [ MacOS Debug ] TestWebKitAPI.WebKit2.CaptureIndicatorDelay is failing +https://bugs.webkit.org/show_bug.cgi?id=230847 + + +Reviewed by Saam Barati. + +As identified by Saam, the promise resolution callback is racing with the stop function. +To prevent this, we check in a loop whether the page has a stream and call stop when that is the case. + +* TestWebKitAPI/Tests/WebKit/GetUserMedia.mm: +(TestWebKitAPI::TEST): +* TestWebKitAPI/Tests/WebKit/getUserMedia.html: + + +git-svn-id: https://svn.webkit.org/repository/webkit/trunk@283172 268f45cc-cd09-0410-ab3c-d52691b4dbfc + +2021-09-28 Youenn Fablet + +REGRESSION (r283102): [ MacOS Debug ] TestWebKitAPI.WebKit2.CaptureIndicatorDelay is failing +https://bugs.webkit.org/show_bug.cgi?id=230847 + + +Reviewed by Saam Barati. + +As identified by Saam, the promise resolution callback is racing with the stop function. +To prevent this, we check in a loop whether the page has a stream and call stop when that is the case. + +* TestWebKitAPI/Tests/WebKit/GetUserMedia.mm: +(TestWebKitAPI::TEST): +* TestWebKitAPI/Tests/WebKit/getUserMedia.html: + 2021-09-25 Lauro Moura [GLIB] Use less parallel webviews in the uri-scheme API test for WPE and debug builds Modified: branches/safari-613.1.3-branch/Tools/TestWebKitAPI/Tests/WebKit/GetUserMedia.mm (283290 => 283291) --- branches/safari-613.1.3-branch/Tools/TestWebKitAPI/Tests/WebKit/GetUserMedia.mm 2021-09-30 00:57:35 UTC (rev 283290) +++ branches/safari-613.1.3-branch/Tools/TestWebKitAPI/Tests/WebKit/GetUserMedia.mm 2021-09-30 00:57:38 UTC (rev 283291) @@ -393,7 +393,10 @@ [webView loadTestPageNamed:@"getUserMedia"]; EXPECT_TRUE(waitUntilCaptureState(webView.get(), _WKMediaCaptureStateDeprecatedActiveCamera)); -[delegate waitUntilPrompted]; +int retryCount = 1000; +while (--retryCount && ![webView stringByEvaluatingJavaScript:@"haveStream()"].boolValue) +TestWebKitAPI::Util::spinRunLoop(10); +EXPECT_TRUE(!!retryCount); [webView stringByEvaluatingJavaScript:@"stop()"]; ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [283290] branches/safari-613.1.3-branch
Title: [283290] branches/safari-613.1.3-branch
Revision 283290
Author alanc...@apple.com
Date 2021-09-29 17:57:35 -0700 (Wed, 29 Sep 2021)
Log Message
Cherry-pick r283087. rdar://problem/83697121
Line iterator firstRun/lastRun may return runs from wrong lines
https://bugs.webkit.org/show_bug.cgi?id=230770
Reviewed by Alan Bujtas.
Source/WebCore:
In some situation line iterator firstRun/lastRun could return runs from different lines.
This could lead to inconsistencies like firstRun being non-null while lastRun is null.
Test: editing/iterator-line-start-end.html
* layout/integration/LayoutIntegrationLineIteratorModernPath.h:
(WebCore::LayoutIntegration::LineIteratorModernPath::firstRun const):
(WebCore::LayoutIntegration::LineIteratorModernPath::lastRun const):
Take care to only return runs from this line.
LayoutTests:
* editing/iterator-line-start-end-expected.txt: Added.
* editing/iterator-line-start-end.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@283087 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Modified Paths
branches/safari-613.1.3-branch/LayoutTests/ChangeLog
branches/safari-613.1.3-branch/Source/WebCore/ChangeLog
branches/safari-613.1.3-branch/Source/WebCore/layout/integration/LayoutIntegrationLineIteratorModernPath.h
Added Paths
branches/safari-613.1.3-branch/LayoutTests/editing/iterator-line-start-end-expected.txt
branches/safari-613.1.3-branch/LayoutTests/editing/iterator-line-start-end.html
Diff
Modified: branches/safari-613.1.3-branch/LayoutTests/ChangeLog (283289 => 283290)
--- branches/safari-613.1.3-branch/LayoutTests/ChangeLog 2021-09-30 00:55:27 UTC (rev 283289)
+++ branches/safari-613.1.3-branch/LayoutTests/ChangeLog 2021-09-30 00:57:35 UTC (rev 283290)
@@ -1,3 +1,45 @@
+2021-09-29 Alan Coon
+
+Cherry-pick r283087. rdar://problem/83697121
+
+Line iterator firstRun/lastRun may return runs from wrong lines
+https://bugs.webkit.org/show_bug.cgi?id=230770
+
+
+Reviewed by Alan Bujtas.
+
+Source/WebCore:
+
+In some situation line iterator firstRun/lastRun could return runs from different lines.
+This could lead to inconsistencies like firstRun being non-null while lastRun is null.
+
+Test: editing/iterator-line-start-end.html
+
+* layout/integration/LayoutIntegrationLineIteratorModernPath.h:
+(WebCore::LayoutIntegration::LineIteratorModernPath::firstRun const):
+(WebCore::LayoutIntegration::LineIteratorModernPath::lastRun const):
+
+Take care to only return runs from this line.
+
+LayoutTests:
+
+* editing/iterator-line-start-end-expected.txt: Added.
+* editing/iterator-line-start-end.html: Added.
+
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@283087 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2021-09-26 Antti Koivisto
+
+Line iterator firstRun/lastRun may return runs from wrong lines
+https://bugs.webkit.org/show_bug.cgi?id=230770
+
+
+Reviewed by Alan Bujtas.
+
+* editing/iterator-line-start-end-expected.txt: Added.
+* editing/iterator-line-start-end.html: Added.
+
2021-09-23 Tim Nguyen
Make inert nodes invisible to hit testing
Added: branches/safari-613.1.3-branch/LayoutTests/editing/iterator-line-start-end-expected.txt (0 => 283290)
--- branches/safari-613.1.3-branch/LayoutTests/editing/iterator-line-start-end-expected.txt (rev 0)
+++ branches/safari-613.1.3-branch/LayoutTests/editing/iterator-line-start-end-expected.txt 2021-09-30 00:57:35 UTC (rev 283290)
@@ -0,0 +1,3 @@
+
+This test passes if it doesn't crash
+x x
Added: branches/safari-613.1.3-branch/LayoutTests/editing/iterator-line-start-end.html (0 => 283290)
--- branches/safari-613.1.3-branch/LayoutTests/editing/iterator-line-start-end.html (rev 0)
+++ branches/safari-613.1.3-branch/LayoutTests/editing/iterator-line-start-end.html 2021-09-30 00:57:35 UTC (rev 283290)
@@ -0,0 +1,9 @@
+
+This test passes if it doesn't crash
+x x
+
+if (window.testRunner)
+testRunner.dumpAsText();
+
+document.execCommand("selectAll");
+
Modified: branches/safari-613.1.3-branch/Source/WebCore/ChangeLog (283289 => 283290)
--- branches/safari-613.1.3-branch/Source/WebCore/ChangeLog 2021-09-30 00:55:27 UTC (rev 283289)
+++ branches/safari-613.1.3-branch/Source/WebCore/ChangeLog 2021-09-30 00:57:35 UTC (rev 283290)
@@ -1,3 +1,53 @@
+2021-09-29 Alan Coon
+
+Cherry-pick r
[webkit-changes] [283289] trunk/Source/WebKit
Title: [283289] trunk/Source/WebKit Revision 283289 Author pvol...@apple.com Date 2021-09-29 17:55:27 -0700 (Wed, 29 Sep 2021) Log Message [macOS] Allow audio service in the WebContent process on older versions https://bugs.webkit.org/show_bug.cgi?id=230974 Reviewed by Brent Fulgham. Older versions of macOS still need access to "com.apple.audio.AudioComponentRegistrar" in the WebContent process. * WebProcess/com.apple.WebProcess.sb.in: Modified Paths trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/WebProcess/com.apple.WebProcess.sb.in Diff Modified: trunk/Source/WebKit/ChangeLog (283288 => 283289) --- trunk/Source/WebKit/ChangeLog 2021-09-30 00:47:41 UTC (rev 283288) +++ trunk/Source/WebKit/ChangeLog 2021-09-30 00:55:27 UTC (rev 283289) @@ -1,3 +1,15 @@ +2021-09-29 Per Arne Vollan + +[macOS] Allow audio service in the WebContent process on older versions +https://bugs.webkit.org/show_bug.cgi?id=230974 + + +Reviewed by Brent Fulgham. + +Older versions of macOS still need access to "com.apple.audio.AudioComponentRegistrar" in the WebContent process. + +* WebProcess/com.apple.WebProcess.sb.in: + 2021-09-29 Fujii Hironori [WinCairo] REGRESSION(r280726): registry keys enabling GPU process mode don't work Modified: trunk/Source/WebKit/WebProcess/com.apple.WebProcess.sb.in (283288 => 283289) --- trunk/Source/WebKit/WebProcess/com.apple.WebProcess.sb.in 2021-09-30 00:47:41 UTC (rev 283288) +++ trunk/Source/WebKit/WebProcess/com.apple.WebProcess.sb.in 2021-09-30 00:55:27 UTC (rev 283289) @@ -1736,8 +1736,15 @@ ) ) +#if __MAC_OS_X_VERSION_MIN_REQUIRED < 11 (allow mach-lookup (require-all +(require-not (extension "com.apple.webkit.extension.mach")) +(global-name "com.apple.audio.AudioComponentRegistrar"))) +#endif + +(allow mach-lookup +(require-all (extension "com.apple.webkit.extension.mach") (xpc-service-name ;;; FIXME(207716): The following should be removed when the GPU process is complete ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [283288] trunk
Title: [283288] trunk
Revision 283288
Author sbar...@apple.com
Date 2021-09-29 17:47:41 -0700 (Wed, 29 Sep 2021)
Log Message
We need to load the baseline JIT's constant pool register after OSR exit to checkpoints if we return to baseline code
https://bugs.webkit.org/show_bug.cgi?id=230972
Reviewed by Mark Lam and Yusuke Suzuki.
JSTests:
* stress/checkpoint-osr-exit-needs-to-reload-baseline-jit-constant-pool-gpr.js: Added.
(empty):
(empty2):
(test):
Source/_javascript_Core:
Consider the following:
- We have a CodeBlock A.
- DFG or FTL compiles an exit to A when A is still LLInt code. This means
the OSR exit code will materialize registers as if A is LLInt.
- We tier up A to Baseline JIT code.
- Now, we take the exit to A as if it's LLInt. But the checkpoint OSR exit
code will actually jump to the tiered up baseline code when it's done,
because it determines where to jump at runtime. Because of this, when
we return from the checkpoint code, and if we are jumping into baseline
code, we must always load the constant pool register.
- There's no need to load the metadata register because that register is
shared with LLInt code, and will already contain the right value.
* jit/JIT.cpp:
(JSC::JIT::privateCompileMainPass):
* llint/LLIntSlowPaths.cpp:
(JSC::LLInt::dispatchToNextInstructionDuringExit):
(JSC::LLInt::llint_slow_path_checkpoint_osr_exit_from_inlined_call):
(JSC::LLInt::llint_slow_path_checkpoint_osr_exit):
(JSC::LLInt::dispatchToNextInstruction): Deleted.
* llint/LowLevelInterpreter.asm:
* llint/LowLevelInterpreter64.asm:
Modified Paths
trunk/JSTests/ChangeLog
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/jit/JIT.cpp
trunk/Source/_javascript_Core/llint/LLIntSlowPaths.cpp
trunk/Source/_javascript_Core/llint/LowLevelInterpreter.asm
trunk/Source/_javascript_Core/llint/LowLevelInterpreter64.asm
Added Paths
trunk/JSTests/stress/checkpoint-osr-exit-needs-to-reload-baseline-jit-constant-pool-gpr.js
Diff
Modified: trunk/JSTests/ChangeLog (283287 => 283288)
--- trunk/JSTests/ChangeLog 2021-09-30 00:21:20 UTC (rev 283287)
+++ trunk/JSTests/ChangeLog 2021-09-30 00:47:41 UTC (rev 283288)
@@ -1,5 +1,18 @@
2021-09-29 Saam Barati
+We need to load the baseline JIT's constant pool register after OSR exit to checkpoints if we return to baseline code
+https://bugs.webkit.org/show_bug.cgi?id=230972
+
+
+Reviewed by Mark Lam and Yusuke Suzuki.
+
+* stress/checkpoint-osr-exit-needs-to-reload-baseline-jit-constant-pool-gpr.js: Added.
+(empty):
+(empty2):
+(test):
+
+2021-09-29 Saam Barati
+
Code inside strength reduction can incorrectly prove that we know what lastIndex is
https://bugs.webkit.org/show_bug.cgi?id=230802
Added: trunk/JSTests/stress/checkpoint-osr-exit-needs-to-reload-baseline-jit-constant-pool-gpr.js (0 => 283288)
--- trunk/JSTests/stress/checkpoint-osr-exit-needs-to-reload-baseline-jit-constant-pool-gpr.js (rev 0)
+++ trunk/JSTests/stress/checkpoint-osr-exit-needs-to-reload-baseline-jit-constant-pool-gpr.js 2021-09-30 00:47:41 UTC (rev 283288)
@@ -0,0 +1,15 @@
+function empty() {}
+function empty2() {}
+
+function test(arr) {
+empty.apply(undefined, arr);
+empty2();
+}
+
+for (let i = 0; i < 1; i++) {
+let arr = [];
+for (let j = 0; j < i+1; j++) {
+arr.push(undefined);
+}
+test(arr);
+}
Modified: trunk/Source/_javascript_Core/ChangeLog (283287 => 283288)
--- trunk/Source/_javascript_Core/ChangeLog 2021-09-30 00:21:20 UTC (rev 283287)
+++ trunk/Source/_javascript_Core/ChangeLog 2021-09-30 00:47:41 UTC (rev 283288)
@@ -1,3 +1,34 @@
+2021-09-29 Saam Barati
+
+We need to load the baseline JIT's constant pool register after OSR exit to checkpoints if we return to baseline code
+https://bugs.webkit.org/show_bug.cgi?id=230972
+
+
+Reviewed by Mark Lam and Yusuke Suzuki.
+
+Consider the following:
+- We have a CodeBlock A.
+- DFG or FTL compiles an exit to A when A is still LLInt code. This means
+ the OSR exit code will materialize registers as if A is LLInt.
+- We tier up A to Baseline JIT code.
+- Now, we take the exit to A as if it's LLInt. But the checkpoint OSR exit
+ code will actually jump to the tiered up baseline code when it's done,
+ because it determines where to jump at runtime. Because of this, when
+ we return from the checkpoint code, and if we are jumping into baseline
+ code, we must always load the constant pool register.
+- There's no need to load the metadata register because that register is
+ shared with LLInt code, and will already contain the right value.
+
+* jit/JIT.cpp:
+(JSC::JIT::privateCompileMainPass):
+* llint/LLIntSlowPaths.cpp:
+(JSC::LLInt::dispatchToNextInstructionDuringExit):
+
[webkit-changes] [283287] trunk/Source
Title: [283287] trunk/Source
Revision 283287
Author basuke.suz...@sony.com
Date 2021-09-29 17:21:20 -0700 (Wed, 29 Sep 2021)
Log Message
Suppress warnings for implicit copy assignment operator/copy constructor with clang 13
https://bugs.webkit.org/show_bug.cgi?id=230963
Reviewed by Mark Lam.
Source/_javascript_Core:
Added default copy constructor to suppress warning.
* bytecode/Operands.h:
Source/WebCore:
No new tests because there is no behavior change.
Added default copy constructor / copy assignment operator to suppress warning.
* platform/LayoutUnit.h:
* platform/LengthBox.h:
* platform/RectEdges.h:
* platform/graphics/FontSelectionAlgorithm.h:
* platform/graphics/ImagePaintingOptions.h:
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/bytecode/Operands.h
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/LayoutUnit.h
trunk/Source/WebCore/platform/LengthBox.h
trunk/Source/WebCore/platform/RectEdges.h
trunk/Source/WebCore/platform/graphics/FontSelectionAlgorithm.h
trunk/Source/WebCore/platform/graphics/ImagePaintingOptions.h
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (283286 => 283287)
--- trunk/Source/_javascript_Core/ChangeLog 2021-09-30 00:19:07 UTC (rev 283286)
+++ trunk/Source/_javascript_Core/ChangeLog 2021-09-30 00:21:20 UTC (rev 283287)
@@ -1,5 +1,16 @@
2021-09-29 Basuke Suzuki
+Suppress warnings for implicit copy assignment operator/copy constructor with clang 13
+https://bugs.webkit.org/show_bug.cgi?id=230963
+
+Reviewed by Mark Lam.
+
+Added default copy constructor to suppress warning.
+
+* bytecode/Operands.h:
+
+2021-09-29 Basuke Suzuki
+
[JSC] Add objectTypeCounts to JSGetMemoryUsageStatistics
https://bugs.webkit.org/show_bug.cgi?id=230957
Modified: trunk/Source/_javascript_Core/bytecode/Operands.h (283286 => 283287)
--- trunk/Source/_javascript_Core/bytecode/Operands.h 2021-09-30 00:19:07 UTC (rev 283286)
+++ trunk/Source/_javascript_Core/bytecode/Operands.h 2021-09-30 00:21:20 UTC (rev 283287)
@@ -68,6 +68,8 @@
}
static Operand tmp(uint32_t index) { return Operand(OperandKind::Tmp, index); }
+Operand& operator=(const Operand&) = default;
+
OperandKind kind() const { return m_kind; }
int value() const { return m_operand; }
VirtualRegister virtualRegister() const
Modified: trunk/Source/WebCore/ChangeLog (283286 => 283287)
--- trunk/Source/WebCore/ChangeLog 2021-09-30 00:19:07 UTC (rev 283286)
+++ trunk/Source/WebCore/ChangeLog 2021-09-30 00:21:20 UTC (rev 283287)
@@ -1,3 +1,20 @@
+2021-09-29 Basuke Suzuki
+
+Suppress warnings for implicit copy assignment operator/copy constructor with clang 13
+https://bugs.webkit.org/show_bug.cgi?id=230963
+
+Reviewed by Mark Lam.
+
+No new tests because there is no behavior change.
+
+Added default copy constructor / copy assignment operator to suppress warning.
+
+* platform/LayoutUnit.h:
+* platform/LengthBox.h:
+* platform/RectEdges.h:
+* platform/graphics/FontSelectionAlgorithm.h:
+* platform/graphics/ImagePaintingOptions.h:
+
2021-09-29 Kiet Ho
Implement the 'ic' unit from CSS Values 4
Modified: trunk/Source/WebCore/platform/LayoutUnit.h (283286 => 283287)
--- trunk/Source/WebCore/platform/LayoutUnit.h 2021-09-30 00:19:07 UTC (rev 283286)
+++ trunk/Source/WebCore/platform/LayoutUnit.h 2021-09-30 00:21:20 UTC (rev 283287)
@@ -65,6 +65,7 @@
class LayoutUnit {
public:
LayoutUnit() : m_value(0) { }
+LayoutUnit(const LayoutUnit&) = default;
LayoutUnit(int value) { setValue(value); }
LayoutUnit(unsigned short value) { setValue(value); }
LayoutUnit(unsigned value) { setValue(value); }
@@ -85,7 +86,7 @@
m_value = clampToInteger(value * kFixedPointDenominator);
}
-LayoutUnit& operator=(const LayoutUnit& other) = default;
+LayoutUnit& operator=(const LayoutUnit&) = default;
LayoutUnit& operator=(const float& other) { return *this = LayoutUnit(other); }
static LayoutUnit fromFloatCeil(float value)
Modified: trunk/Source/WebCore/platform/LengthBox.h (283286 => 283287)
--- trunk/Source/WebCore/platform/LengthBox.h 2021-09-30 00:19:07 UTC (rev 283286)
+++ trunk/Source/WebCore/platform/LengthBox.h 2021-09-30 00:21:20 UTC (rev 283287)
@@ -55,6 +55,7 @@
}
LengthBox(const LengthBox&) = default;
+LengthBox& operator=(const LengthBox&) = default;
bool isZero() const
{
Modified: trunk/Source/WebCore/platform/RectEdges.h (283286 => 283287)
--- trunk/Source/WebCore/platform/RectEdges.h 2021-09-30 00:19:07 UTC (rev 283286)
+++ trunk/Source/WebCore/platform/RectEdges.h 2021-09-30 00:21:20 UTC (rev 283287)
@@ -46,6 +46,7 @@
RectEdges() = default;
RectEdges(const RectEdges&) = default;
+RectEdges& operator=(const RectEdges&) = default;
template
RectEdges(U&& top, U&&
[webkit-changes] [283286] trunk/Source/JavaScriptCore
Title: [283286] trunk/Source/_javascript_Core Revision 283286 Author basuke.suz...@sony.com Date 2021-09-29 17:19:07 -0700 (Wed, 29 Sep 2021) Log Message [JSC] Add objectTypeCounts to JSGetMemoryUsageStatistics https://bugs.webkit.org/show_bug.cgi?id=230957 Reviewed by Yusuke Suzuki. * API/JSBase.cpp: Added objectTypeCounts property (JSGetMemoryUsageStatistics): * API/JSBasePrivate.h: Added description of objectTypeCounts property * jsc.cpp: Added memoryUsageStatistics() function Modified Paths trunk/Source/_javascript_Core/API/JSBase.cpp trunk/Source/_javascript_Core/API/JSBasePrivate.h trunk/Source/_javascript_Core/ChangeLog trunk/Source/_javascript_Core/jsc.cpp Diff Modified: trunk/Source/_javascript_Core/API/JSBase.cpp (283285 => 283286) --- trunk/Source/_javascript_Core/API/JSBase.cpp 2021-09-30 00:07:14 UTC (rev 283285) +++ trunk/Source/_javascript_Core/API/JSBase.cpp 2021-09-30 00:19:07 UTC (rev 283286) @@ -204,6 +204,11 @@ VM& vm = globalObject->vm(); JSLockHolder locker(vm); +auto typeCounts = vm.heap.objectTypeCounts(); +JSObject* objectTypeCounts = constructEmptyObject(globalObject); +for (auto& it : *typeCounts) +objectTypeCounts->putDirect(vm, Identifier::fromString(vm, it.key), jsNumber(it.value)); + JSObject* object = constructEmptyObject(globalObject); object->putDirect(vm, Identifier::fromString(vm, "heapSize"), jsNumber(vm.heap.size())); object->putDirect(vm, Identifier::fromString(vm, "heapCapacity"), jsNumber(vm.heap.capacity())); @@ -212,6 +217,7 @@ object->putDirect(vm, Identifier::fromString(vm, "protectedObjectCount"), jsNumber(vm.heap.protectedObjectCount())); object->putDirect(vm, Identifier::fromString(vm, "globalObjectCount"), jsNumber(vm.heap.globalObjectCount())); object->putDirect(vm, Identifier::fromString(vm, "protectedGlobalObjectCount"), jsNumber(vm.heap.protectedGlobalObjectCount())); +object->putDirect(vm, Identifier::fromString(vm, "objectTypeCounts"), objectTypeCounts); return toRef(object); } Modified: trunk/Source/_javascript_Core/API/JSBasePrivate.h (283285 => 283286) --- trunk/Source/_javascript_Core/API/JSBasePrivate.h 2021-09-30 00:07:14 UTC (rev 283285) +++ trunk/Source/_javascript_Core/API/JSBasePrivate.h 2021-09-30 00:19:07 UTC (rev 283286) @@ -71,6 +71,7 @@ protectedObjectCount: current count of protected GC objects globalObjectCount: current count of global GC objects protectedGlobalObjectCount: current count of protected global GC objects + objectTypeCounts: object with GC object types as keys and their current counts as values */ JS_EXPORT JSObjectRef JSGetMemoryUsageStatistics(JSContextRef ctx); Modified: trunk/Source/_javascript_Core/ChangeLog (283285 => 283286) --- trunk/Source/_javascript_Core/ChangeLog 2021-09-30 00:07:14 UTC (rev 283285) +++ trunk/Source/_javascript_Core/ChangeLog 2021-09-30 00:19:07 UTC (rev 283286) @@ -1,3 +1,15 @@ +2021-09-29 Basuke Suzuki + +[JSC] Add objectTypeCounts to JSGetMemoryUsageStatistics +https://bugs.webkit.org/show_bug.cgi?id=230957 + +Reviewed by Yusuke Suzuki. + +* API/JSBase.cpp: Added objectTypeCounts property +(JSGetMemoryUsageStatistics): +* API/JSBasePrivate.h: Added description of objectTypeCounts property +* jsc.cpp: Added memoryUsageStatistics() function + 2021-09-29 Yusuke Suzuki [JSC] Remove CodeBlock::m_llintExecuteCounter Modified: trunk/Source/_javascript_Core/jsc.cpp (283285 => 283286) --- trunk/Source/_javascript_Core/jsc.cpp 2021-09-30 00:07:14 UTC (rev 283285) +++ trunk/Source/_javascript_Core/jsc.cpp 2021-09-30 00:19:07 UTC (rev 283286) @@ -22,6 +22,7 @@ #include "config.h" +#include "APICast.h" #include "ArrayBuffer.h" #include "BigIntConstructor.h" #include "BytecodeCacheError.h" @@ -44,6 +45,7 @@ #include "JITSizeStatistics.h" #include "JSArray.h" #include "JSArrayBuffer.h" +#include "JSBasePrivate.h" #include "JSBigInt.h" #include "JSFinalizationRegistry.h" #include "JSFunction.h" @@ -285,6 +287,7 @@ static JSC_DECLARE_HOST_FUNCTION(functionFullGC); static JSC_DECLARE_HOST_FUNCTION(functionEdenGC); static JSC_DECLARE_HOST_FUNCTION(functionHeapSize); +static JSC_DECLARE_HOST_FUNCTION(functionMemoryUsageStatistics); static JSC_DECLARE_HOST_FUNCTION(functionCreateMemoryFootprint); static JSC_DECLARE_HOST_FUNCTION(functionResetMemoryPeak); static JSC_DECLARE_HOST_FUNCTION(functionAddressOf); @@ -529,6 +532,7 @@ addFunction(vm, "fullGC", functionFullGC, 0); addFunction(vm, "edenGC", functionEdenGC, 0); addFunction(vm, "gcHeapSize", functionHeapSize, 0); +addFunction(vm, "memoryUsageStatistics", functionMemoryUsageStatistics, 0); addFunction(vm, "MemoryFootprint", functionCreateMemoryFootprint, 0); addFunction(vm, "resetMemoryPeak", functionResetMemoryPeak, 0); addFunction(vm, "addressOf", functionAddressOf, 1); @@ -1461,6 +1465,12 @@
[webkit-changes] [283285] trunk/Source/bmalloc
Title: [283285] trunk/Source/bmalloc
Revision 283285
Author basuke.suz...@sony.com
Date 2021-09-29 17:07:14 -0700 (Wed, 29 Sep 2021)
Log Message
[bmalloc] ChunkHash is not used since r261667
https://bugs.webkit.org/show_bug.cgi?id=230762
Reviewed by Alex Christensen.
The structure is the leftover when ObjectTypeTable was introduced at r261667.
* bmalloc/Chunk.h:
Modified Paths
trunk/Source/bmalloc/ChangeLog
trunk/Source/bmalloc/bmalloc/Chunk.h
Diff
Modified: trunk/Source/bmalloc/ChangeLog (283284 => 283285)
--- trunk/Source/bmalloc/ChangeLog 2021-09-30 00:00:16 UTC (rev 283284)
+++ trunk/Source/bmalloc/ChangeLog 2021-09-30 00:07:14 UTC (rev 283285)
@@ -1,3 +1,14 @@
+2021-09-29 Basuke Suzuki
+
+[bmalloc] ChunkHash is not used since r261667
+https://bugs.webkit.org/show_bug.cgi?id=230762
+
+Reviewed by Alex Christensen.
+
+The structure is the leftover when ObjectTypeTable was introduced at r261667.
+
+* bmalloc/Chunk.h:
+
2021-09-29 Eric Hutchison
Unreviewed, reverting r282850.
Modified: trunk/Source/bmalloc/bmalloc/Chunk.h (283284 => 283285)
--- trunk/Source/bmalloc/bmalloc/Chunk.h 2021-09-30 00:00:16 UTC (rev 283284)
+++ trunk/Source/bmalloc/bmalloc/Chunk.h 2021-09-30 00:07:14 UTC (rev 283285)
@@ -66,14 +66,6 @@
std::array m_pages { };
};
-struct ChunkHash {
-static unsigned hash(Chunk* key)
-{
-return static_cast(
-reinterpret_cast(key) / chunkSize);
-}
-};
-
inline size_t Chunk::metadataSize(size_t pageSize)
{
// We align to at least the page size so we can service aligned allocations
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [283284] trunk/Source
Title: [283284] trunk/Source
Revision 283284
Author hironori.fu...@sony.com
Date 2021-09-29 17:00:16 -0700 (Wed, 29 Sep 2021)
Log Message
[WinCairo] REGRESSION(r280726): registry keys enabling GPU process mode don't work
https://bugs.webkit.org/show_bug.cgi?id=230871
Reviewed by Don Olmstead.
Source/WebKit:
r270175 (Bug 219294) added registry keys to enable GPU process
mode for WinCairo port. But after r280726 (Bug 228803) changed the
function signature, they didn't work.
* Shared/WebPreferencesDefaultValues.cpp:
* Shared/win/WebPreferencesDefaultValuesWin.cpp:
(WebKit::isFeatureFlagEnabled):
Source/WTF:
* wtf/PlatformHave.h: r270175 defined HAVE_SYSTEM_FEATURE_FLAGS
for Windows to use WebKit::isFeatureFlagEnabled. But, it is no
longer needed.
Modified Paths
trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/PlatformHave.h
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Shared/WebPreferencesDefaultValues.cpp
trunk/Source/WebKit/Shared/win/WebPreferencesDefaultValuesWin.cpp
Diff
Modified: trunk/Source/WTF/ChangeLog (283283 => 283284)
--- trunk/Source/WTF/ChangeLog 2021-09-29 23:56:07 UTC (rev 283283)
+++ trunk/Source/WTF/ChangeLog 2021-09-30 00:00:16 UTC (rev 283284)
@@ -1,3 +1,14 @@
+2021-09-29 Fujii Hironori
+
+[WinCairo] REGRESSION(r280726): registry keys enabling GPU process mode don't work
+https://bugs.webkit.org/show_bug.cgi?id=230871
+
+Reviewed by Don Olmstead.
+
+* wtf/PlatformHave.h: r270175 defined HAVE_SYSTEM_FEATURE_FLAGS
+for Windows to use WebKit::isFeatureFlagEnabled. But, it is no
+longer needed.
+
2021-09-29 Kiet Ho
Implement the 'ic' unit from CSS Values 4
Modified: trunk/Source/WTF/wtf/PlatformHave.h (283283 => 283284)
--- trunk/Source/WTF/wtf/PlatformHave.h 2021-09-29 23:56:07 UTC (rev 283283)
+++ trunk/Source/WTF/wtf/PlatformHave.h 2021-09-30 00:00:16 UTC (rev 283284)
@@ -669,8 +669,7 @@
#if (PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 11) \
|| (PLATFORM(IOS_FAMILY) && __IPHONE_OS_VERSION_MIN_REQUIRED >= 15) \
|| (PLATFORM(WATCHOS) && __WATCH_OS_VERSION_MIN_REQUIRED >= 7) \
-|| (PLATFORM(APPLETV) && __TV_OS_VERSION_MIN_REQUIRED >= 14) \
-|| PLATFORM(WIN)
+|| (PLATFORM(APPLETV) && __TV_OS_VERSION_MIN_REQUIRED >= 14)
#define HAVE_SYSTEM_FEATURE_FLAGS 1
#endif
Modified: trunk/Source/WebKit/ChangeLog (283283 => 283284)
--- trunk/Source/WebKit/ChangeLog 2021-09-29 23:56:07 UTC (rev 283283)
+++ trunk/Source/WebKit/ChangeLog 2021-09-30 00:00:16 UTC (rev 283284)
@@ -1,3 +1,18 @@
+2021-09-29 Fujii Hironori
+
+[WinCairo] REGRESSION(r280726): registry keys enabling GPU process mode don't work
+https://bugs.webkit.org/show_bug.cgi?id=230871
+
+Reviewed by Don Olmstead.
+
+r270175 (Bug 219294) added registry keys to enable GPU process
+mode for WinCairo port. But after r280726 (Bug 228803) changed the
+function signature, they didn't work.
+
+* Shared/WebPreferencesDefaultValues.cpp:
+* Shared/win/WebPreferencesDefaultValuesWin.cpp:
+(WebKit::isFeatureFlagEnabled):
+
2021-09-29 Chris Dumez
[ iOS Debug ] http/tests/xmlhttprequest/access-control-preflight-credential-sync.html is a flaky crash
Modified: trunk/Source/WebKit/Shared/WebPreferencesDefaultValues.cpp (283283 => 283284)
--- trunk/Source/WebKit/Shared/WebPreferencesDefaultValues.cpp 2021-09-29 23:56:07 UTC (rev 283283)
+++ trunk/Source/WebKit/Shared/WebPreferencesDefaultValues.cpp 2021-09-30 00:00:16 UTC (rev 283284)
@@ -41,7 +41,7 @@
namespace WebKit {
-#if !PLATFORM(COCOA)
+#if !PLATFORM(COCOA) && !PLATFORM(WIN)
bool isFeatureFlagEnabled(const char*, bool defaultValue)
{
return defaultValue;
Modified: trunk/Source/WebKit/Shared/win/WebPreferencesDefaultValuesWin.cpp (283283 => 283284)
--- trunk/Source/WebKit/Shared/win/WebPreferencesDefaultValuesWin.cpp 2021-09-29 23:56:07 UTC (rev 283283)
+++ trunk/Source/WebKit/Shared/win/WebPreferencesDefaultValuesWin.cpp 2021-09-30 00:00:16 UTC (rev 283284)
@@ -26,19 +26,18 @@
#include "config.h"
#include "WebPreferencesDefaultValues.h"
-#if HAVE(SYSTEM_FEATURE_FLAGS)
-
#include
#include
namespace WebKit {
-bool isFeatureFlagEnabled(const String& featureName)
+bool isFeatureFlagEnabled(const char* featureName, bool defaultValue)
{
+auto featureNameWide = String(featureName).wideCharacters();
DWORD data;
DWORD dataSize = sizeof data;
DWORD keyType;
-HRESULT hr = getRegistryValue(HKEY_CURRENT_USER, L"Software\\WebKit", featureName.wideCharacters().data(), &keyType, &data, &dataSize);
+HRESULT hr = getRegistryValue(HKEY_CURRENT_USER, L"Software\\WebKit", featureNameWide.data(), &keyType, &data, &dataSize);
if (hr != ERROR_SUCCESS)
return false;
if (keyType != REG_DWORD)
@@ -49,5 +48,3 @@
}
} // namespace WebKit
-
-#endif
___
webkit-changes
[webkit-changes] [283283] trunk
Title: [283283] trunk
Revision 283283
Author cdu...@apple.com
Date 2021-09-29 16:56:07 -0700 (Wed, 29 Sep 2021)
Log Message
[ iOS Debug ] http/tests/xmlhttprequest/access-control-preflight-credential-sync.html is a flaky crash
https://bugs.webkit.org/show_bug.cgi?id=228305
Reviewed by Alex Christensen.
Source/WebKit:
When a NetworkResourceLoader for a synchronous XHR gets aborted (e.g. because the connection to
the WebProcess was severed), NetworkResourceLoader::abort() would fail to call
sendReplyToSynchronousRequest() (sendReplyToSynchronousRequest was only called in didFailLoading() and
didFinishLoading()). As a result, we would hit the following assertion in the NetworkResourceLoader
destructor later on: ASSERT(!isSynchronous() || !m_synchronousLoadData->delayedReply)
No new tests, covered by existing test that I am unskipping.
* NetworkProcess/NetworkResourceLoader.cpp:
(WebKit::NetworkResourceLoader::abort):
LayoutTests:
Unskip test that should no longer be flaky.
* platform/ios-wk2/TestExpectations:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/ios-wk2/TestExpectations
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/NetworkProcess/NetworkResourceLoader.cpp
Diff
Modified: trunk/LayoutTests/ChangeLog (283282 => 283283)
--- trunk/LayoutTests/ChangeLog 2021-09-29 23:53:31 UTC (rev 283282)
+++ trunk/LayoutTests/ChangeLog 2021-09-29 23:56:07 UTC (rev 283283)
@@ -1,3 +1,15 @@
+2021-09-29 Chris Dumez
+
+[ iOS Debug ] http/tests/xmlhttprequest/access-control-preflight-credential-sync.html is a flaky crash
+https://bugs.webkit.org/show_bug.cgi?id=228305
+
+
+Reviewed by Alex Christensen.
+
+Unskip test that should no longer be flaky.
+
+* platform/ios-wk2/TestExpectations:
+
2021-09-29 Kiet Ho
Implement the 'ic' unit from CSS Values 4
Modified: trunk/LayoutTests/platform/ios-wk2/TestExpectations (283282 => 283283)
--- trunk/LayoutTests/platform/ios-wk2/TestExpectations 2021-09-29 23:53:31 UTC (rev 283282)
+++ trunk/LayoutTests/platform/ios-wk2/TestExpectations 2021-09-29 23:56:07 UTC (rev 283283)
@@ -1908,8 +1908,6 @@
webkit.org/b/215350 http/tests/xmlhttprequest/overridemimetype-headers-received-state-force-shiftjis.html [ Pass Timeout ]
-webkit.org/b/228305 [ Debug ] http/tests/xmlhttprequest/access-control-preflight-credential-sync.html [ Pass Crash ]
-
webkit.org/b/215351 http/wpt/service-workers/module-meta-url-fragment.https.html [ Pass Failure ]
webkit.org/b/228670 http/wpt/service-workers/navigation-redirect-main-frame.https.html [ Pass Timeout ]
Modified: trunk/Source/WebKit/ChangeLog (283282 => 283283)
--- trunk/Source/WebKit/ChangeLog 2021-09-29 23:53:31 UTC (rev 283282)
+++ trunk/Source/WebKit/ChangeLog 2021-09-29 23:56:07 UTC (rev 283283)
@@ -1,3 +1,22 @@
+2021-09-29 Chris Dumez
+
+[ iOS Debug ] http/tests/xmlhttprequest/access-control-preflight-credential-sync.html is a flaky crash
+https://bugs.webkit.org/show_bug.cgi?id=228305
+
+
+Reviewed by Alex Christensen.
+
+When a NetworkResourceLoader for a synchronous XHR gets aborted (e.g. because the connection to
+the WebProcess was severed), NetworkResourceLoader::abort() would fail to call
+sendReplyToSynchronousRequest() (sendReplyToSynchronousRequest was only called in didFailLoading() and
+didFinishLoading()). As a result, we would hit the following assertion in the NetworkResourceLoader
+destructor later on: ASSERT(!isSynchronous() || !m_synchronousLoadData->delayedReply)
+
+No new tests, covered by existing test that I am unskipping.
+
+* NetworkProcess/NetworkResourceLoader.cpp:
+(WebKit::NetworkResourceLoader::abort):
+
2021-09-29 Sihui Liu
Add a default return value in convertToExceptionCode
Modified: trunk/Source/WebKit/NetworkProcess/NetworkResourceLoader.cpp (283282 => 283283)
--- trunk/Source/WebKit/NetworkProcess/NetworkResourceLoader.cpp 2021-09-29 23:53:31 UTC (rev 283282)
+++ trunk/Source/WebKit/NetworkProcess/NetworkResourceLoader.cpp 2021-09-29 23:56:07 UTC (rev 283283)
@@ -523,6 +523,11 @@
m_networkLoad->cancel();
}
+if (isSynchronous()) {
+m_synchronousLoadData->error = ResourceError { ResourceError::Type::Cancellation };
+sendReplyToSynchronousRequest(*m_synchronousLoadData, nullptr, { });
+}
+
cleanup(LoadResult::Cancel);
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [283282] trunk/Tools
Title: [283282] trunk/Tools
Revision 283282
Author basuke.suz...@sony.com
Date 2021-09-29 16:53:31 -0700 (Wed, 29 Sep 2021)
Log Message
[webkitpy] LOG_CHANNEL is widely used in the codebase and shouldn't be treated as error
https://bugs.webkit.org/show_bug.cgi?id=230995
Reviewed by Jonathan Bedard.
LOG_CHANNEL is the macro which is defined in each framework to define list of all channels
in the framework.
* Scripts/webkitpy/style/checkers/cpp.py:
(check_identifier_name_in_declaration):
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/style/checkers/cpp.py
Diff
Modified: trunk/Tools/ChangeLog (283281 => 283282)
--- trunk/Tools/ChangeLog 2021-09-29 23:36:22 UTC (rev 283281)
+++ trunk/Tools/ChangeLog 2021-09-29 23:53:31 UTC (rev 283282)
@@ -1,3 +1,16 @@
+2021-09-29 Basuke Suzuki
+
+[webkitpy] LOG_CHANNEL is widely used in the codebase and shouldn't be treated as error
+https://bugs.webkit.org/show_bug.cgi?id=230995
+
+Reviewed by Jonathan Bedard.
+
+LOG_CHANNEL is the macro which is defined in each framework to define list of all channels
+in the framework.
+
+* Scripts/webkitpy/style/checkers/cpp.py:
+(check_identifier_name_in_declaration):
+
2021-09-29 Alex Christensen
Update PCM Daemon name
Modified: trunk/Tools/Scripts/webkitpy/style/checkers/cpp.py (283281 => 283282)
--- trunk/Tools/Scripts/webkitpy/style/checkers/cpp.py 2021-09-29 23:36:22 UTC (rev 283281)
+++ trunk/Tools/Scripts/webkitpy/style/checkers/cpp.py 2021-09-29 23:53:31 UTC (rev 283282)
@@ -4104,6 +4104,7 @@
and not modified_identifier == "const_iterator"
and not modified_identifier == "vm_throw"
and not modified_identifier == "DFG_OPERATION"
+and not modified_identifier == "LOG_CHANNEL"
and not modified_identifier.find('chrono_literals') >= 0):
error(line_number, 'readability/naming/underscores', 4, identifier + " is incorrectly named. Don't use underscores in your identifier names.")
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [283281] trunk/Tools
Title: [283281] trunk/Tools
Revision 283281
Author achristen...@apple.com
Date 2021-09-29 16:36:22 -0700 (Wed, 29 Sep 2021)
Log Message
Update PCM Daemon name
https://bugs.webkit.org/show_bug.cgi?id=230516
In r282883 I updated the daemon name but not in this one place.
I think this might cause TestWebKitAPI.EventAttribution.Daemon to stop timing out on one of the bots.
* TestWebKitAPI/Tests/WebKitCocoa/EventAttribution.mm:
(TestWebKitAPI::TEST):
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/EventAttribution.mm
Diff
Modified: trunk/Tools/ChangeLog (283280 => 283281)
--- trunk/Tools/ChangeLog 2021-09-29 23:31:55 UTC (rev 283280)
+++ trunk/Tools/ChangeLog 2021-09-29 23:36:22 UTC (rev 283281)
@@ -1,3 +1,14 @@
+2021-09-29 Alex Christensen
+
+Update PCM Daemon name
+https://bugs.webkit.org/show_bug.cgi?id=230516
+
+In r282883 I updated the daemon name but not in this one place.
+I think this might cause TestWebKitAPI.EventAttribution.Daemon to stop timing out on one of the bots.
+
+* TestWebKitAPI/Tests/WebKitCocoa/EventAttribution.mm:
+(TestWebKitAPI::TEST):
+
2021-09-29 BJ Burg
[Cocoa] add _WKInspectorExtension SPI to evaluate script on an extension tab
Modified: trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/EventAttribution.mm (283280 => 283281)
--- trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/EventAttribution.mm 2021-09-29 23:31:55 UTC (rev 283280)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/EventAttribution.mm 2021-09-29 23:36:22 UTC (rev 283281)
@@ -475,7 +475,7 @@
[webView _addEventAttributionWithSourceID:42 destinationURL:exampleURL() sourceDescription:@"test source description" purchaser:@"test purchaser" reportEndpoint:server.request().URL optionalNonce:nil applicationBundleID:@"test.bundle.id"];
});
-system("killall TestPCMDaemon -9");
+system("killall AdAttributionDaemon -9");
#if HAVE(OS_LAUNCHD_JOB)
// LaunchOnlyOnce takes care of cleanup with launchd.
#else
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [283280] trunk/Source/WebKit
Title: [283280] trunk/Source/WebKit Revision 283280 Author sihui_...@apple.com Date 2021-09-29 16:31:55 -0700 (Wed, 29 Sep 2021) Log Message Add a default return value in convertToExceptionCode https://bugs.webkit.org/show_bug.cgi?id=230989 Reviewed by Chris Dumez. To fix non-Cocoa build. * NetworkProcess/storage/FileSystemStorageError.h: (WebKit::convertToExceptionCode): Modified Paths trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/NetworkProcess/storage/FileSystemStorageError.h Diff Modified: trunk/Source/WebKit/ChangeLog (283279 => 283280) --- trunk/Source/WebKit/ChangeLog 2021-09-29 23:31:34 UTC (rev 283279) +++ trunk/Source/WebKit/ChangeLog 2021-09-29 23:31:55 UTC (rev 283280) @@ -1,3 +1,15 @@ +2021-09-29 Sihui Liu + +Add a default return value in convertToExceptionCode +https://bugs.webkit.org/show_bug.cgi?id=230989 + +Reviewed by Chris Dumez. + +To fix non-Cocoa build. + +* NetworkProcess/storage/FileSystemStorageError.h: +(WebKit::convertToExceptionCode): + 2021-09-29 BJ Burg [Cocoa] add _WKInspectorExtension SPI to evaluate script on an extension tab Modified: trunk/Source/WebKit/NetworkProcess/storage/FileSystemStorageError.h (283279 => 283280) --- trunk/Source/WebKit/NetworkProcess/storage/FileSystemStorageError.h 2021-09-29 23:31:34 UTC (rev 283279) +++ trunk/Source/WebKit/NetworkProcess/storage/FileSystemStorageError.h 2021-09-29 23:31:55 UTC (rev 283280) @@ -50,8 +50,10 @@ case FileSystemStorageError::InvalidName: return WebCore::ExceptionCode::UnknownError; case FileSystemStorageError::Unknown: -return WebCore::ExceptionCode::UnknownError; +break; } + +return WebCore::ExceptionCode::UnknownError; } } // namespace WebKit ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [283279] trunk
Title: [283279] trunk
Revision 283279
Author commit-qu...@webkit.org
Date 2021-09-29 16:31:34 -0700 (Wed, 29 Sep 2021)
Log Message
Implement the 'ic' unit from CSS Values 4
https://bugs.webkit.org/show_bug.cgi?id=204276
Patch by Kiet Ho on 2021-09-29
Reviewed by Myles C. Maxfield.
LayoutTests/imported/w3c:
Fix ic-unit-{001..012} tests and references to use the IcTestFullWidth font,
which includes the CJK water glyph as a full width character. This avoids an
issue on macOS Catalina where the chosen fallback font renders the glyph
outside of the em box.
Fix ic-unit-{001..004} references to not use the ic unit.
Add two new tests where the CJK water glyph is half-width (ic-unit-013) and zero-width
(ic-unit-014).
* web-platform-tests/css/css-values/ic-unit-001-expected.html:
* web-platform-tests/css/css-values/ic-unit-001.html:
* web-platform-tests/css/css-values/ic-unit-002-expected.html:
* web-platform-tests/css/css-values/ic-unit-002.html:
* web-platform-tests/css/css-values/ic-unit-003-expected.html:
* web-platform-tests/css/css-values/ic-unit-003.html:
* web-platform-tests/css/css-values/ic-unit-004-expected.html:
* web-platform-tests/css/css-values/ic-unit-004.html:
* web-platform-tests/css/css-values/ic-unit-008-expected.html:
* web-platform-tests/css/css-values/ic-unit-008.html:
* web-platform-tests/css/css-values/ic-unit-009-expected.html:
* web-platform-tests/css/css-values/ic-unit-009.html:
* web-platform-tests/css/css-values/ic-unit-010-expected.html:
* web-platform-tests/css/css-values/ic-unit-010.html:
* web-platform-tests/css/css-values/ic-unit-011-expected.html:
* web-platform-tests/css/css-values/ic-unit-011.html:
* web-platform-tests/css/css-values/ic-unit-012-expected.html:
* web-platform-tests/css/css-values/ic-unit-012.html:
* web-platform-tests/css/css-values/ic-unit-013-expected.html: Added.
* web-platform-tests/css/css-values/ic-unit-013.html: Added.
* web-platform-tests/css/css-values/ic-unit-014-expected.html: Added.
* web-platform-tests/css/css-values/ic-unit-014.html: Added.
* web-platform-tests/css/css-values/resources/IcTestFullWidth.woff2: Added.
* web-platform-tests/css/css-values/resources/IcTestHalfWidth.woff2: Added.
* web-platform-tests/css/css-values/resources/IcTestZeroWidth.woff2: Added.
Source/WebCore:
Tests: fast/css/CSSPrimitiveValue-ic.html
imported/w3c/web-platform-tests/css/css-values/ic-unit-013.html
imported/w3c/web-platform-tests/css/css-values/ic-unit-014.html
* css/CSSPrimitiveValue.cpp:
(WebCore::isValidCSSUnitTypeForDoubleConversion):
(WebCore::isStringType):
(WebCore::CSSPrimitiveValue::cleanup):
(WebCore::CSSPrimitiveValue::computeUnzoomedNonCalcLengthDouble):
(WebCore::CSSPrimitiveValue::computeNonCalcLengthDouble):
(WebCore::CSSPrimitiveValue::unitTypeString):
(WebCore::CSSPrimitiveValue::formatNumberForCustomCSSText const):
(WebCore::CSSPrimitiveValue::equals const):
(WebCore::CSSPrimitiveValue::collectDirectComputationalDependencies const):
* css/CSSPrimitiveValue.h:
(WebCore::CSSPrimitiveValue::isFontRelativeLength):
(WebCore::CSSPrimitiveValue::isLength):
* css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::convertingToLengthRequiresNonNullStyle const):
* css/CSSUnits.cpp:
(WebCore::unitCategory):
(WebCore::operator<<):
* css/CSSUnits.h:
* css/DeprecatedCSSOMPrimitiveValue.cpp:
(WebCore::DeprecatedCSSOMPrimitiveValue::primitiveType const):
* css/calc/CSSCalcCategoryMapping.cpp:
(WebCore::calcUnitCategory):
(WebCore::calculationCategoryForCombination):
(WebCore::hasDoubleValue):
* css/parser/CSSParserToken.cpp:
(WebCore::cssPrimitiveValueUnitFromTrie):
* css/parser/CSSPropertyParserHelpers.cpp:
(WebCore::CSSPropertyParserHelpers::consumeLengthRawWithKnownTokenTypeDimension):
* css/parser/SizesAttributeParser.cpp:
(WebCore::SizesAttributeParser::computeLength):
* platform/graphics/Font.cpp:
(WebCore::Font::platformGlyphInit): simplyfy logic, reorder misplaced comment.
* platform/graphics/Font.h: remove property `m_zeroGlyph` only used once in
WebCore::Font::platformGlyphInit. Remove unused getters adjustedSpaceWidth(),
setSpaceWidths(), setSpaceGlyph(), setZeroWidthSpaceGlyph(), zeroGlyph(), setZeroGlyph().
(WebCore::Font::spaceWidth const):
(WebCore::Font::spaceGlyph const):
(WebCore::Font::zeroWidthSpaceGlyph const):
(WebCore::Font::isZeroWidthSpaceGlyph const):
* platform/graphics/FontMetrics.h:
(WebCore::FontMetrics::ideogramWidth const): add metric containing the width of an ideogram
glyph in the font. This width is approximated from the width of the CJK water glyph (U+6C34).
(WebCore::FontMetrics::setIdeogramWidth):
(WebCore::FontMetrics::reset):
Source/WTF:
* wtf/unicode/CharacterNames.h: add CJK water glyph (U+6C34) constant.
LayoutTests:
Added tests for behavior of CSSPrimitiveValue on ic unit.
* TestExpectations: remove ImageOnlyFailure expectations for ic-unit-* tests, now that they should pass.
* fast/css/CSSPrimitiveValue-ic-expected.txt: Added.
* fast/css/CSSPrimitiveValue-ic.html: Added.
[webkit-changes] [283278] tags/Safari-612.2.9.0.1/
Title: [283278] tags/Safari-612.2.9.0.1/ Revision 283278 Author alanc...@apple.com Date 2021-09-29 16:30:49 -0700 (Wed, 29 Sep 2021) Log Message Tag Safari-612.2.9.0.1. Added Paths tags/Safari-612.2.9.0.1/ Diff ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [283277] tags/Safari-612.2.9.1.1/
Title: [283277] tags/Safari-612.2.9.1.1/ Revision 283277 Author alanc...@apple.com Date 2021-09-29 16:30:10 -0700 (Wed, 29 Sep 2021) Log Message Tag Safari-612.2.9.1.1. Added Paths tags/Safari-612.2.9.1.1/ Diff ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [283276] trunk
Title: [283276] trunk Revision 283276 Author bb...@apple.com Date 2021-09-29 16:28:22 -0700 (Wed, 29 Sep 2021) Log Message [Cocoa] add _WKInspectorExtension SPI to evaluate script on an extension tab https://bugs.webkit.org/show_bug.cgi?id=230646 Reviewed by Devin Rousso. Source/WebCore: Exercised by new API test: WKInspectorExtension.CanEvaluateScriptInExtensionTab * inspector/InspectorFrontendHost.h: * inspector/InspectorFrontendHost.idl: * inspector/InspectorFrontendHost.cpp: (WebCore::InspectorFrontendHost::evaluateScriptInExtensionTab): Find the global object that corresponds to the passed-in and try to evaluate scriptSource in the mainThreadNormalWorld() of that . * html/HTMLIFrameElement.idl: Add [JSGenerateToNativeObject] so that it's possible to pass HTMLIFrameElement to the IDL function and convert it to the native object (HTMLIFrameElement&) from a JSValue. Source/WebInspectorUI: Add a new InspectorFrontendAPI method to evaluate script on an iframe within Web Inspector. This in turn calls out to InspectorFrontendHost to do the actual evaluation. Otherwise, the CSP policy set by the tab content may block any such evaluation if the 'script-src' directive does not include 'unsafe-eval'. * UserInterface/Protocol/InspectorFrontendAPI.js: (InspectorFrontendAPI.showExtensionTab): (InspectorFrontendAPI.evaluateScriptInExtensionTab): Call through to the WebInspectorExtensionController method. * UserInterface/Controllers/WebInspectorExtensionController.js: (WI.WebInspectorExtensionController.prototype.evaluateScriptInExtensionTab): Added. Try to get the for a extensionTabID, and use InspectorFrontendHost to evaluate script in the context of the . Be sure to correctly wrap the result. * UserInterface/Views/WebInspectorExtensionTabContentView.js: (WI.WebInspectorExtensionTabContentView): (WI.WebInspectorExtensionTabContentView.prototype.get iframeElement): (WI.WebInspectorExtensionTabContentView.shouldSaveTab): (WI.WebInspectorExtensionTabContentView.prototype.initialLayout): Deleted. While writing the API test, I saw that the first evaluation frequently failed because the did not exist. Change this class so that the is created in the constructor. Add a getter for the element. (WI.WebInspectorExtensionTabContentView.prototype._extensionFrameDidLoad): (WI.WebInspectorExtensionTabContentView.prototype._maybeDispatchDidShowExtensionTab): While writing this patch, it became apparent that didShowExtensionTab() was being called prior to the iframe actually completing its initial load. Then, the test would try to evaluate script on about:blank instead of the actual tab content. To fix this, require that the be attached and have fired the `onload` event before we notify clients that it has been 'shown'. * UserInterface/Main.html: Adjust the default CSP policy to not mention img-src. This allows ports such as Cocoa to set their own img-src CSP directive. These changes are necessary to allow images to load from custom URL schemes. * UserInterface/Views/TabBrowser.js: (WI.TabBrowser.prototype.bestTabContentViewForRepresentedObject): The new API test exposes a bug in this assertion, namely, that it does not account for the situation where a tab does not wish to be saved. In that case, the displayed WebInspectorExtensionTabContentView is *not* at index 0 of WI.TabBrowser.recentTabContentViews. This is correctly handled with a special case in WI.TabBrowser._tabBarItemSelected, so incorporate that logic into the assertion. Source/WebKit: Add new testing API for evaluating script expressions in the context of a tab created by _WKInspectorExtension. For the most part, this is implemented in the same way as the -evaluateScript: method, but the script is evaluated within the Web Inspector frontend itself rather than in the inspected page. To avoid CSP issues, the actual evaluation is performed on subframes using a new InspectorFrontendHost method which takes an and script source. Along the way, tweak Web Inspector's CSP policy to allow loading images from custom URL schemes as specified using _WKInspectorConfiguration. This is so that tab icons from the test-resource: scheme can be loaded in the main frame of Web Inspector's WKWebView under testing situations. * SourcesCocoa.txt: * WebKit.xcodeproj/project.pbxproj: Add new files. * UIProcess/API/APIInspectorExtension.h: * UIProcess/API/APIInspectorExtension.cpp: (API::InspectorExtension::evaluateScriptInExtensionTab): Based on evaluateScript(). Call through to the shared extension controller. * UIProcess/API/Cocoa/_WKInspectorExtensionPrivateForTesting.h: Added. * UIProcess/API/Cocoa/_WKInspectorExtensionTesting.mm: Added. (-[_WKInspectorExtension _evaluateScript:inExtensionTabWithIdentifier:completionHandler:]): Added. Call through to the shared extension controller. * UIProcess/Inspector/WebInspectorUIExtensionControllerProxy.h: * UIProcess/Inspector/WebInspectorUIExtensionControllerProxy.cpp: (WebKit::WebInspectorUIExtensionController
[webkit-changes] [283275] trunk/Source/WebCore
Title: [283275] trunk/Source/WebCore
Revision 283275
Author za...@apple.com
Date 2021-09-29 16:27:35 -0700 (Wed, 29 Sep 2021)
Log Message
[LFC][IFC] Use the first-line style when measuring text content when applicable
https://bugs.webkit.org/show_bug.cgi?id=230925
Reviewed by Antti Koivisto.
Disable "simplified content measuring" when first-style is present.
* layout/formattingContexts/inline/InlineLineBuilder.cpp:
(WebCore::Layout::LineBuilder::inlineItemWidth const):
* layout/formattingContexts/inline/InlineTextItem.cpp:
(WebCore::Layout::InlineTextItem::createAndAppendTextItems):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.cpp
trunk/Source/WebCore/layout/formattingContexts/inline/InlineTextItem.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (283274 => 283275)
--- trunk/Source/WebCore/ChangeLog 2021-09-29 23:08:05 UTC (rev 283274)
+++ trunk/Source/WebCore/ChangeLog 2021-09-29 23:27:35 UTC (rev 283275)
@@ -1,3 +1,17 @@
+2021-09-29 Alan Bujtas
+
+[LFC][IFC] Use the first-line style when measuring text content when applicable
+https://bugs.webkit.org/show_bug.cgi?id=230925
+
+Reviewed by Antti Koivisto.
+
+Disable "simplified content measuring" when first-style is present.
+
+* layout/formattingContexts/inline/InlineLineBuilder.cpp:
+(WebCore::Layout::LineBuilder::inlineItemWidth const):
+* layout/formattingContexts/inline/InlineTextItem.cpp:
+(WebCore::Layout::InlineTextItem::createAndAppendTextItems):
+
2021-09-29 Chris Dumez
Use isolated NSURLSessions for each first party registrable domain
Modified: trunk/Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.cpp (283274 => 283275)
--- trunk/Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.cpp 2021-09-29 23:08:05 UTC (rev 283274)
+++ trunk/Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.cpp 2021-09-29 23:27:35 UTC (rev 283275)
@@ -217,9 +217,11 @@
{
if (is(inlineItem)) {
auto& inlineTextItem = downcast(inlineItem);
-auto& fontCascade = inlineTextItem.layoutBox().style().fontCascade();
-if (auto contentWidth = inlineTextItem.width())
+if (auto contentWidth = inlineTextItem.width()) {
+ASSERT(inlineTextItem.firstLineStyle() == inlineTextItem.style());
return *contentWidth;
+}
+auto& fontCascade = m_isFirstLine ? inlineTextItem.firstLineStyle().fontCascade() : inlineTextItem.style().fontCascade();
if (!inlineTextItem.isWhitespace() || InlineTextItem::shouldPreserveSpacesAndTabs(inlineTextItem))
return TextUtil::width(inlineTextItem, fontCascade, contentLogicalLeft);
return TextUtil::width(inlineTextItem, fontCascade, inlineTextItem.start(), inlineTextItem.start() + 1, contentLogicalLeft);
Modified: trunk/Source/WebCore/layout/formattingContexts/inline/InlineTextItem.cpp (283274 => 283275)
--- trunk/Source/WebCore/layout/formattingContexts/inline/InlineTextItem.cpp 2021-09-29 23:08:05 UTC (rev 283274)
+++ trunk/Source/WebCore/layout/formattingContexts/inline/InlineTextItem.cpp 2021-09-29 23:27:35 UTC (rev 283275)
@@ -88,6 +88,8 @@
auto inlineItemWidth = [&](auto startPosition, auto length) -> std::optional {
if (!inlineTextBox.canUseSimplifiedContentMeasuring())
return { };
+if (inlineTextBox.style() != inlineTextBox.firstLineStyle())
+return { };
return TextUtil::width(inlineTextBox, fontCascade, startPosition, startPosition + length, { });
};
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [283274] trunk
Title: [283274] trunk Revision 283274 Author cdu...@apple.com Date 2021-09-29 16:08:05 -0700 (Wed, 29 Sep 2021) Log Message Use isolated NSURLSessions for each first party registrable domain https://bugs.webkit.org/show_bug.cgi?id=230750 Reviewed by Alex Christensen. LayoutTests/imported/w3c: Rebaseline WPT test that is now passing more checks. * web-platform-tests/fetch/connection-pool/network-partition-key-expected.txt: Source/WebCore: Fix bug where service worker soft-update requests would have their "first-party-for-cookies" field set to "https:" instead of a full origin (e.g. "https://localhost:8080"). This was causing some service worker test failures now that we use different NSURLSession based on the "first-party-for-cookies" field. * workers/service/server/SWServer.cpp: (WebCore::originURL): Source/WebKit: Previously would use up to 10 isolated NSURLSessions only for domains marked as prevalent by ITP *and* that the user interacts with as first party website. We now use different isolated NSURLSession for each top-level registrable domain, not matter their ITP status. This significantly improves privacy. To avoid having too many NSURLSession, we clear the ones that haven't been used in the last 10 minutes, every time we add a new one. * NetworkProcess/cocoa/NetworkSessionCocoa.h: * NetworkProcess/cocoa/NetworkSessionCocoa.mm: (WebKit::NetworkSessionCocoa::sessionWrapperForTask): (WebKit::SessionSet::isolatedSession): LayoutTests: This test is now passing more checks on WebKit2 but still completely fails on WebKit1 so I am adding a WK1-specific baseline. * platform/mac-wk1/imported/w3c/web-platform-tests/fetch/connection-pool/network-partition-key-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/fetch/connection-pool/network-partition-key-expected.txt. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/imported/w3c/ChangeLog trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/connection-pool/network-partition-key-expected.txt trunk/LayoutTests/platform/gtk/TestExpectations trunk/LayoutTests/platform/wpe/TestExpectations trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/workers/service/server/SWServer.cpp trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.h trunk/Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm Added Paths trunk/LayoutTests/http/tests/resourceLoadStatistics/switch-session-on-navigation-to-prevalent-without-interaction-expected.txt trunk/LayoutTests/http/tests/resourceLoadStatistics/switch-session-on-navigation-to-prevalent-without-interaction.py trunk/LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/fetch/connection-pool/ trunk/LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/fetch/connection-pool/network-partition-key-expected.txt Removed Paths trunk/LayoutTests/http/tests/resourceLoadStatistics/do-not-switch-session-on-navigation-to-prevalent-without-interaction-expected.txt trunk/LayoutTests/http/tests/resourceLoadStatistics/do-not-switch-session-on-navigation-to-prevalent-without-interaction.py trunk/LayoutTests/http/tests/resourceLoadStatistics/switch-session-on-navigation-to-prevalent-with-interaction-expected.txt trunk/LayoutTests/http/tests/resourceLoadStatistics/switch-session-on-navigation-to-prevalent-with-interaction.py Diff Modified: trunk/LayoutTests/ChangeLog (283273 => 283274) --- trunk/LayoutTests/ChangeLog 2021-09-29 23:04:52 UTC (rev 283273) +++ trunk/LayoutTests/ChangeLog 2021-09-29 23:08:05 UTC (rev 283274) @@ -1,3 +1,16 @@ +2021-09-29 Chris Dumez + +Use isolated NSURLSessions for each first party registrable domain +https://bugs.webkit.org/show_bug.cgi?id=230750 + + +Reviewed by Alex Christensen. + +This test is now passing more checks on WebKit2 but still completely fails on WebKit1 so I am +adding a WK1-specific baseline. + +* platform/mac-wk1/imported/w3c/web-platform-tests/fetch/connection-pool/network-partition-key-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/fetch/connection-pool/network-partition-key-expected.txt. + 2021-09-29 Aditya Keerthi [css-ui] getComputedStyle() must return the specified value for '-webkit-appearance' Deleted: trunk/LayoutTests/http/tests/resourceLoadStatistics/do-not-switch-session-on-navigation-to-prevalent-without-interaction-expected.txt (283273 => 283274) --- trunk/LayoutTests/http/tests/resourceLoadStatistics/do-not-switch-session-on-navigation-to-prevalent-without-interaction-expected.txt 2021-09-29 23:04:52 UTC (rev 283273) +++ trunk/LayoutTests/http/tests/resourceLoadStatistics/do-not-switch-session-on-navigation-to-prevalent-without-interaction-expected.txt 2021-09-29 23:08:05 UTC (rev 283274) @@ -1,12 +0,0 @@ -Tests that the session is not switched upon top frame navigation to a prevalent resource without user interaction. - -On success, you will see a series of "PASS" mess
[webkit-changes] [283273] trunk/Source/WebCore
Title: [283273] trunk/Source/WebCore Revision 283273 Author drou...@apple.com Date 2021-09-29 16:04:52 -0700 (Wed, 29 Sep 2021) Log Message Allow `DrawGlyphsRecorder` to be used with any `GraphicsContext` instead of just `DisplayList::Recorder` https://bugs.webkit.org/show_bug.cgi?id=230913 Reviewed by Myles Maxfield. There's really nothing about `DrawGlyphsRecorder` that's specific to display lists other than it's currently only being used by `DisplayList::Recorder`. This patch replaces `DisplayList::Recorder` with `GraphicsContext` in `DrawGlyphsRecorder`. It also requires that new methods be added to `GraphicsContext` that are overridden by `DisplayList::Recorder`. This is being done to make `` drawing work in the GPUProcess (). * platform/graphics/DrawGlyphsRecorder.h: * platform/graphics/coretext/DrawGlyphsRecorderCoreText.cpp: (WebCore::DrawGlyphsRecorder::DrawGlyphsRecorder): (WebCore::DrawGlyphsRecorder::populateInternalState): (WebCore::DrawGlyphsRecorder::prepareInternalContext): (WebCore::DrawGlyphsRecorder::recordDrawGlyphs): (WebCore::DrawGlyphsRecorder::drawGlyphs): * platform/graphics/harfbuzz/DrawGlyphsRecorderHarfBuzz.cpp: (WebCore::DrawGlyphsRecorder::DrawGlyphsRecorder): (WebCore::DrawGlyphsRecorder::drawGlyphs): * platform/graphics/win/DrawGlyphsRecorderWin.cpp: (WebCore::DrawGlyphsRecorder::DrawGlyphsRecorder): (WebCore::DrawGlyphsRecorder::drawGlyphs): * platform/graphics/GraphicsContext.h: (WebCore::GraphicsContext::drawGlyphsAndCacheFont): Added. * platform/graphics/displaylists/DisplayListRecorder.h: * platform/graphics/displaylists/DisplayListRecorder.cpp: (WebCore::DisplayList::Recorder::state const): Added. (WebCore::DisplayList::Recorder::drawGlyphsAndCacheFont): Renamed from `appendDrawGlyphsItemWithCachedFont`. AFAICT it seems like the `m_state` in `GraphicsContext` has the same values (but is a different object) as the `currentState().stateChange.m_state` in `DisplayList::Recorder`. Many of the non-overriden methods on `GraphicsContext` (e.g. `setStrokeColor`) both modify the `m_state` and call `updateState`, which `DisplayList::Recorder` uses to modify its `currentState().stateChange.m_state`. As such, we should be able to expose it as an override for the `state` "getter" so that `DrawGlyphsRecorder` is able to access the current state in a `GraphicsContext`-subclass agnostic way. Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/platform/graphics/DrawGlyphsRecorder.h trunk/Source/WebCore/platform/graphics/GraphicsContext.h trunk/Source/WebCore/platform/graphics/coretext/DrawGlyphsRecorderCoreText.cpp trunk/Source/WebCore/platform/graphics/displaylists/DisplayListRecorder.cpp trunk/Source/WebCore/platform/graphics/displaylists/DisplayListRecorder.h trunk/Source/WebCore/platform/graphics/harfbuzz/DrawGlyphsRecorderHarfBuzz.cpp trunk/Source/WebCore/platform/graphics/win/DrawGlyphsRecorderWin.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (283272 => 283273) --- trunk/Source/WebCore/ChangeLog 2021-09-29 23:02:43 UTC (rev 283272) +++ trunk/Source/WebCore/ChangeLog 2021-09-29 23:04:52 UTC (rev 283273) @@ -1,3 +1,46 @@ +2021-09-29 Devin Rousso + +Allow `DrawGlyphsRecorder` to be used with any `GraphicsContext` instead of just `DisplayList::Recorder` +https://bugs.webkit.org/show_bug.cgi?id=230913 + +Reviewed by Myles Maxfield. + +There's really nothing about `DrawGlyphsRecorder` that's specific to display lists other +than it's currently only being used by `DisplayList::Recorder`. + +This patch replaces `DisplayList::Recorder` with `GraphicsContext` in `DrawGlyphsRecorder`. +It also requires that new methods be added to `GraphicsContext` that are overridden by +`DisplayList::Recorder`. This is being done to make `` drawing work in the +GPUProcess (). + +* platform/graphics/DrawGlyphsRecorder.h: +* platform/graphics/coretext/DrawGlyphsRecorderCoreText.cpp: +(WebCore::DrawGlyphsRecorder::DrawGlyphsRecorder): +(WebCore::DrawGlyphsRecorder::populateInternalState): +(WebCore::DrawGlyphsRecorder::prepareInternalContext): +(WebCore::DrawGlyphsRecorder::recordDrawGlyphs): +(WebCore::DrawGlyphsRecorder::drawGlyphs): +* platform/graphics/harfbuzz/DrawGlyphsRecorderHarfBuzz.cpp: +(WebCore::DrawGlyphsRecorder::DrawGlyphsRecorder): +(WebCore::DrawGlyphsRecorder::drawGlyphs): +* platform/graphics/win/DrawGlyphsRecorderWin.cpp: +(WebCore::DrawGlyphsRecorder::DrawGlyphsRecorder): +(WebCore::DrawGlyphsRecorder::drawGlyphs): + +* platform/graphics/GraphicsContext.h: +(WebCore::GraphicsContext::drawGlyphsAndCacheFont): Added. +* platform/graphics/displaylists/DisplayListRecorder.h: +* platform/graphics/displaylists/DisplayListRecorder.cpp: +(WebCore::DisplayList::Recorder::state const): Added. +(WebCore::DisplayList::Recorder::drawGly
[webkit-changes] [283272] trunk/Tools
Title: [283272] trunk/Tools
Revision 283272
Author commit-qu...@webkit.org
Date 2021-09-29 16:02:43 -0700 (Wed, 29 Sep 2021)
Log Message
Migrate _WKDownload tests from TCPServer to HTTPServer
https://bugs.webkit.org/show_bug.cgi?id=230980
Patch by Alex Christensen on 2021-09-29
Reviewed by Chris Dumez.
The former is very picky when it comes to numbers of TCP connections, and causes tests to time out when
the number of connections changes. The latter is more forgiving and runs code on the main thread.
* TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
(TestWebKitAPI::respondSlowly):
(TestWebKitAPI::downloadAtRate):
(TEST):
* TestWebKitAPI/cocoa/HTTPServer.mm:
(TestWebKitAPI::Connection::send const):
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/Download.mm
trunk/Tools/TestWebKitAPI/cocoa/HTTPServer.mm
Diff
Modified: trunk/Tools/ChangeLog (283271 => 283272)
--- trunk/Tools/ChangeLog 2021-09-29 22:45:23 UTC (rev 283271)
+++ trunk/Tools/ChangeLog 2021-09-29 23:02:43 UTC (rev 283272)
@@ -1,3 +1,21 @@
+2021-09-29 Alex Christensen
+
+Migrate _WKDownload tests from TCPServer to HTTPServer
+https://bugs.webkit.org/show_bug.cgi?id=230980
+
+
+Reviewed by Chris Dumez.
+
+The former is very picky when it comes to numbers of TCP connections, and causes tests to time out when
+the number of connections changes. The latter is more forgiving and runs code on the main thread.
+
+* TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
+(TestWebKitAPI::respondSlowly):
+(TestWebKitAPI::downloadAtRate):
+(TEST):
+* TestWebKitAPI/cocoa/HTTPServer.mm:
+(TestWebKitAPI::Connection::send const):
+
2021-09-29 Matt Lewis
Unreviewed built trigger fix.
Modified: trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/Download.mm (283271 => 283272)
--- trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/Download.mm 2021-09-29 22:45:23 UTC (rev 283271)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/Download.mm 2021-09-29 23:02:43 UTC (rev 283272)
@@ -26,11 +26,8 @@
#import "config.h"
#import
-#if PLATFORM(MAC) || PLATFORM(IOS)
-
#import "HTTPServer.h"
#import "PlatformUtilities.h"
-#import "TCPServer.h"
#import "Test.h"
#import "TestDownloadDelegate.h"
#import "TestLegacyDownloadDelegate.h"
@@ -858,31 +855,20 @@
namespace TestWebKitAPI {
-void respondSlowly(int socket, double kbps, bool& terminateServer)
+void respondSlowly(const Connection& connection, double kbps)
{
-EXPECT_FALSE(isMainThread());
-char readBuffer[1000];
-auto bytesRead = ::read(socket, readBuffer, sizeof(readBuffer));
-EXPECT_GT(bytesRead, 0);
-EXPECT_TRUE(static_cast(bytesRead) < sizeof(readBuffer));
-
-const char* responseHeader =
-"HTTP/1.1 200 OK\r\n"
-"Content-Disposition: attachment; filename=\"filename.dat\"\r\n"
-"Content-Length: 1\r\n\r\n";
-auto bytesWritten = ::write(socket, responseHeader, strlen(responseHeader));
-EXPECT_EQ(static_cast(bytesWritten), strlen(responseHeader));
-
+EXPECT_TRUE(isMainThread());
+
const double writesPerSecond = 100;
-Vector writeBuffer(static_cast(1024 * kbps / writesPerSecond));
-while (!terminateServer) {
-auto before = MonotonicTime::now();
-::write(socket, writeBuffer.data(), writeBuffer.size());
+Vector writeBuffer(static_cast(1024 * kbps / writesPerSecond));
+auto before = MonotonicTime::now();
+connection.send(WTFMove(writeBuffer), [=] {
double writeDuration = (MonotonicTime::now() - before).seconds();
double desiredSleep = 1.0 / writesPerSecond;
if (writeDuration < desiredSleep)
usleep(USEC_PER_SEC * (desiredSleep - writeDuration));
-}
+respondSlowly(connection, kbps);
+});
}
static RetainPtr monitorDelegate()
@@ -910,9 +896,16 @@
void downloadAtRate(double desiredKbps, unsigned speedMultiplier, AppReturnsToForeground returnToForeground = AppReturnsToForeground::No)
{
-bool terminateServer = false;
-TCPServer server([&](int socket) {
-respondSlowly(socket, desiredKbps, terminateServer);
+HTTPServer server([=](const Connection& connection) {
+connection.receiveHTTPRequest([=](Vector&&) {
+const char* responseHeader =
+"HTTP/1.1 200 OK\r\n"
+"Content-Disposition: attachment; filename=\"filename.dat\"\r\n"
+"Content-Length: 1\r\n\r\n";
+connection.send(responseHeader, [=] {
+respondSlowly(connection, desiredKbps);
+});
+});
});
auto webView = webViewWithDownloadMonitorSpeedMultiplier(speedMultiplier);
@@ -924,7 +917,6 @@
if (returnToForeground == AppReturnsToForeground::Yes)
[[webView configuration].websiteDataStore _synthesizeAppIsBackground:NO];
[monitorDelegate() waitForDidFail];
-terminateServer = true;
[[NSFileManager
[webkit-changes] [283271] trunk/Source
Title: [283271] trunk/Source Revision 283271 Author sihui_...@apple.com Date 2021-09-29 15:45:23 -0700 (Wed, 29 Sep 2021) Log Message Replace FileSystemHandleImpl with FileSystemStorageConnection https://bugs.webkit.org/show_bug.cgi?id=230861 Reviewed by Youenn Fablet. Source/WebCore: Introduce WorkerStorageConnection class, which dispatches StorageManager task to main-thread StorageConnection and dispatches result back to worker thread. Rebaselined existing test. * Headers.cmake: * Modules/filesystemaccess/FileSystemDirectoryHandle.cpp: (WebCore::FileSystemDirectoryHandle::create): (WebCore::FileSystemDirectoryHandle::FileSystemDirectoryHandle): (WebCore::FileSystemDirectoryHandle::getFileHandle): (WebCore::FileSystemDirectoryHandle::getDirectoryHandle): (WebCore::FileSystemDirectoryHandle::removeEntry): (WebCore::FileSystemDirectoryHandle::resolve): * Modules/filesystemaccess/FileSystemDirectoryHandle.h: * Modules/filesystemaccess/FileSystemFileHandle.cpp: (WebCore::FileSystemFileHandle::create): (WebCore::FileSystemFileHandle::FileSystemFileHandle): * Modules/filesystemaccess/FileSystemFileHandle.h: * Modules/filesystemaccess/FileSystemHandle.cpp: (WebCore::FileSystemHandle::FileSystemHandle): (WebCore::FileSystemHandle::isSameEntry const): * Modules/filesystemaccess/FileSystemHandle.h: (WebCore::FileSystemHandle::identifier const): (WebCore::FileSystemHandle::connection): (WebCore::FileSystemHandle::impl const): Deleted. * Modules/filesystemaccess/FileSystemHandleIdentifier.h: Renamed from Source/WebKit/NetworkProcess/storage/FileSystemStorageHandleIdentifier.h. * Modules/filesystemaccess/FileSystemStorageConnection.h: Renamed from Source/WebCore/Modules/filesystemaccess/FileSystemHandleImpl.h. (WebCore::FileSystemStorageConnection::~FileSystemStorageConnection): * Modules/storage/DummyStorageProvider.h: * Modules/storage/StorageConnection.h: * Modules/storage/StorageManager.cpp: (WebCore::StorageManager::fileSystemAccessGetDirectory): * Modules/storage/WorkerStorageConnection.cpp: * WebCore.xcodeproj/project.pbxproj: Source/WebKit: Replace FileSystemStorageHandleProxy with WebFileSystemStorageConnection. * NetworkProcess/storage/FileSystemStorageHandle.cpp: (WebKit::FileSystemStorageHandle::FileSystemStorageHandle): (WebKit::FileSystemStorageHandle::isSameEntry): (WebKit::FileSystemStorageHandle::requestCreateHandle): (WebKit::FileSystemStorageHandle::getFileHandle): (WebKit::FileSystemStorageHandle::getDirectoryHandle): (WebKit::FileSystemStorageHandle::resolve): * NetworkProcess/storage/FileSystemStorageHandle.h: (WebKit::FileSystemStorageHandle::identifier const): * NetworkProcess/storage/FileSystemStorageHandleRegistry.cpp: (WebKit::FileSystemStorageHandleRegistry::registerHandle): (WebKit::FileSystemStorageHandleRegistry::unregisterHandle): (WebKit::FileSystemStorageHandleRegistry::getHandle): * NetworkProcess/storage/FileSystemStorageHandleRegistry.h: * NetworkProcess/storage/FileSystemStorageManager.cpp: (WebKit::FileSystemStorageManager::createHandle): (WebKit::FileSystemStorageManager::getPath): (WebKit::FileSystemStorageManager::getDirectory): * NetworkProcess/storage/FileSystemStorageManager.h: * NetworkProcess/storage/NetworkStorageManager.cpp: (WebKit::NetworkStorageManager::fileSystemGetDirectory): (WebKit::NetworkStorageManager::isSameEntry): (WebKit::NetworkStorageManager::getFileHandle): (WebKit::NetworkStorageManager::getDirectoryHandle): (WebKit::NetworkStorageManager::removeEntry): (WebKit::NetworkStorageManager::resolve): * NetworkProcess/storage/NetworkStorageManager.h: * NetworkProcess/storage/NetworkStorageManager.messages.in: * NetworkProcess/storage/OriginStorageManager.h: * Scripts/webkit/messages.py: (types_that_cannot_be_forward_declared): * Sources.txt: * WebKit.xcodeproj/project.pbxproj: * WebProcess/WebCoreSupport/WebFileSystemStorageConnection.cpp: Renamed from Source/WebKit/WebProcess/WebCoreSupport/FileSystemStorageHandleProxy.cpp. (WebKit::WebFileSystemStorageConnection::create): (WebKit::WebFileSystemStorageConnection::WebFileSystemStorageConnection): (WebKit::WebFileSystemStorageConnection::connectionClosed): (WebKit::WebFileSystemStorageConnection::isSameEntry): (WebKit::WebFileSystemStorageConnection::getFileHandle): (WebKit::WebFileSystemStorageConnection::getDirectoryHandle): (WebKit::WebFileSystemStorageConnection::removeEntry): (WebKit::WebFileSystemStorageConnection::resolve): * WebProcess/WebCoreSupport/WebFileSystemStorageConnection.h: Renamed from Source/WebKit/WebProcess/WebCoreSupport/FileSystemStorageHandleProxy.h. * WebProcess/WebCoreSupport/WebStorageConnection.cpp: (WebKit::WebStorageConnection::persist): (WebKit::WebStorageConnection::fileSystemGetDirectory): * WebProcess/WebProcess.cpp: (WebKit::WebProcess::networkProcessConnectionClosed): (WebKit::WebProcess::fileSystemStorageConnection): * WebProcess/WebProcess.h: Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/Headers.cmake trunk/Source/WebCore/Modules/f
[webkit-changes] [283270] trunk/Tools
Title: [283270] trunk/Tools Revision 283270 Author ryanhad...@apple.com Date 2021-09-29 15:44:55 -0700 (Wed, 29 Sep 2021) Log Message Unreviewed built trigger fix. Patch by Matt Lewis on 2021-09-29 * CISupport/build-webkit-org/wkbuild.py: (_should_file_trigger_build): * CISupport/build-webkit-org/wkbuild_unittest.py: (ShouldBuildTest): (ShouldBuildTest.test_should_build): Modified Paths trunk/Tools/CISupport/build-webkit-org/wkbuild.py trunk/Tools/CISupport/build-webkit-org/wkbuild_unittest.py trunk/Tools/ChangeLog Diff Modified: trunk/Tools/CISupport/build-webkit-org/wkbuild.py (283269 => 283270) --- trunk/Tools/CISupport/build-webkit-org/wkbuild.py 2021-09-29 22:25:07 UTC (rev 283269) +++ trunk/Tools/CISupport/build-webkit-org/wkbuild.py 2021-09-29 22:44:55 UTC (rev 283270) @@ -46,12 +46,12 @@ "mac-catalina", "mac-bigsur", "win", -"ios-14", -"ios-simulator-14", -"tvos-14", -"tvos-simulator-14", -"watchos-7", -"watchos-simulator-7", +"ios-15", +"ios-simulator-15", +"tvos-15", +"tvos-simulator-15", +"watchos-8", +"watchos-simulator-8", )) directories = [ Modified: trunk/Tools/CISupport/build-webkit-org/wkbuild_unittest.py (283269 => 283270) --- trunk/Tools/CISupport/build-webkit-org/wkbuild_unittest.py 2021-09-29 22:25:07 UTC (rev 283269) +++ trunk/Tools/CISupport/build-webkit-org/wkbuild_unittest.py 2021-09-29 22:44:55 UTC (rev 283270) @@ -29,8 +29,8 @@ (["ChangeLog", "Source/WebCore/ChangeLog", "Source/WebKit/ChangeLog-2011-02-11"], []), (["Websites/bugs.webkit.org/foo", "Source/WebCore/bar"], ["*"]), (["Websites/bugs.webkit.org/foo"], []), -(["Source/_javascript_Core/_javascript_Core.xcodeproj/foo"], ["mac-yosemite", "mac-elcapitan", "mac-sierra", "mac-highsierra", "mac-mojave", "ios-14", "ios-simulator-14", "tvos-14", "tvos-simulator-14", "watchos-7", "watchos-simulator-7"]), -(["Source/_javascript_Core/Configurations/Base.xcconfig"], ["mac-yosemite", "mac-elcapitan", "mac-sierra", "mac-highsierra", "mac-mojave", "ios-14", "ios-simulator-14", "tvos-14", "tvos-simulator-14", "watchos-7", "watchos-simulator-7"]), +(["Source/_javascript_Core/_javascript_Core.xcodeproj/foo"], ["mac-yosemite", "mac-elcapitan", "mac-sierra", "mac-highsierra", "mac-mojave", "ios-15", "ios-simulator-15", "tvos-15", "tvos-simulator-15", "watchos-8", "watchos-simulator-8"]), +(["Source/_javascript_Core/Configurations/Base.xcconfig"], ["mac-yosemite", "mac-elcapitan", "mac-sierra", "mac-highsierra", "mac-mojave", "ios-15", "ios-simulator-15", "tvos-15", "tvos-simulator-15", "watchos-8", "watchos-simulator-8"]), (["Source/_javascript_Core/_javascript_Core.vcproj/foo", "Source/WebKit/win/WebKit2.vcproj", "Source/WebKitLegacy/win/WebKit.sln", "Tools/WebKitTestRunner/Configurations/WebKitTestRunnerCommon.vsprops"], ["win"]), (["LayoutTests/platform/mac/foo", "Source/WebCore/bar"], ["*"]), (["LayoutTests/foo"], ["*"]), @@ -41,10 +41,10 @@ (["LayoutTests/platform/mac-highsierra/foo"], ["mac-yosemite", "mac-elcapitan", "mac-sierra", "mac-highsierra"]), (["LayoutTests/platform/mac-mojave/foo"], ["mac-yosemite", "mac-elcapitan", "mac-sierra", "mac-highsierra", "mac-mojave"]), (["LayoutTests/platform/mac-catalina/foo"], ["mac-mojave", "mac-yosemite", "mac-elcapitan", "mac-sierra", "mac-highsierra", "mac-mojave"]), -(["LayoutTests/platform/ios-simulator/foo"], ["ios-14", "ios-simulator-14"]), -(["LayoutTests/platform/ios-simulator-wk1/foo"], ["ios-14", "ios-simulator-14"]), -(["LayoutTests/platform/ios-simulator-wk2/foo"], ["ios-14", "ios-simulator-14"]), -(["LayoutTests/platform/wk2/Skipped"], ["mac-yosemite", "mac-elcapitan", "mac-sierra", "mac-highsierra", "mac-mojave", "ios-14", "ios-simulator-14"]), +(["LayoutTests/platform/ios-simulator/foo"], ["ios-15", "ios-simulator-15"]), +(["LayoutTests/platform/ios-simulator-wk1/foo"], ["ios-15", "ios-simulator-15"]), +(["LayoutTests/platform/ios-simulator-wk2/foo"], ["ios-15", "ios-simulator-15"]), +(["LayoutTests/platform/wk2/Skipped"], ["mac-yosemite", "mac-elcapitan", "mac-sierra", "mac-highsierra", "mac-mojave", "ios-15", "ios-simulator-15"]), (["LayoutTests/platform/mac-wk2/Skipped"], ["mac-yosemite", "mac-elcapitan", "mac-sierra", "mac-highsierra", "mac-mojave"]), (["LayoutTests/platform/mac-wk1/compositing/tiling/transform-origin-tiled-expected.txt"], ["mac-yosemite", "mac-elcapitan", "mac-sierra", "mac-highsierra", "mac-mojave"]), (["LayoutTests/platform/mac/foo"], ["mac-yosemite", "mac-elcapitan", "mac-sierra", "mac-highsierra", "mac-mojave", "win"]), @@ -52,19 +52,19 @@ (["LayoutTests/platform/win-xp/foo"], ["win"]), (["LayoutTests/platform/win-wk1/foo"], ["win"]), (["LayoutTests/platform/win/foo"], ["
[webkit-changes] [283269] trunk
Title: [283269] trunk Revision 283269 Author akeer...@apple.com Date 2021-09-29 15:25:07 -0700 (Wed, 29 Sep 2021) Log Message [css-ui] getComputedStyle() must return the specified value for '-webkit-appearance' https://bugs.webkit.org/show_bug.cgi?id=230916 rdar://83640938 Reviewed by Simon Fraser. LayoutTests/imported/w3c: * web-platform-tests/css/css-ui/appearance-cssom-001-expected.txt: Rebaseline for progression. Source/WebCore: Currently, an element's appearance can be adjusted to "none" depending on the applied CSS properties. For example, buttons that specify a background-color lose their native appearance. The existing behavior is implemented by modifying the appearance field on RenderStyle. While the spec allows certain properties to affect appearance, it also asserts that the computed value must be equal to the specific value [1]. However, since the specified and adjusted values are stored in the same field in RenderStyle, the computed value does not always equal the specified value. To fix, introduce an effectiveAppearance field to RenderStyle, which stores the used appearance. The specified appearance remains in the appearance field, ensuring the computed value adheres to the spec. The new behavior matches Chrome and Firefox. This work is also necessary for WebKit to support 'auto' as a valid appearance value, since the used value will need to be adjusted depending on the element type, but the computed value should remain 'auto'. [1] https://www.w3.org/TR/css-ui-4/#appearance-switching * accessibility/AccessibilityObject.cpp: (WebCore::AccessibilityObject::boundingBoxForQuads): * accessibility/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::isApplePayButton const): * accessibility/AccessibilitySlider.cpp: (WebCore::AccessibilitySlider::orientation const): * dom/Element.cpp: (WebCore::Element::setActive): (WebCore::Element::setHovered): * editing/FrameSelection.cpp: (WebCore::FrameSelection::focusedOrActiveStateChanged): * html/HTMLFormControlElement.cpp: (WebCore::HTMLFormControlElement::disabledStateChanged): * html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::setChecked): (WebCore::HTMLInputElement::setIndeterminate): * html/HTMLMeterElement.cpp: (WebCore::HTMLMeterElement::createElementRenderer): * html/HTMLOptionElement.cpp: (WebCore::HTMLOptionElement::parseAttribute): * html/HTMLProgressElement.cpp: (WebCore::HTMLProgressElement::createElementRenderer): * html/RangeInputType.cpp: (WebCore::RangeInputType::handleKeydownEvent): * html/shadow/ProgressShadowElement.cpp: (WebCore::ProgressShadowElement::rendererIsNeeded): (WebCore::ProgressInnerElement::rendererIsNeeded): * html/shadow/SliderThumbElement.cpp: (WebCore::hasVerticalAppearance): (WebCore::RenderSliderThumb::updateAppearance): (WebCore::SliderThumbElement::resolveCustomStyle): (WebCore::SliderContainerElement::resolveCustomStyle): * html/shadow/TextControlInnerElements.cpp: (WebCore::SearchFieldResultsButtonElement::resolveCustomStyle): * rendering/RenderAttachment.cpp: (WebCore::RenderAttachment::shouldDrawBorder const): (WebCore::RenderAttachment::paintReplaced): * rendering/RenderBlock.cpp: (WebCore::RenderBlock::addVisualOverflowFromTheme): (WebCore::RenderBlock::baselinePosition const): * rendering/RenderBox.cpp: (WebCore::RenderBox::determineBackgroundBleedAvoidance const): (WebCore::RenderBox::paintBoxDecorations): (WebCore::RenderBox::backgroundIsKnownToBeOpaqueInRect const): * rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::hasVisibleBoxDecorationStyle const): (WebCore::RenderBoxModelObject::boxShadowShouldBeAppliedToBackground const): * rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::updateCustomAppearance): (WebCore::hasVisibleBoxDecorations): * rendering/RenderLayerScrollableArea.cpp: (WebCore::RenderLayerScrollableArea::updateScrollbarsAfterStyleChange): (WebCore::RenderLayerScrollableArea::updateScrollbarsAfterLayout): * rendering/RenderMenuList.cpp: (RenderMenuList::menuStyle const): (RenderMenuList::clientPaddingLeft const): (RenderMenuList::clientPaddingRight const): * rendering/RenderProgress.cpp: (WebCore::RenderProgress::updateAnimationState): * rendering/RenderTheme.cpp: (WebCore::RenderTheme::adjustStyle): Ensure the specified value is not modified by adjusting the effectiveAppearance field instead of the appearance field. (WebCore::RenderTheme::adjustSearchFieldDecorationStyle const): (WebCore::RenderTheme::paint): (WebCore::RenderTheme::paintBorderOnly): (WebCore::RenderTheme::paintDecorations): (WebCore::RenderTheme::baselinePosition const): (WebCore::RenderTheme::isControlStyled const): (WebCore::RenderTheme::adjustRepaintRect): (WebCore::RenderTheme::supportsFocusRing const): (WebCore::RenderTheme::isDefault const): (WebCore::RenderTheme::paintSliderTicks): * rendering/RenderThemeAdwaita.cpp: (WebCore::RenderThemeAdwaita::supportsFocusRing const): (WebCore::RenderThemeAdwaita::popupInternalPaddingBox const): (WebCore::Ren
[webkit-changes] [283268] trunk/LayoutTests
Title: [283268] trunk/LayoutTests Revision 283268 Author jen...@apple.com Date 2021-09-29 15:22:43 -0700 (Wed, 29 Sep 2021) Log Message [ Catalina+ Debug wk2 ] fast/speechrecognition/start-recognition-after-gum.html is a flaky timeout https://bugs.webkit.org/show_bug.cgi?id=228209 Unreviewed test gardening. * platform/mac-wk2/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/mac-wk2/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (283267 => 283268) --- trunk/LayoutTests/ChangeLog 2021-09-29 22:11:23 UTC (rev 283267) +++ trunk/LayoutTests/ChangeLog 2021-09-29 22:22:43 UTC (rev 283268) @@ -1,3 +1,12 @@ +2021-09-29 Robert Jenner + +[ Catalina+ Debug wk2 ] fast/speechrecognition/start-recognition-after-gum.html is a flaky timeout +https://bugs.webkit.org/show_bug.cgi?id=228209 + +Unreviewed test gardening. + +* platform/mac-wk2/TestExpectations: + 2021-09-29 Ayumi Kojima [ iOS Debug ] fast/selectors/ backtracking tests are timing out. Modified: trunk/LayoutTests/platform/mac-wk2/TestExpectations (283267 => 283268) --- trunk/LayoutTests/platform/mac-wk2/TestExpectations 2021-09-29 22:11:23 UTC (rev 283267) +++ trunk/LayoutTests/platform/mac-wk2/TestExpectations 2021-09-29 22:22:43 UTC (rev 283268) @@ -1653,7 +1653,7 @@ webkit.org/b/230027 [ BigSur Debug ] http/tests/media/media-document-referer.html [ Pass Failure ] -webkit.org/b/228209 fast/speechrecognition/start-recognition-after-gum.html [ Slow ] +webkit.org/b/228209 fast/speechrecognition/start-recognition-after-gum.html [ Pass Timeout ] webkit.org/b/230070 media/track/track-cue-css.html [ Pass ImageOnlyFailure ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [283267] trunk/LayoutTests
Title: [283267] trunk/LayoutTests Revision 283267 Author ayumi_koj...@apple.com Date 2021-09-29 15:11:23 -0700 (Wed, 29 Sep 2021) Log Message [ iOS Debug ] fast/selectors/ backtracking tests are timing out. https://bugs.webkit.org/show_bug.cgi?id=230988 Unreviewed test gardening. * platform/ios-14/TestExpectations: * platform/ios-wk2/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/ios-14/TestExpectations trunk/LayoutTests/platform/ios-wk2/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (283266 => 283267) --- trunk/LayoutTests/ChangeLog 2021-09-29 21:58:18 UTC (rev 283266) +++ trunk/LayoutTests/ChangeLog 2021-09-29 22:11:23 UTC (rev 283267) @@ -1,5 +1,15 @@ 2021-09-29 Ayumi Kojima +[ iOS Debug ] fast/selectors/ backtracking tests are timing out. +https://bugs.webkit.org/show_bug.cgi?id=230988 + +Unreviewed test gardening. + +* platform/ios-14/TestExpectations: +* platform/ios-wk2/TestExpectations: + +2021-09-29 Ayumi Kojima + [ iOS ] fast/events/ios/viewport-shrink-to-fit-allows-double-tap.html is flaky timing out. https://bugs.webkit.org/show_bug.cgi?id=230987 Modified: trunk/LayoutTests/platform/ios-14/TestExpectations (283266 => 283267) --- trunk/LayoutTests/platform/ios-14/TestExpectations 2021-09-29 21:58:18 UTC (rev 283266) +++ trunk/LayoutTests/platform/ios-14/TestExpectations 2021-09-29 22:11:23 UTC (rev 283267) @@ -109,8 +109,6 @@ fast/forms/ios/zoom-after-input-tap.html [ Pass Failure Timeout Crash ] fast/events/ios/key-events-comprehensive/key-events-control-option.html [ Pass Timeout ] [ Debug ] fast/events/ios/key-events-comprehensive/key-events-control-shift.html [ Pass Timeout ] -[ Debug ] fast/selectors/is-backtracking.html [ Pass Timeout ] -[ Debug ] fast/selectors/matches-backtracking.html [ Pass Timeout ] fast/forms/ios/dismiss-picker-using-keyboard.html [ Pass Timeout ] fast/forms/ios/drag-range-thumb.html [ Pass Timeout Crash Timeout ] Modified: trunk/LayoutTests/platform/ios-wk2/TestExpectations (283266 => 283267) --- trunk/LayoutTests/platform/ios-wk2/TestExpectations 2021-09-29 21:58:18 UTC (rev 283266) +++ trunk/LayoutTests/platform/ios-wk2/TestExpectations 2021-09-29 22:11:23 UTC (rev 283267) @@ -1877,6 +1877,9 @@ webkit.org/b/214598 fast/scrolling/ios/autoscroll-input-when-very-zoomed.html [ Pass Failure ] +webkit.org/b/230988 [ Debug ] fast/selectors/is-backtracking.html [ Timeout ] +webkit.org/b/230988 [ Debug ] fast/selectors/matches-backtracking.html [ Timeout ] + http/tests/in-app-browser-privacy/ [ Pass ] webkit.org/b/175193 fast/images/async-image-body-background-image.html [ Pass Timeout ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [283266] trunk/Tools
Title: [283266] trunk/Tools
Revision 283266
Author basuke.suz...@sony.com
Date 2021-09-29 14:58:18 -0700 (Wed, 29 Sep 2021)
Log Message
[PlayStation] Make build-webkit configurable using environment variable
https://bugs.webkit.org/show_bug.cgi?id=230958
Reviewed by Fujii Hironori.
The cmake toolchain file is hard coded in the script. Make it configurable using
environment variable.
* Scripts/webkitdirs.pm:
(generateBuildSystemFromCMakeProject):
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitdirs.pm
Diff
Modified: trunk/Tools/ChangeLog (283265 => 283266)
--- trunk/Tools/ChangeLog 2021-09-29 21:52:58 UTC (rev 283265)
+++ trunk/Tools/ChangeLog 2021-09-29 21:58:18 UTC (rev 283266)
@@ -1,3 +1,16 @@
+2021-09-29 Basuke Suzuki
+
+[PlayStation] Make build-webkit configurable using environment variable
+https://bugs.webkit.org/show_bug.cgi?id=230958
+
+Reviewed by Fujii Hironori.
+
+The cmake toolchain file is hard coded in the script. Make it configurable using
+environment variable.
+
+* Scripts/webkitdirs.pm:
+(generateBuildSystemFromCMakeProject):
+
2021-09-29 Youenn Fablet
WPT importer should create serviceworker template for templated test that have worker as global
Modified: trunk/Tools/Scripts/webkitdirs.pm (283265 => 283266)
--- trunk/Tools/Scripts/webkitdirs.pm 2021-09-29 21:52:58 UTC (rev 283265)
+++ trunk/Tools/Scripts/webkitdirs.pm 2021-09-29 21:58:18 UTC (rev 283266)
@@ -2511,7 +2511,10 @@
push @args, "-DLTO_MODE=$ltoMode" if ltoMode();
-push @args, '-DCMAKE_TOOLCHAIN_FILE=Platform/PlayStation' if isPlayStation();
+if (isPlayStation()) {
+my $toolChainFile = $ENV{'CMAKE_TOOLCHAIN_FILE'} || "Platform/PlayStation";
+push @args, '-DCMAKE_TOOLCHAIN_FILE=' . $toolChainFile;
+}
if ($willUseNinja) {
push @args, "-G";
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [283265] trunk/LayoutTests
Title: [283265] trunk/LayoutTests Revision 283265 Author ayumi_koj...@apple.com Date 2021-09-29 14:52:58 -0700 (Wed, 29 Sep 2021) Log Message [ iOS ] fast/events/ios/viewport-shrink-to-fit-allows-double-tap.html is flaky timing out. https://bugs.webkit.org/show_bug.cgi?id=230987 Unreviewed test gardening. * platform/ios-14/TestExpectations: * platform/ios-wk2/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/ios-14/TestExpectations trunk/LayoutTests/platform/ios-wk2/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (283264 => 283265) --- trunk/LayoutTests/ChangeLog 2021-09-29 21:45:04 UTC (rev 283264) +++ trunk/LayoutTests/ChangeLog 2021-09-29 21:52:58 UTC (rev 283265) @@ -1,3 +1,13 @@ +2021-09-29 Ayumi Kojima + +[ iOS ] fast/events/ios/viewport-shrink-to-fit-allows-double-tap.html is flaky timing out. +https://bugs.webkit.org/show_bug.cgi?id=230987 + +Unreviewed test gardening. + +* platform/ios-14/TestExpectations: +* platform/ios-wk2/TestExpectations: + 2021-09-29 Eric Hutchison [ BigSur Debug arm64 ] streams/readableStream-then.html is a flaky crash. Modified: trunk/LayoutTests/platform/ios-14/TestExpectations (283264 => 283265) --- trunk/LayoutTests/platform/ios-14/TestExpectations 2021-09-29 21:45:04 UTC (rev 283264) +++ trunk/LayoutTests/platform/ios-14/TestExpectations 2021-09-29 21:52:58 UTC (rev 283265) @@ -109,7 +109,6 @@ fast/forms/ios/zoom-after-input-tap.html [ Pass Failure Timeout Crash ] fast/events/ios/key-events-comprehensive/key-events-control-option.html [ Pass Timeout ] [ Debug ] fast/events/ios/key-events-comprehensive/key-events-control-shift.html [ Pass Timeout ] -fast/events/ios/viewport-shrink-to-fit-allows-double-tap.html [ Pass Timeout ] [ Debug ] fast/selectors/is-backtracking.html [ Pass Timeout ] [ Debug ] fast/selectors/matches-backtracking.html [ Pass Timeout ] Modified: trunk/LayoutTests/platform/ios-wk2/TestExpectations (283264 => 283265) --- trunk/LayoutTests/platform/ios-wk2/TestExpectations 2021-09-29 21:45:04 UTC (rev 283264) +++ trunk/LayoutTests/platform/ios-wk2/TestExpectations 2021-09-29 21:52:58 UTC (rev 283265) @@ -2071,6 +2071,8 @@ #rdar://82259067 ([iOS Debug]fast/events/ios/rotation/basic-rotation.html is a constant crash) fast/events/ios/rotation/basic-rotation.html [ Pass Crash Failure ] +webkit.org/b/230987 fast/events/ios/viewport-shrink-to-fit-allows-double-tap.html [ Pass Timeout ] + webkit.org/b/229558 http/tests/navigation/page-cache-getUserMedia-pending-promise.html [ Pass Failure ] webkit.org/b/229561 http/tests/navigation/page-cache-video.html [ Pass Failure ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [283264] trunk/Source/bmalloc
Title: [283264] trunk/Source/bmalloc
Revision 283264
Author ehutchi...@apple.com
Date 2021-09-29 14:45:04 -0700 (Wed, 29 Sep 2021)
Log Message
Unreviewed, reverting r282850.
Patch causing many crashes in
bmalloc::Heap::decommitLargeRange
Reverted changeset:
"[bmalloc] freeableMemory and footprint of Heap are completely
broken"
https://bugs.webkit.org/show_bug.cgi?id=230245
https://commits.webkit.org/r282850
Modified Paths
trunk/Source/bmalloc/ChangeLog
trunk/Source/bmalloc/bmalloc/Heap.cpp
trunk/Source/bmalloc/bmalloc/Heap.h
Diff
Modified: trunk/Source/bmalloc/ChangeLog (283263 => 283264)
--- trunk/Source/bmalloc/ChangeLog 2021-09-29 21:16:28 UTC (rev 283263)
+++ trunk/Source/bmalloc/ChangeLog 2021-09-29 21:45:04 UTC (rev 283264)
@@ -1,3 +1,17 @@
+2021-09-29 Eric Hutchison
+
+Unreviewed, reverting r282850.
+
+Patch causing many crashes in
+bmalloc::Heap::decommitLargeRange
+
+Reverted changeset:
+
+"[bmalloc] freeableMemory and footprint of Heap are completely
+broken"
+https://bugs.webkit.org/show_bug.cgi?id=230245
+https://commits.webkit.org/r282850
+
2021-09-27 Filip Pizlo
[libpas] Fix coalescing of the large sharing pool and make it easy to introspect it (update to e4d20851ee9ff00f2962b349a9ff8465695a83d7)
Modified: trunk/Source/bmalloc/bmalloc/Heap.cpp (283263 => 283264)
--- trunk/Source/bmalloc/bmalloc/Heap.cpp 2021-09-29 21:16:28 UTC (rev 283263)
+++ trunk/Source/bmalloc/bmalloc/Heap.cpp 2021-09-29 21:45:04 UTC (rev 283264)
@@ -99,38 +99,6 @@
return m_footprint;
}
-BINLINE void Heap::adjustStat(size_t& value, ssize_t amount)
-{
-auto result = value + amount;
-BASSERT((amount >= 0 && result >= value) || (amount < 0 && result < value));
-value = result;
-}
-
-BINLINE void Heap::logStat(size_t value, ssize_t amount, const char* label, const char* note)
-{
-fprintf(stderr, "%s: %lu (%ld) %s\n", label, value, amount, note);
-}
-
-BINLINE void Heap::adjustFreeableMemory(UniqueLockHolder&, ssize_t amount, const char* note)
-{
-constexpr bool verbose = false;
-
-adjustStat(m_freeableMemory, amount);
-
-if constexpr (verbose)
-logStat(m_freeableMemory, amount, "freeableMemory", note);
-}
-
-BINLINE void Heap::adjustFootprint(UniqueLockHolder&, ssize_t amount, const char* note)
-{
-constexpr bool verbose = false;
-
-adjustStat(m_footprint, amount);
-
-if constexpr (verbose)
-logStat(m_footprint, amount, "footprint", note);
-}
-
void Heap::markAllLargeAsEligibile(const LockHolder&)
{
m_largeFree.markAllAsEligibile();
@@ -138,12 +106,12 @@
m_condition.notify_all();
}
-void Heap::decommitLargeRange(UniqueLockHolder& lock, LargeRange& range, BulkDecommit& decommitter)
+void Heap::decommitLargeRange(UniqueLockHolder&, LargeRange& range, BulkDecommit& decommitter)
{
BASSERT(range.hasPhysicalPages());
-adjustFootprint(lock, -range.totalPhysicalSize(), "decommitLargeRange");
-adjustFreeableMemory(lock, -range.totalPhysicalSize(), "decommitLargeRange");
+m_footprint -= range.totalPhysicalSize();
+m_freeableMemory -= range.totalPhysicalSize();
decommitter.addLazy(range.begin(), range.physicalEnd() - range.begin());
m_hasPendingDecommits = true;
range.setStartPhysicalSize(0);
@@ -171,8 +139,8 @@
size_t pageSize = bmalloc::pageSize(&list - &m_freePages[0]);
size_t decommitSize = physicalPageSizeSloppy(page->begin()->begin(), pageSize);
-adjustFootprint(lock, -decommitSize, "scavenge");
-adjustFreeableMemory(lock, -decommitSize, "scavenge");
+m_freeableMemory -= decommitSize;
+m_footprint -= decommitSize;
decommitter.addEager(page->begin()->begin(), pageSize);
page->setHasPhysicalPages(false);
#if ENABLE_PHYSICAL_PAGE_MAP
@@ -237,7 +205,7 @@
chunk->freePages().push(page);
});
-adjustFreeableMemory(lock, chunkSize, "allocateSmallChunk");
+m_freeableMemory += chunkSize;
m_scavenger->schedule(0);
@@ -307,10 +275,10 @@
size_t pageSize = bmalloc::pageSize(pageClass);
size_t physicalSize = physicalPageSizeSloppy(page->begin()->begin(), pageSize);
if (page->hasPhysicalPages())
-adjustFreeableMemory(lock, -physicalSize, "allocateSmallPage");
+m_freeableMemory -= physicalSize;
else {
m_scavenger->scheduleIfUnderMemoryPressure(pageSize);
-adjustFootprint(lock, physicalSize, "allocateSmallPage");
+m_footprint += physicalSize;
vmAllocatePhysicalPagesSloppy(page->begin()->begin(), pageSize);
page->setHasPhysicalPages(true);
#if ENABLE_PHYSICAL_PAGE_MAP
@@ -346,7 +314,7 @@
size_t pageClass = m_constants.pageClass(page->sizeClass());
-adjustFreeableMemory(lock, physicalPageSizeSloppy(page->begin()-
[webkit-changes] [283263] trunk/LayoutTests
Title: [283263] trunk/LayoutTests Revision 283263 Author ehutchi...@apple.com Date 2021-09-29 14:16:28 -0700 (Wed, 29 Sep 2021) Log Message [ BigSur Debug arm64 ] streams/readableStream-then.html is a flaky crash. https://bugs.webkit.org/show_bug.cgi?id=230984. Unreviewed test gardening. * platform/mac/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/mac/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (283262 => 283263) --- trunk/LayoutTests/ChangeLog 2021-09-29 21:12:45 UTC (rev 283262) +++ trunk/LayoutTests/ChangeLog 2021-09-29 21:16:28 UTC (rev 283263) @@ -1,3 +1,12 @@ +2021-09-29 Eric Hutchison + +[ BigSur Debug arm64 ] streams/readableStream-then.html is a flaky crash. +https://bugs.webkit.org/show_bug.cgi?id=230984. + +Unreviewed test gardening. + +* platform/mac/TestExpectations: + 2021-09-29 Truitt Savell Unreviewed, reverting r281602. Modified: trunk/LayoutTests/platform/mac/TestExpectations (283262 => 283263) --- trunk/LayoutTests/platform/mac/TestExpectations 2021-09-29 21:12:45 UTC (rev 283262) +++ trunk/LayoutTests/platform/mac/TestExpectations 2021-09-29 21:16:28 UTC (rev 283263) @@ -2424,3 +2424,5 @@ webkit.org/b/230862 [ Catalina BigSur ] imported/w3c/web-platform-tests/resource-timing/sizes-redirect-img.html [ Pass Failure ] +webkit.org/b/230984 [ BigSur Debug arm64 ] streams/readableStream-then.html [ Pass Crash ] + ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [283262] trunk/LayoutTests
Title: [283262] trunk/LayoutTests Revision 283262 Author tsav...@apple.com Date 2021-09-29 14:12:45 -0700 (Wed, 29 Sep 2021) Log Message Unreviewed, reverting r281602. These tests are working now Reverted changeset: "25 webkit imported/w3c/web-platform-tests/css/ layout tests failing with black bars" https://commits.webkit.org/r281602 Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/mac/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (283261 => 283262) --- trunk/LayoutTests/ChangeLog 2021-09-29 20:55:43 UTC (rev 283261) +++ trunk/LayoutTests/ChangeLog 2021-09-29 21:12:45 UTC (rev 283262) @@ -1,3 +1,15 @@ +2021-09-29 Truitt Savell + +Unreviewed, reverting r281602. + +These tests are working now + +Reverted changeset: + +"25 webkit imported/w3c/web-platform-tests/css/ layout tests +failing with black bars" +https://commits.webkit.org/r281602 + 2021-09-29 Eric Hutchison Update test expectations to include x86 for imported/w3c/web-platform-tests/resource-timing/sizes-redirect-img.html. Modified: trunk/LayoutTests/platform/mac/TestExpectations (283261 => 283262) --- trunk/LayoutTests/platform/mac/TestExpectations 2021-09-29 20:55:43 UTC (rev 283261) +++ trunk/LayoutTests/platform/mac/TestExpectations 2021-09-29 21:12:45 UTC (rev 283262) @@ -2371,32 +2371,6 @@ [ Monterey+ ] imported/w3c/web-platform-tests/html/canvas/element/wide-gamut-canvas/2d.color.space.p3.toDataURL.with.putImageData.html [ Pass ] [ Monterey+ ] storage/indexeddb/structured-clone-image-data-display-p3.html [ Pass ] -# rdar://82132196 (20 webkit imported/w3c/web-platform-tests/css/ layout tests failing) -[ Monterey ] imported/w3c/web-platform-tests/css/css-backgrounds/background-position/subpixel-position-center.tentative.html [ Pass ImageOnlyFailure ] -[ Monterey ] imported/w3c/web-platform-tests/css/css-flexbox/flex-aspect-ratio-img-column-016.html [ Pass ImageOnlyFailure ] -[ Monterey ] imported/w3c/web-platform-tests/css/css-flexbox/flex-aspect-ratio-img-row-006.html [ Pass ImageOnlyFailure ] -[ Monterey ] imported/w3c/web-platform-tests/css/css-flexbox/flex-aspect-ratio-img-row-012.html [ Pass ImageOnlyFailure ] -[ Monterey ] imported/w3c/web-platform-tests/css/css-flexbox/flex-minimum-height-flex-items-005.xht [ Pass ImageOnlyFailure ] -[ Monterey ] imported/w3c/web-platform-tests/css/css-flexbox/flex-minimum-width-flex-items-005.xht [ Pass ImageOnlyFailure ] -[ Monterey ] imported/w3c/web-platform-tests/css/css-flexbox/flex-minimum-width-flex-items-010.html [ Pass ImageOnlyFailure ] -[ Monterey ] imported/w3c/web-platform-tests/css/css-flexbox/flex-minimum-width-flex-items-016.html [ Pass ImageOnlyFailure ] -[ Monterey ] imported/w3c/web-platform-tests/css/css-flexbox/image-items-flake-001.html [ Pass ImageOnlyFailure ] -[ Monterey ] imported/w3c/web-platform-tests/css/css-grid/grid-items/grid-img-item-percent-max-height-001.html [ Pass ImageOnlyFailure ] -[ Monterey ] imported/w3c/web-platform-tests/css/css-grid/grid-items/grid-minimum-size-grid-items-006.html [ Pass ImageOnlyFailure ] -[ Monterey ] imported/w3c/web-platform-tests/css/css-grid/grid-items/grid-minimum-size-grid-items-008.html [ Pass ImageOnlyFailure ] -[ Monterey ] imported/w3c/web-platform-tests/css/css-multicol/multicol-rule-fraction-002.xht [ Pass ImageOnlyFailure ] -[ Monterey ] imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/abspos-016.html [ Pass ImageOnlyFailure ] -[ Monterey ] imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/flex-aspect-ratio-027.html [ Pass ImageOnlyFailure ] -[ Monterey ] imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/flex-aspect-ratio-028.html [ Pass ImageOnlyFailure ] -[ Monterey ] imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/flex-aspect-ratio-029.html [ Pass ImageOnlyFailure ] -[ Monterey ] imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/flex-aspect-ratio-030.html [ Pass ImageOnlyFailure ] -[ Monterey ] imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/replaced-element-031.html [ Pass ImageOnlyFailure ] -[ Monterey ] imported/w3c/web-platform-tests/css/css-ui/outline-negative-offset-composited-scroll.html [ Pass ImageOnlyFailure ] -[ Monterey ] svg/custom/image-width-height-auto-dynamic.svg [ Pass ImageOnlyFailure ] -[ Monterey ] svg/custom/image-width-height-auto-initial.svg [ Pass ImageOnlyFailure ] -[ Monterey ] svg/custom/image-width-height-length-initial.svg [ Pass ImageOnlyFailure ] -[ Monterey ] imported/w3c/web-platform-tests/density-size-correction/density-corrected-image-svg.html [ Pass ImageOnlyFailure ] - webkit.org/b/229521 pointer-lock/lock-already-locked.html [ Pass Failure ] webkit.org/b/189672 [ Catalina ] webgl/2.0.0/conformance2/rendering/uniform-block-buffer-size.html [ Pass Failure ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.or
[webkit-changes] [283261] trunk/LayoutTests
Title: [283261] trunk/LayoutTests Revision 283261 Author ehutchi...@apple.com Date 2021-09-29 13:55:43 -0700 (Wed, 29 Sep 2021) Log Message Update test expectations to include x86 for imported/w3c/web-platform-tests/resource-timing/sizes-redirect-img.html. https://bugs.webkit.org/show_bug.cgi?id=230862. Unreviewed test gardening. * platform/mac/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/mac/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (283260 => 283261) --- trunk/LayoutTests/ChangeLog 2021-09-29 20:53:53 UTC (rev 283260) +++ trunk/LayoutTests/ChangeLog 2021-09-29 20:55:43 UTC (rev 283261) @@ -1,5 +1,14 @@ 2021-09-29 Eric Hutchison +Update test expectations to include x86 for imported/w3c/web-platform-tests/resource-timing/sizes-redirect-img.html. +https://bugs.webkit.org/show_bug.cgi?id=230862. + +Unreviewed test gardening. + +* platform/mac/TestExpectations: + +2021-09-29 Eric Hutchison + [iOS EWS] imported/w3c/web-platform-tests/content-security-policy/script-src/script-src-strict_dynamic_worker.https.html is a flaky failure. https://bugs.webkit.org/show_bug.cgi?id=230979. Modified: trunk/LayoutTests/platform/mac/TestExpectations (283260 => 283261) --- trunk/LayoutTests/platform/mac/TestExpectations 2021-09-29 20:53:53 UTC (rev 283260) +++ trunk/LayoutTests/platform/mac/TestExpectations 2021-09-29 20:55:43 UTC (rev 283261) @@ -2448,5 +2448,5 @@ webkit.org/b/230780 [ Catalina BigSur Debug ] fast/workers/use-machine-stack.html [ Pass Crash ] -webkit.org/b/230862 [ Catalina BigSur arm64 ] imported/w3c/web-platform-tests/resource-timing/sizes-redirect-img.html [ Pass Failure ] +webkit.org/b/230862 [ Catalina BigSur ] imported/w3c/web-platform-tests/resource-timing/sizes-redirect-img.html [ Pass Failure ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [283260] trunk/Source/WebCore
Title: [283260] trunk/Source/WebCore
Revision 283260
Author za...@apple.com
Date 2021-09-29 13:53:53 -0700 (Wed, 29 Sep 2021)
Log Message
[LFC][IFC] LineBoxBuilder should use the first-line style when applicable
https://bugs.webkit.org/show_bug.cgi?id=230930
Reviewed by Antti Koivisto.
This is in preparation for supporting first-line style.
* layout/formattingContexts/inline/InlineFormattingContext.cpp:
(WebCore::Layout::InlineFormattingContext::lineLayout):
(WebCore::Layout::InlineFormattingContext::computeGeometryForLineContent):
* layout/formattingContexts/inline/InlineFormattingContext.h:
* layout/formattingContexts/inline/InlineLineBoxBuilder.cpp:
(WebCore::Layout::LineBoxBuilder::build):
(WebCore::Layout::LineBoxBuilder::constructAndAlignInlineLevelBoxes):
* layout/formattingContexts/inline/InlineLineBoxBuilder.h:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/layout/formattingContexts/inline/InlineFormattingContext.cpp
trunk/Source/WebCore/layout/formattingContexts/inline/InlineLineBoxBuilder.cpp
trunk/Source/WebCore/layout/formattingContexts/inline/InlineLineBoxBuilder.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (283259 => 283260)
--- trunk/Source/WebCore/ChangeLog 2021-09-29 20:46:39 UTC (rev 283259)
+++ trunk/Source/WebCore/ChangeLog 2021-09-29 20:53:53 UTC (rev 283260)
@@ -1,5 +1,23 @@
2021-09-29 Alan Bujtas
+[LFC][IFC] LineBoxBuilder should use the first-line style when applicable
+https://bugs.webkit.org/show_bug.cgi?id=230930
+
+Reviewed by Antti Koivisto.
+
+This is in preparation for supporting first-line style.
+
+* layout/formattingContexts/inline/InlineFormattingContext.cpp:
+(WebCore::Layout::InlineFormattingContext::lineLayout):
+(WebCore::Layout::InlineFormattingContext::computeGeometryForLineContent):
+* layout/formattingContexts/inline/InlineFormattingContext.h:
+* layout/formattingContexts/inline/InlineLineBoxBuilder.cpp:
+(WebCore::Layout::LineBoxBuilder::build):
+(WebCore::Layout::LineBoxBuilder::constructAndAlignInlineLevelBoxes):
+* layout/formattingContexts/inline/InlineLineBoxBuilder.h:
+
+2021-09-29 Alan Bujtas
+
Thin hairline gap displayed for subpixel sized inset box-shadows
https://bugs.webkit.org/show_bug.cgi?id=230814
Modified: trunk/Source/WebCore/layout/formattingContexts/inline/InlineFormattingContext.cpp (283259 => 283260)
--- trunk/Source/WebCore/layout/formattingContexts/inline/InlineFormattingContext.cpp 2021-09-29 20:46:39 UTC (rev 283259)
+++ trunk/Source/WebCore/layout/formattingContexts/inline/InlineFormattingContext.cpp 2021-09-29 20:53:53 UTC (rev 283260)
@@ -572,11 +572,12 @@
InlineRect InlineFormattingContext::computeGeometryForLineContent(const LineBuilder::LineContent& lineContent)
{
auto& formattingState = this->formattingState();
-auto lineAndLineBox = LineBoxBuilder(*this).build(lineContent);
+auto currentLineIndex = formattingState.lines().size();
+
+auto lineAndLineBox = LineBoxBuilder(*this).build(lineContent, currentLineIndex);
auto lineBoxLogicalRect = lineAndLineBox.line.lineBoxLogicalRect();
auto inlineContentBuilder = InlineDisplayContentBuilder { root(), formattingState };
-auto currentLineIndex = formattingState.lines().size();
formattingState.addBoxes(inlineContentBuilder.build(lineContent, lineAndLineBox.lineBox, lineBoxLogicalRect.topLeft(), currentLineIndex));
formattingState.addLineBox(WTFMove(lineAndLineBox.lineBox));
formattingState.addLine(lineAndLineBox.line);
Modified: trunk/Source/WebCore/layout/formattingContexts/inline/InlineLineBoxBuilder.cpp (283259 => 283260)
--- trunk/Source/WebCore/layout/formattingContexts/inline/InlineLineBoxBuilder.cpp 2021-09-29 20:46:39 UTC (rev 283259)
+++ trunk/Source/WebCore/layout/formattingContexts/inline/InlineLineBoxBuilder.cpp 2021-09-29 20:53:53 UTC (rev 283260)
@@ -109,14 +109,15 @@
{
}
-LineBoxBuilder::LineAndLineBox LineBoxBuilder::build(const LineBuilder::LineContent& lineContent)
+LineBoxBuilder::LineAndLineBox LineBoxBuilder::build(const LineBuilder::LineContent& lineContent, size_t lineIndex)
{
auto& runs = lineContent.runs;
auto contentLogicalWidth = lineContent.contentLogicalWidth;
-auto contentLogicalLeft = Layout::horizontalAlignmentOffset(runs, rootBox().style().textAlign(), lineContent.lineLogicalWidth, contentLogicalWidth, lineContent.isLastLineWithInlineContent).value_or(InlineLayoutUnit { });
+auto textAlign = !lineIndex ? rootBox().firstLineStyle().textAlign() : rootBox().style().textAlign();
+auto contentLogicalLeft = Layout::horizontalAlignmentOffset(runs, textAlign, lineContent.lineLogicalWidth, contentLogicalWidth, lineContent.isLastLineWithInlineContent).value_or(InlineLayoutUnit { });
auto lineBox = LineBox { rootBox(), contentLogicalLeft, contentLogicalWidth, lineContent.nonSpanningInlineLevelBoxCount };
-auto
[webkit-changes] [283259] trunk/LayoutTests
Title: [283259] trunk/LayoutTests Revision 283259 Author ehutchi...@apple.com Date 2021-09-29 13:46:39 -0700 (Wed, 29 Sep 2021) Log Message [iOS EWS] imported/w3c/web-platform-tests/content-security-policy/script-src/script-src-strict_dynamic_worker.https.html is a flaky failure. https://bugs.webkit.org/show_bug.cgi?id=230979. Unreviewed test gardening. * platform/ios-14-wk2/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/ios-14-wk2/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (283258 => 283259) --- trunk/LayoutTests/ChangeLog 2021-09-29 20:38:28 UTC (rev 283258) +++ trunk/LayoutTests/ChangeLog 2021-09-29 20:46:39 UTC (rev 283259) @@ -1,3 +1,12 @@ +2021-09-29 Eric Hutchison + +[iOS EWS] imported/w3c/web-platform-tests/content-security-policy/script-src/script-src-strict_dynamic_worker.https.html is a flaky failure. +https://bugs.webkit.org/show_bug.cgi?id=230979. + +Unreviewed test gardening. + +* platform/ios-14-wk2/TestExpectations: + 2021-09-29 Alan Bujtas Thin hairline gap displayed for subpixel sized inset box-shadows Modified: trunk/LayoutTests/platform/ios-14-wk2/TestExpectations (283258 => 283259) --- trunk/LayoutTests/platform/ios-14-wk2/TestExpectations 2021-09-29 20:38:28 UTC (rev 283258) +++ trunk/LayoutTests/platform/ios-14-wk2/TestExpectations 2021-09-29 20:46:39 UTC (rev 283259) @@ -27,3 +27,4 @@ webkit.org/b/230865 webrtc/video-mute.html [ Pass Failure ] +webkit.org/b/230979 imported/w3c/web-platform-tests/content-security-policy/script-src/script-src-strict_dynamic_worker.https.html [ Pass Failure ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [283258] trunk
Title: [283258] trunk
Revision 283258
Author za...@apple.com
Date 2021-09-29 13:38:28 -0700 (Wed, 29 Sep 2021)
Log Message
Thin hairline gap displayed for subpixel sized inset box-shadows
https://bugs.webkit.org/show_bug.cgi?id=230814
Reviewed by Simon Fraser.
Source/WebCore:
Add missing device pixel snapping for inset offset.
Test: fast/box-shadow/hidpi-box-shadow-inset-on-subpixel-position.html
* rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::paintBoxShadow):
LayoutTests:
* fast/box-shadow/hidpi-box-shadow-inset-on-subpixel-position-expected.html: Added.
* fast/box-shadow/hidpi-box-shadow-inset-on-subpixel-position.html: Added.
* platform/win/TestExpectations:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/win/TestExpectations
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderBoxModelObject.cpp
Added Paths
trunk/LayoutTests/fast/box-shadow/hidpi-box-shadow-inset-on-subpixel-position-expected.html
trunk/LayoutTests/fast/box-shadow/hidpi-box-shadow-inset-on-subpixel-position.html
Diff
Modified: trunk/LayoutTests/ChangeLog (283257 => 283258)
--- trunk/LayoutTests/ChangeLog 2021-09-29 20:35:07 UTC (rev 283257)
+++ trunk/LayoutTests/ChangeLog 2021-09-29 20:38:28 UTC (rev 283258)
@@ -1,3 +1,14 @@
+2021-09-29 Alan Bujtas
+
+Thin hairline gap displayed for subpixel sized inset box-shadows
+https://bugs.webkit.org/show_bug.cgi?id=230814
+
+Reviewed by Simon Fraser.
+
+* fast/box-shadow/hidpi-box-shadow-inset-on-subpixel-position-expected.html: Added.
+* fast/box-shadow/hidpi-box-shadow-inset-on-subpixel-position.html: Added.
+* platform/win/TestExpectations:
+
2021-09-29 Eric Hutchison
Fixed incorrect test expectations for imported/w3c/web-platform-tests/mediacapture-streams/MediaStream-default-feature-policy.https.html.
Added: trunk/LayoutTests/fast/box-shadow/hidpi-box-shadow-inset-on-subpixel-position-expected.html (0 => 283258)
--- trunk/LayoutTests/fast/box-shadow/hidpi-box-shadow-inset-on-subpixel-position-expected.html (rev 0)
+++ trunk/LayoutTests/fast/box-shadow/hidpi-box-shadow-inset-on-subpixel-position-expected.html 2021-09-29 20:38:28 UTC (rev 283258)
@@ -0,0 +1,19 @@
+
+
+Test if subpixel inset shadows paint properly.
+
+div {
+ width: 100px;
+ height: 100px;
+ background-color: yellow;
+}
+
+
+
+
+
+
+
+
+
+
Added: trunk/LayoutTests/fast/box-shadow/hidpi-box-shadow-inset-on-subpixel-position.html (0 => 283258)
--- trunk/LayoutTests/fast/box-shadow/hidpi-box-shadow-inset-on-subpixel-position.html (rev 0)
+++ trunk/LayoutTests/fast/box-shadow/hidpi-box-shadow-inset-on-subpixel-position.html 2021-09-29 20:38:28 UTC (rev 283258)
@@ -0,0 +1,19 @@
+
+
+Test if subpixel inset shadows paint properly.
+
+div {
+ width: 100px;
+ height: 100px;
+ background-color: yellow;
+}
+
+
+
+
+
+
+
+
+
+
\ No newline at end of file
Modified: trunk/LayoutTests/platform/win/TestExpectations (283257 => 283258)
--- trunk/LayoutTests/platform/win/TestExpectations 2021-09-29 20:35:07 UTC (rev 283257)
+++ trunk/LayoutTests/platform/win/TestExpectations 2021-09-29 20:38:28 UTC (rev 283258)
@@ -602,6 +602,7 @@
webkit.org/b/87919 fast/repaint/hidpi-wrong-repaint-rect-when-parent-has-noncompositing-transform.html [ Failure ]
webkit.org/b/151754 fast/borders/hidpi-border-clipping-right-after-move.html [ ImageOnlyFailure ]
+fast/box-shadow/hidpi-box-shadow-inset-on-subpixel-position.html [ ImageOnlyFailure ]
# Skip because this platform does not support a paging mouse wheel event
fast/events/wheel/platform-wheelevent-paging-x-in-non-scrolling-div.html [ Skip ]
Modified: trunk/Source/WebCore/ChangeLog (283257 => 283258)
--- trunk/Source/WebCore/ChangeLog 2021-09-29 20:35:07 UTC (rev 283257)
+++ trunk/Source/WebCore/ChangeLog 2021-09-29 20:38:28 UTC (rev 283258)
@@ -1,5 +1,19 @@
2021-09-29 Alan Bujtas
+Thin hairline gap displayed for subpixel sized inset box-shadows
+https://bugs.webkit.org/show_bug.cgi?id=230814
+
+Reviewed by Simon Fraser.
+
+Add missing device pixel snapping for inset offset.
+
+Test: fast/box-shadow/hidpi-box-shadow-inset-on-subpixel-position.html
+
+* rendering/RenderBoxModelObject.cpp:
+(WebCore::RenderBoxModelObject::paintBoxShadow):
+
+2021-09-29 Alan Bujtas
+
[LFC][IFC] InlineDisplayContentBuilder should use the first-line style when applicable
https://bugs.webkit.org/show_bug.cgi?id=230932
Modified: trunk/Source/WebCore/rendering/RenderBoxModelObject.cpp (283257 => 283258)
--- trunk/Source/WebCore/rendering/RenderBoxModelObject.cpp 2021-09-29 20:35:07 UTC (rev 283257)
+++ trunk/Source/WebCore/rendering/RenderBoxModelObject.cpp 2021-09-29 20:38:28 UTC (rev 283258)
@@ -2544,7 +2544,8 @@
context.translate(extraOffset);
shadowOffset -= extraOffset;
-context.se
[webkit-changes] [283257] trunk/LayoutTests
Title: [283257] trunk/LayoutTests Revision 283257 Author ehutchi...@apple.com Date 2021-09-29 13:35:07 -0700 (Wed, 29 Sep 2021) Log Message Fixed incorrect test expectations for imported/w3c/web-platform-tests/mediacapture-streams/MediaStream-default-feature-policy.https.html. https://bugs.webkit.org/show_bug.cgi?id=230866. Unreviewed test gardening. * platform/mac-wk2/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/mac-wk2/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (283256 => 283257) --- trunk/LayoutTests/ChangeLog 2021-09-29 20:29:09 UTC (rev 283256) +++ trunk/LayoutTests/ChangeLog 2021-09-29 20:35:07 UTC (rev 283257) @@ -1,3 +1,12 @@ +2021-09-29 Eric Hutchison + +Fixed incorrect test expectations for imported/w3c/web-platform-tests/mediacapture-streams/MediaStream-default-feature-policy.https.html. +https://bugs.webkit.org/show_bug.cgi?id=230866. + +Unreviewed test gardening. + +* platform/mac-wk2/TestExpectations: + 2021-09-29 Kimmo Kinnunen MediaStream canvas.captureStream() fails for WebGL Modified: trunk/LayoutTests/platform/mac-wk2/TestExpectations (283256 => 283257) --- trunk/LayoutTests/platform/mac-wk2/TestExpectations 2021-09-29 20:29:09 UTC (rev 283256) +++ trunk/LayoutTests/platform/mac-wk2/TestExpectations 2021-09-29 20:35:07 UTC (rev 283257) @@ -1678,5 +1678,6 @@ webkit.org/b/230865 [ BigSur Debug arm64 ] webrtc/video-mute.html [ Pass Failure ] -webkit.org/b/230866 [ Catalina BigSur ] imported/w3c/web-platform-tests/mediacapture-streams/MediaStream-default-feature-policy.https.html [ Pass Failure Crash ] +webkit.org/b/230866 [ Catalina BigSur ] imported/w3c/web-platform-tests/mediacapture-streams/MediaStream-default-feature-policy.https.html [ Pass Failure Crash DumpJSConsoleLogInStdErr ] + ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [283256] trunk/Source/WebCore
Title: [283256] trunk/Source/WebCore
Revision 283256
Author za...@apple.com
Date 2021-09-29 13:29:09 -0700 (Wed, 29 Sep 2021)
Log Message
[LFC][IFC] InlineDisplayContentBuilder should use the first-line style when applicable
https://bugs.webkit.org/show_bug.cgi?id=230932
Reviewed by Antti Koivisto.
This is in preparation for supporting first-line style.
* layout/formattingContexts/inline/InlineDisplayContentBuilder.cpp:
(WebCore::Layout::InlineDisplayContentBuilder::build):
(WebCore::Layout::InlineDisplayContentBuilder::createBoxesAndUpdateGeometryForLineContent):
(WebCore::Layout::InlineDisplayContentBuilder::createBoxesAndUpdateGeometryForLineSpanningInlineBoxes):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/layout/formattingContexts/inline/InlineDisplayContentBuilder.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (283255 => 283256)
--- trunk/Source/WebCore/ChangeLog 2021-09-29 20:16:10 UTC (rev 283255)
+++ trunk/Source/WebCore/ChangeLog 2021-09-29 20:29:09 UTC (rev 283256)
@@ -1,5 +1,19 @@
2021-09-29 Alan Bujtas
+[LFC][IFC] InlineDisplayContentBuilder should use the first-line style when applicable
+https://bugs.webkit.org/show_bug.cgi?id=230932
+
+Reviewed by Antti Koivisto.
+
+This is in preparation for supporting first-line style.
+
+* layout/formattingContexts/inline/InlineDisplayContentBuilder.cpp:
+(WebCore::Layout::InlineDisplayContentBuilder::build):
+(WebCore::Layout::InlineDisplayContentBuilder::createBoxesAndUpdateGeometryForLineContent):
+(WebCore::Layout::InlineDisplayContentBuilder::createBoxesAndUpdateGeometryForLineSpanningInlineBoxes):
+
+2021-09-29 Alan Bujtas
+
[LFC][IFC] Pass in the first-line style to the InlineContentBreaker::ContinuousContent runs if applicable
https://bugs.webkit.org/show_bug.cgi?id=230924
Modified: trunk/Source/WebCore/layout/formattingContexts/inline/InlineDisplayContentBuilder.cpp (283255 => 283256)
--- trunk/Source/WebCore/layout/formattingContexts/inline/InlineDisplayContentBuilder.cpp 2021-09-29 20:16:10 UTC (rev 283255)
+++ trunk/Source/WebCore/layout/formattingContexts/inline/InlineDisplayContentBuilder.cpp 2021-09-29 20:29:09 UTC (rev 283256)
@@ -50,7 +50,7 @@
// Every line starts with a root box, even the empty ones.
auto rootInlineBoxRect = lineBox.logicalRectForRootInlineBox();
rootInlineBoxRect.moveBy(lineBoxLogicalTopLeft);
-boxes.append({ lineIndex, InlineDisplay::Box::Type::RootInlineBox, root(), root().style(), rootInlineBoxRect, rootInlineBoxRect, { }, { }, lineBox.rootInlineBox().hasContent()});
+boxes.append({ lineIndex, InlineDisplay::Box::Type::RootInlineBox, root(), !lineIndex ? root().firstLineStyle() : root().style(), rootInlineBoxRect, rootInlineBoxRect, { }, { }, lineBox.rootInlineBox().hasContent()});
createBoxesAndUpdateGeometryForLineSpanningInlineBoxes(lineBox, lineBoxLogicalTopLeft, lineIndex, boxes);
createBoxesAndUpdateGeometryForLineContent(lineContent, lineBox, lineBoxLogicalTopLeft, lineIndex, boxes);
@@ -64,8 +64,9 @@
// Create the inline boxes on the current line. This is mostly text and atomic inline boxes.
for (auto& lineRun : lineContent.runs) {
auto& layoutBox = lineRun.layoutBox();
-// FIXME: This should be lineIndex dependent to support first-line style.
-auto& style = layoutBox.style();
+auto& style = [&] () -> const RenderStyle& {
+return !lineIndex ? layoutBox.firstLineStyle() : layoutBox.style();
+}();
switch (lineRun.type()) {
case InlineItem::Type::Text: {
@@ -195,8 +196,9 @@
if (!inlineLevelBox.isLineSpanningInlineBox())
continue;
auto& layoutBox = inlineLevelBox.layoutBox();
-// FIXME: This should be lineIndex dependent to support first-line style.
-auto& style = layoutBox.style();
+auto& style = [&] () -> const RenderStyle& {
+return !lineIndex ? layoutBox.firstLineStyle() : layoutBox.style();
+}();
auto& boxGeometry = formattingState.boxGeometry(layoutBox);
// Inline boxes may or may not be wrapped and have boxes on multiple lines (e.g. first linesecond linethird line)
auto inlineBoxBorderBox = lineBox.logicalBorderBoxForInlineBox(layoutBox, boxGeometry);
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [283255] trunk/Source/WebCore
Title: [283255] trunk/Source/WebCore
Revision 283255
Author za...@apple.com
Date 2021-09-29 13:16:10 -0700 (Wed, 29 Sep 2021)
Log Message
[LFC][IFC] Pass in the first-line style to the InlineContentBreaker::ContinuousContent runs if applicable
https://bugs.webkit.org/show_bug.cgi?id=230924
Reviewed by Antti Koivisto.
Now the inline content breaker has the correct set of style values when first-line style is set.
* layout/formattingContexts/inline/InlineItem.h:
(WebCore::Layout::InlineItem::firstLineStyle const):
* layout/formattingContexts/inline/InlineLineBuilder.cpp:
(WebCore::Layout::LineCandidate::InlineContent::appendInlineItem):
(WebCore::Layout::LineBuilder::layoutInlineContent):
(WebCore::Layout::LineBuilder::computedIntrinsicWidth):
(WebCore::Layout::LineBuilder::initialize):
(WebCore::Layout::LineBuilder::candidateContentForLine):
* layout/formattingContexts/inline/InlineLineBuilder.h:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/layout/formattingContexts/inline/InlineItem.h
trunk/Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.cpp
trunk/Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (283254 => 283255)
--- trunk/Source/WebCore/ChangeLog 2021-09-29 20:14:31 UTC (rev 283254)
+++ trunk/Source/WebCore/ChangeLog 2021-09-29 20:16:10 UTC (rev 283255)
@@ -1,3 +1,22 @@
+2021-09-29 Alan Bujtas
+
+[LFC][IFC] Pass in the first-line style to the InlineContentBreaker::ContinuousContent runs if applicable
+https://bugs.webkit.org/show_bug.cgi?id=230924
+
+Reviewed by Antti Koivisto.
+
+Now the inline content breaker has the correct set of style values when first-line style is set.
+
+* layout/formattingContexts/inline/InlineItem.h:
+(WebCore::Layout::InlineItem::firstLineStyle const):
+* layout/formattingContexts/inline/InlineLineBuilder.cpp:
+(WebCore::Layout::LineCandidate::InlineContent::appendInlineItem):
+(WebCore::Layout::LineBuilder::layoutInlineContent):
+(WebCore::Layout::LineBuilder::computedIntrinsicWidth):
+(WebCore::Layout::LineBuilder::initialize):
+(WebCore::Layout::LineBuilder::candidateContentForLine):
+* layout/formattingContexts/inline/InlineLineBuilder.h:
+
2021-09-29 Aditya Keerthi
Remove references to '-webkit-clear-button'
Modified: trunk/Source/WebCore/layout/formattingContexts/inline/InlineItem.h (283254 => 283255)
--- trunk/Source/WebCore/layout/formattingContexts/inline/InlineItem.h 2021-09-29 20:14:31 UTC (rev 283254)
+++ trunk/Source/WebCore/layout/formattingContexts/inline/InlineItem.h 2021-09-29 20:16:10 UTC (rev 283255)
@@ -41,6 +41,7 @@
Type type() const { return m_type; }
const Box& layoutBox() const { return *m_layoutBox; }
const RenderStyle& style() const { return layoutBox().style(); }
+const RenderStyle& firstLineStyle() const { return layoutBox().firstLineStyle(); }
bool isText() const { return type() == Type::Text; }
bool isBox() const { return type() == Type::Box; }
Modified: trunk/Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.cpp (283254 => 283255)
--- trunk/Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.cpp 2021-09-29 20:14:31 UTC (rev 283254)
+++ trunk/Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.cpp 2021-09-29 20:16:10 UTC (rev 283255)
@@ -140,7 +140,7 @@
const InlineItem* trailingLineBreak() const { return m_trailingLineBreak; }
const InlineItem* trailingWordBreakOpportunity() const { return m_trailingWordBreakOpportunity; }
-void appendInlineItem(const InlineItem&, InlineLayoutUnit logicalWidth);
+void appendInlineItem(const InlineItem&, const RenderStyle&, InlineLayoutUnit logicalWidth);
void appendTrailingLineBreak(const InlineItem& lineBreakItem) { m_trailingLineBreak = &lineBreakItem; }
void appendtrailingWordBreakOpportunity(const InlineItem& wordBreakItem) { m_trailingWordBreakOpportunity = &wordBreakItem; }
void reset();
@@ -175,7 +175,7 @@
{
}
-inline void LineCandidate::InlineContent::appendInlineItem(const InlineItem& inlineItem, InlineLayoutUnit logicalWidth)
+inline void LineCandidate::InlineContent::appendInlineItem(const InlineItem& inlineItem, const RenderStyle& style, InlineLayoutUnit logicalWidth)
{
ASSERT(inlineItem.isText() || inlineItem.isBox() || inlineItem.isInlineBoxStart() || inlineItem.isInlineBoxEnd());
auto collapsibleWidth = [&]() -> std::optional {
@@ -195,8 +195,7 @@
ASSERT(logicalWidth > letterSpacing);
return letterSpacing;
};
-// FIXME: While the line breaking related properties for atomic level boxes do not depend on the line index (first line style) it'd be great to figure out the correct style to pass in.
-m_continuousContent.append(inlineItem, !inlineItem.isBox() ? inlineItem.style
[webkit-changes] [283254] trunk/Source/WebCore
Title: [283254] trunk/Source/WebCore
Revision 283254
Author akeer...@apple.com
Date 2021-09-29 13:14:31 -0700 (Wed, 29 Sep 2021)
Log Message
Remove references to '-webkit-clear-button'
https://bugs.webkit.org/show_bug.cgi?id=230971
Reviewed by Simon Fraser.
The pseudo-element was removed in r150876.
* css/html.css:
* css/parser/CSSSelectorParser.cpp:
(WebCore::CSSSelectorParser::splitCompoundAtImplicitShadowCrossingCombinator):
Updated comment to use a pseudo-element which exists.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/html.css
trunk/Source/WebCore/css/parser/CSSSelectorParser.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (283253 => 283254)
--- trunk/Source/WebCore/ChangeLog 2021-09-29 20:06:54 UTC (rev 283253)
+++ trunk/Source/WebCore/ChangeLog 2021-09-29 20:14:31 UTC (rev 283254)
@@ -1,3 +1,18 @@
+2021-09-29 Aditya Keerthi
+
+Remove references to '-webkit-clear-button'
+https://bugs.webkit.org/show_bug.cgi?id=230971
+
+Reviewed by Simon Fraser.
+
+The pseudo-element was removed in r150876.
+
+* css/html.css:
+* css/parser/CSSSelectorParser.cpp:
+(WebCore::CSSSelectorParser::splitCompoundAtImplicitShadowCrossingCombinator):
+
+Updated comment to use a pseudo-element which exists.
+
2021-09-29 Kimmo Kinnunen
MediaStream canvas.captureStream() fails for WebGL
Modified: trunk/Source/WebCore/css/html.css (283253 => 283254)
--- trunk/Source/WebCore/css/html.css 2021-09-29 20:06:54 UTC (rev 283253)
+++ trunk/Source/WebCore/css/html.css 2021-09-29 20:14:31 UTC (rev 283254)
@@ -449,13 +449,6 @@
content: none !important;
}
-input::-webkit-clear-button {
--webkit-appearance: searchfield-cancel-button;
-display: inline-block;
-flex: none;
-margin-left: 2px;
-}
-
input[type="search"]::-webkit-search-cancel-button {
-webkit-appearance: searchfield-cancel-button;
display: block;
Modified: trunk/Source/WebCore/css/parser/CSSSelectorParser.cpp (283253 => 283254)
--- trunk/Source/WebCore/css/parser/CSSSelectorParser.cpp 2021-09-29 20:06:54 UTC (rev 283253)
+++ trunk/Source/WebCore/css/parser/CSSSelectorParser.cpp 2021-09-29 20:14:31 UTC (rev 283254)
@@ -1047,7 +1047,7 @@
// to their left, which really makes for a new compound selector, yet it's consumed by
// the selector parser as a single compound selector.
//
-// Example: input#x::-webkit-clear-button -> [ ::-webkit-clear-button, input, #x ]
+// Example: input#x::-webkit-inner-spin-button -> [ ::-webkit-inner-spin-button, input, #x ]
//
CSSParserSelector* splitAfter = compoundSelector.get();
while (splitAfter->tagHistory() && !splitAfter->tagHistory()->needsImplicitShadowCombinatorForMatching())
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [283253] trunk/Source/WebKit
Title: [283253] trunk/Source/WebKit Revision 283253 Author pvol...@apple.com Date 2021-09-29 13:06:54 -0700 (Wed, 29 Sep 2021) Log Message Add telemetry to the Networking process sandbox https://bugs.webkit.org/show_bug.cgi?id=230919 Reviewed by Brent Fulgham. Add telemetry to the Networking process sandbox on iOS and macOS. * NetworkProcess/mac/com.apple.WebKit.NetworkProcess.sb.in: * Resources/SandboxProfiles/ios/com.apple.WebKit.Networking.sb: Modified Paths trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/NetworkProcess/mac/com.apple.WebKit.NetworkProcess.sb.in trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.Networking.sb Diff Modified: trunk/Source/WebKit/ChangeLog (283252 => 283253) --- trunk/Source/WebKit/ChangeLog 2021-09-29 19:49:44 UTC (rev 283252) +++ trunk/Source/WebKit/ChangeLog 2021-09-29 20:06:54 UTC (rev 283253) @@ -1,3 +1,16 @@ +2021-09-29 Per Arne + +Add telemetry to the Networking process sandbox +https://bugs.webkit.org/show_bug.cgi?id=230919 + + +Reviewed by Brent Fulgham. + +Add telemetry to the Networking process sandbox on iOS and macOS. + +* NetworkProcess/mac/com.apple.WebKit.NetworkProcess.sb.in: +* Resources/SandboxProfiles/ios/com.apple.WebKit.Networking.sb: + 2021-09-29 Jer Noble Build-time optimization: forward declare more things in MediaPlayer.h and HTMLMediaElement.h Modified: trunk/Source/WebKit/NetworkProcess/mac/com.apple.WebKit.NetworkProcess.sb.in (283252 => 283253) --- trunk/Source/WebKit/NetworkProcess/mac/com.apple.WebKit.NetworkProcess.sb.in 2021-09-29 19:49:44 UTC (rev 283252) +++ trunk/Source/WebKit/NetworkProcess/mac/com.apple.WebKit.NetworkProcess.sb.in 2021-09-29 20:06:54 UTC (rev 283253) @@ -44,14 +44,15 @@ ;;; remove unneeded sandbox extensions. ;;; -(allow mach-register (local-name-prefix "")) +(allow mach-register (with telemetry) (local-name-prefix "")) -(allow mach-lookup (xpc-service-name-prefix "")) +(allow mach-lookup (with telemetry) (xpc-service-name-prefix "")) (allow system-automount (process-attribute is-platform-binary)) -(allow file-map-executable +(allow file-map-executable (with telemetry)) +(allow file-map-executable (with telemetry) (subpath "/Library/Apple/System/Library/Frameworks") (subpath "/Library/Apple/System/Library/PrivateFrameworks") (subpath "/System/Library/Frameworks") @@ -61,17 +62,17 @@ (subpath "/usr/appleinternal/lib") ;; ) -(allow file-read-metadata +(allow file-read-metadata (with telemetry) (literal "/etc") (literal "/tmp") (literal "/var") (literal "/private/etc/localtime")) -(allow file-read-metadata (path-ancestors "/System/Volumes/Data/private")) +(allow file-read-metadata (with telemetry) (path-ancestors "/System/Volumes/Data/private")) -(allow file-read* (literal "/")) +(allow file-read* (with telemetry) (literal "/")) -(allow file-read* +(allow file-read* (with telemetry) (subpath "/Library/Apple/System") (subpath "/Library/Filesystems/NetFSPlugins") (subpath "/Library/Preferences/Logging") ; Logging Rethink @@ -81,7 +82,7 @@ (subpath "/usr/lib") (subpath "/usr/share")) -(allow file-read* +(allow file-read* (with telemetry) (literal "/dev/autofs_nowait") (literal "/dev/random") (literal "/dev/urandom") @@ -90,41 +91,41 @@ (literal "/private/etc/protocols") (literal "/private/etc/services")) -(allow file-read* +(allow file-read* (with telemetry) file-write-data (literal "/dev/null") (literal "/dev/zero")) -(allow file-read* +(allow file-read* (with telemetry) file-write-data file-ioctl (literal "/dev/dtracehelper")) -(allow file-read* +(allow file-read* (with telemetry) (subpath "/usr/local/lib/sanitizers") ;; FIXME(209820) (subpath "/usr/appleinternal/lib") ;; ) -(allow file-write-create +(allow file-write-create (with telemetry) (require-all (prefix "/cores/") (vnode-type REGULAR-FILE))) -(allow file-read* +(allow file-read* (with telemetry) (require-all (subpath "/AppleInternal/Library/Preferences/Logging") (system-attribute apple-internal))) -(allow file-read* file-map-executable +(allow file-read* file-map-executable (with telemetry) (require-all (subpath "/usr/local/lib/log") (system-attribute apple-internal))) -(allow network-outbound +(allow network-outbound (with telemetry) (literal "/private/var/run/syslog")) -(allow ipc-posix-shm-read* +(allow ipc-posix-shm-read* (with telemetry) (ipc-posix-name "apple.shm.notification_center") (ipc-posix-name-prefix "apple.cfprefs.")) -(allow mach-lookup (with report) (with telemetry) +(allow mach-lookup (with telemetry) (global-name "com.apple.system.opendirectoryd.libinfo")
[webkit-changes] [283252] tags/Safari-612.2.6.1.3/
Title: [283252] tags/Safari-612.2.6.1.3/ Revision 283252 Author alanc...@apple.com Date 2021-09-29 12:49:44 -0700 (Wed, 29 Sep 2021) Log Message Tag Safari-612.2.6.1.3. Added Paths tags/Safari-612.2.6.1.3/ Diff ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [283251] branches/safari-612.2.6.1-branch/Source
Title: [283251] branches/safari-612.2.6.1-branch/Source Revision 283251 Author alanc...@apple.com Date 2021-09-29 12:46:48 -0700 (Wed, 29 Sep 2021) Log Message Versioning. WebKit-7612.2.6.1.3 Modified Paths branches/safari-612.2.6.1-branch/Source/_javascript_Core/Configurations/Version.xcconfig branches/safari-612.2.6.1-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig branches/safari-612.2.6.1-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig branches/safari-612.2.6.1-branch/Source/WebCore/Configurations/Version.xcconfig branches/safari-612.2.6.1-branch/Source/WebCore/PAL/Configurations/Version.xcconfig branches/safari-612.2.6.1-branch/Source/WebInspectorUI/Configurations/Version.xcconfig branches/safari-612.2.6.1-branch/Source/WebKit/Configurations/Version.xcconfig branches/safari-612.2.6.1-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig Diff Modified: branches/safari-612.2.6.1-branch/Source/_javascript_Core/Configurations/Version.xcconfig (283250 => 283251) --- branches/safari-612.2.6.1-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2021-09-29 19:45:09 UTC (rev 283250) +++ branches/safari-612.2.6.1-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2021-09-29 19:46:48 UTC (rev 283251) @@ -25,7 +25,7 @@ MINOR_VERSION = 2; TINY_VERSION = 6; MICRO_VERSION = 1; -NANO_VERSION = 2; +NANO_VERSION = 3; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-612.2.6.1-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig (283250 => 283251) --- branches/safari-612.2.6.1-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig 2021-09-29 19:45:09 UTC (rev 283250) +++ branches/safari-612.2.6.1-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig 2021-09-29 19:46:48 UTC (rev 283251) @@ -25,7 +25,7 @@ MINOR_VERSION = 2; TINY_VERSION = 6; MICRO_VERSION = 1; -NANO_VERSION = 2; +NANO_VERSION = 3; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-612.2.6.1-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (283250 => 283251) --- branches/safari-612.2.6.1-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig 2021-09-29 19:45:09 UTC (rev 283250) +++ branches/safari-612.2.6.1-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig 2021-09-29 19:46:48 UTC (rev 283251) @@ -25,7 +25,7 @@ MINOR_VERSION = 2; TINY_VERSION = 6; MICRO_VERSION = 1; -NANO_VERSION = 2; +NANO_VERSION = 3; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-612.2.6.1-branch/Source/WebCore/Configurations/Version.xcconfig (283250 => 283251) --- branches/safari-612.2.6.1-branch/Source/WebCore/Configurations/Version.xcconfig 2021-09-29 19:45:09 UTC (rev 283250) +++ branches/safari-612.2.6.1-branch/Source/WebCore/Configurations/Version.xcconfig 2021-09-29 19:46:48 UTC (rev 283251) @@ -25,7 +25,7 @@ MINOR_VERSION = 2; TINY_VERSION = 6; MICRO_VERSION = 1; -NANO_VERSION = 2; +NANO_VERSION = 3; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-612.2.6.1-branch/Source/WebCore/PAL/Configurations/Version.xcconfig (283250 => 283251) --- branches/safari-612.2.6.1-branch/Source/WebCore/PAL/Configurations/Version.xcconfig 2021-09-29 19:45:09 UTC (rev 283250) +++ branches/safari-612.2.6.1-branch/Source/WebCore/PAL/Configurations/Version.xcconfig 2021-09-29 19:46:48 UTC (rev 283251) @@ -25,7 +25,7 @@ MINOR_VERSION = 2; TINY_VERSION = 6; MICRO_VERSION = 1; -NANO_VERSION = 2; +NANO_VERSION = 3; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-612.2.6.1-branch/Source/WebInspectorUI/Configurations/Version.xcconfig (283250 => 283251) --- branches/safari-612.2.6.1-branch/Source/WebInspectorUI/Configurations/Version.xcconfig 2021-09-29 19:45:09 UTC (rev 283250) +++ branches/safari-612.2.6.1-branch/Source/WebInspectorUI/Configurations/Version.xcconfig 2021-09-29 19:46:48 UTC (rev 283251) @@ -2,7 +2,7 @@ MINOR_VERSION = 2; TINY_VERSION = 6; MICRO_VERSION = 1; -NANO_VERSION = 2; +NANO_VERSION = 3; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NAN
[webkit-changes] [283250] branches/safari-612.2.9.1-branch/Source/WebKitLegacy/mac
Title: [283250] branches/safari-612.2.9.1-branch/Source/WebKitLegacy/mac
Revision 283250
Author alanc...@apple.com
Date 2021-09-29 12:45:09 -0700 (Wed, 29 Sep 2021)
Log Message
Cherry-pick r283225. rdar://problem/83683566
Make WebLocalizedString() thread-safe
https://bugs.webkit.org/show_bug.cgi?id=230954
Reviewed by Alexey Proskuryakov.
Make WebLocalizedString() thread-safe. It takes minimal effort to make it thread-safe given
that the NSBundle API is thread-safe [1] and clients keep calling it on the background thread.
[1] https://developer.apple.com/documentation/foundation/nslocalizedstringwithdefaultvalue
"As of OS X 10.11 and iOS 9, NSBundle is thread-safe. As such, you can safely call
NSLocalizedStringWithDefaultValue from any execution context."
* Misc/WebLocalizableStrings.mm:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@283225 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Modified Paths
branches/safari-612.2.9.1-branch/Source/WebKitLegacy/mac/ChangeLog
branches/safari-612.2.9.1-branch/Source/WebKitLegacy/mac/Misc/WebLocalizableStrings.mm
Diff
Modified: branches/safari-612.2.9.1-branch/Source/WebKitLegacy/mac/ChangeLog (283249 => 283250)
--- branches/safari-612.2.9.1-branch/Source/WebKitLegacy/mac/ChangeLog 2021-09-29 19:43:45 UTC (rev 283249)
+++ branches/safari-612.2.9.1-branch/Source/WebKitLegacy/mac/ChangeLog 2021-09-29 19:45:09 UTC (rev 283250)
@@ -1,3 +1,40 @@
+2021-09-29 Alan Coon
+
+Cherry-pick r283225. rdar://problem/83683566
+
+Make WebLocalizedString() thread-safe
+https://bugs.webkit.org/show_bug.cgi?id=230954
+
+Reviewed by Alexey Proskuryakov.
+
+Make WebLocalizedString() thread-safe. It takes minimal effort to make it thread-safe given
+that the NSBundle API is thread-safe [1] and clients keep calling it on the background thread.
+
+[1] https://developer.apple.com/documentation/foundation/nslocalizedstringwithdefaultvalue
+"As of OS X 10.11 and iOS 9, NSBundle is thread-safe. As such, you can safely call
+ NSLocalizedStringWithDefaultValue from any execution context."
+
+* Misc/WebLocalizableStrings.mm:
+
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@283225 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2021-09-29 Chris Dumez
+
+Make WebLocalizedString() thread-safe
+https://bugs.webkit.org/show_bug.cgi?id=230954
+
+Reviewed by Alexey Proskuryakov.
+
+Make WebLocalizedString() thread-safe. It takes minimal effort to make it thread-safe given
+that the NSBundle API is thread-safe [1] and clients keep calling it on the background thread.
+
+[1] https://developer.apple.com/documentation/foundation/nslocalizedstringwithdefaultvalue
+"As of OS X 10.11 and iOS 9, NSBundle is thread-safe. As such, you can safely call
+ NSLocalizedStringWithDefaultValue from any execution context."
+
+* Misc/WebLocalizableStrings.mm:
+
2021-09-22 Alan Coon
Cherry-pick r282707. rdar://problem/83429953
Modified: branches/safari-612.2.9.1-branch/Source/WebKitLegacy/mac/Misc/WebLocalizableStrings.mm (283249 => 283250)
--- branches/safari-612.2.9.1-branch/Source/WebKitLegacy/mac/Misc/WebLocalizableStrings.mm 2021-09-29 19:43:45 UTC (rev 283249)
+++ branches/safari-612.2.9.1-branch/Source/WebKitLegacy/mac/Misc/WebLocalizableStrings.mm 2021-09-29 19:45:09 UTC (rev 283250)
@@ -37,17 +37,13 @@
NSString *WebLocalizedString(WebLocalizableStringsBundle *stringsBundle, const char *key)
{
-// This function is not thread-safe due at least to its unguarded use of the mainBundle static variable
-// and its use of [NSBundle localizedStringForKey:::], which is not guaranteed to be thread-safe. If
-// we decide we need to use this on background threads, we'll need to add locking here and make sure
-// it doesn't affect performance.
-#if !PLATFORM(IOS_FAMILY)
-ASSERT(isMainThread());
-#endif
-
NSBundle *bundle;
if (stringsBundle == NULL) {
-static NeverDestroyed> mainBundle = [NSBundle mainBundle];
+static LazyNeverDestroyed> mainBundle;
+static std::once_flag flag;
+std::call_once(flag, [] () {
+mainBundle.construct([NSBundle mainBundle]);
+});
ASSERT(mainBundle.get());
bundle = mainBundle.get().get();
} else {
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [283249] branches/safari-612.2.9.0-branch/Source/WebKitLegacy/mac
Title: [283249] branches/safari-612.2.9.0-branch/Source/WebKitLegacy/mac
Revision 283249
Author alanc...@apple.com
Date 2021-09-29 12:43:45 -0700 (Wed, 29 Sep 2021)
Log Message
Cherry-pick r283225. rdar://problem/83683557
Make WebLocalizedString() thread-safe
https://bugs.webkit.org/show_bug.cgi?id=230954
Reviewed by Alexey Proskuryakov.
Make WebLocalizedString() thread-safe. It takes minimal effort to make it thread-safe given
that the NSBundle API is thread-safe [1] and clients keep calling it on the background thread.
[1] https://developer.apple.com/documentation/foundation/nslocalizedstringwithdefaultvalue
"As of OS X 10.11 and iOS 9, NSBundle is thread-safe. As such, you can safely call
NSLocalizedStringWithDefaultValue from any execution context."
* Misc/WebLocalizableStrings.mm:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@283225 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Modified Paths
branches/safari-612.2.9.0-branch/Source/WebKitLegacy/mac/ChangeLog
branches/safari-612.2.9.0-branch/Source/WebKitLegacy/mac/Misc/WebLocalizableStrings.mm
Diff
Modified: branches/safari-612.2.9.0-branch/Source/WebKitLegacy/mac/ChangeLog (283248 => 283249)
--- branches/safari-612.2.9.0-branch/Source/WebKitLegacy/mac/ChangeLog 2021-09-29 19:21:03 UTC (rev 283248)
+++ branches/safari-612.2.9.0-branch/Source/WebKitLegacy/mac/ChangeLog 2021-09-29 19:43:45 UTC (rev 283249)
@@ -1,3 +1,40 @@
+2021-09-29 Alan Coon
+
+Cherry-pick r283225. rdar://problem/83683557
+
+Make WebLocalizedString() thread-safe
+https://bugs.webkit.org/show_bug.cgi?id=230954
+
+Reviewed by Alexey Proskuryakov.
+
+Make WebLocalizedString() thread-safe. It takes minimal effort to make it thread-safe given
+that the NSBundle API is thread-safe [1] and clients keep calling it on the background thread.
+
+[1] https://developer.apple.com/documentation/foundation/nslocalizedstringwithdefaultvalue
+"As of OS X 10.11 and iOS 9, NSBundle is thread-safe. As such, you can safely call
+ NSLocalizedStringWithDefaultValue from any execution context."
+
+* Misc/WebLocalizableStrings.mm:
+
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@283225 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2021-09-29 Chris Dumez
+
+Make WebLocalizedString() thread-safe
+https://bugs.webkit.org/show_bug.cgi?id=230954
+
+Reviewed by Alexey Proskuryakov.
+
+Make WebLocalizedString() thread-safe. It takes minimal effort to make it thread-safe given
+that the NSBundle API is thread-safe [1] and clients keep calling it on the background thread.
+
+[1] https://developer.apple.com/documentation/foundation/nslocalizedstringwithdefaultvalue
+"As of OS X 10.11 and iOS 9, NSBundle is thread-safe. As such, you can safely call
+ NSLocalizedStringWithDefaultValue from any execution context."
+
+* Misc/WebLocalizableStrings.mm:
+
2021-09-22 Alan Coon
Cherry-pick r282707. rdar://problem/83429953
Modified: branches/safari-612.2.9.0-branch/Source/WebKitLegacy/mac/Misc/WebLocalizableStrings.mm (283248 => 283249)
--- branches/safari-612.2.9.0-branch/Source/WebKitLegacy/mac/Misc/WebLocalizableStrings.mm 2021-09-29 19:21:03 UTC (rev 283248)
+++ branches/safari-612.2.9.0-branch/Source/WebKitLegacy/mac/Misc/WebLocalizableStrings.mm 2021-09-29 19:43:45 UTC (rev 283249)
@@ -37,17 +37,13 @@
NSString *WebLocalizedString(WebLocalizableStringsBundle *stringsBundle, const char *key)
{
-// This function is not thread-safe due at least to its unguarded use of the mainBundle static variable
-// and its use of [NSBundle localizedStringForKey:::], which is not guaranteed to be thread-safe. If
-// we decide we need to use this on background threads, we'll need to add locking here and make sure
-// it doesn't affect performance.
-#if !PLATFORM(IOS_FAMILY)
-ASSERT(isMainThread());
-#endif
-
NSBundle *bundle;
if (stringsBundle == NULL) {
-static NeverDestroyed> mainBundle = [NSBundle mainBundle];
+static LazyNeverDestroyed> mainBundle;
+static std::once_flag flag;
+std::call_once(flag, [] () {
+mainBundle.construct([NSBundle mainBundle]);
+});
ASSERT(mainBundle.get());
bundle = mainBundle.get().get();
} else {
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [283248] branches/safari-612.2.9.0-branch/Source
Title: [283248] branches/safari-612.2.9.0-branch/Source Revision 283248 Author alanc...@apple.com Date 2021-09-29 12:21:03 -0700 (Wed, 29 Sep 2021) Log Message Cherry-pick r283156. rdar://problem/83648190 Vorbis decoder can't be instantiated - Remove workaround added in bug 228139 https://bugs.webkit.org/show_bug.cgi?id=230742 rdar://83484414 Reviewed by Eric Carlson. Source/WebKit: This is already covered by test; however this will fail on Monterey without the updated CoreMedia framework. * Scripts/process-entitlements.sh: Add new required entitlement. * WebProcess/cocoa/WebProcessCocoa.mm: (WebKit::WebProcess::initializeSandbox): Only have bug workaround on BigSur and earlier. Source/WTF: * wtf/PlatformUse.h: Add USE_VORBIS_AUDIOCOMPONENT_WORKAROUND git-svn-id: https://svn.webkit.org/repository/webkit/trunk@283156 268f45cc-cd09-0410-ab3c-d52691b4dbfc Modified Paths branches/safari-612.2.9.0-branch/Source/WTF/ChangeLog branches/safari-612.2.9.0-branch/Source/WTF/wtf/PlatformUse.h branches/safari-612.2.9.0-branch/Source/WebKit/ChangeLog branches/safari-612.2.9.0-branch/Source/WebKit/Scripts/process-entitlements.sh branches/safari-612.2.9.0-branch/Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm Diff Modified: branches/safari-612.2.9.0-branch/Source/WTF/ChangeLog (283247 => 283248) --- branches/safari-612.2.9.0-branch/Source/WTF/ChangeLog 2021-09-29 19:19:43 UTC (rev 283247) +++ branches/safari-612.2.9.0-branch/Source/WTF/ChangeLog 2021-09-29 19:21:03 UTC (rev 283248) @@ -1,3 +1,39 @@ +2021-09-29 Alan Coon + +Cherry-pick r283156. rdar://problem/83648190 + +Vorbis decoder can't be instantiated - Remove workaround added in bug 228139 +https://bugs.webkit.org/show_bug.cgi?id=230742 +rdar://83484414 + +Reviewed by Eric Carlson. + +Source/WebKit: + +This is already covered by test; however this will fail on Monterey without the updated +CoreMedia framework. + +* Scripts/process-entitlements.sh: Add new required entitlement. +* WebProcess/cocoa/WebProcessCocoa.mm: +(WebKit::WebProcess::initializeSandbox): Only have bug workaround on BigSur and earlier. + +Source/WTF: + +* wtf/PlatformUse.h: Add USE_VORBIS_AUDIOCOMPONENT_WORKAROUND + + +git-svn-id: https://svn.webkit.org/repository/webkit/trunk@283156 268f45cc-cd09-0410-ab3c-d52691b4dbfc + +2021-09-27 Jean-Yves Avenard + +Vorbis decoder can't be instantiated - Remove workaround added in bug 228139 +https://bugs.webkit.org/show_bug.cgi?id=230742 +rdar://83484414 + +Reviewed by Eric Carlson. + +* wtf/PlatformUse.h: Add USE_VORBIS_AUDIOCOMPONENT_WORKAROUND + 2021-09-23 Russell Epstein Cherry-pick r281910. rdar://problem/83429926 Modified: branches/safari-612.2.9.0-branch/Source/WTF/wtf/PlatformUse.h (283247 => 283248) --- branches/safari-612.2.9.0-branch/Source/WTF/wtf/PlatformUse.h 2021-09-29 19:19:43 UTC (rev 283247) +++ branches/safari-612.2.9.0-branch/Source/WTF/wtf/PlatformUse.h 2021-09-29 19:21:03 UTC (rev 283248) @@ -347,3 +347,6 @@ #endif #endif +#if PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED < 12 +#define USE_VORBIS_AUDIOCOMPONENT_WORKAROUND 1 +#endif Modified: branches/safari-612.2.9.0-branch/Source/WebKit/ChangeLog (283247 => 283248) --- branches/safari-612.2.9.0-branch/Source/WebKit/ChangeLog 2021-09-29 19:19:43 UTC (rev 283247) +++ branches/safari-612.2.9.0-branch/Source/WebKit/ChangeLog 2021-09-29 19:21:03 UTC (rev 283248) @@ -1,3 +1,44 @@ +2021-09-29 Alan Coon + +Cherry-pick r283156. rdar://problem/83648190 + +Vorbis decoder can't be instantiated - Remove workaround added in bug 228139 +https://bugs.webkit.org/show_bug.cgi?id=230742 +rdar://83484414 + +Reviewed by Eric Carlson. + +Source/WebKit: + +This is already covered by test; however this will fail on Monterey without the updated +CoreMedia framework. + +* Scripts/process-entitlements.sh: Add new required entitlement. +* WebProcess/cocoa/WebProcessCocoa.mm: +(WebKit::WebProcess::initializeSandbox): Only have bug workaround on BigSur and earlier. + +Source/WTF: + +* wtf/PlatformUse.h: Add USE_VORBIS_AUDIOCOMPONENT_WORKAROUND + + +git-svn-id: https://svn.webkit.org/repository/webkit/trunk@283156 268f45cc-cd09-0410-ab3c-d52691b4dbfc + +2021-09-27 Jean-Yves Avenard + +Vorbis decoder can't be instantiated - Remove workaround added in bug 228139 +https://bugs.webkit.org/show_bug.cgi?id=230742 +rdar://83484414 + +Reviewed by Eric Carlson. + +This is already covered by test; however this will fail on Monterey without the updated +CoreMedia framework. + +* Scripts/process-entitlements.sh: Add new required entitlement. +* WebProcess/cocoa/Web
[webkit-changes] [283247] branches/safari-612.2.9.0-branch/Source
Title: [283247] branches/safari-612.2.9.0-branch/Source Revision 283247 Author alanc...@apple.com Date 2021-09-29 12:19:43 -0700 (Wed, 29 Sep 2021) Log Message Versioning. WebKit-7612.2.9.0.1 Modified Paths branches/safari-612.2.9.0-branch/Source/_javascript_Core/Configurations/Version.xcconfig branches/safari-612.2.9.0-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig branches/safari-612.2.9.0-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig branches/safari-612.2.9.0-branch/Source/WebCore/Configurations/Version.xcconfig branches/safari-612.2.9.0-branch/Source/WebCore/PAL/Configurations/Version.xcconfig branches/safari-612.2.9.0-branch/Source/WebInspectorUI/Configurations/Version.xcconfig branches/safari-612.2.9.0-branch/Source/WebKit/Configurations/Version.xcconfig branches/safari-612.2.9.0-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig Diff Modified: branches/safari-612.2.9.0-branch/Source/_javascript_Core/Configurations/Version.xcconfig (283246 => 283247) --- branches/safari-612.2.9.0-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2021-09-29 19:17:59 UTC (rev 283246) +++ branches/safari-612.2.9.0-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2021-09-29 19:19:43 UTC (rev 283247) @@ -25,8 +25,8 @@ MINOR_VERSION = 2; TINY_VERSION = 9; MICRO_VERSION = 0; -NANO_VERSION = 0; -FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); +NANO_VERSION = 1; +FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION)); Modified: branches/safari-612.2.9.0-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig (283246 => 283247) --- branches/safari-612.2.9.0-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig 2021-09-29 19:17:59 UTC (rev 283246) +++ branches/safari-612.2.9.0-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig 2021-09-29 19:19:43 UTC (rev 283247) @@ -25,8 +25,8 @@ MINOR_VERSION = 2; TINY_VERSION = 9; MICRO_VERSION = 0; -NANO_VERSION = 0; -FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); +NANO_VERSION = 1; +FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION)); Modified: branches/safari-612.2.9.0-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (283246 => 283247) --- branches/safari-612.2.9.0-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig 2021-09-29 19:17:59 UTC (rev 283246) +++ branches/safari-612.2.9.0-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig 2021-09-29 19:19:43 UTC (rev 283247) @@ -25,8 +25,8 @@ MINOR_VERSION = 2; TINY_VERSION = 9; MICRO_VERSION = 0; -NANO_VERSION = 0; -FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); +NANO_VERSION = 1; +FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION)); Modified: branches/safari-612.2.9.0-branch/Source/WebCore/Configurations/Version.xcconfig (283246 => 283247) --- branches/safari-612.2.9.0-branch/Source/WebCore/Configurations/Version.xcconfig 2021-09-29 19:17:59 UTC (rev 283246) +++ branches/safari-612.2.9.0-branch/Source/WebCore/Configurations/Version.xcconfig 2021-09-29 19:19:43 UTC (rev 283247) @@ -25,8 +25,8 @@ MINOR_VERSION = 2; TINY_VERSION = 9; MICRO_VERSION = 0; -NANO_VERSION = 0; -FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); +NANO_VERSION = 1; +FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION)); Modified: branches/safari-612.2.9.0-branch/Source/WebCore/PAL/Configurations/Version.xcconfig (283246 => 283247) --- branches/safari-612.2.9.0-branch/Source/WebCore/PAL/Configurations/Version.xcconfig 2021-09-29 19:17:59 UTC (rev 283246) +++ branches/safari-612.2.9.0-branch/Source/WebCore/PAL/Configurations/Version.xcconfig 2021-09-29 19:19:43 UTC (rev 283247) @@ -25,8 +25,8 @@ MINOR_VERSION = 2; TINY_VERSION = 9; MICRO_VERSION = 0; -NANO_VERSION = 0; -FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); +NANO_VERSION = 1; +FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. BUNDLE_VERSION = $(BUNDL
[webkit-changes] [283246] branches/safari-612.2.9.1-branch/Source/WebKit
Title: [283246] branches/safari-612.2.9.1-branch/Source/WebKit
Revision 283246
Author alanc...@apple.com
Date 2021-09-29 12:17:59 -0700 (Wed, 29 Sep 2021)
Log Message
Cherry-pick r283209. rdar://problem/83681911
Crash in WebKit::DisplayLink::displayLinkCallback()
https://bugs.webkit.org/show_bug.cgi?id=230917
Reviewed by Tim Horton.
We have evidence of a divide-by-zero crash in DisplayLink::notifyObserversDisplayWasRefreshed()
where m_currentUpdate.updatesPerSecond is zero. The only way I can see this happening
is if DisplayLink::DisplayLink() returns early, which should log. Protect against
this by initializing m_displayNominalFramesPerSecond to 60, and do another check,
with a log, in DisplayLink::addObserver() before we use m_displayNominalFramesPerSecond
for the first time.
Convert the logging to RELEASE_LOG_FAULT reports.
* UIProcess/mac/DisplayLink.cpp:
(WebKit::DisplayLink::DisplayLink):
(WebKit::DisplayLink::addObserver):
* UIProcess/mac/DisplayLink.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@283209 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Modified Paths
branches/safari-612.2.9.1-branch/Source/WebKit/ChangeLog
branches/safari-612.2.9.1-branch/Source/WebKit/UIProcess/mac/DisplayLink.cpp
branches/safari-612.2.9.1-branch/Source/WebKit/UIProcess/mac/DisplayLink.h
Diff
Modified: branches/safari-612.2.9.1-branch/Source/WebKit/ChangeLog (283245 => 283246)
--- branches/safari-612.2.9.1-branch/Source/WebKit/ChangeLog 2021-09-29 19:17:55 UTC (rev 283245)
+++ branches/safari-612.2.9.1-branch/Source/WebKit/ChangeLog 2021-09-29 19:17:59 UTC (rev 283246)
@@ -1,5 +1,54 @@
2021-09-29 Alan Coon
+Cherry-pick r283209. rdar://problem/83681911
+
+Crash in WebKit::DisplayLink::displayLinkCallback()
+https://bugs.webkit.org/show_bug.cgi?id=230917
+
+
+Reviewed by Tim Horton.
+
+We have evidence of a divide-by-zero crash in DisplayLink::notifyObserversDisplayWasRefreshed()
+where m_currentUpdate.updatesPerSecond is zero. The only way I can see this happening
+is if DisplayLink::DisplayLink() returns early, which should log. Protect against
+this by initializing m_displayNominalFramesPerSecond to 60, and do another check,
+with a log, in DisplayLink::addObserver() before we use m_displayNominalFramesPerSecond
+for the first time.
+
+Convert the logging to RELEASE_LOG_FAULT reports.
+
+* UIProcess/mac/DisplayLink.cpp:
+(WebKit::DisplayLink::DisplayLink):
+(WebKit::DisplayLink::addObserver):
+* UIProcess/mac/DisplayLink.h:
+
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@283209 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2021-09-28 Simon Fraser
+
+Crash in WebKit::DisplayLink::displayLinkCallback()
+https://bugs.webkit.org/show_bug.cgi?id=230917
+
+
+Reviewed by Tim Horton.
+
+We have evidence of a divide-by-zero crash in DisplayLink::notifyObserversDisplayWasRefreshed()
+where m_currentUpdate.updatesPerSecond is zero. The only way I can see this happening
+is if DisplayLink::DisplayLink() returns early, which should log. Protect against
+this by initializing m_displayNominalFramesPerSecond to 60, and do another check,
+with a log, in DisplayLink::addObserver() before we use m_displayNominalFramesPerSecond
+for the first time.
+
+Convert the logging to RELEASE_LOG_FAULT reports.
+
+* UIProcess/mac/DisplayLink.cpp:
+(WebKit::DisplayLink::DisplayLink):
+(WebKit::DisplayLink::addObserver):
+* UIProcess/mac/DisplayLink.h:
+
+2021-09-29 Alan Coon
+
Cherry-pick r283156. rdar://problem/83681765
Vorbis decoder can't be instantiated - Remove workaround added in bug 228139
Modified: branches/safari-612.2.9.1-branch/Source/WebKit/UIProcess/mac/DisplayLink.cpp (283245 => 283246)
--- branches/safari-612.2.9.1-branch/Source/WebKit/UIProcess/mac/DisplayLink.cpp 2021-09-29 19:17:55 UTC (rev 283245)
+++ branches/safari-612.2.9.1-branch/Source/WebKit/UIProcess/mac/DisplayLink.cpp 2021-09-29 19:17:59 UTC (rev 283246)
@@ -48,13 +48,13 @@
ASSERT(hasProcessPrivilege(ProcessPrivilege::CanCommunicateWithWindowServer));
CVReturn error = CVDisplayLinkCreateWithCGDisplay(displayID, &m_displayLink);
if (error) {
-WTFLogAlways("Could not create a display link for display %u: error %d", displayID, error);
+RELEASE_LOG_FAULT(DisplayLink, "Could not create a display link for display %u: error %d", displayID, error);
return;
}
error = CVDisplayLinkSetOutputCallback(m_displayLink, displayLinkCallback, this);
if (error) {
-WTFLogAlways("Could not set the display link output callback for display %u: error %d", displayID, error);
+RELEASE_LOG_FAULT(DisplayLink, "Displa
[webkit-changes] [283245] branches/safari-612.2.9.1-branch/Source
Title: [283245] branches/safari-612.2.9.1-branch/Source Revision 283245 Author alanc...@apple.com Date 2021-09-29 12:17:55 -0700 (Wed, 29 Sep 2021) Log Message Cherry-pick r283156. rdar://problem/83681765 Vorbis decoder can't be instantiated - Remove workaround added in bug 228139 https://bugs.webkit.org/show_bug.cgi?id=230742 rdar://83484414 Reviewed by Eric Carlson. Source/WebKit: This is already covered by test; however this will fail on Monterey without the updated CoreMedia framework. * Scripts/process-entitlements.sh: Add new required entitlement. * WebProcess/cocoa/WebProcessCocoa.mm: (WebKit::WebProcess::initializeSandbox): Only have bug workaround on BigSur and earlier. Source/WTF: * wtf/PlatformUse.h: Add USE_VORBIS_AUDIOCOMPONENT_WORKAROUND git-svn-id: https://svn.webkit.org/repository/webkit/trunk@283156 268f45cc-cd09-0410-ab3c-d52691b4dbfc Modified Paths branches/safari-612.2.9.1-branch/Source/WTF/ChangeLog branches/safari-612.2.9.1-branch/Source/WTF/wtf/PlatformUse.h branches/safari-612.2.9.1-branch/Source/WebKit/ChangeLog branches/safari-612.2.9.1-branch/Source/WebKit/Scripts/process-entitlements.sh branches/safari-612.2.9.1-branch/Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm Diff Modified: branches/safari-612.2.9.1-branch/Source/WTF/ChangeLog (283244 => 283245) --- branches/safari-612.2.9.1-branch/Source/WTF/ChangeLog 2021-09-29 19:17:38 UTC (rev 283244) +++ branches/safari-612.2.9.1-branch/Source/WTF/ChangeLog 2021-09-29 19:17:55 UTC (rev 283245) @@ -1,3 +1,39 @@ +2021-09-29 Alan Coon + +Cherry-pick r283156. rdar://problem/83681765 + +Vorbis decoder can't be instantiated - Remove workaround added in bug 228139 +https://bugs.webkit.org/show_bug.cgi?id=230742 +rdar://83484414 + +Reviewed by Eric Carlson. + +Source/WebKit: + +This is already covered by test; however this will fail on Monterey without the updated +CoreMedia framework. + +* Scripts/process-entitlements.sh: Add new required entitlement. +* WebProcess/cocoa/WebProcessCocoa.mm: +(WebKit::WebProcess::initializeSandbox): Only have bug workaround on BigSur and earlier. + +Source/WTF: + +* wtf/PlatformUse.h: Add USE_VORBIS_AUDIOCOMPONENT_WORKAROUND + + +git-svn-id: https://svn.webkit.org/repository/webkit/trunk@283156 268f45cc-cd09-0410-ab3c-d52691b4dbfc + +2021-09-27 Jean-Yves Avenard + +Vorbis decoder can't be instantiated - Remove workaround added in bug 228139 +https://bugs.webkit.org/show_bug.cgi?id=230742 +rdar://83484414 + +Reviewed by Eric Carlson. + +* wtf/PlatformUse.h: Add USE_VORBIS_AUDIOCOMPONENT_WORKAROUND + 2021-09-23 Russell Epstein Cherry-pick r281910. rdar://problem/83429926 Modified: branches/safari-612.2.9.1-branch/Source/WTF/wtf/PlatformUse.h (283244 => 283245) --- branches/safari-612.2.9.1-branch/Source/WTF/wtf/PlatformUse.h 2021-09-29 19:17:38 UTC (rev 283244) +++ branches/safari-612.2.9.1-branch/Source/WTF/wtf/PlatformUse.h 2021-09-29 19:17:55 UTC (rev 283245) @@ -347,3 +347,6 @@ #endif #endif +#if PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED < 12 +#define USE_VORBIS_AUDIOCOMPONENT_WORKAROUND 1 +#endif Modified: branches/safari-612.2.9.1-branch/Source/WebKit/ChangeLog (283244 => 283245) --- branches/safari-612.2.9.1-branch/Source/WebKit/ChangeLog 2021-09-29 19:17:38 UTC (rev 283244) +++ branches/safari-612.2.9.1-branch/Source/WebKit/ChangeLog 2021-09-29 19:17:55 UTC (rev 283245) @@ -1,3 +1,44 @@ +2021-09-29 Alan Coon + +Cherry-pick r283156. rdar://problem/83681765 + +Vorbis decoder can't be instantiated - Remove workaround added in bug 228139 +https://bugs.webkit.org/show_bug.cgi?id=230742 +rdar://83484414 + +Reviewed by Eric Carlson. + +Source/WebKit: + +This is already covered by test; however this will fail on Monterey without the updated +CoreMedia framework. + +* Scripts/process-entitlements.sh: Add new required entitlement. +* WebProcess/cocoa/WebProcessCocoa.mm: +(WebKit::WebProcess::initializeSandbox): Only have bug workaround on BigSur and earlier. + +Source/WTF: + +* wtf/PlatformUse.h: Add USE_VORBIS_AUDIOCOMPONENT_WORKAROUND + + +git-svn-id: https://svn.webkit.org/repository/webkit/trunk@283156 268f45cc-cd09-0410-ab3c-d52691b4dbfc + +2021-09-27 Jean-Yves Avenard + +Vorbis decoder can't be instantiated - Remove workaround added in bug 228139 +https://bugs.webkit.org/show_bug.cgi?id=230742 +rdar://83484414 + +Reviewed by Eric Carlson. + +This is already covered by test; however this will fail on Monterey without the updated +CoreMedia framework. + +* Scripts/process-entitlements.sh: Add new required entitlement. +* WebProcess/cocoa/Web
[webkit-changes] [283244] trunk/LayoutTests/imported/w3c
Title: [283244] trunk/LayoutTests/imported/w3c
Revision 283244
Author mmaxfi...@apple.com
Date 2021-09-29 12:17:38 -0700 (Wed, 29 Sep 2021)
Log Message
Update WPT's IDL for font palettes
https://bugs.webkit.org/show_bug.cgi?id=230794
Reviewed by Tim Horton.
Updating to the latest spec.
* web-platform-tests/css/css-fonts/idlharness-expected.txt:
* web-platform-tests/interfaces/css-fonts.idl:
Modified Paths
trunk/LayoutTests/imported/w3c/ChangeLog
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/idlharness-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/interfaces/css-fonts.idl
Diff
Modified: trunk/LayoutTests/imported/w3c/ChangeLog (283243 => 283244)
--- trunk/LayoutTests/imported/w3c/ChangeLog 2021-09-29 19:16:30 UTC (rev 283243)
+++ trunk/LayoutTests/imported/w3c/ChangeLog 2021-09-29 19:17:38 UTC (rev 283244)
@@ -1,3 +1,16 @@
+2021-09-29 Myles C. Maxfield
+
+Update WPT's IDL for font palettes
+https://bugs.webkit.org/show_bug.cgi?id=230794
+
+
+Reviewed by Tim Horton.
+
+Updating to the latest spec.
+
+* web-platform-tests/css/css-fonts/idlharness-expected.txt:
+* web-platform-tests/interfaces/css-fonts.idl:
+
2021-09-29 Alexey Shvayka
[WebIDL] Align property order of DOM constructors with ECMA-262 counterparts
Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/idlharness-expected.txt (283243 => 283244)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/idlharness-expected.txt 2021-09-29 19:16:30 UTC (rev 283243)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/idlharness-expected.txt 2021-09-29 19:17:38 UTC (rev 283244)
@@ -40,8 +40,10 @@
PASS CSSFontPaletteValuesRule interface: existence and properties of interface prototype object
PASS CSSFontPaletteValuesRule interface: existence and properties of interface prototype object's "constructor" property
PASS CSSFontPaletteValuesRule interface: existence and properties of interface prototype object's @@unscopables property
-FAIL CSSFontPaletteValuesRule interface: attribute fontFamily assert_equals: setter must be function for PutForwards, Replaceable, or non-readonly attributes expected "function" but got "undefined"
-FAIL CSSFontPaletteValuesRule interface: attribute basePalette assert_equals: setter must be function for PutForwards, Replaceable, or non-readonly attributes expected "function" but got "undefined"
+PASS CSSFontPaletteValuesRule interface: attribute name
+PASS CSSFontPaletteValuesRule interface: attribute fontFamily
+PASS CSSFontPaletteValuesRule interface: attribute basePalette
+PASS CSSFontPaletteValuesRule interface: attribute overrideColors
FAIL CSSRule interface: constant FONT_FEATURE_VALUES_RULE on interface object assert_own_property: expected property "FONT_FEATURE_VALUES_RULE" missing
FAIL CSSRule interface: constant FONT_FEATURE_VALUES_RULE on interface prototype object assert_own_property: expected property "FONT_FEATURE_VALUES_RULE" missing
FAIL CSSRule interface: cssRule must inherit property "FONT_FEATURE_VALUES_RULE" with the proper type assert_inherits: property "FONT_FEATURE_VALUES_RULE" not found in prototype chain
Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/interfaces/css-fonts.idl (283243 => 283244)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/interfaces/css-fonts.idl 2021-09-29 19:16:30 UTC (rev 283243)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/interfaces/css-fonts.idl 2021-09-29 19:17:38 UTC (rev 283244)
@@ -30,7 +30,8 @@
[Exposed=Window]
interface CSSFontPaletteValuesRule : CSSRule {
- maplike;
- attribute CSSOMString fontFamily;
- attribute CSSOMString basePalette;
+ readonly attribute CSSOMString name;
+ readonly attribute CSSOMString fontFamily;
+ readonly attribute CSSOMString basePalette;
+ readonly attribute CSSOMString overrideColors;
};
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [283243] branches/safari-612.2.9.1-branch/Source
Title: [283243] branches/safari-612.2.9.1-branch/Source Revision 283243 Author alanc...@apple.com Date 2021-09-29 12:16:30 -0700 (Wed, 29 Sep 2021) Log Message Versioning. WebKit-7612.2.9.1.1 Modified Paths branches/safari-612.2.9.1-branch/Source/_javascript_Core/Configurations/Version.xcconfig branches/safari-612.2.9.1-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig branches/safari-612.2.9.1-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig branches/safari-612.2.9.1-branch/Source/WebCore/Configurations/Version.xcconfig branches/safari-612.2.9.1-branch/Source/WebCore/PAL/Configurations/Version.xcconfig branches/safari-612.2.9.1-branch/Source/WebInspectorUI/Configurations/Version.xcconfig branches/safari-612.2.9.1-branch/Source/WebKit/Configurations/Version.xcconfig branches/safari-612.2.9.1-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig Diff Modified: branches/safari-612.2.9.1-branch/Source/_javascript_Core/Configurations/Version.xcconfig (283242 => 283243) --- branches/safari-612.2.9.1-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2021-09-29 18:42:05 UTC (rev 283242) +++ branches/safari-612.2.9.1-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2021-09-29 19:16:30 UTC (rev 283243) @@ -24,9 +24,9 @@ MAJOR_VERSION = 612; MINOR_VERSION = 2; TINY_VERSION = 9; -MICRO_VERSION = 0; -NANO_VERSION = 0; -FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); +MICRO_VERSION = 1; +NANO_VERSION = 1; +FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION)); Modified: branches/safari-612.2.9.1-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig (283242 => 283243) --- branches/safari-612.2.9.1-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig 2021-09-29 18:42:05 UTC (rev 283242) +++ branches/safari-612.2.9.1-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig 2021-09-29 19:16:30 UTC (rev 283243) @@ -24,9 +24,9 @@ MAJOR_VERSION = 612; MINOR_VERSION = 2; TINY_VERSION = 9; -MICRO_VERSION = 0; -NANO_VERSION = 0; -FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); +MICRO_VERSION = 1; +NANO_VERSION = 1; +FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION)); Modified: branches/safari-612.2.9.1-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (283242 => 283243) --- branches/safari-612.2.9.1-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig 2021-09-29 18:42:05 UTC (rev 283242) +++ branches/safari-612.2.9.1-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig 2021-09-29 19:16:30 UTC (rev 283243) @@ -24,9 +24,9 @@ MAJOR_VERSION = 612; MINOR_VERSION = 2; TINY_VERSION = 9; -MICRO_VERSION = 0; -NANO_VERSION = 0; -FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); +MICRO_VERSION = 1; +NANO_VERSION = 1; +FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION)); Modified: branches/safari-612.2.9.1-branch/Source/WebCore/Configurations/Version.xcconfig (283242 => 283243) --- branches/safari-612.2.9.1-branch/Source/WebCore/Configurations/Version.xcconfig 2021-09-29 18:42:05 UTC (rev 283242) +++ branches/safari-612.2.9.1-branch/Source/WebCore/Configurations/Version.xcconfig 2021-09-29 19:16:30 UTC (rev 283243) @@ -24,9 +24,9 @@ MAJOR_VERSION = 612; MINOR_VERSION = 2; TINY_VERSION = 9; -MICRO_VERSION = 0; -NANO_VERSION = 0; -FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); +MICRO_VERSION = 1; +NANO_VERSION = 1; +FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION)); Modified: branches/safari-612.2.9.1-branch/Source/WebCore/PAL/Configurations/Version.xcconfig (283242 => 283243) --- branches/safari-612.2.9.1-branch/Source/WebCore/PAL/Configurations/Version.xcconfig 2021-09-29 18:42:05 UTC (rev 283242) +++ branches/safari-612.2.9.1-branch/Source/WebCore/PAL/Configurations/Version.xcconfig 2021-09-29 19:16:30 UTC (rev 283243) @@ -24,9 +24,9 @@ MAJOR_VERSION = 612; MINOR_VERSION = 2; TINY_VERSION = 9; -MICRO_VERSION = 0; -NANO_VERSION = 0; -FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); +MICRO_VERSION = 1; +NANO_VERSION = 1; +FULL_VERSION = $(MAJOR_VE
[webkit-changes] [283242] branches/safari-612.2.9.3-branch/
Title: [283242] branches/safari-612.2.9.3-branch/ Revision 283242 Author alanc...@apple.com Date 2021-09-29 11:42:05 -0700 (Wed, 29 Sep 2021) Log Message New branch. Added Paths branches/safari-612.2.9.3-branch/ Diff ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [283241] branches/safari-612.2.9.2-branch/
Title: [283241] branches/safari-612.2.9.2-branch/ Revision 283241 Author alanc...@apple.com Date 2021-09-29 11:41:52 -0700 (Wed, 29 Sep 2021) Log Message New branch. Added Paths branches/safari-612.2.9.2-branch/ Diff ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [283240] branches/safari-612.2.9.1-branch/
Title: [283240] branches/safari-612.2.9.1-branch/ Revision 283240 Author alanc...@apple.com Date 2021-09-29 11:41:37 -0700 (Wed, 29 Sep 2021) Log Message New branch. Added Paths branches/safari-612.2.9.1-branch/ Diff ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [283239] branches/safari-612.2.9.0-branch/
Title: [283239] branches/safari-612.2.9.0-branch/ Revision 283239 Author alanc...@apple.com Date 2021-09-29 11:41:23 -0700 (Wed, 29 Sep 2021) Log Message New branch. Added Paths branches/safari-612.2.9.0-branch/ Diff ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [283238] trunk
Title: [283238] trunk Revision 283238 Author commit-qu...@webkit.org Date 2021-09-29 11:21:58 -0700 (Wed, 29 Sep 2021) Log Message MediaStream canvas.captureStream() fails for WebGL https://bugs.webkit.org/show_bug.cgi?id=230613 Patch by Kimmo Kinnunen on 2021-09-29 Reviewed by Youenn Fablet. .: Add a manual test to interact with media stream captureStream() behavior until the implementation is testable. * ManualTests/mediastream/mediastream-canvas-to-video.html: Added. Source/WebCore: Remove previous incorrect behavior of turning on "preservesDrawingBuffer" and sampling the drawing buffer. The drawing buffer is not what should ever be touched, rather it's the display buffer that should be available. Implement sampling of WebGL display buffer for media stream capture. The upon sampling, obtain a shared reference to the display buffer, passes it to media sample consuming process and mark the WebGL context display buffer non-eligible for recycling as new drawing buffer. Currently the implementation is displayed correctly for WebGL contents that is premultiplied. Unpremultiplied content is fixed in the associated bugs. Note: there are bugs preventing robust use of the API, listed in the associated bugs. As such, testing is not expanded in this bug. Tested by ManualTests/mediastream/mediastream-canvas-to-video.html (added) https://webrtc.github.io/samples/src/content/capture/canvas-video/ (Refresh the page or hide the window until MediaPlayer initialization flakyness lets rendering happen) The test LayoutTests/fast/mediastream/captureStream/canvas3d.html cannot yet be used to test the implementation as the rest of the captureStream() and playback implementation is so flaky. * Modules/mediastream/CanvasCaptureMediaStreamTrack.cpp: (WebCore::CanvasCaptureMediaStreamTrack::Source::canvasChanged): * html/HTMLCanvasElement.cpp: (WebCore::HTMLCanvasElement::toMediaSample): * html/canvas/WebGLRenderingContextBase.cpp: (WebCore::WebGLRenderingContextBase::paintCompositedResultsToMediaSample): * html/canvas/WebGLRenderingContextBase.h: (WebCore::WebGLRenderingContextBase::isPreservingDrawingBuffer const): * platform/graphics/GraphicsContextGL.cpp: * platform/graphics/GraphicsContextGL.h: * platform/graphics/RemoteGraphicsContextGLProxyBase.cpp: (WebCore::RemoteGraphicsContextGLProxyBase::paintCompositedResultsToMediaSample): * platform/graphics/RemoteGraphicsContextGLProxyBase.h: * platform/graphics/avfoundation/objc/MediaSampleAVFObjC.h: * platform/graphics/avfoundation/objc/MediaSampleAVFObjC.mm: (WebCore::MediaSampleAVFObjC::createImageSample): * platform/graphics/cocoa/GraphicsContextGLIOSurfaceSwapChain.cpp: (WebCore::GraphicsContextGLIOSurfaceSwapChain::present): * platform/graphics/cocoa/GraphicsContextGLIOSurfaceSwapChain.h: * platform/graphics/cocoa/GraphicsContextGLOpenGLCocoa.mm: (WebCore::GraphicsContextGLOpenGL::paintCompositedResultsToMediaSample): * platform/graphics/cocoa/RemoteGraphicsContextGLProxyBaseCocoa.mm: (WebCore::RemoteGraphicsContextGLProxyBase::paintCompositedResultsToMediaSample): * platform/graphics/opengl/GraphicsContextGLOpenGL.cpp: (WebCore::GraphicsContextGLOpenGL::paintCompositedResultsToMediaSample): * platform/graphics/opengl/GraphicsContextGLOpenGL.h: LayoutTests: Add new expectations, a warning was removed. CONSOLE MESSAGE: Turning drawing buffer preservation for the WebGL canvas being captured * fast/mediacapturefromelement/CanvasCaptureMediaStream-webgl-events-expected.txt: * fast/mediastream/captureStream/canvas3d-expected.txt: Modified Paths trunk/ChangeLog trunk/LayoutTests/ChangeLog trunk/LayoutTests/fast/mediacapturefromelement/CanvasCaptureMediaStream-webgl-events-expected.txt trunk/LayoutTests/fast/mediastream/captureStream/canvas3d-expected.txt trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/Modules/mediastream/CanvasCaptureMediaStreamTrack.cpp trunk/Source/WebCore/html/HTMLCanvasElement.cpp trunk/Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp trunk/Source/WebCore/html/canvas/WebGLRenderingContextBase.h trunk/Source/WebCore/platform/graphics/GraphicsContextGL.cpp trunk/Source/WebCore/platform/graphics/GraphicsContextGL.h trunk/Source/WebCore/platform/graphics/RemoteGraphicsContextGLProxyBase.cpp trunk/Source/WebCore/platform/graphics/RemoteGraphicsContextGLProxyBase.h trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaSampleAVFObjC.h trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaSampleAVFObjC.mm trunk/Source/WebCore/platform/graphics/cocoa/GraphicsContextGLIOSurfaceSwapChain.cpp trunk/Source/WebCore/platform/graphics/cocoa/GraphicsContextGLIOSurfaceSwapChain.h trunk/Source/WebCore/platform/graphics/cocoa/GraphicsContextGLOpenGLCocoa.mm trunk/Source/WebCore/platform/graphics/cocoa/RemoteGraphicsContextGLProxyBaseCocoa.mm trunk/Source/WebCore/platform/graphics/opengl/GraphicsContextGLOpenGL.cpp trunk/Source/WebCore/platform/graphics/opengl/GraphicsContextGLOpenGL.h Added Paths trunk/ManualTests/media
[webkit-changes] [283237] trunk
Title: [283237] trunk Revision 283237 Author jer.no...@apple.com Date 2021-09-29 11:19:46 -0700 (Wed, 29 Sep 2021) Log Message Build-time optimization: forward declare more things in MediaPlayer.h and HTMLMediaElement.h https://bugs.webkit.org/show_bug.cgi?id=230853 Reviewed by Eric Carlson. Source/WebCore: Forward-declare more things in MediaPlayer.h, and break apart *TrackPrivateClient into its own file, so that clients don't need to include the entire class's file. This requires other classes who got those includes "for free" previously to explicitly include headers in their source files. Drive-by fixes: Fixed a number of places where '0' was being used for 'null'. * Modules/encryptedmedia/legacy/LegacyCDMPrivateClearKey.cpp: * Modules/mediasource/MediaSource.cpp: * Modules/mediasource/SourceBuffer.cpp: * Modules/mediasource/SourceBuffer.h: * Modules/webaudio/ScriptProcessorNode.cpp: (WebCore::ScriptProcessorNode::initialize): * WebCore.xcodeproj/project.pbxproj: * animation/CSSPropertyAnimation.cpp: (WebCore::blendFilterOperations): * css/parser/CSSPropertyParser.cpp: (WebCore::consumeBasicShapeInset): (WebCore::consumeBorderImageSlice): (WebCore::consumeBorderImageOutset): * dom/Element.cpp: (WebCore::Element::getAttributeNodeNS): * dom/ScriptExecutionContext.cpp: (WebCore::ScriptExecutionContext::addConsoleMessage): * dom/TextEvent.cpp: (WebCore::TextEvent::createForPlainTextPaste): * editing/InsertListCommand.cpp: (WebCore::InsertListCommand::listifyParagraph): * html/HTMLMediaElement.cpp: * html/HTMLMediaElement.h: * html/track/AudioTrack.cpp: (WebCore::AudioTrack::AudioTrack): (WebCore::AudioTrack::~AudioTrack): (WebCore::AudioTrack::setPrivate): * html/track/AudioTrack.h: (WebCore::AudioTrackClient::audioTrackEnabledChanged): Deleted. (WebCore::AudioTrackClient::audioTrackIdChanged): Deleted. (WebCore::AudioTrackClient::audioTrackKindChanged): Deleted. (WebCore::AudioTrackClient::audioTrackLabelChanged): Deleted. (WebCore::AudioTrackClient::audioTrackLanguageChanged): Deleted. (WebCore::AudioTrackClient::willRemoveAudioTrack): Deleted. * html/track/AudioTrackClient.h: (WebCore::AudioTrackClient::audioTrackEnabledChanged): (WebCore::AudioTrackClient::audioTrackIdChanged): (WebCore::AudioTrackClient::audioTrackKindChanged): (WebCore::AudioTrackClient::audioTrackLabelChanged): (WebCore::AudioTrackClient::audioTrackLanguageChanged): (WebCore::AudioTrackClient::willRemoveAudioTrack): * html/track/InbandTextTrack.cpp: (WebCore::InbandTextTrack::InbandTextTrack): (WebCore::InbandTextTrack::~InbandTextTrack): (WebCore::InbandTextTrack::setPrivate): * html/track/VideoTrack.cpp: (WebCore::VideoTrack::VideoTrack): (WebCore::VideoTrack::~VideoTrack): (WebCore::VideoTrack::setPrivate): * html/track/VideoTrack.h: (WebCore::VideoTrackClient::videoTrackIdChanged): Deleted. (WebCore::VideoTrackClient::videoTrackKindChanged): Deleted. (WebCore::VideoTrackClient::videoTrackLabelChanged): Deleted. (WebCore::VideoTrackClient::videoTrackLanguageChanged): Deleted. (WebCore::VideoTrackClient::videoTrackSelectedChanged): Deleted. (WebCore::VideoTrackClient::willRemoveVideoTrack): Deleted. * html/track/VideoTrack.idl: * html/track/VideoTrackClient.h: (WebCore::VideoTrackClient::videoTrackIdChanged): (WebCore::VideoTrackClient::videoTrackKindChanged): (WebCore::VideoTrackClient::videoTrackLabelChanged): (WebCore::VideoTrackClient::videoTrackLanguageChanged): (WebCore::VideoTrackClient::videoTrackSelectedChanged): (WebCore::VideoTrackClient::willRemoveVideoTrack): * page/PageConsoleClient.cpp: (WebCore::PageConsoleClient::addMessage): * platform/graphics/AudioTrackPrivate.h: (WebCore::AudioTrackPrivate::setClient): (WebCore::AudioTrackPrivate::clearClient): * platform/graphics/AudioTrackPrivateClient.h: * platform/graphics/InbandTextTrackPrivate.h: (WebCore::InbandTextTrackPrivate::setClient): (WebCore::InbandTextTrackPrivate::clearClient): * platform/graphics/MediaPlayer.cpp: (WebCore::MediaPlayer::MediaPlayer): * platform/graphics/MediaPlayer.h: * platform/graphics/SourceBufferPrivate.cpp: * platform/graphics/TrackPrivateBase.h: * platform/graphics/TrackPrivateBaseClient.h: * platform/graphics/VideoTrackPrivate.h: (WebCore::VideoTrackPrivate::setClient): (WebCore::VideoTrackPrivate::clearClient): * platform/graphics/VideoTrackPrivateClient.h: * platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm: * platform/graphics/avfoundation/objc/WebCoreAVFResourceLoader.mm: * platform/graphics/cocoa/MediaEngineConfigurationFactoryCocoa.cpp: * platform/mock/mediasource/MockMediaSourcePrivate.h: * rendering/RenderEmbeddedObject.cpp: (WebCore::RenderEmbeddedObject::getReplacementTextGeometry const): * rendering/RenderSearchField.cpp: (WebCore::RenderSearchField::RenderSearchField): * rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::setFontFromControlSize const): * xml/parser/XMLDocumentParserLibxml2.cpp: (WebCore::XMLParserContext::createMemoryParser): Source/WebKit: Use new WeakPtr based cli
[webkit-changes] [283236] trunk/Source/JavaScriptCore
Title: [283236] trunk/Source/_javascript_Core
Revision 283236
Author ysuz...@apple.com
Date 2021-09-29 11:12:55 -0700 (Wed, 29 Sep 2021)
Log Message
[JSC] Remove CodeBlock::m_llintExecuteCounter
https://bugs.webkit.org/show_bug.cgi?id=230938
Reviewed by Keith Miller.
CodeBlock::m_llintExecuteCounter is a pointer pointing the middle of UnlinkedCodeBlock.
So this is not necessary to have this pointer separately to access to that from LLInt,
since loading UnlinkedCodeBlock and accessing to the middle of that do the same number
of loads.
* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::CodeBlock):
(JSC::CodeBlock::finalizeUnconditionally):
(JSC::CodeBlock::jitSoon):
(JSC::CodeBlock::jitNextInvocation):
* bytecode/CodeBlock.h:
(JSC::CodeBlock::checkIfJITThresholdReached):
(JSC::CodeBlock::dontJITAnytimeSoon):
(JSC::CodeBlock::llintExecuteCounter const):
(JSC::CodeBlock::addressOfJITExecuteCounter): Deleted.
* llint/LowLevelInterpreter.asm:
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/bytecode/CodeBlock.cpp
trunk/Source/_javascript_Core/bytecode/CodeBlock.h
trunk/Source/_javascript_Core/llint/LowLevelInterpreter.asm
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (283235 => 283236)
--- trunk/Source/_javascript_Core/ChangeLog 2021-09-29 18:05:07 UTC (rev 283235)
+++ trunk/Source/_javascript_Core/ChangeLog 2021-09-29 18:12:55 UTC (rev 283236)
@@ -1,3 +1,27 @@
+2021-09-29 Yusuke Suzuki
+
+[JSC] Remove CodeBlock::m_llintExecuteCounter
+https://bugs.webkit.org/show_bug.cgi?id=230938
+
+Reviewed by Keith Miller.
+
+CodeBlock::m_llintExecuteCounter is a pointer pointing the middle of UnlinkedCodeBlock.
+So this is not necessary to have this pointer separately to access to that from LLInt,
+since loading UnlinkedCodeBlock and accessing to the middle of that do the same number
+of loads.
+
+* bytecode/CodeBlock.cpp:
+(JSC::CodeBlock::CodeBlock):
+(JSC::CodeBlock::finalizeUnconditionally):
+(JSC::CodeBlock::jitSoon):
+(JSC::CodeBlock::jitNextInvocation):
+* bytecode/CodeBlock.h:
+(JSC::CodeBlock::checkIfJITThresholdReached):
+(JSC::CodeBlock::dontJITAnytimeSoon):
+(JSC::CodeBlock::llintExecuteCounter const):
+(JSC::CodeBlock::addressOfJITExecuteCounter): Deleted.
+* llint/LowLevelInterpreter.asm:
+
2021-09-29 Saam Barati
Code inside strength reduction can incorrectly prove that we know what lastIndex is
Modified: trunk/Source/_javascript_Core/bytecode/CodeBlock.cpp (283235 => 283236)
--- trunk/Source/_javascript_Core/bytecode/CodeBlock.cpp 2021-09-29 18:05:07 UTC (rev 283235)
+++ trunk/Source/_javascript_Core/bytecode/CodeBlock.cpp 2021-09-29 18:12:55 UTC (rev 283236)
@@ -307,8 +307,6 @@
ASSERT(source().provider());
setNumParameters(other.numParameters());
-m_llintExecuteCounter = &m_unlinkedCode->llintExecuteCounter();
-
vm.heap.codeBlockSet().add(this);
}
@@ -357,8 +355,6 @@
ASSERT(source().provider());
setNumParameters(unlinkedCodeBlock->numParameters());
-m_llintExecuteCounter = &m_unlinkedCode->llintExecuteCounter();
-
vm.heap.codeBlockSet().add(this);
}
@@ -1658,7 +1654,7 @@
case JITType::HostCallThunk:
return;
case JITType::InterpreterThunk:
-count = m_llintExecuteCounter->count();
+count = m_unlinkedCode->llintExecuteCounter().count();
break;
case JITType::BaselineJIT:
count = m_jitExecuteCounter.count();
@@ -3557,12 +3553,12 @@
void CodeBlock::jitSoon()
{
-m_llintExecuteCounter->setNewThreshold(unlinkedCodeBlock()->thresholdForJIT(Options::thresholdForJITSoon()), this);
+m_unlinkedCode->llintExecuteCounter().setNewThreshold(unlinkedCodeBlock()->thresholdForJIT(Options::thresholdForJITSoon()), this);
}
void CodeBlock::jitNextInvocation()
{
-m_llintExecuteCounter->setNewThreshold(0, this);
+m_unlinkedCode->llintExecuteCounter().setNewThreshold(0, this);
}
bool CodeBlock::hasInstalledVMTrapBreakpoints() const
Modified: trunk/Source/_javascript_Core/bytecode/CodeBlock.h (283235 => 283236)
--- trunk/Source/_javascript_Core/bytecode/CodeBlock.h 2021-09-29 18:05:07 UTC (rev 283235)
+++ trunk/Source/_javascript_Core/bytecode/CodeBlock.h 2021-09-29 18:12:55 UTC (rev 283236)
@@ -599,12 +599,12 @@
bool checkIfJITThresholdReached()
{
-return m_llintExecuteCounter->checkIfThresholdCrossedAndSet(this);
+return m_unlinkedCode->llintExecuteCounter().checkIfThresholdCrossedAndSet(this);
}
void dontJITAnytimeSoon()
{
-m_llintExecuteCounter->deferIndefinitely();
+m_unlinkedCode->llintExecuteCounter().deferIndefinitely();
}
void jitSoon();
@@ -612,7 +612,7 @@
const BaselineExecutionCounter& llintExecuteCounter() const
{
-return *m_llintExecuteCount
[webkit-changes] [283235] trunk/LayoutTests
Title: [283235] trunk/LayoutTests
Revision 283235
Author you...@apple.com
Date 2021-09-29 11:05:07 -0700 (Wed, 29 Sep 2021)
Log Message
[ iOS macOS wk2 ] webrtc/datachannel/mdns-ice-candidates.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=230700
Reviewed by Eric Carlson.
* platform/mac-wk2/TestExpectations:
* webrtc/datachannel/mdns-ice-candidates.html:
Close connections test after test.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac-wk2/TestExpectations
trunk/LayoutTests/webrtc/datachannel/mdns-ice-candidates.html
Diff
Modified: trunk/LayoutTests/ChangeLog (283234 => 283235)
--- trunk/LayoutTests/ChangeLog 2021-09-29 17:58:33 UTC (rev 283234)
+++ trunk/LayoutTests/ChangeLog 2021-09-29 18:05:07 UTC (rev 283235)
@@ -1,3 +1,15 @@
+2021-09-29 Youenn Fablet
+
+[ iOS macOS wk2 ] webrtc/datachannel/mdns-ice-candidates.html is a flaky failure
+https://bugs.webkit.org/show_bug.cgi?id=230700
+
+
+Reviewed by Eric Carlson.
+
+* platform/mac-wk2/TestExpectations:
+* webrtc/datachannel/mdns-ice-candidates.html:
+Close connections test after test.
+
2021-09-29 Ayumi Kojima
[ iOS ] fast/scrolling/ios/click-events-after-long-press-during-momentum-scroll-in-overflow.html is a flaky timeout.
Modified: trunk/LayoutTests/platform/mac-wk2/TestExpectations (283234 => 283235)
--- trunk/LayoutTests/platform/mac-wk2/TestExpectations 2021-09-29 17:58:33 UTC (rev 283234)
+++ trunk/LayoutTests/platform/mac-wk2/TestExpectations 2021-09-29 18:05:07 UTC (rev 283235)
@@ -1642,8 +1642,6 @@
webkit.org/b/209878 [ Debug ] webrtc/datachannel/multiple-connections.html [ Pass Failure Slow ]
-webkit.org/b/230700 webrtc/datachannel/mdns-ice-candidates.html [ Pass Failure ]
-
# rdar://82002352 ([ Monterey wk2 Release ] css3/blending/background-blend-mode-background-clip-content-box.html is flaky image failing)
[ Monterey Release ] css3/blending/background-blend-mode-background-clip-content-box.html [ Pass ImageOnlyFailure ]
Modified: trunk/LayoutTests/webrtc/datachannel/mdns-ice-candidates.html (283234 => 283235)
--- trunk/LayoutTests/webrtc/datachannel/mdns-ice-candidates.html 2021-09-29 17:58:33 UTC (rev 283234)
+++ trunk/LayoutTests/webrtc/datachannel/mdns-ice-candidates.html 2021-09-29 18:05:07 UTC (rev 283235)
@@ -68,6 +68,7 @@
});
assert_true(connection.localDescription.sdp.includes(".local "));
+closeConnections();
}, "Getting some MDNS candidates");
var finishTest;
@@ -86,6 +87,7 @@
});
setTimeout(() => { reject("Test timed out"); }, 5000);
});
+closeConnections();
}, "Basic data channel exchange from offerer to receiver");
promise_test((test) => {
@@ -103,6 +105,7 @@
});
setTimeout(() => { reject("Test timed out"); }, 5000);
});
+closeConnections();
}, "Basic data channel exchange from receiver to offerer");
@@ -121,6 +124,7 @@
}, { filterOutICECandidate: (candidate) => { return candidate && candidate.candidate.toLowerCase().indexOf("udp") == -1; } });
setTimeout(() => { reject("Test timed out"); }, 5000);
});
+closeConnections();
}, "Basic data channel exchange from offerer to receiver using UDP only");
promise_test((test) => {
@@ -149,6 +153,7 @@
});
setTimeout(() => { reject("Test timed out"); }, 5000);
});
+closeConnections();
}, "Basic data channel exchange from offerer to receiver 2");
promise_test(async (test) => {
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [283234] trunk/Source/WebCore
Title: [283234] trunk/Source/WebCore Revision 283234 Author za...@apple.com Date 2021-09-29 10:58:33 -0700 (Wed, 29 Sep 2021) Log Message [LFC][IFC] Layout::Box should be able to return the first-line style when applicable https://bugs.webkit.org/show_bug.cgi?id=230921 Reviewed by Antti Koivisto. This is in preparation for supporting first-line style. * layout/integration/LayoutIntegrationBoxTree.cpp: (WebCore::LayoutIntegration::rootBoxFirstLineStyle): (WebCore::LayoutIntegration::BoxTree::BoxTree): (WebCore::LayoutIntegration::BoxTree::buildTree): (WebCore::LayoutIntegration::BoxTree::updateStyle): * layout/layouttree/LayoutBox.cpp: (WebCore::Layout::Box::Box): Use the rare data to store first-line style. (WebCore::Layout::Box::updateStyle): * layout/layouttree/LayoutBox.h: (WebCore::Layout::Box::firstLineStyle const): * layout/layouttree/LayoutContainerBox.cpp: (WebCore::Layout::ContainerBox::ContainerBox): * layout/layouttree/LayoutContainerBox.h: (WebCore::Layout::ContainerBox::ContainerBox): * layout/layouttree/LayoutInitialContainingBlock.cpp: (WebCore::Layout::InitialContainingBlock::InitialContainingBlock): * layout/layouttree/LayoutInitialContainingBlock.h: * layout/layouttree/LayoutInlineTextBox.cpp: (WebCore::Layout::InlineTextBox::InlineTextBox): * layout/layouttree/LayoutInlineTextBox.h: * layout/layouttree/LayoutLineBreakBox.cpp: (WebCore::Layout::LineBreakBox::LineBreakBox): * layout/layouttree/LayoutLineBreakBox.h: * layout/layouttree/LayoutReplacedBox.cpp: (WebCore::Layout::ReplacedBox::ReplacedBox): * layout/layouttree/LayoutReplacedBox.h: Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/layout/integration/LayoutIntegrationBoxTree.cpp trunk/Source/WebCore/layout/layouttree/LayoutBox.cpp trunk/Source/WebCore/layout/layouttree/LayoutBox.h trunk/Source/WebCore/layout/layouttree/LayoutContainerBox.cpp trunk/Source/WebCore/layout/layouttree/LayoutContainerBox.h trunk/Source/WebCore/layout/layouttree/LayoutInitialContainingBlock.cpp trunk/Source/WebCore/layout/layouttree/LayoutInitialContainingBlock.h trunk/Source/WebCore/layout/layouttree/LayoutInlineTextBox.cpp trunk/Source/WebCore/layout/layouttree/LayoutInlineTextBox.h trunk/Source/WebCore/layout/layouttree/LayoutLineBreakBox.cpp trunk/Source/WebCore/layout/layouttree/LayoutLineBreakBox.h trunk/Source/WebCore/layout/layouttree/LayoutReplacedBox.cpp trunk/Source/WebCore/layout/layouttree/LayoutReplacedBox.h Diff Modified: trunk/Source/WebCore/ChangeLog (283233 => 283234) --- trunk/Source/WebCore/ChangeLog 2021-09-29 17:17:05 UTC (rev 283233) +++ trunk/Source/WebCore/ChangeLog 2021-09-29 17:58:33 UTC (rev 283234) @@ -1,3 +1,39 @@ +2021-09-29 Alan Bujtas + +[LFC][IFC] Layout::Box should be able to return the first-line style when applicable +https://bugs.webkit.org/show_bug.cgi?id=230921 + +Reviewed by Antti Koivisto. + +This is in preparation for supporting first-line style. + +* layout/integration/LayoutIntegrationBoxTree.cpp: +(WebCore::LayoutIntegration::rootBoxFirstLineStyle): +(WebCore::LayoutIntegration::BoxTree::BoxTree): +(WebCore::LayoutIntegration::BoxTree::buildTree): +(WebCore::LayoutIntegration::BoxTree::updateStyle): +* layout/layouttree/LayoutBox.cpp: +(WebCore::Layout::Box::Box): Use the rare data to store first-line style. +(WebCore::Layout::Box::updateStyle): +* layout/layouttree/LayoutBox.h: +(WebCore::Layout::Box::firstLineStyle const): +* layout/layouttree/LayoutContainerBox.cpp: +(WebCore::Layout::ContainerBox::ContainerBox): +* layout/layouttree/LayoutContainerBox.h: +(WebCore::Layout::ContainerBox::ContainerBox): +* layout/layouttree/LayoutInitialContainingBlock.cpp: +(WebCore::Layout::InitialContainingBlock::InitialContainingBlock): +* layout/layouttree/LayoutInitialContainingBlock.h: +* layout/layouttree/LayoutInlineTextBox.cpp: +(WebCore::Layout::InlineTextBox::InlineTextBox): +* layout/layouttree/LayoutInlineTextBox.h: +* layout/layouttree/LayoutLineBreakBox.cpp: +(WebCore::Layout::LineBreakBox::LineBreakBox): +* layout/layouttree/LayoutLineBreakBox.h: +* layout/layouttree/LayoutReplacedBox.cpp: +(WebCore::Layout::ReplacedBox::ReplacedBox): +* layout/layouttree/LayoutReplacedBox.h: + 2021-09-29 Alexey Shvayka [WebIDL] Align property order of DOM constructors with ECMA-262 counterparts Modified: trunk/Source/WebCore/layout/integration/LayoutIntegrationBoxTree.cpp (283233 => 283234) --- trunk/Source/WebCore/layout/integration/LayoutIntegrationBoxTree.cpp 2021-09-29 17:17:05 UTC (rev 283233) +++ trunk/Source/WebCore/layout/integration/LayoutIntegrationBoxTree.cpp 2021-09-29 17:58:33 UTC (rev 283234) @@ -43,6 +43,9 @@ static constexpr size_t smallTreeThreshold = 8; +// FIXME: see webkit.org/b/230964 +#define CAN_USE_FI
[webkit-changes] [283232] trunk
Title: [283232] trunk
Revision 283232
Author sbar...@apple.com
Date 2021-09-29 10:03:29 -0700 (Wed, 29 Sep 2021)
Log Message
Code inside strength reduction can incorrectly prove that we know what lastIndex is
https://bugs.webkit.org/show_bug.cgi?id=230802
Reviewed by Mark Lam.
JSTests:
* stress/dont-fold-regexp-exec-when-we-dont-know-last-index-and-regexp-is-constant.js: Added.
(assert):
(let.reg.RegExp.foo.g.doExec):
(noInline.doExec):
Source/_javascript_Core:
The phase was searching backwards in the graph to see if it found the RegExp
node. However, the RegExp node might be a JSConstant. Hence, the program
didn't allocate it. So we can't assume that we know what the lastIndex is.
We were incorrectly assuming it was "0" in a program like this:
a: JSConstant(RegExp)
b: RegExpExec(@a)
And we assumed we're invoking RegExpExec with lastIndex is 0, because we found
our RegExp in a backwards search. This is likely because we're also matching
NewRegExp nodes, in which case, it is valid to say lastIndex is 0.
This caused us to return a constant value that would've been the exec
result had we invoked it with a NewRegExpNode.
* dfg/DFGStrengthReductionPhase.cpp:
(JSC::DFG::StrengthReductionPhase::run):
(JSC::DFG::StrengthReductionPhase::handleNode):
Modified Paths
trunk/JSTests/ChangeLog
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/dfg/DFGStrengthReductionPhase.cpp
Added Paths
trunk/JSTests/stress/dont-fold-regexp-exec-when-we-dont-know-last-index-and-regexp-is-constant.js
Diff
Modified: trunk/JSTests/ChangeLog (283231 => 283232)
--- trunk/JSTests/ChangeLog 2021-09-29 16:56:07 UTC (rev 283231)
+++ trunk/JSTests/ChangeLog 2021-09-29 17:03:29 UTC (rev 283232)
@@ -1,5 +1,18 @@
2021-09-29 Saam Barati
+Code inside strength reduction can incorrectly prove that we know what lastIndex is
+https://bugs.webkit.org/show_bug.cgi?id=230802
+
+
+Reviewed by Mark Lam.
+
+* stress/dont-fold-regexp-exec-when-we-dont-know-last-index-and-regexp-is-constant.js: Added.
+(assert):
+(let.reg.RegExp.foo.g.doExec):
+(noInline.doExec):
+
+2021-09-29 Saam Barati
+
DoesGCCheck does not use enough bits for nodeIndex
https://bugs.webkit.org/show_bug.cgi?id=230915
Added: trunk/JSTests/stress/dont-fold-regexp-exec-when-we-dont-know-last-index-and-regexp-is-constant.js (0 => 283232)
--- trunk/JSTests/stress/dont-fold-regexp-exec-when-we-dont-know-last-index-and-regexp-is-constant.js (rev 0)
+++ trunk/JSTests/stress/dont-fold-regexp-exec-when-we-dont-know-last-index-and-regexp-is-constant.js 2021-09-29 17:03:29 UTC (rev 283232)
@@ -0,0 +1,19 @@
+function assert(b) {
+if (!b)
+throw new Error;
+}
+
+let reg = RegExp(/foo/g)
+function doExec() {
+return reg.exec("-foo");
+}
+noInline(doExec)
+
+for (let i = 0; i < 1000; ++i) {
+let r = doExec();
+if ((i % 2) === 0)
+assert(r[0] === "foo");
+else
+assert(r === null);
+}
+
Modified: trunk/Source/_javascript_Core/ChangeLog (283231 => 283232)
--- trunk/Source/_javascript_Core/ChangeLog 2021-09-29 16:56:07 UTC (rev 283231)
+++ trunk/Source/_javascript_Core/ChangeLog 2021-09-29 17:03:29 UTC (rev 283232)
@@ -1,3 +1,29 @@
+2021-09-29 Saam Barati
+
+Code inside strength reduction can incorrectly prove that we know what lastIndex is
+https://bugs.webkit.org/show_bug.cgi?id=230802
+
+
+Reviewed by Mark Lam.
+
+The phase was searching backwards in the graph to see if it found the RegExp
+node. However, the RegExp node might be a JSConstant. Hence, the program
+didn't allocate it. So we can't assume that we know what the lastIndex is.
+We were incorrectly assuming it was "0" in a program like this:
+a: JSConstant(RegExp)
+b: RegExpExec(@a)
+
+And we assumed we're invoking RegExpExec with lastIndex is 0, because we found
+our RegExp in a backwards search. This is likely because we're also matching
+NewRegExp nodes, in which case, it is valid to say lastIndex is 0.
+
+This caused us to return a constant value that would've been the exec
+result had we invoked it with a NewRegExpNode.
+
+* dfg/DFGStrengthReductionPhase.cpp:
+(JSC::DFG::StrengthReductionPhase::run):
+(JSC::DFG::StrengthReductionPhase::handleNode):
+
2021-09-29 Yusuke Suzuki
[JSC] Use FixedVector in JITConstantPool
Modified: trunk/Source/_javascript_Core/dfg/DFGStrengthReductionPhase.cpp (283231 => 283232)
--- trunk/Source/_javascript_Core/dfg/DFGStrengthReductionPhase.cpp 2021-09-29 16:56:07 UTC (rev 283231)
+++ trunk/Source/_javascript_Core/dfg/DFGStrengthReductionPhase.cpp 2021-09-29 17:03:29 UTC (rev 283232)
@@ -491,11 +491,13 @@
Node* regExpObjectNode = nullptr;
RegExp* regExp = nullptr;
+bool regExpObje
[webkit-changes] [283231] trunk/JSTests
Title: [283231] trunk/JSTests
Revision 283231
Author sbar...@apple.com
Date 2021-09-29 09:56:07 -0700 (Wed, 29 Sep 2021)
Log Message
DoesGCCheck does not use enough bits for nodeIndex
https://bugs.webkit.org/show_bug.cgi?id=230915
Unreviewed. Forgot to add a try/catch in the test.
* stress/verify-can-gc-node-index.js:
Modified Paths
trunk/JSTests/ChangeLog
trunk/JSTests/stress/verify-can-gc-node-index.js
Diff
Modified: trunk/JSTests/ChangeLog (283230 => 283231)
--- trunk/JSTests/ChangeLog 2021-09-29 16:54:57 UTC (rev 283230)
+++ trunk/JSTests/ChangeLog 2021-09-29 16:56:07 UTC (rev 283231)
@@ -1,3 +1,13 @@
+2021-09-29 Saam Barati
+
+DoesGCCheck does not use enough bits for nodeIndex
+https://bugs.webkit.org/show_bug.cgi?id=230915
+
+
+Unreviewed. Forgot to add a try/catch in the test.
+
+* stress/verify-can-gc-node-index.js:
+
2021-09-28 Saam Barati
DoesGCCheck does not use enough bits for nodeIndex
Modified: trunk/JSTests/stress/verify-can-gc-node-index.js (283230 => 283231)
--- trunk/JSTests/stress/verify-can-gc-node-index.js 2021-09-29 16:54:57 UTC (rev 283230)
+++ trunk/JSTests/stress/verify-can-gc-node-index.js 2021-09-29 16:56:07 UTC (rev 283231)
@@ -16,4 +16,6 @@
f();
f();
};
-f();
+try {
+f();
+} catch { }
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [283230] trunk/Tools
Title: [283230] trunk/Tools
Revision 283230
Author you...@apple.com
Date 2021-09-29 09:54:57 -0700 (Wed, 29 Sep 2021)
Log Message
WPT importer should create serviceworker template for templated test that have worker as global
https://bugs.webkit.org/show_bug.cgi?id=230943
Reviewed by Jonathan Bedard.
Tests with a worker global should run in all worker global scope (dedicated worker, shared worker and service worker).
Let's add service worker by default for now.
* Scripts/webkitpy/w3c/test_importer.py:
* Scripts/webkitpy/w3c/test_importer_unittest.py:
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/w3c/test_importer.py
trunk/Tools/Scripts/webkitpy/w3c/test_importer_unittest.py
Diff
Modified: trunk/Tools/ChangeLog (283229 => 283230)
--- trunk/Tools/ChangeLog 2021-09-29 16:44:10 UTC (rev 283229)
+++ trunk/Tools/ChangeLog 2021-09-29 16:54:57 UTC (rev 283230)
@@ -1,3 +1,16 @@
+2021-09-29 Youenn Fablet
+
+WPT importer should create serviceworker template for templated test that have worker as global
+https://bugs.webkit.org/show_bug.cgi?id=230943
+
+Reviewed by Jonathan Bedard.
+
+Tests with a worker global should run in all worker global scope (dedicated worker, shared worker and service worker).
+Let's add service worker by default for now.
+
+* Scripts/webkitpy/w3c/test_importer.py:
+* Scripts/webkitpy/w3c/test_importer_unittest.py:
+
2021-09-28 BJ Burg
[Cocoa] Add SPI to select a tab created by _WKInspectorExtension
Modified: trunk/Tools/Scripts/webkitpy/w3c/test_importer.py (283229 => 283230)
--- trunk/Tools/Scripts/webkitpy/w3c/test_importer.py 2021-09-29 16:44:10 UTC (rev 283229)
+++ trunk/Tools/Scripts/webkitpy/w3c/test_importer.py 2021-09-29 16:54:57 UTC (rev 283230)
@@ -421,7 +421,9 @@
items = line.split('META: global=', 1)[1].split(',')
suffixes = [self.globalToSuffix.get(item.strip(), '') for item in items]
environments = list(filter(None, set(suffixes)))
-return set(environments) if len(environments) else ['html', 'worker.html']
+if 'worker.html' in environments:
+environments.append('serviceworker.html')
+return set(environments) if len(environments) else ['html', 'worker.html', 'serviceworker.html']
def write_html_files_for_templated_js_tests(self, orig_filepath, new_filepath):
if (orig_filepath.endswith('.window.js')):
Modified: trunk/Tools/Scripts/webkitpy/w3c/test_importer_unittest.py (283229 => 283230)
--- trunk/Tools/Scripts/webkitpy/w3c/test_importer_unittest.py 2021-09-29 16:44:10 UTC (rev 283229)
+++ trunk/Tools/Scripts/webkitpy/w3c/test_importer_unittest.py 2021-09-29 16:54:57 UTC (rev 283230)
@@ -367,10 +367,12 @@
self.assertTrue(fs.exists('/mock-checkout/LayoutTests/w3c/web-platform-tests/t/test.html'))
self.assertTrue(fs.exists('/mock-checkout/LayoutTests/w3c/web-platform-tests/t/test.any.html'))
self.assertTrue(fs.exists('/mock-checkout/LayoutTests/w3c/web-platform-tests/t/test.any.worker.html'))
+self.assertTrue(fs.exists('/mock-checkout/LayoutTests/w3c/web-platform-tests/t/test.any.serviceworker.html'))
self.assertTrue('' in fs.read_text_file('/mock-checkout/LayoutTests/w3c/web-platform-tests/css/test.html').split('\n')[0])
self.assertTrue('' in fs.read_text_file('/mock-checkout/LayoutTests/w3c/web-platform-tests/t/test.html').split('\n')[0])
self.assertTrue('' in fs.read_text_file('/mock-checkout/LayoutTests/w3c/web-platform-tests/t/test.any.html').split('\n')[0])
self.assertFalse('' in fs.read_text_file('/mock-checkout/LayoutTests/w3c/web-platform-tests/t/test.any.worker.html').split('\n')[0])
+self.assertFalse('' in fs.read_text_file('/mock-checkout/LayoutTests/w3c/web-platform-tests/t/test.any.serviceworker.html').split('\n')[0])
def test_webkit_test_runner_import_reftests_with_absolute_paths_download(self):
FAKE_FILES = {
@@ -440,6 +442,7 @@
FAKE_FILES = {
'/mock-checkout/WebKitBuild/w3c-tests/web-platform-tests/t/test.any.js': '// META: global=window,dedicatedworker,sharedworker,serviceworker\n',
'/mock-checkout/WebKitBuild/w3c-tests/web-platform-tests/t/test2.any.js': '\n// META: global=dedicatedworker,serviceworker\n',
+'/mock-checkout/WebKitBuild/w3c-tests/web-platform-tests/t/test3.any.js': '\n// META: global=worker\n',
}
FAKE_FILES.update(FAKE_REPOSITORY)
@@ -452,3 +455,6 @@
self.assertFalse(fs.exists('/mock-checkout/LayoutTests/w3c/web-platform-tests/t/test2.any.html'))
self.assertTrue(fs.exists('/mock-checkout/LayoutTests/w3c/web-platform-tests/t/test2.any.worker.html'))
self.assertTrue(fs.exists('/mock-checkout/LayoutTests/w3c/web-platform-tests/t/test2.any.serviceworker.html'))
+
+self.assertTrue(fs.exists('/mock-checkout/LayoutTests/w3c/web-platform-tests/
[webkit-changes] [283229] trunk/Source/JavaScriptCore
Title: [283229] trunk/Source/_javascript_Core
Revision 283229
Author ysuz...@apple.com
Date 2021-09-29 09:44:10 -0700 (Wed, 29 Sep 2021)
Log Message
[JSC] Use FixedVector in JITConstantPool
https://bugs.webkit.org/show_bug.cgi?id=230937
Reviewed by Keith Miller.
This patch changes JITConstantPool to use FixedVector. This allocates exact size
of memory and Making sizeof(JITConstantPool) smaller. We also use CompactPointerTuple
for JITConstantPool::Value since it is faster for access.
To achieve that, in JIT, we append Value to normal Vector. And when finalizing BaselineJITCode
we construct JITConstantPool from that Vector.
* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::setupWithUnlinkedBaselineCode):
* jit/BaselineJITCode.h:
(JSC::JITConstantPool::JITConstantPool):
(JSC::JITConstantPool::add): Deleted.
* jit/JIT.cpp:
(JSC::JIT::JIT):
(JSC::JIT::addToConstantPool):
* jit/JIT.h:
* jit/JITCall.cpp:
(JSC::JIT::compileOpCall):
(JSC::JIT::emit_op_iterator_open):
(JSC::JIT::emit_op_iterator_next):
* jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_instanceof):
(JSC::JIT::emitNewFuncCommon):
(JSC::JIT::emitNewFuncExprCommon):
* jit/JITPropertyAccess.cpp:
(JSC::JIT::emit_op_get_by_val):
(JSC::JIT::emit_op_get_private_name):
(JSC::JIT::emit_op_set_private_brand):
(JSC::JIT::emit_op_check_private_brand):
(JSC::JIT::emit_op_put_by_val):
(JSC::JIT::emit_op_put_private_name):
(JSC::JIT::emit_op_del_by_id):
(JSC::JIT::emit_op_del_by_val):
(JSC::JIT::emit_op_try_get_by_id):
(JSC::JIT::emit_op_get_by_id_direct):
(JSC::JIT::emit_op_get_by_id):
(JSC::JIT::emit_op_get_by_id_with_this):
(JSC::JIT::emit_op_put_by_id):
(JSC::JIT::emit_op_in_by_id):
(JSC::JIT::emit_op_in_by_val):
(JSC::JIT::emitHasPrivate):
(JSC::JIT::emit_op_enumerator_get_by_val):
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/bytecode/CodeBlock.cpp
trunk/Source/_javascript_Core/jit/BaselineJITCode.h
trunk/Source/_javascript_Core/jit/JIT.cpp
trunk/Source/_javascript_Core/jit/JIT.h
trunk/Source/_javascript_Core/jit/JITCall.cpp
trunk/Source/_javascript_Core/jit/JITOpcodes.cpp
trunk/Source/_javascript_Core/jit/JITPropertyAccess.cpp
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (283228 => 283229)
--- trunk/Source/_javascript_Core/ChangeLog 2021-09-29 16:37:07 UTC (rev 283228)
+++ trunk/Source/_javascript_Core/ChangeLog 2021-09-29 16:44:10 UTC (rev 283229)
@@ -1,3 +1,53 @@
+2021-09-29 Yusuke Suzuki
+
+[JSC] Use FixedVector in JITConstantPool
+https://bugs.webkit.org/show_bug.cgi?id=230937
+
+Reviewed by Keith Miller.
+
+This patch changes JITConstantPool to use FixedVector. This allocates exact size
+of memory and Making sizeof(JITConstantPool) smaller. We also use CompactPointerTuple
+for JITConstantPool::Value since it is faster for access.
+
+To achieve that, in JIT, we append Value to normal Vector. And when finalizing BaselineJITCode
+we construct JITConstantPool from that Vector.
+
+* bytecode/CodeBlock.cpp:
+(JSC::CodeBlock::setupWithUnlinkedBaselineCode):
+* jit/BaselineJITCode.h:
+(JSC::JITConstantPool::JITConstantPool):
+(JSC::JITConstantPool::add): Deleted.
+* jit/JIT.cpp:
+(JSC::JIT::JIT):
+(JSC::JIT::addToConstantPool):
+* jit/JIT.h:
+* jit/JITCall.cpp:
+(JSC::JIT::compileOpCall):
+(JSC::JIT::emit_op_iterator_open):
+(JSC::JIT::emit_op_iterator_next):
+* jit/JITOpcodes.cpp:
+(JSC::JIT::emit_op_instanceof):
+(JSC::JIT::emitNewFuncCommon):
+(JSC::JIT::emitNewFuncExprCommon):
+* jit/JITPropertyAccess.cpp:
+(JSC::JIT::emit_op_get_by_val):
+(JSC::JIT::emit_op_get_private_name):
+(JSC::JIT::emit_op_set_private_brand):
+(JSC::JIT::emit_op_check_private_brand):
+(JSC::JIT::emit_op_put_by_val):
+(JSC::JIT::emit_op_put_private_name):
+(JSC::JIT::emit_op_del_by_id):
+(JSC::JIT::emit_op_del_by_val):
+(JSC::JIT::emit_op_try_get_by_id):
+(JSC::JIT::emit_op_get_by_id_direct):
+(JSC::JIT::emit_op_get_by_id):
+(JSC::JIT::emit_op_get_by_id_with_this):
+(JSC::JIT::emit_op_put_by_id):
+(JSC::JIT::emit_op_in_by_id):
+(JSC::JIT::emit_op_in_by_val):
+(JSC::JIT::emitHasPrivate):
+(JSC::JIT::emit_op_enumerator_get_by_val):
+
2021-09-28 Saam Barati
DoesGCCheck does not use enough bits for nodeIndex
Modified: trunk/Source/_javascript_Core/bytecode/CodeBlock.cpp (283228 => 283229)
--- trunk/Source/_javascript_Core/bytecode/CodeBlock.cpp 2021-09-29 16:37:07 UTC (rev 283228)
+++ trunk/Source/_javascript_Core/bytecode/CodeBlock.cpp 2021-09-29 16:44:10 UTC (rev 283229)
@@ -805,12 +805,12 @@
jitData.m_jitConstantPool = FixedVector(jitCode->m_constantPool.size());
for (size_t i = 0; i < jitCode->m_constantPool.size(); ++i) {
auto entry = jitCode
[webkit-changes] [283228] trunk/Source/WebCore
Title: [283228] trunk/Source/WebCore Revision 283228 Author commit-qu...@webkit.org Date 2021-09-29 09:37:07 -0700 (Wed, 29 Sep 2021) Log Message Fix typo in RenderSVGBlock::updateFromStyle comment https://bugs.webkit.org/show_bug.cgi?id=230955 Patch by Olivier Blin on 2021-09-29 Reviewed by Simon Fraser. No new tests, just a comment fix. * rendering/svg/RenderSVGBlock.cpp: (WebCore::RenderSVGBlock::updateFromStyle): refactor instead of reactor. Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/rendering/svg/RenderSVGBlock.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (283227 => 283228) --- trunk/Source/WebCore/ChangeLog 2021-09-29 16:28:47 UTC (rev 283227) +++ trunk/Source/WebCore/ChangeLog 2021-09-29 16:37:07 UTC (rev 283228) @@ -1,3 +1,16 @@ +2021-09-29 Olivier Blin + +Fix typo in RenderSVGBlock::updateFromStyle comment +https://bugs.webkit.org/show_bug.cgi?id=230955 + +Reviewed by Simon Fraser. + +No new tests, just a comment fix. + +* rendering/svg/RenderSVGBlock.cpp: +(WebCore::RenderSVGBlock::updateFromStyle): refactor instead of reactor. + + 2021-09-29 Myles C. Maxfield Font palette names have to start with two hyphens Modified: trunk/Source/WebCore/rendering/svg/RenderSVGBlock.cpp (283227 => 283228) --- trunk/Source/WebCore/rendering/svg/RenderSVGBlock.cpp 2021-09-29 16:28:47 UTC (rev 283227) +++ trunk/Source/WebCore/rendering/svg/RenderSVGBlock.cpp 2021-09-29 16:37:07 UTC (rev 283228) @@ -46,7 +46,7 @@ // // If we want to support overflow rules for we can choose between two solutions: // a) make RenderSVGForeignObject require layers and SVG layer aware -// b) reactor overflow logic out of RenderLayer (as suggested by dhyatt), which is a large task +// b) refactor overflow logic out of RenderLayer (as suggested by dhyatt), which is a large task // // Until this is resolved, disable overflow support. Opera/FF don't support it as well at the moment (Feb 2010). // ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [283227] trunk/Source/WebKit
Title: [283227] trunk/Source/WebKit
Revision 283227
Author commit-qu...@webkit.org
Date 2021-09-29 09:28:47 -0700 (Wed, 29 Sep 2021)
Log Message
Reduce allocations in DatabaseUtilities::sortedTables
https://bugs.webkit.org/show_bug.cgi?id=230933
Patch by Alex Christensen on 2021-09-29
Reviewed by Chris Dumez.
No change in behavior except no more memory allocations. What a wonderful thing.
* NetworkProcess/Classifier/ResourceLoadStatisticsDatabaseStore.cpp:
(WebKit::ResourceLoadStatisticsDatabaseStore::sortedTables):
* NetworkProcess/Classifier/ResourceLoadStatisticsDatabaseStore.h:
* NetworkProcess/DatabaseUtilities.cpp:
(WebKit::DatabaseUtilities::migrateDataToNewTablesIfNecessary):
* NetworkProcess/DatabaseUtilities.h:
* NetworkProcess/PrivateClickMeasurement/PrivateClickMeasurementDatabase.cpp:
(WebKit::PCM::Database::sortedTables):
* NetworkProcess/PrivateClickMeasurement/PrivateClickMeasurementDatabase.h:
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/NetworkProcess/Classifier/ResourceLoadStatisticsDatabaseStore.cpp
trunk/Source/WebKit/NetworkProcess/Classifier/ResourceLoadStatisticsDatabaseStore.h
trunk/Source/WebKit/NetworkProcess/DatabaseUtilities.cpp
trunk/Source/WebKit/NetworkProcess/DatabaseUtilities.h
trunk/Source/WebKit/NetworkProcess/PrivateClickMeasurement/PrivateClickMeasurementDatabase.cpp
trunk/Source/WebKit/NetworkProcess/PrivateClickMeasurement/PrivateClickMeasurementDatabase.h
Diff
Modified: trunk/Source/WebKit/ChangeLog (283226 => 283227)
--- trunk/Source/WebKit/ChangeLog 2021-09-29 16:26:43 UTC (rev 283226)
+++ trunk/Source/WebKit/ChangeLog 2021-09-29 16:28:47 UTC (rev 283227)
@@ -1,3 +1,22 @@
+2021-09-29 Alex Christensen
+
+Reduce allocations in DatabaseUtilities::sortedTables
+https://bugs.webkit.org/show_bug.cgi?id=230933
+
+Reviewed by Chris Dumez.
+
+No change in behavior except no more memory allocations. What a wonderful thing.
+
+* NetworkProcess/Classifier/ResourceLoadStatisticsDatabaseStore.cpp:
+(WebKit::ResourceLoadStatisticsDatabaseStore::sortedTables):
+* NetworkProcess/Classifier/ResourceLoadStatisticsDatabaseStore.h:
+* NetworkProcess/DatabaseUtilities.cpp:
+(WebKit::DatabaseUtilities::migrateDataToNewTablesIfNecessary):
+* NetworkProcess/DatabaseUtilities.h:
+* NetworkProcess/PrivateClickMeasurement/PrivateClickMeasurementDatabase.cpp:
+(WebKit::PCM::Database::sortedTables):
+* NetworkProcess/PrivateClickMeasurement/PrivateClickMeasurementDatabase.h:
+
2021-09-29 Devin Rousso
Add support for sending Expected in IPC messages
Modified: trunk/Source/WebKit/NetworkProcess/Classifier/ResourceLoadStatisticsDatabaseStore.cpp (283226 => 283227)
--- trunk/Source/WebKit/NetworkProcess/Classifier/ResourceLoadStatisticsDatabaseStore.cpp 2021-09-29 16:26:43 UTC (rev 283226)
+++ trunk/Source/WebKit/NetworkProcess/Classifier/ResourceLoadStatisticsDatabaseStore.cpp 2021-09-29 16:28:47 UTC (rev 283227)
@@ -273,9 +273,9 @@
return expectedTableAndIndexQueries;
}
-const Vector& ResourceLoadStatisticsDatabaseStore::sortedTables()
+Span ResourceLoadStatisticsDatabaseStore::sortedTables()
{
-static auto sortedTables = makeNeverDestroyed(Vector {
+static constexpr std::array sortedTables {
"ObservedDomains"_s,
"TopLevelDomains"_s,
"StorageAccessUnderTopFrameDomains"_s,
@@ -289,9 +289,9 @@
"SubresourceUniqueRedirectsTo"_s,
"SubresourceUniqueRedirectsFrom"_s,
"OperatingDates"_s
-});
+};
-return sortedTables;
+return { sortedTables.data(), sortedTables.size() };
}
template
Modified: trunk/Source/WebKit/NetworkProcess/Classifier/ResourceLoadStatisticsDatabaseStore.h (283226 => 283227)
--- trunk/Source/WebKit/NetworkProcess/Classifier/ResourceLoadStatisticsDatabaseStore.h 2021-09-29 16:26:43 UTC (rev 283226)
+++ trunk/Source/WebKit/NetworkProcess/Classifier/ResourceLoadStatisticsDatabaseStore.h 2021-09-29 16:28:47 UTC (rev 283227)
@@ -117,7 +117,7 @@
private:
const MemoryCompactLookupOnlyRobinHoodHashMap& expectedTableAndIndexQueries() final;
-const Vector& sortedTables() final;
+Span sortedTables() final;
void includeTodayAsOperatingDateIfNecessary() override;
void clearOperatingDates() override { }
bool hasStatisticsExpired(WallTime mostRecentUserInteractionTime, OperatingDatesWindow) const override;
Modified: trunk/Source/WebKit/NetworkProcess/DatabaseUtilities.cpp (283226 => 283227)
--- trunk/Source/WebKit/NetworkProcess/DatabaseUtilities.cpp 2021-09-29 16:26:43 UTC (rev 283226)
+++ trunk/Source/WebKit/NetworkProcess/DatabaseUtilities.cpp 2021-09-29 16:28:47 UTC (rev 283227)
@@ -280,7 +280,7 @@
for (auto& table : sortedTables()) {
auto migrateTableData = insertDistinctValuesInTableStatement(m_database, table);
if (!migrateTableData || migrateTableData->step() != SQLITE_DONE) {
[webkit-changes] [283226] trunk/LayoutTests
Title: [283226] trunk/LayoutTests Revision 283226 Author ayumi_koj...@apple.com Date 2021-09-29 09:26:43 -0700 (Wed, 29 Sep 2021) Log Message [ iOS ] fast/scrolling/ios/click-events-after-long-press-during-momentum-scroll-in-overflow.html is a flaky timeout. https://bugs.webkit.org/show_bug.cgi?id=230959 Unreviewed test gardening. * platform/ios-wk2/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/ios-wk2/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (283225 => 283226) --- trunk/LayoutTests/ChangeLog 2021-09-29 16:12:31 UTC (rev 283225) +++ trunk/LayoutTests/ChangeLog 2021-09-29 16:26:43 UTC (rev 283226) @@ -1,5 +1,14 @@ 2021-09-29 Ayumi Kojima +[ iOS ] fast/scrolling/ios/click-events-after-long-press-during-momentum-scroll-in-overflow.html is a flaky timeout. +https://bugs.webkit.org/show_bug.cgi?id=230959 + +Unreviewed test gardening. + +* platform/ios-wk2/TestExpectations: + +2021-09-29 Ayumi Kojima + [ iOS BigSur ] http/tests/appcache/fail-on-update.html is a flaky timeout. https://bugs.webkit.org/show_bug.cgi?id=227891 Modified: trunk/LayoutTests/platform/ios-wk2/TestExpectations (283225 => 283226) --- trunk/LayoutTests/platform/ios-wk2/TestExpectations 2021-09-29 16:12:31 UTC (rev 283225) +++ trunk/LayoutTests/platform/ios-wk2/TestExpectations 2021-09-29 16:26:43 UTC (rev 283226) @@ -1873,6 +1873,8 @@ webkit.org/b/214512 imported/w3c/web-platform-tests/css/geometry/DOMMatrix2DInit-validate-fixup.html [ Pass Failure ] +webkit.org/b/230959 fast/scrolling/ios/click-events-after-long-press-during-momentum-scroll-in-overflow.html [ Pass Timeout ] + webkit.org/b/214598 fast/scrolling/ios/autoscroll-input-when-very-zoomed.html [ Pass Failure ] http/tests/in-app-browser-privacy/ [ Pass ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [283225] trunk/Source/WebKitLegacy/mac
Title: [283225] trunk/Source/WebKitLegacy/mac
Revision 283225
Author cdu...@apple.com
Date 2021-09-29 09:12:31 -0700 (Wed, 29 Sep 2021)
Log Message
Make WebLocalizedString() thread-safe
https://bugs.webkit.org/show_bug.cgi?id=230954
Reviewed by Alexey Proskuryakov.
Make WebLocalizedString() thread-safe. It takes minimal effort to make it thread-safe given
that the NSBundle API is thread-safe [1] and clients keep calling it on the background thread.
[1] https://developer.apple.com/documentation/foundation/nslocalizedstringwithdefaultvalue
"As of OS X 10.11 and iOS 9, NSBundle is thread-safe. As such, you can safely call
NSLocalizedStringWithDefaultValue from any execution context."
* Misc/WebLocalizableStrings.mm:
Modified Paths
trunk/Source/WebKitLegacy/mac/ChangeLog
trunk/Source/WebKitLegacy/mac/Misc/WebLocalizableStrings.mm
Diff
Modified: trunk/Source/WebKitLegacy/mac/ChangeLog (283224 => 283225)
--- trunk/Source/WebKitLegacy/mac/ChangeLog 2021-09-29 16:10:30 UTC (rev 283224)
+++ trunk/Source/WebKitLegacy/mac/ChangeLog 2021-09-29 16:12:31 UTC (rev 283225)
@@ -1,3 +1,19 @@
+2021-09-29 Chris Dumez
+
+Make WebLocalizedString() thread-safe
+https://bugs.webkit.org/show_bug.cgi?id=230954
+
+Reviewed by Alexey Proskuryakov.
+
+Make WebLocalizedString() thread-safe. It takes minimal effort to make it thread-safe given
+that the NSBundle API is thread-safe [1] and clients keep calling it on the background thread.
+
+[1] https://developer.apple.com/documentation/foundation/nslocalizedstringwithdefaultvalue
+"As of OS X 10.11 and iOS 9, NSBundle is thread-safe. As such, you can safely call
+ NSLocalizedStringWithDefaultValue from any execution context."
+
+* Misc/WebLocalizableStrings.mm:
+
2021-09-28 Chris Dumez
Move Cross-Origin-Opener-Policy handling to the NetworkProcess
Modified: trunk/Source/WebKitLegacy/mac/Misc/WebLocalizableStrings.mm (283224 => 283225)
--- trunk/Source/WebKitLegacy/mac/Misc/WebLocalizableStrings.mm 2021-09-29 16:10:30 UTC (rev 283224)
+++ trunk/Source/WebKitLegacy/mac/Misc/WebLocalizableStrings.mm 2021-09-29 16:12:31 UTC (rev 283225)
@@ -37,17 +37,13 @@
NSString *WebLocalizedString(WebLocalizableStringsBundle *stringsBundle, const char *key)
{
-// This function is not thread-safe due at least to its unguarded use of the mainBundle static variable
-// and its use of [NSBundle localizedStringForKey:::], which is not guaranteed to be thread-safe. If
-// we decide we need to use this on background threads, we'll need to add locking here and make sure
-// it doesn't affect performance.
-#if !PLATFORM(IOS_FAMILY)
-ASSERT(isMainThread());
-#endif
-
NSBundle *bundle;
if (stringsBundle == NULL) {
-static NeverDestroyed> mainBundle = [NSBundle mainBundle];
+static LazyNeverDestroyed> mainBundle;
+static std::once_flag flag;
+std::call_once(flag, [] () {
+mainBundle.construct([NSBundle mainBundle]);
+});
ASSERT(mainBundle.get());
bundle = mainBundle.get().get();
} else {
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [283224] trunk/LayoutTests
Title: [283224] trunk/LayoutTests Revision 283224 Author ayumi_koj...@apple.com Date 2021-09-29 09:10:30 -0700 (Wed, 29 Sep 2021) Log Message [ iOS BigSur ] http/tests/appcache/fail-on-update.html is a flaky timeout. https://bugs.webkit.org/show_bug.cgi?id=227891 Unreviewed test gardening. * platform/mac/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/mac/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (283223 => 283224) --- trunk/LayoutTests/ChangeLog 2021-09-29 16:04:21 UTC (rev 283223) +++ trunk/LayoutTests/ChangeLog 2021-09-29 16:10:30 UTC (rev 283224) @@ -1,3 +1,12 @@ +2021-09-29 Ayumi Kojima + +[ iOS BigSur ] http/tests/appcache/fail-on-update.html is a flaky timeout. +https://bugs.webkit.org/show_bug.cgi?id=227891 + +Unreviewed test gardening. + +* platform/mac/TestExpectations: + 2021-09-29 Aditya Keerthi Update css-ui WPT Modified: trunk/LayoutTests/platform/mac/TestExpectations (283223 => 283224) --- trunk/LayoutTests/platform/mac/TestExpectations 2021-09-29 16:04:21 UTC (rev 283223) +++ trunk/LayoutTests/platform/mac/TestExpectations 2021-09-29 16:10:30 UTC (rev 283224) @@ -1924,6 +1924,8 @@ webkit.org/b/230411 http/tests/media/hls/video-controller-getStartDate.html [ Pass Failure ] +webkit.org/b/227891 http/tests/appcache/fail-on-update.html [ Pass Timeout DumpJSConsoleLogInStdErr ] + # rdar://0680 (REGRESSION (20A2327a-20A2348b): media/video-canvas-createPattern.html is failing) [ BigSur+ ] media/video-canvas-createPattern.html [ Failure ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [283222] trunk/LayoutTests
Title: [283222] trunk/LayoutTests Revision 283222 Author ayumi_koj...@apple.com Date 2021-09-29 09:02:54 -0700 (Wed, 29 Sep 2021) Log Message [iOS] http/tests/appcache/fail-on-update.html is a flaky timeout. https://bugs.webkit.org/show_bug.cgi?id=227891 Unreviewed test gardening. * platform/ios-wk2/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/ios-wk2/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (283221 => 283222) --- trunk/LayoutTests/ChangeLog 2021-09-29 15:40:56 UTC (rev 283221) +++ trunk/LayoutTests/ChangeLog 2021-09-29 16:02:54 UTC (rev 283222) @@ -1,3 +1,12 @@ +2021-09-29 Ayumi Kojima + +[iOS] http/tests/appcache/fail-on-update.html is a flaky timeout. +https://bugs.webkit.org/show_bug.cgi?id=227891 + +Unreviewed test gardening. + +* platform/ios-wk2/TestExpectations: + 2021-09-29 Eric Carlson [Cocoa] Support in-band chapter tracks Modified: trunk/LayoutTests/platform/ios-wk2/TestExpectations (283221 => 283222) --- trunk/LayoutTests/platform/ios-wk2/TestExpectations 2021-09-29 15:40:56 UTC (rev 283221) +++ trunk/LayoutTests/platform/ios-wk2/TestExpectations 2021-09-29 16:02:54 UTC (rev 283222) @@ -1072,7 +1072,7 @@ # Uses WK1 TestRunner.setUseDeferredFramLoading http/tests/appcache/load-from-appcache-defer-resume-crash.html [ Skip ] -webkit.org/b/227891 http/tests/appcache/fail-on-update.html [ DumpJSConsoleLogInStdErr Slow ] +webkit.org/b/227891 http/tests/appcache/fail-on-update.html [ Pass Timeout DumpJSConsoleLogInStdErr ] webkit.org/b/225665 http/tests/appcache/fail-on-update-2.html [ DumpJSConsoleLogInStdErr Slow ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [283221] trunk
Title: [283221] trunk Revision 283221 Author mmaxfi...@apple.com Date 2021-09-29 08:40:56 -0700 (Wed, 29 Sep 2021) Log Message Font palette names have to start with two hyphens https://bugs.webkit.org/show_bug.cgi?id=230790 Reviewed by Dean Jackson. LayoutTests/imported/w3c: Tests are being upstreamed at https://github.com/web-platform-tests/wpt/pull/30963. * web-platform-tests/css/css-fonts/font-palette-add-2-expected.html: * web-platform-tests/css/css-fonts/font-palette-add-2.html: * web-platform-tests/css/css-fonts/font-palette-add-expected-mismatch.html: * web-platform-tests/css/css-fonts/font-palette-add.html: * web-platform-tests/css/css-fonts/font-palette-empty-font-family-expected-mismatch.html: * web-platform-tests/css/css-fonts/font-palette-empty-font-family.html: * web-platform-tests/css/css-fonts/font-palette-modify-2-expected.html: * web-platform-tests/css/css-fonts/font-palette-modify-2.html: * web-platform-tests/css/css-fonts/font-palette-modify-expected-mismatch.html: * web-platform-tests/css/css-fonts/font-palette-modify.html: * web-platform-tests/css/css-fonts/font-palette-remove-2-expected.html: * web-platform-tests/css/css-fonts/font-palette-remove-2.html: * web-platform-tests/css/css-fonts/font-palette-remove-expected-mismatch.html: * web-platform-tests/css/css-fonts/font-palette-remove.html: * web-platform-tests/css/css-fonts/font-palette.html: * web-platform-tests/css/css-fonts/palette-values-rule-add-2-expected.html: * web-platform-tests/css/css-fonts/palette-values-rule-add-2.html: * web-platform-tests/css/css-fonts/palette-values-rule-add-expected-mismatch.html: * web-platform-tests/css/css-fonts/palette-values-rule-add.html: * web-platform-tests/css/css-fonts/palette-values-rule-delete-2-expected.html: * web-platform-tests/css/css-fonts/palette-values-rule-delete-2.html: * web-platform-tests/css/css-fonts/palette-values-rule-delete-expected-mismatch.html: * web-platform-tests/css/css-fonts/palette-values-rule-delete.html: * web-platform-tests/css/css-fonts/parsing/font-palette-computed-expected.txt: * web-platform-tests/css/css-fonts/parsing/font-palette-computed.html: * web-platform-tests/css/css-fonts/parsing/font-palette-invalid-expected.txt: * web-platform-tests/css/css-fonts/parsing/font-palette-invalid.html: * web-platform-tests/css/css-fonts/parsing/font-palette-valid-expected.txt: * web-platform-tests/css/css-fonts/parsing/font-palette-valid.html: * web-platform-tests/css/css-fonts/parsing/font-palette-values-invalid.html: * web-platform-tests/css/css-fonts/parsing/font-palette-values-valid.html: Source/WebCore: The spec changed in https://github.com/w3c/csswg-drafts/commit/9ddf9388a2fe0ac300c41b7244e10c0a40fe0cae. Font palettes now have to be named with a . Updated existing tests. * css/parser/CSSParserImpl.cpp: (WebCore::CSSParserImpl::consumeFontPaletteValuesRule): * css/parser/CSSPropertyParser.cpp: (WebCore::consumeFontPalette): * css/parser/CSSPropertyParserHelpers.cpp: (WebCore::CSSPropertyParserHelpers::consumeDashedCustomIdent): * css/parser/CSSPropertyParserHelpers.h: Modified Paths trunk/LayoutTests/imported/w3c/ChangeLog trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/animations/font-palette-animation-2-expected.html trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/animations/font-palette-animation-2.html trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/animations/font-palette-animation-3-expected-mismatch.html trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/animations/font-palette-animation-3.html trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/animations/font-palette-animation-expected.html trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/animations/font-palette-animation.html trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/font-palette-add-2-expected.html trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/font-palette-add-2.html trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/font-palette-add-expected-mismatch.html trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/font-palette-add.html trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/font-palette-empty-font-family-expected-mismatch.html trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/font-palette-empty-font-family.html trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/font-palette-modify-2-expected.html trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/font-palette-modify-2.html trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/font-palette-modify-expected-mismatch.html trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/font-palette-modify.html trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/font-palette-remove-2-expected.html trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/font-palette-remove-2.html trunk/LayoutTests/im
[webkit-changes] [283220] trunk/Source/WebKit
Title: [283220] trunk/Source/WebKit
Revision 283220
Author drou...@apple.com
Date 2021-09-29 08:39:26 -0700 (Wed, 29 Sep 2021)
Log Message
Add support for sending Expected in IPC messages
https://bugs.webkit.org/show_bug.cgi?id=230907
Reviewed by Chris Dumez.
* Platform/IPC/ArgumentCoders.h:
* WebProcess/Inspector/WebInspectorUIExtensionController.messages.in:
* WebProcess/Inspector/WebInspectorUIExtensionController.h:
* WebProcess/Inspector/WebInspectorUIExtensionController.cpp:
(WebKit::WebInspectorUIExtensionController::registerExtension):
(WebKit::WebInspectorUIExtensionController::unregisterExtension):
(WebKit::WebInspectorUIExtensionController::showExtensionTab):
* UIProcess/Inspector/WebInspectorUIExtensionControllerProxy.h:
* UIProcess/Inspector/WebInspectorUIExtensionControllerProxy.cpp:
(WebKit::WebInspectorUIExtensionControllerProxy::registerExtension):
(WebKit::WebInspectorUIExtensionControllerProxy::unregisterExtension):
(WebKit::WebInspectorUIExtensionControllerProxy::showExtensionTab):
* UIProcess/API/Cocoa/_WKInspector.mm:
(-[_WKInspector unregisterExtension:completionHandler:]):
(-[_WKInspector showExtensionTabWithIdentifier:completionHandler:]):
* UIProcess/API/Cocoa/_WKRemoteWebInspectorViewController.mm:
(-[_WKRemoteWebInspectorViewController unregisterExtension:completionHandler:]):
(-[_WKRemoteWebInspectorViewController showExtensionTabWithIdentifier:completionHandler:]):
Replace `Expected` with `Expected` now that it can be sent over IPC.
No change in functionality as the `bool` was never actually used (it was a hardcoded `true`).
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Platform/IPC/ArgumentCoders.h
trunk/Source/WebKit/UIProcess/API/Cocoa/_WKInspector.mm
trunk/Source/WebKit/UIProcess/API/Cocoa/_WKRemoteWebInspectorViewController.mm
trunk/Source/WebKit/UIProcess/Inspector/WebInspectorUIExtensionControllerProxy.cpp
trunk/Source/WebKit/UIProcess/Inspector/WebInspectorUIExtensionControllerProxy.h
trunk/Source/WebKit/WebProcess/Inspector/WebInspectorUIExtensionController.cpp
trunk/Source/WebKit/WebProcess/Inspector/WebInspectorUIExtensionController.h
trunk/Source/WebKit/WebProcess/Inspector/WebInspectorUIExtensionController.messages.in
Diff
Modified: trunk/Source/WebKit/ChangeLog (283219 => 283220)
--- trunk/Source/WebKit/ChangeLog 2021-09-29 15:38:11 UTC (rev 283219)
+++ trunk/Source/WebKit/ChangeLog 2021-09-29 15:39:26 UTC (rev 283220)
@@ -1,3 +1,32 @@
+2021-09-29 Devin Rousso
+
+Add support for sending Expected in IPC messages
+https://bugs.webkit.org/show_bug.cgi?id=230907
+
+Reviewed by Chris Dumez.
+
+* Platform/IPC/ArgumentCoders.h:
+
+* WebProcess/Inspector/WebInspectorUIExtensionController.messages.in:
+* WebProcess/Inspector/WebInspectorUIExtensionController.h:
+* WebProcess/Inspector/WebInspectorUIExtensionController.cpp:
+(WebKit::WebInspectorUIExtensionController::registerExtension):
+(WebKit::WebInspectorUIExtensionController::unregisterExtension):
+(WebKit::WebInspectorUIExtensionController::showExtensionTab):
+* UIProcess/Inspector/WebInspectorUIExtensionControllerProxy.h:
+* UIProcess/Inspector/WebInspectorUIExtensionControllerProxy.cpp:
+(WebKit::WebInspectorUIExtensionControllerProxy::registerExtension):
+(WebKit::WebInspectorUIExtensionControllerProxy::unregisterExtension):
+(WebKit::WebInspectorUIExtensionControllerProxy::showExtensionTab):
+* UIProcess/API/Cocoa/_WKInspector.mm:
+(-[_WKInspector unregisterExtension:completionHandler:]):
+(-[_WKInspector showExtensionTabWithIdentifier:completionHandler:]):
+* UIProcess/API/Cocoa/_WKRemoteWebInspectorViewController.mm:
+(-[_WKRemoteWebInspectorViewController unregisterExtension:completionHandler:]):
+(-[_WKRemoteWebInspectorViewController showExtensionTabWithIdentifier:completionHandler:]):
+Replace `Expected` with `Expected` now that it can be sent over IPC.
+No change in functionality as the `bool` was never actually used (it was a hardcoded `true`).
+
2021-09-28 Simon Fraser
Crash in WebKit::DisplayLink::displayLinkCallback()
Modified: trunk/Source/WebKit/Platform/IPC/ArgumentCoders.h (283219 => 283220)
--- trunk/Source/WebKit/Platform/IPC/ArgumentCoders.h 2021-09-29 15:38:11 UTC (rev 283219)
+++ trunk/Source/WebKit/Platform/IPC/ArgumentCoders.h 2021-09-29 15:39:26 UTC (rev 283220)
@@ -30,6 +30,7 @@
#include
#include
#include
+#include
#include
#include
#include
@@ -671,6 +672,36 @@
}
};
+template struct ArgumentCoder> {
+template static void encode(Encoder& encoder, const Expected& expected)
+{
+if (!expected.has_value()) {
+encoder << false;
+encoder << expected.error();
+return;
+}
+
+encoder << true;
+}
+
+template static std::optional> decode(Decoder& decoder)
+
[webkit-changes] [283219] trunk
Title: [283219] trunk
Revision 283219
Author mmaxfi...@apple.com
Date 2021-09-29 08:38:11 -0700 (Wed, 29 Sep 2021)
Log Message
CSSFontPaletteValuesRule should not be maplike
https://bugs.webkit.org/show_bug.cgi?id=230793
Reviewed by Wenson Hsieh.
LayoutTests/imported/w3c:
The tests are being upstreamed in https://github.com/web-platform-tests/wpt/pull/30966.
* web-platform-tests/css/css-fonts/parsing/font-palette-values-invalid.html:
* web-platform-tests/css/css-fonts/parsing/font-palette-values-valid.html:
Source/WebCore:
The spec changed in
https://github.com/w3c/csswg-drafts/commit/c10855a2c65f51a09697613b977059fae78ff0bc
from "maplike" to "attribute CSSOMString overrideColor".
Tests: imported/w3c/web-platform-tests/css/css-fonts/parsing/font-palette-values-invalid.html
imported/w3c/web-platform-tests/css/css-fonts/parsing/font-palette-values-valid.html
* css/CSSFontPaletteValuesRule.cpp:
(WebCore::CSSFontPaletteValuesRule::basePalette const):
(WebCore::CSSFontPaletteValuesRule::overrideColor const):
(WebCore::CSSFontPaletteValuesRule::cssText const):
(WebCore::CSSFontPaletteValuesRule::initializeMapLike): Deleted.
* css/CSSFontPaletteValuesRule.h:
* css/CSSFontPaletteValuesRule.idl:
Modified Paths
trunk/LayoutTests/imported/w3c/ChangeLog
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/parsing/font-palette-values-invalid.html
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/parsing/font-palette-values-valid.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/CSSFontPaletteValuesRule.cpp
trunk/Source/WebCore/css/CSSFontPaletteValuesRule.h
trunk/Source/WebCore/css/CSSFontPaletteValuesRule.idl
Diff
Modified: trunk/LayoutTests/imported/w3c/ChangeLog (283218 => 283219)
--- trunk/LayoutTests/imported/w3c/ChangeLog 2021-09-29 15:36:28 UTC (rev 283218)
+++ trunk/LayoutTests/imported/w3c/ChangeLog 2021-09-29 15:38:11 UTC (rev 283219)
@@ -1,3 +1,16 @@
+2021-09-29 Myles C. Maxfield
+
+CSSFontPaletteValuesRule should not be maplike
+https://bugs.webkit.org/show_bug.cgi?id=230793
+
+
+Reviewed by Wenson Hsieh.
+
+The tests are being upstreamed in https://github.com/web-platform-tests/wpt/pull/30966.
+
+* web-platform-tests/css/css-fonts/parsing/font-palette-values-invalid.html:
+* web-platform-tests/css/css-fonts/parsing/font-palette-values-valid.html:
+
2021-09-29 Antti Koivisto
[CSS Cascade Layers] Add fonts and keyframes in cascade layer order
Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/parsing/font-palette-values-invalid.html (283218 => 283219)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/parsing/font-palette-values-invalid.html 2021-09-29 15:36:28 UTC (rev 283218)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/parsing/font-palette-values-invalid.html 2021-09-29 15:38:11 UTC (rev 283219)
@@ -183,7 +183,7 @@
let text = rules[7].cssText;
let rule = rules[7];
assert_equals(text.indexOf("override-colors"), -1);
-assert_equals(rule.size, 0);
+assert_equals(rule.overrideColors, "");
});
test(function() {
@@ -190,7 +190,7 @@
let text = rules[8].cssText;
let rule = rules[8];
assert_equals(text.indexOf("override-colors"), -1);
-assert_equals(rule.size, 0);
+assert_equals(rule.overrideColors, "");
});
test(function() {
@@ -197,7 +197,7 @@
let text = rules[9].cssText;
let rule = rules[9];
assert_equals(text.indexOf("override-colors"), -1);
-assert_equals(rule.size, 0);
+assert_equals(rule.overrideColors, "");
});
test(function() {
@@ -204,7 +204,7 @@
let text = rules[10].cssText;
let rule = rules[10];
assert_equals(text.indexOf("override-colors"), -1);
-assert_equals(rule.size, 0);
+assert_equals(rule.overrideColors, "");
});
test(function() {
@@ -211,7 +211,7 @@
let text = rules[11].cssText;
let rule = rules[11];
assert_equals(text.indexOf("override-colors"), -1);
-assert_equals(rule.size, 0);
+assert_equals(rule.overrideColors, "");
});
test(function() {
@@ -218,7 +218,7 @@
let text = rules[12].cssText;
let rule = rules[12];
assert_equals(text.indexOf("override-colors"), -1);
-assert_equals(rule.size, 0);
+assert_equals(rule.overrideColors, "");
});
test(function() {
@@ -233,8 +233,8 @@
let rule = rules[14];
assert_equals(text.indexOf("base-palette"), -1);
assert_equals(text.indexOf("override-colors"), -1);
-assert_equals(rule.size, 0);
assert_equals(rule.basePalette, "");
+assert_equals(rule.overrideColors, "");
});
test(function() {
@@ -242,8 +242,8 @@
let rule = rules[15];
assert_equals(text.indexOf("base-palette"), -1);
assert_equals(text.indexOf("override-colors"), -1);
-assert_equals(rule.size, 0);
assert_equals(rule.basePalette, "");
+assert_equals(rule.overrideColors, "");
[webkit-changes] [283218] trunk/Source/WTF
Title: [283218] trunk/Source/WTF Revision 283218 Author an...@apple.com Date 2021-09-29 08:36:28 -0700 (Wed, 29 Sep 2021) Log Message [CSS Cascade Layers] Enable by default https://bugs.webkit.org/show_bug.cgi?id=230948 Reviewed by Simon Fraser. Flip the switch. * Scripts/Preferences/WebPreferencesExperimental.yaml: Modified Paths trunk/Source/WTF/ChangeLog trunk/Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml Diff Modified: trunk/Source/WTF/ChangeLog (283217 => 283218) --- trunk/Source/WTF/ChangeLog 2021-09-29 15:31:58 UTC (rev 283217) +++ trunk/Source/WTF/ChangeLog 2021-09-29 15:36:28 UTC (rev 283218) @@ -1,3 +1,14 @@ +2021-09-29 Antti Koivisto + +[CSS Cascade Layers] Enable by default +https://bugs.webkit.org/show_bug.cgi?id=230948 + +Reviewed by Simon Fraser. + +Flip the switch. + +* Scripts/Preferences/WebPreferencesExperimental.yaml: + 2021-09-28 Yusuke Suzuki iOS simulator build should use PTHREAD_JIT_PERMISSIONS_API Modified: trunk/Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml (283217 => 283218) --- trunk/Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml 2021-09-29 15:31:58 UTC (rev 283217) +++ trunk/Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml 2021-09-29 15:36:28 UTC (rev 283218) @@ -129,11 +129,11 @@ humanReadableDescription: "Enable CSS Cascade Layers" defaultValue: WebKitLegacy: - default: false + default: true WebKit: - default: false + default: true WebCore: - default: false + default: true CSSColor4: type: bool ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [283216] trunk
Title: [283216] trunk Revision 283216 Author an...@apple.com Date 2021-09-29 08:23:09 -0700 (Wed, 29 Sep 2021) Log Message [CSS Cascade Layers] Add fonts and keyframes in cascade layer order https://bugs.webkit.org/show_bug.cgi?id=230947 Reviewed by Simon Fraser. LayoutTests/imported/w3c: * web-platform-tests/css/css-cascade/layer-font-face-override-expected.txt: * web-platform-tests/css/css-cascade/layer-keyframes-override-expected.txt: Source/WebCore: Ensure font and keyframe rules respect cascade layer ordering. * style/RuleSet.cpp: (WebCore::Style::RuleSet::Builder::addChildRules): Collect resolver mutating rules instead of processing them immediately. (WebCore::Style::RuleSet::Builder::~Builder): (WebCore::Style::RuleSet::Builder::addMutatingRulesToResolver): Process the rules in correct order after cascade layer order has been established. In additive case we need to also re-process rules added from earlier stylesheets as they might have higher priority than the newly added ones. (WebCore::Style::RuleSet::shrinkToFit): * style/RuleSet.h: (WebCore::Style::RuleSet::cascadeLayerOrderForIdentifier const): (WebCore::Style::RuleSet::cascadeLayerOrderFor const): Modified Paths trunk/LayoutTests/imported/w3c/ChangeLog trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-cascade/layer-font-face-override-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-cascade/layer-keyframes-override-expected.txt trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/style/RuleSet.cpp trunk/Source/WebCore/style/RuleSet.h Diff Modified: trunk/LayoutTests/imported/w3c/ChangeLog (283215 => 283216) --- trunk/LayoutTests/imported/w3c/ChangeLog 2021-09-29 14:38:48 UTC (rev 283215) +++ trunk/LayoutTests/imported/w3c/ChangeLog 2021-09-29 15:23:09 UTC (rev 283216) @@ -1,3 +1,13 @@ +2021-09-29 Antti Koivisto + +[CSS Cascade Layers] Add fonts and keyframes in cascade layer order +https://bugs.webkit.org/show_bug.cgi?id=230947 + +Reviewed by Simon Fraser. + +* web-platform-tests/css/css-cascade/layer-font-face-override-expected.txt: +* web-platform-tests/css/css-cascade/layer-keyframes-override-expected.txt: + 2021-09-28 Cameron McCormack Preserve color space when structured cloning ImageBitmaps Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-cascade/layer-font-face-override-expected.txt (283215 => 283216) --- trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-cascade/layer-font-face-override-expected.txt 2021-09-29 14:38:48 UTC (rev 283215) +++ trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-cascade/layer-font-face-override-expected.txt 2021-09-29 15:23:09 UTC (rev 283216) @@ -1,7 +1,7 @@ Test -FAIL @font-face layered overrides unlayered assert_equals: expected "80px" but got "38.515625px" -FAIL @font-face override between layers assert_equals: expected "80px" but got "38.515625px" -FAIL @font-face override update with appended sheet 1 assert_equals: expected "80px" but got "38.515625px" +PASS @font-face layered overrides unlayered +PASS @font-face override between layers +PASS @font-face override update with appended sheet 1 PASS @font-face override update with appended sheet 2 Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-cascade/layer-keyframes-override-expected.txt (283215 => 283216) --- trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-cascade/layer-keyframes-override-expected.txt 2021-09-29 14:38:48 UTC (rev 283215) +++ trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-cascade/layer-keyframes-override-expected.txt 2021-09-29 15:23:09 UTC (rev 283216) @@ -1,6 +1,6 @@ -FAIL @keyframes layered overrides unlayered assert_equals: expected "rgb(0, 128, 0)" but got "rgb(255, 0, 0)" -FAIL @keyframes override between layers assert_equals: expected "rgb(0, 128, 0)" but got "rgb(255, 0, 0)" -FAIL @keyframes override update with appended sheet 1 assert_equals: expected "rgb(0, 128, 0)" but got "rgb(255, 0, 0)" -FAIL @keyframes override update with appended sheet 2 assert_equals: expected "rgb(0, 128, 0)" but got "rgb(255, 0, 0)" +PASS @keyframes layered overrides unlayered +PASS @keyframes override between layers +PASS @keyframes override update with appended sheet 1 +PASS @keyframes override update with appended sheet 2 Modified: trunk/Source/WebCore/ChangeLog (283215 => 283216) --- trunk/Source/WebCore/ChangeLog 2021-09-29 14:38:48 UTC (rev 283215) +++ trunk/Source/WebCore/ChangeLog 2021-09-29 15:23:09 UTC (rev 283216) @@ -1,3 +1,30 @@ +2021-09-29 Antti Koivisto + +[CSS Cascade Layers] Add fonts and keyframes in cascade layer order +https://bugs.webkit.org/show_bug.cgi?id=230947 + +Reviewed by Simon Fraser. + +Ensure font and keyframe rules respect cascade layer ordering. + +* style/RuleSet.cpp: +(WebCore::Style::RuleSet::Builder::addChildRules): + +Collect resolver mutating rules
[webkit-changes] [283215] trunk/Tools/buildstream
Title: [283215] trunk/Tools/buildstream Revision 283215 Author commit-qu...@webkit.org Date 2021-09-29 07:38:48 -0700 (Wed, 29 Sep 2021) Log Message [Flatpak SDK] Add bwrap and xdg-dbus-proxy https://bugs.webkit.org/show_bug.cgi?id=230456 Patch by Philippe Normand on 2021-09-29 Reviewed by Sergio Villar Senin. These are needed in order to enable the Bubblewrap launcher in WPE/GTK at build time. * elements/sdk-platform.bst: * elements/sdk/bubblewrap.bst: Added. * elements/sdk/xdg-dbus-proxy.bst: Added. Modified Paths trunk/Tools/buildstream/ChangeLog trunk/Tools/buildstream/elements/sdk-platform.bst Added Paths trunk/Tools/buildstream/elements/sdk/bubblewrap.bst trunk/Tools/buildstream/elements/sdk/xdg-dbus-proxy.bst Diff Modified: trunk/Tools/buildstream/ChangeLog (283214 => 283215) --- trunk/Tools/buildstream/ChangeLog 2021-09-29 14:25:28 UTC (rev 283214) +++ trunk/Tools/buildstream/ChangeLog 2021-09-29 14:38:48 UTC (rev 283215) @@ -1,5 +1,18 @@ 2021-09-29 Philippe Normand +[Flatpak SDK] Add bwrap and xdg-dbus-proxy +https://bugs.webkit.org/show_bug.cgi?id=230456 + +Reviewed by Sergio Villar Senin. + +These are needed in order to enable the Bubblewrap launcher in WPE/GTK at build time. + +* elements/sdk-platform.bst: +* elements/sdk/bubblewrap.bst: Added. +* elements/sdk/xdg-dbus-proxy.bst: Added. + +2021-09-29 Philippe Normand + [Flatpak SDK] rr replay is broken https://bugs.webkit.org/show_bug.cgi?id=230952 Added: trunk/Tools/buildstream/elements/sdk/bubblewrap.bst (0 => 283215) --- trunk/Tools/buildstream/elements/sdk/bubblewrap.bst (rev 0) +++ trunk/Tools/buildstream/elements/sdk/bubblewrap.bst 2021-09-29 14:38:48 UTC (rev 283215) @@ -0,0 +1,11 @@ +kind: autotools +sources: +- kind: tar + url: github_com:containers/bubblewrap/releases/download/v0.5.0/bubblewrap-0.5.0.tar.xz + ref: 16fdaf33799d63104e347e0133f909196fe90d0c50515d010bcb422eb5a00818 +build-depends: +- freedesktop-sdk.bst:public-stacks/buildsystem-autotools.bst + +depends: +- freedesktop-sdk.bst:components/libcap.bst +- freedesktop-sdk.bst:bootstrap-import.bst Added: trunk/Tools/buildstream/elements/sdk/xdg-dbus-proxy.bst (0 => 283215) --- trunk/Tools/buildstream/elements/sdk/xdg-dbus-proxy.bst (rev 0) +++ trunk/Tools/buildstream/elements/sdk/xdg-dbus-proxy.bst 2021-09-29 14:38:48 UTC (rev 283215) @@ -0,0 +1,11 @@ +kind: autotools +sources: +- kind: tar + url: github_com:flatpak/xdg-dbus-proxy/releases/download/0.1.2/xdg-dbus-proxy-0.1.2.tar.xz + ref: 1749d6f9f46dcc9edc87725641cf56cf91dcad1b01707891ea0850c1000c520f +build-depends: +- freedesktop-sdk.bst:public-stacks/buildsystem-autotools.bst + +depends: +- sdk/glib.bst +- freedesktop-sdk.bst:bootstrap-import.bst Modified: trunk/Tools/buildstream/elements/sdk-platform.bst (283214 => 283215) --- trunk/Tools/buildstream/elements/sdk-platform.bst 2021-09-29 14:25:28 UTC (rev 283214) +++ trunk/Tools/buildstream/elements/sdk-platform.bst 2021-09-29 14:38:48 UTC (rev 283215) @@ -9,6 +9,7 @@ # replaced (patched) elements: - sdk/adwaita-icon-theme.bst +- sdk/bubblewrap.bst - sdk/capnp.bst - sdk/cargo-c.bst - sdk/ccls.bst @@ -64,6 +65,7 @@ - sdk/woff2.bst - sdk/wpebackend-fdo.bst - sdk/x264.bst +- sdk/xdg-dbus-proxy.bst - sdk/xorg-server.bst - freedesktop-sdk.bst:components/alsa-lib.bst ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [283214] trunk/Tools/buildstream
Title: [283214] trunk/Tools/buildstream
Revision 283214
Author commit-qu...@webkit.org
Date 2021-09-29 07:25:28 -0700 (Wed, 29 Sep 2021)
Log Message
[Flatpak SDK] rr replay is broken
https://bugs.webkit.org/show_bug.cgi?id=230952
Patch by Philippe Normand on 2021-09-29
Reviewed by Sergio Villar Senin.
* patches/rr/0001-cmake-Look-for-resources-in-cmake-s-install-lib-dir.patch: As lib
resources and bin resources don't necessarily share the same parent directory, one lookup
function is needed for each use-case.
Modified Paths
trunk/Tools/buildstream/ChangeLog
trunk/Tools/buildstream/patches/rr/0001-cmake-Look-for-resources-in-cmake-s-install-lib-dir.patch
Diff
Modified: trunk/Tools/buildstream/ChangeLog (283213 => 283214)
--- trunk/Tools/buildstream/ChangeLog 2021-09-29 11:12:44 UTC (rev 283213)
+++ trunk/Tools/buildstream/ChangeLog 2021-09-29 14:25:28 UTC (rev 283214)
@@ -1,5 +1,16 @@
2021-09-29 Philippe Normand
+[Flatpak SDK] rr replay is broken
+https://bugs.webkit.org/show_bug.cgi?id=230952
+
+Reviewed by Sergio Villar Senin.
+
+* patches/rr/0001-cmake-Look-for-resources-in-cmake-s-install-lib-dir.patch: As lib
+resources and bin resources don't necessarily share the same parent directory, one lookup
+function is needed for each use-case.
+
+2021-09-29 Philippe Normand
+
[Flatpak SDK] rr unable to locate librrpage.so
https://bugs.webkit.org/show_bug.cgi?id=230942
Modified: trunk/Tools/buildstream/patches/rr/0001-cmake-Look-for-resources-in-cmake-s-install-lib-dir.patch (283213 => 283214)
--- trunk/Tools/buildstream/patches/rr/0001-cmake-Look-for-resources-in-cmake-s-install-lib-dir.patch 2021-09-29 11:12:44 UTC (rev 283213)
+++ trunk/Tools/buildstream/patches/rr/0001-cmake-Look-for-resources-in-cmake-s-install-lib-dir.patch 2021-09-29 14:25:28 UTC (rev 283214)
@@ -1,4 +1,4 @@
-From 26ba5099f19ba2e00f84aff797be7740fead4aee Mon Sep 17 00:00:00 2001
+From e9ceecb54cdfbf45b6eeb296fb078072e83327c2 Mon Sep 17 00:00:00 2001
From: Philippe Normand
Date: Wed, 29 Sep 2021 10:22:00 +0100
Subject: [PATCH] cmake: Look for resources in cmake's install lib dir
@@ -5,9 +5,9 @@
---
CMakeLists.txt | 4
- src/config.h.in | 6 ++
- src/util.cc | 11 +++
- 3 files changed, 13 insertions(+), 8 deletions(-)
+ src/config.h.in | 7 +++
+ src/util.cc | 30 ++
+ 3 files changed, 21 insertions(+), 20 deletions(-)
create mode 100644 src/config.h.in
diff --git a/CMakeLists.txt b/CMakeLists.txt
@@ -27,18 +27,19 @@
set(supports32bit true)
diff --git a/src/config.h.in b/src/config.h.in
new file mode 100644
-index ..059aeb43
+index ..b1188ba7
--- /dev/null
+++ b/src/config.h.in
-@@ -0,0 +1,6 @@
+@@ -0,0 +1,7 @@
+#ifndef RR_CONFIG_H_
+#define RR_CONFIG_H_
+
-+#define RESOURCES_LIB_DIR "@CMAKE_INSTALL_PREFIX@/@CMAKE_INSTALL_LIBDIR@/"
++#define RESOURCES_PATH "@CMAKE_INSTALL_PREFIX@/"
++#define RESOURCES_LIB_PATH "@CMAKE_INSTALL_PREFIX@/@CMAKE_INSTALL_LIBDIR@/"
+
+#endif
diff --git a/src/util.cc b/src/util.cc
-index c57ae7b6..b2ac7bac 100644
+index c57ae7b6..debc3310 100644
--- a/src/util.cc
+++ b/src/util.cc
@@ -45,6 +45,7 @@
@@ -49,22 +50,47 @@
void good_random(uint8_t* out, size_t out_len);
-@@ -1261,8 +1262,7 @@ static string read_exe_dir() {
- string resource_path() {
+@@ -1245,26 +1246,20 @@ string real_path(const string& path) {
+ return path;
+ }
+
+-static string read_exe_dir() {
+- KernelMapping km =
+- AddressSpace::read_local_kernel_mapping((uint8_t*)&read_exe_dir);
+- string exe_path = km.fsname();
+- int end = exe_path.length();
+- // Chop off the filename
+- while (end > 0 && exe_path[end - 1] != '/') {
+---end;
++string resource_path() {
++ string resource_path = Flags::get().resource_path;
++ if (resource_path.empty()) {
++return RESOURCES_PATH;
+ }
+- exe_path.erase(end);
+- return exe_path;
++ return resource_path;
+ }
+
+-string resource_path() {
++string resource_lib_path() {
string resource_path = Flags::get().resource_path;
if (resource_path.empty()) {
-static string exe_path = read_exe_dir() + "../";
-return exe_path;
-+return RESOURCES_LIB_DIR;
++return RESOURCES_LIB_PATH;
}
- return resource_path;
+- return resource_path;
++ return resource_path + "/lib/";
}
-@@ -1294,16 +1294,11 @@ bool running_under_rr(bool cache) {
+ /**
+@@ -1294,16 +1289,11 @@ bool running_under_rr(bool cache) {
+
string find_helper_library(const char *basepath)
{
- string lib_path = resource_path() + "lib64/rr/";
-+ string lib_path = resource_path() + "rr/";
++ string lib_path = resource_lib_path() + "rr/";
string file_name = lib_path + basepath;
if (access(file_name.c_str(), F_OK) == 0) {
return lib_path;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mail
[webkit-changes] [283213] trunk/Tools/buildstream
Title: [283213] trunk/Tools/buildstream
Revision 283213
Author commit-qu...@webkit.org
Date 2021-09-29 04:12:44 -0700 (Wed, 29 Sep 2021)
Log Message
[Flatpak SDK] rr unable to locate librrpage.so
https://bugs.webkit.org/show_bug.cgi?id=230942
Patch by Philippe Normand on 2021-09-29
Reviewed by Sergio Villar Senin.
Look for resources in cmake's install lib dir.
* elements/sdk/rr.bst:
* patches/rr/0001-cmake-Look-for-resources-in-cmake-s-install-lib-dir.patch: Added.
Modified Paths
trunk/Tools/buildstream/ChangeLog
trunk/Tools/buildstream/elements/sdk/rr.bst
Added Paths
trunk/Tools/buildstream/patches/rr/
trunk/Tools/buildstream/patches/rr/0001-cmake-Look-for-resources-in-cmake-s-install-lib-dir.patch
Diff
Modified: trunk/Tools/buildstream/ChangeLog (283212 => 283213)
--- trunk/Tools/buildstream/ChangeLog 2021-09-29 06:32:29 UTC (rev 283212)
+++ trunk/Tools/buildstream/ChangeLog 2021-09-29 11:12:44 UTC (rev 283213)
@@ -1,3 +1,15 @@
+2021-09-29 Philippe Normand
+
+[Flatpak SDK] rr unable to locate librrpage.so
+https://bugs.webkit.org/show_bug.cgi?id=230942
+
+Reviewed by Sergio Villar Senin.
+
+Look for resources in cmake's install lib dir.
+
+* elements/sdk/rr.bst:
+* patches/rr/0001-cmake-Look-for-resources-in-cmake-s-install-lib-dir.patch: Added.
+
2021-09-28 Philippe Normand
[Flatpak SDK] Update libsoup3 and friends
Modified: trunk/Tools/buildstream/elements/sdk/rr.bst (283212 => 283213)
--- trunk/Tools/buildstream/elements/sdk/rr.bst 2021-09-29 06:32:29 UTC (rev 283212)
+++ trunk/Tools/buildstream/elements/sdk/rr.bst 2021-09-29 11:12:44 UTC (rev 283213)
@@ -15,3 +15,5 @@
url: github_com:rr-debugger/rr
track: master
ref: 5.5.0-5-gc168a271dd5f3685834a74e5d96f60cc89a9f6c0
+- kind: patch
+ path: patches/rr/0001-cmake-Look-for-resources-in-cmake-s-install-lib-dir.patch
Added: trunk/Tools/buildstream/patches/rr/0001-cmake-Look-for-resources-in-cmake-s-install-lib-dir.patch (0 => 283213)
--- trunk/Tools/buildstream/patches/rr/0001-cmake-Look-for-resources-in-cmake-s-install-lib-dir.patch (rev 0)
+++ trunk/Tools/buildstream/patches/rr/0001-cmake-Look-for-resources-in-cmake-s-install-lib-dir.patch 2021-09-29 11:12:44 UTC (rev 283213)
@@ -0,0 +1,82 @@
+From 26ba5099f19ba2e00f84aff797be7740fead4aee Mon Sep 17 00:00:00 2001
+From: Philippe Normand
+Date: Wed, 29 Sep 2021 10:22:00 +0100
+Subject: [PATCH] cmake: Look for resources in cmake's install lib dir
+
+---
+ CMakeLists.txt | 4
+ src/config.h.in | 6 ++
+ src/util.cc | 11 +++
+ 3 files changed, 13 insertions(+), 8 deletions(-)
+ create mode 100644 src/config.h.in
+
+diff --git a/CMakeLists.txt b/CMakeLists.txt
+index e28d95aa..d38b3df2 100644
+--- a/CMakeLists.txt
b/CMakeLists.txt
+@@ -49,6 +49,10 @@ configure_file(
+ ${CMAKE_SOURCE_DIR}/src/git_revision.h.in
+ ${CMAKE_BINARY_DIR}/git_revision.h
+ )
++configure_file(
++ ${CMAKE_SOURCE_DIR}/src/config.h.in
++ ${CMAKE_BINARY_DIR}/config.h
++)
+
+ set(FLAGS_COMMON "-D__USE_LARGEFILE64 -pthread")
+ set(supports32bit true)
+diff --git a/src/config.h.in b/src/config.h.in
+new file mode 100644
+index ..059aeb43
+--- /dev/null
b/src/config.h.in
+@@ -0,0 +1,6 @@
++#ifndef RR_CONFIG_H_
++#define RR_CONFIG_H_
++
++#define RESOURCES_LIB_DIR "@CMAKE_INSTALL_PREFIX@/@CMAKE_INSTALL_LIBDIR@/"
++
++#endif
+diff --git a/src/util.cc b/src/util.cc
+index c57ae7b6..b2ac7bac 100644
+--- a/src/util.cc
b/src/util.cc
+@@ -45,6 +45,7 @@
+ #include "kernel_metadata.h"
+ #include "log.h"
+ #include "seccomp-bpf.h"
++#include "config.h"
+
+ void good_random(uint8_t* out, size_t out_len);
+
+@@ -1261,8 +1262,7 @@ static string read_exe_dir() {
+ string resource_path() {
+ string resource_path = Flags::get().resource_path;
+ if (resource_path.empty()) {
+-static string exe_path = read_exe_dir() + "../";
+-return exe_path;
++return RESOURCES_LIB_DIR;
+ }
+ return resource_path;
+ }
+@@ -1294,16 +1294,11 @@ bool running_under_rr(bool cache) {
+
+ string find_helper_library(const char *basepath)
+ {
+- string lib_path = resource_path() + "lib64/rr/";
++ string lib_path = resource_path() + "rr/";
+ string file_name = lib_path + basepath;
+ if (access(file_name.c_str(), F_OK) == 0) {
+ return lib_path;
+ }
+- lib_path = resource_path() + "lib/rr/";
+- file_name = lib_path + basepath;
+- if (access(file_name.c_str(), F_OK) == 0) {
+-return lib_path;
+- }
+ // File does not exist. Assume install put it in LD_LIBRARY_PATH.
+ lib_path = "";
+ return lib_path;
+--
+2.31.1
+
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
