[webkit-changes] [284333] trunk/Source/WebCore
Title: [284333] trunk/Source/WebCore
Revision 284333
Author za...@apple.com
Date 2021-10-16 22:58:00 -0700 (Sat, 16 Oct 2021)
Log Message
[LFC][IFC] Adjust the logical right side of the line with line spanning inline boxes
https://bugs.webkit.org/show_bug.cgi?id=231862
Reviewed by Antti Koivisto.
This patch is in preparation for supporting "box-decoration-break: clone".
1. The line spanning inline box takes up space on the line (see line logical width)
2. The inline box may be getting closed on the line (do not double account for the end width, see handleInlineContent )
3. When we commit the inline box closing, turn the ending into just a normal run (see appendInlineBoxEnd )
* layout/formattingContexts/inline/InlineLine.cpp:
(WebCore::Layout::Line::initialize):
(WebCore::Layout::Line::appendInlineBoxStart):
(WebCore::Layout::Line::appendInlineBoxEnd):
(WebCore::Layout::Line::appendTextContent):
(WebCore::Layout::Line::appendNonReplacedInlineLevelBox):
(WebCore::Layout::Line::appendLineBreak):
(WebCore::Layout::Line::appendWordBreakOpportunity):
* layout/formattingContexts/inline/InlineLine.h:
(WebCore::Layout::Line::contentLogicalRight const):
(WebCore::Layout::Line::lineSpanningInlineBoxRunEnds const):
(WebCore::Layout::Line::lastRunLogicalRight const):
* layout/formattingContexts/inline/InlineLineBuilder.cpp:
(WebCore::Layout::LineBuilder::handleInlineContent):
(WebCore::Layout::LineBuilder::rebuildLineForTrailingSoftHyphen):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/layout/formattingContexts/inline/InlineLine.cpp
trunk/Source/WebCore/layout/formattingContexts/inline/InlineLine.h
trunk/Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (284332 => 284333)
--- trunk/Source/WebCore/ChangeLog 2021-10-17 04:52:41 UTC (rev 284332)
+++ trunk/Source/WebCore/ChangeLog 2021-10-17 05:58:00 UTC (rev 284333)
@@ -1,3 +1,32 @@
+2021-10-16 Alan Bujtas
+
+[LFC][IFC] Adjust the logical right side of the line with line spanning inline boxes
+https://bugs.webkit.org/show_bug.cgi?id=231862
+
+Reviewed by Antti Koivisto.
+
+This patch is in preparation for supporting "box-decoration-break: clone".
+
+1. The line spanning inline box takes up space on the line (see line logical width)
+2. The inline box may be getting closed on the line (do not double account for the end width, see handleInlineContent )
+3. When we commit the inline box closing, turn the ending into just a normal run (see appendInlineBoxEnd )
+
+* layout/formattingContexts/inline/InlineLine.cpp:
+(WebCore::Layout::Line::initialize):
+(WebCore::Layout::Line::appendInlineBoxStart):
+(WebCore::Layout::Line::appendInlineBoxEnd):
+(WebCore::Layout::Line::appendTextContent):
+(WebCore::Layout::Line::appendNonReplacedInlineLevelBox):
+(WebCore::Layout::Line::appendLineBreak):
+(WebCore::Layout::Line::appendWordBreakOpportunity):
+* layout/formattingContexts/inline/InlineLine.h:
+(WebCore::Layout::Line::contentLogicalRight const):
+(WebCore::Layout::Line::lineSpanningInlineBoxRunEnds const):
+(WebCore::Layout::Line::lastRunLogicalRight const):
+* layout/formattingContexts/inline/InlineLineBuilder.cpp:
+(WebCore::Layout::LineBuilder::handleInlineContent):
+(WebCore::Layout::LineBuilder::rebuildLineForTrailingSoftHyphen):
+
2021-10-16 Robin Morisset
Allow WASM to use up to 4GB
Modified: trunk/Source/WebCore/layout/formattingContexts/inline/InlineLine.cpp (284332 => 284333)
--- trunk/Source/WebCore/layout/formattingContexts/inline/InlineLine.cpp 2021-10-17 04:52:41 UTC (rev 284332)
+++ trunk/Source/WebCore/layout/formattingContexts/inline/InlineLine.cpp 2021-10-17 05:58:00 UTC (rev 284333)
@@ -52,6 +52,8 @@
void Line::initialize(const Vector& lineSpanningInlineBoxes)
{
+m_lineSpanningInlineBoxRunEnds.clear();
+m_lineSpanningInlineBoxRunEndWidth = { };
m_nonSpanningInlineLevelBoxCount = 0;
m_contentLogicalWidth = { };
m_runs.clear();
@@ -63,18 +65,23 @@
shouldCheckForMarginBorderAndPadding = inlineBoxStartItem.style().boxDecorationBreak() == BoxDecorationBreak::Clone;
#endif
if (!shouldCheckForMarginBorderAndPadding) {
-m_runs.append({ inlineBoxStartItem, contentLogicalRight(), { } });
+m_runs.append({ inlineBoxStartItem, lastRunLogicalRight(), { } });
continue;
}
// https://drafts.csswg.org/css-break/#break-decoration
// clone: Each box fragment is independently wrapped with the border, padding, and margin.
auto& inlineBoxGeometry = formattingContext().geometryForBox(inlineBoxStartItem.layoutBox());
-auto runLogicalLeft = contentLogicalRight();
-auto marginBorderAndPadding =
[webkit-changes] [284332] trunk/Source/JavaScriptCore
Title: [284332] trunk/Source/_javascript_Core
Revision 284332
Author ysuz...@apple.com
Date 2021-10-16 21:52:41 -0700 (Sat, 16 Oct 2021)
Log Message
[JSC] Use SourceID in SamplingProfiler
https://bugs.webkit.org/show_bug.cgi?id=231855
Reviewed by Mark Lam.
SamplingProfiler was still using intptr_t. We replace it with SourceID.
We also define internalSourceID and aggregatedExternalSourceID in SourceID.h.
They are special SourceID internally used in SamplingProfiler.
* bytecode/SourceID.h:
* runtime/SamplingProfiler.cpp:
(JSC::SamplingProfiler::StackFrame::sourceID):
(JSC::SamplingProfiler::reportTopFunctions):
* runtime/SamplingProfiler.h:
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/bytecode/SourceID.h
trunk/Source/_javascript_Core/runtime/SamplingProfiler.cpp
trunk/Source/_javascript_Core/runtime/SamplingProfiler.h
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (284331 => 284332)
--- trunk/Source/_javascript_Core/ChangeLog 2021-10-17 04:03:21 UTC (rev 284331)
+++ trunk/Source/_javascript_Core/ChangeLog 2021-10-17 04:52:41 UTC (rev 284332)
@@ -1,3 +1,20 @@
+2021-10-16 Yusuke Suzuki
+
+[JSC] Use SourceID in SamplingProfiler
+https://bugs.webkit.org/show_bug.cgi?id=231855
+
+Reviewed by Mark Lam.
+
+SamplingProfiler was still using intptr_t. We replace it with SourceID.
+We also define internalSourceID and aggregatedExternalSourceID in SourceID.h.
+They are special SourceID internally used in SamplingProfiler.
+
+* bytecode/SourceID.h:
+* runtime/SamplingProfiler.cpp:
+(JSC::SamplingProfiler::StackFrame::sourceID):
+(JSC::SamplingProfiler::reportTopFunctions):
+* runtime/SamplingProfiler.h:
+
2021-10-16 Robin Morisset
Allow WASM to use up to 4GB
Modified: trunk/Source/_javascript_Core/bytecode/SourceID.h (284331 => 284332)
--- trunk/Source/_javascript_Core/bytecode/SourceID.h 2021-10-17 04:03:21 UTC (rev 284331)
+++ trunk/Source/_javascript_Core/bytecode/SourceID.h 2021-10-17 04:52:41 UTC (rev 284332)
@@ -29,4 +29,7 @@
using SourceID = uint32_t;
+static constexpr SourceID internalSourceID = std::numeric_limits::max();
+static constexpr SourceID aggregatedExternalSourceID = std::numeric_limits::max() - 1;
+
} // namespace JSC
Modified: trunk/Source/_javascript_Core/runtime/SamplingProfiler.cpp (284331 => 284332)
--- trunk/Source/_javascript_Core/runtime/SamplingProfiler.cpp 2021-10-17 04:03:21 UTC (rev 284331)
+++ trunk/Source/_javascript_Core/runtime/SamplingProfiler.cpp 2021-10-17 04:52:41 UTC (rev 284332)
@@ -1074,7 +1074,7 @@
hash = stream.toString();
} else
hash = ""_s;
-intptr_t sourceID = frame.sourceID();
+SourceID sourceID = frame.sourceID();
if (Options::samplingProfilerIgnoreExternalSourceID()) {
if (sourceID != internalSourceID)
sourceID = aggregatedExternalSourceID;
Modified: trunk/Source/_javascript_Core/runtime/SamplingProfiler.h (284331 => 284332)
--- trunk/Source/_javascript_Core/runtime/SamplingProfiler.h 2021-10-17 04:03:21 UTC (rev 284331)
+++ trunk/Source/_javascript_Core/runtime/SamplingProfiler.h 2021-10-17 04:52:41 UTC (rev 284332)
@@ -79,8 +79,6 @@
C,
Unknown,
};
-static constexpr intptr_t internalSourceID = -1;
-static constexpr intptr_t aggregatedExternalSourceID = -2;
struct StackFrame {
StackFrame(ExecutableBase* executable)
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [284331] trunk/Source/WebKit
Title: [284331] trunk/Source/WebKit
Revision 284331
Author ddkil...@apple.com
Date 2021-10-16 21:03:21 -0700 (Sat, 16 Oct 2021)
Log Message
[WebAuthn] Many Objective-C classes leak their instance variables
Reviewed by Brent Fulgham.
* UIProcess/API/Cocoa/_WKAuthenticationExtensionsClientInputs.mm:
(-[_WKAuthenticationExtensionsClientInputs dealloc]):
* UIProcess/API/Cocoa/_WKPublicKeyCredentialCreationOptions.mm:
(-[_WKPublicKeyCredentialCreationOptions dealloc]):
* UIProcess/API/Cocoa/_WKPublicKeyCredentialDescriptor.mm:
(-[_WKPublicKeyCredentialDescriptor dealloc]):
* UIProcess/API/Cocoa/_WKPublicKeyCredentialEntity.mm:
(-[_WKPublicKeyCredentialEntity dealloc]):
* UIProcess/API/Cocoa/_WKPublicKeyCredentialParameters.mm:
(-[_WKPublicKeyCredentialParameters dealloc]):
* UIProcess/API/Cocoa/_WKPublicKeyCredentialRelyingPartyEntity.mm:
(-[_WKPublicKeyCredentialRelyingPartyEntity dealloc]):
* UIProcess/API/Cocoa/_WKPublicKeyCredentialRequestOptions.mm:
(-[_WKPublicKeyCredentialRequestOptions dealloc]):
* UIProcess/API/Cocoa/_WKPublicKeyCredentialUserEntity.mm:
(-[_WKPublicKeyCredentialUserEntity dealloc]):
- Add -dealloc methods that release instance variables.
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/API/Cocoa/_WKAuthenticationExtensionsClientInputs.mm
trunk/Source/WebKit/UIProcess/API/Cocoa/_WKPublicKeyCredentialCreationOptions.mm
trunk/Source/WebKit/UIProcess/API/Cocoa/_WKPublicKeyCredentialDescriptor.mm
trunk/Source/WebKit/UIProcess/API/Cocoa/_WKPublicKeyCredentialEntity.mm
trunk/Source/WebKit/UIProcess/API/Cocoa/_WKPublicKeyCredentialParameters.mm
trunk/Source/WebKit/UIProcess/API/Cocoa/_WKPublicKeyCredentialRelyingPartyEntity.mm
trunk/Source/WebKit/UIProcess/API/Cocoa/_WKPublicKeyCredentialRequestOptions.mm
trunk/Source/WebKit/UIProcess/API/Cocoa/_WKPublicKeyCredentialUserEntity.mm
Diff
Modified: trunk/Source/WebKit/ChangeLog (284330 => 284331)
--- trunk/Source/WebKit/ChangeLog 2021-10-17 04:00:16 UTC (rev 284330)
+++ trunk/Source/WebKit/ChangeLog 2021-10-17 04:03:21 UTC (rev 284331)
@@ -1,5 +1,31 @@
2021-10-16 David Kilzer
+[WebAuthn] Many Objective-C classes leak their instance variables
+
+
+
+Reviewed by Brent Fulgham.
+
+* UIProcess/API/Cocoa/_WKAuthenticationExtensionsClientInputs.mm:
+(-[_WKAuthenticationExtensionsClientInputs dealloc]):
+* UIProcess/API/Cocoa/_WKPublicKeyCredentialCreationOptions.mm:
+(-[_WKPublicKeyCredentialCreationOptions dealloc]):
+* UIProcess/API/Cocoa/_WKPublicKeyCredentialDescriptor.mm:
+(-[_WKPublicKeyCredentialDescriptor dealloc]):
+* UIProcess/API/Cocoa/_WKPublicKeyCredentialEntity.mm:
+(-[_WKPublicKeyCredentialEntity dealloc]):
+* UIProcess/API/Cocoa/_WKPublicKeyCredentialParameters.mm:
+(-[_WKPublicKeyCredentialParameters dealloc]):
+* UIProcess/API/Cocoa/_WKPublicKeyCredentialRelyingPartyEntity.mm:
+(-[_WKPublicKeyCredentialRelyingPartyEntity dealloc]):
+* UIProcess/API/Cocoa/_WKPublicKeyCredentialRequestOptions.mm:
+(-[_WKPublicKeyCredentialRequestOptions dealloc]):
+* UIProcess/API/Cocoa/_WKPublicKeyCredentialUserEntity.mm:
+(-[_WKPublicKeyCredentialUserEntity dealloc]):
+- Add -dealloc methods that release instance variables.
+
+2021-10-16 David Kilzer
+
_WKRemoteWebInspectorViewController leaks an instance variable and should use a weak delegate
Modified: trunk/Source/WebKit/UIProcess/API/Cocoa/_WKAuthenticationExtensionsClientInputs.mm (284330 => 284331)
--- trunk/Source/WebKit/UIProcess/API/Cocoa/_WKAuthenticationExtensionsClientInputs.mm 2021-10-17 04:00:16 UTC (rev 284330)
+++ trunk/Source/WebKit/UIProcess/API/Cocoa/_WKAuthenticationExtensionsClientInputs.mm 2021-10-17 04:03:21 UTC (rev 284331)
@@ -1,5 +1,5 @@
/*
- * Copyright (C) 2020 Apple Inc. All rights reserved.
+ * Copyright (C) 2020-2021 Apple Inc. All rights reserved.
*
* Redistribution and use in source and binary forms, with or without
* modification, are permitted provided that the following conditions
@@ -27,4 +27,11 @@
#import "_WKAuthenticationExtensionsClientInputs.h"
@implementation _WKAuthenticationExtensionsClientInputs
+
+- (void)dealloc
+{
+[_appid release];
+[super dealloc];
+}
+
@end
Modified: trunk/Source/WebKit/UIProcess/API/Cocoa/_WKPublicKeyCredentialCreationOptions.mm (284330 => 284331)
--- trunk/Source/WebKit/UIProcess/API/Cocoa/_WKPublicKeyCredentialCreationOptions.mm 2021-10-17 04:00:16 UTC (rev 284330)
+++ trunk/Source/WebKit/UIProcess/API/Cocoa/_WKPublicKeyCredentialCreationOptions.mm 2021-10-17 04:03:21 UTC (rev 284331)
@@ -1,5 +1,5 @@
/*
- * Copyright (C) 2020 Apple Inc. All rights reserved.
+ * Copyright (C) 2020-2021 Apple Inc. All rights reserved.
*
* Redistribution and use in source and binary forms, with or without
* modification, are permitted provided that the following
[webkit-changes] [284329] trunk/Source/WebKit
Title: [284329] trunk/Source/WebKit
Revision 284329
Author ddkil...@apple.com
Date 2021-10-16 20:58:51 -0700 (Sat, 16 Oct 2021)
Log Message
_WKRemoteWebInspectorViewController leaks an instance variable and should use a weak delegate
Reviewed by Brent Fulgham.
* UIProcess/API/Cocoa/_WKRemoteWebInspectorViewController.h:
- Use a weak reference for the delegate.
* UIProcess/API/Cocoa/_WKRemoteWebInspectorViewController.mm:
(-[_WKRemoteWebInspectorViewController dealloc]): Add.
- Fix leak by releasing _configuration instance variable.
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/API/Cocoa/_WKRemoteWebInspectorViewController.h
trunk/Source/WebKit/UIProcess/API/Cocoa/_WKRemoteWebInspectorViewController.mm
Diff
Modified: trunk/Source/WebKit/ChangeLog (284328 => 284329)
--- trunk/Source/WebKit/ChangeLog 2021-10-16 23:41:39 UTC (rev 284328)
+++ trunk/Source/WebKit/ChangeLog 2021-10-17 03:58:51 UTC (rev 284329)
@@ -1,3 +1,17 @@
+2021-10-16 David Kilzer
+
+_WKRemoteWebInspectorViewController leaks an instance variable and should use a weak delegate
+
+
+
+Reviewed by Brent Fulgham.
+
+* UIProcess/API/Cocoa/_WKRemoteWebInspectorViewController.h:
+- Use a weak reference for the delegate.
+* UIProcess/API/Cocoa/_WKRemoteWebInspectorViewController.mm:
+(-[_WKRemoteWebInspectorViewController dealloc]): Add.
+- Fix leak by releasing _configuration instance variable.
+
2021-10-16 Tim Horton
WebKit ignores inherited GCC_PREPROCESSOR_DEFINITIONS
Modified: trunk/Source/WebKit/UIProcess/API/Cocoa/_WKRemoteWebInspectorViewController.h (284328 => 284329)
--- trunk/Source/WebKit/UIProcess/API/Cocoa/_WKRemoteWebInspectorViewController.h 2021-10-16 23:41:39 UTC (rev 284328)
+++ trunk/Source/WebKit/UIProcess/API/Cocoa/_WKRemoteWebInspectorViewController.h 2021-10-17 03:58:51 UTC (rev 284329)
@@ -40,7 +40,7 @@
WK_CLASS_AVAILABLE(macos(10.12.3))
@interface _WKRemoteWebInspectorViewController : NSObject <_WKInspectorExtensionHost, _WKInspectorIBActions>
-@property (nonatomic, assign) id <_WKRemoteWebInspectorViewControllerDelegate> delegate;
+@property (nonatomic, weak) id <_WKRemoteWebInspectorViewControllerDelegate> delegate;
@property (nonatomic, readonly, retain) NSWindow *window;
@property (nonatomic, readonly, retain) WKWebView *webView;
Modified: trunk/Source/WebKit/UIProcess/API/Cocoa/_WKRemoteWebInspectorViewController.mm (284328 => 284329)
--- trunk/Source/WebKit/UIProcess/API/Cocoa/_WKRemoteWebInspectorViewController.mm 2021-10-16 23:41:39 UTC (rev 284328)
+++ trunk/Source/WebKit/UIProcess/API/Cocoa/_WKRemoteWebInspectorViewController.mm 2021-10-17 03:58:51 UTC (rev 284329)
@@ -1,5 +1,5 @@
/*
- * Copyright (C) 2016 Apple Inc. All rights reserved.
+ * Copyright (C) 2016-2021 Apple Inc. All rights reserved.
*
* Redistribution and use in source and binary forms, with or without
* modification, are permitted provided that the following conditions
@@ -105,6 +105,12 @@
return self;
}
+- (void)dealloc
+{
+[_configuration release];
+[super dealloc];
+}
+
- (NSWindow *)window
{
return m_remoteInspectorProxy->window();
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [284328] trunk/LayoutTests
Title: [284328] trunk/LayoutTests Revision 284328 Author timothy_hor...@apple.com Date 2021-10-16 16:41:39 -0700 (Sat, 16 Oct 2021) Log Message Unreviewed, revert r284181 No longer needed because the root cause was reverted. * platform/mac-wk2/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/mac-wk2/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (284327 => 284328) --- trunk/LayoutTests/ChangeLog 2021-10-16 23:36:42 UTC (rev 284327) +++ trunk/LayoutTests/ChangeLog 2021-10-16 23:41:39 UTC (rev 284328) @@ -1,3 +1,11 @@ +2021-10-16 Tim Horton + +Unreviewed, revert r284181 + +No longer needed because the root cause was reverted. + +* platform/mac-wk2/TestExpectations: + 2021-10-16 Alan Bujtas [LFC][IFC] Adjust the logical left side of the line with line spanning inline boxes Modified: trunk/LayoutTests/platform/mac-wk2/TestExpectations (284327 => 284328) --- trunk/LayoutTests/platform/mac-wk2/TestExpectations 2021-10-16 23:36:42 UTC (rev 284327) +++ trunk/LayoutTests/platform/mac-wk2/TestExpectations 2021-10-16 23:41:39 UTC (rev 284328) @@ -1680,8 +1680,6 @@ webkit.org/b/231600 [ Release ] imported/w3c/web-platform-tests/css/cssom-view/scroll-behavior-main-frame-window.html [ Pass Failure ] webkit.org/b/231600 [ Release ] imported/w3c/web-platform-tests/css/cssom-view/scroll-behavior-main-frame-root.html [ Failure ] -webkit.org/b/231752 [ Debug ] imported/w3c/web-platform-tests/css/css-contain/content-visibility/content-visibility-049.html [ Pass Crash ] - webkit.org/b/231765 [ Release ] http/tests/resourceLoadStatistics/website-data-removal-for-site-navigated-to-with-link-decoration.html [ Pass Timeout ] webkit.org/b/231780 [ Debug ] imported/w3c/web-platform-tests/webrtc/simulcast/basic.https.html [ Pass Failure ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [284327] trunk
Title: [284327] trunk
Revision 284327
Author za...@apple.com
Date 2021-10-16 16:36:42 -0700 (Sat, 16 Oct 2021)
Log Message
[LFC][IFC] Adjust the logical left side of the line with line spanning inline boxes
https://bugs.webkit.org/show_bug.cgi?id=231851
Reviewed by Antti Koivisto.
Source/WebCore:
This is in preparation for supporting "box-decoration-break: clone", where the
line spanning inline boxes do take up some space on the line with their horizontal margin, border and padding.
Test: fast/inline/inline-box-with-left-decoration-clone.html
* layout/formattingContexts/inline/InlineLine.cpp:
(WebCore::Layout::Line::initialize):
(WebCore::Layout::Line::Run::Run):
* layout/formattingContexts/inline/InlineLine.h:
LayoutTests:
* fast/inline/inline-box-with-left-decoration-clone-expected.html: Added.
* fast/inline/inline-box-with-left-decoration-clone.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/layout/formattingContexts/inline/InlineLine.cpp
trunk/Source/WebCore/layout/formattingContexts/inline/InlineLine.h
Added Paths
trunk/LayoutTests/fast/inline/inline-box-with-left-decoration-clone-expected.html
trunk/LayoutTests/fast/inline/inline-box-with-left-decoration-clone.html
Diff
Modified: trunk/LayoutTests/ChangeLog (284326 => 284327)
--- trunk/LayoutTests/ChangeLog 2021-10-16 23:35:49 UTC (rev 284326)
+++ trunk/LayoutTests/ChangeLog 2021-10-16 23:36:42 UTC (rev 284327)
@@ -1,5 +1,15 @@
2021-10-16 Alan Bujtas
+[LFC][IFC] Adjust the logical left side of the line with line spanning inline boxes
+https://bugs.webkit.org/show_bug.cgi?id=231851
+
+Reviewed by Antti Koivisto.
+
+* fast/inline/inline-box-with-left-decoration-clone-expected.html: Added.
+* fast/inline/inline-box-with-left-decoration-clone.html: Added.
+
+2021-10-16 Alan Bujtas
+
Undo some rebaseline in r284296.
Unreviewed.
Added: trunk/LayoutTests/fast/inline/inline-box-with-left-decoration-clone-expected.html (0 => 284327)
--- trunk/LayoutTests/fast/inline/inline-box-with-left-decoration-clone-expected.html (rev 0)
+++ trunk/LayoutTests/fast/inline/inline-box-with-left-decoration-clone-expected.html 2021-10-16 23:36:42 UTC (rev 284327)
@@ -0,0 +1,4 @@
+thisinline boxhas paddingand margin clone
+thisinline boxhas paddingand margin clone
+thisinline boxhas paddingand margin clone
+thisinline boxhas paddingand margin clone
Added: trunk/LayoutTests/fast/inline/inline-box-with-left-decoration-clone.html (0 => 284327)
--- trunk/LayoutTests/fast/inline/inline-box-with-left-decoration-clone.html (rev 0)
+++ trunk/LayoutTests/fast/inline/inline-box-with-left-decoration-clone.html 2021-10-16 23:36:42 UTC (rev 284327)
@@ -0,0 +1,12 @@
+
+span {
+ -webkit-box-decoration-break: clone;
+ padding-left: 10px;
+ margin-left: 20px;
+}
+
+
+thisinline boxhas paddingand margin clone
+thisinline boxhas paddingand margin clone
+thisinline boxhas paddingand margin clone
+thisinline boxhas paddingand margin clone
Modified: trunk/Source/WebCore/ChangeLog (284326 => 284327)
--- trunk/Source/WebCore/ChangeLog 2021-10-16 23:35:49 UTC (rev 284326)
+++ trunk/Source/WebCore/ChangeLog 2021-10-16 23:36:42 UTC (rev 284327)
@@ -1,3 +1,20 @@
+2021-10-16 Alan Bujtas
+
+[LFC][IFC] Adjust the logical left side of the line with line spanning inline boxes
+https://bugs.webkit.org/show_bug.cgi?id=231851
+
+Reviewed by Antti Koivisto.
+
+This is in preparation for supporting "box-decoration-break: clone", where the
+line spanning inline boxes do take up some space on the line with their horizontal margin, border and padding.
+
+Test: fast/inline/inline-box-with-left-decoration-clone.html
+
+* layout/formattingContexts/inline/InlineLine.cpp:
+(WebCore::Layout::Line::initialize):
+(WebCore::Layout::Line::Run::Run):
+* layout/formattingContexts/inline/InlineLine.h:
+
2021-10-16 Tim Horton
Unreviewed, reverting r284143.
Modified: trunk/Source/WebCore/layout/formattingContexts/inline/InlineLine.cpp (284326 => 284327)
--- trunk/Source/WebCore/layout/formattingContexts/inline/InlineLine.cpp 2021-10-16 23:35:49 UTC (rev 284326)
+++ trunk/Source/WebCore/layout/formattingContexts/inline/InlineLine.cpp 2021-10-16 23:36:42 UTC (rev 284327)
@@ -57,8 +57,25 @@
m_runs.clear();
resetTrailingContent();
auto appendLineSpanningInlineBoxes = [&] {
-for (auto& inlineBoxStartItem : lineSpanningInlineBoxes)
-m_runs.append({ inlineBoxStartItem });
+for (auto& inlineBoxStartItem : lineSpanningInlineBoxes) {
+auto shouldCheckForMarginBorderAndPadding = false;
+#if ENABLE(CSS_BOX_DECORATION_BREAK)
+shouldCheckForMarginBorderAndPadding = inlineBoxStartItem.style().boxDecorationBreak() == BoxDecorationBreak::Clone;
+#endif
+if
[webkit-changes] [284326] trunk/Source
Title: [284326] trunk/Source
Revision 284326
Author timothy_hor...@apple.com
Date 2021-10-16 16:35:49 -0700 (Sat, 16 Oct 2021)
Log Message
Unreviewed, reverting r284143.
Caused a series of assertions in layout tests in EWS
Reverted changeset:
"Scroll To Text Fragment directive parsing"
https://bugs.webkit.org/show_bug.cgi?id=231410
https://commits.webkit.org/r284143
Modified Paths
trunk/Source/WTF/ChangeLog
trunk/Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Sources.txt
trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj
trunk/Source/WebCore/dom/Document.h
trunk/Source/WebCore/page/FrameView.cpp
trunk/Source/WebCore/platform/Logging.h
Removed Paths
trunk/Source/WebCore/dom/FragmentDirectiveParser.cpp
trunk/Source/WebCore/dom/FragmentDirectiveParser.h
Diff
Modified: trunk/Source/WTF/ChangeLog (284325 => 284326)
--- trunk/Source/WTF/ChangeLog 2021-10-16 22:32:19 UTC (rev 284325)
+++ trunk/Source/WTF/ChangeLog 2021-10-16 23:35:49 UTC (rev 284326)
@@ -1,3 +1,15 @@
+2021-10-16 Tim Horton
+
+Unreviewed, reverting r284143.
+
+Caused a series of assertions in layout tests in EWS
+
+Reverted changeset:
+
+"Scroll To Text Fragment directive parsing"
+https://bugs.webkit.org/show_bug.cgi?id=231410
+https://commits.webkit.org/r284143
+
2021-10-15 Basuke Suzuki
Add flag to turn off Iso heap
Modified: trunk/Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml (284325 => 284326)
--- trunk/Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml 2021-10-16 22:32:19 UTC (rev 284325)
+++ trunk/Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml 2021-10-16 23:35:49 UTC (rev 284326)
@@ -1155,18 +1155,6 @@
default: false
WebCore:
default: false
-
-ScrollToTextFragmentEnabled:
- type: bool
- humanReadableName: "Scroll To Text Fragment"
- humanReadableDescription: "Enable Scroll To Text Fragment"
- defaultValue:
-WebKitLegacy:
- default: false
-WebKit:
- default: false
-WebCore:
- default: false
ServerTimingEnabled:
type: bool
Modified: trunk/Source/WebCore/ChangeLog (284325 => 284326)
--- trunk/Source/WebCore/ChangeLog 2021-10-16 22:32:19 UTC (rev 284325)
+++ trunk/Source/WebCore/ChangeLog 2021-10-16 23:35:49 UTC (rev 284326)
@@ -1,3 +1,15 @@
+2021-10-16 Tim Horton
+
+Unreviewed, reverting r284143.
+
+Caused a series of assertions in layout tests in EWS
+
+Reverted changeset:
+
+"Scroll To Text Fragment directive parsing"
+https://bugs.webkit.org/show_bug.cgi?id=231410
+https://commits.webkit.org/r284143
+
2021-10-16 Alan Bujtas
[LFC][IFC] Add "line spanning line box start items" to Line
Modified: trunk/Source/WebCore/Sources.txt (284325 => 284326)
--- trunk/Source/WebCore/Sources.txt 2021-10-16 22:32:19 UTC (rev 284325)
+++ trunk/Source/WebCore/Sources.txt 2021-10-16 23:35:49 UTC (rev 284326)
@@ -921,7 +921,6 @@
dom/ExtensionStyleSheets.cpp
dom/FocusEvent.cpp
dom/FormDataEvent.cpp
-dom/FragmentDirectiveParser.cpp
dom/FullscreenManager.cpp
dom/GCReachableRef.cpp
dom/HashChangeEvent.cpp
Modified: trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj (284325 => 284326)
--- trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj 2021-10-16 22:32:19 UTC (rev 284325)
+++ trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj 2021-10-16 23:35:49 UTC (rev 284326)
@@ -8478,8 +8478,6 @@
443F04260E75C8FB007E5407 /* NetworkStateNotifierIOS.mm */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.objcpp; path = NetworkStateNotifierIOS.mm; sourceTree = ""; };
444D4E210F708B2E003158E0 /* WebCoreURLResponseIOS.mm */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.objcpp; path = WebCoreURLResponseIOS.mm; sourceTree = ""; };
445210DD25D61EFF003A2ED8 /* AppHighlight.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = AppHighlight.h; sourceTree = ""; };
- 445612AA270F6F3700758C97 /* FragmentDirectiveParser.cpp */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.cpp.cpp; path = FragmentDirectiveParser.cpp; sourceTree = ""; };
- 445612AB270F6F3800758C97 /* FragmentDirectiveParser.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; path = FragmentDirectiveParser.h; sourceTree = ""; };
445775E420472F73008DCE5D /* LocalDefaultSystemAppearance.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; path = LocalDefaultSystemAppearance.h; sourceTree = ""; };
445775E92047303B008DCE5D /* LocalDefaultSystemAppearance.mm */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.objcpp; path = LocalDefaultSystemAppearance.mm; sourceTree = ""; };
446DC64624A29D9B0061F390 /* PlaybackTargetClientContextIdentifier.h */ = {isa = PBXFileReference;
[webkit-changes] [284325] trunk/Source/WebKit
Title: [284325] trunk/Source/WebKit Revision 284325 Author timothy_hor...@apple.com Date 2021-10-16 15:32:19 -0700 (Sat, 16 Oct 2021) Log Message WebKit ignores inherited GCC_PREPROCESSOR_DEFINITIONS https://bugs.webkit.org/show_bug.cgi?id=231867 Reviewed by Sam Weinig. * Configurations/BaseTarget.xcconfig: Add a $(inherited) here like in every other project, so that we don't just drop defines that come from above. Modified Paths trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/Configurations/BaseTarget.xcconfig Diff Modified: trunk/Source/WebKit/ChangeLog (284324 => 284325) --- trunk/Source/WebKit/ChangeLog 2021-10-16 22:18:31 UTC (rev 284324) +++ trunk/Source/WebKit/ChangeLog 2021-10-16 22:32:19 UTC (rev 284325) @@ -1,3 +1,14 @@ +2021-10-16 Tim Horton + +WebKit ignores inherited GCC_PREPROCESSOR_DEFINITIONS +https://bugs.webkit.org/show_bug.cgi?id=231867 + +Reviewed by Sam Weinig. + +* Configurations/BaseTarget.xcconfig: +Add a $(inherited) here like in every other project, so that we don't +just drop defines that come from above. + 2021-10-16 Simon Fraser Page zoom is messed up after navigating back from a PDF Modified: trunk/Source/WebKit/Configurations/BaseTarget.xcconfig (284324 => 284325) --- trunk/Source/WebKit/Configurations/BaseTarget.xcconfig 2021-10-16 22:18:31 UTC (rev 284324) +++ trunk/Source/WebKit/Configurations/BaseTarget.xcconfig 2021-10-16 22:32:19 UTC (rev 284325) @@ -43,7 +43,7 @@ WK_FORMATREADERBUNDLE_CODESIGNING_DEFINES[config=Production] = ; GCC_PREFIX_HEADER = WebKit2Prefix.h; -GCC_PREPROCESSOR_DEFINITIONS = $(DEBUG_DEFINES) $(WK_ENABLE_EXPERIMENTAL_FEATURES) $(WK_CORE_PREDICTION_DEFINES) $(WK_FORMATREADERBUNDLE_CODESIGNING_DEFINES) FRAMEWORK_NAME=WebKit; +GCC_PREPROCESSOR_DEFINITIONS = $(DEBUG_DEFINES) $(WK_ENABLE_EXPERIMENTAL_FEATURES) $(WK_CORE_PREDICTION_DEFINES) $(WK_FORMATREADERBUNDLE_CODESIGNING_DEFINES) $(inherited) FRAMEWORK_NAME=WebKit; WEBKITADDITIONS_HEADER_SEARCH_PATHS = $(BUILT_PRODUCTS_DIR)/usr/local/include/WebKitAdditions $(SDKROOT)/usr/local/include/WebKitAdditions; LIBWEBRTC_HEADER_SEARCH_PATHS = $(BUILT_PRODUCTS_DIR)/usr/local/include/webrtc $(SDKROOT)/usr/local/include/webrtc; ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [284324] trunk
Title: [284324] trunk Revision 284324 Author commit-qu...@webkit.org Date 2021-10-16 15:18:31 -0700 (Sat, 16 Oct 2021) Log Message Add github username for tetsuharuohzeki to contributors.json https://bugs.webkit.org/show_bug.cgi?id=231864 Patch by Tetsuharu Ohzeki on 2021-10-16 Reviewed by Fujii Hironori. * metadata/contributors.json: Modified Paths trunk/ChangeLog trunk/metadata/contributors.json Diff Modified: trunk/ChangeLog (284323 => 284324) --- trunk/ChangeLog 2021-10-16 21:14:57 UTC (rev 284323) +++ trunk/ChangeLog 2021-10-16 22:18:31 UTC (rev 284324) @@ -1,3 +1,12 @@ +2021-10-16 Tetsuharu Ohzeki + +Add github username for tetsuharuohzeki to contributors.json +https://bugs.webkit.org/show_bug.cgi?id=231864 + +Reviewed by Fujii Hironori. + +* metadata/contributors.json: + 2021-10-16 Angelos Oikonomopoulos Add my github username to contributors.json Modified: trunk/metadata/contributors.json (284323 => 284324) --- trunk/metadata/contributors.json 2021-10-16 21:14:57 UTC (rev 284323) +++ trunk/metadata/contributors.json 2021-10-16 22:18:31 UTC (rev 284324) @@ -6149,6 +6149,7 @@ "emails" : [ "tetsuharu.ohz...@gmail.com" ], + "github" : "tetsuharuohzeki", "name" : "Tetsuharu Ohzeki", "nicks" : [ "tetsuharuohzeki" ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [284323] trunk/Source/WebCore
Title: [284323] trunk/Source/WebCore
Revision 284323
Author za...@apple.com
Date 2021-10-16 14:14:57 -0700 (Sat, 16 Oct 2021)
Log Message
[LFC][IFC] Add "line spanning line box start items" to Line
https://bugs.webkit.org/show_bug.cgi?id=231551
Reviewed by Antti Koivisto.
This patch is in preparation for supporting box-decoration-break: clone, where the line spanning
inline boxes may take up space on the line (border/padding).
This patch moves the construction of the spanning inline boxes to an earlier step, from LineBox to Line.
* layout/formattingContexts/inline/InlineLineBuilder.cpp:
(WebCore::Layout::LineBuilder::initialize):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/layout/formattingContexts/inline/InlineDisplayContentBuilder.cpp
trunk/Source/WebCore/layout/formattingContexts/inline/InlineItem.h
trunk/Source/WebCore/layout/formattingContexts/inline/InlineLine.cpp
trunk/Source/WebCore/layout/formattingContexts/inline/InlineLine.h
trunk/Source/WebCore/layout/formattingContexts/inline/InlineLineBoxBuilder.cpp
trunk/Source/WebCore/layout/formattingContexts/inline/InlineLineBoxBuilder.h
trunk/Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.cpp
trunk/Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (284322 => 284323)
--- trunk/Source/WebCore/ChangeLog 2021-10-16 20:32:52 UTC (rev 284322)
+++ trunk/Source/WebCore/ChangeLog 2021-10-16 21:14:57 UTC (rev 284323)
@@ -1,5 +1,19 @@
2021-10-16 Alan Bujtas
+[LFC][IFC] Add "line spanning line box start items" to Line
+https://bugs.webkit.org/show_bug.cgi?id=231551
+
+Reviewed by Antti Koivisto.
+
+This patch is in preparation for supporting box-decoration-break: clone, where the line spanning
+inline boxes may take up space on the line (border/padding).
+This patch moves the construction of the spanning inline boxes to an earlier step, from LineBox to Line.
+
+* layout/formattingContexts/inline/InlineLineBuilder.cpp:
+(WebCore::Layout::LineBuilder::initialize):
+
+2021-10-16 Alan Bujtas
+
[LFC][IFC] Move overflowing content creation to LineBuilder::initialize
https://bugs.webkit.org/show_bug.cgi?id=231540
Modified: trunk/Source/WebCore/layout/formattingContexts/inline/InlineDisplayContentBuilder.cpp (284322 => 284323)
--- trunk/Source/WebCore/layout/formattingContexts/inline/InlineDisplayContentBuilder.cpp 2021-10-16 20:32:52 UTC (rev 284322)
+++ trunk/Source/WebCore/layout/formattingContexts/inline/InlineDisplayContentBuilder.cpp 2021-10-16 21:14:57 UTC (rev 284323)
@@ -78,8 +78,7 @@
return !lineIndex ? layoutBox.firstLineStyle() : layoutBox.style();
}();
-switch (lineRun.type()) {
-case InlineItem::Type::Text: {
+if (lineRun.isText()) {
auto textRunRect = lineBox.logicalRectForTextRun(lineRun);
textRunRect.moveBy(lineBoxLogicalTopLeft);
@@ -110,9 +109,9 @@
, inkOverflow()
, lineRun.expansion()
, InlineDisplay::Box::Text { text->start, text->length, content, adjustedContentToRender(), text->needsHyphen } });
-break;
+continue;
}
-case InlineItem::Type::SoftLineBreak: {
+if (lineRun.isSoftLineBreak()) {
auto softLineBreakRunRect = lineBox.logicalRectForTextRun(lineRun);
softLineBreakRunRect.moveBy(lineBoxLogicalTopLeft);
@@ -127,7 +126,7 @@
, InlineDisplay::Box::Text { text->start, text->length, downcast(layoutBox).content() } });
break;
}
-case InlineItem::Type::HardLineBreak: {
+if (lineRun.isHardLineBreak()) {
// Only hard linebreaks have associated layout boxes.
auto lineBreakBoxRect = lineBox.logicalRectForLineBreakBox(layoutBox);
lineBreakBoxRect.moveBy(lineBoxLogicalTopLeft);
@@ -136,9 +135,9 @@
auto& boxGeometry = formattingState.boxGeometry(layoutBox);
boxGeometry.setLogicalTopLeft(toLayoutPoint(lineBreakBoxRect.topLeft()));
boxGeometry.setContentBoxHeight(toLayoutUnit(lineBreakBoxRect.height()));
-break;
+continue;
}
-case InlineItem::Type::Box: {
+if (lineRun.isBox()) {
ASSERT(layoutBox.isAtomicInlineLevelBox());
auto& boxGeometry = formattingState.boxGeometry(layoutBox);
auto logicalBorderBox = lineBox.logicalBorderBoxForAtomicInlineLevelBox(layoutBox, boxGeometry);
@@ -161,9 +160,9 @@
boxes[m_inlineBoxIndexMap.get()].adjustInkOverflow(logicalBorderBox);
};
adjustParentInlineBoxInkOverflow();
-break;
+continue;
}
-case InlineItem::Type::InlineBoxStart: {
+if (lineRun.isInlineBoxStart()) {
// This inline box showed
[webkit-changes] [284322] trunk
Title: [284322] trunk
Revision 284322
Author simon.fra...@apple.com
Date 2021-10-16 13:32:52 -0700 (Sat, 16 Oct 2021)
Log Message
Page zoom is messed up after navigating back from a PDF
https://bugs.webkit.org/show_bug.cgi?id=231841
Reviewed by Tim Horton.
Source/WebKit:
A navigation back from a PDF is a FrameLoadType::Back, so resetting
m_mainFramePluginHandlesPageScaleGesture only for FrameLoadType::Standard is wrong.
For all navigations, the plugins seem to call
pluginScaleFactorDidChange/pluginZoomFactorDidChange/
mainFramePluginHandlesPageScaleGestureDidChange so it's safe to reset them for all
navigation types.
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::didCommitLoadForFrame):
Tools:
* TestWebKitAPI/Tests/WebKitCocoa/PageZoom.mm:
(TestWebKitAPI::TEST):
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/WebPageProxy.cpp
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/PageZoom.mm
Diff
Modified: trunk/Source/WebKit/ChangeLog (284321 => 284322)
--- trunk/Source/WebKit/ChangeLog 2021-10-16 20:16:56 UTC (rev 284321)
+++ trunk/Source/WebKit/ChangeLog 2021-10-16 20:32:52 UTC (rev 284322)
@@ -1,3 +1,22 @@
+2021-10-16 Simon Fraser
+
+Page zoom is messed up after navigating back from a PDF
+https://bugs.webkit.org/show_bug.cgi?id=231841
+
+
+Reviewed by Tim Horton.
+
+A navigation back from a PDF is a FrameLoadType::Back, so resetting
+m_mainFramePluginHandlesPageScaleGesture only for FrameLoadType::Standard is wrong.
+
+For all navigations, the plugins seem to call
+pluginScaleFactorDidChange/pluginZoomFactorDidChange/
+mainFramePluginHandlesPageScaleGestureDidChange so it's safe to reset them for all
+navigation types.
+
+* UIProcess/WebPageProxy.cpp:
+(WebKit::WebPageProxy::didCommitLoadForFrame):
+
2021-10-16 Commit Queue
Unreviewed, reverting r284300.
Modified: trunk/Source/WebKit/UIProcess/WebPageProxy.cpp (284321 => 284322)
--- trunk/Source/WebKit/UIProcess/WebPageProxy.cpp 2021-10-16 20:16:56 UTC (rev 284321)
+++ trunk/Source/WebKit/UIProcess/WebPageProxy.cpp 2021-10-16 20:32:52 UTC (rev 284322)
@@ -4933,11 +4933,9 @@
// plugin is handling page scaling itself) so we should reset it to the default
// for standard main frame loads.
if (frame->isMainFrame()) {
-if (frameLoadType == FrameLoadType::Standard) {
-m_pageScaleFactor = 1;
-m_pluginScaleFactor = 1;
-m_mainFramePluginHandlesPageScaleGesture = false;
-}
+m_pageScaleFactor = 1;
+m_pluginScaleFactor = 1;
+m_mainFramePluginHandlesPageScaleGesture = false;
#if ENABLE(POINTER_LOCK)
requestPointerUnlock();
#endif
Modified: trunk/Tools/ChangeLog (284321 => 284322)
--- trunk/Tools/ChangeLog 2021-10-16 20:16:56 UTC (rev 284321)
+++ trunk/Tools/ChangeLog 2021-10-16 20:32:52 UTC (rev 284322)
@@ -1,3 +1,14 @@
+2021-10-16 Simon Fraser
+
+Page zoom is messed up after navigating back from a PDF
+https://bugs.webkit.org/show_bug.cgi?id=231841
+
+
+Reviewed by Tim Horton.
+
+* TestWebKitAPI/Tests/WebKitCocoa/PageZoom.mm:
+(TestWebKitAPI::TEST):
+
2021-10-15 Basuke Suzuki
Add flag to turn off Iso heap
Modified: trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/PageZoom.mm (284321 => 284322)
--- trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/PageZoom.mm 2021-10-16 20:16:56 UTC (rev 284321)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/PageZoom.mm 2021-10-16 20:32:52 UTC (rev 284322)
@@ -47,4 +47,25 @@
EXPECT_EQ(beforeClientWidth / 2, afterClientWidth);
}
+TEST(WKWebView, PageZoomAfterPDF)
+{
+auto webView = adoptNS([[TestWKWebView alloc] initWithFrame:NSMakeRect(0, 0, 400, 400)]);
+
+NSURLRequest *request = [NSURLRequest requestWithURL:[[NSBundle mainBundle] URLForResource:@"simple" withExtension:@"html" subdirectory:@"TestWebKitAPI.resources"]];
+[webView loadRequest:request];
+[webView _test_waitForDidFinishNavigation];
+webView.get().pageZoom = 2.0;
+auto beforePageZoom = webView.get().pageZoom;
+
+NSURLRequest *pdfRequest = [NSURLRequest requestWithURL:[[NSBundle mainBundle] URLForResource:@"test" withExtension:@"pdf" subdirectory:@"TestWebKitAPI.resources"]];
+[webView loadRequest:pdfRequest];
+[webView _test_waitForDidFinishNavigation];
+
+[webView goBack];
+[webView _test_waitForDidFinishNavigation];
+
+auto afterPageZoom = webView.get().pageZoom;
+EXPECT_EQ(beforePageZoom, afterPageZoom);
+}
+
} // namespace TestWebKitAPI
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [284321] trunk/Source/WebKit
Title: [284321] trunk/Source/WebKit Revision 284321 Author commit-qu...@webkit.org Date 2021-10-16 13:16:56 -0700 (Sat, 16 Oct 2021) Log Message Unreviewed, reverting r284300. https://bugs.webkit.org/show_bug.cgi?id=231866 broke-apple-silicon-performance Reverted changeset: "[macOS] Add telemetry for system calls in WP" https://bugs.webkit.org/show_bug.cgi?id=231836 https://commits.webkit.org/r284300 Modified Paths trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/WebProcess/com.apple.WebProcess.sb.in Diff Modified: trunk/Source/WebKit/ChangeLog (284320 => 284321) --- trunk/Source/WebKit/ChangeLog 2021-10-16 18:37:04 UTC (rev 284320) +++ trunk/Source/WebKit/ChangeLog 2021-10-16 20:16:56 UTC (rev 284321) @@ -1,3 +1,16 @@ +2021-10-16 Commit Queue + +Unreviewed, reverting r284300. +https://bugs.webkit.org/show_bug.cgi?id=231866 + +broke-apple-silicon-performance + +Reverted changeset: + +"[macOS] Add telemetry for system calls in WP" +https://bugs.webkit.org/show_bug.cgi?id=231836 +https://commits.webkit.org/r284300 + 2021-10-16 David Kilzer WebKit::LocalConnection::createCredentialPrivateKey leaks an NSMutableDictionary Modified: trunk/Source/WebKit/WebProcess/com.apple.WebProcess.sb.in (284320 => 284321) --- trunk/Source/WebKit/WebProcess/com.apple.WebProcess.sb.in 2021-10-16 18:37:04 UTC (rev 284320) +++ trunk/Source/WebKit/WebProcess/com.apple.WebProcess.sb.in 2021-10-16 20:16:56 UTC (rev 284321) @@ -1862,182 +1862,179 @@ (when (defined? 'syscall-unix) (deny syscall-unix (with send-signal SIGKILL)) -(allow syscall-unix (syscall-number -SYS___disable_threadsignal -SYS___mac_syscall -SYS___pthread_sigmask -SYS___semwait_signal -SYS_access -SYS_bsdthread_create -SYS_bsdthread_ctl -SYS_bsdthread_terminate -SYS_csrctl -SYS_exit -SYS_faccessat ;; -SYS_fcntl -SYS_fcntl_nocancel -SYS_fgetxattr -SYS_fileport_makefd -SYS_flock -SYS_fsgetpath -SYS_fstat64 -SYS_fstatat64 -SYS_fstatfs64 -SYS_ftruncate -SYS_getattrlist -SYS_getattrlistbulk -SYS_getaudit_addr -SYS_getdirentries64 -SYS_getentropy -SYS_geteuid -SYS_getfsstat64 -SYS_getgid -SYS_gethostuuid -SYS_getrlimit -SYS_getrusage -SYS_gettimeofday -SYS_getuid -SYS_getxattr -SYS_issetugid -SYS_kdebug_trace -SYS_kdebug_trace64 -SYS_kdebug_trace_string ;; Needed for performance sampling, see . -SYS_kevent_id -SYS_kevent_qos -SYS_kqueue_workloop_ctl ;; -SYS_listxattr -SYS_lseek -SYS_lstat64 -SYS_madvise -SYS_mincore -SYS_mkdir -SYS_mmap -SYS_mprotect -SYS_msync -SYS_munmap -SYS_pathconf -SYS_pread -SYS_psynch_cvbroad -SYS_psynch_cvclrprepost -SYS_psynch_cvsignal -SYS_psynch_cvwait -SYS_psynch_mutexdrop -SYS_psynch_mutexwait -SYS_psynch_rw_unlock -SYS_psynch_rw_wrlock -SYS_read -SYS_read_nocancel -SYS_readlink -SYS_rename -SYS_sendto -SYS_sigaltstack -SYS_sigprocmask -SYS_socket -SYS_stat64 -SYS_statfs64 -SYS_thread_selfid -SYS_ulock_wait -SYS_ulock_wake -SYS_umask -SYS_work_interval_ctl -SYS_workq_kernreturn)) - (allow syscall-unix -#if __MAC_OS_X_VERSION_MIN_REQUIRED >= 12 -(with telemetry-backtrace) -#endif -(syscall-number -SYS___pthread_kill -SYS___pthread_markcancel -SYS___semwait_signal_nocancel -SYS_abort_with_payload -SYS_change_fdguard_np -SYS_chmod -SYS_chmod_extended -SYS_close -SYS_close_nocancel -SYS_connect -SYS_connect_nocancel -SYS_connectx -SYS_csops -SYS_csops_audittoken -SYS_dup -SYS_fchmod -SYS_fgetattrlist ;; -SYS_fileport_makeport -SYS_fsetxattr ;; -SYS_fstat64_extended ;; -SYS_fsync -SYS_getegid -SYS_getpeername -SYS_getpriority ;; rdar://81727094. Required for CoreAudio AudioOutputUnitStart call. Remove when GPU process is enabled by default. -SYS_getsockopt -SYS_gettid ;; Needed for base system, see -SYS_guarded_close_np -SYS_guarded_open_np -SYS_guarded_pwrite_np -SYS_guarded_write_np -SYS_ioctl -SYS_kevent -SYS_kqueue ;; -SYS_lstat64_extended -SYS_lstat_extended -
[webkit-changes] [284320] branches/safari-612-branch
Title: [284320] branches/safari-612-branch
Revision 284320
Author repst...@apple.com
Date 2021-10-16 11:37:04 -0700 (Sat, 16 Oct 2021)
Log Message
Revert "Apply patch. rdar://problem/83953730"
This reverts commit ee910ccd94f646fb5f318a78cfd6910432830a1e.
Modified Paths
branches/safari-612-branch/LayoutTests/TestExpectations
branches/safari-612-branch/LayoutTests/imported/w3c/web-platform-tests/storage/permission-query.https.any-expected.txt
branches/safari-612-branch/LayoutTests/platform/wk2/TestExpectations
branches/safari-612-branch/Source/WebKit/NetworkProcess/NetworkProcess.cpp
branches/safari-612-branch/Source/WebKit/NetworkProcess/NetworkProcess.h
branches/safari-612-branch/Source/WebKit/NetworkProcess/NetworkProcess.messages.in
branches/safari-612-branch/Source/WebKit/NetworkProcess/storage/NetworkStorageManager.cpp
branches/safari-612-branch/Source/WebKit/NetworkProcess/storage/NetworkStorageManager.h
branches/safari-612-branch/Source/WebKit/UIProcess/API/C/WKWebsiteDataStoreRef.cpp
branches/safari-612-branch/Source/WebKit/UIProcess/API/C/WKWebsiteDataStoreRef.h
branches/safari-612-branch/Source/WebKit/UIProcess/Network/NetworkProcessProxy.cpp
branches/safari-612-branch/Source/WebKit/UIProcess/Network/NetworkProcessProxy.h
branches/safari-612-branch/Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.cpp
branches/safari-612-branch/Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.h
branches/safari-612-branch/Tools/WebKitTestRunner/TestController.cpp
branches/safari-612-branch/Tools/WebKitTestRunner/TestController.h
Diff
Modified: branches/safari-612-branch/LayoutTests/TestExpectations (284319 => 284320)
--- branches/safari-612-branch/LayoutTests/TestExpectations 2021-10-16 18:16:53 UTC (rev 284319)
+++ branches/safari-612-branch/LayoutTests/TestExpectations 2021-10-16 18:37:04 UTC (rev 284320)
@@ -196,7 +196,7 @@
fast/speechrecognition/start-recognition-then-stop.html [ Skip ]
fast/speechrecognition/start-second-recognition.html [ Skip ]
fast/speechrecognition/ios/ [ Skip ]
-imported/w3c/web-platform-tests/file-system-access/ [ Skip ]
+imported/w3c/web-platform-tests/storage/ [ Skip ]
# app-privacy-report tests rely on WebKitAdditions
http/tests/app-privacy-report/ [ Skip ]
Modified: branches/safari-612-branch/LayoutTests/imported/w3c/web-platform-tests/storage/permission-query.https.any-expected.txt (284319 => 284320)
--- branches/safari-612-branch/LayoutTests/imported/w3c/web-platform-tests/storage/permission-query.https.any-expected.txt 2021-10-16 18:16:53 UTC (rev 284319)
+++ branches/safari-612-branch/LayoutTests/imported/w3c/web-platform-tests/storage/permission-query.https.any-expected.txt 2021-10-16 18:37:04 UTC (rev 284320)
@@ -1,3 +1,3 @@
-FAIL The "persistent-storage" permission is recognized promise_test: Unhandled rejection with value: object "TypeError: Type error"
+FAIL The "persistent-storage" permission is recognized promise_test: Unhandled rejection with value: object "TypeError: undefined is not an object (evaluating 'navigator.permissions.query')"
Modified: branches/safari-612-branch/LayoutTests/platform/wk2/TestExpectations (284319 => 284320)
--- branches/safari-612-branch/LayoutTests/platform/wk2/TestExpectations 2021-10-16 18:16:53 UTC (rev 284319)
+++ branches/safari-612-branch/LayoutTests/platform/wk2/TestExpectations 2021-10-16 18:37:04 UTC (rev 284320)
@@ -866,6 +866,7 @@
fast/speechrecognition/start-recognition-then-stop.html [ Pass ]
fast/speechrecognition/start-second-recognition.html [ Pass ]
fullscreen/full-screen-enter-while-exiting.html [ Pass ]
+imported/w3c/web-platform-tests/storage/ [ Pass ]
imported/w3c/web-platform-tests/file-system-access/ [ Pass ]
Modified: branches/safari-612-branch/Source/WebKit/NetworkProcess/NetworkProcess.cpp (284319 => 284320)
--- branches/safari-612-branch/Source/WebKit/NetworkProcess/NetworkProcess.cpp 2021-10-16 18:16:53 UTC (rev 284319)
+++ branches/safari-612-branch/Source/WebKit/NetworkProcess/NetworkProcess.cpp 2021-10-16 18:37:04 UTC (rev 284320)
@@ -2422,6 +2422,14 @@
completionHandler();
}
+void NetworkProcess::clearStorage(PAL::SessionID sessionID, CompletionHandler&& completionHandler)
+{
+if (auto manager = m_storageManagers.get(sessionID))
+manager->clearStorageForTesting(WTFMove(completionHandler));
+else
+completionHandler();
+}
+
void NetworkProcess::renameOriginInWebsiteData(PAL::SessionID sessionID, const URL& oldName, const URL& newName, OptionSet dataTypes, CompletionHandler&& completionHandler)
{
auto aggregator = CallbackAggregator::create(WTFMove(completionHandler));
Modified: branches/safari-612-branch/Source/WebKit/NetworkProcess/NetworkProcess.h (284319 => 284320)
--- branches/safari-612-branch/Source/WebKit/NetworkProcess/NetworkProcess.h 2021-10-16 18:16:53 UTC (rev 284319)
+++ branches/safari-612-branch/Source/WebKit/NetworkProcess/NetworkProcess.h 2021-10-16 18:37:04 UTC (rev 284320)
@@ -309,6 +309,7 @@
[webkit-changes] [284319] trunk/Source/WebKit
Title: [284319] trunk/Source/WebKit
Revision 284319
Author ddkil...@apple.com
Date 2021-10-16 11:16:53 -0700 (Sat, 16 Oct 2021)
Log Message
WebKit::LocalConnection::createCredentialPrivateKey leaks an NSMutableDictionary
Reviewed by Kate Cheney.
* UIProcess/WebAuthentication/Cocoa/LocalConnection.mm:
(WebKit::LocalConnection::createCredentialPrivateKey const):
- Use RetainPtr<> and adoptNS to fix the leak.
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/WebAuthentication/Cocoa/LocalConnection.mm
Diff
Modified: trunk/Source/WebKit/ChangeLog (284318 => 284319)
--- trunk/Source/WebKit/ChangeLog 2021-10-16 17:16:15 UTC (rev 284318)
+++ trunk/Source/WebKit/ChangeLog 2021-10-16 18:16:53 UTC (rev 284319)
@@ -1,3 +1,15 @@
+2021-10-16 David Kilzer
+
+WebKit::LocalConnection::createCredentialPrivateKey leaks an NSMutableDictionary
+
+
+
+Reviewed by Kate Cheney.
+
+* UIProcess/WebAuthentication/Cocoa/LocalConnection.mm:
+(WebKit::LocalConnection::createCredentialPrivateKey const):
+- Use RetainPtr<> and adoptNS to fix the leak.
+
2021-10-16 Lauro Moura
[GTK4] Update signal name to monitor window resize
Modified: trunk/Source/WebKit/UIProcess/WebAuthentication/Cocoa/LocalConnection.mm (284318 => 284319)
--- trunk/Source/WebKit/UIProcess/WebAuthentication/Cocoa/LocalConnection.mm 2021-10-16 17:16:15 UTC (rev 284318)
+++ trunk/Source/WebKit/UIProcess/WebAuthentication/Cocoa/LocalConnection.mm 2021-10-16 18:16:53 UTC (rev 284319)
@@ -167,7 +167,7 @@
RetainPtr LocalConnection::createCredentialPrivateKey(LAContext *context, SecAccessControlRef accessControlRef, const String& secAttrLabel, NSData *secAttrApplicationTag) const
{
-NSDictionary *privateKeyAttributes = @{
+RetainPtr privateKeyAttributes = @{
(id)kSecAttrAccessControl: (id)accessControlRef,
(id)kSecAttrIsPermanent: @YES,
(id)kSecAttrAccessGroup: (id)String(LocalAuthenticatiorAccessGroup),
@@ -176,8 +176,8 @@
};
if (context) {
-privateKeyAttributes = [privateKeyAttributes mutableCopy];
-((NSMutableDictionary *)privateKeyAttributes)[(id)kSecUseAuthenticationContext] = context;
+privateKeyAttributes = adoptNS([privateKeyAttributes mutableCopy]);
+((NSMutableDictionary *)privateKeyAttributes.get())[(id)kSecUseAuthenticationContext] = context;
}
NSDictionary *attributes = @{
@@ -184,7 +184,7 @@
(id)kSecAttrTokenID: (id)kSecAttrTokenIDSecureEnclave,
(id)kSecAttrKeyType: (id)kSecAttrKeyTypeECSECPrimeRandom,
(id)kSecAttrKeySizeInBits: @256,
-(id)kSecPrivateKeyAttrs: privateKeyAttributes,
+(id)kSecPrivateKeyAttrs: privateKeyAttributes.get(),
};
LOCAL_CONNECTION_ADDITIONS
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [284318] trunk/LayoutTests
Title: [284318] trunk/LayoutTests
Revision 284318
Author za...@apple.com
Date 2021-10-16 10:16:15 -0700 (Sat, 16 Oct 2021)
Log Message
Undo some rebaseline in r284296.
Unreviewed.
* platform/mac-bigsur/fast/text/capitalize-boundaries-expected.txt:
* platform/mac-catalina/fast/text/capitalize-boundaries-expected.txt:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac-bigsur/fast/text/capitalize-boundaries-expected.txt
trunk/LayoutTests/platform/mac-catalina/fast/text/capitalize-boundaries-expected.txt
Diff
Modified: trunk/LayoutTests/ChangeLog (284317 => 284318)
--- trunk/LayoutTests/ChangeLog 2021-10-16 16:14:24 UTC (rev 284317)
+++ trunk/LayoutTests/ChangeLog 2021-10-16 17:16:15 UTC (rev 284318)
@@ -1,3 +1,12 @@
+2021-10-16 Alan Bujtas
+
+Undo some rebaseline in r284296.
+
+Unreviewed.
+
+* platform/mac-bigsur/fast/text/capitalize-boundaries-expected.txt:
+* platform/mac-catalina/fast/text/capitalize-boundaries-expected.txt:
+
2021-10-16 Simon Fraser
Make sure child layers of top layer elements are rendered and correctly z-ordered (top-layer-stacking.html fails)
Modified: trunk/LayoutTests/platform/mac-bigsur/fast/text/capitalize-boundaries-expected.txt (284317 => 284318)
--- trunk/LayoutTests/platform/mac-bigsur/fast/text/capitalize-boundaries-expected.txt 2021-10-16 16:14:24 UTC (rev 284317)
+++ trunk/LayoutTests/platform/mac-bigsur/fast/text/capitalize-boundaries-expected.txt 2021-10-16 17:16:15 UTC (rev 284318)
@@ -1,8 +1,8 @@
-layer at (0,0) size 785x1201
+layer at (0,0) size 785x1199
RenderView at (0,0) size 785x600
-layer at (0,0) size 785x1201
- RenderBlock {HTML} at (0,0) size 785x1201
-RenderBody {BODY} at (8,8) size 769x1185
+layer at (0,0) size 785x1199
+ RenderBlock {HTML} at (0,0) size 785x1199
+RenderBody {BODY} at (8,8) size 769x1183
RenderBlock (anonymous) at (0,0) size 769x90
RenderText {#text} at (0,0) size 352x18
text run at (0,0) width 352: "This test was provided by open-source contributors on "
@@ -86,47 +86,47 @@
RenderText {#text} at (20,1) size 14x20
text run at (20,2) width 14: "fr"
RenderTableCell {TD} at (57,197) size 710x27 [border: (1px solid #EE)] [r=5 c=1 rs=1 cs=1]
- RenderText {#text} at (2,7) size 215x18
-text run at (2,7) width 215: "quelqu'un l\x{2019}amour t'appelles\x{2011}tu 3"
+ RenderText {#text} at (2,6) size 215x18
+text run at (2,6) width 215: "quelqu'un l\x{2019}amour t'appelles\x{2011}tu 3"
RenderInline {SUP} at (0,0) size 23x15
RenderText {#text} at (216,2) size 23x15
text run at (216,2) width 23: "eme"
- RenderTableRow {TR} at (0,226) size 769x23
-RenderTableCell {TH} at (2,226) size 54x23 [bgcolor=#F8F8F8] [border: (1px solid #EE)] [r=6 c=0 rs=1 cs=1]
+ RenderTableRow {TR} at (0,225) size 769x24
+RenderTableCell {TH} at (2,225) size 54x23 [bgcolor=#F8F8F8] [border: (1px solid #EE)] [r=6 c=0 rs=1 cs=1]
RenderText {#text} at (17,1) size 19x20
text run at (17,2) width 19: "hu"
-RenderTableCell {TD} at (57,226) size 710x23 [border: (1px solid #EE)] [r=6 c=1 rs=1 cs=1]
+RenderTableCell {TD} at (57,225) size 710x24 [border: (1px solid #EE)] [r=6 c=1 rs=1 cs=1]
RenderText {#text} at (2,3) size 114x18
text run at (2,3) width 114: "11-ei london\x{2011}ban"
- RenderTableRow {TR} at (0,251) size 769x22
-RenderTableCell {TH} at (2,251) size 54x22 [bgcolor=#F8F8F8] [border: (1px solid #EE)] [r=7 c=0 rs=1 cs=1]
+ RenderTableRow {TR} at (0,250) size 769x23
+RenderTableCell {TH} at (2,250) size 54x23 [bgcolor=#F8F8F8] [border: (1px solid #EE)] [r=7 c=0 rs=1 cs=1]
RenderText {#text} at (20,2) size 14x18
text run at (20,2) width 14: "nl"
-RenderTableCell {TD} at (57,251) size 710x22 [border: (1px solid #EE)] [r=7 c=1 rs=1 cs=1]
+RenderTableCell {TD} at (57,250) size 710x23 [border: (1px solid #EE)] [r=7 c=1 rs=1 cs=1]
RenderText {#text} at (2,2) size 70x18
text run at (2,2) width 70: "'s ochtends"
- RenderTableRow {TR} at (0,275) size 769x22
-RenderTableCell {TH} at (2,275) size 54x22 [bgcolor=#F8F8F8] [border: (1px solid #EE)] [r=8 c=0 rs=1 cs=1]
+ RenderTableRow {TR} at (0,274) size 769x23
+RenderTableCell {TH} at (2,274) size 54x23 [bgcolor=#F8F8F8] [border: (1px solid #EE)] [r=8 c=0 rs=1 cs=1]
RenderText {#text} at (20,2) size 14x18
text run at (20,2) width 14: "pl"
-RenderTableCell {TD} at (57,275) size 710x22 [border: (1px solid #EE)] [r=8 c=1 rs=1 cs=1]
+RenderTableCell {TD} at
[webkit-changes] [284317] trunk/Source/WebCore
Title: [284317] trunk/Source/WebCore
Revision 284317
Author za...@apple.com
Date 2021-10-16 09:14:24 -0700 (Sat, 16 Oct 2021)
Log Message
[LFC][IFC] Move overflowing content creation to LineBuilder::initialize
https://bugs.webkit.org/show_bug.cgi?id=231540
Reviewed by Antti Koivisto.
LineBuilder::initialize is going to handle all overflowing content initialization.
This is in preparation for adding spanning inline box items to the line (to support box-decoration-break: clone).
* layout/formattingContexts/inline/InlineLineBuilder.cpp:
(WebCore::Layout::LineBuilder::layoutInlineContent):
(WebCore::Layout::LineBuilder::computedIntrinsicWidth):
(WebCore::Layout::LineBuilder::initialize):
(WebCore::Layout::LineBuilder::placeInlineContent):
(WebCore::Layout::LineBuilder::candidateContentForLine):
* layout/formattingContexts/inline/InlineLineBuilder.h:
* layout/formattingContexts/inline/InlineTextItem.h:
(WebCore::Layout::InlineTextItem::right const):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.cpp
trunk/Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.h
trunk/Source/WebCore/layout/formattingContexts/inline/InlineTextItem.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (284316 => 284317)
--- trunk/Source/WebCore/ChangeLog 2021-10-16 14:55:42 UTC (rev 284316)
+++ trunk/Source/WebCore/ChangeLog 2021-10-16 16:14:24 UTC (rev 284317)
@@ -1,3 +1,23 @@
+2021-10-16 Alan Bujtas
+
+[LFC][IFC] Move overflowing content creation to LineBuilder::initialize
+https://bugs.webkit.org/show_bug.cgi?id=231540
+
+Reviewed by Antti Koivisto.
+
+LineBuilder::initialize is going to handle all overflowing content initialization.
+This is in preparation for adding spanning inline box items to the line (to support box-decoration-break: clone).
+
+* layout/formattingContexts/inline/InlineLineBuilder.cpp:
+(WebCore::Layout::LineBuilder::layoutInlineContent):
+(WebCore::Layout::LineBuilder::computedIntrinsicWidth):
+(WebCore::Layout::LineBuilder::initialize):
+(WebCore::Layout::LineBuilder::placeInlineContent):
+(WebCore::Layout::LineBuilder::candidateContentForLine):
+* layout/formattingContexts/inline/InlineLineBuilder.h:
+* layout/formattingContexts/inline/InlineTextItem.h:
+(WebCore::Layout::InlineTextItem::right const):
+
2021-10-16 Antti Koivisto
Use inline iterator for SVG reverse BiDI reordering
Modified: trunk/Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.cpp (284316 => 284317)
--- trunk/Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.cpp 2021-10-16 14:55:42 UTC (rev 284316)
+++ trunk/Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.cpp 2021-10-16 16:14:24 UTC (rev 284317)
@@ -266,11 +266,11 @@
{
}
-LineBuilder::LineContent LineBuilder::layoutInlineContent(const InlineItemRange& needsLayoutRange, size_t partialLeadingContentLength, std::optional overflowLogicalWidth, const InlineRect& initialLineLogicalRect, bool isFirstLine)
+LineBuilder::LineContent LineBuilder::layoutInlineContent(const InlineItemRange& needsLayoutRange, size_t partialLeadingContentLength, std::optional overflowingLogicalWidth, const InlineRect& initialLineLogicalRect, bool isFirstLine)
{
-initialize(initialConstraintsForLine(initialLineLogicalRect, isFirstLine), isFirstLine);
+initialize(initialConstraintsForLine(initialLineLogicalRect, isFirstLine), isFirstLine, needsLayoutRange.start, partialLeadingContentLength, overflowingLogicalWidth);
-auto committedContent = placeInlineContent(needsLayoutRange, partialLeadingContentLength, overflowLogicalWidth);
+auto committedContent = placeInlineContent(needsLayoutRange);
auto committedRange = close(needsLayoutRange, committedContent);
auto isLastLine = isLastLineWithInlineContent(committedRange, needsLayoutRange.end, committedContent.partialTrailingContentLength);
@@ -286,25 +286,33 @@
LineBuilder::IntrinsicContent LineBuilder::computedIntrinsicWidth(const InlineItemRange& needsLayoutRange, InlineLayoutUnit availableWidth)
{
-initialize({ { { }, { availableWidth, maxInlineLayoutUnit() } }, false }, false);
-auto committedContent = placeInlineContent(needsLayoutRange, { }, { });
+initialize({ { { }, { availableWidth, maxInlineLayoutUnit() } }, false }, false, { }, { }, { });
+auto committedContent = placeInlineContent(needsLayoutRange);
auto committedRange = close(needsLayoutRange, committedContent);
return { committedRange, m_line.contentLogicalWidth(), m_floats };
}
-void LineBuilder::initialize(const UsedConstraints& lineConstraints, bool isFirstLine)
+void LineBuilder::initialize(const UsedConstraints& lineConstraints, bool isFirstLine, size_t leadingInlineTextItemIndex, size_t partialLeadingContentLength, std::optional overflowingLogicalWidth)
{
[webkit-changes] [284316] trunk
Title: [284316] trunk Revision 284316 Author ange...@igalia.com Date 2021-10-16 07:55:42 -0700 (Sat, 16 Oct 2021) Log Message Add my github username to contributors.json https://bugs.webkit.org/show_bug.cgi?id=231861 Unreviewed. * metadata/contributors.json: Modified Paths trunk/ChangeLog trunk/metadata/contributors.json Diff Modified: trunk/ChangeLog (284315 => 284316) --- trunk/ChangeLog 2021-10-16 12:39:37 UTC (rev 284315) +++ trunk/ChangeLog 2021-10-16 14:55:42 UTC (rev 284316) @@ -1,3 +1,12 @@ +2021-10-16 Angelos Oikonomopoulos + +Add my github username to contributors.json +https://bugs.webkit.org/show_bug.cgi?id=231861 + +Unreviewed. + +* metadata/contributors.json: + 2021-10-16 Caitlin Potter Add github username for myself Modified: trunk/metadata/contributors.json (284315 => 284316) --- trunk/metadata/contributors.json 2021-10-16 12:39:37 UTC (rev 284315) +++ trunk/metadata/contributors.json 2021-10-16 14:55:42 UTC (rev 284316) @@ -726,6 +726,7 @@ "ange...@igalia.com" ], "expertise" : "_javascript_Core", + "github" : "aoikonomopoulos", "name" : "Angelos Oikonomopoulos", "nicks" : [ "angelos" ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [284315] trunk/Source/WebCore
Title: [284315] trunk/Source/WebCore
Revision 284315
Author an...@apple.com
Date 2021-10-16 05:39:37 -0700 (Sat, 16 Oct 2021)
Log Message
Use inline iterator for SVG reverse BiDI reordering
https://bugs.webkit.org/show_bug.cgi?id=231858
Reviewed by Alan Bujtas.
Share code.
* layout/integration/InlineIteratorLogicalOrderTraversal.cpp:
(WebCore::InlineIterator::makeLineLogicalOrderCache):
(WebCore::InlineIterator::nextLeafOnLineInLogicalOrder):
(WebCore::InlineIterator::previousLeafOnLineInLogicalOrder):
No need to test for the cache, it is always there.
* layout/integration/InlineIteratorLogicalOrderTraversal.h:
(WebCore::InlineIterator::leafBoxesInLogicalOrder):
Make template and move to header.
* rendering/LegacyInlineFlowBox.cpp:
(WebCore::LegacyInlineFlowBox::collectLeafBoxesInLogicalOrder const): Deleted.
Not needed anymore.
* rendering/LegacyInlineFlowBox.h:
* rendering/svg/SVGRootInlineBox.cpp:
(WebCore::SVGRootInlineBox::computePerCharacterLayoutInformation):
(WebCore::reverseInlineBoxRangeAndValueListsIfNeeded):
(WebCore::SVGRootInlineBox::reorderValueListsToLogicalOrder):
(WebCore::SVGRootInlineBox::reorderValueLists): Deleted.
Call the generic version.
* rendering/svg/SVGRootInlineBox.h:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/layout/integration/InlineIteratorLogicalOrderTraversal.cpp
trunk/Source/WebCore/layout/integration/InlineIteratorLogicalOrderTraversal.h
trunk/Source/WebCore/rendering/LegacyInlineFlowBox.cpp
trunk/Source/WebCore/rendering/LegacyInlineFlowBox.h
trunk/Source/WebCore/rendering/svg/SVGRootInlineBox.cpp
trunk/Source/WebCore/rendering/svg/SVGRootInlineBox.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (284314 => 284315)
--- trunk/Source/WebCore/ChangeLog 2021-10-16 10:35:18 UTC (rev 284314)
+++ trunk/Source/WebCore/ChangeLog 2021-10-16 12:39:37 UTC (rev 284315)
@@ -1,3 +1,40 @@
+2021-10-16 Antti Koivisto
+
+Use inline iterator for SVG reverse BiDI reordering
+https://bugs.webkit.org/show_bug.cgi?id=231858
+
+Reviewed by Alan Bujtas.
+
+Share code.
+
+* layout/integration/InlineIteratorLogicalOrderTraversal.cpp:
+(WebCore::InlineIterator::makeLineLogicalOrderCache):
+(WebCore::InlineIterator::nextLeafOnLineInLogicalOrder):
+(WebCore::InlineIterator::previousLeafOnLineInLogicalOrder):
+
+No need to test for the cache, it is always there.
+
+* layout/integration/InlineIteratorLogicalOrderTraversal.h:
+(WebCore::InlineIterator::leafBoxesInLogicalOrder):
+
+Make template and move to header.
+
+* rendering/LegacyInlineFlowBox.cpp:
+(WebCore::LegacyInlineFlowBox::collectLeafBoxesInLogicalOrder const): Deleted.
+
+Not needed anymore.
+
+* rendering/LegacyInlineFlowBox.h:
+* rendering/svg/SVGRootInlineBox.cpp:
+(WebCore::SVGRootInlineBox::computePerCharacterLayoutInformation):
+(WebCore::reverseInlineBoxRangeAndValueListsIfNeeded):
+(WebCore::SVGRootInlineBox::reorderValueListsToLogicalOrder):
+(WebCore::SVGRootInlineBox::reorderValueLists): Deleted.
+
+Call the generic version.
+
+* rendering/svg/SVGRootInlineBox.h:
+
2021-10-16 Simon Fraser
Make sure child layers of top layer elements are rendered and correctly z-ordered (top-layer-stacking.html fails)
Modified: trunk/Source/WebCore/layout/integration/InlineIteratorLogicalOrderTraversal.cpp (284314 => 284315)
--- trunk/Source/WebCore/layout/integration/InlineIteratorLogicalOrderTraversal.cpp 2021-10-16 10:35:18 UTC (rev 284314)
+++ trunk/Source/WebCore/layout/integration/InlineIteratorLogicalOrderTraversal.cpp 2021-10-16 12:39:37 UTC (rev 284315)
@@ -92,49 +92,12 @@
static LineLogicalOrderCache makeLineLogicalOrderCache(const LineIterator& line)
{
auto cache = WTF::makeUnique();
+
cache->line = line;
+cache->boxes = leafBoxesInLogicalOrder(line, [](auto first, auto last) {
+std::reverse(first, last);
+});
-auto& boxes = cache->boxes;
-
-unsigned char minLevel = 128;
-unsigned char maxLevel = 0;
-
-for (auto box = line->firstRun(); box; box = box.traverseNextOnLine()) {
-minLevel = std::min(minLevel, box->bidiLevel());
-maxLevel = std::max(maxLevel, box->bidiLevel());
-boxes.append(box);
-}
-
-if (!maxLevel)
-return cache;
-
-if (line->containingBlock().style().rtlOrdering() == Order::Visual)
-return cache;
-
-// Reverse of reordering of the line (L2 according to Bidi spec):
-// L2. From the highest level found in the text to the lowest odd level on each line,
-// reverse any contiguous sequence of characters that are at that level or higher.
-
-// Reversing the reordering of the line is only done up to the lowest odd level.
-if (!(minLevel % 2))
-++minLevel;
-
-auto end = boxes.end();
-for (; minLevel <= maxLevel; ++minLevel) {
-auto box
[webkit-changes] [284314] trunk
Title: [284314] trunk
Revision 284314
Author simon.fra...@apple.com
Date 2021-10-16 03:35:18 -0700 (Sat, 16 Oct 2021)
Log Message
Make sure child layers of top layer elements are rendered and correctly z-ordered (top-layer-stacking.html fails)
https://bugs.webkit.org/show_bug.cgi?id=231832
Reviewed by Antoine Quint.
Source/WebCore:
Top layer elements should create CSS stacking context, per https://fullscreen.spec.whatwg.org/#rendering
I decided to call isInTopLayerOrBackdrop() twice to avoid calling it every time this function
is called. It's a cheap function.
Test: fast/layers/dialog-is-stacking-context.html
* style/StyleAdjuster.cpp:
(WebCore::Style::Adjuster::adjust const):
LayoutTests:
Ref test that compares a dialog with positioned children and one with children place
with margins.
* fast/layers/dialog-is-stacking-context-expected.html: Added.
* fast/layers/dialog-is-stacking-context.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/style/StyleAdjuster.cpp
Added Paths
trunk/LayoutTests/fast/layers/dialog-is-stacking-context-expected.html
trunk/LayoutTests/fast/layers/dialog-is-stacking-context.html
Diff
Modified: trunk/LayoutTests/ChangeLog (284313 => 284314)
--- trunk/LayoutTests/ChangeLog 2021-10-16 10:22:11 UTC (rev 284313)
+++ trunk/LayoutTests/ChangeLog 2021-10-16 10:35:18 UTC (rev 284314)
@@ -1,3 +1,16 @@
+2021-10-16 Simon Fraser
+
+Make sure child layers of top layer elements are rendered and correctly z-ordered (top-layer-stacking.html fails)
+https://bugs.webkit.org/show_bug.cgi?id=231832
+
+Reviewed by Antoine Quint.
+
+Ref test that compares a dialog with positioned children and one with children place
+with margins.
+
+* fast/layers/dialog-is-stacking-context-expected.html: Added.
+* fast/layers/dialog-is-stacking-context.html: Added.
+
2021-10-15 Antoine Quint
Accelerated animations on ::backdrop shouldn't affect (backdrop-animate-002.html fails)
Added: trunk/LayoutTests/fast/layers/dialog-is-stacking-context-expected.html (0 => 284314)
--- trunk/LayoutTests/fast/layers/dialog-is-stacking-context-expected.html (rev 0)
+++ trunk/LayoutTests/fast/layers/dialog-is-stacking-context-expected.html 2021-10-16 10:35:18 UTC (rev 284314)
@@ -0,0 +1,36 @@
+
+
+
+
+dialog {
+position: absolute;
+top: 10px;
+left: 10px;
+width: 300px;
+height: 200px;
+}
+
+.box {
+margin: -200px 0;
+width: 100px;
+height: 100px;
+background-color: green;
+}
+
+.negative {
+margin: 50px;
+z-index: -1;
+background-color: orange;
+}
+
+
+
+
+
+
+
+
+document.getElementById('theDialog').showModal();
+
+
+
Added: trunk/LayoutTests/fast/layers/dialog-is-stacking-context.html (0 => 284314)
--- trunk/LayoutTests/fast/layers/dialog-is-stacking-context.html (rev 0)
+++ trunk/LayoutTests/fast/layers/dialog-is-stacking-context.html 2021-10-16 10:35:18 UTC (rev 284314)
@@ -0,0 +1,37 @@
+
+
+
+
+dialog {
+position: absolute;
+top: 10px;
+left: 10px;
+width: 300px;
+height: 200px;
+}
+
+.box {
+position: absolute;
+z-index: 0;
+width: 100px;
+height: 100px;
+background-color: green;
+}
+
+.negative {
+margin: 50px;
+z-index: -1;
+background-color: orange;
+}
+
+
+
+
+
+
+
+
+document.getElementById('theDialog').showModal();
+
+
+
Modified: trunk/Source/WebCore/ChangeLog (284313 => 284314)
--- trunk/Source/WebCore/ChangeLog 2021-10-16 10:22:11 UTC (rev 284313)
+++ trunk/Source/WebCore/ChangeLog 2021-10-16 10:35:18 UTC (rev 284314)
@@ -1,3 +1,20 @@
+2021-10-16 Simon Fraser
+
+Make sure child layers of top layer elements are rendered and correctly z-ordered (top-layer-stacking.html fails)
+https://bugs.webkit.org/show_bug.cgi?id=231832
+
+Reviewed by Antoine Quint.
+
+Top layer elements should create CSS stacking context, per https://fullscreen.spec.whatwg.org/#rendering
+
+I decided to call isInTopLayerOrBackdrop() twice to avoid calling it every time this function
+is called. It's a cheap function.
+
+Test: fast/layers/dialog-is-stacking-context.html
+
+* style/StyleAdjuster.cpp:
+(WebCore::Style::Adjuster::adjust const):
+
2021-10-15 Antoine Quint
Accelerated animations on ::backdrop shouldn't affect (backdrop-animate-002.html fails)
Modified: trunk/Source/WebCore/style/StyleAdjuster.cpp (284313 => 284314)
---
[webkit-changes] [284313] trunk
Title: [284313] trunk
Revision 284313
Author grao...@webkit.org
Date 2021-10-16 03:22:11 -0700 (Sat, 16 Oct 2021)
Log Message
Accelerated animations on ::backdrop shouldn't affect (backdrop-animate-002.html fails)
https://bugs.webkit.org/show_bug.cgi?id=230008
Reviewed by Simon Fraser and Tim Nguyen.
Source/WebCore:
We did not know how to access the ::backdrop renderer when running accelerated animations. To do so we now
implement full support to access the renderer for known pseudo-elements on Styleable with a new renderer()
method, including ::backdrop. We also make Styleable::fromRenderer() aware of ::backdrop such that the various
call sites for this function that deal with accelerated transform animations access the right element.
* animation/KeyframeEffect.cpp:
(WebCore::KeyframeEffect::renderer const):
* style/Styleable.cpp:
(WebCore::Styleable::fromRenderer):
(WebCore::Styleable::renderer const):
* style/Styleable.h:
(WebCore::Styleable::fromRenderer): Deleted.
LayoutTests:
* TestExpectations: Mark the previously failing test as passing.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/TestExpectations
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/animation/KeyframeEffect.cpp
trunk/Source/WebCore/style/Styleable.cpp
trunk/Source/WebCore/style/Styleable.h
Diff
Modified: trunk/LayoutTests/ChangeLog (284312 => 284313)
--- trunk/LayoutTests/ChangeLog 2021-10-16 10:16:32 UTC (rev 284312)
+++ trunk/LayoutTests/ChangeLog 2021-10-16 10:22:11 UTC (rev 284313)
@@ -1,5 +1,15 @@
2021-10-15 Antoine Quint
+Accelerated animations on ::backdrop shouldn't affect (backdrop-animate-002.html fails)
+https://bugs.webkit.org/show_bug.cgi?id=230008
+
+
+Reviewed by Simon Fraser and Tim Nguyen.
+
+* TestExpectations: Mark the previously failing test as passing.
+
+2021-10-15 Antoine Quint
+
CSS Animations creation and sorting is incorrect and may lead to crash
https://bugs.webkit.org/show_bug.cgi?id=231812
Modified: trunk/LayoutTests/TestExpectations (284312 => 284313)
--- trunk/LayoutTests/TestExpectations 2021-10-16 10:16:32 UTC (rev 284312)
+++ trunk/LayoutTests/TestExpectations 2021-10-16 10:22:11 UTC (rev 284313)
@@ -5127,8 +5127,6 @@
webkit.org/b/230237 imported/w3c/web-platform-tests/css/cssom-view/scrollIntoView-inline-image.html [ Failure ]
-webkit.org/b/230008 imported/w3c/web-platform-tests/css/css-pseudo/backdrop-animate-002.html [ ImageOnlyFailure ]
-
webkit.org/b/230004 imported/w3c/web-platform-tests/css/css-pseudo/active-selection-012.html [ ImageOnlyFailure ]
webkit.org/b/230004 imported/w3c/web-platform-tests/css/css-pseudo/active-selection-014.html [ ImageOnlyFailure ]
webkit.org/b/230004 imported/w3c/web-platform-tests/css/css-pseudo/active-selection-018.html [ ImageOnlyFailure ]
Modified: trunk/Source/WebCore/ChangeLog (284312 => 284313)
--- trunk/Source/WebCore/ChangeLog 2021-10-16 10:16:32 UTC (rev 284312)
+++ trunk/Source/WebCore/ChangeLog 2021-10-16 10:22:11 UTC (rev 284313)
@@ -1,5 +1,26 @@
2021-10-15 Antoine Quint
+Accelerated animations on ::backdrop shouldn't affect (backdrop-animate-002.html fails)
+https://bugs.webkit.org/show_bug.cgi?id=230008
+
+
+Reviewed by Simon Fraser and Tim Nguyen.
+
+We did not know how to access the ::backdrop renderer when running accelerated animations. To do so we now
+implement full support to access the renderer for known pseudo-elements on Styleable with a new renderer()
+method, including ::backdrop. We also make Styleable::fromRenderer() aware of ::backdrop such that the various
+call sites for this function that deal with accelerated transform animations access the right element.
+
+* animation/KeyframeEffect.cpp:
+(WebCore::KeyframeEffect::renderer const):
+* style/Styleable.cpp:
+(WebCore::Styleable::fromRenderer):
+(WebCore::Styleable::renderer const):
+* style/Styleable.h:
+(WebCore::Styleable::fromRenderer): Deleted.
+
+2021-10-15 Antoine Quint
+
CSS Animations creation and sorting is incorrect and may lead to crash
https://bugs.webkit.org/show_bug.cgi?id=231812
Modified: trunk/Source/WebCore/animation/KeyframeEffect.cpp (284312 => 284313)
--- trunk/Source/WebCore/animation/KeyframeEffect.cpp 2021-10-16 10:16:32 UTC (rev 284312)
+++ trunk/Source/WebCore/animation/KeyframeEffect.cpp 2021-10-16 10:22:11 UTC (rev 284313)
@@ -1873,7 +1873,9 @@
RenderElement* KeyframeEffect::renderer() const
{
-return targetElementOrPseudoElement() ? targetElementOrPseudoElement()->renderer() : nullptr;
+if (auto target = targetStyleable())
+return target->renderer();
+return nullptr;
}
const RenderStyle& KeyframeEffect::currentStyle() const
Modified: trunk/Source/WebCore/style/Styleable.cpp (284312 => 284313)
---
[webkit-changes] [284312] trunk
Title: [284312] trunk
Revision 284312
Author grao...@webkit.org
Date 2021-10-16 03:16:32 -0700 (Sat, 16 Oct 2021)
Log Message
CSS Animations creation and sorting is incorrect and may lead to crash
https://bugs.webkit.org/show_bug.cgi?id=231812
Reviewed by Dean Jackson.
LayoutTests/imported/w3c:
Mark two progressions in a test that now passes entirely.
* web-platform-tests/css/css-animations/Element-getAnimations-dynamic-changes.tentative-expected.txt:
Source/WebCore:
When we parse CSS properties related to CSS Animations, we create as many Animation objects as the maximum number
of values in one of the CSS Animations properties. These Animation objects are stored in an AnimationList which
is owned by RenderStyle and that we use to store all provided values such that they can be read back through the
computed style.
Upon finishing parsing those CSS properties, RenderStyle::adjustAnimations() is called and does two things that
were not quite correct.
First, it would attempt to remove animations that were in fact created for no good reason using the
Animation::isEmpty() method. That method was not quite right as it was only checking if the animation
name wasn't set but not whether the animation was explicitly marked as a "none" animation. This meant
that "none" animations could be considered as bogus animations and any animations after that one would
be mistakenly cleared.
Second, it would finish process the list of remaning animations by making sure that mis-matched CSS properties,
for instance three values for animation-duration and four values for animation-name, would be correctly represented
throughout the Animation objects. However, the function performing this work, AnimationList::fillUnsetProperties(),
used to reset the animation's name in case it wasn't explicitly set, which meant that Animation objects that did not
have a matching animation-name would end up with a valid one. This meant that further down the line, in
Styleable::updateCSSAnimations(), we couldn't distinguish Animation objects that were created without a
matching animation-name and discard those.
We've fixed those incorrect behaviors and we now have the expected number of animations created resulting in an additional
WPT PASS result.
Additionally, this also showed some issues around sorting CSS Animations in compareCSSAnimations() where we weren't
making a pointer comparison. This is now fixed and we now pass another WPT PASS result.
Test: webanimations/css-animation-sorting-crash.html
* animation/WebAnimationUtilities.cpp:
(WebCore::compareCSSAnimations):
* platform/animation/Animation.h:
(WebCore::Animation::isEmpty const):
* platform/animation/AnimationList.cpp:
(WebCore::AnimationList::fillUnsetProperties):
LayoutTests:
Add a new test that used to crash before the source change.
* animations/animation-remove-element-crash.html: Remove a line that was now a failure since only a
single animation should be created.
* webanimations/css-animation-sorting-crash-expected.txt: Added.
* webanimations/css-animation-sorting-crash.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/animations/animation-remove-element-crash.html
trunk/LayoutTests/imported/w3c/ChangeLog
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-animations/Element-getAnimations-dynamic-changes.tentative-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/animation/WebAnimationUtilities.cpp
trunk/Source/WebCore/platform/animation/Animation.h
trunk/Source/WebCore/platform/animation/AnimationList.cpp
Added Paths
trunk/LayoutTests/webanimations/css-animation-sorting-crash-expected.txt
trunk/LayoutTests/webanimations/css-animation-sorting-crash.html
Diff
Modified: trunk/LayoutTests/ChangeLog (284311 => 284312)
--- trunk/LayoutTests/ChangeLog 2021-10-16 09:07:26 UTC (rev 284311)
+++ trunk/LayoutTests/ChangeLog 2021-10-16 10:16:32 UTC (rev 284312)
@@ -1,3 +1,18 @@
+2021-10-15 Antoine Quint
+
+CSS Animations creation and sorting is incorrect and may lead to crash
+https://bugs.webkit.org/show_bug.cgi?id=231812
+
+
+Reviewed by Dean Jackson.
+
+Add a new test that used to crash before the source change.
+
+* animations/animation-remove-element-crash.html: Remove a line that was now a failure since only a
+single animation should be created.
+* webanimations/css-animation-sorting-crash-expected.txt: Added.
+* webanimations/css-animation-sorting-crash.html: Added.
+
2021-10-15 Antti Koivisto
[LFC][Integration] Enable inline boxes with borders
Modified: trunk/LayoutTests/animations/animation-remove-element-crash.html (284311 => 284312)
--- trunk/LayoutTests/animations/animation-remove-element-crash.html 2021-10-16 09:07:26 UTC (rev 284311)
+++ trunk/LayoutTests/animations/animation-remove-element-crash.html 2021-10-16 10:16:32 UTC (rev 284312)
@@ -14,7 +14,6 @@
console.log('This test passes if it does
[webkit-changes] [284311] trunk/Source/WebKit
Title: [284311] trunk/Source/WebKit
Revision 284311
Author lmo...@igalia.com
Date 2021-10-16 02:07:26 -0700 (Sat, 16 Oct 2021)
Log Message
[GTK4] Update signal name to monitor window resize
https://bugs.webkit.org/show_bug.cgi?id=231854
Reviewed by Carlos Garcia Campos.
Using size-changed (previous signal name) makes the MiniBrowser crash
running the WebDriver tests.
The signal name was changed in
https://gitlab.gnome.org/GNOME/gtk/-/commit/b7380543449ea679a2c912b66aab4855b2bb41f2,
as part of GTK 3.99.5.
Covered by existing tests.
* UIProcess/API/glib/WebKitUIClient.cpp:
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/API/glib/WebKitUIClient.cpp
Diff
Modified: trunk/Source/WebKit/ChangeLog (284310 => 284311)
--- trunk/Source/WebKit/ChangeLog 2021-10-16 08:22:59 UTC (rev 284310)
+++ trunk/Source/WebKit/ChangeLog 2021-10-16 09:07:26 UTC (rev 284311)
@@ -1,3 +1,21 @@
+2021-10-16 Lauro Moura
+
+[GTK4] Update signal name to monitor window resize
+https://bugs.webkit.org/show_bug.cgi?id=231854
+
+Reviewed by Carlos Garcia Campos.
+
+Using size-changed (previous signal name) makes the MiniBrowser crash
+running the WebDriver tests.
+
+The signal name was changed in
+https://gitlab.gnome.org/GNOME/gtk/-/commit/b7380543449ea679a2c912b66aab4855b2bb41f2,
+as part of GTK 3.99.5.
+
+Covered by existing tests.
+
+* UIProcess/API/glib/WebKitUIClient.cpp:
+
2021-10-15 Alex Christensen
Start using adattributiond on iOS
Modified: trunk/Source/WebKit/UIProcess/API/glib/WebKitUIClient.cpp (284310 => 284311)
--- trunk/Source/WebKit/UIProcess/API/glib/WebKitUIClient.cpp 2021-10-16 08:22:59 UTC (rev 284310)
+++ trunk/Source/WebKit/UIProcess/API/glib/WebKitUIClient.cpp 2021-10-16 09:07:26 UTC (rev 284311)
@@ -208,7 +208,7 @@
#if USE(GTK4)
auto* surface = gtk_native_get_surface(GTK_NATIVE(window));
-auto signalID = g_signal_connect(surface, "size-changed", G_CALLBACK(+[](GdkSurface*, int width, int height, GdkRectangle* targetGeometry) {
+auto signalID = g_signal_connect(surface, "layout", G_CALLBACK(+[](GdkSurface*, int width, int height, GdkRectangle* targetGeometry) {
if (width == targetGeometry->width && height == targetGeometry->height)
RunLoop::current().stop();
}), );
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [284310] trunk
Title: [284310] trunk Revision 284310 Author ca...@igalia.com Date 2021-10-16 01:22:59 -0700 (Sat, 16 Oct 2021) Log Message Add github username for myself https://bugs.webkit.org/show_bug.cgi?id=231857 Reviewed by Yusuke Suzuki. * metadata/contributors.json: Modified Paths trunk/ChangeLog trunk/metadata/contributors.json Diff Modified: trunk/ChangeLog (284309 => 284310) --- trunk/ChangeLog 2021-10-16 07:58:04 UTC (rev 284309) +++ trunk/ChangeLog 2021-10-16 08:22:59 UTC (rev 284310) @@ -1,3 +1,12 @@ +2021-10-16 Caitlin Potter + +Add github username for myself +https://bugs.webkit.org/show_bug.cgi?id=231857 + +Reviewed by Yusuke Suzuki. + +* metadata/contributors.json: + 2021-10-15 Basuke Suzuki Add flag to turn off Iso heap Modified: trunk/metadata/contributors.json (284309 => 284310) --- trunk/metadata/contributors.json 2021-10-16 07:58:04 UTC (rev 284309) +++ trunk/metadata/contributors.json 2021-10-16 08:22:59 UTC (rev 284310) @@ -1227,6 +1227,7 @@ "emails" : [ "ca...@igalia.com" ], + "github" : "caitp", "name" : "Caitlin Potter", "nicks" : [ "caitp" ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [284309] trunk/Source/bmalloc
Title: [284309] trunk/Source/bmalloc Revision 284309 Author commit-qu...@webkit.org Date 2021-10-16 00:58:04 -0700 (Sat, 16 Oct 2021) Log Message Unreviewed, reverting r284305. https://bugs.webkit.org/show_bug.cgi?id=231859 webaudio-tests Reverted changeset: "[libpas] Enable libpas on macOS" https://bugs.webkit.org/show_bug.cgi?id=231815 https://commits.webkit.org/r284305 Modified Paths trunk/Source/bmalloc/ChangeLog trunk/Source/bmalloc/bmalloc/BPlatform.h Diff Modified: trunk/Source/bmalloc/ChangeLog (284308 => 284309) --- trunk/Source/bmalloc/ChangeLog 2021-10-16 06:14:25 UTC (rev 284308) +++ trunk/Source/bmalloc/ChangeLog 2021-10-16 07:58:04 UTC (rev 284309) @@ -1,3 +1,16 @@ +2021-10-16 Commit Queue + +Unreviewed, reverting r284305. +https://bugs.webkit.org/show_bug.cgi?id=231859 + +webaudio-tests + +Reverted changeset: + +"[libpas] Enable libpas on macOS" +https://bugs.webkit.org/show_bug.cgi?id=231815 +https://commits.webkit.org/r284305 + 2021-10-15 Yusuke Suzuki [libpas] Enable libpas on macOS Modified: trunk/Source/bmalloc/bmalloc/BPlatform.h (284308 => 284309) --- trunk/Source/bmalloc/bmalloc/BPlatform.h 2021-10-16 06:14:25 UTC (rev 284308) +++ trunk/Source/bmalloc/bmalloc/BPlatform.h 2021-10-16 07:58:04 UTC (rev 284309) @@ -311,7 +311,7 @@ /* BENABLE(LIBPAS) is enabling libpas build. But this does not mean we use libpas for bmalloc replacement. */ #if !defined(BENABLE_LIBPAS) -#if BOS(MAC) +#if BCPU(ARM64) && BOS(MAC) #define BENABLE_LIBPAS 1 #else #define BENABLE_LIBPAS 0 ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [284307] branches/safari-612-branch
Title: [284307] branches/safari-612-branch
Revision 284307
Author repst...@apple.com
Date 2021-10-15 23:02:53 -0700 (Fri, 15 Oct 2021)
Log Message
Apply patch. rdar://problem/83953730
Modified Paths
branches/safari-612-branch/LayoutTests/TestExpectations
branches/safari-612-branch/LayoutTests/imported/w3c/web-platform-tests/storage/permission-query.https.any-expected.txt
branches/safari-612-branch/LayoutTests/platform/wk2/TestExpectations
branches/safari-612-branch/Source/WebKit/NetworkProcess/NetworkProcess.cpp
branches/safari-612-branch/Source/WebKit/NetworkProcess/NetworkProcess.h
branches/safari-612-branch/Source/WebKit/NetworkProcess/NetworkProcess.messages.in
branches/safari-612-branch/Source/WebKit/NetworkProcess/storage/NetworkStorageManager.cpp
branches/safari-612-branch/Source/WebKit/NetworkProcess/storage/NetworkStorageManager.h
branches/safari-612-branch/Source/WebKit/UIProcess/API/C/WKWebsiteDataStoreRef.cpp
branches/safari-612-branch/Source/WebKit/UIProcess/API/C/WKWebsiteDataStoreRef.h
branches/safari-612-branch/Source/WebKit/UIProcess/Network/NetworkProcessProxy.cpp
branches/safari-612-branch/Source/WebKit/UIProcess/Network/NetworkProcessProxy.h
branches/safari-612-branch/Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.cpp
branches/safari-612-branch/Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.h
branches/safari-612-branch/Tools/WebKitTestRunner/TestController.cpp
branches/safari-612-branch/Tools/WebKitTestRunner/TestController.h
Diff
Modified: branches/safari-612-branch/LayoutTests/TestExpectations (284306 => 284307)
--- branches/safari-612-branch/LayoutTests/TestExpectations 2021-10-16 05:31:25 UTC (rev 284306)
+++ branches/safari-612-branch/LayoutTests/TestExpectations 2021-10-16 06:02:53 UTC (rev 284307)
@@ -196,7 +196,6 @@
fast/speechrecognition/start-recognition-then-stop.html [ Skip ]
fast/speechrecognition/start-second-recognition.html [ Skip ]
fast/speechrecognition/ios/ [ Skip ]
-imported/w3c/web-platform-tests/storage/ [ Skip ]
# app-privacy-report tests rely on WebKitAdditions
http/tests/app-privacy-report/ [ Skip ]
Modified: branches/safari-612-branch/LayoutTests/imported/w3c/web-platform-tests/storage/permission-query.https.any-expected.txt (284306 => 284307)
--- branches/safari-612-branch/LayoutTests/imported/w3c/web-platform-tests/storage/permission-query.https.any-expected.txt 2021-10-16 05:31:25 UTC (rev 284306)
+++ branches/safari-612-branch/LayoutTests/imported/w3c/web-platform-tests/storage/permission-query.https.any-expected.txt 2021-10-16 06:02:53 UTC (rev 284307)
@@ -1,3 +1,3 @@
-FAIL The "persistent-storage" permission is recognized promise_test: Unhandled rejection with value: object "TypeError: undefined is not an object (evaluating 'navigator.permissions.query')"
+FAIL The "persistent-storage" permission is recognized promise_test: Unhandled rejection with value: object "TypeError: Type error"
Modified: branches/safari-612-branch/LayoutTests/platform/wk2/TestExpectations (284306 => 284307)
--- branches/safari-612-branch/LayoutTests/platform/wk2/TestExpectations 2021-10-16 05:31:25 UTC (rev 284306)
+++ branches/safari-612-branch/LayoutTests/platform/wk2/TestExpectations 2021-10-16 06:02:53 UTC (rev 284307)
@@ -866,5 +866,4 @@
fast/speechrecognition/start-recognition-then-stop.html [ Pass ]
fast/speechrecognition/start-second-recognition.html [ Pass ]
fullscreen/full-screen-enter-while-exiting.html [ Pass ]
-imported/w3c/web-platform-tests/storage/ [ Pass ]
Modified: branches/safari-612-branch/Source/WebKit/NetworkProcess/NetworkProcess.cpp (284306 => 284307)
--- branches/safari-612-branch/Source/WebKit/NetworkProcess/NetworkProcess.cpp 2021-10-16 05:31:25 UTC (rev 284306)
+++ branches/safari-612-branch/Source/WebKit/NetworkProcess/NetworkProcess.cpp 2021-10-16 06:02:53 UTC (rev 284307)
@@ -2422,14 +2422,6 @@
completionHandler();
}
-void NetworkProcess::clearStorage(PAL::SessionID sessionID, CompletionHandler&& completionHandler)
-{
-if (auto manager = m_storageManagers.get(sessionID))
-manager->clearStorageForTesting(WTFMove(completionHandler));
-else
-completionHandler();
-}
-
void NetworkProcess::renameOriginInWebsiteData(PAL::SessionID sessionID, const URL& oldName, const URL& newName, OptionSet dataTypes, CompletionHandler&& completionHandler)
{
auto aggregator = CallbackAggregator::create(WTFMove(completionHandler));
Modified: branches/safari-612-branch/Source/WebKit/NetworkProcess/NetworkProcess.h (284306 => 284307)
--- branches/safari-612-branch/Source/WebKit/NetworkProcess/NetworkProcess.h 2021-10-16 05:31:25 UTC (rev 284306)
+++ branches/safari-612-branch/Source/WebKit/NetworkProcess/NetworkProcess.h 2021-10-16 06:02:53 UTC (rev 284307)
@@ -309,7 +309,6 @@
void syncLocalStorage(CompletionHandler&&);
void resetQuota(PAL::SessionID, CompletionHandler&&);
-void clearStorage(PAL::SessionID, CompletionHandler&&);
void
