[webkit-changes] [284667] trunk
Title: [284667] trunk
Revision 284667
Author cathiec...@igalia.com
Date 2021-10-21 22:05:42 -0700 (Thu, 21 Oct 2021)
Log Message
The intrisic size of picture image inside a template is always zero
https://bugs.webkit.org/show_bug.cgi?id=227682
Reviewed by Darin Adler.
LayoutTests/imported/w3c:
* web-platform-tests/html/semantics/embedded-content/the-img-element/adoption-expected.txt:
Source/WebCore:
When the picture element is inside a template element, it belongs to a template document which does not
have frame or RenderView, this would affect the source selection and size calculation. Though it calls
sourcesChanged to adjust the source in HTMLPictureElement::didMoveToNewDocument, but at this point
the image element is still inside the template document, so it does not help with this scenario. To
fix it, call sourcesChanged in HTMLImageElement::didMoveToNewDocument instead.
Test: fast/picture/picture-inside-template.html
* html/HTMLImageElement.cpp:
(WebCore::HTMLImageElement::didMoveToNewDocument):
* html/HTMLPictureElement.cpp:
(WebCore::HTMLPictureElement::didMoveToNewDocument): Deleted.
* html/HTMLPictureElement.h:
LayoutTests:
* fast/picture/picture-inside-template-expected.txt: Added.
* fast/picture/picture-inside-template.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/imported/w3c/ChangeLog
trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/adoption-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/HTMLImageElement.cpp
trunk/Source/WebCore/html/HTMLPictureElement.cpp
trunk/Source/WebCore/html/HTMLPictureElement.h
Added Paths
trunk/LayoutTests/fast/picture/picture-inside-template-expected.txt
trunk/LayoutTests/fast/picture/picture-inside-template.html
Diff
Modified: trunk/LayoutTests/ChangeLog (284666 => 284667)
--- trunk/LayoutTests/ChangeLog 2021-10-22 04:57:49 UTC (rev 284666)
+++ trunk/LayoutTests/ChangeLog 2021-10-22 05:05:42 UTC (rev 284667)
@@ -1,3 +1,13 @@
+2021-10-21 Cathie Chen
+
+The intrisic size of picture image inside a template is always zero
+https://bugs.webkit.org/show_bug.cgi?id=227682
+
+Reviewed by Darin Adler.
+
+* fast/picture/picture-inside-template-expected.txt: Added.
+* fast/picture/picture-inside-template.html: Added.
+
2021-10-21 Gabriel Nava Marino
Two null box iterators from different paths fail to compare equal
Added: trunk/LayoutTests/fast/picture/picture-inside-template-expected.txt (0 => 284667)
--- trunk/LayoutTests/fast/picture/picture-inside-template-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/picture/picture-inside-template-expected.txt 2021-10-22 05:05:42 UTC (rev 284667)
@@ -0,0 +1,9 @@
+PASS successfullyParsed is true
+
+TEST COMPLETE
+PASS document.getElementById("canary").clientWidth is 75
+PASS currentSrcFileName("canary") is "blue_rect.jpg?0"
+PASS document.getElementById("simple").clientWidth is 800
+PASS currentSrcFileName("simple") is "image-set-2x.png?2"
+
+
Added: trunk/LayoutTests/fast/picture/picture-inside-template.html (0 => 284667)
--- trunk/LayoutTests/fast/picture/picture-inside-template.html (rev 0)
+++ trunk/LayoutTests/fast/picture/picture-inside-template.html 2021-10-22 05:05:42 UTC (rev 284667)
@@ -0,0 +1,45 @@
+
+
+if (window.testRunner) {
+testRunner.waitUntilDone();
+testRunner.dumpAsText();
+}
+
+function runTest() {
+shouldBe('document.getElementById("canary").clientWidth', '75');
+shouldBe('currentSrcFileName("canary")', '"blue_rect.jpg?0"');
+shouldBe('document.getElementById("simple").clientWidth', '800');
+shouldBe('currentSrcFileName("simple")', '"image-set-2x.png?2"');
+if (window.testRunner)
+testRunner.notifyDone();
+}
+
+function removeTemplate() {
+let container = document.getElementById("container");
+let template = document.getElementsByTagName("template")[0];
+container.removeChild(template);
+let rocketElement = template.content.children[0];
+container.appendChild(rocketElement);
+setTimeout(runTest, 100);
+}
+
+window._onload_ = removeTemplate;
+
+
+
+
+
+
+
+
+
+
+
+
+
+
Modified: trunk/LayoutTests/imported/w3c/ChangeLog (284666 => 284667)
--- trunk/LayoutTests/imported/w3c/ChangeLog 2021-10-22 04:57:49 UTC (rev 284666)
+++ trunk/LayoutTests/imported/w3c/ChangeLog 2021-10-22 05:05:42 UTC (rev 284667)
@@ -1,3 +1,12 @@
+2021-10-21 Cathie Chen
+
+The intrisic size of picture image inside a template is always zero
+https://bugs.webkit.org/show_bug.cgi?id=227682
+
+Reviewed by Darin Adler.
+
+* web-platform-tests/html/semantics/embedded-content/the-img-element/adoption-expected.txt:
+
2021-10-21 Sihui Liu
FileSystemSyncAccessHandle should close platform file handle on close()
Modified:
[webkit-changes] [284666] trunk
Title: [284666] trunk Revision 284666 Author eric.carl...@apple.com Date 2021-10-21 21:57:49 -0700 (Thu, 21 Oct 2021) Log Message Add GitHub name to contributors.json https://bugs.webkit.org/show_bug.cgi?id=232131 Add my github username to contributors.json Unreviewed. * metadata/contributors.json: Modified Paths trunk/ChangeLog trunk/metadata/contributors.json Diff Modified: trunk/ChangeLog (284665 => 284666) --- trunk/ChangeLog 2021-10-22 04:52:50 UTC (rev 284665) +++ trunk/ChangeLog 2021-10-22 04:57:49 UTC (rev 284666) @@ -1,3 +1,14 @@ +2021-10-21 Eric Carlson + +Add GitHub name to contributors.json +https://bugs.webkit.org/show_bug.cgi?id=232131 + +Add my github username to contributors.json + +Unreviewed. + +* metadata/contributors.json: + 2021-10-21 Chris Lord [WPE][GTK] Enable smooth scrolling by default Modified: trunk/metadata/contributors.json (284665 => 284666) --- trunk/metadata/contributors.json 2021-10-22 04:52:50 UTC (rev 284665) +++ trunk/metadata/contributors.json 2021-10-22 04:57:49 UTC (rev 284666) @@ -2254,6 +2254,7 @@ "eric.carl...@apple.com" ], "expertise" : "HTML5 Media Elements", + "github" : "eric-carlson", "name" : "Eric Carlson", "nicks" : [ "eric_carlson" ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [284665] trunk
Title: [284665] trunk
Revision 284665
Author commit-qu...@webkit.org
Date 2021-10-21 21:52:50 -0700 (Thu, 21 Oct 2021)
Log Message
Two null box iterators from different paths fail to compare equal
https://bugs.webkit.org/show_bug.cgi?id=232093
Patch by Gabriel Nava Marino on 2021-10-21
Reviewed by Antti Koivisto.
Source/WebCore:
Test: fast/clip/clip-hit-null-iterator-path-comparison.html
* layout/integration/InlineIteratorBox.cpp:
(WebCore::InlineIterator::BoxIterator::operator== const):
LayoutTests:
* fast/clip/clip-hit-null-iterator-path-comparison-expected.txt: Added.
* fast/clip/clip-hit-null-iterator-path-comparison.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/layout/integration/InlineIteratorBox.cpp
Added Paths
trunk/LayoutTests/fast/clip/clip-hit-null-iterator-path-comparison-expected.txt
trunk/LayoutTests/fast/clip/clip-hit-null-iterator-path-comparison.html
Diff
Modified: trunk/LayoutTests/ChangeLog (284664 => 284665)
--- trunk/LayoutTests/ChangeLog 2021-10-22 04:31:45 UTC (rev 284664)
+++ trunk/LayoutTests/ChangeLog 2021-10-22 04:52:50 UTC (rev 284665)
@@ -1,3 +1,13 @@
+2021-10-21 Gabriel Nava Marino
+
+Two null box iterators from different paths fail to compare equal
+https://bugs.webkit.org/show_bug.cgi?id=232093
+
+Reviewed by Antti Koivisto.
+
+* fast/clip/clip-hit-null-iterator-path-comparison-expected.txt: Added.
+* fast/clip/clip-hit-null-iterator-path-comparison.html: Added.
+
2021-10-21 Chris Dumez
Form submission should be cancelled if the form gets detached from inside the formdata event handler
Added: trunk/LayoutTests/fast/clip/clip-hit-null-iterator-path-comparison-expected.txt (0 => 284665)
--- trunk/LayoutTests/fast/clip/clip-hit-null-iterator-path-comparison-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/clip/clip-hit-null-iterator-path-comparison-expected.txt 2021-10-22 04:52:50 UTC (rev 284665)
@@ -0,0 +1 @@
+ PASS
Added: trunk/LayoutTests/fast/clip/clip-hit-null-iterator-path-comparison.html (0 => 284665)
--- trunk/LayoutTests/fast/clip/clip-hit-null-iterator-path-comparison.html (rev 0)
+++ trunk/LayoutTests/fast/clip/clip-hit-null-iterator-path-comparison.html 2021-10-22 04:52:50 UTC (rev 284665)
@@ -0,0 +1,12 @@
+
+ ::first-line {
+background-clip: text;
+ }
+
+
+PASS
+
+ if (window.testRunner)
+ testRunner.dumpAsText();
+
+
Modified: trunk/Source/WebCore/ChangeLog (284664 => 284665)
--- trunk/Source/WebCore/ChangeLog 2021-10-22 04:31:45 UTC (rev 284664)
+++ trunk/Source/WebCore/ChangeLog 2021-10-22 04:52:50 UTC (rev 284665)
@@ -1,3 +1,15 @@
+2021-10-21 Gabriel Nava Marino
+
+Two null box iterators from different paths fail to compare equal
+https://bugs.webkit.org/show_bug.cgi?id=232093
+
+Reviewed by Antti Koivisto.
+
+Test: fast/clip/clip-hit-null-iterator-path-comparison.html
+
+* layout/integration/InlineIteratorBox.cpp:
+(WebCore::InlineIterator::BoxIterator::operator== const):
+
2021-10-21 Saam Barati
Clean up some code around checking the state of Watchpoints
Modified: trunk/Source/WebCore/layout/integration/InlineIteratorBox.cpp (284664 => 284665)
--- trunk/Source/WebCore/layout/integration/InlineIteratorBox.cpp 2021-10-22 04:31:45 UTC (rev 284664)
+++ trunk/Source/WebCore/layout/integration/InlineIteratorBox.cpp 2021-10-22 04:52:50 UTC (rev 284665)
@@ -48,6 +48,9 @@
bool BoxIterator::operator==(const BoxIterator& other) const
{
+if (atEnd() && other.atEnd())
+return true;
+
return m_box.m_pathVariant == other.m_box.m_pathVariant;
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [284664] trunk/Source
Title: [284664] trunk/Source
Revision 284664
Author sbar...@apple.com
Date 2021-10-21 21:31:45 -0700 (Thu, 21 Oct 2021)
Log Message
Clean up some code around checking the state of Watchpoints
https://bugs.webkit.org/show_bug.cgi?id=232111
Reviewed by Yusuke Suzuki.
Source/_javascript_Core:
No need to have state() and stateOnJSThread(), since they're now the same.
Also, there is no need to check the allocation watchpoint twice for the
function/internal function allocation profiles.
* bytecode/Watchpoint.h:
(JSC::WatchpointSet::isStillValid const):
(JSC::WatchpointSet::stateOnJSThread const): Deleted.
(JSC::WatchpointSet::isStillValidOnJSThread const): Deleted.
(JSC::InlineWatchpointSet::stateOnJSThread const): Deleted.
* dfg/DFGAbstractInterpreterInlines.h:
(JSC::DFG::AbstractInterpreter::executeEffects):
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parseBlock):
(JSC::DFG::ByteCodeParser::handleCreateInternalFieldObject):
* dfg/DFGConstantFoldingPhase.cpp:
(JSC::DFG::ConstantFoldingPhase::foldConstants):
* runtime/ArrayPrototype.cpp:
(JSC::speciesWatchpointIsValid):
(JSC::canUseDefaultArrayJoinForToString):
* runtime/InferredValue.h:
(JSC::InferredValue::notifyWrite):
(JSC::InferredValue::stateOnJSThread const): Deleted.
* runtime/JSArrayBufferPrototypeInlines.h:
(JSC::speciesWatchpointIsValid):
* runtime/ObjectPropertyChangeAdaptiveWatchpoint.h:
Source/WebCore:
* bindings/js/JSDOMWindowCustom.cpp:
(WebCore::JSDOMWindow::getOwnPropertySlot):
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/bytecode/Watchpoint.h
trunk/Source/_javascript_Core/dfg/DFGAbstractInterpreterInlines.h
trunk/Source/_javascript_Core/dfg/DFGByteCodeParser.cpp
trunk/Source/_javascript_Core/dfg/DFGConstantFoldingPhase.cpp
trunk/Source/_javascript_Core/runtime/ArrayPrototype.cpp
trunk/Source/_javascript_Core/runtime/InferredValue.h
trunk/Source/_javascript_Core/runtime/JSArrayBufferPrototypeInlines.h
trunk/Source/_javascript_Core/runtime/ObjectPropertyChangeAdaptiveWatchpoint.h
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/js/JSDOMWindowCustom.cpp
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (284663 => 284664)
--- trunk/Source/_javascript_Core/ChangeLog 2021-10-22 02:15:01 UTC (rev 284663)
+++ trunk/Source/_javascript_Core/ChangeLog 2021-10-22 04:31:45 UTC (rev 284664)
@@ -1,3 +1,36 @@
+2021-10-21 Saam Barati
+
+Clean up some code around checking the state of Watchpoints
+https://bugs.webkit.org/show_bug.cgi?id=232111
+
+Reviewed by Yusuke Suzuki.
+
+No need to have state() and stateOnJSThread(), since they're now the same.
+Also, there is no need to check the allocation watchpoint twice for the
+function/internal function allocation profiles.
+
+* bytecode/Watchpoint.h:
+(JSC::WatchpointSet::isStillValid const):
+(JSC::WatchpointSet::stateOnJSThread const): Deleted.
+(JSC::WatchpointSet::isStillValidOnJSThread const): Deleted.
+(JSC::InlineWatchpointSet::stateOnJSThread const): Deleted.
+* dfg/DFGAbstractInterpreterInlines.h:
+(JSC::DFG::AbstractInterpreter::executeEffects):
+* dfg/DFGByteCodeParser.cpp:
+(JSC::DFG::ByteCodeParser::parseBlock):
+(JSC::DFG::ByteCodeParser::handleCreateInternalFieldObject):
+* dfg/DFGConstantFoldingPhase.cpp:
+(JSC::DFG::ConstantFoldingPhase::foldConstants):
+* runtime/ArrayPrototype.cpp:
+(JSC::speciesWatchpointIsValid):
+(JSC::canUseDefaultArrayJoinForToString):
+* runtime/InferredValue.h:
+(JSC::InferredValue::notifyWrite):
+(JSC::InferredValue::stateOnJSThread const): Deleted.
+* runtime/JSArrayBufferPrototypeInlines.h:
+(JSC::speciesWatchpointIsValid):
+* runtime/ObjectPropertyChangeAdaptiveWatchpoint.h:
+
2021-10-21 Mark Lam
Remove an unused field: Heap::m_copyingRememberedSet.
Modified: trunk/Source/_javascript_Core/bytecode/Watchpoint.h (284663 => 284664)
--- trunk/Source/_javascript_Core/bytecode/Watchpoint.h 2021-10-22 02:15:01 UTC (rev 284663)
+++ trunk/Source/_javascript_Core/bytecode/Watchpoint.h 2021-10-22 04:31:45 UTC (rev 284664)
@@ -190,17 +190,14 @@
return adoptRef(*new WatchpointSet(state));
}
-// Fast way of getting the state, which only works from the main thread.
-WatchpointState stateOnJSThread() const
-{
-return static_cast(m_state);
-}
-
-// It is safe to call this from another thread. It may return an old
-// state. Guarantees that if *first* read the state() of the thing being
-// watched and it returned IsWatched and *second* you actually read its
-// value then it's safe to assume that if the state being watched changes
-// then also the watchpoint state() will change to IsInvalidated.
+// It is always safe to call this from the main thread.
+// It is also safe to call this
[webkit-changes] [284663] trunk/Source/JavaScriptCore
Title: [284663] trunk/Source/_javascript_Core
Revision 284663
Author mark@apple.com
Date 2021-10-21 19:15:01 -0700 (Thu, 21 Oct 2021)
Log Message
Remove an unused field: Heap::m_copyingRememberedSet.
https://bugs.webkit.org/show_bug.cgi?id=232119
Reviewed by Robin Morisset.
* heap/Heap.h:
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/heap/Heap.h
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (284662 => 284663)
--- trunk/Source/_javascript_Core/ChangeLog 2021-10-22 01:32:04 UTC (rev 284662)
+++ trunk/Source/_javascript_Core/ChangeLog 2021-10-22 02:15:01 UTC (rev 284663)
@@ -1,3 +1,12 @@
+2021-10-21 Mark Lam
+
+Remove an unused field: Heap::m_copyingRememberedSet.
+https://bugs.webkit.org/show_bug.cgi?id=232119
+
+Reviewed by Robin Morisset.
+
+* heap/Heap.h:
+
2021-10-21 Yusuke Suzuki
[JSC] Make GetTypedArrayLengthAsInt52 and GetTypedArrayByteOffsetAsInt52 NodeResultInt52
Modified: trunk/Source/_javascript_Core/heap/Heap.h (284662 => 284663)
--- trunk/Source/_javascript_Core/heap/Heap.h 2021-10-22 01:32:04 UTC (rev 284662)
+++ trunk/Source/_javascript_Core/heap/Heap.h 2021-10-22 02:15:01 UTC (rev 284663)
@@ -621,8 +621,6 @@
size_t m_extraMemorySize { 0 };
size_t m_deprecatedExtraMemorySize { 0 };
-HashSet m_copyingRememberedSet;
-
ProtectCountSet m_protectedValues;
std::unique_ptr> m_markListSet;
SentinelLinkedList> m_markedJSValueRefArrays;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [284662] trunk/Source/WebKit
Title: [284662] trunk/Source/WebKit
Revision 284662
Author commit-qu...@webkit.org
Date 2021-10-21 18:32:04 -0700 (Thu, 21 Oct 2021)
Log Message
Add webpushd plist
https://bugs.webkit.org/show_bug.cgi?id=231981
Patch by Alex Christensen on 2021-10-21
Reviewed by Brady Eidson.
This can be done once rdar://83086960 is approved.
* WebKit.xcodeproj/project.pbxproj:
* webpushd/com.apple.webkit.webpushd.plist: Added.
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/WebKit.xcodeproj/project.pbxproj
Added Paths
trunk/Source/WebKit/webpushd/com.apple.webkit.webpushd.plist
Diff
Modified: trunk/Source/WebKit/ChangeLog (284661 => 284662)
--- trunk/Source/WebKit/ChangeLog 2021-10-22 00:46:35 UTC (rev 284661)
+++ trunk/Source/WebKit/ChangeLog 2021-10-22 01:32:04 UTC (rev 284662)
@@ -1,5 +1,17 @@
2021-10-21 Alex Christensen
+Add webpushd plist
+https://bugs.webkit.org/show_bug.cgi?id=231981
+
+Reviewed by Brady Eidson.
+
+This can be done once rdar://83086960 is approved.
+
+* WebKit.xcodeproj/project.pbxproj:
+* webpushd/com.apple.webkit.webpushd.plist: Added.
+
+2021-10-21 Alex Christensen
+
Unreviewed, reverting r284570.
No longer needed
Modified: trunk/Source/WebKit/WebKit.xcodeproj/project.pbxproj (284661 => 284662)
--- trunk/Source/WebKit/WebKit.xcodeproj/project.pbxproj 2021-10-22 00:46:35 UTC (rev 284661)
+++ trunk/Source/WebKit/WebKit.xcodeproj/project.pbxproj 2021-10-22 01:32:04 UTC (rev 284662)
@@ -4687,6 +4687,7 @@
5CB9310626E839A90032B1C0 /* PrivateClickMeasurementManagerInterface.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = PrivateClickMeasurementManagerInterface.cpp; sourceTree = ""; };
5CB9310726E841CB0032B1C0 /* PrivateClickMeasurementXPCUtilities.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = PrivateClickMeasurementXPCUtilities.h; sourceTree = ""; };
5CB9310826E841CB0032B1C0 /* PrivateClickMeasurementXPCUtilities.mm */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.objcpp; path = PrivateClickMeasurementXPCUtilities.mm; sourceTree = ""; };
+ 5CBB6D4D271F67CC00FD1A5D /* com.apple.webkit.webpushd.plist */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = text.plist.xml; path = com.apple.webkit.webpushd.plist; sourceTree = ""; };
5CBC9B891C6524A500A8FDCF /* NetworkDataTask.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = NetworkDataTask.h; sourceTree = ""; };
5CBC9B8B1C65257300A8FDCF /* NetworkDataTaskCocoa.mm */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.objcpp; path = NetworkDataTaskCocoa.mm; sourceTree = ""; };
5CBE908F26D7FB62005A2E95 /* PrivateClickMeasurementDebugInfo.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = PrivateClickMeasurementDebugInfo.h; sourceTree = ""; };
@@ -9575,6 +9576,7 @@
5C157A0A2717C9F100ED5280 /* webpushd */ = {
isa = PBXGroup;
children = (
+5CBB6D4D271F67CC00FD1A5D /* com.apple.webkit.webpushd.plist */,
5C157A0B2717CA1C00ED5280 /* WebPushDaemonMain.mm */,
);
path = webpushd;
@@ -12526,7 +12528,6 @@
1A6D86C21DF75265007745E8 /* MachMessage.h in Headers */,
BCC56F791159957D001CCAF9 /* MachPort.h in Headers */,
1A24B5F311F531E800C38269 /* MachUtilities.h in Headers */,
-514526FF271FB7EC000467B6 /* NotificationManagerMessageHandler.h in Headers */,
A15799BE2584433200528236 /* MediaFormatReader.h in Headers */,
9ACC07B125C815D800DC6386 /* MediaKeySystemPermissionRequest.h in Headers */,
9ACC07AD25C8132D00DC6386 /* MediaKeySystemPermissionRequestManager.h in Headers */,
@@ -12561,7 +12562,6 @@
1ADCB86B189831B30022EE5A /* NavigationActionData.h in Headers */,
57FD318022B35158008D0E8B /* NavigationSOAuthorizationSession.h in Headers */,
1ABC3DF61899E437004F0626 /* NavigationState.h in Headers */,
-51452708271FBEC6000467B6 /* WebNotificationManagerMessageHandler.h in Headers */,
57B826442304F14000B72EB0 /* NearFieldSoftLink.h in Headers */,
57B826412304EB3E00B72EB0 /* NearFieldSPI.h in Headers */,
1A6FBA2A11E6862700DB1371 /* NetscapeBrowserFuncs.h in Headers */,
@@ -12592,9 +12592,9 @@
83D454D71BE9D3C4006C93BD /* NetworkLoadClient.h in Headers */,
839149651BEA838500D2D953 /* NetworkLoadParameters.h in Headers */,
E47FC8A025B8331C005495FC /* NetworkLoadScheduler.h in Headers */,
+514526ED271E1647000467B6 /* NetworkNotificationManager.h in Headers */,
5179556A162876F300FA43B6 /* NetworkProcess.h in Headers */,
517CF0E4163A486C00C2950E /* NetworkProcessConnectionMessages.h in Headers */,
-51452704271FBA4467B6 /* NotificationManagerMessageHandlerMessagesReplies.h in Headers */,
5C1426ED1C23F80900D41183 /* NetworkProcessCreationParameters.h in
[webkit-changes] [284661] trunk/Source/WebKit
Title: [284661] trunk/Source/WebKit
Revision 284661
Author achristen...@apple.com
Date 2021-10-21 17:46:35 -0700 (Thu, 21 Oct 2021)
Log Message
Unreviewed, reverting r284570.
No longer needed
Reverted changeset:
"Remove com.apple.webkit.adattributiond.plist from build
temporarily"
https://bugs.webkit.org/show_bug.cgi?id=232045
https://commits.webkit.org/r284570
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/WebsiteData/WebsiteDataStoreConfiguration.cpp
trunk/Source/WebKit/WebKit.xcodeproj/project.pbxproj
Diff
Modified: trunk/Source/WebKit/ChangeLog (284660 => 284661)
--- trunk/Source/WebKit/ChangeLog 2021-10-22 00:46:04 UTC (rev 284660)
+++ trunk/Source/WebKit/ChangeLog 2021-10-22 00:46:35 UTC (rev 284661)
@@ -1,3 +1,16 @@
+2021-10-21 Alex Christensen
+
+Unreviewed, reverting r284570.
+
+No longer needed
+
+Reverted changeset:
+
+"Remove com.apple.webkit.adattributiond.plist from build
+temporarily"
+https://bugs.webkit.org/show_bug.cgi?id=232045
+https://commits.webkit.org/r284570
+
2021-10-21 Chris Dumez
Call to [NSURL URLByAppendingPathComponent:] under NetworkSessionCocoa() may be inefficient
Modified: trunk/Source/WebKit/UIProcess/WebsiteData/WebsiteDataStoreConfiguration.cpp (284660 => 284661)
--- trunk/Source/WebKit/UIProcess/WebsiteData/WebsiteDataStoreConfiguration.cpp 2021-10-22 00:46:04 UTC (rev 284660)
+++ trunk/Source/WebKit/UIProcess/WebsiteData/WebsiteDataStoreConfiguration.cpp 2021-10-22 00:46:35 UTC (rev 284661)
@@ -51,6 +51,9 @@
#if ENABLE(ARKIT_INLINE_PREVIEW)
setModelElementCacheDirectory(WebsiteDataStore::defaultModelElementCacheDirectory());
#endif
+#if PLATFORM(IOS)
+setPCMMachServiceName("com.apple.webkit.adattributiond.service");
+#endif
}
}
Modified: trunk/Source/WebKit/WebKit.xcodeproj/project.pbxproj (284660 => 284661)
--- trunk/Source/WebKit/WebKit.xcodeproj/project.pbxproj 2021-10-22 00:46:04 UTC (rev 284660)
+++ trunk/Source/WebKit/WebKit.xcodeproj/project.pbxproj 2021-10-22 00:46:35 UTC (rev 284661)
@@ -14582,7 +14582,7 @@
);
runOnlyForDeploymentPostprocessing = 0;
shellPath = /bin/sh;
- shellScript = "echo \"not copying adattributiond plist\"\n";
+ shellScript = "if [[ \"${WK_PLATFORM_NAME}\" == iphoneos ]]; then\nDAEMON_PLIST_SOURCE=\"${SRCROOT}/Shared/EntryPointUtilities/Cocoa/Daemon/com.apple.webkit.adattributiond.plist\"\nDAEMON_PLIST_DESTINATION=\"${DSTROOT}/System/Library/LaunchDaemons/com.apple.webkit.adattributiond.plist\"\necho \"copying adattributiond plist\"\necho plutil -convert binary1 -o \"${DAEMON_PLIST_DESTINATION}\" \"${DAEMON_PLIST_SOURCE}\"\nplutil -convert binary1 -o \"${DAEMON_PLIST_DESTINATION}\" \"${DAEMON_PLIST_SOURCE}\"\nelse\necho \"not copying adattributiond plist\"\nfi\n";
};
E1AC2E2C20F7B95800B0897D /* Unlock Keychain */ = {
isa = PBXShellScriptBuildPhase;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [284660] trunk
Title: [284660] trunk
Revision 284660
Author cdu...@apple.com
Date 2021-10-21 17:46:04 -0700 (Thu, 21 Oct 2021)
Log Message
Form submission should be cancelled if the form gets detached from inside the formdata event handler
https://bugs.webkit.org/show_bug.cgi?id=232114
Reviewed by Alex Christensen.
Source/WebCore:
Per the HTML specification [1], form submission should abort if the form cannot navigate (which is true
when the form is detached). The algorithm in the specification does the check twice, once at the very
beginning (Step 1 in the spec), and again after calling the "constructing the entry list" algorithm
(step 9 in the spec). The reason we need to do the check again is that the "constructing the entry list"
algorithm fires the "formdata" event and may thus run _javascript_ and the JS can detach the form element.
In HTMLFormElement::submit(), we were doing only the "form is connected" check only at the beginning
of the function and failing to do so after constructing the FormSubmission object (which ends up constructing
the entry list). This patch fixes that.
[1] https://html.spec.whatwg.org/multipage/form-control-infrastructure.html#concept-form-submit
Test: fast/forms/remove-form-inside-formdata-event.html
* html/HTMLFormElement.cpp:
(WebCore::HTMLFormElement::submit):
LayoutTests:
Add layout test coverage.
* fast/forms/remove-form-inside-formdata-event-expected.txt: Added.
* fast/forms/remove-form-inside-formdata-event.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/HTMLFormElement.cpp
Added Paths
trunk/LayoutTests/fast/forms/remove-form-inside-formdata-event-expected.txt
trunk/LayoutTests/fast/forms/remove-form-inside-formdata-event.html
Diff
Modified: trunk/LayoutTests/ChangeLog (284659 => 284660)
--- trunk/LayoutTests/ChangeLog 2021-10-22 00:33:37 UTC (rev 284659)
+++ trunk/LayoutTests/ChangeLog 2021-10-22 00:46:04 UTC (rev 284660)
@@ -1,3 +1,15 @@
+2021-10-21 Chris Dumez
+
+Form submission should be cancelled if the form gets detached from inside the formdata event handler
+https://bugs.webkit.org/show_bug.cgi?id=232114
+
+Reviewed by Alex Christensen.
+
+Add layout test coverage.
+
+* fast/forms/remove-form-inside-formdata-event-expected.txt: Added.
+* fast/forms/remove-form-inside-formdata-event.html: Added.
+
2021-10-21 Eric Hutchison
[ iOS15 Sim EWS ]imported/w3c/web-platform-tests/content-security-policy/script-src/script-src-multiple-policies-multiple-hashing-algorithms.html is a text failure.
Added: trunk/LayoutTests/fast/forms/remove-form-inside-formdata-event-expected.txt (0 => 284660)
--- trunk/LayoutTests/fast/forms/remove-form-inside-formdata-event-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/forms/remove-form-inside-formdata-event-expected.txt 2021-10-22 00:46:04 UTC (rev 284660)
@@ -0,0 +1,10 @@
+Tests that form submission gets cancelled when the form gets detached from inside the formdata event handler.
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+PASS frame.contentWindow.location.href.indexOf('test2.txt') != -1 is true
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
Added: trunk/LayoutTests/fast/forms/remove-form-inside-formdata-event.html (0 => 284660)
--- trunk/LayoutTests/fast/forms/remove-form-inside-formdata-event.html (rev 0)
+++ trunk/LayoutTests/fast/forms/remove-form-inside-formdata-event.html 2021-10-22 00:46:04 UTC (rev 284660)
@@ -0,0 +1,31 @@
+
+
+
+
+description("Tests that form submission gets cancelled when the form gets detached from inside the formdata event handler.");
+jsTestIsAsync = true;
+
+_onload_ = () => {
+let form = document.getElementById("testForm");
+frame = document.getElementById("testFrame");
+frame._onload_ = () => {
+// Form submission should have been cancelled since the form was detached in the
+// formdata event handler. As a result, we should continue the origin test2.txt
+// navigation instead of doing the test.txt form navigation.
+shouldBeTrue("frame.contentWindow.location.href.indexOf('test2.txt') != -1");
+finishJSTest();
+};
+form.addEventListener('formdata', e => {
+form.remove();
+});
+frame.src = ""
+form.submit();
+}
+
+
+
+
+
+
+
Modified: trunk/Source/WebCore/ChangeLog (284659 => 284660)
--- trunk/Source/WebCore/ChangeLog 2021-10-22 00:33:37 UTC (rev 284659)
+++ trunk/Source/WebCore/ChangeLog 2021-10-22 00:46:04 UTC (rev 284660)
@@ -1,5 +1,29 @@
2021-10-21 Chris Dumez
+Form submission should be cancelled if the form gets detached from inside the formdata event handler
+https://bugs.webkit.org/show_bug.cgi?id=232114
+
+Reviewed by Alex Christensen.
+
+Per the HTML specification [1], form submission should abort if the form cannot
[webkit-changes] [284659] trunk/LayoutTests
Title: [284659] trunk/LayoutTests Revision 284659 Author ehutchi...@apple.com Date 2021-10-21 17:33:37 -0700 (Thu, 21 Oct 2021) Log Message [ iOS15 Sim EWS ]imported/w3c/web-platform-tests/content-security-policy/script-src/script-src-multiple-policies-multiple-hashing-algorithms.html is a text failure. https://bugs.webkit.org/show_bug.cgi?id=232120. Unreviewed test gardening. * platform/ios-wk2/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/ios-wk2/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (284658 => 284659) --- trunk/LayoutTests/ChangeLog 2021-10-22 00:11:30 UTC (rev 284658) +++ trunk/LayoutTests/ChangeLog 2021-10-22 00:33:37 UTC (rev 284659) @@ -1,3 +1,12 @@ +2021-10-21 Eric Hutchison + +[ iOS15 Sim EWS ]imported/w3c/web-platform-tests/content-security-policy/script-src/script-src-multiple-policies-multiple-hashing-algorithms.html is a text failure. +https://bugs.webkit.org/show_bug.cgi?id=232120. + +Unreviewed test gardening. + +* platform/ios-wk2/TestExpectations: + 2021-10-21 Chris Dumez Unreviewed, add bug number for skipped test in TestExpectations. Modified: trunk/LayoutTests/platform/ios-wk2/TestExpectations (284658 => 284659) --- trunk/LayoutTests/platform/ios-wk2/TestExpectations 2021-10-22 00:11:30 UTC (rev 284658) +++ trunk/LayoutTests/platform/ios-wk2/TestExpectations 2021-10-22 00:33:37 UTC (rev 284659) @@ -2234,3 +2234,5 @@ webkit.org/b/232102 http/tests/privateClickMeasurement/attribution-conversion-through-image-redirect-with-priority.html [ Pass Crash ] +webkit.org/b/232120 imported/w3c/web-platform-tests/content-security-policy/script-src/script-src-multiple-policies-multiple-hashing-algorithms.html [ Pass Failure ] + ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [284658] trunk/LayoutTests
Title: [284658] trunk/LayoutTests Revision 284658 Author cdu...@apple.com Date 2021-10-21 17:11:30 -0700 (Thu, 21 Oct 2021) Log Message Unreviewed, add bug number for skipped test in TestExpectations. * TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (284657 => 284658) --- trunk/LayoutTests/ChangeLog 2021-10-22 00:10:09 UTC (rev 284657) +++ trunk/LayoutTests/ChangeLog 2021-10-22 00:11:30 UTC (rev 284658) @@ -1,5 +1,11 @@ 2021-10-21 Chris Dumez +Unreviewed, add bug number for skipped test in TestExpectations. + +* TestExpectations: + +2021-10-21 Chris Dumez + RELEASE_ASSERT(result) under FormSubmission::create() https://bugs.webkit.org/show_bug.cgi?id=232112 Modified: trunk/LayoutTests/TestExpectations (284657 => 284658) --- trunk/LayoutTests/TestExpectations 2021-10-22 00:10:09 UTC (rev 284657) +++ trunk/LayoutTests/TestExpectations 2021-10-22 00:11:30 UTC (rev 284658) @@ -604,7 +604,7 @@ imported/w3c/web-platform-tests/dom/events/EventListener-incumbent-global-2.sub.html [ Skip ] imported/w3c/web-platform-tests/webmessaging/broadcastchannel/origin.window.html [ Skip ] imported/w3c/web-platform-tests/html/semantics/document-metadata/the-style-element/style-error-01.html [ Skip ] -imported/w3c/web-platform-tests/html/semantics/forms/form-submission-0/form-submission-algorithm.html [ Skip ] +webkit.org/b/232117 imported/w3c/web-platform-tests/html/semantics/forms/form-submission-0/form-submission-algorithm.html [ Skip ] imported/w3c/web-platform-tests/html/browsers/origin/relaxing-the-same-origin-restriction/document_domain_access_details.sub.html [ Skip ] imported/w3c/web-platform-tests/html/browsers/sandboxing/sandbox-disallow-scripts-via-unsandboxed-popup.tentative.html [ Skip ] imported/w3c/web-platform-tests/html/canvas/element/fill-and-stroke-styles/2d.pattern.transform.infinity.html [ Skip ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [284656] trunk
Title: [284656] trunk
Revision 284656
Author cdu...@apple.com
Date 2021-10-21 17:09:34 -0700 (Thu, 21 Oct 2021)
Log Message
RELEASE_ASSERT(result) under FormSubmission::create()
https://bugs.webkit.org/show_bug.cgi?id=232112
Reviewed by Geoffrey Garen.
Source/WebCore:
form.submit() should early return if the form's |constructing entry list| flag is true, as per:
- https://html.spec.whatwg.org/multipage/form-control-infrastructure.html#concept-form-submit (Step 2)
We were missing this check. As a result, we would call FormSubmission::create(), which would call
form.constructEntryList(). This would end up returning an unexpected nullptr because the
form's |constructing entry list| flag is set and we would hit the `RELEASE_ASSERT(result)` in
FormSubmission::create().
Test: fast/forms/submit-form-inside-formdata-event.html
* html/HTMLFormElement.cpp:
(WebCore::HTMLFormElement::submit):
* loader/FormSubmission.cpp:
(WebCore::FormSubmission::create):
LayoutTests:
Add layout test coverage.
* fast/forms/submit-form-inside-formdata-event-expected.txt: Added.
* fast/forms/submit-form-inside-formdata-event.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/HTMLFormElement.cpp
Added Paths
trunk/LayoutTests/fast/forms/submit-form-inside-formdata-event-expected.txt
trunk/LayoutTests/fast/forms/submit-form-inside-formdata-event.html
Diff
Modified: trunk/LayoutTests/ChangeLog (284655 => 284656)
--- trunk/LayoutTests/ChangeLog 2021-10-22 00:08:14 UTC (rev 284655)
+++ trunk/LayoutTests/ChangeLog 2021-10-22 00:09:34 UTC (rev 284656)
@@ -1,3 +1,15 @@
+2021-10-21 Chris Dumez
+
+RELEASE_ASSERT(result) under FormSubmission::create()
+https://bugs.webkit.org/show_bug.cgi?id=232112
+
+Reviewed by Geoffrey Garen.
+
+Add layout test coverage.
+
+* fast/forms/submit-form-inside-formdata-event-expected.txt: Added.
+* fast/forms/submit-form-inside-formdata-event.html: Added.
+
2021-10-21 Simon Fraser
Content offset in this codepen when switching tabs
Added: trunk/LayoutTests/fast/forms/submit-form-inside-formdata-event-expected.txt (0 => 284656)
--- trunk/LayoutTests/fast/forms/submit-form-inside-formdata-event-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/forms/submit-form-inside-formdata-event-expected.txt 2021-10-22 00:09:34 UTC (rev 284656)
@@ -0,0 +1,12 @@
+Tests submitting the form again from inside the formdata event.
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+PASS counter is 1
+PASS counter is 2
+PASS The frame was navigated
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
Added: trunk/LayoutTests/fast/forms/submit-form-inside-formdata-event.html (0 => 284656)
--- trunk/LayoutTests/fast/forms/submit-form-inside-formdata-event.html (rev 0)
+++ trunk/LayoutTests/fast/forms/submit-form-inside-formdata-event.html 2021-10-22 00:09:34 UTC (rev 284656)
@@ -0,0 +1,32 @@
+
+
+
+
+description("Tests submitting the form again from inside the formdata event.");
+jsTestIsAsync = true;
+
+_onload_ = () => {
+let form = document.getElementById("testForm");
+let frame = document.getElementById("testFrame");
+frame._onload_ = () => {
+testPassed("The frame was navigated");
+finishJSTest();
+};
+counter = 0;
+form.addEventListener('formdata', e => {
+++counter;
+form.submit();
+});
+form.submit();
+shouldBe("counter", "1");
+new FormData(form);
+shouldBe("counter", "2");
+}
+
+
+
+
+
+
+
Modified: trunk/Source/WebCore/ChangeLog (284655 => 284656)
--- trunk/Source/WebCore/ChangeLog 2021-10-22 00:08:14 UTC (rev 284655)
+++ trunk/Source/WebCore/ChangeLog 2021-10-22 00:09:34 UTC (rev 284656)
@@ -1,3 +1,25 @@
+2021-10-21 Chris Dumez
+
+RELEASE_ASSERT(result) under FormSubmission::create()
+https://bugs.webkit.org/show_bug.cgi?id=232112
+
+Reviewed by Geoffrey Garen.
+
+form.submit() should early return if the form's |constructing entry list| flag is true, as per:
+- https://html.spec.whatwg.org/multipage/form-control-infrastructure.html#concept-form-submit (Step 2)
+
+We were missing this check. As a result, we would call FormSubmission::create(), which would call
+form.constructEntryList(). This would end up returning an unexpected nullptr because the
+form's |constructing entry list| flag is set and we would hit the `RELEASE_ASSERT(result)` in
+FormSubmission::create().
+
+Test: fast/forms/submit-form-inside-formdata-event.html
+
+* html/HTMLFormElement.cpp:
+(WebCore::HTMLFormElement::submit):
+* loader/FormSubmission.cpp:
+(WebCore::FormSubmission::create):
+
2021-10-21 Simon Fraser
REGRESSION (r275641): [ iPad Debug ] accessibility/ios-simulator/scroll-in-overflow-div.html is
[webkit-changes] [284657] trunk/Tools
Title: [284657] trunk/Tools
Revision 284657
Author ryanhad...@apple.com
Date 2021-10-21 17:10:09 -0700 (Thu, 21 Oct 2021)
Log Message
WebGL bot should run tests with GPU Process enabled
https://bugs.webkit.org/show_bug.cgi?id=232107
Reviewed by Jonathan Bedard.
* CISupport/build-webkit-org/config.json:
* CISupport/build-webkit-org/factories_unittest.py:
Modified Paths
trunk/Tools/CISupport/build-webkit-org/config.json
trunk/Tools/CISupport/build-webkit-org/factories_unittest.py
trunk/Tools/ChangeLog
Diff
Modified: trunk/Tools/CISupport/build-webkit-org/config.json (284656 => 284657)
--- trunk/Tools/CISupport/build-webkit-org/config.json 2021-10-22 00:09:34 UTC (rev 284656)
+++ trunk/Tools/CISupport/build-webkit-org/config.json 2021-10-22 00:10:09 UTC (rev 284657)
@@ -136,7 +136,7 @@
"platform": "mac-bigsur", "configuration": "release", "architectures": ["x86_64", "arm64"],
"triggers": [
"bigsur-applesilicon-release-tests-test262" ,"bigsur-release-tests-test262", "bigsur-release-tests-wk1", "bigsur-release-tests-wk2",
- "bigsur-release-applesilicon-tests-wk1", "bigsur-release-applesilicon-tests-wk2", "bigsur-applesilicon-release-tests-jsc", "bigsur-release-tests-wk2-webgl"
+ "bigsur-release-applesilicon-tests-wk1", "bigsur-release-applesilicon-tests-wk2", "bigsur-applesilicon-release-tests-jsc", "bigsur-release-tests-wk2-webgl-gpuprocess"
],
"workernames": ["bot121", "bot124"]
},
@@ -168,9 +168,9 @@
"additionalArguments": ["--no-retry-failures"],
"workernames": ["bot1022", "bot1023"]
},
-{ "name": "Apple-BigSur-Release-WK2-WebGL-Tests", "factory": "TestAllButJSCFactory", "builddir": "bigsur-release-tests-wk2-webgl",
+{ "name": "Apple-BigSur-Release-WK2-WebGL-GPUProcess-Tests", "factory": "TestAllButJSCFactory", "builddir": "bigsur-release-tests-wk2-webgl-gpuprocess",
"platform": "mac-bigsur", "configuration": "release", "architectures": ["x86_64", "arm64"],
- "additionalArguments": ["--no-retry-failures", "--webgl-test-suite"],
+ "additionalArguments": ["--no-retry-failures", "--webgl-test-suite", "--use-gpu-process"],
"workernames": ["bot302"]
},
{ "name": "Apple-BigSur-Debug-Build", "factory": "BuildFactory", "builddir": "bigsur-debug",
@@ -592,8 +592,8 @@
{ "type": "Triggerable", "name": "bigsur-release-applesilicon-tests-wk2",
"builderNames": ["Apple-BigSur-Release-AppleSilicon-WK2-Tests"]
},
-{ "type": "Triggerable", "name": "bigsur-release-tests-wk2-webgl",
- "builderNames": ["Apple-BigSur-Release-WK2-WebGL-Tests"]
+{ "type": "Triggerable", "name": "bigsur-release-tests-wk2-webgl-gpuprocess",
+ "builderNames": ["Apple-BigSur-Release-WK2-WebGL-GPUProcess-Tests"]
},
{ "type": "Triggerable", "name": "bigsur-debug-tests-wk1",
"builderNames": ["Apple-BigSur-Debug-WK1-Tests"]
Modified: trunk/Tools/CISupport/build-webkit-org/factories_unittest.py (284656 => 284657)
--- trunk/Tools/CISupport/build-webkit-org/factories_unittest.py 2021-10-22 00:09:34 UTC (rev 284656)
+++ trunk/Tools/CISupport/build-webkit-org/factories_unittest.py 2021-10-22 00:10:09 UTC (rev 284657)
@@ -168,7 +168,7 @@
'builtins-generator-tests',
'trigger-crash-log-submission'
],
-'Apple-BigSur-Release-WK2-WebGL-Tests': [
+'Apple-BigSur-Release-WK2-WebGL-GPUProcess-Tests': [
'configure-build',
'configuration',
'clean-and-update-working-directory',
Modified: trunk/Tools/ChangeLog (284656 => 284657)
--- trunk/Tools/ChangeLog 2021-10-22 00:09:34 UTC (rev 284656)
+++ trunk/Tools/ChangeLog 2021-10-22 00:10:09 UTC (rev 284657)
@@ -1,3 +1,13 @@
+2021-10-21 Ryan Haddad
+
+WebGL bot should run tests with GPU Process enabled
+https://bugs.webkit.org/show_bug.cgi?id=232107
+
+Reviewed by Jonathan Bedard.
+
+* CISupport/build-webkit-org/config.json:
+* CISupport/build-webkit-org/factories_unittest.py:
+
2021-10-21 Simon Fraser
Content offset in this codepen when switching tabs
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [284655] trunk/Source/WebCore
Title: [284655] trunk/Source/WebCore
Revision 284655
Author simon.fra...@apple.com
Date 2021-10-21 17:08:14 -0700 (Thu, 21 Oct 2021)
Log Message
REGRESSION (r275641): [ iPad Debug ] accessibility/ios-simulator/scroll-in-overflow-div.html is asserting
https://bugs.webkit.org/show_bug.cgi?id=228622
Reviewed by Alan Bujtas.
The test was hitting ASSERT(!m_visibleContentStatusDirty). It seems harmless to clear
repaint rects when m_visibleContentStatusDirty is true.
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::clearRepaintRects):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderLayer.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (284654 => 284655)
--- trunk/Source/WebCore/ChangeLog 2021-10-21 23:58:35 UTC (rev 284654)
+++ trunk/Source/WebCore/ChangeLog 2021-10-22 00:08:14 UTC (rev 284655)
@@ -1,5 +1,18 @@
2021-10-21 Simon Fraser
+REGRESSION (r275641): [ iPad Debug ] accessibility/ios-simulator/scroll-in-overflow-div.html is asserting
+https://bugs.webkit.org/show_bug.cgi?id=228622
+
+Reviewed by Alan Bujtas.
+
+The test was hitting ASSERT(!m_visibleContentStatusDirty). It seems harmless to clear
+repaint rects when m_visibleContentStatusDirty is true.
+
+* rendering/RenderLayer.cpp:
+(WebCore::RenderLayer::clearRepaintRects):
+
+2021-10-21 Simon Fraser
+
Content offset in this codepen when switching tabs
https://bugs.webkit.org/show_bug.cgi?id=231989
Modified: trunk/Source/WebCore/rendering/RenderLayer.cpp (284654 => 284655)
--- trunk/Source/WebCore/rendering/RenderLayer.cpp 2021-10-21 23:58:35 UTC (rev 284654)
+++ trunk/Source/WebCore/rendering/RenderLayer.cpp 2021-10-22 00:08:14 UTC (rev 284655)
@@ -1139,7 +1139,6 @@
void RenderLayer::clearRepaintRects()
{
-ASSERT(!m_visibleContentStatusDirty);
m_repaintRectsValid = false;
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [284654] trunk
Title: [284654] trunk Revision 284654 Author simon.fra...@apple.com Date 2021-10-21 16:58:35 -0700 (Thu, 21 Oct 2021) Log Message Content offset in this codepen when switching tabs https://bugs.webkit.org/show_bug.cgi?id=231989 Reviewed by Tim Horton. Source/WebCore: There were two problems that occurred with async-scrollable iframes when their associated WKWebView was removed and re-added to the view hierarchy (e.g. when switching tabs). These resulted in misplaced position:fixed content, and the first user scroll in the iframe causing the scroll position to jump back to the top. The positon:fixed issue was caused by an ordering problem in ScrollingTreeFrameScrollingNode::commitStateBeforeChildren() which resulted in the layout viewport being computed incorrectly; we called updateViewportForCurrentScrollPosition() before setting the min and max scroll position, so we'd always clamp the layout viewport to a location of 0,0. The second scroll position reset issue was caused by the ScrollingTreeScrollingNode's m_currentScrollPosition reverting to a stale after re-attaching the iframe's scrolling subtree. ScrollingTreeScrollingNode::commitStateBeforeChildren() has code to set m_currentScrollPosition from the state tree node's scroll position on first commit; the issue was that ScrollingStateScrollingNode's scrollPosition() was not updated on every scroll, only when something triggered a scrolling tree commit. Fix by silently updating ScrollingStateScrollingNode's scrollPosition() when we get notifications back from the scrolling thread that a scroll happened. Both fixes are tested by the ScrollingCoordinatorTests.ScrollingTreeAfterDetachReattach API test. * page/scrolling/AsyncScrollingCoordinator.cpp: (WebCore::AsyncScrollingCoordinator::updateScrollPositionAfterAsyncScroll): * page/scrolling/ScrollingStateScrollingNode.cpp: (WebCore::ScrollingStateScrollingNode::syncScrollPosition): (WebCore::ScrollingStateScrollingNode::hasScrollPositionRequest const): * page/scrolling/ScrollingStateScrollingNode.h: * page/scrolling/ScrollingStateTree.cpp: (WebCore::ScrollingStateTree::insertNode): * page/scrolling/ScrollingTreeFrameScrollingNode.cpp: (WebCore::ScrollingTreeFrameScrollingNode::commitStateBeforeChildren): We need to check state.hasScrollPositionRequest(), otherwise the "cancel animated scroll request" that comes out of Page::stopKeyboardScrollAnimation() prevents scroll position restoration. * page/scrolling/ScrollingTreeScrollingNode.cpp: (WebCore::ScrollingTreeScrollingNode::commitStateBeforeChildren): (WebCore::ScrollingTreeScrollingNode::dumpProperties const): * page/scrolling/mac/ScrollingCoordinatorMac.mm: (WebCore::ScrollingCoordinatorMac::commitTreeStateIfNeeded): Tools: API test that scrolls an iframe via wheel events, then detached and re-attaches the view. The two wheel scrolls are necessary to exercise the "stale ScrollingStateScrollingNode scroll position" issue. The scrolling tree dumps validate the layout viewport part of the fix. Also correct some functions where the sense of 'isWaitingForJavaScript' was flipped. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: * TestWebKitAPI/Tests/mac/ScrollingCoordinatorTests.mm: Added. (TestWebKitAPI::synthesizeWheelEvents): (TestWebKitAPI::waitForScrollEventAndReturnScrollY): (TestWebKitAPI::scrollingTreeElidingLastCommittedScrollPosition): (TestWebKitAPI::TEST): * TestWebKitAPI/cocoa/TestWKWebView.mm: (-[WKWebView objectByEvaluatingJavaScript:]): (-[WKWebView objectByEvaluatingJavaScriptWithUserGesture:]): (-[WKWebView objectByCallingAsyncFunction:withArguments:error:]): LayoutTests: New baselines. * tiled-drawing/scrolling/clamp-out-of-bounds-scrolls-expected.txt: * tiled-drawing/scrolling/scrolling-tree-after-scroll-expected.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/tiled-drawing/scrolling/clamp-out-of-bounds-scrolls-expected.txt trunk/LayoutTests/tiled-drawing/scrolling/scrolling-tree-after-scroll-expected.txt trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/page/scrolling/AsyncScrollingCoordinator.cpp trunk/Source/WebCore/page/scrolling/ScrollingStateScrollingNode.cpp trunk/Source/WebCore/page/scrolling/ScrollingStateScrollingNode.h trunk/Source/WebCore/page/scrolling/ScrollingStateTree.cpp trunk/Source/WebCore/page/scrolling/ScrollingTreeFrameScrollingNode.cpp trunk/Source/WebCore/page/scrolling/ScrollingTreeScrollingNode.cpp trunk/Source/WebCore/page/scrolling/mac/ScrollingCoordinatorMac.mm trunk/Tools/ChangeLog trunk/Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj trunk/Tools/TestWebKitAPI/cocoa/TestWKWebView.h trunk/Tools/TestWebKitAPI/cocoa/TestWKWebView.mm Added Paths trunk/Tools/TestWebKitAPI/Tests/mac/ScrollingCoordinatorTests.mm Diff Modified: trunk/LayoutTests/ChangeLog (284653 => 284654) --- trunk/LayoutTests/ChangeLog 2021-10-21 23:46:00 UTC (rev 284653) +++ trunk/LayoutTests/ChangeLog 2021-10-21 23:58:35 UTC (rev 284654) @@ -1,3 +1,15 @@ +2021-10-21
[webkit-changes] [284653] trunk/LayoutTests
Title: [284653] trunk/LayoutTests Revision 284653 Author wilan...@apple.com Date 2021-10-21 16:46:00 -0700 (Thu, 21 Oct 2021) Log Message PCM: Change expectation to pass so we can investigate http/tests/privateClickMeasurement/attribution-conversion-through-image-redirect-in-new-window.html https://bugs.webkit.org/show_bug.cgi?id=232115 Unreviewed test gardening. * platform/ios-wk2/TestExpectations: Removed expectation added in https://trac.webkit.org/changeset/284572/webkit. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/ios-wk2/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (284652 => 284653) --- trunk/LayoutTests/ChangeLog 2021-10-21 23:13:02 UTC (rev 284652) +++ trunk/LayoutTests/ChangeLog 2021-10-21 23:46:00 UTC (rev 284653) @@ -1,3 +1,13 @@ +2021-10-21 John Wilander + +PCM: Change expectation to pass so we can investigate http/tests/privateClickMeasurement/attribution-conversion-through-image-redirect-in-new-window.html +https://bugs.webkit.org/show_bug.cgi?id=232115 + +Unreviewed test gardening. + +* platform/ios-wk2/TestExpectations: +Removed expectation added in https://trac.webkit.org/changeset/284572/webkit. + 2021-10-21 Sihui Liu FileSystemSyncAccessHandle should close platform file handle on close() Modified: trunk/LayoutTests/platform/ios-wk2/TestExpectations (284652 => 284653) --- trunk/LayoutTests/platform/ios-wk2/TestExpectations 2021-10-21 23:13:02 UTC (rev 284652) +++ trunk/LayoutTests/platform/ios-wk2/TestExpectations 2021-10-21 23:46:00 UTC (rev 284653) @@ -2230,8 +2230,6 @@ webkit.org/b/231780 [ Debug ] imported/w3c/web-platform-tests/webrtc/simulcast/basic.https.html [ Pass Failure ] -webkit.org/b/232048 http/tests/privateClickMeasurement/attribution-conversion-through-image-redirect-in-new-window.html [ Pass Crash ] - webkit.org/b/232099 imported/w3c/web-platform-tests/websockets/Close-1000.any.html [ Pass Crash ] webkit.org/b/232102 http/tests/privateClickMeasurement/attribution-conversion-through-image-redirect-with-priority.html [ Pass Crash ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [284652] trunk
Title: [284652] trunk Revision 284652 Author sihui_...@apple.com Date 2021-10-21 16:13:02 -0700 (Thu, 21 Oct 2021) Log Message FileSystemSyncAccessHandle should close platform file handle on close() https://bugs.webkit.org/show_bug.cgi?id=232067 Reviewed by Youenn Fablet. LayoutTests/imported/w3c: * web-platform-tests/file-system-access/sandboxed_FileSystemSyncAccessHandle-close.https.tentative.worker-expected.txt: Source/WebCore: This patch also ensures no request is sent after close() is called. Test: storage/filesystemaccess/sync-access-handle-close-worker.html * Modules/filesystemaccess/FileSystemFileHandle.cpp: (WebCore::FileSystemFileHandle::createSyncAccessHandle): * Modules/filesystemaccess/FileSystemSyncAccessHandle.cpp: (WebCore::FileSystemSyncAccessHandle::FileSystemSyncAccessHandle): (WebCore::FileSystemSyncAccessHandle::~FileSystemSyncAccessHandle): (WebCore::FileSystemSyncAccessHandle::isClosingOrClosed const): (WebCore::FileSystemSyncAccessHandle::truncate): (WebCore::FileSystemSyncAccessHandle::getSize): (WebCore::FileSystemSyncAccessHandle::flush): (WebCore::FileSystemSyncAccessHandle::close): (WebCore::FileSystemSyncAccessHandle::didClose): (WebCore::FileSystemSyncAccessHandle::read): (WebCore::FileSystemSyncAccessHandle::write): * Modules/filesystemaccess/FileSystemSyncAccessHandle.h: LayoutTests: * storage/filesystemaccess/resources/sync-access-handle-close.js: Added. (finishTest): (async testFunctions): (async test): * storage/filesystemaccess/sync-access-handle-close-worker-expected.txt: Added. * storage/filesystemaccess/sync-access-handle-close-worker.html: Added. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/imported/w3c/ChangeLog trunk/LayoutTests/imported/w3c/web-platform-tests/file-system-access/sandboxed_FileSystemSyncAccessHandle-close.https.tentative.worker-expected.txt trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/Modules/filesystemaccess/FileSystemFileHandle.cpp trunk/Source/WebCore/Modules/filesystemaccess/FileSystemSyncAccessHandle.cpp trunk/Source/WebCore/Modules/filesystemaccess/FileSystemSyncAccessHandle.h Added Paths trunk/LayoutTests/storage/filesystemaccess/resources/sync-access-handle-close.js trunk/LayoutTests/storage/filesystemaccess/sync-access-handle-close-worker-expected.txt trunk/LayoutTests/storage/filesystemaccess/sync-access-handle-close-worker.html Diff Modified: trunk/LayoutTests/ChangeLog (284651 => 284652) --- trunk/LayoutTests/ChangeLog 2021-10-21 22:45:19 UTC (rev 284651) +++ trunk/LayoutTests/ChangeLog 2021-10-21 23:13:02 UTC (rev 284652) @@ -1,3 +1,18 @@ +2021-10-21 Sihui Liu + +FileSystemSyncAccessHandle should close platform file handle on close() +https://bugs.webkit.org/show_bug.cgi?id=232067 + + +Reviewed by Youenn Fablet. + +* storage/filesystemaccess/resources/sync-access-handle-close.js: Added. +(finishTest): +(async testFunctions): +(async test): +* storage/filesystemaccess/sync-access-handle-close-worker-expected.txt: Added. +* storage/filesystemaccess/sync-access-handle-close-worker.html: Added. + 2021-10-21 Ayumi Kojima [ iOS ] http/wpt/service-workers/skipFetchEvent.https.html is a flaky failure. Modified: trunk/LayoutTests/imported/w3c/ChangeLog (284651 => 284652) --- trunk/LayoutTests/imported/w3c/ChangeLog 2021-10-21 22:45:19 UTC (rev 284651) +++ trunk/LayoutTests/imported/w3c/ChangeLog 2021-10-21 23:13:02 UTC (rev 284652) @@ -1,3 +1,13 @@ +2021-10-21 Sihui Liu + +FileSystemSyncAccessHandle should close platform file handle on close() +https://bugs.webkit.org/show_bug.cgi?id=232067 + + +Reviewed by Youenn Fablet. + +* web-platform-tests/file-system-access/sandboxed_FileSystemSyncAccessHandle-close.https.tentative.worker-expected.txt: + 2021-10-21 Rob Buis [css-contain] Support contain:style for counters Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/file-system-access/sandboxed_FileSystemSyncAccessHandle-close.https.tentative.worker-expected.txt (284651 => 284652) --- trunk/LayoutTests/imported/w3c/web-platform-tests/file-system-access/sandboxed_FileSystemSyncAccessHandle-close.https.tentative.worker-expected.txt 2021-10-21 22:45:19 UTC (rev 284651) +++ trunk/LayoutTests/imported/w3c/web-platform-tests/file-system-access/sandboxed_FileSystemSyncAccessHandle-close.https.tentative.worker-expected.txt 2021-10-21 23:13:02 UTC (rev 284652) @@ -1,14 +1,14 @@ -FAIL SyncAccessHandle.close is idempotent promise_test: Unhandled rejection with value: object "InvalidStateError: The object is in an invalid state." -FAIL SyncAccessHandle.close is idempotent when called immediately promise_test: Unhandled rejection with value: object "UnknownError: The operation failed for an unknown transient reason (e.g. out of memory)." -FAIL SyncAccessHandle.read fails after SyncAccessHandle.close settles promise_test: Unhandled
[webkit-changes] [284651] trunk/Source/WebKit
Title: [284651] trunk/Source/WebKit
Revision 284651
Author cdu...@apple.com
Date 2021-10-21 15:45:19 -0700 (Thu, 21 Oct 2021)
Log Message
Call to [NSURL URLByAppendingPathComponent:] under NetworkSessionCocoa() may be inefficient
https://bugs.webkit.org/show_bug.cgi?id=232098
Reviewed by Alex Christensen.
Call [NSURL URLByAppendingPathComponent:isDirectory:] whenever possible instead of
[NSURL URLByAppendingPathComponent], as it is more efficient.
* NetworkProcess/cocoa/NetworkSessionCocoa.mm:
(WebKit::NetworkSessionCocoa::NetworkSessionCocoa):
* UIProcess/Cocoa/WKShareSheet.mm:
(+[WKShareSheet createRandomSharingDirectoryForFile:]):
(+[WKShareSheet writeFileToShareableURL:data:temporaryDirectory:]):
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm
trunk/Source/WebKit/UIProcess/Cocoa/WKShareSheet.mm
Diff
Modified: trunk/Source/WebKit/ChangeLog (284650 => 284651)
--- trunk/Source/WebKit/ChangeLog 2021-10-21 22:35:59 UTC (rev 284650)
+++ trunk/Source/WebKit/ChangeLog 2021-10-21 22:45:19 UTC (rev 284651)
@@ -1,3 +1,19 @@
+2021-10-21 Chris Dumez
+
+Call to [NSURL URLByAppendingPathComponent:] under NetworkSessionCocoa() may be inefficient
+https://bugs.webkit.org/show_bug.cgi?id=232098
+
+Reviewed by Alex Christensen.
+
+Call [NSURL URLByAppendingPathComponent:isDirectory:] whenever possible instead of
+[NSURL URLByAppendingPathComponent], as it is more efficient.
+
+* NetworkProcess/cocoa/NetworkSessionCocoa.mm:
+(WebKit::NetworkSessionCocoa::NetworkSessionCocoa):
+* UIProcess/Cocoa/WKShareSheet.mm:
+(+[WKShareSheet createRandomSharingDirectoryForFile:]):
+(+[WKShareSheet writeFileToShareableURL:data:temporaryDirectory:]):
+
2021-10-21 John Wilander
PCM: Add temporary logging when isRunningTest() assertion is about to fail to be able to investigate
Modified: trunk/Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm (284650 => 284651)
--- trunk/Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm 2021-10-21 22:35:59 UTC (rev 284650)
+++ trunk/Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm 2021-10-21 22:45:19 UTC (rev 284651)
@@ -1282,7 +1282,7 @@
#if HAVE(CFNETWORK_ALTERNATIVE_SERVICE)
if (!parameters.alternativeServiceDirectory.isEmpty()) {
SandboxExtension::consumePermanently(parameters.alternativeServiceDirectoryExtensionHandle);
-configuration._alternativeServicesStorage = adoptNS([[_NSHTTPAlternativeServicesStorage alloc] initPersistentStoreWithURL:[[NSURL fileURLWithPath:parameters.alternativeServiceDirectory isDirectory:YES] URLByAppendingPathComponent:@"AlternativeService.sqlite"]]).get();
+configuration._alternativeServicesStorage = adoptNS([[_NSHTTPAlternativeServicesStorage alloc] initPersistentStoreWithURL:[[NSURL fileURLWithPath:parameters.alternativeServiceDirectory isDirectory:YES] URLByAppendingPathComponent:@"AlternativeService.sqlite" isDirectory:NO]]).get();
}
if (parameters.http3Enabled)
configuration._allowsHTTP3 = YES;
Modified: trunk/Source/WebKit/UIProcess/Cocoa/WKShareSheet.mm (284650 => 284651)
--- trunk/Source/WebKit/UIProcess/Cocoa/WKShareSheet.mm 2021-10-21 22:35:59 UTC (rev 284650)
+++ trunk/Source/WebKit/UIProcess/Cocoa/WKShareSheet.mm 2021-10-21 22:45:19 UTC (rev 284651)
@@ -329,7 +329,7 @@
NSString *randomDirectory = createCanonicalUUIDString();
if (![randomDirectory length] || !temporaryDirectory)
return nil;
-NSURL *dataPath = [temporaryDirectory URLByAppendingPathComponent:randomDirectory];
+NSURL *dataPath = [temporaryDirectory URLByAppendingPathComponent:randomDirectory isDirectory:YES];
if (![[NSFileManager defaultManager] createDirectoryAtURL:dataPath withIntermediateDirectories:NO attributes:nil error:nil])
return nil;
@@ -346,7 +346,7 @@
if (!temporaryDirectoryForFile)
return nil;
-NSURL *fileURL = [temporaryDirectoryForFile URLByAppendingPathComponent:fileName];
+NSURL *fileURL = [temporaryDirectoryForFile URLByAppendingPathComponent:fileName isDirectory:NO];
if (![fileData writeToURL:fileURL options:NSDataWritingAtomic error:nil])
return nil;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [284650] trunk/Source/WebCore
Title: [284650] trunk/Source/WebCore
Revision 284650
Author d...@apple.com
Date 2021-10-21 15:35:59 -0700 (Thu, 21 Oct 2021)
Log Message
[WebXR] WebXR on Cocoa doesn't work with multisampled contexts
https://bugs.webkit.org/show_bug.cgi?id=226687
Reviewed by Tim Horton.
If the WebXR session requested an anti-aliased context, we'd
end up with an incomplete framebuffer because we were never
initialising the multisample buffers. This would assert on
debug builds and produce no output on release builds.
Fix this by initialising the multisample buffers, ensuring
we're targeting them in startFrame, and do the resolution
in endFrame.
* Modules/webxr/WebXROpaqueFramebuffer.cpp:
(WebCore::WebXROpaqueFramebuffer::startFrame):
(WebCore::WebXROpaqueFramebuffer::endFrame): While here, use NEAREST
sampling on the multisample resolution, the way we do in WebGL.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/webxr/WebXROpaqueFramebuffer.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (284649 => 284650)
--- trunk/Source/WebCore/ChangeLog 2021-10-21 22:28:30 UTC (rev 284649)
+++ trunk/Source/WebCore/ChangeLog 2021-10-21 22:35:59 UTC (rev 284650)
@@ -1,3 +1,25 @@
+2021-10-21 Dean Jackson
+
+[WebXR] WebXR on Cocoa doesn't work with multisampled contexts
+https://bugs.webkit.org/show_bug.cgi?id=226687
+
+
+Reviewed by Tim Horton.
+
+If the WebXR session requested an anti-aliased context, we'd
+end up with an incomplete framebuffer because we were never
+initialising the multisample buffers. This would assert on
+debug builds and produce no output on release builds.
+
+Fix this by initialising the multisample buffers, ensuring
+we're targeting them in startFrame, and do the resolution
+in endFrame.
+
+* Modules/webxr/WebXROpaqueFramebuffer.cpp:
+(WebCore::WebXROpaqueFramebuffer::startFrame):
+(WebCore::WebXROpaqueFramebuffer::endFrame): While here, use NEAREST
+sampling on the multisample resolution, the way we do in WebGL.
+
2021-10-21 Rob Buis
[css-contain] Support contain:style for counters
Modified: trunk/Source/WebCore/Modules/webxr/WebXROpaqueFramebuffer.cpp (284649 => 284650)
--- trunk/Source/WebCore/Modules/webxr/WebXROpaqueFramebuffer.cpp 2021-10-21 22:28:30 UTC (rev 284649)
+++ trunk/Source/WebCore/Modules/webxr/WebXROpaqueFramebuffer.cpp 2021-10-21 22:35:59 UTC (rev 284650)
@@ -125,7 +125,6 @@
auto gCGL = static_cast(m_context.graphicsContextGL());
GCGLenum textureTarget = gCGL->drawingBufferTextureTarget();
-
if (!m_opaqueTexture)
m_opaqueTexture = gCGL->createTexture();
@@ -157,14 +156,15 @@
return;
}
-// Now set up the framebuffer to use the texture that points to the IOSurface. The depth and
-// stencil buffers were attached by startFrame.
-gl.framebufferTexture2D(GL::FRAMEBUFFER, GL::COLOR_ATTACHMENT0, GL::TEXTURE_2D, m_opaqueTexture, 0);
+// If we're not multisampling, set up the framebuffer to use the texture that points to the IOSurface. The depth and
+// stencil buffers were attached by setupFramebuffer. If we are multisampling, the framebuffer was initialized in setupFramebuffer,
+// and we'll resolve into the m_opaqueTexture in endFrame.
+if (!m_multisampleColorBuffer)
+gl.framebufferTexture2D(GL::FRAMEBUFFER, GL::COLOR_ATTACHMENT0, GL::TEXTURE_2D, m_opaqueTexture, 0);
-// FIXME: This is assuming multisampling is turned off and we're rendering directly into the framebuffer.
-
// At this point the framebuffer should be "complete".
ASSERT(gl.checkFramebufferStatus(GL::FRAMEBUFFER) == GL::FRAMEBUFFER_COMPLETE);
+
#else
m_opaqueTexture = data.opaqueTexture;
@@ -190,28 +190,6 @@
auto& gl = *m_context.graphicsContextGL();
-#if USE(IOSURFACE_FOR_XR_LAYER_DATA)
-// FIXME: We have to call finish rather than flush because we only want to disconnect
-// the IOSurface and signal the DeviceProxy when we know the content has been rendered.
-// It might be possible to set this up so the completion of the rendering triggers
-// the endFrame call.
-gl.finish();
-
-if (m_ioSurfaceTextureHandle) {
-auto gCGL = static_cast();
-if (m_ioSurfaceTextureHandleIsShared) {
-#if !PLATFORM(IOS_FAMILY_SIMULATOR)
-gCGL->detachIOSurfaceFromSharedTexture(m_ioSurfaceTextureHandle);
-#else
-ASSERT_NOT_REACHED();
-#endif
-} else
-gCGL->destroyPbufferAndDetachIOSurface(m_ioSurfaceTextureHandle);
-m_ioSurfaceTextureHandle = nullptr;
-m_ioSurfaceTextureHandleIsShared = false;
-}
-#else
-
if (m_multisampleColorBuffer) {
#if !USE(ANGLE)
// FIXME: These may be needed when using ANGLE, but it didn't compile in the initial implementation.
@@ -234,13 +212,31 @@
gl.bindFramebuffer(GL::DRAW_FRAMEBUFFER, m_resolvedFBO);
[webkit-changes] [284649] trunk/Source/WebKit
Title: [284649] trunk/Source/WebKit
Revision 284649
Author wilan...@apple.com
Date 2021-10-21 15:28:30 -0700 (Thu, 21 Oct 2021)
Log Message
PCM: Add temporary logging when isRunningTest() assertion is about to fail to be able to investigate
https://bugs.webkit.org/show_bug.cgi?id=232108
Unreviewed. Just adding logging for test-only functionality.
This patch adds logging to when we are about to fail the assert of isRunningTest() in
WebKit::NetworkSession::setPrivateClickMeasurementAppBundleIDForTesting)(). This is
added to help investigate https://bugs.webkit.org/show_bug.cgi?id=232048.
* NetworkProcess/NetworkSession.cpp:
(WebKit::NetworkSession::setPrivateClickMeasurementAppBundleIDForTesting):
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/NetworkProcess/NetworkSession.cpp
Diff
Modified: trunk/Source/WebKit/ChangeLog (284648 => 284649)
--- trunk/Source/WebKit/ChangeLog 2021-10-21 21:49:28 UTC (rev 284648)
+++ trunk/Source/WebKit/ChangeLog 2021-10-21 22:28:30 UTC (rev 284649)
@@ -1,3 +1,17 @@
+2021-10-21 John Wilander
+
+PCM: Add temporary logging when isRunningTest() assertion is about to fail to be able to investigate
+https://bugs.webkit.org/show_bug.cgi?id=232108
+
+Unreviewed. Just adding logging for test-only functionality.
+
+This patch adds logging to when we are about to fail the assert of isRunningTest() in
+WebKit::NetworkSession::setPrivateClickMeasurementAppBundleIDForTesting)(). This is
+added to help investigate https://bugs.webkit.org/show_bug.cgi?id=232048.
+
+* NetworkProcess/NetworkSession.cpp:
+(WebKit::NetworkSession::setPrivateClickMeasurementAppBundleIDForTesting):
+
2021-10-21 Simon Fraser
Rare crash under DisplayLink::displayLinkCallback()
Modified: trunk/Source/WebKit/NetworkProcess/NetworkSession.cpp (284648 => 284649)
--- trunk/Source/WebKit/NetworkProcess/NetworkSession.cpp 2021-10-21 21:49:28 UTC (rev 284648)
+++ trunk/Source/WebKit/NetworkProcess/NetworkSession.cpp 2021-10-21 22:28:30 UTC (rev 284649)
@@ -455,6 +455,10 @@
void NetworkSession::setPrivateClickMeasurementAppBundleIDForTesting(String&& appBundleIDForTesting)
{
#if PLATFORM(COCOA)
+// FIXME: Remove this logging once https://bugs.webkit.org/show_bug.cgi?id=232048 has been resolved.
+auto appBundleID = WebCore::applicationBundleIdentifier();
+if (!isRunningTest(appBundleID))
+WTFLogAlways("isRunningTest() returned false. appBundleID is %s.", appBundleID.isEmpty() ? "empty" : appBundleID.utf8().data());
RELEASE_ASSERT(isRunningTest(WebCore::applicationBundleIdentifier()));
#endif
privateClickMeasurement().setPrivateClickMeasurementAppBundleIDForTesting(WTFMove(appBundleIDForTesting));
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [284648] trunk/LayoutTests
Title: [284648] trunk/LayoutTests Revision 284648 Author ayumi_koj...@apple.com Date 2021-10-21 14:49:28 -0700 (Thu, 21 Oct 2021) Log Message [ iOS ] http/wpt/service-workers/skipFetchEvent.https.html is a flaky failure. https://bugs.webkit.org/show_bug.cgi?id=230374 Unreviewed test gardening. * platform/ios-wk2/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/ios-wk2/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (284647 => 284648) --- trunk/LayoutTests/ChangeLog 2021-10-21 21:43:29 UTC (rev 284647) +++ trunk/LayoutTests/ChangeLog 2021-10-21 21:49:28 UTC (rev 284648) @@ -1,5 +1,14 @@ 2021-10-21 Ayumi Kojima +[ iOS ] http/wpt/service-workers/skipFetchEvent.https.html is a flaky failure. +https://bugs.webkit.org/show_bug.cgi?id=230374 + +Unreviewed test gardening. + +* platform/ios-wk2/TestExpectations: + +2021-10-21 Ayumi Kojima + REGRESSION: [iOS] ASSERTION FAILED: !m_messageReceiverMapCount under WebKit::RemoteAudioHardwareListener::~RemoteAudioHardwareListener(). https://bugs.webkit.org/show_bug.cgi?id=228038 Modified: trunk/LayoutTests/platform/ios-wk2/TestExpectations (284647 => 284648) --- trunk/LayoutTests/platform/ios-wk2/TestExpectations 2021-10-21 21:43:29 UTC (rev 284647) +++ trunk/LayoutTests/platform/ios-wk2/TestExpectations 2021-10-21 21:49:28 UTC (rev 284648) @@ -1463,8 +1463,6 @@ webkit.org/b/208576 [ Debug ] fast/forms/textarea-scrolled-type.html [ Failure ] -webkit.org/b/230374 http/wpt/service-workers/skipFetchEvent.https.html [ Pass Failure ] - webkit.org/b/208582 http/wpt/service-workers/server-trust-evaluation.https.html [ Pass Failure ] webkit.org/b/206934 imported/w3c/web-platform-tests/IndexedDB/key-generators/reading-autoincrement-indexes-cursors.any.serviceworker.html [ Pass Failure ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [284647] trunk/LayoutTests
Title: [284647] trunk/LayoutTests Revision 284647 Author ayumi_koj...@apple.com Date 2021-10-21 14:43:29 -0700 (Thu, 21 Oct 2021) Log Message REGRESSION: [iOS] ASSERTION FAILED: !m_messageReceiverMapCount under WebKit::RemoteAudioHardwareListener::~RemoteAudioHardwareListener(). https://bugs.webkit.org/show_bug.cgi?id=228038 Unreviewed test gardening. * platform/ios-wk2/TestExpectations: Removed test expectations. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/ios-wk2/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (284646 => 284647) --- trunk/LayoutTests/ChangeLog 2021-10-21 21:40:33 UTC (rev 284646) +++ trunk/LayoutTests/ChangeLog 2021-10-21 21:43:29 UTC (rev 284647) @@ -1,5 +1,14 @@ 2021-10-21 Ayumi Kojima +REGRESSION: [iOS] ASSERTION FAILED: !m_messageReceiverMapCount under WebKit::RemoteAudioHardwareListener::~RemoteAudioHardwareListener(). +https://bugs.webkit.org/show_bug.cgi?id=228038 + +Unreviewed test gardening. + +* platform/ios-wk2/TestExpectations: Removed test expectations. + +2021-10-21 Ayumi Kojima + [ iOS ] media/modern-media-controls/media-documents/media-document-video-with-initial-audio-layout.html is a flaky timeout. https://bugs.webkit.org/show_bug.cgi?id=232106 Modified: trunk/LayoutTests/platform/ios-wk2/TestExpectations (284646 => 284647) --- trunk/LayoutTests/platform/ios-wk2/TestExpectations 2021-10-21 21:40:33 UTC (rev 284646) +++ trunk/LayoutTests/platform/ios-wk2/TestExpectations 2021-10-21 21:43:29 UTC (rev 284647) @@ -1475,12 +1475,7 @@ webkit.org/b/208590 [ Debug ] fast/events/beforeunload-prompt.html [ Pass Crash ] -webkit.org/b/228038 media/modern-media-controls/media-documents/media-document-video-with-initial-audio-layout.html [ Pass Timeout ] -webkit.org/b/228038 [ Debug ] media/non-existent-video-playback-interrupted.html [ Pass Crash ] -webkit.org/b/228038 [ Debug ] media/media-can-play-av1.html [ Pass Crash ] -webkit.org/b/228038 [ Debug ] media/modern-media-controls/mute-button/mute-button.html [ Pass Crash ] -webkit.org/b/228038 [ Debug ] fast/mediastream/audio-bad-sampleRate.html [ Pass Crash ] -webkit.org/b/228038 [ Debug ] media/media-blocked-by-willsendrequest.html [ Pass Crash ] +webkit.org/b/232106 media/modern-media-controls/media-documents/media-document-video-with-initial-audio-layout.html [ Pass Timeout ] webkit.org/b/231618 [ Release ] fast/mediastream/apply-constraints-video.html [ Pass Failure ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [284646] trunk/Source/JavaScriptCore
Title: [284646] trunk/Source/_javascript_Core
Revision 284646
Author ysuz...@apple.com
Date 2021-10-21 14:40:33 -0700 (Thu, 21 Oct 2021)
Log Message
[JSC] Make GetTypedArrayLengthAsInt52 and GetTypedArrayByteOffsetAsInt52 NodeResultInt52
https://bugs.webkit.org/show_bug.cgi?id=232100
Reviewed by Robin Morisset.
This patch makes GetTypedArrayLengthAsInt52 and GetTypedArrayByteOffsetAsInt52 have NodeResultInt52 by default.
And DFG validation should skip Int52 validation before fixup phase, as we are doing for double results.
* dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::fixupNode):
* dfg/DFGNodeType.h:
* dfg/DFGSSALoweringPhase.cpp:
(JSC::DFG::SSALoweringPhase::handleNode):
(JSC::DFG::SSALoweringPhase::lowerBoundsCheck):
* dfg/DFGValidate.cpp:
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/dfg/DFGFixupPhase.cpp
trunk/Source/_javascript_Core/dfg/DFGNodeType.h
trunk/Source/_javascript_Core/dfg/DFGSSALoweringPhase.cpp
trunk/Source/_javascript_Core/dfg/DFGValidate.cpp
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (284645 => 284646)
--- trunk/Source/_javascript_Core/ChangeLog 2021-10-21 21:40:13 UTC (rev 284645)
+++ trunk/Source/_javascript_Core/ChangeLog 2021-10-21 21:40:33 UTC (rev 284646)
@@ -1,5 +1,23 @@
2021-10-21 Yusuke Suzuki
+[JSC] Make GetTypedArrayLengthAsInt52 and GetTypedArrayByteOffsetAsInt52 NodeResultInt52
+https://bugs.webkit.org/show_bug.cgi?id=232100
+
+Reviewed by Robin Morisset.
+
+This patch makes GetTypedArrayLengthAsInt52 and GetTypedArrayByteOffsetAsInt52 have NodeResultInt52 by default.
+And DFG validation should skip Int52 validation before fixup phase, as we are doing for double results.
+
+* dfg/DFGFixupPhase.cpp:
+(JSC::DFG::FixupPhase::fixupNode):
+* dfg/DFGNodeType.h:
+* dfg/DFGSSALoweringPhase.cpp:
+(JSC::DFG::SSALoweringPhase::handleNode):
+(JSC::DFG::SSALoweringPhase::lowerBoundsCheck):
+* dfg/DFGValidate.cpp:
+
+2021-10-21 Yusuke Suzuki
+
[JSC] Inserted GetTypedArrayLengthAsInt52 for PutByVal should have NodeResultInt52
https://bugs.webkit.org/show_bug.cgi?id=232059
Modified: trunk/Source/_javascript_Core/dfg/DFGFixupPhase.cpp (284645 => 284646)
--- trunk/Source/_javascript_Core/dfg/DFGFixupPhase.cpp 2021-10-21 21:40:13 UTC (rev 284645)
+++ trunk/Source/_javascript_Core/dfg/DFGFixupPhase.cpp 2021-10-21 21:40:33 UTC (rev 284646)
@@ -2174,13 +2174,11 @@
blessArrayOperation(node->child1(), Edge(), node->child2(), lengthNeedsStorage);
fixEdge(node->child1());
-node->setResult(NodeResultInt52);
break;
}
case GetTypedArrayByteOffsetAsInt52: {
fixEdge(node->child1());
-node->setResult(NodeResultInt52);
break;
}
Modified: trunk/Source/_javascript_Core/dfg/DFGNodeType.h (284645 => 284646)
--- trunk/Source/_javascript_Core/dfg/DFGNodeType.h 2021-10-21 21:40:13 UTC (rev 284645)
+++ trunk/Source/_javascript_Core/dfg/DFGNodeType.h 2021-10-21 21:40:33 UTC (rev 284646)
@@ -262,11 +262,10 @@
macro(MultiDeleteByOffset, NodeMustGenerate | NodeResultJS) \
macro(GetArrayLength, NodeResultInt32) \
/* This is only relevant for TypedArrays, as they are the only ones that can have a length that does not fit in 32 bits. */ \
-/* GetTypedArrayLengthAsInt52 and GetTypedArrayByteOffsetAsInt52 change to returning Int52 in Fixup. Doing it before causes validation failures. */ \
-macro(GetTypedArrayLengthAsInt52, NodeResultJS) \
+macro(GetTypedArrayLengthAsInt52, NodeResultInt52) \
macro(GetVectorLength, NodeResultInt32) \
macro(GetTypedArrayByteOffset, NodeResultInt32) \
-macro(GetTypedArrayByteOffsetAsInt52, NodeResultJS) \
+macro(GetTypedArrayByteOffsetAsInt52, NodeResultInt52) \
macro(GetScope, NodeResultJS) \
macro(SkipScope, NodeResultJS) \
macro(ResolveScope, NodeResultJS | NodeMustGenerate) \
Modified: trunk/Source/_javascript_Core/dfg/DFGSSALoweringPhase.cpp (284645 => 284646)
--- trunk/Source/_javascript_Core/dfg/DFGSSALoweringPhase.cpp 2021-10-21 21:40:13 UTC (rev 284645)
+++ trunk/Source/_javascript_Core/dfg/DFGSSALoweringPhase.cpp 2021-10-21 21:40:33 UTC (rev 284646)
@@ -105,7 +105,6 @@
Node* length = m_insertionSet.insertNode(
m_nodeIndex, SpecInt52Any, GetTypedArrayLengthAsInt52, m_node->origin,
OpInfo(m_node->arrayMode().asWord()), base, storage);
-length->setResult(NodeResultInt52);
m_graph.varArgChild(m_node, 4) = Edge(length, Int52RepUse);
} else {
#endif
@@ -154,7 +153,6 @@
Node* length = m_insertionSet.insertNode(
m_nodeIndex, SpecInt52Any, GetTypedArrayLengthAsInt52, m_node->origin,
OpInfo(m_node->arrayMode().asWord()),
[webkit-changes] [284645] trunk/LayoutTests
Title: [284645] trunk/LayoutTests Revision 284645 Author ayumi_koj...@apple.com Date 2021-10-21 14:40:13 -0700 (Thu, 21 Oct 2021) Log Message [ iOS ] media/modern-media-controls/media-documents/media-document-video-with-initial-audio-layout.html is a flaky timeout. https://bugs.webkit.org/show_bug.cgi?id=232106 Unreviewed test gardening. * platform/ios-wk2/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/ios-wk2/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (284644 => 284645) --- trunk/LayoutTests/ChangeLog 2021-10-21 21:33:01 UTC (rev 284644) +++ trunk/LayoutTests/ChangeLog 2021-10-21 21:40:13 UTC (rev 284645) @@ -1,5 +1,14 @@ 2021-10-21 Ayumi Kojima +[ iOS ] media/modern-media-controls/media-documents/media-document-video-with-initial-audio-layout.html is a flaky timeout. +https://bugs.webkit.org/show_bug.cgi?id=232106 + +Unreviewed test gardening. + +* platform/ios-wk2/TestExpectations: + +2021-10-21 Ayumi Kojima + [ macOS wk2 ] imported/w3c/web-platform-tests/html/cross-origin-opener-policy/iframe-popup-same-origin-to-same-origin.https.html is a flaky failure/ crashing. https://bugs.webkit.org/show_bug.cgi?id=232105 Modified: trunk/LayoutTests/platform/ios-wk2/TestExpectations (284644 => 284645) --- trunk/LayoutTests/platform/ios-wk2/TestExpectations 2021-10-21 21:33:01 UTC (rev 284644) +++ trunk/LayoutTests/platform/ios-wk2/TestExpectations 2021-10-21 21:40:13 UTC (rev 284645) @@ -1475,7 +1475,7 @@ webkit.org/b/208590 [ Debug ] fast/events/beforeunload-prompt.html [ Pass Crash ] -webkit.org/b/228038 media/modern-media-controls/media-documents/media-document-video-with-initial-audio-layout.html [ Pass Crash ] +webkit.org/b/228038 media/modern-media-controls/media-documents/media-document-video-with-initial-audio-layout.html [ Pass Timeout ] webkit.org/b/228038 [ Debug ] media/non-existent-video-playback-interrupted.html [ Pass Crash ] webkit.org/b/228038 [ Debug ] media/media-can-play-av1.html [ Pass Crash ] webkit.org/b/228038 [ Debug ] media/modern-media-controls/mute-button/mute-button.html [ Pass Crash ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [284644] trunk/Source/WebKit
Title: [284644] trunk/Source/WebKit
Revision 284644
Author simon.fra...@apple.com
Date 2021-10-21 14:33:01 -0700 (Thu, 21 Oct 2021)
Log Message
Rare crash under DisplayLink::displayLinkCallback()
https://bugs.webkit.org/show_bug.cgi?id=232101
Reviewed by Tim Horton.
The crash was a divide by zero under m_currentUpdate.nextUpdate(), indicating that
m_currentUpdate.updatesPerSecond was zero. Previous assumptions that this was caused
by weird display configs were wrong. The actual issue is a race condition where
the callback can fire while we're still inside CVDisplayLinkStart(), or at least
before we've updated m_currentUpdate.
The fix is to initialize m_currentUpdate before we call CVDisplayLinkStart().
* UIProcess/mac/DisplayLink.cpp:
(WebKit::DisplayLink::addObserver):
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/mac/DisplayLink.cpp
Diff
Modified: trunk/Source/WebKit/ChangeLog (284643 => 284644)
--- trunk/Source/WebKit/ChangeLog 2021-10-21 21:22:09 UTC (rev 284643)
+++ trunk/Source/WebKit/ChangeLog 2021-10-21 21:33:01 UTC (rev 284644)
@@ -1,3 +1,22 @@
+2021-10-21 Simon Fraser
+
+Rare crash under DisplayLink::displayLinkCallback()
+https://bugs.webkit.org/show_bug.cgi?id=232101
+
+
+Reviewed by Tim Horton.
+
+The crash was a divide by zero under m_currentUpdate.nextUpdate(), indicating that
+m_currentUpdate.updatesPerSecond was zero. Previous assumptions that this was caused
+by weird display configs were wrong. The actual issue is a race condition where
+the callback can fire while we're still inside CVDisplayLinkStart(), or at least
+before we've updated m_currentUpdate.
+
+The fix is to initialize m_currentUpdate before we call CVDisplayLinkStart().
+
+* UIProcess/mac/DisplayLink.cpp:
+(WebKit::DisplayLink::addObserver):
+
2021-10-21 Per Arne Vollan
Launch Services database is not always sent to GPUP
Modified: trunk/Source/WebKit/UIProcess/mac/DisplayLink.cpp (284643 => 284644)
--- trunk/Source/WebKit/UIProcess/mac/DisplayLink.cpp 2021-10-21 21:22:09 UTC (rev 284643)
+++ trunk/Source/WebKit/UIProcess/mac/DisplayLink.cpp 2021-10-21 21:33:01 UTC (rev 284644)
@@ -101,16 +101,12 @@
if (!CVDisplayLinkIsRunning(m_displayLink)) {
LOG_WITH_STREAM(DisplayLink, stream << "[UI ] DisplayLink for display " << m_displayID << " starting CVDisplayLink with fps " << m_displayNominalFramesPerSecond);
+
+m_currentUpdate = { 0, m_displayNominalFramesPerSecond };
+
CVReturn error = CVDisplayLinkStart(m_displayLink);
if (error)
RELEASE_LOG_FAULT(DisplayLink, "DisplayLink: Could not start the display link: %d", error);
-
-if (!m_displayNominalFramesPerSecond) {
-RELEASE_LOG_FAULT(DisplayLink, "DisplayLink: displayNominalFramesPerSecond is 0, using %d", WebCore::FullSpeedFramesPerSecond);
-m_displayNominalFramesPerSecond = WebCore::FullSpeedFramesPerSecond;
-};
-
-m_currentUpdate = { 0, m_displayNominalFramesPerSecond };
}
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [284643] trunk/LayoutTests
Title: [284643] trunk/LayoutTests Revision 284643 Author ayumi_koj...@apple.com Date 2021-10-21 14:22:09 -0700 (Thu, 21 Oct 2021) Log Message [ macOS wk2 ] imported/w3c/web-platform-tests/html/cross-origin-opener-policy/iframe-popup-same-origin-to-same-origin.https.html is a flaky failure/ crashing. https://bugs.webkit.org/show_bug.cgi?id=232105 Unreviewed test gardening. * platform/mac-wk2/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/mac-wk2/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (284642 => 284643) --- trunk/LayoutTests/ChangeLog 2021-10-21 20:48:28 UTC (rev 284642) +++ trunk/LayoutTests/ChangeLog 2021-10-21 21:22:09 UTC (rev 284643) @@ -1,3 +1,12 @@ +2021-10-21 Ayumi Kojima + +[ macOS wk2 ] imported/w3c/web-platform-tests/html/cross-origin-opener-policy/iframe-popup-same-origin-to-same-origin.https.html is a flaky failure/ crashing. +https://bugs.webkit.org/show_bug.cgi?id=232105 + +Unreviewed test gardening. + +* platform/mac-wk2/TestExpectations: + 2021-10-21 Rob Buis [css-contain] Support contain:style for counters Modified: trunk/LayoutTests/platform/mac-wk2/TestExpectations (284642 => 284643) --- trunk/LayoutTests/platform/mac-wk2/TestExpectations 2021-10-21 20:48:28 UTC (rev 284642) +++ trunk/LayoutTests/platform/mac-wk2/TestExpectations 2021-10-21 21:22:09 UTC (rev 284643) @@ -1240,6 +1240,8 @@ webkit.org/b/232028 imported/w3c/web-platform-tests/html/cross-origin-opener-policy/reporting/navigation-reporting/report-only-four-reports.https.html [ Pass Failure ] +webkit.org/b/232105 imported/w3c/web-platform-tests/html/cross-origin-opener-policy/iframe-popup-same-origin-to-same-origin.https.html [ Pass Failure Crash ] + webkit.org/b/230113 [ BigSur+ Debug arm64 ] svg/animations/animate-elem-14-t-drt.html [ Pass Crash ] # rdar://66806059 (REGRESSION (20A2321a-20A2348b): 4 fast hidpi tests are a flaky image failure) ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [284642] trunk
Title: [284642] trunk Revision 284642 Author commit-qu...@webkit.org Date 2021-10-21 13:48:28 -0700 (Thu, 21 Oct 2021) Log Message [css-contain] Support contain:style for counters https://bugs.webkit.org/show_bug.cgi?id=226458 Patch by Rob Buis on 2021-10-21 Reviewed by Antti Koivisto. LayoutTests/imported/w3c: Update improved test results. * web-platform-tests/css/css-contain/content-visibility/content-visibility-026-expected.txt: * web-platform-tests/css/css-contain/parsing/contain-computed-expected.txt: * web-platform-tests/css/css-contain/parsing/contain-valid-expected.txt: Source/WebCore: Parse contain: style and use it (if set) to scope counter-increment to the element's sub-tree [1]. Tests: imported/w3c/web-platform-tests/css/css-contain/contain-style-counters-001.html imported/w3c/web-platform-tests/css/css-contain/contain-style-counters-002.html imported/w3c/web-platform-tests/css/css-contain/contain-style-counters-003.html imported/w3c/web-platform-tests/css/css-contain/contain-style-counters-004.html [1] https://drafts.csswg.org/css-contain-2/#containment-style * css/CSSComputedStyleDeclaration.cpp: (WebCore::ComputedStyleExtractor::valueForPropertyInStyle): * css/parser/CSSPropertyParser.cpp: (WebCore::consumeContain): * rendering/RenderCounter.cpp: (WebCore::ancestorStyleContainmentObject): (WebCore::previousInPreOrder): (WebCore::previousSiblingOrParentElement): (WebCore::makeCounterNode): (WebCore::RenderCounter::rendererSubtreeAttached): * rendering/RenderObject.cpp: (WebCore::shouldApplyStyleContainment): * rendering/RenderObject.h: * rendering/style/RenderStyle.h: (WebCore::RenderStyle::containsStyle const): * rendering/style/RenderStyleConstants.h: * style/StyleBuilderCustom.h: (WebCore::Style::BuilderCustom::applyValueContain): LayoutTests: Unskip tests that now pass. * TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/TestExpectations trunk/LayoutTests/imported/w3c/ChangeLog trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-contain/content-visibility/content-visibility-026-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-contain/parsing/contain-computed-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-contain/parsing/contain-valid-expected.txt trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/css/CSSComputedStyleDeclaration.cpp trunk/Source/WebCore/css/parser/CSSPropertyParser.cpp trunk/Source/WebCore/rendering/RenderCounter.cpp trunk/Source/WebCore/rendering/RenderObject.cpp trunk/Source/WebCore/rendering/RenderObject.h trunk/Source/WebCore/rendering/style/RenderStyle.h trunk/Source/WebCore/rendering/style/RenderStyleConstants.h trunk/Source/WebCore/style/StyleBuilderCustom.h Diff Modified: trunk/LayoutTests/ChangeLog (284641 => 284642) --- trunk/LayoutTests/ChangeLog 2021-10-21 20:36:10 UTC (rev 284641) +++ trunk/LayoutTests/ChangeLog 2021-10-21 20:48:28 UTC (rev 284642) @@ -1,3 +1,14 @@ +2021-10-21 Rob Buis + +[css-contain] Support contain:style for counters +https://bugs.webkit.org/show_bug.cgi?id=226458 + +Reviewed by Antti Koivisto. + +Unskip tests that now pass. + +* TestExpectations: + 2021-10-21 Eric Hutchison [ iOS15 EWS ] http/tests/privateClickMeasurement/attribution-conversion-through-image-redirect-with-priority.html crashed. Modified: trunk/LayoutTests/TestExpectations (284641 => 284642) --- trunk/LayoutTests/TestExpectations 2021-10-21 20:36:10 UTC (rev 284641) +++ trunk/LayoutTests/TestExpectations 2021-10-21 20:48:28 UTC (rev 284642) @@ -4855,10 +4855,6 @@ imported/w3c/web-platform-tests/css/css-contain/contain-strict-001.html [ ImageOnlyFailure ] imported/w3c/web-platform-tests/css/css-contain/contain-strict-002.html [ ImageOnlyFailure ] imported/w3c/web-platform-tests/css/css-contain/contain-strict-011.html [ ImageOnlyFailure ] -imported/w3c/web-platform-tests/css/css-contain/contain-style-counters-001.html [ ImageOnlyFailure ] -imported/w3c/web-platform-tests/css/css-contain/contain-style-counters-002.html [ ImageOnlyFailure ] -imported/w3c/web-platform-tests/css/css-contain/contain-style-counters-003.html [ ImageOnlyFailure ] -imported/w3c/web-platform-tests/css/css-contain/contain-style-counters-004.html [ ImageOnlyFailure ] imported/w3c/web-platform-tests/css/css-contain/content-visibility/content-visibility-032.html [ ImageOnlyFailure ] imported/w3c/web-platform-tests/css/css-contain/content-visibility/content-visibility-033.sub.https.html [ ImageOnlyFailure ] imported/w3c/web-platform-tests/css/css-contain/content-visibility/content-visibility-034.html [ ImageOnlyFailure ] @@ -4881,7 +4877,6 @@ imported/w3c/web-platform-tests/css/css-contain/content-visibility/element-reassigned-to-slot-in-skipped-subtree.html [ ImageOnlyFailure ] imported/w3c/web-platform-tests/css/css-contain/counter-scoping-001.html [ ImageOnlyFailure ]
[webkit-changes] [284641] trunk/Source/WebKit
Title: [284641] trunk/Source/WebKit
Revision 284641
Author pvol...@apple.com
Date 2021-10-21 13:36:10 -0700 (Thu, 21 Oct 2021)
Log Message
Launch Services database is not always sent to GPUP
https://bugs.webkit.org/show_bug.cgi?id=232047
Unreviewed, address post commit review feedback.
Address review feedback. Also rename a data member which had a misleading name.
* UIProcess/GPU/GPUProcessProxy.cpp:
(WebKit::GPUProcessProxy::didFinishLaunching):
(WebKit::GPUProcessProxy::addSession):
* UIProcess/GPU/GPUProcessProxy.h:
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/GPU/GPUProcessProxy.cpp
trunk/Source/WebKit/UIProcess/GPU/GPUProcessProxy.h
Diff
Modified: trunk/Source/WebKit/ChangeLog (284640 => 284641)
--- trunk/Source/WebKit/ChangeLog 2021-10-21 20:34:57 UTC (rev 284640)
+++ trunk/Source/WebKit/ChangeLog 2021-10-21 20:36:10 UTC (rev 284641)
@@ -1,3 +1,18 @@
+2021-10-21 Per Arne Vollan
+
+Launch Services database is not always sent to GPUP
+https://bugs.webkit.org/show_bug.cgi?id=232047
+
+
+Unreviewed, address post commit review feedback.
+
+Address review feedback. Also rename a data member which had a misleading name.
+
+* UIProcess/GPU/GPUProcessProxy.cpp:
+(WebKit::GPUProcessProxy::didFinishLaunching):
+(WebKit::GPUProcessProxy::addSession):
+* UIProcess/GPU/GPUProcessProxy.h:
+
2021-10-19 Darin Adler
[Cocoa] Merge and simplify the nsColor family of functions
Modified: trunk/Source/WebKit/UIProcess/GPU/GPUProcessProxy.cpp (284640 => 284641)
--- trunk/Source/WebKit/UIProcess/GPU/GPUProcessProxy.cpp 2021-10-21 20:34:57 UTC (rev 284640)
+++ trunk/Source/WebKit/UIProcess/GPU/GPUProcessProxy.cpp 2021-10-21 20:36:10 UTC (rev 284641)
@@ -434,11 +434,15 @@
#endif
#if PLATFORM(COCOA)
-auto it = m_sessionIDs.begin();
-if (it != m_sessionIDs.end()) {
-auto webSiteDataStore = WebsiteDataStore::existingDataStoreForSessionID(*m_sessionIDs.begin());
-m_hasSentLaunchServicesDatabase = webSiteDataStore->sendNetworkProcessXPCEndpointToProcess(*this);
-}
+// Use any session ID to get any Website data store. It is OK to use any Website data store,
+// since we are using it to access any Networking process, which all have the XPC endpoint.
+// The XPC endpoint is used to receive the Launch Services database from the Network process.
+if (m_sessionIDs.isEmpty())
+return;
+auto store = WebsiteDataStore::existingDataStoreForSessionID(*m_sessionIDs.begin());
+if (!store)
+return;
+m_hasSentNetworkProcessXPCEndpoint = store->sendNetworkProcessXPCEndpointToProcess(*this);
#endif
}
@@ -506,8 +510,8 @@
m_sessionIDs.add(store.sessionID());
#if PLATFORM(COCOA)
-if (!m_hasSentLaunchServicesDatabase)
-m_hasSentLaunchServicesDatabase = store.sendNetworkProcessXPCEndpointToProcess(*this);
+if (!m_hasSentNetworkProcessXPCEndpoint)
+m_hasSentNetworkProcessXPCEndpoint = store.sendNetworkProcessXPCEndpointToProcess(*this);
#endif
}
Modified: trunk/Source/WebKit/UIProcess/GPU/GPUProcessProxy.h (284640 => 284641)
--- trunk/Source/WebKit/UIProcess/GPU/GPUProcessProxy.h 2021-10-21 20:34:57 UTC (rev 284640)
+++ trunk/Source/WebKit/UIProcess/GPU/GPUProcessProxy.h 2021-10-21 20:36:10 UTC (rev 284641)
@@ -146,7 +146,7 @@
bool m_hasSentTCCDSandboxExtension { false };
bool m_hasSentCameraSandboxExtension { false };
bool m_hasSentMicrophoneSandboxExtension { false };
-bool m_hasSentLaunchServicesDatabase { false };
+bool m_hasSentNetworkProcessXPCEndpoint { false };
#endif
HashSet m_sessionIDs;
};
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [284640] trunk/LayoutTests
Title: [284640] trunk/LayoutTests Revision 284640 Author ehutchi...@apple.com Date 2021-10-21 13:34:57 -0700 (Thu, 21 Oct 2021) Log Message [ iOS15 EWS ] http/tests/privateClickMeasurement/attribution-conversion-through-image-redirect-with-priority.html crashed. https://bugs.webkit.org/show_bug.cgi?id=232102. Unreviewed test gardening. * platform/ios-wk2/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/ios-wk2/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (284639 => 284640) --- trunk/LayoutTests/ChangeLog 2021-10-21 20:27:24 UTC (rev 284639) +++ trunk/LayoutTests/ChangeLog 2021-10-21 20:34:57 UTC (rev 284640) @@ -1,3 +1,12 @@ +2021-10-21 Eric Hutchison + +[ iOS15 EWS ] http/tests/privateClickMeasurement/attribution-conversion-through-image-redirect-with-priority.html crashed. +https://bugs.webkit.org/show_bug.cgi?id=232102. + +Unreviewed test gardening. + +* platform/ios-wk2/TestExpectations: + 2021-10-21 Ayumi Kojima [ iOS macOS Debug ] imported/w3c/web-platform-tests/html/dom/idlharness.worker.html is a flaky failure. Modified: trunk/LayoutTests/platform/ios-wk2/TestExpectations (284639 => 284640) --- trunk/LayoutTests/platform/ios-wk2/TestExpectations 2021-10-21 20:27:24 UTC (rev 284639) +++ trunk/LayoutTests/platform/ios-wk2/TestExpectations 2021-10-21 20:34:57 UTC (rev 284640) @@ -2241,3 +2241,5 @@ webkit.org/b/232099 imported/w3c/web-platform-tests/websockets/Close-1000.any.html [ Pass Crash ] +webkit.org/b/232102 http/tests/privateClickMeasurement/attribution-conversion-through-image-redirect-with-priority.html [ Pass Crash ] + ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [284639] trunk/LayoutTests
Title: [284639] trunk/LayoutTests Revision 284639 Author ayumi_koj...@apple.com Date 2021-10-21 13:27:24 -0700 (Thu, 21 Oct 2021) Log Message [ iOS macOS Debug ] imported/w3c/web-platform-tests/html/dom/idlharness.worker.html is a flaky failure. https://bugs.webkit.org/show_bug.cgi?id=231030 Unreviewed test gardening. * platform/ios-wk2/TestExpectations: * platform/mac/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/ios-wk2/TestExpectations trunk/LayoutTests/platform/mac/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (284638 => 284639) --- trunk/LayoutTests/ChangeLog 2021-10-21 20:21:01 UTC (rev 284638) +++ trunk/LayoutTests/ChangeLog 2021-10-21 20:27:24 UTC (rev 284639) @@ -1,3 +1,13 @@ +2021-10-21 Ayumi Kojima + +[ iOS macOS Debug ] imported/w3c/web-platform-tests/html/dom/idlharness.worker.html is a flaky failure. +https://bugs.webkit.org/show_bug.cgi?id=231030 + +Unreviewed test gardening. + +* platform/ios-wk2/TestExpectations: +* platform/mac/TestExpectations: + 2021-10-21 Eric Hutchison [ iOS15 EWS ] imported/w3c/web-platform-tests/websockets/Close-1000.any.html is a flaky crash. Modified: trunk/LayoutTests/platform/ios-wk2/TestExpectations (284638 => 284639) --- trunk/LayoutTests/platform/ios-wk2/TestExpectations 2021-10-21 20:21:01 UTC (rev 284638) +++ trunk/LayoutTests/platform/ios-wk2/TestExpectations 2021-10-21 20:27:24 UTC (rev 284639) @@ -1174,6 +1174,8 @@ webkit.org/b/230407 imported/w3c/web-platform-tests/html/dom/idlharness.https.html [ Pass Failure ] +webkit.org/b/231030 [ Debug ] imported/w3c/web-platform-tests/html/dom/idlharness.worker.html [ Pass Failure ] + webkit.org/b/232028 imported/w3c/web-platform-tests/html/cross-origin-opener-policy/reporting/navigation-reporting/report-only-four-reports.https.html [ Pass Failure ] # Newly imported WPT tests that are timing out on iOS. Modified: trunk/LayoutTests/platform/mac/TestExpectations (284638 => 284639) --- trunk/LayoutTests/platform/mac/TestExpectations 2021-10-21 20:21:01 UTC (rev 284638) +++ trunk/LayoutTests/platform/mac/TestExpectations 2021-10-21 20:27:24 UTC (rev 284639) @@ -2330,6 +2330,8 @@ webkit.org/b/228642 imported/w3c/web-platform-tests/html/cross-origin-opener-policy/_javascript_-url.https.html [ Pass Failure ] +webkit.org/b/231030 [ Debug ] imported/w3c/web-platform-tests/html/dom/idlharness.worker.html [ Pass Failure ] + webkit.org/b/229517 imported/w3c/web-platform-tests/webrtc-extensions/RTCRtpSynchronizationSource-captureTimestamp.html [ Pass Failure ] webkit.org/b/229517 imported/w3c/web-platform-tests/webrtc-extensions/RTCRtpSynchronizationSource-senderCaptureTimeOffset.html [ Pass Failure ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [284638] trunk/Tools
Title: [284638] trunk/Tools Revision 284638 Author hironori.fu...@sony.com Date 2021-10-21 13:21:01 -0700 (Thu, 21 Oct 2021) Log Message [Win] TestWTF.FileSystemTest.* are timing out if run-api-tests is run by a normal user https://bugs.webkit.org/show_bug.cgi?id=232065 Reviewed by Jonathan Bedard. run-api-tests script didn't pass TEMP and TMP env vars to TestWTF.exe. Then, generateTemporaryPath in wtf/win/FileSystemWin.cpp never finished because a normal user can't create a file in the Windows system directory. * Scripts/webkitpy/port/win.py: (WinPort.environment_for_api_tests): Added TEMP and TMP to the env var list to inherit. Modified Paths trunk/Tools/ChangeLog trunk/Tools/Scripts/webkitpy/port/win.py Diff Modified: trunk/Tools/ChangeLog (284637 => 284638) --- trunk/Tools/ChangeLog 2021-10-21 20:17:08 UTC (rev 284637) +++ trunk/Tools/ChangeLog 2021-10-21 20:21:01 UTC (rev 284638) @@ -1,5 +1,21 @@ 2021-10-21 Fujii Hironori +[Win] TestWTF.FileSystemTest.* are timing out if run-api-tests is run by a normal user +https://bugs.webkit.org/show_bug.cgi?id=232065 + +Reviewed by Jonathan Bedard. + +run-api-tests script didn't pass TEMP and TMP env vars to +TestWTF.exe. Then, generateTemporaryPath in +wtf/win/FileSystemWin.cpp never finished because a normal user +can't create a file in the Windows system directory. + +* Scripts/webkitpy/port/win.py: +(WinPort.environment_for_api_tests): Added TEMP and TMP to the env +var list to inherit. + +2021-10-21 Fujii Hironori + [Win Python] REGRESSION(r284398): run-api-tests: FileNotFoundError raised: [WinError 2] The system cannot find the file specified https://bugs.webkit.org/show_bug.cgi?id=232037 Modified: trunk/Tools/Scripts/webkitpy/port/win.py (284637 => 284638) --- trunk/Tools/Scripts/webkitpy/port/win.py 2021-10-21 20:17:08 UTC (rev 284637) +++ trunk/Tools/Scripts/webkitpy/port/win.py 2021-10-21 20:21:01 UTC (rev 284638) @@ -142,7 +142,13 @@ def environment_for_api_tests(self): env = super(WinPort, self).environment_for_api_tests() -for variable in ['SYSTEMROOT', 'WEBKIT_LIBRARIES']: +variables_to_copy = [ +'SYSTEMROOT', +'TEMP', +'TMP', +'WEBKIT_LIBRARIES', +] +for variable in variables_to_copy: self._copy_value_from_environ_if_set(env, variable) return env ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [284637] trunk/Tools
Title: [284637] trunk/Tools
Revision 284637
Author hironori.fu...@sony.com
Date 2021-10-21 13:17:08 -0700 (Thu, 21 Oct 2021)
Log Message
[Win Python] REGRESSION(r284398): run-api-tests: FileNotFoundError raised: [WinError 2] The system cannot find the file specified
https://bugs.webkit.org/show_bug.cgi?id=232037
Reviewed by Jonathan Bedard.
r284398 temporarily copied TestWTF program to ToBeListed to list
test cases. However, on Windows, TestWTF.exe is just a wrapper
program loading TestWTFLib.dll. If I just rename TestWTF.exe to
ToBeListed.exe, ToBeListed.exe tries to load ToBeListedLib.dll.
* Scripts/webkitpy/api_tests/manager.py:
(Manager._collect_tests): Do not copy the test program to
ToBeListed on Windows.
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/api_tests/manager.py
Diff
Modified: trunk/Tools/ChangeLog (284636 => 284637)
--- trunk/Tools/ChangeLog 2021-10-21 19:42:47 UTC (rev 284636)
+++ trunk/Tools/ChangeLog 2021-10-21 20:17:08 UTC (rev 284637)
@@ -1,3 +1,19 @@
+2021-10-21 Fujii Hironori
+
+[Win Python] REGRESSION(r284398): run-api-tests: FileNotFoundError raised: [WinError 2] The system cannot find the file specified
+https://bugs.webkit.org/show_bug.cgi?id=232037
+
+Reviewed by Jonathan Bedard.
+
+r284398 temporarily copied TestWTF program to ToBeListed to list
+test cases. However, on Windows, TestWTF.exe is just a wrapper
+program loading TestWTFLib.dll. If I just rename TestWTF.exe to
+ToBeListed.exe, ToBeListed.exe tries to load ToBeListedLib.dll.
+
+* Scripts/webkitpy/api_tests/manager.py:
+(Manager._collect_tests): Do not copy the test program to
+ToBeListed on Windows.
+
2021-10-21 Devin Rousso
[css-values-4] Support small (sv*), large (lv*) and dynamic (dv*) viewport units
Modified: trunk/Tools/Scripts/webkitpy/api_tests/manager.py (284636 => 284637)
--- trunk/Tools/Scripts/webkitpy/api_tests/manager.py 2021-10-21 19:42:47 UTC (rev 284636)
+++ trunk/Tools/Scripts/webkitpy/api_tests/manager.py 2021-10-21 20:17:08 UTC (rev 284637)
@@ -106,10 +106,12 @@
if canonicalized_binary not in specified_binaries:
continue
-to_be_listed = self.host.filesystem.join(self.host.filesystem.dirname(path), 'ToBeListed')
-try:
+to_be_listed = path
+if not self._port.host.platform.is_win():
+to_be_listed = self.host.filesystem.join(self.host.filesystem.dirname(path), 'ToBeListed')
self.host.filesystem.copyfile(path, to_be_listed)
self.host.filesystem.copymode(path, to_be_listed)
+try:
output = self.host.executive.run_command(
Runner.command_for_port(self._port, [to_be_listed, '--gtest_list_tests']),
env=self._port.environment_for_api_tests())
@@ -118,7 +120,8 @@
_log.error('Failed to list {} tests'.format(canonicalized_binary))
raise
finally:
-self.host.filesystem.remove(to_be_listed)
+if not self._port.host.platform.is_win():
+self.host.filesystem.remove(to_be_listed)
if len(args) == 0:
return sorted(available_tests)
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [284636] trunk/LayoutTests
Title: [284636] trunk/LayoutTests Revision 284636 Author ehutchi...@apple.com Date 2021-10-21 12:42:47 -0700 (Thu, 21 Oct 2021) Log Message [ iOS15 EWS ] imported/w3c/web-platform-tests/websockets/Close-1000.any.html is a flaky crash. https://bugs.webkit.org/show_bug.cgi?id=232099. Unreviewed test gardening. * platform/ios-wk2/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/ios-wk2/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (284635 => 284636) --- trunk/LayoutTests/ChangeLog 2021-10-21 19:29:51 UTC (rev 284635) +++ trunk/LayoutTests/ChangeLog 2021-10-21 19:42:47 UTC (rev 284636) @@ -1,3 +1,12 @@ +2021-10-21 Eric Hutchison + +[ iOS15 EWS ] imported/w3c/web-platform-tests/websockets/Close-1000.any.html is a flaky crash. +https://bugs.webkit.org/show_bug.cgi?id=232099. + +Unreviewed test gardening. + +* platform/ios-wk2/TestExpectations: + 2021-10-21 Ayumi Kojima [ iOS 15 ] webrtc/multi-video.html is a flaky timeout. Modified: trunk/LayoutTests/platform/ios-wk2/TestExpectations (284635 => 284636) --- trunk/LayoutTests/platform/ios-wk2/TestExpectations 2021-10-21 19:29:51 UTC (rev 284635) +++ trunk/LayoutTests/platform/ios-wk2/TestExpectations 2021-10-21 19:42:47 UTC (rev 284636) @@ -2236,3 +2236,6 @@ webkit.org/b/231780 [ Debug ] imported/w3c/web-platform-tests/webrtc/simulcast/basic.https.html [ Pass Failure ] webkit.org/b/232048 http/tests/privateClickMeasurement/attribution-conversion-through-image-redirect-in-new-window.html [ Pass Crash ] + +webkit.org/b/232099 imported/w3c/web-platform-tests/websockets/Close-1000.any.html [ Pass Crash ] + ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [284635] trunk
Title: [284635] trunk
Revision 284635
Author ysuz...@apple.com
Date 2021-10-21 12:29:51 -0700 (Thu, 21 Oct 2021)
Log Message
[JSC] Inserted GetTypedArrayLengthAsInt52 for PutByVal should have NodeResultInt52
https://bugs.webkit.org/show_bug.cgi?id=232059
Reviewed by Saam Barati.
JSTests:
* stress/inserted-gettypedarraylengthasint52-should-have-int52-result-for-put-by-val.js: Added.
(foo.bar):
(foo):
Source/_javascript_Core:
When inserting GetTypedArrayLengthAsInt52 after fixup phase, we must set NodeResultInt52.
* dfg/DFGSSALoweringPhase.cpp:
(JSC::DFG::SSALoweringPhase::handleNode):
Modified Paths
trunk/JSTests/ChangeLog
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/dfg/DFGSSALoweringPhase.cpp
Added Paths
trunk/JSTests/stress/inserted-gettypedarraylengthasint52-should-have-int52-result-for-put-by-val.js
Diff
Modified: trunk/JSTests/ChangeLog (284634 => 284635)
--- trunk/JSTests/ChangeLog 2021-10-21 19:18:52 UTC (rev 284634)
+++ trunk/JSTests/ChangeLog 2021-10-21 19:29:51 UTC (rev 284635)
@@ -1,3 +1,14 @@
+2021-10-21 Yusuke Suzuki
+
+[JSC] Inserted GetTypedArrayLengthAsInt52 for PutByVal should have NodeResultInt52
+https://bugs.webkit.org/show_bug.cgi?id=232059
+
+Reviewed by Saam Barati.
+
+* stress/inserted-gettypedarraylengthasint52-should-have-int52-result-for-put-by-val.js: Added.
+(foo.bar):
+(foo):
+
2021-10-18 Phillip Mates
Test coverage for JSC shadow realms implementation
Added: trunk/JSTests/stress/inserted-gettypedarraylengthasint52-should-have-int52-result-for-put-by-val.js (0 => 284635)
--- trunk/JSTests/stress/inserted-gettypedarraylengthasint52-should-have-int52-result-for-put-by-val.js (rev 0)
+++ trunk/JSTests/stress/inserted-gettypedarraylengthasint52-should-have-int52-result-for-put-by-val.js 2021-10-21 19:29:51 UTC (rev 284635)
@@ -0,0 +1,12 @@
+//@ runDefault("--useOSRExitFuzz=1", "--fireOSRExitFuzzAtOrAfter=1", "--jitPolicyScale=0", "--useConcurrentJIT=0")
+const ta = new Uint8Array();
+function foo() {
+ function bar() {
+ta[0] = 0;
+ }
+ for (let i=0; i<10; i++) {
+bar();
+ }
+
+}
+foo();
Modified: trunk/Source/_javascript_Core/ChangeLog (284634 => 284635)
--- trunk/Source/_javascript_Core/ChangeLog 2021-10-21 19:18:52 UTC (rev 284634)
+++ trunk/Source/_javascript_Core/ChangeLog 2021-10-21 19:29:51 UTC (rev 284635)
@@ -1,3 +1,15 @@
+2021-10-21 Yusuke Suzuki
+
+[JSC] Inserted GetTypedArrayLengthAsInt52 for PutByVal should have NodeResultInt52
+https://bugs.webkit.org/show_bug.cgi?id=232059
+
+Reviewed by Saam Barati.
+
+When inserting GetTypedArrayLengthAsInt52 after fixup phase, we must set NodeResultInt52.
+
+* dfg/DFGSSALoweringPhase.cpp:
+(JSC::DFG::SSALoweringPhase::handleNode):
+
2021-10-21 Michael Saboff
Add missing overflow check to DFGIntegerRangeOptimizationPhase::filterConstant()
Modified: trunk/Source/_javascript_Core/dfg/DFGSSALoweringPhase.cpp (284634 => 284635)
--- trunk/Source/_javascript_Core/dfg/DFGSSALoweringPhase.cpp 2021-10-21 19:18:52 UTC (rev 284634)
+++ trunk/Source/_javascript_Core/dfg/DFGSSALoweringPhase.cpp 2021-10-21 19:29:51 UTC (rev 284635)
@@ -105,6 +105,7 @@
Node* length = m_insertionSet.insertNode(
m_nodeIndex, SpecInt52Any, GetTypedArrayLengthAsInt52, m_node->origin,
OpInfo(m_node->arrayMode().asWord()), base, storage);
+length->setResult(NodeResultInt52);
m_graph.varArgChild(m_node, 4) = Edge(length, Int52RepUse);
} else {
#endif
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [284634] trunk/Source/WTF
Title: [284634] trunk/Source/WTF Revision 284634 Author akeer...@apple.com Date 2021-10-21 12:18:52 -0700 (Thu, 21 Oct 2021) Log Message [Cocoa] Enable accent-color by default https://bugs.webkit.org/show_bug.cgi?id=232032 rdar://84474404 Reviewed by Wenson Hsieh. * Scripts/Preferences/WebPreferencesExperimental.yaml: Enable only on Cocoa platforms, as other platforms do not support painting accent colors yet. Modified Paths trunk/Source/WTF/ChangeLog trunk/Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml Diff Modified: trunk/Source/WTF/ChangeLog (284633 => 284634) --- trunk/Source/WTF/ChangeLog 2021-10-21 18:59:06 UTC (rev 284633) +++ trunk/Source/WTF/ChangeLog 2021-10-21 19:18:52 UTC (rev 284634) @@ -1,5 +1,18 @@ 2021-10-21 Aditya Keerthi +[Cocoa] Enable accent-color by default +https://bugs.webkit.org/show_bug.cgi?id=232032 +rdar://84474404 + +Reviewed by Wenson Hsieh. + +* Scripts/Preferences/WebPreferencesExperimental.yaml: + +Enable only on Cocoa platforms, as other platforms do not support +painting accent colors yet. + +2021-10-21 Aditya Keerthi + [Cocoa] Enable 'accent-color' by default https://bugs.webkit.org/show_bug.cgi?id=232032 rdar://84474404 Modified: trunk/Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml (284633 => 284634) --- trunk/Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml 2021-10-21 18:59:06 UTC (rev 284633) +++ trunk/Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml 2021-10-21 19:18:52 UTC (rev 284634) @@ -32,11 +32,14 @@ humanReadableDescription: "Enable accent-color CSS property" defaultValue: WebKitLegacy: - default: true + "PLATFORM(COCOA)" : true + default: false WebKit: - default: true + "PLATFORM(COCOA)" : true + default: false WebCore: - default: true + "PLATFORM(COCOA)" : true + default: false AccessHandleEnabled: type: bool ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [284633] tags/Safari-613.1.6.1/
Title: [284633] tags/Safari-613.1.6.1/ Revision 284633 Author kocsen_ch...@apple.com Date 2021-10-21 11:59:06 -0700 (Thu, 21 Oct 2021) Log Message Tag Safari-613.1.6.1. Added Paths tags/Safari-613.1.6.1/ Diff ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [284632] trunk/LayoutTests
Title: [284632] trunk/LayoutTests Revision 284632 Author ayumi_koj...@apple.com Date 2021-10-21 11:57:11 -0700 (Thu, 21 Oct 2021) Log Message [ iOS 15 ] webrtc/multi-video.html is a flaky timeout. https://bugs.webkit.org/show_bug.cgi?id=232097 Unreviewed test gardening. * platform/ios-wk2/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/ios-wk2/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (284631 => 284632) --- trunk/LayoutTests/ChangeLog 2021-10-21 18:26:12 UTC (rev 284631) +++ trunk/LayoutTests/ChangeLog 2021-10-21 18:57:11 UTC (rev 284632) @@ -1,3 +1,12 @@ +2021-10-21 Ayumi Kojima + +[ iOS 15 ] webrtc/multi-video.html is a flaky timeout. +https://bugs.webkit.org/show_bug.cgi?id=232097 + +Unreviewed test gardening. + +* platform/ios-wk2/TestExpectations: + 2021-10-21 Kate Cheney http/tests/resourceLoadStatistics/website-data-removal-for-site-navigated-to-with-link-decoration.html is a flaky timeout Modified: trunk/LayoutTests/platform/ios-wk2/TestExpectations (284631 => 284632) --- trunk/LayoutTests/platform/ios-wk2/TestExpectations 2021-10-21 18:26:12 UTC (rev 284631) +++ trunk/LayoutTests/platform/ios-wk2/TestExpectations 2021-10-21 18:57:11 UTC (rev 284632) @@ -1276,6 +1276,8 @@ webkit.org/b/173608 webrtc/video-replace-muted-track.html [ Skip ] +webkit.org/b/232097 webrtc/multi-video.html [ Pass Timeout ] + webkit.org/b/231451 [ Debug ] webrtc/receiver-track-should-stay-live-even-if-receiver-is-inactive.html [ Pass Crash ] webkit.org/b/187388 animations/needs-layout.html [ Pass ImageOnlyFailure ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [284631] trunk/LayoutTests
Title: [284631] trunk/LayoutTests
Revision 284631
Author katherine_che...@apple.com
Date 2021-10-21 11:26:12 -0700 (Thu, 21 Oct 2021)
Log Message
http/tests/resourceLoadStatistics/website-data-removal-for-site-navigated-to-with-link-decoration.html is a flaky timeout
https://bugs.webkit.org/show_bug.cgi?id=231971
Reviewed by John Wilander.
Update ITP tests to wait for resetCookies() to finish before ending
the test. Flaky timeouts were being caused by resetCookies() being
partially finished which resets the top loading frame checked in
TestRunner::notifyDone().
* http/tests/cookies/resources/delete-cookie.py: Added.
(delete_cookie):
* http/tests/resourceLoadStatistics/operating-dates-all-but-cookies-not-removed-with-user-interaction-6-days-ago.html:
* http/tests/resourceLoadStatistics/operating-dates-all-but-cookies-removed-with-user-interaction-7-days-ago.html:
* http/tests/resourceLoadStatistics/operating-dates-all-website-data-removed.html:
* http/tests/resourceLoadStatistics/resources/util.js:
(async resetCookiesITP.setUp):
(async resetCookiesITP):
* http/tests/resourceLoadStatistics/standalone-web-application-exempt-from-website-data-deletion.html:
* http/tests/resourceLoadStatistics/website-data-removal-for-site-navigated-to-with-link-decoration.html:
* http/tests/resourceLoadStatistics/website-data-removal-for-site-with-user-interaction.html:
* http/tests/resourceLoadStatistics/website-data-removal-for-site-without-user-interaction.html:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/http/tests/resourceLoadStatistics/operating-dates-all-but-cookies-not-removed-with-user-interaction-6-days-ago.html
trunk/LayoutTests/http/tests/resourceLoadStatistics/operating-dates-all-but-cookies-removed-with-user-interaction-7-days-ago.html
trunk/LayoutTests/http/tests/resourceLoadStatistics/operating-dates-all-website-data-removed.html
trunk/LayoutTests/http/tests/resourceLoadStatistics/resources/util.js
trunk/LayoutTests/http/tests/resourceLoadStatistics/standalone-web-application-exempt-from-website-data-deletion.html
trunk/LayoutTests/http/tests/resourceLoadStatistics/website-data-removal-for-site-navigated-to-with-link-decoration.html
trunk/LayoutTests/http/tests/resourceLoadStatistics/website-data-removal-for-site-with-user-interaction.html
trunk/LayoutTests/http/tests/resourceLoadStatistics/website-data-removal-for-site-without-user-interaction.html
Added Paths
trunk/LayoutTests/http/tests/cookies/resources/delete-cookie.py
Diff
Modified: trunk/LayoutTests/ChangeLog (284630 => 284631)
--- trunk/LayoutTests/ChangeLog 2021-10-21 18:25:04 UTC (rev 284630)
+++ trunk/LayoutTests/ChangeLog 2021-10-21 18:26:12 UTC (rev 284631)
@@ -1,3 +1,29 @@
+2021-10-21 Kate Cheney
+
+http/tests/resourceLoadStatistics/website-data-removal-for-site-navigated-to-with-link-decoration.html is a flaky timeout
+https://bugs.webkit.org/show_bug.cgi?id=231971
+
+
+Reviewed by John Wilander.
+
+Update ITP tests to wait for resetCookies() to finish before ending
+the test. Flaky timeouts were being caused by resetCookies() being
+partially finished which resets the top loading frame checked in
+TestRunner::notifyDone().
+
+* http/tests/cookies/resources/delete-cookie.py: Added.
+(delete_cookie):
+* http/tests/resourceLoadStatistics/operating-dates-all-but-cookies-not-removed-with-user-interaction-6-days-ago.html:
+* http/tests/resourceLoadStatistics/operating-dates-all-but-cookies-removed-with-user-interaction-7-days-ago.html:
+* http/tests/resourceLoadStatistics/operating-dates-all-website-data-removed.html:
+* http/tests/resourceLoadStatistics/resources/util.js:
+(async resetCookiesITP.setUp):
+(async resetCookiesITP):
+* http/tests/resourceLoadStatistics/standalone-web-application-exempt-from-website-data-deletion.html:
+* http/tests/resourceLoadStatistics/website-data-removal-for-site-navigated-to-with-link-decoration.html:
+* http/tests/resourceLoadStatistics/website-data-removal-for-site-with-user-interaction.html:
+* http/tests/resourceLoadStatistics/website-data-removal-for-site-without-user-interaction.html:
+
2021-10-21 Ayumi Kojima
[ iOS macOS wk2 ]compositing/video/video-border-radius-clipping.html is a flakey image failure.
Added: trunk/LayoutTests/http/tests/cookies/resources/delete-cookie.py (0 => 284631)
--- trunk/LayoutTests/http/tests/cookies/resources/delete-cookie.py (rev 0)
+++ trunk/LayoutTests/http/tests/cookies/resources/delete-cookie.py 2021-10-21 18:26:12 UTC (rev 284631)
@@ -0,0 +1,29 @@
+#!/usr/bin/env python3
+
+import os
+import sys
+from datetime import datetime, timedelta
+from urllib.parse import parse_qs
+
+file = __file__.split(':/cygwin')[-1]
+http_root = os.path.dirname(os.path.dirname(os.path.abspath(os.path.dirname(file
+sys.path.insert(0, http_root)
+
[webkit-changes] [284630] trunk/Source
Title: [284630] trunk/Source Revision 284630 Author da...@apple.com Date 2021-10-21 11:25:04 -0700 (Thu, 21 Oct 2021) Log Message [Cocoa] Merge and simplify the nsColor family of functions https://bugs.webkit.org/show_bug.cgi?id=231992 Reviewed by Anders Carlsson. Source/WebCore: - Added a CocoaColor type that is NS/UIColor. - Renamed platformColor to cocoaColor to be less vague. - Removed nsColor. - Added cocoaColorOrNil. - Merged colorFromNSColor and colorFromUIColor into a single colorFromCocoaColor function. * WebCore.xcodeproj/project.pbxproj: Removed ColorIOS.h. * accessibility/mac/WebAccessibilityObjectWrapperMac.mm: (AXAttributeStringSetStyle): Use cocoaColor instead of nsColor. * editing/cocoa/FontAttributesCocoa.mm: (WebCore::FontAttributes::createDictionary const): Use cocoaColor instead of platformColor. * editing/cocoa/FontShadowCocoa.mm: (WebCore::FontShadow::createShadow const): Ditto. * editing/cocoa/HTMLConverter.mm: (HTMLConverter::_colorForElement): Use cocoaColor instead of platformColor. (WebCore::editingAttributedString): Use cocoaColor instead of nsColor. * platform/cocoa/DragImageCocoa.mm: (WebCore::createDragImageForLink): Use colorFromCocoaColor instead of colorFromNSColor. (WebCore::createDragImageForColor): Use cocoaColor instead of nsColor. * platform/graphics/cocoa/ColorCocoa.h: Added an include of "Color.h" so this functions as an addition to that header instead of something independent. Added a WebCore::CocoaColor type, like the one we already have in WebKit, to cut down on the need to do #if and #else so much. Renamed the platformColor function to cocoaColor, added a cocoaColorOrNil function, and renamed both colorFromNSColor and colorFromUIColor to colorFromCocoaColor and moved here. * platform/graphics/cocoa/ColorCocoa.mm: (WebCore::cocoaColor): Renamed the iOS platformColor to this. (WebCore::cocoaColorOrNil): Added. * platform/graphics/mac/ColorMac.h: Include of "ColorCocoa.h" instead of "Color.h" here. Moved colorFromNSColor and nsColor. * platform/graphics/mac/ColorMac.mm: (WebCore::colorFromCocoaColor): Renamed from colorFromNSColor. (WebCore::cocoaColor): Renamed from nsColor. * platform/ios/ColorIOS.h: Removed. * platform/ios/ColorIOS.mm: (WebCore::colorFromCocoaColor): Renamed from colorFromUIColor. * platform/ios/PlatformPasteboardIOS.mm: (WebCore::PlatformPasteboard::setColor): Use cocoaColor instead of +[UIColor colorWithCGColor:] and cachedCGColor. * platform/mac/LocalDefaultSystemAppearance.mm: (WebCore::LocalDefaultSystemAppearance::LocalDefaultSystemAppearance): Use cocoaColor instead of nsColor. * platform/mac/PlatformPasteboardMac.mm: (WebCore::PlatformPasteboard::color): Use colorFromCocoaColor instead of colorFromNSColor. (WebCore::PlatformPasteboard::setColor): Use cocoaColor instead of nsColor. * platform/mac/ThemeMac.mm: (WebCore::drawCellFocusRingWithFrameAtTime): Use colorFromCocoaColor instead of colorFromNSColor. * platform/mac/WebCoreNSFontManagerExtras.mm: (WebCore::computedFontAttributeChanges): DItto. * rendering/RenderThemeIOS.mm: (WebCore::RenderThemeIOS::systemFocusRingColor): Use colorFromCocoaColor instead of colorFromUIColor. (WebCore::attachmentActionColor): Use cocoaColor instead of +[UIColor colorWithCGColor:] and cachedCGColor and return a RetainPtr to avoid autorelease. (WebCore::RenderAttachmentInfo::RenderAttachmentInfo): Update for the user of the RetainPtr. * rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::platformActiveSelectionBackgroundColor const): Use colorFromCocoaColor instead of colorFromNSColor. (WebCore::RenderThemeMac::platformInactiveSelectionBackgroundColor const): Ditto. (WebCore::RenderThemeMac::platformActiveSelectionForegroundColor const): Ditto. (WebCore::RenderThemeMac::platformInactiveSelectionForegroundColor const): Ditto. (WebCore::RenderThemeMac::platformActiveListBoxSelectionBackgroundColor const): Ditto. (WebCore::RenderThemeMac::platformInactiveListBoxSelectionBackgroundColor const): Ditto. (WebCore::RenderThemeMac::platformActiveListBoxSelectionForegroundColor const): Ditto. (WebCore::RenderThemeMac::platformInactiveListBoxSelectionForegroundColor const): Ditto. (WebCore::RenderThemeMac::platformFocusRingColor const): Ditto. (WebCore::RenderThemeMac::platformTextSearchHighlightColor const): Ditto. (WebCore::RenderThemeMac::platformDefaultButtonTextColor const): Ditto. (WebCore::titleTextColorForAttachment): Ditto. (WebCore::AttachmentLayout::layOutTitle): Removed incorrect cast that said it was casting a CGColorRef to an NSColor *, which are not toll-free bridged. This code just needs a CGColorRef in a dictionary, so we just need to cast to id, not to a NSColor *. (WebCore::AttachmentLayout::layOutSubtitle): Ditto. (WebCore::paintAttachmentTitleBackground): Use colorFromCocoaColor instead of colorFromNSColor. Source/WebKit: * Shared/Cocoa/ArgumentCodersCocoa.mm: (IPC::encodeColorInternal): Merged the NSColor and UIColor implementations into a single one that
[webkit-changes] [284629] trunk/LayoutTests
Title: [284629] trunk/LayoutTests Revision 284629 Author ayumi_koj...@apple.com Date 2021-10-21 11:22:37 -0700 (Thu, 21 Oct 2021) Log Message [ iOS macOS wk2 ]compositing/video/video-border-radius-clipping.html is a flakey image failure. https://bugs.webkit.org/show_bug.cgi?id=224690 Unreviewed test gardening. * platform/ios-wk2/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/ios-wk2/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (284628 => 284629) --- trunk/LayoutTests/ChangeLog 2021-10-21 18:17:59 UTC (rev 284628) +++ trunk/LayoutTests/ChangeLog 2021-10-21 18:22:37 UTC (rev 284629) @@ -1,3 +1,12 @@ +2021-10-21 Ayumi Kojima + +[ iOS macOS wk2 ]compositing/video/video-border-radius-clipping.html is a flakey image failure. +https://bugs.webkit.org/show_bug.cgi?id=224690 + +Unreviewed test gardening. + +* platform/ios-wk2/TestExpectations: + 2021-10-21 Arcady Goldmints-Orlov [GTK] Update test baselines after r284521 Modified: trunk/LayoutTests/platform/ios-wk2/TestExpectations (284628 => 284629) --- trunk/LayoutTests/platform/ios-wk2/TestExpectations 2021-10-21 18:17:59 UTC (rev 284628) +++ trunk/LayoutTests/platform/ios-wk2/TestExpectations 2021-10-21 18:22:37 UTC (rev 284629) @@ -1998,6 +1998,8 @@ webkit.org/b/223900 compositing/video/video-update-rendering.html [ Pass Failure ] +webkit.org/b/224690 compositing/video/video-border-radius-clipping.html [ Pass ImageOnlyFailure ] + webkit.org/b/216126 fast/encoding/charset-replacement.html [ Failure ] webkit.org/b/216156 http/tests/misc/script-async.html [ Pass Failure ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [284628] trunk
Title: [284628] trunk Revision 284628 Author drou...@apple.com Date 2021-10-21 11:17:59 -0700 (Thu, 21 Oct 2021) Log Message [css-values-4] Support small (sv*), large (lv*) and dynamic (dv*) viewport units https://bugs.webkit.org/show_bug.cgi?id=219287 Reviewed by Simon Fraser. Source/WebCore: Spec: Tests: CSSViewportUnits.AllSame CSSViewportUnits.EmptyUnobscuredSizeOverrides CSSViewportUnits.SameUnobscuredSizeOverrides CSSViewportUnits.DifferentUnobscuredSizeOverrides * css/CSSUnits.h: * css/CSSUnits.cpp: (WebCore::operator<<): * css/CSSPrimitiveValue.h: (WebCore::CSSPrimitiveValue::isViewportPercentageLength): (WebCore::CSSPrimitiveValue::isViewportPercentageWidth): Deleted. (WebCore::CSSPrimitiveValue::isViewportPercentageHeight): Deleted. (WebCore::CSSPrimitiveValue::isViewportPercentageMax): Deleted. (WebCore::CSSPrimitiveValue::isViewportPercentageMin): Deleted. * css/CSSPrimitiveValue.cpp: (WebCore::isValidCSSUnitTypeForDoubleConversion): (WebCore::isStringType): (WebCore::CSSPrimitiveValue::cleanup): (WebCore::CSSPrimitiveValue::computeUnzoomedNonCalcLengthDouble): (WebCore::CSSPrimitiveValue::computeNonCalcLengthDouble): (WebCore::CSSPrimitiveValue::unitTypeString): (WebCore::CSSPrimitiveValue::formatNumberForCustomCSSText const): (WebCore::CSSPrimitiveValue::equals const): * css/CSSToLengthConversionData.h: * css/CSSToLengthConversionData.cpp: (WebCore::CSSToLengthConversionData::defaultViewportFactor const): Added. (WebCore::CSSToLengthConversionData::smallViewportFactor const): Added. (WebCore::CSSToLengthConversionData::largeViewportFactor const): Added. (WebCore::CSSToLengthConversionData::dynamicViewportFactor const): Added. (WebCore::CSSToLengthConversionData::viewportWidthFactor const): Deleted. (WebCore::CSSToLengthConversionData::viewportHeightFactor const): Deleted. (WebCore::CSSToLengthConversionData::viewportMinFactor const): Deleted. (WebCore::CSSToLengthConversionData::viewportMaxFactor const): Deleted. * css/parser/CSSParserToken.cpp: (WebCore::cssPrimitiveValueUnitFromTrie): * css/parser/CSSPropertyParserHelpers.cpp: (WebCore::CSSPropertyParserHelpers::consumeLengthRawWithKnownTokenTypeDimension): * css/calc/CSSCalcCategoryMapping.cpp: (WebCore::calcUnitCategory): (WebCore::calculationCategoryForCombination): (WebCore::hasDoubleValue): Add support for parsing the following and converting them to their underlying value: - `svw` "small viewport width" is the width of the viewport if all UA interfaces are maximized - `svh` "small viewport height" is the height of the viewport if all UA interfaces are maximized - `svmin` "small viewport small dimension" is `min(svw, svh)` - `svmax` "small viewport large dimension" is `max(svw, svh)` - `lvw` "large viewport width" is the width of the viewport if all UA interfaces are minimized - `lvh` "large viewport height" is the height of the viewport if all UA interfaces are minimized - `lvmin` "large viewport small dimension" is `min(lvw, lvh)` - `lvmax` "large viewport large dimension" is `max(lvw, lvh)` - `dvw` "dynamic viewport width" is the width of the viewport with all UA interfaces being in whatever state they are currently in - `dvh` "dynamic viewport height" is the height of the viewport with all UA interfaces being in whatever state they are currently in - `dvmin` "dynamic viewport small dimension" is `min(dvw, dvh)` - `dvmax` "dynamic viewport large dimension" is `max(dvw, dvh)` The existing `vw`/`vh`/`vmin`/`vmax` correspond to the "UA-default viewport", which WebKit considers equivalent to the "large viewport" `lvw`/`lvh`/`lvmin`/`lvmax`. * page/FrameView.h: * page/FrameView.cpp: (WebCore::FrameView::unobscuredContentSizeChanged): (WebCore::FrameView::performSizeToContentAutoSize): (WebCore::FrameView::enableAutoSizeMode): (WebCore::FrameView::clearSizeOverrideForCSSSmallViewportUnits): Added. (WebCore::FrameView::setSizeForCSSSmallViewportUnits): Added. (WebCore::FrameView::overrideWidthForCSSSmallViewportUnits): Added. (WebCore::FrameView::resetOverriddenWidthForCSSSmallViewportUnits): Added. (WebCore::FrameView::overrideSizeForCSSSmallViewportUnits): Added. (WebCore::FrameView::sizeForCSSSmallViewportUnits const): Added. (WebCore::FrameView::clearSizeOverrideForCSSLargeViewportUnits): Renamed from `clearViewportSizeOverrideForCSSViewportUnits`. (WebCore::FrameView::setSizeForCSSLargeViewportUnits): Renamed from `setViewportSizeForCSSViewportUnits`. (WebCore::FrameView::overrideWidthForCSSLargeViewportUnits): Renamed from `overrideViewportWidthForCSSViewportUnits`. (WebCore::FrameView::resetOverriddenWidthForCSSLargeViewportUnits): Renamed from `resetOverriddenViewportWidthForCSSViewportUnits`. (WebCore::FrameView::overrideSizeForCSSLargeViewportUnits): Renamed from `overrideViewportSizeForCSSViewportUnits`. (WebCore::FrameView::sizeForCSSLargeViewportUnits const): Renamed from `viewportSizeForCSSViewportUnits`. (WebCore::FrameView::calculateSizeForCSSViewportUnitsOverride const): Added.
[webkit-changes] [284626] trunk/Source/WebCore
Title: [284626] trunk/Source/WebCore
Revision 284626
Author akeer...@apple.com
Date 2021-10-21 11:05:21 -0700 (Thu, 21 Oct 2021)
Log Message
[macOS] Update appearance of indicator
https://bugs.webkit.org/show_bug.cgi?id=232031
rdar://84474135
Reviewed by Wenson Hsieh.
Source/WebCore:
* rendering/RenderThemeMac.mm:
(WebCore::RenderThemeMac::paintListButtonForInput):
Use CoreUI to paint the indicator on Big Sur and Monterey.
Source/WebCore/PAL:
* pal/spi/mac/CoreUISPI.h:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/PAL/ChangeLog
trunk/Source/WebCore/PAL/pal/spi/mac/CoreUISPI.h
trunk/Source/WebCore/rendering/RenderThemeMac.mm
Diff
Modified: trunk/Source/WebCore/ChangeLog (284625 => 284626)
--- trunk/Source/WebCore/ChangeLog 2021-10-21 17:58:55 UTC (rev 284625)
+++ trunk/Source/WebCore/ChangeLog 2021-10-21 18:05:21 UTC (rev 284626)
@@ -1,3 +1,16 @@
+2021-10-21 Aditya Keerthi
+
+[macOS] Update appearance of indicator
+https://bugs.webkit.org/show_bug.cgi?id=232031
+rdar://84474135
+
+Reviewed by Wenson Hsieh.
+
+* rendering/RenderThemeMac.mm:
+(WebCore::RenderThemeMac::paintListButtonForInput):
+
+Use CoreUI to paint the indicator on Big Sur and Monterey.
+
2021-10-21 Devin Rousso
REGRESSION(r283864): Apple Pay named images are missing
Modified: trunk/Source/WebCore/PAL/ChangeLog (284625 => 284626)
--- trunk/Source/WebCore/PAL/ChangeLog 2021-10-21 17:58:55 UTC (rev 284625)
+++ trunk/Source/WebCore/PAL/ChangeLog 2021-10-21 18:05:21 UTC (rev 284626)
@@ -1,3 +1,13 @@
+2021-10-21 Aditya Keerthi
+
+[macOS] Update appearance of indicator
+https://bugs.webkit.org/show_bug.cgi?id=232031
+rdar://84474135
+
+Reviewed by Wenson Hsieh.
+
+* pal/spi/mac/CoreUISPI.h:
+
2021-10-20 Ross Kirsling
Mac CMake build should not need to include iOS headers
Modified: trunk/Source/WebCore/PAL/pal/spi/mac/CoreUISPI.h (284625 => 284626)
--- trunk/Source/WebCore/PAL/pal/spi/mac/CoreUISPI.h 2021-10-21 17:58:55 UTC (rev 284625)
+++ trunk/Source/WebCore/PAL/pal/spi/mac/CoreUISPI.h 2021-10-21 18:05:21 UTC (rev 284626)
@@ -68,5 +68,8 @@
extern const CFStringRef kCUIWidgetProgressIndeterminateBar;
extern const CFStringRef kCUIWidgetProgressBar;
extern const CFStringRef kCUIWidgetScrollBarTrackCorner;
+#if HAVE(LARGE_CONTROL_SIZE)
+extern const CFStringRef kCUIWidgetButtonComboBox;
+#endif
#endif
Modified: trunk/Source/WebCore/rendering/RenderThemeMac.mm (284625 => 284626)
--- trunk/Source/WebCore/rendering/RenderThemeMac.mm 2021-10-21 17:58:55 UTC (rev 284625)
+++ trunk/Source/WebCore/rendering/RenderThemeMac.mm 2021-10-21 18:05:21 UTC (rev 284626)
@@ -988,6 +988,65 @@
{
// We can't paint an NSComboBoxCell since they are not height-resizable.
const auto& input = downcast(*(o.generatingNode()));
+
+#if HAVE(LARGE_CONTROL_SIZE)
+LocalDefaultSystemAppearance localAppearance(o.useDarkAppearance(), o.style().effectiveAccentColor());
+
+const FloatSize comboBoxSize { 40, 19 };
+const FloatSize comboBoxButtonSize { 16, 16 };
+const FloatPoint comboBoxButtonInset { 5, 1 };
+constexpr auto comboBoxButtonCornerRadii = 4;
+
+const FloatSize desiredComboBoxButtonSize { 12, 12 };
+constexpr auto desiredComboBoxInset = 2;
+
+float deviceScaleFactor = o.document().deviceScaleFactor();
+
+auto comboBoxImageBuffer = ImageBuffer::createCompatibleBuffer(comboBoxSize, deviceScaleFactor, DestinationColorSpace::SRGB(), context);
+if (!comboBoxImageBuffer)
+return;
+
+ContextContainer cgContextContainer(comboBoxImageBuffer->context());
+CGContextRef cgContext = cgContextContainer.context();
+
+NSString *coreUIState;
+if (input.isPresentingAttachedView())
+coreUIState = (__bridge NSString *)kCUIStatePressed;
+else if (auto* buttonElement = input.dataListButtonElement())
+coreUIState = (__bridge NSString *)(buttonElement->active() ? kCUIStatePressed : kCUIStateActive);
+else
+coreUIState = (__bridge NSString *)kCUIStateActive;
+
+ALLOW_DEPRECATED_DECLARATIONS_BEGIN
+[[NSAppearance currentAppearance] _drawInRect:NSMakeRect(0, 0, comboBoxSize.width(), comboBoxSize.height()) context:cgContext options:@{
+ALLOW_DEPRECATED_DECLARATIONS_END
+(__bridge NSString *)kCUIWidgetKey : (__bridge NSString *)kCUIWidgetButtonComboBox,
+(__bridge NSString *)kCUISizeKey : (__bridge NSString *)kCUISizeRegular,
+(__bridge NSString *)kCUIStateKey : coreUIState,
+(__bridge NSString *)kCUIUserInterfaceLayoutDirectionKey : (__bridge NSString *)kCUIUserInterfaceLayoutDirectionLeftToRight,
+}];
+
+auto comboBoxButtonImageBuffer = ImageBuffer::createCompatibleBuffer(desiredComboBoxButtonSize, deviceScaleFactor, DestinationColorSpace::SRGB(), context);
+if (!comboBoxButtonImageBuffer)
+return;
+
+auto& comboBoxButtonContext =
[webkit-changes] [284625] trunk/Source/WebKit
Title: [284625] trunk/Source/WebKit
Revision 284625
Author drou...@apple.com
Date 2021-10-21 10:58:55 -0700 (Thu, 21 Oct 2021)
Log Message
[iOS] Zooming out should use the page's background color instead of fading
https://bugs.webkit.org/show_bug.cgi?id=232036
Reviewed by Tim Horton.
* UIProcess/API/ios/WKWebViewIOS.mm:
(scrollViewBackgroundColor):
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/API/ios/WKWebViewIOS.mm
Diff
Modified: trunk/Source/WebKit/ChangeLog (284624 => 284625)
--- trunk/Source/WebKit/ChangeLog 2021-10-21 17:55:14 UTC (rev 284624)
+++ trunk/Source/WebKit/ChangeLog 2021-10-21 17:58:55 UTC (rev 284625)
@@ -1,3 +1,14 @@
+2021-10-21 Devin Rousso
+
+[iOS] Zooming out should use the page's background color instead of fading
+https://bugs.webkit.org/show_bug.cgi?id=232036
+
+
+Reviewed by Tim Horton.
+
+* UIProcess/API/ios/WKWebViewIOS.mm:
+(scrollViewBackgroundColor):
+
2021-10-21 John Pascoe
Followup: Fix crash when calling setUsernameForLocalCredentialWithID
Modified: trunk/Source/WebKit/UIProcess/API/ios/WKWebViewIOS.mm (284624 => 284625)
--- trunk/Source/WebKit/UIProcess/API/ios/WKWebViewIOS.mm 2021-10-21 17:55:14 UTC (rev 284624)
+++ trunk/Source/WebKit/UIProcess/API/ios/WKWebViewIOS.mm 2021-10-21 17:58:55 UTC (rev 284625)
@@ -527,14 +527,6 @@
#endif
}
-CGFloat zoomScale = contentZoomScale(webView);
-CGFloat minimumZoomScale = [webView->_scrollView minimumZoomScale];
-if (zoomScale < minimumZoomScale) {
-CGFloat slope = 12;
-CGFloat opacity = std::max(1 - slope * (minimumZoomScale - zoomScale), 0);
-color = color.colorWithAlpha(opacity);
-}
-
return color;
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [284624] trunk
Title: [284624] trunk Revision 284624 Author drou...@apple.com Date 2021-10-21 10:55:14 -0700 (Thu, 21 Oct 2021) Log Message REGRESSION(r283864): Apple Pay named images are missing https://bugs.webkit.org/show_bug.cgi?id=232050 Reviewed by Andy Estes. Source/WebCore: `NamedImageGeneratedImage` already does a translate before calling into `drawNamedImage`, so there's no reason to pass along the location of the named image. Instead, just pass the size. Tests: fast/css/webkit-named-image/apple-pay-logo-black/offset.html fast/css/webkit-named-image/apple-pay-logo-white/offset.html * platform/Theme.h: * platform/Theme.cpp: (WebCore::Theme::drawNamedImage const): * platform/cocoa/ThemeCocoa.h: * platform/cocoa/ThemeCocoa.mm: (WebCore::drawApplePayButton): (WebCore::ThemeCocoa::drawNamedImage const): * platform/graphics/NamedImageGeneratedImage.cpp: (WebCore::NamedImageGeneratedImage::draw): (WebCore::NamedImageGeneratedImage::drawPattern): LayoutTests: * fast/css/webkit-named-image/apple-pay-logo-black/offset.html: Added. * fast/css/webkit-named-image/apple-pay-logo-black/offset-expected-mismatch.html: Added. * fast/css/webkit-named-image/apple-pay-logo-white/offset.html: Added. * fast/css/webkit-named-image/apple-pay-logo-white/offset-expected-mismatch.html: Added. * fast/css/webkit-named-image/apple-pay-logo-white/background-size-centered.html: * fast/css/webkit-named-image/apple-pay-logo-white/background-size-centered-expected-mismatch.html: * fast/css/webkit-named-image/apple-pay-logo-white/background-size.html: * fast/css/webkit-named-image/apple-pay-logo-white/background-size-expected-mismatch.html: * fast/css/webkit-named-image/apple-pay-logo-white/basic.html: * fast/css/webkit-named-image/apple-pay-logo-white/basic-expected-mismatch.html: * fast/css/webkit-named-image/apple-pay-logo-white/container-larger-height.html: * fast/css/webkit-named-image/apple-pay-logo-white/container-larger-height-expected-mismatch.html: * fast/css/webkit-named-image/apple-pay-logo-white/container-larger-width.html: * fast/css/webkit-named-image/apple-pay-logo-white/container-larger-width-expected-mismatch.html: * fast/css/webkit-named-image/apple-pay-logo-white/mask.html: * fast/css/webkit-named-image/apple-pay-logo-white/mask-expected-mismatch.html: Drive-by: fix these to also have `background-color: black;` in the `-expected-mismatch.html`. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/fast/css/webkit-named-image/apple-pay-logo-white/background-size-centered-expected-mismatch.html trunk/LayoutTests/fast/css/webkit-named-image/apple-pay-logo-white/background-size-centered.html trunk/LayoutTests/fast/css/webkit-named-image/apple-pay-logo-white/background-size-expected-mismatch.html trunk/LayoutTests/fast/css/webkit-named-image/apple-pay-logo-white/background-size.html trunk/LayoutTests/fast/css/webkit-named-image/apple-pay-logo-white/basic-expected-mismatch.html trunk/LayoutTests/fast/css/webkit-named-image/apple-pay-logo-white/basic.html trunk/LayoutTests/fast/css/webkit-named-image/apple-pay-logo-white/container-larger-height-expected-mismatch.html trunk/LayoutTests/fast/css/webkit-named-image/apple-pay-logo-white/container-larger-height.html trunk/LayoutTests/fast/css/webkit-named-image/apple-pay-logo-white/container-larger-width-expected-mismatch.html trunk/LayoutTests/fast/css/webkit-named-image/apple-pay-logo-white/container-larger-width.html trunk/LayoutTests/fast/css/webkit-named-image/apple-pay-logo-white/mask-expected-mismatch.html trunk/LayoutTests/fast/css/webkit-named-image/apple-pay-logo-white/mask.html trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/platform/Theme.cpp trunk/Source/WebCore/platform/Theme.h trunk/Source/WebCore/platform/cocoa/ThemeCocoa.h trunk/Source/WebCore/platform/cocoa/ThemeCocoa.mm trunk/Source/WebCore/platform/graphics/NamedImageGeneratedImage.cpp Added Paths trunk/LayoutTests/fast/css/webkit-named-image/apple-pay-logo-black/offset-expected-mismatch.html trunk/LayoutTests/fast/css/webkit-named-image/apple-pay-logo-black/offset.html trunk/LayoutTests/fast/css/webkit-named-image/apple-pay-logo-white/offset-expected-mismatch.html trunk/LayoutTests/fast/css/webkit-named-image/apple-pay-logo-white/offset.html Diff Modified: trunk/LayoutTests/ChangeLog (284623 => 284624) --- trunk/LayoutTests/ChangeLog 2021-10-21 17:54:48 UTC (rev 284623) +++ trunk/LayoutTests/ChangeLog 2021-10-21 17:55:14 UTC (rev 284624) @@ -1,3 +1,30 @@ +2021-10-21 Devin Rousso + +REGRESSION(r283864): Apple Pay named images are missing +https://bugs.webkit.org/show_bug.cgi?id=232050 + + +Reviewed by Andy Estes. + +* fast/css/webkit-named-image/apple-pay-logo-black/offset.html: Added. +* fast/css/webkit-named-image/apple-pay-logo-black/offset-expected-mismatch.html: Added. +* fast/css/webkit-named-image/apple-pay-logo-white/offset.html: Added. +*
[webkit-changes] [284623] trunk/Source/JavaScriptCore
Title: [284623] trunk/Source/_javascript_Core
Revision 284623
Author msab...@apple.com
Date 2021-10-21 10:54:48 -0700 (Thu, 21 Oct 2021)
Log Message
Add missing overflow check to DFGIntegerRangeOptimizationPhase::filterConstant()
https://bugs.webkit.org/show_bug.cgi?id=232058
Reviewed by Robin Morisset.
Added overflow check.
* dfg/DFGIntegerRangeOptimizationPhase.cpp:
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/dfg/DFGIntegerRangeOptimizationPhase.cpp
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (284622 => 284623)
--- trunk/Source/_javascript_Core/ChangeLog 2021-10-21 17:40:23 UTC (rev 284622)
+++ trunk/Source/_javascript_Core/ChangeLog 2021-10-21 17:54:48 UTC (rev 284623)
@@ -1,3 +1,14 @@
+2021-10-21 Michael Saboff
+
+Add missing overflow check to DFGIntegerRangeOptimizationPhase::filterConstant()
+https://bugs.webkit.org/show_bug.cgi?id=232058
+
+Reviewed by Robin Morisset.
+
+Added overflow check.
+
+* dfg/DFGIntegerRangeOptimizationPhase.cpp:
+
2021-10-20 Yusuke Suzuki
*IsSane API's could take in the Structure's we're consulting, or they can be out parameters, so we don't rely on the CPU's memory ordering
Modified: trunk/Source/_javascript_Core/dfg/DFGIntegerRangeOptimizationPhase.cpp (284622 => 284623)
--- trunk/Source/_javascript_Core/dfg/DFGIntegerRangeOptimizationPhase.cpp 2021-10-21 17:40:23 UTC (rev 284622)
+++ trunk/Source/_javascript_Core/dfg/DFGIntegerRangeOptimizationPhase.cpp 2021-10-21 17:54:48 UTC (rev 284623)
@@ -568,6 +568,9 @@
switch (other.m_kind) {
case Equal:
+if (differenceOverflows(otherEffectiveRight, thisRight))
+return *this;
+
// Return a version of *this that is Equal to other's constant.
return Relationship(m_left, m_right, Equal, otherEffectiveRight - thisRight);
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [284622] trunk/LayoutTests
Title: [284622] trunk/LayoutTests
Revision 284622
Author katherine_che...@apple.com
Date 2021-10-21 10:40:23 -0700 (Thu, 21 Oct 2021)
Log Message
crypto/subtle/rsaes-pkcs1-v1_5-import-jwk-public-key-leading-zero.html is a constant timeout
https://bugs.webkit.org/show_bug.cgi?id=232038
Reviewed by Chris Dumez.
The modulus n in the existing test was not the result of two primes
p and q (it ends with 0x66 0x67 0x68). This patch updates the modulus
which I calculated using SubtleCrypto's generateKey() function then
prepended some zeros to test the intended functionality.
* crypto/subtle/rsaes-pkcs1-v1_5-import-jwk-public-key-leading-zero.html:
* platform/mac/TestExpectations:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/crypto/subtle/rsaes-pkcs1-v1_5-import-jwk-public-key-leading-zero.html
trunk/LayoutTests/platform/mac/TestExpectations
Diff
Modified: trunk/LayoutTests/ChangeLog (284621 => 284622)
--- trunk/LayoutTests/ChangeLog 2021-10-21 17:34:01 UTC (rev 284621)
+++ trunk/LayoutTests/ChangeLog 2021-10-21 17:40:23 UTC (rev 284622)
@@ -1,3 +1,19 @@
+2021-10-21 Kate Cheney
+
+crypto/subtle/rsaes-pkcs1-v1_5-import-jwk-public-key-leading-zero.html is a constant timeout
+https://bugs.webkit.org/show_bug.cgi?id=232038
+
+
+Reviewed by Chris Dumez.
+
+The modulus n in the existing test was not the result of two primes
+p and q (it ends with 0x66 0x67 0x68). This patch updates the modulus
+which I calculated using SubtleCrypto's generateKey() function then
+prepended some zeros to test the intended functionality.
+
+* crypto/subtle/rsaes-pkcs1-v1_5-import-jwk-public-key-leading-zero.html:
+* platform/mac/TestExpectations:
+
2021-10-21 Ayumi Kojima
Regression(r284439): [ iPad ] fast/canvas/canvas-createPattern-video-loading.html and imported/w3c/web-platform-tests/html/canvas/element/manual/imagebitmap/canvas-createImageBitmap-video-resize.html are failing.
Modified: trunk/LayoutTests/crypto/subtle/rsaes-pkcs1-v1_5-import-jwk-public-key-leading-zero.html (284621 => 284622)
--- trunk/LayoutTests/crypto/subtle/rsaes-pkcs1-v1_5-import-jwk-public-key-leading-zero.html 2021-10-21 17:34:01 UTC (rev 284621)
+++ trunk/LayoutTests/crypto/subtle/rsaes-pkcs1-v1_5-import-jwk-public-key-leading-zero.html 2021-10-21 17:40:23 UTC (rev 284622)
@@ -15,7 +15,7 @@
var jwkKey = {
kty: "RSA",
-n: "AGFiY2RlZmdoYWJjZGVmZ2hhYmNkZWZnaGFiY2RlZmdoYWJjZGVmZ2hhYmNkZWZnaGFiY2RlZmdoYWJjZGVmZ2hhYmNkZWZnaGFiY2RlZmdoYWJjZGVmZ2hhYmNkZWZnaGFiY2RlZmdoYWJjZGVmZ2hhYmNkZWZnaGFiY2RlZmdoYWJjZGVmZ2hhYmNkZWZnaGFiY2RlZmdoYWJjZGVmZ2hhYmNkZWZnaGFiY2RlZmdoYWJjZGVmZ2hhYmNkZWZnaGFiY2RlZmdoYWJjZGVmZ2hhYmNkZWZnaGFiY2RlZmdoYWJjZGVmZ2hhYmNkZWZnaGFiY2RlZmdoYWJjZGVmZ2g",
+n: "xAlQI4j-tH2AqgPdl1ZTn4MqndY0zQjYdLVtmo9_-FSC4GaEsnekUWoL9Mt7UrGvIl0oXFKvALzJuXZhOYHjeE-KoVM6BJR8yPe_5qsGwAZeU-PxyJwmQET6s26Awcc0NEynZfgfcf2bm4CS6BzvBVXTzFSTPUu4_3xX4T7nRQfPJwv2SrVgnaIBFxmIFR0n4YIVwTP3bq8GcQK3mI7k9XcbvOxLLplC19IH98BMrWIQfLgEnzR3ZC4PX7Te8AqK459u7bYpLQKTUw81MwSbEdVLNDd1MtitsWbks7t192ogm7sAAVoskbuppLrQyzY-tW3p4Ezgbla41V4Ba9BfCw",
e: "AQAB"
};
var extractable = true;
Modified: trunk/LayoutTests/platform/mac/TestExpectations (284621 => 284622)
--- trunk/LayoutTests/platform/mac/TestExpectations 2021-10-21 17:34:01 UTC (rev 284621)
+++ trunk/LayoutTests/platform/mac/TestExpectations 2021-10-21 17:40:23 UTC (rev 284622)
@@ -2259,9 +2259,6 @@
[ Monterey ] imported/w3c/web-platform-tests/css/css-text-decor/text-underline-offset-variable.html [ Pass ImageOnlyFailure ]
[ Monterey ] imported/w3c/web-platform-tests/css/css-text-decor/text-underline-position-from-font-variable.html [ Pass ImageOnlyFailure ]
-# rdar://80333758 (REGRESSION: [ Monterey ] crypto/subtle/rsaes-pkcs1-v1_5-import-jwk-public-key-leading-zero.html is a constant timeout)
-[ Monterey ] crypto/subtle/rsaes-pkcs1-v1_5-import-jwk-public-key-leading-zero.html [ Timeout ]
-
# rdar://80340581 ([ Monterey ] http/tests/preload/onload_event.html is a flaky failure)
[ Monterey ] http/tests/preload/onload_event.html [ Pass Failure ]
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [284621] tags/Safari-612.3.2/
Title: [284621] tags/Safari-612.3.2/ Revision 284621 Author alanc...@apple.com Date 2021-10-21 10:34:01 -0700 (Thu, 21 Oct 2021) Log Message Tag Safari-612.3.2. Added Paths tags/Safari-612.3.2/ Diff ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [284620] branches/safari-612-branch/Source/WebCore
Title: [284620] branches/safari-612-branch/Source/WebCore
Revision 284620
Author alanc...@apple.com
Date 2021-10-21 10:32:06 -0700 (Thu, 21 Oct 2021)
Log Message
Cherry-pick r284201. rdar://problem/83670287
[AppleWin] Controls are not being rendered
https://bugs.webkit.org/show_bug.cgi?id=231769
Reviewed by Fujii Hironori.
Controls are not being rendered because the LocalWindowsContext destructor is no longer blitting the bitmap contents to the hdc.
The test in GraphicsContext::getWindowsContext needs to match the test in GraphicsContext::releaseWindowsContext.
* platform/graphics/win/GraphicsContextWin.cpp:
(WebCore::GraphicsContext::getWindowsContext):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@284201 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Modified Paths
branches/safari-612-branch/Source/WebCore/ChangeLog
branches/safari-612-branch/Source/WebCore/platform/graphics/win/GraphicsContextWin.cpp
Diff
Modified: branches/safari-612-branch/Source/WebCore/ChangeLog (284619 => 284620)
--- branches/safari-612-branch/Source/WebCore/ChangeLog 2021-10-21 17:30:45 UTC (rev 284619)
+++ branches/safari-612-branch/Source/WebCore/ChangeLog 2021-10-21 17:32:06 UTC (rev 284620)
@@ -1,3 +1,36 @@
+2021-10-21 Alan Coon
+
+Cherry-pick r284201. rdar://problem/83670287
+
+[AppleWin] Controls are not being rendered
+https://bugs.webkit.org/show_bug.cgi?id=231769
+
+
+Reviewed by Fujii Hironori.
+
+Controls are not being rendered because the LocalWindowsContext destructor is no longer blitting the bitmap contents to the hdc.
+The test in GraphicsContext::getWindowsContext needs to match the test in GraphicsContext::releaseWindowsContext.
+
+* platform/graphics/win/GraphicsContextWin.cpp:
+(WebCore::GraphicsContext::getWindowsContext):
+
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@284201 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2021-10-14 Per Arne Vollan
+
+[AppleWin] Controls are not being rendered
+https://bugs.webkit.org/show_bug.cgi?id=231769
+
+
+Reviewed by Fujii Hironori.
+
+Controls are not being rendered because the LocalWindowsContext destructor is no longer blitting the bitmap contents to the hdc.
+The test in GraphicsContext::getWindowsContext needs to match the test in GraphicsContext::releaseWindowsContext.
+
+* platform/graphics/win/GraphicsContextWin.cpp:
+(WebCore::GraphicsContext::getWindowsContext):
+
2021-10-19 Russell Epstein
Revert r283931. rdar://problem/83953710
Modified: branches/safari-612-branch/Source/WebCore/platform/graphics/win/GraphicsContextWin.cpp (284619 => 284620)
--- branches/safari-612-branch/Source/WebCore/platform/graphics/win/GraphicsContextWin.cpp 2021-10-21 17:30:45 UTC (rev 284619)
+++ branches/safari-612-branch/Source/WebCore/platform/graphics/win/GraphicsContextWin.cpp 2021-10-21 17:32:06 UTC (rev 284620)
@@ -56,7 +56,7 @@
HDC hdc = nullptr;
#if !USE(CAIRO)
hdc = deprecatedPrivateContext()->m_hdc;
-if (hdc && isInTransparencyLayer()) {
+if (hdc && !isInTransparencyLayer()) {
deprecatedPrivateContext()->flush();
deprecatedPrivateContext()->save();
return deprecatedPrivateContext()->m_hdc;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [284619] branches/safari-612-branch/Source
Title: [284619] branches/safari-612-branch/Source Revision 284619 Author alanc...@apple.com Date 2021-10-21 10:30:45 -0700 (Thu, 21 Oct 2021) Log Message Versioning. WebKit-7612.3.2 Modified Paths branches/safari-612-branch/Source/_javascript_Core/Configurations/Version.xcconfig branches/safari-612-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig branches/safari-612-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig branches/safari-612-branch/Source/WebCore/Configurations/Version.xcconfig branches/safari-612-branch/Source/WebCore/PAL/Configurations/Version.xcconfig branches/safari-612-branch/Source/WebInspectorUI/Configurations/Version.xcconfig branches/safari-612-branch/Source/WebKit/Configurations/Version.xcconfig branches/safari-612-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig Diff Modified: branches/safari-612-branch/Source/_javascript_Core/Configurations/Version.xcconfig (284618 => 284619) --- branches/safari-612-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2021-10-21 17:14:43 UTC (rev 284618) +++ branches/safari-612-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2021-10-21 17:30:45 UTC (rev 284619) @@ -23,7 +23,7 @@ MAJOR_VERSION = 612; MINOR_VERSION = 3; -TINY_VERSION = 1; +TINY_VERSION = 2; MICRO_VERSION = 0; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); Modified: branches/safari-612-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig (284618 => 284619) --- branches/safari-612-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig 2021-10-21 17:14:43 UTC (rev 284618) +++ branches/safari-612-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig 2021-10-21 17:30:45 UTC (rev 284619) @@ -23,7 +23,7 @@ MAJOR_VERSION = 612; MINOR_VERSION = 3; -TINY_VERSION = 1; +TINY_VERSION = 2; MICRO_VERSION = 0; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); Modified: branches/safari-612-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (284618 => 284619) --- branches/safari-612-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig 2021-10-21 17:14:43 UTC (rev 284618) +++ branches/safari-612-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig 2021-10-21 17:30:45 UTC (rev 284619) @@ -23,7 +23,7 @@ MAJOR_VERSION = 612; MINOR_VERSION = 3; -TINY_VERSION = 1; +TINY_VERSION = 2; MICRO_VERSION = 0; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); Modified: branches/safari-612-branch/Source/WebCore/Configurations/Version.xcconfig (284618 => 284619) --- branches/safari-612-branch/Source/WebCore/Configurations/Version.xcconfig 2021-10-21 17:14:43 UTC (rev 284618) +++ branches/safari-612-branch/Source/WebCore/Configurations/Version.xcconfig 2021-10-21 17:30:45 UTC (rev 284619) @@ -23,7 +23,7 @@ MAJOR_VERSION = 612; MINOR_VERSION = 3; -TINY_VERSION = 1; +TINY_VERSION = 2; MICRO_VERSION = 0; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); Modified: branches/safari-612-branch/Source/WebCore/PAL/Configurations/Version.xcconfig (284618 => 284619) --- branches/safari-612-branch/Source/WebCore/PAL/Configurations/Version.xcconfig 2021-10-21 17:14:43 UTC (rev 284618) +++ branches/safari-612-branch/Source/WebCore/PAL/Configurations/Version.xcconfig 2021-10-21 17:30:45 UTC (rev 284619) @@ -23,7 +23,7 @@ MAJOR_VERSION = 612; MINOR_VERSION = 3; -TINY_VERSION = 1; +TINY_VERSION = 2; MICRO_VERSION = 0; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); Modified: branches/safari-612-branch/Source/WebInspectorUI/Configurations/Version.xcconfig (284618 => 284619) --- branches/safari-612-branch/Source/WebInspectorUI/Configurations/Version.xcconfig 2021-10-21 17:14:43 UTC (rev 284618) +++ branches/safari-612-branch/Source/WebInspectorUI/Configurations/Version.xcconfig 2021-10-21 17:30:45 UTC (rev 284619) @@ -1,6 +1,6 @@ MAJOR_VERSION = 612; MINOR_VERSION = 3; -TINY_VERSION = 1; +TINY_VERSION = 2; MICRO_VERSION = 0; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); Modified: branches/safari-612-branch/Source/WebKit/Configurations/Version.xcconfig (284618 => 284619) --- branches/safari-612-branch/Source/WebKit/Configurations/Version.xcconfig 2021-10-21 17:14:43 UTC (rev 284618) +++ branches/safari-612-branch/Source/WebKit/Configurations/Version.xcconfig 2021-10-21 17:30:45 UTC (rev 284619) @@ -23,7 +23,7 @@ MAJOR_VERSION = 612; MINOR_VERSION = 3; -TINY_VERSION = 1; +TINY_VERSION = 2; MICRO_VERSION = 0; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); Modified: branches/safari-612-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig (284618 => 284619) --- branches/safari-612-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig 2021-10-21 17:14:43 UTC
[webkit-changes] [284618] trunk/Source/WTF
Title: [284618] trunk/Source/WTF Revision 284618 Author akeer...@apple.com Date 2021-10-21 10:14:43 -0700 (Thu, 21 Oct 2021) Log Message [Cocoa] Enable 'accent-color' by default https://bugs.webkit.org/show_bug.cgi?id=232032 rdar://84474404 Reviewed by Wenson Hsieh. * Scripts/Preferences/WebPreferencesExperimental.yaml: Modified Paths trunk/Source/WTF/ChangeLog trunk/Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml Diff Modified: trunk/Source/WTF/ChangeLog (284617 => 284618) --- trunk/Source/WTF/ChangeLog 2021-10-21 17:12:27 UTC (rev 284617) +++ trunk/Source/WTF/ChangeLog 2021-10-21 17:14:43 UTC (rev 284618) @@ -1,3 +1,13 @@ +2021-10-21 Aditya Keerthi + +[Cocoa] Enable 'accent-color' by default +https://bugs.webkit.org/show_bug.cgi?id=232032 +rdar://84474404 + +Reviewed by Wenson Hsieh. + +* Scripts/Preferences/WebPreferencesExperimental.yaml: + 2021-10-21 Chris Lord [WPE][GTK] Enable smooth scrolling by default Modified: trunk/Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml (284617 => 284618) --- trunk/Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml 2021-10-21 17:12:27 UTC (rev 284617) +++ trunk/Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml 2021-10-21 17:14:43 UTC (rev 284618) @@ -32,11 +32,11 @@ humanReadableDescription: "Enable accent-color CSS property" defaultValue: WebKitLegacy: - default: false + default: true WebKit: - default: false + default: true WebCore: - default: false + default: true AccessHandleEnabled: type: bool ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [284617] trunk/Source/WebKit
Title: [284617] trunk/Source/WebKit
Revision 284617
Author commit-qu...@webkit.org
Date 2021-10-21 10:12:27 -0700 (Thu, 21 Oct 2021)
Log Message
Followup: Fix crash when calling setUsernameForLocalCredentialWithID
https://bugs.webkit.org/show_bug.cgi?id=232057
Patch by John Pascoe on 2021-10-21
Reviewed by David Kilzer.
Follow up to address David's comment.
* UIProcess/API/Cocoa/_WKWebAuthenticationPanel.mm:
(getAllLocalAuthenticatorCredentialsImpl):
(+[_WKWebAuthenticationPanel deleteLocalAuthenticatorCredentialWithID:]):
(+[_WKWebAuthenticationPanel setUsernameForLocalCredentialWithID:username:]):
- Use
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/API/Cocoa/_WKWebAuthenticationPanel.mm
Diff
Modified: trunk/Source/WebKit/ChangeLog (284616 => 284617)
--- trunk/Source/WebKit/ChangeLog 2021-10-21 17:04:08 UTC (rev 284616)
+++ trunk/Source/WebKit/ChangeLog 2021-10-21 17:12:27 UTC (rev 284617)
@@ -1,3 +1,19 @@
+2021-10-21 John Pascoe
+
+Followup: Fix crash when calling setUsernameForLocalCredentialWithID
+https://bugs.webkit.org/show_bug.cgi?id=232057
+
+
+Reviewed by David Kilzer.
+
+Follow up to address David's comment.
+
+* UIProcess/API/Cocoa/_WKWebAuthenticationPanel.mm:
+(getAllLocalAuthenticatorCredentialsImpl):
+(+[_WKWebAuthenticationPanel deleteLocalAuthenticatorCredentialWithID:]):
+(+[_WKWebAuthenticationPanel setUsernameForLocalCredentialWithID:username:]):
+- Use
+
2021-10-21 Chris Dumez
WebKit should process-swap for initial navigation of a popup if it has no opener
Modified: trunk/Source/WebKit/UIProcess/API/Cocoa/_WKWebAuthenticationPanel.mm (284616 => 284617)
--- trunk/Source/WebKit/UIProcess/API/Cocoa/_WKWebAuthenticationPanel.mm 2021-10-21 17:04:08 UTC (rev 284616)
+++ trunk/Source/WebKit/UIProcess/API/Cocoa/_WKWebAuthenticationPanel.mm 2021-10-21 17:12:27 UTC (rev 284617)
@@ -57,6 +57,7 @@
#import
#import
#import
+#import
#import
#import
@@ -214,11 +215,11 @@
{
auto query = adoptNS([[NSMutableDictionary alloc] init]);
[query setDictionary:@{
-(__bridge id)kSecClass: (__bridge id)kSecClassKey,
-(__bridge id)kSecAttrKeyClass: (__bridge id)kSecAttrKeyClassPrivate,
+(__bridge id)kSecClass: bridge_id_cast(kSecClassKey),
+(__bridge id)kSecAttrKeyClass: bridge_id_cast(kSecAttrKeyClassPrivate),
(__bridge id)kSecAttrAccessGroup: accessGroup,
(__bridge id)kSecReturnAttributes: @YES,
-(__bridge id)kSecMatchLimit: (__bridge id)kSecMatchLimitAll,
+(__bridge id)kSecMatchLimit: bridge_id_cast(kSecMatchLimitAll),
(__bridge id)kSecUseDataProtectionKeychain: @YES
}];
updateQueryIfNecessary(query.get());
@@ -231,7 +232,7 @@
auto result = adoptNS([[NSMutableArray alloc] init]);
for (NSDictionary *attributes in (NSArray *)attributesArrayRef) {
-auto decodedResponse = cbor::CBORReader::read(vectorFromNSData(attributes[(__bridge id)kSecAttrApplicationTag]));
+auto decodedResponse = cbor::CBORReader::read(vectorFromNSData(attributes[bridge_id_cast(kSecAttrApplicationTag)]));
if (!decodedResponse || !decodedResponse->isMap()) {
ASSERT_NOT_REACHED();
return nullptr;
@@ -247,8 +248,8 @@
[result addObject:@{
_WKLocalAuthenticatorCredentialNameKey: username,
-_WKLocalAuthenticatorCredentialIDKey: attributes[(__bridge id)kSecAttrApplicationLabel],
-_WKLocalAuthenticatorCredentialRelyingPartyIDKey: attributes[(__bridge id)kSecAttrLabel]
+_WKLocalAuthenticatorCredentialIDKey: attributes[bridge_id_cast(kSecAttrApplicationLabel)],
+_WKLocalAuthenticatorCredentialRelyingPartyIDKey: attributes[bridge_id_cast(kSecAttrLabel)]
}];
}
@@ -279,7 +280,7 @@
#if ENABLE(WEB_AUTHN)
auto deleteQuery = adoptNS([[NSMutableDictionary alloc] init]);
[deleteQuery setDictionary:@{
-(__bridge id)kSecClass: (__bridge id)kSecClassKey,
+(__bridge id)kSecClass: bridge_id_cast(kSecClassKey),
(__bridge id)kSecAttrApplicationLabel: credentialID,
(__bridge id)kSecUseDataProtectionKeychain: @YES
}];
@@ -301,10 +302,10 @@
#if ENABLE(WEB_AUTHN)
auto query = adoptNS([[NSMutableDictionary alloc] init]);
[query setDictionary:@{
-(__bridge id)kSecClass: (__bridge id)kSecClassKey,
+(__bridge id)kSecClass: bridge_id_cast(kSecClassKey),
(__bridge id)kSecReturnAttributes: @YES,
(__bridge id)kSecAttrApplicationLabel: credentialID,
-(__bridge id)kSecReturnPersistentRef : (__bridge id)kCFBooleanTrue,
+(__bridge id)kSecReturnPersistentRef : bridge_id_cast(kCFBooleanTrue),
(__bridge id)kSecUseDataProtectionKeychain: @YES
}];
updateQueryIfNecessary(query.get());
@@ -316,7 +317,7 @@
return;
}
NSDictionary
[webkit-changes] [284616] trunk/LayoutTests
Title: [284616] trunk/LayoutTests Revision 284616 Author ayumi_koj...@apple.com Date 2021-10-21 10:04:08 -0700 (Thu, 21 Oct 2021) Log Message Regression(r284439): [ iPad ] fast/canvas/canvas-createPattern-video-loading.html and imported/w3c/web-platform-tests/html/canvas/element/manual/imagebitmap/canvas-createImageBitmap-video-resize.html are failing. https://bugs.webkit.org/show_bug.cgi?id=232090 Unreviewed test gardening. * platform/ipad/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/ipad/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (284615 => 284616) --- trunk/LayoutTests/ChangeLog 2021-10-21 17:03:51 UTC (rev 284615) +++ trunk/LayoutTests/ChangeLog 2021-10-21 17:04:08 UTC (rev 284616) @@ -1,3 +1,12 @@ +2021-10-21 Ayumi Kojima + +Regression(r284439): [ iPad ] fast/canvas/canvas-createPattern-video-loading.html and imported/w3c/web-platform-tests/html/canvas/element/manual/imagebitmap/canvas-createImageBitmap-video-resize.html are failing. +https://bugs.webkit.org/show_bug.cgi?id=232090 + +Unreviewed test gardening. + +* platform/ipad/TestExpectations: + 2021-10-21 Tyler Wilcock AX: Remove redundant insert of autofill button child in AccessibilityRenderObject::addTextFieldChildren Modified: trunk/LayoutTests/platform/ipad/TestExpectations (284615 => 284616) --- trunk/LayoutTests/platform/ipad/TestExpectations 2021-10-21 17:03:51 UTC (rev 284615) +++ trunk/LayoutTests/platform/ipad/TestExpectations 2021-10-21 17:04:08 UTC (rev 284616) @@ -105,6 +105,7 @@ webkit.org/b/228663 fast/canvas/canvas-color-space-display-p3.html [ ImageOnlyFailure ] webkit.org/b/232090 fast/canvas/canvas-createPattern-video-loading.html [ Failure ] +webkit.org/b/232090 imported/w3c/web-platform-tests/html/canvas/element/manual/imagebitmap/canvas-createImageBitmap-video-resize.html [ Failure ] webkit.org/b/230419 platform/ipad/media/modern-media-controls/media-documents/media-document-video-ios-sizing.html [ Pass Timeout Crash ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [284615] tags/Safari-612.2.9.1.30/
Title: [284615] tags/Safari-612.2.9.1.30/ Revision 284615 Author alanc...@apple.com Date 2021-10-21 10:03:51 -0700 (Thu, 21 Oct 2021) Log Message Tag Safari-612.2.9.1.30. Added Paths tags/Safari-612.2.9.1.30/ Diff ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [284614] branches/safari-612.2.9.1-branch/Source/WebCore
Title: [284614] branches/safari-612.2.9.1-branch/Source/WebCore
Revision 284614
Author alanc...@apple.com
Date 2021-10-21 09:58:50 -0700 (Thu, 21 Oct 2021)
Log Message
Cherry-pick r284201. rdar://problem/83670287
[AppleWin] Controls are not being rendered
https://bugs.webkit.org/show_bug.cgi?id=231769
Reviewed by Fujii Hironori.
Controls are not being rendered because the LocalWindowsContext destructor is no longer blitting the bitmap contents to the hdc.
The test in GraphicsContext::getWindowsContext needs to match the test in GraphicsContext::releaseWindowsContext.
* platform/graphics/win/GraphicsContextWin.cpp:
(WebCore::GraphicsContext::getWindowsContext):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@284201 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Modified Paths
branches/safari-612.2.9.1-branch/Source/WebCore/ChangeLog
branches/safari-612.2.9.1-branch/Source/WebCore/platform/graphics/win/GraphicsContextWin.cpp
Diff
Modified: branches/safari-612.2.9.1-branch/Source/WebCore/ChangeLog (284613 => 284614)
--- branches/safari-612.2.9.1-branch/Source/WebCore/ChangeLog 2021-10-21 16:56:39 UTC (rev 284613)
+++ branches/safari-612.2.9.1-branch/Source/WebCore/ChangeLog 2021-10-21 16:58:50 UTC (rev 284614)
@@ -1,3 +1,36 @@
+2021-10-21 Alan Coon
+
+Cherry-pick r284201. rdar://problem/83670287
+
+[AppleWin] Controls are not being rendered
+https://bugs.webkit.org/show_bug.cgi?id=231769
+
+
+Reviewed by Fujii Hironori.
+
+Controls are not being rendered because the LocalWindowsContext destructor is no longer blitting the bitmap contents to the hdc.
+The test in GraphicsContext::getWindowsContext needs to match the test in GraphicsContext::releaseWindowsContext.
+
+* platform/graphics/win/GraphicsContextWin.cpp:
+(WebCore::GraphicsContext::getWindowsContext):
+
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@284201 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2021-10-14 Per Arne Vollan
+
+[AppleWin] Controls are not being rendered
+https://bugs.webkit.org/show_bug.cgi?id=231769
+
+
+Reviewed by Fujii Hironori.
+
+Controls are not being rendered because the LocalWindowsContext destructor is no longer blitting the bitmap contents to the hdc.
+The test in GraphicsContext::getWindowsContext needs to match the test in GraphicsContext::releaseWindowsContext.
+
+* platform/graphics/win/GraphicsContextWin.cpp:
+(WebCore::GraphicsContext::getWindowsContext):
+
2021-10-02 Alan Coon
Cherry-pick r283444. rdar://problem/83784764
Modified: branches/safari-612.2.9.1-branch/Source/WebCore/platform/graphics/win/GraphicsContextWin.cpp (284613 => 284614)
--- branches/safari-612.2.9.1-branch/Source/WebCore/platform/graphics/win/GraphicsContextWin.cpp 2021-10-21 16:56:39 UTC (rev 284613)
+++ branches/safari-612.2.9.1-branch/Source/WebCore/platform/graphics/win/GraphicsContextWin.cpp 2021-10-21 16:58:50 UTC (rev 284614)
@@ -56,7 +56,7 @@
HDC hdc = nullptr;
#if !USE(CAIRO)
hdc = deprecatedPrivateContext()->m_hdc;
-if (hdc && isInTransparencyLayer()) {
+if (hdc && !isInTransparencyLayer()) {
deprecatedPrivateContext()->flush();
deprecatedPrivateContext()->save();
return deprecatedPrivateContext()->m_hdc;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [284613] branches/safari-612.2.9.1-branch/Source
Title: [284613] branches/safari-612.2.9.1-branch/Source Revision 284613 Author alanc...@apple.com Date 2021-10-21 09:56:39 -0700 (Thu, 21 Oct 2021) Log Message Versioning. WebKit-7612.2.9.1.30 Modified Paths branches/safari-612.2.9.1-branch/Source/_javascript_Core/Configurations/Version.xcconfig branches/safari-612.2.9.1-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig branches/safari-612.2.9.1-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig branches/safari-612.2.9.1-branch/Source/WebCore/Configurations/Version.xcconfig branches/safari-612.2.9.1-branch/Source/WebCore/PAL/Configurations/Version.xcconfig branches/safari-612.2.9.1-branch/Source/WebInspectorUI/Configurations/Version.xcconfig branches/safari-612.2.9.1-branch/Source/WebKit/Configurations/Version.xcconfig branches/safari-612.2.9.1-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig Diff Modified: branches/safari-612.2.9.1-branch/Source/_javascript_Core/Configurations/Version.xcconfig (284612 => 284613) --- branches/safari-612.2.9.1-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2021-10-21 16:49:44 UTC (rev 284612) +++ branches/safari-612.2.9.1-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2021-10-21 16:56:39 UTC (rev 284613) @@ -25,7 +25,7 @@ MINOR_VERSION = 2; TINY_VERSION = 9; MICRO_VERSION = 1; -NANO_VERSION = 22; +NANO_VERSION = 30; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-612.2.9.1-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig (284612 => 284613) --- branches/safari-612.2.9.1-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig 2021-10-21 16:49:44 UTC (rev 284612) +++ branches/safari-612.2.9.1-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig 2021-10-21 16:56:39 UTC (rev 284613) @@ -25,7 +25,7 @@ MINOR_VERSION = 2; TINY_VERSION = 9; MICRO_VERSION = 1; -NANO_VERSION = 22; +NANO_VERSION = 30; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-612.2.9.1-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (284612 => 284613) --- branches/safari-612.2.9.1-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig 2021-10-21 16:49:44 UTC (rev 284612) +++ branches/safari-612.2.9.1-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig 2021-10-21 16:56:39 UTC (rev 284613) @@ -25,7 +25,7 @@ MINOR_VERSION = 2; TINY_VERSION = 9; MICRO_VERSION = 1; -NANO_VERSION = 22; +NANO_VERSION = 30; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-612.2.9.1-branch/Source/WebCore/Configurations/Version.xcconfig (284612 => 284613) --- branches/safari-612.2.9.1-branch/Source/WebCore/Configurations/Version.xcconfig 2021-10-21 16:49:44 UTC (rev 284612) +++ branches/safari-612.2.9.1-branch/Source/WebCore/Configurations/Version.xcconfig 2021-10-21 16:56:39 UTC (rev 284613) @@ -25,7 +25,7 @@ MINOR_VERSION = 2; TINY_VERSION = 9; MICRO_VERSION = 1; -NANO_VERSION = 22; +NANO_VERSION = 30; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-612.2.9.1-branch/Source/WebCore/PAL/Configurations/Version.xcconfig (284612 => 284613) --- branches/safari-612.2.9.1-branch/Source/WebCore/PAL/Configurations/Version.xcconfig 2021-10-21 16:49:44 UTC (rev 284612) +++ branches/safari-612.2.9.1-branch/Source/WebCore/PAL/Configurations/Version.xcconfig 2021-10-21 16:56:39 UTC (rev 284613) @@ -25,7 +25,7 @@ MINOR_VERSION = 2; TINY_VERSION = 9; MICRO_VERSION = 1; -NANO_VERSION = 22; +NANO_VERSION = 30; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-612.2.9.1-branch/Source/WebInspectorUI/Configurations/Version.xcconfig (284612 => 284613) --- branches/safari-612.2.9.1-branch/Source/WebInspectorUI/Configurations/Version.xcconfig 2021-10-21 16:49:44 UTC (rev 284612) +++ branches/safari-612.2.9.1-branch/Source/WebInspectorUI/Configurations/Version.xcconfig 2021-10-21 16:56:39 UTC (rev 284613) @@ -2,7 +2,7 @@ MINOR_VERSION = 2; TINY_VERSION = 9; MICRO_VERSION = 1; -NANO_VERSION = 22; +NANO_VERSION = 30; FULL_VERSION =
[webkit-changes] [284612] trunk
Title: [284612] trunk
Revision 284612
Author commit-qu...@webkit.org
Date 2021-10-21 09:49:44 -0700 (Thu, 21 Oct 2021)
Log Message
AX: Remove redundant insert of autofill button child in AccessibilityRenderObject::addTextFieldChildren
https://bugs.webkit.org/show_bug.cgi?id=232033
Patch by Tyler Wilcock on 2021-10-21
Reviewed by Chris Fleizach.
Source/WebCore:
Autofill buttons are represented in the DOM, so there's no reason
to also insert it in AccessibilityRenderObject::addTextFieldChildren.
This results in duplicate objects for this button in the AX tree.
* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::addTextFieldChildren):
Remove redundant insertion of autofill button element into the
accessibility tree.
LayoutTests:
* accessibility/auto-fill-crash-expected.txt:
* accessibility/auto-fill-crash.html:
* platform/glib/accessibility/auto-fill-crash-expected.txt:
Expect one less child because we no longer insert a redundant button
into the accessibility tree. Also add an expectation confirming the
autofill button is actually a part of the accessibility tree.
* platform/win/accessibility/auto-fill-crash-expected.txt: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/accessibility/auto-fill-crash-expected.txt
trunk/LayoutTests/accessibility/auto-fill-crash.html
trunk/LayoutTests/platform/glib/accessibility/auto-fill-crash-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/accessibility/AccessibilityRenderObject.cpp
Added Paths
trunk/LayoutTests/platform/win/accessibility/auto-fill-crash-expected.txt
Diff
Modified: trunk/LayoutTests/ChangeLog (284611 => 284612)
--- trunk/LayoutTests/ChangeLog 2021-10-21 16:49:15 UTC (rev 284611)
+++ trunk/LayoutTests/ChangeLog 2021-10-21 16:49:44 UTC (rev 284612)
@@ -1,3 +1,18 @@
+2021-10-21 Tyler Wilcock
+
+AX: Remove redundant insert of autofill button child in AccessibilityRenderObject::addTextFieldChildren
+https://bugs.webkit.org/show_bug.cgi?id=232033
+
+Reviewed by Chris Fleizach.
+
+* accessibility/auto-fill-crash-expected.txt:
+* accessibility/auto-fill-crash.html:
+* platform/glib/accessibility/auto-fill-crash-expected.txt:
+Expect one less child because we no longer insert a redundant button
+into the accessibility tree. Also add an expectation confirming the
+autofill button is actually a part of the accessibility tree.
+* platform/win/accessibility/auto-fill-crash-expected.txt: Added.
+
2021-10-21 Chris Dumez
Unreviewed, drop test from TestExpectations that no longer exists.
Modified: trunk/LayoutTests/accessibility/auto-fill-crash-expected.txt (284611 => 284612)
--- trunk/LayoutTests/accessibility/auto-fill-crash-expected.txt 2021-10-21 16:49:15 UTC (rev 284611)
+++ trunk/LayoutTests/accessibility/auto-fill-crash-expected.txt 2021-10-21 16:49:44 UTC (rev 284612)
@@ -4,8 +4,9 @@
On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
-PASS accessibilityController.accessibleElementById('textfield').childrenCount is 3
-PASS accessibilityController.accessibleElementById('textfield').childrenCount is 1
+PASS textFieldAxObject.childrenCount is 2
+PASS textFieldAxObject.childAtIndex(childrenCountExpected - 1).description is 'AXDescription: contact info AutoFill'
+PASS textFieldAxObject.childrenCount is 1
PASS successfullyParsed is true
TEST COMPLETE
Modified: trunk/LayoutTests/accessibility/auto-fill-crash.html (284611 => 284612)
--- trunk/LayoutTests/accessibility/auto-fill-crash.html 2021-10-21 16:49:15 UTC (rev 284611)
+++ trunk/LayoutTests/accessibility/auto-fill-crash.html 2021-10-21 16:49:44 UTC (rev 284612)
@@ -17,14 +17,24 @@
if (window.accessibilityController) {
var axTextField = accessibilityController.accessibleElementById("textfield");
-var childrenCountExpected = accessibilityController.platformName == "atk" ? "2" : "3";
+var childrenCountExpected = accessibilityController.platformName == "atk" ? "1" : "2";
window.internals.setShowAutoFillButton(document.getElementById("textfield"), "Contacts");
-shouldBe("accessibilityController.accessibleElementById('textfield').childrenCount", childrenCountExpected);
+var textFieldAxObject = accessibilityController.accessibleElementById('textfield');
+shouldBe("textFieldAxObject.childrenCount", childrenCountExpected);
+// Verify the autofill button is represented in the accessibility tree.
+shouldBe("textFieldAxObject.childAtIndex(childrenCountExpected - 1).description", "'AXDescription: contact info AutoFill'");
+var platform = accessibilityController.platformName;
+// Windows expects 2 children.
+childrenCountExpected = "2";
+if (platform == "mac" || platform == "ios")
+childrenCountExpected = "1"
+else if (platform == "atk")
+
[webkit-changes] [284611] trunk/LayoutTests
Title: [284611] trunk/LayoutTests Revision 284611 Author cdu...@apple.com Date 2021-10-21 09:49:15 -0700 (Thu, 21 Oct 2021) Log Message Unreviewed, drop test from TestExpectations that no longer exists. * platform/ios-wk2/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/ios-wk2/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (284610 => 284611) --- trunk/LayoutTests/ChangeLog 2021-10-21 16:47:49 UTC (rev 284610) +++ trunk/LayoutTests/ChangeLog 2021-10-21 16:49:15 UTC (rev 284611) @@ -1,5 +1,11 @@ 2021-10-21 Chris Dumez +Unreviewed, drop test from TestExpectations that no longer exists. + +* platform/ios-wk2/TestExpectations: + +2021-10-21 Chris Dumez + WebKit should process-swap for initial navigation of a popup if it has no opener https://bugs.webkit.org/show_bug.cgi?id=231990 Modified: trunk/LayoutTests/platform/ios-wk2/TestExpectations (284610 => 284611) --- trunk/LayoutTests/platform/ios-wk2/TestExpectations 2021-10-21 16:47:49 UTC (rev 284610) +++ trunk/LayoutTests/platform/ios-wk2/TestExpectations 2021-10-21 16:49:15 UTC (rev 284611) @@ -2021,8 +2021,6 @@ webkit.org/b/228164 [ Debug ] http/tests/resourceLoadStatistics/website-data-removal-for-site-with-user-interaction.html [ Pass Crash ] -webkit.org/b/231586 http/tests/resourceLoadStatistics/switch-session-on-navigation-to-prevalent-without-interaction.py [ Pass Failure ] - webkit.org/b/216492 [ Debug ] imported/w3c/web-platform-tests/selection/extend-20.html [ Slow ] webkit.org/b/231299 [ Debug ] imported/w3c/web-platform-tests/selection/extend-00.html [ Slow ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [284610] trunk
Title: [284610] trunk Revision 284610 Author cdu...@apple.com Date 2021-10-21 09:47:49 -0700 (Thu, 21 Oct 2021) Log Message WebKit should process-swap for initial navigation of a popup if it has no opener https://bugs.webkit.org/show_bug.cgi?id=231990 Reviewed by Brent Fulgham. LayoutTests/imported/w3c: * web-platform-tests/html/cross-origin-opener-policy/coop-coep-sandbox.https-expected.txt: * web-platform-tests/html/cross-origin-opener-policy/coop-sandbox.https-expected.txt: Rebaseline tests due to minor logging differences. Source/WebKit: WebKit should process-swap for initial navigation of a popup if it has no opener, even if the navigation is same-site. Swapping process is not Web-observable here since there is no opener relationship. However, swapping processes has benefits here since we don't want to end up with too many tabs sharing the same process. This impacts Google Drive where double-clicking a document will open Google Docs in a new tab and in the same WebProcess as Google Drive. No new tests, updated existing API tests and this is not Web-observable. * Shared/FrameInfoData.cpp: (WebKit::FrameInfoData::encode const): (WebKit::FrameInfoData::decode): * Shared/FrameInfoData.h: * Shared/LoadParameters.cpp: (WebKit::LoadParameters::encode const): (WebKit::LoadParameters::decode): * Shared/LoadParameters.h: * Shared/NavigationActionData.cpp: (WebKit::NavigationActionData::encode const): (WebKit::NavigationActionData::decode): * Shared/NavigationActionData.h: * UIProcess/API/APINavigation.h: (API::Navigation::effectiveSandboxFlags const): * UIProcess/Cocoa/UIDelegate.mm: (WebKit::UIDelegate::UIClient::decidePolicyForUserMediaPermissionRequest): * UIProcess/ProvisionalPageProxy.cpp: (WebKit::ProvisionalPageProxy::cancel): * UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::loadRequestWithNavigationShared): (WebKit::WebPageProxy::loadSimulatedRequest): (WebKit::WebPageProxy::receivedNavigationPolicyDecision): (WebKit::WebPageProxy::decidePolicyForNavigationAction): * UIProcess/WebPageProxy.h: * UIProcess/WebProcessPool.cpp: (WebKit::WebProcessPool::processForNavigation): (WebKit::WebProcessPool::processForNavigationInternal): * UIProcess/WebProcessPool.h: * WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp: (WebKit::WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction): * WebProcess/WebPage/WebFrame.cpp: (WebKit::WebFrame::info const): * WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::loadRequest): Tools: * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm: (-[PSONUIDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]): (-[PSONUIDelegate webViewDidClose:]): Updated existing API tests to reflect behavior change. Also extend an API test to make sure that a popup opened by JS can still close itself via JS (by calling window.close()), even in the case where we process swap. * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: (WTR::InjectedBundle::didReceiveMessageToPage): (WTR::InjectedBundle::outputText): * WebKitTestRunner/InjectedBundle/InjectedBundle.h: * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: (WTR::InjectedBundlePage::dump): * WebKitTestRunner/TestController.cpp: (WTR::TestController::createOtherPage): (WTR::TestController::didReceivePageMessageFromInjectedBundle): * WebKitTestRunner/TestInvocation.cpp: (WTR::TestInvocation::didReceiveMessageFromInjectedBundle): We have some tests that open a new popup with 'noopener' and the popup would be the one to call `testRunner.notifyDone()`. This used to work fine when the popup would end up in the same WebProcess because the injected bundle would know which page is the main test page and use that one. However, now that we process-swap, the popup page would think it is the main test page and try to dump its own output. However, the UIProcess wasn't listening for messages from auxiliary pages' injected bundles. The UIProcess now listens for those messages and asks the main test page to dump its output when an auxiliary page in another process says the test is done. LayoutTests: * fast/dom/open-and-close-by-DOM.html: The test is relying on testRunner.windowCount(), which is only able to count windows inside the current WebProcess. Add `rel=opener` to the link so that the new window keep opening in the same process, so that `testRunner.windowCount()` actually keeps working as expected. I added an API test to cover to make sure that windows opened by DOM can still close themselves in the case where we swap processes. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/fast/dom/open-and-close-by-DOM.html trunk/LayoutTests/imported/w3c/ChangeLog trunk/LayoutTests/imported/w3c/web-platform-tests/html/cross-origin-opener-policy/coep-blob-popup.https-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/html/cross-origin-opener-policy/coop-coep-sandbox.https-expected.txt
[webkit-changes] [284609] trunk/LayoutTests
Title: [284609] trunk/LayoutTests Revision 284609 Author ayumi_koj...@apple.com Date 2021-10-21 09:34:16 -0700 (Thu, 21 Oct 2021) Log Message Regression(r284439): [ iPad ] fast/canvas/canvas-createPattern-video-loading.html is failing. https://bugs.webkit.org/show_bug.cgi?id=232090 Unreviewed test gardening. * platform/ipad/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/ipad/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (284608 => 284609) --- trunk/LayoutTests/ChangeLog 2021-10-21 16:32:25 UTC (rev 284608) +++ trunk/LayoutTests/ChangeLog 2021-10-21 16:34:16 UTC (rev 284609) @@ -1,3 +1,12 @@ +2021-10-21 Ayumi Kojima + +Regression(r284439): [ iPad ] fast/canvas/canvas-createPattern-video-loading.html is failing. +https://bugs.webkit.org/show_bug.cgi?id=232090 + +Unreviewed test gardening. + +* platform/ipad/TestExpectations: + 2021-10-21 Antoine Quint CSSPropertyZoom needs wrapper that ensures it's always blended into a positive value. Modified: trunk/LayoutTests/platform/ipad/TestExpectations (284608 => 284609) --- trunk/LayoutTests/platform/ipad/TestExpectations 2021-10-21 16:32:25 UTC (rev 284608) +++ trunk/LayoutTests/platform/ipad/TestExpectations 2021-10-21 16:34:16 UTC (rev 284609) @@ -104,6 +104,8 @@ webkit.org/b/228663 fast/canvas/canvas-color-space-display-p3.html [ ImageOnlyFailure ] +webkit.org/b/232090 fast/canvas/canvas-createPattern-video-loading.html [ Failure ] + webkit.org/b/230419 platform/ipad/media/modern-media-controls/media-documents/media-document-video-ios-sizing.html [ Pass Timeout Crash ] webkit.org/b/231609 imported/w3c/web-platform-tests/webmessaging/MessagePort_onmessage_start.any.worker.html [ Pass Failure ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [284608] branches/safari-613.1.6-branch/Source
Title: [284608] branches/safari-613.1.6-branch/Source Revision 284608 Author kocsen_ch...@apple.com Date 2021-10-21 09:32:25 -0700 (Thu, 21 Oct 2021) Log Message Versioning. WebKit-7613.1.6.1 Modified Paths branches/safari-613.1.6-branch/Source/_javascript_Core/Configurations/Version.xcconfig branches/safari-613.1.6-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig branches/safari-613.1.6-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig branches/safari-613.1.6-branch/Source/WebCore/Configurations/Version.xcconfig branches/safari-613.1.6-branch/Source/WebCore/PAL/Configurations/Version.xcconfig branches/safari-613.1.6-branch/Source/WebInspectorUI/Configurations/Version.xcconfig branches/safari-613.1.6-branch/Source/WebKit/Configurations/Version.xcconfig branches/safari-613.1.6-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig Diff Modified: branches/safari-613.1.6-branch/Source/_javascript_Core/Configurations/Version.xcconfig (284607 => 284608) --- branches/safari-613.1.6-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2021-10-21 16:31:19 UTC (rev 284607) +++ branches/safari-613.1.6-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2021-10-21 16:32:25 UTC (rev 284608) @@ -24,9 +24,9 @@ MAJOR_VERSION = 613; MINOR_VERSION = 1; TINY_VERSION = 6; -MICRO_VERSION = 0; +MICRO_VERSION = 1; NANO_VERSION = 0; -FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); +FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION)); Modified: branches/safari-613.1.6-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig (284607 => 284608) --- branches/safari-613.1.6-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig 2021-10-21 16:31:19 UTC (rev 284607) +++ branches/safari-613.1.6-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig 2021-10-21 16:32:25 UTC (rev 284608) @@ -24,9 +24,9 @@ MAJOR_VERSION = 613; MINOR_VERSION = 1; TINY_VERSION = 6; -MICRO_VERSION = 0; +MICRO_VERSION = 1; NANO_VERSION = 0; -FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); +FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION)); Modified: branches/safari-613.1.6-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (284607 => 284608) --- branches/safari-613.1.6-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig 2021-10-21 16:31:19 UTC (rev 284607) +++ branches/safari-613.1.6-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig 2021-10-21 16:32:25 UTC (rev 284608) @@ -24,9 +24,9 @@ MAJOR_VERSION = 613; MINOR_VERSION = 1; TINY_VERSION = 6; -MICRO_VERSION = 0; +MICRO_VERSION = 1; NANO_VERSION = 0; -FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); +FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION)); Modified: branches/safari-613.1.6-branch/Source/WebCore/Configurations/Version.xcconfig (284607 => 284608) --- branches/safari-613.1.6-branch/Source/WebCore/Configurations/Version.xcconfig 2021-10-21 16:31:19 UTC (rev 284607) +++ branches/safari-613.1.6-branch/Source/WebCore/Configurations/Version.xcconfig 2021-10-21 16:32:25 UTC (rev 284608) @@ -24,9 +24,9 @@ MAJOR_VERSION = 613; MINOR_VERSION = 1; TINY_VERSION = 6; -MICRO_VERSION = 0; +MICRO_VERSION = 1; NANO_VERSION = 0; -FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); +FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION)); Modified: branches/safari-613.1.6-branch/Source/WebCore/PAL/Configurations/Version.xcconfig (284607 => 284608) --- branches/safari-613.1.6-branch/Source/WebCore/PAL/Configurations/Version.xcconfig 2021-10-21 16:31:19 UTC (rev 284607) +++ branches/safari-613.1.6-branch/Source/WebCore/PAL/Configurations/Version.xcconfig 2021-10-21 16:32:25 UTC (rev 284608) @@ -24,9 +24,9 @@ MAJOR_VERSION = 613; MINOR_VERSION = 1; TINY_VERSION = 6; -MICRO_VERSION = 0; +MICRO_VERSION = 1; NANO_VERSION = 0; -FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); +FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. BUNDLE_VERSION =
[webkit-changes] [284607] branches/safari-613.1.6-branch/Source/WebKit
Title: [284607] branches/safari-613.1.6-branch/Source/WebKit
Revision 284607
Author kocsen_ch...@apple.com
Date 2021-10-21 09:31:19 -0700 (Thu, 21 Oct 2021)
Log Message
Build fix reviewed by Wenson Hsieh and David Kilzer
Modified Paths
branches/safari-613.1.6-branch/Source/WebKit/GPUProcess/graphics/RemoteRenderingBackend.cpp
branches/safari-613.1.6-branch/Source/WebKit/WebProcess/GPU/graphics/RemoteImageBufferProxy.h
branches/safari-613.1.6-branch/Source/WebKit/WebProcess/GPU/graphics/RemoteRenderingBackendProxy.cpp
Diff
Modified: branches/safari-613.1.6-branch/Source/WebKit/GPUProcess/graphics/RemoteRenderingBackend.cpp (284606 => 284607)
--- branches/safari-613.1.6-branch/Source/WebKit/GPUProcess/graphics/RemoteRenderingBackend.cpp 2021-10-21 16:27:29 UTC (rev 284606)
+++ branches/safari-613.1.6-branch/Source/WebKit/GPUProcess/graphics/RemoteRenderingBackend.cpp 2021-10-21 16:31:19 UTC (rev 284607)
@@ -81,7 +81,7 @@
}
RemoteRenderingBackend::RemoteRenderingBackend(GPUConnectionToWebProcess& gpuConnectionToWebProcess, RemoteRenderingBackendCreationParameters&& creationParameters)
-: m_workQueue(WorkQueue::create("RemoteRenderingBackend work queue", WorkQueue::Type::Serial, WorkQueue::QOS::UserInteractive))
+: m_workQueue(WorkQueue::create("RemoteRenderingBackend work queue", WorkQueue::QOS::UserInteractive))
, m_remoteResourceCache(gpuConnectionToWebProcess.webProcessIdentifier())
, m_gpuConnectionToWebProcess(gpuConnectionToWebProcess)
, m_renderingBackendIdentifier(creationParameters.identifier)
Modified: branches/safari-613.1.6-branch/Source/WebKit/WebProcess/GPU/graphics/RemoteImageBufferProxy.h (284606 => 284607)
--- branches/safari-613.1.6-branch/Source/WebKit/WebProcess/GPU/graphics/RemoteImageBufferProxy.h 2021-10-21 16:27:29 UTC (rev 284606)
+++ branches/safari-613.1.6-branch/Source/WebKit/WebProcess/GPU/graphics/RemoteImageBufferProxy.h 2021-10-21 16:31:19 UTC (rev 284607)
@@ -100,7 +100,7 @@
protected:
RemoteImageBufferProxy(const WebCore::ImageBufferBackend::Parameters& parameters, RemoteRenderingBackendProxy& remoteRenderingBackendProxy)
: BaseDisplayListImageBuffer(parameters, this)
-, m_remoteRenderingBackendProxy(makeWeakPtr(remoteRenderingBackendProxy))
+, m_remoteRenderingBackendProxy(remoteRenderingBackendProxy)
{
ASSERT(m_remoteRenderingBackendProxy);
m_remoteRenderingBackendProxy->remoteResourceCacheProxy().cacheImageBuffer(*this);
Modified: branches/safari-613.1.6-branch/Source/WebKit/WebProcess/GPU/graphics/RemoteRenderingBackendProxy.cpp (284606 => 284607)
--- branches/safari-613.1.6-branch/Source/WebKit/WebProcess/GPU/graphics/RemoteRenderingBackendProxy.cpp 2021-10-21 16:27:29 UTC (rev 284606)
+++ branches/safari-613.1.6-branch/Source/WebKit/WebProcess/GPU/graphics/RemoteRenderingBackendProxy.cpp 2021-10-21 16:31:19 UTC (rev 284607)
@@ -78,7 +78,7 @@
gpuProcessConnection.addClient(*this);
gpuProcessConnection.messageReceiverMap().addMessageReceiver(Messages::RemoteRenderingBackendProxy::messageReceiverName(), renderingBackendIdentifier().toUInt64(), *this);
gpuProcessConnection.connection().send(Messages::GPUConnectionToWebProcess::CreateRenderingBackend(m_parameters), 0, IPC::SendOption::DispatchMessageEvenWhenWaitingForSyncReply);
-m_gpuProcessConnection = makeWeakPtr(gpuProcessConnection);
+m_gpuProcessConnection = gpuProcessConnection;
}
return *m_gpuProcessConnection;
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [284606] trunk/Source/WebCore
Title: [284606] trunk/Source/WebCore Revision 284606 Author commit-qu...@webkit.org Date 2021-10-21 09:27:29 -0700 (Thu, 21 Oct 2021) Log Message AX: Any addition of children should funnel through AccessibilityObject::addChild https://bugs.webkit.org/show_bug.cgi?id=231914 Patch by Tyler Wilcock on 2021-10-21 Reviewed by Chris Fleizach. All addition of children now goes through AccessibilityObject::addChild. This is good for two reasons: 1. It ensures we aren't inserting ignored elements into the tree. `insertChild` (downstream of `addChild`) checks this. Prior to this patch, there were cases where we could insert ignored children into the tree because no check was made. 2. We can reliably set state on the child based on the state of the parent at insertion time. For example, children can set a flag if any of their ancestors have an application or document role, which can be useful for some AX clients. * accessibility/AccessibilityARIAGrid.cpp: (WebCore::AccessibilityARIAGrid::addTableCellChild): (WebCore::AccessibilityARIAGrid::addChildren): * accessibility/AccessibilityListBox.cpp: (WebCore::AccessibilityListBox::addChildren): * accessibility/AccessibilityMenuList.cpp: (WebCore::AccessibilityMenuList::addChildren): * accessibility/AccessibilityMenuListPopup.cpp: (WebCore::AccessibilityMenuListPopup::addChildren): * accessibility/AccessibilityObject.cpp: (WebCore::isAutofillButton): (WebCore::isTableComponent): (WebCore::AccessibilityObject::insertChild): * accessibility/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::addImageMapChildren): (WebCore::AccessibilityRenderObject::addTextFieldChildren): (WebCore::AccessibilityRenderObject::addRemoteSVGChildren): * accessibility/AccessibilityScrollView.cpp: (WebCore::AccessibilityScrollView::addChildScrollbar): * accessibility/AccessibilitySlider.cpp: (WebCore::AccessibilitySlider::addChildren): * accessibility/AccessibilitySpinButton.cpp: (WebCore::AccessibilitySpinButton::addChildren): * accessibility/AccessibilityTable.cpp: (WebCore::AccessibilityTable::addChildren): (WebCore::AccessibilityTable::addTableCellChild): * accessibility/AccessibilityTableColumn.cpp: (WebCore::AccessibilityTableColumn::addChildren): * accessibility/AccessibilityTableHeaderContainer.cpp: (WebCore::AccessibilityTableHeaderContainer::addChildren): * accessibility/AccessibilityTableRow.cpp: (WebCore::AccessibilityTableRow::addChildren): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/accessibility/AccessibilityARIAGrid.cpp trunk/Source/WebCore/accessibility/AccessibilityListBox.cpp trunk/Source/WebCore/accessibility/AccessibilityMenuList.cpp trunk/Source/WebCore/accessibility/AccessibilityMenuListPopup.cpp trunk/Source/WebCore/accessibility/AccessibilityObject.cpp trunk/Source/WebCore/accessibility/AccessibilityRenderObject.cpp trunk/Source/WebCore/accessibility/AccessibilityScrollView.cpp trunk/Source/WebCore/accessibility/AccessibilitySlider.cpp trunk/Source/WebCore/accessibility/AccessibilitySpinButton.cpp trunk/Source/WebCore/accessibility/AccessibilityTable.cpp trunk/Source/WebCore/accessibility/AccessibilityTableColumn.cpp trunk/Source/WebCore/accessibility/AccessibilityTableHeaderContainer.cpp trunk/Source/WebCore/accessibility/AccessibilityTableRow.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (284605 => 284606) --- trunk/Source/WebCore/ChangeLog 2021-10-21 16:17:10 UTC (rev 284605) +++ trunk/Source/WebCore/ChangeLog 2021-10-21 16:27:29 UTC (rev 284606) @@ -1,3 +1,56 @@ +2021-10-21 Tyler Wilcock + +AX: Any addition of children should funnel through AccessibilityObject::addChild +https://bugs.webkit.org/show_bug.cgi?id=231914 + +Reviewed by Chris Fleizach. + +All addition of children now goes through +AccessibilityObject::addChild. This is good for two reasons: + +1. It ensures we aren't inserting ignored elements into the tree. +`insertChild` (downstream of `addChild`) checks this. Prior to this +patch, there were cases where we could insert ignored children into the +tree because no check was made. + +2. We can reliably set state on the child based on the state of the +parent at insertion time. For example, children can set a flag if +any of their ancestors have an application or document role, which can +be useful for some AX clients. + +* accessibility/AccessibilityARIAGrid.cpp: +(WebCore::AccessibilityARIAGrid::addTableCellChild): +(WebCore::AccessibilityARIAGrid::addChildren): +* accessibility/AccessibilityListBox.cpp: +(WebCore::AccessibilityListBox::addChildren): +* accessibility/AccessibilityMenuList.cpp: +(WebCore::AccessibilityMenuList::addChildren): +* accessibility/AccessibilityMenuListPopup.cpp: +(WebCore::AccessibilityMenuListPopup::addChildren): +* accessibility/AccessibilityObject.cpp: +
[webkit-changes] [284605] trunk/Tools
Title: [284605] trunk/Tools
Revision 284605
Author simon.fra...@apple.com
Date 2021-10-21 09:17:10 -0700 (Thu, 21 Oct 2021)
Log Message
run-webkit-tests --ios-simulator --print-expectations fails
https://bugs.webkit.org/show_bug.cgi?id=232035
Reviewed by Jonathan Bedard.
self._port.supported_device_types(), which _collect_tests() uses (despite its argument)
returns a different set of devices than self._port.DEFAULT_DEVICE_TYPES which caused
using those as hash keys to throw. So have print_expectations() and print_summary()
just use self._port.supported_device_types().
* Scripts/webkitpy/layout_tests/controllers/manager.py:
(Manager.print_expectations):
(Manager.print_summary):
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py
Diff
Modified: trunk/Tools/ChangeLog (284604 => 284605)
--- trunk/Tools/ChangeLog 2021-10-21 14:29:14 UTC (rev 284604)
+++ trunk/Tools/ChangeLog 2021-10-21 16:17:10 UTC (rev 284605)
@@ -1,3 +1,19 @@
+2021-10-21 Simon Fraser
+
+run-webkit-tests --ios-simulator --print-expectations fails
+https://bugs.webkit.org/show_bug.cgi?id=232035
+
+Reviewed by Jonathan Bedard.
+
+self._port.supported_device_types(), which _collect_tests() uses (despite its argument)
+returns a different set of devices than self._port.DEFAULT_DEVICE_TYPES which caused
+using those as hash keys to throw. So have print_expectations() and print_summary()
+just use self._port.supported_device_types().
+
+* Scripts/webkitpy/layout_tests/controllers/manager.py:
+(Manager.print_expectations):
+(Manager.print_summary):
+
2021-10-21 Chris Lord
[WPE][GTK] Enable smooth scrolling by default
Modified: trunk/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py (284604 => 284605)
--- trunk/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py 2021-10-21 14:29:14 UTC (rev 284604)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py 2021-10-21 16:17:10 UTC (rev 284605)
@@ -756,7 +756,7 @@
self._print_expectation_line_for_test(format_string, test, device_type=device_type)
def print_expectations(self, args):
-device_type_list = self._port.DEFAULT_DEVICE_TYPES or [self._port.DEVICE_TYPE]
+device_type_list = self._port.supported_device_types()
try:
tests_to_run_by_device, aggregate_tests_to_skip = self._collect_tests(args, device_type_list)
@@ -780,7 +780,7 @@
return 0
def print_summary(self, args):
-device_type_list = self._port.DEFAULT_DEVICE_TYPES or [self._port.DEVICE_TYPE]
+device_type_list = self._port.supported_device_types()
test_stats = {}
try:
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [284604] trunk/Source/WebCore
Title: [284604] trunk/Source/WebCore
Revision 284604
Author an...@apple.com
Date 2021-10-21 07:29:14 -0700 (Thu, 21 Oct 2021)
Log Message
Move Style::Resolver::State out of header
https://bugs.webkit.org/show_bug.cgi?id=232074
Reviewed by Antoine Quint.
It is an implementation detail.
* style/PageRuleCollector.cpp:
(WebCore::Style::PageRuleCollector::isLeftPage const):
* style/PageRuleCollector.h:
(WebCore::Style::PageRuleCollector::PageRuleCollector):
Provide just the root text direction instead of the State.
* style/StyleResolver.cpp:
(WebCore::Style::Resolver::State::State):
(WebCore::Style::Resolver::State::element const):
(WebCore::Style::Resolver::State::setStyle):
(WebCore::Style::Resolver::State::style const):
(WebCore::Style::Resolver::State::takeStyle):
(WebCore::Style::Resolver::State::setParentStyle):
(WebCore::Style::Resolver::State::parentStyle const):
(WebCore::Style::Resolver::State::rootElementStyle const):
(WebCore::Style::Resolver::State::userAgentAppearanceStyle const):
(WebCore::Style::Resolver::State::setUserAgentAppearanceStyle):
(WebCore::Style::Resolver::styleForPage):
* style/StyleResolver.h:
(WebCore::Style::Resolver::State::State): Deleted.
(WebCore::Style::Resolver::State::element const): Deleted.
(WebCore::Style::Resolver::State::style const): Deleted.
(WebCore::Style::Resolver::State::takeStyle): Deleted.
(WebCore::Style::Resolver::State::parentStyle const): Deleted.
(WebCore::Style::Resolver::State::rootElementStyle const): Deleted.
(WebCore::Style::Resolver::State::userAgentAppearanceStyle const): Deleted.
(WebCore::Style::Resolver::State::setUserAgentAppearanceStyle): Deleted.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/style/PageRuleCollector.cpp
trunk/Source/WebCore/style/PageRuleCollector.h
trunk/Source/WebCore/style/StyleResolver.cpp
trunk/Source/WebCore/style/StyleResolver.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (284603 => 284604)
--- trunk/Source/WebCore/ChangeLog 2021-10-21 14:09:08 UTC (rev 284603)
+++ trunk/Source/WebCore/ChangeLog 2021-10-21 14:29:14 UTC (rev 284604)
@@ -1,3 +1,41 @@
+2021-10-21 Antti Koivisto
+
+Move Style::Resolver::State out of header
+https://bugs.webkit.org/show_bug.cgi?id=232074
+
+Reviewed by Antoine Quint.
+
+It is an implementation detail.
+
+* style/PageRuleCollector.cpp:
+(WebCore::Style::PageRuleCollector::isLeftPage const):
+* style/PageRuleCollector.h:
+(WebCore::Style::PageRuleCollector::PageRuleCollector):
+
+Provide just the root text direction instead of the State.
+
+* style/StyleResolver.cpp:
+(WebCore::Style::Resolver::State::State):
+(WebCore::Style::Resolver::State::element const):
+(WebCore::Style::Resolver::State::setStyle):
+(WebCore::Style::Resolver::State::style const):
+(WebCore::Style::Resolver::State::takeStyle):
+(WebCore::Style::Resolver::State::setParentStyle):
+(WebCore::Style::Resolver::State::parentStyle const):
+(WebCore::Style::Resolver::State::rootElementStyle const):
+(WebCore::Style::Resolver::State::userAgentAppearanceStyle const):
+(WebCore::Style::Resolver::State::setUserAgentAppearanceStyle):
+(WebCore::Style::Resolver::styleForPage):
+* style/StyleResolver.h:
+(WebCore::Style::Resolver::State::State): Deleted.
+(WebCore::Style::Resolver::State::element const): Deleted.
+(WebCore::Style::Resolver::State::style const): Deleted.
+(WebCore::Style::Resolver::State::takeStyle): Deleted.
+(WebCore::Style::Resolver::State::parentStyle const): Deleted.
+(WebCore::Style::Resolver::State::rootElementStyle const): Deleted.
+(WebCore::Style::Resolver::State::userAgentAppearanceStyle const): Deleted.
+(WebCore::Style::Resolver::State::setUserAgentAppearanceStyle): Deleted.
+
2021-10-21 Antoine Quint
CSSPropertyZoom needs wrapper that ensures it's always blended into a positive value.
Modified: trunk/Source/WebCore/style/PageRuleCollector.cpp (284603 => 284604)
--- trunk/Source/WebCore/style/PageRuleCollector.cpp 2021-10-21 14:09:08 UTC (rev 284603)
+++ trunk/Source/WebCore/style/PageRuleCollector.cpp 2021-10-21 14:29:14 UTC (rev 284604)
@@ -43,10 +43,7 @@
bool PageRuleCollector::isLeftPage(int pageIndex) const
{
-bool isFirstPageLeft = false;
-if (!m_state.rootElementStyle()->isLeftToRightDirection())
-isFirstPageLeft = true;
-
+bool isFirstPageLeft = m_rootDirection == TextDirection::RTL;
return (pageIndex + (isFirstPageLeft ? 1 : 0)) % 2;
}
Modified: trunk/Source/WebCore/style/PageRuleCollector.h (284603 => 284604)
--- trunk/Source/WebCore/style/PageRuleCollector.h 2021-10-21 14:09:08 UTC (rev 284603)
+++ trunk/Source/WebCore/style/PageRuleCollector.h 2021-10-21 14:29:14 UTC (rev 284604)
@@ -21,7 +21,6 @@
#pragma once
-#include "StyleResolver.h"
#include
[webkit-changes] [284603] trunk
Title: [284603] trunk
Revision 284603
Author cl...@igalia.com
Date 2021-10-21 07:09:08 -0700 (Thu, 21 Oct 2021)
Log Message
[WPE][GTK] Enable smooth scrolling by default
https://bugs.webkit.org/show_bug.cgi?id=220512
Reviewed by Carlos Garcia Campos.
.:
Build smooth scrolling by default on WPE to match other platforms.
* Source/cmake/OptionsWPE.cmake:
Source/WebKit:
Enable smooth scrolling by default on GTK and WPE platforms.
* UIProcess/API/glib/WebKitSettings.cpp:
(webkit_settings_class_init):
Source/WTF:
Enable smooth scrolling by default on GTK and WPE platforms.
* Scripts/Preferences/WebPreferences.yaml:
Tools:
Smooth scrolling is default on on GTK now, so reverse the logic in the
test for the efficacy of the related setting.
* TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
(testWebKitSettings):
Modified Paths
trunk/ChangeLog
trunk/Source/WTF/ChangeLog
trunk/Source/WTF/Scripts/Preferences/WebPreferences.yaml
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/API/glib/WebKitSettings.cpp
trunk/Source/cmake/OptionsWPE.cmake
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp
Diff
Modified: trunk/ChangeLog (284602 => 284603)
--- trunk/ChangeLog 2021-10-21 12:40:06 UTC (rev 284602)
+++ trunk/ChangeLog 2021-10-21 14:09:08 UTC (rev 284603)
@@ -1,3 +1,14 @@
+2021-10-21 Chris Lord
+
+[WPE][GTK] Enable smooth scrolling by default
+https://bugs.webkit.org/show_bug.cgi?id=220512
+
+Reviewed by Carlos Garcia Campos.
+
+Build smooth scrolling by default on WPE to match other platforms.
+
+* Source/cmake/OptionsWPE.cmake:
+
2021-10-20 Kimmo Kinnunen
Add ObjC as supported .clang-format language
Modified: trunk/Source/WTF/ChangeLog (284602 => 284603)
--- trunk/Source/WTF/ChangeLog 2021-10-21 12:40:06 UTC (rev 284602)
+++ trunk/Source/WTF/ChangeLog 2021-10-21 14:09:08 UTC (rev 284603)
@@ -1,3 +1,14 @@
+2021-10-21 Chris Lord
+
+[WPE][GTK] Enable smooth scrolling by default
+https://bugs.webkit.org/show_bug.cgi?id=220512
+
+Reviewed by Carlos Garcia Campos.
+
+Enable smooth scrolling by default on GTK and WPE platforms.
+
+* Scripts/Preferences/WebPreferences.yaml:
+
2021-10-20 Brady Eidson
WebKit Managed Notifications: Skeleton NotificationProvider
Modified: trunk/Source/WTF/Scripts/Preferences/WebPreferences.yaml (284602 => 284603)
--- trunk/Source/WTF/Scripts/Preferences/WebPreferences.yaml 2021-10-21 12:40:06 UTC (rev 284602)
+++ trunk/Source/WTF/Scripts/Preferences/WebPreferences.yaml 2021-10-21 14:09:08 UTC (rev 284603)
@@ -1905,10 +1905,10 @@
"PLATFORM(MAC)": true
default: false
WebKit:
- "PLATFORM(MAC)": true
+ "PLATFORM(MAC) || PLATFORM(GTK) || PLATFORM(WPE)": true
default: false
WebCore:
- "PLATFORM(MAC)": true
+ "PLATFORM(MAC) || PLATFORM(GTK) || PLATFORM(WPE)": true
default: false
# FIXME: This is handled via WebView SPI rather than WebPreferences for WebKitLegacy. We should change the SPI to lookup the WebPreferences value instead.
Modified: trunk/Source/WebKit/ChangeLog (284602 => 284603)
--- trunk/Source/WebKit/ChangeLog 2021-10-21 12:40:06 UTC (rev 284602)
+++ trunk/Source/WebKit/ChangeLog 2021-10-21 14:09:08 UTC (rev 284603)
@@ -1,3 +1,15 @@
+2021-10-21 Chris Lord
+
+[WPE][GTK] Enable smooth scrolling by default
+https://bugs.webkit.org/show_bug.cgi?id=220512
+
+Reviewed by Carlos Garcia Campos.
+
+Enable smooth scrolling by default on GTK and WPE platforms.
+
+* UIProcess/API/glib/WebKitSettings.cpp:
+(webkit_settings_class_init):
+
2021-10-20 Brady Eidson
WebKit Managed Notifications: Skeleton NotificationProvider
Modified: trunk/Source/WebKit/UIProcess/API/glib/WebKitSettings.cpp (284602 => 284603)
--- trunk/Source/WebKit/UIProcess/API/glib/WebKitSettings.cpp 2021-10-21 12:40:06 UTC (rev 284602)
+++ trunk/Source/WebKit/UIProcess/API/glib/WebKitSettings.cpp 2021-10-21 14:09:08 UTC (rev 284603)
@@ -1252,7 +1252,7 @@
"enable-smooth-scrolling",
_("Enable smooth scrolling"),
_("Whether to enable smooth scrolling"),
-FALSE,
+TRUE,
readWriteConstructParamFlags);
/**
Modified: trunk/Source/cmake/OptionsWPE.cmake (284602 => 284603)
--- trunk/Source/cmake/OptionsWPE.cmake 2021-10-21 12:40:06 UTC (rev 284602)
+++ trunk/Source/cmake/OptionsWPE.cmake 2021-10-21 14:09:08 UTC (rev 284603)
@@ -64,7 +64,6 @@
WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_PERIODIC_MEMORY_MONITOR PRIVATE ON)
WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_SERVICE_WORKER PRIVATE ON)
WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_SHAREABLE_RESOURCE PRIVATE ON)
-WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_SMOOTH_SCROLLING PRIVATE OFF)
WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_TOUCH_EVENTS PRIVATE ON)
[webkit-changes] [284602] trunk
Title: [284602] trunk
Revision 284602
Author grao...@webkit.org
Date 2021-10-21 05:40:06 -0700 (Thu, 21 Oct 2021)
Log Message
CSSPropertyZoom needs wrapper that ensures it's always blended into a positive value.
https://bugs.webkit.org/show_bug.cgi?id=232020
Reviewed by Antti Koivisto.
Source/WebCore:
Test: webanimations/zoom-animation-crash.html
The "zoom" CSS property is expected to be always larger than 0, so let's ensure we do not allow
values <= 0 while blending. To do so we repurpose NonNegativeFloatPropertyWrapper to now take
an argument specifying if the blended value should be non-negative or positive.
* animation/CSSPropertyAnimation.cpp:
(WebCore::FloatPropertyWrapper::FloatPropertyWrapper):
(WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap):
(WebCore::NonNegativeFloatPropertyWrapper::NonNegativeFloatPropertyWrapper): Deleted.
LayoutTests:
Add a test that would crash prior to the source change.
* webanimations/zoom-animation-crash-expected.txt: Added.
* webanimations/zoom-animation-crash.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/animation/CSSPropertyAnimation.cpp
Added Paths
trunk/LayoutTests/webanimations/zoom-animation-crash-expected.txt
trunk/LayoutTests/webanimations/zoom-animation-crash.html
Diff
Modified: trunk/LayoutTests/ChangeLog (284601 => 284602)
--- trunk/LayoutTests/ChangeLog 2021-10-21 12:28:57 UTC (rev 284601)
+++ trunk/LayoutTests/ChangeLog 2021-10-21 12:40:06 UTC (rev 284602)
@@ -1,3 +1,16 @@
+2021-10-21 Antoine Quint
+
+CSSPropertyZoom needs wrapper that ensures it's always blended into a positive value.
+https://bugs.webkit.org/show_bug.cgi?id=232020
+
+
+Reviewed by Antti Koivisto.
+
+Add a test that would crash prior to the source change.
+
+* webanimations/zoom-animation-crash-expected.txt: Added.
+* webanimations/zoom-animation-crash.html: Added.
+
2021-10-21 Enrique Ocaña González
REGRESSION(r282059) [GStreamer] Test media/media-source/media-source-stalled-holds-sleep-assertion.html timeouts
Added: trunk/LayoutTests/webanimations/zoom-animation-crash-expected.txt (0 => 284602)
--- trunk/LayoutTests/webanimations/zoom-animation-crash-expected.txt (rev 0)
+++ trunk/LayoutTests/webanimations/zoom-animation-crash-expected.txt 2021-10-21 12:40:06 UTC (rev 284602)
@@ -0,0 +1 @@
+This test passes if it does not crash.
Added: trunk/LayoutTests/webanimations/zoom-animation-crash.html (0 => 284602)
--- trunk/LayoutTests/webanimations/zoom-animation-crash.html (rev 0)
+++ trunk/LayoutTests/webanimations/zoom-animation-crash.html 2021-10-21 12:40:06 UTC (rev 284602)
@@ -0,0 +1,29 @@
+
+
+@keyframes anim {
+50% { zoom: 0.25 }
+}
+
+div {
+animation: anim 20ms cubic-bezier(0, 1000, 0, 1) forwards;
+}
+
+span {
+line-height: 10px;
+}
+
+
+This test passes if it does not crash.
+
+
+if (window.testRunner) {
+window.testRunner.dumpAsText();
+window.testRunner.waitUntilDone();
+}
+
+document.querySelector("div").addEventListener("animationend", () => {
+if (window.testRunner)
+window.testRunner.notifyDone();
+});
+
+
\ No newline at end of file
Modified: trunk/Source/WebCore/ChangeLog (284601 => 284602)
--- trunk/Source/WebCore/ChangeLog 2021-10-21 12:28:57 UTC (rev 284601)
+++ trunk/Source/WebCore/ChangeLog 2021-10-21 12:40:06 UTC (rev 284602)
@@ -1,5 +1,24 @@
2021-10-21 Antoine Quint
+CSSPropertyZoom needs wrapper that ensures it's always blended into a positive value.
+https://bugs.webkit.org/show_bug.cgi?id=232020
+
+
+Reviewed by Antti Koivisto.
+
+Test: webanimations/zoom-animation-crash.html
+
+The "zoom" CSS property is expected to be always larger than 0, so let's ensure we do not allow
+values <= 0 while blending. To do so we repurpose NonNegativeFloatPropertyWrapper to now take
+an argument specifying if the blended value should be non-negative or positive.
+
+* animation/CSSPropertyAnimation.cpp:
+(WebCore::FloatPropertyWrapper::FloatPropertyWrapper):
+(WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap):
+(WebCore::NonNegativeFloatPropertyWrapper::NonNegativeFloatPropertyWrapper): Deleted.
+
+2021-10-21 Antoine Quint
+
Pass CompositeOperation to CSSPropertyAnimation::blendProperties and through more blending functions
https://bugs.webkit.org/show_bug.cgi?id=232069
Modified: trunk/Source/WebCore/animation/CSSPropertyAnimation.cpp (284601 => 284602)
--- trunk/Source/WebCore/animation/CSSPropertyAnimation.cpp 2021-10-21 12:28:57 UTC (rev 284601)
+++ trunk/Source/WebCore/animation/CSSPropertyAnimation.cpp 2021-10-21 12:40:06 UTC (rev 284602)
@@ -2130,11 +2130,18 @@
std::optional m_minValue;
};
-class NonNegativeFloatPropertyWrapper : public
[webkit-changes] [284601] trunk/LayoutTests
Title: [284601] trunk/LayoutTests
Revision 284601
Author eoca...@igalia.com
Date 2021-10-21 05:28:57 -0700 (Thu, 21 Oct 2021)
Log Message
REGRESSION(r282059) [GStreamer] Test media/media-source/media-source-stalled-holds-sleep-assertion.html timeouts
https://bugs.webkit.org/show_bug.cgi?id=229979
Reviewed by Xabier Rodriguez-Calvar.
Detect stall by monitoring currentTime instead of listening to the 'stall' event. This is needed after
removing emission of 'stall' event in GStreamer ports after https://bugs.webkit.org/show_bug.cgi?id=226882
Also remove initial seek, which is irrelevant to the test purpose and causes troubles in GStreamer ports.
* media/media-source/media-source-stalled-holds-sleep-assertion-expected.txt: Updated expectations.
* media/media-source/media-source-stalled-holds-sleep-assertion.html: Monitor currentTime instead of stall event, remove initial seek.
* platform/glib/TestExpectations: Removed timeout expectation.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/media/media-source/media-source-stalled-holds-sleep-assertion-expected.txt
trunk/LayoutTests/media/media-source/media-source-stalled-holds-sleep-assertion.html
trunk/LayoutTests/platform/glib/TestExpectations
Diff
Modified: trunk/LayoutTests/ChangeLog (284600 => 284601)
--- trunk/LayoutTests/ChangeLog 2021-10-21 11:51:12 UTC (rev 284600)
+++ trunk/LayoutTests/ChangeLog 2021-10-21 12:28:57 UTC (rev 284601)
@@ -1,3 +1,19 @@
+2021-10-21 Enrique Ocaña González
+
+REGRESSION(r282059) [GStreamer] Test media/media-source/media-source-stalled-holds-sleep-assertion.html timeouts
+https://bugs.webkit.org/show_bug.cgi?id=229979
+
+Reviewed by Xabier Rodriguez-Calvar.
+
+Detect stall by monitoring currentTime instead of listening to the 'stall' event. This is needed after
+removing emission of 'stall' event in GStreamer ports after https://bugs.webkit.org/show_bug.cgi?id=226882
+
+Also remove initial seek, which is irrelevant to the test purpose and causes troubles in GStreamer ports.
+
+* media/media-source/media-source-stalled-holds-sleep-assertion-expected.txt: Updated expectations.
+* media/media-source/media-source-stalled-holds-sleep-assertion.html: Monitor currentTime instead of stall event, remove initial seek.
+* platform/glib/TestExpectations: Removed timeout expectation.
+
2021-10-20 Antti Koivisto
[ iOS ] fast/inline/inline-background-clip-text-multiline.html is image failing
Modified: trunk/LayoutTests/media/media-source/media-source-stalled-holds-sleep-assertion-expected.txt (284600 => 284601)
--- trunk/LayoutTests/media/media-source/media-source-stalled-holds-sleep-assertion-expected.txt 2021-10-21 11:51:12 UTC (rev 284600)
+++ trunk/LayoutTests/media/media-source/media-source-stalled-holds-sleep-assertion-expected.txt 2021-10-21 12:28:57 UTC (rev 284601)
@@ -7,9 +7,8 @@
EVENT(update)
RUN(sourceBuffer.appendBuffer(loader.mediaSegment(0)))
EVENT(update)
-RUN(video.currentTime = video.buffered.end(0) - 0.1)
RUN(video.play())
-EVENT(stalled)
+EXPECTED ((currentTime != initialCurrentTime && oldCurrentTime == currentTime) == 'true') OK
EXPECTED (internals.elementIsBlockingDisplaySleep(video) == 'false') OK
END OF TEST
Modified: trunk/LayoutTests/media/media-source/media-source-stalled-holds-sleep-assertion.html (284600 => 284601)
--- trunk/LayoutTests/media/media-source/media-source-stalled-holds-sleep-assertion.html 2021-10-21 11:51:12 UTC (rev 284600)
+++ trunk/LayoutTests/media/media-source/media-source-stalled-holds-sleep-assertion.html 2021-10-21 12:28:57 UTC (rev 284601)
@@ -8,6 +8,9 @@
var loader;
var source;
var sourceBuffer;
+var currentTime;
+var oldCurrentTime;
+var initialCurrentTime = null;
function runTest() {
findMediaElement();
@@ -39,13 +42,24 @@
run('sourceBuffer.appendBuffer(loader.mediaSegment(0))');
}
+function checkStalled() {
+oldCurrentTime = currentTime;
+currentTime = video.currentTime;
+if (initialCurrentTime == null)
+initialCurrentTime = currentTime;
+if (currentTime != initialCurrentTime && oldCurrentTime == currentTime)
+stalled();
+else
+setTimeout(checkStalled, 300);
+}
+
function sourceUpdated() {
-run('video.currentTime = video.buffered.end(0) - 0.1');
run('video.play()');
-waitForEvent('stalled', stalled);
+checkStalled();
}
function stalled() {
+testExpected('(currentTime != initialCurrentTime && oldCurrentTime == currentTime)', true);
testExpected('internals.elementIsBlockingDisplaySleep(video)', false);
endTest();
}
@@ -54,4 +68,4 @@
-
\ No newline at end of file
+
Modified: trunk/LayoutTests/platform/glib/TestExpectations (284600 => 284601)
--- trunk/LayoutTests/platform/glib/TestExpectations 2021-10-21 11:51:12 UTC (rev
[webkit-changes] [284600] trunk/Source/WebCore
Title: [284600] trunk/Source/WebCore Revision 284600 Author grao...@webkit.org Date 2021-10-21 04:51:12 -0700 (Thu, 21 Oct 2021) Log Message Pass CompositeOperation to CSSPropertyAnimation::blendProperties and through more blending functions https://bugs.webkit.org/show_bug.cgi?id=232069 Reviewed by Antti Koivisto. In preparation for support of CompositeOperation when blending, we need to pass it down from blendProperties() to other blending functions. Currently we only ever pass Replace so there is no change in behavior. * animation/CSSPropertyAnimation.cpp: (WebCore::CSSPropertyBlendingContext::CSSPropertyBlendingContext): (WebCore::AnimationPropertyWrapperBase::canInterpolate const): (WebCore::CSSPropertyAnimation::blendProperties): (WebCore::CSSPropertyAnimation::canPropertyBeInterpolated): * animation/CSSPropertyAnimation.h: * animation/KeyframeEffect.cpp: (WebCore::KeyframeEffect::setAnimatedPropertiesInStyle): * platform/LengthSize.h: (WebCore::blend): * platform/animation/AnimationUtilities.h: (WebCore::BlendingContext::BlendingContext): * platform/graphics/transforms/AffineTransform.cpp: (WebCore::AffineTransform::blend): * platform/graphics/transforms/AffineTransform.h: * platform/graphics/transforms/RotateTransformOperation.cpp: (WebCore::RotateTransformOperation::blend): * platform/graphics/transforms/TransformOperation.h: * platform/graphics/transforms/TransformationMatrix.cpp: (WebCore::blendFloat): (WebCore::TransformationMatrix::blend2): (WebCore::TransformationMatrix::blend4): (WebCore::TransformationMatrix::blend): * platform/graphics/transforms/TransformationMatrix.h: Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/animation/CSSPropertyAnimation.cpp trunk/Source/WebCore/animation/CSSPropertyAnimation.h trunk/Source/WebCore/animation/KeyframeEffect.cpp trunk/Source/WebCore/platform/LengthSize.h trunk/Source/WebCore/platform/animation/AnimationUtilities.h trunk/Source/WebCore/platform/graphics/transforms/AffineTransform.cpp trunk/Source/WebCore/platform/graphics/transforms/AffineTransform.h trunk/Source/WebCore/platform/graphics/transforms/RotateTransformOperation.cpp trunk/Source/WebCore/platform/graphics/transforms/TransformOperation.h trunk/Source/WebCore/platform/graphics/transforms/TransformationMatrix.cpp trunk/Source/WebCore/platform/graphics/transforms/TransformationMatrix.h Diff Modified: trunk/Source/WebCore/ChangeLog (284599 => 284600) --- trunk/Source/WebCore/ChangeLog 2021-10-21 10:50:28 UTC (rev 284599) +++ trunk/Source/WebCore/ChangeLog 2021-10-21 11:51:12 UTC (rev 284600) @@ -1,3 +1,38 @@ +2021-10-21 Antoine Quint + +Pass CompositeOperation to CSSPropertyAnimation::blendProperties and through more blending functions +https://bugs.webkit.org/show_bug.cgi?id=232069 + +Reviewed by Antti Koivisto. + +In preparation for support of CompositeOperation when blending, we need to pass it down from blendProperties() +to other blending functions. Currently we only ever pass Replace so there is no change in behavior. + +* animation/CSSPropertyAnimation.cpp: +(WebCore::CSSPropertyBlendingContext::CSSPropertyBlendingContext): +(WebCore::AnimationPropertyWrapperBase::canInterpolate const): +(WebCore::CSSPropertyAnimation::blendProperties): +(WebCore::CSSPropertyAnimation::canPropertyBeInterpolated): +* animation/CSSPropertyAnimation.h: +* animation/KeyframeEffect.cpp: +(WebCore::KeyframeEffect::setAnimatedPropertiesInStyle): +* platform/LengthSize.h: +(WebCore::blend): +* platform/animation/AnimationUtilities.h: +(WebCore::BlendingContext::BlendingContext): +* platform/graphics/transforms/AffineTransform.cpp: +(WebCore::AffineTransform::blend): +* platform/graphics/transforms/AffineTransform.h: +* platform/graphics/transforms/RotateTransformOperation.cpp: +(WebCore::RotateTransformOperation::blend): +* platform/graphics/transforms/TransformOperation.h: +* platform/graphics/transforms/TransformationMatrix.cpp: +(WebCore::blendFloat): +(WebCore::TransformationMatrix::blend2): +(WebCore::TransformationMatrix::blend4): +(WebCore::TransformationMatrix::blend): +* platform/graphics/transforms/TransformationMatrix.h: + 2021-10-21 Chris Lord [GTK] Slow scrolling (not matching GTK native scroll amount) Modified: trunk/Source/WebCore/animation/CSSPropertyAnimation.cpp (284599 => 284600) --- trunk/Source/WebCore/animation/CSSPropertyAnimation.cpp 2021-10-21 10:50:28 UTC (rev 284599) +++ trunk/Source/WebCore/animation/CSSPropertyAnimation.cpp 2021-10-21 11:51:12 UTC (rev 284600) @@ -43,6 +43,7 @@ #include "CalculationValue.h" #include "ClipPathOperation.h" #include "ColorBlending.h" +#include "CompositeOperation.h" #include "FloatConversion.h" #include "FontCascade.h" #include "FontSelectionAlgorithm.h" @@
[webkit-changes] [284599] trunk/Source/ThirdParty/libwebrtc
Title: [284599] trunk/Source/ThirdParty/libwebrtc
Revision 284599
Author ddkil...@apple.com
Date 2021-10-21 03:50:28 -0700 (Thu, 21 Oct 2021)
Log Message
[WebRTC] Simplify libwebtc Xcode project
Reviewed by Youenn Fablet.
* Configurations/libwebm.xcconfig:
(INSTALL_HEADERS_PATH):
(LIBWEBM_HEADERS_FOLDER_PATH):
(LIBWEBM_HEADERS_FOLDER_PATH_NO):
(LIBWEBM_HEADERS_FOLDER_PATH_YES):
- Remove variables used by now-removed build phase scripts.
(PUBLIC_HEADERS_FOLDER_PATH): Add.
- This determines where webm public headers are installed.
* libwebrtc.xcodeproj/project.pbxproj:
(Recovered References): Remove.
- The two source files were added back at the correct path
elsewhere, so these references can be removed.
(webm target):
- Remove "Copy webm headers" and "Copy common headers" build
phase scripts since headers are installed by Xcode's built-in
"Headers" phase.
- Remove duplicate C++ source files (noticed after reviewing
"Recovered References" files).
- Install webm headers as public headers since their is no
subdirectory structure, and this fixes the bug in the radar
where webm headers were not installed consistently.
Modified Paths
trunk/Source/ThirdParty/libwebrtc/ChangeLog
trunk/Source/ThirdParty/libwebrtc/Configurations/libwebm.xcconfig
trunk/Source/ThirdParty/libwebrtc/libwebrtc.xcodeproj/project.pbxproj
Diff
Modified: trunk/Source/ThirdParty/libwebrtc/ChangeLog (284598 => 284599)
--- trunk/Source/ThirdParty/libwebrtc/ChangeLog 2021-10-21 10:21:15 UTC (rev 284598)
+++ trunk/Source/ThirdParty/libwebrtc/ChangeLog 2021-10-21 10:50:28 UTC (rev 284599)
@@ -1,3 +1,34 @@
+2021-10-21 David Kilzer
+
+[WebRTC] Simplify libwebtc Xcode project
+
+
+
+Reviewed by Youenn Fablet.
+
+* Configurations/libwebm.xcconfig:
+(INSTALL_HEADERS_PATH):
+(LIBWEBM_HEADERS_FOLDER_PATH):
+(LIBWEBM_HEADERS_FOLDER_PATH_NO):
+(LIBWEBM_HEADERS_FOLDER_PATH_YES):
+- Remove variables used by now-removed build phase scripts.
+(PUBLIC_HEADERS_FOLDER_PATH): Add.
+- This determines where webm public headers are installed.
+
+* libwebrtc.xcodeproj/project.pbxproj:
+(Recovered References): Remove.
+- The two source files were added back at the correct path
+ elsewhere, so these references can be removed.
+(webm target):
+- Remove "Copy webm headers" and "Copy common headers" build
+ phase scripts since headers are installed by Xcode's built-in
+ "Headers" phase.
+- Remove duplicate C++ source files (noticed after reviewing
+ "Recovered References" files).
+- Install webm headers as public headers since their is no
+ subdirectory structure, and this fixes the bug in the radar
+ where webm headers were not installed consistently.
+
2021-10-20 Youenn Fablet
WebRTC p2p call, VP9-SVC only low layer decoded on receiver side
Modified: trunk/Source/ThirdParty/libwebrtc/Configurations/libwebm.xcconfig (284598 => 284599)
--- trunk/Source/ThirdParty/libwebrtc/Configurations/libwebm.xcconfig 2021-10-21 10:21:15 UTC (rev 284598)
+++ trunk/Source/ThirdParty/libwebrtc/Configurations/libwebm.xcconfig 2021-10-21 10:50:28 UTC (rev 284599)
@@ -8,9 +8,5 @@
HEADER_SEARCH_PATHS = Source/third_party/libwebm Source/third_party/libwebm/webm_parser Source/third_party/libwebm/webm_parser/include;
INSTALL_PATH = /usr/local/lib;
+PUBLIC_HEADERS_FOLDER_PATH = /usr/local/include/webm;
USE_HEADERMAP = NO;
-
-INSTALL_HEADERS_PATH = /usr/local/include;
-LIBWEBM_HEADERS_FOLDER_PATH = $(LIBWEBM_HEADERS_FOLDER_PATH_$(DEPLOYMENT_LOCATION));
-LIBWEBM_HEADERS_FOLDER_PATH_NO = $(BUILT_PRODUCTS_DIR)/$(INSTALL_HEADERS_PATH);
-LIBWEBM_HEADERS_FOLDER_PATH_YES = $(INSTALL_HEADERS_PATH);
Modified: trunk/Source/ThirdParty/libwebrtc/libwebrtc.xcodeproj/project.pbxproj (284598 => 284599)
--- trunk/Source/ThirdParty/libwebrtc/libwebrtc.xcodeproj/project.pbxproj 2021-10-21 10:21:15 UTC (rev 284598)
+++ trunk/Source/ThirdParty/libwebrtc/libwebrtc.xcodeproj/project.pbxproj 2021-10-21 10:50:28 UTC (rev 284599)
@@ -1520,9 +1520,8 @@
415F1FB621272FBA00064CBF /* vad_with_level.h in Headers */ = {isa = PBXBuildFile; fileRef = 41A08BE321272F85001D5D7B /* vad_with_level.h */; };
415F1FB721272FBA00064CBF /* vector_float_frame.h in Headers */ = {isa = PBXBuildFile; fileRef = 41A08BDD21272F84001D5D7B /* vector_float_frame.h */; };
415F1FC62127308F00064CBF /* audio_state.cc in Sources */ = {isa = PBXBuildFile; fileRef = 415F1FC52127308E00064CBF /* audio_state.cc */; };
- 416008B425DBCEC300E892FE /* vp9_header_parser.h in Headers */ = {isa = PBXBuildFile; fileRef = CDFD2F9624C4B2F90048DAC3 /* vp9_header_parser.h */; };
+ 416008B425DBCEC300E892FE /* vp9_header_parser.h in Headers */ = {isa = PBXBuildFile; fileRef = CDFD2F9624C4B2F90048DAC3 /* vp9_header_parser.h */; settings = {ATTRIBUTES = (Public, ); }; };
416008B525DBD3DE00E892FE /*
[webkit-changes] [284598] releases/WPE WebKit/webkit-2.34.1/
Title: [284598] releases/WPE WebKit/webkit-2.34.1/ Revision 284598 Author ape...@igalia.com Date 2021-10-21 03:21:15 -0700 (Thu, 21 Oct 2021) Log Message WPE WebKit 2.34.1 Added Paths releases/WPE WebKit/webkit-2.34.1/ Diff ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [284597] releases/WebKitGTK/webkit-2.34
Title: [284597] releases/WebKitGTK/webkit-2.34 Revision 284597 Author ape...@igalia.com Date 2021-10-21 03:21:00 -0700 (Thu, 21 Oct 2021) Log Message Unreviewed. Update OptionsWPE.cmake and NEWS for the 2.34.1 release .: * Source/cmake/OptionsWPE.cmake: Bump version numbers. Source/WebKit: * wpe/NEWS: Add release notes for 2.34.1. Modified Paths releases/WebKitGTK/webkit-2.34/ChangeLog releases/WebKitGTK/webkit-2.34/Source/WebKit/ChangeLog releases/WebKitGTK/webkit-2.34/Source/WebKit/wpe/NEWS releases/WebKitGTK/webkit-2.34/Source/cmake/OptionsWPE.cmake Diff Modified: releases/WebKitGTK/webkit-2.34/ChangeLog (284596 => 284597) --- releases/WebKitGTK/webkit-2.34/ChangeLog 2021-10-21 09:53:50 UTC (rev 284596) +++ releases/WebKitGTK/webkit-2.34/ChangeLog 2021-10-21 10:21:00 UTC (rev 284597) @@ -1,3 +1,9 @@ +2021-10-21 Adrian Perez de Castro + +Unreviewed. Update OptionsWPE.cmake and NEWS for the 2.34.1 release + +* Source/cmake/OptionsWPE.cmake: Bump version numbers. + 2021-10-21 Carlos Garcia Campos Unreviewed. Update OptionsGTK.cmake and NEWS for 2.34.1 release Modified: releases/WebKitGTK/webkit-2.34/Source/WebKit/ChangeLog (284596 => 284597) --- releases/WebKitGTK/webkit-2.34/Source/WebKit/ChangeLog 2021-10-21 09:53:50 UTC (rev 284596) +++ releases/WebKitGTK/webkit-2.34/Source/WebKit/ChangeLog 2021-10-21 10:21:00 UTC (rev 284597) @@ -1,3 +1,9 @@ +2021-10-21 Adrian Perez de Castro + +Unreviewed. Update OptionsWPE.cmake and NEWS for the 2.34.1 release + +* wpe/NEWS: Add release notes for 2.34.1. + 2021-10-21 Carlos Garcia Campos Unreviewed. Update OptionsGTK.cmake and NEWS for 2.34.1 release Modified: releases/WebKitGTK/webkit-2.34/Source/WebKit/wpe/NEWS (284596 => 284597) --- releases/WebKitGTK/webkit-2.34/Source/WebKit/wpe/NEWS 2021-10-21 09:53:50 UTC (rev 284596) +++ releases/WebKitGTK/webkit-2.34/Source/WebKit/wpe/NEWS 2021-10-21 10:21:00 UTC (rev 284597) @@ -1,4 +1,15 @@ = +WPE WebKit 2.34.1 += + +What's new in WPE WebKit 2.34.0? + + - Update User-Agent browser versions. + - Fix a crash when loading videos on Reddit. + - Fix file type detection when application calls +g_desktop_app_info_set_as_default_for_extension() passing HTML. + += WPE WebKit 2.34.0 = Modified: releases/WebKitGTK/webkit-2.34/Source/cmake/OptionsWPE.cmake (284596 => 284597) --- releases/WebKitGTK/webkit-2.34/Source/cmake/OptionsWPE.cmake 2021-10-21 09:53:50 UTC (rev 284596) +++ releases/WebKitGTK/webkit-2.34/Source/cmake/OptionsWPE.cmake 2021-10-21 10:21:00 UTC (rev 284597) @@ -1,7 +1,7 @@ include(GNUInstallDirs) include(VersioningUtils) -SET_PROJECT_VERSION(2 34 0) +SET_PROJECT_VERSION(2 34 1) set(USER_AGENT_BRANDING "" CACHE STRING "Branding to add to user agent string") @@ -143,9 +143,9 @@ endif () if (WPE_API_VERSION VERSION_EQUAL "1.0") -CALCULATE_LIBRARY_VERSIONS_FROM_LIBTOOL_TRIPLE(WEBKIT 19 2 16) +CALCULATE_LIBRARY_VERSIONS_FROM_LIBTOOL_TRIPLE(WEBKIT 19 3 16) else () -CALCULATE_LIBRARY_VERSIONS_FROM_LIBTOOL_TRIPLE(WEBKIT 0 0 0) +CALCULATE_LIBRARY_VERSIONS_FROM_LIBTOOL_TRIPLE(WEBKIT 0 1 0) endif () # These are shared variables, but we special case their definition so that we can use the ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [284596] trunk/Source/WebCore
Title: [284596] trunk/Source/WebCore
Revision 284596
Author cl...@igalia.com
Date 2021-10-21 02:53:50 -0700 (Thu, 21 Oct 2021)
Log Message
[GTK] Slow scrolling (not matching GTK native scroll amount)
https://bugs.webkit.org/show_bug.cgi?id=197100
Reviewed by Simon Fraser.
Fix up behaviour with interrupting smooth scrolling, mainly on
keyboard-initiated scrolling, but also for the mouse-wheel. When
interrupting a smooth scroll, the animation curve is now changed from
ease-in-out to ease-out and the duration is recalculated.
No new tests, covered by existing tests.
* platform/ScrollAnimation.h:
(WebCore::ScrollAnimation::destinationOffset const):
* platform/ScrollAnimationSmooth.cpp:
(WebCore::ScrollAnimationSmooth::ScrollAnimationSmooth):
(WebCore::ScrollAnimationSmooth::startAnimatedScrollToDestination):
(WebCore::ScrollAnimationSmooth::retargetActiveAnimation):
(WebCore::ScrollAnimationSmooth::animateScroll):
(WebCore::ScrollAnimationSmooth::startOrRetargetAnimation): Deleted.
* platform/ScrollAnimationSmooth.h:
* platform/ScrollAnimator.cpp:
(WebCore::ScrollAnimator::scroll):
* platform/ScrollingEffectsController.cpp:
(WebCore::ScrollingEffectsController::retargetAnimatedScrollBy):
(WebCore::ScrollingEffectsController::handleWheelEvent):
* platform/ScrollingEffectsController.h:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/ScrollAnimation.h
trunk/Source/WebCore/platform/ScrollAnimationSmooth.cpp
trunk/Source/WebCore/platform/ScrollAnimationSmooth.h
trunk/Source/WebCore/platform/ScrollAnimator.cpp
trunk/Source/WebCore/platform/ScrollingEffectsController.cpp
trunk/Source/WebCore/platform/ScrollingEffectsController.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (284595 => 284596)
--- trunk/Source/WebCore/ChangeLog 2021-10-21 09:48:26 UTC (rev 284595)
+++ trunk/Source/WebCore/ChangeLog 2021-10-21 09:53:50 UTC (rev 284596)
@@ -1,3 +1,33 @@
+2021-10-21 Chris Lord
+
+[GTK] Slow scrolling (not matching GTK native scroll amount)
+https://bugs.webkit.org/show_bug.cgi?id=197100
+
+Reviewed by Simon Fraser.
+
+Fix up behaviour with interrupting smooth scrolling, mainly on
+keyboard-initiated scrolling, but also for the mouse-wheel. When
+interrupting a smooth scroll, the animation curve is now changed from
+ease-in-out to ease-out and the duration is recalculated.
+
+No new tests, covered by existing tests.
+
+* platform/ScrollAnimation.h:
+(WebCore::ScrollAnimation::destinationOffset const):
+* platform/ScrollAnimationSmooth.cpp:
+(WebCore::ScrollAnimationSmooth::ScrollAnimationSmooth):
+(WebCore::ScrollAnimationSmooth::startAnimatedScrollToDestination):
+(WebCore::ScrollAnimationSmooth::retargetActiveAnimation):
+(WebCore::ScrollAnimationSmooth::animateScroll):
+(WebCore::ScrollAnimationSmooth::startOrRetargetAnimation): Deleted.
+* platform/ScrollAnimationSmooth.h:
+* platform/ScrollAnimator.cpp:
+(WebCore::ScrollAnimator::scroll):
+* platform/ScrollingEffectsController.cpp:
+(WebCore::ScrollingEffectsController::retargetAnimatedScrollBy):
+(WebCore::ScrollingEffectsController::handleWheelEvent):
+* platform/ScrollingEffectsController.h:
+
2021-10-20 Brady Eidson
WebKit Managed Notifications: Skeleton NotificationProvider
Modified: trunk/Source/WebCore/platform/ScrollAnimation.h (284595 => 284596)
--- trunk/Source/WebCore/platform/ScrollAnimation.h 2021-10-21 09:48:26 UTC (rev 284595)
+++ trunk/Source/WebCore/platform/ScrollAnimation.h 2021-10-21 09:53:50 UTC (rev 284596)
@@ -78,6 +78,7 @@
virtual void updateScrollExtents() { };
FloatPoint currentOffset() const { return m_currentOffset; }
+virtual std::optional destinationOffset() const { return std::nullopt; }
virtual void serviceAnimation(MonotonicTime) = 0;
Modified: trunk/Source/WebCore/platform/ScrollAnimationSmooth.cpp (284595 => 284596)
--- trunk/Source/WebCore/platform/ScrollAnimationSmooth.cpp 2021-10-21 09:48:26 UTC (rev 284595)
+++ trunk/Source/WebCore/platform/ScrollAnimationSmooth.cpp 2021-10-21 09:53:50 UTC (rev 284596)
@@ -41,7 +41,7 @@
ScrollAnimationSmooth::ScrollAnimationSmooth(ScrollAnimationClient& client)
: ScrollAnimation(Type::Smooth, client)
-, m_easeInOutTimingFunction(CubicBezierTimingFunction::create(CubicBezierTimingFunction::TimingFunctionPreset::EaseInOut))
+, m_timingFunction(CubicBezierTimingFunction::create())
{
}
@@ -49,11 +49,21 @@
bool ScrollAnimationSmooth::startAnimatedScrollToDestination(const FloatPoint& fromOffset, const FloatPoint& destinationOffset)
{
+if (!isActive() && fromOffset == destinationOffset)
+return false;
+
+auto extents = m_client.scrollExtentsForAnimation(*this);
+
+m_startTime = MonotonicTime::now();
m_startOffset = fromOffset;
-m_duration =
[webkit-changes] [284595] trunk/Tools
Title: [284595] trunk/Tools Revision 284595 Author gsnedd...@apple.com Date 2021-10-21 02:48:26 -0700 (Thu, 21 Oct 2021) Log Message Move layout_test_finder to layout_test_finder_legacy https://bugs.webkit.org/show_bug.cgi?id=232018 Reviewed by Darin Adler. This is a simple rename; no further changes. * Scripts/open-layout-test: * Scripts/webkitpy/layout_tests/controllers/layout_test_finder_legacy.py: Renamed from Tools/Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py. (_is_reference_html_file): (_has_supported_extension): (LayoutTestFinder): (LayoutTestFinder.__init__): (LayoutTestFinder.find_tests): (LayoutTestFinder.find_tests_by_path): (LayoutTestFinder._expanded_paths): (LayoutTestFinder._real_tests): (LayoutTestFinder._is_test_file): (LayoutTestFinder._is_w3c_resource_file): (LayoutTestFinder._strip_test_dir_prefixes): (LayoutTestFinder._strip_test_dir_prefix): (LayoutTestFinder._read_test_names_from_file): (LayoutTestFinder._strip_comments): * Scripts/webkitpy/layout_tests/controllers/layout_test_finder_legacy_unittest.py: Renamed from Tools/Scripts/webkitpy/layout_tests/controllers/layout_test_finder_unittest.py. (MockLayoutTestFinder): (MockLayoutTestFinder._real_tests): (LayoutTestFinderTests): (LayoutTestFinderTests.make_finder): (LayoutTestFinderTests.test_supported_test_extensions): (LayoutTestFinderTests.test_is_reference_html_file): (LayoutTestFinderTests.test_find_no_paths_specified): (LayoutTestFinderTests.test_find_one_test): (LayoutTestFinderTests.test_find_glob): (LayoutTestFinderTests.test_find_with_skipped_directories): (LayoutTestFinderTests.test_find_with_skipped_directories_2): (LayoutTestFinderTests.test_is_test_file): (LayoutTestFinderTests.test_is_w3c_resource_file): * Scripts/webkitpy/layout_tests/controllers/manager.py: * Scripts/webkitpy/tool/commands/queries.py: Modified Paths trunk/Tools/ChangeLog trunk/Tools/Scripts/open-layout-test trunk/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py trunk/Tools/Scripts/webkitpy/tool/commands/queries.py Added Paths trunk/Tools/Scripts/webkitpy/layout_tests/controllers/layout_test_finder_legacy.py trunk/Tools/Scripts/webkitpy/layout_tests/controllers/layout_test_finder_legacy_unittest.py Removed Paths trunk/Tools/Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py trunk/Tools/Scripts/webkitpy/layout_tests/controllers/layout_test_finder_unittest.py Diff Modified: trunk/Tools/ChangeLog (284594 => 284595) --- trunk/Tools/ChangeLog 2021-10-21 08:46:22 UTC (rev 284594) +++ trunk/Tools/ChangeLog 2021-10-21 09:48:26 UTC (rev 284595) @@ -1,3 +1,45 @@ +2021-10-21 Sam Sneddon + +Move layout_test_finder to layout_test_finder_legacy +https://bugs.webkit.org/show_bug.cgi?id=232018 + +Reviewed by Darin Adler. + +This is a simple rename; no further changes. + +* Scripts/open-layout-test: +* Scripts/webkitpy/layout_tests/controllers/layout_test_finder_legacy.py: Renamed from Tools/Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py. +(_is_reference_html_file): +(_has_supported_extension): +(LayoutTestFinder): +(LayoutTestFinder.__init__): +(LayoutTestFinder.find_tests): +(LayoutTestFinder.find_tests_by_path): +(LayoutTestFinder._expanded_paths): +(LayoutTestFinder._real_tests): +(LayoutTestFinder._is_test_file): +(LayoutTestFinder._is_w3c_resource_file): +(LayoutTestFinder._strip_test_dir_prefixes): +(LayoutTestFinder._strip_test_dir_prefix): +(LayoutTestFinder._read_test_names_from_file): +(LayoutTestFinder._strip_comments): +* Scripts/webkitpy/layout_tests/controllers/layout_test_finder_legacy_unittest.py: Renamed from Tools/Scripts/webkitpy/layout_tests/controllers/layout_test_finder_unittest.py. +(MockLayoutTestFinder): +(MockLayoutTestFinder._real_tests): +(LayoutTestFinderTests): +(LayoutTestFinderTests.make_finder): +(LayoutTestFinderTests.test_supported_test_extensions): +(LayoutTestFinderTests.test_is_reference_html_file): +(LayoutTestFinderTests.test_find_no_paths_specified): +(LayoutTestFinderTests.test_find_one_test): +(LayoutTestFinderTests.test_find_glob): +(LayoutTestFinderTests.test_find_with_skipped_directories): +(LayoutTestFinderTests.test_find_with_skipped_directories_2): +(LayoutTestFinderTests.test_is_test_file): +(LayoutTestFinderTests.test_is_w3c_resource_file): +* Scripts/webkitpy/layout_tests/controllers/manager.py: +* Scripts/webkitpy/tool/commands/queries.py: + 2021-10-21 Carlos Garcia Campos Unreviewed. Fix GTK build with old version of ATSPI after r284367. Modified: trunk/Tools/Scripts/open-layout-test (284594 => 284595) --- trunk/Tools/Scripts/open-layout-test 2021-10-21 08:46:22 UTC (rev 284594) +++ trunk/Tools/Scripts/open-layout-test
[webkit-changes] [284594] releases/WebKitGTK/webkit-2.34.1/
Title: [284594] releases/WebKitGTK/webkit-2.34.1/ Revision 284594 Author carlo...@webkit.org Date 2021-10-21 01:46:22 -0700 (Thu, 21 Oct 2021) Log Message WebKitGTK 2.34.1 Added Paths releases/WebKitGTK/webkit-2.34.1/ Diff ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [284593] releases/WebKitGTK/webkit-2.34
Title: [284593] releases/WebKitGTK/webkit-2.34 Revision 284593 Author carlo...@webkit.org Date 2021-10-21 01:45:55 -0700 (Thu, 21 Oct 2021) Log Message Unreviewed. Update OptionsGTK.cmake and NEWS for 2.34.1 release .: * Source/cmake/OptionsGTK.cmake: Bump version numbers. Source/WebKit: * gtk/NEWS: Add release notes for 2.34.1. Modified Paths releases/WebKitGTK/webkit-2.34/ChangeLog releases/WebKitGTK/webkit-2.34/Source/WebKit/ChangeLog releases/WebKitGTK/webkit-2.34/Source/WebKit/gtk/NEWS releases/WebKitGTK/webkit-2.34/Source/cmake/OptionsGTK.cmake Diff Modified: releases/WebKitGTK/webkit-2.34/ChangeLog (284592 => 284593) --- releases/WebKitGTK/webkit-2.34/ChangeLog 2021-10-21 07:21:43 UTC (rev 284592) +++ releases/WebKitGTK/webkit-2.34/ChangeLog 2021-10-21 08:45:55 UTC (rev 284593) @@ -1,3 +1,9 @@ +2021-10-21 Carlos Garcia Campos + +Unreviewed. Update OptionsGTK.cmake and NEWS for 2.34.1 release + +* Source/cmake/OptionsGTK.cmake: Bump version numbers. + 2021-10-19 Adrian Perez de Castro Unreviewed. Update OptionsWPE.cmake and NEWS for the 2.34.0 release Modified: releases/WebKitGTK/webkit-2.34/Source/WebKit/ChangeLog (284592 => 284593) --- releases/WebKitGTK/webkit-2.34/Source/WebKit/ChangeLog 2021-10-21 07:21:43 UTC (rev 284592) +++ releases/WebKitGTK/webkit-2.34/Source/WebKit/ChangeLog 2021-10-21 08:45:55 UTC (rev 284593) @@ -1,3 +1,9 @@ +2021-10-21 Carlos Garcia Campos + +Unreviewed. Update OptionsGTK.cmake and NEWS for 2.34.1 release + +* gtk/NEWS: Add release notes for 2.34.1. + 2021-10-20 Michael Catanzaro REGRESSION(r276635): [GTK] local HTML file is downloaded instead of displayed if any application has ever called g_desktop_app_info_set_as_default_for_extension(info, "html") Modified: releases/WebKitGTK/webkit-2.34/Source/WebKit/gtk/NEWS (284592 => 284593) --- releases/WebKitGTK/webkit-2.34/Source/WebKit/gtk/NEWS 2021-10-21 07:21:43 UTC (rev 284592) +++ releases/WebKitGTK/webkit-2.34/Source/WebKit/gtk/NEWS 2021-10-21 08:45:55 UTC (rev 284593) @@ -1,4 +1,15 @@ +WebKitGTK 2.34.1 + + +What's new in WebKitGTK 2.34.1? + + - Update user agent browser versions. + - Fix a crash with GTK >= 3.24.30. + - Fix a crash when loading videos on reddit. + - Fix file type detection when application calls g_desktop_app_info_set_as_default_for_extension() passing html. + + WebKitGTK 2.34.0 Modified: releases/WebKitGTK/webkit-2.34/Source/cmake/OptionsGTK.cmake (284592 => 284593) --- releases/WebKitGTK/webkit-2.34/Source/cmake/OptionsGTK.cmake 2021-10-21 07:21:43 UTC (rev 284592) +++ releases/WebKitGTK/webkit-2.34/Source/cmake/OptionsGTK.cmake 2021-10-21 08:45:55 UTC (rev 284593) @@ -3,7 +3,7 @@ WEBKIT_OPTION_BEGIN() -SET_PROJECT_VERSION(2 34 0) +SET_PROJECT_VERSION(2 34 1) set(USER_AGENT_BRANDING "" CACHE STRING "Branding to add to user agent string") @@ -226,11 +226,11 @@ endif () if (WEBKITGTK_API_VERSION VERSION_EQUAL "4.0") -CALCULATE_LIBRARY_VERSIONS_FROM_LIBTOOL_TRIPLE(WEBKIT 92 3 55) -CALCULATE_LIBRARY_VERSIONS_FROM_LIBTOOL_TRIPLE(_javascript_CORE 37 5 19) +CALCULATE_LIBRARY_VERSIONS_FROM_LIBTOOL_TRIPLE(WEBKIT 92 4 55) +CALCULATE_LIBRARY_VERSIONS_FROM_LIBTOOL_TRIPLE(_javascript_CORE 37 6 19) elseif (WEBKITGTK_API_VERSION VERSION_EQUAL "4.1") -CALCULATE_LIBRARY_VERSIONS_FROM_LIBTOOL_TRIPLE(WEBKIT 0 0 0) -CALCULATE_LIBRARY_VERSIONS_FROM_LIBTOOL_TRIPLE(_javascript_CORE 0 0 0) +CALCULATE_LIBRARY_VERSIONS_FROM_LIBTOOL_TRIPLE(WEBKIT 0 1 0) +CALCULATE_LIBRARY_VERSIONS_FROM_LIBTOOL_TRIPLE(_javascript_CORE 0 1 0) elseif (WEBKITGTK_API_VERSION VERSION_EQUAL "5.0") CALCULATE_LIBRARY_VERSIONS_FROM_LIBTOOL_TRIPLE(WEBKIT 0 0 0) CALCULATE_LIBRARY_VERSIONS_FROM_LIBTOOL_TRIPLE(_javascript_CORE 0 0 0) ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [284592] trunk/Tools
Title: [284592] trunk/Tools
Revision 284592
Author carlo...@webkit.org
Date 2021-10-21 00:21:43 -0700 (Thu, 21 Oct 2021)
Log Message
Unreviewed. Fix GTK build with old version of ATSPI after r284367.
There's not API to check ATSPI version, so check if ATSPI_SCROLLTYPE_COUNT is defined to know if component
scroll API is available.
* TestWebKitAPI/Tests/WebKitGtk/TestWebKitAccessibility.cpp:
(beforeAll):
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WebKitGtk/TestWebKitAccessibility.cpp
Diff
Modified: trunk/Tools/ChangeLog (284591 => 284592)
--- trunk/Tools/ChangeLog 2021-10-21 06:51:48 UTC (rev 284591)
+++ trunk/Tools/ChangeLog 2021-10-21 07:21:43 UTC (rev 284592)
@@ -1,3 +1,13 @@
+2021-10-21 Carlos Garcia Campos
+
+Unreviewed. Fix GTK build with old version of ATSPI after r284367.
+
+There's not API to check ATSPI version, so check if ATSPI_SCROLLTYPE_COUNT is defined to know if component
+scroll API is available.
+
+* TestWebKitAPI/Tests/WebKitGtk/TestWebKitAccessibility.cpp:
+(beforeAll):
+
2021-10-20 Brady Eidson
WebKit Managed Notifications: Skeleton NotificationProvider
Modified: trunk/Tools/TestWebKitAPI/Tests/WebKitGtk/TestWebKitAccessibility.cpp (284591 => 284592)
--- trunk/Tools/TestWebKitAPI/Tests/WebKitGtk/TestWebKitAccessibility.cpp 2021-10-21 06:51:48 UTC (rev 284591)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKitGtk/TestWebKitAccessibility.cpp 2021-10-21 07:21:43 UTC (rev 284592)
@@ -757,6 +757,7 @@
g_assert_true(accessible.get() == documentWeb.get());
}
+#ifdef ATSPI_SCROLLTYPE_COUNT
static void testComponentScrollTo(AccessibilityTest* test, gconstpointer)
{
test->showInWindow(640, 480);
@@ -802,6 +803,7 @@
g_assert_cmpint(topPositionBeforeScrolling->x, ==, topPositionAfterScrolling->x);
g_assert_cmpint(topPositionBeforeScrolling->y, ==, topPositionAfterScrolling->y);
}
+#endif
void beforeAll()
{
@@ -812,7 +814,9 @@
AccessibilityTest::add("WebKitAccessibility", "accessible/state", testAccessibleState);
AccessibilityTest::add("WebKitAccessibility", "accessible/state-changed", testAccessibleStateChanged);
AccessibilityTest::add("WebKitAccessibility", "component/hit-test", testComponentHitTest);
+#ifdef ATSPI_SCROLLTYPE_COUNT
AccessibilityTest::add("WebKitAccessibility", "component/scroll-to", testComponentScrollTo);
+#endif
}
void afterAll()
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [284591] trunk
Title: [284591] trunk Revision 284591 Author beid...@apple.com Date 2021-10-20 23:51:48 -0700 (Wed, 20 Oct 2021) Log Message WebKit Managed Notifications: Skeleton NotificationProvider https://bugs.webkit.org/show_bug.cgi?id=231786 Reviewed by Alex Christensen. Source/WebCore: * page/RuntimeEnabledFeatures.h: (WebCore::RuntimeEnabledFeatures::setBuiltInNotificationsEnabled): (WebCore::RuntimeEnabledFeatures::builtInNotificationsEnabled const): Source/WebKit: Currently, notification messages route from WebContent to the UI process. When "WebKit-managed built-in notifications" are enabled, notification requests will route from WebContent to Networking instead. >From there they will head off to webpushd to be handled. This patch just sets up the switch where messages can optionally head off to the Networking process instead of the UIProcess. (It also lays the SPI groundwork for the webpushd mach service name) * NetworkProcess/NetworkSession.cpp: (WebKit::NetworkSession::NetworkSession): (WebKit::NetworkSession::~NetworkSession): * NetworkProcess/NetworkSession.h: * NetworkProcess/NetworkSessionCreationParameters.cpp: (WebKit::NetworkSessionCreationParameters::encode const): (WebKit::NetworkSessionCreationParameters::decode): * NetworkProcess/NetworkSessionCreationParameters.h: * NetworkProcess/Notifications/NetworkNotificationManager.cpp: Added. (WebKit::NetworkNotificationManager::NetworkNotificationManager): (WebKit::NetworkNotificationManager::showNotification): (WebKit::NetworkNotificationManager::cancelNotification): (WebKit::NetworkNotificationManager::clearNotifications): (WebKit::NetworkNotificationManager::didDestroyNotification): * NetworkProcess/Notifications/NetworkNotificationManager.h: Added. * NetworkProcess/WebStorage/LocalStorageDatabase.cpp: Unified build fixup. * Sources.txt: * UIProcess/API/Cocoa/_WKWebsiteDataStoreConfiguration.h: * UIProcess/API/Cocoa/_WKWebsiteDataStoreConfiguration.mm: (-[_WKWebsiteDataStoreConfiguration webPushMachServiceName]): (-[_WKWebsiteDataStoreConfiguration setWebPushMachServiceName:]): * UIProcess/WebsiteData/WebsiteDataStore.cpp: (WebKit::WebsiteDataStore::parameters): * UIProcess/WebsiteData/WebsiteDataStoreConfiguration.h: (WebKit::WebsiteDataStoreConfiguration::setWebPushMachServiceName): (WebKit::WebsiteDataStoreConfiguration::webPushMachServiceName const): * WebKit.xcodeproj/project.pbxproj: * WebProcess/Notifications/WebNotificationManager.cpp: (WebKit::sendNotificationMessage): (WebKit::WebNotificationManager::show): (WebKit::WebNotificationManager::cancel): (WebKit::WebNotificationManager::clearNotifications): (WebKit::WebNotificationManager::didDestroyNotification): Source/WTF: * Scripts/Preferences/WebPreferencesExperimental.yaml: * wtf/PlatformEnableCocoa.h: Tools: * WebKitTestRunner/TestOptions.cpp: (WTR::TestOptions::defaults): Disable BuiltInNotificationsEnabled for now. Modified Paths trunk/Source/WTF/ChangeLog trunk/Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml trunk/Source/WTF/wtf/PlatformEnableCocoa.h trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/page/RuntimeEnabledFeatures.h trunk/Source/WebKit/CMakeLists.txt trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.cpp trunk/Source/WebKit/NetworkProcess/NetworkSession.cpp trunk/Source/WebKit/NetworkProcess/NetworkSession.h trunk/Source/WebKit/NetworkProcess/NetworkSessionCreationParameters.cpp trunk/Source/WebKit/NetworkProcess/NetworkSessionCreationParameters.h trunk/Source/WebKit/NetworkProcess/WebStorage/LocalStorageDatabase.cpp trunk/Source/WebKit/Sources.txt trunk/Source/WebKit/UIProcess/API/Cocoa/_WKWebsiteDataStoreConfiguration.h trunk/Source/WebKit/UIProcess/API/Cocoa/_WKWebsiteDataStoreConfiguration.mm trunk/Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.cpp trunk/Source/WebKit/UIProcess/WebsiteData/WebsiteDataStoreConfiguration.h trunk/Source/WebKit/WebKit.xcodeproj/project.pbxproj trunk/Source/WebKit/WebProcess/Notifications/WebNotificationManager.cpp trunk/Tools/ChangeLog trunk/Tools/WebKitTestRunner/TestOptions.cpp Added Paths trunk/Source/WebKit/NetworkProcess/Notifications/ trunk/Source/WebKit/NetworkProcess/Notifications/NetworkNotificationManager.cpp trunk/Source/WebKit/NetworkProcess/Notifications/NetworkNotificationManager.h Diff Modified: trunk/Source/WTF/ChangeLog (284590 => 284591) --- trunk/Source/WTF/ChangeLog 2021-10-21 06:27:53 UTC (rev 284590) +++ trunk/Source/WTF/ChangeLog 2021-10-21 06:51:48 UTC (rev 284591) @@ -1,3 +1,13 @@ +2021-10-20 Brady Eidson + +WebKit Managed Notifications: Skeleton NotificationProvider +https://bugs.webkit.org/show_bug.cgi?id=231786 + +Reviewed by Alex Christensen. + +* Scripts/Preferences/WebPreferencesExperimental.yaml: +* wtf/PlatformEnableCocoa.h: + 2021-10-20 Alex Christensen URLParser should reject hosts with C0 control characters or U+007F Modified:
[webkit-changes] [284590] trunk/Source/JavaScriptCore
Title: [284590] trunk/Source/_javascript_Core Revision 284590 Author ysuz...@apple.com Date 2021-10-20 23:27:53 -0700 (Wed, 20 Oct 2021) Log Message *IsSane API's could take in the Structure's we're consulting, or they can be out parameters, so we don't rely on the CPU's memory ordering https://bugs.webkit.org/show_bug.cgi?id=231996 Reviewed by Filip Pizlo. objectPrototypeIsSane, arrayPrototypeChainIsSane, and stringPrototypeChainIsSane reloads structures from prototype objects while the caller is already getting them and validating them. This introduces a race condition where structure transition happens just before calling these APIs and we will see different structures which are already validated. This is simply wrong: if we validate one structure, then we should continue using that and we should put a watchpoint on this structure. We should not reload structures from the prototype again. We add Concurrently postfix to these functions, and passing structures to these APIs to continue using these structures instead of reloading it from prototype objects. This eliminate the race condition we had, and this removes the necessity of load-load-fence on watchpoint state retrieval. * dfg/DFGAbstractInterpreterInlines.h: (JSC::DFG::AbstractInterpreter::executeEffects): * dfg/DFGArgumentsEliminationPhase.cpp: * dfg/DFGArrayMode.cpp: (JSC::DFG::ArrayMode::refine const): * dfg/DFGByteCodeParser.cpp: (JSC::DFG::ByteCodeParser::handleIntrinsicCall): * dfg/DFGFixupPhase.cpp: (JSC::DFG::FixupPhase::fixupNode): (JSC::DFG::FixupPhase::setSaneChainIfPossible): * dfg/DFGSpeculativeJIT.cpp: (JSC::DFG::SpeculativeJIT::compileGetByValOnString): * ftl/FTLLowerDFGToB3.cpp: (JSC::FTL::DFG::LowerDFGToB3::compileStringCharAtImpl): * runtime/JSGlobalObject.h: * runtime/JSGlobalObjectInlines.h: (JSC::JSGlobalObject::objectPrototypeIsSane): (JSC::JSGlobalObject::arrayPrototypeChainIsSaneConcurrently): (JSC::JSGlobalObject::stringPrototypeChainIsSaneConcurrently): (JSC::JSGlobalObject::arrayPrototypeChainIsSane): (JSC::JSGlobalObject::stringPrototypeChainIsSane): Modified Paths trunk/Source/_javascript_Core/ChangeLog trunk/Source/_javascript_Core/dfg/DFGAbstractInterpreterInlines.h trunk/Source/_javascript_Core/dfg/DFGArgumentsEliminationPhase.cpp trunk/Source/_javascript_Core/dfg/DFGArrayMode.cpp trunk/Source/_javascript_Core/dfg/DFGByteCodeParser.cpp trunk/Source/_javascript_Core/dfg/DFGFixupPhase.cpp trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.cpp trunk/Source/_javascript_Core/ftl/FTLLowerDFGToB3.cpp trunk/Source/_javascript_Core/runtime/JSGlobalObject.h trunk/Source/_javascript_Core/runtime/JSGlobalObjectInlines.h Diff Modified: trunk/Source/_javascript_Core/ChangeLog (284589 => 284590) --- trunk/Source/_javascript_Core/ChangeLog 2021-10-21 06:15:51 UTC (rev 284589) +++ trunk/Source/_javascript_Core/ChangeLog 2021-10-21 06:27:53 UTC (rev 284590) @@ -1,5 +1,43 @@ 2021-10-20 Yusuke Suzuki +*IsSane API's could take in the Structure's we're consulting, or they can be out parameters, so we don't rely on the CPU's memory ordering +https://bugs.webkit.org/show_bug.cgi?id=231996 + +Reviewed by Filip Pizlo. + +objectPrototypeIsSane, arrayPrototypeChainIsSane, and stringPrototypeChainIsSane reloads structures from prototype objects while the caller +is already getting them and validating them. This introduces a race condition where structure transition happens just before calling these +APIs and we will see different structures which are already validated. This is simply wrong: if we validate one structure, then we should +continue using that and we should put a watchpoint on this structure. We should not reload structures from the prototype again. + +We add Concurrently postfix to these functions, and passing structures to these APIs to continue using these structures instead of reloading +it from prototype objects. This eliminate the race condition we had, and this removes the necessity of load-load-fence on watchpoint state +retrieval. + +* dfg/DFGAbstractInterpreterInlines.h: +(JSC::DFG::AbstractInterpreter::executeEffects): +* dfg/DFGArgumentsEliminationPhase.cpp: +* dfg/DFGArrayMode.cpp: +(JSC::DFG::ArrayMode::refine const): +* dfg/DFGByteCodeParser.cpp: +(JSC::DFG::ByteCodeParser::handleIntrinsicCall): +* dfg/DFGFixupPhase.cpp: +(JSC::DFG::FixupPhase::fixupNode): +(JSC::DFG::FixupPhase::setSaneChainIfPossible): +* dfg/DFGSpeculativeJIT.cpp: +(JSC::DFG::SpeculativeJIT::compileGetByValOnString): +* ftl/FTLLowerDFGToB3.cpp: +(JSC::FTL::DFG::LowerDFGToB3::compileStringCharAtImpl): +* runtime/JSGlobalObject.h: +* runtime/JSGlobalObjectInlines.h: +(JSC::JSGlobalObject::objectPrototypeIsSane): +(JSC::JSGlobalObject::arrayPrototypeChainIsSaneConcurrently): +
[webkit-changes] [284589] trunk/LayoutTests
Title: [284589] trunk/LayoutTests Revision 284589 Author an...@apple.com Date 2021-10-20 23:15:51 -0700 (Wed, 20 Oct 2021) Log Message [ iOS ] fast/inline/inline-background-clip-text-multiline.html is image failing https://bugs.webkit.org/show_bug.cgi?id=231961 Unreviewed. Fix the test to not depend on font rendering details. * fast/inline/inline-background-clip-text-multiline-expected.html: * fast/inline/inline-background-clip-text-multiline.html: * platform/ios-wk2/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/fast/inline/inline-background-clip-text-multiline-expected.html trunk/LayoutTests/fast/inline/inline-background-clip-text-multiline.html trunk/LayoutTests/platform/ios-wk2/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (284588 => 284589) --- trunk/LayoutTests/ChangeLog 2021-10-21 00:03:30 UTC (rev 284588) +++ trunk/LayoutTests/ChangeLog 2021-10-21 06:15:51 UTC (rev 284589) @@ -1,3 +1,17 @@ +2021-10-20 Antti Koivisto + +[ iOS ] fast/inline/inline-background-clip-text-multiline.html is image failing +https://bugs.webkit.org/show_bug.cgi?id=231961 + + +Unreviewed. + +Fix the test to not depend on font rendering details. + +* fast/inline/inline-background-clip-text-multiline-expected.html: +* fast/inline/inline-background-clip-text-multiline.html: +* platform/ios-wk2/TestExpectations: + 2021-10-20 Ayumi Kojima [ macOS ] imported/w3c/web-platform-tests/xhr/event-upload-progress-crossorigin.any.html is a flaky failure. Modified: trunk/LayoutTests/fast/inline/inline-background-clip-text-multiline-expected.html (284588 => 284589) --- trunk/LayoutTests/fast/inline/inline-background-clip-text-multiline-expected.html 2021-10-21 00:03:30 UTC (rev 284588) +++ trunk/LayoutTests/fast/inline/inline-background-clip-text-multiline-expected.html 2021-10-21 06:15:51 UTC (rev 284589) @@ -1,6 +1,8 @@
