date:20211101

[webkit-changes] [285153] branches/safari-612-branch/Source

2021-11-01 Thread repstein

Title: [285153] branches/safari-612-branch/Source








Revision 285153
Author repst...@apple.com
Date 2021-11-01 21:55:23 -0700 (Mon, 01 Nov 2021)


Log Message
Versioning.

WebKit-7612.3.4

Modified Paths

branches/safari-612-branch/Source/_javascript_Core/Configurations/Version.xcconfig
branches/safari-612-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig
branches/safari-612-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig
branches/safari-612-branch/Source/WebCore/Configurations/Version.xcconfig
branches/safari-612-branch/Source/WebCore/PAL/Configurations/Version.xcconfig
branches/safari-612-branch/Source/WebInspectorUI/Configurations/Version.xcconfig
branches/safari-612-branch/Source/WebKit/Configurations/Version.xcconfig
branches/safari-612-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig




Diff

Modified: branches/safari-612-branch/Source/_javascript_Core/Configurations/Version.xcconfig (285152 => 285153)

--- branches/safari-612-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2021-11-02 03:42:34 UTC (rev 285152)
+++ branches/safari-612-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2021-11-02 04:55:23 UTC (rev 285153)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 612;
 MINOR_VERSION = 3;
-TINY_VERSION = 3;
+TINY_VERSION = 4;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: branches/safari-612-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig (285152 => 285153)

--- branches/safari-612-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig	2021-11-02 03:42:34 UTC (rev 285152)
+++ branches/safari-612-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig	2021-11-02 04:55:23 UTC (rev 285153)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 612;
 MINOR_VERSION = 3;
-TINY_VERSION = 3;
+TINY_VERSION = 4;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: branches/safari-612-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (285152 => 285153)

--- branches/safari-612-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2021-11-02 03:42:34 UTC (rev 285152)
+++ branches/safari-612-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2021-11-02 04:55:23 UTC (rev 285153)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 612;
 MINOR_VERSION = 3;
-TINY_VERSION = 3;
+TINY_VERSION = 4;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: branches/safari-612-branch/Source/WebCore/Configurations/Version.xcconfig (285152 => 285153)

--- branches/safari-612-branch/Source/WebCore/Configurations/Version.xcconfig	2021-11-02 03:42:34 UTC (rev 285152)
+++ branches/safari-612-branch/Source/WebCore/Configurations/Version.xcconfig	2021-11-02 04:55:23 UTC (rev 285153)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 612;
 MINOR_VERSION = 3;
-TINY_VERSION = 3;
+TINY_VERSION = 4;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: branches/safari-612-branch/Source/WebCore/PAL/Configurations/Version.xcconfig (285152 => 285153)

--- branches/safari-612-branch/Source/WebCore/PAL/Configurations/Version.xcconfig	2021-11-02 03:42:34 UTC (rev 285152)
+++ branches/safari-612-branch/Source/WebCore/PAL/Configurations/Version.xcconfig	2021-11-02 04:55:23 UTC (rev 285153)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 612;
 MINOR_VERSION = 3;
-TINY_VERSION = 3;
+TINY_VERSION = 4;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: branches/safari-612-branch/Source/WebInspectorUI/Configurations/Version.xcconfig (285152 => 285153)

--- branches/safari-612-branch/Source/WebInspectorUI/Configurations/Version.xcconfig	2021-11-02 03:42:34 UTC (rev 285152)
+++ branches/safari-612-branch/Source/WebInspectorUI/Configurations/Version.xcconfig	2021-11-02 04:55:23 UTC (rev 285153)
@@ -1,6 +1,6 @@
 MAJOR_VERSION = 612;
 MINOR_VERSION = 3;
-TINY_VERSION = 3;
+TINY_VERSION = 4;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: branches/safari-612-branch/Source/WebKit/Configurations/Version.xcconfig (285152 => 285153)

--- branches/safari-612-branch/Source/WebKit/Configurations/Version.xcconfig	2021-11-02 03:42:34 UTC (rev 285152)
+++ branches/safari-612-branch/Source/WebKit/Configurations/Version.xcconfig	2021-11-02 04:55:23 UTC (rev 285153)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 612;
 MINOR_VERSION = 3;
-TINY_VERSION = 3;
+TINY_VERSION = 4;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: branches/safari-612-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig (285152 => 285153)

--- branches/safari-612-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig	2021-11-02 03:42:34 UTC

[webkit-changes] [285152] trunk/Source/JavaScriptCore

2021-11-01 Thread ross . kirsling

Title: [285152] trunk/Source/_javascript_Core








Revision 285152
Author ross.kirsl...@sony.com
Date 2021-11-01 20:42:34 -0700 (Mon, 01 Nov 2021)


Log Message
[JSC][LLInt] Non-commutative binops are hard to reason about when operands are labelled in reverse
https://bugs.webkit.org/show_bug.cgi?id=232598

Reviewed by Saam Barati.

In offlineasm, `OP a, b, c` is `c = a OP b` but `OP a, b` is `b = b OP a`.

This can make identifiers like `left` and `right` quite confusing --
simple cases like `subd left, right` are already misleading, while OpDiv literally
passes its RHS to a macro as `left` and then checks `left` for division by zero.
It becomes difficult to keep this all in one's brain without rewriting it on paper.

This patch may not constitute a "complete solution", but it at least makes our naming honest:
1. Use 3-argument syntax (as `left, right, result`) whenever possible.
2. When not possible (e.g. because `bsubio` isn't flexible about its arguments or
   because x86 doesn't have 3-argument shift operations), then say `rhs, lhs` explicitly.

* llint/LowLevelInterpreter32_64.asm:
* llint/LowLevelInterpreter64.asm:

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/llint/LowLevelInterpreter32_64.asm
trunk/Source/_javascript_Core/llint/LowLevelInterpreter64.asm




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (285151 => 285152)

--- trunk/Source/_javascript_Core/ChangeLog	2021-11-02 03:25:30 UTC (rev 285151)
+++ trunk/Source/_javascript_Core/ChangeLog	2021-11-02 03:42:34 UTC (rev 285152)
@@ -1,3 +1,25 @@
+2021-11-01  Ross Kirsling  
+
+[JSC][LLInt] Non-commutative binops are hard to reason about when operands are labelled in reverse
+https://bugs.webkit.org/show_bug.cgi?id=232598
+
+Reviewed by Saam Barati.
+
+In offlineasm, `OP a, b, c` is `c = a OP b` but `OP a, b` is `b = b OP a`.
+
+This can make identifiers like `left` and `right` quite confusing --
+simple cases like `subd left, right` are already misleading, while OpDiv literally
+passes its RHS to a macro as `left` and then checks `left` for division by zero.
+It becomes difficult to keep this all in one's brain without rewriting it on paper.
+
+This patch may not constitute a "complete solution", but it at least makes our naming honest:
+1. Use 3-argument syntax (as `left, right, result`) whenever possible.
+2. When not possible (e.g. because `bsubio` isn't flexible about its arguments or
+   because x86 doesn't have 3-argument shift operations), then say `rhs, lhs` explicitly.
+
+* llint/LowLevelInterpreter32_64.asm:
+* llint/LowLevelInterpreter64.asm:
+
 2021-11-01  Yusuke Suzuki  
 
 [JSC] LLIntCallee should have two replacements


Modified: trunk/Source/_javascript_Core/llint/LowLevelInterpreter32_64.asm (285151 => 285152)

--- trunk/Source/_javascript_Core/llint/LowLevelInterpreter32_64.asm	2021-11-02 03:25:30 UTC (rev 285151)
+++ trunk/Source/_javascript_Core/llint/LowLevelInterpreter32_64.asm	2021-11-02 03:42:34 UTC (rev 285152)
@@ -1118,7 +1118,7 @@
 bineq t3, Int32Tag, .op2NotInt
 updateBinaryArithProfile(size, opcodeStruct, ArithProfileIntInt, t5, t2)
 get(m_dst, t2)
-integerOperationAndStore(t3, t1, t0, .slow, t2)
+integerOperationAndStore(t3, t0, t1, .slow, t2)
 dispatch()
 
 .op1NotInt:
@@ -1135,7 +1135,7 @@
 .op1NotIntReady:
 get(m_dst, t1)
 fii2d t0, t2, ft0
-doubleOperation(ft1, ft0)
+doubleOperation(ft0, ft1, ft0)
 stored ft0, [cfr, t1, 8]
 dispatch()
 
@@ -1146,7 +1146,7 @@
 get(m_dst, t2)
 ci2ds t0, ft0
 fii2d t1, t3, ft1
-doubleOperation(ft1, ft0)
+doubleOperation(ft0, ft1, ft0)
 stored ft0, [cfr, t2, 8]
 dispatch()
 
@@ -1158,53 +1158,53 @@
 
 macro binaryOp(opcodeName, opcodeStruct, integerOperation, doubleOperation)
 binaryOpCustomStore(opcodeName, opcodeStruct,
-macro (int32Tag, left, right, slow, index)
-integerOperation(left, right, slow)
+macro (int32Tag, lhs, rhs, slow, index)
+integerOperation(lhs, rhs, slow)
 storei int32Tag, TagOffset[cfr, index, 8]
-storei right, PayloadOffset[cfr, index, 8]
+storei lhs, PayloadOffset[cfr, index, 8]
 end,
 doubleOperation)
 end
 
 binaryOp(add, OpAdd,
-macro (left, right, slow) baddio left, right, slow end,
-macro (left, right) addd left, right end)
+macro (lhs, rhs, slow) baddio rhs, lhs, slow end,
+macro (left, right, result) addd left, right, result end)
 
 
 binaryOpCustomStore(mul, OpMul,
-macro (int32Tag, left, right, slow, index)
+macro (int32Tag, lhs, rhs, slow, index)
 const scratch = int32Tag   # We know that we can reuse the int32Tag register since it has a constant.
-move right, scratch
-bmulio left,

[webkit-changes] [285151] trunk/Source/WebCore

2021-11-01 Thread don . olmstead

Title: [285151] trunk/Source/WebCore








Revision 285151
Author don.olmst...@sony.com
Date 2021-11-01 20:25:30 -0700 (Mon, 01 Nov 2021)


Log Message
[Curl] Fix -Wreorder-ctor in CurlRequest
https://bugs.webkit.org/show_bug.cgi?id=232591

Reviewed by Ross Kirsling.

Reorder member initializer list in CurlRequest::CurlRequest to follow the ordering of
members in its declaration.

* platform/network/curl/CurlRequest.cpp:
(WebCore::CurlRequest::CurlRequest):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/network/curl/CurlRequest.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (285150 => 285151)

--- trunk/Source/WebCore/ChangeLog	2021-11-02 02:30:27 UTC (rev 285150)
+++ trunk/Source/WebCore/ChangeLog	2021-11-02 03:25:30 UTC (rev 285151)
@@ -1,5 +1,18 @@
 2021-11-01  Don Olmstead  
 
+[Curl] Fix -Wreorder-ctor in CurlRequest
+https://bugs.webkit.org/show_bug.cgi?id=232591
+
+Reviewed by Ross Kirsling.
+
+Reorder member initializer list in CurlRequest::CurlRequest to follow the ordering of
+members in its declaration.
+
+* platform/network/curl/CurlRequest.cpp:
+(WebCore::CurlRequest::CurlRequest):
+
+2021-11-01  Don Olmstead  
+
 [AX] Fix signature of childrenChanged when !ENABLE(ACCESSIBILITY)
 https://bugs.webkit.org/show_bug.cgi?id=232590
 


Modified: trunk/Source/WebCore/platform/network/curl/CurlRequest.cpp (285150 => 285151)

--- trunk/Source/WebCore/platform/network/curl/CurlRequest.cpp	2021-11-02 02:30:27 UTC (rev 285150)
+++ trunk/Source/WebCore/platform/network/curl/CurlRequest.cpp	2021-11-02 03:25:30 UTC (rev 285151)
@@ -46,8 +46,8 @@
 : m_client(client)
 , m_messageQueue(WTFMove(messageQueue))
 , m_request(request.isolatedCopy())
+, m_enableMultipart(enableMultipart == EnableMultipart::Yes)
 , m_startState(shouldSuspend == ShouldSuspend::Yes ? StartState::StartSuspended : StartState::WaitingForStart)
-, m_enableMultipart(enableMultipart == EnableMultipart::Yes)
 , m_formDataStream(m_request.httpBody())
 , m_captureExtraMetrics(captureExtraMetrics == CaptureNetworkLoadMetrics::Extended)
 {






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [285150] trunk/Tools

2021-11-01 Thread Hironori . Fujii

Title: [285150] trunk/Tools








Revision 285150
Author hironori.fu...@sony.com
Date 2021-11-01 19:30:27 -0700 (Mon, 01 Nov 2021)


Log Message
ImageDiff.cpp(74): warning C4477: 'fprintf' : format string '%lu' requires an argument of type 'unsigned long', but variadic argument 2 has type 'size_t'
https://bugs.webkit.org/show_bug.cgi?id=232596

Reviewed by Don Olmstead.

Since r284764, MSVC reports the following warning and a suggestion.

> Tools\ImageDiff\ImageDiff.cpp(74): warning C4477: 'fprintf' : format string '%lu' requires an argument of type 'unsigned long', but variadic argument 2 has type 'size_t'
> Tools\ImageDiff\ImageDiff.cpp(74): note: consider using '%zu' in the format string

* ImageDiff/ImageDiff.cpp:
(processImages): Use %zu for size_t.

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/ImageDiff/ImageDiff.cpp




Diff

Modified: trunk/Tools/ChangeLog (285149 => 285150)

--- trunk/Tools/ChangeLog	2021-11-02 01:14:49 UTC (rev 285149)
+++ trunk/Tools/ChangeLog	2021-11-02 02:30:27 UTC (rev 285150)
@@ -1,3 +1,18 @@
+2021-11-01  Fujii Hironori  
+
+ImageDiff.cpp(74): warning C4477: 'fprintf' : format string '%lu' requires an argument of type 'unsigned long', but variadic argument 2 has type 'size_t'
+https://bugs.webkit.org/show_bug.cgi?id=232596
+
+Reviewed by Don Olmstead.
+
+Since r284764, MSVC reports the following warning and a suggestion.
+
+> Tools\ImageDiff\ImageDiff.cpp(74): warning C4477: 'fprintf' : format string '%lu' requires an argument of type 'unsigned long', but variadic argument 2 has type 'size_t'
+> Tools\ImageDiff\ImageDiff.cpp(74): note: consider using '%zu' in the format string
+
+* ImageDiff/ImageDiff.cpp:
+(processImages): Use %zu for size_t.
+
 2021-11-01  Jonathan Bedard  
 
 [webkitscmpy] Only respect the latest review


Modified: trunk/Tools/ImageDiff/ImageDiff.cpp (285149 => 285150)

--- trunk/Tools/ImageDiff/ImageDiff.cpp	2021-11-02 01:14:49 UTC (rev 285149)
+++ trunk/Tools/ImageDiff/ImageDiff.cpp	2021-11-02 02:30:27 UTC (rev 285150)
@@ -71,7 +71,7 @@
 fprintf(stdout, "diff: %01.8f%%\n", differenceData.percentageDifference);
 
 if (printDifference)
-fprintf(stdout, "maxDifference=%u; totalPixels=%lu\n", differenceData.maxDifference, differenceData.totalPixels);
+fprintf(stdout, "maxDifference=%u; totalPixels=%zu\n", differenceData.maxDifference, differenceData.totalPixels);
 
 fprintf(stdout, "#EOF\n");
 fflush(stdout);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [285149] trunk/Source/JavaScriptCore

2021-11-01 Thread ysuzuki

Title: [285149] trunk/Source/_javascript_Core








Revision 285149
Author ysuz...@apple.com
Date 2021-11-01 18:14:49 -0700 (Mon, 01 Nov 2021)


Log Message
[JSC] LLIntCallee should have two replacements
https://bugs.webkit.org/show_bug.cgi?id=228552
rdar://81217357

Reviewed by Saam Barati.

LLIntCallee can be used for signaling memory and bounds-checking memory.
Thus it should have two replacements for each mode.

* wasm/WasmBBQPlan.cpp:
(JSC::Wasm::BBQPlan::work):
* wasm/WasmCallee.h:
(JSC::Wasm::Callee::setOSREntryCallee):
* wasm/WasmOMGForOSREntryPlan.cpp:
(JSC::Wasm::OMGForOSREntryPlan::work):
* wasm/WasmOMGPlan.cpp:
(JSC::Wasm::OMGPlan::work):
* wasm/WasmPlan.cpp:
(JSC::Wasm::Plan::updateCallSitesToCallUs):
* wasm/WasmSlowPaths.cpp:
(JSC::LLInt::jitCompileAndSetHeuristics):
(JSC::LLInt::WASM_SLOW_PATH_DECL):

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/wasm/WasmBBQPlan.cpp
trunk/Source/_javascript_Core/wasm/WasmCallee.h
trunk/Source/_javascript_Core/wasm/WasmOMGForOSREntryPlan.cpp
trunk/Source/_javascript_Core/wasm/WasmOMGPlan.cpp
trunk/Source/_javascript_Core/wasm/WasmPlan.cpp
trunk/Source/_javascript_Core/wasm/WasmSlowPaths.cpp




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (285148 => 285149)

--- trunk/Source/_javascript_Core/ChangeLog	2021-11-02 01:06:14 UTC (rev 285148)
+++ trunk/Source/_javascript_Core/ChangeLog	2021-11-02 01:14:49 UTC (rev 285149)
@@ -1,3 +1,28 @@
+2021-11-01  Yusuke Suzuki  
+
+[JSC] LLIntCallee should have two replacements
+https://bugs.webkit.org/show_bug.cgi?id=228552
+rdar://81217357
+
+Reviewed by Saam Barati.
+
+LLIntCallee can be used for signaling memory and bounds-checking memory.
+Thus it should have two replacements for each mode.
+
+* wasm/WasmBBQPlan.cpp:
+(JSC::Wasm::BBQPlan::work):
+* wasm/WasmCallee.h:
+(JSC::Wasm::Callee::setOSREntryCallee):
+* wasm/WasmOMGForOSREntryPlan.cpp:
+(JSC::Wasm::OMGForOSREntryPlan::work):
+* wasm/WasmOMGPlan.cpp:
+(JSC::Wasm::OMGPlan::work):
+* wasm/WasmPlan.cpp:
+(JSC::Wasm::Plan::updateCallSitesToCallUs):
+* wasm/WasmSlowPaths.cpp:
+(JSC::LLInt::jitCompileAndSetHeuristics):
+(JSC::LLInt::WASM_SLOW_PATH_DECL):
+
 2021-11-01  Saam Barati  
 
 ArrayBuffer species watchpoint being invalidated doesn't mean it's not an ArrayBuffer constructor from the same global object


Modified: trunk/Source/_javascript_Core/wasm/WasmBBQPlan.cpp (285148 => 285149)

--- trunk/Source/_javascript_Core/wasm/WasmBBQPlan.cpp	2021-11-02 01:06:14 UTC (rev 285148)
+++ trunk/Source/_javascript_Core/wasm/WasmBBQPlan.cpp	2021-11-02 01:14:49 UTC (rev 285149)
@@ -150,7 +150,7 @@
 {
 LLIntCallee& llintCallee = m_codeBlock->m_llintCallees->at(m_functionIndex).get();
 Locker locker { llintCallee.tierUpCounter().m_lock };
-llintCallee.setReplacement(callee.copyRef());
+llintCallee.setReplacement(callee.copyRef(), mode());
 llintCallee.tierUpCounter().m_compilationStatus = LLIntTierUpCounter::CompilationStatus::Compiled;
 }
 }


Modified: trunk/Source/_javascript_Core/wasm/WasmCallee.h (285148 => 285149)

--- trunk/Source/_javascript_Core/wasm/WasmCallee.h	2021-11-02 01:06:14 UTC (rev 285148)
+++ trunk/Source/_javascript_Core/wasm/WasmCallee.h	2021-11-02 01:14:49 UTC (rev 285149)
@@ -66,7 +66,7 @@
 bool hasExceptionHandlers() const { return !!m_exceptionHandlers.size(); }
 
 #if ENABLE(WEBASSEMBLY_B3JIT)
-virtual void setOSREntryCallee(Ref&&)
+virtual void setOSREntryCallee(Ref&&, MemoryMode)
 {
 RELEASE_ASSERT_NOT_REACHED();
 }
@@ -193,7 +193,7 @@
 }
 
 OMGForOSREntryCallee* osrEntryCallee() { return m_osrEntryCallee.get(); }
-void setOSREntryCallee(Ref&& osrEntryCallee) final
+void setOSREntryCallee(Ref&& osrEntryCallee, MemoryMode) final
 {
 m_osrEntryCallee = WTFMove(osrEntryCallee);
 }
@@ -238,16 +238,16 @@
 JS_EXPORT_PRIVATE std::tuple range() const final;
 
 #if ENABLE(WEBASSEMBLY_B3JIT)
-JITCallee* replacement() { return m_replacement.get(); }
-void setReplacement(Ref&& replacement)
+JITCallee* replacement(MemoryMode mode) { return m_replacements[static_cast(mode)].get(); }
+void setReplacement(Ref&& replacement, MemoryMode mode)
 {
-m_replacement = WTFMove(replacement);
+m_replacements[static_cast(mode)] = WTFMove(replacement);
 }
 
-OMGForOSREntryCallee* osrEntryCallee() { return m_osrEntryCallee.get(); }
-void setOSREntryCallee(Ref&& osrEntryCallee) final
+OMGForOSREntryCallee* osrEntryCallee(MemoryMode mode) { return m_osrEntryCallees[static_cast(mode)].get(); }
+void setOSREntryCallee(Ref&& osrEntryCallee, MemoryMode mode) final
 {
-m_osrEntryCallee = WTFMove(osrEntryCallee);
+m_osrEntryCallees[static_cast(mode)] =

[webkit-changes] [285148] trunk/Source/WebKitLegacy/mac

2021-11-01 Thread beidson

Title: [285148] trunk/Source/WebKitLegacy/mac








Revision 285148
Author beid...@apple.com
Date 2021-11-01 18:06:14 -0700 (Mon, 01 Nov 2021)


Log Message
Make WebChromeClient's m_webView pointer weak.
https://bugs.webkit.org/show_bug.cgi?id=232588

Reviewed by David Kilzer.

* WebCoreSupport/WebChromeClient.h:

Modified Paths

trunk/Source/WebKitLegacy/mac/ChangeLog
trunk/Source/WebKitLegacy/mac/WebCoreSupport/WebChromeClient.h




Diff

Modified: trunk/Source/WebKitLegacy/mac/ChangeLog (285147 => 285148)

--- trunk/Source/WebKitLegacy/mac/ChangeLog	2021-11-01 23:56:26 UTC (rev 285147)
+++ trunk/Source/WebKitLegacy/mac/ChangeLog	2021-11-02 01:06:14 UTC (rev 285148)
@@ -1,3 +1,12 @@
+2021-11-01  Brady Eidson  
+
+Make WebChromeClient's m_webView pointer weak.
+https://bugs.webkit.org/show_bug.cgi?id=232588
+
+Reviewed by David Kilzer.
+
+* WebCoreSupport/WebChromeClient.h:
+
 2021-10-29  Alex Christensen  
 
 Fix internal macOS build after r285047


Modified: trunk/Source/WebKitLegacy/mac/WebCoreSupport/WebChromeClient.h (285147 => 285148)

--- trunk/Source/WebKitLegacy/mac/WebCoreSupport/WebChromeClient.h	2021-11-01 23:56:26 UTC (rev 285147)
+++ trunk/Source/WebKitLegacy/mac/WebCoreSupport/WebChromeClient.h	2021-11-02 01:06:14 UTC (rev 285148)
@@ -259,5 +259,5 @@
 bool m_mockVideoPresentationModeEnabled { false };
 #endif
 
-WebView *m_webView;
+__weak WebView *m_webView;
 };






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [285147] trunk/Source/WebCore

2021-11-01 Thread don . olmstead

Title: [285147] trunk/Source/WebCore








Revision 285147
Author don.olmst...@sony.com
Date 2021-11-01 16:56:26 -0700 (Mon, 01 Nov 2021)


Log Message
[AX] Fix signature of childrenChanged when !ENABLE(ACCESSIBILITY)
https://bugs.webkit.org/show_bug.cgi?id=232590


Unreviewed build fix.

In r285092 the signature of childrenChanged went from AXCoreObject* to AccessibilityObject*
but wasn't updated when accessibility is disabled.


* accessibility/AXObjectCache.h:
(WebCore::AXObjectCache::checkedStateChanged):
(WebCore::AXObjectCache::childrenChanged):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/accessibility/AXObjectCache.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (285146 => 285147)

--- trunk/Source/WebCore/ChangeLog	2021-11-01 23:50:32 UTC (rev 285146)
+++ trunk/Source/WebCore/ChangeLog	2021-11-01 23:56:26 UTC (rev 285147)
@@ -1,5 +1,20 @@
 2021-11-01  Don Olmstead  
 
+[AX] Fix signature of childrenChanged when !ENABLE(ACCESSIBILITY)
+https://bugs.webkit.org/show_bug.cgi?id=232590
+
+
+Unreviewed build fix.
+
+In r285092 the signature of childrenChanged went from AXCoreObject* to AccessibilityObject*
+but wasn't updated when accessibility is disabled.
+
+* accessibility/AXObjectCache.h:
+(WebCore::AXObjectCache::checkedStateChanged):
+(WebCore::AXObjectCache::childrenChanged):
+
+2021-11-01  Don Olmstead  
+
 [Curl] Explicitly disable libcurl's internal cookie support
 https://bugs.webkit.org/show_bug.cgi?id=232586
 


Modified: trunk/Source/WebCore/accessibility/AXObjectCache.h (285146 => 285147)

--- trunk/Source/WebCore/accessibility/AXObjectCache.h	2021-11-01 23:50:32 UTC (rev 285146)
+++ trunk/Source/WebCore/accessibility/AXObjectCache.h	2021-11-01 23:56:26 UTC (rev 285147)
@@ -577,9 +577,9 @@
 inline Node* AXObjectCache::modalNode() { return nullptr; }
 inline void AXObjectCache::attachWrapper(AXCoreObject*) { }
 inline void AXObjectCache::checkedStateChanged(Node*) { }
-inline void AXObjectCache::childrenChanged(AXCoreObject*) { }
 inline void AXObjectCache::childrenChanged(Node*, Node*) { }
 inline void AXObjectCache::childrenChanged(RenderObject*, RenderObject*) { }
+inline void AXObjectCache::childrenChanged(AccessibilityObject*) { }
 inline void AXObjectCache::deferFocusedUIElementChangeIfNeeded(Node*, Node*) { }
 inline void AXObjectCache::deferRecomputeIsIgnoredIfNeeded(Element*) { }
 inline void AXObjectCache::deferRecomputeIsIgnored(Element*) { }






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [285146] trunk

2021-11-01 Thread don . olmstead

Title: [285146] trunk








Revision 285146
Author don.olmst...@sony.com
Date 2021-11-01 16:50:32 -0700 (Mon, 01 Nov 2021)


Log Message
[Curl] Explicitly disable libcurl's internal cookie support
https://bugs.webkit.org/show_bug.cgi?id=232586

Reviewed by Ross Kirsling.

.:

Setting CURLOPT_COOKIEFILE to NULL to disable the cookie engine was not added till 7.77.0
so require that version or later.

* Source/cmake/OptionsPlayStation.cmake:
* Source/cmake/OptionsWinCairo.cmake:

Source/WebCore:

Explicitly disable the cookie engine inside curl.

* platform/network/curl/CurlContext.cpp:
(WebCore::CurlHandle::CurlHandle):

Modified Paths

trunk/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/network/curl/CurlContext.cpp
trunk/Source/cmake/OptionsPlayStation.cmake
trunk/Source/cmake/OptionsWinCairo.cmake




Diff

Modified: trunk/ChangeLog (285145 => 285146)

--- trunk/ChangeLog	2021-11-01 23:33:45 UTC (rev 285145)
+++ trunk/ChangeLog	2021-11-01 23:50:32 UTC (rev 285146)
@@ -1,3 +1,16 @@
+2021-11-01  Don Olmstead  
+
+[Curl] Explicitly disable libcurl's internal cookie support
+https://bugs.webkit.org/show_bug.cgi?id=232586
+
+Reviewed by Ross Kirsling.
+
+Setting CURLOPT_COOKIEFILE to NULL to disable the cookie engine was not added till 7.77.0
+so require that version or later.
+
+* Source/cmake/OptionsPlayStation.cmake:
+* Source/cmake/OptionsWinCairo.cmake:
+
 2021-11-01  David Kilzer  
 
 Add ddkilzer's GitHub name to contributors.json


Modified: trunk/Source/WebCore/ChangeLog (285145 => 285146)

--- trunk/Source/WebCore/ChangeLog	2021-11-01 23:33:45 UTC (rev 285145)
+++ trunk/Source/WebCore/ChangeLog	2021-11-01 23:50:32 UTC (rev 285146)
@@ -1,3 +1,15 @@
+2021-11-01  Don Olmstead  
+
+[Curl] Explicitly disable libcurl's internal cookie support
+https://bugs.webkit.org/show_bug.cgi?id=232586
+
+Reviewed by Ross Kirsling.
+
+Explicitly disable the cookie engine inside curl.
+
+* platform/network/curl/CurlContext.cpp:
+(WebCore::CurlHandle::CurlHandle):
+
 2021-11-01  Michael Smith  
 
 [WebInspector][CORS] Show HTTP status code in CORS messages.


Modified: trunk/Source/WebCore/platform/network/curl/CurlContext.cpp (285145 => 285146)

--- trunk/Source/WebCore/platform/network/curl/CurlContext.cpp	2021-11-01 23:33:45 UTC (rev 285145)
+++ trunk/Source/WebCore/platform/network/curl/CurlContext.cpp	2021-11-01 23:50:32 UTC (rev 285146)
@@ -298,6 +298,7 @@
 m_handle = curl_easy_init();
 curl_easy_setopt(m_handle, CURLOPT_ERRORBUFFER, m_errorBuffer);
 curl_easy_setopt(m_handle, CURLOPT_NOSIGNAL, 1L);
+curl_easy_setopt(m_handle, CURLOPT_COOKIEFILE, nullptr);
 
 enableShareHandle();
 enableAllowedProtocols();


Modified: trunk/Source/cmake/OptionsPlayStation.cmake (285145 => 285146)

--- trunk/Source/cmake/OptionsPlayStation.cmake	2021-11-01 23:33:45 UTC (rev 285145)
+++ trunk/Source/cmake/OptionsPlayStation.cmake	2021-11-01 23:50:32 UTC (rev 285146)
@@ -132,7 +132,7 @@
 set(OpenGLES2_NAMES ${EGL_NAMES})
 
 find_package(Cairo REQUIRED)
-find_package(CURL REQUIRED)
+find_package(CURL 7.77.0 REQUIRED)
 find_package(EGL REQUIRED)
 find_package(Fontconfig REQUIRED)
 find_package(Freetype REQUIRED)


Modified: trunk/Source/cmake/OptionsWinCairo.cmake (285145 => 285146)

--- trunk/Source/cmake/OptionsWinCairo.cmake	2021-11-01 23:33:45 UTC (rev 285145)
+++ trunk/Source/cmake/OptionsWinCairo.cmake	2021-11-01 23:50:32 UTC (rev 285146)
@@ -6,7 +6,7 @@
 set(ENABLE_WEBKIT ON)
 
 find_package(Cairo 1.15.12 REQUIRED)
-find_package(CURL 7.71.0 REQUIRED)
+find_package(CURL 7.77.0 REQUIRED)
 find_package(ICU 61.2 REQUIRED COMPONENTS data i18n uc)
 find_package(JPEG 1.5.2 REQUIRED)
 find_package(LibXml2 2.9.7 REQUIRED)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [285144] trunk

2021-11-01 Thread ddkilzer

Title: [285144] trunk








Revision 285144
Author ddkil...@apple.com
Date 2021-11-01 16:29:35 -0700 (Mon, 01 Nov 2021)


Log Message
Add ddkilzer's GitHub name to contributors.json


Reviewed by Jonathan Bedard.

* metadata/contributors.json:

Modified Paths

trunk/ChangeLog
trunk/metadata/contributors.json




Diff

Modified: trunk/ChangeLog (285143 => 285144)

--- trunk/ChangeLog	2021-11-01 23:21:30 UTC (rev 285143)
+++ trunk/ChangeLog	2021-11-01 23:29:35 UTC (rev 285144)
@@ -1,3 +1,12 @@
+2021-11-01  David Kilzer  
+
+Add ddkilzer's GitHub name to contributors.json
+
+
+Reviewed by Jonathan Bedard.
+
+* metadata/contributors.json:
+
 2021-11-01  Robert Jenner  
 
 Add my GitHub name (robert-jenner) to contributors.json


Modified: trunk/metadata/contributors.json (285143 => 285144)

--- trunk/metadata/contributors.json	2021-11-01 23:21:30 UTC (rev 285143)
+++ trunk/metadata/contributors.json	2021-11-01 23:29:35 UTC (rev 285144)
@@ -1809,6 +1809,7 @@
  "ddkil...@apple.com"
   ],
   "expertise" : "iPhone port, Xcode build system, Tools, Perl, git, WebArchive",
+  "github" : "ddkilzer",
   "name" : "David Kilzer",
   "nicks" : [
  "ddkilzer"






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [285143] trunk/Source/WebCore

2021-11-01 Thread Hironori . Fujii

Title: [285143] trunk/Source/WebCore








Revision 285143
Author hironori.fu...@sony.com
Date 2021-11-01 16:21:30 -0700 (Mon, 01 Nov 2021)


Log Message
[CMake] Can't stat Source/WebCore/Modules/webgpu: No such file or directory
https://bugs.webkit.org/show_bug.cgi?id=232583

Reviewed by Konstantin Tokarev.

r285096 removed WebCore/Modules/webgpu directory.

* CMakeLists.txt: Removed Modules/webgpu directory from
WebCore_IDL_INCLUDES and WebCore_PRIVATE_INCLUDE_DIRECTORIES.
* PlatformMac.cmake:

Modified Paths

trunk/Source/WebCore/CMakeLists.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/PlatformMac.cmake




Diff

Modified: trunk/Source/WebCore/CMakeLists.txt (285142 => 285143)

--- trunk/Source/WebCore/CMakeLists.txt	2021-11-01 23:13:43 UTC (rev 285142)
+++ trunk/Source/WebCore/CMakeLists.txt	2021-11-01 23:21:30 UTC (rev 285143)
@@ -64,9 +64,6 @@
 "${WEBCORE_DIR}/Modules/webauthn/fido"
 "${WEBCORE_DIR}/Modules/webdatabase"
 "${WEBCORE_DIR}/Modules/webdriver"
-"${WEBCORE_DIR}/Modules/webgpu"
-"${WEBCORE_DIR}/Modules/webgpu/WHLSL"
-"${WEBCORE_DIR}/Modules/webgpu/WHLSL/AST"
 "${WEBCORE_DIR}/Modules/websockets"
 "${WEBCORE_DIR}/Modules/webxr"
 "${WEBCORE_DIR}/accessibility"
@@ -218,7 +215,6 @@
 Modules/web-locks
 Modules/webaudio
 Modules/webdatabase
-Modules/webgpu
 Modules/websockets
 
 bindings/js


Modified: trunk/Source/WebCore/ChangeLog (285142 => 285143)

--- trunk/Source/WebCore/ChangeLog	2021-11-01 23:13:43 UTC (rev 285142)
+++ trunk/Source/WebCore/ChangeLog	2021-11-01 23:21:30 UTC (rev 285143)
@@ -1,3 +1,16 @@
+2021-11-01  Fujii Hironori  
+
+[CMake] Can't stat Source/WebCore/Modules/webgpu: No such file or directory
+https://bugs.webkit.org/show_bug.cgi?id=232583
+
+Reviewed by Konstantin Tokarev.
+
+r285096 removed WebCore/Modules/webgpu directory.
+
+* CMakeLists.txt: Removed Modules/webgpu directory from
+WebCore_IDL_INCLUDES and WebCore_PRIVATE_INCLUDE_DIRECTORIES.
+* PlatformMac.cmake:
+
 2021-11-01  Myles C. Maxfield  
 
 Rename GPUDevice to GPUPrewarming because it conflicts with WebGPU's GPUDevice


Modified: trunk/Source/WebCore/PlatformMac.cmake (285142 => 285143)

--- trunk/Source/WebCore/PlatformMac.cmake	2021-11-01 23:13:43 UTC (rev 285142)
+++ trunk/Source/WebCore/PlatformMac.cmake	2021-11-01 23:21:30 UTC (rev 285143)
@@ -87,7 +87,6 @@
 "${CMAKE_BINARY_DIR}/libwebrtc/PrivateHeaders"
 "${CMAKE_SOURCE_DIR}/Source/ThirdParty/libwebrtc/Source"
 "${WEBCORE_DIR}/Modules/webauthn/apdu"
-"${WEBCORE_DIR}/Modules/webgpu/WHLSL/Metal"
 "${WEBCORE_DIR}/accessibility/isolatedtree/mac"
 "${WEBCORE_DIR}/accessibility/mac"
 "${WEBCORE_DIR}/bridge/objc"






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [285142] trunk/Tools

2021-11-01 Thread jbedard

Title: [285142] trunk/Tools








Revision 285142
Author jbed...@apple.com
Date 2021-11-01 16:13:43 -0700 (Mon, 01 Nov 2021)


Log Message
[webkitscmpy] Only respect the latest review
https://bugs.webkit.org/show_bug.cgi?id=231987


Reviewed by Dewei Zhu.

GitHub will report the entire history of a review, we should only
respect the latest review state.

* Scripts/libraries/webkitscmpy/setup.py: Bump version.
* Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py: Ditto.
* Scripts/libraries/webkitscmpy/webkitscmpy/remote/git_hub.py:
(GitHub.PRGenerator.reviewers):
* Scripts/libraries/webkitscmpy/webkitscmpy/test/pull_request_unittest.py:
(TestNetworkPullRequestGitHub.test_approved_edits):

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/libraries/webkitscmpy/setup.py
trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py
trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/remote/git_hub.py
trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/test/pull_request_unittest.py




Diff

Modified: trunk/Tools/ChangeLog (285141 => 285142)

--- trunk/Tools/ChangeLog	2021-11-01 23:05:46 UTC (rev 285141)
+++ trunk/Tools/ChangeLog	2021-11-01 23:13:43 UTC (rev 285142)
@@ -1,3 +1,21 @@
+2021-11-01  Jonathan Bedard  
+
+[webkitscmpy] Only respect the latest review
+https://bugs.webkit.org/show_bug.cgi?id=231987
+
+
+Reviewed by Dewei Zhu.
+
+GitHub will report the entire history of a review, we should only
+respect the latest review state.
+
+* Scripts/libraries/webkitscmpy/setup.py: Bump version.
+* Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py: Ditto.
+* Scripts/libraries/webkitscmpy/webkitscmpy/remote/git_hub.py:
+(GitHub.PRGenerator.reviewers):
+* Scripts/libraries/webkitscmpy/webkitscmpy/test/pull_request_unittest.py:
+(TestNetworkPullRequestGitHub.test_approved_edits):
+
 2021-11-01  Sam Sneddon  
 
 Improve LayoutTestFinder test coverage


Modified: trunk/Tools/Scripts/libraries/webkitscmpy/setup.py (285141 => 285142)

--- trunk/Tools/Scripts/libraries/webkitscmpy/setup.py	2021-11-01 23:05:46 UTC (rev 285141)
+++ trunk/Tools/Scripts/libraries/webkitscmpy/setup.py	2021-11-01 23:13:43 UTC (rev 285142)
@@ -29,7 +29,7 @@
 
 setup(
 name='webkitscmpy',
-version='2.2.21',
+version='2.2.22',
 description='Library designed to interact with git and svn repositories.',
 long_description=readme(),
 classifiers=[


Modified: trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py (285141 => 285142)

--- trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py	2021-11-01 23:05:46 UTC (rev 285141)
+++ trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py	2021-11-01 23:13:43 UTC (rev 285142)
@@ -46,7 +46,7 @@
 "Please install webkitcorepy with `pip install webkitcorepy --extra-index-url `"
 )
 
-version = Version(2, 2, 21)
+version = Version(2, 2, 22)
 
 AutoInstall.register(Package('fasteners', Version(0, 15, 0)))
 AutoInstall.register(Package('jinja2', Version(2, 11, 3)))


Modified: trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/remote/git_hub.py (285141 => 285142)

--- trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/remote/git_hub.py	2021-11-01 23:05:46 UTC (rev 285141)
+++ trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/remote/git_hub.py	2021-11-01 23:13:43 UTC (rev 285142)
@@ -206,13 +206,17 @@
 pull_request._reviewers = [self._contributor(user['login']) for user in response.get('users', [])]
 pull_request._approvers = []
 pull_request._blockers = []
+
+state_for = {}
+for review in self.repository.request('pulls/{}/reviews'.format(pull_request.number)):
+state_for[self._contributor(review['user']['login'])] = review.get('state')
+
 needs_status = Contributor.REVIEWER in self.repository.contributors.statuses
-for review in self.repository.request('pulls/{}/reviews'.format(pull_request.number)):
-contributor = self._contributor(review['user']['login'])
+for contributor, status in state_for.items():
 pull_request._reviewers.append(contributor)
-if review.get('state') == 'APPROVED' and (not needs_status or contributor.status == Contributor.REVIEWER):
+if status == 'APPROVED' and (not needs_status or contributor.status == Contributor.REVIEWER):
 pull_request._approvers.append(contributor)
-elif review.get('state') == 'CHANGES_REQUESTED':
+elif status == 'CHANGES_REQUESTED':
 pull_request._blockers.append(contributor)
 
 pull_request._reviewers = sorted(pull_request._reviewers)


Modified: trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/test/pull_request_unittest.py (285141 => 285142)

---

[webkit-changes] [285141] trunk/Source/WebCore

2021-11-01 Thread mmaxfield

Title: [285141] trunk/Source/WebCore








Revision 285141
Author mmaxfi...@apple.com
Date 2021-11-01 16:05:46 -0700 (Mon, 01 Nov 2021)


Log Message
Rename GPUDevice to GPUPrewarming because it conflicts with WebGPU's GPUDevice
https://bugs.webkit.org/show_bug.cgi?id=232549

Reviewed by Tim Horton.

We should have called it GPUPrewarming from the beginning, because that's what it does.

No new tests because there is no behavior change.

* SourcesCocoa.txt:
* WebCore.xcodeproj/project.pbxproj:
* page/ProcessWarming.cpp:
* platform/graphics/gpu/GPUPrewarming.h: Renamed from Source/WebCore/platform/graphics/gpu/GPUDevice.h.
* platform/graphics/gpu/cocoa/GPUPrewarmingMetal.mm: Renamed from Source/WebCore/platform/graphics/gpu/cocoa/GPUDeviceMetal.mm.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/SourcesCocoa.txt
trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj
trunk/Source/WebCore/page/ProcessWarming.cpp


Added Paths

trunk/Source/WebCore/platform/graphics/gpu/GPUPrewarming.h
trunk/Source/WebCore/platform/graphics/gpu/cocoa/GPUPrewarmingMetal.mm


Removed Paths

trunk/Source/WebCore/platform/graphics/gpu/GPUDevice.h
trunk/Source/WebCore/platform/graphics/gpu/cocoa/GPUDeviceMetal.mm




Diff

Modified: trunk/Source/WebCore/ChangeLog (285140 => 285141)

--- trunk/Source/WebCore/ChangeLog	2021-11-01 22:50:11 UTC (rev 285140)
+++ trunk/Source/WebCore/ChangeLog	2021-11-01 23:05:46 UTC (rev 285141)
@@ -1,3 +1,20 @@
+2021-11-01  Myles C. Maxfield  
+
+Rename GPUDevice to GPUPrewarming because it conflicts with WebGPU's GPUDevice
+https://bugs.webkit.org/show_bug.cgi?id=232549
+
+Reviewed by Tim Horton.
+
+We should have called it GPUPrewarming from the beginning, because that's what it does.
+
+No new tests because there is no behavior change.
+
+* SourcesCocoa.txt:
+* WebCore.xcodeproj/project.pbxproj:
+* page/ProcessWarming.cpp:
+* platform/graphics/gpu/GPUPrewarming.h: Renamed from Source/WebCore/platform/graphics/gpu/GPUDevice.h.
+* platform/graphics/gpu/cocoa/GPUPrewarmingMetal.mm: Renamed from Source/WebCore/platform/graphics/gpu/cocoa/GPUDeviceMetal.mm.
+
 2021-11-01  Alan Bujtas  
 
 [LFC][IFC] Stop measuring text while collecting inline items when content needs bidi split


Modified: trunk/Source/WebCore/SourcesCocoa.txt (285140 => 285141)

--- trunk/Source/WebCore/SourcesCocoa.txt	2021-11-01 22:50:11 UTC (rev 285140)
+++ trunk/Source/WebCore/SourcesCocoa.txt	2021-11-01 23:05:46 UTC (rev 285141)
@@ -401,7 +401,7 @@
 platform/graphics/cv/PixelBufferConformerCV.cpp
 platform/graphics/cv/GraphicsContextGLCVANGLE.cpp
 platform/graphics/coreimage/FilterEffectRendererCoreImage.mm
-platform/graphics/gpu/cocoa/GPUDeviceMetal.mm
+platform/graphics/gpu/cocoa/GPUPrewarmingMetal.mm
 platform/graphics/ios/DisplayRefreshMonitorIOS.mm
 platform/graphics/ios/IconIOS.mm
 platform/graphics/mac/ColorMac.mm


Modified: trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj (285140 => 285141)

--- trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj	2021-11-01 22:50:11 UTC (rev 285140)
+++ trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj	2021-11-01 23:05:46 UTC (rev 285141)
@@ -7080,8 +7080,8 @@
 		1CDD45E40BA9C84600F90147 /* DebugRelease.xcconfig */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = text.xcconfig; path = DebugRelease.xcconfig; sourceTree = ""; };
 		1CDD45E50BA9C84600F90147 /* WebCore.xcconfig */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = text.xcconfig; path = WebCore.xcconfig; sourceTree = ""; };
 		1CDD45E60BA9C84600F90147 /* Base.xcconfig */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = text.xcconfig; path = Base.xcconfig; sourceTree = ""; };
-		1CE3497A26B33B7A008306BD /* GPUDevice.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; path = GPUDevice.h; sourceTree = ""; };
-		1CE3497C26B33BAE008306BD /* GPUDeviceMetal.mm */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.cpp.objcpp; path = GPUDeviceMetal.mm; sourceTree = ""; };
+		1CE3497A26B33B7A008306BD /* GPUPrewarming.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; path = GPUPrewarming.h; sourceTree = ""; };
+		1CE3497C26B33BAE008306BD /* GPUPrewarmingMetal.mm */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.cpp.objcpp; path = GPUPrewarmingMetal.mm; sourceTree = ""; };
 		1CE8863E26105A5F000C816C /* InMemoryDisplayList.cpp */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.cpp.cpp; path = InMemoryDisplayList.cpp; sourceTree = ""; };
 		1CE8863F26105A5F000C816C /* InMemoryDisplayList.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; path = InMemoryDisplayList.h; sourceTree = ""; };
 		1CE8D12526185BD800FC3AEF /* DisplayListItemBufferIdentifier.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; path = DisplayListItemBufferIdentifier.h; sourceTree = ""; };
@@ -18644,11

[webkit-changes] [285140] tags/Safari-613.1.6.6/

2021-11-01 Thread repstein

Title: [285140] tags/Safari-613.1.6.6/








Revision 285140
Author repst...@apple.com
Date 2021-11-01 15:50:11 -0700 (Mon, 01 Nov 2021)


Log Message
Tag Safari-613.1.6.6.

Added Paths

tags/Safari-613.1.6.6/




Diff




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [285139] branches/safari-613.1.6-branch/Source

2021-11-01 Thread repstein

Title: [285139] branches/safari-613.1.6-branch/Source








Revision 285139
Author repst...@apple.com
Date 2021-11-01 15:28:37 -0700 (Mon, 01 Nov 2021)


Log Message
Versioning.

WebKit-7613.1.6.6

Modified Paths

branches/safari-613.1.6-branch/Source/_javascript_Core/Configurations/Version.xcconfig
branches/safari-613.1.6-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig
branches/safari-613.1.6-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig
branches/safari-613.1.6-branch/Source/WebCore/Configurations/Version.xcconfig
branches/safari-613.1.6-branch/Source/WebCore/PAL/Configurations/Version.xcconfig
branches/safari-613.1.6-branch/Source/WebInspectorUI/Configurations/Version.xcconfig
branches/safari-613.1.6-branch/Source/WebKit/Configurations/Version.xcconfig
branches/safari-613.1.6-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig




Diff

Modified: branches/safari-613.1.6-branch/Source/_javascript_Core/Configurations/Version.xcconfig (285138 => 285139)

--- branches/safari-613.1.6-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2021-11-01 22:27:58 UTC (rev 285138)
+++ branches/safari-613.1.6-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2021-11-01 22:28:37 UTC (rev 285139)
@@ -24,7 +24,7 @@
 MAJOR_VERSION = 613;
 MINOR_VERSION = 1;
 TINY_VERSION = 6;
-MICRO_VERSION = 5;
+MICRO_VERSION = 6;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 


Modified: branches/safari-613.1.6-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig (285138 => 285139)

--- branches/safari-613.1.6-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig	2021-11-01 22:27:58 UTC (rev 285138)
+++ branches/safari-613.1.6-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig	2021-11-01 22:28:37 UTC (rev 285139)
@@ -24,7 +24,7 @@
 MAJOR_VERSION = 613;
 MINOR_VERSION = 1;
 TINY_VERSION = 6;
-MICRO_VERSION = 5;
+MICRO_VERSION = 6;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 


Modified: branches/safari-613.1.6-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (285138 => 285139)

--- branches/safari-613.1.6-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2021-11-01 22:27:58 UTC (rev 285138)
+++ branches/safari-613.1.6-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2021-11-01 22:28:37 UTC (rev 285139)
@@ -24,7 +24,7 @@
 MAJOR_VERSION = 613;
 MINOR_VERSION = 1;
 TINY_VERSION = 6;
-MICRO_VERSION = 5;
+MICRO_VERSION = 6;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 


Modified: branches/safari-613.1.6-branch/Source/WebCore/Configurations/Version.xcconfig (285138 => 285139)

--- branches/safari-613.1.6-branch/Source/WebCore/Configurations/Version.xcconfig	2021-11-01 22:27:58 UTC (rev 285138)
+++ branches/safari-613.1.6-branch/Source/WebCore/Configurations/Version.xcconfig	2021-11-01 22:28:37 UTC (rev 285139)
@@ -24,7 +24,7 @@
 MAJOR_VERSION = 613;
 MINOR_VERSION = 1;
 TINY_VERSION = 6;
-MICRO_VERSION = 5;
+MICRO_VERSION = 6;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 


Modified: branches/safari-613.1.6-branch/Source/WebCore/PAL/Configurations/Version.xcconfig (285138 => 285139)

--- branches/safari-613.1.6-branch/Source/WebCore/PAL/Configurations/Version.xcconfig	2021-11-01 22:27:58 UTC (rev 285138)
+++ branches/safari-613.1.6-branch/Source/WebCore/PAL/Configurations/Version.xcconfig	2021-11-01 22:28:37 UTC (rev 285139)
@@ -24,7 +24,7 @@
 MAJOR_VERSION = 613;
 MINOR_VERSION = 1;
 TINY_VERSION = 6;
-MICRO_VERSION = 5;
+MICRO_VERSION = 6;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 


Modified: branches/safari-613.1.6-branch/Source/WebInspectorUI/Configurations/Version.xcconfig (285138 => 285139)

--- branches/safari-613.1.6-branch/Source/WebInspectorUI/Configurations/Version.xcconfig	2021-11-01 22:27:58 UTC (rev 285138)
+++ branches/safari-613.1.6-branch/Source/WebInspectorUI/Configurations/Version.xcconfig	2021-11-01 22:28:37 UTC (rev 285139)
@@ -1,7 +1,7 @@
 MAJOR_VERSION = 613;
 MINOR_VERSION = 1;
 TINY_VERSION = 6;
-MICRO_VERSION = 5;
+MICRO_VERSION = 6;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 


Modified: branches/safari-613.1.6-branch/Source/WebKit/Configurations/Version.xcconfig (285138 => 285139)

--- branches/safari-613.1.6-branch/Source/WebKit/Configurations/Version.xcconfig	2021-11-01 22:27:58 UTC (rev 285138)
+++ branches/safari-613.1.6-branch/Source/WebKit/Configurations/Version.xcconfig	2021-11-01 22:28:37 UTC (rev 285139)
@@ -24,7 +24,7 @@
 MAJOR_VERSION = 613;
 MINOR_VERSION = 1;
 TINY_VERSION = 6;
-MICRO_VERSION = 5;
+MICRO_VERSION = 6;
 NANO_VERSION = 0;
 FULL_VERSION =

[webkit-changes] [285138] trunk/Source/WebKit

2021-11-01 Thread cdumez

Title: [285138] trunk/Source/WebKit








Revision 285138
Author cdu...@apple.com
Date 2021-11-01 15:27:58 -0700 (Mon, 01 Nov 2021)


Log Message
Avoid heap-allocating ImportanceAssertion
https://bugs.webkit.org/show_bug.cgi?id=232579

Reviewed by Alex Christensen.

Avoid heap-allocating ImportanceAssertion since this is just a wrapper around a
mach_port.

Also update the ImportanceAssertion destructor to null out the mach port as
hardening given .

* Platform/IPC/Decoder.cpp:
(IPC::Decoder::setImportanceAssertion):
* Platform/IPC/Decoder.h:
* Platform/IPC/cocoa/ConnectionCocoa.mm:
(IPC::Connection::receiveSourceEventHandler):
* Platform/IPC/cocoa/ImportanceAssertion.h:
(IPC::ImportanceAssertion::ImportanceAssertion):
(IPC::ImportanceAssertion::operator=):
(IPC::ImportanceAssertion::~ImportanceAssertion):

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Platform/IPC/Decoder.cpp
trunk/Source/WebKit/Platform/IPC/Decoder.h
trunk/Source/WebKit/Platform/IPC/cocoa/ConnectionCocoa.mm
trunk/Source/WebKit/Platform/IPC/cocoa/ImportanceAssertion.h




Diff

Modified: trunk/Source/WebKit/ChangeLog (285137 => 285138)

--- trunk/Source/WebKit/ChangeLog	2021-11-01 22:15:44 UTC (rev 285137)
+++ trunk/Source/WebKit/ChangeLog	2021-11-01 22:27:58 UTC (rev 285138)
@@ -1,3 +1,26 @@
+2021-11-01  Chris Dumez  
+
+Avoid heap-allocating ImportanceAssertion
+https://bugs.webkit.org/show_bug.cgi?id=232579
+
+Reviewed by Alex Christensen.
+
+Avoid heap-allocating ImportanceAssertion since this is just a wrapper around a
+mach_port.
+
+Also update the ImportanceAssertion destructor to null out the mach port as
+hardening given .
+
+* Platform/IPC/Decoder.cpp:
+(IPC::Decoder::setImportanceAssertion):
+* Platform/IPC/Decoder.h:
+* Platform/IPC/cocoa/ConnectionCocoa.mm:
+(IPC::Connection::receiveSourceEventHandler):
+* Platform/IPC/cocoa/ImportanceAssertion.h:
+(IPC::ImportanceAssertion::ImportanceAssertion):
+(IPC::ImportanceAssertion::operator=):
+(IPC::ImportanceAssertion::~ImportanceAssertion):
+
 2021-11-01  Per Arne  
 
 [macOS] Opening local html files is failing


Modified: trunk/Source/WebKit/Platform/IPC/Decoder.cpp (285137 => 285138)

--- trunk/Source/WebKit/Platform/IPC/Decoder.cpp	2021-11-01 22:15:44 UTC (rev 285137)
+++ trunk/Source/WebKit/Platform/IPC/Decoder.cpp	2021-11-01 22:27:58 UTC (rev 285138)
@@ -147,7 +147,7 @@
 }
 
 #if PLATFORM(MAC)
-void Decoder::setImportanceAssertion(std::unique_ptr assertion)
+void Decoder::setImportanceAssertion(ImportanceAssertion&& assertion)
 {
 m_importanceAssertion = WTFMove(assertion);
 }


Modified: trunk/Source/WebKit/Platform/IPC/Decoder.h (285137 => 285138)

--- trunk/Source/WebKit/Platform/IPC/Decoder.h	2021-11-01 22:15:44 UTC (rev 285137)
+++ trunk/Source/WebKit/Platform/IPC/Decoder.h	2021-11-01 22:27:58 UTC (rev 285138)
@@ -32,6 +32,10 @@
 #include 
 #include 
 
+#if PLATFORM(MAC)
+#include "ImportanceAssertion.h"
+#endif
+
 #if HAVE(QOS_CLASSES)
 #include 
 #endif
@@ -38,7 +42,6 @@
 
 namespace IPC {
 
-class ImportanceAssertion;
 enum class MessageFlags : uint8_t;
 enum class ShouldDispatchWhenWaitingForSyncReply : uint8_t;
 
@@ -67,7 +70,7 @@
 bool shouldMaintainOrderingWithAsyncMessages() const;
 
 #if PLATFORM(MAC)
-void setImportanceAssertion(std::unique_ptr);
+void setImportanceAssertion(ImportanceAssertion&&);
 #endif
 
 static std::unique_ptr unwrapForTesting(Decoder&);
@@ -173,7 +176,7 @@
 uint64_t m_destinationID;
 
 #if PLATFORM(MAC)
-std::unique_ptr m_importanceAssertion;
+ImportanceAssertion m_importanceAssertion;
 #endif
 };
 


Modified: trunk/Source/WebKit/Platform/IPC/cocoa/ConnectionCocoa.mm (285137 => 285138)

--- trunk/Source/WebKit/Platform/IPC/cocoa/ConnectionCocoa.mm	2021-11-01 22:15:44 UTC (rev 285137)
+++ trunk/Source/WebKit/Platform/IPC/cocoa/ConnectionCocoa.mm	2021-11-01 22:27:58 UTC (rev 285138)
@@ -542,7 +542,7 @@
 return;
 
 #if PLATFORM(MAC)
-decoder->setImportanceAssertion(makeUnique(header));
+decoder->setImportanceAssertion(ImportanceAssertion { header });
 #endif
 
 if (decoder->messageName() == MessageName::InitializeConnection) {


Modified: trunk/Source/WebKit/Platform/IPC/cocoa/ImportanceAssertion.h (285137 => 285138)

--- trunk/Source/WebKit/Platform/IPC/cocoa/ImportanceAssertion.h	2021-11-01 22:15:44 UTC (rev 285137)
+++ trunk/Source/WebKit/Platform/IPC/cocoa/ImportanceAssertion.h	2021-11-01 22:27:58 UTC (rev 285138)
@@ -1,5 +1,5 @@
 /*
- * Copyright (C) 2013 Apple Inc. All rights reserved.
+ * Copyright (C) 2013-2021 Apple Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
@@ -32,30 +32,44 @@
 namespace IPC {
 
 class ImportanceAssertion {
-WTF_MAKE_FAST_ALLOCATED;
-

[webkit-changes] [285137] trunk/Tools

2021-11-01 Thread gsnedders

Title: [285137] trunk/Tools








Revision 285137
Author gsnedd...@apple.com
Date 2021-11-01 15:15:44 -0700 (Mon, 01 Nov 2021)


Log Message
Improve LayoutTestFinder test coverage
https://bugs.webkit.org/show_bug.cgi?id=232576

Reviewed by Jonathan Bedard.

Some of these are largely copied from layout_tests/run_webkit_tests_integrationtest.py, but
in unit test form for the test finder.

* Scripts/webkitpy/layout_tests/controllers/layout_test_finder_legacy_unittest.py:
(LayoutTestFinderTests.__init__):
(LayoutTestFinderTests):
(LayoutTestFinderTests.setUp):
(LayoutTestFinderTests.tearDown):
(LayoutTestFinderTests.test_find_no_paths_specified):
(LayoutTestFinderTests.test_find_no_paths_sorted):
(LayoutTestFinderTests.test_find_all_no_paths):
(LayoutTestFinderTests.test_includes_other_platforms):
(LayoutTestFinderTests.test_find_one_test):
(LayoutTestFinderTests.test_find_platform):
(LayoutTestFinderTests.test_find_platform_self):
(LayoutTestFinderTests.test_find_platform_other):
(LayoutTestFinderTests.test_find_platform_specific):
(LayoutTestFinderTests.test_find_platform_specific_directory):
(LayoutTestFinderTests.test_find_directory_includes_platform_specific):
(LayoutTestFinderTests.test_find_glob):
(LayoutTestFinderTests.test_find_glob_mixed_file_type_sorted):
(LayoutTestFinderTests.test_find_glob_directory):
(LayoutTestFinderTests.test_find_glob_directory_b):
(LayoutTestFinderTests.test_find_glob_directory_e):
(LayoutTestFinderTests.test_find_directory):
(LayoutTestFinderTests.test_find_directory_trailing_slash):
(LayoutTestFinderTests.test_find_directory_star):
(LayoutTestFinderTests.test_preserves_order):
(LayoutTestFinderTests.test_preserves_order_multiple_times):
(LayoutTestFinderTests.test_preserves_order_directories):
(LayoutTestFinderTests.test_preserves_order_mixed_file_type):
(LayoutTestFinderTests.test_preserves_order_mixed_file_type_b):
(LayoutTestFinderTests.test_find_directory_multiple_times):
(LayoutTestFinderTests.test_no_reference):
(LayoutTestFinderTests.test_glob_no_references):
(LayoutTestFinderTests.test_find_with_skipped_directories):
(LayoutTestFinderTests.test_find_with_skipped_directories_2):
(LayoutTestFinderTests.test_is_test_file):
(LayoutTestFinderTests.test_is_w3c_resource_file):
(LayoutTestFinderTests.make_finder): Deleted.
* Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
(RunTest.setUp): Re-enable tests on Python 3, as this now works
(RunTest.test_child_processes_min): Also ignore tests in platform/
* Scripts/webkitpy/port/test.py:

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/layout_tests/controllers/layout_test_finder_legacy_unittest.py
trunk/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py
trunk/Tools/Scripts/webkitpy/port/test.py




Diff

Modified: trunk/Tools/ChangeLog (285136 => 285137)

--- trunk/Tools/ChangeLog	2021-11-01 22:09:41 UTC (rev 285136)
+++ trunk/Tools/ChangeLog	2021-11-01 22:15:44 UTC (rev 285137)
@@ -1,3 +1,55 @@
+2021-11-01  Sam Sneddon  
+
+Improve LayoutTestFinder test coverage
+https://bugs.webkit.org/show_bug.cgi?id=232576
+
+Reviewed by Jonathan Bedard.
+
+Some of these are largely copied from layout_tests/run_webkit_tests_integrationtest.py, but
+in unit test form for the test finder.
+
+* Scripts/webkitpy/layout_tests/controllers/layout_test_finder_legacy_unittest.py:
+(LayoutTestFinderTests.__init__):
+(LayoutTestFinderTests):
+(LayoutTestFinderTests.setUp):
+(LayoutTestFinderTests.tearDown):
+(LayoutTestFinderTests.test_find_no_paths_specified):
+(LayoutTestFinderTests.test_find_no_paths_sorted):
+(LayoutTestFinderTests.test_find_all_no_paths):
+(LayoutTestFinderTests.test_includes_other_platforms):
+(LayoutTestFinderTests.test_find_one_test):
+(LayoutTestFinderTests.test_find_platform):
+(LayoutTestFinderTests.test_find_platform_self):
+(LayoutTestFinderTests.test_find_platform_other):
+(LayoutTestFinderTests.test_find_platform_specific):
+(LayoutTestFinderTests.test_find_platform_specific_directory):
+(LayoutTestFinderTests.test_find_directory_includes_platform_specific):
+(LayoutTestFinderTests.test_find_glob):
+(LayoutTestFinderTests.test_find_glob_mixed_file_type_sorted):
+(LayoutTestFinderTests.test_find_glob_directory):
+(LayoutTestFinderTests.test_find_glob_directory_b):
+(LayoutTestFinderTests.test_find_glob_directory_e):
+(LayoutTestFinderTests.test_find_directory):
+(LayoutTestFinderTests.test_find_directory_trailing_slash):
+(LayoutTestFinderTests.test_find_directory_star):
+(LayoutTestFinderTests.test_preserves_order):
+(LayoutTestFinderTests.test_preserves_order_multiple_times):
+(LayoutTestFinderTests.test_preserves_order_directories):
+(LayoutTestFinderTests.test_preserves_order_mixed_file_type):
+

[webkit-changes] [285136] trunk/Source/WebCore

2021-11-01 Thread zalan

Title: [285136] trunk/Source/WebCore








Revision 285136
Author za...@apple.com
Date 2021-11-01 15:09:41 -0700 (Mon, 01 Nov 2021)


Log Message
[LFC][IFC] Stop measuring text while collecting inline items when content needs bidi split
https://bugs.webkit.org/show_bug.cgi?id=232571

Reviewed by Antti Koivisto.

When we know we are going to do bidi processing, these inline item width results will most likely become stale at breakAndComputeBidiLevels.

* layout/formattingContexts/inline/InlineItemsBuilder.cpp:
(WebCore::Layout::InlineItemsBuilder::breakAndComputeBidiLevels):
(WebCore::Layout::InlineItemsBuilder::handleTextContent):
(WebCore::Layout::InlineItemsBuilder::enterBidiContext):
(WebCore::Layout::InlineItemsBuilder::exitBidiContext):
(WebCore::Layout::InlineItemsBuilder::buildPreviousTextContent):
* layout/formattingContexts/inline/InlineItemsBuilder.h:
(WebCore::Layout::InlineItemsBuilder::isBiDiContent const):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/layout/formattingContexts/inline/InlineItemsBuilder.cpp
trunk/Source/WebCore/layout/formattingContexts/inline/InlineItemsBuilder.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (285135 => 285136)

--- trunk/Source/WebCore/ChangeLog	2021-11-01 22:09:33 UTC (rev 285135)
+++ trunk/Source/WebCore/ChangeLog	2021-11-01 22:09:41 UTC (rev 285136)
@@ -1,3 +1,21 @@
+2021-11-01  Alan Bujtas  
+
+[LFC][IFC] Stop measuring text while collecting inline items when content needs bidi split
+https://bugs.webkit.org/show_bug.cgi?id=232571
+
+Reviewed by Antti Koivisto.
+
+When we know we are going to do bidi processing, these inline item width results will most likely become stale at breakAndComputeBidiLevels.
+
+* layout/formattingContexts/inline/InlineItemsBuilder.cpp:
+(WebCore::Layout::InlineItemsBuilder::breakAndComputeBidiLevels):
+(WebCore::Layout::InlineItemsBuilder::handleTextContent):
+(WebCore::Layout::InlineItemsBuilder::enterBidiContext):
+(WebCore::Layout::InlineItemsBuilder::exitBidiContext):
+(WebCore::Layout::InlineItemsBuilder::buildPreviousTextContent):
+* layout/formattingContexts/inline/InlineItemsBuilder.h:
+(WebCore::Layout::InlineItemsBuilder::isBiDiContent const):
+
 2021-11-01  Devin Rousso  
 
 [ iOS15 EWS ] TestWebKitAPI.CSSViewportUnits.SameUnobscuredSizeOverrides flaky fails on EWS


Modified: trunk/Source/WebCore/layout/formattingContexts/inline/InlineItemsBuilder.cpp (285135 => 285136)

--- trunk/Source/WebCore/layout/formattingContexts/inline/InlineItemsBuilder.cpp	2021-11-01 22:09:33 UTC (rev 285135)
+++ trunk/Source/WebCore/layout/formattingContexts/inline/InlineItemsBuilder.cpp	2021-11-01 22:09:41 UTC (rev 285136)
@@ -136,7 +136,7 @@
 
 void InlineItemsBuilder::breakAndComputeBidiLevels(InlineItems& inlineItems)
 {
-if (m_paragraphContentBuilder.isEmpty())
+if (!hasSeenBidiContent())
 return;
 ASSERT(!inlineItems.isEmpty());
 
@@ -179,6 +179,7 @@
 ++currentInlineItemIndex;
 continue;
 }
+// FIXME: Find out if this is the most optimal place to measure and cache text widths. 
 auto& inlineTextItem = downcast(inlineItem);
 inlineTextItem.setBidiLevel(level);
 
@@ -221,6 +222,10 @@
 unsigned currentPosition = 0;
 
 auto inlineItemWidth = [&](auto startPosition, auto length) -> std::optional {
+if (hasSeenBidiContent()) {
+// Delay content measuring until bidi split.
+return { };
+}
 if (!inlineTextBox.canUseSimplifiedContentMeasuring()
 || !TextUtil::canUseSimplifiedTextMeasuringForFirstLine(inlineTextBox.style(), inlineTextBox.firstLineStyle()))
 return { };
@@ -227,7 +232,7 @@
 return TextUtil::width(inlineTextBox, fontCascade, startPosition, startPosition + length, { });
 };
 
-if (!m_paragraphContentBuilder.isEmpty()) {
+if (hasSeenBidiContent()) {
 m_contentOffsetMap.set(, m_paragraphContentBuilder.length());
 m_paragraphContentBuilder.append(text);
 }
@@ -291,7 +296,7 @@
 currentPosition = endPosition;
 #if ALLOW_BIDI_CONTENT
 // Check if the content has bidi dependency so that we have to start building the paragraph content for ubidi.
-if (text.is8Bit() || !m_paragraphContentBuilder.isEmpty())
+if (text.is8Bit() || hasSeenBidiContent())
 return true;
 
 for (auto position = startPosition; position < endPosition;) {
@@ -404,7 +409,7 @@
 
 void InlineItemsBuilder::enterBidiContext(const Box& box, UChar controlCharacter, const InlineItems& inlineItems)
 {
-if (m_paragraphContentBuilder.isEmpty())
+if (!hasSeenBidiContent())
 buildPreviousTextContent(inlineItems);
 // Let the first control character represent the  box.
 m_contentOffsetMap.add(,

[webkit-changes] [285135] trunk/LayoutTests

2021-11-01 Thread ehutchison

Title: [285135] trunk/LayoutTests








Revision 285135
Author ehutchi...@apple.com
Date 2021-11-01 15:09:33 -0700 (Mon, 01 Nov 2021)


Log Message
[ Catalina Debug wk1 EWS-only ] media/track/track-element-load-event.html is a flaky crash.
https://bugs.webkit.org/show_bug.cgi?id=232585.

Unreviewed test gardening.

* platform/mac-wk1/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac-wk1/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (285134 => 285135)

--- trunk/LayoutTests/ChangeLog	2021-11-01 22:04:09 UTC (rev 285134)
+++ trunk/LayoutTests/ChangeLog	2021-11-01 22:09:33 UTC (rev 285135)
@@ -1,3 +1,12 @@
+2021-11-01  Eric Hutchison  
+
+[ Catalina Debug wk1 EWS-only ] media/track/track-element-load-event.html is a flaky crash.
+https://bugs.webkit.org/show_bug.cgi?id=232585.
+
+Unreviewed test gardening.
+
+* platform/mac-wk1/TestExpectations:
+
 2021-11-01  Nikos Mouchtaris  
 
 Add platform test expectations for imported/w3c/web-platform-tests/mathml/relations/html5-tree/dynamic-childlist-001.html


Modified: trunk/LayoutTests/platform/mac-wk1/TestExpectations (285134 => 285135)

--- trunk/LayoutTests/platform/mac-wk1/TestExpectations	2021-11-01 22:04:09 UTC (rev 285134)
+++ trunk/LayoutTests/platform/mac-wk1/TestExpectations	2021-11-01 22:09:33 UTC (rev 285135)
@@ -1512,3 +1512,4 @@
 
 webkit.org/b/232446 [ Catalina Debug ] media/track/track-element-dom-change-crash.html [ Pass Crash ]
 
+webkit.org/b/232585 [ Catalina Debug ] media/track/track-element-load-event.html [ Pass Crash ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [285134] trunk/LayoutTests

2021-11-01 Thread nmouchtaris

Title: [285134] trunk/LayoutTests








Revision 285134
Author nmouchta...@apple.com
Date 2021-11-01 15:04:09 -0700 (Mon, 01 Nov 2021)


Log Message
Add platform test expectations for imported/w3c/web-platform-tests/mathml/relations/html5-tree/dynamic-childlist-001.html
https://bugs.webkit.org/show_bug.cgi?id=232504

Reviewed by Myles C. Maxfield.

* platform/ios-simulator-wk2/TestExpectations:
* platform/ios-wk2/TestExpectations:
* platform/mac-bigsur/imported/w3c/web-platform-tests/mathml/relations/html5-tree/dynamic-childlist-001-expected.txt: Added.
* platform/mac/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/ios-simulator-wk2/TestExpectations
trunk/LayoutTests/platform/ios-wk2/TestExpectations
trunk/LayoutTests/platform/mac/TestExpectations


Added Paths

trunk/LayoutTests/imported/w3c/web-platform-tests/mathml/relations/html5-tree/dynamic-childlist-001-expected.txt
trunk/LayoutTests/platform/ios-simulator-wk2/imported/w3c/web-platform-tests/mathml/
trunk/LayoutTests/platform/ios-simulator-wk2/imported/w3c/web-platform-tests/mathml/relations/
trunk/LayoutTests/platform/ios-simulator-wk2/imported/w3c/web-platform-tests/mathml/relations/html5-tree/
trunk/LayoutTests/platform/ios-simulator-wk2/imported/w3c/web-platform-tests/mathml/relations/html5-tree/dynamic-childlist-001-expected.txt
trunk/LayoutTests/platform/mac-bigsur-wk2/imported/w3c/web-platform-tests/mathml/
trunk/LayoutTests/platform/mac-bigsur-wk2/imported/w3c/web-platform-tests/mathml/relations/
trunk/LayoutTests/platform/mac-bigsur-wk2/imported/w3c/web-platform-tests/mathml/relations/html5-tree/
trunk/LayoutTests/platform/mac-bigsur-wk2/imported/w3c/web-platform-tests/mathml/relations/html5-tree/dynamic-childlist-001-expected.txt
trunk/LayoutTests/platform/mac-catalina-wk2/imported/w3c/web-platform-tests/mathml/
trunk/LayoutTests/platform/mac-catalina-wk2/imported/w3c/web-platform-tests/mathml/relations/
trunk/LayoutTests/platform/mac-catalina-wk2/imported/w3c/web-platform-tests/mathml/relations/html5-tree/
trunk/LayoutTests/platform/mac-catalina-wk2/imported/w3c/web-platform-tests/mathml/relations/html5-tree/dynamic-childlist-001-expected.txt


Removed Paths

trunk/LayoutTests/platform/glib/imported/w3c/web-platform-tests/mathml/relations/html5-tree/dynamic-childlist-001-expected.txt
trunk/LayoutTests/platform/ios-wk2/imported/w3c/web-platform-tests/mathml/relations/html5-tree/dynamic-childlist-001-expected.txt
trunk/LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/mathml/relations/html5-tree/dynamic-childlist-001-expected.txt
trunk/LayoutTests/platform/mac-wk2/imported/w3c/web-platform-tests/mathml/relations/html5-tree/dynamic-childlist-001-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (285133 => 285134)

--- trunk/LayoutTests/ChangeLog	2021-11-01 21:58:38 UTC (rev 285133)
+++ trunk/LayoutTests/ChangeLog	2021-11-01 22:04:09 UTC (rev 285134)
@@ -1,3 +1,15 @@
+2021-11-01  Nikos Mouchtaris  
+
+Add platform test expectations for imported/w3c/web-platform-tests/mathml/relations/html5-tree/dynamic-childlist-001.html
+https://bugs.webkit.org/show_bug.cgi?id=232504
+
+Reviewed by Myles C. Maxfield.
+
+* platform/ios-simulator-wk2/TestExpectations:
+* platform/ios-wk2/TestExpectations:
+* platform/mac-bigsur/imported/w3c/web-platform-tests/mathml/relations/html5-tree/dynamic-childlist-001-expected.txt: Added.
+* platform/mac/TestExpectations:
+
 2021-11-01  Ayumi Kojima  
 
 [ iOS Debug ] http/wpt/push-api tests are flaky failing.


Copied: trunk/LayoutTests/imported/w3c/web-platform-tests/mathml/relations/html5-tree/dynamic-childlist-001-expected.txt (from rev 285133, trunk/LayoutTests/platform/ios-wk2/imported/w3c/web-platform-tests/mathml/relations/html5-tree/dynamic-childlist-001-expected.txt) (0 => 285134)

--- trunk/LayoutTests/imported/w3c/web-platform-tests/mathml/relations/html5-tree/dynamic-childlist-001-expected.txt	(rev 0)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/mathml/relations/html5-tree/dynamic-childlist-001-expected.txt	2021-11-01 22:04:09 UTC (rev 285134)
@@ -0,0 +1,101 @@
+
+PASS Adding missing children to mfrac
+PASS Removing child from valid mfrac
+FAIL Adding child to valid mfrac assert_approx_equals: block position (child 1) expected 0 +/- 1 but got 12.375
+PASS Removing extra child from mfrac
+PASS Adding missing children to munder
+PASS Removing child from valid munder
+FAIL Adding child to valid munder assert_approx_equals: block position (child 1) expected 0 +/- 1 but got 12.390625
+PASS Removing extra child from munder
+PASS Adding missing children to mover
+FAIL Removing child from valid mover assert_approx_equals: block position (child 0) expected 0 +/- 1 but got 23.1875
+FAIL Adding child to valid mover assert_approx_equals: block position (child 0) expected 0 +/- 1 but got 23.1875
+PASS Removing extra child from mover
+PASS Adding missing

[webkit-changes] [285133] trunk

2021-11-01 Thread jenner

Title: [285133] trunk








Revision 285133
Author jen...@apple.com
Date 2021-11-01 14:58:38 -0700 (Mon, 01 Nov 2021)


Log Message
Add my GitHub name (robert-jenner) to contributors.json
https://bugs.webkit.org/show_bug.cgi?id=232581

Reviewed by Jonathan Bedard.

* metadata/contributors.json:

Modified Paths

trunk/ChangeLog
trunk/metadata/contributors.json




Diff

Modified: trunk/ChangeLog (285132 => 285133)

--- trunk/ChangeLog	2021-11-01 21:30:38 UTC (rev 285132)
+++ trunk/ChangeLog	2021-11-01 21:58:38 UTC (rev 285133)
@@ -1,3 +1,12 @@
+2021-11-01  Robert Jenner  
+
+Add my GitHub name (robert-jenner) to contributors.json
+https://bugs.webkit.org/show_bug.cgi?id=232581
+
+Reviewed by Jonathan Bedard.
+
+* metadata/contributors.json:
+
 2021-11-01  Beth Dakin  
 
 Add my GitHub name to contributors.json


Modified: trunk/metadata/contributors.json (285132 => 285133)

--- trunk/metadata/contributors.json	2021-11-01 21:30:38 UTC (rev 285132)
+++ trunk/metadata/contributors.json	2021-11-01 21:58:38 UTC (rev 285133)
@@ -5564,6 +5564,7 @@
   "emails" : [
  "jen...@apple.com"
   ],
+  "github" : "robert-jenner",
   "name" : "Robert Jenner",
   "status" : "committer"
},






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [285132] trunk/Tools

2021-11-01 Thread timothy_horton

Title: [285132] trunk/Tools








Revision 285132
Author timothy_hor...@apple.com
Date 2021-11-01 14:30:38 -0700 (Mon, 01 Nov 2021)


Log Message
Add a run-webkit-tests mode to A/B test a given feature
https://bugs.webkit.org/show_bug.cgi?id=232553

Reviewed by Jonathan Bedard.

Add the argument --self-compare-with-header to run-webkit-tests, which
can be used to test the impact of a given feature (or set of features;
it accepts the standard test features header format).

When tests are run in this mode, all tests are run in the ref-test
style, but with the `expected` and `actual` results loading the same
test file (ignoring the usual -expected.html or whatever); they differ
only in the set of features/preferences enabled.

This is especially useful for testing the impact of e.g. platform
graphics features, where the difference between the shipping behavior
and in-development behavior is more interesting than whether or not
it actually makes the tests, as written, fail.

* Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
(SingleTestRunner):
(SingleTestRunner._run_comparison_test):
Add the comparison test runner, and prefer it if requested.

One note here: the run with the options derived from the given header is
considered the "actual" result and the default configuration the "expected".

* Scripts/webkitpy/layout_tests/run_webkit_tests.py:
(parse_args):
* Scripts/webkitpy/port/driver.py:
(DriverInput.__init__):
(DriverInput.__repr__):
(Driver._command_from_driver_input):
Pass the comparison test header along to the test runner.

Also, fix a longstanding error where --dump-jsconsolelog-in-stderr
could get inserted immediately after --pixel-test, causing the test runner
to consume it as the expected image hash! And leave a comment so nobody
else has to debug this again...

* TestRunnerShared/TestCommand.cpp:
(WTR::parseInputLine):
* TestRunnerShared/TestCommand.h:
* TestRunnerShared/TestFeatures.cpp:
(WTR::parseTestHeaderString):
(WTR::parseTestHeader):
(WTR::featureDefaultsFromComparisonTestHeader):
Factor out the parsing of the part of the test header inside the [ ],
since we use this format for the value of --self-compare-with-header as well.

* TestRunnerShared/TestFeatures.h:
* WebKitTestRunner/Options.h:
* WebKitTestRunner/TestController.cpp:
(WTR::TestController::testOptionsForTest const):
Merge the comparison header's options in to the test options before
the test's own header, so that the comparison header wins.

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/layout_tests/controllers/single_test_runner.py
trunk/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py
trunk/Tools/Scripts/webkitpy/port/driver.py
trunk/Tools/TestRunnerShared/TestCommand.cpp
trunk/Tools/TestRunnerShared/TestCommand.h
trunk/Tools/TestRunnerShared/TestFeatures.cpp
trunk/Tools/TestRunnerShared/TestFeatures.h
trunk/Tools/WebKitTestRunner/TestController.cpp




Diff

Modified: trunk/Tools/ChangeLog (285131 => 285132)

--- trunk/Tools/ChangeLog	2021-11-01 21:24:24 UTC (rev 285131)
+++ trunk/Tools/ChangeLog	2021-11-01 21:30:38 UTC (rev 285132)
@@ -1,3 +1,62 @@
+2021-11-01  Tim Horton  
+
+Add a run-webkit-tests mode to A/B test a given feature
+https://bugs.webkit.org/show_bug.cgi?id=232553
+
+Reviewed by Jonathan Bedard.
+
+Add the argument --self-compare-with-header to run-webkit-tests, which
+can be used to test the impact of a given feature (or set of features;
+it accepts the standard test features header format).
+
+When tests are run in this mode, all tests are run in the ref-test
+style, but with the `expected` and `actual` results loading the same
+test file (ignoring the usual -expected.html or whatever); they differ
+only in the set of features/preferences enabled.
+
+This is especially useful for testing the impact of e.g. platform
+graphics features, where the difference between the shipping behavior
+and in-development behavior is more interesting than whether or not
+it actually makes the tests, as written, fail.
+
+* Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
+(SingleTestRunner):
+(SingleTestRunner._run_comparison_test):
+Add the comparison test runner, and prefer it if requested.
+
+One note here: the run with the options derived from the given header is
+considered the "actual" result and the default configuration the "expected".
+
+* Scripts/webkitpy/layout_tests/run_webkit_tests.py:
+(parse_args):
+* Scripts/webkitpy/port/driver.py:
+(DriverInput.__init__):
+(DriverInput.__repr__):
+(Driver._command_from_driver_input):
+Pass the comparison test header along to the test runner.
+
+Also, fix a longstanding error where --dump-jsconsolelog-in-stderr
+could get inserted immediately after --pixel-test, causing the test runner

[webkit-changes] [285131] trunk/Tools

2021-11-01 Thread jbedard

Title: [285131] trunk/Tools








Revision 285131
Author jbed...@apple.com
Date 2021-11-01 14:24:24 -0700 (Mon, 01 Nov 2021)


Log Message
webkitpy: Remove obsolete port name
https://bugs.webkit.org/show_bug.cgi?id=169302


Reviewed by Alex Christensen.

Removing a temporary workaround from r213654.

* Scripts/webkitpy/common/config/ports.py:
(DeprecatedPort.port): Remove mapping from 'ios' to 'ios-device.'

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/common/config/ports.py




Diff

Modified: trunk/Tools/ChangeLog (285130 => 285131)

--- trunk/Tools/ChangeLog	2021-11-01 21:04:45 UTC (rev 285130)
+++ trunk/Tools/ChangeLog	2021-11-01 21:24:24 UTC (rev 285131)
@@ -1,3 +1,16 @@
+2021-11-01  Jonathan Bedard  
+
+webkitpy: Remove obsolete port name
+https://bugs.webkit.org/show_bug.cgi?id=169302
+
+
+Reviewed by Alex Christensen.
+
+Removing a temporary workaround from r213654.
+
+* Scripts/webkitpy/common/config/ports.py:
+(DeprecatedPort.port): Remove mapping from 'ios' to 'ios-device.'
+
 2021-11-01  Fujii Hironori  
 
 TestWTF.WTF_CompactUniquePtrTuple.Subclassing is randomly failing on WinCairo tester bots


Modified: trunk/Tools/Scripts/webkitpy/common/config/ports.py (285130 => 285131)

--- trunk/Tools/Scripts/webkitpy/common/config/ports.py	2021-11-01 21:04:45 UTC (rev 285130)
+++ trunk/Tools/Scripts/webkitpy/common/config/ports.py	2021-11-01 21:24:24 UTC (rev 285131)
@@ -65,8 +65,6 @@
 "ftw": FTWPort,
 "gtk-wk2": GtkWK2Port,
 "ios-device": IOSPort,
-# FIXME: https://bugs.webkit.org/show_bug.cgi?id=169302
-"ios": IOSPort,
 "ios-simulator-wk2": IOSSimulatorWK2Port,
 "jsc-only": JscOnlyPort,
 "mac": MacPort,






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [285130] trunk/Source

2021-11-01 Thread pvollan

Title: [285130] trunk/Source








Revision 285130
Author pvol...@apple.com
Date 2021-11-01 14:04:45 -0700 (Mon, 01 Nov 2021)


Log Message
[macOS] Opening local html files is failing
https://bugs.webkit.org/show_bug.cgi?id=232572


Reviewed by Brent Fulgham.

Source/WebKit:

On some macOS versions, opening local html files is failing. In order for the WebContent process
to successfully issue the file extension to the Networking process, the flags for the extension
in the WebContent process must include the user intent flag when the extension is issued with an
audit token.

* Shared/Cocoa/SandboxExtensionCocoa.mm:
(WebKit::SandboxExtensionImpl::sandboxExtensionForType):

Source/WTF:

Declare sandbox flag.

* wtf/spi/darwin/SandboxSPI.h:

Modified Paths

trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/spi/darwin/SandboxSPI.h
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Shared/Cocoa/SandboxExtensionCocoa.mm




Diff

Modified: trunk/Source/WTF/ChangeLog (285129 => 285130)

--- trunk/Source/WTF/ChangeLog	2021-11-01 20:54:53 UTC (rev 285129)
+++ trunk/Source/WTF/ChangeLog	2021-11-01 21:04:45 UTC (rev 285130)
@@ -1,3 +1,15 @@
+2021-11-01  Per Arne  
+
+[macOS] Opening local html files is failing
+https://bugs.webkit.org/show_bug.cgi?id=232572
+
+
+Reviewed by Brent Fulgham.
+
+Declare sandbox flag.
+
+* wtf/spi/darwin/SandboxSPI.h:
+
 2021-11-01  Tim Horton  
 
 Add a testing preference to replay CG display lists manually


Modified: trunk/Source/WTF/wtf/spi/darwin/SandboxSPI.h (285129 => 285130)

--- trunk/Source/WTF/wtf/spi/darwin/SandboxSPI.h	2021-11-01 20:54:53 UTC (rev 285129)
+++ trunk/Source/WTF/wtf/spi/darwin/SandboxSPI.h	2021-11-01 21:04:45 UTC (rev 285130)
@@ -62,6 +62,7 @@
 
 extern const uint32_t SANDBOX_EXTENSION_NO_REPORT;
 extern const uint32_t SANDBOX_EXTENSION_CANONICAL;
+extern const uint32_t SANDBOX_EXTENSION_USER_INTENT;
 
 char *sandbox_extension_issue_file(const char *extension_class, const char *path, uint32_t flags);
 char *sandbox_extension_issue_generic(const char *extension_class, uint32_t flags);


Modified: trunk/Source/WebKit/ChangeLog (285129 => 285130)

--- trunk/Source/WebKit/ChangeLog	2021-11-01 20:54:53 UTC (rev 285129)
+++ trunk/Source/WebKit/ChangeLog	2021-11-01 21:04:45 UTC (rev 285130)
@@ -1,3 +1,19 @@
+2021-11-01  Per Arne  
+
+[macOS] Opening local html files is failing
+https://bugs.webkit.org/show_bug.cgi?id=232572
+
+
+Reviewed by Brent Fulgham.
+
+On some macOS versions, opening local html files is failing. In order for the WebContent process
+to successfully issue the file extension to the Networking process, the flags for the extension
+in the WebContent process must include the user intent flag when the extension is issued with an
+audit token.
+
+* Shared/Cocoa/SandboxExtensionCocoa.mm:
+(WebKit::SandboxExtensionImpl::sandboxExtensionForType):
+
 2021-11-01  Fujii Hironori  
 
 [WinCairo] Enable gpu_process_canvas_rendering and gpu_process_webgl by default


Modified: trunk/Source/WebKit/Shared/Cocoa/SandboxExtensionCocoa.mm (285129 => 285130)

--- trunk/Source/WebKit/Shared/Cocoa/SandboxExtensionCocoa.mm	2021-11-01 20:54:53 UTC (rev 285129)
+++ trunk/Source/WebKit/Shared/Cocoa/SandboxExtensionCocoa.mm	2021-11-01 21:04:45 UTC (rev 285130)
@@ -115,6 +115,9 @@
 case SandboxExtension::Type::ReadByProcess:
 if (!auditToken)
 return nullptr;
+#if PLATFORM(MAC)
+extensionFlags |= SANDBOX_EXTENSION_USER_INTENT;
+#endif
 return sandbox_extension_issue_file_to_process(APP_SANDBOX_READ, path, extensionFlags, *auditToken);
 }
 }






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [285129] trunk

2021-11-01 Thread bdakin

Title: [285129] trunk








Revision 285129
Author bda...@apple.com
Date 2021-11-01 13:54:53 -0700 (Mon, 01 Nov 2021)


Log Message
Add my GitHub name to contributors.json
https://bugs.webkit.org/show_bug.cgi?id=232495

Reviewed by Alexey Proskuryakov.

* metadata/contributors.json:

Modified Paths

trunk/ChangeLog
trunk/metadata/contributors.json




Diff

Modified: trunk/ChangeLog (285128 => 285129)

--- trunk/ChangeLog	2021-11-01 20:33:37 UTC (rev 285128)
+++ trunk/ChangeLog	2021-11-01 20:54:53 UTC (rev 285129)
@@ -1,3 +1,12 @@
+2021-11-01  Beth Dakin  
+
+Add my GitHub name to contributors.json
+https://bugs.webkit.org/show_bug.cgi?id=232495
+
+Reviewed by Alexey Proskuryakov.
+
+* metadata/contributors.json:
+
 2021-11-01  BJ Burg  
 
 Add bburg's GitHub username to contributors.json.


Modified: trunk/metadata/contributors.json (285128 => 285129)

--- trunk/metadata/contributors.json	2021-11-01 20:33:37 UTC (rev 285128)
+++ trunk/metadata/contributors.json	2021-11-01 20:54:53 UTC (rev 285129)
@@ -1089,6 +1089,7 @@
  "bda...@apple.com"
   ],
   "expertise" : "CSS (Cascading Style Sheets), Layout and Rendering, Resolution-Independence, HTML Parsing, Tables, Web Accessibility",
+  "github" : "dethbakin",
   "name" : "Beth Dakin",
   "nicks" : [
  "dethbakin"






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [285128] trunk/Tools

2021-11-01 Thread Hironori . Fujii

Title: [285128] trunk/Tools








Revision 285128
Author hironori.fu...@sony.com
Date 2021-11-01 13:33:37 -0700 (Mon, 01 Nov 2021)


Log Message
TestWTF.WTF_CompactUniquePtrTuple.Subclassing is randomly failing on WinCairo tester bots
https://bugs.webkit.org/show_bug.cgi?id=232556

Reviewed by Yusuke Suzuki.

"EXPECT_NE(oldPointer, a.pointer())" of line 241 was randomly
failing on WinCairo tester bots. This seems a simple mistake of
the test case. 'oldPointer' should be updated before destructing
the old value.

* TestWebKitAPI/Tests/WTF/CompactUniquePtrTuple.cpp:
(WTF_CompactUniquePtrTuple::Subclassing):

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WTF/CompactUniquePtrTuple.cpp




Diff

Modified: trunk/Tools/ChangeLog (285127 => 285128)

--- trunk/Tools/ChangeLog	2021-11-01 20:32:51 UTC (rev 285127)
+++ trunk/Tools/ChangeLog	2021-11-01 20:33:37 UTC (rev 285128)
@@ -1,3 +1,18 @@
+2021-11-01  Fujii Hironori  
+
+TestWTF.WTF_CompactUniquePtrTuple.Subclassing is randomly failing on WinCairo tester bots
+https://bugs.webkit.org/show_bug.cgi?id=232556
+
+Reviewed by Yusuke Suzuki.
+
+"EXPECT_NE(oldPointer, a.pointer())" of line 241 was randomly
+failing on WinCairo tester bots. This seems a simple mistake of
+the test case. 'oldPointer' should be updated before destructing
+the old value.
+
+* TestWebKitAPI/Tests/WTF/CompactUniquePtrTuple.cpp:
+(WTF_CompactUniquePtrTuple::Subclassing):
+
 2021-11-01  Brady Eidson  
 
 webpushd: Add mock in-memory registration, and the WKWebsiteDataStore SPI to manage them


Modified: trunk/Tools/TestWebKitAPI/Tests/WTF/CompactUniquePtrTuple.cpp (285127 => 285128)

--- trunk/Tools/TestWebKitAPI/Tests/WTF/CompactUniquePtrTuple.cpp	2021-11-01 20:32:51 UTC (rev 285127)
+++ trunk/Tools/TestWebKitAPI/Tests/WTF/CompactUniquePtrTuple.cpp	2021-11-01 20:33:37 UTC (rev 285128)
@@ -233,6 +233,7 @@
 EXPECT_NE(oldPointer, a.pointer());
 EXPECT_EQ(0x1cU, a.type());
 
+oldPointer = a.pointer();
 a = makeCompactUniquePtr();
 EXPECT_EQ(4U, A::s_constructorCallCount);
 EXPECT_EQ(3U, A::s_destructorCallCount);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [285127] trunk/Source/WebKit

2021-11-01 Thread Hironori . Fujii

Title: [285127] trunk/Source/WebKit








Revision 285127
Author hironori.fu...@sony.com
Date 2021-11-01 13:32:51 -0700 (Mon, 01 Nov 2021)


Log Message
[WinCairo] Enable gpu_process_canvas_rendering and gpu_process_webgl by default
https://bugs.webkit.org/show_bug.cgi?id=232555

Reviewed by Don Olmstead.

They can be disabled by the registry.

> reg add HKEY_CURRENT_USER\Software\WebKit /v gpu_process_canvas_rendering /t REG_DWORD /d 0 /f
> reg add HKEY_CURRENT_USER\Software\WebKit /v gpu_process_webgl /t REG_DWORD /d 0 /f

* Shared/WebPreferencesDefaultValues.cpp:
(WebKit::defaultUseGPUProcessForCanvasRenderingEnabled):
(WebKit::defaultUseGPUProcessForWebGLEnabled):
* Shared/win/WebPreferencesDefaultValuesWin.cpp:
(WebKit::isFeatureFlagEnabled):

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Shared/WebPreferencesDefaultValues.cpp
trunk/Source/WebKit/Shared/win/WebPreferencesDefaultValuesWin.cpp




Diff

Modified: trunk/Source/WebKit/ChangeLog (285126 => 285127)

--- trunk/Source/WebKit/ChangeLog	2021-11-01 20:27:51 UTC (rev 285126)
+++ trunk/Source/WebKit/ChangeLog	2021-11-01 20:32:51 UTC (rev 285127)
@@ -1,5 +1,23 @@
 2021-11-01  Fujii Hironori  
 
+[WinCairo] Enable gpu_process_canvas_rendering and gpu_process_webgl by default
+https://bugs.webkit.org/show_bug.cgi?id=232555
+
+Reviewed by Don Olmstead.
+
+They can be disabled by the registry.
+
+> reg add HKEY_CURRENT_USER\Software\WebKit /v gpu_process_canvas_rendering /t REG_DWORD /d 0 /f
+> reg add HKEY_CURRENT_USER\Software\WebKit /v gpu_process_webgl /t REG_DWORD /d 0 /f
+
+* Shared/WebPreferencesDefaultValues.cpp:
+(WebKit::defaultUseGPUProcessForCanvasRenderingEnabled):
+(WebKit::defaultUseGPUProcessForWebGLEnabled):
+* Shared/win/WebPreferencesDefaultValuesWin.cpp:
+(WebKit::isFeatureFlagEnabled):
+
+2021-11-01  Fujii Hironori  
+
 HashMap>::get can't compile
 https://bugs.webkit.org/show_bug.cgi?id=232554
 


Modified: trunk/Source/WebKit/Shared/WebPreferencesDefaultValues.cpp (285126 => 285127)

--- trunk/Source/WebKit/Shared/WebPreferencesDefaultValues.cpp	2021-11-01 20:27:51 UTC (rev 285126)
+++ trunk/Source/WebKit/Shared/WebPreferencesDefaultValues.cpp	2021-11-01 20:32:51 UTC (rev 285127)
@@ -161,7 +161,7 @@
 
 bool defaultUseGPUProcessForCanvasRenderingEnabled()
 {
-#if ENABLE(GPU_PROCESS_BY_DEFAULT)
+#if ENABLE(GPU_PROCESS_BY_DEFAULT) || PLATFORM(WIN)
 bool defaultValue = true;
 #else
 bool defaultValue = false;
@@ -188,7 +188,12 @@
 
 bool defaultUseGPUProcessForWebGLEnabled()
 {
-return isFeatureFlagEnabled("gpu_process_webgl", false);
+#if PLATFORM(WIN)
+bool defaultValue = true;
+#else
+bool defaultValue = false;
+#endif
+return isFeatureFlagEnabled("gpu_process_webgl", defaultValue);
 }
 
 #endif // ENABLE(GPU_PROCESS)


Modified: trunk/Source/WebKit/Shared/win/WebPreferencesDefaultValuesWin.cpp (285126 => 285127)

--- trunk/Source/WebKit/Shared/win/WebPreferencesDefaultValuesWin.cpp	2021-11-01 20:27:51 UTC (rev 285126)
+++ trunk/Source/WebKit/Shared/win/WebPreferencesDefaultValuesWin.cpp	2021-11-01 20:32:51 UTC (rev 285127)
@@ -39,11 +39,11 @@
 DWORD keyType;
 HRESULT hr = getRegistryValue(HKEY_CURRENT_USER, L"Software\\WebKit", featureNameWide.data(), , , );
 if (hr != ERROR_SUCCESS)
-return false;
+return defaultValue;
 if (keyType != REG_DWORD)
-return false;
+return defaultValue;
 if (dataSize != sizeof data)
-return false;
+return defaultValue;
 return data;
 }
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [285126] tags/Safari-613.1.6.5/

2021-11-01 Thread repstein

Title: [285126] tags/Safari-613.1.6.5/








Revision 285126
Author repst...@apple.com
Date 2021-11-01 13:27:51 -0700 (Mon, 01 Nov 2021)


Log Message
Tag Safari-613.1.6.5.

Added Paths

tags/Safari-613.1.6.5/




Diff




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [285125] trunk/Source/WebKit

2021-11-01 Thread Hironori . Fujii

Title: [285125] trunk/Source/WebKit








Revision 285125
Author hironori.fu...@sony.com
Date 2021-11-01 13:24:37 -0700 (Mon, 01 Nov 2021)


Log Message
HashMap>::get can't compile
https://bugs.webkit.org/show_bug.cgi?id=232554

Reviewed by Kimmo Kinnunen.

Because IPC::ScopedActiveMessageReceiveQueue didn't have own
HashTraits, it used GenericHashTraits. So, HashMap::get tried to
return PeekType, that was ScopedActiveMessageReceiveQueue. But, it
couldn't construct ScopedActiveMessageReceiveQueue from "const
ScopedActiveMessageReceiveQueue&".

* GPUProcess/GPUConnectionToWebProcess.cpp:
(WebKit::GPUConnectionToWebProcess::findRemoteGraphicsContextGL):
Use get() instead of find().
* Platform/IPC/ScopedActiveMessageReceiveQueue.h: Added HashTraits for it.

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/GPUProcess/GPUConnectionToWebProcess.cpp
trunk/Source/WebKit/Platform/IPC/ScopedActiveMessageReceiveQueue.h




Diff

Modified: trunk/Source/WebKit/ChangeLog (285124 => 285125)

--- trunk/Source/WebKit/ChangeLog	2021-11-01 20:16:03 UTC (rev 285124)
+++ trunk/Source/WebKit/ChangeLog	2021-11-01 20:24:37 UTC (rev 285125)
@@ -1,3 +1,21 @@
+2021-11-01  Fujii Hironori  
+
+HashMap>::get can't compile
+https://bugs.webkit.org/show_bug.cgi?id=232554
+
+Reviewed by Kimmo Kinnunen.
+
+Because IPC::ScopedActiveMessageReceiveQueue didn't have own
+HashTraits, it used GenericHashTraits. So, HashMap::get tried to
+return PeekType, that was ScopedActiveMessageReceiveQueue. But, it
+couldn't construct ScopedActiveMessageReceiveQueue from "const
+ScopedActiveMessageReceiveQueue&".
+
+* GPUProcess/GPUConnectionToWebProcess.cpp:
+(WebKit::GPUConnectionToWebProcess::findRemoteGraphicsContextGL):
+Use get() instead of find().
+* Platform/IPC/ScopedActiveMessageReceiveQueue.h: Added HashTraits for it.
+
 2021-11-01  Brady Eidson  
 
 webpushd: Add mock in-memory registration, and the WKWebsiteDataStore SPI to manage them


Modified: trunk/Source/WebKit/GPUProcess/GPUConnectionToWebProcess.cpp (285124 => 285125)

--- trunk/Source/WebKit/GPUProcess/GPUConnectionToWebProcess.cpp	2021-11-01 20:16:03 UTC (rev 285124)
+++ trunk/Source/WebKit/GPUProcess/GPUConnectionToWebProcess.cpp	2021-11-01 20:24:37 UTC (rev 285125)
@@ -355,10 +355,7 @@
 RefPtr GPUConnectionToWebProcess::findRemoteGraphicsContextGL(GraphicsContextGLIdentifier identifier)
 {
 ASSERT(RunLoop::isMain());
-auto iter = m_remoteGraphicsContextGLMap.find(identifier);
-if (iter == m_remoteGraphicsContextGLMap.end())
-return nullptr;
-return iter->value.get();
+return m_remoteGraphicsContextGLMap.get(identifier);
 }
 #endif
 


Modified: trunk/Source/WebKit/Platform/IPC/ScopedActiveMessageReceiveQueue.h (285124 => 285125)

--- trunk/Source/WebKit/Platform/IPC/ScopedActiveMessageReceiveQueue.h	2021-11-01 20:16:03 UTC (rev 285124)
+++ trunk/Source/WebKit/Platform/IPC/ScopedActiveMessageReceiveQueue.h	2021-11-01 20:24:37 UTC (rev 285125)
@@ -99,3 +99,12 @@
 ScopedActiveMessageReceiveQueue(Ref&&) -> ScopedActiveMessageReceiveQueue>;
 
 }
+
+namespace WTF {
+
+template struct HashTraits> : GenericHashTraits> {
+using PeekType = T*;
+static T* peek(const IPC::ScopedActiveMessageReceiveQueue& value) { return value.get(); }
+};
+
+}






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [285124] branches/safari-613.1.6-branch/Source

2021-11-01 Thread repstein

Title: [285124] branches/safari-613.1.6-branch/Source








Revision 285124
Author repst...@apple.com
Date 2021-11-01 13:16:03 -0700 (Mon, 01 Nov 2021)


Log Message
Versioning.

WebKit-7613.1.6.5

Modified Paths

branches/safari-613.1.6-branch/Source/_javascript_Core/Configurations/Version.xcconfig
branches/safari-613.1.6-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig
branches/safari-613.1.6-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig
branches/safari-613.1.6-branch/Source/WebCore/Configurations/Version.xcconfig
branches/safari-613.1.6-branch/Source/WebCore/PAL/Configurations/Version.xcconfig
branches/safari-613.1.6-branch/Source/WebInspectorUI/Configurations/Version.xcconfig
branches/safari-613.1.6-branch/Source/WebKit/Configurations/Version.xcconfig
branches/safari-613.1.6-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig




Diff

Modified: branches/safari-613.1.6-branch/Source/_javascript_Core/Configurations/Version.xcconfig (285123 => 285124)

--- branches/safari-613.1.6-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2021-11-01 20:10:24 UTC (rev 285123)
+++ branches/safari-613.1.6-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2021-11-01 20:16:03 UTC (rev 285124)
@@ -24,7 +24,7 @@
 MAJOR_VERSION = 613;
 MINOR_VERSION = 1;
 TINY_VERSION = 6;
-MICRO_VERSION = 4;
+MICRO_VERSION = 5;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 


Modified: branches/safari-613.1.6-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig (285123 => 285124)

--- branches/safari-613.1.6-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig	2021-11-01 20:10:24 UTC (rev 285123)
+++ branches/safari-613.1.6-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig	2021-11-01 20:16:03 UTC (rev 285124)
@@ -24,7 +24,7 @@
 MAJOR_VERSION = 613;
 MINOR_VERSION = 1;
 TINY_VERSION = 6;
-MICRO_VERSION = 4;
+MICRO_VERSION = 5;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 


Modified: branches/safari-613.1.6-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (285123 => 285124)

--- branches/safari-613.1.6-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2021-11-01 20:10:24 UTC (rev 285123)
+++ branches/safari-613.1.6-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2021-11-01 20:16:03 UTC (rev 285124)
@@ -24,7 +24,7 @@
 MAJOR_VERSION = 613;
 MINOR_VERSION = 1;
 TINY_VERSION = 6;
-MICRO_VERSION = 4;
+MICRO_VERSION = 5;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 


Modified: branches/safari-613.1.6-branch/Source/WebCore/Configurations/Version.xcconfig (285123 => 285124)

--- branches/safari-613.1.6-branch/Source/WebCore/Configurations/Version.xcconfig	2021-11-01 20:10:24 UTC (rev 285123)
+++ branches/safari-613.1.6-branch/Source/WebCore/Configurations/Version.xcconfig	2021-11-01 20:16:03 UTC (rev 285124)
@@ -24,7 +24,7 @@
 MAJOR_VERSION = 613;
 MINOR_VERSION = 1;
 TINY_VERSION = 6;
-MICRO_VERSION = 4;
+MICRO_VERSION = 5;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 


Modified: branches/safari-613.1.6-branch/Source/WebCore/PAL/Configurations/Version.xcconfig (285123 => 285124)

--- branches/safari-613.1.6-branch/Source/WebCore/PAL/Configurations/Version.xcconfig	2021-11-01 20:10:24 UTC (rev 285123)
+++ branches/safari-613.1.6-branch/Source/WebCore/PAL/Configurations/Version.xcconfig	2021-11-01 20:16:03 UTC (rev 285124)
@@ -24,7 +24,7 @@
 MAJOR_VERSION = 613;
 MINOR_VERSION = 1;
 TINY_VERSION = 6;
-MICRO_VERSION = 4;
+MICRO_VERSION = 5;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 


Modified: branches/safari-613.1.6-branch/Source/WebInspectorUI/Configurations/Version.xcconfig (285123 => 285124)

--- branches/safari-613.1.6-branch/Source/WebInspectorUI/Configurations/Version.xcconfig	2021-11-01 20:10:24 UTC (rev 285123)
+++ branches/safari-613.1.6-branch/Source/WebInspectorUI/Configurations/Version.xcconfig	2021-11-01 20:16:03 UTC (rev 285124)
@@ -1,7 +1,7 @@
 MAJOR_VERSION = 613;
 MINOR_VERSION = 1;
 TINY_VERSION = 6;
-MICRO_VERSION = 4;
+MICRO_VERSION = 5;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 


Modified: branches/safari-613.1.6-branch/Source/WebKit/Configurations/Version.xcconfig (285123 => 285124)

--- branches/safari-613.1.6-branch/Source/WebKit/Configurations/Version.xcconfig	2021-11-01 20:10:24 UTC (rev 285123)
+++ branches/safari-613.1.6-branch/Source/WebKit/Configurations/Version.xcconfig	2021-11-01 20:16:03 UTC (rev 285124)
@@ -24,7 +24,7 @@
 MAJOR_VERSION = 613;
 MINOR_VERSION = 1;
 TINY_VERSION = 6;
-MICRO_VERSION = 4;
+MICRO_VERSION = 5;
 NANO_VERSION = 0;
 FULL_VERSION =

[webkit-changes] [285123] trunk

2021-11-01 Thread sbarati

Title: [285123] trunk








Revision 285123
Author sbar...@apple.com
Date 2021-11-01 13:10:24 -0700 (Mon, 01 Nov 2021)


Log Message
ArrayBuffer species watchpoint being invalidated doesn't mean it's not an ArrayBuffer constructor from the same global object
https://bugs.webkit.org/show_bug.cgi?id=231322


Reviewed by Yusuke Suzuki.

JSTests:

* stress/array-buffer-species-watchpoint-should-not-dictate-if-constructor-is-correct.js: Added.
(main.async v23):
(main):

Source/_javascript_Core:

We were relying on the watchpoint to tell us if the Array species watchpoint
for 'constructor' is set to the right value. However, the watchpoint being
fired doesn't guarantee that it won't be the right value. For example, we
might not be able to install the watchpoint because the replacement watchpoint
may already be fired.

* runtime/JSArrayBufferPrototype.cpp:
(JSC::arrayBufferSpeciesConstructorSlow):

Modified Paths

trunk/JSTests/ChangeLog
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/runtime/JSArrayBufferPrototype.cpp


Added Paths

trunk/JSTests/stress/array-buffer-species-watchpoint-should-not-dictate-if-constructor-is-correct.js




Diff

Modified: trunk/JSTests/ChangeLog (285122 => 285123)

--- trunk/JSTests/ChangeLog	2021-11-01 20:08:01 UTC (rev 285122)
+++ trunk/JSTests/ChangeLog	2021-11-01 20:10:24 UTC (rev 285123)
@@ -1,3 +1,15 @@
+2021-11-01  Saam Barati  
+
+ArrayBuffer species watchpoint being invalidated doesn't mean it's not an ArrayBuffer constructor from the same global object
+https://bugs.webkit.org/show_bug.cgi?id=231322
+
+
+Reviewed by Yusuke Suzuki.
+
+* stress/array-buffer-species-watchpoint-should-not-dictate-if-constructor-is-correct.js: Added.
+(main.async v23):
+(main):
+
 2021-11-01  Robin Morisset  
 
 JSGenericTypedArrayView::set crashes if the length + objectOffset is > UINT32_MAX


Added: trunk/JSTests/stress/array-buffer-species-watchpoint-should-not-dictate-if-constructor-is-correct.js (0 => 285123)

--- trunk/JSTests/stress/array-buffer-species-watchpoint-should-not-dictate-if-constructor-is-correct.js	(rev 0)
+++ trunk/JSTests/stress/array-buffer-species-watchpoint-should-not-dictate-if-constructor-is-correct.js	2021-11-01 20:10:24 UTC (rev 285123)
@@ -0,0 +1,16 @@
+//@ runDefault("--useConcurrentJIT=false", "--useConcurrentGC=false", "--thresholdForJITSoon=10", "--thresholdForJITAfterWarmUp=10", "--thresholdForOptimizeAfterWarmUp=100", "--thresholdForOptimizeAfterLongWarmUp=100", "--thresholdForOptimizeSoon=100", "--thresholdForFTLOptimizeAfterWarmUp=1000", "--thresholdForFTLOptimizeSoon=1000", "--validateBCE=true", "--useConcurrentJIT=0", "--dumpFTLDisassembly=0", "--useFTLJIT=0")
+
+function main() {
+async function v23(v24) {
+for (let v30 = 0; v30 < 6; v30++) { } 
+ArrayBuffer.prototype.constructor = ArrayBuffer;
+}
+
+const v22 = [0, 0, 0]; 
+const v35 = v22.filter(v23);
+
+const v37 = [0, 0, 0]
+const v42 = new Uint8ClampedArray(v37);
+const v43 = new Uint32Array(v42);
+}
+main();


Modified: trunk/Source/_javascript_Core/ChangeLog (285122 => 285123)

--- trunk/Source/_javascript_Core/ChangeLog	2021-11-01 20:08:01 UTC (rev 285122)
+++ trunk/Source/_javascript_Core/ChangeLog	2021-11-01 20:10:24 UTC (rev 285123)
@@ -1,3 +1,20 @@
+2021-11-01  Saam Barati  
+
+ArrayBuffer species watchpoint being invalidated doesn't mean it's not an ArrayBuffer constructor from the same global object
+https://bugs.webkit.org/show_bug.cgi?id=231322
+
+
+Reviewed by Yusuke Suzuki.
+
+We were relying on the watchpoint to tell us if the Array species watchpoint
+for 'constructor' is set to the right value. However, the watchpoint being
+fired doesn't guarantee that it won't be the right value. For example, we
+might not be able to install the watchpoint because the replacement watchpoint
+may already be fired.
+
+* runtime/JSArrayBufferPrototype.cpp:
+(JSC::arrayBufferSpeciesConstructorSlow):
+
 2021-11-01  Robin Morisset  
 
 JSGenericTypedArrayView::set crashes if the length + objectOffset is > UINT32_MAX


Modified: trunk/Source/_javascript_Core/runtime/JSArrayBufferPrototype.cpp (285122 => 285123)

--- trunk/Source/_javascript_Core/runtime/JSArrayBufferPrototype.cpp	2021-11-01 20:08:01 UTC (rev 285122)
+++ trunk/Source/_javascript_Core/runtime/JSArrayBufferPrototype.cpp	2021-11-01 20:10:24 UTC (rev 285123)
@@ -52,9 +52,8 @@
 if (constructor.isConstructor(vm)) {
 JSObject* constructorObject = jsCast(constructor);
 JSGlobalObject* globalObjectFromConstructor = constructorObject->globalObject(vm);
-bool isArrayBufferConstructorFromAnotherRealm = globalObject != globalObjectFromConstructor
-&& constructorObject == globalObjectFromConstructor->arrayBufferConstructor(mode);
-if

[webkit-changes] [285122] trunk

2021-11-01 Thread bburg

Title: [285122] trunk








Revision 285122
Author bb...@apple.com
Date 2021-11-01 13:08:01 -0700 (Mon, 01 Nov 2021)


Log Message
Add bburg's GitHub username to contributors.json.

Unreviewed.

* metadata/contributors.json:
Also, canonicalize a recent change.

Modified Paths

trunk/ChangeLog
trunk/metadata/contributors.json




Diff

Modified: trunk/ChangeLog (285121 => 285122)

--- trunk/ChangeLog	2021-11-01 19:31:45 UTC (rev 285121)
+++ trunk/ChangeLog	2021-11-01 20:08:01 UTC (rev 285122)
@@ -1,3 +1,12 @@
+2021-11-01  BJ Burg  
+
+Add bburg's GitHub username to contributors.json.
+
+Unreviewed.
+
+* metadata/contributors.json:
+Also, canonicalize a recent change.
+
 2021-10-31  Fujii Hironori  
 
 [WinCairo] New GraphicsLayer for GPU process mode


Modified: trunk/metadata/contributors.json (285121 => 285122)

--- trunk/metadata/contributors.json	2021-11-01 19:31:45 UTC (rev 285121)
+++ trunk/metadata/contributors.json	2021-11-01 20:08:01 UTC (rev 285122)
@@ -939,6 +939,7 @@
  "b...@cs.washington.edu"
   ],
   "expertise" : "Developer Tools, Web Inspector, WebDriver, Cocoa API",
+  "github" : "burg",
   "name" : "BJ Burg",
   "nicks" : [
  "bburg",
@@ -5103,7 +5104,7 @@
   "emails" : [
  "obru...@igalia.com"
   ],
-  "github": "Loirooriol",
+  "github" : "Loirooriol",
   "name" : "Oriol Brufau",
   "nicks" : [
  "obrufau"
@@ -7021,4 +7022,4 @@
   ],
   "status" : "reviewer"
}
-]
+]
\ No newline at end of file






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [285121] trunk

2021-11-01 Thread beidson

Title: [285121] trunk








Revision 285121
Author beid...@apple.com
Date 2021-11-01 12:31:45 -0700 (Mon, 01 Nov 2021)


Log Message
webpushd: Add mock in-memory registration, and the WKWebsiteDataStore SPI to manage them
https://bugs.webkit.org/show_bug.cgi?id=232539

Reviewed by Alex Christensen.

Source/WebKit:

Covered by API test.

The old SPI to ask the client if notifications should be allowed will remain.

Assuming the client okays notifications, in the case of built-in notifications, the *actual*
registration interaction with the system will take place as an additional step in webpushd

This patch:
- Adds in-memory notification registration for webpushd
- Adds SPI to WKWebsiteDataStore to manage registrations
- Tests the SPI

* NetworkProcess/NetworkProcess.cpp:
(WebKit::NetworkProcess::deletePushAndNotificationRegistration):
(WebKit::NetworkProcess::getOriginsWithPushAndNotificationPermissions):
* NetworkProcess/NetworkProcess.h:
* NetworkProcess/NetworkProcess.messages.in:

* NetworkProcess/NetworkSession.h:
(WebKit::NetworkSession::notificationManager):

* NetworkProcess/Notifications/NetworkNotificationManager.cpp:
(WebKit::NetworkNotificationManager::requestSystemNotificationPermission):
(WebKit::NetworkNotificationManager::deletePushAndNotificationRegistration):
(WebKit::NetworkNotificationManager::getOriginsWithPushAndNotificationPermissions):
(WebKit::ReplyCaller::callReply):
(WebKit::ReplyCaller::callReply):
* NetworkProcess/Notifications/NetworkNotificationManager.h:

* Shared/API/APISecurityOrigin.h:
(API::SecurityOrigin::create):

* Shared/Notifications/NotificationManagerMessageHandler.h:
* Shared/Notifications/NotificationManagerMessageHandler.messages.in:

* Shared/WebPushDaemonConstants.h:
(WebKit::WebPushD::messageTypeSendsReply):

* UIProcess/API/Cocoa/WKWebsiteDataStore.mm:
(-[WKWebsiteDataStore _deletePushAndNotificationRegistration:completionHandler:]):
(-[WKWebsiteDataStore _getOriginsWithPushAndNotificationPermissions:]):
* UIProcess/API/Cocoa/WKWebsiteDataStorePrivate.h:

* UIProcess/Network/NetworkProcessProxy.cpp:
(WebKit::NetworkProcessProxy::deletePushAndNotificationRegistration):
(WebKit::NetworkProcessProxy::getOriginsWithPushAndNotificationPermissions):
* UIProcess/Network/NetworkProcessProxy.h:

* UIProcess/Notifications/WebNotificationManagerMessageHandler.cpp:
(WebKit::WebNotificationManagerMessageHandler::requestSystemNotificationPermission):
* UIProcess/Notifications/WebNotificationManagerMessageHandler.h:

* WebProcess/Notifications/NotificationPermissionRequestManager.cpp:
(WebKit::NotificationPermissionRequestManager::startRequest):

* webpushd/WebPushDaemon.h:
* webpushd/WebPushDaemon.mm:
(WebPushD::MessageInfo::getOriginsWithPushAndNotificationPermissions::encodeReply):
(WebPushD::MessageInfo::deletePushAndNotificationRegistration::encodeReply):
(WebPushD::MessageInfo::requestSystemNotificationPermission::encodeReply):
(WebPushD::Daemon::decodeAndHandleMessage):
(WebPushD::Daemon::requestSystemNotificationPermission):
(WebPushD::Daemon::getOriginsWithPushAndNotificationPermissions):
(WebPushD::Daemon::deletePushAndNotificationRegistration):

Tools:

* TestWebKitAPI/Tests/WebKitCocoa/WebPushDaemon.mm:
(-[NotificationPermissionDelegate _webView:requestNotificationPermissionForSecurityOrigin:decisionHandler:]):
(-[NotificationPermissionDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
(TestWebKitAPI::then):

Modified Paths

trunk/LayoutTests/http/tests/notifications/request.html
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/NetworkProcess/NetworkProcess.cpp
trunk/Source/WebKit/NetworkProcess/NetworkProcess.h
trunk/Source/WebKit/NetworkProcess/NetworkProcess.messages.in
trunk/Source/WebKit/NetworkProcess/NetworkSession.h
trunk/Source/WebKit/NetworkProcess/Notifications/NetworkNotificationManager.cpp
trunk/Source/WebKit/NetworkProcess/Notifications/NetworkNotificationManager.h
trunk/Source/WebKit/Shared/API/APISecurityOrigin.h
trunk/Source/WebKit/Shared/Notifications/NotificationManagerMessageHandler.h
trunk/Source/WebKit/Shared/Notifications/NotificationManagerMessageHandler.messages.in
trunk/Source/WebKit/Shared/WebPushDaemonConstants.h
trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebsiteDataStore.mm
trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebsiteDataStorePrivate.h
trunk/Source/WebKit/UIProcess/Network/NetworkProcessProxy.cpp
trunk/Source/WebKit/UIProcess/Network/NetworkProcessProxy.h
trunk/Source/WebKit/UIProcess/Notifications/WebNotificationManagerMessageHandler.cpp
trunk/Source/WebKit/UIProcess/Notifications/WebNotificationManagerMessageHandler.h
trunk/Source/WebKit/WebProcess/Notifications/NotificationPermissionRequestManager.cpp
trunk/Source/WebKit/webpushd/WebPushDaemon.h
trunk/Source/WebKit/webpushd/WebPushDaemon.mm
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/WebPushDaemon.mm




Diff

Modified: trunk/LayoutTests/http/tests/notifications/request.html (285120 => 285121)

---

[webkit-changes] [285120] trunk

2021-11-01 Thread drousso

Title: [285120] trunk








Revision 285120
Author drou...@apple.com
Date 2021-11-01 12:22:52 -0700 (Mon, 01 Nov 2021)


Log Message
[ iOS15 EWS ] TestWebKitAPI.CSSViewportUnits.SameUnobscuredSizeOverrides flaky fails on EWS
https://bugs.webkit.org/show_bug.cgi?id=232158


Reviewed by Megan Gardner.

Source/WebCore:

Tests: CSSViewportUnits.AllSame
   CSSViewportUnits.EmptyUnobscuredSizeOverrides
   CSSViewportUnits.SameUnobscuredSizeOverrides
   CSSViewportUnits.DifferentUnobscuredSizeOverrides

* page/FrameView.cpp:
(WebCore::FrameView::sizeForCSSDynamicViewportUnits const):
This should use `unobscuredContentRectIncludingScrollbars` to match `DOMWindow::inner{width,height}`.
I think I accidentally left in the old code when I was testing some other configurations
while working on r284628.

Tools:

* TestWebKitAPI/Tests/WebKitCocoa/CSSViewportUnits.mm:
(TEST.CSSViewportUnits.AllSame):
(TEST.CSSViewportUnits.EmptyUnobscuredSizeOverrides):
(TEST.CSSViewportUnits.SameUnobscuredSizeOverrides):
(TEST.CSSViewportUnits.DifferentUnobscuredSizeOverrides):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/FrameView.cpp
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/CSSViewportUnits.mm




Diff

Modified: trunk/Source/WebCore/ChangeLog (285119 => 285120)

--- trunk/Source/WebCore/ChangeLog	2021-11-01 19:22:20 UTC (rev 285119)
+++ trunk/Source/WebCore/ChangeLog	2021-11-01 19:22:52 UTC (rev 285120)
@@ -1,3 +1,22 @@
+2021-11-01  Devin Rousso  
+
+[ iOS15 EWS ] TestWebKitAPI.CSSViewportUnits.SameUnobscuredSizeOverrides flaky fails on EWS
+https://bugs.webkit.org/show_bug.cgi?id=232158
+
+
+Reviewed by Megan Gardner.
+
+Tests: CSSViewportUnits.AllSame
+   CSSViewportUnits.EmptyUnobscuredSizeOverrides
+   CSSViewportUnits.SameUnobscuredSizeOverrides
+   CSSViewportUnits.DifferentUnobscuredSizeOverrides
+
+* page/FrameView.cpp:
+(WebCore::FrameView::sizeForCSSDynamicViewportUnits const):
+This should use `unobscuredContentRectIncludingScrollbars` to match `DOMWindow::inner{width,height}`.
+I think I accidentally left in the old code when I was testing some other configurations
+while working on r284628.
+
 2021-11-01  Alan Bujtas  
 
 [LFC][IFC] Start using ubidi to find bidi boundaries


Modified: trunk/Source/WebCore/page/FrameView.cpp (285119 => 285120)

--- trunk/Source/WebCore/page/FrameView.cpp	2021-11-01 19:22:20 UTC (rev 285119)
+++ trunk/Source/WebCore/page/FrameView.cpp	2021-11-01 19:22:52 UTC (rev 285120)
@@ -5666,7 +5666,7 @@
 
 IntSize FrameView::sizeForCSSDynamicViewportUnits() const
 {
-return visibleContentRectIncludingScrollbars().size();
+return unobscuredContentRectIncludingScrollbars().size();
 }
 
 IntSize FrameView::sizeForCSSDefaultViewportUnits() const


Modified: trunk/Tools/ChangeLog (285119 => 285120)

--- trunk/Tools/ChangeLog	2021-11-01 19:22:20 UTC (rev 285119)
+++ trunk/Tools/ChangeLog	2021-11-01 19:22:52 UTC (rev 285120)
@@ -1,3 +1,17 @@
+2021-11-01  Devin Rousso  
+
+[ iOS15 EWS ] TestWebKitAPI.CSSViewportUnits.SameUnobscuredSizeOverrides flaky fails on EWS
+https://bugs.webkit.org/show_bug.cgi?id=232158
+
+
+Reviewed by Megan Gardner.
+
+* TestWebKitAPI/Tests/WebKitCocoa/CSSViewportUnits.mm:
+(TEST.CSSViewportUnits.AllSame):
+(TEST.CSSViewportUnits.EmptyUnobscuredSizeOverrides):
+(TEST.CSSViewportUnits.SameUnobscuredSizeOverrides):
+(TEST.CSSViewportUnits.DifferentUnobscuredSizeOverrides):
+
 2021-11-01  Simon Fraser  
 
 ImageDiff no longer needs a --tolerance argument, and fix sometimes-black diff images


Modified: trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/CSSViewportUnits.mm (285119 => 285120)

--- trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/CSSViewportUnits.mm	2021-11-01 19:22:20 UTC (rev 285119)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/CSSViewportUnits.mm	2021-11-01 19:22:52 UTC (rev 285120)
@@ -60,12 +60,10 @@
 EXPECT_EQ(320, getElementHeight(webView.get(), @"lvmin"));
 EXPECT_EQ(500, getElementHeight(webView.get(), @"lvmax"));
 
-int innerWidth = evaluateForInt(webView.get(), @"window.innerWidth");
-int innerHeight = evaluateForInt(webView.get(), @"window.innerHeight");
-EXPECT_EQ(innerWidth, getElementHeight(webView.get(), @"dvw"));
-EXPECT_EQ(innerHeight, getElementHeight(webView.get(), @"dvh"));
-EXPECT_EQ(innerWidth, getElementHeight(webView.get(), @"dvmin"));
-EXPECT_EQ(innerHeight, getElementHeight(webView.get(), @"dvmax"));
+EXPECT_EQ(evaluateForInt(webView.get(), @"window.innerWidth"), getElementHeight(webView.get(), @"dvw"));
+EXPECT_EQ(evaluateForInt(webView.get(), @"window.innerHeight"), getElementHeight(webView.get(), @"dvh"));
+EXPECT_EQ(evaluateForInt(webView.get(), @"window.innerWidth"), getElementHeight(webView.get(), @"dvmin"));
+

[webkit-changes] [285119] trunk/Source/WebCore

2021-11-01 Thread zalan

Title: [285119] trunk/Source/WebCore








Revision 285119
Author za...@apple.com
Date 2021-11-01 12:22:20 -0700 (Mon, 01 Nov 2021)


Log Message
[LFC][IFC] Start using ubidi to find bidi boundaries
https://bugs.webkit.org/show_bug.cgi?id=232552

Reviewed by Antti Koivisto.

In this patch, we start using ubidi to find the bidi boundaries in the paragraph content.
We also set the bidi levels on the associated inline item range. Later we'll be using these levels
to compute the visual order (after line breaking).
(see breakAndComputeBidiLevels for details)

* layout/formattingContexts/inline/InlineItem.h:
(WebCore::Layout::InlineItem::setBidiLevel):
* layout/formattingContexts/inline/InlineItemsBuilder.cpp:
(WebCore::Layout::InlineItemsBuilder::breakAndComputeBidiLevels):
* layout/formattingContexts/inline/InlineTextItem.cpp:
(WebCore::Layout::InlineTextItem::splitAt):
* layout/formattingContexts/inline/InlineTextItem.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/layout/formattingContexts/inline/InlineItem.h
trunk/Source/WebCore/layout/formattingContexts/inline/InlineItemsBuilder.cpp
trunk/Source/WebCore/layout/formattingContexts/inline/InlineItemsBuilder.h
trunk/Source/WebCore/layout/formattingContexts/inline/InlineTextItem.cpp
trunk/Source/WebCore/layout/formattingContexts/inline/InlineTextItem.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (285118 => 285119)

--- trunk/Source/WebCore/ChangeLog	2021-11-01 19:21:11 UTC (rev 285118)
+++ trunk/Source/WebCore/ChangeLog	2021-11-01 19:22:20 UTC (rev 285119)
@@ -1,3 +1,23 @@
+2021-11-01  Alan Bujtas  
+
+[LFC][IFC] Start using ubidi to find bidi boundaries
+https://bugs.webkit.org/show_bug.cgi?id=232552
+
+Reviewed by Antti Koivisto.
+
+In this patch, we start using ubidi to find the bidi boundaries in the paragraph content.
+We also set the bidi levels on the associated inline item range. Later we'll be using these levels
+to compute the visual order (after line breaking).
+(see breakAndComputeBidiLevels for details)
+
+* layout/formattingContexts/inline/InlineItem.h:
+(WebCore::Layout::InlineItem::setBidiLevel):
+* layout/formattingContexts/inline/InlineItemsBuilder.cpp:
+(WebCore::Layout::InlineItemsBuilder::breakAndComputeBidiLevels):
+* layout/formattingContexts/inline/InlineTextItem.cpp:
+(WebCore::Layout::InlineTextItem::splitAt):
+* layout/formattingContexts/inline/InlineTextItem.h:
+
 2021-11-01  Chris Dumez  
 
 Crash under HIDDevice::HIDDevice()


Modified: trunk/Source/WebCore/layout/formattingContexts/inline/InlineItem.h (285118 => 285119)

--- trunk/Source/WebCore/layout/formattingContexts/inline/InlineItem.h	2021-11-01 19:21:11 UTC (rev 285118)
+++ trunk/Source/WebCore/layout/formattingContexts/inline/InlineItem.h	2021-11-01 19:22:20 UTC (rev 285119)
@@ -34,6 +34,8 @@
 namespace WebCore {
 namespace Layout {
 
+class InlineItemsBuilder;
+
 class InlineItem {
 public:
 enum class Type : uint8_t {
@@ -65,6 +67,10 @@
 bool isInlineBoxEnd() const { return type() == Type::InlineBoxEnd; }
 
 private:
+friend class InlineItemsBuilder;
+
+void setBidiLevel(UBiDiLevel bidiLevel) { m_bidiLevel = bidiLevel; }
+
 const Box* m_layoutBox { nullptr };
 Type m_type { };
 UBiDiLevel m_bidiLevel { UBIDI_DEFAULT_LTR };


Modified: trunk/Source/WebCore/layout/formattingContexts/inline/InlineItemsBuilder.cpp (285118 => 285119)

--- trunk/Source/WebCore/layout/formattingContexts/inline/InlineItemsBuilder.cpp	2021-11-01 19:21:11 UTC (rev 285118)
+++ trunk/Source/WebCore/layout/formattingContexts/inline/InlineItemsBuilder.cpp	2021-11-01 19:22:20 UTC (rev 285119)
@@ -29,6 +29,7 @@
 #if ENABLE(LAYOUT_FORMATTING_CONTEXT)
 
 #include "InlineSoftLineBreakItem.h"
+#include 
 
 namespace WebCore {
 namespace Layout {
@@ -83,7 +84,7 @@
 {
 InlineItems inlineItems;
 collectInlineItems(inlineItems);
-breakInlineItemsAtBidiBoundaries(inlineItems);
+breakAndComputeBidiLevels(inlineItems);
 return inlineItems;
 }
 
@@ -133,9 +134,74 @@
 }
 }
 
-void InlineItemsBuilder::breakInlineItemsAtBidiBoundaries(InlineItems&)
+void InlineItemsBuilder::breakAndComputeBidiLevels(InlineItems& inlineItems)
 {
-// FIXME: Use ubidi to split the content at bidi boundaries.
+if (m_paragraphContentBuilder.isEmpty())
+return;
+ASSERT(!inlineItems.isEmpty());
+
+// 1. Setup the bidi boundary loop by calling ubidi_setPara with the paragraph text.
+// 2. Call ubidi_getLogicalRun to advance to the next bidi boundary until we hit the end of the content.
+// 3. Set the computed bidi level on the associated inline items. Split them as needed.
+UBiDi* ubidi = ubidi_open();
+
+auto closeUBiDiOnExit = makeScopeExit([&] {
+ubidi_close(ubidi);
+});
+
+UBiDiLevel bidiLevel = UBIDI_DEFAULT_LTR;
+bool useHeuristicBaseDirection = root().style().unicodeBidi()

[webkit-changes] [285118] trunk/Source/WebCore

2021-11-01 Thread cdumez

Title: [285118] trunk/Source/WebCore








Revision 285118
Author cdu...@apple.com
Date 2021-11-01 12:21:11 -0700 (Mon, 01 Nov 2021)


Log Message
Crash under HIDDevice::HIDDevice()
https://bugs.webkit.org/show_bug.cgi?id=232567


Reviewed by Simon Fraser.

Make sure we null check values returned by IOHIDDeviceGetProperty() before calling
CFNumberGetValue() on them.

* platform/mac/HIDDevice.cpp:
(WebCore::getDevicePropertyAsInt):
(WebCore::HIDDevice::HIDDevice):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/mac/HIDDevice.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (285117 => 285118)

--- trunk/Source/WebCore/ChangeLog	2021-11-01 18:01:21 UTC (rev 285117)
+++ trunk/Source/WebCore/ChangeLog	2021-11-01 19:21:11 UTC (rev 285118)
@@ -1,5 +1,20 @@
 2021-11-01  Chris Dumez  
 
+Crash under HIDDevice::HIDDevice()
+https://bugs.webkit.org/show_bug.cgi?id=232567
+
+
+Reviewed by Simon Fraser.
+
+Make sure we null check values returned by IOHIDDeviceGetProperty() before calling
+CFNumberGetValue() on them.
+
+* platform/mac/HIDDevice.cpp:
+(WebCore::getDevicePropertyAsInt):
+(WebCore::HIDDevice::HIDDevice):
+
+2021-11-01  Chris Dumez  
+
 Align XSLTProcessor with Blink and get closer to Gecko in the process
 https://bugs.webkit.org/show_bug.cgi?id=232485
 


Modified: trunk/Source/WebCore/platform/mac/HIDDevice.cpp (285117 => 285118)

--- trunk/Source/WebCore/platform/mac/HIDDevice.cpp	2021-11-01 18:01:21 UTC (rev 285117)
+++ trunk/Source/WebCore/platform/mac/HIDDevice.cpp	2021-11-01 19:21:11 UTC (rev 285118)
@@ -39,16 +39,21 @@
 
 namespace WebCore {
 
+static int getDevicePropertyAsInt(IOHIDDeviceRef device, CFStringRef key)
+{
+CFNumberRef cfPropertyValue = checked_cf_cast(IOHIDDeviceGetProperty(device, key));
+int propertyValue = -1;
+if (cfPropertyValue)
+CFNumberGetValue(cfPropertyValue, kCFNumberIntType, );
+return propertyValue;
+}
+
 HIDDevice::HIDDevice(IOHIDDeviceRef device)
 : m_rawDevice(device)
 {
-CFNumberRef cfVendorID = checked_cf_cast(IOHIDDeviceGetProperty(device, CFSTR(kIOHIDVendorIDKey)));
-CFNumberRef cfProductID = checked_cf_cast(IOHIDDeviceGetProperty(device, CFSTR(kIOHIDProductIDKey)));
+int vendorID = getDevicePropertyAsInt(device, CFSTR(kIOHIDVendorIDKey));
+int productID = getDevicePropertyAsInt(device, CFSTR(kIOHIDProductIDKey));
 
-int vendorID, productID;
-CFNumberGetValue(cfVendorID, kCFNumberIntType, );
-CFNumberGetValue(cfProductID, kCFNumberIntType, );
-
 if (vendorID < 0 || vendorID > std::numeric_limits::max()) {
 LOG(HID, "Device attached with malformed vendor ID 0x%x. Resetting to 0.", vendorID);
 vendorID = 0;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [285117] trunk

2021-11-01 Thread rmorisset

Title: [285117] trunk








Revision 285117
Author rmoris...@apple.com
Date 2021-11-01 11:01:21 -0700 (Mon, 01 Nov 2021)


Log Message
JSGenericTypedArrayView::set crashes if the length + objectOffset is > UINT32_MAX
https://bugs.webkit.org/show_bug.cgi?id=231975
rdar://84402043

Reviewed by Yusuke Suzuki.

JSTests:

- regress-84402043 is the testcase that revealed the problem.
- typed-array-set-large(-offset) test the same function, in the typed-array to typed-array case
- typed-array-large-slice tests the only caller that passes a non-0 objectOffset, and found other issues with it
- typed-array-large-oob-eventually-not.js is just another test of the Wasm4GB change that I had forgotten to commit

* stress/regress-84402043.js: Added.
* stress/typed-array-large-oob-eventually-not.js: Added.
(test):
* stress/typed-array-large-slice.js: Added.
(expect):
* stress/typed-array-set-large-offset.js: Added.
* stress/typed-array-set-large.js: Added.

Source/_javascript_Core:

UINT_MAX (and anything above it) is not a valid array index, so we cannot use JSObject::get(JSGlobalObject*, unsigned) with an index that big.
This was pointed by Yusuke in his review of my recent patch that introduced the problem (https://bugs.webkit.org/show_bug.cgi?id=229353#c21),
but I misunderstood the code and thought we could never get values that big at that point, thus only putting a RELEASE_ASSERT.
In this patch I instead apply his original suggestion to have a first loop using the (fast) JSObject::get(),
and a second loop for any large indices, using a slower but safe code path.

I also fixed an unrelated bug I noticed in Clobberize/AbstractInterpreter while testing the rest of the patch:
they were not aware that NewTypedArray can take a Int52RepUse child.

Finally, while trying to properly test this change, I discovered that genericTypedArrayViewProtoFuncSlice
(which is the only caller of JSGenericTypedArrayView::set which passes it a non-0 objectOffset)
was still using unsigned everywhere instead of size_t, and that the same was true of all other functions in the same file.
So I fixed it in the same patch.

* dfg/DFGAbstractInterpreterInlines.h:
(JSC::DFG::AbstractInterpreter::executeEffects):
* dfg/DFGClobberize.h:
(JSC::DFG::clobberize):
* runtime/JSArrayBufferConstructor.cpp:
(JSC::JSGenericArrayBufferConstructor::constructImpl):
* runtime/JSGenericTypedArrayViewConstructorInlines.h:
(JSC::constructGenericTypedArrayViewImpl):
* runtime/JSGenericTypedArrayViewInlines.h:
(JSC::JSGenericTypedArrayView::set):
* runtime/JSGenericTypedArrayViewPrototypeFunctions.h:
(JSC::argumentClampedIndexFromStartOrEnd):
(JSC::genericTypedArrayViewProtoFuncSet):
(JSC::genericTypedArrayViewProtoFuncCopyWithin):
(JSC::genericTypedArrayViewProtoFuncIncludes):
(JSC::genericTypedArrayViewProtoFuncIndexOf):
(JSC::genericTypedArrayViewProtoFuncJoin):
(JSC::genericTypedArrayViewProtoFuncFill):
(JSC::genericTypedArrayViewProtoFuncLastIndexOf):
(JSC::genericTypedArrayViewProtoFuncSlice):
(JSC::genericTypedArrayViewPrivateFuncSubarrayCreate):

Modified Paths

trunk/JSTests/ChangeLog
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/dfg/DFGAbstractInterpreterInlines.h
trunk/Source/_javascript_Core/dfg/DFGClobberize.h
trunk/Source/_javascript_Core/runtime/JSArrayBufferConstructor.cpp
trunk/Source/_javascript_Core/runtime/JSGenericTypedArrayViewConstructorInlines.h
trunk/Source/_javascript_Core/runtime/JSGenericTypedArrayViewInlines.h
trunk/Source/_javascript_Core/runtime/JSGenericTypedArrayViewPrototypeFunctions.h


Added Paths

trunk/JSTests/stress/regress-84402043.js
trunk/JSTests/stress/typed-array-large-oob-eventually-not.js
trunk/JSTests/stress/typed-array-large-slice.js
trunk/JSTests/stress/typed-array-set-large-offset.js
trunk/JSTests/stress/typed-array-set-large.js




Diff

Modified: trunk/JSTests/ChangeLog (285116 => 285117)

--- trunk/JSTests/ChangeLog	2021-11-01 17:50:16 UTC (rev 285116)
+++ trunk/JSTests/ChangeLog	2021-11-01 18:01:21 UTC (rev 285117)
@@ -1,3 +1,24 @@
+2021-11-01  Robin Morisset  
+
+JSGenericTypedArrayView::set crashes if the length + objectOffset is > UINT32_MAX
+https://bugs.webkit.org/show_bug.cgi?id=231975
+rdar://84402043
+
+Reviewed by Yusuke Suzuki.
+
+- regress-84402043 is the testcase that revealed the problem.
+- typed-array-set-large(-offset) test the same function, in the typed-array to typed-array case
+- typed-array-large-slice tests the only caller that passes a non-0 objectOffset, and found other issues with it
+- typed-array-large-oob-eventually-not.js is just another test of the Wasm4GB change that I had forgotten to commit
+
+* stress/regress-84402043.js: Added.
+* stress/typed-array-large-oob-eventually-not.js: Added.
+(test):
+* stress/typed-array-large-slice.js: Added.
+(expect):
+* stress/typed-array-set-large-offset.js: Added.
+* stress/typed-array-set-large.js:

[webkit-changes] [285116] trunk/Source/WebKit

2021-11-01 Thread commit-queue

Title: [285116] trunk/Source/WebKit








Revision 285116
Author commit-qu...@webkit.org
Date 2021-11-01 10:50:16 -0700 (Mon, 01 Nov 2021)


Log Message
GPU process WebKit logging is not initialised
https://bugs.webkit.org/show_bug.cgi?id=232563

Patch by Kimmo Kinnunen  on 2021-11-01
Reviewed by Chris Dumez.

The file was not including LogInitialization.h.
"using namespace WebCore" caused
WebKit::logChannels() to mean WebCore::logChannels().

* GPUProcess/GPUProcess.cpp:
(WebKit::GPUProcess::initializeGPUProcess):

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/GPUProcess/GPUProcess.cpp




Diff

Modified: trunk/Source/WebKit/ChangeLog (285115 => 285116)

--- trunk/Source/WebKit/ChangeLog	2021-11-01 17:45:35 UTC (rev 285115)
+++ trunk/Source/WebKit/ChangeLog	2021-11-01 17:50:16 UTC (rev 285116)
@@ -1,3 +1,17 @@
+2021-11-01  Kimmo Kinnunen  
+
+GPU process WebKit logging is not initialised
+https://bugs.webkit.org/show_bug.cgi?id=232563
+
+Reviewed by Chris Dumez.
+
+The file was not including LogInitialization.h.
+"using namespace WebCore" caused
+WebKit::logChannels() to mean WebCore::logChannels().
+
+* GPUProcess/GPUProcess.cpp:
+(WebKit::GPUProcess::initializeGPUProcess):
+
 2021-11-01  Sihui Liu  
 
 Increase responsiveness timeout for network process


Modified: trunk/Source/WebKit/GPUProcess/GPUProcess.cpp (285115 => 285116)

--- trunk/Source/WebKit/GPUProcess/GPUProcess.cpp	2021-11-01 17:45:35 UTC (rev 285115)
+++ trunk/Source/WebKit/GPUProcess/GPUProcess.cpp	2021-11-01 17:50:16 UTC (rev 285116)
@@ -38,7 +38,7 @@
 #include "GPUProcessCreationParameters.h"
 #include "GPUProcessProxyMessages.h"
 #include "GPUProcessSessionParameters.h"
-#include "Logging.h"
+#include "LogInitialization.h"
 #include "SandboxExtension.h"
 #include "WebPageProxyMessages.h"
 #include "WebProcessPoolMessages.h"
@@ -75,7 +75,6 @@
 #endif
 
 namespace WebKit {
-using namespace WebCore;
 
 // We wouldn't want the GPUProcess to repeatedly exit then relaunch when under memory pressure. In particular, we need to make sure the
 // WebProcess has a change to schedule work after the GPUProcess get launched. For this reason, we make sure that the GPUProcess never






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [285115] trunk/Source/WebKit

2021-11-01 Thread sihui_liu

Title: [285115] trunk/Source/WebKit








Revision 285115
Author sihui_...@apple.com
Date 2021-11-01 10:45:35 -0700 (Mon, 01 Nov 2021)


Log Message
Increase responsiveness timeout for network process
https://bugs.webkit.org/show_bug.cgi?id=232505

Reviewed by Chris Dumez.

* UIProcess/AuxiliaryProcessProxy.cpp:
(WebKit::AuxiliaryProcessProxy::AuxiliaryProcessProxy):
* UIProcess/AuxiliaryProcessProxy.h:
* UIProcess/Network/NetworkProcessProxy.cpp:
(WebKit::NetworkProcessProxy::NetworkProcessProxy):
(WebKit::NetworkProcessProxy::getNetworkProcessConnection):
* UIProcess/ResponsivenessTimer.cpp:
(WebKit::ResponsivenessTimer::ResponsivenessTimer):
(WebKit::ResponsivenessTimer::timerFired):
(WebKit::ResponsivenessTimer::start):
(): Deleted.
* UIProcess/ResponsivenessTimer.h:
* UIProcess/WebsiteData/WebsiteDataStore.cpp:
(WebKit::WebsiteDataStore::getNetworkProcessConnection):

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/AuxiliaryProcessProxy.cpp
trunk/Source/WebKit/UIProcess/AuxiliaryProcessProxy.h
trunk/Source/WebKit/UIProcess/Network/NetworkProcessProxy.cpp
trunk/Source/WebKit/UIProcess/ResponsivenessTimer.cpp
trunk/Source/WebKit/UIProcess/ResponsivenessTimer.h
trunk/Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.cpp




Diff

Modified: trunk/Source/WebKit/ChangeLog (285114 => 285115)

--- trunk/Source/WebKit/ChangeLog	2021-11-01 17:14:17 UTC (rev 285114)
+++ trunk/Source/WebKit/ChangeLog	2021-11-01 17:45:35 UTC (rev 285115)
@@ -1,3 +1,25 @@
+2021-11-01  Sihui Liu  
+
+Increase responsiveness timeout for network process
+https://bugs.webkit.org/show_bug.cgi?id=232505
+
+Reviewed by Chris Dumez.
+
+* UIProcess/AuxiliaryProcessProxy.cpp:
+(WebKit::AuxiliaryProcessProxy::AuxiliaryProcessProxy):
+* UIProcess/AuxiliaryProcessProxy.h:
+* UIProcess/Network/NetworkProcessProxy.cpp:
+(WebKit::NetworkProcessProxy::NetworkProcessProxy):
+(WebKit::NetworkProcessProxy::getNetworkProcessConnection):
+* UIProcess/ResponsivenessTimer.cpp:
+(WebKit::ResponsivenessTimer::ResponsivenessTimer):
+(WebKit::ResponsivenessTimer::timerFired):
+(WebKit::ResponsivenessTimer::start):
+(): Deleted.
+* UIProcess/ResponsivenessTimer.h:
+* UIProcess/WebsiteData/WebsiteDataStore.cpp:
+(WebKit::WebsiteDataStore::getNetworkProcessConnection):
+
 2021-11-01  Tim Horton  
 
 Add a testing preference to replay CG display lists manually


Modified: trunk/Source/WebKit/UIProcess/AuxiliaryProcessProxy.cpp (285114 => 285115)

--- trunk/Source/WebKit/UIProcess/AuxiliaryProcessProxy.cpp	2021-11-01 17:14:17 UTC (rev 285114)
+++ trunk/Source/WebKit/UIProcess/AuxiliaryProcessProxy.cpp	2021-11-01 17:45:35 UTC (rev 285115)
@@ -40,8 +40,8 @@
 
 namespace WebKit {
 
-AuxiliaryProcessProxy::AuxiliaryProcessProxy(bool alwaysRunsAtBackgroundPriority)
-: m_responsivenessTimer(*this)
+AuxiliaryProcessProxy::AuxiliaryProcessProxy(bool alwaysRunsAtBackgroundPriority, Seconds responsivenessTimeout)
+: m_responsivenessTimer(*this, responsivenessTimeout)
 , m_alwaysRunsAtBackgroundPriority(alwaysRunsAtBackgroundPriority)
 {
 }


Modified: trunk/Source/WebKit/UIProcess/AuxiliaryProcessProxy.h (285114 => 285115)

--- trunk/Source/WebKit/UIProcess/AuxiliaryProcessProxy.h	2021-11-01 17:14:17 UTC (rev 285114)
+++ trunk/Source/WebKit/UIProcess/AuxiliaryProcessProxy.h	2021-11-01 17:45:35 UTC (rev 285115)
@@ -43,7 +43,7 @@
 WTF_MAKE_NONCOPYABLE(AuxiliaryProcessProxy);
 
 protected:
-explicit AuxiliaryProcessProxy(bool alwaysRunsAtBackgroundPriority = false);
+AuxiliaryProcessProxy(bool alwaysRunsAtBackgroundPriority = false, Seconds responsivenessTimeout = ResponsivenessTimer::defaultResponsivenessTimeout);
 
 public:
 virtual ~AuxiliaryProcessProxy();


Modified: trunk/Source/WebKit/UIProcess/Network/NetworkProcessProxy.cpp (285114 => 285115)

--- trunk/Source/WebKit/UIProcess/Network/NetworkProcessProxy.cpp	2021-11-01 17:14:17 UTC (rev 285114)
+++ trunk/Source/WebKit/UIProcess/Network/NetworkProcessProxy.cpp	2021-11-01 17:45:35 UTC (rev 285115)
@@ -86,6 +86,8 @@
 namespace WebKit {
 using namespace WebCore;
 
+static constexpr Seconds networkProcessResponsivenessTimeout = 6_s;
+
 static HashSet& networkProcessesSet()
 {
 ASSERT(RunLoop::isMain());
@@ -201,7 +203,7 @@
 }
 
 NetworkProcessProxy::NetworkProcessProxy()
-: AuxiliaryProcessProxy(anyProcessPoolAlwaysRunsAtBackgroundPriority())
+: AuxiliaryProcessProxy(anyProcessPoolAlwaysRunsAtBackgroundPriority(), networkProcessResponsivenessTimeout)
 #if ENABLE(LEGACY_CUSTOM_PROTOCOL_MANAGER)
 , m_customProtocolManagerClient(makeUniqueRef())
 , m_customProtocolManagerProxy(*this)
@@ -255,8 +257,7 @@
 void NetworkProcessProxy::getNetworkProcessConnection(WebProcessProxy& webProcessProxy, Messages::WebProcessProxy::GetNetworkProcessConnection::DelayedReply&& reply)
 {

[webkit-changes] [285114] trunk/Source

2021-11-01 Thread timothy_horton

Title: [285114] trunk/Source








Revision 285114
Author timothy_hor...@apple.com
Date 2021-11-01 10:14:17 -0700 (Mon, 01 Nov 2021)


Log Message
Add a testing preference to replay CG display lists manually
https://bugs.webkit.org/show_bug.cgi?id=232566

Reviewed by Wenson Hsieh.

Source/WebKit:

* Shared/RemoteLayerTree/RemoteLayerBackingStore.h:
* Shared/RemoteLayerTree/RemoteLayerBackingStore.mm:
(WebKit::RemoteLayerBackingStore::applyBackingStoreToLayer):
* Shared/RemoteLayerTree/RemoteLayerTreePropertyApplier.mm:
(WebKit::RemoteLayerTreePropertyApplier::applyPropertiesToLayer):
* UIProcess/RemoteLayerTree/RemoteLayerTreeHost.h:
* UIProcess/RemoteLayerTree/RemoteLayerTreeHost.mm:
(WebKit::RemoteLayerTreeHost::replayCGDisplayListsIntoBackingStore const):
Plumb the preference through to _setWKContents.

* UIProcess/RemoteLayerTree/cocoa/RemoteLayerTreeLayers.h:
* UIProcess/RemoteLayerTree/cocoa/RemoteLayerTreeLayers.mm:
(-[WKCompositingLayer _setWKContents:withDisplayList:replayForTesting:]):
(-[WKCompositingLayer drawInContext:]):
(-[WKCompositingLayer _setWKContents:withDisplayList:]): Deleted.
If the preference is set, store the display list instead of setting it on the layer,
and call setNeedsDisplay, and then replay the display list in drawInContext.

Source/WTF:

* Scripts/Preferences/WebPreferencesInternal.yaml:

Modified Paths

trunk/Source/WTF/ChangeLog
trunk/Source/WTF/Scripts/Preferences/WebPreferencesInternal.yaml
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Shared/RemoteLayerTree/RemoteLayerBackingStore.h
trunk/Source/WebKit/Shared/RemoteLayerTree/RemoteLayerBackingStore.mm
trunk/Source/WebKit/Shared/RemoteLayerTree/RemoteLayerTreePropertyApplier.mm
trunk/Source/WebKit/UIProcess/RemoteLayerTree/RemoteLayerTreeHost.h
trunk/Source/WebKit/UIProcess/RemoteLayerTree/RemoteLayerTreeHost.mm
trunk/Source/WebKit/UIProcess/RemoteLayerTree/cocoa/RemoteLayerTreeLayers.h
trunk/Source/WebKit/UIProcess/RemoteLayerTree/cocoa/RemoteLayerTreeLayers.mm




Diff

Modified: trunk/Source/WTF/ChangeLog (285113 => 285114)

--- trunk/Source/WTF/ChangeLog	2021-11-01 17:12:10 UTC (rev 285113)
+++ trunk/Source/WTF/ChangeLog	2021-11-01 17:14:17 UTC (rev 285114)
@@ -1,3 +1,12 @@
+2021-11-01  Tim Horton  
+
+Add a testing preference to replay CG display lists manually
+https://bugs.webkit.org/show_bug.cgi?id=232566
+
+Reviewed by Wenson Hsieh.
+
+* Scripts/Preferences/WebPreferencesInternal.yaml:
+
 2021-10-29  Yusuke Suzuki  
 
 [JSC] Clean up Baseline StructureStubInfo management


Modified: trunk/Source/WTF/Scripts/Preferences/WebPreferencesInternal.yaml (285113 => 285114)

--- trunk/Source/WTF/Scripts/Preferences/WebPreferencesInternal.yaml	2021-11-01 17:12:10 UTC (rev 285113)
+++ trunk/Source/WTF/Scripts/Preferences/WebPreferencesInternal.yaml	2021-11-01 17:14:17 UTC (rev 285114)
@@ -621,6 +621,17 @@
 WebCore:
   default: true
 
+ReplayCGDisplayListsIntoBackingStore:
+  type: bool
+  humanReadableName: "CG Display Lists: Replay for Testing"
+  humanReadableDescription: "Replay CG Display Lists into layer contents for testing"
+  webcoreBinding: none
+  condition: ENABLE(CG_DISPLAY_LIST_BACKED_IMAGE_BUFFER)
+  exposed: [ WebKit ]
+  defaultValue:
+WebKit:
+  default: false
+
 ResourceLoadSchedulingEnabled:
   type: bool
   humanReadableName: "Resource Load Scheduling"
@@ -788,7 +799,7 @@
 
 UseCGDisplayListsForDOMRendering:
   type: bool
-  humanReadableName: "Use CG Display Lists for DOM rendering"
+  humanReadableName: "CG Display Lists: DOM Rendering"
   humanReadableDescription: "Use CG Display Lists for DOM rendering"
   webcoreBinding: none
   condition: ENABLE(CG_DISPLAY_LIST_BACKED_IMAGE_BUFFER)


Modified: trunk/Source/WebKit/ChangeLog (285113 => 285114)

--- trunk/Source/WebKit/ChangeLog	2021-11-01 17:12:10 UTC (rev 285113)
+++ trunk/Source/WebKit/ChangeLog	2021-11-01 17:14:17 UTC (rev 285114)
@@ -1,3 +1,28 @@
+2021-11-01  Tim Horton  
+
+Add a testing preference to replay CG display lists manually
+https://bugs.webkit.org/show_bug.cgi?id=232566
+
+Reviewed by Wenson Hsieh.
+
+* Shared/RemoteLayerTree/RemoteLayerBackingStore.h:
+* Shared/RemoteLayerTree/RemoteLayerBackingStore.mm:
+(WebKit::RemoteLayerBackingStore::applyBackingStoreToLayer):
+* Shared/RemoteLayerTree/RemoteLayerTreePropertyApplier.mm:
+(WebKit::RemoteLayerTreePropertyApplier::applyPropertiesToLayer):
+* UIProcess/RemoteLayerTree/RemoteLayerTreeHost.h:
+* UIProcess/RemoteLayerTree/RemoteLayerTreeHost.mm:
+(WebKit::RemoteLayerTreeHost::replayCGDisplayListsIntoBackingStore const):
+Plumb the preference through to _setWKContents.
+
+* UIProcess/RemoteLayerTree/cocoa/RemoteLayerTreeLayers.h:
+* UIProcess/RemoteLayerTree/cocoa/RemoteLayerTreeLayers.mm:
+(-[WKCompositingLayer _setWKContents:withDisplayList:replayForTesting:]):
+(-[WKCompositingLayer

[webkit-changes] [285113] trunk/LayoutTests

2021-11-01 Thread ayumi_kojima

Title: [285113] trunk/LayoutTests








Revision 285113
Author ayumi_koj...@apple.com
Date 2021-11-01 10:12:10 -0700 (Mon, 01 Nov 2021)


Log Message
[ iOS Debug ] http/wpt/push-api tests are flaky failing.
https://bugs.webkit.org/show_bug.cgi?id=232570

Unreviewed test gardening.

* platform/ios-wk2/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/ios-wk2/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (285112 => 285113)

--- trunk/LayoutTests/ChangeLog	2021-11-01 17:04:09 UTC (rev 285112)
+++ trunk/LayoutTests/ChangeLog	2021-11-01 17:12:10 UTC (rev 285113)
@@ -1,5 +1,14 @@
 2021-11-01  Ayumi Kojima  
 
+[ iOS Debug ] http/wpt/push-api tests are flaky failing.
+https://bugs.webkit.org/show_bug.cgi?id=232570
+
+Unreviewed test gardening.
+
+* platform/ios-wk2/TestExpectations:
+
+2021-11-01  Ayumi Kojima  
+
 [ iOS ] fast/events/ios/viewport-device-width-allows-double-tap-zoom-out.html is a flaky timeout.
 https://bugs.webkit.org/show_bug.cgi?id=232568
 


Modified: trunk/LayoutTests/platform/ios-wk2/TestExpectations (285112 => 285113)

--- trunk/LayoutTests/platform/ios-wk2/TestExpectations	2021-11-01 17:04:09 UTC (rev 285112)
+++ trunk/LayoutTests/platform/ios-wk2/TestExpectations	2021-11-01 17:12:10 UTC (rev 285113)
@@ -1971,6 +1971,10 @@
 
 webkit.org/b/228165 http/wpt/webrtc/transfer-datachannel-service-worker.https.html [ Pass Failure ]
 
+webkit.org/b/232570 [ Debug ] http/wpt/push-api/pushEvent.any.serviceworker.html [ Pass Failure ]
+webkit.org/b/232570 [ Debug ] http/wpt/push-api/pushManager.any.html [ Pass Failure ]
+webkit.org/b/232570 [ Debug ] http/wpt/push-api/pushManager.any.serviceworker.html [ Pass Failure ]
+
 webkit.org/b/215398 [ Release ] imported/w3c/web-platform-tests/css/css-images/idlharness.html [ Pass Timeout ]
 
 webkit.org/b/215403 imported/w3c/web-platform-tests/css/css-grid/layout-algorithm/flex-and-intrinsic-sizes-001.html [ Pass Timeout ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [285112] trunk

2021-11-01 Thread cdumez

Title: [285112] trunk








Revision 285112
Author cdu...@apple.com
Date 2021-11-01 10:04:09 -0700 (Mon, 01 Nov 2021)


Log Message
Align XSLTProcessor with Blink and get closer to Gecko in the process
https://bugs.webkit.org/show_bug.cgi?id=232485

Reviewed by Alex Christensen.

LayoutTests/imported/w3c:

Rebaseline WPT test now that more checks are passing.

* web-platform-tests/dom/idlharness.window-expected.txt:

Source/WebCore:

Align XSLTProcessor with Blink and get closer to Gecko (and the specification [1]) in the process.
The changes include making the parameters mandatory and non-nullable, as well as treating null
as the empty string for some parameters.

[1] https://dom.spec.whatwg.org/#xsltprocessor

No new tests, rebaselined existing test.

* xml/XSLTProcessor.cpp:
(WebCore::XSLTProcessor::transformToDocument):
(WebCore::XSLTProcessor::transformToFragment):
* xml/XSLTProcessor.h:
(WebCore::XSLTProcessor::importStylesheet):
* xml/XSLTProcessor.idl:

Modified Paths

trunk/LayoutTests/fast/xsl/xslt-processor-expected.txt
trunk/LayoutTests/fast/xsl/xslt-processor.html
trunk/LayoutTests/imported/w3c/ChangeLog
trunk/LayoutTests/imported/w3c/web-platform-tests/dom/idlharness.window-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/xml/XSLTProcessor.cpp
trunk/Source/WebCore/xml/XSLTProcessor.h
trunk/Source/WebCore/xml/XSLTProcessor.idl




Diff

Modified: trunk/LayoutTests/fast/xsl/xslt-processor-expected.txt (285111 => 285112)

--- trunk/LayoutTests/fast/xsl/xslt-processor-expected.txt	2021-11-01 16:43:10 UTC (rev 285111)
+++ trunk/LayoutTests/fast/xsl/xslt-processor-expected.txt	2021-11-01 17:04:09 UTC (rev 285112)
@@ -47,7 +47,7 @@
 
 
 1.3 Import undefined stylesheet:
-Failure (expected exception, instead got result: "undefined")
+Success
 1.4 Import undefined stylesheet:
 Failure (expected exception, instead got result: "undefined")
 1.5 Don't import stylesheet:
@@ -56,7 +56,7 @@
 2.0 DOMDocumentFragment transformToFragment(in DOMNode source, in DOMDocument output):
 
 2.1 fragment with undefined source:
-Failure (expected exception, instead got result: "null")
+Success
 2.2 fragment with undefined output document:
 Success
 2.3 use non-DOMDocument output parameter:
@@ -70,8 +70,8 @@
 
 3.0 DOMDocument transformToDocument(in DOMNode source):
 
-3.1 use non-DOMDocument output parameter:
-Failure (expected exception, instead got result: "null")
+3.1 document from undefined source:
+Success
 3.2 transform twice:
 Success
 
@@ -89,7 +89,7 @@
 5.0 Value getParameter(in DOMString namespaceURI, in DOMString localName):
 
 5.1 pass getParameter an undefined name:
-Failure (expected exception, instead got result: "null")
+Failure (expected exception, instead got result: "Success")
 5.2 pass getParameter a name which has not been set:
 Success
 5.3 verify getParameter actually gets (and set sets):


Modified: trunk/LayoutTests/fast/xsl/xslt-processor.html (285111 => 285112)

--- trunk/LayoutTests/fast/xsl/xslt-processor.html	2021-11-01 16:43:10 UTC (rev 285111)
+++ trunk/LayoutTests/fast/xsl/xslt-processor.html	2021-11-01 17:04:09 UTC (rev 285112)
@@ -26,7 +26,7 @@
 	testId = 0;
 }
 
-function addResultExpectException(name, func) {
+function addResultExpectException(testname, func) {
 	try {
 		var result = func();
 		addStringResult(testname, "Failure (expected exception, instead got result: \"" + result + "\")", "failure");
@@ -136,7 +136,9 @@
 
 
 // 2.0 DOMDocumentFragment transformToFragment(in DOMNode source, in DOMDocument output);
+
 addSectionHeader("DOMDocumentFragment transformToFragment(in DOMNode source, in DOMDocument output)");
+
 // 2.1 fragment with undefined source
 
 processor.reset();
@@ -147,9 +149,8 @@
 
 // 2.2 fragment with undefined output document
 
-ownerDocument = document.implementation.createDocument("", "test", null);
-newFragment = processor.transformToFragment(xml, undefined);
-addResultExpectValueWhenSerialized("fragment with undefined output document", newFragment, undefined);
+var testName = "fragment with undefined output document"
+addResultExpectException(testName, () => { processor.transformToFragment(xml, undefined); });
 
 // 2.3 use non-DOMDocument output parameter
 
@@ -274,7 +275,7 @@
 processor.setParameter(undefined, "undefined", "Success");
 processor.removeParameter(undefined, undefined);
 var testname = "pass removeParameter undefined name";
-addResultExpectValue(testname, processor.getParameter(undefined, "undefined"), "Success");
+addResultExpectValue(testname, processor.getParameter(undefined, "undefined"), null);
 
 // 6.4 pass removeParameter a name which has not been set
 
@@ -318,4 +319,4 @@
 
 
 
-
\ No newline at end of file
+


Modified: trunk/LayoutTests/imported/w3c/ChangeLog (285111 => 285112)

--- trunk/LayoutTests/imported/w3c/ChangeLog	2021-11-01 16:43:10 UTC (rev 285111)
+++ trunk/LayoutTests/imported/w3c/ChangeLog	2021-11-01 17:04:09 UTC (rev 285112)
@@ -1,3 +1,14 @@

[webkit-changes] [285111] trunk/LayoutTests

2021-11-01 Thread ayumi_kojima

Title: [285111] trunk/LayoutTests








Revision 285111
Author ayumi_koj...@apple.com
Date 2021-11-01 09:43:10 -0700 (Mon, 01 Nov 2021)


Log Message
[ iOS ] fast/events/ios/viewport-device-width-allows-double-tap-zoom-out.html is a flaky timeout.
https://bugs.webkit.org/show_bug.cgi?id=232568

Unreviewed test gardening.

* platform/ios-wk2/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/ios-wk2/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (285110 => 285111)

--- trunk/LayoutTests/ChangeLog	2021-11-01 16:27:56 UTC (rev 285110)
+++ trunk/LayoutTests/ChangeLog	2021-11-01 16:43:10 UTC (rev 285111)
@@ -1,3 +1,12 @@
+2021-11-01  Ayumi Kojima  
+
+[ iOS ] fast/events/ios/viewport-device-width-allows-double-tap-zoom-out.html is a flaky timeout.
+https://bugs.webkit.org/show_bug.cgi?id=232568
+
+Unreviewed test gardening.
+
+* platform/ios-wk2/TestExpectations:
+
 2021-11-01  Chris Dumez  
 
 REGRESSION (r283935): fast/css/style-element-process-crash.html is a flaky failure


Modified: trunk/LayoutTests/platform/ios-wk2/TestExpectations (285110 => 285111)

--- trunk/LayoutTests/platform/ios-wk2/TestExpectations	2021-11-01 16:27:56 UTC (rev 285110)
+++ trunk/LayoutTests/platform/ios-wk2/TestExpectations	2021-11-01 16:43:10 UTC (rev 285111)
@@ -2147,6 +2147,8 @@
 
 webkit.org/b/230987 fast/events/ios/viewport-shrink-to-fit-allows-double-tap.html [ Pass Timeout ]
 
+webkit.org/b/232568 fast/events/ios/viewport-device-width-allows-double-tap-zoom-out.html [ Pass Timeout ]
+
 webkit.org/b/231311 fast/events/ios/fast-click-double-tap-to-zoom-in-on-text-and-then-again-to-zoom-out.html [ Pass Failure ]
 
 webkit.org/b/229558 http/tests/navigation/page-cache-getUserMedia-pending-promise.html [ Pass Failure ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [285110] trunk/Source

2021-11-01 Thread ayumi_kojima

Title: [285110] trunk/Source








Revision 285110
Author ayumi_koj...@apple.com
Date 2021-11-01 09:27:56 -0700 (Mon, 01 Nov 2021)


Log Message
Unreviewed, reverting r285055.

Reverting because this commit may have caused
webgl/1.0.x/conformance/textures/misc/texture-corner-case-
videos.html and webgl/2.0.y/conformance/textures/misc/texture-
corner-case-videos.html to time out

Reverted changeset:

"Avoid sending video data to Web process for
canvas.drawImage(video)"
https://bugs.webkit.org/show_bug.cgi?id=230766
https://commits.webkit.org/r285055

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/canvas/CanvasRenderingContext2DBase.cpp
trunk/Source/WebCore/platform/graphics/ImageBuffer.h
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/WebProcess/GPU/graphics/RemoteImageBufferProxy.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (285109 => 285110)

--- trunk/Source/WebCore/ChangeLog	2021-11-01 16:23:21 UTC (rev 285109)
+++ trunk/Source/WebCore/ChangeLog	2021-11-01 16:27:56 UTC (rev 285110)
@@ -1,3 +1,19 @@
+2021-11-01  Ayumi Kojima  
+
+Unreviewed, reverting r285055.
+
+Reverting because this commit may have caused
+webgl/1.0.x/conformance/textures/misc/texture-corner-case-
+videos.html and webgl/2.0.y/conformance/textures/misc/texture-
+corner-case-videos.html to time out
+
+Reverted changeset:
+
+"Avoid sending video data to Web process for
+canvas.drawImage(video)"
+https://bugs.webkit.org/show_bug.cgi?id=230766
+https://commits.webkit.org/r285055
+
 2021-11-01  Alan Bujtas  
 
 Addressing post-commit comment (r285093).


Modified: trunk/Source/WebCore/html/canvas/CanvasRenderingContext2DBase.cpp (285109 => 285110)

--- trunk/Source/WebCore/html/canvas/CanvasRenderingContext2DBase.cpp	2021-11-01 16:23:21 UTC (rev 285109)
+++ trunk/Source/WebCore/html/canvas/CanvasRenderingContext2DBase.cpp	2021-11-01 16:27:56 UTC (rev 285110)
@@ -1677,19 +1677,17 @@
 checkOrigin();
 
 #if USE(CG)
-if (!canvasBase().buffer()->isRemote()) {
-if (auto image = video.nativeImageForCurrentTime()) {
-c->drawNativeImage(*image, FloatSize(video.videoWidth(), video.videoHeight()), dstRect, srcRect);
+if (auto image = video.nativeImageForCurrentTime()) {
+c->drawNativeImage(*image, FloatSize(video.videoWidth(), video.videoHeight()), dstRect, srcRect);
 
-if (isEntireBackingStoreDirty())
-didDraw(std::nullopt);
-else if (rectContainsCanvas(dstRect))
-didDrawEntireCanvas();
-else
-didDraw(dstRect);
+if (isEntireBackingStoreDirty())
+didDraw(std::nullopt);
+else if (rectContainsCanvas(dstRect))
+didDrawEntireCanvas();
+else
+didDraw(dstRect);
 
-return { };
-}
+return { };
 }
 #endif
 


Modified: trunk/Source/WebCore/platform/graphics/ImageBuffer.h (285109 => 285110)

--- trunk/Source/WebCore/platform/graphics/ImageBuffer.h	2021-11-01 16:23:21 UTC (rev 285109)
+++ trunk/Source/WebCore/platform/graphics/ImageBuffer.h	2021-11-01 16:27:56 UTC (rev 285110)
@@ -71,7 +71,6 @@
 
 virtual RenderingMode renderingMode() const = 0;
 virtual bool canMapBackingStore() const = 0;
-virtual bool isRemote() const { return false; }
 virtual RenderingResourceIdentifier renderingResourceIdentifier() const { return { }; }
 
 virtual GraphicsContext& context() const = 0;


Modified: trunk/Source/WebKit/ChangeLog (285109 => 285110)

--- trunk/Source/WebKit/ChangeLog	2021-11-01 16:23:21 UTC (rev 285109)
+++ trunk/Source/WebKit/ChangeLog	2021-11-01 16:27:56 UTC (rev 285110)
@@ -1,3 +1,19 @@
+2021-11-01  Ayumi Kojima  
+
+Unreviewed, reverting r285055.
+
+Reverting because this commit may have caused
+webgl/1.0.x/conformance/textures/misc/texture-corner-case-
+videos.html and webgl/2.0.y/conformance/textures/misc/texture-
+corner-case-videos.html to time out
+
+Reverted changeset:
+
+"Avoid sending video data to Web process for
+canvas.drawImage(video)"
+https://bugs.webkit.org/show_bug.cgi?id=230766
+https://commits.webkit.org/r285055
+
 2021-11-01  Daniel Kolesa  
 
 Fix build with GCC 8.4 on Ubuntu 18.04


Modified: trunk/Source/WebKit/WebProcess/GPU/graphics/RemoteImageBufferProxy.h (285109 => 285110)

--- trunk/Source/WebKit/WebProcess/GPU/graphics/RemoteImageBufferProxy.h	2021-11-01 16:23:21 UTC (rev 285109)
+++ trunk/Source/WebKit/WebProcess/GPU/graphics/RemoteImageBufferProxy.h	2021-11-01 16:27:56 UTC (rev 285110)
@@ -96,8 +96,6 @@
 ASSERT(m_sentFlushIdentifier == targetFlushIdentifier);
 }
 
-bool isRemote() const final { return true; }
-
 protected:
 RemoteImageBufferProxy(const WebCore::ImageBufferBackend::Parameters& parameters, RemoteRenderingBackendProxy& remoteRenderingBackendProxy)

[webkit-changes] [285109] trunk/Tools

2021-11-01 Thread simon . fraser

Title: [285109] trunk/Tools








Revision 285109
Author simon.fra...@apple.com
Date 2021-11-01 09:23:21 -0700 (Mon, 01 Nov 2021)


Log Message
ImageDiff no longer needs a --tolerance argument, and fix sometimes-black diff images
https://bugs.webkit.org/show_bug.cgi?id=232522

Reviewed by Martin Robinson.

ImageDiff no longer deals with tolerance, so remove `--tolerance` handling code in ImageDiff
and the driving script.

Also fix an issue where the diff image could be all black pixels even when there was a diff;
we need to ensure that a pixel with any diff is non-zero before scaling, and we need to
ensure that scaling by legacyDistanceMax doesn't overflow.

* ImageDiff/ImageDiff.cpp:
(processImages):
(main):
* ImageDiff/PlatformImage.cpp:
(ImageDiff::PlatformImage::difference):
* ImageDiff/PlatformImage.h:
* ImageDiff/cg/PlatformImageCG.cpp:
(ImageDiff::PlatformImage::createFromFile):
* Scripts/webkitpy/port/image_diff.py:
(ImageDiffer.diff_image):
(ImageDiffer._start): No need to restart ImageDiff if the tolerance changed, since
ImageDiff doesn't consult it. Tolerance in the python here just feeds into
the ImageDiffResult.
* Scripts/webkitpy/port/port_testcase.py:
(PortTestCase.test_diff_image):

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/ImageDiff/ImageDiff.cpp
trunk/Tools/ImageDiff/PlatformImage.cpp
trunk/Tools/ImageDiff/PlatformImage.h
trunk/Tools/ImageDiff/cg/PlatformImageCG.cpp
trunk/Tools/Scripts/webkitpy/port/image_diff.py
trunk/Tools/Scripts/webkitpy/port/port_testcase.py




Diff

Modified: trunk/Tools/ChangeLog (285108 => 285109)

--- trunk/Tools/ChangeLog	2021-11-01 16:02:28 UTC (rev 285108)
+++ trunk/Tools/ChangeLog	2021-11-01 16:23:21 UTC (rev 285109)
@@ -1,3 +1,33 @@
+2021-11-01  Simon Fraser  
+
+ImageDiff no longer needs a --tolerance argument, and fix sometimes-black diff images
+https://bugs.webkit.org/show_bug.cgi?id=232522
+
+Reviewed by Martin Robinson.
+
+ImageDiff no longer deals with tolerance, so remove `--tolerance` handling code in ImageDiff
+and the driving script.
+
+Also fix an issue where the diff image could be all black pixels even when there was a diff;
+we need to ensure that a pixel with any diff is non-zero before scaling, and we need to
+ensure that scaling by legacyDistanceMax doesn't overflow.
+
+* ImageDiff/ImageDiff.cpp:
+(processImages):
+(main):
+* ImageDiff/PlatformImage.cpp:
+(ImageDiff::PlatformImage::difference):
+* ImageDiff/PlatformImage.h:
+* ImageDiff/cg/PlatformImageCG.cpp:
+(ImageDiff::PlatformImage::createFromFile):
+* Scripts/webkitpy/port/image_diff.py:
+(ImageDiffer.diff_image):
+(ImageDiffer._start): No need to restart ImageDiff if the tolerance changed, since
+ImageDiff doesn't consult it. Tolerance in the python here just feeds into
+the ImageDiffResult.
+* Scripts/webkitpy/port/port_testcase.py:
+(PortTestCase.test_diff_image):
+
 2021-11-01  Aakash Jain  
 
 Fix a typo in EWS emails


Modified: trunk/Tools/ImageDiff/ImageDiff.cpp (285108 => 285109)

--- trunk/Tools/ImageDiff/ImageDiff.cpp	2021-11-01 16:02:28 UTC (rev 285108)
+++ trunk/Tools/ImageDiff/ImageDiff.cpp	2021-11-01 16:23:21 UTC (rev 285109)
@@ -49,7 +49,7 @@
 #define FORMAT_SIZE_T "zu"
 #endif
 
-static int processImages(std::unique_ptr&& actualImage, std::unique_ptr&& baselineImage, float tolerance, bool printDifference)
+static int processImages(std::unique_ptr&& actualImage, std::unique_ptr&& baselineImage, bool exact, bool printDifference)
 {
 if (!actualImage->isCompatible(*baselineImage)) {
 if (actualImage->width() != baselineImage->width() || actualImage->height() != baselineImage->height()) {
@@ -64,7 +64,7 @@
 }
 
 PlatformImage::Difference differenceData = { 100, 0, 0 };
-auto diffImage = actualImage->difference(*baselineImage, differenceData);
+auto diffImage = actualImage->difference(*baselineImage, exact, differenceData);
 if (diffImage)
 diffImage->writeAsPNGToStdout();
 
@@ -86,25 +86,11 @@
 _setmode(1, _O_BINARY);
 #endif
 
-float tolerance = 0.0f;
 bool verbose = false;
+bool exact = false;
 bool printDifference = false;
 
 for (int i = 1; i < argc; ++i) {
-if (!strcmp(argv[i], "-t") || !strcmp(argv[i], "--tolerance")) {
-if (i >= argc - 1)
-return EXIT_FAILURE;
-
-char* readEnd = NULL;
-tolerance = strtof(argv[i + 1], );
-if (readEnd == argv[i + 1]) {
-fprintf(stderr, "Failed to read numberic tolerance value from %s\n", argv[i + 1]);
-return EXIT_FAILURE;
-}
-++i;
-continue;
-}
-
 if (!strcmp(argv[i], "-v") || !strcmp(argv[i], "--verbose")) {
 verbose = true;
 continue;
@@ -115,9 +101,14 @@
 continue;

[webkit-changes] [285108] trunk/Source/WebCore

2021-11-01 Thread zalan

Title: [285108] trunk/Source/WebCore








Revision 285108
Author za...@apple.com
Date 2021-11-01 09:02:28 -0700 (Mon, 01 Nov 2021)


Log Message
Addressing post-commit comment (r285093).

* layout/formattingContexts/inline/InlineItemsBuilder.cpp:
(WebCore::Layout::InlineItemsBuilder::handleInlineBoxStart):
(WebCore::Layout::InlineItemsBuilder::handleInlineBoxEnd):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/layout/formattingContexts/inline/InlineItemsBuilder.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (285107 => 285108)

--- trunk/Source/WebCore/ChangeLog	2021-11-01 15:58:18 UTC (rev 285107)
+++ trunk/Source/WebCore/ChangeLog	2021-11-01 16:02:28 UTC (rev 285108)
@@ -1,5 +1,13 @@
 2021-11-01  Alan Bujtas  
 
+Addressing post-commit comment (r285093).
+
+* layout/formattingContexts/inline/InlineItemsBuilder.cpp:
+(WebCore::Layout::InlineItemsBuilder::handleInlineBoxStart):
+(WebCore::Layout::InlineItemsBuilder::handleInlineBoxEnd):
+
+2021-11-01  Alan Bujtas  
+
 [LFC][IFC] Introduce paragraph content building to InlineItemsBuilder::handleTextContent
 https://bugs.webkit.org/show_bug.cgi?id=232546
 


Modified: trunk/Source/WebCore/layout/formattingContexts/inline/InlineItemsBuilder.cpp (285107 => 285108)

--- trunk/Source/WebCore/layout/formattingContexts/inline/InlineItemsBuilder.cpp	2021-11-01 15:58:18 UTC (rev 285107)
+++ trunk/Source/WebCore/layout/formattingContexts/inline/InlineItemsBuilder.cpp	2021-11-01 16:02:28 UTC (rev 285108)
@@ -265,9 +265,6 @@
 return;
 
 auto isLeftToRightDirection = style.isLeftToRightDirection();
-auto enteringContentControlChar = std::optional { };
-auto nestedContentControlChar = std::optional { };
-
 switch (style.unicodeBidi()) {
 case EUnicodeBidi::UBNormal:
 // The box does not open an additional level of embedding with respect to the bidirectional algorithm.
@@ -274,29 +271,24 @@
 // For inline boxes, implicit reordering works across box boundaries.
 break;
 case EUnicodeBidi::Embed:
-enteringContentControlChar = isLeftToRightDirection ? leftToRightEmbed : rightToLeftEmbed;
+enterBidiContext(inlineBox, isLeftToRightDirection ? leftToRightEmbed : rightToLeftEmbed, inlineItems);
 break;
 case EUnicodeBidi::Override:
-enteringContentControlChar = isLeftToRightDirection ? leftToRightOverride : rightToLeftOverride;
+enterBidiContext(inlineBox, isLeftToRightDirection ? leftToRightOverride : rightToLeftOverride, inlineItems);
 break;
 case EUnicodeBidi::Isolate:
-enteringContentControlChar = isLeftToRightDirection ? leftToRightIsolate : rightToLeftIsolate;
+enterBidiContext(inlineBox, isLeftToRightDirection ? leftToRightIsolate : rightToLeftIsolate, inlineItems);
 break;
 case EUnicodeBidi::Plaintext:
-enteringContentControlChar = firstStrongIsolate;
+enterBidiContext(inlineBox, firstStrongIsolate, inlineItems);
 break;
 case EUnicodeBidi::IsolateOverride:
-enteringContentControlChar = firstStrongIsolate;
-nestedContentControlChar = isLeftToRightDirection ? leftToRightOverride : rightToLeftOverride;
+enterBidiContext(inlineBox, firstStrongIsolate, inlineItems);
+enterBidiContext(inlineBox, isLeftToRightDirection ? leftToRightOverride : rightToLeftOverride, inlineItems);
 break;
 default:
 ASSERT_NOT_REACHED();
 }
-
-if (enteringContentControlChar)
-enterBidiContext(inlineBox, *enteringContentControlChar, inlineItems);
-if (nestedContentControlChar)
-enterBidiContext(inlineBox, *nestedContentControlChar, inlineItems);
 }
 
 void InlineItemsBuilder::handleInlineBoxEnd(const Box& inlineBox, InlineItems& inlineItems)
@@ -307,9 +299,6 @@
 if (style.rtlOrdering() == Order::Visual)
 return;
 
-auto exitingContentControlChar = std::optional { };
-auto nestedContentControlChar = std::optional { };
-
 switch (style.unicodeBidi()) {
 case EUnicodeBidi::UBNormal:
 // The box does not open an additional level of embedding with respect to the bidirectional algorithm.
@@ -316,29 +305,24 @@
 // For inline boxes, implicit reordering works across box boundaries.
 break;
 case EUnicodeBidi::Embed:
-exitingContentControlChar = popDirectionalFormatting;
+exitBidiContext(inlineBox, popDirectionalFormatting);
 break;
 case EUnicodeBidi::Override:
-exitingContentControlChar = popDirectionalFormatting;
+exitBidiContext(inlineBox, popDirectionalFormatting);
 break;
 case EUnicodeBidi::Isolate:
-exitingContentControlChar = popDirectionalIsolate;
+exitBidiContext(inlineBox, popDirectionalIsolate);
 break;
 case EUnicodeBidi::Plaintext:
-exitingContentControlChar = popDirectionalIsolate;
+exitBidiContext(inlineBox,

[webkit-changes] [285107] trunk/Source

2021-11-01 Thread repstein

Title: [285107] trunk/Source








Revision 285107
Author repst...@apple.com
Date 2021-11-01 08:58:18 -0700 (Mon, 01 Nov 2021)


Log Message
Versioning.

WebKit-7613.1.8

Modified Paths

trunk/Source/_javascript_Core/Configurations/Version.xcconfig
trunk/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig
trunk/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig
trunk/Source/WebCore/Configurations/Version.xcconfig
trunk/Source/WebCore/PAL/Configurations/Version.xcconfig
trunk/Source/WebInspectorUI/Configurations/Version.xcconfig
trunk/Source/WebKit/Configurations/Version.xcconfig
trunk/Source/WebKitLegacy/mac/Configurations/Version.xcconfig




Diff

Modified: trunk/Source/_javascript_Core/Configurations/Version.xcconfig (285106 => 285107)

--- trunk/Source/_javascript_Core/Configurations/Version.xcconfig	2021-11-01 15:55:19 UTC (rev 285106)
+++ trunk/Source/_javascript_Core/Configurations/Version.xcconfig	2021-11-01 15:58:18 UTC (rev 285107)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 613;
 MINOR_VERSION = 1;
-TINY_VERSION = 7;
+TINY_VERSION = 8;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: trunk/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig (285106 => 285107)

--- trunk/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig	2021-11-01 15:55:19 UTC (rev 285106)
+++ trunk/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig	2021-11-01 15:58:18 UTC (rev 285107)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 613;
 MINOR_VERSION = 1;
-TINY_VERSION = 7;
+TINY_VERSION = 8;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: trunk/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (285106 => 285107)

--- trunk/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2021-11-01 15:55:19 UTC (rev 285106)
+++ trunk/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2021-11-01 15:58:18 UTC (rev 285107)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 613;
 MINOR_VERSION = 1;
-TINY_VERSION = 7;
+TINY_VERSION = 8;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: trunk/Source/WebCore/Configurations/Version.xcconfig (285106 => 285107)

--- trunk/Source/WebCore/Configurations/Version.xcconfig	2021-11-01 15:55:19 UTC (rev 285106)
+++ trunk/Source/WebCore/Configurations/Version.xcconfig	2021-11-01 15:58:18 UTC (rev 285107)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 613;
 MINOR_VERSION = 1;
-TINY_VERSION = 7;
+TINY_VERSION = 8;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: trunk/Source/WebCore/PAL/Configurations/Version.xcconfig (285106 => 285107)

--- trunk/Source/WebCore/PAL/Configurations/Version.xcconfig	2021-11-01 15:55:19 UTC (rev 285106)
+++ trunk/Source/WebCore/PAL/Configurations/Version.xcconfig	2021-11-01 15:58:18 UTC (rev 285107)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 613;
 MINOR_VERSION = 1;
-TINY_VERSION = 7;
+TINY_VERSION = 8;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: trunk/Source/WebInspectorUI/Configurations/Version.xcconfig (285106 => 285107)

--- trunk/Source/WebInspectorUI/Configurations/Version.xcconfig	2021-11-01 15:55:19 UTC (rev 285106)
+++ trunk/Source/WebInspectorUI/Configurations/Version.xcconfig	2021-11-01 15:58:18 UTC (rev 285107)
@@ -1,6 +1,6 @@
 MAJOR_VERSION = 613;
 MINOR_VERSION = 1;
-TINY_VERSION = 7;
+TINY_VERSION = 8;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: trunk/Source/WebKit/Configurations/Version.xcconfig (285106 => 285107)

--- trunk/Source/WebKit/Configurations/Version.xcconfig	2021-11-01 15:55:19 UTC (rev 285106)
+++ trunk/Source/WebKit/Configurations/Version.xcconfig	2021-11-01 15:58:18 UTC (rev 285107)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 613;
 MINOR_VERSION = 1;
-TINY_VERSION = 7;
+TINY_VERSION = 8;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: trunk/Source/WebKitLegacy/mac/Configurations/Version.xcconfig (285106 => 285107)

--- trunk/Source/WebKitLegacy/mac/Configurations/Version.xcconfig	2021-11-01 15:55:19 UTC (rev 285106)
+++ trunk/Source/WebKitLegacy/mac/Configurations/Version.xcconfig	2021-11-01 15:58:18 UTC (rev 285107)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 613;
 MINOR_VERSION = 1;
-TINY_VERSION = 7;
+TINY_VERSION = 8;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [285106] trunk/LayoutTests

2021-11-01 Thread cdumez

Title: [285106] trunk/LayoutTests








Revision 285106
Author cdu...@apple.com
Date 2021-11-01 08:55:19 -0700 (Mon, 01 Nov 2021)


Log Message
REGRESSION (r283935): fast/css/style-element-process-crash.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=232456


Reviewed by Wenson Hsieh.

After r283935, focus may happen asynchronously when using autofocus. As a result, we need to
update the test to use waitUntilDone() / notifyDone().

* fast/css/style-element-process-crash.html:
* platform/ios-wk2/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/css/style-element-process-crash.html
trunk/LayoutTests/platform/ios-wk2/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (285105 => 285106)

--- trunk/LayoutTests/ChangeLog	2021-11-01 15:52:33 UTC (rev 285105)
+++ trunk/LayoutTests/ChangeLog	2021-11-01 15:55:19 UTC (rev 285106)
@@ -1,3 +1,17 @@
+2021-11-01  Chris Dumez  
+
+REGRESSION (r283935): fast/css/style-element-process-crash.html is a flaky failure
+https://bugs.webkit.org/show_bug.cgi?id=232456
+
+
+Reviewed by Wenson Hsieh.
+
+After r283935, focus may happen asynchronously when using autofocus. As a result, we need to
+update the test to use waitUntilDone() / notifyDone().
+
+* fast/css/style-element-process-crash.html:
+* platform/ios-wk2/TestExpectations:
+
 2021-10-31  Fujii Hironori  
 
 [WinCairo] Unreviewed test gardening


Modified: trunk/LayoutTests/fast/css/style-element-process-crash.html (285105 => 285106)

--- trunk/LayoutTests/fast/css/style-element-process-crash.html	2021-11-01 15:52:33 UTC (rev 285105)
+++ trunk/LayoutTests/fast/css/style-element-process-crash.html	2021-11-01 15:55:19 UTC (rev 285106)
@@ -1,11 +1,15 @@
 
 
 
-if (window.testRunner)
-	testRunner.dumpAsText();
+if (window.testRunner) {
+testRunner.dumpAsText();
+testRunner.waitUntilDone();
+}
 
 function crash() {
-	document.body.innerHTML = "PASS. WebKit didn't crash.";
+document.body.innerHTML = "PASS. WebKit didn't crash.";
+if (window.testRunner)
+testRunner.notifyDone();
 }
 
 
@@ -13,7 +17,7 @@
 
 
 .abc::first-child { 
-	font: 2147483647 small-caps 3507521020px sans-serif;
+font: 2147483647 small-caps 3507521020px sans-serif;
 }
 
 


Modified: trunk/LayoutTests/platform/ios-wk2/TestExpectations (285105 => 285106)

--- trunk/LayoutTests/platform/ios-wk2/TestExpectations	2021-11-01 15:52:33 UTC (rev 285105)
+++ trunk/LayoutTests/platform/ios-wk2/TestExpectations	2021-11-01 15:55:19 UTC (rev 285106)
@@ -2249,5 +2249,3 @@
 
 webkit.org/b/232337 [ Release ] imported/w3c/web-platform-tests/html/cross-origin-opener-policy/reporting/navigation-reporting/reporting-coop-navigated-opener.https.html [ Pass Failure  DumpJSConsoleLogInStdErr ]
 
-webkit.org/b/232456 fast/css/style-element-process-crash.html [ Pass Failure ]
-






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [285105] branches/safari-613.1.7-branch/

2021-11-01 Thread repstein

Title: [285105] branches/safari-613.1.7-branch/








Revision 285105
Author repst...@apple.com
Date 2021-11-01 08:52:33 -0700 (Mon, 01 Nov 2021)


Log Message
New branch.

Added Paths

branches/safari-613.1.7-branch/




Diff




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [285104] trunk/Source/WebCore

2021-11-01 Thread zalan

Title: [285104] trunk/Source/WebCore








Revision 285104
Author za...@apple.com
Date 2021-11-01 08:40:32 -0700 (Mon, 01 Nov 2021)


Log Message
[LFC][IFC] Introduce paragraph content building to InlineItemsBuilder::handleTextContent
https://bugs.webkit.org/show_bug.cgi?id=232546

Reviewed by Antti Koivisto.

Let's check for directional control characters in text content and build
the paragraph content accordingly. Now that we've got both the inline box and
the text bidi content (atomic inline level boxes are still missing) breakInlineItemsAtBidiBoundaries
can start calling into ubidi to find content boundaries.

* layout/formattingContexts/inline/InlineItemsBuilder.cpp:
(WebCore::Layout::InlineItemsBuilder::handleTextContent):
(WebCore::Layout::InlineItemsBuilder::enterBidiContext):
(WebCore::Layout::InlineItemsBuilder::buildPreviousTextContent):
* layout/formattingContexts/inline/InlineItemsBuilder.h:
* layout/integration/LayoutIntegrationCoverage.cpp:
(WebCore::LayoutIntegration::canUseForFontAndText):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/layout/formattingContexts/inline/InlineItemsBuilder.cpp
trunk/Source/WebCore/layout/formattingContexts/inline/InlineItemsBuilder.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (285103 => 285104)

--- trunk/Source/WebCore/ChangeLog	2021-11-01 14:11:59 UTC (rev 285103)
+++ trunk/Source/WebCore/ChangeLog	2021-11-01 15:40:32 UTC (rev 285104)
@@ -1,3 +1,23 @@
+2021-11-01  Alan Bujtas  
+
+[LFC][IFC] Introduce paragraph content building to InlineItemsBuilder::handleTextContent
+https://bugs.webkit.org/show_bug.cgi?id=232546
+
+Reviewed by Antti Koivisto.
+
+Let's check for directional control characters in text content and build
+the paragraph content accordingly. Now that we've got both the inline box and
+the text bidi content (atomic inline level boxes are still missing) breakInlineItemsAtBidiBoundaries
+can start calling into ubidi to find content boundaries.
+
+* layout/formattingContexts/inline/InlineItemsBuilder.cpp:
+(WebCore::Layout::InlineItemsBuilder::handleTextContent):
+(WebCore::Layout::InlineItemsBuilder::enterBidiContext):
+(WebCore::Layout::InlineItemsBuilder::buildPreviousTextContent):
+* layout/formattingContexts/inline/InlineItemsBuilder.h:
+* layout/integration/LayoutIntegrationCoverage.cpp:
+(WebCore::LayoutIntegration::canUseForFontAndText):
+
 2021-11-01  Daniel Kolesa  
 
 Fix build with GCC 8.4 on Ubuntu 18.04


Modified: trunk/Source/WebCore/layout/formattingContexts/inline/InlineItemsBuilder.cpp (285103 => 285104)

--- trunk/Source/WebCore/layout/formattingContexts/inline/InlineItemsBuilder.cpp	2021-11-01 14:11:59 UTC (rev 285103)
+++ trunk/Source/WebCore/layout/formattingContexts/inline/InlineItemsBuilder.cpp	2021-11-01 15:40:32 UTC (rev 285104)
@@ -33,6 +33,8 @@
 namespace WebCore {
 namespace Layout {
 
+#define ALLOW_BIDI_CONTENT 0
+
 struct WhitespaceContent {
 size_t length { 0 };
 bool isWordSeparator { true };
@@ -139,7 +141,8 @@
 void InlineItemsBuilder::handleTextContent(const InlineTextBox& inlineTextBox, InlineItems& inlineItems)
 {
 auto text = inlineTextBox.content();
-if (!text.length())
+auto contentLength = text.length();
+if (!contentLength)
 return inlineItems.append(InlineTextItem::createEmptyItem(inlineTextBox));
 
 auto& style = inlineTextBox.style();
@@ -158,20 +161,29 @@
 return TextUtil::width(inlineTextBox, fontCascade, startPosition, startPosition + length, { });
 };
 
-while (currentPosition < text.length()) {
-auto isSegmentBreakCandidate = [](auto character) {
-return character == '\n';
+if (!m_paragraphContentBuilder.isEmpty()) {
+m_contentOffsetMap.set(, m_paragraphContentBuilder.length());
+m_paragraphContentBuilder.append(text);
+}
+
+while (currentPosition < contentLength) {
+auto handleSegmentBreak = [&] {
+// Segment breaks with preserve new line style (white-space: pre, pre-wrap, break-spaces and pre-line) compute to forced line break.
+auto isSegmentBreakCandidate = text[currentPosition] == newlineCharacter;
+if (!isSegmentBreakCandidate || !shouldPreserveNewline)
+return false;
+inlineItems.append(InlineSoftLineBreakItem::createSoftLineBreakItem(inlineTextBox, currentPosition++));
+return true;
 };
-
-// Segment breaks with preserve new line style (white-space: pre, pre-wrap, break-spaces and pre-line) compute to forced line break.
-if (isSegmentBreakCandidate(text[currentPosition]) && shouldPreserveNewline) {
-inlineItems.append(InlineSoftLineBreakItem::createSoftLineBreakItem(inlineTextBox, currentPosition));
-++currentPosition;
+if (handleSegmentBreak())
 continue;
-}
 
-auto

[webkit-changes] [285103] trunk/Tools

2021-11-01 Thread aakash_jain

Title: [285103] trunk/Tools








Revision 285103
Author aakash_j...@apple.com
Date 2021-11-01 07:11:59 -0700 (Mon, 01 Nov 2021)


Log Message
Fix a typo in EWS emails

Modified Paths

trunk/Tools/CISupport/ews-build/steps.py
trunk/Tools/CISupport/ews-build/steps_unittest.py
trunk/Tools/ChangeLog




Diff

Modified: trunk/Tools/CISupport/ews-build/steps.py (285102 => 285103)

--- trunk/Tools/CISupport/ews-build/steps.py	2021-11-01 13:17:55 UTC (rev 285102)
+++ trunk/Tools/CISupport/ews-build/steps.py	2021-11-01 14:11:59 UTC (rev 285103)
@@ -1775,7 +1775,7 @@
 if logs:
 logs = logs.replace('&', '').replace('<', '').replace('>', '')
 email_text += '\n\nError lines:\n\n{}'.format(logs)
-email_text += '\n\nTo unsubscrible from these notifications or to provide any feedback please email aakash_j...@apple.com'
+email_text += '\n\nTo unsubscribe from these notifications or to provide any feedback please email aakash_j...@apple.com'
 self._addToLog('stdio', 'Sending email notification to {}'.format(patch_author))
 send_email_to_patch_author(patch_author, email_subject, email_text, patch_id)
 except Exception as e:
@@ -2622,7 +2622,7 @@
 email_text += ' for .'.format(Bugzilla.bug_url(bug_id), bug_id)
 email_text += '\n\nFull details are available at: {}\n\nPatch author: {}'.format(build_url, patch_author)
 email_text += '\n\nLayout test failure{}:\n{}'.format(pluralSuffix, test_names_string)
-email_text += '\n\nTo unsubscrible from these notifications or to provide any feedback please email aakash_j...@apple.com'
+email_text += '\n\nTo unsubscribe from these notifications or to provide any feedback please email aakash_j...@apple.com'
 self._addToLog('stdio', 'Sending email notification to {}'.format(patch_author))
 send_email_to_patch_author(patch_author, email_subject, email_text, patch_id)
 except Exception as e:


Modified: trunk/Tools/CISupport/ews-build/steps_unittest.py (285102 => 285103)

--- trunk/Tools/CISupport/ews-build/steps_unittest.py	2021-11-01 13:17:55 UTC (rev 285102)
+++ trunk/Tools/CISupport/ews-build/steps_unittest.py	2021-11-01 14:11:59 UTC (rev 285103)
@@ -4266,7 +4266,7 @@
 def test_load_contributors_from_disk(self):
 ValidateCommiterAndReviewer._addToLog = lambda cls, logtype, log: sys.stdout.write(log)
 contributors = filter(lambda element: element.get('name') == 'Aakash Jain', ValidateCommiterAndReviewer().load_contributors_from_disk())
-self.assertEqual(list(contributors)[0]['emails'], ['aakash_j...@apple.com'])
+self.assertEqual(list(contributors)[0]['emails'][0], 'aakash_j...@apple.com')
 
 
 class TestCheckPatchStatusOnEWSQueues(BuildStepMixinAdditions, unittest.TestCase):


Modified: trunk/Tools/ChangeLog (285102 => 285103)

--- trunk/Tools/ChangeLog	2021-11-01 13:17:55 UTC (rev 285102)
+++ trunk/Tools/ChangeLog	2021-11-01 14:11:59 UTC (rev 285103)
@@ -1,3 +1,14 @@
+2021-11-01  Aakash Jain  
+
+Fix a typo in EWS emails
+
+Unreviewed minor fix.
+
+* CISupport/ews-build/steps.py:
+(AnalyzeCompileWebKitResults.send_email_for_new_build_failure):
+(AnalyzeLayoutTestsResults.send_email_for_new_test_failures):
+* CISupport/ews-build/steps_unittest.py: Unit-test fix after 243670@main.
+
 2021-10-30  Wenson Hsieh  
 
 Layer tree should not be stuck in frozen state after explicitly stopping a page load






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [285102] trunk/Source/ThirdParty/ANGLE

2021-11-01 Thread ddkilzer

Title: [285102] trunk/Source/ThirdParty/ANGLE








Revision 285102
Author ddkil...@apple.com
Date 2021-11-01 06:17:55 -0700 (Mon, 01 Nov 2021)


Log Message
[ANGLE] Enable -Wformat=2 warnings



Reviewed by Kimmo Kinnunen.

* Configurations/Base.xcconfig:
(WARNING_CFLAGS):
- Add -Wformat=2 switch, which includes -Wformat-nonliteral.
* src/common/angleutils.h:
(FormatStringIntoVector):
- Move below definition of ANGLE_FORMAT_PRINTF() and add macro
  to the function declaration to fix -Wformat-nonliteral
  warning.
* src/compiler/translator/Common.h:
(sh::str):
- Make `formatStr` a constexpr to fix -Wformat-nonliteral
  warning.

Modified Paths

trunk/Source/ThirdParty/ANGLE/ChangeLog
trunk/Source/ThirdParty/ANGLE/Configurations/Base.xcconfig
trunk/Source/ThirdParty/ANGLE/src/common/angleutils.h
trunk/Source/ThirdParty/ANGLE/src/compiler/translator/Common.h




Diff

Modified: trunk/Source/ThirdParty/ANGLE/ChangeLog (285101 => 285102)

--- trunk/Source/ThirdParty/ANGLE/ChangeLog	2021-11-01 08:42:19 UTC (rev 285101)
+++ trunk/Source/ThirdParty/ANGLE/ChangeLog	2021-11-01 13:17:55 UTC (rev 285102)
@@ -1,3 +1,24 @@
+2021-11-01  David Kilzer  
+
+[ANGLE] Enable -Wformat=2 warnings
+
+
+
+Reviewed by Kimmo Kinnunen.
+
+* Configurations/Base.xcconfig:
+(WARNING_CFLAGS):
+- Add -Wformat=2 switch, which includes -Wformat-nonliteral.
+* src/common/angleutils.h:
+(FormatStringIntoVector):
+- Move below definition of ANGLE_FORMAT_PRINTF() and add macro
+  to the function declaration to fix -Wformat-nonliteral
+  warning.
+* src/compiler/translator/Common.h:
+(sh::str):
+- Make `formatStr` a constexpr to fix -Wformat-nonliteral
+  warning.
+
 2021-10-27  Kimmo Kinnunen  
 
 REGRESSION (Safari 15): Poor WebGL performance on https://downloads.scirra.com/labs/particles


Modified: trunk/Source/ThirdParty/ANGLE/Configurations/Base.xcconfig (285101 => 285102)

--- trunk/Source/ThirdParty/ANGLE/Configurations/Base.xcconfig	2021-11-01 08:42:19 UTC (rev 285101)
+++ trunk/Source/ThirdParty/ANGLE/Configurations/Base.xcconfig	2021-11-01 13:17:55 UTC (rev 285102)
@@ -61,7 +61,7 @@
 
 PREBINDING = NO;
 
-WARNING_CFLAGS = -Wglobal-constructors -Wno-inconsistent-missing-override;
+WARNING_CFLAGS = -Wformat=2 -Wglobal-constructors -Wno-inconsistent-missing-override;
 
 SUPPORTED_PLATFORMS = iphoneos iphonesimulator macosx appletvos appletvsimulator watchos watchsimulator;
 SUPPORTS_MACCATALYST = YES;


Modified: trunk/Source/ThirdParty/ANGLE/src/common/angleutils.h (285101 => 285102)

--- trunk/Source/ThirdParty/ANGLE/src/common/angleutils.h	2021-11-01 08:42:19 UTC (rev 285101)
+++ trunk/Source/ThirdParty/ANGLE/src/common/angleutils.h	2021-11-01 13:17:55 UTC (rev 285102)
@@ -186,8 +186,6 @@
 return strstr.str();
 }
 
-size_t FormatStringIntoVector(const char *fmt, va_list vararg, std::vector );
-
 template 
 std::string ToString(const T )
 {
@@ -372,4 +370,6 @@
 #define ANGLE_REQUIRE_CONSTANT_INIT
 #endif  // __has_cpp_attribute(require_constant_initialization)
 
+size_t FormatStringIntoVector(const char *fmt, va_list vararg, std::vector ) ANGLE_FORMAT_PRINTF(1, 0);
+
 #endif  // COMMON_ANGLEUTILS_H_


Modified: trunk/Source/ThirdParty/ANGLE/src/compiler/translator/Common.h (285101 => 285102)

--- trunk/Source/ThirdParty/ANGLE/src/compiler/translator/Common.h	2021-11-01 08:42:19 UTC (rev 285101)
+++ trunk/Source/ThirdParty/ANGLE/src/compiler/translator/Common.h	2021-11-01 13:17:55 UTC (rev 285102)
@@ -215,7 +215,7 @@
 {
 ASSERT(std::numeric_limits::is_integer);
 char buffer[((8 * sizeof(T)) / 3) + 3];
-const char *formatStr = std::numeric_limits::is_signed ? "%d" : "%u";
+constexpr const char *formatStr = std::numeric_limits::is_signed ? "%d" : "%u";
 snprintf(buffer, sizeof(buffer), formatStr, i);
 return buffer;
 }






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [285101] trunk/Source

2021-11-01 Thread commit-queue

Title: [285101] trunk/Source








Revision 285101
Author commit-qu...@webkit.org
Date 2021-11-01 01:42:19 -0700 (Mon, 01 Nov 2021)


Log Message
Fix build with GCC 8.4 on Ubuntu 18.04
https://bugs.webkit.org/show_bug.cgi?id=232305

Patch by Daniel Kolesa  on 2021-11-01
Reviewed by Adrian Perez de Castro.

Source/WebCore:

Fix build with GCC 8.4 on Ubuntu 18.04

Thes sections of the code trigger an internal compiler error with
GCC 8.4, segfaulting the compiler. This adds a workaround that
makes it work again.

* Modules/async-clipboard/ClipboardItemBindingsDataSource.cpp:
(WebCore::ClipboardItemBindingsDataSource::collectDataForWriting):

Source/WebKit:

Thes sections of the code trigger an internal compiler error with
GCC 8.4, segfaulting the compiler. This adds a workaround that
makes it work again.

* NetworkProcess/NetworkProcess.cpp:
(WebKit::NetworkProcess::deleteAndRestrictWebsiteDataForRegistrableDomains):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/async-clipboard/ClipboardItemBindingsDataSource.cpp
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/NetworkProcess/NetworkProcess.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (285100 => 285101)

--- trunk/Source/WebCore/ChangeLog	2021-11-01 06:20:41 UTC (rev 285100)
+++ trunk/Source/WebCore/ChangeLog	2021-11-01 08:42:19 UTC (rev 285101)
@@ -1,3 +1,19 @@
+2021-11-01  Daniel Kolesa  
+
+Fix build with GCC 8.4 on Ubuntu 18.04
+https://bugs.webkit.org/show_bug.cgi?id=232305
+
+Reviewed by Adrian Perez de Castro.
+
+Fix build with GCC 8.4 on Ubuntu 18.04
+
+Thes sections of the code trigger an internal compiler error with
+GCC 8.4, segfaulting the compiler. This adds a workaround that
+makes it work again.
+
+* Modules/async-clipboard/ClipboardItemBindingsDataSource.cpp:
+(WebCore::ClipboardItemBindingsDataSource::collectDataForWriting):
+
 2021-10-31  Antti Koivisto  
 
 Fix :host invalidation when combined with pseudo classes in descendant position


Modified: trunk/Source/WebCore/Modules/async-clipboard/ClipboardItemBindingsDataSource.cpp (285100 => 285101)

--- trunk/Source/WebCore/Modules/async-clipboard/ClipboardItemBindingsDataSource.cpp	2021-11-01 06:20:41 UTC (rev 285100)
+++ trunk/Source/WebCore/Modules/async-clipboard/ClipboardItemBindingsDataSource.cpp	2021-11-01 08:42:19 UTC (rev 285101)
@@ -139,7 +139,9 @@
 });
 
 auto promise = typeAndItem.value;
-promise->whenSettled([this, protectedItem = Ref { m_item }, destination = m_writingDestination, promise, type, weakItemTypeLoader = WeakPtr { itemTypeLoader }] () mutable {
+/* hack: gcc 8.4 will segfault if the WeakPtr is instantiated within the lambda captures */
+auto wl = WeakPtr { itemTypeLoader };
+promise->whenSettled([this, protectedItem = Ref { m_item }, destination = m_writingDestination, promise, type, weakItemTypeLoader = WTFMove(wl)] () mutable {
 if (!weakItemTypeLoader)
 return;
 


Modified: trunk/Source/WebKit/ChangeLog (285100 => 285101)

--- trunk/Source/WebKit/ChangeLog	2021-11-01 06:20:41 UTC (rev 285100)
+++ trunk/Source/WebKit/ChangeLog	2021-11-01 08:42:19 UTC (rev 285101)
@@ -1,3 +1,17 @@
+2021-11-01  Daniel Kolesa  
+
+Fix build with GCC 8.4 on Ubuntu 18.04
+https://bugs.webkit.org/show_bug.cgi?id=232305
+
+Reviewed by Adrian Perez de Castro.
+
+Thes sections of the code trigger an internal compiler error with
+GCC 8.4, segfaulting the compiler. This adds a workaround that
+makes it work again.
+
+* NetworkProcess/NetworkProcess.cpp:
+(WebKit::NetworkProcess::deleteAndRestrictWebsiteDataForRegistrableDomains):
+
 2021-10-31  Fujii Hironori  
 
 [WinCairo] New GraphicsLayer for GPU process mode


Modified: trunk/Source/WebKit/NetworkProcess/NetworkProcess.cpp (285100 => 285101)

--- trunk/Source/WebKit/NetworkProcess/NetworkProcess.cpp	2021-11-01 06:20:41 UTC (rev 285100)
+++ trunk/Source/WebKit/NetworkProcess/NetworkProcess.cpp	2021-11-01 08:42:19 UTC (rev 285101)
@@ -1940,7 +1940,9 @@
 
 if (websiteDataTypes.contains(WebsiteDataType::DiskCache)) {
 forEachNetworkSession([sessionID, fetchOptions, , ](auto& session) {
-fetchDiskCacheEntries(session.cache(), sessionID, fetchOptions, [domainsToDeleteAllNonCookieWebsiteDataFor, callbackAggregator, session = WeakPtr { session }](auto entries) mutable {
+/* hack: gcc 8.4 will segfault if the WeakPtr is instantiated within the lambda captures */
+auto ws = WeakPtr { session };
+fetchDiskCacheEntries(session.cache(), sessionID, fetchOptions, [domainsToDeleteAllNonCookieWebsiteDataFor, callbackAggregator, session = WTFMove(ws)](auto entries) mutable {
 if (!session)
 return;
 






___
webkit-changes mailing list

[webkit-changes] [285100] trunk

2021-11-01 Thread antti

Title: [285100] trunk








Revision 285100
Author an...@apple.com
Date 2021-10-31 23:20:41 -0700 (Sun, 31 Oct 2021)


Log Message
Fix :host invalidation when combined with pseudo classes in descendant position
https://bugs.webkit.org/show_bug.cgi?id=232544

Reviewed by Simon Fraser.

LayoutTests/imported/w3c:

* web-platform-tests/css/css-scoping/host-functional-descendant-invalidation-expected.txt:

Source/WebCore:

* style/RuleSet.cpp:
(WebCore::Style::isHostSelectorMatchingInShadowTree):

Make more readable and accurate.

(WebCore::Style::RuleSet::addRule):

Compute m_hasHostPseudoClassRulesMatchingInShadowTree before bailing out for pseudo elements.

Modified Paths

trunk/LayoutTests/imported/w3c/ChangeLog
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-scoping/host-functional-descendant-invalidation-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/style/RuleSet.cpp




Diff

Modified: trunk/LayoutTests/imported/w3c/ChangeLog (285099 => 285100)

--- trunk/LayoutTests/imported/w3c/ChangeLog	2021-11-01 00:56:28 UTC (rev 285099)
+++ trunk/LayoutTests/imported/w3c/ChangeLog	2021-11-01 06:20:41 UTC (rev 285100)
@@ -1,3 +1,12 @@
+2021-10-31  Antti Koivisto  
+
+Fix :host invalidation when combined with pseudo classes in descendant position
+https://bugs.webkit.org/show_bug.cgi?id=232544
+
+Reviewed by Simon Fraser.
+
+* web-platform-tests/css/css-scoping/host-functional-descendant-invalidation-expected.txt:
+
 2021-10-30  Brandon Stewart  
 
 Selection extend() should trigger exception with no ranges


Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-scoping/host-functional-descendant-invalidation-expected.txt (285099 => 285100)

--- trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-scoping/host-functional-descendant-invalidation-expected.txt	2021-11-01 00:56:28 UTC (rev 285099)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-scoping/host-functional-descendant-invalidation-expected.txt	2021-11-01 06:20:41 UTC (rev 285100)
@@ -1,3 +1,3 @@
 
-FAIL CSS Test: element style is correctly updated for rule with :host(..) assert_equals: expected "rgb(0, 128, 0)" but got "rgb(255, 0, 0)"
+PASS CSS Test: element style is correctly updated for rule with :host(..)
 


Modified: trunk/Source/WebCore/ChangeLog (285099 => 285100)

--- trunk/Source/WebCore/ChangeLog	2021-11-01 00:56:28 UTC (rev 285099)
+++ trunk/Source/WebCore/ChangeLog	2021-11-01 06:20:41 UTC (rev 285100)
@@ -1,3 +1,19 @@
+2021-10-31  Antti Koivisto  
+
+Fix :host invalidation when combined with pseudo classes in descendant position
+https://bugs.webkit.org/show_bug.cgi?id=232544
+
+Reviewed by Simon Fraser.
+
+* style/RuleSet.cpp:
+(WebCore::Style::isHostSelectorMatchingInShadowTree):
+
+Make more readable and accurate.
+
+(WebCore::Style::RuleSet::addRule):
+
+Compute m_hasHostPseudoClassRulesMatchingInShadowTree before bailing out for pseudo elements.
+
 2021-10-31  Fujii Hironori  
 
 [WinCairo] New GraphicsLayer for GPU process mode


Modified: trunk/Source/WebCore/style/RuleSet.cpp (285099 => 285100)

--- trunk/Source/WebCore/style/RuleSet.cpp	2021-11-01 00:56:28 UTC (rev 285099)
+++ trunk/Source/WebCore/style/RuleSet.cpp	2021-11-01 06:20:41 UTC (rev 285100)
@@ -71,16 +71,17 @@
 
 static bool isHostSelectorMatchingInShadowTree(const CSSSelector& startSelector)
 {
-auto* leftmostSelector = 
-bool hasDescendantOrChildRelation = false;
-while (auto* previous = leftmostSelector->tagHistory()) {
-hasDescendantOrChildRelation = leftmostSelector->hasDescendantOrChildRelation();
-leftmostSelector = previous;
+bool hasOnlyOneCompound = true;
+bool hasHostInLastCompound = false;
+for (auto* selector =  selector; selector = selector->tagHistory()) {
+if (selector->match() == CSSSelector::PseudoClass && selector->pseudoClassType() == CSSSelector::PseudoClassHost)
+hasHostInLastCompound = true;
+if (selector->tagHistory() && selector->relation() != CSSSelector::Subselector) {
+hasOnlyOneCompound = false;
+hasHostInLastCompound = false;
+}
 }
-if (!hasDescendantOrChildRelation)
-return false;
-
-return leftmostSelector->match() == CSSSelector::PseudoClass && leftmostSelector->pseudoClassType() == CSSSelector::PseudoClassHost;
+return !hasOnlyOneCompound && hasHostInLastCompound;
 }
 
 void RuleSet::addRule(const StyleRule& rule, unsigned selectorIndex, unsigned selectorListIndex)
@@ -197,6 +198,9 @@
 selector = selector->tagHistory();
 } while (selector);
 
+if (!m_hasHostPseudoClassRulesMatchingInShadowTree)
+m_hasHostPseudoClassRulesMatchingInShadowTree = isHostSelectorMatchingInShadowTree(*ruleData.selector());
+
 #if ENABLE(VIDEO)
 if (cuePseudoElementSelector) {
 m_cuePseudoRules.append(ruleData);
@@ -233,9 +237,6 @@

53 matches

Mail list logo