[webkit-changes] [285918] trunk
Title: [285918] trunk Revision 285918 Author commit-qu...@webkit.org Date 2021-11-16 23:54:59 -0800 (Tue, 16 Nov 2021) Log Message Re-add 'style' to contain:strict and contain:content CSS properties https://bugs.webkit.org/show_bug.cgi?id=233193 Patch by Rob Buis on 2021-11-16 Reviewed by Brent Fulgham. LayoutTests/imported/w3c: Now contain-computed-expected.txt is all PASS. * web-platform-tests/css/css-contain/parsing/contain-computed-expected.txt: Source/WebCore: After being removed for a while, style containment is part again of contain:strict and contain: content [1, 2]. The change was done in chromium and Firefox has verbally agreed to make the change as well [3]. [1] https://github.com/w3c/csswg-drafts/issues/6287#issuecomment-862525199 [2] https://github.com/w3c/csswg-drafts/commit/7948feb03a9aaceb3a8ee423b07c6e526024cdc2 [3] https://groups.google.com/a/chromium.org/g/blink-dev/c/oMVBKemrTDQ?pli=1 * rendering/style/RenderStyle.h: (WebCore::RenderStyle::strictContainment): (WebCore::RenderStyle::contentContainment): LayoutTests: * TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/TestExpectations trunk/LayoutTests/imported/w3c/ChangeLog trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-contain/parsing/contain-computed-expected.txt trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/rendering/style/RenderStyle.h Diff Modified: trunk/LayoutTests/ChangeLog (285917 => 285918) --- trunk/LayoutTests/ChangeLog 2021-11-17 06:25:17 UTC (rev 285917) +++ trunk/LayoutTests/ChangeLog 2021-11-17 07:54:59 UTC (rev 285918) @@ -1,3 +1,12 @@ +2021-11-16 Rob Buis + +Re-add 'style' to contain:strict and contain:content CSS properties +https://bugs.webkit.org/show_bug.cgi?id=233193 + +Reviewed by Brent Fulgham. + +* TestExpectations: + 2021-11-16 Simon Fraser Stop a momentum scroll animation when receiving a momentum end event Modified: trunk/LayoutTests/TestExpectations (285917 => 285918) --- trunk/LayoutTests/TestExpectations 2021-11-17 06:25:17 UTC (rev 285917) +++ trunk/LayoutTests/TestExpectations 2021-11-17 07:54:59 UTC (rev 285918) @@ -4796,7 +4796,6 @@ imported/w3c/web-platform-tests/css/css-contain/contain-body-w-m-002.html [ ImageOnlyFailure ] imported/w3c/web-platform-tests/css/css-contain/contain-body-w-m-003.html [ ImageOnlyFailure ] imported/w3c/web-platform-tests/css/css-contain/contain-body-w-m-004.html [ ImageOnlyFailure ] -imported/w3c/web-platform-tests/css/css-contain/contain-content-011.html [ ImageOnlyFailure ] imported/w3c/web-platform-tests/css/css-contain/contain-html-bg-001.html [ ImageOnlyFailure ] imported/w3c/web-platform-tests/css/css-contain/contain-html-bg-002.html [ ImageOnlyFailure ] imported/w3c/web-platform-tests/css/css-contain/contain-html-bg-003.html [ ImageOnlyFailure ] Modified: trunk/LayoutTests/imported/w3c/ChangeLog (285917 => 285918) --- trunk/LayoutTests/imported/w3c/ChangeLog 2021-11-17 06:25:17 UTC (rev 285917) +++ trunk/LayoutTests/imported/w3c/ChangeLog 2021-11-17 07:54:59 UTC (rev 285918) @@ -1,3 +1,14 @@ +2021-11-16 Rob Buis + +Re-add 'style' to contain:strict and contain:content CSS properties +https://bugs.webkit.org/show_bug.cgi?id=233193 + +Reviewed by Brent Fulgham. + +Now contain-computed-expected.txt is all PASS. + +* web-platform-tests/css/css-contain/parsing/contain-computed-expected.txt: + 2021-11-16 Joonghun Park border-radius inline style should serialize with valid syntax Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-contain/parsing/contain-computed-expected.txt (285917 => 285918) --- trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-contain/parsing/contain-computed-expected.txt 2021-11-17 06:25:17 UTC (rev 285917) +++ trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-contain/parsing/contain-computed-expected.txt 2021-11-17 07:54:59 UTC (rev 285918) @@ -8,8 +8,8 @@ PASS Property contain value 'paint' PASS Property contain value 'size layout' PASS Property contain value 'style paint' -FAIL Property contain value 'style layout paint' assert_equals: expected "content" but got "layout style paint" -FAIL Property contain value 'size style layout paint' assert_equals: expected "strict" but got "size layout style paint" -FAIL Property contain value 'size layout paint' assert_equals: expected "size layout paint" but got "strict" -FAIL Property contain value 'layout paint' assert_equals: expected "layout paint" but got "content" +PASS Property contain value 'style layout paint' +PASS Property contain value 'size style layout paint' +PASS Property contain value 'size layout paint' +PASS Property contain value 'layout paint' Modified: trunk/Source/WebCore/ChangeLog (285917 => 285918) --- trunk/Source/WebCore/ChangeLog 2021-11-17 06:25:17 UTC (rev 285917) +++ trunk/Source/WebCore/ChangeLog 2021-11-17 07:54:59 UTC (rev 285918) @@ -1,3
[webkit-changes] [285917] trunk
Title: [285917] trunk
Revision 285917
Author simon.fra...@apple.com
Date 2021-11-16 22:25:17 -0800 (Tue, 16 Nov 2021)
Log Message
Stop a momentum scroll animation when receiving a momentum end event
https://bugs.webkit.org/show_bug.cgi?id=233236
Reviewed by Tim Horton.
Source/WebCore:
The stream of momentum events is terminated by an "end" event under two circumstances:
1. The gesture finished naturally without interruption.
2. The user tapped the trackpad with two fingers.
Unfortunately we can't tell these apart, so we always have to stop the animation.
Sadly this reveals a hole in the testing infrastructure. All the "changed" momentum
events in the sequence handed to UIHelper.mouseWheelSequence() are ignored while the
animation is running, but the "ended" event stops the animation. So any test without
a reasonable number of "changed" events will terminate its animation prematurely.
We can't fix this without new testing infrastructure (webkit.org/b/233234).
Test: fast/scrolling/mac/momentum-animator-end-event-stops.html
* platform/ScrollingEffectsController.h:
* platform/mac/ScrollingEffectsController.mm:
(WebCore::ScrollingEffectsController::handleWheelEvent):
LayoutTests:
New test, and skip one that breaks now because we need a fix for webkit.org/b/233234.
* fast/scrolling/mac/momentum-animator-end-event-stops-expected.txt: Added.
* fast/scrolling/mac/momentum-animator-end-event-stops.html: Added.
* platform/mac-wk2/TestExpectations:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac-wk2/TestExpectations
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/ScrollingEffectsController.h
trunk/Source/WebCore/platform/mac/ScrollingEffectsController.mm
Added Paths
trunk/LayoutTests/fast/scrolling/mac/momentum-animator-end-event-stops-expected.txt
trunk/LayoutTests/fast/scrolling/mac/momentum-animator-end-event-stops.html
Diff
Modified: trunk/LayoutTests/ChangeLog (285916 => 285917)
--- trunk/LayoutTests/ChangeLog 2021-11-17 06:24:11 UTC (rev 285916)
+++ trunk/LayoutTests/ChangeLog 2021-11-17 06:25:17 UTC (rev 285917)
@@ -1,3 +1,16 @@
+2021-11-16 Simon Fraser
+
+Stop a momentum scroll animation when receiving a momentum end event
+https://bugs.webkit.org/show_bug.cgi?id=233236
+
+Reviewed by Tim Horton.
+
+New test, and skip one that breaks now because we need a fix for webkit.org/b/233234.
+
+* fast/scrolling/mac/momentum-animator-end-event-stops-expected.txt: Added.
+* fast/scrolling/mac/momentum-animator-end-event-stops.html: Added.
+* platform/mac-wk2/TestExpectations:
+
2021-11-16 Sihui Liu
Implement FileSystemFileHandle.getFile()
Added: trunk/LayoutTests/fast/scrolling/mac/momentum-animator-end-event-stops-expected.txt (0 => 285917)
--- trunk/LayoutTests/fast/scrolling/mac/momentum-animator-end-event-stops-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/scrolling/mac/momentum-animator-end-event-stops-expected.txt 2021-11-17 06:25:17 UTC (rev 285917)
@@ -0,0 +1,7 @@
+Momentum event reached main thread
+PASS scrollEventCount > 0 is true
+PASS scrollEventCount is scrollEventCountAtMomentumEnded
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
Added: trunk/LayoutTests/fast/scrolling/mac/momentum-animator-end-event-stops.html (0 => 285917)
--- trunk/LayoutTests/fast/scrolling/mac/momentum-animator-end-event-stops.html (rev 0)
+++ trunk/LayoutTests/fast/scrolling/mac/momentum-animator-end-event-stops.html 2021-11-17 06:25:17 UTC (rev 285917)
@@ -0,0 +1,119 @@
+
+
+
+
+body {
+height: 2000px;
+width: 200%;
+}
+
+
+var jsTestIsAsync = true;
+
+let sawMomentumEvent = false;
+let sawFingersDown = false;
+let scrollEventCount = 0;
+let scrollEventCountAtMomentumEnded = 0;
+
+async function testEventSequence()
+{
+const events = [
+{
+type : "wheel",
+viewX : 100,
+viewY : 100,
+deltaY : -10, // Note that this delta is currently ignored.
+phase : "began"
+},
+{
+type : "wheel",
+deltaY : -50,
+phase : "changed"
+},
+{
+type : "wheel",
+phase : "ended"
+},
+{
+type : "wheel",
+deltaY : -60,
+momentumPhase : "began"
+},
+{
+type: "wheel",
+viewX : 101, // defeat coalescing
+deltaY : -99,
+momentumPhase: "changed"
+},
+{
+type: "wheel",
+viewX :
[webkit-changes] [285916] trunk/Source/WebCore
Title: [285916] trunk/Source/WebCore Revision 285916 Author s...@apple.com Date 2021-11-16 22:24:11 -0800 (Tue, 16 Nov 2021) Log Message [GPU Process] Build a postfix _expression_ for applying the FilterEffects of the SVGFilter https://bugs.webkit.org/show_bug.cgi?id=233214 Reviewed by Cameron McCormack. The goal of building this _expression_ is to have all inputs of each FilterEffect be applied before applying it. This will eliminate the need to do recursive applying in FilterEffect::apply(). And it will also eliminate the need to store the rectangle of the result of FilterEffect. Once the absolutePaintRect is calculated, the result image can be created. Filter::apply() and FilterEffect::apply() should return a boolean so the caller knows that applying the filter function was not successful. * WebCore.xcodeproj/project.pbxproj: * platform/graphics/cpu/arm/filters/FEBlendNEON.h: (WebCore::FEBlend::platformApplySoftware): * platform/graphics/filters/FEBlend.cpp: (WebCore::FEBlend::platformApplySoftware): * platform/graphics/filters/FEBlend.h: * platform/graphics/filters/FEColorMatrix.cpp: (WebCore::FEColorMatrix::platformApplySoftware): * platform/graphics/filters/FEColorMatrix.h: * platform/graphics/filters/FEComponentTransfer.cpp: (WebCore::FEComponentTransfer::platformApplySoftware): * platform/graphics/filters/FEComponentTransfer.h: * platform/graphics/filters/FEComposite.cpp: (WebCore::FEComposite::platformApplySoftware): * platform/graphics/filters/FEComposite.h: * platform/graphics/filters/FEConvolveMatrix.cpp: (WebCore::FEConvolveMatrix::platformApplySoftware): * platform/graphics/filters/FEConvolveMatrix.h: * platform/graphics/filters/FEDisplacementMap.cpp: (WebCore::FEDisplacementMap::platformApplySoftware): * platform/graphics/filters/FEDisplacementMap.h: * platform/graphics/filters/FEDropShadow.cpp: (WebCore::FEDropShadow::platformApplySoftware): * platform/graphics/filters/FEDropShadow.h: * platform/graphics/filters/FEFlood.cpp: (WebCore::FEFlood::platformApplySoftware): * platform/graphics/filters/FEFlood.h: * platform/graphics/filters/FEGaussianBlur.cpp: (WebCore::FEGaussianBlur::platformApplySoftware): * platform/graphics/filters/FEGaussianBlur.h: * platform/graphics/filters/FELighting.cpp: (WebCore::FELighting::platformApplySoftware): * platform/graphics/filters/FELighting.h: * platform/graphics/filters/FEMerge.cpp: (WebCore::FEMerge::platformApplySoftware): * platform/graphics/filters/FEMerge.h: * platform/graphics/filters/FEMorphology.cpp: (WebCore::FEMorphology::platformApplySoftware): * platform/graphics/filters/FEMorphology.h: * platform/graphics/filters/FEOffset.cpp: (WebCore::FEOffset::platformApplySoftware): * platform/graphics/filters/FEOffset.h: * platform/graphics/filters/FETile.cpp: (WebCore::FETile::platformApplySoftware): * platform/graphics/filters/FETile.h: * platform/graphics/filters/FETurbulence.cpp: (WebCore::FETurbulence::platformApplySoftware): * platform/graphics/filters/FETurbulence.h: * platform/graphics/filters/Filter.h: * platform/graphics/filters/FilterEffect.cpp: (WebCore::FilterEffect::apply): * platform/graphics/filters/FilterEffect.h: * platform/graphics/filters/FilterEffectVector.h: Added. * platform/graphics/filters/FilterFunction.h: (WebCore::FilterFunction::apply): * platform/graphics/filters/SourceAlpha.cpp: (WebCore::SourceAlpha::platformApplySoftware): * platform/graphics/filters/SourceAlpha.h: * platform/graphics/filters/SourceGraphic.cpp: (WebCore::SourceGraphic::platformApplySoftware): * platform/graphics/filters/SourceGraphic.h: * rendering/CSSFilter.cpp: (WebCore::CSSFilter::apply): * rendering/CSSFilter.h: * svg/graphics/filters/SVGFEImage.cpp: (WebCore::FEImage::platformApplySoftware): * svg/graphics/filters/SVGFEImage.h: * svg/graphics/filters/SVGFilter.cpp: (WebCore::SVGFilter::create): (WebCore::SVGFilter::apply): (WebCore::SVGFilter::outsets const): (WebCore::SVGFilter::clearResult): * svg/graphics/filters/SVGFilter.h: * svg/graphics/filters/SVGFilterBuilder.cpp: (WebCore::buildEffectExpression): (WebCore::SVGFilterBuilder::buildExpression const): * svg/graphics/filters/SVGFilterBuilder.h: Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj trunk/Source/WebCore/platform/graphics/cpu/arm/filters/FEBlendNEON.h trunk/Source/WebCore/platform/graphics/filters/FEBlend.cpp trunk/Source/WebCore/platform/graphics/filters/FEBlend.h trunk/Source/WebCore/platform/graphics/filters/FEColorMatrix.cpp trunk/Source/WebCore/platform/graphics/filters/FEColorMatrix.h trunk/Source/WebCore/platform/graphics/filters/FEComponentTransfer.cpp trunk/Source/WebCore/platform/graphics/filters/FEComponentTransfer.h trunk/Source/WebCore/platform/graphics/filters/FEComposite.cpp trunk/Source/WebCore/platform/graphics/filters/FEComposite.h trunk/Source/WebCore/platform/graphics/filters/FEConvolveMatrix.cpp trunk/Source/WebCore/platform/graphics/filters/FEConvolveMatrix.h
[webkit-changes] [285915] trunk
Title: [285915] trunk Revision 285915 Author jh718.p...@samsung.com Date 2021-11-16 21:53:07 -0800 (Tue, 16 Nov 2021) Log Message border-radius inline style should serialize with valid syntax https://bugs.webkit.org/show_bug.cgi?id=183994 This patch have border-radius property serializes in canonical order as specified in https://drafts.csswg.org/css-backgrounds/#border-radius. Reviewed by Darin Adler. LayoutTests/imported/w3c: * web-platform-tests/css/css-backgrounds/parsing/border-radius-valid-expected.txt: Add css wide keywords test case results. * web-platform-tests/css/css-backgrounds/parsing/border-radius-valid.html: Add css wide keywords test cases. Source/WebCore: * css/StyleProperties.cpp: (WebCore::StyleProperties::getPropertyValue const): (WebCore::StyleProperties::borderRadiusValue const): * css/StyleProperties.h: Modified Paths trunk/LayoutTests/imported/w3c/ChangeLog trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-backgrounds/parsing/border-radius-valid-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-backgrounds/parsing/border-radius-valid.html trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/css/StyleProperties.cpp trunk/Source/WebCore/css/StyleProperties.h Diff Modified: trunk/LayoutTests/imported/w3c/ChangeLog (285914 => 285915) --- trunk/LayoutTests/imported/w3c/ChangeLog 2021-11-17 04:27:08 UTC (rev 285914) +++ trunk/LayoutTests/imported/w3c/ChangeLog 2021-11-17 05:53:07 UTC (rev 285915) @@ -1,3 +1,16 @@ +2021-11-16 Joonghun Park + +border-radius inline style should serialize with valid syntax +https://bugs.webkit.org/show_bug.cgi?id=183994 + +This patch have border-radius property serializes in canonical order +as specified in https://drafts.csswg.org/css-backgrounds/#border-radius. + +Reviewed by Darin Adler. + +* web-platform-tests/css/css-backgrounds/parsing/border-radius-valid-expected.txt: Add css wide keywords test case results. +* web-platform-tests/css/css-backgrounds/parsing/border-radius-valid.html: Add css wide keywords test cases. + 2021-11-16 Sihui Liu Implement FileSystemFileHandle.getFile() Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-backgrounds/parsing/border-radius-valid-expected.txt (285914 => 285915) --- trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-backgrounds/parsing/border-radius-valid-expected.txt 2021-11-17 04:27:08 UTC (rev 285914) +++ trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-backgrounds/parsing/border-radius-valid-expected.txt 2021-11-17 05:53:07 UTC (rev 285915) @@ -1,19 +1,23 @@ +PASS e.style['border-radius'] = "initial" should set the property value +PASS e.style['border-radius'] = "inherit" should set the property value +PASS e.style['border-radius'] = "unset" should set the property value +PASS e.style['border-radius'] = "revert" should set the property value PASS e.style['border-radius'] = "1px" should set the property value PASS e.style['border-radius'] = "1px 5%" should set the property value PASS e.style['border-radius'] = "1px 2% 3px" should set the property value PASS e.style['border-radius'] = "1px 2% 3px 4%" should set the property value -FAIL e.style['border-radius'] = "1px / 2px" should set the property value assert_equals: serialization should be canonical expected "1px / 2px" but got "1px 2px" -FAIL e.style['border-radius'] = "5em / 1px 2% 3px 4%" should set the property value assert_equals: serialization should be canonical expected "5em / 1px 2% 3px 4%" but got "5em 1px 5em 2% 5em 3px 5em 4%" -FAIL e.style['border-radius'] = "1px 2% / 3px 4px" should set the property value assert_equals: serialization should be canonical expected "1px 2% / 3px 4px" but got "1px 3px 2% 4px" -FAIL e.style['border-radius'] = "1px 2px 3em / 1px 2px 3%" should set the property value assert_equals: serialization should be canonical expected "1px 2px 3em / 1px 2px 3%" but got "1px 2px 3em 3%" -FAIL e.style['border-radius'] = "1px 2% / 2px 3em 4px 5em" should set the property value assert_equals: serialization should be canonical expected "1px 2% / 2px 3em 4px 5em" but got "1px 2px 2% 3em 1px 4px 2% 5em" -FAIL e.style['border-radius'] = "1px 2% 3px 4% / 5em" should set the property value assert_equals: serialization should be canonical expected "1px 2% 3px 4% / 5em" but got "1px 5em 2% 5em 3px 5em 4% 5em" -FAIL e.style['border-radius'] = "1px 1px 1px 2% / 1px 2% 1px 2%" should set the property value assert_equals: serialization should be canonical expected "1px 1px 1px 2% / 1px 2%" but got "1px 1px 2% 1px 2%" -FAIL e.style['border-radius'] = "1px 1px 1px 1px / 1px 1px 2% 1px" should set the property value assert_equals: serialization should be canonical expected "1px / 1px 1px 2%" but got "1px 1px 1px 2%" +PASS e.style['border-radius'] = "1px / 2px" should set the property value +PASS e.style['border-radius'] = "5em / 1px 2% 3px 4%" should set the property value +PASS
[webkit-changes] [285914] trunk/Source/WebKit
Title: [285914] trunk/Source/WebKit
Revision 285914
Author ross.kirsl...@sony.com
Date 2021-11-16 20:27:08 -0800 (Tue, 16 Nov 2021)
Log Message
Unreviewed, fix WinCairo build following r285881.
* CMakeLists.txt:
* WebProcess/GPU/graphics/WebGPU/RemoteDeviceProxy.h:
* WebProcess/GPU/graphics/WebGPU/RemoteTextureProxy.h:
Modified Paths
trunk/Source/WebKit/CMakeLists.txt
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemoteDeviceProxy.h
trunk/Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemoteTextureProxy.h
Diff
Modified: trunk/Source/WebKit/CMakeLists.txt (285913 => 285914)
--- trunk/Source/WebKit/CMakeLists.txt 2021-11-17 03:14:06 UTC (rev 285913)
+++ trunk/Source/WebKit/CMakeLists.txt 2021-11-17 04:27:08 UTC (rev 285914)
@@ -50,6 +50,7 @@
"${WEBKIT_DIR}/Shared/Plugins/Netscape"
"${WEBKIT_DIR}/Shared/Plugins/Netscape/x11"
"${WEBKIT_DIR}/Shared/RemoteLayerTree"
+"${WEBKIT_DIR}/Shared/WebGPU"
"${WEBKIT_DIR}/Shared/WebsiteData"
"${WEBKIT_DIR}/Shared/XR"
"${WEBKIT_DIR}/UIProcess"
Modified: trunk/Source/WebKit/ChangeLog (285913 => 285914)
--- trunk/Source/WebKit/ChangeLog 2021-11-17 03:14:06 UTC (rev 285913)
+++ trunk/Source/WebKit/ChangeLog 2021-11-17 04:27:08 UTC (rev 285914)
@@ -1,3 +1,11 @@
+2021-11-16 Ross Kirsling
+
+Unreviewed, fix WinCairo build following r285881.
+
+* CMakeLists.txt:
+* WebProcess/GPU/graphics/WebGPU/RemoteDeviceProxy.h:
+* WebProcess/GPU/graphics/WebGPU/RemoteTextureProxy.h:
+
2021-11-16 Sihui Liu
Implement FileSystemFileHandle.getFile()
Modified: trunk/Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemoteDeviceProxy.h (285913 => 285914)
--- trunk/Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemoteDeviceProxy.h 2021-11-17 03:14:06 UTC (rev 285913)
+++ trunk/Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemoteDeviceProxy.h 2021-11-17 04:27:08 UTC (rev 285914)
@@ -28,6 +28,7 @@
#if ENABLE(GPU_PROCESS)
#include "WebGPUIdentifier.h"
+#include
#include
#include
Modified: trunk/Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemoteTextureProxy.h (285913 => 285914)
--- trunk/Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemoteTextureProxy.h 2021-11-17 03:14:06 UTC (rev 285913)
+++ trunk/Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemoteTextureProxy.h 2021-11-17 04:27:08 UTC (rev 285914)
@@ -32,6 +32,7 @@
#include
#include
#include
+#include
namespace WebKit::WebGPU {
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [285913] trunk/Source/WebGPU
Title: [285913] trunk/Source/WebGPU Revision 285913 Author mmaxfi...@apple.com Date 2021-11-16 19:14:06 -0800 (Tue, 16 Nov 2021) Log Message [WebGPU] Add WGSLUnitTests XCTest target for WebGPU https://bugs.webkit.org/show_bug.cgi?id=233227 Reviewed by Robin Morisset. For now, this new target isn't hooked up to any automated testing - it's just a local target which developers can run. * Configurations/WGSLUnitTests.xcconfig: Added. * WGSLUnitTests/WGSLUnitTests.mm: Added. (-[WGSLUnitTests testExample]): * WebGPU.xcodeproj/project.pbxproj: * WebGPU.xcodeproj/xcshareddata/xcschemes/WGSL.xcscheme: * WebGPU.xcodeproj/xcshareddata/xcschemes/WGSLUnitTests.xcscheme: Copied from Source/WebGPU/WebGPU.xcodeproj/xcshareddata/xcschemes/WGSL.xcscheme. Modified Paths trunk/Source/WebGPU/ChangeLog trunk/Source/WebGPU/WebGPU.xcodeproj/project.pbxproj trunk/Source/WebGPU/WebGPU.xcodeproj/xcshareddata/xcschemes/WGSL.xcscheme Added Paths trunk/Source/WebGPU/Configurations/WGSLUnitTests.xcconfig trunk/Source/WebGPU/WGSLUnitTests/ trunk/Source/WebGPU/WGSLUnitTests/WGSLUnitTests.mm trunk/Source/WebGPU/WebGPU.xcodeproj/xcshareddata/xcschemes/WGSLUnitTests.xcscheme Diff Modified: trunk/Source/WebGPU/ChangeLog (285912 => 285913) --- trunk/Source/WebGPU/ChangeLog 2021-11-17 02:55:32 UTC (rev 285912) +++ trunk/Source/WebGPU/ChangeLog 2021-11-17 03:14:06 UTC (rev 285913) @@ -1,3 +1,19 @@ +2021-11-16 Myles C. Maxfield + +[WebGPU] Add WGSLUnitTests XCTest target for WebGPU +https://bugs.webkit.org/show_bug.cgi?id=233227 + +Reviewed by Robin Morisset. + +For now, this new target isn't hooked up to any automated testing - it's just a local target which developers can run. + +* Configurations/WGSLUnitTests.xcconfig: Added. +* WGSLUnitTests/WGSLUnitTests.mm: Added. +(-[WGSLUnitTests testExample]): +* WebGPU.xcodeproj/project.pbxproj: +* WebGPU.xcodeproj/xcshareddata/xcschemes/WGSL.xcscheme: +* WebGPU.xcodeproj/xcshareddata/xcschemes/WGSLUnitTests.xcscheme: Copied from Source/WebGPU/WebGPU.xcodeproj/xcshareddata/xcschemes/WGSL.xcscheme. + 2021-11-14 Myles C. Maxfield [WebGPU] Add necessary additions to WebGPU.framework Added: trunk/Source/WebGPU/Configurations/WGSLUnitTests.xcconfig (0 => 285913) --- trunk/Source/WebGPU/Configurations/WGSLUnitTests.xcconfig (rev 0) +++ trunk/Source/WebGPU/Configurations/WGSLUnitTests.xcconfig 2021-11-17 03:14:06 UTC (rev 285913) @@ -0,0 +1,28 @@ +// Copyright (C) 2014-2021 Apple Inc. All rights reserved. +// +// Redistribution and use in source and binary forms, with or without +// modification, are permitted provided that the following conditions +// are met: +// 1. Redistributions of source code must retain the above copyright +//notice, this list of conditions and the following disclaimer. +// 2. Redistributions in binary form must reproduce the above copyright +//notice, this list of conditions and the following disclaimer in the +//documentation and/or other materials provided with the distribution. +// +// THIS SOFTWARE IS PROVIDED BY APPLE INC. ``AS IS'' AND ANY +// EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE +// IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR +// PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR +// CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, +// EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, +// PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR +// PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY +// OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT +// (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE +// OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. + +EXECUTABLE_PREFIX = lib; +HEADER_SEARCH_PATHS = "$(BUILT_PRODUCTS_DIR)/usr/local/include" $(inherited); +PRODUCT_NAME = WGSLUnitTests; +ENABLE_TESTABILITY = YES; +GENERATE_INFOPLIST_FILE = YES; Added: trunk/Source/WebGPU/WGSLUnitTests/WGSLUnitTests.mm (0 => 285913) --- trunk/Source/WebGPU/WGSLUnitTests/WGSLUnitTests.mm (rev 0) +++ trunk/Source/WebGPU/WGSLUnitTests/WGSLUnitTests.mm 2021-11-17 03:14:06 UTC (rev 285913) @@ -0,0 +1,44 @@ +/* + * Copyright (c) 2021 Apple Inc. All rights reserved. + * + * Redistribution and use in source and binary forms, with or without + * modification, are permitted provided that the following conditions + * are met: + * 1. Redistributions of source code must retain the above copyright + *notice, this list of conditions and the following disclaimer. + * 2. Redistributions in binary form must reproduce the above copyright + *notice, this list of conditions and the following disclaimer in the + *documentation and/or other materials provided with the distribution. + * + * THIS SOFTWARE IS PROVIDED BY APPLE INC. ``AS IS'' AND
[webkit-changes] [285911] trunk/Source/WebKit
Title: [285911] trunk/Source/WebKit Revision 285911 Author pvol...@apple.com Date 2021-11-16 18:48:39 -0800 (Tue, 16 Nov 2021) Log Message [macOS] Add sandbox telemetry for preference access https://bugs.webkit.org/show_bug.cgi?id=233194 Reviewed by Brent Fulgham. Add sandbox telemetry for preference access on macOS. * Shared/Sandbox/preferences.sb: Modified Paths trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/Shared/Sandbox/preferences.sb Diff Modified: trunk/Source/WebKit/ChangeLog (285910 => 285911) --- trunk/Source/WebKit/ChangeLog 2021-11-17 02:39:47 UTC (rev 285910) +++ trunk/Source/WebKit/ChangeLog 2021-11-17 02:48:39 UTC (rev 285911) @@ -1,3 +1,14 @@ +2021-11-16 Per Arne Vollan + +[macOS] Add sandbox telemetry for preference access +https://bugs.webkit.org/show_bug.cgi?id=233194 + +Reviewed by Brent Fulgham. + +Add sandbox telemetry for preference access on macOS. + +* Shared/Sandbox/preferences.sb: + 2021-11-16 Devin Rousso [iOS] use PhotosUIPrivate instead of PhotosUI Modified: trunk/Source/WebKit/Shared/Sandbox/preferences.sb (285910 => 285911) --- trunk/Source/WebKit/Shared/Sandbox/preferences.sb 2021-11-17 02:39:47 UTC (rev 285910) +++ trunk/Source/WebKit/Shared/Sandbox/preferences.sb 2021-11-17 02:48:39 UTC (rev 285911) @@ -30,7 +30,7 @@ (define (shared-preferences-read . domains) (for-each (lambda (domain) (begin -(allow user-preference-read (preference-domain domain)) +(allow user-preference-read (with telemetry) (preference-domain domain)) (allow file-read* (literal (string-append "/Library/Preferences/" domain ".plist")) (home-library-preferences-literal (string-append "/" domain ".plist")) ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [285910] trunk/Source
Title: [285910] trunk/Source Revision 285910 Author drou...@apple.com Date 2021-11-16 18:39:47 -0800 (Tue, 16 Nov 2021) Log Message [iOS] use PhotosUIPrivate instead of PhotosUI https://bugs.webkit.org/show_bug.cgi?id=233213 Reviewed by Aditya Keerthi. Source/WebKit: * Platform/spi/ios/PhotosUISPI.h: * UIProcess/ios/forms/WKFileUploadPanel.mm: Source/WTF: * wtf/PlatformHave.h: Modified Paths trunk/Source/WTF/ChangeLog trunk/Source/WTF/wtf/PlatformHave.h trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/Platform/spi/ios/PhotosUISPI.h trunk/Source/WebKit/UIProcess/ios/forms/WKFileUploadPanel.mm Diff Modified: trunk/Source/WTF/ChangeLog (285909 => 285910) --- trunk/Source/WTF/ChangeLog 2021-11-17 02:13:35 UTC (rev 285909) +++ trunk/Source/WTF/ChangeLog 2021-11-17 02:39:47 UTC (rev 285910) @@ -1,3 +1,13 @@ +2021-11-16 Devin Rousso + +[iOS] use PhotosUIPrivate instead of PhotosUI +https://bugs.webkit.org/show_bug.cgi?id=233213 + + +Reviewed by Aditya Keerthi. + +* wtf/PlatformHave.h: + 2021-11-15 Sam Weinig Add another backend backed by SceneKit to prove out ModelPlayer infrastructure a bit more Modified: trunk/Source/WTF/wtf/PlatformHave.h (285909 => 285910) --- trunk/Source/WTF/wtf/PlatformHave.h 2021-11-17 02:13:35 UTC (rev 285909) +++ trunk/Source/WTF/wtf/PlatformHave.h 2021-11-17 02:39:47 UTC (rev 285910) @@ -1068,8 +1068,11 @@ #endif #if PLATFORM(IOS) -#define HAVE_PUACTIVITYPROGRESSCONTROLLER 1 +#define HAVE_PHOTOS_UI 1 +#if __has_include() +#define HAVE_PHOTOS_UI_PRIVATE 1 #endif +#endif #if (PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 12) \ || (((PLATFORM(IOS) && !PLATFORM(IOS_FAMILY_SIMULATOR)) || PLATFORM(MACCATALYST)) && __IPHONE_OS_VERSION_MIN_REQUIRED >= 15) \ Modified: trunk/Source/WebKit/ChangeLog (285909 => 285910) --- trunk/Source/WebKit/ChangeLog 2021-11-17 02:13:35 UTC (rev 285909) +++ trunk/Source/WebKit/ChangeLog 2021-11-17 02:39:47 UTC (rev 285910) @@ -1,3 +1,14 @@ +2021-11-16 Devin Rousso + +[iOS] use PhotosUIPrivate instead of PhotosUI +https://bugs.webkit.org/show_bug.cgi?id=233213 + + +Reviewed by Aditya Keerthi. + +* Platform/spi/ios/PhotosUISPI.h: +* UIProcess/ios/forms/WKFileUploadPanel.mm: + 2021-11-16 Per Arne Vollan [iOS] Reduce telemetry Modified: trunk/Source/WebKit/Platform/spi/ios/PhotosUISPI.h (285909 => 285910) --- trunk/Source/WebKit/Platform/spi/ios/PhotosUISPI.h 2021-11-17 02:13:35 UTC (rev 285909) +++ trunk/Source/WebKit/Platform/spi/ios/PhotosUISPI.h 2021-11-17 02:39:47 UTC (rev 285910) @@ -25,7 +25,9 @@ #if USE(APPLE_INTERNAL_SDK) -#if HAVE(PUACTIVITYPROGRESSCONTROLLER) +#if HAVE(PHOTOS_UI_PRIVATE) +#import +#elif HAVE(PHOTOS_UI) #import #endif @@ -33,7 +35,7 @@ #import "UIKitSPI.h" -#if HAVE(PUACTIVITYPROGRESSCONTROLLER) +#if HAVE(PHOTOS_UI) @interface PUActivityProgressController : NSObject @@ -50,6 +52,6 @@ @end -#endif // HAVE(PUACTIVITYPROGRESSCONTROLLER) +#endif // HAVE(PHOTOS_UI) #endif // USE(APPLE_INTERNAL_SDK) Modified: trunk/Source/WebKit/UIProcess/ios/forms/WKFileUploadPanel.mm (285909 => 285910) --- trunk/Source/WebKit/UIProcess/ios/forms/WKFileUploadPanel.mm 2021-11-17 02:13:35 UTC (rev 285909) +++ trunk/Source/WebKit/UIProcess/ios/forms/WKFileUploadPanel.mm 2021-11-17 02:39:47 UTC (rev 285910) @@ -54,7 +54,10 @@ #import -#if HAVE(PUACTIVITYPROGRESSCONTROLLER) +#if HAVE(PHOTOS_UI_PRIVATE) +SOFT_LINK_PRIVATE_FRAMEWORK(PhotosUIPrivate) +SOFT_LINK_CLASS(PhotosUIPrivate, PUActivityProgressController) +#elif HAVE(PHOTOS_UI) SOFT_LINK_FRAMEWORK(PhotosUI) SOFT_LINK_CLASS(PhotosUI, PUActivityProgressController) #endif ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [285909] tags/Safari-612.3.6.3.1/
Title: [285909] tags/Safari-612.3.6.3.1/ Revision 285909 Author repst...@apple.com Date 2021-11-16 18:13:35 -0800 (Tue, 16 Nov 2021) Log Message Tag Safari-612.3.6.3.1. Added Paths tags/Safari-612.3.6.3.1/ Diff ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [285908] tags/Safari-612.3.6.2.2/
Title: [285908] tags/Safari-612.3.6.2.2/ Revision 285908 Author repst...@apple.com Date 2021-11-16 18:12:07 -0800 (Tue, 16 Nov 2021) Log Message Tag Safari-612.3.6.2.2. Added Paths tags/Safari-612.3.6.2.2/ Diff ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [285907] tags/Safari-612.3.6.0.3/
Title: [285907] tags/Safari-612.3.6.0.3/ Revision 285907 Author repst...@apple.com Date 2021-11-16 18:07:27 -0800 (Tue, 16 Nov 2021) Log Message Tag Safari-612.3.6.0.3. Added Paths tags/Safari-612.3.6.0.3/ Diff ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [285906] trunk/Source/WebKit
Title: [285906] trunk/Source/WebKit Revision 285906 Author pvol...@apple.com Date 2021-11-16 18:00:06 -0800 (Tue, 16 Nov 2021) Log Message [iOS] Reduce telemetry https://bugs.webkit.org/show_bug.cgi?id=233218 Reviewed by Brent Fulgham. Reduce telemetry with backtrace for the system calls we have information about. * Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in: Modified Paths trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in Diff Modified: trunk/Source/WebKit/ChangeLog (285905 => 285906) --- trunk/Source/WebKit/ChangeLog 2021-11-17 01:57:27 UTC (rev 285905) +++ trunk/Source/WebKit/ChangeLog 2021-11-17 02:00:06 UTC (rev 285906) @@ -1,3 +1,14 @@ +2021-11-16 Per Arne Vollan + +[iOS] Reduce telemetry +https://bugs.webkit.org/show_bug.cgi?id=233218 + +Reviewed by Brent Fulgham. + +Reduce telemetry with backtrace for the system calls we have information about. + +* Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in: + 2021-11-16 Devin Rousso [Apple Pay] handle unknown setup features Modified: trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in (285905 => 285906) --- trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in 2021-11-17 01:57:27 UTC (rev 285905) +++ trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in 2021-11-17 02:00:06 UTC (rev 285906) @@ -1280,6 +1280,19 @@ (syscall-number SYS_workq_kernreturn) (syscall-number SYS_workq_open)) +(allow syscall-unix (with telemetry) +(syscall-number SYS_fgetxattr) +(syscall-number SYS_getgid) +(syscall-number SYS_getxattr) +(syscall-number SYS_necp_client_action) +(syscall-number SYS_necp_open) +(syscall-number SYS_sendto) +(syscall-number SYS_setrlimit) +(syscall-number SYS_sigaltstack) +(syscall-number SYS_socket) +(syscall-number SYS_thread_selfusage) +) + (allow syscall-unix (with telemetry-backtrace) (syscall-number SYS___pthread_kill) (syscall-number SYS___pthread_markcancel) @@ -1298,7 +1311,6 @@ (syscall-number SYS_dup) (syscall-number SYS_dup2) (syscall-number SYS_fchmod) -(syscall-number SYS_fgetxattr) (syscall-number SYS_fileport_makefd) (syscall-number SYS_fileport_makeport) (syscall-number SYS_fstatat64) @@ -1305,10 +1317,8 @@ (syscall-number SYS_fsync) (syscall-number SYS_getattrlistbulk) ;; xpc_realpath and directory enumeration (syscall-number SYS_getaudit_addr) -(syscall-number SYS_getgid) (syscall-number SYS_getpeername) (syscall-number SYS_getsockopt) ;; used by libwebrtc -(syscall-number SYS_getxattr) (syscall-number SYS_ioctl) ;; needed by tcgetattr (TIOCGETA) - debugging (syscall-number SYS_kdebug_trace) (syscall-number SYS_mkdirat) @@ -1315,8 +1325,6 @@ (syscall-number SYS_mlock) (syscall-number SYS_mremap_encrypted) (syscall-number SYS_munlock) -(syscall-number SYS_necp_client_action) -(syscall-number SYS_necp_open) (syscall-number SYS_open) (syscall-number SYS_open_dprotected_np) (syscall-number SYS_open_nocancel) @@ -1340,21 +1348,16 @@ (syscall-number SYS_sem_post) (syscall-number SYS_sem_wait) (syscall-number SYS_sendmsg_nocancel) -(syscall-number SYS_sendto) (syscall-number SYS_sendto_nocancel) (syscall-number SYS_setpriority) -(syscall-number SYS_setrlimit) (syscall-number SYS_setsockopt) (syscall-number SYS_shm_open) (syscall-number SYS_shutdown) -(syscall-number SYS_sigaltstack) (syscall-number SYS_sigprocmask) (syscall-number SYS_sigreturn) -(syscall-number SYS_socket) (syscall-number SYS_socketpair) (syscall-number SYS_sysctl) (syscall-number SYS_sysctlbyname) -(syscall-number SYS_thread_selfusage) (syscall-number SYS_umask) (syscall-number SYS_unlink) (syscall-number SYS_work_interval_ctl) @@ -1547,18 +1550,18 @@ mach_exception_raise (when (defined? 'mach_make_memory_entry) mach_make_memory_entry) (when (defined? 'mach_make_memory_entry_64) mach_make_memory_entry_64) -mach_memory_entry_ownership mach_port_request_notification mach_vm_region mach_vm_region_recurse -task_set_exc_guard_behavior task_threads_from_user -thread_policy (when (defined? 'vm_copy) vm_copy) (when (defined? 'vm_remap_external) vm_remap_external))) (allow
[webkit-changes] [285905] tags/Safari-612.3.6.1.3/
Title: [285905] tags/Safari-612.3.6.1.3/ Revision 285905 Author repst...@apple.com Date 2021-11-16 17:57:27 -0800 (Tue, 16 Nov 2021) Log Message Tag Safari-612.3.6.1.3. Added Paths tags/Safari-612.3.6.1.3/ Diff ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [285904] trunk/Source
Title: [285904] trunk/Source Revision 285904 Author nmouchta...@apple.com Date 2021-11-16 17:26:57 -0800 (Tue, 16 Nov 2021) Log Message Rename TextDecoration to TextDecorationLine https://bugs.webkit.org/show_bug.cgi?id=232729 Reviewed by Myles C. Maxfield. Source/WebCore: Split up patch by Tim Nguyen: https://bugs.webkit.org/show_bug.cgi?id=230083. This patch renames enum TextDecoration to TextDecorationLine, to be more in line with the current spec. * accessibility/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::hasUnderline const): * accessibility/atk/WebKitAccessibleInterfaceText.cpp: (getAttributeSetForAccessibilityObject): * accessibility/mac/WebAccessibilityObjectWrapperBase.mm: (AXAttributeStringSetStyle): * accessibility/mac/WebAccessibilityObjectWrapperMac.mm: (AXAttributeStringSetStyle): * animation/CSSPropertyAnimation.cpp: (WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap): * css/CSSComputedStyleDeclaration.cpp: (WebCore::renderTextDecorationLineFlagsToCSSValue): (WebCore::ComputedStyleExtractor::valueForPropertyInStyle): (WebCore::renderTextDecorationFlagsToCSSValue): Deleted. * css/CSSPrimitiveValueMappings.h: (WebCore::CSSPrimitiveValue::operator OptionSet const): (WebCore::CSSPrimitiveValue::operator OptionSet const): Deleted. * editing/Editor.cpp: (WebCore::Editor::fontAttributesAtSelectionStart): * editing/cocoa/HTMLConverter.mm: (WebCore::editingAttributedString): * rendering/StyledMarkedText.cpp: (WebCore::resolveStyleForMarkedText): * rendering/TextDecorationPainter.cpp: (WebCore::TextDecorationPainter::TextDecorationPainter): (WebCore::TextDecorationPainter::paintTextDecoration): (WebCore::collectStylesForRenderer): (WebCore::TextDecorationPainter::textDecorationsInEffectForStyle): (WebCore::TextDecorationPainter::stylesForRenderer): * rendering/TextDecorationPainter.h: * rendering/style/RenderStyle.h: (WebCore::RenderStyle::textDecorationsInEffect const): (WebCore::RenderStyle::textDecoration const): (WebCore::RenderStyle::addToTextDecorationsInEffect): (WebCore::RenderStyle::setTextDecorationsInEffect): (WebCore::RenderStyle::setTextDecoration): (WebCore::RenderStyle::initialTextDecoration): * rendering/style/RenderStyleConstants.cpp: (WebCore::operator<<): * rendering/style/RenderStyleConstants.h: * rendering/svg/SVGInlineTextBox.cpp: (WebCore::SVGInlineTextBox::paint): (WebCore::positionOffsetForDecoration): (WebCore::thicknessForDecoration): (WebCore::SVGInlineTextBox::paintDecoration): (WebCore::SVGInlineTextBox::paintDecorationWithStyle): * rendering/svg/SVGInlineTextBox.h: * style/InlineTextBoxStyle.cpp: (WebCore::minLogicalTopForTextDecorationLine): (WebCore::maxLogicalBottomForTextDecorationLine): (WebCore::enclosingRendererWithTextDecoration): (WebCore::computeUnderlineOffset): (WebCore::visualOverflowForDecorations): * style/StyleBuilderConverter.h: (WebCore::Style::BuilderConverter::convertTextDecoration): Source/WebKitLegacy/mac: * WebView/WebView.mm: (-[WebView updateTextTouchBar]): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/accessibility/AccessibilityRenderObject.cpp trunk/Source/WebCore/accessibility/atk/WebKitAccessibleInterfaceText.cpp trunk/Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperBase.mm trunk/Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm trunk/Source/WebCore/animation/CSSPropertyAnimation.cpp trunk/Source/WebCore/css/CSSComputedStyleDeclaration.cpp trunk/Source/WebCore/css/CSSPrimitiveValueMappings.h trunk/Source/WebCore/editing/Editor.cpp trunk/Source/WebCore/editing/cocoa/HTMLConverter.mm trunk/Source/WebCore/rendering/StyledMarkedText.cpp trunk/Source/WebCore/rendering/TextDecorationPainter.cpp trunk/Source/WebCore/rendering/TextDecorationPainter.h trunk/Source/WebCore/rendering/style/RenderStyle.h trunk/Source/WebCore/rendering/style/RenderStyleConstants.cpp trunk/Source/WebCore/rendering/style/RenderStyleConstants.h trunk/Source/WebCore/rendering/svg/SVGInlineTextBox.cpp trunk/Source/WebCore/rendering/svg/SVGInlineTextBox.h trunk/Source/WebCore/style/InlineTextBoxStyle.cpp trunk/Source/WebCore/style/StyleBuilderConverter.h trunk/Source/WebKitLegacy/mac/ChangeLog trunk/Source/WebKitLegacy/mac/WebView/WebView.mm Diff Modified: trunk/Source/WebCore/ChangeLog (285903 => 285904) --- trunk/Source/WebCore/ChangeLog 2021-11-17 01:08:34 UTC (rev 285903) +++ trunk/Source/WebCore/ChangeLog 2021-11-17 01:26:57 UTC (rev 285904) @@ -1,3 +1,69 @@ +2021-11-16 Nikolaos Mouchtaris + +Rename TextDecoration to TextDecorationLine +https://bugs.webkit.org/show_bug.cgi?id=232729 + +Reviewed by Myles C. Maxfield. + +Split up patch by Tim Nguyen: https://bugs.webkit.org/show_bug.cgi?id=230083. This patch +renames enum TextDecoration to TextDecorationLine, to be more in line with the current spec. + +* accessibility/AccessibilityRenderObject.cpp: +
[webkit-changes] [285903] branches/safari-613.1.9-branch/Source/WebKit
Title: [285903] branches/safari-613.1.9-branch/Source/WebKit
Revision 285903
Author repst...@apple.com
Date 2021-11-16 17:08:34 -0800 (Tue, 16 Nov 2021)
Log Message
Cherry-pick r285886. rdar://problem/85473581
[iOS] Limit graphics related IOKit method filtering
https://bugs.webkit.org/show_bug.cgi?id=233209
Reviewed by Brent Fulgham.
Limit graphics related IOKit method filtering based on OS version. This patch also adds an entitlement which
will enable a replacement for the disabled filtering.
* Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in:
* Scripts/process-entitlements.sh:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@285886 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Modified Paths
branches/safari-613.1.9-branch/Source/WebKit/ChangeLog
branches/safari-613.1.9-branch/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in
branches/safari-613.1.9-branch/Source/WebKit/Scripts/process-entitlements.sh
Diff
Modified: branches/safari-613.1.9-branch/Source/WebKit/ChangeLog (285902 => 285903)
--- branches/safari-613.1.9-branch/Source/WebKit/ChangeLog 2021-11-17 01:03:07 UTC (rev 285902)
+++ branches/safari-613.1.9-branch/Source/WebKit/ChangeLog 2021-11-17 01:08:34 UTC (rev 285903)
@@ -1,5 +1,38 @@
2021-11-16 Russell Epstein
+Cherry-pick r285886. rdar://problem/85473581
+
+[iOS] Limit graphics related IOKit method filtering
+https://bugs.webkit.org/show_bug.cgi?id=233209
+
+
+Reviewed by Brent Fulgham.
+
+Limit graphics related IOKit method filtering based on OS version. This patch also adds an entitlement which
+will enable a replacement for the disabled filtering.
+
+* Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in:
+* Scripts/process-entitlements.sh:
+
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@285886 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2021-11-16 Per Arne Vollan
+
+[iOS] Limit graphics related IOKit method filtering
+https://bugs.webkit.org/show_bug.cgi?id=233209
+
+
+Reviewed by Brent Fulgham.
+
+Limit graphics related IOKit method filtering based on OS version. This patch also adds an entitlement which
+will enable a replacement for the disabled filtering.
+
+* Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in:
+* Scripts/process-entitlements.sh:
+
+2021-11-16 Russell Epstein
+
Cherry-pick r285889. rdar://problem/85430575
Adjust graphics related message filter
Modified: branches/safari-613.1.9-branch/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in (285902 => 285903)
--- branches/safari-613.1.9-branch/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in 2021-11-17 01:03:07 UTC (rev 285902)
+++ branches/safari-613.1.9-branch/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in 2021-11-17 01:08:34 UTC (rev 285903)
@@ -261,7 +261,7 @@
iokit-external-method
)
(allow iokit-async-external-method
-#if PLATFORM(IOS)
+#if PLATFORM(IOS) && __IPHONE_OS_VERSION_MIN_REQUIRED < 16
(iokit-method-number
43
44
@@ -269,7 +269,7 @@
#endif
)
(allow iokit-external-method
-#if PLATFORM(IOS)
+#if PLATFORM(IOS) && __IPHONE_OS_VERSION_MIN_REQUIRED < 16
(iokit-method-number
0
2
Modified: branches/safari-613.1.9-branch/Source/WebKit/Scripts/process-entitlements.sh (285902 => 285903)
--- branches/safari-613.1.9-branch/Source/WebKit/Scripts/process-entitlements.sh 2021-11-17 01:03:07 UTC (rev 285902)
+++ branches/safari-613.1.9-branch/Source/WebKit/Scripts/process-entitlements.sh 2021-11-17 01:08:34 UTC (rev 285903)
@@ -32,6 +32,10 @@
then
plistbuddy add :com.apple.coreaudio.allow-vorbis-decode bool YES
fi
+if (( "${TARGET_MAC_OS_X_VERSION_MAJOR}" >= 13 ))
+then
+plistbuddy Add :com.apple.private.gpu-restricted bool YES
+fi
fi
mac_process_webcontent_or_plugin_entitlements
@@ -61,6 +65,11 @@
plistbuddy Add :com.apple.security.cs.jit-write-allowlist bool YES
fi
+if (( "${TARGET_MAC_OS_X_VERSION_MAJOR}" >= 13 ))
+then
+plistbuddy Add :com.apple.private.gpu-restricted bool YES
+fi
+
plistbuddy Add :com.apple.private.memory.ownership_transfer bool YES
plistbuddy Add :com.apple.private.webkit.use-xpc-endpoint bool YES
plistbuddy Add :com.apple.rootless.storage.WebKitGPUSandbox bool YES
@@ -280,6 +289,7 @@
plistbuddy Add :com.apple.private.allow-explicit-graphics-priority bool YES
plistbuddy Add
[webkit-changes] [285902] branches/safari-612.3.6.3-branch/Source/WebKit
Title: [285902] branches/safari-612.3.6.3-branch/Source/WebKit
Revision 285902
Author repst...@apple.com
Date 2021-11-16 17:03:07 -0800 (Tue, 16 Nov 2021)
Log Message
Cherry-pick r283386. rdar://problem/83953959
Protect WebFrame during invalidatePolicyListener()
https://bugs.webkit.org/show_bug.cgi?id=229981
Reviewed by Alex Christensen.
* WebProcess/WebPage/WebFrame.cpp:
(WebKit::WebFrame::invalidatePolicyListeners): Protect the WebFrame while
policy handlers are run.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@283386 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Modified Paths
branches/safari-612.3.6.3-branch/Source/WebKit/ChangeLog
branches/safari-612.3.6.3-branch/Source/WebKit/WebProcess/WebPage/WebFrame.cpp
Diff
Modified: branches/safari-612.3.6.3-branch/Source/WebKit/ChangeLog (285901 => 285902)
--- branches/safari-612.3.6.3-branch/Source/WebKit/ChangeLog 2021-11-17 00:59:58 UTC (rev 285901)
+++ branches/safari-612.3.6.3-branch/Source/WebKit/ChangeLog 2021-11-17 01:03:07 UTC (rev 285902)
@@ -1,3 +1,31 @@
+2021-11-16 Russell Epstein
+
+Cherry-pick r283386. rdar://problem/83953959
+
+Protect WebFrame during invalidatePolicyListener()
+https://bugs.webkit.org/show_bug.cgi?id=229981
+
+
+Reviewed by Alex Christensen.
+
+* WebProcess/WebPage/WebFrame.cpp:
+(WebKit::WebFrame::invalidatePolicyListeners): Protect the WebFrame while
+policy handlers are run.
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@283386 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2021-10-01 Brent Fulgham
+
+Protect WebFrame during invalidatePolicyListener()
+https://bugs.webkit.org/show_bug.cgi?id=229981
+
+
+Reviewed by Alex Christensen.
+
+* WebProcess/WebPage/WebFrame.cpp:
+(WebKit::WebFrame::invalidatePolicyListeners): Protect the WebFrame while
+policy handlers are run.
+
2021-11-08 Kocsen Chung
Cherry-pick r285236. rdar://problem/83950623
Modified: branches/safari-612.3.6.3-branch/Source/WebKit/WebProcess/WebPage/WebFrame.cpp (285901 => 285902)
--- branches/safari-612.3.6.3-branch/Source/WebKit/WebProcess/WebPage/WebFrame.cpp 2021-11-17 00:59:58 UTC (rev 285901)
+++ branches/safari-612.3.6.3-branch/Source/WebKit/WebProcess/WebPage/WebFrame.cpp 2021-11-17 01:03:07 UTC (rev 285902)
@@ -237,6 +237,8 @@
void WebFrame::invalidatePolicyListener()
{
+Ref protectedThis { *this };
+
if (!m_policyListenerID)
return;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [285901] branches/safari-612.3.6.3-branch/Source
Title: [285901] branches/safari-612.3.6.3-branch/Source Revision 285901 Author repst...@apple.com Date 2021-11-16 16:59:58 -0800 (Tue, 16 Nov 2021) Log Message Versioning. WebKit-7612.3.6.3.1 Modified Paths branches/safari-612.3.6.3-branch/Source/_javascript_Core/Configurations/Version.xcconfig branches/safari-612.3.6.3-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig branches/safari-612.3.6.3-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig branches/safari-612.3.6.3-branch/Source/WebCore/Configurations/Version.xcconfig branches/safari-612.3.6.3-branch/Source/WebCore/PAL/Configurations/Version.xcconfig branches/safari-612.3.6.3-branch/Source/WebInspectorUI/Configurations/Version.xcconfig branches/safari-612.3.6.3-branch/Source/WebKit/Configurations/Version.xcconfig branches/safari-612.3.6.3-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig Diff Modified: branches/safari-612.3.6.3-branch/Source/_javascript_Core/Configurations/Version.xcconfig (285900 => 285901) --- branches/safari-612.3.6.3-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2021-11-17 00:56:19 UTC (rev 285900) +++ branches/safari-612.3.6.3-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2021-11-17 00:59:58 UTC (rev 285901) @@ -24,9 +24,9 @@ MAJOR_VERSION = 612; MINOR_VERSION = 3; TINY_VERSION = 6; -MICRO_VERSION = 0; -NANO_VERSION = 0; -FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); +MICRO_VERSION = 3; +NANO_VERSION = 1; +FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION)); Modified: branches/safari-612.3.6.3-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig (285900 => 285901) --- branches/safari-612.3.6.3-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig 2021-11-17 00:56:19 UTC (rev 285900) +++ branches/safari-612.3.6.3-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig 2021-11-17 00:59:58 UTC (rev 285901) @@ -24,9 +24,9 @@ MAJOR_VERSION = 612; MINOR_VERSION = 3; TINY_VERSION = 6; -MICRO_VERSION = 0; -NANO_VERSION = 0; -FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); +MICRO_VERSION = 3; +NANO_VERSION = 1; +FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION)); Modified: branches/safari-612.3.6.3-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (285900 => 285901) --- branches/safari-612.3.6.3-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig 2021-11-17 00:56:19 UTC (rev 285900) +++ branches/safari-612.3.6.3-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig 2021-11-17 00:59:58 UTC (rev 285901) @@ -24,9 +24,9 @@ MAJOR_VERSION = 612; MINOR_VERSION = 3; TINY_VERSION = 6; -MICRO_VERSION = 0; -NANO_VERSION = 0; -FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); +MICRO_VERSION = 3; +NANO_VERSION = 1; +FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION)); Modified: branches/safari-612.3.6.3-branch/Source/WebCore/Configurations/Version.xcconfig (285900 => 285901) --- branches/safari-612.3.6.3-branch/Source/WebCore/Configurations/Version.xcconfig 2021-11-17 00:56:19 UTC (rev 285900) +++ branches/safari-612.3.6.3-branch/Source/WebCore/Configurations/Version.xcconfig 2021-11-17 00:59:58 UTC (rev 285901) @@ -24,9 +24,9 @@ MAJOR_VERSION = 612; MINOR_VERSION = 3; TINY_VERSION = 6; -MICRO_VERSION = 0; -NANO_VERSION = 0; -FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); +MICRO_VERSION = 3; +NANO_VERSION = 1; +FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION)); Modified: branches/safari-612.3.6.3-branch/Source/WebCore/PAL/Configurations/Version.xcconfig (285900 => 285901) --- branches/safari-612.3.6.3-branch/Source/WebCore/PAL/Configurations/Version.xcconfig 2021-11-17 00:56:19 UTC (rev 285900) +++ branches/safari-612.3.6.3-branch/Source/WebCore/PAL/Configurations/Version.xcconfig 2021-11-17 00:59:58 UTC (rev 285901) @@ -24,9 +24,9 @@ MAJOR_VERSION = 612; MINOR_VERSION = 3; TINY_VERSION = 6; -MICRO_VERSION = 0; -NANO_VERSION = 0; -FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); +MICRO_VERSION = 3; +NANO_VERSION = 1; +FULL_VERSION =
[webkit-changes] [285900] trunk/Tools
Title: [285900] trunk/Tools Revision 285900 Author jbed...@apple.com Date 2021-11-16 16:56:19 -0800 (Tue, 16 Nov 2021) Log Message [webkitscmpy] Load secrets in kubernetes https://bugs.webkit.org/show_bug.cgi?id=233158 Reviewed by Dewei Zhu. * Tools/Scripts/libraries/webkitcorepy/setup.py: Bump version. * Tools/Scripts/libraries/webkitcorepy/webkitcorepy/__init__.py: Bump version, export Environment. * Tools/Scripts/libraries/webkitcorepy/webkitcorepy/credentials.py: (credentials): Use Environment instead of os.environ. * Tools/Scripts/libraries/webkitcorepy/webkitcorepy/environment.py: Added. (Environment): (Environment.instance): Construct a shared Environmant intance. (Environment.__init__): (Environment.load): Load secrets in file directory. (Environment.get): Check environment variable and then secret store. (Environment.__getitem__): (Environment.__setitem__): (Environment.keys): Iterate through secret store and environment variables. (Environment.values): Ditto. (Environment.items): Ditto. * Tools/Scripts/libraries/webkitcorepy/webkitcorepy/tests/environment_unittest.py: Added. (TestEnvironment): (TestEnvironment.test_basic): (TestEnvironment.test_scoped): (TestEnvironment.test_list): Canonical link: https://commits.webkit.org/244316@main Modified Paths trunk/Tools/ChangeLog trunk/Tools/Scripts/libraries/webkitcorepy/setup.py trunk/Tools/Scripts/libraries/webkitcorepy/webkitcorepy/__init__.py trunk/Tools/Scripts/libraries/webkitcorepy/webkitcorepy/credentials.py Added Paths trunk/Tools/Scripts/libraries/webkitcorepy/webkitcorepy/environment.py trunk/Tools/Scripts/libraries/webkitcorepy/webkitcorepy/tests/environment_unittest.py Diff Modified: trunk/Tools/ChangeLog (285899 => 285900) --- trunk/Tools/ChangeLog 2021-11-17 00:31:49 UTC (rev 285899) +++ trunk/Tools/ChangeLog 2021-11-17 00:56:19 UTC (rev 285900) @@ -1,3 +1,32 @@ +2021-11-16 Jonathan Bedard + +[webkitscmpy] Load secrets in kubernetes +https://bugs.webkit.org/show_bug.cgi?id=233158 + + +Reviewed by Dewei Zhu. + +* Scripts/libraries/webkitcorepy/setup.py: Bump version. +* Scripts/libraries/webkitcorepy/webkitcorepy/__init__.py: Bump version, export Environment. +* Scripts/libraries/webkitcorepy/webkitcorepy/credentials.py: +(credentials): Use Environment instead of os.environ. +* Scripts/libraries/webkitcorepy/webkitcorepy/environment.py: Added. +(Environment): +(Environment.instance): Construct a shared Environmant intance. +(Environment.__init__): +(Environment.load): Load secrets in file directory. +(Environment.get): Check environment variable and then secret store. +(Environment.__getitem__): +(Environment.__setitem__): +(Environment.keys): Iterate through secret store and environment variables. +(Environment.values): Ditto. +(Environment.items): Ditto. +* Scripts/libraries/webkitcorepy/webkitcorepy/tests/environment_unittest.py: Added. +(TestEnvironment): +(TestEnvironment.test_basic): +(TestEnvironment.test_scoped): +(TestEnvironment.test_list): + 2021-11-12 Jonathan Bedard [git-webkit] Mark landed changes as merged Modified: trunk/Tools/Scripts/libraries/webkitcorepy/setup.py (285899 => 285900) --- trunk/Tools/Scripts/libraries/webkitcorepy/setup.py 2021-11-17 00:31:49 UTC (rev 285899) +++ trunk/Tools/Scripts/libraries/webkitcorepy/setup.py 2021-11-17 00:56:19 UTC (rev 285900) @@ -30,7 +30,7 @@ setup( name='webkitcorepy', -version='0.11.4', +version='0.12.0', description='Library containing various Python support classes and functions.', long_description=readme(), classifiers=[ Modified: trunk/Tools/Scripts/libraries/webkitcorepy/webkitcorepy/__init__.py (285899 => 285900) --- trunk/Tools/Scripts/libraries/webkitcorepy/webkitcorepy/__init__.py 2021-11-17 00:31:49 UTC (rev 285899) +++ trunk/Tools/Scripts/libraries/webkitcorepy/webkitcorepy/__init__.py 2021-11-17 00:56:19 UTC (rev 285900) @@ -36,6 +36,7 @@ from webkitcorepy.output_capture import LoggerCapture, OutputCapture, OutputDuplicate from webkitcorepy.task_pool import TaskPool from webkitcorepy.terminal import Terminal +from webkitcorepy.environment import Environment from webkitcorepy.credentials import credentials from webkitcorepy.measure_time import MeasureTime from webkitcorepy.nested_fuzzy_dict import NestedFuzzyDict @@ -43,7 +44,7 @@ from webkitcorepy.editor import Editor from webkitcorepy.file_lock import FileLock -version = Version(0, 11, 4) +version = Version(0, 12, 0) from webkitcorepy.autoinstall import Package, AutoInstall if sys.version_info > (3, 0): Modified: trunk/Tools/Scripts/libraries/webkitcorepy/webkitcorepy/credentials.py (285899 => 285900) --- trunk/Tools/Scripts/libraries/webkitcorepy/webkitcorepy/credentials.py 2021-11-17 00:31:49 UTC (rev 285899) +++
[webkit-changes] [285899] branches/safari-612.3.6.2-branch/Source/WebKit
Title: [285899] branches/safari-612.3.6.2-branch/Source/WebKit
Revision 285899
Author repst...@apple.com
Date 2021-11-16 16:31:49 -0800 (Tue, 16 Nov 2021)
Log Message
Cherry-pick r283386. rdar://problem/83953959
Protect WebFrame during invalidatePolicyListener()
https://bugs.webkit.org/show_bug.cgi?id=229981
Reviewed by Alex Christensen.
* WebProcess/WebPage/WebFrame.cpp:
(WebKit::WebFrame::invalidatePolicyListeners): Protect the WebFrame while
policy handlers are run.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@283386 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Modified Paths
branches/safari-612.3.6.2-branch/Source/WebKit/ChangeLog
branches/safari-612.3.6.2-branch/Source/WebKit/WebProcess/WebPage/WebFrame.cpp
Diff
Modified: branches/safari-612.3.6.2-branch/Source/WebKit/ChangeLog (285898 => 285899)
--- branches/safari-612.3.6.2-branch/Source/WebKit/ChangeLog 2021-11-17 00:30:29 UTC (rev 285898)
+++ branches/safari-612.3.6.2-branch/Source/WebKit/ChangeLog 2021-11-17 00:31:49 UTC (rev 285899)
@@ -1,3 +1,31 @@
+2021-11-16 Russell Epstein
+
+Cherry-pick r283386. rdar://problem/83953959
+
+Protect WebFrame during invalidatePolicyListener()
+https://bugs.webkit.org/show_bug.cgi?id=229981
+
+
+Reviewed by Alex Christensen.
+
+* WebProcess/WebPage/WebFrame.cpp:
+(WebKit::WebFrame::invalidatePolicyListeners): Protect the WebFrame while
+policy handlers are run.
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@283386 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2021-10-01 Brent Fulgham
+
+Protect WebFrame during invalidatePolicyListener()
+https://bugs.webkit.org/show_bug.cgi?id=229981
+
+
+Reviewed by Alex Christensen.
+
+* WebProcess/WebPage/WebFrame.cpp:
+(WebKit::WebFrame::invalidatePolicyListeners): Protect the WebFrame while
+policy handlers are run.
+
2021-11-11 Alan Coon
Cherry-pick r285648. rdar://problem/85171163
Modified: branches/safari-612.3.6.2-branch/Source/WebKit/WebProcess/WebPage/WebFrame.cpp (285898 => 285899)
--- branches/safari-612.3.6.2-branch/Source/WebKit/WebProcess/WebPage/WebFrame.cpp 2021-11-17 00:30:29 UTC (rev 285898)
+++ branches/safari-612.3.6.2-branch/Source/WebKit/WebProcess/WebPage/WebFrame.cpp 2021-11-17 00:31:49 UTC (rev 285899)
@@ -237,6 +237,8 @@
void WebFrame::invalidatePolicyListener()
{
+Ref protectedThis { *this };
+
if (!m_policyListenerID)
return;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [285898] trunk/Source
Title: [285898] trunk/Source
Revision 285898
Author drou...@apple.com
Date 2021-11-16 16:30:29 -0800 (Tue, 16 Nov 2021)
Log Message
[Apple Pay] handle unknown setup features
https://bugs.webkit.org/show_bug.cgi?id=233212
Reviewed by Wenson Hsieh.
Source/WebCore:
* Modules/applepay/ApplePaySetupFeatureWebCore.h:
* Modules/applepay/ApplePaySetupFeature.mm:
(WebCore::ApplePaySetupFeature::supportsFeature): Added.
(WebCore::ApplePaySetupFeature::type const):
* Modules/applepay/PaymentInstallmentConfiguration.mm:
(WebCore::applePaySetupFeatureType):
(WebCore::platformFeatureType):
(WebCore::PaymentInstallmentConfiguration::applePayInstallmentConfiguration const):
If the `PKPaymentSetupFeatureType` is unknown/unsupported, return an empty `ApplePayInstallmentConfiguration`.
Drive-by: Replace all `PKPaymentSetupFeatureTypeApplePay_X` with `PKPaymentSetupFeatureTypeAppleCard`.
Source/WebCore/PAL:
* pal/spi/cocoa/PassKitSPI.h:
Drive-by: Replace all `PKPaymentSetupFeatureTypeApplePay_X` with `PKPaymentSetupFeatureTypeAppleCard`.
Source/WebKit:
* Shared/ApplePay/ApplePayPaymentSetupFeatures.mm:
(WebKit::PaymentSetupFeatures::operator Vector> const):
Skip `PKPaymentSetupFeature` that have an unknown `PKPaymentSetupFeatureType`. This ensures
that `WebCore::ApplePaySetupFeature` will only ever be created with known/supported `PKPaymentSetupFeatureType`.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/applepay/ApplePaySetupFeature.mm
trunk/Source/WebCore/Modules/applepay/ApplePaySetupFeatureWebCore.h
trunk/Source/WebCore/Modules/applepay/PaymentInstallmentConfiguration.mm
trunk/Source/WebCore/PAL/ChangeLog
trunk/Source/WebCore/PAL/pal/spi/cocoa/PassKitSPI.h
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Shared/ApplePay/ApplePayPaymentSetupFeatures.mm
Diff
Modified: trunk/Source/WebCore/ChangeLog (285897 => 285898)
--- trunk/Source/WebCore/ChangeLog 2021-11-17 00:29:07 UTC (rev 285897)
+++ trunk/Source/WebCore/ChangeLog 2021-11-17 00:30:29 UTC (rev 285898)
@@ -1,3 +1,22 @@
+2021-11-16 Devin Rousso
+
+[Apple Pay] handle unknown setup features
+https://bugs.webkit.org/show_bug.cgi?id=233212
+
+Reviewed by Wenson Hsieh.
+
+* Modules/applepay/ApplePaySetupFeatureWebCore.h:
+* Modules/applepay/ApplePaySetupFeature.mm:
+(WebCore::ApplePaySetupFeature::supportsFeature): Added.
+(WebCore::ApplePaySetupFeature::type const):
+
+* Modules/applepay/PaymentInstallmentConfiguration.mm:
+(WebCore::applePaySetupFeatureType):
+(WebCore::platformFeatureType):
+(WebCore::PaymentInstallmentConfiguration::applePayInstallmentConfiguration const):
+If the `PKPaymentSetupFeatureType` is unknown/unsupported, return an empty `ApplePayInstallmentConfiguration`.
+Drive-by: Replace all `PKPaymentSetupFeatureTypeApplePay_X` with `PKPaymentSetupFeatureTypeAppleCard`.
+
2021-11-16 Nikolaos Mouchtaris
Add overscroll behavior to ScrollableAreaParameters
Modified: trunk/Source/WebCore/Modules/applepay/ApplePaySetupFeature.mm (285897 => 285898)
--- trunk/Source/WebCore/Modules/applepay/ApplePaySetupFeature.mm 2021-11-17 00:29:07 UTC (rev 285897)
+++ trunk/Source/WebCore/Modules/applepay/ApplePaySetupFeature.mm 2021-11-17 00:30:29 UTC (rev 285898)
@@ -34,6 +34,18 @@
namespace WebCore {
+bool ApplePaySetupFeature::supportsFeature(PKPaymentSetupFeature *feature)
+{
+switch (feature.type) {
+case PKPaymentSetupFeatureTypeApplePay:
+case PKPaymentSetupFeatureTypeAppleCard:
+return true;
+
+default:
+return false;
+}
+}
+
ApplePaySetupFeature::ApplePaySetupFeature() = default;
ApplePaySetupFeature::~ApplePaySetupFeature() = default;
@@ -42,10 +54,13 @@
switch ([m_feature type]) {
case PKPaymentSetupFeatureTypeApplePay:
return ApplePaySetupFeatureType::ApplePay;
-ALLOW_DEPRECATED_DECLARATIONS_BEGIN
-case PKPaymentSetupFeatureTypeApplePay_X:
-ALLOW_DEPRECATED_DECLARATIONS_END
+
+case PKPaymentSetupFeatureTypeAppleCard:
return ApplePaySetupFeatureType::AppleCard;
+
+default:
+ASSERT(!supportsFeature(m_feature.get()));
+return ApplePaySetupFeatureType::ApplePay;
}
}
Modified: trunk/Source/WebCore/Modules/applepay/ApplePaySetupFeatureWebCore.h (285897 => 285898)
--- trunk/Source/WebCore/Modules/applepay/ApplePaySetupFeatureWebCore.h 2021-11-17 00:29:07 UTC (rev 285897)
+++ trunk/Source/WebCore/Modules/applepay/ApplePaySetupFeatureWebCore.h 2021-11-17 00:30:29 UTC (rev 285898)
@@ -43,6 +43,8 @@
{
return adoptRef(*new ApplePaySetupFeature(feature));
}
+
+WEBCORE_EXPORT static bool supportsFeature(PKPaymentSetupFeature *);
WEBCORE_EXPORT virtual ~ApplePaySetupFeature();
Modified: trunk/Source/WebCore/Modules/applepay/PaymentInstallmentConfiguration.mm (285897 => 285898)
---
[webkit-changes] [285897] branches/safari-612.3.6.2-branch/Source
Title: [285897] branches/safari-612.3.6.2-branch/Source Revision 285897 Author repst...@apple.com Date 2021-11-16 16:29:07 -0800 (Tue, 16 Nov 2021) Log Message Versioning. WebKit-7612.3.6.2.2 Modified Paths branches/safari-612.3.6.2-branch/Source/_javascript_Core/Configurations/Version.xcconfig branches/safari-612.3.6.2-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig branches/safari-612.3.6.2-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig branches/safari-612.3.6.2-branch/Source/WebCore/Configurations/Version.xcconfig branches/safari-612.3.6.2-branch/Source/WebCore/PAL/Configurations/Version.xcconfig branches/safari-612.3.6.2-branch/Source/WebInspectorUI/Configurations/Version.xcconfig branches/safari-612.3.6.2-branch/Source/WebKit/Configurations/Version.xcconfig branches/safari-612.3.6.2-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig Diff Modified: branches/safari-612.3.6.2-branch/Source/_javascript_Core/Configurations/Version.xcconfig (285896 => 285897) --- branches/safari-612.3.6.2-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2021-11-17 00:23:20 UTC (rev 285896) +++ branches/safari-612.3.6.2-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2021-11-17 00:29:07 UTC (rev 285897) @@ -25,7 +25,7 @@ MINOR_VERSION = 3; TINY_VERSION = 6; MICRO_VERSION = 2; -NANO_VERSION = 1; +NANO_VERSION = 2; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-612.3.6.2-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig (285896 => 285897) --- branches/safari-612.3.6.2-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig 2021-11-17 00:23:20 UTC (rev 285896) +++ branches/safari-612.3.6.2-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig 2021-11-17 00:29:07 UTC (rev 285897) @@ -25,7 +25,7 @@ MINOR_VERSION = 3; TINY_VERSION = 6; MICRO_VERSION = 2; -NANO_VERSION = 1; +NANO_VERSION = 2; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-612.3.6.2-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (285896 => 285897) --- branches/safari-612.3.6.2-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig 2021-11-17 00:23:20 UTC (rev 285896) +++ branches/safari-612.3.6.2-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig 2021-11-17 00:29:07 UTC (rev 285897) @@ -25,7 +25,7 @@ MINOR_VERSION = 3; TINY_VERSION = 6; MICRO_VERSION = 2; -NANO_VERSION = 1; +NANO_VERSION = 2; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-612.3.6.2-branch/Source/WebCore/Configurations/Version.xcconfig (285896 => 285897) --- branches/safari-612.3.6.2-branch/Source/WebCore/Configurations/Version.xcconfig 2021-11-17 00:23:20 UTC (rev 285896) +++ branches/safari-612.3.6.2-branch/Source/WebCore/Configurations/Version.xcconfig 2021-11-17 00:29:07 UTC (rev 285897) @@ -25,7 +25,7 @@ MINOR_VERSION = 3; TINY_VERSION = 6; MICRO_VERSION = 2; -NANO_VERSION = 1; +NANO_VERSION = 2; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-612.3.6.2-branch/Source/WebCore/PAL/Configurations/Version.xcconfig (285896 => 285897) --- branches/safari-612.3.6.2-branch/Source/WebCore/PAL/Configurations/Version.xcconfig 2021-11-17 00:23:20 UTC (rev 285896) +++ branches/safari-612.3.6.2-branch/Source/WebCore/PAL/Configurations/Version.xcconfig 2021-11-17 00:29:07 UTC (rev 285897) @@ -25,7 +25,7 @@ MINOR_VERSION = 3; TINY_VERSION = 6; MICRO_VERSION = 2; -NANO_VERSION = 1; +NANO_VERSION = 2; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-612.3.6.2-branch/Source/WebInspectorUI/Configurations/Version.xcconfig (285896 => 285897) --- branches/safari-612.3.6.2-branch/Source/WebInspectorUI/Configurations/Version.xcconfig 2021-11-17 00:23:20 UTC (rev 285896) +++ branches/safari-612.3.6.2-branch/Source/WebInspectorUI/Configurations/Version.xcconfig 2021-11-17 00:29:07 UTC (rev 285897) @@ -2,7 +2,7 @@ MINOR_VERSION = 3; TINY_VERSION = 6; MICRO_VERSION = 2; -NANO_VERSION = 1; +NANO_VERSION = 2; FULL_VERSION =
[webkit-changes] [285896] trunk
Title: [285896] trunk
Revision 285896
Author nvasil...@apple.com
Date 2021-11-16 16:23:20 -0800 (Tue, 16 Nov 2021)
Log Message
Web Inspector: Remove unused `dontCreateIfMissing` argument from CSSStyleDeclaration.prototype.propertyForName
https://bugs.webkit.org/show_bug.cgi?id=233198
Reviewed by Devin Rousso.
Source/WebInspectorUI:
`dontCreateIfMissing` was always set to `true`.
* UserInterface/Models/CSSStyleDeclaration.js:
(WI.CSSStyleDeclaration.prototype.propertyForName):
Drive-by: inline findMatch function, which was only used once.
* UserInterface/Models/DOMNodeStyles.js:
(WI.DOMNodeStyles.prototype._parseStylePropertyPayload):
* UserInterface/Models/Font.js:
(WI.Font):
* UserInterface/Views/BoxModelDetailsSectionRow.js:
(WI.BoxModelDetailsSectionRow.prototype._getPropertyValue):
* UserInterface/Views/SpreadsheetStyleProperty.js:
(WI.SpreadsheetStyleProperty.prototype._addVariableTokens):
LayoutTests:
* inspector/css/overridden-property.html:
* inspector/css/pseudo-element-matches-for-pseudo-element-node.html:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/inspector/css/overridden-property.html
trunk/LayoutTests/inspector/css/pseudo-element-matches-for-pseudo-element-node.html
trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/Models/CSSStyleDeclaration.js
trunk/Source/WebInspectorUI/UserInterface/Models/DOMNodeStyles.js
trunk/Source/WebInspectorUI/UserInterface/Models/Font.js
trunk/Source/WebInspectorUI/UserInterface/Views/BoxModelDetailsSectionRow.js
trunk/Source/WebInspectorUI/UserInterface/Views/SpreadsheetStyleProperty.js
Diff
Modified: trunk/LayoutTests/ChangeLog (285895 => 285896)
--- trunk/LayoutTests/ChangeLog 2021-11-17 00:14:20 UTC (rev 285895)
+++ trunk/LayoutTests/ChangeLog 2021-11-17 00:23:20 UTC (rev 285896)
@@ -1,3 +1,13 @@
+2021-11-16 Nikita Vasilyev
+
+Web Inspector: Remove unused `dontCreateIfMissing` argument from CSSStyleDeclaration.prototype.propertyForName
+https://bugs.webkit.org/show_bug.cgi?id=233198
+
+Reviewed by Devin Rousso.
+
+* inspector/css/overridden-property.html:
+* inspector/css/pseudo-element-matches-for-pseudo-element-node.html:
+
2021-11-16 Rob Buis
[css-contain] Support contain:paint
Modified: trunk/LayoutTests/inspector/css/overridden-property.html (285895 => 285896)
--- trunk/LayoutTests/inspector/css/overridden-property.html 2021-11-17 00:14:20 UTC (rev 285895)
+++ trunk/LayoutTests/inspector/css/overridden-property.html 2021-11-17 00:23:20 UTC (rev 285896)
@@ -92,11 +92,10 @@
name: "OverriddenProperty.OverriddenByShorthand",
test(resolve, reject) {
getStyleDeclaration(".longhand-overridden-by-shorthand", (style) => {
-const dontCreateIfMissing = true;
-let borderTopColorProperty = style.propertyForName("border-top-color", dontCreateIfMissing);
+let borderTopColorProperty = style.propertyForName("border-top-color");
InspectorTest.expectTrue(borderTopColorProperty.overridden, "border-top-color is overridden.");
-let borderColorProperty = style.propertyForName("border-color", dontCreateIfMissing);
+let borderColorProperty = style.propertyForName("border-color");
InspectorTest.expectFalse(borderColorProperty.overridden, "border-color is NOT overridden.");
resolve();
@@ -108,11 +107,10 @@
name: "OverriddenProperty.OverriddenByImportantShorthand",
test(resolve, reject) {
getStyleDeclaration(".longhand-overridden-by-important-shorthand", (style) => {
-const dontCreateIfMissing = true;
-let borderColorProperty = style.propertyForName("border-color", dontCreateIfMissing);
+let borderColorProperty = style.propertyForName("border-color");
InspectorTest.expectFalse(borderColorProperty.overridden, "border-color is NOT overridden.");
-let borderTopColorProperty = style.propertyForName("border-top-color", dontCreateIfMissing);
+let borderTopColorProperty = style.propertyForName("border-top-color");
InspectorTest.expectTrue(borderTopColorProperty.overridden, "border-top-color is overridden.");
resolve();
@@ -124,11 +122,10 @@
name: "OverriddenProperty.NotOverriddenByImportantLonghand",
test(resolve, reject) {
getStyleDeclaration(".shorthand-overridden-by-important-longhand", (style) => {
-const dontCreateIfMissing = true;
-let borderTopColorProperty = style.propertyForName("border-top-color", dontCreateIfMissing);
+let borderTopColorProperty = style.propertyForName("border-top-color");
InspectorTest.expectFalse(borderTopColorProperty.overridden, "border-top-color is NOT overridden.");
-let
[webkit-changes] [285895] branches/safari-613.1.9-branch/Source/WebKit
Title: [285895] branches/safari-613.1.9-branch/Source/WebKit Revision 285895 Author repst...@apple.com Date 2021-11-16 16:14:20 -0800 (Tue, 16 Nov 2021) Log Message Cherry-pick r285889. rdar://problem/85430575 Adjust graphics related message filter https://bugs.webkit.org/show_bug.cgi?id=233151 Reviewed by Brent Fulgham. Adjust graphics related message filter in the WebContent process' sandbox on iOS. This patch unifies the filter for different OS versions. * WebProcess/com.apple.WebProcess.sb.in: git-svn-id: https://svn.webkit.org/repository/webkit/trunk@285889 268f45cc-cd09-0410-ab3c-d52691b4dbfc Modified Paths branches/safari-613.1.9-branch/Source/WebKit/ChangeLog branches/safari-613.1.9-branch/Source/WebKit/WebProcess/com.apple.WebProcess.sb.in Diff Modified: branches/safari-613.1.9-branch/Source/WebKit/ChangeLog (285894 => 285895) --- branches/safari-613.1.9-branch/Source/WebKit/ChangeLog 2021-11-17 00:14:18 UTC (rev 285894) +++ branches/safari-613.1.9-branch/Source/WebKit/ChangeLog 2021-11-17 00:14:20 UTC (rev 285895) @@ -1,5 +1,36 @@ 2021-11-16 Russell Epstein +Cherry-pick r285889. rdar://problem/85430575 + +Adjust graphics related message filter +https://bugs.webkit.org/show_bug.cgi?id=233151 + + +Reviewed by Brent Fulgham. + +Adjust graphics related message filter in the WebContent process' sandbox on iOS. This patch unifies +the filter for different OS versions. + +* WebProcess/com.apple.WebProcess.sb.in: + + +git-svn-id: https://svn.webkit.org/repository/webkit/trunk@285889 268f45cc-cd09-0410-ab3c-d52691b4dbfc + +2021-11-16 Per Arne Vollan + +Adjust graphics related message filter +https://bugs.webkit.org/show_bug.cgi?id=233151 + + +Reviewed by Brent Fulgham. + +Adjust graphics related message filter in the WebContent process' sandbox on iOS. This patch unifies +the filter for different OS versions. + +* WebProcess/com.apple.WebProcess.sb.in: + +2021-11-16 Russell Epstein + Cherry-pick r285878. rdar://problem/85430575 Adjust graphics related message filter Modified: branches/safari-613.1.9-branch/Source/WebKit/WebProcess/com.apple.WebProcess.sb.in (285894 => 285895) --- branches/safari-613.1.9-branch/Source/WebKit/WebProcess/com.apple.WebProcess.sb.in 2021-11-17 00:14:18 UTC (rev 285894) +++ branches/safari-613.1.9-branch/Source/WebKit/WebProcess/com.apple.WebProcess.sb.in 2021-11-17 00:14:20 UTC (rev 285895) @@ -131,9 +131,7 @@ (iokit-method-number 0 47 -#if __MAC_OS_X_VERSION_MIN_REQUIRED >= 120300 48 -#endif ) #endif ) @@ -194,15 +192,11 @@ (if (equal? (param "CPU") "arm64") (allow iokit-external-method (iokit-method-number -#if __MAC_OS_X_VERSION_MIN_REQUIRED >= 120300 +43 44 45 +46 47 -#else -43 -44 -46 -#endif ) ) ) ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [285894] branches/safari-613.1.9-branch/Source/WebKit
Title: [285894] branches/safari-613.1.9-branch/Source/WebKit Revision 285894 Author repst...@apple.com Date 2021-11-16 16:14:18 -0800 (Tue, 16 Nov 2021) Log Message Cherry-pick r285878. rdar://problem/85430575 Adjust graphics related message filter https://bugs.webkit.org/show_bug.cgi?id=233151 Reviewed by Brent Fulgham. Adjust graphics related message filter in the WebContent process' sandbox on iOS. This patch unifies the filter for different OS versions. * Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in: * WebProcess/com.apple.WebProcess.sb.in: git-svn-id: https://svn.webkit.org/repository/webkit/trunk@285878 268f45cc-cd09-0410-ab3c-d52691b4dbfc Modified Paths branches/safari-613.1.9-branch/Source/WebKit/ChangeLog branches/safari-613.1.9-branch/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in branches/safari-613.1.9-branch/Source/WebKit/WebProcess/com.apple.WebProcess.sb.in Diff Modified: branches/safari-613.1.9-branch/Source/WebKit/ChangeLog (285893 => 285894) --- branches/safari-613.1.9-branch/Source/WebKit/ChangeLog 2021-11-16 23:53:48 UTC (rev 285893) +++ branches/safari-613.1.9-branch/Source/WebKit/ChangeLog 2021-11-17 00:14:18 UTC (rev 285894) @@ -1,3 +1,38 @@ +2021-11-16 Russell Epstein + +Cherry-pick r285878. rdar://problem/85430575 + +Adjust graphics related message filter +https://bugs.webkit.org/show_bug.cgi?id=233151 + + +Reviewed by Brent Fulgham. + +Adjust graphics related message filter in the WebContent process' sandbox on iOS. This patch unifies +the filter for different OS versions. + +* Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in: + +* WebProcess/com.apple.WebProcess.sb.in: + + +git-svn-id: https://svn.webkit.org/repository/webkit/trunk@285878 268f45cc-cd09-0410-ab3c-d52691b4dbfc + +2021-11-16 Per Arne Vollan + +Adjust graphics related message filter +https://bugs.webkit.org/show_bug.cgi?id=233151 + + +Reviewed by Brent Fulgham. + +Adjust graphics related message filter in the WebContent process' sandbox on iOS. This patch unifies +the filter for different OS versions. + +* Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in: + +* WebProcess/com.apple.WebProcess.sb.in: + 2021-11-13 Per Arne Vollan [macOS][GPUP] Remove logging of used syscalls Modified: branches/safari-613.1.9-branch/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in (285893 => 285894) --- branches/safari-613.1.9-branch/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in 2021-11-16 23:53:48 UTC (rev 285893) +++ branches/safari-613.1.9-branch/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in 2021-11-17 00:14:18 UTC (rev 285894) @@ -263,11 +263,8 @@ (allow iokit-async-external-method #if PLATFORM(IOS) (iokit-method-number -#if __IPHONE_OS_VERSION_MIN_REQUIRED < 150500 43 -#else 44 -#endif ) #endif ) @@ -292,21 +289,16 @@ 25 26 27 -#if __IPHONE_OS_VERSION_MIN_REQUIRED < 150500 36 +37 38 39 40 +41 42 +43 44 -#else -37 -39 -40 -41 -43 45 -#endif ) #endif ) Modified: branches/safari-613.1.9-branch/Source/WebKit/WebProcess/com.apple.WebProcess.sb.in (285893 => 285894) --- branches/safari-613.1.9-branch/Source/WebKit/WebProcess/com.apple.WebProcess.sb.in 2021-11-16 23:53:48 UTC (rev 285893) +++ branches/safari-613.1.9-branch/Source/WebKit/WebProcess/com.apple.WebProcess.sb.in 2021-11-17 00:14:18 UTC (rev 285894) @@ -166,10 +166,12 @@ 30 31 40 -#if __MAC_OS_X_VERSION_MIN_REQUIRED >= 120300 41 +42 43 +48 49 +256 257 258 259 @@ -180,26 +182,11 @@ 264 265 266 +267 268 269 +512 513 -#else -42 -48 -256 -257 -258 -259 -260 -261 -262 -263 -
[webkit-changes] [285893] trunk/Source
Title: [285893] trunk/Source
Revision 285893
Author nmouchta...@apple.com
Date 2021-11-16 15:53:48 -0800 (Tue, 16 Nov 2021)
Log Message
Add overscroll behavior to ScrollableAreaParameters
https://bugs.webkit.org/show_bug.cgi?id=233159
Reviewed by Simon Fraser.
Source/WebCore:
Split patch by Cathie Chen and Frederic Wang. This patch lands the addition of
horizontalOverscrollBehavior and verticalOverscrollBehavior to ScrollableAreaParameters
to track value of over scroll behavior for particular scroll node. Patches for synchronous/
asynchronous scrolling on Mac and on iOS to come.
* page/scrolling/AsyncScrollingCoordinator.cpp:
(WebCore::AsyncScrollingCoordinator::setScrollingNodeScrollableAreaGeometry):
* page/scrolling/ScrollingCoordinatorTypes.h:
(WebCore::ScrollableAreaParameters::operator== const):
* page/scrolling/ScrollingTreeScrollingNode.h:
* platform/ScrollableArea.h:
(WebCore::ScrollableArea::horizontalOverscrollBehavior const):
(WebCore::ScrollableArea::verticalOverscrollBehavior const):
* rendering/RenderLayerScrollableArea.cpp:
(WebCore::RenderLayerScrollableArea::horizontalOverscrollBehavior const):
(WebCore::RenderLayerScrollableArea::verticalOverscrollBehavior const):
* rendering/RenderLayerScrollableArea.h:
Source/WebKit:
* Shared/WebCoreArgumentCoders.cpp:
(IPC::ArgumentCoder::encode):
(IPC::ArgumentCoder::decode):
* Shared/WebCoreArgumentCoders.h:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/FrameView.cpp
trunk/Source/WebCore/page/FrameView.h
trunk/Source/WebCore/page/scrolling/AsyncScrollingCoordinator.cpp
trunk/Source/WebCore/page/scrolling/ScrollingCoordinatorTypes.h
trunk/Source/WebCore/platform/ScrollableArea.h
trunk/Source/WebCore/rendering/RenderLayerScrollableArea.cpp
trunk/Source/WebCore/rendering/RenderLayerScrollableArea.h
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Shared/WebCoreArgumentCoders.cpp
trunk/Source/WebKit/Shared/WebCoreArgumentCoders.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (285892 => 285893)
--- trunk/Source/WebCore/ChangeLog 2021-11-16 22:58:57 UTC (rev 285892)
+++ trunk/Source/WebCore/ChangeLog 2021-11-16 23:53:48 UTC (rev 285893)
@@ -1,3 +1,28 @@
+2021-11-16 Nikolaos Mouchtaris
+
+Add overscroll behavior to ScrollableAreaParameters
+https://bugs.webkit.org/show_bug.cgi?id=233159
+
+Reviewed by Simon Fraser.
+
+Split patch by Cathie Chen and Frederic Wang. This patch lands the addition of
+horizontalOverscrollBehavior and verticalOverscrollBehavior to ScrollableAreaParameters
+to track value of over scroll behavior for particular scroll node. Patches for synchronous/
+asynchronous scrolling on Mac and on iOS to come.
+
+* page/scrolling/AsyncScrollingCoordinator.cpp:
+(WebCore::AsyncScrollingCoordinator::setScrollingNodeScrollableAreaGeometry):
+* page/scrolling/ScrollingCoordinatorTypes.h:
+(WebCore::ScrollableAreaParameters::operator== const):
+* page/scrolling/ScrollingTreeScrollingNode.h:
+* platform/ScrollableArea.h:
+(WebCore::ScrollableArea::horizontalOverscrollBehavior const):
+(WebCore::ScrollableArea::verticalOverscrollBehavior const):
+* rendering/RenderLayerScrollableArea.cpp:
+(WebCore::RenderLayerScrollableArea::horizontalOverscrollBehavior const):
+(WebCore::RenderLayerScrollableArea::verticalOverscrollBehavior const):
+* rendering/RenderLayerScrollableArea.h:
+
2021-11-16 Rob Buis
[css-contain] Support contain:paint
Modified: trunk/Source/WebCore/page/FrameView.cpp (285892 => 285893)
--- trunk/Source/WebCore/page/FrameView.cpp 2021-11-16 22:58:57 UTC (rev 285892)
+++ trunk/Source/WebCore/page/FrameView.cpp 2021-11-16 23:53:48 UTC (rev 285893)
@@ -5739,6 +5739,24 @@
verticalScrollbar()->setSteps(Scrollbar::pixelsPerLineStep(), pageStep);
}
}
+
+OverscrollBehavior FrameView::horizontalOverscrollBehavior() const
+{
+auto* document = frame().document();
+auto scrollingObject = document && document->documentElement() ? document->documentElement()->renderer() : nullptr;
+if (scrollingObject && renderView() && renderView()->canBeScrolledAndHasScrollableArea())
+return scrollingObject->style().overscrollBehaviorX();
+return OverscrollBehavior::Auto;
+}
+
+OverscrollBehavior FrameView::verticalOverscrollBehavior() const
+{
+auto* document = frame().document();
+auto scrollingObject = document && document->documentElement() ? document->documentElement()->renderer() : nullptr;
+if (scrollingObject && renderView() && renderView()->canBeScrolledAndHasScrollableArea())
+return scrollingObject->style().overscrollBehaviorY();
+return OverscrollBehavior::Auto;
+}
} // namespace WebCore
#undef PAGE_ID
Modified: trunk/Source/WebCore/page/FrameView.h (285892 => 285893)
--- trunk/Source/WebCore/page/FrameView.h 2021-11-16 22:58:57 UTC (rev 285892)
+++
[webkit-changes] [285892] branches/safari-612.3.6.1-branch
Title: [285892] branches/safari-612.3.6.1-branch Revision 285892 Author repst...@apple.com Date 2021-11-16 14:58:57 -0800 (Tue, 16 Nov 2021) Log Message Cherry-pick r285823. rdar://problem/85236459 `Cross-Origin-Embedder-Policy: require-corp` prevents loading of data URL images https://bugs.webkit.org/show_bug.cgi?id=233131 Reviewed by Geoffrey Garen. Source/WebCore: When doing an initial data URL load, we properly wouldn't perform a cross-origin resource policy check. This is per the Fetch specification that says to use a scheme fetch [1] when the request URL is a data URL. When the protocol is data, the scheme fetch algorithm would return a response without performing an HTTP Fetch. The HTTP check [2] is the algorithm that actually performs a cross-origin resource policy check, at step 7. The issue with our implementation was that data URL loads would perform a cross-origin resource policy check in the case where the image is loaded from our memory cache, due to a check we had in CachedResourceLoader::requestResource(). As a result, data URL loads would fail when served from the memory cache, when CORP is enforced. To address the issue and match the specification, we now disable this CORP check when the request URL is a data URL. [1] https://fetch.spec.whatwg.org/#scheme-fetch [2] https://fetch.spec.whatwg.org/#concept-http-fetch Test: http/wpt/html/cross-origin-embedder-policy/require-corp-data-url.html * loader/cache/CachedResourceLoader.cpp: (WebCore::CachedResourceLoader::requestResource): LayoutTests: Add layout test coverage. This test is based on a reduce test case from Cameron McCormack. * http/wpt/html/cross-origin-embedder-policy/require-corp-data-url-expected.txt: Added. * http/wpt/html/cross-origin-embedder-policy/require-corp-data-url.html: Added. * http/wpt/html/cross-origin-embedder-policy/require-corp-data-url.html.headers: Added. git-svn-id: https://svn.webkit.org/repository/webkit/trunk@285823 268f45cc-cd09-0410-ab3c-d52691b4dbfc Modified Paths branches/safari-612.3.6.1-branch/LayoutTests/ChangeLog branches/safari-612.3.6.1-branch/Source/WebCore/ChangeLog branches/safari-612.3.6.1-branch/Source/WebCore/loader/cache/CachedResourceLoader.cpp Added Paths branches/safari-612.3.6.1-branch/LayoutTests/http/wpt/html/cross-origin-embedder-policy/require-corp-data-url-expected.txt branches/safari-612.3.6.1-branch/LayoutTests/http/wpt/html/cross-origin-embedder-policy/require-corp-data-url.html branches/safari-612.3.6.1-branch/LayoutTests/http/wpt/html/cross-origin-embedder-policy/require-corp-data-url.html.headers Diff Modified: branches/safari-612.3.6.1-branch/LayoutTests/ChangeLog (285891 => 285892) --- branches/safari-612.3.6.1-branch/LayoutTests/ChangeLog 2021-11-16 22:57:24 UTC (rev 285891) +++ branches/safari-612.3.6.1-branch/LayoutTests/ChangeLog 2021-11-16 22:58:57 UTC (rev 285892) @@ -1,3 +1,60 @@ +2021-11-16 Russell Epstein + +Cherry-pick r285823. rdar://problem/85236459 + +`Cross-Origin-Embedder-Policy: require-corp` prevents loading of data URL images +https://bugs.webkit.org/show_bug.cgi?id=233131 + + +Reviewed by Geoffrey Garen. + +Source/WebCore: + +When doing an initial data URL load, we properly wouldn't perform a cross-origin resource policy check. +This is per the Fetch specification that says to use a scheme fetch [1] when the request URL is a data URL. +When the protocol is data, the scheme fetch algorithm would return a response without performing an HTTP +Fetch. The HTTP check [2] is the algorithm that actually performs a cross-origin resource policy check, at +step 7. + +The issue with our implementation was that data URL loads would perform a cross-origin resource policy +check in the case where the image is loaded from our memory cache, due to a check we had in +CachedResourceLoader::requestResource(). As a result, data URL loads would fail when served from the +memory cache, when CORP is enforced. To address the issue and match the specification, we now disable this +CORP check when the request URL is a data URL. + +[1] https://fetch.spec.whatwg.org/#scheme-fetch +[2] https://fetch.spec.whatwg.org/#concept-http-fetch + +Test: http/wpt/html/cross-origin-embedder-policy/require-corp-data-url.html + +* loader/cache/CachedResourceLoader.cpp: +(WebCore::CachedResourceLoader::requestResource): + +LayoutTests: + +Add layout test coverage. This test is based on a reduce test case from Cameron McCormack. + +* http/wpt/html/cross-origin-embedder-policy/require-corp-data-url-expected.txt: Added. +* http/wpt/html/cross-origin-embedder-policy/require-corp-data-url.html: Added. +* http/wpt/html/cross-origin-embedder-policy/require-corp-data-url.html.headers: Added. + + +
[webkit-changes] [285891] branches/safari-612.3.6.1-branch/Source/WebKit
Title: [285891] branches/safari-612.3.6.1-branch/Source/WebKit
Revision 285891
Author repst...@apple.com
Date 2021-11-16 14:57:24 -0800 (Tue, 16 Nov 2021)
Log Message
Cherry-pick r283386. rdar://problem/83953959
Protect WebFrame during invalidatePolicyListener()
https://bugs.webkit.org/show_bug.cgi?id=229981
Reviewed by Alex Christensen.
* WebProcess/WebPage/WebFrame.cpp:
(WebKit::WebFrame::invalidatePolicyListeners): Protect the WebFrame while
policy handlers are run.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@283386 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Modified Paths
branches/safari-612.3.6.1-branch/Source/WebKit/ChangeLog
branches/safari-612.3.6.1-branch/Source/WebKit/WebProcess/WebPage/WebFrame.cpp
Diff
Modified: branches/safari-612.3.6.1-branch/Source/WebKit/ChangeLog (285890 => 285891)
--- branches/safari-612.3.6.1-branch/Source/WebKit/ChangeLog 2021-11-16 22:55:52 UTC (rev 285890)
+++ branches/safari-612.3.6.1-branch/Source/WebKit/ChangeLog 2021-11-16 22:57:24 UTC (rev 285891)
@@ -1,3 +1,31 @@
+2021-11-16 Kocsen Chung
+
+Cherry-pick r283386. rdar://problem/83953959
+
+Protect WebFrame during invalidatePolicyListener()
+https://bugs.webkit.org/show_bug.cgi?id=229981
+
+
+Reviewed by Alex Christensen.
+
+* WebProcess/WebPage/WebFrame.cpp:
+(WebKit::WebFrame::invalidatePolicyListeners): Protect the WebFrame while
+policy handlers are run.
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@283386 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2021-10-01 Brent Fulgham
+
+Protect WebFrame during invalidatePolicyListener()
+https://bugs.webkit.org/show_bug.cgi?id=229981
+
+
+Reviewed by Alex Christensen.
+
+* WebProcess/WebPage/WebFrame.cpp:
+(WebKit::WebFrame::invalidatePolicyListeners): Protect the WebFrame while
+policy handlers are run.
+
2021-11-12 Russell Epstein
Revert r285690. rdar://problem/83381842
Modified: branches/safari-612.3.6.1-branch/Source/WebKit/WebProcess/WebPage/WebFrame.cpp (285890 => 285891)
--- branches/safari-612.3.6.1-branch/Source/WebKit/WebProcess/WebPage/WebFrame.cpp 2021-11-16 22:55:52 UTC (rev 285890)
+++ branches/safari-612.3.6.1-branch/Source/WebKit/WebProcess/WebPage/WebFrame.cpp 2021-11-16 22:57:24 UTC (rev 285891)
@@ -237,6 +237,8 @@
void WebFrame::invalidatePolicyListener()
{
+Ref protectedThis { *this };
+
if (!m_policyListenerID)
return;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [285890] trunk/Tools
Title: [285890] trunk/Tools
Revision 285890
Author jbed...@apple.com
Date 2021-11-16 14:55:52 -0800 (Tue, 16 Nov 2021)
Log Message
[git-webkit] Mark landed changes as merged
https://bugs.webkit.org/show_bug.cgi?id=233056
Reviewed by Dewei Zhu.
For BitBucket and GitHub to recognize a pull-request as merged, the target
branch must be updated with the exact commit to be merged as the merge occurs.
* Scripts/libraries/webkitscmpy/setup.py: Bump version.
* Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py: Ditto.
* Scripts/libraries/webkitscmpy/webkitscmpy/program/land.py:
(Land.main): Update source branch when merging commits to target branch.
* Scripts/libraries/webkitscmpy/webkitscmpy/remote/bitbucket.py:
(BitBucket.PRGenerator.update): Only delete values if they exist.
* Scripts/libraries/webkitscmpy/webkitscmpy/test/land_unittest.py:
(TestLand):
(TestLandGitHub):
(TestLandBitBucket):
Canonical link: https://commits.webkit.org/244312@main
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/land.py
trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/remote/bitbucket.py
trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/test/land_unittest.py
Diff
Modified: trunk/Tools/ChangeLog (285889 => 285890)
--- trunk/Tools/ChangeLog 2021-11-16 22:53:58 UTC (rev 285889)
+++ trunk/Tools/ChangeLog 2021-11-16 22:55:52 UTC (rev 285890)
@@ -1,3 +1,25 @@
+2021-11-12 Jonathan Bedard
+
+[git-webkit] Mark landed changes as merged
+https://bugs.webkit.org/show_bug.cgi?id=233056
+
+
+Reviewed by Dewei Zhu.
+
+For BitBucket and GitHub to recognize a pull-request as merged, the target
+branch must be updated with the exact commit to be merged as the merge occurs.
+
+* Scripts/libraries/webkitscmpy/setup.py: Bump version.
+* Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py: Ditto.
+* Scripts/libraries/webkitscmpy/webkitscmpy/program/land.py:
+(Land.main): Update source branch when merging commits to target branch.
+* Scripts/libraries/webkitscmpy/webkitscmpy/remote/bitbucket.py:
+(BitBucket.PRGenerator.update): Only delete values if they exist.
+* Scripts/libraries/webkitscmpy/webkitscmpy/test/land_unittest.py:
+(TestLand):
+(TestLandGitHub):
+(TestLandBitBucket):
+
2021-11-16 Chris Dumez
Crash under WebKit::WebPageProxy::commitProvisionalPage()
Modified: trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/land.py (285889 => 285890)
--- trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/land.py 2021-11-16 22:53:58 UTC (rev 285889)
+++ trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/land.py 2021-11-16 22:55:52 UTC (rev 285890)
@@ -27,9 +27,10 @@
from .canonicalize import Canonicalize
from .command import Command
from .branch import Branch
+from .pull_request import PullRequest
from argparse import Namespace
from webkitcorepy import arguments, run, string_utils, Terminal
-from webkitscmpy import local, log
+from webkitscmpy import local, log, remote
class Land(Command):
@@ -75,11 +76,12 @@
sys.stderr.write("Cannot 'land' on a canonical SVN repository that is not configured as git-svn\n")
return 1
-if not Branch.editable(repository.branch, repository=repository):
+source_branch = repository.branch
+if not Branch.editable(source_branch, repository=repository):
sys.stderr.write("Can only 'land' editable branches\n")
return 1
branch_point = Branch.branch_point(repository)
-commits = list(repository.commits(begin=dict(hash=branch_point.hash), end=dict(branch=repository.branch)))
+commits = list(repository.commits(begin=dict(hash=branch_point.hash), end=dict(branch=source_branch)))
if not commits:
sys.stderr.write('Failed to find commits to land\n')
return 1
@@ -87,11 +89,11 @@
pull_request = None
rmt = repository.remote()
if rmt and rmt.pull_requests:
-candidates = list(rmt.pull_requests.find(opened=True, head=repository.branch))
+candidates = list(rmt.pull_requests.find(opened=True, head=source_branch))
if len(candidates) == 1:
pull_request = candidates[0]
elif candidates:
-sys.stderr.write("Multiple pull-request match '{}'\n".format(repository.branch))
+sys.stderr.write("Multiple pull-request match '{}'\n".format(source_branch))
if pull_request and args.review:
if pull_request.blockers:
@@ -118,17 +120,17 @@
'--env-filter', "GIT_AUTHOR_DATE='{date}';GIT_COMMITTER_DATE='{date}'".format(
date='{} -{}'.format(int(time.time()), repository.gmtoffset())
), '--msg-filter', 'sed "s/NOBODY
[webkit-changes] [285889] trunk/Source/WebKit
Title: [285889] trunk/Source/WebKit Revision 285889 Author pvol...@apple.com Date 2021-11-16 14:53:58 -0800 (Tue, 16 Nov 2021) Log Message Adjust graphics related message filter https://bugs.webkit.org/show_bug.cgi?id=233151 Reviewed by Brent Fulgham. Adjust graphics related message filter in the WebContent process' sandbox on iOS. This patch unifies the filter for different OS versions. * WebProcess/com.apple.WebProcess.sb.in: Modified Paths trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/WebProcess/com.apple.WebProcess.sb.in Diff Modified: trunk/Source/WebKit/ChangeLog (285888 => 285889) --- trunk/Source/WebKit/ChangeLog 2021-11-16 22:53:14 UTC (rev 285888) +++ trunk/Source/WebKit/ChangeLog 2021-11-16 22:53:58 UTC (rev 285889) @@ -1,5 +1,18 @@ 2021-11-16 Per Arne Vollan +Adjust graphics related message filter +https://bugs.webkit.org/show_bug.cgi?id=233151 + + +Reviewed by Brent Fulgham. + +Adjust graphics related message filter in the WebContent process' sandbox on iOS. This patch unifies +the filter for different OS versions. + +* WebProcess/com.apple.WebProcess.sb.in: + +2021-11-16 Per Arne Vollan + [iOS] Limit graphics related IOKit method filtering https://bugs.webkit.org/show_bug.cgi?id=233209 Modified: trunk/Source/WebKit/WebProcess/com.apple.WebProcess.sb.in (285888 => 285889) --- trunk/Source/WebKit/WebProcess/com.apple.WebProcess.sb.in 2021-11-16 22:53:14 UTC (rev 285888) +++ trunk/Source/WebKit/WebProcess/com.apple.WebProcess.sb.in 2021-11-16 22:53:58 UTC (rev 285889) @@ -131,9 +131,7 @@ (iokit-method-number 0 47 -#if __MAC_OS_X_VERSION_MIN_REQUIRED >= 120300 48 -#endif ) #endif ) @@ -194,15 +192,11 @@ (if (equal? (param "CPU") "arm64") (allow iokit-external-method (iokit-method-number -#if __MAC_OS_X_VERSION_MIN_REQUIRED >= 120300 +43 44 45 +46 47 -#else -43 -44 -46 -#endif ) ) ) ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [285888] branches/safari-612.3.6.1-branch/Source
Title: [285888] branches/safari-612.3.6.1-branch/Source Revision 285888 Author repst...@apple.com Date 2021-11-16 14:53:14 -0800 (Tue, 16 Nov 2021) Log Message Versioning. WebKit-7612.3.6.1.3 Modified Paths branches/safari-612.3.6.1-branch/Source/_javascript_Core/Configurations/Version.xcconfig branches/safari-612.3.6.1-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig branches/safari-612.3.6.1-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig branches/safari-612.3.6.1-branch/Source/WebCore/Configurations/Version.xcconfig branches/safari-612.3.6.1-branch/Source/WebCore/PAL/Configurations/Version.xcconfig branches/safari-612.3.6.1-branch/Source/WebInspectorUI/Configurations/Version.xcconfig branches/safari-612.3.6.1-branch/Source/WebKit/Configurations/Version.xcconfig branches/safari-612.3.6.1-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig Diff Modified: branches/safari-612.3.6.1-branch/Source/_javascript_Core/Configurations/Version.xcconfig (285887 => 285888) --- branches/safari-612.3.6.1-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2021-11-16 22:47:03 UTC (rev 285887) +++ branches/safari-612.3.6.1-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2021-11-16 22:53:14 UTC (rev 285888) @@ -25,7 +25,7 @@ MINOR_VERSION = 3; TINY_VERSION = 6; MICRO_VERSION = 1; -NANO_VERSION = 2; +NANO_VERSION = 3; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-612.3.6.1-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig (285887 => 285888) --- branches/safari-612.3.6.1-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig 2021-11-16 22:47:03 UTC (rev 285887) +++ branches/safari-612.3.6.1-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig 2021-11-16 22:53:14 UTC (rev 285888) @@ -25,7 +25,7 @@ MINOR_VERSION = 3; TINY_VERSION = 6; MICRO_VERSION = 1; -NANO_VERSION = 2; +NANO_VERSION = 3; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-612.3.6.1-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (285887 => 285888) --- branches/safari-612.3.6.1-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig 2021-11-16 22:47:03 UTC (rev 285887) +++ branches/safari-612.3.6.1-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig 2021-11-16 22:53:14 UTC (rev 285888) @@ -25,7 +25,7 @@ MINOR_VERSION = 3; TINY_VERSION = 6; MICRO_VERSION = 1; -NANO_VERSION = 2; +NANO_VERSION = 3; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-612.3.6.1-branch/Source/WebCore/Configurations/Version.xcconfig (285887 => 285888) --- branches/safari-612.3.6.1-branch/Source/WebCore/Configurations/Version.xcconfig 2021-11-16 22:47:03 UTC (rev 285887) +++ branches/safari-612.3.6.1-branch/Source/WebCore/Configurations/Version.xcconfig 2021-11-16 22:53:14 UTC (rev 285888) @@ -25,7 +25,7 @@ MINOR_VERSION = 3; TINY_VERSION = 6; MICRO_VERSION = 1; -NANO_VERSION = 2; +NANO_VERSION = 3; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-612.3.6.1-branch/Source/WebCore/PAL/Configurations/Version.xcconfig (285887 => 285888) --- branches/safari-612.3.6.1-branch/Source/WebCore/PAL/Configurations/Version.xcconfig 2021-11-16 22:47:03 UTC (rev 285887) +++ branches/safari-612.3.6.1-branch/Source/WebCore/PAL/Configurations/Version.xcconfig 2021-11-16 22:53:14 UTC (rev 285888) @@ -25,7 +25,7 @@ MINOR_VERSION = 3; TINY_VERSION = 6; MICRO_VERSION = 1; -NANO_VERSION = 2; +NANO_VERSION = 3; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-612.3.6.1-branch/Source/WebInspectorUI/Configurations/Version.xcconfig (285887 => 285888) --- branches/safari-612.3.6.1-branch/Source/WebInspectorUI/Configurations/Version.xcconfig 2021-11-16 22:47:03 UTC (rev 285887) +++ branches/safari-612.3.6.1-branch/Source/WebInspectorUI/Configurations/Version.xcconfig 2021-11-16 22:53:14 UTC (rev 285888) @@ -2,7 +2,7 @@ MINOR_VERSION = 3; TINY_VERSION = 6; MICRO_VERSION = 1; -NANO_VERSION = 2; +NANO_VERSION = 3; FULL_VERSION =
[webkit-changes] [285887] branches/safari-612.3.6.0-branch/Source/WebKit/WebProcess/WebPage /WebFrame.cpp
Title: [285887] branches/safari-612.3.6.0-branch/Source/WebKit/WebProcess/WebPage/WebFrame.cpp
Revision 285887
Author repst...@apple.com
Date 2021-11-16 14:47:03 -0800 (Tue, 16 Nov 2021)
Log Message
Unreviewed integration fix. rdar://83953959
Modified Paths
branches/safari-612.3.6.0-branch/Source/WebKit/WebProcess/WebPage/WebFrame.cpp
Diff
Modified: branches/safari-612.3.6.0-branch/Source/WebKit/WebProcess/WebPage/WebFrame.cpp (285886 => 285887)
--- branches/safari-612.3.6.0-branch/Source/WebKit/WebProcess/WebPage/WebFrame.cpp 2021-11-16 22:46:04 UTC (rev 285886)
+++ branches/safari-612.3.6.0-branch/Source/WebKit/WebProcess/WebPage/WebFrame.cpp 2021-11-16 22:47:03 UTC (rev 285887)
@@ -239,6 +239,9 @@
{
Ref protectedThis { *this };
+if (!m_policyListenerID)
+return;
+
m_policyDownloadID = { };
m_policyListenerID = 0;
auto identifier = m_policyIdentifier;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [285886] trunk/Source/WebKit
Title: [285886] trunk/Source/WebKit
Revision 285886
Author pvol...@apple.com
Date 2021-11-16 14:46:04 -0800 (Tue, 16 Nov 2021)
Log Message
[iOS] Limit graphics related IOKit method filtering
https://bugs.webkit.org/show_bug.cgi?id=233209
Reviewed by Brent Fulgham.
Limit graphics related IOKit method filtering based on OS version. This patch also adds an entitlement which
will enable a replacement for the disabled filtering.
* Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in:
* Scripts/process-entitlements.sh:
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in
trunk/Source/WebKit/Scripts/process-entitlements.sh
Diff
Modified: trunk/Source/WebKit/ChangeLog (285885 => 285886)
--- trunk/Source/WebKit/ChangeLog 2021-11-16 22:32:39 UTC (rev 285885)
+++ trunk/Source/WebKit/ChangeLog 2021-11-16 22:46:04 UTC (rev 285886)
@@ -1,3 +1,17 @@
+2021-11-16 Per Arne Vollan
+
+[iOS] Limit graphics related IOKit method filtering
+https://bugs.webkit.org/show_bug.cgi?id=233209
+
+
+Reviewed by Brent Fulgham.
+
+Limit graphics related IOKit method filtering based on OS version. This patch also adds an entitlement which
+will enable a replacement for the disabled filtering.
+
+* Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in:
+* Scripts/process-entitlements.sh:
+
2021-11-16 Myles C. Maxfield
[WebGPU] Start preparing for serializing commands to the GPU process
Modified: trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in (285885 => 285886)
--- trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in 2021-11-16 22:32:39 UTC (rev 285885)
+++ trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in 2021-11-16 22:46:04 UTC (rev 285886)
@@ -261,7 +261,7 @@
iokit-external-method
)
(allow iokit-async-external-method
-#if PLATFORM(IOS)
+#if PLATFORM(IOS) && __IPHONE_OS_VERSION_MIN_REQUIRED < 16
(iokit-method-number
43
44
@@ -269,7 +269,7 @@
#endif
)
(allow iokit-external-method
-#if PLATFORM(IOS)
+#if PLATFORM(IOS) && __IPHONE_OS_VERSION_MIN_REQUIRED < 16
(iokit-method-number
0
2
Modified: trunk/Source/WebKit/Scripts/process-entitlements.sh (285885 => 285886)
--- trunk/Source/WebKit/Scripts/process-entitlements.sh 2021-11-16 22:32:39 UTC (rev 285885)
+++ trunk/Source/WebKit/Scripts/process-entitlements.sh 2021-11-16 22:46:04 UTC (rev 285886)
@@ -32,6 +32,10 @@
then
plistbuddy add :com.apple.coreaudio.allow-vorbis-decode bool YES
fi
+if (( "${TARGET_MAC_OS_X_VERSION_MAJOR}" >= 13 ))
+then
+plistbuddy Add :com.apple.private.gpu-restricted bool YES
+fi
fi
mac_process_webcontent_or_plugin_entitlements
@@ -61,6 +65,11 @@
plistbuddy Add :com.apple.security.cs.jit-write-allowlist bool YES
fi
+if (( "${TARGET_MAC_OS_X_VERSION_MAJOR}" >= 13 ))
+then
+plistbuddy Add :com.apple.private.gpu-restricted bool YES
+fi
+
plistbuddy Add :com.apple.private.memory.ownership_transfer bool YES
plistbuddy Add :com.apple.private.webkit.use-xpc-endpoint bool YES
plistbuddy Add :com.apple.rootless.storage.WebKitGPUSandbox bool YES
@@ -280,6 +289,7 @@
plistbuddy Add :com.apple.private.allow-explicit-graphics-priority bool YES
plistbuddy Add :com.apple.private.coremedia.extensions.audiorecording.allow bool YES
plistbuddy Add :com.apple.private.coremedia.pidinheritance.allow bool YES
+plistbuddy Add :com.apple.private.gpu-restricted bool YES
plistbuddy Add :com.apple.private.memorystatus bool YES
plistbuddy Add :com.apple.private.network.socket-delegate bool YES
plistbuddy Add :com.apple.private.pac.exception bool YES
@@ -308,6 +318,7 @@
plistbuddy Add :com.apple.mediaremote.set-playback-state bool YES
plistbuddy Add :com.apple.private.allow-explicit-graphics-priority bool YES
plistbuddy Add :com.apple.private.coremedia.extensions.audiorecording.allow bool YES
+plistbuddy Add :com.apple.private.gpu-restricted bool YES
plistbuddy Add :com.apple.private.mediaexperience.startrecordinginthebackground.allow bool YES
plistbuddy Add :com.apple.private.mediaexperience.processassertionaudittokens.allow bool YES
plistbuddy Add :com.apple.private.coremedia.pidinheritance.allow bool YES
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [285885] trunk
Title: [285885] trunk Revision 285885 Author commit-qu...@webkit.org Date 2021-11-16 14:32:39 -0800 (Tue, 16 Nov 2021) Log Message [css-contain] Support contain:paint https://bugs.webkit.org/show_bug.cgi?id=224742 Patch by Rob Buis on 2021-11-16 Reviewed by Alan Bujtas. LayoutTests/imported/w3c: Adjust test expectation now that contain: strict is supported. * web-platform-tests/css/css-flexbox/flex-item-contains-strict-expected.txt: Source/WebCore: This patch implements paint containment as specified[1]. It adds shouldApplyPaintContainment to check whether the element applies for paint containment. Is so, then: - an independent formatting context is established. - an absolute positioning and fixed positioning containing block is established. - a stacking context is created. - implements clipping on the overflow clip edge. This patch also adds effectiveOverflowX/effectiveOverflowY on RenderElement to take the effect of paint containment on overflow-x/y into account. [1] https://drafts.csswg.org/css-contain-2/#paint-containment * page/FrameView.cpp: (WebCore::FrameView::applyOverflowToViewport): (WebCore::FrameView::applyPaginationToViewport): (WebCore::FrameView::calculateScrollbarModesForLayout): * rendering/GridTrackSizingAlgorithm.cpp: (WebCore::GridTrackSizingAlgorithmStrategy::minSizeForChild const): * rendering/RenderBox.cpp: (WebCore::RenderBox::updateFromStyle): (WebCore::RenderBox::constrainLogicalWidthInFragmentByMinMax const): (WebCore::RenderBox::constrainLogicalHeightByMinMax const): (WebCore::RenderBox::createsNewFormattingContext const): (WebCore::RenderBox::addOverflowFromChild): * rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::updateFromStyle): * rendering/RenderElement.cpp: (WebCore::includeNonFixedHeight): (WebCore::RenderElement::effectiveOverflowX const): (WebCore::RenderElement::effectiveOverflowY const): * rendering/RenderElement.h: (WebCore::RenderElement::effectiveOverflowInlineDirection const): (WebCore::RenderElement::effectiveOverflowBlockDirection const): (WebCore::RenderElement::canContainFixedPositionObjects const): (WebCore::RenderElement::canContainAbsolutelyPositionedObjects const): * rendering/RenderFlexibleBox.cpp: (WebCore::RenderFlexibleBox::mainAxisOverflowForChild const): (WebCore::RenderFlexibleBox::crossAxisOverflowForChild const): * rendering/RenderFragmentContainer.cpp: (WebCore::RenderFragmentContainer::overflowRectForFragmentedFlowPortion): * rendering/RenderInline.h: * rendering/RenderLayer.cpp: (WebCore::canCreateStackingContext): (WebCore::RenderLayer::shouldBeCSSStackingContext const): (WebCore::RenderLayer::setAncestorChainHasSelfPaintingLayerDescendant): (WebCore::RenderLayer::setAncestorChainHasVisibleDescendant): (WebCore::RenderLayer::calculateClipRects const): * rendering/RenderObject.cpp: (WebCore::RenderObject::setPaintContainmentApplies): (WebCore::RenderObject::RenderObjectRareData::RenderObjectRareData): (WebCore::shouldApplyPaintContainment): * rendering/RenderObject.h: (WebCore::RenderObject::paintContainmentApplies const): * rendering/style/RenderStyle.h: (WebCore::RenderStyle::overflowY const): (WebCore::RenderStyle::containsPaint const): (WebCore::RenderStyle::overflowInlineDirection const): Deleted. (WebCore::RenderStyle::overflowBlockDirection const): Deleted. * rendering/svg/RenderSVGRoot.cpp: (WebCore::RenderSVGRoot::shouldApplyViewportClip const): LayoutTests: Unskip tests that pass now. * TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/TestExpectations trunk/LayoutTests/imported/w3c/ChangeLog trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-flexbox/flex-item-contains-strict-expected.txt trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/page/FrameView.cpp trunk/Source/WebCore/rendering/GridTrackSizingAlgorithm.cpp trunk/Source/WebCore/rendering/RenderBox.cpp trunk/Source/WebCore/rendering/RenderBoxModelObject.cpp trunk/Source/WebCore/rendering/RenderElement.cpp trunk/Source/WebCore/rendering/RenderElement.h trunk/Source/WebCore/rendering/RenderFlexibleBox.cpp trunk/Source/WebCore/rendering/RenderFragmentContainer.cpp trunk/Source/WebCore/rendering/RenderInline.h trunk/Source/WebCore/rendering/RenderLayer.cpp trunk/Source/WebCore/rendering/RenderObject.cpp trunk/Source/WebCore/rendering/RenderObject.h trunk/Source/WebCore/rendering/style/RenderStyle.h trunk/Source/WebCore/rendering/svg/RenderSVGRoot.cpp Diff Modified: trunk/LayoutTests/ChangeLog (285884 => 285885) --- trunk/LayoutTests/ChangeLog 2021-11-16 22:19:49 UTC (rev 285884) +++ trunk/LayoutTests/ChangeLog 2021-11-16 22:32:39 UTC (rev 285885) @@ -1,3 +1,14 @@ +2021-11-16 Rob Buis + +[css-contain] Support contain:paint +https://bugs.webkit.org/show_bug.cgi?id=224742 + +Reviewed by Alan Bujtas. + +Unskip tests that pass now. + +* TestExpectations: + 2021-11-16 Tyler Wilcock AX: Simplify tests changed in
[webkit-changes] [285884] branches/safari-612.3.6.0-branch/Source/WebKit
Title: [285884] branches/safari-612.3.6.0-branch/Source/WebKit
Revision 285884
Author repst...@apple.com
Date 2021-11-16 14:19:49 -0800 (Tue, 16 Nov 2021)
Log Message
Cherry-pick r283386. rdar://problem/83953959
Protect WebFrame during invalidatePolicyListener()
https://bugs.webkit.org/show_bug.cgi?id=229981
Reviewed by Alex Christensen.
* WebProcess/WebPage/WebFrame.cpp:
(WebKit::WebFrame::invalidatePolicyListeners): Protect the WebFrame while
policy handlers are run.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@283386 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Modified Paths
branches/safari-612.3.6.0-branch/Source/WebKit/ChangeLog
branches/safari-612.3.6.0-branch/Source/WebKit/WebProcess/WebPage/WebFrame.cpp
Diff
Modified: branches/safari-612.3.6.0-branch/Source/WebKit/ChangeLog (285883 => 285884)
--- branches/safari-612.3.6.0-branch/Source/WebKit/ChangeLog 2021-11-16 22:05:01 UTC (rev 285883)
+++ branches/safari-612.3.6.0-branch/Source/WebKit/ChangeLog 2021-11-16 22:19:49 UTC (rev 285884)
@@ -1,3 +1,31 @@
+2021-11-16 Russell Epstein
+
+Cherry-pick r283386. rdar://problem/83953959
+
+Protect WebFrame during invalidatePolicyListener()
+https://bugs.webkit.org/show_bug.cgi?id=229981
+
+
+Reviewed by Alex Christensen.
+
+* WebProcess/WebPage/WebFrame.cpp:
+(WebKit::WebFrame::invalidatePolicyListeners): Protect the WebFrame while
+policy handlers are run.
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@283386 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2021-10-01 Brent Fulgham
+
+Protect WebFrame during invalidatePolicyListener()
+https://bugs.webkit.org/show_bug.cgi?id=229981
+
+
+Reviewed by Alex Christensen.
+
+* WebProcess/WebPage/WebFrame.cpp:
+(WebKit::WebFrame::invalidatePolicyListeners): Protect the WebFrame while
+policy handlers are run.
+
2021-11-12 Babak Shafiei
Revert r285683. rdar://problem/83381842
Modified: branches/safari-612.3.6.0-branch/Source/WebKit/WebProcess/WebPage/WebFrame.cpp (285883 => 285884)
--- branches/safari-612.3.6.0-branch/Source/WebKit/WebProcess/WebPage/WebFrame.cpp 2021-11-16 22:05:01 UTC (rev 285883)
+++ branches/safari-612.3.6.0-branch/Source/WebKit/WebProcess/WebPage/WebFrame.cpp 2021-11-16 22:19:49 UTC (rev 285884)
@@ -237,8 +237,7 @@
void WebFrame::invalidatePolicyListener()
{
-if (!m_policyListenerID)
-return;
+Ref protectedThis { *this };
m_policyDownloadID = { };
m_policyListenerID = 0;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [285883] trunk/Source/WebCore
Title: [285883] trunk/Source/WebCore
Revision 285883
Author simon.fra...@apple.com
Date 2021-11-16 14:05:01 -0800 (Tue, 16 Nov 2021)
Log Message
Use IOHIDEvent timestamps for momentum velocity computation
https://bugs.webkit.org/show_bug.cgi?id=233168
Reviewed by Tim Horton.
NSEvent timetamps can have some jitter on some devices (rdar://85309639) so drop
down to IOHIDEvent timestamps when computing the initial velocity for a momentum
scroll animation, for improved accuracy.
* page/mac/WheelEventDeltaFilterMac.h:
* page/mac/WheelEventDeltaFilterMac.mm:
(WebCore::WheelEventDeltaFilterMac::updateFromEvent):
(WebCore::WheelEventDeltaFilterMac::reset):
* page/scrolling/ThreadedScrollingTree.cpp:
(WebCore::ThreadedScrollingTree::willStartRenderingUpdate):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/mac/WheelEventDeltaFilterMac.h
trunk/Source/WebCore/page/mac/WheelEventDeltaFilterMac.mm
trunk/Source/WebCore/page/scrolling/ThreadedScrollingTree.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (285882 => 285883)
--- trunk/Source/WebCore/ChangeLog 2021-11-16 21:53:42 UTC (rev 285882)
+++ trunk/Source/WebCore/ChangeLog 2021-11-16 22:05:01 UTC (rev 285883)
@@ -1,3 +1,21 @@
+2021-11-16 Simon Fraser
+
+Use IOHIDEvent timestamps for momentum velocity computation
+https://bugs.webkit.org/show_bug.cgi?id=233168
+
+Reviewed by Tim Horton.
+
+NSEvent timetamps can have some jitter on some devices (rdar://85309639) so drop
+down to IOHIDEvent timestamps when computing the initial velocity for a momentum
+scroll animation, for improved accuracy.
+
+* page/mac/WheelEventDeltaFilterMac.h:
+* page/mac/WheelEventDeltaFilterMac.mm:
+(WebCore::WheelEventDeltaFilterMac::updateFromEvent):
+(WebCore::WheelEventDeltaFilterMac::reset):
+* page/scrolling/ThreadedScrollingTree.cpp:
+(WebCore::ThreadedScrollingTree::willStartRenderingUpdate):
+
2021-11-16 Andres Gonzalez
Fix for accessibility/mac/replace-text-with-range-on-webarea-element.html in isolated tree mode.
Modified: trunk/Source/WebCore/page/mac/WheelEventDeltaFilterMac.h (285882 => 285883)
--- trunk/Source/WebCore/page/mac/WheelEventDeltaFilterMac.h 2021-11-16 21:53:42 UTC (rev 285882)
+++ trunk/Source/WebCore/page/mac/WheelEventDeltaFilterMac.h 2021-11-16 22:05:01 UTC (rev 285883)
@@ -47,6 +47,7 @@
RetainPtr<_NSScrollingPredominantAxisFilter> m_predominantAxisFilter;
WallTime m_initialWallTime;
+WallTime m_lastIOHIDEventTimestamp;
};
} // namespace WebCore
Modified: trunk/Source/WebCore/page/mac/WheelEventDeltaFilterMac.mm (285882 => 285883)
--- trunk/Source/WebCore/page/mac/WheelEventDeltaFilterMac.mm 2021-11-16 21:53:42 UTC (rev 285882)
+++ trunk/Source/WebCore/page/mac/WheelEventDeltaFilterMac.mm 2021-11-16 22:05:01 UTC (rev 285883)
@@ -29,6 +29,7 @@
#import "WheelEventDeltaFilterMac.h"
#import "FloatPoint.h"
+#import "Logging.h"
#import "PlatformWheelEvent.h"
#import
@@ -43,8 +44,10 @@
void WheelEventDeltaFilterMac::updateFromEvent(const PlatformWheelEvent& event)
{
-if (event.momentumPhase() != PlatformWheelEventPhase::None)
+if (event.momentumPhase() != PlatformWheelEventPhase::None) {
+m_lastIOHIDEventTimestamp = event.ioHIDEventTimestamp();
return;
+}
// The absolute value of timestamp doesn't matter; the filter looks at deltas from the previous event.
auto timestamp = event.timestamp() - m_initialWallTime;
@@ -51,25 +54,42 @@
switch (event.phase()) {
case PlatformWheelEventPhase::None:
+case PlatformWheelEventPhase::Ended:
break;
case PlatformWheelEventPhase::Began:
+reset();
+FALLTHROUGH;
case PlatformWheelEventPhase::Changed: {
NSPoint filteredDeltaResult;
NSPoint filteredVelocityResult;
[m_predominantAxisFilter filterInputDelta:toFloatPoint(event.delta()) timestamp:timestamp.seconds() outputDelta: velocity:];
-m_currentFilteredVelocity = toFloatSize(filteredVelocityResult);
+auto axisFilteredVelocity = toFloatSize(filteredVelocityResult);
m_currentFilteredDelta = toFloatSize(filteredDeltaResult);
+
+// Use a 1ms minimum to avoid divide by zero. The usual cadence of these events matches screen refresh rate.
+auto deltaFromLastEvent = std::max(event.ioHIDEventTimestamp() - m_lastIOHIDEventTimestamp, 1_ms);
+m_currentFilteredVelocity = event.delta() / deltaFromLastEvent.seconds();
+
+// Apply the axis-locking that m_predominantAxisFilter does.
+if (!axisFilteredVelocity.width())
+m_currentFilteredVelocity.setWidth(0);
+if (!axisFilteredVelocity.height())
+m_currentFilteredVelocity.setHeight(0);
+
+LOG(ScrollAnimations, "WheelEventDeltaFilterMac::updateFromEvent: _NSScrollingPredominantAxisFilter velocity %.2f, %2f, IOHIDEvent velocity %.2f,%.2f",
[webkit-changes] [285882] branches/safari-612.3.6.0-branch/Source
Title: [285882] branches/safari-612.3.6.0-branch/Source Revision 285882 Author repst...@apple.com Date 2021-11-16 13:53:42 -0800 (Tue, 16 Nov 2021) Log Message Versioning. WebKit-7612.3.6.0.3 Modified Paths branches/safari-612.3.6.0-branch/Source/_javascript_Core/Configurations/Version.xcconfig branches/safari-612.3.6.0-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig branches/safari-612.3.6.0-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig branches/safari-612.3.6.0-branch/Source/WebCore/Configurations/Version.xcconfig branches/safari-612.3.6.0-branch/Source/WebCore/PAL/Configurations/Version.xcconfig branches/safari-612.3.6.0-branch/Source/WebInspectorUI/Configurations/Version.xcconfig branches/safari-612.3.6.0-branch/Source/WebKit/Configurations/Version.xcconfig branches/safari-612.3.6.0-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig Diff Modified: branches/safari-612.3.6.0-branch/Source/_javascript_Core/Configurations/Version.xcconfig (285881 => 285882) --- branches/safari-612.3.6.0-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2021-11-16 21:19:35 UTC (rev 285881) +++ branches/safari-612.3.6.0-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2021-11-16 21:53:42 UTC (rev 285882) @@ -25,7 +25,7 @@ MINOR_VERSION = 3; TINY_VERSION = 6; MICRO_VERSION = 0; -NANO_VERSION = 2; +NANO_VERSION = 3; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-612.3.6.0-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig (285881 => 285882) --- branches/safari-612.3.6.0-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig 2021-11-16 21:19:35 UTC (rev 285881) +++ branches/safari-612.3.6.0-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig 2021-11-16 21:53:42 UTC (rev 285882) @@ -25,7 +25,7 @@ MINOR_VERSION = 3; TINY_VERSION = 6; MICRO_VERSION = 0; -NANO_VERSION = 2; +NANO_VERSION = 3; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-612.3.6.0-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (285881 => 285882) --- branches/safari-612.3.6.0-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig 2021-11-16 21:19:35 UTC (rev 285881) +++ branches/safari-612.3.6.0-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig 2021-11-16 21:53:42 UTC (rev 285882) @@ -25,7 +25,7 @@ MINOR_VERSION = 3; TINY_VERSION = 6; MICRO_VERSION = 0; -NANO_VERSION = 2; +NANO_VERSION = 3; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-612.3.6.0-branch/Source/WebCore/Configurations/Version.xcconfig (285881 => 285882) --- branches/safari-612.3.6.0-branch/Source/WebCore/Configurations/Version.xcconfig 2021-11-16 21:19:35 UTC (rev 285881) +++ branches/safari-612.3.6.0-branch/Source/WebCore/Configurations/Version.xcconfig 2021-11-16 21:53:42 UTC (rev 285882) @@ -25,7 +25,7 @@ MINOR_VERSION = 3; TINY_VERSION = 6; MICRO_VERSION = 0; -NANO_VERSION = 2; +NANO_VERSION = 3; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-612.3.6.0-branch/Source/WebCore/PAL/Configurations/Version.xcconfig (285881 => 285882) --- branches/safari-612.3.6.0-branch/Source/WebCore/PAL/Configurations/Version.xcconfig 2021-11-16 21:19:35 UTC (rev 285881) +++ branches/safari-612.3.6.0-branch/Source/WebCore/PAL/Configurations/Version.xcconfig 2021-11-16 21:53:42 UTC (rev 285882) @@ -25,7 +25,7 @@ MINOR_VERSION = 3; TINY_VERSION = 6; MICRO_VERSION = 0; -NANO_VERSION = 2; +NANO_VERSION = 3; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-612.3.6.0-branch/Source/WebInspectorUI/Configurations/Version.xcconfig (285881 => 285882) --- branches/safari-612.3.6.0-branch/Source/WebInspectorUI/Configurations/Version.xcconfig 2021-11-16 21:19:35 UTC (rev 285881) +++ branches/safari-612.3.6.0-branch/Source/WebInspectorUI/Configurations/Version.xcconfig 2021-11-16 21:53:42 UTC (rev 285882) @@ -2,7 +2,7 @@ MINOR_VERSION = 3; TINY_VERSION = 6; MICRO_VERSION = 0; -NANO_VERSION = 2; +NANO_VERSION = 3; FULL_VERSION =
[webkit-changes] [285880] trunk/Source/bmalloc
Title: [285880] trunk/Source/bmalloc
Revision 285880
Author ysuz...@apple.com
Date 2021-11-16 12:55:51 -0800 (Tue, 16 Nov 2021)
Log Message
Unreviewed, -latomic is only available for GCC
https://bugs.webkit.org/show_bug.cgi?id=233097
* CMakeLists.txt:
Modified Paths
trunk/Source/bmalloc/CMakeLists.txt
trunk/Source/bmalloc/ChangeLog
Diff
Modified: trunk/Source/bmalloc/CMakeLists.txt (285879 => 285880)
--- trunk/Source/bmalloc/CMakeLists.txt 2021-11-16 20:24:15 UTC (rev 285879)
+++ trunk/Source/bmalloc/CMakeLists.txt 2021-11-16 20:55:51 UTC (rev 285880)
@@ -639,10 +639,16 @@
)
endif ()
-set(bmalloc_LIBRARIES
-${CMAKE_DL_LIBS}
-atomic
-)
+if (CMAKE_COMPILER_IS_GNUCXX)
+set(bmalloc_LIBRARIES
+${CMAKE_DL_LIBS}
+atomic
+)
+else ()
+set(bmalloc_LIBRARIES
+${CMAKE_DL_LIBS}
+)
+endif ()
set(bmalloc_INTERFACE_LIBRARIES bmalloc)
set(bmalloc_INTERFACE_INCLUDE_DIRECTORIES ${bmalloc_FRAMEWORK_HEADERS_DIR})
Modified: trunk/Source/bmalloc/ChangeLog (285879 => 285880)
--- trunk/Source/bmalloc/ChangeLog 2021-11-16 20:24:15 UTC (rev 285879)
+++ trunk/Source/bmalloc/ChangeLog 2021-11-16 20:55:51 UTC (rev 285880)
@@ -1,3 +1,10 @@
+2021-11-16 Yusuke Suzuki
+
+Unreviewed, -latomic is only available for GCC
+https://bugs.webkit.org/show_bug.cgi?id=233097
+
+* CMakeLists.txt:
+
2021-11-15 Yusuke Suzuki
[libpas] Build and enable libpas on 64bit JSCOnly
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [285878] trunk/Source/WebKit
Title: [285878] trunk/Source/WebKit Revision 285878 Author pvol...@apple.com Date 2021-11-16 12:20:46 -0800 (Tue, 16 Nov 2021) Log Message Adjust graphics related message filter https://bugs.webkit.org/show_bug.cgi?id=233151 Reviewed by Brent Fulgham. Adjust graphics related message filter in the WebContent process' sandbox on iOS. This patch unifies the filter for different OS versions. * Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in: * WebProcess/com.apple.WebProcess.sb.in: Modified Paths trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in trunk/Source/WebKit/WebProcess/com.apple.WebProcess.sb.in Diff Modified: trunk/Source/WebKit/ChangeLog (285877 => 285878) --- trunk/Source/WebKit/ChangeLog 2021-11-16 19:55:35 UTC (rev 285877) +++ trunk/Source/WebKit/ChangeLog 2021-11-16 20:20:46 UTC (rev 285878) @@ -1,3 +1,18 @@ +2021-11-16 Per Arne Vollan + +Adjust graphics related message filter +https://bugs.webkit.org/show_bug.cgi?id=233151 + + +Reviewed by Brent Fulgham. + +Adjust graphics related message filter in the WebContent process' sandbox on iOS. This patch unifies +the filter for different OS versions. + +* Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in: + +* WebProcess/com.apple.WebProcess.sb.in: + 2021-11-16 Chris Dumez Crash under WebKit::WebPageProxy::commitProvisionalPage() Modified: trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in (285877 => 285878) --- trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in 2021-11-16 19:55:35 UTC (rev 285877) +++ trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in 2021-11-16 20:20:46 UTC (rev 285878) @@ -263,11 +263,8 @@ (allow iokit-async-external-method #if PLATFORM(IOS) (iokit-method-number -#if __IPHONE_OS_VERSION_MIN_REQUIRED < 150500 43 -#else 44 -#endif ) #endif ) @@ -292,21 +289,16 @@ 25 26 27 -#if __IPHONE_OS_VERSION_MIN_REQUIRED < 150500 36 +37 38 39 40 +41 42 +43 44 -#else -37 -39 -40 -41 -43 45 -#endif ) #endif ) Modified: trunk/Source/WebKit/WebProcess/com.apple.WebProcess.sb.in (285877 => 285878) --- trunk/Source/WebKit/WebProcess/com.apple.WebProcess.sb.in 2021-11-16 19:55:35 UTC (rev 285877) +++ trunk/Source/WebKit/WebProcess/com.apple.WebProcess.sb.in 2021-11-16 20:20:46 UTC (rev 285878) @@ -166,10 +166,12 @@ 30 31 40 -#if __MAC_OS_X_VERSION_MIN_REQUIRED >= 120300 41 +42 43 +48 49 +256 257 258 259 @@ -180,26 +182,11 @@ 264 265 266 +267 268 269 +512 513 -#else -42 -48 -256 -257 -258 -259 -260 -261 -262 -263 -264 -265 -267 -268 -512 -#endif ) #endif ) ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [285877] trunk
Title: [285877] trunk
Revision 285877
Author cdu...@apple.com
Date 2021-11-16 11:55:35 -0800 (Tue, 16 Nov 2021)
Log Message
Crash under WebKit::WebPageProxy::commitProvisionalPage()
https://bugs.webkit.org/show_bug.cgi?id=233199
Reviewed by Youenn Fablet.
Source/WebKit:
In the event where the committed WebProcess would crash while a cross-site provisional load
is going on in a provisional page / WebProcess, we would do a null dereference of the page's
drawing area when trying to commit the provisional page later on. We would also hit various
assertions in debug since the page's state gets completely reset when its WebProcess crashes.
To address the issue, we now clear the provisional page if the page's WebProcess crashes.
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::resetStateAfterProcessExited):
Tools:
Add API test coverage.
* TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/WebPageProxy.cpp
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm
Diff
Modified: trunk/Source/WebKit/ChangeLog (285876 => 285877)
--- trunk/Source/WebKit/ChangeLog 2021-11-16 19:49:47 UTC (rev 285876)
+++ trunk/Source/WebKit/ChangeLog 2021-11-16 19:55:35 UTC (rev 285877)
@@ -1,5 +1,23 @@
2021-11-16 Chris Dumez
+Crash under WebKit::WebPageProxy::commitProvisionalPage()
+https://bugs.webkit.org/show_bug.cgi?id=233199
+
+
+Reviewed by Youenn Fablet.
+
+In the event where the committed WebProcess would crash while a cross-site provisional load
+is going on in a provisional page / WebProcess, we would do a null dereference of the page's
+drawing area when trying to commit the provisional page later on. We would also hit various
+assertions in debug since the page's state gets completely reset when its WebProcess crashes.
+
+To address the issue, we now clear the provisional page if the page's WebProcess crashes.
+
+* UIProcess/WebPageProxy.cpp:
+(WebKit::WebPageProxy::resetStateAfterProcessExited):
+
+2021-11-16 Chris Dumez
+
[iOS] Do not require the web browser entitlement to opt into captive portal mode
https://bugs.webkit.org/show_bug.cgi?id=233191
Modified: trunk/Source/WebKit/UIProcess/WebPageProxy.cpp (285876 => 285877)
--- trunk/Source/WebKit/UIProcess/WebPageProxy.cpp 2021-11-16 19:49:47 UTC (rev 285876)
+++ trunk/Source/WebKit/UIProcess/WebPageProxy.cpp 2021-11-16 19:55:35 UTC (rev 285877)
@@ -7936,6 +7936,9 @@
m_editorState = EditorState();
m_cachedFontAttributesAtSelectionStart.reset();
+if (terminationReason != ProcessTerminationReason::NavigationSwap)
+m_provisionalPage = nullptr;
+
if (terminationReason == ProcessTerminationReason::NavigationSwap)
pageClient().processWillSwap();
else
Modified: trunk/Tools/ChangeLog (285876 => 285877)
--- trunk/Tools/ChangeLog 2021-11-16 19:49:47 UTC (rev 285876)
+++ trunk/Tools/ChangeLog 2021-11-16 19:55:35 UTC (rev 285877)
@@ -1,3 +1,15 @@
+2021-11-16 Chris Dumez
+
+Crash under WebKit::WebPageProxy::commitProvisionalPage()
+https://bugs.webkit.org/show_bug.cgi?id=233199
+
+
+Reviewed by Youenn Fablet.
+
+Add API test coverage.
+
+* TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
+
2021-11-16 Fujii Hironori
[Win][MiniBrowser][WK2] Show a message box for a provisional navigation failure
Modified: trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm (285876 => 285877)
--- trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm 2021-11-16 19:49:47 UTC (rev 285876)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm 2021-11-16 19:55:35 UTC (rev 285877)
@@ -5527,6 +5527,48 @@
EXPECT_NE(pid3, pid4);
}
+TEST(ProcessSwap, CommittedProcessCrashDuringCrossSiteNavigation)
+{
+auto processPoolConfiguration = psonProcessPoolConfiguration();
+auto processPool = adoptNS([[WKProcessPool alloc] _initWithConfiguration:processPoolConfiguration.get()]);
+
+auto webViewConfiguration = adoptNS([[WKWebViewConfiguration alloc] init]);
+[webViewConfiguration setProcessPool:processPool.get()];
+auto handler = adoptNS([[PSONScheme alloc] init]);
+[webViewConfiguration setURLSchemeHandler:handler.get() forURLScheme:@"PSON"];
+
+auto webView = adoptNS([[WKWebView alloc] initWithFrame:NSMakeRect(0, 0, 800, 600) configuration:webViewConfiguration.get()]);
+auto navigationDelegate = adoptNS([[PSONNavigationDelegate alloc] init]);
+[webView setNavigationDelegate:navigationDelegate.get()];
+
+done = false;
+NSURLRequest *request = [NSURLRequest requestWithURL:[NSURL URLWithString:@"pson://www.webkit.org/main.html"]];
+[webView loadRequest:request];
+
+TestWebKitAPI::Util::run();
+done = false;
+
+
[webkit-changes] [285876] trunk/Tools
Title: [285876] trunk/Tools
Revision 285876
Author hironori.fu...@sony.com
Date 2021-11-16 11:49:47 -0800 (Tue, 16 Nov 2021)
Log Message
[Win][MiniBrowser][WK2] Show a message box for a provisional navigation failure
https://bugs.webkit.org/show_bug.cgi?id=233170
Reviewed by Don Olmstead.
Show a MessageBox if a provisional navigation failed.
* MiniBrowser/win/WebKitBrowserWindow.cpp:
(WebKitBrowserWindow::WebKitBrowserWindow):
(WebKitBrowserWindow::didFailProvisionalNavigation):
* MiniBrowser/win/WebKitBrowserWindow.h:
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/MiniBrowser/win/WebKitBrowserWindow.cpp
trunk/Tools/MiniBrowser/win/WebKitBrowserWindow.h
Diff
Modified: trunk/Tools/ChangeLog (285875 => 285876)
--- trunk/Tools/ChangeLog 2021-11-16 19:31:42 UTC (rev 285875)
+++ trunk/Tools/ChangeLog 2021-11-16 19:49:47 UTC (rev 285876)
@@ -1,3 +1,17 @@
+2021-11-16 Fujii Hironori
+
+[Win][MiniBrowser][WK2] Show a message box for a provisional navigation failure
+https://bugs.webkit.org/show_bug.cgi?id=233170
+
+Reviewed by Don Olmstead.
+
+Show a MessageBox if a provisional navigation failed.
+
+* MiniBrowser/win/WebKitBrowserWindow.cpp:
+(WebKitBrowserWindow::WebKitBrowserWindow):
+(WebKitBrowserWindow::didFailProvisionalNavigation):
+* MiniBrowser/win/WebKitBrowserWindow.h:
+
2021-11-16 Zhifei Fang
Make run-_javascript_-core-test and run-jsc-stress-tests support a customized identity file
Modified: trunk/Tools/MiniBrowser/win/WebKitBrowserWindow.cpp (285875 => 285876)
--- trunk/Tools/MiniBrowser/win/WebKitBrowserWindow.cpp 2021-11-16 19:31:42 UTC (rev 285875)
+++ trunk/Tools/MiniBrowser/win/WebKitBrowserWindow.cpp 2021-11-16 19:49:47 UTC (rev 285876)
@@ -41,6 +41,7 @@
#include
#include
#include
+#include
#include
std::wstring createString(WKURLRef wkURL)
@@ -153,6 +154,7 @@
WKPageNavigationClientV0 navigationClient = { };
navigationClient.base.version = 0;
navigationClient.base.clientInfo = this;
+navigationClient.didFailProvisionalNavigation = didFailProvisionalNavigation;
navigationClient.didReceiveAuthenticationChallenge = didReceiveAuthenticationChallenge;
WKPageSetPageNavigationClient(page, );
@@ -359,6 +361,17 @@
thisWindow.m_client.activeURLChanged(createString(url.get()));
}
+void WebKitBrowserWindow::didFailProvisionalNavigation(WKPageRef page, WKNavigationRef navigation, WKErrorRef error, WKTypeRef userData, const void* clientInfo)
+{
+auto& thisWindow = toWebKitBrowserWindow(clientInfo);
+std::wstringstream text;
+text << createString(adoptWK(WKErrorCopyLocalizedDescription(error)).get()) << std::endl;
+text << L"Error Code: " << WKErrorGetErrorCode(error) << std::endl;
+text << L"Domain: " << createString(adoptWK(WKErrorCopyDomain(error)).get()) << std::endl;
+text << L"Failing URL: " << createString(adoptWK(WKErrorCopyFailingURL(error)).get());
+MessageBox(thisWindow.m_hMainWnd, text.str().c_str(), L"Provisional Navigation Failure", MB_OK | MB_ICONWARNING);
+}
+
void WebKitBrowserWindow::didReceiveAuthenticationChallenge(WKPageRef page, WKAuthenticationChallengeRef challenge, const void* clientInfo)
{
auto& thisWindow = toWebKitBrowserWindow(clientInfo);
Modified: trunk/Tools/MiniBrowser/win/WebKitBrowserWindow.h (285875 => 285876)
--- trunk/Tools/MiniBrowser/win/WebKitBrowserWindow.h 2021-11-16 19:31:42 UTC (rev 285875)
+++ trunk/Tools/MiniBrowser/win/WebKitBrowserWindow.h 2021-11-16 19:49:47 UTC (rev 285876)
@@ -69,6 +69,7 @@
static void didChangeIsLoading(const void*);
static void didChangeEstimatedProgress(const void*);
static void didChangeActiveURL(const void*);
+static void didFailProvisionalNavigation(WKPageRef, WKNavigationRef, WKErrorRef, WKTypeRef, const void*);
static void didReceiveAuthenticationChallenge(WKPageRef, WKAuthenticationChallengeRef, const void*);
static WKPageRef createNewPage(WKPageRef, WKPageConfigurationRef, WKNavigationActionRef, WKWindowFeaturesRef, const void *);
static void didNotHandleKeyEvent(WKPageRef, WKNativeEventPtr, const void*);
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [285875] trunk/Tools
Title: [285875] trunk/Tools
Revision 285875
Author zhifei_f...@apple.com
Date 2021-11-16 11:31:42 -0800 (Tue, 16 Nov 2021)
Log Message
Make run-_javascript_-core-test and run-jsc-stress-tests support a customized identity file
https://bugs.webkit.org/show_bug.cgi?id=232453
Reviewed by Ryan Haddad.
* Scripts/run-_javascript_core-tests: Add idFilePath field for remote config.
* Scripts/run-jsc-stress-tests: Add idFilePath field for remote config.
* Scripts/webkitdirs.pm:
(determineNativeArchitecture): Provide -i option to ssh
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/run-_javascript_core-tests
trunk/Tools/Scripts/run-jsc-stress-tests
trunk/Tools/Scripts/webkitdirs.pm
Diff
Modified: trunk/Tools/ChangeLog (285874 => 285875)
--- trunk/Tools/ChangeLog 2021-11-16 19:26:36 UTC (rev 285874)
+++ trunk/Tools/ChangeLog 2021-11-16 19:31:42 UTC (rev 285875)
@@ -1,3 +1,15 @@
+2021-11-16 Zhifei Fang
+
+Make run-_javascript_-core-test and run-jsc-stress-tests support a customized identity file
+https://bugs.webkit.org/show_bug.cgi?id=232453
+
+Reviewed by Ryan Haddad.
+
+* Scripts/run-_javascript_core-tests: Add idFilePath field for remote config.
+* Scripts/run-jsc-stress-tests: Add idFilePath field for remote config.
+* Scripts/webkitdirs.pm:
+(determineNativeArchitecture): Provide -i option to ssh
+
2021-11-16 Chris Dumez
[iOS] Do not require the web browser entitlement to opt into captive portal mode
Modified: trunk/Tools/Scripts/run-_javascript_core-tests (285874 => 285875)
--- trunk/Tools/Scripts/run-_javascript_core-tests 2021-11-16 19:26:36 UTC (rev 285874)
+++ trunk/Tools/Scripts/run-_javascript_core-tests 2021-11-16 19:31:42 UTC (rev 285875)
@@ -524,12 +524,14 @@
$remotes = $remoteConfig->{"remotes"};
} elsif (defined $remoteConfig->{"remote"}) {
my @split = split(':', $remoteConfig->{"remote"});
-$remotes = [
-{
-"name" => "synthesized",
-"address" => $remoteConfig->{"remote"}
-}
- ];
+my $remote = {
+"name" => "synthesized",
+"address" => $remoteConfig->{"remote"}
+};
+if (exists $remoteConfig->{"idFilePath"}) {
+$remote->{'idFilePath'} = $remoteConfig->{'idFilePath'};
+}
+$remotes = [$remote];
}
}
Modified: trunk/Tools/Scripts/run-jsc-stress-tests (285874 => 285875)
--- trunk/Tools/Scripts/run-jsc-stress-tests 2021-11-16 19:26:36 UTC (rev 285874)
+++ trunk/Tools/Scripts/run-jsc-stress-tests 2021-11-16 19:31:42 UTC (rev 285875)
@@ -51,7 +51,7 @@
puts(Thread.current.backtrace)
}
-RemoteHost = Struct.new(:name, :user, :host, :port, :remoteDirectory)
+RemoteHost = Struct.new(:name, :user, :host, :port, :remoteDirectory, :identity_file_path)
THIS_SCRIPT_PATH = Pathname.new(__FILE__).realpath
SCRIPTS_PATH = THIS_SCRIPT_PATH.dirname
@@ -325,6 +325,9 @@
if config['remoteDirectory']
$remoteHosts[0].remoteDirectory = config['remoteDirectory']
end
+if config['idFilePath']
+$remoteHosts[0].identity_file_path = config['idFilePath']
+end
end
# we can combine --remote and a new style config
@@ -340,6 +343,10 @@
if remote['remoteDirectory']
host.remoteDirectory = remote['remoteDirectory']
end
+if remote['idFilePath']
+host.identity_file_path = remote['idFilePath']
+print('Using identity file: ' + host.identity_file_path + "\r")
+end
host
}
end
@@ -2118,7 +2125,7 @@
raise unless $remote
result = ""
-IO.popen("ssh -o NoHostAuthenticationForLocalhost=yes -p #{remoteHost.port} #{remoteHost.user}@#{remoteHost.host} '#{cmd}'", "r") {
+IO.popen("ssh -o NoHostAuthenticationForLocalhost=yes -p #{remoteHost.port}" + (remoteHost.identity_file_path ? " -i #{remoteHost.identity_file_path}" : "") + " #{remoteHost.user}@#{remoteHost.host} '#{cmd}'", "r") {
| inp |
inp.each_line {
| line |
@@ -2256,8 +2263,8 @@
end
def copyBundleToRemote(remoteHost)
-mysys(["ssh", "-o", "NoHostAuthenticationForLocalhost=yes", "-p", remoteHost.port.to_s, "#{remoteHost.user}@#{remoteHost.host}", "mkdir -p #{remoteHost.remoteDirectory}"])
-mysys(["scp", "-o", "NoHostAuthenticationForLocalhost=yes", "-P", remoteHost.port.to_s, ($outputDir.dirname + $tarFileName).to_s, "#{remoteHost.user}@#{remoteHost.host}:#{remoteHost.remoteDirectory}"])
+mysys(["ssh", "-o", "NoHostAuthenticationForLocalhost=yes"] + (remoteHost.identity_file_path ? ["-i", remoteHost.identity_file_path] : []) + ["-p", remoteHost.port.to_s, "#{remoteHost.user}@#{remoteHost.host}", "mkdir -p #{remoteHost.remoteDirectory}"])
+mysys(["scp", "-o", "NoHostAuthenticationForLocalhost=yes"] + (remoteHost.identity_file_path ? ["-i",
[webkit-changes] [285874] trunk/LayoutTests
Title: [285874] trunk/LayoutTests
Revision 285874
Author commit-qu...@webkit.org
Date 2021-11-16 11:26:36 -0800 (Tue, 16 Nov 2021)
Log Message
AX: Simplify tests changed in https://bugs.webkit.org/show_bug.cgi?id=233085
https://bugs.webkit.org/show_bug.cgi?id=233167
Patch by Tyler Wilcock on 2021-11-16
Reviewed by Andres Gonzalez.
In https://bugs.webkit.org/show_bug.cgi?id=233085 and https://bugs.webkit.org/show_bug.cgi?id=233017,
we made some tests async so that they passed in --release --accessibility-isolated-tree mode. However,
we can make these tests simpler and still pass — i.e., only wait for elements and expressions asynchronously
when it's absolutely necessary.
* accessibility/color-well.html:
* accessibility/mac/header-expected.txt:
* accessibility/mac/header.html:
* accessibility/mac/scrollbars.html:
* accessibility/placeholder.html:
* accessibility/progressbar.html:
* accessibility/range-alter-by-percent-expected.txt:
* accessibility/range-alter-by-percent.html:
* accessibility/range-alter-by-step-expected.txt:
* accessibility/range-alter-by-step.html:
* accessibility/spinbutton-value-expected.txt:
* accessibility/spinbutton-value.html:
Simplify these tests by only use async waiting when
necessary (i.e. dynamic mutation via JS)
* resources/accessibility-helper.js:
(async expectAsyncExpression):
(async waitForExpression): Renamed to expectAsyncExpression.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/accessibility/color-well.html
trunk/LayoutTests/accessibility/mac/header-expected.txt
trunk/LayoutTests/accessibility/mac/header.html
trunk/LayoutTests/accessibility/mac/scrollbars.html
trunk/LayoutTests/accessibility/placeholder.html
trunk/LayoutTests/accessibility/progressbar.html
trunk/LayoutTests/accessibility/range-alter-by-percent-expected.txt
trunk/LayoutTests/accessibility/range-alter-by-percent.html
trunk/LayoutTests/accessibility/range-alter-by-step-expected.txt
trunk/LayoutTests/accessibility/range-alter-by-step.html
trunk/LayoutTests/accessibility/spinbutton-value-expected.txt
trunk/LayoutTests/accessibility/spinbutton-value.html
trunk/LayoutTests/resources/accessibility-helper.js
Diff
Modified: trunk/LayoutTests/ChangeLog (285873 => 285874)
--- trunk/LayoutTests/ChangeLog 2021-11-16 18:27:57 UTC (rev 285873)
+++ trunk/LayoutTests/ChangeLog 2021-11-16 19:26:36 UTC (rev 285874)
@@ -1,3 +1,34 @@
+2021-11-16 Tyler Wilcock
+
+AX: Simplify tests changed in https://bugs.webkit.org/show_bug.cgi?id=233085
+https://bugs.webkit.org/show_bug.cgi?id=233167
+
+Reviewed by Andres Gonzalez.
+
+In https://bugs.webkit.org/show_bug.cgi?id=233085 and https://bugs.webkit.org/show_bug.cgi?id=233017,
+we made some tests async so that they passed in --release --accessibility-isolated-tree mode. However,
+we can make these tests simpler and still pass — i.e., only wait for elements and expressions asynchronously
+when it's absolutely necessary.
+
+* accessibility/color-well.html:
+* accessibility/mac/header-expected.txt:
+* accessibility/mac/header.html:
+* accessibility/mac/scrollbars.html:
+* accessibility/placeholder.html:
+* accessibility/progressbar.html:
+* accessibility/range-alter-by-percent-expected.txt:
+* accessibility/range-alter-by-percent.html:
+* accessibility/range-alter-by-step-expected.txt:
+* accessibility/range-alter-by-step.html:
+* accessibility/spinbutton-value-expected.txt:
+* accessibility/spinbutton-value.html:
+Simplify these tests by only use async waiting when
+necessary (i.e. dynamic mutation via JS)
+
+* resources/accessibility-helper.js:
+(async expectAsyncExpression):
+(async waitForExpression): Renamed to expectAsyncExpression.
+
2021-11-16 Commit Queue
Unreviewed, reverting r280078, r280290 and r282008.
Modified: trunk/LayoutTests/accessibility/color-well.html (285873 => 285874)
--- trunk/LayoutTests/accessibility/color-well.html 2021-11-16 18:27:57 UTC (rev 285873)
+++ trunk/LayoutTests/accessibility/color-well.html 2021-11-16 19:26:36 UTC (rev 285874)
@@ -14,21 +14,15 @@
description("This test checks the role of ColorWellRolean input with type=color");
if (window.accessibilityController) {
-window.jsTestIsAsync = true;
+let axColorwell = accessibilityController.accessibleElementById("empty_colorwell");
+debug("Role of input type=color is: " + axColorwell.role);
+debug("Value of empty color well: " + axColorwell.stringValue);
-setTimeout(async function() {
-let axColorwell = await waitForElementById("empty_colorwell");
-debug("Role of input type=color is: " + axColorwell.role);
-debug("Value of empty color well: " + axColorwell.stringValue);
+axColorwell = accessibilityController.accessibleElementById("good_colorwell");
+
[webkit-changes] [285873] trunk
Title: [285873] trunk
Revision 285873
Author cdu...@apple.com
Date 2021-11-16 10:27:57 -0800 (Tue, 16 Nov 2021)
Log Message
[iOS] Do not require the web browser entitlement to opt into captive portal mode
https://bugs.webkit.org/show_bug.cgi?id=233191
Reviewed by Brent Fulgham.
Source/WebKit:
Do not require the web browser entitlement to opt into captive portal mode on iOS, only require
it to opt out.
* UIProcess/API/Cocoa/WKWebpagePreferences.mm:
(-[WKWebpagePreferences _setCaptivePortalModeEnabled:]):
Tools:
Update API test coverage accordingly.
* TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebpagePreferences.mm
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm
Diff
Modified: trunk/Source/WebKit/ChangeLog (285872 => 285873)
--- trunk/Source/WebKit/ChangeLog 2021-11-16 18:14:09 UTC (rev 285872)
+++ trunk/Source/WebKit/ChangeLog 2021-11-16 18:27:57 UTC (rev 285873)
@@ -1,3 +1,16 @@
+2021-11-16 Chris Dumez
+
+[iOS] Do not require the web browser entitlement to opt into captive portal mode
+https://bugs.webkit.org/show_bug.cgi?id=233191
+
+Reviewed by Brent Fulgham.
+
+Do not require the web browser entitlement to opt into captive portal mode on iOS, only require
+it to opt out.
+
+* UIProcess/API/Cocoa/WKWebpagePreferences.mm:
+(-[WKWebpagePreferences _setCaptivePortalModeEnabled:]):
+
2021-11-16 Per Arne Vollan
[macOS][GPUP] Add telemetry for syscalls
Modified: trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebpagePreferences.mm (285872 => 285873)
--- trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebpagePreferences.mm 2021-11-16 18:14:09 UTC (rev 285872)
+++ trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebpagePreferences.mm 2021-11-16 18:27:57 UTC (rev 285873)
@@ -393,10 +393,15 @@
- (void)_setCaptivePortalModeEnabled:(BOOL)captivePortalModeEnabled
{
+if (_websitePolicies->captivePortalModeEnabled() == captivePortalModeEnabled)
+return;
+
#if PLATFORM(IOS_FAMILY)
-if (!WTF::processHasEntitlement("com.apple.developer.web-browser"))
-return;
+// On iOS, the web browser entitlement is required to disable captive portal mode.
+if (!captivePortalModeEnabled && !WTF::processHasEntitlement("com.apple.developer.web-browser"))
+[NSException raise:NSInternalInconsistencyException format:@"The 'com.apple.developer.web-browser' restricted entitlement is required to disable captive portal mode"];
#endif
+
_websitePolicies->setCaptivePortalModeEnabled(!!captivePortalModeEnabled);
}
Modified: trunk/Tools/ChangeLog (285872 => 285873)
--- trunk/Tools/ChangeLog 2021-11-16 18:14:09 UTC (rev 285872)
+++ trunk/Tools/ChangeLog 2021-11-16 18:27:57 UTC (rev 285873)
@@ -1,3 +1,14 @@
+2021-11-16 Chris Dumez
+
+[iOS] Do not require the web browser entitlement to opt into captive portal mode
+https://bugs.webkit.org/show_bug.cgi?id=233191
+
+Reviewed by Brent Fulgham.
+
+Update API test coverage accordingly.
+
+* TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
+
2021-11-16 Andres Gonzalez
Fix for accessibility/mac/replace-text-with-range-on-webarea-element.html in isolated tree mode.
Modified: trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm (285872 => 285873)
--- trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm 2021-11-16 18:14:09 UTC (rev 285872)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm 2021-11-16 18:27:57 UTC (rev 285873)
@@ -7626,10 +7626,6 @@
runCOOPProcessSwapTest("same-origin-allow-popup", "unsafe-none", "unsafe-none", "unsafe-none", IsSameOrigin::No, DoServerSideRedirect::No, ExpectSwap::No);
}
-// On iOS, toggling the captive portal mode requires the browser entitlement, which TestWebKit API doesn't have.
-// Also, some API tests rely on the browser entitlement not being present.
-#if !PLATFORM(IOS)
-
static bool isJITEnabled(WKWebView *webView)
{
__block bool gotResponse = false;
@@ -7723,6 +7719,53 @@
checkSettingsControlledByCaptivePortalMode(webView.get(), ShouldBeEnabled::No);
}
+#if PLATFORM(IOS)
+
+TEST(ProcessSwap, CannotDisableCaptivePortalModeWithoutBrowserEntitlement)
+{
+auto webViewConfiguration = adoptNS([WKWebViewConfiguration new]);
+EXPECT_FALSE(webViewConfiguration.get().defaultWebpagePreferences._captivePortalModeEnabled);
+[webViewConfiguration.get().defaultWebpagePreferences _setCaptivePortalModeEnabled:YES];
+[webViewConfiguration.get().preferences _setMediaDevicesEnabled:YES];
+webViewConfiguration.get().preferences._mediaCaptureRequiresSecureConnection = NO;
+
+auto webView = adoptNS([[WKWebView alloc] initWithFrame:NSMakeRect(0, 0, 800, 600) configuration:webViewConfiguration.get()]);
+auto delegate =
[webkit-changes] [285872] trunk
Title: [285872] trunk
Revision 285872
Author andresg...@apple.com
Date 2021-11-16 10:14:09 -0800 (Tue, 16 Nov 2021)
Log Message
Fix for accessibility/mac/replace-text-with-range-on-webarea-element.html in isolated tree mode.
https://bugs.webkit.org/show_bug.cgi?id=233160
Reviewed by Chris Fleizach.
Source/WebCore:
Test: accessibility/mac/replace-text-with-range-on-webarea-element.html
The replacement and insertion text string is now properly isolatedCopied
in the AXIsolatedObject method instead of in the wrapper.
* accessibility/isolatedtree/AXIsolatedObject.cpp:
(WebCore::AXIsolatedObject::replaceTextInRange):
(WebCore::AXIsolatedObject::insertText):
* accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
(-[WebAccessibilityObjectWrapper accessibilityReplaceRange:withText:]):
(-[WebAccessibilityObjectWrapper accessibilityInsertText:]):
Tools:
* WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
(WTR::AccessibilityUIElement::stringValue):
(WTR::AccessibilityUIElement::replaceTextInRange):
Dispatches to the AX thread the call to the wrapper's
[accessibilityReplaceRange withText:] method.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.cpp
trunk/Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm
trunk/Tools/ChangeLog
trunk/Tools/WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm
Diff
Modified: trunk/Source/WebCore/ChangeLog (285871 => 285872)
--- trunk/Source/WebCore/ChangeLog 2021-11-16 17:47:29 UTC (rev 285871)
+++ trunk/Source/WebCore/ChangeLog 2021-11-16 18:14:09 UTC (rev 285872)
@@ -1,3 +1,23 @@
+2021-11-16 Andres Gonzalez
+
+Fix for accessibility/mac/replace-text-with-range-on-webarea-element.html in isolated tree mode.
+https://bugs.webkit.org/show_bug.cgi?id=233160
+
+
+Reviewed by Chris Fleizach.
+
+Test: accessibility/mac/replace-text-with-range-on-webarea-element.html
+
+The replacement and insertion text string is now properly isolatedCopied
+in the AXIsolatedObject method instead of in the wrapper.
+
+* accessibility/isolatedtree/AXIsolatedObject.cpp:
+(WebCore::AXIsolatedObject::replaceTextInRange):
+(WebCore::AXIsolatedObject::insertText):
+* accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
+(-[WebAccessibilityObjectWrapper accessibilityReplaceRange:withText:]):
+(-[WebAccessibilityObjectWrapper accessibilityInsertText:]):
+
2021-11-16 Youenn Fablet
Remove unused Xcode references to ServiceWorkerGlobalScopePushAPI files
Modified: trunk/Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.cpp (285871 => 285872)
--- trunk/Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.cpp 2021-11-16 17:47:29 UTC (rev 285871)
+++ trunk/Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.cpp 2021-11-16 18:14:09 UTC (rev 285872)
@@ -1196,9 +1196,9 @@
bool AXIsolatedObject::replaceTextInRange(const String& replacementText, const PlainTextRange& textRange)
{
-return Accessibility::retrieveValueFromMainThread([, , this] () -> bool {
+return Accessibility::retrieveValueFromMainThread([text = replacementText.isolatedCopy(), , this] () -> bool {
if (auto* axObject = associatedAXObject())
-return axObject->replaceTextInRange(replacementText, textRange);
+return axObject->replaceTextInRange(text, textRange);
return false;
});
}
@@ -1205,7 +1205,7 @@
bool AXIsolatedObject::insertText(const String& text)
{
-return Accessibility::retrieveValueFromMainThread([, this] () -> bool {
+return Accessibility::retrieveValueFromMainThread([text = text.isolatedCopy(), this] () -> bool {
if (auto* axObject = associatedAXObject())
return axObject->insertText(text);
return false;
Modified: trunk/Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm (285871 => 285872)
--- trunk/Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm 2021-11-16 17:47:29 UTC (rev 285871)
+++ trunk/Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm 2021-11-16 18:14:09 UTC (rev 285872)
@@ -3277,19 +3277,13 @@
- (BOOL)accessibilityReplaceRange:(NSRange)range withText:(NSString *)string
{
auto* backingObject = self.updateObjectBackingStore;
-if (!backingObject)
-return NO;
-
-return backingObject->replaceTextInRange(String(string).isolatedCopy(), PlainTextRange(range));
+return backingObject ? backingObject->replaceTextInRange(String(string), PlainTextRange(range)) : NO;
}
- (BOOL)accessibilityInsertText:(NSString *)text
{
auto* backingObject = self.updateObjectBackingStore;
-if (!backingObject)
-return NO;
-
-return backingObject->insertText(String(text).isolatedCopy());
+return backingObject ? backingObject->insertText(String(text)) : NO;
}
[webkit-changes] [285871] trunk
Title: [285871] trunk
Revision 285871
Author jbed...@apple.com
Date 2021-11-16 09:47:29 -0800 (Tue, 16 Nov 2021)
Log Message
Add my GitHub username to contributors.json
Reviewed by Jonathan Bedard
* metadata/contributors.json:
Canonical link: https://commits.webkit.org/244297@main
Modified Paths
trunk/ChangeLog
trunk/metadata/contributors.json
Diff
Modified: trunk/ChangeLog (285870 => 285871)
--- trunk/ChangeLog 2021-11-16 17:39:10 UTC (rev 285870)
+++ trunk/ChangeLog 2021-11-16 17:47:29 UTC (rev 285871)
@@ -1,3 +1,11 @@
+2021-11-16 Alex Atwater
+
+Add my GitHub username to contributors.json
+
+Reviewed by Jonathan Bedard
+
+* metadata/contributors.json:
+
2021-11-15 Nikolas Zimmermann
Add my GitHub username to contributors.json
Modified: trunk/metadata/contributors.json (285870 => 285871)
--- trunk/metadata/contributors.json 2021-11-16 17:39:10 UTC (rev 285870)
+++ trunk/metadata/contributors.json 2021-11-16 17:47:29 UTC (rev 285871)
@@ -315,6 +315,14 @@
},
{
"emails" : [
+ "alexandera...@apple.com"
+ ],
+ "expertise" : "Python, Services, Kubernetes",
+ "github" : "akath20",
+ "name" : "Alex Atwater"
+ },
+ {
+ "emails" : [
"achristen...@apple.com",
"achristen...@webkit.org",
"alex.christen...@flexsim.com"
@@ -7038,4 +7046,4 @@
],
"status" : "reviewer"
}
-]
+]
\ No newline at end of file
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [285870] trunk/Tools
Title: [285870] trunk/Tools
Revision 285870
Author beid...@apple.com
Date 2021-11-16 09:39:10 -0800 (Tue, 16 Nov 2021)
Log Message
Enable webpushd tests in the iOS simulator.
https://bugs.webkit.org/show_bug.cgi?id=233149
Reviewed by Alex Christensen.
* TestWebKitAPI/Tests/WebKitCocoa/WebPushDaemon.mm:
(TestWebKitAPI::testWebPushDaemonPList): Add a key to allow an OSLaunchdJob executable to break out of the simulator runtime root.
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/WebPushDaemon.mm
Diff
Modified: trunk/Tools/ChangeLog (285869 => 285870)
--- trunk/Tools/ChangeLog 2021-11-16 17:11:53 UTC (rev 285869)
+++ trunk/Tools/ChangeLog 2021-11-16 17:39:10 UTC (rev 285870)
@@ -1,3 +1,13 @@
+2021-11-16 Brady Eidson
+
+Enable webpushd tests in the iOS simulator.
+https://bugs.webkit.org/show_bug.cgi?id=233149
+
+Reviewed by Alex Christensen.
+
+* TestWebKitAPI/Tests/WebKitCocoa/WebPushDaemon.mm:
+(TestWebKitAPI::testWebPushDaemonPList): Add a key to allow an OSLaunchdJob executable to break out of the simulator runtime root.
+
2021-11-16 Tyler Wilcock
AX: Stop returning AccessibilityUIElements backed by a null pointer
Modified: trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/WebPushDaemon.mm (285869 => 285870)
--- trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/WebPushDaemon.mm 2021-11-16 17:11:53 UTC (rev 285869)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/WebPushDaemon.mm 2021-11-16 17:39:10 UTC (rev 285870)
@@ -32,8 +32,7 @@
#import
#import
-// FIXME: These tests are still currently disabled on iOS while tooling issues with `run-api-tests` are resolved.
-#if PLATFORM(MAC)
+#if PLATFORM(MAC) || PLATFORM(IOS)
static bool alertReceived = false;
@interface NotificationPermissionDelegate : NSObject
@@ -65,15 +64,18 @@
static RetainPtr testWebPushDaemonPList(NSURL *storageLocation)
{
+auto currentDirectory = currentExecutableDirectory();
+
auto plist = adoptNS(xpc_dictionary_create(nullptr, nullptr, 0));
xpc_dictionary_set_string(plist.get(), "_ManagedBy", "TestWebKitAPI");
xpc_dictionary_set_string(plist.get(), "Label", "org.webkit.webpushtestdaemon");
xpc_dictionary_set_bool(plist.get(), "LaunchOnlyOnce", true);
+xpc_dictionary_set_bool(plist.get(), "RootedSimulatorPath", true);
xpc_dictionary_set_string(plist.get(), "StandardErrorPath", [storageLocation URLByAppendingPathComponent:@"daemon_stderr"].path.fileSystemRepresentation);
{
auto environmentVariables = adoptNS(xpc_dictionary_create(nullptr, nullptr, 0));
-xpc_dictionary_set_string(environmentVariables.get(), "DYLD_FRAMEWORK_PATH", currentExecutableDirectory().get().fileSystemRepresentation);
+xpc_dictionary_set_string(environmentVariables.get(), "DYLD_FRAMEWORK_PATH", currentDirectory.get().fileSystemRepresentation);
xpc_dictionary_set_value(plist.get(), "EnvironmentVariables", environmentVariables.get());
}
{
@@ -87,10 +89,7 @@
#if PLATFORM(MAC)
xpc_array_set_string(programArguments.get(), XPC_ARRAY_APPEND, executableLocation.get().fileSystemRepresentation);
#else
-// FIXME: These tests are still currently disabled on iOS while tooling issues with `run-api-tests` are resolved.
-// Once enabled, this patch must point to the webpushd executable at a path that exists within
-// the simulator runtime root.
-xpc_array_set_string(programArguments.get(), XPC_ARRAY_APPEND, "/usr/local/bin/webkit-testing/webpushd");
+xpc_array_set_string(programArguments.get(), XPC_ARRAY_APPEND, [currentDirectory URLByAppendingPathComponent:@"webpushd"].path.fileSystemRepresentation);
#endif
xpc_array_set_string(programArguments.get(), XPC_ARRAY_APPEND, "--machServiceName");
xpc_array_set_string(programArguments.get(), XPC_ARRAY_APPEND, "org.webkit.webpushtestdaemon.service");
@@ -144,9 +143,15 @@
{
killFirstInstanceOfDaemon(@"webpushd");
-EXPECT_TRUE([[NSFileManager defaultManager] fileExistsAtPath:tempDir.path]);
+if (![[NSFileManager defaultManager] fileExistsAtPath:tempDir.path])
+return;
+
NSError *error = nil;
[[NSFileManager defaultManager] removeItemAtURL:tempDir error:];
+
+if (error)
+NSLog(@"Error removing tempDir URL: %@", error);
+
EXPECT_NULL(error);
}
@@ -263,4 +268,4 @@
} // namespace TestWebKitAPI
-#endif // PLATFORM(MAC)
+#endif // PLATFORM(MAC) || PLATFORM(IOS)
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [285868] trunk/Source/WebCore/PAL
Title: [285868] trunk/Source/WebCore/PAL
Revision 285868
Author mmaxfi...@apple.com
Date 2021-11-16 09:11:23 -0800 (Tue, 16 Nov 2021)
Log Message
[WebGPU] Vertex and fragment shaders are not hooked up to pipeline creation
https://bugs.webkit.org/show_bug.cgi?id=233166
Reviewed by Dean Jackson.
I simply forgot to implement them in r285831.
* pal/graphics/WebGPU/Impl/WebGPUAdapterImpl.cpp:
(PAL::WebGPU::supportedLimits):
* pal/graphics/WebGPU/Impl/WebGPUDeviceImpl.cpp:
(PAL::WebGPU::convertToBacking):
Modified Paths
trunk/Source/WebCore/PAL/ChangeLog
trunk/Source/WebCore/PAL/pal/graphics/WebGPU/Impl/WebGPUAdapterImpl.cpp
trunk/Source/WebCore/PAL/pal/graphics/WebGPU/Impl/WebGPUDeviceImpl.cpp
trunk/Source/WebCore/PAL/pal/graphics/WebGPU/Impl/WebGPUDeviceImpl.h
trunk/Source/WebCore/PAL/pal/graphics/WebGPU/Impl/WebGPURenderBundleEncoderImpl.h
trunk/Source/WebCore/PAL/pal/graphics/WebGPU/Impl/WebGPURenderPassEncoderImpl.h
Diff
Modified: trunk/Source/WebCore/PAL/ChangeLog (285867 => 285868)
--- trunk/Source/WebCore/PAL/ChangeLog 2021-11-16 17:11:06 UTC (rev 285867)
+++ trunk/Source/WebCore/PAL/ChangeLog 2021-11-16 17:11:23 UTC (rev 285868)
@@ -1,3 +1,17 @@
+2021-11-16 Myles C. Maxfield
+
+[WebGPU] Vertex and fragment shaders are not hooked up to pipeline creation
+https://bugs.webkit.org/show_bug.cgi?id=233166
+
+Reviewed by Dean Jackson.
+
+I simply forgot to implement them in r285831.
+
+* pal/graphics/WebGPU/Impl/WebGPUAdapterImpl.cpp:
+(PAL::WebGPU::supportedLimits):
+* pal/graphics/WebGPU/Impl/WebGPUDeviceImpl.cpp:
+(PAL::WebGPU::convertToBacking):
+
2021-11-15 Sam Weinig
Add another backend backed by SceneKit to prove out ModelPlayer infrastructure a bit more
Modified: trunk/Source/WebCore/PAL/pal/graphics/WebGPU/Impl/WebGPUAdapterImpl.cpp (285867 => 285868)
--- trunk/Source/WebCore/PAL/pal/graphics/WebGPU/Impl/WebGPUAdapterImpl.cpp 2021-11-16 17:11:06 UTC (rev 285867)
+++ trunk/Source/WebCore/PAL/pal/graphics/WebGPU/Impl/WebGPUAdapterImpl.cpp 2021-11-16 17:11:23 UTC (rev 285868)
@@ -89,7 +89,9 @@
static Ref supportedLimits(WGPUAdapter adapter)
{
WGPUSupportedLimits limits;
-wgpuAdapterGetLimits(adapter, );
+limits.nextInChain = nullptr;
+auto result = wgpuAdapterGetLimits(adapter, );
+ASSERT_UNUSED(result, result);
return SupportedLimits::create(
limits.limits.maxTextureDimension1D,
limits.limits.maxTextureDimension2D,
Modified: trunk/Source/WebCore/PAL/pal/graphics/WebGPU/Impl/WebGPUDeviceImpl.cpp (285867 => 285868)
--- trunk/Source/WebCore/PAL/pal/graphics/WebGPU/Impl/WebGPUDeviceImpl.cpp 2021-11-16 17:11:06 UTC (rev 285867)
+++ trunk/Source/WebCore/PAL/pal/graphics/WebGPU/Impl/WebGPUDeviceImpl.cpp 2021-11-16 17:11:23 UTC (rev 285868)
@@ -235,8 +235,18 @@
{
auto label = descriptor.label.utf8();
+auto source = descriptor.code.utf8();
+
+WGPUShaderModuleWGSLDescriptor backingWGSLDescriptor {
+{
+nullptr,
+WGPUSType_ShaderModuleWGSLDescriptor,
+},
+source.data(),
+};
+
WGPUShaderModuleDescriptor backingDescriptor {
-nullptr,
+,
label.data(),
};
@@ -250,10 +260,10 @@
auto entryPoint = descriptor.compute.entryPoint.utf8();
-Vector keys;
-keys.reserveInitialCapacity(descriptor.compute.constants.size());
+Vector constantNames;
+constantNames.reserveInitialCapacity(descriptor.compute.constants.size());
for (const auto& constant : descriptor.compute.constants)
-keys.uncheckedAppend(constant.key.utf8());
+constantNames.uncheckedAppend(constant.key.utf8());
Vector backingConstantEntries;
backingConstantEntries.reserveInitialCapacity(descriptor.compute.constants.size());
@@ -261,7 +271,7 @@
const auto& constant = descriptor.compute.constants[i];
backingConstantEntries.uncheckedAppend(WGPUConstantEntry {
nullptr,
-keys[i].data(),
+constantNames[i].data(),
constant.value
});
}
@@ -293,6 +303,24 @@
{
auto label = descriptor.label.utf8();
+auto vertexEntryPoint = descriptor.vertex.entryPoint.utf8();
+
+Vector vertexConstantNames;
+vertexConstantNames.reserveInitialCapacity(descriptor.vertex.constants.size());
+for (const auto& constant : descriptor.vertex.constants)
+vertexConstantNames.uncheckedAppend(constant.key.utf8());
+
+Vector vertexConstantEntries;
+vertexConstantEntries.reserveInitialCapacity(descriptor.vertex.constants.size());
+for (size_t i = 0; i < descriptor.vertex.constants.size(); ++i) {
+const auto& constant = descriptor.vertex.constants[i];
+vertexConstantEntries.uncheckedAppend(WGPUConstantEntry {
+nullptr,
+vertexConstantNames[i].data(),
+constant.value,
+});
+}
+
Vector> backingAttributes;
[webkit-changes] [285869] trunk/Source/WebKit
Title: [285869] trunk/Source/WebKit
Revision 285869
Author pvol...@apple.com
Date 2021-11-16 09:11:53 -0800 (Tue, 16 Nov 2021)
Log Message
[macOS][GPUP] Add telemetry for syscalls
https://bugs.webkit.org/show_bug.cgi?id=232888
Reviewed by Brent Fulgham.
Add more telemetry for syscalls in the GPU process' sandbox on macOS. Also add entitlement for the GPU
process to use message filtering.
* GPUProcess/mac/com.apple.WebKit.GPUProcess.sb.in:
* Scripts/process-entitlements.sh:
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/GPUProcess/mac/com.apple.WebKit.GPUProcess.sb.in
trunk/Source/WebKit/Scripts/process-entitlements.sh
Diff
Modified: trunk/Source/WebKit/ChangeLog (285868 => 285869)
--- trunk/Source/WebKit/ChangeLog 2021-11-16 17:11:23 UTC (rev 285868)
+++ trunk/Source/WebKit/ChangeLog 2021-11-16 17:11:53 UTC (rev 285869)
@@ -1,3 +1,17 @@
+2021-11-16 Per Arne Vollan
+
+[macOS][GPUP] Add telemetry for syscalls
+https://bugs.webkit.org/show_bug.cgi?id=232888
+
+
+Reviewed by Brent Fulgham.
+
+Add more telemetry for syscalls in the GPU process' sandbox on macOS. Also add entitlement for the GPU
+process to use message filtering.
+
+* GPUProcess/mac/com.apple.WebKit.GPUProcess.sb.in:
+* Scripts/process-entitlements.sh:
+
2021-11-16 Chris Dumez
Decoder::unwrapForTesting() is unnecessarily inefficient
Modified: trunk/Source/WebKit/GPUProcess/mac/com.apple.WebKit.GPUProcess.sb.in (285868 => 285869)
--- trunk/Source/WebKit/GPUProcess/mac/com.apple.WebKit.GPUProcess.sb.in 2021-11-16 17:11:23 UTC (rev 285868)
+++ trunk/Source/WebKit/GPUProcess/mac/com.apple.WebKit.GPUProcess.sb.in 2021-11-16 17:11:53 UTC (rev 285869)
@@ -856,6 +856,41 @@
)
)
+(when (and (equal? (param "ENABLE_SANDBOX_MESSAGE_FILTER") "YES") (defined? 'mach-kernel-endpoint))
+(allow mach-kernel-endpoint
+(apply-message-filter
+(allow mach-message-send (with telemetry)
+
+(when (and (equal? (param "ENABLE_SANDBOX_MESSAGE_FILTER") "YES") (defined? 'syscall-mach))
+(allow syscall-mach (with telemetry))
+(allow syscall-mach (machtrap-number
+MSC__kernelrpc_mach_port_allocate_trap
+MSC__kernelrpc_mach_port_construct_trap
+MSC__kernelrpc_mach_port_deallocate_trap
+MSC__kernelrpc_mach_port_destruct_trap
+MSC__kernelrpc_mach_port_extract_member_trap
+MSC__kernelrpc_mach_port_guard_trap
+MSC__kernelrpc_mach_port_insert_member_trap
+MSC__kernelrpc_mach_port_insert_right_trap
+MSC__kernelrpc_mach_port_mod_refs_trap
+MSC__kernelrpc_mach_port_request_notification_trap
+MSC__kernelrpc_mach_port_type_trap
+MSC__kernelrpc_mach_vm_allocate_trap
+MSC__kernelrpc_mach_vm_deallocate_trap
+MSC__kernelrpc_mach_vm_map_trap
+MSC__kernelrpc_mach_vm_protect_trap
+MSC_host_create_mach_voucher_trap
+MSC_host_self_trap
+MSC_mach_msg_trap
+MSC_mach_reply_port
+MSC_mach_voucher_extract_attr_recipe_trap
+MSC_pid_for_task
+MSC_semaphore_signal_trap
+MSC_semaphore_wait_trap
+MSC_swtch_pri
+MSC_syscall_thread_switch
+MSC_thread_get_special_reply_port)))
+
(when (defined? 'syscall-unix)
(allow syscall-unix (with telemetry))
(allow syscall-unix (syscall-number
Modified: trunk/Source/WebKit/Scripts/process-entitlements.sh (285868 => 285869)
--- trunk/Source/WebKit/Scripts/process-entitlements.sh 2021-11-16 17:11:23 UTC (rev 285868)
+++ trunk/Source/WebKit/Scripts/process-entitlements.sh 2021-11-16 17:11:53 UTC (rev 285869)
@@ -57,6 +57,7 @@
if (( "${TARGET_MAC_OS_X_VERSION_MAJOR}" >= 11 ))
then
+plistbuddy Add :com.apple.private.security.message-filter bool YES
plistbuddy Add :com.apple.security.cs.jit-write-allowlist bool YES
fi
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [285867] trunk/Source/WebCore
Title: [285867] trunk/Source/WebCore
Revision 285867
Author you...@apple.com
Date 2021-11-16 09:11:06 -0800 (Tue, 16 Nov 2021)
Log Message
Remove unused Xcode references to ServiceWorkerGlobalScopePushAPI files
https://bugs.webkit.org/show_bug.cgi?id=233177
Reviewed by Alex Christensen.
No change of behavior.
* Modules/push-api/ServiceWorkerGlobalScope+PushAPI.idl:
* WebCore.xcodeproj/project.pbxproj:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/push-api/ServiceWorkerGlobalScope+PushAPI.idl
trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj
Diff
Modified: trunk/Source/WebCore/ChangeLog (285866 => 285867)
--- trunk/Source/WebCore/ChangeLog 2021-11-16 16:57:55 UTC (rev 285866)
+++ trunk/Source/WebCore/ChangeLog 2021-11-16 17:11:06 UTC (rev 285867)
@@ -1,3 +1,15 @@
+2021-11-16 Youenn Fablet
+
+Remove unused Xcode references to ServiceWorkerGlobalScopePushAPI files
+https://bugs.webkit.org/show_bug.cgi?id=233177
+
+Reviewed by Alex Christensen.
+
+No change of behavior.
+
+* Modules/push-api/ServiceWorkerGlobalScope+PushAPI.idl:
+* WebCore.xcodeproj/project.pbxproj:
+
2021-11-16 Alan Bujtas
[LFC][IFC] Fix fast/text/basic/005.html
Modified: trunk/Source/WebCore/Modules/push-api/ServiceWorkerGlobalScope+PushAPI.idl (285866 => 285867)
--- trunk/Source/WebCore/Modules/push-api/ServiceWorkerGlobalScope+PushAPI.idl 2021-11-16 16:57:55 UTC (rev 285866)
+++ trunk/Source/WebCore/Modules/push-api/ServiceWorkerGlobalScope+PushAPI.idl 2021-11-16 17:11:06 UTC (rev 285867)
@@ -24,8 +24,7 @@
*/
[
-EnabledAtRuntime=ServiceWorkerEnabled,
-ImplementedBy=ServiceWorkerGlobalScopePushAPI
+EnabledAtRuntime=ServiceWorkerEnabled
] partial interface ServiceWorkerGlobalScope {
attribute EventHandler onpush;
};
Modified: trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj (285866 => 285867)
--- trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj 2021-11-16 16:57:55 UTC (rev 285866)
+++ trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj 2021-11-16 17:11:06 UTC (rev 285867)
@@ -8459,8 +8459,6 @@
418FCBC02706E4F800F96ECA /* PushEvent.idl */ = {isa = PBXFileReference; lastKnownFileType = text; path = PushEvent.idl; sourceTree = ""; };
418FCBC32706E62C00F96ECA /* PushEventInit.idl */ = {isa = PBXFileReference; lastKnownFileType = text; path = PushEventInit.idl; sourceTree = ""; };
418FCBCB2706F3CD00F96ECA /* ServiceWorkerGlobalScope+PushAPI.idl */ = {isa = PBXFileReference; lastKnownFileType = text; path = "ServiceWorkerGlobalScope+PushAPI.idl"; sourceTree = ""; };
- 418FCBCC2706F43400F96ECA /* ServiceWorkerGlobalScopePushAPI.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; path = ServiceWorkerGlobalScopePushAPI.h; sourceTree = ""; };
- 418FCBCD2706F43400F96ECA /* ServiceWorkerGlobalScopePushAPI.cpp */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.cpp.cpp; path = ServiceWorkerGlobalScopePushAPI.cpp; sourceTree = ""; };
418FCBEA2715B60F00F96ECA /* WorkerNavigator+MediaCapabilities.idl */ = {isa = PBXFileReference; lastKnownFileType = text; path = "WorkerNavigator+MediaCapabilities.idl"; sourceTree = ""; };
418FCBEC2715B85100F96ECA /* WorkerNavigatorMediaCapabilities.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; path = WorkerNavigatorMediaCapabilities.h; sourceTree = ""; };
418FCBED2715B85200F96ECA /* WorkerNavigatorMediaCapabilities.cpp */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.cpp.cpp; path = WorkerNavigatorMediaCapabilities.cpp; sourceTree = ""; };
@@ -20656,8 +20654,6 @@
EB0FB701270D0AEA00F7810D /* PushSubscriptionOptionsInit.h */,
EB0FB6FF270D0AE900F7810D /* PushSubscriptionOptionsInit.idl */,
418FCBCB2706F3CD00F96ECA /* ServiceWorkerGlobalScope+PushAPI.idl */,
-418FCBCD2706F43400F96ECA /* ServiceWorkerGlobalScopePushAPI.cpp */,
-418FCBCC2706F43400F96ECA /* ServiceWorkerGlobalScopePushAPI.h */,
EBB9737B27100652007732EF /* ServiceWorkerRegistration+PushAPI.idl */,
EBB9737D27100653007732EF /* ServiceWorkerRegistrationPushAPI.cpp */,
EBB9737A27100652007732EF /* ServiceWorkerRegistrationPushAPI.h */,
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [285866] trunk/Source/WebKit
Title: [285866] trunk/Source/WebKit
Revision 285866
Author cdu...@apple.com
Date 2021-11-16 08:57:55 -0800 (Tue, 16 Nov 2021)
Log Message
Decoder::unwrapForTesting() is unnecessarily inefficient
https://bugs.webkit.org/show_bug.cgi?id=233145
Reviewed by Darin Adler.
Decoder::unwrapForTesting() is unnecessarily inefficient. It can take the whole
m_attachments data members from the decoder instead of calling removeAttachment()
repeatedly on the Decoder.
Also rename removeAttachment() to takeAttachment() since it returns the Attachment.
Update it to return a std::optional instead of using an out-parameter.
* Platform/IPC/Attachment.cpp:
(IPC::Attachment::decode):
* Platform/IPC/Attachment.h:
* Platform/IPC/Decoder.cpp:
(IPC::Decoder::unwrapForTesting):
(IPC::Decoder::takeAttachment):
(IPC::Decoder::removeAttachment): Deleted.
* Platform/IPC/Decoder.h:
* Platform/IPC/win/AttachmentWin.cpp:
(IPC::Attachment::decode):
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Platform/IPC/Attachment.cpp
trunk/Source/WebKit/Platform/IPC/Attachment.h
trunk/Source/WebKit/Platform/IPC/Decoder.cpp
trunk/Source/WebKit/Platform/IPC/Decoder.h
trunk/Source/WebKit/Platform/IPC/win/AttachmentWin.cpp
Diff
Modified: trunk/Source/WebKit/ChangeLog (285865 => 285866)
--- trunk/Source/WebKit/ChangeLog 2021-11-16 16:51:30 UTC (rev 285865)
+++ trunk/Source/WebKit/ChangeLog 2021-11-16 16:57:55 UTC (rev 285866)
@@ -1,5 +1,30 @@
2021-11-16 Chris Dumez
+Decoder::unwrapForTesting() is unnecessarily inefficient
+https://bugs.webkit.org/show_bug.cgi?id=233145
+
+Reviewed by Darin Adler.
+
+Decoder::unwrapForTesting() is unnecessarily inefficient. It can take the whole
+m_attachments data members from the decoder instead of calling removeAttachment()
+repeatedly on the Decoder.
+
+Also rename removeAttachment() to takeAttachment() since it returns the Attachment.
+Update it to return a std::optional instead of using an out-parameter.
+
+* Platform/IPC/Attachment.cpp:
+(IPC::Attachment::decode):
+* Platform/IPC/Attachment.h:
+* Platform/IPC/Decoder.cpp:
+(IPC::Decoder::unwrapForTesting):
+(IPC::Decoder::takeAttachment):
+(IPC::Decoder::removeAttachment): Deleted.
+* Platform/IPC/Decoder.h:
+* Platform/IPC/win/AttachmentWin.cpp:
+(IPC::Attachment::decode):
+
+2021-11-16 Chris Dumez
+
Do some hardening in IPC::createMessageDecoder()
https://bugs.webkit.org/show_bug.cgi?id=233148
Modified: trunk/Source/WebKit/Platform/IPC/Attachment.cpp (285865 => 285866)
--- trunk/Source/WebKit/Platform/IPC/Attachment.cpp 2021-11-16 16:51:30 UTC (rev 285865)
+++ trunk/Source/WebKit/Platform/IPC/Attachment.cpp 2021-11-16 16:57:55 UTC (rev 285866)
@@ -56,11 +56,9 @@
encoder.addAttachment(WTFMove(*const_cast(this)));
}
-bool Attachment::decode(Decoder& decoder, Attachment& attachment)
+std::optional Attachment::decode(Decoder& decoder)
{
-if (!decoder.removeAttachment(attachment))
-return false;
-return true;
+return decoder.takeLastAttachment();
}
#endif
Modified: trunk/Source/WebKit/Platform/IPC/Attachment.h (285865 => 285866)
--- trunk/Source/WebKit/Platform/IPC/Attachment.h 2021-11-16 16:51:30 UTC (rev 285865)
+++ trunk/Source/WebKit/Platform/IPC/Attachment.h 2021-11-16 16:57:55 UTC (rev 285866)
@@ -26,6 +26,8 @@
#pragma once
+#include
+
#if OS(DARWIN) && !USE(UNIX_DOMAIN_SOCKETS)
#include
#include
@@ -98,7 +100,7 @@
#endif
void encode(Encoder&) const;
-static WARN_UNUSED_RETURN bool decode(Decoder&, Attachment&);
+static std::optional decode(Decoder&);
private:
Type m_type;
Modified: trunk/Source/WebKit/Platform/IPC/Decoder.cpp (285865 => 285866)
--- trunk/Source/WebKit/Platform/IPC/Decoder.cpp 2021-11-16 16:51:30 UTC (rev 285865)
+++ trunk/Source/WebKit/Platform/IPC/Decoder.cpp 2021-11-16 16:57:55 UTC (rev 285866)
@@ -33,10 +33,6 @@
#include
#include
-#if PLATFORM(MAC)
-#include "ImportanceAssertion.h"
-#endif
-
namespace IPC {
static const uint8_t* copyBuffer(const uint8_t* buffer, size_t bufferSize)
@@ -147,11 +143,7 @@
{
ASSERT(decoder.isSyncMessage());
-Vector attachments;
-Attachment attachment;
-while (decoder.removeAttachment(attachment))
-attachments.append(WTFMove(attachment));
-attachments.reverse();
+auto attachments = std::exchange(decoder.m_attachments, { });
DataReference wrappedMessage;
if (!decoder.decode(wrappedMessage))
@@ -218,13 +210,11 @@
return data;
}
-bool Decoder::removeAttachment(Attachment& attachment)
+std::optional Decoder::takeLastAttachment()
{
if (m_attachments.isEmpty())
-return false;
-
-attachment = m_attachments.takeLast();
-return true;
+return std::nullopt;
+return m_attachments.takeLast();
}
} // namespace IPC
Modified:
[webkit-changes] [285865] trunk/Source/WebKit
Title: [285865] trunk/Source/WebKit
Revision 285865
Author cdu...@apple.com
Date 2021-11-16 08:51:30 -0800 (Tue, 16 Nov 2021)
Log Message
Do some hardening in IPC::createMessageDecoder()
https://bugs.webkit.org/show_bug.cgi?id=233148
Reviewed by Darin Adler.
Do more bound validation insde createMessageDecoder() to make sure we stay within
the bounds of our ReceiveBuffer.
Also, when the body is out of line, set `out_of_line.deallocate` to false since
we are taking ownership of the memory and will vm_deallocate() it ourselves.
Normally the sender (Connection::sendOutgoingMessage) sets that flag to false but
it is better not to rely on the sender setting a particular flag.
* Platform/IPC/cocoa/ConnectionCocoa.mm:
(IPC::createMessageDecoder):
(IPC::Connection::receiveSourceEventHandler):
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Platform/IPC/cocoa/ConnectionCocoa.mm
Diff
Modified: trunk/Source/WebKit/ChangeLog (285864 => 285865)
--- trunk/Source/WebKit/ChangeLog 2021-11-16 16:47:40 UTC (rev 285864)
+++ trunk/Source/WebKit/ChangeLog 2021-11-16 16:51:30 UTC (rev 285865)
@@ -1,3 +1,23 @@
+2021-11-16 Chris Dumez
+
+Do some hardening in IPC::createMessageDecoder()
+https://bugs.webkit.org/show_bug.cgi?id=233148
+
+
+Reviewed by Darin Adler.
+
+Do more bound validation insde createMessageDecoder() to make sure we stay within
+the bounds of our ReceiveBuffer.
+
+Also, when the body is out of line, set `out_of_line.deallocate` to false since
+we are taking ownership of the memory and will vm_deallocate() it ourselves.
+Normally the sender (Connection::sendOutgoingMessage) sets that flag to false but
+it is better not to rely on the sender setting a particular flag.
+
+* Platform/IPC/cocoa/ConnectionCocoa.mm:
+(IPC::createMessageDecoder):
+(IPC::Connection::receiveSourceEventHandler):
+
2021-11-16 J Pascoe
[WebAuthn] WebKitTestRunner/TWAPI lacks an entitlement and bundle identifier to use required [ASCAgent performAuthorizationRequestsForContext]
Modified: trunk/Source/WebKit/Platform/IPC/cocoa/ConnectionCocoa.mm (285864 => 285865)
--- trunk/Source/WebKit/Platform/IPC/cocoa/ConnectionCocoa.mm 2021-11-16 16:47:40 UTC (rev 285864)
+++ trunk/Source/WebKit/Platform/IPC/cocoa/ConnectionCocoa.mm 2021-11-16 16:51:30 UTC (rev 285865)
@@ -408,8 +408,14 @@
sendOutgoingMessages();
}
-static std::unique_ptr createMessageDecoder(mach_msg_header_t* header)
+static std::unique_ptr createMessageDecoder(mach_msg_header_t* header, size_t bufferSize)
{
+if (UNLIKELY(header->msgh_size > bufferSize)) {
+RELEASE_LOG_FAULT(IPC, "createMessageDecoder: msgh_size is greater than bufferSize (header->msgh_size: %lu, bufferSize: %lu)", static_cast(header->msgh_size), bufferSize);
+ASSERT_NOT_REACHED();
+return nullptr;
+}
+
if (!(header->msgh_bits & MACH_MSGH_BITS_COMPLEX)) {
// We have a simple message.
uint8_t* body = reinterpret_cast(header + 1);
@@ -426,9 +432,16 @@
mach_msg_body_t* body = reinterpret_cast(header + 1);
mach_msg_size_t numberOfPortDescriptors = body->msgh_descriptor_count;
ASSERT(numberOfPortDescriptors);
-if (!numberOfPortDescriptors)
+if (UNLIKELY(!numberOfPortDescriptors))
return nullptr;
+auto sizeWithPortDescriptors = CheckedSize { sizeof(mach_msg_header_t) + sizeof(mach_msg_body_t) } + CheckedSize { numberOfPortDescriptors } * sizeof(mach_msg_port_descriptor_t);
+if (UNLIKELY(sizeWithPortDescriptors.hasOverflowed() || sizeWithPortDescriptors.value() > bufferSize)) {
+RELEASE_LOG_FAULT(IPC, "createMessageDecoder: Overflow when computing sizeWithPortDescriptors (numberOfPortDescriptors: %lu)", static_cast(numberOfPortDescriptors));
+ASSERT_NOT_REACHED();
+return nullptr;
+}
+
uint8_t* descriptorData = reinterpret_cast(body + 1);
// If the message body was sent out-of-line, don't treat the last descriptor
@@ -445,7 +458,7 @@
if (descriptor->type.type != MACH_MSG_PORT_DESCRIPTOR)
return nullptr;
-attachments[numberOfAttachments - i - 1] = Attachment(descriptor->port.name, descriptor->port.disposition);
+attachments[numberOfAttachments - i - 1] = Attachment { descriptor->port.name, descriptor->port.disposition };
descriptorData += sizeof(mach_msg_port_descriptor_t);
}
@@ -457,6 +470,7 @@
uint8_t* messageBody = static_cast(descriptor->out_of_line.address);
size_t messageBodySize = descriptor->out_of_line.size;
+descriptor->out_of_line.deallocate = false; // We are taking ownership of the memory.
return Decoder::create(messageBody, messageBodySize, [](const uint8_t* buffer, size_t length) {
// FIXME: bufferDeallocator block ignores mach_msg_ool_descriptor_t->deallocate
@@ -465,10 +479,10 @@
}
[webkit-changes] [285864] trunk/Source/WebKit
Title: [285864] trunk/Source/WebKit
Revision 285864
Author j_pas...@apple.com
Date 2021-11-16 08:47:40 -0800 (Tue, 16 Nov 2021)
Log Message
[WebAuthn] WebKitTestRunner/TWAPI lacks an entitlement and bundle identifier to use required [ASCAgent performAuthorizationRequestsForContext]
https://bugs.webkit.org/show_bug.cgi?id=232846
rdar://problem/85170633
Reviewed by Brent Fulgham.
Covered by existing tests.
Calling to ASC requires converting WebAuthenticationRequestData to ASCCredentialRequestContext and then making
a call to _WKAuthenticatorAssertionResponse, while also requiring entitlements currently unavailable in OpenSource.
This change avoids calling out to ASC in tests using mock / virtual authenticators to avoid this problem, the
serialization to and from ASCAgent can be tested seperately.
* UIProcess/WebAuthentication/Cocoa/WebAuthenticatorCoordinatorProxy.mm:
Refactor creation of ASCCredentialRequestContext.
(WebKit::WebAuthenticatorCoordinatorProxy::isUserVerifyingPlatformAuthenticatorAvailable):
* UIProcess/WebAuthentication/WebAuthenticatorCoordinatorProxy.cpp:
(WebKit::WebAuthenticatorCoordinatorProxy::handleRequest):
Refactor use of ASC and add clarifying comment about flow.
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/WebAuthentication/Cocoa/WebAuthenticatorCoordinatorProxy.mm
trunk/Source/WebKit/UIProcess/WebAuthentication/WebAuthenticatorCoordinatorProxy.cpp
trunk/Source/WebKit/UIProcess/WebAuthentication/WebAuthenticatorCoordinatorProxy.h
Diff
Modified: trunk/Source/WebKit/ChangeLog (285863 => 285864)
--- trunk/Source/WebKit/ChangeLog 2021-11-16 16:38:52 UTC (rev 285863)
+++ trunk/Source/WebKit/ChangeLog 2021-11-16 16:47:40 UTC (rev 285864)
@@ -1,3 +1,25 @@
+2021-11-16 J Pascoe
+
+[WebAuthn] WebKitTestRunner/TWAPI lacks an entitlement and bundle identifier to use required [ASCAgent performAuthorizationRequestsForContext]
+https://bugs.webkit.org/show_bug.cgi?id=232846
+rdar://problem/85170633
+
+Reviewed by Brent Fulgham.
+
+Covered by existing tests.
+
+Calling to ASC requires converting WebAuthenticationRequestData to ASCCredentialRequestContext and then making
+a call to _WKAuthenticatorAssertionResponse, while also requiring entitlements currently unavailable in OpenSource.
+This change avoids calling out to ASC in tests using mock / virtual authenticators to avoid this problem, the
+serialization to and from ASCAgent can be tested seperately.
+
+* UIProcess/WebAuthentication/Cocoa/WebAuthenticatorCoordinatorProxy.mm:
+Refactor creation of ASCCredentialRequestContext.
+(WebKit::WebAuthenticatorCoordinatorProxy::isUserVerifyingPlatformAuthenticatorAvailable):
+* UIProcess/WebAuthentication/WebAuthenticatorCoordinatorProxy.cpp:
+(WebKit::WebAuthenticatorCoordinatorProxy::handleRequest):
+Refactor use of ASC and add clarifying comment about flow.
+
2021-11-16 Kimmo Kinnunen
RemoteGraphicsContextGLCocoa::m_swapChain is unused
Modified: trunk/Source/WebKit/UIProcess/WebAuthentication/Cocoa/WebAuthenticatorCoordinatorProxy.mm (285863 => 285864)
--- trunk/Source/WebKit/UIProcess/WebAuthentication/Cocoa/WebAuthenticatorCoordinatorProxy.mm 2021-11-16 16:38:52 UTC (rev 285863)
+++ trunk/Source/WebKit/UIProcess/WebAuthentication/Cocoa/WebAuthenticatorCoordinatorProxy.mm 2021-11-16 16:47:40 UTC (rev 285864)
@@ -238,18 +238,17 @@
return requestContext;
}
-void WebAuthenticatorCoordinatorProxy::makeCredential(FrameIdentifier frameId, FrameInfoData&& frameInfo, Vector&& hash, PublicKeyCredentialCreationOptions&& options, bool processingUserGesture, RequestCompletionHandler&& handler)
+RetainPtr WebAuthenticatorCoordinatorProxy::contextForRequest(WebAuthenticationRequestData&& requestData)
{
-auto requestContext = configureRegistrationRequestContext(options);
-performRequest(requestContext, WTFMove(handler));
+RetainPtr result;
+WTF::switchOn(requestData.options, [&](const PublicKeyCredentialCreationOptions& options) {
+result = configureRegistrationRequestContext(options);
+}, [&](const PublicKeyCredentialRequestOptions& options) {
+result = configurationAssertionRequestContext(options);
+});
+return result;
}
-void WebAuthenticatorCoordinatorProxy::getAssertion(FrameIdentifier frameId, FrameInfoData&& frameInfo, Vector&& hash, PublicKeyCredentialRequestOptions&& options, bool processingUserGesture, RequestCompletionHandler&& handler)
-{
-auto requestContext = configurationAssertionRequestContext(options);
-performRequest(requestContext, WTFMove(handler));
-}
-
void WebAuthenticatorCoordinatorProxy::performRequest(RetainPtr requestContext, RequestCompletionHandler&& handler)
{
auto proxy = adoptNS([allocASCAgentProxyInstance() init]);
Modified: trunk/Source/WebKit/UIProcess/WebAuthentication/WebAuthenticatorCoordinatorProxy.cpp (285863 =>
[webkit-changes] [285863] trunk/Source/WebCore
Title: [285863] trunk/Source/WebCore
Revision 285863
Author za...@apple.com
Date 2021-11-16 08:38:52 -0800 (Tue, 16 Nov 2021)
Log Message
[LFC][IFC] Fix fast/text/basic/005.html
https://bugs.webkit.org/show_bug.cgi?id=233150
Reviewed by Antti Koivisto.
Negative word-spacing acts as negative margin, pulling the content to the left. In this patch we account for such negative values when
computing the overall content width.
Note that this patch is in preparation for enabling IFC preferred width computation.
* layout/formattingContexts/inline/InlineLine.cpp:
(WebCore::Layout::Line::appendTextContent):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/layout/formattingContexts/inline/InlineLine.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (285862 => 285863)
--- trunk/Source/WebCore/ChangeLog 2021-11-16 16:37:05 UTC (rev 285862)
+++ trunk/Source/WebCore/ChangeLog 2021-11-16 16:38:52 UTC (rev 285863)
@@ -1,3 +1,18 @@
+2021-11-16 Alan Bujtas
+
+[LFC][IFC] Fix fast/text/basic/005.html
+https://bugs.webkit.org/show_bug.cgi?id=233150
+
+Reviewed by Antti Koivisto.
+
+Negative word-spacing acts as negative margin, pulling the content to the left. In this patch we account for such negative values when
+computing the overall content width.
+
+Note that this patch is in preparation for enabling IFC preferred width computation.
+
+* layout/formattingContexts/inline/InlineLine.cpp:
+(WebCore::Layout::Line::appendTextContent):
+
2021-11-16 Wenson Hsieh
Add support for injecting and rendering text recognition blocks
Modified: trunk/Source/WebCore/layout/formattingContexts/inline/InlineLine.cpp (285862 => 285863)
--- trunk/Source/WebCore/layout/formattingContexts/inline/InlineLine.cpp 2021-11-16 16:37:05 UTC (rev 285862)
+++ trunk/Source/WebCore/layout/formattingContexts/inline/InlineLine.cpp 2021-11-16 16:38:52 UTC (rev 285863)
@@ -343,17 +343,27 @@
auto contentLogicalRight = runLogicalLeft + logicalWidth + m_clonedEndDecorationWidthForInlineBoxRuns;
m_contentLogicalWidth = std::max(oldContentLogicalWidth, contentLogicalRight);
} else if (style.letterSpacing() >= 0) {
-m_runs.last().expand(inlineTextItem, logicalWidth);
-m_contentLogicalWidth += logicalWidth;
+auto& lastRun = m_runs.last();
+lastRun.expand(inlineTextItem, logicalWidth);
+// Ensure that property values that act like negative margin are not making the line wider.
+m_contentLogicalWidth = std::max(oldContentLogicalWidth, lastRun.logicalRight());
} else {
auto& lastRun = m_runs.last();
ASSERT(lastRun.isText());
// Negative letter spacing should only shorten the content to the boundary of the previous run.
// FIXME: We may need to traverse all the way to the previous non-text run (or even across inline boxes).
-auto lastRunLogicalWidth = lastRun.logicalWidth();
-auto contentWidthWithoutLastTextRun = m_contentLogicalWidth - std::max(0.f, lastRunLogicalWidth);
+auto contentWidthWithoutLastTextRun = [&] {
+if (style.fontCascade().wordSpacing() >= 0)
+return m_contentLogicalWidth - std::max(0.f, lastRun.logicalWidth());
+// FIXME: Let's see if we need to optimize for this is the rare case of both letter and word spacing being negative.
+auto rightMostPosition = InlineLayoutUnit { };
+for (auto& run : makeReversedRange(m_runs))
+rightMostPosition = std::max(rightMostPosition, run.logicalRight());
+return std::max(0.f, rightMostPosition);
+}();
+auto lastRunLogicalRight = lastRun.logicalRight();
lastRun.expand(inlineTextItem, logicalWidth);
-m_contentLogicalWidth = std::max(contentWidthWithoutLastTextRun, lastRunLogicalWidth + logicalWidth);
+m_contentLogicalWidth = std::max(contentWidthWithoutLastTextRun, lastRunLogicalRight + logicalWidth);
}
// Handle trailing content, specifically whitespace and letter spacing.
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [285862] trunk/Source/WebCore
Title: [285862] trunk/Source/WebCore
Revision 285862
Author wenson_hs...@apple.com
Date 2021-11-16 08:37:05 -0800 (Tue, 16 Nov 2021)
Log Message
Add support for injecting and rendering text recognition blocks
https://bugs.webkit.org/show_bug.cgi?id=233044
Reviewed by Aditya Keerthi.
Adds support for rendering text recognition blocks, which appear as opaque div elements over images. See below
for more details; no change in behavior, since nothing currently generates TextRecognitionBlockData yet.
* dom/ImageOverlay.cpp:
(WebCore::ImageOverlay::imageOverlayDataDetectorClass):
(WebCore::ImageOverlay::imageOverlayBlockClass):
(WebCore::ImageOverlay::isDataDetectorResult):
(WebCore::ImageOverlay::updateSubtree):
Add support for creating text recognition block containers in the UA shadow root, if needed.
(WebCore::ImageOverlay::fitElementToQuad):
Factor out logic to adjust the width, height and transforms on a given element to fit the given quad, and return
rotated bounding rect info; we use this in three places below.
(WebCore::ImageOverlay::updateWithTextRecognitionResult):
Add support for adjusting the size and transforms on each of the block containers created above.
(WebCore::ImageOverlay::imageOverlayDataDetectorClassName): Deleted.
Rename this to just `imageOverlayDataDetectorClass()` to match the other static helper functions.
* html/shadow/imageOverlay.css:
(div#image-overlay):
(div.image-overlay-line):
(div.image-overlay-line, div.image-overlay-block):
(div.image-overlay-block):
(div.image-overlay-line, .image-overlay-text):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/ImageOverlay.cpp
trunk/Source/WebCore/html/shadow/imageOverlay.css
Diff
Modified: trunk/Source/WebCore/ChangeLog (285861 => 285862)
--- trunk/Source/WebCore/ChangeLog 2021-11-16 15:24:18 UTC (rev 285861)
+++ trunk/Source/WebCore/ChangeLog 2021-11-16 16:37:05 UTC (rev 285862)
@@ -1,3 +1,41 @@
+2021-11-16 Wenson Hsieh
+
+Add support for injecting and rendering text recognition blocks
+https://bugs.webkit.org/show_bug.cgi?id=233044
+
+Reviewed by Aditya Keerthi.
+
+Adds support for rendering text recognition blocks, which appear as opaque div elements over images. See below
+for more details; no change in behavior, since nothing currently generates TextRecognitionBlockData yet.
+
+* dom/ImageOverlay.cpp:
+(WebCore::ImageOverlay::imageOverlayDataDetectorClass):
+(WebCore::ImageOverlay::imageOverlayBlockClass):
+(WebCore::ImageOverlay::isDataDetectorResult):
+(WebCore::ImageOverlay::updateSubtree):
+
+Add support for creating text recognition block containers in the UA shadow root, if needed.
+
+(WebCore::ImageOverlay::fitElementToQuad):
+
+Factor out logic to adjust the width, height and transforms on a given element to fit the given quad, and return
+rotated bounding rect info; we use this in three places below.
+
+(WebCore::ImageOverlay::updateWithTextRecognitionResult):
+
+Add support for adjusting the size and transforms on each of the block containers created above.
+
+(WebCore::ImageOverlay::imageOverlayDataDetectorClassName): Deleted.
+
+Rename this to just `imageOverlayDataDetectorClass()` to match the other static helper functions.
+
+* html/shadow/imageOverlay.css:
+(div#image-overlay):
+(div.image-overlay-line):
+(div.image-overlay-line, div.image-overlay-block):
+(div.image-overlay-block):
+(div.image-overlay-line, .image-overlay-text):
+
2021-11-16 Andreu Botella
Empty is represented incorrectly in FormData
Modified: trunk/Source/WebCore/dom/ImageOverlay.cpp (285861 => 285862)
--- trunk/Source/WebCore/dom/ImageOverlay.cpp 2021-11-16 15:24:18 UTC (rev 285861)
+++ trunk/Source/WebCore/dom/ImageOverlay.cpp 2021-11-16 16:37:05 UTC (rev 285862)
@@ -63,7 +63,7 @@
return identifier;
}
-static const AtomString& imageOverlayDataDetectorClassName()
+static const AtomString& imageOverlayDataDetectorClass()
{
static MainThreadNeverDestroyed className("image-overlay-data-detector-result", AtomString::ConstructFromLiteral);
return className;
@@ -83,6 +83,12 @@
return className;
}
+static const AtomString& imageOverlayBlockClass()
+{
+static MainThreadNeverDestroyed className("image-overlay-block", AtomString::ConstructFromLiteral);
+return className;
+}
+
#endif // ENABLE(IMAGE_ANALYSIS)
bool hasOverlay(const HTMLElement& element)
@@ -106,7 +112,7 @@
bool isDataDetectorResult(const HTMLElement& element)
{
-return imageOverlayHost(element) && element.hasClass() && element.classNames().contains(imageOverlayDataDetectorClassName());
+return imageOverlayHost(element) && element.hasClass() && element.classNames().contains(imageOverlayDataDetectorClass());
}
bool isInsideOverlay(const SimpleRange& range)
@@ -191,6 +197,7 @@
[webkit-changes] [285861] trunk
Title: [285861] trunk
Revision 285861
Author commit-qu...@webkit.org
Date 2021-11-16 07:24:18 -0800 (Tue, 16 Nov 2021)
Log Message
Empty is represented incorrectly in FormData
https://bugs.webkit.org/show_bug.cgi?id=185416
Patch by Andreu Botella on 2021-11-16
Reviewed by Chris Dumez.
LayoutTests/imported/w3c:
* web-platform-tests/html/semantics/forms/form-submission-0/form-data-set-empty-file.window-expected.txt:
Source/WebCore:
When a FormData object is constructed from a form, an empty control will
be represented as an empty file with an empty filename. According to the HTML spec, this
file must have "application/octet-stream" as its content type. WebKit has the empty string
instead. This change brings WebKit into alignment with the standard and with Firefox and
Chrome in this area.
Tests: imported/w3c/web-platform-tests/html/semantics/forms/form-submission-0/form-data-set-empty-file.window.html
* html/FileInputType.cpp:
(WebCore::FileInputType::appendFormData const):
Modified Paths
trunk/LayoutTests/imported/w3c/ChangeLog
trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/form-submission-0/form-data-set-empty-file.window-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/FileInputType.cpp
Diff
Modified: trunk/LayoutTests/imported/w3c/ChangeLog (285860 => 285861)
--- trunk/LayoutTests/imported/w3c/ChangeLog 2021-11-16 15:07:51 UTC (rev 285860)
+++ trunk/LayoutTests/imported/w3c/ChangeLog 2021-11-16 15:24:18 UTC (rev 285861)
@@ -1,3 +1,12 @@
+2021-11-16 Andreu Botella
+
+Empty is represented incorrectly in FormData
+https://bugs.webkit.org/show_bug.cgi?id=185416
+
+Reviewed by Chris Dumez.
+
+* web-platform-tests/html/semantics/forms/form-submission-0/form-data-set-empty-file.window-expected.txt:
+
2021-11-16 Commit Queue
Unreviewed, reverting r280078, r280290 and r282008.
Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/form-submission-0/form-data-set-empty-file.window-expected.txt (285860 => 285861)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/form-submission-0/form-data-set-empty-file.window-expected.txt 2021-11-16 15:07:51 UTC (rev 285860)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/form-submission-0/form-data-set-empty-file.window-expected.txt 2021-11-16 15:24:18 UTC (rev 285861)
@@ -1,5 +1,5 @@
-FAIL Empty is still added to the form's entry list assert_equals: type expected "application/octet-stream" but got ""
+PASS Empty is still added to the form's entry list
PASS Empty shows up in the urlencoded serialization
PASS Empty shows up in the multipart/form-data serialization
FAIL Empty shows up in the text/plain serialization assert_equals: expected "hi=\n" but got "hi="
Modified: trunk/Source/WebCore/ChangeLog (285860 => 285861)
--- trunk/Source/WebCore/ChangeLog 2021-11-16 15:07:51 UTC (rev 285860)
+++ trunk/Source/WebCore/ChangeLog 2021-11-16 15:24:18 UTC (rev 285861)
@@ -1,3 +1,21 @@
+2021-11-16 Andreu Botella
+
+Empty is represented incorrectly in FormData
+https://bugs.webkit.org/show_bug.cgi?id=185416
+
+Reviewed by Chris Dumez.
+
+When a FormData object is constructed from a form, an empty control will
+be represented as an empty file with an empty filename. According to the HTML spec, this
+file must have "application/octet-stream" as its content type. WebKit has the empty string
+instead. This change brings WebKit into alignment with the standard and with Firefox and
+Chrome in this area.
+
+Tests: imported/w3c/web-platform-tests/html/semantics/forms/form-submission-0/form-data-set-empty-file.window.html
+
+* html/FileInputType.cpp:
+(WebCore::FileInputType::appendFormData const):
+
2021-11-16 Alan Bujtas
[LFC][IFC] Fix fast/text/text-indent-inside-float.html
Modified: trunk/Source/WebCore/html/FileInputType.cpp (285860 => 285861)
--- trunk/Source/WebCore/html/FileInputType.cpp 2021-11-16 15:07:51 UTC (rev 285860)
+++ trunk/Source/WebCore/html/FileInputType.cpp 2021-11-16 15:24:18 UTC (rev 285861)
@@ -178,11 +178,16 @@
return true;
}
-// If no filename at all is entered, return successful but empty.
-// Null would be more logical, but Netscape posts an empty file. Argh.
+// If no filename at all is entered, return successful but empty, with
+// application/octet-stream content type. Null would be more logical, but
+// Netscape posts an empty file. Argh.
if (fileList->isEmpty()) {
auto* document = element() ? ()->document() : nullptr;
-formData.append(name, File::create(document, emptyString()));
+auto file = File::create(
+document,
+Blob::create(document, { }, "application/octet-stream"),
+emptyString());
+formData.append(name, file);
[webkit-changes] [285860] trunk/Source/WebCore
Title: [285860] trunk/Source/WebCore
Revision 285860
Author za...@apple.com
Date 2021-11-16 07:07:51 -0800 (Tue, 16 Nov 2021)
Log Message
[LFC][IFC] Fix fast/text/text-indent-inside-float.html
https://bugs.webkit.org/show_bug.cgi?id=233163
Reviewed by Antti Koivisto.
Percentages must be treated as 0 for the purpose of calculating intrinsic size contributions.
https://drafts.csswg.org/css-text/#text-indent-property
Note that this patch is in preparation for enabling IFC preferred width computation.
* layout/formattingContexts/inline/InlineLineBuilder.cpp:
(WebCore::Layout::LineBuilder::LineBuilder):
(WebCore::Layout::LineBuilder::initialConstraintsForLine const):
* layout/formattingContexts/inline/InlineLineBuilder.h: Add an "intrinsic mode" which will also be used
for other, preferred width computation specific properties and values.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.cpp
trunk/Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (285859 => 285860)
--- trunk/Source/WebCore/ChangeLog 2021-11-16 14:38:18 UTC (rev 285859)
+++ trunk/Source/WebCore/ChangeLog 2021-11-16 15:07:51 UTC (rev 285860)
@@ -1,3 +1,21 @@
+2021-11-16 Alan Bujtas
+
+[LFC][IFC] Fix fast/text/text-indent-inside-float.html
+https://bugs.webkit.org/show_bug.cgi?id=233163
+
+Reviewed by Antti Koivisto.
+
+Percentages must be treated as 0 for the purpose of calculating intrinsic size contributions.
+https://drafts.csswg.org/css-text/#text-indent-property
+
+Note that this patch is in preparation for enabling IFC preferred width computation.
+
+* layout/formattingContexts/inline/InlineLineBuilder.cpp:
+(WebCore::Layout::LineBuilder::LineBuilder):
+(WebCore::Layout::LineBuilder::initialConstraintsForLine const):
+* layout/formattingContexts/inline/InlineLineBuilder.h: Add an "intrinsic mode" which will also be used
+for other, preferred width computation specific properties and values.
+
2021-11-16 Chris Lord
[GTK][WPE] displayDidRefresh can shortcut waking up the scrolling thread
Modified: trunk/Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.cpp (285859 => 285860)
--- trunk/Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.cpp 2021-11-16 14:38:18 UTC (rev 285859)
+++ trunk/Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.cpp 2021-11-16 15:07:51 UTC (rev 285860)
@@ -268,8 +268,9 @@
return boxGeometry.marginBoxWidth();
}
-LineBuilder::LineBuilder(InlineFormattingContext& inlineFormattingContext, FloatingState& floatingState, HorizontalConstraints rootHorizontalConstraints, const InlineItems& inlineItems)
-: m_inlineFormattingContext(inlineFormattingContext)
+LineBuilder::LineBuilder(InlineFormattingContext& inlineFormattingContext, FloatingState& floatingState, HorizontalConstraints rootHorizontalConstraints, const InlineItems& inlineItems, IsIntrinsicWidthMode isIntrinsicWidthMode)
+: m_isIntrinsicWidthMode(isIntrinsicWidthMode == IsIntrinsicWidthMode::Yes)
+, m_inlineFormattingContext(inlineFormattingContext)
, m_inlineFormattingState(())
, m_floatingState()
, m_rootHorizontalConstraints(rootHorizontalConstraints)
@@ -278,8 +279,9 @@
{
}
-LineBuilder::LineBuilder(const InlineFormattingContext& inlineFormattingContext, const InlineItems& inlineItems)
-: m_inlineFormattingContext(inlineFormattingContext)
+LineBuilder::LineBuilder(const InlineFormattingContext& inlineFormattingContext, const InlineItems& inlineItems, IsIntrinsicWidthMode isIntrinsicWidthMode)
+: m_isIntrinsicWidthMode(isIntrinsicWidthMode == IsIntrinsicWidthMode::Yes)
+, m_inlineFormattingContext(inlineFormattingContext)
, m_line(inlineFormattingContext)
, m_inlineItems(inlineItems)
{
@@ -547,6 +549,11 @@
auto textIndent = root.style().textIndent();
if (textIndent == RenderStyle::initialTextIndent())
return { };
+if (m_isIntrinsicWidthMode && textIndent.isPercent()) {
+// Percentages must be treated as 0 for the purpose of calculating intrinsic size contributions.
+// https://drafts.csswg.org/css-text/#text-indent-property
+return { };
+}
return { minimumValueForLength(textIndent, initialLineLogicalRect.width()) };
};
lineLogicalLeft += computedTextIndent();
Modified: trunk/Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.h (285859 => 285860)
--- trunk/Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.h 2021-11-16 14:38:18 UTC (rev 285859)
+++ trunk/Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.h 2021-11-16 15:07:51 UTC (rev 285860)
@@ -39,8 +39,9 @@
class LineBuilder {
public:
-LineBuilder(InlineFormattingContext&, FloatingState&,
[webkit-changes] [285859] trunk/Tools
Title: [285859] trunk/Tools Revision 285859 Author commit-qu...@webkit.org Date 2021-11-16 06:38:18 -0800 (Tue, 16 Nov 2021) Log Message AX: Stop returning AccessibilityUIElements backed by a null pointer https://bugs.webkit.org/show_bug.cgi?id=233138 Patch by Tyler Wilcock on 2021-11-16 Reviewed by Andres Gonzalez. Prior to this patch, some callers of AccessibilityUIElement::create passed null `id`s, resulting in a seemingly valid AccessibilityUIElement that is actually backed by a null pointer. This makes writing tests harder, since you can't rely on common operations like `!myElement` to do the right thing. With this patch, we add a RELEASE_ASSERT to AccessibilityUIElement::create requiring the passed pointer to be valid. This patch also fixes up some callsites where we could (and did) pass null pointers. * WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp: (WTR::AccessibilityController::focusedElement): * WebKitTestRunner/InjectedBundle/win/AccessibilityControllerWin.cpp: (WTR::AccessibilityController::focusedElement): * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp: (WTR::AccessibilityController::focusedElement): Return RefPtr instead of Ref, since it's possible that no element is focused. * WebKitTestRunner/InjectedBundle/AccessibilityController.h: * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp: (WTR::AccessibilityUIElement::create): Add RELEASE_ASSERT() to verify passed pointer is valid. * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm: (WTR::AccessibilityUIElement::focusedElement const): (WTR::AccessibilityUIElement::uiElementForSearchPredicate): * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.mm: (-[AccessibilityNotificationHandler _notificationReceived:]): * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm: (WTR::AccessibilityUIElement::uiElementAttributeValue const): (WTR::AccessibilityUIElement::uiElementForSearchPredicate): (WTR::AccessibilityUIElement::cellForColumnAndRow): (WTR::AccessibilityUIElement::horizontalScrollbar const): (WTR::AccessibilityUIElement::verticalScrollbar const): Don't call AccessibilityUIElement::create with null pointers. Modified Paths trunk/Tools/ChangeLog trunk/Tools/WebKitTestRunner/InjectedBundle/AccessibilityController.cpp trunk/Tools/WebKitTestRunner/InjectedBundle/AccessibilityController.h trunk/Tools/WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp trunk/Tools/WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp trunk/Tools/WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm trunk/Tools/WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.mm trunk/Tools/WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm trunk/Tools/WebKitTestRunner/InjectedBundle/win/AccessibilityControllerWin.cpp Diff Modified: trunk/Tools/ChangeLog (285858 => 285859) --- trunk/Tools/ChangeLog 2021-11-16 13:40:51 UTC (rev 285858) +++ trunk/Tools/ChangeLog 2021-11-16 14:38:18 UTC (rev 285859) @@ -1,3 +1,46 @@ +2021-11-16 Tyler Wilcock + +AX: Stop returning AccessibilityUIElements backed by a null pointer +https://bugs.webkit.org/show_bug.cgi?id=233138 + +Reviewed by Andres Gonzalez. + +Prior to this patch, some callers of AccessibilityUIElement::create +passed null `id`s, resulting in a seemingly valid AccessibilityUIElement +that is actually backed by a null pointer. This makes writing tests harder, +since you can't rely on common operations like `!myElement` to do the right thing. + +With this patch, we add a RELEASE_ASSERT to +AccessibilityUIElement::create requiring the passed pointer to be +valid. This patch also fixes up some callsites where we could (and did) pass null pointers. + +* WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp: +(WTR::AccessibilityController::focusedElement): +* WebKitTestRunner/InjectedBundle/win/AccessibilityControllerWin.cpp: +(WTR::AccessibilityController::focusedElement): +* WebKitTestRunner/InjectedBundle/AccessibilityController.cpp: +(WTR::AccessibilityController::focusedElement): +Return RefPtr instead of Ref, since it's possible that no element is +focused. + +* WebKitTestRunner/InjectedBundle/AccessibilityController.h: +* WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp: +(WTR::AccessibilityUIElement::create): +Add RELEASE_ASSERT() to verify passed pointer is valid. + +* WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm: +(WTR::AccessibilityUIElement::focusedElement const): +(WTR::AccessibilityUIElement::uiElementForSearchPredicate): +* WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.mm: +(-[AccessibilityNotificationHandler _notificationReceived:]): +*
[webkit-changes] [285858] trunk/Source/WebCore
Title: [285858] trunk/Source/WebCore
Revision 285858
Author cl...@igalia.com
Date 2021-11-16 05:40:51 -0800 (Tue, 16 Nov 2021)
Log Message
[GTK][WPE] displayDidRefresh can shortcut waking up the scrolling thread
https://bugs.webkit.org/show_bug.cgi?id=233187
Reviewed by Alejandro G. Castro.
Allow scrolling thread wake-up shortcut on GTK and WPE (matching
behaviour on every other platform).
No new tests, covered by existing tests.
* page/scrolling/ThreadedScrollingTree.cpp:
(WebCore::ThreadedScrollingTree::displayDidRefresh):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/scrolling/ThreadedScrollingTree.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (285857 => 285858)
--- trunk/Source/WebCore/ChangeLog 2021-11-16 11:41:05 UTC (rev 285857)
+++ trunk/Source/WebCore/ChangeLog 2021-11-16 13:40:51 UTC (rev 285858)
@@ -1,3 +1,18 @@
+2021-11-16 Chris Lord
+
+[GTK][WPE] displayDidRefresh can shortcut waking up the scrolling thread
+https://bugs.webkit.org/show_bug.cgi?id=233187
+
+Reviewed by Alejandro G. Castro.
+
+Allow scrolling thread wake-up shortcut on GTK and WPE (matching
+behaviour on every other platform).
+
+No new tests, covered by existing tests.
+
+* page/scrolling/ThreadedScrollingTree.cpp:
+(WebCore::ThreadedScrollingTree::displayDidRefresh):
+
2021-11-16 Commit Queue
Unreviewed, reverting r280078, r280290 and r282008.
Modified: trunk/Source/WebCore/page/scrolling/ThreadedScrollingTree.cpp (285857 => 285858)
--- trunk/Source/WebCore/page/scrolling/ThreadedScrollingTree.cpp 2021-11-16 11:41:05 UTC (rev 285857)
+++ trunk/Source/WebCore/page/scrolling/ThreadedScrollingTree.cpp 2021-11-16 13:40:51 UTC (rev 285858)
@@ -488,10 +488,8 @@
if (displayID != this->displayID())
return;
-#if !PLATFORM(WPE) && !PLATFORM(GTK)
if (!scrollingThreadIsActive)
return;
-#endif
ScrollingThread::dispatch([protectedThis = Ref { *this }]() {
protectedThis->displayDidRefreshOnScrollingThread();
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [285857] trunk
Title: [285857] trunk Revision 285857 Author commit-qu...@webkit.org Date 2021-11-16 03:41:05 -0800 (Tue, 16 Nov 2021) Log Message Unreviewed, reverting r280078, r280290 and r282008. https://bugs.webkit.org/show_bug.cgi?id=233184 Caused a crash in grid Reverted changesets: "Images as grid items should use the overridingLogicalWidth when defined to compute the logical Height" https://bugs.webkit.org/show_bug.cgi?id=228022 https://commits.webkit.org/r280078 "[css-grid] svg image as grid items should use the overriding logical width/height when defined to compute the logical height/width" https://bugs.webkit.org/show_bug.cgi?id=228105 https://commits.webkit.org/r280290 "REGRESSION(r280078): broke fast/images/exif-orientation- composited.html on windows" https://bugs.webkit.org/show_bug.cgi?id=228325 https://commits.webkit.org/r282008 Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/TestExpectations trunk/LayoutTests/imported/w3c/ChangeLog trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-grid/alignment/grid-alignment-implies-size-change-029-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-grid/alignment/grid-alignment-implies-size-change-030-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-grid/alignment/grid-alignment-implies-size-change-031-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-grid/alignment/grid-alignment-implies-size-change-035-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-grid/alignment/grid-alignment-implies-size-change-036-expected.txt trunk/LayoutTests/platform/win/TestExpectations trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/rendering/RenderGrid.cpp trunk/Source/WebCore/rendering/RenderReplaced.cpp Diff Modified: trunk/LayoutTests/ChangeLog (285856 => 285857) --- trunk/LayoutTests/ChangeLog 2021-11-16 10:44:32 UTC (rev 285856) +++ trunk/LayoutTests/ChangeLog 2021-11-16 11:41:05 UTC (rev 285857) @@ -1,3 +1,28 @@ +2021-11-16 Commit Queue + +Unreviewed, reverting r280078, r280290 and r282008. +https://bugs.webkit.org/show_bug.cgi?id=233184 + +Caused a crash in grid + +Reverted changesets: + +"Images as grid items should use the overridingLogicalWidth +when defined to compute the logical Height" +https://bugs.webkit.org/show_bug.cgi?id=228022 +https://commits.webkit.org/r280078 + +"[css-grid] svg image as grid items should use the overriding +logical width/height when defined to compute the logical +height/width" +https://bugs.webkit.org/show_bug.cgi?id=228105 +https://commits.webkit.org/r280290 + +"REGRESSION(r280078): broke fast/images/exif-orientation- +composited.html on windows" +https://bugs.webkit.org/show_bug.cgi?id=228325 +https://commits.webkit.org/r282008 + 2021-11-16 Arcady Goldmints-Orlov [GLIB] Update test expectations and baselines. Unreviewed test gardening. Modified: trunk/LayoutTests/TestExpectations (285856 => 285857) --- trunk/LayoutTests/TestExpectations 2021-11-16 10:44:32 UTC (rev 285856) +++ trunk/LayoutTests/TestExpectations 2021-11-16 11:41:05 UTC (rev 285857) @@ -1388,6 +1388,9 @@ imported/w3c/web-platform-tests/css/css-grid/abspos/orthogonal-positioned-grid-descendants-015.html [ Pass Failure ] webkit.org/b/216146 imported/w3c/web-platform-tests/css/css-grid/alignment/grid-baseline-align-001.html [ ImageOnlyFailure ] webkit.org/b/216146 imported/w3c/web-platform-tests/css/css-grid/alignment/grid-baseline-justify-001.html [ ImageOnlyFailure ] +imported/w3c/web-platform-tests/css/css-grid/alignment/replaced-alignment-with-aspect-ratio-002.html [ ImageOnlyFailure ] +imported/w3c/web-platform-tests/css/css-grid/alignment/replaced-alignment-with-aspect-ratio-007.html [ ImageOnlyFailure ] +imported/w3c/web-platform-tests/css/css-grid/alignment/replaced-alignment-with-aspect-ratio-008.html [ ImageOnlyFailure ] imported/w3c/web-platform-tests/css/css-grid/grid-definition/grid-auto-repeat-dynamic-001.html [ ImageOnlyFailure ] imported/w3c/web-platform-tests/css/css-grid/grid-definition/grid-repeat-max-width-001.html [ ImageOnlyFailure ] @@ -4316,6 +4319,10 @@ webkit.org/b/209460 imported/w3c/web-platform-tests/css/css-grid/abspos/descendant-static-position-002.html [ ImageOnlyFailure ] webkit.org/b/209460 imported/w3c/web-platform-tests/css/css-grid/abspos/descendant-static-position-003.html [ ImageOnlyFailure ] webkit.org/b/212201 imported/w3c/web-platform-tests/css/css-grid/grid-definition/grid-limits-001.html [ Skip ] +webkit.org/b/227900 imported/w3c/web-platform-tests/css/css-grid/alignment/grid-item-aspect-ratio-stretch-1.html [ ImageOnlyFailure ] +webkit.org/b/227900 imported/w3c/web-platform-tests/css/css-grid/alignment/grid-item-aspect-ratio-stretch-2.html [ ImageOnlyFailure ] +webkit.org/b/227900
[webkit-changes] [285856] trunk/Source/WebKit
Title: [285856] trunk/Source/WebKit
Revision 285856
Author commit-qu...@webkit.org
Date 2021-11-16 02:44:32 -0800 (Tue, 16 Nov 2021)
Log Message
RemoteGraphicsContextGLCocoa::m_swapChain is unused
https://bugs.webkit.org/show_bug.cgi?id=233176
Patch by Kimmo Kinnunen on 2021-11-16
Reviewed by Antti Koivisto.
Remove the unused variable.
* GPUProcess/graphics/RemoteGraphicsContextGLCocoa.cpp:
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/GPUProcess/graphics/RemoteGraphicsContextGLCocoa.cpp
Diff
Modified: trunk/Source/WebKit/ChangeLog (285855 => 285856)
--- trunk/Source/WebKit/ChangeLog 2021-11-16 09:48:23 UTC (rev 285855)
+++ trunk/Source/WebKit/ChangeLog 2021-11-16 10:44:32 UTC (rev 285856)
@@ -1,3 +1,14 @@
+2021-11-16 Kimmo Kinnunen
+
+RemoteGraphicsContextGLCocoa::m_swapChain is unused
+https://bugs.webkit.org/show_bug.cgi?id=233176
+
+Reviewed by Antti Koivisto.
+
+Remove the unused variable.
+
+* GPUProcess/graphics/RemoteGraphicsContextGLCocoa.cpp:
+
2021-11-15 Commit Queue
Unreviewed, reverting r285812.
Modified: trunk/Source/WebKit/GPUProcess/graphics/RemoteGraphicsContextGLCocoa.cpp (285855 => 285856)
--- trunk/Source/WebKit/GPUProcess/graphics/RemoteGraphicsContextGLCocoa.cpp 2021-11-16 09:48:23 UTC (rev 285855)
+++ trunk/Source/WebKit/GPUProcess/graphics/RemoteGraphicsContextGLCocoa.cpp 2021-11-16 10:44:32 UTC (rev 285856)
@@ -29,7 +29,6 @@
#if ENABLE(GPU_PROCESS) && ENABLE(WEBGL) && PLATFORM(COCOA)
#include "GPUConnectionToWebProcess.h"
-#include
#include
namespace WebKit {
@@ -46,7 +45,6 @@
void platformWorkQueueInitialize(WebCore::GraphicsContextGLAttributes&&) final;
void prepareForDisplay(CompletionHandler&&) final;
private:
-WebCore::GraphicsContextGLIOSurfaceSwapChain m_swapChain WTF_GUARDED_BY_LOCK(m_streamThread);
#if HAVE(IOSURFACE_SET_OWNERSHIP_IDENTITY)
task_id_token_t m_webProcessIdentityToken;
#endif
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [285854] trunk
Title: [285854] trunk Revision 285854 Author cathiec...@igalia.com Date 2021-11-16 01:46:49 -0800 (Tue, 16 Nov 2021) Log Message [CSS contain] The size should be updated if layout containment is inside a fit-content parent https://bugs.webkit.org/show_bug.cgi?id=233046 Reviewed by Rob Buis. Source/WebCore: When the object is a layout containment, we also need to add size containment as the constraint of being a relayout boundary. Otherwise when the layout size depends on the content, the layout size might not be updated correctly. Test: imported/w3c/web-platform-tests/css/css-contain/contain-layout-019.html * rendering/RenderObject.cpp: (WebCore::objectIsRelayoutBoundary): LayoutTests: * TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/TestExpectations trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/rendering/RenderObject.cpp Diff Modified: trunk/LayoutTests/ChangeLog (285853 => 285854) --- trunk/LayoutTests/ChangeLog 2021-11-16 07:02:45 UTC (rev 285853) +++ trunk/LayoutTests/ChangeLog 2021-11-16 09:46:49 UTC (rev 285854) @@ -1,3 +1,12 @@ +2021-11-16 Cathie Chen + +[CSS contain] The size should be updated if layout containment is inside a fit-content parent +https://bugs.webkit.org/show_bug.cgi?id=233046 + +Reviewed by Rob Buis. + +* TestExpectations: + 2021-11-15 Tim Nguyen Re-import css/css-text-decor WPT Modified: trunk/LayoutTests/TestExpectations (285853 => 285854) --- trunk/LayoutTests/TestExpectations 2021-11-16 07:02:45 UTC (rev 285853) +++ trunk/LayoutTests/TestExpectations 2021-11-16 09:46:49 UTC (rev 285854) @@ -4842,7 +4842,6 @@ imported/w3c/web-platform-tests/css/css-contain/contain-html-w-m-002.html [ ImageOnlyFailure ] imported/w3c/web-platform-tests/css/css-contain/contain-html-w-m-003.html [ ImageOnlyFailure ] imported/w3c/web-platform-tests/css/css-contain/contain-html-w-m-004.html [ ImageOnlyFailure ] -imported/w3c/web-platform-tests/css/css-contain/contain-layout-019.html [ ImageOnlyFailure ] imported/w3c/web-platform-tests/css/css-contain/contain-paint-026.html [ ImageOnlyFailure ] # Flaky css-contain test Modified: trunk/Source/WebCore/ChangeLog (285853 => 285854) --- trunk/Source/WebCore/ChangeLog 2021-11-16 07:02:45 UTC (rev 285853) +++ trunk/Source/WebCore/ChangeLog 2021-11-16 09:46:49 UTC (rev 285854) @@ -1,3 +1,19 @@ +2021-11-16 Cathie Chen + +[CSS contain] The size should be updated if layout containment is inside a fit-content parent +https://bugs.webkit.org/show_bug.cgi?id=233046 + +Reviewed by Rob Buis. + +When the object is a layout containment, we also need to add size containment as the constraint of +being a relayout boundary. Otherwise when the layout size depends on the content, the layout size +might not be updated correctly. + +Test: imported/w3c/web-platform-tests/css/css-contain/contain-layout-019.html + +* rendering/RenderObject.cpp: +(WebCore::objectIsRelayoutBoundary): + 2021-11-15 Sam Weinig Add another backend backed by SceneKit to prove out ModelPlayer infrastructure a bit more Modified: trunk/Source/WebCore/rendering/RenderObject.cpp (285853 => 285854) --- trunk/Source/WebCore/rendering/RenderObject.cpp 2021-11-16 07:02:45 UTC (rev 285853) +++ trunk/Source/WebCore/rendering/RenderObject.cpp 2021-11-16 09:46:49 UTC (rev 285854) @@ -505,7 +505,7 @@ if (object->isTextControl()) return true; -if (shouldApplyLayoutContainment(*object)) +if (shouldApplyLayoutContainment(*object) && shouldApplySizeContainment(*object)) return true; if (object->isSVGRoot()) ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [285855] trunk/LayoutTests
Title: [285855] trunk/LayoutTests Revision 285855 Author commit-qu...@webkit.org Date 2021-11-16 01:48:23 -0800 (Tue, 16 Nov 2021) Log Message [GLIB] Update test expectations and baselines. Unreviewed test gardening. https://bugs.webkit.org/show_bug.cgi?id=233156 Patch by Arcady Goldmints-Orlov on 2021-11-16 * platform/glib/TestExpectations: * platform/glib/fast/css/getComputedStyle/computed-style-expected.txt: * platform/glib/fast/xmlhttprequest/xmlhttprequest-nonexistent-file-expected.txt: Added. * platform/glib/http/wpt/push-api/pushManager.any-expected.txt: Added. * platform/glib/http/wpt/push-api/pushManager.any.serviceworker-expected.txt: Added. * platform/glib/imported/w3c/web-platform-tests/content-security-policy/connect-src/connect-src-eventsource-allowed.sub-expected.txt: Added. * platform/gtk/accessibility/color-well-expected.txt: * platform/gtk/ietestcenter/css3/bordersbackgrounds/border-radius-different-width-001-expected.txt: * platform/wpe/accessibility/color-well-expected.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/glib/TestExpectations trunk/LayoutTests/platform/glib/fast/css/getComputedStyle/computed-style-expected.txt trunk/LayoutTests/platform/gtk/accessibility/color-well-expected.txt trunk/LayoutTests/platform/gtk/ietestcenter/css3/bordersbackgrounds/border-radius-different-width-001-expected.txt trunk/LayoutTests/platform/wpe/accessibility/color-well-expected.txt Added Paths trunk/LayoutTests/platform/glib/fast/xmlhttprequest/ trunk/LayoutTests/platform/glib/fast/xmlhttprequest/xmlhttprequest-nonexistent-file-expected.txt trunk/LayoutTests/platform/glib/http/wpt/ trunk/LayoutTests/platform/glib/http/wpt/push-api/ trunk/LayoutTests/platform/glib/http/wpt/push-api/pushManager.any-expected.txt trunk/LayoutTests/platform/glib/http/wpt/push-api/pushManager.any.serviceworker-expected.txt trunk/LayoutTests/platform/glib/imported/w3c/web-platform-tests/content-security-policy/connect-src/ trunk/LayoutTests/platform/glib/imported/w3c/web-platform-tests/content-security-policy/connect-src/connect-src-eventsource-allowed.sub-expected.txt Diff Modified: trunk/LayoutTests/ChangeLog (285854 => 285855) --- trunk/LayoutTests/ChangeLog 2021-11-16 09:46:49 UTC (rev 285854) +++ trunk/LayoutTests/ChangeLog 2021-11-16 09:48:23 UTC (rev 285855) @@ -1,3 +1,18 @@ +2021-11-16 Arcady Goldmints-Orlov + +[GLIB] Update test expectations and baselines. Unreviewed test gardening. +https://bugs.webkit.org/show_bug.cgi?id=233156 + +* platform/glib/TestExpectations: +* platform/glib/fast/css/getComputedStyle/computed-style-expected.txt: +* platform/glib/fast/xmlhttprequest/xmlhttprequest-nonexistent-file-expected.txt: Added. +* platform/glib/http/wpt/push-api/pushManager.any-expected.txt: Added. +* platform/glib/http/wpt/push-api/pushManager.any.serviceworker-expected.txt: Added. +* platform/glib/imported/w3c/web-platform-tests/content-security-policy/connect-src/connect-src-eventsource-allowed.sub-expected.txt: Added. +* platform/gtk/accessibility/color-well-expected.txt: +* platform/gtk/ietestcenter/css3/bordersbackgrounds/border-radius-different-width-001-expected.txt: +* platform/wpe/accessibility/color-well-expected.txt: + 2021-11-16 Cathie Chen [CSS contain] The size should be updated if layout containment is inside a fit-content parent Modified: trunk/LayoutTests/platform/glib/TestExpectations (285854 => 285855) --- trunk/LayoutTests/platform/glib/TestExpectations 2021-11-16 09:46:49 UTC (rev 285854) +++ trunk/LayoutTests/platform/glib/TestExpectations 2021-11-16 09:48:23 UTC (rev 285855) @@ -2554,6 +2554,7 @@ webkit.org/b/232386 fast/inline/vertical-align-text-bottom.html [ Failure ] webkit.org/b/232386 fast/multicol/float-adjacent-to-overflow-block.html [ ImageOnlyFailure ] webkit.org/b/232386 fast/overflow/clip-rects-fixed-ancestor.html [ Failure ] +webkit.org/b/232386 fast/overflow/dynamic-hidden.html [ Failure ] webkit.org/b/232386 fast/parser/changing-attrbutes-crash.html [ Failure ] webkit.org/b/232386 fast/parser/comment-in-script.html [ Failure ] webkit.org/b/232386 fast/parser/comments.html [ Failure ] @@ -2566,6 +2567,7 @@ webkit.org/b/232386 fast/selectors/empty-namespace-with-element-selector.html [ Failure ] webkit.org/b/232386 fast/table/Rowspan-value-more-than-number-of-rows-present.html [ Failure ] webkit.org/b/232386 fast/text/crash-font-family-parsed.html [ Failure ] +webkit.org/b/232386 fast/text/line-breaks-after-white-space.html [ Failure ] webkit.org/b/232386 fast/text/text-shadow-no-default-color.html [ Failure ] webkit.org/b/232386 fast/text/text-underline-first-line-decoration.html [ ImageOnlyFailure ] webkit.org/b/232386 fast/text/text-underline-style.html [ ImageOnlyFailure ] Modified: trunk/LayoutTests/platform/glib/fast/css/getComputedStyle/computed-style-expected.txt (285854 => 285855) ---
