[webkit-changes] [286935] trunk/Source/JavaScriptCore
Title: [286935] trunk/Source/_javascript_Core Revision 286935 Author commit-qu...@webkit.org Date 2021-12-12 23:18:32 -0800 (Sun, 12 Dec 2021) Log Message [RISCV64] Add MacroAssemblerRISCV64 implementations for trivial general-purpose-register operations https://bugs.webkit.org/show_bug.cgi?id=233992 Patch by Zan Dobersek on 2021-12-12 Reviewed by Yusuke Suzuki. Add implementations for the trivial general-purpose-register operations in MacroAssemblerRISCV64. This covers non-patchable loads and stores, shifts, logical operations, zero- and sign-extensions, moves and swaps, stack operations as well as miscellaneous operations like aborts, breakpoints and nops. The loadImmediate helper methods are added to handle loading of different types of immediate values. This should replace move() calls when a sign-extended immediate load is desired, whereas move() for a 32-bit immediate is expected to perform no sign extension. * assembler/MacroAssemblerRISCV64.h: (JSC::MacroAssemblerRISCV64::add32): (JSC::MacroAssemblerRISCV64::add64): (JSC::MacroAssemblerRISCV64::sub32): (JSC::MacroAssemblerRISCV64::mul32): (JSC::MacroAssemblerRISCV64::lshift32): (JSC::MacroAssemblerRISCV64::lshift64): (JSC::MacroAssemblerRISCV64::rshift32): (JSC::MacroAssemblerRISCV64::rshift64): (JSC::MacroAssemblerRISCV64::urshift32): (JSC::MacroAssemblerRISCV64::urshift64): (JSC::MacroAssemblerRISCV64::load8): (JSC::MacroAssemblerRISCV64::load8SignedExtendTo32): (JSC::MacroAssemblerRISCV64::load16): (JSC::MacroAssemblerRISCV64::load16Unaligned): (JSC::MacroAssemblerRISCV64::load16SignedExtendTo32): (JSC::MacroAssemblerRISCV64::load32): (JSC::MacroAssemblerRISCV64::load32WithUnalignedHalfWords): (JSC::MacroAssemblerRISCV64::load64): (JSC::MacroAssemblerRISCV64::loadPair32): (JSC::MacroAssemblerRISCV64::store8): (JSC::MacroAssemblerRISCV64::store16): (JSC::MacroAssemblerRISCV64::store32): (JSC::MacroAssemblerRISCV64::store64): (JSC::MacroAssemblerRISCV64::storePair32): (JSC::MacroAssemblerRISCV64::zeroExtend8To32): (JSC::MacroAssemblerRISCV64::zeroExtend16To32): (JSC::MacroAssemblerRISCV64::zeroExtend32ToWord): (JSC::MacroAssemblerRISCV64::signExtend8To32): (JSC::MacroAssemblerRISCV64::signExtend16To32): (JSC::MacroAssemblerRISCV64::signExtend32ToPtr): (JSC::MacroAssemblerRISCV64::and32): (JSC::MacroAssemblerRISCV64::and64): (JSC::MacroAssemblerRISCV64::or8): (JSC::MacroAssemblerRISCV64::or16): (JSC::MacroAssemblerRISCV64::or32): (JSC::MacroAssemblerRISCV64::or64): (JSC::MacroAssemblerRISCV64::xor32): (JSC::MacroAssemblerRISCV64::xor64): (JSC::MacroAssemblerRISCV64::not32): (JSC::MacroAssemblerRISCV64::not64): (JSC::MacroAssemblerRISCV64::neg32): (JSC::MacroAssemblerRISCV64::neg64): (JSC::MacroAssemblerRISCV64::move): (JSC::MacroAssemblerRISCV64::swap): (JSC::MacroAssemblerRISCV64::push): (JSC::MacroAssemblerRISCV64::pushPair): (JSC::MacroAssemblerRISCV64::pop): (JSC::MacroAssemblerRISCV64::popPair): (JSC::MacroAssemblerRISCV64::abortWithReason): (JSC::MacroAssemblerRISCV64::breakpoint): (JSC::MacroAssemblerRISCV64::nop): (JSC::MacroAssemblerRISCV64::loadImmediate): Modified Paths trunk/Source/_javascript_Core/ChangeLog trunk/Source/_javascript_Core/assembler/MacroAssemblerRISCV64.h Diff Modified: trunk/Source/_javascript_Core/ChangeLog (286934 => 286935) --- trunk/Source/_javascript_Core/ChangeLog 2021-12-13 07:16:02 UTC (rev 286934) +++ trunk/Source/_javascript_Core/ChangeLog 2021-12-13 07:18:32 UTC (rev 286935) @@ -1,3 +1,75 @@ +2021-12-12 Zan Dobersek + +[RISCV64] Add MacroAssemblerRISCV64 implementations for trivial general-purpose-register operations +https://bugs.webkit.org/show_bug.cgi?id=233992 + +Reviewed by Yusuke Suzuki. + +Add implementations for the trivial general-purpose-register operations +in MacroAssemblerRISCV64. This covers non-patchable loads and stores, +shifts, logical operations, zero- and sign-extensions, moves and swaps, +stack operations as well as miscellaneous operations like aborts, +breakpoints and nops. + +The loadImmediate helper methods are added to handle loading of +different types of immediate values. This should replace move() calls +when a sign-extended immediate load is desired, whereas move() for +a 32-bit immediate is expected to perform no sign extension. + +* assembler/MacroAssemblerRISCV64.h: +(JSC::MacroAssemblerRISCV64::add32): +(JSC::MacroAssemblerRISCV64::add64): +(JSC::MacroAssemblerRISCV64::sub32): +(JSC::MacroAssemblerRISCV64::mul32): +(JSC::MacroAssemblerRISCV64::lshift32): +(JSC::MacroAssemblerRISCV64::lshift64): +(JSC::MacroAssemblerRISCV64::rshift32): +(JSC::MacroAssemblerRISCV64::rshift64): +(JSC::MacroAssemblerRISCV64::urshift32): +(JSC::MacroAssemblerRISCV64::urshift64): +(JSC::MacroAssemblerRISCV64::load8): +(JSC::MacroAssemblerRISCV64::load8SignedExtendTo32): +
[webkit-changes] [286934] trunk/Source/bmalloc
Title: [286934] trunk/Source/bmalloc
Revision 286934
Author commit-qu...@webkit.org
Date 2021-12-12 23:16:02 -0800 (Sun, 12 Dec 2021)
Log Message
[libpas] make build.sh, test.sh, build_and_test.sh, and clean.sh work on Linux
https://bugs.webkit.org/show_bug.cgi?id=233821
Patch by Zan Dobersek on 2021-12-12
Reviewed by Yusuke Suzuki.
Adjust and enhance the shell scripts for building and testing CMake
builds of libpas. In build.sh, the 'cmake' SDK option handling is added,
invoking CMake to produce a libpas build of the desired variant and
configuration. The Debug and Release configuration possibilities map
exactly to the CMAKE_BUILD_TYPE option. The ENABLE_PAS_TESTING option
used for the testing variant is converted into a macro definition that's
passed to both CMAKE_C_FLAGS and CMAKE_CXX_FLAGS.
The function declarations are adjusted to use the "fname()" form, making
things runnable on shells that don't support the "function" keyword.
* libpas/build.sh:
* libpas/common.sh:
* libpas/test.sh:
Modified Paths
trunk/Source/bmalloc/ChangeLog
trunk/Source/bmalloc/libpas/build.sh
trunk/Source/bmalloc/libpas/common.sh
trunk/Source/bmalloc/libpas/test.sh
Diff
Modified: trunk/Source/bmalloc/ChangeLog (286933 => 286934)
--- trunk/Source/bmalloc/ChangeLog 2021-12-13 03:23:12 UTC (rev 286933)
+++ trunk/Source/bmalloc/ChangeLog 2021-12-13 07:16:02 UTC (rev 286934)
@@ -1,3 +1,25 @@
+2021-12-12 Zan Dobersek
+
+[libpas] make build.sh, test.sh, build_and_test.sh, and clean.sh work on Linux
+https://bugs.webkit.org/show_bug.cgi?id=233821
+
+Reviewed by Yusuke Suzuki.
+
+Adjust and enhance the shell scripts for building and testing CMake
+builds of libpas. In build.sh, the 'cmake' SDK option handling is added,
+invoking CMake to produce a libpas build of the desired variant and
+configuration. The Debug and Release configuration possibilities map
+exactly to the CMAKE_BUILD_TYPE option. The ENABLE_PAS_TESTING option
+used for the testing variant is converted into a macro definition that's
+passed to both CMAKE_C_FLAGS and CMAKE_CXX_FLAGS.
+
+The function declarations are adjusted to use the "fname()" form, making
+things runnable on shells that don't support the "function" keyword.
+
+* libpas/build.sh:
+* libpas/common.sh:
+* libpas/test.sh:
+
2021-12-09 Alex Christensen
Prepare for transition to C++20
Modified: trunk/Source/bmalloc/libpas/build.sh (286933 => 286934)
--- trunk/Source/bmalloc/libpas/build.sh 2021-12-13 03:23:12 UTC (rev 286933)
+++ trunk/Source/bmalloc/libpas/build.sh 2021-12-13 07:16:02 UTC (rev 286934)
@@ -24,10 +24,10 @@
. common.sh
-function build_variant {
+build_variant_xcodebuild() {
variant=$1
-extra_xcodebuild_options="$2"
-target=$3
+target=$2
+extra_xcodebuild_options="EXTRA_DEFINES=$3"
build_dir=build-$sdk-$variant
mkdir -p $build_dir
@@ -43,7 +43,7 @@
case $target in
mbmalloc|all)
-function link_mbmalloc_personality {
+link_mbmalloc_personality() {
personality=$1
mkdir -p $build_dir/$configdir/mbmalloc_$personality
@@ -60,17 +60,58 @@
esac
}
-function build_variants {
+build_variant_cmake() {
+variant=$1
+target=$2
+extra_options=$3
+
+case $config in
+Release)
+;;
+Debug)
+;;
+*)
+echo "Bad value of config"
+exit 1
+esac
+
+build_dir=build-$sdk-$variant/$configdir
+mkdir -p $build_dir
+
+extra_cmake_options=""
+for option in $extra_options; do
+extra_cmake_options="${extra_cmake_options} -D${option}"
+done
+extra_cmake_options=\"${extra_cmake_options#* }\"
+
+echo $extra_cmake_options
+
+cmake -DCMAKE_BUILD_TYPE=$config -DCMAKE_C_FLAGS=$extra_cmake_options -DCMAKE_CXX_FLAGS=$extra_cmake_options -B $build_dir
+cmake --build $build_dir --parallel
+}
+
+build_variant() {
+case $sdk in
+cmake)
+build_variant_cmake $@
+;;
+*)
+build_variant_xcodebuild
+;;
+esac
+}
+
+build_variants() {
target=$1
case $variants in
all|testing)
-build_variant testing "EXTRA_DEFINES=ENABLE_PAS_TESTING" $target
+build_variant testing $target "ENABLE_PAS_TESTING"
;;
esac
case $variants in
all|default)
-build_variant default "EXTRA_DEFINES=" $target
+build_variant default $target ""
;;
esac
}
Modified: trunk/Source/bmalloc/libpas/common.sh (286933 => 286934)
--- trunk/Source/bmalloc/libpas/common.sh 2021-12-13 03:23:12 UTC (rev 286933)
+++ trunk/Source/bmalloc/libpas/common.sh 2021-12-13 07:16:02 UTC (rev 286934)
@@ -31,7 +31,7 @@
target=all
port=10022
-function show_help {
[webkit-changes] [286933] trunk/Source/WebCore
Title: [286933] trunk/Source/WebCore
Revision 286933
Author za...@apple.com
Date 2021-12-12 19:23:12 -0800 (Sun, 12 Dec 2021)
Log Message
[IFC][Integration] Enable isolate-override for inline boxes
https://bugs.webkit.org/show_bug.cgi?id=234203
Reviewed by Antti Koivisto.
* layout/integration/LayoutIntegrationCoverage.cpp: The only reason why plaintext is not enabled yet
is becuase it may change the inline axis direction to RTL. It is going to be enabled together with the RTL support.
(WebCore::LayoutIntegration::canUseForStyle):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/layout/integration/LayoutIntegrationCoverage.cpp
trunk/Source/WebCore/layout/integration/LayoutIntegrationCoverage.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (286932 => 286933)
--- trunk/Source/WebCore/ChangeLog 2021-12-13 02:42:35 UTC (rev 286932)
+++ trunk/Source/WebCore/ChangeLog 2021-12-13 03:23:12 UTC (rev 286933)
@@ -1,3 +1,14 @@
+2021-12-12 Alan Bujtas
+
+[IFC][Integration] Enable isolate-override for inline boxes
+https://bugs.webkit.org/show_bug.cgi?id=234203
+
+Reviewed by Antti Koivisto.
+
+* layout/integration/LayoutIntegrationCoverage.cpp: The only reason why plaintext is not enabled yet
+is becuase it may change the inline axis direction to RTL. It is going to be enabled together with the RTL support.
+(WebCore::LayoutIntegration::canUseForStyle):
+
2021-12-12 Simon Fraser
Ensure that the scrolling thread always commits layer position changes to reduce scrolling stutters
Modified: trunk/Source/WebCore/layout/integration/LayoutIntegrationCoverage.cpp (286932 => 286933)
--- trunk/Source/WebCore/layout/integration/LayoutIntegrationCoverage.cpp 2021-12-13 02:42:35 UTC (rev 286932)
+++ trunk/Source/WebCore/layout/integration/LayoutIntegrationCoverage.cpp 2021-12-13 03:23:12 UTC (rev 286933)
@@ -116,8 +116,8 @@
case AvoidanceReason::FlowHasOverflowNotVisible:
stream << "overflow: hidden | scroll | auto";
break;
-case AvoidanceReason::FlowIsNotLTR:
-stream << "dir is not LTR";
+case AvoidanceReason::FlowMayNotBeLTR:
+stream << "dir may not be LTR";
break;
case AvoidanceReason::FlowHasLineBoxContainProperty:
stream << "line-box-contain value indicates variable line height";
@@ -125,9 +125,6 @@
case AvoidanceReason::FlowIsNotTopToBottom:
stream << "non top-to-bottom flow";
break;
-case AvoidanceReason::FlowHasNonNormalUnicodeBiDi:
-stream << "non-normal Unicode bidi";
-break;
case AvoidanceReason::FlowHasRTLOrdering:
stream << "-webkit-rtl-ordering";
break;
@@ -437,17 +434,10 @@
SET_REASON_AND_RETURN_IF_NEEDED(FlowHasOverflowNotVisible, reasons, includeReasons);
if (style.textOverflow() == TextOverflow::Ellipsis)
SET_REASON_AND_RETURN_IF_NEEDED(FlowHasTextOverflow, reasons, includeReasons);
-if (!style.isLeftToRightDirection())
-SET_REASON_AND_RETURN_IF_NEEDED(FlowIsNotLTR, reasons, includeReasons);
+if (!style.isLeftToRightDirection() || (is(renderer) && style.unicodeBidi() == EUnicodeBidi::Plaintext))
+SET_REASON_AND_RETURN_IF_NEEDED(FlowMayNotBeLTR, reasons, includeReasons);
if (style.writingMode() != WritingMode::TopToBottom)
SET_REASON_AND_RETURN_IF_NEEDED(FlowIsNotTopToBottom, reasons, includeReasons);
-if (style.unicodeBidi() != UBNormal) {
-auto unicodeBidi = style.unicodeBidi();
-if (unicodeBidi == EUnicodeBidi::Plaintext)
-SET_REASON_AND_RETURN_IF_NEEDED(FlowHasNonNormalUnicodeBiDi, reasons, includeReasons);
-if (!is(renderer) && unicodeBidi == EUnicodeBidi::IsolateOverride)
-SET_REASON_AND_RETURN_IF_NEEDED(FlowHasNonNormalUnicodeBiDi, reasons, includeReasons);
-}
if (style.rtlOrdering() != Order::Logical)
SET_REASON_AND_RETURN_IF_NEEDED(FlowHasRTLOrdering, reasons, includeReasons);
if (style.textEmphasisFill() != TextEmphasisFill::Filled || style.textEmphasisMark() != TextEmphasisMark::None)
Modified: trunk/Source/WebCore/layout/integration/LayoutIntegrationCoverage.h (286932 => 286933)
--- trunk/Source/WebCore/layout/integration/LayoutIntegrationCoverage.h 2021-12-13 02:42:35 UTC (rev 286932)
+++ trunk/Source/WebCore/layout/integration/LayoutIntegrationCoverage.h 2021-12-13 03:23:12 UTC (rev 286933)
@@ -53,10 +53,10 @@
// Unused= 1LLU << 12,
FlowHasOverflowNotVisible= 1LLU << 13,
// Unused= 1LLU << 14,
-FlowIsNotLTR = 1LLU << 15,
+FlowMayNotBeLTR = 1LLU << 15,
FlowHasLineBoxContainProperty= 1LLU << 16,
FlowIsNotTopToBottom = 1LLU << 17,
-FlowHasNonNormalUnicodeBiDi = 1LLU << 18,
+
[webkit-changes] [286932] trunk/Source/WebCore
Title: [286932] trunk/Source/WebCore
Revision 286932
Author simon.fra...@apple.com
Date 2021-12-12 18:42:35 -0800 (Sun, 12 Dec 2021)
Log Message
Ensure that the scrolling thread always commits layer position changes to reduce scrolling stutters
https://bugs.webkit.org/show_bug.cgi?id=234213
Reviewed by Tim Horton.
On a page where CA commits on the main thread take a long time (e.g. because of expensive
painting), it's possible that the main thread has updated the scrolling layer position, and
then the scrolling thread detects that the commit is taking a long time and attempts to
trigger its own commit, but because the layer position property doesn't change, no commit
occurs.
Work around this by setting the layer position to 0,0 and back when we're on the scrolling
thread. Only do this if the scroll position changed since the last display refresh to avoid
triggering redundant commits.
Ideally we'd traverse the scrolling tree and do this for every scrolling node, but scrolling
trees can get large so for now just apply this to the root node.
* page/scrolling/ScrollingTreeScrollingNode.cpp:
(WebCore::ScrollingTreeScrollingNode::updateScrollPositionAtLastDisplayRefresh):
* page/scrolling/ScrollingTreeScrollingNode.h:
* page/scrolling/ThreadedScrollingTree.cpp:
(WebCore::ThreadedScrollingTree::displayDidRefreshOnScrollingThread):
(WebCore::ThreadedScrollingTree::storeScrollPositionsAtLastDisplayRefresh):
* page/scrolling/ThreadedScrollingTree.h:
* page/scrolling/mac/ScrollingTreeFrameScrollingNodeMac.mm:
(WebCore::ScrollingTreeFrameScrollingNodeMac::repositionScrollingLayers):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/scrolling/ScrollingTreeScrollingNode.cpp
trunk/Source/WebCore/page/scrolling/ScrollingTreeScrollingNode.h
trunk/Source/WebCore/page/scrolling/ThreadedScrollingTree.cpp
trunk/Source/WebCore/page/scrolling/ThreadedScrollingTree.h
trunk/Source/WebCore/page/scrolling/mac/ScrollingTreeFrameScrollingNodeMac.mm
Diff
Modified: trunk/Source/WebCore/ChangeLog (286931 => 286932)
--- trunk/Source/WebCore/ChangeLog 2021-12-13 01:46:09 UTC (rev 286931)
+++ trunk/Source/WebCore/ChangeLog 2021-12-13 02:42:35 UTC (rev 286932)
@@ -1,3 +1,33 @@
+2021-12-12 Simon Fraser
+
+Ensure that the scrolling thread always commits layer position changes to reduce scrolling stutters
+https://bugs.webkit.org/show_bug.cgi?id=234213
+
+Reviewed by Tim Horton.
+
+On a page where CA commits on the main thread take a long time (e.g. because of expensive
+painting), it's possible that the main thread has updated the scrolling layer position, and
+then the scrolling thread detects that the commit is taking a long time and attempts to
+trigger its own commit, but because the layer position property doesn't change, no commit
+occurs.
+
+Work around this by setting the layer position to 0,0 and back when we're on the scrolling
+thread. Only do this if the scroll position changed since the last display refresh to avoid
+triggering redundant commits.
+
+Ideally we'd traverse the scrolling tree and do this for every scrolling node, but scrolling
+trees can get large so for now just apply this to the root node.
+
+* page/scrolling/ScrollingTreeScrollingNode.cpp:
+(WebCore::ScrollingTreeScrollingNode::updateScrollPositionAtLastDisplayRefresh):
+* page/scrolling/ScrollingTreeScrollingNode.h:
+* page/scrolling/ThreadedScrollingTree.cpp:
+(WebCore::ThreadedScrollingTree::displayDidRefreshOnScrollingThread):
+(WebCore::ThreadedScrollingTree::storeScrollPositionsAtLastDisplayRefresh):
+* page/scrolling/ThreadedScrollingTree.h:
+* page/scrolling/mac/ScrollingTreeFrameScrollingNodeMac.mm:
+(WebCore::ScrollingTreeFrameScrollingNodeMac::repositionScrollingLayers):
+
2021-12-12 Alan Bujtas
[LFC][IFC] Add partial unicode-bidi support on inline level boxes
Modified: trunk/Source/WebCore/page/scrolling/ScrollingTreeScrollingNode.cpp (286931 => 286932)
--- trunk/Source/WebCore/page/scrolling/ScrollingTreeScrollingNode.cpp 2021-12-13 01:46:09 UTC (rev 286931)
+++ trunk/Source/WebCore/page/scrolling/ScrollingTreeScrollingNode.cpp 2021-12-13 02:42:35 UTC (rev 286932)
@@ -303,6 +303,11 @@
scrollingTree().scrollingTreeNodeDidScroll(*this, action);
}
+void ScrollingTreeScrollingNode::updateScrollPositionAtLastDisplayRefresh()
+{
+m_scrollPositionAtLastDisplayRefresh = m_currentScrollPosition;
+}
+
bool ScrollingTreeScrollingNode::scrollPositionAndLayoutViewportMatch(const FloatPoint& position, std::optional)
{
return position == m_currentScrollPosition;
Modified: trunk/Source/WebCore/page/scrolling/ScrollingTreeScrollingNode.h (286931 => 286932)
--- trunk/Source/WebCore/page/scrolling/ScrollingTreeScrollingNode.h 2021-12-13 01:46:09 UTC (rev 286931)
+++
[webkit-changes] [286931] trunk
Title: [286931] trunk
Revision 286931
Author za...@apple.com
Date 2021-12-12 17:46:09 -0800 (Sun, 12 Dec 2021)
Log Message
[LFC][IFC] Add partial unicode-bidi support on inline level boxes
https://bugs.webkit.org/show_bug.cgi?id=234196
Reviewed by Antti Koivisto.
Source/WebCore:
This patch enables partial unicode-bidi processing on all elements (block and inline).
* layout/formattingContexts/inline/InlineDisplayContentBuilder.cpp:
(WebCore::Layout::InlineDisplayContentBuilder::processBidiContent): The paragraph builder now may
produce valid bidi levels for inline box end type of inline items (see popDirectionalFormatting).
* layout/integration/LayoutIntegrationCoverage.cpp:
(WebCore::LayoutIntegration::canUseForStyle):
LayoutTests:
* platform/mac/fast/text/international/bidi-ignored-for-first-child-inline-expected.txt: Progression.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac/fast/text/international/bidi-ignored-for-first-child-inline-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/layout/formattingContexts/inline/InlineDisplayContentBuilder.cpp
trunk/Source/WebCore/layout/integration/LayoutIntegrationCoverage.cpp
Diff
Modified: trunk/LayoutTests/ChangeLog (286930 => 286931)
--- trunk/LayoutTests/ChangeLog 2021-12-13 01:09:22 UTC (rev 286930)
+++ trunk/LayoutTests/ChangeLog 2021-12-13 01:46:09 UTC (rev 286931)
@@ -1,5 +1,14 @@
2021-12-12 Alan Bujtas
+[LFC][IFC] Add partial unicode-bidi support on inline level boxes
+https://bugs.webkit.org/show_bug.cgi?id=234196
+
+Reviewed by Antti Koivisto.
+
+* platform/mac/fast/text/international/bidi-ignored-for-first-child-inline-expected.txt: Progression.
+
+2021-12-12 Alan Bujtas
+
[LFC][IFC] Ignore zero width glyphs while collecting fallback fonts
https://bugs.webkit.org/show_bug.cgi?id=234210
Modified: trunk/LayoutTests/platform/mac/fast/text/international/bidi-ignored-for-first-child-inline-expected.txt (286930 => 286931)
--- trunk/LayoutTests/platform/mac/fast/text/international/bidi-ignored-for-first-child-inline-expected.txt 2021-12-13 01:09:22 UTC (rev 286930)
+++ trunk/LayoutTests/platform/mac/fast/text/international/bidi-ignored-for-first-child-inline-expected.txt 2021-12-13 01:46:09 UTC (rev 286931)
@@ -86,25 +86,22 @@
RenderText {#text} at (0,1) size 62x18
text run at (0,1) width 62 RTL: "\x{5D3}\x{5D4}\x{5D5}([\x{202A}\x{202C}\x{5D0}\x{5D1}\x{5D2}"
RenderBlock {P} at (0,421) size 784x19
-RenderText {#text} at (0,1) size 36x18
- text run at (0,1) width 25 RTL: "\x{5D3}\x{5D4}\x{5D5}"
- text run at (24,1) width 12: "(["
-RenderInline {SPAN} at (0,0) size 1x18
-RenderText {#text} at (35,1) size 27x18
- text run at (35,1) width 27 RTL: "\x{5D0}\x{5D1}\x{5D2}"
+RenderText {#text} at (26,1) size 36x18
+ text run at (26,1) width 36 RTL: "\x{5D3}\x{5D4}\x{5D5}(["
+RenderInline {SPAN} at (0,0) size 0x18
+RenderText {#text} at (0,1) size 27x18
+ text run at (0,1) width 27 RTL: "\x{5D0}\x{5D1}\x{5D2}"
RenderBlock {P} at (0,456) size 784x19
-RenderText {#text} at (0,1) size 36x18
- text run at (0,1) width 25 RTL: "\x{5D3}\x{5D4}\x{5D5}"
- text run at (24,1) width 12: "(["
-RenderInline {SPAN} at (0,0) size 1x18
- RenderInline {SPAN} at (0,0) size 1x18
-RenderText {#text} at (35,1) size 27x18
- text run at (35,1) width 27 RTL: "\x{5D0}\x{5D1}\x{5D2}"
+RenderText {#text} at (26,1) size 36x18
+ text run at (26,1) width 36 RTL: "\x{5D3}\x{5D4}\x{5D5}(["
+RenderInline {SPAN} at (0,0) size 0x18
+ RenderInline {SPAN} at (0,0) size 0x0
+RenderText {#text} at (0,1) size 27x18
+ text run at (0,1) width 27 RTL: "\x{5D0}\x{5D1}\x{5D2}"
RenderBlock {P} at (0,491) size 784x19
-RenderText {#text} at (0,1) size 36x18
- text run at (0,1) width 25 RTL: "\x{5D3}\x{5D4}\x{5D5}"
- text run at (24,1) width 12: "(["
-RenderInline {SPAN} at (0,0) size 27x18
- RenderInline {SPAN} at (0,0) size 1x18
-RenderText {#text} at (35,1) size 27x18
- text run at (35,1) width 27 RTL: "\x{5D0}\x{5D1}\x{5D2}"
+RenderText {#text} at (26,1) size 36x18
+ text run at (26,1) width 36 RTL: "\x{5D3}\x{5D4}\x{5D5}(["
+RenderInline {SPAN} at (0,0) size 0x18
+ RenderInline {SPAN} at (0,0) size 0x0
+RenderText {#text} at (0,1) size 27x18
+ text run at (0,1) width 27 RTL: "\x{5D0}\x{5D1}\x{5D2}"
Modified: trunk/Source/WebCore/ChangeLog (286930 => 286931)
--- trunk/Source/WebCore/ChangeLog 2021-12-13 01:09:22 UTC (rev 286930)
+++ trunk/Source/WebCore/ChangeLog 2021-12-13 01:46:09 UTC (rev 286931)
@@ -1,5 +1,21 @@
2021-12-12 Alan Bujtas
+[LFC][IFC] Add partial unicode-bidi support on inline level boxes
+
[webkit-changes] [286930] trunk/Source/JavaScriptCore
Title: [286930] trunk/Source/_javascript_Core Revision 286930 Author ysuz...@apple.com Date 2021-12-12 17:09:22 -0800 (Sun, 12 Dec 2021) Log Message [JSC] Use FixedVector to shrink some of Wasm data structures https://bugs.webkit.org/show_bug.cgi?id=234206 Reviewed by Saam Barati. We can use FixedVector to shrink some of Wasm data structures including Wasm::Callee. * wasm/WasmAirIRGenerator.cpp: (JSC::Wasm::AirIRGenerator::emitLoopTierUpCheck): * wasm/WasmB3IRGenerator.cpp: (JSC::Wasm::PatchpointExceptionHandle::generate const): (JSC::Wasm::B3IRGenerator::emitLoopTierUpCheck): * wasm/WasmCallee.cpp: (JSC::Wasm::LLIntCallee::linkExceptionHandlers): (JSC::Wasm::OptimizingJITCallee::linkExceptionHandlers): (JSC::Wasm::OptimizingJITCallee::stackmap const): * wasm/WasmCallee.h: (JSC::Wasm::Callee::hasExceptionHandlers const): (JSC::Wasm::JITCallee::wasmToWasmCallsites): (JSC::Wasm::OptimizingJITCallee::OptimizingJITCallee): * wasm/WasmCodeBlock.cpp: (JSC::Wasm::CodeBlock::CodeBlock): * wasm/WasmCodeBlock.h: * wasm/WasmHandlerInfo.cpp: (JSC::Wasm::HandlerInfo::handlerForIndex): * wasm/WasmHandlerInfo.h: * wasm/WasmOSREntryData.h: (JSC::Wasm::OSREntryData::OSREntryData): (JSC::Wasm::OSREntryData::values): (JSC::Wasm::OSREntryValue::OSREntryValue): Deleted. (JSC::Wasm::OSREntryValue::type const): Deleted. * wasm/WasmPlan.cpp: (JSC::Wasm::Plan::updateCallSitesToCallUs): * wasm/WasmTierUpCount.cpp: (JSC::Wasm::TierUpCount::addOSREntryData): * wasm/WasmTierUpCount.h: * wasm/js/JSWebAssemblyCodeBlock.cpp: (JSC::JSWebAssemblyCodeBlock::JSWebAssemblyCodeBlock): * wasm/js/JSWebAssemblyCodeBlock.h: Modified Paths trunk/Source/_javascript_Core/ChangeLog trunk/Source/_javascript_Core/wasm/WasmAirIRGenerator.cpp trunk/Source/_javascript_Core/wasm/WasmB3IRGenerator.cpp trunk/Source/_javascript_Core/wasm/WasmCallee.cpp trunk/Source/_javascript_Core/wasm/WasmCallee.h trunk/Source/_javascript_Core/wasm/WasmCodeBlock.cpp trunk/Source/_javascript_Core/wasm/WasmCodeBlock.h trunk/Source/_javascript_Core/wasm/WasmHandlerInfo.cpp trunk/Source/_javascript_Core/wasm/WasmHandlerInfo.h trunk/Source/_javascript_Core/wasm/WasmOSREntryData.h trunk/Source/_javascript_Core/wasm/WasmPlan.cpp trunk/Source/_javascript_Core/wasm/WasmTierUpCount.cpp trunk/Source/_javascript_Core/wasm/WasmTierUpCount.h trunk/Source/_javascript_Core/wasm/js/JSWebAssemblyCodeBlock.cpp trunk/Source/_javascript_Core/wasm/js/JSWebAssemblyCodeBlock.h Diff Modified: trunk/Source/_javascript_Core/ChangeLog (286929 => 286930) --- trunk/Source/_javascript_Core/ChangeLog 2021-12-12 23:49:39 UTC (rev 286929) +++ trunk/Source/_javascript_Core/ChangeLog 2021-12-13 01:09:22 UTC (rev 286930) @@ -1,3 +1,45 @@ +2021-12-12 Yusuke Suzuki + +[JSC] Use FixedVector to shrink some of Wasm data structures +https://bugs.webkit.org/show_bug.cgi?id=234206 + +Reviewed by Saam Barati. + +We can use FixedVector to shrink some of Wasm data structures including Wasm::Callee. + +* wasm/WasmAirIRGenerator.cpp: +(JSC::Wasm::AirIRGenerator::emitLoopTierUpCheck): +* wasm/WasmB3IRGenerator.cpp: +(JSC::Wasm::PatchpointExceptionHandle::generate const): +(JSC::Wasm::B3IRGenerator::emitLoopTierUpCheck): +* wasm/WasmCallee.cpp: +(JSC::Wasm::LLIntCallee::linkExceptionHandlers): +(JSC::Wasm::OptimizingJITCallee::linkExceptionHandlers): +(JSC::Wasm::OptimizingJITCallee::stackmap const): +* wasm/WasmCallee.h: +(JSC::Wasm::Callee::hasExceptionHandlers const): +(JSC::Wasm::JITCallee::wasmToWasmCallsites): +(JSC::Wasm::OptimizingJITCallee::OptimizingJITCallee): +* wasm/WasmCodeBlock.cpp: +(JSC::Wasm::CodeBlock::CodeBlock): +* wasm/WasmCodeBlock.h: +* wasm/WasmHandlerInfo.cpp: +(JSC::Wasm::HandlerInfo::handlerForIndex): +* wasm/WasmHandlerInfo.h: +* wasm/WasmOSREntryData.h: +(JSC::Wasm::OSREntryData::OSREntryData): +(JSC::Wasm::OSREntryData::values): +(JSC::Wasm::OSREntryValue::OSREntryValue): Deleted. +(JSC::Wasm::OSREntryValue::type const): Deleted. +* wasm/WasmPlan.cpp: +(JSC::Wasm::Plan::updateCallSitesToCallUs): +* wasm/WasmTierUpCount.cpp: +(JSC::Wasm::TierUpCount::addOSREntryData): +* wasm/WasmTierUpCount.h: +* wasm/js/JSWebAssemblyCodeBlock.cpp: +(JSC::JSWebAssemblyCodeBlock::JSWebAssemblyCodeBlock): +* wasm/js/JSWebAssemblyCodeBlock.h: + 2021-12-11 Saam Barati Teach the sampling profiler how to display origin data for B3 Wasm Modified: trunk/Source/_javascript_Core/wasm/WasmAirIRGenerator.cpp (286929 => 286930) --- trunk/Source/_javascript_Core/wasm/WasmAirIRGenerator.cpp 2021-12-12 23:49:39 UTC (rev 286929) +++ trunk/Source/_javascript_Core/wasm/WasmAirIRGenerator.cpp 2021-12-13 01:09:22 UTC (rev 286930) @@ -2924,10 +2924,13 @@ CCallHelpers::Jump tierUp =
[webkit-changes] [286929] trunk/Source/WebCore
Title: [286929] trunk/Source/WebCore
Revision 286929
Author za...@apple.com
Date 2021-12-12 15:49:39 -0800 (Sun, 12 Dec 2021)
Log Message
[LFC][IFC] Add partial unicode-bidi support on the block container
https://bugs.webkit.org/show_bug.cgi?id=234195
Reviewed by Antti Koivisto.
'unicode-bidi: plaintext' on the block container may change the base directionality of
the container itself. We only support LTR inline axis direction.
* layout/formattingContexts/inline/InlineItemsBuilder.cpp:
(WebCore::Layout::handleEnterExitBidiContext):
(WebCore::Layout::buildBidiParagraph): Add control character for the unicode-bidi property on the block container.
(WebCore::Layout::InlineItemsBuilder::breakAndComputeBidiLevels):
* layout/integration/LayoutIntegrationCoverage.cpp:
(WebCore::LayoutIntegration::canUseForStyle):
(WebCore::LayoutIntegration::canUseForRenderInlineChild):
(WebCore::LayoutIntegration::canUseForLineLayoutWithReason):
(WebCore::LayoutIntegration::canUseForLineLayoutAfterStyleChange):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/layout/formattingContexts/inline/InlineItemsBuilder.cpp
trunk/Source/WebCore/layout/integration/LayoutIntegrationCoverage.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (286928 => 286929)
--- trunk/Source/WebCore/ChangeLog 2021-12-12 22:10:39 UTC (rev 286928)
+++ trunk/Source/WebCore/ChangeLog 2021-12-12 23:49:39 UTC (rev 286929)
@@ -1,5 +1,25 @@
2021-12-12 Alan Bujtas
+[LFC][IFC] Add partial unicode-bidi support on the block container
+https://bugs.webkit.org/show_bug.cgi?id=234195
+
+Reviewed by Antti Koivisto.
+
+'unicode-bidi: plaintext' on the block container may change the base directionality of
+the container itself. We only support LTR inline axis direction.
+
+* layout/formattingContexts/inline/InlineItemsBuilder.cpp:
+(WebCore::Layout::handleEnterExitBidiContext):
+(WebCore::Layout::buildBidiParagraph): Add control character for the unicode-bidi property on the block container.
+(WebCore::Layout::InlineItemsBuilder::breakAndComputeBidiLevels):
+* layout/integration/LayoutIntegrationCoverage.cpp:
+(WebCore::LayoutIntegration::canUseForStyle):
+(WebCore::LayoutIntegration::canUseForRenderInlineChild):
+(WebCore::LayoutIntegration::canUseForLineLayoutWithReason):
+(WebCore::LayoutIntegration::canUseForLineLayoutAfterStyleChange):
+
+2021-12-12 Alan Bujtas
+
[LFC][IFC] Ignore zero width glyphs while collecting fallback fonts
https://bugs.webkit.org/show_bug.cgi?id=234210
Modified: trunk/Source/WebCore/layout/formattingContexts/inline/InlineItemsBuilder.cpp (286928 => 286929)
--- trunk/Source/WebCore/layout/formattingContexts/inline/InlineItemsBuilder.cpp 2021-12-12 22:10:39 UTC (rev 286928)
+++ trunk/Source/WebCore/layout/formattingContexts/inline/InlineItemsBuilder.cpp 2021-12-12 23:49:39 UTC (rev 286929)
@@ -170,9 +170,44 @@
paragraphContentBuilder.append(textContent.right(contentLength - nonReplacedContentStartPosition));
}
+static inline void handleEnterExitBidiContext(StringBuilder& paragraphContentBuilder, EUnicodeBidi unicodeBidi, bool isLTR, bool isEnteringBidi)
+{
+switch (unicodeBidi) {
+case EUnicodeBidi::UBNormal:
+// The box does not open an additional level of embedding with respect to the bidirectional algorithm.
+// For inline boxes, implicit reordering works across box boundaries.
+break;
+case EUnicodeBidi::Embed:
+paragraphContentBuilder.append(isEnteringBidi ? (isLTR ? leftToRightEmbed : rightToLeftEmbed) : popDirectionalFormatting);
+break;
+case EUnicodeBidi::Override:
+paragraphContentBuilder.append(isEnteringBidi ? (isLTR ? leftToRightOverride : rightToLeftOverride) : popDirectionalFormatting);
+break;
+case EUnicodeBidi::Isolate:
+paragraphContentBuilder.append(isEnteringBidi ? (isLTR ? leftToRightIsolate : rightToLeftIsolate) : popDirectionalIsolate);
+break;
+case EUnicodeBidi::Plaintext:
+paragraphContentBuilder.append(isEnteringBidi ? firstStrongIsolate : popDirectionalIsolate);
+break;
+case EUnicodeBidi::IsolateOverride:
+if (isEnteringBidi) {
+paragraphContentBuilder.append(firstStrongIsolate);
+paragraphContentBuilder.append(isLTR ? leftToRightOverride : rightToLeftOverride);
+} else {
+paragraphContentBuilder.append(popDirectionalFormatting);
+paragraphContentBuilder.append(popDirectionalIsolate);
+}
+break;
+default:
+ASSERT_NOT_REACHED();
+}
+}
+
using InlineItemOffsetList = Vector>;
-static inline void buildBidiParagraph(const InlineItems& inlineItems, StringBuilder& paragraphContentBuilder, InlineItemOffsetList& inlineItemOffsetList)
+static inline void buildBidiParagraph(const RenderStyle& rootStyle, const InlineItems&
[webkit-changes] [286928] trunk
Title: [286928] trunk
Revision 286928
Author za...@apple.com
Date 2021-12-12 14:10:39 -0800 (Sun, 12 Dec 2021)
Log Message
[LFC][IFC] Ignore zero width glyphs while collecting fallback fonts
https://bugs.webkit.org/show_bug.cgi?id=234210
Reviewed by Antti Koivisto.
Source/WebCore:
Taking zero width glyphs (e.g. control characters) into consideration while collecting
fallback font information may result in incorrect line height and baseline positioning.
The logic in this patch matches with WidthIterator::commitCurrentFontRange (used by legacy line layout).
It is measured to have only a slight perf impact on layout microbenchmarks (~1%).
Alternatively we could check against unicode ranges to omit certain glyphs.
Test: fast/text/fallback-font-and-zero-width-glyph.html
* layout/formattingContexts/inline/text/TextUtil.cpp:
(WebCore::Layout::fallbackFontsForRunWithIterator):
LayoutTests:
* fast/text/fallback-font-and-zero-width-glyph-expected.html: Added.
* fast/text/fallback-font-and-zero-width-glyph.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac-bigsur/fast/borders/bidi-002-expected.txt
trunk/LayoutTests/platform/mac-bigsur/fast/dom/52776-expected.txt
trunk/LayoutTests/platform/mac-bigsur/fast/text/international/bidi-neutral-run-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/layout/formattingContexts/inline/text/TextUtil.cpp
Added Paths
trunk/LayoutTests/fast/text/fallback-font-and-zero-width-glyph-expected.html
trunk/LayoutTests/fast/text/fallback-font-and-zero-width-glyph.html
Diff
Modified: trunk/LayoutTests/ChangeLog (286927 => 286928)
--- trunk/LayoutTests/ChangeLog 2021-12-12 20:21:26 UTC (rev 286927)
+++ trunk/LayoutTests/ChangeLog 2021-12-12 22:10:39 UTC (rev 286928)
@@ -1,3 +1,13 @@
+2021-12-12 Alan Bujtas
+
+[LFC][IFC] Ignore zero width glyphs while collecting fallback fonts
+https://bugs.webkit.org/show_bug.cgi?id=234210
+
+Reviewed by Antti Koivisto.
+
+* fast/text/fallback-font-and-zero-width-glyph-expected.html: Added.
+* fast/text/fallback-font-and-zero-width-glyph.html: Added.
+
2021-12-12 Fujii Hironori
[WinCairo] Unreviewed test gardening
Added: trunk/LayoutTests/fast/text/fallback-font-and-zero-width-glyph-expected.html (0 => 286928)
--- trunk/LayoutTests/fast/text/fallback-font-and-zero-width-glyph-expected.html (rev 0)
+++ trunk/LayoutTests/fast/text/fallback-font-and-zero-width-glyph-expected.html 2021-12-12 22:10:39 UTC (rev 286928)
@@ -0,0 +1,9 @@
+
+div {
+ font-size: 400px;
+ font-family: Ahem;
+ color: black;
+ border: 10px solid green;
+}
+
+X
Added: trunk/LayoutTests/fast/text/fallback-font-and-zero-width-glyph.html (0 => 286928)
--- trunk/LayoutTests/fast/text/fallback-font-and-zero-width-glyph.html (rev 0)
+++ trunk/LayoutTests/fast/text/fallback-font-and-zero-width-glyph.html 2021-12-12 22:10:39 UTC (rev 286928)
@@ -0,0 +1,10 @@
+
+div {
+ font-size: 400px;
+ font-family: Ahem;
+ color: black;
+ border: 10px solid green;
+}
+
+
+X
Modified: trunk/LayoutTests/platform/mac-bigsur/fast/borders/bidi-002-expected.txt (286927 => 286928)
--- trunk/LayoutTests/platform/mac-bigsur/fast/borders/bidi-002-expected.txt 2021-12-12 20:21:26 UTC (rev 286927)
+++ trunk/LayoutTests/platform/mac-bigsur/fast/borders/bidi-002-expected.txt 2021-12-12 22:10:39 UTC (rev 286928)
@@ -1,14 +1,14 @@
layer at (0,0) size 800x600
RenderView at (0,0) size 800x600
-layer at (0,0) size 800x260
- RenderBlock {HTML} at (0,0) size 800x260
-RenderBody {BODY} at (8,16) size 784x228
+layer at (0,0) size 800x259
+ RenderBlock {HTML} at (0,0) size 800x259
+RenderBody {BODY} at (8,16) size 784x227
RenderBlock {P} at (0,0) size 784x19
RenderText {#text} at (0,1) size 521x18
text run at (0,1) width 506: "The following two blocks should be identical, including overflow. (Force bidi: "
text run at (505,1) width 11 RTL: "\x{5D0}"
text run at (515,1) width 6: ")"
- RenderBlock {DIV} at (0,35) size 784x193
+ RenderBlock {DIV} at (0,35) size 784x192
RenderBlock {P} at (16,0) size 294x88 [bgcolor=#CC] [border: (3px solid #00)]
RenderInline {SPAN} at (0,0) size 118x38 [color=#80] [border: (3px solid #80) none (3px solid #80)]
RenderText {#text} at (30,26) size 99x18
@@ -20,12 +20,12 @@
text run at (219,26) width 86: "GGGHHHIII"
RenderText {#text} at (11,59) size 195x18
text run at (11,59) width 195: "JJJKKKLLLMMMNNNOOO"
-RenderBlock {P} at (16,104) size 294x89 [bgcolor=#CC] [border: (3px solid #00)]
+RenderBlock {P} at (16,104) size 294x88 [bgcolor=#CC] [border: (3px solid #00)]
RenderInline {SPAN} at (0,0) size 313x38 [color=#80] [border: (3px solid #80)]
RenderText {#text} at (30,26) size 275x18
[webkit-changes] [286927] trunk/LayoutTests
Title: [286927] trunk/LayoutTests Revision 286927 Author hironori.fu...@sony.com Date 2021-12-12 12:21:26 -0800 (Sun, 12 Dec 2021) Log Message [WinCairo] Unreviewed test gardening * platform/wincairo/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/wincairo/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (286926 => 286927) --- trunk/LayoutTests/ChangeLog 2021-12-12 17:44:20 UTC (rev 286926) +++ trunk/LayoutTests/ChangeLog 2021-12-12 20:21:26 UTC (rev 286927) @@ -1,3 +1,9 @@ +2021-12-12 Fujii Hironori + +[WinCairo] Unreviewed test gardening + +* platform/wincairo/TestExpectations: + 2021-12-12 Arcady Goldmints-Orlov [GLIB] Update test expectations and baselines. Unreviewed test gardening. Modified: trunk/LayoutTests/platform/wincairo/TestExpectations (286926 => 286927) --- trunk/LayoutTests/platform/wincairo/TestExpectations 2021-12-12 17:44:20 UTC (rev 286926) +++ trunk/LayoutTests/platform/wincairo/TestExpectations 2021-12-12 20:21:26 UTC (rev 286927) @@ -1066,8 +1066,6 @@ css3/flexbox/csswg/ttwf-reftest-flex-wrap-reverse.html [ Pass ] css3/flexbox/csswg/ttwf-reftest-flex-wrap.html [ Pass ] -imported/w3c/web-platform-tests/css/css-flexbox/flex-item-contains-strict.html [ Failure ] - fast/css/apple-system-colors.html [ Failure ] fast/css/image-rendering-parsing.html [ Failure Pass ] fast/css/paint-order-shadow.html [ ImageOnlyFailure ] @@ -2093,9 +2091,6 @@ fast/text/soft-hyphen-2.html [ Failure ] fast/text/soft-hyphen-3.html [ Failure ] fast/text/soft-hyphen-4.html [ Failure ] -http/tests/xmlhttprequest/onabort-response-getters.html [ Failure ] -http/tests/xmlhttprequest/onload-progressevent-attributes.html [ Failure ] -http/tests/xmlhttprequest/xmlhttprequest-LSProgressEvent-ProgressEvent-should-match.html [ Failure ] fast/box-shadow/hidpi-box-shadow-inset-on-subpixel-position.html [ ImageOnlyFailure ] fast/text/hanging-punctuation-allow-end-basic.html [ ImageOnlyFailure ] @@ -2103,3 +2098,18 @@ webgl/gl-clear-preserve-drawing-buffer-bug.html [ ImageOnlyFailure ] fast/text/preserved-white-space-with-word-spacing.html [ ImageOnlyFailure ] + +dom/xhtml/level3/core/canonicalform06.xhtml [ Failure ] +dom/xhtml/level3/core/infoset06.xhtml [ Failure ] +dom/xhtml/level3/core/infoset07.xhtml [ Failure ] +dom/xhtml/level3/core/wellformed01.xhtml [ Failure ] +dom/xhtml/level3/core/wellformed02.xhtml [ Failure ] +dom/xhtml/level3/core/wellformed03.xhtml [ Failure ] +dom/xhtml/level3/core/wellformed04.xhtml [ Failure ] +fast/css/contain-invalidate-if-disabled.html [ Failure ] + +fast/filter-image/filter-image-blur.html [ ImageOnlyFailure ] +fast/text/otsvg-canvas.html [ ImageOnlyFailure ] + +accessibility/aria-roledescription.html [ Timeout ] +accessibility/visible-elements.html [ Timeout ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [286926] trunk/LayoutTests
Title: [286926] trunk/LayoutTests Revision 286926 Author commit-qu...@webkit.org Date 2021-12-12 09:44:20 -0800 (Sun, 12 Dec 2021) Log Message [GLIB] Update test expectations and baselines. Unreviewed test gardening. https://bugs.webkit.org/show_bug.cgi?id=234209 Patch by Arcady Goldmints-Orlov on 2021-12-12 * platform/glib/TestExpectations: * platform/glib/imported/w3c/web-platform-tests/css/cssom-view/getBoundingClientRect-shy-expected.txt: * platform/glib/svg/css/getComputedStyle-basic-expected.txt: * platform/glib/webgl/1.0.3/conformance/glsl/misc/shaders-with-name-conflicts-expected.txt: * platform/gtk/TestExpectations: * platform/gtk/imported/w3c/web-platform-tests/css/cssom/getComputedStyle-detached-subtree-expected.txt: * platform/gtk/imported/w3c/web-platform-tests/html/semantics/forms/constraints/form-validation-validity-valid-expected.txt: * platform/gtk/imported/w3c/web-platform-tests/html/semantics/forms/constraints/form-validation-validity-valueMissing-expected.txt: * platform/gtk/imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/datetime-local-expected.txt: * platform/gtk/imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/time-2-expected.txt: * platform/wpe/css2.1/t0805-c5518-brdr-t-01-e-expected.txt: * platform/wpe/css2.1/t0805-c5519-brdr-r-01-e-expected.txt: * platform/wpe/css2.1/t0805-c5520-brdr-b-01-e-expected.txt: * platform/wpe/css2.1/t0805-c5521-brdr-l-01-e-expected.txt: * platform/wpe/css2.1/t0805-c5521-ibrdr-l-00-a-expected.txt: * platform/wpe/imported/w3c/web-platform-tests/selection/selection-select-all-move-input-crash-expected.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/glib/TestExpectations trunk/LayoutTests/platform/glib/imported/w3c/web-platform-tests/css/cssom-view/getBoundingClientRect-shy-expected.txt trunk/LayoutTests/platform/glib/svg/css/getComputedStyle-basic-expected.txt trunk/LayoutTests/platform/glib/webgl/1.0.3/conformance/glsl/misc/shaders-with-name-conflicts-expected.txt trunk/LayoutTests/platform/gtk/TestExpectations trunk/LayoutTests/platform/gtk/imported/w3c/web-platform-tests/css/cssom/getComputedStyle-detached-subtree-expected.txt trunk/LayoutTests/platform/gtk/imported/w3c/web-platform-tests/html/semantics/forms/constraints/form-validation-validity-valid-expected.txt trunk/LayoutTests/platform/gtk/imported/w3c/web-platform-tests/html/semantics/forms/constraints/form-validation-validity-valueMissing-expected.txt trunk/LayoutTests/platform/gtk/imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/datetime-local-expected.txt trunk/LayoutTests/platform/gtk/imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/time-2-expected.txt trunk/LayoutTests/platform/wpe/css2.1/t0805-c5518-brdr-t-01-e-expected.txt trunk/LayoutTests/platform/wpe/css2.1/t0805-c5519-brdr-r-01-e-expected.txt trunk/LayoutTests/platform/wpe/css2.1/t0805-c5520-brdr-b-01-e-expected.txt trunk/LayoutTests/platform/wpe/css2.1/t0805-c5521-brdr-l-01-e-expected.txt trunk/LayoutTests/platform/wpe/css2.1/t0805-c5521-ibrdr-l-00-a-expected.txt trunk/LayoutTests/platform/wpe/imported/w3c/web-platform-tests/selection/selection-select-all-move-input-crash-expected.txt Diff Modified: trunk/LayoutTests/ChangeLog (286925 => 286926) --- trunk/LayoutTests/ChangeLog 2021-12-12 17:31:36 UTC (rev 286925) +++ trunk/LayoutTests/ChangeLog 2021-12-12 17:44:20 UTC (rev 286926) @@ -1,3 +1,25 @@ +2021-12-12 Arcady Goldmints-Orlov + +[GLIB] Update test expectations and baselines. Unreviewed test gardening. +https://bugs.webkit.org/show_bug.cgi?id=234209 + +* platform/glib/TestExpectations: +* platform/glib/imported/w3c/web-platform-tests/css/cssom-view/getBoundingClientRect-shy-expected.txt: +* platform/glib/svg/css/getComputedStyle-basic-expected.txt: +* platform/glib/webgl/1.0.3/conformance/glsl/misc/shaders-with-name-conflicts-expected.txt: +* platform/gtk/TestExpectations: +* platform/gtk/imported/w3c/web-platform-tests/css/cssom/getComputedStyle-detached-subtree-expected.txt: +* platform/gtk/imported/w3c/web-platform-tests/html/semantics/forms/constraints/form-validation-validity-valid-expected.txt: +* platform/gtk/imported/w3c/web-platform-tests/html/semantics/forms/constraints/form-validation-validity-valueMissing-expected.txt: +* platform/gtk/imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/datetime-local-expected.txt: +* platform/gtk/imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/time-2-expected.txt: +* platform/wpe/css2.1/t0805-c5518-brdr-t-01-e-expected.txt: +* platform/wpe/css2.1/t0805-c5519-brdr-r-01-e-expected.txt: +* platform/wpe/css2.1/t0805-c5520-brdr-b-01-e-expected.txt: +* platform/wpe/css2.1/t0805-c5521-brdr-l-01-e-expected.txt: +* platform/wpe/css2.1/t0805-c5521-ibrdr-l-00-a-expected.txt: +
[webkit-changes] [286925] trunk
Title: [286925] trunk Revision 286925 Author wei...@apple.com Date 2021-12-12 09:31:36 -0800 (Sun, 12 Dec 2021) Log Message Pipe ColorInterpolationMethod into Gradient https://bugs.webkit.org/show_bug.cgi?id=234205 Reviewed by Antti Koivisto. Source/WebCore: There is no functional change yet, this just adds a required ColorInterpolationMethod parameter to Gradient, which for the moment has to be SRGB and non-premultiplied alpha. Subsequent changes will support for specifying an interpolation method via CSS gradients as well as implementing support for that in the platform gradient backends. Also moves the ColorInterpolationMethod struct into its own file as it was getting quite long. * Headers.cmake: * WebCore.xcodeproj/project.pbxproj: * css/CSSGradientValue.cpp: (WebCore::CSSGradientValue::equals const): (WebCore::CSSLinearGradientValue::createGradient): (WebCore::CSSRadialGradientValue::createGradient): (WebCore::CSSConicGradientValue::createGradient): * css/CSSGradientValue.h: (WebCore::CSSGradientValue::CSSGradientValue): (WebCore::CSSGradientValue::colorInterpolationMethod const): * css/parser/CSSPropertyParserHelpers.cpp: (WebCore::CSSPropertyParserHelpers::consumeDeprecatedGradient): (WebCore::CSSPropertyParserHelpers::consumeDeprecatedRadialGradient): (WebCore::CSSPropertyParserHelpers::consumeRadialGradient): (WebCore::CSSPropertyParserHelpers::consumeLinearGradient): (WebCore::CSSPropertyParserHelpers::consumeConicGradient): * html/HTMLInputElement.cpp: (WebCore::autoFillStrongPasswordMaskImage): * html/canvas/CanvasGradient.cpp: (WebCore::CanvasGradient::CanvasGradient): * platform/graphics/ColorInterpolation.h: (WebCore::interpolateColorComponents): (WebCore::ColorInterpolationMethod::encode const): Deleted. (WebCore::ColorInterpolationMethod::decode): Deleted. * platform/graphics/ColorInterpolationMethod.h: Added. (WebCore::ColorInterpolationMethod::encode const): (WebCore::ColorInterpolationMethod::decode): (WebCore::add): (WebCore::operator==): * platform/graphics/Gradient.cpp: (WebCore::Gradient::create): (WebCore::Gradient::Gradient): (WebCore::Gradient::hash const): * platform/graphics/Gradient.h: (WebCore::Gradient::encode const): (WebCore::Gradient::decode): * rendering/RenderThemeIOS.mm: (WebCore::RenderThemeIOS::paintProgressBar): (WebCore::RenderThemeIOS::checkboxRadioBackgroundGradient): (WebCore::RenderThemeIOS::paintColorWellDecorations): * rendering/svg/RenderSVGResourceLinearGradient.cpp: (WebCore::RenderSVGResourceLinearGradient::buildGradient const): * rendering/svg/RenderSVGResourceRadialGradient.cpp: (WebCore::RenderSVGResourceRadialGradient::buildGradient const): Tools: Update calls to Gradient::create() to pass the now required ColorInterpolationMethod. * TestWebKitAPI/Tests/WebCore/DisplayListTests.cpp: (TestWebKitAPI::createGradient): * TestWebKitAPI/Tests/WebCore/cg/BifurcatedGraphicsContextTestsCG.cpp: (TestWebKitAPI::TEST): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/Headers.cmake trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj trunk/Source/WebCore/css/CSSGradientValue.cpp trunk/Source/WebCore/css/CSSGradientValue.h trunk/Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp trunk/Source/WebCore/html/HTMLInputElement.cpp trunk/Source/WebCore/html/canvas/CanvasGradient.cpp trunk/Source/WebCore/platform/graphics/ColorInterpolation.h trunk/Source/WebCore/platform/graphics/Gradient.cpp trunk/Source/WebCore/platform/graphics/Gradient.h trunk/Source/WebCore/rendering/RenderThemeIOS.mm trunk/Source/WebCore/rendering/svg/RenderSVGResourceLinearGradient.cpp trunk/Source/WebCore/rendering/svg/RenderSVGResourceRadialGradient.cpp trunk/Tools/ChangeLog trunk/Tools/TestWebKitAPI/Tests/WebCore/DisplayListTests.cpp trunk/Tools/TestWebKitAPI/Tests/WebCore/cg/BifurcatedGraphicsContextTestsCG.cpp Added Paths trunk/Source/WebCore/platform/graphics/ColorInterpolationMethod.h Diff Modified: trunk/Source/WebCore/ChangeLog (286924 => 286925) --- trunk/Source/WebCore/ChangeLog 2021-12-12 17:29:45 UTC (rev 286924) +++ trunk/Source/WebCore/ChangeLog 2021-12-12 17:31:36 UTC (rev 286925) @@ -1,3 +1,62 @@ +2021-12-12 Sam Weinig + +Pipe ColorInterpolationMethod into Gradient +https://bugs.webkit.org/show_bug.cgi?id=234205 + +Reviewed by Antti Koivisto. + +There is no functional change yet, this just adds a required ColorInterpolationMethod parameter to +Gradient, which for the moment has to be SRGB and non-premultiplied alpha. Subsequent changes will +support for specifying an interpolation method via CSS gradients as well as implementing support +for that in the platform gradient backends. + +Also moves the ColorInterpolationMethod struct into its own file as it was getting quite long. + +* Headers.cmake: +* WebCore.xcodeproj/project.pbxproj: +* css/CSSGradientValue.cpp: +(WebCore::CSSGradientValue::equals const): +
[webkit-changes] [286924] trunk/LayoutTests
Title: [286924] trunk/LayoutTests Revision 286924 Author za...@apple.com Date 2021-12-12 09:29:45 -0800 (Sun, 12 Dec 2021) Log Message IFC progression after r286121. Unreviewed gardening. * TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (286923 => 286924) --- trunk/LayoutTests/ChangeLog 2021-12-12 09:05:17 UTC (rev 286923) +++ trunk/LayoutTests/ChangeLog 2021-12-12 17:29:45 UTC (rev 286924) @@ -1,3 +1,11 @@ +2021-12-12 Alan Bujtas + +IFC progression after r286121. + +Unreviewed gardening. + +* TestExpectations: + 2021-12-12 Antoine Quint Add a test for document.timeline.maximumFrameRate Modified: trunk/LayoutTests/TestExpectations (286923 => 286924) --- trunk/LayoutTests/TestExpectations 2021-12-12 09:05:17 UTC (rev 286923) +++ trunk/LayoutTests/TestExpectations 2021-12-12 17:29:45 UTC (rev 286924) @@ -2741,7 +2741,6 @@ webkit.org/b/195275 imported/w3c/web-platform-tests/css/css-text/white-space/tab-stop-threshold-002.html [ ImageOnlyFailure ] webkit.org/b/195275 imported/w3c/web-platform-tests/css/css-text/white-space/tab-stop-threshold-006.html [ ImageOnlyFailure ] webkit.org/b/195275 imported/w3c/web-platform-tests/css/css-text/white-space/control-chars-000.html [ ImageOnlyFailure ] -webkit.org/b/195275 imported/w3c/web-platform-tests/css/css-text/white-space/white-space-intrinsic-size-001.html [ ImageOnlyFailure ] webkit.org/b/195275 imported/w3c/web-platform-tests/css/css-text/white-space/text-space-collapse-preserve-breaks-001.xht [ ImageOnlyFailure ] webkit.org/b/214290 imported/w3c/web-platform-tests/css/css-text/white-space/eol-spaces-bidi-001.html [ ImageOnlyFailure ] webkit.org/b/214290 imported/w3c/web-platform-tests/css/css-text/white-space/seg-break-transformation-018.html [ ImageOnlyFailure ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [286923] trunk/LayoutTests
Title: [286923] trunk/LayoutTests Revision 286923 Author grao...@webkit.org Date 2021-12-12 01:05:17 -0800 (Sun, 12 Dec 2021) Log Message Add a test for document.timeline.maximumFrameRate https://bugs.webkit.org/show_bug.cgi?id=234200 Reviewed by Dean Jackson. Bug 234161 added a new document.timeline.maximumFrameRate property but didn't feature a test. This new test checks that we have a minimum of 60fps reported. * platform/mac-wk1/TestExpectations: * platform/win/TestExpectations: * webanimations/frame-rate/document-timeline-maximum-frame-rate-expected.txt: Added. * webanimations/frame-rate/document-timeline-maximum-frame-rate.html: Added. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/mac-wk1/TestExpectations trunk/LayoutTests/platform/win/TestExpectations Added Paths trunk/LayoutTests/webanimations/frame-rate/document-timeline-maximum-frame-rate-expected.txt trunk/LayoutTests/webanimations/frame-rate/document-timeline-maximum-frame-rate.html Diff Modified: trunk/LayoutTests/ChangeLog (286922 => 286923) --- trunk/LayoutTests/ChangeLog 2021-12-12 03:04:31 UTC (rev 286922) +++ trunk/LayoutTests/ChangeLog 2021-12-12 09:05:17 UTC (rev 286923) @@ -1,3 +1,18 @@ +2021-12-12 Antoine Quint + +Add a test for document.timeline.maximumFrameRate +https://bugs.webkit.org/show_bug.cgi?id=234200 + +Reviewed by Dean Jackson. + +Bug 234161 added a new document.timeline.maximumFrameRate property but didn't feature +a test. This new test checks that we have a minimum of 60fps reported. + +* platform/mac-wk1/TestExpectations: +* platform/win/TestExpectations: +* webanimations/frame-rate/document-timeline-maximum-frame-rate-expected.txt: Added. +* webanimations/frame-rate/document-timeline-maximum-frame-rate.html: Added. + 2021-12-11 Alan Bujtas fast/borders/bidi-002.html is failing on Monterey bots. Modified: trunk/LayoutTests/platform/mac-wk1/TestExpectations (286922 => 286923) --- trunk/LayoutTests/platform/mac-wk1/TestExpectations 2021-12-12 03:04:31 UTC (rev 286922) +++ trunk/LayoutTests/platform/mac-wk1/TestExpectations 2021-12-12 09:05:17 UTC (rev 286923) @@ -1522,3 +1522,6 @@ # DumpRenderTree doesn't invoke inspector instrumentation when repainting. webkit.org/b/232852 inspector/page/setShowPaintRects.html [ Skip ] + +# The DocumentTimeline.maximumFrameRate property which this test is about is only available in WK2. +webanimations/frame-rate/document-timeline-maximum-frame-rate.html [ Skip ] Modified: trunk/LayoutTests/platform/win/TestExpectations (286922 => 286923) --- trunk/LayoutTests/platform/win/TestExpectations 2021-12-12 03:04:31 UTC (rev 286922) +++ trunk/LayoutTests/platform/win/TestExpectations 2021-12-12 09:05:17 UTC (rev 286923) @@ -4765,3 +4765,6 @@ # OT-SVG is not implemented on Windows. fast/text/otsvg-canvas.html [ ImageOnlyFailure ] + +# The DocumentTimeline.maximumFrameRate property which this test is about is not available on Windows. +webanimations/frame-rate/document-timeline-maximum-frame-rate.html [ Skip ] Added: trunk/LayoutTests/webanimations/frame-rate/document-timeline-maximum-frame-rate-expected.txt (0 => 286923) --- trunk/LayoutTests/webanimations/frame-rate/document-timeline-maximum-frame-rate-expected.txt (rev 0) +++ trunk/LayoutTests/webanimations/frame-rate/document-timeline-maximum-frame-rate-expected.txt 2021-12-12 09:05:17 UTC (rev 286923) @@ -0,0 +1,3 @@ + +PASS document.timeline.maximumFrameRate is defined and reports an expected frame rate + Added: trunk/LayoutTests/webanimations/frame-rate/document-timeline-maximum-frame-rate.html (0 => 286923) --- trunk/LayoutTests/webanimations/frame-rate/document-timeline-maximum-frame-rate.html (rev 0) +++ trunk/LayoutTests/webanimations/frame-rate/document-timeline-maximum-frame-rate.html 2021-12-12 09:05:17 UTC (rev 286923) @@ -0,0 +1,15 @@ + + +DocumentTimeline.maximumFrameRate + +