[webkit-changes] [WebKit/WebKit] c2b42a: Enable ShadowRealm tests
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: c2b42a2f8f93aa45e45bb17dec31ab09739f8c01 https://github.com/WebKit/WebKit/commit/c2b42a2f8f93aa45e45bb17dec31ab09739f8c01 Author: Yusuke Suzuki Date: 2022-11-24 (Thu, 24 Nov 2022) Changed paths: M LayoutTests/TestExpectations Log Message: --- Enable ShadowRealm tests https://bugs.webkit.org/show_bug.cgi?id=248330 rdar://102656071 Reviewed by Ross Kirsling. * LayoutTests/TestExpectations: Canonical link: https://commits.webkit.org/257009@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 13ee07: Wrong overflow behavior for input fields containin...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 13ee07bc7a8e703c96573e18cdf6527c40c593c1 https://github.com/WebKit/WebKit/commit/13ee07bc7a8e703c96573e18cdf6527c40c593c1 Author: Tim Nguyen Date: 2022-11-24 (Thu, 24 Nov 2022) Changed paths: A LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/forms/number-input-vertical-overflow-expected.html A LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/forms/number-input-vertical-overflow-ref.html A LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/forms/number-input-vertical-overflow.html A LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/forms/text-input-vertical-overflow-no-scroll-expected.txt A LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/forms/text-input-vertical-overflow-no-scroll.html M Source/WebCore/html/shadow/TextControlInnerElements.cpp Log Message: --- Wrong overflow behavior for input fields containing ::-webkit-textfield-decoration-container in vertical writing-mode https://bugs.webkit.org/show_bug.cgi?id=248321 rdar://102652144 Reviewed by Cameron McCormack. min-width: 0; is set to avoid the inner (which has flex-grow: 1) from growing. We need the equivalent in vertical writing mode. * LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/forms/number-input-vertical-overflow-expected.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/forms/number-input-vertical-overflow-ref.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/forms/number-input-vertical-overflow.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/forms/text-input-vertical-overflow-no-scroll-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/forms/text-input-vertical-overflow-no-scroll.html: Added. * Source/WebCore/html/shadow/TextControlInnerElements.cpp: (WebCore::TextControlInnerElement::resolveCustomStyle): Canonical link: https://commits.webkit.org/257008@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] ca9f4e: [JSC] Remove already shipped feature flags
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: ca9f4e631e5eaf44ce22e1f5cc29519be9488825 https://github.com/WebKit/WebKit/commit/ca9f4e631e5eaf44ce22e1f5cc29519be9488825 Author: Yusuke Suzuki Date: 2022-11-24 (Thu, 24 Nov 2022) Changed paths: M JSTests/stress/at-method.js M JSTests/stress/change-array-by-copy.js M JSTests/stress/typed-array-change-by-copy.js M JSTests/stress/typedarray-findLast.js M JSTests/stress/typedarray-findLastIndex.js M JSTests/stress/unscopables.js M JSTests/test262/config.yaml M JSTests/wasm.yaml M LayoutTests/inspector/model/remote-object-get-properties.html M LayoutTests/js/Object-getOwnPropertyNames.html M LayoutTests/js/array-findLast.html M LayoutTests/js/array-findLastIndex.html M LayoutTests/js/array-unscopables-properties.html M LayoutTests/js/script-tests/array-findLast.js M LayoutTests/js/script-tests/array-findLastIndex.js M Source/JavaScriptCore/jsc.cpp M Source/JavaScriptCore/runtime/ArrayPrototype.cpp M Source/JavaScriptCore/runtime/IntlObject.cpp M Source/JavaScriptCore/runtime/JSTypedArrayViewPrototype.cpp M Source/JavaScriptCore/runtime/ObjectConstructor.cpp M Source/JavaScriptCore/runtime/OptionsList.h M Source/JavaScriptCore/runtime/StringPrototype.cpp M Source/JavaScriptCore/wasm/WasmAirIRGenerator.cpp M Source/JavaScriptCore/wasm/WasmB3IRGenerator.cpp M Source/JavaScriptCore/wasm/WasmFunctionParser.h M Source/JavaScriptCore/wasm/WasmSectionParser.cpp Log Message: --- [JSC] Remove already shipped feature flags https://bugs.webkit.org/show_bug.cgi?id=248326 rdar://102654031 Reviewed by Ross Kirsling. This patch removes already shipped feature flags in JSC to clean up. * JSTests/stress/at-method.js: * JSTests/stress/change-array-by-copy.js: * JSTests/stress/typed-array-change-by-copy.js: * JSTests/stress/typedarray-findLast.js: * JSTests/stress/typedarray-findLastIndex.js: * JSTests/stress/unscopables.js: * JSTests/test262/config.yaml: * JSTests/wasm.yaml: * LayoutTests/inspector/model/remote-object-get-properties.html: * LayoutTests/js/Object-getOwnPropertyNames.html: * LayoutTests/js/array-findLast.html: * LayoutTests/js/array-findLastIndex.html: * LayoutTests/js/array-unscopables-properties.html: * LayoutTests/js/script-tests/array-findLast.js: * LayoutTests/js/script-tests/array-findLastIndex.js: * Source/JavaScriptCore/jsc.cpp: (CommandLine::parseArguments): * Source/JavaScriptCore/runtime/ArrayPrototype.cpp: (JSC::ArrayPrototype::finishCreation): * Source/JavaScriptCore/runtime/IntlObject.cpp: (JSC::IntlObject::finishCreation): * Source/JavaScriptCore/runtime/JSTypedArrayViewPrototype.cpp: (JSC::JSTypedArrayViewPrototype::finishCreation): * Source/JavaScriptCore/runtime/ObjectConstructor.cpp: (JSC::ObjectConstructor::finishCreation): * Source/JavaScriptCore/runtime/OptionsList.h: * Source/JavaScriptCore/runtime/StringPrototype.cpp: (JSC::StringPrototype::finishCreation): * Source/JavaScriptCore/wasm/WasmAirIRGenerator.cpp: (JSC::Wasm::AirIRGenerator::addIf): (JSC::Wasm::AirIRGenerator::addBranch): * Source/JavaScriptCore/wasm/WasmB3IRGenerator.cpp: (JSC::Wasm::B3IRGenerator::addIf): (JSC::Wasm::B3IRGenerator::addBranch): * Source/JavaScriptCore/wasm/WasmFunctionParser.h: (JSC::Wasm::FunctionParser::parseExpression): (JSC::Wasm::FunctionParser::parseUnreachableExpression): * Source/JavaScriptCore/wasm/WasmSectionParser.cpp: (JSC::Wasm::SectionParser::parseImport): (JSC::Wasm::SectionParser::parseExport): (JSC::Wasm::SectionParser::parseException): (JSC::Wasm::SectionParser::parseCustom): Canonical link: https://commits.webkit.org/257007@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 32c8e0: Resync web-platform-tests/geolocation-API from ups...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 32c8e0f399e0afaac3f4e52527c116306d7b4f5d https://github.com/WebKit/WebKit/commit/32c8e0f399e0afaac3f4e52527c116306d7b4f5d Author: Marcos Caceres Date: 2022-11-24 (Thu, 24 Nov 2022) Changed paths: M LayoutTests/imported/w3c/web-platform-tests/geolocation-API/META.yml M LayoutTests/imported/w3c/web-platform-tests/geolocation-API/PositionOptions.https-expected.txt M LayoutTests/imported/w3c/web-platform-tests/geolocation-API/PositionOptions.https.html R LayoutTests/imported/w3c/web-platform-tests/geolocation-API/clearWatch_TypeError.html A LayoutTests/imported/w3c/web-platform-tests/geolocation-API/clearWatch_TypeError.https-expected.txt A LayoutTests/imported/w3c/web-platform-tests/geolocation-API/clearWatch_TypeError.https.html A LayoutTests/imported/w3c/web-platform-tests/geolocation-API/disabled-by-feature-policy.https.sub-expected.txt A LayoutTests/imported/w3c/web-platform-tests/geolocation-API/disabled-by-feature-policy.https.sub.html A LayoutTests/imported/w3c/web-platform-tests/geolocation-API/disabled-by-feature-policy.https.sub.html.headers A LayoutTests/imported/w3c/web-platform-tests/geolocation-API/enabled-by-feature-policy-attribute-redirect-on-load.https.sub-expected.txt A LayoutTests/imported/w3c/web-platform-tests/geolocation-API/enabled-by-feature-policy-attribute-redirect-on-load.https.sub.html A LayoutTests/imported/w3c/web-platform-tests/geolocation-API/enabled-by-feature-policy-attribute.https.sub-expected.txt A LayoutTests/imported/w3c/web-platform-tests/geolocation-API/enabled-by-feature-policy-attribute.https.sub.html A LayoutTests/imported/w3c/web-platform-tests/geolocation-API/enabled-by-feature-policy.https.sub-expected.txt A LayoutTests/imported/w3c/web-platform-tests/geolocation-API/enabled-by-feature-policy.https.sub.html A LayoutTests/imported/w3c/web-platform-tests/geolocation-API/enabled-by-feature-policy.https.sub.html.headers A LayoutTests/imported/w3c/web-platform-tests/geolocation-API/enabled-on-self-origin-by-feature-policy.https.sub-expected.txt A LayoutTests/imported/w3c/web-platform-tests/geolocation-API/enabled-on-self-origin-by-feature-policy.https.sub.html A LayoutTests/imported/w3c/web-platform-tests/geolocation-API/enabled-on-self-origin-by-feature-policy.https.sub.html.headers R LayoutTests/imported/w3c/web-platform-tests/geolocation-API/getCurrentPosition_IDL.https-expected.txt R LayoutTests/imported/w3c/web-platform-tests/geolocation-API/getCurrentPosition_IDL.https.html R LayoutTests/imported/w3c/web-platform-tests/geolocation-API/getCurrentPosition_TypeError.html A LayoutTests/imported/w3c/web-platform-tests/geolocation-API/getCurrentPosition_TypeError.https-expected.txt A LayoutTests/imported/w3c/web-platform-tests/geolocation-API/getCurrentPosition_TypeError.https.html M LayoutTests/imported/w3c/web-platform-tests/geolocation-API/getCurrentPosition_permission_allow.https.html M LayoutTests/imported/w3c/web-platform-tests/geolocation-API/getCurrentPosition_permission_deny.https.html M LayoutTests/imported/w3c/web-platform-tests/geolocation-API/idlharness.https.window-expected.txt M LayoutTests/imported/w3c/web-platform-tests/geolocation-API/idlharness.https.window.js M LayoutTests/imported/w3c/web-platform-tests/geolocation-API/non-fully-active.https.html A LayoutTests/imported/w3c/web-platform-tests/geolocation-API/permission.https-expected.txt A LayoutTests/imported/w3c/web-platform-tests/geolocation-API/permission.https.html A LayoutTests/imported/w3c/web-platform-tests/geolocation-API/resources/w3c-import.log M LayoutTests/imported/w3c/web-platform-tests/geolocation-API/support.js M LayoutTests/imported/w3c/web-platform-tests/geolocation-API/w3c-import.log R LayoutTests/imported/w3c/web-platform-tests/geolocation-API/watchPosition_TypeError.html A LayoutTests/imported/w3c/web-platform-tests/geolocation-API/watchPosition_TypeError.https-expected.txt A LayoutTests/imported/w3c/web-platform-tests/geolocation-API/watchPosition_TypeError.https.html M LayoutTests/imported/w3c/web-platform-tests/geolocation-API/watchPosition_permission_deny.https.html R LayoutTests/imported/w3c/web-platform-tests/interfaces/geolocation-API.idl A LayoutTests/imported/w3c/web-platform-tests/interfaces/geolocation.idl Log Message: --- Resync web-platform-tests/geolocation-API from upstream https://bugs.webkit.org/show_bug.cgi?id=248294 rdar://102634893 Syncs to 584cd49 Reviewed by Tim Nguyen. * LayoutTests/imported/w3c/web-platform-tests/geolocation-API/META.yml: * LayoutTests/imported/w3c/web-platform-tests/geolocation-API/PositionOptions.https-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/geolocation-API/PositionOptions.https.html: *
[webkit-changes] [WebKit/WebKit] 1940a7: [JSC] Enable resizable ArrayBuffer
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 1940a7d26a1a4de6a6e3af0aadd0042451667367 https://github.com/WebKit/WebKit/commit/1940a7d26a1a4de6a6e3af0aadd0042451667367 Author: Yusuke Suzuki Date: 2022-11-24 (Thu, 24 Nov 2022) Changed paths: M JSTests/ChakraCore/test/typedarray/arraybufferType.baseline-jsc M LayoutTests/inspector/model/remote-object/object-expected.txt M Source/JavaScriptCore/runtime/OptionsList.h Log Message: --- [JSC] Enable resizable ArrayBuffer https://bugs.webkit.org/show_bug.cgi?id=248324 rdar://102653781 Reviewed by Ross Kirsling. Enable resizable ArrayBuffer as we implement all features and JIT optimizations. * Source/JavaScriptCore/runtime/OptionsList.h: Canonical link: https://commits.webkit.org/257005@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 23879e: Ignored TypeError upon optional function call chain
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 23879e6bd1a0b8a5ee2718d9faa5d66514134218 https://github.com/WebKit/WebKit/commit/23879e6bd1a0b8a5ee2718d9faa5d66514134218 Author: Ross Kirsling Date: 2022-11-24 (Thu, 24 Nov 2022) Changed paths: M JSTests/stress/optional-chaining.js M Source/JavaScriptCore/bytecompiler/NodesCodegen.cpp M Source/JavaScriptCore/parser/ASTBuilder.h M Source/JavaScriptCore/parser/NodeConstructors.h M Source/JavaScriptCore/parser/Nodes.h M Source/JavaScriptCore/parser/Parser.cpp Log Message: --- Ignored TypeError upon optional function call chain https://bugs.webkit.org/show_bug.cgi?id=247431 Reviewed by Yusuke Suzuki. Evidently, our implementation of optional chaining has always interpreted `a.b?.().c` and `a.b()?.c` as `a.b?.()?.c`. (Hard to believe, but I guess giving more undefineds and less TypeErrors must not have troubled folks that much...) The issue is rather JSC-specific, in that it's a confused result of our "function call node menagerie" -- ExpressionNode::isOptionalChainBase was repurposed for optional calls like `x?.()`, but that failed to recognize that the result of a call can also be the base of an optional chain, as in `x()?.y`. This patch adds ExpressionNode::isOptionalCall and distinguishes optional call as a separate concept throughout. * JSTests/stress/optional-chaining.js: (shouldThrowTypeError): * Source/JavaScriptCore/bytecompiler/NodesCodegen.cpp: (JSC::EvalFunctionCallNode::emitBytecode): (JSC::FunctionCallValueNode::emitBytecode): (JSC::FunctionCallResolveNode::emitBytecode): (JSC::FunctionCallBracketNode::emitBytecode): (JSC::FunctionCallDotNode::emitBytecode): (JSC::CallFunctionCallDotNode::emitBytecode): (JSC::HasOwnPropertyFunctionCallDotNode::emitBytecode): (JSC::ApplyFunctionCallDotNode::emitBytecode): * Source/JavaScriptCore/parser/ASTBuilder.h: (JSC::ASTBuilder::createOptionalChain): (JSC::ASTBuilder::makeFunctionCallNode): * Source/JavaScriptCore/parser/NodeConstructors.h: (JSC::FunctionCallValueNode::FunctionCallValueNode): (JSC::FunctionCallResolveNode::FunctionCallResolveNode): (JSC::FunctionCallBracketNode::FunctionCallBracketNode): (JSC::FunctionCallDotNode::FunctionCallDotNode): (JSC::CallFunctionCallDotNode::CallFunctionCallDotNode): (JSC::ApplyFunctionCallDotNode::ApplyFunctionCallDotNode): (JSC::HasOwnPropertyFunctionCallDotNode::HasOwnPropertyFunctionCallDotNode): * Source/JavaScriptCore/parser/Nodes.h: (JSC::ExpressionNode::isOptionalCall const): * Source/JavaScriptCore/parser/Parser.cpp: (JSC::Parser::parseMemberExpression): Canonical link: https://commits.webkit.org/257004@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 920620: [Curl] Remove unused SSL error information
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 920620a700243425d43b663fdfbe177a692eb897 https://github.com/WebKit/WebKit/commit/920620a700243425d43b663fdfbe177a692eb897 Author: Kenji Shukuwa Date: 2022-11-24 (Thu, 24 Nov 2022) Changed paths: M Source/WebCore/platform/network/curl/CurlContext.cpp M Source/WebCore/platform/network/curl/CurlContext.h M Source/WebCore/platform/network/curl/CurlRequest.cpp M Source/WebCore/platform/network/curl/CurlSSLVerifier.cpp M Source/WebCore/platform/network/curl/CurlSSLVerifier.h M Source/WebCore/platform/network/curl/ResourceError.h M Source/WebCore/platform/network/curl/ResourceErrorCurl.cpp M Source/WebKit/Shared/curl/WebCoreArgumentCodersCurl.cpp Log Message: --- [Curl] Remove unused SSL error information https://bugs.webkit.org/show_bug.cgi?id=248329 Reviewed by Fujii Hironori. ResourceError::sslErrors is not being used. So we will remove these related code. * Source/WebCore/platform/network/curl/CurlContext.cpp: (WebCore::CurlHandle::sslErrors const): Deleted. * Source/WebCore/platform/network/curl/CurlContext.h: * Source/WebCore/platform/network/curl/CurlRequest.cpp: (WebCore::CurlRequest::didCompleteTransfer): * Source/WebCore/platform/network/curl/CurlSSLVerifier.cpp: (WebCore::CurlSSLVerifier::convertToSSLCertificateFlags): Deleted. * Source/WebCore/platform/network/curl/CurlSSLVerifier.h: * Source/WebCore/platform/network/curl/ResourceError.h: (WebCore::ResourceError::sslErrors const): Deleted. (WebCore::ResourceError::setSslErrors): Deleted. (): Deleted. * Source/WebCore/platform/network/curl/ResourceErrorCurl.cpp: (WebCore::ResourceError::doPlatformIsolatedCopy): (WebCore::ResourceError::platformCompare): (WebCore::ResourceError::sslError): Deleted. * Source/WebKit/Shared/curl/WebCoreArgumentCodersCurl.cpp: (IPC::ArgumentCoder::encodePlatformData): (IPC::ArgumentCoder::decodePlatformData): Canonical link: https://commits.webkit.org/257003@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 7275c7: Slider thumb is wrongly placed in vertical writing...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 7275c7c8b394ea3e97330b45887428e5331f8414 https://github.com/WebKit/WebKit/commit/7275c7c8b394ea3e97330b45887428e5331f8414 Author: Tim Nguyen Date: 2022-11-24 (Thu, 24 Nov 2022) Changed paths: A LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/forms/range-input-painting-ref.html A LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/forms/range-input-vertical-ltr-painting-expected.html A LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/forms/range-input-vertical-ltr-painting.html A LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/forms/range-input-vertical-rtl-painting-expected.html A LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/forms/range-input-vertical-rtl-painting.html M Source/WebCore/html/shadow/SliderThumbElement.cpp Log Message: --- Slider thumb is wrongly placed in vertical writing-mode + RTL https://bugs.webkit.org/show_bug.cgi?id=248320 rdar://102652014 Reviewed by Cameron McCormack. thumb->setLocation() uses logical coordinates, so we can't share the same path with appearance: slider-vertical, otherwise we end up placing the thumb outside of the track. Add reftests that check that we don't paint anything outside the bounds of the input. * LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/forms/range-input-painting-ref.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/forms/range-input-vertical-ltr-painting-expected.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/forms/range-input-vertical-ltr-painting.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/forms/range-input-vertical-rtl-painting-expected.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/forms/range-input-vertical-rtl-painting.html: Added. * Source/WebCore/html/shadow/SliderThumbElement.cpp: (WebCore::RenderSliderContainer::layout): Canonical link: https://commits.webkit.org/257002@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 1a5636: [JSC] Add JIT optimizations for ResizableArrayBuffers
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 1a5636acd02ea65e4795ca8d19fae088e413 https://github.com/WebKit/WebKit/commit/1a5636acd02ea65e4795ca8d19fae088e413 Author: Yusuke Suzuki Date: 2022-11-24 (Thu, 24 Nov 2022) Changed paths: A JSTests/microbenchmarks/emscripten-cube2hash-resizable.js A JSTests/stress/resizable-bytelength.js A JSTests/stress/resizable-byteoffset.js A JSTests/stress/resizable-length.js M Source/JavaScriptCore/assembler/MacroAssemblerARM64.h M Source/JavaScriptCore/assembler/MacroAssemblerRISCV64.h M Source/JavaScriptCore/assembler/MacroAssemblerX86Common.h M Source/JavaScriptCore/assembler/MacroAssemblerX86_64.h M Source/JavaScriptCore/bytecode/AccessCase.cpp M Source/JavaScriptCore/bytecode/AccessCase.h M Source/JavaScriptCore/bytecode/IntrinsicGetterAccessCase.h M Source/JavaScriptCore/bytecode/PolymorphicAccess.cpp M Source/JavaScriptCore/bytecode/Repatch.cpp M Source/JavaScriptCore/dfg/DFGArrayMode.cpp M Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp M Source/JavaScriptCore/dfg/DFGClobberize.h M Source/JavaScriptCore/dfg/DFGNode.h M Source/JavaScriptCore/dfg/DFGOSRExit.cpp M Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp M Source/JavaScriptCore/dfg/DFGSpeculativeJIT.h M Source/JavaScriptCore/dfg/DFGSpeculativeJIT64.cpp M Source/JavaScriptCore/ftl/FTLLowerDFGToB3.cpp M Source/JavaScriptCore/jit/AssemblyHelpers.cpp M Source/JavaScriptCore/jit/AssemblyHelpers.h M Source/JavaScriptCore/jit/IntrinsicEmitter.cpp M Source/JavaScriptCore/runtime/ArrayBuffer.h M Source/JavaScriptCore/runtime/JSDataView.h M Source/JavaScriptCore/runtime/TypedArrayType.cpp M Source/JavaScriptCore/runtime/TypedArrayType.h Log Message: --- [JSC] Add JIT optimizations for ResizableArrayBuffers https://bugs.webkit.org/show_bug.cgi?id=248206 rdar://problem/102597308 Reviewed by Ross Kirsling. This patch adds JIT optimizations for resizable ArrayBuffer. Right now, our generated code is not so tightly optimized (in terms of code size in particular), but still it offers large improvement already, so this is great step as a first implementation. 1. We add JIT getter optimizations for TypedArray intrinsic getters. They are implemented in IntrinsicEmitter. 2. We add JIT AccesssCase optimizations for resizable TypedArrays. IC can detect resizable TypedArrays, and generate IndexedResizableTypedArray* ICes. We do not extend existing TypedArray IC to handle resizable TypedArrays since we would like to keep existing ICes super tightly optimized. We should generate this IC handling resizable TypedArrays gracefully only when we found resizable TypedArrays. 3. We annotate ArrayProfile based on profiling and DFG OSR exit so that we can know resizable TypedArrays in DFG / FTL. Based on that, we optimize DFG / FTL nodes handling TypedArrays. When we didn't observe resizable TypedArrays, we make resizable TypedArrays OSR exit to make node super tightly optimized and avoid saying pessimized clobbering information. 4. We implement DFG / FTL nodes handling resizable TypedArrays. We use (1) and (2)'s JIT code generation to implement them. Ideally, we can do more optimized thing in FTL by generating B3 nodes for this instead of using patchpoint. But currently B3 lacks AtomicLoad nodes, so we first just use patchpoint to implement FTL optimization. This patch improved emscripten-cube2hash-resizable benchmark by 2x. ToT Patched emscripten-cube2hash-resizable 19.1501+-0.0248 ^ 9.1659+-0.0471 ^ definitely 2.0893x faster * JSTests/microbenchmarks/emscripten-cube2hash-resizable.js: Added. (key.in.Module.Module.hasOwnProperty): (ENVIRONMENT_IS_NODE.Module.string_appeared_here): (else.Module.string_appeared_here): (else.else.Module.string_appeared_here): (else): (else.else): (globalEval): (Module.string_appeared_here.string_appeared_here.Module.string_appeared_here.Module.string_appeared_here): (Module.string_appeared_here.Module.string_appeared_here): (key.in.moduleOverrides.moduleOverrides.hasOwnProperty): (Runtime.stackSave): (Runtime.stackRestore): (Runtime.forceAlign): (Runtime.isNumberType): (Runtime.isPointerType): (Runtime.isStructType): * JSTests/stress/resizable-bytelength.js: Added. (shouldBe): (test): * JSTests/stress/resizable-byteoffset.js: Added. (shouldBe): (test): * JSTests/stress/resizable-length.js: Added. (shouldBe): (test): * Source/JavaScriptCore/assembler/MacroAssemblerARM64.h: (JSC::MacroAssemblerARM64::lshift32): (JSC::MacroAssemblerARM64::lshift64): (JSC::MacroAssemblerARM64::loadAcq32): (JSC::MacroAssemblerARM64::loadAcq64): (JSC::MacroAssemblerARM64::atomicLoad32): (JSC::MacroAssemblerARM64::atomicLoad64): * Source/JavaScriptCore/assembler/MacroAssemblerRISCV64.h: (JSC::MacroAssemblerRISCV64::lshift32):
[webkit-changes] [WebKit/WebKit] ada505: [IFC][Integration][Line clamp] Enable simple sibli...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: ada505e4c4e114005109d406c2a3f650e3e9a722 https://github.com/WebKit/WebKit/commit/ada505e4c4e114005109d406c2a3f650e3e9a722 Author: Alan Baradlay Date: 2022-11-24 (Thu, 24 Nov 2022) Changed paths: M LayoutTests/imported/w3c/web-platform-tests/css/css-flexbox/alignment/flex-align-baseline-line-clamp-001.tentative-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/css-grid/alignment/grid-align-baseline-line-clamp-001.tentative-expected.txt M Source/WebCore/layout/integration/LayoutIntegrationCoverage.cpp Log Message: --- [IFC][Integration][Line clamp] Enable simple sibling flex items for IFC https://bugs.webkit.org/show_bug.cgi?id=248298 Reviewed by Antti Koivisto. This patch enables cases when deprecated flex box has multiple flex items. This is slight change in functionality where sibling flex content would not overflow (FF and Chrome behavior). * Source/WebCore/layout/integration/LayoutIntegrationCoverage.cpp: (WebCore::LayoutIntegration::canUseForStyle): Canonical link: https://commits.webkit.org/257000@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 80bf5c: Reduce memory usage when sending SharedBuffer acro...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 80bf5c2acfbc545488d962f3f4a316b0a5c73119 https://github.com/WebKit/WebKit/commit/80bf5c2acfbc545488d962f3f4a316b0a5c73119 Author: Jean-Yves Avenard Date: 2022-11-24 (Thu, 24 Nov 2022) Changed paths: M Source/WebKit/Shared/WebCoreArgumentCoders.cpp M Source/WebKit/UIProcess/WebURLSchemeTask.cpp M Source/WebKit/UIProcess/WebURLSchemeTask.h M Source/WebKit/WebProcess/WebPage/WebPage.cpp M Source/WebKit/WebProcess/WebPage/WebPage.h M Source/WebKit/WebProcess/WebPage/WebPage.messages.in M Source/WebKit/WebProcess/WebPage/WebURLSchemeHandlerProxy.cpp M Source/WebKit/WebProcess/WebPage/WebURLSchemeHandlerProxy.h Log Message: --- Reduce memory usage when sending SharedBuffer across IPC https://bugs.webkit.org/show_bug.cgi?id=248301 rdar://102201837 Pack small SharedBuffers across a single allocated SharedMemory. A threshold of 4kB has been chosen through educated guesses. Have URLSchemeTaskDidReceiveData use SharedBuffer when sending data to the content process rather than a SharedBufferReference. The primary use of a SharedBufferReference is to keep ownership of the allocated memory to the sending process. There's no such requirement here. Fly-by improvement, only perform a single memory allocation when passing a FragmentedShared made of multiple segments on GTK and WPE platfom. Reviewed by Kimmo Kinnunen. * Source/WebKit/Shared/WebCoreArgumentCoders.cpp: (IPC::useUnixDomainSockets): (IPC::ArgumentCoder::encode): (IPC::ArgumentCoder::decode): * Source/WebKit/UIProcess/WebURLSchemeTask.cpp: (WebKit::WebURLSchemeTask::didReceiveData): * Source/WebKit/UIProcess/WebURLSchemeTask.h: * Source/WebKit/WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::urlSchemeTaskDidReceiveData): * Source/WebKit/WebProcess/WebPage/WebPage.h: * Source/WebKit/WebProcess/WebPage/WebPage.messages.in: * Source/WebKit/WebProcess/WebPage/WebURLSchemeHandlerProxy.cpp: (WebKit::WebURLSchemeHandlerProxy::taskDidReceiveData): * Source/WebKit/WebProcess/WebPage/WebURLSchemeHandlerProxy.h: Canonical link: https://commits.webkit.org/256999@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] a9510a: Serialize and deserialize resizable ArrayBuffer
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: a9510aedf5179f92aa036b67aea7f5f9e8b0a24f https://github.com/WebKit/WebKit/commit/a9510aedf5179f92aa036b67aea7f5f9e8b0a24f Author: Yusuke Suzuki Date: 2022-11-24 (Thu, 24 Nov 2022) Changed paths: A LayoutTests/js/dom/resizable-array-buffer-serialization-expected.txt A LayoutTests/js/dom/resizable-array-buffer-serialization.html A LayoutTests/js/dom/resizable-array-buffer-view-serialization-expected.txt A LayoutTests/js/dom/resizable-array-buffer-view-serialization-out-of-bounds-expected.txt A LayoutTests/js/dom/resizable-array-buffer-view-serialization-out-of-bounds-explicit-length-expected.txt A LayoutTests/js/dom/resizable-array-buffer-view-serialization-out-of-bounds-explicit-length.html A LayoutTests/js/dom/resizable-array-buffer-view-serialization-out-of-bounds.html A LayoutTests/js/dom/resizable-array-buffer-view-serialization.html A LayoutTests/workers/sab/growable-shared-array-buffer-serialization-expected.txt A LayoutTests/workers/sab/growable-shared-array-buffer-serialization.html A LayoutTests/workers/sab/growable-shared-array-buffer-view-serialization-expected.txt A LayoutTests/workers/sab/growable-shared-array-buffer-view-serialization-explicit-length-expected.txt A LayoutTests/workers/sab/growable-shared-array-buffer-view-serialization-explicit-length.html A LayoutTests/workers/sab/growable-shared-array-buffer-view-serialization.html A LayoutTests/workers/sab/postMessage-clones-growable-expected.txt A LayoutTests/workers/sab/postMessage-clones-growable.html M Source/JavaScriptCore/runtime/ArrayBufferView.cpp M Source/JavaScriptCore/runtime/ArrayBufferView.h M Source/JavaScriptCore/runtime/DataView.cpp M Source/JavaScriptCore/runtime/DataView.h M Source/JavaScriptCore/runtime/GenericTypedArrayView.h M Source/JavaScriptCore/runtime/GenericTypedArrayViewInlines.h M Source/JavaScriptCore/runtime/JSArrayBufferView.cpp M Source/JavaScriptCore/runtime/JSDataView.cpp M Source/JavaScriptCore/runtime/JSGenericTypedArrayViewInlines.h M Source/WebCore/bindings/js/SerializedScriptValue.cpp M Source/WebCore/bindings/js/StructuredClone.cpp Log Message: --- Serialize and deserialize resizable ArrayBuffer https://bugs.webkit.org/show_bug.cgi?id=248209 rdar://102601423 Reviewed by Ross Kirsling. This patch adds serializing and deserializing of resizable ArrayBuffer and TypedArrays. We add ResizableArrayBufferTag and add a feature serializing resizable ArrayBuffer. But for growable SharedArrayBuffer, nothing is necessary since information is carried via SharedArrayBufferContents already. For TypedArrays, we use UINT64_MAX byteLength marker as a auto-length case. This works since byteLength cannot be UINT64_MAX since it exceeds MAX_ARRAY_BUFFER_SIZE. The other things in TypedArrays are not changed much since these TypedArrays should be resizable / growable ones when the subsequent backing serialized ArrayBuffer is resizable. We also add wrappedAs methods since normal tryCreate has more additional checks for construction. But these checks can fail if the serialized TypedArrays are having ArrayBuffers which is resized to be smaller after the construction. But this is OK since it just makes TypedArrays OOB. wrappedAs methods do not have this check. * Source/JavaScriptCore/runtime/ArrayBufferView.h: (JSC::ArrayBufferView::byteOffsetRaw const): (JSC::ArrayBufferView::byteOffset const): (JSC::ArrayBufferView::byteLengthRaw const): (JSC::ArrayBufferView::byteLength const): * Source/WebCore/bindings/js/SerializedScriptValue.cpp: (WebCore::CloneSerializer::dumpArrayBufferView): (WebCore::CloneSerializer::dumpIfTerminal): (WebCore::CloneDeserializer::readResizableNonSharedArrayBuffer): (WebCore::CloneDeserializer::readArrayBufferViewImpl): (WebCore::CloneDeserializer::readTerminal): Canonical link: https://commits.webkit.org/256998@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] da5d5f: [web-animations] do not account for progress for a...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: da5d5fadcc4463a124d96c9a1b2686df3d09486b https://github.com/WebKit/WebKit/commit/da5d5fadcc4463a124d96c9a1b2686df3d09486b Author: Antoine Quint Date: 2022-11-24 (Thu, 24 Nov 2022) Changed paths: M Source/WebCore/platform/graphics/transforms/TransformationMatrix.cpp Log Message: --- [web-animations] do not account for progress for additivity and accumulation interpolation for transforms https://bugs.webkit.org/show_bug.cgi?id=248313 Reviewed by Antti Koivisto. The progress is always 1 when blending with additivity or accumulation, so instead of using it to multiply we can simply ASSERT() and remove the multiplication, which allows us to simplify the additions. * Source/WebCore/platform/graphics/transforms/TransformationMatrix.cpp: (WebCore::blendFloat): Canonical link: https://commits.webkit.org/256997@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 71e209: [web-animations] correctly blend transform with it...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 71e209c557898b92a216b8206bae5a86e1234830 https://github.com/WebKit/WebKit/commit/71e209c557898b92a216b8206bae5a86e1234830 Author: Antoine Quint Date: 2022-11-24 (Thu, 24 Nov 2022) Changed paths: M LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/keyframe-effects/effect-value-iteration-composite-operation-expected.txt M Source/WebCore/animation/CSSPropertyAnimation.cpp Log Message: --- [web-animations] correctly blend transform with iterationComposite is set to "accumulate" https://bugs.webkit.org/show_bug.cgi?id=248312 Reviewed by Antti Koivisto. When animating transform, we pre-compute the number of matching transform operations. However, in the case of `iterationComposite` we end up blending the "to" value with itself multiple times with an accumulation composite operation (per https://drafts.csswg.org/web-animations-2/#the-effect-value-of-a-keyframe-animation-effect). Indeed, when computing the final keyframe, we accumulate the end keyframe onto itself to match the current iteration interval. In that case, since we're blending the same value with itself, the pre-computed matching prefix is incorrect, so we use std::nullopt instead to indicate that the operations fully match. * LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/keyframe-effects/effect-value-iteration-composite-operation-expected.txt: * Source/WebCore/animation/CSSPropertyAnimation.cpp: (WebCore::blendFunc): Canonical link: https://commits.webkit.org/256996@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 403592: Fix date-time inputs in vertical writing mode and ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 40359210a8f97059de9443f7bffbd2e6595206da https://github.com/WebKit/WebKit/commit/40359210a8f97059de9443f7bffbd2e6595206da Author: Tim Nguyen Date: 2022-11-24 (Thu, 24 Nov 2022) Changed paths: M LayoutTests/fast/css/text-overflow-ellipsis-and-floating-input-hittest.html M LayoutTests/imported/w3c/web-platform-tests/css/css-flexbox/flex-item-compressible-002-expected.txt A LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/forms/text-input-block-size.optional-expected.txt A LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/forms/text-input-block-size.optional.html A LayoutTests/platform/ios/imported/w3c/web-platform-tests/css/css-writing-modes/forms/progress-appearance-native-computed-style.optional-expected.txt M Source/WebCore/css/horizontalFormControls.css M Source/WebCore/css/html.css M Source/WebCore/html/shadow/DateTimeFieldElement.cpp M Source/WebCore/html/shadow/DateTimeFieldElement.h M Source/WebCore/html/shadow/DateTimeNumericFieldElement.cpp M Source/WebCore/html/shadow/DateTimeNumericFieldElement.h M Source/WebCore/html/shadow/DateTimeSymbolicFieldElement.cpp M Source/WebCore/html/shadow/DateTimeSymbolicFieldElement.h Log Message: --- Fix date-time inputs in vertical writing mode and enable all text-based inputs https://bugs.webkit.org/show_bug.cgi?id=248302 rdar://102642911 Reviewed by Antti Koivisto. Text-based inputs in vertical writing mode are mainly a rotated version of the horizontal one. However, inner elements of date-time inputs were setting a min-width, which wrongly increased the opposite dimension in vertical writing mode making it inconsistent with the height in horizontal mode. Fix this by setting the min-inline-size (consistent with CSS terminology), which is writing-mode aware. Also enable vertical text-based inputs behind the VerticalFormControlsEnabled flag, they are working mostly fine aside from these issues, which will be addressed later: - positioning bugs in inputs with decorations (search, number, autofill, etc.) - native search input (not unstyled) is not rendered properly - text input border should be rendered rotated * LayoutTests/fast/css/text-overflow-ellipsis-and-floating-input-hittest.html: * LayoutTests/imported/w3c/web-platform-tests/css/css-flexbox/flex-item-compressible-002-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/forms/text-input-block-size.optional-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/forms/text-input-block-size.optional.html: Added. * LayoutTests/platform/ios/imported/w3c/web-platform-tests/css/css-writing-modes/forms/progress-appearance-native-computed-style.optional-expected.txt: Added. * Source/WebCore/css/horizontalFormControls.css: (@namespace "http://www.w3.org/1999/xhtml;;): * Source/WebCore/css/html.css: (select, button, meter, progress, input:is([type="button"], [type="submit"], [type="reset"], [type="file"])): (input:not([type="color"]), select, button, meter, progress): Deleted. * Source/WebCore/html/shadow/DateTimeFieldElement.cpp: (WebCore::DateTimeFieldElement::resolveCustomStyle): * Source/WebCore/html/shadow/DateTimeFieldElement.h: * Source/WebCore/html/shadow/DateTimeNumericFieldElement.cpp: (WebCore::DateTimeNumericFieldElement::adjustMinInlineSize const): (WebCore::DateTimeNumericFieldElement::adjustMinWidth const): Deleted. * Source/WebCore/html/shadow/DateTimeNumericFieldElement.h: * Source/WebCore/html/shadow/DateTimeSymbolicFieldElement.cpp: (WebCore::DateTimeSymbolicFieldElement::adjustMinInlineSize const): (WebCore::DateTimeSymbolicFieldElement::adjustMinWidth const): Deleted. * Source/WebCore/html/shadow/DateTimeSymbolicFieldElement.h: Canonical link: https://commits.webkit.org/256995@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 7abec1: Support `input[type="range"]` in vertical writing ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 7abec143ddb94dfa96545e67979834d16b52a16b https://github.com/WebKit/WebKit/commit/7abec143ddb94dfa96545e67979834d16b52a16b Author: Tim Nguyen Date: 2022-11-24 (Thu, 24 Nov 2022) Changed paths: M LayoutTests/TestExpectations M LayoutTests/fast/multicol/client-rects-spanners-complex.html M LayoutTests/fast/multicol/client-rects-spanners.html M LayoutTests/imported/w3c/web-platform-tests/css/css-flexbox/flex-item-compressible-002-expected.txt A LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/forms/range-input-appearance-native-horizontal-rtl.optional-expected-mismatch.html A LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/forms/range-input-appearance-native-horizontal-rtl.optional.html A LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/forms/range-input-appearance-native-horizontal.optional-expected-mismatch.html A LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/forms/range-input-appearance-native-horizontal.optional.html A LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/forms/range-input-appearance-native-vertical-rtl.optional-expected-mismatch.html A LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/forms/range-input-appearance-native-vertical-rtl.optional.html A LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/forms/range-input-appearance-native-vertical.optional-expected-mismatch.html A LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/forms/range-input-appearance-native-vertical.optional.html A LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/forms/range-input-appearance-none-horizontal-rtl.optional-expected-mismatch.html A LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/forms/range-input-appearance-none-horizontal-rtl.optional.html A LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/forms/range-input-appearance-none-horizontal.optional-expected-mismatch.html A LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/forms/range-input-appearance-none-horizontal.optional.html A LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/forms/range-input-appearance-none-vertical-rtl.optional-expected-mismatch.html A LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/forms/range-input-appearance-none-vertical-rtl.optional.html A LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/forms/range-input-appearance-none-vertical.optional-expected-mismatch.html A LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/forms/range-input-appearance-none-vertical.optional.html A LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/forms/select-multiple-appearance-native-horizontal.optional-expected-mismatch.html A LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/forms/select-multiple-appearance-native-horizontal.optional.html A LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/forms/select-multiple-appearance-native-vlr.optional-expected-mismatch.html A LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/forms/select-multiple-appearance-native-vlr.optional.html A LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/forms/select-multiple-appearance-native-vrl.optional-expected-mismatch.html A LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/forms/select-multiple-appearance-native-vrl.optional.html A LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/forms/select-multiple-appearance-none-horizontal.optional-expected-mismatch.html A LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/forms/select-multiple-appearance-none-horizontal.optional.html A LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/forms/select-multiple-appearance-none-vlr.optional-expected-mismatch.html A LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/forms/select-multiple-appearance-none-vlr.optional.html A LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/forms/select-multiple-appearance-none-vrl.optional-expected-mismatch.html A LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/forms/select-multiple-appearance-none-vrl.optional.html A LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/forms/select-multiple-scrolling.optional-expected.txt A LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/forms/select-multiple-scrolling.optional.html A LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/forms/select-size-scrolling-and-sizing.optional-expected.txt A
[webkit-changes] [WebKit/WebKit] ba11d6: [MQ4] Use new parser and evaluator for responsive ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: ba11d60c7b4cf1dd2641b482d8061777ac146e53 https://github.com/WebKit/WebKit/commit/ba11d60c7b4cf1dd2641b482d8061777ac146e53 Author: Antti Koivisto Date: 2022-11-24 (Thu, 24 Nov 2022) Changed paths: M LayoutTests/TestExpectations M LayoutTests/fast/dom/HTMLImageElement/sizes/image-sizes-w3c-1-expected.txt M LayoutTests/fast/dom/HTMLImageElement/sizes/image-sizes-w3c-2-expected.txt M LayoutTests/fast/dom/HTMLImageElement/sizes/image-sizes-w3c-3-expected.txt M LayoutTests/fast/dom/HTMLImageElement/sizes/image-sizes-w3c-4-expected.txt M LayoutTests/platform/ios/fast/dom/HTMLImageElement/sizes/image-sizes-w3c-1-expected.txt M LayoutTests/platform/ios/fast/dom/HTMLImageElement/sizes/image-sizes-w3c-2-expected.txt M LayoutTests/platform/ios/fast/dom/HTMLImageElement/sizes/image-sizes-w3c-3-expected.txt M LayoutTests/platform/ios/fast/dom/HTMLImageElement/sizes/image-sizes-w3c-4-expected.txt M Source/WebCore/css/parser/SizesAttributeParser.cpp M Source/WebCore/css/parser/SizesAttributeParser.h M Source/WebCore/css/query/GenericMediaQueryEvaluator.h M Source/WebCore/css/query/GenericMediaQueryParser.cpp M Source/WebCore/css/query/GenericMediaQueryTypes.h M Source/WebCore/css/query/MediaQuery.h M Source/WebCore/css/query/MediaQueryEvaluator.cpp M Source/WebCore/css/query/MediaQueryEvaluator.h M Source/WebCore/css/query/MediaQueryFeatures.cpp M Source/WebCore/css/query/MediaQueryFeatures.h M Source/WebCore/css/query/MediaQueryParser.cpp M Source/WebCore/css/query/MediaQueryParser.h M Source/WebCore/html/HTMLImageElement.cpp M Source/WebCore/html/HTMLImageElement.h M Source/WebCore/html/HTMLMediaElement.cpp M Source/WebCore/html/HTMLSourceElement.cpp M Source/WebCore/html/HTMLSourceElement.h Log Message: --- [MQ4] Use new parser and evaluator for responsive images https://bugs.webkit.org/show_bug.cgi?id=248236 Reviewed by Alan Baradlay. Handle and with the new code. * LayoutTests/fast/dom/HTMLImageElement/sizes/image-sizes-w3c-1-expected.txt: * LayoutTests/fast/dom/HTMLImageElement/sizes/image-sizes-w3c-2-expected.txt: * LayoutTests/fast/dom/HTMLImageElement/sizes/image-sizes-w3c-3-expected.txt: * LayoutTests/fast/dom/HTMLImageElement/sizes/image-sizes-w3c-4-expected.txt: Some progressions in these tests. The new FAILs match the current spec text and the behavior of either Chrome or Firefox (general enclosed handling). * Source/WebCore/css/parser/SizesAttributeParser.cpp: (WebCore::SizesAttributeParser::mediaConditionMatches): (WebCore::SizesAttributeParser::parse): * Source/WebCore/css/parser/SizesAttributeParser.h: (WebCore::SizesAttributeParser::dynamicMediaQueryResults const): (WebCore::SizesAttributeParser::dynamicMediaConditionResults const): Deleted. * Source/WebCore/css/query/GenericMediaQueryEvaluator.h: (WebCore::MQ::GenericMediaQueryEvaluator::evaluateCondition const): * Source/WebCore/css/query/GenericMediaQueryTypes.h: (WebCore::MQ::traverseFeatures): * Source/WebCore/css/query/MediaQuery.h: (WebCore::MQ::traverseFeatures): Add helper for traversing features. * Source/WebCore/css/query/MediaQueryEvaluator.cpp: (WebCore::MQ::MediaQueryEvaluator::evaluate const): Fix Unknown logic. (WebCore::MQ::MediaQueryEvaluator::evaluateMediaType const): Factor into a function. (WebCore::MQ::MediaQueryEvaluator::collectDynamicDependencies const): Find out the dynamic dependencies. * Source/WebCore/css/query/MediaQueryEvaluator.h: * Source/WebCore/css/query/MediaQueryFeatures.cpp: (WebCore::MQ::Features::prefersReducedMotion): Fix a copy-pasta error. (WebCore::MQ::Features::dynamicDependency): Get dynamic dependencies of a feature schema. * Source/WebCore/css/query/MediaQueryFeatures.h: * Source/WebCore/css/query/MediaQueryParser.cpp: (WebCore::MQ::MediaQueryParser::parseCondition): Add a helper for parsing a single condition (as used in the 'sizes' attribute). * Source/WebCore/css/query/MediaQueryParser.h: * Source/WebCore/html/HTMLImageElement.cpp: (WebCore::HTMLImageElement::bestFitSourceFromPictureElement): (WebCore::HTMLImageElement::evaluateDynamicMediaQueryDependencies): (WebCore::HTMLImageElement::selectImageSource): * Source/WebCore/html/HTMLImageElement.h: * Source/WebCore/html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::selectNextSourceChild): * Source/WebCore/html/HTMLSourceElement.cpp: (WebCore::HTMLSourceElement::parsedMediaAttribute const): * Source/WebCore/html/HTMLSourceElement.h: Canonical link: https://commits.webkit.org/256993@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] e8d333: [WK2] Manually specify async-reply or delayed-repl...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: e8d33356796453c7413c0a03a33139736bf5d4ca https://github.com/WebKit/WebKit/commit/e8d33356796453c7413c0a03a33139736bf5d4ca Author: Žan Doberšek Date: 2022-11-24 (Thu, 24 Nov 2022) Changed paths: M Source/WebKit/GPUProcess/media/RemoteSourceBufferProxy.cpp M Source/WebKit/GPUProcess/media/RemoteSourceBufferProxy.h M Source/WebKit/GPUProcess/webrtc/RemoteSampleBufferDisplayLayerManager.h M Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.cpp M Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.h M Source/WebKit/NetworkProcess/NetworkResourceLoader.cpp M Source/WebKit/NetworkProcess/NetworkResourceLoader.h M Source/WebKit/Shared/ApplePay/WebPaymentCoordinatorProxy.h M Source/WebKit/Shared/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.mm M Source/WebKit/UIProcess/GPU/GPUProcessProxy.h M Source/WebKit/UIProcess/Network/NetworkProcessProxy.cpp M Source/WebKit/UIProcess/Network/NetworkProcessProxy.h M Source/WebKit/UIProcess/Notifications/WebNotificationManagerMessageHandler.cpp M Source/WebKit/UIProcess/ProvisionalPageProxy.cpp M Source/WebKit/UIProcess/ProvisionalPageProxy.h M Source/WebKit/UIProcess/SuspendedPageProxy.h M Source/WebKit/UIProcess/UserContent/WebUserContentControllerProxy.cpp M Source/WebKit/UIProcess/UserContent/WebUserContentControllerProxy.h M Source/WebKit/UIProcess/WebPageProxy.cpp M Source/WebKit/UIProcess/WebPageProxy.h M Source/WebKit/UIProcess/WebProcessProxy.cpp M Source/WebKit/UIProcess/WebProcessProxy.h M Source/WebKit/UIProcess/WebURLSchemeHandler.h M Source/WebKit/UIProcess/WebURLSchemeTask.h M Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.cpp M Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.h M Source/WebKit/WebProcess/GPU/webrtc/SampleBufferDisplayLayer.cpp M Source/WebKit/WebProcess/Inspector/WebInspectorUIExtensionController.cpp M Source/WebKit/WebProcess/Storage/WebSWContextManagerConnection.cpp M Source/WebKit/WebProcess/Storage/WebSWContextManagerConnection.h M Source/WebKit/WebProcess/WebCoreSupport/WebNotificationClient.cpp M Source/WebKit/WebProcess/WebPage/Cocoa/WebPageCocoa.mm M Source/WebKit/WebProcess/WebPage/WebPage.cpp M Source/WebKit/WebProcess/WebPage/WebPage.h M Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm M Source/WebKit/WebProcess/cocoa/VideoFullscreenManager.h M Source/WebKit/WebProcess/cocoa/VideoFullscreenManager.mm Log Message: --- [WK2] Manually specify async-reply or delayed-reply CompletionHandler types https://bugs.webkit.org/show_bug.cgi?id=248274 Reviewed by Kimmo Kinnunen. Instead of the generated async-reply and delayed-reply CompletionHandler types and the type aliases placed on each message class, the desired CompletionHandler type should be manually specified for methods that have to operate with reply-expecting messages. The AsyncReply and DelayedReply types for relevant messages are right now generated in a separate header, to avoid including full message headers. The message classes then set up type aliases against those type definitions. But the reality is that these types are nowadays used in very few cases. Most often the CompletionHandler type is written out manually in the message-handling method declarations. This change applies the latter approach everywhere. One benefit of this is that it allows specifying the CompletionHandler in most optimal way, e.g. demanding rvalue references where beneficial. The default type definitions on the other hand enforce const lvalue references for objects of non-trivial types. Once these type definitions are removed from use, the separate headers can be dropped completely, along with a solid chuck of code covering message-related code generation. * Source/WebKit/GPUProcess/media/RemoteSourceBufferProxy.cpp: (WebKit::RemoteSourceBufferProxy::removeCodedFrames): (WebKit::RemoteSourceBufferProxy::evictCodedFrames): * Source/WebKit/GPUProcess/media/RemoteSourceBufferProxy.h: * Source/WebKit/GPUProcess/webrtc/RemoteSampleBufferDisplayLayerManager.h: * Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.cpp: (WebKit::NetworkConnectionToWebProcess::performSynchronousLoad): (WebKit::NetworkConnectionToWebProcess::testProcessIncomingSyncMessagesWhenWaitingForSyncReply): * Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.h: * Source/WebKit/NetworkProcess/NetworkResourceLoader.cpp: (WebKit::NetworkResourceLoader::SynchronousLoadData::SynchronousLoadData): (WebKit::sendReplyToSynchronousRequest): (WebKit::NetworkResourceLoader::NetworkResourceLoader): * Source/WebKit/NetworkProcess/NetworkResourceLoader.h: * Source/WebKit/Shared/ApplePay/WebPaymentCoordinatorProxy.h: * Source/WebKit/Shared/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.mm: (WebKit::WebPaymentCoordinatorProxy::getSetupFeatures):
[webkit-changes] [WebKit/WebKit] 4b2445: REGRESSION(256902@main): [WPE] Broke context-menu ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 4b24459ebb4af8ba7b6547991d14194c4f13de31 https://github.com/WebKit/WebKit/commit/4b24459ebb4af8ba7b6547991d14194c4f13de31 Author: Michael Catanzaro Date: 2022-11-24 (Thu, 24 Nov 2022) Changed paths: M Source/WebKit/PlatformWPE.cmake M Source/WebKit/SourcesWPE.txt M Source/WebKit/UIProcess/API/glib/WebKitWebView.cpp M Source/WebKit/UIProcess/API/wpe/WebKitWebViewWPE.cpp A Source/WebKit/UIProcess/API/wpe/WebKitWebViewWPE1.cpp A Source/WebKit/UIProcess/API/wpe/WebKitWebViewWPE2.cpp Log Message: --- REGRESSION(256902@main): [WPE] Broke context-menu signal https://bugs.webkit.org/show_bug.cgi?id=248243 Reviewed by Carlos Garcia Campos. 256902@main accidentally broke WPE's WebKitWebView::context-menu signal. After that commit, the signal declaration now has two parameters, but the signal emission has three parameters. Instead, the original API needs to have three parameters, while the new API can have just two parameters. This means WebKitWebViewWPE needs to be split into multiple files. * Source/WebKit/PlatformWPE.cmake: * Source/WebKit/SourcesWPE.txt: * Source/WebKit/UIProcess/API/glib/WebKitWebView.cpp: (webkitWebViewPopulateContextMenu): * Source/WebKit/UIProcess/API/wpe/WebKitWebViewWPE.cpp: (createContextMenuSignal): Deleted. * Source/WebKit/UIProcess/API/wpe/WebKitWebViewWPE1.cpp: Added. (createContextMenuSignal): * Source/WebKit/UIProcess/API/wpe/WebKitWebViewWPE2.cpp: Added. (createContextMenuSignal): Canonical link: https://commits.webkit.org/256991@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 138c1e: Uninitialized memory read when opening web inspector
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 138c1e2a317b66c5c8dded5735c717fc53eca62f https://github.com/WebKit/WebKit/commit/138c1e2a317b66c5c8dded5735c717fc53eca62f Author: Michael Catanzaro Date: 2022-11-24 (Thu, 24 Nov 2022) Changed paths: M Source/WebKit/UIProcess/Inspector/WebPageInspectorController.h Log Message: --- Uninitialized memory read when opening web inspector https://bugs.webkit.org/show_bug.cgi?id=248293 Reviewed by Yusuke Suzuki. WebPageInspectorController::m_enabledBrowserAgent is mistakenly not initialized to anything. It's initialized by InspectorBrowserAgent::enable and InspectorBrowserAgent::disable, but these functions both first check whether it's enabled before they do anything. That's undefined behavior. Fix is simple: initialize it. * Source/WebKit/UIProcess/Inspector/WebPageInspectorController.h: Canonical link: https://commits.webkit.org/256990@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] a22621: [IFC][Line clamp] Enable line-clamp for simple fle...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: a226213ce56563ef4b7c26455a78736b3aad5a69 https://github.com/WebKit/WebKit/commit/a226213ce56563ef4b7c26455a78736b3aad5a69 Author: Alan Baradlay Date: 2022-11-24 (Thu, 24 Nov 2022) Changed paths: M LayoutTests/imported/w3c/web-platform-tests/css/css-flexbox/alignment/flex-align-baseline-line-clamp-001.tentative-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/css-grid/alignment/grid-align-baseline-line-clamp-001.tentative-expected.txt M LayoutTests/platform/ios/fast/overflow/line-clamp-expected.txt M LayoutTests/platform/mac/fast/overflow/line-clamp-expected.txt M Source/WebCore/layout/integration/LayoutIntegrationCoverage.cpp Log Message: --- [IFC][Line clamp] Enable line-clamp for simple flex item https://bugs.webkit.org/show_bug.cgi?id=248200 Reviewed by Antti Koivisto. Let's enable (deprecated)flex boxes with one simple, non-nested flex items. * LayoutTests/imported/w3c/web-platform-tests/css/css-flexbox/alignment/flex-align-baseline-line-clamp-001.tentative-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-grid/alignment/grid-align-baseline-line-clamp-001.tentative-expected.txt: * LayoutTests/platform/ios/fast/overflow/line-clamp-expected.txt: * LayoutTests/platform/mac/fast/overflow/line-clamp-expected.txt: * Source/WebCore/layout/integration/LayoutIntegrationCoverage.cpp: (WebCore::LayoutIntegration::canUseForStyle): Canonical link: https://commits.webkit.org/256989@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 6e0351: [WPE] Fix build after 256940@main
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 6e03517aaddb74069a4b59bc5936fda90b49d9a5 https://github.com/WebKit/WebKit/commit/6e03517aaddb74069a4b59bc5936fda90b49d9a5 Author: Claudio Saavedra Date: 2022-11-24 (Thu, 24 Nov 2022) Changed paths: M Source/WebCore/platform/gamepad/libwpe/GamepadProviderLibWPE.cpp Log Message: --- [WPE] Fix build after 256940@main Unreviewed build fix. Use proper format specifier for logging. * Source/WebCore/platform/gamepad/libwpe/GamepadProviderLibWPE.cpp: (WebCore::GamepadProviderLibWPE::gamepadConnected): (WebCore::GamepadProviderLibWPE::gamepadDisconnected): Canonical link: https://commits.webkit.org/256988@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] fde0f3: Resync web-platform-tests/web-share from upstream
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: fde0f31b8e7849e3eb1bf6c82439b4b9a5d31baf https://github.com/WebKit/WebKit/commit/fde0f31b8e7849e3eb1bf6c82439b4b9a5d31baf Author: Marcos Caceres Date: 2022-11-24 (Thu, 24 Nov 2022) Changed paths: R LayoutTests/imported/w3c/web-platform-tests/web-share/OWNERS R LayoutTests/imported/w3c/web-platform-tests/web-share/canShare-files.https-expected.txt R LayoutTests/imported/w3c/web-platform-tests/web-share/canShare-files.tentative.https-expected.txt R LayoutTests/imported/w3c/web-platform-tests/web-share/canShare-files.tentative.https.html R LayoutTests/imported/w3c/web-platform-tests/web-share/canShare-insecure.tentative.http-expected.txt R LayoutTests/imported/w3c/web-platform-tests/web-share/canShare-insecure.tentative.http.html R LayoutTests/imported/w3c/web-platform-tests/web-share/canShare.https-expected.txt M LayoutTests/imported/w3c/web-platform-tests/web-share/disabled-by-permissions-policy-cross-origin.https.sub-expected.txt M LayoutTests/imported/w3c/web-platform-tests/web-share/disabled-by-permissions-policy-cross-origin.https.sub.html R LayoutTests/imported/w3c/web-platform-tests/web-share/idlharness.https.html M LayoutTests/imported/w3c/web-platform-tests/web-share/resources/w3c-import.log R LayoutTests/imported/w3c/web-platform-tests/web-share/share-cancel-manual.https-expected.txt R LayoutTests/imported/w3c/web-platform-tests/web-share/share-cancel-manual.https.html R LayoutTests/imported/w3c/web-platform-tests/web-share/share-extra-argument-manual.https-expected.txt R LayoutTests/imported/w3c/web-platform-tests/web-share/share-extra-argument-manual.https.html R LayoutTests/imported/w3c/web-platform-tests/web-share/share-extra-field-manual.https-expected.txt R LayoutTests/imported/w3c/web-platform-tests/web-share/share-extra-field-manual.https.html R LayoutTests/imported/w3c/web-platform-tests/web-share/share-files-manual.https-expected.txt R LayoutTests/imported/w3c/web-platform-tests/web-share/share-files-manual.https.html R LayoutTests/imported/w3c/web-platform-tests/web-share/share-image-manual.tentative.https-expected.txt R LayoutTests/imported/w3c/web-platform-tests/web-share/share-image-manual.tentative.https.html R LayoutTests/imported/w3c/web-platform-tests/web-share/share-non-string-manual.https-expected.txt R LayoutTests/imported/w3c/web-platform-tests/web-share/share-non-string-manual.https.html R LayoutTests/imported/w3c/web-platform-tests/web-share/share-null-manual.https-expected.txt R LayoutTests/imported/w3c/web-platform-tests/web-share/share-null-manual.https.html R LayoutTests/imported/w3c/web-platform-tests/web-share/share-simple-manual.https-expected.txt R LayoutTests/imported/w3c/web-platform-tests/web-share/share-simple-manual.https.html R LayoutTests/imported/w3c/web-platform-tests/web-share/share-unicode-strings-manual.https-expected.txt R LayoutTests/imported/w3c/web-platform-tests/web-share/share-unicode-strings-manual.https.html R LayoutTests/imported/w3c/web-platform-tests/web-share/share-unicode-strings-nonutf8-manual.https-expected.txt R LayoutTests/imported/w3c/web-platform-tests/web-share/share-unicode-strings-nonutf8-manual.https.html R LayoutTests/imported/w3c/web-platform-tests/web-share/share-url-data-manual.https-expected.txt R LayoutTests/imported/w3c/web-platform-tests/web-share/share-url-data-manual.https.html R LayoutTests/imported/w3c/web-platform-tests/web-share/share-url-empty-manual.https-expected.txt R LayoutTests/imported/w3c/web-platform-tests/web-share/share-url-empty-manual.https.html R LayoutTests/imported/w3c/web-platform-tests/web-share/share-url-encoding-manual.https-expected.txt R LayoutTests/imported/w3c/web-platform-tests/web-share/share-url-encoding-manual.https.html R LayoutTests/imported/w3c/web-platform-tests/web-share/share-url-noscheme-manual.https-expected.txt R LayoutTests/imported/w3c/web-platform-tests/web-share/share-url-noscheme-manual.https.html R LayoutTests/imported/w3c/web-platform-tests/web-share/share-url-pathonly-manual.https-expected.txt R LayoutTests/imported/w3c/web-platform-tests/web-share/share-url-pathonly-manual.https.html R LayoutTests/imported/w3c/web-platform-tests/web-share/share-url-relative-manual.https-expected.txt R LayoutTests/imported/w3c/web-platform-tests/web-share/share-url-relative-manual.https.html M LayoutTests/imported/w3c/web-platform-tests/web-share/w3c-import.log M LayoutTests/platform/ios-wk2/TestExpectations M LayoutTests/platform/mac-wk2/TestExpectations Log Message: --- Resync web-platform-tests/web-share from upstream https://bugs.webkit.org/show_bug.cgi?id=248290 rdar://102634030 Syncs to f172cbe Reviewed by Tim Nguyen. *
