[webkit-changes] [WebKit/WebKit] 2699c1: [JSC] Merge op_enter, op_get_scope and op_check_traps
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 2699c11a984bc0677893eb0b7fe2ef0511d10323 https://github.com/WebKit/WebKit/commit/2699c11a984bc0677893eb0b7fe2ef0511d10323 Author: Tadeu Zagallo Date: 2023-02-23 (Thu, 23 Feb 2023) Changed paths: M Source/JavaScriptCore/bytecode/PreciseJumpTargets.cpp M Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp M Source/JavaScriptCore/bytecompiler/BytecodeGenerator.h M Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp M Source/JavaScriptCore/jit/JIT.cpp M Source/JavaScriptCore/jit/JIT.h M Source/JavaScriptCore/jit/JITOpcodes.cpp M Source/JavaScriptCore/llint/LowLevelInterpreter.asm M Source/JavaScriptCore/llint/LowLevelInterpreter64.asm M Source/JavaScriptCore/runtime/CommonSlowPaths.cpp Log Message: --- [JSC] Merge op_enter, op_get_scope and op_check_traps https://bugs.webkit.org/show_bug.cgi?id=252824 rdar://105833316 Reviewed by Keith Miller. Every function starts with the same 3 opcodes: ``` op_enter op_get_scope loc4 op_check_traps ``` This patch changes `op_enter` to also get the scope and checks for VM traps. This reduces the prologue overhead by 3 bytes. The one complication is recursive tail calls. Previously we inserted a basic block right after op_enter, and recursive tail calls entered at opcode #2 (op_get_scope). Now, in DFG, we have to enter in the middle of op_enter, which is fine, but we can no longer lazily search for the basic block when we detect a recursive tail call, so we keep track of the target block for recursive tail calls in InlineStackEntry. * Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp: (JSC::BytecodeGenerator::BytecodeGenerator): (JSC::BytecodeGenerator::allocateScope): (JSC::BytecodeGenerator::allocateAndEmitScope): Deleted. * Source/JavaScriptCore/bytecompiler/BytecodeGenerator.h: * Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp: (JSC::DFG::ByteCodeParser::handleRecursiveTailCall): (JSC::DFG::ByteCodeParser::handleGetScope): (JSC::DFG::ByteCodeParser::handleCheckTraps): (JSC::DFG::ByteCodeParser::parseBlock): * Source/JavaScriptCore/jit/JIT.cpp: (JSC::JIT::privateCompileSlowCases): * Source/JavaScriptCore/jit/JIT.h: * Source/JavaScriptCore/jit/JITOpcodes.cpp: (JSC::JIT::emitGetScope): (JSC::JIT::emitCheckTraps): (JSC::JIT::emit_op_enter): (JSC::JIT::emit_op_get_scope): (JSC::JIT::emit_op_check_traps): (JSC::JIT::emitSlow_op_enter): * Source/JavaScriptCore/llint/LowLevelInterpreter.asm: * Source/JavaScriptCore/llint/LowLevelInterpreter64.asm: * Source/JavaScriptCore/runtime/CommonSlowPaths.cpp: (JSC::JSC_DEFINE_COMMON_SLOW_PATH): Canonical link: https://commits.webkit.org/260787@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] ba9ef0: [JSC] Add peephole optimization for consecutive moves
Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: ba9ef0e90d4fcf761af62ba00df66efa57a57776
https://github.com/WebKit/WebKit/commit/ba9ef0e90d4fcf761af62ba00df66efa57a57776
Author: Tadeu Zagallo
Date: 2023-02-23 (Thu, 23 Feb 2023)
Changed paths:
M Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp
Log Message:
---
[JSC] Add peephole optimization for consecutive moves
https://bugs.webkit.org/show_bug.cgi?id=252830
rdar://105834848
Reviewed by Keith Miller.
Add a BytecodeGenerator peephole optimization for removing redundant consecutive
moves into the same virtual register. It isn't very common, but looking at real
world data I see a few hundreds of moves that could be eliminated with a trivial
optimization. A contrived example is the following program:
```
{ if (true) { } }
```
This generates 3 consecutives `mov dst:loc6, src:Undefined`.
* Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::initializeVarLexicalEnvironment):
(JSC::BytecodeGenerator::moveLinkTimeConstant):
(JSC::BytecodeGenerator::moveEmptyValue):
(JSC::BytecodeGenerator::emitMove):
Canonical link: https://commits.webkit.org/260786@main
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] f5c820: [WebGPU] "bgra8unorm-storage" is missing from GPUF...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: f5c8208c8ddbf14ae5c9edc948eec1de511e3383 https://github.com/WebKit/WebKit/commit/f5c8208c8ddbf14ae5c9edc948eec1de511e3383 Author: Mike Wyrzykowski Date: 2023-02-23 (Thu, 23 Feb 2023) Changed paths: M Source/WebCore/Modules/WebGPU/GPUFeatureName.h M Source/WebCore/Modules/WebGPU/GPUFeatureName.idl M Source/WebCore/PAL/pal/graphics/WebGPU/Impl/WebGPUAdapterImpl.cpp M Source/WebCore/PAL/pal/graphics/WebGPU/Impl/WebGPUConvertToBackingContext.cpp M Source/WebCore/PAL/pal/graphics/WebGPU/WebGPUFeatureName.h M Source/WebGPU/WebGPU/HardwareCapabilities.mm M Source/WebKit/Shared/WebGPU/WebGPUFeatureName.serialization.in Log Message: --- [WebGPU] "bgra8unorm-storage" is missing from GPUFeatureName https://bugs.webkit.org/show_bug.cgi?id=252731 Reviewed by Myles C. Maxfield. Add missing feature names and related enum values. * Source/WebCore/Modules/WebGPU/GPUFeatureName.idl: * Source/WebCore/Modules/WebGPU/GPUFeatureName.h: (WebCore::convertToBacking): * Source/WebCore/PAL/pal/graphics/WebGPU/Impl/WebGPUAdapterImpl.cpp: (PAL::WebGPU::supportedFeatures): * Source/WebCore/PAL/pal/graphics/WebGPU/Impl/WebGPUConvertToBackingContext.cpp: (PAL::WebGPU::ConvertToBackingContext::convertToBacking): * Source/WebCore/PAL/pal/graphics/WebGPU/WebGPUFeatureName.h: * Source/WebGPU/WebGPU/HardwareCapabilities.mm: (WebGPU::baseFeatures): * Source/WebKit/Shared/WebGPU/WebGPUFeatureName.serialization.in: Canonical link: https://commits.webkit.org/260785@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] e59a73: RemoteScrollingCoordinatorProxy needs to receive N...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: e59a73b266370bee03de9e1abddf3f369e343f56 https://github.com/WebKit/WebKit/commit/e59a73b266370bee03de9e1abddf3f369e343f56 Author: Simon Fraser Date: 2023-02-23 (Thu, 23 Feb 2023) Changed paths: M Source/WebKit/UIProcess/RemoteLayerTree/RemoteScrollingCoordinatorProxy.cpp M Source/WebKit/UIProcess/RemoteLayerTree/RemoteScrollingCoordinatorProxy.h M Source/WebKit/UIProcess/WebPageProxy.cpp Log Message: --- RemoteScrollingCoordinatorProxy needs to receive NativeWebWheelEvents https://bugs.webkit.org/show_bug.cgi?id=252860 rdar://105852101 Reviewed by Sam Weinig. RemoteLayerTreeEventDispatcher will get a MomentumEventDispatcher soon, and MomentumEventDispatcher needs to be fed a ScrollingAccelerationCurve which is derived from a native event, so these native events need to get to RemoteScrollingCoordinatorProxy. So change the argument to handleWheelEvent() to be a NativeWebWheelEvent. * Source/WebKit/UIProcess/RemoteLayerTree/RemoteScrollingCoordinatorProxy.cpp: (WebKit::RemoteScrollingCoordinatorProxy::handleWheelEvent): * Source/WebKit/UIProcess/RemoteLayerTree/RemoteScrollingCoordinatorProxy.h: * Source/WebKit/UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::handleWheelEvent): Canonical link: https://commits.webkit.org/260784@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 5d7824: [CMake] Update WebKitFindPackages wrapper
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 5d7824d83862568b7e98796d18c2c5a8189e4ab9 https://github.com/WebKit/WebKit/commit/5d7824d83862568b7e98796d18c2c5a8189e4ab9 Author: Don Olmstead Date: 2023-02-23 (Thu, 23 Feb 2023) Changed paths: M Source/cmake/WebKitFindPackage.cmake Log Message: --- [CMake] Update WebKitFindPackages wrapper https://bugs.webkit.org/show_bug.cgi?id=252854 Reviewed by Michael Catanzaro. Remove redundant target creation based on a `cmake_minimum_required` of 3.16. Now only `ICU::` and `LibXslt::LibXslt` targets are created in the `find_package` wrapper. * Source/cmake/WebKitFindPackage.cmake: Canonical link: https://commits.webkit.org/260783@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 454308: Avoid unnecessary alloc/init when using dictionary...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 4543085706efe7dfb684593f6b4e87410cefa34d https://github.com/WebKit/WebKit/commit/4543085706efe7dfb684593f6b4e87410cefa34d Author: Rose <83477269+ataridre...@users.noreply.github.com> Date: 2023-02-23 (Thu, 23 Feb 2023) Changed paths: M Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionCocoa.mm Log Message: --- Avoid unnecessary alloc/init when using dictionary literals https://bugs.webkit.org/show_bug.cgi?id=252813 Reviewed by Timothy Hatcher. The compiler initializes an NSDictionary when the @ syntax is used. If an underlying error happens, alloc/init is called again. Let's avoid that. *Source\WebKit\UIProcess\Extensions\Cocoa\WebExtensionCocoa.mm: Canonical link: https://commits.webkit.org/260782@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] b2e818: [Cocoa] font-optical-sizing:auto doesn't set the o...
Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: b2e8181dbd7510819ee516e847f139fa7cb1b636
https://github.com/WebKit/WebKit/commit/b2e8181dbd7510819ee516e847f139fa7cb1b636
Author: Myles C. Maxfield
Date: 2023-02-23 (Thu, 23 Feb 2023)
Changed paths:
M Source/WTF/wtf/PlatformUse.h
M Source/WebCore/platform/graphics/cocoa/UnrealizedCoreTextFont.cpp
M Source/WebCore/platform/graphics/cocoa/UnrealizedCoreTextFont.h
Log Message:
---
[Cocoa] font-optical-sizing:auto doesn't set the opsz variation axis for all
fonts that need it
https://bugs.webkit.org/show_bug.cgi?id=252552
rdar://105662167
Reviewed by Alan Baradlay.
This is a follow-up from 260447@main. That previous patch went almost all the
way toward fixing the
problem, but couldn't actually apply optical sizing to all text that requested
it. The reason for
this is that the trigger we were using to enable optical sizing,
`kCTFontOpticalSizeAttribute`,
enables the `opsz` variation axis, but also enables the `trak` table.
Unfortunately, we have a lot
of tests which use fonts that don't support the optical sizing variation axis,
but do have a `trak`
table. So, if we just naively started enabling `kCTFontOpticalSizeAttribute`
for all text that
requests it, we'll get tons of test failures. It's not really great if we make
tons of text on the
web look different, without it being a deliberate decision. So, the previous
patch stopped just
short of enabling `kCTFontOpticalSizeAttribute` everywhere.
However, all fonts which *do* support the `opsz` variation axis should have it
set automatically,
which is what 260447@main was aiming to address. We have the ability to *just*
set the variation
axis without also setting `trak`, so that's what we need to do for fonts that
request optical
sizing but for which we can't use `kCTFontOpticalSizeAttribute` because of
compatibility.
So, we need 3 buckets:
- Disable optical sizing. This is triggered by font-optical-sizing:none. This
maps to telling Core
Text to use `kCTFontOpticalSizeAttribute`: `none`.
- Enable full optical sizing, including `trak`. This is triggered by
text-rendering:optimizeLegibility. This maps to telling Core Text to use
`kCTFontOpticalSizeAttribute`: `auto`.
- Enable optical sizing, but just the `opsz` variation, and not `trak`, for
compatibility. This
is what all situations not captured by the above use. This maps to
telling Core Text to use
`kCTFontVariationAttribute`: {`opsz`: font size}.
This patch implements the third bucket, which wasn't implemented in the
previous patch. The third
bucket doesn't actually work correctly on older OSes, so it's guarded behind a
OS version check.
https://bugs.webkit.org/show_bug.cgi?id=252592 is about deleting the
compatibility third bucket in
favor of the second bucket: actually enabling `trak` for all text that should
have optical sizing
enabled.
Just like 260447@main, the tests for this adds a megabyte of fonts (because we
have to keep the
whole release of an OFL font together) so I'm not including the test with this
PR, and will upload
another PR later with a custom font that I create from scratch for testing this.
* Source/WTF/wtf/PlatformUse.h:
* Source/WebCore/platform/graphics/cocoa/UnrealizedCoreTextFont.cpp:
(WebCore::UnrealizedCoreTextFont::addAttributesForOpticalSizing):
(WebCore::UnrealizedCoreTextFont::applyVariations):
(WebCore::UnrealizedCoreTextFont::modifyFromContext):
(WebCore::UnrealizedCoreTextFont::realize const):
(WebCore::applyVariations): Deleted.
(WebCore::modifyFromContext): Deleted.
* Source/WebCore/platform/graphics/cocoa/UnrealizedCoreTextFont.h:
Canonical link: https://commits.webkit.org/260781@main
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] e2f6ec: Use a WTF_GUARDED_BY_LOCK in MomentumEventDispatcher
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: e2f6ecac142ec640c57567b2ecf2289452f8abeb https://github.com/WebKit/WebKit/commit/e2f6ecac142ec640c57567b2ecf2289452f8abeb Author: Simon Fraser Date: 2023-02-23 (Thu, 23 Feb 2023) Changed paths: M Source/WebKit/WebProcess/WebPage/MomentumEventDispatcher.h Log Message: --- Use a WTF_GUARDED_BY_LOCK in MomentumEventDispatcher https://bugs.webkit.org/show_bug.cgi?id=252862 rdar://105853141 Reviewed by Chris Dumez. 260617@main added locking for m_accelerationCurves, but omitted using WTF_GUARDED_BY_LOCK, so rectify that. * Source/WebKit/WebProcess/WebPage/MomentumEventDispatcher.h: Canonical link: https://commits.webkit.org/260780@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 68ae85: Add support for painting document markers using sy...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 68ae85e5b18813ea881d0f18312e848a9389366e https://github.com/WebKit/WebKit/commit/68ae85e5b18813ea881d0f18312e848a9389366e Author: Aditya Keerthi Date: 2023-02-23 (Thu, 23 Feb 2023) Changed paths: M Source/WebCore/PAL/pal/spi/mac/NSSpellCheckerSPI.h M Source/WebCore/rendering/RenderTheme.cpp M Source/WebCore/rendering/RenderTheme.h M Source/WebCore/rendering/RenderThemeCocoa.h M Source/WebCore/rendering/RenderThemeCocoa.mm M Source/WebCore/rendering/RenderThemeMac.h M Source/WebCore/rendering/RenderThemeMac.mm Log Message: --- Add support for painting document markers using system colors https://bugs.webkit.org/show_bug.cgi?id=252791 rdar://105796291 Reviewed by Wenson Hsieh and Megan Gardner. Use system colors for painting document markers when possible. To support this functionality, new `RenderTheme` methods are added to control platform-specific marker colors and the color cache is expanded for the new colors. This approach matches the implementation of existing system colors. * Source/WebCore/PAL/pal/spi/mac/NSSpellCheckerSPI.h: * Source/WebCore/rendering/RenderTheme.cpp: (WebCore::RenderTheme::spellingMarkerColor const): (WebCore::RenderTheme::platformSpellingMarkerColor const): (WebCore::RenderTheme::dictationAlternativesMarkerColor const): (WebCore::RenderTheme::platformDictationAlternativesMarkerColor const): (WebCore::RenderTheme::autocorrectionReplacementMarkerColor const): (WebCore::RenderTheme::platformAutocorrectionReplacementMarkerColor const): (WebCore::RenderTheme::grammarMarkerColor const): (WebCore::RenderTheme::platformGrammarMarkerColor const): (WebCore::RenderTheme::documentMarkerLineColor const): * Source/WebCore/rendering/RenderTheme.h: * Source/WebCore/rendering/RenderThemeCocoa.h: * Source/WebCore/rendering/RenderThemeCocoa.mm: (WebCore::RenderThemeCocoa::platformSpellingMarkerColor const): (WebCore::RenderThemeCocoa::platformDictationAlternativesMarkerColor const): (WebCore::RenderThemeCocoa::platformAutocorrectionReplacementMarkerColor const): (WebCore::RenderThemeCocoa::platformGrammarMarkerColor const): (WebCore::grammarColor): Deleted. (WebCore::RenderThemeCocoa::documentMarkerLineColor const): Deleted. * Source/WebCore/rendering/RenderThemeMac.h: * Source/WebCore/rendering/RenderThemeMac.mm: (WebCore::usePlatformColorForAutocorrectionReplacementMarker): (WebCore::RenderThemeMac::platformAutocorrectionReplacementMarkerColor const): Canonical link: https://commits.webkit.org/260779@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 5a42b1: OpenTypeMathData should depend on ENABLE(MATHML)
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 5a42b144278f6e999087354b9c9e08f77b24fe30 https://github.com/WebKit/WebKit/commit/5a42b144278f6e999087354b9c9e08f77b24fe30 Author: Don Olmstead Date: 2023-02-23 (Thu, 23 Feb 2023) Changed paths: M Source/WebCore/platform/graphics/Font.cpp M Source/WebCore/platform/graphics/Font.h M Source/WebCore/platform/graphics/FontPlatformData.h M Source/WebCore/platform/graphics/freetype/FontPlatformDataFreeType.cpp M Source/WebCore/platform/graphics/opentype/OpenTypeMathData.cpp M Source/WebCore/platform/graphics/opentype/OpenTypeMathData.h Log Message: --- OpenTypeMathData should depend on ENABLE(MATHML) https://bugs.webkit.org/show_bug.cgi?id=252851 Reviewed by Michael Catanzaro. All the uses of `OpenTypeMathData` are within code guarded by `ENABLE(MATHML)` so add the guard to it and its references in Font classes. Fixes PlayStation build after 260744@main. * Source/WebCore/platform/graphics/Font.cpp: * Source/WebCore/platform/graphics/Font.h: * Source/WebCore/platform/graphics/FontPlatformData.h: * Source/WebCore/platform/graphics/freetype/FontPlatformDataFreeType.cpp: * Source/WebCore/platform/graphics/opentype/OpenTypeMathData.cpp: * Source/WebCore/platform/graphics/opentype/OpenTypeMathData.h: Canonical link: https://commits.webkit.org/260778@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 403cf8: [WebGPU] Invalid limits do not result in device cr...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 403cf88c8df73ed92e7626dd3c1e5511d9762b03 https://github.com/WebKit/WebKit/commit/403cf88c8df73ed92e7626dd3c1e5511d9762b03 Author: Mike Wyrzykowski Date: 2023-02-23 (Thu, 23 Feb 2023) Changed paths: M Source/WebCore/Modules/WebGPU/GPUAdapter.cpp M Source/WebCore/Modules/WebGPU/GPUSupportedLimits.cpp M Source/WebCore/Modules/WebGPU/GPUSupportedLimits.h M Source/WebCore/Modules/WebGPU/GPUSupportedLimits.idl M Source/WebCore/PAL/pal/graphics/WebGPU/Impl/WebGPUAdapterImpl.cpp M Source/WebCore/PAL/pal/graphics/WebGPU/Impl/WebGPUAdapterImpl.h M Source/WebCore/PAL/pal/graphics/WebGPU/WebGPUAdapter.h M Source/WebCore/PAL/pal/graphics/WebGPU/WebGPUSupportedLimits.h M Source/WebGPU/WebGPU/Adapter.h M Source/WebGPU/WebGPU/Adapter.mm M Source/WebGPU/WebGPU/Buffer.mm M Source/WebGPU/WebGPU/ComputePipeline.mm M Source/WebGPU/WebGPU/HardwareCapabilities.mm M Source/WebGPU/WebGPU/RenderPipeline.mm M Source/WebGPU/WebGPU/ShaderModule.mm M Source/WebGPU/WebGPU/WebGPU.h M Source/WebGPU/WebGPU/WebGPUExt.h M Source/WebKit/GPUProcess/graphics/WebGPU/RemoteAdapter.cpp M Source/WebKit/GPUProcess/graphics/WebGPU/RemoteGPU.cpp M Source/WebKit/Shared/WebGPU/WebGPUSupportedLimits.cpp M Source/WebKit/Shared/WebGPU/WebGPUSupportedLimits.h M Source/WebKit/Shared/WebGPU/WebGPUSupportedLimits.serialization.in M Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemoteAdapterProxy.cpp M Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemoteAdapterProxy.h M Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemoteGPUProxy.cpp Log Message: --- [WebGPU] Invalid limits do not result in device creation failure https://bugs.webkit.org/show_bug.cgi?id=252700 Reviewed by Myles C. Maxfield. The specification says we should reject the promise of GPUAdapter.requestDevice when the specified limits are invalid. Achieve this by returning null on failure from requestDevice and rejecting the promise in the GPUAdapter layer. Also update WebGPU.h as maxColorAttachmentBytesPerSample was missing from WGPULimits. * Source/WebCore/Modules/WebGPU/GPUAdapter.cpp: (WebCore::GPUAdapter::requestDevice): * Source/WebCore/Modules/WebGPU/GPUSupportedLimits.cpp: (WebCore::GPUSupportedLimits::maxBindingsPerBindGroup const): (WebCore::GPUSupportedLimits::maxBufferSize const): (WebCore::GPUSupportedLimits::maxInterStageShaderVariables const): (WebCore::GPUSupportedLimits::maxColorAttachments const): (WebCore::GPUSupportedLimits::maxColorAttachmentBytesPerSample const): * Source/WebCore/Modules/WebGPU/GPUSupportedLimits.h: * Source/WebCore/Modules/WebGPU/GPUSupportedLimits.idl: * Source/WebCore/PAL/pal/graphics/WebGPU/Impl/WebGPUAdapterImpl.cpp: (PAL::WebGPU::supportedFeatures): (PAL::WebGPU::supportedLimits): (PAL::WebGPU::AdapterImpl::requestDevice): * Source/WebCore/PAL/pal/graphics/WebGPU/Impl/WebGPUAdapterImpl.h: * Source/WebCore/PAL/pal/graphics/WebGPU/WebGPUAdapter.h: * Source/WebCore/PAL/pal/graphics/WebGPU/WebGPUSupportedLimits.h: * Source/WebGPU/WGSL/Overload.cpp: (WGSL::OverloadResolver::materialize const): * Source/WebGPU/WebGPU/Adapter.mm: (WebGPU::Adapter::requestInvalidDevice): * Source/WebGPU/WebGPU/Buffer.mm: (wgpuBufferGetMapState): * Source/WebGPU/WebGPU/ComputePipeline.mm: (WebGPU::Device::createComputePipelineAsync): * Source/WebGPU/WebGPU/HardwareCapabilities.mm: (WebGPU::apple3): (WebGPU::apple4): (WebGPU::apple5): (WebGPU::apple6): (WebGPU::apple7): (WebGPU::mac2): (WebGPU::mergeLimits): (WebGPU::anyLimitIsBetterThan): (WebGPU::defaultLimits): * Source/WebGPU/WebGPU/RenderPipeline.mm: (WebGPU::Device::createRenderPipelineAsync): * Source/WebGPU/WebGPU/ShaderModule.mm: (WebGPU::convertMessages): * Source/WebGPU/WebGPU/WebGPU.h: * Source/WebKit/GPUProcess/graphics/WebGPU/RemoteAdapter.cpp: (WebKit::RemoteAdapter::requestDevice): * Source/WebKit/GPUProcess/graphics/WebGPU/RemoteGPU.cpp: (WebKit::RemoteGPU::requestAdapter): * Source/WebKit/Shared/WebGPU/WebGPUSupportedLimits.cpp: (WebKit::WebGPU::ConvertToBackingContext::convertToBacking): (WebKit::WebGPU::ConvertFromBackingContext::convertFromBacking): * Source/WebKit/Shared/WebGPU/WebGPUSupportedLimits.h: * Source/WebKit/Shared/WebGPU/WebGPUSupportedLimits.serialization.in: * Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemoteAdapterProxy.cpp: (WebKit::WebGPU::RemoteAdapterProxy::requestDevice): * Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemoteAdapterProxy.h: * Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemoteGPUProxy.cpp: (WebKit::RemoteGPUProxy::requestAdapter): Canonical link: https://commits.webkit.org/260777@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] c7c5ed: [GTK][WPE] Mark flaky tests from 29Jan2023 to 23Fe...
Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: c7c5edd4c722345409b7fde8dbec131770a2d3e0
https://github.com/WebKit/WebKit/commit/c7c5edd4c722345409b7fde8dbec131770a2d3e0
Author: Carlos Alberto Lopez Perez
Date: 2023-02-23 (Thu, 23 Feb 2023)
Changed paths:
M LayoutTests/platform/glib/TestExpectations
M LayoutTests/platform/gtk/TestExpectations
M LayoutTests/platform/wpe/TestExpectations
Log Message:
---
[GTK][WPE] Mark flaky tests from 29Jan2023 to 23Feb2023
https://bugs.webkit.org/show_bug.cgi?id=252878
Unreviewed gardening.
Mark clear flaky tests detected on the release post-commit
bots on that period.
On top of that seize this to merge the expectations for the
tests imported/w3c/web-platform-tests/shadow-dom/focus-navigation/*
And also rename a expectations for one of this tests that
was renamed on the last import (see WPT commit f09a6bf875 )
shadow-dom/focus-navigation/{focus-navigation-web-component-input-type-radio.html
=> focus-navigation-web-component-radio.html}
* LayoutTests/platform/glib/TestExpectations:
* LayoutTests/platform/gtk/TestExpectations:
* LayoutTests/platform/wpe/TestExpectations:
Canonical link: https://commits.webkit.org/260776@main
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] e314f5: Refactor caret painting logic
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: e314f573db05b5bdbed3b794661dc0144f32ba16 https://github.com/WebKit/WebKit/commit/e314f573db05b5bdbed3b794661dc0144f32ba16 Author: Mike Wyrzykowski Date: 2023-02-23 (Thu, 23 Feb 2023) Changed paths: M Source/WebCore/editing/FrameSelection.cpp M Source/WebCore/editing/FrameSelection.h M Source/WebCore/platform/CaretAnimator.h M Source/WebCore/rendering/RenderBlock.cpp M Source/WebCore/rendering/RenderBlock.h Log Message: --- Refactor caret painting logic https://bugs.webkit.org/show_bug.cgi?id=252148 Reviewed by Ryosuke Niwa and Aditya Keerthi. Continue previous refactorings to the caret painting logic to allow some additional flexibility. * Source/WebCore/editing/FrameSelection.cpp: (WebCore::fillCaretRect): Pass not just the presentation properties but the entire animator to allow for additional flexibility. (WebCore::repaintCaretRectForLocalRect): (WebCore::repaintCaretForLocalRect): Allow the animator to influence the repaint rect. (WebCore::FrameSelection::invalidateCaretRect): (WebCore::CaretBase::invalidateCaretRect): (WebCore::FrameSelection::paintCaret): (WebCore::CaretBase::paintCaret const): (WebCore::DragCaretController::paintDragCaret const): * Source/WebCore/editing/FrameSelection.h: Pass the caret animator instead of just its properties. * Source/WebCore/rendering/RenderBlock.cpp: (WebCore::renderCaretInsideContentsClip): (WebCore::RenderBlock::paint): (WebCore::RenderBlock::paintObject): Allow rendering the caret outside the element's clipping rectangle. Canonical link: https://commits.webkit.org/260775@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] b72881: REGRESSION(260575@main) [GPUP] Video disappears du...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: b72881d351bc84dffb3d3e7cd60e781597236bda https://github.com/WebKit/WebKit/commit/b72881d351bc84dffb3d3e7cd60e781597236bda Author: Jer Noble Date: 2023-02-23 (Thu, 23 Feb 2023) Changed paths: M Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp M Source/WebKit/WebProcess/WebPage/RemoteLayerTree/GraphicsLayerCARemote.cpp M Source/WebKit/WebProcess/WebPage/RemoteLayerTree/GraphicsLayerCARemote.h M Source/WebKit/WebProcess/WebPage/RemoteLayerTree/PlatformCALayerRemote.cpp Log Message: --- REGRESSION(260575@main) [GPUP] Video disappears during playback with UI-Side compositing enabled https://bugs.webkit.org/show_bug.cgi?id=252841 rdar://105835986 Reviewed by Per Arne Vollan. Fix an incorrect pragma that effectively disabled the "no double hosting" logic for media in GPU process. * Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp: (WebCore::GraphicsLayerCA::setContentsToVideoElement): * Source/WebKit/WebProcess/WebPage/RemoteLayerTree/GraphicsLayerCARemote.cpp: * Source/WebKit/WebProcess/WebPage/RemoteLayerTree/GraphicsLayerCARemote.h: * Source/WebKit/WebProcess/WebPage/RemoteLayerTree/PlatformCALayerRemote.cpp: Canonical link: https://commits.webkit.org/260774@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 505649: macOS: support for the foreground color attribute ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 5056494ddbe484ce708028a4de28118967041414 https://github.com/WebKit/WebKit/commit/5056494ddbe484ce708028a4de28118967041414 Author: Richard Robinson Date: 2023-02-23 (Thu, 23 Feb 2023) Changed paths: M Source/WebKit/UIProcess/mac/WebViewImpl.mm Log Message: --- macOS: support for the foreground color attribute in marked text not working https://bugs.webkit.org/show_bug.cgi?id=252792 rdar://105812593 Reviewed by Wenson Hsieh. * Source/WebKit/UIProcess/mac/WebViewImpl.mm: (WebKit::shouldUseHighlightsForMarkedText): (WebKit::compositionHighlights): (WebKit::WebViewImpl::setMarkedText): Canonical link: https://commits.webkit.org/260773@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] fa1044: Fix release build after 260767@main
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: fa1044c7443146e72af48630b9a4c4c5865226f7 https://github.com/WebKit/WebKit/commit/fa1044c7443146e72af48630b9a4c4c5865226f7 Author: Alex Christensen Date: 2023-02-23 (Thu, 23 Feb 2023) Changed paths: M Source/WebCore/page/Page.cpp Log Message: --- Fix release build after 260767@main https://bugs.webkit.org/show_bug.cgi?id=252871 rdar://105858804 Unreviewed. * Source/WebCore/page/Page.cpp: (WebCore::Page::mainFrameDidChangeToNonInitialEmptyDocument): Canonical link: https://commits.webkit.org/260772@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] ffae77: [JSC] Add lock / unlock mechanism to LRU in new wa...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: ffae772a848e40be9839efbf81742919df8d84f5 https://github.com/WebKit/WebKit/commit/ffae772a848e40be9839efbf81742919df8d84f5 Author: Yusuke Suzuki Date: 2023-02-23 (Thu, 23 Feb 2023) Changed paths: M Source/JavaScriptCore/wasm/WasmBBQJIT.cpp Log Message: --- [JSC] Add lock / unlock mechanism to LRU in new wasm BBQ for scratch https://bugs.webkit.org/show_bug.cgi?id=252869 rdar://105856151 Reviewed by Justin Michaud. When a register is used for scratch, then we must not evict it while it is used since (1) we would like to have a register, and (2) there is no way to save and restore scratches. However we have no mechanism to prevent it, and we crash when running tfjs-wasm in JetStream3. This patch integrates lock and unlock mechanism for registers allocated for scratches. This lock / unlock names are derived from DFG's reigster allocator & Baseline JIT's IC register allocators. We mark scratches as locked, and they are not used for register allocation targets. We would like to expand this mechanism for the non scratch registers when it is currently used and we would like to lock it down right now. But in this patch, let's first do it for scratches. * Source/JavaScriptCore/wasm/WasmBBQJIT.cpp: (JSC::Wasm::BBQJIT::LRU::findMin): (JSC::Wasm::BBQJIT::LRU::lock): (JSC::Wasm::BBQJIT::LRU::unlock): (JSC::Wasm::BBQJIT::ScratchScope::gpr const): (JSC::Wasm::BBQJIT::ScratchScope::fpr const): (JSC::Wasm::BBQJIT::ScratchScope::bindGPRToScratch): (JSC::Wasm::BBQJIT::ScratchScope::bindFPRToScratch): (JSC::Wasm::BBQJIT::ScratchScope::unbindGPRFromScratch): (JSC::Wasm::BBQJIT::ScratchScope::unbindFPRFromScratch): Canonical link: https://commits.webkit.org/260771@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 480aae: Unreviewed, reverting r260719@main.
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 480aae26447f06dee6a08be90bd7fc37b85f8f8b https://github.com/WebKit/WebKit/commit/480aae26447f06dee6a08be90bd7fc37b85f8f8b Author: Commit Queue Date: 2023-02-23 (Thu, 23 Feb 2023) Changed paths: M Tools/Scripts/build-webkit Log Message: --- Unreviewed, reverting r260719@main. https://bugs.webkit.org/show_bug.cgi?id=252875 Some macOS versions don't have a corresponding public SDK Reverted changeset: "[Xcode] Set MACOSX_DEPLOYMENT_TARGET on open source builds to match the system version" https://bugs.webkit.org/show_bug.cgi?id=252783 https://commits.webkit.org/260719@main Canonical link: https://commits.webkit.org/260770@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit]
Branch: refs/tags/WebKit-7616.1.3.1 Home: https://github.com/WebKit/WebKit ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 156367: [ macOS , iOS ] imported/w3c/web-platform-tests/pr...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 15636735b114205db28672364d00fc7170cf33b4 https://github.com/WebKit/WebKit/commit/15636735b114205db28672364d00fc7170cf33b4 Author: Ryosuke Niwa Date: 2023-02-23 (Thu, 23 Feb 2023) Changed paths: M LayoutTests/imported/w3c/web-platform-tests/preload/modulepreload.html Log Message: --- [ macOS , iOS ] imported/w3c/web-platform-tests/preload/modulepreload.html is a constant failure. https://bugs.webkit.org/show_bug.cgi?id=252847 Reviewed by Tim Nguyen. The failure was caused by the test relying on resources/module1.js to be loaded in this test even though it's also loaded in preload/link-header-modulepreload.html priori. Fixed the test by making its URL unique. The test is fixed upstream in https://github.com/web-platform-tests/wpt/pull/38689. * LayoutTests/imported/w3c/web-platform-tests/preload/modulepreload.html: Canonical link: https://commits.webkit.org/260769@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] bd7aad: Remove AppleWin code from DLLLauncherMain.cpp
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: bd7aade58f9bbfc59da1f932823380c8cf3d18dc https://github.com/WebKit/WebKit/commit/bd7aade58f9bbfc59da1f932823380c8cf3d18dc Author: Fujii Hironori Date: 2023-02-23 (Thu, 23 Feb 2023) Changed paths: M Source/JavaScriptCore/shell/DLLLauncherMain.cpp M Source/JavaScriptCore/shell/PlatformWin.cmake M Source/WebDriver/PlatformWin.cmake M Tools/ImageDiff/PlatformWin.cmake M Tools/MiniBrowser/win/CMakeLists.txt M Tools/TestWebKitAPI/PlatformWin.cmake M Tools/WebKitTestRunner/PlatformWin.cmake M Tools/win/DLLLauncher/DLLLauncherMain.cpp Log Message: --- Remove AppleWin code from DLLLauncherMain.cpp https://bugs.webkit.org/show_bug.cgi?id=252853 Reviewed by Don Olmstead. * Source/JavaScriptCore/shell/DLLLauncherMain.cpp: (modifyPath): (getStringValue): Deleted. (applePathFromRegistry): Deleted. (appleApplicationSupportDirectory): Deleted. (iTunesDirectory): Deleted. (prependPath): Deleted. * Source/JavaScriptCore/shell/PlatformWin.cmake: * Source/WebDriver/PlatformWin.cmake: * Tools/ImageDiff/PlatformWin.cmake: * Tools/MiniBrowser/win/CMakeLists.txt: * Tools/TestWebKitAPI/PlatformWin.cmake: * Tools/WebKitTestRunner/PlatformWin.cmake: * Tools/win/DLLLauncher/DLLLauncherMain.cpp: (modifyPath): (getStringValue): Deleted. (applePathFromRegistry): Deleted. (appleApplicationSupportDirectory): Deleted. (iTunesDirectory): Deleted. (prependPath): Deleted. Canonical link: https://commits.webkit.org/260768@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] dfb907: Page::m_mainFrame should be an AbstractFrame
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: dfb90751211591c4b39efb57ebd798186f7a2338 https://github.com/WebKit/WebKit/commit/dfb90751211591c4b39efb57ebd798186f7a2338 Author: Alex Christensen Date: 2023-02-23 (Thu, 23 Feb 2023) Changed paths: M Source/WebCore/page/Page.cpp M Source/WebCore/page/Page.h Log Message: --- Page::m_mainFrame should be an AbstractFrame https://bugs.webkit.org/show_bug.cgi?id=252840 rdar://105839964 Reviewed by Chris Dumez. * Source/WebCore/page/Page.cpp: (WebCore::Page::~Page): (WebCore::Page::scrollingStateTreeAsText): (WebCore::Page::synchronousScrollingReasonsAsText): (WebCore::Page::nonFastScrollableRectsForTesting): (WebCore::Page::touchEventRectsForEventForTesting): (WebCore::Page::passiveTouchEventListenerRectsForTesting): (WebCore::Page::goToItem): (WebCore::Page::analyzeImagesForFindInPage): (WebCore::Page::layoutIfNeeded): (WebCore::Page::mediaSessionGroupIdentifier const): (WebCore::Page::setActivityState): (WebCore::Page::setSessionID): (WebCore::Page::dispatchBeforePrintEvent): (WebCore::Page::dispatchAfterPrintEvent): (WebCore::Page::configureLoggingChannel): (WebCore::Page::injectUserStyleSheet): (WebCore::Page::removeInjectedUserStyleSheet): (WebCore::Page::mainFrameDidChangeToNonInitialEmptyDocument): (WebCore::Page::reloadExecutionContextsForOrigin const): * Source/WebCore/page/Page.h: Canonical link: https://commits.webkit.org/260767@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 0a69bf: Cherry-pick dddab8f85b40. rdar://problem/105843507
Branch: refs/heads/safari-7616.1.3-branch Home: https://github.com/WebKit/WebKit Commit: 0a69bf63d56e2f52e0a79ec29e71fc554db05522 https://github.com/WebKit/WebKit/commit/0a69bf63d56e2f52e0a79ec29e71fc554db05522 Author: Chris Dumez Date: 2023-02-23 (Thu, 23 Feb 2023) Changed paths: M Source/WebCore/platform/graphics/transforms/TransformationMatrix.cpp Log Message: --- Cherry-pick dddab8f85b40. rdar://problem/105843507 Revert [260468@main] Optimize TransformationMatrix inverse on ARM64 https://bugs.webkit.org/show_bug.cgi?id=252487 rdar://105843507 Unreviewed, revert 260468@main as it seems to have caused . * Source/WebCore/platform/graphics/transforms/TransformationMatrix.cpp: (WebCore::adjoint): (WebCore::inverse): (WebCore::TransformationMatrix::multiply): Canonical link: https://commits.webkit.org/260765@main Canonical link: https://commits.webkit.org/260516.5@safari-7616.1.3-branch ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] ca0583: Versioning.
Branch: refs/heads/safari-7616.1.3-branch Home: https://github.com/WebKit/WebKit Commit: ca0583107c908979c8319f87cd4d63398d7eb813 https://github.com/WebKit/WebKit/commit/ca0583107c908979c8319f87cd4d63398d7eb813 Author: Russell Epstein Date: 2023-02-23 (Thu, 23 Feb 2023) Changed paths: M Configurations/Version.xcconfig Log Message: --- Versioning. WebKit-7616.1.3.1 Canonical link: https://commits.webkit.org/260516.4@safari-7616.1.3-branch ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 2a4bd9: Disable body to root background propagation when `...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 2a4bd98a580e6517634eb4f04dc6f4d7f695212c https://github.com/WebKit/WebKit/commit/2a4bd98a580e6517634eb4f04dc6f4d7f695212c Author: Rob Buis Date: 2023-02-23 (Thu, 23 Feb 2023) Changed paths: A LayoutTests/imported/w3c/web-platform-tests/css/css-backgrounds/background-color-body-propagation-008-expected.html A LayoutTests/imported/w3c/web-platform-tests/css/css-backgrounds/background-color-body-propagation-008.html A LayoutTests/imported/w3c/web-platform-tests/css/css-backgrounds/background-color-body-propagation-009-expected.html A LayoutTests/imported/w3c/web-platform-tests/css/css-backgrounds/background-color-body-propagation-009.html M Source/WebCore/rendering/BackgroundPainter.cpp Log Message: --- Disable body to root background propagation when `content:paint` is set on body or the root https://bugs.webkit.org/show_bug.cgi?id=252733 Reviewed by Tim Nguyen. Disable body to root background propagation when `content:paint` is set on body or the root [1]. [1] https://drafts.csswg.org/css-contain-1/#contain-property (proposed correction 3) * LayoutTests/imported/w3c/web-platform-tests/css/css-backgrounds/background-color-body-propagation-008-expected.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-backgrounds/background-color-body-propagation-008.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-backgrounds/background-color-body-propagation-009-expected.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-backgrounds/background-color-body-propagation-009.html: Added. * Source/WebCore/rendering/BackgroundPainter.cpp: (WebCore::BackgroundPainter::paintsOwnBackground): Canonical link: https://commits.webkit.org/260766@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] dddab8: Revert [260468@main] Optimize TransformationMatrix...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: dddab8f85b40cbb8d99a267a748c28a40f864d6c https://github.com/WebKit/WebKit/commit/dddab8f85b40cbb8d99a267a748c28a40f864d6c Author: Chris Dumez Date: 2023-02-23 (Thu, 23 Feb 2023) Changed paths: M Source/WebCore/platform/graphics/transforms/TransformationMatrix.cpp Log Message: --- Revert [260468@main] Optimize TransformationMatrix inverse on ARM64 https://bugs.webkit.org/show_bug.cgi?id=252487 rdar://105843507 Unreviewed, revert 260468@main as it seems to have caused . * Source/WebCore/platform/graphics/transforms/TransformationMatrix.cpp: (WebCore::adjoint): (WebCore::inverse): (WebCore::TransformationMatrix::multiply): Canonical link: https://commits.webkit.org/260765@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] c33728: Remove an unused helper method: `NetworkSession::n...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: c337286d5952d1cd86b2ceba21c0842ac7f2c09e https://github.com/WebKit/WebKit/commit/c337286d5952d1cd86b2ceba21c0842ac7f2c09e Author: Wenson Hsieh Date: 2023-02-23 (Thu, 23 Feb 2023) Changed paths: M Source/WebKit/NetworkProcess/NetworkSession.cpp M Source/WebKit/NetworkProcess/NetworkSession.h Log Message: --- Remove an unused helper method: `NetworkSession::needsAdditionalNetworkConnectionIntegritySettings` https://bugs.webkit.org/show_bug.cgi?id=252825 rdar://105806612 Reviewed by Aditya Keerthi and Tim Horton. Remove a static helper method that's no longer used. * Source/WebKit/NetworkProcess/NetworkSession.cpp: (WebKit::NetworkSession::needsAdditionalNetworkConnectionIntegritySettings): Deleted. Canonical link: https://commits.webkit.org/260764@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 7be92e: Implement Login with GitHub on build.webkit.org
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 7be92ea7008d99047bd075d5f758ab9487cbc197 https://github.com/WebKit/WebKit/commit/7be92ea7008d99047bd075d5f758ab9487cbc197 Author: Aakash Jain Date: 2023-02-23 (Thu, 23 Feb 2023) Changed paths: M Tools/CISupport/build-webkit-org/master.cfg Log Message: --- Implement Login with GitHub on build.webkit.org https://bugs.webkit.org/show_bug.cgi?id=252778 Reviewed by Ryan Haddad. References: https://docs.buildbot.net/latest/developer/auth.html https://docs.buildbot.net/current/manual/configuration/www.html#authorization-rules * Tools/CISupport/build-webkit-org/master.cfg: Canonical link: https://commits.webkit.org/260763@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] eac81f: Have RemoteLayerTreeEventDispatcher start and stop...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: eac81f7d7c8d4eb9040ee21a0c94530228ef30ac https://github.com/WebKit/WebKit/commit/eac81f7d7c8d4eb9040ee21a0c94530228ef30ac Author: Simon Fraser Date: 2023-02-23 (Thu, 23 Feb 2023) Changed paths: M Source/WebKit/UIProcess/RemoteLayerTree/mac/RemoteLayerTreeEventDispatcher.cpp M Source/WebKit/UIProcess/RemoteLayerTree/mac/RemoteLayerTreeEventDispatcher.h Log Message: --- Have RemoteLayerTreeEventDispatcher start and stop a DisplayLink callback https://bugs.webkit.org/show_bug.cgi?id=252796 Reviewed by Myles C. Maxfield. RemoteLayerTreeEventDispatcher needs its own DisplayLink::Client because it needs to bounce the callbacks to the scrolling thread. So have RemoteLayerTreeEventDispatcher create a RemoteLayerTreeEventDispatcherDisplayLinkClient which receives the callback, taking care to make the invalidation code path thread safe. We start and stop the callback currently just for scroll animations; future patches will actually hook this up, and add more reasons to run a callback. * Source/WebKit/UIProcess/RemoteLayerTree/mac/RemoteLayerTreeEventDispatcher.cpp: (WebKit::m_displayLinkClient): (WebKit::RemoteLayerTreeEventDispatcher::invalidate): (WebKit::RemoteLayerTreeEventDispatcher::displayLink const): (WebKit::RemoteLayerTreeEventDispatcher::startOrStopDisplayLink): (WebKit::RemoteLayerTreeEventDispatcher::startDisplayLinkObserver): (WebKit::RemoteLayerTreeEventDispatcher::stopDisplayLinkObserver): (WebKit::m_wheelEventDeltaFilter): Deleted. * Source/WebKit/UIProcess/RemoteLayerTree/mac/RemoteLayerTreeEventDispatcher.h: Canonical link: https://commits.webkit.org/260762@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] f9b1ad: [Image Set]: Refactor CSSImageSetValue to accept o...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: f9b1ad4c0847a6799049abdb764a5ca7367b4800 https://github.com/WebKit/WebKit/commit/f9b1ad4c0847a6799049abdb764a5ca7367b4800 Author: Ryan Reno Date: 2023-02-23 (Thu, 23 Feb 2023) Changed paths: M LayoutTests/TestExpectations M LayoutTests/fast/css/image-set-parsing-expected.txt R LayoutTests/fast/css/image-set-parsing-generated-expected.txt R LayoutTests/fast/css/image-set-parsing-generated.html M LayoutTests/fast/css/image-set-parsing.html M LayoutTests/imported/w3c/web-platform-tests/css/css-images/image-set/image-set-parsing-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/css-images/image-set/image-set-parsing.html M Source/WebCore/Sources.txt M Source/WebCore/WebCore.xcodeproj/project.pbxproj A Source/WebCore/css/CSSImageSetOptionValue.cpp A Source/WebCore/css/CSSImageSetOptionValue.h M Source/WebCore/css/CSSImageSetValue.cpp M Source/WebCore/css/CSSValue.cpp M Source/WebCore/css/CSSValue.h M Source/WebCore/css/CSSValuePair.cpp M Source/WebCore/css/calc/CSSCalcPrimitiveValueNode.cpp M Source/WebCore/css/parser/CSSPropertyParser.cpp M Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp M Source/WebCore/rendering/style/StyleImageSet.cpp Log Message: --- [Image Set]: Refactor CSSImageSetValue to accept optional resolution and MIME type parameters https://bugs.webkit.org/show_bug.cgi?id=252137 rdar://105367742 Reviewed by Antti Koivisto. The standardized image-set differs from -webkit-image-set in that each option has three arguments instead of two - an image, an optional resolution, and an optional type() function declaring the MIME type of the image. This refactors the CSSImageSetValue to hold an CSSImageSetOptionValue object instead of placing the image and resolution values in a vector and using a stride of 2 to represent each option. The actual parsing of resolution and type() will be in a follow-on patch. * LayoutTests/TestExpectations: Unskip newly passing WPT ref tests. * LayoutTests/fast/css/image-set-parsing-expected.txt: * LayoutTests/fast/css/image-set-parsing-generated-expected.txt: Removed. * LayoutTests/fast/css/image-set-parsing-generated.html: Removed. * LayoutTests/fast/css/image-set-parsing.html: * LayoutTests/imported/w3c/web-platform-tests/css/css-images/image-set/image-set-parsing-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-images/image-set/image-set-parsing.html: Refactor the internal parsing tests in the following ways: 1) Move and dedup all tests of standard properties (e.g. background-image) to WPT. 2) Move generated image tests (gradients, for example) to the main image-set-parsing test. 3) Test that -webkit-image-set is an alias to image-set 4) Test that the serialization is as expected (per WPT). * Source/WebCore/css/CSSImageSetOptionValue.cpp: Added. (WebCore::CSSImageSetOptionValue::Type::Type): (WebCore::CSSImageSetOptionValue::Type::cssText const): (WebCore::CSSImageSetOptionValue::CSSImageSetOptionValue): (WebCore::CSSImageSetOptionValue::create): (WebCore::CSSImageSetOptionValue::equals const): (WebCore::CSSImageSetOptionValue::customCSSText const): (WebCore::CSSImageSetOptionValue::image const): (WebCore::CSSImageSetOptionValue::resolution const): (WebCore::CSSImageSetOptionValue::setResolution): (WebCore::CSSImageSetOptionValue::type const): (WebCore::CSSImageSetOptionValue::setType): * Source/WebCore/css/CSSImageSetOptionValue.h: Copied from Source/WebCore/css/CSSImageSetValue.h. Create a new CSSImageSetOptionValue class to represent the arguments to the image-set function. This object holds a Ref to either a CSSImageValue or a generated image (e.g. a linear-gradient), and optionally holds a resolution (scale factor) and a MIME type string. * Source/WebCore/css/CSSImageSetValue.cpp: (WebCore::CSSImageSetValue::create): (WebCore::CSSImageSetValue::CSSImageSetValue): (WebCore::CSSImageSetValue::customCSSText const): (WebCore::CSSImageSetValue::createStyleImage const): * Source/WebCore/css/CSSImageSetValue.h: With -webkit-image-set, the image and resolution were the only two arguments and they were both required. The standardized image-set makes resolution and type optional. Instead of holding all the arguments as individual elements in the underlying CSSListValue storage we hold the new CSSImageSetOptionValues in the internal vector instead. We also now filter the image set on provided MIME type if it's supported or not when creating the StyleImage. * Source/WebCore/css/CSSValue.cpp: (WebCore::CSSValue::visitDerived): * Source/WebCore/css/CSSValue.h: (WebCore::CSSValue::isImageSetOptionValue const): Updates for support for the new CSSImageSetOptionValue. * Source/WebCore/css/calc/CSSCalcPrimitiveValueNode.cpp: * Source/WebCore/css/parser/CSSPropertyParser.
[webkit-changes] [WebKit/WebKit] 41bb68: Implement link rel=modulepreload
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 41bb68d54e7ad6d6fe27df4200c2e8721b9aafb0 https://github.com/WebKit/WebKit/commit/41bb68d54e7ad6d6fe27df4200c2e8721b9aafb0 Author: Ryosuke Niwa Date: 2023-02-23 (Thu, 23 Feb 2023) Changed paths: M Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml Log Message: --- Implement link rel=modulepreload https://bugs.webkit.org/show_bug.cgi?id=180574 Reviewed by Yusuke Suzuki. Enable this feature by default. * Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml: Canonical link: https://commits.webkit.org/260761@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 9e54e0: WebProcessPool::processForNavigation() should prev...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 9e54e083d6c2a6f1120bec7715edb0b0b48cd344 https://github.com/WebKit/WebKit/commit/9e54e083d6c2a6f1120bec7715edb0b0b48cd344 Author: Chris Dumez Date: 2023-02-23 (Thu, 23 Feb 2023) Changed paths: M Source/WebKit/UIProcess/WebProcessPool.cpp Log Message: --- WebProcessPool::processForNavigation() should prevent the process from getting shut down while waiting for AddAllowedFirstPartyForCookies IPC reply https://bugs.webkit.org/show_bug.cgi?id=252843 rdar://105375981 Reviewed by Alex Christensen. ebProcessPool::processForNavigation() should prevent the process from getting shut down (or added to the process cache) while waiting for AddAllowedFirstPartyForCookies IPC reply. We recently fixed the lambda in WebPageProxy::triggerBrowsingContextGroupSwitchForNavigation() but failed to fix this one. * Source/WebKit/UIProcess/WebProcessPool.cpp: (WebKit::WebProcessPool::processForNavigation): Canonical link: https://commits.webkit.org/260754@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] fd0581: [web-animations] mask-image should support discret...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: fd0581b4940cf7594443c2f7b3503a26d4df8c58 https://github.com/WebKit/WebKit/commit/fd0581b4940cf7594443c2f7b3503a26d4df8c58 Author: Antoine Quint Date: 2023-02-23 (Thu, 23 Feb 2023) Changed paths: R LayoutTests/animations/cross-fade-webkit-mask-image-expected.txt R LayoutTests/animations/cross-fade-webkit-mask-image.html M LayoutTests/imported/w3c/web-platform-tests/css/css-backgrounds/animations/background-image-interpolation-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/css-masking/animations/mask-image-interpolation-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/css-masking/animations/mask-image-interpolation.html M LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property-002-expected.txt M LayoutTests/platform/glib/imported/w3c/web-platform-tests/css/css-backgrounds/animations/background-image-interpolation-expected.txt R LayoutTests/platform/glib/imported/w3c/web-platform-tests/css/css-masking/animations/mask-image-interpolation-expected.txt M LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property-002-expected.txt M Source/WebCore/animation/CSSPropertyAnimation.cpp Log Message: --- [web-animations] mask-image should support discrete animation https://bugs.webkit.org/show_bug.cgi?id=252656 Reviewed by Dean Jackson. While specifications dictate that properties have a discrete animation type, we actually interpolate such values by producing a -webkit-cross-fade() value. Chrome also does that, while Firefox adheres to the spec. However, in the case of mask-image, Chrome does not cross fade and adheres to the spec, making WebKit the outlier. We should align with the spec in this regard, which frankly makes more sense than cross-fading an image used as a mask and thus not rendered. We had to fix FillLayersPropertyWrapper which incorrectly assumed that the RenderStyle into which we were blending would have the same number of background or mask layers as the from and to values. We now correctly repeat previous layers as needed to accommodate for the length of the from and to values. Fixing this showed that the WPT test css/css-masking/animations/mask-image-interpolation.html was incorrect. While it correctly checked the discrete behavior where from / to values switch at the 0.5 progress mark, it failed to use test_no_interpolation() and thus expected interpolation for CSS Transitions instead of no transition. Finally, we remove animations/cross-fade-webkit-mask-image.html which is entirely superseded by WPT tests. * LayoutTests/animations/cross-fade-webkit-mask-image-expected.txt: Removed. * LayoutTests/animations/cross-fade-webkit-mask-image.html: Removed. * LayoutTests/imported/w3c/web-platform-tests/css/css-backgrounds/animations/background-image-interpolation-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-masking/animations/mask-image-interpolation-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-masking/animations/mask-image-interpolation.html: * LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property-002-expected.txt: * LayoutTests/platform/glib/imported/w3c/web-platform-tests/css/css-backgrounds/animations/background-image-interpolation-expected.txt: * LayoutTests/platform/glib/imported/w3c/web-platform-tests/css/css-masking/animations/mask-image-interpolation-expected.txt: Removed. * LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property-002-expected.txt: * Source/WebCore/animation/CSSPropertyAnimation.cpp: Canonical link: https://commits.webkit.org/260756@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 875f1e: The animation of CSS custom properties is not vali...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 875f1eabd79a095748da329ba181c75a27ae6d02 https://github.com/WebKit/WebKit/commit/875f1eabd79a095748da329ba181c75a27ae6d02 Author: Antoine Quint Date: 2023-02-23 (Thu, 23 Feb 2023) Changed paths: A LayoutTests/imported/w3c/web-platform-tests/css/css-properties-values-api/animation/custom-property-animation-used-in-shorthand-expected.txt A LayoutTests/imported/w3c/web-platform-tests/css/css-properties-values-api/animation/custom-property-animation-used-in-shorthand.html M Source/WebCore/style/PropertyCascade.cpp Log Message: --- The animation of CSS custom properties is not valid in the shorthand property https://bugs.webkit.org/show_bug.cgi?id=252808 Reviewed by Antti Koivisto. * LayoutTests/imported/w3c/web-platform-tests/css/css-properties-values-api/animation/custom-property-animation-used-in-shorthand-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-properties-values-api/animation/custom-property-animation-used-in-shorthand.html: Added. * Source/WebCore/style/PropertyCascade.cpp: (WebCore::Style::PropertyCascade::shouldApplyAfterAnimation): Canonical link: https://commits.webkit.org/260759@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 08509e: [web-animations] rewrite tests under LayoutTests/w...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 08509e730a888f16b662c2eede9b6f10d5b28604 https://github.com/WebKit/WebKit/commit/08509e730a888f16b662c2eede9b6f10d5b28604 Author: Antoine Quint Date: 2023-02-23 (Thu, 23 Feb 2023) Changed paths: M LayoutTests/webanimations/accelerated-animation-removal-upon-transition-completion.html M LayoutTests/webanimations/accelerated-animation-suspension.html M LayoutTests/webanimations/css-animation-dynamic-duration-change.html M LayoutTests/webanimations/css-transition-in-flight-reversal-accelerated.html M LayoutTests/webanimations/no-scheduling-while-filling-accelerated.html M LayoutTests/webanimations/no-scheduling-while-filling-non-accelerated.html A LayoutTests/webanimations/resources/rendering-frames.js M LayoutTests/webanimations/transform-animation-with-steps-timing-function-not-accelerated.html Log Message: --- [web-animations] rewrite tests under LayoutTests/webanimations to use promise_test instead of async_test https://bugs.webkit.org/show_bug.cgi?id=252806 Reviewed by Dean Jackson. We should stay clear of async_test() which will cause timeouts in case of assertion failures while promise_test() just ends the test. * LayoutTests/webanimations/accelerated-animation-removal-upon-transition-completion.html: * LayoutTests/webanimations/accelerated-animation-suspension.html: * LayoutTests/webanimations/css-animation-dynamic-duration-change.html: * LayoutTests/webanimations/css-transition-in-flight-reversal-accelerated.html: * LayoutTests/webanimations/no-scheduling-while-filling-accelerated.html: * LayoutTests/webanimations/no-scheduling-while-filling-non-accelerated.html: * LayoutTests/webanimations/resources/rendering-frames.js: Added. (const.renderingFrames.async numberOfFrames.return.new.Promise): (const.renderingFrames.async numberOfFrames): * LayoutTests/webanimations/transform-animation-with-steps-timing-function-not-accelerated.html: Canonical link: https://commits.webkit.org/260758@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 218530: Web Inspector: Reorganize Web Inspector-scoped dev...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 218530454da476df1d7d2a2c20c5fd58e880b105 https://github.com/WebKit/WebKit/commit/218530454da476df1d7d2a2c20c5fd58e880b105 Author: Razvan Caliman Date: 2023-02-23 (Thu, 23 Feb 2023) Changed paths: M Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js M Source/WebInspectorUI/UserInterface/Base/Main.js A Source/WebInspectorUI/UserInterface/Controllers/DeviceSettingsManager.js M Source/WebInspectorUI/UserInterface/Main.html M Source/WebInspectorUI/UserInterface/Test.html M Source/WebInspectorUI/UserInterface/Views/Main.css A Source/WebInspectorUI/UserInterface/Views/OverrideDeviceSettingsPopover.css A Source/WebInspectorUI/UserInterface/Views/OverrideDeviceSettingsPopover.js M Source/WebInspectorUI/UserInterface/Views/OverrideUserPreferencesPopover.css M Source/WebInspectorUI/UserInterface/Views/OverrideUserPreferencesPopover.js A Source/WebInspectorUI/UserInterface/Views/SettingsPopover.css A Source/WebInspectorUI/UserInterface/Views/SettingsPopover.js Log Message: --- Web Inspector: Reorganize Web Inspector-scoped device settings https://bugs.webkit.org/show_bug.cgi?id=252440 Reviewed by Devin Rousso. Reorganizes the device settings popover to show settings appropriate to the inspected target. Reuses styles from the popover for user preferences overrides. Settings are copied verbatim from `Main.js`, organized into groups, and moved to the new `WI.OverrideDeviceSettingsPopover`. Labels are updated. A new `WI.DeviceSettingsManager` is introduced to manage the collection of device settings, user agent, and screen size overrides, previously kept in `Main.js`. It also holds the responsibility to apply overrides on target initalization. The methods to set overrides are moved mostly unchanged from `Main.js` to WI.DeviceSettingsManager`: ``` function applyOverriddenUserAgent() -> DeviceSettingsManager.overrideUserAgent() function applyOverriddenSetting() -> DeviceSettingsManager.overrideSetting() function applyOverriddenScreenSize() -> DeviceSettingsManager.overrideScreenSize() ``` A generalized `WI.SettingsPopover` is extracted from `WI.OverrideUserPreferencesPopover` to handle showing and positioning the popover. The content is provided by subclasses. A new `WI.OverrideDeviceSettingsPopover` is introduced to show settings appropriate to the inspected target. More settings are shown in the popover for remote targets. For local inspection, most of these settings are available in the develop menu. The capability to override screen sizes is available only for non-Cocoa platforms. The code for setting this override is copied verbatim and adapted slightly to use the new `WI.DeviceSettingsManager`. * Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js: * Source/WebInspectorUI/UserInterface/Base/Main.js: (WI.loaded): (WI.initializeTarget): Most of the code from `Main.js` has moved to `WI.DeviceSettingsManager` and `WI.OverrideDeviceSettingsPopover` according to responsibilites (controller or view). * Source/WebInspectorUI/UserInterface/Controllers/DeviceSettingsManager.js: Added. (WI.DeviceSettingsManager): (WI.DeviceSettingsManager.prototype.initializeTarget): (WI.DeviceSettingsManager.supportsSetScreenSizeOverride): (WI.DeviceSettingsManager.prototype.get defaultSettingsChanged): (WI.DeviceSettingsManager.prototype.get overridenDeviceUserAgent): (WI.DeviceSettingsManager.prototype.get overridenDeviceScreenSize): (WI.DeviceSettingsManager.prototype.get overridenDeviceSettings): (WI.DeviceSettingsManager.prototype.overrideDeviceSetting): (WI.DeviceSettingsManager.prototype.overrideUserAgent): (WI.DeviceSettingsManager.prototype.overrideScreenSize): * Source/WebInspectorUI/UserInterface/Main.html: * Source/WebInspectorUI/UserInterface/Test.html: * Source/WebInspectorUI/UserInterface/Views/Main.css: (.device-settings-content): Deleted. (.device-settings-content > table): Deleted. (.device-settings-content > table > tr > td:first-child): Deleted. (.device-settings-content .container): Deleted. (.device-settings-content .container > * + *): Deleted. (.device-settings-content .column): Deleted. (.device-settings-content .user-agent select): Deleted. (.device-settings-content .user-agent input): Deleted. (.device-settings-content label + label): Deleted. (.device-settings-content label > input): Deleted. (.device-settings-content > .reference-page-link-container): Deleted. Removed styles for device settings popover from `Main.css` and replaced with streamlined styles in `SettingsPopover.css` and `OverrideDeviceSettingsPopover.css`. * Source/WebInspectorUI/UserInterface/Views/OverrideDeviceSettingsPopover.css: Copied from Source/WebInspectorUI/UserInterface/Views/OverrideUserPreferencesPopover.css. (.popover .settings-content:is(.device-settings-content) > label): (.popover .settings-content:is(.device-settings-conten
[webkit-changes] [WebKit/WebKit] 44689f: [GStreamer][Westeros] Fix westeros-sink autoplug w...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 44689f99af554d71142a177c6b5fe65ca8ee755b https://github.com/WebKit/WebKit/commit/44689f99af554d71142a177c6b5fe65ca8ee755b Author: Xabier Rodriguez-Calvar Date: 2023-02-23 (Thu, 23 Feb 2023) Changed paths: M Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp Log Message: --- [GStreamer][Westeros] Fix westeros-sink autoplug with playbin3 https://bugs.webkit.org/show_bug.cgi?id=252836 Reviewed by Philippe Normand. Original patch by Eugene Mutavchi . * Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivateGStreamer::configureElementPlatformQuirks): Canonical link: https://commits.webkit.org/260755@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] a3e54f: Fix RequestPriority.idl
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: a3e54f4f093ca550897154a514ebc4b42d75839d https://github.com/WebKit/WebKit/commit/a3e54f4f093ca550897154a514ebc4b42d75839d Author: Rob Buis Date: 2023-02-23 (Thu, 23 Feb 2023) Changed paths: M Source/WebCore/Modules/fetch/RequestPriority.idl Log Message: --- Fix RequestPriority.idl https://bugs.webkit.org/show_bug.cgi?id=252832 Reviewed by Chris Dumez. Correct an idl mistake from r260666. * Source/WebCore/Modules/fetch/RequestPriority.idl: Canonical link: https://commits.webkit.org/260753@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 380e2f: Clarify WebPageProxy wheel event code for UI-side ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 380e2f6bed60dc8af9193a12c8945b8bf1904796 https://github.com/WebKit/WebKit/commit/380e2f6bed60dc8af9193a12c8945b8bf1904796 Author: Simon Fraser Date: 2023-02-23 (Thu, 23 Feb 2023) Changed paths: M Source/WebKit/UIProcess/WebPageProxy.cpp M Source/WebKit/UIProcess/WebPageProxy.h M Source/WebKit/WebProcess/WebPage/WebPage.cpp M Source/WebKit/WebProcess/WebPage/WebPage.h M Source/WebKit/WebProcess/WebPage/WebPage.messages.in Log Message: --- Clarify WebPageProxy wheel event code for UI-side compositing https://bugs.webkit.org/show_bug.cgi?id=252703 rdar://105752960 Reviewed by Tim Horton. Make use of DrawingAreaProxy::shouldSendWheelEventsToEventDispatcher() to conditionalize code in WebPageProxy, making it clear that we only call into m_scrollingCoordinatorProxy if we're not sending events to the EventDispatcher, and that we don't need to send ScrollingAccelerationCurves to the web process with UI-side compositing. Also dispatchWheelEventWithoutScrolling() is only used on iOS, so #ifdef it for clarity. * Source/WebKit/UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::handleWheelEvent): (WebKit::WebPageProxy::sendWheelEvent): * Source/WebKit/UIProcess/WebPageProxy.h: * Source/WebKit/WebProcess/WebPage/WebPage.cpp: * Source/WebKit/WebProcess/WebPage/WebPage.h: * Source/WebKit/WebProcess/WebPage/WebPage.messages.in: Canonical link: https://commits.webkit.org/260752@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 3168f2: Continue porting WebKit/ related types to the new ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 3168f2acf3cb7416bbe4af15c1285896f2367144 https://github.com/WebKit/WebKit/commit/3168f2acf3cb7416bbe4af15c1285896f2367144 Author: Gavin Phillips Date: 2023-02-23 (Thu, 23 Feb 2023) Changed paths: M Source/WebKit/CMakeLists.txt M Source/WebKit/DerivedSources-input.xcfilelist M Source/WebKit/DerivedSources.make M Source/WebKit/NetworkProcess/NetworkProcess.cpp M Source/WebKit/NetworkProcess/NetworkProcess.h M Source/WebKit/NetworkProcess/NetworkProcess.messages.in M Source/WebKit/Shared/Gamepad/GamepadData.cpp M Source/WebKit/Shared/Gamepad/GamepadData.h A Source/WebKit/Shared/Gamepad/GamepadData.serialization.in R Source/WebKit/Shared/NavigationActionData.cpp M Source/WebKit/Shared/NavigationActionData.h A Source/WebKit/Shared/NavigationActionData.serialization.in R Source/WebKit/Shared/PlatformPopupMenuData.cpp M Source/WebKit/Shared/PlatformPopupMenuData.h A Source/WebKit/Shared/PlatformPopupMenuData.serialization.in M Source/WebKit/Shared/TouchBarMenuItemData.cpp M Source/WebKit/Shared/TouchBarMenuItemData.h A Source/WebKit/Shared/TouchBarMenuItemData.serialization.in M Source/WebKit/Shared/WebsiteData/WebsiteData.cpp M Source/WebKit/Shared/WebsiteData/WebsiteData.h A Source/WebKit/Shared/WebsiteData/WebsiteData.serialization.in M Source/WebKit/Shared/WebsiteData/WebsiteDataType.h A Source/WebKit/Shared/WebsiteData/WebsiteDataType.serialization.in M Source/WebKit/Shared/ios/WebAutocorrectionData.h R Source/WebKit/Shared/ios/WebAutocorrectionData.mm A Source/WebKit/Shared/ios/WebAutocorrectionData.serialization.in M Source/WebKit/Sources.txt M Source/WebKit/SourcesCocoa.txt M Source/WebKit/UIProcess/API/Cocoa/WKWebsiteDataStore.mm M Source/WebKit/UIProcess/Network/NetworkProcessProxy.cpp M Source/WebKit/UIProcess/Network/NetworkProcessProxy.h M Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.cpp M Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.h M Source/WebKit/WebKit.xcodeproj/project.pbxproj Log Message: --- Continue porting WebKit/ related types to the new IPC serialization format https://bugs.webkit.org/show_bug.cgi?id=252742 rdar://105776889 Reviewed by Alex Christensen. This change includes porting across the following types to the new serialization format: - GamepadData - WebAutocorrectionData - NavigationActionData - PlatformPopupMenuData - ItemType - TouchBarMenuItemData - WebsiteData::Entry - WebsiteData - WebsiteDataType * Source/WebKit/CMakeLists.txt: * Source/WebKit/DerivedSources-input.xcfilelist: * Source/WebKit/DerivedSources.make: * Source/WebKit/NetworkProcess/NetworkProcess.cpp: (WebKit::NetworkProcess::hasLocalStorage): (WebKit::NetworkProcess::registrableDomainsWithWebsiteData): (WebKit::NetworkProcess::websiteDataOriginDirectoryForTesting): * Source/WebKit/NetworkProcess/NetworkProcess.h: * Source/WebKit/NetworkProcess/NetworkProcess.messages.in: * Source/WebKit/Shared/Gamepad/GamepadData.cpp: (WebKit::GamepadData::GamepadData): (WebKit::GamepadData::encode const): Deleted. (WebKit::GamepadData::decode): Deleted. * Source/WebKit/Shared/Gamepad/GamepadData.h: * Source/WebKit/Shared/Gamepad/GamepadData.serialization.in: Added. * Source/WebKit/Shared/NavigationActionData.cpp: Removed. * Source/WebKit/Shared/NavigationActionData.h: * Source/WebKit/Shared/NavigationActionData.serialization.in: Added. * Source/WebKit/Shared/PlatformPopupMenuData.cpp: Removed. * Source/WebKit/Shared/PlatformPopupMenuData.h: * Source/WebKit/Shared/PlatformPopupMenuData.serialization.in: Added. * Source/WebKit/Shared/TouchBarMenuItemData.cpp: (WebKit::TouchBarMenuItemData::TouchBarMenuItemData): (WebKit::TouchBarMenuItemData::encode const): Deleted. (WebKit::TouchBarMenuItemData::decode): Deleted. * Source/WebKit/Shared/TouchBarMenuItemData.h: * Source/WebKit/Shared/TouchBarMenuItemData.serialization.in: Added. * Source/WebKit/Shared/WebsiteData/WebsiteData.cpp: (WebKit::WebsiteData::Entry::Entry): (WebKit::WebsiteData::Entry::isolatedCopy const): (WebKit::WebsiteData::Entry::isolatedCopy): (WebKit::WebsiteData::Entry::encode const): Deleted. (WebKit::WebsiteData::Entry::decode): Deleted. (WebKit::WebsiteData::encode const): Deleted. (WebKit::WebsiteData::decode): Deleted. * Source/WebKit/Shared/WebsiteData/WebsiteData.h: (WebKit::WebsiteData::Entry::type const): * Source/WebKit/Shared/WebsiteData/WebsiteData.serialization.in: Added. * Source/WebKit/Shared/WebsiteData/WebsiteDataType.h: * Source/WebKit/Shared/WebsiteData/WebsiteDataType.serialization.in: Added. * Source/WebKit/Shared/ios/WebAutocorrectionData.h: * Source/WebKit/Shared/ios/WebAutocorrectionData.mm: Removed. * Source/WebKit/Shared/ios/WebAutocorrectionData.serialization.in: Added. * Source/WebKit/Sources.txt: * Source/WebKit/SourcesCocoa.txt: * Source/W
[webkit-changes] [WebKit/WebKit] 291555: [ macOS, iOS ] media/video-object-fit.html is a co...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 291555070761b25cba62a0d66d223637991986a4 https://github.com/WebKit/WebKit/commit/291555070761b25cba62a0d66d223637991986a4 Author: Bri Harris Date: 2023-02-23 (Thu, 23 Feb 2023) Changed paths: M LayoutTests/platform/ios/TestExpectations M LayoutTests/platform/mac/TestExpectations Log Message: --- [ macOS, iOS ] media/video-object-fit.html is a constant ImageOnly failure. rdar://105838607 https://bugs.webkit.org/show_bug.cgi?id=252839 Unreviewed test gardening. Setting expectations for failing tests. * LayoutTests/platform/ios/TestExpectations: * LayoutTests/platform/mac/TestExpectations: Canonical link: https://commits.webkit.org/260750@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] af221f: [ iOS ] media/video-element-fullscreen-not-in-dom-...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: af221f1762400149b9806d03814c2c5c266573b8 https://github.com/WebKit/WebKit/commit/af221f1762400149b9806d03814c2c5c266573b8 Author: Bri Harris Date: 2023-02-23 (Thu, 23 Feb 2023) Changed paths: M LayoutTests/platform/ios/TestExpectations Log Message: --- [ iOS ] media/video-element-fullscreen-not-in-dom-accelerated-iphone.html is a constant failure. rdar://105838163 https://bugs.webkit.org/show_bug.cgi?id=252837 Unreviewed test gardening. Setting expectations for failing test. * LayoutTests/platform/ios/TestExpectations: Canonical link: https://commits.webkit.org/260749@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 4cf88a: Cherry-pick 31fc634e822a. rdar://problem/105727098
Branch: refs/tags/WebKit-7616.1.3 Home: https://github.com/WebKit/WebKit Commit: 4cf88a702c9c185e18ff9797ecb5a833dc9a363c https://github.com/WebKit/WebKit/commit/4cf88a702c9c185e18ff9797ecb5a833dc9a363c Author: Yusuke Suzuki Date: 2023-02-21 (Tue, 21 Feb 2023) Changed paths: M Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp Log Message: --- Cherry-pick 31fc634e822a. rdar://problem/105727098 Unreviewed, disable bound function call inlining until tail call issue gets fixed https://bugs.webkit.org/show_bug.cgi?id=252693 rdar://105727098 * Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp: (JSC::DFG::ByteCodeParser::handleIntrinsicCall): Canonical link: https://commits.webkit.org/260635@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 01b10b: Fix inefficient uses of Vector::fill()
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 01b10b7f0e65f07e683f779755f4818487def6b8 https://github.com/WebKit/WebKit/commit/01b10b7f0e65f07e683f779755f4818487def6b8 Author: Chris Dumez Date: 2023-02-23 (Thu, 23 Feb 2023) Changed paths: M Source/JavaScriptCore/b3/air/AirAllocateRegistersByGraphColoring.cpp M Source/JavaScriptCore/b3/air/AirUseCounts.h M Source/JavaScriptCore/bytecode/Operands.h M Source/JavaScriptCore/dfg/DFGScoreBoard.h M Source/JavaScriptCore/wasm/js/JSWebAssemblyStruct.cpp M Source/WTF/wtf/FastBitVector.h M Source/WTF/wtf/FixedVector.h M Source/WTF/wtf/IndexMap.h M Source/WebCore/platform/audio/IIRFilter.cpp M Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp M Source/WebCore/platform/graphics/coretext/FontCoreText.cpp M Source/WebCore/rendering/RenderFrameSet.h M Source/WebCore/rendering/RenderTable.cpp Log Message: --- Fix inefficient uses of Vector::fill() https://bugs.webkit.org/show_bug.cgi?id=252784 Reviewed by Darin Adler. Fix inefficient uses of Vector::fill(). Vector::fill() does a few things that are unnecessary for a newly created Vector. It is more efficient to call the `Vector(size, initialValue)` constructor. * Source/JavaScriptCore/b3/air/AirAllocateRegistersByGraphColoring.cpp: * Source/JavaScriptCore/b3/air/AirUseCounts.h: (JSC::B3::Air::UseCounts::UseCounts): * Source/JavaScriptCore/bytecode/Operands.h: (JSC::Operands::Operands): * Source/JavaScriptCore/dfg/DFGScoreBoard.h: (JSC::DFG::ScoreBoard::ScoreBoard): * Source/JavaScriptCore/wasm/js/JSWebAssemblyStruct.cpp: (JSC::JSWebAssemblyStruct::JSWebAssemblyStruct): * Source/WTF/wtf/FastBitVector.h: (WTF::FastBitVector::FastBitVector): * Source/WTF/wtf/FixedVector.h: (WTF::FixedVector::FixedVector): * Source/WTF/wtf/IndexMap.h: (WTF::IndexMap::IndexMap): * Source/WebCore/platform/audio/IIRFilter.cpp: (WebCore::IIRFilter::IIRFilter): * Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp: (WebCore::GraphicsLayerCA::ReplicaState::cloneID const): * Source/WebCore/platform/graphics/coretext/FontCoreText.cpp: (WebCore::hasGlyphsForCharacterRange): * Source/WebCore/rendering/RenderFrameSet.h: (WebCore::FrameEdgeInfo::FrameEdgeInfo): * Source/WebCore/rendering/RenderTable.cpp: (WebCore::RenderTable::RenderTable): Canonical link: https://commits.webkit.org/260748@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] a3a9a2: Port over remaining ServiceWorker types to the new...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: a3a9a226e40c6a7a89d4ab2f4346b72631450238 https://github.com/WebKit/WebKit/commit/a3a9a226e40c6a7a89d4ab2f4346b72631450238 Author: Gavin Phillips Date: 2023-02-23 (Thu, 23 Feb 2023) Changed paths: M Source/WebCore/Headers.cmake M Source/WebCore/WebCore.xcodeproj/project.pbxproj M Source/WebCore/html/LinkIconType.h M Source/WebCore/platform/LinkIcon.h M Source/WebCore/platform/PasteboardItemInfo.h M Source/WebCore/platform/ScreenProperties.h M Source/WebCore/platform/VideoFrameTimeMetadata.h M Source/WebCore/platform/graphics/PositionedGlyphs.h M Source/WebCore/plugins/PluginData.h M Source/WebCore/rendering/CSSValueKey.h M Source/WebCore/rendering/EventRegion.cpp M Source/WebCore/rendering/EventRegion.h M Source/WebCore/workers/WorkerFetchResult.h M Source/WebCore/workers/WorkerInitializationData.h M Source/WebCore/workers/WorkerOptions.h M Source/WebCore/workers/service/ServiceWorkerContextData.h A Source/WebCore/workers/service/ServiceWorkerImportedScript.h M Source/WebCore/workers/service/ServiceWorkerJobDataIdentifier.h M Source/WebCore/workers/service/ServiceWorkerRegistrationData.h M Source/WebCore/workers/service/ServiceWorkerRegistrationKey.h M Source/WebCore/workers/service/ServiceWorkerRegistrationOptions.h M Source/WebCore/workers/shared/SharedWorkerKey.h M Source/WebKit/NetworkProcess/ServiceWorker/WebSWServerToContextConnection.messages.in M Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in M Source/WebKit/Shared/WebEvent.h M Source/WebKit/Shared/WebKeyboardEvent.h Log Message: --- Port over remaining ServiceWorker types to the new serialization format https://bugs.webkit.org/show_bug.cgi?id=252748 rdar://105782903 Reviewed by Alex Christensen. This change ports the following types to the new IPC serialization format: - LinkIconType - LinkIcon - SupportedPluginIdentifier - CSSValueKey - VideoFrameTimeMetadata - PositionedGlyphs - EventRegion - PasteboardItemPresentationStyle - PresentationSize - PasteboardItemInfo - WorkerOptions - WorkerInitializationData - WorkerFetchResult - SharedWorkerKey - ServiceWorkerRegistrationOptions - ServiceWorkerRegistrationKey - ServiceWorkerRegistrationData - ServiceWorkerJobDataIdentifier - ServiceWorkerImportedScript - ServiceWorkerContextData * Source/WebCore/WebCore.xcodeproj/project.pbxproj: * Source/WebCore/html/LinkIconType.h: * Source/WebCore/platform/LinkIcon.h: (WebCore::LinkIcon::encode const): Deleted. (WebCore::LinkIcon::decode): Deleted. * Source/WebCore/platform/PasteboardItemInfo.h: (WebCore::PasteboardItemInfo::pathForHighestFidelityItem const): (WebCore::PresentationSize::encode const): Deleted. (WebCore::PresentationSize::decode): Deleted. (WebCore::PasteboardItemInfo::encode const): Deleted. (WebCore::PasteboardItemInfo::decode): Deleted. * Source/WebCore/platform/ScreenProperties.h: * Source/WebCore/platform/VideoFrameTimeMetadata.h: (WebCore::VideoFrameTimeMetadata::encode const): Deleted. (WebCore::VideoFrameTimeMetadata::decode): Deleted. * Source/WebCore/platform/graphics/PositionedGlyphs.h: (WebCore::PositionedGlyphs::PositionedGlyphs): (WebCore::PositionedGlyphs::encode const): Deleted. (WebCore::PositionedGlyphs::decode): Deleted. * Source/WebCore/plugins/PluginData.h: (WebCore::SupportedPluginIdentifier::decode): Deleted. (WebCore::SupportedPluginIdentifier::encode const): Deleted. * Source/WebCore/rendering/CSSValueKey.h: (WebCore::CSSValueKey::encode const): Deleted. (WebCore::CSSValueKey::decode): Deleted. * Source/WebCore/rendering/EventRegion.cpp: (WebCore::EventRegion::EventRegion): * Source/WebCore/rendering/EventRegion.h: (WebCore::EventRegion::encode const): Deleted. (WebCore::EventRegion::decode): Deleted. * Source/WebCore/workers/WorkerFetchResult.h: (WebCore::WorkerFetchResult::isolatedCopy const): (WebCore::workerFetchError): (WebCore::WorkerFetchResult::encode const): Deleted. (WebCore::WorkerFetchResult::decode): Deleted. * Source/WebCore/workers/WorkerInitializationData.h: (WebCore::WorkerInitializationData::encode const): Deleted. (WebCore::WorkerInitializationData::decode): Deleted. * Source/WebCore/workers/WorkerOptions.h: (WebCore::WorkerOptions::encode const): Deleted. (WebCore::WorkerOptions::decode): Deleted. * Source/WebCore/workers/service/ServiceWorkerContextData.h: (WebCore::ServiceWorkerContextData::ImportedScript::encode const): Deleted. (WebCore::ServiceWorkerContextData::ImportedScript::decode): Deleted. (WebCore::ServiceWorkerContextData::ImportedScript::isolatedCopy const): Deleted. (WebCore::ServiceWorkerContextData::ImportedScript::isolatedCopy): Deleted. (WebCore::ServiceWorkerContextData::encode const): Deleted. (WebCore::ServiceWorkerContextData::decode): Deleted. * Source/WebCore/workers/ser
[webkit-changes] [WebKit/WebKit] d5d4ad: Fix some bounds issues in API tests
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: d5d4adedf8268ecf3e454dad02981a9cbcd9b07e https://github.com/WebKit/WebKit/commit/d5d4adedf8268ecf3e454dad02981a9cbcd9b07e Author: Alex Christensen Date: 2023-02-23 (Thu, 23 Feb 2023) Changed paths: M Tools/TestWebKitAPI/Tests/WTF/CompactRefPtr.cpp M Tools/TestWebKitAPI/Tests/WTF/FixedBitVector.cpp M Tools/TestWebKitAPI/Tests/WTF/PackedRefPtr.cpp M Tools/TestWebKitAPI/Tests/WTF/RefPtr.cpp Log Message: --- Fix some bounds issues in API tests https://bugs.webkit.org/show_bug.cgi?id=252779 rdar://105784168 Reviewed by Darin Adler. Asan found some out of bounds operations because of how we wrote our tests. * Tools/TestWebKitAPI/Tests/WTF/CompactRefPtr.cpp: (TestWebKitAPI::returnConstRefCountedRef): (TestWebKitAPI::returnRefCountedRef): * Tools/TestWebKitAPI/Tests/WTF/FixedBitVector.cpp: (TestWebKitAPI::testFixedBitVectorFindBit): * Tools/TestWebKitAPI/Tests/WTF/PackedRefPtr.cpp: (TestWebKitAPI::returnConstRefCountedRef): (TestWebKitAPI::returnRefCountedRef): * Tools/TestWebKitAPI/Tests/WTF/RefPtr.cpp: (TestWebKitAPI::returnConstRefCountedRef): (TestWebKitAPI::returnRefCountedRef): Canonical link: https://commits.webkit.org/260746@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 05a40c: [GStreamer][Amlogic] Add platform quirks
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 05a40c73e8144d3248453f077763cdbb6601a88a https://github.com/WebKit/WebKit/commit/05a40c73e8144d3248453f077763cdbb6601a88a Author: Xabier Rodriguez-Calvar Date: 2023-02-23 (Thu, 23 Feb 2023) Changed paths: M Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp M Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h M Source/cmake/OptionsWPE.cmake Log Message: --- [GStreamer][Amlogic] Add platform quirks https://bugs.webkit.org/show_bug.cgi?id=252803 Reviewed by Philippe Normand. Fix for wait for audio & disable xrun timer 1- When the audio data reaches the amlhalasink later than 0.7s a xrun timer is triggered and it is moved to the paused state also causing a video freeze. Disable the xrun timer, so that video wont freeze when in slow network 2- enables 'wait-video' in aml audio sink See: https://github.com/WebPlatformForEmbedded/WPEWebKit/pull/835 * Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivateGStreamer::configureElement): (WebCore::MediaPlayerPrivateGStreamer::configureElementPlatformQuirks): * Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h: * Source/cmake/OptionsWPE.cmake: Canonical link: https://commits.webkit.org/260745@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 8701fc: [GLib] Bump font dependencies
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 8701fcdb29a3e71dbddbd345e7b49c42432a7854 https://github.com/WebKit/WebKit/commit/8701fcdb29a3e71dbddbd345e7b49c42432a7854 Author: Michael Catanzaro Date: 2023-02-23 (Thu, 23 Feb 2023) Changed paths: M Source/WebCore/platform/graphics/FontPlatformData.h M Source/WebCore/platform/graphics/freetype/FontPlatformDataFreeType.cpp M Source/WebCore/platform/graphics/opentype/OpenTypeMathData.h M Source/cmake/OptionsGTK.cmake M Source/cmake/OptionsWPE.cmake Log Message: --- [GLib] Bump font dependencies https://bugs.webkit.org/show_bug.cgi?id=252682 Reviewed by Carlos Garcia Campos. Also, clean up some USE(HARFBUZZ) and ENABLE(OPENTYPE_MATH) build guards. * Source/WebCore/platform/graphics/FontPlatformData.h: * Source/WebCore/platform/graphics/freetype/FontPlatformDataFreeType.cpp: * Source/WebCore/platform/graphics/opentype/OpenTypeMathData.h: * Source/cmake/OptionsGTK.cmake: * Source/cmake/OptionsWPE.cmake: Canonical link: https://commits.webkit.org/260744@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 5fc313: [JSC] Avoid saving top-level scope for non-module ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 5fc313f94632beae308222510df47f48b9e6b866 https://github.com/WebKit/WebKit/commit/5fc313f94632beae308222510df47f48b9e6b866 Author: Tadeu Zagallo Date: 2023-02-23 (Thu, 23 Feb 2023) Changed paths: M JSTests/stress/call-link-info-osrexit-repatch.js A JSTests/stress/hoisted-eval-different-scope.js M Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp M Source/JavaScriptCore/bytecompiler/BytecodeGenerator.h Log Message: --- [JSC] Avoid saving top-level scope for non-module code https://bugs.webkit.org/show_bug.cgi?id=252674 rdar://105732218 Reviewed by Yusuke Suzuki. Avoid allocating a local variable and moving the scope to save the top-level scope. Re-loading the context is pretty cheap and this reduces the amount of bytecode overhead for small functions. Notice that we still allocate a variable for module code, which is necessary since we allocate a lexical environment, which needs the scope for variable resolution. * JSTests/stress/hoisted-eval-different-scope.js: Added. (i.with.g): (i.g.f): (i.g): * Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp: (JSC::BytecodeGenerator::BytecodeGenerator): (JSC::BytecodeGenerator::emitResolveScopeForHoistingFuncDeclInEval): (JSC::BytecodeGenerator::allocateAndEmitScope): (JSC::BytecodeGenerator::restoreScopeRegister): Canonical link: https://commits.webkit.org/260743@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 5e1b94: [GStreamer][WebRTC] Disabled incoming audio track ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 5e1b9418e1ae6ba8954e7f6a916a7882e03ac69e https://github.com/WebKit/WebKit/commit/5e1b9418e1ae6ba8954e7f6a916a7882e03ac69e Author: Philippe Normand Date: 2023-02-23 (Thu, 23 Feb 2023) Changed paths: M LayoutTests/platform/glib/TestExpectations M Source/WebCore/platform/audio/gstreamer/AudioSourceProviderGStreamer.cpp M Source/WebCore/platform/audio/gstreamer/AudioSourceProviderGStreamer.h Log Message: --- [GStreamer][WebRTC] Disabled incoming audio track breaks webaudio provider https://bugs.webkit.org/show_bug.cgi?id=252751 Reviewed by Xabier Rodriguez-Calvar. Disabling an incoming audio track internally means that the mediastreamsrc switches from RTP payloads to raw audio. The AudioSourceProvider wasn't able to reliably handle this, but switching its internal pipeline to uridecodebin3 solves the issue. Internally uridecodebin3 will be able to reconfigure properly. * LayoutTests/platform/glib/TestExpectations: * Source/WebCore/platform/audio/gstreamer/AudioSourceProviderGStreamer.cpp: (WebCore::AudioSourceProviderGStreamer::AudioSourceProviderGStreamer): (WebCore::AudioSourceProviderGStreamer::~AudioSourceProviderGStreamer): (WebCore::AudioSourceProviderGStreamer::setClient): * Source/WebCore/platform/audio/gstreamer/AudioSourceProviderGStreamer.h: Canonical link: https://commits.webkit.org/260742@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 2471ea: [JHBuild] Enable gnutls backend in glib-networking
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 2471eaa794ce0b413c82ea538efe7988b6a64523 https://github.com/WebKit/WebKit/commit/2471eaa794ce0b413c82ea538efe7988b6a64523 Author: Diego Pino Garcia Date: 2023-02-23 (Thu, 23 Feb 2023) Changed paths: M Tools/jhbuild/jhbuild-minimal.modules Log Message: --- [JHBuild] Enable gnutls backend in glib-networking https://bugs.webkit.org/show_bug.cgi?id=252799 Reviewed by Carlos Alberto Lopez Perez. gnutls backend was disabled in favour of openSSL because Ubuntu 18.04 didn't support the required gnutls version and it was not possible to updated via JHBuild. Since already long time ago we're no longer supporting Ubuntu 18.04 so gnutls can be restored. * Tools/jhbuild/jhbuild-minimal.modules: Canonical link: https://commits.webkit.org/260741@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 568aa8: [WPE] Introduce configuration option for Broadcom ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 568aa867536451be47cfddfa0d76d6e1f36a1ecf https://github.com/WebKit/WebKit/commit/568aa867536451be47cfddfa0d76d6e1f36a1ecf Author: Xabier Rodriguez-Calvar Date: 2023-02-23 (Thu, 23 Feb 2023) Changed paths: M Source/cmake/OptionsWPE.cmake Log Message: --- [WPE] Introduce configuration option for Broadcom platform https://bugs.webkit.org/show_bug.cgi?id=252802 Reviewed by Philippe Normand. * Source/cmake/OptionsWPE.cmake: Canonical link: https://commits.webkit.org/260740@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 5e1c8e: [Win] The generic URL::fileSystemPath has to remov...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 5e1c8e09258cfc87c6907b65a5f7c72b08e295af https://github.com/WebKit/WebKit/commit/5e1c8e09258cfc87c6907b65a5f7c72b08e295af Author: Fujii Hironori Date: 2023-02-23 (Thu, 23 Feb 2023) Changed paths: M Source/WTF/wtf/URL.cpp M Source/WTF/wtf/cf/URLCF.cpp Log Message: --- [Win] The generic URL::fileSystemPath has to remove a leading slash https://bugs.webkit.org/show_bug.cgi?id=252367 Reviewed by Darin Adler and Ross Kirsling. Switched Windows port to use the generic URL::fileSystemPath rather than one using CF. URL::fileSystemPath has to remove a leading slash for Windows. Otherwise it returns a path "/C:/x.txt" for a URL "file:///C:/x.txt". * Source/WTF/wtf/URL.cpp: (WTF::URL::fileSystemPath const): * Source/WTF/wtf/cf/URLCF.cpp: (WTF::URL::fileSystemPath const): Canonical link: https://commits.webkit.org/260739@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 8e47c0: WebContent crashes if GPUP WebGL remote context bu...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 8e47c0fabb97ea07aa6d12bea0c47b791be19250 https://github.com/WebKit/WebKit/commit/8e47c0fabb97ea07aa6d12bea0c47b791be19250 Author: Kimmo Kinnunen Date: 2023-02-23 (Thu, 23 Feb 2023) Changed paths: M LayoutTests/platform/glib/TestExpectations M LayoutTests/webgl/webgl-fail-platform-context-creation-no-crash.html A LayoutTests/webgl/webgl-fail-remote-context-ipc-buffer-allocation-no-crash-expected.txt A LayoutTests/webgl/webgl-fail-remote-context-ipc-buffer-allocation-no-crash.html M Source/WebCore/html/canvas/WebGLContextAttributes.idl M Source/WebCore/platform/graphics/GraphicsContextGLAttributes.h M Source/WebKit/Platform/IPC/StreamClientConnection.cpp M Source/WebKit/Platform/IPC/StreamClientConnection.h M Source/WebKit/Platform/IPC/StreamClientConnectionBuffer.h M Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in M Source/WebKit/WebProcess/GPU/graphics/RemoteGraphicsContextGLProxy.cpp M Source/WebKit/WebProcess/GPU/graphics/RemoteGraphicsContextGLProxy.h M Source/WebKit/WebProcess/GPU/graphics/RemoteRenderingBackendProxy.cpp M Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemoteGPUProxy.cpp M Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemoteGPUProxy.h M Source/WebKit/WebProcess/GPU/graphics/cocoa/RemoteGraphicsContextGLProxyCocoa.mm M Source/WebKit/WebProcess/GPU/graphics/wc/RemoteGraphicsContextGLProxyWC.cpp M Tools/TestWebKitAPI/Tests/IPC/StreamConnectionBufferTests.cpp M Tools/TestWebKitAPI/Tests/IPC/StreamConnectionTests.cpp Log Message: --- WebContent crashes if GPUP WebGL remote context buffer cannot be allocated https://bugs.webkit.org/show_bug.cgi?id=252732 rdar://105612611 Reviewed by Geoffrey Garen. Change RemoteGraphicsContextGLProxy and RemoteGPUProxy creation to be nullable. If the IPC stream connection buffer allocation fails, return gracefully instead of previous inteded CRASH(). Preserves the CRASH() in RemoteRenderingBackendProxy as current code structure is such that it is expected always to be succesfully created. * LayoutTests/webgl/webgl-fail-platform-context-creation-no-crash.html: Remove a unneeded
[webkit-changes] [WebKit/WebKit] 03ee31: Add a delegate to allow/deny background fetches
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 03ee317ac8d06a3245e106fd0da4674bd4918970 https://github.com/WebKit/WebKit/commit/03ee317ac8d06a3245e106fd0da4674bd4918970 Author: Youenn Fablet Date: 2023-02-23 (Thu, 23 Feb 2023) Changed paths: A LayoutTests/http/wpt/background-fetch/fetch-denied.window-expected.txt A LayoutTests/http/wpt/background-fetch/fetch-denied.window.html A LayoutTests/http/wpt/background-fetch/fetch-denied.window.js A LayoutTests/http/wpt/background-fetch/sw.js M LayoutTests/imported/w3c/web-platform-tests/resources/testdriver-vendor.js M LayoutTests/platform/glib/TestExpectations M LayoutTests/platform/mac-wk1/TestExpectations M LayoutTests/platform/wincairo/TestExpectations M Source/WebCore/workers/service/server/SWServer.cpp M Source/WebCore/workers/service/server/SWServer.h M Source/WebCore/workers/service/server/SWServerDelegate.h M Source/WebKit/NetworkProcess/NetworkProcess.cpp M Source/WebKit/NetworkProcess/NetworkProcess.h M Source/WebKit/NetworkProcess/NetworkSession.cpp M Source/WebKit/NetworkProcess/NetworkSession.h M Source/WebKit/UIProcess/API/Cocoa/WKWebsiteDataStore.mm M Source/WebKit/UIProcess/API/Cocoa/_WKWebsiteDataStoreDelegate.h M Source/WebKit/UIProcess/Network/NetworkProcessProxy.cpp M Source/WebKit/UIProcess/Network/NetworkProcessProxy.h M Source/WebKit/UIProcess/Network/NetworkProcessProxy.messages.in M Source/WebKit/UIProcess/WebsiteData/WebsiteDataStoreClient.h M Tools/WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl M Tools/WebKitTestRunner/InjectedBundle/TestRunner.cpp M Tools/WebKitTestRunner/InjectedBundle/TestRunner.h M Tools/WebKitTestRunner/TestController.cpp M Tools/WebKitTestRunner/TestController.h M Tools/WebKitTestRunner/TestInvocation.cpp M Tools/WebKitTestRunner/cocoa/TestControllerCocoa.mm M Tools/WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.h M Tools/WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm Log Message: --- Add a delegate to allow/deny background fetches https://bugs.webkit.org/show_bug.cgi?id=252565 rdar://problem/105678551 Reviewed by Alex Christensen. Add plumbing code to check for background fetch permission at SWServer/NetworkProcess level to WebsiteDataStore delegate/UIProcess. Covered by added test. * LayoutTests/http/wpt/background-fetch/fetch-denied.window-expected.txt: Added. * LayoutTests/http/wpt/background-fetch/fetch-denied.window.html: Added. * LayoutTests/http/wpt/background-fetch/fetch-denied.window.js: Added. (promise_test.async t): * LayoutTests/http/wpt/background-fetch/sw.js: Added. * LayoutTests/imported/w3c/web-platform-tests/resources/testdriver-vendor.js: (async switch): (window.test_driver_internal.set_permission): * LayoutTests/platform/glib/TestExpectations: * Source/WebCore/workers/service/server/SWServer.cpp: (WebCore::SWServer::Connection::startBackgroundFetch): * Source/WebCore/workers/service/server/SWServer.h: (WebCore::SWServer::requestBackgroundFetchPermission): * Source/WebCore/workers/service/server/SWServerDelegate.h: * Source/WebKit/NetworkProcess/NetworkProcess.cpp: (WebKit::NetworkProcess::requestBackgroundFetchPermission): * Source/WebKit/NetworkProcess/NetworkProcess.h: * Source/WebKit/NetworkProcess/NetworkSession.cpp: (WebKit::NetworkSession::requestBackgroundFetchPermission): * Source/WebKit/NetworkProcess/NetworkSession.h: * Source/WebKit/UIProcess/API/Cocoa/WKWebsiteDataStore.mm: * Source/WebKit/UIProcess/API/Cocoa/_WKWebsiteDataStoreDelegate.h: * Source/WebKit/UIProcess/Network/NetworkProcessProxy.cpp: (WebKit::NetworkProcessProxy::requestBackgroundFetchPermission): * Source/WebKit/UIProcess/Network/NetworkProcessProxy.h: * Source/WebKit/UIProcess/Network/NetworkProcessProxy.messages.in: * Source/WebKit/UIProcess/WebsiteData/WebsiteDataStoreClient.h: (WebKit::WebsiteDataStoreClient::requestBackgroundFetchPermission): * Tools/WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl: * Tools/WebKitTestRunner/InjectedBundle/TestRunner.cpp: (WTR::TestRunner::setBackgroundFetchPermission): * Tools/WebKitTestRunner/InjectedBundle/TestRunner.h: * Tools/WebKitTestRunner/TestController.cpp: (WTR::TestController::resetStateToConsistentValues): (WTR::TestController::setBackgroundFetchPermission): * Tools/WebKitTestRunner/TestController.h: * Tools/WebKitTestRunner/TestInvocation.cpp: (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle): * Tools/WebKitTestRunner/cocoa/TestControllerCocoa.mm: (WTR::TestController::setBackgroundFetchPermission): * Tools/WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.h: * Tools/WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm: (-[TestWebsiteDataStoreDelegate init]): (-[TestWebsiteDataStoreDelegate setBackgroundFetchPermission:]): (-[TestWebsiteDataStoreDelegate requestBackgroundFetchPermission:frameOrigin:decisionHandler:]): Canonical
[webkit-changes] [WebKit/WebKit] b7cfab: [web-animations] imported/w3c/web-platform-tests/c...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: b7cfabe8d74edd1cf7cdce44da0cacf4fd2173c5 https://github.com/WebKit/WebKit/commit/b7cfabe8d74edd1cf7cdce44da0cacf4fd2173c5 Author: Antoine Quint Date: 2023-02-23 (Thu, 23 Feb 2023) Changed paths: M LayoutTests/TestExpectations Log Message: --- [web-animations] imported/w3c/web-platform-tests/css/css-transforms/animation/transform-interpolation-translate-em.html passes as of 260399@main https://bugs.webkit.org/show_bug.cgi?id=252804 Unreviewed test garderning. * LayoutTests/TestExpectations: Canonical link: https://commits.webkit.org/260736@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 0c0a78: [WGSL] Move type checking into the validation stage
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 0c0a78158493361033491779b9ec813d6da84fbf https://github.com/WebKit/WebKit/commit/0c0a78158493361033491779b9ec813d6da84fbf Author: Tadeu Zagallo Date: 2023-02-23 (Thu, 23 Feb 2023) Changed paths: M Source/WebGPU/WGSL/TypeCheck.cpp M Source/WebGPU/WGSL/TypeCheck.h M Source/WebGPU/WGSL/TypeDeclarations.js M Source/WebGPU/WGSL/WGSL.cpp Log Message: --- [WGSL] Move type checking into the validation stage https://bugs.webkit.org/show_bug.cgi?id=252760 rdar://105788936 Reviewed by Myles C. Maxfield. At first, since there was very little of the type checking implemented, it was only run right before generating and the errors behind a compiler-time flag. While the type checker is still far from complete, it can now correctly check the examples we've been using for development, so we can move it into the validation phase. * Source/WebGPU/WGSL/TypeCheck.cpp: (WGSL::TypeChecker::check): (WGSL::typeCheck): * Source/WebGPU/WGSL/TypeCheck.h: * Source/WebGPU/WGSL/TypeDeclarations.js: * Source/WebGPU/WGSL/WGSL.cpp: (WGSL::staticCheck): (WGSL::prepareImpl): Canonical link: https://commits.webkit.org/260735@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 0072dc: ImageBufferIOSurfaceBackend context setup and tear...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 0072dcd9a13bfa4235b0184fe629e657a60c9b4a https://github.com/WebKit/WebKit/commit/0072dcd9a13bfa4235b0184fe629e657a60c9b4a Author: Kimmo Kinnunen Date: 2023-02-23 (Thu, 23 Feb 2023) Changed paths: M Source/WebCore/platform/graphics/ImageBufferBackend.cpp M Source/WebCore/platform/graphics/ImageBufferBackend.h M Source/WebCore/platform/graphics/cg/IOSurfacePool.cpp M Source/WebCore/platform/graphics/cg/ImageBufferCGBackend.cpp M Source/WebCore/platform/graphics/cg/ImageBufferCGBackend.h M Source/WebCore/platform/graphics/cg/ImageBufferCGBitmapBackend.cpp M Source/WebCore/platform/graphics/cg/ImageBufferCGBitmapBackend.h M Source/WebCore/platform/graphics/cg/ImageBufferIOSurfaceBackend.cpp M Source/WebCore/platform/graphics/cg/ImageBufferIOSurfaceBackend.h M Source/WebCore/platform/graphics/cocoa/IOSurface.h M Source/WebCore/platform/graphics/cocoa/IOSurface.mm Log Message: --- ImageBufferIOSurfaceBackend context setup and teardown functions are redundant and error-prone https://bugs.webkit.org/show_bug.cgi?id=240452 rdar://93412550 Reviewed by Simon Fraser. Make all ImageBufferCGBackend hold the GraphicsContextCG. Avoid holding GraphicsContext in IOSurface, as the only caller was ImageBufferIOSurfaceBackend. ImageBufferBackend::applyBaseTransformToContext() invoked a virtual function context(). This was called from the middle of the inheritance chain, from a constructor. If a class later in the inheritance chain would override context(), the call would not be invoked correctly. Currently no class suffered from this, but in future some might. ImageBufferIOSurfaceBackend call to applyBaseTransformToContext() would also recurse through context() back to applyBaseTransformToContext() in non-intuitive way through overridden ::context() which would re-enter applyBaseTransformToContext(). Based on current knowledge doubly invoking the logic did not cause any harm. * Source/WebCore/platform/graphics/ImageBufferBackend.cpp: (WebCore::ImageBufferBackend::applyBaseTransformToContext const): Deleted. * Source/WebCore/platform/graphics/ImageBufferBackend.h: * Source/WebCore/platform/graphics/cg/IOSurfacePool.cpp: (WebCore::IOSurfacePool::willAddSurface): * Source/WebCore/platform/graphics/cg/ImageBufferCGBackend.cpp: (WebCore::ImageBufferCGBackend::applyBaseTransform const): * Source/WebCore/platform/graphics/cg/ImageBufferCGBackend.h: * Source/WebCore/platform/graphics/cg/ImageBufferCGBitmapBackend.cpp: (WebCore::ImageBufferCGBitmapBackend::ImageBufferCGBitmapBackend): * Source/WebCore/platform/graphics/cg/ImageBufferCGBitmapBackend.h: * Source/WebCore/platform/graphics/cg/ImageBufferIOSurfaceBackend.cpp: (WebCore::ImageBufferIOSurfaceBackend::ImageBufferIOSurfaceBackend): (WebCore::ImageBufferIOSurfaceBackend::context const): (WebCore::ImageBufferIOSurfaceBackend::releaseGraphicsContext): * Source/WebCore/platform/graphics/cg/ImageBufferIOSurfaceBackend.h: * Source/WebCore/platform/graphics/cocoa/IOSurface.h: * Source/WebCore/platform/graphics/cocoa/IOSurface.mm: (WebCore::IOSurface::create): (WebCore::IOSurface::releasePlatformContext): (WebCore::IOSurface::ensureGraphicsContext): Deleted. (WebCore::IOSurface::releaseGraphicsContext): Deleted. Canonical link: https://commits.webkit.org/260734@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 34e32f: [JSC] Bound function should propagate tail-call in...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 34e32f7614d691d6bf29ac7e30678728e052cc07 https://github.com/WebKit/WebKit/commit/34e32f7614d691d6bf29ac7e30678728e052cc07 Author: Yusuke Suzuki Date: 2023-02-23 (Thu, 23 Feb 2023) Changed paths: A JSTests/stress/bound-function-tail-call.js M Source/JavaScriptCore/bytecode/InlineCallFrame.cpp M Source/JavaScriptCore/bytecode/InlineCallFrame.h M Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp M Source/JavaScriptCore/runtime/JSBoundFunction.cpp Log Message: --- [JSC] Bound function should propagate tail-call information https://bugs.webkit.org/show_bug.cgi?id=252726 rdar://105763999 Reviewed by Justin Michaud. When bound function is called in a tail-call form and DFG inlines it, we should make it a bound-function-tail-call. Otherwise, when reconstructing frames on OSR exit, we accidentally compute the wrong frame (bound function's return place gets its frame while it is doing a tail-call). The attached program is doing, entry -call-> test4 -tail-call-> test3 -tail-call-> bound function -call-> test2 (OSR exit) And DFG wipes bound function and make it, entry -call-> test4 -tail-call-> test3 -bound-function-tail-call-> test2 [ one DFG function ] Then, the reconstructed frame on OSR exit should be entry -call-> test2 since test2 should return to entry (test4, test3 are tail calls, and bound function is completely inlined and diminished). We also fix bound function's construct's newTarget compuation (which caused test262 failures). * JSTests/stress/bound-function-tail-call.js: Added. (shouldBe): (entry.test): (entry.test2): (entry.test3): (entry.test4): (entry): * Source/JavaScriptCore/bytecode/InlineCallFrame.cpp: (WTF::printInternal): * Source/JavaScriptCore/bytecode/InlineCallFrame.h: (JSC::InlineCallFrame::callModeFor): (JSC::InlineCallFrame::specializationKindFor): (JSC::InlineCallFrame::isTail): * Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp: (JSC::DFG::ByteCodeParser::inlineCall): (JSC::DFG::ByteCodeParser::handleIntrinsicCall): * Source/JavaScriptCore/runtime/JSBoundFunction.cpp: (JSC::JSC_DEFINE_HOST_FUNCTION): Canonical link: https://commits.webkit.org/260733@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] e4f315: [GStreamer] Improve logging in VideoTrackPrivateGS...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: e4f3157afc6ca0cf36b48e57e2337b4ceb66d459 https://github.com/WebKit/WebKit/commit/e4f3157afc6ca0cf36b48e57e2337b4ceb66d459 Author: Philippe Normand Date: 2023-02-23 (Thu, 23 Feb 2023) Changed paths: M Source/WebCore/platform/graphics/gstreamer/VideoTrackPrivateGStreamer.cpp Log Message: --- [GStreamer] Improve logging in VideoTrackPrivateGStreamer https://bugs.webkit.org/show_bug.cgi?id=252757 Reviewed by Xabier Rodriguez-Calvar. A webkitvideotrack gstreamer debug category can now be used to get runtime logs corresponding to this module. * Source/WebCore/platform/graphics/gstreamer/VideoTrackPrivateGStreamer.cpp: (WebCore::ensureDebugCategoryInitialized): (WebCore::VideoTrackPrivateGStreamer::VideoTrackPrivateGStreamer): (WebCore::VideoTrackPrivateGStreamer::updateConfigurationFromTags): (WebCore::VideoTrackPrivateGStreamer::updateConfigurationFromCaps): Canonical link: https://commits.webkit.org/260732@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 74387c: [GStreamer][WebRTC] Renegotiation signalling impro...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 74387c514701e9fc47ee32f5d9b68fd2d7913071 https://github.com/WebKit/WebKit/commit/74387c514701e9fc47ee32f5d9b68fd2d7913071 Author: Philippe Normand Date: 2023-02-23 (Thu, 23 Feb 2023) Changed paths: M Source/WebCore/Modules/mediastream/gstreamer/GStreamerMediaEndpoint.cpp M Source/WebCore/Modules/mediastream/gstreamer/GStreamerMediaEndpoint.h M Source/WebCore/Modules/mediastream/gstreamer/GStreamerPeerConnectionBackend.cpp Log Message: --- [GStreamer][WebRTC] Renegotiation signalling improvement https://bugs.webkit.org/show_bug.cgi?id=252756 Reviewed by Xabier Rodriguez-Calvar. When webrtcbin emits its on-negotiation-needed it has already made sure the negotiation is really needed according to the spec, but our implementation wasn't resetting the corresponding flag afterwards. We now match the event serial number, similarly to the libwebrtc implementation. * Source/WebCore/Modules/mediastream/gstreamer/GStreamerMediaEndpoint.cpp: (WebCore::GStreamerMediaEndpoint::onNegotiationNeeded): * Source/WebCore/Modules/mediastream/gstreamer/GStreamerMediaEndpoint.h: (WebCore::GStreamerMediaEndpoint::isNegotiationNeeded const): * Source/WebCore/Modules/mediastream/gstreamer/GStreamerPeerConnectionBackend.cpp: (WebCore::GStreamerPeerConnectionBackend::isNegotiationNeeded const): Canonical link: https://commits.webkit.org/260731@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
