[webkit-changes] [WebKit/WebKit] 118930: Fix the build after 273342@main
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 11893003d47a7c29b0ce84a7479980ebf220c589 https://github.com/WebKit/WebKit/commit/11893003d47a7c29b0ce84a7479980ebf220c589 Author: Tim Horton Date: 2024-01-22 (Mon, 22 Jan 2024) Changed paths: M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm Log Message: --- Fix the build after 273342@main https://bugs.webkit.org/show_bug.cgi?id=267912 rdar://121417716 Unreviewed build fix. * Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm: (WebKit::UnifiedPDFPlugin::createContextMenu const): I don't really understand why it doesn't build in some situations, but revert the unnecessary review comment to adopt constructAndAppend. Canonical link: https://commits.webkit.org/273348@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] d9bdd6: Remove WebKit::WebDocumentLoader
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: d9bdd69cd88e6e12890045d2ad2bab3685808d86 https://github.com/WebKit/WebKit/commit/d9bdd69cd88e6e12890045d2ad2bab3685808d86 Author: Alex Christensen Date: 2024-01-22 (Mon, 22 Jan 2024) Changed paths: M Source/WebCore/loader/DocumentLoader.cpp M Source/WebCore/loader/DocumentLoader.h M Source/WebCore/loader/FrameLoader.cpp M Source/WebCore/loader/FrameLoader.h M Source/WebCore/loader/LocalFrameLoaderClient.h M Source/WebCore/page/LocalFrame.h M Source/WebKit/Sources.txt M Source/WebKit/WebKit.xcodeproj/project.pbxproj M Source/WebKit/WebProcess/Network/WebLoaderStrategy.cpp M Source/WebKit/WebProcess/Storage/RemoteWorkerFrameLoaderClient.cpp M Source/WebKit/WebProcess/Storage/WebSWContextManagerConnection.cpp M Source/WebKit/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp M Source/WebKit/WebProcess/WebCoreSupport/WebLocalFrameLoaderClient.cpp M Source/WebKit/WebProcess/WebCoreSupport/WebLocalFrameLoaderClient.h R Source/WebKit/WebProcess/WebPage/WebDocumentLoader.cpp R Source/WebKit/WebProcess/WebPage/WebDocumentLoader.h M Source/WebKit/WebProcess/WebPage/WebFrame.cpp M Source/WebKit/WebProcess/WebPage/WebFrame.h M Source/WebKit/WebProcess/WebPage/WebPage.cpp M Source/WebKit/WebProcess/WebPage/WebPage.h Log Message: --- Remove WebKit::WebDocumentLoader https://bugs.webkit.org/show_bug.cgi?id=267895 rdar://121405086 Reviewed by Brady Eidson. This is the first step towards untangling WebKit::WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction which has no business looking for a DocumentLoader because the frame may be a RemoteFrame. WebKit::WebDocumentLoader is just a WebCore::DocumentLoader with a navigation identifier. Move the navigation identifier to WebCore::DocumentLoader, move all the other code to better places, and remove the abstraction. Now WebKit::WebFrameLoaderClient has no DocumentLoader information that the caller in WebCore doesn't have. * Source/WebCore/loader/DocumentLoader.cpp: (WebCore::DocumentLoader::detachFromFrame): (WebCore::DocumentLoader::setNavigationID): * Source/WebCore/loader/DocumentLoader.h: (WebCore::DocumentLoader::navigationID const): * Source/WebCore/loader/FrameLoader.cpp: (WebCore::FrameLoader::loaderForWebsitePolicies const): * Source/WebCore/loader/FrameLoader.h: * Source/WebCore/loader/LocalFrameLoaderClient.h: * Source/WebCore/page/LocalFrame.h: * Source/WebKit/Sources.txt: * Source/WebKit/WebKit.xcodeproj/project.pbxproj: * Source/WebKit/WebProcess/Network/WebLoaderStrategy.cpp: (WebKit::policySourceDocumentLoaderForFrame): (WebKit::WebLoaderStrategy::scheduleLoadFromNetworkProcess): * Source/WebKit/WebProcess/Storage/RemoteWorkerFrameLoaderClient.cpp: (WebKit::RemoteWorkerFrameLoaderClient::createDocumentLoader): * Source/WebKit/WebProcess/Storage/WebSWContextManagerConnection.cpp: * Source/WebKit/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp: (WebKit::WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction): * Source/WebKit/WebProcess/WebCoreSupport/WebLocalFrameLoaderClient.cpp: (WebKit::WebLocalFrameLoaderClient::documentLoaderDetached): (WebKit::WebLocalFrameLoaderClient::dispatchDidReceiveServerRedirectForProvisionalLoad): (WebKit::WebLocalFrameLoaderClient::dispatchDidChangeProvisionalURL): (WebKit::WebLocalFrameLoaderClient::dispatchDidStartProvisionalLoad): (WebKit::WebLocalFrameLoaderClient::dispatchDidCommitLoad): (WebKit::WebLocalFrameLoaderClient::dispatchDidFailProvisionalLoad): (WebKit::WebLocalFrameLoaderClient::dispatchDidFailLoad): (WebKit::WebLocalFrameLoaderClient::dispatchDidFinishDocumentLoad): (WebKit::WebLocalFrameLoaderClient::dispatchDidFinishLoad): (WebKit::WebLocalFrameLoaderClient::dispatchDecidePolicyForResponse): (WebKit::WebLocalFrameLoaderClient::applyToDocumentLoader): (WebKit::WebLocalFrameLoaderClient::updateCachedDocumentLoader): * Source/WebKit/WebProcess/WebCoreSupport/WebLocalFrameLoaderClient.h: * Source/WebKit/WebProcess/WebPage/WebDocumentLoader.cpp: Removed. * Source/WebKit/WebProcess/WebPage/WebDocumentLoader.h: Removed. * Source/WebKit/WebProcess/WebPage/WebFrame.cpp: (WebKit::WebFrame::didReceivePolicyDecision): (WebKit::WebFrame::documentLoaderDetached): Deleted. * Source/WebKit/WebProcess/WebPage/WebFrame.h: * Source/WebKit/WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::didSameDocumentNavigationForFrame): (WebKit::WebPage::createDocumentLoader): (WebKit::WebPage::updateCachedDocumentLoader): * Source/WebKit/WebProcess/WebPage/WebPage.h: Canonical link: https://commits.webkit.org/273347@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 86b022: [UnifiedPDF] Implement HUD actions
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 86b022b127ea411def2339f0fec126ae7b9d36d6 https://github.com/WebKit/WebKit/commit/86b022b127ea411def2339f0fec126ae7b9d36d6 Author: Tim Horton Date: 2024-01-22 (Mon, 22 Jan 2024) Changed paths: M Source/WebKit/Shared/mac/PDFContextMenu.h M Source/WebKit/Shared/mac/PDFContextMenuItem.serialization.in M Source/WebKit/UIProcess/mac/WebPageProxyMac.mm M Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.h M Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.mm M Source/WebKit/WebProcess/Plugins/PDF/PDFPluginBase.h M Source/WebKit/WebProcess/Plugins/PDF/PDFPluginBase.mm M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.h M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm Log Message: --- [UnifiedPDF] Implement HUD actions https://bugs.webkit.org/show_bug.cgi?id=267910 rdar://118241818 Reviewed by Richard Robinson. Implement Open In... and Download in the HUD, and Open In... in the context menu. * Source/WebKit/Shared/mac/PDFContextMenu.h: * Source/WebKit/Shared/mac/PDFContextMenuItem.serialization.in: * Source/WebKit/UIProcess/mac/WebPageProxyMac.mm: (WebKit::WebPageProxy::showPDFContextMenu): Rename openInPreviewIndex to openInPreviewTag since that's what it is in practice. * Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.h: * Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.mm: (WebKit::PDFPlugin::handleContextMenuEvent): (WebKit::PDFPlugin::liveData const): (WebKit::PDFPlugin::save): Deleted. (WebKit::PDFPlugin::openWithPreview): Deleted. * Source/WebKit/WebProcess/Plugins/PDF/PDFPluginBase.h: * Source/WebKit/WebProcess/Plugins/PDF/PDFPluginBase.mm: (WebKit::PDFPluginBase::createPDFDocument): (WebKit::PDFPluginBase::originalData const): (WebKit::PDFPluginBase::save): (WebKit::PDFPluginBase::openWithPreview): Hoist these to PDFPluginBase. (WebKit::PDFPluginBase::rawData const): Deleted. Rename rawData to originalData to properly convey what is special about it. * Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.h: * Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm: (WebKit::UnifiedPDFPlugin::liveData const): Temporarily implement liveData() interms of originalData() until we have annotation support implemented. (WebKit::UnifiedPDFPlugin::createContextMenu const): (WebKit::UnifiedPDFPlugin::save): Deleted. (WebKit::UnifiedPDFPlugin::openWithPreview): Deleted. Canonical link: https://commits.webkit.org/273346@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] c8a4c0: Fix svg-write-resources-null-maskImage-crash-expec...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: c8a4c028a9e7cdade35b4a20cf7db8721c3b5b9b https://github.com/WebKit/WebKit/commit/c8a4c028a9e7cdade35b4a20cf7db8721c3b5b9b Author: Erica Li Date: 2024-01-22 (Mon, 22 Jan 2024) Changed paths: M LayoutTests/svg/css/svg-write-resources-null-maskImage-crash-expected.html M LayoutTests/svg/css/svg-write-resources-null-maskImage-crash.html Log Message: --- Fix svg-write-resources-null-maskImage-crash-expected.html. rdar://121162928 Reviewed by Tim Nguyen. Removing and style attribute from expected file. * LayoutTests/svg/css/svg-write-resources-null-maskImage-crash-expected.html: * LayoutTests/svg/css/svg-write-resources-null-maskImage-crash.html: Canonical link: https://commits.webkit.org/273345@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] bf3c42: Use UUID::createVersion4Weak for Document constructor
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: bf3c42ab2dd81e67d87363700fca15e9c24e92d0 https://github.com/WebKit/WebKit/commit/bf3c42ab2dd81e67d87363700fca15e9c24e92d0 Author: Yusuke Suzuki Date: 2024-01-22 (Mon, 22 Jan 2024) Changed paths: M Source/WTF/wtf/UUID.cpp M Source/WTF/wtf/UUID.h M Source/WebCore/dom/Document.cpp M Source/WebCore/platform/ScriptExecutionContextIdentifier.h Log Message: --- Use UUID::createVersion4Weak for Document constructor https://bugs.webkit.org/show_bug.cgi?id=267897 rdar://121405807 Reviewed by Ryosuke Niwa. We do not need cryptographically random values here. Use UUID::createVersion4Weak. * Source/WTF/wtf/UUID.cpp: (WTF::createVersion4UUIDString): * Source/WTF/wtf/UUID.h: * Source/WebCore/dom/Document.cpp: (WebCore::Document::originIdentifierForPasteboard const): (WebCore::Document::didInsertAttachmentElement): * Source/WebCore/platform/ScriptExecutionContextIdentifier.h: (WebCore::ProcessQualified::generate): Canonical link: https://commits.webkit.org/273344@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 0ec51a: Fix the build
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 0ec51a74428eaad1fa20f7c5c339b012bb3e1df1 https://github.com/WebKit/WebKit/commit/0ec51a74428eaad1fa20f7c5c339b012bb3e1df1 Author: Andy Estes Date: 2024-01-22 (Mon, 22 Jan 2024) Changed paths: M Source/WebCore/html/HTMLMediaElement.cpp Log Message: --- Fix the build https://bugs.webkit.org/show_bug.cgi?id=267909 rdar://121412960 Unreviewed build fix after 273340@main. * Source/WebCore/html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::enterFullscreen): Canonical link: https://commits.webkit.org/273343@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 12f1eb: [UnifiedPDF] Zooming via HUD buttons, keyboard, an...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 12f1eb0ad174c46f8acd8586704f9934f17612cb https://github.com/WebKit/WebKit/commit/12f1eb0ad174c46f8acd8586704f9934f17612cb Author: Tim Horton Date: 2024-01-22 (Mon, 22 Jan 2024) Changed paths: M Source/WebCore/platform/LocalizedStrings.cpp M Source/WebCore/platform/LocalizedStrings.h M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.h M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm M Source/WebKit/WebProcess/Plugins/PluginView.cpp M Source/WebKit/WebProcess/Plugins/PluginView.h M Tools/MiniBrowser/mac/WK2BrowserWindowController.m Log Message: --- [UnifiedPDF] Zooming via HUD buttons, keyboard, and context menu https://bugs.webkit.org/show_bug.cgi?id=267899 rdar://119632377 Reviewed by Simon Fraser. * Source/WebCore/platform/LocalizedStrings.cpp: (WebCore::contextMenuItemPDFTwoPagesContinuous): (WebCore::contextMenuItemPDFAutoSize): * Source/WebCore/platform/LocalizedStrings.h: Expose zoomIn, zoomOut, and actualSize strings. * Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.h: * Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm: (WebKit::UnifiedPDFPlugin::contextMenuItemTagFromDisplayMode const): (WebKit::UnifiedPDFPlugin::displayModeFromContextMenuItemTag const): Move these in from the header. (WebKit::UnifiedPDFPlugin::createContextMenu const): (WebKit::UnifiedPDFPlugin::performContextMenuAction): Add context menu items for the three new actions. (WebKit::UnifiedPDFPlugin::zoomIn): (WebKit::UnifiedPDFPlugin::zoomOut): Implement these via setPageScaleFactor(). These back the HUD actions. (WebKit::UnifiedPDFPlugin::pageScaleFactor const): Deleted. Don't implement this getter in terms of PluginView's cached plugin scale; just use ours! This way we don't get out of sync when we call setPageScaleFactor internally. * Source/WebKit/WebProcess/Plugins/PluginView.cpp: (WebKit::PluginView::setPageScaleFactor): (WebKit::PluginView::pageScaleFactor const): * Source/WebKit/WebProcess/Plugins/PluginView.h: Stop storing the plugin scale in PluginView, since it's duplicative of state in each of the children. Just defer to them. * Tools/MiniBrowser/mac/WK2BrowserWindowController.m: (-[WK2BrowserWindowController resetZoom:]): Reset page scale in addition to page zoom in MiniBrowser, to match Safari's behavior. Canonical link: https://commits.webkit.org/273342@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 36de40: AX: AXObjectCache::dirtyIsolatedTreeRelations is c...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 36de400f9138812974b62bd16baab486b3a55334 https://github.com/WebKit/WebKit/commit/36de400f9138812974b62bd16baab486b3a55334 Author: Andres Gonzalez Date: 2024-01-22 (Mon, 22 Jan 2024) Changed paths: M Source/WebCore/accessibility/AXObjectCache.cpp M Source/WebCore/accessibility/AXObjectCache.h Log Message: --- AX: AXObjectCache::dirtyIsolatedTreeRelations is called whether relations are modified or not. https://bugs.webkit.org/show_bug.cgi?id=267875 Reviewed by Tyler Wilcock. This causes unnecessary updates to the isolated tree. This patch fixes the issue by making the addRelation and removeRelation method to return a boolean indicating whether the relationships were actually changed. * Source/WebCore/accessibility/AXObjectCache.cpp: (WebCore::AXObjectCache::remove): (WebCore::AXObjectCache::updateLabelFor): (WebCore::AXObjectCache::updateLabeledBy): (WebCore::AXObjectCache::addRelation): (WebCore::AXObjectCache::removeAllRelations): (WebCore::AXObjectCache::removeRelation): (WebCore::AXObjectCache::updateRelationsForTree): (WebCore::AXObjectCache::addLabelForRelation): (WebCore::AXObjectCache::updateRelations): (WebCore::AXObjectCache::removeRelations): Renamed. (WebCore::AXObjectCache::addRelations): Renamed. * Source/WebCore/accessibility/AXObjectCache.h: Canonical link: https://commits.webkit.org/273341@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] d7336d: [EME] Blocked encrypted samples are not enqueued a...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: d7336d4f5da69f80f35c36f8083e53d3c6217dda https://github.com/WebKit/WebKit/commit/d7336d4f5da69f80f35c36f8083e53d3c6217dda Author: Andy Estes Date: 2024-01-22 (Mon, 22 Jan 2024) Changed paths: M LayoutTests/http/tests/media/fairplay/eme2016.js A LayoutTests/http/tests/media/fairplay/fps-mse-attach-cdm-after-key-exchange-expected.txt A LayoutTests/http/tests/media/fairplay/fps-mse-attach-cdm-after-key-exchange.html M LayoutTests/http/tests/media/fairplay/fps-mse-play-while-not-in-dom.html M LayoutTests/http/tests/media/fairplay/fps-mse-unmuxed-audio-only.html M LayoutTests/http/tests/media/fairplay/fps-mse-unmuxed-key-renewal.html M LayoutTests/http/tests/media/fairplay/fps-mse-unmuxed-key-rotation.html M LayoutTests/http/tests/media/fairplay/fps-mse-unmuxed-multiple-keys.html M LayoutTests/http/tests/media/fairplay/fps-mse-unmuxed-same-key.html M LayoutTests/platform/mac/TestExpectations M Source/WebCore/html/HTMLMediaElement.cpp M Source/WebCore/platform/graphics/avfoundation/objc/CDMInstanceFairPlayStreamingAVFObjC.h M Source/WebCore/platform/graphics/avfoundation/objc/CDMInstanceFairPlayStreamingAVFObjC.mm M Source/WebCore/platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.h M Source/WebCore/platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm Log Message: --- [EME] Blocked encrypted samples are not enqueued after a CDM is attached to a SourceBuffer (affects netflix.com) https://bugs.webkit.org/show_bug.cgi?id=267804 rdar://120879185 Reviewed by Jean-Yves Avenard and Jer Noble. When SourceBuffer attempts to enqueue an encrypted sample before either a CDM is attached or a usable key is present it adds the sample to a list of "blocked" samples. The intention was to later enqueue these samples once a CDM was attached and usable keys were present, however this would never occur for two reasons: 1. While SourceBufferPrivateAVFObjC had a key status observer that would enqueue blocked samples when called, it was never added to the attached CDM and therefore never called. 2. Even if the observer were added, if key status resolved to a terminal state prior to the CDM being attached then the observer would never be called. These issues manifested in sporadic playback failures on netflix.com (and possibly other EME sites). Addressed (1) by adding SourceBufferPrivateAVFObjC's key status observer to the attached CDM. Addressed (2) by attempting to enqueue blocked samples immediately at CDM attachment time. Added a layout test. * LayoutTests/http/tests/media/fairplay/eme2016.js: (async startEME): (async fetchAppendAndWaitForEncrypted): (async createBufferAppendAndWaitForEncrypted): * LayoutTests/http/tests/media/fairplay/fps-mse-attach-cdm-after-key-exchange-expected.txt: Added. * LayoutTests/http/tests/media/fairplay/fps-mse-attach-cdm-after-key-exchange.html: Copied from LayoutTests/http/tests/media/fairplay/fps-mse-play-while-not-in-dom.html. * LayoutTests/http/tests/media/fairplay/fps-mse-play-while-not-in-dom.html: * LayoutTests/http/tests/media/fairplay/fps-mse-unmuxed-audio-only.html: * LayoutTests/http/tests/media/fairplay/fps-mse-unmuxed-key-renewal.html: * LayoutTests/http/tests/media/fairplay/fps-mse-unmuxed-key-rotation.html: * LayoutTests/http/tests/media/fairplay/fps-mse-unmuxed-multiple-keys.html: * LayoutTests/http/tests/media/fairplay/fps-mse-unmuxed-same-key.html: * LayoutTests/platform/mac/TestExpectations: * Source/WebCore/html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::enterFullscreen): * Source/WebCore/platform/graphics/avfoundation/objc/CDMInstanceFairPlayStreamingAVFObjC.h: * Source/WebCore/platform/graphics/avfoundation/objc/CDMInstanceFairPlayStreamingAVFObjC.mm: (WebCore::CDMInstanceFairPlayStreamingAVFObjC::addKeyStatusesChangedObserver): (WebCore::CDMInstanceFairPlayStreamingAVFObjC::removeKeyStatusesChangedObserver): * Source/WebCore/platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.h: * Source/WebCore/platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm: (WebCore::SourceBufferPrivateAVFObjC::SourceBufferPrivateAVFObjC): (WebCore::SourceBufferPrivateAVFObjC::setCDMInstance): (WebCore::SourceBufferPrivateAVFObjC::attemptToDecrypt): (WebCore::SourceBufferPrivateAVFObjC::tryToEnqueueBlockedSamples): (WebCore::SourceBufferPrivateAVFObjC::keyStatusesChanged): Renamed to tryToEnqueueBlockedSamples. Canonical link: https://commits.webkit.org/273340@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 408b91: Use more smart pointers in BroadcastChannel.cpp
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 408b91216101f3c318f75948aef3dbe85e0bf61e https://github.com/WebKit/WebKit/commit/408b91216101f3c318f75948aef3dbe85e0bf61e Author: Chris Dumez Date: 2024-01-22 (Mon, 22 Jan 2024) Changed paths: M Source/WebCore/dom/BroadcastChannel.cpp M Source/WebCore/dom/BroadcastChannel.h M Source/WebCore/page/Page.cpp M Source/WebCore/page/Page.h Log Message: --- Use more smart pointers in BroadcastChannel.cpp https://bugs.webkit.org/show_bug.cgi?id=267883 Reviewed by Geoffrey Garen. * Source/WebCore/dom/BroadcastChannel.cpp: (WebCore::WTF_REQUIRES_LOCK): (WebCore::BroadcastChannel::MainThreadBridge::ensureOnMainThread): (WebCore::BroadcastChannel::MainThreadBridge::registerChannel): (WebCore::BroadcastChannel::MainThreadBridge::unregisterChannel): (WebCore::BroadcastChannel::MainThreadBridge::postMessage): (WebCore::BroadcastChannel::BroadcastChannel): (WebCore::BroadcastChannel::dispatchMessageTo): (): Deleted. * Source/WebCore/dom/BroadcastChannel.h: * Source/WebCore/page/Page.cpp: (WebCore::Page::protectedBroadcastChannelRegistry const): * Source/WebCore/page/Page.h: Canonical link: https://commits.webkit.org/273339@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 0d836c: [Gardening]: [ Monterrey+ wk2 iOS 17 Release ] imp...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 0d836cc209603445b2e733915d4553aedb4c8822 https://github.com/WebKit/WebKit/commit/0d836cc209603445b2e733915d4553aedb4c8822 Author: Jay saintfleur Date: 2024-01-22 (Mon, 22 Jan 2024) Changed paths: M LayoutTests/platform/ios-wk2/TestExpectations M LayoutTests/platform/mac-wk2/TestExpectations Log Message: --- [Gardening]: [ Monterrey+ wk2 iOS 17 Release ] imported/w3c/web-platform-tests/requestidlecallback/deadline-max-rAF-dynamic.html is a flaky failure https://bugs.webkit.org/show_bug.cgi?id=267796 rdar://121290178 Unreviewed test gardening. Adding test expectation * LayoutTests/platform/ios-wk2/TestExpectations: * LayoutTests/platform/mac-wk2/TestExpectations: Canonical link: https://commits.webkit.org/273338@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] f67af4: [WebXR] Adjust XRSession visible test
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: f67af466054c043a299acea2fefb5ae0da57a534 https://github.com/WebKit/WebKit/commit/f67af466054c043a299acea2fefb5ae0da57a534 Author: Dan Glastonbury Date: 2024-01-22 (Mon, 22 Jan 2024) Changed paths: M Source/WebCore/Modules/webxr/WebXRSession.cpp Log Message: --- [WebXR] Adjust XRSession visible test https://bugs.webkit.org/show_bug.cgi?id=256938 rdar://problem/109489889 Reviewed by Dean Jackson. XRVisibilityState is tristate: Visible, VisibleBlurred, Hidden. Previously only Visible was considered "visible" causing a JS SecurityError to be thrown when reporting poses in the "blurred" state, ie. when WebXR doesn't have input but should render. This change considers both Visible states as "visible" and Hidden as "not visible". * Source/WebCore/Modules/webxr/WebXRSession.cpp: (WebCore::WebXRSession::posesCanBeReported const): Canonical link: https://commits.webkit.org/273337@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 5d7c3b: [view-transitions] Create renderers for pseudo-ele...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 5d7c3bb3e28035d21e4461474204eac7493419c4 https://github.com/WebKit/WebKit/commit/5d7c3bb3e28035d21e4461474204eac7493419c4 Author: Tim Nguyen Date: 2024-01-22 (Mon, 22 Jan 2024) Changed paths: M Source/WebCore/Sources.txt M Source/WebCore/WebCore.xcodeproj/project.pbxproj M Source/WebCore/dom/ViewTransition.h M Source/WebCore/rendering/RenderView.cpp M Source/WebCore/rendering/RenderView.h M Source/WebCore/rendering/style/RenderStyle.h M Source/WebCore/rendering/style/RenderStyleInlines.h M Source/WebCore/rendering/style/RenderStyleSetters.h M Source/WebCore/rendering/style/StyleRareNonInheritedData.cpp M Source/WebCore/rendering/style/StyleRareNonInheritedData.h M Source/WebCore/rendering/updating/RenderTreeUpdater.cpp M Source/WebCore/rendering/updating/RenderTreeUpdater.h A Source/WebCore/rendering/updating/RenderTreeUpdaterViewTransition.cpp A Source/WebCore/rendering/updating/RenderTreeUpdaterViewTransition.h M Source/WebCore/style/StyleResolver.cpp Log Message: --- [view-transitions] Create renderers for pseudo-elements https://bugs.webkit.org/show_bug.cgi?id=265168 rdar://118667022 Reviewed by Antti Koivisto. Use the named elements map as input to build the pseudo element tree. * Source/WebCore/Sources.txt: * Source/WebCore/WebCore.xcodeproj/project.pbxproj: * Source/WebCore/dom/ViewTransition.h: (WebCore::OrderedNamedElementsMap::isEmpty const): * Source/WebCore/rendering/RenderView.cpp: (WebCore::RenderView::viewTransitionRoot const): (WebCore::RenderView::setViewTransitionRoot): * Source/WebCore/rendering/RenderView.h: * Source/WebCore/rendering/style/RenderStyle.h: * Source/WebCore/rendering/style/RenderStyleInlines.h: (WebCore::RenderStyle::functionalPseudoElementArgument const): * Source/WebCore/rendering/style/RenderStyleSetters.h: (WebCore::RenderStyle::setFunctionalPseudoElementArgument): * Source/WebCore/rendering/style/StyleRareNonInheritedData.cpp: (WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData): (WebCore::StyleRareNonInheritedData::operator== const): * Source/WebCore/rendering/style/StyleRareNonInheritedData.h: * Source/WebCore/rendering/updating/RenderTreeUpdater.cpp: (WebCore::RenderTreeUpdater::RenderTreeUpdater): (WebCore::RenderTreeUpdater::updateAfterDescendants): * Source/WebCore/rendering/updating/RenderTreeUpdater.h: (WebCore::RenderTreeUpdater::viewTransition): * Source/WebCore/rendering/updating/RenderTreeUpdaterViewTransition.cpp: Added. (WebCore::RenderTreeUpdater::ViewTransition::ViewTransition): (WebCore::RenderTreeUpdater::ViewTransition::updatePseudoElementTree): (WebCore::RenderTreeUpdater::ViewTransition::buildPseudoElementGroup): (WebCore::RenderTreeUpdater::ViewTransition::updatePseudoElementGroup): * Source/WebCore/rendering/updating/RenderTreeUpdaterViewTransition.h: Added. * Source/WebCore/style/StyleResolver.cpp: (WebCore::Style::Resolver::styleForPseudoElement): Canonical link: https://commits.webkit.org/273336@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 2afc03: Pass information about resource loads from WebPage...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 2afc03180fc116298060b5b592282c471f29225b https://github.com/WebKit/WebKit/commit/2afc03180fc116298060b5b592282c471f29225b Author: Brian Weinstein Date: 2024-01-22 (Mon, 22 Jan 2024) Changed paths: M Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionContextCocoa.mm M Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionControllerCocoa.mm M Source/WebKit/UIProcess/Extensions/WebExtensionContext.cpp M Source/WebKit/UIProcess/Extensions/WebExtensionContext.h M Source/WebKit/UIProcess/Extensions/WebExtensionController.h M Source/WebKit/UIProcess/WebPageProxy.cpp M Source/WebKit/WebProcess/Extensions/API/Cocoa/WebExtensionAPIWebRequestCocoa.mm M Source/WebKit/WebProcess/Extensions/WebExtensionContextProxy.h M Source/WebKit/WebProcess/Extensions/WebExtensionContextProxy.messages.in Log Message: --- Pass information about resource loads from WebPageProxy through the extensions controller machinery (needed for webRequest support) https://bugs.webkit.org/show_bug.cgi?id=267882 rdar://114823223 Reviewed by Timothy Hatcher. The events still aren't fired in the extensions' web process yet, but they will be in the next PR. * Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionContextCocoa.mm: (WebKit::WebExtensionContext::hasPermissionToSendWebRequestEvent): Check that: - The extension can see the tab - The extension has access to the page URL - The extension has access to the resource URL - The extension has access to the URL specified in the ResourceLoadInfo object (WebKit::WebExtensionContext::resourceLoadDidSendRequest): Send a message to the WebExtensionContextProxy. (WebKit::WebExtensionContext::resourceLoadDidPerformHTTPRedirection): Ditto. (WebKit::WebExtensionContext::resourceLoadDidReceiveChallenge): Ditto. (WebKit::WebExtensionContext::resourceLoadDidReceiveResponse): Ditto. (WebKit::WebExtensionContext::resourceLoadDidCompleteWithError): Ditto. * Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionControllerCocoa.mm: (WebKit::WebExtensionController::resourceLoadDidSendRequest): Call into each WebExtensionContext. (WebKit::WebExtensionController::resourceLoadDidPerformHTTPRedirection): Ditto. (WebKit::WebExtensionController::resourceLoadDidReceiveChallenge): Ditto. (WebKit::WebExtensionController::resourceLoadDidReceiveResponse): Ditto. (WebKit::WebExtensionController::resourceLoadDidCompleteWithError): Ditto. * Source/WebKit/UIProcess/Extensions/WebExtensionContext.cpp: (WebKit::WebExtensionContext::processes const): Update the method to get all processes for an event to take a set of events. * Source/WebKit/UIProcess/Extensions/WebExtensionContext.h: (WebKit::WebExtensionContext::sendToProcessesForEvents): * Source/WebKit/UIProcess/Extensions/WebExtensionController.h: * Source/WebKit/UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::resourceLoadDidSendRequest): Call into the WebExtensionController if it exists. (WebKit::WebPageProxy::resourceLoadDidPerformHTTPRedirection): Ditto. (WebKit::WebPageProxy::resourceLoadDidReceiveChallenge): Ditto. (WebKit::WebPageProxy::resourceLoadDidReceiveResponse): Ditto. (WebKit::WebPageProxy::resourceLoadDidCompleteWithError): Ditto. * Source/WebKit/WebProcess/Extensions/API/Cocoa/WebExtensionAPIWebRequestCocoa.mm: (WebKit::WebExtensionContextProxy::resourceLoadDidSendRequest): Add a FIXME to implement this. (WebKit::WebExtensionContextProxy::resourceLoadDidPerformHTTPRedirection): Ditto. (WebKit::WebExtensionContextProxy::resourceLoadDidReceiveChallenge): Ditto. (WebKit::WebExtensionContextProxy::resourceLoadDidReceiveResponse): Ditto. (WebKit::WebExtensionContextProxy::resourceLoadDidCompleteWithError): Ditto. * Source/WebKit/WebProcess/Extensions/WebExtensionContextProxy.h: * Source/WebKit/WebProcess/Extensions/WebExtensionContextProxy.messages.in: Canonical link: https://commits.webkit.org/273335@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] b9361c: [GLib] Write bwrapinfo.json to disk for xdg-deskto...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: b9361c774194d8be63e58375908afa5b1eb9a30f https://github.com/WebKit/WebKit/commit/b9361c774194d8be63e58375908afa5b1eb9a30f Author: Patrick Griffis Date: 2024-01-22 (Mon, 22 Jan 2024) Changed paths: M Source/WebKit/UIProcess/Launcher/glib/BubblewrapLauncher.cpp Log Message: --- [GLib] Write bwrapinfo.json to disk for xdg-desktop-portal https://bugs.webkit.org/show_bug.cgi?id=238403 Reviewed by Michael Catanzaro. The Realtime portal in xdg-desktop-portal reads bwrapinfo.json to get the child pid. * Source/WebKit/UIProcess/Launcher/glib/BubblewrapLauncher.cpp: (WebKit::createBwrapInfo): (WebKit::createFlatpakInfo): (WebKit::bubblewrapSpawn): Canonical link: https://commits.webkit.org/273334@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] a5d41f: [Gardening]: REGRESSION [ Sonoma wk2 Release ] fas...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: a5d41f962b7192e7d21052add1c56fed87ccd2a2 https://github.com/WebKit/WebKit/commit/a5d41f962b7192e7d21052add1c56fed87ccd2a2 Author: Jay saintfleur Date: 2024-01-22 (Mon, 22 Jan 2024) Changed paths: M LayoutTests/platform/mac-wk2/TestExpectations Log Message: --- [Gardening]: REGRESSION [ Sonoma wk2 Release ] fast/css/nested-table-with-collapsed-borders.html is a flaky image failure https://bugs.webkit.org/show_bug.cgi?id=267891 rdar://121402051 Unreviewed test gardening. Adding test expectation * LayoutTests/platform/mac-wk2/TestExpectations: Canonical link: https://commits.webkit.org/27@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] d6894f: Add rding0207 to contributors.json
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: d6894f5b05ed39f8bbbe59b3ead557f7ff037740 https://github.com/WebKit/WebKit/commit/d6894f5b05ed39f8bbbe59b3ead557f7ff037740 Author: Jonathan Bedard Date: 2024-01-22 (Mon, 22 Jan 2024) Changed paths: M metadata/contributors.json Log Message: --- Add rding0207 to contributors.json Unreviewed contributor addition. * metadata/contributors.json: Add Ren Ding (rding0207). Canonical link: https://commits.webkit.org/273332@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 101cda: Embedder should be able to ignore app utilities links
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 101cda37cddc0d04789cca1c0ac3a217ebb69dd6 https://github.com/WebKit/WebKit/commit/101cda37cddc0d04789cca1c0ac3a217ebb69dd6 Author: Ben Nham Date: 2024-01-22 (Mon, 22 Jan 2024) Changed paths: M Source/WebKit/UIProcess/Cocoa/NavigationState.mm Log Message: --- Embedder should be able to ignore app utilities links https://bugs.webkit.org/show_bug.cgi?id=267874 rdar://121389168 Reviewed by Brady Eidson. Currently we unconditionally handle all WKApplicationUtilities links in WebKit without notifying the embedder via the navigation delegate. To be more consistent with other types of link handling, we should instead notify the navigation delegate about such links, and only handle them in WebKit if the embedder responds to the delegate callback telling us to process that link (e.g. via WKNavigationActionPolicyAllow). * Source/WebKit/UIProcess/Cocoa/NavigationState.mm: (WebKit::tryInterceptNavigation): (WebKit::NavigationState::NavigationClient::decidePolicyForNavigationAction): Canonical link: https://commits.webkit.org/273331@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] f8ba80: Lazily construct Document owned objects
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: f8ba808cb40f52408fa710408a632086ecdd5b80 https://github.com/WebKit/WebKit/commit/f8ba808cb40f52408fa710408a632086ecdd5b80 Author: Ryosuke Niwa Date: 2024-01-22 (Mon, 22 Jan 2024) Changed paths: M Source/WebCore/Modules/fetch/FetchRequest.cpp M Source/WebCore/Modules/mediasession/MediaMetadata.cpp M Source/WebCore/Modules/mediasource/MediaSource.cpp M Source/WebCore/Modules/reporting/ReportingObserver.cpp M Source/WebCore/Modules/websockets/ThreadableWebSocketChannel.cpp M Source/WebCore/bindings/js/JSDOMGlobalObject.cpp M Source/WebCore/bindings/js/JSDOMWindowBase.cpp M Source/WebCore/bindings/scripts/CodeGeneratorJS.pm M Source/WebCore/bindings/scripts/test/JS/JSTestEventTarget.cpp M Source/WebCore/bindings/scripts/test/JS/JSTestIndexedSetterNoIdentifier.cpp M Source/WebCore/bindings/scripts/test/JS/JSTestIndexedSetterThrowingException.cpp M Source/WebCore/bindings/scripts/test/JS/JSTestIndexedSetterWithIdentifier.cpp M Source/WebCore/bindings/scripts/test/JS/JSTestLegacyOverrideBuiltIns.cpp M Source/WebCore/bindings/scripts/test/JS/JSTestNamedAndIndexedSetterNoIdentifier.cpp M Source/WebCore/bindings/scripts/test/JS/JSTestNamedAndIndexedSetterThrowingException.cpp M Source/WebCore/bindings/scripts/test/JS/JSTestNamedAndIndexedSetterWithIdentifier.cpp M Source/WebCore/bindings/scripts/test/JS/JSTestNamedDeleterNoIdentifier.cpp M Source/WebCore/bindings/scripts/test/JS/JSTestNamedDeleterThrowingException.cpp M Source/WebCore/bindings/scripts/test/JS/JSTestNamedDeleterWithIdentifier.cpp M Source/WebCore/bindings/scripts/test/JS/JSTestNamedDeleterWithIndexedGetter.cpp M Source/WebCore/bindings/scripts/test/JS/JSTestNamedGetterCallWith.cpp M Source/WebCore/bindings/scripts/test/JS/JSTestNamedGetterNoIdentifier.cpp M Source/WebCore/bindings/scripts/test/JS/JSTestNamedGetterWithIdentifier.cpp M Source/WebCore/bindings/scripts/test/JS/JSTestNamedSetterNoIdentifier.cpp M Source/WebCore/bindings/scripts/test/JS/JSTestNamedSetterThrowingException.cpp M Source/WebCore/bindings/scripts/test/JS/JSTestNamedSetterWithIdentifier.cpp M Source/WebCore/bindings/scripts/test/JS/JSTestNamedSetterWithIndexedGetter.cpp M Source/WebCore/bindings/scripts/test/JS/JSTestNamedSetterWithIndexedGetterAndSetter.cpp M Source/WebCore/bindings/scripts/test/JS/JSTestNamedSetterWithLegacyOverrideBuiltIns.cpp M Source/WebCore/bindings/scripts/test/JS/JSTestNamedSetterWithLegacyUnforgeableProperties.cpp M Source/WebCore/bindings/scripts/test/JS/JSTestNamedSetterWithLegacyUnforgeablePropertiesAndLegacyOverrideBuiltIns.cpp M Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp M Source/WebCore/bindings/scripts/test/JS/JSTestPluginInterface.cpp M Source/WebCore/contentextensions/ContentExtensionsBackend.cpp M Source/WebCore/css/CSSFontFace.cpp M Source/WebCore/css/CSSFontFaceSet.cpp M Source/WebCore/css/CSSFontFaceSource.cpp M Source/WebCore/css/CSSFontSelector.cpp M Source/WebCore/css/FontFace.cpp M Source/WebCore/css/FontFaceSet.cpp M Source/WebCore/css/MediaQueryList.cpp M Source/WebCore/css/PropertySetCSSStyleDeclaration.cpp M Source/WebCore/css/SelectorCheckerTestFunctions.h M Source/WebCore/css/query/MediaQueryFeatures.cpp M Source/WebCore/dom/CustomElementRegistry.cpp M Source/WebCore/dom/Document.cpp M Source/WebCore/dom/Document.h M Source/WebCore/dom/DocumentFontLoader.cpp M Source/WebCore/dom/DocumentInlines.h M Source/WebCore/dom/DocumentMarkerController.cpp M Source/WebCore/dom/DocumentMarkerController.h M Source/WebCore/dom/DocumentOrShadowRootFullscreen.cpp M Source/WebCore/dom/DocumentStorageAccess.cpp M Source/WebCore/dom/Element.cpp M Source/WebCore/dom/ExtensionStyleSheets.h M Source/WebCore/dom/FullscreenManager.cpp M Source/WebCore/dom/TreeScope.cpp M Source/WebCore/dom/TreeScope.h M Source/WebCore/dom/TreeScopeInlines.h M Source/WebCore/editing/AlternativeTextController.cpp M Source/WebCore/editing/Editor.cpp M Source/WebCore/editing/SplitTextNodeCommand.cpp M Source/WebCore/editing/markup.cpp M Source/WebCore/history/BackForwardCache.cpp M Source/WebCore/html/FeaturePolicy.cpp M Source/WebCore/html/HTMLCanvasElement.cpp M Source/WebCore/html/HTMLDataListElement.cpp M Source/WebCore/html/HTMLDocument.cpp M Source/WebCore/html/HTMLElement.cpp M Source/WebCore/html/HTMLFormControlElement.cpp M Source/WebCore/html/HTMLFrameElementBase.cpp M Source/WebCore/html/HTMLIFrameElement.cpp M Source/WebCore/html/HTMLInputElement.cpp M Source/WebCore/html/HTMLMediaElement.cpp M Source/WebCore/html/HTMLMetaElement.cpp M Source/WebCore/html/MediaElementSession.cpp M Source/WebCore/html/canvas/CanvasRenderingContext2D.cpp
[webkit-changes] [WebKit/WebKit] 778f3d: [Gardening]: REGRESSION (273260@main): [ iOS17 ]AS...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 778f3d67898d1768529dc56c7113e5d156817873 https://github.com/WebKit/WebKit/commit/778f3d67898d1768529dc56c7113e5d156817873 Author: Marta Darbinyan Date: 2024-01-22 (Mon, 22 Jan 2024) Changed paths: M LayoutTests/platform/ios-wk2/TestExpectations Log Message: --- [Gardening]: REGRESSION (273260@main): [ iOS17 ]ASSERTION FAILED: isStackingContext() result of 5 tests in fast/forms/switch to consistent timeout/crash https://bugs.webkit.org/show_bug.cgi?id=267890 rdar://121400496 Unreviewed test gardening. Adding test expectation * LayoutTests/platform/ios-wk2/TestExpectations: Canonical link: https://commits.webkit.org/273329@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] b571ec: AX: Isolated object can be detached in the midst o...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: b571ec5131dcca906981b9a477d7b71e9605b6a6 https://github.com/WebKit/WebKit/commit/b571ec5131dcca906981b9a477d7b71e9605b6a6 Author: Tyler Wilcock Date: 2024-01-22 (Mon, 22 Jan 2024) Changed paths: M Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm Log Message: --- AX: Isolated object can be detached in the midst of serving AXChildren, causing nullptr dereference https://bugs.webkit.org/show_bug.cgi?id=267786 rdar://problem/121282648 Reviewed by Chris Fleizach. The following sequence is possible: 1. accessibilityAttributeValue begins, we protect the initial backingObject with a RefPtr 2. We start handling the AXChildren branch 3. We call childrenVectorSize in the middle of doing so 4. This calls self.axBackingObject->children(), which in turn calls AXIsolatedObject::updateBackingStore, in turn calling AXIsolatedTree::applyPendingChanges 5. For some reason, either self.axBackingObject or its ancestor is in m_pendingSubtreeRemovals, causing the wrapper to detach its m_isolatedObject 6. We jump back out to accessibilityAttributeValue, and try to return self.childrenVectorArray at the very end. But our self.axBackingObject is nullptr now, and we dereference it without checking for nullptr, and crash We can fix this by using the RefPtr protected `backingObject` we have at the top of every method rather than the backing object associated with the wrapper, which can become detached. This patch addresses some, but not all of self.axBackingObject dereferences (overall addressing the dereference for this specific crash, and others too). * Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm: (screenToContents): (scrollViewParent): (-[WebAccessibilityObjectWrapper accessibilityAttributeValue:]): (-[WebAccessibilityObjectWrapper accessibilityAttributeValue:forParameter:]): (-[WebAccessibilityObjectWrapper accessibilityArrayAttributeCount:]): (-[WebAccessibilityObjectWrapper accessibilityArrayAttributeValues:index:maxCount:]): (-[WebAccessibilityObjectWrapper screenToContents:]): Deleted. (-[WebAccessibilityObjectWrapper childrenVectorSize]): Deleted. (-[WebAccessibilityObjectWrapper childrenVectorArray]): Deleted. (-[WebAccessibilityObjectWrapper _computedRoleString]): Deleted. (-[WebAccessibilityObjectWrapper scrollViewParent]): Deleted. Canonical link: https://commits.webkit.org/273328@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] ecb2ea: [Gardening]: REGRESSION (272891@main): [ Sonoma wk...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: ecb2ea021067431f4862cabcc433051a3e502031 https://github.com/WebKit/WebKit/commit/ecb2ea021067431f4862cabcc433051a3e502031 Author: Karl Rackler Date: 2024-01-22 (Mon, 22 Jan 2024) Changed paths: M LayoutTests/platform/mac-wk1/TestExpectations Log Message: --- [Gardening]: REGRESSION (272891@main): [ Sonoma wk1 ] css3/filters/effect-grayscale.html is a consistent image failure https://bugs.webkit.org/show_bug.cgi?id=267888 rdar://121399721 Unreviewed test gardening. Add test expectation. * LayoutTests/platform/mac-wk1/TestExpectations: Canonical link: https://commits.webkit.org/273327@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 40e9c1: Adopt more smart pointers under Source/WebCore/his...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 40e9c18174eebf0b67720ece5abe096eb763d90f https://github.com/WebKit/WebKit/commit/40e9c18174eebf0b67720ece5abe096eb763d90f Author: Chris Dumez Date: 2024-01-22 (Mon, 22 Jan 2024) Changed paths: M Source/WebCore/history/BackForwardCache.cpp M Source/WebCore/history/BackForwardController.cpp M Source/WebCore/history/BackForwardController.h M Source/WebCore/history/CachedFrame.cpp M Source/WebCore/history/CachedFrame.h M Source/WebCore/history/CachedPage.cpp M Source/WebCore/history/CachedPage.h M Source/WebCore/page/DiagnosticLoggingClient.h M Source/WebCore/page/LocalFrame.cpp M Source/WebCore/page/LocalFrame.h Log Message: --- Adopt more smart pointers under Source/WebCore/history/ https://bugs.webkit.org/show_bug.cgi?id=267877 Reviewed by Geoffrey Garen. * Source/WebCore/history/BackForwardCache.cpp: (WebCore::canCacheFrame): (WebCore::canCachePage): (WebCore::BackForwardCache::markPagesForDeviceOrPageScaleChanged): (WebCore::BackForwardCache::markPagesForContentsSizeChanged): (WebCore::BackForwardCache::markPagesForCaptionPreferencesChanged): (WebCore::destroyRenderTree): (WebCore::firePageHideEventRecursively): (WebCore::BackForwardCache::trySuspendPage): (WebCore::BackForwardCache::take): (WebCore::BackForwardCache::removeAllItemsForPage): (WebCore::BackForwardCache::get): (WebCore::BackForwardCache::prune): (WebCore::BackForwardCache::clearEntriesForOrigins): * Source/WebCore/history/BackForwardController.cpp: (WebCore::BackForwardController::protectedPage const): (WebCore::BackForwardController::protectedClient const): (WebCore::BackForwardController::goBackOrForward): (WebCore::BackForwardController::goBack): (WebCore::BackForwardController::goForward): (WebCore::BackForwardController::addItem): (WebCore::BackForwardController::setCurrentItem): (WebCore::BackForwardController::containsItem const): (WebCore::BackForwardController::count const): (WebCore::BackForwardController::backCount const): (WebCore::BackForwardController::forwardCount const): (WebCore::BackForwardController::itemAtIndex): (WebCore::BackForwardController::close): * Source/WebCore/history/BackForwardController.h: * Source/WebCore/history/CachedFrame.cpp: (WebCore::CachedFrameBase::protectedView const): (WebCore::CachedFrameBase::restore): (WebCore::CachedFrame::CachedFrame): (WebCore::CachedFrame::open): (WebCore::CachedFrame::destroy): * Source/WebCore/history/CachedFrame.h: * Source/WebCore/history/CachedPage.cpp: (WebCore::firePageShowEvent): (WebCore::CachedPageRestorationScope::CachedPageRestorationScope): (WebCore::CachedPageRestorationScope::~CachedPageRestorationScope): (WebCore::CachedPage::restore): * Source/WebCore/history/CachedPage.h: (WebCore::CachedPage::page const): * Source/WebCore/page/DiagnosticLoggingClient.h: * Source/WebCore/page/LocalFrame.cpp: (WebCore::LocalFrame::checkedSelection const): * Source/WebCore/page/LocalFrame.h: Canonical link: https://commits.webkit.org/273326@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] d310a3: [Gardening]: [ Sonoma Release wk2 ] fast/scrolling...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: d310a35beec6a4eed9d7fa9af811fdeb43bb712d https://github.com/WebKit/WebKit/commit/d310a35beec6a4eed9d7fa9af811fdeb43bb712d Author: Jay saintfleur Date: 2024-01-22 (Mon, 22 Jan 2024) Changed paths: M LayoutTests/platform/mac-wk2/TestExpectations Log Message: --- [Gardening]: [ Sonoma Release wk2 ] fast/scrolling/rtl-scrollbars-overlay-no-push-contents.html is a flaky image failure https://bugs.webkit.org/show_bug.cgi?id=267885 rdar://121398601 Unreviewed test gardening. Adding test expectation * LayoutTests/platform/mac-wk2/TestExpectations: Canonical link: https://commits.webkit.org/273325@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 252923: Use mousePointerEventType() helper instead of hard...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 252923d1ee75b036d0bee06d54ec7e0ea4e257cd https://github.com/WebKit/WebKit/commit/252923d1ee75b036d0bee06d54ec7e0ea4e257cd Author: Abrar Rahman Protyasha Date: 2024-01-22 (Mon, 22 Jan 2024) Changed paths: M Source/WebCore/platform/PlatformMouseEvent.h M Tools/TestWebKitAPI/Tests/WebKitCocoa/iOSMouseSupport.mm Log Message: --- Use mousePointerEventType() helper instead of hardcoded "mouse" string literal https://bugs.webkit.org/show_bug.cgi?id=267848 rdar://121360954 Reviewed by Wenson Hsieh. The codebase has a couple of spots where we use the string literal "mouse" to denote a mouse pointer type. In this commit, we replace these hardcoded literals in favor of the namesake helper declared in PointerEventTypeNames.h * Source/WebCore/platform/PlatformMouseEvent.h: * Tools/TestWebKitAPI/Tests/WebKitCocoa/iOSMouseSupport.mm: (TestWebKitAPI::TEST): Canonical link: https://commits.webkit.org/273324@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] e0a425: Speedometer 3: WebContent spends a lot of time in ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: e0a42565e3a2879ec1e7c1bc87937dc2d8b779eb https://github.com/WebKit/WebKit/commit/e0a42565e3a2879ec1e7c1bc87937dc2d8b779eb Author: Matt Woodrow Date: 2024-01-22 (Mon, 22 Jan 2024) Changed paths: M LayoutTests/compositing/repaint/copy-forward-dirty-region-purged-backbuffer.html M Source/WebKit/CMakeLists.txt M Source/WebKit/DerivedSources-input.xcfilelist M Source/WebKit/DerivedSources-output.xcfilelist M Source/WebKit/DerivedSources.make M Source/WebKit/GPUProcess/graphics/RemoteImageBufferSet.cpp M Source/WebKit/GPUProcess/graphics/RemoteImageBufferSet.h M Source/WebKit/GPUProcess/graphics/RemoteRenderingBackend.cpp M Source/WebKit/GPUProcess/graphics/RemoteRenderingBackend.h M Source/WebKit/GPUProcess/graphics/RemoteRenderingBackend.messages.in M Source/WebKit/Scripts/webkit/messages.py M Source/WebKit/Shared/RemoteLayerTree/BufferAndBackendInfo.h M Source/WebKit/Shared/RemoteLayerTree/BufferAndBackendInfo.serialization.in M Source/WebKit/Shared/RemoteLayerTree/RemoteLayerBackingStore.h M Source/WebKit/Shared/RemoteLayerTree/RemoteLayerBackingStore.mm M Source/WebKit/Shared/RemoteLayerTree/RemoteLayerBackingStoreCollection.h M Source/WebKit/Shared/RemoteLayerTree/RemoteLayerBackingStoreCollection.mm M Source/WebKit/Shared/RemoteLayerTree/RemoteLayerTree.serialization.in M Source/WebKit/Shared/RemoteLayerTree/RemoteLayerWithInProcessRenderingBackingStore.h M Source/WebKit/Shared/RemoteLayerTree/RemoteLayerWithInProcessRenderingBackingStore.mm M Source/WebKit/Shared/RemoteLayerTree/RemoteLayerWithRemoteRenderingBackingStore.h M Source/WebKit/Shared/RemoteLayerTree/RemoteLayerWithRemoteRenderingBackingStore.mm M Source/WebKit/SourcesCocoa.txt M Source/WebKit/UIProcess/RemoteLayerTree/RemoteLayerTreeDrawingAreaProxy.h M Source/WebKit/UIProcess/RemoteLayerTree/RemoteLayerTreeDrawingAreaProxy.messages.in M Source/WebKit/UIProcess/RemoteLayerTree/RemoteLayerTreeDrawingAreaProxy.mm M Source/WebKit/WebKit.xcodeproj/project.pbxproj M Source/WebKit/WebProcess/GPU/graphics/RemoteImageBufferSetProxy.cpp M Source/WebKit/WebProcess/GPU/graphics/RemoteImageBufferSetProxy.h A Source/WebKit/WebProcess/GPU/graphics/RemoteImageBufferSetProxy.messages.in M Source/WebKit/WebProcess/GPU/graphics/RemoteRenderingBackendProxy.cpp M Source/WebKit/WebProcess/GPU/graphics/RemoteRenderingBackendProxy.h M Source/WebKit/WebProcess/WebPage/RemoteLayerTree/RemoteLayerTreeDrawingArea.h M Source/WebKit/WebProcess/WebPage/RemoteLayerTree/RemoteLayerTreeDrawingArea.mm Log Message: --- Speedometer 3: WebContent spends a lot of time in RemoteImageBufferProxy::ensureBackendCreated. https://bugs.webkit.org/show_bug.cgi?id=266728 Reviewed by Kimmo Kinnunen. Synchronously waiting on the ImageBufferBackendHandle for an ImageBufferSet can block the main thread while trying to serialize a transaction. This splits the response to prepareImageBufferSetsForDisplay into two parts, one that is only present when needed as a sync reponse, and another as a separate message returned asynchronously. The new response message 'DidPrepareForDisplay' stores the resulting buffer backend handles on the RemoteImageBufferSetProxy and notifies a Condition, so that they can be waited on from a different thread. RemoteLayerTree transaction serialization on the main thread now just serializes an identifier for the image buffer set and doesn't block. The transaction flusher thread waits for any incoming backend handles (as well as the existing wait on drawing flushing), and builds a hashamp of image buffer set identifier to response data and appends this on to the remote layer tree transaction. RemoteLayerTreeDrawingAreaProxy uses the trailing hashmap to copy across any needed backend handles from the response hashmap into the appropriate RemoteLayerBackingStoreProperties. * Source/WebKit/CMakeLists.txt: * Source/WebKit/DerivedSources-input.xcfilelist: * Source/WebKit/DerivedSources-output.xcfilelist: * Source/WebKit/DerivedSources.make: * Source/WebKit/GPUProcess/graphics/RemoteImageBufferSet.cpp: (WebKit::RemoteImageBufferSet::ensureBufferForDisplay): * Source/WebKit/GPUProcess/graphics/RemoteImageBufferSet.h: * Source/WebKit/GPUProcess/graphics/RemoteRenderingBackend.cpp: (WebKit::RemoteRenderingBackend::prepareImageBufferSetsForDisplay): (WebKit::RemoteRenderingBackend::prepareImageBufferSetsForDisplaySync): * Source/WebKit/GPUProcess/graphics/RemoteRenderingBackend.h: (WebKit::RemoteRenderingBackend::identifier): * Source/WebKit/GPUProcess/graphics/RemoteRenderingBackend.messages.in: * Source/WebKit/Scripts/webkit/messages.py: (types_that_must_be_moved): (class_template_headers): (headers_for_type): * Source/WebKit/Shared/RemoteLayerTree/BufferAndBackendInfo.h: * Source/WebKit/Shared/RemoteLayerTree/
[webkit-changes] [WebKit/WebKit] 2e6f29: [Gardening]:[ Sonoma wk2 ] fast/scrolling/mac/scro...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 2e6f2978b78c091d46767fdfeafe2f93a9088bde https://github.com/WebKit/WebKit/commit/2e6f2978b78c091d46767fdfeafe2f93a9088bde Author: Jay saintfleur Date: 2024-01-22 (Mon, 22 Jan 2024) Changed paths: M LayoutTests/platform/mac-wk2/TestExpectations Log Message: --- [Gardening]:[ Sonoma wk2 ] fast/scrolling/mac/scrollbars/select-overlay-scrollbar-reveal.html is a flaky timeout https://bugs.webkit.org/show_bug.cgi?id=267880 rdar://problem/121393424 Unreviewed test gardening. Adding test expectation * LayoutTests/platform/mac-wk2/TestExpectations: Canonical link: https://commits.webkit.org/273322@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 180634: REGRESSION(273148@main): Crash on veggiegrill.com
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 18063444ac9927b32405146edf1424e6538ce03a https://github.com/WebKit/WebKit/commit/18063444ac9927b32405146edf1424e6538ce03a Author: Ryosuke Niwa Date: 2024-01-22 (Mon, 22 Jan 2024) Changed paths: M Source/WebCore/loader/ImageLoader.cpp Log Message: --- REGRESSION(273148@main): Crash on veggiegrill.com https://bugs.webkit.org/show_bug.cgi?id=267878 Reviewed by Alex Christensen and Chris Dumez. There are some cases in which we enter this function with m_image being nullptr. Call updateFromElementIgnoringPreviousError in those cases. No new tests since I couldn't create a reliable reduction. The issue seems to be highly timing sensitive. * Source/WebCore/loader/ImageLoader.cpp: (WebCore::ImageLoader::updateFromElementIgnoringPreviousErrorToSameValue): Canonical link: https://commits.webkit.org/273321@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] fe1e48: Invalidate GlyphDisplayListCache entries in more p...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: fe1e4812260edf0b2117c1f78ddecd7c3d584f86 https://github.com/WebKit/WebKit/commit/fe1e4812260edf0b2117c1f78ddecd7c3d584f86 Author: Cameron McCormack Date: 2024-01-22 (Mon, 22 Jan 2024) Changed paths: M Source/WebCore/Headers.cmake M Source/WebCore/Sources.txt M Source/WebCore/WebCore.xcodeproj/project.pbxproj M Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayBox.h M Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayContent.cpp M Source/WebCore/layout/integration/inline/LayoutIntegrationInlineContent.cpp M Source/WebCore/layout/integration/inline/LayoutIntegrationInlineContent.h M Source/WebCore/rendering/GlyphDisplayListCache.cpp M Source/WebCore/rendering/GlyphDisplayListCache.h A Source/WebCore/rendering/GlyphDisplayListCacheRemoval.cpp A Source/WebCore/rendering/GlyphDisplayListCacheRemoval.h M Source/WebCore/rendering/LegacyInlineBox.h M Source/WebCore/rendering/LegacyInlineTextBox.cpp M Source/WebCore/rendering/LegacyInlineTextBox.h M Source/WebCore/rendering/ReferencedSVGResources.cpp M Source/WebCore/rendering/TextPainter.h Log Message: --- Invalidate GlyphDisplayListCache entries in more places https://bugs.webkit.org/show_bug.cgi?id=267843 rdar://119833765 Reviewed by Simon Fraser. With IFC, we currently remove entries from the GlyphDisplayListCache in the InlineDisplay::Content destructor, and in some of the LayoutIntegration::InlineContent mutation methods. But we are not removing enough entries, since we use InlineDisplay::Box pointers as the GlyphDisplayListCache::m_entriesForLayoutRun keys, but we store InlineDisplay::Box objects in vectors, so they can move around in memory. This can cause us to replay the wrong display list, if we're unlucky enough to place an InlineDisplay::Box at the same address as one of the stale pointers. (This is not a security issue, since we only use the InlineDisplay::Box pointer as an opaque key, and we always hold a strong reference to the display list stored in the map.) Change to remove entries from the GlyphDisplayListCache in the destructor of InlineDisplay::Box instead. Store a bit on InlineDisplay::Box and LegacyInlineTextBox to record whether the box is present in the GlyphDisplayListCache, and only attempt to remove it if the bit is set. This avoids the overhead of hashing the pointer and looking up the GlyphDisplayListCache map in the common case of the cache not being engaged (and, for InlineDisplay::Box, if it's not a text box). (This does add an explicit destructor to InlineDisplay::Box, but the class already has a non-trivial destructor due to the CheckedPtr it stores.) * Source/WebCore/Headers.cmake: * Source/WebCore/Sources.txt: * Source/WebCore/WebCore.xcodeproj/project.pbxproj: * Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayBox.h: (WebCore::InlineDisplay::Box::setIsInGlyphDisplayListCache): (WebCore::InlineDisplay::Box::Box): (WebCore::InlineDisplay::Box::~Box): (WebCore::InlineDisplay::Box::removeFromGlyphDisplayListCache): * Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayContent.cpp: (WebCore::InlineDisplay::Content::clear): (WebCore::InlineDisplay::Content::set): (WebCore::InlineDisplay::Content::remove): (WebCore::InlineDisplay::invalidateGlyphCache): Deleted. * Source/WebCore/layout/integration/inline/LayoutIntegrationInlineContent.cpp: (WebCore::LayoutIntegration::InlineContent::~InlineContent): Deleted. * Source/WebCore/layout/integration/inline/LayoutIntegrationInlineContent.h: * Source/WebCore/rendering/GlyphDisplayListCache.cpp: (WebCore::GlyphDisplayListCache::getDisplayList): (WebCore::GlyphDisplayListCache::get): * Source/WebCore/rendering/GlyphDisplayListCache.h: (WebCore::GlyphDisplayListCache::get): Deleted. * Source/WebCore/rendering/GlyphDisplayListCacheRemoval.cpp: Added. (WebCore::removeBoxFromGlyphDisplayListCache): * Source/WebCore/rendering/GlyphDisplayListCacheRemoval.h: Added. * Source/WebCore/rendering/LegacyInlineBox.h: (WebCore::LegacyInlineBox::isInGlyphDisplayListCache const): (WebCore::LegacyInlineBox::setIsInGlyphDisplayListCache): * Source/WebCore/rendering/LegacyInlineTextBox.cpp: (WebCore::LegacyInlineTextBox::~LegacyInlineTextBox): * Source/WebCore/rendering/LegacyInlineTextBox.h: (WebCore::LegacyInlineTextBox::removeFromGlyphDisplayListCache): * Source/WebCore/rendering/TextPainter.h: (WebCore::TextPainter::setGlyphDisplayListIfNeeded): (WebCore::TextPainter::removeGlyphDisplayList): Deleted. Canonical link: https://commits.webkit.org/273320@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] e657a3: startFrom parameter should be unsigned
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: e657a3449fbfd115a1db854fa1c769efa4fe299f https://github.com/WebKit/WebKit/commit/e657a3449fbfd115a1db854fa1c769efa4fe299f Author: Rose <83477269+ataridre...@users.noreply.github.com> Date: 2024-01-22 (Mon, 22 Jan 2024) Changed paths: M Source/JavaScriptCore/yarr/RegularExpression.cpp M Source/JavaScriptCore/yarr/RegularExpression.h Log Message: --- startFrom parameter should be unsigned https://bugs.webkit.org/show_bug.cgi?id=255527 Reviewed by Alexey Shvayka. The value being passed as this argument always unsigned anyway, and when used within the match function itself, it is always being passed to another method or function, which takes an unsigned value, not a signed one. * Source/JavaScriptCore/yarr/RegularExpression.cpp: (JSC::Yarr::RegularExpression::match const): (JSC::Yarr::replace): * Source/JavaScriptCore/yarr/RegularExpression.h: Canonical link: https://commits.webkit.org/273319@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] c1f8a9: Unreviewed, build fix for CLoop
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: c1f8a9e819201b59cacc047715b30dd2b4a1df30 https://github.com/WebKit/WebKit/commit/c1f8a9e819201b59cacc047715b30dd2b4a1df30 Author: Yusuke Suzuki Date: 2024-01-22 (Mon, 22 Jan 2024) Changed paths: M Source/JavaScriptCore/llint/LowLevelInterpreter.cpp Log Message: --- Unreviewed, build fix for CLoop https://bugs.webkit.org/show_bug.cgi?id=267881 rdar://121391447 * Source/JavaScriptCore/llint/LowLevelInterpreter.cpp: (JSC::CLoop::execute): Canonical link: https://commits.webkit.org/273318@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] fd24e6: Adopt more smart pointers in AbortSignal
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: fd24e6ddab25326a522eeec9fdea6a8c08c340f0 https://github.com/WebKit/WebKit/commit/fd24e6ddab25326a522eeec9fdea6a8c08c340f0 Author: Chris Dumez Date: 2024-01-22 (Mon, 22 Jan 2024) Changed paths: M Source/WebCore/Modules/fetch/FetchRequest.cpp M Source/WebCore/Modules/fetch/FetchRequest.h M Source/WebCore/bindings/js/JSDOMGlobalObject.cpp M Source/WebCore/bindings/js/JSDOMWrapper.h M Source/WebCore/bindings/scripts/CodeGeneratorJS.pm M Source/WebCore/bindings/scripts/test/JS/JSDedicatedWorkerGlobalScope.cpp M Source/WebCore/bindings/scripts/test/JS/JSDedicatedWorkerGlobalScope.h M Source/WebCore/bindings/scripts/test/JS/JSExposedStar.cpp M Source/WebCore/bindings/scripts/test/JS/JSExposedStar.h M Source/WebCore/bindings/scripts/test/JS/JSLocalDOMWindow.cpp M Source/WebCore/bindings/scripts/test/JS/JSLocalDOMWindow.h M Source/WebCore/bindings/scripts/test/JS/JSPaintWorkletGlobalScope.cpp M Source/WebCore/bindings/scripts/test/JS/JSPaintWorkletGlobalScope.h M Source/WebCore/bindings/scripts/test/JS/JSServiceWorkerGlobalScope.cpp M Source/WebCore/bindings/scripts/test/JS/JSServiceWorkerGlobalScope.h M Source/WebCore/bindings/scripts/test/JS/JSSharedWorkerGlobalScope.cpp M Source/WebCore/bindings/scripts/test/JS/JSSharedWorkerGlobalScope.h M Source/WebCore/bindings/scripts/test/JS/JSTestDOMJIT.cpp M Source/WebCore/bindings/scripts/test/JS/JSTestDOMJIT.h M Source/WebCore/bindings/scripts/test/JS/JSTestDefaultToJSONIndirectInheritance.cpp M Source/WebCore/bindings/scripts/test/JS/JSTestDefaultToJSONIndirectInheritance.h M Source/WebCore/bindings/scripts/test/JS/JSTestDefaultToJSONInherit.cpp M Source/WebCore/bindings/scripts/test/JS/JSTestDefaultToJSONInherit.h M Source/WebCore/bindings/scripts/test/JS/JSTestDefaultToJSONInheritFinal.cpp M Source/WebCore/bindings/scripts/test/JS/JSTestDefaultToJSONInheritFinal.h M Source/WebCore/bindings/scripts/test/JS/JSTestEventConstructor.cpp M Source/WebCore/bindings/scripts/test/JS/JSTestEventConstructor.h M Source/WebCore/bindings/scripts/test/JS/JSTestEventTarget.cpp M Source/WebCore/bindings/scripts/test/JS/JSTestEventTarget.h M Source/WebCore/bindings/scripts/test/JS/JSTestNode.cpp M Source/WebCore/bindings/scripts/test/JS/JSTestNode.h M Source/WebCore/bindings/scripts/test/JS/JSTestPromiseRejectionEvent.cpp M Source/WebCore/bindings/scripts/test/JS/JSTestPromiseRejectionEvent.h M Source/WebCore/bindings/scripts/test/JS/JSWorkerGlobalScope.cpp M Source/WebCore/bindings/scripts/test/JS/JSWorkerGlobalScope.h M Source/WebCore/bindings/scripts/test/JS/JSWorkletGlobalScope.cpp M Source/WebCore/bindings/scripts/test/JS/JSWorkletGlobalScope.h M Source/WebCore/dom/AbortSignal.cpp Log Message: --- Adopt more smart pointers in AbortSignal https://bugs.webkit.org/show_bug.cgi?id=267863 Reviewed by Geoffrey Garen. * Source/WebCore/Modules/fetch/FetchRequest.cpp: (WebCore::FetchRequest::initializeWith): (WebCore::FetchRequest::clone): * Source/WebCore/Modules/fetch/FetchRequest.h: * Source/WebCore/bindings/js/JSDOMGlobalObject.cpp: (WebCore::JSC_DEFINE_HOST_FUNCTION): * Source/WebCore/bindings/js/JSDOMWrapper.h: (WebCore::JSDOMWrapper::protectedWrapped const): * Source/WebCore/bindings/scripts/CodeGeneratorJS.pm: (GenerateHeader): * Source/WebCore/bindings/scripts/test/JS/JSDedicatedWorkerGlobalScope.h: (WebCore::JSDedicatedWorkerGlobalScope::protectedWrapped const): * Source/WebCore/bindings/scripts/test/JS/JSExposedStar.h: (WebCore::JSExposedStar::protectedWrapped const): * Source/WebCore/bindings/scripts/test/JS/JSLocalDOMWindow.h: (WebCore::JSLocalDOMWindow::protectedWrapped const): * Source/WebCore/bindings/scripts/test/JS/JSPaintWorkletGlobalScope.h: (WebCore::JSPaintWorkletGlobalScope::protectedWrapped const): * Source/WebCore/bindings/scripts/test/JS/JSServiceWorkerGlobalScope.h: (WebCore::JSServiceWorkerGlobalScope::protectedWrapped const): * Source/WebCore/bindings/scripts/test/JS/JSSharedWorkerGlobalScope.h: (WebCore::JSSharedWorkerGlobalScope::protectedWrapped const): * Source/WebCore/bindings/scripts/test/JS/JSTestDOMJIT.h: (WebCore::JSTestDOMJIT::protectedWrapped const): * Source/WebCore/bindings/scripts/test/JS/JSTestDefaultToJSONIndirectInheritance.h: (WebCore::JSTestDefaultToJSONIndirectInheritance::protectedWrapped const): * Source/WebCore/bindings/scripts/test/JS/JSTestDefaultToJSONInherit.h: (WebCore::JSTestDefaultToJSONInherit::protectedWrapped const): * Source/WebCore/bindings/scripts/test/JS/JSTestDefaultToJSONInheritFinal.h: (WebCore::JSTestDefaultToJSONInheritFinal::protectedWrapped const): * Source/WebCore/bindings/scripts/test/JS/JSTestEventConstructor.h: (WebCore::JSTestEventConstructor::protectedWrapped const): * Source/WebCore/bindings/scripts/test/JS/JSTestEventTarget.h: (WebCore::JSTestEve
[webkit-changes] [WebKit/WebKit] 851a94: [iOS] [UIAsyncTextInput] WKWebView AutoFill input ...
Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 851a94731a2a59de7b93907417f505c76b1082ea
https://github.com/WebKit/WebKit/commit/851a94731a2a59de7b93907417f505c76b1082ea
Author: Wenson Hsieh
Date: 2024-01-22 (Mon, 22 Jan 2024)
Changed paths:
M Source/WebKit/Shared/ios/WebAutocorrectionContext.h
M Source/WebKit/Shared/ios/WebAutocorrectionContext.serialization.in
M Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm
M Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm
M Tools/TestRunnerShared/spi/UIKitSPIForTesting.h
M Tools/TestWebKitAPI/Tests/ios/AutocorrectionTestsIOS.mm
M Tools/TestWebKitAPI/cocoa/TestWKWebView.h
M Tools/TestWebKitAPI/cocoa/TestWKWebView.mm
Log Message:
---
[iOS] [UIAsyncTextInput] WKWebView AutoFill input assistant item doesn't show
up in the keyboard
https://bugs.webkit.org/show_bug.cgi?id=267865
rdar://121160501
Reviewed by Aditya Keerthi and Abrar Rahman Protyasha.
When async text input is enabled, we use
`-requestTextContextForAutocorrectionWithCompletionHandler:`
to surface autocorrection context information to UIKit. The conversion from
`WebAutocorrectionContext::markedTextRange` to
`DocumentEditingContext::selectedRangeInMarkedText`
is currently straightforward:
```
editingContext.selectedRangeInMarkedText = {
.location = correctionContext.selectedRangeInMarkedText.location,
.length = correctionContext.selectedRangeInMarkedText.length
};
```
…however, this hides a subtle bug, since the "not found" location of
`markedTextRange` (an
`EditingRange`) is represented using `WTF::notFound`, while the
`selectedRangeInMarkedText`
represents "not found" with `NSNotFound`, directly mirroring `NSRange`. The
`NSRange` operator in
`EditingRange` is aware of this difference:
```
operator NSRange() const
{
if (location == notFound)
return NSMakeRange(NSNotFound, 0);
return NSMakeRange(location, length);
}
```
…but we don't use it in the above code since we set the location and length
directly. Fix this by
simply mapping `notFound` to `NSNotFound` when creating the platform context in
the async text input
codepath.
Test: AutocorrectionTests.AutocorrectionContextBeforeAndAfterEditing
* Source/WebKit/Shared/ios/WebAutocorrectionContext.h:
* Source/WebKit/Shared/ios/WebAutocorrectionContext.serialization.in:
While we're here, also rename `markedTextRange` to `selectedRangeInMarkedText`,
to clarify what this
range actually represents.
* Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView requestTextContextForAutocorrectionWithCompletionHandler:]):
(+[WKAutocorrectionContext autocorrectionContextWithWebContext:]):
* Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::autocorrectionContext):
* Tools/TestRunnerShared/spi/UIKitSPIForTesting.h:
* Tools/TestWebKitAPI/Tests/ios/AutocorrectionTestsIOS.mm:
Augment an existing API test to also verify that when there's no IME
composition range, `markedText`
is `nil` and `selectedRangeInMarkedText` is exactly equal to `{ NSNotFound, 0
}`.
* Tools/TestWebKitAPI/cocoa/TestWKWebView.h:
* Tools/TestWebKitAPI/cocoa/TestWKWebView.mm:
(-[WKWebView autocorrectionContext]):
Canonical link: https://commits.webkit.org/273316@main
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 4c9e5c: [Win] Crash in GLContext::makeContextCurrent under...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 4c9e5ce1f2416cc8631758e33ab26db4e1d9e188 https://github.com/WebKit/WebKit/commit/4c9e5ce1f2416cc8631758e33ab26db4e1d9e188 Author: Fujii Hironori Date: 2024-01-22 (Mon, 22 Jan 2024) Changed paths: M Source/WebKit/GPUProcess/graphics/wc/WCScene.cpp M Source/WebKit/GPUProcess/graphics/wc/WCSceneContext.cpp Log Message: --- [Win] Crash in GLContext::makeContextCurrent under WCSceneContext::makeContextCurrent https://bugs.webkit.org/show_bug.cgi?id=264550 Reviewed by Don Olmstead. Running layout tests was randomly observing assertion failures in GPU process due to OpenGL context creation failures for Windows port. It was relatively reproducible with the following invocation: > python .\Tools\Scripts\run-webkit-tests --debug --iter=100 -f --no-retry > --no-show compositing/shared-backing/backing-sharing-compositing-change.html > compositing/shared-backing/move-sharing-child.html In that cases, the HWND was already closed in UI process. We have to check the GLContext validity and the return value of makeContextCurrent in GPU process. * Source/WebKit/GPUProcess/graphics/wc/WCScene.cpp: * Source/WebKit/GPUProcess/graphics/wc/WCSceneContext.cpp: Canonical link: https://commits.webkit.org/273315@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 3a1830: Adopt more smart pointers in WebCore/css/calc/
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 3a18304f032d6b9a64343fe60d4bb3e317263787 https://github.com/WebKit/WebKit/commit/3a18304f032d6b9a64343fe60d4bb3e317263787 Author: Chris Dumez Date: 2024-01-22 (Mon, 22 Jan 2024) Changed paths: M Source/WebCore/css/calc/CSSCalcExpressionNodeParser.cpp M Source/WebCore/css/calc/CSSCalcExpressionNodeParser.h M Source/WebCore/css/calc/CSSCalcInvertNode.cpp M Source/WebCore/css/calc/CSSCalcInvertNode.h M Source/WebCore/css/calc/CSSCalcNegateNode.cpp M Source/WebCore/css/calc/CSSCalcNegateNode.h M Source/WebCore/css/calc/CSSCalcOperationNode.cpp M Source/WebCore/css/calc/CSSCalcPrimitiveValueNode.cpp M Source/WebCore/css/calc/CSSCalcPrimitiveValueNode.h M Source/WebCore/css/calc/CSSCalcSymbolTable.h M Source/WebCore/css/calc/CSSCalcValue.cpp M Source/WebCore/css/calc/CSSCalcValue.h Log Message: --- Adopt more smart pointers in WebCore/css/calc/ https://bugs.webkit.org/show_bug.cgi?id=267870 Reviewed by Geoffrey Garen. * Source/WebCore/css/calc/CSSCalcExpressionNodeParser.cpp: (WebCore::CSSCalcExpressionNodeParser::parseCalc): (WebCore::CSSCalcExpressionNodeParser::parseValue): * Source/WebCore/css/calc/CSSCalcExpressionNodeParser.h: * Source/WebCore/css/calc/CSSCalcInvertNode.cpp: (WebCore::CSSCalcInvertNode::createCalcExpression const): (WebCore::CSSCalcInvertNode::doubleValue const): (WebCore::CSSCalcInvertNode::computeLengthPx const): * Source/WebCore/css/calc/CSSCalcInvertNode.h: * Source/WebCore/css/calc/CSSCalcNegateNode.cpp: (WebCore::CSSCalcNegateNode::createCalcExpression const): * Source/WebCore/css/calc/CSSCalcNegateNode.h: * Source/WebCore/css/calc/CSSCalcOperationNode.cpp: (WebCore::determineCategory): (WebCore::CSSCalcOperationNode::canCombineAllChildren const): (WebCore::CSSCalcOperationNode::combineChildren): (WebCore::CSSCalcOperationNode::simplifyRecursive): (WebCore::CSSCalcOperationNode::simplifyNode): (WebCore::CSSCalcOperationNode::createCalcExpression const): (WebCore::CSSCalcOperationNode::collectComputedStyleDependencies const): (WebCore::functionPrefixForOperator): (WebCore::CSSCalcOperationNode::buildCSSTextRecursive): * Source/WebCore/css/calc/CSSCalcPrimitiveValueNode.cpp: (WebCore::CSSCalcPrimitiveValueNode::customCSSText const): (WebCore::CSSCalcPrimitiveValueNode::primitiveType const): (WebCore::CSSCalcPrimitiveValueNode::isNegative const): (WebCore::CSSCalcPrimitiveValueNode::negate): (WebCore::CSSCalcPrimitiveValueNode::invert): (WebCore::CSSCalcPrimitiveValueNode::add): (WebCore::CSSCalcPrimitiveValueNode::multiply): (WebCore::CSSCalcPrimitiveValueNode::convertToUnitType): (WebCore::CSSCalcPrimitiveValueNode::canonicalizeUnit): (WebCore::CSSCalcPrimitiveValueNode::createCalcExpression const): (WebCore::CSSCalcPrimitiveValueNode::doubleValue const): (WebCore::CSSCalcPrimitiveValueNode::computeLengthPx const): (WebCore::CSSCalcPrimitiveValueNode::collectComputedStyleDependencies const): (WebCore::CSSCalcPrimitiveValueNode::isZero const): (WebCore::CSSCalcPrimitiveValueNode::dump const): * Source/WebCore/css/calc/CSSCalcPrimitiveValueNode.h: * Source/WebCore/css/calc/CSSCalcSymbolTable.h: * Source/WebCore/css/calc/CSSCalcValue.cpp: (WebCore::createCSS): (WebCore::CSSCalcValue::createCalculationValue const): (WebCore::CSSCalcValue::collectComputedStyleDependencies const): (WebCore::CSSCalcValue::customCSSText const): (WebCore::CSSCalcValue::doubleValue const): (WebCore::CSSCalcValue::computeLengthPx const): (WebCore::CSSCalcValue::protectedExpressionNode const): (WebCore::CSSCalcValue::create): * Source/WebCore/css/calc/CSSCalcValue.h: Canonical link: https://commits.webkit.org/273314@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] de7ac2: Increase smart pointer adoption in dom/messageports
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: de7ac2345de454bc2cda2202ecc2db5e50cc991f https://github.com/WebKit/WebKit/commit/de7ac2345de454bc2cda2202ecc2db5e50cc991f Author: Chris Dumez Date: 2024-01-22 (Mon, 22 Jan 2024) Changed paths: M Source/WTF/wtf/HashMap.h M Source/WebCore/dom/messageports/MessagePortChannel.cpp M Source/WebCore/dom/messageports/MessagePortChannel.h M Source/WebCore/dom/messageports/MessagePortChannelProvider.cpp M Source/WebCore/dom/messageports/MessagePortChannelProvider.h M Source/WebCore/dom/messageports/MessagePortChannelProviderImpl.cpp M Source/WebCore/dom/messageports/MessagePortChannelRegistry.h M Source/WebCore/dom/messageports/WorkerMessagePortChannelProvider.cpp M Source/WebCore/dom/messageports/WorkerMessagePortChannelProvider.h Log Message: --- Increase smart pointer adoption in dom/messageports https://bugs.webkit.org/show_bug.cgi?id=267862 Reviewed by Geoffrey Garen. * Source/WTF/wtf/HashMap.h: (WTF::Y>::take): (WTF::Y>::takeFirst): * Source/WebCore/dom/messageports/MessagePortChannel.cpp: (WebCore::MessagePortChannel::MessagePortChannel): (WebCore::MessagePortChannel::~MessagePortChannel): (WebCore::MessagePortChannel::checkedRegistry const): (WebCore::MessagePortChannel::closePort): (WebCore::MessagePortChannel::takeAllMessagesForPort): * Source/WebCore/dom/messageports/MessagePortChannel.h: * Source/WebCore/dom/messageports/MessagePortChannelProvider.cpp: (WebCore::globalProvider): (WebCore::MessagePortChannelProvider::singleton): (WebCore::MessagePortChannelProvider::setSharedProvider): * Source/WebCore/dom/messageports/MessagePortChannelProvider.h: * Source/WebCore/dom/messageports/MessagePortChannelProviderImpl.cpp: (WebCore::MessagePortChannelProviderImpl::createNewMessagePortChannel): (WebCore::MessagePortChannelProviderImpl::entangleLocalPortInThisProcessToRemote): (WebCore::MessagePortChannelProviderImpl::messagePortDisentangled): (WebCore::MessagePortChannelProviderImpl::messagePortClosed): (WebCore::MessagePortChannelProviderImpl::postMessageToRemote): (WebCore::MessagePortChannelProviderImpl::takeAllMessagesForPort): (WebCore::MessagePortChannelProviderImpl::MessagePortChannelProviderImpl): Deleted. * Source/WebCore/dom/messageports/MessagePortChannelRegistry.h: * Source/WebCore/dom/messageports/WorkerMessagePortChannelProvider.cpp: (WebCore::WorkerMessagePortChannelProvider::~WorkerMessagePortChannelProvider): (WebCore::WorkerMessagePortChannelProvider::takeAllMessagesForPort): * Source/WebCore/dom/messageports/WorkerMessagePortChannelProvider.h: Canonical link: https://commits.webkit.org/273313@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] f95c85: RenderListBox::size() should be 'unsigned' instead...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: f95c858b517e265064bba68c07f970beaf38394f https://github.com/WebKit/WebKit/commit/f95c858b517e265064bba68c07f970beaf38394f Author: Ahmad Saleem Date: 2024-01-22 (Mon, 22 Jan 2024) Changed paths: M Source/WebCore/rendering/RenderListBox.cpp M Source/WebCore/rendering/RenderListBox.h Log Message: --- RenderListBox::size() should be 'unsigned' instead of 'int' https://bugs.webkit.org/show_bug.cgi?id=267854 Reviewed by Simon Fraser. This patch is to align size() function with HTMLSelectElement `size`, which is 'unsigned long' so 'int' should be aligned to have 'unsigned' as well in rendering code. * Source/WebCore/rendering/RenderListBox.cpp: (RenderListBox::size): * Source/WebCore/rendering/RenderListBox.h: Canonical link: https://commits.webkit.org/273312@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 8e4af4: Reduce use of downcast<>() in WebCore
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 8e4af45308bd2a51542bf417ce1eca208e472ade https://github.com/WebKit/WebKit/commit/8e4af45308bd2a51542bf417ce1eca208e472ade Author: Chris Dumez Date: 2024-01-22 (Mon, 22 Jan 2024) Changed paths: M Source/WebCore/bindings/js/JSTrackCustom.cpp M Source/WebCore/bindings/js/ScriptModuleLoader.cpp M Source/WebCore/css/CSSFontFace.cpp M Source/WebCore/css/CSSValue.cpp M Source/WebCore/css/ComputedStyleExtractor.cpp M Source/WebCore/css/DeprecatedCSSOMValue.cpp M Source/WebCore/css/process-css-properties.py M Source/WebCore/dom/Element.cpp M Source/WebCore/dom/Element.h M Source/WebCore/dom/Node.cpp M Source/WebCore/dom/Range.cpp M Source/WebCore/dom/ScopedEventQueue.cpp M Source/WebCore/dom/ScriptExecutionContext.cpp M Source/WebCore/editing/ApplyStyleCommand.cpp M Source/WebCore/editing/BreakBlockquoteCommand.cpp M Source/WebCore/editing/ChangeListTypeCommand.cpp M Source/WebCore/editing/DeleteSelectionCommand.cpp M Source/WebCore/editing/Editing.cpp M Source/WebCore/editing/EditingStyle.cpp M Source/WebCore/html/HTMLLabelElement.cpp M Source/WebCore/html/HTMLLabelElement.h Log Message: --- Reduce use of downcast<>() in WebCore https://bugs.webkit.org/show_bug.cgi?id=267840 Reviewed by Geoffrey Garen. * Source/WebCore/bindings/js/JSTrackCustom.cpp: (WebCore::toJS): * Source/WebCore/bindings/js/ScriptModuleLoader.cpp: (WebCore::ScriptModuleLoader::evaluate): * Source/WebCore/css/CSSFontFace.cpp: (WebCore::CSSFontFace::setSizeAdjust): * Source/WebCore/css/CSSValue.cpp: (WebCore::CSSValue::equals const): * Source/WebCore/css/ComputedStyleExtractor.cpp: (WebCore::transformOperationAsCSSValue): (WebCore::ComputedStyleExtractor::valueForFilter): * Source/WebCore/css/DeprecatedCSSOMValue.cpp: (WebCore::DeprecatedCSSOMValue::operator delete): (WebCore::DeprecatedCSSOMValue::cssValueType const): (WebCore::DeprecatedCSSOMValue::cssText const): * Source/WebCore/css/process-css-properties.py: * Source/WebCore/dom/Element.cpp: (WebCore::Element::willModifyAttribute): (WebCore::Element::updateLabel): Deleted. * Source/WebCore/dom/Element.h: * Source/WebCore/dom/Node.cpp: (WebCore::isTouchRelatedEventType): * Source/WebCore/dom/Range.cpp: (WebCore::processContentsBetweenOffsets): (WebCore::Range::surroundContents): * Source/WebCore/dom/ScopedEventQueue.cpp: (WebCore::ScopedEventQueue::enqueueEvent): * Source/WebCore/dom/ScriptExecutionContext.cpp: (WebCore::ScriptExecutionContext::postTaskToResponsibleDocument): * Source/WebCore/editing/ApplyStyleCommand.cpp: (WebCore::isLegacyAppleStyleSpan): (WebCore::isStyleSpanOrSpanWithOnlyStyleAttribute): (WebCore::isSpanWithoutAttributesOrUnstyledStyleSpan): (WebCore::isEmptyFontTag): (WebCore::ApplyStyleCommand::applyBlockStyle): (WebCore::ApplyStyleCommand::applyRelativeFontStyleChange): (WebCore::dummySpanAncestorForNode): (WebCore::ApplyStyleCommand::removeEmbeddingUpToEnclosingBlock): (WebCore::ApplyStyleCommand::applyInlineStyleToNodeRange): (WebCore::ApplyStyleCommand::removeConflictingInlineStyleFromRun): (WebCore::ApplyStyleCommand::applyInlineStyleToPushDown): (WebCore::ApplyStyleCommand::pushDownInlineStyleAroundNode): (WebCore::ApplyStyleCommand::removeInlineStyle): (WebCore::ApplyStyleCommand::shouldSplitTextElement): (WebCore::ApplyStyleCommand::surroundNodeRangeWithElement): (WebCore::ApplyStyleCommand::applyInlineStyleChange): * Source/WebCore/editing/BreakBlockquoteCommand.cpp: (WebCore::BreakBlockquoteCommand::doApply): * Source/WebCore/editing/ChangeListTypeCommand.cpp: (WebCore::listConversionTypeForSelection): * Source/WebCore/editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::cloneParagraphUnderNewElement): * Source/WebCore/editing/DeleteSelectionCommand.cpp: (WebCore::isSpecialHTMLElement): (WebCore::DeleteSelectionCommand::handleGeneralDelete): (WebCore::DeleteSelectionCommand::fixupWhitespace): (WebCore::DeleteSelectionCommand::doApply): * Source/WebCore/editing/Editing.cpp: (WebCore::enclosingList): (WebCore::isMailBlockquote): (WebCore::elementIfBlockFlow): (WebCore::isBlockFlowElement): (WebCore::deprecatedEnclosingBlockFlowElement): (WebCore::rendererForCaretPainting): * Source/WebCore/editing/EditingStyle.cpp: (WebCore::fontWeightValueIsBold): (WebCore::EditingStyle::overrideTypingStyleAt): (WebCore::EditingStyle::styleIsPresentInComputedStyleOfNode const): (WebCore::EditingStyle::wrappingStyleForSerialization): (WebCore::EditingStyle::mergeStyle): (WebCore::loneFontFamilyName): (WebCore::EditingStyle::mergeStyleFromRulesForSerialization): (WebCore::EditingStyle::legacyFontSize const): (WebCore::EditingStyle::styleAtSelectionStart): (WebCore::StyleChange::StyleChange): (WebCore::StyleChange::extractTextStyles): (WebCore::diffTextDecorations): * Source/WebCore/html/HTMLLabelElement.cpp: (WebCore::HTMLLabelElement::updateLabel): * Source/WebCore/html/H
[webkit-changes] [WebKit/WebKit] 35a56e: Implement MediaStreamTrackProcessor maxBufferSize ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 35a56e6b2d4ab965fadb5efe9bedc6dc3ce9308d https://github.com/WebKit/WebKit/commit/35a56e6b2d4ab965fadb5efe9bedc6dc3ce9308d Author: Youenn Fablet Date: 2024-01-22 (Mon, 22 Jan 2024) Changed paths: A LayoutTests/imported/w3c/web-platform-tests/mediacapture-insertable-streams/MediaStreamTrackProcessor-maxBufferSize.worker-expected.txt A LayoutTests/imported/w3c/web-platform-tests/mediacapture-insertable-streams/MediaStreamTrackProcessor-maxBufferSize.worker.html A LayoutTests/imported/w3c/web-platform-tests/mediacapture-insertable-streams/MediaStreamTrackProcessor-maxBufferSize.worker.js M Source/WebCore/Modules/mediastream/MediaStreamTrackProcessor.cpp M Source/WebCore/Modules/mediastream/MediaStreamTrackProcessor.h M Source/WebCore/Modules/mediastream/MediaStreamTrackProcessor.idl Log Message: --- Implement MediaStreamTrackProcessor maxBufferSize support rdar://121256478 https://bugs.webkit.org/show_bug.cgi?id=267763 Reviewed by Eric Carlson. We add support for buffering some video frames based on maxBufferSize using a Deque. The size restriction is enforced in the media pipeline to limit buffering even if the worker thread is blocked. We keep a maxBufferSize of 1 in Cocoa ports for camera sources since they used a limited number of video frames so buffering could stop the camera and fail capture. * LayoutTests/imported/w3c/web-platform-tests/mediacapture-insertable-streams/MediaStreamTrackProcessor-maxBufferSize.worker-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/mediacapture-insertable-streams/MediaStreamTrackProcessor-maxBufferSize.worker.html: Added. * LayoutTests/imported/w3c/web-platform-tests/mediacapture-insertable-streams/MediaStreamTrackProcessor-maxBufferSize.worker.js: Added. (makeVideoFrame): (promise_test.async t): * Source/WebCore/Modules/mediastream/MediaStreamTrackProcessor.cpp: (WebCore::MediaStreamTrackProcessor::create): (WebCore::MediaStreamTrackProcessor::MediaStreamTrackProcessor): (WebCore::MediaStreamTrackProcessor::VideoFrameObserverWrapper::create): (WebCore::MediaStreamTrackProcessor::VideoFrameObserverWrapper::initialize): (WebCore::MediaStreamTrackProcessor::VideoFrameObserver::VideoFrameObserver): (WebCore::MediaStreamTrackProcessor::VideoFrameObserver::takeVideoFrame): (WebCore::MediaStreamTrackProcessor::VideoFrameObserver::videoFrameAvailable): * Source/WebCore/Modules/mediastream/MediaStreamTrackProcessor.h: * Source/WebCore/Modules/mediastream/MediaStreamTrackProcessor.idl: Canonical link: https://commits.webkit.org/273310@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] d0345d: [JSC] Use Data CallIC in DFG
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: d0345d69220e43945f9b9632378eab88cb50e1da https://github.com/WebKit/WebKit/commit/d0345d69220e43945f9b9632378eab88cb50e1da Author: Yusuke Suzuki Date: 2024-01-22 (Mon, 22 Jan 2024) Changed paths: M Source/JavaScriptCore/bytecode/CallLinkInfo.cpp M Source/JavaScriptCore/bytecode/CallLinkInfo.h M Source/JavaScriptCore/bytecode/InlineCacheCompiler.cpp M Source/JavaScriptCore/bytecode/Repatch.cpp M Source/JavaScriptCore/bytecode/Repatch.h M Source/JavaScriptCore/bytecode/RepatchInlines.h M Source/JavaScriptCore/dfg/DFGJITCompiler.cpp M Source/JavaScriptCore/dfg/DFGJITCompiler.h M Source/JavaScriptCore/dfg/DFGSpeculativeJIT32_64.cpp M Source/JavaScriptCore/dfg/DFGSpeculativeJIT64.cpp M Source/JavaScriptCore/ftl/FTLLowerDFGToB3.cpp M Source/JavaScriptCore/jit/AssemblyHelpers.cpp M Source/JavaScriptCore/jit/AssemblyHelpers.h M Source/JavaScriptCore/jit/BaselineJITRegisters.h M Source/JavaScriptCore/jit/JIT.cpp M Source/JavaScriptCore/jit/JIT.h M Source/JavaScriptCore/jit/JITCall.cpp M Source/JavaScriptCore/jit/JITInlines.h M Source/JavaScriptCore/jit/JITOperations.cpp M Source/JavaScriptCore/jit/JITOperations.h M Source/JavaScriptCore/jit/ThunkGenerators.cpp M Source/JavaScriptCore/llint/LLIntSlowPaths.cpp M Source/JavaScriptCore/llint/LLIntSlowPaths.h M Source/JavaScriptCore/llint/LLIntThunks.cpp M Source/JavaScriptCore/llint/LowLevelInterpreter.asm M Source/JavaScriptCore/llint/LowLevelInterpreter32_64.asm M Source/JavaScriptCore/llint/LowLevelInterpreter64.asm M Source/JavaScriptCore/wasm/js/WasmToJS.cpp Log Message: --- [JSC] Use Data CallIC in DFG https://bugs.webkit.org/show_bug.cgi?id=267802 rdar://121298538 Reviewed by Justin Michaud. This patch enables Data CallIC only in DFG (and IC from DFG), not in FTL. DataIC and RepatchingIC have a tradeoff in terms of performance and setup penalty. And we think that DFG should use DataIC for faster setup and FTL should use RepatchingIC for faster peak performance. Previously we were passing JSGlobalObject* for Call. But this is not so important since this JSGlobalObject* is used only when throwing an error (since the called function itself will start running with its own JSGlobalObject*). So instead of eagerly passing it, CallLinkInfo can now retrieve JSGlobalObject* when it needs to throw an error. * Source/JavaScriptCore/bytecode/CallLinkInfo.cpp: (JSC::BaselineCallLinkInfo::initialize): (JSC::CallLinkInfo::revertCall): (JSC::CallLinkInfo::setVirtualCall): (JSC::CallLinkInfo::globalObjectForSlowPath): (JSC::CallLinkInfo::emitFastPathImpl): (JSC::CallLinkInfo::emitDataICFastPath): (JSC::CallLinkInfo::emitTailCallDataICFastPath): (JSC::CallLinkInfo::setStub): (JSC::CallLinkInfo::emitSlowPathImpl): (JSC::CallLinkInfo::emitFastPath): (JSC::CallLinkInfo::emitTailCallFastPath): (JSC::OptimizingCallLinkInfo::emitFastPath): (JSC::OptimizingCallLinkInfo::emitTailCallFastPath): * Source/JavaScriptCore/bytecode/CallLinkInfo.h: (JSC::CallLinkInfo::ownerForSlowPath): * Source/JavaScriptCore/bytecode/InlineCacheCompiler.cpp: (JSC::InlineCacheCompiler::generateImpl): (JSC::InlineCacheCompiler::emitProxyObjectAccess): * Source/JavaScriptCore/bytecode/Repatch.cpp: (JSC::linkPolymorphicCall): * Source/JavaScriptCore/bytecode/Repatch.h: * Source/JavaScriptCore/bytecode/RepatchInlines.h: (JSC::handleHostCall): (JSC::linkFor): (JSC::virtualForWithFunction): * Source/JavaScriptCore/dfg/DFGJITCompiler.cpp: (JSC::DFG::JITCompiler::addCallLinkInfo): * Source/JavaScriptCore/dfg/DFGJITCompiler.h: * Source/JavaScriptCore/dfg/DFGSpeculativeJIT32_64.cpp: (JSC::DFG::SpeculativeJIT::emitCall): * Source/JavaScriptCore/dfg/DFGSpeculativeJIT64.cpp: (JSC::DFG::SpeculativeJIT::emitCall): * Source/JavaScriptCore/ftl/FTLLowerDFGToB3.cpp: (JSC::FTL::DFG::LowerDFGToB3::compileCompareStrictEq): * Source/JavaScriptCore/jit/AssemblyHelpers.cpp: (JSC::AssemblyHelpers::emitVirtualCall): * Source/JavaScriptCore/jit/AssemblyHelpers.h: * Source/JavaScriptCore/jit/BaselineJITRegisters.h: * Source/JavaScriptCore/jit/JIT.cpp: (JSC::JIT::privateCompileMainPass): (JSC::JIT::privateCompileSlowCases): * Source/JavaScriptCore/jit/JIT.h: * Source/JavaScriptCore/jit/JITCall.cpp: (JSC::JIT::compileCallDirectEvalSlowCase): (JSC::JIT::compileTailCall): (JSC::JIT::compileOpCall): (JSC::JIT::emit_op_call): (JSC::JIT::emit_op_call_ignore_result): (JSC::JIT::emit_op_tail_call): (JSC::JIT::emit_op_call_direct_eval): (JSC::JIT::emit_op_call_varargs): (JSC::JIT::emit_op_tail_call_varargs): (JSC::JIT::emit_op_tail_call_forward_arguments): (JSC::JIT::emit_op_construct_varargs): (JSC::JIT::emit_op_construct): (JSC::JIT::emit_op_iterator_open): (JSC::JIT::emitSlow_op_iterator_open): (JSC::JIT::emit_op_iterator_next): (JSC::JIT::emitSlow_op_iterator_next): (JSC::JIT::compileOpCallSlowCase): Deleted. (JSC::JIT:
[webkit-changes] [WebKit/WebKit] fcb692: Adopt more smart pointers in ImageControlsMac.cpp
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: fcb692633ae1fe8a3efc30a40ea948973bcb1893 https://github.com/WebKit/WebKit/commit/fcb692633ae1fe8a3efc30a40ea948973bcb1893 Author: Chris Dumez Date: 2024-01-22 (Mon, 22 Jan 2024) Changed paths: M Source/WebCore/dom/Document.h M Source/WebCore/dom/mac/ImageControlsMac.cpp M Source/WebCore/dom/mac/ImageControlsMac.h Log Message: --- Adopt more smart pointers in ImageControlsMac.cpp https://bugs.webkit.org/show_bug.cgi?id=267860 Reviewed by Brent Fulgham. * Source/WebCore/dom/Document.h: (WebCore::Document::checkedEventLoop): * Source/WebCore/dom/mac/ImageControlsMac.cpp: (WebCore::ImageControlsMac::hasImageControls): (WebCore::ImageControlsMac::isImageControlsButtonElement): (WebCore::ImageControlsMac::isInsideImageControls): (WebCore::ImageControlsMac::createImageControls): (WebCore::ImageControlsMac::handleEvent): (WebCore::ImageControlsMac::updateImageControls): (WebCore::ImageControlsMac::destroyImageControls): * Source/WebCore/dom/mac/ImageControlsMac.h: Canonical link: https://commits.webkit.org/273308@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] a7d81c: Make isStatelessLambda check compile-time
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: a7d81ce30e154b29c4626b508aca5433f4cfa170 https://github.com/WebKit/WebKit/commit/a7d81ce30e154b29c4626b508aca5433f4cfa170 Author: Yusuke Suzuki Date: 2024-01-22 (Mon, 22 Jan 2024) Changed paths: M Source/JavaScriptCore/runtime/LazyPropertyInlines.h M Source/WTF/wtf/LazyRef.h M Source/WTF/wtf/LazyUniqueRef.h M Source/WTF/wtf/StdLibExtras.h Log Message: --- Make isStatelessLambda check compile-time https://bugs.webkit.org/show_bug.cgi?id=267847 rdar://121360002 Reviewed by Justin Michaud. We can ensure that lambda is stateless at compile-time with constexpr isStatelessLambda function. This patch makes it constexpr, and using static_assert instead of RELEASE_ASSERT in LazyXXX classes. * Source/JavaScriptCore/runtime/LazyPropertyInlines.h: (JSC::ElementType>::initLater): * Source/WTF/wtf/LazyRef.h: (WTF::LazyRef::initLater): * Source/WTF/wtf/LazyUniqueRef.h: (WTF::LazyUniqueRef::initLater): * Source/WTF/wtf/StdLibExtras.h: (WTF::isStatelessLambda): Canonical link: https://commits.webkit.org/273307@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 6fe299: Use Sudo When Pruning coresymbolicationd Cache
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 6fe2994a53cf90840f31bfb54e66d8f5788773fe https://github.com/WebKit/WebKit/commit/6fe2994a53cf90840f31bfb54e66d8f5788773fe Author: Chris Gibb Date: 2024-01-22 (Mon, 22 Jan 2024) Changed paths: M Tools/Scripts/delete-if-too-large Log Message: --- Use Sudo When Pruning coresymbolicationd Cache https://bugs.webkit.org/show_bug.cgi?id=267382 rdar://120814769 Reviewed by Jonathan Bedard. As a follow up to https://bugs.webkit.org/show_bug.cgi?id=267053 , sudo should be used when pruning the coresymbolicationd cache. * Tools/Scripts/delete-if-too-large: (main): Canonical link: https://commits.webkit.org/273306@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 8863d4: [webkitbugspy] Refactor Radar mocks for testing
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 8863d49ad857553e59da6c6175e82450d450c7ac https://github.com/WebKit/WebKit/commit/8863d49ad857553e59da6c6175e82450d450c7ac Author: Jonathan Bedard Date: 2024-01-22 (Mon, 22 Jan 2024) Changed paths: M Tools/Scripts/libraries/webkitbugspy/webkitbugspy/mocks/radar.py Log Message: --- [webkitbugspy] Refactor Radar mocks for testing https://bugs.webkit.org/show_bug.cgi?id=267798 rdar://121291184 Reviewed by Aakash Jain. * Tools/Scripts/libraries/webkitbugspy/webkitbugspy/mocks/radar.py: (Radar.Milestone): Moved from RadarModel. (Radar.Category): Ditto. (RadarModel.Milestone): Move to Radar. (RadarModel.Category): Ditto. Canonical link: https://commits.webkit.org/273305@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] c9354b: Make sure we protect the GraphicsContextGL before ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: c9354bc74322940912c8e4a0143a4c35019a6fc8 https://github.com/WebKit/WebKit/commit/c9354bc74322940912c8e4a0143a4c35019a6fc8 Author: Chris Dumez Date: 2024-01-22 (Mon, 22 Jan 2024) Changed paths: M Source/WebCore/Modules/webxr/WebXROpaqueFramebuffer.cpp M Source/WebCore/html/OffscreenCanvas.cpp M Source/WebCore/html/canvas/ANGLEInstancedArrays.cpp M Source/WebCore/html/canvas/EXTBlendMinMax.cpp M Source/WebCore/html/canvas/EXTClipControl.cpp M Source/WebCore/html/canvas/EXTColorBufferFloat.cpp M Source/WebCore/html/canvas/EXTColorBufferHalfFloat.cpp M Source/WebCore/html/canvas/EXTConservativeDepth.cpp M Source/WebCore/html/canvas/EXTDepthClamp.cpp M Source/WebCore/html/canvas/EXTDisjointTimerQuery.cpp M Source/WebCore/html/canvas/EXTDisjointTimerQueryWebGL2.cpp M Source/WebCore/html/canvas/EXTFloatBlend.cpp M Source/WebCore/html/canvas/EXTFragDepth.cpp M Source/WebCore/html/canvas/EXTPolygonOffsetClamp.cpp M Source/WebCore/html/canvas/EXTRenderSnorm.cpp M Source/WebCore/html/canvas/EXTShaderTextureLOD.cpp M Source/WebCore/html/canvas/EXTTextureCompressionBPTC.cpp M Source/WebCore/html/canvas/EXTTextureCompressionRGTC.cpp M Source/WebCore/html/canvas/EXTTextureFilterAnisotropic.cpp M Source/WebCore/html/canvas/EXTTextureMirrorClampToEdge.cpp M Source/WebCore/html/canvas/EXTTextureNorm16.cpp M Source/WebCore/html/canvas/EXTsRGB.cpp M Source/WebCore/html/canvas/KHRParallelShaderCompile.cpp M Source/WebCore/html/canvas/NVShaderNoperspectiveInterpolation.cpp M Source/WebCore/html/canvas/OESDrawBuffersIndexed.cpp M Source/WebCore/html/canvas/OESElementIndexUint.cpp M Source/WebCore/html/canvas/OESFBORenderMipmap.cpp M Source/WebCore/html/canvas/OESSampleVariables.cpp M Source/WebCore/html/canvas/OESShaderMultisampleInterpolation.cpp M Source/WebCore/html/canvas/OESStandardDerivatives.cpp M Source/WebCore/html/canvas/OESTextureFloat.cpp M Source/WebCore/html/canvas/OESTextureFloatLinear.cpp M Source/WebCore/html/canvas/OESTextureHalfFloat.cpp M Source/WebCore/html/canvas/OESTextureHalfFloatLinear.cpp M Source/WebCore/html/canvas/OESVertexArrayObject.cpp M Source/WebCore/html/canvas/WebGL2RenderingContext.cpp M Source/WebCore/html/canvas/WebGLBuffer.cpp M Source/WebCore/html/canvas/WebGLClipCullDistance.cpp M Source/WebCore/html/canvas/WebGLColorBufferFloat.cpp M Source/WebCore/html/canvas/WebGLCompressedTextureASTC.cpp M Source/WebCore/html/canvas/WebGLCompressedTextureETC.cpp M Source/WebCore/html/canvas/WebGLCompressedTextureETC1.cpp M Source/WebCore/html/canvas/WebGLCompressedTexturePVRTC.cpp M Source/WebCore/html/canvas/WebGLCompressedTextureS3TC.cpp M Source/WebCore/html/canvas/WebGLCompressedTextureS3TCsRGB.cpp M Source/WebCore/html/canvas/WebGLDebugShaders.cpp M Source/WebCore/html/canvas/WebGLDefaultFramebuffer.cpp M Source/WebCore/html/canvas/WebGLDepthTexture.cpp M Source/WebCore/html/canvas/WebGLDrawBuffers.cpp M Source/WebCore/html/canvas/WebGLDrawInstancedBaseVertexBaseInstance.cpp M Source/WebCore/html/canvas/WebGLFramebuffer.cpp M Source/WebCore/html/canvas/WebGLMultiDraw.cpp M Source/WebCore/html/canvas/WebGLMultiDrawInstancedBaseVertexBaseInstance.cpp M Source/WebCore/html/canvas/WebGLPolygonMode.cpp M Source/WebCore/html/canvas/WebGLProgram.cpp M Source/WebCore/html/canvas/WebGLProvokingVertex.cpp M Source/WebCore/html/canvas/WebGLQuery.cpp M Source/WebCore/html/canvas/WebGLRenderSharedExponent.cpp M Source/WebCore/html/canvas/WebGLRenderbuffer.cpp M Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp M Source/WebCore/html/canvas/WebGLRenderingContextBase.h M Source/WebCore/html/canvas/WebGLSampler.cpp M Source/WebCore/html/canvas/WebGLShader.cpp M Source/WebCore/html/canvas/WebGLStencilTexturing.cpp M Source/WebCore/html/canvas/WebGLSync.cpp M Source/WebCore/html/canvas/WebGLTexture.cpp M Source/WebCore/html/canvas/WebGLTimerQueryEXT.cpp M Source/WebCore/html/canvas/WebGLTransformFeedback.cpp M Source/WebCore/html/canvas/WebGLUtilities.cpp M Source/WebCore/html/canvas/WebGLUtilities.h M Source/WebCore/html/canvas/WebGLVertexArrayObject.cpp M Source/WebCore/html/canvas/WebGLVertexArrayObjectBase.cpp M Source/WebCore/html/canvas/WebGLVertexArrayObjectOES.cpp Log Message: --- Make sure we protect the GraphicsContextGL before calling its member functions https://bugs.webkit.org/show_bug.cgi?id=267856 Reviewed by Darin Adler. * Source/WebCore/Modules/webxr/WebXROpaqueFramebuffer.cpp: (WebCore::WebXROpaqueFramebuffer::~WebXROpaqueFramebuffer): (WebCore::WebXROpaqueFramebuffer::startFrame): (WebCore::WebXROpaqueFramebuffer::endFrame): (WebCore::WebXROpaqueFramebuffer::setupFramebuffer): * Source/WebC
[webkit-changes] [WebKit/WebKit] ac6c0c: [GTK] Unreviewed, buld fix for Ubuntu LTS after 27...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: ac6c0cf26ac84b600528a146424f33a251ad74b9 https://github.com/WebKit/WebKit/commit/ac6c0cf26ac84b600528a146424f33a251ad74b9 Author: Diego Pino Garcia Date: 2024-01-22 (Mon, 22 Jan 2024) Changed paths: M Source/WebCore/platform/mediastream/gstreamer/GStreamerMediaStreamSource.cpp Log Message: --- [GTK] Unreviewed, buld fix for Ubuntu LTS after 273292@main https://bugs.webkit.org/show_bug.cgi?id=267411 Guard block of code using 'RealtimeIncomingSourceGStreamer' within "USE(GSTREAMER_WEBRTC)". * Source/WebCore/platform/mediastream/gstreamer/GStreamerMediaStreamSource.cpp: Canonical link: https://commits.webkit.org/273303@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 79b1fe: Revert: 273297@main is breaking internal builds.
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 79b1fe2bd420eb59d18a36a48d800f267e51c9a5 https://github.com/WebKit/WebKit/commit/79b1fe2bd420eb59d18a36a48d800f267e51c9a5 Author: Ben Schwartz Date: 2024-01-22 (Mon, 22 Jan 2024) Changed paths: M LayoutTests/TestExpectations M LayoutTests/fast/dom/dom-window-property-gc-after-frame-detach-expected.txt M LayoutTests/fast/dom/dom-window-property-gc-after-frame-detach.html M LayoutTests/fast/dom/event-handler-attributes.html M LayoutTests/fast/events/destroyed-atomic-string.html M LayoutTests/fast/events/dispatchEvent-crash-expected.txt M LayoutTests/fast/events/dispatchEvent-crash.html M LayoutTests/fast/loader/window-properties-restored-from-page-cache-expected.txt M LayoutTests/fast/loader/window-properties-restored-from-page-cache.html A LayoutTests/http/tests/appcache/404-manifest-expected.txt A LayoutTests/http/tests/appcache/404-manifest.html A LayoutTests/http/tests/appcache/404-resource-expected.txt A LayoutTests/http/tests/appcache/404-resource-with-slow-main-resource-expected.txt A LayoutTests/http/tests/appcache/404-resource-with-slow-main-resource.py A LayoutTests/http/tests/appcache/404-resource.html A LayoutTests/http/tests/appcache/abort-cache-onchecking-expected.txt A LayoutTests/http/tests/appcache/abort-cache-onchecking-manifest-404-expected.txt A LayoutTests/http/tests/appcache/abort-cache-onchecking-manifest-404.html A LayoutTests/http/tests/appcache/abort-cache-onchecking-resource-404-expected.txt A LayoutTests/http/tests/appcache/abort-cache-onchecking-resource-404.html A LayoutTests/http/tests/appcache/abort-cache-onchecking.html A LayoutTests/http/tests/appcache/abort-cache-ondownloading-expected.txt A LayoutTests/http/tests/appcache/abort-cache-ondownloading-manifest-404-expected.txt A LayoutTests/http/tests/appcache/abort-cache-ondownloading-manifest-404.html A LayoutTests/http/tests/appcache/abort-cache-ondownloading-resource-404-expected.txt A LayoutTests/http/tests/appcache/abort-cache-ondownloading-resource-404.html A LayoutTests/http/tests/appcache/abort-cache-ondownloading.html A LayoutTests/http/tests/appcache/abort-cache-onprogress-expected.txt A LayoutTests/http/tests/appcache/abort-cache-onprogress.html A LayoutTests/http/tests/appcache/access-via-redirect-expected.txt A LayoutTests/http/tests/appcache/access-via-redirect.py A LayoutTests/http/tests/appcache/appcache-cookies-expected.txt A LayoutTests/http/tests/appcache/appcache-cookies.html A LayoutTests/http/tests/appcache/auth-expected.txt A LayoutTests/http/tests/appcache/auth.html A LayoutTests/http/tests/appcache/crash-when-navigating-away-then-back-expected.txt A LayoutTests/http/tests/appcache/crash-when-navigating-away-then-back.html A LayoutTests/http/tests/appcache/credential-url-expected.txt A LayoutTests/http/tests/appcache/credential-url.html A LayoutTests/http/tests/appcache/cyrillic-uri-expected.txt A LayoutTests/http/tests/appcache/cyrillic-uri.html A LayoutTests/http/tests/appcache/decide-navigation-policy-after-delay-expected.txt A LayoutTests/http/tests/appcache/decide-navigation-policy-after-delay.html A LayoutTests/http/tests/appcache/deferred-events-delete-while-raising-expected.txt A LayoutTests/http/tests/appcache/deferred-events-delete-while-raising-timer-expected.txt A LayoutTests/http/tests/appcache/deferred-events-delete-while-raising-timer.html A LayoutTests/http/tests/appcache/deferred-events-delete-while-raising.html A LayoutTests/http/tests/appcache/deferred-events-expected.txt A LayoutTests/http/tests/appcache/deferred-events.html A LayoutTests/http/tests/appcache/destroyed-frame-expected.txt A LayoutTests/http/tests/appcache/destroyed-frame.html A LayoutTests/http/tests/appcache/detached-iframe-expected.txt A LayoutTests/http/tests/appcache/detached-iframe.html A LayoutTests/http/tests/appcache/different-https-origin-resource-main-expected.txt A LayoutTests/http/tests/appcache/different-https-origin-resource-main.html A LayoutTests/http/tests/appcache/different-origin-manifest-expected.txt A LayoutTests/http/tests/appcache/different-origin-manifest.html A LayoutTests/http/tests/appcache/different-scheme-expected.txt A LayoutTests/http/tests/appcache/different-scheme.html A LayoutTests/http/tests/appcache/disabled-expected.txt A LayoutTests/http/tests/appcache/disabled.html A LayoutTests/http/tests/appcache/document-cookie-expected.txt A LayoutTests/http/tests/appcache/document-cookie-http-only-expected.txt A LayoutTests/http/tests/appcache/document-cookie-http-only.py A LayoutTests/http/tests/appcache/document-cookie.py A LayoutTests/http/tests/appcache/document-write-html-element-2-expected.txt A LayoutTests/http/t
[webkit-changes] [WebKit/WebKit] 4c3167: Advanced tracking and fingerprinting protection pe...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 4c31678fef6899bc5aa8db9efe5883e9b24db160 https://github.com/WebKit/WebKit/commit/4c31678fef6899bc5aa8db9efe5883e9b24db160 Author: Matthew Finkel Date: 2024-01-22 (Mon, 22 Jan 2024) Changed paths: M LayoutTests/fast/canvas/canvas-noise-injection-expected.txt M LayoutTests/fast/canvas/canvas-noise-injection.html A LayoutTests/fast/canvas/webgl/resources/webgl-fingerprinting-support.js M Source/WebCore/html/CanvasBase.cpp M Source/WebCore/html/CanvasBase.h M Source/WebCore/html/CanvasNoiseInjection.cpp M Source/WebCore/html/CanvasNoiseInjection.h M Source/WebCore/html/canvas/CanvasRenderingContext2DBase.cpp M Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp Log Message: --- Advanced tracking and fingerprinting protection performance issues with drawImage https://bugs.webkit.org/show_bug.cgi?id=266181 rdar://problem/119783395 Reviewed by Kimmo Kinnunen. In 270207@main, in the case when canvas noise injection is enabled, I added exceptions where noise would not be applied to the canvas following putImageData and drawImage commands. However, I excluded some cases which weren't safe. One of those is applying noise to the source buffer of a canvas when it is drawn onto another canvas. This patch changes the above behavior by not applying any pending noise to the source buffer, and instead the destination rect of the destination canvas is marked as needing noise application. In order to accomplish this for both canvas2d and webgl, this patch also stops tracking WebGL dirty rects that need noise applied. The current mechanism for tracking was not sufficient and it wasn't necessary. Instead, this patch now applies noise the the entire image buffer if the rendering context is not 2D. This patch adds tests that verify drawing one canvas from another accumulates pending noise in the destination without applying noise to the source. It also verifies that the noise application process does not change the image by incorrectly placing the extracted pixelbuffer at the wrong offset of the image buffer. * LayoutTests/fast/canvas/canvas-noise-injection-expected.txt: * LayoutTests/fast/canvas/canvas-noise-injection.html: * LayoutTests/fast/canvas/webgl/resources/webgl-fingerprinting-support.js: Added. (createMatrix): (drawScene): (setPositionAttribute): (setColorAttribute): (initBuffers): (initPositionBuffer): (initColorBuffer): (initShaderProgram): (loadShader): (main): * Source/WebCore/html/CanvasBase.cpp: (WebCore::CanvasBase::makeRenderingResultsAvailable): * Source/WebCore/html/CanvasBase.h: * Source/WebCore/html/CanvasNoiseInjection.cpp: (WebCore::CanvasNoiseInjection::postProcessDirtyCanvasBuffer): (WebCore::CanvasNoiseInjection::postProcessPixelBufferResults const): * Source/WebCore/html/CanvasNoiseInjection.h: * Source/WebCore/html/canvas/CanvasRenderingContext2DBase.cpp: (WebCore::CanvasRenderingContext2DBase::drawImage): * Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp: (WebCore::WebGLRenderingContextBase::markContextChangedAndNotifyCanvasObserver): Canonical link: https://commits.webkit.org/273301@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 0b9dfb: Implement MediaStreamTrack transfer to dedicated w...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 0b9dfbd9559968b0383455f58dcaeffaa57f https://github.com/WebKit/WebKit/commit/0b9dfbd9559968b0383455f58dcaeffaa57f Author: Youenn Fablet Date: 2024-01-22 (Mon, 22 Jan 2024) Changed paths: A LayoutTests/http/wpt/mediastream/transfer-mediastreamtrack-to-worker-expected.txt A LayoutTests/http/wpt/mediastream/transfer-mediastreamtrack-to-worker-worker.js A LayoutTests/http/wpt/mediastream/transfer-mediastreamtrack-to-worker.html A LayoutTests/http/wpt/mediastream/transfer-videotrackgenerator-track-expected.txt A LayoutTests/http/wpt/mediastream/transfer-videotrackgenerator-track.html M LayoutTests/imported/w3c/web-platform-tests/mediacapture-insertable-streams/idlharness.any.worker-expected.txt M LayoutTests/imported/w3c/web-platform-tests/mediacapture-streams/MediaStreamTrack-transfer-video.https-expected.txt M LayoutTests/platform/glib/TestExpectations M LayoutTests/platform/mac-wk1/TestExpectations M Source/WebCore/Headers.cmake M Source/WebCore/Modules/mediastream/MediaStreamTrack.cpp M Source/WebCore/Modules/mediastream/MediaStreamTrack.h M Source/WebCore/Modules/mediastream/MediaStreamTrack.idl M Source/WebCore/Modules/mediastream/MediaStreamTrackProcessor.cpp M Source/WebCore/Sources.txt M Source/WebCore/WebCore.xcodeproj/project.pbxproj M Source/WebCore/bindings/js/SerializedScriptValue.cpp M Source/WebCore/bindings/js/SerializedScriptValue.h A Source/WebCore/platform/mediastream/MediaStreamTrackDataHolder.cpp A Source/WebCore/platform/mediastream/MediaStreamTrackDataHolder.h M Source/WebCore/platform/mediastream/MediaStreamTrackPrivate.cpp M Source/WebCore/platform/mediastream/MediaStreamTrackPrivate.h M Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in M Tools/TestWebKitAPI/Tests/WebKit/GetUserMedia.mm M Tools/TestWebKitAPI/cocoa/UserMediaCaptureUIDelegate.h M Tools/TestWebKitAPI/cocoa/UserMediaCaptureUIDelegate.mm Log Message: --- Implement MediaStreamTrack transfer to dedicated workers in same agent cluster rdar://121180907 https://bugs.webkit.org/show_bug.cgi?id=267682 Reviewed by Eric Carlson. Introduce MediaStreamTrackDataHolder which is used to store the MediaStreamTrack information necessary as part of the transfer. It keeps the track source alive and allows to create a MediaStreamTrackPrivate from it. We expose MediaStreamTrack to window and dedicated worker but only support transferring tracks in the same agent cluster. The goal is typically to transfer the track from a window context to a dedicated worker created by the window context, to do track video frame processing. Given the source, even if transferred, is kept by the document for which was created the source, there is no impact on the privacy indicators. The new tests highlighted three issues in MediaStreamTrackProcessor: - The observer needs to be created right away or we need to add an if check. We are creating it right away - We were missing protecting the processor in MediaStreamTrackProcessor::VideoFrameObserver::videoFrameAvailable. - We should call ReadableStreamSource::pullFinished() only if enqueuing went well. * LayoutTests/http/wpt/mediastream/transfer-mediastreamtrack-to-worker-expected.txt: Added. * LayoutTests/http/wpt/mediastream/transfer-mediastreamtrack-to-worker-worker.js: Added. (makeOffscreenCanvasVideoFrame): (promise_test.async t): * LayoutTests/http/wpt/mediastream/transfer-mediastreamtrack-to-worker.html: Added. * LayoutTests/http/wpt/mediastream/transfer-videotrackgenerator-track-expected.txt: Added. * LayoutTests/http/wpt/mediastream/transfer-videotrackgenerator-track.html: Added. * LayoutTests/imported/w3c/web-platform-tests/mediacapture-insertable-streams/idlharness.any.worker-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/mediacapture-streams/MediaStreamTrack-transfer-video.https-expected.txt: * LayoutTests/platform/glib/TestExpectations: * LayoutTests/platform/mac-wk1/TestExpectations: * Source/WebCore/Headers.cmake: * Source/WebCore/Modules/mediastream/MediaStreamTrack.cpp: (WebCore::MediaStreamTrack::detach): (WebCore::MediaStreamTrack::create): * Source/WebCore/Modules/mediastream/MediaStreamTrack.h: (WebCore::MediaStreamTrack::isDetached const): * Source/WebCore/Modules/mediastream/MediaStreamTrack.idl: * Source/WebCore/Modules/mediastream/MediaStreamTrackProcessor.cpp: (WebCore::MediaStreamTrackProcessor::VideoFrameObserverWrapper::initialize): (WebCore::MediaStreamTrackProcessor::VideoFrameObserver::VideoFrameObserver): (WebCore::MediaStreamTrackProcessor::VideoFrameObserver::videoFrameAvailable): (WebCore::MediaStreamTrackProcessor::Source::enqueue): * Source/WebCore/Sources.txt: * Source/WebCore/WebCore.xcodeproj/project.pbxproj: * Source/WebCore/bindings/js/SerializedScriptValue.cpp: (WebCore::isTypeExposedToGlobalObject): (We
[webkit-changes] [WebKit/WebKit] 905209: [run-webkit-tests] Fix unit tests with a different...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 9052093b92b3f5db5d1a124acb40f7659de85445 https://github.com/WebKit/WebKit/commit/9052093b92b3f5db5d1a124acb40f7659de85445 Author: Jonathan Bedard Date: 2024-01-22 (Mon, 22 Jan 2024) Changed paths: M Tools/Scripts/libraries/webkitcorepy/webkitcorepy/mocks/subprocess.py M Tools/Scripts/libraries/webkitscmpy/webkitscmpy/test/hooks/prepare-commit-msg M Tools/Scripts/libraries/webkitscmpy/webkitscmpy/test/publish_unittest.py Log Message: --- [run-webkit-tests] Fix unit tests with a different git path https://bugs.webkit.org/show_bug.cgi?id=267794 rdar://121288444 Reviewed by Dewei Zhu. * Tools/Scripts/libraries/webkitcorepy/webkitcorepy/mocks/subprocess.py: (Subprocess.CommandRoute.matches): Allow commands to match without the exact path. (Subprocess.completion_generator_for): Ditto. * Tools/Scripts/libraries/webkitscmpy/webkitscmpy/test/hooks/prepare-commit-msg: * Tools/Scripts/libraries/webkitscmpy/webkitscmpy/test/publish_unittest.py: (TestPublish.test_git): Use production 'git' path. Canonical link: https://commits.webkit.org/273299@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] bb4042: Variable used to obtain a bit value from mModeFlag...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: bb40425085b9f49ff6091ce774729aca2db3f1ab https://github.com/WebKit/WebKit/commit/bb40425085b9f49ff6091ce774729aca2db3f1ab Author: Rose <83477269+ataridre...@users.noreply.github.com> Date: 2024-01-22 (Mon, 22 Jan 2024) Changed paths: M Source/WebCore/platform/graphics/cocoa/CMUtilities.mm Log Message: --- Variable used to obtain a bit value from mModeFlags is sign extended https://bugs.webkit.org/show_bug.cgi?id=263994 Reviewed by Simon Fraser. mModeFlags is a UInt64, which means we risk overflowing an integer when we use a signed integer to obtain bit-packed flags from it instead of using an unsigned long long. * Source/WebCore/platform/graphics/cocoa/CMUtilities.mm: (WebCore::PacketDurationParser::framesInPacket): Use an unsigned value to obtain the flags stored in mModeFlags. Canonical link: https://commits.webkit.org/273298@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] f2ffb0: Disable AppCache everywhere
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: f2ffb0129de49a3c02f2b513bba61c889394fbab https://github.com/WebKit/WebKit/commit/f2ffb0129de49a3c02f2b513bba61c889394fbab Author: Youenn Fablet Date: 2024-01-22 (Mon, 22 Jan 2024) Changed paths: M LayoutTests/TestExpectations M LayoutTests/fast/dom/dom-window-property-gc-after-frame-detach-expected.txt M LayoutTests/fast/dom/dom-window-property-gc-after-frame-detach.html M LayoutTests/fast/dom/event-handler-attributes.html M LayoutTests/fast/events/destroyed-atomic-string.html M LayoutTests/fast/events/dispatchEvent-crash-expected.txt M LayoutTests/fast/events/dispatchEvent-crash.html M LayoutTests/fast/loader/window-properties-restored-from-page-cache-expected.txt M LayoutTests/fast/loader/window-properties-restored-from-page-cache.html R LayoutTests/http/tests/appcache/404-manifest-expected.txt R LayoutTests/http/tests/appcache/404-manifest.html R LayoutTests/http/tests/appcache/404-resource-expected.txt R LayoutTests/http/tests/appcache/404-resource-with-slow-main-resource-expected.txt R LayoutTests/http/tests/appcache/404-resource-with-slow-main-resource.py R LayoutTests/http/tests/appcache/404-resource.html R LayoutTests/http/tests/appcache/abort-cache-onchecking-expected.txt R LayoutTests/http/tests/appcache/abort-cache-onchecking-manifest-404-expected.txt R LayoutTests/http/tests/appcache/abort-cache-onchecking-manifest-404.html R LayoutTests/http/tests/appcache/abort-cache-onchecking-resource-404-expected.txt R LayoutTests/http/tests/appcache/abort-cache-onchecking-resource-404.html R LayoutTests/http/tests/appcache/abort-cache-onchecking.html R LayoutTests/http/tests/appcache/abort-cache-ondownloading-expected.txt R LayoutTests/http/tests/appcache/abort-cache-ondownloading-manifest-404-expected.txt R LayoutTests/http/tests/appcache/abort-cache-ondownloading-manifest-404.html R LayoutTests/http/tests/appcache/abort-cache-ondownloading-resource-404-expected.txt R LayoutTests/http/tests/appcache/abort-cache-ondownloading-resource-404.html R LayoutTests/http/tests/appcache/abort-cache-ondownloading.html R LayoutTests/http/tests/appcache/abort-cache-onprogress-expected.txt R LayoutTests/http/tests/appcache/abort-cache-onprogress.html R LayoutTests/http/tests/appcache/access-via-redirect-expected.txt R LayoutTests/http/tests/appcache/access-via-redirect.py R LayoutTests/http/tests/appcache/appcache-cookies-expected.txt R LayoutTests/http/tests/appcache/appcache-cookies.html R LayoutTests/http/tests/appcache/auth-expected.txt R LayoutTests/http/tests/appcache/auth.html R LayoutTests/http/tests/appcache/crash-when-navigating-away-then-back-expected.txt R LayoutTests/http/tests/appcache/crash-when-navigating-away-then-back.html R LayoutTests/http/tests/appcache/credential-url-expected.txt R LayoutTests/http/tests/appcache/credential-url.html R LayoutTests/http/tests/appcache/cyrillic-uri-expected.txt R LayoutTests/http/tests/appcache/cyrillic-uri.html R LayoutTests/http/tests/appcache/decide-navigation-policy-after-delay-expected.txt R LayoutTests/http/tests/appcache/decide-navigation-policy-after-delay.html R LayoutTests/http/tests/appcache/deferred-events-delete-while-raising-expected.txt R LayoutTests/http/tests/appcache/deferred-events-delete-while-raising-timer-expected.txt R LayoutTests/http/tests/appcache/deferred-events-delete-while-raising-timer.html R LayoutTests/http/tests/appcache/deferred-events-delete-while-raising.html R LayoutTests/http/tests/appcache/deferred-events-expected.txt R LayoutTests/http/tests/appcache/deferred-events.html R LayoutTests/http/tests/appcache/destroyed-frame-expected.txt R LayoutTests/http/tests/appcache/destroyed-frame.html R LayoutTests/http/tests/appcache/detached-iframe-expected.txt R LayoutTests/http/tests/appcache/detached-iframe.html R LayoutTests/http/tests/appcache/different-https-origin-resource-main-expected.txt R LayoutTests/http/tests/appcache/different-https-origin-resource-main.html R LayoutTests/http/tests/appcache/different-origin-manifest-expected.txt R LayoutTests/http/tests/appcache/different-origin-manifest.html R LayoutTests/http/tests/appcache/different-scheme-expected.txt R LayoutTests/http/tests/appcache/different-scheme.html R LayoutTests/http/tests/appcache/disabled-expected.txt R LayoutTests/http/tests/appcache/disabled.html R LayoutTests/http/tests/appcache/document-cookie-expected.txt R LayoutTests/http/tests/appcache/document-cookie-http-only-expected.txt R LayoutTests/http/tests/appcache/document-cookie-http-only.py R LayoutTests/http/tests/appcache/document-cookie.py R LayoutTests/http/tests/appcache/document-write-html-element-2-expected.txt R LayoutTests/http/
[webkit-changes] [WebKit/WebKit] 8e62e0: [WGSL] Failed constant conversion should clean the...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 8e62e079b8ab55343fa35e533d41505728711209 https://github.com/WebKit/WebKit/commit/8e62e079b8ab55343fa35e533d41505728711209 Author: Tadeu Zagallo Date: 2024-01-22 (Mon, 22 Jan 2024) Changed paths: M Source/WebGPU/WGSL/TypeCheck.cpp M Source/WebGPU/WGSL/tests/invalid/division.wgsl M Source/WebGPU/WGSL/tests/invalid/modulo.wgsl Log Message: --- [WGSL] Failed constant conversion should clean the invalid constant https://bugs.webkit.org/show_bug.cgi?id=267780 rdar://121247554 Reviewed by Mike Wyrzykowski. If a constant is not valid in its target type, we should clean it so it's not further used in subsequent checks. * Source/WebGPU/WGSL/TypeCheck.cpp: (WGSL::TypeChecker::visitVariable): (WGSL::TypeChecker::visit): (WGSL::TypeChecker::bitcast): (WGSL::TypeChecker::chooseOverload): (WGSL::TypeChecker::convertValue): (WGSL::TypeChecker::convertValueImpl): (WGSL::TypeChecker::setConstantValue): * Source/WebGPU/WGSL/tests/invalid/division.wgsl: * Source/WebGPU/WGSL/tests/invalid/modulo.wgsl: Canonical link: https://commits.webkit.org/273296@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 9840b7: [WGSL] Array constructor should return when elemen...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 9840b7e8fa258cd249f96660d66528aa3d31c6bf https://github.com/WebKit/WebKit/commit/9840b7e8fa258cd249f96660d66528aa3d31c6bf Author: Tadeu Zagallo Date: 2024-01-22 (Mon, 22 Jan 2024) Changed paths: M Source/WebGPU/WGSL/TypeCheck.cpp M Source/WebGPU/WGSL/tests/invalid/array.wgsl Log Message: --- [WGSL] Array constructor should return when element type is invalid https://bugs.webkit.org/show_bug.cgi?id=267772 rdar://121247451 Reviewed by Mike Wyrzykowski. When type checking array constructors (e.g. array(...)) we failed to check if the resolved element type (T in the previous example) was valid. If the type is resolved to bottom, i.e. failed to resolve, the constructor should also fail. * Source/WebGPU/WGSL/TypeCheck.cpp: (WGSL::TypeChecker::visit): * Source/WebGPU/WGSL/tests/invalid/array.wgsl: Canonical link: https://commits.webkit.org/273295@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 1fcd68: [WGSL] Empty structs should be rejected
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 1fcd681a29a87c051da6138b2eb82d9ecc381296 https://github.com/WebKit/WebKit/commit/1fcd681a29a87c051da6138b2eb82d9ecc381296 Author: Tadeu Zagallo Date: 2024-01-22 (Mon, 22 Jan 2024) Changed paths: M Source/WebGPU/WGSL/Parser.cpp A Source/WebGPU/WGSL/tests/invalid/empty-struct.wgsl M Source/WebGPU/WGSL/tests/invalid/redeclaration-reordering.wgsl Log Message: --- [WGSL] Empty structs should be rejected https://bugs.webkit.org/show_bug.cgi?id=267771 rdar://121247449 Reviewed by Mike Wyrzykowski. It's not valid according to the spec to have a struct with no fields. We make it a parser failure for now. * Source/WebGPU/WGSL/Parser.cpp: (WGSL::Parser::parseStructure): * Source/WebGPU/WGSL/tests/invalid/empty-struct.wgsl: Added. * Source/WebGPU/WGSL/tests/invalid/redeclaration-reordering.wgsl: Canonical link: https://commits.webkit.org/273294@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 26d12c: [LBSE] 'mask' / 'clipPath' (SVG) DOM changes shoul...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 26d12c80d8df13b1005c00fc45cb88ad622e2f64 https://github.com/WebKit/WebKit/commit/26d12c80d8df13b1005c00fc45cb88ad622e2f64 Author: Nikolas Zimmermann Date: 2024-01-22 (Mon, 22 Jan 2024) Changed paths: M LayoutTests/platform/ios/svg/repaint/clip-path-object-bounding-box-transformed-expected.txt M LayoutTests/platform/ios/svg/repaint/mask-object-bounding-box-transformed-expected.txt A LayoutTests/platform/mac-sonoma-wk2-lbse-text/svg/animations/svg-element-attribute-changed-crash-expected.txt A LayoutTests/platform/mac-sonoma-wk2-lbse-text/svg/transforms/svg-css-transforms-clip-path-expected.txt A LayoutTests/svg/repaint/clip-path-change-unit-space-expected.txt A LayoutTests/svg/repaint/clip-path-change-unit-space.html M LayoutTests/svg/repaint/clip-path-object-bounding-box-transformed-expected.txt M LayoutTests/svg/repaint/clip-path-user-space-on-use-transformed-expected.txt M LayoutTests/svg/repaint/mask-object-bounding-box-transformed-expected.txt M LayoutTests/svg/repaint/mask-user-space-on-use-transformed-expected.txt M Source/WebCore/rendering/ReferencedSVGResources.cpp M Source/WebCore/rendering/RenderLayer.cpp M Source/WebCore/rendering/svg/SVGContainerLayout.cpp M Source/WebCore/svg/SVGClipPathElement.cpp M Source/WebCore/svg/SVGMaskElement.cpp Log Message: --- [LBSE] 'mask' / 'clipPath' (SVG) DOM changes should never trigger relayouts https://bugs.webkit.org/show_bug.cgi?id=267732 Reviewed by Rob Buis and Simon Fraser. When clipPahUnits change via (SVG) DOM, SVGClipPathElement::svgAttributeChanged() will trigger an async re-layout of the associated RenderSVGResourceClipper. This is useless, as it does not repaint the elements making use of the resource. Furthermore unnecessary work is spent in layout - avoid all of that, and repaint the old and new boundaries of all resource users, with the help of RenderLayers repaintRect tracking, that assures the objects is repainted at its old and new position, not leaving visual artifacts. Covered by existing tests in LBSE + added a new test svg/repaint/clip-path-change-unit-space.html. * LayoutTests/platform/ios/svg/repaint/clip-path-object-bounding-box-transformed-expected.txt: * LayoutTests/platform/ios/svg/repaint/mask-object-bounding-box-transformed-expected.txt: * LayoutTests/platform/mac-sonoma-wk2-lbse-text/svg/animations/svg-element-attribute-changed-crash-expected.txt: Added. * LayoutTests/platform/mac-sonoma-wk2-lbse-text/svg/transforms/svg-css-transforms-clip-path-expected.txt: Added. * LayoutTests/svg/repaint/clip-path-change-unit-space-expected.txt: Added. * LayoutTests/svg/repaint/clip-path-change-unit-space.html: Added. * LayoutTests/svg/repaint/clip-path-object-bounding-box-transformed-expected.txt: * LayoutTests/svg/repaint/clip-path-user-space-on-use-transformed-expected.txt: * LayoutTests/svg/repaint/mask-object-bounding-box-transformed-expected.txt: * LayoutTests/svg/repaint/mask-user-space-on-use-transformed-expected.txt: * Source/WebCore/rendering/ReferencedSVGResources.cpp: (WebCore::CSSSVGResourceElementClient::resourceChanged): * Source/WebCore/rendering/RenderLayer.cpp: (WebCore::RenderLayer::recursiveUpdateLayerPositions): * Source/WebCore/rendering/svg/SVGContainerLayout.cpp: (WebCore::SVGContainerLayout::layoutChildren): * Source/WebCore/svg/SVGClipPathElement.cpp: (WebCore::SVGClipPathElement::svgAttributeChanged): (WebCore::SVGClipPathElement::childrenChanged): * Source/WebCore/svg/SVGMaskElement.cpp: (WebCore::SVGMaskElement::svgAttributeChanged): (WebCore::SVGMaskElement::childrenChanged): Canonical link: https://commits.webkit.org/273293@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 4dab5e: REGRESSION(272844@main): [GStreamer][Debug] ASSERT...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 4dab5e97eee362997bc251c68299d3e72d118181 https://github.com/WebKit/WebKit/commit/4dab5e97eee362997bc251c68299d3e72d118181 Author: Philippe Normand Date: 2024-01-22 (Mon, 22 Jan 2024) Changed paths: M LayoutTests/platform/glib/TestExpectations M LayoutTests/platform/gtk-wayland/TestExpectations M LayoutTests/platform/gtk/TestExpectations R LayoutTests/platform/gtk/webrtc/canvas-to-peer-connection-2d-expected.txt M LayoutTests/platform/wpe/TestExpectations M Source/WebCore/Modules/mediastream/gstreamer/GStreamerMediaEndpoint.cpp M Source/WebCore/Modules/mediastream/gstreamer/GStreamerMediaEndpoint.h M Source/WebCore/Modules/mediastream/gstreamer/GStreamerPeerConnectionBackend.cpp M Source/WebCore/Modules/mediastream/gstreamer/GStreamerPeerConnectionBackend.h M Source/WebCore/Modules/mediastream/gstreamer/GStreamerRtpSenderBackend.cpp M Source/WebCore/Modules/mediastream/gstreamer/GStreamerRtpSenderBackend.h M Source/WebCore/Modules/mediastream/gstreamer/GStreamerRtpTransceiverBackend.cpp M Source/WebCore/Modules/mediastream/gstreamer/GStreamerRtpTransceiverBackend.h M Source/WebCore/platform/SourcesGStreamer.txt M Source/WebCore/platform/graphics/gstreamer/VideoFrameMetadataGStreamer.cpp A Source/WebCore/platform/mediastream/gstreamer/GStreamerIncomingTrackProcessor.cpp A Source/WebCore/platform/mediastream/gstreamer/GStreamerIncomingTrackProcessor.h M Source/WebCore/platform/mediastream/gstreamer/GStreamerMediaStreamSource.cpp A Source/WebCore/platform/mediastream/gstreamer/GStreamerWebRTCCommon.h M Source/WebCore/platform/mediastream/gstreamer/RealtimeIncomingAudioSourceGStreamer.cpp M Source/WebCore/platform/mediastream/gstreamer/RealtimeIncomingSourceGStreamer.cpp M Source/WebCore/platform/mediastream/gstreamer/RealtimeIncomingSourceGStreamer.h M Source/WebCore/platform/mediastream/gstreamer/RealtimeIncomingVideoSourceGStreamer.cpp M Source/WebCore/platform/mediastream/gstreamer/RealtimeIncomingVideoSourceGStreamer.h M Source/WebCore/platform/mediastream/gstreamer/RealtimeOutgoingAudioSourceGStreamer.cpp M Source/WebCore/platform/mediastream/gstreamer/RealtimeOutgoingAudioSourceGStreamer.h M Source/WebCore/platform/mediastream/gstreamer/RealtimeOutgoingMediaSourceGStreamer.cpp M Source/WebCore/platform/mediastream/gstreamer/RealtimeOutgoingMediaSourceGStreamer.h M Source/WebCore/platform/mediastream/gstreamer/RealtimeOutgoingVideoSourceGStreamer.cpp Log Message: --- REGRESSION(272844@main): [GStreamer][Debug] ASSERTION FAILED: isMainThread() in WebCore::MediaStreamTrackPrivate::source() https://bugs.webkit.org/show_bug.cgi?id=267411 Reviewed by Xabier Rodriguez-Calvar. Make sure we don't access the RealtimeMediaSource from non-main threads. Parsing and/or decoding on incoming RTP packets is now done between the webrtcbin src pad and the incoming source bin. Thus, track events are dispatched only when all parsers and/or decoders are ready, from the main thread. * LayoutTests/platform/glib/TestExpectations: * LayoutTests/platform/gtk-wayland/TestExpectations: * LayoutTests/platform/gtk/TestExpectations: * LayoutTests/platform/gtk/webrtc/canvas-to-peer-connection-2d-expected.txt: Removed. * LayoutTests/platform/wpe/TestExpectations: * Source/WebCore/Modules/mediastream/gstreamer/GStreamerMediaEndpoint.cpp: (WebCore::GStreamerMediaEndpoint::initializePipeline): (WebCore::GStreamerMediaEndpoint::teardownPipeline): (WebCore::GStreamerMediaEndpoint::getStats): (WebCore::GStreamerMediaEndpoint::connectIncomingTrack): (WebCore::GStreamerMediaEndpoint::connectPad): (WebCore::GStreamerMediaEndpoint::suspend): (WebCore::GStreamerMediaEndpoint::resume): (WebCore::GStreamerMediaEndpoint::addRemoteStream): Deleted. (WebCore::GStreamerMediaEndpoint::startRemoteStream): Deleted. * Source/WebCore/Modules/mediastream/gstreamer/GStreamerMediaEndpoint.h: (WebCore::GStreamerMediaEndpoint::webrtcBin const): * Source/WebCore/Modules/mediastream/gstreamer/GStreamerPeerConnectionBackend.cpp: (WebCore::GStreamerPeerConnectionBackend::getStats): (WebCore::GStreamerPeerConnectionBackend::tearDown): * Source/WebCore/Modules/mediastream/gstreamer/GStreamerPeerConnectionBackend.h: * Source/WebCore/Modules/mediastream/gstreamer/GStreamerRtpSenderBackend.cpp: (WebCore::GStreamerRtpSenderBackend::tearDown): * Source/WebCore/Modules/mediastream/gstreamer/GStreamerRtpSenderBackend.h: * Source/WebCore/Modules/mediastream/gstreamer/GStreamerRtpTransceiverBackend.cpp: (WebCore::GStreamerRtpTransceiverBackend::tearDown): * Source/WebCore/Modules/mediastream/gstreamer/GStreamerRtpTransceiverBackend.h: * Source/WebCore/platform/SourcesGStreamer.txt: * Source/WebCore/platform/graphics/gstreamer/VideoFrameMetadataGStreamer.cpp: (videoFrameMetadataGetInfo): * Source/WebCore/platform/mediastream/gstr
[webkit-changes] [WebKit/WebKit] 8a6406: REGRESSION(272844@main): [GStreamer][Debug] ASSERT...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 8a64069be24e2e1f74a7f5314055bc05fe1ff656 https://github.com/WebKit/WebKit/commit/8a64069be24e2e1f74a7f5314055bc05fe1ff656 Author: Vitaly Dyachkov Date: 2024-01-22 (Mon, 22 Jan 2024) Changed paths: M LayoutTests/platform/glib/TestExpectations M LayoutTests/platform/gtk/TestExpectations M LayoutTests/platform/wpe/TestExpectations Log Message: --- REGRESSION(272844@main): [GStreamer][Debug] ASSERTION FAILED: isMainThread() in WebCore::MediaStreamTrackPrivate::source() https://bugs.webkit.org/show_bug.cgi?id=267411 Unreviewed test gardening. * LayoutTests/platform/glib/TestExpectations: * LayoutTests/platform/gtk/TestExpectations: * LayoutTests/platform/wpe/TestExpectations: Canonical link: https://commits.webkit.org/273291@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 074546: [GStreamer][WebCodecs] Improve support for h.264 f...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 0745467377affa10f7b1a2aef1a93a148afbe71e https://github.com/WebKit/WebKit/commit/0745467377affa10f7b1a2aef1a93a148afbe71e Author: Philippe Normand Date: 2024-01-22 (Mon, 22 Jan 2024) Changed paths: M LayoutTests/platform/glib/TestExpectations R LayoutTests/platform/glib/imported/w3c/web-platform-tests/webcodecs/videoFrame-canvasImageSource-expected.txt A LayoutTests/platform/gtk/imported/w3c/web-platform-tests/webcodecs/videoFrame-canvasImageSource-expected.txt A LayoutTests/platform/wpe/imported/w3c/web-platform-tests/webcodecs/videoFrame-canvasImageSource-expected.txt M Source/WebCore/platform/graphics/gstreamer/VideoDecoderGStreamer.cpp M Source/WebCore/platform/gstreamer/GStreamerElementHarness.cpp M Source/WebCore/platform/gstreamer/GStreamerElementHarness.h Log Message: --- [GStreamer][WebCodecs] Improve support for h.264 frames reordering in decoder https://bugs.webkit.org/show_bug.cgi?id=265335 Reviewed by Youenn Fablet and Xabier Rodriguez-Calvar. The GStreamer video decoder flush logic was flawed, assuming a flush-start/stop cycle would be sufficient, but in practice we need to send EOS and teardown the element to force drain of the decoder. * LayoutTests/platform/glib/TestExpectations: * LayoutTests/platform/gtk/imported/w3c/web-platform-tests/webcodecs/videoFrame-canvasImageSource-expected.txt: Copied from LayoutTests/platform/glib/imported/w3c/web-platform-tests/webcodecs/videoFrame-canvasImageSource-expected.txt. * LayoutTests/platform/wpe/imported/w3c/web-platform-tests/webcodecs/videoFrame-canvasImageSource-expected.txt: Renamed from LayoutTests/platform/glib/imported/w3c/web-platform-tests/webcodecs/videoFrame-canvasImageSource-expected.txt. * Source/WebCore/platform/graphics/gstreamer/VideoDecoderGStreamer.cpp: (WebCore::GStreamerInternalVideoDecoder::GStreamerInternalVideoDecoder): (WebCore::GStreamerInternalVideoDecoder::decode): (WebCore::GStreamerInternalVideoDecoder::flush): * Source/WebCore/platform/gstreamer/GStreamerElementHarness.cpp: (WebCore::GStreamerElementHarness::~GStreamerElementHarness): (WebCore::GStreamerElementHarness::reset): * Source/WebCore/platform/gstreamer/GStreamerElementHarness.h: Canonical link: https://commits.webkit.org/273290@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 7c24c6: Make iOS-zooming comp...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 7c24c6f0873d402fb1cdd125b3668b2adddc5692 https://github.com/WebKit/WebKit/commit/7c24c6f0873d402fb1cdd125b3668b2adddc5692 Author: Anne van Kesteren Date: 2024-01-22 (Mon, 22 Jan 2024) Changed paths: A LayoutTests/fast/forms/switch/zoom-computed-style-expected.txt A LayoutTests/fast/forms/switch/zoom-computed-style.html M Source/WebCore/rendering/RenderThemeIOS.mm Log Message: --- Make iOS-zooming compatible with other ports https://bugs.webkit.org/show_bug.cgi?id=267757 rdar://121248632 Reviewed by Aditya Keerthi. This ensures that on iOS builds that can paint a switch, the following tests pass as expected: - fast/forms/switch/zoom-approximates-transform-rtl.html - fast/forms/switch/zoom-approximates-transform-vertical-lr.html - fast/forms/switch/zoom-approximates-transform-vertical-rl.html - fast/forms/switch/zoom-approximates-transform.html Without this fix there would be some amount of zooming on iOS due to it currently aligning with the font-size, but only for very large zoom values. Also add a new test that demonstrates this does not impact getComputedStyle() across platforms. * LayoutTests/fast/forms/switch/zoom-computed-style-expected.txt: Added. * LayoutTests/fast/forms/switch/zoom-computed-style.html: Added. * Source/WebCore/rendering/RenderThemeIOS.mm: (WebCore::RenderThemeIOS::adjustSwitchStyle const): Canonical link: https://commits.webkit.org/273289@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
