[webkit-changes] [WebKit/WebKit] a01156: [iOS] Time picker fails to dodge the software keyb...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: a011563227e99a7fb9f3d81a7ec7645d538b71ce https://github.com/WebKit/WebKit/commit/a011563227e99a7fb9f3d81a7ec7645d538b71ce Author: Wenson Hsieh Date: 2024-01-24 (Wed, 24 Jan 2024) Changed paths: M Source/WebKit/UIProcess/ios/forms/WKDatePickerPopoverController.mm Log Message: --- [iOS] Time picker fails to dodge the software keyboard when presented below the element https://bugs.webkit.org/show_bug.cgi?id=268056 rdar://120403319 Reviewed by Aditya Keerthi. When presented *below* the time input, it's possible for time pickers to shrink (and sometimes even dismiss) when a software keyboard is shown, upon focusing either the hour or minute field. Avoid this for now by not presenting below the input; I've separately filed rdar://121571971 for UIKit to investigate moving the popover content in this case, instead of shrinking to fit. * Source/WebKit/UIProcess/ios/forms/WKDatePickerPopoverController.mm: (-[WKDatePickerPopoverController presentInView:sourceRect:completion:]): Canonical link: https://commits.webkit.org/273480@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 16fc26: contentHint should be preserved when transferring ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 16fc264632e675343232c6aa6be92017f8c3757d https://github.com/WebKit/WebKit/commit/16fc264632e675343232c6aa6be92017f8c3757d Author: Youenn Fablet Date: 2024-01-24 (Wed, 24 Jan 2024) Changed paths: M LayoutTests/http/wpt/mediastream/transfer-mediastreamtrack-to-worker-expected.txt M LayoutTests/http/wpt/mediastream/transfer-mediastreamtrack-to-worker.html M Source/WebCore/Headers.cmake M Source/WebCore/Modules/mediastream/MediaStreamTrack.cpp M Source/WebCore/WebCore.xcodeproj/project.pbxproj M Source/WebCore/platform/mediastream/MediaStreamTrackDataHolder.cpp M Source/WebCore/platform/mediastream/MediaStreamTrackDataHolder.h A Source/WebCore/platform/mediastream/MediaStreamTrackHintValue.h M Source/WebCore/platform/mediastream/MediaStreamTrackPrivate.cpp M Source/WebCore/platform/mediastream/MediaStreamTrackPrivate.h Log Message: --- contentHint should be preserved when transferring a MediaStreamTrack https://bugs.webkit.org/show_bug.cgi?id=267921 rdar://121516684 Reviewed by Eric Carlson. We add contentHint as a slot in data holder. We make sure to set contentHint in MediaStreamTrackPrivate constructor. We remove the optimization in MediaStreamTrack::create for the document case since this creates two code paths that we would need to keep in sync. * LayoutTests/http/wpt/mediastream/transfer-mediastreamtrack-to-worker-expected.txt: * LayoutTests/http/wpt/mediastream/transfer-mediastreamtrack-to-worker.html: * Source/WebCore/Headers.cmake: * Source/WebCore/Modules/mediastream/MediaStreamTrack.cpp: (WebCore::contentHintToAtomString): (WebCore::MediaStreamTrack::contentHint const): (WebCore::MediaStreamTrack::setContentHint): (WebCore::MediaStreamTrack::create): * Source/WebCore/WebCore.xcodeproj/project.pbxproj: * Source/WebCore/platform/mediastream/MediaStreamTrackDataHolder.cpp: (WebCore::MediaStreamTrackDataHolder::MediaStreamTrackDataHolder): * Source/WebCore/platform/mediastream/MediaStreamTrackDataHolder.h: * Source/WebCore/platform/mediastream/MediaStreamTrackHintValue.h: Added. * Source/WebCore/platform/mediastream/MediaStreamTrackPrivate.cpp: (WebCore::MediaStreamTrackPrivate::MediaStreamTrackPrivate): (WebCore::MediaStreamTrackPrivate::setContentHint): (WebCore::MediaStreamTrackPrivate::toDataHolder): * Source/WebCore/platform/mediastream/MediaStreamTrackPrivate.h: Canonical link: https://commits.webkit.org/273479@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 578277: Adopt more smart pointers in ResourceLoader.cpp
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 578277aa333935292b2c672558d6e45bfe14d7e4 https://github.com/WebKit/WebKit/commit/578277aa333935292b2c672558d6e45bfe14d7e4 Author: Chris Dumez Date: 2024-01-24 (Wed, 24 Jan 2024) Changed paths: M Source/WebCore/loader/FrameLoader.cpp M Source/WebCore/loader/FrameLoader.h M Source/WebCore/loader/ResourceLoader.cpp M Source/WebCore/loader/ResourceLoader.h Log Message: --- Adopt more smart pointers in ResourceLoader.cpp https://bugs.webkit.org/show_bug.cgi?id=268054 Reviewed by Ryosuke Niwa. * Source/WebCore/loader/FrameLoader.cpp: (WebCore::FrameLoader::protectedNetworkingContext const): * Source/WebCore/loader/FrameLoader.h: * Source/WebCore/loader/ResourceLoader.cpp: (WebCore::ResourceLoader::finishNetworkLoad): (WebCore::ResourceLoader::releaseResources): (WebCore::ResourceLoader::init): (WebCore::ResourceLoader::start): (WebCore::ResourceLoader::setDefersLoading): (WebCore::ResourceLoader::loadDataURL): (WebCore::ResourceLoader::willSwitchToSubstituteResource): (WebCore::ResourceLoader::checkedFrameLoader const): (WebCore::ResourceLoader::willSendRequestInternal): (WebCore::logResourceResponseSource): (WebCore::ResourceLoader::shouldAllowResourceToAskForCredentials const): (WebCore::ResourceLoader::didBlockAuthenticationChallenge): (WebCore::ResourceLoader::didReceiveResponse): (WebCore::ResourceLoader::didReceiveBuffer): (WebCore::ResourceLoader::didFinishLoadingOnePart): (WebCore::ResourceLoader::didFail): (WebCore::ResourceLoader::cleanupForError): (WebCore::ResourceLoader::cancel): (WebCore::ResourceLoader::cancelledError): (WebCore::ResourceLoader::blockedError): (WebCore::ResourceLoader::blockedByContentBlockerError): (WebCore::ResourceLoader::cannotShowURLError): (WebCore::ResourceLoader::httpsUpgradeRedirectLoopError): (WebCore::ResourceLoader::willSendRequestAsync): (WebCore::ResourceLoader::didReceiveResponseAsync): (WebCore::ResourceLoader::shouldUseCredentialStorage): (WebCore::ResourceLoader::didReceiveAuthenticationChallenge): (WebCore::ResourceLoader::canAuthenticateAgainstProtectionSpace): (WebCore::ResourceLoader::connectionProperties): (WebCore::ResourceLoader::schedule): (WebCore::ResourceLoader::unschedule): (WebCore::ResourceLoader::isPDFJSResourceLoad const): * Source/WebCore/loader/ResourceLoader.h: Canonical link: https://commits.webkit.org/273478@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 5bde3a: Unreviewed, reverting 273240@main.
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 5bde3ab2239688184694a4b26061468ed95a0af3 https://github.com/WebKit/WebKit/commit/5bde3ab2239688184694a4b26061468ed95a0af3 Author: Commit Queue Date: 2024-01-24 (Wed, 24 Jan 2024) Changed paths: M Source/WebCore/SourcesCocoa.txt M Source/WebCore/WebCore.xcodeproj/project.pbxproj M Source/WebCore/platform/graphics/ImageBuffer.h M Source/WebCore/platform/graphics/cocoa/IOSurface.h R Source/WebCore/platform/graphics/re/DynamicContentScalingResourceCache.h R Source/WebCore/platform/graphics/re/DynamicContentScalingResourceCache.mm M Source/WebKit/GPUProcess/graphics/RemoteRenderingBackend.cpp M Source/WebKit/GPUProcess/graphics/RemoteRenderingBackend.h M Source/WebKit/Shared/RemoteLayerTree/DynamicContentScalingBifurcatedImageBuffer.h M Source/WebKit/Shared/RemoteLayerTree/DynamicContentScalingBifurcatedImageBuffer.mm M Source/WebKit/Shared/RemoteLayerTree/DynamicContentScalingImageBufferBackend.mm M Source/WebKit/Shared/RemoteLayerTree/RemoteLayerWithInProcessRenderingBackingStore.mm M Source/WebKit/WebProcess/WebPage/RemoteLayerTree/RemoteLayerTreeContext.h M Source/WebKit/WebProcess/WebPage/RemoteLayerTree/RemoteLayerTreeContext.mm Log Message: --- Unreviewed, reverting 273240@main. https://bugs.webkit.org/show_bug.cgi?id=268062 Caused unnecessary port accumulation and IPC message send rejection Reverted changeset: "Dynamic Content Scaling resource cache cannot cache images between layers" https://bugs.webkit.org/show_bug.cgi?id=245920 https://commits.webkit.org/273240@main Canonical link: https://commits.webkit.org/273477@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] bca58a: [WebAuthn] Check mediation optional before derefer...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: bca58a413d4d4767ebf590b3466b330f67db277a https://github.com/WebKit/WebKit/commit/bca58a413d4d4767ebf590b3466b330f67db277a Author: Pascoe Date: 2024-01-24 (Wed, 24 Jan 2024) Changed paths: M Source/WebKit/UIProcess/WebAuthentication/Cocoa/WebAuthenticatorCoordinatorProxy.mm Log Message: --- [WebAuthn] Check mediation optional before dereferencing https://bugs.webkit.org/show_bug.cgi?id=268021 rdar://121530024 Reviewed by Charlie Wolfe. We need to check if this conditional is present before comparing it's value. * Source/WebKit/UIProcess/WebAuthentication/Cocoa/WebAuthenticatorCoordinatorProxy.mm: (WebKit::WebAuthenticatorCoordinatorProxy::requestsForAssertion): Public AuthenticationServices API will not accept security key requests for autofill requests at this time so we shouldn't include one. (WebKit::WebAuthenticatorCoordinatorProxy::performRequest): Canonical link: https://commits.webkit.org/273476@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] e20379: Corrupt/missing tile content on tab switch.
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: e203798dcce88cf721d6c2061ca00a63b9811c3d https://github.com/WebKit/WebKit/commit/e203798dcce88cf721d6c2061ca00a63b9811c3d Author: Matt Woodrow Date: 2024-01-24 (Wed, 24 Jan 2024) Changed paths: M Source/WebKit/Shared/RemoteLayerTree/RemoteLayerBackingStore.h M Source/WebKit/Shared/RemoteLayerTree/RemoteLayerBackingStore.mm M Source/WebKit/Shared/RemoteLayerTree/RemoteLayerWithInProcessRenderingBackingStore.h M Source/WebKit/Shared/RemoteLayerTree/RemoteLayerWithInProcessRenderingBackingStore.mm M Source/WebKit/Shared/RemoteLayerTree/RemoteLayerWithRemoteRenderingBackingStore.h M Source/WebKit/Shared/RemoteLayerTree/RemoteLayerWithRemoteRenderingBackingStore.mm M Source/WebKit/WebProcess/GPU/graphics/RemoteImageBufferSetProxy.cpp M Source/WebKit/WebProcess/GPU/graphics/RemoteImageBufferSetProxy.h Log Message: --- Corrupt/missing tile content on tab switch. https://bugs.webkit.org/show_bug.cgi?id=268025 Reviewed by Simon Fraser. Creating a flusher for a RemoteLayerBackingStore now waits for backend handles to be delivered as well as flushing any drawing. We need to call this even when the dirty region is empty, so that we get handles delivered. Adds an enum to describe what we want to wait for, so that can avoid flushing the drawing (or creating a flusher entirely) if no drawing commands have been issued. https://bugs.webkit.org/show_bug.cgi?id=267749 (PR #22958) adds a test that will catch this. * Source/WebKit/Shared/RemoteLayerTree/RemoteLayerBackingStore.h: * Source/WebKit/Shared/RemoteLayerTree/RemoteLayerBackingStore.mm: (WebKit::RemoteLayerBackingStore::paintContents): * Source/WebKit/Shared/RemoteLayerTree/RemoteLayerWithInProcessRenderingBackingStore.h: * Source/WebKit/Shared/RemoteLayerTree/RemoteLayerWithInProcessRenderingBackingStore.mm: (WebKit::RemoteLayerWithInProcessRenderingBackingStore::createFlusher): * Source/WebKit/Shared/RemoteLayerTree/RemoteLayerWithRemoteRenderingBackingStore.h: * Source/WebKit/Shared/RemoteLayerTree/RemoteLayerWithRemoteRenderingBackingStore.mm: (WebKit::RemoteLayerWithRemoteRenderingBackingStore::createFlusher): * Source/WebKit/WebProcess/GPU/graphics/RemoteImageBufferSetProxy.cpp: (WebKit::RemoteImageBufferSetProxyFlushFence::create): (WebKit::RemoteImageBufferSetProxyFlushFence::waitFor): (WebKit::RemoteImageBufferSetProxyFlushFence::tryTakeEvent): (WebKit::RemoteImageBufferSetProxyFlushFence::RemoteImageBufferSetProxyFlushFence): (WebKit::RemoteImageBufferSetProxy::flushFrontBufferAsync): * Source/WebKit/WebProcess/GPU/graphics/RemoteImageBufferSetProxy.h: Canonical link: https://commits.webkit.org/273475@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 6be388: AX: WebProcess::accessibilityRelayProcessSuspended...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 6be388b56fc65fe2f3eb74bd266b3d89b0b8ef13 https://github.com/WebKit/WebKit/commit/6be388b56fc65fe2f3eb74bd266b3d89b0b8ef13 Author: Tyler Wilcock Date: 2024-01-24 (Wed, 24 Jan 2024) Changed paths: M Source/WebKit/WebProcess/WebProcess.cpp M Source/WebKit/WebProcess/WebProcess.h Log Message: --- AX: WebProcess::accessibilityRelayProcessSuspended can drop requests to unsuspend, causing ATs to think web content is permanently suspended https://bugs.webkit.org/show_bug.cgi?id=268024 rdar://problem/121545631 Reviewed by Andres Gonzalez. Depending on timing, we can get a call to unsuspend the process at a moment when we don't have any webpages (but may gain them soon). Even when we do get a webpage back, we don't try to send the process unsuspension message, causing assistive technologies to think we are permanently suspended. Fix this by storing this pending unsuspension as a new WebProcess member variable, and processing it when a webpage is added. * Source/WebKit/WebProcess/WebProcess.cpp: (WebKit::WebProcess::createWebPage): (WebKit::WebProcess::accessibilityRelayProcessSuspended): * Source/WebKit/WebProcess/WebProcess.h: Canonical link: https://commits.webkit.org/273474@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 580e58: [72857589b8bce60e] ASAN_ILL | WebCore::TreeScopeOr...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 580e5844c227041f4e3dc3356948a9568a3b6d15 https://github.com/WebKit/WebKit/commit/580e5844c227041f4e3dc3356948a9568a3b6d15 Author: Erica Li Date: 2024-01-24 (Wed, 24 Jan 2024) Changed paths: A LayoutTests/fast/shadow-dom/svg-mpath-removed-from-ancestor-crash-expected.txt A LayoutTests/fast/shadow-dom/svg-mpath-removed-from-ancestor-crash.html M Source/WebCore/svg/SVGAnimateMotionElement.cpp M Source/WebCore/svg/SVGAnimateMotionElement.h M Source/WebCore/svg/SVGMPathElement.cpp M Source/WebCore/svg/SVGMPathElement.h Log Message: --- [72857589b8bce60e] ASAN_ILL | WebCore::TreeScopeOrderedMap::getElementById; WebCore::TreeScope::getElementById; WebCore::SVGURIReference::targetElementFromIRIString. https://bugs.webkit.org/show_bug.cgi?id=265562 rdar://118513775 Reviewed by Chris Dumez. updateAnimationPath should be done after treescope is fully updated. * LayoutTests/fast/shadow-dom/svg-mpath-removed-from-ancestor-crash-expected.txt: Added. * LayoutTests/fast/shadow-dom/svg-mpath-removed-from-ancestor-crash.html: Added. * Source/WebCore/svg/SVGAnimateMotionElement.cpp: (WebCore::SVGAnimateMotionElement::childrenChanged): * Source/WebCore/svg/SVGAnimateMotionElement.h: * Source/WebCore/svg/SVGMPathElement.cpp: (WebCore::SVGMPathElement::removedFromAncestor): (WebCore::SVGMPathElement::targetPathChanged): (WebCore::SVGMPathElement::notifyParentOfPathChange): Deleted. * Source/WebCore/svg/SVGMPathElement.h: Originally-landed-as: 267815.611@safari-7617-branch (ca57f6a1de59). rdar://121480927 Canonical link: https://commits.webkit.org/273473@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 235ea5: rdar://115106974 (SEGV in -[NSView resizeSubviewsW...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 235ea5801184534cc4fe85b818c642eeea8849c3 https://github.com/WebKit/WebKit/commit/235ea5801184534cc4fe85b818c642eeea8849c3 Author: Scott Marcy Date: 2024-01-24 (Wed, 24 Jan 2024) Changed paths: M LayoutTests/TestExpectations A LayoutTests/ipc/invalid-fullscreen-enum-expected.txt A LayoutTests/ipc/invalid-fullscreen-enum.html A LayoutTests/ipc/resources/1080i60_SMPTE_8CH_audible.mov M Source/WebCore/platform/graphics/MediaPlayerEnums.h M Source/WebKit/UIProcess/Cocoa/VideoPresentationManagerProxy.mm Log Message: --- rdar://115106974 (SEGV in -[NSView resizeSubviewsWithOldSize:]) Checks that the VideoFullscreenMode argument for two IPC calls is valid and invalidates the IPC message if not. Reviewed by Alex Christensen (achristensen07). If the VideoFullscreenMode value is not as expected it IPC message will be marked as invalid, which is supposed to crash the content process thereby thwarting any attempted attack through this mechanism. * LayoutTests/TestExpectations: * LayoutTests/ipc/invalid-fullscreen-enum-expected.txt: Added. * LayoutTests/ipc/invalid-fullscreen-enum.html: Added. * LayoutTests/ipc/resources/1080i60_SMPTE_8CH_audible.mov: Added. * Source/WebCore/platform/graphics/MediaPlayerEnums.h: * Source/WebKit/UIProcess/Cocoa/VideoPresentationManagerProxy.mm: (WebKit::VideoPresentationManagerProxy::setupFullscreenWithID): (WebKit::VideoPresentationManagerProxy::exitFullscreenWithoutAnimationToMode): Originally-landed-as: 267815.636@safari-7617-branch (cc4e54ad41c9). rdar://121480101 Canonical link: https://commits.webkit.org/273472@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 67a191: Fix adattributiond sandbox violation
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 67a191ac740b0193fdbba0a43941e6c6bf12454f https://github.com/WebKit/WebKit/commit/67a191ac740b0193fdbba0a43941e6c6bf12454f Author: Brent Fulgham Date: 2024-01-24 (Wed, 24 Jan 2024) Changed paths: M Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.adattributiond.sb.in Log Message: --- Fix adattributiond sandbox violation https://bugs.webkit.org/show_bug.cgi?id=268039 Reviewed by Per Arne Vollan. In Bug 263274 we added user-specific DarwinDirectoryDataStore to the adattributiond sandbox, but neglected the system fallback location. This triggers sandbox telemetry and prevents the expected fallback behavior. * Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.adattributiond.sb.in: Canonical link: https://commits.webkit.org/273471@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] dbe36e: Move PseudoElementRequest to its own file
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: dbe36ee35f87eddccece6a3e58f2673ac284f8ba https://github.com/WebKit/WebKit/commit/dbe36ee35f87eddccece6a3e58f2673ac284f8ba Author: Tim Nguyen Date: 2024-01-24 (Wed, 24 Jan 2024) Changed paths: M Source/WebCore/WebCore.xcodeproj/project.pbxproj M Source/WebCore/style/ElementRuleCollector.h A Source/WebCore/style/PseudoElementRequest.h Log Message: --- Move PseudoElementRequest to its own file https://bugs.webkit.org/show_bug.cgi?id=268048 rdar://121565442 Reviewed by Simon Fraser. We shouldn't need to import ElementRuleCollector.h to use this class. * Source/WebCore/WebCore.xcodeproj/project.pbxproj: * Source/WebCore/style/ElementRuleCollector.h: (WebCore::Style::PseudoElementRequest::PseudoElementRequest): Deleted. * Source/WebCore/style/PseudoElementRequest.h: Added. (WebCore::Style::PseudoElementRequest::PseudoElementRequest): Canonical link: https://commits.webkit.org/273470@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] a166cb: [iOS] Time picker fails to blur after tapping the ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: a166cbc7846f1df9bac19ca8a314f333e122d8bb https://github.com/WebKit/WebKit/commit/a166cbc7846f1df9bac19ca8a314f333e122d8bb Author: Wenson Hsieh Date: 2024-01-24 (Wed, 24 Jan 2024) Changed paths: M Source/WebKit/UIProcess/ios/forms/WKDatePickerPopoverController.mm Log Message: --- [iOS] Time picker fails to blur after tapping the page while editing hour/minute text fields https://bugs.webkit.org/show_bug.cgi?id=268046 rdar://119175928 Reviewed by Aditya Keerthi. When editing hour/minute text fields while a time picker is presented and then tapping any non- editable content on the page to dismiss the time picker and keyboard, the `-presentationControllerDidDismiss:` `UIPopoverPresentationControllerDelegate` method never gets invoked by UIKit. As a result, we end up never sending `-accessoryDone` back to the content view and blurring the time input, which then gets us into a state where subsequent attempts to focus the time input fail to show a popover, because the content view is still in a state where it thinks the popover is still presenting. To address this, we can instead override `-viewDidDisappear:` and notify the popover controller delegate if needed, which is (luckily) still invoked in this scenario. * Source/WebKit/UIProcess/ios/forms/WKDatePickerPopoverController.mm: (-[WKDatePickerPopoverController viewDidDisappear:]): Canonical link: https://commits.webkit.org/273469@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] e1395e: Create and adopt an SQLite store for web extension...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: e1395e4dbba28625de13524fc5e94921c1eba60e https://github.com/WebKit/WebKit/commit/e1395e4dbba28625de13524fc5e94921c1eba60e Author: Kiara Rose Date: 2024-01-24 (Wed, 24 Jan 2024) Changed paths: M Source/WebKit/Shared/Extensions/WebExtensionUtilities.h M Source/WebKit/Shared/Extensions/WebExtensionUtilities.mm M Source/WebKit/Shared/Extensions/_WKWebExtensionSQLiteStore.mm M Source/WebKit/UIProcess/Extensions/Cocoa/API/WebExtensionContextAPIStorageCocoa.mm M Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionContextCocoa.mm A Source/WebKit/UIProcess/Extensions/Cocoa/_WKWebExtensionStorageSQLiteStore.h A Source/WebKit/UIProcess/Extensions/Cocoa/_WKWebExtensionStorageSQLiteStore.mm M Source/WebKit/UIProcess/Extensions/WebExtensionContext.h M Source/WebKit/UIProcess/Extensions/WebExtensionContext.messages.in M Source/WebKit/WebKit.xcodeproj/project.pbxproj M Source/WebKit/WebProcess/Extensions/API/Cocoa/WebExtensionAPIStorageAreaCocoa.mm M Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionAPIStorage.mm Log Message: --- Create and adopt an SQLite store for web extension Storage API https://bugs.webkit.org/show_bug.cgi?id=267649 rdar://121143226 Reviewed by Timothy Hatcher. This patch creates and adopts a _WKWebExtensionStorageSQLiteStore which is used to manage storage for web extensions. This patch also changes the way the data is sent over to the UI Proccess. Instead of using a IPC::DataReference object, simply encode the data as a JSON string and send it that way. * Source/WebKit/Shared/Extensions/WebExtensionUtilities.h: * Source/WebKit/Shared/Extensions/WebExtensionUtilities.mm: (WebKit::storageSizeOf): (WebKit::anyItemsExceedQuota): * Source/WebKit/Shared/Extensions/_WKWebExtensionSQLiteStore.mm: * Source/WebKit/Shared/Extensions/_WKWebExtensionStorageSQLiteStore.h: Added. * Source/WebKit/UIProcess/Extensions/Cocoa/API/WebExtensionContextAPIStorageCocoa.mm: Utlize _WKWebExtensionStorageSQLiteStore to get/set/remove/clear data. (WebKit::WebExtensionContext::storageGet): (WebKit::WebExtensionContext::storageGetBytesInUse): (WebKit::WebExtensionContext::storageSet): (WebKit::WebExtensionContext::storageRemove): (WebKit::WebExtensionContext::storageClear): * Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionContextCocoa.mm: (WebKit::WebExtensionContext::invalidateStorage): (WebKit::WebExtensionContext::quoataForStorageType): (WebKit::WebExtensionContext::localStorageStore): (WebKit::WebExtensionContext::sessionStorageStore): (WebKit::WebExtensionContext::syncStorageStore): (WebKit::WebExtensionContext::storageForType): * Source/WebKit/UIProcess/Extensions/Cocoa/_WKWebExtensionStorageSQLiteStore.h: Added. * Source/WebKit/UIProcess/Extensions/Cocoa/_WKWebExtensionStorageSQLiteStore.mm: Added. (rowFilterStringFromRowKeys): (-[_WKWebExtensionStorageSQLiteStore initWithUniqueIdentifier:storageType:directory:usesInMemoryDatabase:]): (-[_WKWebExtensionStorageSQLiteStore getValuesForKeys:completionHandler:]): (-[_WKWebExtensionStorageSQLiteStore getStorageSizeForKeys:completionHandler:]): (-[_WKWebExtensionStorageSQLiteStore getStorageSizeForAllKeysIncludingKeyedData:withCompletionHandler:]): (-[_WKWebExtensionStorageSQLiteStore setKeyedData:completionHandler:]): (-[_WKWebExtensionStorageSQLiteStore deleteValuesForKeys:completionHandler:]): (-[_WKWebExtensionStorageSQLiteStore _databaseURL]): (-[_WKWebExtensionStorageSQLiteStore _insertOrUpdateValue:forKey:inDatabase:]): (-[_WKWebExtensionStorageSQLiteStore _getValuesForAllKeysReturningErrorMessage:]): (-[_WKWebExtensionStorageSQLiteStore _getKeysAndValuesFromRowEnumerator:]): (-[_WKWebExtensionStorageSQLiteStore _getAllKeysReturningErrorMessage:]): (-[_WKWebExtensionStorageSQLiteStore _getValuesForKeys:outErrorMessage:]): (-[_WKWebExtensionStorageSQLiteStore _currentDatabaseSchemaVersion]): (-[_WKWebExtensionStorageSQLiteStore _createFreshDatabaseSchema]): (-[_WKWebExtensionStorageSQLiteStore _resetDatabaseSchema]): (-[_WKWebExtensionStorageSQLiteStore _isDatabaseEmpty]): * Source/WebKit/UIProcess/Extensions/WebExtensionContext.h: * Source/WebKit/UIProcess/Extensions/WebExtensionContext.messages.in: * Source/WebKit/WebKit.xcodeproj/project.pbxproj: * Source/WebKit/WebProcess/Extensions/API/Cocoa/WebExtensionAPIStorageAreaCocoa.mm: (WebKit::WebExtensionAPIStorageArea::get): If 'items' is a dictionary with keys and default values, only send the keys over to the UI process since we can add the default values after we receive the data from storage. (WebKit::WebExtensionAPIStorageArea::getBytesInUse): (WebKit::WebExtensionAPIStorageArea::set): * Source/WebKit/WebProcess/Extensions/API/WebExtensionAPIStorageArea.h: * Source/WebKit/WebProcess/Extensions/Interfaces/WebExtensionAPIStorageArea.idl: Needs JSContextRef so we can serialize and deserialize the data in 'storage.get()' and
[webkit-changes] [WebKit/WebKit] 0963c1: REGRESSION (273187@main): [ iOS17 Debug arm64 ] AS...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 0963c19c0ab8e2a0872897f1fb3399cc70948bcd https://github.com/WebKit/WebKit/commit/0963c19c0ab8e2a0872897f1fb3399cc70948bcd Author: Chris Dumez Date: 2024-01-24 (Wed, 24 Jan 2024) Changed paths: M LayoutTests/platform/ios-wk2/TestExpectations M Source/WebCore/workers/service/server/SWServerWorker.cpp Log Message: --- REGRESSION (273187@main): [ iOS17 Debug arm64 ] ASSERTION FAILED:bool WTF::RefCountedBase::hasOneRef() in http/tests/workers/service/postmessage-after-terminate.https.html result of a flaky crash https://bugs.webkit.org/show_bug.cgi?id=268029 rdar://121550392 Unreviewed, very partial revert of 273187@main to address the assertion hit. * LayoutTests/platform/ios-wk2/TestExpectations: * Source/WebCore/workers/service/server/SWServerWorker.cpp: (WebCore::SWServerWorker::contextConnection): Canonical link: https://commits.webkit.org/273467@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 82020f: Unused member WebMResourceClientParent::m_buffer
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 82020f502c2444bfa7923579957e4e3fe7096593 https://github.com/WebKit/WebKit/commit/82020f502c2444bfa7923579957e4e3fe7096593 Author: Jean-Yves Avenard Date: 2024-01-24 (Wed, 24 Jan 2024) Changed paths: M Source/WebCore/platform/graphics/WebMResourceClient.cpp M Source/WebCore/platform/graphics/WebMResourceClient.h Log Message: --- Unused member WebMResourceClientParent::m_buffer https://bugs.webkit.org/show_bug.cgi?id=268041 rdar://121560631 Reviewed by Eric Carlson. Remove member. No change in observable behaviour. * Source/WebCore/platform/graphics/WebMResourceClient.cpp: (WebCore::WebMResourceClient::dataReceived): * Source/WebCore/platform/graphics/WebMResourceClient.h: Canonical link: https://commits.webkit.org/273466@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 5c6404: [webkitdirs] Xcode destination lookup always uses ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 5c64049edf356c4ede296c32ef130f1deecd2a08 https://github.com/WebKit/WebKit/commit/5c64049edf356c4ede296c32ef130f1deecd2a08 Author: Elliott Williams Date: 2024-01-24 (Wed, 24 Jan 2024) Changed paths: M Tools/Scripts/webkitdirs.pm Log Message: --- [webkitdirs] Xcode destination lookup always uses iOS simulator runtime rdar://121553208 https://bugs.webkit.org/show_bug.cgi?id=268034 Reviewed by Tim Horton. Look up simulator runtime using the platform name and parsing the JSON output. When computing destination for simulator devices, fall back to building for a generic device when no simulators are available. * Tools/Scripts/webkitdirs.pm: (determineXcodeDestination): Use the active port name to select simulator runtime. Implement generic fallback logic. (iosSimulatorRuntime): Retained for compatibility. (simulatorRuntime): Renamed from iosSimulatorRuntime, new parsing logic. Canonical link: https://commits.webkit.org/273465@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 72a0a4: Remove NavigationActionPolicyParameters in favor o...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 72a0a4511e3ff50356a68b37e78de6c3ce281606 https://github.com/WebKit/WebKit/commit/72a0a4511e3ff50356a68b37e78de6c3ce281606 Author: Alex Christensen Date: 2024-01-24 (Wed, 24 Jan 2024) Changed paths: M Source/WebKit/CMakeLists.txt M Source/WebKit/DerivedSources-input.xcfilelist M Source/WebKit/DerivedSources.make M Source/WebKit/Shared/NavigationActionData.h M Source/WebKit/Shared/NavigationActionData.serialization.in R Source/WebKit/Shared/NavigationActionPolicyParameters.h R Source/WebKit/Shared/NavigationActionPolicyParameters.serialization.in M Source/WebKit/UIProcess/ProvisionalPageProxy.cpp M Source/WebKit/UIProcess/ProvisionalPageProxy.h M Source/WebKit/UIProcess/RemotePageProxy.cpp M Source/WebKit/UIProcess/RemotePageProxy.h M Source/WebKit/UIProcess/WebPageProxy.cpp M Source/WebKit/UIProcess/WebPageProxy.h M Source/WebKit/UIProcess/WebPageProxy.messages.in M Source/WebKit/WebKit.xcodeproj/project.pbxproj M Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.cpp M Source/WebKit/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp M Source/WebKit/WebProcess/WebCoreSupport/WebFrameLoaderClient.h M Source/WebKit/WebProcess/WebCoreSupport/WebLocalFrameLoaderClient.cpp Log Message: --- Remove NavigationActionPolicyParameters in favor of NavigationActionData https://bugs.webkit.org/show_bug.cgi?id=268016 rdar://121536820 Reviewed by Brady Eidson. It turns out we can put everything we need into NavigationActionData, making NavigationActionPolicyParameters useless. Also, I made a function on WebFrameLoaderClient to get the NavigationActionData so I can reuse it for other things. NavigationActionData is actually used in a few places. This is also a small step towards unifying them. For now I only added what was used and consolidated a few other parameters into NavigationActionData. Some future refactoring is probably still in order. * Source/WebKit/CMakeLists.txt: * Source/WebKit/DerivedSources-input.xcfilelist: * Source/WebKit/DerivedSources.make: * Source/WebKit/Shared/NavigationActionData.h: * Source/WebKit/Shared/NavigationActionData.serialization.in: * Source/WebKit/Shared/NavigationActionPolicyParameters.h: Removed. * Source/WebKit/Shared/NavigationActionPolicyParameters.serialization.in: Removed. * Source/WebKit/UIProcess/ProvisionalPageProxy.cpp: (WebKit::ProvisionalPageProxy::decidePolicyForNavigationActionAsync): (WebKit::ProvisionalPageProxy::decidePolicyForNavigationActionSync): * Source/WebKit/UIProcess/ProvisionalPageProxy.h: * Source/WebKit/UIProcess/RemotePageProxy.cpp: (WebKit::RemotePageProxy::decidePolicyForNavigationActionAsync): (WebKit::RemotePageProxy::decidePolicyForNavigationActionSync): * Source/WebKit/UIProcess/RemotePageProxy.h: * Source/WebKit/UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::decidePolicyForNavigationActionAsync): (WebKit::WebPageProxy::decidePolicyForNavigationActionAsyncShared): (WebKit::WebPageProxy::decidePolicyForNavigationAction): (WebKit::WebPageProxy::decidePolicyForNavigationActionSync): (WebKit::WebPageProxy::decidePolicyForNavigationActionSyncShared): * Source/WebKit/UIProcess/WebPageProxy.h: * Source/WebKit/UIProcess/WebPageProxy.messages.in: * Source/WebKit/WebKit.xcodeproj/project.pbxproj: * Source/WebKit/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp: (WebKit::WebFrameLoaderClient::navigationActionData const): (WebKit::WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction): * Source/WebKit/WebProcess/WebCoreSupport/WebFrameLoaderClient.h: Canonical link: https://commits.webkit.org/273464@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 7346bf: Expand site-isolation test coverage to include imp...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 7346bfb4e5f21cf8778d309c6582019cd0bbc598 https://github.com/WebKit/WebKit/commit/7346bfb4e5f21cf8778d309c6582019cd0bbc598 Author: Alex Christensen Date: 2024-01-24 (Wed, 24 Jan 2024) Changed paths: M LayoutTests/platform/mac-site-isolation/TestExpectations Log Message: --- Expand site-isolation test coverage to include imported/w3c/web-platform-tests/html/browsers https://bugs.webkit.org/show_bug.cgi?id=268045 rdar://121563515 Reviewed by Charlie Wolfe. * LayoutTests/platform/mac-site-isolation/TestExpectations: Canonical link: https://commits.webkit.org/273463@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 852fa1: WebFrame::frameLoaderClient should return a WebFra...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 852fa131995ef97f11cab81c7137659e3552cd03 https://github.com/WebKit/WebKit/commit/852fa131995ef97f11cab81c7137659e3552cd03 Author: Alex Christensen Date: 2024-01-24 (Wed, 24 Jan 2024) Changed paths: M Source/WebCore/page/Frame.h M Source/WebCore/page/LocalFrame.cpp M Source/WebCore/page/LocalFrame.h M Source/WebCore/page/RemoteFrame.cpp M Source/WebCore/page/RemoteFrame.h M Source/WebCore/page/RemoteFrameClient.h M Source/WebKit/WebProcess/WebCoreSupport/WebRemoteFrameClient.cpp M Source/WebKit/WebProcess/WebCoreSupport/WebRemoteFrameClient.h M Source/WebKit/WebProcess/WebPage/WebCookieJar.cpp M Source/WebKit/WebProcess/WebPage/WebFrame.cpp M Source/WebKit/WebProcess/WebPage/WebFrame.h M Source/WebKit/WebProcess/WebPage/WebPage.cpp Log Message: --- WebFrame::frameLoaderClient should return a WebFrameLoaderClient https://bugs.webkit.org/show_bug.cgi?id=268038 rdar://121558709 Reviewed by Charlie Wolfe. This allows me to get the frame's WebKit-level client even if the WebFrame is wrapping a RemoteFrame. * Source/WebCore/page/Frame.h: * Source/WebCore/page/LocalFrame.cpp: (WebCore::LocalFrame::loaderClient): * Source/WebCore/page/LocalFrame.h: * Source/WebCore/page/RemoteFrame.cpp: (WebCore::RemoteFrame::loaderClient): * Source/WebCore/page/RemoteFrame.h: * Source/WebCore/page/RemoteFrameClient.h: * Source/WebKit/WebProcess/WebCoreSupport/WebRemoteFrameClient.cpp: (WebKit::WebRemoteFrameClient::dispatchDecidePolicyForNavigationAction): * Source/WebKit/WebProcess/WebCoreSupport/WebRemoteFrameClient.h: * Source/WebKit/WebProcess/WebPage/WebCookieJar.cpp: (WebKit::shouldBlockCookies): * Source/WebKit/WebProcess/WebPage/WebFrame.cpp: (WebKit::WebFrame::localFrameLoaderClient const): (WebKit::WebFrame::frameLoaderClient const): (WebKit::WebFrame::didCommitLoadInAnotherProcess): (WebKit::WebFrame::didReceivePolicyDecision): * Source/WebKit/WebProcess/WebPage/WebFrame.h: * Source/WebKit/WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::requestStorageAccess): Canonical link: https://commits.webkit.org/273462@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 66bf68: Element::parserSetAttributes shouldn't trigger sha...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 66bf68c9f4593eecb8dc370eb0761cb7a0e1ae77 https://github.com/WebKit/WebKit/commit/66bf68c9f4593eecb8dc370eb0761cb7a0e1ae77 Author: Ryosuke Niwa Date: 2024-01-24 (Wed, 24 Jan 2024) Changed paths: M Source/WebCore/html/HTMLInputElement.cpp M Source/WebCore/html/HTMLTextFormControlElement.cpp M Source/WebCore/html/TextFieldInputType.cpp M Source/WebCore/testing/Internals.cpp Log Message: --- Element::parserSetAttributes shouldn't trigger shadow tree construction in TextFieldInputType::attributeChanged https://bugs.webkit.org/show_bug.cgi?id=267936 Reviewed by Aditya Keerthi and Yusuke Suzuki. Don't construct shadow tree in TextFieldInputType::attributeChanged. * Source/WebCore/html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::updateType): Sanitize the value before calling createShadowSubtreeIfNeeded. Otherwise, we can assert in NumberInputType::localizeValue for example. * Source/WebCore/html/HTMLTextFormControlElement.cpp: (WebCore::HTMLTextFormControlElement::setSelectionRange): * Source/WebCore/html/TextFieldInputType.cpp: (WebCore::TextFieldInputType::isEmptyValue const): Now checks visibleValue() when the shadow tree doesn't exist yet. (WebCore::TextFieldInputType::createShadowSubtree): Update the inner text value after creating the shadow tree. (WebCore::TextFieldInputType::attributeChanged): Fixed the code so that it no longer constructs the shadow tree. * Source/WebCore/testing/Internals.cpp: (WebCore::Internals::visiblePlaceholder): Update the style / layout so that the shadow tree will get created. Canonical link: https://commits.webkit.org/273461@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 22343e: Add support for suppressing clang static analyzer ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 22343e69f00f3f26fc5df4016a301a654b1c0bc3 https://github.com/WebKit/WebKit/commit/22343e69f00f3f26fc5df4016a301a654b1c0bc3 Author: David Kilzer Date: 2024-01-24 (Wed, 24 Jan 2024) Changed paths: M Source/WTF/wtf/Compiler.h M Tools/TestWebKitAPI/Tests/WTF/CheckedPtr.cpp M Tools/TestWebKitAPI/Tests/WTF/CompactPtr.cpp M Tools/TestWebKitAPI/Tests/WTF/CompactRefPtr.cpp M Tools/TestWebKitAPI/Tests/WTF/FixedVector.cpp M Tools/TestWebKitAPI/Tests/WTF/ListHashSet.cpp M Tools/TestWebKitAPI/Tests/WTF/NakedPtr.cpp M Tools/TestWebKitAPI/Tests/WTF/PackedRefPtr.cpp M Tools/TestWebKitAPI/Tests/WTF/RefPtr.cpp M Tools/TestWebKitAPI/Tests/WTF/URL.cpp M Tools/TestWebKitAPI/Tests/WTF/Vector.cpp M Tools/TestWebKitAPI/Tests/WTF/WeakPtr.cpp M Tools/TestWebKitAPI/Tests/WTF/cf/RetainPtr.cpp M Tools/TestWebKitAPI/Tests/WTF/cocoa/TypeCastsCocoa.mm M Tools/TestWebKitAPI/Tests/WTF/ns/RetainPtr.mm M Tools/TestWebKitAPI/Tests/WebKit/cocoa/WeakObjCPtr.mm Log Message: --- Add support for suppressing clang static analyzer issues with [[clang::suppress]] https://bugs.webkit.org/show_bug.cgi?id=267981 Reviewed by Alex Christensen and Darin Adler. This adds support for the `[[clang::suppress]]` attribute in clang-17. Currently there is no way to ignore specific analyzer warnings, but the macros add support for documenting the warning(s) in case support is added later. The `[[clang::suppress]]` attribute can be applied to a single line of code or to a block of code. * Source/WTF/wtf/Compiler.h: (COMPILER_HAS_ATTRIBUTE): Add. - Define helper macro since __has_attribute() is used more than once. (COMPILER_HAS_CLANG_FEATURE): - Update documentation link to https. (FALLTHROUGH): (NOT_TAIL_CALLED): - Use COMPILER_HAS_ATTRIBUTE(). (IGNORE_CLANG_STATIC_ANALYZER_WARNINGS_ATTRIBUTE): Add. (IGNORE_CLANG_STATIC_ANALYZER_WARNINGS_BEGIN): Add. (IGNORE_CLANG_STATIC_ANALYZER_WARNINGS_END): Add. - Add support for the [[clang::suppress]] attribute. (IGNORE_CLANG_STATIC_ANALYZER_USE_AFTER_MOVE_ATTRIBUTE): Add. (TLS_MODEL_INITIAL_EXEC): - Use COMPILER_HAS_ATTRIBUTE(). * Tools/TestWebKitAPI/Tests/WTF/CheckedPtr.cpp: * Tools/TestWebKitAPI/Tests/WTF/CompactPtr.cpp: * Tools/TestWebKitAPI/Tests/WTF/CompactRefPtr.cpp: * Tools/TestWebKitAPI/Tests/WTF/FixedVector.cpp: * Tools/TestWebKitAPI/Tests/WTF/ListHashSet.cpp: * Tools/TestWebKitAPI/Tests/WTF/NakedPtr.cpp: * Tools/TestWebKitAPI/Tests/WTF/PackedRefPtr.cpp: * Tools/TestWebKitAPI/Tests/WTF/RefPtr.cpp: * Tools/TestWebKitAPI/Tests/WTF/URL.cpp: * Tools/TestWebKitAPI/Tests/WTF/Vector.cpp: * Tools/TestWebKitAPI/Tests/WTF/WeakPtr.cpp: * Tools/TestWebKitAPI/Tests/WTF/cf/RetainPtr.cpp: * Tools/TestWebKitAPI/Tests/WTF/cocoa/TypeCastsCocoa.mm: * Tools/TestWebKitAPI/Tests/WTF/ns/RetainPtr.mm: * Tools/TestWebKitAPI/Tests/WebKit/cocoa/WeakObjCPtr.mm: - Ignore expected cplusplus.Move warnings using IGNORE_CLANG_STATIC_ANALYZER_USE_AFTER_MOVE_ATTRIBUTE. Canonical link: https://commits.webkit.org/273460@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 10fba3: [GARDENING]Add more expectations to site isolation
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 10fba3f4e35c6953735d213df8d73b9dde09659e https://github.com/WebKit/WebKit/commit/10fba3f4e35c6953735d213df8d73b9dde09659e Author: Robert Jenner Date: 2024-01-24 (Wed, 24 Jan 2024) Changed paths: M LayoutTests/platform/mac-site-isolation/TestExpectations Log Message: --- [GARDENING]Add more expectations to site isolation https://bugs.webkit.org/show_bug.cgi?id=268049 rdar://121565791 Unreviewed test gardening. * LayoutTests/platform/mac-site-isolation/TestExpectations: Canonical link: https://commits.webkit.org/273459@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] eaff76: Add a hasUnreadBadgeText property to _WKWebExtensi...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: eaff760b4a9ea37d5bbf33fd6d8f775b4c845135 https://github.com/WebKit/WebKit/commit/eaff760b4a9ea37d5bbf33fd6d8f775b4c845135 Author: Timothy Hatcher Date: 2024-01-24 (Wed, 24 Jan 2024) Changed paths: M Source/WebKit/UIProcess/API/Cocoa/_WKWebExtensionAction.h M Source/WebKit/UIProcess/API/Cocoa/_WKWebExtensionAction.mm M Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionActionCocoa.mm M Source/WebKit/UIProcess/Extensions/WebExtensionAction.h M Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionAPIAction.mm Log Message: --- Add a hasUnreadBadgeText property to _WKWebExtensionAction. https://webkit.org/b/268014 rdar://problem/121536115 Reviewed by Brian Weinstein. This property is automatically set to `YES` when `badgeText` changes and is not empty. If `badgeText` becomes empty or the popup associated with the action is presented, this property is automatically set to `NO`. Additionally, it should be set to `NO` by the app when the badge has been presented to the user. This property is useful for higher-level notification badges when extensions might be hidden behind an action sheet. * Source/WebKit/UIProcess/API/Cocoa/_WKWebExtensionAction.h: * Source/WebKit/UIProcess/API/Cocoa/_WKWebExtensionAction.mm: (-[_WKWebExtensionAction hasUnreadBadgeText]): Added. (-[_WKWebExtensionAction setHasUnreadBadgeText:]): Added. * Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionActionCocoa.mm: (WebKit::WebExtensionAction::readyToPresentPopup): (WebKit::WebExtensionAction::setBadgeText): (WebKit::WebExtensionAction::hasUnreadBadgeText const): Added. (WebKit::WebExtensionAction::setHasUnreadBadgeText): Added. (WebKit::WebExtensionAction::incrementBlockedResourceCount): * Source/WebKit/UIProcess/Extensions/WebExtensionAction.h: * Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionAPIAction.mm: (TestWebKitAPI::TEST): Added new tests. Canonical link: https://commits.webkit.org/273458@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] bba680: Remove non-standard `KeyboardEvent.keyLocation`
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: bba680e17fee76325be7facc38899eda3f43d419 https://github.com/WebKit/WebKit/commit/bba680e17fee76325be7facc38899eda3f43d419 Author: Ahmad Saleem Date: 2024-01-24 (Wed, 24 Jan 2024) Changed paths: M LayoutTests/fast/events/constructors/keyboard-event-constructor-expected.txt M LayoutTests/fast/events/constructors/keyboard-event-constructor.html M LayoutTests/fast/events/ios/key-events-comprehensive/key-events-control-expected.txt M LayoutTests/fast/events/ios/key-events-comprehensive/key-events-control-option-expected.txt M LayoutTests/fast/events/ios/key-events-comprehensive/key-events-control-shift-expected.txt M LayoutTests/fast/events/ios/key-events-comprehensive/key-events-meta-control-expected.txt M LayoutTests/fast/events/ios/key-events-comprehensive/key-events-meta-expected.txt M LayoutTests/fast/events/ios/key-events-comprehensive/key-events-meta-option-expected.txt M LayoutTests/fast/events/ios/key-events-comprehensive/key-events-meta-shift-expected.txt M LayoutTests/fast/events/ios/key-events-comprehensive/key-events-option-expected.txt M LayoutTests/fast/events/ios/key-events-comprehensive/key-events-option-shift-expected.txt M LayoutTests/fast/events/ios/key-events-comprehensive/key-events-shift-expected.txt M Source/WebCore/dom/KeyboardEvent.cpp M Source/WebCore/dom/KeyboardEvent.h M Source/WebCore/dom/KeyboardEvent.idl Log Message: --- Remove non-standard `KeyboardEvent.keyLocation` https://bugs.webkit.org/show_bug.cgi?id=267819 Reviewed by Ryosuke Niwa. This patch aligns WebKit with Gecko / Firefox and Blink / Chromium by removing non-standard KeyboardEvent.keyLocation (alias of 'location'). It is not in web-specification [1]. [1] https://w3c.github.io/uievents/#events-keyboardevents It was never shipped in Gecko / Firefox while removed in Blink in 2016 and with commit [2]: [2] https://chromium.googlesource.com/chromium/src.git/+/263d94f9b2dc4a0a3cf5b3124c1cc8d2163a4410 * Source/WebCore/dom/KeyboardEvent.cpp: (KeyboardEvent::KeyboardEvent): * Source/WebCore/dom/KeyboardEvent.h: * Source/WebCore/dom/KeyboardEvent.idl: * LayoutTests/fast/events/constructors/keyboard-event-constructor.html: Rebaselined * LayoutTests/fast/events/constructors/keyboard-event-constructor-expected.txt: Rebaselined * LayoutTests/fast/events/ios/key-events-comprehensive/key-events-control-expected.txt: Rebaselined * LayoutTests/fast/events/ios/key-events-comprehensive/key-events-control-option-expected.txt: Ditto * LayoutTests/fast/events/ios/key-events-comprehensive/key-events-control-shift-expected.txt: Ditto * LayoutTests/fast/events/ios/key-events-comprehensive/key-events-meta-control-expected.txt: Ditto * LayoutTests/fast/events/ios/key-events-comprehensive/key-events-meta-expected.txt: Ditto * LayoutTests/fast/events/ios/key-events-comprehensive/key-events-meta-option-expected.txt: Ditto * LayoutTests/fast/events/ios/key-events-comprehensive/key-events-meta-shift-expected.txt: Ditto * LayoutTests/fast/events/ios/key-events-comprehensive/key-events-option-expected.txt: Ditto * LayoutTests/fast/events/ios/key-events-comprehensive/key-events-option-shift-expected.txt: Ditto * LayoutTests/fast/events/ios/key-events-comprehensive/key-events-shift-expected.txt: Ditto Canonical link: https://commits.webkit.org/273457@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] e0038b: [UnifiedPDF] Start handling text widget annotations.
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: e0038b5b7ace4173ca4547fbbf9f4e124dec0675 https://github.com/WebKit/WebKit/commit/e0038b5b7ace4173ca4547fbbf9f4e124dec0675 Author: Sammy Gill Date: 2024-01-24 (Wed, 24 Jan 2024) Changed paths: M Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.mm M Source/WebKit/WebProcess/Plugins/PDF/PDFPluginAnnotation.mm M Source/WebKit/WebProcess/Plugins/PDF/PDFPluginBase.h M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/PDFDocumentLayout.h M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/PDFDocumentLayout.mm M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.h M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm Log Message: --- [UnifiedPDF] Start handling text widget annotations. https://bugs.webkit.org/show_bug.cgi?id=267967 rdar://problem/121474907 Reviewed by Simon Fraser. To start handling text annotations, we start by handling mouse left clicks. When doing this we check to see if there is an annotation under the left click event and if is a text annotation widget. If this is the case then we will set the active annotation to this one (making sure to commit any other previously active annotation). The PDFPluginAnnotation that is created will need the bounds for the underlying annotation to properly style the HTML input element that is used. This is a matter of getting the bounds from the annotation, which is in page space, and then converting it into document space. Before this patch the PDFPluginAnnotation was performing this conversion, but I moved this responsibility to the PDFPlugins instead so that the annotations can just do everything in document space. * Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.mm: (WebKit::PDFPlugin::boundsForAnnotation const): * Source/WebKit/WebProcess/Plugins/PDF/PDFPluginAnnotation.mm: (WebKit::PDFPluginAnnotation::updateGeometry): * Source/WebKit/WebProcess/Plugins/PDF/PDFPluginBase.h: * Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/PDFDocumentLayout.h: * Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/PDFDocumentLayout.mm: (WebKit::PDFDocumentLayout::indexForPage const): * Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.h: * Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm: (WebKit::UnifiedPDFPlugin::UnifiedPDFPlugin): (WebKit::documentSpaceToPageSpaceTransform): (WebKit::UnifiedPDFPlugin::convertFromDocumentToPage const): (WebKit::UnifiedPDFPlugin::convertFromPageToDocument const): (WebKit::UnifiedPDFPlugin::handleMouseEvent): (WebKit::UnifiedPDFPlugin::boundsForAnnotation const): (WebKit::UnifiedPDFPlugin::setActiveAnnotation): Canonical link: https://commits.webkit.org/273456@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] a073c4: [Gardening]: NEW TEST (264371@main): [ iOS17 Debug...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: a073c417465ac3c39ae9e6a3be1fa8edcef94e59 https://github.com/WebKit/WebKit/commit/a073c417465ac3c39ae9e6a3be1fa8edcef94e59 Author: Marta Darbinyan Date: 2024-01-24 (Wed, 24 Jan 2024) Changed paths: M LayoutTests/platform/ios-wk2/TestExpectations Log Message: --- [Gardening]: NEW TEST (264371@main): [ iOS17 Debug ] ipc/shared-video-frame-size.html is a consistent crash https://bugs.webkit.org/show_bug.cgi?id=268044 rdar://121562681 Unreviewed test gardening. Adding test expectation * LayoutTests/platform/ios-wk2/TestExpectations: Canonical link: https://commits.webkit.org/273455@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] eb9ae0: REGRESSION (272891@main): [ Sonoma wk1 ] css3/filt...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: eb9ae09f0c935b2e0e39f8a6082baa6f357fd067 https://github.com/WebKit/WebKit/commit/eb9ae09f0c935b2e0e39f8a6082baa6f357fd067 Author: Karl Rackler Date: 2024-01-24 (Wed, 24 Jan 2024) Changed paths: M LayoutTests/css3/filters/effect-grayscale.html M LayoutTests/platform/mac-wk1/TestExpectations Log Message: --- REGRESSION (272891@main): [ Sonoma wk1 ] css3/filters/effect-grayscale.html is a consistent image failure https://bugs.webkit.org/show_bug.cgi?id=267888 rdar://121399721 Reviewed by Said Abou-Hallawa. Adjust pixel tolerance. Remove test expectation. * LayoutTests/css3/filters/effect-grayscale.html: * LayoutTests/platform/mac-wk1/TestExpectations: Canonical link: https://commits.webkit.org/273454@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 9bf0e6: REGRESSION ( Sonoma?): [ Sonoma wk1 ] media/track/...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 9bf0e6805bef8e5f85175b639cabee8f4b1d5cd8 https://github.com/WebKit/WebKit/commit/9bf0e6805bef8e5f85175b639cabee8f4b1d5cd8 Author: Karl Rackler Date: 2024-01-24 (Wed, 24 Jan 2024) Changed paths: M LayoutTests/media/track/track-webvtt-no-snap-to-lines-overlap.html Log Message: --- REGRESSION ( Sonoma?): [ Sonoma wk1 ] media/track/track-webvtt-no-snap-to-lines-overlap.html is a consistent image failure https://bugs.webkit.org/show_bug.cgi?id=267892 rdar://121402908 Reviewed by Jer Noble. Add pixel tolerance. * LayoutTests/media/track/track-webvtt-no-snap-to-lines-overlap.html: Canonical link: https://commits.webkit.org/273453@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] f1f5d9: Update Nvidia to all uppper case letters to apply ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: f1f5d970884cc1d26aac2025107010bc17b6b17d https://github.com/WebKit/WebKit/commit/f1f5d970884cc1d26aac2025107010bc17b6b17d Author: Byungseon(Sun) Shin Date: 2024-01-24 (Wed, 24 Jan 2024) Changed paths: M Websites/webkit.org/wp-content/themes/webkit/team.php Log Message: --- Update Nvidia to all uppper case letters to apply official name https://bugs.webkit.org/show_bug.cgi?id=258744 Reviewed by Ryosuke Niwa. * Websites/webkit.org/wp-content/themes/webkit/team.php: Canonical link: https://commits.webkit.org/273452@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] c08057: [ews-build] Force ValidateSquashed to process log
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: c080575b999291a1bb0f69df37768cc458447b7a https://github.com/WebKit/WebKit/commit/c080575b999291a1bb0f69df37768cc458447b7a Author: Jonathan Bedard Date: 2024-01-24 (Wed, 24 Jan 2024) Changed paths: M Tools/CISupport/ews-build/steps.py M Tools/CISupport/ews-build/steps_unittest.py Log Message: --- [ews-build] Force ValidateSquashed to process log https://bugs.webkit.org/show_bug.cgi?id=268033 rdar://121553221 Reviewed by Aakash Jain. This is a follow-up fix to 272863@main, adding a newline to our stdio log in ValidateSquashed forces buildbot to process the line. * Tools/CISupport/ews-build/steps.py: (ValidateSquashed.run): * Tools/CISupport/ews-build/steps_unittest.py: Canonical link: https://commits.webkit.org/273451@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] a519a8: [JSC] parseObjectLiteral() should always create th...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: a519a84a2f962828d3ad7182ef8739badc066161 https://github.com/WebKit/WebKit/commit/a519a84a2f962828d3ad7182ef8739badc066161 Author: Alexey Shvayka Date: 2024-01-24 (Wed, 24 Jan 2024) Changed paths: M Source/JavaScriptCore/parser/Parser.cpp Log Message: --- [JSC] parseObjectLiteral() should always create the node with expression start location https://bugs.webkit.org/show_bug.cgi?id=268036 Reviewed by Justin Michaud. This was the idea of https://bugs.webkit.org/show_bug.cgi?id=267728, yet unfortunately the case of ObjectLiteral containing a comma was missed. * Source/JavaScriptCore/parser/Parser.cpp: (JSC::Parser::parseObjectLiteral): Canonical link: https://commits.webkit.org/273450@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 8a2c5e: Adopt more smart pointers in HistoryController.cpp
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 8a2c5e5a36088bc357bac41acd8def29e3713bc1 https://github.com/WebKit/WebKit/commit/8a2c5e5a36088bc357bac41acd8def29e3713bc1 Author: Chris Dumez Date: 2024-01-24 (Wed, 24 Jan 2024) Changed paths: M Source/WebCore/loader/FrameLoader.cpp M Source/WebCore/loader/FrameLoader.h M Source/WebCore/loader/HistoryController.cpp M Source/WebCore/loader/HistoryController.h Log Message: --- Adopt more smart pointers in HistoryController.cpp https://bugs.webkit.org/show_bug.cgi?id=267977 Reviewed by Darin Adler. * Source/WebCore/loader/FrameLoader.cpp: (WebCore::FrameLoader::detachFromParent): (WebCore::FrameLoader::checkedHistory const): * Source/WebCore/loader/FrameLoader.h: * Source/WebCore/loader/HistoryController.cpp: (WebCore::HistoryController::saveScrollPositionAndViewStateToItem): (WebCore::HistoryController::protectedFrame const): (WebCore::HistoryController::clearScrollPositionAndViewState): (WebCore::HistoryController::restoreScrollPositionAndViewState): (WebCore::HistoryController::saveDocumentState): (WebCore::HistoryController::saveDocumentAndScrollState): (WebCore::HistoryController::restoreDocumentState): (WebCore::HistoryController::invalidateCurrentItemCachedPage): (WebCore::HistoryController::shouldStopLoadingForHistoryItem const): (WebCore::HistoryController::goToItem): (WebCore::HistoryController::setDefersLoading): (WebCore::HistoryController::updateForBackForwardNavigation): (WebCore::HistoryController::updateForReload): (WebCore::HistoryController::updateForStandardLoad): (WebCore::HistoryController::updateForRedirectWithLockedBackForwardList): (WebCore::HistoryController::updateForClientRedirect): (WebCore::HistoryController::updateForCommit): (WebCore::HistoryController::recursiveUpdateForCommit): (WebCore::HistoryController::updateForSameDocumentNavigation): (WebCore::HistoryController::recursiveUpdateForSameDocumentNavigation): (WebCore::HistoryController::setCurrentItem): (WebCore::HistoryController::setCurrentItemTitle): (WebCore::HistoryController::clearPreviousItem): (WebCore::HistoryController::setProvisionalItem): (WebCore::HistoryController::initializeItem): (WebCore::HistoryController::createItem): (WebCore::HistoryController::createItemTree): (WebCore::HistoryController::recursiveSetProvisionalItem): (WebCore::HistoryController::recursiveGoToItem): (WebCore::HistoryController::currentFramesMatchItem const): (WebCore::HistoryController::updateBackForwardListClippedAtTarget): (WebCore::HistoryController::updateCurrentItem): (WebCore::HistoryController::pushState): (WebCore::HistoryController::replaceState): (WebCore::HistoryController::replaceCurrentItem): (WebCore::HistoryController::protectedPreviousItem const): * Source/WebCore/loader/HistoryController.h: Canonical link: https://commits.webkit.org/273449@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 4522d4: ASSERT when calling browser.storageArea.get()
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 4522d41c15c5272d1a47017cd6c5fd1bb1dcf0a8 https://github.com/WebKit/WebKit/commit/4522d41c15c5272d1a47017cd6c5fd1bb1dcf0a8 Author: Kiara Rose Date: 2024-01-24 (Wed, 24 Jan 2024) Changed paths: M Source/WebKit/UIProcess/Extensions/Cocoa/API/WebExtensionContextAPIStorageCocoa.mm M Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionContextCocoa.mm M Source/WebKit/UIProcess/Extensions/WebExtensionContext.h Log Message: --- ASSERT when calling browser.storageArea.get() https://bugs.webkit.org/show_bug.cgi?id=268020 rdar://121538792 Reviewed by Timothy Hatcher. Issues with how ErrorString was being used in WebKit::WebExtensionContext::extensionCanAccessWebPage caused the crash. However, since a failure in this method would indicate a security issue, we should remove this error message and instead add a RELEASE_ASSERT_NOT_REACHED(). The reason why we're hitting this failure currently is because we return false when the tab for the web page is not found. This is an internal bug and is being tracked in https://bugs.webkit.org/show_bug.cgi?id=268030, rdar://121550605. * Source/WebKit/UIProcess/Extensions/Cocoa/API/WebExtensionContextAPIStorageCocoa.mm: (WebKit::WebExtensionContext::storageGet): (WebKit::WebExtensionContext::storageGetBytesInUse): (WebKit::WebExtensionContext::storageSet): (WebKit::WebExtensionContext::storageRemove): (WebKit::WebExtensionContext::storageClear): (WebKit::WebExtensionContext::storageSetAccessLevel): * Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionContextCocoa.mm: (WebKit::WebExtensionContext::extensionCanAccessWebPage): A failure in this function would indicate a security bug as this case should never be hit. Add a RELEASE_ASSERT_NOT_REACHED() for this. * Source/WebKit/UIProcess/Extensions/WebExtensionContext.h: Canonical link: https://commits.webkit.org/273448@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 1c3b20: Adopt more smart pointers under WebCore/css/query
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 1c3b20fe345a6729f1b2569f72b6cf5889a43233 https://github.com/WebKit/WebKit/commit/1c3b20fe345a6729f1b2569f72b6cf5889a43233 Author: Chris Dumez Date: 2024-01-24 (Wed, 24 Jan 2024) Changed paths: M Source/WebCore/css/query/ContainerQueryFeatures.cpp M Source/WebCore/css/query/GenericMediaQueryEvaluator.cpp M Source/WebCore/css/query/GenericMediaQueryParser.cpp M Source/WebCore/css/query/GenericMediaQueryTypes.h M Source/WebCore/css/query/MediaQueryEvaluator.cpp M Source/WebCore/css/query/MediaQueryEvaluator.h M Source/WebCore/css/query/MediaQueryFeatures.cpp M Source/WebCore/page/Frame.cpp M Source/WebCore/page/Frame.h Log Message: --- Adopt more smart pointers under WebCore/css/query https://bugs.webkit.org/show_bug.cgi?id=267966 Reviewed by Darin Adler. * Source/WebCore/css/query/ContainerQueryFeatures.cpp: * Source/WebCore/css/query/GenericMediaQueryEvaluator.cpp: (WebCore::MQ::evaluateLengthComparison): (WebCore::MQ::evaluateNumberComparison): (WebCore::MQ::evaluateIntegerComparison): (WebCore::MQ::evaluateResolutionComparison): (WebCore::MQ::evaluateRatioComparison): (WebCore::MQ::evaluateBooleanFeature): * Source/WebCore/css/query/GenericMediaQueryParser.cpp: (WebCore::MQ::GenericMediaQueryParserBase::consumeBooleanOrPlainFeature): (WebCore::MQ::GenericMediaQueryParserBase::consumeRangeFeature): (WebCore::MQ::consumeRatioWithSlash): (WebCore::MQ::GenericMediaQueryParserBase::consumeValue): (WebCore::MQ::GenericMediaQueryParserBase::validateFeatureAgainstSchema): * Source/WebCore/css/query/GenericMediaQueryTypes.h: * Source/WebCore/css/query/MediaQueryEvaluator.cpp: (WebCore::MQ::MediaQueryEvaluator::MediaQueryEvaluator): (WebCore::MQ::MediaQueryEvaluator::evaluate const): * Source/WebCore/css/query/MediaQueryEvaluator.h: * Source/WebCore/css/query/MediaQueryFeatures.cpp: (WebCore::MQ::Features::deviceScaleFactor): (WebCore::MQ::Features::anyHover): (WebCore::MQ::Features::anyPointer): (WebCore::MQ::Features::aspectRatio): (WebCore::MQ::Features::color): (WebCore::MQ::Features::colorGamut): (WebCore::MQ::Features::deviceAspectRatio): (WebCore::MQ::Features::deviceHeight): (WebCore::MQ::Features::deviceWidth): (WebCore::MQ::Features::dynamicRange): (WebCore::MQ::Features::height): (WebCore::MQ::Features::hover): (WebCore::MQ::Features::invertedColors): (WebCore::MQ::Features::monochrome): (WebCore::MQ::Features::orientation): (WebCore::MQ::Features::pointer): (WebCore::MQ::Features::prefersContrast): (WebCore::MQ::Features::prefersDarkInterface): (WebCore::MQ::Features::prefersReducedMotion): (WebCore::MQ::Features::scripting): (WebCore::MQ::Features::transform3d): (WebCore::MQ::Features::update): (WebCore::MQ::Features::videoPlayableInline): (WebCore::MQ::Features::width): (WebCore::MQ::Features::displayMode): (WebCore::MQ::Features::overflowBlock): (WebCore::MQ::Features::prefersColorScheme): * Source/WebCore/page/Frame.cpp: (WebCore::Frame::protectedVirtualView const): * Source/WebCore/page/Frame.h: Canonical link: https://commits.webkit.org/273447@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] f009f9: [Gardening]: REGRESSION (273187@main): [ iOS17 Deb...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: f009f9f8c8db31b408f52074f0ddd7f180fc371f https://github.com/WebKit/WebKit/commit/f009f9f8c8db31b408f52074f0ddd7f180fc371f Author: Marta Darbinyan Date: 2024-01-24 (Wed, 24 Jan 2024) Changed paths: M LayoutTests/platform/ios-wk2/TestExpectations Log Message: --- [Gardening]: REGRESSION (273187@main): [ iOS17 Debug arm64 ] ASSERTION FAILED:bool WTF::RefCountedBase::hasOneRef() in http/tests/workers/service/postmessage-after-terminate.https.html result of a flaky crash https://bugs.webkit.org/show_bug.cgi?id=268029 rdar://121550392 Unreviewed test gardening. Adding test expectation * LayoutTests/platform/ios-wk2/TestExpectations: Canonical link: https://commits.webkit.org/273446@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 840e8f: Port JavaScriptCore/parser enums to new serializat...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 840e8f70706ef6076a82934d37857c04ff0b4b09 https://github.com/WebKit/WebKit/commit/840e8f70706ef6076a82934d37857c04ff0b4b09 Author: Mikhail R. Gadelha Date: 2024-01-24 (Wed, 24 Jan 2024) Changed paths: M Source/JavaScriptCore/parser/SourceProvider.h M Source/WebKit/Shared/JavaScriptCore.serialization.in Log Message: --- Port JavaScriptCore/parser enums to new serialization format https://bugs.webkit.org/show_bug.cgi?id=268002 Reviewed by Alex Christensen. Port JavaScriptCore/parser enums to new serialization format * Source/JavaScriptCore/parser/SourceProvider.h: * Source/WebKit/Shared/JavaScriptCore.serialization.in: Canonical link: https://commits.webkit.org/273445@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] e819c4: All extensions are being granted the tabs permissi...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: e819c4ec9e878eacac535573df5a24e18e821236 https://github.com/WebKit/WebKit/commit/e819c4ec9e878eacac535573df5a24e18e821236 Author: Timothy Hatcher Date: 2024-01-24 (Wed, 24 Jan 2024) Changed paths: M Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionContextCocoa.mm M Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionAPITabs.mm Log Message: --- All extensions are being granted the tabs permission on user gesture. https://webkit.org/b/267952 rdar://problem/121469546 Reviewed by Brian Weinstein. * Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionContextCocoa.mm: (WebKit::WebExtensionContext::permissionState): Add missing activeTab permission check. * Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionAPITabs.mm: (TestWebKitAPI::TEST): Added new test. Canonical link: https://commits.webkit.org/273444@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] fe72ea: [iOS] Occasional crash under -_updatePanGestureToP...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: fe72eacc753b1a8d16a71bdb61883bd58cd8 https://github.com/WebKit/WebKit/commit/fe72eacc753b1a8d16a71bdb61883bd58cd8 Author: Wenson Hsieh Date: 2024-01-24 (Wed, 24 Jan 2024) Changed paths: M Source/WebKit/UIProcess/ios/WKBaseScrollView.mm Log Message: --- [iOS] Occasional crash under -_updatePanGestureToPreventScrolling when resetting state after process termination https://bugs.webkit.org/show_bug.cgi?id=268011 rdar://121329521 Reviewed by Simon Fraser. This is a speculative fix for crashes in `-[WKBaseScrollView _updatePanGestureToPreventScrolling]` while resetting UI-side state under `WebPageProxy::resetStateAfterProcessTermination`. From the crashing stack, this appears to be triggered because: 1. The overflow scroller is being removed from the view hierarchy. 2. UIKit invokes gesture actions one final time, which (after the changes in 271171@main) calls out to the `ScrollingTreeScrollingNodeDelegateIOS` to ask for active touch actions for the pan gesture. 3. The scrolling tree node is already invalid at this point, the `RemoteScrollingTree` downcast fails and we crash. Try to mitigate this by not calling into delegate for locked scrolling axes in the case where we're either not in the view hierarchy, or we're in the middle of being removed from the view hierarchy. * Source/WebKit/UIProcess/ios/WKBaseScrollView.mm: (-[WKBaseScrollView removeFromSuperview]): (-[WKBaseScrollView _axesToPreventScrollingFromDelegate]): Canonical link: https://commits.webkit.org/273443@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 9fe594: [Gardening]: [ Sonoma wk2 Release] fast/images/tex...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 9fe5942355c2f15631781ab81bbb9a054c8c https://github.com/WebKit/WebKit/commit/9fe5942355c2f15631781ab81bbb9a054c8c Author: Jay saintfleur Date: 2024-01-24 (Wed, 24 Jan 2024) Changed paths: M LayoutTests/platform/mac-wk2/TestExpectations Log Message: --- [Gardening]: [ Sonoma wk2 Release] fast/images/text-recognition/mac/select-word-in-transparent-image-overlay.html is a flaky image failure https://bugs.webkit.org/show_bug.cgi?id=268018 rdar://problem/121537972 Unreviewed test gardening. Adding test expectation * LayoutTests/platform/mac-wk2/TestExpectations: Canonical link: https://commits.webkit.org/273442@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 60e468: Adopt more smart pointers in Font.cpp
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 60e46879c5aa638979e0cdd5cfb97fcb958a492e https://github.com/WebKit/WebKit/commit/60e46879c5aa638979e0cdd5cfb97fcb958a492e Author: Chris Dumez Date: 2024-01-24 (Wed, 24 Jan 2024) Changed paths: M Source/WebCore/platform/graphics/Font.cpp Log Message: --- Adopt more smart pointers in Font.cpp https://bugs.webkit.org/show_bug.cgi?id=268007 Reviewed by Darin Adler. * Source/WebCore/platform/graphics/Font.cpp: (WebCore::Font::initCharWidths): (WebCore::Font::platformGlyphInit): (WebCore::createAndFillGlyphPage): (WebCore::Font::glyphForCharacter const): (WebCore::Font::glyphDataForCharacter const): (WebCore::Font::mathData const): Canonical link: https://commits.webkit.org/273441@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 27567f: [JSC] parseMemberExpression() should create NewExp...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 27567fb2a9f316d9bc6a1b75d2b94b02731756c6 https://github.com/WebKit/WebKit/commit/27567fb2a9f316d9bc6a1b75d2b94b02731756c6 Author: Alexey Shvayka Date: 2024-01-24 (Wed, 24 Jan 2024) Changed paths: M Source/JavaScriptCore/parser/Parser.cpp Log Message: --- [JSC] parseMemberExpression() should create NewExpr with expression start location https://bugs.webkit.org/show_bug.cgi?id=268022 Reviewed by Yusuke Suzuki and Justin Michaud. This was the idea of https://bugs.webkit.org/show_bug.cgi?id=267728, yet unfortunately in-between implementation revisions the case of correct location for `new new new C` did regress. * Source/JavaScriptCore/parser/Parser.cpp: (JSC::Parser::parseMemberExpression): Canonical link: https://commits.webkit.org/273440@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] fb1c6b: Adopt more smart pointers in FontCascade.cpp
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: fb1c6b29a3a4d6ad23aadf78dd5626651621cb31 https://github.com/WebKit/WebKit/commit/fb1c6b29a3a4d6ad23aadf78dd5626651621cb31 Author: Chris Dumez Date: 2024-01-24 (Wed, 24 Jan 2024) Changed paths: M Source/WebCore/platform/graphics/FontCascade.cpp M Source/WebCore/platform/graphics/FontCascade.h Log Message: --- Adopt more smart pointers in FontCascade.cpp https://bugs.webkit.org/show_bug.cgi?id=268008 Reviewed by Brent Fulgham. * Source/WebCore/platform/graphics/FontCascade.cpp: (WebCore::FontCascade::width const): (WebCore::FontCascade::widthForSimpleText const): (WebCore::FontCascade::widthForSimpleTextWithFixedPitch const): (WebCore::FontCascade::glyphDataForCharacter const): (WebCore::FontCascade::isLoadingCustomFonts const): (WebCore::FontCascade::emphasisMarkHeight const): (WebCore::FontCascade::floatEmphasisMarkHeight const): (WebCore::FontCascade::drawGlyphBuffer const): (WebCore::GlyphToPathTranslator::GlyphToPathTranslator): (WebCore::GlyphToPathTranslator::containsMorePaths): (WebCore::GlyphToPathTranslator::path): (WebCore::GlyphToPathTranslator::extents): (WebCore::GlyphToPathTranslator::advance): (WebCore::FontCascade::protectedFonts const): * Source/WebCore/platform/graphics/FontCascade.h: (WebCore::FontCascade::primaryFont const): (WebCore::FontCascade::fallbackRangesAt const): (WebCore::FontCascade::isFixedPitch const): (WebCore::FontCascade::canTakeFixedPitchFastContentMeasuring const): (WebCore::FontCascade::fontSelector const): Canonical link: https://commits.webkit.org/273439@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 1d5e98: Only run webRequest tests on macOS that allow pers...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 1d5e9822affd75ce7440bf15a7f9917613cd9718 https://github.com/WebKit/WebKit/commit/1d5e9822affd75ce7440bf15a7f9917613cd9718 Author: Brian Weinstein Date: 2024-01-24 (Wed, 24 Jan 2024) Changed paths: M Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionAPIWebRequest.mm Log Message: --- Only run webRequest tests on macOS that allow persistent background pages https://bugs.webkit.org/show_bug.cgi?id=268012 Reviewed by Timothy Hatcher. The filter tests are still run on every platform, but the tests that involve the webRequest JavaScript API are only run on Mac, since that is the only platform that supports persistent background pages (and therefore webRequest). * Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionAPIWebRequest.mm: Canonical link: https://commits.webkit.org/273438@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] e5df40: Factor inline stylesheet cache into a class
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: e5df4028963eb94d06adc84eb4ec3999de4f502e https://github.com/WebKit/WebKit/commit/e5df4028963eb94d06adc84eb4ec3999de4f502e Author: Antti Koivisto Date: 2024-01-24 (Wed, 24 Jan 2024) Changed paths: M Source/WebCore/Sources.txt M Source/WebCore/WebCore.xcodeproj/project.pbxproj M Source/WebCore/css/CSSStyleSheet.cpp M Source/WebCore/css/CSSStyleSheet.h M Source/WebCore/css/StyleSheetContents.h M Source/WebCore/dom/InlineStyleSheetOwner.cpp M Source/WebCore/dom/InlineStyleSheetOwner.h M Source/WebCore/page/MemoryRelease.cpp A Source/WebCore/style/StyleSheetContentsCache.cpp A Source/WebCore/style/StyleSheetContentsCache.h Log Message: --- Factor inline stylesheet cache into a class https://bugs.webkit.org/show_bug.cgi?id=267996 rdar://problem/121514266 Reviewed by Ryosuke Niwa. Add StyleSheetContentsCache and use it. * Source/WebCore/Sources.txt: * Source/WebCore/WebCore.xcodeproj/project.pbxproj: * Source/WebCore/css/CSSStyleSheet.cpp: (WebCore::CSSStyleSheet::CSSStyleSheet): (WebCore::CSSStyleSheet::replaceSync): * Source/WebCore/css/StyleSheetContents.h: * Source/WebCore/dom/InlineStyleSheetOwner.cpp: (WebCore::makeStyleSheetContentsCacheKey): (WebCore::InlineStyleSheetOwner::createSheet): (WebCore::inlineStyleSheetCache): Deleted. (WebCore::makeInlineStyleSheetCacheKey): Deleted. (WebCore::InlineStyleSheetOwner::clearCache): Deleted. * Source/WebCore/dom/InlineStyleSheetOwner.h: * Source/WebCore/page/MemoryRelease.cpp: (WebCore::releaseNoncriticalMemory): * Source/WebCore/style/StyleSheetContentsCache.cpp: Added. (WebCore::Style::StyleSheetContentsCache::singleton): (WebCore::Style::StyleSheetContentsCache::get): (WebCore::Style::StyleSheetContentsCache::add): (WebCore::Style::StyleSheetContentsCache::clear): * Source/WebCore/style/StyleSheetContentsCache.h: Added. Canonical link: https://commits.webkit.org/273437@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 65fb3e: [WebGPU] api, validation, queue, * is failing
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 65fb3ec0feaee6c99d6dbcf47914b54c69f640ae https://github.com/WebKit/WebKit/commit/65fb3ec0feaee6c99d6dbcf47914b54c69f640ae Author: Mike Wyrzykowski Date: 2024-01-24 (Wed, 24 Jan 2024) Changed paths: M LayoutTests/http/tests/webgpu/webgpu/api/validation/queue/buffer_mapped-expected.txt M LayoutTests/http/tests/webgpu/webgpu/api/validation/queue/buffer_mapped.spec.js M LayoutTests/http/tests/webgpu/webgpu/api/validation/queue/copyToTexture/CopyExternalImageToTexture-expected.txt M LayoutTests/http/tests/webgpu/webgpu/api/validation/queue/copyToTexture/CopyExternalImageToTexture.spec.js A LayoutTests/http/tests/webgpu/webgpu/api/validation/queue/destroyed/buffer-expected.txt M LayoutTests/http/tests/webgpu/webgpu/api/validation/queue/destroyed/buffer.spec.js M LayoutTests/http/tests/webgpu/webgpu/api/validation/queue/destroyed/query_set-expected.txt M LayoutTests/http/tests/webgpu/webgpu/api/validation/queue/destroyed/query_set.spec.js A LayoutTests/http/tests/webgpu/webgpu/api/validation/queue/destroyed/texture-expected.txt M LayoutTests/http/tests/webgpu/webgpu/api/validation/queue/destroyed/texture.spec.js M LayoutTests/http/tests/webgpu/webgpu/api/validation/queue/submit.spec.js M LayoutTests/http/tests/webgpu/webgpu/api/validation/queue/writeBuffer.spec.js M LayoutTests/http/tests/webgpu/webgpu/api/validation/queue/writeTexture-expected.txt M LayoutTests/http/tests/webgpu/webgpu/api/validation/queue/writeTexture.spec.js M Source/WebCore/Modules/WebGPU/GPUQueue.cpp M Source/WebCore/Modules/WebGPU/GPUQueue.h M Source/WebCore/Modules/WebGPU/GPUQueue.idl M Source/WebCore/html/OffscreenCanvas.h M Source/WebGPU/WebGPU/BindGroup.mm M Source/WebGPU/WebGPU/BindableResource.h M Source/WebGPU/WebGPU/Buffer.h M Source/WebGPU/WebGPU/Buffer.mm M Source/WebGPU/WebGPU/CommandBuffer.h M Source/WebGPU/WebGPU/CommandBuffer.mm M Source/WebGPU/WebGPU/CommandEncoder.h M Source/WebGPU/WebGPU/CommandEncoder.mm M Source/WebGPU/WebGPU/ComputePassEncoder.mm M Source/WebGPU/WebGPU/ExternalTexture.h M Source/WebGPU/WebGPU/QuerySet.h M Source/WebGPU/WebGPU/QuerySet.mm M Source/WebGPU/WebGPU/Queue.mm M Source/WebGPU/WebGPU/RenderBundle.h M Source/WebGPU/WebGPU/RenderBundle.mm M Source/WebGPU/WebGPU/RenderBundleEncoder.h M Source/WebGPU/WebGPU/RenderBundleEncoder.mm M Source/WebGPU/WebGPU/RenderPassEncoder.h M Source/WebGPU/WebGPU/RenderPassEncoder.mm M Source/WebGPU/WebGPU/Texture.h M Source/WebGPU/WebGPU/Texture.mm M Source/WebGPU/WebGPU/TextureView.h M Source/WebGPU/WebGPU/TextureView.mm Log Message: --- [WebGPU] api,validation,queue,* is failing https://bugs.webkit.org/show_bug.cgi?id=267279 Reviewed by Tadeu Zagallo. Add validation for GPUQueue and related operations along with passing exepctations. * LayoutTests/http/tests/webgpu/webgpu/api/validation/queue/buffer_mapped-expected.txt: * LayoutTests/http/tests/webgpu/webgpu/api/validation/queue/buffer_mapped.spec.js: * LayoutTests/http/tests/webgpu/webgpu/api/validation/queue/copyToTexture/CopyExternalImageToTexture-expected.txt: * LayoutTests/http/tests/webgpu/webgpu/api/validation/queue/copyToTexture/CopyExternalImageToTexture.spec.js: * LayoutTests/http/tests/webgpu/webgpu/api/validation/queue/destroyed/buffer-expected.txt: Added. * LayoutTests/http/tests/webgpu/webgpu/api/validation/queue/destroyed/buffer.spec.js: * LayoutTests/http/tests/webgpu/webgpu/api/validation/queue/destroyed/query_set-expected.txt: * LayoutTests/http/tests/webgpu/webgpu/api/validation/queue/destroyed/query_set.spec.js: * LayoutTests/http/tests/webgpu/webgpu/api/validation/queue/destroyed/texture-expected.txt: Added. * LayoutTests/http/tests/webgpu/webgpu/api/validation/queue/destroyed/texture.spec.js: * LayoutTests/http/tests/webgpu/webgpu/api/validation/queue/submit.spec.js: * LayoutTests/http/tests/webgpu/webgpu/api/validation/queue/writeBuffer.spec.js: * LayoutTests/http/tests/webgpu/webgpu/api/validation/queue/writeTexture-expected.txt: * LayoutTests/http/tests/webgpu/webgpu/api/validation/queue/writeTexture.spec.js: Add passing expectations and update tests to latest revision of the CTS. * Source/WebCore/Modules/WebGPU/GPUQueue.cpp: (WebCore::isOriginClean): (WebCore::dimension): (WebCore::isStateValid): (WebCore::convertRGBAToRGB10A2): (WebCore::copyToDestinationFormat): (WebCore::GPUQueue::copyExternalImageToTexture): Fix reporting errors when a cross origin asset is used. * Source/WebCore/Modules/WebGPU/GPUQueue.h: * Source/WebCore/Modules/WebGPU/GPUQueue.idl: * Source/WebCore/html/OffscreenCanvas.h: * Source/WebGPU/WGSL/AttributeValidator.cpp: (WGSL::AttributeValidator::visit): (WGSL::AttributeValidator::parseLocation): * Source/WebGPU/WebGPU/BindGroup.mm:
[webkit-changes] [WebKit/WebKit] a4903b: Add -Wno-elaborated-enum-base to WARNING_FLAGS whe...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: a4903bd869a66081c14a3d7b160bcce4868a0d85 https://github.com/WebKit/WebKit/commit/a4903bd869a66081c14a3d7b160bcce4868a0d85 Author: David Kilzer Date: 2024-01-24 (Wed, 24 Jan 2024) Changed paths: M Configurations/CommonBase.xcconfig M Configurations/Sanitizers.xcconfig Log Message: --- Add -Wno-elaborated-enum-base to WARNING_FLAGS when building with clang static analyzer https://bugs.webkit.org/show_bug.cgi?id=267973 Reviewed by Elliott Williams. * Configurations/CommonBase.xcconfig: (WARNING_CFLAGS): - Add $(WK_SANITIZER_WARNING_CFLAGS) to the list of values. * Configurations/Sanitizers.xcconfig: (WK_SANITIZER_WARNING_CFLAGS): Add. (WK_STATIC_ANALYZER_WARNING_CFLAGS_YES): Add. - Include -Wno-elaborated-enum-base during build-and-analyze. Canonical link: https://commits.webkit.org/273435@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 277c42: [VisionOS] Twitter.com videos do not play
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 277c42bdaccc434bff6fac4e45f23b7f31ca371b https://github.com/WebKit/WebKit/commit/277c42bdaccc434bff6fac4e45f23b7f31ca371b Author: Jer Noble Date: 2024-01-24 (Wed, 24 Jan 2024) Changed paths: M Source/WebCore/Modules/remoteplayback/HTMLMediaElement+RemotePlayback.idl Log Message: --- [VisionOS] Twitter.com videos do not play https://bugs.webkit.org/show_bug.cgi?id=267938 rdar://121391975 Reviewed by Tim Horton. Twitter.com has adopted ManagedMediaSource, and disables airplay via HTMLMediaElement.disableRemotePlayback. On other platforms, this allows MMS to move to the "open" state, due to the managedMediaSourceNeedsAirPlay setting. However, on VisionOS, the RemotePlaybackEnabled setting is off, so the disableRemotePlayback property is not reflected into an attribute on the HTMLMediaElement, and the check for isWirelessPlaybackTargetDisabled() fails. Selectively move portions of EnabledBySetting=RemotePlaybackEnabled from the HTMLMediaElement+RemotePlayback.idl file sufficient for disableRemotePlayback to be reflected, and to allow ManagedMediaSource to check for its presence. * Source/WebCore/Modules/remoteplayback/HTMLMediaElement+RemotePlayback.idl: Canonical link: https://commits.webkit.org/273434@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 4d861f: [CoreIPC] heap-use-after-free in WebCore::MockMedi...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 4d861ff045d4ce0cc26414854fbb422b0299960f https://github.com/WebKit/WebKit/commit/4d861ff045d4ce0cc26414854fbb422b0299960f Author: Nicole Rosario Date: 2024-01-24 (Wed, 24 Jan 2024) Changed paths: M LayoutTests/TestExpectations A LayoutTests/ipc/argumentParser.js A LayoutTests/ipc/fuzz_tools.js A LayoutTests/ipc/media-player-invalid-test-expected.txt A LayoutTests/ipc/media-player-invalid-test.html M Source/WebCore/platform/mock/mediasource/MockMediaSourcePrivate.cpp M Source/WebCore/platform/mock/mediasource/MockMediaSourcePrivate.h Log Message: --- [CoreIPC] heap-use-after-free in WebCore::MockMediaSourcePrivate::markEndOfStream rdar://115982856 Reviewed by Jean-Yves Avenard and Eric Carlson. Error only hit in internal testing. Object was referenced after deletion. Updated `MockMediaPlayer` to use weak pointer for `m_player` instead of reference and added checks to methods to check that `m_player` exists before trying to read/write * Source/WebCore/platform/mock/mediasource/MockMediaSourcePrivate.cpp: added check that `m_player` exists before accessing * Source/WebCore/platform/mock/mediasource/MockMediaSourcePrivate.h: changed `m_player` to weak pointer instead of a reference * Source/WebCore/platform/mock/mediasource/MockSourceBufferPrivate.cpp: (WebCore::MockSourceBufferPrivate::readyState const): (WebCore::MockSourceBufferPrivate::setReadyState): Originally-landed-as: 267815.570@safari-7617-branch (fc6f62059d44). rdar://121481507 Canonical link: https://commits.webkit.org/273428@main Commit: 622f92afdb426af016db98987bbe36b87c9098f5 https://github.com/WebKit/WebKit/commit/622f92afdb426af016db98987bbe36b87c9098f5 Author: Nicole Rosario Date: 2024-01-24 (Wed, 24 Jan 2024) Changed paths: M LayoutTests/TestExpectations A LayoutTests/fast/rendering/render-list-marker-select-expected.txt A LayoutTests/fast/rendering/render-list-marker-select.html M Source/WebCore/rendering/updating/RenderTreeBuilderList.cpp Log Message: --- jsc_fuz/wktr: null ptr deref in WebCore::RenderMenuList::computeIntrinsicLogicalWidths https://bugs.webkit.org/show_bug.cgi?id=264830 rdar://115721454 Reviewed by Alan Baradlay. Null pointer dereference error caused by render tree being ordered incorrectly. RenderListMarker was being placed inside RenderMenuList, where RenderListMarker and RenderMenuList should be on the same level and in RenderListItem * LayoutTests/fast/rendering/render-list-marker-select-expected.txt: * LayoutTests/fast/rendering/render-list-marker-select.html: * Source/WebCore/rendering/updating/RenderTreeBuilderList.cpp: (WebCore::getParentOfFirstLineBox): added check to ensure RenderListMarker isn't placed inside RenderMenuList but can be placed at same level (ie, sibling) Originally-landed-as: 267815.595@safari-7617-branch (2a1f2e7acfe2). rdar://121481232 Canonical link: https://commits.webkit.org/273429@main Commit: 15774fae27ec36386eddb171418ddcfe1c488c08 https://github.com/WebKit/WebKit/commit/15774fae27ec36386eddb171418ddcfe1c488c08 Author: David Kilzer Date: 2024-01-24 (Wed, 24 Jan 2024) Changed paths: M Source/ThirdParty/libwebrtc/Source/webrtc/modules/rtp_rtcp/source/rtp_format_vp9.cc A Source/ThirdParty/libwebrtc/WebKit/01-WebRTC-Stack-buffer-overflow-in-webrtc-anonymous_namespace-SsDataLength.patch Log Message: --- [WebRTC] Stack-buffer-overflow in webrtc::anonymous_namespace::SsDataLength() in vp9 packetizer https://bugs.webkit.org/show_bug.cgi?id=265727 Reviewed by Youenn Fablet. * Source/ThirdParty/libwebrtc/Source/webrtc/modules/rtp_rtcp/source/rtp_format_vp9.cc: (webrtc::anonymous_namespace::SsDataLength): - Change debug assertion into runtime check. * Source/ThirdParty/libwebrtc/WebKit/01-WebRTC-Stack-buffer-overflow-in-webrtc-anonymous_namespace-SsDataLength.patch: Add. Originally-landed-as: 267815.606@safari-7617-branch (f2ba7a5d0dd0). rdar://121481147 Canonical link: https://commits.webkit.org/273430@main Commit: bb644de42b02991f8e878e917b2df008a9a17a3e https://github.com/WebKit/WebKit/commit/bb644de42b02991f8e878e917b2df008a9a17a3e Author: David Kilzer Date: 2024-01-24 (Wed, 24 Jan 2024) Changed paths: M Source/ThirdParty/libwebrtc/Source/webrtc/modules/rtp_rtcp/source/rtp_format_vp9.cc A Source/ThirdParty/libwebrtc/WebKit/0001-WebRTC-Out-of-bounds-crash-in-webrtc-anonymous_namespace-RemoveInactiveSpatialLayers.patch Log Message: --- [WebRTC] Out-of-bounds crash in webrtc::anonymous_namespace::RemoveInactiveSpatialLayers() in vp9 packetizer https://bugs.webkit.org/show_bug.cgi?id=265776 Reviewed by Youenn Fablet. * Source/ThirdParty/libwebrtc/Source/webrtc/modules/rtp_rtcp/source/rtp_format_vp9.cc: (webrtc::anonymous_namespace::RemoveInactiveSpatialLayers): - Add sanity check for
[webkit-changes] [WebKit/WebKit] f3f809: Hold a process throttler activity while serializin...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: f3f8098013c24e7a154b6b44b3e5de4c7f5768eb https://github.com/WebKit/WebKit/commit/f3f8098013c24e7a154b6b44b3e5de4c7f5768eb Author: Wenson Hsieh Date: 2024-01-24 (Wed, 24 Jan 2024) Changed paths: M Source/WebKit/UIProcess/API/Cocoa/NSAttributedString.mm Log Message: --- Hold a process throttler activity while serializing attributed strings from HTML or web archive data https://bugs.webkit.org/show_bug.cgi?id=267985 rdar://118957708 Reviewed by Chris Dumez. Maintain a `ProcessThrottler::Activity` over the entire course of an attributed string serialization operation; this is necessary to ensure that we run at foreground priority, even when using offscreen `WKWebView`s to load and serialize `NSAttributedString` data. * Source/WebKit/UIProcess/API/Cocoa/NSAttributedString.mm: (+[NSAttributedString _loadFromHTMLWithOptions:contentLoader:completionHandler:]): Canonical link: https://commits.webkit.org/273427@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] ea3d99: Adopt more smart pointers in SubresourceLoader.cpp
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: ea3d99fe95daaa9b05825b685a41e86e866c69f5 https://github.com/WebKit/WebKit/commit/ea3d99fe95daaa9b05825b685a41e86e866c69f5 Author: Chris Dumez Date: 2024-01-24 (Wed, 24 Jan 2024) Changed paths: M Source/WebCore/loader/DocumentLoader.cpp M Source/WebCore/loader/DocumentLoader.h M Source/WebCore/loader/ResourceLoader.cpp M Source/WebCore/loader/ResourceLoader.h M Source/WebCore/loader/SubresourceLoader.cpp M Source/WebCore/loader/SubresourceLoader.h Log Message: --- Adopt more smart pointers in SubresourceLoader.cpp https://bugs.webkit.org/show_bug.cgi?id=267982 Reviewed by Darin Adler. * Source/WebCore/loader/DocumentLoader.cpp: (WebCore::DocumentLoader::protectedCachedResourceLoader const): * Source/WebCore/loader/DocumentLoader.h: * Source/WebCore/loader/ResourceLoader.cpp: (WebCore::ResourceLoader::protectedResourceData const): (WebCore::ResourceLoader::protectedFrame const): * Source/WebCore/loader/ResourceLoader.h: (WebCore::ResourceLoader::frame const): * Source/WebCore/loader/SubresourceLoader.cpp: (WebCore::SubresourceLoader::RequestCountTracker::RequestCountTracker): (WebCore::SubresourceLoader::RequestCountTracker::~RequestCountTracker): (WebCore::SubresourceLoader::SubresourceLoader): (WebCore::SubresourceLoader::create): (WebCore::SubresourceLoader::willSendRequestInternal): (WebCore::SubresourceLoader::didSendData): (WebCore::SubresourceLoader::didReceiveResponse): (WebCore::SubresourceLoader::didReceiveBuffer): (WebCore::logResourceLoaded): (WebCore::SubresourceLoader::checkResponseCrossOriginAccessControl): (WebCore::SubresourceLoader::protectedOrigin const): (WebCore::SubresourceLoader::checkRedirectionCrossOriginAccessControl): (WebCore::SubresourceLoader::didFinishLoading): (WebCore::SubresourceLoader::didFail): (WebCore::SubresourceLoader::willCancel): (WebCore::SubresourceLoader::notifyDone): (WebCore::SubresourceLoader::reportResourceTiming): * Source/WebCore/loader/SubresourceLoader.h: Canonical link: https://commits.webkit.org/273426@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 75d9af: Adopt more smart pointers in SubframeLoader.cpp
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 75d9af099b45c8a24199497f5a7ec24fccc11721 https://github.com/WebKit/WebKit/commit/75d9af099b45c8a24199497f5a7ec24fccc11721 Author: Chris Dumez Date: 2024-01-24 (Wed, 24 Jan 2024) Changed paths: M Source/WebCore/loader/SubframeLoader.cpp M Source/WebCore/loader/SubframeLoader.h Log Message: --- Adopt more smart pointers in SubframeLoader.cpp https://bugs.webkit.org/show_bug.cgi?id=267980 Reviewed by Darin Adler. * Source/WebCore/loader/SubframeLoader.cpp: (WebCore::FrameLoader::SubframeLoader::protectedFrame const): (WebCore::FrameLoader::SubframeLoader::createFrameIfNecessary): (WebCore::FrameLoader::SubframeLoader::pluginIsLoadable): (WebCore::FrameLoader::SubframeLoader::requestPlugin): (WebCore::FrameLoader::SubframeLoader::loadOrRedirectSubframe): (WebCore::FrameLoader::SubframeLoader::loadSubframe): (WebCore::FrameLoader::SubframeLoader::shouldUsePlugin): (WebCore::FrameLoader::SubframeLoader::loadPlugin): (WebCore::FrameLoader::SubframeLoader::completeURL const): (WebCore::FrameLoader::SubframeLoader::shouldConvertInvalidURLsToBlank const): * Source/WebCore/loader/SubframeLoader.h: Canonical link: https://commits.webkit.org/273425@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] b46a8f: Use-after-free in processResponse in ServiceWorker...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: b46a8fcd809a9c84aa92538e942e1fa0c789ed27 https://github.com/WebKit/WebKit/commit/b46a8fcd809a9c84aa92538e942e1fa0c789ed27 Author: Youenn Fablet Date: 2024-01-24 (Wed, 24 Jan 2024) Changed paths: M Source/WebCore/workers/service/context/ServiceWorkerFetch.cpp Log Message: --- Use-after-free in processResponse in ServiceWorkerFetch.cpp rdar://118039950 Reviewed by Chris Dumez. Cancelling the stream can trigger GC when creating the DOMException JS wrapper. This might collect the FetchResponse object. To make sure the FetchResponse object stays live for the whole time, we protect it in the callback. * Source/WebCore/workers/service/context/ServiceWorkerFetch.cpp: (WebCore::ServiceWorkerFetch::processResponse): Originally-landed-as: 267815.569@safari-7617-branch (5ebdf97c0a26). rdar://121481543 Canonical link: https://commits.webkit.org/273420@main Commit: dc6de2647a918167eeaf607fb54ca0f651b32979 https://github.com/WebKit/WebKit/commit/dc6de2647a918167eeaf607fb54ca0f651b32979 Author: Claudio Saavedra Date: 2024-01-24 (Wed, 24 Jan 2024) Changed paths: A LayoutTests/fast/parser/parser-insertion-after-shadow-reparenting-expected.txt A LayoutTests/fast/parser/parser-insertion-after-shadow-reparenting.html M Source/WebCore/dom/ContainerNode.cpp Log Message: --- DOM: Make sure to set tree scope during parser insertion https://bugs.webkit.org/show_bug.cgi?id=263178 rdar://116715621 Reviewed by Ryosuke Niwa. It is possible for an element to be reparented, pg., to a shadow tree before parsing has finished, so we need to make sure to set the correct tree scope for a new element during parsing insertion, otherwise it might end up associated to the wrong tree scope. * LayoutTests/fast/parser/parser-insertion-after-shadow-reparenting-expected.txt: Added. * LayoutTests/fast/parser/parser-insertion-after-shadow-reparenting.html: Added. * Source/WebCore/dom/ContainerNode.cpp: (WebCore::ContainerNode::parserInsertBefore): Originally-landed-as: 268451.4@webkit-2023.9-embargoed (f554230ef55f). rdar://121481452 Canonical link: https://commits.webkit.org/273421@main Commit: 0023fa29b365fd4f1f7c79ff3bd84786e96a1ea9 https://github.com/WebKit/WebKit/commit/0023fa29b365fd4f1f7c79ff3bd84786e96a1ea9 Author: Kimmo Kinnunen Date: 2024-01-24 (Wed, 24 Jan 2024) Changed paths: M Source/WebCore/platform/graphics/cocoa/GraphicsContextGLCocoa.mm Log Message: --- GraphicsContextGLCocoa::setDrawingBufferColorSpace is missing makeContextCurrent() https://bugs.webkit.org/show_bug.cgi?id=265129 rdar://118650182 Reviewed by Dan Glastonbury. All public API entrypoints in GraphicsContextGLANGLE should call the makeContextCurrent(). * Source/WebCore/platform/graphics/cocoa/GraphicsContextGLCocoa.mm: (WebCore::GraphicsContextGLCocoa::setDrawingBufferColorSpace): Originally-landed-as: 267815.586@safari-7617-branch (e408ece1b8a7). rdar://121481426 Canonical link: https://commits.webkit.org/273422@main Commit: f0b62299b0c73fae19a498524298a672479afdf9 https://github.com/WebKit/WebKit/commit/f0b62299b0c73fae19a498524298a672479afdf9 Author: Kimmo Kinnunen Date: 2024-01-24 (Wed, 24 Jan 2024) Changed paths: M Source/ThirdParty/ANGLE/src/libANGLE/Surface.cpp M Source/ThirdParty/ANGLE/src/libANGLE/Texture.cpp M Source/ThirdParty/ANGLE/src/tests/gl_tests/PbufferTest.cpp Log Message: --- ANGLE eglBindTexImage ASSERT when overwriting a binding https://bugs.webkit.org/show_bug.cgi?id=265127 rdar://118649807 Reviewed by Dan Glastonbury. glBindTexture(GL_TEXTURE_2D, tex); eglBindTexImage(.., pbuffer, ...); - Would set the Surface::mBoundTexture of pbuffer - Would set the Texture::mBoundSurface of tex eglBindTexImage(.., pbuffer2, ...); - Would set the Surface::mBoundTexture of pbuffer2 - Would set the Texture::mBoundSurface of tex - Would fail to unset Surface::mBoundTexture of pbuffer Fix by making the unset logic linear, avoiding Surface -> Texture -> Surface call sequence. * Source/ThirdParty/ANGLE/src/libANGLE/Surface.cpp: (egl::Surface::bindTexImage): * Source/ThirdParty/ANGLE/src/libANGLE/Texture.cpp: (gl::Texture::bindTexImageFromSurface): * Source/ThirdParty/ANGLE/src/tests/gl_tests/PbufferTest.cpp: Originally-landed-as: 267815.587@safari-7617-branch (db3f6a7dbf33). rdar://121481385 Canonical link: https://commits.webkit.org/273423@main Commit: 568df84631eb4f205057cb9634fa404e2787d08c https://github.com/WebKit/WebKit/commit/568df84631eb4f205057cb9634fa404e2787d08c Author: Erica Li Date: 2024-01-24 (Wed, 24 Jan 2024) Changed paths: A LayoutTests/fast/text/line-break-after-whitespace-create-display-content-crash-expected.txt A LayoutTests/fast/text/line-break-after-whitespace-create-display-content-crash.html M
[webkit-changes] [WebKit/WebKit] f62dc2: WebFrameLoaderClient::dispatchDecidePolicyForNavig...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: f62dc2ae6c6b869b3feb37de4941b9f24afdaa95 https://github.com/WebKit/WebKit/commit/f62dc2ae6c6b869b3feb37de4941b9f24afdaa95 Author: Alex Christensen Date: 2024-01-24 (Wed, 24 Jan 2024) Changed paths: M Source/WebCore/dom/SecurityContext.h M Source/WebCore/loader/CrossOriginOpenerPolicy.h M Source/WebCore/loader/EmptyClients.cpp M Source/WebCore/loader/EmptyFrameLoaderClient.h M Source/WebCore/loader/FrameLoaderClient.h M Source/WebCore/loader/LocalFrameLoaderClient.h M Source/WebCore/loader/PolicyChecker.cpp M Source/WebCore/loader/PolicyChecker.h M Source/WebKit/Shared/LoadParameters.h M Source/WebKit/Shared/NavigationActionData.h M Source/WebKit/Shared/WebHitTestResultData.cpp M Source/WebKit/Shared/WebHitTestResultData.h M Source/WebKit/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp M Source/WebKit/WebProcess/WebCoreSupport/WebFrameLoaderClient.h M Source/WebKit/WebProcess/WebCoreSupport/WebLocalFrameLoaderClient.cpp M Source/WebKit/WebProcess/WebCoreSupport/WebLocalFrameLoaderClient.h M Source/WebKit/WebProcess/WebCoreSupport/WebRemoteFrameClient.cpp M Source/WebKitLegacy/mac/WebCoreSupport/WebFrameLoaderClient.h M Source/WebKitLegacy/mac/WebCoreSupport/WebFrameLoaderClient.mm Log Message: --- WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction shouldn't interact with a LocalFrame https://bugs.webkit.org/show_bug.cgi?id=267984 Reviewed by Chris Dumez. The Frame may be a RemoteFrame. This is part of untangling this navigation flow so I can reuse its pieces better. * Source/WebCore/dom/SecurityContext.h: * Source/WebCore/loader/CrossOriginOpenerPolicy.h: * Source/WebCore/loader/EmptyClients.cpp: (WebCore::EmptyFrameLoaderClient::dispatchDecidePolicyForNewWindowAction): (WebCore::EmptyFrameLoaderClient::dispatchDecidePolicyForNavigationAction): * Source/WebCore/loader/EmptyFrameLoaderClient.h: * Source/WebCore/loader/FrameLoaderClient.h: * Source/WebCore/loader/LocalFrameLoaderClient.h: * Source/WebCore/loader/PolicyChecker.cpp: (WebCore::FrameLoader::PolicyChecker::checkNavigationPolicy): (WebCore::FrameLoader::PolicyChecker::hitTestResult): (WebCore::FrameLoader::PolicyChecker::checkNewWindowPolicy): * Source/WebCore/loader/PolicyChecker.h: * Source/WebKit/Shared/LoadParameters.h: * Source/WebKit/Shared/NavigationActionData.h: * Source/WebKit/Shared/WebHitTestResultData.cpp: (WebKit::WebHitTestResultData::fromNavigationActionAndLocalFrame): Deleted. * Source/WebKit/Shared/WebHitTestResultData.h: * Source/WebKit/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp: (WebKit::WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction): * Source/WebKit/WebProcess/WebCoreSupport/WebFrameLoaderClient.h: * Source/WebKit/WebProcess/WebCoreSupport/WebLocalFrameLoaderClient.cpp: (WebKit::WebLocalFrameLoaderClient::dispatchDecidePolicyForNewWindowAction): (WebKit::WebLocalFrameLoaderClient::dispatchDecidePolicyForNavigationAction): * Source/WebKit/WebProcess/WebCoreSupport/WebLocalFrameLoaderClient.h: * Source/WebKit/WebProcess/WebCoreSupport/WebRemoteFrameClient.cpp: (WebKit::WebRemoteFrameClient::changeLocation): * Source/WebKitLegacy/mac/WebCoreSupport/WebFrameLoaderClient.h: * Source/WebKitLegacy/mac/WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction): (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction): Canonical link: https://commits.webkit.org/273419@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 0ae38a: [Gardening] `CSSStyleSheet-constructable-concat.ht...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 0ae38a7f4c08fa8fbc9041e8cb52e5693eda0b1c https://github.com/WebKit/WebKit/commit/0ae38a7f4c08fa8fbc9041e8cb52e5693eda0b1c Author: Ahmad Saleem Date: 2024-01-24 (Wed, 24 Jan 2024) Changed paths: R LayoutTests/imported/w3c/web-platform-tests/css/cssom/CSSStyleSheet-constructable-concat-expected.txt Log Message: --- [Gardening] `CSSStyleSheet-constructable-concat.html` is reftest and should not have '-expected.txt' file https://bugs.webkit.org/show_bug.cgi?id=267997 Reviewed by Anne van Kesteren. The test is 'reftest' and should not have `-expected.txt` file, this PR removes it. * LayoutTests/imported/w3c/web-platform-tests/css/cssom/CSSStyleSheet-constructable-concat-expected.txt: Deleted Canonical link: https://commits.webkit.org/273418@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 67943c: Non-unified build fixes, late January 2024 edition
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 67943cb752bf84af9cdb249ad792f7369f9f0f96 https://github.com/WebKit/WebKit/commit/67943cb752bf84af9cdb249ad792f7369f9f0f96 Author: Don Olmstead Date: 2024-01-24 (Wed, 24 Jan 2024) Changed paths: M Source/JavaScriptCore/bytecode/ExpressionInfo.cpp M Source/JavaScriptCore/bytecode/ExpressionInfo.h M Source/JavaScriptCore/llint/LLIntThunks.cpp M Source/JavaScriptCore/runtime/FileBasedFuzzerAgentBase.h M Source/WebCore/Modules/WebGPU/GPUOutOfMemoryError.h M Source/WebCore/Modules/WebGPU/GPURenderPassColorAttachment.h M Source/WebCore/Modules/WebGPU/InternalAPI/WebGPURenderPassColorAttachment.h M Source/WebCore/css/calc/CSSCalcExpressionNodeParser.h M Source/WebCore/history/HistoryItem.cpp M Source/WebCore/html/FormListedElement.cpp M Source/WebCore/layout/formattingContexts/inline/ruby/RubyFormattingContext.cpp M Source/WebCore/layout/formattingContexts/inline/ruby/RubyFormattingContext.h M Source/WebCore/rendering/updating/RenderTreeUpdaterViewTransition.cpp M Source/WebKit/Shared/WebGPU/WebGPURenderPassColorAttachment.h Log Message: --- Non-unified build fixes, late January 2024 edition https://bugs.webkit.org/show_bug.cgi?id=267954 Reviewed by Ryosuke Niwa. Unreviewed non-unified build fix. * Source/JavaScriptCore/bytecode/ExpressionInfo.cpp: * Source/JavaScriptCore/bytecode/ExpressionInfo.h: * Source/JavaScriptCore/llint/LLIntThunks.cpp: * Source/JavaScriptCore/runtime/FileBasedFuzzerAgentBase.h: * Source/WebCore/Modules/WebGPU/GPUOutOfMemoryError.h: * Source/WebCore/Modules/WebGPU/GPURenderPassColorAttachment.h: * Source/WebCore/Modules/WebGPU/InternalAPI/WebGPURenderPassColorAttachment.h: * Source/WebCore/css/calc/CSSCalcExpressionNodeParser.h: * Source/WebCore/history/HistoryItem.cpp: * Source/WebCore/html/FormListedElement.cpp: * Source/WebCore/layout/formattingContexts/inline/ruby/RubyFormattingContext.cpp: * Source/WebCore/layout/formattingContexts/inline/ruby/RubyFormattingContext.h: * Source/WebCore/rendering/updating/RenderTreeUpdaterViewTransition.cpp: * Source/WebKit/Shared/WebGPU/WebGPURenderPassColorAttachment.h: Canonical link: https://commits.webkit.org/273417@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 80d432: upload-file-to-url should print information about ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 80d432578269e9734ce838b30d89f2b9308821c5 https://github.com/WebKit/WebKit/commit/80d432578269e9734ce838b30d89f2b9308821c5 Author: Aakash Jain Date: 2024-01-24 (Wed, 24 Jan 2024) Changed paths: M Tools/CISupport/ews-build/steps.py M Tools/CISupport/ews-build/steps_unittest.py M Tools/Scripts/upload-file-to-url Log Message: --- upload-file-to-url should print information about retry attempts live while it is running https://bugs.webkit.org/show_bug.cgi?id=268004 Reviewed by Jonathan Bedard. Replace print with sys.stderr.write. Also, increase timeout for upload-file-to-s3 step from 30 to 31 minutes so as to allow the script to finish by itself (it has 3 retries of 10 minutes each). * Tools/Scripts/upload-file-to-url: * Tools/CISupport/ews-build/steps.py: * Tools/CISupport/ews-build/steps_unittest.py: Canonical link: https://commits.webkit.org/273416@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 22599e: [JSC][armv7] Re-enable DFG after CallIC changes
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 22599e19e5d7d89b799a199b57490d287105944d https://github.com/WebKit/WebKit/commit/22599e19e5d7d89b799a199b57490d287105944d Author: Joseph Griego Date: 2024-01-24 (Wed, 24 Jan 2024) Changed paths: M Source/JavaScriptCore/runtime/Options.cpp Log Message: --- [JSC][armv7] Re-enable DFG after CallIC changes https://bugs.webkit.org/show_bug.cgi?id=267947 Reviewed by Yusuke Suzuki. After 65c8acc4699947d9a9b6326b9672a2fca5804a8c, DFG was broken on armv7 and was disabled. However, this breakage was due to DFG calls not checking the tag word of the callee and also skipping part of the tail-call preparation due to an old, unused patchable branch; incidentally, both were fixed in d0345d69220e43945f9b9632378eab88cb50e1da, so, we can re-enable DFG if test cases are passing again. * Source/JavaScriptCore/runtime/Options.cpp: (JSC::Options::notifyOptionsChanged): Canonical link: https://commits.webkit.org/273415@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 27a506: Fix the build with WebCodecs enabled after 0ebf839...
Branch: refs/heads/webkitglib/2.42 Home: https://github.com/WebKit/WebKit Commit: 27a50613a11c7f7e0781af4e18789a3f838ec8a1 https://github.com/WebKit/WebKit/commit/27a50613a11c7f7e0781af4e18789a3f838ec8a1 Author: Adrian Perez de Castro Date: 2024-01-24 (Wed, 24 Jan 2024) Changed paths: M Source/WebCore/bindings/js/SerializedScriptValue.cpp Log Message: --- Fix the build with WebCodecs enabled after 0ebf8393b3e4 Unreviewed build fix. Delete a few uses of enum tags and methods from the WebCodecs audio support which are not yet present in the 2.42.x release branch and were left during when 0ebf8393b3e4 was backported. * Source/WebCore/bindings/js/SerializedScriptValue.cpp: (WebCore::name): (WebCore::CloneDeserializer::deserialize): (WebCore::CloneDeserializer::takeSerializedVideoFrames): (WebCore::validateSerializedResult): (WebCore::CloneDeserializer::takeSerializedAudioChunks): Deleted. (WebCore::CloneDeserializer::takeSerializedAudioData): Deleted. ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 3873b3: [LBSE] Rebaseline svg/ tests
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 3873b3a523f316d7c1e3b26f09def41f2a8c2364 https://github.com/WebKit/WebKit/commit/3873b3a523f316d7c1e3b26f09def41f2a8c2364 Author: Rob Buis Date: 2024-01-24 (Wed, 24 Jan 2024) Changed paths: M LayoutTests/platform/mac-sonoma-wk2-lbse-text/svg/custom/inline-svg-in-xhtml-expected.txt M LayoutTests/platform/mac-sonoma-wk2-pixel/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.png M LayoutTests/platform/mac-sonoma-wk2-pixel/svg/W3C-SVG-1.1/animate-elem-15-t-expected.png M LayoutTests/platform/mac-sonoma-wk2-pixel/svg/W3C-SVG-1.1/animate-elem-17-t-expected.png M LayoutTests/platform/mac-sonoma-wk2-pixel/svg/W3C-SVG-1.1/animate-elem-28-t-expected.png M LayoutTests/platform/mac-sonoma-wk2-pixel/svg/W3C-SVG-1.1/animate-elem-30-t-expected.png M LayoutTests/platform/mac-sonoma-wk2-pixel/svg/W3C-SVG-1.1/animate-elem-37-t-expected.png M LayoutTests/platform/mac-sonoma-wk2-pixel/svg/W3C-SVG-1.1/animate-elem-39-t-expected.png M LayoutTests/platform/mac-sonoma-wk2-pixel/svg/W3C-SVG-1.1/animate-elem-40-t-expected.png M LayoutTests/platform/mac-sonoma-wk2-pixel/svg/W3C-SVG-1.1/animate-elem-81-t-expected.png M LayoutTests/platform/mac-sonoma-wk2-pixel/svg/W3C-SVG-1.1/coords-viewattr-02-b-expected.png M LayoutTests/platform/mac-sonoma-wk2-pixel/svg/W3C-SVG-1.1/extend-namespace-01-f-expected.png M LayoutTests/platform/mac-sonoma-wk2-pixel/svg/W3C-SVG-1.1/filters-image-01-b-expected.png M LayoutTests/platform/mac-sonoma-wk2-pixel/svg/W3C-SVG-1.1/fonts-desc-02-t-expected.png M LayoutTests/platform/mac-sonoma-wk2-pixel/svg/W3C-SVG-1.1/interact-cursor-01-f-expected.png M LayoutTests/platform/mac-sonoma-wk2-pixel/svg/W3C-SVG-1.1/masking-mask-01-b-expected.png M LayoutTests/platform/mac-sonoma-wk2-pixel/svg/W3C-SVG-1.1/masking-path-01-b-expected.png M LayoutTests/platform/mac-sonoma-wk2-pixel/svg/W3C-SVG-1.1/masking-path-04-b-expected.png M LayoutTests/platform/mac-sonoma-wk2-pixel/svg/W3C-SVG-1.1/metadata-example-01-b-expected.png M LayoutTests/platform/mac-sonoma-wk2-pixel/svg/W3C-SVG-1.1/paths-data-03-f-expected.png M LayoutTests/platform/mac-sonoma-wk2-pixel/svg/W3C-SVG-1.1/pservers-grad-05-b-expected.png M LayoutTests/platform/mac-sonoma-wk2-pixel/svg/W3C-SVG-1.1/pservers-grad-17-b-expected.png M LayoutTests/platform/mac-sonoma-wk2-pixel/svg/W3C-SVG-1.1/render-elems-07-t-expected.png M LayoutTests/platform/mac-sonoma-wk2-pixel/svg/W3C-SVG-1.1/struct-image-01-t-expected.png M LayoutTests/platform/mac-sonoma-wk2-pixel/svg/W3C-SVG-1.1/struct-image-02-b-expected.png M LayoutTests/platform/mac-sonoma-wk2-pixel/svg/W3C-SVG-1.1/struct-image-04-t-expected.png M LayoutTests/platform/mac-sonoma-wk2-pixel/svg/W3C-SVG-1.1/struct-image-09-t-expected.png M LayoutTests/platform/mac-sonoma-wk2-pixel/svg/W3C-SVG-1.1/struct-image-10-t-expected.png M LayoutTests/platform/mac-sonoma-wk2-pixel/svg/W3C-SVG-1.1/text-altglyph-01-b-expected.png M LayoutTests/platform/mac-sonoma-wk2-pixel/svg/as-background-image/animated-svg-as-background-expected.png M LayoutTests/platform/mac-sonoma-wk2-pixel/svg/as-background-image/svg-as-background-4-expected.png M LayoutTests/platform/mac-sonoma-wk2-pixel/svg/as-background-image/svg-as-background-5-expected.png M LayoutTests/platform/mac-sonoma-wk2-pixel/svg/as-object/object-box-sizing-no-width-height-expected.png M LayoutTests/platform/mac-sonoma-wk2-pixel/svg/batik/filters/feTile-expected.png M LayoutTests/platform/mac-sonoma-wk2-pixel/svg/batik/masking/maskRegions-expected.png M LayoutTests/platform/mac-sonoma-wk2-pixel/svg/batik/paints/patternRegions-positioned-objects-expected.png M LayoutTests/platform/mac-sonoma-wk2-pixel/svg/batik/text/textDecoration-expected.png M LayoutTests/platform/mac-sonoma-wk2-pixel/svg/batik/text/textEffect-expected.png M LayoutTests/platform/mac-sonoma-wk2-pixel/svg/batik/text/textEffect2-expected.png M LayoutTests/platform/mac-sonoma-wk2-pixel/svg/batik/text/textLength-expected.png M LayoutTests/platform/mac-sonoma-wk2-pixel/svg/batik/text/textOnPath-expected.png M LayoutTests/platform/mac-sonoma-wk2-pixel/svg/batik/text/verticalText-expected.png M LayoutTests/platform/mac-sonoma-wk2-pixel/svg/carto.net/colourpicker-expected.png M LayoutTests/platform/mac-sonoma-wk2-pixel/svg/carto.net/scrollbar-expected.png M LayoutTests/platform/mac-sonoma-wk2-pixel/svg/carto.net/selectionlist-expected.png M LayoutTests/platform/mac-sonoma-wk2-pixel/svg/css/text-shadow-multiple-expected.png M LayoutTests/platform/mac-sonoma-wk2-pixel/svg/custom/absolute-sized-content-with-resources-expected.png M LayoutTests/platform/mac-sonoma-wk2-pixel/svg/custom/clone-element-with-animated-svg-properties-expected.png M
[webkit-changes] [WebKit/WebKit] abe059: [WebDriver] Pytest errors running run-webdriver-te...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: abe0591426767036fc01d5d86d8a158ddfb77457 https://github.com/WebKit/WebKit/commit/abe0591426767036fc01d5d86d8a158ddfb77457 Author: Lauro Moura Date: 2024-01-24 (Wed, 24 Jan 2024) Changed paths: M Tools/Scripts/webkitpy/webdriver_tests/pytest_runner.py M WebDriverTests/imported/w3c/config.json Log Message: --- [WebDriver] Pytest errors running run-webdriver-tests on a clean environment https://bugs.webkit.org/show_bug.cgi?id=265202 Reviewed by Carlos Garcia Campos. Import required pytest plugins to ensure Autoinstall installs them before invoking pytest programatically in `pytest_runner.py` pytest's lazy plugin loading wasn't installing either pytest-timeout nor pytest-asyncio. The former added support for the `--timeout` parameter that was being unrecognized in this bug original report. This commit also includes a drive-by fix of WPT webdriver config.json, updating a key in the same was as https://commits.webkit.org/272808@main * Tools/Scripts/webkitpy/webdriver_tests/pytest_runner.py: * WebDriverTests/imported/w3c/config.json: Canonical link: https://commits.webkit.org/273413@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] fa283e: [git-webkit] Automatically make merge-back tasks o...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: fa283e1ae8bf83f6c4306344aac6def4fa5da24b https://github.com/WebKit/WebKit/commit/fa283e1ae8bf83f6c4306344aac6def4fa5da24b Author: Jonathan Bedard Date: 2024-01-24 (Wed, 24 Jan 2024) Changed paths: M Tools/Scripts/libraries/webkitbugspy/webkitbugspy/mocks/radar.py M Tools/Scripts/libraries/webkitbugspy/webkitbugspy/radar.py M Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/clone.py M Tools/Scripts/libraries/webkitscmpy/webkitscmpy/test/clone_unittest.py Log Message: --- [git-webkit] Automatically make merge-back tasks of umbrella radar https://bugs.webkit.org/show_bug.cgi?id=267933 rdar://121450457 Reviewed by Dewei Zhu. Per policy, merge-back tasks should exist under an umbrella radar. We should automatically create merge-back clones under this radar. * Tools/Scripts/libraries/webkitbugspy/webkitbugspy/mocks/radar.py: (RadarClient.find_radars): Implement a basic mock of radarclient's find_radars query. * Tools/Scripts/libraries/webkitbugspy/webkitbugspy/radar.py: (Tracker): Remove comment on search function. * Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/clone.py: (Clone.parent): Determine the umbrella merge-back radar for a specific milestone. (Clone.main): Automatically mark merge-back clone as subtask of umbrella merge-back radar. * Tools/Scripts/libraries/webkitscmpy/webkitscmpy/test/clone_unittest.py: (TestClone.test_find_parent_none): (TestClone.test_find_parent): (TestClone.test_merge_back_no_parent): (TestClone.test_merge_back): Canonical link: https://commits.webkit.org/273412@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] ca705e: [GStreamer] Minor improvements and logging for Vid...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: ca705e68c3039dcbeb6146bf21dc2765acfd4418 https://github.com/WebKit/WebKit/commit/ca705e68c3039dcbeb6146bf21dc2765acfd4418 Author: Philippe Normand Date: 2024-01-24 (Wed, 24 Jan 2024) Changed paths: M Source/WebCore/platform/graphics/gstreamer/VideoFrameGStreamer.cpp M Source/WebCore/platform/graphics/gstreamer/VideoFrameGStreamer.h M Source/WebCore/platform/mediastream/gstreamer/MockRealtimeVideoSourceGStreamer.cpp Log Message: --- [GStreamer] Minor improvements and logging for VideoFrame implementation https://bugs.webkit.org/show_bug.cgi?id=267924 Reviewed by Xabier Rodriguez-Calvar. The createFromPixelBuffer() should be allowed to fail, when conversion fails. The call sites were adapted accordingly. Also we were applying the frame metadata twice to those buffers, for no particular reason. * Source/WebCore/platform/graphics/gstreamer/VideoFrameGStreamer.cpp: (WebCore::VideoFrame::createFromPixelBuffer): (WebCore::VideoFrameGStreamer::createFromPixelBuffer): * Source/WebCore/platform/graphics/gstreamer/VideoFrameGStreamer.h: * Source/WebCore/platform/mediastream/gstreamer/MockRealtimeVideoSourceGStreamer.cpp: (WebCore::MockRealtimeVideoSourceGStreamer::updateSampleBuffer): Canonical link: https://commits.webkit.org/273411@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 7b9b52: [GStreamer] media/media-vp8-webm-error.html is a ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 7b9b52800ba59d8a4727340d92227a2b17584116 https://github.com/WebKit/WebKit/commit/7b9b52800ba59d8a4727340d92227a2b17584116 Author: Philippe Normand Date: 2024-01-24 (Wed, 24 Jan 2024) Changed paths: M LayoutTests/platform/glib/TestExpectations M Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp Log Message: --- [GStreamer] media/media-vp8-webm-error.html is a permanent failure https://bugs.webkit.org/show_bug.cgi?id=267370 Reviewed by Xabier Rodriguez-Calvar. By default GstVideoDecoder doesn't emit error messages on the bus, until its max-errors threshold is reached. By default its value is -1, so no errors raised to application level. We now set it to 0, which means that the decoder will notify us starting from the first decoding error. * LayoutTests/platform/glib/TestExpectations: * Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivateGStreamer::handleMessage): (WebCore::MediaPlayerPrivateGStreamer::configureVideoDecoder): Canonical link: https://commits.webkit.org/273410@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] e9d2d1: [iOS] Instagram story header lays out under status...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: e9d2d1449a98d1e47abca2829f576cbb19e7d041 https://github.com/WebKit/WebKit/commit/e9d2d1449a98d1e47abca2829f576cbb19e7d041 Author: Jer Noble Date: 2024-01-24 (Wed, 24 Jan 2024) Changed paths: M Source/WebCore/page/Quirks.cpp Log Message: --- [iOS] Instagram story header lays out under status bar on the web and can’t be tapped https://bugs.webkit.org/show_bug.cgi?id=267893 rdar://121014613 Reviewed by Aditya Keerthi and Eric Carlson. Instagram adopts `viewport-fit=cover`, so fullscreen content will intentionally flow under the unsafe areas in fullscreen. Adding a quirk for Instagram.com to disable the Fullscreen API until this behavior is fixed server-side. * Source/WebCore/page/Quirks.cpp: (WebCore::Quirks::shouldDisableElementFullscreenQuirk const): Canonical link: https://commits.webkit.org/273409@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] a92146: [Glib] Getting stacktrace from systemd fails somet...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: a92146e5ba8f2bd1fcd843249aa9652e2852d922 https://github.com/WebKit/WebKit/commit/a92146e5ba8f2bd1fcd843249aa9652e2852d922 Author: Vitaly Dyachkov Date: 2024-01-24 (Wed, 24 Jan 2024) Changed paths: M Tools/Scripts/webkitpy/port/linux_get_crash_log.py Log Message: --- [Glib] Getting stacktrace from systemd fails sometimes https://bugs.webkit.org/show_bug.cgi?id=267999 Reviewed by Adrian Perez de Castro. When `coredumpctl` is available, we use it to get the stacktrace. The exact command executed is `coredumpctl info --since="Wed 2024-01-24 14:48:45 CET"`. But sometimes it fails to parse the provided datetime: ``` $ coredumpctl info --since="Wed 2024-01-24 14:48:45 CET" Failed to parse timestamp 'Wed 2024-01-24 14:48:45 CET': Invalid argument ``` According to systemd documentation [1], we can pass the number of seconds since the UNIX epoch prefixed with `@` instead. [1] https://www.freedesktop.org/software/systemd/man/latest/systemd.time.html * Tools/Scripts/webkitpy/port/linux_get_crash_log.py: (GDBCrashLogGenerator._get_trace_from_systemd): Canonical link: https://commits.webkit.org/273408@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 1e4b44: REGRESSION (267617@main): Bad layout on kk.org
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 1e4b445227ae8d5e3c9ef8d13d0acd90e1c1366b https://github.com/WebKit/WebKit/commit/1e4b445227ae8d5e3c9ef8d13d0acd90e1c1366b Author: Alan Baradlay Date: 2024-01-24 (Wed, 24 Jan 2024) Changed paths: A LayoutTests/fast/text/float-and-out-of-flow-and-br-with-clear-expected.html A LayoutTests/fast/text/float-and-out-of-flow-and-br-with-clear.html M Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.cpp M Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.h M Source/WebCore/layout/formattingContexts/inline/TextOnlySimpleLineBuilder.cpp Log Message: --- REGRESSION (267617@main): Bad layout on kk.org https://bugs.webkit.org/show_bug.cgi?id=267940 Reviewed by Simon Fraser. Now that we append out-of-flow boxes to Line, checking if m_line.runs() is empty does not always produce the correct answer for the question of "is this the last line with inline content". We end up finding subsequent lines with isLastLineWithInlineContent true which confuses the clear gap logic that we use to offset cleared floats _after_ the last line (the distance between the last line with inline content and the bottom of the cleared float(s)). * LayoutTests/fast/text/float-and-out-of-flow-and-br-with-clear-expected.html: Added. * LayoutTests/fast/text/float-and-out-of-flow-and-br-with-clear.html: Added. * Source/WebCore/layout/integration/inline/LayoutIntegrationLineLayout.cpp: (WebCore::LayoutIntegration::LineLayout::contentBoxLogicalHeight const): Canonical link: https://commits.webkit.org/273407@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 6bf767: REGRESSION (268393@main): [ Monterey Ventura Debug...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 6bf767bc41419a266bac5b934afcbe5c6f74d0b3 https://github.com/WebKit/WebKit/commit/6bf767bc41419a266bac5b934afcbe5c6f74d0b3 Author: Jean-Yves Avenard Date: 2024-01-24 (Wed, 24 Jan 2024) Changed paths: M LayoutTests/platform/ios/TestExpectations M Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm M Source/WebCore/platform/graphics/cocoa/MediaPlayerPrivateWebM.mm M Source/WebKit/WebProcess/GPU/media/MediaPlayerPrivateRemote.cpp M Source/WebKit/WebProcess/GPU/media/MediaPlayerPrivateRemote.h Log Message: --- REGRESSION (268393@main): [ Monterey Ventura Debug wk2 ] ASSERTION FAILED: willBeComposited == needsToBeComposited(layer, queryData) https://bugs.webkit.org/show_bug.cgi?id=267661 rdar://121154236 Reviewed by Eric Carlson and Simon Fraser. It was possible the MediaPlayerPrivate's accelerated rendering capability to change without a required match to MediaPlayer::renderingModeChanged. We were querying the old value of MediaPlayer::renderingCanBeAccelerated after modifying a class member that would impact what the new value would be. Compare with the previous value and call renderingModeChanged if required. Covered by existing tests. * LayoutTests/platform/ios/TestExpectations: Remove obsolete expectations as original bug got fixed. * Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm: Remove unnecessary call to renderModeChanged as removing the audio layer doesn't impact how images are rendered. * Source/WebCore/platform/graphics/cocoa/MediaPlayerPrivateWebM.mm: (WebCore::MediaPlayerPrivateWebM::destroyAudioRenderers): Same as above. * Source/WebKit/WebProcess/GPU/media/MediaPlayerPrivateRemote.cpp: (WebKit::MediaPlayerPrivateRemote::MediaPlayerPrivateRemote): There's no need to send to the GPU process that the rendering has mode has changed as both content process and GPU process' player values are initialised to false. (WebKit::MediaPlayerPrivateRemote::readyStateChanged): (WebKit::MediaPlayerPrivateRemote::acceleratedRenderingStateChanged): (WebKit::MediaPlayerPrivateRemote::updateConfiguration): (WebKit::MediaPlayerPrivateRemote::setVideoFullscreenLayer): (WebKit::MediaPlayerPrivateRemote::checkAcceleratedRenderingState): Deleted. * Source/WebKit/WebProcess/GPU/media/MediaPlayerPrivateRemote.h: Canonical link: https://commits.webkit.org/273406@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 75f7d9: [WebAuthn] Fix Web Authentication AuthenticationSe...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 75f7d901f88b6f7b713aaec7fb34516596d303f6 https://github.com/WebKit/WebKit/commit/75f7d901f88b6f7b713aaec7fb34516596d303f6 Author: Pascoe Date: 2024-01-24 (Wed, 24 Jan 2024) Changed paths: M Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml Log Message: --- [WebAuthn] Fix Web Authentication AuthenticationServices feature flag rdar://121473121 https://bugs.webkit.org/show_bug.cgi?id=267970 Reviewed by Charlie Wolfe. The condition for this feature flag was erroneously written as ENABLE(WEB_AUTHN_AS_MODERN), but only HAVE(WEB_AUTHN_AS_MODERN) is defined. This patch fixes that. * Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml: Canonical link: https://commits.webkit.org/273405@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 5eb8b5: Timestamps should be preserved between VideoTrackG...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 5eb8b5f9535303f4c25fbcaddcf718f0cf417ba1 https://github.com/WebKit/WebKit/commit/5eb8b5f9535303f4c25fbcaddcf718f0cf417ba1 Author: Youenn Fablet Date: 2024-01-24 (Wed, 24 Jan 2024) Changed paths: M LayoutTests/http/wpt/mediastream/worker-mediastreamtrack.worker.js M Source/WebCore/Modules/mediastream/MediaStreamTrackProcessor.cpp M Source/WebCore/Modules/webcodecs/WebCodecsVideoFrame.cpp M Source/WebCore/Modules/webcodecs/WebCodecsVideoFrame.h Log Message: --- Timestamps should be preserved between VideoTrackGenerator and MediaStreamTrackProcessor https://bugs.webkit.org/show_bug.cgi?id=267929 rdar://121462248 Reviewed by Eric Carlson. Add support for setting the VideoFrame presentationTime based on the WebCodecsVideoFrame timestamp. In the future, the WebCodecsVideoFrame timestamp will be removed in favour of the VideoFrame presentationTime. Make sure to have MediaStreamTrackProcessor correctly create the WebCodecsVideoFrame with the presentationTime. * LayoutTests/http/wpt/mediastream/worker-mediastreamtrack.worker.js: (makeOffscreenCanvasVideoFrame): (promise_test.async t): * Source/WebCore/Modules/mediastream/MediaStreamTrackProcessor.cpp: (WebCore::MediaStreamTrackProcessor::VideoFrameObserver::takeVideoFrame): * Source/WebCore/Modules/webcodecs/WebCodecsVideoFrame.cpp: (WebCore::WebCodecsVideoFrame::create): (WebCore::WebCodecsVideoFrame::initializeFrameFromOtherFrame): * Source/WebCore/Modules/webcodecs/WebCodecsVideoFrame.h: Canonical link: https://commits.webkit.org/273404@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 6799e1: [SOUP] Flaky crash in g_tls_certificate_gnutls_fin...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 6799e10d2b609992ee6601085b5385b72bb51e6a https://github.com/WebKit/WebKit/commit/6799e10d2b609992ee6601085b5385b72bb51e6a Author: Vitaly Dyachkov Date: 2024-01-24 (Wed, 24 Jan 2024) Changed paths: M LayoutTests/platform/glib/TestExpectations Log Message: --- [SOUP] Flaky crash in g_tls_certificate_gnutls_finalize() - corrupted double-linked list https://bugs.webkit.org/show_bug.cgi?id=267992 Unreviewed test gardening. * LayoutTests/platform/glib/TestExpectations: Canonical link: https://commits.webkit.org/273403@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] c90fbe: [SOUP] Flaky crash in g_type_check_instance_is_fun...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: c90fbe579f41faf5ac813466b3aeda75bc4715e0 https://github.com/WebKit/WebKit/commit/c90fbe579f41faf5ac813466b3aeda75bc4715e0 Author: Vitaly Dyachkov Date: 2024-01-24 (Wed, 24 Jan 2024) Changed paths: M LayoutTests/platform/glib/TestExpectations Log Message: --- [SOUP] Flaky crash in g_type_check_instance_is_fundamentally_a https://bugs.webkit.org/show_bug.cgi?id=267990 Unreviewed test gardening. * LayoutTests/platform/glib/TestExpectations: Canonical link: https://commits.webkit.org/273402@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 2f91ef: [SOUP] g_atomic_rc_box_release_full: assertion 're...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 2f91ef7e81115ea4fe86fc6dcb6bac426c3c6b17 https://github.com/WebKit/WebKit/commit/2f91ef7e81115ea4fe86fc6dcb6bac426c3c6b17 Author: Vitaly Dyachkov Date: 2024-01-24 (Wed, 24 Jan 2024) Changed paths: M LayoutTests/platform/glib/TestExpectations Log Message: --- [SOUP] g_atomic_rc_box_release_full: assertion 'real_box->magic == G_BOX_MAGIC' failed https://bugs.webkit.org/show_bug.cgi?id=267988 Unreviewed test gardening. * LayoutTests/platform/glib/TestExpectations: Canonical link: https://commits.webkit.org/273401@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 1dd42b: MediaStreamTrackProcessor should not be destroyed ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 1dd42ba248d5a42d0142a2a0134b23ec189ff1cf https://github.com/WebKit/WebKit/commit/1dd42ba248d5a42d0142a2a0134b23ec189ff1cf Author: Youenn Fablet Date: 2024-01-24 (Wed, 24 Jan 2024) Changed paths: M Source/WebCore/Modules/fetch/FetchBodySource.h M Source/WebCore/Modules/mediastream/MediaStreamTrackProcessor.cpp M Source/WebCore/Modules/mediastream/MediaStreamTrackProcessor.h M Source/WebCore/Modules/streams/ReadableStreamSource.h M Source/WebCore/Modules/webtransport/DatagramSource.h M Source/WebCore/Modules/webtransport/WebTransportBidirectionalStreamSource.h M Source/WebCore/Modules/webtransport/WebTransportReceiveStreamSource.h M Source/WebCore/fileapi/Blob.cpp M Source/WebKit/WebProcess/Network/WebTransportReceiveStreamSource.h Log Message: --- MediaStreamTrackProcessor should not be destroyed if its ReadableStream source is live https://bugs.webkit.org/show_bug.cgi?id=267932 rdar://121465569 Reviewed by Eric Carlson. We want to keep MediaStreamTrackProcessor alive if its ReadableStream source is alive, so that we can pipe the received video frames to the source. To do this, MediaStreamTrackProcessor::Source is no longer RefCounted but will use its MediaStreamTrackProcessor ref count. We make ReadableStreamSource no longer refcounted so that MediaStreamTrackProcessor::Source can do its own ref/deref. We introduce RefCountedReadableStreamSource for other existing ReadableStream sources. * Source/WebCore/Modules/fetch/FetchBodySource.h: * Source/WebCore/Modules/mediastream/MediaStreamTrackProcessor.cpp: (WebCore::MediaStreamTrackProcessor::readable): * Source/WebCore/Modules/mediastream/MediaStreamTrackProcessor.h: * Source/WebCore/Modules/streams/ReadableStreamSource.h: * Source/WebCore/Modules/webtransport/DatagramSource.h: * Source/WebCore/Modules/webtransport/WebTransportBidirectionalStreamSource.h: * Source/WebCore/Modules/webtransport/WebTransportReceiveStreamSource.h: * Source/WebCore/fileapi/Blob.cpp: (WebCore::Blob::stream): * Source/WebKit/WebProcess/Network/WebTransportReceiveStreamSource.h: Canonical link: https://commits.webkit.org/273400@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 4241ce: [content-visibility] REGRESSION(267547@main): Blan...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 4241ce2896306ad1fc0443357a0ae93462fa7734 https://github.com/WebKit/WebKit/commit/4241ce2896306ad1fc0443357a0ae93462fa7734 Author: Rob Buis Date: 2024-01-24 (Wed, 24 Jan 2024) Changed paths: A LayoutTests/imported/w3c/web-platform-tests/css/css-contain/content-visibility/content-visibility-096-expected.html A LayoutTests/imported/w3c/web-platform-tests/css/css-contain/content-visibility/content-visibility-096.html A LayoutTests/imported/w3c/web-platform-tests/css/css-contain/content-visibility/content-visibility-097-expected.html A LayoutTests/imported/w3c/web-platform-tests/css/css-contain/content-visibility/content-visibility-097.html A LayoutTests/imported/w3c/web-platform-tests/css/css-contain/content-visibility/content-visibility-098-expected.html A LayoutTests/imported/w3c/web-platform-tests/css/css-contain/content-visibility/content-visibility-098.html A LayoutTests/imported/w3c/web-platform-tests/css/css-contain/content-visibility/content-visibility-099-expected.html A LayoutTests/imported/w3c/web-platform-tests/css/css-contain/content-visibility/content-visibility-099.html M Source/WebCore/rendering/RenderElement.cpp Log Message: --- [content-visibility] REGRESSION(267547@main): Blank panels on bing.com (content-visibility: auto) https://bugs.webkit.org/show_bug.cgi?id=264989 Reviewed by Simon Fraser. When content-visibility status changes from hidden/out of view to visible/in viewport we should use dirtyVisibleContentStatus since setHasVisibleContent has no effect on the subtree of the content-visibility root if the layer already has this flag set, causing the subtree to remain hidden. * LayoutTests/imported/w3c/web-platform-tests/css/css-contain/content-visibility/content-visibility-096-expected.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-contain/content-visibility/content-visibility-096.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-contain/content-visibility/content-visibility-097-expected.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-contain/content-visibility/content-visibility-097.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-contain/content-visibility/content-visibility-098-expected.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-contain/content-visibility/content-visibility-098.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-contain/content-visibility/content-visibility-099-expected.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-contain/content-visibility/content-visibility-099.html: Added. * Source/WebCore/rendering/RenderElement.cpp: (WebCore::RenderElement::styleWillChange): Canonical link: https://commits.webkit.org/273399@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 3d9f01: VideoTrackGenerator muted should apply on the sink...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 3d9f01080b2343ad3a745b960335daf6556cb921 https://github.com/WebKit/WebKit/commit/3d9f01080b2343ad3a745b960335daf6556cb921 Author: Youenn Fablet Date: 2024-01-24 (Wed, 24 Jan 2024) Changed paths: M LayoutTests/http/wpt/mediastream/worker-mediastreamtrack.worker-expected.txt M LayoutTests/http/wpt/mediastream/worker-mediastreamtrack.worker.js M Source/WebCore/Modules/mediastream/VideoTrackGenerator.cpp Log Message: --- VideoTrackGenerator muted should apply on the sink synchronously https://bugs.webkit.org/show_bug.cgi?id=267931 rdar://121449466 Reviewed by Eric Carlson. We synchronously update the muted slot as defined by the spec. Covered by added test. * LayoutTests/http/wpt/mediastream/worker-mediastreamtrack.worker-expected.txt: * LayoutTests/http/wpt/mediastream/worker-mediastreamtrack.worker.js: (makeOffscreenCanvasVideoFrame): (promise_test.async t): * Source/WebCore/Modules/mediastream/VideoTrackGenerator.cpp: (WebCore::VideoTrackGenerator::setMuted): Canonical link: https://commits.webkit.org/273398@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 4d9799: Update MediaStreamTrack contentHint and kind imple...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 4d979907052d94f13720d299fccfe1fe47175216 https://github.com/WebKit/WebKit/commit/4d979907052d94f13720d299fccfe1fe47175216 Author: Youenn Fablet Date: 2024-01-24 (Wed, 24 Jan 2024) Changed paths: M LayoutTests/http/wpt/mediastream/worker-mediastreamtrack.worker-expected.txt M LayoutTests/http/wpt/mediastream/worker-mediastreamtrack.worker.js M Source/WebCore/Modules/mediastream/MediaStreamTrack.cpp M Source/WebCore/Modules/mediastream/MediaStreamTrack.h Log Message: --- Update MediaStreamTrack contentHint and kind implementation to handle tracks living in workers https://bugs.webkit.org/show_bug.cgi?id=267930 rdar://121448238 Reviewed by Eric Carlson. Now that tracks can live in workers, we cannot use main thread only atom strings. Update implementation accordingly. * LayoutTests/http/wpt/mediastream/worker-mediastreamtrack.worker-expected.txt: * LayoutTests/http/wpt/mediastream/worker-mediastreamtrack.worker.js: (promise_test.async t): * Source/WebCore/Modules/mediastream/MediaStreamTrack.cpp: (WebCore::MediaStreamTrack::kind const): (WebCore::contentHintToAtomString): (WebCore::MediaStreamTrack::contentHint const): (WebCore::MediaStreamTrack::setContentHint): * Source/WebCore/Modules/mediastream/MediaStreamTrack.h: Canonical link: https://commits.webkit.org/273397@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] d1ab07: Make MediaStreamTrackProcessor::VideoFrameObserver...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: d1ab07a92e50d93ef8f4a342d9a0478307c9d1bc https://github.com/WebKit/WebKit/commit/d1ab07a92e50d93ef8f4a342d9a0478307c9d1bc Author: Youenn Fablet Date: 2024-01-24 (Wed, 24 Jan 2024) Changed paths: M Source/WebCore/Modules/mediastream/MediaStreamTrackProcessor.cpp M Source/WebCore/Modules/mediastream/MediaStreamTrackProcessor.h Log Message: --- Make MediaStreamTrackProcessor::VideoFrameObserverWrapper::m_observer a UniqueRef rdar://121372402 https://bugs.webkit.org/show_bug.cgi?id=267853 Reviewed by Eric Carlson. A UniqueRef is better than a std::unique_ptr and we do not need the initialize method any longer. * Source/WebCore/Modules/mediastream/MediaStreamTrackProcessor.cpp: (WebCore::MediaStreamTrackProcessor::VideoFrameObserverWrapper::create): (WebCore::MediaStreamTrackProcessor::VideoFrameObserverWrapper::VideoFrameObserverWrapper): (WebCore::MediaStreamTrackProcessor::VideoFrameObserverWrapper::initialize): Deleted. * Source/WebCore/Modules/mediastream/MediaStreamTrackProcessor.h: Canonical link: https://commits.webkit.org/273396@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 23402d: Use std::variant and std::optional as storage for ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 23402d69a57f55e6a557868d128bc4a6b5c75068 https://github.com/WebKit/WebKit/commit/23402d69a57f55e6a557868d128bc4a6b5c75068 Author: Alex Christensen Date: 2024-01-24 (Wed, 24 Jan 2024) Changed paths: M Source/WTF/wtf/Expected.h M Source/WebKit/Platform/IPC/Connection.h Log Message: --- Use std::variant and std::optional as storage for WTF::Expected https://bugs.webkit.org/show_bug.cgi?id=267956 rdar://121471408 Reviewed by Fujii Hironori. Our Expected interface is 7 paper revisions behind https://wg21.link/P0323R11 It has all kinds of issues with trivially copyable and trivially destructable types that have been solved since https://wg21.link/P0323R4 and it's in C++23 which we can't use for another few months. Until then, just use std::optional and std::variant as the storage, where these problems have also already been solved. * Source/WTF/wtf/Expected.h: (std::experimental::fundamentals_v3::__expected_detail::base::base): (std::experimental::fundamentals_v3::__expected_detail::voidbase::voidbase): (std::experimental::fundamentals_v3::expected::expected): (std::experimental::fundamentals_v3::expected::swap): (std::experimental::fundamentals_v3::expected::operator-> const): (std::experimental::fundamentals_v3::expected::operator->): (std::experimental::fundamentals_v3::expected::operator* const): (std::experimental::fundamentals_v3::expected::operator*): (std::experimental::fundamentals_v3::expected::operator bool const): (std::experimental::fundamentals_v3::expected::has_value const): (std::experimental::fundamentals_v3::expected::value const): (std::experimental::fundamentals_v3::expected::value): (std::experimental::fundamentals_v3::expected::error const): (std::experimental::fundamentals_v3::expected::error): (std::experimental::fundamentals_v3::expected::value_or const): (std::experimental::fundamentals_v3::expected::value_or): (std::experimental::fundamentals_v3::__expected_detail::destroy): Deleted. (std::experimental::fundamentals_v3::__expected_detail::std::is_trivially_destructible::value): Deleted. (std::experimental::fundamentals_v3::__expected_detail::constexpr_base::constexpr_base): Deleted. (std::experimental::fundamentals_v3::__expected_detail::base::~base): Deleted. * Source/WebKit/Platform/IPC/Connection.h: Canonical link: https://commits.webkit.org/273395@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
