[webkit-changes] [WebKit/WebKit] 6b46c2: Fix build failed for riscv64
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 6b46c24db81426c056f4f1f6fe915c2cdd687a1e https://github.com/WebKit/WebKit/commit/6b46c24db81426c056f4f1f6fe915c2cdd687a1e Author: luyahan Date: 2024-02-03 (Sat, 03 Feb 2024) Changed paths: M Source/JavaScriptCore/assembler/RISCV64Assembler.h M Source/JavaScriptCore/offlineasm/riscv64.rb Log Message: --- Fix build failed for riscv64 https://bugs.webkit.org/show_bug.cgi?id=266218 Reviewed by Yusuke Suzuki. fix the build error * RISCV64.patch: Added. * Source/JavaScriptCore/assembler/RISCV64Assembler.h: * Source/JavaScriptCore/offlineasm/riscv64.rb: Canonical link: https://commits.webkit.org/274066@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] e89a58: [threaded-animation-resolution] Schedule animation...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: e89a58c3716a2cee16351e230a760ed8e8e0358e https://github.com/WebKit/WebKit/commit/e89a58c3716a2cee16351e230a760ed8e8e0358e Author: Matt Woodrow Date: 2024-02-03 (Sat, 03 Feb 2024) Changed paths: M Source/WebKit/UIProcess/RemoteLayerTree/RemoteAcceleratedEffectStack.h M Source/WebKit/UIProcess/RemoteLayerTree/RemoteAcceleratedEffectStack.mm M Source/WebKit/UIProcess/RemoteLayerTree/RemoteLayerTreeDrawingAreaProxy.h M Source/WebKit/UIProcess/RemoteLayerTree/RemoteLayerTreeNode.mm M Source/WebKit/UIProcess/RemoteLayerTree/ios/RemoteLayerTreeDrawingAreaProxyIOS.h M Source/WebKit/UIProcess/RemoteLayerTree/ios/RemoteLayerTreeDrawingAreaProxyIOS.mm M Source/WebKit/UIProcess/RemoteLayerTree/ios/RemoteScrollingCoordinatorProxyIOS.h M Source/WebKit/UIProcess/RemoteLayerTree/ios/RemoteScrollingCoordinatorProxyIOS.mm Log Message: --- [threaded-animation-resolution] Schedule animation updates from RemoteScrollingCoordinatorProxy on the main thread https://bugs.webkit.org/show_bug.cgi?id=268282 rdar://121839192 Reviewed by Simon Fraser. In 273391@main we added support for scheduling animation resolution for macOS via RemoteLayerTreeEventDispatcher. On iOS, where we don't use a scrolling thread, we schedule animations through RemoteScrollingCoordinatorProxy using a dedicated CADisplayLink in a new WKAnimationDisplayLinkHandler. When that display link fires, we resolve animations on the main thread by calling the new RemoteAcceleratedEffectStack::applyEffectsFromMainThread(). * Source/WebKit/UIProcess/RemoteLayerTree/RemoteAcceleratedEffectStack.h: * Source/WebKit/UIProcess/RemoteLayerTree/RemoteAcceleratedEffectStack.mm: (WebKit::RemoteAcceleratedEffectStack::applyEffectsFromMainThread const): * Source/WebKit/UIProcess/RemoteLayerTree/RemoteLayerTreeNode.mm: (WebKit::RemoteLayerTreeNode::setAcceleratedEffectsAndBaseValues): * Source/WebKit/UIProcess/RemoteLayerTree/ios/RemoteScrollingCoordinatorProxyIOS.h: * Source/WebKit/UIProcess/RemoteLayerTree/ios/RemoteScrollingCoordinatorProxyIOS.mm: (-[WKAnimationDisplayLinkHandler initWithCoordinator:]): (-[WKAnimationDisplayLinkHandler dealloc]): (-[WKAnimationDisplayLinkHandler displayLinkFired:]): (-[WKAnimationDisplayLinkHandler invalidate]): (-[WKAnimationDisplayLinkHandler schedule]): (-[WKAnimationDisplayLinkHandler pause]): (WebKit::RemoteScrollingCoordinatorProxyIOS::~RemoteScrollingCoordinatorProxyIOS): (WebKit::RemoteScrollingCoordinatorProxyIOS::animationsWereAddedToNode): (WebKit::RemoteScrollingCoordinatorProxyIOS::animationsWereRemovedFromNode): (WebKit::RemoteScrollingCoordinatorProxyIOS::updateAnimations): Canonical link: https://commits.webkit.org/274065@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] bacdbd: [JSC] Micro-optimize String equal operation with U...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: bacdbdaaf1824b08dc7ad35035d5d8358be623c5 https://github.com/WebKit/WebKit/commit/bacdbdaaf1824b08dc7ad35035d5d8358be623c5 Author: Yusuke Suzuki Date: 2024-02-03 (Sat, 03 Feb 2024) Changed paths: M Source/WTF/wtf/text/StringCommon.h Log Message: --- [JSC] Micro-optimize String equal operation with UChar / LChar https://bugs.webkit.org/show_bug.cgi?id=268684 rdar://14476 Reviewed by Ryosuke Niwa. This patch micro-optimizes String equal operation with different characters (UChar* and LChar*). ToT Patched todomvc-javascript-es5-json-parse 37.6466+-0.1862 ^ 37.1991+-0.1560^ definitely 1.0120x faster todomvc-javascript-es6-webpack-json-parse 58.9239+-0.3310 ^ 58.2251+-0.1931^ definitely 1.0120x faster * Source/WTF/wtf/text/StringCommon.h: Canonical link: https://commits.webkit.org/274064@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 55c8a5: Rename `Cloneable` to `Clonable` to align with Web...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 55c8a567ee56cf6f488c2a1d6a7675088204bea7 https://github.com/WebKit/WebKit/commit/55c8a567ee56cf6f488c2a1d6a7675088204bea7 Author: Ahmad Saleem Date: 2024-02-03 (Sat, 03 Feb 2024) Changed paths: A LayoutTests/fast/shadow-dom/clonable-shadow-root-expected.txt A LayoutTests/fast/shadow-dom/clonable-shadow-root.html R LayoutTests/fast/shadow-dom/cloneable-shadow-root-expected.txt R LayoutTests/fast/shadow-dom/cloneable-shadow-root.html M Source/WebCore/dom/Element.cpp M Source/WebCore/dom/Range.cpp M Source/WebCore/dom/ShadowRoot.cpp M Source/WebCore/dom/ShadowRoot.h M Source/WebCore/dom/ShadowRoot.idl M Source/WebCore/dom/ShadowRootInit.h M Source/WebCore/dom/ShadowRootInit.idl Log Message: --- Rename `Cloneable` to `Clonable` to align with Web Specification wording https://bugs.webkit.org/show_bug.cgi?id=267634 rdar://problem/121516711 Reviewed by Ryosuke Niwa. This patch is just rename of `cloneable` to `clonable` as per web-specification [1]: [1] https://dom.spec.whatwg.org/#shadowroot-clonable * Source/WebCore/dom/ShadowRoot.cpp: (ShadowRoot::ShadowRoot): (ShadowRoot::cloneNodeInternal): * Source/WebCore/dom/ShadowRoot.h: * Source/WebCore/dom/ShadowRoot.idl: * Source/WebCore/dom/ShadowRootInit.h: * LayoutTests/fast/shadow-dom/clonable-shadow-root.html: Renamed from LayoutTests/fast/shadow-dom/cloneable-shadow-root.html and rebaselined * LayoutTests/fast/shadow-dom/clonable-shadow-root-expected.txt: Renamed from LayoutTests/fast/shadow-dom/cloneable-shadow-root-expected.txt and rebaselined Canonical link: https://commits.webkit.org/274063@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 817b93: Generate serialization of CFArrayRef
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 817b93374cbff38a0b7693d8b316219157b68478 https://github.com/WebKit/WebKit/commit/817b93374cbff38a0b7693d8b316219157b68478 Author: Alex Christensen Date: 2024-02-03 (Sat, 03 Feb 2024) Changed paths: M Source/WebKit/DerivedSources-input.xcfilelist M Source/WebKit/DerivedSources.make M Source/WebKit/Shared/Cocoa/ArgumentCodersCocoa.h M Source/WebKit/Shared/Cocoa/ArgumentCodersCocoa.mm M Source/WebKit/Shared/Cocoa/CoreIPCCFType.h M Source/WebKit/Shared/Cocoa/CoreIPCCFType.serialization.in A Source/WebKit/Shared/Cocoa/CoreIPCRetainPtr.h M Source/WebKit/Shared/cf/ArgumentCodersCF.cpp M Source/WebKit/Shared/cf/ArgumentCodersCF.h M Source/WebKit/Shared/cf/CFTypes.serialization.in A Source/WebKit/Shared/cf/CoreIPCCFArray.h A Source/WebKit/Shared/cf/CoreIPCCFArray.mm A Source/WebKit/Shared/cf/CoreIPCCFArray.serialization.in M Source/WebKit/WebKit.xcodeproj/project.pbxproj Log Message: --- Generate serialization of CFArrayRef https://bugs.webkit.org/show_bug.cgi?id=268700 Reviewed by Brady Eidson. To retain existing behavior, we need a type distinct from CoreIPCArray which wraps NSArray. The day may come when all our array serialization specifies what is inside the array, but until then we need CoreIPCCFArray. Covered by tests from 274048@main * Source/WebKit/DerivedSources-input.xcfilelist: * Source/WebKit/DerivedSources.make: * Source/WebKit/Shared/Cocoa/ArgumentCodersCocoa.h: (IPC::ArgumentCoder>::encode): (IPC::CoreIPCRetainPtr::CoreIPCRetainPtr): Deleted. * Source/WebKit/Shared/Cocoa/ArgumentCodersCocoa.mm: (IPC::encodeObjectDirectly): * Source/WebKit/Shared/Cocoa/CoreIPCCFType.h: * Source/WebKit/Shared/Cocoa/CoreIPCCFType.serialization.in: * Source/WebKit/Shared/Cocoa/CoreIPCRetainPtr.h: Copied from Source/WebKit/Shared/Cocoa/CoreIPCCFType.h. (IPC::CoreIPCRetainPtr::CoreIPCRetainPtr): * Source/WebKit/Shared/cf/ArgumentCodersCF.cpp: (IPC::typeFromCFTypeRef): (IPC::ArgumentCoder::encode): Deleted. (IPC::ArgumentCoder>::decode): Deleted. * Source/WebKit/Shared/cf/ArgumentCodersCF.h: * Source/WebKit/Shared/cf/CFTypes.serialization.in: * Source/WebKit/Shared/cf/CoreIPCCFArray.h: Copied from Source/WebKit/Shared/Cocoa/CoreIPCCFType.h. (WebKit::CoreIPCCFArray::CoreIPCCFArray): (WebKit::CoreIPCCFArray::array const): * Source/WebKit/Shared/cf/CoreIPCCFArray.mm: Copied from Source/WebKit/Shared/Cocoa/CoreIPCCFType.h. (WebKit::CoreIPCCFArray::CoreIPCCFArray): (WebKit::CoreIPCCFArray::createCFArray const): * Source/WebKit/Shared/cf/CoreIPCCFArray.serialization.in: Copied from Source/WebKit/Shared/Cocoa/CoreIPCCFType.serialization.in. * Source/WebKit/WebKit.xcodeproj/project.pbxproj: Canonical link: https://commits.webkit.org/274062@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 5ffedc: Clarify the role of "mainFrameCanRubberBand" at th...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 5ffedc5fb9606192a9b87137b74788c6efa93d70 https://github.com/WebKit/WebKit/commit/5ffedc5fb9606192a9b87137b74788c6efa93d70 Author: Simon Fraser Date: 2024-02-03 (Sat, 03 Feb 2024) Changed paths: M Source/WebCore/page/scrolling/ScrollingTree.cpp M Source/WebCore/page/scrolling/ScrollingTree.h M Source/WebCore/page/scrolling/mac/ScrollingTreeScrollingNodeDelegateMac.mm M Source/WebKit/UIProcess/RemoteLayerTree/RemoteScrollingCoordinatorProxy.cpp M Source/WebKit/UIProcess/RemoteLayerTree/mac/RemoteLayerTreeEventDispatcher.cpp M Source/WebKit/WebProcess/WebPage/EventDispatcher.cpp Log Message: --- Clarify the role of "mainFrameCanRubberBand" at the ScrollingTree level https://bugs.webkit.org/show_bug.cgi?id=268697 rdar://122242780 Reviewed by Tim Horton. ScrollingTree::mainFrameCanRubberBandOnSide() is easy to mis-use: it doesn't mean that rubber-banding will happen, only that the client (Safari, Mail etc) has allowed rubber-banding to happen on this side. So rename it accordingly. This make it clear that `ScrollingTreeScrollingNodeDelegateMac::shouldRubberBandOnSide()` isn't using it correctly. Future changes will fix that. * Source/WebCore/page/scrolling/ScrollingTree.cpp: (WebCore::ScrollingTree::setClientAllowedMainFrameRubberBandableEdges): (WebCore::ScrollingTree::clientAllowsMainFrameRubberBandingOnSide): (WebCore::ScrollingTree::willWheelEventStartSwipeGesture): (WebCore::ScrollingTree::setMainFrameCanRubberBand): Deleted. (WebCore::ScrollingTree::mainFrameCanRubberBandOnSide): Deleted. * Source/WebCore/page/scrolling/ScrollingTree.h: * Source/WebCore/page/scrolling/mac/ScrollingTreeScrollingNodeDelegateMac.mm: (WebCore::ScrollingTreeScrollingNodeDelegateMac::shouldRubberBandOnSide const): * Source/WebKit/UIProcess/RemoteLayerTree/RemoteScrollingCoordinatorProxy.cpp: (WebKit::RemoteScrollingCoordinatorProxy::handleWheelEvent): * Source/WebKit/UIProcess/RemoteLayerTree/mac/RemoteLayerTreeEventDispatcher.cpp: (WebKit::RemoteLayerTreeEventDispatcher::determineWheelEventProcessing): * Source/WebKit/WebProcess/WebPage/EventDispatcher.cpp: (WebKit::EventDispatcher::internalWheelEvent): Canonical link: https://commits.webkit.org/274061@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] f232a5: Adopt more smart pointers in CachedRawResource and...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: f232a5d1d6e79c12e69a9aaa4e145c3523f9a66f https://github.com/WebKit/WebKit/commit/f232a5d1d6e79c12e69a9aaa4e145c3523f9a66f Author: Chris Dumez Date: 2024-02-03 (Sat, 03 Feb 2024) Changed paths: M Source/WebCore/loader/FrameLoader.cpp M Source/WebCore/loader/FrameLoader.h M Source/WebCore/loader/cache/CachedRawResource.cpp M Source/WebCore/loader/cache/CachedResource.cpp M Source/WebCore/loader/cache/CachedResource.h Log Message: --- Adopt more smart pointers in CachedRawResource and CachedResource https://bugs.webkit.org/show_bug.cgi?id=268702 Reviewed by Darin Adler. * Source/WebCore/loader/FrameLoader.cpp: (WebCore::FrameLoader::protectedActiveDocumentLoader const): * Source/WebCore/loader/FrameLoader.h: * Source/WebCore/loader/cache/CachedRawResource.cpp: (WebCore::CachedRawResource::updateBuffer): (WebCore::CachedRawResource::finishLoading): (WebCore::CachedRawResource::notifyClientsDataWasReceived): (WebCore::CachedRawResource::didAddClient): (WebCore::CachedRawResource::allClientsRemoved): (WebCore::CachedRawResource::redirectReceived): (WebCore::CachedRawResource::responseReceived): (WebCore::CachedRawResource::setDefersLoading): (WebCore::CachedRawResource::clear): (WebCore::CachedRawResource::previewResponseReceived): * Source/WebCore/loader/cache/CachedResource.cpp: (WebCore::CachedResource::load): (WebCore::CachedResource::cancelLoad): (WebCore::CachedResource::allClientsRemoved): (WebCore::CachedResource::deleteIfPossible): (WebCore::CachedResource::setResourceToRevalidate): (WebCore::CachedResource::switchClientsToRevalidatedResource): (WebCore::CachedResource::varyHeaderValuesMatch): (WebCore::CachedResource::protectedResourceToRevalidate const): (WebCore::CachedResource::protectedCookieJar const): (WebCore::CachedResource::Callback::timerFired): (WebCore::CachedResource::tryReplaceEncodedData): Deleted. (WebCore::CachedResource::previewResponseReceived): Deleted. (WebCore::CachedResource::cryptographicDigest const): Deleted. * Source/WebCore/loader/cache/CachedResource.h: (WebCore::CachedResource::isCacheValidator const): (WebCore::CachedResource::resourceToRevalidate const): (WebCore::CachedResource::validationInProgress const): Canonical link: https://commits.webkit.org/274060@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 2c75a8: Adopt more smart pointers in CachedImage.cpp
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 2c75a8c92adbc1751c0a558dc443b306cc1189b3 https://github.com/WebKit/WebKit/commit/2c75a8c92adbc1751c0a558dc443b306cc1189b3 Author: Chris Dumez Date: 2024-02-03 (Sat, 03 Feb 2024) Changed paths: M Source/WebCore/loader/cache/CachedImage.cpp M Source/WebCore/loader/cache/CachedImage.h M Source/WebCore/rendering/RenderImage.cpp Log Message: --- Adopt more smart pointers in CachedImage.cpp https://bugs.webkit.org/show_bug.cgi?id=268699 Reviewed by Ryosuke Niwa and Darin Adler. * Source/WebCore/loader/cache/CachedImage.cpp: (WebCore::CachedImage::setBodyDataFrom): (WebCore::CachedImage::didAddClient): (WebCore::CachedImage::switchClientsToRevalidatedResource): (WebCore::CachedImage::allClientsRemoved): (WebCore::CachedImage::brokenImage const): (WebCore::CachedImage::image const): (WebCore::CachedImage::imageForRenderer): (WebCore::CachedImage::setContainerContextForClient): (WebCore::CachedImage::imageSizeForRenderer const): (WebCore::CachedImage::computeIntrinsicDimensions): (WebCore::CachedImage::createImage): (WebCore::CachedImage::CachedImageObserver::encodedDataStatusChanged): (WebCore::CachedImage::CachedImageObserver::decodedSizeChanged): (WebCore::CachedImage::CachedImageObserver::didDraw): (WebCore::CachedImage::CachedImageObserver::canDestroyDecodedData): (WebCore::CachedImage::CachedImageObserver::imageFrameAvailable): (WebCore::CachedImage::CachedImageObserver::changedInRect): (WebCore::CachedImage::CachedImageObserver::scheduleRenderingUpdate): (WebCore::CachedImage::CachedImageObserver::allowsAnimation const): (WebCore::CachedImage::clearImage): (WebCore::CachedImage::updateBufferInternal): (WebCore::CachedImage::updateImageData): (WebCore::CachedImage::didReplaceSharedBufferContents): (WebCore::CachedImage::destroyDecodedData): (WebCore::CachedImage::imageFrameAvailable): (WebCore::CachedImage::currentFrameKnownToBeOpaque): * Source/WebCore/loader/cache/CachedImage.h: * Source/WebCore/rendering/RenderImage.cpp: (WebCore::RenderImage::imageSizeForError const): (WebCore::RenderImage::paintReplaced): Canonical link: https://commits.webkit.org/274059@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 99c494: [WPT] Sync css/css-color
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 99c494742988f1c942b9afb99b37d01ef33bd596 https://github.com/WebKit/WebKit/commit/99c494742988f1c942b9afb99b37d01ef33bd596 Author: Matthieu Dubet Date: 2024-02-03 (Sat, 03 Feb 2024) Changed paths: M LayoutTests/TestExpectations M LayoutTests/imported/w3c/resources/resource-files.json M LayoutTests/imported/w3c/web-platform-tests/css/css-color/deprecated-sameas-002-expected.html M LayoutTests/imported/w3c/web-platform-tests/css/css-color/deprecated-sameas-002.html A LayoutTests/imported/w3c/web-platform-tests/css/css-color/light-dark-currentcolor-in-color-expected.txt A LayoutTests/imported/w3c/web-platform-tests/css/css-color/light-dark-currentcolor-in-color.html M LayoutTests/imported/w3c/web-platform-tests/css/css-color/parsing/color-computed-relative-color-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/css-color/parsing/color-computed-relative-color.html M LayoutTests/imported/w3c/web-platform-tests/css/css-color/parsing/color-invalid-relative-color-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/css-color/parsing/color-invalid-relative-color.html M LayoutTests/imported/w3c/web-platform-tests/css/css-color/system-color-support-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/css-color/system-color-support.html M LayoutTests/imported/w3c/web-platform-tests/css/css-color/w3c-import.log A LayoutTests/platform/gtk/imported/w3c/web-platform-tests/css/css-color/system-color-support-expected.txt A LayoutTests/platform/ios/imported/w3c/web-platform-tests/css/css-color/system-color-support-expected.txt Log Message: --- [WPT] Sync css/css-color https://bugs.webkit.org/show_bug.cgi?id=268589 rdar://122141796 Reviewed by Tim Nguyen. WPT @ 747837a9c8e7eea63593e35852c7d22b697af96f * LayoutTests/TestExpectations: * LayoutTests/imported/w3c/resources/resource-files.json: * LayoutTests/imported/w3c/web-platform-tests/css/css-color/deprecated-sameas-002-expected.html: * LayoutTests/imported/w3c/web-platform-tests/css/css-color/deprecated-sameas-002.html: * LayoutTests/imported/w3c/web-platform-tests/css/css-color/light-dark-currentcolor-in-color-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-color/light-dark-currentcolor-in-color.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-color/parsing/color-computed-relative-color-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-color/parsing/color-computed-relative-color.html: * LayoutTests/imported/w3c/web-platform-tests/css/css-color/parsing/color-invalid-relative-color-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-color/parsing/color-invalid-relative-color.html: * LayoutTests/imported/w3c/web-platform-tests/css/css-color/system-color-support-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-color/system-color-support.html: * LayoutTests/imported/w3c/web-platform-tests/css/css-color/w3c-import.log: * LayoutTests/platform/gtk/imported/w3c/web-platform-tests/css/css-color/system-color-support-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/css/css-color/system-color-support-expected.txt. * LayoutTests/platform/ios/imported/w3c/web-platform-tests/css/css-color/system-color-support-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/css/css-color/system-color-support-expected.txt. Canonical link: https://commits.webkit.org/274058@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 7c6244: AX: The value of date time fields is not read by V...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 7c62441425c1b526d401600066914c8eb8b006ac https://github.com/WebKit/WebKit/commit/7c62441425c1b526d401600066914c8eb8b006ac Author: Andres Gonzalez Date: 2024-02-03 (Sat, 03 Feb 2024) Changed paths: M LayoutTests/accessibility/date-input-aria-label-and-value-expected.txt M LayoutTests/accessibility/date-input-aria-label-and-value.html A LayoutTests/accessibility/input-time-label-value-expected.txt A LayoutTests/accessibility/input-time-label-value.html R LayoutTests/accessibility/ios-simulator/input-type-time-expected.txt R LayoutTests/accessibility/ios-simulator/input-type-time.html A LayoutTests/platform/gtk/accessibility/input-time-label-value-expected.txt M LayoutTests/platform/ios-simulator/accessibility/changing-aria-hidden-with-display-none-parent-expected.txt M LayoutTests/platform/ios/TestExpectations A LayoutTests/platform/ios/accessibility/input-time-label-value-expected.txt A LayoutTests/platform/mac-monterey/accessibility/input-time-label-value-expected.txt M LayoutTests/platform/mac-wk1/TestExpectations A LayoutTests/platform/wpe/accessibility/input-time-label-value-expected.txt M Source/WebCore/accessibility/AXCoreObject.h M Source/WebCore/accessibility/AXObjectCache.cpp M Source/WebCore/accessibility/AccessibilityNodeObject.cpp M Source/WebCore/accessibility/AccessibilityObject.cpp M Source/WebCore/accessibility/AccessibilityObject.h M Source/WebCore/accessibility/AccessibilityRenderObject.cpp M Source/WebCore/accessibility/AccessibilitySpinButton.h M Source/WebCore/accessibility/atspi/AccessibilityObjectAtspi.cpp M Source/WebCore/accessibility/ios/AccessibilityObjectIOS.mm M Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm M Source/WebCore/accessibility/mac/AccessibilityObjectMac.mm M Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm M Tools/WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm Log Message: --- AX: The value of date time fields is not read by VoiceOver when the VO cursor lands on them. https://bugs.webkit.org/show_bug.cgi?id=268523 Reviewed by Tyler Wilcock. This patch fixes the problem by providing a proper implementation for the stringValue() method in the case of a date time field. Some iOS-specific code to handle date time fields was re-worked and promoted to core code to make this fix possible in all platforms. The patch includes the following changes: - Added a DateTime role to describe this family of elements. - Map this role to its appropriate platform properties. - Fix in AccessibilityRenderObject::stringValue(). - Code cleanup. * LayoutTests/accessibility/date-input-aria-label-and-value-expected.txt: * LayoutTests/accessibility/date-input-aria-label-and-value.html: Re-wrote this test according to our current standards, and simplified and made clear the code. * LayoutTests/accessibility/input-time-label-value-expected.txt: Added. * LayoutTests/accessibility/input-time-label-value.html: Added. Promoted this test from ios-simulator to all platforms. Also modernized and cleaned up the code. * LayoutTests/accessibility/ios-simulator/input-type-time-expected.txt: Removed. * LayoutTests/accessibility/ios-simulator/input-type-time.html: Removed. Became input-time-label-value.html above. * LayoutTests/platform/gtk/accessibility/input-time-label-value-expected.txt: Added. * LayoutTests/platform/ios-simulator/accessibility/changing-aria-hidden-with-display-none-parent-expected.txt: Rebased because now AccessibilityUIElement::title returns something on iOS, before returned null. * LayoutTests/platform/ios/TestExpectations: * LayoutTests/platform/ios/accessibility/input-time-label-value-expected.txt: Added. * LayoutTests/platform/mac-wk1/TestExpectations: * LayoutTests/platform/wpe/accessibility/input-time-label-value-expected.txt: Added. * Source/WebCore/accessibility/AXCoreObject.h: (WebCore::accessibilityRoleToString): (WebCore::AXCoreObject::isDateTime const): * Source/WebCore/accessibility/AXObjectCache.cpp: (WebCore::AXObjectCache::create): * Source/WebCore/accessibility/AccessibilityNodeObject.cpp: (WebCore::AccessibilityNodeObject::determineAccessibilityRoleFromNode const): * Source/WebCore/accessibility/AccessibilityObject.cpp: (WebCore::initializeRoleMap): * Source/WebCore/accessibility/AccessibilityObject.h: * Source/WebCore/accessibility/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::stringValue const): (WebCore::AccessibilityRenderObject::addTextFieldChildren): * Source/WebCore/accessibility/AccessibilitySpinButton.h: * Source/WebCore/accessibility/atspi/AccessibilityObjectAtspi.cpp: (WebCore::atspiRole): * Source/WebCore/accessibility/ios/AccessibilityObjectIOS.mm: (WebCore::AccessibilityObject::isInputTypePopupButton const): Deleted. * Source/WebCore/accessibil
[webkit-changes] [WebKit/WebKit] 1a2dfd: [UnifiedPDF] UnifiedPDFPlugin should handle the "s...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 1a2dfd4eb52baf164e5bab30cf957e0596812571 https://github.com/WebKit/WebKit/commit/1a2dfd4eb52baf164e5bab30cf957e0596812571 Author: Abrar Rahman Protyasha Date: 2024-02-03 (Sat, 03 Feb 2024) Changed paths: M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.h M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm Log Message: --- [UnifiedPDF] UnifiedPDFPlugin should handle the "selectAll" editing command https://bugs.webkit.org/show_bug.cgi?id=268689 rdar://122230652 Reviewed by Simon Fraser. Following the added support for selection tracking in 274032@main, it is trivial for the UnifiedPDFPlugin to handle the "selectAll" editing command. The plugin does so by simply querying PDFDocument for a selection representing text for the entire document, and then overriding the currently tracked selection. * Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.h: * Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm: (WebKit::UnifiedPDFPlugin::handleKeyboardEvent): (WebKit::UnifiedPDFPlugin::handleEditingCommand): (WebKit::UnifiedPDFPlugin::isEditingCommandEnabled): (WebKit::UnifiedPDFPlugin::forwardEditingCommandToEditor const): (WebKit::UnifiedPDFPlugin::selectAll): Canonical link: https://commits.webkit.org/274056@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 0aa3d4: [Painting] Default gap is only used by computedUnd...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 0aa3d40bc28f2e815c92c9ec6a4c1fc841e22609 https://github.com/WebKit/WebKit/commit/0aa3d40bc28f2e815c92c9ec6a4c1fc841e22609 Author: Alan Baradlay Date: 2024-02-03 (Sat, 03 Feb 2024) Changed paths: M LayoutTests/fast/inline/text-decoration-underline-inline-box-offset-expected.html M LayoutTests/fast/inline/text-decoration-underline-inline-box-offset.html M Source/WebCore/style/InlineTextBoxStyle.cpp Log Message: --- [Painting] Default gap is only used by computedUnderlineOffset https://bugs.webkit.org/show_bug.cgi?id=268692 Reviewed by Antti Koivisto. This is in preparation for adding text-underline left/right painting support. Remove defaultGap from UnderlineOffsetArguments struct and instead call the helper function directly from computedUnderlineOffset (only place where it is used) (test case change: let's go back to the initial test case with Ahem font now. The test update had incorrect assumptions about what was being tested here.) * Source/WebCore/style/InlineTextBoxStyle.cpp: (WebCore::defaultGap): (WebCore::computedUnderlineOffset): (WebCore::visualOverflowForDecorations): (WebCore::underlineOffsetForTextBoxPainting): Canonical link: https://commits.webkit.org/274055@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 9f7a7a: BELayerHierarchy should be invalidated
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 9f7a7a918cc5cec7a873b288bf1fa830231777c3 https://github.com/WebKit/WebKit/commit/9f7a7a918cc5cec7a873b288bf1fa830231777c3 Author: Per Arne Vollan Date: 2024-02-03 (Sat, 03 Feb 2024) Changed paths: M Source/WebKit/Platform/cocoa/LayerHostingContext.mm Log Message: --- BELayerHierarchy should be invalidated https://bugs.webkit.org/show_bug.cgi?id=268695 rdar://122238284 Reviewed by Wenson Hsieh. BELayerHierarchy should be invalidated before being deallocated. * Source/WebKit/Platform/cocoa/LayerHostingContext.mm: (WebKit::LayerHostingContext::~LayerHostingContext): Canonical link: https://commits.webkit.org/274054@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] a3c751: [LBSE] Code cleanup after implementing all but one...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: a3c7518b1394db37cb46e4c00c9272d382eacb2f https://github.com/WebKit/WebKit/commit/a3c7518b1394db37cb46e4c00c9272d382eacb2f Author: Nikolas Zimmermann Date: 2024-02-03 (Sat, 03 Feb 2024) Changed paths: M Source/WebCore/rendering/ReferencedSVGResources.cpp M Source/WebCore/rendering/svg/RenderSVGBlock.cpp M Source/WebCore/rendering/svg/RenderSVGContainer.cpp M Source/WebCore/rendering/svg/RenderSVGForeignObject.cpp M Source/WebCore/rendering/svg/RenderSVGGradientStop.cpp M Source/WebCore/rendering/svg/RenderSVGImage.cpp M Source/WebCore/rendering/svg/RenderSVGInline.cpp M Source/WebCore/rendering/svg/RenderSVGModelObject.cpp M Source/WebCore/rendering/svg/RenderSVGModelObject.h M Source/WebCore/rendering/svg/RenderSVGResourceClipper.cpp M Source/WebCore/rendering/svg/RenderSVGResourceMarker.cpp M Source/WebCore/rendering/svg/RenderSVGResourceMasker.cpp M Source/WebCore/rendering/svg/RenderSVGResourcePattern.cpp M Source/WebCore/rendering/svg/RenderSVGRoot.cpp M Source/WebCore/rendering/svg/RenderSVGRoot.h M Source/WebCore/rendering/svg/RenderSVGShape.cpp M Source/WebCore/rendering/svg/RenderSVGText.cpp M Source/WebCore/rendering/svg/SVGContainerLayout.cpp M Source/WebCore/rendering/svg/SVGResourcesCache.cpp M Source/WebCore/rendering/updating/RenderTreeBuilder.cpp M Source/WebCore/rendering/updating/RenderTreeBuilderSVG.cpp M Source/WebCore/rendering/updating/RenderTreeBuilderSVG.h Log Message: --- [LBSE] Code cleanup after implementing all but one resource https://bugs.webkit.org/show_bug.cgi?id=268615 Reviewed by Rob Buis. Remove all usage of SVGRenderingContext.h / SVGResources.h / SVGResourcesCache.h, that is legacy-only code, from LBSE. Turn all static methods in SVGResourcesCache to release assertion, to make sure none of these methods is called from LBSE. Covered by existing tests. * Source/WebCore/rendering/ReferencedSVGResources.cpp: (WebCore::ReferencedSVGResources::referencedSVGResourceIDs): * Source/WebCore/rendering/svg/RenderSVGBlock.cpp: (WebCore::RenderSVGBlock::willBeDestroyed): (WebCore::RenderSVGBlock::styleDidChange): * Source/WebCore/rendering/svg/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::layout): * Source/WebCore/rendering/svg/RenderSVGForeignObject.cpp: (WebCore::RenderSVGForeignObject::layout): * Source/WebCore/rendering/svg/RenderSVGGradientStop.cpp: * Source/WebCore/rendering/svg/RenderSVGImage.cpp: (WebCore::RenderSVGImage::layout): (WebCore::RenderSVGImage::imageChanged): * Source/WebCore/rendering/svg/RenderSVGInline.cpp: (WebCore::RenderSVGInline::willBeDestroyed): (WebCore::RenderSVGInline::styleDidChange): * Source/WebCore/rendering/svg/RenderSVGModelObject.cpp: (WebCore::RenderSVGModelObject::styleDidChange): (WebCore::RenderSVGModelObject::willBeDestroyed): Deleted. * Source/WebCore/rendering/svg/RenderSVGModelObject.h: * Source/WebCore/rendering/svg/RenderSVGResourceClipper.cpp: * Source/WebCore/rendering/svg/RenderSVGResourceMarker.cpp: * Source/WebCore/rendering/svg/RenderSVGResourceMasker.cpp: * Source/WebCore/rendering/svg/RenderSVGResourcePattern.cpp: * Source/WebCore/rendering/svg/RenderSVGRoot.cpp: (WebCore::RenderSVGRoot::layout): (WebCore::RenderSVGRoot::layoutChildren): (WebCore::RenderSVGRoot::paintObject): (WebCore::RenderSVGRoot::willBeDestroyed): (WebCore::RenderSVGRoot::insertedIntoTree): Deleted. (WebCore::RenderSVGRoot::willBeRemovedFromTree): Deleted. (WebCore::RenderSVGRoot::styleDidChange): Deleted. (WebCore::RenderSVGRoot::addResourceForClientInvalidation): Deleted. * Source/WebCore/rendering/svg/RenderSVGRoot.h: * Source/WebCore/rendering/svg/RenderSVGShape.cpp: (WebCore::RenderSVGShape::layout): * Source/WebCore/rendering/svg/RenderSVGText.cpp: (WebCore::RenderSVGText::layout): * Source/WebCore/rendering/svg/SVGContainerLayout.cpp: * Source/WebCore/rendering/svg/SVGResourcesCache.cpp: (WebCore::SVGResourcesCache::clientLayoutChanged): (WebCore::SVGResourcesCache::clientStyleChanged): (WebCore::SVGResourcesCache::clientWasAddedToTree): (WebCore::SVGResourcesCache::clientWillBeRemovedFromTree): (WebCore::SVGResourcesCache::clientDestroyed): (WebCore::SVGResourcesCache::resourceDestroyed): * Source/WebCore/rendering/updating/RenderTreeBuilder.cpp: (WebCore::RenderTreeBuilder::attachInternal): (WebCore::RenderTreeBuilder::detach): * Source/WebCore/rendering/updating/RenderTreeBuilderSVG.cpp: (WebCore::RenderTreeBuilder::SVG::attach): (WebCore::RenderTreeBuilder::SVG::detach): * Source/WebCore/rendering/updating/RenderTreeBuilderSVG.h: Canonical link: https://commits.webkit.org/274053@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 71e4e7: [UnifiedPDF] Drive-by style fixes under WebKit/Web...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 71e4e7e3844641aa59c978c77f47d0ebe4b7785a https://github.com/WebKit/WebKit/commit/71e4e7e3844641aa59c978c77f47d0ebe4b7785a Author: Abrar Rahman Protyasha Date: 2024-02-03 (Sat, 03 Feb 2024) Changed paths: M Source/WebKit/WebProcess/Plugins/PDF/PDFPluginBase.mm M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm Log Message: --- [UnifiedPDF] Drive-by style fixes under WebKit/WebProcess/Plugins/PDF https://bugs.webkit.org/show_bug.cgi?id=268688 rdar://122230060 Reviewed by Wenson Hsieh. Namely, we prefer `[retainPtr method:]` over `[retainPtr.get() method:]`, but also, move an annotation to avoid unnecessary ref-churn when calling UnifiedPDFPlugin::setActiveAnnotation. * Source/WebKit/WebProcess/Plugins/PDF/PDFPluginBase.mm: (WebKit::PDFPluginBase::maybeClearHighLatencyDataProviderFlag): * Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm: (WebKit::UnifiedPDFPlugin::handleMouseEvent): (WebKit::UnifiedPDFPlugin::continueTrackingSelection): (WebKit::UnifiedPDFPlugin::boundsForAnnotation const): Canonical link: https://commits.webkit.org/274052@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] fe4d36: Port ScriptBuffer to the new IPC serialization format
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: fe4d36309bff66d364e031740d1029b0fd4d692c https://github.com/WebKit/WebKit/commit/fe4d36309bff66d364e031740d1029b0fd4d692c Author: Chris Dumez Date: 2024-02-03 (Sat, 03 Feb 2024) Changed paths: M Source/WebCore/workers/ScriptBuffer.cpp M Source/WebCore/workers/ScriptBuffer.h M Source/WebKit/Shared/WebCoreArgumentCoders.cpp M Source/WebKit/Shared/WebCoreArgumentCoders.h M Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in Log Message: --- Port ScriptBuffer to the new IPC serialization format https://bugs.webkit.org/show_bug.cgi?id=268676 Reviewed by Alex Christensen. * Source/WebCore/workers/ScriptBuffer.cpp: (WebCore::tryConvertToShareableResourceHandle): (WebCore::ScriptBuffer::fromIPCData): (WebCore::ScriptBuffer::ipcData const): * Source/WebCore/workers/ScriptBuffer.h: * Source/WebKit/Shared/WebCoreArgumentCoders.cpp: (IPC::tryConvertToShareableResourceHandle): Deleted. (IPC::ArgumentCoder::encode): Deleted. (IPC::ArgumentCoder::decode): Deleted. * Source/WebKit/Shared/WebCoreArgumentCoders.h: * Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in: Canonical link: https://commits.webkit.org/274051@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 826792: REGRESSION (267163@main): Name for ::slotted pseud...
Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 82679256a4152facc36c85a38532d7196646d886
https://github.com/WebKit/WebKit/commit/82679256a4152facc36c85a38532d7196646d886
Author: Antti Koivisto
Date: 2024-02-03 (Sat, 03 Feb 2024)
Changed paths:
M
LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/container-name-tree-scoped-expected.txt
M
LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/container-name-tree-scoped.html
M Source/WebCore/style/ContainerQueryEvaluator.cpp
Log Message:
---
REGRESSION (267163@main): Name for ::slotted pseudo element inside container
query resolved against wrong scope
https://bugs.webkit.org/show_bug.cgi?id=268683
rdar://14135
Reviewed by Alan Baradlay.
The name in
@container name (width) { ::slotted(*) { } }
is resolved against wrong scope when matching ::slotted.
*
LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/container-name-tree-scoped-expected.txt:
*
LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/container-name-tree-scoped.html:
* Source/WebCore/style/ContainerQueryEvaluator.cpp:
(WebCore::Style::ContainerQueryEvaluator::selectContainer):
Use the host of the originating element () for :host scope resolution
when matching ::slotted() rules.
Canonical link: https://commits.webkit.org/274050@main
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 1b40ca: [Painting] text-underline-position left/right beha...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 1b40ca37b3ff23bf483289e78d10b74c62a3ca11 https://github.com/WebKit/WebKit/commit/1b40ca37b3ff23bf483289e78d10b74c62a3ca11 Author: Alan Baradlay Date: 2024-02-03 (Sat, 03 Feb 2024) Changed paths: M Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayContentBuilder.cpp M Source/WebCore/style/InlineTextBoxStyle.cpp M Source/WebCore/style/InlineTextBoxStyle.h Log Message: --- [Painting] text-underline-position left/right behave as under https://bugs.webkit.org/show_bug.cgi?id=268691 Reviewed by Antti Koivisto. This is in preparation for adding text-underline left/right painting support. 1. Replace resolvedUnderlinePosition with isAlignedForUnder (<- spec term) text-underline-position left/right behave as 'under' in vertical writing mode (also check against current writing mode instead of baseline type) 2. Use isAlignedForUnder() to figure out whether we are dealing with 'under' type of offsetting. Canonical link: https://commits.webkit.org/274049@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] f3054a: Add some tests for CFArrayRef serialization
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: f3054ac4d2cb5b6348a7612c2366c4ba539df389 https://github.com/WebKit/WebKit/commit/f3054ac4d2cb5b6348a7612c2366c4ba539df389 Author: Alex Christensen Date: 2024-02-03 (Sat, 03 Feb 2024) Changed paths: M Source/WebKit/Shared/cf/ArgumentCodersCF.cpp M Tools/TestWebKitAPI/Tests/IPC/IPCSerialization.mm Log Message: --- Add some tests for CFArrayRef serialization https://bugs.webkit.org/show_bug.cgi?id=268681 Reviewed by Brady Eidson. Also make WebKit not assert when things that were previously untested happen. * Source/WebKit/Shared/cf/ArgumentCodersCF.cpp: (IPC::typeFromCFTypeRef): (IPC::ArgumentCoder::encode): (IPC::ArgumentCoder::encode): (IPC::ArgumentCoder::encode): * Tools/TestWebKitAPI/Tests/IPC/IPCSerialization.mm: (secTrustRefsEqual): (cfHolder): (operator==): (operator!=): (arraysEqual): (TEST): (compareSecTrustRefs): Deleted. Canonical link: https://commits.webkit.org/274048@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 4beae4: RemoteImageBufferSetProxy::didPrepareForDisplay ca...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 4beae41dc6154ad2687f21a5fd87d09039e0d2af https://github.com/WebKit/WebKit/commit/4beae41dc6154ad2687f21a5fd87d09039e0d2af Author: Matt Woodrow Date: 2024-02-03 (Sat, 03 Feb 2024) Changed paths: M Source/WebKit/Platform/IPC/StreamClientConnection.cpp M Source/WebKit/Platform/IPC/StreamClientConnection.h M Source/WebKit/Shared/RemoteLayerTree/RemoteLayerWithRemoteRenderingBackingStore.h M Source/WebKit/Shared/RemoteLayerTree/RemoteLayerWithRemoteRenderingBackingStore.mm M Source/WebKit/WebProcess/GPU/graphics/RemoteImageBufferSetProxy.cpp M Source/WebKit/WebProcess/GPU/graphics/RemoteImageBufferSetProxy.h M Source/WebKit/WebProcess/GPU/graphics/RemoteImageBufferSetProxy.messages.in M Source/WebKit/WebProcess/GPU/graphics/RemoteRenderingBackendProxy.cpp M Source/WebKit/WebProcess/GPU/graphics/RemoteRenderingBackendProxy.h Log Message: --- RemoteImageBufferSetProxy::didPrepareForDisplay can be blocked by other main thread task. https://bugs.webkit.org/show_bug.cgi?id=268506 Reviewed by Kimmo Kinnunen. This message is received on the main thread, and blocks submission of the previous layer tree transaction. It can be delayed by other work on the main thread, for arbitrary periods of time. This changes makes it be delivered it to a WorkQueue instead to prevent this blocking. * Source/WebKit/Platform/IPC/StreamClientConnection.cpp: (IPC::StreamClientConnection::addWorkQueueMessageReceiver): (IPC::StreamClientConnection::removeWorkQueueMessageReceiver): * Source/WebKit/Platform/IPC/StreamClientConnection.h: * Source/WebKit/Shared/RemoteLayerTree/RemoteLayerWithRemoteRenderingBackingStore.h: * Source/WebKit/Shared/RemoteLayerTree/RemoteLayerWithRemoteRenderingBackingStore.mm: (WebKit::RemoteLayerWithRemoteRenderingBackingStore::~RemoteLayerWithRemoteRenderingBackingStore): * Source/WebKit/WebProcess/GPU/graphics/RemoteImageBufferSetProxy.cpp: (WebKit::RemoteImageBufferSetProxyFlushFence::create): (WebKit::RemoteImageBufferSetProxyFlushFence::~RemoteImageBufferSetProxyFlushFence): (WebKit::RemoteImageBufferSetProxyFlushFence::waitFor): (WebKit::RemoteImageBufferSetProxyFlushFence::tryTakeEvent): (WebKit::RemoteImageBufferSetProxyFlushFence::setWaitingForSignal): (WebKit::RemoteImageBufferSetProxy::didPrepareForDisplay): (WebKit::RemoteImageBufferSetProxy::shutdown): (WebKit::RemoteImageBufferSetProxy::doShutdown): (WebKit::RemoteImageBufferSetProxy::createFlushFence): (WebKit::RemoteImageBufferSetProxy::flushFrontBufferAsync): (WebKit::RemoteImageBufferSetProxy::willPrepareForDisplay): (WebKit::RemoteImageBufferSetProxy::remoteBufferSetWasDestroyed): * Source/WebKit/WebProcess/GPU/graphics/RemoteImageBufferSetProxy.h: (WebKit::RemoteImageBufferSetProxy::WTF_GUARDED_BY_LOCK): * Source/WebKit/WebProcess/GPU/graphics/RemoteImageBufferSetProxy.messages.in: * Source/WebKit/WebProcess/GPU/graphics/RemoteRenderingBackendProxy.cpp: (WebKit::RemoteRenderingBackendProxy::RemoteRenderingBackendProxy): (WebKit::RemoteRenderingBackendProxy::didClose): (WebKit::RemoteRenderingBackendProxy::prepareImageBufferSetsForDisplay): (WebKit::RemoteRenderingBackendProxy::dispatchMessage): (WebKit::RemoteRenderingBackendProxy::didPrepareForDisplay): Deleted. * Source/WebKit/WebProcess/GPU/graphics/RemoteRenderingBackendProxy.h: (WebKit::RemoteRenderingBackendProxy::workQueue): Canonical link: https://commits.webkit.org/274047@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 2b82b0: Port SharedBuffer to the new IPC serialization format
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 2b82b0b362a5b7b4b1bac7437577834635e392bb https://github.com/WebKit/WebKit/commit/2b82b0b362a5b7b4b1bac7437577834635e392bb Author: Chris Dumez Date: 2024-02-03 (Sat, 03 Feb 2024) Changed paths: M Source/WebCore/platform/SharedBuffer.cpp M Source/WebCore/platform/SharedBuffer.h M Source/WebKit/Shared/WebCoreArgumentCoders.cpp M Source/WebKit/Shared/WebCoreArgumentCoders.h M Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in Log Message: --- Port SharedBuffer to the new IPC serialization format https://bugs.webkit.org/show_bug.cgi?id=268669 Reviewed by Alex Christensen. * Source/WebCore/platform/SharedBuffer.cpp: (WebCore::SharedBuffer::create): * Source/WebCore/platform/SharedBuffer.h: (WebCore::SharedBuffer::asFragmentedSharedBuffer const): * Source/WebKit/Shared/WebCoreArgumentCoders.cpp: (IPC::ArgumentCoder::encode): Deleted. (IPC::ArgumentCoder::decode): Deleted. * Source/WebKit/Shared/WebCoreArgumentCoders.h: * Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in: Canonical link: https://commits.webkit.org/274046@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] a57d94: Unreviewed, reverting 274023@main.
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: a57d9469ff79e847e26c02677b1cd671b48794a4 https://github.com/WebKit/WebKit/commit/a57d9469ff79e847e26c02677b1cd671b48794a4 Author: Commit Queue Date: 2024-02-03 (Sat, 03 Feb 2024) Changed paths: M Source/WebCore/Modules/webauthn/AuthenticatorCoordinator.cpp M Source/WebCore/Modules/webauthn/AuthenticatorCoordinatorClient.h M Source/WebCore/Modules/webauthn/AuthenticatorResponse.cpp M Source/WebCore/Modules/webauthn/AuthenticatorResponseData.h M Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in M Source/WebKit/UIProcess/WebAuthentication/Cocoa/AuthenticationServicesForwardDeclarations.h M Source/WebKit/UIProcess/WebAuthentication/Cocoa/AuthenticationServicesSoftLink.h M Source/WebKit/UIProcess/WebAuthentication/Cocoa/WebAuthenticatorCoordinatorProxy.mm M Source/WebKit/UIProcess/WebAuthentication/WebAuthenticatorCoordinatorProxy.cpp M Source/WebKit/UIProcess/WebAuthentication/WebAuthenticatorCoordinatorProxy.h M Source/WebKit/UIProcess/WebAuthentication/WebAuthenticatorCoordinatorProxy.messages.in M Source/WebKit/WebProcess/WebAuthentication/WebAuthenticatorCoordinator.cpp M Source/WebKit/WebProcess/WebAuthentication/WebAuthenticatorCoordinator.h Log Message: --- Unreviewed, reverting 274023@main. https://bugs.webkit.org/show_bug.cgi?id=268696 Caused webauthn tests to fail Reverted changeset: "[WebAuthn] Use AS APIs passing clientData for WebAuthn" https://bugs.webkit.org/show_bug.cgi?id=268632 https://commits.webkit.org/274023@main Canonical link: https://commits.webkit.org/274045@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 79244f: Port Image to the new IPC serialization format
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 79244f9b44b11ee6e07cf3f5bb7a4282c9b04b55 https://github.com/WebKit/WebKit/commit/79244f9b44b11ee6e07cf3f5bb7a4282c9b04b55 Author: Chris Dumez Date: 2024-02-03 (Sat, 03 Feb 2024) Changed paths: M Source/WebCore/platform/graphics/Image.cpp M Source/WebCore/platform/graphics/Image.h M Source/WebKit/Shared/WebCoreArgumentCoders.cpp M Source/WebKit/Shared/WebCoreArgumentCoders.h M Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in Log Message: --- Port Image to the new IPC serialization format https://bugs.webkit.org/show_bug.cgi?id=268651 Reviewed by Alex Christensen. * Source/WebCore/platform/graphics/Image.cpp: (WebCore::Image::create): (WebCore::Image::toShareableBitmap const): * Source/WebCore/platform/graphics/Image.h: * Source/WebKit/Shared/WebCoreArgumentCoders.cpp: (IPC::ArgumentCoder::encode): Deleted. (IPC::ArgumentCoder::decode): Deleted. * Source/WebKit/Shared/WebCoreArgumentCoders.h: * Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in: Canonical link: https://commits.webkit.org/274044@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] edf848: Generate serialization for SecKeychainItemRef
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: edf8486e0ced3bf3f416bd255aa8b694d7ba01c5 https://github.com/WebKit/WebKit/commit/edf8486e0ced3bf3f416bd255aa8b694d7ba01c5 Author: Scott Marcy Date: 2024-02-03 (Sat, 03 Feb 2024) Changed paths: M Source/WebKit/DerivedSources-input.xcfilelist M Source/WebKit/DerivedSources.make M Source/WebKit/Shared/cf/ArgumentCodersCF.cpp M Source/WebKit/Shared/cf/ArgumentCodersCF.h M Source/WebKit/Shared/cf/CFTypes.serialization.in A Source/WebKit/Shared/cf/CoreIPCSecKeychainItem.h A Source/WebKit/Shared/cf/CoreIPCSecKeychainItem.serialization.in M Source/WebKit/WebKit.xcodeproj/project.pbxproj M Tools/TestWebKitAPI/Tests/IPC/IPCSerialization.mm Log Message: --- Generate serialization for SecKeychainItemRef https://bugs.webkit.org/show_bug.cgi?id=268182 rdar://121676431 Reviewed by achristensen07 (Alex Christensen). * Source/WebKit/DerivedSources-input.xcfilelist: * Source/WebKit/DerivedSources.make: * Source/WebKit/Shared/cf/ArgumentCodersCF.cpp: (IPC::ArgumentCoder::encode): Deleted. (IPC::ArgumentCoder>::decode): Deleted. * Source/WebKit/Shared/cf/ArgumentCodersCF.h: * Source/WebKit/Shared/cf/CFTypes.serialization.in: * Source/WebKit/Shared/cf/CoreIPCSecKeychainItem.h: Added. (WebKit::CoreIPCSecKeychainItem::CoreIPCSecKeychainItem): (WebKit::CoreIPCSecKeychainItem::createSecKeychainItem const): (WebKit::CoreIPCSecKeychainItem::dataReference const): (WebKit::CoreIPCSecKeychainItem::persistentRefForKeychainItem const): * Source/WebKit/Shared/cf/CoreIPCSecKeychainItem.serialization.in: Added. * Source/WebKit/WebKit.xcodeproj/project.pbxproj: * Tools/TestWebKitAPI/Tests/IPC/IPCSerialization.mm: (getTempKeychain): (destroyTempKeychain): (TEST): Canonical link: https://commits.webkit.org/274043@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 13769c: _WKHitTestResult should expose an imageSuggestedFi...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 13769cf1e65593750d931d505723cda7c2e3874d https://github.com/WebKit/WebKit/commit/13769cf1e65593750d931d505723cda7c2e3874d Author: Jeff Miller Date: 2024-02-03 (Sat, 03 Feb 2024) Changed paths: M Source/WebCore/rendering/HitTestResult.h M Source/WebKit/Shared/API/Cocoa/_WKHitTestResult.h M Source/WebKit/Shared/API/Cocoa/_WKHitTestResult.mm M Source/WebKit/Shared/WebHitTestResultData.cpp M Source/WebKit/Shared/WebHitTestResultData.h M Source/WebKit/Shared/WebHitTestResultData.serialization.in M Source/WebKit/UIProcess/API/APIHitTestResult.h M Tools/TestWebKitAPI/Tests/mac/ContextMenuTests.mm Log Message: --- _WKHitTestResult should expose an imageSuggestedFilename property https://bugs.webkit.org/show_bug.cgi?id=268588 rdar://122130871 Reviewed by Aditya Keerthi. Add hasEntireImage and imageSuggestedFilename to WebHitTestResultData (and the underlying plumbing to support calculating the filename) and expose imageSuggestedFilename via a property on _WKHitTestResult. hasEntireImage is currently exposed on _WKContextMenuElementInfo, which in hindsight was probably a mistake, it should be on _WKHitTestResult since that class contains every other related property, but I'll address that in a separate patch. * Source/WebCore/rendering/HitTestResult.h: Export hasEntireImage() so WebKit can use it. * Source/WebKit/Shared/API/Cocoa/_WKHitTestResult.h: Added imageSuggestedFilename property. * Source/WebKit/Shared/API/Cocoa/_WKHitTestResult.mm: (-[_WKHitTestResult imageSuggestedFilename]): Added. * Source/WebKit/Shared/WebHitTestResultData.cpp: (WebKit::imageSuggestedFilenameFromHitTestResult): Added, we can only determine the suggested filename if the entire image is available. (WebKit::WebHitTestResultData::WebHitTestResultData): Initialize linkLocalDataMIMEType. * Source/WebKit/Shared/WebHitTestResultData.h: Added imageSuggestedFilename and hasEntireImage. * Source/WebKit/Shared/WebHitTestResultData.serialization.in: Ditto. * Source/WebKit/UIProcess/API/APIHitTestResult.h: (API::HitTestResult::imageSuggestedFilename const): Added. * Tools/TestWebKitAPI/Tests/mac/ContextMenuTests.mm: (TestWebKitAPI::TEST): Added HitTestResultImageSuggestedFilename, loads an image and verifies that the imageSuggestedFilename is the name of the file. Canonical link: https://commits.webkit.org/274042@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 7575ad: Cherry-pick 274011@main (f2599adbe881). https://bu...
Branch: refs/heads/webkitglib/2.42 Home: https://github.com/WebKit/WebKit Commit: 7575ad359167e085c3cdd40dcae1053af57d0583 https://github.com/WebKit/WebKit/commit/7575ad359167e085c3cdd40dcae1053af57d0583 Author: Olivier Blin Date: 2024-02-03 (Sat, 03 Feb 2024) Changed paths: M Source/WebKit/UIProcess/soup/WebProcessPoolSoup.cpp Log Message: --- Cherry-pick 274011@main (f2599adbe881). https://bugs.webkit.org/show_bug.cgi?id=268479 REGRESSION (234750@main): [GTK][WPE] preferred language not passed to NetworkProcess if set in WebContext before creating WebView https://bugs.webkit.org/show_bug.cgi?id=268479 Reviewed by Adrian Perez de Castro. In GLib ports, since 234750@main, the user preferred language is not properly passed to the NetworkProcess if it is set in WebContext before creating the WebView. This causes a wrong Accept-Language header in HTTP requests sent with libsoup. The webkit_web_context_set_preferred_languages() API can be called before passing the WebContext at WebView creation. Since 234750@main, this function calls the setOverrideLanguages() WebProcessPool API instead of the overrideUserPreferredLanguages() WTF API. So WebProcessPool::platformInitializeNetworkProcess() could not get the real preferred language from the userPreferredLanguages() WTF API. Instead, the NetworkProcess creation should use the overrideLanguages() WebProcessPool API, like already done for the WebProcess creation parameters (see also 226031@main). Keep userPreferredLanguages() as a fallback to get the default language from platformLanguage() in WTF::LanguageUnix. * Source/WebKit/UIProcess/soup/WebProcessPoolSoup.cpp: (WebKit::WebProcessPool::platformInitializeNetworkProcess): Canonical link: https://commits.webkit.org/274011@main Commit: 75cfcdec027c30644b72fd980189044f386e9504 https://github.com/WebKit/WebKit/commit/75cfcdec027c30644b72fd980189044f386e9504 Author: Georges Basile Stavracas Neto Date: 2024-02-03 (Sat, 03 Feb 2024) Changed paths: M Source/WebCore/platform/gamepad/manette/ManetteGamepad.cpp M Source/WebCore/platform/gamepad/manette/ManetteGamepad.h Log Message: --- Cherry-pick 274022@main (37a85d6c3252). https://bugs.webkit.org/show_bug.cgi?id=268653 [GTK][WPE] Detect gamepad button 16 https://bugs.webkit.org/show_bug.cgi?id=268653 Reviewed by Michael Catanzaro. The Gamepad spec lists 17 buttons, starting at zero. The button number 16 is defined as "Center button in center cluster" [1], e.g. the PS button in a DualShock 4 or 5, or similar ones in other controllers. The libmanette gamepad backend only lists up to button number 15, which was what was under the spec when the backend was introduced. Add the button 16 to the listing as well. Listing is all that is needed since the rest of the code already detects and maps this button as expected [1] https://www.w3.org/TR/gamepad/#dfn-standard-gamepad * Source/WebCore/platform/gamepad/manette/ManetteGamepad.cpp: (WebCore::toStandardGamepadButton): * Source/WebCore/platform/gamepad/manette/ManetteGamepad.h: Canonical link: https://commits.webkit.org/274022@main Commit: 1bed1f4d2e254778c906147f094c1a4359b089d2 https://github.com/WebKit/WebKit/commit/1bed1f4d2e254778c906147f094c1a4359b089d2 Author: Georges Basile Stavracas Neto Date: 2024-02-03 (Sat, 03 Feb 2024) Changed paths: M Source/WebKit/UIProcess/Gamepad/gtk/UIGamepadProviderGtk.cpp Log Message: --- Cherry-pick 273882@main (7ca356b2f1bf). https://bugs.webkit.org/show_bug.cgi?id=258264 [GTK] Check window focus with gtk_window_is_active() https://bugs.webkit.org/show_bug.cgi?id=258264 Reviewed by Michael Catanzaro. In GTK3, gtk_widget_has_focus() called on a GtkWindow has the semantics of "does this window receive input". This semantic is not preserved in GTK4; instead, gtk_window_is_active() is what yields the same results. By using gtk_widget_has_focus() in UIGamepadProviderGtk, it always returned false, and prevented gamepad detection from properly working. Switch that to gtk_window_is_active(). * Source/WebKit/UIProcess/Gamepad/gtk/UIGamepadProviderGtk.cpp: (WebKit::UIGamepadProvider::platformWebPageProxyForGamepadInput): Canonical link: https://commits.webkit.org/273882@main Compare: https://github.com/WebKit/WebKit/compare/1d37ed0cf1ac...1bed1f4d2e25 ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] d43204: [WPE] Remove unused WPE platform variables
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: d43204ef8d198c79e44bb588cef9782dff95c27d https://github.com/WebKit/WebKit/commit/d43204ef8d198c79e44bb588cef9782dff95c27d Author: Olivier Blin Date: 2024-02-03 (Sat, 03 Feb 2024) Changed paths: M Source/WebKit/UIProcess/API/wpe/WPEWebView.h M Tools/WebKitTestRunner/libwpe/EventSenderProxyClientLibWPE.h Log Message: --- [WPE] Remove unused WPE platform variables https://bugs.webkit.org/show_bug.cgi?id=268627 Reviewed by Michael Catanzaro. * Source/WebKit/UIProcess/API/wpe/WPEWebView.h: m_viewWasAlreadyInFullScreen is used only with ENABLE(WPE_PLATFORM) * Tools/WebKitTestRunner/libwpe/EventSenderProxyClientLibWPE.h: m_backend is never used Canonical link: https://commits.webkit.org/274041@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 3b4f0c: Ruby 3.2 removed File.exists?
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 3b4f0c1d94b591c4c4de50f8213d910cfaaa307e https://github.com/WebKit/WebKit/commit/3b4f0c1d94b591c4c4de50f8213d910cfaaa307e Author: Fujii Hironori Date: 2024-02-03 (Sat, 03 Feb 2024) Changed paths: M Tools/Scripts/check-for-inappropriate-macros-in-external-headers M Tools/Scripts/run-jsc-stress-tests M Tools/Scripts/run-testmem M Tools/Scripts/webkitruby/jsc-stress-test-writer-playstation.rb M Tools/Scripts/webkitruby/jsc-stress-test-writer-ruby.rb Log Message: --- Ruby 3.2 removed File.exists? https://bugs.webkit.org/show_bug.cgi?id=268604 Reviewed by Ross Kirsling. `File.exists?` was deprecated since Ruby 2.1. And, Ruby 3.2 finally removed File.exists? Use `File.exist?` instead. * Tools/Scripts/check-for-inappropriate-macros-in-external-headers: * Tools/Scripts/run-jsc-stress-tests: * Tools/Scripts/run-testmem: * Tools/Scripts/webkitruby/jsc-stress-test-writer-playstation.rb: * Tools/Scripts/webkitruby/jsc-stress-test-writer-ruby.rb: Canonical link: https://commits.webkit.org/274040@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
