[webkit-changes] [WebKit/WebKit] 7fd681: [iOS] Pressing any modifier with a hardware keyboa...

[Wenson Hsieh]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 7fd6818d91806bf407ec38e3be19038ee2790e98
  
https://github.com/WebKit/WebKit/commit/7fd6818d91806bf407ec38e3be19038ee2790e98
  Author: Wenson Hsieh 
  Date:   2024-02-14 (Wed, 14 Feb 2024)

  Changed paths:
M Source/WebCore/platform/ios/WebEvent.mm

  Log Message:
  ---
  [iOS] Pressing any modifier with a hardware keyboard debug asserts under 
-[WebEvent characters]
https://bugs.webkit.org/show_bug.cgi?id=269430
rdar://122968675

Reviewed by Aditya Keerthi.

In iOS 17.4, UIKit now always calls into `-characters` and 
`-charactersIgnoringModifiers` in the
process of constructing a `UIKeyEvent` from a `WebEvent` (which is eventually 
wrapped in a
`BEKeyEvent`). For modifier keys, this ends up triggering assertions in these 
two methods.

To keep these assertions relevant when using `BEKeyEntry` for key event 
dispatch, only allow them to
trigger once the key event arrives in WebKit code, and we proceed to unwrap the 
`BEKeyEntry` back
into the underlying `WebEvent`.

This fixes ~25 failing tests in debug iOS.

* Source/WebCore/platform/ios/WebEvent.mm:
(-[WebEvent characters]):
(-[WebEvent charactersIgnoringModifiers]):
(-[WebEvent initWithKeyEntry:]):

Canonical link: https://commits.webkit.org/274701@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 1e5148: Try to fix the iOS UnifiedPDF build after pasteboa...

[Tim Horton]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 1e514819de21e8f57c846378688f00de0f737bd9
  
https://github.com/WebKit/WebKit/commit/1e514819de21e8f57c846378688f00de0f737bd9
  Author: Tim Horton 
  Date:   2024-02-14 (Wed, 14 Feb 2024)

  Changed paths:
M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm

  Log Message:
  ---
  Try to fix the iOS UnifiedPDF build after pasteboard changes
https://bugs.webkit.org/show_bug.cgi?id=269435

Unreviewed speculative build fix.

* Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm:
(WebKit::UnifiedPDFPlugin::performCopyLinkOperation const):

Canonical link: https://commits.webkit.org/274700@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 0d7c00: Use the highest QOS available when detecting conte...

[Richard Robinson]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 0d7c0048ca22e42c1c974a3a832562d8fec781e0
  
https://github.com/WebKit/WebKit/commit/0d7c0048ca22e42c1c974a3a832562d8fec781e0
  Author: Richard Robinson 
  Date:   2024-02-14 (Wed, 14 Feb 2024)

  Changed paths:
M Source/WebCore/PAL/pal/cocoa/DataDetectorsCoreSoftLink.h
M Source/WebCore/PAL/pal/cocoa/DataDetectorsCoreSoftLink.mm
M Source/WebCore/PAL/pal/spi/cocoa/DataDetectorsCoreSPI.h
M Source/WebCore/editing/cocoa/DataDetection.h
M Source/WebCore/editing/cocoa/DataDetection.mm
M Source/WebCore/loader/FrameLoader.cpp
M Source/WebCore/page/Page.h
M Source/WebKit/Shared/Cocoa/DataDetectionResult.h
M Source/WebKit/WebProcess/WebPage/WebPage.cpp

  Log Message:
  ---
  Use the highest QOS available when detecting content with DataDetectors
https://bugs.webkit.org/show_bug.cgi?id=267879
rdar://118585870

Reviewed by Aditya Keerthi.

Use the highest QOS available when creating a DDScanner.

To facilitate this, make the content data detection mechanism async.

* Source/WebCore/PAL/pal/spi/cocoa/DataDetectorsCoreSPI.h:
* Source/WebCore/editing/cocoa/DataDetection.h:
* Source/WebCore/editing/cocoa/DataDetection.mm:
(WebCore::buildQuery):
(WebCore::workQueue):
(WebCore::parseAllResultRanges):
(WebCore::DDQueryFragmentCore::operator== const):
(WebCore::getFragmentsFromQuery):
(WebCore::processDataDetectorScannerResults):
(WebCore::DataDetection::detectContentInFrame):
(WebCore::DataDetection::detectContentInRange):
* Source/WebCore/loader/FrameLoader.cpp:
(WebCore::FrameLoader::checkLoadCompleteForThisFrame):
* Source/WebKit/Shared/Cocoa/DataDetectionResult.h:
* 
Source/WebKit/WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInRangeHandle.mm:
(-[WKWebProcessPlugInRangeHandle detectDataWithTypes:context:]):
* Source/WebKit/WebProcess/WebPage/WebPage.cpp:
(WebKit::detectDataInFrame):
(WebKit::WebPage::detectDataInAllFrames):

Canonical link: https://commits.webkit.org/274699@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] a41e91: UnifiedPDF: Crash when clicking on form fields

[Tim Horton]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: a41e91d3c9715f4f8267e4f1f0712a2eb69daa61
  
https://github.com/WebKit/WebKit/commit/a41e91d3c9715f4f8267e4f1f0712a2eb69daa61
  Author: Tim Horton 
  Date:   2024-02-14 (Wed, 14 Feb 2024)

  Changed paths:
M Source/WebKit/WebProcess/Plugins/PDF/PDFPluginTextAnnotation.mm

  Log Message:
  ---
  UnifiedPDF: Crash when clicking on form fields
https://bugs.webkit.org/show_bug.cgi?id=269432
rdar://122989423

Reviewed by Richard Robinson.

* Source/WebKit/WebProcess/Plugins/PDF/PDFPluginTextAnnotation.mm:
(WebKit::PDFPluginTextAnnotation::createAnnotationElement):
Don't use setValue() because element() is still null at this point.

Canonical link: https://commits.webkit.org/274698@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] f56a1d: NEW TEST (274589@main): [ macOS Monterey+ ] TestWe...

[martadarbinyan]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: f56a1d7f2efecfee7bfae3999ecfb4d0ed0d9d01
  
https://github.com/WebKit/WebKit/commit/f56a1d7f2efecfee7bfae3999ecfb4d0ed0d9d01
  Author: Marta Darbinyan 
  Date:   2024-02-14 (Wed, 14 Feb 2024)

  Changed paths:
M Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionAPIDevTools.mm

  Log Message:
  ---
  NEW TEST (274589@main): [ macOS Monterey+ ] TestWebKitAPI.WKWebExtensio 
nAPIDevTools.CreatePanel is a consistent timeout (269402)
https://bugs.webkit.org/show_bug.cgi?id=269402
rdar://122967271

Reviewed by Timothy Hatcher.

Disabling timeout API test since it is effecting EWS.

* Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionAPIDevTools.mm:
(TestWebKitAPI::TEST):

Canonical link: https://commits.webkit.org/274697@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 11df71: Try to fix the macCatalyst build after 274668@main

[Tim Horton]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 11df71e92471b37abb2b62277a4fd800e05f748f
  
https://github.com/WebKit/WebKit/commit/11df71e92471b37abb2b62277a4fd800e05f748f
  Author: Tim Horton 
  Date:   2024-02-14 (Wed, 14 Feb 2024)

  Changed paths:
M Source/WebKit/WebProcess/WebPage/Cocoa/TextCheckingControllerProxy.mm

  Log Message:
  ---
  Try to fix the macCatalyst build after 274668@main
https://bugs.webkit.org/show_bug.cgi?id=269431

Unreviewed build fix.

* Source/WebKit/WebProcess/WebPage/Cocoa/TextCheckingControllerProxy.mm:
(WebKit::TextCheckingControllerProxy::annotatedSubstringBetweenPositions):

Canonical link: https://commits.webkit.org/274696@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 2a14de: [UnifiedPDF] "Copy Link" context menu item should ...

[Abrar Rahman Protyasha]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 2a14de2051cd21485f7d7a65f8caf7b9f3d9ffec
  
https://github.com/WebKit/WebKit/commit/2a14de2051cd21485f7d7a65f8caf7b9f3d9ffec
  Author: Abrar Rahman Protyasha 
  Date:   2024-02-14 (Wed, 14 Feb 2024)

  Changed paths:
M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.h
M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm

  Log Message:
  ---
  [UnifiedPDF] "Copy Link" context menu item should copy the link from the 
current selection
https://bugs.webkit.org/show_bug.cgi?id=269423
rdar://122981243

Reviewed by Simon Fraser.

In 274611@main, we added support for a "Copy Link" context menu item.
This patch imbibes the item with its namesake functionality through the
performCopyLinkOperation method. Said method checks if the context menu
was invoked over a link-bearing annotation, and if so, extracts the URL
from that annotation and puts it on the pasteboard.

Note that we introduce a subtle behavior change through this patch. We
no longer unconditionally present the "Copy Link" context menu item for
any link annotations, and only do so for annotations containing external
links (not destinations).

* Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.h:
* Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm:
(WebKit::UnifiedPDFPlugin::convertFromDocumentToPlugin const):
(WebKit::UnifiedPDFPlugin::convertFromPageToDocument const):
(WebKit::annotationIsExternalLink):
(WebKit::annotationIsLinkWithDestination):
(WebKit::UnifiedPDFPlugin::handleContextMenuEvent):
(WebKit::UnifiedPDFPlugin::createContextMenu const):
(WebKit::UnifiedPDFPlugin::selectionContextMenuItems const):
(WebKit::UnifiedPDFPlugin::performContextMenuAction):
(WebKit::UnifiedPDFPlugin::performCopyLinkOperation const):

Canonical link: https://commits.webkit.org/274695@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 7175cd: Deadlock under ~PluginView() with PDFPlugin.

[lericaa]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 7175cd9a22b4a115e8fc413db3fb759b193b0b80
  
https://github.com/WebKit/WebKit/commit/7175cd9a22b4a115e8fc413db3fb759b193b0b80
  Author: Erica Li 
  Date:   2024-02-14 (Wed, 14 Feb 2024)

  Changed paths:
A 
LayoutTests/compositing/plugins/pdf/pdf-plugin-hang-during-destruction-expected.txt
A 
LayoutTests/compositing/plugins/pdf/pdf-plugin-hang-during-destruction.html
M Source/WebKit/WebProcess/Plugins/PDF/PDFIncrementalLoader.h
M Source/WebKit/WebProcess/Plugins/PDF/PDFIncrementalLoader.mm
M Source/WebKit/WebProcess/Plugins/PDF/PDFPluginBase.h

  Log Message:
  ---
  Deadlock under ~PluginView() with PDFPlugin.
rdar://108489643
https://bugs.webkit.org/show_bug.cgi?id=268536

Reviewed by Simon Fraser.

dataProviderGetBytesAtPosition might be invoked recursively from CG, and it 
highly increased the possiblity when the main runloop is destructing the 
PDFPlugin,
while the another main runloop is dispatched from 
dataProviderGetBytesAtPosition and does not get chance to signal semaphore as 
it is waiting current runloop to finish,
that causes deadlock. This change is to stop dispatch main runloop when plugin 
has been destroyed and signal the semaphore before main thread calling 
waitForCompletion for m_pdfThread.

* 
LayoutTests/compositing/plugins/pdf/pdf-plugin-hang-during-destruction-expected.txt:
 Added.
* LayoutTests/compositing/plugins/pdf/pdf-plugin-hang-during-destruction.html: 
Added.
* Source/WebKit/WebProcess/Plugins/PDF/PDFIncrementalLoader.h:
* Source/WebKit/WebProcess/Plugins/PDF/PDFIncrementalLoader.mm:
(WebKit::PDFIncrementalLoader::clear):
(WebKit::PDFIncrementalLoader::dataProviderGetBytesAtPosition):
* Source/WebKit/WebProcess/Plugins/PDF/PDFPluginBase.h:
(WebKit::PDFPluginBase::hasBeenDestroyed const):

Canonical link: https://commits.webkit.org/274694@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 49fef5: [PlayStation] Build fix after 274652@main

[Stephan Szabo]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 49fef559975eadeb4609dfe423aed84f43dcacb9
  
https://github.com/WebKit/WebKit/commit/49fef559975eadeb4609dfe423aed84f43dcacb9
  Author: Stephan Szabo 
  Date:   2024-02-14 (Wed, 14 Feb 2024)

  Changed paths:
M Source/WebCore/page/PageOverlayController.h

  Log Message:
  ---
  [PlayStation] Build fix after 274652@main
https://bugs.webkit.org/show_bug.cgi?id=269415

Unreviewed build fix.

In our configuration GraphicsLayer is just a forward
declaration in PageOverlayController, so we have errors,
so make sure that the header is included.

* Source/WebCore/page/PageOverlayController.h:

Canonical link: https://commits.webkit.org/274693@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 3ece00: Add process info methods to WKProcessPool

[bnham]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 3ece00bd2a4f6159b2e91705cde25e993edbb220
  
https://github.com/WebKit/WebKit/commit/3ece00bd2a4f6159b2e91705cde25e993edbb220
  Author: Ben Nham 
  Date:   2024-02-14 (Wed, 14 Feb 2024)

  Changed paths:
M Source/WebKit/UIProcess/API/Cocoa/WKProcessPool.mm
M Source/WebKit/UIProcess/API/Cocoa/WKProcessPoolPrivate.h
M Source/WebKit/UIProcess/AuxiliaryProcessProxy.h
M Source/WebKit/UIProcess/Cocoa/AuxiliaryProcessProxyCocoa.mm
M Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm
M Source/WebKit/UIProcess/GPU/GPUProcessProxy.h
M Source/WebKit/UIProcess/Model/ModelProcessProxy.h
M Source/WebKit/UIProcess/Network/NetworkProcessProxy.h
M Source/WebKit/UIProcess/WebProcessProxy.cpp
M Source/WebKit/UIProcess/WebProcessProxy.h
M Tools/TestWebKitAPI/SourcesCocoa.txt
M Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj
A Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessInfo.mm

  Log Message:
  ---
  Add process info methods to WKProcessPool
https://bugs.webkit.org/show_bug.cgi?id=269228
rdar://problem/122825184

Reviewed by Brady Eidson.

This adds methods to WKProcessPool that allow clients to see metadata such as 
CPU time usage, memory
footprint, and current process state for processes spawned by WebKit. This can 
be useful for
understanding how our processes behave in the field.

* Source/WebKit/UIProcess/API/Cocoa/WKProcessPool.mm:
(+[WKProcessPool _gpuProcessInfo]):
(+[WKProcessPool _networkingProcessInfo]):
(+[WKProcessPool _webContentProcessInfo]):
(processStateFromThrottleState):
(-[_WKProcessInfo initWithTaskInfo:]):
(-[_WKWebContentProcessInfo initWithTaskInfo:process:]):
(-[_WKWebContentProcessInfo webViews]):
* Source/WebKit/UIProcess/API/Cocoa/WKProcessPoolPrivate.h:
* Source/WebKit/UIProcess/AuxiliaryProcessProxy.h:
* Source/WebKit/UIProcess/Cocoa/AuxiliaryProcessProxyCocoa.mm:
(WebKit::AuxiliaryProcessProxy::taskInfo const):
* Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm:
(WebKit::description):
(WebKit::logProcessPoolState):
* Source/WebKit/UIProcess/GPU/GPUProcessProxy.h:
* Source/WebKit/UIProcess/Model/ModelProcessProxy.h:
* Source/WebKit/UIProcess/Network/NetworkProcessProxy.h:
* Source/WebKit/UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::setIsInProcessCache):
(WebKit::WebProcessProxy::markIsNoLongerInPrewarmedPool):
(WebKit::WebProcessProxy::didChangeThrottleState):
(WebKit::WebProcessProxy::didDropLastAssertion):
(WebKit::WebProcessProxy::totalForegroundTime const):
(WebKit::WebProcessProxy::totalBackgroundTime const):
(WebKit::WebProcessProxy::totalSuspendedTime const):
(WebKit::WebProcessProxy::updateRuntimeStatistics):
* Source/WebKit/UIProcess/WebProcessProxy.h:
(WebKit::WebProcessProxy::throttler const): Deleted.

Canonical link: https://commits.webkit.org/274692@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 5bdc3d: WebKitSwift.h:26:9: error: 'WebKitSwift/WKSLinearM...

[Dana Estra]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 5bdc3dad5f5b1264ddd2699aa9b9377aa69f8f43
  
https://github.com/WebKit/WebKit/commit/5bdc3dad5f5b1264ddd2699aa9b9377aa69f8f43
  Author: Dana Estra 
  Date:   2024-02-14 (Wed, 14 Feb 2024)

  Changed paths:
M Source/WebCore/platform/ios/PlaybackSessionInterfaceAVKit.h
M Source/WebCore/platform/ios/PlaybackSessionInterfaceAVKit.mm
M Source/WebCore/platform/ios/PlaybackSessionInterfaceIOS.h
M Source/WebKit/Platform/ios/PlaybackSessionInterfaceLMK.h
M Source/WebKit/Platform/ios/PlaybackSessionInterfaceLMK.mm
M Source/WebKit/Platform/ios/VideoPresentationInterfaceLMK.h
M Source/WebKit/Platform/ios/VideoPresentationInterfaceLMK.mm

  Log Message:
  ---
  WebKitSwift.h:26:9: error: 'WebKitSwift/WKSLinearMediaPlayer.h' file not 
found (in target 'WebKit' from project 'WebKit')
https://bugs.webkit.org/show_bug.cgi?id=269392
rdar://122956083

Reviewed by Andy Estes.

Removing usage of WKLinearMediaPlayerDelegate and WKSLinearMediaPlayer.

* Source/WebCore/platform/ios/PlaybackSessionInterfaceAVKit.h:
* Source/WebCore/platform/ios/PlaybackSessionInterfaceAVKit.mm:
(WebCore::PlaybackSessionInterfaceAVKit::linearMediaPlayer const): Deleted.
* Source/WebCore/platform/ios/PlaybackSessionInterfaceIOS.h:
* Source/WebKit/Platform/ios/PlaybackSessionInterfaceLMK.h:
(): Deleted.
* Source/WebKit/Platform/ios/PlaybackSessionInterfaceLMK.mm:
(WebKit::PlaybackSessionInterfaceLMK::PlaybackSessionInterfaceLMK):
(WebKit::PlaybackSessionInterfaceLMK::durationChanged):
(WebKit::PlaybackSessionInterfaceLMK::currentTimeChanged):
(-[WKLinearMediaPlayerDelegate initWithInterface:]): Deleted.
(): Deleted.
(WebKit::PlaybackSessionInterfaceLMK::invalidate): Deleted.
* Source/WebKit/Platform/ios/VideoPresentationInterfaceLMK.h:
* Source/WebKit/Platform/ios/VideoPresentationInterfaceLMK.mm:
(WebKit::VideoPresentationInterfaceLMK::linearMediaPlayer const): Deleted.

Canonical link: https://commits.webkit.org/274691@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 1d46d6: [MultiRep HEIC] Ensure data is preserved when copy...

[Aditya Keerthi]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 1d46d6999740b7e33536645aadfdc0a45afce20e
  
https://github.com/WebKit/WebKit/commit/1d46d6999740b7e33536645aadfdc0a45afce20e
  Author: Aditya Keerthi 
  Date:   2024-02-14 (Wed, 14 Feb 2024)

  Changed paths:
M Source/WebCore/editing/cocoa/AttributedString.h
M Source/WebCore/editing/cocoa/AttributedString.mm
M Source/WebCore/editing/cocoa/HTMLConverter.mm
M Source/WebCore/editing/cocoa/TextAttachmentForSerialization.h
M Source/WebCore/html/HTMLImageElement.cpp
M Source/WebCore/html/HTMLImageElement.h
M Source/WebCore/platform/graphics/ImageAdapter.h
M Source/WebCore/platform/graphics/mac/ImageAdapterMac.mm
M Source/WebCore/platform/ios/UIFoundationSoftLink.h
M Source/WebCore/platform/ios/UIFoundationSoftLink.mm
M Source/WebKit/Shared/Cocoa/WebCoreArgumentCodersCocoa.serialization.in
M Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in

  Log Message:
  ---
  [MultiRep HEIC] Ensure data is preserved when copying rich content
https://bugs.webkit.org/show_bug.cgi?id=269348
rdar://122932418

Reviewed by Richard Robinson.

* Source/WebCore/editing/cocoa/AttributedString.h:
* Source/WebCore/editing/cocoa/AttributedString.mm:

Decompose the attachment into individual bitmaps for serialization.

(WebCore::toNSObject):
(WebCore::extractValue):
* Source/WebCore/editing/cocoa/HTMLConverter.mm:

Add a HEIC attachment to the attributed string when a multi-representation
HEIC is encountered.

(HTMLConverter::_addMultiRepresentationHEICAttachmentForImageElement):
(HTMLConverter::_processElement):
(attachmentForElement):
(WebCore::editingAttributedString):
* Source/WebCore/editing/cocoa/TextAttachmentForSerialization.h:
* Source/WebCore/html/HTMLImageElement.cpp:
(WebCore::HTMLImageElement::isMultiRepresentationHEIC const):
* Source/WebCore/html/HTMLImageElement.h:
* Source/WebCore/platform/graphics/ImageAdapter.h:
* Source/WebCore/platform/graphics/mac/ImageAdapterMac.mm:
(WebCore::ImageAdapter::multiRepresentationHEIC):
(WebCore::ImageAdapter::invalidate):
* Source/WebCore/platform/ios/UIFoundationSoftLink.h:
* Source/WebCore/platform/ios/UIFoundationSoftLink.mm:
* Source/WebKit/Shared/Cocoa/WebCoreArgumentCodersCocoa.serialization.in:
* Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in:

Canonical link: https://commits.webkit.org/274690@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] dea5f8: Try loading fonts with CTFontManagerCreateMemorySa...

[apple-fcloutier]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: dea5f8e4a1495d6a7ae3d295d12ec5a99969861c
  
https://github.com/WebKit/WebKit/commit/dea5f8e4a1495d6a7ae3d295d12ec5a99969861c
  Author: Félix Cloutier 
  Date:   2024-02-14 (Wed, 14 Feb 2024)

  Changed paths:
M Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml
M Source/WebCore/Headers.cmake
M Source/WebCore/PAL/pal/cf/CoreTextSoftLink.cpp
M Source/WebCore/PAL/pal/cf/CoreTextSoftLink.h
M Source/WebCore/Sources.txt
M Source/WebCore/WebCore.order
M Source/WebCore/WebCore.xcodeproj/project.pbxproj
M Source/WebCore/css/CSSFontFace.cpp
M Source/WebCore/css/CSSFontFaceSource.cpp
M Source/WebCore/css/FontFace.cpp
R Source/WebCore/loader/cache/AllowedFonts.cpp
R Source/WebCore/loader/cache/AllowedFonts.h
M Source/WebCore/loader/cache/CachedFont.cpp
M Source/WebCore/loader/cache/CachedFont.h
M Source/WebCore/loader/cache/CachedFontLoadRequest.h
A Source/WebCore/loader/cache/TrustedFonts.cpp
A Source/WebCore/loader/cache/TrustedFonts.h
M Source/WebCore/page/Quirks.cpp
M Source/WebCore/page/Settings.yaml
M Source/WebCore/page/SettingsBase.h
M Source/WebCore/platform/graphics/FontCustomPlatformData.h
M 
Source/WebCore/platform/graphics/coretext/FontCustomPlatformDataCoreText.cpp
M Source/WebCore/platform/graphics/coretext/FontPlatformDataCoreText.cpp
M 
Source/WebCore/platform/graphics/freetype/FontCustomPlatformDataFreeType.cpp
M Source/WebCore/platform/graphics/win/FontCustomPlatformDataWin.cpp
M Source/WebCore/workers/WorkerFontLoadRequest.cpp
M Source/WebKit/Shared/WebCoreArgumentCoders.cpp
M Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in
M Source/WebKit/Shared/win/WebCoreArgumentCodersWin.cpp
M Source/WebKit/WebProcess/WebPage/WebPage.cpp

  Log Message:
  ---
  Try loading fonts with CTFontManagerCreateMemorySafeFontDescriptorFromData in 
Lockdown Mode.

https://bugs.webkit.org/show_bug.cgi?id=267948

rdar://121280542

Reviewed by Brent Fulgham and Chris Dumez.

Most Web fonts are not parsed in Lockdown Mode. On systems that provide an
alternative, safe font parser, try to use that font parser. Whether to enable
a fallback font parser is controlled by the LockdownFontParserEnabled setting,
added in "testable" status.

* Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml:
* Source/WebCore/Headers.cmake:
* Source/WebCore/PAL/pal/cf/CoreTextSoftLink.cpp:
* Source/WebCore/PAL/pal/cf/CoreTextSoftLink.h:
* Source/WebCore/Sources.txt:
* Source/WebCore/WebCore.order:
* Source/WebCore/WebCore.xcodeproj/project.pbxproj:
* Source/WebCore/css/CSSFontFace.cpp:
(WebCore::CSSFontFace::appendSources):
* Source/WebCore/css/CSSFontFaceSource.cpp:
(WebCore::CSSFontFaceSource::load):
* Source/WebCore/css/FontFace.cpp:
(WebCore::FontFace::create):
* Source/WebCore/loader/cache/CachedFont.cpp:
(WebCore::CachedFont::policyForCustomFont):
(WebCore::CachedFont::finishLoading):
(WebCore::CachedFont::ensureCustomFontData):
(WebCore::CachedFont::createCustomFontData):
(WebCore::CachedFont::createCustomFontDataExperimentalParser):
(WebCore::CachedFont::shouldAllowCustomFont): Deleted.
* Source/WebCore/loader/cache/CachedFont.h:
(WebCore::CachedFont::didRefuseToParseCustomFont const):
(WebCore::CachedFont::didRefuseToLoadCustomFont const): Deleted.
* Source/WebCore/loader/cache/CachedFontLoadRequest.h:
* Source/WebCore/loader/cache/TrustedFonts.cpp: Renamed from 
Source/WebCore/loader/cache/AllowedFonts.cpp.
(WebCore::trustedFontHashesInLockdownMode):
(WebCore::hashForFontData):
(WebCore::fontBinaryParsingPolicy):
* Source/WebCore/loader/cache/TrustedFonts.h: Renamed from 
Source/WebCore/loader/cache/AllowedFonts.h.
* Source/WebCore/page/Quirks.cpp:
(WebCore::Quirks::shouldEnableFontLoadingAPIQuirk const):
* Source/WebCore/page/Settings.yaml:
* Source/WebCore/page/SettingsBase.h:
* Source/WebCore/platform/graphics/FontCustomPlatformData.h:
* Source/WebCore/platform/graphics/coretext/FontCustomPlatformDataCoreText.cpp:
(WebCore::extractFontCustomPlatformData):
(WebCore::FontCustomPlatformData::create):
(WebCore::FontCustomPlatformData::createMemorySafe):
(WebCore::FontCustomPlatformData::tryMakeFromSerializationData):
(WebCore::createFontCustomPlatformData): Deleted.
* Source/WebCore/platform/graphics/coretext/FontPlatformDataCoreText.cpp:
(WebCore::FontPlatformData::tryMakeFontPlatformData):
* Source/WebCore/platform/graphics/freetype/FontCustomPlatformDataFreeType.cpp:
(WebCore::FontCustomPlatformData::create):
(WebCore::FontCustomPlatformData::createMemorySafe):
(WebCore::createFontCustomPlatformData): Deleted.
* Source/WebCore/platform/graphics/win/FontCustomPlatformDataWin.cpp:
(WebCore::FontCustomPlatformData::create):
(WebCore::FontCustomPlatformData::createMemorySafe):
(WebCore::createFontCustomPlatformData): Deleted.
* Source/WebCore/workers/WorkerFontLoadRequest.cpp:

[webkit-changes] [WebKit/WebKit] ec2d97: [resutlsdb] Add reset button for ConfigurationSele...

[Zhifei Fang]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: ec2d9753bb2acef535cf5584a73b4c00b0ad560f
  
https://github.com/WebKit/WebKit/commit/ec2d9753bb2acef535cf5584a73b4c00b0ad560f
  Author: Zhifei Fang 
  Date:   2024-02-14 (Wed, 14 Feb 2024)

  Changed paths:
M Tools/Scripts/libraries/resultsdbpy/resultsdbpy/view/static/js/drawer.js

  Log Message:
  ---
  [resutlsdb] Add reset button for ConfigurationSelectors
https://bugs.webkit.org/show_bug.cgi?id=269312
rdar://122889620

Reviewed by Jonathan Bedard.

Add a reset button for user to easily reset all config filters

* Tools/Scripts/libraries/resultsdbpy/resultsdbpy/view/static/js/drawer.js:

Canonical link: https://commits.webkit.org/274688@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] b13bf4: [JSC] Introduce InBy megamorphic ICs

[Yusuke Suzuki]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: b13bf4c3488741d6e41f1be6b2d15300a9951ce8
  
https://github.com/WebKit/WebKit/commit/b13bf4c3488741d6e41f1be6b2d15300a9951ce8
  Author: Yusuke Suzuki 
  Date:   2024-02-14 (Wed, 14 Feb 2024)

  Changed paths:
M Source/JavaScriptCore/bytecode/AccessCase.cpp
M Source/JavaScriptCore/bytecode/AccessCase.h
M Source/JavaScriptCore/bytecode/InByStatus.cpp
M Source/JavaScriptCore/bytecode/InByStatus.h
M Source/JavaScriptCore/bytecode/InlineCacheCompiler.cpp
M Source/JavaScriptCore/bytecode/InlineCacheCompiler.h
M Source/JavaScriptCore/bytecode/Repatch.cpp
M Source/JavaScriptCore/bytecode/Repatch.h
M Source/JavaScriptCore/bytecode/StructureStubInfo.cpp
M Source/JavaScriptCore/bytecode/StructureStubInfo.h
M Source/JavaScriptCore/dfg/DFGAbstractInterpreterInlines.h
M Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp
M Source/JavaScriptCore/dfg/DFGClobberize.h
M Source/JavaScriptCore/dfg/DFGConstantFoldingPhase.cpp
M Source/JavaScriptCore/dfg/DFGDoesGC.cpp
M Source/JavaScriptCore/dfg/DFGFixupPhase.cpp
M Source/JavaScriptCore/dfg/DFGNode.cpp
M Source/JavaScriptCore/dfg/DFGNode.h
M Source/JavaScriptCore/dfg/DFGNodeType.h
M Source/JavaScriptCore/dfg/DFGPredictionPropagationPhase.cpp
M Source/JavaScriptCore/dfg/DFGSafeToExecute.h
M Source/JavaScriptCore/dfg/DFGSpeculativeJIT.h
M Source/JavaScriptCore/dfg/DFGSpeculativeJIT32_64.cpp
M Source/JavaScriptCore/dfg/DFGSpeculativeJIT64.cpp
M Source/JavaScriptCore/dfg/DFGStrengthReductionPhase.cpp
M Source/JavaScriptCore/ftl/FTLCapabilities.cpp
M Source/JavaScriptCore/ftl/FTLLowerDFGToB3.cpp
M Source/JavaScriptCore/jit/AssemblyHelpers.cpp
M Source/JavaScriptCore/jit/AssemblyHelpers.h
M Source/JavaScriptCore/jit/JITOperations.cpp
M Source/JavaScriptCore/jit/JITOperations.h
M Source/JavaScriptCore/runtime/MegamorphicCache.cpp
M Source/JavaScriptCore/runtime/MegamorphicCache.h

  Log Message:
  ---
  [JSC] Introduce InBy megamorphic ICs
https://bugs.webkit.org/show_bug.cgi?id=269255
rdar://121083665

Reviewed by Justin Michaud.

This patch adds InBy megamorphic IC in all tiers. This is super similar to 
GetBy megamorphic IC.
Similar to GetBy megamorphic IC, we store structure/uid pair and the result. 
And when prototype objects
get changed, we bump the epoch (it is already done), and then all cache gets 
invalidated.

The only conceptual difference is that we can say `true` for custom accessor 
gets found. This is not
possible for GetBy megamorphic IC, but for InBy IC, it is OK since it is only 
asking whether it exists or not.

* Source/JavaScriptCore/bytecode/AccessCase.cpp:
(JSC::AccessCase::create):
(JSC::AccessCase::guardedByStructureCheckSkippingConstantIdentifierCheck const):
(JSC::AccessCase::requiresIdentifierNameMatch const):
(JSC::AccessCase::requiresInt32PropertyCheck const):
(JSC::AccessCase::forEachDependentCell const):
(JSC::AccessCase::doesCalls const):
(JSC::AccessCase::canReplace const):
(JSC::AccessCase::runWithDowncast):
(JSC::AccessCase::canBeShared):
* Source/JavaScriptCore/bytecode/AccessCase.h:
* Source/JavaScriptCore/bytecode/InByStatus.cpp:
(JSC::InByStatus::computeFor):
(JSC::InByStatus::computeForStubInfo):
(JSC::InByStatus::computeForStubInfoWithoutExitSiteFeedback):
(JSC::InByStatus::merge):
(JSC::InByStatus::dump const):
* Source/JavaScriptCore/bytecode/InByStatus.h:
* Source/JavaScriptCore/bytecode/InlineCacheCompiler.cpp:
(JSC::needsScratchFPR):
(JSC::forInBy):
(JSC::InlineCacheCompiler::generateWithGuard):
(JSC::InlineCacheCompiler::generateImpl):
(JSC::InlineCacheCompiler::regenerate):
* Source/JavaScriptCore/bytecode/InlineCacheCompiler.h:
(JSC::canUseMegamorphicInById):
* Source/JavaScriptCore/bytecode/Repatch.cpp:
(JSC::repatchInBySlowPathCall):
(JSC::tryCacheInBy):
(JSC::repatchInBy):
* Source/JavaScriptCore/bytecode/Repatch.h:
* Source/JavaScriptCore/bytecode/StructureStubInfo.cpp:
(JSC::StructureStubInfo::summary const):
(JSC::SharedJITStubSet::getMegamorphic const):
(JSC::SharedJITStubSet::setMegamorphic):
* Source/JavaScriptCore/bytecode/StructureStubInfo.h:
* Source/JavaScriptCore/dfg/DFGAbstractInterpreterInlines.h:
(JSC::DFG::AbstractInterpreter::executeEffects):
* Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::handleInById):
(JSC::DFG::ByteCodeParser::parseBlock):
* Source/JavaScriptCore/dfg/DFGClobberize.h:
(JSC::DFG::clobberize):
* Source/JavaScriptCore/dfg/DFGConstantFoldingPhase.cpp:
(JSC::DFG::ConstantFoldingPhase::foldConstants):
* Source/JavaScriptCore/dfg/DFGDoesGC.cpp:
(JSC::DFG::doesGC):
* Source/JavaScriptCore/dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::fixupNode):
* Source/JavaScriptCore/dfg/DFGNode.cpp:
(JSC::DFG::Node::convertToInByIdMaybeMegamorphic):
* Source/JavaScriptCore/dfg/DFGNode.h:
(JSC::DFG::Node::hasCacheableIdentifier):
(JSC::DFG::Node::cacheableIdentifier):

[webkit-changes] [WebKit/WebKit] 6edfdb: Fix build after 274683@main

[Tim Nguyen]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 6edfdbf00113ebda4e7b09f320894621be4c5073
  
https://github.com/WebKit/WebKit/commit/6edfdbf00113ebda4e7b09f320894621be4c5073
  Author: Tim Nguyen 
  Date:   2024-02-14 (Wed, 14 Feb 2024)

  Changed paths:
M Source/WebCore/rendering/style/RenderStyle.h

  Log Message:
  ---
  Fix build after 274683@main
https://bugs.webkit.org/show_bug.cgi?id=269410
rdar://122976910

Unreviewed build fix.

* Source/WebCore/rendering/style/RenderStyle.h:

Canonical link: https://commits.webkit.org/274686@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 562e65: Add Speedometer 3.0 preview content to browserbenc...

[Ryosuke Niwa]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 562e657d155ffd56f1f2967667f8009f0819768e
  
https://github.com/WebKit/WebKit/commit/562e657d155ffd56f1f2967667f8009f0819768e
  Author: Ryosuke Niwa 
  Date:   2024-02-14 (Wed, 14 Feb 2024)

  Changed paths:
A Websites/browserbench.org/Speedometer3.0-preview/Development.md
A Websites/browserbench.org/Speedometer3.0-preview/Governance.md
A Websites/browserbench.org/Speedometer3.0-preview/InteractiveRunner.html
A Websites/browserbench.org/Speedometer3.0-preview/LICENSE
A Websites/browserbench.org/Speedometer3.0-preview/README.md
A Websites/browserbench.org/Speedometer3.0-preview/Testing.md
A Websites/browserbench.org/Speedometer3.0-preview/babel.config.json
A Websites/browserbench.org/Speedometer3.0-preview/index.html
A Websites/browserbench.org/Speedometer3.0-preview/package-lock.json
A Websites/browserbench.org/Speedometer3.0-preview/package.json
A 
Websites/browserbench.org/Speedometer3.0-preview/resources/benchmark-runner.mjs
A 
Websites/browserbench.org/Speedometer3.0-preview/resources/charts/chartjs.html
A 
Websites/browserbench.org/Speedometer3.0-preview/resources/charts/chartjs.js
A 
Websites/browserbench.org/Speedometer3.0-preview/resources/charts/datasets/README
A 
Websites/browserbench.org/Speedometer3.0-preview/resources/charts/datasets/airports.csv
A 
Websites/browserbench.org/Speedometer3.0-preview/resources/charts/datasets/flights-airports.csv
A 
Websites/browserbench.org/Speedometer3.0-preview/resources/charts/developer.html
A 
Websites/browserbench.org/Speedometer3.0-preview/resources/charts/dist/assets/chartjs-7fd89fd7.js
A 
Websites/browserbench.org/Speedometer3.0-preview/resources/charts/dist/assets/flights-airports-9a9e6422.js
A 
Websites/browserbench.org/Speedometer3.0-preview/resources/charts/dist/assets/plot-37d2a5fb.js
A 
Websites/browserbench.org/Speedometer3.0-preview/resources/charts/dist/chartjs.html
A 
Websites/browserbench.org/Speedometer3.0-preview/resources/charts/dist/developer.html
A 
Websites/browserbench.org/Speedometer3.0-preview/resources/charts/dist/index.html
A 
Websites/browserbench.org/Speedometer3.0-preview/resources/charts/dist/observable-plot.html
A 
Websites/browserbench.org/Speedometer3.0-preview/resources/charts/index.html
A 
Websites/browserbench.org/Speedometer3.0-preview/resources/charts/observable-plot.html
A 
Websites/browserbench.org/Speedometer3.0-preview/resources/charts/observable-plot.js
A 
Websites/browserbench.org/Speedometer3.0-preview/resources/charts/package-lock.json
A 
Websites/browserbench.org/Speedometer3.0-preview/resources/charts/package.json
A 
Websites/browserbench.org/Speedometer3.0-preview/resources/charts/readme.md
A 
Websites/browserbench.org/Speedometer3.0-preview/resources/charts/vite.config.js
A 
Websites/browserbench.org/Speedometer3.0-preview/resources/developer-mode.mjs
A 
Websites/browserbench.org/Speedometer3.0-preview/resources/editors/.gitignore
A 
Websites/browserbench.org/Speedometer3.0-preview/resources/editors/assets/README.md
A 
Websites/browserbench.org/Speedometer3.0-preview/resources/editors/assets/longscript.js
A 
Websites/browserbench.org/Speedometer3.0-preview/resources/editors/assets/longtext.html
A 
Websites/browserbench.org/Speedometer3.0-preview/resources/editors/codemirror.html
A 
Websites/browserbench.org/Speedometer3.0-preview/resources/editors/codemirror.js
A 
Websites/browserbench.org/Speedometer3.0-preview/resources/editors/dist/assets/codemirror-521de7ab.js
A 
Websites/browserbench.org/Speedometer3.0-preview/resources/editors/dist/assets/index-2feebe42.css
A 
Websites/browserbench.org/Speedometer3.0-preview/resources/editors/dist/assets/index.es-02a92ebc.js
A 
Websites/browserbench.org/Speedometer3.0-preview/resources/editors/dist/assets/tiptap-95a40ba8.js
A 
Websites/browserbench.org/Speedometer3.0-preview/resources/editors/dist/codemirror.html
A 
Websites/browserbench.org/Speedometer3.0-preview/resources/editors/dist/index.html
A 
Websites/browserbench.org/Speedometer3.0-preview/resources/editors/dist/tiptap.html
A 
Websites/browserbench.org/Speedometer3.0-preview/resources/editors/dist/vite.svg
A 
Websites/browserbench.org/Speedometer3.0-preview/resources/editors/index.html
A 
Websites/browserbench.org/Speedometer3.0-preview/resources/editors/longtext.js
A 
Websites/browserbench.org/Speedometer3.0-preview/resources/editors/package-lock.json
A 
Websites/browserbench.org/Speedometer3.0-preview/resources/editors/package.json
A 
Websites/browserbench.org/Speedometer3.0-preview/resources/editors/public/vite.svg
A 
Websites/browserbench.org/Speedometer3.0-preview/resources/editors/readme.md
A 
Websites/browserbench.org/Speedometer3.0-preview/resources/editors/screenshot.jpg
A 

[webkit-changes] [WebKit/WebKit] ad9eeb: [iOS] Address fullscreen warning UI feedback

[Jer Noble]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: ad9eeb0d8d0e77fea0edd9be5888b24b083465bd
  
https://github.com/WebKit/WebKit/commit/ad9eeb0d8d0e77fea0edd9be5888b24b083465bd
  Author: Jer Noble 
  Date:   2024-02-14 (Wed, 14 Feb 2024)

  Changed paths:
M Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenViewController.mm

  Log Message:
  ---
  [iOS] Address fullscreen warning UI feedback
https://bugs.webkit.org/show_bug.cgi?id=269340
rdar://117099085

Reviewed by Aditya Keerthi.

Address feedback re: the fullscreen warning panel is visible upon entering 
fullscreen
by making two changes to the warning panel:

1. Move the panel to the top third of the screen, to avoid both media controls 
in the
   center of the screen, as well as controls along the bottom.

2. Allow the user to dismiss the warning panel by tapping on it; but ensure the 
panel
   is visible for a minimum amount of time, even if tapped.

* Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenViewController.mm:
(-[WKFullScreenViewController invalidate]):
(-[WKFullScreenViewController showBanner]):
(-[WKFullScreenViewController hideBanner]):
(-[WKFullScreenViewController _minimumHideDelayReached]):
(-[WKFullScreenViewController _bannerDismissalRecognized:]):
(-[WKFullScreenViewController loadView]):

Canonical link: https://commits.webkit.org/274684@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 4ef4a1: Move `position` from `NonInheritedFlags` to `Style...

[Tim Nguyen]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 4ef4a11dcf0223e2b3631f30ff6d567ecc16
  
https://github.com/WebKit/WebKit/commit/4ef4a11dcf0223e2b3631f30ff6d567ecc16
  Author: Tim Nguyen 
  Date:   2024-02-14 (Wed, 14 Feb 2024)

  Changed paths:
M Source/WebCore/rendering/style/RenderStyle.cpp
M Source/WebCore/rendering/style/RenderStyle.h
M Source/WebCore/rendering/style/RenderStyleInlines.h
M Source/WebCore/rendering/style/RenderStyleSetters.h
M Source/WebCore/rendering/style/StyleBoxData.cpp
M Source/WebCore/rendering/style/StyleBoxData.h

  Log Message:
  ---
  Move `position` from `NonInheritedFlags` to `StyleBoxData`
https://bugs.webkit.org/show_bug.cgi?id=269410
rdar://122976910

Reviewed by Aditya Keerthi and Darin Adler.

Free-up 3 bits from `NonInheritedFlags` for `::target-text` and 
`text-decoration-line: spelling-error/grammar-error`.

* Source/WebCore/rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::RenderStyle):
(WebCore::RenderStyle::NonInheritedFlags::copyNonInheritedFrom):
(WebCore::RenderStyle::hashForTextAutosizing const):
(WebCore::RenderStyle::equalForTextAutosizing const):
(WebCore::RenderStyle::changeRequiresLayout const):
* Source/WebCore/rendering/style/RenderStyle.h:
(WebCore::RenderStyle::position const): Deleted.
(WebCore::RenderStyle::setPosition): Deleted.
* Source/WebCore/rendering/style/RenderStyleInlines.h:
(WebCore::RenderStyle::position const):
* Source/WebCore/rendering/style/RenderStyleSetters.h:
(WebCore::RenderStyle::setPosition):
* Source/WebCore/rendering/style/StyleBoxData.cpp:
(WebCore::StyleBoxData::StyleBoxData):
(WebCore::StyleBoxData::operator== const):
* Source/WebCore/rendering/style/StyleBoxData.h:
(WebCore::StyleBoxData::position const):

Canonical link: https://commits.webkit.org/274683@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] cf4012: [WebXR] Remove texture size from createAndBindEGLI...

[Dan Glastonbury]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: cf4012b2fc39b2fd05e6b2011ffb5a5eae22df0d
  
https://github.com/WebKit/WebKit/commit/cf4012b2fc39b2fd05e6b2011ffb5a5eae22df0d
  Author: Dan Glastonbury 
  Date:   2024-02-14 (Wed, 14 Feb 2024)

  Changed paths:
M Source/WebCore/Modules/webxr/WebXROpaqueFramebuffer.cpp
M Source/WebCore/platform/graphics/GraphicsContextGL.h
M Source/WebCore/platform/graphics/angle/GraphicsContextGLANGLE.cpp
M Source/WebCore/platform/graphics/angle/GraphicsContextGLANGLE.h
M Source/WebCore/platform/graphics/cocoa/GraphicsContextGLCocoa.h
M Source/WebCore/platform/graphics/cocoa/GraphicsContextGLCocoa.mm
M Source/WebCore/platform/xr/PlatformXR.h
M Source/WebKit/GPUProcess/graphics/RemoteGraphicsContextGL.cpp
M Source/WebKit/GPUProcess/graphics/RemoteGraphicsContextGL.h
M Source/WebKit/GPUProcess/graphics/RemoteGraphicsContextGL.messages.in
M Source/WebKit/Shared/XR/PlatformXR.serialization.in
M Source/WebKit/UIProcess/XR/ios/PlatformXRARKit.mm
M Source/WebKit/WebProcess/GPU/graphics/RemoteGraphicsContextGLProxy.cpp
M Source/WebKit/WebProcess/GPU/graphics/RemoteGraphicsContextGLProxy.h
M 
Source/WebKit/WebProcess/GPU/graphics/cocoa/RemoteGraphicsContextGLProxyCocoa.mm

  Log Message:
  ---
  [WebXR] Remove texture size from createAndBindEGLImage result
https://bugs.webkit.org/show_bug.cgi?id=269280
rdar://122857763

Reviewed by Mike Wyrzykowski.

Don't return the size of external image from createAndBindEGLImage. The size of
the framebuffer and external images are already known by the calling code.

* Source/WebCore/Modules/webxr/WebXROpaqueFramebuffer.cpp:
(WebCore::createAndBindCompositorTexture):
(WebCore::createAndBindCompositorBuffer):
(WebCore::WebXROpaqueFramebuffer::startFrame):
* Source/WebCore/platform/graphics/GraphicsContextGL.h:
* Source/WebCore/platform/graphics/angle/GraphicsContextGLANGLE.cpp:
(WebCore::GraphicsContextGLANGLE::createAndBindEGLImage):
* Source/WebCore/platform/graphics/angle/GraphicsContextGLANGLE.h:
* Source/WebCore/platform/graphics/cocoa/GraphicsContextGLCocoa.h:
* Source/WebCore/platform/graphics/cocoa/GraphicsContextGLCocoa.mm:
(WebCore::GraphicsContextGLCocoa::createAndBindEGLImage):
* Source/WebCore/platform/xr/PlatformXR.h:
* Source/WebKit/GPUProcess/graphics/RemoteGraphicsContextGL.cpp:
(WebKit::RemoteGraphicsContextGL::createAndBindEGLImage):
* Source/WebKit/GPUProcess/graphics/RemoteGraphicsContextGL.h:
* Source/WebKit/Shared/XR/PlatformXR.serialization.in:
* Source/WebKit/WebProcess/GPU/graphics/RemoteGraphicsContextGLProxy.cpp:
(WebKit::RemoteGraphicsContextGLProxy::createAndBindEGLImage):
* Source/WebKit/WebProcess/GPU/graphics/RemoteGraphicsContextGLProxy.h:
* 
Source/WebKit/WebProcess/GPU/graphics/cocoa/RemoteGraphicsContextGLProxyCocoa.mm:

Canonical link: https://commits.webkit.org/274682@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 43d104: [CMake] Centralize cURL definitions

[Don Olmstead]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 43d1049f80d50d5f3e1ca94adf21fb82df8edb64
  
https://github.com/WebKit/WebKit/commit/43d1049f80d50d5f3e1ca94adf21fb82df8edb64
  Author: Don Olmstead 
  Date:   2024-02-14 (Wed, 14 Feb 2024)

  Changed paths:
A Source/WebKit/Platform/Curl.cmake
M Source/WebKit/PlatformPlayStation.cmake
M Source/WebKit/PlatformWin.cmake

  Log Message:
  ---
  [CMake] Centralize cURL definitions
https://bugs.webkit.org/show_bug.cgi?id=269424

Reviewed by Fujii Hironori.

Share `USE(CURL)` build definitions between ports.

* Source/WebKit/PlatformPlayStation.cmake:
* Source/WebKit/PlatformWin.cmake:
* Source/WebKit/Platform/Curl.cmake: Added.

Canonical link: https://commits.webkit.org/274681@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 9adf81: [view-transitions] Integrate pseudo-elements with ...

[Tim Nguyen]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 9adf8124721472c84c07e7974c4d5e6e8b086b1b
  
https://github.com/WebKit/WebKit/commit/9adf8124721472c84c07e7974c4d5e6e8b086b1b
  Author: Tim Nguyen 
  Date:   2024-02-14 (Wed, 14 Feb 2024)

  Changed paths:
M Source/WebCore/animation/AcceleratedTimeline.cpp
M Source/WebCore/animation/AcceleratedTimeline.h
M Source/WebCore/animation/CSSAnimation.cpp
M Source/WebCore/animation/CSSAnimation.h
M Source/WebCore/animation/CSSAnimationEvent.cpp
M Source/WebCore/animation/CSSAnimationEvent.h
M Source/WebCore/animation/CSSTransition.cpp
M Source/WebCore/animation/CSSTransition.h
M Source/WebCore/animation/CSSTransitionEvent.cpp
M Source/WebCore/animation/CSSTransitionEvent.h
M Source/WebCore/animation/ElementAnimationRareData.cpp
M Source/WebCore/animation/ElementAnimationRareData.h
M Source/WebCore/animation/KeyframeEffect.cpp
M Source/WebCore/animation/KeyframeEffect.h
M Source/WebCore/animation/StyleOriginatedAnimation.cpp
M Source/WebCore/animation/StyleOriginatedAnimation.h
M Source/WebCore/animation/StyleOriginatedAnimationEvent.cpp
M Source/WebCore/animation/StyleOriginatedAnimationEvent.h
M Source/WebCore/animation/WebAnimation.cpp
M Source/WebCore/animation/WebAnimationUtilities.cpp
M Source/WebCore/css/ComputedStyleExtractor.cpp
M Source/WebCore/dom/Element.cpp
M Source/WebCore/dom/Element.h
M Source/WebCore/dom/ElementRareData.h
M Source/WebCore/dom/PseudoElement.cpp
M Source/WebCore/dom/ViewTransition.cpp
M Source/WebCore/inspector/agents/InspectorCSSAgent.cpp
M Source/WebCore/inspector/agents/InspectorDOMAgent.cpp
M Source/WebCore/rendering/updating/RenderTreeUpdater.cpp
M Source/WebCore/rendering/updating/RenderTreeUpdaterGeneratedContent.cpp
M Source/WebCore/style/ElementRuleCollector.cpp
M Source/WebCore/style/ElementRuleCollector.h
M Source/WebCore/style/PseudoElementIdentifier.h
M Source/WebCore/style/PseudoElementRequest.h
M Source/WebCore/style/StyleResolver.cpp
M Source/WebCore/style/StyleResolver.h
M Source/WebCore/style/StyleSharingResolver.cpp
M Source/WebCore/style/StyleTreeResolver.cpp
M Source/WebCore/style/StyleTreeResolver.h
M Source/WebCore/style/Styleable.cpp
M Source/WebCore/style/Styleable.h

  Log Message:
  ---
  [view-transitions] Integrate pseudo-elements with animation code
https://bugs.webkit.org/show_bug.cgi?id=268064
rdar://121691532

Reviewed by Darin Adler.

In order to support view transitions, animation code needs to support the named 
argument for view transition pseudos, to be able to determine when the view 
transition ends.

Some of the code needs more fixes in order to work properly for view 
transitions, but this properly implements timing as a first step.

To achieve this goal, we refactor most animation code to use 
`std::optional` instead of `PseudoId`.

* Source/WebCore/animation/AcceleratedTimeline.cpp:
(WebCore::AcceleratedTimeline::updateEffectStacks):
(WebCore::AcceleratedTimeline::updateEffectStackForTarget):
* Source/WebCore/animation/AcceleratedTimeline.h:
* Source/WebCore/animation/CSSAnimation.cpp:
(WebCore::CSSAnimation::createEvent):
* Source/WebCore/animation/CSSAnimation.h:
* Source/WebCore/animation/CSSAnimationEvent.cpp:
(WebCore::CSSAnimationEvent::CSSAnimationEvent):
* Source/WebCore/animation/CSSAnimationEvent.h:
* Source/WebCore/animation/CSSTransition.cpp:
(WebCore::CSSTransition::createEvent):
* Source/WebCore/animation/CSSTransition.h:
* Source/WebCore/animation/CSSTransitionEvent.cpp:
(WebCore::CSSTransitionEvent::CSSTransitionEvent):
* Source/WebCore/animation/CSSTransitionEvent.h:
* Source/WebCore/animation/ElementAnimationRareData.cpp:
(WebCore::ElementAnimationRareData::ElementAnimationRareData):
* Source/WebCore/animation/ElementAnimationRareData.h:
(WebCore::ElementAnimationRareData::pseudoElementIdentifier):
(WebCore::ElementAnimationRareData::pseudoId const): Deleted.
* Source/WebCore/animation/KeyframeEffect.cpp:
(WebCore::KeyframeEffect::create):
(WebCore::KeyframeEffect::KeyframeEffect):
(WebCore::KeyframeEffect::copyPropertiesFromSource):
(WebCore::KeyframeEffect::getKeyframes):
(WebCore::KeyframeEffect::targetStyleable const):
(WebCore::KeyframeEffect::targetsPseudoElement const):
(WebCore::KeyframeEffect::pseudoElement const):
(WebCore::KeyframeEffect::setPseudoElement):
(WebCore::KeyframeEffect::isCurrentlyAffectingProperty const):
(WebCore::KeyframeEffect::applyPendingAcceleratedActions):
(WebCore::KeyframeEffect::ticksContinuouslyWhileActive const):
(WebCore::KeyframeEffect::computeHasAcceleratedPropertyOverriddenByCascadeProperty):
(WebCore::KeyframeEffect::abilityToBeAcceleratedDidChange):
(WebCore::KeyframeEffect::StackMembershipMutationScope::StackMembershipMutationScope):
(WebCore::KeyframeEffect::StackMembershipMutationScope::~StackMembershipMutationScope):
* 

[webkit-changes] [WebKit/WebKit] de2497: Unreviewed, reverting 274656@main.

[Commit Queue]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: de2497dd06501f25d66ca45e682fe0c12361e80d
  
https://github.com/WebKit/WebKit/commit/de2497dd06501f25d66ca45e682fe0c12361e80d
  Author: Commit Queue 
  Date:   2024-02-14 (Wed, 14 Feb 2024)

  Changed paths:
R Websites/browserbench.org/Speedometer3.0-preview

  Log Message:
  ---
  Unreviewed, reverting 274656@main.
https://bugs.webkit.org/show_bug.cgi?id=269422

Broke some bots

Reverted changeset:

"Add Speedometer 3.0 preview content to browserbench.org"
https://bugs.webkit.org/show_bug.cgi?id=269397
https://commits.webkit.org/274656@main

Canonical link: https://commits.webkit.org/274679@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] a69e24: MiniBrowser should take window size as a command l...

[bnham]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: a69e24351cef45d9fd008ba1fee356ef5bd49826
  
https://github.com/WebKit/WebKit/commit/a69e24351cef45d9fd008ba1fee356ef5bd49826
  Author: Ben Nham 
  Date:   2024-02-14 (Wed, 14 Feb 2024)

  Changed paths:
M Tools/MiniBrowser/mac/BrowserWindowController.m

  Log Message:
  ---
  MiniBrowser should take window size as a command line argument
https://bugs.webkit.org/show_bug.cgi?id=269383
rdar://problem/122959997

Reviewed by Sammy Gill.

Some of our benchmarks run at a particular window size (e.g. they may load 
cached subresources from
a responsive site based on viewport width media queries). To help debug those 
benchmarks it'd be
useful for MiniBrowser to be able to take the window size as an argument.

* Tools/MiniBrowser/mac/BrowserWindowController.m:
(-[BrowserWindowController windowDidLoad]):

Canonical link: https://commits.webkit.org/274678@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] b15425: [Gardening]: [ iOS ] 5x imported/w3c/web-platform-...

[Jay Saintfleur]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: b154253a9abe9f0b5f3001b33c5882c010f2aab8
  
https://github.com/WebKit/WebKit/commit/b154253a9abe9f0b5f3001b33c5882c010f2aab8
  Author: Jay Stfleur 
  Date:   2024-02-14 (Wed, 14 Feb 2024)

  Changed paths:
M LayoutTests/platform/ipad/TestExpectations

  Log Message:
  ---
  [Gardening]: [ iOS ] 5x imported/w3c/web-platform-tests are constant text 
failures
https://bugs.webkit.org/show_bug.cgi?id=122978657
rdar://122978657

Unreviewed test gardening.

Adding test expectation

* LayoutTests/platform/ipad/TestExpectations:

Canonical link: https://commits.webkit.org/274677@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 961bf5: Try to fix the UnifiedPDFPlugin build

[Tim Horton]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 961bf526844dade32fa9e67961480cd6a9fbf862
  
https://github.com/WebKit/WebKit/commit/961bf526844dade32fa9e67961480cd6a9fbf862
  Author: Tim Horton 
  Date:   2024-02-14 (Wed, 14 Feb 2024)

  Changed paths:
M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.h

  Log Message:
  ---
  Try to fix the UnifiedPDFPlugin build
https://bugs.webkit.org/show_bug.cgi?id=269419

Unreviewed speculative build fix.

* Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.h:

Canonical link: https://commits.webkit.org/274676@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] b23842: [CMake] Support USE(SKIA) build on PlayStation

[Don Olmstead]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: b2384277ae56839abfca022f4c70fdf6f9b38cc3
  
https://github.com/WebKit/WebKit/commit/b2384277ae56839abfca022f4c70fdf6f9b38cc3
  Author: Don Olmstead 
  Date:   2024-02-14 (Wed, 14 Feb 2024)

  Changed paths:
M Source/WebCore/PlatformPlayStation.cmake
M Source/WebKit/GPUProcess/EntryPoint/playstation/GPUProcessMain.cpp
M Source/WebKit/PlatformPlayStation.cmake
M Source/WebKit/UIProcess/API/C/playstation/WKPagePrivatePlayStation.cpp
M Source/WebKit/WebProcess/EntryPoint/playstation/WebProcessMain.cpp
M Source/cmake/OptionsPlayStation.cmake
M Tools/MiniBrowser/playstation/CMakeLists.txt
M Tools/MiniBrowser/playstation/WebViewWindow.cpp
M Tools/MiniBrowser/playstation/main.cpp
M Tools/TestWebKitAPI/playstation/main.cpp
M Tools/WebKitTestRunner/PlatformPlayStation.cmake

  Log Message:
  ---
  [CMake] Support USE(SKIA) build on PlayStation
https://bugs.webkit.org/show_bug.cgi?id=269250

Reviewed by Fujii Hironori.

Handle the `USE(SKIA)` case within the PlayStation build of WebKit. Modify the
build to handle both `USE(CAIRO)` and `USE(SKIA)`. Guard more code with
`USE(CAIRO)`.

Cairo has to be used when building the MiniBrowser at this time so also support
that.

Building Skia itself in a cross platform way will be in separate patches.

* Source/WebCore/PlatformPlayStation.cmake:
* Source/WebKit/GPUProcess/EntryPoint/playstation/GPUProcessMain.cpp:
(main):
* Source/WebKit/PlatformPlayStation.cmake:
* Source/WebKit/UIProcess/API/C/playstation/WKPagePrivatePlayStation.cpp:
(WKPagePaint):
* Source/WebKit/WebProcess/EntryPoint/playstation/WebProcessMain.cpp:
(main):
* Source/cmake/OptionsPlayStation.cmake:
* Tools/MiniBrowser/playstation/CMakeLists.txt:
* Tools/MiniBrowser/playstation/WebViewWindow.cpp:
(WebViewWindow::setSize):
(WebViewWindow::paintSelf):
* Tools/MiniBrowser/playstation/main.cpp:
(initialize):
* Tools/TestWebKitAPI/playstation/main.cpp:
(main):
* Tools/WebKitTestRunner/PlatformPlayStation.cmake:

Canonical link: https://commits.webkit.org/274675@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 7f1ed3: Adding myself to contributors.json

[Marcus Plutowski]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 7f1ed3ccb618143f71fddca1c2647e57ff485883
  
https://github.com/WebKit/WebKit/commit/7f1ed3ccb618143f71fddca1c2647e57ff485883
  Author: Marcus Plutowski 
  Date:   2024-02-14 (Wed, 14 Feb 2024)

  Changed paths:
M metadata/contributors.json

  Log Message:
  ---
  Adding myself to contributors.json
https://bugs.webkit.org/show_bug.cgi?id=269382
rdar://122963107

Reviewed by Justin Michaud and Yusuke Suzuki.

Adds myself to the list as a contributor.

* metadata/contributors.json:

Canonical link: https://commits.webkit.org/274674@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 632855: Adopt more smart pointers in FrameLoader.cpp

[Chris Dumez]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 6328556e366c4d5150c9a3403e5a7f66d419cc91
  
https://github.com/WebKit/WebKit/commit/6328556e366c4d5150c9a3403e5a7f66d419cc91
  Author: Chris Dumez 
  Date:   2024-02-14 (Wed, 14 Feb 2024)

  Changed paths:
M Source/WebCore/loader/FrameLoadRequest.cpp
M Source/WebCore/loader/FrameLoadRequest.h
M Source/WebCore/loader/FrameLoader.cpp

  Log Message:
  ---
  Adopt more smart pointers in FrameLoader.cpp
https://bugs.webkit.org/show_bug.cgi?id=269398

Reviewed by Brent Fulgham.

Adopt more smart pointers in FrameLoader.cpp, as recommended by the static 
analyzer.

* Source/WebCore/loader/FrameLoadRequest.cpp:
(WebCore::FrameLoadRequest::protectedRequester const):
(WebCore::FrameLoadRequest::protectedRequesterSecurityOrigin const):
* Source/WebCore/loader/FrameLoadRequest.h:
* Source/WebCore/loader/FrameLoader.cpp:
(WebCore::isInVisibleAndActivePage):
(WebCore::FrameLoader::submitForm):
(WebCore::shouldClearWindowName):
(WebCore::FrameLoader::didBeginDocument):
(WebCore::FrameLoader::outgoingReferrer const):
(WebCore::FrameLoader::setOpener):
(WebCore::FrameLoader::setFirstPartyForCookies):
(WebCore::FrameLoader::loadInSameDocument):
(WebCore::FrameLoader::completed):
(WebCore::FrameLoader::isNavigationAllowed const):
(WebCore::FrameLoader::loadURL):
(WebCore::FrameLoader::load):
(WebCore::FrameLoader::loadWithNavigationAction):
(WebCore::FrameLoader::loadWithDocumentLoader):
(WebCore::FrameLoader::setPolicyDocumentLoader):
(WebCore::FrameLoader::commitProvisionalLoad):
(WebCore::FrameLoader::numPendingOrLoadingRequests const):
(WebCore::FrameLoader::loadPostRequest):
(WebCore::FrameLoader::scrollToFragmentWithParentBoundary):
(WebCore::FrameLoader::shouldClose):
(WebCore::FrameLoader::dispatchBeforeUnloadEvent):
(WebCore::FrameLoader::shouldInterruptLoadForXFrameOptions):
(WebCore::FrameLoader::shouldTreatURLAsSameAsCurrent const):
(WebCore::FrameLoader::loadDifferentDocumentItem):
(WebCore::createWindow):

Canonical link: https://commits.webkit.org/274673@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 424698: [CMake] Centralize WC definitions

[Don Olmstead]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 42469865934158548fa1313cba5520571f041ec3
  
https://github.com/WebKit/WebKit/commit/42469865934158548fa1313cba5520571f041ec3
  Author: Don Olmstead 
  Date:   2024-02-14 (Wed, 14 Feb 2024)

  Changed paths:
M Source/WebCore/PlatformWin.cmake
M Source/WebCore/platform/TextureMapper.cmake
A Source/WebKit/Platform/WC.cmake
M Source/WebKit/PlatformPlayStation.cmake
M Source/WebKit/PlatformWin.cmake

  Log Message:
  ---
  [CMake] Centralize WC definitions
https://bugs.webkit.org/show_bug.cgi?id=269407

Reviewed by Fujii Hironori.

Share `USE(GRAPHICS_LAYER_WC)` build definitions between ports.

* Source/WebCore/PlatformWin.cmake:
* Source/WebCore/platform/TextureMapper.cmake:
* Source/WebKit/PlatformPlayStation.cmake:
* Source/WebKit/PlatformWin.cmake:
* Source/WebKit/Platform/WC.cmake: Added.

Canonical link: https://commits.webkit.org/274672@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 95e57b: UnifiedPDF: Discrete scrolling mode

[Tim Horton]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 95e57b0ff9882e5ebd1c28680930eb94ad52532c
  
https://github.com/WebKit/WebKit/commit/95e57b0ff9882e5ebd1c28680930eb94ad52532c
  Author: Tim Horton 
  Date:   2024-02-14 (Wed, 14 Feb 2024)

  Changed paths:
M Source/WebCore/platform/ScrollableArea.h
M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.h
M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm

  Log Message:
  ---
  UnifiedPDF: Discrete scrolling mode
https://bugs.webkit.org/show_bug.cgi?id=269399
rdar://121940957

Reviewed by Simon Fraser.

* Source/WebCore/platform/ScrollableArea.h:
* Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.h:
* Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm:
(WebKit::UnifiedPDFPlugin::updatePageBackgroundLayers):
(WebKit::UnifiedPDFPlugin::paintPDFContent):
Don't paint pages that we don't want displayed.

(WebKit::UnifiedPDFPlugin::updateLayerHierarchy):
(WebKit::UnifiedPDFPlugin::setPageScaleFactor):
(WebKit::UnifiedPDFPlugin::didChangeScrollOffset):
Determine if the currently-snapped page changed after each scroll.

(WebKit::UnifiedPDFPlugin::populateScrollSnapIdentifiers):
Make fake ElementIdentifiers for each PDF page to appease
insufficiently-DOM-agnostic scroll snapping code.

(WebKit::UnifiedPDFPlugin::pageForScrollSnapIdentifier const):
Find the page index for the given fake ElementIdentifier.

(WebKit::UnifiedPDFPlugin::shouldUseScrollSnapping const):
(WebKit::UnifiedPDFPlugin::updateSnapOffsets):
Build up a synthetic scroll snapping offset table for the PDF pages, with
required stop points at the beginning and end of each page.

(WebKit::UnifiedPDFPlugin::updateSnappedPage):
Look up which page is currently snapped, by scroll position.
This is a bit rough; ideally it would use the current snap point but you
often don't have one, so instead we just assume it's the last page that's not
too far past the current scroll position.
This could be improved.

(WebKit::UnifiedPDFPlugin::shouldDisplayPage):
Determine if the given page should be painted (based on the snapping location).
We show both the snapped page and the one next to it if we're in 2-up.

(WebKit::UnifiedPDFPlugin::performContextMenuAction):
Resnap when the mode is changed, if needed.

Canonical link: https://commits.webkit.org/274671@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] fd9c13: Regression(274445@main): Crash under HTMLMediaElem...

[Chris Dumez]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: fd9c1365ede0b2da49f029ef066691bcc823b9a4
  
https://github.com/WebKit/WebKit/commit/fd9c1365ede0b2da49f029ef066691bcc823b9a4
  Author: Chris Dumez 
  Date:   2024-02-14 (Wed, 14 Feb 2024)

  Changed paths:
M Source/WebCore/platform/PODInterval.h

  Log Message:
  ---
  Regression(274445@main): Crash under 
HTMLMediaElement::updateActiveTextTrackCues() on Hulu.com
https://bugs.webkit.org/show_bug.cgi?id=269394
rdar://122959342

Reviewed by Jer Noble.

In 274445@main, I updated CueInterval to be an alias to:
```
PODInterval>
```
instead of:
```
PODInterval
```
per our recent smart pointer guidelines.

When doing do, I noticed that PODInterval has different implementations when the
second type is a WeakPtr. Adopting WeakPtr led to build errors because the
PODInterval's specialization for WeakPtr was missing operator==(). To fix the
build, I copied the generic PODInterval's operator==() and used it. However, I
failed to noticed that the 2 specializations had different operator<()
implementations as well. In particular, the generic operator<() was checking
userData while the WeakPtr specialization one wasn't. This mismatch between
operator==() (which was checking userData) and operator<() (which wasn't 
checking
userData) was the cause of these crashes.

I now updated operator<() to be the same of both specializations (except for
calling `.get()` to extract the raw pointer from the WeakPtr) and this addressed
the crashes on hulu.com.

* Source/WebCore/platform/PODInterval.h:

Canonical link: https://commits.webkit.org/274670@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 7900c6: Exception in WebKit::WebExtensionTab::processes().

[Timothy Hatcher]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 7900c68de6a3191a59ddff3938d08e3334189187
  
https://github.com/WebKit/WebKit/commit/7900c68de6a3191a59ddff3938d08e3334189187
  Author: Timothy Hatcher 
  Date:   2024-02-14 (Wed, 14 Feb 2024)

  Changed paths:
M Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionTabCocoa.mm

  Log Message:
  ---
  Exception in WebKit::WebExtensionTab::processes().
https://webkit.org/b/269409
rdar://122974809

Reviewed by Jeff Miller and Brian Weinstein.

When mainWebView() is nil, we need to be careful. Use [NSArray 
arrayWithObjects:]
instead of [NSArray arrayWithObject:] since that will make a zero item array
if the web view is nil, instead of throwing an exception.

* Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionTabCocoa.mm:
(WebKit::WebExtensionTab::processes const):

Canonical link: https://commits.webkit.org/274669@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 51e91d: "Look Up" popover is not attached to highlighted w...

[Alan Baradlay]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 51e91d1ab3d410f7a84180cad93c22ccbec7f64f
  
https://github.com/WebKit/WebKit/commit/51e91d1ab3d410f7a84180cad93c22ccbec7f64f
  Author: Alan Baradlay 
  Date:   2024-02-14 (Wed, 14 Feb 2024)

  Changed paths:
M LayoutTests/accessibility/element-line-rects-and-text.html
M LayoutTests/editing/text-iterator/sequential-collapsed-ranges-expected.txt
M LayoutTests/editing/text-iterator/sequential-collapsed-ranges.html
M 
LayoutTests/editing/text-iterator/subrange-with-trailing-collapsed-whitespace-expected.txt
M 
LayoutTests/editing/text-iterator/subrange-with-trailing-collapsed-whitespace.html
M 
LayoutTests/platform/ios-simulator-wk2/accessibility/visible-character-range-height-changes-expected.txt
M 
LayoutTests/platform/ios-simulator-wk2/accessibility/visible-character-range-width-changes-expected.txt
M 
LayoutTests/platform/ios/accessibility/element-line-rects-and-text-expected.txt
M 
LayoutTests/platform/ios/accessibility/visible-character-range-basic-expected.txt
M 
LayoutTests/platform/ios/accessibility/visible-character-range-height-changes-expected.txt
M 
LayoutTests/platform/ios/accessibility/visible-character-range-width-changes-expected.txt
M 
LayoutTests/platform/mac/accessibility/element-line-rects-and-text-expected.txt
M 
LayoutTests/platform/mac/accessibility/visible-character-range-basic-expected.txt
M 
LayoutTests/platform/mac/accessibility/visible-character-range-height-changes-expected.txt
M 
LayoutTests/platform/mac/accessibility/visible-character-range-scrolling-expected.txt
M 
LayoutTests/platform/mac/accessibility/visible-character-range-width-changes-expected.txt
M Source/WebCore/editing/TextIterator.cpp
M Source/WebCore/editing/TextIteratorBehavior.h
M Source/WebCore/testing/Internals.cpp
M Source/WebCore/testing/Internals.h
M Source/WebCore/testing/Internals.idl
M Source/WebKit/WebProcess/WebPage/Cocoa/TextCheckingControllerProxy.mm

  Log Message:
  ---
  "Look Up" popover is not attached to highlighted words at the end of a line 
on New York Times
https://bugs.webkit.org/show_bug.cgi?id=269341


Reviewed by Ryosuke Niwa.

This patch ensures that we _always_ bail out of iterating the text content when 
beyond the range end position,
even when we are at a previously collapsed (trimmed) whitespace.
- remove TextIteratorBehavior::IgnoresWhiteSpaceAtEndOfRun workaround
- check for _range_ end (and not run end what IgnoresWhiteSpaceAtEndOfRun does) 
to see if we need to emit a whitespace

accessibility/element-line-rects-and-text.html seems to expect preserved 
trailing whitespace (the -expected.html change is unrelated to this patch
and is caused by continuation.

* LayoutTests/editing/text-iterator/sequential-collapsed-ranges.html:
* 
LayoutTests/editing/text-iterator/subrange-with-trailing-collapsed-whitespace.html:
* Source/WebCore/editing/TextIterator.cpp:
(WebCore::TextIterator::handleTextRun):
* Source/WebCore/editing/TextIteratorBehavior.h:
* Source/WebCore/testing/Internals.cpp:
(WebCore::Internals::locationFromRange):
(WebCore::Internals::lengthFromRange):
(WebCore::Internals::statesOfTextIterator):
(WebCore::toTextIteratorBehaviors): Deleted.
* Source/WebCore/testing/Internals.h:
* Source/WebCore/testing/Internals.idl:
* Source/WebKit/WebProcess/WebPage/Cocoa/TextCheckingControllerProxy.mm:
(WebKit::TextCheckingControllerProxy::annotatedSubstringBetweenPositions):

Canonical link: https://commits.webkit.org/274668@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] b307c2: [Skia] Implement conic gradients

[Georges Basile Stavracas Neto]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: b307c2ebeeb0c272a87b479fdf8cbf6c3bd027f6
  
https://github.com/WebKit/WebKit/commit/b307c2ebeeb0c272a87b479fdf8cbf6c3bd027f6
  Author: Georges Basile Stavracas Neto 
  Date:   2024-02-14 (Wed, 14 Feb 2024)

  Changed paths:
M Source/WebCore/platform/graphics/skia/GradientSkia.cpp

  Log Message:
  ---
  [Skia] Implement conic gradients
https://bugs.webkit.org/show_bug.cgi?id=269396

Reviewed by Don Olmstead.

Implement conic gradients using a Sweep gradient shader provided by
Skia. Skia renders it starting from the positive horizontal coordinate
space, so adjust that to what is expected for web by rotating it back
90 degress. The pivot point is the center of the conic.

* Source/WebCore/platform/graphics/skia/GradientSkia.cpp:
(WebCore::Gradient::shader):

Canonical link: https://commits.webkit.org/274667@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] d8d655: [WebGPU] Clamp depth values to the viewport range

[mwyrzykowski]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: d8d655468dab980b4a4d83a5e02dff57845f1e95
  
https://github.com/WebKit/WebKit/commit/d8d655468dab980b4a4d83a5e02dff57845f1e95
  Author: Mike Wyrzykowski 
  Date:   2024-02-14 (Wed, 14 Feb 2024)

  Changed paths:
M 
LayoutTests/http/tests/webgpu/webgpu/api/operation/rendering/depth_clip_clamp-expected.txt
M Source/WebGPU/WGSL/GlobalVariableRewriter.cpp
M Source/WebGPU/WGSL/Metal/MetalFunctionWriter.cpp
M Source/WebGPU/WebGPU/CommandEncoder.mm
M Source/WebGPU/WebGPU/RenderPassEncoder.h
M Source/WebGPU/WebGPU/RenderPassEncoder.mm
M Source/WebGPU/WebGPU/ShaderModule.h
M Source/WebGPU/WebGPU/ShaderModule.mm

  Log Message:
  ---
  [WebGPU] Clamp depth values to the viewport range
https://bugs.webkit.org/show_bug.cgi?id=264449


Reviewed by Tadeu Zagallo.

Add passing expectations for api,operation,rendering,depth_clip_clamp
and add depth clamping when the viewport is not the default [0, 1] range.

* 
LayoutTests/http/tests/webgpu/webgpu/api/operation/rendering/depth_clip_clamp-expected.txt:
* Source/WebGPU/WGSL/GlobalVariableRewriter.cpp:
(WGSL::RewriteGlobalVariables::insertParameters):
* Source/WebGPU/WGSL/Metal/MetalFunctionWriter.cpp:
(WGSL::Metal::FunctionDefinitionWriter::visit):
* Source/WebGPU/WebGPU/CommandEncoder.h:
* Source/WebGPU/WebGPU/CommandEncoder.mm:
(WebGPU::CommandEncoder::runDepthClampEncoder):
(WebGPU::CommandEncoder::beginRenderPass):
* Source/WebGPU/WebGPU/RenderPassEncoder.h:
* Source/WebGPU/WebGPU/RenderPassEncoder.mm:
(WebGPU::RenderPassEncoder::RenderPassEncoder):
(WebGPU::RenderPassEncoder::quantizedDepthValue):
(WebGPU::RenderPassEncoder::setPipeline):
(WebGPU::RenderPassEncoder::setViewport):

Canonical link: https://commits.webkit.org/274666@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 47b3bd: Parse externally_connectable properties from the m...

[kiaraarose]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 47b3bd6baca3b003554ea69f8bb809307fd999b4
  
https://github.com/WebKit/WebKit/commit/47b3bd6baca3b003554ea69f8bb809307fd999b4
  Author: Kiara Rose 
  Date:   2024-02-14 (Wed, 14 Feb 2024)

  Changed paths:
M Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionCocoa.mm
M Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionMatchPatternCocoa.mm
M Source/WebKit/UIProcess/Extensions/WebExtension.h
M Source/WebKit/UIProcess/Extensions/WebExtensionMatchPattern.h
M Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtension.mm

  Log Message:
  ---
  Parse externally_connectable properties from the manifest
https://bugs.webkit.org/show_bug.cgi?id=246491
rdar://114823306

Reviewed by Timothy Hatcher.

Parse externally_connectable properties from the manifest.

* Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionCocoa.mm:
(WebKit::WebExtension::populateExternallyConnectableIfNeeded):
(WebKit::WebExtension::externallyConnectableMatchPatterns):
(WebKit::WebExtension::allRequestedMatchPatterns):
* Source/WebKit/UIProcess/Extensions/WebExtension.h:

Canonical link: https://commits.webkit.org/274665@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 53c385: AX: WebKit fails to emit newlines between containe...

[Tyler Wilcock]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 53c3857f5cea7bb83096b8586ae9d4b430fe0031
  
https://github.com/WebKit/WebKit/commit/53c3857f5cea7bb83096b8586ae9d4b430fe0031
  Author: Tyler Wilcock 
  Date:   2024-02-14 (Wed, 14 Feb 2024)

  Changed paths:
M 
LayoutTests/accessibility/ax-thread-text-apis/display-contents-end-text-marker.html
M 
LayoutTests/accessibility/ax-thread-text-apis/text-marker-range-with-unordered-markers.html
A 
LayoutTests/accessibility/ax-thread-text-apis/text-marker-string-empty-paragraphs-expected.txt
A 
LayoutTests/accessibility/ax-thread-text-apis/text-marker-string-empty-paragraphs.html
M 
LayoutTests/accessibility/ax-thread-text-apis/text-marker-string-for-document-range.html
M 
LayoutTests/accessibility/ax-thread-text-apis/text-marker-with-user-select-none.html
M Source/WebCore/accessibility/AXCoreObject.h
M Source/WebCore/accessibility/AXLogger.cpp
M Source/WebCore/accessibility/AXTextMarker.cpp
M Source/WebCore/accessibility/AccessibilityNodeObject.cpp
M Source/WebCore/accessibility/AccessibilityNodeObject.h
M Source/WebCore/accessibility/AccessibilityObject.cpp
M Source/WebCore/accessibility/AccessibilityObject.h
M Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.cpp
M Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.h
M Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.h
M Source/WebCore/editing/TextIterator.cpp
M Source/WebCore/editing/TextIterator.h

  Log Message:
  ---
  AX: WebKit fails to emit newlines between container nodes when serving 
AXStringForTextMarkerRange off the main-thread
https://bugs.webkit.org/show_bug.cgi?id=269072
rdar://problem/122648346

Reviewed by Chris Fleizach.

Prior to this patch, AXTextMarker::findObjectWithRuns was basically just a 
wrapper over `findMatchingObjects`.
It has become clear that the traversal we need to do for text markers requires 
lots of custom hooks and behavior,
and it doesn't make sense to muddy `findMatchingObjects` for this single 
usecase, so this patch takes what we need
from `findMatchingObjects` and moves it directly into findObjectWithRuns.

This allows us to remove the `stopAtID` logic from `findMatchingObjects`. It 
also allows to add an "exit object"
hook to the traversal, which this patch uses to emit newlines when exiting a 
node that `shouldEmitNewlinesBeforeAndAfterNode`.
This matches the behavior of the TextIterator: dive into text-leaf nodes, and 
emit newlines for their containers on exit.

Prior to this patch, we never emitted any newline. Now we do, bringing us 
closer to passing several tests in
LayoutTests/accessibility/ax-thread-text-apis. This patch also documents in 
detail why several of these tests cotinue
to fail, and adds a new test that exercises interesting edgecases when we emit 
newlines for containers: text-marker-string-empty-paragraphs.html

* 
LayoutTests/accessibility/ax-thread-text-apis/display-contents-end-text-marker.html:
* 
LayoutTests/accessibility/ax-thread-text-apis/text-marker-range-with-unordered-markers.html:
* 
LayoutTests/accessibility/ax-thread-text-apis/text-marker-string-empty-paragraphs-expected.txt:
 Added.
* 
LayoutTests/accessibility/ax-thread-text-apis/text-marker-string-empty-paragraphs.html:
 Added.
* 
LayoutTests/accessibility/ax-thread-text-apis/text-marker-string-for-document-range.html:
* 
LayoutTests/accessibility/ax-thread-text-apis/text-marker-with-user-select-none.html:
* Source/WebCore/accessibility/AXCoreObject.h:
* Source/WebCore/accessibility/AXLogger.cpp:
(WebCore::operator<<):
* Source/WebCore/accessibility/AXTextMarker.cpp:
(WebCore::appendChildren):
(WebCore::findObjectWithRuns):
(WebCore::AXTextMarkerRange::toString const):
* Source/WebCore/accessibility/AccessibilityNodeObject.cpp:
(WebCore::AccessibilityNodeObject::shouldEmitNewlinesBeforeAndAfterNode const):
* Source/WebCore/accessibility/AccessibilityNodeObject.h:
* Source/WebCore/accessibility/AccessibilityObject.cpp:
(WebCore::Accessibility::isAccessibilityObjectSearchMatchAtIndex):
(WebCore::Accessibility::findMatchingObjects):
* Source/WebCore/accessibility/AccessibilityObject.h:
* Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.cpp:
(WebCore::AXIsolatedObject::initializeProperties):
* Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.h:
* Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.h:
* Source/WebCore/editing/TextIterator.cpp:
(WebCore::shouldEmitNewlinesBeforeAndAfterNode):
* Source/WebCore/editing/TextIterator.h:

Canonical link: https://commits.webkit.org/274664@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] c9407f: REGRESSION (December 2023?): 2x increase in JSC-Te...

[Justin Michaud]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c9407f23b73ea3d5b24c385330d2a2d413fe2b1f
  
https://github.com/WebKit/WebKit/commit/c9407f23b73ea3d5b24c385330d2a2d413fe2b1f
  Author: Justin Michaud 
  Date:   2024-02-14 (Wed, 14 Feb 2024)

  Changed paths:
M Source/JavaScriptCore/runtime/Options.cpp

  Log Message:
  ---
  REGRESSION (December 2023?): 2x increase in JSC-Tests-EWS build duration
https://bugs.webkit.org/show_bug.cgi?id=269245
rdar://121678486

Reviewed by Yusuke Suzuki.

Skip useRandomizingExecutableIslandAllocation on x86 where we don't use
jump islands anyway.

* Source/JavaScriptCore/runtime/Options.cpp:
(JSC::Options::notifyOptionsChanged):

Canonical link: https://commits.webkit.org/274663@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] e0b44d: Apply Markable to FontMetrics for consistency

[ChangSeok Oh]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: e0b44ddffaafdfc7549ba4cf4638e12f0ee53556
  
https://github.com/WebKit/WebKit/commit/e0b44ddffaafdfc7549ba4cf4638e12f0ee53556
  Author: ChangSeok Oh 
  Date:   2024-02-14 (Wed, 14 Feb 2024)

  Changed paths:
M Source/WebCore/css/CSSPrimitiveValue.cpp
M Source/WebCore/html/HTMLInputElement.cpp
M Source/WebCore/html/canvas/CanvasRenderingContext2DBase.cpp
M Source/WebCore/inspector/InspectorOverlay.cpp
M Source/WebCore/inspector/InspectorOverlayLabel.cpp
M Source/WebCore/layout/formattingContexts/inline/InlineLevelBox.h
M Source/WebCore/layout/formattingContexts/inline/InlineLineBox.cpp
M Source/WebCore/layout/formattingContexts/inline/InlineLineBoxBuilder.cpp
M 
Source/WebCore/layout/formattingContexts/inline/InlineLineBoxVerticalAligner.cpp
M Source/WebCore/layout/formattingContexts/inline/InlineQuirks.cpp
M 
Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayContentBuilder.cpp
M 
Source/WebCore/layout/formattingContexts/inline/ruby/RubyFormattingContext.cpp
M Source/WebCore/layout/integration/inline/LayoutIntegrationPagination.cpp
M Source/WebCore/platform/graphics/Font.cpp
M Source/WebCore/platform/graphics/FontCascade.cpp
M Source/WebCore/platform/graphics/FontMetrics.h
M Source/WebCore/platform/graphics/FontSizeAdjust.h
M Source/WebCore/platform/graphics/PositionedGlyphs.cpp
M Source/WebCore/platform/graphics/coretext/DrawGlyphsRecorderCoreText.cpp
M Source/WebCore/platform/graphics/coretext/FontCascadeCoreText.cpp
M Source/WebCore/platform/graphics/coretext/FontCoreText.cpp
M Source/WebCore/platform/graphics/opentype/OpenTypeVerticalData.cpp
M Source/WebCore/platform/win/DragImageWin.cpp
M Source/WebCore/rendering/CaretRectComputation.cpp
M Source/WebCore/rendering/EllipsisBoxPainter.cpp
M Source/WebCore/rendering/LegacyEllipsisBox.cpp
M Source/WebCore/rendering/LegacyInlineBox.cpp
M Source/WebCore/rendering/LegacyInlineFlowBox.cpp
M Source/WebCore/rendering/LegacyLineLayout.cpp
M Source/WebCore/rendering/LegacyRootInlineBox.cpp
M Source/WebCore/rendering/RenderBlock.cpp
M Source/WebCore/rendering/RenderBlockFlow.cpp
M Source/WebCore/rendering/RenderEmbeddedObject.cpp
M Source/WebCore/rendering/RenderFileUploadControl.cpp
M Source/WebCore/rendering/RenderImage.cpp
M Source/WebCore/rendering/RenderInline.cpp
M Source/WebCore/rendering/RenderLineBreak.cpp
M Source/WebCore/rendering/RenderListBox.cpp
M Source/WebCore/rendering/RenderListMarker.cpp
M Source/WebCore/rendering/RenderRubyRun.cpp
M Source/WebCore/rendering/TextBoxPainter.cpp
M Source/WebCore/rendering/TextPainter.cpp
M Source/WebCore/rendering/mathml/RenderMathMLBlock.cpp
M Source/WebCore/rendering/mathml/RenderMathMLRoot.cpp
M Source/WebCore/rendering/mathml/RenderMathMLScripts.cpp
M Source/WebCore/rendering/mathml/RenderMathMLUnderOver.cpp
M Source/WebCore/rendering/style/RenderStyle.cpp
M Source/WebCore/rendering/style/TextDecorationThickness.h
M Source/WebCore/rendering/svg/RenderSVGInlineText.cpp
M Source/WebCore/rendering/svg/SVGInlineTextBox.cpp
M Source/WebCore/rendering/svg/SVGTextLayoutEngineBaseline.cpp
M Source/WebCore/rendering/svg/SVGTextMetrics.cpp
M Source/WebCore/rendering/svg/SVGTextQuery.cpp
M Source/WebCore/rendering/updating/RenderTreeBuilderFirstLetter.cpp
M Source/WebCore/style/InlineTextBoxStyle.cpp
M Source/WebCore/style/StyleFontSizeFunctions.cpp
M Source/WebCore/svg/SVGLengthContext.cpp
M Source/WebKit/WebProcess/WebCoreSupport/win/WebPopupMenuWin.cpp
M Source/WebKit/WebProcess/WebPage/Cocoa/WebPageCocoa.mm
M Source/WebKitLegacy/mac/WebView/WebImmediateActionController.mm

  Log Message:
  ---
  Apply Markable to FontMetrics for consistency
https://bugs.webkit.org/show_bug.cgi?id=255378

Reviewed by Alan Baradlay and Matthieu Dubet.

This change aims at cleaning up the FontMetrics interface. There are three
inconsistencies in this class, which could mislead developers.

1. Inconsistent type of get/set methods. The set methods take float, but the
   corresponding get functions return int.
2. Inconsistent return types of get methods. For example, The height() returns
   an int, but the xHeight() returns a float.
3. Inconsistent validity checks. The xHeight and capHeight use their own has*
   functions, but the zeroWidth uses std::optional. Others font metrics do not
   provide any validity check methods.

This change applies Markable to FontMetrics and makes its interface
in the following way:

1. Each get method returns a float as default. To get an int value, callers
   should explicitly call the int* methods. (e.g., ascent() returns float and
   intAscent() returns int.)
2. Each font metric value is returned as a Markable value. So callers can check
   the validity with 

[webkit-changes] [WebKit/WebKit] 804619: [css-grid] Enable masonry feature flag

[Brandon Stewart]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 8046191c7d94629c89f5abf4ea436b340a0ec721
  
https://github.com/WebKit/WebKit/commit/8046191c7d94629c89f5abf4ea436b340a0ec721
  Author: Brandon Stewart 
  Date:   2024-02-14 (Wed, 14 Feb 2024)

  Changed paths:
M Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml

  Log Message:
  ---
  [css-grid] Enable masonry feature flag
https://bugs.webkit.org/show_bug.cgi?id=247074
rdar://101595681

Reviewed by Tim Nguyen and Brent Fulgham.

Enable masonry by default on platforms.

* Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml:

Canonical link: https://commits.webkit.org/274661@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 7003db: [Unified Text Replacement] `WebPage::autocorrectio...

[Richard Robinson]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 7003dbcab5b68f602cad24dd95030c9b67b26e73
  
https://github.com/WebKit/WebKit/commit/7003dbcab5b68f602cad24dd95030c9b67b26e73
  Author: Richard Robinson 
  Date:   2024-02-14 (Wed, 14 Feb 2024)

  Changed paths:
M Source/WebKit/WebProcess/WebPage/Cocoa/WebPageCocoa.mm

  Log Message:
  ---
  [Unified Text Replacement] `WebPage::autocorrectionContextRange` sometimes 
returns an incorrect range
https://bugs.webkit.org/show_bug.cgi?id=269385
rdar://122960194

Reviewed by Aditya Keerthi.

This function was previously (incorrectly) refactored; fix by reverting it to 
its original state,
and making the proper fix by simply null-checking the relevant range as 
appropriate.

Also add some clarifying comments.

* Source/WebKit/WebProcess/WebPage/Cocoa/WebPageCocoa.mm:
(WebKit::WebPage::autocorrectionContextRange):

Canonical link: https://commits.webkit.org/274660@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 98c763: [UnifiedPDF] Introduce AsyncPDFRenderer

[Simon Fraser]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 98c763e246170ff480978642d91f27ff6bff79e8
  
https://github.com/WebKit/WebKit/commit/98c763e246170ff480978642d91f27ff6bff79e8
  Author: Simon Fraser 
  Date:   2024-02-14 (Wed, 14 Feb 2024)

  Changed paths:
M Source/WebKit/Platform/Logging.h
M Source/WebKit/SourcesCocoa.txt
M Source/WebKit/WebKit.xcodeproj/project.pbxproj
M Source/WebKit/WebProcess/Plugins/PDF/PDFPluginBase.h
A Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/AsyncPDFRenderer.h
A Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/AsyncPDFRenderer.mm
M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.h

  Log Message:
  ---
  [UnifiedPDF] Introduce AsyncPDFRenderer
https://bugs.webkit.org/show_bug.cgi?id=269368
rdar://122950491

Reviewed by Tim Horton.

This is the first step to rendering PDF content off the main thread.

AsyncPDFRenderer is a TiledBackingClient, so gets notified when the TileBacking 
needs
to repaint a tile. This causes it to enqueue a request to render a tile 
(identified by
a grid index/tile index pair in `TileForGrid`) on a workqueue (currently 
serial, but likely
concurrent in future). The tile rendering request includes a `PDFPageCoverage`, 
which
describes the set of PDF pages and their geometry which will go into this tile.

Rendering a tile on the work queue involves allocating an in-process 
ImageBuffer, calling
PDFDocument for the PDFPages for this tile, and drawing them (without 
selection). That
ImageBuffer is then transferred back to the main thread, and put into a cache, 
again
keyed by `TileForGrid`.

When a tile render is complete, we need to trigger a repaint so we can paint 
the tile
in the normal painting code path. There's a little trickiness to avoid 
continual repaints,
which is handled by `AsyncPDFRenderer::willRepaintTile()`.

* Source/WebKit/Platform/Logging.h:
* Source/WebKit/SourcesCocoa.txt:
* Source/WebKit/WebKit.xcodeproj/project.pbxproj:
* Source/WebKit/WebProcess/Plugins/PDF/PDFPluginBase.h:
(WebKit::PDFPluginBase::pdfDocument const):
* Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/AsyncPDFRenderer.h: Added.
(WTF::TileForGridHash::hash):
(WTF::TileForGridHash::equal):
(WTF::HashTraits::emptyValue):
(WTF::HashTraits::deletedValue):
(WTF::HashTraits::constructDeletedValue):
(WTF::HashTraits::isDeletedValue):
(WebKit::AsyncPDFRenderer::paintingWorkQueue const):
* Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/AsyncPDFRenderer.mm: Added.
(WebKit::AsyncPDFRenderer::create):
(WebKit::AsyncPDFRenderer::AsyncPDFRenderer):
(WebKit::AsyncPDFRenderer::~AsyncPDFRenderer):
(WebKit::AsyncPDFRenderer::setupWithLayer):
(WebKit::AsyncPDFRenderer::willRepaintTile):
(WebKit::AsyncPDFRenderer::willRemoveTile):
(WebKit::AsyncPDFRenderer::willRepaintAllTiles):
(WebKit::AsyncPDFRenderer::clearCachedTiles):
(WebKit::AsyncPDFRenderer::enqueuePaintWithClip):
(WebKit::AsyncPDFRenderer::paintTileOnWorkQueue):
(WebKit::AsyncPDFRenderer::paintPDFIntoBuffer):
(WebKit::AsyncPDFRenderer::transferBufferToMainThread):
(WebKit::AsyncPDFRenderer::paintTileForClip):
* Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.h:

Canonical link: https://commits.webkit.org/274659@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 9c058f: Cherry-pick 274382@main (c4bb21451b14). https://bu...

[Loïc Yhuel]

  Branch: refs/heads/webkitglib/2.42
  Home:   https://github.com/WebKit/WebKit
  Commit: 9c058fc33ab4cc6ed53f35d0838dc8e078a1ff2a
  
https://github.com/WebKit/WebKit/commit/9c058fc33ab4cc6ed53f35d0838dc8e078a1ff2a
  Author: Loïc Yhuel 
  Date:   2024-02-14 (Wed, 14 Feb 2024)

  Changed paths:
M Source/WebCore/page/DOMWindow.cpp

  Log Message:
  ---
  Cherry-pick 274382@main (c4bb21451b14). 
https://bugs.webkit.org/show_bug.cgi?id=268915

REGRESSION(262334@main): Fix leak of SecurityOrigin with postMessage
https://bugs.webkit.org/show_bug.cgi?id=268915

Reviewed by Charlie Wolfe.

DOMWindow::createTargetOriginForPostMessage could return a new
SecurityOrigin with two refs.
It is only used with RefPtr, so we only need to have one ref.

* Source/WebCore/page/DOMWindow.cpp:
(WebCore::DOMWindow::createTargetOriginForPostMessage):

Canonical link: https://commits.webkit.org/274382@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] e07aea: [Gardening]: [ iOS wk2 ] 3 iOS orientation(layout-...

[Jay Saintfleur]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: e07aea8eea5ef60e0e305d5ff2acfb4ae2b4530e
  
https://github.com/WebKit/WebKit/commit/e07aea8eea5ef60e0e305d5ff2acfb4ae2b4530e
  Author: Jay Stfleur 
  Date:   2024-02-14 (Wed, 14 Feb 2024)

  Changed paths:
M LayoutTests/platform/ipad/TestExpectations

  Log Message:
  ---
  [Gardening]: [ iOS wk2 ] 3 iOS orientation(layout-tests) are constant text 
failures
https://bugs.webkit.org/show_bug.cgi?id=122963897
rdar://122963897

Unreviewed test gardening.

Adding test expectation

* LayoutTests/platform/ipad/TestExpectations:

Canonical link: https://commits.webkit.org/274658@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] fd87ee: [ GARDENING ][ Ventura Debug WK2 arm64 EWS ] http/...

[Robert Jenner]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: fd87eec432d83a2d84a4ba79995f856207f9583d
  
https://github.com/WebKit/WebKit/commit/fd87eec432d83a2d84a4ba79995f856207f9583d
  Author: Robert Jenner 
  Date:   2024-02-14 (Wed, 14 Feb 2024)

  Changed paths:
M LayoutTests/platform/mac-ventura/TestExpectations

  Log Message:
  ---
  [ GARDENING ][ Ventura Debug WK2 arm64 EWS ] 
http/tests/media/hls/track-in-band-multiple-cues.html is crashing
rdar://122967706
https://bugs.webkit.org/show_bug.cgi?id=269403

Unreviewed test gardening.

* LayoutTests/platform/mac-ventura/TestExpectations:

Canonical link: https://commits.webkit.org/274657@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 9458b1: Add Speedometer 3.0 preview content to browserbenc...

[Ryosuke Niwa]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 9458b1b53cdd8a487bc5e51aa568688195a227cd
  
https://github.com/WebKit/WebKit/commit/9458b1b53cdd8a487bc5e51aa568688195a227cd
  Author: Ryosuke Niwa 
  Date:   2024-02-14 (Wed, 14 Feb 2024)

  Changed paths:
A Websites/browserbench.org/Speedometer3.0-preview

  Log Message:
  ---
  Add Speedometer 3.0 preview content to browserbench.org
https://bugs.webkit.org/show_bug.cgi?id=269397

Reviewed by Chris Dumez.

Add Speedometer 3.0 preview content.

* Websites/browserbench.org/Speedometer3.0-preview: Added.

Canonical link: https://commits.webkit.org/274656@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 99d31c: Adopt more smart pointers in HTMLVideoElement / HT...

[Chris Dumez]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 99d31c7f2c1c447d83f1275db7ab9cb871684f96
  
https://github.com/WebKit/WebKit/commit/99d31c7f2c1c447d83f1275db7ab9cb871684f96
  Author: Chris Dumez 
  Date:   2024-02-14 (Wed, 14 Feb 2024)

  Changed paths:
M Source/WebCore/html/HTMLAudioElement.cpp
M Source/WebCore/html/HTMLImageElement.cpp
M Source/WebCore/html/HTMLPlugInImageElement.cpp
M Source/WebCore/html/HTMLVideoElement.cpp
M Source/WebCore/html/HTMLVideoElement.h
M Source/WebCore/html/ImageInputType.cpp
M Source/WebCore/loader/ImageLoader.cpp
M Source/WebCore/rendering/RenderImageResource.cpp
M Source/WebCore/rendering/RenderImageResource.h
M Source/WebCore/svg/SVGImageElement.cpp

  Log Message:
  ---
  Adopt more smart pointers in HTMLVideoElement / HTMLAudioElement
https://bugs.webkit.org/show_bug.cgi?id=269381

Reviewed by Darin Adler.

* Source/WebCore/html/HTMLAudioElement.cpp:
(WebCore::HTMLAudioElement::create):
(WebCore::HTMLAudioElement::createForLegacyFactoryFunction):
* Source/WebCore/html/HTMLImageElement.cpp:
(WebCore::HTMLImageElement::didAttachRenderers):
* Source/WebCore/html/HTMLPlugInImageElement.cpp:
(WebCore::HTMLPlugInImageElement::didAttachRenderers):
* Source/WebCore/html/HTMLVideoElement.cpp:
(WebCore::HTMLVideoElement::create):
(WebCore::HTMLVideoElement::didAttachRenderers):
(WebCore::HTMLVideoElement::attributeChanged):
(WebCore::HTMLVideoElement::supportsFullscreen const):
(WebCore::HTMLVideoElement::posterImageURL const):
(WebCore::HTMLVideoElement::exitToFullscreenModeWithoutAnimationIfPossible):
(WebCore::HTMLVideoElement::requestVideoFrameCallback):
(WebCore::HTMLVideoElement::serviceRequestVideoFrameCallbacks):
* Source/WebCore/html/HTMLVideoElement.h:
* Source/WebCore/html/ImageInputType.cpp:
(WebCore::ImageInputType::attach):
* Source/WebCore/loader/ImageLoader.cpp:
(WebCore::ImageLoader::updateRenderer):
* Source/WebCore/rendering/RenderImageResource.cpp:
(WebCore::RenderImageResource::setCachedImage):
* Source/WebCore/rendering/RenderImageResource.h:
* Source/WebCore/svg/SVGImageElement.cpp:
(WebCore::SVGImageElement::didAttachRenderers):

Canonical link: https://commits.webkit.org/274655@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 45d96d: [WPE] REGRESSION(274544@main): Build fails due to ...

[Adrian Perez]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 45d96da23f0121bd46d10a637ef6a76a3ed53cb3
  
https://github.com/WebKit/WebKit/commit/45d96da23f0121bd46d10a637ef6a76a3ed53cb3
  Author: Adrian Perez de Castro 
  Date:   2024-02-14 (Wed, 14 Feb 2024)

  Changed paths:
M Tools/ImageDiff/skia/PlatformImageSkia.cpp
M Tools/wpe/backends/fdo/HeadlessViewBackendFdo.cpp

  Log Message:
  ---
  [WPE] REGRESSION(274544@main): Build fails due to Clang -Wcast-align errors
https://bugs.webkit.org/show_bug.cgi?id=269360

Reviewed by Michael Catanzaro.

Use "#pragma GCC diagnostic ..." instead of "#pragma clang diagnostic ..."
because Clang will recognize the GCC variant but not the other way around.
This way we avoid GCC complaining due to -Wunknown-pragmas.

* Tools/ImageDiff/skia/PlatformImageSkia.cpp:
* Tools/wpe/backends/fdo/HeadlessViewBackendFdo.cpp:

Canonical link: https://commits.webkit.org/274654@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 5d528e: VAPI for register_script_message_handler of webkit...

[Michael Catanzaro]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 5d528e1cafcaa30bc59e66c78e5691830fdd0378
  
https://github.com/WebKit/WebKit/commit/5d528e1cafcaa30bc59e66c78e5691830fdd0378
  Author: Michael Catanzaro 
  Date:   2024-02-14 (Wed, 14 Feb 2024)

  Changed paths:
M Source/WebKit/UIProcess/API/glib/WebKitUserContentManager.cpp

  Log Message:
  ---
  VAPI for register_script_message_handler of webkitgtk-6.0 is wrong
https://bugs.webkit.org/show_bug.cgi?id=269358

Reviewed by Adrian Perez de Castro.

Too bad we don't get a warning when we typo the colon here.

* Source/WebKit/UIProcess/API/glib/WebKitUserContentManager.cpp:

Canonical link: https://commits.webkit.org/274653@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 46e0a7: Adopt even more smart pointer under WebCore/page/

[Chris Dumez]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 46e0a788746340ea0cabd5006bdac3e9f3c965cc
  
https://github.com/WebKit/WebKit/commit/46e0a788746340ea0cabd5006bdac3e9f3c965cc
  Author: Chris Dumez 
  Date:   2024-02-14 (Wed, 14 Feb 2024)

  Changed paths:
M Source/WebCore/bindings/js/JSDOMWindowBase.cpp
M Source/WebCore/css/CSSImportRule.cpp
M Source/WebCore/css/CSSImportRule.h
M Source/WebCore/page/CaptionUserPreferences.cpp
M Source/WebCore/page/ContextMenuController.cpp
M Source/WebCore/page/DeviceController.cpp
M Source/WebCore/page/DragController.cpp
M Source/WebCore/page/EventHandler.cpp
M Source/WebCore/page/FocusController.cpp
M Source/WebCore/page/FrameTree.cpp
M Source/WebCore/page/FrameView.cpp
M Source/WebCore/page/History.cpp
M Source/WebCore/page/LocalDOMWindow.cpp
M Source/WebCore/page/LocalDOMWindow.h
M Source/WebCore/page/LocalFrameView.cpp
M Source/WebCore/page/Location.cpp
M Source/WebCore/page/Page.cpp
M Source/WebCore/page/PageColorSampler.cpp
M Source/WebCore/page/PageDebuggable.cpp
M Source/WebCore/page/PageOverlay.cpp
M Source/WebCore/page/PageOverlayController.cpp
M Source/WebCore/page/PageOverlayController.h
M Source/WebCore/page/PageSerializer.cpp
M Source/WebCore/page/PerformanceLogging.cpp
M Source/WebCore/page/PerformanceNavigation.cpp
M Source/WebCore/page/PointerCaptureController.cpp
M Source/WebCore/page/ResizeObservation.cpp
M Source/WebCore/page/ResizeObservation.h
M Source/WebCore/page/ResizeObserver.cpp
M Source/WebCore/page/SettingsBase.cpp
M Source/WebCore/page/VisualViewport.cpp
M Source/WebCore/page/WorkerNavigator.cpp
M Source/WebCore/page/mac/EventHandlerMac.mm
M Source/WebCore/page/mac/ServicesOverlayController.mm
M Source/WebCore/page/scrolling/AsyncScrollingCoordinator.cpp
M Source/WebCore/page/scrolling/ScrollingCoordinator.cpp
M Source/WebCore/page/scrolling/ScrollingCoordinator.h
M Source/WebCore/page/scrolling/ScrollingStateFixedNode.cpp
M Source/WebCore/page/scrolling/ThreadedScrollingCoordinator.cpp
M Source/WebCore/page/scrolling/mac/ScrollingCoordinatorMac.mm
M Source/WebKit/WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMDOMWindow.cpp
M 
Source/WebKit/WebProcess/WebPage/RemoteLayerTree/RemoteScrollingCoordinator.mm

  Log Message:
  ---
  Adopt even more smart pointer under WebCore/page/
https://bugs.webkit.org/show_bug.cgi?id=269267

Reviewed by Ryosuke Niwa.

Adopt even more smart pointer under WebCore/page/, as recommended by the static
analyzer.

* Source/WebCore/bindings/js/JSDOMWindowBase.cpp:
* Source/WebCore/css/CSSImportRule.cpp:
(WebCore::CSSImportRule::protectedStyleSheet const):
* Source/WebCore/css/CSSImportRule.h:
* Source/WebCore/page/CaptionUserPreferences.cpp:
(WebCore::CaptionUserPreferences::userPrefersTextDescriptions const):
* Source/WebCore/page/ContextMenuController.cpp:
(WebCore::ContextMenuController::contextMenuItemSelected):
* Source/WebCore/page/DeviceController.cpp:
(WebCore::DeviceController::dispatchDeviceEvent):
* Source/WebCore/page/DragController.cpp:
(WebCore::elementUnderMouse):
(WebCore::DragController::draggableElement const):
* Source/WebCore/page/EventHandler.cpp:
(WebCore::EventHandler::nodeWillBeRemoved):
(WebCore::EventHandler::handleMouseMoveEvent):
(WebCore::EventHandler::handleMouseReleaseEvent):
* Source/WebCore/page/FocusController.cpp:
(WebCore::FocusController::findFocusableElementAcrossFocusScope):
(WebCore::FocusController::findFocusableElementWithinScope):
(WebCore::FocusController::nextFocusableElementWithinScope):
(WebCore::FocusController::previousFocusableElementWithinScope):
(WebCore::FocusController::advanceFocusDirectionallyInContainer):
* Source/WebCore/page/FrameTree.cpp:
(WebCore::inScope):
(WebCore::FrameTree::find const):
* Source/WebCore/page/FrameView.cpp:
(WebCore::FrameView::invalidateRect):
(WebCore::FrameView::scrollableAreaBoundingBox const):
* Source/WebCore/page/History.cpp:
(WebCore::History::stateObjectAdded):
* Source/WebCore/page/LocalDOMWindow.cpp:
(WebCore::LocalDOMWindow::frameElement const):
(WebCore::LocalDOMWindow::protectedFrameElement const):
(WebCore::LocalDOMWindow::scrollTo const):
(WebCore::LocalDOMWindow::setLocation):
* Source/WebCore/page/LocalDOMWindow.h:
* Source/WebCore/page/LocalFrameView.cpp:
(WebCore::LocalFrameView::updateSnapOffsets):
(WebCore::shouldEnableSpeculativeTilingDuringLoading):
(WebCore::LocalFrameView::safeToPropagateScrollToParent const):
(WebCore::LocalFrameView::updateScrollCorner):
(WebCore::LocalFrameView::updateLayoutAndStyleIfNeededRecursive):
* Source/WebCore/page/Location.cpp:
(WebCore::Location::setLocation):
* Source/WebCore/page/Page.cpp:
(WebCore::Page::useDarkAppearance const):
(WebCore::Page::hasLocalDataForURL):
(WebCore::Page::configureLoggingChannel):
(WebCore::Page::removeInjectedUserStyleSheet):

[webkit-changes] [WebKit/WebKit] 0f83fb: Adopt more smart pointer in generated JS bindings ...

[Chris Dumez]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 0f83fb62281e4da0335af451ba6bc67721505431
  
https://github.com/WebKit/WebKit/commit/0f83fb62281e4da0335af451ba6bc67721505431
  Author: Chris Dumez 
  Date:   2024-02-14 (Wed, 14 Feb 2024)

  Changed paths:
M Source/WebCore/bindings/scripts/CodeGeneratorJS.pm
M Source/WebCore/bindings/scripts/test/JS/JSExposedToWorkerAndWindow.cpp
M Source/WebCore/bindings/scripts/test/JS/JSShadowRealmGlobalScope.cpp
M Source/WebCore/bindings/scripts/test/JS/JSTestAsyncIterable.cpp
M Source/WebCore/bindings/scripts/test/JS/JSTestAsyncKeyValueIterable.cpp
M Source/WebCore/bindings/scripts/test/JS/JSTestCEReactions.cpp
M Source/WebCore/bindings/scripts/test/JS/JSTestCEReactionsStringifier.cpp
M Source/WebCore/bindings/scripts/test/JS/JSTestCallTracer.cpp
M 
Source/WebCore/bindings/scripts/test/JS/JSTestClassWithJSBuiltinConstructor.cpp
M Source/WebCore/bindings/scripts/test/JS/JSTestConditionalIncludes.cpp
M Source/WebCore/bindings/scripts/test/JS/JSTestConditionallyReadWrite.cpp
M Source/WebCore/bindings/scripts/test/JS/JSTestDefaultToJSON.cpp
M 
Source/WebCore/bindings/scripts/test/JS/JSTestDefaultToJSONFilteredByExposed.cpp
M 
Source/WebCore/bindings/scripts/test/JS/JSTestDelegateToSharedSyntheticAttribute.cpp
M Source/WebCore/bindings/scripts/test/JS/JSTestDomainSecurity.cpp
M Source/WebCore/bindings/scripts/test/JS/JSTestEnabledBySetting.cpp
M Source/WebCore/bindings/scripts/test/JS/JSTestEnabledForContext.cpp
M Source/WebCore/bindings/scripts/test/JS/JSTestException.cpp
M Source/WebCore/bindings/scripts/test/JS/JSTestGenerateAddOpaqueRoot.cpp
M Source/WebCore/bindings/scripts/test/JS/JSTestGenerateIsReachable.cpp
M Source/WebCore/bindings/scripts/test/JS/JSTestGlobalObject.cpp
M 
Source/WebCore/bindings/scripts/test/JS/JSTestIndexedSetterNoIdentifier.cpp
M 
Source/WebCore/bindings/scripts/test/JS/JSTestIndexedSetterThrowingException.cpp
M 
Source/WebCore/bindings/scripts/test/JS/JSTestIndexedSetterWithIdentifier.cpp
M Source/WebCore/bindings/scripts/test/JS/JSTestInterface.cpp
M 
Source/WebCore/bindings/scripts/test/JS/JSTestInterfaceLeadingUnderscore.cpp
M Source/WebCore/bindings/scripts/test/JS/JSTestIterable.cpp
M Source/WebCore/bindings/scripts/test/JS/JSTestLegacyFactoryFunction.cpp
M Source/WebCore/bindings/scripts/test/JS/JSTestLegacyNoInterfaceObject.cpp
M Source/WebCore/bindings/scripts/test/JS/JSTestLegacyOverrideBuiltIns.cpp
M Source/WebCore/bindings/scripts/test/JS/JSTestMapLike.cpp
M 
Source/WebCore/bindings/scripts/test/JS/JSTestMapLikeWithOverriddenOperations.cpp
M 
Source/WebCore/bindings/scripts/test/JS/JSTestNamedAndIndexedSetterNoIdentifier.cpp
M 
Source/WebCore/bindings/scripts/test/JS/JSTestNamedAndIndexedSetterThrowingException.cpp
M 
Source/WebCore/bindings/scripts/test/JS/JSTestNamedAndIndexedSetterWithIdentifier.cpp
M Source/WebCore/bindings/scripts/test/JS/JSTestNamedDeleterNoIdentifier.cpp
M 
Source/WebCore/bindings/scripts/test/JS/JSTestNamedDeleterThrowingException.cpp
M 
Source/WebCore/bindings/scripts/test/JS/JSTestNamedDeleterWithIdentifier.cpp
M 
Source/WebCore/bindings/scripts/test/JS/JSTestNamedDeleterWithIndexedGetter.cpp
M Source/WebCore/bindings/scripts/test/JS/JSTestNamedGetterCallWith.cpp
M Source/WebCore/bindings/scripts/test/JS/JSTestNamedGetterNoIdentifier.cpp
M 
Source/WebCore/bindings/scripts/test/JS/JSTestNamedGetterWithIdentifier.cpp
M Source/WebCore/bindings/scripts/test/JS/JSTestNamedSetterNoIdentifier.cpp
M 
Source/WebCore/bindings/scripts/test/JS/JSTestNamedSetterThrowingException.cpp
M 
Source/WebCore/bindings/scripts/test/JS/JSTestNamedSetterWithIdentifier.cpp
M 
Source/WebCore/bindings/scripts/test/JS/JSTestNamedSetterWithIndexedGetter.cpp
M 
Source/WebCore/bindings/scripts/test/JS/JSTestNamedSetterWithIndexedGetterAndSetter.cpp
M 
Source/WebCore/bindings/scripts/test/JS/JSTestNamedSetterWithLegacyOverrideBuiltIns.cpp
M 
Source/WebCore/bindings/scripts/test/JS/JSTestNamedSetterWithLegacyUnforgeableProperties.cpp
M 
Source/WebCore/bindings/scripts/test/JS/JSTestNamedSetterWithLegacyUnforgeablePropertiesAndLegacyOverrideBuiltIns.cpp
M Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp
M Source/WebCore/bindings/scripts/test/JS/JSTestOperationConditional.cpp
M Source/WebCore/bindings/scripts/test/JS/JSTestOverloadedConstructors.cpp
M 
Source/WebCore/bindings/scripts/test/JS/JSTestOverloadedConstructorsWithSequence.cpp
M Source/WebCore/bindings/scripts/test/JS/JSTestPluginInterface.cpp
M Source/WebCore/bindings/scripts/test/JS/JSTestReadOnlyMapLike.cpp
M Source/WebCore/bindings/scripts/test/JS/JSTestReadOnlySetLike.cpp
M Source/WebCore/bindings/scripts/test/JS/JSTestReportExtraMemoryCost.cpp
M 

[webkit-changes] [WebKit/WebKit] 7d3c8d: Add SPI to WKWebView for toggling in-window mode

[Dana Estra]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 7d3c8dd214517a4bda7aeb8aa5f609d16b74631c
  
https://github.com/WebKit/WebKit/commit/7d3c8dd214517a4bda7aeb8aa5f609d16b74631c
  Author: Dana Estra 
  Date:   2024-02-14 (Wed, 14 Feb 2024)

  Changed paths:
M Source/WebCore/platform/cocoa/PlaybackSessionModel.h
M Source/WebCore/platform/cocoa/PlaybackSessionModelMediaElement.h
M Source/WebCore/platform/cocoa/PlaybackSessionModelMediaElement.mm
M Source/WebCore/platform/ios/WebVideoFullscreenControllerAVKit.mm
M Source/WebCore/platform/mac/WebPlaybackControlsManager.h
M Source/WebCore/platform/mac/WebPlaybackControlsManager.mm
M Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm
M Source/WebKit/UIProcess/API/Cocoa/WKWebViewPrivate.h
M Source/WebKit/UIProcess/Cocoa/PlaybackSessionManagerProxy.h
M Source/WebKit/UIProcess/Cocoa/PlaybackSessionManagerProxy.mm
M Source/WebKit/UIProcess/mac/WebViewImpl.h
M Source/WebKit/UIProcess/mac/WebViewImpl.mm
M Source/WebKit/WebProcess/cocoa/PlaybackSessionManager.h
M Source/WebKit/WebProcess/cocoa/PlaybackSessionManager.messages.in
M Source/WebKit/WebProcess/cocoa/PlaybackSessionManager.mm

  Log Message:
  ---
  Add SPI to WKWebView for toggling in-window mode
https://bugs.webkit.org/show_bug.cgi?id=269032
rdar://122593920

Reviewed by Jer Noble.

This patch adds SPI to WKWebView _canToggleInWindow and _toggleInWindow, and a 
stub
for _isInWindowActive.

_canToggleInWindow uses the same heuristic as _canTogglePictureInPicture
To determine if there is a viable video on the webpage to put into in-window
Fullscreen mode.

_toggleInWindow toggles a viable video, if there is one, between
In-window and inline mode.

* Source/WebCore/platform/cocoa/PlaybackSessionModel.h:
* Source/WebCore/platform/cocoa/PlaybackSessionModelMediaElement.h:
* Source/WebCore/platform/cocoa/PlaybackSessionModelMediaElement.mm:
(WebCore::PlaybackSessionModelMediaElement::toggleInWindow):
(WebCore::PlaybackSessionModelMediaElement::isInWindowActive):
* Source/WebCore/platform/mac/WebPlaybackControlsManager.h:
* Source/WebCore/platform/mac/WebPlaybackControlsManager.mm:
(-[WebPlaybackControlsManager toggleInWindow]):
(-[WebPlaybackControlsManager isInWindowActive]):
* Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _canToggleInWindow]):
(-[WKWebView _isInWindowActive]):
(-[WKWebView _toggleInWindow]):
* Source/WebKit/UIProcess/API/Cocoa/WKWebViewPrivate.h:
* Source/WebKit/UIProcess/Cocoa/PlaybackSessionManagerProxy.h:
* Source/WebKit/UIProcess/Cocoa/PlaybackSessionManagerProxy.mm:
(WebKit::PlaybackSessionModelContext::toggleInWindow):
(WebKit::PlaybackSessionModelContext::isInWindowActive):
(WebKit::PlaybackSessionManagerProxy::toggleInWindow):
(WebKit::PlaybackSessionManagerProxy::isInWindowActive):
* Source/WebKit/UIProcess/mac/WebViewImpl.h:
* Source/WebKit/UIProcess/mac/WebViewImpl.mm:
(WebKit::WebViewImpl::isInWindowActive):
(WebKit::WebViewImpl::toggleInWindow):
* Source/WebKit/WebProcess/cocoa/PlaybackSessionManager.h:
* Source/WebKit/WebProcess/cocoa/PlaybackSessionManager.messages.in:
* Source/WebKit/WebProcess/cocoa/PlaybackSessionManager.mm:
(WebKit::PlaybackSessionManager::toggleInWindow):
(WebKit::PlaybackSessionManager::isInWindowActive):

Canonical link: https://commits.webkit.org/274650@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 886077: Add support for the devtools.network.onNavigated W...

[Timothy Hatcher]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 886077e077a496a6e398df52a4b7915d8cd68f76
  
https://github.com/WebKit/WebKit/commit/886077e077a496a6e398df52a4b7915d8cd68f76
  Author: Timothy Hatcher 
  Date:   2024-02-14 (Wed, 14 Feb 2024)

  Changed paths:
M Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionContextCocoa.mm
M Source/WebKit/UIProcess/Extensions/WebExtensionContext.h
M 
Source/WebKit/WebProcess/Extensions/API/Cocoa/WebExtensionAPIDevToolsNetworkCocoa.mm
M Source/WebKit/WebProcess/Extensions/WebExtensionContextProxy.h
M Source/WebKit/WebProcess/Extensions/WebExtensionContextProxy.messages.in
M Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionAPIDevTools.mm

  Log Message:
  ---
  Add support for the devtools.network.onNavigated Web Extension event.
https://webkit.org/b/246485
rdar://problem/114823326

Reviewed by BJ Burg.

* Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionContextCocoa.mm:
(WebKit::WebExtensionContext::loadInspectorBackgroundPage): Connect client to 
inspectedPageDidNavigate.
(WebKit::WebExtensionContext::inspectedPageDidNavigate): Added.
* Source/WebKit/UIProcess/Extensions/WebExtensionContext.h:
* 
Source/WebKit/WebProcess/Extensions/API/Cocoa/WebExtensionAPIDevToolsNetworkCocoa.mm:
(WebKit::WebExtensionContextProxy::dispatchDevToolsNetworkNavigatedEvent):
* Source/WebKit/WebProcess/Extensions/WebExtensionContextProxy.h:
* Source/WebKit/WebProcess/Extensions/WebExtensionContextProxy.messages.in:
* Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionAPIDevTools.mm:
(TEST(WKWebExtensionAPIDevTools, NetworkNavigatedEvent)): Added.

Canonical link: https://commits.webkit.org/274649@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] fa3538: Use `getCachedPseudoStyle` for view transition and...

[Tim Nguyen]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: fa3538d5a5b956dfa655a3aa26c5a9c940681fd9
  
https://github.com/WebKit/WebKit/commit/fa3538d5a5b956dfa655a3aa26c5a9c940681fd9
  Author: Tim Nguyen 
  Date:   2024-02-14 (Wed, 14 Feb 2024)

  Changed paths:
M Source/WebCore/rendering/RenderElement.cpp
M Source/WebCore/rendering/RenderElement.h
M Source/WebCore/rendering/RenderListItem.cpp
M Source/WebCore/rendering/RenderReplaced.cpp
M Source/WebCore/rendering/RenderText.h
M Source/WebCore/rendering/TextDecorationPainter.cpp
M Source/WebCore/rendering/svg/SVGInlineTextBox.cpp
M Source/WebCore/rendering/updating/RenderTreeUpdaterGeneratedContent.cpp
M Source/WebCore/rendering/updating/RenderTreeUpdaterViewTransition.cpp

  Log Message:
  ---
  Use `getCachedPseudoStyle` for view transition and highlight pseudo-elements
https://bugs.webkit.org/show_bug.cgi?id=269369
rdar://122950635

Reviewed by Anne van Kesteren.

Start using the cache now that it supports PseudoElementIdentifier since 
274629@main.

* Source/WebCore/rendering/RenderElement.cpp:
(WebCore::RenderElement::getCachedPseudoStyle const):
(WebCore::RenderElement::textSegmentPseudoStyle const):
* Source/WebCore/rendering/RenderElement.h:
* Source/WebCore/rendering/RenderListItem.cpp:
(WebCore::RenderListItem::computeMarkerStyle const):
* Source/WebCore/rendering/RenderReplaced.cpp:
(WebCore::RenderReplaced::calculateHighlightColor const):
* Source/WebCore/rendering/RenderText.h:
(WebCore::RenderText::getCachedPseudoStyle const):
* Source/WebCore/rendering/TextDecorationPainter.cpp:
(WebCore::collectStylesForRenderer):
* Source/WebCore/rendering/svg/SVGInlineTextBox.cpp:
(WebCore::SVGInlineTextBox::paint):
* Source/WebCore/rendering/updating/RenderTreeUpdaterGeneratedContent.cpp:
(WebCore::RenderTreeUpdater::GeneratedContent::updateBackdropRenderer):
* Source/WebCore/rendering/updating/RenderTreeUpdaterViewTransition.cpp:
(WebCore::RenderTreeUpdater::ViewTransition::updatePseudoElementTree):
(WebCore::RenderTreeUpdater::ViewTransition::buildPseudoElementGroup):
(WebCore::RenderTreeUpdater::ViewTransition::updatePseudoElementGroup):

Canonical link: https://commits.webkit.org/274648@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] cce92d: Adopt more smart pointers in WebCore/bindings

[Chris Dumez]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: cce92d99566ed92ff5c4bd3ad1855f5f5cf88976
  
https://github.com/WebKit/WebKit/commit/cce92d99566ed92ff5c4bd3ad1855f5f5cf88976
  Author: Chris Dumez 
  Date:   2024-02-14 (Wed, 14 Feb 2024)

  Changed paths:
M Source/JavaScriptCore/runtime/JSObject.h
M Source/WebCore/animation/WebAnimation.cpp
M Source/WebCore/animation/WebAnimation.h
M Source/WebCore/bindings/js/CachedModuleScriptLoader.cpp
M Source/WebCore/bindings/js/CachedScriptSourceProvider.h
M Source/WebCore/bindings/js/CommonVM.cpp
M Source/WebCore/bindings/js/CommonVM.h
M Source/WebCore/bindings/js/DOMGCOutputConstraint.h
M Source/WebCore/bindings/js/DOMPromiseProxy.h
M Source/WebCore/bindings/js/DOMWrapperWorld.cpp
M Source/WebCore/bindings/js/DOMWrapperWorld.h
M Source/WebCore/bindings/js/GCController.cpp
M Source/WebCore/bindings/js/IDBBindingUtilities.cpp
M Source/WebCore/bindings/js/InternalReadableStream.cpp
M Source/WebCore/bindings/js/InternalWritableStream.cpp
M Source/WebCore/bindings/js/JSCallbackData.cpp
M Source/WebCore/bindings/js/JSCustomElementInterface.cpp
M Source/WebCore/bindings/js/JSCustomElementRegistryCustom.cpp
M Source/WebCore/bindings/js/JSCustomEventCustom.cpp
M Source/WebCore/bindings/js/JSDOMAbstractOperations.h
M Source/WebCore/bindings/js/JSDOMAsyncIterator.h
M Source/WebCore/bindings/js/JSDOMBindingSecurity.cpp
M Source/WebCore/bindings/js/JSDOMBindingSecurityInlines.h
M Source/WebCore/bindings/js/JSDOMBuiltinConstructor.h
M Source/WebCore/bindings/js/JSDOMCastThisValue.h
M Source/WebCore/bindings/js/JSDOMConstructorBase.cpp
M Source/WebCore/bindings/js/JSDOMConvertAny.h
M Source/WebCore/bindings/js/JSDOMConvertBufferSource.h
M Source/WebCore/bindings/js/JSDOMConvertCallbacks.h
M Source/WebCore/bindings/js/JSDOMConvertDate.cpp
M Source/WebCore/bindings/js/JSDOMConvertEnumeration.h
M Source/WebCore/bindings/js/JSDOMConvertEventListener.h
M Source/WebCore/bindings/js/JSDOMExceptionHandling.cpp
M Source/WebCore/bindings/js/JSDOMGlobalObject.cpp
M Source/WebCore/bindings/js/JSDOMGlobalObject.h
M Source/WebCore/bindings/js/JSDOMGuardedObject.cpp
M Source/WebCore/bindings/js/JSDOMIterator.cpp
M Source/WebCore/bindings/js/JSDOMIterator.h
M Source/WebCore/bindings/js/JSDOMMapLike.h
M Source/WebCore/bindings/js/JSDOMMicrotask.cpp
M Source/WebCore/bindings/js/JSDOMOperation.h
M Source/WebCore/bindings/js/JSDOMPromise.cpp
M Source/WebCore/bindings/js/JSDOMPromiseDeferred.cpp
M Source/WebCore/bindings/js/JSDOMPromiseDeferred.h
M Source/WebCore/bindings/js/JSDOMSetLike.cpp
M Source/WebCore/bindings/js/JSDOMSetLike.h
M Source/WebCore/bindings/js/JSDOMWindowBase.cpp
M Source/WebCore/bindings/js/JSDOMWindowProperties.cpp
M Source/WebCore/bindings/js/JSDOMWrapper.cpp
M Source/WebCore/bindings/js/JSDOMWrapperCache.h
M Source/WebCore/bindings/js/JSDocumentCustom.cpp
M Source/WebCore/bindings/js/JSElementCustom.cpp
M Source/WebCore/bindings/js/JSElementInternalsCustom.cpp
M Source/WebCore/bindings/js/JSErrorHandler.cpp
M Source/WebCore/bindings/js/JSEventListener.cpp
M Source/WebCore/bindings/js/JSEventListener.h
M Source/WebCore/bindings/js/JSEventTargetCustom.h
M Source/WebCore/bindings/js/JSExecState.cpp
M Source/WebCore/bindings/js/JSExecState.h
M Source/WebCore/bindings/js/JSExtendableMessageEventCustom.cpp
M Source/WebCore/bindings/js/JSHTMLAllCollectionCustom.cpp
M Source/WebCore/bindings/js/JSHTMLElementCustom.cpp
M Source/WebCore/bindings/js/JSHistoryCustom.cpp
M Source/WebCore/bindings/js/JSImageDataCustom.cpp
M Source/WebCore/bindings/js/JSKeyframeEffectCustom.cpp
M Source/WebCore/bindings/js/JSLazyEventListener.cpp
M Source/WebCore/bindings/js/JSLocalDOMWindowCustom.cpp
M Source/WebCore/bindings/js/JSLocationCustom.cpp
M Source/WebCore/bindings/js/JSMicrotaskCallback.h
M Source/WebCore/bindings/js/JSNodeCustom.cpp
M Source/WebCore/bindings/js/JSObservableArray.cpp
M Source/WebCore/bindings/js/JSObservableArray.h
M Source/WebCore/bindings/js/JSPopStateEventCustom.cpp
M Source/WebCore/bindings/js/JSRTCRtpSFrameTransformCustom.cpp
M Source/WebCore/bindings/js/JSReadableStreamSourceCustom.cpp
M Source/WebCore/bindings/js/JSRemoteDOMWindowBase.cpp
M Source/WebCore/bindings/js/JSRemoteDOMWindowBase.h
M Source/WebCore/bindings/js/JSRemoteDOMWindowCustom.cpp
M Source/WebCore/bindings/js/JSShadowRootCustom.cpp
M Source/WebCore/bindings/js/JSWebAnimationCustom.cpp
M Source/WebCore/bindings/js/JSWindowProxy.cpp
M Source/WebCore/bindings/js/JSWorkerGlobalScopeBase.cpp
M Source/WebCore/bindings/js/JSWorkerGlobalScopeCustom.cpp
M Source/WebCore/bindings/js/ModuleScriptLoader.h
M 

[webkit-changes] [WebKit/WebKit] 3bfd75: [UnifiedPDF] Find in PDF without overlays

[Sammy Gill]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 3bfd7513a9aff5e2ae3f35fbf1547843adf0306a
  
https://github.com/WebKit/WebKit/commit/3bfd7513a9aff5e2ae3f35fbf1547843adf0306a
  Author: Sammy Gill 
  Date:   2024-02-14 (Wed, 14 Feb 2024)

  Changed paths:
M Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.h
M Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.mm
M Source/WebKit/WebProcess/Plugins/PDF/PDFPluginBase.h
M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/PDFDocumentLayout.h
M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/PDFDocumentLayout.mm
M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.h
M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm

  Log Message:
  ---
  [UnifiedPDF] Find in PDF without overlays
https://bugs.webkit.org/show_bug.cgi?id=269328
rdar://problem/122917321

Reviewed by Tim Horton.

Provides the initial support for the find in PDF functionality. This
is done by querying the PDFDocument for the string that was passed in
for search.

In order to accomplish this we need to keep track of the last string
that was searched for. If the target string is the same as the last one
then we need to continue the search from the last match/result we found.
We keep track of the results as the current selection. If the target is
not as the last string we found, then we need to clear the selection
before we attempt to search for the string.

When we find the string we will update its selection to the one that
was returned to us from PDFDocument and potentially scroll to it if it
is currently out of view.

* Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.h:
* Source/WebKit/WebProcess/Plugins/PDF/PDFPluginBase.h:
* Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/PDFDocumentLayout.h:
* Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/PDFDocumentLayout.mm:
(WebKit::PDFDocumentLayout::pdfPageRectToDocumentRect const):
* Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.h:
* Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm:
(WebKit::UnifiedPDFPlugin::convertFromPageToDocument const):
(WebKit::UnifiedPDFPlugin::convertFromPageToContents const):
(WebKit::UnifiedPDFPlugin::countFindMatches):
(WebKit::UnifiedPDFPlugin::findString):

Canonical link: https://commits.webkit.org/274646@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] bbc211: Add support for the devtools.inspectedWindow Web E...

[Timothy Hatcher]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: bbc211140430e58da5821a8e87d1f6736a984929
  
https://github.com/WebKit/WebKit/commit/bbc211140430e58da5821a8e87d1f6736a984929
  Author: Timothy Hatcher 
  Date:   2024-02-14 (Wed, 14 Feb 2024)

  Changed paths:
M 
Source/WebInspectorUI/UserInterface/Controllers/WebInspectorExtensionController.js
M Source/WebKit/Shared/InspectorExtensionTypes.h
M Source/WebKit/UIProcess/API/APIInspectorExtension.cpp
M Source/WebKit/UIProcess/API/APIInspectorExtension.h
M Source/WebKit/UIProcess/API/Cocoa/_WKInspectorExtension.mm
A 
Source/WebKit/UIProcess/Extensions/Cocoa/API/WebExtensionContextAPIDevToolsInspectedWindow.mm
M 
Source/WebKit/UIProcess/Extensions/Cocoa/API/WebExtensionContextAPIDevToolsPanels.mm
M Source/WebKit/UIProcess/Extensions/WebExtensionContext.h
M Source/WebKit/UIProcess/Extensions/WebExtensionContext.messages.in
M 
Source/WebKit/UIProcess/Inspector/WebInspectorUIExtensionControllerProxy.cpp
M Source/WebKit/UIProcess/Inspector/WebInspectorUIExtensionControllerProxy.h
M Source/WebKit/WebKit.xcodeproj/project.pbxproj
M 
Source/WebKit/WebProcess/Extensions/API/Cocoa/WebExtensionAPIDevToolsInspectedWindowCocoa.mm
M 
Source/WebKit/WebProcess/Extensions/API/WebExtensionAPIDevToolsInspectedWindow.h
M 
Source/WebKit/WebProcess/Extensions/Interfaces/WebExtensionAPIDevToolsInspectedWindow.idl
M Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionAPIDevTools.mm

  Log Message:
  ---
  Add support for the devtools.inspectedWindow Web Extension APIs.
https://webkit.org/bug/246485
rdar://problem/114823326

Reviewed by Jeff Miller and BJ Burg.

Adds support for the eval() and reload() functions on devtools.inspectedWindow.
This is primarily implemented by API::InspectorExtension and Inspector code.

This implementation of eval() properly returns the result as an array of two 
values,
the result and error, like Chrome and Firefox. The Safari implementation just 
returned
the result and never provided the exception details.

Also removed the plumbing for reload to return a evaluation result. This was 
never the
case, and the Web Extension spec does not provide a result.

* 
Source/WebInspectorUI/UserInterface/Controllers/WebInspectorExtensionController.js:
(WI.WebInspectorExtensionController.prototype.async evaluateScriptForExtension):
(WI.WebInspectorExtensionController.prototype.reloadForExtension): Don't use an 
eval result
since reload does not provide a result to Web Extensions.
* Source/WebKit/Shared/InspectorExtensionTypes.h: Use Ref instead of RefPtr.
* Source/WebKit/UIProcess/API/APIInspectorExtension.cpp:
(API::InspectorExtension::reloadIgnoringCache):
* Source/WebKit/UIProcess/API/APIInspectorExtension.h:
* Source/WebKit/UIProcess/API/Cocoa/_WKInspectorExtension.mm:
(-[_WKInspectorExtension 
reloadIgnoringCache:userAgent:injectedScript:completionHandler:]):
* 
Source/WebKit/UIProcess/Extensions/Cocoa/API/WebExtensionContextAPIDevToolsInspectedWindow.mm:
 Added.
(WebKit::WebExtensionContext::devToolsInspectedWindowEval):
(WebKit::WebExtensionContext::devToolsInspectedWindowReload):
* 
Source/WebKit/UIProcess/Extensions/Cocoa/API/WebExtensionContextAPIDevToolsPanels.mm:
(WebKit::WebExtensionContext::devToolsPanelsCreate):
* Source/WebKit/UIProcess/Extensions/WebExtensionContext.h:
* Source/WebKit/UIProcess/Extensions/WebExtensionContext.messages.in:
* Source/WebKit/UIProcess/Inspector/WebInspectorUIExtensionControllerProxy.cpp:
(WebKit::WebInspectorUIExtensionControllerProxy::evaluateScriptForExtension):
(WebKit::WebInspectorUIExtensionControllerProxy::reloadForExtension):
(WebKit::WebInspectorUIExtensionControllerProxy::evaluateScriptInExtensionTab):
* Source/WebKit/UIProcess/Inspector/WebInspectorUIExtensionControllerProxy.h:
* Source/WebKit/WebKit.xcodeproj/project.pbxproj:
* 
Source/WebKit/WebProcess/Extensions/API/Cocoa/WebExtensionAPIDevToolsInspectedWindowCocoa.mm:
(WebKit::WebExtensionAPIDevToolsInspectedWindow::eval):
(WebKit::WebExtensionAPIDevToolsInspectedWindow::reload):
* 
Source/WebKit/WebProcess/Extensions/API/WebExtensionAPIDevToolsInspectedWindow.h:
* 
Source/WebKit/WebProcess/Extensions/Interfaces/WebExtensionAPIDevToolsInspectedWindow.idl:
* Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionAPIDevTools.mm:
(TEST(WKWebExtensionAPIDevTools, InspectedWindowEval)): Added.
(TEST(WKWebExtensionAPIDevTools, InspectedWindowReload)): Added.
(TEST(WKWebExtensionAPIDevTools, InspectedWindowReloadIgnoringCache)): Added.

Canonical link: https://commits.webkit.org/274645@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 1da9e9: Set DeletingAllowed for bmalloc::Heap::m_largeAllo...

[aoikonomopoulos]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 1da9e9d6ada35701cb3c9438c5305eeabfd7e53e
  
https://github.com/WebKit/WebKit/commit/1da9e9d6ada35701cb3c9438c5305eeabfd7e53e
  Author: Angelos Oikonomopoulos 
  Date:   2024-02-14 (Wed, 14 Feb 2024)

  Changed paths:
M Source/bmalloc/bmalloc/Heap.h

  Log Message:
  ---
  Set DeletingAllowed for bmalloc::Heap::m_largeAllocated
https://bugs.webkit.org/show_bug.cgi?id=269357

Reviewed by Michael Saboff.

https://commits.webkit.org/274606@main added an AllowDeleting parameter
to bmalloc::Map, which defaults to DeletingNotAllowed. However, this
default does not work for the Map in bmalloc/Heap.h, leading to massive
JSC breakage on platforms that haven't switched to libpas. Set it to
DeletingAllowed instead.

* Source/bmalloc/bmalloc/Heap.h:

Canonical link: https://commits.webkit.org/274644@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 3e214a: [GStreamer] Buffer end equals video duration for p...

[Enrique Ocaña González]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 3e214abe945921fb2ebbf234c7bfd1dab35cea9e
  
https://github.com/WebKit/WebKit/commit/3e214abe945921fb2ebbf234c7bfd1dab35cea9e
  Author: Enrique Ocaña González 
  Date:   2024-02-14 (Wed, 14 Feb 2024)

  Changed paths:
M Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp

  Log Message:
  ---
  [GStreamer] Buffer end equals video duration for progressive video
https://bugs.webkit.org/show_bug.cgi?id=269203

Reviewed by Philippe Normand.

On some long regular videos, the current buffer management mechanism
reports 100% of the video as loaded when that's not actually happening.
This causes document.getElementsByTagName('video')[0].buffered.end(0) to
be equal to document.getElementsByTagName('video')[0].duration when that
should clearly not the case.

The current default way of computing m_maxTimeLoaded isn't working
properly because oftern, when the buffering messages are received by
MediaPlayerPrivateGStreamer, the duration is still unknown and the code
in charge of computing the fill status bails out.

The WebKitWebSrc network downloading statistics provide a much more
accurate source of information for the buffered data, and should be used
in more cases when available. The download statistics tend to arrive
later than the buffer fill messages and at that moment duration is
already available, leading to a proper computation of m_maxTimeLoaded.

See: https://github.com/WebPlatformForEmbedded/WPEWebKit/pull/1238

This patch calls updateMaxTimeLoaded() when the network statistics are
received. That update must be done here because the current system in
place to perform such update is based on m_fillTimer, and when the
network stats are received the timer is usually already stopped. This
method works fine both with on-disk cache and without it (the typical
use case on set-top-box devices).

Original patch authored by: suresh-khurdiya-epam 


* Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::handleMessage): When a 
webkit-network-statistics message is received, compute the fill status and 
update m_maxTimeLoaded.

Canonical link: https://commits.webkit.org/274643@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 4bbbd7: [Gardening]: New Test (274419@main): [ iOS Debug ]...

[Jay Saintfleur]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 4bbbd725c85076f3171c34b28d86b5bf047a2403
  
https://github.com/WebKit/WebKit/commit/4bbbd725c85076f3171c34b28d86b5bf047a2403
  Author: Jay Stfleur 
  Date:   2024-02-14 (Wed, 14 Feb 2024)

  Changed paths:
M LayoutTests/platform/ios-wk2/TestExpectations

  Log Message:
  ---
  [Gardening]: New Test (274419@main): [ iOS Debug ] 
fast/forms/switch/click-dis abled.html is a constantly crashing
https://bugs.webkit.org/show_bug.cgi?id=122956268
rdar://122956268

Unreviewed test gardening.

Adding test expectation

* LayoutTests/platform/ios-wk2/TestExpectations:

Canonical link: https://commits.webkit.org/274642@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] c3b754: Crash under WebPage::close()

[Chris Dumez]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c3b754f8cd593c4021129ad72daa0d2e15e53142
  
https://github.com/WebKit/WebKit/commit/c3b754f8cd593c4021129ad72daa0d2e15e53142
  Author: Chris Dumez 
  Date:   2024-02-14 (Wed, 14 Feb 2024)

  Changed paths:
M Source/WebKit/WebProcess/WebPage/WebPage.cpp

  Log Message:
  ---
  Crash under WebPage::close()
https://bugs.webkit.org/show_bug.cgi?id=269373
rdar://118486861

Reviewed by Brent Fulgham.

Add a null check for the LocalFrame given that nothing prevents it
from being null and we're seeing null dereferences in the wild.

* Source/WebKit/WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::close):

Canonical link: https://commits.webkit.org/274641@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 3582e2: [Gardening]:NEW TEST (273727@main ): [ Sonoma wk2 ...

[martadarbinyan]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 3582e2c4cdc5ec4477f155cffb2bac55208ea2f0
  
https://github.com/WebKit/WebKit/commit/3582e2c4cdc5ec4477f155cffb2bac55208ea2f0
  Author: Marta Darbinyan 
  Date:   2024-02-14 (Wed, 14 Feb 2024)

  Changed paths:
M LayoutTests/platform/mac-wk2/TestExpectations

  Log Message:
  ---
  [Gardening]:NEW TEST (273727@main ): [ Sonoma wk2 ] 
compositing/plugins/pdf/pdf-in-iframe-scrolling-tree-after-back.html is a flaky 
failure
https://bugs.webkit.org/show_bug.cgi?id=268398
rdar://121943774

Unreviewed test gardening.

Adding test expectation

* LayoutTests/platform/mac-wk2/TestExpectations:

Canonical link: https://commits.webkit.org/274640@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] c1b66e: Conditionally block the CA render server

[Per Arne Vollan]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c1b66e4ec0ee6896573057afae51e383e46e48bf
  
https://github.com/WebKit/WebKit/commit/c1b66e4ec0ee6896573057afae51e383e46e48bf
  Author: Per Arne Vollan 
  Date:   2024-02-14 (Wed, 14 Feb 2024)

  Changed paths:
M Source/WebKit/Shared/WebPageCreationParameters.h
M Source/WebKit/Shared/WebPageCreationParameters.serialization.in
M Source/WebKit/UIProcess/WebPageProxy.cpp
M Source/WebKit/WebProcess/WebPage/WebPage.cpp
M Source/WebKit/WebProcess/com.apple.WebProcess.sb.in

  Log Message:
  ---
  Conditionally block the CA render server
https://bugs.webkit.org/show_bug.cgi?id=269343
rdar://114834122

Reviewed by Brent Fulgham.

Block the CA render server in the WebContent process' sandbox on macOS when 
unified PDF is enabled.

* Source/WebKit/Shared/WebPageCreationParameters.h:
* Source/WebKit/Shared/WebPageCreationParameters.serialization.in:
* Source/WebKit/UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::creationParameters):
* Source/WebKit/WebProcess/WebPage/WebPage.cpp:
(WebKit::m_unifiedTextReplacementController):
* Source/WebKit/WebProcess/com.apple.WebProcess.sb.in:

Canonical link: https://commits.webkit.org/274639@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] d954db: [Gardening]: REGRESSION (270621@main?): [ Sonoma+ ...

[martadarbinyan]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: d954dba51225065bf9e4fe87529050b0758761c9
  
https://github.com/WebKit/WebKit/commit/d954dba51225065bf9e4fe87529050b0758761c9
  Author: Marta Darbinyan 
  Date:   2024-02-14 (Wed, 14 Feb 2024)

  Changed paths:
M LayoutTests/platform/ios-wk2/TestExpectations
M LayoutTests/platform/mac-wk2/TestExpectations

  Log Message:
  ---
  [Gardening]: REGRESSION (270621@main?): [ Sonoma+ iOS17 wk2 Release  ] 
webrtc/audio-samplerate-change.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=269327
rdar://122917306

Unreviewed test gardening.

Adding test expectation

* LayoutTests/platform/ios-wk2/TestExpectations:
* LayoutTests/platform/mac-wk2/TestExpectations:

Canonical link: https://commits.webkit.org/274638@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 803d30: [Wasm-GC] Fix assertions for global init import case

[Asumu Takikawa]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 803d3064cdeb810bbf07b64288b06b5493b7d68d
  
https://github.com/WebKit/WebKit/commit/803d3064cdeb810bbf07b64288b06b5493b7d68d
  Author: Asumu Takikawa 
  Date:   2024-02-14 (Wed, 14 Feb 2024)

  Changed paths:
M JSTests/wasm/gc/const-exprs.js
M JSTests/wasm/gc/simd.js
M JSTests/wasm/gc/table_init.js
M Source/JavaScriptCore/wasm/js/WebAssemblyModuleRecord.cpp

  Log Message:
  ---
  [Wasm-GC] Fix assertions for global init import case
https://bugs.webkit.org/show_bug.cgi?id=269123

Reviewed by Justin Michaud.

Fixes assertions for the "import" (referring to previous globals) case of
global init expressions. Also adds tests for various cases (including for
tables) to cover these cases better.

* JSTests/wasm/gc/const-exprs.js:
(async testConstExprGlobalOrdering):
* JSTests/wasm/gc/simd.js:
(testSIMDGlobal):
* JSTests/wasm/gc/table_init.js:
* Source/JavaScriptCore/wasm/js/WebAssemblyModuleRecord.cpp:
(JSC::WebAssemblyModuleRecord::initializeExports):

Canonical link: https://commits.webkit.org/274637@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 65461a: Make requestStorageAccess return NoModificationAll...

[Sihui]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 65461aad5f3fbb4bd347ab2bff74ce2bdf66b2d7
  
https://github.com/WebKit/WebKit/commit/65461aad5f3fbb4bd347ab2bff74ce2bdf66b2d7
  Author: Sihui Liu 
  Date:   2024-02-14 (Wed, 14 Feb 2024)

  Changed paths:
A 
LayoutTests/http/tests/storageAccess/request-throw-exception-on-grant-until-reload-expected.txt
A 
LayoutTests/http/tests/storageAccess/request-throw-exception-on-grant-until-reload.html
A 
LayoutTests/http/tests/storageAccess/resources/request-throw-exception-on-grant-until-reload-iframe.html
M Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml
M Source/WebCore/dom/DocumentStorageAccess.cpp
M Source/WebCore/dom/DocumentStorageAccess.h
M Source/WebCore/page/Quirks.h
M Source/WebKit/NetworkProcess/Classifier/ResourceLoadStatisticsStore.h
M Source/WebKit/NetworkProcess/Classifier/WebResourceLoadStatisticsStore.cpp
M Source/WebKit/NetworkProcess/Classifier/WebResourceLoadStatisticsStore.h
M Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.cpp
M Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.h
M Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.messages.in
M Source/WebKit/NetworkProcess/NetworkProcess.cpp
M Source/WebKit/NetworkProcess/NetworkProcess.h
M Source/WebKit/NetworkProcess/NetworkResourceLoadParameters.cpp
M Source/WebKit/NetworkProcess/NetworkResourceLoadParameters.h
M 
Source/WebKit/NetworkProcess/NetworkResourceLoadParameters.serialization.in
M Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in
M Source/WebKit/UIProcess/Network/NetworkProcessProxy.h
M Source/WebKit/WebProcess/Network/WebLoaderStrategy.cpp
M Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.h
M Source/WebKit/WebProcess/WebProcess.cpp
M Tools/WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl
M Tools/WebKitTestRunner/InjectedBundle/TestRunner.cpp
M Tools/WebKitTestRunner/InjectedBundle/TestRunner.h
M Tools/WebKitTestRunner/TestController.cpp
M Tools/WebKitTestRunner/TestController.h
M Tools/WebKitTestRunner/TestInvocation.cpp

  Log Message:
  ---
  Make requestStorageAccess return NoModificationAllowedError until frame is 
reloaded
https://bugs.webkit.org/show_bug.cgi?id=269108
rdar://122676929

Reviewed by Alex Christensen.

Add a feature flag to make requestStorageAccess return 
NoModificationAllowedError on granted request until frame is
reloaded, to faciliate testing behavior change on requestStorageAccess when 
site isolation is enabled.

Test: 
http/tests/storageAccess/request-throw-exception-on-grant-until-reload.html

* 
LayoutTests/http/tests/storageAccess/request-throw-exception-on-grant-until-reload-expected.txt:
 Added.
* 
LayoutTests/http/tests/storageAccess/request-throw-exception-on-grant-until-reload.html:
 Added.
* 
LayoutTests/http/tests/storageAccess/resources/request-throw-exception-on-grant-until-reload-iframe.html:
 Added.
* Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml:
* Source/WebCore/dom/DocumentStorageAccess.cpp:
(WebCore::DocumentStorageAccess::requestStorageAccess):
(WebCore::DocumentStorageAccess::requestStorageAccessQuirk):
* Source/WebCore/dom/DocumentStorageAccess.h:
* Source/WebCore/page/Quirks.h:
* Source/WebKit/NetworkProcess/Classifier/ResourceLoadStatisticsStore.h:
* Source/WebKit/NetworkProcess/Classifier/WebResourceLoadStatisticsStore.cpp:
(WebKit::WebResourceLoadStatisticsStore::requestStorageAccess):
(WebKit::WebResourceLoadStatisticsStore::grantStorageAccess):
(WebKit::WebResourceLoadStatisticsStore::grantStorageAccessEphemeral):
(WebKit::WebResourceLoadStatisticsStore::grantStorageAccessInStorageSession):
(WebKit::WebResourceLoadStatisticsStore::recordFrameLoadForStorageAccess):
(WebKit::WebResourceLoadStatisticsStore::clearFrameLoadRecordsForStorageAccess):
(WebKit::WebResourceLoadStatisticsStore::storageAccessWasGrantedValueForFrame):
* Source/WebKit/NetworkProcess/Classifier/WebResourceLoadStatisticsStore.h:
* Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.cpp:
(WebKit::NetworkConnectionToWebProcess::scheduleResourceLoad):
(WebKit::NetworkConnectionToWebProcess::clearFrameLoadRecordsForStorageAccess):
* Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.h:
* Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.messages.in:
* Source/WebKit/NetworkProcess/NetworkProcess.cpp:
(WebKit::NetworkProcess::removeWebPageNetworkParameters):
* Source/WebKit/NetworkProcess/NetworkProcess.h:
* Source/WebKit/NetworkProcess/NetworkResourceLoadParameters.cpp:
(WebKit::NetworkResourceLoadParameters::NetworkResourceLoadParameters):
* Source/WebKit/NetworkProcess/NetworkResourceLoadParameters.h:
* Source/WebKit/NetworkProcess/NetworkResourceLoadParameters.serialization.in:
* Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in:
* Source/WebKit/UIProcess/Network/NetworkProcessProxy.h:
* 

[webkit-changes] [WebKit/WebKit] c76ab2: [Wasm-GC] Add test for bug 258796

[Asumu Takikawa]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c76ab28ce98e8d89e58919ce4e0c7a2963ed4f5a
  
https://github.com/WebKit/WebKit/commit/c76ab28ce98e8d89e58919ce4e0c7a2963ed4f5a
  Author: Asumu Takikawa 
  Date:   2024-02-14 (Wed, 14 Feb 2024)

  Changed paths:
A JSTests/wasm/gc/bug258796.js

  Log Message:
  ---
  [Wasm-GC] Add test for bug 258796
https://bugs.webkit.org/show_bug.cgi?id=258796

Reviewed by Justin Michaud.

Add test for already fixed bug.

* JSTests/wasm/gc/bug258796.js: Added.
(module):

Canonical link: https://commits.webkit.org/274635@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] fef628: Search buttons and search field are sometimes not ...

[Commit Queue]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: fef6284d40103b776032d66812367f8f62ec29e7
  
https://github.com/WebKit/WebKit/commit/fef6284d40103b776032d66812367f8f62ec29e7
  Author: Luming Yin 
  Date:   2024-02-14 (Wed, 14 Feb 2024)

  Changed paths:
M Source/WebKit/WebProcess/com.apple.WebProcess.sb.in

  Log Message:
  ---
  Search buttons and search field are sometimes not visible on Google.com
https://bugs.webkit.org/show_bug.cgi?id=269055
rdar://122487319

Reviewed by Per Arne Vollan.

* Source/WebKit/WebProcess/com.apple.WebProcess.sb.in:
Allow looking up `com.apple.MTLCompilerService` without requiring 
com.apple.webkit.extension.mach
extension only before macOS Sonoma where GPU DOM rendering is not enabled by 
default.

Canonical link: https://commits.webkit.org/274634@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 993ecb: Generate serialization for NSURLProtectionSpace

[Simon Lewis]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 993ecb7ef85e18f280dd7876d150ef5054ac32f2
  
https://github.com/WebKit/WebKit/commit/993ecb7ef85e18f280dd7876d150ef5054ac32f2
  Author: Simon Lewis 
  Date:   2024-02-14 (Wed, 14 Feb 2024)

  Changed paths:
M Source/WebKit/DerivedSources-input.xcfilelist
M Source/WebKit/DerivedSources.make
M Source/WebKit/Shared/Cocoa/ArgumentCodersCocoa.h
M Source/WebKit/Shared/Cocoa/ArgumentCodersCocoa.mm
M Source/WebKit/Shared/Cocoa/CoreIPCNSCFObject.h
M Source/WebKit/Shared/Cocoa/CoreIPCNSCFObject.mm
A Source/WebKit/Shared/Cocoa/CoreIPCNSURLProtectionSpace.serialization.in
M Source/WebKit/WebKit.xcodeproj/project.pbxproj
M Tools/TestWebKitAPI/Tests/IPC/IPCSerialization.mm

  Log Message:
  ---
  Generate serialization for NSURLProtectionSpace
https://bugs.webkit.org/show_bug.cgi?id=269021
rdar://problem/122584628

Reviewed by Alex Christensen.

* Source/WebKit/DerivedSources-input.xcfilelist:
* Source/WebKit/DerivedSources.make:
* Source/WebKit/Shared/Cocoa/ArgumentCodersCocoa.h:
* Source/WebKit/Shared/Cocoa/ArgumentCodersCocoa.mm:
(IPC::typeFromObject):
(IPC::shouldEnableStrictMode):
* Source/WebKit/Shared/Cocoa/CoreIPCNSCFObject.h:
* Source/WebKit/Shared/Cocoa/CoreIPCNSCFObject.mm:
(WebKit::valueFromID):
* Source/WebKit/Shared/Cocoa/CoreIPCNSURLProtectionSpace.serialization.in: 
Added.
* Source/WebKit/WebKit.xcodeproj/project.pbxproj:
* Tools/TestWebKitAPI/Tests/IPC/IPCSerialization.mm:
(isEqual):
(operator==):
(TEST):

Canonical link: https://commits.webkit.org/274633@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 499d9e: [JSC] Simplify PerfLog

[Yusuke Suzuki]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 499d9e1e42cb4c8d2d5a70c9bf4c23863a777c60
  
https://github.com/WebKit/WebKit/commit/499d9e1e42cb4c8d2d5a70c9bf4c23863a777c60
  Author: Yusuke Suzuki 
  Date:   2024-02-14 (Wed, 14 Feb 2024)

  Changed paths:
M Source/JavaScriptCore/assembler/LinkBuffer.cpp
M Source/JavaScriptCore/assembler/LinkBuffer.h
M Source/JavaScriptCore/assembler/PerfLog.cpp
M Source/JavaScriptCore/assembler/testmasm.cpp
M Source/JavaScriptCore/b3/B3Compile.cpp
M Source/JavaScriptCore/b3/air/testair.cpp
M Source/JavaScriptCore/b3/testb3_6.cpp
M Source/JavaScriptCore/bytecode/CodeBlock.cpp
M Source/JavaScriptCore/bytecode/CodeBlock.h
M Source/JavaScriptCore/bytecode/InlineAccess.cpp
M Source/JavaScriptCore/bytecode/InlineCacheCompiler.cpp
M Source/JavaScriptCore/bytecode/Repatch.cpp
M Source/JavaScriptCore/dfg/DFGOSRExit.cpp
M Source/JavaScriptCore/dfg/DFGThunks.cpp
M Source/JavaScriptCore/ftl/FTLLazySlowPath.cpp
M Source/JavaScriptCore/ftl/FTLLink.cpp
M Source/JavaScriptCore/ftl/FTLOSRExitCompiler.cpp
M Source/JavaScriptCore/ftl/FTLThunks.cpp
M Source/JavaScriptCore/jit/ExecutableAllocator.cpp
M Source/JavaScriptCore/jit/JIT.cpp
M Source/JavaScriptCore/jit/JITMathIC.h
M Source/JavaScriptCore/jit/JITOpcodes.cpp
M Source/JavaScriptCore/jit/JITPropertyAccess.cpp
M Source/JavaScriptCore/jit/JITStubRoutine.h
M Source/JavaScriptCore/jit/SlowPathCall.cpp
M Source/JavaScriptCore/jit/SpecializedThunkJIT.h
M Source/JavaScriptCore/jit/ThunkGenerator.h
M Source/JavaScriptCore/jit/ThunkGenerators.cpp
M Source/JavaScriptCore/llint/LLIntThunks.cpp
M Source/JavaScriptCore/runtime/OptionsList.h
M Source/JavaScriptCore/wasm/WasmBBQPlan.cpp
M Source/JavaScriptCore/wasm/WasmBinding.cpp
M Source/JavaScriptCore/wasm/WasmIPIntPlan.cpp
M Source/JavaScriptCore/wasm/WasmLLIntPlan.cpp
M Source/JavaScriptCore/wasm/WasmOMGPlan.cpp
M Source/JavaScriptCore/wasm/WasmOSREntryPlan.cpp
M Source/JavaScriptCore/wasm/WasmThunks.cpp
M Source/JavaScriptCore/wasm/js/WasmToJS.cpp
M Source/JavaScriptCore/wasm/js/WebAssemblyFunction.cpp
M Source/JavaScriptCore/yarr/YarrJIT.cpp
M Source/WTF/wtf/text/ASCIILiteral.h
M Source/WebCore/cssjit/SelectorCompiler.cpp

  Log Message:
  ---
  [JSC] Simplify PerfLog
https://bugs.webkit.org/show_bug.cgi?id=269352
rdar://122939072

Reviewed by Justin Michaud.

This patch simplifies PerfLog's content.

1. We should emit very simple name for each logging
2. We use LinkBuffer::Profile as a prefix (like, "FTL: function#")
3. Add option to specify the directory for JITDump. "/tmp" is the default.

* Source/JavaScriptCore/assembler/LinkBuffer.cpp:
(JSC::profileName):
(JSC::LinkBuffer::finalizeCodeWithoutDisassemblyImpl):
(JSC::LinkBuffer::logJITCodeForPerf):
(JSC::LinkBuffer::finalizeCodeWithDisassemblyImpl):
(JSC::LinkBuffer::dumpProfileStatistics):
* Source/JavaScriptCore/assembler/LinkBuffer.h:
(JSC::LinkBuffer::LinkBuffer):
(JSC::LinkBuffer::finalizeCodeWithoutDisassembly):
(JSC::LinkBuffer::finalizeCodeWithDisassembly):
* Source/JavaScriptCore/assembler/PerfLog.cpp:
(JSC::PerfLog::PerfLog):
* Source/JavaScriptCore/assembler/testmasm.cpp:
(JSC::compile):
* Source/JavaScriptCore/b3/B3Compile.cpp:
(JSC::B3::compile):
* Source/JavaScriptCore/b3/air/testair.cpp:
* Source/JavaScriptCore/b3/testb3_6.cpp:
(testEntrySwitchSimple):
(testEntrySwitchNoEntrySwitch):
(testEntrySwitchWithCommonPaths):
(testEntrySwitchWithCommonPathsAndNonTrivialEntrypoint):
(testEntrySwitchLoop):
* Source/JavaScriptCore/bytecode/CodeBlock.cpp:
(JSC::CodeBlock::dumpSimpleName const):
* Source/JavaScriptCore/bytecode/CodeBlock.h:
* Source/JavaScriptCore/bytecode/InlineAccess.cpp:
(JSC::linkCodeInline):
* Source/JavaScriptCore/bytecode/InlineCacheCompiler.cpp:
(JSC::getByIdSlowPathCodeGenerator):
(JSC::getByIdWithThisSlowPathCodeGenerator):
(JSC::getByValSlowPathCodeGenerator):
(JSC::getPrivateNameSlowPathCodeGenerator):
(JSC::getByValWithThisSlowPathCodeGenerator):
(JSC::putByIdSlowPathCodeGenerator):
(JSC::putByValSlowPathCodeGenerator):
(JSC::instanceOfSlowPathCodeGenerator):
(JSC::delByIdSlowPathCodeGenerator):
(JSC::delByValSlowPathCodeGenerator):
(JSC::categoryName):
(JSC::InlineCacheCompiler::regenerate):
* Source/JavaScriptCore/bytecode/Repatch.cpp:
(JSC::linkPolymorphicCall):
* Source/JavaScriptCore/dfg/DFGOSRExit.cpp:
(JSC::DFG::JSC_DEFINE_JIT_OPERATION):
* Source/JavaScriptCore/dfg/DFGThunks.cpp:
(JSC::DFG::osrExitGenerationThunkGenerator):
(JSC::DFG::osrEntryThunkGenerator):
* Source/JavaScriptCore/ftl/FTLLazySlowPath.cpp:
(JSC::FTL::LazySlowPath::generate):
* Source/JavaScriptCore/ftl/FTLLink.cpp:
(JSC::FTL::link):
* Source/JavaScriptCore/ftl/FTLOSRExitCompiler.cpp:
(JSC::FTL::compileStub):
* Source/JavaScriptCore/ftl/FTLThunks.cpp:
(JSC::FTL::genericGenerationThunkGenerator):

[webkit-changes] [WebKit/WebKit] c0bc71: Move iPadMini UA overrides to Quirks.cpp

[Karl Dubost]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c0bc71135b421a7ed16cd9b2e76c47a4954f806a
  
https://github.com/WebKit/WebKit/commit/c0bc71135b421a7ed16cd9b2e76c47a4954f806a
  Author: Karl Dubost 
  Date:   2024-02-14 (Wed, 14 Feb 2024)

  Changed paths:
M Source/WebCore/page/Quirks.cpp
M Source/WebCore/page/Quirks.h
M Source/WebKit/UIProcess/ios/WebPageProxyIOS.mm

  Log Message:
  ---
  Move iPadMini UA overrides to Quirks.cpp
https://bugs.webkit.org/show_bug.cgi?id=269335
rdar://122920694

Reviewed by Wenson Hsieh.

Currently the iPad UA override are handled in
Source/WebKit/UIProcess/iOS/WebPageProxyIOS.mm
The Quirks are usually handled in Source/WebCore/page/Quirks.cpp

It creates two separate places for checking the domain names when
there's a website with a need for a specific treatment.
Moving the domain name check in the same place than the rest of the
Quirks will make it easier for people new to code to understand all
the deviation from the normal behavior.

It doesn't change the current behavior. So when a domain name is matching
the userAgent will be set to RecommendDesktopClassBrowsingForRequest::No
which is basically the iPadOS (aka iPad mini) user agent.

Note that this will not solve the needsQuirk check.
It requires a bigger refactor for checking if Quirks are active or not.
It should be a good next step.

* Source/WebCore/page/Quirks.cpp:
(WebCore::Quirks::needsIpadMiniUserAgent const):
* Source/WebCore/page/Quirks.h:
* Source/WebKit/UIProcess/ios/WebPageProxyIOS.mm:
(WebKit::desktopClassBrowsingRecommendedForRequest):

Canonical link: https://commits.webkit.org/274631@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] d50688: [iOS] Unskip http/tests/site-isolation/iframe-proc...

[Sihui]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: d50688eb02fc8ed0159a25b6fe6a559f2b0ece82
  
https://github.com/WebKit/WebKit/commit/d50688eb02fc8ed0159a25b6fe6a559f2b0ece82
  Author: Sihui Liu 
  Date:   2024-02-14 (Wed, 14 Feb 2024)

  Changed paths:
M LayoutTests/platform/ios/TestExpectations

  Log Message:
  ---
  [iOS] Unskip http/tests/site-isolation/iframe-process-termination.html

Unreviewed test gardening.

* LayoutTests/platform/ios/TestExpectations:

Canonical link: https://commits.webkit.org/274630@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] ccb0d9: Teach RenderStyle::getCachedPseudoStyle() about Ps...

[Anne van Kesteren]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: ccb0d9418f55033e79a737ce52602e76da10af9d
  
https://github.com/WebKit/WebKit/commit/ccb0d9418f55033e79a737ce52602e76da10af9d
  Author: Anne van Kesteren 
  Date:   2024-02-14 (Wed, 14 Feb 2024)

  Changed paths:
M Source/WebCore/css/ComputedStyleExtractor.cpp
M Source/WebCore/dom/Element.cpp
M Source/WebCore/rendering/RenderBox.cpp
M Source/WebCore/rendering/RenderElement.cpp
M Source/WebCore/rendering/TextAutoSizing.cpp
M Source/WebCore/rendering/style/RenderStyle.cpp
M Source/WebCore/rendering/style/RenderStyle.h
M Source/WebCore/rendering/updating/RenderTreeBuilderFirstLetter.cpp
M Source/WebCore/rendering/updating/RenderTreeUpdaterGeneratedContent.cpp
M Source/WebCore/style/StylePendingResources.cpp
M Source/WebCore/style/StyleTreeResolver.cpp

  Log Message:
  ---
  Teach RenderStyle::getCachedPseudoStyle() about PseudoElementIdentifier
https://bugs.webkit.org/show_bug.cgi?id=269359

Reviewed by Antti Koivisto.

While developing a patch for getComputedStyle() I discovered with
considerable help from rniwa that Element::resolvePseudoElementStyle()
has to consistently cache the RenderStyle object as it's freed
otherwise.

I've added an assert to clarify this expectation. Using smart pointers
there might be good as well per rniwa. That can be done in a follow-up
patch.

* Source/WebCore/css/ComputedStyleExtractor.cpp:
(WebCore::computeRenderStyleForProperty):
* Source/WebCore/dom/Element.cpp:
(WebCore::Element::renderOrDisplayContentsStyle const):
(WebCore::Element::resolvePseudoElementStyle):
(WebCore::Element::computedStyle):
* Source/WebCore/rendering/RenderBox.cpp:
(WebCore::RenderBox::imageChanged):
* Source/WebCore/rendering/RenderElement.cpp:
(WebCore::RenderElement::firstLineStyle const):
(WebCore::RenderElement::styleDidChange):
(WebCore::RenderElement::willBeDestroyed):
(WebCore::RenderElement::getCachedPseudoStyle const):
* Source/WebCore/rendering/TextAutoSizing.cpp:
(WebCore::cloneRenderStyleWithState):
(WebCore::TextAutoSizingValue::adjustTextNodeSizes):
* Source/WebCore/rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::getCachedPseudoStyle const):
(WebCore::RenderStyle::changeRequiresLayout const):
* Source/WebCore/rendering/style/RenderStyle.h:
* Source/WebCore/rendering/updating/RenderTreeBuilderFirstLetter.cpp:
(WebCore::styleForFirstLetter):
* Source/WebCore/rendering/updating/RenderTreeUpdaterGeneratedContent.cpp:
(WebCore::RenderTreeUpdater::GeneratedContent::updatePseudoElement):
* Source/WebCore/style/StylePendingResources.cpp:
(WebCore::Style::loadPendingResources):
* Source/WebCore/style/StyleTreeResolver.cpp:
(WebCore::Style::TreeResolver::resolveElement):
(WebCore::Style::TreeResolver::makeResolutionContextForPseudoElement):
(WebCore::Style::TreeResolver::makeResolutionContextForInheritedFirstLine):

Canonical link: https://commits.webkit.org/274629@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] c6eb5d: Unreviewed, fix internal builds that use `WKWebVie...

[Wenson Hsieh]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c6eb5dfa73e1b7cabad5035f5aa8c146da033259
  
https://github.com/WebKit/WebKit/commit/c6eb5dfa73e1b7cabad5035f5aa8c146da033259
  Author: Wenson Hsieh 
  Date:   2024-02-14 (Wed, 14 Feb 2024)

  Changed paths:
M Source/WebKit/Configurations/WebKitSwift.xcconfig
M Source/WebKit/DerivedSources.make

  Log Message:
  ---
  Unreviewed, fix internal builds that use `WKWebView+TextExtraction.swift.in`
rdar://122947207

Partially revert support for text extraction, until we're able to reliably 
block the WebKitSwift
installhdrs phase on the WebKitAdditions build being finished.

* Source/WebKit/Configurations/WebKitSwift.xcconfig:
* Source/WebKit/DerivedSources.make:

Canonical link: https://commits.webkit.org/274628@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 201d69: [UnifiedPDF] Choose a good initial scale, and fix ...

[Simon Fraser]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 201d691c2124b002de6280430852e50e0f9f997e
  
https://github.com/WebKit/WebKit/commit/201d691c2124b002de6280430852e50e0f9f997e
  Author: Simon Fraser 
  Date:   2024-02-14 (Wed, 14 Feb 2024)

  Changed paths:
M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/PDFDocumentLayout.mm
M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.h
M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm

  Log Message:
  ---
  [UnifiedPDF] Choose a good initial scale, and fix various scaling issues
https://bugs.webkit.org/show_bug.cgi?id=269333
rdar://122907238

Reviewed by Tim Horton.

Fix various scaling issues with PDFs:
1. On first load, try to display at actual size, as long as that doesn't cause 
it to
   zoom in. Otherwise try to fix the entire height in the view. Implemented via 
the
   `AdjustScaleAfterLayout` argument to `updateLayout()`.

2. When changing layout modes, rescale using the same logic as first load.

3. When the PDF content is shorter than the view, vertically center it. 
Implemented
   by renaming and changing `sidePaddingWidth()` to return a FloatSize. It also 
now
   always computes padding, even when scaled above 1.

* Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.h:
* Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm:
(WebKit::UnifiedPDFPlugin::installPDFDocument):
(WebKit::UnifiedPDFPlugin::attemptToUnlockPDF):
(WebKit::UnifiedPDFPlugin::updatePageBackgroundLayers):
(WebKit::UnifiedPDFPlugin::scaleForFitToView const):
(WebKit::UnifiedPDFPlugin::initialScale const):
(WebKit::UnifiedPDFPlugin::setPageScaleFactor):
(WebKit::UnifiedPDFPlugin::updateLayout):
(WebKit::UnifiedPDFPlugin::centeringOffset const):
(WebKit::UnifiedPDFPlugin::convertFromPluginToDocument const):
(WebKit::UnifiedPDFPlugin::convertFromDocumentToPlugin const):
(WebKit::UnifiedPDFPlugin::convertFromPageToContents const):
(WebKit::UnifiedPDFPlugin::performContextMenuAction):
(WebKit::UnifiedPDFPlugin::sidePaddingWidth const): Deleted.

Canonical link: https://commits.webkit.org/274627@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 67862e: Refactor VideoPresentationInterfaceIOS

[Dana Estra]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 67862e4bd5cec103b4d1b0d60c359c358999e3a1
  
https://github.com/WebKit/WebKit/commit/67862e4bd5cec103b4d1b0d60c359c358999e3a1
  Author: Dana Estra 
  Date:   2024-02-14 (Wed, 14 Feb 2024)

  Changed paths:
M Source/WebCore/SourcesCocoa.txt
M Source/WebCore/WebCore.xcodeproj/project.pbxproj
M Source/WebCore/platform/graphics/PlatformVideoPresentationInterface.h
M Source/WebCore/platform/ios/PlaybackSessionInterfaceAVKit.h
M Source/WebCore/platform/ios/PlaybackSessionInterfaceAVKit.mm
M Source/WebCore/platform/ios/PlaybackSessionInterfaceIOS.h
M Source/WebCore/platform/ios/PlaybackSessionInterfaceIOS.mm
R Source/WebCore/platform/ios/PlaybackSessionInterfaceLMK.h
R Source/WebCore/platform/ios/PlaybackSessionInterfaceLMK.mm
A Source/WebCore/platform/ios/VideoPresentationInterfaceAVKit.h
A Source/WebCore/platform/ios/VideoPresentationInterfaceAVKit.mm
M Source/WebCore/platform/ios/VideoPresentationInterfaceIOS.h
M Source/WebCore/platform/ios/VideoPresentationInterfaceIOS.mm
M Source/WebCore/platform/ios/WebVideoFullscreenControllerAVKit.mm
A Source/WebKit/Platform/ios/PlaybackSessionInterfaceLMK.h
A Source/WebKit/Platform/ios/PlaybackSessionInterfaceLMK.mm
A Source/WebKit/Platform/ios/VideoPresentationInterfaceLMK.h
A Source/WebKit/Platform/ios/VideoPresentationInterfaceLMK.mm
M Source/WebKit/SourcesCocoa.txt
M Source/WebKit/UIProcess/Cocoa/VideoPresentationManagerProxy.mm
M Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenViewController.mm
M Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenWindowControllerIOS.mm
M Source/WebKit/WebKit.xcodeproj/project.pbxproj

  Log Message:
  ---
  Refactor VideoPresentationInterfaceIOS
https://bugs.webkit.org/show_bug.cgi?id=269231
rdar://122826677

Reviewed by Andy Estes.

This patch extracts the AVKit-specific code from VideoPresentationInterfaceIOS
and places it into a subclass called VideoPresentationInterfaceAVKit. There
is also now a second subclass called VideoPresentationInterfaceLMK, which
will be used on the vision platform in the future. For now, all IOS platforms
instantiate VideoPresentationInterfaceAVKit.

* Source/WebCore/SourcesCocoa.txt:
* Source/WebCore/WebCore.xcodeproj/project.pbxproj:
* Source/WebCore/platform/ios/PlaybackSessionInterfaceLMK.mm: Removed.
* Source/WebCore/platform/ios/VideoPresentationInterfaceAVKit.h:
(WebCore::VideoPresentationInterfaceAVKit::playerLayerView const): Deleted.
(WebCore::VideoPresentationInterfaceAVKit::changingStandbyOnly): Deleted.
(): Deleted.
* Source/WebCore/platform/ios/VideoPresentationInterfaceAVKit.mm:
(-[WebAVPlayerViewControllerDelegate fullscreenInterface]):
(-[WebAVPlayerViewControllerDelegate setFullscreenInterface:]):
(convertToExitFullScreenReason):
(-[WebAVPlayerViewController initWithFullscreenInterface:]):
(-[WebAVPlayerViewController 
configurePlayerViewControllerWithFullscreenInterface:]):
(-[WebAVPlayerViewController logChannel]):
(WebCore::VideoPresentationInterfaceAVKit::create):
(WebCore::VideoPresentationInterfaceAVKit::VideoPresentationInterfaceAVKit):
(WebCore::VideoPresentationInterfaceAVKit::~VideoPresentationInterfaceAVKit):
(WebCore::VideoPresentationInterfaceAVKit::playerViewController const):
(WebCore::VideoPresentationInterfaceAVKit::avPlayerViewController const):
(WebCore::VideoPresentationInterfaceAVKit::setupFullscreen):
(WebCore::VideoPresentationInterfaceAVKit::updateRouteSharingPolicy):
(WebCore::VideoPresentationInterfaceAVKit::setPlayerIdentifier):
(WebCore::VideoPresentationInterfaceAVKit::setupPlayerViewController):
(WebCore::VideoPresentationInterfaceAVKit::invalidatePlayerViewController):
(WebCore::VideoPresentationInterfaceAVKit::presentFullscreen):
(WebCore::VideoPresentationInterfaceAVKit::dismissFullscreen):
(WebCore::VideoPresentationInterfaceAVKit::tryToStartPictureInPicture):
(WebCore::VideoPresentationInterfaceAVKit::stopPictureInPicture):
(WebCore::VideoPresentationInterfaceAVKit::isPlayingVideoInEnhancedFullscreen 
const):
(WebCore::VideoPresentationInterfaceAVKit::setAllowsPictureInPicturePlayback):
(WebCore::VideoPresentationInterfaceAVKit::setShowsPlaybackControls):
(WebCore::VideoPresentationInterfaceAVKit::setContentDimensions):
(WebCore::setSupportsPictureInPicture):
(WebCore::supportsPictureInPicture):
(clearUIColor): Deleted.
(boolString): Deleted.
(VideoPresentationInterfaceAVKit::create): Deleted.
(VideoPresentationInterfaceAVKit::VideoPresentationInterfaceAVKit): Deleted.
(VideoPresentationInterfaceAVKit::~VideoPresentationInterfaceAVKit): Deleted.
(VideoPresentationInterfaceAVKit::avPlayerViewController const): Deleted.
(VideoPresentationInterfaceAVKit::videoDimensionsChanged): Deleted.
(VideoPresentationInterfaceAVKit::setupFullscreen): Deleted.
(VideoPresentationInterfaceAVKit::setVideoPresentationModel): Deleted.
(VideoPresentationInterfaceAVKit::hasVideoChanged): 

[webkit-changes] [WebKit/WebKit] 622b90: [UnifiedPDF] Annotation hover and interaction is b...

[Simon Fraser]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 622b90f2c44db97d10326a6970b96588b7394705
  
https://github.com/WebKit/WebKit/commit/622b90f2c44db97d10326a6970b96588b7394705
  Author: Simon Fraser 
  Date:   2024-02-14 (Wed, 14 Feb 2024)

  Changed paths:
M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/PDFDocumentLayout.h
M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/PDFDocumentLayout.mm
M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.h
M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm

  Log Message:
  ---
  [UnifiedPDF] Annotation hover and interaction is broken in rotated pages
https://bugs.webkit.org/show_bug.cgi?id=269344
rdar://122929753

Reviewed by Tim Horton.

The transform math in `documentSpaceToPageSpaceTransform()` was wrong, 
resulting in hit-testing
of annotations in rotated pages being wrong.

The page bounds vended by PDFDocumentLayout are normalized, so we can't use 
them for coordinate
conversion. We need to go back to the original page crop boxes. Clarify this by 
renaming
`boundsForPageAtIndex()` to `layoutBoundsForPageAtIndex()` since it is 
normalized, and contains
the layout offset of the page.

Then have PDFDocumentLayout store the original crop box per page. Internally, 
it computes
an AffineTransform from page rotation and crop box, and we use that and some 
coordinate flipping
to convert points.

Remove the FloatRect conversion functions on UnifiedPDFPlugin that I just 
added, because
they were wrong, and unused.

* Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/PDFDocumentLayout.h:
* Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/PDFDocumentLayout.mm:
(WebKit::PDFDocumentLayout::updateLayout):
(WebKit::PDFDocumentLayout::layoutSingleColumn):
(WebKit::PDFDocumentLayout::layoutTwoUpColumn):
(WebKit::PDFDocumentLayout::layoutBoundsForPageAtIndex const):
(WebKit::PDFDocumentLayout::toPageTransform const):
(WebKit::PDFDocumentLayout::documentPointToPDFPagePoint const):
(WebKit::PDFDocumentLayout::pdfPagePointToDocumentPoint const):
(WebKit::PDFDocumentLayout::boundsForPageAtIndex const): Deleted.
* Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.h:
* Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm:
(WebKit::UnifiedPDFPlugin::updatePageBackgroundLayers):
(WebKit::UnifiedPDFPlugin::pageCoverageForRect const):
(WebKit::UnifiedPDFPlugin::scaleForActualSize const):
(WebKit::UnifiedPDFPlugin::heightForPage const):
(WebKit::UnifiedPDFPlugin::pageIndexForDocumentPoint const):
(WebKit::UnifiedPDFPlugin::convertFromDocumentToPage const):
(WebKit::UnifiedPDFPlugin::convertFromPageToDocument const):
(WebKit::documentSpaceToPageSpaceTransform): Deleted.

Canonical link: https://commits.webkit.org/274625@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 36d87a: [WPE] REGRESSION(274544@main): Build fails due to ...

[Adrian Perez]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 36d87a9c88b9400cbb24387dfecda318e92a6ba6
  
https://github.com/WebKit/WebKit/commit/36d87a9c88b9400cbb24387dfecda318e92a6ba6
  Author: Adrian Perez de Castro 
  Date:   2024-02-14 (Wed, 14 Feb 2024)

  Changed paths:
M Tools/ImageDiff/skia/PlatformImageSkia.cpp
M Tools/wpe/backends/fdo/HeadlessViewBackendFdo.cpp

  Log Message:
  ---
  [WPE] REGRESSION(274544@main): Build fails due to Clang -Wcast-align errors
https://bugs.webkit.org/show_bug.cgi?id=269360

Unreviewed build fix.

Use "pragma clang diagnostic" to silence -Wcast-align warnings being
treated as errors. The IGNORE_CLANG_WARNINGS_{BEGIN,END} macros are not
used in this instance because none of the affected sources are supposed
to use WTF. No additional guards are needed to use the pragmas, because
compilers are expected to ignore an unknown #pragma.

* Tools/ImageDiff/skia/PlatformImageSkia.cpp:
* Tools/wpe/backends/fdo/HeadlessViewBackendFdo.cpp:

Canonical link: https://commits.webkit.org/274624@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] cb24c5: [GStreamer] Implement "id" property for in-band au...

[Philippe Normand]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: cb24c51631e89c0a0c1facdba4de43c59746205c
  
https://github.com/WebKit/WebKit/commit/cb24c51631e89c0a0c1facdba4de43c59746205c
  Author: Philippe Normand 
  Date:   2024-02-14 (Wed, 14 Feb 2024)

  Changed paths:
M LayoutTests/platform/glib/TestExpectations
M Source/WebCore/platform/graphics/gstreamer/AudioTrackPrivateGStreamer.cpp
M Source/WebCore/platform/graphics/gstreamer/AudioTrackPrivateGStreamer.h
M 
Source/WebCore/platform/graphics/gstreamer/InbandTextTrackPrivateGStreamer.cpp
M 
Source/WebCore/platform/graphics/gstreamer/InbandTextTrackPrivateGStreamer.h
M Source/WebCore/platform/graphics/gstreamer/VideoTrackPrivateGStreamer.cpp
M Source/WebCore/platform/graphics/gstreamer/VideoTrackPrivateGStreamer.h

  Log Message:
  ---
  [GStreamer] Implement "id" property for in-band audio, text and video tracks
https://bugs.webkit.org/show_bug.cgi?id=123901

Reviewed by Xabier Rodriguez-Calvar.

Support for container-specific-track-id GStreamer tag was implemented in:
https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/6041

Which is scheduled to ship in GStreamer 1.24. The demuxers supported initially 
are DASH, qtdemux and
matroskademux, so we have coverage for the most common formats.

* LayoutTests/platform/glib/TestExpectations:
* Source/WebCore/platform/graphics/gstreamer/AudioTrackPrivateGStreamer.cpp:
(WebCore::AudioTrackPrivateGStreamer::updateConfigurationFromTags):
* Source/WebCore/platform/graphics/gstreamer/AudioTrackPrivateGStreamer.h:
* 
Source/WebCore/platform/graphics/gstreamer/InbandTextTrackPrivateGStreamer.cpp:
(WebCore::ensureTextTrackDebugCategoryInitialized):
(WebCore::InbandTextTrackPrivateGStreamer::InbandTextTrackPrivateGStreamer):
(WebCore::InbandTextTrackPrivateGStreamer::tagsChanged):
* Source/WebCore/platform/graphics/gstreamer/InbandTextTrackPrivateGStreamer.h:
* Source/WebCore/platform/graphics/gstreamer/VideoTrackPrivateGStreamer.cpp:
(WebCore::VideoTrackPrivateGStreamer::updateConfigurationFromTags):
* Source/WebCore/platform/graphics/gstreamer/VideoTrackPrivateGStreamer.h:

Canonical link: https://commits.webkit.org/274623@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] b85b96: Remove unused expectations of SVGCursorElement-svg...

[Ahmad Saleem]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: b85b96c50d057a446880f433c5fe9404e7152094
  
https://github.com/WebKit/WebKit/commit/b85b96c50d057a446880f433c5fe9404e7152094
  Author: Ahmad Saleem 
  Date:   2024-02-14 (Wed, 14 Feb 2024)

  Changed paths:
R 
LayoutTests/platform/gtk/svg/dynamic-updates/SVGCursorElement-svgdom-x-prop-expected.png
R 
LayoutTests/platform/gtk/svg/dynamic-updates/SVGCursorElement-svgdom-y-prop-expected.png
R 
LayoutTests/platform/mac/svg/dynamic-updates/SVGCursorElement-svgdom-x-prop-expected.png
R 
LayoutTests/platform/mac/svg/dynamic-updates/SVGCursorElement-svgdom-y-prop-expected.png

  Log Message:
  ---
  Remove unused expectations of SVGCursorElement-svgdom-* tests

https://bugs.webkit.org/show_bug.cgi?id=269339

Reviewed by Nikolas Zimmermann.

This patch removes unused file expectations for following tests (which don't 
exist anymore):

> svg/dynamic-updates/SVGCursorElement-svgdom-x-prop.html:
> svg/dynamic-updates/SVGCursorElement-svgdom-y-prop.html:

* 
LayoutTests/platform/gtk/svg/dynamic-updates/SVGCursorElement-svgdom-x-prop-expected.png:
 Deleted
* 
LayoutTests/platform/gtk/svg/dynamic-updates/SVGCursorElement-svgdom-y-prop-expected.png:
 Ditto
* 
LayoutTests/platform/mac/svg/dynamic-updates/SVGCursorElement-svgdom-x-prop-expected.png:
 Ditto
* 
LayoutTests/platform/mac/svg/dynamic-updates/SVGCursorElement-svgdom-y-prop-expected.png:
 Ditto

Canonical link: https://commits.webkit.org/274622@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] d01f00: [WGSL] Cannot initialize variable with non-concret...

[Tadeu Zagallo]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: d01f00ff4efa7da5a686a4d41f612be6850057dc
  
https://github.com/WebKit/WebKit/commit/d01f00ff4efa7da5a686a4d41f612be6850057dc
  Author: Tadeu Zagallo 
  Date:   2024-02-14 (Wed, 14 Feb 2024)

  Changed paths:
M Source/WebGPU/WGSL/TypeCheck.cpp

  Log Message:
  ---
  [WGSL] Cannot initialize variable with non-concrete type
https://bugs.webkit.org/show_bug.cgi?id=269304
rdar://122293570

Reviewed by Mike Wyrzykowski.

Currently we release_assert, but it should be a type error instead.

* Source/WebGPU/WGSL/TypeCheck.cpp:
(WGSL::variableFlavorToString):
(WGSL::TypeChecker::visitVariable):

Canonical link: https://commits.webkit.org/274621@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 36543a: run-javascriptcore-tests: Allow a cap on the effec...

[aoikonomopoulos]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 36543ae6e0e96340bd5071a9e3c6018fd1b6549e
  
https://github.com/WebKit/WebKit/commit/36543ae6e0e96340bd5071a9e3c6018fd1b6549e
  Author: Angelos Oikonomopoulos 
  Date:   2024-02-14 (Wed, 14 Feb 2024)

  Changed paths:
M Tools/Scripts/run-javascriptcore-tests
M Tools/Scripts/run-jsc-stress-tests

  Log Message:
  ---
  run-javascriptcore-tests: Allow a cap on the effective timeout
https://bugs.webkit.org/show_bug.cgi?id=269318

Reviewed by Justin Michaud.

run-jsc-stress-tests scales up JSC_timeout by the number of cores. On
high core count machines, this would push the value above the 1200
seconds after which buildbot will kill the running command if it hasn't
seen any output. This means that when a single JSC stress test would
hang, the whole test run would ends up wasted and the user'd only get a
cryptic

command timed out: 1200 seconds without output running

message that gives no information as to which test got stuck.

Add a --max-timeout parameter, which the CI environment can use to cap
the effective per-stress-test timeout to something less than the
buildbot timeout.

* Tools/Scripts/run-javascriptcore-tests:
(runJSCStressTests):
* Tools/Scripts/run-jsc-stress-tests:

Canonical link: https://commits.webkit.org/274620@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] b96094: [WPE] WPE Platform: Implement monitors API in DRM ...

[Carlos Garcia Campos]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: b96094f5ce941b472f4490d05cef37214fc6f2e4
  
https://github.com/WebKit/WebKit/commit/b96094f5ce941b472f4490d05cef37214fc6f2e4
  Author: Carlos Garcia Campos 
  Date:   2024-02-14 (Wed, 14 Feb 2024)

  Changed paths:
M Source/WebKit/UIProcess/glib/DisplayVBlankMonitorDRM.cpp
M Source/WebKit/WPEPlatform/wpe/drm/CMakeLists.txt
M Source/WebKit/WPEPlatform/wpe/drm/WPEDRM.cpp
M Source/WebKit/WPEPlatform/wpe/drm/WPEDRM.h
M Source/WebKit/WPEPlatform/wpe/drm/WPEDisplayDRM.cpp
M Source/WebKit/WPEPlatform/wpe/drm/WPEDisplayDRMPrivate.h
A Source/WebKit/WPEPlatform/wpe/drm/WPEMonitorDRM.cpp
A Source/WebKit/WPEPlatform/wpe/drm/WPEMonitorDRM.h
A Source/WebKit/WPEPlatform/wpe/drm/WPEMonitorDRMPrivate.h
M Source/WebKit/WPEPlatform/wpe/drm/WPEViewDRM.cpp
M Source/WebKit/WPEPlatform/wpe/drm/wpe-drm.h

  Log Message:
  ---
  [WPE] WPE Platform: Implement monitors API in DRM platform
https://bugs.webkit.org/show_bug.cgi?id=269062

Reviewed by Adrian Perez de Castro.

Add WPEMonitor implementation for DRM.

* Source/WebKit/UIProcess/glib/DisplayVBlankMonitorDRM.cpp:
(WebKit::DisplayVBlankMonitorDRM::create):
* Source/WebKit/WPEPlatform/wpe/drm/CMakeLists.txt:
* Source/WebKit/WPEPlatform/wpe/drm/WPEDRM.cpp:
(WPE::DRM::Crtc::Crtc):
(WPE::DRM::Connector::Connector):
* Source/WebKit/WPEPlatform/wpe/drm/WPEDRM.h:
(WPE::DRM::Crtc::x const):
(WPE::DRM::Crtc::y const):
(WPE::DRM::Crtc::width const):
(WPE::DRM::Crtc::height const):
(WPE::DRM::Connector::widthMM const):
(WPE::DRM::Connector::heightMM const):
* Source/WebKit/WPEPlatform/wpe/drm/WPEDisplayDRM.cpp:
(wpeDisplayDRMConnect):
(wpeDisplayDRMGetNMonitors):
(wpeDisplayDRMGetMonitor):
(wpe_display_drm_class_init):
(wpeDisplayDRMGetCrtc): Deleted.
* Source/WebKit/WPEPlatform/wpe/drm/WPEDisplayDRMPrivate.h:
* Source/WebKit/WPEPlatform/wpe/drm/WPEMonitorDRM.cpp: Added.
(wpeMonitorDRMInvalidate):
(wpeMonitorDRMDispose):
(wpe_monitor_drm_class_init):
(wpeMonitorDRMCreate):
(wpeMonitorDRMGetMode):
(wpeMonitorDRMGetCrtc):
(wpe_monitor_drm_get_crtc_index):
* Source/WebKit/WPEPlatform/wpe/drm/WPEMonitorDRM.h: Copied from 
Source/WebKit/WPEPlatform/wpe/drm/wpe-drm.h.
* Source/WebKit/WPEPlatform/wpe/drm/WPEMonitorDRMPrivate.h: Copied from 
Source/WebKit/WPEPlatform/wpe/drm/wpe-drm.h.
* Source/WebKit/WPEPlatform/wpe/drm/WPEViewDRM.cpp:
(wpeViewDRMConstructed):
(wpeViewDRMCommitAtomic):
(wpeViewDRMCommitLegacy):
(wpeViewDRMGetMonitor):
(wpeViewDRMScheduleCursorUpdate):
(wpe_view_drm_class_init):
* Source/WebKit/WPEPlatform/wpe/drm/wpe-drm.h:

Canonical link: https://commits.webkit.org/274619@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 2d31db: [WGSL] Global sort does not check max expression d...

[Tadeu Zagallo]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 2d31dba1a971959a98ff0a87c4d243cf905e3908
  
https://github.com/WebKit/WebKit/commit/2d31dba1a971959a98ff0a87c4d243cf905e3908
  Author: Tadeu Zagallo 
  Date:   2024-02-14 (Wed, 14 Feb 2024)

  Changed paths:
M Source/WebGPU/WGSL/GlobalSorting.cpp

  Log Message:
  ---
  [WGSL] Global sort does not check max expression depth in parameters
https://bugs.webkit.org/show_bug.cgi?id=269305
rdar://122293551

Reviewed by Mike Wyrzykowski.

We check for maximum expression depth in GlobalSorting, but while visiting 
parameters
we visit further the parameter type, which allows for expressions that exceed 
the max
depth to occur in the parameter's attributes.

* Source/WebGPU/WGSL/GlobalSorting.cpp:
(WGSL::GraphBuilder::visit):

Canonical link: https://commits.webkit.org/274618@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 26862e: [WGSL] Array elements must be constructible

[Tadeu Zagallo]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 26862e874a4664c4c9d53fe60c4b752393d2046f
  
https://github.com/WebKit/WebKit/commit/26862e874a4664c4c9d53fe60c4b752393d2046f
  Author: Tadeu Zagallo 
  Date:   2024-02-14 (Wed, 14 Feb 2024)

  Changed paths:
M Source/WebGPU/WGSL/TypeCheck.cpp

  Log Message:
  ---
  [WGSL] Array elements must be constructible
https://bugs.webkit.org/show_bug.cgi?id=269309
rdar://122293571

Reviewed by Mike Wyrzykowski.

Check that array element type is constructible.

* Source/WebGPU/WGSL/TypeCheck.cpp:
(WGSL::TypeChecker::visit):

Canonical link: https://commits.webkit.org/274617@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] a28287: [WGSL] Stack overflow when parsing coreLHSExpression

[Tadeu Zagallo]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: a28287972916cdb8091cb16e74b47d87fe5cf7a1
  
https://github.com/WebKit/WebKit/commit/a28287972916cdb8091cb16e74b47d87fe5cf7a1
  Author: Tadeu Zagallo 
  Date:   2024-02-14 (Wed, 14 Feb 2024)

  Changed paths:
M Source/WebGPU/WGSL/Parser.cpp

  Log Message:
  ---
  [WGSL] Stack overflow when parsing coreLHSExpression
https://bugs.webkit.org/show_bug.cgi?id=269306
rdar://122293634

Reviewed by Mike Wyrzykowski.

We have a check for maximum recursion depth in parseLHSExpression, but for some 
reason
we only checked when parsing a unary expression, so we could still overflow 
when the
lhs expression was a "coreLHSExpression".

* Source/WebGPU/WGSL/Parser.cpp:
(WGSL::Parser::parseLHSExpression):

Canonical link: https://commits.webkit.org/274616@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] cedb0d: [WGSL] shader, validation, decl, var:initializer_kind...

[Tadeu Zagallo]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: cedb0d4044f0c16c34166bb89cc8ff9dfa539296
  
https://github.com/WebKit/WebKit/commit/cedb0d4044f0c16c34166bb89cc8ff9dfa539296
  Author: Tadeu Zagallo 
  Date:   2024-02-14 (Wed, 14 Feb 2024)

  Changed paths:
M Source/WebGPU/WGSL/TypeCheck.cpp

  Log Message:
  ---
  [WGSL] shader,validation,decl,var:initializer_kind:* is failing
https://bugs.webkit.org/show_bug.cgi?id=269080
rdar://122652837

Reviewed by Mike Wyrzykowski.

Validate that global variables do not use other global variables or call
user-defined functions in their initializers.

* Source/WebGPU/WGSL/TypeCheck.cpp:
(WGSL::TypeChecker::visitVariable):
(WGSL::TypeChecker::visit):
(WGSL::TypeChecker::isModuleScope const):

Canonical link: https://commits.webkit.org/274615@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 518c5d: REGRESSION(273906@main): [GStreamer] webrtc/receiv...

[Philippe Normand]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 518c5dcd9b48dc4c31ad4677f957d0d9b8e20773
  
https://github.com/WebKit/WebKit/commit/518c5dcd9b48dc4c31ad4677f957d0d9b8e20773
  Author: Philippe Normand 
  Date:   2024-02-14 (Wed, 14 Feb 2024)

  Changed paths:
M LayoutTests/platform/glib/TestExpectations
M 
Source/WebCore/platform/mediastream/gstreamer/RealtimeOutgoingMediaSourceGStreamer.cpp
M 
Source/WebCore/platform/mediastream/gstreamer/RealtimeOutgoingMediaSourceGStreamer.h

  Log Message:
  ---
  REGRESSION(273906@main): [GStreamer] 
webrtc/receiver-track-should-stay-live-even-if-receiver-is-inactive.html is 
flaky crash
https://bugs.webkit.org/show_bug.cgi?id=268906

Reviewed by Xabier Rodriguez-Calvar.

Flaky crashes were triggered when the codecPreferencesChanged() was called 
while the blocking pad
probe was still active. We now prevent re-entry when this is the case.

* LayoutTests/platform/glib/TestExpectations:
* 
Source/WebCore/platform/mediastream/gstreamer/RealtimeOutgoingMediaSourceGStreamer.cpp:
(WebCore::RealtimeOutgoingMediaSourceGStreamer::start):
(WebCore::RealtimeOutgoingMediaSourceGStreamer::setSinkPad):
(WebCore::RealtimeOutgoingMediaSourceGStreamer::teardown):
(WebCore::RealtimeOutgoingMediaSourceGStreamer::codecPreferencesChanged):
* 
Source/WebCore/platform/mediastream/gstreamer/RealtimeOutgoingMediaSourceGStreamer.h:

Canonical link: https://commits.webkit.org/274614@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 046aeb: [WPE][Skia] Implement HeadlessViewBackend

[Carlos Garcia Campos]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 046aebec01c45777cebdc558cd92e1865cc70abb
  
https://github.com/WebKit/WebKit/commit/046aebec01c45777cebdc558cd92e1865cc70abb
  Author: Carlos Garcia Campos 
  Date:   2024-02-14 (Wed, 14 Feb 2024)

  Changed paths:
M Tools/wpe/backends/HeadlessViewBackend.h
M Tools/wpe/backends/fdo/HeadlessViewBackendFdo.cpp

  Log Message:
  ---
  [WPE][Skia] Implement HeadlessViewBackend
https://bugs.webkit.org/show_bug.cgi?id=269350

Reviewed by Nikolas Zimmermann.

This allows to run ref tests with skia when using the old libwpe API.

* Tools/wpe/backends/HeadlessViewBackend.h:
* Tools/wpe/backends/fdo/HeadlessViewBackendFdo.cpp:
(WPEToolingBackends::HeadlessViewBackend::HeadlessViewBackend):
(WPEToolingBackends::HeadlessViewBackend::~HeadlessViewBackend):
(WPEToolingBackends::HeadlessViewBackend::snapshot):
(WPEToolingBackends::HeadlessViewBackend::updateSnapshot):

Canonical link: https://commits.webkit.org/274613@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] b9a2ac: Fix the UnifiedPDF iOS build

[Tim Horton]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: b9a2ac222ce6c0d04e0e0b82dd4ef4201d06fe2d
  
https://github.com/WebKit/WebKit/commit/b9a2ac222ce6c0d04e0e0b82dd4ef4201d06fe2d
  Author: Tim Horton 
  Date:   2024-02-14 (Wed, 14 Feb 2024)

  Changed paths:
M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm

  Log Message:
  ---
  Fix the UnifiedPDF iOS build
https://bugs.webkit.org/show_bug.cgi?id=269351

Unreviewed build fix.

* Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm:
(WebKit::UnifiedPDFPlugin::attemptToUnlockPDF):

Canonical link: https://commits.webkit.org/274612@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 547b74: [UnifiedPDF] Context menu should have selection-ac...

[Abrar Rahman Protyasha]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 547b742836e50083101077f7002d57a24f0e92ea
  
https://github.com/WebKit/WebKit/commit/547b742836e50083101077f7002d57a24f0e92ea
  Author: Abrar Rahman Protyasha 
  Date:   2024-02-14 (Wed, 14 Feb 2024)

  Changed paths:
M Source/WebCore/platform/LocalizedStrings.cpp
M Source/WebCore/platform/LocalizedStrings.h
M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.h
M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm

  Log Message:
  ---
  [UnifiedPDF] Context menu should have selection-activated items (copy link, 
lookup, search-the-web)
https://bugs.webkit.org/show_bug.cgi?id=269330
rdar://122918090

Reviewed by Tim Horton.

We track text selections as of 274032@main, making it possible to perform
actions on said selections. This patch introduces the context menu items
that are modulated by the current selection context. Namely, we add
"Copy Link", "Dictionary Lookup", and "Search the Web". The last of
these items has a concrete action courtesy of 274583@main, and the other
two will be implemented in upcoming commits.

In doing so, we slightly refactor how we construct the context menu by
breaking it up into sections corresponding to selections, scale
adjustment, and display mode.

* Source/WebCore/platform/LocalizedStrings.cpp:
(WebCore::contextMenuItemPDFOpenWithPreview):
(WebCore::contextMenuItemPDFCopy): Deleted.
Remove the redundant definition since contextMenuItemTagCopy() returns
the same data.

* Source/WebCore/platform/LocalizedStrings.h:
WEBCORE_EXPORT some more methods since they're being called from WebKit.

* Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.h:
* Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm:
(WebKit::UnifiedPDFPlugin::handleContextMenuEvent):
(WebKit::UnifiedPDFPlugin::toContextMenuItemTag const):
(WebKit::UnifiedPDFPlugin::createContextMenu const):
(WebKit::UnifiedPDFPlugin::isDisplayModeContextMenuItemTag const):
(WebKit::UnifiedPDFPlugin::titleForContextMenuItemTag const):
(WebKit::UnifiedPDFPlugin::contextMenuItem const):
(WebKit::UnifiedPDFPlugin::separatorContextMenuItem const):
(WebKit::UnifiedPDFPlugin::selectionContextMenuItems const):
(WebKit::UnifiedPDFPlugin::displayModeContextMenuItems const):
(WebKit::UnifiedPDFPlugin::scaleContextMenuItems const):
(WebKit::UnifiedPDFPlugin::performContextMenuAction):

Canonical link: https://commits.webkit.org/274611@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 46a7bd: AX: com.apple.WebKit.WebContent crash at WebCore: ...

[Chris Fleizach]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 46a7bd3624b4319e46015765469ec176cb54850c
  
https://github.com/WebKit/WebKit/commit/46a7bd3624b4319e46015765469ec176cb54850c
  Author: Chris Fleizach 
  Date:   2024-02-14 (Wed, 14 Feb 2024)

  Changed paths:
M Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm

  Log Message:
  ---
  AX: com.apple.WebKit.WebContent crash at WebCore: 
-[WebAccessibilityObjectWrapper 
handleNotificationRelayToChrome:notificationData:]
https://bugs.webkit.org/show_bug.cgi?id=269319


Reviewed by (OOPS).

Ensure that we have a valid AXObjectCache before proceeding.

* Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm

Canonical link: https://commits.webkit.org/274610@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes