[webkit-changes] [WebKit/WebKit] 0ee25f: [view-transitions] Integrate with DocumentTimeline
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 0ee25f18f0a022047c25215a865d7a819a8bfe4f https://github.com/WebKit/WebKit/commit/0ee25f18f0a022047c25215a865d7a819a8bfe4f Author: Tim Nguyen Date: 2024-02-21 (Wed, 21 Feb 2024) Changed paths: M LayoutTests/TestExpectations M LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/style-inheritance-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/unset-and-initial-view-transition-name-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/view-transition-name-on-removed-element-expected.txt M Source/WebCore/animation/DocumentTimeline.cpp M Source/WebCore/animation/DocumentTimeline.h M Source/WebCore/dom/ViewTransition.cpp Log Message: --- [view-transitions] Integrate with DocumentTimeline https://bugs.webkit.org/show_bug.cgi?id=265228 rdar://118705652 Reviewed by Matt Woodrow. Go through animations instead of keyframe effects as specified by https://drafts.csswg.org/css-view-transitions-1/#handle-transition-frame-algorithm Consult pending events + playState as the algorithm specifies. * LayoutTests/TestExpectations: * LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/style-inheritance-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/unset-and-initial-view-transition-name-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/view-transition-name-on-removed-element-expected.txt: * Source/WebCore/animation/DocumentTimeline.cpp: (WebCore::DocumentTimeline::hasPendingAnimationEventForAnimation const): * Source/WebCore/animation/DocumentTimeline.h: * Source/WebCore/dom/ViewTransition.cpp: (WebCore::ViewTransition::handleTransitionFrame): (WebCore::ViewTransition::updatePseudoElementStyles): Canonical link: https://commits.webkit.org/275156@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 8b36ea: Devirtualize Event::eventInterface
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 8b36ea3d233a543f2307e2496f2a638d32a4b84a https://github.com/WebKit/WebKit/commit/8b36ea3d233a543f2307e2496f2a638d32a4b84a Author: Ryosuke Niwa Date: 2024-02-21 (Wed, 21 Feb 2024) Changed paths: M Source/WebCore/Modules/WebGPU/GPUUncapturedErrorEvent.cpp M Source/WebCore/Modules/airplay/WebKitPlaybackTargetAvailabilityEvent.cpp M Source/WebCore/Modules/applepay/ApplePayCancelEvent.cpp M Source/WebCore/Modules/applepay/ApplePayCouponCodeChangedEvent.cpp M Source/WebCore/Modules/applepay/ApplePayPaymentAuthorizedEvent.cpp M Source/WebCore/Modules/applepay/ApplePayPaymentMethodSelectedEvent.cpp M Source/WebCore/Modules/applepay/ApplePayShippingContactSelectedEvent.cpp M Source/WebCore/Modules/applepay/ApplePayShippingMethodSelectedEvent.cpp M Source/WebCore/Modules/applepay/ApplePayValidateMerchantEvent.cpp M Source/WebCore/Modules/cookie-store/CookieChangeEvent.cpp M Source/WebCore/Modules/cookie-store/ExtendableCookieChangeEvent.cpp M Source/WebCore/Modules/encryptedmedia/MediaKeyMessageEvent.cpp M Source/WebCore/Modules/encryptedmedia/legacy/WebKitMediaKeyMessageEvent.cpp M Source/WebCore/Modules/encryptedmedia/legacy/WebKitMediaKeyNeededEvent.cpp M Source/WebCore/Modules/gamepad/GamepadEvent.cpp M Source/WebCore/Modules/indexeddb/IDBRequestCompletionEvent.cpp M Source/WebCore/Modules/indexeddb/IDBVersionChangeEvent.cpp M Source/WebCore/Modules/mediarecorder/BlobEvent.cpp M Source/WebCore/Modules/mediarecorder/MediaRecorderErrorEvent.cpp M Source/WebCore/Modules/mediasource/BufferedChangeEvent.cpp M Source/WebCore/Modules/mediastream/MediaStreamTrackEvent.cpp M Source/WebCore/Modules/mediastream/OverconstrainedErrorEvent.h M Source/WebCore/Modules/mediastream/RTCDTMFToneChangeEvent.cpp M Source/WebCore/Modules/mediastream/RTCDataChannelEvent.cpp M Source/WebCore/Modules/mediastream/RTCErrorEvent.cpp M Source/WebCore/Modules/mediastream/RTCPeerConnectionIceErrorEvent.cpp M Source/WebCore/Modules/mediastream/RTCPeerConnectionIceEvent.cpp M Source/WebCore/Modules/mediastream/RTCRtpSFrameTransformErrorEvent.cpp M Source/WebCore/Modules/mediastream/RTCTrackEvent.cpp M Source/WebCore/Modules/mediastream/RTCTransformEvent.cpp M Source/WebCore/Modules/notifications/NotificationEvent.cpp M Source/WebCore/Modules/paymentrequest/MerchantValidationEvent.cpp M Source/WebCore/Modules/paymentrequest/PaymentMethodChangeEvent.cpp M Source/WebCore/Modules/paymentrequest/PaymentRequestUpdateEvent.cpp M Source/WebCore/Modules/paymentrequest/PaymentRequestUpdateEvent.h M Source/WebCore/Modules/pictureinpicture/PictureInPictureEvent.cpp M Source/WebCore/Modules/push-api/PushEvent.cpp M Source/WebCore/Modules/push-api/PushNotificationEvent.cpp M Source/WebCore/Modules/push-api/PushSubscriptionChangeEvent.cpp M Source/WebCore/Modules/speech/SpeechRecognitionErrorEvent.cpp M Source/WebCore/Modules/speech/SpeechRecognitionEvent.cpp M Source/WebCore/Modules/speech/SpeechSynthesisErrorEvent.cpp M Source/WebCore/Modules/speech/SpeechSynthesisEvent.cpp M Source/WebCore/Modules/speech/SpeechSynthesisEvent.h M Source/WebCore/Modules/webaudio/AudioProcessingEvent.cpp M Source/WebCore/Modules/webaudio/OfflineAudioCompletionEvent.cpp M Source/WebCore/Modules/websockets/CloseEvent.h M Source/WebCore/Modules/webxr/XRInputSourceEvent.cpp M Source/WebCore/Modules/webxr/XRInputSourcesChangeEvent.cpp M Source/WebCore/Modules/webxr/XRReferenceSpaceEvent.cpp M Source/WebCore/Modules/webxr/XRSessionEvent.cpp M Source/WebCore/animation/AnimationEventBase.cpp M Source/WebCore/animation/AnimationEventBase.h M Source/WebCore/animation/AnimationPlaybackEvent.cpp M Source/WebCore/animation/CSSAnimationEvent.cpp M Source/WebCore/animation/CSSTransitionEvent.cpp M Source/WebCore/animation/StyleOriginatedAnimationEvent.cpp M Source/WebCore/animation/StyleOriginatedAnimationEvent.h M Source/WebCore/bindings/scripts/InFilesCompiler.pm M Source/WebCore/css/MediaQueryListEvent.cpp M Source/WebCore/dom/BeforeTextInsertedEvent.cpp M Source/WebCore/dom/BeforeUnloadEvent.cpp M Source/WebCore/dom/ClipboardEvent.cpp M Source/WebCore/dom/CompositionEvent.cpp M Source/WebCore/dom/ContentVisibilityAutoStateChangeEvent.cpp M Source/WebCore/dom/CustomEvent.cpp M Source/WebCore/dom/DeviceMotionEvent.cpp M Source/WebCore/dom/DeviceOrientationEvent.cpp M Source/WebCore/dom/DragEvent.cpp M Source/WebCore/dom/ErrorEvent.cpp M Source/WebCore/dom/Event.cpp M Source/WebCore/dom/Event.h M Source/WebCore/dom/FocusEvent.cpp M Source/WebCore/dom/FocusEvent.h M Source/WebCore/dom/FormDataEvent.cpp M Source/WebCore/dom/HashChangeEvent.h M Source/WebCore/dom/InputEvent.cpp M Source/WebCo
[webkit-changes] [WebKit/WebKit] 27713e: [WebKitSwift] Add a target dependency on WebKit
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 27713ed79eddae10b8e98de95a1aa8a34b9cdadb https://github.com/WebKit/WebKit/commit/27713ed79eddae10b8e98de95a1aa8a34b9cdadb Author: Wenson Hsieh Date: 2024-02-21 (Wed, 21 Feb 2024) Changed paths: M Source/WebKit/WebKit.xcodeproj/project.pbxproj Log Message: --- [WebKitSwift] Add a target dependency on WebKit https://bugs.webkit.org/show_bug.cgi?id=269879 Reviewed by Andy Estes. Make WebKitSwift depend on WebKit. The new logic in `WKWebView+TextExtraction.swift` will require importing the WebKit module from within WebKitSwift, which requires the WebKit build to be finished first. With the changes in 275053@main, WebKit no longer depends on WebKitSwift's umbrella header, so it's now safe to simply add this target dependency. Without this change, engineering builds that enable the build-time flags within `WKWebView+TextExtraction.swift` may sporadically fail when building WebKit. * Source/WebKit/WebKit.xcodeproj/project.pbxproj: Canonical link: https://commits.webkit.org/275154@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 07ca7d: [Navigation] Implement more of NavigationHistoryEntry
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 07ca7d40e32bb25bfc5ba2bc2e41870d0b20e5bc https://github.com/WebKit/WebKit/commit/07ca7d40e32bb25bfc5ba2bc2e41870d0b20e5bc Author: Rob Buis Date: 2024-02-21 (Wed, 21 Feb 2024) Changed paths: M LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigation-history-entry/current-basic-expected.txt M Source/WebCore/page/Navigation.cpp M Source/WebCore/page/NavigationHistoryEntry.cpp M Source/WebCore/page/NavigationHistoryEntry.h Log Message: --- [Navigation] Implement more of NavigationHistoryEntry https://bugs.webkit.org/show_bug.cgi?id=268986 Reviewed by Alex Christensen. Implement more of NavigationHistoryEntry according to the specification: - implement index by looking the NavigationHistoryEntry up in the entries of the associated Navigation object. - implement sameDocument by checking whether it is same document to the current history item. * LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigation-history-entry/current-basic-expected.txt: * Source/WebCore/page/Navigation.cpp: (WebCore::Navigation::back): (WebCore::Navigation::forward): * Source/WebCore/page/NavigationHistoryEntry.cpp: (WebCore::NavigationHistoryEntry::NavigationHistoryEntry): (WebCore::NavigationHistoryEntry::index const): (WebCore::NavigationHistoryEntry::sameDocument const): * Source/WebCore/page/NavigationHistoryEntry.h: Canonical link: https://commits.webkit.org/275153@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 5fc81f: [JSC] Fix parsing of private fields with Unicode s...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 5fc81f8795e87f422134be7c28ca4636b1afedf3 https://github.com/WebKit/WebKit/commit/5fc81f8795e87f422134be7c28ca4636b1afedf3 Author: Ross Kirsling Date: 2024-02-21 (Wed, 21 Feb 2024) Changed paths: M JSTests/test262/expectations.yaml M Source/JavaScriptCore/parser/Lexer.cpp Log Message: --- [JSC] Fix parsing of private fields with Unicode start characters https://bugs.webkit.org/show_bug.cgi?id=269831 Reviewed by Darin Adler and Yusuke Suzuki. Our lexer can't currently handle various class-private field names with valid Unicode start characters, like `#𐡀`. After seeing that m_current is '#', we call isSingleCharacterIdentStart(peek(1)), which complains of U16_IS_SURROGATE; instead of trying to cut a corner, we need to get the next code point from U16_GET, just like we did for m_current. * JSTests/test262/expectations.yaml: Mark 24 test cases passing. * Source/JavaScriptCore/parser/Lexer.cpp: (JSC::Lexer::lexWithoutClearingLineTerminator): Use U16_GET when a private field name starts with a non-Latin1 character. Canonical link: https://commits.webkit.org/275152@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 241d9a: [UnifiedPDF] Track PageCoverage for each rendered ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 241d9ab4f0c9a478c19560d63cd2743691228320 https://github.com/WebKit/WebKit/commit/241d9ab4f0c9a478c19560d63cd2743691228320 Author: Simon Fraser Date: 2024-02-21 (Wed, 21 Feb 2024) Changed paths: M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/AsyncPDFRenderer.h M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/AsyncPDFRenderer.mm Log Message: --- [UnifiedPDF] Track PageCoverage for each rendered tile https://bugs.webkit.org/show_bug.cgi?id=269887 rdar://123416384 Reviewed by Tim Horton. In order to store PDFPageCoverage per rendered tile, reshuffle the data structures in AsyncPDFRenderer a little. We can fold the `tileRect` into `TileRenderInfo`, which means it gets passed to the decoding callback and back to the main thread in that struct so we no longer need to track it separately. Then we can store a `TileRenderInfo` in what used to be called `BufferAndClip`, and is here renamed to `RenderedTile`. That then now tracks the tileRect, the configurationIdentifier and the PDFPageCoverage. No behavior change. * Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/AsyncPDFRenderer.h: * Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/AsyncPDFRenderer.mm: (WebKit::AsyncPDFRenderer::enqueuePaintWithClip): (WebKit::AsyncPDFRenderer::paintTileOnWorkQueue): (WebKit::AsyncPDFRenderer::paintPDFIntoBuffer): (WebKit::AsyncPDFRenderer::transferBufferToMainThread): (WebKit::AsyncPDFRenderer::paintTilesForPaintingRect): (WebKit::AsyncPDFRenderer::invalidateTilesForPaintingRect): Canonical link: https://commits.webkit.org/275151@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 8aed81: [UnifiedPDF] PDFPluginAnnotations need to be repos...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 8aed81df35f81ca9f75368e75b52f1e012ce89f0 https://github.com/WebKit/WebKit/commit/8aed81df35f81ca9f75368e75b52f1e012ce89f0 Author: Sammy Gill Date: 2024-02-21 (Wed, 21 Feb 2024) Changed paths: M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm Log Message: --- [UnifiedPDF] PDFPluginAnnotations need to be repositioned on layout changes https://bugs.webkit.org/show_bug.cgi?id=269870 rdar://123119217 Reviewed by Simon Fraser. Whenever the plugin's geometry is updated, then we need to check if there is a currently active annotation. If there is then we inform the annotation of this and have it update its geometry in response to the change. * Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm: (WebKit::UnifiedPDFPlugin::geometryDidChange): Canonical link: https://commits.webkit.org/275150@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 3194a2: CrashTracer: com.apple.WebKit.WebContent at WebKit...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 3194a24ba7ab15a9d565d7b0bed9e0f6c7e66bf4 https://github.com/WebKit/WebKit/commit/3194a24ba7ab15a9d565d7b0bed9e0f6c7e66bf4 Author: Aditya Keerthi Date: 2024-02-21 (Wed, 21 Feb 2024) Changed paths: M Source/WebKit/WebProcess/WebPage/WebPage.cpp Log Message: --- CrashTracer: com.apple.WebKit.WebContent at WebKit: WebKit::WebPage::drawPagesToPDFImpl https://bugs.webkit.org/show_bug.cgi?id=269881 rdar://99740304 Reviewed by Wenson Hsieh. Crash reports have been showing null derefs of `m_printContext` under `drawPagesToPDFImpl`. However, it is unclear exactly what results in this scenario, and a user reports have not been found. Fix by adding a null check. * Source/WebKit/WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::drawPagesToPDFImpl): Canonical link: https://commits.webkit.org/275149@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 24b6ac: [macOS Debug] TestWebKitAPI.SiteIsolation.WebsiteP...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 24b6aca8482a00b3d17eb504ea91be0423ff8928 https://github.com/WebKit/WebKit/commit/24b6aca8482a00b3d17eb504ea91be0423ff8928 Author: Charlie Wolfe Date: 2024-02-21 (Wed, 21 Feb 2024) Changed paths: M Source/WebKit/UIProcess/RemotePageProxy.cpp M Source/WebKit/UIProcess/WebPageProxy.cpp Log Message: --- [macOS Debug] TestWebKitAPI.SiteIsolation.WebsitePoliciesCustomUserAgentDuringCrossSiteProvisionalNavigation is a consistent crash https://bugs.webkit.org/show_bug.cgi?id=269746 rdar://123265363 Reviewed by Alex Christensen. I needed to make two changes to get this test to not hit debug assertions: - When a subframe swaps processes it was possible for it to cancel the provisional load of the main frame. A provisional page load should only be canceled if another main frame provisional load was started. - `WebPageProxy::currentURL` would return the provisional or committed URL. This would cause some allowedFirstPartyForCookies checks to fail when subframe processes made requests while the main frame was in a provisional load state. `SubframeProcessPageParameters` should always use the main frame committed URL. * Source/WebKit/UIProcess/RemotePageProxy.cpp: (WebKit::RemotePageProxy::injectPageIntoNewProcess): * Source/WebKit/UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::continueNavigationInNewProcess): Canonical link: https://commits.webkit.org/275148@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] a8f799: Unreviewed build fix after 275140@main
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: a8f79986379822f154bf60060894c9424f1ca98c https://github.com/WebKit/WebKit/commit/a8f79986379822f154bf60060894c9424f1ca98c Author: Fujii Hironori Date: 2024-02-21 (Wed, 21 Feb 2024) Changed paths: M Source/WebCore/Headers.cmake Log Message: --- Unreviewed build fix after 275140@main GTK, WPE, Win and PlayStation couldn't compile. > Debug/DerivedSources/WebKit/MessageArgumentDescriptions.cpp:110:10: fatal > error: WebCore/ModelPlayerIdentifier.h: No such file or directory * Source/WebCore/Headers.cmake: Added ModelPlayerIdentifier.h. Canonical link: https://commits.webkit.org/275147@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] e7d325: [Apple Pay] Support for PKDisbursementRequest on W...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: e7d32568225abe6427fe6c5a3958b43fc9326ec4 https://github.com/WebKit/WebKit/commit/e7d32568225abe6427fe6c5a3958b43fc9326ec4 Author: Robin Malhotra Date: 2024-02-21 (Wed, 21 Feb 2024) Changed paths: A LayoutTests/http/tests/paymentrequest/ApplePayModifier-disbursementPaymentRequest.https-expected.txt A LayoutTests/http/tests/paymentrequest/ApplePayModifier-disbursementPaymentRequest.https.html M LayoutTests/platform/ios-wk2/TestExpectations M LayoutTests/platform/mac-wk2/TestExpectations M Source/WTF/wtf/PlatformEnableCocoa.h M Source/WebCore/DerivedSources-input.xcfilelist M Source/WebCore/DerivedSources-output.xcfilelist M Source/WebCore/DerivedSources.make M Source/WebCore/Modules/applepay/ApplePayDetailsUpdateBase.h M Source/WebCore/Modules/applepay/ApplePayDetailsUpdateBase.idl A Source/WebCore/Modules/applepay/ApplePayDisbursementPaymentRequest.h A Source/WebCore/Modules/applepay/ApplePayDisbursementPaymentRequest.idl M Source/WebCore/Modules/applepay/ApplePayFeature.h M Source/WebCore/Modules/applepay/ApplePayFeature.idl M Source/WebCore/Modules/applepay/ApplePayLineItem.h M Source/WebCore/Modules/applepay/ApplePayLineItem.idl M Source/WebCore/Modules/applepay/ApplePayMerchantCapability.cpp M Source/WebCore/Modules/applepay/ApplePayMerchantCapability.h M Source/WebCore/Modules/applepay/ApplePayMerchantCapability.idl M Source/WebCore/Modules/applepay/ApplePayPaymentRequest.h M Source/WebCore/Modules/applepay/ApplePayPaymentRequest.idl M Source/WebCore/Modules/applepay/ApplePaySession.cpp M Source/WebCore/Modules/applepay/ApplePaySessionPaymentRequest.h M Source/WebCore/Modules/applepay/PaymentSummaryItems.h M Source/WebCore/Modules/applepay/cocoa/PaymentSummaryItemsCocoa.mm M Source/WebCore/Modules/applepay/paymentrequest/ApplePayModifier.h M Source/WebCore/Modules/applepay/paymentrequest/ApplePayModifier.idl M Source/WebCore/Modules/applepay/paymentrequest/ApplePayPaymentHandler.cpp M Source/WebCore/PAL/pal/cocoa/PassKitSoftLink.h M Source/WebCore/PAL/pal/cocoa/PassKitSoftLink.mm M Source/WebCore/PAL/pal/spi/cocoa/PassKitSPI.h M Source/WebCore/SourcesCocoa.txt M Source/WebCore/WebCore.xcodeproj/project.pbxproj M Source/WebCore/testing/MockPaymentCoordinator.cpp M Source/WebCore/testing/MockPaymentCoordinator.h M Source/WebCore/testing/MockPaymentCoordinator.idl M Source/WebKit/Platform/cocoa/PaymentAuthorizationPresenter.mm A Source/WebKit/Shared/ApplePay/DisbursementPaymentRequest.h A Source/WebKit/Shared/ApplePay/cocoa/DisbursementPaymentRequestCocoa.mm M Source/WebKit/Shared/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.h M Source/WebKit/Shared/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.mm M Source/WebKit/Shared/ApplePay/ios/WebPaymentCoordinatorProxyIOS.mm M Source/WebKit/Shared/ApplePay/mac/WebPaymentCoordinatorProxyMac.mm M Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in M Source/WebKit/SourcesCocoa.txt M Source/WebKit/WebKit.xcodeproj/project.pbxproj Log Message: --- [Apple Pay] Support for PKDisbursementRequest on WebKit https://bugs.webkit.org/show_bug.cgi?id=267428 rdar://115776022 Reviewed by Alex Christensen. Originally authored by Robin Malhotra. This patch adds support for `PKDisbursementRequest` and associated classes. Since `PKDisbursementPaymentRequest` is a subclass and not a property, the code paths may sometimes diverge from convention. * LayoutTests/http/tests/paymentrequest/ApplePayModifier-disbursementPaymentRequest.https-expected.txt: Added. * LayoutTests/http/tests/paymentrequest/ApplePayModifier-disbursementPaymentRequest.https.html: Added. * LayoutTests/platform/ios-wk2/TestExpectations: * LayoutTests/platform/mac-wk2/TestExpectations: * Source/WTF/wtf/PlatformEnableCocoa.h: * Source/WebCore/DerivedSources-input.xcfilelist: * Source/WebCore/DerivedSources-output.xcfilelist: * Source/WebCore/DerivedSources.make: * Source/WebCore/Modules/applepay/ApplePayDetailsUpdateBase.h: * Source/WebCore/Modules/applepay/ApplePayDetailsUpdateBase.idl: * Source/WebCore/Modules/applepay/ApplePayDisbursementPaymentRequest.h: Copied from Source/WebCore/Modules/applepay/ApplePayMerchantCapability.h. * Source/WebCore/Modules/applepay/ApplePayDisbursementPaymentRequest.idl: Copied from Source/WebCore/Modules/applepay/ApplePayMerchantCapability.idl. * Source/WebCore/Modules/applepay/ApplePayFeature.h: * Source/WebCore/Modules/applepay/ApplePayFeature.idl: * Source/WebCore/Modules/applepay/ApplePayLineItem.h: * Source/WebCore/Modules/applepay/ApplePayLineItem.idl: * Source/WebCore/Modules/applepay/ApplePayMerchantCapability.cpp: (WebCore::convertAndValidate): * Source/WebCore/Modules/applepay/ApplePayMerchantCapability.h: * Source/WebCore/Modules/applepay/ApplePayMerchantCapability.
[webkit-changes] [WebKit/WebKit] 7b9edc: Adopt dynamicDowncast<> in ScrollingTree
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 7b9edce24ba63e56f25348a04714bf918f788cd9 https://github.com/WebKit/WebKit/commit/7b9edce24ba63e56f25348a04714bf918f788cd9 Author: Anne van Kesteren Date: 2024-02-21 (Wed, 21 Feb 2024) Changed paths: M Source/WebCore/page/scrolling/ScrollingTree.cpp Log Message: --- Adopt dynamicDowncast<> in ScrollingTree https://bugs.webkit.org/show_bug.cgi?id=269866 Reviewed by Chris Dumez. * Source/WebCore/page/scrolling/ScrollingTree.cpp: (WebCore::ScrollingTree::handleWheelEvent): (WebCore::ScrollingTree::handleWheelEventWithNode): (WebCore::ScrollingTree::traverseScrollingTreeRecursive): (WebCore::ScrollingTree::updateTreeFromStateNodeRecursive): (WebCore::ScrollingTree::serviceScrollAnimations): (WebCore::ScrollingTree::scrollBySimulatingWheelEventForTesting): Canonical link: https://commits.webkit.org/275145@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 35cfdf: setupTransitionPseudoElements doesn't update the v...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 35cfdf3fdab6aa072eb6203618c0f7b6189aab66 https://github.com/WebKit/WebKit/commit/35cfdf3fdab6aa072eb6203618c0f7b6189aab66 Author: Matt Woodrow Date: 2024-02-21 (Wed, 21 Feb 2024) Changed paths: M LayoutTests/TestExpectations M LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/group-animation-for-root-transition-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/mix-blend-mode-only-on-transition-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/paused-animation-at-end-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/style-inheritance-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/synchronous-callback-skipped-before-run-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/unset-and-initial-view-transition-name-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/view-transition-name-on-removed-element-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/window-resize-aborts-transition-expected.txt M LayoutTests/platform/glib/TestExpectations M Source/WebCore/dom/ViewTransition.cpp M Source/WebCore/dom/ViewTransition.h M Source/WebCore/style/StyleResolver.cpp M Source/WebCore/style/StyleResolver.h Log Message: --- setupTransitionPseudoElements doesn't update the view transition dynamic style sheet. https://bugs.webkit.org/show_bug.cgi?id=265225 Reviewed by Tim Nguyen. Refactors Resolver::setViewTransitionGroupStyle to take the pseduo element type, and builds the appropriate selector, so that it can be used for all view-transition pseudo elements. Adds the generation of the view-transition dynamic style sheet styles to ViewTransition::setupTransitionPseudoElements. * LayoutTests/TestExpectations: * LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/mix-blend-mode-only-on-transition-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/paused-animation-at-end-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/style-inheritance-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/unset-and-initial-view-transition-name-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/view-transition-name-on-removed-element-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/window-resize-aborts-transition-expected.txt: * Source/WebCore/dom/ViewTransition.cpp: (WebCore::ViewTransition::setupDynamicStyleSheet): (WebCore::ViewTransition::setupTransitionPseudoElements): (WebCore::ViewTransition::copyElementBaseProperties): (WebCore::ViewTransition::updatePseudoElementStyles): * Source/WebCore/dom/ViewTransition.h: * Source/WebCore/style/StyleResolver.cpp: (WebCore::Style::viewTransitionSelector): (WebCore::Style::Resolver::setViewTransitionStyles): (WebCore::Style::Resolver::setViewTransitionGroupStyles): Deleted. * Source/WebCore/style/StyleResolver.h: Canonical link: https://commits.webkit.org/275144@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 08a1f3: Fix Web Inspector: Remember the message type selec...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 08a1f3998383fe5de26c9910bff87e89cb1739f3 https://github.com/WebKit/WebKit/commit/08a1f3998383fe5de26c9910bff87e89cb1739f3 Author: Qianlang Chen Date: 2024-02-21 (Wed, 21 Feb 2024) Changed paths: M Source/WebInspectorUI/UserInterface/Base/Main.js M Source/WebInspectorUI/UserInterface/Protocol/InspectorFrontendAPI.js M Source/WebInspectorUI/UserInterface/Views/LogContentView.js Log Message: --- Fix Web Inspector: Remember the message type selection in the Console tab rdar://122924275 https://bugs.webkit.org/show_bug.cgi?id=268882 Reviewed by Devin Rousso. When showing the the inspector's console using `WI.showConsole()`, the caller can optionally pass in a `requestedScope` to control which levels (AKA message types) to be filtered automatically when the Console tab shows up. However, when `requestedScope` is falsy or left empty, it always applies `WI.LogContentView.Scopes.All` instead, which overrides the levels selected by default, which are read from local settings when the scope bar is created at the inspector's startup. This commit removes the forced application of `Scopes.All`, so when `requestedScope` is left empty, the Console tab is shown with levels unchanged, which is the expected behavior when launching the Console tab through Develop -> Show JavaScript Console (or Option-Command-C). This fix has one known side-effect: when an inspector tab does not support split console view, pressing Esc will switch to the actual Console tab instead. (The Settings tab is one example of such tab.) This commit will make that also "remember" the previously selected levels instead of deselecting back to just `Scopes.All`, which is arguably the correct behavior anyway. This commit also cleans up on how `requestedScope` gets passed in; passing in as part of the `options` parameter allows callers of `showConsole()` to self-document the usage `requestedScope`. * Source/WebInspectorUI/UserInterface/Base/Main.js: - Fix the bug. - Adapt to the clean up for the `options` parameter. * Source/WebInspectorUI/UserInterface/Protocol/InspectorFrontendAPI.js: (InspectorFrontendAPI.showConsole): - Adapt to the clean up for the `options` parameter. * Source/WebInspectorUI/UserInterface/Views/LogContentView.js: (WI.LogContentView.prototype._showConsoleTab): - Adapt to the clean up for the `options` parameter. Canonical link: https://commits.webkit.org/275143@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 8a5f3f: Remove unneeded weak pointer check on process launch
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 8a5f3ff1b58ba3c0d8f0c67ad4089509102fa602 https://github.com/WebKit/WebKit/commit/8a5f3ff1b58ba3c0d8f0c67ad4089509102fa602 Author: Per Arne Vollan Date: 2024-02-21 (Wed, 21 Feb 2024) Changed paths: M Source/WebKit/UIProcess/Launcher/cocoa/ProcessLauncherCocoa.mm Log Message: --- Remove unneeded weak pointer check on process launch https://bugs.webkit.org/show_bug.cgi?id=269862 rdar://123398702 Reviewed by Chris Dumez. Remove unneeded weak pointer check on non main thread on process launch. This weak pointer check can make the Process launcher be destroyed on the non main thread, which is incorrect. * Source/WebKit/UIProcess/Launcher/cocoa/ProcessLauncherCocoa.mm: (WebKit::ProcessLauncher::launchProcess): Canonical link: https://commits.webkit.org/275142@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 6db9bb: Adopt dynamicDowncast<> in platform/calc/Calc*
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 6db9bb57df3bfff6c2a29bf793aaef9768d86b71 https://github.com/WebKit/WebKit/commit/6db9bb57df3bfff6c2a29bf793aaef9768d86b71 Author: Anne van Kesteren Date: 2024-02-21 (Wed, 21 Feb 2024) Changed paths: M Source/WebCore/platform/calc/CalcExpressionBlendLength.cpp M Source/WebCore/platform/calc/CalcExpressionInversion.cpp M Source/WebCore/platform/calc/CalcExpressionLength.cpp M Source/WebCore/platform/calc/CalcExpressionNegation.cpp M Source/WebCore/platform/calc/CalcExpressionNumber.cpp M Source/WebCore/platform/calc/CalcExpressionOperation.cpp Log Message: --- Adopt dynamicDowncast<> in platform/calc/Calc* https://bugs.webkit.org/show_bug.cgi?id=269857 Reviewed by Chris Dumez. * Source/WebCore/platform/calc/CalcExpressionBlendLength.cpp: (WebCore::CalcExpressionBlendLength::CalcExpressionBlendLength): (WebCore::CalcExpressionBlendLength::operator== const): * Source/WebCore/platform/calc/CalcExpressionInversion.cpp: (WebCore::CalcExpressionInversion::operator== const): * Source/WebCore/platform/calc/CalcExpressionLength.cpp: (WebCore::CalcExpressionLength::operator== const): * Source/WebCore/platform/calc/CalcExpressionNegation.cpp: (WebCore::CalcExpressionNegation::operator== const): * Source/WebCore/platform/calc/CalcExpressionNumber.cpp: (WebCore::CalcExpressionNumber::operator== const): * Source/WebCore/platform/calc/CalcExpressionOperation.cpp: (WebCore::CalcExpressionOperation::operator== const): Canonical link: https://commits.webkit.org/275141@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] a990f1: Multiplexes messages sent to ModelProcess from Web...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: a990f17d6abe0458febd3c8b58a4daf66bfa9871 https://github.com/WebKit/WebKit/commit/a990f17d6abe0458febd3c8b58a4daf66bfa9871 Author: Eddy Wong Date: 2024-02-21 (Wed, 21 Feb 2024) Changed paths: M Source/WebCore/WebCore.xcodeproj/project.pbxproj A Source/WebCore/platform/graphics/ModelPlayerIdentifier.h M Source/WebKit/CMakeLists.txt M Source/WebKit/DerivedSources-input.xcfilelist M Source/WebKit/DerivedSources-output.xcfilelist M Source/WebKit/DerivedSources.make M Source/WebKit/ModelProcess/ModelConnectionToWebProcess.cpp M Source/WebKit/ModelProcess/ModelConnectionToWebProcess.h M Source/WebKit/ModelProcess/ModelConnectionToWebProcess.messages.in A Source/WebKit/ModelProcess/ModelProcessModelPlayerManagerProxy.cpp A Source/WebKit/ModelProcess/ModelProcessModelPlayerManagerProxy.h A Source/WebKit/ModelProcess/ModelProcessModelPlayerManagerProxy.messages.in A Source/WebKit/ModelProcess/ModelProcessModelPlayerProxy.cpp A Source/WebKit/ModelProcess/ModelProcessModelPlayerProxy.h A Source/WebKit/ModelProcess/ModelProcessModelPlayerProxy.messages.in M Source/WebKit/Scripts/webkit/messages.py M Source/WebKit/Scripts/webkit/tests/MessageArgumentDescriptions.cpp M Source/WebKit/Scripts/webkit/tests/SerializedTypeInfo.cpp M Source/WebKit/Shared/WTFArgumentCoders.serialization.in M Source/WebKit/Sources.txt M Source/WebKit/SourcesCocoa.txt M Source/WebKit/WebKit.xcodeproj/project.pbxproj M Source/WebKit/WebProcess/Model/ModelProcessConnection.cpp M Source/WebKit/WebProcess/Model/ModelProcessConnection.h A Source/WebKit/WebProcess/Model/ModelProcessModelPlayer.cpp M Source/WebKit/WebProcess/Model/ModelProcessModelPlayer.h A Source/WebKit/WebProcess/Model/ModelProcessModelPlayer.messages.in R Source/WebKit/WebProcess/Model/ModelProcessModelPlayer.mm A Source/WebKit/WebProcess/Model/ModelProcessModelPlayerManager.cpp A Source/WebKit/WebProcess/Model/ModelProcessModelPlayerManager.h M Source/WebKit/WebProcess/Model/WebModelPlayerProvider.cpp M Source/WebKit/WebProcess/Plugins/PDF/PDFPluginBase.mm M Source/WebKit/WebProcess/WebPage/UnifiedTextReplacementController.cpp M Source/WebKit/WebProcess/WebPage/wpe/WebPageWPE.cpp M Source/WebKit/WebProcess/WebProcess.cpp M Source/WebKit/WebProcess/WebProcess.h Log Message: --- Multiplexes messages sent to ModelProcess from WebProcess https://bugs.webkit.org/show_bug.cgi?id=269631 rdar://123122822 (Multiplexing IPC messages) Reviewed by Tim Horton. Implements IPC messages multiplexing for Model process to handle distinct model tags. On WebProcess side, added: ModelProcessModelPlayerManager, a per-WebProcess singleton, which creates/manages all ModelProcessModelPlayer for the same WebProcess. On ModelProcess side, added: ModelProcessModelPlayerManagerProxy, which exists 1:1 to ModelConnectionToWebProcess, ModelProcessModelPlayerManagerProxy creates/manages all ModelProcessModelPlayerProxy for the same WebProcess. Added IPC dispatching mechanism so that ModelProcessModelPlayer can easily send a message to its corresponding ModelProcessModelPlayerProxy, and vice versa. * Source/WebCore/WebCore.xcodeproj/project.pbxproj: * Source/WebCore/platform/graphics/ModelPlayerIdentifier.h: Added. This identifies different model tags from the same WebProcess. * Source/WebKit/DerivedSources-input.xcfilelist: * Source/WebKit/DerivedSources-output.xcfilelist: * Source/WebKit/DerivedSources.make: * Source/WebKit/ModelProcess/ModelConnectionToWebProcess.cpp: (WebKit::ModelConnectionToWebProcess::ModelConnectionToWebProcess): (WebKit::ModelConnectionToWebProcess::dispatchMessage): * Source/WebKit/ModelProcess/ModelConnectionToWebProcess.h: (WebKit::ModelConnectionToWebProcess::protectedConnection): (WebKit::ModelConnectionToWebProcess::modelProcessModelPlayerManagerProxy): * Source/WebKit/ModelProcess/ModelConnectionToWebProcess.messages.in: * Source/WebKit/ModelProcess/ModelProcessModelPlayerManagerProxy.cpp: Added. (WebKit::ModelProcessModelPlayerManagerProxy::ModelProcessModelPlayerManagerProxy): (WebKit::ModelProcessModelPlayerManagerProxy::~ModelProcessModelPlayerManagerProxy): (WebKit::ModelProcessModelPlayerManagerProxy::clear): (WebKit::ModelProcessModelPlayerManagerProxy::createModelPlayer): (WebKit::ModelProcessModelPlayerManagerProxy::deleteModelPlayer): (WebKit::ModelProcessModelPlayerManagerProxy::didReceivePlayerMessage): * Source/WebKit/ModelProcess/ModelProcessModelPlayerManagerProxy.h: Added. (WebKit::ModelProcessModelPlayerManagerProxy::modelConnectionToWebProcess): (WebKit::ModelProcessModelPlayerManagerProxy::didReceiveMessageFromWebProcess): * Source/WebKit/ModelProcess/ModelProcessModelPlayerManagerProxy.messages.in: Added. * Source/WebKit/ModelProcess/ModelProcessModelPlayerProxy.cpp: Copied from Source/WebKit/WebProces
[webkit-changes] [WebKit/WebKit] 9946d9: [Gardening]: New test (274810@main): [ macOS iOS ]...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 9946d935760f81365fd7cfc9136233d70cfe3f59 https://github.com/WebKit/WebKit/commit/9946d935760f81365fd7cfc9136233d70cfe3f59 Author: Karl Rackler Date: 2024-02-21 (Wed, 21 Feb 2024) Changed paths: M LayoutTests/TestExpectations M LayoutTests/platform/ios/TestExpectations M LayoutTests/platform/mac/TestExpectations Log Message: --- [Gardening]: New test (274810@main): [ macOS iOS ] 13 SVG tests are a consistent image failure https://bugs.webkit.org/show_bug.cgi?id=269880 rdar://123413079 Unreviewed test gardening. Modify tests expectations. * LayoutTests/TestExpectations: * LayoutTests/platform/ios/TestExpectations: * LayoutTests/platform/mac/TestExpectations: Canonical link: https://commits.webkit.org/275139@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] d578ab: Gardening: [ iOS ] Duplicate/ambiguous expectation...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: d578ab75ab0361b5e7385c31dd87572ebfb507fe https://github.com/WebKit/WebKit/commit/d578ab75ab0361b5e7385c31dd87572ebfb507fe Author: Ben Schwartz Date: 2024-02-21 (Wed, 21 Feb 2024) Changed paths: M LayoutTests/platform/ios/TestExpectations M LayoutTests/platform/ipad/TestExpectations Log Message: --- Gardening: [ iOS ] Duplicate/ambiguous expectations warnings logged every time layout tests are run. https://bugs.webkit.org/show_bug.cgi?id=269872 rdar://123404452 Unreviewed test gardening. Updating test expectations to remove `--lint-test-files` warnings. * LayoutTests/platform/ios/TestExpectations: * LayoutTests/platform/ipad/TestExpectations: Canonical link: https://commits.webkit.org/275138@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 3e7f2c: REGRESSION(274164@main): Do not consult against Do...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 3e7f2c1bc01db4255c2de428d4b5d04ab054df86 https://github.com/WebKit/WebKit/commit/3e7f2c1bc01db4255c2de428d4b5d04ab054df86 Author: Yusuke Suzuki Date: 2024-02-21 (Wed, 21 Feb 2024) Changed paths: M Source/WebCore/dom/Document.cpp M Source/WebCore/dom/Document.h M Source/WebCore/html/CanvasBase.cpp M Source/WebCore/html/HTMLCanvasElement.cpp M Source/WebCore/html/canvas/CanvasRenderingContext.h Log Message: --- REGRESSION(274164@main): Do not consult against Document's WeakHashSet for every Canvas ops https://bugs.webkit.org/show_bug.cgi?id=269867 rdar://123400342 Reviewed by Ryosuke Niwa. 274164@main introduced addCanvasNeedingPreparationForDisplayOrFlush and removeCanvasNeedingPreparationForDisplayOrFlush, which consult against Document's WeakHashSet for every Canvas operation. Because each Canvas operation is very tiny, Canvas operations are called super frequently, and any kind of performance regression on each call can be exhibited as visible performance regression. WeakHashSet querying is costly, and Document is super large so frequent cache miss happens. Instead, we store a bool flag to CanvasRenderingContext, which says whether it is registered in Document's WeakHashSet. And avoid this costly operation once it gets registered. * Source/WebCore/dom/Document.cpp: (WebCore::Document::prepareCanvasesForDisplayOrFlushIfNeeded): (WebCore::Document::addCanvasNeedingPreparationForDisplayOrFlush): (WebCore::Document::removeCanvasNeedingPreparationForDisplayOrFlush): * Source/WebCore/dom/Document.h: * Source/WebCore/html/CanvasBase.cpp: (WebCore::CanvasBase::addCanvasNeedingPreparationForDisplayOrFlush): (WebCore::CanvasBase::removeCanvasNeedingPreparationForDisplayOrFlush): * Source/WebCore/html/HTMLCanvasElement.cpp: (WebCore::HTMLCanvasElement::didMoveToNewDocument): * Source/WebCore/html/canvas/CanvasRenderingContext.h: (WebCore::CanvasRenderingContext::setIsToPrepare): (WebCore::CanvasRenderingContext::isInPreparationForDisplayOrFlush const): Canonical link: https://commits.webkit.org/275137@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 919460: [Gardening]: NEW TEST [ MacOS ] imported/w3c/web-p...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 9194607c515c82a1b1966e3d7967727ea1aac9c4 https://github.com/WebKit/WebKit/commit/9194607c515c82a1b1966e3d7967727ea1aac9c4 Author: Jay Stfleur Date: 2024-02-21 (Wed, 21 Feb 2024) Changed paths: M LayoutTests/platform/mac-wk2/TestExpectations Log Message: --- [Gardening]: NEW TEST [ MacOS ] imported/w3c/web-platform-tests/media-source/dedicated-worker/mediasource-worker-detach-element.html is a flaky crash https://bugs.webkit.org/show_bug.cgi?id=123404489 rdar://123404489 Unreviewed test gardening. Adding test expectation * LayoutTests/platform/mac-wk2/TestExpectations: Canonical link: https://commits.webkit.org/275136@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 7c0a7f: EmberJS Web Extension fails to detect Ember applic...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 7c0a7f074ef28ce5047f221780989c47e18e763c https://github.com/WebKit/WebKit/commit/7c0a7f074ef28ce5047f221780989c47e18e763c Author: Timothy Hatcher Date: 2024-02-21 (Wed, 21 Feb 2024) Changed paths: M Source/WebKit/Shared/Extensions/WebExtensionContentWorldType.h M Source/WebKit/Shared/Extensions/WebExtensionContentWorldType.serialization.in M Source/WebKit/Shared/Extensions/WebExtensionContextParameters.h M Source/WebKit/Shared/Extensions/WebExtensionContextParameters.serialization.in M Source/WebKit/UIProcess/Extensions/Cocoa/API/WebExtensionContextAPIPortCocoa.mm M Source/WebKit/UIProcess/Extensions/Cocoa/API/WebExtensionContextAPIRuntimeCocoa.mm M Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionContextCocoa.mm M Source/WebKit/UIProcess/Extensions/WebExtensionContext.cpp M Source/WebKit/UIProcess/Extensions/WebExtensionContext.h M Source/WebKit/WebProcess/Extensions/API/Cocoa/WebExtensionAPIRuntimeCocoa.mm M Source/WebKit/WebProcess/Extensions/Cocoa/WebExtensionContextProxyCocoa.mm M Source/WebKit/WebProcess/Extensions/Cocoa/WebExtensionControllerProxyCocoa.mm M Source/WebKit/WebProcess/Extensions/WebExtensionContextProxy.cpp M Source/WebKit/WebProcess/Extensions/WebExtensionContextProxy.h M Source/WebKit/WebProcess/Extensions/WebExtensionContextProxy.messages.in M Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionAPIDevTools.mm Log Message: --- EmberJS Web Extension fails to detect Ember application. https://webkit.org/b/269816 rdar://problem/123338506 Reviewed by Brian Weinstein. DevTools extensions need to use a custom content world type, that is similar to Main but distinct since it has less APIs. Previously we were just using the ContentScript world type to limit the APIs. This prevented message passing from being delivered properly to the Inspector pages. We also need the pass the Inspector page, tab, and window identifiers to the web process so browser.devtools.inspectedWindow.tabId returns the correct value. * Source/WebKit/Shared/Extensions/WebExtensionContentWorldType.h: (WebKit::toDebugString): * Source/WebKit/Shared/Extensions/WebExtensionContentWorldType.serialization.in: * Source/WebKit/Shared/Extensions/WebExtensionContextParameters.h: * Source/WebKit/Shared/Extensions/WebExtensionContextParameters.serialization.in: * Source/WebKit/UIProcess/Extensions/Cocoa/API/WebExtensionContextAPIPortCocoa.mm: (WebKit::WebExtensionContext::portPostMessage): (WebKit::WebExtensionContext::firePortDisconnectEventIfNeeded): * Source/WebKit/UIProcess/Extensions/Cocoa/API/WebExtensionContextAPIRuntimeCocoa.mm: (WebKit::WebExtensionContext::runtimeSendMessage): * Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionContextCocoa.mm: (WebKit::WebExtensionContext::inspectorPageIdentifiers const): (WebKit::WebExtensionContext::wakeUpBackgroundContentIfNecessaryToFireEvents): (WebKit::WebExtensionContext::loadInspectorBackgroundPage): * Source/WebKit/UIProcess/Extensions/WebExtensionContext.cpp: (WebKit::WebExtensionContext::parameters const): (WebKit::WebExtensionContext::pageListensForEvent const): (WebKit::WebExtensionContext::processes const): * Source/WebKit/UIProcess/Extensions/WebExtensionContext.h: (WebKit::WebExtensionContext::processes const): (WebKit::WebExtensionContext::sendToProcessesForEvents const): * Source/WebKit/WebProcess/Extensions/API/Cocoa/WebExtensionAPIRuntimeCocoa.mm: (WebKit::WebExtensionContextProxy::dispatchRuntimeMessageEvent): (WebKit::WebExtensionContextProxy::dispatchRuntimeConnectEvent): * Source/WebKit/WebProcess/Extensions/Cocoa/WebExtensionContextProxyCocoa.mm: (WebKit::WebExtensionContextProxy::toDOMWrapperWorld): * Source/WebKit/WebProcess/Extensions/Cocoa/WebExtensionControllerProxyCocoa.mm: (WebKit::WebExtensionControllerProxy::globalObjectIsAvailableForFrame): * Source/WebKit/WebProcess/Extensions/WebExtensionContextProxy.cpp: (WebKit::WebExtensionContextProxy::tabIdentifier const): (WebKit::WebExtensionContextProxy::addInspectorPage): (WebKit::WebExtensionContextProxy::addInspectorPageIdentifier): * Source/WebKit/WebProcess/Extensions/WebExtensionContextProxy.h: * Source/WebKit/WebProcess/Extensions/WebExtensionContextProxy.messages.in: * Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionAPIDevTools.mm: (TEST(WKWebExtensionAPIDevTools, MessagePassingToBackground)): Added. (TEST(WKWebExtensionAPIDevTools, MessagePassingFromPanelToBackground)): Added. (TEST(WKWebExtensionAPIDevTools, MessagePassingFromPanelToDevToolsBackground)): Added. (TEST(WKWebExtensionAPIDevTools, PortMessagePassingToBackground)): Added. (TEST(WKWebExtensionAPIDevTools, PortMessagePassingFromPanelToBackground)): Added. (TEST(WKWebExtensionAPIDevTools, PortMessagePassingFromPanelToDevToolsBackground)): Added. Canonical link: https://commits.webkit.org/275135@main To unsubscribe from these emails, change
[webkit-changes] [WebKit/WebKit] 9bad54: [Gardening]: NEW TEST (275033@main): [ macOS ] imp...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 9bad54a910ec17f678ea1d94fb05126e2f72abf1 https://github.com/WebKit/WebKit/commit/9bad54a910ec17f678ea1d94fb05126e2f72abf1 Author: Marta Darbinyan Date: 2024-02-21 (Wed, 21 Feb 2024) Changed paths: M LayoutTests/platform/mac/TestExpectations Log Message: --- [Gardening]: NEW TEST (275033@main): [ macOS ] imported/w3c/web-platform-tests/webrtc-extensions/transfer-datachannel-service-worker.https.html is a flaky failure (EWS) https://bugs.webkit.org/show_bug.cgi?id=269873 rdar://123405808 Unreviewed test gardening. Adding test expectation * LayoutTests/platform/mac/TestExpectations: Canonical link: https://commits.webkit.org/275134@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 6b339d: REGRESSION (275053@main): Crash in PlaybackSession...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 6b339dfcfdc1c7c57144bd1291ecdd58077364d6 https://github.com/WebKit/WebKit/commit/6b339dfcfdc1c7c57144bd1291ecdd58077364d6 Author: Andy Estes Date: 2024-02-21 (Wed, 21 Feb 2024) Changed paths: M Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml Log Message: --- REGRESSION (275053@main): Crash in PlaybackSessionInterfaceLMK::seekableRangesChanged when entering fullscreen https://bugs.webkit.org/show_bug.cgi?id=269868 rdar://123397849 Reviewed by Tim Horton. Due to issues in Apple's Production build, libWebKitSwift.dylib may be missing at runtime when entering fullscreen on visionOS. Until those issues are resolved, disable the LinearMediaPlayer feature at runtime. * Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml: Canonical link: https://commits.webkit.org/275133@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] e1cab3: Generate serialization of NSURLCredential
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: e1cab360c28ad35642b685bd17a9d3db6a052121 https://github.com/WebKit/WebKit/commit/e1cab360c28ad35642b685bd17a9d3db6a052121 Author: Alex Christensen Date: 2024-02-21 (Wed, 21 Feb 2024) Changed paths: M Source/WTF/wtf/PlatformHave.h M Source/WebKit/DerivedSources-input.xcfilelist M Source/WebKit/DerivedSources.make M Source/WebKit/Shared/Cocoa/ArgumentCodersCocoa.mm A Source/WebKit/Shared/Cocoa/CoreIPCNSURLCredential.h A Source/WebKit/Shared/Cocoa/CoreIPCNSURLCredential.mm A Source/WebKit/Shared/Cocoa/CoreIPCNSURLCredential.serialization.in M Source/WebKit/WebKit.xcodeproj/project.pbxproj M Tools/TestWebKitAPI/Tests/IPC/IPCSerialization.mm Log Message: --- Generate serialization of NSURLCredential https://bugs.webkit.org/show_bug.cgi?id=269651 Reviewed by Pascoe. There's still work to be done to expose exactly what this dictionary should look like in SerializedTypeInfo.mm somehow, but at least we're not using SecureCoding any more. This is a baby step in the right direction. This works on all platforms except macOS Monterey, which doesn't use _enableStrictSecureDecodingMode for all types anyways, so on Monterey only, just use NSKeyedUnarchiver. Monterey also doesn't have the ability to serialize NSURLCredentials with identities in them. The Monterey code will be removed soon. * Source/WTF/wtf/PlatformHave.h: * Source/WebKit/DerivedSources-input.xcfilelist: * Source/WebKit/DerivedSources.make: * Source/WebKit/Shared/Cocoa/ArgumentCodersCocoa.mm: (IPC::encodeObjectDirectly>): (IPC::shouldEnableStrictMode): * Source/WebKit/Shared/Cocoa/CoreIPCNSURLCredential.h: Added. (WebKit::CoreIPCNSURLCredential::CoreIPCNSURLCredential): * Source/WebKit/Shared/Cocoa/CoreIPCNSURLCredential.mm: Added. (WebKit::CoreIPCNSURLCredential::CoreIPCNSURLCredential): (WebKit::CoreIPCNSURLCredential::toID const): * Source/WebKit/Shared/Cocoa/CoreIPCNSURLCredential.serialization.in: Added. * Source/WebKit/WebKit.xcodeproj/project.pbxproj: * Tools/TestWebKitAPI/Tests/IPC/IPCSerialization.mm: (NSURLCredentialTesting_isEqual): (operator==): (TEST): Canonical link: https://commits.webkit.org/275132@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 1c84cd: [JSC] Enhance enumerator_has_own_property pattern ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 1c84cd6c970271eabe238a7e4eff9adced5614ce https://github.com/WebKit/WebKit/commit/1c84cd6c970271eabe238a7e4eff9adced5614ce Author: Yusuke Suzuki Date: 2024-02-21 (Wed, 21 Feb 2024) Changed paths: A JSTests/stress/for-in-has-own-property-complex.js M Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp M Source/JavaScriptCore/bytecompiler/BytecodeGenerator.h M Source/JavaScriptCore/bytecompiler/NodesCodegen.cpp M Source/JavaScriptCore/parser/Nodes.h Log Message: --- [JSC] Enhance enumerator_has_own_property pattern detection https://bugs.webkit.org/show_bug.cgi?id=269834 rdar://123362273 Reviewed by Keith Miller and Justin Michaud. This patch extends enumerator_has_own_property pattern matching detection more, aligned to relatively newer JS minifier behavior. * Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp: (JSC::BytecodeGenerator::tryResolveVariable): * Source/JavaScriptCore/bytecompiler/BytecodeGenerator.h: * Source/JavaScriptCore/bytecompiler/NodesCodegen.cpp: (JSC::ForInNode::emitBytecode): * Source/JavaScriptCore/parser/Nodes.h: Canonical link: https://commits.webkit.org/275131@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 0b437b: "Activate Cash Back" button doesn’t work for Rakuten
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 0b437b3e5592d6dad2b75d437eaa7ec5dff1e073 https://github.com/WebKit/WebKit/commit/0b437b3e5592d6dad2b75d437eaa7ec5dff1e073 Author: Kiara Rose Date: 2024-02-21 (Wed, 21 Feb 2024) Changed paths: M Source/WebKit/WebProcess/Extensions/API/Cocoa/WebExtensionAPIStorageAreaCocoa.mm M Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionAPIStorage.mm Log Message: --- "Activate Cash Back" button doesn’t work for Rakuten https://bugs.webkit.org/show_bug.cgi?id=269854 rdar://123336734 Reviewed by Brian Weinstein and Timothy Hatcher. Only storageArea.sync has a maximum item size limit. In the logs: "Exception thrown: Invalid call to storageArea.set(). ... value is invalid, because exceeded maximum size for a single item." * Source/WebKit/WebProcess/Extensions/API/Cocoa/WebExtensionAPIStorageAreaCocoa.mm: (WebKit::WebExtensionAPIStorageArea::set): Canonical link: https://commits.webkit.org/275130@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 97ccc5: [Curl] Support local host aliases for WPT testing
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 97ccc52dcedaa11df94a28245f6d1bd4c9c16810 https://github.com/WebKit/WebKit/commit/97ccc52dcedaa11df94a28245f6d1bd4c9c16810 Author: Kenji Shukuwa Date: 2024-02-21 (Wed, 21 Feb 2024) Changed paths: A LayoutTests/platform/wincairo/imported/w3c/web-platform-tests/import-maps/bare-specifiers.sub-expected.txt A LayoutTests/platform/wincairo/imported/w3c/web-platform-tests/import-maps/csp/applied-to-target-dynamic.sub-expected.txt A LayoutTests/platform/wincairo/imported/w3c/web-platform-tests/import-maps/csp/applied-to-target.sub-expected.txt A LayoutTests/platform/wincairo/imported/w3c/web-platform-tests/import-maps/data-url-specifiers.sub-expected.txt A LayoutTests/platform/wincairo/imported/w3c/web-platform-tests/import-maps/http-url-like-specifiers.sub-expected.txt A LayoutTests/platform/wincairo/imported/w3c/web-platform-tests/loading/preloader-css-import-no-quote.tentative-expected.txt A LayoutTests/platform/wincairo/imported/w3c/web-platform-tests/loading/preloader-css-import-no-semicolon.tentative-expected.txt A LayoutTests/platform/wincairo/imported/w3c/web-platform-tests/loading/preloader-css-import-no-space.tentative-expected.txt A LayoutTests/platform/wincairo/imported/w3c/web-platform-tests/resource-timing/resource_TAO_match_origin-expected.txt A LayoutTests/platform/wincairo/imported/w3c/web-platform-tests/trusted-types/default-policy-expected.txt A LayoutTests/platform/wincairo/imported/w3c/web-platform-tests/trusted-types/default-policy-report-only-expected.txt A LayoutTests/platform/wincairo/imported/w3c/web-platform-tests/webtransport/constructor.https.any-expected.txt M Source/WebCore/platform/network/curl/CurlContext.cpp M Source/WebCore/platform/network/curl/CurlContext.h M Source/WebCore/platform/network/curl/CurlRequest.cpp M Source/WebCore/platform/network/curl/CurlRequest.h M Source/WebCore/platform/network/curl/CurlStream.cpp M Source/WebCore/platform/network/curl/CurlStream.h M Source/WebCore/platform/network/curl/CurlStreamScheduler.cpp M Source/WebCore/platform/network/curl/CurlStreamScheduler.h M Source/WebKit/NetworkProcess/curl/NetworkDataTaskCurl.cpp M Source/WebKit/NetworkProcess/curl/WebSocketTaskCurl.cpp M Tools/Scripts/webkitpy/port/win.py Log Message: --- [Curl] Support local host aliases for WPT testing https://bugs.webkit.org/show_bug.cgi?id=269822 Reviewed by Fujii Hironori. GTK port can run WPT tests against the web-platform.test domains after bug 243428. The curl port also supports local host aliases added in this bug for WPT testing. * LayoutTests/platform/wincairo/imported/w3c/web-platform-tests/import-maps/bare-specifiers.sub-expected.txt: Added. * LayoutTests/platform/wincairo/imported/w3c/web-platform-tests/import-maps/csp/applied-to-target-dynamic.sub-expected.txt: Added. * LayoutTests/platform/wincairo/imported/w3c/web-platform-tests/import-maps/csp/applied-to-target.sub-expected.txt: Added. * LayoutTests/platform/wincairo/imported/w3c/web-platform-tests/import-maps/data-url-specifiers.sub-expected.txt: Added. * LayoutTests/platform/wincairo/imported/w3c/web-platform-tests/import-maps/http-url-like-specifiers.sub-expected.txt: Added. * LayoutTests/platform/wincairo/imported/w3c/web-platform-tests/loading/preloader-css-import-no-quote.tentative-expected.txt: Added. * LayoutTests/platform/wincairo/imported/w3c/web-platform-tests/loading/preloader-css-import-no-semicolon.tentative-expected.txt: Added. * LayoutTests/platform/wincairo/imported/w3c/web-platform-tests/loading/preloader-css-import-no-space.tentative-expected.txt: Added. * LayoutTests/platform/wincairo/imported/w3c/web-platform-tests/resource-timing/resource_TAO_match_origin-expected.txt: Added. * LayoutTests/platform/wincairo/imported/w3c/web-platform-tests/trusted-types/default-policy-expected.txt: Added. * LayoutTests/platform/wincairo/imported/w3c/web-platform-tests/trusted-types/default-policy-report-only-expected.txt: Added. * LayoutTests/platform/wincairo/imported/w3c/web-platform-tests/webtransport/constructor.https.any-expected.txt: Added. * Source/WebCore/platform/network/curl/CurlContext.cpp: (WebCore::CurlHandle::setURL): * Source/WebCore/platform/network/curl/CurlContext.h: * Source/WebCore/platform/network/curl/CurlRequest.cpp: (WebCore::CurlRequest::setupTransfer): * Source/WebCore/platform/network/curl/CurlRequest.h: (WebCore::CurlRequest::enableLocalhostAlias): * Source/WebCore/platform/network/curl/CurlStream.cpp: (WebCore::CurlStream::CurlStream): * Source/WebCore/platform/network/curl/CurlStream.h: (WebCore::CurlStream::create): * Source/WebCore/platform/network/curl/CurlStreamScheduler.cpp: (WebCore::CurlStreamScheduler::createStream): * Source/WebCore/platform/network/curl/CurlStreamScheduler.h: * Source/WebKit/NetworkProcess/curl/NetworkDataTas
[webkit-changes] [WebKit/WebKit] e710ca: Speculative WebKitSwift install_name fix
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: e710caf302f8c9c1b3e0a73302fc13ec4a5bb5e0 https://github.com/WebKit/WebKit/commit/e710caf302f8c9c1b3e0a73302fc13ec4a5bb5e0 Author: Russell Epstein Date: 2024-02-21 (Wed, 21 Feb 2024) Changed paths: M Source/WebKit/Configurations/WebKitSwift.xcconfig Log Message: --- Speculative WebKitSwift install_name fix rdar://123397704 Reviewed by Andy Estes. * Source/WebKit/Configurations/WebKitSwift.xcconfig: Canonical link: https://commits.webkit.org/275128@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] a3e668: [WinCairo] Unreviewed test gardening
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: a3e6686eaa43479bc8121998202215a09320cfdf https://github.com/WebKit/WebKit/commit/a3e6686eaa43479bc8121998202215a09320cfdf Author: Fujii Hironori Date: 2024-02-21 (Wed, 21 Feb 2024) Changed paths: M LayoutTests/platform/wincairo/TestExpectations Log Message: --- [WinCairo] Unreviewed test gardening * LayoutTests/platform/wincairo/TestExpectations: Canonical link: https://commits.webkit.org/275127@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] ce1ce9: GPU resources in the WebContent process should be ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: ce1ce902abaaa9379ae1b79392cee619e0220ff7 https://github.com/WebKit/WebKit/commit/ce1ce902abaaa9379ae1b79392cee619e0220ff7 Author: Per Arne Vollan Date: 2024-02-21 (Wed, 21 Feb 2024) Changed paths: M Source/WTF/wtf/PlatformEnableCocoa.h M Source/WebKit/WebProcess/com.apple.WebProcess.sb.in Log Message: --- GPU resources in the WebContent process should be accessible in some configurations https://bugs.webkit.org/show_bug.cgi?id=269851 rdar://123356564 Reviewed by Brent Fulgham. For some configurations, we still need to have access to GPU resources in the WebContent process. * Source/WTF/wtf/PlatformEnableCocoa.h: * Source/WebKit/WebProcess/com.apple.WebProcess.sb.in: Canonical link: https://commits.webkit.org/275126@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 8195fa: Regression: Mac Buddy crashes after sign in
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 8195fa48866243eab439676fdb43c25e0b65e5f6 https://github.com/WebKit/WebKit/commit/8195fa48866243eab439676fdb43c25e0b65e5f6 Author: Chris Dumez Date: 2024-02-21 (Wed, 21 Feb 2024) Changed paths: M Source/WebCore/css/query/GenericMediaQueryTypes.h M Source/WebCore/dom/Document.h M Source/WebCore/dom/EventPath.cpp M Source/WebCore/dom/Node.h M Source/WebCore/dom/ShadowRoot.cpp M Source/WebCore/dom/ShadowRoot.h M Source/WebCore/dom/ShouldNotFireMutationEventsScope.h M Source/WebCore/dom/TreeScope.cpp M Source/WebCore/dom/TreeScope.h M Source/WebCore/html/parser/HTMLDocumentParserFastPath.cpp M Source/WebCore/rendering/svg/SVGResources.cpp M Source/WebCore/style/StyleScope.cpp M Source/WebCore/style/StyleScope.h M Source/WebCore/svg/SVGElement.cpp M Source/WebCore/svg/SVGTextPathElement.cpp Log Message: --- Regression: Mac Buddy crashes after sign in https://bugs.webkit.org/show_bug.cgi?id=269824 rdar://123037271 Reviewed by Ryosuke Niwa and Brent Fulgham. The crash seems to be caused by a CheckedPtr / CheckedRef pointing to a Document upon destruction. We've stopped using CheckedPtr / CheckedRef for Nodes already but it was still in use for Document. To address the issue, revert the CheckedPtr / CheckedRef adoption for Document in order to get back in a good state. In a follow-up, we should work on adopting more smart pointers (ideally WeakPtr / WeakRef). * Source/WebCore/css/query/GenericMediaQueryTypes.h: * Source/WebCore/dom/Document.h: * Source/WebCore/dom/EventPath.cpp: (WebCore::EventPath::setRelatedTarget): (WebCore::RelatedNodeRetargeter::RelatedNodeRetargeter): * Source/WebCore/dom/Node.h: * Source/WebCore/dom/ShadowRoot.cpp: * Source/WebCore/dom/ShadowRoot.h: * Source/WebCore/dom/ShouldNotFireMutationEventsScope.h: * Source/WebCore/dom/TreeScope.cpp: (WebCore::TreeScope::ref const): (WebCore::TreeScope::deref const): (WebCore::TreeScope::incrementPtrCount const): Deleted. (WebCore::TreeScope::decrementPtrCount const): Deleted. * Source/WebCore/dom/TreeScope.h: * Source/WebCore/html/parser/HTMLDocumentParserFastPath.cpp: (WebCore::HTMLFastPathParser::parseChildren): (WebCore::HTMLFastPathParser::parseElementAfterTagName): * Source/WebCore/rendering/svg/SVGResources.cpp: (WebCore::SVGResources::buildCachedResources): * Source/WebCore/style/StyleScope.cpp: (WebCore::Style::Scope::createDocumentResolver): (WebCore::Style::Scope::releaseMemory): (WebCore::Style::Scope::didRemovePendingStylesheet): (WebCore::Style::Scope::addStyleSheetCandidateNode): (WebCore::Style::Scope::collectActiveStyleSheets): (WebCore::Style::Scope::updateActiveStyleSheets): (WebCore::Style::Scope::invalidateStyleAfterStyleSheetChange): (WebCore::Style::Scope::activeStyleSheetsForInspector): (WebCore::Style::Scope::flushPendingDescendantUpdates): (WebCore::Style::Scope::scheduleUpdate): (WebCore::Style::Scope::collectResolverScopes): (WebCore::Style::Scope::didChangeStyleSheetEnvironment): (WebCore::Style::Scope::didChangeViewportSize): (WebCore::Style::Scope::invalidateMatchedDeclarationsCache): (WebCore::Style::Scope::pendingUpdateTimerFired): (WebCore::Style::Scope::documentScope): (WebCore::Style::Scope::updateQueryContainerState): * Source/WebCore/style/StyleScope.h: * Source/WebCore/svg/SVGElement.cpp: (WebCore::SVGElement::buildPendingResourcesIfNeeded): * Source/WebCore/svg/SVGTextPathElement.cpp: (WebCore::SVGTextPathElement::buildPendingResource): Canonical link: https://commits.webkit.org/275125@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 9b530e: Unreviewed, reverting 275084@main.
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 9b530e95cc763506eb74601a08dbe4cdf971a77f https://github.com/WebKit/WebKit/commit/9b530e95cc763506eb74601a08dbe4cdf971a77f Author: Commit Queue Date: 2024-02-21 (Wed, 21 Feb 2024) Changed paths: R LayoutTests/http/tests/paymentrequest/ApplePayModifier-disbursementPaymentRequest.https-expected.txt R LayoutTests/http/tests/paymentrequest/ApplePayModifier-disbursementPaymentRequest.https.html M LayoutTests/platform/ios-wk2/TestExpectations M LayoutTests/platform/mac-wk2/TestExpectations M Source/WTF/wtf/PlatformEnableCocoa.h M Source/WebCore/DerivedSources-input.xcfilelist M Source/WebCore/DerivedSources-output.xcfilelist M Source/WebCore/DerivedSources.make M Source/WebCore/Modules/applepay/ApplePayDetailsUpdateBase.h M Source/WebCore/Modules/applepay/ApplePayDetailsUpdateBase.idl R Source/WebCore/Modules/applepay/ApplePayDisbursementPaymentRequest.h R Source/WebCore/Modules/applepay/ApplePayDisbursementPaymentRequest.idl M Source/WebCore/Modules/applepay/ApplePayFeature.h M Source/WebCore/Modules/applepay/ApplePayFeature.idl M Source/WebCore/Modules/applepay/ApplePayLineItem.h M Source/WebCore/Modules/applepay/ApplePayLineItem.idl M Source/WebCore/Modules/applepay/ApplePayMerchantCapability.cpp M Source/WebCore/Modules/applepay/ApplePayMerchantCapability.h M Source/WebCore/Modules/applepay/ApplePayMerchantCapability.idl M Source/WebCore/Modules/applepay/ApplePayPaymentRequest.h M Source/WebCore/Modules/applepay/ApplePayPaymentRequest.idl M Source/WebCore/Modules/applepay/ApplePaySession.cpp M Source/WebCore/Modules/applepay/ApplePaySessionPaymentRequest.h M Source/WebCore/Modules/applepay/PaymentSummaryItems.h M Source/WebCore/Modules/applepay/cocoa/PaymentSummaryItemsCocoa.mm M Source/WebCore/Modules/applepay/paymentrequest/ApplePayModifier.h M Source/WebCore/Modules/applepay/paymentrequest/ApplePayModifier.idl M Source/WebCore/Modules/applepay/paymentrequest/ApplePayPaymentHandler.cpp M Source/WebCore/PAL/pal/cocoa/PassKitSoftLink.h M Source/WebCore/PAL/pal/cocoa/PassKitSoftLink.mm M Source/WebCore/PAL/pal/spi/cocoa/PassKitSPI.h M Source/WebCore/SourcesCocoa.txt M Source/WebCore/WebCore.xcodeproj/project.pbxproj M Source/WebCore/testing/MockPaymentCoordinator.cpp M Source/WebCore/testing/MockPaymentCoordinator.h M Source/WebCore/testing/MockPaymentCoordinator.idl M Source/WebKit/Platform/cocoa/PaymentAuthorizationPresenter.mm R Source/WebKit/Shared/ApplePay/DisbursementPaymentRequest.h R Source/WebKit/Shared/ApplePay/cocoa/DisbursementPaymentRequestCocoa.mm M Source/WebKit/Shared/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.h M Source/WebKit/Shared/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.mm M Source/WebKit/Shared/ApplePay/ios/WebPaymentCoordinatorProxyIOS.mm M Source/WebKit/Shared/ApplePay/mac/WebPaymentCoordinatorProxyMac.mm M Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in M Source/WebKit/SourcesCocoa.txt M Source/WebKit/WebKit.xcodeproj/project.pbxproj Log Message: --- Unreviewed, reverting 275084@main. https://bugs.webkit.org/show_bug.cgi?id=269861 Broke internal builds Reverted changeset: "[Apple Pay] Support for PKDisbursementRequest on WebKit" https://bugs.webkit.org/show_bug.cgi?id=267428 https://commits.webkit.org/275084@main Canonical link: https://commits.webkit.org/275124@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] a55bd5: [UnifiedPDF] Crash when scrolling after a swipe ba...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: a55bd5c3df1c8395a4ca3a81c88b176ec8b3b664 https://github.com/WebKit/WebKit/commit/a55bd5c3df1c8395a4ca3a81c88b176ec8b3b664 Author: Simon Fraser Date: 2024-02-21 (Wed, 21 Feb 2024) Changed paths: M Source/WebCore/plugins/PluginViewBase.h M Source/WebCore/rendering/RenderEmbeddedObject.cpp M Source/WebCore/rendering/RenderEmbeddedObject.h M Source/WebCore/rendering/RenderLayerCompositor.cpp M Source/WebKit/WebProcess/Plugins/PDF/PDFPluginBase.h M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.h M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm M Source/WebKit/WebProcess/Plugins/PluginView.cpp M Source/WebKit/WebProcess/Plugins/PluginView.h Log Message: --- [UnifiedPDF] Crash when scrolling after a swipe back from an external link follow https://bugs.webkit.org/show_bug.cgi?id=269244 rdar://122835175 Reviewed by Tim Horton. Having calls to `UnifiedPDFPlugin::scrollingNodeID()` lazily create the scrolling tree node is problematic, since this can happen early (under `UnifiedPDFPlugin::updateOverflowControlsLayers()`), which causes the ScrollingCoordinator to create an unparented node, which is later replaced by a different node with the same ID, causing us to lose the layer registrations. Fix by adding an explicit `willAttachScrollingNode()` which is called by `RenderLayerCompositor::attachWidgetContentLayers()`, and have it create the node, and done the necessary layer and geometry updates on the node. * Source/WebCore/plugins/PluginViewBase.h: (WebCore::PluginViewBase::willAttachScrollingNode): * Source/WebCore/rendering/RenderEmbeddedObject.cpp: (WebCore::RenderEmbeddedObject::willAttachScrollingNode): * Source/WebCore/rendering/RenderEmbeddedObject.h: * Source/WebCore/rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::attachWidgetContentLayers): * Source/WebKit/WebProcess/Plugins/PDF/PDFPluginBase.h: (WebKit::PDFPluginBase::willAttachScrollingNode): * Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.h: * Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm: (WebKit::UnifiedPDFPlugin::willAttachScrollingNode): (WebKit::UnifiedPDFPlugin::scrollingNodeID const): (WebKit::UnifiedPDFPlugin::createScrollingNodeIfNecessary): * Source/WebKit/WebProcess/Plugins/PluginView.cpp: (WebKit::PluginView::willAttachScrollingNode): * Source/WebKit/WebProcess/Plugins/PluginView.h: Canonical link: https://commits.webkit.org/275123@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 637fd1: Fill in/fix macros in WebKitTargetConditionals.xcc...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 637fd114532ab3db42ffaf84888b26843e8231b9 https://github.com/WebKit/WebKit/commit/637fd114532ab3db42ffaf84888b26843e8231b9 Author: David Kilzer Date: 2024-02-21 (Wed, 21 Feb 2024) Changed paths: M Configurations/WebKitTargetConditionals.xcconfig Log Message: --- Fill in/fix macros in WebKitTargetConditionals.xcconfig https://bugs.webkit.org/show_bug.cgi?id=269799 Reviewed by Alexey Proskuryakov. * Configurations/WebKitTargetConditionals.xcconfig: - Add support for later versions. - Fix multi-version macOS macros which were missing versions in macro names, had incorrect values, or where definitions were just missing. - Remove old unsupported versions. (More clean-up is needed in project *.xcconfig files to remove additional unsupported versions.) Canonical link: https://commits.webkit.org/275122@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] ce4726: [view-transitions] Support style inheritance in th...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: ce47267f2d5ecaa5aefd2346a8cfa59b7aaeb08a https://github.com/WebKit/WebKit/commit/ce47267f2d5ecaa5aefd2346a8cfa59b7aaeb08a Author: Tim Nguyen Date: 2024-02-21 (Wed, 21 Feb 2024) Changed paths: M LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/style-inheritance-expected.txt M Source/WebCore/dom/Element.cpp M Source/WebCore/rendering/style/RenderStyleSetters.h M Source/WebCore/style/StyleTreeResolver.cpp Log Message: --- [view-transitions] Support style inheritance in the pseudo-element tree https://bugs.webkit.org/show_bug.cgi?id=269808 rdar://123331760 Reviewed by Anne van Kesteren. The style inheritance must follow the pseudo-element tree structure. This allows the different `inherit` declarations in the `viewTransitions.css` UA stylesheet to work. This is also ergonomic for developers since they can just set the animation-duration once and have it cascade down the pseudo-element tree. Also fix the cache to actually store the named view transition style when resolving, otherwise `TreeResolver::makeResolutionContextForPseudoElement` can't fetch it. * LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/style-inheritance-expected.txt: Rebaselined test. * Source/WebCore/dom/Element.cpp: (WebCore::Element::resolvePseudoElementStyle): * Source/WebCore/rendering/style/RenderStyleSetters.h: (WebCore::RenderStyle::setPseudoElementNameArgument): * Source/WebCore/style/StyleTreeResolver.cpp: (WebCore::Style::TreeResolver::resolveElement): (WebCore::Style::TreeResolver::makeResolutionContextForPseudoElement): Canonical link: https://commits.webkit.org/275121@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 71b8fb: REGRESSION(273742@main): LinkedIn "…" menu does no...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 71b8fba1401e6e512316802f0973647a5f6470a3 https://github.com/WebKit/WebKit/commit/71b8fba1401e6e512316802f0973647a5f6470a3 Author: Tim Nguyen Date: 2024-02-21 (Wed, 21 Feb 2024) Changed paths: M LayoutTests/imported/w3c/resources/import-expectations.json A LayoutTests/imported/w3c/web-platform-tests/css/CSS2/visufx/animation/visibility-interpolation-expected.txt A LayoutTests/imported/w3c/web-platform-tests/css/CSS2/visufx/animation/visibility-interpolation.html M Source/WebCore/animation/CSSPropertyAnimation.cpp Log Message: --- REGRESSION(273742@main): LinkedIn "…" menu does not populate on click https://bugs.webkit.org/show_bug.cgi?id=269848 rdar://123264559 Reviewed by Cameron McCormack. The menu on LinkedIn transitions the `visibility` CSS property. Do a partial revert of 273742@main to revert only the animation wrapper change for the `visibility` property, since it has caused changes that are timing sensitive for the site. Imported WPT that also regressed along with 273742@main to avoid regressing this again. * LayoutTests/imported/w3c/resources/import-expectations.json: * LayoutTests/imported/w3c/web-platform-tests/css/CSS2/visufx/animation/visibility-interpolation-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/css/CSS2/visufx/animation/visibility-interpolation.html: Added. * Source/WebCore/animation/CSSPropertyAnimation.cpp: (WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap): Canonical link: https://commits.webkit.org/275120@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] ad3406: REGRESSION (LinearMediaPlayer): Start and end time...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: ad340677c00a4b4b6a299c93a6e18cd073b3f4e9 https://github.com/WebKit/WebKit/commit/ad340677c00a4b4b6a299c93a6e18cd073b3f4e9 Author: Andy Estes Date: 2024-02-21 (Wed, 21 Feb 2024) Changed paths: M Source/WebKit/Platform/ios/PlaybackSessionInterfaceLMK.mm Log Message: --- REGRESSION (LinearMediaPlayer): Start and end times are not displayed in the scrubber https://bugs.webkit.org/show_bug.cgi?id=269817 rdar://123339430 Reviewed by Jer Noble. WebKit needs to provide `remainingTime` to LinearMediaPlayer in order for start and end times to be computed in the scrubber. Computed remainingTime as duration - currentTime. * Source/WebKit/Platform/ios/PlaybackSessionInterfaceLMK.mm: (WebKit::PlaybackSessionInterfaceLMK::durationChanged): (WebKit::PlaybackSessionInterfaceLMK::currentTimeChanged): Canonical link: https://commits.webkit.org/275119@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 5240fc: [Clang] Unused parameter warnings in WebsiteDataSt...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 5240fc400e2fbee5e8c86c76e21706760ce15bd2 https://github.com/WebKit/WebKit/commit/5240fc400e2fbee5e8c86c76e21706760ce15bd2 Author: Philippe Normand Date: 2024-02-21 (Wed, 21 Feb 2024) Changed paths: M Source/WebKit/UIProcess/WebsiteData/WebsiteDataStoreClient.h Log Message: --- [Clang] Unused parameter warnings in WebsiteDataStoreClient.h https://bugs.webkit.org/show_bug.cgi?id=269841 Reviewed by Michael Catanzaro. Make the didExceedMemoryFootprintThreshold() unused parameters anonymous. * Source/WebKit/UIProcess/WebsiteData/WebsiteDataStoreClient.h: (WebKit::WebsiteDataStoreClient::didExceedMemoryFootprintThreshold): Canonical link: https://commits.webkit.org/275118@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] c443c9: Fix custom/pattern-userSpaceOnUse-userToBaseTransf...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: c443c971c715d48e5b9031f62c0926d05f27310c https://github.com/WebKit/WebKit/commit/c443c971c715d48e5b9031f62c0926d05f27310c Author: Rob Buis Date: 2024-02-21 (Wed, 21 Feb 2024) Changed paths: A LayoutTests/platform/glib/svg/custom/pattern-userSpaceOnUse-userToBaseTransform-with-viewBox-expected.txt A LayoutTests/platform/ios/svg/custom/pattern-userSpaceOnUse-userToBaseTransform-with-viewBox-expected.txt M LayoutTests/platform/mac-sonoma-wk2-lbse-text/TestExpectations A LayoutTests/platform/mac-sonoma-wk2-lbse-text/svg/custom/pattern-userSpaceOnUse-userToBaseTransform-with-viewBox-expected.txt A LayoutTests/svg/custom/pattern-userSpaceOnUse-userToBaseTransform-with-viewBox-expected.png A LayoutTests/svg/custom/pattern-userSpaceOnUse-userToBaseTransform-with-viewBox-expected.txt A LayoutTests/svg/custom/pattern-userSpaceOnUse-userToBaseTransform-with-viewBox.xhtml M Source/WebCore/rendering/RenderLayer.cpp M Source/WebCore/rendering/RenderLayer.h Log Message: --- Fix custom/pattern-userSpaceOnUse-userToBaseTransform.xhtml https://bugs.webkit.org/show_bug.cgi?id=269234 Reviewed by Nikolas Zimmermann. When determining RenderSVGRoot as root layer we also calculate any padding/border values as part of offsetFromAncestor, this means for patterns painting would be wrongly offset for pattern content. Instead, use the RenderSVGRoot, viewport as root layer which discards any border/padding for the pattern content painting. * LayoutTests/platform/glib/svg/custom/pattern-userSpaceOnUse-userToBaseTransform-with-viewBox-expected.txt: Added. * LayoutTests/platform/ios/svg/custom/pattern-userSpaceOnUse-userToBaseTransform-with-viewBox-expected.txt: Added. * LayoutTests/platform/mac-sonoma-wk2-lbse-text/TestExpectations: * LayoutTests/platform/mac-sonoma-wk2-lbse-text/svg/custom/pattern-userSpaceOnUse-userToBaseTransform-with-viewBox-expected.txt: Added. * LayoutTests/svg/custom/pattern-userSpaceOnUse-userToBaseTransform-with-viewBox-expected.png: Added. * LayoutTests/svg/custom/pattern-userSpaceOnUse-userToBaseTransform-with-viewBox-expected.txt: Added. * LayoutTests/svg/custom/pattern-userSpaceOnUse-userToBaseTransform-with-viewBox.xhtml: Added. * Source/WebCore/rendering/RenderLayer.cpp: (WebCore::RenderLayer::paintSVGResourceLayer): (WebCore::RenderLayer::enclosingSVGRootLayer const): Deleted. * Source/WebCore/rendering/RenderLayer.h: Canonical link: https://commits.webkit.org/275117@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 46245a: [Gardening]: REGRESSION (275091@main): [ MacOS iOS...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 46245abb306e9a0cc8527f1a08987f96f2074e3c https://github.com/WebKit/WebKit/commit/46245abb306e9a0cc8527f1a08987f96f2074e3c Author: Marta Darbinyan Date: 2024-02-21 (Wed, 21 Feb 2024) Changed paths: M LayoutTests/platform/ios/TestExpectations M LayoutTests/platform/mac/TestExpectations Log Message: --- [Gardening]: REGRESSION (275091@main): [ MacOS iOS ] imported/w3c/web-platform-tests/css/filter-effects/backdrop-filter-edge-behavior.html is a constant failure https://bugs.webkit.org/show_bug.cgi?id=269852 rdar://123389666 Unreviewed test gardening. Adding test expectation * LayoutTests/platform/ios/TestExpectations: * LayoutTests/platform/mac/TestExpectations: Canonical link: https://commits.webkit.org/275116@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] e68044: REGRESSION: Scrolling down and attempting to fulls...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: e680442311f32c01dbf7187d032fcde640e1a525 https://github.com/WebKit/WebKit/commit/e680442311f32c01dbf7187d032fcde640e1a525 Author: Aditya Keerthi Date: 2024-02-21 (Wed, 21 Feb 2024) Changed paths: M Source/WebCore/dom/Document.cpp M Source/WebCore/dom/FullscreenManager.cpp M Source/WebCore/dom/FullscreenManager.h M Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj A Tools/TestWebKitAPI/Tests/ios/FullscreenLayoutParameters.mm R Tools/TestWebKitAPI/Tests/ios/FullscreenOverriddenLayoutParameters.mm Log Message: --- REGRESSION: Scrolling down and attempting to fullscreen video on twitter.com displays the feed https://bugs.webkit.org/show_bug.cgi?id=269795 rdar://122981183 Reviewed by Jer Noble. In order for element fullscreen to behave correctly, sites rely on the following invariants: 1. "fullscreenchange" is fired before "resize". 2. The values of viewport properties during "fullscreenchange" match the fullscreen size. Twitter relies on (1), as they teardown the video player if "resize" occurs during the transition into fullscreen. 270199@main broke two things: 1. The ordering of "fullscreenchange" and "resize" events when entering fullscreen on iPadOS. 2. The values of viewport properties during the "fullscreenchange" event on visionOS. (1) went undetected for a long time, because at first, the effect was not this bug, but a crash, fixed in 273885@main. 272752@main fixed (2), but also introduced (1) on visionOS. To the invariant mentioned above is true, fix by adding logic which ensures "resize" is dispatched after "fullscreenchange". * Source/WebCore/dom/Document.cpp: (WebCore::Document::setNeedsDOMWindowResizeEvent): (WebCore::Document::setNeedsVisualViewportResize): * Source/WebCore/dom/FullscreenManager.cpp: (WebCore::FullscreenManager::setAnimatingFullscreen): (WebCore::FullscreenManager::addPendingScheduledResize): * Source/WebCore/dom/FullscreenManager.h: * Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: * Tools/TestWebKitAPI/Tests/ios/FullscreenLayoutParameters.mm: Renamed from Tools/TestWebKitAPI/Tests/ios/FullscreenOverriddenLayoutParameters.mm. (TestWebKitAPI::TEST): Canonical link: https://commits.webkit.org/275115@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] bcbd49: Remove ApplicationCache code from WebKit
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: bcbd49ce96d02e193abdc6f4cca95ddda775508c https://github.com/WebKit/WebKit/commit/bcbd49ce96d02e193abdc6f4cca95ddda775508c Author: Sihui Liu Date: 2024-02-21 (Wed, 21 Feb 2024) Changed paths: M Source/WebCore/loader/appcache/ApplicationCacheGroup.cpp M Source/WebCore/page/ChromeClient.h M Source/WebCore/page/Page.cpp M Source/WebCore/page/Page.h M Source/WebCore/testing/Internals.cpp M Source/WebKit/Shared/WebProcessDataStoreParameters.h M Source/WebKit/Shared/WebProcessDataStoreParameters.serialization.in M Source/WebKit/UIProcess/API/APIUIClient.h M Source/WebKit/UIProcess/API/C/WKContextConfigurationRef.cpp M Source/WebKit/UIProcess/API/C/WKContextConfigurationRef.h M Source/WebKit/UIProcess/Cocoa/UIDelegate.h M Source/WebKit/UIProcess/Cocoa/UIDelegate.mm M Source/WebKit/UIProcess/Launcher/glib/BubblewrapLauncher.cpp M Source/WebKit/UIProcess/WebPageProxy.cpp M Source/WebKit/UIProcess/WebPageProxy.h M Source/WebKit/UIProcess/WebPageProxy.messages.in M Source/WebKit/UIProcess/WebProcessPool.cpp M Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.cpp M Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.h M Source/WebKit/UIProcess/glib/WebProcessProxyGLib.cpp M Source/WebKit/WebProcess/InjectedBundle/API/APIInjectedBundlePageUIClient.h M Source/WebKit/WebProcess/InjectedBundle/API/c/WKBundlePage.cpp M Source/WebKit/WebProcess/InjectedBundle/API/c/WKBundlePagePrivate.h M Source/WebKit/WebProcess/InjectedBundle/InjectedBundle.cpp M Source/WebKit/WebProcess/InjectedBundle/InjectedBundlePageUIClient.cpp M Source/WebKit/WebProcess/InjectedBundle/InjectedBundlePageUIClient.h M Source/WebKit/WebProcess/Network/WebLoaderStrategy.cpp M Source/WebKit/WebProcess/Network/WebResourceLoader.cpp M Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.cpp M Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.h M Source/WebKit/WebProcess/WebPage/WebPage.cpp M Source/WebKit/WebProcess/WebProcess.cpp M Source/WebKit/WebProcess/WebProcess.h M Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm M Tools/TestWebKitAPI/Tests/WebKitCocoa/LocalStorageClear.mm M Tools/WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl M Tools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp M Tools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.h M Tools/WebKitTestRunner/InjectedBundle/TestRunner.cpp M Tools/WebKitTestRunner/InjectedBundle/TestRunner.h Log Message: --- Remove ApplicationCache code from WebKit https://bugs.webkit.org/show_bug.cgi?id=269629 rdar://123123740 Reviewed by Alex Christensen. Also, clean up AppCache data left on disk when WebsiteDataStore resolves directories. * Source/WebCore/loader/appcache/ApplicationCacheGroup.cpp: (WebCore::ApplicationCacheGroup::cacheForMainRequest): (WebCore::ApplicationCacheGroup::fallbackCacheForMainRequest): (WebCore::ApplicationCacheGroup::selectCache): (WebCore::ApplicationCacheGroup::didReachMaxAppCacheSize): (WebCore::ApplicationCacheGroup::recalculateAvailableSpaceInQuota): * Source/WebCore/page/ChromeClient.h: (WebCore::ChromeClient::reachedMaxAppCacheSize): (WebCore::ChromeClient::reachedApplicationCacheOriginQuota): * Source/WebCore/page/Page.cpp: (WebCore::Page::Page): * Source/WebCore/page/Page.h: (WebCore::Page::applicationCacheStorage): * Source/WebCore/testing/Internals.cpp: (WebCore::Internals::resetToConsistentState): (WebCore::Internals::setApplicationCacheOriginQuota): * Source/WebKit/Shared/WebProcessDataStoreParameters.h: * Source/WebKit/Shared/WebProcessDataStoreParameters.serialization.in: * Source/WebKit/UIProcess/API/APIUIClient.h: (API::UIClient::exceededDatabaseQuota): (API::UIClient::reachedApplicationCacheOriginQuota): Deleted. * Source/WebKit/UIProcess/API/C/WKContextConfigurationRef.cpp: (WKContextConfigurationCopyApplicationCacheDirectory): Deleted. (WKContextConfigurationSetApplicationCacheDirectory): Deleted. * Source/WebKit/UIProcess/API/C/WKContextConfigurationRef.h: * Source/WebKit/UIProcess/Cocoa/UIDelegate.h: * Source/WebKit/UIProcess/Cocoa/UIDelegate.mm: (WebKit::UIDelegate::UIClient::reachedApplicationCacheOriginQuota): Deleted. * Source/WebKit/UIProcess/Launcher/glib/BubblewrapLauncher.cpp: (WebKit::bubblewrapSpawn): * Source/WebKit/UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::reachedApplicationCacheOriginQuota): Deleted. * Source/WebKit/UIProcess/WebPageProxy.h: * Source/WebKit/UIProcess/WebPageProxy.messages.in: * Source/WebKit/UIProcess/WebProcessPool.cpp: (WebKit::WebProcessPool::webProcessDataStoreParameters): * Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.cpp: (WebKit::WebsiteDataStore::resolveDirectoriesIfNecessary): (WebKit::WebsiteDataStore::fetchDataAndApply): (WebKit::WebsiteDataStore::removeData): * Source/WebKit/UIProcess/WebsiteData/Webs
[webkit-changes] [WebKit/WebKit] 53a866: Remove the owner element null check in WebFrame::p...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 53a866856e702868d61f205922c1342ad2321e68 https://github.com/WebKit/WebKit/commit/53a866856e702868d61f205922c1342ad2321e68 Author: Charlie Wolfe Date: 2024-02-21 (Wed, 21 Feb 2024) Changed paths: M Source/WebKit/WebProcess/WebPage/WebFrame.cpp Log Message: --- Remove the owner element null check in WebFrame::parentFrame() https://bugs.webkit.org/show_bug.cgi?id=269829 rdar://123343035 Reviewed by Alex Christensen. I tried to fix a null pointer crash in 274274@main with Site Isolation enabled but didn’t remove this null check. If the parent frame is being hosted in another process the owner element will always be null. * Source/WebKit/WebProcess/WebPage/WebFrame.cpp: (WebKit::WebFrame::parentFrame const): Canonical link: https://commits.webkit.org/275113@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 3fc817: [WebGPU] Buffer index is not validated prior to me...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 3fc81749e677cd4cd339c89b7cf3145c2972ea59 https://github.com/WebKit/WebKit/commit/3fc81749e677cd4cd339c89b7cf3145c2972ea59 Author: Mike Wyrzykowski Date: 2024-02-21 (Wed, 21 Feb 2024) Changed paths: M Source/WebGPU/WGSL/GlobalVariableRewriter.cpp M Source/WebGPU/WGSL/GlobalVariableRewriter.h M Source/WebGPU/WGSL/WGSL.cpp Log Message: --- [WebGPU] Buffer index is not validated prior to metal compilation https://bugs.webkit.org/show_bug.cgi?id=269821 Reviewed by Dan Glastonbury. WGSL allows any buffer to be used, but we need to fail pipeline creation if the buffer index in the WGSL is too large. * Source/WebGPU/WGSL/GlobalVariableRewriter.cpp: (WGSL::RewriteGlobalVariables::RewriteGlobalVariables): (WGSL::RewriteGlobalVariables::run): (WGSL::buffersForStage): (WGSL::RewriteGlobalVariables::collectGlobals): (WGSL::rewriteGlobalVariables): * Source/WebGPU/WGSL/GlobalVariableRewriter.h: * Source/WebGPU/WGSL/WGSL.cpp: (WGSL::prepareImpl): Canonical link: https://commits.webkit.org/275112@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] e177e8: [git-webkit revert] Add relationships between issu...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: e177e893ff985e413c4991ebe1d79c2a4f704c5c https://github.com/WebKit/WebKit/commit/e177e893ff985e413c4991ebe1d79c2a4f704c5c Author: Brianna Fan Date: 2024-02-21 (Wed, 21 Feb 2024) Changed paths: M Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/revert.py M Tools/Scripts/libraries/webkitscmpy/webkitscmpy/test/revert_unittest.py Log Message: --- [git-webkit revert] Add relationships between issues when reverting https://bugs.webkit.org/show_bug.cgi?id=267276 rdar://120723182 Reviewed by Jonathan Bedard. Adds 'blocks' relationship between bugs and 'cause of' relationship between radars. This happens after reverting so the issues are only changed with a successful revert. * Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/revert.py: (Revert.get_commit_info): (Revert.get_issue_info): (Revert): (Revert.relate_issues): (Revert.main): Canonical link: https://commits.webkit.org/275111@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] b9e977: [Gardening]: REGRESSION (272891@main): [ MacOS ] c...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: b9e977a96d71cfabd3739ff4ec5fb2568cea36f7 https://github.com/WebKit/WebKit/commit/b9e977a96d71cfabd3739ff4ec5fb2568cea36f7 Author: Jay Stfleur Date: 2024-02-21 (Wed, 21 Feb 2024) Changed paths: M LayoutTests/platform/mac-wk1/TestExpectations Log Message: --- [Gardening]: REGRESSION (272891@main): [ MacOS ] css3/filters/effect-sepia.html is a constant failure https://bugs.webkit.org/show_bug.cgi?id=123320516 rdar://123320516 Unreviewed test gardening. Adding test expectation * LayoutTests/platform/mac-wk1/TestExpectations: Canonical link: https://commits.webkit.org/275110@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 680b21: REGRESSION(273637@main?): [ Sonoma+ wk2 Release ar...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 680b214f093a338118a9b7ddd2a480adb192b6aa https://github.com/WebKit/WebKit/commit/680b214f093a338118a9b7ddd2a480adb192b6aa Author: Youenn Fablet Date: 2024-02-21 (Wed, 21 Feb 2024) Changed paths: M LayoutTests/platform/mac-wk2/TestExpectations Log Message: --- REGRESSION(273637@main?): [ Sonoma+ wk2 Release arm64] 7 http/wpt/webcodecs (layout-tests) are constant text failures rdar://121889869 https://bugs.webkit.org/show_bug.cgi?id=268347 Unreviewed. * LayoutTests/platform/mac-wk2/TestExpectations: Remove expectations as tests are no longer failing. Canonical link: https://commits.webkit.org/275109@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 2dfb4e: [WK2] WebKit abandons compiled sandbox profiles
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 2dfb4e9da6fd0294f2899c73592c9d4647fe0d9f https://github.com/WebKit/WebKit/commit/2dfb4e9da6fd0294f2899c73592c9d4647fe0d9f Author: Chris Dumez Date: 2024-02-21 (Wed, 21 Feb 2024) Changed paths: M Source/WebKit/Shared/mac/AuxiliaryProcessMac.mm Log Message: --- [WK2] WebKit abandons compiled sandbox profiles https://bugs.webkit.org/show_bug.cgi?id=212177 rdar://54613619 Reviewed by Per Arne Vollan. WebKit generates new compiled sandbox profiles whenever sandbox profiles are updated or whenever webkit directories change (which is super common for WebKitTestRunner). Previous compiled sandbox profiles do not get deleted and therefore may accumulate. To address the issue, stop including the sandbox profile hash in the compiled sandbox's filename. We end up using: - com.apple.WebKit.Networking.Sandbox/CompiledSandbox instead of - com.apple.WebKit.Networking.Sandbox/CompiledSandbox+D2hn1Pn_lLcl-wJoTYvS45lVG6tqDaa3Lhp_AZPFesI This means that every time the sandbox profile gets updated, we'll just overwrite the previous version on disk. Therefore, compiled sandbox files will no longer accumulate. The one inconvenient I can think of is when running two different versions of Safari locally. Both instances will overwrite each other compiled sandbox files, which could impact process launch time when alternating between the 2 instances. However, this is not a super common use case and the impact is only a minor performance one, no correctness issue. * Source/WebKit/Shared/mac/AuxiliaryProcessMac.mm: (WebKit::sandboxFilePath): (WebKit::applySandbox): Canonical link: https://commits.webkit.org/275108@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 243190: REGRESSION (272891@main): [ MacOS ] css3/filters/e...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 24319063fa8e8162a2a7a87e118d8a4026ecee9e https://github.com/WebKit/WebKit/commit/24319063fa8e8162a2a7a87e118d8a4026ecee9e Author: Said Abou-Hallawa Date: 2024-02-21 (Wed, 21 Feb 2024) Changed paths: M LayoutTests/css3/filters/effect-sepia.html Log Message: --- REGRESSION (272891@main): [ MacOS ] css3/filters/effect-sepia.html is a constant failure https://bugs.webkit.org/show_bug.cgi?id=269797 rdar://123320516 [Filters] Unreviewed test gardening Increase the pixel tolerance of the test. * LayoutTests/css3/filters/effect-sepia.html: Canonical link: https://commits.webkit.org/275107@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 7d9a65: [Skia] Use Skia API when adding rounded rect to pa...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 7d9a6549eb1269c0d823ac95fe940f17f49a4b53 https://github.com/WebKit/WebKit/commit/7d9a6549eb1269c0d823ac95fe940f17f49a4b53 Author: Carlos Garcia Campos Date: 2024-02-21 (Wed, 21 Feb 2024) Changed paths: M Source/WebCore/platform/SourcesSkia.txt M Source/WebCore/platform/graphics/FloatRoundedRect.h A Source/WebCore/platform/graphics/skia/FloatRoundedRectSkia.cpp M Source/WebCore/platform/graphics/skia/GraphicsContextSkia.cpp M Source/WebCore/platform/graphics/skia/PathSkia.cpp Log Message: --- [Skia] Use Skia API when adding rounded rect to path and strategy is PreferNative https://bugs.webkit.org/show_bug.cgi?id=269845 Reviewed by Adrian Perez de Castro. Also add conversion operators between FloatRounrdedRect and SkRREct to remove duplicated code. * Source/WebCore/platform/SourcesSkia.txt: * Source/WebCore/platform/graphics/FloatRoundedRect.h: * Source/WebCore/platform/graphics/skia/FloatRoundedRectSkia.cpp: Added. (WebCore::FloatRoundedRect::FloatRoundedRect): (WebCore::FloatRoundedRect::operator SkRRect const): * Source/WebCore/platform/graphics/skia/GraphicsContextSkia.cpp: (WebCore::GraphicsContextSkia::fillRoundedRectImpl): (WebCore::GraphicsContextSkia::fillRectWithRoundedHole): * Source/WebCore/platform/graphics/skia/PathSkia.cpp: (WebCore::PathSkia::add): Canonical link: https://commits.webkit.org/275106@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] cc2256: [WGSL] Type checker does not visit structure attri...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: cc2256fa58d7af75de256cfa33ad8733f5556aeb https://github.com/WebKit/WebKit/commit/cc2256fa58d7af75de256cfa33ad8733f5556aeb Author: Tadeu Zagallo Date: 2024-02-21 (Wed, 21 Feb 2024) Changed paths: M Source/WebGPU/WGSL/TypeCheck.cpp Log Message: --- [WGSL] Type checker does not visit structure attributes https://bugs.webkit.org/show_bug.cgi?id=269786 rdar://123238802 Reviewed by Mike Wyrzykowski. The attributes of a struct weren't being visited, and therefore not type checked. * Source/WebGPU/WGSL/TypeCheck.cpp: (WGSL::TypeChecker::visit): Canonical link: https://commits.webkit.org/275105@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 7839f9: [CSS Container Queries][Style queries] Allow !impo...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 7839f9caaeec6540011d7470842f0966773b92a1 https://github.com/WebKit/WebKit/commit/7839f9caaeec6540011d7470842f0966773b92a1 Author: Antti Koivisto Date: 2024-02-21 (Wed, 21 Feb 2024) Changed paths: M LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/at-container-style-parsing-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/custom-property-style-queries-expected.txt M Source/WebCore/css/parser/CSSParserImpl.cpp M Source/WebCore/css/parser/CSSParserImpl.h M Source/WebCore/css/parser/CSSParserTokenRange.cpp M Source/WebCore/css/parser/CSSParserTokenRange.h M Source/WebCore/css/query/GenericMediaQueryParser.cpp Log Message: --- [CSS Container Queries][Style queries] Allow !important https://bugs.webkit.org/show_bug.cgi?id=269844 rdar://123374708 Reviewed by Alan Baradlay. * LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/custom-property-style-queries-expected.txt: * Source/WebCore/css/parser/CSSParserImpl.cpp: (WebCore::CSSParserImpl::consumeTrailingImportantAndWhitespace): Factor into a function and clean up. (WebCore::CSSParserImpl::consumeDeclaration): (WebCore::removeTrailingWhitespace): Deleted. * Source/WebCore/css/parser/CSSParserImpl.h: * Source/WebCore/css/parser/CSSParserTokenRange.cpp: (WebCore::CSSParserTokenRange::trimTrailingWhitespace): (WebCore::CSSParserTokenRange::consumeLast): (WebCore::CSSParserTokenRange::consumeAllExcludingTrailingWhitespace): Deleted. Some helper improvements. * Source/WebCore/css/parser/CSSParserTokenRange.h: (WebCore::CSSParserTokenRange::consumeAll): * Source/WebCore/css/query/GenericMediaQueryParser.cpp: (WebCore::MQ::consumeCustomPropertyValue): Consume away any !important and proceed to ignore it. Canonical link: https://commits.webkit.org/275104@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] f8d79c: [WGSL] Validate function parameter and return types
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: f8d79cb3381c3e2e52f3f2fa7aa0c8f3e54e63a9 https://github.com/WebKit/WebKit/commit/f8d79cb3381c3e2e52f3f2fa7aa0c8f3e54e63a9 Author: Tadeu Zagallo Date: 2024-02-21 (Wed, 21 Feb 2024) Changed paths: M Source/WebGPU/WGSL/TypeCheck.cpp M Source/WebGPU/WGSL/Types.cpp M Source/WebGPU/WGSL/Types.h Log Message: --- [WGSL] Validate function parameter and return types https://bugs.webkit.org/show_bug.cgi?id=269727 rdar://123238787 Reviewed by Mike Wyrzykowski. Validate function parameters and return types according to the spec[1]. [1]: https://www.w3.org/TR/WGSL/#function-restriction * Source/WebGPU/WGSL/TypeCheck.cpp: (WGSL::TypeChecker::visit): Canonical link: https://commits.webkit.org/275103@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 3bea24: WK_LIBFUZZER_COVERAGE should default to trace-pc-g...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 3bea246beab860f4cdc8e992956cdfda720eeebe https://github.com/WebKit/WebKit/commit/3bea246beab860f4cdc8e992956cdfda720eeebe Author: David Kilzer Date: 2024-02-21 (Wed, 21 Feb 2024) Changed paths: M Configurations/Sanitizers.xcconfig Log Message: --- WK_LIBFUZZER_COVERAGE should default to trace-pc-guard when Fuzzilli is enabled https://bugs.webkit.org/show_bug.cgi?id=269796 Reviewed by Yusuke Suzuki. * Configurations/Sanitizers.xcconfig: (WK_SANITIZER_OTHER_LDFLAGS): - Remove support for WK_FUZZILLI_OTHER_LDFLAGS_YES since it's no longer needed. (WK_LIBFUZZER_COVERAGE): - Default to trace-pc-guard when ENABLE_FUZZILLI=YES. (WK_FUZZILLI_OTHER_CFLAGS_YES): - Remove redundant -fsanitize-coverage=trace-pc-guard for Fuzzilli. (WK_FUZZILLI_OTHER_LDFLAGS_YES): Remove. Canonical link: https://commits.webkit.org/275102@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] bdca85: [WGSL] Calls to non-constructible struct construct...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: bdca8520ed5ffd00e6b77977f99b006f086f041a https://github.com/WebKit/WebKit/commit/bdca8520ed5ffd00e6b77977f99b006f086f041a Author: Tadeu Zagallo Date: 2024-02-21 (Wed, 21 Feb 2024) Changed paths: M Source/WebGPU/WGSL/TypeCheck.cpp Log Message: --- [WGSL] Calls to non-constructible struct constructors should be rejected https://bugs.webkit.org/show_bug.cgi?id=269793 rdar://123312266 Reviewed by Mike Wyrzykowski. We were missing a check in the type checker for whether the struct being constructed is actually constructible. * Source/WebGPU/WGSL/TypeCheck.cpp: (WGSL::TypeChecker::visit): Canonical link: https://commits.webkit.org/275101@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] c45034: REGRESSION (274945@main): [ iOS17 wk2 ] mathml/pre...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: c45034c246de229d4fabbde8a25eec9ec26cb1f6 https://github.com/WebKit/WebKit/commit/c45034c246de229d4fabbde8a25eec9ec26cb1f6 Author: Alan Baradlay Date: 2024-02-21 (Wed, 21 Feb 2024) Changed paths: M LayoutTests/mathml/presentation/scripts-underover-expected.html M LayoutTests/mathml/presentation/scripts-underover.html Log Message: --- REGRESSION (274945@main): [ iOS17 wk2 ] mathml/presentation/scripts-underover.html is a constant failure (EWS) https://bugs.webkit.org/show_bug.cgi?id=269760 Unreviewed test hardening. -use consistent line spacing. * LayoutTests/mathml/presentation/scripts-underover-expected.html: * LayoutTests/mathml/presentation/scripts-underover.html: Canonical link: https://commits.webkit.org/275100@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] badede: [WGSL] Fix small parser bugs
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: badede9886d3f208291d4ee550ceefd482cfc7ca https://github.com/WebKit/WebKit/commit/badede9886d3f208291d4ee550ceefd482cfc7ca Author: Tadeu Zagallo Date: 2024-02-21 (Wed, 21 Feb 2024) Changed paths: M Source/WebGPU/WGSL/Parser.cpp Log Message: --- [WGSL] Fix small parser bugs https://bugs.webkit.org/show_bug.cgi?id=269790 rdar://123311105 Reviewed by Mike Wyrzykowski. We were missing a check for a semicolon after const_assert and trailing commas in attributes, which caused a few CTS test failures. * Source/WebGPU/WGSL/Parser.cpp: (WGSL::Parser::parseConstAssert): (WGSL::Parser::parseAttribute): Canonical link: https://commits.webkit.org/275099@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] bbf9f2: REGRESSION(274827@main): ASSERTION FAILED: !deleti...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: bbf9f2b123cb1366ff9bbe4932fd42f010dc6257 https://github.com/WebKit/WebKit/commit/bbf9f2b123cb1366ff9bbe4932fd42f010dc6257 Author: Vitaly Dyachkov Date: 2024-02-21 (Wed, 21 Feb 2024) Changed paths: M Source/WebCore/page/LocalDOMWindow.cpp Log Message: --- REGRESSION(274827@main): ASSERTION FAILED: !deletionHasBegun() https://bugs.webkit.org/show_bug.cgi?id=269784 Reviewed by Chris Dumez. Use `RefPtrAllowingPartiallyDestroyed` to reference the `Document` in `LocalDOMWindow::removeAllEventListeners()` because it can be called when the deletion of the `Document` has already begun. * Source/WebCore/page/LocalDOMWindow.cpp: (WebCore::LocalDOMWindow::removeAllEventListeners): Canonical link: https://commits.webkit.org/275098@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 9d9b9b: [WGSL] Global sorting tries to print the name of a...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 9d9b9bba0c3d53e06df2af6da84463b83165226c https://github.com/WebKit/WebKit/commit/9d9b9bba0c3d53e06df2af6da84463b83165226c Author: Tadeu Zagallo Date: 2024-02-21 (Wed, 21 Feb 2024) Changed paths: M Source/WebGPU/WGSL/GlobalSorting.cpp Log Message: --- [WGSL] Global sorting tries to print the name of a const_assert https://bugs.webkit.org/show_bug.cgi?id=269787 rdar://123238821 Reviewed by Mike Wyrzykowski. A const_assert can never be part of a dependency cycle, but it can be visited while the cycle is being computed. In that case, a debug logging was trying to print the name of the const_assert, which resulted in an assertion failure. * Source/WebGPU/WGSL/GlobalSorting.cpp: (WGSL::nameForDeclaration): (WGSL::Graph::addEdge): (WGSL::reorder): Canonical link: https://commits.webkit.org/275097@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] acf728: Adopt more dynamicDowncast<> in FrameIOS
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: acf728ee70545f5bbe84d807755c25cfbbfa90b0 https://github.com/WebKit/WebKit/commit/acf728ee70545f5bbe84d807755c25cfbbfa90b0 Author: Anne van Kesteren Date: 2024-02-21 (Wed, 21 Feb 2024) Changed paths: M Source/WebCore/page/ios/FrameIOS.mm Log Message: --- Adopt more dynamicDowncast<> in FrameIOS https://bugs.webkit.org/show_bug.cgi?id=269828 Reviewed by Chris Dumez. * Source/WebCore/page/ios/FrameIOS.mm: (WebCore::nodeIsMouseFocusable): (WebCore::LocalFrame::preferredHeight const): Canonical link: https://commits.webkit.org/275096@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] a9c33a: Wasm Callee should remain set even after tier-up
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: a9c33a2b496aeadd33e500d7e474710f4abfbf8a https://github.com/WebKit/WebKit/commit/a9c33a2b496aeadd33e500d7e474710f4abfbf8a Author: Justin Michaud Date: 2024-02-21 (Wed, 21 Feb 2024) Changed paths: M LayoutTests/platform/mac/TestExpectations M Source/JavaScriptCore/wasm/WasmCallsiteCollection.cpp Log Message: --- Wasm Callee should remain set even after tier-up https://bugs.webkit.org/show_bug.cgi?id=268990 rdar://123015079 Reviewed by Alexey Shvayka. We may still need to call into the LLInt after tier-up, so we shouldn't clear callee. * Source/JavaScriptCore/wasm/WasmCallsiteCollection.cpp: (JSC::Wasm::CallsiteCollection::updateCallsitesToCallUs): Canonical link: https://commits.webkit.org/275095@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] ed5a44: More assorted dynamicDowncast<> adoption in WebKit...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: ed5a44f381a891a581bce59f807188e5c30cab31 https://github.com/WebKit/WebKit/commit/ed5a44f381a891a581bce59f807188e5c30cab31 Author: Anne van Kesteren Date: 2024-02-21 (Wed, 21 Feb 2024) Changed paths: M Source/WebCore/page/LocalFrameViewLayoutContext.cpp M Source/WebCore/workers/service/ServiceWorkerGlobalScope.h M Source/WebKit/WebProcess/WebCoreSupport/mac/WebDragClientMac.mm M Source/WebKit/WebProcess/cocoa/TextTrackRepresentationCocoa.mm Log Message: --- More assorted dynamicDowncast<> adoption in WebKit & WebCore https://bugs.webkit.org/show_bug.cgi?id=269826 Reviewed by Chris Dumez. * Source/WebCore/page/LocalFrameViewLayoutContext.cpp: (WebCore::RenderTreeNeedsLayoutChecker::~RenderTreeNeedsLayoutChecker): * Source/WebCore/workers/service/ServiceWorkerGlobalScope.h: (isType): * Source/WebKit/WebProcess/WebCoreSupport/mac/WebDragClientMac.mm: (WebKit::cachedImage): * Source/WebKit/WebProcess/cocoa/TextTrackRepresentationCocoa.mm: (WebKit::WebTextTrackRepresentationCocoa::setContentScale): (WebKit::WebTextTrackRepresentationCocoa::setHidden const): Canonical link: https://commits.webkit.org/275094@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] bcffee: [Skia] Implement inset shadows
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: bcffee080ac979d3b38875f008acdd39798ac7a4 https://github.com/WebKit/WebKit/commit/bcffee080ac979d3b38875f008acdd39798ac7a4 Author: Georges Basile Stavracas Neto Date: 2024-02-21 (Wed, 21 Feb 2024) Changed paths: M Source/WebCore/platform/graphics/skia/FontCascadeSkia.cpp M Source/WebCore/platform/graphics/skia/GraphicsContextSkia.cpp M Source/WebCore/platform/graphics/skia/GraphicsContextSkia.h Log Message: --- [Skia] Implement inset shadows https://bugs.webkit.org/show_bug.cgi?id=269714 Reviewed by Carlos Garcia Campos. Move the drop shadow filter creation into a helper method, and refactor all callers of GraphicsContextSkia::createFillPaint() to manually create and apply a drop shadow. The helper method returns nullptr if there is no shadow, or if the shadow is effectively hidden, following Cairo's optimization. Add a selector enum for inset and outset shadows, used by the helper method aforementioned, and handle the case for both inset and outset shadows. The outset shadow case is just what was there before. The inset shadow case is a combination of two image filters. One creates a black shadow with the drop shadow parameters, and uses it as a mask to apply a color blend. The color blend is what uses the actual drop shadow color, and blends it with the SrcIn mode, which effectively inverts the drop shadow based on the pixel opacity. The only place in code that interprets GraphicsContext.dropShadow() as an inset shadow is inside GraphicsContext::fillRectWithRoundedHole(), which is implemented in this commit using SkCanvas::drawDRRect(). * Source/WebCore/platform/graphics/skia/FontCascadeSkia.cpp: (WebCore::FontCascade::drawGlyphs): * Source/WebCore/platform/graphics/skia/GraphicsContextSkia.cpp: (WebCore::GraphicsContextSkia::drawNativeImageInternal): (WebCore::GraphicsContextSkia::fillPath): (WebCore::GraphicsContextSkia::createDropShadowFilter const): (WebCore::GraphicsContextSkia::createFillPaint const): (WebCore::GraphicsContextSkia::fillRect): (WebCore::GraphicsContextSkia::fillRoundedRectImpl): (WebCore::GraphicsContextSkia::fillRectWithRoundedHole): * Source/WebCore/platform/graphics/skia/GraphicsContextSkia.h: Canonical link: https://commits.webkit.org/275093@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 8b4edd: Source/WebKit/Platform/cocoa/ExtensionCapabilityGr...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 8b4edddf2455f4c5a5632bc7aea781e845b113c0 https://github.com/WebKit/WebKit/commit/8b4edddf2455f4c5a5632bc7aea781e845b113c0 Author: Jean-Yves Avenard Date: 2024-02-21 (Wed, 21 Feb 2024) Changed paths: M Source/WebKit/Platform/cocoa/ExtensionCapabilityGrant.mm Log Message: --- Source/WebKit/Platform/cocoa/ExtensionCapabilityGrant.mm:40:25: error: instance method '-isValid' not found https://bugs.webkit.org/show_bug.cgi?id=269839 rdar://123369227 Unreviewed compilation failure fix Change platformInvalidate prototype definition. * Source/WebKit/Platform/cocoa/ExtensionCapabilityGrant.mm: (WebKit::platformInvalidate): Canonical link: https://commits.webkit.org/275092@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] cfa812: Regression(251234@main): [Cairo][GTK][WPE] Darker ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: cfa8125ddf7c39a7256fcddf52b3c9f35de026e3 https://github.com/WebKit/WebKit/commit/cfa8125ddf7c39a7256fcddf52b3c9f35de026e3 Author: Przemyslaw Gorszkowski Date: 2024-02-21 (Wed, 21 Feb 2024) Changed paths: M LayoutTests/TestExpectations M LayoutTests/fast/gradients/conic-gradient-extended-stops.html M LayoutTests/platform/glib/TestExpectations M LayoutTests/svg/filters/feConvolveMatrix-clipped.svg M LayoutTests/svg/filters/feGaussianBlur-clipped.svg M Source/WTF/wtf/PlatformEnable.h M Source/WebCore/platform/graphics/ImageBuffer.cpp M Source/WebCore/platform/graphics/filters/FEDropShadow.h M Source/WebCore/platform/graphics/filters/FilterImageTargetSwitcher.cpp M Source/WebCore/platform/graphics/filters/FilterImageTargetSwitcher.h M Source/WebCore/platform/graphics/filters/FilterStyleTargetSwitcher.cpp M Source/WebCore/platform/graphics/filters/FilterStyleTargetSwitcher.h M Source/WebCore/platform/graphics/filters/FilterTargetSwitcher.h M Source/WebCore/rendering/RenderLayerFilters.cpp M Source/WebCore/rendering/svg/legacy/LegacyRenderSVGResourceFilter.cpp M Source/WebCore/svg/graphics/filters/SVGFilter.cpp Log Message: --- Regression(251234@main): [Cairo][GTK][WPE] Darker output of SVG with filters fediffuselighting https://bugs.webkit.org/show_bug.cgi?id=268537 Reviewed by Said Abou-Hallawa and Nikolas Zimmermann. Turn off the support for linearRGB color space in case of Cairo (251234@main) causes, that SVG with filter, where linearRGB as inputs is demanded, generates darker output. The SVG spec says that SourceGraphic has to be in linearRGB color space: https://www.w3.org/TR/filter-effects-1/#attr-valuedef-in-sourcegraphic In case of Cairo (which operates in SRGB color space) the image source (SourceGraphic) should be created in SRGB and before passing it to filters, it should be transformed to linearRGB color space. * LayoutTests/TestExpectations: * LayoutTests/platform/glib/TestExpectations: Remove some tests which pass with this change * LayoutTests/svg/filters/feConvolveMatrix-clipped.svg: * LayoutTests/svg/filters/feGaussianBlur-clipped.svg: * LayoutTests/fast/gradients/conic-gradient-extended-stops.html: Add possible differences in outputs * Source/WebCore/platform/graphics/ImageBuffer.cpp: (WebCore::ImageBuffer::filteredNativeImage): Pass color space to endDrawSourceImage * Source/WebCore/platform/graphics/filters/FEDropShadow.h: Force to use SRGB as operating color space for DropShadow in case of Cairo. * Source/WebCore/platform/graphics/filters/FilterImageTargetSwitcher.cpp: (WebCore::FilterImageTargetSwitcher::endClipAndDrawSourceImage): (WebCore::FilterImageTargetSwitcher::endDrawSourceImage): Before applying all filter, the source image has to be translated to requested color space (only valid for Cairo). * Source/WebCore/platform/graphics/filters/FilterTargetSwitcher.h: * Source/WebCore/platform/graphics/filters/FilterImageTargetSwitcher.h: * Source/WebCore/platform/graphics/filters/FilterStyleTargetSwitcher.h: Added color space as additional parameter. * Source/WebCore/platform/graphics/filters/FilterStyleTargetSwitcher.cpp: (WebCore::FilterStyleTargetSwitcher::endDrawSourceImage): WebCore::FilterStyleTargetSwitcher::endDrawSourceImage does not use color space so just ignore it * Source/WebCore/rendering/RenderLayerFilters.cpp: (WebCore::RenderLayerFilters::applyFilterEffect): Just pass DestinationColorSpace::SRGB() to endClipAndDrawSourceImage. * Source/WebCore/rendering/svg/legacy/LegacyRenderSVGResourceFilter.cpp: (WebCore::LegacyRenderSVGResourceFilter::applyResource): In case of Cairo, the sourceImage has to be created with sRGB color space, because Cairo operates in sRGB. The linearRGB color space will be passed to TargetSwitcher in WebCore::LegacyRenderSVGResourceFilter::postApplyResource and the sourceImage will be transformed to linearRGB before all filter applying. (WebCore::LegacyRenderSVGResourceFilter::postApplyResource): Before applying all filter, the source image has to be translated to requested color space. * Source/WebCore/svg/graphics/filters/SVGFilter.cpp: (WebCore::buildFilterEffectsGraph): Create SourceGraphic and SourceAlpha with LinearRGB color space if color-interpolation_filter attribute of the Filter has LinearRGB value (only in case of Cairo). Canonical link: https://commits.webkit.org/275091@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] c62c74: [WPE][GTK] Disable mDNS LibWebRTC support
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: c62c746909158152138988541b5c9ccf6be98d34 https://github.com/WebKit/WebKit/commit/c62c746909158152138988541b5c9ccf6be98d34 Author: Philippe Normand Date: 2024-02-21 (Wed, 21 Feb 2024) Changed paths: M Source/WebKit/WebProcess/Network/webrtc/LibWebRTCNetworkManager.cpp Log Message: --- [WPE][GTK] Disable mDNS LibWebRTC support https://bugs.webkit.org/show_bug.cgi?id=269836 Reviewed by Adrian Perez de Castro. Disable mDNS address resolving for WPE and GTK ports, mDNS address registration is implemented only for the Mac ports, so resolving can work only for those, currently. * Source/WebKit/WebProcess/Network/webrtc/LibWebRTCNetworkManager.cpp: (WebKit::LibWebRTCNetworkManager::GetMdnsResponder const): Canonical link: https://commits.webkit.org/275090@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 541bbd: [LibWebRTC][CMake] Data channel support broken
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 541bbd134c5e9e103d318a62f43d19cf394956e4 https://github.com/WebKit/WebKit/commit/541bbd134c5e9e103d318a62f43d19cf394956e4 Author: Philippe Normand Date: 2024-02-21 (Wed, 21 Feb 2024) Changed paths: M Source/ThirdParty/libwebrtc/CMakeLists.txt Log Message: --- [LibWebRTC][CMake] Data channel support broken https://bugs.webkit.org/show_bug.cgi?id=269779 Reviewed by Youenn Fablet. Enable dcsctp data channels support. * Source/ThirdParty/libwebrtc/CMakeLists.txt: Canonical link: https://commits.webkit.org/275089@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 7a77ef: Unprefixed backdrop filter should only be enabled ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 7a77efe3ef06baa7d9e64828b1c583cb090ebd01 https://github.com/WebKit/WebKit/commit/7a77efe3ef06baa7d9e64828b1c583cb090ebd01 Author: Matt Woodrow Date: 2024-02-21 (Wed, 21 Feb 2024) Changed paths: M Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml M Source/WebKit/Shared/WebPreferencesDefaultValues.h M Tools/DumpRenderTree/TestOptions.cpp M Tools/WebKitTestRunner/TestOptions.cpp Log Message: --- Unprefixed backdrop filter should only be enabled when UNPREFIXED_BACKDROP_FILTER is true. https://bugs.webkit.org/show_bug.cgi?id=269755 Reviewed by Tim Nguyen. * Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml: * Source/WebKit/Shared/WebPreferencesDefaultValues.h: Canonical link: https://commits.webkit.org/275088@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 136017: [view-transitions] Implement "capture the image" a...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 1360173f7d2bb98f8b6d3eefa30d77620bd07c37 https://github.com/WebKit/WebKit/commit/1360173f7d2bb98f8b6d3eefa30d77620bd07c37 Author: Matt Woodrow Date: 2024-02-21 (Wed, 21 Feb 2024) Changed paths: M LayoutTests/platform/glib/TestExpectations M LayoutTests/platform/mac-wk2/TestExpectations M Source/WebCore/dom/ViewTransition.cpp M Source/WebCore/dom/ViewTransition.h M Source/WebCore/rendering/RenderBoxModelObject.cpp M Source/WebCore/rendering/RenderElement.cpp M Source/WebCore/rendering/RenderElement.h M Source/WebCore/rendering/RenderLayer.cpp M Source/WebCore/rendering/RenderLayer.h M Source/WebCore/rendering/RenderLayerBacking.cpp M Source/WebCore/rendering/RenderLayerCompositor.cpp M Source/WebCore/rendering/RenderLayerCompositor.h M Source/WebCore/rendering/RenderViewTransitionCapture.cpp M Source/WebCore/rendering/RenderViewTransitionCapture.h M Source/WebCore/rendering/updating/RenderTreeUpdaterViewTransition.cpp Log Message: --- [view-transitions] Implement "capture the image" algorithm. https://bugs.webkit.org/show_bug.cgi?id=265170 Reviewed by Tim Nguyen. Uses 'snapshotNode' to capture the old image during 'captureOldState', and implements `paintReplaced` on the renderer (in the same way RenderHTMLElement does) to draw the old catpured image. Forces composited layers to be created for the ::view-transition-new/old pseudos, as well as the element with the view-transtion, and reparents the GraphicsLayer from real element into pseduo, so that the new capture is displayed using the live content. This also effectively stops the original element from being displayed normally, as required by the spec. * Source/WebCore/dom/ViewTransition.cpp: (WebCore::ViewTransition::captureOldState): * Source/WebCore/dom/ViewTransition.h: * Source/WebCore/rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::requiresLayer const): * Source/WebCore/rendering/RenderElement.cpp: (WebCore::RenderElement::hasViewTransition const): (WebCore::RenderElement::isViewTransitionPseudo const): * Source/WebCore/rendering/RenderElement.h: * Source/WebCore/rendering/RenderLayer.cpp: (WebCore::canCreateStackingContext): (WebCore::RenderLayer::shouldBeCSSStackingContext const): (WebCore::RenderLayer::computeCanBeBackdropRoot const): * Source/WebCore/rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::updateGeometry): * Source/WebCore/rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::collectViewTransitionNewContentLayers): (WebCore::RenderLayerCompositor::updateBackingAndHierarchy): (WebCore::RenderLayerCompositor::requiresCompositingLayer const): (WebCore::RenderLayerCompositor::requiresOwnBackingStore const): (WebCore::RenderLayerCompositor::requiresCompositingForViewTransition const): * Source/WebCore/rendering/RenderLayerCompositor.h: * Source/WebCore/rendering/RenderViewTransitionCapture.cpp: (WebCore::RenderViewTransitionCapture::setImage): (WebCore::RenderViewTransition::paintReplaced): * Source/WebCore/rendering/RenderViewTransitionCapture.h: * Source/WebCore/rendering/updating/RenderTreeUpdaterViewTransition.cpp: (WebCore::RenderTreeUpdater::ViewTransition::updatePseudoElementTree): (WebCore::RenderTreeUpdater::ViewTransition::buildPseudoElementGroup): (WebCore::RenderTreeUpdater::ViewTransition::updatePseudoElementGroup): Canonical link: https://commits.webkit.org/275087@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
