[webkit-changes] [WebKit/WebKit] dc6a01: Enable UnifiedPDF compile time flag on Cocoa platf...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: dc6a01c9fd207e1b1394a1cb8261b410a1909cf6 https://github.com/WebKit/WebKit/commit/dc6a01c9fd207e1b1394a1cb8261b410a1909cf6 Author: Tim Horton Date: 2024-02-23 (Fri, 23 Feb 2024) Changed paths: M Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml M Source/WTF/wtf/PlatformEnableCocoa.h M Source/WTF/wtf/PlatformHave.h M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.h M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm M Source/WebKit/WebProcess/Plugins/WebPluginInfoProvider.cpp M Tools/WebKitTestRunner/TestOptions.cpp Log Message: --- Enable UnifiedPDF compile time flag on Cocoa platforms https://bugs.webkit.org/show_bug.cgi?id=269440 Reviewed by Simon Fraser. * Source/WTF/wtf/PlatformEnableCocoa.h: Turn it on. * Source/WTF/wtf/PlatformHave.h: Add a define for some CG API added recently. * Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm: (WebKit::UnifiedPDFPlugin::pdfElementTypesForPluginPoint const): (WebKit::UnifiedPDFPlugin::handlePDFActionForAnnotation): Adopt defines for not-yet-everywhere API. (WebKit::UnifiedPDFPlugin::shouldShowDebugIndicators const): (WebKit::UnifiedPDFPlugin::didChangeSettings): (WebKit::UnifiedPDFPlugin::paintPDFContent): Fix the build on old compilers. * Tools/WebKitTestRunner/TestOptions.cpp: (WTR::TestOptions::defaults): Disable by default in test runner for now, so we have to explicitly opt tests into unified PDF. We'll swap this at some point. * Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml: * Source/WebKit/WebProcess/Plugins/WebPluginInfoProvider.cpp: (WebKit::pluginInfoVector): (WebKit::WebPluginInfoProvider::pluginInfo): (WebKit::WebPluginInfoProvider::webVisiblePluginInfo): Fix a longstanding mis-assumption that if ENABLE(PDF_PLUGIN) is true, we will always have PDF plugins (the macOS version was never runtime-disableable). This mistake previously caused us to pretend to have a PDF plugin on iOS when Unified PDF was enabled at build time, even if it was disabled at runtime, breaking our fallback to PDFDocumentImage-based presentation. Canonical link: https://commits.webkit.org/275274@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] a0edcb: Fix the internal iOS build when USE(BROWSERENGINEK...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: a0edcb80c674edf695bb1bdc424a57456f4c3218 https://github.com/WebKit/WebKit/commit/a0edcb80c674edf695bb1bdc424a57456f4c3218 Author: Wenson Hsieh Date: 2024-02-23 (Fri, 23 Feb 2024) Changed paths: M Source/WebKit/Configurations/WebKit.xcconfig M Tools/TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig Log Message: --- Fix the internal iOS build when USE(BROWSERENGINEKIT) is set https://bugs.webkit.org/show_bug.cgi?id=270033 rdar://123545536 Reviewed by Tim Horton. Fix the build by removing some xcconfig overrides that are no longer required. * Source/WebKit/Configurations/WebKit.xcconfig: * Tools/TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig: Canonical link: https://commits.webkit.org/275273@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] dc20f3: _WKWebExtensionMessagePort is being deallocated on...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: dc20f3f73c6b9aa0da5523525031b6501436dc4d https://github.com/WebKit/WebKit/commit/dc20f3f73c6b9aa0da5523525031b6501436dc4d Author: Timothy Hatcher Date: 2024-02-23 (Fri, 23 Feb 2024) Changed paths: M Source/WTF/wtf/PlatformHave.h M Source/WTF/wtf/spi/cocoa/objcSPI.h M Source/WebKit/Shared/Cocoa/WKObject.h M Source/WebKit/UIProcess/API/Cocoa/_WKWebExtension.mm M Source/WebKit/UIProcess/API/Cocoa/_WKWebExtensionAction.mm M Source/WebKit/UIProcess/API/Cocoa/_WKWebExtensionCommand.mm M Source/WebKit/UIProcess/API/Cocoa/_WKWebExtensionContext.mm M Source/WebKit/UIProcess/API/Cocoa/_WKWebExtensionController.mm M Source/WebKit/UIProcess/API/Cocoa/_WKWebExtensionControllerConfiguration.mm M Source/WebKit/UIProcess/API/Cocoa/_WKWebExtensionDataRecord.mm M Source/WebKit/UIProcess/API/Cocoa/_WKWebExtensionMatchPattern.mm M Source/WebKit/UIProcess/API/Cocoa/_WKWebExtensionMessagePort.mm Log Message: --- _WKWebExtensionMessagePort is being deallocated on a background thread. https://webkit.org/b/270012 rdar://123529626 Reviewed by Darin Adler. Introduce WK_OBJECT_DEALLOC_ON_MAIN_THREAD() and WK_OBJECT_DEALLOC_IMPL_ON_MAIN_THREAD() macros that use _class_setCustomDeallocInitiation() to be able to dealloc on the main thread for both ARC and non-ARC objects. Start using these macros in the Web Extensions classes since they stopped using WebCoreObjCScheduleDeallocateOnMainRunLoop(). All objects currently using the WebCore dealloc helper can be switched over to use these new macros. * Source/WTF/wtf/PlatformHave.h: Added HAVE_OBJC_CUSTOM_DEALLOC. * Source/WTF/wtf/spi/cocoa/objcSPI.h: Added _class_setCustomDeallocInitiation and _objc_deallocOnMainThreadHelper. * Source/WebKit/Shared/Cocoa/WKObject.h: Added WK_OBJECT_DEALLOC_ON_MAIN_THREAD and WK_OBJECT_DEALLOC_IMPL_ON_MAIN_THREAD. * Source/WebKit/UIProcess/API/Cocoa/_WKWebExtension.mm: (-[_WKWebExtension dealloc]): Deleted. * Source/WebKit/UIProcess/API/Cocoa/_WKWebExtensionAction.mm: (-[_WKWebExtensionAction dealloc]): Deleted. * Source/WebKit/UIProcess/API/Cocoa/_WKWebExtensionCommand.mm: (-[_WKWebExtensionCommand dealloc]): Deleted. * Source/WebKit/UIProcess/API/Cocoa/_WKWebExtensionContext.mm: (-[_WKWebExtensionContext initForExtension:]): (-[_WKWebExtensionContext dealloc]): Deleted. * Source/WebKit/UIProcess/API/Cocoa/_WKWebExtensionController.mm: (-[_WKWebExtensionController dealloc]): Deleted. * Source/WebKit/UIProcess/API/Cocoa/_WKWebExtensionControllerConfiguration.mm: (-[_WKWebExtensionControllerConfiguration dealloc]): Deleted. * Source/WebKit/UIProcess/API/Cocoa/_WKWebExtensionDataRecord.mm: (-[_WKWebExtensionDataRecord dealloc]): Deleted. * Source/WebKit/UIProcess/API/Cocoa/_WKWebExtensionMatchPattern.mm: (-[_WKWebExtensionMatchPattern initWithCoder:]): (-[_WKWebExtensionMatchPattern encodeWithCoder:]): (-[_WKWebExtensionMatchPattern copyWithZone:]): (-[_WKWebExtensionMatchPattern dealloc]): Deleted. * Source/WebKit/UIProcess/API/Cocoa/_WKWebExtensionMessagePort.mm: (-[_WKWebExtensionMessagePort dealloc]): Deleted. Canonical link: https://commits.webkit.org/275272@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 0a519d: Drop LockHolder alias
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 0a519d863ac1cd38d5fe58cef8d447267641b8c5 https://github.com/WebKit/WebKit/commit/0a519d863ac1cd38d5fe58cef8d447267641b8c5 Author: Chris Dumez Date: 2024-02-23 (Fri, 23 Feb 2024) Changed paths: M Source/JavaScriptCore/heap/IsoSubspacePerVM.cpp M Source/JavaScriptCore/heap/IsoSubspacePerVM.h M Source/JavaScriptCore/jit/ExecutableAllocator.cpp M Source/JavaScriptCore/runtime/ConcurrentJSLock.h M Source/JavaScriptCore/runtime/SamplingProfiler.cpp M Source/WTF/wtf/Lock.h M Source/WTF/wtf/MetaAllocator.cpp M Source/WTF/wtf/MetaAllocator.h M Source/WTF/wtf/ParkingLot.cpp M Source/WTF/wtf/WordLock.h M Source/WTF/wtf/text/AtomStringImpl.cpp M Source/WebCore/platform/graphics/avfoundation/objc/CDMSessionAVContentKeySession.mm M Source/WebCore/platform/graphics/gstreamer/eme/WebKitCommonEncryptionDecryptorGStreamer.cpp M Source/WebCore/platform/graphics/nicosia/NicosiaSceneIntegration.h M Source/WebCore/platform/mediarecorder/MediaRecorderPrivateGStreamer.cpp M Source/WebGPU/WebGPU/Instance.mm M Source/WebKit/Shared/CoordinatedGraphics/threadedcompositor/CompositingRunLoop.cpp M Source/WebKit/Shared/CoordinatedGraphics/threadedcompositor/CompositingRunLoop.h Log Message: --- Drop LockHolder alias https://bugs.webkit.org/show_bug.cgi?id=270010 Reviewed by Darin Adler. Drop LockHolder alias for `Locker`. `Locker` is not much longer and we can often use the shorter `Locker` thanks to template parameter detection nowadays. * Source/JavaScriptCore/heap/IsoSubspacePerVM.cpp: (JSC::IsoSubspacePerVM::isoSubspaceforHeap): * Source/JavaScriptCore/heap/IsoSubspacePerVM.h: * Source/JavaScriptCore/jit/ExecutableAllocator.cpp: * Source/JavaScriptCore/runtime/ConcurrentJSLock.h: * Source/JavaScriptCore/runtime/SamplingProfiler.cpp: (JSC::SamplingProfiler::takeSample): * Source/WTF/wtf/Lock.h: * Source/WTF/wtf/MetaAllocator.cpp: (WTF::MetaAllocator::release): (WTF::MetaAllocator::allocate): (WTF::MetaAllocator::currentStatistics): * Source/WTF/wtf/MetaAllocator.h: * Source/WTF/wtf/ParkingLot.cpp: * Source/WTF/wtf/WordLock.h: * Source/WTF/wtf/text/AtomStringImpl.cpp: (WTF::AtomStringTableLocker::AtomStringTableLocker): * Source/WebCore/platform/graphics/avfoundation/objc/CDMSessionAVContentKeySession.mm: (WebCore::CDMSessionAVContentKeySession::hasContentKeyRequest const): (WebCore::CDMSessionAVContentKeySession::contentKeyRequest): (WebCore::CDMSessionAVContentKeySession::didProvideContentKeyRequest): * Source/WebCore/platform/graphics/gstreamer/eme/WebKitCommonEncryptionDecryptorGStreamer.cpp: (changeState): * Source/WebCore/platform/graphics/nicosia/NicosiaSceneIntegration.h: * Source/WebCore/platform/mediarecorder/MediaRecorderPrivateGStreamer.cpp: (WebCore::MediaRecorderPrivateBackend::stopRecording): (WebCore::MediaRecorderPrivateBackend::notifyEOS): * Source/WebGPU/WebGPU/Instance.mm: (WebGPU::Instance::defaultScheduleWork): (WebGPU::Instance::processEvents): * Source/WebKit/Shared/CoordinatedGraphics/threadedcompositor/CompositingRunLoop.cpp: (WebKit::CompositingRunLoop::scheduleUpdate): (WebKit::CompositingRunLoop::updateCompleted): * Source/WebKit/Shared/CoordinatedGraphics/threadedcompositor/CompositingRunLoop.h: Canonical link: https://commits.webkit.org/275271@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 809e39: Disable Web Transport-related IPC endpoints when t...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 809e3920b67fb7167c2dd9328ca85508f0ddb80b https://github.com/WebKit/WebKit/commit/809e3920b67fb7167c2dd9328ca85508f0ddb80b Author: Chris Dumez Date: 2024-02-23 (Fri, 23 Feb 2024) Changed paths: M Source/WebKit/CMakeLists.txt M Source/WebKit/DerivedSources-input.xcfilelist M Source/WebKit/DerivedSources.make M Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.cpp M Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.h M Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.messages.in M Source/WebKit/Shared/NetworkProcessConnectionParameters.h M Source/WebKit/Shared/NetworkProcessConnectionParameters.serialization.in A Source/WebKit/Shared/NetworkProcessPreferencesForWebProcess.h A Source/WebKit/Shared/NetworkProcessPreferencesForWebProcess.serialization.in M Source/WebKit/UIProcess/API/APIPageConfiguration.cpp M Source/WebKit/UIProcess/API/APIPageConfiguration.h M Source/WebKit/UIProcess/Network/NetworkProcessProxy.cpp M Source/WebKit/UIProcess/SuspendedPageProxy.cpp M Source/WebKit/UIProcess/WebPageProxy.cpp M Source/WebKit/UIProcess/WebPageProxy.h M Source/WebKit/UIProcess/WebProcessCache.cpp M Source/WebKit/UIProcess/WebProcessPool.cpp M Source/WebKit/UIProcess/WebProcessPool.h M Source/WebKit/UIProcess/WebProcessProxy.cpp M Source/WebKit/UIProcess/WebProcessProxy.h M Source/WebKit/WebKit.xcodeproj/project.pbxproj M Source/WebKit/WebProcess/Network/NetworkProcessConnection.cpp M Source/WebKit/WebProcess/Network/WebTransportSession.cpp M Source/WebKit/WebProcess/WebPage/WebPage.cpp M Source/WebKit/WebProcess/WebPage/WebPage.h M Source/WebKit/WebProcess/WebProcess.cpp M Source/WebKit/WebProcess/WebProcess.h Log Message: --- Disable Web Transport-related IPC endpoints when the feature is disabled at runtime https://bugs.webkit.org/show_bug.cgi?id=269742 rdar://122108912 Reviewed by Alex Christensen. Follow the same pattern as for the GPUProcess, introduce a NetworkProcessPreferencesForWebProcess struct which contains the set of WebProcess preferences the NetworkProcess needs to know about (for now "isWebTransportEnabled"). These preferences are passed to the network process when the WebProcess initiates the connection to the network process. The NetworkProcess can then use these preferences to decide whether or not to enable particular IPC endpoints with the WebProcess, using [EnabledIf] in messages.in. * Source/WebKit/CMakeLists.txt: * Source/WebKit/DerivedSources-input.xcfilelist: * Source/WebKit/DerivedSources.make: * Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.cpp: * Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.h: (WebKit::NetworkConnectionToWebProcess::isWebTransportEnabled const): * Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.messages.in: * Source/WebKit/Shared/NetworkProcessConnectionParameters.h: * Source/WebKit/Shared/NetworkProcessConnectionParameters.serialization.in: * Source/WebKit/UIProcess/API/APIPageConfiguration.cpp: (API::PageConfiguration::preferences const): (API::PageConfiguration::preferencesForNetworkProcess const): (API::PageConfiguration::preferences): Deleted. * Source/WebKit/UIProcess/API/APIPageConfiguration.h: * Source/WebKit/UIProcess/Network/NetworkProcessProxy.cpp: (WebKit::NetworkProcessProxy::getNetworkProcessConnection): * Source/WebKit/UIProcess/SuspendedPageProxy.cpp: (WebKit::SuspendedPageProxy::findReusableSuspendedPageProcess): * Source/WebKit/UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::hasSameGPUAndNetworkProcessPreferencesAs const): (WebKit::WebPageProxy::launchProcess): (WebKit::WebPageProxy::preferencesForNetworkProcess const): (WebKit::WebPageProxy::hasSameGPUProcessPreferencesAs const): Deleted. * Source/WebKit/UIProcess/WebPageProxy.h: * Source/WebKit/UIProcess/WebProcessCache.cpp: (WebKit::WebProcessCache::takeProcess): * Source/WebKit/UIProcess/WebProcessPool.cpp: (WebKit::WebProcessPool::establishRemoteWorkerContextConnectionToNetworkProcess): (WebKit::WebProcessPool::tryTakePrewarmedProcess): (WebKit::WebProcessPool::processForRegistrableDomain): (WebKit::WebProcessPool::createWebPage): (WebKit::WebProcessPool::processForNavigationInternal): * Source/WebKit/UIProcess/WebProcessPool.h: * Source/WebKit/UIProcess/WebProcessProxy.cpp: (WebKit::WebProcessProxy::initializePreferencesForGPUAndNetworkProcesses): (WebKit::WebProcessProxy::initializePreferencesForNetworkProcess): (WebKit::WebProcessProxy::hasSameGPUAndNetworkProcessPreferencesAs const): (WebKit::WebProcessProxy::addProvisionalPageProxy): (WebKit::WebProcessProxy::addRemotePageProxy): (WebKit::WebProcessProxy::addExistingWebPage): (WebKit::WebProcessProxy::initializePreferencesForGPUProcess): Deleted. (WebKit::WebProcessProxy::hasSameGPUProcessPreferencesAs const): Deleted. * Source/WebKit/UIProcess/WebPro
[webkit-changes] [WebKit/WebKit] e69275: Make notifyNodeInsertedInto* and notifyNodeRemoved...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: e69275aaafe241b8995fc7519c31d15dde19a714 https://github.com/WebKit/WebKit/commit/e69275aaafe241b8995fc7519c31d15dde19a714 Author: Ryosuke Niwa Date: 2024-02-23 (Fri, 23 Feb 2024) Changed paths: M Source/WebCore/dom/ContainerNodeAlgorithms.cpp Log Message: --- Make notifyNodeInsertedInto* and notifyNodeRemovedFrom* iterative https://bugs.webkit.org/show_bug.cgi?id=270022 Reviewed by Yusuke Suzuki. Made these functions iterative instead of recursive. * Source/WebCore/dom/ContainerNodeAlgorithms.cpp: (WebCore::notifyNodeInsertedIntoDocument): (WebCore::notifyNodeInsertedIntoTree): (WebCore::notifyNodeRemovedFromDocument): (WebCore::notifyNodeRemovedFromTree): Canonical link: https://commits.webkit.org/275269@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 5f3622: NEW TEST [ MacOS ] imported/w3c/web-platform-tests...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 5f3622e3b24527b6a58d4b50c69f1a68e4709eea https://github.com/WebKit/WebKit/commit/5f3622e3b24527b6a58d4b50c69f1a68e4709eea Author: Jean-Yves Avenard Date: 2024-02-23 (Fri, 23 Feb 2024) Changed paths: M LayoutTests/platform/mac-wk2/TestExpectations M Source/WebKit/GPUProcess/media/RemoteMediaSourceProxy.cpp M Source/WebKit/GPUProcess/media/RemoteSourceBufferProxy.cpp M Source/WebKit/GPUProcess/media/RemoteSourceBufferProxy.h M Source/WebKit/WebProcess/GPU/media/MediaSourcePrivateRemote.cpp M Source/WebKit/WebProcess/GPU/media/SourceBufferPrivateRemote.cpp M Source/WebKit/WebProcess/GPU/media/SourceBufferPrivateRemote.h M Source/WebKit/WebProcess/GPU/media/SourceBufferPrivateRemoteMessageReceiver.messages.in Log Message: --- NEW TEST [ MacOS ] imported/w3c/web-platform-tests/media-source/dedicated-worker/mediasource-worker-detach-element.html is a flaky crash https://bugs.webkit.org/show_bug.cgi?id=269871 rdar://123404489 Reviewed by Youenn Fablet. When shutting down the RemoteMediaSourceProxy in the GPUP we would send a asynchronous message to the MediaSourcePrivateRemote in the WP which in turn would have disconnected all the SourceBufferPrivateRemote. However, it was possible at this stage that the MediaSource in a worker to itself have started to shutdown and detaching all existing SourceBuffer. At this stage, the MediaSourcePrivateRemote::m_sourceBuffers would have been emptied and be unable to disconnect them. So we split the shutdown of the RemoteMediaSourceProxy and of the RemoteSourceBufferProxy so that they each inform their respective remotes to start shutting down. Similar to what the RemoteMediaSourceProxy does when being shutdown by the RemoteMediaPlayerProxy, it will now tell all RemoteSourceBufferProxies to shutdown, which in turn will shutdown the source buffers in the web process. Only once that message been sent that it will continue tearing down the proxies. Covered by re-enabled test. * LayoutTests/platform/mac-wk2/TestExpectations: * Source/WebKit/GPUProcess/media/RemoteMediaSourceProxy.cpp: (WebKit::RemoteMediaSourceProxy::disconnect): (WebKit::RemoteMediaSourceProxy::shutdown): * Source/WebKit/GPUProcess/media/RemoteSourceBufferProxy.cpp: (WebKit::RemoteSourceBufferProxy::shutdown): * Source/WebKit/GPUProcess/media/RemoteSourceBufferProxy.h: * Source/WebKit/WebProcess/GPU/media/MediaSourcePrivateRemote.cpp: (WebKit::MediaSourcePrivateRemote::MessageReceiver::mediaSourcePrivateShuttingDown): * Source/WebKit/WebProcess/GPU/media/SourceBufferPrivateRemote.cpp: (WebKit::SourceBufferPrivateRemote::removedFromMediaSource): (WebKit::SourceBufferPrivateRemote::MessageReceiver::sourceBufferPrivateShuttingDown): * Source/WebKit/WebProcess/GPU/media/SourceBufferPrivateRemote.h: * Source/WebKit/WebProcess/GPU/media/SourceBufferPrivateRemoteMessageReceiver.messages.in: Canonical link: https://commits.webkit.org/275268@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] e73497: Remove Event::eventInterface
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: e73497e992e4e234534153d64106dbd4946485ca https://github.com/WebKit/WebKit/commit/e73497e992e4e234534153d64106dbd4946485ca Author: Ryosuke Niwa Date: 2024-02-23 (Fri, 23 Feb 2024) Changed paths: M Source/WebCore/Modules/WebGPU/GPUUncapturedErrorEvent.cpp M Source/WebCore/Modules/WebGPU/GPUUncapturedErrorEvent.h M Source/WebCore/Modules/airplay/WebKitPlaybackTargetAvailabilityEvent.h M Source/WebCore/Modules/applepay/ApplePayCancelEvent.cpp M Source/WebCore/Modules/applepay/ApplePayCancelEvent.h M Source/WebCore/Modules/applepay/ApplePayCouponCodeChangedEvent.cpp M Source/WebCore/Modules/applepay/ApplePayCouponCodeChangedEvent.h M Source/WebCore/Modules/applepay/ApplePayPaymentAuthorizedEvent.cpp M Source/WebCore/Modules/applepay/ApplePayPaymentAuthorizedEvent.h M Source/WebCore/Modules/applepay/ApplePayPaymentMethodSelectedEvent.cpp M Source/WebCore/Modules/applepay/ApplePayPaymentMethodSelectedEvent.h M Source/WebCore/Modules/applepay/ApplePayShippingContactSelectedEvent.cpp M Source/WebCore/Modules/applepay/ApplePayShippingContactSelectedEvent.h M Source/WebCore/Modules/applepay/ApplePayShippingMethodSelectedEvent.cpp M Source/WebCore/Modules/applepay/ApplePayShippingMethodSelectedEvent.h M Source/WebCore/Modules/applepay/ApplePayValidateMerchantEvent.cpp M Source/WebCore/Modules/applepay/ApplePayValidateMerchantEvent.h M Source/WebCore/Modules/cookie-store/CookieChangeEvent.cpp M Source/WebCore/Modules/cookie-store/CookieChangeEvent.h M Source/WebCore/Modules/cookie-store/ExtendableCookieChangeEvent.cpp M Source/WebCore/Modules/cookie-store/ExtendableCookieChangeEvent.h M Source/WebCore/Modules/encryptedmedia/MediaKeyMessageEvent.cpp M Source/WebCore/Modules/encryptedmedia/MediaKeyMessageEvent.h M Source/WebCore/Modules/encryptedmedia/legacy/WebKitMediaKeyMessageEvent.cpp M Source/WebCore/Modules/encryptedmedia/legacy/WebKitMediaKeyMessageEvent.h M Source/WebCore/Modules/encryptedmedia/legacy/WebKitMediaKeyNeededEvent.cpp M Source/WebCore/Modules/encryptedmedia/legacy/WebKitMediaKeyNeededEvent.h M Source/WebCore/Modules/gamepad/GamepadEvent.h M Source/WebCore/Modules/indexeddb/IDBVersionChangeEvent.cpp M Source/WebCore/Modules/indexeddb/IDBVersionChangeEvent.h M Source/WebCore/Modules/mediarecorder/BlobEvent.cpp M Source/WebCore/Modules/mediarecorder/BlobEvent.h M Source/WebCore/Modules/mediarecorder/MediaRecorderErrorEvent.cpp M Source/WebCore/Modules/mediarecorder/MediaRecorderErrorEvent.h M Source/WebCore/Modules/mediasource/BufferedChangeEvent.cpp M Source/WebCore/Modules/mediasource/BufferedChangeEvent.h M Source/WebCore/Modules/mediastream/MediaStreamTrackEvent.cpp M Source/WebCore/Modules/mediastream/MediaStreamTrackEvent.h M Source/WebCore/Modules/mediastream/OverconstrainedErrorEvent.h M Source/WebCore/Modules/mediastream/RTCDTMFToneChangeEvent.cpp M Source/WebCore/Modules/mediastream/RTCDTMFToneChangeEvent.h M Source/WebCore/Modules/mediastream/RTCDataChannelEvent.cpp M Source/WebCore/Modules/mediastream/RTCDataChannelEvent.h M Source/WebCore/Modules/mediastream/RTCErrorEvent.h M Source/WebCore/Modules/mediastream/RTCPeerConnectionIceErrorEvent.cpp M Source/WebCore/Modules/mediastream/RTCPeerConnectionIceErrorEvent.h M Source/WebCore/Modules/mediastream/RTCPeerConnectionIceEvent.cpp M Source/WebCore/Modules/mediastream/RTCPeerConnectionIceEvent.h M Source/WebCore/Modules/mediastream/RTCRtpSFrameTransformErrorEvent.cpp M Source/WebCore/Modules/mediastream/RTCRtpSFrameTransformErrorEvent.h M Source/WebCore/Modules/mediastream/RTCTrackEvent.h M Source/WebCore/Modules/mediastream/RTCTransformEvent.cpp M Source/WebCore/Modules/mediastream/RTCTransformEvent.h M Source/WebCore/Modules/notifications/NotificationEvent.h M Source/WebCore/Modules/paymentrequest/MerchantValidationEvent.cpp M Source/WebCore/Modules/paymentrequest/MerchantValidationEvent.h M Source/WebCore/Modules/paymentrequest/PaymentMethodChangeEvent.cpp M Source/WebCore/Modules/paymentrequest/PaymentMethodChangeEvent.h M Source/WebCore/Modules/paymentrequest/PaymentRequestUpdateEvent.cpp M Source/WebCore/Modules/paymentrequest/PaymentRequestUpdateEvent.h M Source/WebCore/Modules/pictureinpicture/PictureInPictureEvent.h M Source/WebCore/Modules/push-api/PushEvent.h M Source/WebCore/Modules/push-api/PushNotificationEvent.h M Source/WebCore/Modules/push-api/PushSubscriptionChangeEvent.h M Source/WebCore/Modules/speech/SpeechRecognitionErrorEvent.cpp M Source/WebCore/Modules/speech/SpeechRecognitionErrorEvent.h M Source/WebCore/Modules/speech/SpeechRecognitionEvent.cpp M Source/WebCore/Modules/speech/SpeechRecognitionEvent.h M Source/WebCore/Modules/speech/SpeechSynthesisErro
[webkit-changes] [WebKit/WebKit] f4a21d: AX: Fix expectation for test now passing in ITM.
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: f4a21d2908ab672c931b9057df95b68db7bd3b2d https://github.com/WebKit/WebKit/commit/f4a21d2908ab672c931b9057df95b68db7bd3b2d Author: Andres Gonzalez Date: 2024-02-23 (Fri, 23 Feb 2024) Changed paths: M LayoutTests/accessibility-isolated-tree/TestExpectations Log Message: --- AX: Fix expectation for test now passing in ITM. https://bugs.webkit.org/show_bug.cgi?id=27 Unreviewed test gardening. These tests are now passing in ITM, thus removing them from the list of failures. * LayoutTests/accessibility-isolated-tree/TestExpectations: Canonical link: https://commits.webkit.org/275266@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 26acc6: AX: VoiceOver reports the datetime value in the wr...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 26acc630c3467b5ce6989d4d5a9c842c5c8be498 https://github.com/WebKit/WebKit/commit/26acc630c3467b5ce6989d4d5a9c842c5c8be498 Author: Andres Gonzalez Date: 2024-02-23 (Fri, 23 Feb 2024) Changed paths: M Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm Log Message: --- AX: VoiceOver reports the datetime value in the wrong time zone. https://bugs.webkit.org/show_bug.cgi?id=26 Reviewed by Chris Fleizach. VoiceOver expects the value of dateTime elements to be in local time zone. Since we store those values in GMT, we need to convert them to local times before returning them. * Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm: (gmtToLocalTimeOffset): (-[WebAccessibilityObjectWrapper accessibilityAttributeValue:]): Canonical link: https://commits.webkit.org/275265@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] a22474: [UnifiedPDF] PDFPluginChoiceAnnotations have incor...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: a2247463abb0064a8213ab4d24a23c9d38378514 https://github.com/WebKit/WebKit/commit/a2247463abb0064a8213ab4d24a23c9d38378514 Author: Sammy Gill Date: 2024-02-23 (Fri, 23 Feb 2024) Changed paths: M Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.h M Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.mm M Source/WebKit/WebProcess/Plugins/PDF/PDFPluginBase.h M Source/WebKit/WebProcess/Plugins/PDF/PDFPluginChoiceAnnotation.mm M Source/WebKit/WebProcess/Plugins/PDF/PDFPluginTextAnnotation.mm M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.h M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm Log Message: --- [UnifiedPDF] PDFPluginChoiceAnnotations have incorrect font size. https://bugs.webkit.org/show_bug.cgi?id=269923 rdar://123119103 Reviewed by Simon Fraser. The PDFPluginChoiceAnnotation sets its font size based on the size of the font in the underlying annotation within the document and then scales it based on its scale factor. The UnifiedPDFPlugin's scale factor is its zoom scale factor, but we could also have scaled the document to fit in the available width. PDFPluginTextAnnotations take into consideration both scale factors so we should do the same here. In order to do this more cleanly, I introduced contentScaleFactor on the plugins. For the legacy PDF plugin this is just the same as its scaleFactor, but for the UnifiedPDFPlugin this is both the document fitting scale and the zoom scale (it seems like this is what the legacy plugin considers to be its scaleFactor as well). * Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.h: * Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.mm: (WebKit::PDFPlugin::contentScaleFactor const): * Source/WebKit/WebProcess/Plugins/PDF/PDFPluginBase.h: * Source/WebKit/WebProcess/Plugins/PDF/PDFPluginChoiceAnnotation.mm: (WebKit::PDFPluginChoiceAnnotation::updateGeometry): * Source/WebKit/WebProcess/Plugins/PDF/PDFPluginTextAnnotation.mm: (WebKit::PDFPluginTextAnnotation::updateGeometry): * Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.h: * Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm: (WebKit::UnifiedPDFPlugin::contentScaleFactor const): (WebKit::UnifiedPDFPlugin::updateSnapOffsets): (WebKit::UnifiedPDFPlugin::searchInDictionary): Canonical link: https://commits.webkit.org/275264@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] ec9dc0: REGRESSION (274945@main): [ MacOS ] Multiple editi...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: ec9dc084575a80af1fa675a50e0c2026c44f2b54 https://github.com/WebKit/WebKit/commit/ec9dc084575a80af1fa675a50e0c2026c44f2b54 Author: Alan Baradlay Date: 2024-02-23 (Fri, 23 Feb 2024) Changed paths: M LayoutTests/platform/mac-ventura/editing/selection/3690703-2-expected.txt M LayoutTests/platform/mac-ventura/editing/selection/3690703-expected.txt M LayoutTests/platform/mac-ventura/editing/selection/3690719-expected.txt Log Message: --- REGRESSION (274945@main): [ MacOS ] Multiple editing/selection tests are constant failures https://bugs.webkit.org/show_bug.cgi?id=269955 Unreviewed test gardening. * LayoutTests/platform/mac-ventura/editing/selection/3690703-2-expected.txt: * LayoutTests/platform/mac-ventura/editing/selection/3690703-expected.txt: * LayoutTests/platform/mac-ventura/editing/selection/3690719-expected.txt: Canonical link: https://commits.webkit.org/275263@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] a78127: [Cocoa] Audio distortion during media playback whe...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: a78127adb38a402b5d0fe6b17367aba32a38eb22 https://github.com/WebKit/WebKit/commit/a78127adb38a402b5d0fe6b17367aba32a38eb22 Author: Jer Noble Date: 2024-02-23 (Fri, 23 Feb 2024) Changed paths: M Source/WebCore/Headers.cmake M Source/WebCore/Sources.txt M Source/WebCore/WebCore.xcodeproj/project.pbxproj A Source/WebCore/platform/audio/SharedAudioDestination.cpp A Source/WebCore/platform/audio/SharedAudioDestination.h M Source/WebCore/platform/audio/cocoa/AudioDestinationCocoa.cpp M Source/WebCore/platform/graphics/MediaSourcePrivate.cpp M Source/WebKit/WebProcess/GPU/media/WebMediaStrategy.cpp Log Message: --- [Cocoa] Audio distortion during media playback when many AudioContexts are created https://bugs.webkit.org/show_bug.cgi?id=269833 rdar://122590884 Reviewed by Chris Dumez. In WebKit, each AudioContext created results in an additional thread serving that context's AudioDestination. (In WebKitLegacy, each AudioContext will result in an additional AudioOutputUnit running on a single high-priority audio thread.) When many threads (or AudioOutputUnits) are created, the overhead alone can cause underruns. And when this happens on the high-priority audio thread, it affects all audio playback within that process. Rather than create new threads or AudioOutputUnits (that are all rendering on the same thread to the same buffer in the end) for each AudioContext, a shared AudioDestination can be used for multiple AudioContext's with the same number of channels and sample rate. For common scenarios, this means only one high-priority audio thread will be created and serviced by a single AudioDestination. Specifically for WebKit, it means a single RemoteAudioDestination/Proxy pair for each WebContent process. * Source/WebCore/platform/audio/SharedAudioDestination.cpp: Added. (WebCore::SharedAudioDestinationAdapter::framesPerBuffer const): (WebCore::SharedAudioDestinationAdapter::sharedMap): (WebCore::SharedAudioDestinationAdapter::ensureAdapter): (WebCore::SharedAudioDestinationAdapter::SharedAudioDestinationAdapter): (WebCore::m_configurationSemaphore): (WebCore::SharedAudioDestinationAdapter::addRenderer): (WebCore::SharedAudioDestinationAdapter::removeRenderer): (WebCore::SharedAudioDestinationAdapter::configureRenderThread): (WebCore::SharedAudioDestinationAdapter::render): (WebCore::SharedAudioDestination::create): (WebCore::SharedAudioDestination::SharedAudioDestination): (WebCore::SharedAudioDestination::~SharedAudioDestination): (WebCore::SharedAudioDestination::start): (WebCore::SharedAudioDestination::stop): (WebCore::SharedAudioDestination::framesPerBuffer const): (WebCore::SharedAudioDestination::setIsPlaying): * Source/WebCore/platform/audio/SharedAudioDestination.h: Added. * Source/WebCore/platform/audio/cocoa/AudioDestinationCocoa.cpp: (WebCore::AudioDestination::create): * Source/WebKit/WebProcess/GPU/media/WebMediaStrategy.cpp: (WebKit::WebMediaStrategy::createAudioDestination): Canonical link: https://commits.webkit.org/275262@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 9df0e9: [Gardening]: REGRESSION (275227@main): [ macOS wk2...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 9df0e928b75bf7efd8030e1f7a2a2c2a6a51f372 https://github.com/WebKit/WebKit/commit/9df0e928b75bf7efd8030e1f7a2a2c2a6a51f372 Author: Marta Darbinyan Date: 2024-02-23 (Fri, 23 Feb 2024) Changed paths: M LayoutTests/platform/mac-wk2/TestExpectations Log Message: --- [Gardening]: REGRESSION (275227@main): [ macOS wk2 Debug ] ASSERTION FAILED fixedPositionContainerLayer result of 5 tests in imported/w3c/web-platform-tests/css/css-view-transitions to flaky crash or constant failure https://bugs.webkit.org/show_bug.cgi?id=270014 rdar://123530456 Unreviewed test gardening. Adding test expectation * LayoutTests/platform/mac-wk2/TestExpectations: Canonical link: https://commits.webkit.org/275261@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] f1618b: [build.webkit.org] Replace shell.Test with shell.T...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: f1618b20c06ce81c30f4d2913338d74d52962b89 https://github.com/WebKit/WebKit/commit/f1618b20c06ce81c30f4d2913338d74d52962b89 Author: Jonathan Bedard Date: 2024-02-23 (Fri, 23 Feb 2024) Changed paths: M Tools/CISupport/build-webkit-org/steps.py Log Message: --- [build.webkit.org] Replace shell.Test with shell.TestNewStyle (Follow-up fix) https://bugs.webkit.org/show_bug.cgi?id=256970 rdar://109516328 Unreviewed follow-up fix. * Tools/CISupport/build-webkit-org/steps.py: (RunGLibAPITests.run): Move "evaluateCommand" computation into "run" (RunGLibAPITests.evaluateCommand): Deleted. Canonical link: https://commits.webkit.org/275260@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] decca7: Unreviewed, reverting 275218@main
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: decca72b1b0a68cf80b236eb182674d384aec57a https://github.com/WebKit/WebKit/commit/decca72b1b0a68cf80b236eb182674d384aec57a Author: Marta Darbinyan Date: 2024-02-23 (Fri, 23 Feb 2024) Changed paths: M Source/WebKit/CMakeLists.txt M Source/WebKit/DerivedSources-input.xcfilelist M Source/WebKit/DerivedSources.make M Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.cpp M Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.h M Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.messages.in M Source/WebKit/Shared/NetworkProcessConnectionParameters.h M Source/WebKit/Shared/NetworkProcessConnectionParameters.serialization.in R Source/WebKit/Shared/NetworkProcessPreferencesForWebProcess.h R Source/WebKit/Shared/NetworkProcessPreferencesForWebProcess.serialization.in M Source/WebKit/UIProcess/API/APIPageConfiguration.cpp M Source/WebKit/UIProcess/API/APIPageConfiguration.h M Source/WebKit/UIProcess/Network/NetworkProcessProxy.cpp M Source/WebKit/UIProcess/SuspendedPageProxy.cpp M Source/WebKit/UIProcess/WebPageProxy.cpp M Source/WebKit/UIProcess/WebPageProxy.h M Source/WebKit/UIProcess/WebProcessCache.cpp M Source/WebKit/UIProcess/WebProcessPool.cpp M Source/WebKit/UIProcess/WebProcessPool.h M Source/WebKit/UIProcess/WebProcessProxy.cpp M Source/WebKit/UIProcess/WebProcessProxy.h M Source/WebKit/WebKit.xcodeproj/project.pbxproj M Source/WebKit/WebProcess/Network/NetworkProcessConnection.cpp M Source/WebKit/WebProcess/Network/WebTransportSession.cpp M Source/WebKit/WebProcess/WebPage/WebPage.cpp M Source/WebKit/WebProcess/WebPage/WebPage.h M Source/WebKit/WebProcess/WebProcess.cpp M Source/WebKit/WebProcess/WebProcess.h Log Message: --- Unreviewed, reverting 275218@main https://bugs.webkit.org/show_bug.cgi?id=270009 rdar://123528750 breaks API tests Reverted change: Disable Web Transport-related IPC endpoints when the feature is disabled at runtime https://bugs.webkit.org/show_bug.cgi?id=269742 rdar://122108912 https://commits.webkit.org/275218@main Canonical link: https://commits.webkit.org/275259@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 421383: [IFC][Ruby] Text is clipped at the bottom on some ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 421383510002ad187fe1e8de081a92463b09b9e0 https://github.com/WebKit/WebKit/commit/421383510002ad187fe1e8de081a92463b09b9e0 Author: Alan Baradlay Date: 2024-02-23 (Fri, 23 Feb 2024) Changed paths: A LayoutTests/fast/ruby/overhang-with-justified-content-in-vertical-mode-incorrect-size-expected.html A LayoutTests/fast/ruby/overhang-with-justified-content-in-vertical-mode-incorrect-size.html M Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayContentBuilder.cpp Log Message: --- [IFC][Ruby] Text is clipped at the bottom on some pages in Books https://bugs.webkit.org/show_bug.cgi?id=270002 Reviewed by Antti Koivisto. Justified text runs are expanded on the wrong axis in vertical writing mode. * LayoutTests/fast/ruby/overhang-with-justified-content-in-vertical-mode-incorrect-size-expected.html: Added. * LayoutTests/fast/ruby/overhang-with-justified-content-in-vertical-mode-incorrect-size.html: Added. * Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayContentBuilder.cpp: (WebCore::Layout::InlineDisplayContentBuilder::applyRubyOverhang): Canonical link: https://commits.webkit.org/275258@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] be2536: [Gardening]: REGRESSION (274957@main): [ MacOS iOS...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: be2536cda23e2caa7e19cd5cc2153d6c60c62c5b https://github.com/WebKit/WebKit/commit/be2536cda23e2caa7e19cd5cc2153d6c60c62c5b Author: Jay Stfleur Date: 2024-02-23 (Fri, 23 Feb 2024) Changed paths: M LayoutTests/platform/mac-wk2/TestExpectations Log Message: --- [Gardening]: REGRESSION (274957@main): [ MacOS iOS Debug wk2 ] 2x imported/w3c/web-platform-tests/css/css-view-transitions tests are constant crash https://bugs.webkit.org/show_bug.cgi?id=123266095 rdar://123266095 Unreviewed test gardening. Removing Title from folder as Test Expectations was moved. * LayoutTests/platform/mac-wk2/TestExpectations: Canonical link: https://commits.webkit.org/275257@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 617715: [JSC] Clean up CallLinkInfo::unlinlkOrUpgradeImpl ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 617715243dc578fef6ca3a32ab2cb017e8e1deb5 https://github.com/WebKit/WebKit/commit/617715243dc578fef6ca3a32ab2cb017e8e1deb5 Author: Yusuke Suzuki Date: 2024-02-23 (Fri, 23 Feb 2024) Changed paths: M Source/JavaScriptCore/bytecode/CallLinkInfo.cpp M Source/JavaScriptCore/bytecode/Repatch.cpp Log Message: --- [JSC] Clean up CallLinkInfo::unlinlkOrUpgradeImpl to make `remove` consistent https://bugs.webkit.org/show_bug.cgi?id=270004 rdar://122611742 Reviewed by Alexey Shvayka. 1. In CallLinkInfo::unlinkOrUpgradeImpl, let's always start with removing it from the list. If we upgrade, we anyway re-chain it to the new CodeBlock. So there is no possible case that we would like to keep the current link. 2. Let's make linked / unlinked state consistent more by moving `remove` code inside CallLinkInfo itself. And always check `isOnList` before calling it. * Source/JavaScriptCore/bytecode/CallLinkInfo.cpp: (JSC::CallLinkInfo::unlinkOrUpgradeImpl): (JSC::CallLinkInfo::setStub): * Source/JavaScriptCore/bytecode/Repatch.cpp: (JSC::linkPolymorphicCall): Canonical link: https://commits.webkit.org/275256@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 3790f1: [JSC] Don't optimize String.prototype.replace for ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 3790f1e3cc0a7b0e02528d3440e588a491b28be4 https://github.com/WebKit/WebKit/commit/3790f1e3cc0a7b0e02528d3440e588a491b28be4 Author: Sosuke Suzuki Date: 2024-02-23 (Fri, 23 Feb 2024) Changed paths: A JSTests/stress/string-replace-regexp-deopt-lastindex.js M Source/JavaScriptCore/dfg/DFGFixupPhase.cpp Log Message: --- [JSC] Don't optimize String.prototype.replace for RegExp searchValue with non-numeric lastIndex. https://bugs.webkit.org/show_bug.cgi?id=246274 Reviewed by Alexey Shvayka. In DFGByteCodeParser, String.prototype.replace with a RegExp object as searchValue is inlined into a StringReplace node. So after DFG, lastIndex is no longer read and updated. Therefore, searchValue.lastIndex.toString is no longer invoked. This patch changes the code so that it doesn't inline if searchValue.lastIndex isn't numeric. https://tc39.es/ecma262/#sec-string.prototype.replace * JSTests/stress/string-replace-regexp-deopt-lastindex.js: Added. (shouldBe): (foo.regexLastIndex.toString): (foo): * Source/JavaScriptCore/dfg/DFGFixupPhase.cpp: (JSC::DFG::FixupPhase::addStringReplacePrimordialChecks): Canonical link: https://commits.webkit.org/275255@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 8e5cdd: Try to fix the visionOS build
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 8e5cdd60e829600d8d6f15121f73d0cafa897974 https://github.com/WebKit/WebKit/commit/8e5cdd60e829600d8d6f15121f73d0cafa897974 Author: Andy Estes Date: 2024-02-23 (Fri, 23 Feb 2024) Changed paths: M Source/WebKit/WebKitSwift/LinearMediaKit/LinearMediaPlayer.swift M Source/WebKit/WebKitSwift/LinearMediaKit/LinearMediaTypes.swift Log Message: --- Try to fix the visionOS build https://bugs.webkit.org/show_bug.cgi?id=269998 rdar://123520955 Unreviewed build fix for visionOS SDKs that do not have required LinearMediaKit APIs. * Source/WebKit/WebKitSwift/LinearMediaKit/LinearMediaPlayer.swift: (WKSLinearMediaPlayer.makeViewController): (WKSLinearMediaPlayer.makeDefaultEntity): * Source/WebKit/WebKitSwift/LinearMediaKit/LinearMediaTypes.swift: Canonical link: https://commits.webkit.org/275254@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] c6069f: [UnifiedPDF] Flashing when interacting with form c...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: c6069f49ce6b011ecf978e53ce4875f39cea3727 https://github.com/WebKit/WebKit/commit/c6069f49ce6b011ecf978e53ce4875f39cea3727 Author: Simon Fraser Date: 2024-02-23 (Fri, 23 Feb 2024) Changed paths: M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/AsyncPDFRenderer.h M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/AsyncPDFRenderer.mm M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm Log Message: --- [UnifiedPDF] Flashing when interacting with form controls https://bugs.webkit.org/show_bug.cgi?id=269958 rdar://123479307 Reviewed by Tim Horton. Currently when PDF content is invalidated (e.g. by a form control action) we throw away the rendered tiles for that rect, and asynchronously regenerate them. That results in flashes. Instead, we can keep the existing tile, and update it from a asynchronously-rendered buffer containing the invalidated rect for that tile. This means that paints may use a stale tile, but that's better than flashing. * Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/AsyncPDFRenderer.h: * Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/AsyncPDFRenderer.mm: (WebKit::AsyncPDFRenderer::paintingToTileTransform): (WebKit::AsyncPDFRenderer::enqueuePaintWithClip): (WebKit::AsyncPDFRenderer::paintTileOnWorkQueue): (WebKit::AsyncPDFRenderer::paintPDFIntoBuffer): (WebKit::AsyncPDFRenderer::transferBufferToMainThread): (WebKit::AsyncPDFRenderer::didCompleteNewTileRender): (WebKit::AsyncPDFRenderer::didCompleteTileUpdateRender): (WebKit::AsyncPDFRenderer::updateTilesForPaintingRect): * Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm: (WebKit::UnifiedPDFPlugin::setNeedsRepaintInDocumentRect): Canonical link: https://commits.webkit.org/275253@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 3832d8: [Gardening]: REGRESSION ( 275227@main?): [ MacOS D...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 3832d8ef60666b50d8e827bdc044290ec5f989af https://github.com/WebKit/WebKit/commit/3832d8ef60666b50d8e827bdc044290ec5f989af Author: Jay Stfleur Date: 2024-02-23 (Fri, 23 Feb 2024) Changed paths: M LayoutTests/platform/mac-wk2/TestExpectations Log Message: --- [Gardening]: REGRESSION ( 275227@main?): [ MacOS Debug ] imported/w3c/web-platform-tests/css/css-view-transitions/offscreen-element-modified-before-coming-onscreen.html is a constant crash https://bugs.webkit.org/show_bug.cgi?id=123516775 rdar://123516775 Unreviewed test gardening. Adding test expectation * LayoutTests/platform/mac-wk2/TestExpectations: Canonical link: https://commits.webkit.org/275252@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 229250: Rework WebPageProxy::creationParameters function p...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 229250e6cd7fa24eab4423c217c814d977dc60e7 https://github.com/WebKit/WebKit/commit/229250e6cd7fa24eab4423c217c814d977dc60e7 Author: Gerald Squelart Date: 2024-02-23 (Fri, 23 Feb 2024) Changed paths: M Source/WebKit/Shared/WebPageCreationParameters.h M Source/WebKit/Shared/WebPageCreationParameters.serialization.in M Source/WebKit/UIProcess/ProvisionalPageProxy.cpp M Source/WebKit/UIProcess/RemotePageProxy.cpp M Source/WebKit/UIProcess/WebPageProxy.cpp M Source/WebKit/UIProcess/WebPageProxy.h Log Message: --- Rework WebPageProxy::creationParameters function parameters https://bugs.webkit.org/show_bug.cgi?id=269823 rdar://116201784 Reviewed by Alex Christensen. Two calls to WebPageProxy::creationParameters() modify the parameters before using them in messages. These calls are now forced to instead provide all the necessary information at once, and the returned WebPageCreationParameters shouldn't need any further modifications. * Source/WebKit/Shared/WebPageCreationParameters.h: * Source/WebKit/Shared/WebPageCreationParameters.serialization.in: The SubframeProcessPageParameters struct definition has been moved outside of WebPageCreationParameters, so that a forward declaration is enough when declaring WebPageProxy::creationParameters. * Source/WebKit/UIProcess/WebPageProxy.h: * Source/WebKit/UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::creationParameters): (WebKit::WebPageProxy::creationParametersForProvisionalPage): (WebKit::WebPageProxy::creationParametersForRemotePage): Added new function parameters, as needed for provisional and remote pages, and helper functions that only take the minimum required parameters. * Source/WebKit/UIProcess/ProvisionalPageProxy.cpp: (WebKit::ProvisionalPageProxy::initializeWebPage): Using the updated WebPageProxy::creationParameters function. Since it doesn't require doctoring, it can be used directly in the message creation. Also, the call may be delayed until & if it is actually needed. * Source/WebKit/UIProcess/RemotePageProxy.cpp: (WebKit::RemotePageProxy::injectPageIntoNewProcess): Using the updated WebPageProxy::creationParameters function. Since it doesn't require doctoring, it can be used directly in the message creation. Canonical link: https://commits.webkit.org/275251@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 782788: [Gardening]: NEW TEST [ MacOS ] imported/w3c/web-p...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 782788038688a248a4552b0050cec5a7f0e5767c https://github.com/WebKit/WebKit/commit/782788038688a248a4552b0050cec5a7f0e5767c Author: Jay Stfleur Date: 2024-02-23 (Fri, 23 Feb 2024) Changed paths: M LayoutTests/platform/mac-wk2/TestExpectations Log Message: --- [Gardening]: NEW TEST [ MacOS ] imported/w3c/web-platform-tests/media-source/dedicated-worker/mediasource-worker-detach-element.html is a flaky crash https://bugs.webkit.org/show_bug.cgi?id=123404489 rdar://123404489 Unreviewed test gardening. Adding test expectation * LayoutTests/platform/mac-wk2/TestExpectations: Canonical link: https://commits.webkit.org/275250@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] c9a926: [css-grid] Turn masonry feature off-by-default on ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: c9a9269b077fd8712363b519b8bca7c73478b5b5 https://github.com/WebKit/WebKit/commit/c9a9269b077fd8712363b519b8bca7c73478b5b5 Author: Brent Fulgham Date: 2024-02-23 (Fri, 23 Feb 2024) Changed paths: M Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml Log Message: --- [css-grid] Turn masonry feature off-by-default on non-Cocoa builds https://bugs.webkit.org/show_bug.cgi?id=269939 Reviewed by Tim Nguyen. In Bug 247074 we moved the Masonry feature flag from preview to stable. While the Cocoa build of WebKit needs the feature to be on by default at the moment, we do not need to toggle the feature for other ports. This patch leaves the Cocoa port enabled, but switches the default for non-Cocoa ports back off. * Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml: Canonical link: https://commits.webkit.org/275249@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 619674: Add more fallback logic for the name of a browser ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 6196748e4b8469493d488992d5dd1f38e6312624 https://github.com/WebKit/WebKit/commit/6196748e4b8469493d488992d5dd1f38e6312624 Author: Brian Weinstein Date: 2024-02-23 (Fri, 23 Feb 2024) Changed paths: M Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionCocoa.mm M Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionCommandCocoa.mm Log Message: --- Add more fallback logic for the name of a browser action keyboard shortcut https://bugs.webkit.org/show_bug.cgi?id=269997 rdar://123455683 Reviewed by Timothy Hatcher. This change: 1) Makes it so we don't crash if a command has an empty name or description 2) Falls back to the display name for _execute_browser_action if no action title is specified * Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionCocoa.mm: (WebKit::WebExtension::populateCommandsIfNeeded): * Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionCommandCocoa.mm: (+[_WKWebExtensionKeyCommand commandWithTitle:image:input:modifierFlags:handler:]): Canonical link: https://commits.webkit.org/275248@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 7498f7: [build.webkit.org] Replace shell.Test with shell.T...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 7498f7a026b40c149165a11ffe84f0d525429272 https://github.com/WebKit/WebKit/commit/7498f7a026b40c149165a11ffe84f0d525429272 Author: Jonathan Bedard Date: 2024-02-23 (Fri, 23 Feb 2024) Changed paths: M Tools/CISupport/build-webkit-org/steps.py Log Message: --- [build.webkit.org] Replace shell.Test with shell.TestNewStyle (Follow-up fix) https://bugs.webkit.org/show_bug.cgi?id=256970 rdar://109516328 Unreviewed follow-up fix. * Tools/CISupport/build-webkit-org/steps.py: (RunWebDriverTests.run): Correct syntax error in function call. Canonical link: https://commits.webkit.org/275247@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 298785: Fix build issues around PALSwift.h header
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 29878520d567ad1242cc14257eb8dbb46b08ab93 https://github.com/WebKit/WebKit/commit/29878520d567ad1242cc14257eb8dbb46b08ab93 Author: nmahendru Date: 2024-02-23 (Fri, 23 Feb 2024) Changed paths: M Source/WebCore/WebCore.xcodeproj/project.pbxproj Log Message: --- Fix build issues around PALSwift.h header rdar://123514935 Reviewed by Jonathan Bedard. A few of the builds are structured in a way that assuming the directory `PAL.build` to be right where it usually is not feasible. So this relaxes that but still should manage to get the right header. * Source/WebCore/WebCore.xcodeproj/project.pbxproj: Canonical link: https://commits.webkit.org/275246@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 1c1624: [CMake] Centralize Nicosia sources
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 1c162458ba708e0aba191d5e2e4b0c81466426d7 https://github.com/WebKit/WebKit/commit/1c162458ba708e0aba191d5e2e4b0c81466426d7 Author: Don Olmstead Date: 2024-02-23 (Fri, 23 Feb 2024) Changed paths: M Source/WebCore/PlatformPlayStation.cmake M Source/WebCore/SourcesGTK.txt M Source/WebCore/SourcesWPE.txt A Source/WebCore/platform/SourcesNicosia.txt M Source/WebCore/platform/TextureMapper.cmake M Source/WebCore/platform/graphics/nicosia/NicosiaGCGLANGLELayer.cpp M Source/WebCore/platform/graphics/nicosia/NicosiaGCGLANGLELayer.h Log Message: --- [CMake] Centralize Nicosia sources https://bugs.webkit.org/show_bug.cgi?id=269935 Reviewed by Adrian Perez de Castro. Move `USE(NICOSIA)` sources into `SourcesNicosia.txt`. Some are unable to be moved because they will break the `USE(SKIA)` build. Organize the `TextureMapper.cmake` file to check for `USE_NICOSIA`. Fix some guards around ANGLE code. * Source/WebCore/PlatformPlayStation.cmake: * Source/WebCore/SourcesGTK.txt: * Source/WebCore/SourcesWPE.txt: * Source/WebCore/platform/SourcesNicosia.txt: Added. * Source/WebCore/platform/TextureMapper.cmake: * Source/WebCore/platform/graphics/nicosia/NicosiaGCGLANGLELayer.cpp: * Source/WebCore/platform/graphics/nicosia/NicosiaGCGLANGLELayer.h: Canonical link: https://commits.webkit.org/275245@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] d97f5a: getUserMedia camera stream lost on history pushSta...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: d97f5a09e4f10a05d93ad47f08ac293180c75f77 https://github.com/WebKit/WebKit/commit/d97f5a09e4f10a05d93ad47f08ac293180c75f77 Author: Andy Estes Date: 2024-02-23 (Fri, 23 Feb 2024) Changed paths: M Source/WebKit/Platform/cocoa/MediaCapability.h M Source/WebKit/Platform/cocoa/MediaCapability.mm M Source/WebKit/UIProcess/Cocoa/WebPageProxyCocoa.mm M Source/WebKit/UIProcess/WebPageProxy.cpp M Source/WebKit/UIProcess/WebPageProxy.h M Source/WebKit/WebKit.xcodeproj/project.pbxproj Log Message: --- getUserMedia camera stream lost on history pushState in iOS 17.4 Beta 4 https://bugs.webkit.org/show_bug.cgi?id=269846 rdar://123381737 Reviewed by Eric Carlson and Youenn Fablet. When WebKit adopted media capability grants for camera capture we chose to tie the lifetime of the media environment to the top frame document's current URL, such that if the URL changes (ignoring fragment identifiers) then the current media environment is destroyed and a new one is created. If a capture session is active when the media environment changes then the system will pause the capture session as it's no longer associated with the current media environment. The logic of comparing URLs was meant as a proxy for detecting cross-document navigations but failed to account for same-document navigations that changed the path of the current URL (e.g., via pushState). Since the origin associated with the media environment does not change during a same-document navigation there is no need to recreate the media environment. Addressed this by moving the logic for creating and destroying media environments to WebPageProxy::didChangeMainDocument. Further, since only the top document's origin is displayed to the user in iOS's privacy accounting UI, changed MediaCapability to only track a SecurityOrigin. The logic for when to activate and deactivate a media environment's capability remains unchanged. Manually verified that this resolves the issue reported in bug #269846. Unfortunately no new tests are possible since the underlying platform support for media capabilities is not available in iOS Simulator. * Source/WebKit/Platform/cocoa/MediaCapability.h: * Source/WebKit/Platform/cocoa/MediaCapability.mm: (WebKit::MediaCapability::MediaCapability): (WebKit::m_mediaEnvironment): (WebKit::MediaCapability::registrableDomain const): Deleted. * Source/WebKit/UIProcess/Cocoa/WebPageProxyCocoa.mm: (WebKit::WebPageProxy::setMediaCapability): (WebKit::WebPageProxy::deactivateMediaCapability): (WebKit::WebPageProxy::resetMediaCapability): (WebKit::WebPageProxy::updateMediaCapability): * Source/WebKit/UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::didCommitLoadForFrame): (WebKit::WebPageProxy::didChangeMainDocument): * Source/WebKit/UIProcess/WebPageProxy.h: * Source/WebKit/WebKit.xcodeproj/project.pbxproj: Canonical link: https://commits.webkit.org/275244@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] e33391: [ Monterey+ wk2 ] imported/w3c/web-platform-tests/...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: e33391b688bac2c4e3374778e2314efd99735de2 https://github.com/WebKit/WebKit/commit/e33391b688bac2c4e3374778e2314efd99735de2 Author: Youenn Fablet Date: 2024-02-23 (Fri, 23 Feb 2024) Changed paths: M LayoutTests/platform/mac-wk2/TestExpectations M Source/ThirdParty/libwebrtc/Source/webrtc/sdk/WebKit/VideoProcessingSoftLink.h M Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/components/video_codec/RTCVideoEncoderH264.mm Log Message: --- [ Monterey+ wk2 ] imported/w3c/web-platform-tests/webrtc/RTCPeerConnection-GC.https.html is a flaky text failure https://bugs.webkit.org/show_bug.cgi?id=268098 rdar://121613695 Reviewed by Eric Carlson. On Intel x86, the VCP code path is not supporting resolution below 192x108. We resort on SW code path using usage = 1, until the OS supports it. * LayoutTests/platform/mac-wk2/TestExpectations: * Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/components/video_codec/RTCVideoEncoderH264.mm: (-[RTCVideoEncoderH264 resetCompressionSessionWithPixelFormat:]): Canonical link: https://commits.webkit.org/275243@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 3fbaad: Add support for dumping GC heap snapshots of Workers
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 3fbaadfcd9305751f242411149c68dfd2f4c1ed9 https://github.com/WebKit/WebKit/commit/3fbaadfcd9305751f242411149c68dfd2f4c1ed9 Author: Sihui Liu Date: 2024-02-23 (Fri, 23 Feb 2024) Changed paths: M Source/WebCore/bindings/js/GCController.cpp M Source/WebCore/bindings/js/GCController.h M Source/WebCore/workers/WorkerGlobalScope.cpp M Source/WebCore/workers/WorkerGlobalScope.h Log Message: --- Add support for dumping GC heap snapshots of Workers https://bugs.webkit.org/show_bug.cgi?id=269853 rdar://123390121 Reviewed by Simon Fraser. This will help us understand memory usuage for Workers. * Source/WebCore/bindings/js/GCController.cpp: (WebCore::GCController::dumpHeapForVM): (WebCore::GCController::dumpHeap): * Source/WebCore/bindings/js/GCController.h: * Source/WebCore/workers/WorkerGlobalScope.cpp: (WebCore::WorkerGlobalScope::dumpGCHeapForWorkers): * Source/WebCore/workers/WorkerGlobalScope.h: Canonical link: https://commits.webkit.org/275242@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] d11c7e: [WPE] Enable autoplay and WebRTC in MiniBrowser
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: d11c7e88e250b8266e38c729da505e2f9b1f98d4 https://github.com/WebKit/WebKit/commit/d11c7e88e250b8266e38c729da505e2f9b1f98d4 Author: Olivier Blin Date: 2024-02-23 (Fri, 23 Feb 2024) Changed paths: M Tools/MiniBrowser/wpe/main.cpp Log Message: --- [WPE] Enable autoplay and WebRTC in MiniBrowser https://bugs.webkit.org/show_bug.cgi?id=269920 Reviewed by Michael Catanzaro. Before 264689@main, the autoplay setting was not properly applied and was always WEBKIT_AUTOPLAY_ALLOW for WPE. Now, the default setting of WEBKIT_AUTOPLAY_ALLOW_WITHOUT_SOUND is really applied. This prevents some pages with minimal UI from playing videos, and MiniBrowser does not have the UI to enable autoplay. It is easier to enable it by default. Also enable WebRTC, which has been made opt-in in 251951@main, and now needs to be enabled in addition to MediaStream. * Tools/MiniBrowser/wpe/main.cpp: (activate): Canonical link: https://commits.webkit.org/275241@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] c1124e: [iOS] Flash of black while exiting fullscreen on y...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: c1124e4e8f4c4e7282afba3960ac02126b1fa8fc https://github.com/WebKit/WebKit/commit/c1124e4e8f4c4e7282afba3960ac02126b1fa8fc Author: Jer Noble Date: 2024-02-23 (Fri, 23 Feb 2024) Changed paths: M Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenWindowControllerIOS.mm Log Message: --- [iOS] Flash of black while exiting fullscreen on youtube.com https://bugs.webkit.org/show_bug.cgi?id=269969 rdar://117708957 Reviewed by Jean-Yves Avenard. A single frame of black is sometimes shown when exiting fullscreen, after the fullscreen animation completes, but before the WKWebView is visible in its full inline state. Debugging shows this is due to the call to -makeKeyAndVisible in -_reinsertWebViewUnderPlaceholder. It's not clear why making the WKWebView's parent window key and visible causes a black flash, but it's also unnecessary at this point in the animation. Additionally, none of the operations in -_completedExitFullScreen are wrapped in a CATransaction, so add one that commits once the WKWebView has finished the repaint after re-inserting it in its original window. Additionally, Safari will steal the WKWebView out of its fullscreen presentation during layout, so long as -[WKFullScreenWindowController isFullScreen] returns false. So modify the meaning of that property to include "WaitingToExit" and "ExitingFullscreen", preventing Safari from stealing the view until the fullscreen animation completes. * Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenWindowControllerIOS.mm: (-[WKFullScreenWindowController _reinsertWebViewUnderPlaceholder]): (-[WKFullScreenWindowController _completedExitFullScreen]): Canonical link: https://commits.webkit.org/275240@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 6bf54f: [ iOS ] imported/w3c/web-platform-tests/feature-po...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 6bf54f097d979fa59538fd1cc6489ca8d411e4d3 https://github.com/WebKit/WebKit/commit/6bf54f097d979fa59538fd1cc6489ca8d411e4d3 Author: Chris Dumez Date: 2024-02-23 (Fri, 23 Feb 2024) Changed paths: M LayoutTests/platform/ipad/TestExpectations A LayoutTests/platform/ipad/imported/w3c/web-platform-tests/feature-policy/reporting/picture-in-picture-reporting-expected.txt Log Message: --- [ iOS ] imported/w3c/web-platform-tests/feature-policy/reporting/picture-in-picture-reporting.html is a constant failure https://bugs.webkit.org/show_bug.cgi?id=269926 rdar://123454189 Unreviewed, land an iPad-specific baseline for this test. * LayoutTests/platform/ipad/TestExpectations: * LayoutTests/platform/ipad/imported/w3c/web-platform-tests/feature-policy/reporting/picture-in-picture-reporting-expected.txt: Added. Canonical link: https://commits.webkit.org/275239@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 53197e: [build.webkit.org] Report DNS name, not HOSTNAME t...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 53197ed1596b020918bbc8daadda1be875388c14 https://github.com/WebKit/WebKit/commit/53197ed1596b020918bbc8daadda1be875388c14 Author: Jonathan Bedard Date: 2024-02-23 (Fri, 23 Feb 2024) Changed paths: M Tools/CISupport/build-webkit-org/steps.py Log Message: --- [build.webkit.org] Report DNS name, not HOSTNAME to results.webkit.org https://bugs.webkit.org/show_bug.cgi?id=269990 rdar://123508951 Reviewed by Aakash Jain. * Tools/CISupport/build-webkit-org/steps.py: (RunJavaScriptCoreTests): Use DNS_NAME instead of CURRENT_HOSTNAME. (RunWebKitTests): Ditto. (RunAPITests): Ditto. (RunWebKitPyTests): Ditto. (RunLLINTCLoopTests): Ditto. (Run32bitJSCTests): Ditto. Canonical link: https://commits.webkit.org/275238@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 33172d: getOutputTimestamp() seems to use wrong time scale
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 33172dfe163a1a3445e76b23bc9a9b705516fc11 https://github.com/WebKit/WebKit/commit/33172dfe163a1a3445e76b23bc9a9b705516fc11 Author: Chris Dumez Date: 2024-02-23 (Fri, 23 Feb 2024) Changed paths: A LayoutTests/webaudio/getOutputTimestamp-expected.txt A LayoutTests/webaudio/getOutputTimestamp.html M Source/WebCore/platform/audio/AudioDestinationResampler.cpp Log Message: --- getOutputTimestamp() seems to use wrong time scale https://bugs.webkit.org/show_bug.cgi?id=264247 rdar://118323705 Reviewed by Eric Carlson. The time returned by getOutputTimestamp() was incorrectly divided by the sample rate. Fix this so the value returned is correct and matches Chrome and Firefox. * LayoutTests/webaudio/getOutputTimestamp-expected.txt: Added. * LayoutTests/webaudio/getOutputTimestamp.html: Added. * Source/WebCore/platform/audio/AudioDestinationResampler.cpp: (WebCore::AudioDestinationResampler::render): Canonical link: https://commits.webkit.org/275237@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 262c7e: Preserve whitespace when serializing custom proper...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 262c7e61cab2ef3cdeeab58d28d932aafc4cac39 https://github.com/WebKit/WebKit/commit/262c7e61cab2ef3cdeeab58d28d932aafc4cac39 Author: Antti Koivisto Date: 2024-02-23 (Fri, 23 Feb 2024) Changed paths: M LayoutTests/css-custom-properties-api/crash.html M LayoutTests/css-custom-properties-api/inline.html M LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/at-container-style-serialization-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/custom-property-style-queries.html M LayoutTests/imported/w3c/web-platform-tests/css/css-syntax/custom-property-rule-ambiguity-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/css-variables/variable-cssText-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/css-variables/variable-definition-expected.txt M Source/WebCore/css/parser/CSSParserImpl.cpp M Source/WebCore/css/parser/CSSParserToken.cpp M Source/WebCore/css/parser/CSSParserToken.h M Source/WebCore/css/parser/CSSTokenizer.cpp Log Message: --- Preserve whitespace when serializing custom properties https://bugs.webkit.org/show_bug.cgi?id=269971 rdar://123491915 Reviewed by Anne van Kesteren. "Specified values of custom properties must be serialized exactly as specified by the author. Simplifications that might occur in other properties, such as dropping comments, normalizing whitespace, reserializing numeric tokens from their value, etc., must not occur." https://drafts.csswg.org/css-variables-2/#serializing-custom-props * LayoutTests/css-custom-properties-api/crash.html: * LayoutTests/css-custom-properties-api/inline.html Update the tests. Leading and trailing whitespaces should be trimmed also when using CSSStyleDeclaration.setProperty(). This matches other browsers. * LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/at-container-style-serialization-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/custom-property-style-queries.html: Fix a bug in this WPT. It was checking a wrong property and not testing anything. * LayoutTests/imported/w3c/web-platform-tests/css/css-syntax/custom-property-rule-ambiguity-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-variables/variable-cssText-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-variables/variable-definition-expected.txt: * Source/WebCore/css/parser/CSSParserImpl.cpp: (WebCore::CSSParserImpl::parseCustomPropertyValue): Also fix trimming of leading and trailing whitespace in CSSStyleDeclaration.setProperty() API. * Source/WebCore/css/parser/CSSParserToken.cpp: (WebCore::CSSParserToken::CSSParserToken): Remember the number of whitespaces represented by a whitespace token. (WebCore::CSSParserToken::operator== const): Also take the space count into account in equality comparison. This is used for custom properties only. (WebCore::CSSParserToken::serialize const): Preserve the spaces in custom property serialization mode. * Source/WebCore/css/parser/CSSParserToken.h: * Source/WebCore/css/parser/CSSTokenizer.cpp: (WebCore::CSSTokenizer::whiteSpace): Count the spaces. Canonical link: https://commits.webkit.org/275236@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 91dc14: [GStreamer][LibWebRTC] Conflict between two GStrea...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 91dc14fd908d68d00a582840163c1342f304efb3 https://github.com/WebKit/WebKit/commit/91dc14fd908d68d00a582840163c1342f304efb3 Author: Olivier Blin Date: 2024-02-23 (Fri, 23 Feb 2024) Changed paths: M Source/WebCore/platform/mediastream/libwebrtc/gstreamer/GStreamerVideoDecoderFactory.cpp Log Message: --- [GStreamer][LibWebRTC] Conflict between two GStreamerVideoDecoder classes can lead to crash https://bugs.webkit.org/show_bug.cgi?id=269915 Reviewed by Philippe Normand. In the GStreamer ports, there are two different implementations of the WebCore::GStreamerVideoDecoder class: - one for WebRTC in Source/WebCore/platform/mediastream/libwebrtc/gstreamer/GStreamerVideoDecoderFactory.cpp - one for WebCodecs in Source/WebCore/platform/graphics/gstreamer/VideoDecoderGStreamer.cpp This can lead to a crash in WebRTC usage, since the WebCore::GStreamerVideoDecoder destructor from the WebCodecs class can be mistakenly used instead of the one from the WebRTC class. Rename the WebRTC class as GStreamerWebRTCVideoDecoder. * Source/WebCore/platform/mediastream/libwebrtc/gstreamer/GStreamerVideoDecoderFactory.cpp: (WebCore::GStreamerWebRTCVideoDecoder::GStreamerWebRTCVideoDecoder): (WebCore::GStreamerVideoDecoder::GStreamerVideoDecoder): Deleted. (WebCore::GStreamerVideoDecoder::decodebinPadAddedCb): Deleted. (WebCore::GStreamerVideoDecoder::pipeline): Deleted. (WebCore::GStreamerVideoDecoder::makeElement): Deleted. (WebCore::GStreamerVideoDecoder::handleError): Deleted. (WebCore::GStreamerVideoDecoder::CreateFilter): Deleted. (WebCore::GStreamerVideoDecoder::pullSample): Deleted. (WebCore::GStreamerVideoDecoder::GetCapsForFrame): Deleted. (WebCore::GStreamerVideoDecoder::AddDecoderIfSupported): Deleted. (WebCore::GStreamerVideoDecoder::ConfigureSupportedDecoder): Deleted. (WebCore::GStreamerVideoDecoder::GstDecoderFactory): Deleted. (WebCore::GStreamerVideoDecoder::HasGstDecoder): Deleted. Canonical link: https://commits.webkit.org/275235@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] ca4cb0: [WGSL] Serialization of constant structs is not im...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: ca4cb03cffc676534681333693789bc5d7a159e8 https://github.com/WebKit/WebKit/commit/ca4cb03cffc676534681333693789bc5d7a159e8 Author: Tadeu Zagallo Date: 2024-02-23 (Fri, 23 Feb 2024) Changed paths: M Source/WebGPU/WGSL/AST/ASTStructureMember.h M Source/WebGPU/WGSL/Metal/MetalFunctionWriter.cpp Log Message: --- [WGSL] Serialization of constant structs is not implemented https://bugs.webkit.org/show_bug.cgi?id=269921 rdar://123445698 Reviewed by Mike Wyrzykowski. Constant structs were implemented in 275043@main, but serialization was missing. * Source/WebGPU/WGSL/AST/ASTStructureMember.h: * Source/WebGPU/WGSL/Metal/MetalFunctionWriter.cpp: (WGSL::Metal::FunctionDefinitionWriter::serializeConstant): Canonical link: https://commits.webkit.org/275234@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] ffdb8d: Migrate EventTarget to use EventTargetInterfaceTyp...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: ffdb8dd1da9260284b42045286910bf544d6bc97 https://github.com/WebKit/WebKit/commit/ffdb8dd1da9260284b42045286910bf544d6bc97 Author: Ryosuke Niwa Date: 2024-02-23 (Fri, 23 Feb 2024) Changed paths: M Source/WebCore/Modules/WebGPU/GPUDevice.h M Source/WebCore/Modules/applepay/ApplePaySession.h M Source/WebCore/Modules/async-clipboard/Clipboard.cpp M Source/WebCore/Modules/async-clipboard/Clipboard.h M Source/WebCore/Modules/audiosession/DOMAudioSession.h M Source/WebCore/Modules/cookie-store/CookieStore.cpp M Source/WebCore/Modules/cookie-store/CookieStore.h M Source/WebCore/Modules/encryptedmedia/MediaKeySession.h M Source/WebCore/Modules/encryptedmedia/legacy/WebKitMediaKeySession.h M Source/WebCore/Modules/indexeddb/IDBDatabase.h M Source/WebCore/Modules/indexeddb/IDBRequest.cpp M Source/WebCore/Modules/indexeddb/IDBRequest.h M Source/WebCore/Modules/indexeddb/IDBTransaction.h M Source/WebCore/Modules/mediarecorder/MediaRecorder.h M Source/WebCore/Modules/mediasession/MediaSessionCoordinator.h M Source/WebCore/Modules/mediasource/MediaSource.cpp M Source/WebCore/Modules/mediasource/MediaSource.h M Source/WebCore/Modules/mediasource/SourceBuffer.h M Source/WebCore/Modules/mediasource/SourceBufferList.h M Source/WebCore/Modules/mediastream/MediaDevices.h M Source/WebCore/Modules/mediastream/MediaStream.h M Source/WebCore/Modules/mediastream/MediaStreamTrack.h M Source/WebCore/Modules/mediastream/RTCDTMFSender.h M Source/WebCore/Modules/mediastream/RTCDataChannel.h M Source/WebCore/Modules/mediastream/RTCDtlsTransport.h M Source/WebCore/Modules/mediastream/RTCIceTransport.h M Source/WebCore/Modules/mediastream/RTCPeerConnection.h M Source/WebCore/Modules/mediastream/RTCRtpSFrameTransform.h M Source/WebCore/Modules/mediastream/RTCSctpTransport.h M Source/WebCore/Modules/notifications/Notification.h M Source/WebCore/Modules/paymentrequest/PaymentRequest.h M Source/WebCore/Modules/paymentrequest/PaymentResponse.h M Source/WebCore/Modules/permissions/PermissionStatus.h M Source/WebCore/Modules/pictureinpicture/PictureInPictureWindow.h M Source/WebCore/Modules/remoteplayback/RemotePlayback.h M Source/WebCore/Modules/screen-wake-lock/WakeLockSentinel.h M Source/WebCore/Modules/speech/SpeechRecognition.h M Source/WebCore/Modules/speech/SpeechSynthesis.h M Source/WebCore/Modules/speech/SpeechSynthesisUtterance.h M Source/WebCore/Modules/webaudio/AudioNode.cpp M Source/WebCore/Modules/webaudio/AudioNode.h M Source/WebCore/Modules/webaudio/BaseAudioContext.cpp M Source/WebCore/Modules/webaudio/BaseAudioContext.h M Source/WebCore/Modules/webcodecs/WebCodecsAudioDecoder.h M Source/WebCore/Modules/webcodecs/WebCodecsAudioEncoder.h M Source/WebCore/Modules/webcodecs/WebCodecsVideoDecoder.h M Source/WebCore/Modules/webcodecs/WebCodecsVideoEncoder.h M Source/WebCore/Modules/websockets/WebSocket.cpp M Source/WebCore/Modules/websockets/WebSocket.h M Source/WebCore/Modules/webxr/WebXRLayer.h M Source/WebCore/Modules/webxr/WebXRSession.h M Source/WebCore/Modules/webxr/WebXRSpace.h M Source/WebCore/Modules/webxr/WebXRSystem.h M Source/WebCore/animation/WebAnimation.h M Source/WebCore/bindings/scripts/InFilesCompiler.pm M Source/WebCore/css/FontFaceSet.h M Source/WebCore/css/MediaQueryList.h M Source/WebCore/dom/AbortSignal.h M Source/WebCore/dom/BroadcastChannel.h M Source/WebCore/dom/EventTarget.h M Source/WebCore/dom/EventTargetConcrete.h M Source/WebCore/dom/MessagePort.h M Source/WebCore/dom/MouseRelatedEvent.cpp M Source/WebCore/dom/MouseRelatedEvent.h M Source/WebCore/dom/Node.cpp M Source/WebCore/dom/Node.h M Source/WebCore/dom/TouchEvent.cpp M Source/WebCore/dom/make_event_factory.pl M Source/WebCore/fileapi/FileReader.h M Source/WebCore/html/MediaController.h M Source/WebCore/html/OffscreenCanvas.h M Source/WebCore/html/track/AudioTrackList.cpp M Source/WebCore/html/track/AudioTrackList.h M Source/WebCore/html/track/TextTrack.h M Source/WebCore/html/track/TextTrackCue.h M Source/WebCore/html/track/TextTrackList.cpp M Source/WebCore/html/track/TextTrackList.h M Source/WebCore/html/track/TrackListBase.h M Source/WebCore/html/track/VideoTrackList.cpp M Source/WebCore/html/track/VideoTrackList.h M Source/WebCore/loader/appcache/DOMApplicationCache.h M Source/WebCore/page/DOMWindow.h M Source/WebCore/page/EventSource.h M Source/WebCore/page/LocalDOMWindow.h M Source/WebCore/page/Navigation.cpp M Source/WebCore/page/Navigation.h M Source/WebCore/page/NavigationHistoryEntry.cpp M Source/WebCore/page/NavigationHistoryEntry.h M Source/WebCore/page/Performance.h M Source/WebCore/page/S
[webkit-changes] [WebKit/WebKit] eade05: Remove unused `pageLocation` function from `MouseR...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: eade0529b1d751328f3d0e6861b35c2370824caa https://github.com/WebKit/WebKit/commit/eade0529b1d751328f3d0e6861b35c2370824caa Author: Ahmad Saleem Date: 2024-02-23 (Fri, 23 Feb 2024) Changed paths: M Source/WebCore/dom/MouseRelatedEvent.cpp M Source/WebCore/dom/MouseRelatedEvent.h Log Message: --- Remove unused `pageLocation` function from `MouseRelatedEvent.cpp|h` https://bugs.webkit.org/show_bug.cgi?id=269963 Reviewed by Ryosuke Niwa. This patch removes unused function 'pageLocation' from `MouseRelatedEvent.cpp|h`. * Source/WebCore/dom/MouseRelatedEvent.cpp: (MouseRelatedEvent::pageLocation): * Source/WebCore/dom/MouseRelatedEvent.h: Canonical link: https://commits.webkit.org/275232@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 53463e: REGRESSION (274442@main): [ MacOS wk2 ] media/medi...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 53463ea1c60fe6de4120dab418a8bafa5e6471dd https://github.com/WebKit/WebKit/commit/53463ea1c60fe6de4120dab418a8bafa5e6471dd Author: Jean-Yves Avenard Date: 2024-02-23 (Fri, 23 Feb 2024) Changed paths: M LayoutTests/platform/mac-wk2/TestExpectations M Source/WebCore/Modules/mediasource/MediaSource.cpp M Source/WebKit/WebProcess/GPU/media/MediaPlayerPrivateRemote.cpp Log Message: --- REGRESSION (274442@main): [ MacOS wk2 ] media/media-source/media-source-seek-complete.html is a flaky timeout https://bugs.webkit.org/show_bug.cgi?id=269814 rdar://123338097 Reviewed by Jer Noble. If a `currentTimeChanged` message between the GPUP and WP was mid-flight when a new seek operation was started it would have set the current time to a stale value, so the time would appear to go backward and the seek would never complete. Prior 274442@main it *usually* didn't matter as the HTMLMediaElement cached the seeked time and would partially hide the time going backward. Following this change however, the MediaPlayerPrivate became the time reference, and so issues with the time being wrong became more problematic. This issue could explain a series of intermittent failures we have seen ever since the MediaPlayer was moved to the GPUP, including several changes made to prevent the time from ever going backward. The explanation above likely explains on why we needed such workaround in the first place. Also, before 274442@main if a seek was pending, it would have always returned the seek time when querying MediaSource::currentTime; we changed it to return 0 whenever the MediaSource was closed. We return to the original behaviour. * LayoutTests/platform/mac-wk2/TestExpectations: * Source/WebCore/Modules/mediasource/MediaSource.cpp: (WebCore::MediaSource::currentTime const): * Source/WebKit/WebProcess/GPU/media/MediaPlayerPrivateRemote.cpp: (WebKit::MediaPlayerPrivateRemote::playbackStateChanged): Add log. (WebKit::MediaPlayerPrivateRemote::currentTimeChanged): return early if currently seeking. Add log Canonical link: https://commits.webkit.org/275231@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 4b665f: [JSC] Fold empty string + value in bytecode generator
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 4b665f046f0db0e63fa3f84ee5116897b61c78be https://github.com/WebKit/WebKit/commit/4b665f046f0db0e63fa3f84ee5116897b61c78be Author: Yusuke Suzuki Date: 2024-02-23 (Fri, 23 Feb 2024) Changed paths: A JSTests/stress/empty-string-add-to-string.js M Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp Log Message: --- [JSC] Fold empty string + value in bytecode generator https://bugs.webkit.org/show_bug.cgi?id=269974 rdar://123492788 Reviewed by Ross Kirsling and Alexey Shvayka. This pattern is too much seen in the wild. So let's do optimization in bytecode generator level since it is too simple. When we see `"" + value`, we generate `to_string` bytecode for value. * JSTests/stress/empty-string-add-to-string.js: Added. (test1): (test2): (shouldBe): * Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp: (JSC::BytecodeGenerator::emitBinaryOp): Canonical link: https://commits.webkit.org/275230@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] c67d58: Pause control does not work in in-window mode
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: c67d585912b331ac7757866a1f969e25de04553c https://github.com/WebKit/WebKit/commit/c67d585912b331ac7757866a1f969e25de04553c Author: Dana Estra Date: 2024-02-23 (Fri, 23 Feb 2024) Changed paths: M Source/WebCore/Modules/modern-media-controls/controls/button.js Log Message: --- Pause control does not work in in-window mode https://bugs.webkit.org/show_bug.cgi?id=269951 rdar://122834226 Reviewed by Jer Noble. This bug was caused by both our event handler for clicking on the pause button and youtube's event handler for clicking on the video both being activated, causing the video to pause and then immediately be played again. To prevent this, in our button's event handler we now call stopPropagation(). * Source/WebCore/Modules/modern-media-controls/controls/button.js: (Button.prototype.handleEvent): Canonical link: https://commits.webkit.org/275229@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] a216dd: [WPE][GTK] Fully disable mDNS LibWebRTC support
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: a216dd6f98bfb8ffeb342b220c0d221e8b398f00 https://github.com/WebKit/WebKit/commit/a216dd6f98bfb8ffeb342b220c0d221e8b398f00 Author: Olivier Blin Date: 2024-02-23 (Fri, 23 Feb 2024) Changed paths: M Source/WebKit/WebProcess/Network/webrtc/LibWebRTCProvider.cpp Log Message: --- [WPE][GTK] Fully disable mDNS LibWebRTC support https://bugs.webkit.org/show_bug.cgi?id=269913 Reviewed by Philippe Normand. In 275090@main (c62c74690915), mDNS LibWebRTC support has been disabled for WPE and GTK in LibWebRTCNetworkManager::GetMdnsResponder(). But this is not synchronized with WebRTCProvider::isSupportingMDNS(), which is used to initialize m_shouldFilterICECandidates in PeerConnectionBackend::PeerConnectionBackend(). This triggers assertions in PeerConnectionBackend::newICECandidate(). * Source/WebKit/WebProcess/Network/webrtc/LibWebRTCProvider.cpp: (WebKit::LibWebRTCProvider::LibWebRTCProvider): Canonical link: https://commits.webkit.org/275228@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 34e14b: View transition old snapshots incorrectly get scal...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 34e14bf3631972e46abcee10b0b72f0339e7a493 https://github.com/WebKit/WebKit/commit/34e14bf3631972e46abcee10b0b72f0339e7a493 Author: Matt Woodrow Date: 2024-02-23 (Fri, 23 Feb 2024) Changed paths: M LayoutTests/TestExpectations M LayoutTests/platform/glib/TestExpectations M Source/WebCore/dom/ViewTransition.cpp M Source/WebCore/dom/ViewTransition.h M Source/WebCore/page/FrameSnapshotting.cpp M Source/WebCore/page/FrameSnapshotting.h M Source/WebCore/rendering/RenderBoxModelObject.cpp M Source/WebCore/rendering/RenderElement.cpp M Source/WebCore/rendering/RenderElement.h M Source/WebCore/rendering/RenderInline.cpp M Source/WebCore/rendering/RenderLayer.cpp M Source/WebCore/rendering/RenderTableRow.cpp M Source/WebCore/rendering/RenderViewTransitionCapture.cpp M Source/WebCore/rendering/RenderViewTransitionCapture.h M Source/WebCore/rendering/updating/RenderTreeUpdaterViewTransition.cpp Log Message: --- View transition old snapshots incorrectly get scaled to the border-box size. https://bugs.webkit.org/show_bug.cgi?id=269954 Reviewed by Tim Nguyen. Drawing of the old snapshot rescales the image to the border-box size, even if we captured a larger area. We shouldn't apply scaling, just align the origin of the border-box in the snapshot to the border-box origin of the pseudo element. This records the overflow rect for which the snapshot is captured, and uses it to adjust the overflow rect of the pseudo element and align the painting position of the snapshot. As a slight cleanup, merges the two createRendererIfNeeded lambdas into a single static function. * LayoutTests/TestExpectations: * LayoutTests/platform/glib/TestExpectations: * Source/WebCore/dom/ViewTransition.cpp: (WebCore::snapshotNodeVisualOverflowClippedToViewport): (WebCore::ViewTransition::captureOldState): * Source/WebCore/dom/ViewTransition.h: * Source/WebCore/page/FrameSnapshotting.cpp: (WebCore::snapshotFrameRectWithClip): * Source/WebCore/page/FrameSnapshotting.h: * Source/WebCore/rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::requiresLayer const): * Source/WebCore/rendering/RenderElement.cpp: (WebCore::RenderElement::capturedInViewTransition const): (WebCore::RenderElement::hasViewTransitionName const): * Source/WebCore/rendering/RenderElement.h: * Source/WebCore/rendering/RenderInline.cpp: (WebCore::RenderInline::requiresLayer const): * Source/WebCore/rendering/RenderLayer.cpp: (WebCore::canCreateStackingContext): (WebCore::RenderLayer::shouldBeCSSStackingContext const): (WebCore::RenderLayer::computeCanBeBackdropRoot const): * Source/WebCore/rendering/RenderTableRow.cpp: (WebCore::RenderTableRow::requiresLayer const): * Source/WebCore/rendering/RenderViewTransitionCapture.cpp: (WebCore::RenderViewTransitionCapture::setImage): (WebCore::RenderViewTransitionCapture::paintReplaced): (WebCore::RenderViewTransitionCapture::layout): * Source/WebCore/rendering/RenderViewTransitionCapture.h: * Source/WebCore/rendering/updating/RenderTreeUpdaterViewTransition.cpp: (WebCore::createRendererIfNeeded): (WebCore::RenderTreeUpdater::ViewTransition::buildPseudoElementGroup): (WebCore::RenderTreeUpdater::ViewTransition::updatePseudoElementGroup): Canonical link: https://commits.webkit.org/275227@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 277513: [LibWebRTC][GStreamer] Clean-up GstSample ownershi...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 277513e286a06d87a28196e8edb74256ffb052c1 https://github.com/WebKit/WebKit/commit/277513e286a06d87a28196e8edb74256ffb052c1 Author: Philippe Normand Date: 2024-02-23 (Fri, 23 Feb 2024) Changed paths: M Source/WebCore/platform/mediastream/libwebrtc/gstreamer/GStreamerVideoDecoderFactory.cpp M Source/WebCore/platform/mediastream/libwebrtc/gstreamer/GStreamerVideoFrameLibWebRTC.cpp M Source/WebCore/platform/mediastream/libwebrtc/gstreamer/GStreamerVideoFrameLibWebRTC.h Log Message: --- [LibWebRTC][GStreamer] Clean-up GstSample ownership semantics in LibWebRTC VideoFrame https://bugs.webkit.org/show_bug.cgi?id=269903 Reviewed by Xabier Rodriguez-Calvar. The sample reference can be moved to the VideoFrame. * Source/WebCore/platform/mediastream/libwebrtc/gstreamer/GStreamerVideoDecoderFactory.cpp: (WebCore::GStreamerVideoDecoder::pullSample): * Source/WebCore/platform/mediastream/libwebrtc/gstreamer/GStreamerVideoFrameLibWebRTC.cpp: (WebCore::convertGStreamerSampleToLibWebRTCVideoFrame): (WebCore::GStreamerVideoFrameLibWebRTC::create): * Source/WebCore/platform/mediastream/libwebrtc/gstreamer/GStreamerVideoFrameLibWebRTC.h: (WebCore::GStreamerVideoFrameLibWebRTC::GStreamerVideoFrameLibWebRTC): Canonical link: https://commits.webkit.org/275226@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 36c6dd: Safari is hanging on launch in WebExtension::resou...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 36c6dd79307be994ccb7ca9a819775c6e904564c https://github.com/WebKit/WebKit/commit/36c6dd79307be994ccb7ca9a819775c6e904564c Author: Timothy Hatcher Date: 2024-02-23 (Fri, 23 Feb 2024) Changed paths: M Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionActionCocoa.mm M Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionCocoa.mm Log Message: --- Safari is hanging on launch in WebExtension::resourceFileURLForPath. https://webkit.org/b/269972 rdar://123470286 Reviewed by Brian Weinstein. Three things were happening here to cause the hang: * The incorrect logic for checking null strings in `clearCustomizations()` was causing the notification to fire all the time. When the action cleared, Ghostery would set custom icons and an empty badge string again (likely detecting the change in results from browser.action APIs.) This would cause rapid cycles of change and reset. * The icon paths Ghostery uses start with a `/`. This was causing our `resourceFileURLForPath()` function to truncate the file URL back to the root and return nil for the icons path. This caused the action icon image to fail to load and show a blank icon. * Not all of the action properties were properly tracking changes, always sending the changed notification when nothing had changed. * Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionActionCocoa.mm: (WebKit::WebExtensionAction::clearCustomizations): Correct the null string checks. (WebKit::WebExtensionAction::setIconsDictionary): Early return if nothing changed. (WebKit::WebExtensionAction::setHasUnreadBadgeText): Ditto. (WebKit::WebExtensionAction::incrementBlockedResourceCount): Ditto. * Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionCocoa.mm: (WebKit::WebExtension::resourceFileURLForPath): Remove prefix if present. Canonical link: https://commits.webkit.org/275225@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 5afce8: [Skia][GStreamer] Implement ImageGStreamer
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 5afce8e3f3a69057b9eb565af0c341d72d23ce62 https://github.com/WebKit/WebKit/commit/5afce8e3f3a69057b9eb565af0c341d72d23ce62 Author: Carlos Garcia Campos Date: 2024-02-23 (Fri, 23 Feb 2024) Changed paths: M Source/WebCore/platform/graphics/gstreamer/GStreamerCommon.h M Source/WebCore/platform/graphics/gstreamer/ImageGStreamerSkia.cpp M Source/WebCore/platform/graphics/gstreamer/VideoFrameGStreamer.cpp M Source/WebCore/platform/mediastream/libwebrtc/gstreamer/GStreamerVideoFrameLibWebRTC.cpp Log Message: --- [Skia][GStreamer] Implement ImageGStreamer https://bugs.webkit.org/show_bug.cgi?id=269907 Reviewed by Philippe Normand. * Source/WebCore/platform/graphics/gstreamer/ImageGStreamerSkia.cpp: (WebCore::ImageGStreamer::ImageGStreamer): (WebCore::ImageGStreamer::~ImageGStreamer): Canonical link: https://commits.webkit.org/275224@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 29ce0c: Cherry-pick 274448@main (ac976a6da88c). https://bu...
Branch: refs/heads/webkitglib/2.44 Home: https://github.com/WebKit/WebKit Commit: 29ce0c76196f16f8d5c901e734addfa40cbf7ce4 https://github.com/WebKit/WebKit/commit/29ce0c76196f16f8d5c901e734addfa40cbf7ce4 Author: Jean-Yves Avenard Date: 2024-02-16 (Fri, 16 Feb 2024) Changed paths: M Source/WTF/wtf/NativePromise.h M Tools/TestWebKitAPI/Tests/WTF/NativePromise.cpp Log Message: --- Cherry-pick 274448@main (ac976a6da88c). https://bugs.webkit.org/show_bug.cgi?id=269160 NativePromise: ASSERTION FAILED: !m_callback https://bugs.webkit.org/show_bug.cgi?id=269160 rdar://122738739 Reviewed by Youenn Fablet. Following 273828@main, NativePromiseRequest now inherits from CanMakeWeakPtr, making it possible to disconnect it while not owning it. If the NativePromiseRequest was owned by the NativePromise callback, when disconnecting the NativePromiseRequest the callback would be deleted before the NativePromiseRequest::m_callback member got cleared, which trigger the assertion. We clear m_callback prior call disconnect(). Added API test. * Source/WTF/wtf/NativePromise.h: (WTF::NativePromiseRequest::disconnect): * Tools/TestWebKitAPI/Tests/WTF/NativePromise.cpp: (TestWebKitAPI::TEST): Canonical link: https://commits.webkit.org/274448@main Commit: 7e26f96d7f4540893b35a15a5cd0f2ba61d3487e https://github.com/WebKit/WebKit/commit/7e26f96d7f4540893b35a15a5cd0f2ba61d3487e Author: Jer Noble Date: 2024-02-16 (Fri, 16 Feb 2024) Changed paths: M Source/WebKit/WebProcess/FullScreen/WebFullScreenManager.cpp Log Message: --- Cherry-pick 274460@main (8a0987250d87). https://bugs.webkit.org/show_bug.cgi?id=269120 [iOS] youtube.com: Exiting fullscreen causes page to scroll down slightly, cropping top of video https://bugs.webkit.org/show_bug.cgi?id=269120 rdar://120492434 Reviewed by Aditya Keerthi. In 271567@main, we added a call to `scrollIntoView()` to ensure the element which was exiting fullscreen was visible in the viewport, no matter how much layout shifted the element during the fullscreen transition. However, this has the side effect of "pinning" the fullscreen element to the top of the page, which for the case of YouTube, is under the YouTube header bar. Instead, call `scrollIntoViewIfNotVisible()` (passing in `true` to center the element if offscreen) which is a no-op if the element is already visible. * Source/WebKit/WebProcess/FullScreen/WebFullScreenManager.cpp: (WebKit::WebFullScreenManager::didExitFullScreen): Canonical link: https://commits.webkit.org/274460@main Commit: 43eff15a763d3c22e3a5f3ab3df1b550c8878cc9 https://github.com/WebKit/WebKit/commit/43eff15a763d3c22e3a5f3ab3df1b550c8878cc9 Author: Vivienne Watermeier Date: 2024-02-16 (Fri, 16 Feb 2024) Changed paths: M Source/WebCore/platform/graphics/gstreamer/GStreamerCommon.cpp Log Message: --- Cherry-pick 274464@main (41a2e3c52030). https://bugs.webkit.org/show_bug.cgi?id=268559 [GStreamer] Include MpegAudioParse plugin in Brcm Nexus gstreamer pipeline https://bugs.webkit.org/show_bug.cgi?id=268559 Reviewed by Xabier Rodriguez-Calvar. On broadcom/nexus with progressive audio, gst_element_query_duration() returns wrong values, which is avoided by forcing mpegaudioparse. See: https://github.com/WebPlatformForEmbedded/WPEWebKit/pull/1213 Original author: suresh-khurdiya-epam * Source/WebCore/platform/graphics/gstreamer/GStreamerCommon.cpp: (WebCore::ensureGStreamerInitialized): Override mpegaudioparse rank Canonical link: https://commits.webkit.org/274464@main Commit: cf178e40b0ca3b14c5c29600c9d057c649f00444 https://github.com/WebKit/WebKit/commit/cf178e40b0ca3b14c5c29600c9d057c649f00444 Author: Vivienne Watermeier Date: 2024-02-16 (Fri, 16 Feb 2024) Changed paths: M Source/WebCore/platform/graphics/gstreamer/TrackPrivateBaseGStreamer.cpp Log Message: --- Cherry-pick 274469@main (48efea40e980). https://bugs.webkit.org/show_bug.cgi?id=268549 [GStreamer] Trim leading zeroes from track IDs https://bugs.webkit.org/show_bug.cgi?id=268549 Reviewed by Xabier Rodriguez-Calvar and Philippe Normand. Qtdemux inserts leading zeroes when generating stream-ids, this patch trims them in TrackPrivateBaseGStreamer for a better representation of their underlying integers. * Source/WebCore/platform/graphics/gstreamer/TrackPrivateBaseGStreamer.cpp: (WebCore::trimStreamId): (WebCore::TrackPrivateBaseGStreamer::TrackPrivateBaseGStreamer): (WebCore::TrackPrivateBaseGStreamer::notifyTrackOfStreamChanged): (WebCore::TrackPrivateBaseGStreamer::trackIdFromPadStreamStartOrUniqueID): Canonical link: https://commits.webkit.org/274469@main Commit: 8450b1daa6de8014b177008750d111d185ee590b
