[webkit-changes] [WebKit/WebKit] 0c23d3: Unreviewed, reverting 277816@main
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 0c23d38440fb47a42a6bc059c6e1e7b2f7fbd731 https://github.com/WebKit/WebKit/commit/0c23d38440fb47a42a6bc059c6e1e7b2f7fbd731 Author: Chris Dumez Date: 2024-04-23 (Tue, 23 Apr 2024) Changed paths: M Source/WebKit/Configurations/BaseExtension.xcconfig M Source/WebKit/WebKit.xcodeproj/project.pbxproj Log Message: --- Unreviewed, reverting 277816@main https://bugs.webkit.org/show_bug.cgi?id=273168 rdar://126927058 Unreviewed, revert 277816@main as it seems to have broken roots install Reverted change: Change install location of WebKit process extensions https://bugs.webkit.org/show_bug.cgi?id=268946 rdar://126613034 https://commits.webkit.org/277816@main Canonical link: https://commits.webkit.org/277918@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] b9413e: REGRESSION (277809@main): [ macOS wk1 ] imported/w...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: b9413e6988be6d8cf97daf0a6cd5a8ca03b71585 https://github.com/WebKit/WebKit/commit/b9413e6988be6d8cf97daf0a6cd5a8ca03b71585 Author: Marcos Caceres Date: 2024-04-23 (Tue, 23 Apr 2024) Changed paths: M LayoutTests/imported/w3c/web-platform-tests/geolocation-API/disabled-by-permissions-policy.https.sub-expected.txt M LayoutTests/imported/w3c/web-platform-tests/geolocation-API/enabled-by-permission-policy-attribute-redirect-on-load.https.sub-expected.txt M LayoutTests/imported/w3c/web-platform-tests/geolocation-API/enabled-by-permissions-policy.https.sub-expected.txt M LayoutTests/imported/w3c/web-platform-tests/geolocation-API/enabled-on-self-origin-by-permissions-policy.https.sub-expected.txt M LayoutTests/platform/gtk/imported/w3c/web-platform-tests/geolocation-API/disabled-by-permissions-policy.https.sub-expected.txt M LayoutTests/platform/gtk/imported/w3c/web-platform-tests/geolocation-API/enabled-by-permission-policy-attribute-redirect-on-load.https.sub-expected.txt M LayoutTests/platform/gtk/imported/w3c/web-platform-tests/geolocation-API/enabled-by-permissions-policy.https.sub-expected.txt M LayoutTests/platform/gtk/imported/w3c/web-platform-tests/geolocation-API/enabled-on-self-origin-by-permissions-policy.https.sub-expected.txt M LayoutTests/platform/mac-wk1/TestExpectations M LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/geolocation-API/disabled-by-permissions-policy.https.sub-expected.txt M LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/geolocation-API/enabled-by-permission-policy-attribute-redirect-on-load.https.sub-expected.txt M LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/geolocation-API/enabled-by-permissions-policy.https.sub-expected.txt M LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/geolocation-API/enabled-on-self-origin-by-permissions-policy.https.sub-expected.txt M LayoutTests/platform/wpe/imported/w3c/web-platform-tests/geolocation-API/disabled-by-permissions-policy.https.sub-expected.txt M LayoutTests/platform/wpe/imported/w3c/web-platform-tests/geolocation-API/enabled-by-permission-policy-attribute-redirect-on-load.https.sub-expected.txt M LayoutTests/platform/wpe/imported/w3c/web-platform-tests/geolocation-API/enabled-by-permissions-policy.https.sub-expected.txt M LayoutTests/platform/wpe/imported/w3c/web-platform-tests/geolocation-API/enabled-on-self-origin-by-permissions-policy.https.sub-expected.txt Log Message: --- REGRESSION (277809@main): [ macOS wk1 ] imported/w3c/web-platform-tests/geolocation-API are consistent failure https://bugs.webkit.org/show_bug.cgi?id=273083 rdar://126878399 Reviewed by Simon Fraser. Fixed console string in the test to match the expected result. This happened because I landed the following patch without rebasing the geo tests that landed at the same time: https://github.com/WebKit/WebKit/pull/27477 * LayoutTests/imported/w3c/web-platform-tests/geolocation-API/disabled-by-permissions-policy.https.sub-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/geolocation-API/enabled-by-permission-policy-attribute-redirect-on-load.https.sub-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/geolocation-API/enabled-by-permissions-policy.https.sub-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/geolocation-API/enabled-on-self-origin-by-permissions-policy.https.sub-expected.txt: * LayoutTests/platform/gtk/imported/w3c/web-platform-tests/geolocation-API/disabled-by-permissions-policy.https.sub-expected.txt: * LayoutTests/platform/gtk/imported/w3c/web-platform-tests/geolocation-API/enabled-by-permission-policy-attribute-redirect-on-load.https.sub-expected.txt: * LayoutTests/platform/gtk/imported/w3c/web-platform-tests/geolocation-API/enabled-by-permissions-policy.https.sub-expected.txt: * LayoutTests/platform/gtk/imported/w3c/web-platform-tests/geolocation-API/enabled-on-self-origin-by-permissions-policy.https.sub-expected.txt: * LayoutTests/platform/mac-wk1/TestExpectations: * LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/geolocation-API/disabled-by-permissions-policy.https.sub-expected.txt: * LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/geolocation-API/enabled-by-permission-policy-attribute-redirect-on-load.https.sub-expected.txt: * LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/geolocation-API/enabled-by-permissions-policy.https.sub-expected.txt: * LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/geolocation-API/enabled-on-self-origin-by-permissions-policy.https.sub-expected.txt: * LayoutTests/platform/wpe/imported/w3c/web-platform-tests/geolocation-API/disabled-by-permissions-policy.https.sub-expected.txt: * LayoutTests/platform/wpe/imported/w3c/web-platform-tests/geolocation-API/enabled-by-permission-policy-at
[webkit-changes] [WebKit/WebKit] 93c46c: Follow-up fix to 277527@main
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 93c46cf87c69e32f3e0c38bdfbada8adc0fd8ab6 https://github.com/WebKit/WebKit/commit/93c46cf87c69e32f3e0c38bdfbada8adc0fd8ab6 Author: Alex Christensen Date: 2024-04-23 (Tue, 23 Apr 2024) Changed paths: M Source/WTF/wtf/PlatformHave.h M Source/WebKit/Shared/RemoteLayerTree/RemoteLayerTreeTransaction.mm M Source/WebKit/WebProcess/WebPage/IPCTestingAPI.cpp M Tools/TestWebKitAPI/Tests/IPC/ArgumentCoderTests.cpp M Tools/TestWebKitAPI/Tests/IPC/IPCSerialization.mm Log Message: --- Follow-up fix to 277527@main https://bugs.webkit.org/show_bug.cgi?id=272742 Reviewed by Alex Christensen and Don Olmstead. * Source/WTF/wtf/PlatformHave.h: * Source/WebKit/Shared/RemoteLayerTree/RemoteLayerTreeTransaction.mm: (IPC::ArgumentCoder::encode): * Source/WebKit/Shared/mac/ObjCObjectGraph.mm: (WebKit::ObjCObjectGraph::decode): * Source/WebKit/WebProcess/WebPage/IPCTestingAPI.cpp: (WebKit::IPCTestingAPI::JSIPCSemaphore::JSIPCSemaphore): (WebKit::IPCTestingAPI::JSIPCConnectionHandle::JSIPCConnectionHandle): (WebKit::IPCTestingAPI::JSIPCConnection::JSIPCConnection): (WebKit::IPCTestingAPI::JSIPCStreamClientConnection::JSIPCStreamClientConnection): (WebKit::IPCTestingAPI::JSIPCStreamServerConnectionHandle::JSIPCStreamServerConnectionHandle): (WebKit::IPCTestingAPI::JSIPCStreamConnectionBuffer::JSIPCStreamConnectionBuffer): (WebKit::IPCTestingAPI::JSSharedMemory::JSSharedMemory): (WebKit::IPCTestingAPI::JSIPC::JSIPC): (WebKit::IPCTestingAPI::extractSyncIPCMessageInfo): (WebKit::IPCTestingAPI::JSIPCStreamClientConnection::streamBuffer): (WebKit::IPCTestingAPI::JSIPCStreamClientConnection::setSemaphores): (WebKit::IPCTestingAPI::extractIPCStreamMessageInfo): (WebKit::IPCTestingAPI::JSIPCStreamClientConnection::sendWithAsyncReply): (WebKit::IPCTestingAPI::JSIPCStreamClientConnection::sendSyncMessage): (WebKit::IPCTestingAPI::JSIPCStreamClientConnection::sendIPCStreamTesterSyncCrashOnZero): (WebKit::IPCTestingAPI::JSIPCSemaphore::signal): (WebKit::IPCTestingAPI::JSIPCSemaphore::waitFor): (WebKit::IPCTestingAPI::JSSharedMemory::readBytes): (WebKit::IPCTestingAPI::arrayBufferSpanFromValueRef): (WebKit::IPCTestingAPI::JSSharedMemory::writeBytes): (WebKit::IPCTestingAPI::JSIPCStreamConnectionBuffer::readHeaderBytes): (WebKit::IPCTestingAPI::JSIPCStreamConnectionBuffer::readDataBytes): (WebKit::IPCTestingAPI::JSIPCStreamConnectionBuffer::readBytes): (WebKit::IPCTestingAPI::JSIPCStreamConnectionBuffer::writeHeaderBytes): (WebKit::IPCTestingAPI::JSIPCStreamConnectionBuffer::writeDataBytes): (WebKit::IPCTestingAPI::JSIPCStreamConnectionBuffer::writeBytes): (WebKit::IPCTestingAPI::JSIPC::processTargetFromArgument): (WebKit::IPCTestingAPI::JSIPC::addMessageListener): (WebKit::IPCTestingAPI::messageNameFromArgument): (WebKit::IPCTestingAPI::encodeTypedArray): (WebKit::IPCTestingAPI::encodeRemoteRenderingBackendCreationParameters): (WebKit::IPCTestingAPI::encodeSharedMemory): (WebKit::IPCTestingAPI::encodeStreamConnectionBuffer): (WebKit::IPCTestingAPI::encodeStreamServerConnectionHandle): (WebKit::IPCTestingAPI::encodeSemaphore): (WebKit::IPCTestingAPI::encodeConnectionHandle): (IPC::ArgumentCoder::encode): (WebKit::IPCTestingAPI::JSMessageListener::jsDescriptionFromDecoder): * Tools/TestWebKitAPI/Tests/IPC/ArgumentCoderTests.cpp: (TestWebKitAPI::ArgumentCoderEncoderDecoderTest::Impl::Impl): (TestWebKitAPI::EncodingCounter::CounterValues::CounterValues): (TestWebKitAPI::EncodingCounter::EncodingCounter): (IPC::ArgumentCoder::encode): (IPC::ArgumentCoder::encode): (IPC::ArgumentCoder::decode): * Tools/TestWebKitAPI/Tests/IPC/IPCSerialization.mm: (IPC::ArgumentCoder::encode): (IPC::ArgumentCoder::decode): (IPC::ArgumentCoder::encode): (IPC::ArgumentCoder::decode): Canonical link: https://commits.webkit.org/277916@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] c55e7c: [visionOS] Firefox opens up a black window during ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: c55e7c8b5b2f2a777adac65df27114eccebbfa5c https://github.com/WebKit/WebKit/commit/c55e7c8b5b2f2a777adac65df27114eccebbfa5c Author: Jer Noble Date: 2024-04-23 (Tue, 23 Apr 2024) Changed paths: M Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml M Source/WebKit/Shared/WebPreferencesDefaultValues.cpp M Source/WebKit/Shared/WebPreferencesDefaultValues.h M Source/WebKit/UIProcess/WebPageProxy.cpp Log Message: --- [visionOS] Firefox opens up a black window during video fullscreen https://bugs.webkit.org/show_bug.cgi?id=273149 rdar://126767657 Reviewed by Andy Estes. Disable the LinearMediaPlayerEnabled setting when run in iPad compatibility mode. * Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml: * Source/WebKit/Shared/WebPreferencesDefaultValues.cpp: (WebKit::defaultLinearMediaPlayerEnabled): * Source/WebKit/Shared/WebPreferencesDefaultValues.h: * Source/WebKit/UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::viewDidLeaveWindow): Canonical link: https://commits.webkit.org/277915@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 7fb06f: [Skia] Simplify and fix accelerated filters
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 7fb06fd42e78309f1d14e5178ce118eda974c625 https://github.com/WebKit/WebKit/commit/7fb06fd42e78309f1d14e5178ce118eda974c625 Author: Georges Basile Stavracas Neto Date: 2024-04-23 (Tue, 23 Apr 2024) Changed paths: M Source/WebCore/platform/SourcesSkia.txt M Source/WebCore/platform/graphics/filters/FilterImage.cpp M Source/WebCore/platform/graphics/filters/FilterImage.h M Source/WebCore/platform/graphics/filters/skia/FEColorMatrixSkiaApplier.cpp M Source/WebCore/platform/graphics/filters/skia/FEGaussianBlurSkiaApplier.cpp M Source/WebCore/platform/graphics/filters/skia/SourceGraphicSkiaApplier.cpp R Source/WebCore/platform/graphics/skia/FilterImageSkia.cpp Log Message: --- [Skia] Simplify and fix accelerated filters https://bugs.webkit.org/show_bug.cgi?id=272991 Reviewed by Carlos Garcia Campos. The ImageBuffer in results must exist for various tests and pages to work. Skia creates that on demand, like CoreImage, but that doesn't seem to work well. Always call "results.imageBuffer()" when applying Skia filters - FilterImage::imageBuffer() looks like a simple getter but it actually creates the ImageBuffer if it doesn't exist! Remove the SkPictureRecorder and the SkPicture from the game, they're not needed since we can paint using the graphics context of the result image buffer directly. * Source/WebCore/platform/SourcesSkia.txt: * Source/WebCore/platform/graphics/filters/FilterImage.cpp: (WebCore::FilterImage::memoryCost const): (WebCore::FilterImage::imageBuffer): * Source/WebCore/platform/graphics/filters/FilterImage.h: * Source/WebCore/platform/graphics/filters/skia/FEColorMatrixSkiaApplier.cpp: (WebCore::FEColorMatrixSkiaApplier::apply const): * Source/WebCore/platform/graphics/filters/skia/FEGaussianBlurSkiaApplier.cpp: (WebCore::FEGaussianBlurSkiaApplier::apply const): * Source/WebCore/platform/graphics/filters/skia/SourceGraphicSkiaApplier.cpp: (WebCore::SourceGraphicSkiaApplier::apply const): * Source/WebCore/platform/graphics/skia/FilterImageSkia.cpp: Removed. Canonical link: https://commits.webkit.org/277914@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 918bd3: Use ASCIILiteral in more places
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 918bd357adca5b0a818bdb200e4ce5a74f292b75 https://github.com/WebKit/WebKit/commit/918bd357adca5b0a818bdb200e4ce5a74f292b75 Author: Chris Dumez Date: 2024-04-23 (Tue, 23 Apr 2024) Changed paths: M Source/WebCore/html/parser/HTMLTokenizer.cpp M Source/WebCore/loader/archive/mhtml/MHTMLArchive.cpp M Source/WebCore/page/History.cpp M Source/WebCore/page/MemoryRelease.cpp M Source/WebCore/page/PageOverlayController.cpp M Source/WebCore/page/PageOverlayController.h M Source/WebCore/page/PerformanceMonitor.cpp M Source/WebCore/page/csp/ContentSecurityPolicy.cpp M Source/WebCore/platform/cocoa/PasteboardCocoa.mm M Source/WebCore/platform/gamepad/PlatformGamepad.h M Source/WebCore/platform/gamepad/cocoa/GameControllerGamepad.h M Source/WebCore/platform/gamepad/mac/HIDGamepad.h M Source/WebCore/platform/gamepad/mac/MultiGamepadProvider.h M Source/WebCore/platform/graphics/GraphicsLayer.cpp M Source/WebCore/platform/graphics/GraphicsLayerClient.h M Source/WebCore/platform/graphics/SourceBufferPrivate.cpp M Source/WebCore/platform/graphics/TrackBuffer.cpp M Source/WebCore/platform/graphics/TrackBuffer.h M Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp M Source/WebCore/platform/graphics/ca/GraphicsLayerCA.h M Source/WebCore/platform/graphics/cocoa/WebMAudioUtilitiesCocoa.mm M Source/WebCore/platform/mac/PlatformPasteboardMac.mm M Source/WebCore/platform/mock/MockRealtimeVideoSource.cpp M Source/WebCore/platform/mock/ScrollbarsControllerMock.cpp M Source/WebCore/platform/mock/ScrollbarsControllerMock.h M Source/WebCore/platform/network/HTTPParsers.cpp M Source/WebCore/platform/text/SegmentedString.cpp M Source/WebCore/platform/text/SegmentedString.h M Source/WebCore/rendering/LegacyInlineBox.cpp M Source/WebCore/rendering/LegacyInlineBox.h M Source/WebCore/rendering/LegacyInlineFlowBox.cpp M Source/WebCore/rendering/LegacyInlineFlowBox.h M Source/WebCore/rendering/LegacyInlineTextBox.cpp M Source/WebCore/rendering/LegacyInlineTextBox.h M Source/WebCore/rendering/LegacyRootInlineBox.cpp M Source/WebCore/rendering/LegacyRootInlineBox.h M Source/WebCore/rendering/RenderLayer.cpp M Source/WebCore/rendering/RenderLayerBacking.cpp M Source/WebCore/rendering/RenderLayerBacking.h M Source/WebCore/rendering/RenderLayerCompositor.cpp M Source/WebCore/rendering/RenderLayerCompositor.h M Source/WebCore/rendering/RenderQuote.cpp M Source/WebCore/rendering/svg/SVGRenderTreeAsText.cpp Log Message: --- Use ASCIILiteral in more places https://bugs.webkit.org/show_bug.cgi?id=273111 Reviewed by Darin Adler. Use ASCIILiteral in more places to reduce use of `const char*`. * Source/WebCore/html/parser/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::processToken): * Source/WebCore/loader/archive/mhtml/MHTMLArchive.cpp: (WebCore::MHTMLArchive::generateMHTMLData): * Source/WebCore/page/History.cpp: (WebCore::History::stateObjectAdded): * Source/WebCore/page/MemoryRelease.cpp: (WebCore::logMemoryStatisticsReasonDescription): (WebCore::logMemoryStatistics): * Source/WebCore/page/PageOverlayController.cpp: (WebCore::PageOverlayController::shouldDumpPropertyForLayer const): * Source/WebCore/page/PageOverlayController.h: * Source/WebCore/page/PerformanceMonitor.cpp: (WebCore::stringForCPUSamplingActivityState): (WebCore::PerformanceMonitor::measureCPUUsageInActivityState): * Source/WebCore/page/csp/ContentSecurityPolicy.cpp: (WebCore::consoleMessageForViolation): (WebCore::ContentSecurityPolicy::allowJavaScriptURLs const): (WebCore::ContentSecurityPolicy::allowInlineEventHandlers const): (WebCore::ContentSecurityPolicy::allowNonParserInsertedScripts const): (WebCore::ContentSecurityPolicy::allowInlineScript const): (WebCore::ContentSecurityPolicy::allowInlineStyle const): (WebCore::ContentSecurityPolicy::allowEval const): (WebCore::ContentSecurityPolicy::allowFrameAncestors const): (WebCore::ContentSecurityPolicy::allowPluginType const): (WebCore::ContentSecurityPolicy::allowObjectFromSource const): (WebCore::ContentSecurityPolicy::allowChildFrameFromSource const): (WebCore::ContentSecurityPolicy::allowResourceFromSource const): (WebCore::ContentSecurityPolicy::allowWorkerFromSource const): (WebCore::ContentSecurityPolicy::allowScriptFromSource const): (WebCore::ContentSecurityPolicy::allowStyleFromSource const): (WebCore::ContentSecurityPolicy::allowConnectToSource const): (WebCore::ContentSecurityPolicy::allowBaseURI const): * Source/WebCore/platform/cocoa/PasteboardCocoa.mm: (WebCore::imageTypeToMIMEType): (WebCore::Pasteboard::read): * Source/WebCore/platform/gamepad/PlatformGamepad.h: (WebCore::PlatformGamepad::source const): * Source/WebCore/platform/gamepad/cocoa/GameControllerGamepad.h: * Source/WebCore/platform/gamepad/mac/HIDGamepad.h: * Source/WebCore/pl
[webkit-changes] [WebKit/WebKit] 235ae8: Rebuild continuations when position property changes
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 235ae8a090b2798b982fa2737c5df7d65d26298b https://github.com/WebKit/WebKit/commit/235ae8a090b2798b982fa2737c5df7d65d26298b Author: Antti Koivisto Date: 2024-04-23 (Tue, 23 Apr 2024) Changed paths: M LayoutTests/fast/block/positioning/fixed-container-with-relative-parent-expected.html A LayoutTests/fast/block/positioning/out-of-flow-continuation-rebuild-expected.html A LayoutTests/fast/block/positioning/out-of-flow-continuation-rebuild.html M Source/WebCore/rendering/updating/RenderTreeUpdater.cpp M Source/WebCore/style/StyleTreeResolver.cpp M Source/WebCore/style/StyleUpdate.cpp M Source/WebCore/style/StyleUpdate.h Log Message: --- Rebuild continuations when position property changes https://bugs.webkit.org/show_bug.cgi?id=273137 rdar://124987637 Reviewed by Alan Baradlay. We fail to clear continuation renderers when a renderer becomes out-of-flow positioned. In some cases this has painting or layout effects. * LayoutTests/fast/block/positioning/fixed-container-with-relative-parent-expected.html: Expectations of this tests were wrong and didn't match other browsers. Simply compare against the non-dynamic case. * LayoutTests/fast/block/positioning/out-of-flow-continuation-rebuild-expected.html: Added. * LayoutTests/fast/block/positioning/out-of-flow-continuation-rebuild.html: Added. * Source/WebCore/rendering/updating/RenderTreeUpdater.cpp: (WebCore::RenderTreeUpdater::updateRebuildRoots): Check if the rebuild root is inside a continuation. If so start the rebuild from the ancestor. Also copy pseudo-elements. * Source/WebCore/style/StyleTreeResolver.cpp: (WebCore::Style::TreeResolver::createAnimatedElementUpdate): If position property changes we need to check for different rebuild root. * Source/WebCore/style/StyleUpdate.cpp: (WebCore::Style::Update::addElement): Collect potential rebuild roots based on a bit in Style::Update. * Source/WebCore/style/StyleUpdate.h: Canonical link: https://commits.webkit.org/277912@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 10bdca: Disable NSTextViewAllowsDowngradeToLayoutManager i...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 10bdca14c1424fdf0a473807f68881fbc8be446b https://github.com/WebKit/WebKit/commit/10bdca14c1424fdf0a473807f68881fbc8be446b Author: Ryosuke Niwa Date: 2024-04-23 (Tue, 23 Apr 2024) Changed paths: M Source/WebKit/Shared/Cocoa/AuxiliaryProcessCocoa.mm Log Message: --- Disable NSTextViewAllowsDowngradeToLayoutManager in WebKit processes https://bugs.webkit.org/show_bug.cgi?id=273133 rdar://121082136 Reviewed by Wenson Hsieh. Set NSTextViewAllowsDowngradeToLayoutManager to NO in WebKit's child processes. * Source/WebKit/Shared/Cocoa/AuxiliaryProcessCocoa.mm: (WebKit::disableDowngradeToLayoutManager): (WebKit::AuxiliaryProcess::platformInitialize): Canonical link: https://commits.webkit.org/277911@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] e52cc4: REGRESSION(276962@main): ~1% regression in JetStre...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: e52cc44f2604eb43287e2153dcf815525594be80 https://github.com/WebKit/WebKit/commit/e52cc44f2604eb43287e2153dcf815525594be80 Author: Ryosuke Niwa Date: 2024-04-23 (Tue, 23 Apr 2024) Changed paths: M Source/WebCore/loader/EmptyClients.cpp M Source/WebCore/loader/EmptyFrameLoaderClient.h M Source/WebCore/loader/FrameLoader.cpp M Source/WebCore/loader/LocalFrameLoaderClient.h M Source/WebKit/WebProcess/WebCoreSupport/WebLocalFrameLoaderClient.cpp M Source/WebKit/WebProcess/WebCoreSupport/WebLocalFrameLoaderClient.h M Source/WebKitLegacy/mac/WebCoreSupport/WebFrameLoaderClient.h M Source/WebKitLegacy/mac/WebCoreSupport/WebFrameLoaderClient.mm Log Message: --- REGRESSION(276962@main): ~1% regression in JetStream 3 https://bugs.webkit.org/show_bug.cgi?id=273139 Reviewed by Wenson Hsieh. The regression was caused by the scheduling of full editor state update. Avoid this work for an initial blank document loaded for an iframe. * Source/WebCore/loader/EmptyClients.cpp: (WebCore::EmptyFrameLoaderClient::transitionToCommittedForNewPage): * Source/WebCore/loader/EmptyFrameLoaderClient.h: * Source/WebCore/loader/FrameLoader.cpp: (WebCore::FrameLoader::initForSynthesizedDocument): (WebCore::FrameLoader::transitionToCommitted): * Source/WebCore/loader/LocalFrameLoaderClient.h: * Source/WebKit/WebProcess/WebCoreSupport/WebLocalFrameLoaderClient.cpp: (WebKit::WebLocalFrameLoaderClient::transitionToCommittedForNewPage): * Source/WebKit/WebProcess/WebCoreSupport/WebLocalFrameLoaderClient.h: * Source/WebKitLegacy/mac/WebCoreSupport/WebFrameLoaderClient.h: * Source/WebKitLegacy/mac/WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::transitionToCommittedForNewPage): Canonical link: https://commits.webkit.org/277910@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] ba9d66: MiniBrowser Build Fix w/ Release Builds
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: ba9d663c6686b5926899ff9897f597cea985a5f1 https://github.com/WebKit/WebKit/commit/ba9d663c6686b5926899ff9897f597cea985a5f1 Author: Brandon Stewart Date: 2024-04-23 (Tue, 23 Apr 2024) Changed paths: M Tools/MiniBrowser/mac/AppDelegate.h M Tools/MiniBrowser/mac/MiniBrowser_Prefix.pch M Tools/MiniBrowser/mac/WK2BrowserWindowController.h Log Message: --- MiniBrowser Build Fix w/ Release Builds https://bugs.webkit.org/show_bug.cgi?id=273140 Reviewed by Elliott Williams. MiniBrowser was seeing certain headers multiple times due to includes. This was causing a build failure on certain SDKs. >From talking with Elliott, removing the #import webkit from the pch and moving it to the select headers files resolved the problem. * Tools/MiniBrowser/mac/AppDelegate.h: * Tools/MiniBrowser/mac/MiniBrowser_Prefix.pch: * Tools/MiniBrowser/mac/WK2BrowserWindowController.h: Canonical link: https://commits.webkit.org/277909@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] ecd31a: Add --js-builtin option to generate-sampling-profi...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: ecd31acfa9f1371c758d65498b9f775ddb5e7736 https://github.com/WebKit/WebKit/commit/ecd31acfa9f1371c758d65498b9f775ddb5e7736 Author: Yusuke Suzuki Date: 2024-04-23 (Tue, 23 Apr 2024) Changed paths: M Tools/Scripts/generate-sampling-profiler-flame-graph Log Message: --- Add --js-builtin option to generate-sampling-profiler-flame-graph https://bugs.webkit.org/show_bug.cgi?id=273147 rdar://126941714 Reviewed by Keith Miller. This is an option which annotate frame with `/JSBUILTIN` if it is JS builtin function in sampling profiler. * Tools/Scripts/generate-sampling-profiler-flame-graph: Canonical link: https://commits.webkit.org/277908@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] c318bf: [Remote Inspection] Add support for targets in nes...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: c318bffec39ae54ee6bcfefaf129d1ab52790bde https://github.com/WebKit/WebKit/commit/c318bffec39ae54ee6bcfefaf129d1ab52790bde Author: Wenson Hsieh Date: 2024-04-23 (Tue, 23 Apr 2024) Changed paths: M Source/WebCore/loader/DocumentLoader.h M Source/WebCore/page/ElementTargetingController.cpp M Source/WebCore/page/ElementTargetingController.h M Source/WebCore/page/ElementTargetingTypes.h M Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in M Source/WebKit/Shared/WebsitePoliciesData.h M Source/WebKit/Shared/WebsitePoliciesData.serialization.in M Source/WebKit/UIProcess/API/APITargetedElementInfo.h M Source/WebKit/UIProcess/API/APIWebsitePolicies.h M Source/WebKit/UIProcess/API/Cocoa/WKWebpagePreferences.mm M Source/WebKit/UIProcess/API/Cocoa/WKWebpagePreferencesPrivate.h M Source/WebKit/UIProcess/API/Cocoa/_WKTargetedElementInfo.h M Source/WebKit/UIProcess/API/Cocoa/_WKTargetedElementInfo.mm M Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj M Tools/TestWebKitAPI/Tests/WebKitCocoa/ElementTargetingTests.mm A Tools/TestWebKitAPI/Tests/WebKitCocoa/element-targeting-8.html Log Message: --- [Remote Inspection] Add support for targets in nested shadow roots https://bugs.webkit.org/show_bug.cgi?id=273076 rdar://123160948 Reviewed by Tim Horton, Abrar Protyasha and Aditya Keerthi. Currently, `visibilityAdjustmentSelectors` is a flattened list of CSS selectors, which correspond to an arbitrary number of targeted elements. This has a couple of drawbacks: 1. We might resolve more targets than there originally were (in the case where a targeted element had multiple potential selectors, but one of them now maps to something else). 2. It's unable to resolve targeted elements inside of shadow roots. I previously worked around this in 277171@main by just returning an empty list in the case where the element is inside of a shadow tree, but that only fixed the case where the targeted element itself contained a shadow root (rather than being inside of the shadow DOM). This patch actually fixes this issue, by revamping how we both surface and ingest CSS selectors corresponding to targeted elements: • `TargetedElementInfo` now contains a array of array of selectors. Each element in the outer array corresponds to an enclosing shadow host element that contains the targeted element (such that the final array maps to the targeted element itself). For targets that are not inside shadow roots, this simply means that there's a single outer array. The inner array, like before, represents a array of selectors (sorted by length) that can be used to resolve the target (or shadow host containing the target) within its tree scope. • `WKWebpagePreferences` now has a `_visibilityAdjustmentSelectorsIncludingShadowHosts` property, which consists of an array of array of sets of strings. To unpack this: 1. Each array in the outermost (first) array represents a single targeted element. 2. Each set in the second array represents a targeted element or shadow host containing the targeted element. The last element is the targeted element itself, and the first element (if the targeted element is inside of a shadow root) is the outermost shadow host element in the document. 3. Each string in the set represents a CSS selector that can potentially be used to resolve the targeted element or one of its hosts, within its tree scope. To make this work, we: (a) Make `TargetedElementController` recursively ascend the DOM by shadow host, to construct a `Vector>` for each targeted element. (b) Teach `TargetedElementController` to ingest the array of array of sets described above to resolve targeted elements that reside inside shadow trees. There is no change in behavior for the case where targeted elements aren't inside the shadow DOM. Test: ElementTargeting.AdjustVisibilityForTargetsInShadowRoot * Source/WebCore/loader/DocumentLoader.h: (WebCore::DocumentLoader::visibilityAdjustmentSelectors const): (WebCore::DocumentLoader::setVisibilityAdjustmentSelectors): * Source/WebCore/page/ElementTargetingController.cpp: (WebCore::querySelectorMatchesOneElement): (WebCore::computeIDSelector): (WebCore::selectorsForTarget): For elements inside of shadow roots, teach this to recursively find selectors that resolve to shadow hosts, and return a list of lists of selectors. (WebCore::targetedElementInfo): (WebCore::ElementTargetingController::applyVisibilityAdjustmentFromSelectors): Teach this to apply visibility adjustment to content inside of shadow roots. * Source/WebCore/page/ElementTargetingController.h: * Source/WebCore/page/ElementTargetingTypes.h: * Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in: Turn the list of selectors for each targeted
[webkit-changes] [WebKit/WebKit] 5ca7d6: REGRESSION(277648@main) Breaks prewarmed safari pr...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 5ca7d6c795619fb7baf3d28ecaffcef5e6b69f69 https://github.com/WebKit/WebKit/commit/5ca7d6c795619fb7baf3d28ecaffcef5e6b69f69 Author: Keith Miller Date: 2024-04-23 (Tue, 23 Apr 2024) Changed paths: M Source/JavaScriptCore/jsc.cpp M Source/JavaScriptCore/runtime/InitializeThreading.cpp M Source/JavaScriptCore/runtime/JSCConfig.cpp M Source/JavaScriptCore/runtime/JSCConfig.h M Source/JavaScriptCore/runtime/VM.cpp M Source/JavaScriptCore/runtime/VMEntryScope.cpp M Source/JavaScriptCore/runtime/VMTraps.cpp M Source/JavaScriptCore/tools/JSDollarVM.cpp M Source/JavaScriptCore/wasm/WasmFaultSignalHandler.cpp M Source/JavaScriptCore/wasm/WasmFaultSignalHandler.h M Source/WTF/wtf/CryptographicallyRandomNumber.cpp M Source/WTF/wtf/CryptographicallyRandomNumber.h M Source/WTF/wtf/PlatformRegisters.cpp M Source/WTF/wtf/Threading.cpp M Source/WTF/wtf/WTFConfig.cpp M Source/WTF/wtf/WTFConfig.h M Source/WTF/wtf/threads/Signals.cpp M Source/WTF/wtf/threads/Signals.h M Source/WTF/wtf/win/SignalsWin.cpp M Source/WebKit/GPUProcess/EntryPoint/Cocoa/XPCService/GPUServiceEntryPoint.mm M Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in M Tools/DumpRenderTree/mac/DumpRenderTree.mm M Tools/TestWebKitAPI/Tests/WTF/Signals.cpp Log Message: --- REGRESSION(277648@main) Breaks prewarmed safari processes https://bugs.webkit.org/show_bug.cgi?id=273157 rdar://126767343 Unreviewed, revert. * Source/JavaScriptCore/jsc.cpp: (main): (CommandLine::parseArguments): * Source/JavaScriptCore/runtime/InitializeThreading.cpp: (JSC::initialize): * Source/JavaScriptCore/runtime/JSCConfig.cpp: (JSC::Config::disableFreezingForTesting): * Source/JavaScriptCore/runtime/JSCConfig.h: (JSC::Config::permanentlyFreeze): (JSC::Config::disableFreezingForTesting): Deleted. (JSC::Config::finalize): Deleted. * Source/JavaScriptCore/runtime/VM.cpp: (JSC::VM::VM): * Source/JavaScriptCore/runtime/VMEntryScope.cpp: (JSC::VMEntryScope::setUpSlow): * Source/JavaScriptCore/runtime/VMTraps.cpp: * Source/JavaScriptCore/tools/JSDollarVM.cpp: (JSC::JSC_DEFINE_HOST_FUNCTION_WITH_ATTRIBUTES): * Source/JavaScriptCore/wasm/WasmFaultSignalHandler.cpp: (JSC::Wasm::MachExceptionSigningKey::MachExceptionSigningKey): (JSC::Wasm::trapHandler): (JSC::Wasm::activateSignalingMemory): (JSC::Wasm::prepareSignalingMemory): (): Deleted. * Source/JavaScriptCore/wasm/WasmFaultSignalHandler.h: * Source/WTF/wtf/CryptographicallyRandomNumber.cpp: (WTF::cryptographicallyRandomNumber): (WTF::cryptographicallyRandomNumber): (WTF::cryptographicallyRandomNumber): Deleted. * Source/WTF/wtf/CryptographicallyRandomNumber.h: * Source/WTF/wtf/PlatformRegisters.cpp: (WTF::threadStatePCInternal): * Source/WTF/wtf/Threading.cpp: (WTF::initialize): * Source/WTF/wtf/WTFConfig.cpp: (WTF::Config::initialize): (WTF::Config::permanentlyFreeze): (WTF::Config::finalize): Deleted. (WTF::Config::disableFreezingForTesting): Deleted. * Source/WTF/wtf/WTFConfig.h: * Source/WTF/wtf/threads/Signals.cpp: (WTF::SignalHandlers::add): (WTF::initMachExceptionHandlerThread): (WTF::setExceptionPorts): (WTF::activeThreads): (WTF::registerThreadForMachExceptionHandling): (WTF::addSignalHandler): (WTF::activateSignalHandlersFor): (WTF::finalizeSignalHandlers): (WTF::jscSignalHandler): (WTF::SignalHandlers::initialize): (WTF::SignalHandlers::presignReturnPCForHandler): Deleted. (WTF::toMachMask): Deleted. (WTF::SignalHandlers::finalize): Deleted. * Source/WTF/wtf/threads/Signals.h: (WTF::toMachMask): (WTF::initializeSignalHandling): (WTF::disableSignalHandling): * Source/WTF/wtf/win/SignalsWin.cpp: (WTF::SignalHandlers::add): (WTF::addSignalHandler): (WTF::activateSignalHandlersFor): (WTF::SignalHandlers::initialize): (WTF::finalizeSignalHandlers): (WTF::SignalHandlers::finalize): Deleted. * Source/WebKit/GPUProcess/EntryPoint/Cocoa/XPCService/GPUServiceEntryPoint.mm: (GPU_SERVICE_INITIALIZER): * Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in: * Tools/DumpRenderTree/mac/DumpRenderTree.mm: (testOptionsForTest): * Tools/TestWebKitAPI/Tests/WTF/Signals.cpp: (TEST(Signals, SignalsWorkOnExit)): (TEST(Signals, SignalsAccessFault)): Canonical link: https://commits.webkit.org/277906@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 6ff267: Update grid3 demo images and add dimensions in markup
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 6ff2672a1392a5aaf056bba35ba3e031a9e4c362 https://github.com/WebKit/WebKit/commit/6ff2672a1392a5aaf056bba35ba3e031a9e4c362 Author: Jonathan Davis Date: 2024-04-23 (Tue, 23 Apr 2024) Changed paths: M Websites/webkit.org/demos/grid3/index.html M Websites/webkit.org/demos/grid3/megamenu/index.html M Websites/webkit.org/demos/grid3/megamenu/styles.css M Websites/webkit.org/demos/grid3/museum/images/National_Gallery_of_Art.png M Websites/webkit.org/demos/grid3/museum/images/a_vestal_1952.5.99.jpg M Websites/webkit.org/demos/grid3/museum/images/basket_1943.8.6537.jpg M Websites/webkit.org/demos/grid3/museum/images/boy_in_blue_coat_1959.11.5.jpg M Websites/webkit.org/demos/grid3/museum/images/catherine_brower_1956.13.5.jpg M Websites/webkit.org/demos/grid3/museum/images/detail_of_painting_on_altar_panel_1943.8.5992.jpg M Websites/webkit.org/demos/grid3/museum/images/feeding_the_bird_1953.5.63.jpg M Websites/webkit.org/demos/grid3/museum/images/flowers_in_a_vase_1976.26.2.jpg M Websites/webkit.org/demos/grid3/museum/images/hunting_scene_with_a_pond_1970.17.102.jpg M Websites/webkit.org/demos/grid3/museum/images/john_stuart-wortle_2nd_baron_wharncliffe_2007.jpg M Websites/webkit.org/demos/grid3/museum/images/keelmen_heaving_in_coals_by_moonlight_1942.9.86.jpg M Websites/webkit.org/demos/grid3/museum/images/mademoiselle_sicot_1963.10.209.jpg M Websites/webkit.org/demos/grid3/museum/images/miss_van_alen_1956.13.14.jpg M Websites/webkit.org/demos/grid3/museum/images/niagara_2014.79.10.jpg M Websites/webkit.org/demos/grid3/museum/images/painted_chest_1943.8.7517.jpg M Websites/webkit.org/demos/grid3/museum/images/portrait_of_a_man_1943.7.3.jpg M Websites/webkit.org/demos/grid3/museum/images/retablo_1943.8.6831.jpg M Websites/webkit.org/demos/grid3/museum/images/self-portrait_dedicated_to_carriere_1985.64.20.jpg M Websites/webkit.org/demos/grid3/museum/images/side_of_chest_1943.8.7520.jpg M Websites/webkit.org/demos/grid3/museum/images/study_for__army_boots___verso__1996.121.6.b.jpg M Websites/webkit.org/demos/grid3/museum/images/the_house_of_representatives_2014.79.27.jpg M Websites/webkit.org/demos/grid3/museum/images/the_island_and_bridge_of_san_bartolomeo_rome_2001.23.1.jpg M Websites/webkit.org/demos/grid3/museum/images/the_japanese_footbridge_1992.9.1.jpg M Websites/webkit.org/demos/grid3/museum/images/the_trap_1994.59.13.jpg M Websites/webkit.org/demos/grid3/museum/images/view_of_the_mall_in_saint_jamespark_1970.17.132.jpg M Websites/webkit.org/demos/grid3/museum/index.html M Websites/webkit.org/demos/grid3/museum/museum.js M Websites/webkit.org/demos/grid3/museum/styles.css M Websites/webkit.org/demos/grid3/newspaper/index.html M Websites/webkit.org/demos/grid3/photos/index.html A Websites/webkit.org/demos/grid3/photos/photos/adam-bignell-Frt_UFRKMvc-unsplash.jpg A Websites/webkit.org/demos/grid3/photos/photos/agata-ciosek-eppywzUKWzA-unsplash.jpg A Websites/webkit.org/demos/grid3/photos/photos/alexandr-istomin-QmuHSij3bzk-unsplash.jpg A Websites/webkit.org/demos/grid3/photos/photos/andrea-de-santis-KF52HaIDtyM-unsplash.jpg A Websites/webkit.org/demos/grid3/photos/photos/andrew-keymaster-KiXccYM2eQo-unsplash.jpg A Websites/webkit.org/demos/grid3/photos/photos/annie-spratt-VfXZg_-8f6A-unsplash.jpg A Websites/webkit.org/demos/grid3/photos/photos/barthelemy-de-mazenod-rRLZZ8BHZNo-unsplash.jpg A Websites/webkit.org/demos/grid3/photos/photos/benoit-deschasaux-WSsW8EpMaeQ-unsplash.jpg A Websites/webkit.org/demos/grid3/photos/photos/blaire-harmon-HkG8cOpvUkU-unsplash.jpg A Websites/webkit.org/demos/grid3/photos/photos/bundo-kim-VRbd6ss_LJI-unsplash.jpg A Websites/webkit.org/demos/grid3/photos/photos/catia-dombaxe-cPFYcoMAi-I-unsplash.jpg A Websites/webkit.org/demos/grid3/photos/photos/chalo-gallardo-F01kfMEodyk-unsplash.jpg A Websites/webkit.org/demos/grid3/photos/photos/ciocan-ciprian-armvMS3dYng-unsplash.jpg A Websites/webkit.org/demos/grid3/photos/photos/clark-van-der-beken-IImZQk78xe0-unsplash.jpg A Websites/webkit.org/demos/grid3/photos/photos/clay-banks-RRjC0r8GwpI-unsplash.jpg A Websites/webkit.org/demos/grid3/photos/photos/clay-banks-X1vQu69kV48-unsplash.jpg A Websites/webkit.org/demos/grid3/photos/photos/clement-m-h7vKkZNNThE-unsplash.jpg A Websites/webkit.org/demos/grid3/photos/photos/clement-proust-m3StSUrsi3I-unsplash.jpg A Websites/webkit.org/demos/grid3/photos/photos/cristina-gottardi-CSpjU6hYo_0-unsplash.jpg A Websites/webkit.org/demos/grid3/photos/photos/cristina-gottardi-KX_214Qr7Ko-unsplash.jpg A Websites/webkit.org/demos/grid3/photos/photos/daniel-j-schwarz-6oKyf2Pip6Y-unsplash.jpg A Websites/webkit.org/demos/grid3/photos/photos/daniel-lerman-7bZi3hfM_
[webkit-changes] [WebKit/WebKit] 619e39: Build failure with -Werror=overloaded-virtual on G...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 619e39d2eab19c9e206788a0f351897b312cefb9 https://github.com/WebKit/WebKit/commit/619e39d2eab19c9e206788a0f351897b312cefb9 Author: Carlos Bentzen Date: 2024-04-23 (Tue, 23 Apr 2024) Changed paths: M Source/WebKit/WebProcess/Network/WebSocketChannel.cpp M Source/WebKit/WebProcess/Network/WebSocketChannel.h Log Message: --- Build failure with -Werror=overloaded-virtual on GCC 13 https://bugs.webkit.org/show_bug.cgi?id=273097 Reviewed by Darin Adler. WebSocketChannel inherits from IPC::MessageSender which has a virtual sendMessage() method. However, WebSocketChannel also had a private sendMessage() method which was overloading IPC::MessageSender::sendMessage(). There is a warning for this with -Woverloaded-virtual in GCC, which is included in -Wall on GCC 13. Coupled with -Werror, we get a build failure in developer mode. To fix this, renamed WebSocketChannel's sendMessage to sendMessageInternal. * Source/WebKit/WebProcess/Network/WebSocketChannel.cpp: (WebKit::WebSocketChannel::createMessageQueue): (WebKit::WebSocketChannel::sendMessageInternal): (WebKit::WebSocketChannel::sendMessage): Deleted. * Source/WebKit/WebProcess/Network/WebSocketChannel.h: Canonical link: https://commits.webkit.org/277904@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] f3b58b: [PlayStation] Remove compiler workaround following...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: f3b58bf1fdf2e271e1ac10fd933458df78c86429 https://github.com/WebKit/WebKit/commit/f3b58bf1fdf2e271e1ac10fd933458df78c86429 Author: Ross Kirsling Date: 2024-04-23 (Tue, 23 Apr 2024) Changed paths: M Source/cmake/OptionsPlayStation.cmake Log Message: --- [PlayStation] Remove compiler workaround following gtest upgrade https://bugs.webkit.org/show_bug.cgi?id=273119 Reviewed by Don Olmstead. Following the googletest upgrade in 277635@main, PlayStation no longer needs to undefine __cpp_char8_t. Accordingly, we can revert 268268@main, which silenced a clang warning. * Source/cmake/OptionsPlayStation.cmake: Remove -Wno-builtin-macro-redefined. Canonical link: https://commits.webkit.org/277903@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 900ffe: [JSC] More aggressive application of call_ignore_r...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 900ffeb07aa4f5175cac8b4233a87eb5b6046386 https://github.com/WebKit/WebKit/commit/900ffeb07aa4f5175cac8b4233a87eb5b6046386 Author: Yusuke Suzuki Date: 2024-04-23 (Tue, 23 Apr 2024) Changed paths: M Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp M Source/JavaScriptCore/bytecompiler/BytecodeGenerator.h Log Message: --- [JSC] More aggressive application of call_ignore_result https://bugs.webkit.org/show_bug.cgi?id=273146 rdar://126940736 Reviewed by Alexey Shvayka. When we are passing ignoredResult explicitly, we do not need to inherit m_allowCallIgnoreResultOptimization. We can just revert it back to the default value. This further extends call_ignore_result coverage. * Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp: (JSC::BytecodeGenerator::BytecodeGenerator): * Source/JavaScriptCore/bytecompiler/BytecodeGenerator.h: (JSC::BytecodeGenerator::emitNodeInIgnoreResultPosition): Canonical link: https://commits.webkit.org/277902@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 091399: Unified build fixes
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 09139952a7fd36e5485cc36717d081d9f3ffca67 https://github.com/WebKit/WebKit/commit/09139952a7fd36e5485cc36717d081d9f3ffca67 Author: Claudio Saavedra Date: 2024-04-23 (Tue, 23 Apr 2024) Changed paths: M Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp M Source/JavaScriptCore/dfg/DFGDesiredWeakReferences.cpp M Source/JavaScriptCore/dfg/DFGDesiredWeakReferences.h M Source/JavaScriptCore/dfg/DFGFinalizer.cpp M Source/JavaScriptCore/dfg/DFGFinalizer.h M Source/JavaScriptCore/dfg/DFGPlan.cpp M Source/JavaScriptCore/dfg/DFGStoreBarrierInsertionPhase.cpp M Source/JavaScriptCore/wasm/js/WebAssemblyTagConstructor.h M Source/WTF/wtf/CommaPrinter.h M Source/WebCore/Modules/mediastream/UserMediaRequest.cpp M Source/WebCore/accessibility/AccessibilityMenuListOption.h M Source/WebCore/accessibility/AccessibilityObject.cpp M Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm M Source/WebCore/bindings/js/DOMWrapperWorld.cpp M Source/WebCore/bindings/js/JSDOMGuardedObject.h M Source/WebCore/bindings/js/JSDOMPromise.cpp M Source/WebCore/bindings/js/JSTrustedTypePolicyFactoryCustom.cpp M Source/WebCore/bindings/js/WindowProxy.cpp M Source/WebCore/crypto/algorithms/CryptoAlgorithmECDSA.cpp M Source/WebCore/crypto/algorithms/CryptoAlgorithmEd25519.cpp M Source/WebCore/css/CSSFontVariantLigaturesParser.h M Source/WebCore/css/ComputedStyleExtractor.cpp M Source/WebCore/css/parser/CSSCalcParser.cpp M Source/WebCore/css/parser/CSSCalcParser.h M Source/WebCore/css/parser/CSSPropertyParser.cpp M Source/WebCore/css/parser/CSSPropertyParserConsumer+Angle.cpp M Source/WebCore/css/parser/CSSPropertyParserConsumer+Angle.h M Source/WebCore/css/parser/CSSPropertyParserConsumer+Color.cpp M Source/WebCore/css/parser/CSSPropertyParserConsumer+Length.cpp M Source/WebCore/css/parser/CSSPropertyParserConsumer+Length.h M Source/WebCore/css/parser/CSSPropertyParserConsumer+Meta.h M Source/WebCore/css/parser/CSSPropertyParserConsumer+None.cpp M Source/WebCore/css/parser/CSSPropertyParserConsumer+Number.cpp M Source/WebCore/css/parser/CSSPropertyParserConsumer+Number.h M Source/WebCore/css/parser/CSSPropertyParserConsumer+Percent.cpp M Source/WebCore/css/parser/CSSPropertyParserConsumer+Resolution.cpp M Source/WebCore/css/parser/CSSPropertyParserConsumer+Resolution.h M Source/WebCore/css/parser/CSSPropertyParserConsumer+Time.cpp M Source/WebCore/css/parser/CSSPropertyParserConsumer+Time.h M Source/WebCore/dom/GetHTMLOptions.h M Source/WebCore/dom/IdleCallbackController.cpp M Source/WebCore/dom/TrustedTypePolicy.cpp M Source/WebCore/dom/WindowOrWorkerGlobalScopeTrustedTypes.cpp M Source/WebCore/dom/WindowOrWorkerGlobalScopeTrustedTypes.h M Source/WebCore/editing/FrameSelection.cpp M Source/WebCore/html/track/TrackBase.cpp M Source/WebCore/inspector/InspectorFrontendAPIDispatcher.cpp M Source/WebCore/inspector/InspectorFrontendClientLocal.cpp M Source/WebCore/layout/formattingContexts/inline/RangeBasedLineBuilder.cpp M Source/WebCore/layout/formattingContexts/inline/invalidation/InlineInvalidation.cpp M Source/WebCore/layout/formattingContexts/inline/text/TextBreakingPositionCache.cpp M Source/WebCore/loader/ImageLoader.cpp M Source/WebCore/page/DOMWindow.cpp M Source/WebCore/page/DebugPageOverlays.cpp M Source/WebCore/page/ElementTargetingController.h M Source/WebCore/page/NavigationDestination.cpp M Source/WebCore/page/UndoItem.cpp M Source/WebCore/page/UndoItem.h M Source/WebCore/page/WheelEventTestMonitor.h M Source/WebCore/platform/graphics/gbm/DRMDeviceManager.cpp M Source/WebCore/platform/graphics/gbm/DRMDeviceManager.h M Source/WebCore/rendering/EventRegion.h M Source/WebCore/rendering/GlyphDisplayListCache.cpp M Source/WebCore/rendering/RenderLayerBacking.cpp M Source/WebCore/rendering/style/StyleSelfAlignmentData.h M Source/WebKit/Shared/ProcessTerminationReason.cpp M Source/WebKit/Shared/WebCoreArgumentCoders.cpp M Source/WebKit/Shared/WebEvent.cpp M Source/WebKit/UIProcess/Notifications/glib/NotificationService.cpp M Source/WebKit/UIProcess/geoclue/GeoclueGeolocationProvider.cpp Log Message: --- Unified build fixes https://bugs.webkit.org/show_bug.cgi?id=273092 Unreviewed build fix. * Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp: * Source/JavaScriptCore/dfg/DFGDesiredWeakReferences.cpp: * Source/JavaScriptCore/dfg/DFGDesiredWeakReferences.h: * Source/JavaScriptCore/dfg/DFGFinalizer.cpp: * Source/JavaScriptCore/dfg/DFGFinalizer.h: * Source/JavaScriptCore/dfg/DFGPlan.cpp: * Source/JavaScriptCore/dfg/DFGStoreBarrierInsertionPhase.cpp: * Source/JavaScriptCore/wasm/js/WebAssemblyTagConstructor.h: * Source/WTF/wtf/CommaPrinter.h: * Source/We
[webkit-changes] [WebKit/WebKit] 8b7b1a: [JSC] Relax arraySpeciesWatchpointIsValid condition
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 8b7b1a1b94a005149bbc517244ae80bbc87029b9 https://github.com/WebKit/WebKit/commit/8b7b1a1b94a005149bbc517244ae80bbc87029b9 Author: Yusuke Suzuki Date: 2024-04-23 (Tue, 23 Apr 2024) Changed paths: A JSTests/stress/array-splice-constructor.js M Source/JavaScriptCore/runtime/ArrayPrototype.cpp M Source/JavaScriptCore/runtime/ArrayPrototypeInlines.h Log Message: --- [JSC] Relax arraySpeciesWatchpointIsValid condition https://bugs.webkit.org/show_bug.cgi?id=273143 rdar://126938733 Reviewed by Alexey Shvayka. This patch relaxes arraySpeciesWatchpointIsValid condition so that we can accept Array with unrelated properties for the fast path. * JSTests/stress/array-splice-constructor.js: Added. (shouldBe): (throw.new.Error): (shouldBe.array): * Source/JavaScriptCore/runtime/ArrayPrototype.cpp: (JSC::JSC_DEFINE_HOST_FUNCTION): * Source/JavaScriptCore/runtime/ArrayPrototypeInlines.h: (JSC::arraySpeciesWatchpointIsValid): Canonical link: https://commits.webkit.org/277900@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] f36efd: [Tools][GTK][WPE] generate backtraces with GDB usi...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: f36efdeb89fbea238cf363310fe7144f9eac0e30 https://github.com/WebKit/WebKit/commit/f36efdeb89fbea238cf363310fe7144f9eac0e30 Author: Carlos Alberto Lopez Perez Date: 2024-04-23 (Tue, 23 Apr 2024) Changed paths: M Tools/Scripts/webkitpy/port/linux_get_crash_log.py Log Message: --- [Tools][GTK][WPE] generate backtraces with GDB using lower CPU priority https://bugs.webkit.org/show_bug.cgi?id=273145 Reviewed by Michael Catanzaro. GDB may use quite a lot of CPU to generate a backtrace when it is invoked when a test crashes. This may cause that other test process compete with the CPU with GDB leading to random timeouts on the tests. To help with that, run the GDB process with lower priority. * Tools/Scripts/webkitpy/port/linux_get_crash_log.py: (GDBCrashLogGenerator._get_gdb_output): Canonical link: https://commits.webkit.org/277899@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 1ad20f: Turn on HAVE_ONLY_MODERN_SERIALIZATION for Windows
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 1ad20fe37f2075252dc66fbed60b9a624d22a70a https://github.com/WebKit/WebKit/commit/1ad20fe37f2075252dc66fbed60b9a624d22a70a Author: Don Olmstead Date: 2024-04-23 (Tue, 23 Apr 2024) Changed paths: M Source/WTF/wtf/PlatformHave.h Log Message: --- Turn on HAVE_ONLY_MODERN_SERIALIZATION for Windows https://bugs.webkit.org/show_bug.cgi?id=273144 Reviewed by Alex Christensen. The Windows port builds using only modern serialization. Turn on the build flag flag for this. Correct the flag name in `PlatformHave.h`. Remove `PLATFORM(COCOA)` since it doesn't compile with this flag. * Source/WTF/wtf/PlatformHave.h: Canonical link: https://commits.webkit.org/277898@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 87d123: REGRESSION (275888@main): [ Ventura ] tables/mozil...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 87d123dcab61fe2b1fcefc47ee0c9089d2870e75 https://github.com/WebKit/WebKit/commit/87d123dcab61fe2b1fcefc47ee0c9089d2870e75 Author: Jay Stfleur Date: 2024-04-23 (Tue, 23 Apr 2024) Changed paths: M LayoutTests/platform/mac/TestExpectations Log Message: --- REGRESSION (275888@main): [ Ventura ] tables/mozilla/bugs/bug12384.html is a constant failure https://bugs.webkit.org/show_bug.cgi?id=270939 rdar://124558965 Unreviewed test gardening. Removing test expectation since test is passing. * LayoutTests/platform/mac/TestExpectations: Canonical link: https://commits.webkit.org/277897@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] e147cc: Fix crash when using Site Isolation debug overlay ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: e147cc2e73f0bc2c8057354508b45b8f6058ed59 https://github.com/WebKit/WebKit/commit/e147cc2e73f0bc2c8057354508b45b8f6058ed59 Author: Pascoe Date: 2024-04-23 (Tue, 23 Apr 2024) Changed paths: M Source/WebKit/UIProcess/RemoteLayerTree/RemoteLayerTreeDrawingAreaProxy.mm Log Message: --- Fix crash when using Site Isolation debug overlay in debug build https://bugs.webkit.org/show_bug.cgi?id=273142 rdar://126938019 Reviewed by Sihui Liu. This lock was added https://bugs.webkit.org/show_bug.cgi?id=266026 but no lock/unlocking code was added for debug overlays, which causes the lockIsHeld assertion to crash when using debug overlays within a debug build. This patch fixes that by holding the lock for debug overlays. * Source/WebKit/UIProcess/RemoteLayerTree/RemoteLayerTreeDrawingAreaProxy.mm: (WebKit::RemoteLayerTreeDrawingAreaProxy::commitLayerTreeTransaction): Canonical link: https://commits.webkit.org/277896@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] dcc459: REGRESSION (276119@main): [ macOS iOS ] http/tests...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: dcc459d3e3ea455c20c6ed05e7c0a7a7bb0edab9 https://github.com/WebKit/WebKit/commit/dcc459d3e3ea455c20c6ed05e7c0a7a7bb0edab9 Author: Jay Stfleur Date: 2024-04-23 (Tue, 23 Apr 2024) Changed paths: M LayoutTests/platform/ios/TestExpectations M LayoutTests/platform/mac-wk2/TestExpectations Log Message: --- REGRESSION (276119@main): [ macOS iOS ] http/tests/navigation/page-cache-getUserMedia-pending-promise.html is a flaky timeout https://bugs.webkit.org/show_bug.cgi?id=271063 rdar://124698382 Unreviewed test gardening. Removing test expectation after confirming test is passing. * LayoutTests/platform/ios/TestExpectations: * LayoutTests/platform/mac-wk2/TestExpectations: Canonical link: https://commits.webkit.org/277895@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 95019f: AX: Remove AccessibilityRole::ApplicationGroup and...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 95019f166e2d4977a3d917d6814b9971acb54def https://github.com/WebKit/WebKit/commit/95019f166e2d4977a3d917d6814b9971acb54def Author: Tyler Wilcock Date: 2024-04-23 (Tue, 23 Apr 2024) Changed paths: M LayoutTests/accessibility/list-detection2-expected.txt M LayoutTests/accessibility/list-detection2.html M LayoutTests/accessibility/mac/basic-embed-pdf-accessibility-expected.txt M LayoutTests/accessibility/mac/basic-embed-pdf-accessibility.html M LayoutTests/imported/w3c/web-platform-tests/css/css-display/accessibility/display-contents-role-and-label-expected.txt M LayoutTests/imported/w3c/web-platform-tests/svg-aam/role/roles-expected.txt M LayoutTests/imported/w3c/web-platform-tests/svg-aam/role/roles-generic-expected.txt M LayoutTests/platform/ios/accessibility/changing-aria-hidden-with-display-none-parent-expected.txt M LayoutTests/platform/ios/accessibility/list-with-dynamically-changing-content-expected.txt M LayoutTests/platform/mac-wk2/accessibility/aria-visible-element-roles-expected.txt M Source/WebCore/accessibility/AXCoreObject.cpp M Source/WebCore/accessibility/AXCoreObject.h M Source/WebCore/accessibility/AccessibilityLabel.cpp M Source/WebCore/accessibility/AccessibilityList.cpp M Source/WebCore/accessibility/AccessibilityNodeObject.cpp M Source/WebCore/accessibility/AccessibilityObject.cpp M Source/WebCore/accessibility/AccessibilityRenderObject.cpp M Source/WebCore/accessibility/AccessibilitySVGElement.cpp M Source/WebCore/accessibility/AccessibilitySVGRoot.cpp M Source/WebCore/accessibility/AccessibilityTree.cpp M Source/WebCore/accessibility/atspi/AccessibilityAtspi.cpp M Source/WebCore/accessibility/atspi/AccessibilityObjectAtspi.cpp M Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm M Source/WebCore/accessibility/mac/AccessibilityObjectMac.mm Log Message: --- AX: Remove AccessibilityRole::ApplicationGroup and AccessibilityRole::ApplicationTextGroup to simplify group logic https://bugs.webkit.org/show_bug.cgi?id=273089 rdar://126880483 Reviewed by Chris Fleizach. Currently, there are four "group" roles: Group, ApplicationGroup, TextGroup, ApplicationTextGroup. The original intention for separating these was that the Application style roles were explicitly defined by the author (e.g. via role="group" for ApplicationGroup and role="doc-example" for ApplicationTextGroup), while the non-Application variants were implicitly assigned via heuristics done by the user agent (WebKit). However, that distinction has become muddied over time: 1. To support Web Inspector and WPTs, AccessibilityRole::Group has become synonymous with "generic" (mostly because we used to assign this role to nearly every div on the page). This is confusing because it doesn't match or map to role="group" (which is AccessibilityRole::ApplicationGroup). 2. Partially due to point one, in several places we have started returning ApplicationGroup even when the element is not explicitly assigned as such (i.e. via role="group"), going against the point of this role's existence. With this patch, ApplicationGroup and ApplicationTextGroup are eliminated. Any context that needs to know whether an object has that role due to explicit definition via ARIA can do so by checking ariaRoleAttribute(). This makes our code more clear in several different ways. This patch fixes two WPT tests and breaks one. The broken will be fixed in a follow-up. * LayoutTests/accessibility/list-detection2-expected.txt: * LayoutTests/accessibility/list-detection2.html: * LayoutTests/accessibility/mac/basic-embed-pdf-accessibility-expected.txt: * LayoutTests/accessibility/mac/basic-embed-pdf-accessibility.html: * LayoutTests/imported/w3c/web-platform-tests/css/css-display/accessibility/display-contents-role-and-label-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/svg-aam/role/roles-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/svg-aam/role/roles-generic-expected.txt: * LayoutTests/platform/mac-wk2/accessibility/aria-visible-element-roles-expected.txt: * Source/WebCore/accessibility/AXCoreObject.cpp: (WebCore::AXCoreObject::isGroup const): * Source/WebCore/accessibility/AXCoreObject.h: (WebCore::accessibilityRoleToString): * Source/WebCore/accessibility/AccessibilityLabel.cpp: (WebCore::childrenContainOnlyStaticText): * Source/WebCore/accessibility/AccessibilityList.cpp: (WebCore::AccessibilityList::determineAccessibilityRole): * Source/WebCore/accessibility/AccessibilityNodeObject.cpp: (WebCore::AccessibilityNodeObject::determineAccessibilityRoleFromNode const): (WebCore::AccessibilityNodeObject::hierarchicalLevel const): * Source/WebCore/accessibility/AccessibilityObject.cpp: (WebCore::AccessibilityObject::accessibleNameDerivesFromContent const): (WebCore::initializeRole
[webkit-changes] [WebKit/WebKit] 0eb520: REGRESSION (276683@main): [ iOS ] 3X imported/w3c/...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 0eb520caada1880b6e09d357ce6279ec8db6fb03 https://github.com/WebKit/WebKit/commit/0eb520caada1880b6e09d357ce6279ec8db6fb03 Author: Jay Stfleur Date: 2024-04-23 (Tue, 23 Apr 2024) Changed paths: M LayoutTests/platform/ios/TestExpectations Log Message: --- REGRESSION (276683@main): [ iOS ] 3X imported/w3c/web-platform-tests/svg/import/animate tests are consistent failures https://bugs.webkit.org/show_bug.cgi?id=271772 rdar://125499045 Unreviewed test gardening. Removing test expectations after test were confirmed passing. * LayoutTests/platform/ios/TestExpectations: Canonical link: https://commits.webkit.org/277893@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 8a3958: Remove unused legacy visionOS idiom
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 8a3958f28ab3e5111571db72aa53e624cef71e58 https://github.com/WebKit/WebKit/commit/8a3958f28ab3e5111571db72aa53e624cef71e58 Author: Tim Horton Date: 2024-04-23 (Tue, 23 Apr 2024) Changed paths: M Source/WebCore/Configurations/WebCore.xcconfig M Source/WebCore/PAL/pal/spi/cf/CoreTextSPI.h M Source/WebCore/PAL/pal/system/ios/UserInterfaceIdiom.h M Source/WebCore/PAL/pal/system/ios/UserInterfaceIdiom.mm M Source/WebCore/platform/graphics/cocoa/SystemFontDatabaseCoreText.cpp M Source/WebKit/Shared/UserInterfaceIdiom.serialization.in M Source/WebKit/Shared/WebPreferencesDefaultValues.cpp M Source/WebKit/UIProcess/ios/WebPageProxyIOS.mm Log Message: --- Remove unused legacy visionOS idiom https://bugs.webkit.org/show_bug.cgi?id=273131 rdar://126933329 Reviewed by Wenson Hsieh. * Source/WebCore/Configurations/WebCore.xcconfig: * Source/WebCore/PAL/pal/spi/cf/CoreTextSPI.h: * Source/WebCore/PAL/pal/system/ios/UserInterfaceIdiom.h: * Source/WebCore/PAL/pal/system/ios/UserInterfaceIdiom.mm: (PAL::currentUserInterfaceIdiomIsVision): (PAL::updateCurrentUserInterfaceIdiom): (PAL::currentUserInterfaceIdiomIsVisionOrVisionLegacy): Deleted. (PAL::currentUserInterfaceIdiomIsVisionLegacy): Deleted. (PAL::determineVisionSubidiom): Deleted. * Source/WebCore/platform/graphics/cocoa/SystemFontDatabaseCoreText.cpp: (WebCore::fontPlatform): * Source/WebKit/Shared/UserInterfaceIdiom.serialization.in: * Source/WebKit/Shared/WebPreferencesDefaultValues.cpp: (WebKit::defaultAlternateFormControlDesignEnabled): (WebKit::defaultVideoFullscreenRequiresElementFullscreen): * Source/WebKit/UIProcess/ios/WebPageProxyIOS.mm: (WebKit::WebPageProxy::availableScreenSize): (WebKit::WebPageProxy::overrideScreenSize): Canonical link: https://commits.webkit.org/277892@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] d44973: Propogate NaNs thru constant-folded min/max in BBQ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: d449735fb88069ee4760cd99ad3f7cf157976224 https://github.com/WebKit/WebKit/commit/d449735fb88069ee4760cd99ad3f7cf157976224 Author: Marcus Plutowski Date: 2024-04-23 (Tue, 23 Apr 2024) Changed paths: A JSTests/wasm/stress/fp-nan-minmax.js M Source/JavaScriptCore/wasm/WasmBBQJIT.cpp M Source/JavaScriptCore/wasm/WasmBBQJIT.h Log Message: --- Propogate NaNs thru constant-folded min/max in BBQ JIT https://bugs.webkit.org/show_bug.cgi?id=270262 rdar://120540053 Reviewed by Keith Miller. During constant-folding we use std::min/std::max, which the C++ standard defines as treating NaNs as "missing values" and therefore returning the non-NaN value, while conversely WASM expects us to propogate the NaN operand in all cases. * JSTests/wasm/stress/fp-nan-minmax.js: Added. (from.string_appeared_here.import.as.assert.from.string_appeared_here.let.wat.module.func.export.string_appeared_here.param.f32.f32.result.f32.local.0.local.1.f32.min.func.export.string_appeared_here.param.f32.f32.result.f32.local.0.local.1.f32.max.func.export.string_appeared_here.param.f64.f64.result.f64.local.0.local.1.f64.min.func.export.string_appeared_here.param.f64.f64.result.f64.local.0.local.1.f64.max.async test): * Source/JavaScriptCore/wasm/WasmBBQJIT.cpp: (JSC::Wasm::BBQJITImpl::BBQJIT::addF32Min): (JSC::Wasm::BBQJITImpl::BBQJIT::addF64Min): (JSC::Wasm::BBQJITImpl::BBQJIT::addF32Max): (JSC::Wasm::BBQJITImpl::BBQJIT::addF64Max): * Source/JavaScriptCore/wasm/WasmBBQJIT.h: (JSC::Wasm::BBQJITImpl::BBQJIT::computeFloatingPointMinOrMax): Canonical link: https://commits.webkit.org/277891@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 7f0262: testRunner.queueReload should use same load mechan...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 7f02621085bc6bbb17a41a54b5e922c5476bf7ea https://github.com/WebKit/WebKit/commit/7f02621085bc6bbb17a41a54b5e922c5476bf7ea Author: Alex Christensen Date: 2024-04-23 (Tue, 23 Apr 2024) Changed paths: M Tools/WebKitTestRunner/TestController.h M Tools/WebKitTestRunner/TestInvocation.cpp M Tools/WebKitTestRunner/TestInvocation.h M Tools/WebKitTestRunner/WorkQueueManager.cpp Log Message: --- testRunner.queueReload should use same load mechanism as original load when running tests with --site-isolation https://bugs.webkit.org/show_bug.cgi?id=273005 rdar://126768112 Reviewed by Sihui Liu and Charlie Wolfe. This is one of at least two things needed to get http/tests/navigation/useragent-reload.py working with --site-isolation * Tools/WebKitTestRunner/TestController.h: (WTR::TestController::currentInvocation): * Tools/WebKitTestRunner/TestInvocation.cpp: (WTR::TestInvocation::loadTestInCrossOriginIframe): (WTR::TestInvocation::invoke): * Tools/WebKitTestRunner/TestInvocation.h: * Tools/WebKitTestRunner/WorkQueueManager.cpp: (WTR::WorkQueueManager::queueReload): Canonical link: https://commits.webkit.org/277890@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 2f489a: [ iOS ] imported/w3c/web-platform-tests/css/css-tr...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 2f489a100ff0d9c8959550901620e2e7a7f004da https://github.com/WebKit/WebKit/commit/2f489a100ff0d9c8959550901620e2e7a7f004da Author: Jay Stfleur Date: 2024-04-23 (Tue, 23 Apr 2024) Changed paths: M LayoutTests/platform/ios/TestExpectations Log Message: --- [ iOS ] imported/w3c/web-platform-tests/css/css-transforms/transform3d-preserve3d-001.html is a consistent failure https://bugs.webkit.org/show_bug.cgi?id=271994 rdar://125737538 Unreviewed test gardening. Removing test expectation afer issue was fixed. * LayoutTests/platform/ios/TestExpectations: Canonical link: https://commits.webkit.org/277889@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] be5cbe: Add CryptoKit implementations for HMAC/HKDF in WebKit
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: be5cbef50e65beef09ae6956defb911329c8cb29 https://github.com/WebKit/WebKit/commit/be5cbef50e65beef09ae6956defb911329c8cb29 Author: Nitin Mahendru Date: 2024-04-23 (Tue, 23 Apr 2024) Changed paths: M LayoutTests/TestExpectations M LayoutTests/crypto/subtle/hkdf-derive-bits-length-limits-expected.txt M LayoutTests/crypto/subtle/hkdf-derive-bits-length-limits.html M Source/WebCore/Modules/webauthn/fido/Pin.cpp M Source/WebCore/PAL/PAL.xcodeproj/project.pbxproj M Source/WebCore/PAL/pal/PALSwift.h M Source/WebCore/PAL/pal/PALSwift/CryptoKitShim.swift M Source/WebCore/PAL/pal/PALSwift/UnsafeOverlays.swift A Source/WebCore/PAL/pal/PALSwiftUtils.h M Source/WebCore/crypto/algorithms/CryptoAlgorithmHKDF.cpp M Source/WebCore/crypto/algorithms/CryptoAlgorithmHKDF.h M Source/WebCore/crypto/algorithms/CryptoAlgorithmHMAC.cpp M Source/WebCore/crypto/algorithms/CryptoAlgorithmHMAC.h M Source/WebCore/crypto/cocoa/CryptoAlgorithmAESGCMMac.cpp M Source/WebCore/crypto/cocoa/CryptoAlgorithmAESKWMac.cpp M Source/WebCore/crypto/cocoa/CryptoAlgorithmECDHMac.cpp M Source/WebCore/crypto/cocoa/CryptoAlgorithmECDSAMac.cpp M Source/WebCore/crypto/cocoa/CryptoAlgorithmEd25519Cocoa.cpp M Source/WebCore/crypto/cocoa/CryptoAlgorithmHKDFMac.cpp M Source/WebCore/crypto/cocoa/CryptoAlgorithmHMACMac.cpp M Source/WebCore/crypto/cocoa/CryptoAlgorithmX25519Cocoa.cpp M Source/WebCore/crypto/cocoa/CryptoKeyECMac.cpp M Source/WebCore/crypto/gcrypt/CryptoAlgorithmHKDFGCrypt.cpp M Source/WebCore/crypto/gcrypt/CryptoAlgorithmHMACGCrypt.cpp M Source/WebCore/crypto/openssl/CryptoAlgorithmHKDFOpenSSL.cpp M Source/WebCore/crypto/openssl/CryptoAlgorithmHMACOpenSSL.cpp Log Message: --- Add CryptoKit implementations for HMAC/HKDF in WebKit rdar://126689803 https://bugs.webkit.org/show_bug.cgi?id=272879 Reviewed by Alex Christensen. Add HMAC/HKDF implementations using CryptoKit. Still disabled by default. Also: - disabled some sha224 tests. It's not part of the webcrypto standard anymore.(since 2017) - Renamed some Swift classes to not use acronyms. * Source/WebCore/Modules/webauthn/fido/Pin.cpp: (fido::pin::makePinAuth): (fido::pin::SetPinRequest::tryCreate): * Source/WebCore/PAL/PAL.xcodeproj/project.pbxproj: * Source/WebCore/PAL/pal/PALSwift.h: * Source/WebCore/PAL/pal/PALSwift/CryptoKitShim.swift: (HMAC.sign(_:data:hashFunction:)): (HMAC.verify(_:key:data:hashFunction:)): (HKDF.deriveBits(_:salt:info:outputByteCount:hashFunction:)): * Source/WebCore/PAL/pal/PALSwift/UnsafeOverlays.swift: (CryptoKit.isValidAuthenticationCode(_:data:key:)): (CryptoKit.deriveKey(_:salt:info:outputByteCount:)): * Source/WebCore/PAL/pal/PALSwiftUtils.h: Copied from Source/WebCore/PAL/pal/PALSwift.h. (WebCore::toCKHashFunction): (WebCore::isValidHashParameter): * Source/WebCore/crypto/algorithms/CryptoAlgorithmHKDF.cpp: (WebCore::CryptoAlgorithmHKDF::deriveBits): * Source/WebCore/crypto/algorithms/CryptoAlgorithmHKDF.h: * Source/WebCore/crypto/algorithms/CryptoAlgorithmHMAC.cpp: (WebCore::CryptoAlgorithmHMAC::sign): (WebCore::CryptoAlgorithmHMAC::verify): * Source/WebCore/crypto/algorithms/CryptoAlgorithmHMAC.h: * Source/WebCore/crypto/cocoa/CryptoAlgorithmECDSAMac.cpp: (WebCore::toCKHashFunction): Deleted. (WebCore::isValidHashParameter): Deleted. * Source/WebCore/crypto/cocoa/CryptoAlgorithmHKDFMac.cpp: (WebCore::platformDeriveBitsCC): (WebCore::platformDeriveBitsCryptoKit): (WebCore::CryptoAlgorithmHKDF::platformDeriveBits): * Source/WebCore/crypto/cocoa/CryptoAlgorithmHMACMac.cpp: (WebCore::platformSignCryptoKit): (WebCore::platformVerifyCryptoKit): (WebCore::platformSignCC): (WebCore::platformVerifyCC): (WebCore::CryptoAlgorithmHMAC::platformSign): (WebCore::CryptoAlgorithmHMAC::platformVerify): * Source/WebCore/crypto/gcrypt/CryptoAlgorithmHKDFGCrypt.cpp: (WebCore::CryptoAlgorithmHKDF::platformDeriveBits): * Source/WebCore/crypto/gcrypt/CryptoAlgorithmHMACGCrypt.cpp: (WebCore::CryptoAlgorithmHMAC::platformSign): (WebCore::CryptoAlgorithmHMAC::platformVerify): * Source/WebCore/crypto/openssl/CryptoAlgorithmHKDFOpenSSL.cpp: (WebCore::CryptoAlgorithmHKDF::platformDeriveBits): * Source/WebCore/crypto/openssl/CryptoAlgorithmHMACOpenSSL.cpp: (WebCore::CryptoAlgorithmHMAC::platformSign): (WebCore::CryptoAlgorithmHMAC::platformVerify): Canonical link: https://commits.webkit.org/277888@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] dca6ec: REGRESSION (277669@main): [ MacOS iOS ] imported/w...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: dca6ec38e14d781a8298cfb23ebbbc63351db19a https://github.com/WebKit/WebKit/commit/dca6ec38e14d781a8298cfb23ebbbc63351db19a Author: Jay Stfleur Date: 2024-04-23 (Tue, 23 Apr 2024) Changed paths: M LayoutTests/platform/ios/TestExpectations Log Message: --- REGRESSION (277669@main): [ MacOS iOS ] imported/w3c/web-platform-tests/css/css-contain/content-visibility/content-visibility-form-controls-crash.html is a consistent crash https://bugs.webkit.org/show_bug.cgi?id=272944 rdar://126722146 Unreviewed test gardening. Removing Test Expectation to unskip test that is fixed on iOS. * LayoutTests/platform/ios/TestExpectations: Canonical link: https://commits.webkit.org/277887@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 6bf69f: [Site Isolation] Drawing identifier sent during pa...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 6bf69ff83955cd9e0b9d7779b5d51d97a179ae04 https://github.com/WebKit/WebKit/commit/6bf69ff83955cd9e0b9d7779b5d51d97a179ae04 Author: Charlie Wolfe Date: 2024-04-23 (Tue, 23 Apr 2024) Changed paths: M Source/WebKit/UIProcess/ProvisionalPageProxy.cpp M Tools/TestWebKitAPI/Tests/WebKitCocoa/SiteIsolation.mm Log Message: --- [Site Isolation] Drawing identifier sent during page creation may be incorrect after a process swap https://bugs.webkit.org/show_bug.cgi?id=273128 rdar://126927331 Reviewed by Alex Christensen. In `WebPageProxy::continueNavigationInNewProcess()` the call to `ensureProcessForDomain()` will send the drawing area identifier to the new web process. The drawing area identifier may change again in `ProvisionalPageProxy`, but we may not send the CreateWebPage message to notify the web process it has changed. This message should always be sent. * Source/WebKit/UIProcess/ProvisionalPageProxy.cpp: (WebKit::ProvisionalPageProxy::initializeWebPage): * Tools/TestWebKitAPI/Tests/WebKitCocoa/SiteIsolation.mm: (TestWebKitAPI::TEST(SiteIsolation, PresentationUpdateAfterCrossSiteNavigation)): Canonical link: https://commits.webkit.org/277886@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 595d36: Fix build for macOS without NSTextPlaceholder rects.
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 595d364ecd7f7f223dc7a4ee70d288934f9f6a61 https://github.com/WebKit/WebKit/commit/595d364ecd7f7f223dc7a4ee70d288934f9f6a61 Author: Megan Gardner Date: 2024-04-23 (Tue, 23 Apr 2024) Changed paths: M Source/WebKit/UIProcess/Cocoa/WKTextPlaceholder.mm Log Message: --- Fix build for macOS without NSTextPlaceholder rects. https://bugs.webkit.org/show_bug.cgi?id=273135 rdar://126934848 Unreviewed Build Fix. Make sure that mac builds without NSTextPlaceholder rects aren't trying to build with them. * Source/WebKit/UIProcess/Cocoa/WKTextPlaceholder.mm: (-[WKTextPlaceholder rects]): Canonical link: https://commits.webkit.org/277885@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 7b0e37: [webkitpy] Wrong simulator sometimes chosen when a...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 7b0e37e37c6f855170b488cba2cbd456c6eb4623 https://github.com/WebKit/WebKit/commit/7b0e37e37c6f855170b488cba2cbd456c6eb4623 Author: Ben Schwartz Date: 2024-04-23 (Tue, 23 Apr 2024) Changed paths: M Tools/Scripts/webkitpy/xcode/simulated_device.py Log Message: --- [webkitpy] Wrong simulator sometimes chosen when a device is named "Managed 0" https://bugs.webkit.org/show_bug.cgi?id=273105 rdar://126884847 Reviewed by Jonathan Bedard. When running webkit tests in a simulator, webkitpy needs to either find or create a device that satisfies the request. For instance, if a user passes the `--ios-simulator` flag, webkitpy needs to either find a booted simulator that matches the request, or create and boot such a device. By default, devices are named "Managed X", where X is an integer that increments with each simulator that is booted. When webkitpy was created, iOS was the only simulator, so the only check to validate a simulator after creation is that the name matches the next available iteration of X. Now that there are more types of OS simulators, having, for instance, a visionOS simulator with the name "Managed 0" will override the --ios-simulator flag such that the existing visionOS simulator is booted instead of the newly created iOS simulator with the same name. This PR adds extra heuristics to check the device's type and OS build version before assuming it's a match. This locks the simulator device and OS to the requested version, ensuring the correct simulator is always booted. * Tools/Scripts/webkitpy/xcode/simulated_device.py: (SimulatedDeviceManager._create_or_find_device_for_request): Added check for device type and OS build version when finding a newly created simulated device. Canonical link: https://commits.webkit.org/277884@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 884c93: Make WTF::negate work correctly when negating non-...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 884c93a89477439436e11c1081dcc73312599cd7 https://github.com/WebKit/WebKit/commit/884c93a89477439436e11c1081dcc73312599cd7 Author: David Degazio Date: 2024-04-23 (Tue, 23 Apr 2024) Changed paths: M Source/WTF/wtf/MathExtras.h M Tools/TestWebKitAPI/Tests/WTF/MathExtras.cpp Log Message: --- Make WTF::negate work correctly when negating non-negative integers https://bugs.webkit.org/show_bug.cgi?id=273048 rdar://problem/126872453 Reviewed by Yusuke Suzuki and Keith Miller. WTF::negate statically accepts signed integers, but ASSERTs that its input is already negative so it can return a non-negative result. This is pretty surprising behavior, and since the operation of WTF::negate is a simple two's-complement negate, it should be fine to allow it to return negative results as well. * Source/WTF/wtf/MathExtras.h: (WTF::negate): Canonical link: https://commits.webkit.org/277883@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 02f644: [visionOS] Sometimes native inline controls appear...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 02f6442f3dc239e88c1c75520e4502875d7f9028 https://github.com/WebKit/WebKit/commit/02f6442f3dc239e88c1c75520e4502875d7f9028 Author: Jer Noble Date: 2024-04-23 (Tue, 23 Apr 2024) Changed paths: R LayoutTests/media/modern-media-controls/controls-visibility-support/controls-visibility-support-fullscreen-on-video-expected.txt R LayoutTests/media/modern-media-controls/controls-visibility-support/controls-visibility-support-fullscreen-on-video.html M LayoutTests/platform/glib/TestExpectations M LayoutTests/platform/ios/TestExpectations M Source/WebCore/Modules/modern-media-controls/controls/ios-layout-traits.js M Source/WebCore/Modules/modern-media-controls/controls/layout-traits.js M Source/WebCore/Modules/modern-media-controls/controls/macos-layout-traits.js M Source/WebCore/Modules/modern-media-controls/controls/vision-layout-traits.js M Source/WebCore/Modules/modern-media-controls/controls/watchos-layout-traits.js M Source/WebCore/Modules/modern-media-controls/media/media-controller.js M Source/WebCore/html/HTMLMediaElement.cpp M Source/WebCore/html/HTMLMediaElement.h Log Message: --- [visionOS] Sometimes native inline controls appear after exiting fullscreen, conflicting with page-implemented controls https://bugs.webkit.org/show_bug.cgi?id=273013 rdar://125878487 Reviewed by Andy Estes. Previously on visionOS, video fullscreen used element fullscreen as an implementation detail, and so VisionLayoutTraits.controlsAlwaysAvailable() would return true to force native controls to be visible in video fullscreen mode. However with the introduction of WKLinearMediaPlayer, this is no longer true; video fullscreen will use LinearMediaKit rather than element fullscreen. So the constant answer from LayoutTraits became incorrect. Rather than hard-code these values per-LayoutTraits subclass, just ask the HTMLMediaElement, which knows whether `videoFullscreenRequiresElementFullscreen()` has been set to true. Refactor things into a new private HTMLMediaElement function videoUsesElementFullscreen(), which can be used from many places inside HTMLMediaElement, including shouldForceControlsDisplay(). This ensures the controls will be visible when videoUsesElementFullscreen() is enabled, hidden when linearMediaPlayerEnabled() is enabled, and always on macOS. * Source/WebCore/Modules/modern-media-controls/controls/ios-layout-traits.js: (IOSLayoutTraits.prototype.controlsAlwaysAvailable): Deleted. * Source/WebCore/Modules/modern-media-controls/controls/layout-traits.js: (LayoutTraits.prototype.controlsAlwaysAvailable): Deleted. * Source/WebCore/Modules/modern-media-controls/controls/macos-layout-traits.js: (MacOSLayoutTraits.prototype.controlsAlwaysAvailable): Deleted. * Source/WebCore/Modules/modern-media-controls/controls/vision-layout-traits.js: (VisionLayoutTraits.prototype.controlsAlwaysAvailable): Deleted. * Source/WebCore/Modules/modern-media-controls/controls/watchos-layout-traits.js: (WatchOSLayoutTraits.prototype.controlsAlwaysAvailable): Deleted. * Source/WebCore/Modules/modern-media-controls/media/media-controller.js: (MediaController.prototype._shouldControlsBeAvailable): * Source/WebCore/html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::videoUsesElementFullscreen const): (WebCore::HTMLMediaElement::enterFullscreen): (WebCore::HTMLMediaElement::shouldForceControlsDisplay const): (WebCore::HTMLMediaElement::configureMediaControls): * Source/WebCore/html/HTMLMediaElement.h: Canonical link: https://commits.webkit.org/277882@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 51ce1f: Update gsnedders to reviewer
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 51ce1fab3ca0c7e738f3dcb8ad25863906ef3469 https://github.com/WebKit/WebKit/commit/51ce1fab3ca0c7e738f3dcb8ad25863906ef3469 Author: Sam Sneddon Date: 2024-04-23 (Tue, 23 Apr 2024) Changed paths: M metadata/contributors.json Log Message: --- Update gsnedders to reviewer https://bugs.webkit.org/show_bug.cgi?id=273129 Reviewed by Jonathan Bedard. * metadata/contributors.json: Canonical link: https://commits.webkit.org/277881@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 9fb659: Replace OpaqueJSString::characters8() / characters...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 9fb6599ff25c6305a75f2213d87c54a8d476c625 https://github.com/WebKit/WebKit/commit/9fb6599ff25c6305a75f2213d87c54a8d476c625 Author: Chris Dumez Date: 2024-04-23 (Tue, 23 Apr 2024) Changed paths: M Source/JavaScriptCore/API/JSStringRef.cpp M Source/JavaScriptCore/API/JSStringRefCF.cpp M Source/JavaScriptCore/API/OpaqueJSString.h M Source/WTF/wtf/text/StringImpl.cpp M Source/WTF/wtf/text/StringImpl.h M Source/WTF/wtf/unicode/UTF8Conversion.cpp M Source/WTF/wtf/unicode/UTF8Conversion.h M Source/WebCore/platform/SharedBuffer.cpp M Source/WebCore/xml/parser/XMLDocumentParserLibxml2.cpp M Source/WebKit/Shared/API/c/WKString.cpp Log Message: --- Replace OpaqueJSString::characters8() / characters16() with span equivalents https://bugs.webkit.org/show_bug.cgi?id=273096 Reviewed by Darin Adler. * Source/JavaScriptCore/API/JSStringRef.cpp: (JSStringGetUTF8CString): * Source/JavaScriptCore/API/JSStringRefCF.cpp: (JSStringCopyCFString): * Source/JavaScriptCore/API/OpaqueJSString.h: (OpaqueJSString::span8): (OpaqueJSString::span16): (OpaqueJSString::characters8): Deleted. (OpaqueJSString::characters16): Deleted. * Source/WTF/wtf/text/StringImpl.cpp: (WTF::StringImpl::utf8ForCharactersIntoBuffer): * Source/WTF/wtf/text/StringImpl.h: (WTF::StringImpl::tryGetUTF8ForCharacters): * Source/WTF/wtf/unicode/UTF8Conversion.cpp: (WTF::Unicode::convertLatin1ToUTF8): (WTF::Unicode::convertUTF16ToUTF8): * Source/WTF/wtf/unicode/UTF8Conversion.h: * Source/WebCore/platform/SharedBuffer.cpp: (WebCore::utf8Buffer): * Source/WebCore/xml/parser/XMLDocumentParserLibxml2.cpp: (WebCore::convertUTF16EntityToUTF8): * Source/WebKit/Shared/API/c/WKString.cpp: (WKStringGetUTF8CStringImpl): Canonical link: https://commits.webkit.org/277880@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] d94443: Adopt NSTextPlaceholders for Mac.
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: d94443d3d4bf19b813546e7089bb65f4a00b58c3 https://github.com/WebKit/WebKit/commit/d94443d3d4bf19b813546e7089bb65f4a00b58c3 Author: Megan Gardner Date: 2024-04-23 (Tue, 23 Apr 2024) Changed paths: M Source/WebCore/PAL/pal/spi/mac/NSTextInputContextSPI.h M Source/WebKit/SourcesCocoa.txt M Source/WebKit/UIProcess/API/mac/WKWebViewMac.mm A Source/WebKit/UIProcess/Cocoa/WKTextPlaceholder.h A Source/WebKit/UIProcess/Cocoa/WKTextPlaceholder.mm A Source/WebKit/UIProcess/Cocoa/WKTextSelectionRect.h A Source/WebKit/UIProcess/Cocoa/WKTextSelectionRect.mm M Source/WebKit/UIProcess/WebPageProxy.cpp M Source/WebKit/UIProcess/WebPageProxy.h M Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm R Source/WebKit/UIProcess/ios/WKTextPlaceholder.h R Source/WebKit/UIProcess/ios/WKTextPlaceholder.mm R Source/WebKit/UIProcess/ios/WKTextSelectionRect.h R Source/WebKit/UIProcess/ios/WKTextSelectionRect.mm M Source/WebKit/UIProcess/ios/WebPageProxyIOS.mm M Source/WebKit/UIProcess/mac/WebViewImpl.h M Source/WebKit/UIProcess/mac/WebViewImpl.mm M Source/WebKit/WebKit.xcodeproj/project.pbxproj M Source/WebKit/WebProcess/WebPage/WebPage.cpp M Source/WebKit/WebProcess/WebPage/WebPage.h M Source/WebKit/WebProcess/WebPage/WebPage.messages.in M Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm M Tools/TestWebKitAPI/SourcesCocoa.txt M Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj A Tools/TestWebKitAPI/Tests/WebKitCocoa/TextPlaceholderTests.mm Log Message: --- Adopt NSTextPlaceholders for Mac. https://bugs.webkit.org/show_bug.cgi?id=272961 rdar://126696059 Reviewed by Wenson Hsieh. Adopt NSTextPlaceholders which is a parallel of UITextPlaceholders. Move the now common code to Cocoa to allow for code sharing. * Source/WebCore/PAL/pal/spi/mac/NSTextInputContextSPI.h: * Source/WebKit/SourcesCocoa.txt: * Source/WebKit/UIProcess/API/mac/WKWebViewMac.mm: (-[WKWebView insertTextPlaceholderWithSize:completionHandler:]): (-[WKWebView removeTextPlaceholder:willInsertText:completionHandler:]): * Source/WebKit/UIProcess/Cocoa/WKTextPlaceholder.h: Renamed from Source/WebKit/UIProcess/ios/WKTextPlaceholder.h. * Source/WebKit/UIProcess/Cocoa/WKTextPlaceholder.mm: Renamed from Source/WebKit/UIProcess/ios/WKTextPlaceholder.mm. (-[WKTextPlaceholder initWithElementContext:]): (-[WKTextPlaceholder elementContext]): (-[WKTextPlaceholder rects]): * Source/WebKit/UIProcess/Cocoa/WKTextSelectionRect.h: Renamed from Source/WebKit/UIProcess/ios/WKTextSelectionRect.h. * Source/WebKit/UIProcess/Cocoa/WKTextSelectionRect.mm: Renamed from Source/WebKit/UIProcess/ios/WKTextSelectionRect.mm. (-[WKTextSelectionRectCustomHandleInfo initWithFloatQuad:isHorizontal:]): (-[WKTextSelectionRectCustomHandleInfo bottomLeft]): (-[WKTextSelectionRectCustomHandleInfo topLeft]): (-[WKTextSelectionRectCustomHandleInfo bottomRight]): (-[WKTextSelectionRectCustomHandleInfo topRight]): (-[WKTextSelectionRect initWithCGRect:]): (-[WKTextSelectionRect initWithSelectionGeometry:scaleFactor:]): (-[WKTextSelectionRect _path]): (-[WKTextSelectionRect writingDirection]): (-[WKTextSelectionRect range]): (-[WKTextSelectionRect _customHandleInfo]): (-[WKTextSelectionRect rect]): (-[WKTextSelectionRect containsStart]): (-[WKTextSelectionRect containsEnd]): (-[WKTextSelectionRect isVertical]): * Source/WebKit/UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::insertTextPlaceholder): (WebKit::WebPageProxy::removeTextPlaceholder): * Source/WebKit/UIProcess/WebPageProxy.h: * Source/WebKit/UIProcess/ios/AppKitSoftLink.h: * Source/WebKit/UIProcess/ios/AppKitSoftLink.mm: * Source/WebKit/UIProcess/ios/WebPageProxyIOS.mm: (WebKit::WebPageProxy::insertTextPlaceholder): Deleted. (WebKit::WebPageProxy::removeTextPlaceholder): Deleted. * Source/WebKit/UIProcess/mac/WebViewImpl.h: * Source/WebKit/UIProcess/mac/WebViewImpl.mm: (WebKit::WebViewImpl::insertTextPlaceholderWithSize): (WebKit::WebViewImpl::removeTextPlaceholder): * Source/WebKit/WebKit.xcodeproj/project.pbxproj: * Source/WebKit/WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::insertTextPlaceholder): (WebKit::WebPage::removeTextPlaceholder): * Source/WebKit/WebProcess/WebPage/WebPage.h: * Source/WebKit/WebProcess/WebPage/WebPage.messages.in: * Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm: (WebKit::WebPage::insertTextPlaceholder): Deleted. (WebKit::WebPage::removeTextPlaceholder): Deleted. * Tools/TestWebKitAPI/SourcesCocoa.txt: * Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: * Tools/TestWebKitAPI/Tests/WebKitCocoa/TextPlaceholderTests.mm: Added. Canonical link: https://commits.webkit.org/277879@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list
[webkit-changes] [WebKit/WebKit] 772672: [JSC] Rewrite Array#sort
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 7726722f8ddd89a6c25ab071961cb059eab63d14 https://github.com/WebKit/WebKit/commit/7726722f8ddd89a6c25ab071961cb059eab63d14 Author: Yusuke Suzuki Date: 2024-04-23 (Tue, 23 Apr 2024) Changed paths: A JSTests/microbenchmarks/array-prototype-sort-large-array-comparator-double.js M LayoutTests/js/dom/array-prototype-properties-expected.txt M Source/JavaScriptCore/CMakeLists.txt M Source/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj M Source/JavaScriptCore/builtins/ArrayPrototype.js M Source/JavaScriptCore/heap/GCMemoryOperations.h M Source/JavaScriptCore/interpreter/CachedCall.h M Source/JavaScriptCore/runtime/ArgList.cpp M Source/JavaScriptCore/runtime/ArgList.h M Source/JavaScriptCore/runtime/ArrayPrototype.cpp M Source/JavaScriptCore/runtime/CommonIdentifiers.h M Source/JavaScriptCore/runtime/JSArray.cpp M Source/JavaScriptCore/runtime/JSArray.h M Source/JavaScriptCore/runtime/JSGenericTypedArrayViewPrototypeFunctions.h M Source/JavaScriptCore/runtime/JSGlobalObject.cpp M Source/JavaScriptCore/runtime/JSTypedArrayViewPrototype.cpp A Source/JavaScriptCore/runtime/StableSort.h M Source/JavaScriptCore/runtime/VM.h Log Message: --- [JSC] Rewrite Array#sort https://bugs.webkit.org/show_bug.cgi?id=273051 rdar://126833827 Reviewed by Keith Miller. The world found that JS-implemented Array#sort is too slow, in particular in Baseline JIT. As a result, all other engines rewrote Array#sort in C++ (V8 and SpiderMonkey). We also found that our Array#sort is too slow in Speedometer 3.0, so we need to rewrite to follow to the other engines. But now, the implementation is significantly simpler than before since Array#sort is now well defined in the spec and we first copy content to non user-observable array for sorting. This avoids any changes to this array via function calls, so we can make sorting much simpler and safer (even than JS implemented one). 1. VMTraps is moved to make access close to the other fields in VM. 2. Unify TypedArray / Array sort. 3. Add insertion sort path for smaller arrays. 4. Add a fast path skipping many comparisons by checking whether two subarrays are already sorted. This is aligned to V8 and SpiderMonkey behavior. ToT Patched uint32array-sort-custom73.4050+-0.6354 ^ 48.5713+-0.3494^ definitely 1.5113x faster array-prototype-sort-large-array 25.9099+-0.0528 ^ 22.4718+-0.1368^ definitely 1.1530x faster array-prototype-sort-small-array-comparator 12.6596+-0.2183 ^ 9.7617+-0.2233^ definitely 1.2969x faster array-prototype-sort-large-array-comparator 13.8265+-0.1290 ^ 6.7050+-0.2796^ definitely 2.0621x faster sorting-benchmark 10.0377+-0.1360 ^ 8.3962+-0.2557^ definitely 1.1955x faster array-prototype-sort-medium-array-comparator 42.4683+-0.4189 ^ 28.7110+-0.2369^ definitely 1.4792x faster array-prototype-sort-medium-array 70.2655+-0.6955 ^ 29.8648+-0.3713^ definitely 2.3528x faster array-prototype-sort-small-array 20.3562+-0.1621 ^ 9.7814+-0.0692^ definitely 2.0811x faster * Source/JavaScriptCore/CMakeLists.txt: * Source/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj: * Source/JavaScriptCore/builtins/ArrayPrototype.js: (linkTimeConstant.sortStringComparator): Deleted. (linkTimeConstant.sortCompact): Deleted. (linkTimeConstant.sortCommit): Deleted. (linkTimeConstant.sortMerge): Deleted. (linkTimeConstant.sortMergeSort): Deleted. (linkTimeConstant.sortBucketSort): Deleted. (sort): Deleted. * Source/JavaScriptCore/heap/GCMemoryOperations.h: (JSC::gcSafeMemcpy): (JSC::gcSafeMemmove): * Source/JavaScriptCore/interpreter/CachedCall.h: (JSC::CachedCall::callWithArguments): * Source/JavaScriptCore/runtime/ArgList.cpp: (JSC::ArgList::getSlice const): (JSC::MarkedVectorBase::markLists): (JSC::MarkedVectorBase::expandCapacity): * Source/JavaScriptCore/runtime/ArgList.h: (JSC::MarkedVector::at const): (JSC::MarkedVector::set): (JSC::ArgList::ArgList): (JSC::ArgList::at const): * Source/JavaScriptCore/runtime/ArrayPrototype.cpp: (JSC::ArrayPrototype::finishCreation): (JSC::sortCompact): (JSC::sortBucketSort): (JSC::sortStableSort): (JSC::sortCommit): (JSC::JSC_DEFINE_HOST_FUNCTION): * Source/JavaScriptCore/runtime/CommonIdentifiers.h: * Source/JavaScriptCore/runtime/JSArray.cpp: (JSC::JSArray::appendMemcpy): * Source/JavaScriptCore/runtime/JSArray.h: * Source/JavaScriptCore/runtime/JSGenericTypedArrayViewPrototyp
[webkit-changes] [WebKit/WebKit] 4fb782: [visionOS] When transitioning from video fullscree...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 4fb78297f66382824d32daea416bcdccc940a801 https://github.com/WebKit/WebKit/commit/4fb78297f66382824d32daea416bcdccc940a801 Author: Andy Estes Date: 2024-04-23 (Tue, 23 Apr 2024) Changed paths: M Source/WebKit/UIProcess/Cocoa/PlaybackSessionManagerProxy.mm M Source/WebKit/UIProcess/WebPageProxy.cpp M Source/WebKit/UIProcess/ios/PageClientImplIOS.h M Source/WebKit/UIProcess/ios/PageClientImplIOS.mm M Source/WebKit/UIProcess/ios/WKContentViewInteraction.h M Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm M Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenWindowControllerIOS.h M Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenWindowControllerIOS.mm Log Message: --- [visionOS] When transitioning from video fullscreen to element fullscreen, the element fullscreen window is not frontmost https://bugs.webkit.org/show_bug.cgi?id=273100 rdar://126642251 Reviewed by Wenson Hsieh and Aditya Keerthi. When entering video fullscreen LinearMediaKit changes the client scene's windows' transform3D, then fails to restore them to their original values when exiting fullscreen. As a result, the element fullscreen window may no longer be frontmost when exiting back to element fullscreen. This issue was originally worked around in 277031@main by exiting element fullscreen when entering video fullscreen, but this was suboptimal since users expect to return to element fullscreen if that's the state they were in when entering video fullscreen. This change improves the workaround by instead restoring the expected transform3Ds on both the element fullscreen window and WKWebView's window when exiting video fullscreen. Note that this change also removes dead code in -[WKContentViewInteraction _did(Enter|Exit)Fullscreen] so that hooking up PageClientImpl::did(Enter|Exit)Fullscreen does not cause an unintended behavior change. * Source/WebKit/UIProcess/Cocoa/PlaybackSessionManagerProxy.mm: (WebKit::PlaybackSessionManagerProxy::setVideoReceiverEndpoint): * Source/WebKit/UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::didEnterFullscreen): (WebKit::WebPageProxy::didExitFullscreen): * Source/WebKit/UIProcess/ios/PageClientImplIOS.h: * Source/WebKit/UIProcess/ios/PageClientImplIOS.mm: (WebKit::PageClientImpl::didExitFullscreen): (WebKit::PageClientImpl::didEnterFullscreen): Deleted. * Source/WebKit/UIProcess/ios/WKContentViewInteraction.h: * Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm: (-[WKContentView _didEnterFullscreen]): Deleted. (-[WKContentView _didExitFullscreen]): Deleted. * Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenWindowControllerIOS.h: * Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenWindowControllerIOS.mm: (-[WKFullScreenWindowController didExitFullscreen]): Canonical link: https://commits.webkit.org/277877@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 8824ae: [Remote Inspection] Adjust targeting to skip non-i...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 8824aec206772ee607381b372c9da62892f501e4 https://github.com/WebKit/WebKit/commit/8824aec206772ee607381b372c9da62892f501e4 Author: Wenson Hsieh Date: 2024-04-23 (Tue, 23 Apr 2024) Changed paths: A LayoutTests/fast/element-targeting/targeted-element-ignores-pointer-events-none-overlay-expected.txt A LayoutTests/fast/element-targeting/targeted-element-ignores-pointer-events-none-overlay.html M Source/WebCore/page/ElementTargetingController.cpp Log Message: --- [Remote Inspection] Adjust targeting to skip non-interactable containers that cover the viewport https://bugs.webkit.org/show_bug.cgi?id=273124 rdar://126818923 Reviewed by Megan Gardner. Fine-tune the targeting heuristic further, by adding logic to skip over full-viewport-sized elements that are either z-ordered below the rest of the content, or out-of-flow and non-interactable (i.e. `pointer-events: none;`) with no visible background either. * LayoutTests/fast/element-targeting/targeted-element-ignores-pointer-events-none-overlay-expected.txt: Added. * LayoutTests/fast/element-targeting/targeted-element-ignores-pointer-events-none-overlay.html: Added. * Source/WebCore/page/ElementTargetingController.cpp: (WebCore::ElementTargetingController::findTargets): Canonical link: https://commits.webkit.org/277876@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 3dcddc: Clearing BitmapImage decoded frames should should ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 3dcddc14fce35b4e931b22ebf69470ceb0d09dcb https://github.com/WebKit/WebKit/commit/3dcddc14fce35b4e931b22ebf69470ceb0d09dcb Author: Said Abou-Hallawa Date: 2024-04-23 (Tue, 23 Apr 2024) Changed paths: M Source/WebCore/platform/graphics/BitmapImageSource.cpp Log Message: --- Clearing BitmapImage decoded frames should should not overflow https://bugs.webkit.org/show_bug.cgi?id=273098 rdar://126591872 Reviewed by Simon Fraser. When destroying the decoded frames, BitmapImageSource::destroyDecodedData() should loop through the frames Vector only and do not assume its size is be the same as frameCount. * Source/WebCore/platform/graphics/BitmapImageSource.cpp: (WebCore::BitmapImageSource::destroyDecodedData): Canonical link: https://commits.webkit.org/277875@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] a63d41: [ Ventura WK1 ] 2x imported/w3c/web-platform-tests...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: a63d417c95a806d76ce4769d12bffa3ced0c2165 https://github.com/WebKit/WebKit/commit/a63d417c95a806d76ce4769d12bffa3ced0c2165 Author: Jay Stfleur Date: 2024-04-23 (Tue, 23 Apr 2024) Changed paths: M LayoutTests/platform/mac-ventura-wk1/TestExpectations Log Message: --- [ Ventura WK1 ] 2x imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/track/track-element/track-mode are constant crashes https://bugs.webkit.org/show_bug.cgi?id=270915 rdar://124540415 Unreviewed test gardening. Removing test expectation for test that are passing. * LayoutTests/platform/mac-ventura-wk1/TestExpectations: Canonical link: https://commits.webkit.org/277874@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] ffdff3: [WebGPU] CommandEncoder::copyTexturToTexture fails...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: ffdff3e6b9708b6d84619778093f27d7b50b631e https://github.com/WebKit/WebKit/commit/ffdff3e6b9708b6d84619778093f27d7b50b631e Author: Mike Wyrzykowski Date: 2024-04-23 (Tue, 23 Apr 2024) Changed paths: M LayoutTests/TestExpectations A LayoutTests/fast/webgpu/fuzz-273023-expected.txt A LayoutTests/fast/webgpu/fuzz-273023.html M Source/WebGPU/WebGPU/CommandEncoder.mm Log Message: --- [WebGPU] CommandEncoder::copyTexturToTexture fails metal validation in some cases https://bugs.webkit.org/show_bug.cgi?id=273023 Reviewed by Tadeu Zagallo. Don't allow source slice to be outside the texture range but until its determined this should be a validation error according to the specification, treat as a no-op. * LayoutTests/TestExpectations: * LayoutTests/fast/webgpu/fuzz-273023-expected.txt: Added. * LayoutTests/fast/webgpu/fuzz-273023.html: Added. Add regression test. * Source/WebGPU/WebGPU/CommandEncoder.mm: (WebGPU::CommandEncoder::copyTextureToTexture): Canonical link: https://commits.webkit.org/277873@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 1a65f5: Increase platform coverage of check-for-duplicated...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 1a65f54c1c2c520f11d4c2a84654c993fc11256a https://github.com/WebKit/WebKit/commit/1a65f54c1c2c520f11d4c2a84654c993fc11256a Author: Jonathan Bedard Date: 2024-04-23 (Tue, 23 Apr 2024) Changed paths: M Tools/Scripts/webkitpy/port/win_unittest.py Log Message: --- Increase platform coverage of check-for-duplicated-platform-test-results (Follow-up) https://bugs.webkit.org/show_bug.cgi?id=271276 rdar://126887595> Unreviewed rebaseline. Rebaseline test after 277843@main (b8532bcbdb39). * Tools/Scripts/webkitpy/port/win_unittest.py: (WinPortTest.test_baseline_search_path): Canonical link: https://commits.webkit.org/277872@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 2d6113: [ews-build.webkit.org] RevertPullRequestChanges do...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 2d6113b208452d6226a422ca800535ebfc6cd2df https://github.com/WebKit/WebKit/commit/2d6113b208452d6226a422ca800535ebfc6cd2df Author: Jonathan Bedard Date: 2024-04-23 (Tue, 23 Apr 2024) Changed paths: M Tools/CISupport/ews-build/steps.py M Tools/CISupport/ews-build/steps_unittest.py Log Message: --- [ews-build.webkit.org] RevertPullRequestChanges doesn't apply to patches https://bugs.webkit.org/show_bug.cgi?id=272933 rdar://126774529 Reviewed by Ryan Haddad. Since patches are applied as commits, we should rename RevertPullRequestChanges to RevertAppliedChanges and remove UnApplyPatch. * Tools/CISupport/ews-build/steps.py: (RevertAppliedChanges): Renamed from RevertPullRequestChanges (CompileWebKit.evaluateCommand): (RunJavaScriptCoreTests.evaluateCommand): (RunWebKitTests.evaluateCommand): (ReRunWebKitTests.evaluateCommand): (RunWebKitTestsRedTree.evaluateCommand): (RunWebKitTestsRepeatFailuresRedTree.evaluateCommand): (ReRunAPITests.doOnFailure): (UnApplyPatch): Deleted. (RevertPullRequestChanges): Renamed to RevertAppliedChanges. * Tools/CISupport/ews-build/steps_unittest.py: (TestRunWebKitTestsRedTree.test_last_try_unexpected_failure_without_list_of_failing_tests_then_schedule_update_libs_and_test_without_patch): (TestRunWebKitTestsRedTree.test_flakies_but_no_failures_then_go_to_analyze_results): (TestRunWebKitTestsRepeatFailuresRedTree.test_last_run_with_patch_ends_with_list_of_failing_tests_then_schedule_update_libs_and_test_without_patch): (TestRunWebKitTestsRepeatFailuresRedTree.test_last_run_with_patch_ends_with_no_failing_tests_then_go_to_analyze): (TestRevertAppliedChanges): Renamed from TestRevertPullRequestChanges. (TestRevertAppliedChanges.test_patch): (TestUnApplyPatch): Deleted. (TestRevertPullRequestChanges): Renamed to TestRevertAppliedChanges. (TestRevertPullRequestChanges.test_skip): Deleted. Canonical link: https://commits.webkit.org/277871@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] e75958: REGRESSION (277781@main): [ iOS ] accessibility/io...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: e75958e43a538e8bb98325c8f76b5d22b9d66557 https://github.com/WebKit/WebKit/commit/e75958e43a538e8bb98325c8f76b5d22b9d66557 Author: Tyler Wilcock Date: 2024-04-23 (Tue, 23 Apr 2024) Changed paths: M LayoutTests/accessibility/ios-simulator/math-expected.txt M LayoutTests/accessibility/ios-simulator/math.html M LayoutTests/platform/ios/TestExpectations Log Message: --- REGRESSION (277781@main): [ iOS ] accessibility/ios-simulator/math.html is a consistent failure https://bugs.webkit.org/show_bug.cgi?id=273095 rdar://problem/126887745 Reviewed by Chris Fleizach. This test needs a rebase after https://commits.webkit.org/277781@main. * LayoutTests/accessibility/ios-simulator/math-expected.txt: * LayoutTests/accessibility/ios-simulator/math.html: * LayoutTests/platform/ios/TestExpectations: Canonical link: https://commits.webkit.org/277870@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 2431b5: Cherry-pick 277248@main (2e1188405ef9). https://bu...
Branch: refs/heads/webkitglib/2.44 Home: https://github.com/WebKit/WebKit Commit: 2431b537193e0ae1516ab3fc83db89286e4c2bfe https://github.com/WebKit/WebKit/commit/2431b537193e0ae1516ab3fc83db89286e4c2bfe Author: Michael Catanzaro Date: 2024-04-23 (Tue, 23 Apr 2024) Changed paths: M Source/WTF/wtf/ThreadSafeRefCounted.h Log Message: --- Cherry-pick 277248@main (2e1188405ef9). https://bugs.webkit.org/show_bug.cgi?id=271997 Build failures in GeneratedSerializers.cpp in release builds with assertions enabled https://bugs.webkit.org/show_bug.cgi?id=271997 Reviewed by Chris Dumez. This matches the condition to determine whether assertions are enabled with RefCounted.h. It's a better condition anyway. * Source/WTF/wtf/ThreadSafeRefCounted.h: Canonical link: https://commits.webkit.org/277248@main Canonical link: https://commits.webkit.org/274313.157@webkitglib/2.44 To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 6c86b5: [iOS] CRASH: exception thrown from AVVideoCaptureS...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 6c86b501dc6d75696d6d30eb0170a174f0f9bda9 https://github.com/WebKit/WebKit/commit/6c86b501dc6d75696d6d30eb0170a174f0f9bda9 Author: Jer Noble Date: 2024-04-23 (Tue, 23 Apr 2024) Changed paths: M Source/WebCore/platform/mediastream/mac/AVVideoCaptureSource.mm Log Message: --- [iOS] CRASH: exception thrown from AVVideoCaptureSource::stopSession() https://bugs.webkit.org/show_bug.cgi?id=273088 rdar://126717672 Reviewed by Eric Carlson. Crashtracer data shows that an exception is thrown from -[AVCaptureSession stopRunning] because that method is called after -beginConfiguration, but before -commitConfiguration. Make this method robust to that exception, and add our own ASSERT that we are not in the middle of configuration in order to catch this case before it gets to AVCapture. * Source/WebCore/platform/mediastream/mac/AVVideoCaptureSource.mm: (WebCore::AVVideoCaptureSource::stopSession): Canonical link: https://commits.webkit.org/277869@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 372330: Cherry-pick 277261@main (5c6736f3f9ad). https://bu...
Branch: refs/heads/webkitglib/2.44 Home: https://github.com/WebKit/WebKit Commit: 3723301b852126140c3d1b615714bc23bb434e4a https://github.com/WebKit/WebKit/commit/3723301b852126140c3d1b615714bc23bb434e4a Author: Qianlang Chen Date: 2024-04-23 (Tue, 23 Apr 2024) Changed paths: A LayoutTests/inspector/console/js-completions-expected.txt A LayoutTests/inspector/console/js-completions.html M Source/WebInspectorUI/UserInterface/Controllers/ConsoleManager.js M Source/WebInspectorUI/UserInterface/Controllers/JavaScriptLogViewController.js M Source/WebInspectorUI/UserInterface/Controllers/JavaScriptRuntimeCompletionProvider.js M Source/WebInspectorUI/UserInterface/Test.html Log Message: --- Cherry-pick 277261@main (5c6736f3f9ad). https://bugs.webkit.org/show_bug.cgi?id=271265 Web Inspector: Console code completion doesn't suggest variables unless inspector is re-opened rdar://125035133 https://bugs.webkit.org/show_bug.cgi?id=271265 Reviewed by Devin Rousso. In the current JavaScriptRuntimeCompletionProvider, there's work done to cache the list of property names present in the runtime. This property name cache is cleared / forced to be re-fetched either when 30 seconds have passed or when the code typed starts accessing a different object's properties (the object to the left of a dot operator). However, when variables are created by executing a command, the cache is not updated, resulting in those new variables missing from the suggestions. This commit simply makes it so that executing a command from the console also forces clearing the cache, so that new variables, in case created, are immediately collected as suggestions when typing a new command. The cache is also cleared when the console clears, so when the page is reloaded with the console opened, the variable completion still gets properly reset. * Source/WebInspectorUI/UserInterface/Controllers/JavaScriptRuntimeCompletionProvider.js: (WI.JavaScriptRuntimeCompletionProvider): (WI.JavaScriptRuntimeCompletionProvider.prototype.completionControllerCompletionsNeeded): - Update the comment on the need of loading the list of property names from cache to reflect now there can be additional opportunities that the cache should be cleared. - Remove the `// Protected` section comment as this function is accessed by others. (WI.JavaScriptRuntimeCompletionProvider): (WI.JavaScriptRuntimeCompletionProvider.prototype.clearCachedPropertyNames): (WI.JavaScriptRuntimeCompletionProvider.prototype._clearLastProperties): Deleted - Expose the logic of clearing the property name cache so that the completion provider's users can also force a reload of property names. (WI.JavaScriptRuntimeCompletionProvider.prototype.completionControllerCompletionsNeeded.updateLastPropertyNames): - Adapt to the cache-clearing logic being exposed to public. * Source/WebInspectorUI/UserInterface/Controllers/JavaScriptLogViewController.js: (WI.JavaScriptLogViewController.prototype.consolePromptTextCommitted): - Clear cached property names whenever a new command is executed in the console, since new commands are what can possibly introduce changes to existing variables (additions from `x = ...` or `let x`, and deletions from `delete x`). * Source/WebInspectorUI/UserInterface/Controllers/ConsoleManager.js: (WI.ConsoleManager.prototype.messagesCleared): - Clear cached property names when the console is cleared because the page might've been reloaded and therefore variables were reset as a result. * Source/WebInspectorUI/UserInterface/Test.html: * LayoutTests/inspector/console/js-completions.html: Added. * LayoutTests/inspector/console/js-completions-expected.txt: Added. - Add a simple test to demonstrate how `clearCachedPropertyNames` is used. Canonical link: https://commits.webkit.org/277261@main Canonical link: https://commits.webkit.org/274313.156@webkitglib/2.44 To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 9f717e: [UnifiedPDF] Resizing a slow-rendering PDF, wedges...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 9f717e3bb0d15503330aad55b66c9d609594b1b9 https://github.com/WebKit/WebKit/commit/9f717e3bb0d15503330aad55b66c9d609594b1b9 Author: Simon Fraser Date: 2024-04-23 (Tue, 23 Apr 2024) Changed paths: M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/AsyncPDFRenderer.h M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/AsyncPDFRenderer.mm Log Message: --- [UnifiedPDF] Resizing a slow-rendering PDF, wedges all cores for tens of minutes https://bugs.webkit.org/show_bug.cgi?id=272880 rdar://126213078 Reviewed by Tim Horton. Currently we dispatch PDF tile renders as soon as we get notified that a tile needs new content. That causes all the requests to pile up in libdispatch, and once they are dispatched we have no way to cancel those that are stale. Fix by using a work queue for tile render requests; while requests are still in the queue, they can be removed. We track how many renders are in flight, and only dispatch new ones when requests complete. The number of concurrent renders is computed based on the number of cores, with some sensible limits. We don't just match the number of cores because that brings back the original problem of farming out lots of uncancellable renders. * Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/AsyncPDFRenderer.h: * Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/AsyncPDFRenderer.mm: (WebKit::maxConcurrentTileRenders): (WebKit::AsyncPDFRenderer::AsyncPDFRenderer): (WebKit::AsyncPDFRenderer::willRemoveTile): (WebKit::AsyncPDFRenderer::clearRequestsAndCachedTiles): (WebKit::AsyncPDFRenderer::enqueuePaintWithClip): (WebKit::AsyncPDFRenderer::serviceRequestQueue): (WebKit::AsyncPDFRenderer::didCompleteTileRender): Canonical link: https://commits.webkit.org/277868@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] fa0ace: [WGSL] shader, execution, expression, call, user, ptr_p...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: fa0acee7fc7f2c005d578f926b125508f24f5caa https://github.com/WebKit/WebKit/commit/fa0acee7fc7f2c005d578f926b125508f24f5caa Author: Tadeu Zagallo Date: 2024-04-23 (Tue, 23 Apr 2024) Changed paths: A LayoutTests/http/tests/webgpu/webgpu/shader/execution/expression/call/user/ptr_params-expected.txt M Source/WebGPU/WGSL/CallGraph.cpp M Source/WebGPU/WGSL/CallGraph.h M Source/WebGPU/WGSL/GlobalVariableRewriter.cpp Log Message: --- [WGSL] shader,execution,expression,call,user,ptr_params:* is failing https://bugs.webkit.org/show_bug.cgi?id=273071 rdar://126865271 Reviewed by Mike Wyrzykowski. The WGSL compiler rewrites calls to `arrayLength(ptr)` to use the length injected via the API, which is basically done by replacing it `ptr_length`. This simple approach worked originally since pointers to runtime-sized arrays couldn't be passed to other functions, so we always knew syntactically which array we were requesting the length for. However, the spec was updated to support pointers to variables in the storage space in function parameters, which means that it's now possible to read the array length of a function argument. This requires passing the the length alongside the array through the call sites anywhere the array length is read. * LayoutTests/http/tests/webgpu/webgpu/shader/execution/expression/call/user/ptr_params-expected.txt: Added. * Source/WebGPU/WGSL/CallGraph.cpp: (WGSL::CallGraphBuilder::visit): * Source/WebGPU/WGSL/CallGraph.h: * Source/WebGPU/WGSL/GlobalVariableRewriter.cpp: (WGSL::RewriteGlobalVariables::visitCallee): (WGSL::RewriteGlobalVariables::visit): (WGSL::RewriteGlobalVariables::getPacking): (WGSL::RewriteGlobalVariables::getBase): Canonical link: https://commits.webkit.org/277867@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 073f85: [JSC] Extend call_ignore_result coverage
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 073f85a35f31b911c5ad533a7f1b77a5475baecb https://github.com/WebKit/WebKit/commit/073f85a35f31b911c5ad533a7f1b77a5475baecb Author: Yusuke Suzuki Date: 2024-04-23 (Tue, 23 Apr 2024) Changed paths: M Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp M Source/JavaScriptCore/bytecompiler/BytecodeGenerator.h M Source/JavaScriptCore/bytecompiler/NodesCodegen.cpp Log Message: --- [JSC] Extend call_ignore_result coverage https://bugs.webkit.org/show_bug.cgi?id=273112 rdar://126903588 Reviewed by Justin Michaud. This patch extends coverage of call_ignore_result. We replace emitNode + ignoredResult with emitNodeInIgnoreResultPosition. In particular, CommaNode's change is important since it allows us to eliminate many unnecessary results in minified JS code. * Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp: (JSC::BytecodeGenerator::BytecodeGenerator): * Source/JavaScriptCore/bytecompiler/BytecodeGenerator.h: (JSC::BytecodeGenerator::emitNodeInIgnoreResultPosition): * Source/JavaScriptCore/bytecompiler/NodesCodegen.cpp: (JSC::DeleteValueNode::emitBytecode): (JSC::VoidNode::emitBytecode): (JSC::TypeOfValueNode::emitBytecode): (JSC::CommaNode::emitBytecode): (JSC::ForNode::emitBytecode): (JSC::ForInNode::emitBytecode): Canonical link: https://commits.webkit.org/277866@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 77fd27: [WPE] Missing UNUSED_PARAM for screendisplayID in ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 77fd27c0419a637bbe8dbc13e70427aa78df5dbb https://github.com/WebKit/WebKit/commit/77fd27c0419a637bbe8dbc13e70427aa78df5dbb Author: Przemyslaw Gorszkowski Date: 2024-04-23 (Tue, 23 Apr 2024) Changed paths: M Source/WebCore/platform/wpe/PlatformScreenWPE.cpp Log Message: --- [WPE] Missing UNUSED_PARAM for screendisplayID in PlatformScreenWPE https://bugs.webkit.org/show_bug.cgi?id=273116 Reviewed by Miguel Gomez. Without this change and disabled ENABLE_WPE_PLATFORM there is a compiler error about "unused parameter". * Source/WebCore/platform/wpe/PlatformScreenWPE.cpp: (WebCore::screenDPI): Canonical link: https://commits.webkit.org/277865@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] c2439d: [GTK][WPE] Use a fence to wait for composited surf...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: c2439d1c405bc25d8bb4e56dda631480fd313916 https://github.com/WebKit/WebKit/commit/c2439d1c405bc25d8bb4e56dda631480fd313916 Author: Carlos Garcia Campos Date: 2024-04-23 (Tue, 23 Apr 2024) Changed paths: M Source/WebKit/WebProcess/WebPage/dmabuf/AcceleratedSurfaceDMABuf.cpp Log Message: --- [GTK][WPE] Use a fence to wait for composited surface to be rendered before sending the Frame message https://bugs.webkit.org/show_bug.cgi?id=273118 Reviewed by Miguel Gomez. * Source/WebKit/WebProcess/WebPage/dmabuf/AcceleratedSurfaceDMABuf.cpp: (WebKit::AcceleratedSurfaceDMABuf::didRenderFrame): Canonical link: https://commits.webkit.org/277864@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] a80c09: [Skia] Fix canvas source-in globalCompositeOperation
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: a80c097d123d3a51b8e73bb6325b6e5828c911cc https://github.com/WebKit/WebKit/commit/a80c097d123d3a51b8e73bb6325b6e5828c911cc Author: Pawel Lampe Date: 2024-04-23 (Tue, 23 Apr 2024) Changed paths: M Source/WebCore/html/canvas/CanvasRenderingContext2DBase.cpp Log Message: --- [Skia] Fix canvas source-in globalCompositeOperation https://bugs.webkit.org/show_bug.cgi?id=272976 Reviewed by Carlos Garcia Campos. * Source/WebCore/html/canvas/CanvasRenderingContext2DBase.cpp: (WebCore::CanvasRenderingContext2DBase::beginCompositeLayer): (WebCore::CanvasRenderingContext2DBase::endCompositeLayer): Canonical link: https://commits.webkit.org/277863@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] f80260: Cherry-pick 277435@main (5b488a0a1b57). https://bu...
Branch: refs/heads/webkitglib/2.44 Home: https://github.com/WebKit/WebKit Commit: f802609d3c91004b81a36718b050770b062adeb3 https://github.com/WebKit/WebKit/commit/f802609d3c91004b81a36718b050770b062adeb3 Author: Ryosuke Niwa Date: 2024-04-23 (Tue, 23 Apr 2024) Changed paths: A LayoutTests/fast/dom/dispatch-event-without-event-listener-expected.txt A LayoutTests/fast/dom/dispatch-event-without-event-listener.html M Source/WebCore/dom/EventDispatcher.cpp Log Message: --- Cherry-pick 277435@main (5b488a0a1b57). https://bugs.webkit.org/show_bug.cgi?id=272552 REGRESSION(272801@main): CustomEvent.target is not set when dispatching event https://bugs.webkit.org/show_bug.cgi?id=272552 Reviewed by Yusuke Suzuki. Set Event's target even when there is no relevant event listener since this is observable by scripts. * LayoutTests/fast/dom/dispatch-event-without-event-listener-expected.txt: Added. * LayoutTests/fast/dom/dispatch-event-without-event-listener.html: Added. * Source/WebCore/dom/EventDispatcher.cpp: (WebCore::EventDispatcher::dispatchEvent): Canonical link: https://commits.webkit.org/277435@main Canonical link: https://commits.webkit.org/274313.155@webkitglib/2.44 To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 6ca4b0: Cherry-pick 277500@main (040cadd0e752). https://bu...
Branch: refs/heads/webkitglib/2.44 Home: https://github.com/WebKit/WebKit Commit: 6ca4b079318ede197d62866dd6ae38e9dff7f818 https://github.com/WebKit/WebKit/commit/6ca4b079318ede197d62866dd6ae38e9dff7f818 Author: Antti Koivisto Date: 2024-04-23 (Tue, 23 Apr 2024) Changed paths: M LayoutTests/imported/w3c/web-platform-tests/css/css-masking/parsing/clip-path-computed-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/css-masking/parsing/clip-path-computed.html M Source/WebCore/css/BasicShapeFunctions.cpp M Source/WebCore/platform/Length.cpp M Source/WebCore/platform/Length.h Log Message: --- Cherry-pick 277500@main (040cadd0e752). https://bugs.webkit.org/show_bug.cgi?id=270296 REGRESSION(272180@main): Crash in CSSCalcOperationNode::simplifyRecursive with xywh() and rect() clip-paths https://bugs.webkit.org/show_bug.cgi?id=270296 rdar://123508905 Reviewed by Darin Adler. Clip path serialization produces inset() values which requires constructing calc expressions if the original values are not insets. The code for this didn't work correctly if the values were calc expressions thenselves. * LayoutTests/imported/w3c/web-platform-tests/css/css-masking/parsing/clip-path-computed-expected.txt: The results are correct though FAILs because they are not maximally simplified. * LayoutTests/imported/w3c/web-platform-tests/css/css-masking/parsing/clip-path-computed.html: Update from the WPT repo. * Source/WebCore/css/BasicShapeFunctions.cpp: Use the existing convertTo100PercentMinusLength instead of trying to do this manually. (WebCore::valueForBasicShape): * Source/WebCore/platform/Length.cpp: (WebCore::convertTo100PercentMinusLengthSum): Add a separate dual-argument version. This is needed so we can do some manual simplification (see the comment). * Source/WebCore/platform/Length.h: Canonical link: https://commits.webkit.org/277500@main Canonical link: https://commits.webkit.org/274313.154@webkitglib/2.44 To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 83c5e9: [Skia] Create the fence after flush and submit
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 83c5e98d79948e06e2644c4ac2d0f81efdda5c63 https://github.com/WebKit/WebKit/commit/83c5e98d79948e06e2644c4ac2d0f81efdda5c63 Author: Carlos Garcia Campos Date: 2024-04-23 (Tue, 23 Apr 2024) Changed paths: M Source/WebCore/platform/graphics/egl/GLFence.cpp M Source/WebCore/platform/graphics/egl/GLFence.h M Source/WebCore/platform/graphics/nicosia/NicosiaBuffer.cpp Log Message: --- [Skia] Create the fence after flush and submit https://bugs.webkit.org/show_bug.cgi?id=273115 Reviewed by Miguel Gomez. There might still be glitches because we create the GLFence before the submit. Expose isGLFenceSyncSupported as static function GLFence::isSupported() and use it to decide whether to sync cpu or not in flushAndSubmit call. Also make the glFlush() in GLFence::create() optional. * Source/WebCore/platform/graphics/egl/GLFence.cpp: (WebCore::GLFence::isSupported): (WebCore::GLFence::create): (WebCore::isGLFenceSyncSupported): Deleted. * Source/WebCore/platform/graphics/egl/GLFence.h: * Source/WebCore/platform/graphics/nicosia/NicosiaBuffer.cpp: (Nicosia::AcceleratedBuffer::completePainting): Canonical link: https://commits.webkit.org/277862@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 34d7f5: Fix JSCOnly Mac build
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 34d7f551c40ab7253255304e1443394d5e49 https://github.com/WebKit/WebKit/commit/34d7f551c40ab7253255304e1443394d5e49 Author: Keith Miller Date: 2024-04-23 (Tue, 23 Apr 2024) Changed paths: M Source/WTF/wtf/PlatformUse.h Log Message: --- Fix JSCOnly Mac build https://bugs.webkit.org/show_bug.cgi?id=273078 rdar://126873329 Reviewed by Yusuke Suzuki. We need to use the pthreads JIT permissions API on Apple platforms (other than iOS family devices in OpenSource). * Source/WTF/wtf/PlatformUse.h: Canonical link: https://commits.webkit.org/277861@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] ab3b33: Cherry-pick 277501@main (21426dee35a1). https://bu...
Branch: refs/heads/webkitglib/2.44 Home: https://github.com/WebKit/WebKit Commit: ab3b337d35921355809a224a87983e1e147ed72d https://github.com/WebKit/WebKit/commit/ab3b337d35921355809a224a87983e1e147ed72d Author: Antti Koivisto Date: 2024-04-23 (Tue, 23 Apr 2024) Changed paths: A LayoutTests/fast/block/positioning/simple-out-of-flow-percent-height-expected.html A LayoutTests/fast/block/positioning/simple-out-of-flow-percent-height.html M Source/WebCore/rendering/RenderBlockFlow.cpp Log Message: --- Cherry-pick 277501@main (21426dee35a1). https://bugs.webkit.org/show_bug.cgi?id=272665 REGRESSION(271848@main): "Watch later" checkbox on youtube.com mis-renders https://bugs.webkit.org/show_bug.cgi?id=272665 rdar://125644808 Reviewed by Alan Baradlay. Percent height out-of-flow positioned boxes taking the fast path may end up with miscomputed height. * LayoutTests/fast/block/positioning/simple-out-of-flow-percent-height-expected.html: Added. * LayoutTests/fast/block/positioning/simple-out-of-flow-percent-height.html: Added. * Source/WebCore/rendering/RenderBlockFlow.cpp: (WebCore::RenderBlockFlow::layoutModernLines): Disable the out-of-flow fast path if there are percent height boxes. The problem is that the fast path does a synchronous layout for these boxes before the height of the parent is computed. The synchronous layout itself is a workaround but fixing it may be more complicated. Canonical link: https://commits.webkit.org/277501@main Canonical link: https://commits.webkit.org/274313.153@webkitglib/2.44 To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] c48d5a: [CMake] Avoid libSkia.a to always be considered ou...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: c48d5a8a6a389f9bca2ff8d9977b96124f792c39 https://github.com/WebKit/WebKit/commit/c48d5a8a6a389f9bca2ff8d9977b96124f792c39 Author: Adrian Perez de Castro Date: 2024-04-23 (Tue, 23 Apr 2024) Changed paths: M Source/ThirdParty/skia/CMakeLists.txt Log Message: --- [CMake] Avoid libSkia.a to always be considered outdated https://bugs.webkit.org/show_bug.cgi?id=270776 Reviewed by Carlos Garcia Campos. Use a POST_BUILD build event command attached to the Skia target to create the symlink for the headers, instead of having a target as a dependency. Build events always run when a target is built, but crucially do not cause the target to be considered out-of-date. * Source/ThirdParty/skia/CMakeLists.txt: Canonical link: https://commits.webkit.org/277860@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 6eefd2: iOS web push processing before unlock can cause In...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 6eefd2796ca6a2b650c4d0caed20137bbdb91bbd https://github.com/WebKit/WebKit/commit/6eefd2796ca6a2b650c4d0caed20137bbdb91bbd Author: Ben Nham Date: 2024-04-23 (Tue, 23 Apr 2024) Changed paths: M Source/WTF/wtf/PlatformHave.h M Source/WebCore/PAL/PAL.xcodeproj/project.pbxproj A Source/WebCore/PAL/pal/spi/ios/MobileKeyBagSPI.h M Source/WebKit/Configurations/WebKit.xcconfig M Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.webpushd.sb.in M Source/WebKit/webpushd/PushService.mm A WebKitLibraries/SDKs/iphoneos17.0-additions.sdk/System/Library/PrivateFrameworks/MobileKeyBag.framework/MobileKeyBag.tbd Log Message: --- iOS web push processing before unlock can cause InvalidStateError exceptions https://bugs.webkit.org/show_bug.cgi?id=272865 rdar://126061835 Reviewed by Brady Eidson. If a web push is processed before the user unlocks the device for the very first time, then that processing fails because the PushDatabase file has file protection attributes that prevent it from being opened before first unlock. This then causes the PushService to get in to a state where it responds to all IPCs with an InvalidStateError since the push database couldn't be initialized. Changing the protection class to always allow access is probably not a great idea because no one has ever validated whether all the downstream work involved in handling a push event (e.g. spawning a service worker in a new process) works before first unlock. It likely doesn't, because many files on the volume will have a protection class attribute that makes them inaccessible before first unlock. To fix this, hold off on database initialization until the user unlocks the device for the first time. It's important that we only hold off only on DB initialization and not on initializing the push service connection (i.e. creating ApplePushServiceConnection) because apsd needs us to check in promptly or else it will put our daemon in a penalty box for not responding to its launch on demand request promptly. * Source/WTF/wtf/PlatformHave.h: * Source/WebCore/PAL/PAL.xcodeproj/project.pbxproj: * Source/WebCore/PAL/pal/spi/ios/MobileKeyBagSPI.h: Added. * Source/WebKit/Configurations/WebKit.xcconfig: * Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.webpushd.sb.in: * Source/WebKit/webpushd/PushService.mm: (WebPushD::performAfterFirstUnlock): (WebPushD::hasUnlockedAtLeastOnce): (WebPushD::PushService::create): * WebKitLibraries/SDKs/iphoneos17.0-additions.sdk/System/Library/PrivateFrameworks/MobileKeyBag.framework/MobileKeyBag.tbd: Added. Canonical link: https://commits.webkit.org/277859@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 5060ef: TextIterator::emitText: cap textEndOffset to rende...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 5060efe86a321543d57a2a1581de2ce2cd2e3a33 https://github.com/WebKit/WebKit/commit/5060efe86a321543d57a2a1581de2ce2cd2e3a33 Author: Vitor Roriz Date: 2024-04-23 (Tue, 23 Apr 2024) Changed paths: M LayoutTests/platform/ios/TestExpectations M Source/WebCore/editing/TextIterator.cpp M Source/WebCore/editing/TextIterator.h Log Message: --- TextIterator::emitText: cap textEndOffset to renderer's string length https://bugs.webkit.org/show_bug.cgi?id=273090 rdar://125650526 Reviewed by Ryosuke Niwa. With the use of text-transform, the renderer's text can differ from the renderer's original text on length. For example, the German S sharp (ß) when text-transformed to uppercase becomes "SS". When TextIterator::emitText is requested to use the original text due to TextIteratorBehavior::EmitsOriginalText, the received textEndOffset can be potentially greater than the render's original text. In our example, we would get a textEndOffset of 2 and originalText.length would be 1, given that originalText is ß. For that reason, we cap the textEndOffset to the string result's length. We are also using the original's render text instead of render's text when EmitsOriginalText is requested. * LayoutTests/platform/ios/TestExpectations: * Source/WebCore/editing/TextIterator.cpp: (WebCore::TextIterator::handleTextNode): (WebCore::TextIterator::handleTextRun): (WebCore::TextIterator::emitText): * Source/WebCore/editing/TextIterator.h: (WebCore::TextIterator::rendererTextForBehavior const): Canonical link: https://commits.webkit.org/277858@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] c3b1ff: [GStreamer] Improve support for AV1 colorimetry ha...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: c3b1ffe5f3a0558820b7f75fa36664b2b7ef0408 https://github.com/WebKit/WebKit/commit/c3b1ffe5f3a0558820b7f75fa36664b2b7ef0408 Author: Philippe Normand Date: 2024-04-23 (Tue, 23 Apr 2024) Changed paths: M Source/WebCore/platform/graphics/AV1Utilities.cpp M Source/WebCore/platform/gstreamer/GStreamerCodecUtilities.cpp M Tools/TestWebKitAPI/Tests/WebCore/gstreamer/GStreamerTest.cpp Log Message: --- [GStreamer] Improve support for AV1 colorimetry handling https://bugs.webkit.org/show_bug.cgi?id=273059 Reviewed by Xabier Rodriguez-Calvar. The parsed av01 codec string can now be translated to GStreamer caps. While writing tests for this I noticed a couple issues in `parseAV1CodecParameters()`, returning empty results after parsing optional fields. That issue is now fixed and we have tests. Later on the encoder will be adapted in order to make use of this code. * Source/WebCore/platform/graphics/AV1Utilities.cpp: (WebCore::parseAV1CodecParameters): * Source/WebCore/platform/gstreamer/GStreamerCodecUtilities.cpp: (WebCore::av1CapsFromCodecString): (WebCore::GStreamerCodecUtilities::capsFromCodecString): * Tools/TestWebKitAPI/Tests/WebCore/gstreamer/GStreamerTest.cpp: (TestWebKitAPI::TEST_F): Canonical link: https://commits.webkit.org/277857@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
