[webkit-changes] [WebKit/WebKit] af7bd7: Fix PlayStation build following 278652@main
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: af7bd70a44bb1e3adae77f36bcc34a47daeeb9a4 https://github.com/WebKit/WebKit/commit/af7bd70a44bb1e3adae77f36bcc34a47daeeb9a4 Author: Ross Kirsling Date: 2024-05-11 (Sat, 11 May 2024) Changed paths: M Source/WebCore/css/color/StyleColor.cpp Log Message: --- Fix PlayStation build following 278652@main https://bugs.webkit.org/show_bug.cgi?id=274045 Unreviewed build fix. * Source/WebCore/css/color/StyleColor.cpp: Fix `error: equality comparison operator can only be defaulted in a class definition`. Canonical link: https://commits.webkit.org/278661@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 11b43d: REGRESSION: run-api-tests strips newlines in failu...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 11b43d3c00bef88afe9c312dcbab08bb295fd3cb https://github.com/WebKit/WebKit/commit/11b43d3c00bef88afe9c312dcbab08bb295fd3cb Author: Jonathan Bedard Date: 2024-05-11 (Sat, 11 May 2024) Changed paths: M Tools/Scripts/webkitpy/api_tests/runner.py Log Message: --- REGRESSION: run-api-tests strips newlines in failure summary https://bugs.webkit.org/show_bug.cgi?id=266044 rdar://119696758 Reviewed by Sam Sneddon. Our technique for grabbing the remaining stdout and stderr from an API process accidentally strips newlines. * Tools/Scripts/webkitpy/api_tests/runner.py: (_Worker._filter_noisy_output): Strip trailing whitespace on output. (_Worker._run_single_test): Re-add newlines when grabbing remaining stdout and stderr. Canonical link: https://commits.webkit.org/278660@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] f0496e: [ iOS ] TestWebKitAPI.KeyboardInputTests.Autocorre...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: f0496e97f86310855a96eaf4de419a1a63cfe34a https://github.com/WebKit/WebKit/commit/f0496e97f86310855a96eaf4de419a1a63cfe34a Author: Richard Robinson Date: 2024-05-11 (Sat, 11 May 2024) Changed paths: M Tools/TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm Log Message: --- [ iOS ] TestWebKitAPI.KeyboardInputTests.AutocorrectionIndicatorColorNotAffectedByAuthorDefinedAncestorColorProperty is a consistent crash https://bugs.webkit.org/show_bug.cgi?id=273834 rdar://127683332 Reviewed by Aditya Keerthi. The test assumed a screen scale factor of 3, however this is not always true. Fix by querying the actual screen scale and just using that. * Tools/TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm: (TestWebKitAPI::TEST(KeyboardInputTests, AutocorrectionIndicatorColorNotAffectedByAuthorDefinedAncestorColorProperty)): Canonical link: https://commits.webkit.org/278659@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] b64c3e: [UnifedPDF] Clean up annotation repaint code
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: b64c3ed8059502609a5dba0c79c6d84773362c4a https://github.com/WebKit/WebKit/commit/b64c3ed8059502609a5dba0c79c6d84773362c4a Author: Simon Fraser Date: 2024-05-11 (Sat, 11 May 2024) Changed paths: M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.h M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm Log Message: --- [UnifedPDF] Clean up annotation repaint code https://bugs.webkit.org/show_bug.cgi?id=274030 rdar://127915821 Reviewed by Tim Horton. Future changes will require that we target repaints at pages, not just at the entire document. To support this, tighten up annotation repaint code to target a page (until the final conversion to document coordinates). Implement a `pageIndexForAnnotation()` helper, and add `setNeedsRepaintForAnnotation()`. Implementing `revealAnnotation()` eliminates the final call site of `documentRectForAnnotation()`, which can be removed. * Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.h: * Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm: (WebKit::UnifiedPDFPlugin::setNeedsRepaintForAnnotation): (WebKit::UnifiedPDFPlugin::paintHoveredAnnotationOnPage): (WebKit::UnifiedPDFPlugin::pageIndexForAnnotation const): (WebKit::UnifiedPDFPlugin::pageIndexWithHoveredAnnotation const): (WebKit::UnifiedPDFPlugin::repaintAnnotationsForFormField): (WebKit::UnifiedPDFPlugin::startTrackingAnnotation): (WebKit::UnifiedPDFPlugin::updateTrackedAnnotation): (WebKit::UnifiedPDFPlugin::finishTrackingAnnotation): (WebKit::UnifiedPDFPlugin::setActiveAnnotation): (WebKit::UnifiedPDFPlugin::revealAnnotation): (WebKit::UnifiedPDFPlugin::annotationRectsForTesting const): (WebKit::UnifiedPDFPlugin::documentRectForAnnotation const): Deleted. Canonical link: https://commits.webkit.org/278658@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] a6189e: Unreviewed, reverting 278631@main.
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: a6189e1a0def7cf7f0226bce7ccf41ff257a2708 https://github.com/WebKit/WebKit/commit/a6189e1a0def7cf7f0226bce7ccf41ff257a2708 Author: Commit Queue Date: 2024-05-11 (Sat, 11 May 2024) Changed paths: M LayoutTests/http/tests/site-isolation/scrolling/basic-scrolling-tree.html A LayoutTests/http/tests/site-isolation/scrolling/multiple-root-frames-expected.txt A LayoutTests/http/tests/site-isolation/scrolling/multiple-root-frames.html A LayoutTests/http/tests/site-isolation/scrolling/remove-root-frame-expected.txt A LayoutTests/http/tests/site-isolation/scrolling/remove-root-frame.html M LayoutTests/platform/ios/TestExpectations M Source/WTF/WTF.xcodeproj/project.pbxproj M Source/WTF/wtf/CMakeLists.txt A Source/WTF/wtf/SmallMap.h M Source/WebCore/dom/Document.cpp M Source/WebCore/page/LocalFrame.cpp M Source/WebCore/page/LocalFrameView.cpp M Source/WebCore/page/LocalFrameView.h M Source/WebCore/page/scrolling/AsyncScrollingCoordinator.cpp M Source/WebCore/page/scrolling/AsyncScrollingCoordinator.h M Source/WebCore/page/scrolling/ScrollingCoordinator.h M Source/WebCore/page/scrolling/ScrollingStateTree.h M Source/WebCore/page/scrolling/ScrollingTree.cpp M Source/WebCore/page/scrolling/ScrollingTree.h M Source/WebCore/page/scrolling/ScrollingTreeFrameHostingNode.cpp M Source/WebCore/page/scrolling/ScrollingTreeFrameHostingNode.h M Source/WebCore/page/scrolling/ThreadedScrollingCoordinator.cpp M Source/WebCore/platform/ScrollableArea.h M Source/WebCore/rendering/RenderLayerBacking.cpp M Source/WebCore/rendering/RenderLayerCompositor.cpp M Source/WebCore/rendering/RenderLayerScrollableArea.cpp M Source/WebCore/rendering/RenderLayerScrollableArea.h M Source/WebCore/rendering/RenderListBox.cpp M Source/WebCore/rendering/RenderListBox.h M Source/WebKit/UIProcess/RemoteLayerTree/RemoteLayerTreeDrawingAreaProxy.h M Source/WebKit/UIProcess/RemoteLayerTree/RemoteLayerTreeDrawingAreaProxy.mm M Source/WebKit/WebProcess/Plugins/PDF/PDFPluginBase.h M Source/WebKit/WebProcess/Plugins/PDF/PDFPluginBase.mm M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm M Source/WebKit/WebProcess/WebPage/RemoteLayerTree/RemoteLayerTreeDrawingArea.mm M Source/WebKit/WebProcess/WebPage/RemoteLayerTree/RemoteScrollingCoordinator.h M Source/WebKit/WebProcess/WebPage/RemoteLayerTree/RemoteScrollingCoordinator.mm M Tools/TestWebKitAPI/Tests/WTF/SmallSet.cpp Log Message: --- Unreviewed, reverting 278631@main. https://bugs.webkit.org/show_bug.cgi?id=274038 Speculative revert was not correct. Performance regression was introduced by different change. Relanding Reverted changeset: "Unreviewed, reverting 278591@main." https://bugs.webkit.org/show_bug.cgi?id=274023 https://commits.webkit.org/278631@main Canonical link: https://commits.webkit.org/278657@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 1a3a46: Unreviewed, reverting 278639@main.
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 1a3a465496fe6546999078e32fbfd2433c7d4945 https://github.com/WebKit/WebKit/commit/1a3a465496fe6546999078e32fbfd2433c7d4945 Author: Commit Queue Date: 2024-05-11 (Sat, 11 May 2024) Changed paths: M Source/WebKit/Shared/AuxiliaryProcess.h M Source/WebKit/Shared/Cocoa/AuxiliaryProcessCocoa.mm M Source/WebKit/Shared/EntryPointUtilities/Cocoa/XPCService/XPCServiceMain.mm M Source/WebKit/Shared/mac/AuxiliaryProcessMac.mm Log Message: --- Unreviewed, reverting 278639@main. https://bugs.webkit.org/show_bug.cgi?id=274037 Introduced crash on older OS versions Reverted changeset: "Remove notify option NOTIFY_OPT_LOOPBACK in WebKit" https://bugs.webkit.org/show_bug.cgi?id=272977 https://commits.webkit.org/278639@main Canonical link: https://commits.webkit.org/278656@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] d7a54e: REGRESSION (274876@main): [ iOS Debug ] accessibil...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: d7a54ec9f06058d19cfa177b6bb2b92e6794dc5b https://github.com/WebKit/WebKit/commit/d7a54ec9f06058d19cfa177b6bb2b92e6794dc5b Author: Chris Dumez Date: 2024-05-11 (Sat, 11 May 2024) Changed paths: M LayoutTests/platform/ios/TestExpectations M Source/WebCore/accessibility/AXObjectCache.cpp M Source/WebCore/accessibility/AXObjectCache.h M Source/WebCore/accessibility/AXTextMarker.h M Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm M Source/WebCore/accessibility/mac/AXObjectCacheMac.mm Log Message: --- REGRESSION (274876@main): [ iOS Debug ] accessibility/text-marker/text-marker-range-stale-node-crash.html is a consistent crash https://bugs.webkit.org/show_bug.cgi?id=274020 rdar://127901543 Reviewed by Darin Adler. Introduce SafeTextMarkerData as an alternative to TextMarkerData, which uses a WeakPtr for `node` instead of a raw pointer. TextMarkerData currently has to keep using a raw pointer because memcpy() / memcmp() are used with this type's bytes. However, we should use SafeTextMarkerData wherever possible and this patch starts doing some adoption to address the crash. * LayoutTests/platform/ios/TestExpectations: * Source/WebCore/accessibility/AXObjectCache.cpp: (WebCore::AXObjectCache::characterOffsetForTextMarkerData): (WebCore::AXObjectCache::accessibilityObjectForTextMarkerData): * Source/WebCore/accessibility/AXObjectCache.h: * Source/WebCore/accessibility/AXTextMarker.h: (WebCore::SafeTextMarkerData::toTextMarkerData const): (WebCore::TextMarkerData::toSafeTextMarkerData const): * Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm: (-[WebAccessibilityTextMarker initWithTextMarker:cache:]): (-[WebAccessibilityTextMarker initWithData:cache:]): (-[WebAccessibilityTextMarker dataRepresentation]): (-[WebAccessibilityTextMarker visiblePosition]): (-[WebAccessibilityTextMarker characterOffset]): (-[WebAccessibilityTextMarker isIgnored]): (-[WebAccessibilityTextMarker accessibilityObject]): (-[WebAccessibilityTextMarker description]): (-[WebAccessibilityTextMarker textMarkerData]): Canonical link: https://commits.webkit.org/278655@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 23f2fd: Unreviewed, reverting 278596@main and 278616@main.
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 23f2fddbbd22a00c05cc6f9a91ae8641f92e2275 https://github.com/WebKit/WebKit/commit/23f2fddbbd22a00c05cc6f9a91ae8641f92e2275 Author: Commit Queue Date: 2024-05-11 (Sat, 11 May 2024) Changed paths: M Source/WebCore/rendering/GridLayoutFunctions.cpp M Source/WebCore/rendering/GridLayoutFunctions.h M Source/WebCore/rendering/GridTrackSizingAlgorithm.cpp M Source/WebCore/rendering/RenderBox.cpp M Source/WebCore/rendering/RenderBox.h M Source/WebCore/rendering/RenderBoxModelObject.cpp M Source/WebCore/rendering/RenderBoxModelObject.h M Source/WebCore/rendering/RenderGrid.cpp Log Message: --- Unreviewed, reverting 278596@main and 278616@main. https://bugs.webkit.org/show_bug.cgi?id=274034 Speedometer 3 1% regression Reverted changesets: "[Cleanup] Remove RenderBoxModelObject::overridingContainingBlockContentWidth virtual functions" https://bugs.webkit.org/show_bug.cgi?id=273945 https://commits.webkit.org/278596@main "[Cleanup] Remove RenderBox::hasOverridingContainingBlock*" https://bugs.webkit.org/show_bug.cgi?id=273967 https://commits.webkit.org/278616@main Canonical link: https://commits.webkit.org/278654@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 3ced9c: AX: AXObjectCache::postPlatformNotification should...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 3ced9c0227fcfedf9cb7c94b3599059b078a07dc https://github.com/WebKit/WebKit/commit/3ced9c0227fcfedf9cb7c94b3599059b078a07dc Author: Andres Gonzalez Date: 2024-05-11 (Sat, 11 May 2024) Changed paths: M Source/WebCore/accessibility/AXObjectCache.cpp M Source/WebCore/accessibility/AXObjectCache.h M Source/WebCore/accessibility/atspi/AXObjectCacheAtspi.cpp M Source/WebCore/accessibility/ios/AXObjectCacheIOS.mm M Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.cpp M Source/WebCore/accessibility/mac/AXObjectCacheMac.mm M Source/WebCore/accessibility/playstation/AXObjectCachePlayStation.cpp M Source/WebCore/accessibility/win/AXObjectCacheWin.cpp Log Message: --- AX: AXObjectCache::postPlatformNotification should take an AccessibilityObject not an AXCoreObject. https://bugs.webkit.org/show_bug.cgi?id=273968 Reviewed by Darin Adler. This tightens the type checks since we should never pass an AXIsolatedObject to notification methods. this was a leftover from the initial introduction of AXCoreObject. * Source/WebCore/accessibility/AXObjectCache.cpp: (WebCore::AXObjectCache::buildIsolatedTree): (WebCore::AXObjectCache::handleAllDeferredChildrenChanged): (WebCore::AXObjectCache::notificationPostTimerFired): (WebCore::AXObjectCache::handleActiveDescendantChange): (WebCore::AXObjectCache::handleMenuListValueChanged): * Source/WebCore/accessibility/AXObjectCache.h: * Source/WebCore/accessibility/atspi/AXObjectCacheAtspi.cpp: (WebCore::AXObjectCache::postPlatformNotification): * Source/WebCore/accessibility/ios/AXObjectCacheIOS.mm: (WebCore::AXObjectCache::postPlatformNotification): (WebCore::AXObjectCache::postTextStateChangePlatformNotification): (WebCore::AXObjectCache::postTextReplacementPlatformNotification): (WebCore::AXObjectCache::postTextReplacementPlatformNotificationForTextControl): (WebCore::AXObjectCache::frameLoadingEventPlatformNotification): * Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.cpp: (WebCore::AXIsolatedTree::reportLoadingProgress): * Source/WebCore/accessibility/mac/AXObjectCacheMac.mm: (WebCore::exerciseIsIgnored): (WebCore::AXObjectCache::postPlatformNotification): * Source/WebCore/accessibility/playstation/AXObjectCachePlayStation.cpp: (WebCore::AXObjectCache::postPlatformNotification): (WebCore::AXObjectCache::handleScrolledToAnchor): (WebCore::AXObjectCache::platformHandleFocusedUIElementChanged): * Source/WebCore/accessibility/win/AXObjectCacheWin.cpp: (WebCore::AXObjectCache::handleScrolledToAnchor): (WebCore::AXObjectCache::postPlatformNotification): (WebCore::AXObjectCache::platformHandleFocusedUIElementChanged): Canonical link: https://commits.webkit.org/278653@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 794b34: Re-land "Use a standard interface for all StyleCol...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 794b345789d622c60a60e4b29b264c838b177279 https://github.com/WebKit/WebKit/commit/794b345789d622c60a60e4b29b264c838b177279 Author: Sam Weinig Date: 2024-05-11 (Sat, 11 May 2024) Changed paths: M Source/WebCore/Headers.cmake M Source/WebCore/Sources.txt M Source/WebCore/WebCore.xcodeproj/project.pbxproj R Source/WebCore/css/StyleColor.cpp R Source/WebCore/css/StyleColor.h M Source/WebCore/css/color/CSSColorDescriptors.h M Source/WebCore/css/color/CSSColorMixSerialization.h A Source/WebCore/css/color/StyleAbsoluteColor.cpp A Source/WebCore/css/color/StyleAbsoluteColor.h A Source/WebCore/css/color/StyleColor.cpp A Source/WebCore/css/color/StyleColor.h A Source/WebCore/css/color/StyleColorMix.cpp A Source/WebCore/css/color/StyleColorMix.h A Source/WebCore/css/color/StyleCurrentColor.cpp A Source/WebCore/css/color/StyleCurrentColor.h M Source/WebCore/css/parser/CSSPropertyParserConsumer+None.cpp M Source/WebCore/css/parser/CSSPropertyParserConsumer+NoneDefinitions.h Log Message: --- Re-land "Use a standard interface for all StyleColor kinds, and move them each to their own file" https://bugs.webkit.org/show_bug.cgi?id=274029 Reviewed by Matthieu Dubet and Tim Nguyen. In preparation for adding support for relative colors to StyleColor, this change adds explicit types for each StyleColor kind and gives each their own files. This allows the implementation of StyleColor itself to be very simple, just dispatching to whatever kind is resident in the variant. The one complication here is that StyleColorMix (and any relative color support type in the future), wants to have a StyleColor as a member, creating a recursive relationship. This means we have be very careful not to instantiate the ColorKind variant in the StyleColor header at all, as it would lead to undefined type compile errors. Instead, we out-of-line all the operations. With a bunch of StyleColor related files now existing, they also all got moved to the color subdirectory. * Source/WebCore/Headers.cmake: * Source/WebCore/Sources.txt: * Source/WebCore/WebCore.xcodeproj/project.pbxproj: - Added new files, updated for file moves. * Source/WebCore/css/color/CSSColorDescriptors.h: - Add missing #include. * Source/WebCore/css/color/CSSColorMixSerialization.h: - Updated #include to use new StyleColorMix header. * Source/WebCore/css/color/StyleAbsoluteColor.cpp: Added. * Source/WebCore/css/color/StyleAbsoluteColor.h: Added. - Added. Simple wrapper around a Color. * Source/WebCore/css/color/StyleColor.cpp: Renamed from Source/WebCore/css/StyleColor.cpp. * Source/WebCore/css/color/StyleColor.h: Renamed from Source/WebCore/css/StyleColor.h. - Moved. Updated to out-of-line all uses of ColorKind and use generic dispatch in all possible places. * Source/WebCore/css/color/StyleColorMix.cpp: Added. * Source/WebCore/css/color/StyleColorMix.h: Added. - Moved from StyleColor.h/cpp * Source/WebCore/css/color/StyleCurrentColor.cpp: Added. * Source/WebCore/css/color/StyleCurrentColor.h: Added. - Moved from StyleColor.h/cpp Canonical link: https://commits.webkit.org/278652@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 7ee2bb: REGRESSION (268971@main): [ iOS ] TestWebKitAPI.iO...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 7ee2bbe31b7ff81eb609d85ae5030cd12fcd4514 https://github.com/WebKit/WebKit/commit/7ee2bbe31b7ff81eb609d85ae5030cd12fcd4514 Author: Wenson Hsieh Date: 2024-05-11 (Sat, 11 May 2024) Changed paths: M Tools/TestWebKitAPI/Tests/WebKitCocoa/iOSMouseSupport.mm Log Message: --- REGRESSION (268971@main): [ iOS ] TestWebKitAPI.iOSMouseSupport.MouseDidMoveOverElement is a consistent timeout https://bugs.webkit.org/show_bug.cgi?id=273839 rdar://127691561 Reviewed by Megan Gardner and Richard Robinson. The changes to `MouseEventTestHarness` in 268971@main made this API test time out, but only on iPad. That's because UIKit adds its own `UIHoverGestureRecognizer` subclasses to `WKContentView` on iPad, which causes the logic in the constructor of `MouseEventTestHarness` to initialize `m_hoverGestureRecognizer` to the wrong gesture. Subsequently, attempts to simulate mouse movement using this gesture recognizer fails to call into `WKMouseInteraction` delegate methods. To fix this, simply adjust this logic to check the name of the gesture recognizer (`"WKMouseHover"`) instead of relying on the class and `allowedTouchTypes`. * Tools/TestWebKitAPI/Tests/WebKitCocoa/iOSMouseSupport.mm: (TestWebKitAPI::MouseEventTestHarness::MouseEventTestHarness): Canonical link: https://commits.webkit.org/278651@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] e4580b: Fix PlayStation build following 278635@main
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: e4580b83827141b83a6625ee5527c4a9552e2c94 https://github.com/WebKit/WebKit/commit/e4580b83827141b83a6625ee5527c4a9552e2c94 Author: Ross Kirsling Date: 2024-05-11 (Sat, 11 May 2024) Changed paths: M Source/WebCore/css/parser/CSSPropertyParserConsumer+RawTypes.h Log Message: --- Fix PlayStation build following 278635@main https://bugs.webkit.org/show_bug.cgi?id=274031 Unreviewed build fix. 278635@main introduced the first usage of `consteval` into the codebase; apparently this works correctly in clang 9-10 and clang 15+, but not in clang 11-14. Presumably we should introduce a macro in Compiler.h to allow us to use `consteval` where possible, but for the moment, this patch just fixes the build by reverting `consteval` to `constexpr`. * Source/WebCore/css/parser/CSSPropertyParserConsumer+RawTypes.h: (WebCore::computeMinimumValue): Canonical link: https://commits.webkit.org/278650@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 42b0cd: Crash in transparent document markers when collect...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 42b0cd59678aa755142f8bc4dddc5e5ccd91bea5 https://github.com/WebKit/WebKit/commit/42b0cd59678aa755142f8bc4dddc5e5ccd91bea5 Author: Megan Gardner Date: 2024-05-10 (Fri, 10 May 2024) Changed paths: M Source/WebCore/dom/DocumentMarker.h M Source/WebCore/dom/DocumentMarkerController.cpp M Source/WebCore/dom/DocumentMarkerController.h M Source/WebCore/rendering/RenderReplaced.cpp M Source/WebKit/WebProcess/WebPage/Cocoa/WebPageCocoa.mm Log Message: --- Crash in transparent document markers when collecting. https://bugs.webkit.org/show_bug.cgi?id=274021 rdar://127898121 Reviewed by Wenson Hsieh. Was incorrectly casting the data for a transparent document marker. Add the additional element data to a transparent document maker to make it function correctly and also not crash. * Source/WebCore/dom/DocumentMarker.h: * Source/WebCore/dom/DocumentMarkerController.cpp: (WebCore::DocumentMarkerController::addTransparentContentMarker): (WebCore::shouldInsertAsSeparateMarker): * Source/WebCore/dom/DocumentMarkerController.h: * Source/WebCore/rendering/RenderReplaced.cpp: (WebCore::contentContainsReplacedElement): * Source/WebKit/WebProcess/WebPage/Cocoa/WebPageCocoa.mm: (WebKit::WebPage::updateTextIndicatorStyleVisibilityForID): Canonical link: https://commits.webkit.org/278649@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
