[webkit-changes] [WebKit/WebKit] e6d5e1: [WebGPU] Index buffer can read outside the range o...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: e6d5e1a6604e5aa2b7786e3f40859274b6353c90 https://github.com/WebKit/WebKit/commit/e6d5e1a6604e5aa2b7786e3f40859274b6353c90 Author: Mike Wyrzykowski Date: 2024-05-22 (Wed, 22 May 2024) Changed paths: M Source/WebGPU/WebGPU/BindableResource.h M Source/WebGPU/WebGPU/Buffer.h M Source/WebGPU/WebGPU/Buffer.mm M Source/WebGPU/WebGPU/CommandEncoder.h M Source/WebGPU/WebGPU/CommandEncoder.mm M Source/WebGPU/WebGPU/ComputePassEncoder.mm M Source/WebGPU/WebGPU/Device.h M Source/WebGPU/WebGPU/Device.mm M Source/WebGPU/WebGPU/Pipeline.mm M Source/WebGPU/WebGPU/RenderBundleEncoder.h M Source/WebGPU/WebGPU/RenderBundleEncoder.mm M Source/WebGPU/WebGPU/RenderPassEncoder.h M Source/WebGPU/WebGPU/RenderPassEncoder.mm Log Message: --- [WebGPU] Index buffer can read outside the range of a vertex buffer https://bugs.webkit.org/show_bug.cgi?id=273828 Reviewed by Tadeu Zagallo. Prevent out of bounds accesses into vertex buffers via drawIndexed, drawIndirect, and drawIndexedIndirect by running a non-rasterizing vertex shader immedietly before the draw call. ICB path rewrites the ICB render commands to avoid out of bounds accesses. * Source/WebGPU/WebGPU/BindableResource.h: * Source/WebGPU/WebGPU/Buffer.h: * Source/WebGPU/WebGPU/Buffer.mm: (WebGPU::Buffer::Buffer): (WebGPU::Buffer::maxIndex const): (WebGPU::Buffer::indirectBuffer const): (WebGPU::Buffer::indirectIndexedBuffer const): (WebGPU::Buffer::indirectBufferRequiresRecomputation const): (WebGPU::Buffer::indirectBufferRecomputed): (WebGPU::Buffer::indirectBufferInvalidated): (WebGPU::Buffer::recomputeMaxIndexValues const): Deleted. * Source/WebGPU/WebGPU/CommandEncoder.h: * Source/WebGPU/WebGPU/CommandEncoder.mm: (WebGPU::CommandEncoder::copyBufferToBuffer): (WebGPU::CommandEncoder::copyTextureToBuffer): (WebGPU::CommandEncoder::clearBuffer): * Source/WebGPU/WebGPU/ComputePassEncoder.mm: (WebGPU::addResourceToActiveResources): (WebGPU::ComputePassEncoder::runPredispatchIndirectCallValidation): (WebGPU::setCommandEncoder): * Source/WebGPU/WebGPU/Device.h: * Source/WebGPU/WebGPU/Device.mm: (WebGPU::GPUFrameCapture::captureFrame): (WebGPU::Device::dispatchCallBuffer): (WebGPU::Device::dispatchCallPipelineState): (WebGPU::Device::copyIndexIndirectArgsPipeline): (wgpuDeviceReference): Deleted. (wgpuDeviceRelease): Deleted. (wgpuDeviceCreateBindGroup): Deleted. (wgpuDeviceCreateBindGroupLayout): Deleted. (wgpuDeviceCreateBuffer): Deleted. (wgpuDeviceCreateCommandEncoder): Deleted. (wgpuDeviceCreateComputePipeline): Deleted. (wgpuDeviceCreateComputePipelineAsync): Deleted. (wgpuDeviceCreateComputePipelineAsyncWithBlock): Deleted. (wgpuDeviceCreatePipelineLayout): Deleted. (wgpuDeviceCreateQuerySet): Deleted. (wgpuDeviceCreateRenderBundleEncoder): Deleted. (wgpuDeviceCreateRenderPipeline): Deleted. (wgpuDeviceCreateRenderPipelineAsync): Deleted. (wgpuDeviceCreateRenderPipelineAsyncWithBlock): Deleted. (wgpuDeviceCreateSampler): Deleted. (wgpuDeviceImportExternalTexture): Deleted. (wgpuDeviceCreateShaderModule): Deleted. (wgpuDeviceCreateSwapChain): Deleted. (wgpuDeviceCreateTexture): Deleted. (wgpuDeviceDestroy): Deleted. (wgpuDeviceEnumerateFeatures): Deleted. (wgpuDeviceGetLimits): Deleted. (wgpuDeviceGetQueue): Deleted. (wgpuDeviceHasFeature): Deleted. (wgpuDevicePopErrorScope): Deleted. (wgpuDevicePopErrorScopeWithBlock): Deleted. (wgpuDevicePushErrorScope): Deleted. (wgpuDeviceSetDeviceLostCallback): Deleted. (wgpuDeviceSetDeviceLostCallbackWithBlock): Deleted. (wgpuDeviceSetUncapturedErrorCallback): Deleted. (wgpuDeviceSetUncapturedErrorCallbackWithBlock): Deleted. (wgpuDeviceSetLabel): Deleted. * Source/WebGPU/WebGPU/Pipeline.mm: (WebGPU::validateBindGroup): * Source/WebGPU/WebGPU/RenderBundleEncoder.h: * Source/WebGPU/WebGPU/RenderBundleEncoder.mm: (-[RenderBundleICBWithResources initWithICB:containerBuffer:pipelineState:depthStencilState:cullMode:frontFace:depthClipMode:depthBias:depthBiasSlopeScale:depthBiasClamp:fragmentDynamicOffsetsBuffer:pipeline:]): (-[RenderBundleICBWithResources minVertexCountForDrawCommand]): (WebGPU::makeRenderBundleICBWithResources): (WebGPU::RenderBundleEncoder::addResource): (WebGPU::RenderBundleEncoder::computeMininumVertexCount const): (WebGPU::RenderBundleEncoder::storeVertexBufferCountsForValidation): (WebGPU::RenderBundleEncoder::drawIndexed): (WebGPU::RenderBundleEncoder::drawIndexedIndirect): (WebGPU::RenderBundleEncoder::drawIndirect): (WebGPU::RenderBundleEncoder::endCurrentICB): (WebGPU::RenderBundleEncoder::setIndexBuffer): (WebGPU::RenderBundleEncoder::setVertexBuffer): (-[RenderBundleICBWithResources initWithICB:pipelineState:depthStencilState:cullMode:frontFace:depthClipMode:depthBias:depthBiasSlopeScale:depthBiasClamp:fragmentDynamicOffsetsBuffer:pipeline:]): Deleted. * Source/WebGPU/WebGPU/RenderPassEncoder.h: * Source/WebGPU/WebGPU/RenderPassEncoder.mm:
[webkit-changes] [WebKit/WebKit] 2b5ed0: [JSC] ArrayBuffer/SharedArrayBuffer constructor sh...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 2b5ed009bee397beb4099f6ea0e40072d2aaec0f https://github.com/WebKit/WebKit/commit/2b5ed009bee397beb4099f6ea0e40072d2aaec0f Author: Sosuke Suzuki Date: 2024-05-22 (Wed, 22 May 2024) Changed paths: M JSTests/test262/expectations.yaml M Source/JavaScriptCore/runtime/JSArrayBufferConstructor.cpp Log Message: --- [JSC] ArrayBuffer/SharedArrayBuffer constructor should check length before creating an instance https://bugs.webkit.org/show_bug.cgi?id=272809 Reviewed by Darin Adler. According to the specs[1][2], the constructors for ArrayBuffer and SharedArrayBuffer should check if `byteLength > maxByteLength` and throw a `RangeError` before creating an instance. This patch changes to perform these checks before creating an instance. `toTypedArrayIndex`, there is an observable side effect of throwing a `RangeError` when `length` exceeds `MAX_ARRAY_BUFFER_SIZE`. So, this patch use `toNumber` instead when checking `byteLength > maxByteLength`. [1]: https://tc39.es/ecma262/#sec-allocatearraybuffer [2]: https://tc39.es/ecma262/#sec-allocatesharedarraybuffer * JSTests/test262/expectations.yaml: * Source/JavaScriptCore/runtime/JSArrayBufferConstructor.cpp: (JSC::JSGenericArrayBufferConstructor::constructImpl): Canonical link: https://commits.webkit.org/279181@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] d7bdc4: [JSC] Use `var` instead of `let` in built-in `Iter...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: d7bdc4ae05980d538508f43938c1e1ee21b844bd https://github.com/WebKit/WebKit/commit/d7bdc4ae05980d538508f43938c1e1ee21b844bd Author: Sosuke Suzuki Date: 2024-05-22 (Wed, 22 May 2024) Changed paths: M Source/JavaScriptCore/builtins/IteratorHelpers.js Log Message: --- [JSC] Use `var` instead of `let` in built-in `IteratorHelpers.js` https://bugs.webkit.org/show_bug.cgi?id=274453 Reviewed by Alexey Shvayka. In the built-in JS files, `var` was adopted instead of `let` / `const` by 219251@main[1]. However, in the functions in `IteratorHelpers.js` added by 250474@main[2], `let` is used. This patch changes to use `var` instead of `let`. [1]: https://commits.webkit.org/219251@main [2]: https://commits.webkit.org/250474@main * Source/JavaScriptCore/builtins/IteratorHelpers.js: (set linkTimeConstant.builtinMapIterable): Canonical link: https://commits.webkit.org/279180@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] fe5796: Fixed Playstation build break after 279166@main
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: fe5796bc5acc530a367de9ddeee7c993d3bf2edd https://github.com/WebKit/WebKit/commit/fe5796bc5acc530a367de9ddeee7c993d3bf2edd Author: Jigen Zhou Date: 2024-05-22 (Wed, 22 May 2024) Changed paths: M Source/WebCore/platform/graphics/nicosia/NicosiaImageBufferPipe.cpp Log Message: --- Fixed Playstation build break after 279166@main https://bugs.webkit.org/show_bug.cgi?id=274566 Reviewed by Ross Kirsling. Only allow using 'fence' if PLATFORM(GTK) || PLATFORM(WPE) * Source/WebCore/platform/graphics/nicosia/NicosiaImageBufferPipe.cpp: Canonical link: https://commits.webkit.org/279179@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 9b7b8d: [Remote Inspection] Add the ability to target elem...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 9b7b8ded8fa6f6aa85d72ec5f68bee3252c00a81 https://github.com/WebKit/WebKit/commit/9b7b8ded8fa6f6aa85d72ec5f68bee3252c00a81 Author: Wenson Hsieh Date: 2024-05-22 (Wed, 22 May 2024) Changed paths: M Source/WebCore/page/ElementTargetingController.cpp M Source/WebCore/page/ElementTargetingController.h M Source/WebCore/page/ElementTargetingTypes.h M Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in M Source/WebKit/UIProcess/API/APITargetedElementInfo.h M Source/WebKit/UIProcess/API/APITargetedElementRequest.cpp M Source/WebKit/UIProcess/API/APITargetedElementRequest.h M Source/WebKit/UIProcess/API/Cocoa/_WKTargetedElementInfo.h M Source/WebKit/UIProcess/API/Cocoa/_WKTargetedElementInfo.mm M Source/WebKit/UIProcess/API/Cocoa/_WKTargetedElementRequest.h M Source/WebKit/UIProcess/API/Cocoa/_WKTargetedElementRequest.mm M Tools/TestWebKitAPI/Tests/WebKitCocoa/ElementTargetingTests.mm Log Message: --- [Remote Inspection] Add the ability to target elements based on selector information https://bugs.webkit.org/show_bug.cgi?id=274532 Reviewed by Aditya Keerthi. Add the ability to target elements based on compound selectors (i.e. selectors including all shadow hosts). Additionally, expose a new property on targeted element info to indicate whether or not the element is inside of an adjustment subtree. See below for more details. Test: ElementTargeting.RequestElementsFromSelectors * Source/WebCore/page/ElementTargetingController.cpp: (WebCore::targetedElementInfo): (WebCore::ElementTargetingController::findTargets): (WebCore::ElementTargetingController::findNodes): Add `WebCore::TargetedElementSelectors` as a new type of targeted element request data, alongside a point in root view coordinates and a search string. Add a new `findNodes()` implementation for this targeted element selectors list. Build on top of the `findElementFromSelectors` method (see below for more details). (WebCore::ElementTargetingController::extractTargets): Drive-by adjustment: only target elements if they're non-empty. This can otherwise happen in the case where the list of candidates was derived from ascending the DOM when performing a text search. (WebCore::ElementTargetingController::adjustVisibilityInRepeatedlyTargetedRegions): (WebCore::resolveSelectorToQuery): Pull this out into a separate static helper function, so we can use it from both methods below. (WebCore::ElementTargetingController::applyVisibilityAdjustmentFromSelectors): Pull logic out of this method, and into `findElementFromSelectors`. Also, remove the document argument (which was only ever the main document), and instead just retrieve the main document from the `m_page` (or exit early if it's null). (WebCore::ElementTargetingController::findElementFromSelectors): Factor out logic for mapping a list of compound selectors (including all shadow hosts) into a separate private method, so that it can be reused in multiple places in this class. (WebCore::ElementTargetingController::mainDocument const): Avoid some code duplication by adding a private helper method to return the main document, through `m_page`. (WebCore::ElementTargetingController::selectorBasedVisibilityAdjustmentTimerFired): * Source/WebCore/page/ElementTargetingController.h: * Source/WebCore/page/ElementTargetingTypes.h: * Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in: Add the new IPC types. * Source/WebKit/UIProcess/API/APITargetedElementInfo.h: * Source/WebKit/UIProcess/API/APITargetedElementRequest.cpp: (API::TargetedElementRequest::setSelectors): (API::TargetedElementRequest::searchText const): Deleted. Remove an unused getter for `-searchText`, along with support in the API object. * Source/WebKit/UIProcess/API/APITargetedElementRequest.h: * Source/WebKit/UIProcess/API/Cocoa/_WKTargetedElementInfo.h: * Source/WebKit/UIProcess/API/Cocoa/_WKTargetedElementInfo.mm: (-[_WKTargetedElementInfo isInVisibilityAdjustmentSubtree]): * Source/WebKit/UIProcess/API/Cocoa/_WKTargetedElementRequest.h: * Source/WebKit/UIProcess/API/Cocoa/_WKTargetedElementRequest.mm: (-[_WKTargetedElementRequest initWithSelectors:]): Add a new initializer that takes a compound selector representing the element to target. (-[_WKTargetedElementRequest searchText]): Deleted. (-[_WKTargetedElementRequest point]): Deleted. * Tools/TestWebKitAPI/Tests/WebKitCocoa/ElementTargetingTests.mm: (-[WKWebView targetedElementInfoWithSelectors:]): (TestWebKitAPI::TEST(ElementTargeting, RequestElementsFromSelectors)): Add a new API test to exercise the change. (TestWebKitAPI::TEST(ElementTargeting, AdjustVisibilityFromPseudoSelectors)): Canonical link: https://commits.webkit.org/279178@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications
[webkit-changes] [WebKit/WebKit] 0752e9: [WebGPU] Invalidate all command buffers on submit, ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 0752e9050165de7947d5aeb3c613755099311b25 https://github.com/WebKit/WebKit/commit/0752e9050165de7947d5aeb3c613755099311b25 Author: Mike Wyrzykowski Date: 2024-05-22 (Wed, 22 May 2024) Changed paths: M LayoutTests/platform/mac-wk2/TestExpectations M Source/WebGPU/WebGPU/Queue.mm Log Message: --- [WebGPU] Invalidate all command buffers on submit, regardless of it the submit call succeeds https://bugs.webkit.org/show_bug.cgi?id=274244> Reviewed by Dan Glastonbury. Invalidate all command buffers passed to GPUQueue.submit, regardless of whether or not they get committed. Fixes the test being added in https://github.com/gpuweb/cts/pull/3716 Reland with regression fixed and test enabled. * LayoutTests/platform/mac-wk2/TestExpectations: * Source/WebGPU/WebGPU/Queue.mm: (WebGPU::invalidateCommandBuffers): (WebGPU::Queue::submit): Canonical link: https://commits.webkit.org/279177@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 72e754: Build fix for TextIndicatorStyle.
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 72e7542a458b37df50599619295d9703876ebcda https://github.com/WebKit/WebKit/commit/72e7542a458b37df50599619295d9703876ebcda Author: Megan Gardner Date: 2024-05-22 (Wed, 22 May 2024) Changed paths: M Source/WebKit/UIProcess/mac/WKTextIndicatorStyleManager.h Log Message: --- Build fix for TextIndicatorStyle. https://bugs.webkit.org/show_bug.cgi?id=274569 rdar://128584738 Unreviewed build fix. Switched with TextIndicatorStyle type to use without switching headers. * Source/WebKit/UIProcess/mac/WKTextIndicatorStyleManager.h: Canonical link: https://commits.webkit.org/279176@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] ab81e7: [Skia] Enable ImageBitmap acceleration
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: ab81e7f867ac35e5208bea45000caea21b7c5e9f https://github.com/WebKit/WebKit/commit/ab81e7f867ac35e5208bea45000caea21b7c5e9f Author: Carlos Garcia Campos Date: 2024-05-22 (Wed, 22 May 2024) Changed paths: M LayoutTests/platform/glib/TestExpectations M Source/WebCore/html/ImageBitmap.cpp Log Message: --- [Skia] Enable ImageBitmap acceleration https://bugs.webkit.org/show_bug.cgi?id=274518 Reviewed by Miguel Gomez. * LayoutTests/platform/glib/TestExpectations: * Source/WebCore/html/ImageBitmap.cpp: (WebCore::bufferRenderingMode): Canonical link: https://commits.webkit.org/279175@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 683c07: Unreviewed, reverting 278501@main (e84b70e7fa81)
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 683c07d76d889210ea9adc6415e2ee61d58a04d4 https://github.com/WebKit/WebKit/commit/683c07d76d889210ea9adc6415e2ee61d58a04d4 Author: Marta Darbinyan Date: 2024-05-22 (Wed, 22 May 2024) Changed paths: M LayoutTests/imported/w3c/web-platform-tests/trusted-types/Document-write-expected.txt M LayoutTests/imported/w3c/web-platform-tests/trusted-types/Document-write.html M LayoutTests/imported/w3c/web-platform-tests/trusted-types/block-string-assignment-to-Document-write-expected.txt M LayoutTests/imported/w3c/web-platform-tests/trusted-types/block-string-assignment-to-Document-write.html M Source/WebCore/dom/Document+HTML.idl M Source/WebCore/dom/Document.cpp M Source/WebCore/dom/Document.h Log Message: --- Unreviewed, reverting 278501@main (e84b70e7fa81) https://bugs.webkit.org/show_bug.cgi?id=274567 rdar://128491467 REGRESSION (278501@main) [ Sonoma ASan Release ] - Multiple crashing tests with AddressSanitizer error Reverted change: Update implementation of TT enforcement for document.write(ln) https://bugs.webkit.org/show_bug.cgi?id=273819 278501@main (e84b70e7fa81) Canonical link: https://commits.webkit.org/279174@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] d7994b: [visionOS] build-webkit tries to build ImageDiff f...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: d7994bbd6d7f0c1e2e2683c9ad6e02e75937bcc6 https://github.com/WebKit/WebKit/commit/d7994bbd6d7f0c1e2e2683c9ad6e02e75937bcc6 Author: Elliott Williams Date: 2024-05-22 (Wed, 22 May 2024) Changed paths: M Tools/Scripts/webkitdirs.pm Log Message: --- [visionOS] build-webkit tries to build ImageDiff for visionOS, not macOS rdar://128579426 https://bugs.webkit.org/show_bug.cgi?id=274564 Unreviewed build fix. Add --visionos to the list of arguments that get stripped from build-webkit when calling build-imagediff. Before: > perl -ITools/Scripts -Mwebkitdirs -e 'print extractNonMacOSHostConfiguration(\@ARGV)' -- --visionos-device --visionos-device After: > perl -ITools/Scripts -Mwebkitdirs -e 'print extractNonMacOSHostConfiguration(\@ARGV)' -- --visionos-device * Tools/Scripts/webkitdirs.pm: (extractNonMacOSHostConfiguration): Canonical link: https://commits.webkit.org/279173@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] ac3c97: [Gardening] Mark expected failing Navigation test
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: ac3c97671310494a611244c8ad75e76c4a1c7352 https://github.com/WebKit/WebKit/commit/ac3c97671310494a611244c8ad75e76c4a1c7352 Author: Patrick Griffis Date: 2024-05-22 (Wed, 22 May 2024) Changed paths: M LayoutTests/TestExpectations Log Message: --- [Gardening] Mark expected failing Navigation test Unreviewed test gardening. * LayoutTests/TestExpectations: Canonical link: https://commits.webkit.org/279172@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 140660: [WebGPU] RenderBundleEncoder::setVertexBuffer may ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 140660a4096bd07ed39c47760aa8c75eb4e9cf7c https://github.com/WebKit/WebKit/commit/140660a4096bd07ed39c47760aa8c75eb4e9cf7c Author: Mike Wyrzykowski Date: 2024-05-22 (Wed, 22 May 2024) Changed paths: M Source/WebGPU/WebGPU/RenderBundleEncoder.mm Log Message: --- [WebGPU] RenderBundleEncoder::setVertexBuffer may result in a UAF https://bugs.webkit.org/show_bug.cgi?id=274525 Reviewed by Dan Glastonbury. Every other call site to recordCommand captures by Ref, this was the only outlier passing a raw C++ pointer to the lambda. * Source/WebGPU/WebGPU/RenderBundleEncoder.mm: (WebGPU::RenderBundleEncoder::setVertexBuffer): Canonical link: https://commits.webkit.org/279171@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] a0dd96: [view-transitions] Spinner animation on https://ww...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: a0dd96a17f0a14f6ceab095230852d772289c052 https://github.com/WebKit/WebKit/commit/a0dd96a17f0a14f6ceab095230852d772289c052 Author: Matt Woodrow Date: 2024-05-22 (Wed, 22 May 2024) Changed paths: M Source/WebCore/rendering/RenderLayerBacking.cpp Log Message: --- [view-transitions] Spinner animation on https://www.kvin.me/posts/button-interaction jumps https://bugs.webkit.org/show_bug.cgi?id=274400 Reviewed by Tim Nguyen. When an element is captured in a view transition, its 'transform' gets applied to the ::view-transition-group pseudo element, and we stop it being applied to the layer for the element itself. This makes sure we don't accidentally put it back again with an async animation. * Source/WebCore/rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::startAnimation): Canonical link: https://commits.webkit.org/279170@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] ece697: Close XPC connection to OpenDirectory before revok...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: ece697a8bb31fb41166345f9b24a60496eee9f45 https://github.com/WebKit/WebKit/commit/ece697a8bb31fb41166345f9b24a60496eee9f45 Author: Per Arne Vollan Date: 2024-05-22 (Wed, 22 May 2024) Changed paths: M Source/WebKit/Shared/mac/AuxiliaryProcessMac.mm Log Message: --- Close XPC connection to OpenDirectory before revoking sandbox extension https://bugs.webkit.org/show_bug.cgi?id=274557 rdar://128451478 Reviewed by Chris Dumez. Close XPC connection to OpenDirectory before revoking sandbox extension. Otherwise, another thread trying to write on a temporarily open connection could cause a crash, because the sandbox extension has been revoked. * Source/WebKit/Shared/mac/AuxiliaryProcessMac.mm: (WebKit::AuxiliaryProcess::openDirectoryCacheInvalidated): Canonical link: https://commits.webkit.org/279169@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 563c79: Resolve non-replaced URLs in style sheets when sav...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 563c795b80f1c0de51382050f74087012e70b4db https://github.com/WebKit/WebKit/commit/563c795b80f1c0de51382050f74087012e70b4db Author: Sihui Liu Date: 2024-05-22 (Wed, 22 May 2024) Changed paths: M Source/WebCore/css/CSSFontFaceSrcValue.cpp M Source/WebCore/css/CSSFontFaceSrcValue.h M Source/WebCore/css/CSSImageValue.cpp M Source/WebCore/css/CSSImageValue.h M Tools/TestWebKitAPI/Tests/WebKitCocoa/CreateWebArchive.mm Log Message: --- Resolve non-replaced URLs in style sheets when saving web page resources https://bugs.webkit.org/show_bug.cgi?id=270960 rdar://120498768 Reviewed by Ryosuke Niwa. Some CSS rules allow developers to specify multiple resources so that browser could pick the most suitable one to use (e.g. @font-face). In our current implementation, when saving web page resources, we only save the resource that is loaded. That means, URLs of other candidate resources will not be replaced with local file path in saved web page. It is common that style sheets use relative path for subresource URL, and the result is the relative paths in saved style sheets now point to non-existent files (as the candidate resources are not saved). To fix that problem, we now resolve the non-replaced URLs in saved style sheets. With this change, when browser loads the saved web page and decides to load candidate resource, it could send the request to correct server. API test: WebArchive.SaveResourcesStyle * Source/WebCore/css/CSSFontFaceSrcValue.cpp: (WebCore::CSSFontFaceSrcResourceValue::customSetReplacementURLForSubresources): (WebCore::CSSFontFaceSrcResourceValue::customClearReplacementURLForSubresources): (WebCore::CSSFontFaceSrcResourceValue::customCSSText const): * Source/WebCore/css/CSSFontFaceSrcValue.h: * Source/WebCore/css/CSSImageValue.cpp: (WebCore::CSSImageValue::customSetReplacementURLForSubresources): (WebCore::CSSImageValue::customClearReplacementURLForSubresources): (WebCore::CSSImageValue::customCSSText const): * Source/WebCore/css/CSSImageValue.h: * Tools/TestWebKitAPI/Tests/WebKitCocoa/CreateWebArchive.mm: (TestWebKitAPI::(WebArchive, SaveResourcesStyleWithUnloadedResources)): Canonical link: https://commits.webkit.org/279168@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 298b67: REGRESSION(279097@main): [Win GTK WPE] ASSERTION F...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 298b67cd8c41d4b73bd73016e0548f3440871751 https://github.com/WebKit/WebKit/commit/298b67cd8c41d4b73bd73016e0548f3440871751 Author: Chris Dumez Date: 2024-05-22 (Wed, 22 May 2024) Changed paths: M Source/WebCore/platform/image-decoders/ico/ICOImageDecoder.cpp Log Message: --- REGRESSION(279097@main): [Win GTK WPE] ASSERTION FAILED: isASCII(characters[i]) in WTF::StringLiterals::operator""_span under WebCore::ICOImageDecoder::imageTypeAtIndex https://bugs.webkit.org/show_bug.cgi?id=274549 Reviewed by Fujii Hironori. Don't use ""_span since it requires all characters to be ASCII. * Source/WebCore/platform/image-decoders/ico/ICOImageDecoder.cpp: (WebCore::ICOImageDecoder::imageTypeAtIndex): Canonical link: https://commits.webkit.org/279167@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 3216dc: Fixed Playstation build break after 279154@main
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 3216dc5420087aadbf282e20672d8b74493f990b https://github.com/WebKit/WebKit/commit/3216dc5420087aadbf282e20672d8b74493f990b Author: Jigen Zhou Date: 2024-05-22 (Wed, 22 May 2024) Changed paths: M Source/WebCore/platform/graphics/nicosia/NicosiaImageBufferPipe.cpp Log Message: --- Fixed Playstation build break after 279154@main https://bugs.webkit.org/show_bug.cgi?id=274559 Reviewed by Don Olmstead. Fix linking error on undefined symbol `WebCore::GLFence::~GLFence() * Source/WebCore/platform/graphics/nicosia/NicosiaImageBufferPipe.cpp: Canonical link: https://commits.webkit.org/279166@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] cc61eb: Pass additional data for correct TextIndicator sty...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: cc61ebcd1d9dffbc763dfb9d72050db3ea27b594 https://github.com/WebKit/WebKit/commit/cc61ebcd1d9dffbc763dfb9d72050db3ea27b594 Author: Megan Gardner Date: 2024-05-22 (Wed, 22 May 2024) Changed paths: M Source/WebKit/Scripts/webkit/messages.py M Source/WebKit/Shared/UnifiedTextReplacement.serialization.in M Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm M Source/WebKit/UIProcess/API/Cocoa/WKWebViewInternal.h M Source/WebKit/UIProcess/Cocoa/PageClientImplCocoa.h M Source/WebKit/UIProcess/Cocoa/PageClientImplCocoa.mm M Source/WebKit/UIProcess/Cocoa/WebPageProxyCocoa.mm M Source/WebKit/UIProcess/PageClient.h M Source/WebKit/UIProcess/TextIndicatorStyle.h M Source/WebKit/UIProcess/WKSTextStyleManager.h M Source/WebKit/UIProcess/WebPageProxy.cpp M Source/WebKit/UIProcess/WebPageProxy.h M Source/WebKit/UIProcess/WebPageProxy.messages.in M Source/WebKit/UIProcess/mac/WKTextIndicatorStyleManager.h M Source/WebKit/UIProcess/mac/WebViewImpl.h M Source/WebKit/UIProcess/mac/WebViewImpl.mm M Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.mm M Source/WebKit/WebProcess/WebPage/Cocoa/UnifiedTextReplacementController.mm M Source/WebKit/WebProcess/WebPage/Cocoa/WebPageCocoa.mm M Source/WebKit/WebProcess/WebPage/UnifiedTextReplacementController.h M Source/WebKit/WebProcess/WebPage/WebPage.cpp M Source/WebKit/WebProcess/WebPage/WebPage.h Log Message: --- Pass additional data for correct TextIndicator styling. https://bugs.webkit.org/show_bug.cgi?id=274505 rdar://128475613 Reviewed by Aditya Keerthi. * Source/WebKit/Scripts/webkit/messages.py: (headers_for_type): * Source/WebKit/Shared/UnifiedTextReplacement.serialization.in: * Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm: (-[WKWebView _addTextIndicatorStyleForID:withData:]): (-[WKWebView _enableTextIndicatorStylingAfterElementWithID:]): (-[WKWebView _enableTextIndicatorStylingForElementWithID:]): (-[WKWebView _addTextIndicatorStyleForID:withStyleType:]): Deleted. * Source/WebKit/UIProcess/API/Cocoa/WKWebViewInternal.h: * Source/WebKit/UIProcess/Cocoa/PageClientImplCocoa.h: * Source/WebKit/UIProcess/Cocoa/PageClientImplCocoa.mm: (WebKit::PageClientImplCocoa::addTextIndicatorStyleForID): * Source/WebKit/UIProcess/Cocoa/WKTextIndicatorStyleType.h: * Source/WebKit/UIProcess/Cocoa/WebPageProxyCocoa.mm: (WebKit::WebPageProxy::addTextIndicatorStyleForID): * Source/WebKit/UIProcess/PageClient.h: * Source/WebKit/UIProcess/TextIndicatorStyle.h: * Source/WebKit/UIProcess/WKSTextStyleManager.h: * Source/WebKit/UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::setTextIndicatorFromFrame): * Source/WebKit/UIProcess/WebPageProxy.h: * Source/WebKit/UIProcess/WebPageProxy.messages.in: * Source/WebKit/UIProcess/mac/WKTextIndicatorStyleManager.h: * Source/WebKit/UIProcess/mac/WebViewImpl.h: * Source/WebKit/UIProcess/mac/WebViewImpl.mm: (WebKit::WebViewImpl::addTextIndicatorStyleForID): * Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.mm: * Source/WebKit/WebProcess/WebPage/Cocoa/UnifiedTextReplacementController.mm: (WebKit::UnifiedTextReplacementController::removeTransparentMarkersForUUID): (WebKit::UnifiedTextReplacementController::removeTransparentMarkersForSession): (WebKit::UnifiedTextReplacementController::textReplacementSessionDidReceiveTextWithReplacementRange): (WebKit::UnifiedTextReplacementController::contextRangeForSessionOrRangeWithUUID const): * Source/WebKit/WebProcess/WebPage/Cocoa/WebPageCocoa.mm: (WebKit::WebPage::updateTextIndicatorStyleVisibilityForID): * Source/WebKit/WebProcess/WebPage/UnifiedTextReplacementController.h: * Source/WebKit/WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::addTextIndicatorStyleForID): * Source/WebKit/WebProcess/WebPage/WebPage.h: Canonical link: https://commits.webkit.org/279165@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 365ec3: REGRESSION (268367@main): [ iOS ] imported/w3c/web...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 365ec381a9cbaf85d6dc334f8ed1b92c30a3d467 https://github.com/WebKit/WebKit/commit/365ec381a9cbaf85d6dc334f8ed1b92c30a3d467 Author: Jay Stfleur Date: 2024-05-22 (Wed, 22 May 2024) Changed paths: M LayoutTests/platform/ios/TestExpectations M LayoutTests/platform/ios/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt Log Message: --- REGRESSION (268367@main): [ iOS ] imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml.html is a consistent failure https://bugs.webkit.org/show_bug.cgi?id=274245 rdar://128180039 Unreviewed test gardening. Adding rebaseline and removing test expectations. * LayoutTests/platform/ios/TestExpectations: * LayoutTests/platform/ios/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt: Canonical link: https://commits.webkit.org/279164@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 056665: Remove mac-monterey folders from LayoutTests/platf...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 05666581bf4ccf74ec8700a949363341524bc6c3 https://github.com/WebKit/WebKit/commit/05666581bf4ccf74ec8700a949363341524bc6c3 Author: Ben Schwartz Date: 2024-05-22 (Wed, 22 May 2024) Changed paths: R LayoutTests/platform/mac-monterey-wk2/fast/scrolling/mac/scrollbars/scrollbars-controller-type-expected.txt R LayoutTests/platform/mac-monterey/TestExpectations R LayoutTests/platform/mac-monterey/accessibility/math-multiscript-attributes-expected.txt R LayoutTests/platform/mac-monterey/css1/box_properties/acid_test-expected.txt R LayoutTests/platform/mac-monterey/css2.1/t09-c5526c-display-00-e-expected.txt R LayoutTests/platform/mac-monterey/editing/caret/color-span-inside-editable-background-expected.html R LayoutTests/platform/mac-monterey/editing/caret/color-span-inside-editable-expected.html R LayoutTests/platform/mac-monterey/fast/block/basic/011-expected.txt R LayoutTests/platform/mac-monterey/fast/block/basic/minheight-expected.txt R LayoutTests/platform/mac-monterey/fast/block/margin-collapse/103-expected.txt R LayoutTests/platform/mac-monterey/fast/css/002-expected.txt R LayoutTests/platform/mac-monterey/fast/events/invalid/missing-end-tag-expected.txt R LayoutTests/platform/mac-monterey/fast/events/mouse-cursor-multiframecur-expected.txt R LayoutTests/platform/mac-monterey/fast/invalid/008-expected.txt R LayoutTests/platform/mac-monterey/fast/invalid/missing-end-tag-expected.png R LayoutTests/platform/mac-monterey/fast/invalid/missing-end-tag-expected.txt R LayoutTests/platform/mac-monterey/fast/overflow/003-expected.txt R LayoutTests/platform/mac-monterey/fast/text/basic/generic-family-reset-expected.txt R LayoutTests/platform/mac-monterey/fast/text/canvas-color-fonts/stroke-color-COLR-expected.html R LayoutTests/platform/mac-monterey/fast/text/canvas-color-fonts/stroke-color-shadow-COLR-expected.html R LayoutTests/platform/mac-monterey/fast/text/canvas-color-fonts/stroke-color-shadow-ctm-COLR-expected.html R LayoutTests/platform/mac-monterey/fast/text/canvas-color-fonts/stroke-gradient-COLR-expected.html R LayoutTests/platform/mac-monterey/fast/text/resources/Ahem-COLR.ttf R LayoutTests/platform/mac-monterey/http/tests/resourceLoadStatistics/website-data-removal-for-site-navigated-to-with-filtered-link-decoration-after-long-deletion-expected.txt R LayoutTests/platform/mac-monterey/http/tests/resourceLoadStatistics/website-data-removal-for-site-navigated-to-with-unfiltered-link-decoration-after-short-deletion-expected.txt R LayoutTests/platform/mac-monterey/http/tests/resourceLoadStatistics/website-data-removal-for-site-navigated-to-without-link-decoration-expected.txt R LayoutTests/platform/mac-monterey/http/tests/resourceLoadStatistics/website-data-removal-for-site-without-user-interaction-expected.txt R LayoutTests/platform/mac-monterey/http/tests/security/xss-DENIED-xsl-external-entity-expected.txt R LayoutTests/platform/mac-monterey/http/tests/security/xss-DENIED-xsl-external-entity-redirect-expected.txt R LayoutTests/platform/mac-monterey/http/tests/security/xss-DENIED-xsl-external-entity-xslt-docloader-expected.txt R LayoutTests/platform/mac-monterey/imported/w3c/web-platform-tests/cookie-store/change_eventhandler_for_document_cookie.https.window-expected.txt R LayoutTests/platform/mac-monterey/imported/w3c/web-platform-tests/cookie-store/change_eventhandler_for_http_cookie_and_set_cookie_headers.https.window-expected.txt R LayoutTests/platform/mac-monterey/imported/w3c/web-platform-tests/cookie-store/encoding.https.any-expected.txt R LayoutTests/platform/mac-monterey/imported/w3c/web-platform-tests/cookies/value/value-ctl-expected.txt R LayoutTests/platform/mac-monterey/imported/w3c/web-platform-tests/html/canvas/element/manual/wide-gamut-canvas/canvas-createImageBitmap-e_srgb-expected.txt R LayoutTests/platform/mac-monterey/imported/w3c/web-platform-tests/html/dom/documents/resource-metadata-management/document-cookie-expected.txt R LayoutTests/platform/mac-monterey/imported/w3c/web-platform-tests/mathml/presentation-markup/mrow/mrow-fallback-expected.txt R LayoutTests/platform/mac-monterey/imported/w3c/web-platform-tests/mathml/relations/css-styling/ignored-properties-001-expected.txt R LayoutTests/platform/mac-monterey/imported/w3c/web-platform-tests/mathml/relations/css-styling/not-participating-to-parent-layout-expected.txt R LayoutTests/platform/mac-monterey/imported/w3c/web-platform-tests/mathml/relations/css-styling/padding-border-margin/border-002-expected.txt R LayoutTests/platform/mac-monterey/imported/w3c/web-platform-tests/mathml/relations/css-styling/padding-border-margin/padding-002-expected.txt R
[webkit-changes] [WebKit/WebKit] b378f0: Unreviewed, reverting 279155@main.
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: b378f0009318ff3b6c5a18d3e8e50457999e2a40 https://github.com/WebKit/WebKit/commit/b378f0009318ff3b6c5a18d3e8e50457999e2a40 Author: Commit Queue Date: 2024-05-22 (Wed, 22 May 2024) Changed paths: M Source/WebKit/GPUProcess/mac/GPUProcessMac.mm M Source/WebKit/Shared/AuxiliaryProcess.h M Source/WebKit/Shared/mac/AuxiliaryProcessMac.mm M Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm Log Message: --- Unreviewed, reverting 279155@main. https://bugs.webkit.org/show_bug.cgi?id=274555 Incorrect revert, this will be resolved differently Reverted changeset: "Unreviewed, reverting 277204@main." https://bugs.webkit.org/show_bug.cgi?id=274553 https://commits.webkit.org/279155@main Canonical link: https://commits.webkit.org/279162@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 354d46: RenderLayer : Unbalanced begin/endTransparencyLaye...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 354d46a613b7dd92b44cd2d770f52127b33e546c https://github.com/WebKit/WebKit/commit/354d46a613b7dd92b44cd2d770f52127b33e546c Author: Nisha Jain Date: 2024-05-22 (Wed, 22 May 2024) Changed paths: A LayoutTests/fast/rendering/render-layer-with-providedbacking-crash-expected.txt A LayoutTests/fast/rendering/render-layer-with-providedbacking-crash.html M Source/WebCore/rendering/RenderLayer.cpp Log Message: --- RenderLayer : Unbalanced begin/endTransparencyLayers with nested masked elements and backing sharing causes a crash. https://bugs.webkit.org/show_bug.cgi?id=269865 rdar://11314. Reviewed by Simon Fraser. In order to balance the begin/endTransparencyLayers call for a TransparencyLayer with nested masked elements and backing sharing, added 'provided backing/paint to' into account while doing 'ancestor' traversal. * LayoutTests/fast/rendering/render-layer-with-providedbacking-crash-expected.txt: Added. * LayoutTests/fast/rendering/render-layer-with-providedbacking-crash.html: Added. * Source/WebCore/rendering/RenderLayer.cpp: (WebCore::RenderLayer::transparentPaintingAncestor): Originally-landed-as: 272448.600@safari-7618-branch (fc090f6ee88d). rdar://128545892 Canonical link: https://commits.webkit.org/279158@main Commit: 6398a57fc5a53f9fed588bfd32a13a8f55285ca0 https://github.com/WebKit/WebKit/commit/6398a57fc5a53f9fed588bfd32a13a8f55285ca0 Author: Scott Marcy Date: 2024-05-22 (Wed, 22 May 2024) Changed paths: M LayoutTests/TestExpectations A LayoutTests/ipc/removeMediaUsageManagerSession-test-expected.txt A LayoutTests/ipc/removeMediaUsageManagerSession-test.html Log Message: --- Adds a simplified test case to verify an over-release in ScreenTime is fixed. https://bugs.webkit.org/show_bug.cgi?id=270461 rdar://115279815 Reviewed by David Kilzer. This test is currently disabled in TestExpectations due to rdar://120486467 (Provide a way to notify WebKitTestRunner when we hit a purposeful MESSAGE_CHECK (267714)). * LayoutTests/TestExpectations: * LayoutTests/ipc/removeMediaUsageManagerSession-test-expected.txt: Added. * LayoutTests/ipc/removeMediaUsageManagerSession-test.html: Added. Originally-landed-as: 272448.683@safari-7618-branch (6e9c0ea8de57). rdar://128546108 Canonical link: https://commits.webkit.org/279159@main Commit: d8547c86a7407a7a4e6e39c82773391be270d94f https://github.com/WebKit/WebKit/commit/d8547c86a7407a7a4e6e39c82773391be270d94f Author: Rob Buis Date: 2024-05-22 (Wed, 22 May 2024) Changed paths: A LayoutTests/security/schedule-request-object-then-disconnect-crash-expected.txt A LayoutTests/security/schedule-request-object-then-disconnect-crash.html Log Message: --- Add test case for object loading crash https://bugs.webkit.org/show_bug.cgi?id=268771 rdar://121959099 Reviewed by Ryosuke Niwa. This test case applies to this bug as well as bug 264626, meaning it will crash without the fix from bug 264626. Note that it makes more sense to land this test than the one from bug 264626 as that one is flaky and this one is small and reproduces every time. * LayoutTests/security/schedule-request-object-then-disconnect-crash-expected.txt: Added. * LayoutTests/security/schedule-request-object-then-disconnect-crash.html: Added. Originally-landed-as: 274097.11@webkit-2024.2-embargoed (22a024aa0b40). rdar://128546360 Canonical link: https://commits.webkit.org/279160@main Commit: 345a36c5552dab4470ceb58265f42188094d0b0d https://github.com/WebKit/WebKit/commit/345a36c5552dab4470ceb58265f42188094d0b0d Author: Darryl Parkinson Date: 2024-05-22 (Wed, 22 May 2024) Changed paths: M Source/WebCore/workers/service/server/SWServerWorker.cpp M Source/WebCore/workers/service/server/SWServerWorker.h M Source/WebKit/NetworkProcess/ServiceWorker/WebSWServerToContextConnection.cpp M Source/WebKit/NetworkProcess/ServiceWorker/WebSWServerToContextConnection.h Log Message: --- Ensure that the SWServerWorker is in the correct state before finishing installation rdar://121429889 Reviewed by Youenn Fablet. Ensure that the SWServerWorker is in the expected state and bail if this method is triggered on a SWServerWorker in a different state. This method is callable over CoreIPC passing a ServiceWorkerIdentifier. Passing the ID of a service worker in any other state will reach the RELEASE_ASSERT * Source/WebCore/workers/service/server/SWServerWorker.cpp: (WebCore::SWServerWorker::didFinishInstall): Originally-landed-as: 272448.701@safari-7618-branch (be630dbb12c9). rdar://128546484 Canonical link: https://commits.webkit.org/279161@main Compare: https://github.com/WebKit/WebKit/compare/b287b6cc9662...345a36c5552d To unsubscribe from these emails, change your notification settings at
[webkit-changes] [WebKit/WebKit] 4d2933: [JSC] Harden CustomGetterSetter by adding MethodTa...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 4d29332a09b0f3b17eff2d44f464dd8dff77cad0 https://github.com/WebKit/WebKit/commit/4d29332a09b0f3b17eff2d44f464dd8dff77cad0 Author: Alexey Shvayka Date: 2024-05-22 (Wed, 22 May 2024) Changed paths: M Source/JavaScriptCore/runtime/CustomGetterSetter.h Log Message: --- [JSC] Harden CustomGetterSetter by adding MethodTable overrides that always crash https://bugs.webkit.org/show_bug.cgi?id=268897 Reviewed by Mark Lam. Just like GetterSetter, CustomGetterSetter is never purposely exposed to userland code. However, to make exploitation of accidentally exposed CustomGetterSetter objects difficult, this patch implements MethodTable overrides that abort the program when reached, similar to GetterSetter. * Source/JavaScriptCore/runtime/CustomGetterSetter.h: (JSC::CustomGetterSetter::getOwnPropertySlot): (JSC::CustomGetterSetter::put): (JSC::CustomGetterSetter::putByIndex): (JSC::CustomGetterSetter::setPrototype): (JSC::CustomGetterSetter::defineOwnProperty): (JSC::CustomGetterSetter::deleteProperty): Originally-landed-as: 272448.523@safari-7618-branch (66d8614c41ca). rdar://128498125 Canonical link: https://commits.webkit.org/279156@main Commit: b287b6cc9662e88415c7958132ab001431b35f9f https://github.com/WebKit/WebKit/commit/b287b6cc9662e88415c7958132ab001431b35f9f Author: Erica Li Date: 2024-05-22 (Wed, 22 May 2024) Changed paths: A LayoutTests/ipc/create-media-source-with-invalid-constraints-crash-expected.txt A LayoutTests/ipc/create-media-source-with-invalid-constraints-crash.html M Source/WebCore/platform/mediastream/MediaConstraints.cpp M Source/WebCore/platform/mediastream/MediaConstraints.h M Source/WebKit/UIProcess/Cocoa/UserMediaCaptureManagerProxy.cpp Log Message: --- WTFCrashWithSecurityImplication in WebCore::RealtimeMediaSource::fitnessDistance https://bugs.webkit.org/show_bug.cgi?id=268800 rdar://122105977 Reviewed by Youenn Fablet. This is short-term suggested fix to add isValid check to MediaTrackConstraintSetMap to ensure each incomming contraint from IPC call has the right MediaConstraintType. * LayoutTests/ipc/create-media-source-with-invalid-constraints-crash-expected.txt: Added. * LayoutTests/ipc/create-media-source-with-invalid-constraints-crash.html: Added. * Source/WebCore/platform/mediastream/MediaConstraints.cpp: (WebCore::MediaTrackConstraintSetMap::isValid const): * Source/WebCore/platform/mediastream/MediaConstraints.h: * Source/WebKit/UIProcess/Cocoa/UserMediaCaptureManagerProxy.cpp: (WebKit::UserMediaCaptureManagerProxy::createMediaSourceForCaptureDeviceWithConstraints): (WebKit::UserMediaCaptureManagerProxy::applyConstraints): Originally-landed-as: 272448.542@safari-7618-branch (01389d47b6ec). rdar://128498600 Canonical link: https://commits.webkit.org/279157@main Compare: https://github.com/WebKit/WebKit/compare/223c3b4280f0...b287b6cc9662 To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 223c3b: Unreviewed, reverting 277204@main.
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 223c3b4280f02d3f524c66dfa7c9878f5f5b1c10 https://github.com/WebKit/WebKit/commit/223c3b4280f02d3f524c66dfa7c9878f5f5b1c10 Author: Commit Queue Date: 2024-05-22 (Wed, 22 May 2024) Changed paths: M Source/WebKit/GPUProcess/mac/GPUProcessMac.mm M Source/WebKit/Shared/AuxiliaryProcess.h M Source/WebKit/Shared/mac/AuxiliaryProcessMac.mm M Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm Log Message: --- Unreviewed, reverting 277204@main. https://bugs.webkit.org/show_bug.cgi?id=274553 Introduced crash Reverted changeset: "Avoid IPC to OpenDirectory XPC service on main thread" https://bugs.webkit.org/show_bug.cgi?id=272192 https://commits.webkit.org/277204@main Canonical link: https://commits.webkit.org/279155@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit]
Branch: refs/tags/WebKit-7618.2.12.10.10 Home: https://github.com/WebKit/WebKit To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit]
Branch: refs/tags/WebKit-7618.2.12.11.7 Home: https://github.com/WebKit/WebKit To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] c1950e: Cherry-pick 2eca0fcc0b79. rdar://128223572
Branch: refs/heads/safari-7618.2.12.10-branch Home: https://github.com/WebKit/WebKit Commit: c1950e218f1bcbfadae41d0a9b414243cff8e86f https://github.com/WebKit/WebKit/commit/c1950e218f1bcbfadae41d0a9b414243cff8e86f Author: Mohsin Qureshi Date: 2024-05-16 (Thu, 16 May 2024) Changed paths: M Source/WTF/wtf/text/WTFString.h M Source/WebKit/Shared/Cocoa/CoreIPCContacts.mm M Tools/TestWebKitAPI/Tests/IPC/IPCSerialization.mm Log Message: --- Cherry-pick 2eca0fcc0b79. rdar://128223572 Apply patch. rdar://127453631 Canonical link: https://commits.webkit.org/272448.990@safari-7618-branch Commit: 41839bce22645f9876aaa4b023a89c6e5d760d18 https://github.com/WebKit/WebKit/commit/41839bce22645f9876aaa4b023a89c6e5d760d18 Author: Mohsin Qureshi Date: 2024-05-16 (Thu, 16 May 2024) Changed paths: M Configurations/Version.xcconfig Log Message: --- Versioning. WebKit-7618.2.12.10.10 Compare: https://github.com/WebKit/WebKit/compare/5b0e147c0955...41839bce2264 To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] f3c82e: Cherry-pick 2eca0fcc0b79. rdar://128223572
Branch: refs/heads/safari-7618.2.12.11-branch Home: https://github.com/WebKit/WebKit Commit: f3c82e4863a7def40f462638f2449f4279801d17 https://github.com/WebKit/WebKit/commit/f3c82e4863a7def40f462638f2449f4279801d17 Author: Mohsin Qureshi Date: 2024-05-16 (Thu, 16 May 2024) Changed paths: M Source/WTF/wtf/text/WTFString.h M Source/WebKit/Shared/Cocoa/CoreIPCContacts.mm M Tools/TestWebKitAPI/Tests/IPC/IPCSerialization.mm Log Message: --- Cherry-pick 2eca0fcc0b79. rdar://128223572 Apply patch. rdar://127453631 Canonical link: https://commits.webkit.org/272448.990@safari-7618-branch Commit: 94aa5569ec700548c53cfb064e4ca8c23c63ca57 https://github.com/WebKit/WebKit/commit/94aa5569ec700548c53cfb064e4ca8c23c63ca57 Author: Mohsin Qureshi Date: 2024-05-16 (Thu, 16 May 2024) Changed paths: M Configurations/Version.xcconfig Log Message: --- Versioning. WebKit-7618.2.12.11.7 Compare: https://github.com/WebKit/WebKit/compare/d5d9247df661...94aa5569ec70 To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 1fc4f3: Fixed Playstation build break after 279130@main
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 1fc4f38b76059284f949c8978d6d39782bd8a938 https://github.com/WebKit/WebKit/commit/1fc4f38b76059284f949c8978d6d39782bd8a938 Author: Jigen Zhou Date: 2024-05-22 (Wed, 22 May 2024) Changed paths: M Source/WebCore/platform/graphics/nicosia/NicosiaImageBufferPipe.cpp Log Message: --- Fixed Playstation build break after 279130@main https://bugs.webkit.org/show_bug.cgi?id=274547 Reviewed by Don Olmstead. TextureMapperPlatformLayerBuffer::setFence is only available if PLATFORM(GTK) || PLATFORM(WPE) * Source/WebCore/platform/graphics/nicosia/NicosiaImageBufferPipe.cpp: Canonical link: https://commits.webkit.org/279154@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit]
Branch: refs/tags/WebKit-7618.2.12.13.2 Home: https://github.com/WebKit/WebKit To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit]
Branch: refs/tags/WebKit-7618.2.12.13.1 Home: https://github.com/WebKit/WebKit To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] ea2439: Versioning.
Branch: refs/heads/safari-7618.2.12.13-branch Home: https://github.com/WebKit/WebKit Commit: ea2439209d9fe9154b5f04fb3bba08379bfc8d72 https://github.com/WebKit/WebKit/commit/ea2439209d9fe9154b5f04fb3bba08379bfc8d72 Author: Mohsin Qureshi Date: 2024-04-15 (Mon, 15 Apr 2024) Changed paths: M Configurations/Version.xcconfig Log Message: --- Versioning. WebKit-7618.2.12.13.1 Canonical link: https://commits.webkit.org/272448.932@safari-7618.2.12.13-branch Commit: b76830ca75df8b00dbdb36c592ad84f7ed110866 https://github.com/WebKit/WebKit/commit/b76830ca75df8b00dbdb36c592ad84f7ed110866 Author: Chris Dumez Date: 2024-04-16 (Tue, 16 Apr 2024) Changed paths: M Source/WebKit/Shared/AuxiliaryProcess.h M Source/WebKit/Shared/AuxiliaryProcess.messages.in M Source/WebKit/Shared/Cocoa/AuxiliaryProcessCocoa.mm M Source/WebKit/UIProcess/AuxiliaryProcessProxy.cpp M Source/WebKit/UIProcess/AuxiliaryProcessProxy.h M Source/WebKit/UIProcess/Cocoa/AuxiliaryProcessProxyCocoa.mm Log Message: --- Cherry-pick d6540a38e780. rdar://126492909 Regression(277427@main) Crash under AuxiliaryProcessProxy::notifyPreferencesChanged() https://bugs.webkit.org/show_bug.cgi?id=272695 rdar://126492909 Reviewed by Per Arne Vollan. We were using a HashMap to store preferences whose key was a std::pair. The first String was the domain and the second the preference name. However, for global preferences, the domain is null, causing a crash when hashing the key. To address an issue, we now store global preferences in a separate HashMap. * Source/WebKit/Shared/AuxiliaryProcess.h: * Source/WebKit/Shared/AuxiliaryProcess.messages.in: * Source/WebKit/Shared/Cocoa/AuxiliaryProcessCocoa.mm: (WebKit::AuxiliaryProcess::preferencesDidUpdate): * Source/WebKit/UIProcess/AuxiliaryProcessProxy.cpp: (WebKit::AuxiliaryProcessProxy::didChangeThrottleState): * Source/WebKit/UIProcess/AuxiliaryProcessProxy.h: * Source/WebKit/UIProcess/Cocoa/AuxiliaryProcessProxyCocoa.mm: (WebKit::AuxiliaryProcessProxy::notifyPreferencesChanged): Canonical link: https://commits.webkit.org/277514@main Commit: c4b640fbedbee2518b1fb4b1847657a91df811ed https://github.com/WebKit/WebKit/commit/c4b640fbedbee2518b1fb4b1847657a91df811ed Author: Dan Robson Date: 2024-04-17 (Wed, 17 Apr 2024) Changed paths: M Configurations/Version.xcconfig Log Message: --- Versioning. WebKit-7618.2.12.13.2 Canonical link: https://commits.webkit.org/272448.934@safari-7618.2.12.13-branch Commit: d7e2f94c57ea9901695253d7882747b6f62b6ab8 https://github.com/WebKit/WebKit/commit/d7e2f94c57ea9901695253d7882747b6f62b6ab8 Author: Per Arne Vollan Date: 2024-04-17 (Wed, 17 Apr 2024) Changed paths: M Source/WebKit/Platform/cocoa/XPCUtilities.h M Source/WebKit/Platform/cocoa/XPCUtilities.mm M Source/WebKit/Shared/Authentication/cocoa/AuthenticationManagerCocoa.mm M Source/WebKit/Shared/Cocoa/XPCEndpoint.mm M Source/WebKit/Shared/EntryPointUtilities/Cocoa/XPCService/XPCServiceMain.mm Log Message: --- Cherry-pick 3c2c899f692d. rdar://126479653 WebKit process termination with xpc_connection_kill does not always work https://bugs.webkit.org/show_bug.cgi?id=272669 rdar://126479653 Reviewed by Chris Dumez. WebKit process termination with xpc_connection_kill does not always work. We are currently seeing flaky termination behavior on macOS, where the child processes are not always terminated successfully. Additionally, on iOS, the XPC connection has become anonymous due to migration to extensions for WebKit processes, and xpc_connection_kill does not support anonymous connections. This patch addresses this issue by creating and sending a XPC message to the child process to request termination. This has a high chance of success, since we know that the XPC connection termination watchdog is holding a background assertion on the process, so it is not suspended. Additionally, the XPC message is being handled on the XPC event handler thread, which is handling very few messages, so it is very unlikely that it is blocked and cannot handle the message. This gives the process a chance to exit cleanly and send a reply back. If the UI process does not receive the expected reply, it will try calling xpc_connection_kill. * Source/WebKit/Platform/cocoa/XPCUtilities.h: * Source/WebKit/Platform/cocoa/XPCUtilities.mm: (WebKit::terminateWithReason): (WebKit::handleXPCExitMessage): * Source/WebKit/Shared/Authentication/cocoa/AuthenticationManagerCocoa.mm: (WebKit::AuthenticationManager::initializeConnection): * Source/WebKit/Shared/Cocoa/XPCEndpoint.mm: (WebKit::XPCEndpoint::XPCEndpoint): *
[webkit-changes] [WebKit/WebKit] d61c82: ImageFailure sometimes happen with fast/images/dec...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: d61c828315d694a910352391aa51a1493b94aebb https://github.com/WebKit/WebKit/commit/d61c828315d694a910352391aa51a1493b94aebb Author: Said Abou-Hallawa Date: 2024-05-22 (Wed, 22 May 2024) Changed paths: M LayoutTests/fast/images/decode-render-animated-image.html Log Message: --- ImageFailure sometimes happen with fast/images/decode-render-animated-image.html https://bugs.webkit.org/show_bug.cgi?id=271408 rdar://125573776 Unreviewed test gardening Change the test to draw the first frame but call decode() for the following frames. This will make decode() behave the same way for all frames. It will call startAnimation() and wait for imageFrameAtIndexAvailable() to be called. * LayoutTests/fast/images/decode-render-animated-image.html: Canonical link: https://commits.webkit.org/279153@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 1085de: [Site Isolation] Begin to fix the back forward lis...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 1085dea9ba4113642ffc393e3f9ac06a778ff26c https://github.com/WebKit/WebKit/commit/1085dea9ba4113642ffc393e3f9ac06a778ff26c Author: Charlie Wolfe Date: 2024-05-22 (Wed, 22 May 2024) Changed paths: M Source/WebCore/history/BackForwardClient.h M Source/WebCore/history/BackForwardController.cpp M Source/WebCore/history/BackForwardController.h M Source/WebCore/loader/EmptyClients.cpp M Source/WebCore/loader/HistoryController.cpp M Source/WebCore/page/Page.cpp M Source/WebCore/page/Page.h M Source/WebKit/Shared/WebBackForwardListItem.h M Source/WebKit/UIProcess/ProvisionalPageProxy.cpp M Source/WebKit/UIProcess/ProvisionalPageProxy.h M Source/WebKit/UIProcess/WebBackForwardList.cpp M Source/WebKit/UIProcess/WebFrameProxy.h M Source/WebKit/UIProcess/WebPageProxy.cpp M Source/WebKit/UIProcess/WebPageProxy.h M Source/WebKit/UIProcess/WebPageProxy.messages.in M Source/WebKit/WebProcess/WebPage/WebBackForwardListProxy.cpp M Source/WebKit/WebProcess/WebPage/WebBackForwardListProxy.h M Source/WebKit/WebProcess/WebPage/WebPage.cpp M Source/WebKitLegacy/mac/History/BackForwardList.h M Source/WebKitLegacy/mac/History/BackForwardList.mm M Source/WebKitLegacy/mac/History/WebBackForwardList.mm M Source/WebKitLegacy/mac/WebView/WebView.mm M Tools/TestWebKitAPI/Tests/WebKitCocoa/SiteIsolation.mm Log Message: --- [Site Isolation] Begin to fix the back forward list for same-origin iframe navigations https://bugs.webkit.org/show_bug.cgi?id=274419 rdar://128420789 Reviewed by Alex Christensen. Some back forward list state for child frames is currently stored only in the web process. This needs to change with site isolation because web processes can only have history items corresponding to frames they are hosting or have embedded. With this patch, whenever a root child frame is embedded, we add a separate item to the back forward list in the UI process. This way, when navigating back or forward, iframe processes can request history items containing state about same-origin frames that have been embedded by another process without receiving information about the entire frame tree. We also need to keep track of which back forward items correspond to initial root child frame loads. This is necessary to determine which item to navigate an isolated iframe to, while also ignoring these items when the main frame is moved back or forward. Further work is required to make the back forward list behave correctly after cross-origin iframe navigations. More details below. * Source/WebCore/history/BackForwardClient.h: * Source/WebCore/history/BackForwardController.cpp: (WebCore::BackForwardController::addItem): * Source/WebCore/history/BackForwardController.h: * Source/WebCore/loader/EmptyClients.cpp: * Source/WebCore/loader/HistoryController.cpp: (WebCore::HistoryController::goToItem): (WebCore::HistoryController::updateBackForwardListClippedAtTarget): (WebCore::HistoryController::pushState): * Source/WebCore/page/Page.cpp: (WebCore::Page::goToItem): * Source/WebCore/page/Page.h: Update `addItem` to include a FrameIdentifier parameter so the UI process knows which frame is being targeted. Also remove several unneeded local frame downcasts. * Source/WebKit/Shared/WebBackForwardListItem.h: (WebKit::WebBackForwardListItem::setIsRootChildFrameItem): (WebKit::WebBackForwardListItem::isRootChildFrameItem const): Add `m_isRootChildFrameItem` to indicate when a back forward item was created by an initial root child frame load. * Source/WebKit/UIProcess/ProvisionalPageProxy.cpp: (WebKit::ProvisionalPageProxy::backForwardAddItem): * Source/WebKit/UIProcess/ProvisionalPageProxy.h: * Source/WebKit/UIProcess/WebBackForwardList.cpp: (WebKit::itemSkippingBackForwardItemsAddedByJSWithoutUserGesture): Skip root child frame items to avoid targeting initial child frame loads when trying to move the main frame back/forward. This logic probably still isn’t correct when going back/forward between cross-origin iframes. * Source/WebKit/UIProcess/WebFrameProxy.h: (WebKit::WebFrameProxy::setHasPendingBackForwardItem): (WebKit::WebFrameProxy::takeHasPendingBackforwardItem): Add `m_hasPendingBackForwardItem` to indicate when a root frame is waiting for its initial back forward item to be created. * Source/WebKit/UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::goToBackForwardItem): Change this function to send back forward list items corresponding to isolated iframes to the process that navigated. `m_lastProcessIdentifier` on `WebBackForwardListItem` is already used for process selection for PSON. It will initially be the identifier of the web process that constructed the object, so we can use it for iframe isolation too. (WebKit::WebPageProxy::didChangeBackForwardList): Do not call `didChangeBackForwardList` delegates or
[webkit-changes] [WebKit/WebKit] ca45ce: Unreviewed, stale PR gets uploaded
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: ca45ce0afc7301452f0d2f38cc6d33bafaed1b0e https://github.com/WebKit/WebKit/commit/ca45ce0afc7301452f0d2f38cc6d33bafaed1b0e Author: Yusuke Suzuki Date: 2024-05-22 (Wed, 22 May 2024) Changed paths: M Source/JavaScriptCore/runtime/JSGlobalObject.cpp Log Message: --- Unreviewed, stale PR gets uploaded https://bugs.webkit.org/show_bug.cgi?id=274548 rdar://128562540 * Source/JavaScriptCore/runtime/JSGlobalObject.cpp: (JSC::JSGlobalObject::init): Canonical link: https://commits.webkit.org/279151@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 708db4: textarea's width calculations aren't fully writing...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 708db469479bb6c79a55f65532177b6964dd49b0 https://github.com/WebKit/WebKit/commit/708db469479bb6c79a55f65532177b6964dd49b0 Author: Luke Warlow Date: 2024-05-22 (Wed, 22 May 2024) Changed paths: M LayoutTests/TestExpectations M LayoutTests/imported/w3c/web-platform-tests/html/rendering/widgets/textarea-scrollbar-sizing-002-expected.txt M Source/WebCore/rendering/RenderTextControlMultiLine.cpp Log Message: --- textarea's width calculations aren't fully writing mode aware https://bugs.webkit.org/show_bug.cgi?id=274332 Reviewed by Aditya Keerthi. Updates the width cacluations to take into account writing mode when decided whether to add scrollbar thickness. * LayoutTests/TestExpectations: * LayoutTests/imported/w3c/web-platform-tests/html/rendering/widgets/textarea-scrollbar-sizing-002-expected.txt: * Source/WebCore/rendering/RenderTextControlMultiLine.cpp: (WebCore::RenderTextControlMultiLine::preferredContentLogicalWidth const): Canonical link: https://commits.webkit.org/279150@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] c471e6: [Navigation] Implement cross-document navigate events
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: c471e606082fe814511934ed3dacaf7f76cdb31e https://github.com/WebKit/WebKit/commit/c471e606082fe814511934ed3dacaf7f76cdb31e Author: Patrick Griffis Date: 2024-05-22 (Wed, 22 May 2024) Changed paths: M LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigate-event/cross-window/click-crossdocument-sameorigin-expected.txt M LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigate-event/cross-window/location-crossdocument-sameorigin-expected.txt M LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigate-event/cross-window/open-crossdocument-sameorigin-expected.txt M LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigate-event/cross-window/submit-crossdocument-crossorigin-sameorigindomain.sub-expected.txt M LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigate-event/cross-window/submit-crossdocument-sameorigin-expected.txt M LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigate-event/intercept-cross-document-same-origin-expected.txt M LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigate-event/intercept-cross-origin-expected.txt M LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigate-event/intercept-detach-expected.txt M LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigate-event/intercept-detach-multiple-expected.txt M LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigate-event/navigate-anchor-cross-origin-expected.txt M LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigate-event/navigate-anchor-download-expected.txt M LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigate-event/navigate-anchor-download-userInitiated-expected.txt M LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigate-event/navigate-anchor-same-origin-cross-document-expected.txt M LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigate-event/navigate-anchor-with-target-expected.txt M LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigate-event/navigate-destination-getState-reload-expected.txt M LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigate-event/navigate-form-get-expected.txt M LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigate-event/navigate-history-go-0-expected.txt M LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigate-event/navigate-meta-refresh-expected.txt M LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigate-event/navigate-to-srcdoc-expected.txt M LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigation-methods/return-value/reload-rejection-order-pagehide-unserializablestate-expected.txt M LayoutTests/imported/w3c/web-platform-tests/navigation-api/ordering-and-transition/transition-finished-mark-as-handled-expected.txt M LayoutTests/platform/glib/imported/w3c/web-platform-tests/navigation-api/navigate-event/cross-window/click-crossdocument-crossorigin-sameorigindomain.sub-expected.txt M LayoutTests/platform/glib/imported/w3c/web-platform-tests/navigation-api/navigate-event/cross-window/location-crossdocument-crossorigin-sameorigindomain.sub-expected.txt M LayoutTests/platform/glib/imported/w3c/web-platform-tests/navigation-api/navigate-event/cross-window/open-crossdocument-crossorigin-sameorigindomain.sub-expected.txt A LayoutTests/platform/glib/imported/w3c/web-platform-tests/navigation-api/navigation-history-entry/current-basic-expected.txt M Source/WTF/wtf/URL.cpp M Source/WTF/wtf/URL.h M Source/WebCore/loader/FrameLoader.cpp M Source/WebCore/loader/FrameLoader.h Log Message: --- [Navigation] Implement cross-document navigate events https://bugs.webkit.org/show_bug.cgi?id=274426 Reviewed by Alex Christensen. This emits the NavigateEvent for cross-document navigations when the navigation is same-origin-domain. * LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigate-event/cross-window/click-crossdocument-sameorigin-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigate-event/cross-window/location-crossdocument-sameorigin-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigate-event/cross-window/open-crossdocument-sameorigin-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigate-event/cross-window/submit-crossdocument-crossorigin-sameorigindomain.sub-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigate-event/cross-window/submit-crossdocument-sameorigin-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigate-event/intercept-cross-document-same-origin-expected.txt: *
[webkit-changes] [WebKit/WebKit] 9c2a2b: [Unified Text Replacement] When receiving text wit...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 9c2a2b42f8fab8d7d5a776f5e2342772fa2ef6c7 https://github.com/WebKit/WebKit/commit/9c2a2b42f8fab8d7d5a776f5e2342772fa2ef6c7 Author: Richard Robinson Date: 2024-05-22 (Wed, 22 May 2024) Changed paths: M Source/WebKit/WebProcess/WebPage/Cocoa/UnifiedTextReplacementController.mm M Source/WebKit/WebProcess/WebPage/Cocoa/WebPageCocoa.mm Log Message: --- [Unified Text Replacement] When receiving text with a replacement range, a trailing newline can sometimes go missing https://bugs.webkit.org/show_bug.cgi?id=274504 rdar://128084320 Reviewed by Ryosuke Niwa. When creating the context, omit any trailing newlines in the first place, since they will not be actually used, and newlines behave semi-erratically anyways. * Source/WebKit/WebProcess/WebPage/Cocoa/UnifiedTextReplacementController.mm: (WebKit::UnifiedTextReplacementController::textReplacementSessionDidReceiveTextWithReplacementRange): * Source/WebKit/WebProcess/WebPage/Cocoa/WebPageCocoa.mm: (WebKit::WebPage::autocorrectionContextRange): Canonical link: https://commits.webkit.org/279148@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] ab5b67: Change my status in contributors.json
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: ab5b6787c95f685280c1d539952f556cd7b4cdc0 https://github.com/WebKit/WebKit/commit/ab5b6787c95f685280c1d539952f556cd7b4cdc0 Author: Yijia Huang Date: 2024-05-22 (Wed, 22 May 2024) Changed paths: M metadata/contributors.json Log Message: --- Change my status in contributors.json Unreviewed. * metadata/contributors.json: Canonical link: https://commits.webkit.org/279147@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] fb4278: [WebXR] Service video frame callbacks in WebXRSess...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: fb427896ee568c0bc173d1611575da7d8b26be49 https://github.com/WebKit/WebKit/commit/fb427896ee568c0bc173d1611575da7d8b26be49 Author: Ada Chan Date: 2024-05-22 (Wed, 22 May 2024) Changed paths: M Source/WebCore/Modules/webxr/WebXRSession.cpp M Source/WebCore/Modules/webxr/WebXRSession.h M Source/WebCore/Modules/webxr/WebXRSystem.cpp M Source/WebCore/Modules/webxr/WebXRSystem.h M Source/WebCore/page/Page.cpp M Source/WebCore/page/Page.h M Source/WebKit/WebProcess/WebPage/WebPage.cpp Log Message: --- [WebXR] Service video frame callbacks in WebXRSession if page backgrounds during immersive WebXR session https://bugs.webkit.org/show_bug.cgi?id=273901 rdar://124236441 Reviewed by Simon Fraser and Jer Noble. Instead of not freezing the layer tree if the page gets backgrounded during an immersive WebXR session so video frame callbacks can continue to be serviced, just service the video frame callbacks in the XR session. * Source/WebCore/Modules/webxr/WebXRSession.cpp: (WebCore::WebXRSession::minimalUpdateRendering): We'll special case servicing the video frame callbacks as the minimum render updates we'll do in XR session's rAF if the page is backgrounded. (WebCore::WebXRSession::onFrame): * Source/WebCore/Modules/webxr/WebXRSession.h: * Source/WebCore/Modules/webxr/WebXRSystem.cpp: (WebCore::WebXRSystem::activeImmersiveSession const): (WebCore::WebXRSystem::hasActiveImmersiveSession const): Deleted. * Source/WebCore/Modules/webxr/WebXRSystem.h: * Source/WebCore/page/Page.cpp: (WebCore::Page::applicationDidEnterBackground): (WebCore::Page::applicationWillEnterForeground): (WebCore::Page::hasActiveImmersiveSession const): (WebCore::Page::activeImmersiveXRSession const): (WebCore::Page::shouldBlockLayerTreeFreezingForVideo): Deleted. * Source/WebCore/page/Page.h: * Source/WebKit/WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::updateDrawingAreaLayerTreeFreezeState): Remove the logic to prevent the freezing of the layer tree if the page is backgrounded due to an active immersive session. It's not good for performance to continue render updates for the page when it's backgrounded and not visible. Canonical link: https://commits.webkit.org/279146@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 538cc4: [build.webkit.org] Do not try to download build pr...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 538cc4d94b8a51496c3f982522eb0e50cb6aa732 https://github.com/WebKit/WebKit/commit/538cc4d94b8a51496c3f982522eb0e50cb6aa732 Author: Aakash Jain Date: 2024-05-22 (Wed, 22 May 2024) Changed paths: M Tools/CISupport/build-webkit-org/steps.py Log Message: --- [build.webkit.org] Do not try to download build product from master https://bugs.webkit.org/show_bug.cgi?id=274538 Reviewed by Ryan Haddad. We stopped uploading archives to build master in 276...@main.so, while downloading archives, when download from s3 fails, there is no point in trying to fallback to download from build master. We should make it a hard failure when download from s3 fails. This is similar to 276539@main for ews. * Tools/CISupport/build-webkit-org/steps.py: (DownloadBuiltProduct): Canonical link: https://commits.webkit.org/279145@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] e058a9: Web Inspector: CSS source editor can adopt fuzzy s...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: e058a9c99c8c35dac22dc6095343a4895a6fb168 https://github.com/WebKit/WebKit/commit/e058a9c99c8c35dac22dc6095343a4895a6fb168 Author: Qianlang Chen Date: 2024-05-22 (Wed, 22 May 2024) Changed paths: M Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js M Source/WebInspectorUI/UserInterface/Base/Setting.js M Source/WebInspectorUI/UserInterface/Controllers/CodeMirrorCompletionController.js M Source/WebInspectorUI/UserInterface/Main.html M Source/WebInspectorUI/UserInterface/Models/CSSCompletions.js A Source/WebInspectorUI/UserInterface/Models/Completions.js M Source/WebInspectorUI/UserInterface/Test.html M Source/WebInspectorUI/UserInterface/Views/SettingsTabContentView.js Log Message: --- Web Inspector: CSS source editor can adopt fuzzy search for code completion rdar://125030691 https://bugs.webkit.org/show_bug.cgi?id=271260 Reviewed by Devin Rousso. Use CSSCompletions.executeQuery instead of CSSCompletions.startsWith when language mode is CSS, since executeQuery uses fuzzy search. Also add an setting item in the Settings tab's Experimental sub-tab to optionally turn this feature off. * Source/WebInspectorUI/UserInterface/Controllers/CodeMirrorCompletionController.js: (WI.CodeMirrorCompletionController.prototype._generateCSSCompletions): - Optionally apply fuzzy search by using `executeQuery`. (WI.CodeMirrorCompletionController.prototype.updateCompletions): - The argument `completions` could now also be an array of objects instead of always an array of strings (due to executeQuery returning an array of objects). Those objects also contain info on which characters match in the fuzzy search, so the suggestion box can bold the matching text. `this._completions` however does not need this extra info, so we extract only the texts from `completions` for that. (WI.CodeMirrorCompletionController.prototype._applyCompletionHint): (WI.CodeMirrorCompletionController.prototype._applyCompletionHint.update): - Fuzzy search can now match completions not necessarily starting with the same text as currentText. Only show the gray watermark text (hint marker in code) when it's actually a prefix match. * Source/WebInspectorUI/UserInterface/Models/Completions.js: Added. * Source/WebInspectorUI/UserInterface/Models/CSSCompletions.js: (WI.CSSCompletions.getCompletionText): - As the getCompletionText helper function doesn't have to work for only CSS suggestions, it better belongs to a class with a more generic name like Completion instead of CSSCompletion. - Leave a note to eventually migrate all other usages of the old CSSCompletion.getCompletionText to Completion.getCompletionText. * Source/WebInspectorUI/UserInterface/Main.html: * Source/WebInspectorUI/UserInterface/Test.html: - Include the new Completions.js source file. * Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js: * Source/WebInspectorUI/UserInterface/Base/Setting.js: * Source/WebInspectorUI/UserInterface/Views/SettingsTabContentView.js: - Add an experimental setting item for this feature change. Canonical link: https://commits.webkit.org/279144@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] ac7aec: Videos in in-window mode should have their WebKitP...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: ac7aecf284923b3ad201b085a68b66a1d614b285 https://github.com/WebKit/WebKit/commit/ac7aecf284923b3ad201b085a68b66a1d614b285 Author: Dana Estra Date: 2024-05-22 (Wed, 22 May 2024) Changed paths: M Source/WebCore/Modules/mediacontrols/MediaControlsHost.cpp M Source/WebCore/Modules/mediacontrols/MediaControlsHost.h M Source/WebCore/Modules/mediacontrols/MediaControlsHost.idl M Source/WebCore/Modules/modern-media-controls/media/media-controller.js M Source/WebCore/html/HTMLVideoElement.cpp M Source/WebCore/html/HTMLVideoElement.h M Source/WebCore/html/HTMLVideoElement.idl Log Message: --- Videos in in-window mode should have their WebKitPresentationMode property set to inline https://bugs.webkit.org/show_bug.cgi?id=274477 rdar://128482499 Reviewed by Jer Noble. This fix adds a method HTMLVideoElement::webkitPresentationModeForBindings(). The default media controls now consult MediaControlsHost::inWindowFullscreen() to determine that a video is in in-window mode. * Source/WebCore/Modules/mediacontrols/MediaControlsHost.cpp: (WebCore::MediaControlsHost::inWindowFullscreen const): * Source/WebCore/Modules/mediacontrols/MediaControlsHost.h: * Source/WebCore/Modules/mediacontrols/MediaControlsHost.idl: * Source/WebCore/Modules/modern-media-controls/media/media-controller.js: (MediaController.prototype.get isFullscreen): (MediaController.prototype._updateControlsIfNeeded): * Source/WebCore/html/HTMLVideoElement.cpp: (WebCore::HTMLVideoElement::webkitPresentationModeForBindings const): * Source/WebCore/html/HTMLVideoElement.h: * Source/WebCore/html/HTMLVideoElement.idl: Canonical link: https://commits.webkit.org/279143@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] c29a71: Add myself (Darryl Pogue) to contributors.json
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: c29a713c5f577bbbae708cb993ccdadb5045d83f https://github.com/WebKit/WebKit/commit/c29a713c5f577bbbae708cb993ccdadb5045d83f Author: Darryl Pogue Date: 2024-05-22 (Wed, 22 May 2024) Changed paths: M metadata/contributors.json Log Message: --- Add myself (Darryl Pogue) to contributors.json https://bugs.webkit.org/show_bug.cgi?id=274541 Reviewed by Jonathan Bedard. * metadata/contributors.json: Canonical link: https://commits.webkit.org/279142@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 8cb609: [WGSL] Fix failing wgslc tests
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 8cb609477c197cfc25fd66fab6f51b7017c7e8dd https://github.com/WebKit/WebKit/commit/8cb609477c197cfc25fd66fab6f51b7017c7e8dd Author: Tadeu Zagallo Date: 2024-05-22 (Wed, 22 May 2024) Changed paths: M Source/WebGPU/WGSL/AST/ASTForward.h M Source/WebGPU/WGSL/AST/ASTParameter.h M Source/WebGPU/WGSL/AST/ASTVariable.h M Source/WebGPU/WGSL/GlobalVariableRewriter.cpp M Source/WebGPU/WGSL/Metal/MetalFunctionWriter.cpp M Source/WebGPU/WGSL/WGSLShaderModule.h M Source/WebGPU/WGSL/tests/valid/packing.wgsl Log Message: --- [WGSL] Fix failing wgslc tests https://bugs.webkit.org/show_bug.cgi?id=274479 rdar://128485179 Reviewed by Mike Wyrzykowski. There were 2 issues after 278991@main: - we emitted definitions for `__unpack(PackedVec3)` even when we didn't emit the PackedVec3 struct - in a previous patch we tried skipping some explicit pack/unpack calls for vec3/packed_vec3, but that doesn't work for PackedVec3, so we can no longer skip these calls. * Source/WebGPU/WGSL/AST/ASTForward.h: * Source/WebGPU/WGSL/AST/ASTParameter.h: * Source/WebGPU/WGSL/AST/ASTVariable.h: * Source/WebGPU/WGSL/GlobalVariableRewriter.cpp: (WGSL::RewriteGlobalVariables::visitCallee): (WGSL::RewriteGlobalVariables::visit): (WGSL::RewriteGlobalVariables::pack): (WGSL::RewriteGlobalVariables::packStructResource): (WGSL::RewriteGlobalVariables::packArrayResource): (WGSL::RewriteGlobalVariables::insertMaterializations): * Source/WebGPU/WGSL/Metal/MetalFunctionWriter.cpp: (WGSL::Metal::FunctionDefinitionWriter::emitNecessaryHelpers): (WGSL::Metal::FunctionDefinitionWriter::visit): (WGSL::Metal::FunctionDefinitionWriter::shouldPackType const): (WGSL::Metal::FunctionDefinitionWriter::emitPackedVector): (WGSL::Metal::FunctionDefinitionWriter::serializeVariable): * Source/WebGPU/WGSL/WGSLShaderModule.h: (WGSL::ShaderModule::usesPackVector const): (WGSL::ShaderModule::setUsesPackVector): (WGSL::ShaderModule::clearUsesPackVector): (WGSL::ShaderModule::usesUnpackVector const): (WGSL::ShaderModule::setUsesUnpackVector): (WGSL::ShaderModule::clearUsesUnpackVector): * Source/WebGPU/WGSL/tests/valid/packing.wgsl: Canonical link: https://commits.webkit.org/279141@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 625de0: Disable thread-safety-reference-return warnings in...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 625de0728603e766a988d7a6ea9f712806162a3f https://github.com/WebKit/WebKit/commit/625de0728603e766a988d7a6ea9f712806162a3f Author: Youenn Fablet Date: 2024-05-22 (Wed, 22 May 2024) Changed paths: M Source/ThirdParty/libwebrtc/Configurations/Base.xcconfig Log Message: --- Disable thread-safety-reference-return warnings in libwebrtc rdar://126802873 https://bugs.webkit.org/show_bug.cgi?id=274508 Reviewed by David Kilzer. We disable thread-safety-reference-return as libwebrtc is not yet ready for this. A few places would need additional annotations, and some other places are checking that the method is called in the right thread, not that a mutex is held. * Source/ThirdParty/libwebrtc/Configurations/Base.xcconfig: Canonical link: https://commits.webkit.org/279140@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] f05e0d: Unreviewed, reverting 279084@main (69a3317d5271)
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: f05e0d98cff6255208eaa6d018199b13814a8389 https://github.com/WebKit/WebKit/commit/f05e0d98cff6255208eaa6d018199b13814a8389 Author: Mike Wyrzykowski Date: 2024-05-22 (Wed, 22 May 2024) Changed paths: M Source/WebGPU/WebGPU/Queue.mm Log Message: --- Unreviewed, reverting 279084@main (69a3317d5271) https://bugs.webkit.org/show_bug.cgi?id=274537 279084@main caused a regression in duplicate command buffer submission Reverted change: [WebGPU] Invalidate all command buffers on submit, regardless of it the submit call succeeds https://bugs.webkit.org/show_bug.cgi?id=274244 rdar://128177642 279084@main (69a3317d5271) Canonical link: https://commits.webkit.org/279139@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 513f6e: Update base64EncodeToString() / base64URLEncodeToS...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 513f6e7095e6a8730bfd06084c8b3e68a974e856 https://github.com/WebKit/WebKit/commit/513f6e7095e6a8730bfd06084c8b3e68a974e856 Author: Chris Dumez Date: 2024-05-22 (Wed, 22 May 2024) Changed paths: M Source/WTF/wtf/text/Base64.h M Source/WebCore/Modules/identity/DigitalCredential.cpp M Source/WebCore/Modules/webauthn/PublicKeyCredential.cpp M Source/WebCore/Modules/webauthn/WebAuthenticationUtils.cpp M Source/WebCore/Modules/websockets/WebSocketHandshake.cpp M Source/WebCore/crypto/cocoa/CryptoKeyECMac.cpp M Source/WebCore/crypto/gcrypt/CryptoKeyECGCrypt.cpp M Source/WebCore/inspector/DOMPatchSupport.cpp M Source/WebCore/inspector/agents/InspectorNetworkAgent.cpp M Source/WebCore/inspector/agents/InspectorPageAgent.cpp M Source/WebCore/loader/cocoa/PrivateClickMeasurementCocoa.mm M Source/WebCore/page/Base64Utilities.cpp M Source/WebCore/platform/encryptedmedia/clearkey/CDMClearKey.cpp M Source/WebCore/platform/graphics/win/FontCustomPlatformDataWin.cpp M Source/WebCore/platform/network/soup/SoupNetworkSession.cpp M Source/WebCore/rendering/adwaita/RenderThemeAdwaita.cpp M Source/WebCore/storage/StorageUtilities.cpp M Source/WebCore/workers/service/server/SWScriptStorage.cpp M Source/WebKit/NetworkProcess/PrivateClickMeasurement/PrivateClickMeasurementManager.cpp M Source/WebKit/NetworkProcess/storage/NetworkStorageManager.cpp M Source/WebKit/UIProcess/Automation/cairo/WebAutomationSessionCairo.cpp M Source/WebKit/UIProcess/Automation/gtk/WebAutomationSessionGtk.cpp M Source/WebKit/UIProcess/WebAuthentication/Cocoa/LocalAuthenticator.mm M Source/WebKit/UIProcess/WebAuthentication/Mock/MockLocalConnection.mm M Tools/TestWebKitAPI/Tests/WebCore/cocoa/PrivateClickMeasurementCocoa.mm M Tools/TestWebKitAPI/Tests/WebKitCocoa/EventAttribution.mm M Tools/TestWebKitAPI/cocoa/HTTPServer.mm Log Message: --- Update base64EncodeToString() / base64URLEncodeToString() overloads https://bugs.webkit.org/show_bug.cgi?id=274503 Reviewed by Sihui Liu and Darin Adler. Update base64EncodeToString() / base64URLEncodeToString() overloads to force the call sites to provide either a `std::span` or a `std::span`. This is a step towards our broader std::span adoption and using more consistent typing to represent bytes. * Source/WTF/wtf/text/Base64.h: * Source/WebCore/Modules/identity/DigitalCredential.cpp: (WebCore::DigitalCredential::DigitalCredential): * Source/WebCore/Modules/webauthn/PublicKeyCredential.cpp: (WebCore::PublicKeyCredential::PublicKeyCredential): * Source/WebCore/Modules/webauthn/WebAuthenticationUtils.cpp: (WebCore::buildClientDataJson): * Source/WebCore/Modules/websockets/WebSocketHandshake.cpp: (WebCore::WebSocketHandshake::getExpectedWebSocketAccept): * Source/WebCore/crypto/cocoa/CryptoKeyECMac.cpp: (WebCore::CryptoKeyEC::platformAddFieldElements const): * Source/WebCore/crypto/gcrypt/CryptoKeyECGCrypt.cpp: (WebCore::CryptoKeyEC::platformAddFieldElements const): * Source/WebCore/inspector/DOMPatchSupport.cpp: (WebCore::DOMPatchSupport::createDigest): * Source/WebCore/inspector/agents/InspectorNetworkAgent.cpp: (WebCore::InspectorNetworkAgent::getSerializedCertificate): * Source/WebCore/inspector/agents/InspectorPageAgent.cpp: (WebCore::InspectorPageAgent::archive): * Source/WebCore/loader/cocoa/PrivateClickMeasurementCocoa.mm: (WebCore::PrivateClickMeasurement::calculateAndUpdateUnlinkableToken): (WebCore::PrivateClickMeasurement::calculateAndUpdateSecretToken): * Source/WebCore/page/Base64Utilities.cpp: (WebCore::Base64Utilities::btoa): * Source/WebCore/platform/encryptedmedia/clearkey/CDMClearKey.cpp: (WebCore::extractKeyidsFromCencInitData): (WebCore::CDMInstanceSessionClearKey::removeSessionData): * Source/WebCore/platform/graphics/win/FontCustomPlatformDataWin.cpp: (WebCore::createUniqueFontName): * Source/WebCore/platform/network/soup/SoupNetworkSession.cpp: (WebCore::HostTLSCertificateSet::computeCertificateHash): * Source/WebCore/rendering/adwaita/RenderThemeAdwaita.cpp: (WebCore::RenderThemeAdwaita::mediaControlsBase64StringForIconNameAndType): * Source/WebCore/storage/StorageUtilities.cpp: (WebCore::StorageUtilities::encodeSecurityOriginForFileName): * Source/WebCore/workers/service/server/SWScriptStorage.cpp: (WebCore::SWScriptStorage::sha2Hash const): * Source/WebKit/NetworkProcess/PrivateClickMeasurement/PrivateClickMeasurementManager.cpp: (WebKit::PrivateClickMeasurementManager::fireConversionRequest): * Source/WebKit/NetworkProcess/storage/NetworkStorageManager.cpp: (WebKit::encode): * Source/WebKit/UIProcess/Automation/cairo/WebAutomationSessionCairo.cpp: (WebKit::base64EncodedPNGData): * Source/WebKit/UIProcess/Automation/gtk/WebAutomationSessionGtk.cpp: (WebKit::base64EncodedPNGData): * Source/WebKit/UIProcess/WebAuthentication/Cocoa/LocalAuthenticator.mm:
[webkit-changes] [WebKit/WebKit] 2a8d5d: Fix sysctl read sandbox violation in the GPU process
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 2a8d5d0ba6a64bf7e655deb0152cae1e9c3c8c6a https://github.com/WebKit/WebKit/commit/2a8d5d0ba6a64bf7e655deb0152cae1e9c3c8c6a Author: Per Arne Vollan Date: 2024-05-22 (Wed, 22 May 2024) Changed paths: M Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.GPU.sb.in Log Message: --- Fix sysctl read sandbox violation in the GPU process https://bugs.webkit.org/show_bug.cgi?id=274528 rdar://122952474 Reviewed by Chris Dumez. Fix sysctl read sandbox violation in the GPU process on iOS by allowing reading a sysctl name which has been confirmed to be in use. * Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.GPU.sb.in: Canonical link: https://commits.webkit.org/279137@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 57affb: [JSC] Handler IC Getter / Setter / Proxy accessors...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 57affb62969db66ef07975567f4876d62d86da55 https://github.com/WebKit/WebKit/commit/57affb62969db66ef07975567f4876d62d86da55 Author: Yusuke Suzuki Date: 2024-05-22 (Wed, 22 May 2024) Changed paths: M LayoutTests/platform/mac/TestExpectations M Source/JavaScriptCore/bytecode/InlineCacheCompiler.cpp M Source/JavaScriptCore/dfg/DFGJITCode.cpp M Source/JavaScriptCore/llint/LLIntData.cpp M Source/JavaScriptCore/runtime/JSGlobalObject.cpp M Source/JavaScriptCore/runtime/JSGlobalObject.h M Source/JavaScriptCore/runtime/JSGlobalObjectInlines.h M Source/JavaScriptCore/runtime/StructureInlines.h Log Message: --- [JSC] Handler IC Getter / Setter / Proxy accessors should not use m_globalObject https://bugs.webkit.org/show_bug.cgi?id=274485 rdar://128494111 Reviewed by Mark Lam. Since Handler IC can be shared across JSGlobalObjects, the generated code should not rely on that. This patch fixes so that all access are done through JSGlobalObject offered at runtime. We made all necessary fields of JSGlobalObject from JIT. * Source/JavaScriptCore/bytecode/InlineCacheCompiler.cpp: (JSC::InlineCacheCompiler::generateWithGuard): (JSC::InlineCacheCompiler::generateImpl): (JSC::InlineCacheCompiler::emitProxyObjectAccess): * Source/JavaScriptCore/runtime/JSGlobalObject.cpp: (JSC::JSGlobalObject::init): (JSC::JSGlobalObject::visitChildrenImpl): * Source/JavaScriptCore/runtime/JSGlobalObject.h: (JSC::JSGlobalObject::symbolPrototype const): (JSC::JSGlobalObject::dateStructure const): (JSC::JSGlobalObject::symbolObjectStructure const): (JSC::JSGlobalObject::offsetOfPerformProxyObjectHasFunction): (JSC::JSGlobalObject::offsetOfPerformProxyObjectGetFunction): (JSC::JSGlobalObject::offsetOfPerformProxyObjectGetByValFunction): (JSC::JSGlobalObject::offsetOfPerformProxyObjectSetStrictFunction): (JSC::JSGlobalObject::offsetOfPerformProxyObjectSetSloppyFunction): (JSC::JSGlobalObject::offsetOfNullSetterStrictFunction): (JSC::JSGlobalObject::offsetOfStringPrototype): (JSC::JSGlobalObject::offsetOfBigIntPrototype): (JSC::JSGlobalObject::offsetOfSymbolPrototype): * Source/JavaScriptCore/runtime/JSGlobalObjectInlines.h: (JSC::JSGlobalObject::performProxyObjectHasFunction const): (JSC::JSGlobalObject::performProxyObjectGetFunction const): (JSC::JSGlobalObject::performProxyObjectGetFunctionConcurrently const): (JSC::JSGlobalObject::performProxyObjectGetByValFunction const): (JSC::JSGlobalObject::performProxyObjectGetByValFunctionConcurrently const): (JSC::JSGlobalObject::performProxyObjectSetSloppyFunction const): (JSC::JSGlobalObject::performProxyObjectSetSloppyFunctionConcurrently const): (JSC::JSGlobalObject::performProxyObjectSetStrictFunction const): (JSC::JSGlobalObject::performProxyObjectSetStrictFunctionConcurrently const): * Source/JavaScriptCore/runtime/StructureInlines.h: Canonical link: https://commits.webkit.org/279136@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 19697c: [UnifiedPDF] Add the concept of "rows" to PDFDocum...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 19697c5f3ef870f6c4ab84937a06156ee11d0a53 https://github.com/WebKit/WebKit/commit/19697c5f3ef870f6c4ab84937a06156ee11d0a53 Author: Simon Fraser Date: 2024-05-22 (Wed, 22 May 2024) Changed paths: M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/PDFDocumentLayout.h M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/PDFDocumentLayout.mm M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.h M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm Log Message: --- [UnifiedPDF] Add the concept of "rows" to PDFDocumentLayout https://bugs.webkit.org/show_bug.cgi?id=274496 rdar://128504528 Reviewed by Abrar Rahman Protyasha. Discrete (non-scrolling) mode makes heavy use of the "row" concept, where a row is a set of one or two pages viewed together. So introduce PDFLayoutRow, and pass an optional row argument to nearestPageIndexForDocumentPoint(). Other namespace-related cleanup and utility additions for rows. * Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/PDFDocumentLayout.h: (WebKit::PDFDocumentLayout::isSinglePageDisplayMode): (WebKit::PDFDocumentLayout::isTwoUpDisplayMode): (WebKit::PDFDocumentLayout::isScrollingDisplayMode): (WebKit::PDFDocumentLayout::isDiscreteDisplayMode): (WebKit::PDFDocumentLayout::isSinglePageDisplayMode const): (WebKit::PDFDocumentLayout::isTwoUpDisplayMode const): (WebKit::PDFDocumentLayout::isScrollingDisplayMode const): (WebKit::PDFDocumentLayout::isDiscreteDisplayMode const): (WebKit::PDFLayoutRow::numPages const): (WebKit::PDFLayoutRow::containsPage const): * Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/PDFDocumentLayout.mm: (WebKit::PDFDocumentLayout::isRightPageIndex const): (WebKit::PDFDocumentLayout::isLastPageIndex const): (WebKit::PDFDocumentLayout::lastPageIndex const): (WebKit::PDFDocumentLayout::isFirstPageOfRow const): (WebKit::PDFDocumentLayout::indexForPage const): (WebKit::PDFDocumentLayout::nearestPageIndexForDocumentPoint const): (WebKit::PDFDocumentLayout::pageIndexAndPagePointForDocumentYOffset const): (WebKit::PDFDocumentLayout::updateLayout): (WebKit::PDFDocumentLayout::rowCount const): (WebKit::PDFDocumentLayout::rows const): (WebKit::PDFDocumentLayout::rowForPageIndex const): (WebKit::PDFDocumentLayout::rowIndexForPageIndex const): (WebKit::PDFDocumentLayout::layoutBoundsForRow const): * Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.h: * Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm: (WebKit::UnifiedPDFPlugin::visibleRow const): (WebKit::UnifiedPDFPlugin::shouldDisplayPage): (WebKit::UnifiedPDFPlugin::indexForCurrentPageInView const): (WebKit::UnifiedPDFPlugin::handleMouseEvent): (WebKit::UnifiedPDFPlugin::createContextMenu const): (WebKit::UnifiedPDFPlugin::continueAutoscroll): Canonical link: https://commits.webkit.org/279135@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 76a6ff: nonce hiding in SVG is buggy
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 76a6ff4a88da11885fb1c5b8af8b41bf0a7844b5 https://github.com/WebKit/WebKit/commit/76a6ff4a88da11885fb1c5b8af8b41bf0a7844b5 Author: Ryosuke Niwa Date: 2024-05-22 (Wed, 22 May 2024) Changed paths: A LayoutTests/http/tests/security/contentSecurityPolicy/nonce-hiding-on-svg-script-expected.txt A LayoutTests/http/tests/security/contentSecurityPolicy/nonce-hiding-on-svg-script.py M Source/WebCore/dom/ScriptElement.cpp M Source/WebCore/svg/SVGElement.cpp Log Message: --- nonce hiding in SVG is buggy https://bugs.webkit.org/show_bug.cgi?id=268598 rdar://122151552 Reviewed by Chris Dumez. The bug was caused by SVGElement::insertedIntoAncestor hiding nonce after it had an early exit for returning InsertedIntoAncestorResult::NeedsPostInsertionCallback. Fixed the bug by hiding it before this early exit. * LayoutTests/http/tests/security/contentSecurityPolicy/nonce-hiding-on-svg-script-expected.txt: Added. * LayoutTests/http/tests/security/contentSecurityPolicy/nonce-hiding-on-svg-script.py: Added. * Source/WebCore/dom/ScriptElement.cpp: (WebCore::ScriptElement::didFinishInsertingNode): * Source/WebCore/svg/SVGElement.cpp: (WebCore::SVGElement::insertedIntoAncestor): Originally-landed-as: 272448.567@safari-7618-branch (d915a3b6357c). rdar://128504044 Canonical link: https://commits.webkit.org/279131@main Commit: 9e5283739c9809f145488a20f8a52f09fd3a85f4 https://github.com/WebKit/WebKit/commit/9e5283739c9809f145488a20f8a52f09fd3a85f4 Author: Chris Dumez Date: 2024-05-22 (Wed, 22 May 2024) Changed paths: M Source/WebCore/workers/WorkerOrWorkletThread.cpp Log Message: --- Flaky crash under WorkerDedicatedRunLoop::runCleanupTasks() during fuzzing https://bugs.webkit.org/show_bug.cgi?id=269731 rdar://121961101 Reviewed by Brent Fulgham. I haven't been able to reproduce but based on the ASAN report, it looks like the WorkerOrWorkletGlobalScope is getting destroyed in the middle of WorkerDedicatedRunLoop::runCleanupTasks(), causing a use-after free of the context. To make sure this can't happen, apply our smart pointer adoption rules and make sure the WorkerOrWorkletGlobalScope is being protected on the stack at the call site of WorkerDedicatedRunLoop::run() before passing it in argument. * Source/WebCore/workers/WorkerOrWorkletThread.cpp: (WebCore::WorkerOrWorkletThread::runEventLoop): Originally-landed-as: 272448.578@safari-7618-branch (459d377c63c2). rdar://128504577 Canonical link: https://commits.webkit.org/279132@main Commit: 5944980db644fb2ea879bf3e2d6e5efd47156cdc https://github.com/WebKit/WebKit/commit/5944980db644fb2ea879bf3e2d6e5efd47156cdc Author: Wenson Hsieh Date: 2024-05-22 (Wed, 22 May 2024) Changed paths: M Source/WebCore/loader/EmptyClients.cpp M Source/WebCore/page/EditorClient.h M Source/WebCore/page/LocalFrame.cpp M Source/WebKit/UIProcess/WebPageProxy.cpp M Source/WebKit/UIProcess/WebPageProxy.h M Source/WebKit/UIProcess/WebPageProxy.messages.in M Source/WebKit/WebProcess/WebCoreSupport/WebEditorClient.cpp M Source/WebKit/WebProcess/WebCoreSupport/WebEditorClient.h M Source/WebKit/WebProcess/WebPage/WebPage.cpp M Source/WebKit/WebProcess/WebPage/WebPage.h M Source/WebKitLegacy/mac/WebCoreSupport/WebEditorClient.h Log Message: --- Compromised web process can grant pasteboard access by spamming WebPage::RequestDOMPasteAccess https://bugs.webkit.org/show_bug.cgi?id=269769 rdar://97343267 Reviewed by Ryosuke Niwa and Richard Robinson. It's currently possible for a compromised web process to send arbitrary `originIdentifiers` through `requestDOMPasteAccess` to the UI process during programmatic paste. Since the UI process automatically grants programmatic pasteboard access in the case where the incoming origin ID matches the origin ID of the current pasteboard content, it's possible to send a large number of origins through this IPC endpoint, with the end goal of discovering both (1) which website origin the user last copied from, and (2) the contents of the pasteboard in the case where the pasteboard copied from web content in WebKit. To mitigate this attack vector, we add a `FrameIdentifier` in the IPC endpoint, which is used in the UI process to verify that: 1. The incoming frame ID corresponds to a frame underneath the destination page. 2. The pasteboard origin matches the origin of the frame, unless the pasteboard origin is an opaque (null) origin. Additionally, we throttle pasteboard access requests to a maximum of 10 different domains every 5 seconds, to mitigate another variation on this attack vector where the compromised web process loads a large number of cross-origin frames and requests pasteboard access on behalf of those origins, in an attempt to get around the limitations above. With this change, a compromised
[webkit-changes] [WebKit/WebKit] 2c9a11: [Skia][Nicosia] Add support for accelerated offscr...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 2c9a11ae2283ca6a64bea080f8a7187af59c8dfd https://github.com/WebKit/WebKit/commit/2c9a11ae2283ca6a64bea080f8a7187af59c8dfd Author: Carlos Garcia Campos Date: 2024-05-22 (Wed, 22 May 2024) Changed paths: M Source/WebCore/html/CanvasBase.cpp M Source/WebCore/platform/graphics/nicosia/NicosiaImageBufferPipe.cpp M Source/WebCore/platform/graphics/nicosia/NicosiaImageBufferPipe.h Log Message: --- [Skia][Nicosia] Add support for accelerated offscreen canvas https://bugs.webkit.org/show_bug.cgi?id=274461 Reviewed by Miguel Gomez. * Source/WebCore/html/CanvasBase.cpp: (WebCore::CanvasBase::shouldAccelerate const): * Source/WebCore/platform/graphics/nicosia/NicosiaImageBufferPipe.cpp: (Nicosia::NicosiaImageBufferPipeSource::handle): * Source/WebCore/platform/graphics/nicosia/NicosiaImageBufferPipe.h: Canonical link: https://commits.webkit.org/279130@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 567bd6: [WPE][Qt] Add support for building QtWPE against Qt 6
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 567bd6a58583b3944fc027e0d493d117aefb5337 https://github.com/WebKit/WebKit/commit/567bd6a58583b3944fc027e0d493d117aefb5337 Author: Nikolas Zimmermann Date: 2024-05-22 (Wed, 22 May 2024) Changed paths: M Source/WebKit/PlatformWPE.cmake R Source/WebKit/UIProcess/API/wpe/qt/CMakeLists.txt R Source/WebKit/UIProcess/API/wpe/qt/WPEQmlExtensionPlugin.cpp R Source/WebKit/UIProcess/API/wpe/qt/WPEQmlExtensionPlugin.h R Source/WebKit/UIProcess/API/wpe/qt/WPEQtView.cpp R Source/WebKit/UIProcess/API/wpe/qt/WPEQtView.h R Source/WebKit/UIProcess/API/wpe/qt/WPEQtViewBackend.cpp R Source/WebKit/UIProcess/API/wpe/qt/WPEQtViewBackend.h R Source/WebKit/UIProcess/API/wpe/qt/WPEQtViewLoadRequest.cpp R Source/WebKit/UIProcess/API/wpe/qt/WPEQtViewLoadRequest.h R Source/WebKit/UIProcess/API/wpe/qt/WPEQtViewLoadRequestPrivate.h R Source/WebKit/UIProcess/API/wpe/qt/qmldir A Source/WebKit/UIProcess/API/wpe/qt5/CMakeLists.txt A Source/WebKit/UIProcess/API/wpe/qt5/WPEQmlExtensionPlugin.cpp A Source/WebKit/UIProcess/API/wpe/qt5/WPEQmlExtensionPlugin.h A Source/WebKit/UIProcess/API/wpe/qt5/WPEQtView.cpp A Source/WebKit/UIProcess/API/wpe/qt5/WPEQtView.h A Source/WebKit/UIProcess/API/wpe/qt5/WPEQtViewBackend.cpp A Source/WebKit/UIProcess/API/wpe/qt5/WPEQtViewBackend.h A Source/WebKit/UIProcess/API/wpe/qt5/WPEQtViewLoadRequest.cpp A Source/WebKit/UIProcess/API/wpe/qt5/WPEQtViewLoadRequest.h A Source/WebKit/UIProcess/API/wpe/qt5/WPEQtViewLoadRequestPrivate.h A Source/WebKit/UIProcess/API/wpe/qt5/qmldir A Source/WebKit/UIProcess/API/wpe/qt6/WPEDisplayQtQuick.cpp A Source/WebKit/UIProcess/API/wpe/qt6/WPEDisplayQtQuick.h A Source/WebKit/UIProcess/API/wpe/qt6/WPEQmlExtensionPlugin.cpp A Source/WebKit/UIProcess/API/wpe/qt6/WPEQmlExtensionPlugin.h A Source/WebKit/UIProcess/API/wpe/qt6/WPEQtView.cpp A Source/WebKit/UIProcess/API/wpe/qt6/WPEQtView.h A Source/WebKit/UIProcess/API/wpe/qt6/WPEQtViewLoadRequest.cpp A Source/WebKit/UIProcess/API/wpe/qt6/WPEQtViewLoadRequest.h A Source/WebKit/UIProcess/API/wpe/qt6/WPEQtViewLoadRequestPrivate.h A Source/WebKit/UIProcess/API/wpe/qt6/WPEViewQtQuick.cpp A Source/WebKit/UIProcess/API/wpe/qt6/WPEViewQtQuick.h A Source/WebKit/UIProcess/API/wpe/qt6/qmldir M Source/cmake/OptionsWPE.cmake M Tools/MiniBrowser/wpe/CMakeLists.txt R Tools/MiniBrowser/wpe/qt/CMakeLists.txt R Tools/MiniBrowser/wpe/qt/main.cpp R Tools/MiniBrowser/wpe/qt/main.qml R Tools/MiniBrowser/wpe/qt/qml.qrc A Tools/MiniBrowser/wpe/qt5/CMakeLists.txt A Tools/MiniBrowser/wpe/qt5/main.cpp A Tools/MiniBrowser/wpe/qt5/main.qml A Tools/MiniBrowser/wpe/qt5/qml.qrc A Tools/MiniBrowser/wpe/qt6/CMakeLists.txt A Tools/MiniBrowser/wpe/qt6/main.cpp A Tools/MiniBrowser/wpe/qt6/main.qml A Tools/MiniBrowser/wpe/qt6/qml.qrc M Tools/Scripts/run-qt-wpe-minibrowser M Tools/Scripts/webkitdirs.pm M Tools/Scripts/webkitpy/style/checker.py M Tools/TestWebKitAPI/Tests/WPEQt/WPEQtTest.cpp M Tools/TestWebKitAPI/Tests/WPEQt/WPEQtTest.h M Tools/TestWebKitAPI/glib/CMakeLists.txt Log Message: --- [WPE][Qt] Add support for building QtWPE against Qt 6 https://bugs.webkit.org/show_bug.cgi?id=270161 Reviewed by Carlos Garcia Campos. - Keep the existing Qt 5 based WPEQt implementation and rename: - Source/WebKit/UIProcess/API/wpe/qt -> Source/WebKit/UIProcess/API/wpe/qt5 - Tools/MiniBrowser/wpe/qt -> Tools/MiniBrowser/wpe/qt5 - Add a new WPEQt implementation for Qt 6, based on the new WPE platform API, that was recently developed, not relying on WPEBackend(-fdo) anymore. Touch / wheel / hover / mouse / keyboard events are supported, only keyboard+mouse events were tested so far. - Polish UI: Add navigation buttons (back|forward|reload) / URL bar for Qt 6 MiniBrowser - Make the WebKitWebView ref-counted in WPEQtView, by wrapping in GRefPtr (needs some moc related plumbing to allow for config.h inclusion, which is a pre-requisite to get wtf/ headers includable). Tested using: build-webkit --wpe --debug --cmakeargs "-DUSE_QT6=ON|OFF" run-qt-wpe-minibrowser --debug https://www.igalia.com Covered by existing tests, no change in default behavior. * Source/WebKit/PlatformWPE.cmake: * Source/WebKit/UIProcess/API/wpe/qt5/CMakeLists.txt: Renamed from Source/WebKit/UIProcess/API/wpe/qt/CMakeLists.txt. * Source/WebKit/UIProcess/API/wpe/qt5/WPEQmlExtensionPlugin.cpp: Copied from Source/WebKit/UIProcess/API/wpe/qt/WPEQmlExtensionPlugin.cpp. * Source/WebKit/UIProcess/API/wpe/qt5/WPEQmlExtensionPlugin.h: Copied from Source/WebKit/UIProcess/API/wpe/qt/WPEQmlExtensionPlugin.h. * Source/WebKit/UIProcess/API/wpe/qt5/WPEQtView.cpp: Copied from Source/WebKit/UIProcess/API/wpe/qt/WPEQtView.cpp. * Source/WebKit/UIProcess/API/wpe/qt5/WPEQtView.h: Copied
[webkit-changes] [WebKit/WebKit] 403141: ASSERTION FAILED: isPublicSuffixCF(publicSuffix) i...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 4031410eeeb157432f0a6e0ca143e54d02665096 https://github.com/WebKit/WebKit/commit/4031410eeeb157432f0a6e0ca143e54d02665096 Author: Sihui Liu Date: 2024-05-22 (Wed, 22 May 2024) Changed paths: M Source/WebCore/Headers.cmake M Source/WebCore/WebCore.xcodeproj/project.pbxproj A Source/WebCore/platform/PublicSuffix.h M Source/WebCore/platform/PublicSuffixStore.cpp M Source/WebCore/platform/PublicSuffixStore.h M Source/WebCore/platform/cocoa/PublicSuffixStoreCocoa.mm M Source/WebKit/Shared/GoToBackForwardItemParameters.h M Source/WebKit/Shared/GoToBackForwardItemParameters.serialization.in M Source/WebKit/Shared/LoadParameters.h M Source/WebKit/Shared/LoadParameters.serialization.in M Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in M Tools/TestWebKitAPI/Tests/WebCore/PublicSuffix.cpp Log Message: --- ASSERTION FAILED: isPublicSuffixCF(publicSuffix) in PublicSuffixStore::addPublicSuffix https://bugs.webkit.org/show_bug.cgi?id=274418 rdar://128255984 Reviewed by Chris Dumez. The assertion was introduced in 276834@main to help debug rdar://125417343, where we suspected the cause is unexpected entry being added to public suffix cache, like 276635@main. However, because UI process and web process have different sandbox access, isPublicSuffixCF (_CFHostIsDomainTopLevel) might return different values on the same string. That means, in web process, the assertion would be hit even though the string is a valid public suffix according to UI process's check. As the original goal is to ensure UI process only sends valid public suffix (or empty string) to web process, the patch does the hardening by introducing a new class PublicSuffix. UI process needs to explicity contruct it from URL with PublicSuffixStore and send PublicSuffix object to web process, which is less error-prone than allowing UI process sends public suffix in string. With this change, we no longer need the assertion. * Source/WebCore/Headers.cmake: * Source/WebCore/WebCore.xcodeproj/project.pbxproj: * Source/WebCore/platform/PublicSuffix.h: Added. (WebCore::PublicSuffix::fromRawString): (WebCore::PublicSuffix::isValid const): (WebCore::PublicSuffix::string const): (WebCore::PublicSuffix::isolatedCopy const): (WebCore::PublicSuffix::PublicSuffix): (WebCore::PublicSuffix::operator== const): (WebCore::PublicSuffix::isHashTableDeletedValue const): (WebCore::PublicSuffix::hash const): (WebCore::PublicSuffix::PublicSuffixHash::hash): (WebCore::PublicSuffix::PublicSuffixHash::equal): * Source/WebCore/platform/PublicSuffixStore.cpp: (WebCore::PublicSuffixStore::publicSuffix const): * Source/WebCore/platform/PublicSuffixStore.h: (): Deleted. * Source/WebCore/platform/cocoa/PublicSuffixStoreCocoa.mm: (WebCore::PublicSuffixStore::platformIsPublicSuffix const): (WebCore::PublicSuffixStore::enablePublicSuffixCache): (WebCore::PublicSuffixStore::addPublicSuffix): * Source/WebKit/Shared/GoToBackForwardItemParameters.h: * Source/WebKit/Shared/GoToBackForwardItemParameters.serialization.in: * Source/WebKit/Shared/LoadParameters.h: * Source/WebKit/Shared/LoadParameters.serialization.in: * Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in: * Tools/TestWebKitAPI/Tests/WebCore/PublicSuffix.cpp: (TestWebKitAPI::TEST_F): Canonical link: https://commits.webkit.org/279128@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 1d5ea2: [UnifiedPDF] Clean up selection repaint code
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 1d5ea2d61eff45027240a20a5561f6a393c7ad13 https://github.com/WebKit/WebKit/commit/1d5ea2d61eff45027240a20a5561f6a393c7ad13 Author: Simon Fraser Date: 2024-05-22 (Wed, 22 May 2024) Changed paths: M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.h M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm Log Message: --- [UnifiedPDF] Clean up selection repaint code https://bugs.webkit.org/show_bug.cgi?id=274499 rdar://128505796 Reviewed by Abrar Rahman Protyasha. Selection repaint currently works by computing a vector of rectangles for the selection (and possibly the old selection too), and then repainting them. This loses information about which page the rect belongs to, and for future discrete mode changes we'll need this. So repaint selections by enumerating their page coverage. If we have to repaint the old selection, just pass it directly to `repaintOnSelectionChange()`. Rename that method since it was called for selection repaint in general, not just on active state changes. * Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.h: * Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm: (WebKit::UnifiedPDFPlugin::windowActivityDidChange): (WebKit::UnifiedPDFPlugin::repaintOnSelectionChange): (WebKit::UnifiedPDFPlugin::setCurrentSelection): (WebKit::UnifiedPDFPlugin::setNeedsRepaintInDocumentRects): Deleted. (WebKit::UnifiedPDFPlugin::boundsForSelection const): Deleted. (WebKit::UnifiedPDFPlugin::repaintOnSelectionActiveStateChangeIfNeeded): Deleted. Canonical link: https://commits.webkit.org/279127@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 3a6e63: Fix linker error in JSC testing configuration
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 3a6e636fb3bed4bda1a737658411a2af43c86e00 https://github.com/WebKit/WebKit/commit/3a6e636fb3bed4bda1a737658411a2af43c86e00 Author: Keith Miller Date: 2024-05-22 (Wed, 22 May 2024) Changed paths: M Source/JavaScriptCore/bytecode/UnlinkedMetadataTable.cpp M Source/JavaScriptCore/bytecode/UnlinkedMetadataTableInlines.h Log Message: --- Fix linker error in JSC testing configuration https://bugs.webkit.org/show_bug.cgi?id=274523 rdar://128542072 Reviewed by Mark Lam. It seems like someone holding a Ref/RefPtr to UnlinkedMetadataTable didn't include the inlines header. Rather than figure out how to find the missing include I just moved the destructor to the .cpp file. I don't think the destructor is hot enough that inlining is needed. * Source/JavaScriptCore/bytecode/UnlinkedMetadataTable.cpp: (JSC::UnlinkedMetadataTable::~UnlinkedMetadataTable): * Source/JavaScriptCore/bytecode/UnlinkedMetadataTableInlines.h: (JSC::UnlinkedMetadataTable::~UnlinkedMetadataTable): Deleted. Canonical link: https://commits.webkit.org/279126@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 89de00: Introduce a TypedArrayView create that solely take...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 89de003bd68db1f46ecfc9000f341ae919c326ac https://github.com/WebKit/WebKit/commit/89de003bd68db1f46ecfc9000f341ae919c326ac Author: Anne van Kesteren Date: 2024-05-22 (Wed, 22 May 2024) Changed paths: M Source/JavaScriptCore/runtime/GenericTypedArrayView.h M Source/JavaScriptCore/runtime/GenericTypedArrayViewInlines.h M Source/WebCore/Modules/compression/CompressionStreamEncoder.cpp M Source/WebCore/Modules/compression/CompressionStreamEncoder.h M Source/WebCore/Modules/compression/DecompressionStreamDecoder.cpp M Source/WebCore/Modules/compression/DecompressionStreamDecoder.h M Source/WebCore/Modules/fetch/FetchBodyConsumer.cpp M Source/WebCore/html/HTMLMediaElement.cpp M Source/WebCore/platform/graphics/ByteArrayPixelBuffer.cpp M Source/WebCore/platform/graphics/avfoundation/cf/CDMSessionAVFoundationCF.cpp M Source/WebCore/platform/graphics/avfoundation/objc/CDMSessionAVFoundationObjC.mm Log Message: --- Introduce a TypedArrayView create that solely takes an ArrayBuffer https://bugs.webkit.org/show_bug.cgi?id=274309 Reviewed by Youenn Fablet, Keith Miller and Darin Adler. This simplifies the setup for callers as they no longer have to obtain the byteLength or provide the 0 offset. Also use Ref instead of RefPtr where possible in the compression module. * Source/JavaScriptCore/runtime/GenericTypedArrayView.h: * Source/JavaScriptCore/runtime/GenericTypedArrayViewInlines.h: (JSC::GenericTypedArrayView::create): * Source/WebCore/Modules/compression/CompressionStreamEncoder.cpp: (WebCore::CompressionStreamEncoder::encode): (WebCore::CompressionStreamEncoder::flush): (WebCore::CompressionStreamEncoder::compress): * Source/WebCore/Modules/compression/CompressionStreamEncoder.h: * Source/WebCore/Modules/compression/DecompressionStreamDecoder.cpp: (WebCore::DecompressionStreamDecoder::decode): (WebCore::DecompressionStreamDecoder::flush): (WebCore::DecompressionStreamDecoder::decompress): (WebCore::DecompressionStreamDecoder::decompressZlib): (WebCore::DecompressionStreamDecoder::decompressAppleCompressionFramework): * Source/WebCore/Modules/compression/DecompressionStreamDecoder.h: * Source/WebCore/Modules/fetch/FetchBodyConsumer.cpp: (WebCore::FetchBodyConsumer::resolve): * Source/WebCore/html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::mediaPlayerKeyNeeded): * Source/WebCore/platform/graphics/ByteArrayPixelBuffer.cpp: (WebCore::ByteArrayPixelBuffer::tryCreate): * Source/WebCore/platform/graphics/avfoundation/cf/CDMSessionAVFoundationCF.cpp: (WebCore::CDMSessionAVFoundationCF::generateKeyRequest): * Source/WebCore/platform/graphics/avfoundation/objc/CDMSessionAVFoundationObjC.mm: (WebCore::CDMSessionAVFoundationObjC::generateKeyRequest): Canonical link: https://commits.webkit.org/279125@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 24bc94: iOS: Fix gamepad detection when becoming firstResp...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 24bc94ef702df472e0b0e75d7448090b147c1c84 https://github.com/WebKit/WebKit/commit/24bc94ef702df472e0b0e75d7448090b147c1c84 Author: Darryl Pogue Date: 2024-05-22 (Wed, 22 May 2024) Changed paths: M Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm Log Message: --- iOS: Fix gamepad detection when becoming firstResponder https://bugs.webkit.org/show_bug.cgi?id=269292 Reviewed by Brady Eidson. Gamepads were only detected at initial load of the page if the WKWebView were marked as the firstResponder, rather than detecting when the WKWebView becomes or resigns the firstResponder. This aligns the behaviour with WKWebView on macOS. * Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm: (-[WKContentView becomeFirstResponderForWebView]): (-[WKContentView resignFirstResponderForWebView]): Enable/disable checking for gamepads when the WKWebView becomes or resigns firstResponder status. Canonical link: https://commits.webkit.org/279124@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 00d92c: Address Darin's review feedback on 279097@main
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 00d92c3139d072e389479b411faf047eb0b6ed00 https://github.com/WebKit/WebKit/commit/00d92c3139d072e389479b411faf047eb0b6ed00 Author: Chris Dumez Date: 2024-05-22 (Wed, 22 May 2024) Changed paths: M Source/WebCore/platform/cocoa/SharedMemoryCocoa.cpp M Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp M Source/WebCore/platform/graphics/gstreamer/mse/SourceBufferPrivateGStreamer.cpp Log Message: --- Address Darin's review feedback on 279097@main https://bugs.webkit.org/show_bug.cgi?id=274502 Unreviewed, address Darin's review feedback on 279097@main, which I somewhere failed to upload before merging the PR. * Source/WebCore/platform/cocoa/SharedMemoryCocoa.cpp: (WebCore::SharedMemory::wrapMap): * Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivateGStreamer::initializationDataEncountered): * Source/WebCore/platform/graphics/gstreamer/mse/SourceBufferPrivateGStreamer.cpp: (WebCore::SourceBufferPrivateGStreamer::appendInternal): Canonical link: https://commits.webkit.org/279123@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] f987e5: Adopt more smart pointers in HTMLCanvasElement
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: f987e56ae559b455cb008420ff25583cf0081905 https://github.com/WebKit/WebKit/commit/f987e56ae559b455cb008420ff25583cf0081905 Author: Rob Buis Date: 2024-05-22 (Wed, 22 May 2024) Changed paths: M Source/WebCore/html/HTMLCanvasElement.cpp Log Message: --- Adopt more smart pointers in HTMLCanvasElement https://bugs.webkit.org/show_bug.cgi?id=274463 Reviewed by Ryosuke Niwa. Adopt more smart pointers in HTMLCanvasElement based on the [alpha.webkit.UncountedLocalVarsChecker] warning. * Source/WebCore/html/HTMLCanvasElement.cpp: (WebCore::HTMLCanvasElement::getContext): (WebCore::HTMLCanvasElement::createContextWebGL): (WebCore::HTMLCanvasElement::paint): (WebCore::HTMLCanvasElement::didMoveToNewDocument): Canonical link: https://commits.webkit.org/279122@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 0b2576: Synchronize FileAPI WPT
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 0b25769a33bbdf56e9f725697a4e577ac8033478 https://github.com/WebKit/WebKit/commit/0b25769a33bbdf56e9f725697a4e577ac8033478 Author: Anne van Kesteren Date: 2024-05-22 (Wed, 22 May 2024) Changed paths: M LayoutTests/imported/w3c/resources/resource-files.json A LayoutTests/imported/w3c/web-platform-tests/FileAPI/FileReader/Progress_event_bubbles_cancelable-expected.txt A LayoutTests/imported/w3c/web-platform-tests/FileAPI/FileReader/Progress_event_bubbles_cancelable.html M LayoutTests/imported/w3c/web-platform-tests/FileAPI/META.yml R LayoutTests/imported/w3c/web-platform-tests/FileAPI/blob/Blob-constructor-expected.txt R LayoutTests/imported/w3c/web-platform-tests/FileAPI/blob/Blob-methods-from-detached-frame-expected.txt R LayoutTests/imported/w3c/web-platform-tests/FileAPI/blob/Blob-methods-from-detached-frame.html R LayoutTests/imported/w3c/web-platform-tests/FileAPI/blob/Blob-slice-expected.txt R LayoutTests/imported/w3c/web-platform-tests/FileAPI/blob/Blob-slice-overflow-expected.txt A LayoutTests/imported/w3c/web-platform-tests/FileAPI/blob/Blob-stream-byob-crash.html A LayoutTests/imported/w3c/web-platform-tests/FileAPI/blob/Blob-stream-sync-xhr-crash.html M LayoutTests/imported/w3c/web-platform-tests/FileAPI/blob/Blob-stream.any-expected.txt M LayoutTests/imported/w3c/web-platform-tests/FileAPI/blob/Blob-stream.any.js M LayoutTests/imported/w3c/web-platform-tests/FileAPI/blob/Blob-stream.any.worker-expected.txt M LayoutTests/imported/w3c/web-platform-tests/FileAPI/blob/w3c-import.log R LayoutTests/imported/w3c/web-platform-tests/FileAPI/file/File-constructor-expected.txt R LayoutTests/imported/w3c/web-platform-tests/FileAPI/file/send-file-formdata-expected.txt R LayoutTests/imported/w3c/web-platform-tests/FileAPI/file/send-file-formdata-utf-8-expected.txt R LayoutTests/imported/w3c/web-platform-tests/FileAPI/fileReader-expected.txt R LayoutTests/imported/w3c/web-platform-tests/FileAPI/reading-data-section/Determining-Encoding-expected.txt R LayoutTests/imported/w3c/web-platform-tests/FileAPI/reading-data-section/FileReader-event-handler-attributes-expected.txt R LayoutTests/imported/w3c/web-platform-tests/FileAPI/reading-data-section/FileReader-multiple-reads-expected.txt R LayoutTests/imported/w3c/web-platform-tests/FileAPI/reading-data-section/filereader_abort-expected.txt R LayoutTests/imported/w3c/web-platform-tests/FileAPI/reading-data-section/filereader_error-expected.txt R LayoutTests/imported/w3c/web-platform-tests/FileAPI/reading-data-section/filereader_readAsArrayBuffer-expected.txt R LayoutTests/imported/w3c/web-platform-tests/FileAPI/reading-data-section/filereader_readAsBinaryString-expected.txt R LayoutTests/imported/w3c/web-platform-tests/FileAPI/reading-data-section/filereader_readAsDataURL-expected.txt R LayoutTests/imported/w3c/web-platform-tests/FileAPI/reading-data-section/filereader_readAsText-expected.txt R LayoutTests/imported/w3c/web-platform-tests/FileAPI/reading-data-section/filereader_readystate-expected.txt R LayoutTests/imported/w3c/web-platform-tests/FileAPI/reading-data-section/filereader_result-expected.txt M LayoutTests/imported/w3c/web-platform-tests/FileAPI/url/sandboxed-iframe-expected.txt M LayoutTests/imported/w3c/web-platform-tests/FileAPI/url/url-format.any.js M LayoutTests/imported/w3c/web-platform-tests/FileAPI/url/url-with-fetch.any.js A LayoutTests/imported/w3c/web-platform-tests/FileAPI/url/url_xmlhttprequest_img-ref.html M LayoutTests/imported/w3c/web-platform-tests/FileAPI/url/w3c-import.log M LayoutTests/tests-options.json Log Message: --- Synchronize FileAPI WPT https://bugs.webkit.org/show_bug.cgi?id=274457 Reviewed by Tim Nguyen. Quite a few caveats unfortunately: - Ignore a test change with Float16Array for now as it would reduce coverage. - BlobURL/cross-partition.tentative.https.html is not imported for now. - blob/Blob-methods-from-detached-frame.html is removed as we exported it as Blob-methods-from-detached-frame.html and imported that one at a later point. So in effect this deduplicates it. - Many -expected.txt files are removed because --clean-dest-dir was not used during prior imports. - A change to FileAPI/url/multi-global-origin-serialization.sub.html is ignored for now. Latest upstream commit for this directory: https://github.com/web-platform-tests/wpt/commit/5aa50dd4151b5bc1d04d5505366c6e27df30af5b * LayoutTests/imported/w3c/resources/resource-files.json: * LayoutTests/imported/w3c/web-platform-tests/FileAPI/FileReader/Progress_event_bubbles_cancelable-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/FileAPI/FileReader/Progress_event_bubbles_cancelable.html: Added. *
[webkit-changes] [WebKit/WebKit] 19f5b8: [TextureMapper] BitmapTexture::create should not c...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 19f5b8907ca43c6f30a5417d02a532cbafe5a037 https://github.com/WebKit/WebKit/commit/19f5b8907ca43c6f30a5417d02a532cbafe5a037 Author: Carlos Garcia Campos Date: 2024-05-22 (Wed, 22 May 2024) Changed paths: M Source/WebCore/platform/graphics/texmap/BitmapTexture.cpp Log Message: --- [TextureMapper] BitmapTexture::create should not change the bound texture https://bugs.webkit.org/show_bug.cgi?id=274510 Reviewed by Miguel Gomez. When creating a new texture we should keep the previously bound texture. * Source/WebCore/platform/graphics/texmap/BitmapTexture.cpp: (WebCore::BitmapTexture::BitmapTexture): Canonical link: https://commits.webkit.org/279120@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 685354: [Skia] Use a different GL context on every thread
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 685354bc969a297feb8030122b0ab696294debd7 https://github.com/WebKit/WebKit/commit/685354bc969a297feb8030122b0ab696294debd7 Author: Carlos Garcia Campos Date: 2024-05-22 (Wed, 22 May 2024) Changed paths: M Source/WebCore/platform/graphics/PlatformDisplay.cpp M Source/WebCore/platform/graphics/PlatformDisplay.h M Source/WebCore/platform/graphics/skia/PlatformDisplaySkia.cpp Log Message: --- [Skia] Use a different GL context on every thread https://bugs.webkit.org/show_bug.cgi?id=274454 Reviewed by Miguel Gomez. This will allow to have accelerated ImageBitmap and offscreen canvas. * Source/WebCore/platform/graphics/PlatformDisplay.cpp: (WebCore::PlatformDisplay::clearSharingGLContext): * Source/WebCore/platform/graphics/PlatformDisplay.h: (WebCore::PlatformDisplay::skiaGrContext): Deleted. * Source/WebCore/platform/graphics/skia/PlatformDisplaySkia.cpp: (WebCore::skiaGLInterface): (WebCore::SkiaGLContext::create): (WebCore::SkiaGLContext::invalidate): (WebCore::SkiaGLContext::skiaGLContext const): (WebCore::SkiaGLContext::skiaGrContext const): (WebCore::SkiaGLContext::SkiaGLContext): (WebCore::PlatformDisplay::skiaGLContext): (WebCore::PlatformDisplay::skiaGrContext): (WebCore::PlatformDisplay::invalidateSkiaGLContexts): Canonical link: https://commits.webkit.org/279119@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] be4cdc: Implement further enforcement of Trusted Types for...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: be4cdc9c602803f8505921b2c66f86aa0f392497 https://github.com/WebKit/WebKit/commit/be4cdc9c602803f8505921b2c66f86aa0f392497 Author: Luke Warlow Date: 2024-05-22 (Wed, 22 May 2024) Changed paths: M LayoutTests/imported/w3c/web-platform-tests/trusted-types/block-string-assignment-to-attribute-via-attribute-node-expected.txt M LayoutTests/imported/w3c/web-platform-tests/trusted-types/modify-attributes-in-callback-expected.txt M LayoutTests/imported/w3c/web-platform-tests/trusted-types/modify-attributes-in-callback.html M Source/WebCore/dom/Attr.cpp M Source/WebCore/dom/Attr.h M Source/WebCore/dom/CharacterData.cpp M Source/WebCore/dom/CharacterData.h M Source/WebCore/dom/Element.cpp M Source/WebCore/dom/Element.h M Source/WebCore/dom/Node.cpp M Source/WebCore/dom/Node.h Log Message: --- Implement further enforcement of Trusted Types for Attributes https://bugs.webkit.org/show_bug.cgi?id=274267 Reviewed by Ryosuke Niwa. This patch adds trusted types enforcement to Attr textContent, value and nodeValue. It also improves error handling for mutating attributes within default policy. * LayoutTests/imported/w3c/web-platform-tests/trusted-types/block-string-assignment-to-attribute-via-attribute-node-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/trusted-types/modify-attributes-in-callback-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/trusted-types/modify-attributes-in-callback.html: * Source/WebCore/dom/Attr.cpp: (WebCore::Attr::setValue): (WebCore::Attr::setNodeValue): * Source/WebCore/dom/Attr.h: * Source/WebCore/dom/CharacterData.cpp: (WebCore::CharacterData::setNodeValue): * Source/WebCore/dom/CharacterData.h: * Source/WebCore/dom/Element.cpp: (WebCore::Element::validateAttributeIndex const): (WebCore::Element::setAttribute): * Source/WebCore/dom/Element.h: * Source/WebCore/dom/Node.cpp: (WebCore::Node::setNodeValue): (WebCore::Node::setTextContent): * Source/WebCore/dom/Node.h: Canonical link: https://commits.webkit.org/279118@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] f33204: Implement trusted types enforcement for script ele...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: f33204d52243ae13948a2dee417d69e25442c2d8 https://github.com/WebKit/WebKit/commit/f33204d52243ae13948a2dee417d69e25442c2d8 Author: Luke Warlow Date: 2024-05-22 (Wed, 22 May 2024) Changed paths: M LayoutTests/TestExpectations M LayoutTests/imported/w3c/web-platform-tests/trusted-types/block-Node-multiple-arguments-expected.txt M LayoutTests/imported/w3c/web-platform-tests/trusted-types/block-text-node-insertion-into-script-element-expected.txt M LayoutTests/imported/w3c/web-platform-tests/trusted-types/trusted-types-report-only-expected.txt M LayoutTests/imported/w3c/web-platform-tests/trusted-types/trusted-types-svg-script-expected.txt M Source/WebCore/dom/ScriptElement.cpp M Source/WebCore/dom/ScriptElement.h M Source/WebCore/html/HTMLScriptElement.cpp M Source/WebCore/html/HTMLScriptElement.h M Source/WebCore/svg/SVGScriptElement.cpp M Source/WebCore/svg/SVGScriptElement.h Log Message: --- Implement trusted types enforcement for script elements https://bugs.webkit.org/show_bug.cgi?id=269365 Reviewed by Darin Adler and Ryosuke Niwa. Add script text string to script element. This is used to ensure that script elements can't be manipulated in untrusted ways. See https://w3c.github.io/trusted-types/dist/spec/#htmlscriptelement-script-text and https://w3c.github.io/trusted-types/dist/spec/#slot-value-verification * LayoutTests/TestExpectations: * LayoutTests/imported/w3c/web-platform-tests/trusted-types/block-Node-multiple-arguments-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/trusted-types/block-text-node-insertion-into-script-element-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/trusted-types/trusted-types-report-only-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/trusted-types/trusted-types-svg-script-expected.txt: * Source/WebCore/dom/ScriptElement.cpp: (WebCore::ScriptElement::finishParsingChildren): (WebCore::ScriptElement::prepareScript): (WebCore::ScriptElement::setTrustedScriptText): * Source/WebCore/dom/ScriptElement.h: * Source/WebCore/html/HTMLScriptElement.cpp: (WebCore::HTMLScriptElement::finishParsingChildren): (WebCore::HTMLScriptElement::setTextContent): (WebCore::HTMLScriptElement::setInnerText): * Source/WebCore/html/HTMLScriptElement.h: * Source/WebCore/svg/SVGScriptElement.cpp: (WebCore::SVGScriptElement::finishParsingChildren): * Source/WebCore/svg/SVGScriptElement.h: Canonical link: https://commits.webkit.org/279117@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 3414c9: [GTK] `css3/flexbox/image-percent-max-height.html`...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 3414c9ad54a72dffbe8ef62a626c62c7174597d6 https://github.com/WebKit/WebKit/commit/3414c9ad54a72dffbe8ef62a626c62c7174597d6 Author: Vitaly Dyachkov Date: 2024-05-22 (Wed, 22 May 2024) Changed paths: M LayoutTests/css3/flexbox/image-percent-max-height-expected.html M LayoutTests/css3/flexbox/image-percent-max-height.html M LayoutTests/platform/wpe/TestExpectations Log Message: --- [GTK] `css3/flexbox/image-percent-max-height.html` is a constant failure https://bugs.webkit.org/show_bug.cgi?id=271762 Reviewed by Said Abou-Hallawa. Use `image-rendering: crisp-edges;` to prevent scaling artifacts. * LayoutTests/css3/flexbox/image-percent-max-height-expected.html: * LayoutTests/css3/flexbox/image-percent-max-height.html: * LayoutTests/platform/mac/TestExpectations: * LayoutTests/platform/wpe/TestExpectations: Canonical link: https://commits.webkit.org/279116@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] c2e64b: Implement `field-sizing: content` minimum width fo...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: c2e64ba96fbed90353cfdea4b0c20a855a6c40bb https://github.com/WebKit/WebKit/commit/c2e64ba96fbed90353cfdea4b0c20a855a6c40bb Author: Luke Warlow Date: 2024-05-22 (Wed, 22 May 2024) Changed paths: A LayoutTests/fast/forms/text/text-field-sizing-caret-expected.txt A LayoutTests/fast/forms/text/text-field-sizing-caret.html A LayoutTests/fast/forms/textarea/textarea-field-sizing-caret-expected.txt A LayoutTests/fast/forms/textarea/textarea-field-sizing-caret.html M Source/WebCore/html/HTMLTextFormControlElement.cpp Log Message: --- Implement `field-sizing: content` minimum width for text caret https://bugs.webkit.org/show_bug.cgi?id=269128 Reviewed by Darin Adler. Updates text control computed style to include a minimum sizing so the caret shows. * LayoutTests/fast/forms/text/text-field-sizing-caret-expected.txt: Added. * LayoutTests/fast/forms/text/text-field-sizing-caret.html: Added. * LayoutTests/fast/forms/textarea/textarea-field-sizing-caret-expected.txt: Added. * LayoutTests/fast/forms/textarea/textarea-field-sizing-caret.html: Added. * Source/WebCore/html/HTMLTextFormControlElement.cpp: (WebCore::HTMLTextFormControlElement::adjustInnerTextStyle const): Canonical link: https://commits.webkit.org/279115@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 45503f: Unreviewed, reverting 279093@main.
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 45503f8710637c591ea738906c2a8303dc9663ed https://github.com/WebKit/WebKit/commit/45503f8710637c591ea738906c2a8303dc9663ed Author: Commit Queue Date: 2024-05-22 (Wed, 22 May 2024) Changed paths: M Source/WebCore/animation/KeyframeEffect.cpp Log Message: --- Unreviewed, reverting 279093@main. https://bugs.webkit.org/show_bug.cgi?id=274511 Caused compositing consistency assertion in debug tests Reverted changeset: "[view-transitions] Async animation of snapshot position via transform looks jumpy with sync animation of size" https://bugs.webkit.org/show_bug.cgi?id=274437 https://commits.webkit.org/279093@main Canonical link: https://commits.webkit.org/279114@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 05456a: [macOS Sonoma+] Enable microphone capture in GPUPr...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 05456ae93aa145c7f52bb3876fa296469d9424d7 https://github.com/WebKit/WebKit/commit/05456ae93aa145c7f52bb3876fa296469d9424d7 Author: Youenn Fablet Date: 2024-05-22 (Wed, 22 May 2024) Changed paths: M Source/WTF/wtf/PlatformHave.h M Source/WebKit/Shared/WebPreferencesDefaultValues.cpp Log Message: --- [macOS Sonoma+] Enable microphone capture in GPUProcess for all applications https://bugs.webkit.org/show_bug.cgi?id=274464 rdar://128463834 Reviewed by Jean-Yves Avenard. Given rdar://problem/29448368 is fixed in Sonoma, we can enable GPU process microphone capture. This allows to reuse VPIO for audio rendering like Safari does. * Source/WTF/wtf/PlatformHave.h: * Source/WebKit/Shared/WebPreferencesDefaultValues.cpp: (WebKit::defaultCaptureAudioInGPUProcessEnabled): Canonical link: https://commits.webkit.org/279113@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 4ec5cd: [visionOS] In Firefox, YouTube videos immediately ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 4ec5cdeedc10b597d41c3c5ecd264c62e2a7e007 https://github.com/WebKit/WebKit/commit/4ec5cdeedc10b597d41c3c5ecd264c62e2a7e007 Author: Jean-Yves Avenard Date: 2024-05-22 (Wed, 22 May 2024) Changed paths: M Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm M Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.h M Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm M Source/WebCore/platform/ios/VideoPresentationInterfaceIOS.mm M Source/WebKit/UIProcess/WebPageProxy.cpp Log Message: --- [visionOS] In Firefox, YouTube videos immediately exit full screen https://bugs.webkit.org/show_bug.cgi?id=274458 rdar://12214 Reviewed by Jer Noble. The primary cause for fullscreen to immediately exit was a typo in the use of the PLATFORM macro which caused requestHideAndExitFullscreen() to be immediately called once we had entered fullscreen. Then we had two issues that were revealed once the primary issue was fixed. When running in iOS compatibility mode, once we entered fullscreen we would either remove the player from the video layer (CRABS) or teardown the video layer (MSE). To avoid this, we check if a FigVideoTargetRef is set, which indicate that the application isn't running in iOS compatibility mode and a LMK isn't in use. Manually tested MSE and CRABS, for both app in both native (Safari) and compatibility mode (Firefox) * Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.h: * Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm: (WebCore::MediaPlayerPrivateMediaSourceAVFObjC::acceleratedVideoMode const): (WebCore::MediaPlayerPrivateAVFoundationObjC::isInFullscreenOrPictureInPictureChanged): * Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm: (WebCore::MediaPlayerPrivateMediaSourceAVFObjC::isInFullscreenOrPictureInPictureChanged): * Source/WebCore/platform/ios/VideoPresentationInterfaceIOS.mm: (WebCore::VideoPresentationInterfaceIOS::doSetup): * Source/WebKit/UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::viewDidLeaveWindow): Fix typo and replace with PLATFORM(VISION). This caused to immediately exit fullscreen as soon as we entered fullscreen. Canonical link: https://commits.webkit.org/279112@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] a270d6: Most of WPT webrtc/RTCSctpTransport-maxMessageSize...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: a270d67c53417c216ccfa1ed3bbc30a20e7d4512 https://github.com/WebKit/WebKit/commit/a270d67c53417c216ccfa1ed3bbc30a20e7d4512 Author: Youenn Fablet Date: 2024-05-22 (Wed, 22 May 2024) Changed paths: M LayoutTests/imported/w3c/web-platform-tests/webrtc/RTCSctpTransport-maxMessageSize-expected.txt M Source/WebCore/Modules/mediastream/PeerConnectionBackend.cpp M Source/WebCore/Modules/mediastream/PeerConnectionBackend.h M Source/WebCore/Modules/mediastream/RTCPeerConnection.cpp M Source/WebCore/Modules/mediastream/RTCPeerConnection.h M Source/WebCore/Modules/mediastream/RTCSctpTransport.cpp M Source/WebCore/Modules/mediastream/RTCSctpTransport.h M Source/WebCore/Modules/mediastream/gstreamer/GStreamerMediaEndpoint.cpp M Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp Log Message: --- Most of WPT webrtc/RTCSctpTransport-maxMessageSize.html tests are failing https://bugs.webkit.org/show_bug.cgi?id=274442 rdar://128444396 Reviewed by Philippe Normand. We implement https://w3c.github.io/webrtc-pc/#sctp-transport-update-mms. This is called when successfully applying a SDP description as per specification. In this implementation, the assumption is that canSendSize is 0. The specific value of 65536 is handled by libwebrtc. * LayoutTests/imported/w3c/web-platform-tests/webrtc/RTCSctpTransport-maxMessageSize-expected.txt: * Source/WebCore/Modules/mediastream/PeerConnectionBackend.cpp: (WebCore::PeerConnectionBackend::setLocalDescriptionSucceeded): (WebCore::PeerConnectionBackend::setRemoteDescriptionSucceeded): * Source/WebCore/Modules/mediastream/PeerConnectionBackend.h: * Source/WebCore/Modules/mediastream/RTCPeerConnection.cpp: (WebCore::RTCPeerConnection::updateSctpBackend): * Source/WebCore/Modules/mediastream/RTCPeerConnection.h: * Source/WebCore/Modules/mediastream/RTCSctpTransport.cpp: (WebCore::RTCSctpTransport::onStateChanged): (WebCore::RTCSctpTransport::updateMaxMessageSize): * Source/WebCore/Modules/mediastream/RTCSctpTransport.h: * Source/WebCore/Modules/mediastream/gstreamer/GStreamerMediaEndpoint.cpp: (WebCore::GStreamerMediaEndpoint::doSetLocalDescription): (WebCore::GStreamerMediaEndpoint::doSetRemoteDescription): * Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp: (WebCore::SctpTransportState::maxMessageSize const): (WebCore::LibWebRTCMediaEndpoint::setLocalSessionDescriptionSucceeded): (WebCore::LibWebRTCMediaEndpoint::setRemoteSessionDescriptionSucceeded): Canonical link: https://commits.webkit.org/279111@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 6ad608: Unreviewed, reverting 278971@main (7da094e1da19)
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 6ad608ca9d2936751a08a54639756243071542aa https://github.com/WebKit/WebKit/commit/6ad608ca9d2936751a08a54639756243071542aa Author: Michael[tm] Smith Date: 2024-05-22 (Wed, 22 May 2024) Changed paths: M LayoutTests/editing/execCommand/break-out-of-empty-list-item.html M LayoutTests/editing/inserting/typing-space-to-trigger-smart-link.html M LayoutTests/editing/pasteboard/paste-text-events-expected.txt M LayoutTests/editing/pasteboard/paste-text-events.html M LayoutTests/editing/style/highlight-insert-paragraph.html M LayoutTests/fast/events/input-events-fired-when-typing-expected.txt M LayoutTests/fast/events/input-events-fired-when-typing.html M LayoutTests/fast/events/ios/submit-form-target-blank-using-return-key.html M LayoutTests/fast/events/onchange-passwordfield.html M LayoutTests/fast/events/onchange-searchfield.html M LayoutTests/fast/events/onchange-textfield.html M LayoutTests/fast/forms/onchange-change-type.html M LayoutTests/http/tests/navigation/keyboard-events-during-provisional-navigation-expected.txt M LayoutTests/http/tests/navigation/keyboard-events-during-provisional-subframe-navigation-expected.txt M LayoutTests/platform/mac-wk2/http/tests/navigation/keyboard-events-during-provisional-navigation-expected.txt M LayoutTests/platform/wpe/TestExpectations M Source/WebCore/dom/Node.cpp M Source/WebCore/dom/TextEvent.cpp M Source/WebCore/dom/TextEvent.h M Source/WebCore/editing/AlternativeTextController.cpp M Source/WebCore/editing/Editor.cpp M Source/WebCore/editing/Editor.h M Source/WebCore/editing/EditorCommand.cpp M Source/WebCore/page/EventHandler.cpp M Source/WebCore/page/EventHandler.h Log Message: --- Unreviewed, reverting 278971@main (7da094e1da19) https://bugs.webkit.org/show_bug.cgi?id=274500 rdar://128463632 REGRESSION (278971@main): [iOS] Form submission does not occur when pressing the return key Reverted change: The beforeinput event should fire before textInput https://bugs.webkit.org/show_bug.cgi?id=268988 278971@main (7da094e1da19) Canonical link: https://commits.webkit.org/279110@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 072b03: [Navigation] Correct cancelable determination of N...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 072b031414e564e51079e9a3448b5843d0f4492d https://github.com/WebKit/WebKit/commit/072b031414e564e51079e9a3448b5843d0f4492d Author: Rob Buis Date: 2024-05-22 (Wed, 22 May 2024) Changed paths: M LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigate-event/cross-window/click-samedocument-crossorigin-expected.txt M LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigate-event/cross-window/click-samedocument-sameorigin-expected.txt M LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigate-event/cross-window/location-samedocument-crossorigin-expected.txt M LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigate-event/cross-window/location-samedocument-sameorigin-expected.txt M LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigate-event/cross-window/open-samedocument-crossorigin-expected.txt M LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigate-event/cross-window/open-samedocument-crossorigin-sameorigindomain.sub-expected.txt M LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigate-event/cross-window/open-samedocument-sameorigin-expected.txt M LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigate-event/cross-window/submit-samedocument-crossorigin-expected.txt M LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigate-event/cross-window/submit-samedocument-crossorigin-sameorigindomain.sub-expected.txt M LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigate-event/cross-window/submit-samedocument-sameorigin-expected.txt M LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigate-event/navigate-iframe-location-expected.txt M LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigate-event/navigate-window-open-expected.txt M LayoutTests/platform/glib/imported/w3c/web-platform-tests/navigation-api/navigate-event/cross-window/click-samedocument-crossorigin-sameorigindomain.sub-expected.txt M LayoutTests/platform/glib/imported/w3c/web-platform-tests/navigation-api/navigate-event/cross-window/location-samedocument-crossorigin-sameorigindomain.sub-expected.txt M Source/WebCore/page/Navigation.cpp Log Message: --- [Navigation] Correct cancelable determination of NavigateEvent https://bugs.webkit.org/show_bug.cgi?id=274471 Reviewed by Alex Christensen and Darin Adler. When determining the cancelable flag for NavigateEvent we did not take into account the navigation type [1]. By fixing that we fix navigate-anchor-download.html, navigate-anchor-download-userInitiated.html and can mark two further tests as passing. [1] https://html.spec.whatwg.org/multipage/nav-history-apis.html#inner-navigate-event-firing-algorithm (Step 11) * LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigate-event/cross-window/click-samedocument-crossorigin-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigate-event/cross-window/click-samedocument-sameorigin-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigate-event/cross-window/location-samedocument-crossorigin-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigate-event/cross-window/location-samedocument-sameorigin-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigate-event/cross-window/open-samedocument-crossorigin-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigate-event/cross-window/open-samedocument-crossorigin-sameorigindomain.sub-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigate-event/cross-window/open-samedocument-sameorigin-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigate-event/cross-window/submit-samedocument-crossorigin-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigate-event/cross-window/submit-samedocument-crossorigin-sameorigindomain.sub-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigate-event/cross-window/submit-samedocument-sameorigin-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigate-event/navigate-iframe-location-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigate-event/navigate-window-open-expected.txt: * LayoutTests/platform/glib/imported/w3c/web-platform-tests/navigation-api/navigate-event/cross-window/click-samedocument-crossorigin-sameorigindomain.sub-expected.txt: * LayoutTests/platform/glib/imported/w3c/web-platform-tests/navigation-api/navigate-event/cross-window/location-samedocument-crossorigin-sameorigindomain.sub-expected.txt: * Source/WebCore/page/Navigation.cpp: (WebCore::Navigation::innerDispatchNavigateEvent): Canonical link:
[webkit-changes] [WebKit/WebKit] adcd97: Further remove MSVC code
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: adcd97e5a4ae359e0ea83a4cc9ae2348b95d607f https://github.com/WebKit/WebKit/commit/adcd97e5a4ae359e0ea83a4cc9ae2348b95d607f Author: Yusuke Suzuki Date: 2024-05-21 (Tue, 21 May 2024) Changed paths: M Source/JavaScriptCore/API/tests/testapi.c M Source/JavaScriptCore/API/tests/testapi.cpp M Source/JavaScriptCore/assembler/MacroAssemblerX86Common.cpp M Source/JavaScriptCore/assembler/X86Assembler.h M Source/JavaScriptCore/builtins/BuiltinNames.cpp M Source/JavaScriptCore/config.h M Source/JavaScriptCore/jit/PCToCodeOriginMap.cpp M Source/JavaScriptCore/jit/RegisterAtOffset.h M Source/JavaScriptCore/jsc.cpp M Source/JavaScriptCore/offlineasm/generate_offset_extractor.rb M Source/JavaScriptCore/parser/SourceProviderCacheItem.h M Source/JavaScriptCore/runtime/JSCPtrTag.h M Source/JavaScriptCore/runtime/VM.h M Source/JavaScriptCore/testRegExp.cpp M Source/WTF/wtf/Assertions.cpp M Source/WTF/wtf/Assertions.h M Source/WTF/wtf/MathExtras.h M Source/WTF/wtf/PtrTag.h M Source/WTF/wtf/SegmentedVector.h M Source/WTF/wtf/posix/ThreadingPOSIX.cpp Log Message: --- Further remove MSVC code https://bugs.webkit.org/show_bug.cgi?id=274450 rdar://128448731 Reviewed by Ross Kirsling. Further remove MSVC hacks. And we use `OS(WINDOWS)` for code which needs to be used on Windows (even without MSVC). * Source/JavaScriptCore/API/tests/testapi.c: * Source/JavaScriptCore/API/tests/testapi.cpp: * Source/JavaScriptCore/assembler/MacroAssemblerX86Common.cpp: (JSC::MacroAssembler::probe): (JSC::MacroAssemblerX86Common::getCPUIDEx): * Source/JavaScriptCore/assembler/X86Assembler.h: * Source/JavaScriptCore/builtins/BuiltinNames.cpp: * Source/JavaScriptCore/config.h: * Source/JavaScriptCore/jit/PCToCodeOriginMap.cpp: * Source/JavaScriptCore/jit/RegisterAtOffset.cpp: * Source/JavaScriptCore/jsc.cpp: (JSC_DEFINE_HOST_FUNCTION): (jscmain): * Source/JavaScriptCore/offlineasm/generate_offset_extractor.rb: * Source/JavaScriptCore/parser/SourceProviderCacheItem.h: * Source/JavaScriptCore/runtime/JSCPtrTag.h: * Source/JavaScriptCore/runtime/VM.h: * Source/JavaScriptCore/testRegExp.cpp: * Source/WTF/wtf/Assertions.cpp: (WTF::createWithFormatAndArguments): * Source/WTF/wtf/Assertions.h: * Source/WTF/wtf/MathExtras.h: * Source/WTF/wtf/PtrTag.h: * Source/WTF/wtf/SegmentedVector.h: * Source/WTF/wtf/posix/ThreadingPOSIX.cpp: Canonical link: https://commits.webkit.org/279108@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
