[webkit-changes] [WebKit/WebKit] c61b4b: [masonry] getComputedStyle should return masonry

[Brandon Stewart]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c61b4bd8c681b8982c2c46af366f6654ac162e2d
  
https://github.com/WebKit/WebKit/commit/c61b4bd8c681b8982c2c46af366f6654ac162e2d
  Author: Brandon Stewart 
  Date:   2024-09-10 (Tue, 10 Sep 2024)

  Changed paths:
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/masonry-grid-template-columns-computed-withcontent-expected.txt
M Source/WebCore/css/ComputedStyleExtractor.cpp

  Log Message:
  ---
  [masonry] getComputedStyle should return masonry
https://bugs.webkit.org/show_bug.cgi?id=279387
rdar://problem/135602712

Reviewed by Sammy Gill.

getComputedStyle() should return a value of masonry when computing 
grid-template-columns or grid-template-rows.
Returning a px value as we were doing before in the test case is not correct.

https://drafts.csswg.org/css-grid-3/#grid-template-masonry

* 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/masonry-grid-template-columns-computed-withcontent-expected.txt:
* Source/WebCore/css/ComputedStyleExtractor.cpp:
(WebCore::valueForGridTrackList):
(WebCore::rendererCanHaveTrimmedMargin):
(WebCore::ComputedStyleExtractor::valueForPropertyInStyle const):

Canonical link: https://commits.webkit.org/283429@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] cef8bd: [css-masonry] Update masonry-gap-002-ref.html to a...

[Brandon Stewart]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: cef8bd5564edda53b9f18e81c3f730a1764db824
  
https://github.com/WebKit/WebKit/commit/cef8bd5564edda53b9f18e81c3f730a1764db824
  Author: Brandon Stewart 
  Date:   2024-08-22 (Thu, 22 Aug 2024)

  Changed paths:
M LayoutTests/TestExpectations
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/gap/masonry-gap-002-expected.html
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/gap/masonry-gap-002-ref.html
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/gap/masonry-gap-002.html

  Log Message:
  ---
  [css-masonry] Update masonry-gap-002-ref.html to align with test case behavior
https://bugs.webkit.org/show_bug.cgi?id=278489
rdar://problem/134446346

Reviewed by Sammy Gill.

gap-002 was creating 4 columns of 'auto', which in masonry would set all the 
'auto' tracks to the same size.
We can address this by creating hidden elements in the expected test to emulate 
this.

-expected test case did not match the -ref test case, so that has been 
corrected.

* LayoutTests/TestExpectations:
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/gap/masonry-gap-002-expected.html:
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/gap/masonry-gap-002-ref.html:
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/gap/masonry-gap-002.html:

Canonical link: https://commits.webkit.org/282614@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] fc4e08: [css-masonry] GridTrackSizing Header Cleanup

[Brandon Stewart]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: fc4e08755b94d4b2e11a0e25a34c136d2cdd0eda
  
https://github.com/WebKit/WebKit/commit/fc4e08755b94d4b2e11a0e25a34c136d2cdd0eda
  Author: Brandon Stewart 
  Date:   2024-08-21 (Wed, 21 Aug 2024)

  Changed paths:
M Source/WebCore/rendering/GridTrackSizingAlgorithm.h

  Log Message:
  ---
  [css-masonry] GridTrackSizing Header Cleanup
https://bugs.webkit.org/show_bug.cgi?id=278490
rdar://problem/134446919

Reviewed by Sammy Gill.

The original plan was to use StdMultimap, but the implementation changed to 
using a StdMap with a vector as the value.
The StdMultimap is no longer being used in this file and can be removed.

* Source/WebCore/rendering/GridTrackSizingAlgorithm.h:

Canonical link: https://commits.webkit.org/282599@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 297884: [css-masonry] Update masonry-intrinsic-sizing-cols...

[Brandon Stewart]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 297884e8bd4d4d3c34df56d6e033261b525fad58
  
https://github.com/WebKit/WebKit/commit/297884e8bd4d4d3c34df56d6e033261b525fad58
  Author: Brandon Stewart 
  Date:   2024-08-20 (Tue, 20 Aug 2024)

  Changed paths:
M LayoutTests/TestExpectations
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/intrinsic-sizing/masonry-intrinsic-sizing-cols-005-expected.html
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/intrinsic-sizing/masonry-intrinsic-sizing-cols-005-ref.html

  Log Message:
  ---
  [css-masonry] Update masonry-intrinsic-sizing-cols-005-ref/expected to align 
with base test case
https://bugs.webkit.org/show_bug.cgi?id=278382
rdar://problem/134344626

Reviewed by Sammy Gill.

In Masonry having a definite item means that the sizing is only considered in 
the that track.
The other tracks will just be auto sized to the block size of the box.

* LayoutTests/TestExpectations:
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/intrinsic-sizing/masonry-intrinsic-sizing-cols-005-expected.html:
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/intrinsic-sizing/masonry-intrinsic-sizing-cols-005-ref.html:

Canonical link: https://commits.webkit.org/282513@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 24b5b0: [css-masonry] masonry-intrinsic-sizing-cols-001 is...

[Brandon Stewart]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 24b5b087d18d4baa487dd73905c46589fa353da3
  
https://github.com/WebKit/WebKit/commit/24b5b087d18d4baa487dd73905c46589fa353da3
  Author: Brandon Stewart 
  Date:   2024-08-20 (Tue, 20 Aug 2024)

  Changed paths:
M LayoutTests/TestExpectations

  Log Message:
  ---
  [css-masonry] masonry-intrinsic-sizing-cols-001 is passing
https://bugs.webkit.org/show_bug.cgi?id=278383
rdar://problem/134344800

Reviewed by Sammy Gill.

Based on running the test locally it is confirming that it passed.

* LayoutTests/TestExpectations:

Canonical link: https://commits.webkit.org/282510@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 6a622c: [css-masonry] Update masonry-intrinsic-sizing-cols...

[Brandon Stewart]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 6a622c21a8f68ab89beb3291db8af8360912c089
  
https://github.com/WebKit/WebKit/commit/6a622c21a8f68ab89beb3291db8af8360912c089
  Author: Brandon Stewart 
  Date:   2024-08-20 (Tue, 20 Aug 2024)

  Changed paths:
M LayoutTests/TestExpectations
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/intrinsic-sizing/masonry-intrinsic-sizing-cols-003-expected.html
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/intrinsic-sizing/masonry-intrinsic-sizing-cols-003-ref.html

  Log Message:
  ---
  [css-masonry] Update masonry-intrinsic-sizing-cols-003-ref/expected to align 
with base test case
https://bugs.webkit.org/show_bug.cgi?id=278379
rdar://problem/134341983

Reviewed by Sammy Gill.

There were two issues with this ref/expected test cases.

1. In test case two of mixed sizing: fixed + auto + fr the 5 needs to be a 
width of 2ch, because the width is set to 2ch in the base test case.

2. The number of 5s present in the other test cases were miscounted.

* LayoutTests/TestExpectations:
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/intrinsic-sizing/masonry-intrinsic-sizing-cols-003-expected.html:
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/intrinsic-sizing/masonry-intrinsic-sizing-cols-003-ref.html:

Canonical link: https://commits.webkit.org/282501@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 19c323: macOS header files failing with clangd

[Brandon Stewart]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 19c323b9385f1f9139667426a3e4aa0fd0d7cf54
  
https://github.com/WebKit/WebKit/commit/19c323b9385f1f9139667426a3e4aa0fd0d7cf54
  Author: Brandon Stewart 
  Date:   2024-08-19 (Mon, 19 Aug 2024)

  Changed paths:
M Tools/clangd/update-clangd-config

  Log Message:
  ---
  macOS header files failing with clangd
https://bugs.webkit.org/show_bug.cgi?id=278179
rdar://problem/133965046

Reviewed by Elliott Williams.

macOS clangd header files were failing in WebKit. This appears to be caused by 
the "-xobjective-cpp" flag, so I
updated the flag to "-xobjective-c++", which fixes the error.

* Tools/clangd/update-clangd-config:
 (gen_template_environment):

Canonical link: https://commits.webkit.org/282470@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] f10662: [masonry] Optimize items that span multiple tracks

[Brandon Stewart]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: f10662fe88d05adea16c6cdccd850905acd342f2
  
https://github.com/WebKit/WebKit/commit/f10662fe88d05adea16c6cdccd850905acd342f2
  Author: Brandon Stewart 
  Date:   2024-08-19 (Mon, 19 Aug 2024)

  Changed paths:
M LayoutTests/TestExpectations
M Source/WebCore/rendering/GridTrackSizingAlgorithm.cpp
M Source/WebCore/rendering/GridTrackSizingAlgorithm.h

  Log Message:
  ---
  [masonry] Optimize items that span multiple tracks
https://bugs.webkit.org/show_bug.cgi?id=276733
rdar://problem/132435056

Reviewed by Sammy Gill and Yusuke Suzuki.

The implementation is split up into several steps.

1. Gather indefinite items into groups, and calculate their min/max sizes. 
Definite items
should be documented for later use too.

2. Update intrinsic tracks with single span items.

3. Convert indefinite items to definite items.

3. Update instrinsic tracks with multi span items that do not cross a flex 
track.

4. Update flex tracks with items that are single or multi span that cross a 
flex track.

Note: This masonry implementation does not support Subgrid at this point.

* LayoutTests/TestExpectations:
* Source/WebCore/rendering/GridTrackSizingAlgorithm.cpp:
 (WebCore::GridTrackSizingAlgorithm::computeTrackBasedSize const):
 (WebCore::GridTrackSizingAlgorithm::sizeTrackToFitSingleSpanMasonryGroup):
 
(WebCore::GridTrackSizingAlgorithm::itemSizeForTrackSizeComputationPhaseMasonry 
const):
 
(WebCore::GridTrackSizingAlgorithm::increaseSizesToAccommodateSpanningItemsMasonry):
 
(WebCore::GridTrackSizingAlgorithm::increaseSizesToAccommodateSpanningItemsMasonryWithFlex):
 (WebCore::GridTrackSizingAlgorithm::convertIndefiniteItemsToDefiniteMasonry):
 (WebCore::GridTrackSizingAlgorithm::distributeSpaceToTracks const):
 (WebCore::GridTrackSizingAlgorithmStrategy::minContentForGridItem const):
 (WebCore::GridTrackSizingAlgorithm::canParticipateInBaselineAlignment const):
 (WebCore::GridTrackSizingAlgorithm::computeIndefiniteItemsForMasonry):
 (WebCore::GridTrackSizingAlgorithm::resolveIntrinsicTrackSizesMasonry):
 (WebCore::GridTrackSizingAlgorithm::accumulateIntrinsicSizesForTrackMasonry): 
Deleted.
 (WebCore::GridTrackSizingAlgorithm::computeIndefiniteItemsForMasonry const): 
Deleted.
* Source/WebCore/rendering/GridTrackSizingAlgorithm.h:

Canonical link: https://commits.webkit.org/282464@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] fd25ae: Update README: Change iBooks to Apple Books

[Brandon Stewart]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: fd25ae7b0445a9b2689bc836690e1ee5f9bf0826
  
https://github.com/WebKit/WebKit/commit/fd25ae7b0445a9b2689bc836690e1ee5f9bf0826
  Author: Brandon Stewart 
  Date:   2024-08-14 (Wed, 14 Aug 2024)

  Changed paths:
M ReadMe.md

  Log Message:
  ---
  Update README: Change iBooks to Apple Books
https://bugs.webkit.org/show_bug.cgi?id=278105
rdar://problem/133844683

Reviewed by Tim Nguyen.

iBooks was renamed to Apple Books.

https://www.apple.com/apple-books/
https://en.wikipedia.org/wiki/Apple_Books

* ReadMe.md:

Canonical link: https://commits.webkit.org/282234@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] c3b35f: Fix masonry-intrinsic-sizing-cols-002-expected.htm...

[Brandon Stewart]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c3b35fb1be6dbf9597c349e524558729054143fd
  
https://github.com/WebKit/WebKit/commit/c3b35fb1be6dbf9597c349e524558729054143fd
  Author: Brandon Stewart 
  Date:   2024-08-13 (Tue, 13 Aug 2024)

  Changed paths:
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/intrinsic-sizing/masonry-intrinsic-sizing-cols-002-expected.html
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/intrinsic-sizing/masonry-intrinsic-sizing-cols-002-ref.html

  Log Message:
  ---
  Fix masonry-intrinsic-sizing-cols-002-expected.html fixed + auto + fr scenario
https://bugs.webkit.org/show_bug.cgi?id=278059
rdar://problem/133793978

Reviewed by Sammy Gill.

In masonry, the indefinite items will be placed in every column during 
intrinsic sizing.
This will cause 'auto' and 'fr' to be resolved to 2ch.

* 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/intrinsic-sizing/masonry-intrinsic-sizing-cols-002-expected.html:
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/intrinsic-sizing/masonry-intrinsic-sizing-cols-002-ref.html:

Canonical link: https://commits.webkit.org/282216@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 1e6779: Add std::multimap to WebKit

[Brandon Stewart]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 1e6779c98ddb3a1ea0b6c90960de161e83d170dd
  
https://github.com/WebKit/WebKit/commit/1e6779c98ddb3a1ea0b6c90960de161e83d170dd
  Author: Brandon Stewart 
  Date:   2024-08-13 (Tue, 13 Aug 2024)

  Changed paths:
M Source/WTF/WTF.xcodeproj/project.pbxproj
M Source/WTF/wtf/CMakeLists.txt
A Source/WTF/wtf/StdMultimap.h

  Log Message:
  ---
  Add std::multimap to WebKit
https://bugs.webkit.org/show_bug.cgi?id=278025
rdar://problem/133769139

Reviewed by Yusuke Suzuki and Matthieu Dubet.

Expose std::multimap to WebKit as StdMultimap.
This data structure will be used in CSS Masonry.

* Source/WTF/WTF.xcodeproj/project.pbxproj:
* Source/WTF/wtf/CMakeLists.txt:
* Source/WTF/wtf/StdMultimap.h: Added.

Canonical link: https://commits.webkit.org/282196@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 5cdcca: [css-grid] Add FIXME about refactoring work to rem...

[Brandon Stewart]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 5cdcca7894c2c47dab457ce85721d8f927935c31
  
https://github.com/WebKit/WebKit/commit/5cdcca7894c2c47dab457ce85721d8f927935c31
  Author: Brandon Stewart 
  Date:   2024-08-02 (Fri, 02 Aug 2024)

  Changed paths:
M Source/WebCore/rendering/RenderGrid.h

  Log Message:
  ---
  [css-grid] Add FIXME about refactoring work to remove m_trackSizingAlgorithm 
from RenderGrid.h
https://bugs.webkit.org/show_bug.cgi?id=277497
rdar://problem/133003278

Reviewed by Sammy Gill.

Add FIXME to acknowledge needed work for a future refactor.

Sammy and I had a discussion over the last two days about removing 
m_trackSizingAlgorithm from RenderGrid.h and refactoring it to inside of 
layoutGrid and layoutMasonry.
This would allow a smaller scope of access to m_trackSizingAlgorithm and ensure 
that this object only survives during the layout step.
Several references to m_trackSizingAlgorithm are called deeply nested inside 
the layout functions, which would require propagation of object down the 
function stack.

* Source/WebCore/rendering/RenderGrid.h:

Canonical link: https://commits.webkit.org/281766@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] a7320f: [css-grid] Improve GridTrackSizingAlgorithm Archit...

[Brandon Stewart]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: a7320ffab3aeadbd0b27c09dbda273d679e2234f
  
https://github.com/WebKit/WebKit/commit/a7320ffab3aeadbd0b27c09dbda273d679e2234f
  Author: Brandon Stewart 
  Date:   2024-08-01 (Thu, 01 Aug 2024)

  Changed paths:
M Source/WebCore/rendering/GridTrackSizingAlgorithm.cpp
M Source/WebCore/rendering/GridTrackSizingAlgorithm.h
M Source/WebCore/rendering/RenderGrid.cpp

  Log Message:
  ---
  [css-grid] Improve GridTrackSizingAlgorithm Architecture
https://bugs.webkit.org/show_bug.cgi?id=277492
rdar://problem/132996992

Reviewed by Alan Baradlay.

We want to hide the setup step inside the run() function. The run() functions 
requires setup() to be called before executing.
It does not make sense to require the developer to know the setup() function 
must be called before calling run().

* Source/WebCore/rendering/GridTrackSizingAlgorithm.cpp:
(WebCore::GridTrackSizingAlgorithm::run):
* Source/WebCore/rendering/GridTrackSizingAlgorithm.h:
* Source/WebCore/rendering/RenderGrid.cpp:
(WebCore::RenderGrid::computeTrackSizesForDefiniteSize):
(WebCore::RenderGrid::computeTrackSizesForIndefiniteSize const):

Canonical link: https://commits.webkit.org/281727@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] a829f4: [masonry] Fix intrinsic sizing with fixed-size and...

[Brandon Stewart]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: a829f44a065e3bab573c8356f6e64e0f75895f37
  
https://github.com/WebKit/WebKit/commit/a829f44a065e3bab573c8356f6e64e0f75895f37
  Author: Brandon Stewart 
  Date:   2024-07-31 (Wed, 31 Jul 2024)

  Changed paths:
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/intrinsic-sizing/masonry-intrinsic-sizing-cols-007-expected.html
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/intrinsic-sizing/masonry-intrinsic-sizing-cols-007-ref.html
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/intrinsic-sizing/masonry-intrinsic-sizing-cols-007.html
M Source/WebCore/rendering/GridTrackSizingAlgorithm.cpp

  Log Message:
  ---
  [masonry] Fix intrinsic sizing with fixed-size and auto
https://bugs.webkit.org/show_bug.cgi?id=277382
rdar://problem/132849745

Reviewed by Sammy Gill.

We were not calculating auto sizes when there is a span and it
went outside of the track sizing range. This is due to masonry
trying to place all the indefinite items in each track, and since the span would
be outside the track range it would be skipped.

The solution is to try to shift the item's start and end to fit within the 
track.

* 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/intrinsic-sizing/masonry-intrinsic-sizing-cols-007-expected.html:
 Added.
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/intrinsic-sizing/masonry-intrinsic-sizing-cols-007-ref.html:
 Added.
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/intrinsic-sizing/masonry-intrinsic-sizing-cols-007.html:
 Added.
* Source/WebCore/rendering/GridTrackSizingAlgorithm.cpp:
(WebCore::GridTrackSizingAlgorithm::shouldExcludeGridItemForMasonryTrackSizing 
const):
* Source/WebCore/rendering/GridTrackSizingAlgorithm.h:

Canonical link: https://commits.webkit.org/281677@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] e71788: [masonry] Import WPT Tests

[Brandon Stewart]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: e717882187ca8e108481f8a87395bf648368c33e
  
https://github.com/WebKit/WebKit/commit/e717882187ca8e108481f8a87395bf648368c33e
  Author: Brandon Stewart 
  Date:   2024-07-25 (Thu, 25 Jul 2024)

  Changed paths:
M LayoutTests/TestExpectations
M LayoutTests/imported/w3c/resources/resource-files.json
R 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/intrinsic-sizing/masonry-intrinsic-sizing-001-expected.html
R 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/intrinsic-sizing/masonry-intrinsic-sizing-001-ref.html
R 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/intrinsic-sizing/masonry-intrinsic-sizing-001.html
R 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/intrinsic-sizing/masonry-intrinsic-sizing-002-expected.html
R 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/intrinsic-sizing/masonry-intrinsic-sizing-002-ref.html
R 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/intrinsic-sizing/masonry-intrinsic-sizing-002.html
R 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/intrinsic-sizing/masonry-intrinsic-sizing-003-expected.html
R 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/intrinsic-sizing/masonry-intrinsic-sizing-003-ref.html
R 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/intrinsic-sizing/masonry-intrinsic-sizing-003.html
R 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/intrinsic-sizing/masonry-intrinsic-sizing-004-expected.html
R 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/intrinsic-sizing/masonry-intrinsic-sizing-004-ref.html
R 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/intrinsic-sizing/masonry-intrinsic-sizing-004.html
R 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/intrinsic-sizing/masonry-intrinsic-sizing-005-expected.html
R 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/intrinsic-sizing/masonry-intrinsic-sizing-005-ref.html
R 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/intrinsic-sizing/masonry-intrinsic-sizing-005.html
R 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/intrinsic-sizing/masonry-intrinsic-sizing-006-expected.html
R 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/intrinsic-sizing/masonry-intrinsic-sizing-006-ref.html
R 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/intrinsic-sizing/masonry-intrinsic-sizing-006.html
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/intrinsic-sizing/masonry-intrinsic-sizing-cols-001-expected.html
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/intrinsic-sizing/masonry-intrinsic-sizing-cols-001-ref.html
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/intrinsic-sizing/masonry-intrinsic-sizing-cols-001.html
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/intrinsic-sizing/masonry-intrinsic-sizing-cols-002-expected.html
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/intrinsic-sizing/masonry-intrinsic-sizing-cols-002-ref.html
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/intrinsic-sizing/masonry-intrinsic-sizing-cols-002.html
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/intrinsic-sizing/masonry-intrinsic-sizing-cols-003-expected.html
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/intrinsic-sizing/masonry-intrinsic-sizing-cols-003-ref.html
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/intrinsic-sizing/masonry-intrinsic-sizing-cols-003.html
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/intrinsic-sizing/masonry-intrinsic-sizing-cols-004-expected.html
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/intrinsic-sizing/masonry-intrinsic-sizing-cols-004-ref.html
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/intrinsic-sizing/masonry-intrinsic-sizing-cols-004.html
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/intrinsic-sizing/masonry-intrinsic-sizing-cols-005-expected.html
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/intrinsic-sizing/masonry-intrinsic-sizing-cols-005-ref.html
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/intrinsic-sizing/masonry-intrinsic-sizing-cols-005.html

[webkit-changes] [WebKit/WebKit] edd20b: [css-grid] Split Grid and Masonry Implementation i...

[Brandon Stewart]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: edd20b55060cae41a9447146a25b92cf5e1d155d
  
https://github.com/WebKit/WebKit/commit/edd20b55060cae41a9447146a25b92cf5e1d155d
  Author: Brandon Stewart 
  Date:   2024-07-19 (Fri, 19 Jul 2024)

  Changed paths:
M Source/WebCore/rendering/GridTrackSizingAlgorithm.cpp
M Source/WebCore/rendering/GridTrackSizingAlgorithm.h

  Log Message:
  ---
  [css-grid] Split Grid and Masonry Implementation in resolveIntrinsicTrackSizes
https://bugs.webkit.org/show_bug.cgi?id=276831
rdar://problem/132103501

Reviewed by Sammy Gill.

Refactoring work to split up the implementations of resolveIntrinsicTrackSizes
and accumulateIntrinsicSizesForTrack.

Both of these implementations are constantly diverging based on optimizations I
have been working on. The Grid implementation is becoming more confusing to 
follow,
since it often does not need to care about the Masonry pieces.

Also, factored out handleInfinityGrowthLimit since it was just duplicating code 
that
was the exact same across implementations.

* Source/WebCore/rendering/GridTrackSizingAlgorithm.cpp:
(WebCore::GridTrackSizingAlgorithm::accumulateIntrinsicSizesForTrack):
(WebCore::GridTrackSizingAlgorithm::accumulateIntrinsicSizesForTrackMasonry):
(WebCore::GridTrackSizingAlgorithm::handleInfinityGrowthLimit):
(WebCore::GridTrackSizingAlgorithm::resolveIntrinsicTrackSizes):
(WebCore::GridTrackSizingAlgorithm::resolveIntrinsicTrackSizesMasonry):
(WebCore::GridTrackSizingAlgorithm::run):
* Source/WebCore/rendering/GridTrackSizingAlgorithm.h:

Canonical link: https://commits.webkit.org/281155@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] f6831e: [masonry] Optimize grid items with a span 1

[Brandon Stewart]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: f6831edd45a88907a4cf1d3d3d690338fb1db597
  
https://github.com/WebKit/WebKit/commit/f6831edd45a88907a4cf1d3d3d690338fb1db597
  Author: Brandon Stewart 
  Date:   2024-07-12 (Fri, 12 Jul 2024)

  Changed paths:
M Source/WebCore/rendering/GridTrackSizingAlgorithm.cpp
M Source/WebCore/rendering/GridTrackSizingAlgorithm.h

  Log Message:
  ---
  [masonry] Optimize grid items with a span 1
https://bugs.webkit.org/show_bug.cgi?id=276385
rdar://problem/131407028

Reviewed by Sammy Gill.

General Case: grouping auto-placed items by span size -> Nitems + Ntracks x 
Nspans
- compute aggregate items (Nitems)
- apply to tracks (Ntracks x Nspans)

This implements the algorithm for single track items. Items that span multiple 
tracks
and items that are 'fr' will be handled in a follow up patch.

Runtime on microbenchark was reduced from 1.2 seconds to 38 ms.
Benchmark tested 1000 columns with 'auto' and 10,000 grid items.
Tested on M1 Ultra.

* Source/WebCore/rendering/GridTrackSizingAlgorithm.cpp:
(WebCore::GridTrackSizingAlgorithm::accumulateIntrinsicSizesForTrack):
(WebCore::GridTrackSizingAlgorithm::resolveIntrinsicTrackSizes):
* Source/WebCore/rendering/GridTrackSizingAlgorithm.h:

Canonical link: https://commits.webkit.org/280919@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 69db44: [libpas] PGM Crash Testing: Align allocation to pa...

[Brandon Stewart]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 69db44623766e6e27c87f20d7cb5add5220d59e9
  
https://github.com/WebKit/WebKit/commit/69db44623766e6e27c87f20d7cb5add5220d59e9
  Author: Brandon Stewart 
  Date:   2024-07-10 (Wed, 10 Jul 2024)

  Changed paths:
M Source/JavaScriptCore/jsc.cpp

  Log Message:
  ---
  [libpas] PGM Crash Testing: Align allocation to page size
https://bugs.webkit.org/show_bug.cgi?id=276181
rdar://problem/13106

Reviewed by David Kilzer.

PGM will align pages left or right, so by allocating the entire length of the 
page
it will give the same result whether left or right aligned. This will make 
testing guard pages reliable again.

* Source/JavaScriptCore/jsc.cpp:
(crashPGMUAF):
(crashPGMUpperGuardPage):
(crashPGMLowerGuardPage):

Canonical link: https://commits.webkit.org/280836@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] dbefcf: Improve window.styleMedia Warning Message

[Brandon Stewart]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: dbefcff060c88cadac12b3cd6f366756d56fdf46
  
https://github.com/WebKit/WebKit/commit/dbefcff060c88cadac12b3cd6f366756d56fdf46
  Author: Brandon Stewart 
  Date:   2024-07-02 (Tue, 02 Jul 2024)

  Changed paths:
M 
LayoutTests/imported/w3c/web-platform-tests/WebIDL/ecmascript-binding/attributes-accessors-unique-function-objects-expected.txt
M Source/WebCore/css/StyleMedia.cpp

  Log Message:
  ---
  Improve window.styleMedia Warning Message
https://bugs.webkit.org/show_bug.cgi?id=276157
rdar://problem/131005713

Reviewed by Tim Nguyen.

Update the error message to remove mention of Firefox's support for this 
feature.
Web Developers have websites like Can I Use or other equivalents to check on 
feature support for browsers,
and the information we provide in the Web Inspector console may become out of 
date.

* 
LayoutTests/imported/w3c/web-platform-tests/WebIDL/ecmascript-binding/attributes-accessors-unique-function-objects-expected.txt:
* Source/WebCore/css/StyleMedia.cpp:
(WebCore::StyleMedia::StyleMedia):

Canonical link: https://commits.webkit.org/280612@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 3a4379: grid-within-flexbox-indefinite.html now passing

[Brandon Stewart]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 3a437945ebe2ebb453219f6a4d24f32a038a223c
  
https://github.com/WebKit/WebKit/commit/3a437945ebe2ebb453219f6a4d24f32a038a223c
  Author: Brandon Stewart 
  Date:   2024-07-01 (Mon, 01 Jul 2024)

  Changed paths:
M LayoutTests/TestExpectations

  Log Message:
  ---
  grid-within-flexbox-indefinite.html now passing
https://bugs.webkit.org/show_bug.cgi?id=276077
rdar://problem/130903429

Reviewed by Sammy Gill.

Test case was passing now when running layout tests.

* LayoutTests/TestExpectations:

Canonical link: https://commits.webkit.org/280552@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 569711: Update README to point to latest Windows build ins...

[Brandon Stewart]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 5697113ea4980e35b67af933b967862da6598837
  
https://github.com/WebKit/WebKit/commit/5697113ea4980e35b67af933b967862da6598837
  Author: Brandon Stewart 
  Date:   2024-06-29 (Sat, 29 Jun 2024)

  Changed paths:
M ReadMe.md

  Log Message:
  ---
  Update README to point to latest Windows build instructions
https://bugs.webkit.org/show_bug.cgi?id=276032
rdar://problem/130814076

Reviewed by Fujii Hironori.

Update ReadMe to point at latest Windows build instructions on docs.webkit.org.

* ReadMe.md:

Canonical link: https://commits.webkit.org/280508@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 6ec453: Remove unused headers in GridTrackSizingAlgorithm.cpp

[Brandon Stewart]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 6ec4530bac5ff1d9cd5717b10b137dc9cf50b42f
  
https://github.com/WebKit/WebKit/commit/6ec4530bac5ff1d9cd5717b10b137dc9cf50b42f
  Author: Brandon Stewart 
  Date:   2024-06-29 (Sat, 29 Jun 2024)

  Changed paths:
M Source/WebCore/rendering/GridTrackSizingAlgorithm.cpp

  Log Message:
  ---
  Remove unused headers in GridTrackSizingAlgorithm.cpp
https://bugs.webkit.org/show_bug.cgi?id=276021
rdar://problem/130786376

Reviewed by Sammy Gill.

Headers do not appear to be needed when compiling. Removing.

* Source/WebCore/rendering/GridTrackSizingAlgorithm.cpp:

Canonical link: https://commits.webkit.org/280499@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 267c22: Use a const & when when getting tracks in minSizeF...

[Brandon Stewart]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 267c225fb2d3c6ba94a3426f442a6dda40eecb2d
  
https://github.com/WebKit/WebKit/commit/267c225fb2d3c6ba94a3426f442a6dda40eecb2d
  Author: Brandon Stewart 
  Date:   2024-06-28 (Fri, 28 Jun 2024)

  Changed paths:
A PerformanceTests/Layout/auto-masonry-1000-columns-1-items.html
M Source/WebCore/rendering/GridTrackSizingAlgorithm.cpp

  Log Message:
  ---
  Use a const & when when getting tracks in minSizeForChild
https://bugs.webkit.org/show_bug.cgi?id=275972
rdar://problem/130728344

Reviewed by Sammy Gill.

We are doing unnecessary copies of GridTracks when grabbing the allTracks.

Based on the microbenchmark I wrote it reduced masonry layout from ~1 minute to 
~1 second.
Grid layout decreased from ~100 ms to ~30 ms.
Tested on M1 Ultra.

* PerformanceTests/Layout/auto-masonry-1000-columns-1-items.html: Added.
* Source/WebCore/rendering/GridTrackSizingAlgorithm.cpp:
(WebCore::GridTrackSizingAlgorithmStrategy::minSizeForChild const):

Canonical link: https://commits.webkit.org/280473@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 0146f7: libpas: Enable easier testing of PGM crashes

[Brandon Stewart]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 0146f7f3441f8d788963818d223665fc231c74ff
  
https://github.com/WebKit/WebKit/commit/0146f7f3441f8d788963818d223665fc231c74ff
  Author: Brandon Stewart 
  Date:   2024-06-27 (Thu, 27 Jun 2024)

  Changed paths:
M Source/JavaScriptCore/jsc.cpp
M Source/WTF/wtf/FastMalloc.cpp
M Source/WTF/wtf/FastMalloc.h
M Source/bmalloc/bmalloc/bmalloc.cpp
M Source/bmalloc/bmalloc/bmalloc.h
M 
Source/bmalloc/libpas/src/libpas/pas_probabilistic_guard_malloc_allocator.c
M 
Source/bmalloc/libpas/src/libpas/pas_probabilistic_guard_malloc_allocator.h

  Log Message:
  ---
  libpas: Enable easier testing of PGM crashes
https://bugs.webkit.org/show_bug.cgi?id=274863

Reviewed by David Kilzer.

Add crash test scenarios to enable automated testing of PGM crashes in libpas 
for ReportCrash.
JavaScriptCore is required to perform testing for ReportCrash, so I added it to 
the jsc binary.

The new options available are:
./jsc --crash-vm=PGMOOBLowerGuardPage
./jsc --crash-vm=PGMOOBUpperGuardPage
./jsc --crash-vm=PGMUAF

* Source/JavaScriptCore/jsc.cpp:
(printUsageStatement):
(CommandLine::parseArguments):
* Source/WTF/wtf/FastMalloc.cpp:
(WTF::forceEnablePGM):
* Source/WTF/wtf/FastMalloc.h:
* Source/bmalloc/libpas/src/libpas/pas_probabilistic_guard_malloc_allocator.c:
(pas_probabilistic_guard_malloc_initialize_pgm_as_enabled):
* Source/bmalloc/libpas/src/libpas/pas_probabilistic_guard_malloc_allocator.h:

Canonical link: https://commits.webkit.org/280443@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 6bb70d: computed-margin-values block-container-block-start...

[Brandon Stewart]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 6bb70d9ecad5d983bee746f380fd7e2f4ebcebcd
  
https://github.com/WebKit/WebKit/commit/6bb70d9ecad5d983bee746f380fd7e2f4ebcebcd
  Author: Brandon Stewart 
  Date:   2024-06-26 (Wed, 26 Jun 2024)

  Changed paths:
M LayoutTests/platform/ios/TestExpectations

  Log Message:
  ---
  computed-margin-values block-container-block-start-child-with-border and 
block-container-block-start-self-collapsing-nested are passing
https://bugs.webkit.org/show_bug.cgi?id=275076

Reviewed by Sammy Gill.

These two tests are passing on iOS now.

* LayoutTests/platform/ios/TestExpectations:

Canonical link: https://commits.webkit.org/280391@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 7a4bc6: Moving Masonry to preview

[Brandon Stewart]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 7a4bc6fdbf407f3b9a36b98fd915fad6aa4eb10c
  
https://github.com/WebKit/WebKit/commit/7a4bc6fdbf407f3b9a36b98fd915fad6aa4eb10c
  Author: Brandon Stewart 
  Date:   2024-05-01 (Wed, 01 May 2024)

  Changed paths:
M Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml

  Log Message:
  ---
  Moving Masonry to preview
https://bugs.webkit.org/show_bug.cgi?id=273564
rdar://problem/127378191

Reviewed by Brent Fulgham.

Moving Masonry state back to preview now that initial testing is complete.

* Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml:

Canonical link: https://commits.webkit.org/278247@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] ba9d66: MiniBrowser Build Fix w/ Release Builds

[Brandon Stewart]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: ba9d663c6686b5926899ff9897f597cea985a5f1
  
https://github.com/WebKit/WebKit/commit/ba9d663c6686b5926899ff9897f597cea985a5f1
  Author: Brandon Stewart 
  Date:   2024-04-23 (Tue, 23 Apr 2024)

  Changed paths:
M Tools/MiniBrowser/mac/AppDelegate.h
M Tools/MiniBrowser/mac/MiniBrowser_Prefix.pch
M Tools/MiniBrowser/mac/WK2BrowserWindowController.h

  Log Message:
  ---
  MiniBrowser Build Fix w/ Release Builds
https://bugs.webkit.org/show_bug.cgi?id=273140

Reviewed by Elliott Williams.

MiniBrowser was seeing certain headers multiple times due to includes.
This was causing a build failure on certain SDKs.

>From talking with Elliott, removing the #import webkit from the pch and moving
it to the select headers files resolved the problem.

* Tools/MiniBrowser/mac/AppDelegate.h:
* Tools/MiniBrowser/mac/MiniBrowser_Prefix.pch:
* Tools/MiniBrowser/mac/WK2BrowserWindowController.h:

Canonical link: https://commits.webkit.org/277909@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] e004ae: [css-grid] Rebase Masonry WPT Tests

[Brandon Stewart]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: e004ae642c29d20e9684279124065f07a98883fb
  
https://github.com/WebKit/WebKit/commit/e004ae642c29d20e9684279124065f07a98883fb
  Author: Brandon Stewart 
  Date:   2024-04-20 (Sat, 20 Apr 2024)

  Changed paths:
M LayoutTests/TestExpectations
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/WEB_FEATURES.yml
R 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/align-content/masonry-align-content-001-expected.html
R 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/align-content/masonry-align-content-001-ref.html
R 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/align-content/masonry-align-content-001.html
R 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/align-content/masonry-align-content-002-expected.html
R 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/align-content/masonry-align-content-002-ref.html
R 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/align-content/masonry-align-content-002.html
R 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/align-content/masonry-align-content-003-expected.html
R 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/align-content/masonry-align-content-003-ref.html
R 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/align-content/masonry-align-content-003.html
R 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/align-content/masonry-align-content-004-expected.html
R 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/align-content/masonry-align-content-004-ref.html
R 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/align-content/masonry-align-content-004.html
R 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/align-content/w3c-import.log
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/alignment/masonry-align-content-001-expected.html
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/alignment/masonry-align-content-001.html
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/alignment/masonry-align-content-002-expected.html
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/alignment/masonry-align-content-002.html
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/alignment/masonry-align-content-003-expected.html
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/alignment/masonry-align-content-003.html
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/alignment/masonry-align-content-004-expected.html
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/alignment/masonry-align-content-004.html
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/alignment/masonry-justify-content-001-expected.html
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/alignment/masonry-justify-content-001.html
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/alignment/masonry-justify-content-002-expected.html
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/alignment/masonry-justify-content-002.html
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/alignment/masonry-justify-content-003-expected.html
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/alignment/masonry-justify-content-003.html
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/alignment/masonry-justify-content-004-expected.html
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/alignment/masonry-justify-content-004.html
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/alignment/w3c-import.log
R 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/baseline/masonry-grid-item-content-baseline-001-ref.html
R 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/baseline/masonry-grid-item-self-baseline-001-ref.html
R 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/baseline/masonry-grid-item-self-baseline-002a-ref.html
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/baseline/masonry-grid-item-self-baseline-002a.html
R 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/baseline/masonry-grid-item-self-baseline-002b-ref.html
M 
LayoutTests/imported/w3c/web-platform

[webkit-changes] [WebKit/WebKit] 7766d8: Remove shouldAlwaysUsePluginDocument

[Brandon Stewart]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 7766d8c67414d29385d2c60a7c2befa620e8feb0
  
https://github.com/WebKit/WebKit/commit/7766d8c67414d29385d2c60a7c2befa620e8feb0
  Author: Brandon Stewart 
  Date:   2024-04-18 (Thu, 18 Apr 2024)

  Changed paths:
M Source/WebCore/dom/DOMImplementation.cpp
M Source/WebCore/loader/DocumentWriter.cpp
M Source/WebCore/loader/LocalFrameLoaderClient.h
M Source/WebCore/loader/SubframeLoader.cpp

  Log Message:
  ---
  Remove shouldAlwaysUsePluginDocument
https://bugs.webkit.org/show_bug.cgi?id=272854

Reviewed by Alex Christensen.

This function always returns false now, and does not use the parameter input 
given at all.

* Source/WebCore/dom/DOMImplementation.cpp:
(WebCore::DOMImplementation::createDocument):
* Source/WebCore/loader/DocumentWriter.cpp:
(WebCore::DocumentWriter::createDocument):
* Source/WebCore/loader/LocalFrameLoaderClient.h:
* Source/WebCore/loader/SubframeLoader.cpp:
(WebCore::FrameLoader::SubframeLoader::shouldUsePlugin):

Canonical link: https://commits.webkit.org/277692@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 118097: PDF Plugin should load its inline styles regardles...

[Brandon Stewart]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 118097374f64baa854137fa9b507f83270ff4b67
  
https://github.com/WebKit/WebKit/commit/118097374f64baa854137fa9b507f83270ff4b67
  Author: Brandon Stewart 
  Date:   2024-04-18 (Thu, 18 Apr 2024)

  Changed paths:
A LayoutTests/pdf/fullscreen-expected.txt
A LayoutTests/pdf/fullscreen.html
A LayoutTests/pdf/resources/fullscreen.pdf
A LayoutTests/platform/gtk/pdf/fullscreen-expected.txt
A LayoutTests/platform/ios/pdf/fullscreen-expected.txt
A LayoutTests/platform/mac-wk1/pdf/fullscreen-expected.txt
A LayoutTests/platform/wpe/pdf/fullscreen-expected.txt
M Source/WebCore/dom/InlineStyleSheetOwner.cpp

  Log Message:
  ---
  PDF Plugin should load its inline styles regardless of CSP
https://bugs.webkit.org/show_bug.cgi?id=272689
rdar://125796665

Reviewed by Alex Christensen.

We embed styles when rendering a pdf file that should not be ignored if CSP is 
activated (particularly around style sheets),
and will lead to a poor viewing experience for the user.

In addition, Anne pointed out that CSP is not defined for PDF documents, and 
thus we should ignore the checks.

* LayoutTests/pdf/fullscreen-expected.txt: Added.
* LayoutTests/pdf/fullscreen.html: Added.
* LayoutTests/pdf/resources/fullscreen.pdf: Added.
* LayoutTests/platform/gtk/pdf/fullscreen-expected.txt: Added.
* LayoutTests/platform/ios/pdf/fullscreen-expected.txt: Added.
* LayoutTests/platform/mac-wk1/pdf/fullscreen-expected.txt: Added.
* LayoutTests/platform/wpe/pdf/fullscreen-expected.txt: Added.
* Source/WebCore/dom/InlineStyleSheetOwner.cpp:
(WebCore::InlineStyleSheetOwner::createSheet):

Canonical link: https://commits.webkit.org/277683@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 58b046: Masonry isn't performing intrinsic sizing correctly.

[Brandon Stewart]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 58b046421e15c1f20ea7cc5dc0e64bd58e11cd92
  
https://github.com/WebKit/WebKit/commit/58b046421e15c1f20ea7cc5dc0e64bd58e11cd92
  Author: Brandon Stewart 
  Date:   2024-04-11 (Thu, 11 Apr 2024)

  Changed paths:
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/align-content/masonry-align-content-003-expected.html
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/align-content/masonry-align-content-003-ref.html
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/masonry-grid-template-columns-computed-withcontent.html
M Source/WebCore/rendering/Grid.cpp
M Source/WebCore/rendering/Grid.h
M Source/WebCore/rendering/GridTrackSizingAlgorithm.cpp
M Source/WebCore/rendering/GridTrackSizingAlgorithm.h

  Log Message:
  ---
  Masonry isn't performing intrinsic sizing correctly.
https://bugs.webkit.org/show_bug.cgi?id=270663
rdar://problem/124240255

Reviewed by Sammy Gill.

Indefinite items from other intrinsic tracks were not being taken
into account during the calculation.

masonry-align-content-003-expected-ref/expected.html:
Updated to exact pixel lengths, since 'auto' can have different lengths in grid.

masonry-grid-template-columns-computed-withcontent.html:
Updated to have all intrinsic tracks being the same width.

* 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/align-content/masonry-align-content-003-expected.html:
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/align-content/masonry-align-content-003-ref.html:
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/masonry-grid-template-columns-computed-withcontent.html:
* Source/WebCore/rendering/Grid.cpp:
(WebCore::GridIterator::createForSubgrid):
* Source/WebCore/rendering/Grid.h:
* Source/WebCore/rendering/GridTrackSizingAlgorithm.cpp:
(WebCore::IndefiniteSizeStrategy::accumulateFlexFraction const):
(WebCore::GridTrackSizingAlgorithm::accumulateIntrinsicSizesForTrack):
(WebCore::GridTrackSizingAlgorithm::resolveIntrinsicTrackSizes):
* Source/WebCore/rendering/GridTrackSizingAlgorithm.h:

Canonical link: https://commits.webkit.org/277403@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] cd0837: [css-grid] Small cleanup patch

[Brandon Stewart]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: cd08370c221449e0dcd9e8af7c32550d710c00a5
  
https://github.com/WebKit/WebKit/commit/cd08370c221449e0dcd9e8af7c32550d710c00a5
  Author: Brandon Stewart 
  Date:   2024-04-10 (Wed, 10 Apr 2024)

  Changed paths:
M Source/WebCore/rendering/GridTrackSizingAlgorithm.cpp
M Source/WebCore/rendering/RenderGrid.cpp

  Log Message:
  ---
  [css-grid] Small cleanup patch
https://bugs.webkit.org/show_bug.cgi?id=272458

Reviewed by Tim Nguyen.

A few things I have noticed when working in Grid these last few weeks.

* Source/WebCore/rendering/GridTrackSizingAlgorithm.cpp:
(WebCore::GridTrackSizingAlgorithm::rawGridTrackSize const):
(WebCore::distributeItemIncurredIncreases):
* Source/WebCore/rendering/RenderGrid.cpp:
(WebCore::RenderGrid::computeIntrinsicLogicalWidths const):

Canonical link: https://commits.webkit.org/277316@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 231bbe: [css-grid] Masonry cleanup TestExpectations

[Brandon Stewart]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 231bbe48d42193210bc04d64f8324d6aa4426448
  
https://github.com/WebKit/WebKit/commit/231bbe48d42193210bc04d64f8324d6aa4426448
  Author: Brandon Stewart 
  Date:   2024-04-10 (Wed, 10 Apr 2024)

  Changed paths:
M LayoutTests/TestExpectations

  Log Message:
  ---
  [css-grid] Masonry cleanup TestExpectations
https://bugs.webkit.org/show_bug.cgi?id=272460

Reviewed by Tim Nguyen.

Organize the test cases better based on failure type.

* LayoutTests/TestExpectations:

Canonical link: https://commits.webkit.org/277314@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 804619: [css-grid] Enable masonry feature flag

[Brandon Stewart]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 8046191c7d94629c89f5abf4ea436b340a0ec721
  
https://github.com/WebKit/WebKit/commit/8046191c7d94629c89f5abf4ea436b340a0ec721
  Author: Brandon Stewart 
  Date:   2024-02-14 (Wed, 14 Feb 2024)

  Changed paths:
M Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml

  Log Message:
  ---
  [css-grid] Enable masonry feature flag
https://bugs.webkit.org/show_bug.cgi?id=247074
rdar://101595681

Reviewed by Tim Nguyen and Brent Fulgham.

Enable masonry by default on platforms.

* Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml:

Canonical link: https://commits.webkit.org/274661@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] bf22d1: [masonry] Incorrect Spec Section

[Brandon Stewart]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: bf22d1dad1df05ffd32b47f63639733cae0aa8cf
  
https://github.com/WebKit/WebKit/commit/bf22d1dad1df05ffd32b47f63639733cae0aa8cf
  Author: Brandon Stewart 
  Date:   2024-01-26 (Fri, 26 Jan 2024)

  Changed paths:
M Source/WebCore/rendering/GridMasonryLayout.cpp

  Log Message:
  ---
  [masonry] Incorrect Spec Section
https://bugs.webkit.org/show_bug.cgi?id=268151

Reviewed by Sammy Gill.

During the spec update to Masonry, the spec section numbers changed.
Fix an issue with referencing the wrong section now.

* Source/WebCore/rendering/GridMasonryLayout.cpp:
(WebCore::GridMasonryLayout::performMasonryPlacement):

Canonical link: https://commits.webkit.org/273565@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 7719c4: [masonry] Update to modern track sizing algorithm ...

[Brandon Stewart]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 7719c4262533e0ce345feda9d30c9b399ec4efbd
  
https://github.com/WebKit/WebKit/commit/7719c4262533e0ce345feda9d30c9b399ec4efbd
  Author: Brandon Stewart 
  Date:   2024-01-25 (Thu, 25 Jan 2024)

  Changed paths:
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/gap/masonry-gap-001-expected.html
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/gap/masonry-gap-001-ref.html
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/gap/masonry-gap-001.html
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/track-sizing/masonry-track-sizing-overflow-left-side-expected.html
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/track-sizing/masonry-track-sizing-overflow-left-side-ref.html
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/track-sizing/masonry-track-sizing-overflow-right-side-expected.html
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/track-sizing/masonry-track-sizing-overflow-right-side-ref.html
M Source/WebCore/rendering/GridTrackSizingAlgorithm.cpp

  Log Message:
  ---
  [masonry] Update to modern track sizing algorithm during accumulating track 
sizes
https://bugs.webkit.org/show_bug.cgi?id=268050

Reviewed by Sammy Gill.

Update to the new track sizing algorithm. All elements participate that are 
definite inside the track,
and those that are indefinite.

This patch only handles the algorithm. Another patch will handle placing all 
indefinite items across
all intrinsic tracks.

Test Case Updates:

masonry-track-sizing-overflow-left/right-side:
These test cases were built off the idea of the old track sizing algorithm 
where only the first track determined the
column size. Under the new algorithm all items now contribute; therefore the 
bottom item extends the track an extra 50px.

masonry-gap-001:
Simplified test case to focus on the gap.
Updated the grid-columns for items to ensure that other tracks would not affect 
the 2nd column.

* 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/gap/masonry-gap-001-expected.html:
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/gap/masonry-gap-001-ref.html:
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/gap/masonry-gap-001.html:
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/track-sizing/masonry-track-sizing-overflow-left-side-expected.html:
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/track-sizing/masonry-track-sizing-overflow-left-side-ref.html:
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/track-sizing/masonry-track-sizing-overflow-right-side-expected.html:
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/track-sizing/masonry-track-sizing-overflow-right-side-ref.html:
* Source/WebCore/rendering/GridTrackSizingAlgorithm.cpp:
(WebCore::GridTrackSizingAlgorithm::accumulateIntrinsicSizesForTrack):

Canonical link: https://commits.webkit.org/273551@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] a9ab65: [grid][masonry] Rename performGridItemsPreLayout t...

[Brandon Stewart]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: a9ab65d440f73841e7d9fa0dccc8adf6515137fd
  
https://github.com/WebKit/WebKit/commit/a9ab65d440f73841e7d9fa0dccc8adf6515137fd
  Author: Brandon Stewart 
  Date:   2024-01-25 (Thu, 25 Jan 2024)

  Changed paths:
M Source/WebCore/rendering/GridTrackSizingAlgorithm.cpp
M Source/WebCore/rendering/RenderGrid.cpp
M Source/WebCore/rendering/RenderGrid.h

  Log Message:
  ---
  [grid][masonry] Rename performGridItemsPreLayout to 
performPreLayoutForGridItems
https://bugs.webkit.org/show_bug.cgi?id=268052

Reviewed by Sammy Gill.

Give the function a better name. It was confusingly worded before.

* Source/WebCore/rendering/GridTrackSizingAlgorithm.cpp:
(WebCore::GridTrackSizingAlgorithm::canParticipateInBaselineAlignment const):
* Source/WebCore/rendering/RenderGrid.cpp:
(WebCore::RenderGrid::layoutGrid):
(WebCore::RenderGrid::layoutMasonry):
(WebCore::RenderGrid::computeIntrinsicLogicalWidths const):
(WebCore::RenderGrid::performPreLayoutForGridItems const):
(WebCore::RenderGrid::performGridItemsPreLayout const): Deleted.
* Source/WebCore/rendering/RenderGrid.h:

Canonical link: https://commits.webkit.org/273500@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 381645: [masonry] Expose grid items positions and sizes to...

[Brandon Stewart]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 3816458b86b6fc9a5c62f8dc1d3e96b5498ec554
  
https://github.com/WebKit/WebKit/commit/3816458b86b6fc9a5c62f8dc1d3e96b5498ec554
  Author: Brandon Stewart 
  Date:   2024-01-19 (Fri, 19 Jan 2024)

  Changed paths:
M Source/WebCore/rendering/RenderGrid.cpp
M Source/WebCore/rendering/RenderGrid.h

  Log Message:
  ---
  [masonry] Expose grid items positions and sizes to Web Inspector
https://bugs.webkit.org/show_bug.cgi?id=267736
rdar://problem/121219933

Reviewed by Sammy Gill.

Masonry differs from Grid in only having one axis. This does not allow simple 
drawing
straight lines. The Web Inspector can instead draw boxes around each item, 
which this patch
is exposing in a simpler format.

This patch is not exclusive to masonry and can be used for all returning all 
grid items
layout rects.

* Source/WebCore/rendering/RenderGrid.cpp:
(WebCore::RenderGrid::gridItemsLayoutRects):
* Source/WebCore/rendering/RenderGrid.h:

Canonical link: https://commits.webkit.org/273232@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 294802: Grammar cleanup in GridTrackSizingAlgorithm

[Brandon Stewart]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 294802b072ac0e4f1b7702bfb117419d0a717640
  
https://github.com/WebKit/WebKit/commit/294802b072ac0e4f1b7702bfb117419d0a717640
  Author: Brandon Stewart 
  Date:   2024-01-19 (Fri, 19 Jan 2024)

  Changed paths:
M Source/WebCore/rendering/GridTrackSizingAlgorithm.h

  Log Message:
  ---
  Grammar cleanup in GridTrackSizingAlgorithm
https://bugs.webkit.org/show_bug.cgi?id=267769
rdar://problem/121260788

Reviewed by Sammy Gill.

Small grammar fixes that I noticed a while back, but have not had a chance to 
address yet.

* Source/WebCore/rendering/GridTrackSizingAlgorithm.h:

Canonical link: https://commits.webkit.org/273227@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 051dfd: [masonry] Remove unused function itemGridAreaStart...

[Brandon Stewart]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 051dfdbae48ea4d9914fcaeac3a40517c350e14a
  
https://github.com/WebKit/WebKit/commit/051dfdbae48ea4d9914fcaeac3a40517c350e14a
  Author: Brandon Stewart 
  Date:   2024-01-19 (Fri, 19 Jan 2024)

  Changed paths:
M Source/WebCore/rendering/GridMasonryLayout.h

  Log Message:
  ---
  [masonry] Remove unused function itemGridAreaStartsAtFirstLine
https://bugs.webkit.org/show_bug.cgi?id=267767
rdar://problem/121259639

Reviewed by Sammy Gill.

Remove unused function. It is not needed anymore.

* Source/WebCore/rendering/GridMasonryLayout.h:
(WebCore::GridMasonryLayout::itemGridAreaStartsAtFirstLine): Deleted.

Canonical link: https://commits.webkit.org/273226@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] d3ed62: [css-grid] Fix broken link in RenderGrid

[Brandon Stewart]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: d3ed6221dc410ffaaac9adec51f019242ebb3c36
  
https://github.com/WebKit/WebKit/commit/d3ed6221dc410ffaaac9adec51f019242ebb3c36
  Author: Brandon Stewart 
  Date:   2023-12-18 (Mon, 18 Dec 2023)

  Changed paths:
M Source/WebCore/rendering/RenderGrid.cpp

  Log Message:
  ---
  [css-grid] Fix broken link in RenderGrid
https://bugs.webkit.org/show_bug.cgi?id=266585

Reviewed by Tim Nguyen.

Link to spec was broken; fixed it.

* Source/WebCore/rendering/RenderGrid.cpp:
(WebCore::RenderGrid::placeSpecifiedMajorAxisItemsOnGrid):

Canonical link: https://commits.webkit.org/272232@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 5f45e4: [masonry] Remove support for special first track h...

[Brandon Stewart]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 5f45e4707561fd2dce89400f9a0acd5f7568d856
  
https://github.com/WebKit/WebKit/commit/5f45e4707561fd2dce89400f9a0acd5f7568d856
  Author: Brandon Stewart 
  Date:   2023-12-08 (Fri, 08 Dec 2023)

  Changed paths:
M LayoutTests/TestExpectations
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/item-placement/masonry-item-placement-001-expected.html
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/item-placement/masonry-item-placement-001-ref.html
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/item-placement/masonry-item-placement-001.html
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/item-placement/masonry-item-placement-002.html
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/item-placement/masonry-item-placement-003.html
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/order/masonry-order-001-expected.html
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/order/masonry-order-001-ref.html
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/order/masonry-order-002-expected.html
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/order/masonry-order-002-ref.html
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/order/masonry-order-002.html
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/track-sizing/masonry-track-sizing-explicit-block.html
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/track-sizing/masonry-track-sizing-span-row.html
M Source/WebCore/rendering/GridMasonryLayout.cpp
M Source/WebCore/rendering/GridMasonryLayout.h

  Log Message:
  ---
  [masonry] Remove support for special first track handling
https://bugs.webkit.org/show_bug.cgi?id=265682

Reviewed by Sammy Gill.

Remove support for first tracks from CSS Masonry.

Added several test cases to test expectations.
These are outside the scope of this patch.

* LayoutTests/TestExpectations:
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/item-placement/masonry-item-placement-001-expected.html:
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/item-placement/masonry-item-placement-001-ref.html:
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/item-placement/masonry-item-placement-001.html:
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/item-placement/masonry-item-placement-002.html:
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/item-placement/masonry-item-placement-003.html:
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/order/masonry-order-001-expected.html:
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/order/masonry-order-001-ref.html:
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/order/masonry-order-002-expected.html:
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/order/masonry-order-002-ref.html:
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/order/masonry-order-002.html:
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/track-sizing/masonry-track-sizing-explicit-block.html:
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/track-sizing/masonry-track-sizing-span-row.html:
* Source/WebCore/rendering/GridMasonryLayout.cpp:
(WebCore::GridMasonryLayout::performMasonryPlacement):
(WebCore::GridMasonryLayout::collectMasonryItems):
(WebCore::GridMasonryLayout::addItemsToFirstTrack): Deleted.
* Source/WebCore/rendering/GridMasonryLayout.h:

Canonical link: https://commits.webkit.org/271757@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] d75147: Bad jsCast<>() in copyDataFromJSArrayToBuses() in ...

[Brandon Stewart]

Notify::No
instead of SynchronouslyNotify::Yes. Note that in the spec [1], the only 
scenario in which this flag
is set to yes is when the author script calls finish() on an Animation object.

For (3), (4), and (5), this PR makes these actions asynchronous by scheduling a 
task / microtask
instead of synchronously rejecting promises.

[1] 
https://drafts.csswg.org/web-animations-1/#update-an-animations-finished-state

Based on original patch by Ryosuke Niwa.

* 
LayoutTests/animations/resolve-animation-should-not-execute-scripts-expected.txt:
 Added.
* LayoutTests/animations/resolve-animation-should-not-execute-scripts.html: 
Added.

* Source/WebCore/Modules/paymentrequest/PaymentRequest.cpp:
(WebCore::PaymentRequest::~PaymentRequest): Now allows pending activity to 
exist when the associated
script execution context had been stopped.
(WebCore::PaymentRequest::stop): Don't try to settle the promise in the middle 
of stopping this
active DOM object.
(WebCore::PaymentRequest::suspend): Ditto for suspension. Schedule a task to 
settle promise instead.

* Source/WebCore/Modules/paymentrequest/PaymentResponse.cpp:
(WebCore::PaymentResponse::~PaymentResponse): Now allows pending activity to 
exist when
the associated script execution context had been stopped.
(WebCore::PaymentResponse::suspend): Don't try to settle the promise in the 
middle of stopping this
active DOM object.

* Source/WebCore/Modules/webaudio/OfflineAudioContext.cpp:
(WebCore::OfflineAudioContext::uninitialize): Don't reject the promise when the 
active DOM objects
had already been stopped.

* Source/WebCore/animation/WebAnimation.cpp:
(WebCore::WebAnimation::cancel): Reject the finished promise in a newly 
scheduled task instead of
synchronously rejecting it, which would result in script execution.
(WebCore::WebAnimation::resolve): Resolve the promise asynchronously.

* Source/WebCore/bindings/js/JSDOMPromiseDeferred.cpp:
(WebCore::DeferredPromise::callFunction): Added a release assertion.
* Source/WebCore/dom/TaskSource.h:

Originally-landed-as: 265870.536@safari-7616-branch (6d865c4bf3da). 
rdar://117810274
Canonical link: https://commits.webkit.org/270122@main


  Commit: eb3a8c2925c527c15ac432c60457d5d592be71c3
  
https://github.com/WebKit/WebKit/commit/eb3a8c2925c527c15ac432c60457d5d592be71c3
  Author: Brandon Stewart 
  Date:   2023-11-02 (Thu, 02 Nov 2023)

  Changed paths:
M Source/WebCore/crypto/SubtleCrypto.cpp

  Log Message:
  ---
  SubtleCrypto:wrapKey ensure promise is not garbage collected
https://bugs.webkit.org/show_bug.cgi?id=261519
rdar://115349445

Reviewed by Tim Nguyen.

We need to ensure that the promise always remains alive when in use.
Adding a RefPtr guarantees that it will not be garbage collected.

* Source/WebCore/crypto/SubtleCrypto.cpp:
(WebCore::SubtleCrypto::wrapKey):

Originally-landed-as: 8e9332694594. rdar://117810508
Canonical link: https://commits.webkit.org/270123@main


Compare: https://github.com/WebKit/WebKit/compare/77c606018747...eb3a8c2925c5
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 66c541: Re-baseline Masonry Tests for Removed Align / Just...

[Brandon Stewart]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 66c541bb831fd664d585a6817b463f4f3e825ef3
  
https://github.com/WebKit/WebKit/commit/66c541bb831fd664d585a6817b463f4f3e825ef3
  Author: Brandon Stewart 
  Date:   2023-10-10 (Tue, 10 Oct 2023)

  Changed paths:
M LayoutTests/TestExpectations
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/baseline/masonry-grid-item-self-baseline-002a.html
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/baseline/masonry-grid-item-self-baseline-002b.html
R 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/fragmentation/masonry-fragmentation-004-expected.html
R 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/fragmentation/masonry-fragmentation-004-ref.html
R 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/fragmentation/masonry-fragmentation-004.html
R 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/fragmentation/masonry-fragmentation-005-expected.html
R 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/fragmentation/masonry-fragmentation-005-ref.html
R 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/fragmentation/masonry-fragmentation-005.html
R 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/fragmentation/masonry-fragmentation-006-expected.html
R 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/fragmentation/masonry-fragmentation-006-ref.html
R 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/fragmentation/masonry-fragmentation-006.html

  Log Message:
  ---
  Re-baseline Masonry Tests for Removed Align / Justify Tracks
https://bugs.webkit.org/show_bug.cgi?id=262936


Reviewed by Tim Nguyen.

Re-baseline Masonry Tests based on the removal of align / justify tracks 
feature.

See commit in WPT
https://github.com/web-platform-tests/wpt/commit/336dd49ca503585ce8aa060380561ef9fc480282

* LayoutTests/TestExpectations:
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/baseline/masonry-grid-item-self-baseline-002a.html:
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/baseline/masonry-grid-item-self-baseline-002b.html:
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/fragmentation/masonry-fragmentation-004-expected.html:
 Removed.
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/fragmentation/masonry-fragmentation-004-ref.html:
 Removed.
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/fragmentation/masonry-fragmentation-004.html:
 Removed.
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/fragmentation/masonry-fragmentation-005-expected.html:
 Removed.
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/fragmentation/masonry-fragmentation-005-ref.html:
 Removed.
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/fragmentation/masonry-fragmentation-005.html:
 Removed.
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/fragmentation/masonry-fragmentation-006-expected.html:
 Removed.
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/fragmentation/masonry-fragmentation-006-ref.html:
 Removed.
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/fragmentation/masonry-fragmentation-006.html:
 Removed.

Canonical link: https://commits.webkit.org/269147@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] c9c17f: Remove Masonry align-tracks and justify-tracks Par...

[Brandon Stewart]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c9c17fb7f1f9fd36e14f14f8683cff034aaaf5d6
  
https://github.com/WebKit/WebKit/commit/c9c17fb7f1f9fd36e14f14f8683cff034aaaf5d6
  Author: Brandon Stewart 
  Date:   2023-10-06 (Fri, 06 Oct 2023)

  Changed paths:
M LayoutTests/imported/w3c/resources/resource-files.json
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-cascade/all-prop-revert-layer-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-cascade/all-prop-revert-layer.html
M 
LayoutTests/platform/gtk/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt
M 
LayoutTests/platform/ios-wk2/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt
M 
LayoutTests/platform/ipad/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt
M 
LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt
M 
LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/css/css-cascade/all-prop-revert-layer-expected.txt
M 
LayoutTests/platform/wpe/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt
M Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml
M Source/WebCore/animation/CSSPropertyAnimation.cpp
M Source/WebCore/css/CSSProperties.json
M Source/WebCore/css/CSSValueKeywords.in
M Source/WebCore/css/ComputedStyleExtractor.cpp
M Source/WebCore/css/parser/CSSPropertyParser.cpp
M Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp
M Source/WebCore/css/parser/CSSPropertyParserHelpers.h
M Source/WebCore/rendering/style/RenderStyle.h
M Source/WebCore/rendering/style/RenderStyleInlines.h
M Source/WebCore/rendering/style/RenderStyleSetters.h
M Source/WebCore/rendering/style/StyleGridData.cpp
M Source/WebCore/rendering/style/StyleGridData.h

  Log Message:
  ---
  Remove Masonry align-tracks and justify-tracks Parsing Support
https://bugs.webkit.org/show_bug.cgi?id=262731
rdar://problem/116540667

Reviewed by Tim Nguyen.

Remove CSS Parsing code for align-tracks and justify-tracks.
This is not supported anymore in Masonry.

* LayoutTests/imported/w3c/resources/resource-files.json:
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-cascade/all-prop-revert-layer-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-cascade/all-prop-revert-layer.html:
* 
LayoutTests/platform/gtk/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt:
* 
LayoutTests/platform/ios-wk2/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt:
* 
LayoutTests/platform/ipad/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt:
* 
LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt:
* 
LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/css/css-cascade/all-prop-revert-layer-expected.txt:
* 
LayoutTests/platform/wpe/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt:
* Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml:
* Source/WebCore/animation/CSSPropertyAnimation.cpp:
(WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap):
* Source/WebCore/css/CSSProperties.json:
* Source/WebCore/css/CSSValueKeywords.in:
* Source/WebCore/css/ComputedStyleExtractor.cpp:
(WebCore::ComputedStyleExtractor::valueForPropertyInStyle const):
* Source/WebCore/css/parser/CSSPropertyParser.cpp:
(WebCore::initialValueForLonghand):
* Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp:
(WebCore::CSSPropertyParserHelpers::consumeAlignTracks): Deleted.
(WebCore::CSSPropertyParserHelpers::consumeJustifyTracks): Deleted.
* Source/WebCore/css/parser/CSSPropertyParserHelpers.h:
* Source/WebCore/rendering/style/RenderStyle.h:
* Source/WebCore/rendering/style/RenderStyleInlines.h:
(WebCore::RenderStyle::alignSelf const):
(WebCore::RenderStyle::inheritedCustomProperties const):
(WebCore::RenderStyle::initialJustifyItems):
(WebCore::RenderStyle::justifySelf const):
(WebCore::RenderStyle::alignTracks const): Deleted.
(WebCore::RenderStyle::initialAlignTracks): Deleted.
(WebCore::RenderStyle::initialJustifyTracks): Deleted.
(WebCore::RenderStyle::justifyTracks const): Deleted.
* Source/WebCore/rendering/style/RenderStyleSetters.h:
(WebCore::RenderStyle::setAlignSelfPosition):
(WebCore::RenderStyle::setJustifySelfPosition):
(WebCore::RenderStyle::setAlignTracks): Deleted.
(WebCore::RenderStyle::setJustifyTracks): Deleted.
* Source/WebCore/rendering/style/StyleGridData.cpp:
(WebCore::StyleGridData::StyleGridData):
* Source/WebCore/rendering/style/StyleGridData.h

[webkit-changes] [WebKit/WebKit] 16408a: Remove Masonry Align and Justify Tracks Test Cases

[Brandon Stewart]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 16408a184624c8f2e25382a39498b09766f38335
  
https://github.com/WebKit/WebKit/commit/16408a184624c8f2e25382a39498b09766f38335
  Author: Brandon Stewart 
  Date:   2023-10-05 (Thu, 05 Oct 2023)

  Changed paths:
M LayoutTests/TestExpectations
R 
LayoutTests/imported/w3c/web-platform-tests/css/css-align/parsing/align-tracks-computed-expected.txt
R 
LayoutTests/imported/w3c/web-platform-tests/css/css-align/parsing/align-tracks-computed.html
R 
LayoutTests/imported/w3c/web-platform-tests/css/css-align/parsing/align-tracks-invalid-expected.txt
R 
LayoutTests/imported/w3c/web-platform-tests/css/css-align/parsing/align-tracks-invalid.html
R 
LayoutTests/imported/w3c/web-platform-tests/css/css-align/parsing/align-tracks-valid-expected.txt
R 
LayoutTests/imported/w3c/web-platform-tests/css/css-align/parsing/align-tracks-valid.html
R 
LayoutTests/imported/w3c/web-platform-tests/css/css-align/parsing/justify-tracks-computed-expected.txt
R 
LayoutTests/imported/w3c/web-platform-tests/css/css-align/parsing/justify-tracks-computed.html
R 
LayoutTests/imported/w3c/web-platform-tests/css/css-align/parsing/justify-tracks-invalid-expected.txt
R 
LayoutTests/imported/w3c/web-platform-tests/css/css-align/parsing/justify-tracks-invalid.html
R 
LayoutTests/imported/w3c/web-platform-tests/css/css-align/parsing/justify-tracks-valid-expected.txt
R 
LayoutTests/imported/w3c/web-platform-tests/css/css-align/parsing/justify-tracks-valid.html
R 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/align-tracks/masonry-align-tracks-001-expected.html
R 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/align-tracks/masonry-align-tracks-001-ref.html
R 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/align-tracks/masonry-align-tracks-001.html
R 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/align-tracks/masonry-align-tracks-multi-001-expected.html
R 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/align-tracks/masonry-align-tracks-multi-001-ref.html
R 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/align-tracks/masonry-align-tracks-multi-001.html
R 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/align-tracks/masonry-align-tracks-stretch-001-expected.html
R 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/align-tracks/masonry-align-tracks-stretch-001-ref.html
R 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/align-tracks/masonry-align-tracks-stretch-001.html
R 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/align-tracks/masonry-align-tracks-stretch-002-expected.html
R 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/align-tracks/masonry-align-tracks-stretch-002-ref.html
R 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/align-tracks/masonry-align-tracks-stretch-002.html
R 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/align-tracks/w3c-import.log
R 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/justify-tracks/masonry-justify-tracks-001-expected.html
R 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/justify-tracks/masonry-justify-tracks-001-ref.html
R 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/justify-tracks/masonry-justify-tracks-001.html
R 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/justify-tracks/masonry-justify-tracks-multi-001-expected.html
R 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/justify-tracks/masonry-justify-tracks-multi-001-ref.html
R 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/justify-tracks/masonry-justify-tracks-multi-001.html
R 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/justify-tracks/masonry-justify-tracks-stretch-001-expected.html
R 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/justify-tracks/masonry-justify-tracks-stretch-001-ref.html
R 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/justify-tracks/masonry-justify-tracks-stretch-001.html
R 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/justify-tracks/masonry-justify-tracks-stretch-002-expected.html
R 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/justify-tracks/masonry-justify-tracks-stretch-002-ref.html
R 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/justify-tracks/masonry-justify-tracks-stretch-002.html
R 
LayoutTests/imported/w3c

[webkit-changes] [WebKit/WebKit] 7cf103: Regression Revert Request Idle Callback Enablement

[Brandon Stewart]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 7cf103117bd780828284c158b6838cfb3f694058
  
https://github.com/WebKit/WebKit/commit/7cf103117bd780828284c158b6838cfb3f694058
  Author: Brandon Stewart 
  Date:   2023-09-15 (Fri, 15 Sep 2023)

  Changed paths:
M Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml

  Log Message:
  ---
  Regression Revert Request Idle Callback Enablement
https://bugs.webkit.org/show_bug.cgi?id=261606
rdar://problem/115557729

Unreviewed memory regression.

commits.webkit.org/267023@main caused a memory regression on iOS devices based 
on benchmark results.
Reverting this patch for now.

* Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml:

Canonical link: https://commits.webkit.org/268037@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 956e03: generate-compile-commands replace trac link with d...

[Brandon Stewart]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 956e038198e5f04d3a00c2edaa36e3e705c055aa
  
https://github.com/WebKit/WebKit/commit/956e038198e5f04d3a00c2edaa36e3e705c055aa
  Author: Brandon Stewart 
  Date:   2023-09-15 (Fri, 15 Sep 2023)

  Changed paths:
M Tools/Scripts/generate-compile-commands

  Log Message:
  ---
  generate-compile-commands replace trac link with docs.webkit.org
https://bugs.webkit.org/show_bug.cgi?id=261591

Reviewed by Jonathan Bedard.

Update trac link to docs.webkit.org

* Tools/Scripts/generate-compile-commands:

Canonical link: https://commits.webkit.org/268027@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] d67db0: RenderGrid Cleanup

[Brandon Stewart]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: d67db0b3d4dfc1cfb40e7d758a01d0c628fc3d4e
  
https://github.com/WebKit/WebKit/commit/d67db0b3d4dfc1cfb40e7d758a01d0c628fc3d4e
  Author: Brandon Stewart 
  Date:   2023-09-15 (Fri, 15 Sep 2023)

  Changed paths:
M Source/WebCore/rendering/RenderGrid.cpp

  Log Message:
  ---
  RenderGrid Cleanup
https://bugs.webkit.org/show_bug.cgi?id=261590

Reviewed by Tim Nguyen.

Some spelling fixes in the comments that I have noticed
over the last year.

* Source/WebCore/rendering/RenderGrid.cpp:
(WebCore::RenderGrid::repeatTracksSizingIfNeeded):
(WebCore::RenderGrid::layoutGrid):
(WebCore::RenderGrid::layoutMasonry):
(WebCore::RenderGrid::guttersSize const):
(WebCore::RenderGrid::performGridItemsPreLayout const):
(WebCore::RenderGrid::updateGridAreaForAspectRatioItems):
(WebCore::RenderGrid::populateGridPositionsForDirection):
(WebCore::RenderGrid::gridAreaPositionForInFlowChild const):
(WebCore::RenderGrid::numTracks const):

Canonical link: https://commits.webkit.org/268018@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 3ed444: Remove unneeded header includes in RenderGrid

[Brandon Stewart]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 3ed444be8319a6314f8c54e8ccd85ae172efbbec
  
https://github.com/WebKit/WebKit/commit/3ed444be8319a6314f8c54e8ccd85ae172efbbec
  Author: Brandon Stewart 
  Date:   2023-09-14 (Thu, 14 Sep 2023)

  Changed paths:
M Source/WebCore/rendering/RenderGrid.cpp

  Log Message:
  ---
  Remove unneeded header includes in RenderGrid
https://bugs.webkit.org/show_bug.cgi?id=261587

Reviewed by Sammy Gill.

Several headers were no longer in use in RenderGrid.cpp.
Removing them.

* Source/WebCore/rendering/RenderGrid.cpp:

Canonical link: https://commits.webkit.org/268013@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 7aea8b: [libpas] PGM Documentation

[Brandon Stewart]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 7aea8b03c8ef694767d4bde6dba8b0352468432c
  
https://github.com/WebKit/WebKit/commit/7aea8b03c8ef694767d4bde6dba8b0352468432c
  Author: Brandon Stewart 
  Date:   2023-08-29 (Tue, 29 Aug 2023)

  Changed paths:
M 
Source/bmalloc/libpas/src/libpas/pas_probabilistic_guard_malloc_allocator.c
M 
Source/bmalloc/libpas/src/libpas/pas_probabilistic_guard_malloc_allocator.h

  Log Message:
  ---
  [libpas] PGM Documentation
https://bugs.webkit.org/show_bug.cgi?id=260882

Reviewed by David Kilzer and Mark Lam.

Clarify how the activation and probabilistic functions work in PGM.
Also, add the documentation on PGM back into the code as it was buried deep
in Phil's Internal explanation and was not super easy to find without searching.

* Source/bmalloc/libpas/src/libpas/pas_probabilistic_guard_malloc_allocator.c:
(pas_probabilistic_guard_malloc_initialize_pgm):
* Source/bmalloc/libpas/src/libpas/pas_probabilistic_guard_malloc_allocator.h:

Canonical link: https://commits.webkit.org/267433@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] c99dbf: Grammatical Cleanup in ReadMe

[Brandon Stewart]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c99dbf8f10441f8bab12b09eb50239f6cc86e37f
  
https://github.com/WebKit/WebKit/commit/c99dbf8f10441f8bab12b09eb50239f6cc86e37f
  Author: Brandon Stewart 
  Date:   2023-08-22 (Tue, 22 Aug 2023)

  Changed paths:
M ReadMe.md

  Log Message:
  ---
  Grammatical Cleanup in ReadMe
https://bugs.webkit.org/show_bug.cgi?id=260539

Reviewed by Sammy Gill.

Noticed an extra 'to' in the ReadMe.
Surrond a script with a code block make it looker nicer.

* ReadMe.md:

Canonical link: https://commits.webkit.org/267151@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 33b383: Get WebKit MALLOC_HEAP_BREAKDOWN Configuration Bui...

[Brandon Stewart]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 33b383131d5edd4552336cfb67114e4dddaaf363
  
https://github.com/WebKit/WebKit/commit/33b383131d5edd4552336cfb67114e4dddaaf363
  Author: Brandon Stewart 
  Date:   2023-08-16 (Wed, 16 Aug 2023)

  Changed paths:
M Source/JavaScriptCore/assembler/LinkBuffer.cpp
M Source/JavaScriptCore/assembler/LinkBuffer.h
M Source/JavaScriptCore/bytecode/InstructionStream.cpp
M Source/JavaScriptCore/runtime/StringReplaceCache.h
M Source/JavaScriptCore/runtime/StringSplitCache.h
M Source/WTF/wtf/BitVector.cpp
M Source/WTF/wtf/DebugHeap.h
M Source/WTF/wtf/FastMalloc.h
M Source/WTF/wtf/MetaAllocator.cpp
M Source/WTF/wtf/text/CString.h
M Source/WTF/wtf/text/cf/StringImplCF.cpp
M Source/WebCore/Modules/WebGPU/InternalAPI/WebGPUBindGroupLayout.h
M Source/WebGPU/WGSL/AST/ASTBuilder.h
M Source/WebKit/Shared/ShareableBitmap.cpp
M Source/WebKit/Shared/ShareableBitmap.h
M Source/WebKit/Shared/ShareableBitmapHandle.cpp
M Source/WebKit/UIProcess/mac/LegacySessionStateCoding.cpp

  Log Message:
  ---
  Get WebKit MALLOC_HEAP_BREAKDOWN Configuration Building Again
https://bugs.webkit.org/show_bug.cgi?id=259786

Reviewed by Elliott Williams.

Get the Malloc Heap Breakdown build compiling again. Lots of header includes 
and exporting of symbols.
This really should not touch the system in any other way, but it does modify 
files across numerous components.

* Source/JavaScriptCore/assembler/LinkBuffer.cpp:
* Source/JavaScriptCore/assembler/LinkBuffer.h:
* Source/JavaScriptCore/bytecode/InstructionStream.cpp:
* Source/JavaScriptCore/runtime/StringReplaceCache.h:
* Source/JavaScriptCore/runtime/StringSplitCache.h:
* Source/WTF/wtf/BitVector.cpp:
* Source/WTF/wtf/DebugHeap.h:
* Source/WTF/wtf/FastMalloc.h:
* Source/WTF/wtf/MetaAllocator.cpp:
* Source/WTF/wtf/text/CString.h:
* Source/WTF/wtf/text/cf/StringImplCF.cpp:
* Source/WebCore/Modules/WebGPU/InternalAPI/WebGPUBindGroupLayout.h:
* Source/WebGPU/WGSL/AST/ASTBuilder.h:
* Source/WebKit/Shared/ShareableBitmap.cpp:
* Source/WebKit/Shared/ShareableBitmap.h:
* Source/WebKit/Shared/ShareableBitmapHandle.cpp:
* Source/WebKit/UIProcess/mac/LegacySessionStateCoding.cpp:

Canonical link: https://commits.webkit.org/266981@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] f1aca9: Add more information on needsSeekingSupportDisable...

[Brandon Stewart]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: f1aca9bd0b7f63039336f3a8d48cb96afa81033e
  
https://github.com/WebKit/WebKit/commit/f1aca9bd0b7f63039336f3a8d48cb96afa81033e
  Author: Brandon Stewart 
  Date:   2023-08-11 (Fri, 11 Aug 2023)

  Changed paths:
M Source/WebCore/page/Quirks.cpp

  Log Message:
  ---
  Add more information on needsSeekingSupportDisabled Quirk
https://bugs.webkit.org/show_bug.cgi?id=260080

Reviewed by Brent Fulgham.

Add additional information on the scenarios this quirk handles.
This was not well documented and led to breakages due to only manually
testing certain cases.

* Source/WebCore/page/Quirks.cpp:

Canonical link: https://commits.webkit.org/266832@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 24c399: Remove Quirk needsSeekingSupportDisabled for Netfl...

[Brandon Stewart]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 24c3998f729699bd4a79492a60a07f3f134b83bf
  
https://github.com/WebKit/WebKit/commit/24c3998f729699bd4a79492a60a07f3f134b83bf
  Author: Brandon Stewart 
  Date:   2023-08-07 (Mon, 07 Aug 2023)

  Changed paths:
M Source/WebCore/html/HTMLMediaElement.cpp
M Source/WebCore/html/HTMLMediaElement.h
M Source/WebCore/page/Quirks.cpp
M Source/WebCore/page/Quirks.h

  Log Message:
  ---
  Remove Quirk needsSeekingSupportDisabled for Netflix.com
https://bugs.webkit.org/show_bug.cgi?id=254788
rdar://107428381

Reviewed by Brent Fulgham.

Remove the quirk for Netflix resuming/stopping the show when the user removes 
an Airpod from their ear.
>From manual testing in a recent version of Safari this is working correctly.

* Source/WebCore/html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::supportsSeeking const): Deleted.
* Source/WebCore/html/HTMLMediaElement.h:
* Source/WebCore/page/Quirks.cpp:
(WebCore::Quirks::needsSeekingSupportDisabled const): Deleted.
* Source/WebCore/page/Quirks.h:

Canonical link: https://commits.webkit.org/266653@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 2524ce: Crash in GridBaselineAlignment::baselineGroupForChild

[Brandon Stewart]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 2524ce648b831949a2646a984cea076e73a0093b
  
https://github.com/WebKit/WebKit/commit/2524ce648b831949a2646a984cea076e73a0093b
  Author: Brandon Stewart 
  Date:   2023-07-31 (Mon, 31 Jul 2023)

  Changed paths:
A LayoutTests/fast/css-grid-layout/baseline-masonry-crash-expected.html
A LayoutTests/fast/css-grid-layout/baseline-masonry-crash.html
M Source/WebCore/rendering/RenderGrid.cpp

  Log Message:
  ---
  Crash in GridBaselineAlignment::baselineGroupForChild
https://bugs.webkit.org/show_bug.cgi?id=257509
rdar://110027455

Reviewed by Alan Baradlay.

Certain baseline properties are not properly handled in CSS Masonry.
We will just disable these calculations for now and then remove this in the 
future.

* LayoutTests/fast/css-grid-layout/baseline-masonry-crash-expected.html: Added.
* LayoutTests/fast/css-grid-layout/baseline-masonry-crash.html: Added.
* Source/WebCore/rendering/RenderGrid.cpp:
(WebCore::RenderGrid::columnAxisBaselineOffsetForChild const):
(WebCore::RenderGrid::rowAxisBaselineOffsetForChild const):

Originally-landed-as: 259548.835@safari-7615-branch (b63d45649891). 
rdar://110027455
Canonical link: https://commits.webkit.org/266429@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 205444: URI Fragments Cached After 301 Redirect

[Brandon Stewart]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 205444531ae8c5213c84b0b63cd0d6ec51cf7735
  
https://github.com/WebKit/WebKit/commit/205444531ae8c5213c84b0b63cd0d6ec51cf7735
  Author: Brandon Stewart 
  Date:   2023-07-10 (Mon, 10 Jul 2023)

  Changed paths:
A LayoutTests/http/tests/links/redirect-301-clear-memory-cache-expected.txt
A LayoutTests/http/tests/links/redirect-301-clear-memory-cache.html
A LayoutTests/http/tests/links/redirect-301-no-inital-fragments-expected.txt
A LayoutTests/http/tests/links/redirect-301-no-inital-fragments.html
A LayoutTests/http/tests/links/redirect-301-with-fragments-expected.txt
A LayoutTests/http/tests/links/redirect-301-with-fragments.html
A LayoutTests/http/tests/links/resources/redirect-helper.pl
A LayoutTests/http/tests/links/resources/redirect-target.html
M Source/WebCore/loader/cache/CachedResource.cpp
M Source/WebCore/loader/cache/CachedResourceLoader.cpp
M Source/WebCore/loader/cache/CachedResourceRequest.h
M Source/WebKit/NetworkProcess/cache/NetworkCache.cpp
M Source/WebKit/NetworkProcess/cache/NetworkCache.h

  Log Message:
  ---
  URI Fragments Cached After 301 Redirect
https://bugs.webkit.org/show_bug.cgi?id=255924
rdar://problem/108535944

Reviewed by Youenn Fablet.

We end up reusing the fragments when performing a redirect and as such end up 
serving old parameters.
For now we will just disable caching redirects with fragments. This is a 
temporary fix; a more proper
solution of handling fragment caching in the future is required.

* LayoutTests/http/tests/links/redirect-301-clear-memory-cache-expected.txt: 
Added.
* LayoutTests/http/tests/links/redirect-301-clear-memory-cache.html: Added.
* LayoutTests/http/tests/links/redirect-301-no-inital-fragments-expected.txt: 
Added.
* LayoutTests/http/tests/links/redirect-301-no-inital-fragments.html: Added.
* LayoutTests/http/tests/links/redirect-301-with-fragments-expected.txt: Added.
* LayoutTests/http/tests/links/redirect-301-with-fragments.html: Added.
* LayoutTests/http/tests/links/resources/redirect-helper.pl: Added.
* LayoutTests/http/tests/links/resources/redirect-target.html: Added.
* Source/WebCore/loader/cache/CachedResource.cpp:
(WebCore::CachedResource::redirectReceived):
* Source/WebCore/loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::determineRevalidationPolicy const):
* Source/WebCore/loader/cache/CachedResourceRequest.h:
(WebCore::CachedResourceRequest::hasFragmentIdentifier const):
* Source/WebKit/NetworkProcess/cache/NetworkCache.cpp:
(WebKit::NetworkCache::makeUseDecision):
(WebKit::NetworkCache::makeStoreDecision):
* Source/WebKit/NetworkProcess/cache/NetworkCache.h:

Canonical link: https://commits.webkit.org/265906@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 3c59e3: Enable macOS previews in SwiftUI MiniBrowser Brows...

[Brandon Stewart]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 3c59e3a33892b111ed0d9d8ffb21996a418e7c20
  
https://github.com/WebKit/WebKit/commit/3c59e3a33892b111ed0d9d8ffb21996a418e7c20
  Author: Brandon Stewart 
  Date:   2023-06-23 (Fri, 23 Jun 2023)

  Changed paths:
M Tools/MiniBrowserSwiftUI/Shared/BrowserTab.swift

  Log Message:
  ---
  Enable macOS previews in SwiftUI MiniBrowser BrowserTab
https://bugs.webkit.org/show_bug.cgi?id=258263
Reviewed by Jonathan Bedard.

BrowserTab previews are available on iOS. This adds support to view them on 
macOS too.

* Tools/MiniBrowserSwiftUI/Shared/BrowserTab.swift:
(BrowserTab_Previews.previews):

Canonical link: https://commits.webkit.org/265493@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] a8a7ef: SwiftUI MiniBrowser Enable Implicit Dependencies

[Brandon Stewart]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: a8a7efec14c0cfe87e595a6f5d1f6af6181570bf
  
https://github.com/WebKit/WebKit/commit/a8a7efec14c0cfe87e595a6f5d1f6af6181570bf
  Author: Brandon Stewart 
  Date:   2023-06-23 (Fri, 23 Jun 2023)

  Changed paths:
M 
Tools/MiniBrowserSwiftUI/MiniBrowserSwiftUI.xcodeproj/xcshareddata/xcschemes/MiniBrowserSwiftUI.xcscheme

  Log Message:
  ---
  SwiftUI MiniBrowser Enable Implicit Dependencies
https://bugs.webkit.org/show_bug.cgi?id=258262

Reviewed by Elliott Williams.

SwiftUI MiniBrowser requires _WebKit_SWIFTUI to compile. Enable 
buildImplicitDependencies to
ensure _WebKit_SWIFTUI is built automatically by the MiniBrowserSwiftUI 
application.

* Tools/MiniBrowserSwiftUI/MiniBrowserSwiftUI.xcodeproj/project.pbxproj:

Canonical link: https://commits.webkit.org/265492@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 63cf0b: Missing CSS Parser Text Underline Handling in CSSP...

[Brandon Stewart]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 63cf0bd4f0aa1aff623c7c398f62dca5f5170a69
  
https://github.com/WebKit/WebKit/commit/63cf0bd4f0aa1aff623c7c398f62dca5f5170a69
  Author: Brandon Stewart 
  Date:   2023-06-14 (Wed, 14 Jun 2023)

  Changed paths:
M Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml
M Source/WebCore/css/parser/CSSParserContext.cpp

  Log Message:
  ---
  Missing CSS Parser Text Underline Handling in CSSParserContext
https://bugs.webkit.org/show_bug.cgi?id=258034

Reviewed by Tim Nguyen.

Was missing support in the CSSParserContext for handling the text underline 
flag.

* Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml:
* Source/WebCore/css/parser/CSSParserContext.cpp:
(WebCore::operator==):
(WebCore::add):

Canonical link: https://commits.webkit.org/265181@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] df4fd0: Simplify Compression Streams Large Flush Output Te...

[Brandon Stewart]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: df4fd08173e18981947d97aafd6efde8dee4db5c
  
https://github.com/WebKit/WebKit/commit/df4fd08173e18981947d97aafd6efde8dee4db5c
  Author: Brandon Stewart 
  Date:   2023-05-22 (Mon, 22 May 2023)

  Changed paths:
M 
LayoutTests/imported/w3c/web-platform-tests/compression/compression-large-flush-output.any.js

  Log Message:
  ---
  Simplify Compression Streams Large Flush Output Test Logic
https://bugs.webkit.org/show_bug.cgi?id=257159

Reviewed by Tim Nguyen.

Remove a lot of the hand written code to handle the concatinating of output 
together.
This was already handled in the concatenate-stream.js.

Also fix Tim's comments in WPT.

* 
LayoutTests/imported/w3c/web-platform-tests/compression/compression-large-flush-output.any.js:
(async compressData):
(promise_test.async t):

Canonical link: https://commits.webkit.org/264399@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 705acf: Text not wrapping in nested grid

[Brandon Stewart]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 705acfb695e5f37fa7e52c7d2050e9e3151cb606
  
https://github.com/WebKit/WebKit/commit/705acfb695e5f37fa7e52c7d2050e9e3151cb606
  Author: Brandon Stewart 
  Date:   2023-05-19 (Fri, 19 May 2023)

  Changed paths:
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/grid-relayout-with-nested-grid-expected.html
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/grid-relayout-with-nested-grid-ref.html
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/grid-relayout-with-nested-grid.html
M Source/WebCore/rendering/RenderGrid.cpp
M Source/WebCore/rendering/RenderGrid.h

  Log Message:
  ---
  Text not wrapping in nested grid
https://bugs.webkit.org/show_bug.cgi?id=254214
rdar://107002717

Reviewed by Alan Baradlay.

This is a hack fix to support not re-layout text in inner grids. This is caused 
by the updateGridAreaLogicalSize
being called in performGridItemsPreLayout(). This causes the paragraph to 
re-need a layout, which should not be happening.
This re-layout ultimately the text to go out of the bounds of the grid.

* 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/grid-relayout-with-nested-grid-expected.html:
 Added.
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/grid-relayout-with-nested-grid-ref.html:
 Added.
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/grid-relayout-with-nested-grid.html:
 Added.
* Source/WebCore/rendering/RenderGrid.cpp:
(WebCore::RenderGrid::layoutGrid):
(WebCore::RenderGrid::layoutMasonry):
(WebCore::RenderGrid::computeIntrinsicLogicalWidths const):
(WebCore::RenderGrid::performGridItemsPreLayout const):
* Source/WebCore/rendering/RenderGrid.h:

Canonical link: https://commits.webkit.org/264252@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] a30d92: Compression Streams not handling large outputs dur...

[Brandon Stewart]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: a30d9284f5b98bd5c389f28bfc4a710d9f256fa8
  
https://github.com/WebKit/WebKit/commit/a30d9284f5b98bd5c389f28bfc4a710d9f256fa8
  Author: Brandon Stewart 
  Date:   2023-05-11 (Thu, 11 May 2023)

  Changed paths:
A 
LayoutTests/imported/w3c/web-platform-tests/compression/compression-large-flush-output.any-expected.txt
A 
LayoutTests/imported/w3c/web-platform-tests/compression/compression-large-flush-output.any.html
A 
LayoutTests/imported/w3c/web-platform-tests/compression/compression-large-flush-output.any.js
M Source/WebCore/Modules/compression/CompressionStreamEncoder.cpp
M Source/WebCore/Modules/compression/CompressionStreamEncoder.h
M Source/WebCore/Modules/compression/DecompressionStreamDecoder.cpp
M Source/WebCore/Modules/compression/DecompressionStreamDecoder.h

  Log Message:
  ---
  Compression Streams not handling large outputs during the flush stage
https://bugs.webkit.org/show_bug.cgi?id=254021

Reviewed by Chris Dumez and Brent Fulgham.

We missed an edge case where during the flush step we may have data longer than
the allocated output. Since the avail_in will be set to 0 we would just exit.
We need to verify that the stream has ended before exiting.

* 
LayoutTests/imported/w3c/web-platform-tests/compression/compression-large-flush-output.any-expected.txt:
 Added.
* 
LayoutTests/imported/w3c/web-platform-tests/compression/compression-large-flush-output.any.html:
 Added.
* 
LayoutTests/imported/w3c/web-platform-tests/compression/compression-large-flush-output.any.js:
 Added.
(async compressData):
(promise_test.async t):
* Source/WebCore/Modules/compression/CompressionStreamEncoder.cpp:
(WebCore::CompressionStreamEncoder::flush):
(WebCore::CompressionStreamEncoder::didDeflateFinish const):
(WebCore::didDeflateFail):
(WebCore::CompressionStreamEncoder::compress):
* Source/WebCore/Modules/compression/CompressionStreamEncoder.h:
(WebCore::CompressionStreamEncoder::CompressionStreamEncoder):
* Source/WebCore/Modules/compression/DecompressionStreamDecoder.cpp:
(WebCore::DecompressionStreamDecoder::flush):
(WebCore::DecompressionStreamDecoder::didInflateFinish const):
(WebCore::didInflateFail):
(WebCore::DecompressionStreamDecoder::didInflateContainExtraBytes const):
(WebCore::DecompressionStreamDecoder::decompressZlib):
(WebCore::DecompressionStreamDecoder::decompressAppleCompressionFramework):
* Source/WebCore/Modules/compression/DecompressionStreamDecoder.h:
(WebCore::DecompressionStreamDecoder::DecompressionStreamDecoder):

Canonical link: https://commits.webkit.org/263997@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 70ac68: Refactor Masonry Initialization Logic to Separate ...

[Brandon Stewart]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 70ac6881106acd3f50495761cb91bfcebceb5acf
  
https://github.com/WebKit/WebKit/commit/70ac6881106acd3f50495761cb91bfcebceb5acf
  Author: Brandon Stewart 
  Date:   2023-05-05 (Fri, 05 May 2023)

  Changed paths:
M Source/WebCore/rendering/GridMasonryLayout.cpp
M Source/WebCore/rendering/GridMasonryLayout.h

  Log Message:
  ---
  Refactor Masonry Initialization Logic to Separate Function
https://bugs.webkit.org/show_bug.cgi?id=256391

Reviewed by Brent Fulgham.

Moving some of the initilization logic to a separate function. This logic resets
all the global variables between masonry runs.

* Source/WebCore/rendering/GridMasonryLayout.cpp:
(WebCore::GridMasonryLayout::initializeMasonry):
(WebCore::GridMasonryLayout::performMasonryPlacement):
* Source/WebCore/rendering/GridMasonryLayout.h:

Canonical link: https://commits.webkit.org/263738@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] bc2ea4: CSS Masonry Ensure Grid Size Updates on Resize

[Brandon Stewart]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: bc2ea4d4cf826d62361b7744522954a7b4be96b0
  
https://github.com/WebKit/WebKit/commit/bc2ea4d4cf826d62361b7744522954a7b4be96b0
  Author: Brandon Stewart 
  Date:   2023-05-04 (Thu, 04 May 2023)

  Changed paths:
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/track-sizing/masonry-track-sizing-check-grid-height-on-resize-expected.html
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/track-sizing/masonry-track-sizing-check-grid-height-on-resize-ref.html
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/track-sizing/masonry-track-sizing-check-grid-height-on-resize.html
M Source/WebCore/rendering/GridMasonryLayout.cpp

  Log Message:
  ---
  CSS Masonry Ensure Grid Size Updates on Resize
https://bugs.webkit.org/show_bug.cgi?id=256337

Reviewed by Brent Fulgham.

During a resize of an element, the grid was not properly updating. The total 
grid size was remaining the same size while
the content was properly resized. This was caused by not clearing the 
m_gridContentSize at the start of the masonry algorithm.

* 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/track-sizing/masonry-track-sizing-check-grid-height-on-resize-expected.html:
 Added.
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/track-sizing/masonry-track-sizing-check-grid-height-on-resize-ref.html:
 Added.
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/track-sizing/masonry-track-sizing-check-grid-height-on-resize.html:
 Added.
* Source/WebCore/rendering/GridMasonryLayout.cpp:
(WebCore::GridMasonryLayout::performMasonryPlacement):

Canonical link: https://commits.webkit.org/263712@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 79afd6: Fix Lint Warning in TestExpectations

[Brandon Stewart]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 79afd6bfac3990e7403d1067219ff46697987e09
  
https://github.com/WebKit/WebKit/commit/79afd6bfac3990e7403d1067219ff46697987e09
  Author: Brandon Stewart 
  Date:   2023-05-03 (Wed, 03 May 2023)

  Changed paths:
M LayoutTests/platform/mac-wk2/TestExpectations

  Log Message:
  ---
  Fix Lint Warning in TestExpectations
https://bugs.webkit.org/show_bug.cgi?id=256286

Reviewed by Tim Nguyen.

Address lint warning when running webkit test runner.

--lint-test-files warnings:
LayoutTests/platform/mac-wk2/TestExpectations:1799 Unrecognized expectation 
"Debug"
imported/w3c/web-platform-tests/background-fetch/port-blocking.https.window.html

* LayoutTests/platform/mac-wk2/TestExpectations:

Canonical link: https://commits.webkit.org/263659@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] b7227f: Cleanup Source/.gitignore

[Brandon Stewart]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: b7227f0e7f28cd1d3a94082f5815bf49b0c2270f
  
https://github.com/WebKit/WebKit/commit/b7227f0e7f28cd1d3a94082f5815bf49b0c2270f
  Author: Brandon Stewart 
  Date:   2023-05-01 (Mon, 01 May 2023)

  Changed paths:
R Source/.gitignore

  Log Message:
  ---
  Cleanup Source/.gitignore
https://bugs.webkit.org/show_bug.cgi?id=256133

Reviewed by Michael Catanzaro.

This file only contains a reference to a generate file in the QT build system.
I can't find any other references to it in the codebase.

* Source/.gitignore: Removed.

Canonical link: https://commits.webkit.org/263552@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] c93e91: Remove mutableGrid() from GridTrackSizing Algorithm

[Brandon Stewart]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c93e912f76b4fec9e6d44aaff283c19339d7a9fd
  
https://github.com/WebKit/WebKit/commit/c93e912f76b4fec9e6d44aaff283c19339d7a9fd
  Author: Brandon Stewart 
  Date:   2023-04-20 (Thu, 20 Apr 2023)

  Changed paths:
M Source/WebCore/rendering/GridTrackSizingAlgorithm.h

  Log Message:
  ---
  Remove mutableGrid() from GridTrackSizing Algorithm
https://bugs.webkit.org/show_bug.cgi?id=255738

Reviewed by Tim Nguyen.

mutableGrid() does not appear to be used anymore in the code base.

* Source/WebCore/rendering/GridTrackSizingAlgorithm.h:

Canonical link: https://commits.webkit.org/263207@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] f20960: PGM Crash Analysis

[Brandon Stewart]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: f209607bc69672c97760e70b3e128cc79d4a704d
  
https://github.com/WebKit/WebKit/commit/f209607bc69672c97760e70b3e128cc79d4a704d
  Author: Brandon Stewart 
  Date:   2023-04-17 (Mon, 17 Apr 2023)

  Changed paths:
A Source/JavaScriptCore/API/PASReportCrashPrivate.cpp
A Source/JavaScriptCore/API/PASReportCrashPrivate.h
M Source/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj
M Source/JavaScriptCore/SourcesCocoa.txt
M Source/bmalloc/CMakeLists.txt
M Source/bmalloc/bmalloc.xcodeproj/project.pbxproj
M Source/bmalloc/libpas/libpas.xcodeproj/project.pbxproj
M Source/bmalloc/libpas/src/libpas/pas_enumerate_large_heaps.c
A Source/bmalloc/libpas/src/libpas/pas_report_crash.c
A Source/bmalloc/libpas/src/libpas/pas_report_crash.h
A Source/bmalloc/libpas/src/libpas/pas_report_crash_pgm_report.h

  Log Message:
  ---
  PGM Crash Analysis
https://bugs.webkit.org/show_bug.cgi?id=255345

Reviewed by Mark Lam, Elliott Williams and David Kilzer.

When a process crashes we will now try to determine whether this crash was 
caused by
a PGM allocation in WebKit. ReportCrash will call into JSC, which would forward 
the information
onto libpas. libpas will respond with a report generated from the memory of the 
now dead process.

libpas will determine whether this was a PGM crash and if so what kind of crash 
(UAF or OOB).
This information will be added to the local crash log generated.

* Source/JavaScriptCore/API/PASReportCrashPrivate.cpp: Added.
(PASReportCrashExtractResults):
* Source/JavaScriptCore/API/PASReportCrashPrivate.h: Added.
* Source/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj:
* Source/JavaScriptCore/SourcesCocoa.txt:
* Source/bmalloc/CMakeLists.txt:
* Source/bmalloc/bmalloc.xcodeproj/project.pbxproj:
* Source/bmalloc/libpas/libpas.xcodeproj/project.pbxproj:
* Source/bmalloc/libpas/src/libpas/pas_enumerate_large_heaps.c:
(pas_hash_map_entry_callback):
* Source/bmalloc/libpas/src/libpas/pas_report_crash.c: Added.
(memory_reader_adapter):
(setup_memory_reader):
(pas_report_crash_extract_pgm_failure):
* Source/bmalloc/libpas/src/libpas/pas_report_crash.h: Added.
* Source/bmalloc/libpas/src/libpas/pas_report_crash_pgm_report.h: Added.

Canonical link: https://commits.webkit.org/263055@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] ef3245: [css-grid] grid-template-rows: masonry has an effe...

[Brandon Stewart]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: ef3245fe7ca023957930d1836c543b5522db91eb
  
https://github.com/WebKit/WebKit/commit/ef3245fe7ca023957930d1836c543b5522db91eb
  Author: Brandon Stewart 
  Date:   2023-04-06 (Thu, 06 Apr 2023)

  Changed paths:
M Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp

  Log Message:
  ---
  [css-grid] grid-template-rows: masonry has an effect, even when the feature 
is turned off
https://bugs.webkit.org/show_bug.cgi?id=255022

Reviewed by Matt Woodrow.

Missing a check to verify whether Masonry is enabled or not. This should be 
refactored in the future
as having to check the context everywhere is not great, but this does fix the 
bug.

The reason masonry was being triggered was the RenderStyle masonryRows are 
getting populated due to the missing check.
When we go to layout the block we do a check if it is masonry or not. Since the 
masonryRows got populated we assume that
we should do a masonry layout instead of a grid layout.

Reviewed manually turning on and off the flag.

* Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp:
(WebCore::CSSPropertyParserHelpers::consumeGridTrackList):

Canonical link: https://commits.webkit.org/262670@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 3cca5b: Remove Windows Record Memory

[Brandon Stewart]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 3cca5b501df706f803455bbc7824e06106b1fcf3
  
https://github.com/WebKit/WebKit/commit/3cca5b501df706f803455bbc7824e06106b1fcf3
  Author: Brandon Stewart 
  Date:   2023-03-21 (Tue, 21 Mar 2023)

  Changed paths:
R Tools/win/record-memory/main.cpp
R Tools/win/record-memory/record-memory.vcxproj
R Tools/win/record-memory/record-memory.vcxproj.filters
R Tools/win/record-memory/record-memoryCommon.props
R Tools/win/record-memory/record-memoryDebug.props
R Tools/win/record-memory/record-memoryDebugWinCairo.props
R Tools/win/record-memory/record-memoryProduction.props
R Tools/win/record-memory/record-memoryRelease.props
R Tools/win/record-memory/record-memoryReleaseWinCairo.props

  Log Message:
  ---
  Remove Windows Record Memory
https://bugs.webkit.org/show_bug.cgi?id=252887

Reviewed by Fujii Hironori.

Delete Windows Record Memory. It does not seem to be used anymore.
We can add this back if we discover a use case for it.

* Tools/win/record-memory/main.cpp: Removed.
* Tools/win/record-memory/record-memory.vcxproj: Removed.
* Tools/win/record-memory/record-memory.vcxproj.filters: Removed.
* Tools/win/record-memory/record-memoryCommon.props: Removed.
* Tools/win/record-memory/record-memoryDebug.props: Removed.
* Tools/win/record-memory/record-memoryDebugWinCairo.props: Removed.
* Tools/win/record-memory/record-memoryProduction.props: Removed.
* Tools/win/record-memory/record-memoryRelease.props: Removed.
* Tools/win/record-memory/record-memoryReleaseWinCairo.props: Removed.

Canonical link: https://commits.webkit.org/261939@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 582634: [libpas] PGM Add Back Logging for Upper and Lower ...

[Brandon Stewart]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 5826345a0ebfc60e93daed1251c3785600b1b286
  
https://github.com/WebKit/WebKit/commit/5826345a0ebfc60e93daed1251c3785600b1b286
  Author: Brandon Stewart 
  Date:   2023-03-21 (Tue, 21 Mar 2023)

  Changed paths:
M 
Source/bmalloc/libpas/src/libpas/pas_probabilistic_guard_malloc_allocator.c

  Log Message:
  ---
  [libpas] PGM Add Back Logging for Upper and Lower Guard Pages
https://bugs.webkit.org/show_bug.cgi?id=254233

Reviewed by Yusuke Suzuki.

Add back logging for PGM upper and lower guard pages. These got removed when I 
was optimizing the
storage of metadata.

* Source/bmalloc/libpas/src/libpas/pas_probabilistic_guard_malloc_allocator.c:
(pas_probabilistic_guard_malloc_debug_info):

Canonical link: https://commits.webkit.org/261938@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] e5d00e: Remove generate-win32-export-forwards Script

[Brandon Stewart]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: e5d00e8df2124e4f637f42c7ac894a1bbb8297ec
  
https://github.com/WebKit/WebKit/commit/e5d00e8df2124e4f637f42c7ac894a1bbb8297ec
  Author: Brandon Stewart 
  Date:   2023-03-07 (Tue, 07 Mar 2023)

  Changed paths:
R Tools/Scripts/generate-win32-export-forwards

  Log Message:
  ---
  Remove generate-win32-export-forwards Script
https://bugs.webkit.org/show_bug.cgi?id=253492

Reviewed by Don Olmstead.

As far as I can tell this was added specifically for the QT port, which has 
since been deprecated.

* Tools/Scripts/generate-win32-export-forwards: Removed.

Canonical link: https://commits.webkit.org/261338@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 0014f2: Reduce PGM Metadata Storage from 64 to 40 bytes pe...

[Brandon Stewart]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 0014f22cde494c9382d376d0cf89c9d56cf03a04
  
https://github.com/WebKit/WebKit/commit/0014f22cde494c9382d376d0cf89c9d56cf03a04
  Author: Brandon Stewart 
  Date:   2023-03-06 (Mon, 06 Mar 2023)

  Changed paths:
M Source/bmalloc/libpas/src/libpas/pas_enumerate_large_heaps.c
M 
Source/bmalloc/libpas/src/libpas/pas_probabilistic_guard_malloc_allocator.c
M 
Source/bmalloc/libpas/src/libpas/pas_probabilistic_guard_malloc_allocator.h

  Log Message:
  ---
  Reduce PGM Metadata Storage from 64 to 40 bytes per allocation
https://bugs.webkit.org/show_bug.cgi?id=253458

Reviewed by Yusuke Suzuki.

Decrease metadata storage significantly per allocation when performing a PGM 
allocation.
This is a solid first pass, but we can probably optimize the page_size entry a 
bit.

* Source/bmalloc/libpas/src/libpas/pas_enumerate_large_heaps.c:
(pas_hash_map_entry_callback):
* Source/bmalloc/libpas/src/libpas/pas_probabilistic_guard_malloc_allocator.c:
(pas_probabilistic_guard_malloc_allocate):
(pas_probabilistic_guard_malloc_deallocate):
(pas_probabilistic_guard_malloc_debug_info):
* Source/bmalloc/libpas/src/libpas/pas_probabilistic_guard_malloc_allocator.h:

Canonical link: https://commits.webkit.org/261305@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 49c7fc: CSS Text Underline Position Left and Right Parsing

[Brandon Stewart]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 49c7fca71f8ba7afe8bbf0153bc050b15857fd39
  
https://github.com/WebKit/WebKit/commit/49c7fca71f8ba7afe8bbf0153bc050b15857fd39
  Author: Brandon Stewart 
  Date:   2023-03-02 (Thu, 02 Mar 2023)

  Changed paths:
M Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml
M Source/WebCore/css/CSSPrimitiveValueMappings.h
M Source/WebCore/css/CSSProperties.json
M Source/WebCore/css/parser/CSSParserContext.h
M Source/WebCore/rendering/TextDecorationPainter.cpp
M Source/WebCore/rendering/style/RenderStyleConstants.cpp
M Source/WebCore/rendering/style/RenderStyleConstants.h
M Source/WebCore/rendering/style/StyleRareInheritedData.h

  Log Message:
  ---
  CSS Text Underline Position Left and Right Parsing
https://bugs.webkit.org/show_bug.cgi?id=252770

Reviewed by Tim Nguyen.

Add support for parsing CSS Text Underline position left and right values.
This does not add support for multiple values like "under left".

* Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml:
* Source/WebCore/css/CSSPrimitiveValueMappings.h:
* Source/WebCore/css/CSSProperties.json:
* Source/WebCore/css/parser/CSSParserContext.h:
* Source/WebCore/rendering/TextDecorationPainter.cpp:
(WebCore::TextDecorationPainter::paintBackgroundDecorations):
* Source/WebCore/rendering/style/RenderStyleConstants.cpp:
(WebCore::operator<<):
* Source/WebCore/rendering/style/RenderStyleConstants.h:
* Source/WebCore/rendering/style/StyleRareInheritedData.h:

Canonical link: https://commits.webkit.org/261052@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] e1dfe8: PGM Enumeration

[Brandon Stewart]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: e1dfe8ee432e1e56188157ffb1ce6f6afb7758ba
  
https://github.com/WebKit/WebKit/commit/e1dfe8ee432e1e56188157ffb1ce6f6afb7758ba
  Author: Brandon Stewart 
  Date:   2023-02-28 (Tue, 28 Feb 2023)

  Changed paths:
M Source/bmalloc/libpas/libpas.xcodeproj/project.pbxproj
M Source/bmalloc/libpas/src/libpas/pas_enumerate_large_heaps.c
M 
Source/bmalloc/libpas/src/libpas/pas_probabilistic_guard_malloc_allocator.c
M 
Source/bmalloc/libpas/src/libpas/pas_probabilistic_guard_malloc_allocator.h
M Source/bmalloc/libpas/src/libpas/pas_root.c
M Source/bmalloc/libpas/src/libpas/pas_root.h
A Source/bmalloc/libpas/src/test/EnumerationTests.cpp
M Source/bmalloc/libpas/src/test/TestHarness.cpp

  Log Message:
  ---
  PGM Enumeration
https://bugs.webkit.org/show_bug.cgi?id=252331

Reviewed by Brent Fulgham.

Add enumeration support for PGM allocation. This will enumerate both the 
allocation and
surronding metadata regarding that allocation. Freed PGM allocations are not 
tracked.

* Source/bmalloc/libpas/libpas.xcodeproj/project.pbxproj:
* Source/bmalloc/libpas/src/libpas/pas_enumerate_large_heaps.c:
(pas_hash_map_entry_callback):
(enumerate_pgm_map):
(pas_enumerate_large_heaps):
* Source/bmalloc/libpas/src/libpas/pas_probabilistic_guard_malloc_allocator.c:
(pas_probabilistic_guard_malloc_deallocate):
* Source/bmalloc/libpas/src/libpas/pas_probabilistic_guard_malloc_allocator.h:
* Source/bmalloc/libpas/src/libpas/pas_root.c:
(pas_root_construct):
* Source/bmalloc/libpas/src/libpas/pas_root.h:
* Source/bmalloc/libpas/src/test/EnumerationTests.cpp: Added.
(std::PageRange::PageRange):
(std::PageRange::operator< const):
(std::PageRange::end const):
(std::RecordedRange::RecordedRange):
(std::RecordedRange::operator< const):
(std::RecordedRange::end const):
(std::ReaderRange::ReaderRange):
(std::ReaderRange::operator< const):
(std::enumeratorReader):
(std::enumeratorRecorder):
(std::testBasicEnumeration):
(std::testPGMEnumerationBasic):
(std::testPGMEnumerationAddAndFree):
(addEnumerationTests):
* Source/bmalloc/libpas/src/test/TestHarness.cpp:
(main):

Canonical link: https://commits.webkit.org/260978@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] fe58e5: Disable Apple Compression API in Compression Streams

[Brandon Stewart]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: fe58e5cd0281e47d9e9739df609cf404067d1c96
  
https://github.com/WebKit/WebKit/commit/fe58e5cd0281e47d9e9739df609cf404067d1c96
  Author: Brandon Stewart 
  Date:   2023-02-27 (Mon, 27 Feb 2023)

  Changed paths:
M Source/WebCore/Modules/compression/DecompressionStreamDecoder.cpp
M Source/WebCore/Modules/compression/DecompressionStreamDecoder.h

  Log Message:
  ---
  Disable Apple Compression API in Compression Streams
https://bugs.webkit.org/show_bug.cgi?id=253042

Reviewed by Brent Fulgham.

Disable Compression API for Compression Streams right now as it is causing 
issues
on web sites.

* Source/WebCore/Modules/compression/DecompressionStreamDecoder.cpp:
(WebCore::DecompressionStreamDecoder::decompress):
* Source/WebCore/Modules/compression/DecompressionStreamDecoder.h:
(WebCore::DecompressionStreamDecoder::DecompressionStreamDecoder):

Canonical link: https://commits.webkit.org/260923@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] bad2b1: Integrate PGM for large heap allocations

[Brandon Stewart]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: bad2b1b9cb893c36c7d869820a8fae97ab36356e
  
https://github.com/WebKit/WebKit/commit/bad2b1b9cb893c36c7d869820a8fae97ab36356e
  Author: Brandon Stewart 
  Date:   2023-02-15 (Wed, 15 Feb 2023)

  Changed paths:
M Source/bmalloc/bmalloc.xcodeproj/project.pbxproj
M Source/bmalloc/libpas/src/libpas/bmalloc_heap_config.h
M Source/bmalloc/libpas/src/libpas/iso_heap_config.h
M Source/bmalloc/libpas/src/libpas/pas_heap.c
M Source/bmalloc/libpas/src/libpas/pas_heap_config_utils.h
M Source/bmalloc/libpas/src/libpas/pas_large_heap.c
M 
Source/bmalloc/libpas/src/libpas/pas_probabilistic_guard_malloc_allocator.c
M 
Source/bmalloc/libpas/src/libpas/pas_probabilistic_guard_malloc_allocator.h
M Source/bmalloc/libpas/src/libpas/pas_try_allocate_common.h
M Source/bmalloc/libpas/src/libpas/pas_try_reallocate.h
M Source/bmalloc/libpas/src/test/PGMTests.cpp

  Log Message:
  ---
  Integrate PGM for large heap allocations
https://bugs.webkit.org/show_bug.cgi?id=249371

Reviewed by Yusuke Suzuki.

This patch turns on PGM allocations for large heaps.
PGM will be enabled 1 in 1000 times upon process launch, and a PGM allocation
will be performed every 4,000 to 5,000 times.

This patch also adds re-allocation support to PGM. PGM allocations can be 
re-allocated
to a non pgm allocation and vice versa.

Based on benchmarks there was no noticable memory or performance overhead 
observed when enabling
this feature.

* Source/bmalloc/libpas/libpas.xcodeproj/project.pbxproj:
* Source/bmalloc/libpas/src/libpas/bmalloc_heap_config.h:
* Source/bmalloc/libpas/src/libpas/iso_heap_config.h:
* Source/bmalloc/libpas/src/libpas/pas_heap.c:
(pas_heap_create):
* Source/bmalloc/libpas/src/libpas/pas_probabilistic_guard_malloc_allocator.c:
(pas_probabilistic_guard_malloc_allocate):
(pas_probabilistic_guard_malloc_return_as_large_map_entry):
(pas_probabilistic_guard_malloc_should_call_pgm):
(pas_probabilistic_guard_malloc_initialize_pgm):
* Source/bmalloc/libpas/src/libpas/pas_probabilistic_guard_malloc_allocator.h:
* Source/bmalloc/libpas/src/libpas/pas_try_allocate_common.h:
(pas_try_allocate_common_impl_slow):
* Source/bmalloc/libpas/src/libpas/pas_try_reallocate.h:
(pas_try_reallocate):
* Source/bmalloc/libpas/src/test/PGMTests.cpp:
(std::testPGMRealloc):
(addPGMTests):

Canonical link: https://commits.webkit.org/260353@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] d1c78b: Remove WinCairo WK1 Tests

[Brandon Stewart]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: d1c78b14827757d6e4da73219f3d46dae4e0c050
  
https://github.com/WebKit/WebKit/commit/d1c78b14827757d6e4da73219f3d46dae4e0c050
  Author: Brandon Stewart 
  Date:   2023-02-15 (Wed, 15 Feb 2023)

  Changed paths:
R LayoutTests/platform/wincairo-wk1/TestExpectations
R 
LayoutTests/platform/wincairo-wk1/http/tests/security/401-logout/401-logout-expected.txt
R 
LayoutTests/platform/wincairo-wk1/http/tests/xmlhttprequest/redirect-cross-origin-post-expected.txt
R 
LayoutTests/platform/wincairo-wk1/http/tests/xmlhttprequest/simple-cross-origin-denied-events-post-expected.txt

  Log Message:
  ---
  Remove WinCairo WK1 Tests
https://bugs.webkit.org/show_bug.cgi?id=252371

Reviewed by Fujii Hironori.

Remove WinCairo WK1 tests as it is not supported anymore.

* LayoutTests/platform/wincairo-wk1/TestExpectations: Removed.
* 
LayoutTests/platform/wincairo-wk1/http/tests/security/401-logout/401-logout-expected.txt:
 Removed.
* 
LayoutTests/platform/wincairo-wk1/http/tests/xmlhttprequest/redirect-cross-origin-post-expected.txt:
 Removed.
* 
LayoutTests/platform/wincairo-wk1/http/tests/xmlhttprequest/simple-cross-origin-denied-events-post-expected.txt:
 Removed.

Canonical link: https://commits.webkit.org/260350@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 202ede: Apple Windows Cleanup in AVFoundation

[Brandon Stewart]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 202ede539db28000c1f6bba252d02a8e9b3205df
  
https://github.com/WebKit/WebKit/commit/202ede539db28000c1f6bba252d02a8e9b3205df
  Author: Brandon Stewart 
  Date:   2023-02-11 (Sat, 11 Feb 2023)

  Changed paths:
R 
Source/WebCore/platform/graphics/avfoundation/cf/AVFoundationCFSoftLinking.h
M 
Source/WebCore/platform/graphics/avfoundation/cf/CDMSessionAVFoundationCF.cpp
R 
Source/WebCore/platform/graphics/avfoundation/cf/InbandTextTrackPrivateAVCF.cpp
R 
Source/WebCore/platform/graphics/avfoundation/cf/InbandTextTrackPrivateAVCF.h
R 
Source/WebCore/platform/graphics/avfoundation/cf/InbandTextTrackPrivateLegacyAVCF.cpp
R 
Source/WebCore/platform/graphics/avfoundation/cf/InbandTextTrackPrivateLegacyAVCF.h
R 
Source/WebCore/platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp
R 
Source/WebCore/platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.h
M 
Source/WebCore/platform/graphics/avfoundation/cf/WebCoreAVCFResourceLoader.cpp

  Log Message:
  ---
  Apple Windows Cleanup in AVFoundation
https://bugs.webkit.org/show_bug.cgi?id=252094

Reviewed by Brent Fulgham.

Cleanup AVFoundation code by removing Apple Windows specific components.

* Source/WebCore/platform/graphics/avfoundation/cf/AVFoundationCFSoftLinking.h: 
Removed.
* Source/WebCore/platform/graphics/avfoundation/cf/CDMSessionAVFoundationCF.cpp:
* 
Source/WebCore/platform/graphics/avfoundation/cf/InbandTextTrackPrivateAVCF.cpp:
 Removed.
* 
Source/WebCore/platform/graphics/avfoundation/cf/InbandTextTrackPrivateAVCF.h: 
Removed.
* 
Source/WebCore/platform/graphics/avfoundation/cf/InbandTextTrackPrivateLegacyAVCF.cpp:
 Removed.
* 
Source/WebCore/platform/graphics/avfoundation/cf/InbandTextTrackPrivateLegacyAVCF.h:
 Removed.
* 
Source/WebCore/platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp:
 Removed.
* 
Source/WebCore/platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.h:
 Removed.
* 
Source/WebCore/platform/graphics/avfoundation/cf/WebCoreAVCFResourceLoader.cpp:

Canonical link: https://commits.webkit.org/260155@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 4ad56a: Remove Apple Win Support from WTF

[Brandon Stewart]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 4ad56abb112ee51f630fbb16b3a912202e622eb5
  
https://github.com/WebKit/WebKit/commit/4ad56abb112ee51f630fbb16b3a912202e622eb5
  Author: Brandon Stewart 
  Date:   2023-02-10 (Fri, 10 Feb 2023)

  Changed paths:
M Source/WTF/WTF.xcodeproj/project.pbxproj
M Source/WTF/wtf/CMakeLists.txt
M Source/WTF/wtf/PlatformEnable.h
R Source/WTF/wtf/PlatformEnableWinApple.h

  Log Message:
  ---
  Remove Apple Win Support from WTF
https://bugs.webkit.org/show_bug.cgi?id=252061

Reviewed by Don Olmstead and Brent Fulgham.

Remove Apple Win Support from WTF as it is no longer in use.
This should not touch the WIN CAIRO build at all.

* Source/WTF/WTF.xcodeproj/project.pbxproj:
* Source/WTF/wtf/CMakeLists.txt:
* Source/WTF/wtf/PlatformEnable.h:
* Source/WTF/wtf/PlatformEnableWinApple.h: Removed.

Canonical link: https://commits.webkit.org/260137@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 53f62d: [libpas] Fix separate Xcode project build

[Brandon Stewart]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 53f62db4c1f7337e0196b6bbf68f8ff9b6b0a7f5
  
https://github.com/WebKit/WebKit/commit/53f62db4c1f7337e0196b6bbf68f8ff9b6b0a7f5
  Author: Brandon Stewart 
  Date:   2023-02-10 (Fri, 10 Feb 2023)

  Changed paths:
M Source/bmalloc/libpas/libpas.xcodeproj/project.pbxproj

  Log Message:
  ---
  [libpas] Fix separate Xcode project build
https://bugs.webkit.org/show_bug.cgi?id=251803

Reviewed by Elliott Williams.

I noticed that I was getting runtime issue when trying to run test_pas on my 
build.
This seems to be due to the SDKROOT being different between projects.

* Source/bmalloc/libpas/libpas.xcodeproj/project.pbxproj:

Canonical link: https://commits.webkit.org/260120@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 605d17: Address Masonry First Load Image Failures

[Brandon Stewart]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 605d174ea587fb7635afe58f0fbb0f79ee3df6b6
  
https://github.com/WebKit/WebKit/commit/605d174ea587fb7635afe58f0fbb0f79ee3df6b6
  Author: Brandon Stewart 
  Date:   2023-02-07 (Tue, 07 Feb 2023)

  Changed paths:
M Source/WebCore/rendering/GridMasonryLayout.cpp

  Log Message:
  ---
  Address Masonry First Load Image Failures
https://bugs.webkit.org/show_bug.cgi?id=251733

Reviewed by Matt Woodrow.

Masonry has been having some interesting behavior with pure images
due to heights often being incorrectly rendered as 0px. This patch
fixes the first load problem. This seems to be connected to not properly
populating grid positions.

* Source/WebCore/rendering/GridMasonryLayout.cpp:
(WebCore::GridMasonryLayout::performMasonryPlacement):

Canonical link: https://commits.webkit.org/259978@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] f63e4c: Masonry Items being added to Incorrect Row

[Brandon Stewart]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: f63e4c7cf1ab3e10832a8f17c62c753683dd805a
  
https://github.com/WebKit/WebKit/commit/f63e4c7cf1ab3e10832a8f17c62c753683dd805a
  Author: Brandon Stewart 
  Date:   2023-02-02 (Thu, 02 Feb 2023)

  Changed paths:
M Source/WebCore/rendering/RenderGrid.cpp
M Source/WebCore/rendering/RenderGrid.h

  Log Message:
  ---
  Masonry Items being added to Incorrect Row
https://bugs.webkit.org/show_bug.cgi?id=251604

Reviewed by Matt Woodrow.

I noticed that itmes were getting added to the second "row" when writing up
some basic examples. This was addressed by removing the extra track sizing step,
which I don't think is needed for Masonry.

Also, forking out the layoutGrid code. I think we should be able to eventually 
able to delete
this based on some discussions with Matt, but we need it for now due to certain 
layout operations
being performed here, otherwise the tree ends up at dirty and crashes.

* Source/WebCore/rendering/RenderGrid.cpp:
(WebCore::RenderGrid::layoutMasonry):
(WebCore::RenderGrid::layoutGridItems):
(WebCore::RenderGrid::layoutMasonryItems):
* Source/WebCore/rendering/RenderGrid.h:

Canonical link: https://commits.webkit.org/259786@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 48fe5d: Fork out Masonry into a separate layout function

[Brandon Stewart]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 48fe5d10f6d2a56957f07a669bdb9aa8627c5aff
  
https://github.com/WebKit/WebKit/commit/48fe5d10f6d2a56957f07a669bdb9aa8627c5aff
  Author: Brandon Stewart 
  Date:   2023-01-31 (Tue, 31 Jan 2023)

  Changed paths:
M Source/WebCore/rendering/GridMasonryLayout.cpp
M Source/WebCore/rendering/GridTrackSizingAlgorithm.cpp
M Source/WebCore/rendering/GridTrackSizingAlgorithm.h
M Source/WebCore/rendering/RenderGrid.cpp
M Source/WebCore/rendering/RenderGrid.h

  Log Message:
  ---
  Fork out Masonry into a separate layout function
https://bugs.webkit.org/show_bug.cgi?id=251459

Reviewed by Matt Woodrow.

I have been finding a significant amount of special cases are getting added to
the grid code to handle masonry. This has been getting rather messy to maintain,
and splitting these two would allow easier changes to the layout to support 
masonry without
worrying about breaking grid.

* Source/WebCore/rendering/GridMasonryLayout.cpp:
(WebCore::GridMasonryLayout::collectMasonryItems):
* Source/WebCore/rendering/GridTrackSizingAlgorithm.cpp:
(WebCore::GridTrack::cachedTrackSize const):
* Source/WebCore/rendering/GridTrackSizingAlgorithm.h:
(WebCore::GridTrack::cachedTrackSize const): Deleted.
* Source/WebCore/rendering/RenderGrid.cpp:
(WebCore::RenderGrid::layoutBlock):
(WebCore::RenderGrid::layoutGrid):
(WebCore::RenderGrid::layoutMasonry):
* Source/WebCore/rendering/RenderGrid.h:

Canonical link: https://commits.webkit.org/259662@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 92c4a2: Skip tracksAreWiderThanMinTrackBreadth() if the gr...

[Brandon Stewart]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 92c4a270002ac42a89d6f05a558ae53c7c135352
  
https://github.com/WebKit/WebKit/commit/92c4a270002ac42a89d6f05a558ae53c7c135352
  Author: Brandon Stewart 
  Date:   2023-01-30 (Mon, 30 Jan 2023)

  Changed paths:
M Source/WebCore/rendering/GridTrackSizingAlgorithm.cpp
M Source/WebCore/rendering/GridTrackSizingAlgorithm.h

  Log Message:
  ---
  Skip tracksAreWiderThanMinTrackBreadth() if the grid is Masonry
https://bugs.webkit.org/show_bug.cgi?id=251399

Reviewed by Matt Woodrow.

Similar to subgrid let's skip the tracksAreWiderThanMinTrackBreadth() when the 
Grid is set to Masonry.
Under Masonry the GridTrackSizing algorithm is skipped, so it is not needed to 
run this.

* Source/WebCore/rendering/GridTrackSizingAlgorithm.cpp:
(WebCore::GridTrackSizingAlgorithm::run):
(WebCore::GridTrackSizingAlgorithm::tracksAreWiderThanMinTrackBreadth const):
* Source/WebCore/rendering/GridTrackSizingAlgorithm.h:
(WebCore::GridTrack::cachedTrackSize const):

Canonical link: https://commits.webkit.org/259604@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] e70c40: Spelling fix for errorMessageForTransfer function

[Brandon Stewart]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: e70c4066c8d887760f868e1d53a16cca761d0bf2
  
https://github.com/WebKit/WebKit/commit/e70c4066c8d887760f868e1d53a16cca761d0bf2
  Author: Brandon Stewart 
  Date:   2023-01-27 (Fri, 27 Jan 2023)

  Changed paths:
M Source/JavaScriptCore/runtime/ArrayBuffer.cpp
M Source/JavaScriptCore/runtime/ArrayBuffer.h
M Source/WebCore/bindings/js/SerializedScriptValue.cpp

  Log Message:
  ---
  Spelling fix for errorMessageForTransfer function
https://bugs.webkit.org/show_bug.cgi?id=251250

Reviewed by Yusuke Suzuki.

Noticed incorrect spelling while browsing the code today.
Update errorMesasgeForTransfer to errorMessageForTransfer.

* Source/JavaScriptCore/runtime/ArrayBuffer.cpp:
(JSC::errorMessageForTransfer):
(JSC::errorMesasgeForTransfer): Deleted.
* Source/JavaScriptCore/runtime/ArrayBuffer.h:
* Source/WebCore/bindings/js/SerializedScriptValue.cpp:
(WebCore::SerializedScriptValue::create):

Canonical link: https://commits.webkit.org/259486@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 0ab19d: Update webkit.org trac source code links to GitHub

[Brandon Stewart]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 0ab19d727b810ae14cb6b3559c4c199411d594e7
  
https://github.com/WebKit/WebKit/commit/0ab19d727b810ae14cb6b3559c4c199411d594e7
  Author: Brandon Stewart 
  Date:   2023-01-25 (Wed, 25 Jan 2023)

  Changed paths:
M Websites/webkit.org/commit-review.md
M Websites/webkit.org/docs/b3/assembly-intermediate-representation.html
M Websites/webkit.org/docs/b3/intermediate-representation.html

  Log Message:
  ---
  Update webkit.org trac source code links to GitHub
https://bugs.webkit.org/show_bug.cgi?id=251128

Reviewed by Jonathan Bedard.

Update the source code links from trac to github on webkit.org.
We have moved over our development to posting patches on GitHub, so it seems 
nicer
to point at the GitHub repo instead.

* Websites/webkit.org/commit-review.md:
* Websites/webkit.org/docs/b3/assembly-intermediate-representation.html:
* Websites/webkit.org/docs/b3/intermediate-representation.html:

Canonical link: https://commits.webkit.org/259362@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 3c270c: Masonry use calculated height instead of estimated...

[Brandon Stewart]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 3c270c15b7888c72d8d10e29bc43e40dba71e1d2
  
https://github.com/WebKit/WebKit/commit/3c270c15b7888c72d8d10e29bc43e40dba71e1d2
  Author: Brandon Stewart 
  Date:   2023-01-24 (Tue, 24 Jan 2023)

  Changed paths:
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/item-placement/masonry-item-placement-008-expected.html
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/item-placement/masonry-item-placement-008-ref.html
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/item-placement/masonry-item-placement-008.html
M Source/WebCore/rendering/GridMasonryLayout.cpp
M Source/WebCore/rendering/GridTrackSizingAlgorithm.cpp
M Source/WebCore/rendering/GridTrackSizingAlgorithm.h

  Log Message:
  ---
  Masonry use calculated height instead of estimated height
https://bugs.webkit.org/show_bug.cgi?id=250720

Reviewed by Matt Woodrow.

The masonry calculations were being done before we had a done a proper layout.
With some refactoring the masonry layout was pushed back in the chain. This 
allows
the children content to have calculated the widths and heights. Now, we can just
use the real widths and heights instead of relying on the estimated ones.

* Source/WebCore/rendering/GridMasonryLayout.cpp:
(WebCore::GridMasonryLayout::setItemGridAxisContainingBlockToGridArea):
* Source/WebCore/rendering/GridTrackSizingAlgorithm.cpp:
(WebCore::GridTrackSizingAlgorithm::gridAreaBreadthForChild const):
* Source/WebCore/rendering/GridTrackSizingAlgorithm.h:
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/item-placement/masonry-item-placement-008-expected.html:
 Added.
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/item-placement/masonry-item-placement-008-ref.html:
 Added.
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/item-placement/masonry-item-placement-008.html:
 Added.

Canonical link: https://commits.webkit.org/259308@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 929973: Fix ASSERT crash in masonry-grid-template-columns-...

[Brandon Stewart]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 929973a6b81a666841b16576a184e7d45edd610b
  
https://github.com/WebKit/WebKit/commit/929973a6b81a666841b16576a184e7d45edd610b
  Author: Brandon Stewart 
  Date:   2023-01-09 (Mon, 09 Jan 2023)

  Changed paths:
M LayoutTests/TestExpectations
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/masonry-grid-template-columns-computed-withcontent-expected.txt
M Source/WebCore/rendering/RenderGrid.cpp

  Log Message:
  ---
  Fix ASSERT crash in masonry-grid-template-columns-computed-withcontent.html
https://bugs.webkit.org/show_bug.cgi?id=250349

Reviewed by Matt Woodrow.

This test case was crashing due to an assert being triggered by 
m_autoRepeatTotalTracks being set to 0
in OrderedNamedLinesCollectorInGridLayout::collectLineNamesForIndex. The crash 
is caused by
set needs items placement, which was reseting the auto repeat tracks. We never 
set them again leading to the
crash later on.

* LayoutTests/TestExpectations:
* Source/WebCore/rendering/RenderGrid.cpp:
(WebCore::RenderGrid::placeItemsOnGrid):

Canonical link: https://commits.webkit.org/258700@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 813f05: Update Masonry to Preview

[Brandon Stewart]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 813f05167ea5885831eb6e2dd7797685bce21fbc
  
https://github.com/WebKit/WebKit/commit/813f05167ea5885831eb6e2dd7797685bce21fbc
  Author: Brandon Stewart 
  Date:   2023-01-09 (Mon, 09 Jan 2023)

  Changed paths:
M Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml

  Log Message:
  ---
  Update Masonry to Preview
https://bugs.webkit.org/show_bug.cgi?id=250328

Reviewed by Brent Fulgham.

Update Masonry to preview from testable.

* Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml:

Canonical link: https://commits.webkit.org/258694@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 7da5d9: Masonry Alignment and Spacing align-tracks and jus...

[Brandon Stewart]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 7da5d95cea57de320f5eebdf30e3cadacb3d7186
  
https://github.com/WebKit/WebKit/commit/7da5d95cea57de320f5eebdf30e3cadacb3d7186
  Author: Brandon Stewart 
  Date:   2023-01-06 (Fri, 06 Jan 2023)

  Changed paths:
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-align/parsing/align-tracks-computed-expected.txt
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-align/parsing/align-tracks-computed.html
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-align/parsing/align-tracks-invalid-expected.txt
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-align/parsing/align-tracks-invalid.html
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-align/parsing/align-tracks-valid-expected.txt
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-align/parsing/align-tracks-valid.html
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-align/parsing/justify-tracks-computed-expected.txt
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-align/parsing/justify-tracks-computed.html
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-align/parsing/justify-tracks-invalid-expected.txt
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-align/parsing/justify-tracks-invalid.html
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-align/parsing/justify-tracks-valid-expected.txt
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-align/parsing/justify-tracks-valid.html
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-cascade/all-prop-revert-layer-expected.txt
M Source/WebCore/animation/CSSPropertyAnimation.cpp
M Source/WebCore/css/CSSProperties.json
M Source/WebCore/css/CSSValueKeywords.in
M Source/WebCore/css/ComputedStyleExtractor.cpp
M Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp
M Source/WebCore/css/parser/CSSPropertyParserHelpers.h
M Source/WebCore/rendering/style/RenderStyle.h
M Source/WebCore/rendering/style/StyleGridData.cpp
M Source/WebCore/rendering/style/StyleGridData.h
M Source/WebCore/style/StyleBuilderConverter.h

  Log Message:
  ---
  Masonry Alignment and Spacing align-tracks and justify-tracks
https://bugs.webkit.org/show_bug.cgi?id=248835
rdar://102782713

Reviewed by Tim Nguyen.

Add initial support for align-tracks and justify-tracks in Masonry layout.
These new properties resemble align-content and justify-content, with the 
addition of being able
to have multiple items so you can specify for each track.

* Source/WebCore/animation/CSSPropertyAnimation.cpp:
(WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap):
* Source/WebCore/css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::operator AlignTracks const):
(WebCore::CSSPrimitiveValue::operator JustifyTracks const):
* Source/WebCore/css/CSSProperties.json:
* Source/WebCore/css/CSSValueKeywords.in:
* Source/WebCore/css/ComputedStyleExtractor.cpp:
(WebCore::ComputedStyleExtractor::valueForPropertyInStyle):
* Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp:
(WebCore::CSSPropertyParserHelpers::consumeAlignTracks):
(WebCore::CSSPropertyParserHelpers::consumeJustifyTracks):
* Source/WebCore/css/parser/CSSPropertyParserHelpers.h:
* Source/WebCore/rendering/style/RenderStyle.h:
(WebCore::RenderStyle::alignTracks const):
(WebCore::RenderStyle::justifyTracks const):
(WebCore::RenderStyle::setAlignTracks):
(WebCore::RenderStyle::setJustifyTracks):
(WebCore::RenderStyle::initialAlignTracks):
(WebCore::RenderStyle::initialJustifyTracks):
* Source/WebCore/rendering/style/RenderStyleConstants.h:
* Source/WebCore/rendering/style/StyleGridData.cpp:
(WebCore::StyleGridData::StyleGridData):
* Source/WebCore/rendering/style/StyleGridData.h:
(WebCore::StyleGridData::operator== const):
* Source/WebCore/style/StyleBuilderConverter.h:
(WebCore::Style::BuilderConverter::convertAlignTracks):
(WebCore::Style::BuilderConverter::convertJustifyTracks):

Canonical link: https://commits.webkit.org/258544@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 941d50: Align Masonry Track Sizing Tests with WPT

[Brandon Stewart]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 941d50ec8f2c74a2c2007458f33638914ef683f2
  
https://github.com/WebKit/WebKit/commit/941d50ec8f2c74a2c2007458f33638914ef683f2
  Author: Brandon Stewart 
  Date:   2023-01-04 (Wed, 04 Jan 2023)

  Changed paths:
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/track-sizing/masonry-track-sizing-overflow-left-side-expected.html
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/track-sizing/masonry-track-sizing-overflow-left-side-ref.html
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/track-sizing/masonry-track-sizing-overflow-left-side.html
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/track-sizing/masonry-track-sizing-overflow-right-side-expected.html
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/track-sizing/masonry-track-sizing-overflow-right-side-ref.html
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/track-sizing/masonry-track-sizing-overflow-right-side.html

  Log Message:
  ---
  Align Masonry Track Sizing Tests with WPT
https://bugs.webkit.org/show_bug.cgi?id=250098

Reviewed by Tim Nguyen.

Had to make several small whitespace changes and a small ref fix up
when exporting to the WPT repo.

* 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/track-sizing/masonry-track-sizing-overflow-left-side-expected.html:
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/track-sizing/masonry-track-sizing-overflow-left-side-ref.html:
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/track-sizing/masonry-track-sizing-overflow-left-side.html:
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/track-sizing/masonry-track-sizing-overflow-right-side-expected.html:
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/track-sizing/masonry-track-sizing-overflow-right-side-ref.html:
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/track-sizing/masonry-track-sizing-overflow-right-side.html:

Canonical link: https://commits.webkit.org/258444@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] b93352: Skip masonry-columns-item-placement-auto-flow-next...

[Brandon Stewart]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: b93352783c4cc119de0d978f03235d11847beaee
  
https://github.com/WebKit/WebKit/commit/b93352783c4cc119de0d978f03235d11847beaee
  Author: Brandon Stewart 
  Date:   2023-01-03 (Tue, 03 Jan 2023)

  Changed paths:
M LayoutTests/TestExpectations

  Log Message:
  ---
  Skip masonry-columns-item-placement-auto-flow-next-001.html due to consistent 
failures on iOS
https://bugs.webkit.org/show_bug.cgi?id=250028
rdar://103836338

Reviewed by Brent Fulgham.

Skip test case for now due to failures on iOS.

* LayoutTests/TestExpectations:

Canonical link: https://commits.webkit.org/258418@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 7a7910: Add Masonry Track Sizing Tests

[Brandon Stewart]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 7a79101a21e1462bee8dc459dfa4b6745c81ae3e
  
https://github.com/WebKit/WebKit/commit/7a79101a21e1462bee8dc459dfa4b6745c81ae3e
  Author: Brandon Stewart 
  Date:   2023-01-03 (Tue, 03 Jan 2023)

  Changed paths:
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/track-sizing/masonry-track-sizing-explicit-block-expected.html
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/track-sizing/masonry-track-sizing-explicit-block-ref.html
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/track-sizing/masonry-track-sizing-explicit-block.html
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/track-sizing/masonry-track-sizing-span-row-expected.html
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/track-sizing/masonry-track-sizing-span-row-ref.html
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/track-sizing/masonry-track-sizing-span-row.html

  Log Message:
  ---
  Add Masonry Track Sizing Tests
https://bugs.webkit.org/show_bug.cgi?id=249860

Reviewed by Brent Fulgham.

Add tests to ensure track sizing functionality is working for definite blocks 
and
full row spanning blocks.

* 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/track-sizing/masonry-track-sizing-explicit-block-expected.html:
 Added.
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/track-sizing/masonry-track-sizing-explicit-block-ref.html:
 Added.
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/track-sizing/masonry-track-sizing-explicit-block.html:
 Added.
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/track-sizing/masonry-track-sizing-span-row-expected.html:
 Added.
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/track-sizing/masonry-track-sizing-span-row-ref.html:
 Added.
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/track-sizing/masonry-track-sizing-span-row.html:
 Added.

Canonical link: https://commits.webkit.org/258409@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 02a5e3: Cleanup Changelog Scripts

[Brandon Stewart]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 02a5e30761fc261f874b36fa03f2e6c41958de22
  
https://github.com/WebKit/WebKit/commit/02a5e30761fc261f874b36fa03f2e6c41958de22
  Author: Brandon Stewart 
  Date:   2023-01-03 (Tue, 03 Jan 2023)

  Changed paths:
R Tools/Scripts/roll-over-ChangeLogs

  Log Message:
  ---
  Cleanup Changelog Scripts
https://bugs.webkit.org/show_bug.cgi?id=250021

Reviewed by Brent Fulgham.

Remove roll-over-changelogs as Changelogs were removed last year.

* Tools/Scripts/roll-over-ChangeLogs: Removed.

Canonical link: https://commits.webkit.org/258401@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] f54ab6: Rename WTF_OS_MAC_OS_X to WTF_OS_MACOS

[Brandon Stewart]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: f54ab6989687aa9553200b7e96e326024333e2c6
  
https://github.com/WebKit/WebKit/commit/f54ab6989687aa9553200b7e96e326024333e2c6
  Author: Brandon Stewart 
  Date:   2022-12-30 (Fri, 30 Dec 2022)

  Changed paths:
M Source/JavaScriptCore/shell/CMakeLists.txt
M Source/WTF/wtf/PlatformLegacy.h
M Source/WTF/wtf/PlatformOS.h
M Source/WebCore/html/shadow/SpinButtonElement.cpp
M Source/WebCore/page/NavigatorBase.cpp
M Source/WebCore/platform/glib/UserAgentGLib.cpp
M Source/WebKit/config.h
M Source/cmake/WebKitCommon.cmake
M Tools/WebKitTestRunner/InjectedBundle/EventSendingController.cpp

  Log Message:
  ---
  Rename WTF_OS_MAC_OS_X to WTF_OS_MACOS
https://bugs.webkit.org/show_bug.cgi?id=249950

Reviewed by Simon Fraser.

Update WTF_OS_MAC_OS_X to WTF_OS_MACOS and remove FIXME comment.

* Source/JavaScriptCore/shell/CMakeLists.txt:
* Source/WTF/wtf/PlatformOS.h:
* Source/cmake/WebKitCommon.cmake:

Canonical link: https://commits.webkit.org/258363@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 46e8aa: Refactor spots checking if the grid is Masonry

[Brandon Stewart]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 46e8aa67857469452ae492cac0b7fc254218e6e6
  
https://github.com/WebKit/WebKit/commit/46e8aa67857469452ae492cac0b7fc254218e6e6
  Author: Brandon Stewart 
  Date:   2022-12-23 (Fri, 23 Dec 2022)

  Changed paths:
M Source/WebCore/rendering/GridTrackSizingAlgorithm.cpp
M Source/WebCore/rendering/RenderGrid.cpp
M Source/WebCore/rendering/RenderGrid.h

  Log Message:
  ---
  Refactor spots checking if the grid is Masonry
https://bugs.webkit.org/show_bug.cgi?id=249843

Reviewed by Matt Woodrow.

Refactor out checking if a function isMasonry or not based on Matt's feedback 
in the
last patch.

* Source/WebCore/rendering/GridTrackSizingAlgorithm.cpp:
(WebCore::GridTrackSizingAlgorithm::accumulateIntrinsicSizesForTrack):
(WebCore::GridTrackSizingAlgorithm::run):
(WebCore::GridTrackSizingAlgorithm::isDirectionInMasonryDirection const):
* Source/WebCore/rendering/RenderGrid.cpp:
(WebCore::RenderGrid::isMasonry const):
* Source/WebCore/rendering/RenderGrid.h:

Canonical link: https://commits.webkit.org/258315@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 3c5823: Implement Masonry Track Sizing

[Brandon Stewart]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 3c5823bb309e94722ae6028f80166daa2d448f4e
  
https://github.com/WebKit/WebKit/commit/3c5823bb309e94722ae6028f80166daa2d448f4e
  Author: Brandon Stewart 
  Date:   2022-12-22 (Thu, 22 Dec 2022)

  Changed paths:
M LayoutTests/TestExpectations
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/track-sizing/masonry-track-sizing-overflow-left-side-expected.html
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/track-sizing/masonry-track-sizing-overflow-left-side-ref.html
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/track-sizing/masonry-track-sizing-overflow-left-side.html
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/track-sizing/masonry-track-sizing-overflow-right-side-expected.html
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/track-sizing/masonry-track-sizing-overflow-right-side-ref.html
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/track-sizing/masonry-track-sizing-overflow-right-side.html
M Source/WebCore/rendering/GridMasonryLayout.h
M Source/WebCore/rendering/GridTrackSizingAlgorithm.cpp
M Source/WebCore/rendering/RenderGrid.cpp

  Log Message:
  ---
  Implement Masonry Track Sizing
https://bugs.webkit.org/show_bug.cgi?id=248287

Reviewed by Matt Woodrow.

Track sizing will only include blocks if they meet the below criteria in the 
track sizing algorithm.

- Items placed at the first implicit line in the masonry axis.
- Items that have a specified definite placement in the grid axis
- Items that span all grid axis tracks.

The masonry calling code needed to be heavily refactored to a later step in 
layout pipeline.
This ended breaking quite a few test cases, which will be addressed in future 
patches.

* LayoutTests/TestExpectations:
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/track-sizing/masonry-track-sizing-overflow-left-side-ref.html:
 Added.
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/track-sizing/masonry-track-sizing-overflow-left-side.html:
 Added.
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/track-sizing/masonry-track-sizing-overflow-right-side-ref.html:
 Added.
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/track-sizing/masonry-track-sizing-overflow-right-side.html:
 Added.
* 
LayoutTests/platform/mac/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/track-sizing/masonry-track-sizing-overflow-left-side-expected.txt:
 Added.
* 
LayoutTests/platform/mac/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/track-sizing/masonry-track-sizing-overflow-right-side-expected.txt:
 Added.
* Source/WebCore/rendering/GridMasonryLayout.h:
(WebCore::GridMasonryLayout::gridGap const):
* Source/WebCore/rendering/GridTrackSizingAlgorithm.cpp:
(WebCore::GridTrackSizingAlgorithm::accumulateIntrinsicSizesForTrack):
(WebCore::GridTrackSizingAlgorithm::run):
* Source/WebCore/rendering/RenderGrid.cpp:
(WebCore::RenderGrid::layoutBlock):
(WebCore::RenderGrid::placeItemsOnGrid):
(WebCore::RenderGrid::autoPlacementMinorAxisDirection const):

Canonical link: https://commits.webkit.org/258280@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] be2f46: Update WK1 TestExpectation for geolocation-API/per...

[Brandon Stewart]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: be2f467383e0e145c64177fd7742ac7a12053222
  
https://github.com/WebKit/WebKit/commit/be2f467383e0e145c64177fd7742ac7a12053222
  Author: Brandon Stewart 
  Date:   2022-12-20 (Tue, 20 Dec 2022)

  Changed paths:
M LayoutTests/platform/mac-wk1/TestExpectations

  Log Message:
  ---
  Update WK1 TestExpectation for geolocation-API/permission.https.html to 
WontFix
https://bugs.webkit.org/show_bug.cgi?id=249657

Reviewed by Alexey Proskuryakov.

We do not support Generic Permissions API in WK1. Changing to WontFix and 
updated
the comment in TestExpectations.

* LayoutTests/platform/mac-wk1/TestExpectations:

Canonical link: https://commits.webkit.org/258148@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes