[webkit-changes] [WebKit/WebKit] e0b44d: Apply Markable to FontMetrics for consistency

[ChangSeok Oh]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: e0b44ddffaafdfc7549ba4cf4638e12f0ee53556
  
https://github.com/WebKit/WebKit/commit/e0b44ddffaafdfc7549ba4cf4638e12f0ee53556
  Author: ChangSeok Oh 
  Date:   2024-02-14 (Wed, 14 Feb 2024)

  Changed paths:
M Source/WebCore/css/CSSPrimitiveValue.cpp
M Source/WebCore/html/HTMLInputElement.cpp
M Source/WebCore/html/canvas/CanvasRenderingContext2DBase.cpp
M Source/WebCore/inspector/InspectorOverlay.cpp
M Source/WebCore/inspector/InspectorOverlayLabel.cpp
M Source/WebCore/layout/formattingContexts/inline/InlineLevelBox.h
M Source/WebCore/layout/formattingContexts/inline/InlineLineBox.cpp
M Source/WebCore/layout/formattingContexts/inline/InlineLineBoxBuilder.cpp
M 
Source/WebCore/layout/formattingContexts/inline/InlineLineBoxVerticalAligner.cpp
M Source/WebCore/layout/formattingContexts/inline/InlineQuirks.cpp
M 
Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayContentBuilder.cpp
M 
Source/WebCore/layout/formattingContexts/inline/ruby/RubyFormattingContext.cpp
M Source/WebCore/layout/integration/inline/LayoutIntegrationPagination.cpp
M Source/WebCore/platform/graphics/Font.cpp
M Source/WebCore/platform/graphics/FontCascade.cpp
M Source/WebCore/platform/graphics/FontMetrics.h
M Source/WebCore/platform/graphics/FontSizeAdjust.h
M Source/WebCore/platform/graphics/PositionedGlyphs.cpp
M Source/WebCore/platform/graphics/coretext/DrawGlyphsRecorderCoreText.cpp
M Source/WebCore/platform/graphics/coretext/FontCascadeCoreText.cpp
M Source/WebCore/platform/graphics/coretext/FontCoreText.cpp
M Source/WebCore/platform/graphics/opentype/OpenTypeVerticalData.cpp
M Source/WebCore/platform/win/DragImageWin.cpp
M Source/WebCore/rendering/CaretRectComputation.cpp
M Source/WebCore/rendering/EllipsisBoxPainter.cpp
M Source/WebCore/rendering/LegacyEllipsisBox.cpp
M Source/WebCore/rendering/LegacyInlineBox.cpp
M Source/WebCore/rendering/LegacyInlineFlowBox.cpp
M Source/WebCore/rendering/LegacyLineLayout.cpp
M Source/WebCore/rendering/LegacyRootInlineBox.cpp
M Source/WebCore/rendering/RenderBlock.cpp
M Source/WebCore/rendering/RenderBlockFlow.cpp
M Source/WebCore/rendering/RenderEmbeddedObject.cpp
M Source/WebCore/rendering/RenderFileUploadControl.cpp
M Source/WebCore/rendering/RenderImage.cpp
M Source/WebCore/rendering/RenderInline.cpp
M Source/WebCore/rendering/RenderLineBreak.cpp
M Source/WebCore/rendering/RenderListBox.cpp
M Source/WebCore/rendering/RenderListMarker.cpp
M Source/WebCore/rendering/RenderRubyRun.cpp
M Source/WebCore/rendering/TextBoxPainter.cpp
M Source/WebCore/rendering/TextPainter.cpp
M Source/WebCore/rendering/mathml/RenderMathMLBlock.cpp
M Source/WebCore/rendering/mathml/RenderMathMLRoot.cpp
M Source/WebCore/rendering/mathml/RenderMathMLScripts.cpp
M Source/WebCore/rendering/mathml/RenderMathMLUnderOver.cpp
M Source/WebCore/rendering/style/RenderStyle.cpp
M Source/WebCore/rendering/style/TextDecorationThickness.h
M Source/WebCore/rendering/svg/RenderSVGInlineText.cpp
M Source/WebCore/rendering/svg/SVGInlineTextBox.cpp
M Source/WebCore/rendering/svg/SVGTextLayoutEngineBaseline.cpp
M Source/WebCore/rendering/svg/SVGTextMetrics.cpp
M Source/WebCore/rendering/svg/SVGTextQuery.cpp
M Source/WebCore/rendering/updating/RenderTreeBuilderFirstLetter.cpp
M Source/WebCore/style/InlineTextBoxStyle.cpp
M Source/WebCore/style/StyleFontSizeFunctions.cpp
M Source/WebCore/svg/SVGLengthContext.cpp
M Source/WebKit/WebProcess/WebCoreSupport/win/WebPopupMenuWin.cpp
M Source/WebKit/WebProcess/WebPage/Cocoa/WebPageCocoa.mm
M Source/WebKitLegacy/mac/WebView/WebImmediateActionController.mm

  Log Message:
  ---
  Apply Markable to FontMetrics for consistency
https://bugs.webkit.org/show_bug.cgi?id=255378

Reviewed by Alan Baradlay and Matthieu Dubet.

This change aims at cleaning up the FontMetrics interface. There are three
inconsistencies in this class, which could mislead developers.

1. Inconsistent type of get/set methods. The set methods take float, but the
   corresponding get functions return int.
2. Inconsistent return types of get methods. For example, The height() returns
   an int, but the xHeight() returns a float.
3. Inconsistent validity checks. The xHeight and capHeight use their own has*
   functions, but the zeroWidth uses std::optional. Others font metrics do not
   provide any validity check methods.

This change applies Markable to FontMetrics and makes its interface
in the following way:

1. Each get method returns a float as default. To get an int value, callers
   should explicitly call the int* methods. (e.g., ascent() returns float and
   intAscent() returns int.)
2. Each font metric value is returned as a Markable value. So callers can check
   the validity

[webkit-changes] [WebKit/WebKit] 0579d0: The --export-compile-commands option for build-web...

[ChangSeok Oh]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 0579d0e2c508a74054d935809ff429b4caad7ee2
  
https://github.com/WebKit/WebKit/commit/0579d0e2c508a74054d935809ff429b4caad7ee2
  Author: ChangSeok Oh 
  Date:   2023-11-07 (Tue, 07 Nov 2023)

  Changed paths:
M Tools/Scripts/build-webkit
M Tools/Scripts/webkitdirs.pm
M Tools/Scripts/webkitperl/BuildSubproject.pm

  Log Message:
  ---
  The --export-compile-commands option for build-webkit is broken.
https://bugs.webkit.org/show_bug.cgi?id=264239

Reviewed by Elliott Williams.

The build-webkit with --export-compile-commands on macOS does not produce
compile_commands.json. In bug 235686 [1], we added the support of exporting
compile_commands.json to the make build. This change brings the same
support into the build-webkit script.

[1] https://webkit.org/b/235686

* Tools/Scripts/build-webkit:
* Tools/Scripts/webkitdirs.pm:
(XcodeExportCompileCommandsOptions):
* Tools/Scripts/webkitperl/BuildSubproject.pm:

Canonical link: https://commits.webkit.org/270348@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 033598: Build failure of AccessibilityNotificationHandler.cpp

[ChangSeok Oh]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 0335988960faf5c9255a4769389625cd8150392b
  
https://github.com/WebKit/WebKit/commit/0335988960faf5c9255a4769389625cd8150392b
  Author: ChangSeok Oh 
  Date:   2023-11-07 (Tue, 07 Nov 2023)

  Changed paths:
M 
Tools/WebKitTestRunner/InjectedBundle/atspi/AccessibilityNotificationHandler.cpp

  Log Message:
  ---
  Build failure of AccessibilityNotificationHandler.cpp
https://bugs.webkit.org/show_bug.cgi?id=264207

Reviewed by Michael Catanzaro.

The constructor and destructor of AccessibilityNotificationHandler use methods
guarded by DEVELOPER_MODE.

* 
Tools/WebKitTestRunner/InjectedBundle/atspi/AccessibilityNotificationHandler.cpp:
(WTR::AccessibilityNotificationHandler::AccessibilityNotificationHandler):
(WTR::AccessibilityNotificationHandler::~AccessibilityNotificationHandler):

Canonical link: https://commits.webkit.org/270333@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 4172b6: text-decoration-thickness should support percentages

[ChangSeok Oh]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 4172b60326a851840071774f9b1341c8147c6718
  
https://github.com/WebKit/WebKit/commit/4172b60326a851840071774f9b1341c8147c6718
  Author: ChangSeok Oh 
  Date:   2023-10-28 (Sat, 28 Oct 2023)

  Changed paths:
M LayoutTests/TestExpectations
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-text-decor/animations/discrete-no-interpolation-expected.txt
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-text-decor/animations/text-decoration-thickness-interpolation-expected.txt
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-text-decor/animations/text-decoration-thickness-interpolation.html
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-text-decor/text-decoration-thickness-calc-expected.html
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-text-decor/text-decoration-thickness-calc-ref.html
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-text-decor/text-decoration-thickness-calc.html
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-text-decor/text-decoration-thickness-computed-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-text-decor/text-decoration-thickness-computed.html
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-text-decor/text-decoration-thickness-valid-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/text-decoration-thickness-expected.txt
M Source/WebCore/animation/CSSPropertyAnimation.cpp
M Source/WebCore/css/CSSProperties.json
M Source/WebCore/css/ComputedStyleExtractor.cpp
M Source/WebCore/rendering/style/RenderStyle.h
M Source/WebCore/rendering/style/RenderStyleInlines.h
M Source/WebCore/rendering/style/TextDecorationThickness.h
M Source/WebCore/style/StyleBuilderConverter.h

  Log Message:
  ---
  text-decoration-thickness should support percentages
https://bugs.webkit.org/show_bug.cgi?id=262866

Reviewed by Tim Nguyen.

This change adds support of percentage to text-decoration-thickness [1].

The text-decoration-thickness-interpolation.html is newly added to evaluate 
interpolation
between various length types. The updated 
text-decoration-thickness-computed.html
verifies calc() computation with em, %, and px values. And
text-decoration-thickness-calc.html verifies the actual rendering.

Test: 
imported/w3c/web-platform-tests/css/css-fonts/size-adjust-text-decoration.tentative.html
  
imported/w3c/web-platform-tests/css/css-text-decor/animations/discrete-no-interpolation.html
  
imported/w3c/web-platform-tests/css/css-text-decor/animations/text-decoration-thickness-interpolation.html
  
imported/w3c/web-platform-tests/css/css-text-decor/text-decoration-thickness-calc.html
  
imported/w3c/web-platform-tests/css/css-text-decor/text-decoration-thickness-computed.html
  
imported/w3c/web-platform-tests/css/css-text-decor/text-decoration-thickness-fixed.html
  
imported/w3c/web-platform-tests/css/css-text-decor/text-decoration-thickness-valid.html
  
imported/w3c/web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/text-decoration-thickness.html

[1] 
https://drafts.csswg.org/css-text-decor-4/#valdef-text-decoration-thickness-percentage

* LayoutTests/TestExpectations:
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-text-decor/animations/discrete-no-interpolation-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-text-decor/animations/text-decoration-thickness-interpolation-expected.txt:
 Added.
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-text-decor/animations/text-decoration-thickness-interpolation.html:
 Added.
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-text-decor/text-decoration-thickness-calc-expected.html:
 Added.
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-text-decor/text-decoration-thickness-calc-ref.html:
 Added.
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-text-decor/text-decoration-thickness-calc.html:
 Added.
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-text-decor/text-decoration-thickness-computed-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-text-decor/text-decoration-thickness-computed.html:
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-text-decor/text-decoration-thickness-valid-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/text-decoration-thickness-expected.txt:
* Source/WebCore/animation/CSSPropertyAnimation.cpp:
(WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap):
* Source/WebCore/css/CSSProperties.json:
* Source/WebCore/css/ComputedStyleExtractor.cpp:
(WebCore::textDecorationThicknessToCSSValue):
(WebCore::ComputedStyleExtractor::valueForPropertyInStyle const):
* Source/WebCore/rendering/style/RenderStyle.h:
* Source/WebCore/rendering/style/RenderStyleInlines.h

[webkit-changes] [WebKit/WebKit] 39f8d3: Import css/css-text-decor/animations tests from th...

[ChangSeok Oh]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 39f8d3a5c26cd0ebe9ebc95710075184d540f011
  
https://github.com/WebKit/WebKit/commit/39f8d3a5c26cd0ebe9ebc95710075184d540f011
  Author: ChangSeok Oh 
  Date:   2023-10-17 (Tue, 17 Oct 2023)

  Changed paths:
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-text-decor/animations/discrete-no-interpolation-expected.txt
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-text-decor/animations/discrete-no-interpolation.html
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-text-decor/animations/text-underline-offset-interpolation-expected.txt
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-text-decor/animations/text-underline-offset-interpolation.html

  Log Message:
  ---
  Import css/css-text-decor/animations tests from the latest WPT
https://bugs.webkit.org/show_bug.cgi?id=263241

Reviewed by Tim Nguyen.

This change imports animation tests related to CSS Text Decoration from
upstream WPT. We will use them to verify the animation of
text-decoration-thickness in this PR [1].

WPT hash for this import: 3d084c0ac239eff15e62958a18b5508203dc2aaa

[1] https://github.com/WebKit/WebKit/pull/19085

* 
LayoutTests/imported/w3c/web-platform-tests/css/css-text-decor/animations/discrete-no-interpolation-expected.txt:
 Added.
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-text-decor/animations/discrete-no-interpolation.html:
 Added.
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-text-decor/animations/text-underline-offset-interpolation-expected.txt:
 Added.
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-text-decor/animations/text-underline-offset-interpolation.html:
 Added.

Canonical link: https://commits.webkit.org/269447@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] d0c48f: Update fallback-url-to-local.html and its expected...

[ChangSeok Oh]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: d0c48f7ae3442165f9b92239cf5b4fbee3c255da
  
https://github.com/WebKit/WebKit/commit/d0c48f7ae3442165f9b92239cf5b4fbee3c255da
  Author: ChangSeok Oh 
  Date:   2023-10-12 (Thu, 12 Oct 2023)

  Changed paths:
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/fallback-url-to-local-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/fallback-url-to-local.html

  Log Message:
  ---
  Update fallback-url-to-local.html and its expected result.
https://bugs.webkit.org/show_bug.cgi?id=263064

Reviewed by Tim Nguyen.

A WPT test, fallback-url-to-local.html, had a bug, and it has been fixed since 
[1].
This change re-imports the test and updates the expected result accordingly.

[1] https://github.com/web-platform-tests/wpt/pull/42368

* 
LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/fallback-url-to-local-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/fallback-url-to-local.html:

Canonical link: https://commits.webkit.org/269263@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] cfb200: [CSS Fonts] font-size-adjust adopts ValueType and ...

[ChangSeok Oh]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: cfb200931b4c0c03c4d00639c733ffb6b752016e
  
https://github.com/WebKit/WebKit/commit/cfb200931b4c0c03c4d00639c733ffb6b752016e
  Author: ChangSeok Oh 
  Date:   2023-10-09 (Mon, 09 Oct 2023)

  Changed paths:
M Source/WebCore/animation/CSSPropertyAnimation.cpp
M Source/WebCore/css/ComputedStyleExtractor.cpp
M Source/WebCore/platform/graphics/FontCascadeCache.h
M Source/WebCore/platform/graphics/FontCascadeFonts.h
M Source/WebCore/platform/graphics/FontSizeAdjust.h
M Source/WebCore/style/StyleBuilderConverter.h

  Log Message:
  ---
  [CSS Fonts] font-size-adjust adopts ValueType and isNone().
https://bugs.webkit.org/show_bug.cgi?id=262882

Reviewed by Tim Nguyen.

To improve code readability, this change replaces a boolean with an enum class,
which represents the from-font value type of FontSizeAdjust. In addition, this
patch changes the boolean operator of FontSizeAdjust to an explicit method name
called isNone() as a follow-up of 269041@main [1].

[1] https://commits.webkit.org/269041@main

* Source/WebCore/animation/CSSPropertyAnimation.cpp:
* Source/WebCore/css/ComputedStyleExtractor.cpp:
(WebCore::fontSizeAdjustFromStyle):
(WebCore::fontShorthandValue):
* Source/WebCore/platform/graphics/FontCascadeCache.h:
(WebCore::FontDescriptionKey::FontDescriptionKey):
* Source/WebCore/platform/graphics/FontCascadeFonts.h:
(WebCore::FontCascadeFonts::primaryFont):
* Source/WebCore/platform/graphics/FontSizeAdjust.h:
(WebCore::FontSizeAdjust::isNone const):
(WebCore::FontSizeAdjust::isFromFont const):
(WebCore::add):
(WebCore::operator<<):
(WebCore::FontSizeAdjust::operator bool const): Deleted.
* Source/WebCore/style/StyleBuilderConverter.h:
(WebCore::Style::BuilderConverter::convertFontSizeAdjust):

Canonical link: https://commits.webkit.org/269124@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 00b96b: [CSS Fonts] getComputedStyle() should return a res...

[ChangSeok Oh]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 00b96b0c358272590abe1075865af8e706b213c1
  
https://github.com/WebKit/WebKit/commit/00b96b0c358272590abe1075865af8e706b213c1
  Author: ChangSeok Oh 
  Date:   2023-10-09 (Mon, 09 Oct 2023)

  Changed paths:
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/parsing/font-size-adjust-computed-expected.txt
M Source/WebCore/css/ComputedStyleExtractor.cpp

  Log Message:
  ---
  [CSS Fonts] getComputedStyle() should return a resolved value for 
font-size-adjust:from-font
https://bugs.webkit.org/show_bug.cgi?id=262147

Reviewed by Tim Nguyen.

We returned the from-font identifier for font-size-adjust as a computed style
value. But it was an incorrect behavior. This change makes getComputedStyle()
return an actual numeric value of the from-font for font-size-adjust instead.

Test: 
imported/w3c/web-platform-tests/css/css-fonts/parsing/font-size-adjust-computed.html

* 
LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/parsing/font-size-adjust-computed-expected.txt:
* Source/WebCore/css/ComputedStyleExtractor.cpp:
(WebCore::fontSizeAdjustFromStyle):

Canonical link: https://commits.webkit.org/269084@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 89bdb0: [CSS Fonts] The `from-font` value for CSS `font-si...

[ChangSeok Oh]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 89bdb0336c3b32a4130822ed976d858538e0d596
  
https://github.com/WebKit/WebKit/commit/89bdb0336c3b32a4130822ed976d858538e0d596
  Author: ChangSeok Oh 
  Date:   2023-10-07 (Sat, 07 Oct 2023)

  Changed paths:
M LayoutTests/TestExpectations
M Source/WebCore/css/ComputedStyleExtractor.cpp
M Source/WebCore/platform/graphics/FontCascade.h
M Source/WebCore/platform/graphics/FontCascadeCache.h
M Source/WebCore/platform/graphics/FontCascadeFonts.h
M Source/WebCore/platform/graphics/FontSizeAdjust.h
M Source/WebCore/style/StyleBuilderConverter.h
M Source/WebCore/style/StyleFontSizeFunctions.cpp
M Source/WebCore/style/StyleFontSizeFunctions.h

  Log Message:
  ---
  [CSS Fonts] The `from-font` value for CSS `font-size-adjust` is not computed 
correctly
https://bugs.webkit.org/show_bug.cgi?id=259551

Reviewed by Tim Nguyen.

When resolving styles, we used the parent-style font to compute the aspect ratio
for font-size-adjust: from-font because the first available font could not be
determined at that moment. Unfortunately, this causes the failure of
font-size-adjust-014.html. To make the test happy, we should defer resolving
the aspect value after determining a primary font. Also, FontDescriptionKey
should consider if the font-size-adjust has from-font, not simply checking if
it has a valid value when looking up a proper FontCascadeFonts.

For minimizing performance regression, this patch is updated as follows.
1. The resolving place changed from FontCascadeFonts::glyphDataForCharacter() to
   FontCascadeFonts::primaryFont(). Font-size-adjust:from-font is resolved when
   the primary font is created the first time.
2. Copying FontCascadeDescription is avoided. Instead, the source font 
description
   is directly modified.

* LayoutTests/TestExpectations:
* Source/WebCore/css/ComputedStyleExtractor.cpp:
(WebCore::fontSizeAdjustFromStyle):
* Source/WebCore/platform/graphics/FontCascade.h:
* Source/WebCore/platform/graphics/FontCascadeCache.h:
(WebCore::FontDescriptionKey::FontDescriptionKey):
* Source/WebCore/platform/graphics/FontCascadeFonts.h:
(WebCore::FontCascadeFonts::primaryFont):
* Source/WebCore/platform/graphics/FontSizeAdjust.h:
(WebCore::FontSizeAdjust::operator bool const):
(WebCore::FontSizeAdjust::resolve const):
(WebCore::add):
(WebCore::operator<<):
* Source/WebCore/style/StyleBuilderConverter.h:
(WebCore::Style::BuilderConverter::convertFontSizeAdjust):
* Source/WebCore/style/StyleFontSizeFunctions.cpp:
(WebCore::Style::aspectValueOfPrimaryFont): Deleted.
* Source/WebCore/style/StyleFontSizeFunctions.h:

Canonical link: https://commits.webkit.org/269041@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 49f518: [CSS Fonts] The `from-font` value for CSS `font-si...

[ChangSeok Oh]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 49f5188b5e8285f7c3b97cd7161b517ff0bd2886
  
https://github.com/WebKit/WebKit/commit/49f5188b5e8285f7c3b97cd7161b517ff0bd2886
  Author: ChangSeok Oh 
  Date:   2023-09-27 (Wed, 27 Sep 2023)

  Changed paths:
M LayoutTests/TestExpectations
M Source/WebCore/css/ComputedStyleExtractor.cpp
M Source/WebCore/platform/graphics/FontCascadeCache.h
M Source/WebCore/platform/graphics/FontCascadeFonts.cpp
M Source/WebCore/platform/graphics/FontSizeAdjust.h
M Source/WebCore/style/StyleBuilderConverter.h
M Source/WebCore/style/StyleFontSizeFunctions.cpp
M Source/WebCore/style/StyleFontSizeFunctions.h

  Log Message:
  ---
  [CSS Fonts] The `from-font` value for CSS `font-size-adjust` is not computed 
correctly
https://bugs.webkit.org/show_bug.cgi?id=259551

Reviewed by Myles C. Maxfield.

When resolving styles, we used the parent-style font to compute the aspect ratio
for font-size-adjust: from-font because the first available font could not be
determined at that moment. Unfortunately, this causes the failure of
font-size-adjust-014.html. To make the test happy, we should defer resolving
the aspect value after determining a primary font. Also, FontDescriptionKey
should consider if the font-size-adjust has from-font, not simply checking if
it has a valid value when looking up a proper FontCascadeFonts.

* LayoutTests/TestExpectations:
* Source/WebCore/css/ComputedStyleExtractor.cpp:
(WebCore::fontSizeAdjustFromStyle):
* Source/WebCore/platform/graphics/FontCascadeCache.h:
(WebCore::FontDescriptionKey::FontDescriptionKey):
* Source/WebCore/platform/graphics/FontCascadeFonts.cpp:
(WebCore::FontCascadeFonts::glyphDataForCharacter):
* Source/WebCore/platform/graphics/FontSizeAdjust.h:
(WebCore::FontSizeAdjust::operator bool const):
(WebCore::FontSizeAdjust::resolve const):
(WebCore::add):
(WebCore::operator<<):
* Source/WebCore/style/StyleBuilderConverter.h:
(WebCore::Style::BuilderConverter::convertFontSizeAdjust):
* Source/WebCore/style/StyleFontSizeFunctions.cpp:
(WebCore::Style::aspectValueOfPrimaryFont): Deleted.
* Source/WebCore/style/StyleFontSizeFunctions.h:

Canonical link: https://commits.webkit.org/268550@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 491514: Import font-size-adjust related tests from the lat...

[ChangSeok Oh]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 491514d389f263329ef6659e5c70feb5deacc256
  
https://github.com/WebKit/WebKit/commit/491514d389f263329ef6659e5c70feb5deacc256
  Author: ChangSeok Oh 
  Date:   2023-09-26 (Tue, 26 Sep 2023)

  Changed paths:
M LayoutTests/TestExpectations
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/font-size-adjust-012-expected.html
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/font-size-adjust-012-ref.html
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/font-size-adjust-012.html
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/font-size-adjust-013-expected.html
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/font-size-adjust-013-ref.html
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/font-size-adjust-013.html
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/font-size-adjust-014-expected.html
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/font-size-adjust-014-ref.html
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/font-size-adjust-014.html
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/parsing/ahem-ex-500.otf
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/parsing/font-size-adjust-computed-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/parsing/font-size-adjust-computed.html

  Log Message:
  ---
  Import font-size-adjust related tests from the latest WPT
https://bugs.webkit.org/show_bug.cgi?id=262103

Reviewed by Tim Nguyen.

This change imports or re-imports font-size-adjust related tests from the latest
WPT repository, which were updated in 
https://github.com/web-platform-tests/wpt/pull/41273.

* LayoutTests/TestExpectations:
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/font-size-adjust-012-expected.html:
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/font-size-adjust-012-ref.html:
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/font-size-adjust-012.html:
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/font-size-adjust-013-expected.html:
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/font-size-adjust-013-ref.html:
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/font-size-adjust-013.html:
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/font-size-adjust-014-expected.html:
 Added.
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/font-size-adjust-014-ref.html:
 Added.
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/font-size-adjust-014.html:
 Added.
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/parsing/ahem-ex-500.otf:
 Added.
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/parsing/font-size-adjust-computed-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/parsing/font-size-adjust-computed.html:

Canonical link: https://commits.webkit.org/268458@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 97a915: Move gstreamer-related headers from Headers.cmake ...

[ChangSeok Oh]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 97a91554b84aff6781737d035d9aed02d16f71db
  
https://github.com/WebKit/WebKit/commit/97a91554b84aff6781737d035d9aed02d16f71db
  Author: ChangSeok Oh 
  Date:   2023-08-25 (Fri, 25 Aug 2023)

  Changed paths:
M Source/WebCore/Headers.cmake
M Source/WebCore/platform/GStreamer.cmake

  Log Message:
  ---
  Move gstreamer-related headers from Headers.cmake to GStreamer.cmake
https://bugs.webkit.org/show_bug.cgi?id=260706

Reviewed by Philippe Normand and Michael Catanzaro.

This change is a small cleanup. We move gstreamer-related header files
in Headers.cmake to GStreamer.cmake.

* Source/WebCore/Headers.cmake:
* Source/WebCore/platform/GStreamer.cmake:

Canonical link: https://commits.webkit.org/267286@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 9e0569: Build fix after 160450@main by guarding showRender...

[ChangSeok Oh]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 9e05696bcb54853cb53d763acbb3eed7ec39f1ed
  
https://github.com/WebKit/WebKit/commit/9e05696bcb54853cb53d763acbb3eed7ec39f1ed
  Author: ChangSeok Oh 
  Date:   2023-08-25 (Fri, 25 Aug 2023)

  Changed paths:
M Source/WebCore/page/LocalFrameViewLayoutContext.cpp

  Log Message:
  ---
  Build fix after 160450@main by guarding showRenderTree
https://bugs.webkit.org/show_bug.cgi?id=260702

Unreviewed build fix.

Where LOG_DISABLED is disabled, the build fails due to missing showRenderTree().
The showRenderTree() is guarded by ENABLE(TREE_DEBUGGING).

* Source/WebCore/page/LocalFrameViewLayoutContext.cpp:
(WebCore::LocalFrameViewLayoutContext::performLayout):

Canonical link: https://commits.webkit.org/267268@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 8a587d: Cleanup consumeFontSizeAdjust()

[ChangSeok Oh]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 8a587dccd0c8606b55030baf4ee3745d0d1a0908
  
https://github.com/WebKit/WebKit/commit/8a587dccd0c8606b55030baf4ee3745d0d1a0908
  Author: ChangSeok Oh 
  Date:   2023-05-10 (Wed, 10 May 2023)

  Changed paths:
M Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp

  Log Message:
  ---
  Cleanup consumeFontSizeAdjust()
https://bugs.webkit.org/show_bug.cgi?id=256545

Reviewed by Tim Nguyen.

This change is a minor clean-up of consumeFontSizeAdjust(). We don't
need to call consumeNumber() twice.

* Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp:
(WebCore::CSSPropertyParserHelpers::consumeFontSizeAdjust):

Canonical link: https://commits.webkit.org/263904@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] eb50f3: Cap height is incorrect on platforms using FreeType.

[ChangSeok Oh]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: eb50f369243c6fcb130ba92cb3bb75e119512284
  
https://github.com/WebKit/WebKit/commit/eb50f369243c6fcb130ba92cb3bb75e119512284
  Author: ChangSeok Oh 
  Date:   2023-04-11 (Tue, 11 Apr 2023)

  Changed paths:
M 
LayoutTests/fast/css-generated-content/initial-letter-first-line-wrapping-expected.html
M LayoutTests/platform/glib/TestExpectations
M 
LayoutTests/platform/glib/fast/text/combining-enclosing-keycap-expected.txt
M 
LayoutTests/platform/gtk/fast/css-generated-content/initial-letter-basic-expected.txt
M 
LayoutTests/platform/gtk/fast/css-generated-content/initial-letter-border-padding-expected.txt
M 
LayoutTests/platform/gtk/fast/css-generated-content/initial-letter-clearance-expected.txt
M 
LayoutTests/platform/gtk/fast/css-generated-content/initial-letter-descender-expected.txt
M 
LayoutTests/platform/gtk/fast/css-generated-content/initial-letter-raised-expected.txt
M 
LayoutTests/platform/gtk/fast/css-generated-content/initial-letter-sunken-expected.txt
M 
LayoutTests/platform/wpe/fast/css-generated-content/initial-letter-basic-expected.txt
M 
LayoutTests/platform/wpe/fast/css-generated-content/initial-letter-border-padding-expected.txt
M 
LayoutTests/platform/wpe/fast/css-generated-content/initial-letter-clearance-expected.txt
M 
LayoutTests/platform/wpe/fast/css-generated-content/initial-letter-descender-expected.txt
M 
LayoutTests/platform/wpe/fast/css-generated-content/initial-letter-raised-expected.txt
M 
LayoutTests/platform/wpe/fast/css-generated-content/initial-letter-sunken-expected.txt
M Source/WebCore/platform/graphics/freetype/SimpleFontDataFreeType.cpp

  Log Message:
  ---
  Cap height is incorrect on platforms using FreeType.
https://bugs.webkit.org/show_bug.cgi?id=255082

Reviewed by Carlos Garcia Campos.

FreeType platforms use the height of cairo_font_extents_t as cap-height
for the given font. Unfortunately, that is not the cap-height we want. According
to the Cairo document [1], cairo_font_extents_t.height is the vertical distance
between baselines, which contains ascent, descent, and some margin. That is far
from the cap-height the CSS standard defines [2], and results in the failure of
font-size-adjust-009.html.

To fix this, we use the cap-height FreeType provided since its version 2 [3].
As we did for x-height, we fall back to cairo_text_extends_t if we cannot get
the cap-height from FreeType.

[1] 
https://www.cairographics.org/manual/cairo-cairo-scaled-font-t.html#cairo-font-extents-t
[2] https://www.w3.org/TR/css-values-4/#font-relative-lengths
[3] 
https://freetype.org/freetype2/docs/reference/ft2-truetype_tables.html#tt_os2

The following tests are manually verified by matching the results to ones of 
the mac port.

Test:
+ imported/w3c/web-platform-tests/css/css-fonts/font-size-adjust-009.html
+ fast/css-generated-content/initial-letter-basic.html
+ fast/css-generated-content/initial-letter-border-padding.html
+ fast/css-generated-content/initial-letter-clearance.html
+ fast/css-generated-content/initial-letter-descender.html
* fast/css-generated-content/initial-letter-first-line-wrapping.html:
+ fast/css-generated-content/initial-letter-raised.html
+ fast/css-generated-content/initial-letter-sunken.html
* fast/text/combining-enclosing-keycap.html

The following tests are marked as expected image test failures. Before this 
patch,
they passed because they rendered nothing (i.e., an empty page) due to 
inaccurate
font heights. To make them pass, custom fonts (e.g., color fonts) via
@font-face: font-family should work for Canvas. We handle them in a separate 
bug.

- http/tests/canvas/color-fonts/ctm-sbix.html
- http/tests/canvas/color-fonts/fill-color-sbix.html
- http/tests/canvas/color-fonts/fill-gradient-sbix.html
- http/tests/canvas/color-fonts/linedash-sbix.html
- http/tests/canvas/color-fonts/stroke-gradient-sbix.html
- http/tests/canvas/color-fonts/text-sbix.html

* 
LayoutTests/fast/css-generated-content/initial-letter-first-line-wrapping-expected.html:
 Updated.
* LayoutTests/platform/glib/TestExpectations:
* LayoutTests/platform/glib/fast/text/combining-enclosing-keycap-expected.txt: 
Updated.
* 
LayoutTests/platform/gtk/fast/css-generated-content/initial-letter-basic-expected.txt:
 Updated.
* 
LayoutTests/platform/gtk/fast/css-generated-content/initial-letter-border-padding-expected.txt:
 Updated.
* 
LayoutTests/platform/gtk/fast/css-generated-content/initial-letter-clearance-expected.txt:
 Updated.
* 
LayoutTests/platform/gtk/fast/css-generated-content/initial-letter-descender-expected.txt:
 Updated.
* 
LayoutTests/platform/gtk/fast/css-generated-content/initial-letter-raised-expected.txt:
 Updated.
* 
LayoutTests/platform/gtk/fast/css-generated-content/initial-letter-sunken-expected.txt:
 Updated.
* 
LayoutTests/platform/wpe/fast/css-generated-content/initial-letter-basic-expected.txt:
 Updated

[webkit-changes] [WebKit/WebKit] 0f2621: [CSS Fonts] Implement the from-font value for font...

[ChangSeok Oh]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 0f2621d762162b939c8959ba3aa4f4a3af8452df
  
https://github.com/WebKit/WebKit/commit/0f2621d762162b939c8959ba3aa4f4a3af8452df
  Author: ChangSeok Oh 
  Date:   2023-04-10 (Mon, 10 Apr 2023)

  Changed paths:
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/font-size-adjust-013-expected.html
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/font-size-adjust-013.html
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/parsing/font-size-adjust-computed-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/parsing/font-size-adjust-computed.html
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/parsing/font-size-adjust-invalid-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/parsing/font-size-adjust-invalid.html
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/parsing/font-size-adjust-valid-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/parsing/font-size-adjust-valid.html
M Source/WebCore/css/CSSProperties.json
M Source/WebCore/css/CSSValueKeywords.in
M Source/WebCore/css/ComputedStyleExtractor.cpp
M Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp
M Source/WebCore/platform/graphics/FontSizeAdjust.h
M Source/WebCore/style/StyleBuilderConverter.h
M Source/WebCore/style/StyleFontSizeFunctions.cpp
M Source/WebCore/style/StyleFontSizeFunctions.h

  Log Message:
  ---
  [CSS Fonts] Implement the from-font value for font-size-adjust
https://bugs.webkit.org/show_bug.cgi?id=254790

Reviewed by Myles C. Maxfield and Tim Nguyen.

The 'from-font' value is newly added to CSS Font Module Level 5 [1], which 
allows
the browser to automatically determine a font-size-adjust value based on the 
primary font.
This change implements it.

The following tests have merged into the latest WPT [2] and are backported in 
this patch.

Test:
imported/w3c/web-platform-tests/css/css-fonts/font-size-adjust-013.html

imported/w3c/web-platform-tests/css/css-fonts/parsing/font-size-adjust-computed.html

imported/w3c/web-platform-tests/css/css-fonts/parsing/font-size-adjust-invalid.html

imported/w3c/web-platform-tests/css/css-fonts/parsing/font-size-adjust-valid.html

[1] https://www.w3.org/TR/css-fonts-5/#valdef-font-size-adjust-from-font
[2] https://github.com/web-platform-tests/wpt/pull/39380

* 
LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/font-size-adjust-013-expected.html:
 Added.
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/font-size-adjust-013.html:
 Added.
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/parsing/font-size-adjust-computed-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/parsing/font-size-adjust-computed.html:
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/parsing/font-size-adjust-invalid-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/parsing/font-size-adjust-invalid.html:
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/parsing/font-size-adjust-valid-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/parsing/font-size-adjust-valid.html:
* Source/WebCore/css/CSSProperties.json:
* Source/WebCore/css/CSSValueKeywords.in:
* Source/WebCore/css/ComputedStyleExtractor.cpp:
(WebCore::fontSizeAdjustFromStyle):
* Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp:
(WebCore::CSSPropertyParserHelpers::consumeFontSizeAdjust):
* Source/WebCore/platform/graphics/FontSizeAdjust.h:
(WebCore::FontSizeAdjust::operator== const):
(WebCore::operator<<):
* Source/WebCore/style/StyleBuilderConverter.h:
(WebCore::Style::BuilderConverter::convertFontSizeAdjust):
* Source/WebCore/style/StyleFontSizeFunctions.cpp:
(WebCore::Style::aspectValueOfPrimaryFont):
* Source/WebCore/style/StyleFontSizeFunctions.h:

Canonical link: https://commits.webkit.org/262800@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 0a83ef: [CSS Fonts] Implement animation support for FontSi...

[ChangSeok Oh]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 0a83efdbed5c5535b98961df55b4f0b5156dd6a5
  
https://github.com/WebKit/WebKit/commit/0a83efdbed5c5535b98961df55b4f0b5156dd6a5
  Author: ChangSeok Oh 
  Date:   2023-03-30 (Thu, 30 Mar 2023)

  Changed paths:
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/animations/font-size-adjust-interpolation-expected.txt
M Source/WebCore/animation/CSSPropertyAnimation.cpp

  Log Message:
  ---
  [CSS Fonts] Implement animation support for FontSizeAdjust metrics two-value 
syntax
https://bugs.webkit.org/show_bug.cgi?id=254266

Reviewed by Tim Nguyen.

This change brings animation support for the font-size-adjust CSS property.

* 
LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/animations/font-size-adjust-interpolation-expected.txt:
* Source/WebCore/animation/CSSPropertyAnimation.cpp:

Canonical link: https://commits.webkit.org/262374@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 2f42ba: [CSS Fonts] Implement two-value syntax of font-siz...

[ChangSeok Oh]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 2f42bab726901c27c9dbe5cef0b0c341ff14
  
https://github.com/WebKit/WebKit/commit/2f42bab726901c27c9dbe5cef0b0c341ff14
  Author: ChangSeok Oh 
  Date:   2023-03-29 (Wed, 29 Mar 2023)

  Changed paths:
M LayoutTests/TestExpectations
M 
LayoutTests/http/tests/incremental/stylesheet-body-incremental-rendering.html
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-cascade/layer-counter-style-override-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/animations/font-size-adjust-interpolation-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/parsing/font-size-adjust-computed-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/parsing/font-size-adjust-valid-expected.txt
M LayoutTests/platform/glib/TestExpectations
A 
LayoutTests/platform/mac-ventura-wk2/imported/w3c/web-platform-tests/css/css-cascade/layer-counter-style-override-expected.txt
M Source/WebCore/Headers.cmake
M Source/WebCore/WebCore.xcodeproj/project.pbxproj
M Source/WebCore/animation/CSSPropertyAnimation.cpp
M Source/WebCore/css/CSSPrimitiveValueMappings.h
M Source/WebCore/css/CSSProperties.json
M Source/WebCore/css/CSSValueKeywords.in
M Source/WebCore/css/ComputedStyleExtractor.cpp
M Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp
M Source/WebCore/css/parser/CSSPropertyParserHelpers.h
M Source/WebCore/platform/graphics/FontCascadeCache.h
M Source/WebCore/platform/graphics/FontCascadeDescription.cpp
M Source/WebCore/platform/graphics/FontCascadeDescription.h
M Source/WebCore/platform/graphics/FontDescription.h
M Source/WebCore/platform/graphics/FontPlatformData.cpp
M Source/WebCore/platform/graphics/FontPlatformData.h
A Source/WebCore/platform/graphics/FontSizeAdjust.h
M Source/WebCore/rendering/style/RenderStyle.cpp
M Source/WebCore/rendering/style/RenderStyle.h
M Source/WebCore/style/StyleBuilderConverter.h
M Source/WebCore/style/StyleBuilderCustom.h
M Source/WebCore/style/StyleFontSizeFunctions.cpp
M Source/WebCore/style/StyleFontSizeFunctions.h

  Log Message:
  ---
  [CSS Fonts] Implement two-value syntax of font-size-adjust
https://bugs.webkit.org/show_bug.cgi?id=254191

Reviewed by Myles C. Maxfield.

This change implements the two-value syntax of font-size-adjust specified in
the CSS Fonts Module Level 5 [1]. Five new font metrics: ex-height, cap-height
ch-width, ic-width and ic-height, are added, which clarify what font metric the
given value is for.

This change does not handle the CSS animation support and the 'from-font' value.
Follow-up patches will cover them.

Test:
imported/w3c/web-platform-tests/css/css-fonts/font-size-adjust-009.html
imported/w3c/web-platform-tests/css/css-fonts/font-size-adjust-010.html
imported/w3c/web-platform-tests/css/css-fonts/font-size-adjust-011.html

[1] https://www.w3.org/TR/css-fonts-5/#font-size-adjust-prop

* LayoutTests/TestExpectations:
* LayoutTests/http/tests/incremental/stylesheet-body-incremental-rendering.html:
  Modified to deterministically measure repainted regions caused by style 
changes.
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-cascade/layer-counter-style-override-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/animations/font-size-adjust-interpolation-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/parsing/font-size-adjust-computed-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/parsing/font-size-adjust-valid-expected.txt:
* LayoutTests/platform/glib/TestExpectations:
* 
LayoutTests/platform/mac-ventura-wk2/imported/w3c/web-platform-tests/css/css-cascade/layer-counter-style-override-expected.txt:
 Copied from 
LayoutTests/imported/w3c/web-platform-tests/css/css-cascade/layer-counter-style-override-expected.txt.
* Source/WebCore/Headers.cmake:
* Source/WebCore/WebCore.xcodeproj/project.pbxproj:
* Source/WebCore/animation/CSSPropertyAnimation.cpp:
* Source/WebCore/css/CSSPrimitiveValueMappings.h:
(WebCore::toCSSValueID):
(WebCore::fromCSSValueID):
* Source/WebCore/css/CSSProperties.json:
* Source/WebCore/css/CSSValueKeywords.in:
* Source/WebCore/css/ComputedStyleExtractor.cpp:
(WebCore::fontSizeAdjustFromStyle):
(WebCore::fontShorthandValue):
* Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp:
(WebCore::CSSPropertyParserHelpers::consumeFontSizeAdjust):
* Source/WebCore/css/parser/CSSPropertyParserHelpers.h:
* Source/WebCore/platform/graphics/FontCascadeCache.h:
(WebCore::FontDescriptionKeyRareData::create):
(WebCore::FontDescriptionKeyRareData::fontSizeAdjust const):
(WebCore::FontDescriptionKeyRareData::FontDescriptionKeyRareData):
(WebCore::FontDescriptionKey::FontDescriptionKey):
* Source/WebCore/platform/graphics/FontCascadeDescription.cpp:
* Source/WebCore/platform/graphics

[webkit-changes] [WebKit/WebKit] d516ad: Cherry-pick 262061@main (9bd41e74f05f). https://bu...

[ChangSeok Oh]

  Branch: refs/heads/webkitglib/2.40
  Home:   https://github.com/WebKit/WebKit
  Commit: d516adb9242e81f3770342096c00d44d2a08e409
  
https://github.com/WebKit/WebKit/commit/d516adb9242e81f3770342096c00d44d2a08e409
  Author: ChangSeok Oh 
  Date:   2023-03-24 (Fri, 24 Mar 2023)

  Changed paths:
M LayoutTests/platform/gtk/svg/W3C-SVG-1.1-SE/coords-units-03-b-expected.png
M LayoutTests/platform/gtk/svg/W3C-SVG-1.1-SE/coords-units-03-b-expected.txt
M LayoutTests/platform/wpe/svg/W3C-SVG-1.1-SE/coords-units-03-b-expected.txt
M Source/WebCore/platform/graphics/freetype/SimpleFontDataFreeType.cpp

  Log Message:
  ---
  Cherry-pick 262061@main (9bd41e74f05f). 
https://bugs.webkit.org/show_bug.cgi?id=254145

[GTK] font-size-adjust does not work for non-Ahem fonts
https://bugs.webkit.org/show_bug.cgi?id=254145

Reviewed by Carlos Garcia Campos.

The GTK port does not properly handle the font-size-adjust CSS property.
This is because xHeight is not retrieved with FreeType in 
Font::platformInit()
at SimpleFontDataFreeType.cpp. We attempt to get the xHeight from FreeType 
first,
then do the same from Cairo. If we get 0 of xHeight in the first trial and
set it to `std::optional xHeight`, the second trial never happens
as `if (!xHeight)` does not hit. That condition just checks if xHeight has
a value or not. Our intention is to retry to get xHeight by an alternative 
way
(i.e., Cairo) where the xHeight is not normal (i.e., 0). To fix this, we 
test
if xHeight has a value and that is a non-zero value for the second trial.
Otherwise, we get the xHeight from Cairo.

The following results are updated since the xHeight value was not reflected.

* 
LayoutTests/platform/gtk/svg/W3C-SVG-1.1-SE/coords-units-03-b-expected.png:
* 
LayoutTests/platform/gtk/svg/W3C-SVG-1.1-SE/coords-units-03-b-expected.txt:
* 
LayoutTests/platform/wpe/svg/W3C-SVG-1.1-SE/coords-units-03-b-expected.txt:
* Source/WebCore/platform/graphics/freetype/SimpleFontDataFreeType.cpp:
(WebCore::Font::platformInit):

Canonical link: https://commits.webkit.org/262061@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 9bd41e: [GTK] font-size-adjust does not work for non-Ahem ...

[ChangSeok Oh]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 9bd41e74f05fdc5149e5bd3e3760512e2e5ddad0
  
https://github.com/WebKit/WebKit/commit/9bd41e74f05fdc5149e5bd3e3760512e2e5ddad0
  Author: ChangSeok Oh 
  Date:   2023-03-23 (Thu, 23 Mar 2023)

  Changed paths:
M LayoutTests/platform/gtk/svg/W3C-SVG-1.1-SE/coords-units-03-b-expected.png
M LayoutTests/platform/gtk/svg/W3C-SVG-1.1-SE/coords-units-03-b-expected.txt
M LayoutTests/platform/wpe/svg/W3C-SVG-1.1-SE/coords-units-03-b-expected.txt
M Source/WebCore/platform/graphics/freetype/SimpleFontDataFreeType.cpp

  Log Message:
  ---
  [GTK] font-size-adjust does not work for non-Ahem fonts
https://bugs.webkit.org/show_bug.cgi?id=254145

Reviewed by Carlos Garcia Campos.

The GTK port does not properly handle the font-size-adjust CSS property.
This is because xHeight is not retrieved with FreeType in Font::platformInit()
at SimpleFontDataFreeType.cpp. We attempt to get the xHeight from FreeType 
first,
then do the same from Cairo. If we get 0 of xHeight in the first trial and
set it to `std::optional xHeight`, the second trial never happens
as `if (!xHeight)` does not hit. That condition just checks if xHeight has
a value or not. Our intention is to retry to get xHeight by an alternative way
(i.e., Cairo) where the xHeight is not normal (i.e., 0). To fix this, we test
if xHeight has a value and that is a non-zero value for the second trial.
Otherwise, we get the xHeight from Cairo.

The following results are updated since the xHeight value was not reflected.

* LayoutTests/platform/gtk/svg/W3C-SVG-1.1-SE/coords-units-03-b-expected.png:
* LayoutTests/platform/gtk/svg/W3C-SVG-1.1-SE/coords-units-03-b-expected.txt:
* LayoutTests/platform/wpe/svg/W3C-SVG-1.1-SE/coords-units-03-b-expected.txt:
* Source/WebCore/platform/graphics/freetype/SimpleFontDataFreeType.cpp:
(WebCore::Font::platformInit):

Canonical link: https://commits.webkit.org/262061@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 1dbfbb: [GTK] Update Korean translations - Mar 3, 2023

[ChangSeok Oh]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 1dbfbb4c31d9762ff10617b2e198912355cf277a
  
https://github.com/WebKit/WebKit/commit/1dbfbb4c31d9762ff10617b2e198912355cf277a
  Author: ChangSeok Oh 
  Date:   2023-03-03 (Fri, 03 Mar 2023)

  Changed paths:
M Source/WebCore/platform/gtk/po/ko.po

  Log Message:
  ---
  [GTK] Update Korean translations - Mar 3, 2023
https://bugs.webkit.org/show_bug.cgi?id=253368

Reviewed by Michael Catanzaro.

This change updates Korean translations for WebKitGTK+.

* Source/WebCore/platform/gtk/po/ko.po:

Canonical link: https://commits.webkit.org/261199@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 5e6a4c: Use an rvalue reference argument for the GstSpeech...

[ChangSeok Oh]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 5e6a4c1f5660fb96e455c1722ce2b3c24ed37fd2
  
https://github.com/WebKit/WebKit/commit/5e6a4c1f5660fb96e455c1722ce2b3c24ed37fd2
  Author: ChangSeok Oh 
  Date:   2023-02-21 (Tue, 21 Feb 2023)

  Changed paths:
M Source/WebCore/platform/gstreamer/PlatformSpeechSynthesizerGStreamer.cpp

  Log Message:
  ---
  Use an rvalue reference argument for the GstSpeechSynthesisWrapper constructor
https://bugs.webkit.org/show_bug.cgi?id=252653

Reviewed by Philippe Normand.

Using an rvalue reference argument, we avoid an unnecessary copy of
PlatformSpeechSynthesizer in the GstSpeechSynthesisWrapper constructor.

* Source/WebCore/platform/gstreamer/PlatformSpeechSynthesizerGStreamer.cpp:
(WebCore::GstSpeechSynthesisWrapper::GstSpeechSynthesisWrapper):

Canonical link: https://commits.webkit.org/260600@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] a29a02: [GStreamer] Implement pitch, rate, and volume cont...

[ChangSeok Oh]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: a29a02ef293ea6f1711b746507f913f7a77a6e8d
  
https://github.com/WebKit/WebKit/commit/a29a02ef293ea6f1711b746507f913f7a77a6e8d
  Author: ChangSeok Oh 
  Date:   2023-02-07 (Tue, 07 Feb 2023)

  Changed paths:
M Source/WebCore/platform/gstreamer/PlatformSpeechSynthesizerGStreamer.cpp

  Log Message:
  ---
  [GStreamer] Implement pitch, rate, and volume controls of SpeechSynthesis
https://bugs.webkit.org/show_bug.cgi?id=251486

Reviewed by Philippe Normand.

This change adds pitch, rate, and volume controls support to web speech 
synthesis.
We use a GStreamer plugin of soundtouch for the pitch change of voice and 
control
the voice rate with gst_element_seek.

* Source/WebCore/platform/gstreamer/PlatformSpeechSynthesizerGStreamer.cpp:
(WebCore::GstSpeechSynthesisWrapper::GstSpeechSynthesisWrapper):
(WebCore::GstSpeechSynthesisWrapper::speakUtterance):

Canonical link: https://commits.webkit.org/259949@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 24c8ac: [Flatpak SDK] Enable SoundTouch GStreamer plugin

[ChangSeok Oh]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 24c8ac498e698b2407b4230048dc2bd9424492a1
  
https://github.com/WebKit/WebKit/commit/24c8ac498e698b2407b4230048dc2bd9424492a1
  Author: ChangSeok Oh 
  Date:   2023-02-05 (Sun, 05 Feb 2023)

  Changed paths:
M Tools/buildstream/elements/freedesktop-sdk.bst
A Tools/buildstream/patches/fdo-0006-gst-plugins-bad-Enable-soundtouch.patch

  Log Message:
  ---
  [Flatpak SDK] Enable SoundTouch GStreamer plugin
https://bugs.webkit.org/show_bug.cgi?id=251739

Reviewed by Philippe Normand.

To control the pitch of web speech, we use the SoundTouch GStreamer plugin.
This change enables the SoundTouch support for GStreamer and adds the 
libsoundtouch build
to Flatpak SDK.

* Tools/buildstream/elements/freedesktop-sdk.bst:
* Tools/buildstream/patches/fdo-0006-gst-plugins-bad-Enable-soundtouch.patch: 
Added.

Canonical link: https://commits.webkit.org/259870@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 3aad91: [GStreamer] Fix a failure of fast/speechsynthesis/...

[ChangSeok Oh]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 3aad9165b15df302e611f79f33378137101d390f
  
https://github.com/WebKit/WebKit/commit/3aad9165b15df302e611f79f33378137101d390f
  Author: ChangSeok Oh 
  Date:   2023-02-03 (Fri, 03 Feb 2023)

  Changed paths:
M LayoutTests/fast/speechsynthesis/voices-non-mock-expected.txt
M LayoutTests/fast/speechsynthesis/voices-non-mock.html
M LayoutTests/platform/glib/TestExpectations
A 
LayoutTests/platform/glib/fast/speechsynthesis/voices-non-mock-expected.txt
M Source/WebCore/testing/Internals.cpp
M Source/WebCore/testing/Internals.h
M Source/WebCore/testing/Internals.idl

  Log Message:
  ---
  [GStreamer] Fix a failure of fast/speechsynthesis/voices-non-mock.html
https://bugs.webkit.org/show_bug.cgi?id=250656

Reviewed by Philippe Normand.

The voices-non-mock.html used a mac platform-specific value to test the number
of available voices. This change introduces a new method of Internals, which 
allows
each port to decide its minimum expected voice count. Besides, this change 
includes
a new expected result for ports using GStreamer since the number of available 
voices
for those ports differs from that of the mac port.

* LayoutTests/fast/speechsynthesis/voices-non-mock.html:
* LayoutTests/platform/glib/TestExpectations:
* LayoutTests/platform/glib/fast/speechsynthesis/voices-non-mock-expected.txt: 
Added.
* Source/WebCore/testing/Internals.cpp:
(WebCore::Internals::minimumExpectedVoiceCount):
* Source/WebCore/testing/Internals.h:
* Source/WebCore/testing/Internals.idl:

Canonical link: https://commits.webkit.org/259820@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] ecbd5f: [CMake] Remove a duplicate AVIF configuration mess...

[ChangSeok Oh]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: ecbd5fc1a11d1c2c900e20dafc6fec33dcf43b06
  
https://github.com/WebKit/WebKit/commit/ecbd5fc1a11d1c2c900e20dafc6fec33dcf43b06
  Author: ChangSeok Oh 
  Date:   2023-01-24 (Tue, 24 Jan 2023)

  Changed paths:
M Source/cmake/OptionsGTK.cmake
M Source/cmake/OptionsWPE.cmake

  Log Message:
  ---
  [CMake] Remove a duplicate AVIF configuration message.
https://bugs.webkit.org/show_bug.cgi?id=251060

Reviewed by Carlos Garcia Campos.

This change removes a duplicate USE_AVIF CMake configuration message.

* Source/cmake/OptionsGTK.cmake:
* Source/cmake/OptionsWPE.cmake:

Canonical link: https://commits.webkit.org/259266@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 1153af: [GStreamer] Fix a crash for fast/speechsynthesis/s...

[ChangSeok Oh]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 1153afca6d716b3bc6685e910d1b48fc7b5ba73c
  
https://github.com/WebKit/WebKit/commit/1153afca6d716b3bc6685e910d1b48fc7b5ba73c
  Author: ChangSeok Oh 
  Date:   2023-01-24 (Tue, 24 Jan 2023)

  Changed paths:
M LayoutTests/platform/glib/TestExpectations
M Source/WebCore/platform/gstreamer/PlatformSpeechSynthesizerGStreamer.cpp
M Source/WebCore/platform/gstreamer/WebKitFliteSourceGStreamer.cpp
M Source/WebCore/platform/gstreamer/WebKitFliteSourceGStreamer.h

  Log Message:
  ---
  [GStreamer] Fix a crash for 
fast/speechsynthesis/speech-synthesis-real-client-version.html
https://bugs.webkit.org/show_bug.cgi?id=251056

Reviewed by Xabier Rodriguez-Calvar.

The crash happens when the web content does not specify a voice to use. We 
handle a null pointer
of the voice with the default voice.

Test: fast/speechsynthesis/speech-synthesis-real-client-version.html

* LayoutTests/platform/glib/TestExpectations:
* Source/WebCore/platform/gstreamer/PlatformSpeechSynthesizerGStreamer.cpp:
(WebCore::GstSpeechSynthesisWrapper::speakUtterance):
* Source/WebCore/platform/gstreamer/WebKitFliteSourceGStreamer.cpp:
(fliteVoice):
(webKitFliteSrcSetUtterance):
* Source/WebCore/platform/gstreamer/WebKitFliteSourceGStreamer.h:

Canonical link: https://commits.webkit.org/259265@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] f99efc: [GStreamer] Implement Speech Synthesis with Flite

[ChangSeok Oh]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: f99efce2948ad9f817f9e69e3272db98fafce4f0
  
https://github.com/WebKit/WebKit/commit/f99efce2948ad9f817f9e69e3272db98fafce4f0
  Author: ChangSeok Oh 
  Date:   2023-01-22 (Sun, 22 Jan 2023)

  Changed paths:
M LayoutTests/platform/glib/TestExpectations
M Source/WebCore/PlatformGTK.cmake
M Source/WebCore/PlatformWPE.cmake
M Source/WebCore/platform/GStreamer.cmake
M Source/WebCore/platform/PlatformSpeechSynthesizer.h
M Source/WebCore/platform/graphics/gstreamer/GStreamerCommon.cpp
A Source/WebCore/platform/gstreamer/GUniquePtrFlite.h
A Source/WebCore/platform/gstreamer/PlatformSpeechSynthesizerGStreamer.cpp
A Source/WebCore/platform/gstreamer/WebKitFliteSourceGStreamer.cpp
A Source/WebCore/platform/gstreamer/WebKitFliteSourceGStreamer.h
M Source/WebKit/SourcesGTK.txt
M Source/WebKit/SourcesWPE.txt
A Source/WebKit/UIProcess/gstreamer/WebPageProxyGStreamer.cpp
M Source/WebKit/WebProcess/WebPage/WebPage.cpp
A Source/cmake/FindFlite.cmake
M Source/cmake/OptionsGTK.cmake
M Source/cmake/OptionsWPE.cmake
M Tools/Scripts/webkitpy/style/checker.py

  Log Message:
  ---
  [GStreamer] Implement Speech Synthesis with Flite
https://bugs.webkit.org/show_bug.cgi?id=250628

Reviewed by Philippe Normand.

This change implements the Speech Synthesis part of Web speech with Flite, an 
open-source
speech synthesis engine for ports using GStreamer. Once Flite converts texts to 
a wave,
GStreamer controls the playback of the wave sound in a GStreamer pipeline.
This patch only implements basic functionalities such as play, pause, resume, 
stop, and voice
change. Other fine controls, such as pitch, rate, etc., will be supported in 
the following changes.

This change passes 11 out of 13 tests in fast/speechsynthesis. We enable those 
tests in this patch,
skipping failed ones temporarily. We will fix the failures in a different bug.

Tests: LayoutTests/fast/speechsynthesis

Combined changes:
* LayoutTests/platform/glib/TestExpectations:
* Source/WebCore/PlatformGTK.cmake:
* Source/WebCore/PlatformWPE.cmake:
* Source/WebCore/platform/GStreamer.cmake:
* Source/WebCore/platform/PlatformSpeechSynthesizer.h:
* Source/WebCore/platform/graphics/gstreamer/GStreamerCommon.cpp: A new gst 
element added, "webkitflitesrc".
(WebCore::registerWebKitGStreamerElements):
* Source/WebCore/platform/gstreamer/GUniquePtrFlite.h: Added.
* Source/WebCore/platform/gstreamer/PlatformSpeechSynthesizerGStreamer.cpp: 
Added. This file
  implements the playback of speech with given texts.
(WebCore::GstSpeechSynthesisWrapper::GstSpeechSynthesisWrapper):
(WebCore::GstSpeechSynthesisWrapper::~GstSpeechSynthesisWrapper):
(WebCore::GstSpeechSynthesisWrapper::pause):
(WebCore::GstSpeechSynthesisWrapper::resume):
(WebCore::GstSpeechSynthesisWrapper::speakUtterance):
(WebCore::GstSpeechSynthesisWrapper::cancel):
(WebCore::GstSpeechSynthesisWrapper::resetState):
(WebCore::GstSpeechSynthesisWrapper::handleMessage):
(WebCore::PlatformSpeechSynthesizer::create):
(WebCore::PlatformSpeechSynthesizer::PlatformSpeechSynthesizer):
(WebCore::PlatformSpeechSynthesizer::initializeVoiceList):
(WebCore::PlatformSpeechSynthesizer::pause):
(WebCore::PlatformSpeechSynthesizer::resume):
(WebCore::PlatformSpeechSynthesizer::speak):
(WebCore::PlatformSpeechSynthesizer::cancel):
(WebCore::PlatformSpeechSynthesizer::resetState):
* Source/WebCore/platform/gstreamer/WebKitFliteSourceGStreamer.cpp: Added. This 
file initializes
  a gstreamer source element with flite, registers voices.
(webkitFliteSrcConstructed):
(webkitFliteSrcStart):
(webkitFliteSrcStop):
(webkitFliteSrcCreate):
(webkitFliteSrcSetCaps):
(webkit_flite_src_class_init):
(fliteVoices):
(fliteVoice):
(ensureFliteVoicesInitialized):
(webKitFliteSrcSetUtterance):
* Source/WebCore/platform/gstreamer/WebKitFliteSourceGStreamer.h: Added.
* Source/WebKit/SourcesGTK.txt:
* Source/WebKit/SourcesWPE.txt:
* Source/WebKit/UIProcess/gstreamer/WebPageProxyGStreamer.cpp: Added.
(WebKit::WebPageProxy::didStartSpeaking):
(WebKit::WebPageProxy::didFinishSpeaking):
(WebKit::WebPageProxy::didPauseSpeaking):
(WebKit::WebPageProxy::didResumeSpeaking):
(WebKit::WebPageProxy::speakingErrorOccurred):
(WebKit::WebPageProxy::boundaryEventOccurred):
(WebKit::WebPageProxy::voicesDidChange):
* Source/WebKit/WebProcess/WebPage/WebPage.cpp: We don't install the speech 
synthesis client since
  we want to run gstreamer in Web Process.

(WebKit::m_appHighlightsVisible):
* Source/cmake/FindFlite.cmake: Added.
* Source/cmake/OptionsGTK.cmake:
* Source/cmake/OptionsWPE.cmake:
* Tools/Scripts/webkitpy/style/checker.py: Add WebKitFliteSourceGStreamer files 
for naming exceptions.

Canonical link: https://commits.webkit.org/259197@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 2cae29: [Flatpak SDK] Add Flite

[ChangSeok Oh]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 2cae2987404bc4943273aa9e8aee304017d6f0c5
  
https://github.com/WebKit/WebKit/commit/2cae2987404bc4943273aa9e8aee304017d6f0c5
  Author: ChangSeok Oh 
  Date:   2023-01-16 (Mon, 16 Jan 2023)

  Changed paths:
M Tools/buildstream/elements/sdk-platform.bst
A Tools/buildstream/elements/sdk/flite.bst

  Log Message:
  ---
  [Flatpak SDK] Add Flite
https://bugs.webkit.org/show_bug.cgi?id=250668

Reviewed by Philippe Normand.

This change adds Flite, a speech synthesis engine, to Flatpak SDK.

* Tools/buildstream/elements/sdk-platform.bst:
* Tools/buildstream/elements/sdk/flite.bst: Added.

Canonical link: https://commits.webkit.org/258944@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [196767] trunk/Source/WebKit2

[changseok . oh]

Title: [196767] trunk/Source/WebKit2








Revision 196767
Author changseok...@collabora.com
Date 2016-02-18 11:06:50 -0800 (Thu, 18 Feb 2016)


Log Message
[GTK][Threaded Compositor] The web inspector doesn't work when using the threaded compositor
https://bugs.webkit.org/show_bug.cgi?id=154067

Reviewed by Carlos Garcia Campos.

The forceCompositingMode should be true for threaded compositor. We set it true for a normal webView
in _WebKitSettingsPrivate() but we do not for inspector anywhere. So DrawingArea is not
properly created for the inspector. Let's move the setting to WebPreferences::platformInitializeStore
which is a common place for the webView and the inspector.

* UIProcess/API/gtk/WebKitSettings.cpp:
(_WebKitSettingsPrivate::_WebKitSettingsPrivate): Deleted.
* UIProcess/gtk/WebPreferencesGtk.cpp:
(WebKit::WebPreferences::platformInitializeStore):

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/gtk/WebKitSettings.cpp
trunk/Source/WebKit2/UIProcess/gtk/WebPreferencesGtk.cpp




Diff

Modified: trunk/Source/WebKit2/ChangeLog (196766 => 196767)

--- trunk/Source/WebKit2/ChangeLog	2016-02-18 19:02:26 UTC (rev 196766)
+++ trunk/Source/WebKit2/ChangeLog	2016-02-18 19:06:50 UTC (rev 196767)
@@ -1,3 +1,20 @@
+2016-02-18  ChangSeok Oh  <changseok...@collabora.com>
+
+[GTK][Threaded Compositor] The web inspector doesn't work when using the threaded compositor
+https://bugs.webkit.org/show_bug.cgi?id=154067
+
+Reviewed by Carlos Garcia Campos.
+
+The forceCompositingMode should be true for threaded compositor. We set it true for a normal webView
+in _WebKitSettingsPrivate() but we do not for inspector anywhere. So DrawingArea is not
+properly created for the inspector. Let's move the setting to WebPreferences::platformInitializeStore
+which is a common place for the webView and the inspector.
+
+* UIProcess/API/gtk/WebKitSettings.cpp:
+(_WebKitSettingsPrivate::_WebKitSettingsPrivate): Deleted.
+* UIProcess/gtk/WebPreferencesGtk.cpp:
+(WebKit::WebPreferences::platformInitializeStore):
+
 2016-02-18  Commit Queue  <commit-qu...@webkit.org>
 
 Unreviewed, rolling out r196765.


Modified: trunk/Source/WebKit2/UIProcess/API/gtk/WebKitSettings.cpp (196766 => 196767)

--- trunk/Source/WebKit2/UIProcess/API/gtk/WebKitSettings.cpp	2016-02-18 19:02:26 UTC (rev 196766)
+++ trunk/Source/WebKit2/UIProcess/API/gtk/WebKitSettings.cpp	2016-02-18 19:06:50 UTC (rev 196767)
@@ -58,10 +58,6 @@
 fantasyFontFamily = preferences->fantasyFontFamily().utf8();
 pictographFontFamily = preferences->pictographFontFamily().utf8();
 defaultCharset = preferences->defaultTextEncodingName().utf8();
-
-#if USE(COORDINATED_GRAPHICS_THREADED)
-preferences->setForceCompositingMode(true);
-#endif
 }
 
 RefPtr preferences;


Modified: trunk/Source/WebKit2/UIProcess/gtk/WebPreferencesGtk.cpp (196766 => 196767)

--- trunk/Source/WebKit2/UIProcess/gtk/WebPreferencesGtk.cpp	2016-02-18 19:02:26 UTC (rev 196766)
+++ trunk/Source/WebKit2/UIProcess/gtk/WebPreferencesGtk.cpp	2016-02-18 19:06:50 UTC (rev 196767)
@@ -41,6 +41,9 @@
 setAcceleratedCompositingEnabled(false);
 }
 #endif
+#if USE(COORDINATED_GRAPHICS_THREADED)
+setForceCompositingMode(true);
+#endif
 #if !ENABLE(OPENGL)
 setAcceleratedCompositingEnabled(false);
 #else






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [196623] trunk/Source/WebKit2

[changseok . oh]

Title: [196623] trunk/Source/WebKit2








Revision 196623
Author changseok...@collabora.com
Date 2016-02-15 21:39:57 -0800 (Mon, 15 Feb 2016)


Log Message
[ThreadedCompositor] position:fixed elements do not have their own layers when threaded compositor is enabled.
https://bugs.webkit.org/show_bug.cgi?id=154100

Reviewed by Carlos Garcia Campos.

Currently, fixed elements are redrawn to a backing store every time layout or scroll happens.
It results in the bad effect on performance-wise. Letting fixed element have separate layers is
necessary when threaded compositor is enabled at least. Because async scrolling requires it.

* WebProcess/WebPage/DrawingAreaImpl.cpp:
(WebKit::DrawingAreaImpl::updatePreferences):

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/WebProcess/WebPage/DrawingAreaImpl.cpp




Diff

Modified: trunk/Source/WebKit2/ChangeLog (196622 => 196623)

--- trunk/Source/WebKit2/ChangeLog	2016-02-16 05:36:38 UTC (rev 196622)
+++ trunk/Source/WebKit2/ChangeLog	2016-02-16 05:39:57 UTC (rev 196623)
@@ -1,3 +1,17 @@
+2016-02-15  ChangSeok Oh  <changseok...@collabora.com>
+
+[ThreadedCompositor] position:fixed elements do not have their own layers when threaded compositor is enabled.
+https://bugs.webkit.org/show_bug.cgi?id=154100
+
+Reviewed by Carlos Garcia Campos.
+
+Currently, fixed elements are redrawn to a backing store every time layout or scroll happens.
+It results in the bad effect on performance-wise. Letting fixed element have separate layers is
+necessary when threaded compositor is enabled at least. Because async scrolling requires it.
+
+* WebProcess/WebPage/DrawingAreaImpl.cpp:
+(WebKit::DrawingAreaImpl::updatePreferences):
+
 2016-02-15  Alex Christensen  <achristen...@webkit.org>
 
 Implement content sniffing check with NetworkSession


Modified: trunk/Source/WebKit2/WebProcess/WebPage/DrawingAreaImpl.cpp (196622 => 196623)

--- trunk/Source/WebKit2/WebProcess/WebPage/DrawingAreaImpl.cpp	2016-02-16 05:36:38 UTC (rev 196622)
+++ trunk/Source/WebKit2/WebProcess/WebPage/DrawingAreaImpl.cpp	2016-02-16 05:39:57 UTC (rev 196623)
@@ -248,7 +248,15 @@
 
 void DrawingAreaImpl::updatePreferences(const WebPreferencesStore& store)
 {
-m_webPage.corePage()->settings().setForceCompositingMode(store.getBoolValueForKey(WebPreferencesKey::forceCompositingModeKey()));
+Settings& settings = m_webPage.corePage()->settings();
+settings.setForceCompositingMode(store.getBoolValueForKey(WebPreferencesKey::forceCompositingModeKey()));
+
+#if USE(COORDINATED_GRAPHICS_THREADED)
+// Fixed position elements need to be composited and create stacking contexts
+// in order to be scrolled by the ScrollingCoordinator.
+settings.setAcceleratedCompositingForFixedPositionEnabled(true);
+settings.setFixedPositionCreatesStackingContext(true);
+#endif
 }
 
 void DrawingAreaImpl::layerHostDidFlushLayers()






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [195809] trunk

[changseok . oh]

Title: [195809] trunk








Revision 195809
Author changseok...@collabora.com
Date 2016-01-29 01:58:02 -0800 (Fri, 29 Jan 2016)


Log Message
[GStreamer] built-in media player doesn't update
https://bugs.webkit.org/show_bug.cgi?id=151816

Reviewed by Xabier Rodriguez-Calvar.

Source/WebCore:

The timeline of audio controls in media document is not properly updated since it is assumed
that the controls are hidden as soon as playing. However, such full page audio always has
opacity : 1 declared by video:-webkit-full-page-media::-webkit-media-controls-panel.no-video.
i.e. it is not actually hidden. We can fix this by simply returning false for no-video media
in controlsAreHidden();

Test: media/audio-controls-timeline-in-media-document.html

* Modules/mediacontrols/mediaControlsBase.js:
(Controller.prototype.controlsAreAlwaysVisible):
(Controller.prototype.controlsAreHidden):

LayoutTests:

* media/audio-controls-timeline-in-media-document-expected.txt: Added.
* media/audio-controls-timeline-in-media-document.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/mediacontrols/mediaControlsBase.js


Added Paths

trunk/LayoutTests/media/audio-controls-timeline-in-media-document-expected.txt
trunk/LayoutTests/media/audio-controls-timeline-in-media-document.html




Diff

Modified: trunk/LayoutTests/ChangeLog (195808 => 195809)

--- trunk/LayoutTests/ChangeLog	2016-01-29 09:22:28 UTC (rev 195808)
+++ trunk/LayoutTests/ChangeLog	2016-01-29 09:58:02 UTC (rev 195809)
@@ -1,3 +1,13 @@
+2016-01-29  ChangSeok Oh  <changseok...@collabora.com>
+
+[GStreamer] built-in media player doesn't update
+https://bugs.webkit.org/show_bug.cgi?id=151816
+
+Reviewed by Xabier Rodriguez-Calvar.
+
+* media/audio-controls-timeline-in-media-document-expected.txt: Added.
+* media/audio-controls-timeline-in-media-document.html: Added.
+
 2016-01-28  Brady Eidson  <beid...@apple.com>
 
 Modern IDB: SQLite backend mismanages key generator values.


Added: trunk/LayoutTests/media/audio-controls-timeline-in-media-document-expected.txt (0 => 195809)

--- trunk/LayoutTests/media/audio-controls-timeline-in-media-document-expected.txt	(rev 0)
+++ trunk/LayoutTests/media/audio-controls-timeline-in-media-document-expected.txt	2016-01-29 09:58:02 UTC (rev 195809)
@@ -0,0 +1,6 @@
+Pass if the timeline of audio in a media document is properly updated during playback.
+
+EVENT(timeupdate)
+TEST(timeLineValue() > 0) OK
+END OF TEST
+


Added: trunk/LayoutTests/media/audio-controls-timeline-in-media-document.html (0 => 195809)

--- trunk/LayoutTests/media/audio-controls-timeline-in-media-document.html	(rev 0)
+++ trunk/LayoutTests/media/audio-controls-timeline-in-media-document.html	2016-01-29 09:58:02 UTC (rev 195809)
@@ -0,0 +1,31 @@
+
+Pass if the timeline of audio in a media document is properly updated during playback.
+
+function timeLineValue()
+{
+const timeline = mediaControlsElement(internals.shadowRoot(video).firstChild.firstChild, "-webkit-media-controls-timeline");
+if (!timeline)
+throw "Failed to find -webkit-media-controls-timeline";
+
+return timeline.value;
+}
+
+function iframeLoaded()
+{
+video = iframe.contentDocument.querySelector("video");
+video.addEventListener("timeupdate", function() {
+consoleWrite("EVENT(timeupdate)");
+testAndEnd("timeLineValue() > 0");
+});
+}
+
+var video;
+const iframe = document.createElement("iframe");
+iframe._onload_ = iframeLoaded;
+iframe.src = "" "content/test");
+
+document.body.appendChild(iframe);
+


Modified: trunk/Source/WebCore/ChangeLog (195808 => 195809)

--- trunk/Source/WebCore/ChangeLog	2016-01-29 09:22:28 UTC (rev 195808)
+++ trunk/Source/WebCore/ChangeLog	2016-01-29 09:58:02 UTC (rev 195809)
@@ -1,3 +1,22 @@
+2016-01-29  ChangSeok Oh  <changseok...@collabora.com>
+
+[GStreamer] built-in media player doesn't update
+https://bugs.webkit.org/show_bug.cgi?id=151816
+
+Reviewed by Xabier Rodriguez-Calvar.
+
+The timeline of audio controls in media document is not properly updated since it is assumed
+that the controls are hidden as soon as playing. However, such full page audio always has
+opacity : 1 declared by video:-webkit-full-page-media::-webkit-media-controls-panel.no-video.
+i.e. it is not actually hidden. We can fix this by simply returning false for no-video media
+in controlsAreHidden();
+
+Test: media/audio-controls-timeline-in-media-document.html
+
+* Modules/mediacontrols/mediaControlsBase.js:
+(Controller.prototype.controlsAreAlwaysVisible):
+(Controller.prototype.controlsAreHidden):
+
 2016-01-29  Manuel Rego Casasnovas  <r...@igalia.com>

[webkit-changes] [195771] trunk/Source/WebCore

[changseok . oh]

Title: [195771] trunk/Source/WebCore








Revision 195771
Author changseok...@collabora.com
Date 2016-01-28 12:03:30 -0800 (Thu, 28 Jan 2016)


Log Message
[ThreadedCompositor] Fix flickers happening on video when entering/leaving fullscreen.
https://bugs.webkit.org/show_bug.cgi?id=153585

Reviewed by Michael Catanzaro.

Video thumbnail flickers where threaded compositor is enabled. This is because
a content buffer is not set to a target layer which changes before swapBuffer.
This is a very rare case though, it happens where video size changes many times in a short period.

* platform/graphics/texmap/TextureMapperPlatformLayerProxy.cpp:
(WebCore::TextureMapperPlatformLayerProxy::activateOnCompositingThread):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/texmap/TextureMapperPlatformLayerProxy.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (195770 => 195771)

--- trunk/Source/WebCore/ChangeLog	2016-01-28 19:52:57 UTC (rev 195770)
+++ trunk/Source/WebCore/ChangeLog	2016-01-28 20:03:30 UTC (rev 195771)
@@ -1,3 +1,17 @@
+2016-01-28  ChangSeok Oh  <changseok...@collabora.com>
+
+[ThreadedCompositor] Fix flickers happening on video when entering/leaving fullscreen.
+https://bugs.webkit.org/show_bug.cgi?id=153585
+
+Reviewed by Michael Catanzaro.
+
+Video thumbnail flickers where threaded compositor is enabled. This is because
+a content buffer is not set to a target layer which changes before swapBuffer.
+This is a very rare case though, it happens where video size changes many times in a short period.
+
+* platform/graphics/texmap/TextureMapperPlatformLayerProxy.cpp:
+(WebCore::TextureMapperPlatformLayerProxy::activateOnCompositingThread):
+
 2016-01-27  Jer Noble  <jer.no...@apple.com>
 
 Allow CachedResourceLoader clients to opt out of the MemoryCache.


Modified: trunk/Source/WebCore/platform/graphics/texmap/TextureMapperPlatformLayerProxy.cpp (195770 => 195771)

--- trunk/Source/WebCore/platform/graphics/texmap/TextureMapperPlatformLayerProxy.cpp	2016-01-28 19:52:57 UTC (rev 195770)
+++ trunk/Source/WebCore/platform/graphics/texmap/TextureMapperPlatformLayerProxy.cpp	2016-01-28 20:03:30 UTC (rev 195771)
@@ -63,6 +63,9 @@
 LockHolder locker(m_lock);
 m_compositor = compositor;
 m_targetLayer = targetLayer;
+if (m_targetLayer && m_currentBuffer)
+m_targetLayer->setContentsLayer(m_currentBuffer.get());
+
 m_compositorThreadUpdateTimer = std::make_unique<RunLoop::Timer>(RunLoop::current(), this, ::compositorThreadUpdateTimerFired);
 }
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [195447] trunk

[changseok . oh]

Title: [195447] trunk








Revision 195447
Author changseok...@collabora.com
Date 2016-01-22 01:19:44 -0800 (Fri, 22 Jan 2016)


Log Message
[GTK] Remove a focus ring on anchor node when focused by mouse.
https://bugs.webkit.org/show_bug.cgi?id=136121

Reviewed by Michael Catanzaro.

Source/WebCore:

Safari, Chrome and FF don't show a focus ring, the dotted rectangle on anchor node
for mouse clicking. I think the behavior is reasonable and looks better.
No reason for gtk & efl ports to keep the focus on anchor node. Of course, this change should not
affect the focus ring for tab navigation.

No new tests since an existing test can cover this.
Tests: fast/events/click-focus-anchor.html

* html/HTMLAnchorElement.cpp:
(WebCore::HTMLAnchorElement::isMouseFocusable):

LayoutTests:

Removed gtk and efl specific results for the test.

* platform/efl/fast/events/click-focus-anchor-expected.txt: Removed.
* platform/gtk/fast/events/click-focus-anchor-expected.txt: Removed.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/HTMLAnchorElement.cpp


Removed Paths

trunk/LayoutTests/platform/efl/fast/events/click-focus-anchor-expected.txt
trunk/LayoutTests/platform/gtk/fast/events/click-focus-anchor-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (195446 => 195447)

--- trunk/LayoutTests/ChangeLog	2016-01-22 07:24:36 UTC (rev 195446)
+++ trunk/LayoutTests/ChangeLog	2016-01-22 09:19:44 UTC (rev 195447)
@@ -1,3 +1,15 @@
+2016-01-22  ChangSeok Oh  <changseok...@collabora.com>
+
+[GTK] Remove a focus ring on anchor node when focused by mouse.
+https://bugs.webkit.org/show_bug.cgi?id=136121
+
+Reviewed by Michael Catanzaro.
+
+Removed gtk and efl specific results for the test.
+
+* platform/efl/fast/events/click-focus-anchor-expected.txt: Removed.
+* platform/gtk/fast/events/click-focus-anchor-expected.txt: Removed.
+
 2016-01-21  Simon Fraser  <simon.fra...@apple.com>
 
 REGRESSION (r168244): Content in horizontal-bt page is offset such that only the end is viewable and there is a white gap at the top


Deleted: trunk/LayoutTests/platform/efl/fast/events/click-focus-anchor-expected.txt (195446 => 195447)

--- trunk/LayoutTests/platform/efl/fast/events/click-focus-anchor-expected.txt	2016-01-22 07:24:36 UTC (rev 195446)
+++ trunk/LayoutTests/platform/efl/fast/events/click-focus-anchor-expected.txt	2016-01-22 09:19:44 UTC (rev 195447)
@@ -1,11 +0,0 @@
-This test ensures that we can click to focus an a element. Click on the element below.
-
-The expected result is platform specific. GTK, QT and EFL allows all links to be mouse focusable.
-
-Result
-
-
-a1 received focus (focusable)
-a3 received focus (focusable on GTK, QT and EFL)
-a4 received focus (focusable)
-a5 received focus (focusable)


Deleted: trunk/LayoutTests/platform/gtk/fast/events/click-focus-anchor-expected.txt (195446 => 195447)

--- trunk/LayoutTests/platform/gtk/fast/events/click-focus-anchor-expected.txt	2016-01-22 07:24:36 UTC (rev 195446)
+++ trunk/LayoutTests/platform/gtk/fast/events/click-focus-anchor-expected.txt	2016-01-22 09:19:44 UTC (rev 195447)
@@ -1,11 +0,0 @@
-This test ensures that we can click to focus an a element. Click on the element below.
-
-The expected result is platform specific. GTK, QT and EFL allows all links to be mouse focusable.
-
-Result
-
-
-a1 received focus (focusable)
-a3 received focus (focusable on GTK, QT and EFL)
-a4 received focus (focusable)
-a5 received focus (focusable)


Modified: trunk/Source/WebCore/ChangeLog (195446 => 195447)

--- trunk/Source/WebCore/ChangeLog	2016-01-22 07:24:36 UTC (rev 195446)
+++ trunk/Source/WebCore/ChangeLog	2016-01-22 09:19:44 UTC (rev 195447)
@@ -1,3 +1,21 @@
+2016-01-22  ChangSeok Oh  <changseok...@collabora.com>
+
+[GTK] Remove a focus ring on anchor node when focused by mouse.
+https://bugs.webkit.org/show_bug.cgi?id=136121
+
+Reviewed by Michael Catanzaro.
+
+Safari, Chrome and FF don't show a focus ring, the dotted rectangle on anchor node
+for mouse clicking. I think the behavior is reasonable and looks better.
+No reason for gtk & efl ports to keep the focus on anchor node. Of course, this change should not
+affect the focus ring for tab navigation.
+
+No new tests since an existing test can cover this.
+Tests: fast/events/click-focus-anchor.html
+
+* html/HTMLAnchorElement.cpp:
+(WebCore::HTMLAnchorElement::isMouseFocusable):
+
 2016-01-21  Simon Fraser  <simon.fra...@apple.com>
 
 REGRESSION (r168244): Content in horizontal-bt page is offset such that only the end is viewable and there is a white gap at the top


Modified: trunk/Source/WebCore/html/HTMLAnchorElement.cpp (195446 => 195447)

--- trunk/Source/WebCore/html/HTMLAnchorElement.cpp	2016-01-22 07:24:36 UTC (rev 195446)
+++ trunk/Source/WebCore/html/HTMLAnchor

[webkit-changes] [194453] trunk/LayoutTests

[changseok . oh]

Title: [194453] trunk/LayoutTests








Revision 194453
Author changseok...@collabora.com
Date 2015-12-31 08:47:49 -0800 (Thu, 31 Dec 2015)


Log Message
[GTK] Unreviewed gardening at 2015-12-31

Mark fast/text/text-combine-placement.html as crashing.


* platform/gtk/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/gtk/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (194452 => 194453)

--- trunk/LayoutTests/ChangeLog	2015-12-31 05:43:33 UTC (rev 194452)
+++ trunk/LayoutTests/ChangeLog	2015-12-31 16:47:49 UTC (rev 194453)
@@ -1,3 +1,11 @@
+2015-12-31  ChangSeok Oh  <changseok...@collabora.com>
+
+[GTK] Unreviewed gardening at 2015-12-31
+
+Mark fast/text/text-combine-placement.html as crashing.
+
+* platform/gtk/TestExpectations:
+
 2015-12-30  Brady Eidson  <beid...@apple.com>
 
 Modern IDB: Only fire blocked events after all open connections have handled their versionchange events.


Modified: trunk/LayoutTests/platform/gtk/TestExpectations (194452 => 194453)

--- trunk/LayoutTests/platform/gtk/TestExpectations	2015-12-31 05:43:33 UTC (rev 194452)
+++ trunk/LayoutTests/platform/gtk/TestExpectations	2015-12-31 16:47:49 UTC (rev 194453)
@@ -649,6 +649,8 @@
 
 webkit.org/b/118902 svg/animations/svgenum-animation-6.html [ Crash Pass ]
 
+webkit.org/b/152610 fast/text/text-combine-placement.html [ Crash ]
+
 # Crashing after the FTL merge
 webkit.org/b/119255 [ Debug ] fast/workers/stress-js-execution.html [ Crash Pass ]
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [194390] trunk/LayoutTests

[changseok . oh]

Title: [194390] trunk/LayoutTests








Revision 194390
Author changseok...@collabora.com
Date 2015-12-23 08:56:13 -0800 (Wed, 23 Dec 2015)


Log Message
[GTK] Unreviewed gardening

RTCPeerConnection-state.html is removed after r194112. Remove failure expectations
for tests which have been passing. Add new expectations for text-combine-shrink-on-color-change.html


* platform/gtk/TestExpectations:
* platform/gtk/fast/text/text-combine-shrink-on-color-change-expected.png: Added.
* platform/gtk/fast/text/text-combine-shrink-on-color-change-expected.txt: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/gtk/TestExpectations


Added Paths

trunk/LayoutTests/platform/gtk/fast/text/text-combine-shrink-on-color-change-expected.png
trunk/LayoutTests/platform/gtk/fast/text/text-combine-shrink-on-color-change-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (194389 => 194390)

--- trunk/LayoutTests/ChangeLog	2015-12-23 14:03:21 UTC (rev 194389)
+++ trunk/LayoutTests/ChangeLog	2015-12-23 16:56:13 UTC (rev 194390)
@@ -1,3 +1,14 @@
+2015-12-23  ChangSeok Oh  <changseok...@collabora.com>
+
+[GTK] Unreviewed gardening
+
+RTCPeerConnection-state.html is removed after r194112. Remove failure expectations
+for tests which have been passing. Add new expectations for text-combine-shrink-on-color-change.html
+
+* platform/gtk/TestExpectations:
+* platform/gtk/fast/text/text-combine-shrink-on-color-change-expected.png: Added.
+* platform/gtk/fast/text/text-combine-shrink-on-color-change-expected.txt: Added.
+
 2015-12-23  Andy VanWagoner  <a...@instructure.com>
 
 [INTL] Implement Intl.DateTimeFormat.prototype.resolvedOptions ()


Modified: trunk/LayoutTests/platform/gtk/TestExpectations (194389 => 194390)

--- trunk/LayoutTests/platform/gtk/TestExpectations	2015-12-23 14:03:21 UTC (rev 194389)
+++ trunk/LayoutTests/platform/gtk/TestExpectations	2015-12-23 16:56:13 UTC (rev 194390)
@@ -349,7 +349,6 @@
 webkit.org/b/79203 fast/mediastream/RTCPeerConnection-onnegotiationneeded.html [ Skip ]
 webkit.org/b/79203 fast/mediastream/RTCPeerConnection-remoteDescription.html [ Skip ]
 webkit.org/b/79203 fast/mediastream/RTCPeerConnection-stable.html [ Skip ]
-webkit.org/b/79203 fast/mediastream/RTCPeerConnection-state.html [ Skip ]
 webkit.org/b/79203 fast/mediastream/RTCPeerConnection-stats.html [ Skip ]
 webkit.org/b/79203 fast/mediastream/RTCPeerConnection-statsSelector.html [ Skip ]
 webkit.org/b/79203 fast/events/constructors/media-stream-event-constructor.html [ Skip ]
@@ -553,9 +552,7 @@
 webkit.org/b/142269 fast/attachment/attachment-dom.html [ Failure ]
 webkit.org/b/142270 fast/canvas/canvas-ellipse-zero-lineto.html [ Failure ]
 
-webkit.org/b/127109 media/video-object-fit.html [ ImageOnlyFailure ]
 webkit.org/b/142283 fast/regions/overflow/overflow-first-and-last-regions.html [ ImageOnlyFailure ]
-webkit.org/b/142287 svg/clip-path/clip-path-line-use-before-defined.svg [ ImageOnlyFailure ]
 webkit.org/b/142289 mathml/presentation/scripts-subsup.html [ ImageOnlyFailure ]
 
 webkit.org/b/142819 fast/text/baseline-inline-block.html [ ImageOnlyFailure ]


Added: trunk/LayoutTests/platform/gtk/fast/text/text-combine-shrink-on-color-change-expected.png

(Binary files differ)

Property changes on: trunk/LayoutTests/platform/gtk/fast/text/text-combine-shrink-on-color-change-expected.png
___

Added: svn:mime-type

Added: trunk/LayoutTests/platform/gtk/fast/text/text-combine-shrink-on-color-change-expected.txt (0 => 194390)

--- trunk/LayoutTests/platform/gtk/fast/text/text-combine-shrink-on-color-change-expected.txt	(rev 0)
+++ trunk/LayoutTests/platform/gtk/fast/text/text-combine-shrink-on-color-change-expected.txt	2015-12-23 16:56:13 UTC (rev 194390)
@@ -0,0 +1,13 @@
+layer at (0,0) size 800x600
+  RenderView at (0,0) size 800x600
+layer at (0,0) size 800x600
+  RenderBlock {HTML} at (0,0) size 800x600
+RenderBody {BODY} at (8,8) size 784x584
+  RenderBlock {DIV} at (0,0) size 40x200 [color=#008000]
+RenderText {#text} at (0,0) size 40x27
+  text run at (0,0) width 27: "1 "
+RenderInline {SPAN} at (0,0) size 40x108
+  RenderCombineText {#text} at (0,27) size 40x108
+text run at (0,27) width 108: "123456"
+RenderText {#text} at (0,135) size 40x27
+  text run at (0,135) width 27: " 2"






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [191576] trunk

[changseok . oh]

Title: [191576] trunk








Revision 191576
Author changseok...@collabora.com
Date 2015-10-26 01:57:40 -0700 (Mon, 26 Oct 2015)


Log Message
[GStreamer] Bump internal jhbuild versions to 1.6.0
https://bugs.webkit.org/show_bug.cgi?id=149594

Reviewed by Philippe Normand.

.:

Bump up the minimum reqirement version of gstreamer-gl to 1.6.0.

* Source/cmake/FindGStreamer.cmake:

Tools:

Bump up whole gstreamer libraries to 1.6.0. Relevant patches are no more
useful so they are removed accordingly.

* gtk/jhbuild.modules:
* gtk/patches/gst-plugins-bad-fix-faad2-version-check.patch: Removed.
* gtk/patches/gst-plugins-bad-remove-gnustep-support.patch: Removed.
* gtk/patches/gst-plugins-base-rtp-rtcpbuffer-fix-typo-in-enum.patch: Removed.

Modified Paths

trunk/ChangeLog
trunk/Source/cmake/FindGStreamer.cmake
trunk/Tools/ChangeLog
trunk/Tools/gtk/jhbuild.modules


Removed Paths

trunk/Tools/gtk/patches/gst-plugins-bad-fix-faad2-version-check.patch
trunk/Tools/gtk/patches/gst-plugins-bad-remove-gnustep-support.patch
trunk/Tools/gtk/patches/gst-plugins-base-rtp-rtcpbuffer-fix-typo-in-enum.patch




Diff

Modified: trunk/ChangeLog (191575 => 191576)

--- trunk/ChangeLog	2015-10-26 08:56:21 UTC (rev 191575)
+++ trunk/ChangeLog	2015-10-26 08:57:40 UTC (rev 191576)
@@ -1,3 +1,14 @@
+2015-10-26  ChangSeok Oh  <changseok...@collabora.com>
+
+[GStreamer] Bump internal jhbuild versions to 1.6.0
+https://bugs.webkit.org/show_bug.cgi?id=149594
+
+Reviewed by Philippe Normand.
+
+Bump up the minimum reqirement version of gstreamer-gl to 1.6.0.
+
+* Source/cmake/FindGStreamer.cmake:
+
 2015-10-22  Philippe Normand  <pnorm...@igalia.com>
 
 [GTK][Mac] ICU-related build fixes


Modified: trunk/Source/cmake/FindGStreamer.cmake (191575 => 191576)

--- trunk/Source/cmake/FindGStreamer.cmake	2015-10-26 08:56:21 UTC (rev 191575)
+++ trunk/Source/cmake/FindGStreamer.cmake	2015-10-26 08:57:40 UTC (rev 191576)
@@ -85,7 +85,7 @@
 FIND_GSTREAMER_COMPONENT(GSTREAMER_APP gstreamer-app-1.0 gstapp-1.0)
 FIND_GSTREAMER_COMPONENT(GSTREAMER_AUDIO gstreamer-audio-1.0 gstaudio-1.0)
 FIND_GSTREAMER_COMPONENT(GSTREAMER_FFT gstreamer-fft-1.0 gstfft-1.0)
-FIND_GSTREAMER_COMPONENT(GSTREAMER_GL gstreamer-gl-1.0>=1.5.0 gstgl-1.0)
+FIND_GSTREAMER_COMPONENT(GSTREAMER_GL gstreamer-gl-1.0>=1.6.0 gstgl-1.0)
 FIND_GSTREAMER_COMPONENT(GSTREAMER_MPEGTS gstreamer-mpegts-1.0>=1.4.0 gstmpegts-1.0)
 FIND_GSTREAMER_COMPONENT(GSTREAMER_PBUTILS gstreamer-pbutils-1.0 gstpbutils-1.0)
 FIND_GSTREAMER_COMPONENT(GSTREAMER_TAG gstreamer-tag-1.0 gsttag-1.0)


Modified: trunk/Tools/ChangeLog (191575 => 191576)

--- trunk/Tools/ChangeLog	2015-10-26 08:56:21 UTC (rev 191575)
+++ trunk/Tools/ChangeLog	2015-10-26 08:57:40 UTC (rev 191576)
@@ -1,3 +1,18 @@
+2015-10-26  ChangSeok Oh  <changseok...@collabora.com>
+
+[GStreamer] Bump internal jhbuild versions to 1.6.0
+https://bugs.webkit.org/show_bug.cgi?id=149594
+
+Reviewed by Philippe Normand.
+
+Bump up whole gstreamer libraries to 1.6.0. Relevant patches are no more
+useful so they are removed accordingly.
+
+* gtk/jhbuild.modules:
+* gtk/patches/gst-plugins-bad-fix-faad2-version-check.patch: Removed.
+* gtk/patches/gst-plugins-bad-remove-gnustep-support.patch: Removed.
+* gtk/patches/gst-plugins-base-rtp-rtcpbuffer-fix-typo-in-enum.patch: Removed.
+
 2015-10-25  Alexey Proskuryakov  <a...@apple.com>
 
 API tests fail on El Capitan after r191543


Modified: trunk/Tools/gtk/jhbuild.modules (191575 => 191576)

--- trunk/Tools/gtk/jhbuild.modules	2015-10-26 08:56:21 UTC (rev 191575)
+++ trunk/Tools/gtk/jhbuild.modules	2015-10-26 08:57:40 UTC (rev 191576)
@@ -284,10 +284,10 @@
   
 
   
-+ repo="gstreamer"
-hash="sha256:f0e305d91a93d05bf9e332cd4256ca07d77f5186a4d73847b7ae6db218f2c237"
-md5sum="98f4a6d45a28dd195144baef0244ba38"/>
+hash="sha256:52ef885647afef11c8b7645a9afefe04aa09e8971c4b932e7717872ab8a30fcc"
+md5sum="201c15ac4b956833f7f6774485433969"/>
   
 
   @@ -296,12 +296,10 @@
 
   
 
-+ repo="gstreamer"
-hash="sha256:49cd9e8f23c416b1607b43837a09833fa03e0106929d81ead2ddfde6c0ade44b"
-md5sum="0c42eca8f9e4efd56d2ce8e9249ce4a1">
-  
-
+hash="sha256:314fd1b707f65caf8eb6164d9422fc51e2b220a890ccd2de6ec03a2883d77231"
+md5sum="3c223f1d2716e1861ba84287ea02b164"/>
   
 
   
@@ -309,34 +307,30 @@
   
 
 
-+ repo="gstreamer"
-hash="sha256:2df90e99da45211c7b2525ae4ac34830a9e7784bd48c072c406c0cf014bdb277"
-md5sum="673cf9276952bd3937dafd817c9ead2b">
-
+hash="sha256:a0915639595305e48884656

[webkit-changes] [191298] trunk/Tools

[changseok . oh]

Title: [191298] trunk/Tools








Revision 191298
Author changseok...@collabora.com
Date 2015-10-19 11:01:07 -0700 (Mon, 19 Oct 2015)


Log Message
REGRESSION(r190262): User media unit test failures after r190262
https://bugs.webkit.org/show_bug.cgi?id=149580

Reviewed by Carlos Garcia Campos.

The test failures on usermedia-permission-requests and WebKit2.UserMediaBasic have gone.
So we do not need to skip them anymore.

* Scripts/run-gtk-tests:
(TestRunner): Deleted.

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/run-gtk-tests




Diff

Modified: trunk/Tools/ChangeLog (191297 => 191298)

--- trunk/Tools/ChangeLog	2015-10-19 17:58:49 UTC (rev 191297)
+++ trunk/Tools/ChangeLog	2015-10-19 18:01:07 UTC (rev 191298)
@@ -1,3 +1,16 @@
+2015-10-19  ChangSeok Oh  <changseok...@collabora.com>
+
+REGRESSION(r190262): User media unit test failures after r190262
+https://bugs.webkit.org/show_bug.cgi?id=149580
+
+Reviewed by Carlos Garcia Campos.
+
+The test failures on usermedia-permission-requests and WebKit2.UserMediaBasic have gone.
+So we do not need to skip them anymore.
+
+* Scripts/run-gtk-tests:
+(TestRunner): Deleted.
+
 2015-10-19  Csaba Osztrogonác  <o...@webkit.org>
 
 Add historical addresses to contributors.json


Modified: trunk/Tools/Scripts/run-gtk-tests (191297 => 191298)

--- trunk/Tools/Scripts/run-gtk-tests	2015-10-19 17:58:49 UTC (rev 191297)
+++ trunk/Tools/Scripts/run-gtk-tests	2015-10-19 18:01:07 UTC (rev 191298)
@@ -62,7 +62,6 @@
 
 SKIPPED = [
 SkippedTest("WebKit2Gtk/TestUIClient", "/webkit2/WebKitWebView/mouse-target", "Test times out after r150890", 117689),
-SkippedTest("WebKit2Gtk/TestUIClient", "/webkit2/WebKitWebView/usermedia-permission-requests", "Test fails after r190262", 149580),
 SkippedTest("WebKit2Gtk/TestCookieManager", "/webkit2/WebKitCookieManager/persistent-storage", "Test is flaky", 134580),
 SkippedTest("WebKit2Gtk/TestWebExtensions", "/webkit2/WebKitWebView/install-missing-plugins-permission-request", "Test times out", 147822),
 SkippedTest("WebKit2/TestWebKit2", "WebKit2.MouseMoveAfterCrash", "Test is flaky", 85066),
@@ -75,7 +74,6 @@
 SkippedTest("WebKit2/TestWebKit2", "WebKit2.DidAssociateFormControls", "Test times out", 120302),
 SkippedTest("WebKit2/TestWebKit2", "WebKit2.InjectedBundleFrameHitTest", "Test times out", 120303),
 SkippedTest("WebKit2/TestWebKit2", "WebKit2.TerminateTwice", "Test causes crash on the next test", 121970),
-SkippedTest("WebKit2/TestWebKit2", "WebKit2.UserMediaBasic", "Test crashes after r190262", 149580),
 SkippedTest("WebKit2/TestWebKit2", "WebKit2.GeolocationTransitionToHighAccuracy", "Test causes crash on the next test", 125068),
 SkippedTest("WebKit2/TestWebKit2", "WebKit2.GeolocationTransitionToLowAccuracy", "Test causes crash on the next test", 125068),
 ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [190970] trunk/Source/WebCore

[changseok . oh]

Title: [190970] trunk/Source/WebCore








Revision 190970
Author changseok...@collabora.com
Date 2015-10-13 04:30:48 -0700 (Tue, 13 Oct 2015)


Log Message
[GTK] Use GUniquePtr for GtkIconInfo
https://bugs.webkit.org/show_bug.cgi?id=150082

Reviewed by Carlos Garcia Campos.

GtkIconInfo cab be wrapped by a smart pointer, GUniqueptr.

No new test required since no functionality changed.

* rendering/RenderThemeGtk.cpp:
(WebCore::getStockSymbolicIconForWidgetType):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderThemeGtk.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (190969 => 190970)

--- trunk/Source/WebCore/ChangeLog	2015-10-13 11:24:06 UTC (rev 190969)
+++ trunk/Source/WebCore/ChangeLog	2015-10-13 11:30:48 UTC (rev 190970)
@@ -1,3 +1,17 @@
+2015-10-13  ChangSeok Oh  <changseok...@collabora.com>
+
+[GTK] Use GUniquePtr for GtkIconInfo
+https://bugs.webkit.org/show_bug.cgi?id=150082
+
+Reviewed by Carlos Garcia Campos.
+
+GtkIconInfo cab be wrapped by a smart pointer, GUniqueptr.
+
+No new test required since no functionality changed.
+
+* rendering/RenderThemeGtk.cpp:
+(WebCore::getStockSymbolicIconForWidgetType):
+
 2015-10-12  Jaehun Lim  <ljaehun@samsung.com>
 
 Unreviewed, fix debug build warning.


Modified: trunk/Source/WebCore/rendering/RenderThemeGtk.cpp (190969 => 190970)

--- trunk/Source/WebCore/rendering/RenderThemeGtk.cpp	2015-10-13 11:24:06 UTC (rev 190969)
+++ trunk/Source/WebCore/rendering/RenderThemeGtk.cpp	2015-10-13 11:30:48 UTC (rev 190970)
@@ -30,6 +30,7 @@
 #include "FileList.h"
 #include "FileSystem.h"
 #include "FontDescription.h"
+#include "GUniquePtrGtk.h"
 #include "Gradient.h"
 #include "GraphicsContext.h"
 #include "GtkVersioning.h"
@@ -236,14 +237,13 @@
 
 gtk_style_context_set_state(context, static_cast(flags));
 gtk_style_context_set_direction(context, static_cast(direction));
-GtkIconInfo* info = gtk_icon_theme_lookup_icon(gtk_icon_theme_get_default(), symbolicIconName, iconSize,
-static_cast(GTK_ICON_LOOKUP_FORCE_SVG | GTK_ICON_LOOKUP_FORCE_SIZE));
-GdkPixbuf* icon = 0;
-if (info) {
-icon = gtk_icon_info_load_symbolic_for_context(info, context, 0, 0);
-gtk_icon_info_free(info);
-}
 
+GUniquePtr info(gtk_icon_theme_lookup_icon(gtk_icon_theme_get_default(), symbolicIconName, iconSize,
+static_cast(GTK_ICON_LOOKUP_FORCE_SVG | GTK_ICON_LOOKUP_FORCE_SIZE)));
+GdkPixbuf* icon = nullptr;
+if (info)
+icon = gtk_icon_info_load_symbolic_for_context(info.get(), context, nullptr, nullptr);
+
 gtk_style_context_restore(context);
 
 if (!icon) {






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [190662] trunk

[changseok . oh]

Title: [190662] trunk








Revision 190662
Author changseok...@collabora.com
Date 2015-10-07 00:32:14 -0700 (Wed, 07 Oct 2015)


Log Message
[GTK] Progress bar is broken on recent GTK+
https://bugs.webkit.org/show_bug.cgi?id=149831

Reviewed by Carlos Garcia Campos.

Source/WebCore:

The gtk progress bar has been broken after bumping up to Gtk+-3.16. This is because
the way of rendering progress bar changed after gtk+-3.13.7. See more
https://mail.gnome.org/archives/commits-list/2014-August/msg03865.html
gtk_render_activity is no longer valid to paint a progress bar on a newer gtk+.
It should be done with gtk_render_background and gtk_render_frame.

Test: fast/dom/HTMLProgressElement/native-progress-bar.html

* rendering/RenderThemeGtk.cpp:
(WebCore::RenderThemeGtk::paintProgressBar):

LayoutTests:

* fast/dom/HTMLProgressElement/native-progress-bar.html: Added.
* platform/gtk/fast/dom/HTMLProgressElement/native-progress-bar-expected.png: Added.
* platform/gtk/fast/dom/HTMLProgressElement/native-progress-bar-expected.txt: Added.
* platform/mac/fast/dom/HTMLProgressElement/native-progress-bar-expected.png: Added.
* platform/mac/fast/dom/HTMLProgressElement/native-progress-bar-expected.txt: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderThemeGtk.cpp


Added Paths

trunk/LayoutTests/fast/dom/HTMLProgressElement/native-progress-bar.html
trunk/LayoutTests/platform/gtk/fast/dom/HTMLProgressElement/native-progress-bar-expected.png
trunk/LayoutTests/platform/gtk/fast/dom/HTMLProgressElement/native-progress-bar-expected.txt
trunk/LayoutTests/platform/mac/fast/dom/HTMLProgressElement/native-progress-bar-expected.png
trunk/LayoutTests/platform/mac/fast/dom/HTMLProgressElement/native-progress-bar-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (190661 => 190662)

--- trunk/LayoutTests/ChangeLog	2015-10-07 07:11:08 UTC (rev 190661)
+++ trunk/LayoutTests/ChangeLog	2015-10-07 07:32:14 UTC (rev 190662)
@@ -1,3 +1,16 @@
+2015-10-07  ChangSeok Oh  <changseok...@collabora.com>
+
+[GTK] Progress bar is broken on recent GTK+
+https://bugs.webkit.org/show_bug.cgi?id=149831
+
+Reviewed by Carlos Garcia Campos.
+
+* fast/dom/HTMLProgressElement/native-progress-bar.html: Added.
+* platform/gtk/fast/dom/HTMLProgressElement/native-progress-bar-expected.png: Added.
+* platform/gtk/fast/dom/HTMLProgressElement/native-progress-bar-expected.txt: Added.
+* platform/mac/fast/dom/HTMLProgressElement/native-progress-bar-expected.png: Added.
+* platform/mac/fast/dom/HTMLProgressElement/native-progress-bar-expected.txt: Added.
+
 2015-10-06  Jon Honeycutt  <jhoneyc...@apple.com>
 
 Unreviewed iOS test gardening after r190629.


Added: trunk/LayoutTests/fast/dom/HTMLProgressElement/native-progress-bar.html (0 => 190662)

--- trunk/LayoutTests/fast/dom/HTMLProgressElement/native-progress-bar.html	(rev 0)
+++ trunk/LayoutTests/fast/dom/HTMLProgressElement/native-progress-bar.html	2015-10-07 07:32:14 UTC (rev 190662)
@@ -0,0 +1,4 @@
+
+Test passes if following bars are filled 30% with a color.
+
+


Added: trunk/LayoutTests/platform/gtk/fast/dom/HTMLProgressElement/native-progress-bar-expected.png

(Binary files differ)

Property changes on: trunk/LayoutTests/platform/gtk/fast/dom/HTMLProgressElement/native-progress-bar-expected.png
___

Added: svn:mime-type

Added: trunk/LayoutTests/platform/gtk/fast/dom/HTMLProgressElement/native-progress-bar-expected.txt (0 => 190662)

--- trunk/LayoutTests/platform/gtk/fast/dom/HTMLProgressElement/native-progress-bar-expected.txt	(rev 0)
+++ trunk/LayoutTests/platform/gtk/fast/dom/HTMLProgressElement/native-progress-bar-expected.txt	2015-10-07 07:32:14 UTC (rev 190662)
@@ -0,0 +1,16 @@
+layer at (0,0) size 800x600
+  RenderView at (0,0) size 800x600
+layer at (0,0) size 800x99
+  RenderBlock {HTML} at (0,0) size 800x99
+RenderBody {BODY} at (8,16) size 784x67
+  RenderBlock {P} at (0,0) size 784x17
+RenderText {#text} at (0,0) size 354x17
+  text run at (0,0) width 354: "Test passes if following bars are filled 30% with a color."
+  RenderBlock {P} at (0,33) size 784x34
+RenderProgress {PROGRESS} at (0,1) size 160x17
+RenderBR {BR} at (160,0) size 0x17
+RenderBlock {PROGRESS} at (0,18) size 160x17
+  RenderProgress {DIV} at (0,0) size 160x16
+RenderBlock {DIV} at (0,0) size 160x16 [bgcolor=#808080]
+  RenderBlock {DIV} at (0,0) size 48x16 [bgcolor=#008000]
+RenderText {#text} at (0,0) size 0x0


Added: trunk/LayoutTests/platform/mac/fast/dom/HTMLProgressElement/native-progress-bar-expected.png

(Binary files differ)

Property changes on: trunk/LayoutTests/platform/mac/fast/dom/HTMLProgressElement/n

[webkit-changes] [190200] trunk

[changseok . oh]

Title: [190200] trunk








Revision 190200
Author changseok...@collabora.com
Date 2015-09-24 02:41:06 -0700 (Thu, 24 Sep 2015)


Log Message
[GTK] playbutton in media controls is not changed when it is clicked.
https://bugs.webkit.org/show_bug.cgi?id=149113

Reviewed by Philippe Normand.

Source/WebCore:

When the play button in media controls is clicked, a 'paused' class is added or removed
for the element to update its appearance. Although Document::recalcStyle is triggered
by that class attribute change, the play button is not changed since there is
no difference in styles whether having the 'paused' class or not. Gtk port
does not define the -webkit-media-controls-play-button.paused. To fix this,
-webkit-media-controls-play-button.paused is newly defined with a dummy style,
"position: relative;", which should not change the play button appearance,
but be clearly different in style.

Test: media/media-controls-play-button-updates.html

* css/mediaControlsGtk.css:
(video::-webkit-media-controls-play-button.paused):

LayoutTests:

* media/media-controls-play-button-updates-expected.png: Added.
* media/media-controls-play-button-updates-expected.txt: Added.
* media/media-controls-play-button-updates.html: Added.
* platform/efl/TestExpectations: Skip the test.
* platform/gtk/media/media-controls-play-button-updates-expected.png: Added.
* platform/gtk/media/media-controls-play-button-updates-expected.txt: Added.
* platform/mac/TestExpectations: Skip the test on yosemite.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/efl/TestExpectations
trunk/LayoutTests/platform/mac/TestExpectations
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/mediaControlsGtk.css


Added Paths

trunk/LayoutTests/media/media-controls-play-button-updates-expected.png
trunk/LayoutTests/media/media-controls-play-button-updates-expected.txt
trunk/LayoutTests/media/media-controls-play-button-updates.html
trunk/LayoutTests/platform/gtk/media/media-controls-play-button-updates-expected.png
trunk/LayoutTests/platform/gtk/media/media-controls-play-button-updates-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (190199 => 190200)

--- trunk/LayoutTests/ChangeLog	2015-09-24 09:24:54 UTC (rev 190199)
+++ trunk/LayoutTests/ChangeLog	2015-09-24 09:41:06 UTC (rev 190200)
@@ -1,3 +1,18 @@
+2015-09-24  ChangSeok Oh  <changseok...@collabora.com>
+
+[GTK] playbutton in media controls is not changed when it is clicked.
+https://bugs.webkit.org/show_bug.cgi?id=149113
+
+Reviewed by Philippe Normand.
+
+* media/media-controls-play-button-updates-expected.png: Added.
+* media/media-controls-play-button-updates-expected.txt: Added.
+* media/media-controls-play-button-updates.html: Added.
+* platform/efl/TestExpectations: Skip the test.
+* platform/gtk/media/media-controls-play-button-updates-expected.png: Added.
+* platform/gtk/media/media-controls-play-button-updates-expected.txt: Added.
+* platform/mac/TestExpectations: Skip the test on yosemite.
+
 2015-09-23  Myles C. Maxfield  <mmaxfi...@apple.com>
 
 [Cocoa] [Font Features] Implement font-variant-*


Added: trunk/LayoutTests/media/media-controls-play-button-updates-expected.png

(Binary files differ)

Property changes on: trunk/LayoutTests/media/media-controls-play-button-updates-expected.png
___

Added: svn:mime-type

Added: trunk/LayoutTests/media/media-controls-play-button-updates-expected.txt (0 => 190200)

--- trunk/LayoutTests/media/media-controls-play-button-updates-expected.txt	(rev 0)
+++ trunk/LayoutTests/media/media-controls-play-button-updates-expected.txt	2015-09-24 09:41:06 UTC (rev 190200)
@@ -0,0 +1,64 @@
+layer at (0,0) size 800x600
+  RenderView at (0,0) size 800x600
+layer at (0,0) size 800x356
+  RenderBlock {HTML} at (0,0) size 800x356
+RenderBody {BODY} at (8,16) size 784x332
+  RenderBlock {P} at (0,0) size 784x18
+RenderText {#text} at (0,0) size 548x18
+  text run at (0,0) width 548: "This tests if media controls play button is properly updated accroding to mouse clicks"
+  RenderBlock (anonymous) at (0,34) size 784x244
+RenderText {#text} at (0,0) size 0x0
+RenderText {#text} at (0,0) size 0x0
+RenderText {#text} at (0,0) size 0x0
+RenderText {#text} at (0,0) size 0x0
+  RenderBlock {DIV} at (0,278) size 784x54
+RenderText {#text} at (0,0) size 163x18
+  text run at (0,0) width 163: "EVENT(canplaythrough)"
+RenderBR {BR} at (162,0) size 1x18
+RenderText {#text} at (0,18) size 112x18
+  text run at (0,18) width 112: "EVENT(playing)"
+RenderBR {BR} at (111,18) size 1x18
+RenderText {#text} at (0,36) size 100x18
+  text run at (0,36) width 100: "EVENT(pause)"
+

[webkit-changes] [190205] trunk/Source/WebCore

[changseok . oh]

Title: [190205] trunk/Source/WebCore








Revision 190205
Author changseok...@collabora.com
Date 2015-09-24 08:55:47 -0700 (Thu, 24 Sep 2015)


Log Message
Unreviewed, fix typo errors in a comment ("passed" -> "Passed", "Overwise" -> "Otherwise")

* css/mediaControlsGtk.css:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/mediaControlsGtk.css




Diff

Modified: trunk/Source/WebCore/ChangeLog (190204 => 190205)

--- trunk/Source/WebCore/ChangeLog	2015-09-24 15:48:41 UTC (rev 190204)
+++ trunk/Source/WebCore/ChangeLog	2015-09-24 15:55:47 UTC (rev 190205)
@@ -1,3 +1,9 @@
+2015-09-24  ChangSeok Oh  <changseok...@collabora.com>
+
+Unreviewed, fix typo errors in a comment ("passed" -> "Passed", "Overwise" -> "Otherwise")
+
+* css/mediaControlsGtk.css:
+
 2015-09-24  Gyuyoung Kim  <gyuyoung@webkit.org>
 
 Reduce almost uses of PassRefPtr in Webcore/testing


Modified: trunk/Source/WebCore/css/mediaControlsGtk.css (190204 => 190205)

--- trunk/Source/WebCore/css/mediaControlsGtk.css	2015-09-24 15:48:41 UTC (rev 190204)
+++ trunk/Source/WebCore/css/mediaControlsGtk.css	2015-09-24 15:55:47 UTC (rev 190205)
@@ -145,7 +145,7 @@
 outline: none;
 }
 
-/* paused classes for audio/video controls should be defined to make a difference in style from not having this class. Overwise a repaint would not happen. */
+/* Paused classes for audio/video controls should be defined to make a difference in style from not having this class. Otherwise a repaint would not happen. */
 audio::-webkit-media-controls-play-button.paused,
 video::-webkit-media-controls-play-button.paused {
 position: relative;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [190204] trunk/LayoutTests

[changseok . oh]

Title: [190204] trunk/LayoutTests








Revision 190204
Author changseok...@collabora.com
Date 2015-09-24 08:48:41 -0700 (Thu, 24 Sep 2015)


Log Message
Unreviewed, rebaseline media/media-controls-play-button-updates.html.

* platform/gtk/media/media-controls-play-button-updates-expected.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/gtk/media/media-controls-play-button-updates-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (190203 => 190204)

--- trunk/LayoutTests/ChangeLog	2015-09-24 15:39:06 UTC (rev 190203)
+++ trunk/LayoutTests/ChangeLog	2015-09-24 15:48:41 UTC (rev 190204)
@@ -1,5 +1,11 @@
 2015-09-24  ChangSeok Oh  <changseok...@collabora.com>
 
+Unreviewed, rebaseline media/media-controls-play-button-updates.html.
+
+* platform/gtk/media/media-controls-play-button-updates-expected.txt:
+
+2015-09-24  ChangSeok Oh  <changseok...@collabora.com>
+
 [GTK] playbutton in media controls is not changed when it is clicked.
 https://bugs.webkit.org/show_bug.cgi?id=149113
 


Modified: trunk/LayoutTests/platform/gtk/media/media-controls-play-button-updates-expected.txt (190203 => 190204)

--- trunk/LayoutTests/platform/gtk/media/media-controls-play-button-updates-expected.txt	2015-09-24 15:39:06 UTC (rev 190203)
+++ trunk/LayoutTests/platform/gtk/media/media-controls-play-button-updates-expected.txt	2015-09-24 15:48:41 UTC (rev 190204)
@@ -28,7 +28,6 @@
 RenderBlock {DIV} at (0,200) size 320x40
 layer at (13,254) size 310x30
   RenderFlexibleBox {DIV} at (5,5) size 310x30 [bgcolor=#141414CC]
-RenderButton {BUTTON} at (9,0) size 30x30
 RenderSlider {INPUT} at (49,11) size 93x8 [color=#E6E6E659]
   RenderFlexibleBox {DIV} at (0,0) size 93x8 [border: (1px solid #E6E6E659)]
 RenderBlock {DIV} at (1,-2) size 105x12
@@ -39,3 +38,5 @@
 RenderButton {BUTTON} at (239,0) size 30x30
 RenderFlexibleBox {DIV} at (271,0) size 30x30
   RenderButton {BUTTON} at (0,0) size 30x30
+layer at (22,254) size 30x30
+  RenderButton {BUTTON} at (9,0) size 30x30






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [190160] trunk

[changseok . oh]

Title: [190160] trunk








Revision 190160
Author changseok...@collabora.com
Date 2015-09-23 04:07:15 -0700 (Wed, 23 Sep 2015)


Log Message
[GTK] playbutton in media controls is not changed when it is clicked.
https://bugs.webkit.org/show_bug.cgi?id=149113

Reviewed by Philippe Normand.

Source/WebCore:

When the play button in media controls is clicked, a 'paused' class is added or removed
for the element to update its appearance. Although Document::recalcStyle is triggered
by that class attribute change, the play button is not changed since there is
no difference in styles whether having the 'paused' class or not. Gtk port
does not define the -webkit-media-controls-play-button.paused. To fix this,
-webkit-media-controls-play-button.paused is newly defined with a dummy style,
"position: relative;", which should not change the play button appearance,
but be clearly different in style.

Test: media/media-controls-play-button-updates.html

* css/mediaControlsGtk.css:
(video::-webkit-media-controls-play-button.paused):

LayoutTests:

* media/media-controls-play-button-updates-expected.png: Added.
* media/media-controls-play-button-updates-expected.txt: Added.
* media/media-controls-play-button-updates.html: Added.
* platform/gtk/media/media-controls-play-button-updates-expected.png: Added.
* platform/gtk/media/media-controls-play-button-updates-expected.txt: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/mediaControlsGtk.css


Added Paths

trunk/LayoutTests/media/media-controls-play-button-updates-expected.png
trunk/LayoutTests/media/media-controls-play-button-updates-expected.txt
trunk/LayoutTests/media/media-controls-play-button-updates.html
trunk/LayoutTests/platform/gtk/media/media-controls-play-button-updates-expected.png
trunk/LayoutTests/platform/gtk/media/media-controls-play-button-updates-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (190159 => 190160)

--- trunk/LayoutTests/ChangeLog	2015-09-23 11:03:08 UTC (rev 190159)
+++ trunk/LayoutTests/ChangeLog	2015-09-23 11:07:15 UTC (rev 190160)
@@ -1,3 +1,16 @@
+2015-09-23  ChangSeok Oh  <changseok...@collabora.com>
+
+[GTK] playbutton in media controls is not changed when it is clicked.
+https://bugs.webkit.org/show_bug.cgi?id=149113
+
+Reviewed by Philippe Normand.
+
+* media/media-controls-play-button-updates-expected.png: Added.
+* media/media-controls-play-button-updates-expected.txt: Added.
+* media/media-controls-play-button-updates.html: Added.
+* platform/gtk/media/media-controls-play-button-updates-expected.png: Added.
+* platform/gtk/media/media-controls-play-button-updates-expected.txt: Added.
+
 2015-09-23  Xabier Rodriguez Calvar  <calva...@igalia.com>
 
 [Streams API] Add bad strategies writable streams tests


Added: trunk/LayoutTests/media/media-controls-play-button-updates-expected.png

(Binary files differ)

Property changes on: trunk/LayoutTests/media/media-controls-play-button-updates-expected.png
___

Added: svn:mime-type

Added: trunk/LayoutTests/media/media-controls-play-button-updates-expected.txt (0 => 190160)

--- trunk/LayoutTests/media/media-controls-play-button-updates-expected.txt	(rev 0)
+++ trunk/LayoutTests/media/media-controls-play-button-updates-expected.txt	2015-09-23 11:07:15 UTC (rev 190160)
@@ -0,0 +1,64 @@
+layer at (0,0) size 800x600
+  RenderView at (0,0) size 800x600
+layer at (0,0) size 800x356
+  RenderBlock {HTML} at (0,0) size 800x356
+RenderBody {BODY} at (8,16) size 784x332
+  RenderBlock {P} at (0,0) size 784x18
+RenderText {#text} at (0,0) size 548x18
+  text run at (0,0) width 548: "This tests if media controls play button is properly updated accroding to mouse clicks"
+  RenderBlock (anonymous) at (0,34) size 784x244
+RenderText {#text} at (0,0) size 0x0
+RenderText {#text} at (0,0) size 0x0
+RenderText {#text} at (0,0) size 0x0
+RenderText {#text} at (0,0) size 0x0
+  RenderBlock {DIV} at (0,278) size 784x54
+RenderText {#text} at (0,0) size 163x18
+  text run at (0,0) width 163: "EVENT(canplaythrough)"
+RenderBR {BR} at (162,0) size 1x18
+RenderText {#text} at (0,18) size 112x18
+  text run at (0,18) width 112: "EVENT(playing)"
+RenderBR {BR} at (111,18) size 1x18
+RenderText {#text} at (0,36) size 100x18
+  text run at (0,36) width 100: "EVENT(pause)"
+RenderBR {BR} at (99,36) size 1x18
+layer at (8,50) size 320x240 isolatesBlending
+  RenderVideo {VIDEO} at (0,0) size 320x240
+layer at (8,50) size 320x240
+  RenderFlexibleBox {DIV} at (0,0) size 320x240
+layer at (8,245) size 320x45
+  RenderFlexibleBox {DIV} at (0,195) size 320x45
+layer at (8,245) size 320

[webkit-changes] [190157] trunk/LayoutTests

[changseok . oh]

Title: [190157] trunk/LayoutTests








Revision 190157
Author changseok...@collabora.com
Date 2015-09-23 01:32:59 -0700 (Wed, 23 Sep 2015)


Log Message
[GTK] media/media-controls-timeline-updates.html timeouts
https://bugs.webkit.org/show_bug.cgi?id=139363

Reviewed by Philippe Normand.

The default timeout value of gtk port is 6000ms for release build layout tests.
But this is too short to pass some media tests such as media-controls-timeline-updates.html
Let's tweak the test to have shorter test time by seeking.

* media/media-controls-timeline-updates.html:
* platform/gtk/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/media/media-controls-timeline-updates.html
trunk/LayoutTests/platform/gtk/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (190156 => 190157)

--- trunk/LayoutTests/ChangeLog	2015-09-23 07:33:05 UTC (rev 190156)
+++ trunk/LayoutTests/ChangeLog	2015-09-23 08:32:59 UTC (rev 190157)
@@ -1,3 +1,17 @@
+2015-09-23  ChangSeok Oh  <changseok...@collabora.com>
+
+[GTK] media/media-controls-timeline-updates.html timeouts
+https://bugs.webkit.org/show_bug.cgi?id=139363
+
+Reviewed by Philippe Normand.
+
+The default timeout value of gtk port is 6000ms for release build layout tests.
+But this is too short to pass some media tests such as media-controls-timeline-updates.html
+Let's tweak the test to have shorter test time by seeking.
+
+* media/media-controls-timeline-updates.html:
+* platform/gtk/TestExpectations:
+
 2015-09-23  Youenn Fablet  <youenn.fab...@crf.canon.fr>
 
 [Streams API] Implement ReadableStream pipeThrough


Modified: trunk/LayoutTests/media/media-controls-timeline-updates.html (190156 => 190157)

--- trunk/LayoutTests/media/media-controls-timeline-updates.html	2015-09-23 07:33:05 UTC (rev 190156)
+++ trunk/LayoutTests/media/media-controls-timeline-updates.html	2015-09-23 08:32:59 UTC (rev 190157)
@@ -42,7 +42,10 @@
 
 testExpected("timeLineValue()", 0);
 
-video.play();
+video.addEventListener("seeked", function() {
+video.play();
+});
+video.fastSeek(video.duration - 1);
 }
 
 


Modified: trunk/LayoutTests/platform/gtk/TestExpectations (190156 => 190157)

--- trunk/LayoutTests/platform/gtk/TestExpectations	2015-09-23 07:33:05 UTC (rev 190156)
+++ trunk/LayoutTests/platform/gtk/TestExpectations	2015-09-23 08:32:59 UTC (rev 190157)
@@ -1338,8 +1338,6 @@
 webkit.org/b/139362 inspector/css/selector-specificity.html [ Timeout Pass ]
 webkit.org/b/147229 inspector/css/modify-rule-selector.html [ Skip ] # Timeout
 
-webkit.org/b/139363 media/media-controls-timeline-updates.html [ Timeout ]
-
 webkit.org/b/142292 fast/images/animated-gif-window-resizing.html [ Timeout ]
 webkit.org/b/142292 fast/images/animated-gif-zooming.html [ Timeout ]
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [190053] trunk

[changseok . oh]

Title: [190053] trunk








Revision 190053
Author changseok...@collabora.com
Date 2015-09-21 01:37:25 -0700 (Mon, 21 Sep 2015)


Log Message
[GTK] timeline is not updated after few seconds when mouse hovers on controls
https://bugs.webkit.org/show_bug.cgi?id=149111

Reviewed by Philippe Normand.

Source/WebCore:

Timeline is not updated if controlsAreHidden is true. The problem here is that
the function does not mean actually 'hidden' since it only checkes 'show' and 'hidden'
class existences. The panel's visibility are not only controlled by the two classes,
but also by video::-webkit-media-controls-panel:hover. The panel could be visible
by setting the pseudo hover class. So we need to check if panel is hovered as well in controlsAreHidden().

Test: media/media-controls-timeline-updates-when-hovered.html

* Modules/mediacontrols/mediaControlsBase.js:
(Controller.prototype.controlsAreHidden):

LayoutTests:

* media/media-controls-timeline-updates-when-hovered-expected.txt: Added.
* media/media-controls-timeline-updates-when-hovered.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/mediacontrols/mediaControlsBase.js


Added Paths

trunk/LayoutTests/media/media-controls-timeline-updates-when-hovered-expected.txt
trunk/LayoutTests/media/media-controls-timeline-updates-when-hovered.html




Diff

Modified: trunk/LayoutTests/ChangeLog (190052 => 190053)

--- trunk/LayoutTests/ChangeLog	2015-09-21 08:36:44 UTC (rev 190052)
+++ trunk/LayoutTests/ChangeLog	2015-09-21 08:37:25 UTC (rev 190053)
@@ -1,3 +1,13 @@
+2015-09-21  ChangSeok Oh  <changseok...@collabora.com>
+
+[GTK] timeline is not updated after few seconds when mouse hovers on controls
+https://bugs.webkit.org/show_bug.cgi?id=149111
+
+Reviewed by Philippe Normand.
+
+* media/media-controls-timeline-updates-when-hovered-expected.txt: Added.
+* media/media-controls-timeline-updates-when-hovered.html: Added.
+
 2015-09-20  Andy Estes  <aes...@apple.com>
 
 http/tests/contentfiltering/load-substitute-data-from-appcache.html crashes sometimes


Added: trunk/LayoutTests/media/media-controls-timeline-updates-when-hovered-expected.txt (0 => 190053)

--- trunk/LayoutTests/media/media-controls-timeline-updates-when-hovered-expected.txt	(rev 0)
+++ trunk/LayoutTests/media/media-controls-timeline-updates-when-hovered-expected.txt	2015-09-21 08:37:25 UTC (rev 190053)
@@ -0,0 +1,11 @@
+This tests if media controls timeline is properly updated when a cursor hovers the controls during playback.
+
+
+EVENT(canplaythrough)
+EXPECTED (timeLineValue() == '0') OK
+RUN(video.play())
+EVENT(play)
+EVENT(timeupdate)
+TEST(timeLineValue() >= 1) OK
+END OF TEST
+


Added: trunk/LayoutTests/media/media-controls-timeline-updates-when-hovered.html (0 => 190053)

--- trunk/LayoutTests/media/media-controls-timeline-updates-when-hovered.html	(rev 0)
+++ trunk/LayoutTests/media/media-controls-timeline-updates-when-hovered.html	2015-09-21 08:37:25 UTC (rev 190053)
@@ -0,0 +1,53 @@
+
+This tests if media controls timeline is properly updated when a cursor hovers the controls during playback.
+
+
+function timeLineValue()
+{
+var timeline = mediaControlsElement(internals.shadowRoot(video).firstChild.firstChild, '-webkit-media-controls-timeline');
+if (!timeline)
+throw "Failed to find -webkit-media-controls-timeline";
+
+return timeline.value;
+}
+
+function canplaythrough()
+{
+if (!window.testRunner) {
+endTest();
+return;
+}
+
+testExpected("timeLineValue()", 0);
+
+var playButtonCoords;
+try {
+playButtonCoords = mediaControlsButtonCoordinates(video, "play-button");
+} catch (exception) {
+endTest();
+return;
+}
+eventSender.mouseMoveTo(playButtonCoords[0], playButtonCoords[1]);
+
+video.addEventListener("timeupdate", function() {
+ if (video.currentTime >= 1) {
+consoleWrite("EVENT(timeupdate)");
+test("timeLineValue() >= 1");
+endTest();
+ }
+});
+
+run("video.play()");
+}
+
+var video;
+findMediaElement();
+video.src = "" "content/test");
+
+waitForEvent("canplaythrough", canplaythrough);
+waitForEvent("play");
+waitForEventAndFail("error");
+


Modified: trunk/Source/WebCore/ChangeLog (190052 => 190053)

--- trunk/Source/WebCore/ChangeLog	2015-09-21 08:36:44 UTC (rev 190052)
+++ trunk/Source/WebCore/ChangeLog	2015-09-21 08:37:25 UTC (rev 190053)
@@ -1,3 +1,21 @@
+2015-09-21  ChangSeok Oh  <changseok...@collabora.com>
+
+[GTK] timeline is not updated after few seconds when mouse hovers on controls
+https://bugs.webkit.org/show_bug.cgi?id=149111
+
+Reviewed by Philippe Normand.
+
+   

[webkit-changes] [190054] trunk

[changseok . oh]

Title: [190054] trunk








Revision 190054
Author changseok...@collabora.com
Date 2015-09-21 01:53:01 -0700 (Mon, 21 Sep 2015)


Log Message
[GTK] media controls does not show up when playing video finishes.
https://bugs.webkit.org/show_bug.cgi?id=149112

Reviewed by Philippe Normand.

Source/WebCore:

GTK port does not show controls after playing video. This behavior is different
from what Mac port does. They do show controls when playing video finishes.
At least, we should update the timeline before showing it up not to show incorrect numbers
when reappearing.

Test: media/media-controls-timeline-updates-after-playing.html

* Modules/mediacontrols/mediaControlsBase.js:
(Controller.prototype.setPlaying):
(Controller.prototype.showControls):

LayoutTests:

* media/media-controls-timeline-updates-after-playing-expected.txt: Added.
* media/media-controls-timeline-updates-after-playing.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/mediacontrols/mediaControlsBase.js


Added Paths

trunk/LayoutTests/media/media-controls-timeline-updates-after-playing-expected.txt
trunk/LayoutTests/media/media-controls-timeline-updates-after-playing.html




Diff

Modified: trunk/LayoutTests/ChangeLog (190053 => 190054)

--- trunk/LayoutTests/ChangeLog	2015-09-21 08:37:25 UTC (rev 190053)
+++ trunk/LayoutTests/ChangeLog	2015-09-21 08:53:01 UTC (rev 190054)
@@ -1,5 +1,15 @@
 2015-09-21  ChangSeok Oh  <changseok...@collabora.com>
 
+[GTK] media controls does not show up when playing video finishes.
+https://bugs.webkit.org/show_bug.cgi?id=149112
+
+Reviewed by Philippe Normand.
+
+* media/media-controls-timeline-updates-after-playing-expected.txt: Added.
+* media/media-controls-timeline-updates-after-playing.html: Added.
+
+2015-09-21  ChangSeok Oh  <changseok...@collabora.com>
+
 [GTK] timeline is not updated after few seconds when mouse hovers on controls
 https://bugs.webkit.org/show_bug.cgi?id=149111
 


Added: trunk/LayoutTests/media/media-controls-timeline-updates-after-playing-expected.txt (0 => 190054)

--- trunk/LayoutTests/media/media-controls-timeline-updates-after-playing-expected.txt	(rev 0)
+++ trunk/LayoutTests/media/media-controls-timeline-updates-after-playing-expected.txt	2015-09-21 08:53:01 UTC (rev 190054)
@@ -0,0 +1,13 @@
+This tests if media controls shows up and timeline is accordingly updated after playing the video.
+
+
+EVENT(canplaythrough)
+EXPECTED (timeLineValue() == '0') OK
+RUN(video.fastSeek(video.duration - 1))
+EVENT(seeked)
+RUN(video.play())
+EVENT(play)
+EVENT(pause)
+TEST(Math.floor(video.currentTime * 100) / 100 == timeLineValue()) OK
+END OF TEST
+


Added: trunk/LayoutTests/media/media-controls-timeline-updates-after-playing.html (0 => 190054)

--- trunk/LayoutTests/media/media-controls-timeline-updates-after-playing.html	(rev 0)
+++ trunk/LayoutTests/media/media-controls-timeline-updates-after-playing.html	2015-09-21 08:53:01 UTC (rev 190054)
@@ -0,0 +1,49 @@
+
+This tests if media controls shows up and timeline is accordingly updated after playing the video.
+
+
+function timeLineValue()
+{
+var timeline = mediaControlsElement(internals.shadowRoot(video).firstChild.firstChild, '-webkit-media-controls-timeline');
+if (!timeline)
+throw "Failed to find -webkit-media-controls-timeline";
+
+return timeline.value;
+}
+
+function canplaythrough()
+{
+if (!window.testRunner) {
+endTest();
+return;
+}
+
+testExpected("timeLineValue()", 0);
+run('video.fastSeek(video.duration - 1)');
+}
+
+function seeked()
+{
+run("video.play()");
+}
+
+function paused()
+{
+// timeLineValue returns a two decimal value.
+test("Math.floor(video.currentTime * 100) / 100 == timeLineValue()");
+endTest();
+}
+
+var video;
+findMediaElement();
+video.src = "" "content/test");
+
+waitForEvent("canplaythrough", canplaythrough);
+waitForEvent("seeked", seeked);
+waitForEvent("play");
+waitForEvent("pause", paused);
+waitForEventAndFail("error");
+


Modified: trunk/Source/WebCore/ChangeLog (190053 => 190054)

--- trunk/Source/WebCore/ChangeLog	2015-09-21 08:37:25 UTC (rev 190053)
+++ trunk/Source/WebCore/ChangeLog	2015-09-21 08:53:01 UTC (rev 190054)
@@ -1,5 +1,23 @@
 2015-09-21  ChangSeok Oh  <changseok...@collabora.com>
 
+[GTK] media controls does not show up when playing video finishes.
+https://bugs.webkit.org/show_bug.cgi?id=149112
+
+Reviewed by Philippe Normand.
+
+GTK port does not show controls after playing video. This behavior is different
+from what Mac port does. They do show controls when playing video finishes.
+At least, we should update the timeline before show

[webkit-changes] [189684] trunk/LayoutTests

[changseok . oh]

Title: [189684] trunk/LayoutTests








Revision 189684
Author changseok...@collabora.com
Date 2015-09-14 00:47:41 -0700 (Mon, 14 Sep 2015)


Log Message
[GTK] Layout Test media/video-volume-slider.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=149032

Reviewed by Philippe Normand.

* platform/gtk/TestExpectations: media/video-volume-slider.html is removed.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/gtk/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (189683 => 189684)

--- trunk/LayoutTests/ChangeLog	2015-09-14 07:43:28 UTC (rev 189683)
+++ trunk/LayoutTests/ChangeLog	2015-09-14 07:47:41 UTC (rev 189684)
@@ -1,3 +1,12 @@
+2015-09-14  ChangSeok Oh  <changseok...@collabora.com>
+
+[GTK] Layout Test media/video-volume-slider.html is flaky
+https://bugs.webkit.org/show_bug.cgi?id=149032
+
+Reviewed by Philippe Normand.
+
+* platform/gtk/TestExpectations: media/video-volume-slider.html is removed.
+
 2015-09-13  Chris Dumez  <cdu...@apple.com>
 
 Document.adoptNode() should be able to explicitly adopt a DocumentType node


Modified: trunk/LayoutTests/platform/gtk/TestExpectations (189683 => 189684)

--- trunk/LayoutTests/platform/gtk/TestExpectations	2015-09-14 07:43:28 UTC (rev 189683)
+++ trunk/LayoutTests/platform/gtk/TestExpectations	2015-09-14 07:47:41 UTC (rev 189684)
@@ -552,7 +552,6 @@
 webkit.org/b/142268 editing/pasteboard/copy-paste-attachment.html [ Failure ]
 webkit.org/b/142269 fast/attachment/attachment-dom.html [ Failure ]
 webkit.org/b/142270 fast/canvas/canvas-ellipse-zero-lineto.html [ Failure ]
-webkit.org/b/142142 media/video-volume-slider.html [ Failure ]
 
 webkit.org/b/127109 media/video-object-fit.html [ ImageOnlyFailure ]
 webkit.org/b/142283 fast/regions/overflow/overflow-first-and-last-regions.html [ ImageOnlyFailure ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [189566] trunk

[changseok . oh]

Title: [189566] trunk








Revision 189566
Author changseok...@collabora.com
Date 2015-09-10 02:10:11 -0700 (Thu, 10 Sep 2015)


Log Message
[GTK] Volume bar is broken
https://bugs.webkit.org/show_bug.cgi?id=145639

Reviewed by Philippe Normand.

Source/WebCore:

The ControlPart enum values' order has mismatched the one of values in CSSValueKeywords.in
after r180965. The MediaVolumeSliderPart should be prior to the MediaVolumeSliderContainerpart.

Tests: media/click-volume-bar-not-pausing.html
   media/volume-bar-empty-when-muted.html

* platform/ThemeTypes.h:

LayoutTests:

Unblock relevant tests. media/click-volume-bar-not-pausing.html, media/volume-bar-empty-when-muted.html

* platform/gtk/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/gtk/TestExpectations
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/ThemeTypes.h




Diff

Modified: trunk/LayoutTests/ChangeLog (189565 => 189566)

--- trunk/LayoutTests/ChangeLog	2015-09-10 02:16:22 UTC (rev 189565)
+++ trunk/LayoutTests/ChangeLog	2015-09-10 09:10:11 UTC (rev 189566)
@@ -1,3 +1,14 @@
+2015-09-10  ChangSeok Oh  <changseok...@collabora.com>
+
+[GTK] Volume bar is broken
+https://bugs.webkit.org/show_bug.cgi?id=145639
+
+Reviewed by Philippe Normand.
+
+Unblock relevant tests. media/click-volume-bar-not-pausing.html, media/volume-bar-empty-when-muted.html
+
+* platform/gtk/TestExpectations:
+
 2015-09-09  Dewei Zhu  <dewei_...@apple.com>
 
 Document.characterSet should return "UTF-8" by default.


Modified: trunk/LayoutTests/platform/gtk/TestExpectations (189565 => 189566)

--- trunk/LayoutTests/platform/gtk/TestExpectations	2015-09-10 02:16:22 UTC (rev 189565)
+++ trunk/LayoutTests/platform/gtk/TestExpectations	2015-09-10 09:10:11 UTC (rev 189566)
@@ -1350,7 +1350,6 @@
 webkit.org/b/142491 media/media-source/media-source-stalled-holds-sleep-assertion.html [ Timeout ]
 
 webkit.org/b/142820 fast/images/animated-gif-body-outside-viewport.html [ Timeout Pass ]
-webkit.org/b/142491 media/click-volume-bar-not-pausing.html [ Timeout ]
 webkit.org/b/143473 editing/pasteboard/drag-and-drop-attachment-contenteditable.html [ Timeout ]
 
 webkit.org/b/143477 fast/writing-mode/broken-ideograph-small-caps.html [ Timeout Pass ]
@@ -2234,8 +2233,6 @@
 
 webkit.org/b/132235 fast/shapes/shape-outside-floats/shape-outside-floats-shape-margin-percent.html [ ImageOnlyFailure ]
 
-webkit.org/b/132253 media/volume-bar-empty-when-muted.html [ Failure ]
-
 webkit.org/b/132910 editing/pasteboard/drag-drop-paragraph-crasher.html [ Failure ]
 
 webkit.org/b/132914 http/tests/security/drag-drop-local-file.html [ Failure ]


Modified: trunk/Source/WebCore/ChangeLog (189565 => 189566)

--- trunk/Source/WebCore/ChangeLog	2015-09-10 02:16:22 UTC (rev 189565)
+++ trunk/Source/WebCore/ChangeLog	2015-09-10 09:10:11 UTC (rev 189566)
@@ -1,3 +1,18 @@
+2015-09-10  ChangSeok Oh  <changseok...@collabora.com>
+
+[GTK] Volume bar is broken
+https://bugs.webkit.org/show_bug.cgi?id=145639
+
+Reviewed by Philippe Normand.
+
+The ControlPart enum values' order has mismatched the one of values in CSSValueKeywords.in
+after r180965. The MediaVolumeSliderPart should be prior to the MediaVolumeSliderContainerpart.
+
+Tests: media/click-volume-bar-not-pausing.html
+   media/volume-bar-empty-when-muted.html
+
+* platform/ThemeTypes.h:
+
 2015-09-09  Gyuyoung Kim  <gyuyoung@webkit.org>
 
 Remove all uses of PassRefPtr in WebCore/svg


Modified: trunk/Source/WebCore/platform/ThemeTypes.h (189565 => 189566)

--- trunk/Source/WebCore/platform/ThemeTypes.h	2015-09-10 02:16:22 UTC (rev 189565)
+++ trunk/Source/WebCore/platform/ThemeTypes.h	2015-09-10 09:10:11 UTC (rev 189566)
@@ -38,8 +38,8 @@
 MediaFullScreenVolumeSliderThumbPart, MediaMuteButtonPart, MediaOverlayPlayButtonPart,
 MediaPlayButtonPart, MediaReturnToRealtimeButtonPart, MediaRewindButtonPart, MediaSeekBackButtonPart,
 MediaSeekForwardButtonPart, MediaSliderPart, MediaSliderThumbPart, MediaTimeRemainingPart,
-MediaToggleClosedCaptionsButtonPart, MediaVolumeSliderContainerPart, MediaVolumeSliderMuteButtonPart,
-MediaVolumeSliderPart, MediaVolumeSliderThumbPart,
+MediaToggleClosedCaptionsButtonPart, MediaVolumeSliderPart, MediaVolumeSliderContainerPart,
+MediaVolumeSliderMuteButtonPart, MediaVolumeSliderThumbPart,
 MenulistPart, MenulistButtonPart, MenulistTextPart, MenulistTextFieldPart, MeterPart, ProgressBarPart, ProgressBarValuePart,
 SliderHorizontalPart, SliderVerticalPart, SliderThumbHorizontalPart,
 SliderThumbVerticalPart, CaretPart, SearchFieldPart, SearchFieldDecorationPart,






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [186835] trunk/Source/WebKit2

[changseok . oh]

Title: [186835] trunk/Source/WebKit2








Revision 186835
Author changseok...@collabora.com
Date 2015-07-15 06:34:19 -0700 (Wed, 15 Jul 2015)


Log Message
[GTK] Accelerated compositing is enabled by MiniBrowser in Wayland
https://bugs.webkit.org/show_bug.cgi?id=146827

Reviewed by Žan Doberšek.

WebKit2Gtk+ does not currently support accelerated compositing. For the reason,
we forcedly disable it in webkitWebViewBaseCreateWebPage. However, when we launch
MiniBrowser in wayland, the unsupported feature is re-enabled since the existing
setting is overwritten by a newly created one. Here the default value for
accelerated compositing is true. We can fix this by moving the code disabling
accelerated composition to WebPreferences::platformInitializeStore() so that
we make sure the accelerated compositing is always disabled for wayland.

* UIProcess/API/gtk/WebKitWebViewBase.cpp:
(webkitWebViewBaseCreateWebPage): Deleted.
* UIProcess/gtk/WebPreferencesGtk.cpp:
(WebKit::WebPreferences::platformInitializeStore):

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebViewBase.cpp
trunk/Source/WebKit2/UIProcess/gtk/WebPreferencesGtk.cpp




Diff

Modified: trunk/Source/WebKit2/ChangeLog (186834 => 186835)

--- trunk/Source/WebKit2/ChangeLog	2015-07-15 08:33:31 UTC (rev 186834)
+++ trunk/Source/WebKit2/ChangeLog	2015-07-15 13:34:19 UTC (rev 186835)
@@ -1,3 +1,23 @@
+2015-07-15  ChangSeok Oh  changseok...@collabora.com
+
+[GTK] Accelerated compositing is enabled by MiniBrowser in Wayland
+https://bugs.webkit.org/show_bug.cgi?id=146827
+
+Reviewed by Žan Doberšek.
+
+WebKit2Gtk+ does not currently support accelerated compositing. For the reason,
+we forcedly disable it in webkitWebViewBaseCreateWebPage. However, when we launch
+MiniBrowser in wayland, the unsupported feature is re-enabled since the existing
+setting is overwritten by a newly created one. Here the default value for
+accelerated compositing is true. We can fix this by moving the code disabling
+accelerated composition to WebPreferences::platformInitializeStore() so that
+we make sure the accelerated compositing is always disabled for wayland.
+
+* UIProcess/API/gtk/WebKitWebViewBase.cpp:
+(webkitWebViewBaseCreateWebPage): Deleted.
+* UIProcess/gtk/WebPreferencesGtk.cpp:
+(WebKit::WebPreferences::platformInitializeStore):
+
 2015-07-15  Dan Bernstein  m...@apple.com
 
 Fixed build fix.


Modified: trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebViewBase.cpp (186834 => 186835)

--- trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebViewBase.cpp	2015-07-15 08:33:31 UTC (rev 186834)
+++ trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebViewBase.cpp	2015-07-15 13:34:19 UTC (rev 186835)
@@ -1073,14 +1073,6 @@
 void webkitWebViewBaseCreateWebPage(WebKitWebViewBase* webkitWebViewBase, WebProcessPool* context, WebPageConfiguration configuration)
 {
 WebKitWebViewBasePrivate* priv = webkitWebViewBase-priv;
-
-#if PLATFORM(WAYLAND)
-// FIXME: Accelerated compositing under Wayland is not yet supported.
-// https://bugs.webkit.org/show_bug.cgi?id=115803
-if (PlatformDisplay::sharedDisplay().type() == PlatformDisplay::Type::Wayland)
-configuration.preferences-setAcceleratedCompositingEnabled(false);
-#endif
-
 priv-pageProxy = context-createWebPage(*priv-pageClient, WTF::move(configuration));
 priv-pageProxy-initializeWebPage();
 


Modified: trunk/Source/WebKit2/UIProcess/gtk/WebPreferencesGtk.cpp (186834 => 186835)

--- trunk/Source/WebKit2/UIProcess/gtk/WebPreferencesGtk.cpp	2015-07-15 08:33:31 UTC (rev 186834)
+++ trunk/Source/WebKit2/UIProcess/gtk/WebPreferencesGtk.cpp	2015-07-15 13:34:19 UTC (rev 186835)
@@ -28,12 +28,18 @@
 #include WebPreferences.h
 
 #include WebCore/NotImplemented.h
+#include WebCore/PlatformDisplay.h
 
 namespace WebKit {
 
 void WebPreferences::platformInitializeStore()
 {
-notImplemented();
+#if PLATFORM(WAYLAND)
+// FIXME: Accelerated compositing under Wayland is not yet supported.
+// https://bugs.webkit.org/show_bug.cgi?id=115803
+if (WebCore::PlatformDisplay::sharedDisplay().type() == WebCore::PlatformDisplay::Type::Wayland)
+setAcceleratedCompositingEnabled(false);
+#endif
 }
 
 void WebPreferences::platformUpdateStringValueForKey(const String, const String)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [182546] trunk

[changseok . oh]

Title: [182546] trunk








Revision 182546
Author changseok...@collabora.com
Date 2015-04-08 10:14:07 -0700 (Wed, 08 Apr 2015)


Log Message
Fill list style background with same color with that of list background.
https://bugs.webkit.org/show_bug.cgi?id=143483

Reviewed by Simon Fraser.

Source/WebCore:

LayoutListMarker does not have a node so its selectionBackgroundColor alway returns
the default theme color for selection. We can make it more natural by filling
the same color with that of LayoutListItem into it.

Tests: fast/backgrounds/selection-background-color-of-image-list-style.html
   fast/backgrounds/selection-background-color-of-list-style.html

* rendering/RenderListMarker.cpp:
(WebCore::RenderListMarker::paint):

LayoutTests:

* fast/backgrounds/selection-background-color-of-image-list-style.html: Added.
* fast/backgrounds/selection-background-color-of-list-style.html: Added.
* platform/gtk/fast/backgrounds/selection-background-color-of-image-list-style-expected.png: Added.
* platform/gtk/fast/backgrounds/selection-background-color-of-image-list-style-expected.txt: Added.
* platform/gtk/fast/backgrounds/selection-background-color-of-list-style-expected.png: Added.
* platform/gtk/fast/backgrounds/selection-background-color-of-list-style-expected.txt: Added.
* platform/mac/fast/backgrounds/selection-background-color-of-image-list-style-expected.png: Added.
* platform/mac/fast/backgrounds/selection-background-color-of-image-list-style-expected.txt: Added.
* platform/mac/fast/backgrounds/selection-background-color-of-list-style-expected.png: Added.
* platform/mac/fast/backgrounds/selection-background-color-of-list-style-expected.txt: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderListMarker.cpp


Added Paths

trunk/LayoutTests/fast/backgrounds/selection-background-color-of-image-list-style.html
trunk/LayoutTests/fast/backgrounds/selection-background-color-of-list-style.html
trunk/LayoutTests/platform/gtk/fast/backgrounds/selection-background-color-of-image-list-style-expected.png
trunk/LayoutTests/platform/gtk/fast/backgrounds/selection-background-color-of-image-list-style-expected.txt
trunk/LayoutTests/platform/gtk/fast/backgrounds/selection-background-color-of-list-style-expected.png
trunk/LayoutTests/platform/gtk/fast/backgrounds/selection-background-color-of-list-style-expected.txt
trunk/LayoutTests/platform/mac/fast/backgrounds/selection-background-color-of-image-list-style-expected.png
trunk/LayoutTests/platform/mac/fast/backgrounds/selection-background-color-of-image-list-style-expected.txt
trunk/LayoutTests/platform/mac/fast/backgrounds/selection-background-color-of-list-style-expected.png
trunk/LayoutTests/platform/mac/fast/backgrounds/selection-background-color-of-list-style-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (182545 => 182546)

--- trunk/LayoutTests/ChangeLog	2015-04-08 16:47:56 UTC (rev 182545)
+++ trunk/LayoutTests/ChangeLog	2015-04-08 17:14:07 UTC (rev 182546)
@@ -1,3 +1,21 @@
+2015-04-08  ChangSeok Oh  changseok...@collabora.com
+
+Fill list style background with same color with that of list background.
+https://bugs.webkit.org/show_bug.cgi?id=143483
+
+Reviewed by Simon Fraser.
+
+* fast/backgrounds/selection-background-color-of-image-list-style.html: Added.
+* fast/backgrounds/selection-background-color-of-list-style.html: Added.
+* platform/gtk/fast/backgrounds/selection-background-color-of-image-list-style-expected.png: Added.
+* platform/gtk/fast/backgrounds/selection-background-color-of-image-list-style-expected.txt: Added.
+* platform/gtk/fast/backgrounds/selection-background-color-of-list-style-expected.png: Added.
+* platform/gtk/fast/backgrounds/selection-background-color-of-list-style-expected.txt: Added.
+* platform/mac/fast/backgrounds/selection-background-color-of-image-list-style-expected.png: Added.
+* platform/mac/fast/backgrounds/selection-background-color-of-image-list-style-expected.txt: Added.
+* platform/mac/fast/backgrounds/selection-background-color-of-list-style-expected.png: Added.
+* platform/mac/fast/backgrounds/selection-background-color-of-list-style-expected.txt: Added.
+
 2015-04-08  Commit Queue  commit-qu...@webkit.org
 
 Unreviewed, rolling out r182536.


Added: trunk/LayoutTests/fast/backgrounds/selection-background-color-of-image-list-style.html (0 => 182546)

--- trunk/LayoutTests/fast/backgrounds/selection-background-color-of-image-list-style.html	(rev 0)
+++ trunk/LayoutTests/fast/backgrounds/selection-background-color-of-image-list-style.html	2015-04-08 17:14:07 UTC (rev 182546)
@@ -0,0 +1,17 @@
+!DOCTYPE html
+style
+ul { list-style-image: url('./resources/diamond.png'); }
+ulli::selection { background: yellow; }
+/style
+div
+  Test pass if background of image list style in ul is yellow.

[webkit-changes] [180213] trunk/Source/WebCore

[changseok . oh]

Title: [180213] trunk/Source/WebCore








Revision 180213
Author changseok...@collabora.com
Date 2015-02-17 01:42:13 -0800 (Tue, 17 Feb 2015)


Log Message
REGRESSION(r180050): It broke the !ENABLE(CSS_GRID_LAYOUT) build
https://bugs.webkit.org/show_bug.cgi?id=141647

Reviewed by Csaba Osztrogonác.

No new tests since this just fixes a build break.

* dom/Position.cpp: Add a build guard ENABLE(CSS_GRID_LAYOUT) for RenderGrid.
(WebCore::Position::isCandidate):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/Position.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (180212 => 180213)

--- trunk/Source/WebCore/ChangeLog	2015-02-17 08:58:41 UTC (rev 180212)
+++ trunk/Source/WebCore/ChangeLog	2015-02-17 09:42:13 UTC (rev 180213)
@@ -1,3 +1,15 @@
+2015-02-17  ChangSeok Oh  changseok...@collabora.com
+
+REGRESSION(r180050): It broke the !ENABLE(CSS_GRID_LAYOUT) build
+https://bugs.webkit.org/show_bug.cgi?id=141647
+
+Reviewed by Csaba Osztrogonác.
+
+No new tests since this just fixes a build break.
+
+* dom/Position.cpp: Add a build guard ENABLE(CSS_GRID_LAYOUT) for RenderGrid.
+(WebCore::Position::isCandidate):
+
 2015-02-16  Chris Dumez  cdu...@apple.com
 
 Keep all memory cache resources in ListHashSets


Modified: trunk/Source/WebCore/dom/Position.cpp (180212 => 180213)

--- trunk/Source/WebCore/dom/Position.cpp	2015-02-17 08:58:41 UTC (rev 180212)
+++ trunk/Source/WebCore/dom/Position.cpp	2015-02-17 09:42:13 UTC (rev 180213)
@@ -50,7 +50,7 @@
 #include stdio.h
 #include wtf/text/CString.h
 #include wtf/unicode/CharacterNames.h
-  
+
 namespace WebCore {
 
 using namespace HTMLNames;
@@ -937,7 +937,11 @@
 if (m_anchorNode-hasTagName(htmlTag))
 return false;
 
-if (isRenderBlockFlow(*renderer) || isRenderFlexibleBox(*renderer) || isRenderGrid(*renderer)) {
+if (isRenderBlockFlow(*renderer)
+#if ENABLE(CSS_GRID_LAYOUT)
+|| isRenderGrid(*renderer)
+#endif
+|| isRenderFlexibleBox(*renderer)) {
 RenderBlock block = downcastRenderBlock(*renderer);
 if (block.logicalHeight() || m_anchorNode-hasTagName(bodyTag)) {
 if (!Position::hasRenderedNonAnonymousDescendantsWithHeight(block))






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [180050] trunk

[changseok . oh]

Title: [180050] trunk








Revision 180050
Author changseok...@collabora.com
Date 2015-02-13 09:15:50 -0800 (Fri, 13 Feb 2015)


Log Message
Div having contentEditable and display:grid cannot be edited if it is empty.
https://bugs.webkit.org/show_bug.cgi?id=141465

Reviewed by Ryosuke Niwa.

Source/WebCore:

This bug is quite similar to webkit.org/b/141218. RenderGrid should be also treated as a candidate
for visible position as like RenderFlexibleBox. The only different situation between them is
that RenderGrid has a bug setting 0px for logicalHeight when it is empty. RenderGrid should also have
a minimum height of a single line if it is editable as well as RenderFlexibleBox does.

Test: fast/events/key-events-in-editable-gridbox.html

* dom/Position.cpp:
(WebCore::Position::isCandidate):
(WebCore::Position::isRenderedCharacter):
* rendering/RenderGrid.cpp:
(WebCore::RenderGrid::layoutGridItems):

LayoutTests:

This tests if an editable grid box can be reedited after erasing all texts in it.

* fast/events/key-events-in-editable-gridbox-expected.txt: Added.
* fast/events/key-events-in-editable-gridbox.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/Position.cpp
trunk/Source/WebCore/rendering/RenderGrid.cpp


Added Paths

trunk/LayoutTests/fast/events/key-events-in-editable-gridbox-expected.txt
trunk/LayoutTests/fast/events/key-events-in-editable-gridbox.html




Diff

Modified: trunk/LayoutTests/ChangeLog (180049 => 180050)

--- trunk/LayoutTests/ChangeLog	2015-02-13 17:10:35 UTC (rev 180049)
+++ trunk/LayoutTests/ChangeLog	2015-02-13 17:15:50 UTC (rev 180050)
@@ -1,3 +1,15 @@
+2015-02-13  ChangSeok Oh  changseok...@collabora.com
+
+Div having contentEditable and display:grid cannot be edited if it is empty.
+https://bugs.webkit.org/show_bug.cgi?id=141465
+
+Reviewed by Ryosuke Niwa.
+
+This tests if an editable grid box can be reedited after erasing all texts in it.
+
+* fast/events/key-events-in-editable-gridbox-expected.txt: Added.
+* fast/events/key-events-in-editable-gridbox.html: Added.
+
 2015-02-13  Brent Fulgham  bfulg...@apple.com
 
 [Win] Skip accessibility tests failing due to debug assertions.


Added: trunk/LayoutTests/fast/events/key-events-in-editable-gridbox-expected.txt (0 => 180050)

--- trunk/LayoutTests/fast/events/key-events-in-editable-gridbox-expected.txt	(rev 0)
+++ trunk/LayoutTests/fast/events/key-events-in-editable-gridbox-expected.txt	2015-02-13 17:15:50 UTC (rev 180050)
@@ -0,0 +1,7 @@
+PASS targetDiv.innerText is TEST
+PASS targetDiv.innerText is 
+PASS targetDiv.innerText is TEST
+PASS successfullyParsed is true
+
+TEST COMPLETE
+TEST


Added: trunk/LayoutTests/fast/events/key-events-in-editable-gridbox.html (0 => 180050)

--- trunk/LayoutTests/fast/events/key-events-in-editable-gridbox.html	(rev 0)
+++ trunk/LayoutTests/fast/events/key-events-in-editable-gridbox.html	2015-02-13 17:15:50 UTC (rev 180050)
@@ -0,0 +1,38 @@
+!DOCTYPE html
+html
+head
+script src=""
+style
+#target {
+display: -webkit-grid;
+}
+/style
+script
+var targetDiv;
+function test()
+{
+targetDiv = document.getElementById('target');
+targetDiv.focus();
+
+// Move cursor to the end of line.
+getSelection().modify('move', 'forward', 'lineboundary');
+
+document.execCommand(insertText, false, EST);
+shouldBeEqualToString(targetDiv.innerText, TEST);
+
+document.execCommand(delete);
+document.execCommand(delete);
+document.execCommand(delete);
+document.execCommand(delete);
+document.execCommand(delete); // Remove '\n'
+shouldBeEmptyString(targetDiv.innerText);
+
+document.execCommand(insertText, false, TEST);
+shouldBeEqualToString(targetDiv.innerText, TEST);
+}
+/script
+/head
+body _onload_=test()
+div id=target contentEditableT/div
+/body
+/html


Modified: trunk/Source/WebCore/ChangeLog (180049 => 180050)

--- trunk/Source/WebCore/ChangeLog	2015-02-13 17:10:35 UTC (rev 180049)
+++ trunk/Source/WebCore/ChangeLog	2015-02-13 17:15:50 UTC (rev 180050)
@@ -1,3 +1,23 @@
+2015-02-13  ChangSeok Oh  changseok...@collabora.com
+
+Div having contentEditable and display:grid cannot be edited if it is empty.
+https://bugs.webkit.org/show_bug.cgi?id=141465
+
+Reviewed by Ryosuke Niwa.
+
+This bug is quite similar to webkit.org/b/141218. RenderGrid should be also treated as a candidate
+for visible position as like RenderFlexibleBox. The only different situation between them is
+that RenderGrid has a bug setting 0px for logicalHeight when it is empty. RenderGrid should also have
+a minimum height of a single line if it is editable as well as RenderFlexibleBox does.
+
+Test: fast/events/key-events-in-editable-gridbox

[webkit-changes] [179942] trunk/Source

[changseok . oh]

Title: [179942] trunk/Source








Revision 179942
Author changseok...@collabora.com
Date 2015-02-11 12:09:13 -0800 (Wed, 11 Feb 2015)


Log Message
Activate ReliefLogger of a memory pressure handler for linux system.
https://bugs.webkit.org/show_bug.cgi?id=123611

Reviewed by Anders Carlsson.

Source/WebCore:

Put more logs for the time when a system goes under memory pressure or viceversa.

No new tests since no engine behavior changed.

* platform/linux/MemoryPressureHandlerLinux.cpp:
(WebCore::MemoryPressureHandler::waitForMemoryPressureEvent): Wait a memory pressure event
from cgroup in a seperated thread. Once a pressure event happens, respondToMemoryPressure()
would be called to get back some resources.
(WebCore::MemoryPressureHandler::install): Install memoryPressureHandler module
to make it work.

Source/WebKit2:

* Shared/WebProcessCreationParameters.cpp:
(WebKit::WebProcessCreationParameters::WebProcessCreationParameters):
Make the parameter, shouldEnableMemoryPressureReliefLogging shareable with COCOA else systems.
(WebKit::WebProcessCreationParameters::encode): ditto.
(WebKit::WebProcessCreationParameters::decode): ditto.
* Shared/WebProcessCreationParameters.h:
* UIProcess/WebProcessPool.cpp:
(WebKit::WebProcessPool::createNewWebProcess): Set shouldEnableMemoryPressureReliefLogging
to true for linux system.
* WebProcess/WebProcess.cpp:
(WebKit::WebProcess::initializeWebProcess): Pass the shouldEnableMemoryPressureReliefLogging value
to MemoryPressureHandler::ReliefLogger::setLoggingEnabled().

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/linux/MemoryPressureHandlerLinux.cpp
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/Shared/WebProcessCreationParameters.cpp
trunk/Source/WebKit2/Shared/WebProcessCreationParameters.h
trunk/Source/WebKit2/UIProcess/WebProcessPool.cpp
trunk/Source/WebKit2/WebProcess/WebProcess.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (179941 => 179942)

--- trunk/Source/WebCore/ChangeLog	2015-02-11 19:44:07 UTC (rev 179941)
+++ trunk/Source/WebCore/ChangeLog	2015-02-11 20:09:13 UTC (rev 179942)
@@ -1,3 +1,21 @@
+2015-02-11  ChangSeok Oh  changseok...@collabora.com
+
+Activate ReliefLogger of a memory pressure handler for linux system.
+https://bugs.webkit.org/show_bug.cgi?id=123611
+
+Reviewed by Anders Carlsson.
+
+Put more logs for the time when a system goes under memory pressure or viceversa.
+
+No new tests since no engine behavior changed.
+
+* platform/linux/MemoryPressureHandlerLinux.cpp:
+(WebCore::MemoryPressureHandler::waitForMemoryPressureEvent): Wait a memory pressure event
+from cgroup in a seperated thread. Once a pressure event happens, respondToMemoryPressure()
+would be called to get back some resources.
+(WebCore::MemoryPressureHandler::install): Install memoryPressureHandler module
+to make it work.
+
 2015-02-11  Alex Christensen  achristen...@webkit.org
 
 Final preparations to switch to WEBCORE_EXPORT.


Modified: trunk/Source/WebCore/platform/linux/MemoryPressureHandlerLinux.cpp (179941 => 179942)

--- trunk/Source/WebCore/platform/linux/MemoryPressureHandlerLinux.cpp	2015-02-11 19:44:07 UTC (rev 179941)
+++ trunk/Source/WebCore/platform/linux/MemoryPressureHandlerLinux.cpp	2015-02-11 20:09:13 UTC (rev 179942)
@@ -97,9 +97,16 @@
 return;
 }
 
-memoryPressureHandler().m_underMemoryPressure = true;
-callOnMainThread([] {
-memoryPressureHandler().respondToMemoryPressure(true);
+// FIXME: Current memcg does not provide any way for users to know how serious the memory pressure is.
+// So we assume all notifications from memcg are critical for now. If memcg had better inferfaces
+// to get a detailed memory pressure level in the future, we should update here accordingly.
+bool critical = true;
+if (ReliefLogger::loggingEnabled())
+LOG(MemoryPressure, Got memory pressure notification (%s), critical ? critical : non-critical);
+
+memoryPressureHandler().setUnderMemoryPressure(critical);
+callOnMainThread([critical] {
+memoryPressureHandler().respondToMemoryPressure(critical);
 });
 }
 
@@ -156,7 +163,10 @@
 return;
 }
 
-m_underMemoryPressure = false;
+if (ReliefLogger::loggingEnabled()  isUnderMemoryPressure())
+LOG(MemoryPressure, System is no longer under memory pressure.);
+
+setUnderMemoryPressure(false);
 m_installed = true;
 }
 


Modified: trunk/Source/WebKit2/ChangeLog (179941 => 179942)

--- trunk/Source/WebKit2/ChangeLog	2015-02-11 19:44:07 UTC (rev 179941)
+++ trunk/Source/WebKit2/ChangeLog	2015-02-11 20:09:13 UTC (rev 179942)
@@ -1,3 +1,23 @@
+2015-02-11  ChangSeok Oh  changseok...@collabora.com
+
+Activate ReliefLogger of a memory pressure handler for linux system.
+https://bugs.webkit.org/show_bug.cgi?id=123611
+
+Reviewed by Anders Carlsson.
+
+   

[webkit-changes] [179944] trunk

[changseok . oh]

Title: [179944] trunk








Revision 179944
Author changseok...@collabora.com
Date 2015-02-11 12:13:03 -0800 (Wed, 11 Feb 2015)


Log Message
Div having contentEditable and display:flex cannot be edited if it is empty.
https://bugs.webkit.org/show_bug.cgi?id=141218

Reviewed by Ryosuke Niwa.

Source/WebCore:

RenderFlexibleBox should be treated as a candidate for visible position. Visible selection
in an editable area is recalculated whenever an inner value of div is changed. If the inner value
is empty, the visible selection recalculated with DeleteSelectionCommand::m_endingPostion
is not correct. Because RenderBlockFlow is only considered but not RenderFlexibleBox
in Position::isCandidate so that a calculated ending VisiblePosition for an editable div
having display : flex goes weird and VisibleSelection is empty accordingly.

Test: fast/events/key-events-in-editable-flexbox.html

* dom/Position.cpp:
(WebCore::Position::isCandidate):

LayoutTests:

This tests if an editable flexbox can be reedited after erasing all texts in it.

* fast/events/key-events-in-editable-flexbox-expected.txt: Added.
* fast/events/key-events-in-editable-flexbox.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/Position.cpp


Added Paths

trunk/LayoutTests/fast/events/key-events-in-editable-flexbox-expected.txt
trunk/LayoutTests/fast/events/key-events-in-editable-flexbox.html




Diff

Modified: trunk/LayoutTests/ChangeLog (179943 => 179944)

--- trunk/LayoutTests/ChangeLog	2015-02-11 20:12:36 UTC (rev 179943)
+++ trunk/LayoutTests/ChangeLog	2015-02-11 20:13:03 UTC (rev 179944)
@@ -1,3 +1,15 @@
+2015-02-11  ChangSeok Oh  changseok...@collabora.com
+
+Div having contentEditable and display:flex cannot be edited if it is empty.
+https://bugs.webkit.org/show_bug.cgi?id=141218
+
+Reviewed by Ryosuke Niwa.
+
+This tests if an editable flexbox can be reedited after erasing all texts in it.
+
+* fast/events/key-events-in-editable-flexbox-expected.txt: Added.
+* fast/events/key-events-in-editable-flexbox.html: Added.
+
 2015-02-11  Sam Weinig  s...@webkit.org
 
 performance.now can crash if accessed from a window that has navigated


Added: trunk/LayoutTests/fast/events/key-events-in-editable-flexbox-expected.txt (0 => 179944)

--- trunk/LayoutTests/fast/events/key-events-in-editable-flexbox-expected.txt	(rev 0)
+++ trunk/LayoutTests/fast/events/key-events-in-editable-flexbox-expected.txt	2015-02-11 20:13:03 UTC (rev 179944)
@@ -0,0 +1,7 @@
+PASS targetDiv.innerText is TEST
+PASS targetDiv.innerText is 
+PASS targetDiv.innerText is TEST
+PASS successfullyParsed is true
+
+TEST COMPLETE
+TEST


Added: trunk/LayoutTests/fast/events/key-events-in-editable-flexbox.html (0 => 179944)

--- trunk/LayoutTests/fast/events/key-events-in-editable-flexbox.html	(rev 0)
+++ trunk/LayoutTests/fast/events/key-events-in-editable-flexbox.html	2015-02-11 20:13:03 UTC (rev 179944)
@@ -0,0 +1,39 @@
+!DOCTYPE html
+html
+head
+script src=""
+style
+#target {
+display: flex;
+display: -webkit-flex;
+}
+/style
+script
+var targetDiv;
+function test()
+{
+targetDiv = document.getElementById('target');
+targetDiv.focus();
+
+// Move cursor to the end of line.
+getSelection().modify('move', 'forward', 'lineboundary');
+
+document.execCommand(insertText, false, EST);
+shouldBeEqualToString(targetDiv.innerText, TEST);
+
+document.execCommand(delete);
+document.execCommand(delete);
+document.execCommand(delete);
+document.execCommand(delete);
+document.execCommand(delete); // Remove '\n'
+shouldBeEmptyString(targetDiv.innerText);
+
+document.execCommand(insertText, false, TEST);
+shouldBeEqualToString(targetDiv.innerText, TEST);
+}
+/script
+/head
+body _onload_=test()
+div id=target contentEditableT/div
+/body
+/html


Modified: trunk/Source/WebCore/ChangeLog (179943 => 179944)

--- trunk/Source/WebCore/ChangeLog	2015-02-11 20:12:36 UTC (rev 179943)
+++ trunk/Source/WebCore/ChangeLog	2015-02-11 20:13:03 UTC (rev 179944)
@@ -1,5 +1,24 @@
 2015-02-11  ChangSeok Oh  changseok...@collabora.com
 
+Div having contentEditable and display:flex cannot be edited if it is empty.
+https://bugs.webkit.org/show_bug.cgi?id=141218
+
+Reviewed by Ryosuke Niwa.
+
+RenderFlexibleBox should be treated as a candidate for visible position. Visible selection
+in an editable area is recalculated whenever an inner value of div is changed. If the inner value
+is empty, the visible selection recalculated with DeleteSelectionCommand::m_endingPostion
+is not correct. Because RenderBlockFlow is only considered but not RenderFlexibleBox
+in Position::isCandidate so that a calculated 

[webkit-changes] [179921] trunk

[changseok . oh]

Title: [179921] trunk








Revision 179921
Author changseok...@collabora.com
Date 2015-02-11 00:51:55 -0800 (Wed, 11 Feb 2015)


Log Message
Div having contentEditable and display:flex cannot be edited if it is empty.
https://bugs.webkit.org/show_bug.cgi?id=141218

Reviewed by Ryosuke Niwa.

Source/WebCore:

RenderFlexibleBox should be treated as a candidate for visible position. Visible selection
in an editable area is recalculated whenever an inner value of div is changed. If the inner value
is empty, the visible selection recalculated with DeleteSelectionCommand::m_endingPostion
is not correct. Because RenderBlockFlow is only considered but not RenderFlexibleBox
in Position::isCandidate so that a calculated ending VisiblePosition for an editable div
having display : flex goes weird and VisibleSelection is empty accordingly.

Test: fast/events/key-events-in-editable-flexbox.html

* dom/Position.cpp:
(WebCore::Position::isCandidate):

LayoutTests:

This tests if an editable flexbox can be reedited after erasing all texts in it.

* fast/events/key-events-in-editable-flexbox-expected.txt: Added.
* fast/events/key-events-in-editable-flexbox.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/Position.cpp


Added Paths

trunk/LayoutTests/fast/events/key-events-in-editable-flexbox-expected.txt
trunk/LayoutTests/fast/events/key-events-in-editable-flexbox.html




Diff

Modified: trunk/LayoutTests/ChangeLog (179920 => 179921)

--- trunk/LayoutTests/ChangeLog	2015-02-11 08:36:22 UTC (rev 179920)
+++ trunk/LayoutTests/ChangeLog	2015-02-11 08:51:55 UTC (rev 179921)
@@ -1,3 +1,15 @@
+2015-02-11  ChangSeok Oh  changseok...@collabora.com
+
+Div having contentEditable and display:flex cannot be edited if it is empty.
+https://bugs.webkit.org/show_bug.cgi?id=141218
+
+Reviewed by Ryosuke Niwa.
+
+This tests if an editable flexbox can be reedited after erasing all texts in it.
+
+* fast/events/key-events-in-editable-flexbox-expected.txt: Added.
+* fast/events/key-events-in-editable-flexbox.html: Added.
+
 2015-02-11  Dana Burkart  dburk...@apple.com
 
 http/tests/cache/disk-cache-validation.html generates a lot of Perl errors


Added: trunk/LayoutTests/fast/events/key-events-in-editable-flexbox-expected.txt (0 => 179921)

--- trunk/LayoutTests/fast/events/key-events-in-editable-flexbox-expected.txt	(rev 0)
+++ trunk/LayoutTests/fast/events/key-events-in-editable-flexbox-expected.txt	2015-02-11 08:51:55 UTC (rev 179921)
@@ -0,0 +1,7 @@
+PASS targetDiv.innerText is TEST
+PASS targetDiv.innerText is 
+PASS targetDiv.innerText is TEST
+PASS successfullyParsed is true
+
+TEST COMPLETE
+TEST


Added: trunk/LayoutTests/fast/events/key-events-in-editable-flexbox.html (0 => 179921)

--- trunk/LayoutTests/fast/events/key-events-in-editable-flexbox.html	(rev 0)
+++ trunk/LayoutTests/fast/events/key-events-in-editable-flexbox.html	2015-02-11 08:51:55 UTC (rev 179921)
@@ -0,0 +1,39 @@
+!DOCTYPE html
+html
+head
+script src=""
+style
+#target {
+display: flex;
+display: -webkit-flex;
+}
+/style
+script
+var targetDiv;
+function test()
+{
+targetDiv = document.getElementById('target');
+targetDiv.focus();
+
+// Move cursor to the end of line.
+getSelection().modify('move', 'forward', 'lineboundary');
+
+document.execCommand(insertText, false, EST);
+shouldBeEqualToString(targetDiv.innerText, TEST);
+
+document.execCommand(delete);
+document.execCommand(delete);
+document.execCommand(delete);
+document.execCommand(delete);
+document.execCommand(delete); // Remove '\n'
+shouldBeEmptyString(targetDiv.innerText);
+
+document.execCommand(insertText, false, TEST);
+shouldBeEqualToString(targetDiv.innerText, TEST);
+}
+/script
+/head
+body _onload_=test()
+div id=target contentEditableT/div
+/body
+/html


Modified: trunk/Source/WebCore/ChangeLog (179920 => 179921)

--- trunk/Source/WebCore/ChangeLog	2015-02-11 08:36:22 UTC (rev 179920)
+++ trunk/Source/WebCore/ChangeLog	2015-02-11 08:51:55 UTC (rev 179921)
@@ -1,3 +1,22 @@
+2015-02-11  ChangSeok Oh  changseok...@collabora.com
+
+Div having contentEditable and display:flex cannot be edited if it is empty.
+https://bugs.webkit.org/show_bug.cgi?id=141218
+
+Reviewed by Ryosuke Niwa.
+
+RenderFlexibleBox should be treated as a candidate for visible position. Visible selection
+in an editable area is recalculated whenever an inner value of div is changed. If the inner value
+is empty, the visible selection recalculated with DeleteSelectionCommand::m_endingPostion
+is not correct. Because RenderBlockFlow is only considered but not RenderFlexibleBox
+in Position::isCandidate so that a calculated 

[webkit-changes] [177721] trunk/Source/WebKit2

[changseok . oh]

Title: [177721] trunk/Source/WebKit2








Revision 177721
Author changseok...@collabora.com
Date 2014-12-23 21:34:39 -0800 (Tue, 23 Dec 2014)


Log Message
[GTK] Build fix after r177692
https://bugs.webkit.org/show_bug.cgi?id=139919

Reviewed by Gyuyoung Kim.

This change addresses build failures introduced after r177692.

* PlatformEfl.cmake: Renamed WebContextSoup to WebProcessPoolSoup.cpp
* PlatformGTK.cmake: ditto.
* UIProcess/API/gtk/PageClientImpl.cpp:
* UIProcess/API/gtk/WebKitDownloadClient.cpp:
* UIProcess/API/gtk/WebKitFormSubmissionRequest.cpp:
(webkitFormSubmissionRequestCreate):
(webkit_form_submission_request_get_text_fields):
* UIProcess/API/gtk/WebKitFormSubmissionRequestPrivate.h:
* UIProcess/API/gtk/WebKitInjectedBundleClient.cpp:
(didReceiveWebViewMessageFromInjectedBundle):
(didReceiveMessageFromInjectedBundle):
* UIProcess/API/gtk/WebKitSecurityManager.cpp:
(registerSecurityPolicyForURIScheme):
* UIProcess/API/gtk/WebKitWebContext.cpp:
(webkitWebContextConstructed):
(webkit_web_context_prefetch_dns):
(webkitWebContextGetContext):
* UIProcess/API/gtk/WebKitWebContextPrivate.h:
* UIProcess/API/gtk/WebKitWebView.cpp:
(webkit_web_view_get_snapshot):
* UIProcess/API/gtk/WebKitWebViewBase.cpp:
(webkitWebViewBaseCreate):
(webkitWebViewBaseCreateWebPage):
* UIProcess/API/gtk/WebKitWebViewBasePrivate.h:
* UIProcess/API/gtk/WebKitWindowProperties.cpp:
* UIProcess/gtk/WebInspectorProxyGtk.cpp:
(WebKit::WebInspectorProxy::platformCreateInspectorPage):
* UIProcess/gtk/WebProcessPoolGtk.cpp: Renamed from Source/WebKit2/UIProcess/gtk/WebContextGtk.cpp.
(WebKit::initInspectorServer):
(WebKit::WebProcessPool::platformDefaultApplicationCacheDirectory):
(WebKit::WebProcessPool::platformInitializeWebProcess):
(WebKit::WebProcessPool::platformInvalidateContext):
(WebKit::WebProcessPool::platformDefaultWebSQLDatabaseDirectory):
(WebKit::WebProcessPool::platformDefaultIndexedDBDatabaseDirectory):
(WebKit::WebProcessPool::platformDefaultIconDatabasePath):
(WebKit::WebProcessPool::platformDefaultLocalStorageDirectory):
(WebKit::WebProcessPool::platformDefaultMediaKeysStorageDirectory):
(WebKit::WebProcessPool::platformDefaultDiskCacheDirectory):
(WebKit::WebProcessPool::platformDefaultCookieStorageDirectory):
(WebKit::WebProcessPool::setIgnoreTLSErrors):
* UIProcess/soup/WebProcessPoolSoup.cpp: Renamed from Source/WebKit2/UIProcess/soup/WebContextSoup.cpp.
(WebKit::WebProcessPool::platformInitializeNetworkProcess):
* WebProcess/InjectedBundle/API/gtk/WebKitWebExtension.cpp:
(webkitWebExtensionDidReceiveMessage):
* WebProcess/InjectedBundle/API/gtk/WebKitWebPage.cpp:
(didInitiateLoadForResource):
(willSendRequestForFrame):
(didReceiveResponseForResource):
(didReceiveContentLengthForResource):
(didFinishLoadForResource):
(didFailLoadForResource):
(webkitWebPageDidReceiveMessage):
* WebProcess/InjectedBundle/API/gtk/WebKitWebPagePrivate.h:

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/PlatformEfl.cmake
trunk/Source/WebKit2/PlatformGTK.cmake
trunk/Source/WebKit2/UIProcess/API/gtk/PageClientImpl.cpp
trunk/Source/WebKit2/UIProcess/API/gtk/WebKitDownloadClient.cpp
trunk/Source/WebKit2/UIProcess/API/gtk/WebKitFormSubmissionRequest.cpp
trunk/Source/WebKit2/UIProcess/API/gtk/WebKitFormSubmissionRequestPrivate.h
trunk/Source/WebKit2/UIProcess/API/gtk/WebKitInjectedBundleClient.cpp
trunk/Source/WebKit2/UIProcess/API/gtk/WebKitSecurityManager.cpp
trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebContext.cpp
trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebContextPrivate.h
trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp
trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebViewBase.cpp
trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebViewBasePrivate.h
trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWindowProperties.cpp
trunk/Source/WebKit2/UIProcess/gtk/WebInspectorProxyGtk.cpp
trunk/Source/WebKit2/WebProcess/InjectedBundle/API/gtk/WebKitWebExtension.cpp
trunk/Source/WebKit2/WebProcess/InjectedBundle/API/gtk/WebKitWebPage.cpp
trunk/Source/WebKit2/WebProcess/InjectedBundle/API/gtk/WebKitWebPagePrivate.h


Added Paths

trunk/Source/WebKit2/UIProcess/gtk/WebProcessPoolGtk.cpp
trunk/Source/WebKit2/UIProcess/soup/WebProcessPoolSoup.cpp


Removed Paths

trunk/Source/WebKit2/UIProcess/gtk/WebContextGtk.cpp
trunk/Source/WebKit2/UIProcess/soup/WebContextSoup.cpp




Diff

Modified: trunk/Source/WebKit2/ChangeLog (177720 => 177721)

--- trunk/Source/WebKit2/ChangeLog	2014-12-24 04:58:51 UTC (rev 177720)
+++ trunk/Source/WebKit2/ChangeLog	2014-12-24 05:34:39 UTC (rev 177721)
@@ -1,3 +1,66 @@
+2014-12-23  ChangSeok Oh  changseok...@collabora.com
+
+[GTK] Build fix after r177692
+https://bugs.webkit.org/show_bug.cgi?id=139919
+
+Reviewed by Gyuyoung Kim.
+
+This change addresses build failures introduced after r177692.
+
+* PlatformEfl.cmake: Renamed WebContextSoup to WebProcessPoolSoup.cpp
+* PlatformGTK.cmake: ditto.
+* UIProcess/API/gtk/PageClientImpl.

[webkit-changes] [177216] trunk/Source/WebCore

[changseok . oh]

Title: [177216] trunk/Source/WebCore








Revision 177216
Author changseok...@collabora.com
Date 2014-12-12 01:21:15 -0800 (Fri, 12 Dec 2014)


Log Message
Implement MemoryPressureHandler for Linux system
https://bugs.webkit.org/show_bug.cgi?id=123532

Reviewed by Sergio Villar Senin.

This is an initial implementation to support MemoryPressureHandler for linux system.
The patch is based on Tomeu's last patch and improved on top of it.
Most of current linux distributions support cgroup, so that we use the memory.pressure_level
mechanism of cgroup to get notifications when an application reaches the 'low' memory
pressure level.

No new tests since no engine behavior changed.

* PlatformEfl.cmake:
* PlatformGTK.cmake:
* platform/MemoryPressureHandler.cpp:
(WebCore::MemoryPressureHandler::MemoryPressureHandler):
* platform/MemoryPressureHandler.h:
* platform/linux/MemoryPressureHandlerLinux.cpp: Added.
(WebCore::nextToken):
(WebCore::MemoryPressureHandler::~MemoryPressureHandler):
(WebCore::MemoryPressureHandler::waitForMemoryPressureEvent): run in a seperated thread
to listen 'low' level event.
(WebCore::MemoryPressureHandler::logErrorAndCloseFDs):
(WebCore::MemoryPressureHandler::install):
(WebCore::MemoryPressureHandler::uninstall):
(WebCore::MemoryPressureHandler::holdOffTimerFired):
(WebCore::MemoryPressureHandler::holdOff):
(WebCore::MemoryPressureHandler::respondToMemoryPressure):
(WebCore::MemoryPressureHandler::platformReleaseMemory):
(WebCore::MemoryPressureHandler::ReliefLogger::platformLog):
(WebCore::MemoryPressureHandler::ReliefLogger::platformMemoryUsage): read /proc/self/status
to get VM amount used by current process.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/PlatformEfl.cmake
trunk/Source/WebCore/PlatformGTK.cmake
trunk/Source/WebCore/platform/MemoryPressureHandler.cpp
trunk/Source/WebCore/platform/MemoryPressureHandler.h


Added Paths

trunk/Source/WebCore/platform/linux/MemoryPressureHandlerLinux.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (177215 => 177216)

--- trunk/Source/WebCore/ChangeLog	2014-12-12 09:17:21 UTC (rev 177215)
+++ trunk/Source/WebCore/ChangeLog	2014-12-12 09:21:15 UTC (rev 177216)
@@ -1,3 +1,39 @@
+2014-12-12  ChangSeok Oh  changseok...@collabora.com
+
+Implement MemoryPressureHandler for Linux system
+https://bugs.webkit.org/show_bug.cgi?id=123532
+
+Reviewed by Sergio Villar Senin.
+
+This is an initial implementation to support MemoryPressureHandler for linux system.
+The patch is based on Tomeu's last patch and improved on top of it.
+Most of current linux distributions support cgroup, so that we use the memory.pressure_level
+mechanism of cgroup to get notifications when an application reaches the 'low' memory
+pressure level.
+
+No new tests since no engine behavior changed.
+
+* PlatformEfl.cmake:
+* PlatformGTK.cmake:
+* platform/MemoryPressureHandler.cpp:
+(WebCore::MemoryPressureHandler::MemoryPressureHandler):
+* platform/MemoryPressureHandler.h:
+* platform/linux/MemoryPressureHandlerLinux.cpp: Added.
+(WebCore::nextToken):
+(WebCore::MemoryPressureHandler::~MemoryPressureHandler):
+(WebCore::MemoryPressureHandler::waitForMemoryPressureEvent): run in a seperated thread
+to listen 'low' level event.
+(WebCore::MemoryPressureHandler::logErrorAndCloseFDs):
+(WebCore::MemoryPressureHandler::install):
+(WebCore::MemoryPressureHandler::uninstall):
+(WebCore::MemoryPressureHandler::holdOffTimerFired):
+(WebCore::MemoryPressureHandler::holdOff):
+(WebCore::MemoryPressureHandler::respondToMemoryPressure):
+(WebCore::MemoryPressureHandler::platformReleaseMemory):
+(WebCore::MemoryPressureHandler::ReliefLogger::platformLog):
+(WebCore::MemoryPressureHandler::ReliefLogger::platformMemoryUsage): read /proc/self/status
+to get VM amount used by current process.
+
 2014-12-12  Simon Fraser  simon.fra...@apple.com
 
 Layer borders on contentsLayers don't correctly toggle with the rest of the borders


Modified: trunk/Source/WebCore/PlatformEfl.cmake (177215 => 177216)

--- trunk/Source/WebCore/PlatformEfl.cmake	2014-12-12 09:17:21 UTC (rev 177215)
+++ trunk/Source/WebCore/PlatformEfl.cmake	2014-12-12 09:21:15 UTC (rev 177216)
@@ -212,6 +212,7 @@
 platform/image-decoders/webp/WEBPImageDecoder.cpp
 
 platform/linux/GamepadDeviceLinux.cpp
+platform/linux/MemoryPressureHandlerLinux.cpp
 
 platform/mediastream/gstreamer/MediaStreamCenterGStreamer.cpp
 


Modified: trunk/Source/WebCore/PlatformGTK.cmake (177215 => 177216)

--- trunk/Source/WebCore/PlatformGTK.cmake	2014-12-12 09:17:21 UTC (rev 177215)
+++ trunk/Source/WebCore/PlatformGTK.cmake	2014-12-12 09:21:15 UTC (rev 177216)
@@ -156,6 +156,7 @@
 platform/image-decoders/webp/WEBPImageDecoder.cpp
 
 platf

[webkit-changes] [176255] trunk/Tools

[changseok . oh]

Title: [176255] trunk/Tools








Revision 176255
Author changseok...@collabora.com
Date 2014-11-18 05:40:49 -0800 (Tue, 18 Nov 2014)


Log Message
[GTK] Mesa build fails over llvm-3.5
https://bugs.webkit.org/show_bug.cgi?id=138825

Reviewed by Gustavo Noronha Silva.

OwningPtr.h have been removed in llvm-3.5. Instread we should use std::unique_ptr for mesa build.

* gtk/jhbuild.modules:
* gtk/patches/mesa-gallivm-Fix-build-after-LLVM-commit-211259.patch: Added.

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/gtk/jhbuild.modules


Added Paths

trunk/Tools/gtk/patches/mesa-gallivm-Fix-build-after-LLVM-commit-211259.patch




Diff

Modified: trunk/Tools/ChangeLog (176254 => 176255)

--- trunk/Tools/ChangeLog	2014-11-18 12:51:59 UTC (rev 176254)
+++ trunk/Tools/ChangeLog	2014-11-18 13:40:49 UTC (rev 176255)
@@ -1,3 +1,15 @@
+2014-11-18  ChangSeok Oh  changseok...@collabora.com
+
+[GTK] Mesa build fails over llvm-3.5
+https://bugs.webkit.org/show_bug.cgi?id=138825
+
+Reviewed by Gustavo Noronha Silva.
+
+OwningPtr.h have been removed in llvm-3.5. Instread we should use std::unique_ptr for mesa build.
+
+* gtk/jhbuild.modules:
+* gtk/patches/mesa-gallivm-Fix-build-after-LLVM-commit-211259.patch: Added.
+
 2014-11-17  Daniel Bates  daba...@apple.com
 
 Unreviewed, rolling out r176232.


Modified: trunk/Tools/gtk/jhbuild.modules (176254 => 176255)

--- trunk/Tools/gtk/jhbuild.modules	2014-11-18 12:51:59 UTC (rev 176254)
+++ trunk/Tools/gtk/jhbuild.modules	2014-11-18 13:40:49 UTC (rev 176255)
@@ -355,7 +355,9 @@
 branch module=/pub/mesa/10.2.1/MesaLib-10.2.1.tar.bz2 version=10.2.1
 checkoutdir=Mesa
 repo=ftp.freedesktop.org
-hash=sha256:461277909207da689d8152cfbf9e182ea6f70e1e672ab64c67df83725c8d2b54/
+hash=sha256:461277909207da689d8152cfbf9e182ea6f70e1e672ab64c67df83725c8d2b54
+  patch file=mesa-gallivm-Fix-build-after-LLVM-commit-211259.patch strip=1/
+/branch
   /autotools
 
 /moduleset


Added: trunk/Tools/gtk/patches/mesa-gallivm-Fix-build-after-LLVM-commit-211259.patch (0 => 176255)

--- trunk/Tools/gtk/patches/mesa-gallivm-Fix-build-after-LLVM-commit-211259.patch	(rev 0)
+++ trunk/Tools/gtk/patches/mesa-gallivm-Fix-build-after-LLVM-commit-211259.patch	2014-11-18 13:40:49 UTC (rev 176255)
@@ -0,0 +1,29 @@
+From 564821c917f4a9d5a0de2ee77b90b0cd85e3d3a6 Mon Sep 17 00:00:00 2001
+From: Aaron Watry awa...@gmail.com
+Date: Fri, 20 Jun 2014 19:13:30 -0500
+Subject: [PATCH] gallivm: Fix build after LLVM commit 211259
+
+Signed-off-by: Aaron Watry awa...@gmail.com
+Reviewed-by: Tom Stellard thomas.stell...@amd.com
+---
+ src/gallium/auxiliary/gallivm/lp_bld_debug.cpp | 4 +++-
+ 1 file changed, 3 insertions(+), 1 deletion(-)
+
+diff --git a/src/gallium/auxiliary/gallivm/lp_bld_debug.cpp b/src/gallium/auxiliary/gallivm/lp_bld_debug.cpp
+index df26883..413a0c2 100644
+--- a/src/gallium/auxiliary/gallivm/lp_bld_debug.cpp
 b/src/gallium/auxiliary/gallivm/lp_bld_debug.cpp
+@@ -51,7 +51,9 @@
+ #include llvm/MC/MCInstPrinter.h
+ #include llvm/MC/MCRegisterInfo.h
+ 
+-#if HAVE_LLVM = 0x0303
++#if HAVE_LLVM = 0x0305
++#define OwningPtr std::unique_ptr
++#elif HAVE_LLVM = 0x0303
+ #include llvm/ADT/OwningPtr.h
+ #endif
+ 
+-- 
+2.1.0
+






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [167667] trunk/Tools

[changseok . oh]

Title: [167667] trunk/Tools








Revision 167667
Author changseok...@collabora.com
Date 2014-04-22 10:38:15 -0700 (Tue, 22 Apr 2014)


Log Message
[GTK] YCM choose a newer compile_commands.json in between Release or Debug
https://bugs.webkit.org/show_bug.cgi?id=131911

Reviewed by Martin Robinson.

common.get_build_path returns release path even though Debug configuration
is newer than Release. So YouCompleteMe is used to refer old build setup inadvertently.

* gtk/ycm_extra_conf.py:
(get_build_path): Compare modified time of Release and Debug. And return a recent modified path.
(FlagsForFile):

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/gtk/ycm_extra_conf.py




Diff

Modified: trunk/Tools/ChangeLog (167666 => 167667)

--- trunk/Tools/ChangeLog	2014-04-22 17:30:56 UTC (rev 167666)
+++ trunk/Tools/ChangeLog	2014-04-22 17:38:15 UTC (rev 167667)
@@ -1,3 +1,17 @@
+2014-04-22  ChangSeok Oh  changseok...@collabora.com
+
+[GTK] YCM choose a newer compile_commands.json in between Release or Debug
+https://bugs.webkit.org/show_bug.cgi?id=131911
+
+Reviewed by Martin Robinson.
+
+common.get_build_path returns release path even though Debug configuration
+is newer than Release. So YouCompleteMe is used to refer old build setup inadvertently.
+
+* gtk/ycm_extra_conf.py:
+(get_build_path): Compare modified time of Release and Debug. And return a recent modified path.
+(FlagsForFile):
+
 2014-04-21  Brent Fulgham  bfulg...@apple.com
 
 Unreviewed build fix.


Modified: trunk/Tools/gtk/ycm_extra_conf.py (167666 => 167667)

--- trunk/Tools/gtk/ycm_extra_conf.py	2014-04-22 17:30:56 UTC (rev 167666)
+++ trunk/Tools/gtk/ycm_extra_conf.py	2014-04-22 17:38:15 UTC (rev 167667)
@@ -61,6 +61,26 @@
 return result
 
 
+def get_build_path():
+webkitbuild_path = os.path.join(common.get_build_path(fatal=False), '..')
+if not os.path.exists(webkitbuild_path):
+return None
+
+release_build_path = os.path.join(webkitbuild_path, 'Release')
+debug_build_path = os.path.join(webkitbuild_path, 'Debug')
+
+try:
+release_mtime = os.path.getmtime(os.path.join(release_build_path, 'compile_commands.json'))
+except os.error:
+release_mtime = 0
+try:
+debug_mtime = os.path.getmtime(os.path.join(debug_build_path, 'compile_commands.json'))
+except os.error:
+debug_mtime = 0
+
+return release_build_path if release_mtime = debug_mtime else debug_build_path
+
+
 def FlagsForFile(filename, **kwargs):
 This is the main entry point for YCM. Its interface is fixed.
 
@@ -88,7 +108,7 @@
 # Force config.h file inclusion, for GLib macros.
 result['flags'].append(-includeconfig.h)
 
-build_path = os.path.normpath(common.get_build_path(fatal=False))
+build_path = os.path.normpath(get_build_path())
 if not build_path:
 print Could not find WebKit build path.
 return result






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [167482] trunk/Tools

[changseok . oh]

Title: [167482] trunk/Tools








Revision 167482
Author changseok...@collabora.com
Date 2014-04-17 22:05:41 -0700 (Thu, 17 Apr 2014)


Log Message
[GTK] YouCompleteMe doesn't work for cmake build system.
https://bugs.webkit.org/show_bug.cgi?id=131591

Reviewed by Martin Robinson.

Add cmake build system support for YouCompleteMe. It should work regardless of
using make or ninja. In addition, autotools related code is removed since it's
not used anymore in WebKit.

* Scripts/webkitdirs.pm:
(generateBuildSystemFromCMakeProject):
* gtk/ycm_extra_conf.py:
(transform_relative_paths_to_absolute_paths):
(FlagsForFile):

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitdirs.pm
trunk/Tools/gtk/ycm_extra_conf.py




Diff

Modified: trunk/Tools/ChangeLog (167481 => 167482)

--- trunk/Tools/ChangeLog	2014-04-18 03:51:14 UTC (rev 167481)
+++ trunk/Tools/ChangeLog	2014-04-18 05:05:41 UTC (rev 167482)
@@ -1,3 +1,20 @@
+2014-04-17  ChangSeok Oh  changseok...@collabora.com
+
+[GTK] YouCompleteMe doesn't work for cmake build system.
+https://bugs.webkit.org/show_bug.cgi?id=131591
+
+Reviewed by Martin Robinson.
+
+Add cmake build system support for YouCompleteMe. It should work regardless of
+using make or ninja. In addition, autotools related code is removed since it's
+not used anymore in WebKit.
+
+* Scripts/webkitdirs.pm:
+(generateBuildSystemFromCMakeProject):
+* gtk/ycm_extra_conf.py:
+(transform_relative_paths_to_absolute_paths):
+(FlagsForFile):
+
 2014-04-17  Anders Carlsson  ander...@apple.com
 
 Fix build.


Modified: trunk/Tools/Scripts/webkitdirs.pm (167481 => 167482)

--- trunk/Tools/Scripts/webkitdirs.pm	2014-04-18 03:51:14 UTC (rev 167481)
+++ trunk/Tools/Scripts/webkitdirs.pm	2014-04-18 05:05:41 UTC (rev 167482)
@@ -1811,6 +1811,7 @@
 my @args;
 push @args, -DPORT=\$port\;
 push @args, -DCMAKE_INSTALL_PREFIX=\$prefixPath\ if $prefixPath;
+push @args, -DCMAKE_EXPORT_COMPILE_COMMANDS=ON if isGtk();
 push @args, -DSHARED_CORE=ON if isEfl()  $ENV{ENABLE_DRT};
 if ($config =~ /release/i) {
 push @args, -DCMAKE_BUILD_TYPE=Release;


Modified: trunk/Tools/gtk/ycm_extra_conf.py (167481 => 167482)

--- trunk/Tools/gtk/ycm_extra_conf.py	2014-04-18 03:51:14 UTC (rev 167481)
+++ trunk/Tools/gtk/ycm_extra_conf.py	2014-04-18 05:05:41 UTC (rev 167482)
@@ -1,5 +1,6 @@
 #!/usr/bin/env python
 # Copyright (C) 2013 Danilo Cesar Lemes de Paula danilo...@gmail.com
+# Copyright (C) 2014 ChangSeok Oh shivami...@gmail.com
 #
 # This library is free software; you can redistribute it and/or
 # modify it under the terms of the GNU Lesser General Public
@@ -16,9 +17,8 @@
 # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301  USA
 
 import os
-import re
-import subprocess
 import sys
+import ycm_core
 
 # It's very likely that this script is a symlink somewhere in the WebKit directory,
 # so we try to find the actual script location so that we can locate the tools
@@ -34,13 +34,10 @@
 sys.path.insert(0, os.path.abspath(__tools_directory))
 import common
 
-MAKE_TRACE_FILE_NAME = ycm-make-trace
-FLAGS_PRECEDING_PATHS = ['-isystem', '-I', '-iquote', '--sysroot=']
 
-
+FLAGS_PRECEDING_PATHS = ['-isystem', '-I', '-iquote', '--sysroot=']
 def transform_relative_paths_to_absolute_paths(arguments, build_path):
 result = []
-
 make_next_absolute = False
 for argument in arguments:
 if make_next_absolute:
@@ -64,56 +61,6 @@
 return result
 
 
-def create_make_trace_file(build_path):
-print Creating make trace file for YouCompleteMe, might take a few seconds
-os.chdir(build_path)
-subprocess.call(make -n -s  %s % MAKE_TRACE_FILE_NAME, shell=True)
-
-
-def make_trace_file_up_to_date(build_path):
-trace_file = os.path.join(build_path, MAKE_TRACE_FILE_NAME)
-if not os.path.isfile(trace_file):
-return False
-
-makefile = os.path.join(build_path, 'GNUmakefile')
-if os.path.getmtime(trace_file)  os.path.getctime(makefile):
-return False
-
-return True
-
-
-def ensure_make_trace_file(build_path):
-if make_trace_file_up_to_date(build_path):
-return True
-create_make_trace_file(build_path)
-return make_trace_file_up_to_date(build_path)
-
-
-def get_compilation_flags_from_build_commandline(command_line, build_path):
-flags = re.findall(-[I,D,p,O][\w,\.,/,-]*(?:=\?\w*\?)?, command_line)
-return transform_relative_paths_to_absolute_paths(flags, build_path)
-
-
-def get_compilation_flags_for_file(build_path, filename):
-trace_file_path = os.path.join(build_path, MAKE_TRACE_FILE_NAME)
-
-try:
-trace_file = open(trace_file_path)
-lines = trace_file.readlines()
-trace_file.close()
-except:
-print  Error reading %s file, trace_file_path
-return []
-
-basename = os.path.basename(filename)
-for line in lines:
-if 

[webkit-changes] [165189] trunk/Tools

[changseok . oh]

Title: [165189] trunk/Tools








Revision 165189
Author changseok...@collabora.com
Date 2014-03-06 07:01:12 -0800 (Thu, 06 Mar 2014)


Log Message
make-3.82 fails to build on ARM/Linux
https://bugs.webkit.org/show_bug.cgi?id=107926

Reviewed by Martin Robinson.

Some ARM/Linux systems don't support PAGE_SIZE macro so that it causes a build failure.
The related bug reporting is here. https://lists.debian.org/debian-kernel/2014/02/msg00274.html
To avoid this, I propose to use sysconf(_SC_PAGESIZE) instead of PAGE_SIZE
where it is not defined. See more details, http://linux.die.net/man/2/getpagesize

* gtk/patches/make-3.82-arg-list-length.patch:

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/gtk/patches/make-3.82-arg-list-length.patch




Diff

Modified: trunk/Tools/ChangeLog (165188 => 165189)

--- trunk/Tools/ChangeLog	2014-03-06 14:20:46 UTC (rev 165188)
+++ trunk/Tools/ChangeLog	2014-03-06 15:01:12 UTC (rev 165189)
@@ -1,3 +1,17 @@
+2014-03-06  ChangSeok Oh  changseok...@collabora.com
+
+make-3.82 fails to build on ARM/Linux
+https://bugs.webkit.org/show_bug.cgi?id=107926
+
+Reviewed by Martin Robinson.
+
+Some ARM/Linux systems don't support PAGE_SIZE macro so that it causes a build failure.
+The related bug reporting is here. https://lists.debian.org/debian-kernel/2014/02/msg00274.html
+To avoid this, I propose to use sysconf(_SC_PAGESIZE) instead of PAGE_SIZE
+where it is not defined. See more details, http://linux.die.net/man/2/getpagesize
+
+* gtk/patches/make-3.82-arg-list-length.patch:
+
 2014-03-06  Carlos Garcia Campos  cgar...@igalia.com
 
 [GTK] Close the page when the view is disposed instead of when finalized


Modified: trunk/Tools/gtk/patches/make-3.82-arg-list-length.patch (165188 => 165189)

--- trunk/Tools/gtk/patches/make-3.82-arg-list-length.patch	2014-03-06 14:20:46 UTC (rev 165188)
+++ trunk/Tools/gtk/patches/make-3.82-arg-list-length.patch	2014-03-06 15:01:12 UTC (rev 165189)
@@ -36,11 +36,14 @@
  
  # ifdef __EMX__ /* is this necessary? */
  if (!unixy_shell)
-@@ -2865,8 +2871,17 @@
+@@ -2865,8 +2871,20 @@
  	return new_argv;
}
  
 +#ifdef MAX_ARG_STRLEN
++#ifndef PAGE_SIZE
++#define PAGE_SIZE sysconf(_SC_PAGESIZE)
++#endif
 +static char eval_line[] = eval\\ \\\set\\ x\\;\\ shift\\;\\ ;
 +#define ARG_NUMBER_DIGITS 5
 +#define EVAL_LEN (sizeof(eval_line)-1 + shell_len + 4   \






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [164524] trunk/Source/WebCore

[changseok . oh]

Title: [164524] trunk/Source/WebCore








Revision 164524
Author changseok...@collabora.com
Date 2014-02-21 19:53:53 -0800 (Fri, 21 Feb 2014)


Log Message
Mac port uses ANGLE_instanced_arrays related apis through those in GraphicsContext3DCommon.cpp
https://bugs.webkit.org/show_bug.cgi?id=128803

Reviewed by Dean Jackson.

Merge mac port implementation of ANGLE_instanced_arrays into common code.

No new tests, no functionality changed.

* platform/graphics/mac/GraphicsContext3DMac.mm:
* platform/graphics/opengl/Extensions3DOpenGL.cpp:
(WebCore::Extensions3DOpenGL::drawArraysInstanced):
(WebCore::Extensions3DOpenGL::drawElementsInstanced):
(WebCore::Extensions3DOpenGL::vertexAttribDivisor):
* platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:
(WebCore::GraphicsContext3D::vertexAttribDivisor):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/mac/GraphicsContext3DMac.mm
trunk/Source/WebCore/platform/graphics/opengl/Extensions3DOpenGL.cpp
trunk/Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (164523 => 164524)

--- trunk/Source/WebCore/ChangeLog	2014-02-22 03:39:46 UTC (rev 164523)
+++ trunk/Source/WebCore/ChangeLog	2014-02-22 03:53:53 UTC (rev 164524)
@@ -1,3 +1,22 @@
+2014-02-21  ChangSeok Oh  changseok...@collabora.com
+
+Mac port uses ANGLE_instanced_arrays related apis through those in GraphicsContext3DCommon.cpp
+https://bugs.webkit.org/show_bug.cgi?id=128803
+
+Reviewed by Dean Jackson.
+
+Merge mac port implementation of ANGLE_instanced_arrays into common code.
+
+No new tests, no functionality changed.
+
+* platform/graphics/mac/GraphicsContext3DMac.mm:
+* platform/graphics/opengl/Extensions3DOpenGL.cpp:
+(WebCore::Extensions3DOpenGL::drawArraysInstanced):
+(WebCore::Extensions3DOpenGL::drawElementsInstanced):
+(WebCore::Extensions3DOpenGL::vertexAttribDivisor):
+* platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:
+(WebCore::GraphicsContext3D::vertexAttribDivisor):
+
 2014-02-21  Myles C. Maxfield  mmaxfi...@apple.com
 
 After copy and paste, cursor may appear to be above the bottom of content


Modified: trunk/Source/WebCore/platform/graphics/mac/GraphicsContext3DMac.mm (164523 => 164524)

--- trunk/Source/WebCore/platform/graphics/mac/GraphicsContext3DMac.mm	2014-02-22 03:39:46 UTC (rev 164523)
+++ trunk/Source/WebCore/platform/graphics/mac/GraphicsContext3DMac.mm	2014-02-22 03:53:53 UTC (rev 164524)
@@ -370,44 +370,6 @@
 {
 }
 
-void GraphicsContext3D::drawArraysInstanced(GC3Denum mode, GC3Dint first, GC3Dsizei count, GC3Dsizei primcount)
-{
-#if PLATFORM(IOS) || PLATFORM(MAC)  __MAC_OS_X_VERSION_MIN_REQUIRED = 1090
-makeContextCurrent();
-::glDrawArraysInstancedARB(mode, first, count, primcount);
-#else
-UNUSED_PARAM(mode);
-UNUSED_PARAM(first);
-UNUSED_PARAM(count);
-UNUSED_PARAM(primcount);
-#endif
 }
 
-void GraphicsContext3D::drawElementsInstanced(GC3Denum mode, GC3Dsizei count, GC3Denum type, GC3Dintptr offset, GC3Dsizei primcount)
-{
-#if PLATFORM(IOS) || PLATFORM(MAC)  __MAC_OS_X_VERSION_MIN_REQUIRED = 1090
-makeContextCurrent();
-::glDrawElementsInstancedARB(mode, count, type, reinterpret_castGLvoid*(static_castintptr_t(offset)), primcount);
-#else
-UNUSED_PARAM(mode);
-UNUSED_PARAM(count);
-UNUSED_PARAM(type);
-UNUSED_PARAM(offset);
-UNUSED_PARAM(primcount);
-#endif
-}
-
-void GraphicsContext3D::vertexAttribDivisor(GC3Duint index, GC3Duint divisor)
-{
-#if PLATFORM(IOS) || PLATFORM(MAC)  __MAC_OS_X_VERSION_MIN_REQUIRED = 1090
-makeContextCurrent();
-::glVertexAttribDivisorARB(index, divisor);
-#else
-UNUSED_PARAM(index);
-UNUSED_PARAM(divisor);
-#endif
-}
-
-}
-
 #endif // USE(3D_GRAPHICS)


Modified: trunk/Source/WebCore/platform/graphics/opengl/Extensions3DOpenGL.cpp (164523 => 164524)

--- trunk/Source/WebCore/platform/graphics/opengl/Extensions3DOpenGL.cpp	2014-02-22 03:39:46 UTC (rev 164523)
+++ trunk/Source/WebCore/platform/graphics/opengl/Extensions3DOpenGL.cpp	2014-02-22 03:53:53 UTC (rev 164524)
@@ -232,9 +232,11 @@
 
 void Extensions3DOpenGL::drawArraysInstanced(GC3Denum mode, GC3Dint first, GC3Dsizei count, GC3Dsizei primcount)
 {
+m_context-makeContextCurrent();
 #if PLATFORM(GTK)
-m_context-makeContextCurrent();
 ::glDrawArraysInstanced(mode, first, count, primcount);
+#elif PLATFORM(IOS) || PLATFORM(MAC)  __MAC_OS_X_VERSION_MIN_REQUIRED = 1090
+::glDrawArraysInstancedARB(mode, first, count, primcount);
 #else
 UNUSED_PARAM(mode);
 UNUSED_PARAM(first);
@@ -245,9 +247,11 @@
 
 void Extensions3DOpenGL::drawElementsInstanced(GC3Denum mode, GC3Dsizei count, GC3Denum type, long long offset, GC3Dsizei primcount)
 {
+m_context-makeContextCurrent();
 #if PLATFORM(GTK)
-m_context-makeContextCurrent();
 ::glDrawElementsInstanced(mo

[webkit-changes] [164525] trunk/Source/WebCore

[changseok . oh]

Title: [164525] trunk/Source/WebCore








Revision 164525
Author changseok...@collabora.com
Date 2014-02-21 19:56:33 -0800 (Fri, 21 Feb 2014)


Log Message
[GTK] Support WEBGL_draw_buffers extension.
https://bugs.webkit.org/show_bug.cgi?id=129143

Reviewed by Dean Jackson.

Support the WEBGL_draw_buffers WebGL extension for gtk port. Relevant opengl APIs
are exposed for WebGLRenderingContext to access them properly.

Covered by fast/canvas/webgl/webgl-draw-buffers.html

* platform/graphics/OpenGLShims.cpp:
(WebCore::initializeOpenGLShims):
* platform/graphics/OpenGLShims.h:
* platform/graphics/opengl/Extensions3DOpenGL.cpp:
(WebCore::Extensions3DOpenGL::supportsExtension):
(WebCore::Extensions3DOpenGL::drawBuffersEXT):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/OpenGLShims.cpp
trunk/Source/WebCore/platform/graphics/OpenGLShims.h
trunk/Source/WebCore/platform/graphics/opengl/Extensions3DOpenGL.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (164524 => 164525)

--- trunk/Source/WebCore/ChangeLog	2014-02-22 03:53:53 UTC (rev 164524)
+++ trunk/Source/WebCore/ChangeLog	2014-02-22 03:56:33 UTC (rev 164525)
@@ -1,5 +1,24 @@
 2014-02-21  ChangSeok Oh  changseok...@collabora.com
 
+[GTK] Support WEBGL_draw_buffers extension.
+https://bugs.webkit.org/show_bug.cgi?id=129143
+
+Reviewed by Dean Jackson.
+
+Support the WEBGL_draw_buffers WebGL extension for gtk port. Relevant opengl APIs
+are exposed for WebGLRenderingContext to access them properly.
+
+Covered by fast/canvas/webgl/webgl-draw-buffers.html
+
+* platform/graphics/OpenGLShims.cpp:
+(WebCore::initializeOpenGLShims):
+* platform/graphics/OpenGLShims.h:
+* platform/graphics/opengl/Extensions3DOpenGL.cpp:
+(WebCore::Extensions3DOpenGL::supportsExtension):
+(WebCore::Extensions3DOpenGL::drawBuffersEXT):
+
+2014-02-21  ChangSeok Oh  changseok...@collabora.com
+
 Mac port uses ANGLE_instanced_arrays related apis through those in GraphicsContext3DCommon.cpp
 https://bugs.webkit.org/show_bug.cgi?id=128803
 


Modified: trunk/Source/WebCore/platform/graphics/OpenGLShims.cpp (164524 => 164525)

--- trunk/Source/WebCore/platform/graphics/OpenGLShims.cpp	2014-02-22 03:53:53 UTC (rev 164524)
+++ trunk/Source/WebCore/platform/graphics/OpenGLShims.cpp	2014-02-22 03:56:33 UTC (rev 164525)
@@ -147,6 +147,7 @@
 ASSIGN_FUNCTION_TABLE_ENTRY(glDetachShader, success);
 ASSIGN_FUNCTION_TABLE_ENTRY(glDisableVertexAttribArray, success);
 ASSIGN_FUNCTION_TABLE_ENTRY(glDrawArraysInstanced, success);
+ASSIGN_FUNCTION_TABLE_ENTRY(glDrawBuffers, success);
 ASSIGN_FUNCTION_TABLE_ENTRY(glDrawElementsInstanced, success);
 ASSIGN_FUNCTION_TABLE_ENTRY(glEnableVertexAttribArray, success);
 ASSIGN_FUNCTION_TABLE_ENTRY(glFramebufferRenderbuffer, success);


Modified: trunk/Source/WebCore/platform/graphics/OpenGLShims.h (164524 => 164525)

--- trunk/Source/WebCore/platform/graphics/OpenGLShims.h	2014-02-22 03:53:53 UTC (rev 164524)
+++ trunk/Source/WebCore/platform/graphics/OpenGLShims.h	2014-02-22 03:56:33 UTC (rev 164525)
@@ -70,6 +70,7 @@
 typedef void (GLAPIENTRY *glDetachShaderType) (GLuint, GLuint);
 typedef void (GLAPIENTRY *glDisableVertexAttribArrayType) (GLuint);
 typedef void (GLAPIENTRY *glDrawArraysInstancedType) (GLenum, GLint, GLsizei, GLsizei);
+typedef void (GLAPIENTRY *glDrawBuffersType) (GLsizei, const GLenum*);
 typedef void (GLAPIENTRY *glDrawElementsInstancedType) (GLenum, GLsizei, GLenum, const GLvoid*, GLsizei);
 typedef void (GLAPIENTRY *glEnableVertexAttribArrayType) (GLuint);
 typedef void (GLAPIENTRY *glFramebufferRenderbufferType) (GLenum, GLenum, GLenum, GLuint);
@@ -175,6 +176,7 @@
 FUNCTION_TABLE_ENTRY(glDetachShader);
 FUNCTION_TABLE_ENTRY(glDisableVertexAttribArray);
 FUNCTION_TABLE_ENTRY(glDrawArraysInstanced);
+FUNCTION_TABLE_ENTRY(glDrawBuffers);
 FUNCTION_TABLE_ENTRY(glDrawElementsInstanced);
 FUNCTION_TABLE_ENTRY(glEnableVertexAttribArray);
 FUNCTION_TABLE_ENTRY(glFramebufferRenderbuffer);
@@ -290,6 +292,8 @@
 #define glDisableVertexAttribArray LOOKUP_GL_FUNCTION(glDisableVertexAttribArray)
 #define glDrawArraysInstancedEXT   glDrawArraysInstanced
 #define glDrawArraysInstanced  LOOKUP_GL_FUNCTION(glDrawArraysInstanced)
+#define glDrawBuffersEXT   glDrawBuffers
+#define glDrawBuffers  LOOKUP_GL_FUNCTION(glDrawBuffers)
 #define glDrawElementsInstancedEXT glDrawElementsInstanced
 #define glDrawElementsInstancedLOOKUP_GL_FUNCTION(glDrawElementsInstanced)
 #define glEnableVertexAttribArray  LOOKUP_GL_FUNCTION(glEnableVertexAttribArray)


Modified: trunk/Source/WebCore/platform/graphics/opengl/Extensions3DOpenGL.cpp (164524 => 164525)

--- trunk/Source/WebCore/platform/graphics/opengl/Extensions3DOpenGL.cpp	2

[webkit-changes] [164468] trunk/Source/WebCore

[changseok . oh]

Title: [164468] trunk/Source/WebCore








Revision 164468
Author changseok...@collabora.com
Date 2014-02-20 20:59:09 -0800 (Thu, 20 Feb 2014)


Log Message
Remove unused chromium stuff in Extensions3D
https://bugs.webkit.org/show_bug.cgi?id=129086

Reviewed by Anders Carlsson.

Remove GL_CHROMIUM_copy_texture and GL_CHROMIUM_flipy interfaces since they are used nowhere.

No new tests since no functionality changed.

* platform/graphics/Extensions3D.h:
* platform/graphics/opengl/Extensions3DOpenGL.cpp:
* platform/graphics/opengl/Extensions3DOpenGL.h:
* platform/graphics/opengl/Extensions3DOpenGLES.cpp:
* platform/graphics/opengl/Extensions3DOpenGLES.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/Extensions3D.h
trunk/Source/WebCore/platform/graphics/opengl/Extensions3DOpenGL.cpp
trunk/Source/WebCore/platform/graphics/opengl/Extensions3DOpenGL.h
trunk/Source/WebCore/platform/graphics/opengl/Extensions3DOpenGLES.cpp
trunk/Source/WebCore/platform/graphics/opengl/Extensions3DOpenGLES.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (164467 => 164468)

--- trunk/Source/WebCore/ChangeLog	2014-02-21 04:55:44 UTC (rev 164467)
+++ trunk/Source/WebCore/ChangeLog	2014-02-21 04:59:09 UTC (rev 164468)
@@ -1,3 +1,20 @@
+2014-02-20  ChangSeok Oh  changseok...@collabora.com
+
+Remove unused chromium stuff in Extensions3D
+https://bugs.webkit.org/show_bug.cgi?id=129086
+
+Reviewed by Anders Carlsson.
+
+Remove GL_CHROMIUM_copy_texture and GL_CHROMIUM_flipy interfaces since they are used nowhere.
+
+No new tests since no functionality changed.
+
+* platform/graphics/Extensions3D.h:
+* platform/graphics/opengl/Extensions3DOpenGL.cpp:
+* platform/graphics/opengl/Extensions3DOpenGL.h:
+* platform/graphics/opengl/Extensions3DOpenGLES.cpp:
+* platform/graphics/opengl/Extensions3DOpenGLES.h:
+
 2014-02-20  Joseph Pecoraro  pecor...@apple.com
 
 [iOS] Assert / crash trying to draw empty checked input


Modified: trunk/Source/WebCore/platform/graphics/Extensions3D.h (164467 => 164468)

--- trunk/Source/WebCore/platform/graphics/Extensions3D.h	2014-02-21 04:55:44 UTC (rev 164467)
+++ trunk/Source/WebCore/platform/graphics/Extensions3D.h	2014-02-21 04:59:09 UTC (rev 164468)
@@ -71,8 +71,6 @@
 //   GL_IMG_texture_compression_pvrtc
 //   EXT_texture_filter_anisotropic
 //   GL_EXT_debug_marker
-//   GL_CHROMIUM_copy_texture
-//   GL_CHROMIUM_flipy
 //   GL_ARB_draw_buffers / GL_EXT_draw_buffers
 //   GL_ANGLE_instanced_arrays
 
@@ -155,13 +153,6 @@
 TEXTURE_MAX_ANISOTROPY_EXT = 0x84FE,
 MAX_TEXTURE_MAX_ANISOTROPY_EXT = 0x84FF,
 
-// GL_CHROMIUM_flipy
-UNPACK_FLIP_Y_CHROMIUM = 0x9240,
-
-// GL_CHROMIUM_copy_texture
-UNPACK_PREMULTIPLY_ALPHA_CHROMIUM = 0x9241,
-UNPACK_UNPREMULTIPLY_ALPHA_CHROMIUM = 0x9242,
-
 // GL_ARB_draw_buffers / GL_EXT_draw_buffers
 MAX_DRAW_BUFFERS_EXT = 0x8824,
 DRAW_BUFFER0_EXT = 0x8825,
@@ -223,9 +214,6 @@
 // GL_ANGLE_translated_shader_source
 virtual String getTranslatedShaderSourceANGLE(Platform3DObject) = 0;
 
-// GL_CHROMIUM_copy_texture
-virtual void copyTextureCHROMIUM(GC3Denum, Platform3DObject, Platform3DObject, GC3Dint, GC3Denum) = 0;
-
 // EXT Robustness - uses getGraphicsResetStatusARB
 virtual void readnPixelsEXT(int x, int y, GC3Dsizei width, GC3Dsizei height, GC3Denum format, GC3Denum type, GC3Dsizei bufSize, void *data) = 0;
 virtual void getnUniformfvEXT(GC3Duint program, int location, GC3Dsizei bufSize, float *params) = 0;


Modified: trunk/Source/WebCore/platform/graphics/opengl/Extensions3DOpenGL.cpp (164467 => 164468)

--- trunk/Source/WebCore/platform/graphics/opengl/Extensions3DOpenGL.cpp	2014-02-21 04:55:44 UTC (rev 164467)
+++ trunk/Source/WebCore/platform/graphics/opengl/Extensions3DOpenGL.cpp	2014-02-21 04:59:09 UTC (rev 164468)
@@ -141,12 +141,6 @@
 #endif
 }
 
-void Extensions3DOpenGL::copyTextureCHROMIUM(GC3Denum, Platform3DObject, Platform3DObject, GC3Dint, GC3Denum)
-{
-// FIXME: implement this function and add GL_CHROMIUM_copy_texture in supports().
-return;
-}
-
 void Extensions3DOpenGL::insertEventMarkerEXT(const String)
 {
 // FIXME: implement this function and add GL_EXT_debug_marker in supports().


Modified: trunk/Source/WebCore/platform/graphics/opengl/Extensions3DOpenGL.h (164467 => 164468)

--- trunk/Source/WebCore/platform/graphics/opengl/Extensions3DOpenGL.h	2014-02-21 04:55:44 UTC (rev 164467)
+++ trunk/Source/WebCore/platform/graphics/opengl/Extensions3DOpenGL.h	2014-02-21 04:59:09 UTC (rev 164468)
@@ -47,7 +47,6 @@
 virtual void deleteVertexArrayOES(Platform3DObject);
 virtual GC3Dboolean isVertexArrayOES(Platform3DObject);
 virtual void bindVertexArrayOES(Platform3DObject);
-virtual void copyTextureCHROMIUM(GC3Denum, Platform3DObject, Platform3DObject, GC3Di

[webkit-changes] [164416] trunk/Source/JavaScriptCore

[changseok . oh]

Title: [164416] trunk/Source/_javascript_Core








Revision 164416
Author changseok...@collabora.com
Date 2014-02-19 23:12:08 -0800 (Wed, 19 Feb 2014)


Log Message
Unreviewed build fix after r164396

* GNUmakefile.list.am: Added Promises.prototype.js properly

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/GNUmakefile.list.am




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (164415 => 164416)

--- trunk/Source/_javascript_Core/ChangeLog	2014-02-20 05:02:37 UTC (rev 164415)
+++ trunk/Source/_javascript_Core/ChangeLog	2014-02-20 07:12:08 UTC (rev 164416)
@@ -1,3 +1,9 @@
+2014-02-19  ChangSeok Oh  changseok...@collabora.com
+
+Unreviewed build fix after r164396
+
+* GNUmakefile.list.am: Added Promises.prototype.js properly
+
 2014-02-19  Geoffrey Garen  gga...@apple.com
 
 Crash after -[JSContext evaluateScript:] when initializing JSContext with JSVirtualMachine


Modified: trunk/Source/_javascript_Core/GNUmakefile.list.am (164415 => 164416)

--- trunk/Source/_javascript_Core/GNUmakefile.list.am	2014-02-20 05:02:37 UTC (rev 164415)
+++ trunk/Source/_javascript_Core/GNUmakefile.list.am	2014-02-20 07:12:08 UTC (rev 164416)
@@ -38,7 +38,7 @@
 	DerivedSources/_javascript_Core/LLIntAssembly.h
 
 _javascript_core_builtins_js_nosources += \
-	Source/_javascript_Core/builtins/Array.prototype.js
+	Source/_javascript_Core/builtins/Array.prototype.js \
 	Source/_javascript_Core/builtins/Promise.prototype.js
 
 _javascript_core_sources += \






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [164293] trunk/Source/WebCore

[changseok . oh]

Title: [164293] trunk/Source/WebCore








Revision 164293
Author changseok...@collabora.com
Date 2014-02-18 09:00:02 -0800 (Tue, 18 Feb 2014)


Log Message
[GTK] Unreviewed fix. Correct wrong flags, ENABLE(GTK)-PLATFORM(GTK).

* platform/graphics/opengl/Extensions3DOpenGL.cpp:
(WebCore::Extensions3DOpenGL::drawArraysInstanced):
(WebCore::Extensions3DOpenGL::drawElementsInstanced):
(WebCore::Extensions3DOpenGL::vertexAttribDivisor):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/opengl/Extensions3DOpenGL.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (164292 => 164293)

--- trunk/Source/WebCore/ChangeLog	2014-02-18 16:13:23 UTC (rev 164292)
+++ trunk/Source/WebCore/ChangeLog	2014-02-18 17:00:02 UTC (rev 164293)
@@ -1,3 +1,12 @@
+2014-02-18  ChangSeok Oh  changseok...@collabora.com
+
+[GTK] Unreviewed fix. Correct wrong flags, ENABLE(GTK)-PLATFORM(GTK).
+
+* platform/graphics/opengl/Extensions3DOpenGL.cpp:
+(WebCore::Extensions3DOpenGL::drawArraysInstanced):
+(WebCore::Extensions3DOpenGL::drawElementsInstanced):
+(WebCore::Extensions3DOpenGL::vertexAttribDivisor):
+
 2014-02-18  Mihnea Ovidenie  mih...@adobe.com
 
 [CSSRegions] Compute region ranges for inline replaced elements


Modified: trunk/Source/WebCore/platform/graphics/opengl/Extensions3DOpenGL.cpp (164292 => 164293)

--- trunk/Source/WebCore/platform/graphics/opengl/Extensions3DOpenGL.cpp	2014-02-18 16:13:23 UTC (rev 164292)
+++ trunk/Source/WebCore/platform/graphics/opengl/Extensions3DOpenGL.cpp	2014-02-18 17:00:02 UTC (rev 164293)
@@ -238,7 +238,7 @@
 
 void Extensions3DOpenGL::drawArraysInstanced(GC3Denum mode, GC3Dint first, GC3Dsizei count, GC3Dsizei primcount)
 {
-#if ENABLE(GTK)
+#if PLATFORM(GTK)
 m_context-makeContextCurrent();
 ::glDrawArraysInstanced(mode, first, count, primcount);
 #else
@@ -251,7 +251,7 @@
 
 void Extensions3DOpenGL::drawElementsInstanced(GC3Denum mode, GC3Dsizei count, GC3Denum type, long long offset, GC3Dsizei primcount)
 {
-#if ENABLE(GTK)
+#if PLATFORM(GTK)
 m_context-makeContextCurrent();
 ::glDrawElementsInstanced(mode, count, type, reinterpret_castGLvoid*(static_castintptr_t(offset)), primcount);
 #else
@@ -265,7 +265,7 @@
 
 void Extensions3DOpenGL::vertexAttribDivisor(GC3Duint index, GC3Duint divisor)
 {
-#if ENABLE(GTK)
+#if PLATFORM(GTK)
 m_context-makeContextCurrent();
 ::glVertexAttribDivisor(index, divisor);
 #else






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [164222] trunk

[changseok . oh]

Title: [164222] trunk








Revision 164222
Author changseok...@collabora.com
Date 2014-02-17 08:18:14 -0800 (Mon, 17 Feb 2014)


Log Message
[GTK] MEDIA_CONTROLS_SCRIPT depends on VIDEO_TRACK
https://bugs.webkit.org/show_bug.cgi?id=128799

Reviewed by Philippe Normand.

MEDIA_CONTROLS_SCRIPT has a dependency on VIDEO_TRACK. So it causes a build break
if building with autotools. cmake system has enabled it as default. So I propose
enabling VIDEO_TRACK as well.

* Source/autotools/SetupWebKitFeatures.m4:

Modified Paths

trunk/ChangeLog
trunk/Source/autotools/SetupWebKitFeatures.m4




Diff

Modified: trunk/ChangeLog (164221 => 164222)

--- trunk/ChangeLog	2014-02-17 15:29:46 UTC (rev 164221)
+++ trunk/ChangeLog	2014-02-17 16:18:14 UTC (rev 164222)
@@ -1,3 +1,16 @@
+2014-02-17  ChangSeok Oh  changseok...@collabora.com
+
+[GTK] MEDIA_CONTROLS_SCRIPT depends on VIDEO_TRACK
+https://bugs.webkit.org/show_bug.cgi?id=128799
+
+Reviewed by Philippe Normand.
+
+MEDIA_CONTROLS_SCRIPT has a dependency on VIDEO_TRACK. So it causes a build break
+if building with autotools. cmake system has enabled it as default. So I propose
+enabling VIDEO_TRACK as well.
+
+* Source/autotools/SetupWebKitFeatures.m4:
+
 2014-02-14  Commit Queue  commit-qu...@webkit.org
 
 Unreviewed, rolling out r164090.


Modified: trunk/Source/autotools/SetupWebKitFeatures.m4 (164221 => 164222)

--- trunk/Source/autotools/SetupWebKitFeatures.m4	2014-02-17 15:29:46 UTC (rev 164221)
+++ trunk/Source/autotools/SetupWebKitFeatures.m4	2014-02-17 16:18:14 UTC (rev 164222)
@@ -163,7 +163,7 @@
 ENABLE_TOUCH_ICON_LOADING=0 \
 ENABLE_USER_TIMING=0 \
 ENABLE_VIBRATION=0 \
-ENABLE_VIDEO_TRACK=0 \
+ENABLE_VIDEO_TRACK=1 \
 ENABLE_VIEW_MODE_CSS_MEDIA=1 \
 ENABLE_WEB_SOCKETS=1 \
 ENABLE_WEB_TIMING=1 \






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [164239] trunk/Source/WebCore

[changseok . oh]

Title: [164239] trunk/Source/WebCore








Revision 164239
Author changseok...@collabora.com
Date 2014-02-17 11:48:31 -0800 (Mon, 17 Feb 2014)


Log Message
[GTK] Build failure caused by missing jsmin module
https://bugs.webkit.org/show_bug.cgi?id=128742

Reviewed by Philippe Normand.

No new tests since no functionality changed.

* GNUmakefile.am: Relocate PYTHONPATH to make it meaningful.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/GNUmakefile.am




Diff

Modified: trunk/Source/WebCore/ChangeLog (164238 => 164239)

--- trunk/Source/WebCore/ChangeLog	2014-02-17 19:45:26 UTC (rev 164238)
+++ trunk/Source/WebCore/ChangeLog	2014-02-17 19:48:31 UTC (rev 164239)
@@ -1,3 +1,14 @@
+2014-02-17  ChangSeok Oh  changseok...@collabora.com
+
+[GTK] Build failure caused by missing jsmin module
+https://bugs.webkit.org/show_bug.cgi?id=128742
+
+Reviewed by Philippe Normand.
+
+No new tests since no functionality changed.
+
+* GNUmakefile.am: Relocate PYTHONPATH to make it meaningful.
+
 2014-02-17  Radu Stavila  stav...@adobe.com
 
 [CSS Regions] Make regions unsplittable


Modified: trunk/Source/WebCore/GNUmakefile.am (164238 => 164239)

--- trunk/Source/WebCore/GNUmakefile.am	2014-02-17 19:45:26 UTC (rev 164238)
+++ trunk/Source/WebCore/GNUmakefile.am	2014-02-17 19:48:31 UTC (rev 164239)
@@ -267,9 +267,8 @@
 
 USER_AGENT_SCRIPT_FILES = $(WebCore)/Modules/mediacontrols/mediaControlsApple.js $(WebCore)/Modules/mediacontrols/mediaControlsGtk.js
 DerivedSources/WebCore/UserAgentScriptsData.cpp: DerivedSources/WebCore/UserAgentScripts.h
-DerivedSources/WebCore/UserAgentScripts.h: PYTHONPATH=$(INSPECTOR_SCRIPTS_DIR)
 DerivedSources/WebCore/UserAgentScripts.h: $(WebCore)/Scripts/make-js-file-arrays.py $(USER_AGENT_SCRIPT_FILES)
-	$(AM_V_GEN)$(PYTHON) $ $@ DerivedSources/WebCore/UserAgentScriptsData.cpp $(USER_AGENT_SCRIPT_FILES)
+	$(AM_V_GEN) PYTHONPATH=$(INSPECTOR_SCRIPTS_DIR) $(PYTHON) $ $@ DerivedSources/WebCore/UserAgentScriptsData.cpp $(USER_AGENT_SCRIPT_FILES)
 
 # user agent style sheets
 USER_AGENT_STYLE_SHEETS = \






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [164273] trunk/Source/WebKit2

[changseok . oh]

Title: [164273] trunk/Source/WebKit2








Revision 164273
Author changseok...@collabora.com
Date 2014-02-17 22:51:36 -0800 (Mon, 17 Feb 2014)


Log Message
Unreviewed gtk build fix.

* GNUmakefile.list.am: Remove WebHistoryClient.cpp/h after r164230.

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/GNUmakefile.list.am




Diff

Modified: trunk/Source/WebKit2/ChangeLog (164272 => 164273)

--- trunk/Source/WebKit2/ChangeLog	2014-02-18 05:18:18 UTC (rev 164272)
+++ trunk/Source/WebKit2/ChangeLog	2014-02-18 06:51:36 UTC (rev 164273)
@@ -1,3 +1,9 @@
+2014-02-17  ChangSeok Oh  changseok...@collabora.com
+
+Unreviewed gtk build fix.
+
+* GNUmakefile.list.am: Remove WebHistoryClient.cpp/h after r164230.
+
 2014-02-17  Ricky Mondello  rmonde...@apple.com
 
 Expose a way to clear cookies modified after a given date


Modified: trunk/Source/WebKit2/GNUmakefile.list.am (164272 => 164273)

--- trunk/Source/WebKit2/GNUmakefile.list.am	2014-02-18 05:18:18 UTC (rev 164272)
+++ trunk/Source/WebKit2/GNUmakefile.list.am	2014-02-18 06:51:36 UTC (rev 164273)
@@ -940,8 +940,6 @@
 	Source/WebKit2/UIProcess/WebGeolocationProvider.h \
 	Source/WebKit2/UIProcess/WebGrammarDetail.cpp \
 	Source/WebKit2/UIProcess/WebGrammarDetail.h \
-	Source/WebKit2/UIProcess/WebHistoryClient.cpp \
-	Source/WebKit2/UIProcess/WebHistoryClient.h \
 	Source/WebKit2/UIProcess/WebIconDatabase.cpp \
 	Source/WebKit2/UIProcess/WebIconDatabase.h \
 	Source/WebKit2/UIProcess/WebIconDatabaseClient.cpp \






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [164026] trunk/Source/WebCore

[changseok . oh]

Title: [164026] trunk/Source/WebCore








Revision 164026
Author changseok...@collabora.com
Date 2014-02-13 04:58:54 -0800 (Thu, 13 Feb 2014)


Log Message
Support ANGLE_instanced_arrays for GLES backend.
https://bugs.webkit.org/show_bug.cgi?id=128579

Reviewed by Dean Jackson.

Add some APIs to Extensions3D to support ANGLE_instanced_arrays for GLES backend.
At the same time, drawArraysInstanced, drawElementsInstanced and vertexAttribDivisor
are moved from GC3DOpenGL.cpp to GC3DOpenGLCommon.cpp since they could be shareable
through Extensions3D.

Covered by fast/canvas/webgl/angle-instanced-arrays.html

* platform/graphics/Extensions3D.h:
* platform/graphics/opengl/Extensions3DOpenGL.cpp:
(WebCore::Extensions3DOpenGL::drawArraysInstanced):
(WebCore::Extensions3DOpenGL::drawElementsInstanced):
(WebCore::Extensions3DOpenGL::vertexAttribDivisor):
* platform/graphics/opengl/Extensions3DOpenGL.h:
* platform/graphics/opengl/Extensions3DOpenGLES.cpp:
(WebCore::Extensions3DOpenGLES::Extensions3DOpenGLES):
(WebCore::Extensions3DOpenGLES::drawArraysInstanced):
(WebCore::Extensions3DOpenGLES::drawElementsInstanced):
(WebCore::Extensions3DOpenGLES::vertexAttribDivisor):
(WebCore::Extensions3DOpenGLES::supportsExtension):
* platform/graphics/opengl/Extensions3DOpenGLES.h:
* platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:
* platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:
(WebCore::GraphicsContext3D::drawArraysInstanced):
(WebCore::GraphicsContext3D::drawElementsInstanced):
(WebCore::GraphicsContext3D::vertexAttribDivisor):
* platform/graphics/opengl/GraphicsContext3DOpenGLES.cpp:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/Extensions3D.h
trunk/Source/WebCore/platform/graphics/opengl/Extensions3DOpenGL.cpp
trunk/Source/WebCore/platform/graphics/opengl/Extensions3DOpenGL.h
trunk/Source/WebCore/platform/graphics/opengl/Extensions3DOpenGLES.cpp
trunk/Source/WebCore/platform/graphics/opengl/Extensions3DOpenGLES.h
trunk/Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGL.cpp
trunk/Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp
trunk/Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGLES.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (164025 => 164026)

--- trunk/Source/WebCore/ChangeLog	2014-02-13 12:35:44 UTC (rev 164025)
+++ trunk/Source/WebCore/ChangeLog	2014-02-13 12:58:54 UTC (rev 164026)
@@ -1,3 +1,37 @@
+2014-02-13  ChangSeok Oh  changseok...@collabora.com
+
+Support ANGLE_instanced_arrays for GLES backend.
+https://bugs.webkit.org/show_bug.cgi?id=128579
+
+Reviewed by Dean Jackson.
+
+Add some APIs to Extensions3D to support ANGLE_instanced_arrays for GLES backend.
+At the same time, drawArraysInstanced, drawElementsInstanced and vertexAttribDivisor
+are moved from GC3DOpenGL.cpp to GC3DOpenGLCommon.cpp since they could be shareable
+through Extensions3D.
+
+Covered by fast/canvas/webgl/angle-instanced-arrays.html
+
+* platform/graphics/Extensions3D.h:
+* platform/graphics/opengl/Extensions3DOpenGL.cpp:
+(WebCore::Extensions3DOpenGL::drawArraysInstanced):
+(WebCore::Extensions3DOpenGL::drawElementsInstanced):
+(WebCore::Extensions3DOpenGL::vertexAttribDivisor):
+* platform/graphics/opengl/Extensions3DOpenGL.h:
+* platform/graphics/opengl/Extensions3DOpenGLES.cpp:
+(WebCore::Extensions3DOpenGLES::Extensions3DOpenGLES):
+(WebCore::Extensions3DOpenGLES::drawArraysInstanced):
+(WebCore::Extensions3DOpenGLES::drawElementsInstanced):
+(WebCore::Extensions3DOpenGLES::vertexAttribDivisor):
+(WebCore::Extensions3DOpenGLES::supportsExtension):
+* platform/graphics/opengl/Extensions3DOpenGLES.h:
+* platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:
+* platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:
+(WebCore::GraphicsContext3D::drawArraysInstanced):
+(WebCore::GraphicsContext3D::drawElementsInstanced):
+(WebCore::GraphicsContext3D::vertexAttribDivisor):
+* platform/graphics/opengl/GraphicsContext3DOpenGLES.cpp:
+
 2014-02-13  Xabier Rodriguez Calvar  calva...@igalia.com
 
 [GTK] MEDIA_CONTROLS_SCRIPT support


Modified: trunk/Source/WebCore/platform/graphics/Extensions3D.h (164025 => 164026)

--- trunk/Source/WebCore/platform/graphics/Extensions3D.h	2014-02-13 12:35:44 UTC (rev 164025)
+++ trunk/Source/WebCore/platform/graphics/Extensions3D.h	2014-02-13 12:58:54 UTC (rev 164026)
@@ -74,6 +74,7 @@
 //   GL_CHROMIUM_copy_texture
 //   GL_CHROMIUM_flipy
 //   GL_ARB_draw_buffers / GL_EXT_draw_buffers
+//   GL_ANGLE_instanced_arrays
 
 // Takes full name of extension; for example,
 // GL_EXT_texture_format_BGRA.
@@ -238,6 +239,11 @@
 // GL_ARB_draw_buffers / GL_EXT_draw_buffers
 virtual void drawBuffersEXT(GC3Dsizei n, const GC3Denum

[webkit-changes] [164027] trunk/LayoutTests

[changseok . oh]

Title: [164027] trunk/LayoutTests








Revision 164027
Author changseok...@collabora.com
Date 2014-02-13 05:20:20 -0800 (Thu, 13 Feb 2014)


Log Message
Unreviewed GTK gardening.

Removed unexpected pass tests from TextExpections

* platform/gtk-wk2/TestExpectations:
* platform/gtk/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/gtk/TestExpectations
trunk/LayoutTests/platform/gtk-wk2/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (164026 => 164027)

--- trunk/LayoutTests/ChangeLog	2014-02-13 12:58:54 UTC (rev 164026)
+++ trunk/LayoutTests/ChangeLog	2014-02-13 13:20:20 UTC (rev 164027)
@@ -1,3 +1,12 @@
+2014-02-13  ChangSeok Oh  changseok...@collabora.com
+
+Unreviewed GTK gardening.
+
+Removed unexpected pass tests from TextExpections
+
+* platform/gtk-wk2/TestExpectations:
+* platform/gtk/TestExpectations:
+
 2014-02-13  Michał Pakuła vel Rutka  m.pak...@samsung.com
 
 Unreviewed EFL gardening


Modified: trunk/LayoutTests/platform/gtk/TestExpectations (164026 => 164027)

--- trunk/LayoutTests/platform/gtk/TestExpectations	2014-02-13 12:58:54 UTC (rev 164026)
+++ trunk/LayoutTests/platform/gtk/TestExpectations	2014-02-13 13:20:20 UTC (rev 164027)
@@ -1519,8 +1519,6 @@
 
 webkit.org/b/126879 fast/css3-text/css3-text-decoration/text-decoration-skip/text-decoration-skip-tall-underlines.html [ ImageOnlyFailure ]
 
-webkit.org/b/127740 accessibility/range-alter-by-percent.html [ Failure ]
-
 # Subpixel rendering: borders are reporting float values.
 webkit.org/b/128061 css1/units/length_units.html [ Failure ]
 webkit.org/b/128061 fast/css/bidi-override-in-anonymous-block.html [ Failure ]


Modified: trunk/LayoutTests/platform/gtk-wk2/TestExpectations (164026 => 164027)

--- trunk/LayoutTests/platform/gtk-wk2/TestExpectations	2014-02-13 12:58:54 UTC (rev 164026)
+++ trunk/LayoutTests/platform/gtk-wk2/TestExpectations	2014-02-13 13:20:20 UTC (rev 164027)
@@ -355,10 +355,6 @@
 # tables/ failures
 Bug(WK2) tables/mozilla_expected_failures/bugs/bug8499.html [ Failure ]
 
-# Assertion failure in replaySavedEvents
-# http://webkit.org/b/21796
-webkit.org/b/21796 fast/forms/select-multiple-elements-with-mouse-drag-with-options-less-than-size.html [ Failure ]
-
 # [Qt][WK2] New http/tests/security/cross-origin-plugin* tests fail
 # https://bugs.webkit.org/show_bug.cgi?id=95935
 webkit.org/b/95935 http/tests/security/cross-origin-plugin.html [ Failure ]
@@ -388,8 +384,6 @@
 Bug(GTK) fast/events/remove-target-with-shadow-in-drag.html [ Failure ]
 Bug(GTK) fast/events/scroll-in-scaled-page-with-overflow-hidden.html [ Failure ]
 Bug(GTK) fast/events/selectionchange-iframe.html [ Failure ]
-Bug(GTK) fast/forms/listbox-deselect-scroll.html [ Failure ]
-Bug(GTK) fast/forms/listbox-selection.html [ Failure ]
 Bug(GTK) fast/forms/listbox-typeahead-cyrillic.html [ Failure ]
 Bug(GTK) fast/forms/listbox-typeahead-greek.html [ Failure ]
 Bug(GTK) fast/forms/mailto/formenctype-attribute-button-html.html [ Failure ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [163858] trunk/Source/WebCore

[changseok . oh]

Title: [163858] trunk/Source/WebCore








Revision 163858
Author changseok...@collabora.com
Date 2014-02-10 21:24:44 -0800 (Mon, 10 Feb 2014)


Log Message
Support ANGLE_instanced_arrays for linux
https://bugs.webkit.org/show_bug.cgi?id=127465

Reviewed by Martin Robinson.

Support the instanced drawing WebGL extension, ANGLE_instanced_arrays for linux platform.
This is a following patch for r162565. Relevant opengl APIs are exposed
for WebGLRenderingContext to access them.

Covered by fast/canvas/webgl/angle-instanced-arrays.html

* html/canvas/ANGLEInstancedArrays.cpp:
(WebCore::ANGLEInstancedArrays::supported):
* platform/graphics/OpenGLShims.cpp:
(WebCore::initializeOpenGLShims):
* platform/graphics/OpenGLShims.h:
* platform/graphics/opengl/Extensions3DOpenGL.cpp:
(WebCore::Extensions3DOpenGL::supportsExtension):
* platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:
(WebCore::GraphicsContext3D::drawArraysInstanced):
(WebCore::GraphicsContext3D::drawElementsInstanced):
(WebCore::GraphicsContext3D::vertexAttribDivisor):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/canvas/ANGLEInstancedArrays.cpp
trunk/Source/WebCore/platform/graphics/OpenGLShims.cpp
trunk/Source/WebCore/platform/graphics/OpenGLShims.h
trunk/Source/WebCore/platform/graphics/opengl/Extensions3DOpenGL.cpp
trunk/Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGL.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (163857 => 163858)

--- trunk/Source/WebCore/ChangeLog	2014-02-11 05:17:15 UTC (rev 163857)
+++ trunk/Source/WebCore/ChangeLog	2014-02-11 05:24:44 UTC (rev 163858)
@@ -1,3 +1,28 @@
+2014-02-10  ChangSeok Oh  changseok...@collabora.com
+
+Support ANGLE_instanced_arrays for linux
+https://bugs.webkit.org/show_bug.cgi?id=127465
+
+Reviewed by Martin Robinson.
+
+Support the instanced drawing WebGL extension, ANGLE_instanced_arrays for linux platform.
+This is a following patch for r162565. Relevant opengl APIs are exposed
+for WebGLRenderingContext to access them.
+
+Covered by fast/canvas/webgl/angle-instanced-arrays.html
+
+* html/canvas/ANGLEInstancedArrays.cpp:
+(WebCore::ANGLEInstancedArrays::supported):
+* platform/graphics/OpenGLShims.cpp:
+(WebCore::initializeOpenGLShims):
+* platform/graphics/OpenGLShims.h:
+* platform/graphics/opengl/Extensions3DOpenGL.cpp:
+(WebCore::Extensions3DOpenGL::supportsExtension):
+* platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:
+(WebCore::GraphicsContext3D::drawArraysInstanced):
+(WebCore::GraphicsContext3D::drawElementsInstanced):
+(WebCore::GraphicsContext3D::vertexAttribDivisor):
+
 2014-02-10  Mark Lam  mark@apple.com
 
 Removing limitation on JSLock’s lockDropDepth.


Modified: trunk/Source/WebCore/html/canvas/ANGLEInstancedArrays.cpp (163857 => 163858)

--- trunk/Source/WebCore/html/canvas/ANGLEInstancedArrays.cpp	2014-02-11 05:17:15 UTC (rev 163857)
+++ trunk/Source/WebCore/html/canvas/ANGLEInstancedArrays.cpp	2014-02-11 05:24:44 UTC (rev 163858)
@@ -28,6 +28,10 @@
 #if ENABLE(WEBGL)
 #include ANGLEInstancedArrays.h
 
+#if PLATFORM(GTK)
+#include Extensions3D.h
+#endif
+
 namespace WebCore {
 
 ANGLEInstancedArrays::ANGLEInstancedArrays(WebGLRenderingContext* context)
@@ -49,11 +53,16 @@
 return adoptPtr(new ANGLEInstancedArrays(context));
 }
 
-bool ANGLEInstancedArrays::supported(WebGLRenderingContext*)
+bool ANGLEInstancedArrays::supported(WebGLRenderingContext* context)
 {
 #if PLATFORM(IOS) || PLATFORM(MAC)  __MAC_OS_X_VERSION_MIN_REQUIRED = 1090
+UNUSED_PARAM(context);
 return true;
+#elif PLATFORM(GTK)
+Extensions3D* extensions = context-graphicsContext3D()-getExtensions();
+return extensions-supports(GL_ANGLE_instanced_arrays);
 #else
+UNUSED_PARAM(context);
 return false;
 #endif
 }


Modified: trunk/Source/WebCore/platform/graphics/OpenGLShims.cpp (163857 => 163858)

--- trunk/Source/WebCore/platform/graphics/OpenGLShims.cpp	2014-02-11 05:17:15 UTC (rev 163857)
+++ trunk/Source/WebCore/platform/graphics/OpenGLShims.cpp	2014-02-11 05:24:44 UTC (rev 163858)
@@ -146,6 +146,8 @@
 ASSIGN_FUNCTION_TABLE_ENTRY_EXT(glDeleteVertexArrays);
 ASSIGN_FUNCTION_TABLE_ENTRY(glDetachShader, success);
 ASSIGN_FUNCTION_TABLE_ENTRY(glDisableVertexAttribArray, success);
+ASSIGN_FUNCTION_TABLE_ENTRY(glDrawArraysInstanced, success);
+ASSIGN_FUNCTION_TABLE_ENTRY(glDrawElementsInstanced, success);
 ASSIGN_FUNCTION_TABLE_ENTRY(glEnableVertexAttribArray, success);
 ASSIGN_FUNCTION_TABLE_ENTRY(glFramebufferRenderbuffer, success);
 ASSIGN_FUNCTION_TABLE_ENTRY(glFramebufferTexture2D, success);
@@ -220,6 +222,7 @@
 ASSIGN_FUNCTION_TABLE_ENTRY(glVertexAttrib3fv, success);
 ASSIGN_FUNCTION_TABLE_ENTRY(glVertexAttrib4f, success);
 ASSIGN_FUNCTION_TABLE_ENTRY(glVertexAttrib4fv, success);
+ASSIGN_FUNCTION_TA

[webkit-changes] [163616] trunk/LayoutTests

[changseok . oh]

Title: [163616] trunk/LayoutTests








Revision 163616
Author changseok...@collabora.com
Date 2014-02-07 02:10:55 -0800 (Fri, 07 Feb 2014)


Log Message
Unreviewed GTK port gardening

* platform/gtk-wk2/TestExpectations:
* platform/gtk/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/gtk/TestExpectations
trunk/LayoutTests/platform/gtk-wk2/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (163615 => 163616)

--- trunk/LayoutTests/ChangeLog	2014-02-07 09:20:03 UTC (rev 163615)
+++ trunk/LayoutTests/ChangeLog	2014-02-07 10:10:55 UTC (rev 163616)
@@ -1,3 +1,10 @@
+2014-02-07  ChangSeok Oh  changseok...@collabora.com
+
+Unreviewed GTK port gardening
+
+* platform/gtk-wk2/TestExpectations:
+* platform/gtk/TestExpectations:
+
 2014-02-07  Grzegorz Czajkowski  g.czajkow...@samsung.com
 
 Verify misspellings after lines merge/split asynchronously


Modified: trunk/LayoutTests/platform/gtk/TestExpectations (163615 => 163616)

--- trunk/LayoutTests/platform/gtk/TestExpectations	2014-02-07 09:20:03 UTC (rev 163615)
+++ trunk/LayoutTests/platform/gtk/TestExpectations	2014-02-07 10:10:55 UTC (rev 163616)
@@ -851,8 +851,6 @@
 
 webkit.org/b/120201 js/regress/emscripten-memops.html [ Pass Slow ]
 
-Bug(GTK) js/regress/stepanov_container.html [ Pass Slow ]
-
 #
 # End of slow tests
 #
@@ -1082,7 +1080,7 @@
 webkit.org/b/40601 editing/selection/5354455-1.html [ Failure ]
 
 webkit.org/b/122121 editing/spelling/spellcheck-paste.html [ Timeout ]
-webkit.org/b/122121 editing/spelling/spelling-changed-text.html [ Timeout ]
+webkit.org/b/122121 editing/spelling/spelling-changed-text.html [ Failure Timeout ]
 
 # Tests that fail across all platforms.
 # Even though some platforms don't skip these tests, there are platform-specific
@@ -1346,7 +1344,6 @@
 webkit.org/b/108370 editing/spelling/spelling-should-select-multiple-words.html [ Skip ]
 webkit.org/b/108370 editing/spelling/spelling-with-punctuation-selection.html [ Skip ]
 webkit.org/b/108370 editing/spelling/spelling-with-whitespace-selection.html [ Skip ]
-webkit.org/b/108370 editing/spelling/spelling-changed-text.html [ Failure ]
 
 webkit.org/b/107118 fast/canvas/canvas-quadratic-same-endpoint.html [ Failure ]
 


Modified: trunk/LayoutTests/platform/gtk-wk2/TestExpectations (163615 => 163616)

--- trunk/LayoutTests/platform/gtk-wk2/TestExpectations	2014-02-07 09:20:03 UTC (rev 163615)
+++ trunk/LayoutTests/platform/gtk-wk2/TestExpectations	2014-02-07 10:10:55 UTC (rev 163616)
@@ -287,8 +287,6 @@
 # Tests timing out
 #
 
-Bug(GTK) fast/dom/Window/window-postmessage-clone.html [ Timeout ]
-
 Bug(GTK) plugins/evaluate-js-after-removing-plugin-element.html [ Timeout ]
 Bug(GTK) plugins/reloadplugins-and-pages.html [ Timeout ]
 
@@ -368,7 +366,7 @@
 Bug(GTK) fast/css/bidi-override-in-anonymous-block.html [ Failure ]
 Bug(GTK) fast/css/disabled-author-styles.html [ Failure ]
 Bug(GTK) fast/dom/rtl-scroll-to-leftmost-and-resize.html [ Failure ]
-Bug(GTK) fast/dom/Window/window-postmessage-clone.html [ Failure ]
+Bug(GTK) fast/dom/Window/window-postmessage-clone.html [ Failure Timeout ]
 Bug(GTK) fast/dynamic/window-resize-scrollbars-test.html [ Failure ]
 Bug(GTK) fast/events/backspace-navigates-back.html [ Failure ]
 Bug(GTK) fast/events/keydown-leftright-keys.html [ Failure ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [162600] trunk/Source/WebCore

[changseok . oh]

Title: [162600] trunk/Source/WebCore








Revision 162600
Author changseok...@collabora.com
Date 2014-01-23 00:10:47 -0800 (Thu, 23 Jan 2014)


Log Message
Unreviewed build fix for gles after r162565. Add missing definitions.

* platform/graphics/opengl/GraphicsContext3DOpenGLES.cpp:
(WebCore::GraphicsContext3D::drawArraysInstanced):
(WebCore::GraphicsContext3D::drawElementsInstanced):
(WebCore::GraphicsContext3D::vertexAttribDivisor):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGLES.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (162599 => 162600)

--- trunk/Source/WebCore/ChangeLog	2014-01-23 07:53:48 UTC (rev 162599)
+++ trunk/Source/WebCore/ChangeLog	2014-01-23 08:10:47 UTC (rev 162600)
@@ -1,3 +1,12 @@
+2014-01-23  ChangSeok Oh  changseok...@collabora.com
+
+Unreviewed build fix for gles after r162565. Add missing definitions.
+
+* platform/graphics/opengl/GraphicsContext3DOpenGLES.cpp:
+(WebCore::GraphicsContext3D::drawArraysInstanced):
+(WebCore::GraphicsContext3D::drawElementsInstanced):
+(WebCore::GraphicsContext3D::vertexAttribDivisor):
+
 2014-01-22  Carlos Garcia Campos  cgar...@igalia.com
 
 [GLIB] Use GUniquePtr instead of GOwnPtr


Modified: trunk/Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGLES.cpp (162599 => 162600)

--- trunk/Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGLES.cpp	2014-01-23 07:53:48 UTC (rev 162599)
+++ trunk/Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGLES.cpp	2014-01-23 08:10:47 UTC (rev 162600)
@@ -206,7 +206,29 @@
 ::glClearDepthf(depth);
 }
 
+void GraphicsContext3D::drawArraysInstanced(GC3Denum mode, GC3Dint first, GC3Dsizei count, GC3Dsizei primcount)
+{
+UNUSED_PARAM(mode);
+UNUSED_PARAM(first);
+UNUSED_PARAM(count);
+UNUSED_PARAM(primcount);
+}
 
+void GraphicsContext3D::drawElementsInstanced(GC3Denum mode, GC3Dsizei count, GC3Denum type, GC3Dintptr offset, GC3Dsizei primcount)
+{
+UNUSED_PARAM(mode);
+UNUSED_PARAM(count);
+UNUSED_PARAM(type);
+UNUSED_PARAM(offset);
+UNUSED_PARAM(primcount);
+}
+
+void GraphicsContext3D::vertexAttribDivisor(GC3Duint index, GC3Duint divisor)
+{
+UNUSED_PARAM(index);
+UNUSED_PARAM(divisor);
+}
+
 Extensions3D* GraphicsContext3D::getExtensions()
 {
 if (!m_extensions)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [162683] trunk

[changseok . oh]

Title: [162683] trunk








Revision 162683
Author changseok...@collabora.com
Date 2014-01-23 20:12:23 -0800 (Thu, 23 Jan 2014)


Log Message
Dragging from inner side of video to outside causes a crash
https://bugs.webkit.org/show_bug.cgi?id=126338

Reviewed by Jer Noble.

Source/WebCore:

The crash happens while dragging mouse cursor through timeline control to outside
of video region. This is beacause media controls are selected with the drag.
The media controls disappear when mouse cursor goes outside of video though
the dragging/selection proceeds. If once media controls are hidden, related element
lose their renderers. However the drag is still under going. it requires shadowPseudoId
of the selected controls. Untorntunately, SliderThumbElement/SliderContainerElement
don't return a static value for the shadowPseudoId unlike other media controls,
but they need a renderer to determine it. This is the reason of crash.

Test: media/media-controller-drag-crash.html

* html/shadow/SliderThumbElement.cpp:
(WebCore::SliderThumbElement::shadowPseudoId):
(WebCore::SliderContainerElement::shadowPseudoId):

LayoutTests:

This tests that dragging through timeslider control to outside of video causes a crash.
The crash happened on both gtk+ and efl ports not using MEDIA_CONTROL_SCRIPT.

* media/media-controller-drag-crash-expected.txt: Added.
* media/media-controller-drag-crash.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/shadow/SliderThumbElement.cpp


Added Paths

trunk/LayoutTests/media/media-controller-drag-crash-expected.txt
trunk/LayoutTests/media/media-controller-drag-crash.html




Diff

Modified: trunk/LayoutTests/ChangeLog (162682 => 162683)

--- trunk/LayoutTests/ChangeLog	2014-01-24 03:52:30 UTC (rev 162682)
+++ trunk/LayoutTests/ChangeLog	2014-01-24 04:12:23 UTC (rev 162683)
@@ -1,3 +1,16 @@
+2014-01-23  ChangSeok Oh  changseok...@collabora.com
+
+Dragging from inner side of video to outside causes a crash
+https://bugs.webkit.org/show_bug.cgi?id=126338
+
+Reviewed by Jer Noble.
+
+This tests that dragging through timeslider control to outside of video causes a crash.
+The crash happened on both gtk+ and efl ports not using MEDIA_CONTROL_SCRIPT.
+
+* media/media-controller-drag-crash-expected.txt: Added.
+* media/media-controller-drag-crash.html: Added.
+
 2014-01-23  Jon Honeycutt  jhoneyc...@apple.com
 
 Assertion failure in WebCore::PseudoElement::didRecalcStyle()


Added: trunk/LayoutTests/media/media-controller-drag-crash-expected.txt (0 => 162683)

--- trunk/LayoutTests/media/media-controller-drag-crash-expected.txt	(rev 0)
+++ trunk/LayoutTests/media/media-controller-drag-crash-expected.txt	2014-01-24 04:12:23 UTC (rev 162683)
@@ -0,0 +1,9 @@
+Test that dragging through the timebar causes a crash.
+
+
+EVENT(canplaythrough)
+RUN(video.play())
+Mouse dragging.
+No crash. PASS.
+END OF TEST
+


Added: trunk/LayoutTests/media/media-controller-drag-crash.html (0 => 162683)

--- trunk/LayoutTests/media/media-controller-drag-crash.html	(rev 0)
+++ trunk/LayoutTests/media/media-controller-drag-crash.html	2014-01-24 04:12:23 UTC (rev 162683)
@@ -0,0 +1,59 @@
+!DOCTYPE html
+html
+  head
+titleDragging through timebar test/title
+script src=""
+script src=""
+script src=""
+script
+  if (window.testRunner)
+testRunner.dumpAsText();
+
+  function test()
+  {
+run('video.play()');
+
+if (window.eventSender) {
+  consoleWrite(Mouse dragging.);
+
+  var timelineCoordinate;
+  try {
+timelineCoordinate = mediaControlsButtonCoordinates(video, timeline);
+  } catch (exception) {
+failTest(exception.description);
+return;
+  }
+  var x = timelineCoordinate[0];
+  var y = timelineCoordinate[1];
+
+  eventSender.dragMode = false;
+  eventSender.mouseMoveTo(x, y - 100);
+  eventSender.mouseDown();
+  eventSender.mouseMoveTo(x, y);
+  eventSender.mouseMoveTo(x, y + 100);
+}
+window.setTimeout(finish(), 1000);
+  }
+
+  function finish()
+  {
+consoleWrite(No crash. PASS.)
+if (window.eventSender)
+  eventSender.mouseUp();
+endTest();
+  }
+
+  function start()
+  {
+findMediaElement();
+waitForEvent('canplaythrough', test);
+video.src = "" content/test);
+  }
+/script
+  /head
+  body _onload_=start()
+pTest that dragging through the timebar causes a crash./p
+video controls/video
+  /body
+/html
+


Modified: trunk/Source/WebCore/ChangeLog (162682 => 162683)

--- trunk/Source/WebCore/ChangeLog	2014-01-24 03:52:30 UTC (rev 162682)
+++ trunk/Source/WebCore/ChangeLog	2014-01-24 04:12:23 UTC 

[webkit-changes] [162510] trunk/LayoutTests

[changseok . oh]

Title: [162510] trunk/LayoutTests








Revision 162510
Author changseok...@collabora.com
Date 2014-01-22 00:50:42 -0800 (Wed, 22 Jan 2014)


Log Message
Unreviewed GTK gardening

Remove test expectations for passed tests.
fast/parser/document-write-basic.html is marked crash but passed.
fast/forms/select-live-pseudo-selectors.html is marked crash but passed.

* platform/gtk-wk2/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/gtk-wk2/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (162509 => 162510)

--- trunk/LayoutTests/ChangeLog	2014-01-22 08:40:08 UTC (rev 162509)
+++ trunk/LayoutTests/ChangeLog	2014-01-22 08:50:42 UTC (rev 162510)
@@ -1,3 +1,13 @@
+2014-01-22  ChangSeok Oh  changseok...@collabora.com
+
+Unreviewed GTK gardening
+
+Remove test expectations for passed tests.
+fast/parser/document-write-basic.html is marked crash but passed.
+fast/forms/select-live-pseudo-selectors.html is marked crash but passed.
+
+* platform/gtk-wk2/TestExpectations:
+
 2014-01-22  Alexey Proskuryakov  a...@apple.com
 
 inspector-protocol/page/deny-X-FrameOption.html is very flaky


Modified: trunk/LayoutTests/platform/gtk-wk2/TestExpectations (162509 => 162510)

--- trunk/LayoutTests/platform/gtk-wk2/TestExpectations	2014-01-22 08:40:08 UTC (rev 162509)
+++ trunk/LayoutTests/platform/gtk-wk2/TestExpectations	2014-01-22 08:50:42 UTC (rev 162510)
@@ -198,10 +198,6 @@
 
 webkit.org/b/82020 plugins/netscape-dom-access-and-reload.html [ Crash Pass ]
 
-Bug(GTK) fast/parser/document-write-basic.html [ Crash ]
-
-Bug(GTK) fast/forms/select-live-pseudo-selectors.html [ Crash ]
-
 webkit.org/b/124556 http/tests/xmlhttprequest/access-control-repeated-failed-preflight-crash.html [ Crash Timeout ]
 
 #






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [162448] trunk/Tools

[changseok . oh]

Title: [162448] trunk/Tools








Revision 162448
Author changseok...@collabora.com
Date 2014-01-21 10:22:54 -0800 (Tue, 21 Jan 2014)


Log Message
[GTK] Fix a c++11 compliance issue for fontconfig
https://bugs.webkit.org/show_bug.cgi?id=127283

Reviewed by Martin Robinson.

fontconfig-2.8.0 is not compliant with C++11. So I propose to apply a
hotfix until bumping fontconfig up.

* gtk/jhbuild.modules:
* gtk/patches/fontconfig-C-11-requires-a-space-between-literal-and-identifier.patch: Added.

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/gtk/jhbuild.modules


Added Paths

trunk/Tools/gtk/patches/fontconfig-C-11-requires-a-space-between-literal-and-identifier.patch




Diff

Modified: trunk/Tools/ChangeLog (162447 => 162448)

--- trunk/Tools/ChangeLog	2014-01-21 18:06:06 UTC (rev 162447)
+++ trunk/Tools/ChangeLog	2014-01-21 18:22:54 UTC (rev 162448)
@@ -1,3 +1,16 @@
+2014-01-21  ChangSeok Oh  changseok...@collabora.com
+
+[GTK] Fix a c++11 compliance issue for fontconfig
+https://bugs.webkit.org/show_bug.cgi?id=127283
+
+Reviewed by Martin Robinson.
+
+fontconfig-2.8.0 is not compliant with C++11. So I propose to apply a
+hotfix until bumping fontconfig up.
+
+* gtk/jhbuild.modules:
+* gtk/patches/fontconfig-C-11-requires-a-space-between-literal-and-identifier.patch: Added.
+
 2014-01-21  Peter Molnar  pmolnar.u-sze...@partner.samsung.com
 
 run-jsc-stress-tests should accept --child-processes option and WEBKIT_TEST_CHILD_PROCESSES env.var


Modified: trunk/Tools/gtk/jhbuild.modules (162447 => 162448)

--- trunk/Tools/gtk/jhbuild.modules	2014-01-21 18:06:06 UTC (rev 162447)
+++ trunk/Tools/gtk/jhbuild.modules	2014-01-21 18:22:54 UTC (rev 162448)
@@ -193,6 +193,7 @@
 repo=freedesktop.org
 hash=sha256:fa2a1c6eea654d9fce7a4b1220f10c99cdec848dccaf1625c01f076b31382335
 md5sum=77e15a92006ddc2adbb06f840d591c0e
+  patch file=fontconfig-C-11-requires-a-space-between-literal-and-identifier.patch strip=1/
 /branch
   /autotools
 


Added: trunk/Tools/gtk/patches/fontconfig-C-11-requires-a-space-between-literal-and-identifier.patch (0 => 162448)

--- trunk/Tools/gtk/patches/fontconfig-C-11-requires-a-space-between-literal-and-identifier.patch	(rev 0)
+++ trunk/Tools/gtk/patches/fontconfig-C-11-requires-a-space-between-literal-and-identifier.patch	2014-01-21 18:22:54 UTC (rev 162448)
@@ -0,0 +1,30 @@
+From 7069d717e982adcf8e1d300cbd10eec6322a65c9 Mon Sep 17 00:00:00 2001
+From: Akira TAGOH ak...@tagoh.org
+Date: Sun, 22 Apr 2012 21:40:44 +0900
+Subject: [PATCH] C++11 requires a space between literal and identifier
+
+Reported by Buganini
+---
+ fontconfig/fontconfig.h | 6 +++---
+ 1 file changed, 3 insertions(+), 3 deletions(-)
+
+diff --git a/fontconfig/fontconfig.h b/fontconfig/fontconfig.h
+index 0e2ca50..b27ccb5 100644
+--- a/fontconfig/fontconfig.h
 b/fontconfig/fontconfig.h
+@@ -112,9 +112,9 @@ typedef int		FcBool;
+ #define FC_DECORATIVE	decorative	/* Bool - true if style is a decorative variant */
+ #define FC_LCD_FILTER	lcdfilter		/* Int */
+ 
+-#define FC_CACHE_SUFFIX		.cache-FC_CACHE_VERSION
+-#define FC_DIR_CACHE_FILE	fonts.cache-FC_CACHE_VERSION
+-#define FC_USER_CACHE_FILE	.fonts.cache-FC_CACHE_VERSION
++#define FC_CACHE_SUFFIX		.cache- FC_CACHE_VERSION
++#define FC_DIR_CACHE_FILE	fonts.cache- FC_CACHE_VERSION
++#define FC_USER_CACHE_FILE	.fonts.cache- FC_CACHE_VERSION
+ 
+ /* Adjust outline rasterizer */
+ #define FC_CHAR_WIDTH	charwidth	/* Int */
+-- 
+1.8.3.2
+






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [162060] trunk/Tools

[changseok . oh]

Title: [162060] trunk/Tools








Revision 162060
Author changseok...@collabora.com
Date 2014-01-15 01:55:05 -0800 (Wed, 15 Jan 2014)


Log Message
[EFL] Change test font installed path to webkitgtk-font-tests
https://bugs.webkit.org/show_bug.cgi?id=126723

Reviewed by Gyuyoung Kim.

I'd like to change the test fonts installed directory from 'webkitgtk-test-fonts-0.0.3'
to 'webkitgtk-test-fonts'. webkitgtk-test-fonts-0.0.3 doesn't match the path
hard-coded in FontManagement.cpp#105

* DumpRenderTree/PlatformEfl.cmake:
* WebKitTestRunner/PlatformEfl.cmake:
* efl/jhbuild.modules:

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/DumpRenderTree/PlatformEfl.cmake
trunk/Tools/WebKitTestRunner/PlatformEfl.cmake
trunk/Tools/efl/jhbuild.modules




Diff

Modified: trunk/Tools/ChangeLog (162059 => 162060)

--- trunk/Tools/ChangeLog	2014-01-15 09:45:26 UTC (rev 162059)
+++ trunk/Tools/ChangeLog	2014-01-15 09:55:05 UTC (rev 162060)
@@ -1,3 +1,18 @@
+2014-01-15  ChangSeok Oh  changseok...@collabora.com
+
+[EFL] Change test font installed path to webkitgtk-font-tests
+https://bugs.webkit.org/show_bug.cgi?id=126723
+
+Reviewed by Gyuyoung Kim.
+
+I'd like to change the test fonts installed directory from 'webkitgtk-test-fonts-0.0.3'
+to 'webkitgtk-test-fonts'. webkitgtk-test-fonts-0.0.3 doesn't match the path
+hard-coded in FontManagement.cpp#105
+
+* DumpRenderTree/PlatformEfl.cmake:
+* WebKitTestRunner/PlatformEfl.cmake:
+* efl/jhbuild.modules:
+
 2014-01-14  Ryosuke Niwa  rn...@webkit.org
 
 Make DoYouEvenBench runnable by run-perf-tests


Modified: trunk/Tools/DumpRenderTree/PlatformEfl.cmake (162059 => 162060)

--- trunk/Tools/DumpRenderTree/PlatformEfl.cmake	2014-01-15 09:45:26 UTC (rev 162059)
+++ trunk/Tools/DumpRenderTree/PlatformEfl.cmake	2014-01-15 09:55:05 UTC (rev 162060)
@@ -77,4 +77,4 @@
 # FIXME: DOWNLOADED_FONTS_DIR should not hardcode the directory
 # structure. See https://bugs.webkit.org/show_bug.cgi?id=81475.
 add_definitions(-DFONTS_CONF_DIR=${TOOLS_DIR}/DumpRenderTree/gtk/fonts
--DDOWNLOADED_FONTS_DIR=${CMAKE_SOURCE_DIR}/WebKitBuild/Dependencies/Source/webkitgtk-test-fonts-0.0.3)
+-DDOWNLOADED_FONTS_DIR=${CMAKE_SOURCE_DIR}/WebKitBuild/Dependencies/Source/webkitgtk-test-fonts)


Modified: trunk/Tools/WebKitTestRunner/PlatformEfl.cmake (162059 => 162060)

--- trunk/Tools/WebKitTestRunner/PlatformEfl.cmake	2014-01-15 09:45:26 UTC (rev 162059)
+++ trunk/Tools/WebKitTestRunner/PlatformEfl.cmake	2014-01-15 09:55:05 UTC (rev 162060)
@@ -78,7 +78,7 @@
 # FIXME: DOWNLOADED_FONTS_DIR should not hardcode the directory
 # structure. See https://bugs.webkit.org/show_bug.cgi?id=81475.
 add_definitions(-DFONTS_CONF_DIR=${TOOLS_DIR}/DumpRenderTree/gtk/fonts
--DDOWNLOADED_FONTS_DIR=${CMAKE_SOURCE_DIR}/WebKitBuild/Dependencies/Source/webkitgtk-test-fonts-0.0.3)
+-DDOWNLOADED_FONTS_DIR=${CMAKE_SOURCE_DIR}/WebKitBuild/Dependencies/Source/webkitgtk-test-fonts)
 
 if (ENABLE_ACCESSIBILITY)
 list(APPEND WebKitTestRunner_INCLUDE_DIRECTORIES


Modified: trunk/Tools/efl/jhbuild.modules (162059 => 162060)

--- trunk/Tools/efl/jhbuild.modules	2014-01-15 09:45:26 UTC (rev 162059)
+++ trunk/Tools/efl/jhbuild.modules	2014-01-15 09:55:05 UTC (rev 162060)
@@ -77,6 +77,7 @@
   autotools id=fonts
  skip-autogen=true
 branch module=downloads/mrobinson/webkitgtk-test-fonts/webkitgtk-test-fonts-0.0.3.tar.gz version=0.0.3
+checkoutdir=webkitgtk-test-fonts
 repo=github.com
 hash=sha256:4a0a01f00855997cdcc7201f164b33a4e4144e8eadf40a5e542a1c448e035de5
 md5sum=10e74de1a8ba961d9037994d427b1dd2 size=16981642






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [162055] trunk/Source/WebCore

[changseok . oh]

Title: [162055] trunk/Source/WebCore








Revision 162055
Author changseok...@collabora.com
Date 2014-01-14 23:41:41 -0800 (Tue, 14 Jan 2014)


Log Message
Unreviewed build fix after r161980.

CachedResourcesLoader.h should not belong to the CSS_SHADERS flag since it is used
out of the flag so it causes a compile failure when svg and css shaders are concurrently disabled.

* css/StyleResolver.cpp:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/StyleResolver.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (162054 => 162055)

--- trunk/Source/WebCore/ChangeLog	2014-01-15 07:18:40 UTC (rev 162054)
+++ trunk/Source/WebCore/ChangeLog	2014-01-15 07:41:41 UTC (rev 162055)
@@ -1,3 +1,12 @@
+2014-01-14  ChangSeok Oh  changseok...@collabora.com
+
+Unreviewed build fix after r161980.
+
+CachedResourcesLoader.h should not belong to the CSS_SHADERS flag since it is used
+out of the flag so it causes a compile failure when svg and css shaders are concurrently disabled.
+
+* css/StyleResolver.cpp:
+
 2014-01-14  Andreas Kling  akl...@apple.com
 
 Pack ResourceResponse harder.


Modified: trunk/Source/WebCore/css/StyleResolver.cpp (162054 => 162055)

--- trunk/Source/WebCore/css/StyleResolver.cpp	2014-01-15 07:18:40 UTC (rev 162054)
+++ trunk/Source/WebCore/css/StyleResolver.cpp	2014-01-15 07:41:41 UTC (rev 162055)
@@ -54,6 +54,7 @@
 #include CSSTimingFunctionValue.h
 #include CSSValueList.h
 #include CachedImage.h
+#include CachedResourceLoader.h
 #include CalculationValue.h
 #include ContentData.h
 #include Counter.h
@@ -158,10 +159,6 @@
 #include WebKitCSSShaderValue.h
 #endif
 
-#if ENABLE(CSS_SHAPES)
-#include CachedResourceLoader.h
-#endif
-
 #if ENABLE(DASHBOARD_SUPPORT)
 #include DashboardRegion.h
 #endif






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [161652] trunk/Source/WebCore

[changseok . oh]

Title: [161652] trunk/Source/WebCore








Revision 161652
Author changseok...@collabora.com
Date 2014-01-10 10:53:12 -0800 (Fri, 10 Jan 2014)


Log Message
Unreviewed build fix since r161589.

The changeset causes a compile failure with --no-svg.

* platform/graphics/FontFastPath.cpp:
(WebCore::Font::drawGlyphBuffer):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/FontFastPath.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (161651 => 161652)

--- trunk/Source/WebCore/ChangeLog	2014-01-10 18:49:22 UTC (rev 161651)
+++ trunk/Source/WebCore/ChangeLog	2014-01-10 18:53:12 UTC (rev 161652)
@@ -1,3 +1,12 @@
+2014-01-10  ChangSeok Oh  changseok...@collabora.com
+
+Unreviewed build fix since r161589.
+
+The changeset causes a compile failure with --no-svg.
+
+* platform/graphics/FontFastPath.cpp:
+(WebCore::Font::drawGlyphBuffer):
+
 2014-01-10  Przemyslaw Szymanski  p.szymans...@samsung.com
 
 [WebGL] Removing unnecessary pointer checks


Modified: trunk/Source/WebCore/platform/graphics/FontFastPath.cpp (161651 => 161652)

--- trunk/Source/WebCore/platform/graphics/FontFastPath.cpp	2014-01-10 18:49:22 UTC (rev 161651)
+++ trunk/Source/WebCore/platform/graphics/FontFastPath.cpp	2014-01-10 18:53:12 UTC (rev 161652)
@@ -228,8 +228,9 @@
 #if ENABLE(SVG_FONTS)
 if (renderingContext  fontData-isSVGFont())
 renderingContext-drawSVGGlyphs(context, fontData, glyphBuffer, lastFrom, nextGlyph - lastFrom, startPoint);
-else {
+else
 #endif
+{
 drawGlyphs(context, fontData, glyphBuffer, lastFrom, nextGlyph - lastFrom, startPoint);
 point.setX(nextX);
 }






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [161503] trunk/LayoutTests

[changseok . oh]

Title: [161503] trunk/LayoutTests








Revision 161503
Author changseok...@collabora.com
Date 2014-01-08 08:02:32 -0800 (Wed, 08 Jan 2014)


Log Message
Unreviewed GTK gardening.

setFileInputFiles.html was removed after r161380. string-replacement-outofmemory.html,
toString-and-valueOf-override.html and exceptions-thrown-in-callbacks.html
were moved into other directory.

* platform/gtk-wk2/TestExpectations:
* platform/gtk/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/gtk/TestExpectations
trunk/LayoutTests/platform/gtk-wk2/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (161502 => 161503)

--- trunk/LayoutTests/ChangeLog	2014-01-08 15:45:48 UTC (rev 161502)
+++ trunk/LayoutTests/ChangeLog	2014-01-08 16:02:32 UTC (rev 161503)
@@ -1,3 +1,14 @@
+2014-01-08  ChangSeok Oh  changseok...@collabora.com
+
+Unreviewed GTK gardening.
+
+setFileInputFiles.html was removed after r161380. string-replacement-outofmemory.html,
+toString-and-valueOf-override.html and exceptions-thrown-in-callbacks.html
+were moved into other directory.
+
+* platform/gtk-wk2/TestExpectations:
+* platform/gtk/TestExpectations:
+
 2014-01-08  Alexey Proskuryakov  a...@apple.com
 
 REGRESSION: webgl/1.0.2/conformance/textures/tex-image-and-sub-image-2d-with-video-rgb565.html is very flaky


Modified: trunk/LayoutTests/platform/gtk/TestExpectations (161502 => 161503)

--- trunk/LayoutTests/platform/gtk/TestExpectations	2014-01-08 15:45:48 UTC (rev 161502)
+++ trunk/LayoutTests/platform/gtk/TestExpectations	2014-01-08 16:02:32 UTC (rev 161503)
@@ -813,9 +813,9 @@
 Bug(GTK) [ Debug ] js/dfg-uint8array.html [ Pass Slow ]
 Bug(GTK) [ Debug ] js/dfg-uint8clampedarray.html [ Pass Slow ]
 Bug(GTK) [ Debug ] js/dom/random-array-gc-stress.html [ Pass Slow ]
+Bug(GTK) [ Debug ] js/dom/string-replacement-outofmemory.html [ Pass Slow ]
+Bug(GTK) [ Debug ] js/dom/toString-and-valueOf-override.html [ Pass Slow ]
 Bug(GTK) [ Debug ] js/regress/method-on-number.html [ Pass Slow ]
-Bug(GTK) [ Debug ] js/string-replacement-outofmemory.html [ Pass Slow ]
-Bug(GTK) [ Debug ] js/toString-and-valueOf-override.html [ Pass Slow ]
 Bug(GTK) [ Debug ] fast/frames/lots-of-iframes.html [ Pass Slow ]
 Bug(GTK) [ Debug ] fast/frames/lots-of-objects.html [ Pass Slow ]
 Bug(GTK) [ Debug ] fast/workers/worker-cloneport.html [ Pass Slow ]
@@ -906,7 +906,6 @@
 webkit.org/b/122571 inspector-protocol/debugger/removeBreakpoint.html [ Timeout Pass ]
 webkit.org/b/122571 inspector-protocol/debugger/setVariableValue.html [ Timeout Pass ]
 webkit.org/b/122571 inspector-protocol/debugger/call-frame-this-strict.html [ Timeout Pass ]
-webkit.org/b/122571 inspector-protocol/dom/setFileInputFiles.html [ Timeout Pass ]
 webkit.org/b/122571 inspector-protocol/dom/request-child-nodes-depth.html [ Timeout Pass ]
 webkit.org/b/122571 inspector-protocol/dom/focus.html [ Timeout Pass ]
 webkit.org/b/122571 inspector-protocol/input/dispatchMouseEvent.html [ Timeout Pass ]


Modified: trunk/LayoutTests/platform/gtk-wk2/TestExpectations (161502 => 161503)

--- trunk/LayoutTests/platform/gtk-wk2/TestExpectations	2014-01-08 15:45:48 UTC (rev 161502)
+++ trunk/LayoutTests/platform/gtk-wk2/TestExpectations	2014-01-08 16:02:32 UTC (rev 161503)
@@ -251,7 +251,7 @@
 Bug(GTK) fast/forms/select/menulist-type-ahead-find.html [ Pass Timeout ]
 Bug(GTK) fast/forms/select/optgroup-disabled.html [ Pass Timeout ]
 Bug(GTK) fast/forms/select-selected.html [ Pass Timeout ]
-Bug(GTK) js/exceptions-thrown-in-callbacks.html [ Failure Pass ]
+Bug(GTK) js/dom/exceptions-thrown-in-callbacks.html [ Failure Pass ]
 Bug(GTK) fast/loader/fragment-after-redirect-gets-back-entry.html [ Failure Pass ]
 Bug(GTK) fast/writing-mode/japanese-ruby-horizontal-bt.html [ Failure Pass ]
 Bug(GTK) fast/writing-mode/japanese-ruby-vertical-lr.html [ Failure Pass ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [161187] trunk/Tools

[changseok . oh]

Title: [161187] trunk/Tools








Revision 161187
Author changseok...@collabora.com
Date 2014-01-01 05:35:13 -0800 (Wed, 01 Jan 2014)


Log Message
[GTK][WK2] Back items are shown in reverse order in MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=126354

Reviewed by Carlos Garcia Campos.

The latest visited site for backward history should be placed on the top of a history stack
as a common behavior. However currently its order is reverse.

* MiniBrowser/gtk/BrowserWindow.c:
(browserWindowUpdateNavigationActions):

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/MiniBrowser/gtk/BrowserWindow.c




Diff

Modified: trunk/Tools/ChangeLog (161186 => 161187)

--- trunk/Tools/ChangeLog	2014-01-01 01:08:13 UTC (rev 161186)
+++ trunk/Tools/ChangeLog	2014-01-01 13:35:13 UTC (rev 161187)
@@ -1,3 +1,16 @@
+2014-01-01  ChangSeok Oh  changseok...@collabora.com
+
+[GTK][WK2] Back items are shown in reverse order in MiniBrowser
+https://bugs.webkit.org/show_bug.cgi?id=126354
+
+Reviewed by Carlos Garcia Campos.
+
+The latest visited site for backward history should be placed on the top of a history stack
+as a common behavior. However currently its order is reverse.
+
+* MiniBrowser/gtk/BrowserWindow.c:
+(browserWindowUpdateNavigationActions):
+
 2013-12-30  Martin Robinson  mrobin...@igalia.com
 
 [GTK] Make the output directory of GObject unit tests binaries consistent with the CMake build


Modified: trunk/Tools/MiniBrowser/gtk/BrowserWindow.c (161186 => 161187)

--- trunk/Tools/MiniBrowser/gtk/BrowserWindow.c	2014-01-01 01:08:13 UTC (rev 161186)
+++ trunk/Tools/MiniBrowser/gtk/BrowserWindow.c	2014-01-01 13:35:13 UTC (rev 161187)
@@ -230,14 +230,14 @@
 gtk_widget_set_sensitive(window-backItem, webkit_web_view_can_go_back(window-webView));
 gtk_widget_set_sensitive(window-forwardItem, webkit_web_view_can_go_forward(window-webView));
 
-GList *list = webkit_back_forward_list_get_back_list_with_limit(backForwadlist, 10);
+GList *list = g_list_reverse(webkit_back_forward_list_get_back_list_with_limit(backForwadlist, 10));
 gtk_menu_tool_button_set_menu(GTK_MENU_TOOL_BUTTON(window-backItem),
-  browserWindowCreateBackForwardMenu(window, list));
+browserWindowCreateBackForwardMenu(window, list));
 g_list_free(list);
 
 list = webkit_back_forward_list_get_forward_list_with_limit(backForwadlist, 10);
 gtk_menu_tool_button_set_menu(GTK_MENU_TOOL_BUTTON(window-forwardItem),
-  browserWindowCreateBackForwardMenu(window, list));
+browserWindowCreateBackForwardMenu(window, list));
 g_list_free(list);
 }
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [161136] trunk/Source/WebCore

[changseok . oh]

Title: [161136] trunk/Source/WebCore








Revision 161136
Author changseok...@collabora.com
Date 2013-12-29 21:12:17 -0800 (Sun, 29 Dec 2013)


Log Message
Remove unused functions in GraphicsContext3D.cpp
https://bugs.webkit.org/show_bug.cgi?id=126265

Reviewed by Andreas Kling.

platformGraphicsContext3D, platformTexture and platformLayer in GC3D.cpp
seem not used by any ports.

No new tests, no functionality changed.

* platform/graphics/GraphicsContext3D.cpp:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/GraphicsContext3D.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (161135 => 161136)

--- trunk/Source/WebCore/ChangeLog	2013-12-30 01:27:55 UTC (rev 161135)
+++ trunk/Source/WebCore/ChangeLog	2013-12-30 05:12:17 UTC (rev 161136)
@@ -1,3 +1,17 @@
+2013-12-29  ChangSeok Oh  changseok...@collabora.com
+
+Remove unused functions in GraphicsContext3D.cpp
+https://bugs.webkit.org/show_bug.cgi?id=126265
+
+Reviewed by Andreas Kling.
+
+platformGraphicsContext3D, platformTexture and platformLayer in GC3D.cpp
+seem not used by any ports.
+
+No new tests, no functionality changed.
+
+* platform/graphics/GraphicsContext3D.cpp:
+
 2013-12-29  Gyuyoung Kim  gyuyoung@samsung.com
 
 Fix build error on 64bit debug build.


Modified: trunk/Source/WebCore/platform/graphics/GraphicsContext3D.cpp (161135 => 161136)

--- trunk/Source/WebCore/platform/graphics/GraphicsContext3D.cpp	2013-12-30 01:27:55 UTC (rev 161135)
+++ trunk/Source/WebCore/platform/graphics/GraphicsContext3D.cpp	2013-12-30 05:12:17 UTC (rev 161136)
@@ -1799,25 +1799,6 @@
 }
 }
 
-#if !PLATFORM(BLACKBERRY)  !PLATFORM(GTK)  !PLATFORM(EFL)  !PLATFORM(MAC)  !PLATFORM(WIN)  !PLATFORM(NIX)
-PlatformGraphicsContext3D GraphicsContext3D::platformGraphicsContext3D() const
-{
-return NullPlatformGraphicsContext3D;
-}
-
-Platform3DObject GraphicsContext3D::platformTexture() const
-{
-return NullPlatform3DObject;
-}
-
-#if USE(ACCELERATED_COMPOSITING)
-PlatformLayer* GraphicsContext3D::platformLayer() const
-{
-return 0;
-}
-#endif
-#endif
-
 } // namespace WebCore
 
 #endif // USE(3D_GRAPHICS)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [161086] trunk/Source/WebCore

[changseok . oh]

Title: [161086] trunk/Source/WebCore








Revision 161086
Author changseok...@collabora.com
Date 2013-12-26 01:24:36 -0800 (Thu, 26 Dec 2013)


Log Message
Unreviewed build fix after r159526.
isBoxValue is used at out of ENABLE_CSS_SHAPES gaurd. It causes a compile failure.
So I moved isBoxValue to out side of ENABLE_CSS_SHAPES.

* css/CSSParser.cpp:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/CSSParser.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (161085 => 161086)

--- trunk/Source/WebCore/ChangeLog	2013-12-26 07:32:04 UTC (rev 161085)
+++ trunk/Source/WebCore/ChangeLog	2013-12-26 09:24:36 UTC (rev 161086)
@@ -1,3 +1,11 @@
+2013-12-26  ChangSeok Oh  changseok...@collabora.com
+
+Unreviewed build fix after r159526.
+isBoxValue is used at out of ENABLE_CSS_SHAPES gaurd. It causes a compile failure.
+So I moved isBoxValue to out side of ENABLE_CSS_SHAPES.
+
+* css/CSSParser.cpp:
+
 2013-12-25  Gyuyoung Kim  gyuyoung@samsung.com
 
 Set m_pos as private in InlineIterator, and use getter and setter functions.


Modified: trunk/Source/WebCore/css/CSSParser.cpp (161085 => 161086)

--- trunk/Source/WebCore/css/CSSParser.cpp	2013-12-26 07:32:04 UTC (rev 161085)
+++ trunk/Source/WebCore/css/CSSParser.cpp	2013-12-26 09:24:36 UTC (rev 161086)
@@ -5818,7 +5818,6 @@
 return shape;
 }
 
-#if ENABLE(CSS_SHAPES)
 static bool isBoxValue(CSSValueID valueId)
 {
 switch (valueId) {
@@ -5833,6 +5832,7 @@
 return false;
 }
 
+#if ENABLE(CSS_SHAPES)
 PassRefPtrCSSValue CSSParser::parseShapeProperty(CSSPropertyID propId)
 {
 if (!RuntimeEnabledFeatures::sharedFeatures().cssShapesEnabled())






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [160991] trunk/Source/WebCore

[changseok . oh]

Title: [160991] trunk/Source/WebCore








Revision 160991
Author changseok...@collabora.com
Date 2013-12-23 02:18:51 -0800 (Mon, 23 Dec 2013)


Log Message
[GTK][WK2] WebGL is not working with GLES
https://bugs.webkit.org/show_bug.cgi?id=126138

Reviewed by Martin Robinson.

m_texture has been unnecessarily regenerated. It's generated in GraphicsContext3D
constructor for offscreen rendering. And m_compositorTexture is used by only Mac port.
They create it in their GraphicsContext3D constructor so that we don't need to recreate it
in GC3DOpenGLES::reshapeFBOs.

No new tests since no functionality changed.

* platform/graphics/cairo/GraphicsContext3DCairo.cpp:
(WebCore::GraphicsContext3D::~GraphicsContext3D):
* platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:
(WebCore::GraphicsContext3D::reshapeFBOs):
* platform/graphics/opengl/GraphicsContext3DOpenGLES.cpp:
(WebCore::GraphicsContext3D::reshapeFBOs):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/cairo/GraphicsContext3DCairo.cpp
trunk/Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGL.cpp
trunk/Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGLES.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (160990 => 160991)

--- trunk/Source/WebCore/ChangeLog	2013-12-23 09:22:08 UTC (rev 160990)
+++ trunk/Source/WebCore/ChangeLog	2013-12-23 10:18:51 UTC (rev 160991)
@@ -1,3 +1,24 @@
+2013-12-23  ChangSeok Oh  changseok...@collabora.com
+
+[GTK][WK2] WebGL is not working with GLES
+https://bugs.webkit.org/show_bug.cgi?id=126138
+
+Reviewed by Martin Robinson.
+
+m_texture has been unnecessarily regenerated. It's generated in GraphicsContext3D
+constructor for offscreen rendering. And m_compositorTexture is used by only Mac port.
+They create it in their GraphicsContext3D constructor so that we don't need to recreate it
+in GC3DOpenGLES::reshapeFBOs.
+
+No new tests since no functionality changed.
+
+* platform/graphics/cairo/GraphicsContext3DCairo.cpp:
+(WebCore::GraphicsContext3D::~GraphicsContext3D):
+* platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:
+(WebCore::GraphicsContext3D::reshapeFBOs):
+* platform/graphics/opengl/GraphicsContext3DOpenGLES.cpp:
+(WebCore::GraphicsContext3D::reshapeFBOs):
+
 2013-12-22  Benjamin Poulain  bpoul...@apple.com
 
 Create a skeleton for CSS Selector code generation


Modified: trunk/Source/WebCore/platform/graphics/cairo/GraphicsContext3DCairo.cpp (160990 => 160991)

--- trunk/Source/WebCore/platform/graphics/cairo/GraphicsContext3DCairo.cpp	2013-12-23 09:22:08 UTC (rev 160990)
+++ trunk/Source/WebCore/platform/graphics/cairo/GraphicsContext3DCairo.cpp	2013-12-23 10:18:51 UTC (rev 160991)
@@ -159,8 +159,11 @@
 return;
 
 makeContextCurrent();
-::glDeleteTextures(1, m_texture);
-::glDeleteTextures(1, m_compositorTexture);
+if (m_texture)
+::glDeleteTextures(1, m_texture);
+if (m_compositorTexture)
+::glDeleteTextures(1, m_compositorTexture);
+
 if (m_attrs.antialias) {
 ::glDeleteRenderbuffers(1, m_multisampleColorBuffer);
 if (m_attrs.stencil || m_attrs.depth)


Modified: trunk/Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGL.cpp (160990 => 160991)

--- trunk/Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGL.cpp	2013-12-23 09:22:08 UTC (rev 160990)
+++ trunk/Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGL.cpp	2013-12-23 10:18:51 UTC (rev 160991)
@@ -124,12 +124,18 @@
 mustRestoreFBO = true;
 ::glBindFramebufferEXT(GL_FRAMEBUFFER_EXT, m_fbo);
 }
+
+ASSERT(m_texture);
 ::glBindTexture(GL_TEXTURE_2D, m_texture);
 ::glTexImage2D(GL_TEXTURE_2D, 0, m_internalColorFormat, width, height, 0, colorFormat, GL_UNSIGNED_BYTE, 0);
 ::glFramebufferTexture2DEXT(GL_FRAMEBUFFER_EXT, GL_COLOR_ATTACHMENT0_EXT, GL_TEXTURE_2D, m_texture, 0);
-::glBindTexture(GL_TEXTURE_2D, m_compositorTexture);
-::glTexImage2D(GL_TEXTURE_2D, 0, m_internalColorFormat, width, height, 0, colorFormat, GL_UNSIGNED_BYTE, 0);
-::glBindTexture(GL_TEXTURE_2D, 0);
+
+if (m_compositorTexture) {
+::glBindTexture(GL_TEXTURE_2D, m_compositorTexture);
+::glTexImage2D(GL_TEXTURE_2D, 0, m_internalColorFormat, width, height, 0, colorFormat, GL_UNSIGNED_BYTE, 0);
+::glBindTexture(GL_TEXTURE_2D, 0);
+}
+
 if (!m_attrs.antialias  (m_attrs.stencil || m_attrs.depth)) {
 ::glBindRenderbufferEXT(GL_RENDERBUFFER_EXT, m_depthStencilBuffer);
 ::glRenderbufferStorageEXT(GL_RENDERBUFFER_EXT, internalDepthStencilFormat, width, height);


Modified: trunk/Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGLES.cpp (160990 => 160991)

--- trunk/Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGLES.cpp	2013-12-23 09:22:08 UTC (rev 160990)
+++ trunk/Source/WebC

[webkit-changes] [160273] trunk/Source/WebCore

[changseok . oh]

Title: [160273] trunk/Source/WebCore








Revision 160273
Author changseok...@collabora.com
Date 2013-12-07 08:50:25 -0800 (Sat, 07 Dec 2013)


Log Message
Unreviewed. Build fix for gtk port after r160260.

* loader/cache/CachedImage.h: Add missing a header.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/loader/cache/CachedImage.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (160272 => 160273)

--- trunk/Source/WebCore/ChangeLog	2013-12-07 16:33:39 UTC (rev 160272)
+++ trunk/Source/WebCore/ChangeLog	2013-12-07 16:50:25 UTC (rev 160273)
@@ -1,3 +1,9 @@
+2013-12-07  ChangSeok Oh  changseok...@collabora.com
+
+Unreviewed. Build fix for gtk port after r160260.
+
+* loader/cache/CachedImage.h: Add missing a header.
+
 2013-12-07  Gustavo Noronha Silva  g...@gnome.org
 
 ubuntu software center hits _XReadEvents() error


Modified: trunk/Source/WebCore/loader/cache/CachedImage.h (160272 => 160273)

--- trunk/Source/WebCore/loader/cache/CachedImage.h	2013-12-07 16:33:39 UTC (rev 160272)
+++ trunk/Source/WebCore/loader/cache/CachedImage.h	2013-12-07 16:50:25 UTC (rev 160273)
@@ -24,6 +24,7 @@
 #define CachedImage_h
 
 #include CachedResource.h
+#include Image.h
 #include ImageObserver.h
 #include IntRect.h
 #include IntSizeHash.h






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [159913] trunk/Source/WebKit2

[changseok . oh]

Title: [159913] trunk/Source/WebKit2








Revision 159913
Author changseok...@collabora.com
Date 2013-12-01 23:48:48 -0800 (Sun, 01 Dec 2013)


Log Message
Unreviewed Gtk port Build fix after r159903

* UIProcess/DrawingAreaProxyImpl.cpp:
(WebKit::DrawingAreaProxyImpl::layerHostingModeDidChange):
(WebKit::DrawingAreaProxyImpl::update):
(WebKit::DrawingAreaProxyImpl::didUpdateBackingStoreState):
(WebKit::DrawingAreaProxyImpl::sendUpdateBackingStoreState):
(WebKit::DrawingAreaProxyImpl::waitForAndDispatchDidUpdateBackingStoreState):
* UIProcess/gtk/WebFullScreenManagerProxyGtk.cpp:
(WebKit::WebFullScreenManagerProxy::invalidate):
* UIProcess/gtk/WebInspectorProxyGtk.cpp:
(WebKit::WebInspectorProxy::platformCreateInspectorPage):
* UIProcess/gtk/WebPageProxyGtk.cpp:
(WebKit::WebPageProxy::setAcceleratedCompositingWindowId):

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/DrawingAreaProxyImpl.cpp
trunk/Source/WebKit2/UIProcess/gtk/WebFullScreenManagerProxyGtk.cpp
trunk/Source/WebKit2/UIProcess/gtk/WebInspectorProxyGtk.cpp
trunk/Source/WebKit2/UIProcess/gtk/WebPageProxyGtk.cpp




Diff

Modified: trunk/Source/WebKit2/ChangeLog (159912 => 159913)

--- trunk/Source/WebKit2/ChangeLog	2013-12-02 05:44:16 UTC (rev 159912)
+++ trunk/Source/WebKit2/ChangeLog	2013-12-02 07:48:48 UTC (rev 159913)
@@ -1,3 +1,20 @@
+2013-12-01  ChangSeok Oh  changseok...@collabora.com
+
+Unreviewed Gtk port Build fix after r159903
+
+* UIProcess/DrawingAreaProxyImpl.cpp:
+(WebKit::DrawingAreaProxyImpl::layerHostingModeDidChange):
+(WebKit::DrawingAreaProxyImpl::update):
+(WebKit::DrawingAreaProxyImpl::didUpdateBackingStoreState):
+(WebKit::DrawingAreaProxyImpl::sendUpdateBackingStoreState):
+(WebKit::DrawingAreaProxyImpl::waitForAndDispatchDidUpdateBackingStoreState):
+* UIProcess/gtk/WebFullScreenManagerProxyGtk.cpp:
+(WebKit::WebFullScreenManagerProxy::invalidate):
+* UIProcess/gtk/WebInspectorProxyGtk.cpp:
+(WebKit::WebInspectorProxy::platformCreateInspectorPage):
+* UIProcess/gtk/WebPageProxyGtk.cpp:
+(WebKit::WebPageProxy::setAcceleratedCompositingWindowId):
+
 2013-12-01  Sam Weinig  s...@webkit.org
 
 Give UserMessageEncoders WebProcessProxy reference (like the decoders already have)


Modified: trunk/Source/WebKit2/UIProcess/DrawingAreaProxyImpl.cpp (159912 => 159913)

--- trunk/Source/WebKit2/UIProcess/DrawingAreaProxyImpl.cpp	2013-12-02 05:44:16 UTC (rev 159912)
+++ trunk/Source/WebKit2/UIProcess/DrawingAreaProxyImpl.cpp	2013-12-02 07:48:48 UTC (rev 159913)
@@ -115,7 +115,7 @@
 
 void DrawingAreaProxyImpl::layerHostingModeDidChange()
 {
-m_webPageProxy-process()-send(Messages::DrawingArea::SetLayerHostingMode(m_webPageProxy-layerHostingMode()), m_webPageProxy-pageID());
+m_webPageProxy-process().send(Messages::DrawingArea::SetLayerHostingMode(m_webPageProxy-layerHostingMode()), m_webPageProxy-pageID());
 }
 
 void DrawingAreaProxyImpl::setBackingStoreIsDiscardable(bool isBackingStoreDiscardable)
@@ -144,7 +144,7 @@
 // FIXME: Handle the case where the view is hidden.
 
 incorporateUpdate(updateInfo);
-m_webPageProxy-process()-send(Messages::DrawingArea::DidUpdate(), m_webPageProxy-pageID());
+m_webPageProxy-process().send(Messages::DrawingArea::DidUpdate(), m_webPageProxy-pageID());
 }
 
 void DrawingAreaProxyImpl::didUpdateBackingStoreState(uint64_t backingStoreStateID, const UpdateInfo updateInfo, const LayerTreeContext layerTreeContext)
@@ -156,7 +156,7 @@
 m_isWaitingForDidUpdateBackingStoreState = false;
 
 // Stop the responsiveness timer that was started in sendUpdateBackingStoreState.
-m_webPageProxy-process()-responsivenessTimer()-stop();
+m_webPageProxy-process().responsivenessTimer()-stop();
 
 #if USE(ACCELERATED_COMPOSITING)
 if (layerTreeContext != m_layerTreeContext) {
@@ -280,13 +280,13 @@
 
 m_isWaitingForDidUpdateBackingStoreState = respondImmediatelyOrNot == RespondImmediately;
 
-m_webPageProxy-process()-send(Messages::DrawingArea::UpdateBackingStoreState(m_nextBackingStoreStateID, respondImmediatelyOrNot == RespondImmediately, m_webPageProxy-deviceScaleFactor(), m_size, m_scrollOffset), m_webPageProxy-pageID());
+m_webPageProxy-process().send(Messages::DrawingArea::UpdateBackingStoreState(m_nextBackingStoreStateID, respondImmediatelyOrNot == RespondImmediately, m_webPageProxy-deviceScaleFactor(), m_size, m_scrollOffset), m_webPageProxy-pageID());
 m_scrollOffset = IntSize();
 
 if (m_isWaitingForDidUpdateBackingStoreState) {
 // Start the responsiveness timer. We will stop it when we hear back from the WebProcess
 // in didUpdateBackingStoreState.
-m_webPageProxy-process()-responsivenessTimer()-start();
+m_webPageProxy-process().responsivenessTimer()-start();
 }
 
 #if USE(ACCELERATED_COMPOSITING)
@@ -304,7 +304,7 @@
 
 if (!m_webPageProxy-i

[webkit-changes] [158275] trunk/Source/WebCore

[changseok . oh]

Title: [158275] trunk/Source/WebCore








Revision 158275
Author changseok...@collabora.com
Date 2013-10-30 10:21:10 -0700 (Wed, 30 Oct 2013)


Log Message
Unguard Element::childShouldCreateRenderer
https://bugs.webkit.org/show_bug.cgi?id=123496

Reviewed by Andreas Kling.

Make Element::childShouldCreateRenderer normally accessible. Guarding it with flags
just leaves potential build issues.

No new tests since no functionality changed.

* dom/Element.cpp:
(WebCore::Element::childShouldCreateRenderer):
* dom/Element.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/Element.cpp
trunk/Source/WebCore/dom/Element.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (158274 => 158275)

--- trunk/Source/WebCore/ChangeLog	2013-10-30 16:44:21 UTC (rev 158274)
+++ trunk/Source/WebCore/ChangeLog	2013-10-30 17:21:10 UTC (rev 158275)
@@ -1,3 +1,19 @@
+2013-10-30  ChangSeok Oh  changseok...@collabora.com
+
+Unguard Element::childShouldCreateRenderer
+https://bugs.webkit.org/show_bug.cgi?id=123496
+
+Reviewed by Andreas Kling.
+
+Make Element::childShouldCreateRenderer normally accessible. Guarding it with flags
+just leaves potential build issues.
+
+No new tests since no functionality changed.
+
+* dom/Element.cpp:
+(WebCore::Element::childShouldCreateRenderer):
+* dom/Element.h:
+
 2013-10-30  Jer Noble  jer.no...@apple.com
 
 [MSE] Make MediaSourcePrivate, SourceBufferPrivate classes RefCounted.


Modified: trunk/Source/WebCore/dom/Element.cpp (158274 => 158275)

--- trunk/Source/WebCore/dom/Element.cpp	2013-10-30 16:44:21 UTC (rev 158274)
+++ trunk/Source/WebCore/dom/Element.cpp	2013-10-30 17:21:10 UTC (rev 158275)
@@ -2619,17 +2619,15 @@
 }
 #endif
 
-
-#if ENABLE(SVG)
 bool Element::childShouldCreateRenderer(const Node* child) const
 {
+#if ENABLE(SVG)
 // Only create renderers for SVG elements whose parents are SVG elements, or for proper svg xmlns=svgNS subdocuments.
 if (child-isSVGElement())
 return child-hasTagName(SVGNames::svgTag) || isSVGElement();
-
+#endif
 return ContainerNode::childShouldCreateRenderer(child);
 }
-#endif
 
 #if ENABLE(FULLSCREEN_API)
 void Element::webkitRequestFullscreen()


Modified: trunk/Source/WebCore/dom/Element.h (158274 => 158275)

--- trunk/Source/WebCore/dom/Element.h	2013-10-30 16:44:21 UTC (rev 158274)
+++ trunk/Source/WebCore/dom/Element.h	2013-10-30 17:21:10 UTC (rev 158275)
@@ -479,10 +479,8 @@
 // to event listeners, and prevents DOMActivate events from being sent at all.
 virtual bool isDisabledFormControl() const { return false; }
 
-
-#if ENABLE(SVG) || ENABLE(MATHML)
 virtual bool childShouldCreateRenderer(const Node*) const OVERRIDE;
-#endif
+
 #if ENABLE(SVG)
 bool hasPendingResources() const;
 void setHasPendingResources();






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [157915] trunk/Source

[changseok . oh]

Title: [157915] trunk/Source








Revision 157915
Author changseok...@collabora.com
Date 2013-10-23 23:43:11 -0700 (Wed, 23 Oct 2013)


Log Message
Unreviewed build fix since r157823.
FilterOperation::getOperationType() is renamed FilterOperation::type().

Source/WebCore:

* platform/graphics/texmap/TextureMapperGL.cpp:
(WebCore::prepareFilterProgram):
(WebCore::TextureMapperGL::drawTexture):
(WebCore::TextureMapperGL::drawUsingCustomFilter):
(WebCore::TextureMapperGL::drawFiltered):
(WebCore::BitmapTextureGL::applyFilters):
* platform/graphics/texmap/coordinated/CoordinatedGraphicsScene.cpp:
(WebCore::CoordinatedGraphicsScene::injectCachedCustomFilterPrograms):

Source/WebKit2:

* Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.cpp:
(CoreIPCencode):
* WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp:
(WebKit::CoordinatedLayerTreeHost::checkCustomFilterProgramProxies):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/texmap/TextureMapperGL.cpp
trunk/Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsScene.cpp
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.cpp
trunk/Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (157914 => 157915)

--- trunk/Source/WebCore/ChangeLog	2013-10-24 06:31:21 UTC (rev 157914)
+++ trunk/Source/WebCore/ChangeLog	2013-10-24 06:43:11 UTC (rev 157915)
@@ -1,3 +1,17 @@
+2013-10-23  ChangSeok Oh  changseok...@collabora.com
+
+Unreviewed build fix since r157823.
+FilterOperation::getOperationType() is renamed FilterOperation::type().
+
+* platform/graphics/texmap/TextureMapperGL.cpp:
+(WebCore::prepareFilterProgram):
+(WebCore::TextureMapperGL::drawTexture):
+(WebCore::TextureMapperGL::drawUsingCustomFilter):
+(WebCore::TextureMapperGL::drawFiltered):
+(WebCore::BitmapTextureGL::applyFilters):
+* platform/graphics/texmap/coordinated/CoordinatedGraphicsScene.cpp:
+(WebCore::CoordinatedGraphicsScene::injectCachedCustomFilterPrograms):
+
 2013-10-23  Ryuan Choi  ryuan.c...@samsung.com
 
 Unreviewed build fix on CMake based ports when CMAKE_BUILD_TYPE is not given.


Modified: trunk/Source/WebCore/platform/graphics/texmap/TextureMapperGL.cpp (157914 => 157915)

--- trunk/Source/WebCore/platform/graphics/texmap/TextureMapperGL.cpp	2013-10-24 06:31:21 UTC (rev 157914)
+++ trunk/Source/WebCore/platform/graphics/texmap/TextureMapperGL.cpp	2013-10-24 06:43:11 UTC (rev 157915)
@@ -471,7 +471,7 @@
 RefPtrGraphicsContext3D context = program-context();
 context-useProgram(program-programID());
 
-switch (operation.getOperationType()) {
+switch (operation.type()) {
 case FilterOperation::GRAYSCALE:
 case FilterOperation::SEPIA:
 case FilterOperation::SATURATE:
@@ -567,7 +567,7 @@
 if (filter) {
 if (data().filterInfo-contentTexture)
 filterContentTextureID = toBitmapTextureGL(data().filterInfo-contentTexture.get())-id();
-options |= optionsForFilterType(filter-getOperationType(), data().filterInfo-pass);
+options |= optionsForFilterType(filter-type(), data().filterInfo-pass);
 if (filter-affectsOpacity())
 flags |= ShouldBlend;
 }
@@ -879,7 +879,7 @@
 bool TextureMapperGL::drawUsingCustomFilter(BitmapTexture target, const BitmapTexture source, const FilterOperation filter)
 {
 RefPtrCustomFilterRenderer renderer;
-switch (filter.getOperationType()) {
+switch (filter.type()) {
 case FilterOperation::CUSTOM: {
 // WebKit2 pipeline is using the CustomFilterOperation, that's because of the de-serialization that
 // happens in CoordinatedGraphicsArgumentCoders.
@@ -933,7 +933,7 @@
 void TextureMapperGL::drawFiltered(const BitmapTexture sampler, const BitmapTexture* contentTexture, const FilterOperation filter, int pass)
 {
 // For standard filters, we always draw the whole texture without transformations.
-TextureMapperShaderProgram::Options options = optionsForFilterType(filter.getOperationType(), pass);
+TextureMapperShaderProgram::Options options = optionsForFilterType(filter.type(), pass);
 RefPtrTextureMapperShaderProgram program = data().sharedGLData().getShaderProgram(options);
 ASSERT(program);
 
@@ -968,9 +968,9 @@
 RefPtrFilterOperation filter = filters.operations()[i];
 ASSERT(filter);
 
-bool custom = isCustomFilter(filter-getOperationType());
+bool custom = isCustomFilter(filter-type());
 
-int numPasses = getPassesRequiredForFilter(filter-getOperationType());
+int numPasses = getPassesRequiredForFilter(filter-type());
 for (int j = 0; j  numPasses; ++j) {
 bool last = (i == filters.size() - 1)  (j == numPasses - 1);
 if (custom ||

[webkit-changes] [157634] trunk/Source/WebCore

[changseok . oh]

Title: [157634] trunk/Source/WebCore








Revision 157634
Author changseok...@collabora.com
Date 2013-10-18 09:05:08 -0700 (Fri, 18 Oct 2013)


Log Message
Unreviewed build fix for --no-svg option.
m_svgStyle of RenderStyle is guarded with the ENABLE_SVG flag.

* rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::RenderStyle):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/style/RenderStyle.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (157633 => 157634)

--- trunk/Source/WebCore/ChangeLog	2013-10-18 15:23:51 UTC (rev 157633)
+++ trunk/Source/WebCore/ChangeLog	2013-10-18 16:05:08 UTC (rev 157634)
@@ -1,3 +1,11 @@
+2013-10-18  ChangSeok Oh  changseok...@collabora.com
+
+Unreviewed build fix for --no-svg option.
+m_svgStyle of RenderStyle is guarded with the ENABLE_SVG flag.
+
+* rendering/style/RenderStyle.cpp:
+(WebCore::RenderStyle::RenderStyle):
+
 2013-10-17  Brady Eidson  beid...@apple.com
 
 Cleanup the Modules group in the WebCore.xcodeproj


Modified: trunk/Source/WebCore/rendering/style/RenderStyle.cpp (157633 => 157634)

--- trunk/Source/WebCore/rendering/style/RenderStyle.cpp	2013-10-18 15:23:51 UTC (rev 157633)
+++ trunk/Source/WebCore/rendering/style/RenderStyle.cpp	2013-10-18 16:05:08 UTC (rev 157634)
@@ -135,7 +135,9 @@
 , rareNonInheritedData(StyleRareNonInheritedData::create())
 , rareInheritedData(StyleRareInheritedData::create())
 , inherited(StyleInheritedData::create())
+#if ENABLE(SVG)
 , m_svgStyle(SVGRenderStyle::create())
+#endif
 {
 setBitDefaults();
 }






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [157124] trunk/Source/WebCore

[changseok . oh]

Title: [157124] trunk/Source/WebCore








Revision 157124
Author changseok...@collabora.com
Date 2013-10-08 11:25:16 -0700 (Tue, 08 Oct 2013)


Log Message
[GTK] Leak: GdkEvent retured by gtk_get_current_event is not freed.
https://bugs.webkit.org/show_bug.cgi?id=122506

Reviewed by Gustavo Noronha Silva.

Gdk event returned by gtk_get_current_event should be freed after using it.

No functionality changed.

* platform/gtk/PopupMenuGtk.cpp:
(WebCore::PopupMenuGtk::show):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/gtk/PopupMenuGtk.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (157123 => 157124)

--- trunk/Source/WebCore/ChangeLog	2013-10-08 18:03:29 UTC (rev 157123)
+++ trunk/Source/WebCore/ChangeLog	2013-10-08 18:25:16 UTC (rev 157124)
@@ -1,3 +1,17 @@
+2013-10-08  ChangSeok Oh  changseok...@collabora.com
+
+[GTK] Leak: GdkEvent retured by gtk_get_current_event is not freed.
+https://bugs.webkit.org/show_bug.cgi?id=122506
+
+Reviewed by Gustavo Noronha Silva.
+
+Gdk event returned by gtk_get_current_event should be freed after using it.
+
+No functionality changed.
+
+* platform/gtk/PopupMenuGtk.cpp:
+(WebCore::PopupMenuGtk::show):
+
 2013-10-08  Ryosuke Niwa  rn...@webkit.org
 
 Use references in EventRetargeter::calculateEventPath and EventRetargeter::eventTargetRespectingTargetRules


Modified: trunk/Source/WebCore/platform/gtk/PopupMenuGtk.cpp (157123 => 157124)

--- trunk/Source/WebCore/platform/gtk/PopupMenuGtk.cpp	2013-10-08 18:03:29 UTC (rev 157123)
+++ trunk/Source/WebCore/platform/gtk/PopupMenuGtk.cpp	2013-10-08 18:25:16 UTC (rev 157124)
@@ -28,10 +28,11 @@
 #include PopupMenuGtk.h
 
 #include FrameView.h
-#include wtf/gobject/GOwnPtr.h
+#include GOwnPtrGtk.h
 #include GtkUtilities.h
 #include HostWindow.h
 #include gtk/gtk.h
+#include wtf/gobject/GOwnPtr.h
 #include wtf/text/CString.h
 
 namespace WebCore {
@@ -87,7 +88,8 @@
 IntPoint menuPosition = convertWidgetPointToScreenPoint(GTK_WIDGET(view-hostWindow()-platformPageClient()), view-contentsToWindow(rect.location()));
 menuPosition.move(0, rect.height());
 
-m_popup-popUp(rect.size(), menuPosition, size, index, gtk_get_current_event());
+GOwnPtrGdkEvent currentEvent(gtk_get_current_event());
+m_popup-popUp(rect.size(), menuPosition, size, index, currentEvent.get());
 
 // GTK can refuse to actually open the menu when mouse grabs fails.
 // Ensure WebCore does not go into some pesky state.






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [156333] trunk/Source/WebKit2

[changseok . oh]

Title: [156333] trunk/Source/WebKit2








Revision 156333
Author changseok...@collabora.com
Date 2013-09-24 07:25:09 -0700 (Tue, 24 Sep 2013)


Log Message
[EFL] Build failed at ProcessLauncherEfl.cpp
https://bugs.webkit.org/show_bug.cgi?id=121826

Reviewed by Gyuyoung Kim.

Fixed a build failure with adding socket.h.

* UIProcess/Launcher/efl/ProcessLauncherEfl.cpp:

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/Launcher/efl/ProcessLauncherEfl.cpp




Diff

Modified: trunk/Source/WebKit2/ChangeLog (156332 => 156333)

--- trunk/Source/WebKit2/ChangeLog	2013-09-24 14:24:07 UTC (rev 156332)
+++ trunk/Source/WebKit2/ChangeLog	2013-09-24 14:25:09 UTC (rev 156333)
@@ -1,3 +1,14 @@
+2013-09-24  ChangSeok Oh  changseok...@collabora.com
+
+[EFL] Build failed at ProcessLauncherEfl.cpp
+https://bugs.webkit.org/show_bug.cgi?id=121826
+
+Reviewed by Gyuyoung Kim.
+
+Fixed a build failure with adding socket.h.
+
+* UIProcess/Launcher/efl/ProcessLauncherEfl.cpp:
+
 2013-09-23  Patrick Gansterer  par...@webkit.org
 
 use NOMINMAX instead of #define min min


Modified: trunk/Source/WebKit2/UIProcess/Launcher/efl/ProcessLauncherEfl.cpp (156332 => 156333)

--- trunk/Source/WebKit2/UIProcess/Launcher/efl/ProcessLauncherEfl.cpp	2013-09-24 14:24:07 UTC (rev 156332)
+++ trunk/Source/WebKit2/UIProcess/Launcher/efl/ProcessLauncherEfl.cpp	2013-09-24 14:25:09 UTC (rev 156333)
@@ -28,6 +28,7 @@
 #include WebCore/NetworkingContext.h
 #include WebCore/ResourceHandle.h
 #include WebCore/RunLoop.h
+#include sys/socket.h
 #include wtf/StdLibExtras.h
 #include wtf/text/CString.h
 #include wtf/text/WTFString.h






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [156287] trunk/Source/WebKit2

[changseok . oh]

Title: [156287] trunk/Source/WebKit2








Revision 156287
Author changseok...@collabora.com
Date 2013-09-23 13:09:41 -0700 (Mon, 23 Sep 2013)


Log Message
[GTK][WK2] A plugin dirtyRect within iframe remains after moving to a different page.
https://bugs.webkit.org/show_bug.cgi?id=121600

Reviewed by Gustavo Noronha Silva.

Nowhere to destroy NetscapePlugin::m_platformPluginWidget even after destroying
an instance of NetscapePlugin. So the created GtkWidget remains visible.

* WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp:
(WebKit::NetscapePlugin::platformDestroy):

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp




Diff

Modified: trunk/Source/WebKit2/ChangeLog (156286 => 156287)

--- trunk/Source/WebKit2/ChangeLog	2013-09-23 19:46:46 UTC (rev 156286)
+++ trunk/Source/WebKit2/ChangeLog	2013-09-23 20:09:41 UTC (rev 156287)
@@ -1,3 +1,16 @@
+2013-09-23  ChangSeok Oh  changseok...@collabora.com
+
+[GTK][WK2] A plugin dirtyRect within iframe remains after moving to a different page.
+https://bugs.webkit.org/show_bug.cgi?id=121600
+
+Reviewed by Gustavo Noronha Silva.
+
+Nowhere to destroy NetscapePlugin::m_platformPluginWidget even after destroying
+an instance of NetscapePlugin. So the created GtkWidget remains visible.
+
+* WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp:
+(WebKit::NetscapePlugin::platformDestroy):
+
 2013-09-23  Sam Weinig  s...@webkit.org
 
 Add back the SharedWorkerStrategy to prevent crashing.


Modified: trunk/Source/WebKit2/WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp (156286 => 156287)

--- trunk/Source/WebKit2/WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp	2013-09-23 19:46:46 UTC (rev 156286)
+++ trunk/Source/WebKit2/WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp	2013-09-23 20:09:41 UTC (rev 156287)
@@ -297,6 +297,13 @@
 XFreePixmap(hostDisplay, m_drawable);
 m_drawable = 0;
 }
+
+#if PLATFORM(GTK)
+if (m_platformPluginWidget) {
+gtk_widget_destroy(m_platformPluginWidget);
+m_platformPluginWidget = 0;
+}
+#endif
 }
 
 bool NetscapePlugin::platformInvalidate(const IntRect)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [156282] trunk

[changseok . oh]

Title: [156282] trunk








Revision 156282
Author changseok...@collabora.com
Date 2013-09-23 12:02:44 -0700 (Mon, 23 Sep 2013)


Log Message
[Texmap] Reloading a webgl page doesn't work
https://bugs.webkit.org/show_bug.cgi?id=120593

Reviewed by Noam Rosenthal.

Source/WebCore:

Let GraphicsLayerTextureMapper know it needs to detach the platform layer when a GraphicsContext3D is destroyed.

Test: fast/canvas/webgl/webgl-reload-crash.html

* platform/graphics/GraphicsContext3DPrivate.cpp:
(WebCore::GraphicsContext3DPrivate::~GraphicsContext3DPrivate):
* platform/graphics/texmap/GraphicsLayerTextureMapper.h:
* platform/graphics/texmap/TextureMapperPlatformLayer.h:

LayoutTests:

Add a new test case to check if a crash occurs while reloading a page which contains webgl.

* fast/canvas/webgl/webgl-reload-crash-expected.txt: Added.
* fast/canvas/webgl/webgl-reload-crash.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/GraphicsContext3DPrivate.cpp
trunk/Source/WebCore/platform/graphics/texmap/GraphicsLayerTextureMapper.h
trunk/Source/WebCore/platform/graphics/texmap/TextureMapperPlatformLayer.h


Added Paths

trunk/LayoutTests/fast/canvas/webgl/webgl-reload-crash-expected.txt
trunk/LayoutTests/fast/canvas/webgl/webgl-reload-crash.html




Diff

Modified: trunk/LayoutTests/ChangeLog (156281 => 156282)

--- trunk/LayoutTests/ChangeLog	2013-09-23 18:21:24 UTC (rev 156281)
+++ trunk/LayoutTests/ChangeLog	2013-09-23 19:02:44 UTC (rev 156282)
@@ -1,3 +1,15 @@
+2013-09-23  ChangSeok Oh  changseok...@collabora.com
+
+[Texmap] Reloading a webgl page doesn't work
+https://bugs.webkit.org/show_bug.cgi?id=120593
+
+Reviewed by Noam Rosenthal.
+
+Add a new test case to check if a crash occurs while reloading a page which contains webgl.
+
+* fast/canvas/webgl/webgl-reload-crash-expected.txt: Added.
+* fast/canvas/webgl/webgl-reload-crash.html: Added.
+
 2013-09-23  Alexey Proskuryakov  a...@apple.com
 
 Audio object garbage collection is incorrect (media/audio-garbage-collect.html test is flaky)


Added: trunk/LayoutTests/fast/canvas/webgl/webgl-reload-crash-expected.txt (0 => 156282)

--- trunk/LayoutTests/fast/canvas/webgl/webgl-reload-crash-expected.txt	(rev 0)
+++ trunk/LayoutTests/fast/canvas/webgl/webgl-reload-crash-expected.txt	2013-09-23 19:02:44 UTC (rev 156282)
@@ -0,0 +1,2 @@
+PASS. You didn't crash.
+


Added: trunk/LayoutTests/fast/canvas/webgl/webgl-reload-crash.html (0 => 156282)

--- trunk/LayoutTests/fast/canvas/webgl/webgl-reload-crash.html	(rev 0)
+++ trunk/LayoutTests/fast/canvas/webgl/webgl-reload-crash.html	2013-09-23 19:02:44 UTC (rev 156282)
@@ -0,0 +1,43 @@
+!DOCTYPE html
+html
+  head
+script src="" /script
+script
+function runTest()
+{
+  if (sessionStorage.count == 10) {
+delete sessionStorage.count;
+if (window.testRunner)
+  testRunner.notifyDone();
+  } else {
+var canvas = document.getElementById('webgl-canvas');
+var gl = WebGLTestUtils.create3DContext(canvas);
+gl.clearColor(1, 0, 0, 1);
+gl.clear(gl.COLOR_BUFFER_BIT | gl.DEPTH_BUFFER_BIT);
+
+canvas.width = canvas.clientWidth;
+canvas.height = canvas.clientHeight;
+
+if (!sessionStorage.count)
+  sessionStorage.count = 0;
+sessionStorage.count++;
+
+setTimeout(function() { location.reload(); }, 0);
+  }
+}
+if (window.testRunner) {
+  testRunner.dumpAsText();
+  testRunner.overridePreference(WebKitAcceleratedCompositingEnabled, 1);
+  testRunner.overridePreference(WebKitWebGLEnabled, 1);
+  testRunner.waitUntilDone();
+}
+
+window._onpageshow_ = runTest;
+/script
+  /head
+  body
+divPASS. You didn't crash./div
+canvas id=webgl-canvas width=100px height=100px/canvas
+  /body
+/html
+


Modified: trunk/Source/WebCore/ChangeLog (156281 => 156282)

--- trunk/Source/WebCore/ChangeLog	2013-09-23 18:21:24 UTC (rev 156281)
+++ trunk/Source/WebCore/ChangeLog	2013-09-23 19:02:44 UTC (rev 156282)
@@ -1,3 +1,19 @@
+2013-09-23  ChangSeok Oh  changseok...@collabora.com
+
+[Texmap] Reloading a webgl page doesn't work
+https://bugs.webkit.org/show_bug.cgi?id=120593
+
+Reviewed by Noam Rosenthal.
+
+Let GraphicsLayerTextureMapper know it needs to detach the platform layer when a GraphicsContext3D is destroyed.
+
+Test: fast/canvas/webgl/webgl-reload-crash.html
+
+* platform/graphics/GraphicsContext3DPrivate.cpp:
+(WebCore::GraphicsContext3DPrivate::~GraphicsContext3DPrivate):
+* platform/graphics/texmap/GraphicsLayerTextureMapper.h:
+* platform/graphics/texmap/TextureMapperPlatformLayer.h:
+
 2013-09-23  Antti Koivisto  an...@apple.com
 
 Remove RenderObjectChildList


Modified: trunk/Source/Web

[webkit-changes] [155610] trunk/Tools

[changseok . oh]

Title: [155610] trunk/Tools








Revision 155610
Author changseok...@collabora.com
Date 2013-09-12 07:51:46 -0700 (Thu, 12 Sep 2013)


Log Message
[GTK] Add jhbuild-wayland.modules
https://bugs.webkit.org/show_bug.cgi?id=120455

Reviewed by Gustavo Noronha Silva.

Current versions of gtk+, gdk-pixbuf and glib don't fit the requirement for wayland support.
With this patch, you can build extra gtk+, gdk-pixbuf and glib through jhbuild with exporting
WEBKIT_EXTRA_MODULESETS.

* gtk/jhbuild-wayland.modules: Added.

Modified Paths

trunk/Tools/ChangeLog


Added Paths

trunk/Tools/gtk/jhbuild-wayland.modules




Diff

Modified: trunk/Tools/ChangeLog (155609 => 155610)

--- trunk/Tools/ChangeLog	2013-09-12 14:41:49 UTC (rev 155609)
+++ trunk/Tools/ChangeLog	2013-09-12 14:51:46 UTC (rev 155610)
@@ -1,3 +1,16 @@
+2013-09-12  ChangSeok Oh  changseok...@collabora.com
+
+[GTK] Add jhbuild-wayland.modules
+https://bugs.webkit.org/show_bug.cgi?id=120455
+
+Reviewed by Gustavo Noronha Silva.
+
+Current versions of gtk+, gdk-pixbuf and glib don't fit the requirement for wayland support.
+With this patch, you can build extra gtk+, gdk-pixbuf and glib through jhbuild with exporting
+WEBKIT_EXTRA_MODULESETS.
+
+* gtk/jhbuild-wayland.modules: Added.
+
 2013-09-12  Mario Sanchez Prada  mario.pr...@samsung.com
 
 [GTK][WK2] a11y tests unconditionally launching a11y daemons


Added: trunk/Tools/gtk/jhbuild-wayland.modules (0 => 155610)

--- trunk/Tools/gtk/jhbuild-wayland.modules	(rev 0)
+++ trunk/Tools/gtk/jhbuild-wayland.modules	2013-09-12 14:51:46 UTC (rev 155610)
@@ -0,0 +1,43 @@
+?xml version=1.0?
+!DOCTYPE moduleset SYSTEM moduleset.dtd
+?xml-stylesheet type=text/xsl href=""
+moduleset
+
+  !-- This file contains a set of modules to set up an enviroment for wayland support. --
+  repository type=tarball name=ftp.gnome.org
+  href=""
+
+  autotools id=gdk-pixbuf autogen-sh=configure
+ autogenargs=--disable-introspection
+dependencies
+  dep package=glib/
+/dependencies
+branch module=/pub/GNOME/sources/gdk-pixbuf/2.29/gdk-pixbuf-2.29.3.tar.xz version=2.29.3
+repo=ftp.gnome.org
+hash=sha256:f3ab2e153809ceedc3f8b9b22cdee018ffe7bbec2d2a8b5154e0ce220ea7d088/
+  /autotools
+
+  autotools id=gtk+ autogen-sh=configure
+ autogenargs=--disable-introspection --enable-x11-backend --enable-wayland-backend
+dependencies
+  dep package=glib/
+  dep package=cairo/
+  dep package=at-spi2-atk/
+  dep package=gdk-pixbuf/
+/dependencies
+branch module=/pub/GNOME/sources/gtk+/3.9/gtk+-3.9.6.tar.xz version=3.9.6
+repo=ftp.gnome.org
+hash=sha256:4d34b7cd763ca4975b8a55e587923eeefe7b3c8e08d3d01c9111900fca30c817/
+  /autotools
+
+  autotools id=glib
+ autogen-sh=configure
+ autogenargs=--disable-dtrace
+dependencies
+  dep package=libffi/
+/dependencies
+branch module=/pub/GNOME/sources/glib/2.37/glib-2.37.6.tar.xz version=2.37.6
+repo=ftp.gnome.org
+hash=sha256:01e1de3179cc58dafc0c950363530fccdefc6dda32a25aed96dd24dc23b83165/
+  /autotools
+/moduleset






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [155522] trunk/Source/WebKit2

[changseok . oh]

Title: [155522] trunk/Source/WebKit2








Revision 155522
Author changseok...@collabora.com
Date 2013-09-11 06:53:38 -0700 (Wed, 11 Sep 2013)


Log Message
Unreviewed build fix.

* GNUmakefile.list.am: Duplicated NetscapePluginModuleNone.cpp  NetscapePluginNone.cpp.
They cause build breaks of multiple definitions when targeting wayland build.

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/GNUmakefile.list.am




Diff

Modified: trunk/Source/WebKit2/ChangeLog (155521 => 155522)

--- trunk/Source/WebKit2/ChangeLog	2013-09-11 13:44:29 UTC (rev 155521)
+++ trunk/Source/WebKit2/ChangeLog	2013-09-11 13:53:38 UTC (rev 155522)
@@ -1,3 +1,10 @@
+2013-09-11  ChangSeok Oh  changseok...@collabora.com
+
+Unreviewed build fix.
+
+* GNUmakefile.list.am: Duplicated NetscapePluginModuleNone.cpp  NetscapePluginNone.cpp.
+They cause build breaks of multiple definitions when targeting wayland build.
+
 2013-09-11  Gyuyoung Kim  gyuyoung@samsung.com
 
 Generate more HTML type checks and casting


Modified: trunk/Source/WebKit2/GNUmakefile.list.am (155521 => 155522)

--- trunk/Source/WebKit2/GNUmakefile.list.am	2013-09-11 13:44:29 UTC (rev 155521)
+++ trunk/Source/WebKit2/GNUmakefile.list.am	2013-09-11 13:53:38 UTC (rev 155522)
@@ -442,7 +442,6 @@
 	Source/WebKit2/Shared/PrintInfo.h \
 	Source/WebKit2/Shared/Plugins/Netscape/NetscapePluginModule.cpp \
 	Source/WebKit2/Shared/Plugins/Netscape/NetscapePluginModule.h \
-	Source/WebKit2/Shared/Plugins/Netscape/NetscapePluginModuleNone.cpp \
 	Source/WebKit2/Shared/Plugins/Netscape/PluginInformation.cpp \
 	Source/WebKit2/Shared/Plugins/Netscape/PluginInformation.h \
 	Source/WebKit2/Shared/Plugins/NPIdentifierData.cpp \
@@ -1130,7 +1129,6 @@
 	Source/WebKit2/WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.h \
 	Source/WebKit2/WebProcess/Plugins/Netscape/NetscapePlugin.cpp \
 	Source/WebKit2/WebProcess/Plugins/Netscape/NetscapePlugin.h \
-	Source/WebKit2/WebProcess/Plugins/Netscape/NetscapePluginNone.cpp \
 	Source/WebKit2/WebProcess/Plugins/Netscape/NetscapePluginStream.cpp \
 	Source/WebKit2/WebProcess/Plugins/Netscape/NetscapePluginStream.h \
 	Source/WebKit2/WebProcess/Plugins/Netscape/NPJSObject.cpp \






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes