[webkit-changes] [WebKit/WebKit] 4a5feb: Update Slovenian (sl) translation
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 4a5febf4811eed7ea7b7ed5e5b9b8b1b9ff1afb4 https://github.com/WebKit/WebKit/commit/4a5febf4811eed7ea7b7ed5e5b9b8b1b9ff1afb4 Author: Michael Catanzaro Date: 2024-08-04 (Sun, 04 Aug 2024) Changed paths: M Source/WebCore/platform/gtk/po/sl.po Log Message: --- Update Slovenian (sl) translation https://bugs.webkit.org/show_bug.cgi?id=277606 Unreviewed translation update. * Source/WebCore/platform/gtk/po/sl.po: Canonical link: https://commits.webkit.org/281818@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] c3c753: [WPE][GTK] Web process cache suspend/resume does n...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: c3c75352f0eef0734daa4946af7a5b60ce045ccd https://github.com/WebKit/WebKit/commit/c3c75352f0eef0734daa4946af7a5b60ce045ccd Author: Michael Catanzaro Date: 2024-07-29 (Mon, 29 Jul 2024) Changed paths: M Source/WebKit/Platform/IPC/IPCUtilities.h M Source/WebKit/Platform/IPC/unix/ConnectionUnix.cpp M Source/WebKit/Shared/unix/AuxiliaryProcessMain.cpp M Source/WebKit/UIProcess/Launcher/glib/FlatpakLauncher.cpp M Source/WebKit/UIProcess/Launcher/glib/FlatpakLauncher.h M Source/WebKit/UIProcess/Launcher/glib/ProcessLauncherGLib.cpp Log Message: --- [WPE][GTK] Web process cache suspend/resume does not work, WebProcessProxy::processIdentifier is not the pid of the actual web process https://bugs.webkit.org/show_bug.cgi?id=262794 Reviewed by Carlos Garcia Campos. We'll use Unix credentials to send the actual pid of the child process to the parent process. This could be done using the WebKit IPC connection, but the code is much simpler if we create a separate socket for this. * Source/WebKit/Platform/IPC/IPCUtilities.h: * Source/WebKit/Platform/IPC/unix/ConnectionUnix.cpp: (IPC::createPlatformConnection): (IPC::sendPIDToPeer): (IPC::readPIDFromPeer): * Source/WebKit/Shared/unix/AuxiliaryProcessMain.cpp: (WebKit::AuxiliaryProcessMainCommon::parseCommandLine): * Source/WebKit/UIProcess/Launcher/glib/FlatpakLauncher.cpp: (WebKit::flatpakSpawn): * Source/WebKit/UIProcess/Launcher/glib/FlatpakLauncher.h: * Source/WebKit/UIProcess/Launcher/glib/ProcessLauncherGLib.cpp: (WebKit::ProcessLauncher::launchProcess): Canonical link: https://commits.webkit.org/281488@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 5965f5: [WPE][GTK] Unsupported browser warning on Google Docs
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 5965f597b3e11973b5e11df0f2cb53b4c388afde https://github.com/WebKit/WebKit/commit/5965f597b3e11973b5e11df0f2cb53b4c388afde Author: Michael Catanzaro Date: 2024-07-26 (Fri, 26 Jul 2024) Changed paths: M Source/WebCore/platform/glib/UserAgentQuirks.cpp Log Message: --- [WPE][GTK] Unsupported browser warning on Google Docs https://bugs.webkit.org/show_bug.cgi?id=277144 Reviewed by Carlos Garcia Campos. Updating the Chrome quirk should fix this bug. We can also update the Firefox quirk for good measure. Let's try to stay ahead of the game by using an unsubtle high version number. * Source/WebCore/platform/glib/UserAgentQuirks.cpp: (WebCore::UserAgentQuirks::stringForQuirk): Canonical link: https://commits.webkit.org/281402@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 70b7f2: Remove old CMake version checks
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 70b7f2833a02dfb59682baab4b248a0302d33810 https://github.com/WebKit/WebKit/commit/70b7f2833a02dfb59682baab4b248a0302d33810 Author: Michael Catanzaro Date: 2024-07-22 (Mon, 22 Jul 2024) Changed paths: M Source/WebCore/CMakeLists.txt M Source/cmake/OptionsGTK.cmake M Source/cmake/OptionsWPE.cmake Log Message: --- Remove old CMake version checks https://bugs.webkit.org/show_bug.cgi?id=276781 Reviewed by Carlos Garcia Campos. CMake 3.20 is our current minimum required CMake version. * Source/WebCore/CMakeLists.txt: * Source/cmake/OptionsGTK.cmake: * Source/cmake/OptionsWPE.cmake: Canonical link: https://commits.webkit.org/281189@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 3f928a: [Skia] Use after free when serializing SkColorSpace
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 3f928ad98a0e59c9121db11911238adaa291c583 https://github.com/WebKit/WebKit/commit/3f928ad98a0e59c9121db11911238adaa291c583 Author: Michael Catanzaro Date: 2024-07-16 (Tue, 16 Jul 2024) Changed paths: M Source/WebKit/Shared/skia/CoreIPCSkColorSpace.h Log Message: --- [Skia] Use after free when serializing SkColorSpace https://bugs.webkit.org/show_bug.cgi?id=276589 Reviewed by Philippe Normand. We're returning a "dangling span" that references data from a temporary SkData that has already been freed. Fix is to store the SkData. Unrelated: mark single-parameter constructors as explicit for good measure. * Source/WebKit/Shared/skia/CoreIPCSkColorSpace.h: (WebKit::CoreIPCSkColorSpace::CoreIPCSkColorSpace): (WebKit::CoreIPCSkColorSpace::dataReference const): Canonical link: https://commits.webkit.org/281006@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 2d8800: [GTK] Remove GTK 3 comment from GTK 4 web view bac...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 2d8800de7fc8d629a862b484b3302ac60c14ef80 https://github.com/WebKit/WebKit/commit/2d8800de7fc8d629a862b484b3302ac60c14ef80 Author: Michael Catanzaro Date: 2024-07-12 (Fri, 12 Jul 2024) Changed paths: M Source/WebKit/UIProcess/API/gtk/WebKitWebViewGtk.cpp M Source/WebKit/UIProcess/API/gtk/WebKitWebViewGtk3.cpp M Source/WebKit/UIProcess/API/gtk/WebKitWebViewGtk4.cpp Log Message: --- [GTK] Remove GTK 3 comment from GTK 4 web view background color docs https://bugs.webkit.org/show_bug.cgi?id=276488 Reviewed by Carlos Garcia Campos. * Source/WebKit/UIProcess/API/gtk/WebKitWebViewGtk.cpp: * Source/WebKit/UIProcess/API/gtk/WebKitWebViewGtk3.cpp: * Source/WebKit/UIProcess/API/gtk/WebKitWebViewGtk4.cpp: Canonical link: https://commits.webkit.org/280892@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 23af62: [WPE][GTK] IPC socket should use SOCK_CLOEXEC on L...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 23af623a3a7e6b6458b1f51cf2af9c2fe77b30e8 https://github.com/WebKit/WebKit/commit/23af623a3a7e6b6458b1f51cf2af9c2fe77b30e8 Author: Michael Catanzaro Date: 2024-07-11 (Thu, 11 Jul 2024) Changed paths: M Source/WTF/wtf/UniStdExtras.h M Source/WTF/wtf/playstation/UniStdExtrasPlayStation.cpp M Source/WTF/wtf/unix/UniStdExtrasUnix.cpp M Source/WebKit/Platform/IPC/unix/ConnectionUnix.cpp Log Message: --- [WPE][GTK] IPC socket should use SOCK_CLOEXEC on Linux https://bugs.webkit.org/show_bug.cgi?id=275690 Reviewed by Carlos Garcia Campos. Instead of creating the IPC socket without CLOEXEC and then setting it afterwards if requested, instead create the socket with CLOEXEC and unset it afterwards if not requested. This closes the race window where the socket may leak into a subprocess spawned by another thread (which seems unlikely, but you never know what applications will do). In practice, this ensures the server socket will never leak to a subprocess. The client socket might still get leaked because CLOEXEC has to get unset at some point for the child process to receive the socket. * Source/WTF/wtf/UniStdExtras.h: * Source/WTF/wtf/playstation/UniStdExtrasPlayStation.cpp: (WTF::unsetCloseOnExec): * Source/WTF/wtf/unix/UniStdExtrasUnix.cpp: (WTF::unsetCloseOnExec): * Source/WebKit/Platform/IPC/unix/ConnectionUnix.cpp: (IPC::createPlatformConnection): Canonical link: https://commits.webkit.org/280858@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] fff1b1: WebKitDOMEventTarget.h:95: Warning: WebKit2WebExte...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: fff1b1773bff2ef7c3b867ab019d69faa36c010d https://github.com/WebKit/WebKit/commit/fff1b1773bff2ef7c3b867ab019d69faa36c010d Author: Michael Catanzaro Date: 2024-07-03 (Wed, 03 Jul 2024) Changed paths: M Source/WebKit/WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMEventTarget.h Log Message: --- WebKitDOMEventTarget.h:95: Warning: WebKit2WebExtension: invalid "scope" annotation: only valid on callback parameters https://bugs.webkit.org/show_bug.cgi?id=276180 Unreviewed build fix. Emmanuele recommends using (type gpointer) for the GCallback parameter of webkit_dom_event_target_remove_event_listener, since it won't be called and is therefore not functioning as a callback. * Source/WebKit/WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMEventTarget.h: Canonical link: https://commits.webkit.org/280639@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] f112cc: Fix GTK/WPE build after 280115@main
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: f112cca233f9b8e36cbfd3206d68beac72127b63 https://github.com/WebKit/WebKit/commit/f112cca233f9b8e36cbfd3206d68beac72127b63 Author: Michael Catanzaro Date: 2024-06-18 (Tue, 18 Jun 2024) Changed paths: M Source/WebCore/platform/graphics/nicosia/NicosiaPlaceholderRenderingContextSource.cpp Log Message: --- Fix GTK/WPE build after 280115@main https://bugs.webkit.org/show_bug.cgi?id=275630 Unreviewed build fix. * Source/WebCore/platform/graphics/nicosia/NicosiaPlaceholderRenderingContextSource.cpp: Canonical link: https://commits.webkit.org/280140@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 5d324a: [WPE][GTK] Bubblewrap sandbox should not kill auxi...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 5d324a1c159cd01bd075f3b06081288a3b1ac25e https://github.com/WebKit/WebKit/commit/5d324a1c159cd01bd075f3b06081288a3b1ac25e Author: Michael Catanzaro Date: 2024-06-16 (Sun, 16 Jun 2024) Changed paths: M Source/WebKit/UIProcess/Launcher/glib/BubblewrapLauncher.cpp Log Message: --- [WPE][GTK] Bubblewrap sandbox should not kill auxiliary process when UI process terminates https://bugs.webkit.org/show_bug.cgi?id=275485 Reviewed by Carlos Garcia Campos. The bubblewrap sandbox should not kill auxiliary processes when the UI process terminates. Instead, let the child process terminate cleanly. The idea here is to match the behavior of unsandboxed WebKit and flatpaked WebKit and reduce the odds of bugs going unnoticed. This will allow exit handlers to run; notably, EGL termination has historically been a source of crashes. This will also avoid subverting the purpose of the watchdog thread that crashes the web porecss 10 seconds after the UI process exits. The problem is bwrap will SIGKILL the child process immediately, preventing it from doing usual cleanup. * Source/WebKit/UIProcess/Launcher/glib/BubblewrapLauncher.cpp: (WebKit::bubblewrapSpawn): Canonical link: https://commits.webkit.org/280061@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] e0c4ad: [GTK] Fix texture leaks
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: e0c4addd008abc4d193218a8e7583a6e372deeba https://github.com/WebKit/WebKit/commit/e0c4addd008abc4d193218a8e7583a6e372deeba Author: Michael Catanzaro Date: 2024-06-12 (Wed, 12 Jun 2024) Changed paths: M Source/WebKit/UIProcess/API/gtk/WebKitWebViewBase.cpp M Source/WebKit/UIProcess/gtk/ViewGestureControllerGtk.cpp Log Message: --- [GTK] Fix texture leaks https://bugs.webkit.org/show_bug.cgi?id=275377 Reviewed by Carlos Garcia Campos. * Source/WebKit/UIProcess/API/gtk/WebKitWebViewBase.cpp: (webkitWebViewBaseTakeViewSnapshot): * Source/WebKit/UIProcess/gtk/ViewGestureControllerGtk.cpp: (WebKit::ViewGestureController::beginSwipeGesture): Canonical link: https://commits.webkit.org/279978@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] eef110: [WPE][GTK] Un-deprecate webkit_back_forward_list_i...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: eef110a09e7b36a057ec4b06af82176f463dca1f https://github.com/WebKit/WebKit/commit/eef110a09e7b36a057ec4b06af82176f463dca1f Author: Michael Catanzaro Date: 2024-06-11 (Tue, 11 Jun 2024) Changed paths: M Source/WebKit/UIProcess/API/glib/WebKitBackForwardListItem.cpp M Source/WebKit/UIProcess/API/glib/WebKitBackForwardListItem.h.in M Tools/MiniBrowser/gtk/BrowserWindow.c M Tools/TestWebKitAPI/Tests/WebKitGLib/TestBackForwardList.cpp Log Message: --- [WPE][GTK] Un-deprecate webkit_back_forward_list_item_get_title() https://bugs.webkit.org/show_bug.cgi?id=275298 Reviewed by Adrian Perez de Castro. We changed our minds and are bringing back the ability to set page titles in the back/forward list. Apparently this functionality worked on macOS. It does *not* work for WPE/GTK. The page title is always equal to the URL. I have not investigated to find out why. But we should still not discourage applications from using this API if it might work in the future. * Source/WebKit/UIProcess/API/glib/WebKitBackForwardListItem.cpp: (webkit_back_forward_list_item_get_title): * Source/WebKit/UIProcess/API/glib/WebKitBackForwardListItem.h.in: * Tools/MiniBrowser/gtk/BrowserWindow.c: (browserWindowCreateBackForwardMenu): * Tools/TestWebKitAPI/Tests/WebKitGLib/TestBackForwardList.cpp: (testBackForwardListNavigation): (testWebKitWebViewSessionState): Canonical link: https://commits.webkit.org/279918@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] b3a26e: [GTK] Paste primary selection on button release, n...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: b3a26e61256043433ad22ee653568934f5ed819e https://github.com/WebKit/WebKit/commit/b3a26e61256043433ad22ee653568934f5ed819e Author: Michael Catanzaro Date: 2024-06-11 (Tue, 11 Jun 2024) Changed paths: M Source/WebCore/page/EventHandler.cpp M Source/WebCore/page/EventHandler.h Log Message: --- [GTK] Paste primary selection on button release, not on button press https://bugs.webkit.org/show_bug.cgi?id=247375 Reviewed by Carlos Garcia Campos. This changes how middle click paste works. Let's paste on mouse button up (released) rather than button down (pressed). This is inconsistent with GTK's behavior, but it matches all other platforms and is superior because it allows Epiphany to process mouse gestures first and handle the event before WebKit pastes anything. * Source/WebCore/page/EventHandler.cpp: (WebCore::EventHandler::handleMousePressEventSingleClick): (WebCore::EventHandler::handleMouseReleaseEvent): (WebCore::EventHandler::handlePasteGlobalSelection): * Source/WebCore/page/EventHandler.h: Canonical link: https://commits.webkit.org/279915@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] c14972: Fix copy/paste error in WebPageProxy::stopLoading ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: c14972b1ae139c89b18fc22f280ae8ea8b18d71d https://github.com/WebKit/WebKit/commit/c14972b1ae139c89b18fc22f280ae8ea8b18d71d Author: Michael Catanzaro Date: 2024-06-03 (Mon, 03 Jun 2024) Changed paths: M Source/WebKit/UIProcess/WebPageProxy.cpp Log Message: --- Fix copy/paste error in WebPageProxy::stopLoading log message https://bugs.webkit.org/show_bug.cgi?id=275088 Reviewed by Charlie Wolfe. * Source/WebKit/UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::stopLoading): Canonical link: https://commits.webkit.org/279685@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 86fbb6: [WPE][GTK] g_variant_builder_add_value: assertion ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 86fbb6c7dafe2bb7bb60e991ad84df6a5a9afe4f https://github.com/WebKit/WebKit/commit/86fbb6c7dafe2bb7bb60e991ad84df6a5a9afe4f Author: Michael Catanzaro Date: 2024-06-03 (Mon, 03 Jun 2024) Changed paths: M Source/WebKit/UIProcess/API/glib/WebKitWebViewSessionState.cpp Log Message: --- [WPE][GTK] g_variant_builder_add_value: assertion 'GVSB(builder)->offset < GVSB(builder)->max_items' failed when encoding session state https://bugs.webkit.org/show_bug.cgi?id=274964 Reviewed by Carlos Garcia Campos. When we encode the array of HTTP body elements, we have the open and close calls in the wrong place, such that it breaks if there are ever more than just one element. We could probably add a test for this, but it's not too likely to regress, and I didn't want to spend too long trying to work on that. * Source/WebKit/UIProcess/API/glib/WebKitWebViewSessionState.cpp: (encodeHTTPBody): Canonical link: https://commits.webkit.org/279649@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 34f750: [GTK] UI process crash in gtk_accessible_update_ch...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 34f75014ef7332cc8060d161bfd31e12a6ba49ca https://github.com/WebKit/WebKit/commit/34f75014ef7332cc8060d161bfd31e12a6ba49ca Author: Michael Catanzaro Date: 2024-05-31 (Fri, 31 May 2024) Changed paths: M Source/WebKit/UIProcess/gtk/WebDataListSuggestionsDropdownGtk.cpp M Source/WebKit/UIProcess/ios/WebDataListSuggestionsDropdownIOS.mm Log Message: --- [GTK] UI process crash in gtk_accessible_update_children https://bugs.webkit.org/show_bug.cgi?id=274927 Reviewed by Carlos Garcia Campos. We are failing to unparent the WebDataListSuggestionsDropdownGtk from the WebKitWebView before finalizing the web view. WebPageProxy calls WebDataListSuggestionsDropdown::close, but doesn't drop its ref until WebPageProxy::didCloseSuggestions is called. That happens in WebDataListSuggestionsDropdown::close, but the GTK implementation fails to chain up. Oops. I checked the color chooser and date/time picker widgets, which are implemented similarly, but didn't find any similar problem. I did notice that iOS also fails to chain up. It doesn't have this bug since it does the same work in the subclass instead, but it's surely safest to chain up here to be robust to future changes. Developers tend to get surprised when virtual function do not chain up. * Source/WebKit/UIProcess/gtk/WebDataListSuggestionsDropdownGtk.cpp: (WebKit::WebDataListSuggestionsDropdownGtk::close): * Source/WebKit/UIProcess/ios/WebDataListSuggestionsDropdownIOS.mm: (WebKit::WebDataListSuggestionsDropdownIOS::close): Canonical link: https://commits.webkit.org/279571@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] cc750d: Update simde _Float16 test to match upstream
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: cc750da2d46cd8729065b3c95f66ff5f6131fcd8 https://github.com/WebKit/WebKit/commit/cc750da2d46cd8729065b3c95f66ff5f6131fcd8 Author: Michael Catanzaro Date: 2024-05-24 (Fri, 24 May 2024) Changed paths: M Source/WTF/wtf/simde/arm/neon.h Log Message: --- Update simde _Float16 test to match upstream https://bugs.webkit.org/show_bug.cgi?id=274581 Reviewed by Yusuke Suzuki. The simde build fix landed in 278821@main does not match what I landed upstream in https://github.com/simd-everywhere/simde/pull/1182. Let's change our copy to match upstream to flush out any potential problems sooner rather than later. * Source/WTF/wtf/simde/arm/neon.h: Canonical link: https://commits.webkit.org/279270@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] c6f625: Revert "Cherry-pick 276798@main (f91aeb92bd8e). ht...
Branch: refs/heads/webkitglib/2.44 Home: https://github.com/WebKit/WebKit Commit: c6f625d1c91df9986d79a928b01399dce4beb1cc https://github.com/WebKit/WebKit/commit/c6f625d1c91df9986d79a928b01399dce4beb1cc Author: Michael Catanzaro Date: 2024-05-18 (Sat, 18 May 2024) Changed paths: R LayoutTests/media/media-source/media-source-muted-scroll-and-seek-crash-expected.txt R LayoutTests/media/media-source/media-source-muted-scroll-and-seek-crash.html M Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp Log Message: --- Revert "Cherry-pick 276798@main (f91aeb92bd8e). https://bugs.webkit.org/show_bug.cgi?id=260455; Unreviewed. This reverts commit 30ad9a720e6b12a6c958fcef0d7dd3f52da485bd. See: https://bugs.webkit.org/show_bug.cgi?id=274261 Canonical link: https://commits.webkit.org/274313.257@webkitglib/2.44 To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] a57faf: Unreviewed, reverting 276798@main (f91aeb92bd8e)
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: a57fafd69d276cd7b6afc3a0f8fd6ce6c902f4e6 https://github.com/WebKit/WebKit/commit/a57fafd69d276cd7b6afc3a0f8fd6ce6c902f4e6 Author: Michael Catanzaro Date: 2024-05-17 (Fri, 17 May 2024) Changed paths: R LayoutTests/media/media-source/media-source-muted-scroll-and-seek-crash-expected.txt R LayoutTests/media/media-source/media-source-muted-scroll-and-seek-crash.html M Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp Log Message: --- Unreviewed, reverting 276798@main (f91aeb92bd8e) https://bugs.webkit.org/show_bug.cgi?id=274261 [GTK] Excessive CPU usage from cached web process after closing nbcnews.com page, failure to display web content after reopening page Reverted change: [GStreamer][MSE] Crash in webKitMediaSrcStreamFlush https://bugs.webkit.org/show_bug.cgi?id=260455 276798@main (f91aeb92bd8e) Canonical link: https://commits.webkit.org/278929@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 4f5aa1: [WPE][GTK] createNewPage in WebKitUIClient.cpp nee...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 4f5aa1a1182dc07afb17a676cf68ee07e5843179 https://github.com/WebKit/WebKit/commit/4f5aa1a1182dc07afb17a676cf68ee07e5843179 Author: Michael Catanzaro Date: 2024-05-16 (Thu, 16 May 2024) Changed paths: M Source/WebKit/UIProcess/API/glib/WebKitUIClient.cpp M Source/WebKit/UIProcess/API/glib/WebKitWebView.cpp M Source/WebKit/UIProcess/API/glib/WebKitWebViewPrivate.h Log Message: --- [WPE][GTK] createNewPage in WebKitUIClient.cpp needs some hooking up of the API::PageConfiguration https://bugs.webkit.org/show_bug.cgi?id=273975 Reviewed by Darin Adler and Alex Christensen. This resolves a FIXME where the API::PageConfiguration gets ignored when creating a new related web view. The control flow isn't obvious unless you're familiar with GTK/WPE ports, but the WebKitWebView emits the WebKitWebView::create signal, then the application using WebKit is supposed to create a new web view using webkit_web_view_new_with_related_view(). Note that some members of the PageConfiguration are always taken from the related view rather than the PageConfiguration we receive. This commit additionally adjusts the sanity check in webkitWebViewCreateNewPage to match the corresponding Cocoa checks in UIDelegate::UIClient::createNewPage, so it (hopefully) won't fail when site isolation is enabled. This was suggested by Carlos Garcia. * Source/WebKit/UIProcess/API/glib/WebKitUIClient.cpp: * Source/WebKit/UIProcess/API/glib/WebKitWebView.cpp: (webkitWebViewConstructed): (webkitWebViewCreateNewPage): * Source/WebKit/UIProcess/API/glib/WebKitWebViewPrivate.h: Canonical link: https://commits.webkit.org/278896@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 3b302c: REGRESSION(278410@main): Fails to build with clang...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 3b302c53053443bb6d035bfdbe845b8e3b2498c5 https://github.com/WebKit/WebKit/commit/3b302c53053443bb6d035bfdbe845b8e3b2498c5 Author: Michael Catanzaro Date: 2024-05-15 (Wed, 15 May 2024) Changed paths: M Source/WTF/wtf/simde/arm/neon.h Log Message: --- REGRESSION(278410@main): Fails to build with clang: error: _Float16 is not supported on this target https://bugs.webkit.org/show_bug.cgi?id=274086 Unreviewed build fix for s390x, and also i386 with SSE2 disabled. I've submitted these changes to upstream SIMDE to ensure they hopefully don't get lost when rebasing: https://github.com/simd-everywhere/simde/pull/1182 * Source/WTF/wtf/simde/arm/neon.h: Canonical link: https://commits.webkit.org/278821@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 6ad266: Always log internal loader errors to stderr
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 6ad266d724e52b52c46da253141d58173559079f https://github.com/WebKit/WebKit/commit/6ad266d724e52b52c46da253141d58173559079f Author: Michael Catanzaro Date: 2024-05-14 (Tue, 14 May 2024) Changed paths: M Source/WTF/wtf/Assertions.cpp M Source/WTF/wtf/Assertions.h M Source/WebCore/platform/graphics/cv/PixelBufferConformerCV.cpp M Source/WebCore/platform/network/ResourceErrorBase.cpp M Source/WebCore/platform/network/ResourceErrorBase.h Log Message: --- Always log internal loader errors to stderr https://bugs.webkit.org/show_bug.cgi?id=273662 Reviewed by Philippe Normand. Currently when WebKit encounters an internal error during loading, we release log a stacktrace showing the location of the error. However, there are several downsides: * Release stacktraces are generally very poor quality, so this is effectively useless. (On Linux, better backtraces are available if built with libbacktrace enabled, but libbacktrace has no releases, so I believe no Linux distros do this.) * The stacktrace is only logged to the system journal, not to stderr, so it's unlikely to actually be noticed. * I think it's only logged by default on Linux, because the journald implementation of WTFReleaseLogStackTrace ignores whether log channels are enabled. (I believe this is a bug in the Linux implementation of WTFReleaseLogStackTrace.) * Otherwise, release logging has to be enabled manually (using the defaults database on macOS, or environment variables on Linux), so naturally it won't ever be enabled when needed. RELEASE_LOG_BACKTRACE is used from only two places: ResourceErrorBase.cpp, when logging an internal error, and PixelBufferConformerCV.cpp, which isn't built on Linux. This commit removes the use of RELEASE_LOG_BACKTRACE from ResourceErrorBase.cpp. Since there are no other remaining uses of RELEASE_LOG_BACKTRACE, and since I don't like it, let's move the implementation to PixelBufferConformerCV.cpp to discourage further use. This allows simplifying it to assume use of os_log. WebKit internal loader errors are bugs and worth printing more visibly so we have a better chance to debug problems, especially sporadic or unexpected problems that will naturally never occur when we are looking for them with release logging manually enabled. The backtrace is probably not really needed here anyway; it's probably generally sufficient to just log the source file location. Here is what a sample error message looks like for a fake error that I introduced for test purposes: ERROR: WebKit encountered an internal error. This is a WebKit bug. /home/mcatanzaro/Projects/WebKit/Source/WebKit/WebProcess/gtk/WebProcessMainGtk.cpp(75) : virtual bool WebKit::WebProcessMainGtk::platformInitialize() In contrast, the release backtrace that I found in my system journal after encountering an internal error yesterday only tells me that the problem lies somewhere in libwebkitgtk-6.0.so.4, which is not useful. * Source/WTF/wtf/Assertions.cpp: * Source/WTF/wtf/Assertions.h: * Source/WebCore/platform/graphics/cv/PixelBufferConformerCV.cpp: (WebCore::logStackTrace): * Source/WebCore/platform/network/ResourceErrorBase.cpp: (WebCore::createInternalError): (WebCore::internalError): Deleted. * Source/WebCore/platform/network/ResourceErrorBase.h: Canonical link: https://commits.webkit.org/278778@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 7a1468: [GTK] [2.45.1] Fails to build on big-endian machin...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 7a1468c7a3f33f5355ff4e734121139c37209a39 https://github.com/WebKit/WebKit/commit/7a1468c7a3f33f5355ff4e734121139c37209a39 Author: Michael Catanzaro Date: 2024-05-14 (Tue, 14 May 2024) Changed paths: M Source/cmake/OptionsGTK.cmake M Source/cmake/OptionsWPE.cmake Log Message: --- [GTK] [2.45.1] Fails to build on big-endian machines due to lack of support in Skia https://bugs.webkit.org/show_bug.cgi?id=274032 Reviewed by Carlos Garcia Campos. Don't use skia on big endian architectures. * Source/cmake/OptionsGTK.cmake: * Source/cmake/OptionsWPE.cmake: Canonical link: https://commits.webkit.org/278740@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] cae3db: REGRESSION(277476@main): [GTK] Crash in WebCore::G...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: cae3dbd2f345116351cbb73fd45950ce01af9168 https://github.com/WebKit/WebKit/commit/cae3dbd2f345116351cbb73fd45950ce01af9168 Author: Michael Catanzaro Date: 2024-05-14 (Tue, 14 May 2024) Changed paths: M Source/WebCore/platform/image-decoders/gif/GIFImageDecoder.cpp M Source/WebCore/platform/image-decoders/gif/GIFImageReader.h Log Message: --- REGRESSION(277476@main): [GTK] Crash in WebCore::GIFImageDecoder::haveDecodedRow https://bugs.webkit.org/show_bug.cgi?id=274027 Reviewed by Carlos Garcia Campos. Confusingly, the "size" of the color maps is defined in 3-byte units, so size in bytes is actually 3x the "size" of the color map. Chris understandably missed this when converting the code to use std::span. Now we're reading off the end of the span. This triggers libstdc++ runtime assertions, but the assertions are disabled by default, so our EWS bots did not notice. Distros do (or should) enable the assertions using something like -DCMAKE_CXX_FLAGS="-Wp,-D_GLIBCXX_ASSERTIONS". * Source/WebCore/platform/image-decoders/gif/GIFImageDecoder.cpp: (WebCore::GIFImageDecoder::haveDecodedRow): * Source/WebCore/platform/image-decoders/gif/GIFImageReader.h: (GIFImageReader::globalColormap const): (GIFImageReader::localColormap const): Canonical link: https://commits.webkit.org/278739@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] cef7bf: SerializedScriptValue.cpp:367:16: error: use of ov...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: cef7bfbcfe60adf0cf4b645faab9d2f306b227f8 https://github.com/WebKit/WebKit/commit/cef7bfbcfe60adf0cf4b645faab9d2f306b227f8 Author: Michael Catanzaro Date: 2024-05-13 (Mon, 13 May 2024) Changed paths: M Source/WebCore/bindings/js/SerializedScriptValue.cpp Log Message: --- SerializedScriptValue.cpp:367:16: error: use of overloaded operator '[]' is ambiguous (with operand types 'ASCIILiteral' and 'int') https://bugs.webkit.org/show_bug.cgi?id=274095 Unreviewed build fix. Specify the type of the integer literal to avoid ambiguity. * Source/WebCore/bindings/js/SerializedScriptValue.cpp: (WTF::printInternal): Canonical link: https://commits.webkit.org/278699@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 482177: Cherry-pick 278456@main (48d82b12d119). https://bu...
Branch: refs/heads/webkitglib/2.44 Home: https://github.com/WebKit/WebKit Commit: 482178e82fcf78116a4e0e744c38f20ad661 https://github.com/WebKit/WebKit/commit/482178e82fcf78116a4e0e744c38f20ad661 Author: Michael Catanzaro Date: 2024-05-09 (Thu, 09 May 2024) Changed paths: M Source/WebKit/UIProcess/API/gtk/WebKitWebViewBase.cpp Log Message: --- Cherry-pick 278456@main (48d82b12d119). https://bugs.webkit.org/show_bug.cgi?id=273780 [GTK] Consider keycode when activating application accelerators https://bugs.webkit.org/show_bug.cgi?id=273780 Reviewed by Carlos Garcia Campos. Since Epiphany 46, keyboard shortcuts no longer work when using non-Latin keyboard layouts, like Ukranian or Hebrew. Currently we only consider the keyval when activating application accelerators. We need to consider the raw keycode as well. E.g. on a Hebrew keyboard pressing Ctrl+א should open a new tab, because the same key is used for both א and T. Fortunately, GTK can do the hard work of deciding which accelerator to activate for us. All we need to do is pass along the keycode. (This bug was *sort of* a regression from 273922@main. In practice, the regression probably only affected Epiphany, because this codepath only matters if the application allows the web view to process key events before it allows its GtkWindow to do so. That has to be done manually. Otherwise, this code will never be reached, because the GtkWindow would have already determined the key event matches an accelerator and handled it before the web view ever gets a chance to see it.) * Source/WebKit/UIProcess/API/gtk/WebKitWebViewBase.cpp: (webkitWebViewBaseProcessAcceleratorsForKeyPressEvent): Canonical link: https://commits.webkit.org/278456@main Canonical link: https://commits.webkit.org/274313.209@webkitglib/2.44 To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 5034ee: Unreviewed, reverting 276079@main (7c138c8)
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 5034eecac6edc9e4785b36156c19322ec26399bb https://github.com/WebKit/WebKit/commit/5034eecac6edc9e4785b36156c19322ec26399bb Author: Michael Catanzaro Date: 2024-05-07 (Tue, 07 May 2024) Changed paths: M Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/LayerTreeHost.cpp Log Message: --- Unreviewed, reverting 276079@main (7c138c8) https://bugs.webkit.org/show_bug.cgi?id=273792 REGRESSION(276079@main): [GTK] Web view content disappears after back/forward navigation Reverted change: [CoordinatedGraphics] Setting `LocalFrameView`'s content size should not require relayout https://bugs.webkit.org/show_bug.cgi?id=270445 276079@main (7c138c8) This is causing web view content to disappear after a history navigation. Canonical link: https://commits.webkit.org/278469@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 48d82b: [GTK] Consider keycode when activating application...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 48d82b12d119cf146e3c0127410fa6677581f2b7 https://github.com/WebKit/WebKit/commit/48d82b12d119cf146e3c0127410fa6677581f2b7 Author: Michael Catanzaro Date: 2024-05-07 (Tue, 07 May 2024) Changed paths: M Source/WebKit/UIProcess/API/gtk/WebKitWebViewBase.cpp Log Message: --- [GTK] Consider keycode when activating application accelerators https://bugs.webkit.org/show_bug.cgi?id=273780 Reviewed by Carlos Garcia Campos. Since Epiphany 46, keyboard shortcuts no longer work when using non-Latin keyboard layouts, like Ukranian or Hebrew. Currently we only consider the keyval when activating application accelerators. We need to consider the raw keycode as well. E.g. on a Hebrew keyboard pressing Ctrl+א should open a new tab, because the same key is used for both א and T. Fortunately, GTK can do the hard work of deciding which accelerator to activate for us. All we need to do is pass along the keycode. (This bug was *sort of* a regression from 273922@main. In practice, the regression probably only affected Epiphany, because this codepath only matters if the application allows the web view to process key events before it allows its GtkWindow to do so. That has to be done manually. Otherwise, this code will never be reached, because the GtkWindow would have already determined the key event matches an accelerator and handled it before the web view ever gets a chance to see it.) * Source/WebKit/UIProcess/API/gtk/WebKitWebViewBase.cpp: (webkitWebViewBaseProcessAcceleratorsForKeyPressEvent): Canonical link: https://commits.webkit.org/278456@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 2431b5: Cherry-pick 277248@main (2e1188405ef9). https://bu...
Branch: refs/heads/webkitglib/2.44 Home: https://github.com/WebKit/WebKit Commit: 2431b537193e0ae1516ab3fc83db89286e4c2bfe https://github.com/WebKit/WebKit/commit/2431b537193e0ae1516ab3fc83db89286e4c2bfe Author: Michael Catanzaro Date: 2024-04-23 (Tue, 23 Apr 2024) Changed paths: M Source/WTF/wtf/ThreadSafeRefCounted.h Log Message: --- Cherry-pick 277248@main (2e1188405ef9). https://bugs.webkit.org/show_bug.cgi?id=271997 Build failures in GeneratedSerializers.cpp in release builds with assertions enabled https://bugs.webkit.org/show_bug.cgi?id=271997 Reviewed by Chris Dumez. This matches the condition to determine whether assertions are enabled with RefCounted.h. It's a better condition anyway. * Source/WTF/wtf/ThreadSafeRefCounted.h: Canonical link: https://commits.webkit.org/277248@main Canonical link: https://commits.webkit.org/274313.157@webkitglib/2.44 To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 5fe5d0: Cherry-pick 276753@main (753783aa83f4). https://bu...
Branch: refs/heads/webkitglib/2.44 Home: https://github.com/WebKit/WebKit Commit: 5fe5d060b4a206fb396c56c07235ff788bac5475 https://github.com/WebKit/WebKit/commit/5fe5d060b4a206fb396c56c07235ff788bac5475 Author: Philippe Normand Date: 2024-04-19 (Fri, 19 Apr 2024) Changed paths: M Source/ThirdParty/libwebrtc/Source/webrtc/pc/legacy_stats_collector.cc Log Message: --- Cherry-pick 276753@main (753783aa83f4). https://bugs.webkit.org/show_bug.cgi?id=271752 [LibWebRTC] Build fails with clang-18 on Linux https://bugs.webkit.org/show_bug.cgi?id=271752 Reviewed by Youenn Fablet. Fix -Wc++11-narrowing-const-reference warnings in LibWebRTC legacy stats collector. * Source/ThirdParty/libwebrtc/Source/webrtc/pc/legacy_stats_collector.cc: Canonical link: https://commits.webkit.org/276753@main Canonical link: https://commits.webkit.org/274313.143@webkitglib/2.44 Commit: a67b6bcf730abfb97664ddba0b4a8c14774bcd12 https://github.com/WebKit/WebKit/commit/a67b6bcf730abfb97664ddba0b4a8c14774bcd12 Author: Michael Catanzaro Date: 2024-04-19 (Fri, 19 Apr 2024) Changed paths: M Source/WebCore/html/PDFDocument.cpp M Source/WebCore/html/PDFDocument.h Log Message: --- Cherry-pick 277434@main (96e3800242ca). https://bugs.webkit.org/show_bug.cgi?id=249872 Crash in PDFDocument::injectStyleAndContentScript when downloading PDF https://bugs.webkit.org/show_bug.cgi?id=249872 Reviewed by Tim Nguyen. PDFDocument expects injectStyleAndContentScript to be called exactly once, but it may be called multiple times because the EventListener is never unregistered. So let's start by unregistering it when it's no longer needed (which requires saving a copy of the HTMLScriptElement). I'm not sure whether or not it's possible for a second load to start before the main resource load finishes, so I've added an extra member variable m_injectedStyleAndScript to really make sure we inject the user content only once, for good measure. This fixes a crash when attempting to download certain PDF documents, but does NOT make downloading the document actually work. It only avoids the crash. * Source/WebCore/html/PDFDocument.cpp: (WebCore::PDFDocumentEventListener::handleEvent): (WebCore::PDFDocument::finishedParsing): (WebCore::PDFDocument::finishLoadingPDF): (WebCore::PDFDocument::injectStyleAndContentScript): * Source/WebCore/html/PDFDocument.h: Canonical link: https://commits.webkit.org/277434@main Canonical link: https://commits.webkit.org/274313.144@webkitglib/2.44 Compare: https://github.com/WebKit/WebKit/compare/de9ef4916193...a67b6bcf730a To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] a4cfee: Update to PDF.js v4.1.392
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: a4cfee13c6affa5e980e352311bb747758bcab0c https://github.com/WebKit/WebKit/commit/a4cfee13c6affa5e980e352311bb747758bcab0c Author: Michael Catanzaro Date: 2024-04-17 (Wed, 17 Apr 2024) Changed paths: M Source/ThirdParty/pdfjs/PdfJSFiles.cmake M Source/ThirdParty/pdfjs/README.webkit M Source/ThirdParty/pdfjs/build/pdf.mjs M Source/ThirdParty/pdfjs/build/pdf.sandbox.mjs M Source/ThirdParty/pdfjs/build/pdf.worker.mjs M Source/ThirdParty/pdfjs/web/debugger.css A Source/ThirdParty/pdfjs/web/images/cursor-editorFreeHighlight.svg A Source/ThirdParty/pdfjs/web/images/cursor-editorTextHighlight.svg R Source/ThirdParty/pdfjs/web/images/gv-toolbarButton-openinapp.svg M Source/ThirdParty/pdfjs/web/images/toolbarButton-editorFreeText.svg M Source/ThirdParty/pdfjs/web/images/toolbarButton-editorStamp.svg M Source/ThirdParty/pdfjs/web/locale/ar/viewer.ftl M Source/ThirdParty/pdfjs/web/locale/be/viewer.ftl M Source/ThirdParty/pdfjs/web/locale/bg/viewer.ftl M Source/ThirdParty/pdfjs/web/locale/br/viewer.ftl M Source/ThirdParty/pdfjs/web/locale/cs/viewer.ftl M Source/ThirdParty/pdfjs/web/locale/cy/viewer.ftl M Source/ThirdParty/pdfjs/web/locale/da/viewer.ftl M Source/ThirdParty/pdfjs/web/locale/de/viewer.ftl M Source/ThirdParty/pdfjs/web/locale/dsb/viewer.ftl M Source/ThirdParty/pdfjs/web/locale/el/viewer.ftl M Source/ThirdParty/pdfjs/web/locale/en-CA/viewer.ftl M Source/ThirdParty/pdfjs/web/locale/en-GB/viewer.ftl M Source/ThirdParty/pdfjs/web/locale/en-US/viewer.ftl M Source/ThirdParty/pdfjs/web/locale/eo/viewer.ftl M Source/ThirdParty/pdfjs/web/locale/es-AR/viewer.ftl M Source/ThirdParty/pdfjs/web/locale/es-CL/viewer.ftl M Source/ThirdParty/pdfjs/web/locale/es-ES/viewer.ftl M Source/ThirdParty/pdfjs/web/locale/eu/viewer.ftl M Source/ThirdParty/pdfjs/web/locale/fi/viewer.ftl M Source/ThirdParty/pdfjs/web/locale/fr/viewer.ftl M Source/ThirdParty/pdfjs/web/locale/fur/viewer.ftl M Source/ThirdParty/pdfjs/web/locale/fy-NL/viewer.ftl M Source/ThirdParty/pdfjs/web/locale/gl/viewer.ftl M Source/ThirdParty/pdfjs/web/locale/gn/viewer.ftl M Source/ThirdParty/pdfjs/web/locale/he/viewer.ftl M Source/ThirdParty/pdfjs/web/locale/hsb/viewer.ftl M Source/ThirdParty/pdfjs/web/locale/hu/viewer.ftl M Source/ThirdParty/pdfjs/web/locale/ia/viewer.ftl M Source/ThirdParty/pdfjs/web/locale/is/viewer.ftl M Source/ThirdParty/pdfjs/web/locale/it/viewer.ftl M Source/ThirdParty/pdfjs/web/locale/ja/viewer.ftl M Source/ThirdParty/pdfjs/web/locale/ka/viewer.ftl M Source/ThirdParty/pdfjs/web/locale/kk/viewer.ftl M Source/ThirdParty/pdfjs/web/locale/ko/viewer.ftl M Source/ThirdParty/pdfjs/web/locale/nb-NO/viewer.ftl M Source/ThirdParty/pdfjs/web/locale/nl/viewer.ftl M Source/ThirdParty/pdfjs/web/locale/nn-NO/viewer.ftl M Source/ThirdParty/pdfjs/web/locale/oc/viewer.ftl M Source/ThirdParty/pdfjs/web/locale/pa-IN/viewer.ftl M Source/ThirdParty/pdfjs/web/locale/pl/viewer.ftl M Source/ThirdParty/pdfjs/web/locale/pt-BR/viewer.ftl M Source/ThirdParty/pdfjs/web/locale/pt-PT/viewer.ftl M Source/ThirdParty/pdfjs/web/locale/rm/viewer.ftl M Source/ThirdParty/pdfjs/web/locale/ru/viewer.ftl M Source/ThirdParty/pdfjs/web/locale/sk/viewer.ftl M Source/ThirdParty/pdfjs/web/locale/skr/viewer.ftl M Source/ThirdParty/pdfjs/web/locale/sl/viewer.ftl M Source/ThirdParty/pdfjs/web/locale/sq/viewer.ftl M Source/ThirdParty/pdfjs/web/locale/sv-SE/viewer.ftl M Source/ThirdParty/pdfjs/web/locale/tg/viewer.ftl M Source/ThirdParty/pdfjs/web/locale/th/viewer.ftl M Source/ThirdParty/pdfjs/web/locale/tr/viewer.ftl M Source/ThirdParty/pdfjs/web/locale/uk/viewer.ftl M Source/ThirdParty/pdfjs/web/locale/vi/viewer.ftl M Source/ThirdParty/pdfjs/web/locale/zh-CN/viewer.ftl M Source/ThirdParty/pdfjs/web/locale/zh-TW/viewer.ftl M Source/ThirdParty/pdfjs/web/viewer.css M Source/ThirdParty/pdfjs/web/viewer.html M Source/ThirdParty/pdfjs/web/viewer.mjs Log Message: --- Update to PDF.js v4.1.392 https://bugs.webkit.org/show_bug.cgi?id=272832 Reviewed by Tim Nguyen. * Source/ThirdParty/pdfjs/PdfJSFiles.cmake: * Source/ThirdParty/pdfjs/README.webkit: * Source/ThirdParty/pdfjs/build/pdf.mjs: * Source/ThirdParty/pdfjs/build/pdf.sandbox.mjs: * Source/ThirdParty/pdfjs/build/pdf.worker.mjs: * Source/ThirdParty/pdfjs/web/debugger.css: (.debuggerShowText,): * Source/ThirdParty/pdfjs/web/images/cursor-editorFreeHighlight.svg: Added. * Source/ThirdParty/pdfjs/web/images/cursor-editorTextHighlight.svg: Added. * Source/ThirdParty/pdfjs/web/images/gv-toolbarButton-openinapp.svg: Removed. * Source/ThirdParty/pdfjs/web/images/toolbarButton-editorFreeText.svg: * Source/ThirdParty/pdfjs/web/images/toolbarButton-editorStamp.svg
[webkit-changes] [WebKit/WebKit] 897c8c: Updated Swedish translation
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 897c8cea2788fcf23fc0da6b4b9d4b987f984398 https://github.com/WebKit/WebKit/commit/897c8cea2788fcf23fc0da6b4b9d4b987f984398 Author: Michael Catanzaro Date: 2024-04-15 (Mon, 15 Apr 2024) Changed paths: M Source/WebCore/platform/gtk/po/sv.po Log Message: --- Updated Swedish translation https://bugs.webkit.org/show_bug.cgi?id=272303 Unreviewed translation update. * Source/WebCore/platform/gtk/po/sv.po: Canonical link: https://commits.webkit.org/277499@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 96e380: Crash in PDFDocument::injectStyleAndContentScript ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 96e3800242ca68458fa29e3ff4450262ce6f179e https://github.com/WebKit/WebKit/commit/96e3800242ca68458fa29e3ff4450262ce6f179e Author: Michael Catanzaro Date: 2024-04-12 (Fri, 12 Apr 2024) Changed paths: M Source/WebCore/html/PDFDocument.cpp M Source/WebCore/html/PDFDocument.h Log Message: --- Crash in PDFDocument::injectStyleAndContentScript when downloading PDF https://bugs.webkit.org/show_bug.cgi?id=249872 Reviewed by Tim Nguyen. PDFDocument expects injectStyleAndContentScript to be called exactly once, but it may be called multiple times because the EventListener is never unregistered. So let's start by unregistering it when it's no longer needed (which requires saving a copy of the HTMLScriptElement). I'm not sure whether or not it's possible for a second load to start before the main resource load finishes, so I've added an extra member variable m_injectedStyleAndScript to really make sure we inject the user content only once, for good measure. This fixes a crash when attempting to download certain PDF documents, but does NOT make downloading the document actually work. It only avoids the crash. * Source/WebCore/html/PDFDocument.cpp: (WebCore::PDFDocumentEventListener::handleEvent): (WebCore::PDFDocument::finishedParsing): (WebCore::PDFDocument::finishLoadingPDF): (WebCore::PDFDocument::injectStyleAndContentScript): * Source/WebCore/html/PDFDocument.h: Canonical link: https://commits.webkit.org/277434@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 2e1188: Build failures in GeneratedSerializers.cpp in rele...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 2e1188405ef911ce4b48969b3dcfdf6397cab1e7 https://github.com/WebKit/WebKit/commit/2e1188405ef911ce4b48969b3dcfdf6397cab1e7 Author: Michael Catanzaro Date: 2024-04-09 (Tue, 09 Apr 2024) Changed paths: M Source/WTF/wtf/ThreadSafeRefCounted.h Log Message: --- Build failures in GeneratedSerializers.cpp in release builds with assertions enabled https://bugs.webkit.org/show_bug.cgi?id=271997 Reviewed by Chris Dumez. This matches the condition to determine whether assertions are enabled with RefCounted.h. It's a better condition anyway. * Source/WTF/wtf/ThreadSafeRefCounted.h: Canonical link: https://commits.webkit.org/277248@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 91118d: Cherry-pick 276276@main (d679abb2e0d1). https://bu...
Branch: refs/heads/webkitglib/2.44 Home: https://github.com/WebKit/WebKit Commit: 91118dab8a572b8cca26801e1558f5ed1a403e2e https://github.com/WebKit/WebKit/commit/91118dab8a572b8cca26801e1558f5ed1a403e2e Author: Patrick Griffis Date: 2024-04-04 (Thu, 04 Apr 2024) Changed paths: M Source/WebCore/WebCoreMacros.cmake Log Message: --- Cherry-pick 276276@main (d679abb2e0d1). https://bugs.webkit.org/show_bug.cgi?id=264156 [CMake] Regenerate bindings when UnifiedWebPreferences is modified https://bugs.webkit.org/show_bug.cgi?id=264156 Reviewed by Don Olmstead. When a setting is removed from UnifiedWebPreferences the output of the generated files may change if an IDL file uses EnabledBySetting. Ideally this would be tracked per IDL file but that isn't how the generator currently works. * Source/WebCore/WebCoreMacros.cmake: Canonical link: https://commits.webkit.org/276276@main Commit: 7e2648717faf687d2441ae7fa640959ca99e504a https://github.com/WebKit/WebKit/commit/7e2648717faf687d2441ae7fa640959ca99e504a Author: Michael Saboff Date: 2024-04-04 (Thu, 04 Apr 2024) Changed paths: M Source/JavaScriptCore/jsc.cpp Log Message: --- Cherry-pick 277010@main (6e20396fae8b). https://bugs.webkit.org/show_bug.cgi?id=251420 [JSC] Crash On JSC when open dir as input file https://bugs.webkit.org/show_bug.cgi?id=251420 rdar://104853422 Reviewed by Yusuke Suzuki. Added code to check the type of filesystem object the JSC shell is trying to load via stat() and fstat(). We return an error message when thrying to open some non-file object. * Source/JavaScriptCore/jsc.cpp: (fillBufferWithContentsOfFile): Canonical link: https://commits.webkit.org/277010@main Commit: 8c5853b8a9ea551c7215e23130829f436e984fc2 https://github.com/WebKit/WebKit/commit/8c5853b8a9ea551c7215e23130829f436e984fc2 Author: Michael Catanzaro Date: 2024-04-04 (Thu, 04 Apr 2024) Changed paths: M Source/WebKit/UIProcess/API/gtk/WebKitWebViewBase.cpp Log Message: --- Cherry-pick 276950@main (9da2cabb016b). https://bugs.webkit.org/show_bug.cgi?id=271963 gtk_widget_snapshot_child: assertion '_gtk_widget_get_parent (child) == widget' failed https://bugs.webkit.org/show_bug.cgi?id=271963 Reviewed by Carlos Garcia Campos. Using a weak pointer to track the lifetime of the child dialog is insufficient because we'll try to snapshot it after it has been unparented but before it has been fully destroyed. It's guaranteed to be unparented before dispose, so it's both necessary and sufficient to watch notify::parent instead. webkitWebViewBaseRemoveDialog is no longer needed since it becomes just a one-liner. * Source/WebKit/UIProcess/API/gtk/WebKitWebViewBase.cpp: (webkitWebViewBaseAddDialog): (webkitWebViewBaseDispose): (webkitWebViewBaseRemoveDialog): Deleted. Canonical link: https://commits.webkit.org/276950@main Compare: https://github.com/WebKit/WebKit/compare/004c28e211d9...8c5853b8a9ea To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 9da2ca: gtk_widget_snapshot_child: assertion '_gtk_widget_...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 9da2cabb016bb065e75677a3b5795c325256ca07 https://github.com/WebKit/WebKit/commit/9da2cabb016bb065e75677a3b5795c325256ca07 Author: Michael Catanzaro Date: 2024-04-02 (Tue, 02 Apr 2024) Changed paths: M Source/WebKit/UIProcess/API/gtk/WebKitWebViewBase.cpp Log Message: --- gtk_widget_snapshot_child: assertion '_gtk_widget_get_parent (child) == widget' failed https://bugs.webkit.org/show_bug.cgi?id=271963 Reviewed by Carlos Garcia Campos. Using a weak pointer to track the lifetime of the child dialog is insufficient because we'll try to snapshot it after it has been unparented but before it has been fully destroyed. It's guaranteed to be unparented before dispose, so it's both necessary and sufficient to watch notify::parent instead. webkitWebViewBaseRemoveDialog is no longer needed since it becomes just a one-liner. * Source/WebKit/UIProcess/API/gtk/WebKitWebViewBase.cpp: (webkitWebViewBaseAddDialog): (webkitWebViewBaseDispose): (webkitWebViewBaseRemoveDialog): Deleted. Canonical link: https://commits.webkit.org/276950@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] e2c404: Cherry-pick 275480@main (73271df67cec). https://bu...
Branch: refs/heads/webkitglib/2.44 Home: https://github.com/WebKit/WebKit Commit: e2c404f16697d8f0022ff1860870a0bc38f2a39a https://github.com/WebKit/WebKit/commit/e2c404f16697d8f0022ff1860870a0bc38f2a39a Author: Lauro Moura Date: 2024-03-19 (Tue, 19 Mar 2024) Changed paths: M Source/WebKit/UIProcess/XR/PlatformXRSystem.h Log Message: --- Cherry-pick 275480@main (73271df67cec). https://bugs.webkit.org/show_bug.cgi?id=270239 (REGRESSION 275453@main) Broke clean cmake builds https://bugs.webkit.org/show_bug.cgi?id=270239 Reviewed by Don Olmstead. Fix entry for file that was moved to cocoa-specific directory. * Source/WebKit/UIProcess/XR/PlatformXRSystem.h: Drive-by non-unified fix that was breaking unified WPE build on flatpak * Source/WebKit/Sources.txt: * Source/WebKit/SourcesCocoa.txt: Canonical link: https://commits.webkit.org/275480@main Commit: ff25d1c79f5d4007c79ed9a351f36f73442d0afc https://github.com/WebKit/WebKit/commit/ff25d1c79f5d4007c79ed9a351f36f73442d0afc Author: Carlos Garcia Campos Date: 2024-03-20 (Wed, 20 Mar 2024) Changed paths: M Source/WebKit/PlatformWPE.cmake M Source/WebKit/UIProcess/API/glib/WebKitWebViewAccessible.cpp M Source/WebKit/UIProcess/API/glib/WebKitWebViewAccessible.h M Source/WebKit/UIProcess/API/wpe/PageClientImpl.cpp M Source/WebKit/UIProcess/API/wpe/PageClientImpl.h M Source/WebKit/UIProcess/API/wpe/WPEWebView.cpp M Source/WebKit/UIProcess/API/wpe/WPEWebView.h M Source/WebKit/UIProcess/wpe/WebPageProxyWPE.cpp M Source/cmake/OptionsGTK.cmake M Source/cmake/OptionsWPE.cmake M Tools/MiniBrowser/wpe/CMakeLists.txt M Tools/MiniBrowser/wpe/main.cpp M Tools/wpe/backends/PlatformWPE.cmake M Tools/wpe/backends/ViewBackend.cpp M Tools/wpe/backends/atk/ViewBackendAtk.cpp M Tools/wpe/backends/atk/WebKitAccessibleApplication.cpp M Tools/wpe/backends/atk/WebKitAccessibleApplication.h Log Message: --- Cherry-pick 276392@main (9d2e1868ff2f). https://bugs.webkit.org/show_bug.cgi?id=267508 [WPE] Introduce USE(ATK) https://bugs.webkit.org/show_bug.cgi?id=267508 Reviewed by Michael Catanzaro. ENABLE_ACCESSIBILITY was removed in 273021@main, so add USE_ATK to keep accessibility optional in the WPE port. * Source/WebKit/PlatformWPE.cmake: * Source/WebKit/UIProcess/API/glib/WebKitWebViewAccessible.cpp: * Source/WebKit/UIProcess/API/glib/WebKitWebViewAccessible.h: * Source/WebKit/UIProcess/API/wpe/PageClientImpl.cpp: * Source/WebKit/UIProcess/API/wpe/PageClientImpl.h: * Source/WebKit/UIProcess/API/wpe/WPEWebView.cpp: (WKWPE::m_backend): (WKWPE::View::~View): * Source/WebKit/UIProcess/API/wpe/WPEWebView.h: * Source/WebKit/UIProcess/wpe/WebPageProxyWPE.cpp: (WebKit::WebPageProxy::bindAccessibilityTree): * Source/cmake/OptionsGTK.cmake: * Source/cmake/OptionsWPE.cmake: * Tools/MiniBrowser/wpe/CMakeLists.txt: * Tools/MiniBrowser/wpe/main.cpp: (activate): * Tools/wpe/backends/PlatformWPE.cmake: * Tools/wpe/backends/ViewBackend.cpp: (WPEToolingBackends::ViewBackend::initializeAccessibility): (WPEToolingBackends::ViewBackend::updateAccessibilityState): * Tools/wpe/backends/atk/ViewBackendAtk.cpp: * Tools/wpe/backends/atk/WebKitAccessibleApplication.cpp: * Tools/wpe/backends/atk/WebKitAccessibleApplication.h: Canonical link: https://commits.webkit.org/276392@main Commit: dba426f3d041a11a99181e7971544b1f387ce9af https://github.com/WebKit/WebKit/commit/dba426f3d041a11a99181e7971544b1f387ce9af Author: Adrian Perez de Castro Date: 2024-03-20 (Wed, 20 Mar 2024) Changed paths: M Source/WebCore/Modules/webxr/WebXRLayer.cpp Log Message: --- [WebXR] Fix non-unified build Unreviewed build fix. * Source/WebCore/Modules/webxr/WebXRLayer.cpp: Add missing include. Commit: 09fd3067a8caea5ef3e8038fe9db7854157e96ba https://github.com/WebKit/WebKit/commit/09fd3067a8caea5ef3e8038fe9db7854157e96ba Author: Adrian Perez de Castro Date: 2024-03-20 (Wed, 20 Mar 2024) Changed paths: M Source/WebKit/UIProcess/API/glib/WebKitWebView.h.in Log Message: --- [WPE] Fix the build with ENABLE_WPE_PLATFORM=OFF Unreviewed build fix. * Source/WebKit/UIProcess/API/glib/WebKitWebView.h.in: Add guards around parts that depend on the new unreleased platform API. Commit: a97ad1248d0766e63c8bbde79938960f9e38e38f https://github.com/WebKit/WebKit/commit/a97ad1248d0766e63c8bbde79938960f9e38e38f Author: Michael Catanzaro Date: 2024-03-20 (Wed, 20 Mar 2024) Changed paths: M Source/WebCore/platform/Timer.cpp Log Message: --- Cherry-pick 276282@main (2922af379dc7). https://bugs.webkit.org/show_bug.cgi?id=271108 REGRESSION(274077@main): failure to build on i586 (and likely other 32bit arches): static assertion
[webkit-changes] [WebKit/WebKit] 2922af: REGRESSION(274077@main): failure to build on i586 ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 2922af379dc70b4b1a63b01d67179eb431f03ac4 https://github.com/WebKit/WebKit/commit/2922af379dc70b4b1a63b01d67179eb431f03ac4 Author: Michael Catanzaro Date: 2024-03-18 (Mon, 18 Mar 2024) Changed paths: M Source/WebCore/platform/Timer.cpp Log Message: --- REGRESSION(274077@main): failure to build on i586 (and likely other 32bit arches): static assertion failed: Timer should stay small https://bugs.webkit.org/show_bug.cgi?id=271108 Unreviewed build fix. This changes SameSizeOfTimer to ensure it matches the size of Timer on 32-bit platforms. * Source/WebCore/platform/Timer.cpp: Canonical link: https://commits.webkit.org/276282@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] d02f04: [WPE][GTK] Fix clang warning about use of variable...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: d02f043164f222ef32519784d614e5ea0a8b300a https://github.com/WebKit/WebKit/commit/d02f043164f222ef32519784d614e5ea0a8b300a Author: Michael Catanzaro Date: 2024-03-15 (Fri, 15 Mar 2024) Changed paths: M Tools/TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebContext.cpp Log Message: --- [WPE][GTK] Fix clang warning about use of variable length arrays in C++ https://bugs.webkit.org/show_bug.cgi?id=271005 Reviewed by Adrian Perez de Castro. We shouldn't use variable-length arrays in WebKit. * Tools/TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebContext.cpp: (testWebContextURIScheme): Canonical link: https://commits.webkit.org/276168@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 910ab1: [WPE][GTK] Warning: WebKit2: Couldn't find 'run_as...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 910ab18a82d45d05c146999c32b0c517bf78b56a https://github.com/WebKit/WebKit/commit/910ab18a82d45d05c146999c32b0c517bf78b56a Author: Michael Catanzaro Date: 2024-03-12 (Tue, 12 Mar 2024) Changed paths: M Source/WebKit/PlatformGTK.cmake M Source/WebKit/PlatformWPE.cmake M Source/WebKit/UIProcess/API/glib/WebKitWebView.cpp M Source/WebKit/UIProcess/API/glib/WebKitWebView.h.in Log Message: --- [WPE][GTK] Warning: WebKit2: Couldn't find 'run_async_javascript_function_in_world_finish' for the corresponding async function: 'run_async_javascript_function_in_world' https://bugs.webkit.org/show_bug.cgi?id=269377 Reviewed by Adrian Perez de Castro. We need to use the new finish-func annotation so that language bindings can figure out how to complete the async call, due to our nonstandard naming for the finish function. It seems trying to reuse the same finish function for multiple async calls was not such a good idea. Unfortunately, with older gobject-introspection, we cannot use this new annotation or the build will fail due to the unrecognized annotation. So we will need to conditionalize the entire doc comment. Finally, I've also fixed the nullability of the world_name parameter, which was broken due to a missing colon. * Source/WebKit/PlatformGTK.cmake: * Source/WebKit/PlatformWPE.cmake: * Source/WebKit/UIProcess/API/glib/WebKitWebView.cpp: * Source/WebKit/UIProcess/API/glib/WebKitWebView.h.in: Canonical link: https://commits.webkit.org/276012@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 1a9883: Atlassian Confluence blocks Epiphany's user agent
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 1a9883acbbb02ab8671f5e31e18ea0d0b8eda162 https://github.com/WebKit/WebKit/commit/1a9883acbbb02ab8671f5e31e18ea0d0b8eda162 Author: Michael Catanzaro Date: 2024-03-08 (Fri, 08 Mar 2024) Changed paths: M Source/WebCore/platform/glib/UserAgentQuirks.cpp M Tools/TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp Log Message: --- Atlassian Confluence blocks Epiphany's user agent https://bugs.webkit.org/show_bug.cgi?id=270438 Reviewed by Philippe Normand. * Source/WebCore/platform/glib/UserAgentQuirks.cpp: (WebCore::urlRequiresMacintoshPlatform): * Tools/TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp: (TestWebKitAPI::TEST): Canonical link: https://commits.webkit.org/275835@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 432956: [GTK] [l10n] Updated Turkish translation of WebKitGTK
Branch: refs/heads/webkitglib/2.44 Home: https://github.com/WebKit/WebKit Commit: 432956a238f1ecc4cd7e56fe656d33eba45638f8 https://github.com/WebKit/WebKit/commit/432956a238f1ecc4cd7e56fe656d33eba45638f8 Author: Michael Catanzaro Date: 2024-03-06 (Wed, 06 Mar 2024) Changed paths: M Source/WebCore/platform/gtk/po/tr.po Log Message: --- [GTK] [l10n] Updated Turkish translation of WebKitGTK https://bugs.webkit.org/show_bug.cgi?id=269675 Unreviewed translation update. * Source/WebCore/platform/gtk/po/tr.po: Canonical link: https://commits.webkit.org/275003@main Commit: 30ffd82eb335550207b01dd6993134877a1555d6 https://github.com/WebKit/WebKit/commit/30ffd82eb335550207b01dd6993134877a1555d6 Author: Michael Catanzaro Date: 2024-03-06 (Wed, 06 Mar 2024) Changed paths: M Source/WebCore/platform/gtk/po/sv.po Log Message: --- Updated Swedish translation https://bugs.webkit.org/show_bug.cgi?id=270035 Unreviewed translation update. * Source/WebCore/platform/gtk/po/sv.po: Canonical link: https://commits.webkit.org/275344@main Commit: cb47b05e152cc32c4a6dfc8c44dd2b137271735f https://github.com/WebKit/WebKit/commit/cb47b05e152cc32c4a6dfc8c44dd2b137271735f Author: Michael Catanzaro Date: 2024-03-06 (Wed, 06 Mar 2024) Changed paths: M Source/WebCore/platform/gtk/po/pl.po Log Message: --- [GTK][l10n] Updated Polish translation of WebKitGTK for 2.44 https://bugs.webkit.org/show_bug.cgi?id=270412 Unreviewed translation update. * Source/WebCore/platform/gtk/po/pl.po: Canonical link: https://commits.webkit.org/275626@main Commit: c44311bdc6abc567dd860ff4f7685e11f0700341 https://github.com/WebKit/WebKit/commit/c44311bdc6abc567dd860ff4f7685e11f0700341 Author: Michael Catanzaro Date: 2024-03-06 (Wed, 06 Mar 2024) Changed paths: M Source/WebCore/platform/gtk/po/de.po Log Message: --- Proof-read German translation update https://bugs.webkit.org/show_bug.cgi?id=270542 Unreviewed translation update. * Source/WebCore/platform/gtk/po/de.po: Canonical link: https://commits.webkit.org/275719@main Compare: https://github.com/WebKit/WebKit/compare/e764fa239f8f...c44311bdc6ab To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 145e1e: Proof-read German translation update
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 145e1ec015f35b23540936f1695bbad97ce3b77d https://github.com/WebKit/WebKit/commit/145e1ec015f35b23540936f1695bbad97ce3b77d Author: Michael Catanzaro Date: 2024-03-05 (Tue, 05 Mar 2024) Changed paths: M Source/WebCore/platform/gtk/po/de.po Log Message: --- Proof-read German translation update https://bugs.webkit.org/show_bug.cgi?id=270542 Unreviewed translation update. * Source/WebCore/platform/gtk/po/de.po: Canonical link: https://commits.webkit.org/275719@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 4a199e: [GTK][l10n] Updated Polish translation of WebKitGT...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 4a199e26b7d393b6a455e8f14e2e7cbb0ed09f24 https://github.com/WebKit/WebKit/commit/4a199e26b7d393b6a455e8f14e2e7cbb0ed09f24 Author: Michael Catanzaro Date: 2024-03-04 (Mon, 04 Mar 2024) Changed paths: M Source/WebCore/platform/gtk/po/pl.po Log Message: --- [GTK][l10n] Updated Polish translation of WebKitGTK for 2.44 https://bugs.webkit.org/show_bug.cgi?id=270412 Unreviewed translation update. * Source/WebCore/platform/gtk/po/pl.po: Canonical link: https://commits.webkit.org/275626@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 2dd0e8: Updated Swedish translation
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 2dd0e8102e51145886e545bb6835837453e42c4d https://github.com/WebKit/WebKit/commit/2dd0e8102e51145886e545bb6835837453e42c4d Author: Michael Catanzaro Date: 2024-02-26 (Mon, 26 Feb 2024) Changed paths: M Source/WebCore/platform/gtk/po/sv.po Log Message: --- Updated Swedish translation https://bugs.webkit.org/show_bug.cgi?id=270035 Unreviewed translation update. * Source/WebCore/platform/gtk/po/sv.po: Canonical link: https://commits.webkit.org/275344@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 29ee71: Web process cache should expire old web processes ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 29ee71944f9115b7f39159ca4ebc85ffb373ec6b https://github.com/WebKit/WebKit/commit/29ee71944f9115b7f39159ca4ebc85ffb373ec6b Author: Michael Catanzaro Date: 2024-02-20 (Tue, 20 Feb 2024) Changed paths: M Source/WebKit/UIProcess/WebProcessCache.cpp Log Message: --- Web process cache should expire old web processes sooner https://bugs.webkit.org/show_bug.cgi?id=262780 Reviewed by Don Olmstead and Carlos Garcia Campos. GTK/WPE want a shorter web process cache lifetime. I guess the shorter lifetime is likely to be desired by other non-Apple ports, as well. Apple prefers to keep the current 30 minute cache lifetime. * Source/WebKit/UIProcess/WebProcessCache.cpp: Canonical link: https://commits.webkit.org/275063@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 9cf404: [WPE][GTK] Deprecate insecure-content-detected sig...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 9cf4048416d8bdd0ff193189422bf20427bccb6a https://github.com/WebKit/WebKit/commit/9cf4048416d8bdd0ff193189422bf20427bccb6a Author: Michael Catanzaro Date: 2024-02-20 (Tue, 20 Feb 2024) Changed paths: M Source/WebKit/UIProcess/API/glib/WebKitWebView.cpp M Source/WebKit/UIProcess/API/glib/WebKitWebView.h.in Log Message: --- [WPE][GTK] Deprecate insecure-content-detected signals https://bugs.webkit.org/show_bug.cgi?id=219396 Reviewed by Carlos Garcia Campos. I'm being a bit careful with the language here because although in practice these signals will never be emitted anymore, technically it is still possible if the user toggles the right runtime setting using the WebKitFeature API. But in practice, this is not something anybody is ever likely to do, so we should indicate that these signals are obsolete. * Source/WebKit/UIProcess/API/glib/WebKitWebView.cpp: (webkit_web_view_class_init): * Source/WebKit/UIProcess/API/glib/WebKitWebView.h.in: Canonical link: https://commits.webkit.org/275056@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 4fc58f: [GTK] [l10n] Updated Turkish translation of WebKitGTK
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 4fc58fdcb411dacacb9a5d48ad9b503654dfad43 https://github.com/WebKit/WebKit/commit/4fc58fdcb411dacacb9a5d48ad9b503654dfad43 Author: Michael Catanzaro Date: 2024-02-19 (Mon, 19 Feb 2024) Changed paths: M Source/WebCore/platform/gtk/po/tr.po Log Message: --- [GTK] [l10n] Updated Turkish translation of WebKitGTK https://bugs.webkit.org/show_bug.cgi?id=269675 Unreviewed translation update. * Source/WebCore/platform/gtk/po/tr.po: Canonical link: https://commits.webkit.org/275003@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 5d528e: VAPI for register_script_message_handler of webkit...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 5d528e1cafcaa30bc59e66c78e5691830fdd0378 https://github.com/WebKit/WebKit/commit/5d528e1cafcaa30bc59e66c78e5691830fdd0378 Author: Michael Catanzaro Date: 2024-02-14 (Wed, 14 Feb 2024) Changed paths: M Source/WebKit/UIProcess/API/glib/WebKitUserContentManager.cpp Log Message: --- VAPI for register_script_message_handler of webkitgtk-6.0 is wrong https://bugs.webkit.org/show_bug.cgi?id=269358 Reviewed by Adrian Perez de Castro. Too bad we don't get a warning when we typo the colon here. * Source/WebKit/UIProcess/API/glib/WebKitUserContentManager.cpp: Canonical link: https://commits.webkit.org/274653@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 3d5373: [GTK] [2.42.5] LowLevelInterpreter.cpp:339:21: err...
Branch: refs/heads/webkitglib/2.42 Home: https://github.com/WebKit/WebKit Commit: 3d5373575695b293b8559155431d0079a6153aff https://github.com/WebKit/WebKit/commit/3d5373575695b293b8559155431d0079a6153aff Author: Michael Catanzaro Date: 2024-02-05 (Mon, 05 Feb 2024) Changed paths: M Source/JavaScriptCore/llint/LowLevelInterpreter.cpp Log Message: --- [GTK] [2.42.5] LowLevelInterpreter.cpp:339:21: error: ‘t6’ was not declared in this scope https://bugs.webkit.org/show_bug.cgi?id=268739 Unreviewed build fix. Seems a backport went badly, and we didn't notice because the code is architecture-specific. * Source/JavaScriptCore/llint/LowLevelInterpreter.cpp: (JSC::CLoop::execute): ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 6c0572: Cherry-pick 272313@main (64a739754a58). https://bu...
s://github.com/WebKit/WebKit/commit/f47952e22520e4010c8c77eb3800d106cee33191 Author: Loïc Yhuel Date: 2024-01-29 (Mon, 29 Jan 2024) Changed paths: M Source/WebCore/platform/mediastream/gstreamer/GStreamerCaptureDeviceManager.cpp Log Message: --- Cherry-pick 272804@main (0af0ad4fe5bf). https://bugs.webkit.org/show_bug.cgi?id=267234 [GStreamer][MediaStream] Do not initialize on teardown https://bugs.webkit.org/show_bug.cgi?id=267234 Reviewed by Philippe Normand. The capture device managers were created on exit, including possibly a full GStreamer init. * Source/WebCore/platform/mediastream/gstreamer/GStreamerCaptureDeviceManager.cpp: (WebCore::GStreamerAudioCaptureDeviceManager::singleton): (WebCore::GStreamerVideoCaptureDeviceManager::singleton): (WebCore::teardownGStreamerCaptureDeviceManagers): Canonical link: https://commits.webkit.org/272804@main Commit: 69ad89f7e72431e98a6db565669409327d84456a https://github.com/WebKit/WebKit/commit/69ad89f7e72431e98a6db565669409327d84456a Author: Philippe Normand Date: 2024-01-29 (Mon, 29 Jan 2024) Changed paths: M Source/WTF/wtf/PlatformGTK.cmake M Source/WTF/wtf/PlatformWPE.cmake A Source/WTF/wtf/glib/GThreadSafeWeakPtr.h M Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp M Tools/TestWebKitAPI/Tests/WTF/glib/GWeakPtr.cpp Log Message: --- Cherry-pick 272807@main (6a9d7a164705). https://bugs.webkit.org/show_bug.cgi?id=266973 [GStreamer] Crash in CachedResourceStreamingClient::dataReceived https://bugs.webkit.org/show_bug.cgi?id=266973 Reviewed by Michael Catanzaro, Carlos Garcia Campos and Xabier Rodriguez-Calvar. Store the WebKitWebSrc pointer as a weak reference in the CachedResourceStreamingClient. Using a const raw pointer was not sufficient, because nothing prevented other code to dispose the element, thus making the pointer point to garbage. We can't use a strong reference because it would introduce a reference cycle between WebKitWebSrc and the CachedResourceStreamingClient. * Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp: (webKitWebSrcMakeRequest): (CachedResourceStreamingClient::CachedResourceStreamingClient): (CachedResourceStreamingClient::~CachedResourceStreamingClient): (CachedResourceStreamingClient::checkUpdateBlocksize): (CachedResourceStreamingClient::responseReceived): (CachedResourceStreamingClient::dataReceived): (CachedResourceStreamingClient::accessControlCheckFailed): (CachedResourceStreamingClient::loadFailed): (CachedResourceStreamingClient::loadFinished): Canonical link: https://commits.webkit.org/272807@main Commit: a23f51344acf868f6d37d12178c516585a8dc054 https://github.com/WebKit/WebKit/commit/a23f51344acf868f6d37d12178c516585a8dc054 Author: Antti Koivisto Date: 2024-01-29 (Mon, 29 Jan 2024) Changed paths: A LayoutTests/fast/ruby/ruby-frameset-display-none-crash-expected.txt A LayoutTests/fast/ruby/ruby-frameset-display-none-crash.html M Source/WebCore/html/HTMLFrameElement.cpp M Source/WebCore/html/HTMLFrameSetElement.cpp M Source/WebCore/html/HTMLFrameSetElement.h M Source/WebCore/style/StyleAdjuster.cpp Log Message: --- Cherry-pick 272846@main (8395281e9b92). https://bugs.webkit.org/show_bug.cgi?id=267331 [iFC][Ruby] frameset with display:none crashes in ruby https://bugs.webkit.org/show_bug.cgi?id=267331 rdar://120496400 Reviewed by Alan Baradlay. generates a renderer even with 'display:none' breaking some assumptions. * LayoutTests/fast/ruby/ruby-frameset-display-none-crash-expected.txt: Added. * LayoutTests/fast/ruby/ruby-frameset-display-none-crash.html: Added. * Source/WebCore/html/HTMLFrameElement.cpp: (WebCore::HTMLFrameElement::rendererIsNeeded): * Source/WebCore/html/HTMLFrameSetElement.cpp: (WebCore::HTMLFrameSetElement::rendererIsNeeded): Deleted. * Source/WebCore/html/HTMLFrameSetElement.h: * Source/WebCore/style/StyleAdjuster.cpp: (WebCore::Style::Adjuster::adjust const): Adjust frameset/frame always have 'display:block', even when it is orginally 'none'. This matches other browsers. Canonical link: https://commits.webkit.org/272846@main Commit: 6a781d4dc0dcac50887aea7944cf5b781d76e5b0 https://github.com/WebKit/WebKit/commit/6a781d4dc0dcac50887aea7944cf5b781d76e5b0 Author: Philippe Normand Date: 2024-01-29 (Mon, 29 Jan 2024) Changed paths: M Source/WebCore/Modules/mediastream/gstreamer/GStreamerMediaEndpoint.cpp Log Message: --- Cherry-pick 272909@main (62752b330f81). https://bugs.webkit.org/show_bug.cgi?id=267328 [GStreamer][WebRTC] WPT test RTCPeerConnection-restartIce.https.html is crashing https://bugs.webkit.org/show_bug.cgi?id=267328 Reviewed by Xabier Rodriguez-Calv
[webkit-changes] [WebKit/WebKit] fd1f0b: [GTK] Remove key event reinjection
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: fd1f0b783bb7b0b957f17c4e9594f11747e2be33 https://github.com/WebKit/WebKit/commit/fd1f0b783bb7b0b957f17c4e9594f11747e2be33 Author: Michael Catanzaro Date: 2024-02-01 (Thu, 01 Feb 2024) Changed paths: M Source/WebKit/UIProcess/API/gtk/PageClientImpl.cpp M Source/WebKit/UIProcess/API/gtk/WebKitWebViewBase.cpp M Source/WebKit/UIProcess/API/gtk/WebKitWebViewBasePrivate.h Log Message: --- [GTK] Remove key event reinjection https://bugs.webkit.org/show_bug.cgi?id=261348 Reviewed by Carlos Garcia Campos. Event processing in GTK is synchronous, but in WebKit it is asynchronous because we don't want to block the UI process waiting for the web process to decide whether a DOM event has been handled (e.g. by using Event.stopPropagation). Currently we use a complicated scheme to synthesize and reinject new key and wheel events to continue event processing when the event is not handled by the web content, which the GTK developers do not approve of, and which is causing serious problems where Epiphany has to choose between processing events in an infinite loop vs. handling events too soon and blocking the web view from receiving them. Neither option is great. https://gitlab.gnome.org/GNOME/epiphany/-/issues/1915 https://gitlab.gnome.org/GNOME/epiphany/-/issues/2173 The solution is to just never reinject events, and instead always handle them. We do not need event reinjection anymore if we activate application accelerators manually. See the long comment embedded in this commit for full details of why this is necessary. This patch removes the key event reinjection. Wheel event reinjection is not yet removed because this would break when WebKit is used within scrolled windows. * Source/WebKit/UIProcess/API/gtk/PageClientImpl.cpp: (WebKit::PageClientImpl::doneWithKeyEvent): * Source/WebKit/UIProcess/API/gtk/WebKitWebViewBase.cpp: (shouldForwardKeyEvent): (webkitWebViewBaseProcessAcceleratorsForKeyPressEvent): (webkitWebViewBaseKeyPressed): (handleScroll): (webkitWebViewBasePropagateKeyEvent): * Source/WebKit/UIProcess/API/gtk/WebKitWebViewBasePrivate.h: Canonical link: https://commits.webkit.org/273922@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 39559c: [GTK] gdk_memory_texture_new: assertion 'width > 0...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 39559cbd2d257dc88ed4d7119f110e7a6268f276 https://github.com/WebKit/WebKit/commit/39559cbd2d257dc88ed4d7119f110e7a6268f276 Author: Michael Catanzaro Date: 2024-02-01 (Thu, 01 Feb 2024) Changed paths: M Source/WebCore/platform/graphics/gtk/GdkCairoUtilities.cpp M Source/WebKit/UIProcess/API/glib/WebKitFaviconDatabase.cpp M Source/WebKit/UIProcess/API/glib/WebKitWebView.cpp Log Message: --- [GTK] gdk_memory_texture_new: assertion 'width > 0' failed in cairoSurfaceToGdkTexture https://bugs.webkit.org/show_bug.cgi?id=252435 Reviewed by Carlos Garcia Campos. If the cairo surface does not have positive width and height, we need to not attempt to create a GdkTexture, and return a valid error. * Source/WebCore/platform/graphics/gtk/GdkCairoUtilities.cpp: (WebCore::cairoSurfaceToGdkTexture): * Source/WebKit/UIProcess/API/glib/WebKitFaviconDatabase.cpp: (webkit_favicon_database_get_favicon_finish): * Source/WebKit/UIProcess/API/glib/WebKitWebView.cpp: Canonical link: https://commits.webkit.org/273907@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 72ddfd: Remove ADD_SOURCE_WEBCORE_DERIVED_DEPENDENCIES macro
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 72ddfd39b7bdf4997b026e96e9208d1517bb2535 https://github.com/WebKit/WebKit/commit/72ddfd39b7bdf4997b026e96e9208d1517bb2535 Author: Michael Catanzaro Date: 2024-01-12 (Fri, 12 Jan 2024) Changed paths: M Source/WebCore/CMakeLists.txt M Source/WebCore/Headers.cmake M Source/WebCore/WebCoreMacros.cmake Log Message: --- Remove ADD_SOURCE_WEBCORE_DERIVED_DEPENDENCIES macro https://bugs.webkit.org/show_bug.cgi?id=266984 Reviewed by Fujii Hironori and Don Olmstead. ADD_SOURCE_WEBCORE_DERIVED_DEPENDENCIES is used in two cases: (1) To add dependencies on generated header files. In most cases, these headers are already part of WebCore_PRIVATE_FRAMEWORK_HEADERS, and so are guaranteed to be generated before compiling WebCore. In all other cases, they should just be added to WebCore_PRIVATE_FRAMEWORK_HEADERS. (2) To add dependencies on generated source files. In all cases, these sources are already part of WebCore_SOURCES, and so are guaranteed to be generated before compiling WebCore. * Source/WebCore/CMakeLists.txt: * Source/WebCore/Headers.cmake: * Source/WebCore/WebCoreMacros.cmake: Canonical link: https://commits.webkit.org/272974@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] d9cb0b: Fix CSSSelectorParser.cpp dependency on CSSSelecto...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: d9cb0beddac4f8a15481128a8fd2e262b46c7a9f https://github.com/WebKit/WebKit/commit/d9cb0beddac4f8a15481128a8fd2e262b46c7a9f Author: Michael Catanzaro Date: 2024-01-03 (Wed, 03 Jan 2024) Changed paths: M Source/WebCore/CMakeLists.txt Log Message: --- Fix CSSSelectorParser.cpp dependency on CSSSelectorInlines.h https://bugs.webkit.org/show_bug.cgi?id=266998 Reviewed by Darin Adler. Also, move an unrelated dependency to a more appropriate location in the CMake file. * Source/WebCore/CMakeLists.txt: Canonical link: https://commits.webkit.org/272634@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 3bed0f: Update to PDF.js v4.0.379
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 3bed0fecd99720d98590749eaf41377ea6358534 https://github.com/WebKit/WebKit/commit/3bed0fecd99720d98590749eaf41377ea6358534 Author: Michael Catanzaro Date: 2024-01-02 (Tue, 02 Jan 2024) Changed paths: M Source/ThirdParty/pdfjs/PdfJSFiles.cmake M Source/ThirdParty/pdfjs/README.webkit M Source/ThirdParty/pdfjs/build/pdf.mjs M Source/ThirdParty/pdfjs/build/pdf.sandbox.mjs M Source/ThirdParty/pdfjs/build/pdf.worker.mjs A Source/ThirdParty/pdfjs/web/images/toolbarButton-editorHighlight.svg M Source/ThirdParty/pdfjs/web/locale/be/viewer.ftl M Source/ThirdParty/pdfjs/web/locale/br/viewer.ftl M Source/ThirdParty/pdfjs/web/locale/cs/viewer.ftl M Source/ThirdParty/pdfjs/web/locale/cy/viewer.ftl M Source/ThirdParty/pdfjs/web/locale/da/viewer.ftl M Source/ThirdParty/pdfjs/web/locale/de/viewer.ftl M Source/ThirdParty/pdfjs/web/locale/dsb/viewer.ftl M Source/ThirdParty/pdfjs/web/locale/el/viewer.ftl M Source/ThirdParty/pdfjs/web/locale/en-GB/viewer.ftl M Source/ThirdParty/pdfjs/web/locale/en-US/viewer.ftl M Source/ThirdParty/pdfjs/web/locale/es-AR/viewer.ftl M Source/ThirdParty/pdfjs/web/locale/es-CL/viewer.ftl M Source/ThirdParty/pdfjs/web/locale/es-ES/viewer.ftl M Source/ThirdParty/pdfjs/web/locale/fi/viewer.ftl M Source/ThirdParty/pdfjs/web/locale/fr/viewer.ftl M Source/ThirdParty/pdfjs/web/locale/fur/viewer.ftl M Source/ThirdParty/pdfjs/web/locale/fy-NL/viewer.ftl M Source/ThirdParty/pdfjs/web/locale/gn/viewer.ftl M Source/ThirdParty/pdfjs/web/locale/he/viewer.ftl M Source/ThirdParty/pdfjs/web/locale/hsb/viewer.ftl M Source/ThirdParty/pdfjs/web/locale/hu/viewer.ftl M Source/ThirdParty/pdfjs/web/locale/ia/viewer.ftl M Source/ThirdParty/pdfjs/web/locale/is/viewer.ftl M Source/ThirdParty/pdfjs/web/locale/it/viewer.ftl M Source/ThirdParty/pdfjs/web/locale/ja/viewer.ftl M Source/ThirdParty/pdfjs/web/locale/ka/viewer.ftl M Source/ThirdParty/pdfjs/web/locale/kab/viewer.ftl M Source/ThirdParty/pdfjs/web/locale/kk/viewer.ftl M Source/ThirdParty/pdfjs/web/locale/ko/viewer.ftl M Source/ThirdParty/pdfjs/web/locale/nb-NO/viewer.ftl M Source/ThirdParty/pdfjs/web/locale/nl/viewer.ftl M Source/ThirdParty/pdfjs/web/locale/nn-NO/viewer.ftl M Source/ThirdParty/pdfjs/web/locale/pa-IN/viewer.ftl M Source/ThirdParty/pdfjs/web/locale/pl/viewer.ftl M Source/ThirdParty/pdfjs/web/locale/pt-BR/viewer.ftl M Source/ThirdParty/pdfjs/web/locale/rm/viewer.ftl M Source/ThirdParty/pdfjs/web/locale/ru/viewer.ftl M Source/ThirdParty/pdfjs/web/locale/sk/viewer.ftl M Source/ThirdParty/pdfjs/web/locale/sl/viewer.ftl M Source/ThirdParty/pdfjs/web/locale/sq/viewer.ftl M Source/ThirdParty/pdfjs/web/locale/sv-SE/viewer.ftl M Source/ThirdParty/pdfjs/web/locale/tg/viewer.ftl M Source/ThirdParty/pdfjs/web/locale/tr/viewer.ftl M Source/ThirdParty/pdfjs/web/locale/uk/viewer.ftl M Source/ThirdParty/pdfjs/web/locale/vi/viewer.ftl M Source/ThirdParty/pdfjs/web/locale/zh-CN/viewer.ftl M Source/ThirdParty/pdfjs/web/locale/zh-TW/viewer.ftl M Source/ThirdParty/pdfjs/web/viewer.css M Source/ThirdParty/pdfjs/web/viewer.html M Source/ThirdParty/pdfjs/web/viewer.mjs Log Message: --- Update to PDF.js v4.0.379 https://bugs.webkit.org/show_bug.cgi?id=266987 Reviewed by Tim Nguyen. * Source/ThirdParty/pdfjs/PdfJSFiles.cmake: * Source/ThirdParty/pdfjs/README.webkit: * Source/ThirdParty/pdfjs/build/pdf.mjs: * Source/ThirdParty/pdfjs/build/pdf.sandbox.mjs: * Source/ThirdParty/pdfjs/build/pdf.worker.mjs: * Source/ThirdParty/pdfjs/web/images/toolbarButton-editorHighlight.svg: Added. * Source/ThirdParty/pdfjs/web/locale/be/viewer.ftl: * Source/ThirdParty/pdfjs/web/locale/br/viewer.ftl: * Source/ThirdParty/pdfjs/web/locale/cs/viewer.ftl: * Source/ThirdParty/pdfjs/web/locale/cy/viewer.ftl: * Source/ThirdParty/pdfjs/web/locale/da/viewer.ftl: * Source/ThirdParty/pdfjs/web/locale/de/viewer.ftl: * Source/ThirdParty/pdfjs/web/locale/dsb/viewer.ftl: * Source/ThirdParty/pdfjs/web/locale/el/viewer.ftl: * Source/ThirdParty/pdfjs/web/locale/en-GB/viewer.ftl: * Source/ThirdParty/pdfjs/web/locale/en-US/viewer.ftl: * Source/ThirdParty/pdfjs/web/locale/es-AR/viewer.ftl: * Source/ThirdParty/pdfjs/web/locale/es-CL/viewer.ftl: * Source/ThirdParty/pdfjs/web/locale/es-ES/viewer.ftl: * Source/ThirdParty/pdfjs/web/locale/fi/viewer.ftl: * Source/ThirdParty/pdfjs/web/locale/fr/viewer.ftl: * Source/ThirdParty/pdfjs/web/locale/fur/viewer.ftl: * Source/ThirdParty/pdfjs/web/locale/fy-NL/viewer.ftl: * Source/ThirdParty/pdfjs/web/locale/gn/viewer.ftl: * Source/ThirdParty/pdfjs/web/locale/he/viewer.ftl: * Source/ThirdParty/pdfjs/web/locale/hsb/viewer.ftl: * Source/ThirdParty/pdfjs/web/locale/hu/viewer.ftl: * Source/ThirdParty/pdfjs/web/locale/ia/viewer.ftl: * Source/ThirdParty/pdfjs
[webkit-changes] [WebKit/WebKit] 80ae63: Unreviewed, reverting 272572@main
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 80ae6344b2316e8f53345ae4e94a3b6d4ebe8c44 https://github.com/WebKit/WebKit/commit/80ae6344b2316e8f53345ae4e94a3b6d4ebe8c44 Author: Michael Catanzaro Date: 2024-01-02 (Tue, 02 Jan 2024) Changed paths: M Source/WebCore/CMakeLists.txt M Source/WebCore/WebCoreMacros.cmake Log Message: --- Unreviewed, reverting 272572@main https://bugs.webkit.org/show_bug.cgi?id=266997 Changes are incorrect, the deps are mostly backwards now Reverted change: Remove ADD_SOURCE_WEBCORE_DERIVED_DEPENDENCIES macro https://bugs.webkit.org/show_bug.cgi?id=266984 https://commits.webkit.org/272572@main Canonical link: https://commits.webkit.org/272578@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] e14694: Remove ADD_SOURCE_WEBCORE_DERIVED_DEPENDENCIES macro
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: e146946d0b72786e7716b27092827dd3ab102029 https://github.com/WebKit/WebKit/commit/e146946d0b72786e7716b27092827dd3ab102029 Author: Michael Catanzaro Date: 2024-01-02 (Tue, 02 Jan 2024) Changed paths: M Source/WebCore/CMakeLists.txt M Source/WebCore/WebCoreMacros.cmake Log Message: --- Remove ADD_SOURCE_WEBCORE_DERIVED_DEPENDENCIES macro https://bugs.webkit.org/show_bug.cgi?id=266984 Reviewed by Darin Adler. This macro doesn't seem very useful as it can generally be replaced by just adding DEPENDS to the command that generates the dependencies. The only exception is MathMLNames.cpp, which needs to be handled manually. This also fixes the dependency on CSSSelectorParser.cpp which was broken when the file moved. * Source/WebCore/CMakeLists.txt: * Source/WebCore/WebCoreMacros.cmake: Canonical link: https://commits.webkit.org/272572@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 0ff5cc: [WPE][GTK] Remove pkg-config use from FindLibBackt...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 0ff5cc83058a1ec8db37ffa6784eed55eaa232b5 https://github.com/WebKit/WebKit/commit/0ff5cc83058a1ec8db37ffa6784eed55eaa232b5 Author: Michael Catanzaro Date: 2023-12-19 (Tue, 19 Dec 2023) Changed paths: M Source/cmake/FindLibBacktrace.cmake Log Message: --- [WPE][GTK] Remove pkg-config use from FindLibBacktrace.cmake https://bugs.webkit.org/show_bug.cgi?id=265813 Reviewed by Adrian Perez de Castro. libbacktrace upstream does not distribute a pkg-config file. Apparently some downstreams are doing this, but I'm not sure who, because this software is not packaged in major distros like Debian or Fedora. It's not likely to be, because it doesn't have any releases. Let's not attempt to use a downstream-only pkg-config file. If pkg-config support can be upstream, that would be great. * Source/cmake/FindLibBacktrace.cmake: Canonical link: https://commits.webkit.org/272292@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 3633f4: glib-reviewers should not own libwebrtc directories
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 3633f4ec40d4f89701c1ae27434402133500ae8b https://github.com/WebKit/WebKit/commit/3633f4ec40d4f89701c1ae27434402133500ae8b Author: Michael Catanzaro Date: 2023-12-12 (Tue, 12 Dec 2023) Changed paths: M .github/CODEOWNERS Log Message: --- glib-reviewers should not own libwebrtc directories https://bugs.webkit.org/show_bug.cgi?id=266219 Reviewed by Jonathan Bedard. Unfortunately there's no good way to do this without giving up ownership of linux directories outside libwebrtc, but we can at least manually denylist particular paths that we don't want to own, which will work until more paths get added in the future. * .github/CODEOWNERS: Canonical link: https://commits.webkit.org/271931@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 08395c: REGRESSION(267629@main): create_hash_table script ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 08395c362d950165a0646c78ce89101979ba2618 https://github.com/WebKit/WebKit/commit/08395c362d950165a0646c78ce89101979ba2618 Author: Michael Catanzaro Date: 2023-12-08 (Fri, 08 Dec 2023) Changed paths: M Source/JavaScriptCore/create_hash_table M Source/WebCore/bindings/scripts/Hasher.pm M Source/WebCore/bindings/scripts/test/JS/JSTestConditionallyReadWrite.cpp M Source/WebCore/bindings/scripts/test/JS/JSTestGlobalObject.cpp Log Message: --- REGRESSION(267629@main): create_hash_table script runs forever on i686 https://bugs.webkit.org/show_bug.cgi?id=265554 Reviewed by Mark Lam. This reverts 267629@main, and also adds some additional safety checks to the create_hash_table script. bigint and Math::BigInt are two completely different perl modules. bigint causes the entire script to transparently use Math::BigInt for mathematical operations. Importing the wrong module effectively sabotaged the script. Whoops. bigint appears to be part of a standard perl installation, so for upstream purposes we can expect it to be always available. However, Fedora packages the perl interpreter separately from its modules. When I went to install the bigint module, I tricked myself into thinking it was already installed because Math::BigInt was installed, and another developer suggested that the import syntax was wrong, and I improperly went along with this because I am not very familiar with perl. So, fix the import syntax to make this script actually use big integers again. This fixes an infinite loop on 32-bit platforms if perl is not compiled with 64-bit integer support. It also affects the generated hash tables, so I had to rebase two of the bindings test results. Also, add new safety checks to ensure the script fails if the hash size grows too large. This will prevent the script from infinite looping if somebody else breaks the script in the future. The guard values I selected are arbitrary numbers that are much bigger than expected. * Source/JavaScriptCore/create_hash_table: * Source/WebCore/bindings/scripts/Hasher.pm: * Source/WebCore/bindings/scripts/test/JS/JSTestConditionallyReadWrite.cpp: (WebCore::JSTestConditionallyReadWriteDOMConstructor::prototypeForStructure): * Source/WebCore/bindings/scripts/test/JS/JSTestGlobalObject.cpp: Canonical link: https://commits.webkit.org/271765@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 22c4ad: Fix a typo and rename a variable in create_hash_ta...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 22c4ad895901e0d6efefa325bc1df4e63c44e2b8 https://github.com/WebKit/WebKit/commit/22c4ad895901e0d6efefa325bc1df4e63c44e2b8 Author: Michael Catanzaro Date: 2023-12-08 (Fri, 08 Dec 2023) Changed paths: M Source/JavaScriptCore/create_hash_table Log Message: --- Fix a typo and rename a variable in create_hash_table script https://bugs.webkit.org/show_bug.cgi?id=266029 Reviewed by Don Olmstead. This just fixes a typo, and also renames a confusing/misleading variable. * Source/JavaScriptCore/create_hash_table: Canonical link: https://commits.webkit.org/271742@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 898941: Update to PDF.js v4.0.269
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 898941b34f885c463b0e634394dd84ff6d4d8c4d https://github.com/WebKit/WebKit/commit/898941b34f885c463b0e634394dd84ff6d4d8c4d Author: Michael Catanzaro Date: 2023-11-30 (Thu, 30 Nov 2023) Changed paths: M Source/ThirdParty/pdfjs/PdfJSFiles.cmake M Source/ThirdParty/pdfjs/build/pdf.mjs M Source/ThirdParty/pdfjs/build/pdf.sandbox.mjs M Source/ThirdParty/pdfjs/build/pdf.worker.mjs A Source/ThirdParty/pdfjs/web/images/editor-toolbar-delete.svg R Source/ThirdParty/pdfjs/web/images/loading-dark.svg M Source/ThirdParty/pdfjs/web/locale/be/viewer.ftl M Source/ThirdParty/pdfjs/web/locale/cy/viewer.ftl M Source/ThirdParty/pdfjs/web/locale/da/viewer.ftl M Source/ThirdParty/pdfjs/web/locale/dsb/viewer.ftl M Source/ThirdParty/pdfjs/web/locale/el/viewer.ftl M Source/ThirdParty/pdfjs/web/locale/en-GB/viewer.ftl M Source/ThirdParty/pdfjs/web/locale/en-US/viewer.ftl M Source/ThirdParty/pdfjs/web/locale/eo/viewer.ftl M Source/ThirdParty/pdfjs/web/locale/es-CL/viewer.ftl M Source/ThirdParty/pdfjs/web/locale/fi/viewer.ftl M Source/ThirdParty/pdfjs/web/locale/fr/viewer.ftl M Source/ThirdParty/pdfjs/web/locale/gl/viewer.ftl M Source/ThirdParty/pdfjs/web/locale/gn/viewer.ftl M Source/ThirdParty/pdfjs/web/locale/he/viewer.ftl M Source/ThirdParty/pdfjs/web/locale/hsb/viewer.ftl M Source/ThirdParty/pdfjs/web/locale/ia/viewer.ftl M Source/ThirdParty/pdfjs/web/locale/is/viewer.ftl M Source/ThirdParty/pdfjs/web/locale/it/viewer.ftl M Source/ThirdParty/pdfjs/web/locale/kab/viewer.ftl M Source/ThirdParty/pdfjs/web/locale/kk/viewer.ftl M Source/ThirdParty/pdfjs/web/locale/ko/viewer.ftl M Source/ThirdParty/pdfjs/web/locale/locale.json M Source/ThirdParty/pdfjs/web/locale/nb-NO/viewer.ftl M Source/ThirdParty/pdfjs/web/locale/pl/viewer.ftl M Source/ThirdParty/pdfjs/web/locale/pt-BR/viewer.ftl M Source/ThirdParty/pdfjs/web/locale/pt-PT/viewer.ftl M Source/ThirdParty/pdfjs/web/locale/rm/viewer.ftl M Source/ThirdParty/pdfjs/web/locale/ru/viewer.ftl M Source/ThirdParty/pdfjs/web/locale/sk/viewer.ftl M Source/ThirdParty/pdfjs/web/locale/sl/viewer.ftl M Source/ThirdParty/pdfjs/web/locale/sq/viewer.ftl M Source/ThirdParty/pdfjs/web/locale/sv-SE/viewer.ftl M Source/ThirdParty/pdfjs/web/locale/th/viewer.ftl M Source/ThirdParty/pdfjs/web/locale/tr/viewer.ftl M Source/ThirdParty/pdfjs/web/locale/vi/viewer.ftl M Source/ThirdParty/pdfjs/web/locale/zh-CN/viewer.ftl M Source/ThirdParty/pdfjs/web/locale/zh-TW/viewer.ftl M Source/ThirdParty/pdfjs/web/viewer.css M Source/ThirdParty/pdfjs/web/viewer.html M Source/ThirdParty/pdfjs/web/viewer.mjs Log Message: --- Update to PDF.js v4.0.269 https://bugs.webkit.org/show_bug.cgi?id=265587 Reviewed by Tim Nguyen. * Source/ThirdParty/pdfjs/PdfJSFiles.cmake: * Source/ThirdParty/pdfjs/build/pdf.mjs: * Source/ThirdParty/pdfjs/build/pdf.sandbox.mjs: * Source/ThirdParty/pdfjs/build/pdf.worker.mjs: * Source/ThirdParty/pdfjs/web/images/editor-toolbar-delete.svg: Added. * Source/ThirdParty/pdfjs/web/images/loading-dark.svg: Removed. * Source/ThirdParty/pdfjs/web/locale/be/viewer.ftl: * Source/ThirdParty/pdfjs/web/locale/cy/viewer.ftl: * Source/ThirdParty/pdfjs/web/locale/da/viewer.ftl: * Source/ThirdParty/pdfjs/web/locale/dsb/viewer.ftl: * Source/ThirdParty/pdfjs/web/locale/el/viewer.ftl: * Source/ThirdParty/pdfjs/web/locale/en-GB/viewer.ftl: * Source/ThirdParty/pdfjs/web/locale/en-US/viewer.ftl: * Source/ThirdParty/pdfjs/web/locale/eo/viewer.ftl: * Source/ThirdParty/pdfjs/web/locale/es-CL/viewer.ftl: * Source/ThirdParty/pdfjs/web/locale/fi/viewer.ftl: * Source/ThirdParty/pdfjs/web/locale/fr/viewer.ftl: * Source/ThirdParty/pdfjs/web/locale/gl/viewer.ftl: * Source/ThirdParty/pdfjs/web/locale/gn/viewer.ftl: * Source/ThirdParty/pdfjs/web/locale/he/viewer.ftl: * Source/ThirdParty/pdfjs/web/locale/hsb/viewer.ftl: * Source/ThirdParty/pdfjs/web/locale/ia/viewer.ftl: * Source/ThirdParty/pdfjs/web/locale/is/viewer.ftl: * Source/ThirdParty/pdfjs/web/locale/it/viewer.ftl: * Source/ThirdParty/pdfjs/web/locale/kab/viewer.ftl: * Source/ThirdParty/pdfjs/web/locale/kk/viewer.ftl: * Source/ThirdParty/pdfjs/web/locale/ko/viewer.ftl: * Source/ThirdParty/pdfjs/web/locale/locale.json: * Source/ThirdParty/pdfjs/web/locale/nb-NO/viewer.ftl: * Source/ThirdParty/pdfjs/web/locale/pl/viewer.ftl: * Source/ThirdParty/pdfjs/web/locale/pt-BR/viewer.ftl: * Source/ThirdParty/pdfjs/web/locale/pt-PT/viewer.ftl: * Source/ThirdParty/pdfjs/web/locale/rm/viewer.ftl: * Source/ThirdParty/pdfjs/web/locale/ru/viewer.ftl: * Source/ThirdParty/pdfjs/web/locale/sk/viewer.ftl: * Source/ThirdParty/pdfjs/web/locale/sl/viewer.ftl: * Source/ThirdParty/pdfjs/web/locale/sq/viewer.ftl: * Source/ThirdParty/pdfjs/web/locale/sv-SE/viewer.ftl: * Source/ThirdParty/pdfjs/web/locale/th/viewer.ftl
[webkit-changes] [WebKit/WebKit] e2a9eb: REGRESSION(270651@main): Broke cloop build: LowLev...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: e2a9ebe5b7dae0aaa64d5de1040a67f56eaa60e9 https://github.com/WebKit/WebKit/commit/e2a9ebe5b7dae0aaa64d5de1040a67f56eaa60e9 Author: Michael Catanzaro Date: 2023-11-30 (Thu, 30 Nov 2023) Changed paths: M Source/cmake/WebKitFeatures.cmake Log Message: --- REGRESSION(270651@main): Broke cloop build: LowLevelInterpreter.asm:2778 in call to entry: Could not find macro entry (MacroError) https://bugs.webkit.org/show_bug.cgi?id=265218 Reviewed by Don Olmstead. WebAssembly no longer requires JIT, but it's still incompatible with cloop, so let's make sure you cannot build with both enabled and set an appropriate default value for each architecture. This is my second attempt to land this change. On the first attempt, r271252@main, I accidentally changed the default value of ENABLE_WEBASSEMBLY to "NOT". Let's do better this time. * Source/cmake/WebKitFeatures.cmake: Canonical link: https://commits.webkit.org/271347@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 49e6e8: REGRESSION(270651@main): Broke cloop build: LowLev...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 49e6e8770b5010d4fc27845088b8ff259b4910e7 https://github.com/WebKit/WebKit/commit/49e6e8770b5010d4fc27845088b8ff259b4910e7 Author: Michael Catanzaro Date: 2023-11-28 (Tue, 28 Nov 2023) Changed paths: M Source/cmake/WebKitFeatures.cmake Log Message: --- REGRESSION(270651@main): Broke cloop build: LowLevelInterpreter.asm:2778 in call to entry: Could not find macro entry (MacroError) https://bugs.webkit.org/show_bug.cgi?id=265218 Reviewed by Don Olmstead. WebAssembly no longer requires JIT, but it's still incompatible with cloop, so let's make sure you cannot build with both enabled and set an appropriate default value for each architecture. * Source/cmake/WebKitFeatures.cmake: Canonical link: https://commits.webkit.org/271252@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] a5bf27: [GLib] Install documentation into ${CMAKE_INSTALL_...
Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: a5bf27995f893b8c705661f9a417d79f1bcd4f77
https://github.com/WebKit/WebKit/commit/a5bf27995f893b8c705661f9a417d79f1bcd4f77
Author: Michael Catanzaro
Date: 2023-11-21 (Tue, 21 Nov 2023)
Changed paths:
M Source/cmake/FindGIDocgen.cmake
Log Message:
---
[GLib] Install documentation into ${CMAKE_INSTALL_DATADIR}/doc
https://bugs.webkit.org/show_bug.cgi?id=265133
Reviewed by Carlos Garcia Campos.
Projects that use gi-docgen do not generally install into the old
gtk-doc directory. Probably time to update our installation location.
* Source/cmake/FindGIDocgen.cmake:
Canonical link: https://commits.webkit.org/271014@main
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] bcd222: [SOUP] webkit_web_context_allow_tls_certificate_fo...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: bcd2223c93620870bc4b5dc8d077b10d1a3a0df3 https://github.com/WebKit/WebKit/commit/bcd2223c93620870bc4b5dc8d077b10d1a3a0df3 Author: Michael Catanzaro Date: 2023-11-21 (Tue, 21 Nov 2023) Changed paths: M Source/WebCore/platform/network/soup/SoupNetworkSession.cpp M Source/WebKit/UIProcess/API/glib/WebKitNetworkSession.cpp M Source/WebKit/UIProcess/API/glib/WebKitWebContext.cpp Log Message: --- [SOUP] webkit_web_context_allow_tls_certificate_for_host() fails for IPv6 URIs produced by SoupURI https://bugs.webkit.org/show_bug.cgi?id=195908 Reviewed by Carlos Garcia Campos. Nowadays SoupURI has been replaced by GUri, but the underlying problem remains: IPv6 addresses in URLs have to be surrounded by [] brackets, and WTF::URL considers these brackets to be part of the host component, but SoupURI and GUri do not. Alas! Let's also clarify expected usage of the API. It might be even better to accept input in both forms and normalize it, but GUri documents that the brackets are not part of the host, so probably fine for us to do so too. Finally, note this is a little awkward to test, so I have omitted tests. We could change WebKitTestServer::run to allow selecting IPV6 and then run all of TestSSL again twice, and skip them if IPv6 is not enabled. I was a little tempted to attempt this, but decided I'm lazy and would rather not spend time on it. This is already an edge case and it's not the end of the world if it breaks again in the future. * Source/WebCore/platform/network/soup/SoupNetworkSession.cpp: (WebCore::hostForComparison): (WebCore::SoupNetworkSession::checkTLSErrors): * Source/WebKit/UIProcess/API/glib/WebKitNetworkSession.cpp: * Source/WebKit/UIProcess/API/glib/WebKitWebContext.cpp: Canonical link: https://commits.webkit.org/271013@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 3ae0cd: Add assertions to ensure memcpySpan and memsetSpan...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 3ae0cd09762de6f9fd715033fc108bdf5fc1d3d0 https://github.com/WebKit/WebKit/commit/3ae0cd09762de6f9fd715033fc108bdf5fc1d3d0 Author: Michael Catanzaro Date: 2023-11-15 (Wed, 15 Nov 2023) Changed paths: M Source/WTF/wtf/Algorithms.h Log Message: --- Add assertions to ensure memcpySpan and memsetSpan are used on trivially copyable spans https://bugs.webkit.org/show_bug.cgi?id=264619 Reviewed by Darin Adler. Bad things are likely to happen if used on objects with custom constructors or destructors or assignment operators, because they won't be executed. Add safety checks for this. * Source/WTF/wtf/Algorithms.h: (WTF::memcpySpan): (WTF::memsetSpan): Canonical link: https://commits.webkit.org/270796@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] ace4bf: Updated Swedish translation
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: ace4bfd6a10b346ba5a7b085d9116a1e616350ae https://github.com/WebKit/WebKit/commit/ace4bfd6a10b346ba5a7b085d9116a1e616350ae Author: Michael Catanzaro Date: 2023-11-13 (Mon, 13 Nov 2023) Changed paths: M Source/WebCore/platform/gtk/po/sv.po Log Message: --- Updated Swedish translation https://bugs.webkit.org/show_bug.cgi?id=264671 Unreviewed translation update. * Source/WebCore/platform/gtk/po/sv.po: Canonical link: https://commits.webkit.org/270653@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 58df23: REGRESSION(266247@main): PDF "Save" button does no...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 58df23fe5ac509adc2117503127e97d53b02445b https://github.com/WebKit/WebKit/commit/58df23fe5ac509adc2117503127e97d53b02445b Author: Michael Catanzaro Date: 2023-11-06 (Mon, 06 Nov 2023) Changed paths: M Source/WebCore/page/SecurityOrigin.cpp Log Message: --- REGRESSION(266247@main): PDF "Save" button does nothing, "Print" function also broken https://bugs.webkit.org/show_bug.cgi?id=260771 Reviewed by Chris Dumez. The PDF.js viewer protocol and resource protocols both should be treated the same as HTTP protocols and have access to blob URLs. The protocol is an implementation detail that shouldn't affect how the web content behaves and certainly should not restrict access to web platform features. * Source/WebCore/page/SecurityOrigin.cpp: (WebCore::isSafelistedBlobProtocol): Canonical link: https://commits.webkit.org/270274@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 245f14: Upgrade to PDF.js v4.0.189
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 245f14a57d24bd0e8ddfa93fe5013efc8529d3a6 https://github.com/WebKit/WebKit/commit/245f14a57d24bd0e8ddfa93fe5013efc8529d3a6 Author: Michael Catanzaro Date: 2023-11-06 (Mon, 06 Nov 2023) Changed paths: M Source/ThirdParty/pdfjs/PdfJSFiles.cmake R Source/ThirdParty/pdfjs/build/pdf.js A Source/ThirdParty/pdfjs/build/pdf.mjs R Source/ThirdParty/pdfjs/build/pdf.sandbox.js A Source/ThirdParty/pdfjs/build/pdf.sandbox.mjs R Source/ThirdParty/pdfjs/build/pdf.worker.js A Source/ThirdParty/pdfjs/build/pdf.worker.mjs M Source/ThirdParty/pdfjs/web/debugger.css R Source/ThirdParty/pdfjs/web/debugger.js A Source/ThirdParty/pdfjs/web/debugger.mjs A Source/ThirdParty/pdfjs/web/locale/ach/viewer.ftl R Source/ThirdParty/pdfjs/web/locale/ach/viewer.properties A Source/ThirdParty/pdfjs/web/locale/af/viewer.ftl R Source/ThirdParty/pdfjs/web/locale/af/viewer.properties A Source/ThirdParty/pdfjs/web/locale/an/viewer.ftl R Source/ThirdParty/pdfjs/web/locale/an/viewer.properties A Source/ThirdParty/pdfjs/web/locale/ar/viewer.ftl R Source/ThirdParty/pdfjs/web/locale/ar/viewer.properties A Source/ThirdParty/pdfjs/web/locale/ast/viewer.ftl R Source/ThirdParty/pdfjs/web/locale/ast/viewer.properties A Source/ThirdParty/pdfjs/web/locale/az/viewer.ftl R Source/ThirdParty/pdfjs/web/locale/az/viewer.properties A Source/ThirdParty/pdfjs/web/locale/be/viewer.ftl R Source/ThirdParty/pdfjs/web/locale/be/viewer.properties A Source/ThirdParty/pdfjs/web/locale/bg/viewer.ftl R Source/ThirdParty/pdfjs/web/locale/bg/viewer.properties A Source/ThirdParty/pdfjs/web/locale/bn/viewer.ftl R Source/ThirdParty/pdfjs/web/locale/bn/viewer.properties A Source/ThirdParty/pdfjs/web/locale/bo/viewer.ftl R Source/ThirdParty/pdfjs/web/locale/bo/viewer.properties A Source/ThirdParty/pdfjs/web/locale/br/viewer.ftl R Source/ThirdParty/pdfjs/web/locale/br/viewer.properties A Source/ThirdParty/pdfjs/web/locale/brx/viewer.ftl R Source/ThirdParty/pdfjs/web/locale/brx/viewer.properties A Source/ThirdParty/pdfjs/web/locale/bs/viewer.ftl R Source/ThirdParty/pdfjs/web/locale/bs/viewer.properties A Source/ThirdParty/pdfjs/web/locale/ca/viewer.ftl R Source/ThirdParty/pdfjs/web/locale/ca/viewer.properties A Source/ThirdParty/pdfjs/web/locale/cak/viewer.ftl R Source/ThirdParty/pdfjs/web/locale/cak/viewer.properties A Source/ThirdParty/pdfjs/web/locale/ckb/viewer.ftl R Source/ThirdParty/pdfjs/web/locale/ckb/viewer.properties A Source/ThirdParty/pdfjs/web/locale/cs/viewer.ftl R Source/ThirdParty/pdfjs/web/locale/cs/viewer.properties A Source/ThirdParty/pdfjs/web/locale/cy/viewer.ftl R Source/ThirdParty/pdfjs/web/locale/cy/viewer.properties A Source/ThirdParty/pdfjs/web/locale/da/viewer.ftl R Source/ThirdParty/pdfjs/web/locale/da/viewer.properties A Source/ThirdParty/pdfjs/web/locale/de/viewer.ftl R Source/ThirdParty/pdfjs/web/locale/de/viewer.properties A Source/ThirdParty/pdfjs/web/locale/dsb/viewer.ftl R Source/ThirdParty/pdfjs/web/locale/dsb/viewer.properties A Source/ThirdParty/pdfjs/web/locale/el/viewer.ftl R Source/ThirdParty/pdfjs/web/locale/el/viewer.properties A Source/ThirdParty/pdfjs/web/locale/en-CA/viewer.ftl R Source/ThirdParty/pdfjs/web/locale/en-CA/viewer.properties A Source/ThirdParty/pdfjs/web/locale/en-GB/viewer.ftl R Source/ThirdParty/pdfjs/web/locale/en-GB/viewer.properties A Source/ThirdParty/pdfjs/web/locale/en-US/viewer.ftl R Source/ThirdParty/pdfjs/web/locale/en-US/viewer.properties A Source/ThirdParty/pdfjs/web/locale/eo/viewer.ftl R Source/ThirdParty/pdfjs/web/locale/eo/viewer.properties A Source/ThirdParty/pdfjs/web/locale/es-AR/viewer.ftl R Source/ThirdParty/pdfjs/web/locale/es-AR/viewer.properties A Source/ThirdParty/pdfjs/web/locale/es-CL/viewer.ftl R Source/ThirdParty/pdfjs/web/locale/es-CL/viewer.properties A Source/ThirdParty/pdfjs/web/locale/es-ES/viewer.ftl R Source/ThirdParty/pdfjs/web/locale/es-ES/viewer.properties A Source/ThirdParty/pdfjs/web/locale/es-MX/viewer.ftl R Source/ThirdParty/pdfjs/web/locale/es-MX/viewer.properties A Source/ThirdParty/pdfjs/web/locale/et/viewer.ftl R Source/ThirdParty/pdfjs/web/locale/et/viewer.properties A Source/ThirdParty/pdfjs/web/locale/eu/viewer.ftl R Source/ThirdParty/pdfjs/web/locale/eu/viewer.properties A Source/ThirdParty/pdfjs/web/locale/fa/viewer.ftl R Source/ThirdParty/pdfjs/web/locale/fa/viewer.properties A Source/ThirdParty/pdfjs/web/locale/ff/viewer.ftl R Source/ThirdParty/pdfjs/web/locale/ff/viewer.properties A Source/ThirdParty/pdfjs/web/locale/fi/viewer.ftl R Source/ThirdParty/pdfjs/web/locale/fi/viewer.properties A Source/ThirdParty/pdfjs/web/locale/fr/viewer.ftl R Source
[webkit-changes] [WebKit/WebKit] 0f803e: Fix incorrect storage of AudioSourceProviderGStreamer
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 0f803ec2d5e6630eb8915594772e31036d460537 https://github.com/WebKit/WebKit/commit/0f803ec2d5e6630eb8915594772e31036d460537 Author: Michael Catanzaro Date: 2023-11-06 (Mon, 06 Nov 2023) Changed paths: M Source/WebCore/platform/audio/gstreamer/AudioSourceProviderGStreamer.h M Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp M Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h Log Message: --- Fix incorrect storage of AudioSourceProviderGStreamer https://bugs.webkit.org/show_bug.cgi?id=264119 Reviewed by Xabier Rodriguez-Calvar and Philippe Normand We cannot store refcounted objects in a std::unique_ptr since the object may be deleted with an outstanding reference. Part of the problem here is that AudioSourceProviderGStreamer may or may not be a refcounted object depending on whether ENABLE(MEDIA_STREAM) is used. If disabled, then it inherits from AudioSourceProvider, which is not refcounted. If enabled, then it inherits from WebAudioSourceProvider, which just adds refcounting and nothing else. There is no reason this should be dependent on the value of ENABLE(MEDIA_STREAM) so we can just always inherit from WebAudioSourceProvider. * Source/WebCore/platform/audio/gstreamer/AudioSourceProviderGStreamer.h: * Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivateGStreamer::ensureAudioSourceProvider): * Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h: Canonical link: https://commits.webkit.org/270266@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 9664b1: Remove references to GTK+ and WebKitGTK+ from README
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 9664b14bb15565f7928c6a3a61ab0bc703e482da https://github.com/WebKit/WebKit/commit/9664b14bb15565f7928c6a3a61ab0bc703e482da Author: Michael Catanzaro Date: 2023-11-03 (Fri, 03 Nov 2023) Changed paths: M ReadMe.md Log Message: --- Remove references to GTK+ and WebKitGTK+ from README https://bugs.webkit.org/show_bug.cgi?id=264161 Reviewed by Carlos Garcia Campos. GTK+ was renamed to GTK in GTK 4, and we renamed WebKitGTK+ to WebKitGTK correspondingly. Don't put punctuation in names. Just don't. Looking at you, Pop!_OS. * ReadMe.md: Canonical link: https://commits.webkit.org/270183@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 1a44c4: Fix AudioSourceProviderGStreamer build with !ENABL...
Branch: refs/heads/webkitglib/2.42 Home: https://github.com/WebKit/WebKit Commit: 1a44c46ec3d867f20bb9ddb7371e550e183e4fea https://github.com/WebKit/WebKit/commit/1a44c46ec3d867f20bb9ddb7371e550e183e4fea Author: Michael Catanzaro Date: 2023-11-03 (Fri, 03 Nov 2023) Changed paths: M Source/WebCore/platform/audio/gstreamer/AudioSourceProviderGStreamer.h Log Message: --- Fix AudioSourceProviderGStreamer build with !ENABLE(MEDIA_STREAM) https://bugs.webkit.org/show_bug.cgi?id=264119 This an another unreviewed stable branch commit, including the latest changes that I've proposed in: https://github.com/WebKit/WebKit/pull/19920 ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 34b806: Cherry-pick 265870.524@safari-7616-branch (5a87cf9...
itAPI/Tests/WTF/RobinHoodHashMap.cpp: (TestWebKitAPI::TEST): * Tools/TestWebKitAPI/Tests/WTF/RobinHoodHashSet.cpp: (TestWebKitAPI::TEST): Canonical link: https://commits.webkit.org/265870.533@safari-7616-branch Commit: e2a2dcf04b9f7b15e47de15e5bc83c52a469862e https://github.com/WebKit/WebKit/commit/e2a2dcf04b9f7b15e47de15e5bc83c52a469862e Author: Michael Catanzaro Date: 2023-11-02 (Thu, 02 Nov 2023) Changed paths: M Source/WebCore/platform/audio/gstreamer/AudioSourceProviderGStreamer.h M Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp M Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h Log Message: --- Fix incorrect storage of AudioSourceProviderGStreamer https://bugs.webkit.org/show_bug.cgi?id=264119 Unreviewed stable branch commit. We cannot store refcounted objects in a std::unique_ptr since the object may be deleted with an outstanding reference. * Source/WebCore/platform/audio/gstreamer/AudioSourceProviderGStreamer.h: * Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivateGStreamer::ensureAudioSourceProvider): * Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h: Commit: 2e71064c029466c901f55603355367d6362929e3 https://github.com/WebKit/WebKit/commit/2e71064c029466c901f55603355367d6362929e3 Author: Chris Dumez Date: 2023-11-02 (Thu, 02 Nov 2023) Changed paths: M Source/WTF/wtf/Algorithms.h M Source/WebCore/platform/audio/AudioArray.h M Source/WebCore/platform/audio/AudioBus.cpp M Source/WebCore/platform/audio/AudioChannel.h M Source/WebCore/platform/audio/MultiChannelResampler.cpp M Source/WebCore/platform/audio/MultiChannelResampler.h M Source/WebCore/platform/audio/SincResampler.cpp M Source/WebCore/platform/audio/SincResampler.h Log Message: --- Security hardening for SincResampler https://bugs.webkit.org/show_bug.cgi?id=261317 rdar://105650262 Reviewed by David Kilzer and Darin Adler. Do security hardening for SincResampler as we have evidence that we're getting the logic wrong in some cases and doing a heap-buffer overflow WRITE. This patch updates SincResampler to use `std::span` instead of `float*` and to leverage new memcpySpans() / memsetSpan() functions I added to WTF. This had several benefits: - Using std::span means we don't lose tracks of our buffer bounds so we can do extra bounds checks. - We benefit from std::span's bounds checks too which are already enabled on trunk via `-D_LIBCPP_ENABLE_ASSERTIONS=1`. Those checks apply to subspan() and operator[] in particular, both of which are used by SincResampler. * Source/WTF/WTF.xcodeproj/project.pbxproj: * Source/WTF/wtf/Algorithms.h:. (WTF::memcpySpans): (WTF::memsetSpan): * Source/WebCore/platform/audio/AudioArray.h: (WebCore::AudioArray::toSpan): (WebCore::AudioArray::toSpan const): * Source/WebCore/platform/audio/AudioBus.cpp: (WebCore::AudioBus::createBySampleRateConverting): * Source/WebCore/platform/audio/AudioChannel.h: * Source/WebCore/platform/audio/MultiChannelResampler.cpp: (WebCore::MultiChannelResampler::process): (WebCore::MultiChannelResampler::provideInputForChannel): * Source/WebCore/platform/audio/MultiChannelResampler.h: * Source/WebCore/platform/audio/SincResampler.cpp: (WebCore::SincResampler::SincResampler): (WebCore::SincResampler::updateRegions): (WebCore::SincResampler::processBuffer): (WebCore::SincResampler::process): * Source/WebCore/platform/audio/SincResampler.h: Canonical link: https://commits.webkit.org/265870.537@safari-7616-branch Commit: c52c35eae9ab3df71d3fcac99c1c4dc85ef9493d https://github.com/WebKit/WebKit/commit/c52c35eae9ab3df71d3fcac99c1c4dc85ef9493d Author: David Kilzer Date: 2023-11-02 (Thu, 02 Nov 2023) Changed paths: M Source/WebCore/testing/js/WebCoreTestSupport.cpp M Source/WebCore/testing/js/WebCoreTestSupport.h Log Message: --- Add test function for WebCore::SincResampler https://bugs.webkit.org/show_bug.cgi?id=261702 Reviewed by Chris Dumez and Alex Christensen. Add test method that calls SincResampler::processBuffer(). * Source/WebCore/testing/js/WebCoreTestSupport.cpp: (WebCoreTestSupport::testSincResamplerProcessBuffer): Add. * Source/WebCore/testing/js/WebCoreTestSupport.h: (WebCoreTestSupport::testSincResamplerProcessBuffer): Add. Canonical link: https://commits.webkit.org/265870.567@safari-7616-branch Compare: https://github.com/WebKit/WebKit/compare/027d2d68cdf8...c52c35eae9ab ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] e57b85: Incorrect documentation for webkit-cookie-manager-...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: e57b85e56c4c6c0e7b6664645c18a6439eae6da6 https://github.com/WebKit/WebKit/commit/e57b85e56c4c6c0e7b6664645c18a6439eae6da6 Author: Michael Catanzaro Date: 2023-11-01 (Wed, 01 Nov 2023) Changed paths: M Source/WebKit/UIProcess/API/glib/WebKitCookieManager.cpp Log Message: --- Incorrect documentation for webkit-cookie-manager-get-cookies-finish https://bugs.webkit.org/show_bug.cgi?id=263967 Reviewed by Carlos Garcia Campos. This fixes a serious typo. GSList and GList are entirely separate, incompatible types. This tricked the Eclipse developers and now they have a type confusion problem because they trusted our incorrect documentation. See also: eclipse-platform/eclipse.platform.swt#842 * Source/WebKit/UIProcess/API/glib/WebKitCookieManager.cpp: Canonical link: https://commits.webkit.org/270058@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] bf6b86: Cherry-pick 269169@main (f0755ec8caee). https://bu...
Branch: refs/heads/webkitglib/2.42 Home: https://github.com/WebKit/WebKit Commit: bf6b866723cc350bdb738739331a78ed023af6e7 https://github.com/WebKit/WebKit/commit/bf6b866723cc350bdb738739331a78ed023af6e7 Author: Michael Catanzaro Date: 2023-10-19 (Thu, 19 Oct 2023) Changed paths: M Source/WebCore/platform/glib/UserAgentGLib.cpp Log Message: --- Cherry-pick 269169@main (f0755ec8caee). https://bugs.webkit.org/show_bug.cgi?id=262782 [WPE][GTK] Bump Safari version in user agent header https://bugs.webkit.org/show_bug.cgi?id=262782 Reviewed by Carlos Garcia Campos. * Source/WebCore/platform/glib/UserAgentGLib.cpp: (WebCore::buildUserAgentString): Canonical link: https://commits.webkit.org/269169@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] f0755e: [WPE][GTK] Bump Safari version in user agent header
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: f0755ec8caee20f08b8d830ec75a7c598a8ed459 https://github.com/WebKit/WebKit/commit/f0755ec8caee20f08b8d830ec75a7c598a8ed459 Author: Michael Catanzaro Date: 2023-10-10 (Tue, 10 Oct 2023) Changed paths: M Source/WebCore/platform/glib/UserAgentGLib.cpp Log Message: --- [WPE][GTK] Bump Safari version in user agent header https://bugs.webkit.org/show_bug.cgi?id=262782 Reviewed by Carlos Garcia Campos. * Source/WebCore/platform/glib/UserAgentGLib.cpp: (WebCore::buildUserAgentString): Canonical link: https://commits.webkit.org/269169@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] c29a26: Partially revert "Fix stack-overflow when dealing ...
Branch: refs/heads/webkitglib/2.42 Home: https://github.com/WebKit/WebKit Commit: c29a26a02441b64c881b173f2a1dde83e353e418 https://github.com/WebKit/WebKit/commit/c29a26a02441b64c881b173f2a1dde83e353e418 Author: Michael Catanzaro Date: 2023-10-10 (Tue, 10 Oct 2023) Changed paths: M Source/WebCore/fileapi/BlobURL.cpp Log Message: --- Partially revert "Fix stack-overflow when dealing with blobURL(s)" https://bugs.webkit.org/show_bug.cgi?id=262777 The code change here is incompatible with some other commit, most likely 266247@main. We can still keep the new test, though. This fixes Unity WebGL applications. * Source/WebCore/fileapi/BlobURL.cpp: (WebCore::BlobURL::isSecureBlobURL): ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 00cd7d: run-webkit-tests broken with python 3.12 due to er...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 00cd7de391a8b32ce47f4547b505e58373bdcc0b https://github.com/WebKit/WebKit/commit/00cd7de391a8b32ce47f4547b505e58373bdcc0b Author: Michael Catanzaro Date: 2023-09-30 (Sat, 30 Sep 2023) Changed paths: M Tools/Scripts/webkitpy/__init__.py Log Message: --- run-webkit-tests broken with python 3.12 due to error in beautifulsoup4 https://bugs.webkit.org/show_bug.cgi?id=262395 Reviewed by Philippe Normand. * Tools/Scripts/webkitpy/__init__.py: Canonical link: https://commits.webkit.org/268694@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] f474bd: Update to PDF.js v3.11.174
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: f474bd838acb98fc2881f950febcf88969c86c2a https://github.com/WebKit/WebKit/commit/f474bd838acb98fc2881f950febcf88969c86c2a Author: Michael Catanzaro Date: 2023-09-25 (Mon, 25 Sep 2023) Changed paths: M Source/ThirdParty/pdfjs/PdfJSFiles.cmake M Source/ThirdParty/pdfjs/build/pdf.js M Source/ThirdParty/pdfjs/build/pdf.sandbox.js M Source/ThirdParty/pdfjs/build/pdf.worker.js M Source/ThirdParty/pdfjs/web/debugger.css M Source/ThirdParty/pdfjs/web/debugger.js A Source/ThirdParty/pdfjs/web/images/altText_add.svg A Source/ThirdParty/pdfjs/web/images/altText_done.svg M Source/ThirdParty/pdfjs/web/locale/ach/viewer.properties M Source/ThirdParty/pdfjs/web/locale/be/viewer.properties M Source/ThirdParty/pdfjs/web/locale/cs/viewer.properties M Source/ThirdParty/pdfjs/web/locale/cy/viewer.properties M Source/ThirdParty/pdfjs/web/locale/da/viewer.properties M Source/ThirdParty/pdfjs/web/locale/de/viewer.properties M Source/ThirdParty/pdfjs/web/locale/dsb/viewer.properties M Source/ThirdParty/pdfjs/web/locale/el/viewer.properties M Source/ThirdParty/pdfjs/web/locale/en-CA/viewer.properties M Source/ThirdParty/pdfjs/web/locale/en-GB/viewer.properties M Source/ThirdParty/pdfjs/web/locale/en-US/viewer.properties M Source/ThirdParty/pdfjs/web/locale/eo/viewer.properties M Source/ThirdParty/pdfjs/web/locale/es-AR/viewer.properties M Source/ThirdParty/pdfjs/web/locale/es-CL/viewer.properties M Source/ThirdParty/pdfjs/web/locale/es-ES/viewer.properties M Source/ThirdParty/pdfjs/web/locale/eu/viewer.properties M Source/ThirdParty/pdfjs/web/locale/fi/viewer.properties M Source/ThirdParty/pdfjs/web/locale/fr/viewer.properties M Source/ThirdParty/pdfjs/web/locale/fur/viewer.properties M Source/ThirdParty/pdfjs/web/locale/fy-NL/viewer.properties M Source/ThirdParty/pdfjs/web/locale/gl/viewer.properties M Source/ThirdParty/pdfjs/web/locale/gn/viewer.properties M Source/ThirdParty/pdfjs/web/locale/he/viewer.properties M Source/ThirdParty/pdfjs/web/locale/hi-IN/viewer.properties M Source/ThirdParty/pdfjs/web/locale/hsb/viewer.properties M Source/ThirdParty/pdfjs/web/locale/hu/viewer.properties M Source/ThirdParty/pdfjs/web/locale/ia/viewer.properties M Source/ThirdParty/pdfjs/web/locale/is/viewer.properties M Source/ThirdParty/pdfjs/web/locale/it/viewer.properties M Source/ThirdParty/pdfjs/web/locale/ja/viewer.properties M Source/ThirdParty/pdfjs/web/locale/ka/viewer.properties M Source/ThirdParty/pdfjs/web/locale/kab/viewer.properties M Source/ThirdParty/pdfjs/web/locale/kk/viewer.properties M Source/ThirdParty/pdfjs/web/locale/ko/viewer.properties M Source/ThirdParty/pdfjs/web/locale/mk/viewer.properties M Source/ThirdParty/pdfjs/web/locale/nb-NO/viewer.properties M Source/ThirdParty/pdfjs/web/locale/nl/viewer.properties M Source/ThirdParty/pdfjs/web/locale/nn-NO/viewer.properties M Source/ThirdParty/pdfjs/web/locale/oc/viewer.properties M Source/ThirdParty/pdfjs/web/locale/pa-IN/viewer.properties M Source/ThirdParty/pdfjs/web/locale/pl/viewer.properties M Source/ThirdParty/pdfjs/web/locale/pt-BR/viewer.properties M Source/ThirdParty/pdfjs/web/locale/pt-PT/viewer.properties M Source/ThirdParty/pdfjs/web/locale/rm/viewer.properties M Source/ThirdParty/pdfjs/web/locale/ru/viewer.properties M Source/ThirdParty/pdfjs/web/locale/sat/viewer.properties M Source/ThirdParty/pdfjs/web/locale/sc/viewer.properties M Source/ThirdParty/pdfjs/web/locale/si/viewer.properties M Source/ThirdParty/pdfjs/web/locale/sk/viewer.properties M Source/ThirdParty/pdfjs/web/locale/skr/viewer.properties M Source/ThirdParty/pdfjs/web/locale/sl/viewer.properties M Source/ThirdParty/pdfjs/web/locale/sv-SE/viewer.properties M Source/ThirdParty/pdfjs/web/locale/tg/viewer.properties M Source/ThirdParty/pdfjs/web/locale/th/viewer.properties M Source/ThirdParty/pdfjs/web/locale/tr/viewer.properties M Source/ThirdParty/pdfjs/web/locale/uk/viewer.properties M Source/ThirdParty/pdfjs/web/locale/vi/viewer.properties M Source/ThirdParty/pdfjs/web/locale/zh-CN/viewer.properties M Source/ThirdParty/pdfjs/web/locale/zh-TW/viewer.properties M Source/ThirdParty/pdfjs/web/viewer.css M Source/ThirdParty/pdfjs/web/viewer.html M Source/ThirdParty/pdfjs/web/viewer.js Log Message: --- Update to PDF.js v3.11.174 https://bugs.webkit.org/show_bug.cgi?id=262038 Reviewed by Tim Nguyen. * Source/ThirdParty/pdfjs/PdfJSFiles.cmake: * Source/ThirdParty/pdfjs/build/pdf.js: (webpackUniversalModuleDefinition): (return.): (return): * Source/ThirdParty/pdfjs/build/pdf.sandbox.js: (webpackUniversalModuleDefinition): * Source/ThirdParty/pdfjs/build/pdf.worker.js: (webpackUniversalModuleDefinition): (return
[webkit-changes] [WebKit/WebKit] 356c9d: GLContextX11.cpp:89:66: error: invalid cast from t...
Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 356c9d5d33e0e3883cdd5909a601fa5736495fff
https://github.com/WebKit/WebKit/commit/356c9d5d33e0e3883cdd5909a601fa5736495fff
Author: Michael Catanzaro
Date: 2023-09-19 (Tue, 19 Sep 2023)
Changed paths:
M Source/WebCore/platform/graphics/egl/GLContextX11.cpp
Log Message:
---
GLContextX11.cpp:89:66: error: invalid cast from type 'long unsigned int' to
type 'EGLNativePixmapType' {aka 'unsigned int'}
https://bugs.webkit.org/show_bug.cgi?id=261754
Unreviewed build fix.
As usual, we need to use C-style casts with EGL types.
* Source/WebCore/platform/graphics/egl/GLContextX11.cpp:
(WebCore::GLContext::createPixmapContext):
Canonical link: https://commits.webkit.org/268137@main
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] f21f4c: Cherry-pick 267995@main (8291bc027cb4). https://bu...
Branch: refs/heads/webkitglib/2.42 Home: https://github.com/WebKit/WebKit Commit: f21f4ca21ec834dc8dc0bcf97f484dad53b4835c https://github.com/WebKit/WebKit/commit/f21f4ca21ec834dc8dc0bcf97f484dad53b4835c Author: Michael Catanzaro Date: 2023-09-15 (Fri, 15 Sep 2023) Changed paths: M Source/WebCore/platform/gtk/po/sv.po Log Message: --- Cherry-pick 267995@main (8291bc027cb4). https://bugs.webkit.org/show_bug.cgi?id=261525 Updated Swedish translation https://bugs.webkit.org/show_bug.cgi?id=261525 Unreviewed translation update. * Source/WebCore/platform/gtk/po/sv.po: Canonical link: https://commits.webkit.org/267995@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 8291bc: Updated Swedish translation
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 8291bc027cb4e717d76a12dc281e5f45b15eb81b https://github.com/WebKit/WebKit/commit/8291bc027cb4e717d76a12dc281e5f45b15eb81b Author: Michael Catanzaro Date: 2023-09-14 (Thu, 14 Sep 2023) Changed paths: M Source/WebCore/platform/gtk/po/sv.po Log Message: --- Updated Swedish translation https://bugs.webkit.org/show_bug.cgi?id=261525 Unreviewed translation update. * Source/WebCore/platform/gtk/po/sv.po: Canonical link: https://commits.webkit.org/267995@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 501318: Fix typo handleLowModePowerChange -> handleLowPowe...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 501318a01eda030622502da8eceb37ab53676979 https://github.com/WebKit/WebKit/commit/501318a01eda030622502da8eceb37ab53676979 Author: Michael Catanzaro Date: 2023-09-12 (Tue, 12 Sep 2023) Changed paths: M Source/WebCore/page/Page.cpp M Source/WebCore/page/Page.h Log Message: --- Fix typo handleLowModePowerChange -> handleLowPowerModeChange https://bugs.webkit.org/show_bug.cgi?id=261447 Reviewed by Chris Dumez. * Source/WebCore/page/Page.cpp: (WebCore::Page::Page): (WebCore::Page::setLowPowerModeEnabledOverrideForTesting): (WebCore::Page::handleLowPowerModeChange): (WebCore::Page::handleLowModePowerChange): Deleted. * Source/WebCore/page/Page.h: Canonical link: https://commits.webkit.org/267898@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] ac567d: REGRESSION(267532@main): Cannot import bigint.pm e...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: ac567dde309e9b359df2f5508caad2e94ccec798 https://github.com/WebKit/WebKit/commit/ac567dde309e9b359df2f5508caad2e94ccec798 Author: Michael Catanzaro Date: 2023-09-05 (Tue, 05 Sep 2023) Changed paths: M Source/JavaScriptCore/create_hash_table M Source/WebCore/bindings/scripts/Hasher.pm Log Message: --- REGRESSION(267532@main): Cannot import bigint.pm even when installed https://bugs.webkit.org/show_bug.cgi?id=261150 Unreviewed build fix. This solution is suggested by Dan Horak (thanks!). * Source/JavaScriptCore/create_hash_table: * Source/WebCore/bindings/scripts/Hasher.pm: Canonical link: https://commits.webkit.org/267629@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] e57e1d: REGRESSION(267569@main?): WasmB3IRGenerator.h:59:2...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: e57e1d07f2ceae505ffd11badb7656271eab8c16 https://github.com/WebKit/WebKit/commit/e57e1d07f2ceae505ffd11badb7656271eab8c16 Author: Michael Catanzaro Date: 2023-09-05 (Tue, 05 Sep 2023) Changed paths: M Source/JavaScriptCore/wasm/WasmB3IRGenerator.h Log Message: --- REGRESSION(267569@main?): WasmB3IRGenerator.h:59:21: error: use of undeclared identifier 'BBQDisassembler' https://bugs.webkit.org/show_bug.cgi?id=261152 Unreviewed build fix. * Source/JavaScriptCore/wasm/WasmB3IRGenerator.h: Canonical link: https://commits.webkit.org/267628@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] ddb67f: [GTK] Wrong free function in documentation for web...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: ddb67f54d7679fd6910facd9b0091afe3f198451 https://github.com/WebKit/WebKit/commit/ddb67f54d7679fd6910facd9b0091afe3f198451 Author: Michael Catanzaro Date: 2023-09-02 (Sat, 02 Sep 2023) Changed paths: M Source/WebKit/UIProcess/API/glib/WebKitWebView.cpp Log Message: --- [GTK] Wrong free function in documentation for webkit_web_view_evaluate_javascript https://bugs.webkit.org/show_bug.cgi?id=261043 Reviewed by Adrian Perez de Castro. * Source/WebKit/UIProcess/API/glib/WebKitWebView.cpp: Canonical link: https://commits.webkit.org/267583@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] ade70b: SyntaxWarning when running 'git-webkit pr'
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: ade70bdb664e933e1244458b55965b877df48e51 https://github.com/WebKit/WebKit/commit/ade70bdb664e933e1244458b55965b877df48e51 Author: Michael Catanzaro Date: 2023-09-01 (Fri, 01 Sep 2023) Changed paths: M Tools/Scripts/webkitpy/common/checkout/checkout.py Log Message: --- SyntaxWarning when running 'git-webkit pr' https://bugs.webkit.org/show_bug.cgi?id=260729 Reviewed by Jonathan Bedard. The backslashes here are python string escapes, but they were intended to be regex escapes. Each \ would need to be replaced with \\ for them to function as regex escapes. We can use raw string notation to avoid this problem. * Tools/Scripts/webkitpy/common/checkout/checkout.py: (Checkout): Canonical link: https://commits.webkit.org/267558@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] e829b0: [GStreamer] Improve a debug message
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: e829b016db55bb336f68cb3198129b06bf432a1c https://github.com/WebKit/WebKit/commit/e829b016db55bb336f68cb3198129b06bf432a1c Author: Michael Catanzaro Date: 2023-09-01 (Fri, 01 Sep 2023) Changed paths: M Source/WebCore/platform/graphics/gstreamer/GStreamerSinksWorkarounds.cpp Log Message: --- [GStreamer] Improve a debug message https://bugs.webkit.org/show_bug.cgi?id=260993 Reviewed by Philippe Normand. Fix: "Running GStreamer GStreamer 1.22.5, the bug fix is was" * Source/WebCore/platform/graphics/gstreamer/GStreamerSinksWorkarounds.cpp: (WebCore::BaseSinkPositionFlushWorkaroundProbe::checkIsNeeded): Canonical link: https://commits.webkit.org/267548@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] dd6d24: Unreviewed, fix cloop build
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: dd6d24eb821c56b879594e5599f5a56246db https://github.com/WebKit/WebKit/commit/dd6d24eb821c56b879594e5599f5a56246db Author: Michael Catanzaro Date: 2023-08-31 (Thu, 31 Aug 2023) Changed paths: M Source/JavaScriptCore/b3/air/testair.cpp Log Message: --- Unreviewed, fix cloop build https://bugs.webkit.org/show_bug.cgi?id=260966 * Source/JavaScriptCore/b3/air/testair.cpp: Canonical link: https://commits.webkit.org/267504@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] aa8528: Fix -Wunneeded-internal-declaration build warning
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: aa8528f3bfb321b465e68ad0af3deec2b00fa0e2 https://github.com/WebKit/WebKit/commit/aa8528f3bfb321b465e68ad0af3deec2b00fa0e2 Author: Michael Catanzaro Date: 2023-08-30 (Wed, 30 Aug 2023) Changed paths: M Tools/TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp Log Message: --- Fix -Wunneeded-internal-declaration build warning https://bugs.webkit.org/show_bug.cgi?id=260629 Reviewed by Don Olmstead. * Tools/TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp: Canonical link: https://commits.webkit.org/267476@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] cb07c7: Cherry-pick 267461@main (160f1a456bf4). https://bu...
Branch: refs/heads/webkitglib/2.40 Home: https://github.com/WebKit/WebKit Commit: cb07c70c253a35b0e09e46e6100e1cdcebab26e2 https://github.com/WebKit/WebKit/commit/cb07c70c253a35b0e09e46e6100e1cdcebab26e2 Author: Michael Catanzaro Date: 2023-08-30 (Wed, 30 Aug 2023) Changed paths: M Tools/Scripts/libraries/webkitcorepy/webkitcorepy/__init__.py Log Message: --- Cherry-pick 267461@main (160f1a456bf4). https://bugs.webkit.org/show_bug.cgi?id=260889 REGRESSION(267415@main): Broke python autoinstaller for python 3.11 https://bugs.webkit.org/show_bug.cgi?id=260889 Reviewed by Jonathan Bedard. All of these python libraries are quite interdependent. Apparently beautifulsoup4 depends on functionality removed from the newer setuptools. * Tools/Scripts/libraries/webkitcorepy/webkitcorepy/__init__.py: Canonical link: https://commits.webkit.org/267461@main Canonical link: https://commits.webkit.org/260527.432@webkitglib/2.40 ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 7ea615: Cherry-pick 267461@main (160f1a456bf4). https://bu...
Branch: refs/heads/webkitglib/2.42 Home: https://github.com/WebKit/WebKit Commit: 7ea615c41bcd4ae49ba055197af47ec2c4982a7d https://github.com/WebKit/WebKit/commit/7ea615c41bcd4ae49ba055197af47ec2c4982a7d Author: Michael Catanzaro Date: 2023-08-30 (Wed, 30 Aug 2023) Changed paths: M Tools/Scripts/libraries/webkitcorepy/webkitcorepy/__init__.py Log Message: --- Cherry-pick 267461@main (160f1a456bf4). https://bugs.webkit.org/show_bug.cgi?id=260889 REGRESSION(267415@main): Broke python autoinstaller for python 3.11 https://bugs.webkit.org/show_bug.cgi?id=260889 Reviewed by Jonathan Bedard. All of these python libraries are quite interdependent. Apparently beautifulsoup4 depends on functionality removed from the newer setuptools. * Tools/Scripts/libraries/webkitcorepy/webkitcorepy/__init__.py: Canonical link: https://commits.webkit.org/267461@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 160f1a: REGRESSION(267415@main): Broke python autoinstalle...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 160f1a456bf42fc2e2e108ed207be765a8a68d7d https://github.com/WebKit/WebKit/commit/160f1a456bf42fc2e2e108ed207be765a8a68d7d Author: Michael Catanzaro Date: 2023-08-30 (Wed, 30 Aug 2023) Changed paths: M Tools/Scripts/libraries/webkitcorepy/webkitcorepy/__init__.py Log Message: --- REGRESSION(267415@main): Broke python autoinstaller for python 3.11 https://bugs.webkit.org/show_bug.cgi?id=260889 Reviewed by Jonathan Bedard. All of these python libraries are quite interdependent. Apparently beautifulsoup4 depends on functionality removed from the newer setuptools. * Tools/Scripts/libraries/webkitcorepy/webkitcorepy/__init__.py: Canonical link: https://commits.webkit.org/267461@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 9dce19: [SOUP] Increase maximum connection limit from 17 t...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 9dce195e0c90318049abf76809c8017ed13aa241 https://github.com/WebKit/WebKit/commit/9dce195e0c90318049abf76809c8017ed13aa241 Author: Michael Catanzaro Date: 2023-08-30 (Wed, 30 Aug 2023) Changed paths: M Source/WebCore/platform/network/soup/SoupNetworkSession.cpp Log Message: --- [SOUP] Increase maximum connection limit from 17 to 256 https://bugs.webkit.org/show_bug.cgi?id=260725 Reviewed by Carlos Garcia Campos. A long time ago, web browsers limited themselves to fairly small maximum connection limits. Nowadays, Chrome uses 256 and Firefox uses 900, but we still have a 17 connection limit established in 170917@main. I picked 17 for no other reason than that was what other browsers were doing at the time. That reasoning is as good now as ever, so time to increase. Note this has little effect on HTTP/2 and newer, as there we generally use only one or two connections total per origin. * Source/WebCore/platform/network/soup/SoupNetworkSession.cpp: (WebCore::SoupNetworkSession::SoupNetworkSession): Canonical link: https://commits.webkit.org/267455@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] cb4faa: python autoinstaller is broken with python 3.12
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: cb4faa2a3ee38601f41c1d60fcac002a83cec4ff https://github.com/WebKit/WebKit/commit/cb4faa2a3ee38601f41c1d60fcac002a83cec4ff Author: Michael Catanzaro Date: 2023-08-29 (Tue, 29 Aug 2023) Changed paths: M Tools/Scripts/libraries/webkitcorepy/webkitcorepy/__init__.py Log Message: --- python autoinstaller is broken with python 3.12 https://bugs.webkit.org/show_bug.cgi?id=260726 Reviewed by Jonathan Bedard. Currently git-webkit is broken with python 3.12 due to various problems with dependencies that are already fixed in newer upstream versions. So, update a few things. Unfortunately, the newer library versions are incompatible with other Python versions, so this means more conditional versions. * Tools/Scripts/libraries/webkitcorepy/webkitcorepy/__init__.py: Canonical link: https://commits.webkit.org/267415@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] e7fc91: Adjust webkitcorepy changes to match changes on ma...
Branch: refs/heads/webkitglib/2.42 Home: https://github.com/WebKit/WebKit Commit: e7fc913c06a2cda779749ccb09742214388d4c1a https://github.com/WebKit/WebKit/commit/e7fc913c06a2cda779749ccb09742214388d4c1a Author: Michael Catanzaro Date: 2023-08-29 (Tue, 29 Aug 2023) Changed paths: M Tools/Scripts/libraries/webkitcorepy/webkitcorepy/__init__.py Log Message: --- Adjust webkitcorepy changes to match changes on main branch This syncs 2.42 branch with https://github.com/WebKit/WebKit/pull/17076 * Tools/Scripts/libraries/webkitcorepy/webkitcorepy/__init__.py: Canonical link: https://commits.webkit.org/266719.27@webkitglib/2.42 ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] f8bf4f: python autoinstaller is broken with python 3.12
Branch: refs/heads/webkitglib/2.40 Home: https://github.com/WebKit/WebKit Commit: f8bf4f0e316b81b8197ed17e1f85eda838a836bb https://github.com/WebKit/WebKit/commit/f8bf4f0e316b81b8197ed17e1f85eda838a836bb Author: Michael Catanzaro Date: 2023-08-29 (Tue, 29 Aug 2023) Changed paths: M Tools/Scripts/libraries/webkitcorepy/webkitcorepy/__init__.py Log Message: --- python autoinstaller is broken with python 3.12 https://bugs.webkit.org/show_bug.cgi?id=260726 Reviewed by NOBODY (OOPS!). Currently git-webkit is broken with python 3.12 due to various problems with dependencies that are already fixed in newer upstream versions. So, update a few things. Unfortunately, the newer library versions are incompatible with other Python versions, so this means more conditional versions. * Tools/Scripts/libraries/webkitcorepy/webkitcorepy/__init__.py: Canonical link: https://commits.webkit.org/260527.430@webkitglib/2.40 ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] ad247f: python autoinstaller is broken with python 3.12
Branch: refs/heads/webkitglib/2.42 Home: https://github.com/WebKit/WebKit Commit: ad247f639619f2ec019a41bfaea5904f80d9c6b2 https://github.com/WebKit/WebKit/commit/ad247f639619f2ec019a41bfaea5904f80d9c6b2 Author: Michael Catanzaro Date: 2023-08-28 (Mon, 28 Aug 2023) Changed paths: M Tools/Scripts/libraries/webkitcorepy/webkitcorepy/__init__.py Log Message: --- python autoinstaller is broken with python 3.12 https://bugs.webkit.org/show_bug.cgi?id=260726 Reviewed by NOBODY (OOPS!). Currently git-webkit is broken with python 3.12 due to various problems with dependencies that are already fixed in newer upstream versions. So, update a few things. Unfortunately, the newer library versions are incompatible with other Python versions, so this means more conditional versions. * Tools/Scripts/libraries/webkitcorepy/webkitcorepy/__init__.py: Canonical link: https://commits.webkit.org/266719.23@webkitglib/2.42 Commit: 13de864f3a2845135778bc646a00cbf7becb384e https://github.com/WebKit/WebKit/commit/13de864f3a2845135778bc646a00cbf7becb384e Author: Michael Catanzaro Date: 2023-08-28 (Mon, 28 Aug 2023) Changed paths: M Source/WebCore/bindings/js/ScriptController.cpp M Source/WebKit/UIProcess/API/C/WKPage.cpp M Source/WebKit/UIProcess/API/glib/WebKitWebView.cpp M Source/WebKit/UIProcess/Inspector/socket/RemoteInspectorProtocolHandler.cpp Log Message: --- Cherry-pick 267352@main (3b7c5108fac6). https://bugs.webkit.org/show_bug.cgi?id=260361 Transient activation should be dropped after evaluating JavaScript, except when required for application compatibility https://bugs.webkit.org/show_bug.cgi?id=260361 Reviewed by Carlos Garcia Campos. This is a follow-up to bug #258037 and bug #251276. When a user interacts with a web page, the page is said to receive a user gesture and this grants additional permissions to the web content until the "transient activation" period expires, which in WebKit is 5 seconds. WebKit's API functions that allow applications to run JavaScript allow the application to force a user gesture in order to execute JS with full permissions. But in this case, the transient activation should expire immediately because the user did not really interact with the page. Web content should not unexpectedly receive additional permissions for 5 seconds whenever the application runs some of its own unrelated JS. Bug #258037 and bug #251276 fixed this for freshly built applications on Cocoa platforms, but left other platforms unchanged because dropping the transient activation is not backwards-compatible and coulde possibly cause unknown breakage in applications. But the desired behavior is to always drop transient activation. Implement this everywhere: (1) In RemoteInspectorProtocolHandler.cpp, affecting JS executed by remote inspector. This change is surely safe. (2) In WebKitWebView.cpp, affecting the GTK and WPE port. This could possibly break GTK/WPE applications, so we won't backport it to the 2.40 stable branch. (3) In WKPageRunJavaScriptInMainFrame, affecting non-Cocoa ports. This should be safe because the C API is not public except for Windows and PlayStation ports, which control the version of WebKit they ship. (4) And finally in ScriptController::executeScriptIgnoringException. This will affect all ports and could possibly break things. * Source/WebCore/bindings/js/ScriptController.cpp: (WebCore::ScriptController::executeScriptInWorldIgnoringException): * Source/WebKit/UIProcess/API/C/WKPage.cpp: (WKPageRunJavaScriptInMainFrame): * Source/WebKit/UIProcess/API/glib/WebKitWebView.cpp: (webkitWebViewRunJavascriptWithoutForcedUserGestures): (webkitWebViewEvaluateJavascriptInternal): (webkitWebViewCallAsyncJavascriptFunctionInternal): (resourcesStreamReadCallback): * Source/WebKit/UIProcess/Inspector/socket/RemoteInspectorProtocolHandler.cpp: (WebKit::RemoteInspectorProtocolHandler::runScript): Canonical link: https://commits.webkit.org/267352@main Canonical link: https://commits.webkit.org/266719.24@webkitglib/2.42 Commit: 20cfdaf8fd3aa2e418a9702bf0d4621b4c50b4de https://github.com/WebKit/WebKit/commit/20cfdaf8fd3aa2e418a9702bf0d4621b4c50b4de Author: Carlos Garcia Campos Date: 2023-08-28 (Mon, 28 Aug 2023) Changed paths: M Source/WebCore/platform/graphics/gbm/GBMBufferSwapchain.cpp M Source/WebKit/WebProcess/WebPage/gtk/AcceleratedSurfaceDMABuf.cpp Log Message: --- Cherry-pick 267070@main (75237ef8a286). https://bugs.webkit.org/show_bug.cgi?id=260431 [GTK][WPE] Pass GBM_BO_USE_RENDERING to gbm_bo_create https://bugs.webkit.org/show_bug.cgi?id=260431 Reviewed by Michael Catanzaro. I suspect nvidia GBM implementation defaults to GBM_BO_USE_SCANOUT when
